Timeline
Feb 23, 2016:
- 11:20 PM Changeset in webkit [197018] by
-
- 3 edits in trunk/Source/WebCore
Support building LocaleICU with light ICU (UCONFIG_NO_FORMATTING)
https://bugs.webkit.org/show_bug.cgi?id=154484
Patch by Olivier Blin <Olivier Blin> on 2016-02-23
Reviewed by Darin Adler.
In this mode, this makes LocaleICU with UCONFIG_NO_FORMATTING
essentially the same as LocaleNone, but allows to keep using ICU for
other features.
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::LocaleICU):
(WebCore::LocaleICU::~LocaleICU):
(WebCore::LocaleICU::initializeLocaleData):
- platform/text/LocaleICU.h:
- 11:11 PM Changeset in webkit [197017] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: don't run the protocol generator once per output file
https://bugs.webkit.org/show_bug.cgi?id=154635
Reviewed by Myles C. Maxfield.
- DerivedSources.make: Use $(firstword, ...) to take just one file as
the target to be built so that the generator runs only once. Make isn't
really designed to coalesce multiple file outputs to one production rule.
- 11:07 PM Changeset in webkit [197016] by
-
- 9 edits3 deletes in trunk/Source/WebCore
Remove dead FontLoader code
https://bugs.webkit.org/show_bug.cgi?id=154625
Reviewed by Darin Adler.
This code has been replaced by FontFaceSet.
No new tests because there is no behavior change.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/FontLoader.cpp: Removed.
(WebCore::LoadFontCallback::create): Deleted.
(WebCore::LoadFontCallback::createFromParams): Deleted.
(WebCore::LoadFontCallback::~LoadFontCallback): Deleted.
(WebCore::LoadFontCallback::familyCount): Deleted.
(WebCore::LoadFontCallback::LoadFontCallback): Deleted.
(WebCore::LoadFontCallback::notifyLoaded): Deleted.
(WebCore::LoadFontCallback::notifyError): Deleted.
(WebCore::FontLoader::loadFontDone): Deleted.
(WebCore::FontLoader::FontLoader): Deleted.
(WebCore::FontLoader::~FontLoader): Deleted.
(WebCore::FontLoader::eventTargetData): Deleted.
(WebCore::FontLoader::ensureEventTargetData): Deleted.
(WebCore::FontLoader::eventTargetInterface): Deleted.
(WebCore::FontLoader::scriptExecutionContext): Deleted.
(WebCore::FontLoader::didLayout): Deleted.
(WebCore::FontLoader::activeDOMObjectName): Deleted.
(WebCore::FontLoader::canSuspendForDocumentSuspension): Deleted.
(WebCore::FontLoader::scheduleEvent): Deleted.
(WebCore::FontLoader::firePendingEvents): Deleted.
(WebCore::FontLoader::beginFontLoading): Deleted.
(WebCore::FontLoader::fontLoaded): Deleted.
(WebCore::FontLoader::loadError): Deleted.
(WebCore::FontLoader::notifyWhenFontsReady): Deleted.
(WebCore::FontLoader::loadingDone): Deleted.
(WebCore::FontLoader::loadFont): Deleted.
(WebCore::FontLoader::checkFont): Deleted.
(WebCore::applyPropertyToCurrentStyle): Deleted.
(WebCore::FontLoader::resolveFontStyle): Deleted.
- css/FontLoader.h: Removed.
- css/FontLoader.idl: Removed.
- page/FrameView.cpp:
- 11:05 PM Changeset in webkit [197015] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo][MediaFoundation] Implement methods to set volume.
https://bugs.webkit.org/show_bug.cgi?id=154580
Reviewed by Alex Christensen.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::paused):
(WebCore::MediaPlayerPrivateMediaFoundation::setVolume):
(WebCore::MediaPlayerPrivateMediaFoundation::supportsMuting):
(WebCore::MediaPlayerPrivateMediaFoundation::setMuted):
(WebCore::MediaPlayerPrivateMediaFoundation::networkState):
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
- 11:04 PM Changeset in webkit [197014] by
-
- 13 edits in trunk
[Reflected] IDL attributes of integer types should use HTML rules for parsing integers
https://bugs.webkit.org/show_bug.cgi?id=154573
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C HTML tests now that more checks are passing.
- web-platform-tests/html/dom/reflection-embedded-expected.txt:
- web-platform-tests/html/dom/reflection-forms-expected.txt:
- web-platform-tests/html/dom/reflection-grouping-expected.txt:
- web-platform-tests/html/dom/reflection-metadata-expected.txt:
- web-platform-tests/html/dom/reflection-misc-expected.txt:
- web-platform-tests/html/dom/reflection-obsolete-expected.txt:
- web-platform-tests/html/dom/reflection-sections-expected.txt:
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
- web-platform-tests/html/dom/reflection-text-expected.txt:
Source/WebCore:
[Reflected] IDL attributes of integer types should use HTML rules for
parsing integers:
Those rules are defined here:
- https://html.spec.whatwg.org/#rules-for-parsing-integers
- https://html.spec.whatwg.org/#rules-for-parsing-non-negative-integers
We already had an implementation for parsing HTML integers but our reflected
attributes currently use WTFString::toInt() / toUint() instead.
No new tests, already covered by existing tests.
- dom/Element.cpp:
(WebCore::Element::getIntegralAttribute):
This method used by the bindings only, for reflected IDL attributed of
type 'long'. Now call parseHTMLInteger() instead of String::toInt() to
parse the content attribute as per the HTML specification.
(WebCore::Element::getUnsignedIntegralAttribute):
This method used by the bindings only, for reflected IDL attributed of
type 'unsigned long'. Now call parseHTMLNonNegativeInteger() instead of
String::toUInt() to parse the content attribute as per the HTML
specification.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLIntegerInternal):
Fix a bug in our implementation of parseHTMLIntegerInternal() that
would cause the string "−2147483648" to be parsed as 0. It should
be parsed as −2147483648, which is in the valid range as per:
http://heycam.github.io/webidl/#idl-long
- 10:43 PM Changeset in webkit [197013] by
-
- 21 edits in trunk/Source/JavaScriptCore
Web Inspector: teach the Objective-C protocol generators about --frontend and --backend directives
https://bugs.webkit.org/show_bug.cgi?id=154615
<rdar://problem/24804330>
Reviewed by Timothy Hatcher.
Some of the generated Objective-C bindings are only relevant to code acting as the
protocol backend. Add a per-generator setting mechanism and propagate --frontend and
--backend to all generators. Use the setting in a few generators to omit code that's
not needed.
Also fix a few places where the code emits the wrong Objective-C class prefix.
There is some common non-generated code that must always have the RWIProtocol prefix.
Lastly, change includes to use RWIProtocolJSONObjectPrivate.h instead of *Internal.h. The
macros defined in the internal header now need to be used outside of the framework.
- inspector/scripts/codegen/generate_objc_conversion_helpers.py:
Use OBJC_STATIC_PREFIX along with the file name and use different include syntax
depending on the target framework.
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator.generate_output):
For now, omit generating command protocol and event dispatchers when generating for --frontend.
(ObjCHeaderGenerator._generate_type_interface):
Use OBJC_STATIC_PREFIX along with the unprefixed file name.
- inspector/scripts/codegen/generate_objc_internal_header.py:
Use RWIProtocolJSONObjectPrivate.h instead.
- inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
(ObjCProtocolTypesImplementationGenerator.generate_output):
Include the Internal header if it's being generated (only for --backend).
- inspector/scripts/codegen/generator.py:
(Generator.init):
(Generator.set_generator_setting):
(Generator):
(Generator.get_generator_setting):
Crib a simple setting system from the Framework class. Make the names more obnoxious.
(Generator.string_for_file_include):
Inspired by the replay input generator, this is a function that uses the proper syntax
for a file include depending on the file's framework and target framework.
- inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator.and):
(ObjCGenerator.and.objc_prefix):
(ObjCGenerator):
(ObjCGenerator.objc_type_for_raw_name):
(ObjCGenerator.objc_class_for_raw_name):
Whitelist the 'Automation' domain for the ObjC generators. Revise use of OBJC_STATIC_PREFIX.
- inspector/scripts/generate-inspector-protocol-bindings.py:
(generate_from_specification):
Change the generators to use for the frontend. Propagate --frontend and --backend.
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
Rebaseline tests. They now correctly include RWIProtocolJSONObject.h and the like.
- 9:15 PM Changeset in webkit [197012] by
-
- 5 edits14 adds in trunk
Align our implementation of Range.createContextualFragment with the specification
https://bugs.webkit.org/show_bug.cgi?id=154627
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline as one more check is passing.
- web-platform-tests/dom/nodes/Node-contains-xhtml-expected.txt:
Source/WebCore:
Align our implementation of Range.createContextualFragment with the
specification:
In particular, if the Range's start node is a Document / DocumentFragment,
we now create a new HTMLBodyElement and use it as context element, instead
of throwing an exception.
This also aligns our behavior with Firefox and Chrome.
Tests: imported/blink/fast/dom/Range/create-contextual-fragment-from-bodyless-document-range.html
imported/blink/fast/dom/Range/create-contextual-fragment-from-detached-text-node-range.html
imported/blink/fast/dom/Range/create-contextual-fragment-from-document-fragment-range.html
imported/blink/fast/dom/Range/create-contextual-fragment-from-document-range.html
imported/blink/fast/dom/Range/create-contextual-fragment-from-xhtml-document-range.xhtml
imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran.html
imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html
- dom/Range.cpp:
(WebCore::Range::createContextualFragment):
LayoutTests:
Import some more layout tests from blink to improve coverage for
Range.createContextualFragment().
- imported/blink/fast/dom/Range/create-contextual-fragment-from-bodyless-document-range-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-bodyless-document-range.html: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-detached-text-node-range-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-detached-text-node-range.html: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-document-fragment-range-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-document-fragment-range.html: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-document-range-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-document-range.html: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-xhtml-document-range-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-from-xhtml-document-range.xhtml: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-not-ran.html: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started-expected.txt: Added.
- imported/blink/fast/dom/Range/create-contextual-fragment-script-unmark-already-started.html: Added.
- 8:39 PM Changeset in webkit [197011] by
-
- 2 edits in trunk/Source/JavaScriptCore
arrayProtoFuncConcat doesn't check for an exception after allocating an array
https://bugs.webkit.org/show_bug.cgi?id=154621
Reviewed by Michael Saboff.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat):
- 8:26 PM Changeset in webkit [197010] by
-
- 24 edits in trunk
[Xcode] Linker errors display mangled names, but no longer should
https://bugs.webkit.org/show_bug.cgi?id=154632
Reviewed by Sam Weinig.
Source/bmalloc:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/WebCore:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/WebInspectorUI:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/WebKit/mac:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/WebKit2:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Source/WTF:
- Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
Tools:
- ContentExtensionTester/Configurations/Base.xcconfig: Stop setting LINKER_DISPLAYS_MANGLED_NAMES to YES.
- DumpRenderTree/mac/Configurations/Base.xcconfig: Ditto.
- LayoutTestRelay/Configurations/Base.xcconfig: Ditto.
- MiniBrowser/Configurations/Base.xcconfig: Ditto.
- TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
- WebEditingTester/Configurations/Base.xcconfig: Ditto.
- WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
- 5:57 PM Changeset in webkit [197009] by
-
- 21 edits in trunk/Source
Source/JavaScriptCore:
Remove HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define
https://bugs.webkit.org/show_bug.cgi?id=112323
Reviewed by Chris Dumez.
This feature is controlled by a runtime switch, and defaults off.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
[WebGL] iOS doesn't respect the alpha:false context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=154617
<rdar://problem/13417023>
Patch by Dean Jackson <dino@apple.com> on 2016-02-23
Reviewed by Sam Weinig.
On iOS we were not respecting the alpha:false context creation
attribute, which meant you always got output that could
have an alpha channel.
The good news is that now we're setting the opaque flag on
the CALayer, there should be a performance improvement when
compositing WebGL into the page.
Test: fast/canvas/webgl/context-attributes-alpha.html
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): Don't tell the layer
to be transparent.
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable): Do it
here instead, but based on the value of the alpha attribute.
Source/WebKit/mac:
Remove HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define
https://bugs.webkit.org/show_bug.cgi?id=112323
Reviewed by Chris Dumez.
This feature is controlled by a runtime switch, and defaults off.
- Configurations/FeatureDefines.xcconfig:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Remove HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define
https://bugs.webkit.org/show_bug.cgi?id=112323
Reviewed by Chris Dumez.
This feature is controlled by a runtime switch, and defaults off.
- Configurations/FeatureDefines.xcconfig:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
Remove HIDDEN_PAGE_DOM_TIMER_THROTTLING feature define
https://bugs.webkit.org/show_bug.cgi?id=112323
Reviewed by Chris Dumez.
This feature is controlled by a runtime switch, and defaults off.
- wtf/FeatureDefines.h:
- 5:21 PM Changeset in webkit [197008] by
-
- 3 edits2 adds in trunk
[WebGL] iOS doesn't respect the alpha:false context creation attribute
https://bugs.webkit.org/show_bug.cgi?id=154617
<rdar://problem/13417023>
Reviewed by Sam Weinig.
Source/WebCore:
On iOS we were not respecting the alpha:false context creation
attribute, which meant you always got output that could
have an alpha channel.
The good news is that now we're setting the opaque flag on
the CALayer, there should be a performance improvement when
compositing WebGL into the page.
Test: fast/canvas/webgl/context-attributes-alpha.html
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D): Don't tell the layer
to be transparent.
(WebCore::GraphicsContext3D::setRenderbufferStorageFromDrawable): Do it
here instead, but based on the value of the alpha attribute.
LayoutTests:
Add a test that draws contexts with and without alpha, and then a reference
version that hard-codes the non-alpha colors.
- fast/canvas/webgl/context-attributes-alpha-expected.html: Added.
- fast/canvas/webgl/context-attributes-alpha.html: Added.
- 4:53 PM Changeset in webkit [197007] by
-
- 8 edits1 copy8 adds in trunk
CSP: Enable base-uri directive by default
https://bugs.webkit.org/show_bug.cgi?id=154521
<rdar://problem/24762032>
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: http/tests/security/contentSecurityPolicy/1.1/base-uri-default-ignored.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-base-uri-deny.html
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::isExperimentalDirectiveName): Move base-uri from the directives considered
experimental to...
(WebCore::isCSPDirectiveName): ...the list of standard directives.
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Move logic to parse the base-uri
directive outside the ENABLE(CSP_NEXT) macro guarded section/experimental feature runtime flag.
LayoutTests:
Copy test http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html to
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-base-uri-deny.html,
making some minor stylistic changes, and update TestExpectations to skip it because it depends
on the firing of event SecurityPolicyViolationEvent, which is disabled as of the time of writing.
We will enable the firing of this event in <https://bugs.webkit.org/show_bug.cgi?id=154522>.
Repurpose test name base-uri-deny.html to test that the base-uri directive prevents the use of
document base URL without depending on the firing of event SecurityPolicyViolationEvent.
Additionally, add test http/tests/security/contentSecurityPolicy/1.1/base-uri-default-ignored.html
to ensure that we do not fall back to enforcing the default-src directive in absence of
a base-uri directive as per section base-uri of the Content Security Policy 2.0 spec.,
<https://www.w3.org/TR/2015/CR-CSP2-20150721/>.
- TestExpectations:
- http/tests/security/contentSecurityPolicy/1.1/base-uri-default-ignored-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/base-uri-default-ignored.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/base-uri-deny-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html: Repurpose test.
- http/tests/security/contentSecurityPolicy/1.1/resources/base-href/resources/safe-script.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/safe-script.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-base-uri-deny-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/base-uri-deny-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-base-uri-deny.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html.
- http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt: Update expected result based on change to test (below).
- http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html: Modified to test that we emit
a console warning when base-uri is used as a source expression.
- 4:32 PM Changeset in webkit [197006] by
-
- 5 edits in trunk/Source/WebCore
Add a mechanism to automatically ramp up timer alignment.
https://bugs.webkit.org/show_bug.cgi?id=154578
Reviewed by Antti Koivisto & Chris Dumez.
Allow timer alignment duration to be proportional to the time the page
has been hidden. This implementation does so by scaling up the throttle
in exponential steps, spaced exponentially far apart.
- page/Page.cpp:
(WebCore::Page::Page):
- initialize timer.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged):
- if setting are changed fully disable/reenable to ensure new setting are read.
(WebCore::Page::setTimerThrottlingEnabled):
- enebled bool flag converted to an Optional<double>, tracking time throttling is enabled.
(WebCore::Page::setDOMTimerAlignmentInterval):
- when new mechanism is enabled schedule a timer to step up alignment.
(WebCore::Page::timerAlignmentIntervalIncreaseTimerFired):
- when timer fires increase alignment.
- page/Page.h:
- added new member.
- page/Settings.cpp:
(WebCore::Settings::Settings):
- initialize new member.
(WebCore::Settings::setHiddenPageDOMTimerThrottlingAutoIncreaseLimit):
- added, update new setting. Setting to zero disabled. A non-zero value is a duration in seconds for timer throttling to ramp up to.
- page/Settings.h:
(WebCore::Settings::hiddenPageDOMTimerThrottlingAutoIncreases):
- read as boolean whether throttle increasing is enabled.
(WebCore::Settings::hiddenPageDOMTimerThrottlingAutoIncreaseLimit):
- read throttle increasing limit.
- 4:30 PM Changeset in webkit [197005] by
-
- 2 edits in trunk/Source/WebCore
Refactor script that updates fullscreen buttons.
https://bugs.webkit.org/show_bug.cgi?id=154562
Reviewed by Dean Jackson.
Also expose extra property and element in getCurrentControlsStatus() for future testing.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.updatePictureInPictureButton):
(Controller.prototype.updateFullscreenButtons):
- 4:20 PM Changeset in webkit [197004] by
-
- 6 edits in trunk
WKWebView should implement NSCoding
https://bugs.webkit.org/show_bug.cgi?id=137160
Source/WebKit2:
rdar://problem/17380562
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController initWithCoder:]):
We need to call [self init] here, so that the wrapper will be initialized.
- UIProcess/API/Cocoa/WKWebView.h:
-initWithCoder: shouldn't be unavailable, it should be a designated initializer.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
Move initialization out into a common method.
(-[WKWebView initWithFrame:configuration:]):
Call -initializeWithConfiguration: here.
(-[WKWebView initWithCoder:]):
Decode everything.
(-[WKWebView encodeWithCoder:]):
Encode everything.
Tools:
Reviewed by Dan Bernstein.
Add tests.
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):
- 3:41 PM Changeset in webkit [197003] by
-
- 2 edits in trunk/Source/WebKit2
Fix an API test.
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::defaultDataStore):
Make sure to initialize WebKit2.
- 3:05 PM Changeset in webkit [197002] by
-
- 2 edits in trunk/Source/WebKit2
WKWebViewConfiguration should encode more of its properties
https://bugs.webkit.org/show_bug.cgi?id=154611
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
- 3:03 PM Changeset in webkit [197001] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSC stress tests' standalone-pre.js should exit on the first failure by default
https://bugs.webkit.org/show_bug.cgi?id=154565
Reviewed by Mark Lam.
Currently, if a test writer does not call finishJSTest() at the end of
any test using stress/resources/standalone-pre.js then the test can fail
without actually reporting an error to the harness. By default, we
should throw on the first error so, in the event someone does not call
finishJSTest() the harness will still notice the error.
- tests/stress/regress-151324.js:
- tests/stress/resources/standalone-pre.js:
(testFailed):
- 2:54 PM Changeset in webkit [197000] by
-
- 3 edits in trunk/Source/WebKit2
WKUserContentController should conform to NSCoding
https://bugs.webkit.org/show_bug.cgi?id=154609
Reviewed by Sam Weinig.
Since we just want to be able to encode WKUserContentController from WKWebViewConfiguration,
we don't encode anything inside WKUserContentController.
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController encodeWithCoder:]):
(-[WKUserContentController initWithCoder:]):
- 2:41 PM Changeset in webkit [196999] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make JSObject::getMethod have fewer branches
https://bugs.webkit.org/show_bug.cgi?id=154603
Reviewed by Mark Lam.
Writing code with fewer branches is almost always better.
- runtime/JSObject.cpp:
(JSC::JSObject::getMethod):
- 2:35 PM Changeset in webkit [196998] by
-
- 6 edits6 adds in trunk
Calling importNode on shadow root causes a crash
https://bugs.webkit.org/show_bug.cgi?id=154570
Reviewed by Anders Carlsson.
Source/WebCore:
The bug was caused by a missing check in cloneNode. Added cloneNodeForBindings to explicitly throw
an NotSupportedError when it's called on a shadow root. We don't clone shadow root when deep-cloning
the tree so we don't have to check that condition.
The behavior of cloneNode is specified at:
http://w3c.github.io/webcomponents/spec/shadow/#the-shadowroot-interface
(it current says we should throw DATA_CLONE_ERR but I have an spec bug filed at
https://github.com/w3c/webcomponents/issues/393)
The behavior of importNode and adoptNode are specified in DOM4 specification:
https://dom.spec.whatwg.org/#dom-document-importnode
https://dom.spec.whatwg.org/#dom-document-adoptnode
Tests: fast/shadow-dom/Document-prototype-adoptNode.html
fast/shadow-dom/Document-prototype-importNode.html
fast/shadow-dom/Node-prototype-cloneNode.html
- dom/Document.cpp:
(WebCore::Document::importNode): Throw NotSupportedError when importing a shadow root.
- dom/Node.cpp:
(WebCore::Node::cloneNodeForBindings): Added.
- dom/Node.h:
- dom/Node.idl: Use cloneNodeForBindings here.
LayoutTests:
Added W3C-style testharness tests for calling cloneNode on a shadow root.
Also added tests for adoptNode and importNode.
- fast/shadow-dom/Document-prototype-adoptNode-expected.txt: Added.
- fast/shadow-dom/Document-prototype-adoptNode.html: Added.
- fast/shadow-dom/Document-prototype-importNode-expected.txt: Added.
- fast/shadow-dom/Document-prototype-importNode.html: Added.
- fast/shadow-dom/Node-prototype-cloneNode-expected.txt: Added.
- fast/shadow-dom/Node-prototype-cloneNode.html: Added.
- 2:29 PM Changeset in webkit [196997] by
-
- 6 edits in trunk
WKProcessPool should conform to NSCoding
https://bugs.webkit.org/show_bug.cgi?id=154608
Reviewed by Sam Weinig.
Source/WebKit2:
Add +[WKProcessPool _sharedProcessPool] and encode/decode whether the process pool is shared.
- UIProcess/API/Cocoa/WKProcessPool.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool encodeWithCoder:]):
(-[WKProcessPool initWithCoder:]):
(+[WKProcessPool _sharedProcessPool]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
Tools:
Add tests.
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):
- 2:17 PM Changeset in webkit [196996] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3::Value doesn't self-destruct virtually enough (Causes many leaks in LowerDFGToB3::appendOSRExit)
https://bugs.webkit.org/show_bug.cgi?id=154592
Reviewed by Saam Barati.
If Foo has a virtual destructor, then:
foo->Foo::~Foo() does a non-virtual call to Foo's destructor. Even if foo points to a
subclass of Foo that overrides the destructor, this syntax will not call that override.
foo->~Foo() does a virtual call to the destructor, and so if foo points to a subclass, you
get the subclass's override.
In B3, we used this->Value::~Value() thinking that it would call the subclass's override.
This caused leaks because this didn't actually call the subclass's override. This fixes the
problem by using this->~Value() instead.
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::convertToOops):
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithPhi):
- 2:08 PM Changeset in webkit [196995] by
-
- 5 edits in trunk
WKWebsiteDataStore should conform to NSCoding
https://bugs.webkit.org/show_bug.cgi?id=154605
Reviewed by Dan Bernstein.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore initWithCoder:]):
(-[WKWebsiteDataStore encodeWithCoder:]):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):
- 1:49 PM Changeset in webkit [196994] by
-
- 2 edits in trunk/Source/WebKit2
Fix iOS build.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration initWithCoder:]):
- 1:49 PM Changeset in webkit [196993] by
-
- 25 edits in trunk/Source/JavaScriptCore
Web Inspector: the protocol generator's Objective-C name prefix should be configurable
https://bugs.webkit.org/show_bug.cgi?id=154596
<rdar://problem/24794962>
Reviewed by Timothy Hatcher.
In order to support different generated protocol sets that don't have conflicting
file and type names, allow the Objective-C prefix to be configurable based on the
target framework. Each name also has the implicit prefix 'Protocol' appended to the
per-target framework prefix.
For example, the existing protocol for remote inspection has the prefix 'RWI'
and is generated as 'RWIProtocol'. The WebKit framework has the 'Automation' prefix
and is generated as 'AutomationProtocol'.
To make this change, convert ObjCGenerator to be a subclass of Generator and use
the instance method model() to find the target framework and its setting for
'objc_prefix'. Make all ObjC generators subclass ObjCGenerator so they can use
these instance methods that used to be static methods. This is a large but
mechanical change to use self instead of ObjCGenerator.
- inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py:
(ObjCBackendDispatcherHeaderGenerator):
(ObjCBackendDispatcherHeaderGenerator.init):
(ObjCBackendDispatcherHeaderGenerator.output_filename):
(ObjCBackendDispatcherHeaderGenerator._generate_objc_forward_declarations):
(ObjCBackendDispatcherHeaderGenerator._generate_objc_handler_declarations_for_domain):
- inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:
(ObjCConfigurationImplementationGenerator):
(ObjCConfigurationImplementationGenerator.init):
(ObjCConfigurationImplementationGenerator.output_filename):
(ObjCConfigurationImplementationGenerator.generate_output):
(ObjCConfigurationImplementationGenerator._generate_success_block_for_command):
(ObjCConfigurationImplementationGenerator._generate_success_block_for_command.and):
(ObjCConfigurationImplementationGenerator._generate_conversions_for_command):
- inspector/scripts/codegen/generate_objc_configuration_header.py:
(ObjCConfigurationHeaderGenerator):
(ObjCConfigurationHeaderGenerator.init):
(ObjCConfigurationHeaderGenerator.output_filename):
(ObjCConfigurationHeaderGenerator.generate_output):
(ObjCConfigurationHeaderGenerator._generate_configuration_interface_for_domains):
(ObjCConfigurationHeaderGenerator._generate_properties_for_domain):
- inspector/scripts/codegen/generate_objc_configuration_implementation.py:
(ObjCBackendDispatcherImplementationGenerator):
(ObjCBackendDispatcherImplementationGenerator.init):
(ObjCBackendDispatcherImplementationGenerator.output_filename):
(ObjCBackendDispatcherImplementationGenerator.generate_output):
(ObjCBackendDispatcherImplementationGenerator._generate_configuration_implementation_for_domains):
(ObjCBackendDispatcherImplementationGenerator._generate_ivars):
(ObjCBackendDispatcherImplementationGenerator._generate_handler_setter_for_domain):
(ObjCBackendDispatcherImplementationGenerator._generate_event_dispatcher_getter_for_domain):
- inspector/scripts/codegen/generate_objc_conversion_helpers.py:
(ObjCConversionHelpersGenerator):
(ObjCConversionHelpersGenerator.init):
(ObjCConversionHelpersGenerator.output_filename):
(ObjCConversionHelpersGenerator.generate_output):
(ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_declaration):
(ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_member):
(ObjCConversionHelpersGenerator._generate_anonymous_enum_conversion_for_parameter):
- inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:
(ObjCFrontendDispatcherImplementationGenerator):
(ObjCFrontendDispatcherImplementationGenerator.init):
(ObjCFrontendDispatcherImplementationGenerator.output_filename):
(ObjCFrontendDispatcherImplementationGenerator.generate_output):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_dispatcher_implementations):
(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event.and):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_signature):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):
- inspector/scripts/codegen/generate_objc_header.py:
(ObjCHeaderGenerator):
(ObjCHeaderGenerator.init):
(ObjCHeaderGenerator.output_filename):
(ObjCHeaderGenerator.generate_output):
(ObjCHeaderGenerator._generate_forward_declarations):
(ObjCHeaderGenerator._generate_anonymous_enum_for_declaration):
(ObjCHeaderGenerator._generate_anonymous_enum_for_member):
(ObjCHeaderGenerator._generate_anonymous_enum_for_parameter):
(ObjCHeaderGenerator._generate_type_interface):
(ObjCHeaderGenerator._generate_init_method_for_required_members):
(ObjCHeaderGenerator._generate_member_property):
(ObjCHeaderGenerator._generate_command_protocols):
(ObjCHeaderGenerator._generate_single_command_protocol):
(ObjCHeaderGenerator._callback_block_for_command):
(ObjCHeaderGenerator._generate_event_interfaces):
(ObjCHeaderGenerator._generate_single_event_interface):
- inspector/scripts/codegen/generate_objc_internal_header.py:
(ObjCInternalHeaderGenerator):
(ObjCInternalHeaderGenerator.init):
(ObjCInternalHeaderGenerator.output_filename):
(ObjCInternalHeaderGenerator.generate_output):
(ObjCInternalHeaderGenerator._generate_event_dispatcher_private_interfaces):
- inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:
(ObjCProtocolTypesImplementationGenerator):
(ObjCProtocolTypesImplementationGenerator.init):
(ObjCProtocolTypesImplementationGenerator.output_filename):
(ObjCProtocolTypesImplementationGenerator.generate_output):
(ObjCProtocolTypesImplementationGenerator.generate_type_implementation):
(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_required_members):
(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_required_members.and):
(ObjCProtocolTypesImplementationGenerator._generate_setter_for_member):
(ObjCProtocolTypesImplementationGenerator._generate_setter_for_member.and):
(ObjCProtocolTypesImplementationGenerator._generate_getter_for_member):
- inspector/scripts/codegen/models.py:
- inspector/scripts/codegen/objc_generator.py:
(ObjCTypeCategory.category_for_type):
(ObjCGenerator):
(ObjCGenerator.init):
(ObjCGenerator.objc_prefix):
(ObjCGenerator.objc_name_for_type):
(ObjCGenerator.objc_enum_name_for_anonymous_enum_declaration):
(ObjCGenerator.objc_enum_name_for_anonymous_enum_member):
(ObjCGenerator.objc_enum_name_for_anonymous_enum_parameter):
(ObjCGenerator.objc_enum_name_for_non_anonymous_enum):
(ObjCGenerator.objc_class_for_type):
(ObjCGenerator.objc_class_for_array_type):
(ObjCGenerator.objc_accessor_type_for_member):
(ObjCGenerator.objc_accessor_type_for_member_internal):
(ObjCGenerator.objc_type_for_member):
(ObjCGenerator.objc_type_for_member_internal):
(ObjCGenerator.objc_type_for_param):
(ObjCGenerator.objc_type_for_param_internal):
(ObjCGenerator.objc_protocol_export_expression_for_variable):
(ObjCGenerator.objc_protocol_import_expression_for_member):
(ObjCGenerator.objc_protocol_import_expression_for_parameter):
(ObjCGenerator.objc_protocol_import_expression_for_variable):
(ObjCGenerator.objc_to_protocol_expression_for_member):
(ObjCGenerator.protocol_to_objc_expression_for_member):
Change the prefix for the 'Test' target framework to be 'Test.' Rebaseline results.
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- 1:32 PM Changeset in webkit [196992] by
-
- 5 edits in trunk
REGRESSION (r196892): No longer emit error message when CSP form-action directive is used as a source expression
https://bugs.webkit.org/show_bug.cgi?id=154555
<rdar://problem/24776777>
Reviewed by Andy Estes.
Source/WebCore:
Fixes an issue where an error message is not emitted when directive form-action is used as a
source expression. Prior to <http://trac.webkit.org/changeset/196892>, when directive form-action
was used as a source expression a console error message would be emitted with the form:
The Content Security Policy directive 'script-src' contains 'form-action' as a source expression.
Did you mean 'script-src ...; form-action...' (note the semicolon)?
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::isCSPDirectiveName): Return true if the specified directive name is "form-action".
LayoutTests:
Test that we emit a console error message when form-action is used as a source expression.
- http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon.html: Use form-action as a
source expression. Also, use a double quoted (") string literal instead of a single quoted (') string
literal to represent the CSP policy so as to avoid the need to escape embedded single quote characters.
- 1:18 PM Changeset in webkit [196991] by
-
- 14 edits in trunk/Source/WebCore
Lay the groundwork for more constness in StyleResolver-related code
https://bugs.webkit.org/show_bug.cgi?id=154598
Reviewed by Antti Koivisto.
Make some of the leaf functions that are used by the style resolver take
const CSSValues, and use 'auto' more to automatically get const stack variables
when appropriate.
- css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::slices):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isQuirkValue):
- css/FontVariantBuilder.cpp:
(WebCore::extractFontVariantLigatures):
(WebCore::extractFontVariantNumeric):
(WebCore::extractFontVariantEastAsian):
- css/FontVariantBuilder.h:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertReflection):
(WebCore::StyleBuilderConverter::convertGridAutoFlow):
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueSize):
(WebCore::StyleBuilderCustom::applyValueStroke):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::colorFromPrimitiveValueIsDerivedFromElement):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h:
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/TransformFunctions.h:
- rendering/style/StylePendingImage.h:
- svg/SVGLength.cpp:
(WebCore::SVGLength::fromCSSPrimitiveValue):
- svg/SVGLength.h:
- 1:17 PM Changeset in webkit [196990] by
-
- 5 edits in trunk
WKWebViewConfiguration should conform to NSCoding
https://bugs.webkit.org/show_bug.cgi?id=154602
Reviewed by Beth Dakin.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(TEST):
- 12:38 PM Changeset in webkit [196989] by
-
- 4 edits2 copies6 adds in trunk/LayoutTests
Add tests for fast click change in r196679
https://bugs.webkit.org/show_bug.cgi?id=154568
<rdar://problem/24782479>
Reviewed by Myles Maxfield.
Bug http://webkit.org/b/154318 made some changes to the fast
click behaviour, but didn't include any tests. Here they are!
- fast/events/ios/fast-click-double-tap-sends-click-expected.txt: Added.
- fast/events/ios/fast-click-double-tap-sends-click.html: Checks that a double tap on a clickable element sends a click.
- fast/events/ios/fast-click-double-tap-zooms-on-image-expected.txt: Added.
- fast/events/ios/fast-click-double-tap-zooms-on-image.html: Checks that a double tap on an image can trigger a zoom if there
isn't anything else listening.
- fast/events/ios/fast-click-double-tap-zooms-on-text-expected.txt: Added.
- fast/events/ios/fast-click-double-tap-zooms-on-text.html: Checks that a double tap on a block of text can trigger a zoom
if there isn't anything else listening.
- fast/events/ios/no-fast-click-double-tap-causes-zoom-expected.txt: Added.
- fast/events/ios/no-fast-click-double-tap-causes-zoom.html: When we are not in fast click mode, a double tap should
trigger a zoom. This is checking the inverse behaviour to fast-click-double-tap-sends-click.
- fast/events/ios/viewport-device-width-allows-double-tap-zoom-out.html: Removed some code that could never be called.
- fast/events/ios/viewport-zooms-from-element-to-initial-scale.html: Ditto.
- platform/ios-simulator/TestExpectations: Add the new tests.
- 12:09 PM Changeset in webkit [196988] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r192251): http/tests/navigation/page-cache-xhr.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=154589
Reviewed by Youenn Fablet.
- http/tests/navigation/page-cache-xhr.html: Load a file that exists. The content
doesn't matter, as we expect to navigate away before the load occurs.
- http/tests/resources/load-and-stall.cgi: Added cache control, just for a good measure.
- 12:04 PM Changeset in webkit [196987] by
-
- 5 edits1 copy in trunk
WKPreferences should conform to NSCoding
https://bugs.webkit.org/show_bug.cgi?id=154597
Reviewed by Sam Weinig.
Source/WebKit2:
Add NSCoding implementation.
- UIProcess/API/Cocoa/WKPreferences.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
Tools:
Test encoding and decoding WKPreferences.
- TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
(encodeAndDecode):
(TEST):
- 11:41 AM Changeset in webkit [196986] by
-
- 29 edits1 add in trunk
Debug assertion failure while loading http://kangax.github.io/compat-table/es6/.
https://bugs.webkit.org/show_bug.cgi?id=154542
Reviewed by Saam Barati.
Source/JavaScriptCore:
According to the spec, the constructors of the following types "are not intended
to be called as a function and will throw an exception". These types are:
TypedArrays - https://tc39.github.io/ecma262/#sec-typedarray-constructors
Map - https://tc39.github.io/ecma262/#sec-map-constructor
Set - https://tc39.github.io/ecma262/#sec-set-constructor
WeakMap - https://tc39.github.io/ecma262/#sec-weakmap-constructor
WeakSet - https://tc39.github.io/ecma262/#sec-weakset-constructor
ArrayBuffer - https://tc39.github.io/ecma262/#sec-arraybuffer-constructor
DataView - https://tc39.github.io/ecma262/#sec-dataview-constructor
Promise - https://tc39.github.io/ecma262/#sec-promise-constructor
Proxy - https://tc39.github.io/ecma262/#sec-proxy-constructor
This patch does the foillowing:
- Ensures that these constructors can be called but will throw a TypeError when called.
- Makes all these objects use throwConstructorCannotBeCalledAsFunctionTypeError() in their implementation to be consistent.
- Change the error message to "calling XXX constructor without new is invalid". This is clearer because the error is likely due to the user forgetting to use the new operator on these constructors.
- runtime/Error.h:
- runtime/Error.cpp:
(JSC::throwConstructorCannotBeCalledAsFunctionTypeError):
- Added a convenience function to throw the TypeError.
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
(JSC::callArrayBuffer):
(JSC::JSArrayBufferConstructor::getCallData):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::callGenericTypedArrayView):
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
- runtime/JSPromiseConstructor.cpp:
(JSC::callPromise):
- runtime/MapConstructor.cpp:
(JSC::callMap):
- runtime/ProxyConstructor.cpp:
(JSC::callProxy):
(JSC::ProxyConstructor::getCallData):
- runtime/SetConstructor.cpp:
(JSC::callSet):
- runtime/WeakMapConstructor.cpp:
(JSC::callWeakMap):
- runtime/WeakSetConstructor.cpp:
(JSC::callWeakSet):
- tests/es6.yaml:
- The typed_arrays_%TypedArray%[Symbol.species].js test now passes.
- tests/stress/call-non-calleable-constructors-as-function.js: Added.
(test):
- tests/stress/map-constructor.js:
(testCallTypeError):
- tests/stress/promise-cannot-be-called.js:
(shouldThrow):
- tests/stress/proxy-basic.js:
- tests/stress/set-constructor.js:
- tests/stress/throw-from-ftl-call-ic-slow-path-cells.js:
(i.catch):
- tests/stress/throw-from-ftl-call-ic-slow-path-undefined.js:
(i.catch):
- tests/stress/throw-from-ftl-call-ic-slow-path.js:
(i.catch):
- tests/stress/weak-map-constructor.js:
(testCallTypeError):
- tests/stress/weak-set-constructor.js:
- Updated error message string.
LayoutTests:
- js/Promise-types-expected.txt:
- js/basic-map-expected.txt:
- js/basic-set-expected.txt:
- js/dom/basic-weakmap-expected.txt:
- js/dom/basic-weakset-expected.txt:
- js/script-tests/Promise-types.js:
- js/typedarray-constructors-expected.txt:
- Updated error message string.
- 11:38 AM Changeset in webkit [196985] by
-
- 2 edits in trunk/Source/JavaScriptCore
ASan build fix.
Let's not export a template function that is only used in InspectorBackendDispatcher.cpp.
- inspector/InspectorBackendDispatcher.h:
- 11:13 AM Changeset in webkit [196984] by
-
- 15 edits in trunk/Source/WebKit2
Implement downloads with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154473
Reviewed by Brady Eidson.
- NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::~Download):
(WebKit::Download::didStart):
(WebKit::Download::shouldDecodeSourceDataOfMIMEType):
(WebKit::Download::decideDestinationWithSuggestedFilename):
(WebKit::Download::didCreateDestination):
- NetworkProcess/Downloads/Download.h:
(WebKit::Download::downloadID):
(WebKit::Download::setSandboxExtension):
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::dataTaskBecameDownloadTask):
(WebKit::DownloadManager::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::DownloadManager::continueWillSendRequest):
(WebKit::DownloadManager::willDecidePendingDownloadDestination):
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
(WebKit::DownloadManager::convertHandleToDownload):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::clearClient):
NetworkDataTasks can now outlive their client, so we need to make client a pointer
with the ability to be nulled from the client's destructor.
(WebKit::NetworkDataTask::pendingDownloadID):
(WebKit::NetworkDataTask::pendingDownload):
(WebKit::NetworkDataTask::setPendingDownload):
(WebKit::NetworkDataTask::pendingDownloadLocation):
(WebKit::NetworkDataTask::client): Deleted.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::setPendingDownloadID):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
Don't call the didReceiveResponse completion handler immediately when we know we are
going to turn the load into a download. Instead, save the completion handler until
after we have determined the download destination and set it in the NetworkDataTask.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::continueWillSendRequest):
(WebKit::NetworkProcess::findPendingDownloadLocation):
(WebKit::NetworkProcess::continueDecidePendingDownloadDestination):
(WebKit::NetworkProcess::setCacheModel):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::~NetworkDataTask):
(WebKit::NetworkDataTask::didSendData):
(WebKit::NetworkDataTask::didReceiveChallenge):
(WebKit::NetworkDataTask::didCompleteWithError):
(WebKit::NetworkDataTask::didReceiveResponse):
(WebKit::NetworkDataTask::didReceiveData):
(WebKit::NetworkDataTask::didBecomeDownload):
(WebKit::NetworkDataTask::willPerformHTTPRedirection):
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired):
(WebKit::NetworkDataTask::findPendingDownloadLocation):
(WebKit::NetworkDataTask::setPendingDownloadLocation):
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
(WebKit::NetworkDataTask::transferSandboxExtensionToDownload):
(WebKit::NetworkDataTask::currentRequest):
(WebKit::NetworkDataTask::cancel):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:]):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
This delegate callback is used for downloads, too.
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveData:]):
(-[WKNetworkSessionDelegate URLSession:downloadTask:didFinishDownloadingToURL:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
Call didCreateDestination now, which is after the file has been opened on the disk.
A DownloadProxy::DidStart message is now sent from NetworkProcess::findPendingDownloadLocation before
we ask the UIProcess where the download should end up on disk.
Null check the NetworkDataTask's client before using it because it is now a pointer that could be null.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
(WebKit::DownloadProxy::didCreateDestination):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Downloads/DownloadProxy.messages.in:
- 10:17 AM Changeset in webkit [196983] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Avoid duplicated calls to resolution code
https://bugs.webkit.org/show_bug.cgi?id=154336
Reviewed by Sergio Villar Senin.
We were calling GridResolvedPosition::resolveGridPositionsFromStyle()
several times per item.
We can store the GridCoordinates in
RenderGrid::populateExplicitGridAndOrderIterator()
and reuse them in the placement code.
Once RenderGrid::placeItemsOnGrid() is over,
all the items will have a definite position in both axis.
No new tests, no change of behavior.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::cachedGridCoordinate):
(WebCore::RenderGrid::cachedGridSpan):
- rendering/RenderGrid.h:
- 9:57 AM Changeset in webkit [196982] by
-
- 2 edits in trunk/Tools
Fix build.
- TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
(-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]):
- 9:42 AM Changeset in webkit [196981] by
-
- 2 edits in trunk/PerformanceTests
Unreviewed change to revert extraneous changes made part of change set 196955.
- MallocBench/MallocBench/Interpreter.cpp:
(Interpreter::doMallocOp):
(Interpreter::Thread::switchTo):
(writeData): Deleted.
- 9:40 AM Changeset in webkit [196980] by
-
- 6 edits in trunk/Source
Connect WebAutomationSession to its backend dispatcher as if it were an agent and add stub implementations
https://bugs.webkit.org/show_bug.cgi?id=154518
<rdar://problem/24761096>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InspectorBackendDispatcher.h:
Export all the classes since they are used by WebKit::WebAutomationSession.
Source/WebKit2:
Add a domain dispatcher for the 'Automation' domain, and register the
WebAutomationSession itself as the handler for Automation commands.
Stub out these command implementations so the code will compile.
- UIProcess/Automation/Automation.json:
Fix the createWindow command's parameters and description.
Add an ErrorMessage string enumeration and document how it can be used
to signal well-known errors to the frontend.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::WebAutomationSession):
Add the domain backend dispatcher. It further parses commands that were deemed
valid by the generic dispatcher and match the 'Automation' domain prefix.
(WebKit::WebAutomationSession::getWindows):
(WebKit::WebAutomationSession::openWindow):
(WebKit::WebAutomationSession::closeWindow):
Stub these out with our new ErrorMessage enumeration and a macro to
make this code pattern more readable.
- UIProcess/Automation/WebAutomationSession.h:
Add new declarations and members.
- 9:38 AM Changeset in webkit [196979] by
-
- 7 edits2 adds in trunk/Tools
[GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.
https://bugs.webkit.org/show_bug.cgi?id=153993
Reviewed by Carlos Garcia Campos.
- MiniBrowser/gtk/main.c:
(createBrowserWindow): Support --geometry argument for MiniBrowser.
We use this on the gtk_minibrowser_driver script to start the MiniBrowser maximized.
- Scripts/webkitpy/benchmark_runner/browser_driver/init.py: Fix loading of subclasses:
The base class has to be loaded first, otherwise any subclase referencing it will give import error.
In OSX the ordering of os.listdir() causes the base class (browser_driver.py) to be first on the list, but not on Linux.
By specifiying the name of the base class file, we ensure it is always loaded first on any system despite the ordering of listdir.
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
(BrowserDriverFactory.create):
- Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py: Added.
(GTKBrowserDriver):
(GTKBrowserDriver.prepare_env):
(GTKBrowserDriver.restore_env):
(GTKBrowserDriver.close_browsers):
(GTKBrowserDriver._launch_process):
(GTKBrowserDriver._terminate_processes):
(GTKBrowserDriver._screen_size):
- Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py: Added.
(GTKMiniBrowserDriver):
(GTKMiniBrowserDriver.prepare_env):
(GTKMiniBrowserDriver.launch_url):
(GTKMiniBrowserDriver.close_browsers):
- Scripts/webkitpy/benchmark_runner/http_server_driver/init.py: Fix loading of subclasses. See description above.
- Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver.kill_server): Check if the server is still running before trying to terminate it.
Usually the server ends gracefully (no need to terminate it), so this was causing ugly errors on the log.
- Scripts/webkitpy/benchmark_runner/utils.py: Fix loading of subclasses. See description above.
(load_subclasses):
- 8:49 AM Changeset in webkit [196978] by
-
- 5 edits in trunk
[css-grid] Rows track sizes are optional in grid-template shorthand
https://bugs.webkit.org/show_bug.cgi?id=154586
Reviewed by Sergio Villar Senin.
You can omit the size of the rows in grid-template shorthand,
even if you specify a named grid line for the end of the row,
due to a change in the spec back in 2014:
https://github.com/w3c/csswg-drafts/commit/9f660c4183c73c1f5279c46904dc6cb314f76194
Before if you want to specify a named grid line,
you need to set the row size.
Update parsing, so it nows accepts things like:
grid-template: 100px / "a" [bottom];
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSParser::parseGridTemplateShorthand):
- 8:30 AM Changeset in webkit [196977] by
-
- 15 edits3 adds in trunk
[SVG] Update SVG source to return string literals as ASCIILiteral and add test cases for case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=154373
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-02-23
Reviewed by Youenn Fablet.
Source/WebCore:
Update SVGAnimatedEnumeration toString method to return ASCIILiteral for string literals and add test cases for
case-sensitivity for these elements.
Test: svg/dom/SVGAnimatedEnumeration-case-sensitive.html
- svg/SVGComponentTransferFunctionElement.h:
(WebCore::SVGPropertyTraits<ComponentTransferType>::toString):
- svg/SVGFEBlendElement.h:
(WebCore::SVGPropertyTraits<BlendMode>::toString):
- svg/SVGFEColorMatrixElement.h:
(WebCore::SVGPropertyTraits<ColorMatrixType>::toString):
- svg/SVGFECompositeElement.h:
(WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
- svg/SVGFEConvolveMatrixElement.h:
(WebCore::SVGPropertyTraits<EdgeModeType>::toString):
- svg/SVGFEDisplacementMapElement.h:
(WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):
- svg/SVGFEMorphologyElement.h:
(WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):
- svg/SVGFETurbulenceElement.h:
(WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):
- svg/SVGGradientElement.h:
(WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):
- svg/SVGMarkerElement.h:
(WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):
- svg/SVGTextContentElement.h:
(WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):
- svg/SVGTextPathElement.h:
(WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):
- svg/SVGUnitTypes.h:
(WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):
LayoutTests:
Add test cases for case-sensitivity for SVGAnimatedEnumeration elements.
- svg/dom/SVGAnimatedEnumeration-case-sensitive-expected.txt: Added.
- svg/dom/SVGAnimatedEnumeration-case-sensitive.html: Added.
- svg/dom/script-tests/SVGAnimatedEnumeration-case-sensitive.js: Added.
(testCaseSensitivity):
- 7:51 AM Changeset in webkit [196976] by
-
- 2 edits in trunk/Source/WebCore
[Mac][cmake] Unreviewed speculative buildfix after r196779. Just for fun.
- PlatformMac.cmake:
- 7:46 AM WebKitGTK/2.12.x edited by
- (diff)
- 6:36 AM Changeset in webkit [196975] by
-
- 8 edits in trunk/Source
Remove tab suspension code
https://bugs.webkit.org/show_bug.cgi?id=154585
Reviewed by Andreas Kling.
Source/WebCore:
It causes too many problems.
- page/Page.cpp:
(WebCore::networkStateChanged):
(WebCore::Page::Page):
(WebCore::Page::setPageActivityState):
(WebCore::Page::setIsVisible):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setIsPrerender):
(WebCore::Page::setResourceUsageOverlayVisible):
(WebCore::Page::canTabSuspend): Deleted.
(WebCore::Page::setIsTabSuspended): Deleted.
(WebCore::Page::setTabSuspensionEnabled): Deleted.
(WebCore::Page::updateTabSuspensionState): Deleted.
(WebCore::Page::tabSuspensionTimerFired): Deleted.
- page/Page.h:
(WebCore::Page::setEditable):
(WebCore::Page::isEditable):
(WebCore::Page::setShowAllPlugins):
Source/WebKit2:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 4:22 AM Changeset in webkit [196974] by
-
- 1 edit1 add in trunk/Tools
[GTK] Missing configuration patch for openh264 compilation
https://bugs.webkit.org/show_bug.cgi?id=154455
This patch is required for the openh264 compilation with the
jhbuild-webrtc.modules. The code was implemented by Alessandro
Decina.
Patch by Alejandro G. Castro <alex@igalia.com> on 2016-02-23
Reviewed by Philippe Normand.
- gtk/patches/openh264-configure.patch: Added.
- 1:39 AM Changeset in webkit [196973] by
-
- 6 edits in trunk/Source/WebCore
Refactor DOM Iterator next signature
https://bugs.webkit.org/show_bug.cgi?id=154531
Reviewed by Myles C. Maxfield.
Covered by existing tests.
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next): Using Optional<KeyValuePair> to return iterator value.
- Modules/fetch/FetchHeaders.h:
- bindings/js/JSKeyValueIterator.h: Using Optional<KeyValuePair> as returned iterator value.
(WebCore::keyValueIteratorForEach):
(WebCore::JSKeyValueIterator<JSWrapper>::next):
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::Iterator::next): Using Optional<KeyValuePair> to return iterator value.
- css/FontFaceSet.h:
Feb 22, 2016:
- 11:59 PM Changeset in webkit [196972] by
-
- 15 edits2 deletes in trunk/Source/WebKit2
[EFL] Merge WebView and WebViewEfl
https://bugs.webkit.org/show_bug.cgi?id=154445
Reviewed by Gyuyoung Kim.
- PlatformEfl.cmake: Removed WebViewEfl.cpp from source list.
- UIProcess/API/C/efl/WKViewEfl.cpp: Removed type cast for WebViewEfl.
- UIProcess/API/efl/EwkView.cpp: Ditto.
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/GestureRecognizer.cpp: Removed type cast for WebViewEfl.
- UIProcess/API/efl/WebAccessibility.cpp: Removed unnecessary includes.
- UIProcess/API/efl/ewk_view.cpp: Ditto.
- UIProcess/efl/ViewClientEfl.cpp: Ditto.
- UIProcess/efl/WebColorPickerClient.cpp: Ditto.
- UIProcess/efl/WebColorPickerClient.h:
- UIProcess/efl/WebColorPickerEfl.cpp:
(WebKit::WebColorPickerEfl::WebColorPickerEfl):
- UIProcess/efl/WebColorPickerEfl.h:
(WebKit::WebColorPickerEfl::create):
- UIProcess/efl/WebView.cpp:
- UIProcess/efl/WebView.h:
- UIProcess/efl/WebViewEfl.cpp: Removed.
- UIProcess/efl/WebViewEfl.h: Ditto.
- 11:37 PM Changeset in webkit [196971] by
-
- 6 edits in trunk/Source/WebCore
Some timer alignment cleanup.
https://bugs.webkit.org/show_bug.cgi?id=154559
Reviewed by Chris Dumez.
Document shouldn't override Page's timer alignment policy with a lower alignment,
and m_domTimerAlignmentInterval isn't really a Settings, it's just the current state
for the page.
- dom/Document.cpp:
(WebCore::Document::timerAlignmentInterval):
- take the max of the possible intervals.
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setTimerThrottlingEnabled):
(WebCore::Page::setDOMTimerAlignmentInterval):
- moved here from Settings.
- page/Page.h:
(WebCore::Page::domTimerAlignmentInterval):
- moved here from Settings.
- page/Settings.cpp:
(WebCore::Settings::setDOMTimerAlignmentInterval): Deleted.
- moved to Page.
- page/Settings.h:
(WebCore::Settings::domTimerAlignmentInterval): Deleted.
- moved to Page.
- 11:18 PM Changeset in webkit [196970] by
-
- 9 edits2 moves2 adds in trunk/Source
Web Inspector: add 'Automation' protocol domain and generate its backend classes separately in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=154509
<rdar://problem/24759098>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Add a new 'WebKit' framework, which is used to generate protocol code
in WebKit2.
Add --backend and --frontend flags to the main generator script.
These allow a framework to trigger two different sets of generators
so they can be separately generated and compiled.
- inspector/scripts/codegen/models.py:
(Framework.fromString):
(Frameworks): Add new framework.
- inspector/scripts/generate-inspector-protocol-bindings.py:
If neither --backend or --frontend is specified, assume both are wanted.
This matches the behavior for JavaScriptCore and WebInspector frameworks.
(generate_from_specification):
Generate C++ files for the backend and Objective-C files for the frontend.
Source/WebKit2:
Add a new 'Automation' domain which presents an RPC interface
for sending automation commands to an active WebAutomationSession
in the UIProcess via RemoteInspector. This is similar to how the
Inspector backend communicates bidirectionally with a remote
Inspector frontend.
Add build system logic to generate JSON-RPC protocol bindings
for the 'Automation' domain using the inspector code generators.
Move automation-related files that are not API or SPI into their
own directory.
- Configurations/BaseTarget.xcconfig: Tell where JavaScriptCore's
private headers are, since that's where the code generators live.
- CMakeLists.txt: Look in UIProcess/Automation directory.
- PlatformMac.cmake:
- DerivedSources.make: Generate protocol bindings for a single domain.
The names of the generated files will be improved in a follow-up patch
so that they do not clash with generated files in JavaScriptCore.
- UIProcess/Automation/Automation.json: Added.
- UIProcess/Automation/WebAutomationSession.cpp: Renamed from Source/WebKit2/UIProcess/WebAutomationSession.cpp.
(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::~WebAutomationSession):
Set up a backend dispatcher and frontend router. They will be used later.
(WebKit::WebAutomationSession::dispatchMessageFromRemote):
Forward messages from the remote to the backend dispatcher. When
an agent / command handler is registered, it will receive the message.
(WebKit::WebAutomationSession::connect):
(WebKit::WebAutomationSession::disconnect):
Connenct and disconnect the frontend router to the remote channel.
- UIProcess/Automation/WebAutomationSession.h: Renamed from Source/WebKit2/UIProcess/WebAutomationSession.h.
- WebKit2.xcodeproj/project.pbxproj: Add and move files.
- 11:17 PM Changeset in webkit [196969] by
-
- 13 edits2 adds in trunk
Font features specified in @font-face blocks don't apply to local() families
https://bugs.webkit.org/show_bug.cgi?id=154554
Reviewed by Dean Jackson.
Source/WebCore:
The correct variables just need to be wired up. In addition, our caches need to be sensitive
to the new data.
Test: css3/font-feature-font-face-local.html
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::fontForFamily):
- platform/graphics/FontCache.h:
- platform/graphics/FontFeatureSettings.h:
(WebCore::FontFeature::operator!=):
(WebCore::FontFeatureSettings::operator!=):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::lastResortFallbackFont):
- platform/text/TextFlags.h:
(WebCore::FontVariantSettings::operator==):
(WebCore::FontVariantSettings::operator!=):
(WebCore::FontVariantSettings::uniqueValue):
LayoutTests:
- css3/font-feature-font-face-local-expected.html: Added.
- css3/font-feature-font-face-local.html: Added.
- 6:31 PM Changeset in webkit [196968] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines sidebar and overview attempt to access undefined properties when FPS instrument is absent
https://bugs.webkit.org/show_bug.cgi?id=154567
<rdar://problem/24781536>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
The viewMode property should be in a valid state before attempting
to access the current view mode settings.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.get minimumWidth):
(WebInspector.TimelineSidebarPanel.prototype._updateViewModeIfNeeded):
(WebInspector.TimelineSidebarPanel):
Added missing checks for FPSInstrument support.
- 5:01 PM Changeset in webkit [196967] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSGlobalObject doesn't visit ProxyObjectStructure during GC
https://bugs.webkit.org/show_bug.cgi?id=154564
Rubber stamped by Mark Lam.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
- 4:51 PM Changeset in webkit [196966] by
-
- 18 edits1 add in trunk/Source/JavaScriptCore
InternalFunction::createSubclassStructure doesn't take into account that get() might throw
https://bugs.webkit.org/show_bug.cgi?id=154548
Reviewed by Mark Lam and Geoffrey Garen and Andreas Kling.
InternalFunction::createSubclassStructure calls newTarget.get(...) which can throw
an exception. Neither the function nor the call sites of the function took this into
account. This patch audits the call sites of the function to make it work in
the event that an exception is thrown.
- runtime/BooleanConstructor.cpp:
(JSC::constructWithBooleanConstructor):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/ErrorConstructor.cpp:
(JSC::Interpreter::constructWithErrorConstructor):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::createSubclassStructure):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayView):
- runtime/JSGlobalObject.h:
(JSC::constructEmptyArray):
(JSC::constructArray):
(JSC::constructArrayNegativeIndexed):
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise):
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/NativeErrorConstructor.cpp:
(JSC::Interpreter::constructWithNativeErrorConstructor):
- runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor):
- runtime/RegExpConstructor.cpp:
(JSC::getRegExpStructure):
(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):
- runtime/SetConstructor.cpp:
(JSC::constructSet):
- runtime/StringConstructor.cpp:
(JSC::constructWithStringConstructor):
(JSC::StringConstructor::getConstructData):
- runtime/WeakMapConstructor.cpp:
(JSC::constructWeakMap):
- runtime/WeakSetConstructor.cpp:
(JSC::constructWeakSet):
- tests/stress/create-subclass-structure-might-throw.js: Added.
(assert):
- 4:48 PM Changeset in webkit [196965] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r196892): Crash in DocumentLoader::startLoadingMainResource()
https://bugs.webkit.org/show_bug.cgi?id=154563
<rdar://problem/24780678>
Reviewed by Alexey Proskuryakov.
Fixes an issue where the provisional loader may be deallocated when starting
a load. One example where this can occur is when cancelling the provisional load
as part of a form submission because the Content Security Policy of the page
blocks the submission (it violates the directive form-action).
This crash is covered by the test http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Take a ref before calling
DocumentLoader::willSendRequest().
- 4:40 PM Changeset in webkit [196964] by
-
- 14 edits in trunk/Source
Implement basic functionality in WebVideoFullscreenInterfaceMac.
https://bugs.webkit.org/show_bug.cgi?id=153241
Reviewed by Beth Dakin.
Source/WebCore:
- platform/cocoa/WebVideoFullscreenInterface.h:
- platform/mac/WebVideoFullscreenInterfaceMac.h:
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(WebCore::WebVideoFullscreenInterfaceMac::setupFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::enterFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::cleanupFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::invalidate):
(WebCore::WebVideoFullscreenInterfaceMac::preparedToReturnToInline):
Source/WebKit2:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::exitFullscreen):
(WebKit::WebVideoFullscreenManagerProxy::preparedToReturnToInline):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::rootViewToWindow):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::rootViewToWindow):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::supportsVideoFullscreen):
- WebProcess/cocoa/WebVideoFullscreenManager.h:
- WebProcess/cocoa/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::supportsVideoFullscreen):
- 4:03 PM Changeset in webkit [196963] by
-
- 1 edit in trunk/PerformanceTests/MallocBench/MallocBench/Benchmark.cpp
Unreviewed build fix.
Eliminated the include of simple.h as that benchmark wasn't meant to be checked in.
- 3:03 PM Changeset in webkit [196962] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix build and implement functions to retrieve registers on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=152258
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2016-02-22
Reviewed by Michael Catanzaro.
- heap/MachineStackMarker.cpp:
(pthreadSignalHandlerSuspendResume):
struct ucontext is not specified in POSIX and it is not available on
FreeBSD. Replacing it with ucontext_t fixes the build problem.
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
- heap/MachineStackMarker.h:
- 2:27 PM Changeset in webkit [196961] by
-
- 5 edits in trunk
REGRESSION (r196563): Images not loading on https://klim.co.nz/blog/paypal-sans-design-information/
https://bugs.webkit.org/show_bug.cgi?id=154547
<rdar://problem/24772167>
Reviewed by Gavin Barraclough.
Source/WebCore:
The Website was doing the following:
$ var e = window.addEventListener;
$ e("eventname", handler)
In such case, the jsEventTargetPrototypeFunctionDispatchEvent() bindings
implementation was caused with a thisValue which is a JSLexicalEnvironment
and the implementation did not know how to convert it into a global object.
The previous implementation on JSDOMWindow used to handle tis correctly
because it was always calling JSValue::toThis() on the thisValue before
trying to cast it to a JSDOMWindow, and JSLexicalEnvironment::toThis()
gets the globalThisValue. This patch updates the EventTarget bindings
code to call always call toThis() on the thisValue before trying to
cast it. This should correctly deal with JSLexicalEnvironment and be a
no-op in usual cases.
No new tests, extended existing test.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateFunctionCastedThis):
LayoutTests:
Add regression test for <rdar://problem/24772167>.
- fast/dom/Window/addEventListener-implicit-this-expected.txt:
- fast/dom/Window/addEventListener-implicit-this.html:
- 2:26 PM Changeset in webkit [196960] by
-
- 10 edits2 adds in trunk
Repeated background images have the wrong position when using bottom/right-relative background-position
https://bugs.webkit.org/show_bug.cgi?id=154478
Reviewed by Dave Hyatt.
Source/WebCore:
Fix RenderBoxModelObject::calculateBackgroundImageGeometry() to use the right position when
painting repeated background images when right/bottom edges are used.
Also rename BackgroundEdgeOrigin to Edge
Test: fast/images/background-position.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator Edge):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin): Deleted.
- rendering/RenderBoxModelObject.cpp:
(WebCore::resolveEdgeRelativeLength):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
- rendering/style/FillLayer.h:
(WebCore::FillLayer::backgroundXOrigin):
(WebCore::FillLayer::backgroundYOrigin):
(WebCore::FillLayer::setBackgroundXOrigin):
(WebCore::FillLayer::setBackgroundYOrigin):
- rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
- rendering/style/RenderStyleConstants.h:
LayoutTests:
Enhanced background-position-serialize.html to test values that use right/bottom edge specifiers.
Ref test for background-position.
- fast/css/background-position-serialize-expected.txt:
- fast/css/background-position-serialize.html:
- fast/images/background-position-expected.html: Added.
- fast/images/background-position.html: Added.
- fast/images/resources/checker.png: Added.
- 2:24 PM Changeset in webkit [196959] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSValue::isConstructor and JSValue::isFunction should check getConstructData and getCallData
https://bugs.webkit.org/show_bug.cgi?id=154552
Reviewed by Mark Lam.
ES6 Proxy breaks our isFunction() and isConstructor() JSValue methods.
They return false on a Proxy with internal Call and Construct
properties. It seems safest, most forward looking, and most adherent
to the specification to check getCallData() and getConstructData() to
implement these functions.
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::createSubclassStructure):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::isFunction):
(JSC::JSValue::isConstructor):
- 2:23 PM Changeset in webkit [196958] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r196935.
https://bugs.webkit.org/show_bug.cgi?id=154557
This change causes timeouts and crashes in LayoutTests
(Requested by ryanhaddad on #webkit).
Reverted changeset:
"Enable AVFoundationNSURLSessionEnabled by default"
https://bugs.webkit.org/show_bug.cgi?id=154469
http://trac.webkit.org/changeset/196935
Patch by Commit Queue <commit-queue@webkit.org> on 2016-02-22
- 2:18 PM Changeset in webkit [196957] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Polish translation of WebKitGTK+ for 2.12
https://bugs.webkit.org/show_bug.cgi?id=154549
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2016-02-22
Rubber-stamped by Michael Catanzaro.
- pl.po:
- 2:07 PM Changeset in webkit [196956] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
Bound functions should use the prototype of the function being bound
https://bugs.webkit.org/show_bug.cgi?id=154195
Reviewed by Geoffrey Garen.
Per ES6, the result of Function.prototype.bind should have the same
prototype as the the function being bound. In order to avoid creating
a new structure each time a function is bound we store the new
structure in our structure map. However, we cannot currently store
structures that have a different GlobalObject than their prototype.
In the rare case that the GlobalObject differs or the prototype of
the bindee is null we create a new structure each time. To further
minimize new structures, as well as making structure lookup faster,
we also store the structure in the RareData of the function we
are binding.
- runtime/FunctionRareData.cpp:
(JSC::FunctionRareData::visitChildren):
- runtime/FunctionRareData.h:
(JSC::FunctionRareData::getBoundFunctionStructure):
(JSC::FunctionRareData::setBoundFunctionStructure):
- runtime/JSBoundFunction.cpp:
(JSC::getBoundFunctionStructure):
(JSC::JSBoundFunction::create):
- tests/es6.yaml:
- tests/stress/bound-function-uses-prototype.js: Added.
(testChangeProto.foo):
(testChangeProto):
(testBuiltins):
- tests/stress/class-subclassing-function.js:
- 2:02 PM Changeset in webkit [196955] by
-
- 42 edits5 adds in trunk/PerformanceTests
MallocBench: Added recording for nimlang website, new recording details and added new options
https://bugs.webkit.org/show_bug.cgi?id=154485
Reviewed by Geoff Garen.
Added new capabilities to MallocBench. These include:
Added a recording of http://nim-lang.org/docs/lib.html.
Added thread id to the recording and the ability to playback switching threads in MallocBench
Added aligned allocations to recordings and the ability to playback
Added --use-thread-id option to honor recorded thread ids
Added --detailed-report to output remaining allocations by size after playback
Added --no-warmup to not run the warm up iteration
Changed the way that options are passed down to the benchmarks. Instead of passing individual
boolean or numeric option values, just pass a reference the CommandLine itself. Each benchmark
can access the options that are appropriate. The Benchmark class also uses the options for
is parallel, run counts and warm up.
Added thread id and aligned malloc to the Op by noticing that structure padding and Opcode allowed
for another 32 bits of data. Breaking that unused 32 bits into a 16 bit thread id value and a
16 bit log base 2 of the alignment for aligned malloc allowed for existing recordings to playback
without any incompatibilities.
Threaded operation is simulated by creating threads as needed. As long as the next Op's thread id
is the same as the last, operation continues as normal. When the next Op has a different thread id,
we switch to that thread using the shared Op stream to continue playing back. There is a mutex to
assure that only one thread is really running at a time and a condition variable used to wait
that the current thread id matches each block thread's thread id. This doesn't simulate true
concurrent threading, but is instead plays back Ops recorded for multiple thread faithfully.
- MallocBench/MallocBench.xcodeproj/project.pbxproj:
- MallocBench/MallocBench/Benchmark.cpp:
(deallocateHeap):
(Benchmark::Benchmark):
(Benchmark::runOnce):
(Benchmark::run):
- MallocBench/MallocBench/Benchmark.h:
(Benchmark::isValid):
- MallocBench/MallocBench/CommandLine.cpp:
(CommandLine::printUsage):
- MallocBench/MallocBench/CommandLine.h:
(CommandLine::isValid):
(CommandLine::benchmarkName):
(CommandLine::isParallel):
(CommandLine::useThreadID):
(CommandLine::detailedReport):
(CommandLine::warmUp):
(CommandLine::heapSize):
(CommandLine::runs):
- MallocBench/MallocBench/Interpreter.cpp:
(Interpreter::Interpreter):
(Interpreter::run):
(Interpreter::readOps):
(Interpreter::doOnSameThread):
(Interpreter::switchToThread):
(Interpreter::detailedReport):
(compute2toPower):
(writeData):
(Interpreter::doMallocOp):
(Interpreter::Thread::Thread):
(Interpreter::Thread::stop):
(Interpreter::Thread::~Thread):
(Interpreter::Thread::runThread):
(Interpreter::Thread::waitToRun):
(Interpreter::Thread::switchTo):
- MallocBench/MallocBench/Interpreter.h:
(Interpreter::Thread::isMainThread):
- MallocBench/MallocBench/alloc_free.cpp: Added.
(benchmark_alloc_free):
- MallocBench/MallocBench/alloc_free.h: Added.
- MallocBench/MallocBench/balloon.cpp:
(benchmark_balloon):
- MallocBench/MallocBench/balloon.h:
- MallocBench/MallocBench/big.cpp:
(benchmark_big):
- MallocBench/MallocBench/big.h:
- MallocBench/MallocBench/churn.cpp:
(benchmark_churn):
- MallocBench/MallocBench/churn.h:
- MallocBench/MallocBench/facebook.cpp:
(benchmark_facebook):
- MallocBench/MallocBench/facebook.h:
- MallocBench/MallocBench/flickr.cpp:
(benchmark_flickr):
(benchmark_flickr_memory_warning):
- MallocBench/MallocBench/flickr.h:
- MallocBench/MallocBench/fragment.cpp:
(validate):
(benchmark_fragment):
(benchmark_fragment_iterate):
- MallocBench/MallocBench/fragment.h:
- MallocBench/MallocBench/list.cpp:
(benchmark_list_allocate):
(benchmark_list_traverse):
- MallocBench/MallocBench/list.h:
- MallocBench/MallocBench/main.cpp:
(main):
- MallocBench/MallocBench/medium.cpp:
(benchmark_medium):
- MallocBench/MallocBench/medium.h:
- MallocBench/MallocBench/memalign.cpp:
(test):
(benchmark_memalign):
- MallocBench/MallocBench/memalign.h:
- MallocBench/MallocBench/message.cpp:
(benchmark_message_one):
(benchmark_message_many):
- MallocBench/MallocBench/message.h:
- MallocBench/MallocBench/nimlang.cpp: Added.
(benchmark_nimlang):
- MallocBench/MallocBench/nimlang.h: Added.
- MallocBench/MallocBench/nimlang.ops: Added.
- MallocBench/MallocBench/realloc.cpp:
(benchmark_realloc):
- MallocBench/MallocBench/realloc.h:
- MallocBench/MallocBench/reddit.cpp:
(benchmark_reddit):
(benchmark_reddit_memory_warning):
- MallocBench/MallocBench/reddit.h:
- MallocBench/MallocBench/stress.cpp:
(deallocate):
(benchmark_stress):
- MallocBench/MallocBench/stress.h:
- MallocBench/MallocBench/stress_aligned.cpp:
(benchmark_stress_aligned):
- MallocBench/MallocBench/stress_aligned.h:
- MallocBench/MallocBench/theverge.cpp:
(benchmark_theverge):
(benchmark_theverge_memory_warning):
- MallocBench/MallocBench/theverge.h:
- MallocBench/MallocBench/tree.cpp:
(benchmark_tree_allocate):
(benchmark_tree_traverse):
(benchmark_tree_churn):
- MallocBench/MallocBench/tree.h:
- MallocBench/run-malloc-benchmarks:
- 1:40 PM Changeset in webkit [196954] by
-
- 25 edits2 adds in trunk
[Font Loading] Split CSSFontSelector into a FontFaceSet implementation and the rest of the class
https://bugs.webkit.org/show_bug.cgi?id=153347
Reviewed by Antti Koivisto.
Source/WebCore:
This patch implements the document.fonts Javascript object. It does so by briding the
already-existing FontFaceSet Javascript object with the CSSFontSelector WebCore object.
CSSFontSelector used to hold internal objects for each @font-face object in the
Document. These objects have been moved into CSSFontFaceSet, so CSSFontSelector simply
just owns an instance of a CSSFontFaceSet.
The lifetime of the FontFace and FontFaceSet objects is a little interesting: because
all the ownership references are inside the WebCore CSSFontFace{,Set} objects, the
higher-level Javascript FontFace{,Set} objects are held through a WeakPtr. This means
that if all the references to these higher-level objects go away, and you re-query the
document for its FontFace objects, you may get a new object (albeit with the same
state as a previous object). However, this won't occur if there are any references to
the old object, which means it is almost not observable.
This patch doesn't implement the relationship between the CSSOM and the FontFace
objects. Changing one should result in a change in the other, but that will be
implemented in a forthcoming patch.
This patch also doesn't alter the lifetime of the CSSFontSelector, which means that all
the Document's fonts may be destroyed and recreated from CSS. There are a few things
which can trigger this. A subsequent patch will make the CSSFontSelector outlive the
Document.
This patch does implement (and test) the ability to add a new FontFace to the Document
to cause a relayout, as well as changing properties of existing FontFace objects already
in the Document to cause a relayout.
Test: fast/text/font-face-set-document.html
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next): Pass an extra argument.
- Modules/fetch/FetchHeaders.h:
- bindings/js/JSKeyValueIterator.h: The ExecState is necessary to build an external
wrapper from an existing CSSFontFace object.
(WebCore::JSKeyValueIterator<JSWrapper>::next):
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::appendSources): Moved from CSSFontSelector.
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::notifyClientsOfFontPropertyChange):
(WebCore::CSSFontFace::setFamilies):
(WebCore::CSSFontFace::calculateStyle): Shared code between CSSFontFaceSet and
CSSFontFace.
(WebCore::CSSFontFace::setStyle): Update to use calculateStyle().
(WebCore::CSSFontFace::calculateWeight): Ditto.
(WebCore::CSSFontFace::setWeight): Update to use caculateWeight().
(WebCore::CSSFontFace::setUnicodeRange): Notify clients.
(WebCore::CSSFontFace::setVariantLigatures): Ditto.
(WebCore::CSSFontFace::setVariantPosition): Ditto.
(WebCore::CSSFontFace::setVariantCaps): Ditto.
(WebCore::CSSFontFace::setVariantNumeric): Ditto.
(WebCore::CSSFontFace::setVariantAlternates): Ditto.
(WebCore::CSSFontFace::setVariantEastAsian): Ditto.
(WebCore::CSSFontFace::setFeatureSettings): Ditto.
(WebCore::CSSFontFace::removeClient):
(WebCore::CSSFontFace::wrapper): Build a new wrapper if one doesn't already
exist. Note that this requires an ExecState to create a promise.
(WebCore::CSSFontFace::setStatus):
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::font):
- css/CSSFontFace.h:
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::CSSFontFaceSet): Moved code from CSSFontSelector.
(WebCore::CSSFontFaceSet::~CSSFontFaceSet):
(WebCore::CSSFontFaceSet::addClient): This object can now have multiple
clients.
(WebCore::CSSFontFaceSet::removeClient):
(WebCore::CSSFontFaceSet::incrementActiveCount): Update for multiple clients.
(WebCore::CSSFontFaceSet::decrementActiveCount): Ditto.
(WebCore::CSSFontFaceSet::hasFace):
(WebCore::CSSFontFaceSet::registerLocalFontFacesForFamily): Moved from
CSSFontSelector.
(WebCore::CSSFontFaceSet::familyNameFromPrimitive): Ditto.
(WebCore::CSSFontFaceSet::addToFacesLookupTable): This helper function can
be used when a property of a FontFace is changed.
(WebCore::CSSFontFaceSet::add): Update to use addToFacesLookupTable().
(WebCore::CSSFontFaceSet::removeFromFacesLookupTable): Same as
addToFacesLookupTable().
(WebCore::CSSFontFaceSet::remove): Update to use removeFromFacesLookupTable().
(WebCore::CSSFontFaceSet::clear):
(WebCore::CSSFontFaceSet::operator[]):
(WebCore::computeFontTraitsMask): Moved from CSSFontSelector.
(WebCore::CSSFontFaceSet::matchingFaces): Update to use new data structures.
(WebCore::FontFaceComparator::FontFaceComparator): Moved from
CSSFontSelector.
(WebCore::FontFaceComparator::operator()):
(WebCore::CSSFontFaceSet::getFontFace): Update to use new data structures.
(WebCore::CSSFontFaceSet::fontStateChanged): Update to use multiple clients.
(WebCore::CSSFontFaceSet::fontPropertyChanged): We must update our internal
data structure if the family name changed.
(WebCore::extractFamilies): Deleted.
(WebCore::familiesIntersect): Deleted.
(WebCore::CSSFontFaceSet::load): Deleted.
(WebCore::CSSFontFaceSet::stateChanged): Deleted.
- css/CSSFontFaceSet.h: Now needs to be RefCounted. New data structures are
taken from CSSFontSelector.
(WebCore::CSSFontFaceSetClient::faceFinished):
(WebCore::CSSFontFaceSetClient::fontModified):
(WebCore::CSSFontFaceSetClient::startedLoading):
(WebCore::CSSFontFaceSetClient::completedLoading):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp: Move code into CSSFontFaceSet.
(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::~CSSFontSelector):
(WebCore::CSSFontSelector::fontFaceSet):
(WebCore::CSSFontSelector::isEmpty):
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::fontModified):
(WebCore::CSSFontSelector::fontRangesForFamily):
(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::appendSources): Deleted.
(WebCore::CSSFontSelector::familyNameFromPrimitive): Deleted.
(WebCore::CSSFontSelector::registerLocalFontFacesForFamily): Deleted.
(WebCore::FontFaceComparator::FontFaceComparator): Deleted.
(WebCore::FontFaceComparator::operator()): Deleted.
(WebCore::CSSFontSelector::getFontFace): Deleted.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace):
- css/CSSSegmentedFontFace.h:
- css/FontFace.cpp:
(WebCore::FontFace::create):
(WebCore::FontFace::FontFace):
(WebCore::FontFace::createWeakPtr):
(WebCore::FontFace::fontStateChanged):
(WebCore::FontFace::stateChanged): Deleted.
- css/FontFace.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::create):
(WebCore::FontFaceSet::FontFaceSet):
(WebCore::FontFaceSet::~FontFaceSet):
(WebCore::FontFaceSet::Iterator::next):
(WebCore::FontFaceSet::has):
(WebCore::FontFaceSet::size):
(WebCore::FontFaceSet::add):
(WebCore::FontFaceSet::remove):
(WebCore::FontFaceSet::clear):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::check):
(WebCore::FontFaceSet::status):
(WebCore::FontFaceSet::canSuspendForDocumentSuspension):
(WebCore::FontFaceSet::faceFinished):
- css/FontFaceSet.h:
- css/FontFaceSet.idl:
- dom/Document.cpp:
(WebCore::Document::fonts):
- dom/Document.h:
- dom/Document.idl:
- svg/SVGFontFaceElement.h:
LayoutTests:
- fast/text/font-face-javascript.html:
- fast/text/font-face-set-document-expected.txt: Added.
- fast/text/font-face-set-document.html: Added.
- 1:36 PM Changeset in webkit [196953] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix stress test to not print on success.
- tests/stress/call-apply-builtin-functions-dont-use-iterators.js:
(catch): Deleted.
- 1:10 PM Changeset in webkit [196952] by
-
- 2 edits in trunk/Source/WebKit2
Remove _mockCaptureDevicesEnabled getter and setter
https://bugs.webkit.org/show_bug.cgi?id=154550
Reviewed by Beth Dakin.
The _mockCaptureDevicesEnabled property isn't declared anywhere, and this
should be a WKWebViewConfiguration parameter if we ever want to expose it in the modern API.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _mockCaptureDevicesEnabled]): Deleted.
(-[WKPreferences _setMockCaptureDevicesEnabled:]): Deleted.
- 12:15 PM Changeset in webkit [196951] by
-
- 2 edits in trunk/Source/WebKit/win
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=154545
Reviewed by Alex Christensen.
Add missing parameter to GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers().
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::flushPendingLayerChanges):
- 12:07 PM Changeset in webkit [196950] by
-
- 11 edits in trunk/Source/JavaScriptCore
Use Symbol.species in the builtin TypedArray.prototype functions
https://bugs.webkit.org/show_bug.cgi?id=153384
Reviewed by Geoffrey Garen.
This patch adds the use of species constructors to the TypedArray.prototype map and filter
functions. It also adds a new private function typedArrayGetOriginalConstructor that
returns the TypedArray constructor used to originally create a TypedArray instance.
There are no ES6 tests to update for this patch as species creation for these functions is
not tested in the compatibility table.
- builtins/TypedArrayPrototype.js:
(map):
(filter):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::typedArrayConstructor):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewPrivateFuncGetOriginalConstructor):
- runtime/JSTypedArrayViewPrototype.h:
- tests/stress/typedarray-filter.js:
(subclasses.typedArrays.map):
(prototype.accept):
(testSpecies):
(accept):
(forEach):
(subclasses.forEach):
(testSpeciesRemoveConstructor):
- tests/stress/typedarray-map.js:
(subclasses.typedArrays.map):
(prototype.id):
(testSpecies):
(id):
(forEach):
(subclasses.forEach):
(testSpeciesRemoveConstructor):
- 11:43 AM Changeset in webkit [196949] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Builtins that should not rely on iteration do.
https://bugs.webkit.org/show_bug.cgi?id=154475
Reviewed by Geoffrey Garen.
When changing the behavior of varargs calls to use ES6 iterators the
call builtin function's use of a varargs call was overlooked. The use
of iterators is observable outside the scope of the the call function,
thus it must be reimplemented.
- builtins/FunctionPrototype.js:
(call):
- tests/stress/call-apply-builtin-functions-dont-use-iterators.js: Added.
(test):
(addAll):
(catch):
- 11:41 AM Changeset in webkit [196948] by
-
- 4 edits in trunk
[JSC shell] Don't put empty arguments array to VM.
https://bugs.webkit.org/show_bug.cgi?id=154516
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-22
Reviewed by Geoffrey Garen.
This allows arrowfunction-lexical-bind-arguments-top-level test to pass
in jsc as well as in browser.
Source/JavaScriptCore:
- jsc.cpp:
(GlobalObject::finishCreation):
LayoutTests:
- js/script-tests/arrowfunction-lexical-bind-arguments-top-level.js:
Removed @ skip annotation.
- 11:32 AM Changeset in webkit [196947] by
-
- 12 edits in trunk
[cmake] Moved library setup code to WEBKIT_FRAMEWORK macro.
https://bugs.webkit.org/show_bug.cgi?id=154450
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-22
Reviewed by Alex Christensen.
.:
- Source/cmake/WebKitMacros.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
Source/WebCore:
No new tests needed.
- CMakeLists.txt:
Source/WebKit:
- CMakeLists.txt:
Source/WebKit2:
- CMakeLists.txt: Used WebKit2_SOURCES variable instead of separate
WebKit2_DERIVED_SOURCES for compatibility with WEBKIT_FRAMEWORK macro.
There is no real need to separate derived sources from others.
- PlatformGTK.cmake: Ditto.
Source/WTF:
- wtf/CMakeLists.txt:
- 11:26 AM Changeset in webkit [196946] by
-
- 2 edits in trunk/Source/WebCore
Workaround for ICE in GCC 4.8 appeared in r196846.
https://bugs.webkit.org/show_bug.cgi?id=154535
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-22
Reviewed by Chris Dumez.
No new tests needed.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::autocomplete):
- 11:24 AM Changeset in webkit [196945] by
-
- 2 edits in trunk/Source/WebKit2
[CMake] Unreviewed build fix after r196942.
- CMakeLists.txt: WKPluginSiteDataManager.cpp is gone.
- 11:22 AM Changeset in webkit [196944] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Rebaseline Mavericks expected results for emoji tests. rdar://problem/24724222
- 10:31 AM Changeset in webkit [196943] by
-
- 13 edits in trunk/Source
Add mechanism to disable memory pressure handling
https://bugs.webkit.org/show_bug.cgi?id=154254
<rdar://problem/24662616>
Patch by Keith Rollin <Keith Rollin> on 2016-02-22
Reviewed by Chris Dumez.
Add a mechanism to disable WebKit's response to memory pressure
triggers. This was asked for by another group for testing purposes.
In order to disable WebKit's memory pressure handling, execute the
following from the command line:
defaults write com.apple.Safari WebKitSuppressMemoryPressureHandler -bool true
To revert to standard behavior, delete the key or set it to False.
This flag is used when a new sub-process is being spawned. The value
is read and stored in an initialization parameter block, which is then
sent to the new sub-process.
In actuality, only the UI, WebContent, and Network processes heed the
flag. The Plugin process isn't instrumented to heed this flag for
three reasons. First, the Plugin process installs its memory pressure
handler in initializeProcess, not initializePluginProcess. This is
contrary to when the other processes install their handlers, which is
in initialize<PluginType>Process, not initializeProcess. So in order
to accomodate the Plugin process, we'd need to modify
ChildProcessInitializationParameters. Doing this is awkward at best,
but also seems to be opposed to what's supposed to be done in
initializeProcess and conveyed in
ChildProcessInitializationParameters. And even if we did add a boolean
to this structure and added support for conveying it through the XPC
port, it would end up being a Plugin process-only boolean in a general
parameter block, which seems asymmetric with the other processes.
Second, there's no convenient Cocoa function called in the flow that
spawns the Plugin process, meaning that there's no convenient place to
call NSUserDefaults to get the flag's value. And third, the Plugin
process doesn't elegantly respond to the memory pressure trigger
anyway. It might terminate itself, but that's it. As for the Database
process, it doesn't seem to support responding to memory pressure at
all, so we don't send it a flag telling it to ignore it.
Internally, the memory pressure handler is suppressed by not calling
MemoryPressureHandler::install() if the flag is set. In the case of
the Network process, the flag is saved so that it can be checked later
in other places that manually kick off the memory pressure handling
procedure.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::initializeNetworkProcess):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 10:22 AM Changeset in webkit [196942] by
-
- 5 edits2 deletes in trunk/Source/WebKit2
Get rid of WKPluginSiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=154470
Reviewed by Tim Horton.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetPluginSiteDataManager): Deleted.
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKPluginSiteDataManager.cpp: Removed.
(WKPluginSiteDataManagerGetTypeID): Deleted.
(WKPluginSiteDataManagerGetSitesWithData): Deleted.
(WKPluginSiteDataManagerClearSiteData): Deleted.
(WKPluginSiteDataManagerClearAllSiteData): Deleted.
- UIProcess/API/C/WKPluginSiteDataManager.h: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 10:03 AM Changeset in webkit [196941] by
-
- 3 edits in trunk/LayoutTests
Rebaseline tests for ios-simulator after W3C HTML/DOM re-sync in r196883
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
- 10:01 AM Changeset in webkit [196940] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/reflection-forms.html for ios-simulator after r196893
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
- 9:50 AM Changeset in webkit [196939] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][Mac] Allow processes to set "fast-dev-casheable" bit
https://bugs.webkit.org/show_bug.cgi?id=154503
<rdar://problem/22920815>
Reviewed by Alexey Proskuryakov.
Update the various sandbox profiles with a declaration that using the
system-fctl to touch the "hot file" flag (to support caching operations)
is allowed.
- DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in: Add sandbox permission.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Ditto.
- WebProcess/com.apple.WebProcess.sb.in: Ditto.
- 9:34 AM Changeset in webkit [196938] by
-
- 3 edits in trunk/Source/bmalloc
Fixed compilation of bmalloc with GCC 4.8 after r196873.
https://bugs.webkit.org/show_bug.cgi?id=154534
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-22
Reviewed by Mark Lam.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55382.
- bmalloc/LargeChunk.h:
- bmalloc/SmallChunk.h:
- 9:03 AM Changeset in webkit [196937] by
-
- 9 edits2 copies1 delete in trunk/Source
Unreviewed, rolling out r196891.
https://bugs.webkit.org/show_bug.cgi?id=154539
it broke Production builds (Requested by brrian on #webkit).
Reverted changeset:
"Web Inspector: add 'Automation' protocol domain and generate
its backend classes separately in WebKit2"
https://bugs.webkit.org/show_bug.cgi?id=154509
http://trac.webkit.org/changeset/196891
- 8:36 AM Changeset in webkit [196936] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r196620): Web Inspector: Filter bar in the left sidebar is 1px shorter than the console prompt
https://bugs.webkit.org/show_bug.cgi?id=154529
Reviewed by Timothy Hatcher.
- UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .overflow-shadow):
- 7:59 AM Changeset in webkit [196935] by
-
- 6 edits in trunk/Source
Enable AVFoundationNSURLSessionEnabled by default
https://bugs.webkit.org/show_bug.cgi?id=154469
Reviewed by Sam Weinig.
Source/WebCore:
- page/Settings.cpp:
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- 6:08 AM Changeset in webkit [196934] by
-
- 29 edits in trunk
[css-grid] Swap columns and rows in grid-template shorthand
https://bugs.webkit.org/show_bug.cgi?id=154472
Reviewed by Darin Adler.
The spec was modified past December to change the order of
columns and rows in the grid-template shorthand:
https://github.com/w3c/csswg-drafts/commit/f6c7691679a519017a80ebae44fd86c3eae5c5f9
Updated the parsing and modified the tests to follow the new syntax.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateColumns):
(WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas): Renamed to
parseGridTemplateRowsAndAreasAndColumns().
- css/CSSParser.h:
LayoutTests:
- fast/css-grid-layout/absolute-positioning-definite-sizes.html:
- fast/css-grid-layout/flex-content-distribution.html:
- fast/css-grid-layout/grid-align-content-vertical-lr.html:
- fast/css-grid-layout/grid-align-content-vertical-rl.html:
- fast/css-grid-layout/grid-align-content.html:
- fast/css-grid-layout/grid-gutters-and-alignment.html:
- fast/css-grid-layout/grid-gutters-and-flex-content.html:
- fast/css-grid-layout/grid-gutters-and-tracks.html:
- fast/css-grid-layout/grid-justify-content-vertical-lr.html:
- fast/css-grid-layout/grid-justify-content-vertical-rl.html:
- fast/css-grid-layout/grid-justify-content.html:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- fast/css-grid-layout/grid-template-shorthand-get-set.html:
- fast/css-grid-layout/relayout-align-items-changed.html:
- fast/css-grid-layout/relayout-align-self-changed.html:
- fast/css-grid-layout/relayout-indefinite-heights.html:
- fast/css-grid-layout/relayout-justify-items-changed.html:
- fast/css-grid-layout/relayout-justify-self-changed.html:
- fast/repaint/align-items-overflow-change.html:
- fast/repaint/align-self-change.html:
- fast/repaint/align-self-overflow-change.html:
- fast/repaint/justify-items-change.html:
- fast/repaint/justify-items-overflow-change.html:
- fast/repaint/justify-self-change.html:
- fast/repaint/justify-self-overflow-change.html:
- 3:49 AM Changeset in webkit [196933] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196809 - [GStreamer] clean-up various leaks
https://bugs.webkit.org/show_bug.cgi?id=154285
Reviewed by Carlos Garcia Campos.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init): Take full ownership of the GstTask.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Null pointer support in ASSERTs.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements): Take full ownership of the GstElementFactory pointers.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Ditto.
- 3:44 AM Changeset in webkit [196932] by
-
- 7 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r196803 - [GTK] Limit the number of tiles according to the visible area
https://bugs.webkit.org/show_bug.cgi?id=126122
Reviewed by Carlos Garcia Campos.
Source/WebCore:
TextureMapperTiledBackingStore creates tiles for whole layer bounds, which
means it creates the huge amount of textures if there is an excessively big
layer. Not only it wastes the memory and the CPU time, it even can crash GPU
drivers.
This patch modifies TextureMapperTiledBackingStore to take into account the
visible area with a coverage multiplier when creating tiles.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
Set a flag to recalculate the visible area of the layer when there are
geometric changes.
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::markVisibleRectAsDirty):
(WebCore::GraphicsLayerTextureMapper::selfOrAncestorHasActiveTransformAnimation):
(WebCore::GraphicsLayerTextureMapper::computeTransformedVisibleRect):
Compute the inverse transform matrix to map a global visible are to
the local visible area.
(WebCore::clampToContentsRectIfRectIsInfinite):
(WebCore::GraphicsLayerTextureMapper::transformedVisibleRect):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
In HiDPI, the directly composited image is uploaded to the unscaled
texture to reduce memory usages. So we should apply device scale
factor to render it correctly.
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
Create tiles which covered by visible rect with a coverage multiplier.
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize): Because we creates
nonCompositingLayer with a size of current view, we should not apply
the currently visible rect when creating / deleting tiles.
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges): Passes the current
visible rect to the GraphicsLayers.
- 2:53 AM Changeset in webkit [196931] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196666 - Every RenderLayer should not have to remove itself from the scrollableArea set
https://bugs.webkit.org/show_bug.cgi?id=154311
Reviewed by Zalan Bujtas.
A subset of RenderLayers are are scrollable, and get registered on the FrameView,
but we pay the cost of a hash lookup for removal on every RenderLayer, which is a waste.
Store a bit that tells RenderLayer that it's in the set and needs to be removed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- 2:42 AM Changeset in webkit [196930] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196641 - Rollout r188659. This broke scrolling of iframes and overflow when
navigating back to a page in the page cache.
The fix was overly agressive and had no layout test. I will fix the original
issue a different way.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- page/FrameView.cpp:
(WebCore::FrameView::clearScrollableAreas): Deleted.
- page/FrameView.h:
- 2:36 AM Changeset in webkit [196929] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r196640 - [GTK] No hover-horizontal scrolling available
https://bugs.webkit.org/show_bug.cgi?id=122859
Reviewed by Michael Catanzaro.
Source/WebCore:
This is a regression of WebKit2, because in WebKit1 we used native
widgets for frame scrollbars that handled this automatically. Now
we need to also check if the mouse is over frame scrollbars to
adjust the wheel event.
Test: platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent): Pass the adjusted wheel
event to platformCompleteWheelEvent().
- page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):
Check also frame scrollbars.
LayoutTests:
- platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll-expected.html: Added.
- platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html: Added.
- 2:35 AM Changeset in webkit [196928] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196631 - Mouse cursor doesn't change when entering scrollbars
https://bugs.webkit.org/show_bug.cgi?id=154243
Reviewed by Simon Fraser.
If the scrollbar is over or very close to text or a link, when
entering the scrollbar the cursor is not changed, keeping the beam
or hand cursor when using the scrollbar. Same happens for image
documents where the magnifier cursor is used and it remains when
entering the scrollbars. We should use pointer cursor always for
scrollbars.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateCursor): Request also to include
frame scrollbars in hit test result.
(WebCore::EventHandler::selectCursor): Use always pointer cursor
for scrollbars.
- 2:32 AM Changeset in webkit [196927] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196602 - Null-deref crash in DefaultAudioDestinationNode::suspend()
https://bugs.webkit.org/show_bug.cgi?id=154248
Reviewed by Alex Christensen.
Null-check scriptExecutionContext() before deref.
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):
- 2:31 AM Changeset in webkit [196926] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r196591 - [ARMv7] stress/op_rshift.js and stress/op_urshift.js are failing.
https://bugs.webkit.org/show_bug.cgi?id=151514
Reviewed by Filip Pizlo.
The issue turns out to be trivial: on ARMv7 (and traditional ARM too), arithmetic
shift right (ASR) and logical shift right (LSR) takes an immediate shift amount
from 1-32. See http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0204j/Cjacbgca.html.
An immediate shift amount of 0 is interpreted as a shift of 32 bits.
Meanwhile, our macro assembler is expecting the immediate shift value to be
between 0-31. As a result, a shift amount of 0 is being wrongly encoded with 0
bits which means shift right by 32 bits.
The fix is to check if the shift amount is 0, and if so, emit a move. Else,
emit the right shift as usual.
This issue does not affect left shifts, as the immediate shift amount for left
shifts is between 0-31 as our macro assembler expects.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::rshift32):
(JSC::MacroAssemblerARMv7::urshift32):
- tests/stress/op_rshift.js:
- tests/stress/op_urshift.js:
- Un-skip these tests. They should always pass now.
- 2:29 AM Changeset in webkit [196925] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r196587 - Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr
https://bugs.webkit.org/show_bug.cgi?id=154244
rdar://problem/24290670
Reviewed by Michael Saboff.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::appendToCommaExpr): Catch the bug sooner in debug.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVariableDeclarationList): Fix the bug.
- tests/stress/for-let-comma.js: Added. This used to crash in debug and release.
- 2:22 AM Changeset in webkit [196924] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r196475 - [GTK] HTTP auth dialog incorrectly rendered with Accelerated Compositing enabled
https://bugs.webkit.org/show_bug.cgi?id=154159
Reviewed by Michael Catanzaro.
There are two problems here, first we are changing the cairo
operator when rendering the xcomposite window pixmap without a
proper save/restore, so it affects the drawing that happens after
that, and second problem is that we are not rendering the gray
background in AC mode because we are returning earlier.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewRenderAcceleratedCompositingResults):
(webkitWebViewBaseDraw):
- 2:21 AM Changeset in webkit [196923] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196469 - GCC buildfix in Source/WebCore/svg/SVGToOTFFontConversion.cpp
https://bugs.webkit.org/show_bug.cgi?id=154162
Reviewed by Andreas Kling.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable):
- 2:19 AM Changeset in webkit [196922] by
-
- 6 edits in releases/WebKitGTK/webkit-2.10/Source/bmalloc
Merge r196421, r196424, r196536: bmalloc: large aligned allocations will put 1 or 2 free object on free list without merging with free neighbors
https://bugs.webkit.org/show_bug.cgi?id=154091
Reviewed by Geoffrey Garen.
If we split off any unused free object in the aligned version of Heap::allocateLarge(), we merge them with
free neighbors before putting them back on the free list. Added helpers to verify that when we
add LargeObjects to the free list their neighbors are allocated.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateLarge): Deleted private helper version and rolled it into the two the
two public versions of allocateLarge().
- bmalloc/Heap.h:
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::prevIsAllocated): New helper.
(bmalloc::LargeObject::nextIsAllocated): New helper.
(bmalloc::LargeObject::merge): Check that the merge object has allocated neighbors.
Unreviewed build fix after r196421.
Removed BASSERTs that are firing to eliminate Debug build crashes. I'll debug locally and
enable or alter after the issue is understood.
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::merge): Removed BASSERTs that are firing.
BASSERTs added in r196421 are causing debug test failures
https://bugs.webkit.org/show_bug.cgi?id=154113
Reviewed by Geoffrey Garen.
In VMHeap::deallocateLargeObject(), we drop the lock to deallocate the physical pages.
If the scavenger thread is running at the same time a synchronous call to scavenge()
comes in, we could call VMHeap::deallocateLargeObject() for an adjacent object while the
lock in the other thread is dropped. We fix this by checking for adjacent objects we
can merge with and loop if we have one.
- bmalloc/FreeList.h:
(bmalloc::FreeList::push): Added BASSERT to catch adding unmerged free objects
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateLarge): Changed to use nextCanMerge().
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::prevCanMerge): Repurposed prevIsAllocated.
(bmalloc::LargeObject::nextCanMerge): Repurposed nextIsAllocated.
(bmalloc::LargeObject::prevIsAllocated): Deleted.
(bmalloc::LargeObject::nextIsAllocated): Deleted.
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateLargeObject): Moved adding the extra object back to the free list
to after we set the object we'll return as being allocated.
(bmalloc::VMHeap::deallocateLargeObject):
- 2:12 AM Changeset in webkit [196921] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196364 - [GTK] Toggle buttons are blurry with GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=154007
Reviewed by Michael Catanzaro.
Use min-width/min-height style properties when GTK+ >= 3.19.7 to
get the size of toggle buttons.
- rendering/RenderThemeGtk.cpp:
(WebCore::setToggleSize):
(WebCore::paintToggle):
- 2:09 AM Changeset in webkit [196920] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r196337 - Don't crash if we fail to parse a builtin
https://bugs.webkit.org/show_bug.cgi?id=154047
rdar://problem/24300617
Reviewed by Mark Lam.
Crashing probably seemed like a good idea at the time, but we could get here in case of a
near stack overflow, so that the parser bails because of recursion.
- parser/Parser.h:
(JSC::parse):
- 2:03 AM Changeset in webkit [196919] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r196307 - possible buffer overrun in Connection::processMessage of Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=153637
Patch by Fujii Hironori <Hironori.Fujii@jp.sony.com> on 2016-02-09
Reviewed by Carlos Garcia Campos.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage): Fix invalid arguments of memmove.
- 1:31 AM Changeset in webkit [196918] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r196264 - Infinite loop when processing mouse events synchronously
https://bugs.webkit.org/show_bug.cgi?id=153995
Reviewed by Darin Adler.
This happened with WTR in the GTK+ port after landing patch in bug
to be synchronous. When a drag and drop operation is in progress,
the web process ignores mouse move events and replies with
DidReceiveEvent signal. The DidReceiveEvent message handler in
WebPageProxy checks if we have a m_nextMouseMoveEvent and handles
it, but when all this happens synchronously the
m_nextMouseMoveEvent is the current one because we haven't
returned yet from handleMouseEvent(). We need to invalidate the
m_nextMouseMoveEvent before calling handleMouseEvent().
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
- 1:30 AM Changeset in webkit [196917] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WTF
Merge r196259 - Make sure that locking code that relies on module boundaries for compiler fences uses NEVER_INLINE
https://bugs.webkit.org/show_bug.cgi?id=153972
Reviewed by Andreas Kling.
When this code was written, we assumed that module boundaries were compiler fences. That might
not be the case if we ever do LTO.
- wtf/Lock.cpp:
(WTF::LockBase::lockSlow):
(WTF::LockBase::unlockSlow):
- wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionally):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::unparkAll):
(WTF::ParkingLot::forEach):
- wtf/WordLock.cpp:
(WTF::WordLock::lockSlow):
(WTF::WordLock::unlockSlow):
- 1:29 AM Changeset in webkit [196916] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r196257 - [GTK] Fix crash when creating webview with g_object_new
https://bugs.webkit.org/show_bug.cgi?id=153989
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2016-02-08
Reviewed by Carlos Garcia Campos.
g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL) crashes webkit
as _WebKitWebViewBasePrivate constructor requires a mainloop, but
webkit is only initialized when a context is created (which
doesn't happen with a direct call to g_object_new).
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- 1:25 AM Changeset in webkit [196915] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source
Merge r196253 - [GTK] WebKitWebView should send crossing events to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=153740
Reviewed by Michael Catanzaro.
Source/WebCore:
Update the target element under the mouse also when only updating
scrollbars, so that if the mouse enters the page when the window
is not active, the scroll animator is notified that the mouse
entered the scrollable area.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent): Call
updateMouseEventTargetNode() before early returning in case of
only updating scrollbars.
Source/WebKit2:
We don't currently handle crossing events in the web view
(enter/leave). That's why if you hover a scrollbar and leave the
window, the scrollbar is still rendered as hovered.
- Shared/gtk/WebEventFactory.cpp:
(WebKit::buttonForEvent): Handle the case of GDK_ENTER_NOTIFY and
GDK_LEAVE_NOTIFY events.
(WebKit::WebEventFactory::createWebMouseEvent): Ditto.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Add GDK_ENTER_NOTIFY_MASK and
GDK_LEAVE_NOTIFY_MASK flags to the web view event mask.
(webkitWebViewBaseCrossingNotifyEvent): Handle enter/leave notify
events by generating a mouse move event, ensuring the double to
int conversion will not cause any problem.
(webkit_web_view_base_class_init): Add an implementation for
enter_notify_event and leave_notify_event.
- 1:19 AM Changeset in webkit [196914] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196172 - [GTK] Scrollbars incorrectly rendered with older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=153861
Reviewed by Michael Catanzaro.
The theme doesn't really know it's a scrollbar. Older versions of
GTK+ require to explicitly add the scrollbar style class to the
child GtkStyleContext.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::createChildStyleContext):
- 1:18 AM Changeset in webkit [196913] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196171 - [GTK] Scrollbars not correctly rendered in non GNOME environments
https://bugs.webkit.org/show_bug.cgi?id=153860
Reviewed by Michael Catanzaro.
I noticed this in a matchbox environment, where there's no
gnome-setting-daemon running. The problem is only with the
scrollbars, because we initialize the GtkSettings in
RenderThemeGtk and notify the ScrollbarTheme when it changes, but
ScrollbarTheme is created before RenderThemeGtk so we initialize
the theme properties before the GtkSettings have been
initialized. We can just let the ScrollbarTheme monitor the
theme itself instead of relying on being notified by the WebCore
layer.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::themeChangedCallback):
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
- rendering/RenderThemeGtk.cpp:
(WebCore::gtkStyleChangedCallback): Deleted.
- 1:12 AM Changeset in webkit [196912] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r196112 - Do not show context menu when right clicking on a scrollbar
https://bugs.webkit.org/show_bug.cgi?id=153493
Reviewed by Michael Catanzaro.
Source/WebCore:
Scrollbars don't currently handle right clicks, but we are showing
the context menu when they are right clicked. This is not desired
at least in GTK+ and I've checked that it isn't consistent with
other applications in Mac either.
Test: fast/events/contextmenu-on-scrollbars.html
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
LayoutTests:
Add a test to check that context menu event is not sent when right
clicking on a scrollbar.
- fast/events/contextmenu-on-scrollbars-expected.txt: Added.
- fast/events/contextmenu-on-scrollbars.html: Added.
- 1:09 AM Changeset in webkit [196911] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10
Merge r196061 - [GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
https://bugs.webkit.org/show_bug.cgi?id=145253
Reviewed by Michael Catanzaro.
Source/WebCore:
The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.
LayoutTests:
Update test expectation.
- platform/gtk/TestExpectations:
- 1:07 AM Changeset in webkit [196910] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196055 - [TexMap] Don't use RELEASE_ASSERT in TextureMapperLayer::computeTransformsRecursive()
https://bugs.webkit.org/show_bug.cgi?id=153822
Reviewed by Carlos Garcia Campos.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
Use ASSERT to check that the m_children members are indeed children
of the current layer, RELEASE_ASSERT probably slipped in unnoticed
at some point.
- 1:07 AM Changeset in webkit [196909] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196054 - PlatformPathCairo: Lazily allocate the path surface
https://bugs.webkit.org/show_bug.cgi?id=153821
Reviewed by Carlos Garcia Campos.
Move the static variable that holds the Cairo surface into
the pathSurface() function (previously getPathSurface). This
way the surface will only be allocated once the function is
called for the first time from the CairoPath surface.
No change in functionality, just a cleanup.
- platform/graphics/cairo/PlatformPathCairo.cpp:
(WebCore::pathSurface):
(WebCore::CairoPath::CairoPath):
(WebCore::getPathSurface): Deleted.
- 1:06 AM Changeset in webkit [196908] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r196052 - ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result)
https://bugs.webkit.org/show_bug.cgi?id=153576
Patch by Fujii Hironori <Hironori.Fujii@jp.sony.com> on 2016-02-02
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/block/geometry-map-assertion-with-rounding-negative-half.html
The results of roundedIntPoint of FloatPoint and LayoutPoint may be different
because of the uniqueness of LayoutUnit::round introduced by this bug
<https://bugs.webkit.org/show_bug.cgi?id=107208>.
Should convert a FloatPoint to a LayoutPoint before rounding.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
LayoutTests:
- fast/block/geometry-map-assertion-with-rounding-negative-half-expected.txt: Added.
- fast/block/geometry-map-assertion-with-rounding-negative-half.html: Added.
- 1:04 AM Changeset in webkit [196907] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore
Merge r196051 - JSSymbolTableObject::deleteProperty() crashes deleting Symbols
https://bugs.webkit.org/show_bug.cgi?id=153816
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.
Changes JSSymbolTableObject::deleteProperty() to check if its
symbolTable() contains the property's uid() rather than publicName().
This ensures that it will not crash in the case of Symbols.
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::deleteProperty):
- tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:
(testGlobalProxy):
- tests/stress/regress-153816.js: Added.
(deleteSymbolFromJSSymbolTableObject):
- 1:01 AM Changeset in webkit [196906] by
-
- 5 edits in trunk
[css-grid] Swap columns and rows in grid shorthand
https://bugs.webkit.org/show_bug.cgi?id=154449
Reviewed by Darin Adler.
The spec was modified past December to change the order of
columns and rows in the grid shorthand:
https://github.com/w3c/csswg-drafts/commit/7454c7c8c5857b61bbbe2ee5f07803c264bf37e4
Updated the parsing and modified the tests to follow the new syntax.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridShorthand):
LayoutTests:
- fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- 1:00 AM Changeset in webkit [196905] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r196039 - WEBGL_debug_shaders should be disabled for OpenGLES backend also
https://bugs.webkit.org/show_bug.cgi?id=153788
Reviewed by Darin Adler.
WEBGL_debug_shaders extension is disabled for OpenGL backed platform
because the implementation is not fully compliant to the spec yet.
Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
should be disabled for OpenGLES backed platforms also.
No new tests, already covered by existing tests.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Deleted.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::supports):
- 12:55 AM Changeset in webkit [196904] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195965 - REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
https://bugs.webkit.org/show_bug.cgi?id=153727
<rdar://problem/24429886>
Reviewed by Chris Dumez.
The
thisobject may be freed after calling deleteIfPossible(). Make the early-return-if-
deleted more explicit, and only check allowsCaching() after the deleteIfPossible() return
value check.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
- 12:47 AM Changeset in webkit [196903] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195837 - [WebGL] Check vertex array bounds before permitting a glDrawArrays to execute
https://bugs.webkit.org/show_bug.cgi?id=153643
<rdar://problem/23424456>
Reviewed by Dean Jackson.
Tested by fast/canvas/webgl/webgl-drawarrays-crash.html.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateDrawArrays): Make sure that we have at
least one buffer bound to a program if a drawArray call with a non-zero range of
requested data is being made.
(WebCore::WebGLRenderingContextBase::validateDrawElements): Drive-by formatting fix.
LayoutTests:
Test to check for stack recursion when indexed propertyNames defined using Object.defineProperty are deleted.
https://bugs.webkit.org/show_bug.cgi?id=149179
<rdar://problem/22708019>.
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-12-22
Reviewed by Dean Jackson.
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt: Added.
- storage/domstorage/localstorage/delete-defineproperty-removal.html: Added.
- 12:43 AM Changeset in webkit [196902] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195809 - [GStreamer] built-in media player doesn't update
https://bugs.webkit.org/show_bug.cgi?id=151816
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The timeline of audio controls in media document is not properly updated since it is assumed
that the controls are hidden as soon as playing. However, such full page audio always has
opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
in controlsAreHidden();
Test: media/audio-controls-timeline-in-media-document.html
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):
LayoutTests:
- media/audio-controls-timeline-in-media-document-expected.txt: Added.
- media/audio-controls-timeline-in-media-document.html: Added.
- 12:35 AM Changeset in webkit [196901] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195705 - AX: Crash in AccessibilityTableColumn::headerObject
https://bugs.webkit.org/show_bug.cgi?id=153553
<rdar://problem/23196278>
Reviewed by Chris Fleizach.
Webkit was crashing sometimes when we asked for column headers of a table.
The columns vector of the table was reset during the iteration when we
were asking for the headerObject of each column. The column's addChildren()
function calls elementRect() for each child cell and that sometimes causes
the parent table to reset its children.
Fixed it by caching the columns vector and moving out the elementRect() logic
from AccessibilityTalbeColumn::addChildren().
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::addChildren):
- accessibility/AccessibilityTableColumn.h:
- 12:31 AM Changeset in webkit [196900] by
-
- 21 edits1 delete in trunk
Binding generator should support key value iterable
https://bugs.webkit.org/show_bug.cgi?id=154413
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-basic.html:
Source/WebCore:
Covered by added layout and binding tests.
iterable<key, value> in a IDL file will trigger the generation of entries, keys, values, [Symbol.iterator] and forEach methods to the prototype.
Updated FetchHeaders and FontFaceSet to use it.
IDLParser.pm parses the iterable<> and adds an iterable field in the interface containing the iterable information and objects for the five operations.
IDLParser.pm is cleaned up a bit to remove previous Iterator support, which does not seem to be supported.
CodeGeneratorJS.pm is updated to generate the code for the five operations, using JSKeyValueIterator. Set iterators are not yet supported.
Moved definition of Iterator Key and Value Type to binding generated JSXX class based on iterable<> declaration in the IDL.
Added binding test and Fetch Headers tests.
- CMakeLists.txt:
- Modules/fetch/FetchHeaders.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSFetchHeadersCustom.cpp: Removed.
- bindings/js/JSFontFaceSetCustom.cpp:
(WebCore::JSFontFaceSet::ready): Removed iterable custom methods.
- bindings/js/JSKeyValueIterator.h:
(WebCore::createKeyValueIterator):
(WebCore::keyValueIteratorForEach):
- bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionName):
(PrototypeFunctionCount):
(PrototypePropertyCount):
(GeneratePropertiesHashTable):
(GenerateImplementation):
(GenerateImplementationFunctionCall):
(GenerateImplementationIterableFunctions):
- bindings/scripts/IDLParser.pm:
(parseOperationOrIterator):
(parseOperationOrIteratorRest):
(parseIterableRest):
(parseOptionalIterableInterface):
(applyMemberList):
(parseSpecial): Deleted.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjPrototypeFunctionSymbolIterator):
(WebCore::jsTestObjPrototypeFunctionEntries):
(WebCore::jsTestObjPrototypeFunctionKeys):
(WebCore::jsTestObjPrototypeFunctionValues):
(WebCore::jsTestObjPrototypeFunctionForEach):
- bindings/scripts/test/TestObj.idl:
- css/FontFaceSet.idl:
- 12:14 AM Changeset in webkit [196899] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Merge r195652 - fast/history/page-cache-webdatabase-no-transaction-db.html flakily crashes
https://bugs.webkit.org/show_bug.cgi?id=153525
Reviewed by Andreas Kling.
Source/WebCore:
The test was crashing because DatabaseThread::hasPendingDatabaseActivity()
was accessing m_openDatabaseSet from the main thread without any locking
mechanism. This is an issue because m_openDatabaseSet is altered by the
database thread.
No new tests, already covered by fast/history/page-cache-webdatabase-no-transaction-db.html.
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::DatabaseThread::hasPendingDatabaseActivity):
- Modules/webdatabase/DatabaseThread.h:
LayoutTests:
Unskip fast/history/page-cache-webdatabase-no-transaction-db.html now
that it no longer crashes.
- 12:06 AM Changeset in webkit [196898] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195596 - Do not convert GlyphBufferAdvance to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=153429
GlyphBufferAdvance is not necessaryly convertible to FloatSize.
Also, this code was doing extra work by transforming height value.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Antti Koivisto.
No new tests needed.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::extents):
- 12:02 AM Changeset in webkit [196897] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195540 - Media "ended" event incorrectly fires when currentTime is set
https://bugs.webkit.org/show_bug.cgi?id=150348
<rdar://problem/24247974>
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-ended-fired-once.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::invalidateCachedTime): Always mark m_cachedTime as invalid.
LayoutTests:
- media/media-ended-fired-once-expected.txt: Added.
- media/media-ended-fired-once.html: Added.
Feb 21, 2016:
- 11:29 PM Changeset in webkit [196896] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeBlock always visits its unlinked code twice
https://bugs.webkit.org/show_bug.cgi?id=154494
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-21
Reviewed by Saam Barati.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitChildren):
The unlinked code is always visited in stronglyVisitStrongReferences.
- 10:30 PM Changeset in webkit [196895] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline html/dom/interfaces.html.
- web-platform-tests/html/dom/interfaces-expected.txt:
- 10:28 PM Changeset in webkit [196894] by
-
- 19 edits in trunk
HTMLScriptElement.crossOrigin / HTMLImageElement.crossOrigin should only return known values
https://bugs.webkit.org/show_bug.cgi?id=154502
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/reflection-embedded-expected.txt:
- web-platform-tests/html/dom/reflection-misc-expected.txt:
Source/WebCore:
HTMLScriptElement.crossOrigin / HTMLImageElement.crossOrigin should only
return known values and should be nullable as per the specification:
- https://html.spec.whatwg.org/multipage/scripting.html#attr-script-crossorigin
- https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-crossorigin
- https://html.spec.whatwg.org/multipage/infrastructure.html#cors-settings-attribute
This aligns our behavior with the HTML specification and Firefox.
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
Add support for nullable DOMString attributes. If such attribute is
marked as nullable:
- A null string is passed to the implementation if the setter is called with null/undefined.
- null is returned to the Javascript if the getter implementation returns a null string.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
Add test coverage for nullable DOMString attributes
and rebaseline bindings tests.
- html/HTMLImageElement.cpp:
- html/HTMLImageElement.h:
- html/HTMLImageElement.idl:
- html/HTMLScriptElement.cpp:
- html/HTMLScriptElement.h:
- html/HTMLScriptElement.idl:
- html/parser/HTMLParserIdioms.cpp:
- html/parser/HTMLParserIdioms.h:
- 9:52 PM Changeset in webkit [196893] by
-
- 14 edits1 add6 deletes in trunk
Make HTMLSelectElement.size behave as per the specification
https://bugs.webkit.org/show_bug.cgi?id=154504
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/reflection-forms-expected.txt:
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
Source/WebCore:
Make HTMLSelectElement.size behave as per the specification:
- https://html.spec.whatwg.org/#htmlselectelement
- https://html.spec.whatwg.org/#dom-select-size
- https://html.spec.whatwg.org/#reflecting-content-attributes-in-idl-attributes:idl-unsigned-long
In particular, it should be unsigned and be in the range [0; 2147483647].
Also update several unsigned long attributes in our HTML implementation to use
parseHTMLNonNegativeInteger() to parse unsigned integers as per the HTML
specification, instead of calling String::toUint().
No new tests, already covered by existing tests.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::size):
(WebCore::HTMLInputElement::setSize):
- html/HTMLInputElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::setSize):
(WebCore::HTMLSelectElement::namedItem): Deleted.
(WebCore::HTMLSelectElement::item): Deleted.
- html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::size):
- html/HTMLSelectElement.idl:
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
(WebCore::HTMLTableColElement::setSpan):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseAttribute):
(WebCore::HTMLTextAreaElement::setCols):
(WebCore::HTMLTextAreaElement::setRows):
- html/parser/HTMLParserIdioms.h:
(WebCore::limitToOnlyHTMLNonNegativeNumbersGreaterThanZero):
(WebCore::limitToOnlyHTMLNonNegative):
LayoutTests:
Update test that was covering the case of an HTMLSelectElement with an
invalid size attribute. The test was expecting the bad "size" attribute
value to get corrected so that the select element looks like a menu list.
This workaround was added back in 2007 to workaround a bug on
www.chainreaction.com (rdar://problem/4697438). This patch drops the
workaround in HTMLSelectElement::parseAttribute() because:
- This is not standard behavior as per the HTML specification
- This behavior does not match Firefox either
- The workaround is no longer needed for www.chainreaction.com.
- fast/forms/select-size-expected.html: Added.
- fast/forms/select-size.html:
- platform/efl/fast/forms/select-size-expected.txt: Removed.
- platform/gtk/fast/forms/select-size-expected.txt: Removed.
- platform/ios-simulator/fast/forms/select-size-expected.txt: Removed.
- platform/mac/fast/forms/select-size-expected.png: Removed.
- platform/mac/fast/forms/select-size-expected.txt: Removed.
- platform/win/fast/forms/select-size-expected.txt: Removed.
- 9:26 PM Changeset in webkit [196892] by
-
- 4 edits in trunk
CSP: Enable form-action directive by default
https://bugs.webkit.org/show_bug.cgi?id=154520
<rdar://problem/24762029>
Reviewed by Sam Weinig.
Source/WebCore:
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Move logic to parse the form-action
directive outside the ENABLE(CSP_NEXT) macro guarded section/experimental feature runtime flag.
(WebCore::isExperimentalDirectiveName): Remove form-action from the directives considered
experimental.
LayoutTests:
Mark form-action tests as Pass so that we run them.
- 8:49 PM Changeset in webkit [196891] by
-
- 9 edits2 moves2 adds in trunk/Source
Web Inspector: add 'Automation' protocol domain and generate its backend classes separately in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=154509
<rdar://problem/24759098>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Add a new 'WebKit' framework, which is used to generate protocol code
in WebKit2.
Add --backend and --frontend flags to the main generator script.
These allow a framework to trigger two different sets of generators
so they can be separately generated and compiled.
- inspector/scripts/codegen/models.py:
(Framework.fromString):
(Frameworks): Add new framework.
- inspector/scripts/generate-inspector-protocol-bindings.py:
If neither --backend or --frontend is specified, assume both are wanted.
This matches the behavior for JavaScriptCore and WebInspector frameworks.
(generate_from_specification):
Generate C++ files for the backend and Objective-C files for the frontend.
Source/WebKit2:
Add a new 'Automation' domain which presents an RPC interface
for sending automation commands to an active WebAutomationSession
in the UIProcess via RemoteInspector. This is similar to how the
Inspector backend communicates bidirectionally with a remote
Inspector frontend.
Add build system logic to generate JSON-RPC protocol bindings
for the 'Automation' domain using the inspector code generators.
Move automation-related files that are not API or SPI into their
own directory.
- Configurations/BaseTarget.xcconfig: Tell where JavaScriptCore's
private headers are, since that's where the code generators live.
- CMakeLists.txt: Look in UIProcess/Automation directory.
- PlatformMac.cmake:
- DerivedSources.make: Generate protocol bindings for a single domain.
The names of the generated files will be improved in a follow-up patch
so that they do not clash with generated files in JavaScriptCore.
- UIProcess/Automation/Automation.json: Added.
- UIProcess/Automation/WebAutomationSession.cpp: Renamed from Source/WebKit2/UIProcess/WebAutomationSession.cpp.
(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::~WebAutomationSession):
Set up a backend dispatcher and frontend router. They will be used later.
(WebKit::WebAutomationSession::dispatchMessageFromRemote):
Forward messages from the remote to the backend dispatcher. When
an agent / command handler is registered, it will receive the message.
(WebKit::WebAutomationSession::connect):
(WebKit::WebAutomationSession::disconnect):
Connenct and disconnect the frontend router to the remote channel.
- UIProcess/Automation/WebAutomationSession.h: Renamed from Source/WebKit2/UIProcess/WebAutomationSession.h.
- WebKit2.xcodeproj/project.pbxproj: Add and move files.
- 7:28 PM Changeset in webkit [196890] by
-
- 24 edits3 adds in trunk
Add username / password attributes to HTMLAnchorElement / HTMLAreaElement
https://bugs.webkit.org/show_bug.cgi?id=154519
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add username / password attributes to HTMLAnchorElement / HTMLAreaElement as per:
https://html.spec.whatwg.org/#htmlhyperlinkelementutils
Firefox and Chrome already implement these.
Also stop treating null as the empty string for the HTMLHyperlinkElementUtils
attributes. This behavior does not match the specification or other browsers
(tested Firefox and Chrome).
Test: fast/dom/HTMLAnchorElement/set-href-attribute-user-pass.html
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::username):
(WebCore::HTMLAnchorElement::setUsername):
(WebCore::HTMLAnchorElement::password):
(WebCore::HTMLAnchorElement::setPassword):
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLHyperlinkElementUtils.idl: Added.
LayoutTests:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hostname.js:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-search.js:
- fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
- fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt:
- fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt:
- fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt:
- fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt:
Update / rebaseline tests now that we no longer treat null as the empty string.
- fast/dom/HTMLAnchorElement/set-href-attribute-user-pass-expected.txt: Added.
- fast/dom/HTMLAnchorElement/set-href-attribute-user-pass.html: Added.
Add test coverage for setting the username / password attributes.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
Rebaseline now that HTMLAnchorElement / HTMLAreaElement have 2 additional
attributes: username and password.
- 7:27 PM Changeset in webkit [196889] by
-
- 6 edits2 adds in trunk
iframe/frame/object.contentDocument should be on the prototype
https://bugs.webkit.org/show_bug.cgi?id=154409
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move iframe/frame/object.contentDocument to the prototype. They used
to be on the instance due to the [CheckSecurityForNode] IDL extended
attribute. This patch updates the bindings generator so that such
attributes are now on the prototype. While they are now on the
prototype, the security checks are still generated in the
corresponding getters and setters so cross origin access is still
prevented.
Test: http/tests/security/cross-origin-iframe-contentDocument.html
- bindings/scripts/CodeGeneratorJS.pm:
(AttributeShouldBeOnInstance): Deleted.
LayoutTests:
Add test coverage for trying to access iframe.contentDocument cross origin
to make sure it still fails and logs a security error.
- http/tests/security/cross-origin-iframe-contentDocument-expected.txt: Added.
- http/tests/security/cross-origin-iframe-contentDocument.html: Added.
- 6:33 PM Changeset in webkit [196888] by
-
- 15 edits in trunk/Source
Refactor LazyEventListener creation to separate Element and Document cases
https://bugs.webkit.org/show_bug.cgi?id=154231
Reviewed by Andreas Kling.
Source/WebCore:
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::create): Added. Newly factored to separate
Element, Document, and DOMWindow with overloading.
(WebCore::JSLazyEventListener::createForNode): Deleted.
(WebCore::JSLazyEventListener::createForDOMWindow): Deleted.
- bindings/js/JSLazyEventListener.h: Replaced the separate createForNode
and createForDOMWindow functions with a single overloaded function create,
which takes an Element, Document, or DOMWindow. Also changed indentation
to match the style guide.
- dom/Attr.h: Added newly needed forward class declaration.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::setAttributeEventListener): Deleted.
- dom/ContainerNode.h: Deleted setAttributeEventListener override; it's now
done separately by Element and Document.
- dom/Document.cpp:
(WebCore::Document::setAttributeEventListener): Added. Makes the lazy event
listener and calls through to the base class's setAttributeEventListener.
(WebCore::Document::setWindowAttributeEventListener): Updated to call just
create instead of createForDOMWindow.
- dom/Document.h: Removed some unneeded forward declarations. Added the
overload for setAttributeEventListener. Removed a no longer useful comment.
- dom/Element.cpp:
(WebCore::Element::setAttributeEventListener): Added. Makes the lazy event
listener and calls through to the base class's setAttributeEventListener.
- dom/Element.h: Removed some unneeded forward declarations. Added the
overload for setAttributeEventListener.
- dom/Node.h: Removed many unneeded forward declarations.
- dom/NodeRareData.h: Added one forward declaration.
- editing/Editor.h: Added one forward declaration.
Source/WebKit/win:
- WebView.h: Forward declare KeyboardEvent.
- 5:55 PM Changeset in webkit [196887] by
-
- 8 edits in trunk/Source/JavaScriptCore
Improvements to Intl code
https://bugs.webkit.org/show_bug.cgi?id=154486
Reviewed by Darin Adler.
This patch does several things:
- Use std::unique_ptr to store ICU objects.
- Pass Vector::size() to ICU functions that take a buffer size instead of Vector::capacity().
- If U_SUCCESS(status) is true, it means there is no error, but there could be warnings. ICU functions ignore warnings. So, there is no need to reset status to U_ZERO_ERROR.
- Remove the initialization of the String instance variables of IntlDateTimeFormat. These values are never read and cause unnecessary memory allocation.
- Fix coding style.
- Some small optimization.
- runtime/IntlCollator.cpp:
(JSC::IntlCollator::UCollatorDeleter::operator()):
(JSC::IntlCollator::createCollator):
(JSC::IntlCollator::compareStrings):
(JSC::IntlCollator::~IntlCollator): Deleted.
- runtime/IntlCollator.h:
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::UDateFormatDeleter::operator()):
(JSC::defaultTimeZone):
(JSC::canonicalizeTimeZoneName):
(JSC::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::weekdayString):
(JSC::IntlDateTimeFormat::format):
(JSC::IntlDateTimeFormat::~IntlDateTimeFormat): Deleted.
(JSC::localeData): Deleted.
- runtime/IntlDateTimeFormat.h:
- runtime/IntlDateTimeFormatConstructor.cpp:
- runtime/IntlNumberFormatConstructor.cpp:
- runtime/IntlObject.cpp:
(JSC::numberingSystemsForLocale):
- 5:45 PM Changeset in webkit [196886] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove arrowfunction test cases that rely on arguments variable in jsc
https://bugs.webkit.org/show_bug.cgi?id=154517
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-02-21
Reviewed by Yusuke Suzuki.
Allow to jsc has the same behavior in javascript as browser has
- tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js:
- tests/stress/arrowfunction-lexical-bind-arguments-strict.js:
- 5:30 PM Changeset in webkit [196885] by
-
- 1 edit3 adds in trunk/LayoutTests
CSP: sandbox directive should be ignored when contained in a policy defined via a meta element
https://bugs.webkit.org/show_bug.cgi?id=154299
<rdar://problem/24680433>
Add iOS Simulator-specific expected result for test http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe.html.
- platform/ios-simulator/http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe-expected.txt: Added.
- 5:29 PM Changeset in webkit [196884] by
-
- 1 edit1 add in trunk/LayoutTests
Adding ios-simulator baseline for js/number-toLocaleString.html
https://bugs.webkit.org/show_bug.cgi?id=154524
Unreviewed test gardening.
- platform/ios-simulator/js/number-toLocaleString-expected.txt: Added.
- 5:27 PM Changeset in webkit [196883] by
-
- 8 edits in trunk/LayoutTests/imported/w3c
Re-sync W3C HTML/DOM web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=154513
Reviewed by Darin Adler.
Re-sync W3C HTML/DOM web-platform-tests after:
- https://github.com/w3c/web-platform-tests/pull/2597
- https://github.com/w3c/web-platform-tests/pull/2598
- https://github.com/w3c/web-platform-tests/pull/2599
- web-platform-tests/html/dom/elements-embedded.js:
- web-platform-tests/html/dom/elements-misc.js:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/dom/reflection-embedded-expected.txt:
- web-platform-tests/html/dom/reflection-misc-expected.txt:
- web-platform-tests/html/dom/reflection.js:
(ReflectionTests.doReflects):
- 5:23 PM Changeset in webkit [196882] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/reflection-forms.html for ios-simulator after r196846
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
- 4:08 PM Changeset in webkit [196881] by
-
- 10 edits in trunk/Source/JavaScriptCore
Web Inspector: it should be possible to omit generated code guarded by INSPECTOR_ALTERNATE_DISPATCHERS
https://bugs.webkit.org/show_bug.cgi?id=154508
<rdar://problem/24759077>
Reviewed by Timothy Hatcher.
In preparation for being able to generate protocol files for WebKit2,
make it possible to not emit generated code that's guarded by
ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS). This code is not needed by
backend dispatchers generated outside of JavaScriptCore. We can't just
define it to 0 for WebKit2, since it's defined to 1 in <wtf/Platform.h>
in the configurations where the code is actually used.
Add a new opt-in Framework configuration option that turns on generating
this code. Adjust how the code is generated so that it can be easily excluded.
- inspector/scripts/codegen/cpp_generator_templates.py:
Make a separate template for the declarations that are guarded.
Add an initializer expression so the order of initalizers doesn't matter.
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:
(CppBackendDispatcherHeaderGenerator.generate_output): Add a setting check.
(CppBackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain):
If the declarations are needed, they will be appended to the end of the
declarations list.
- inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:
(CppBackendDispatcherImplementationGenerator.generate_output): Add a setting check.
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command): Add a setting check.
- inspector/scripts/codegen/models.py: Set the 'alternate_dispatchers' setting
to True for Framework.JavaScriptCore only. It's not needed elsewhere.
Rebaseline affected tests.
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- 4:05 PM Changeset in webkit [196880] by
-
- 15 edits in trunk/Source/JavaScriptCore
Web Inspector: clean up generator selection in generate-inspector-protocol-bindings.py
https://bugs.webkit.org/show_bug.cgi?id=154505
<rdar://problem/24758042>
Reviewed by Timothy Hatcher.
It should be possible to generate code for a framework using some generators
that other frameworks also use. Right now the generator selection code assumes
that use of a generator is mutually exclusive among non-test frameworks.
Make this code explicitly switch on the framework. Reorder generators
alpabetically within each case.
- inspector/scripts/generate-inspector-protocol-bindings.py:
(generate_from_specification):
Rebaseline tests that are affected by generator reorderings.
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- 3:02 PM Changeset in webkit [196879] by
-
- 2 edits3 moves in trunk/LayoutTests
Another attempt to fix the Content Extension test failures following <https://trac.webkit.org/changeset/196875>
(https://bugs.webkit.org/show_bug.cgi?id=154307)
Rename Content Extension JSON files so that they are associated with tests http/tests/contentextensions/block-cookies-in-csp-report.php
http/tests/contentextensions/block-csp-report.php and http/tests/contentextensions/hide-on-csp-report.php. These
files were formerly named block-cookies-in-csp-report.html, block-csp-report.html, and hide-on-csp-report.html,
respectively, prior to <https://trac.webkit.org/changeset/196878>. Also, update expected result for test block-csp-report.html
following <https://trac.webkit.org/changeset/196878>.
- http/tests/contentextensions/block-cookies-in-csp-report.php.json: Renamed from LayoutTests/http/tests/contentextensions/block-cookies-in-csp-report.html.json.
- http/tests/contentextensions/block-csp-report-expected.txt:
- http/tests/contentextensions/block-csp-report.php.json: Renamed from LayoutTests/http/tests/contentextensions/block-csp-report.html.json.
- http/tests/contentextensions/hide-on-csp-report.php.json: Renamed from LayoutTests/http/tests/contentextensions/hide-on-csp-report.html.json.
- 1:37 PM Changeset in webkit [196878] by
-
- 1 edit3 moves in trunk/LayoutTests
Attempt to fix the Content Extension test failures following <https://trac.webkit.org/changeset/196875>
(https://bugs.webkit.org/show_bug.cgi?id=154307)
Convert Content Extension tests that use the Content Security Policy directive report-uri from HTML files
to PHP scripts and modified them to define the content security policy for the page via the Content-Security-Policy
HTTP header instead of via a meta element so that the report-uri directive is honored. Following
<https://trac.webkit.org/changeset/196875> the directive report-uri is only honored when contained in a
policy that is delivered via an HTTP header. That is, it is no longer honored when delivered in a meta element.
- http/tests/contentextensions/block-cookies-in-csp-report.php: Renamed from LayoutTests/http/tests/contentextensions/block-cookies-in-csp-report.html.
- http/tests/contentextensions/block-csp-report.php: Renamed from LayoutTests/http/tests/contentextensions/block-csp-report.html.
- http/tests/contentextensions/hide-on-csp-report.php: Renamed from LayoutTests/http/tests/contentextensions/hide-on-csp-report.html.
- 11:51 AM Changeset in webkit [196877] by
-
- 6 edits in trunk
CSP: Violation report should include column number
https://bugs.webkit.org/show_bug.cgi?id=154418
<rdar://problem/24729525>
Reviewed by Brent Fulgham.
Source/WebCore:
Include column-number in the Content Security Policy violation report for the column number
in the source script where the violation occurred (for a script violation) as per section
Reporting of the Content Security Policy 2.0 spec., <https://www.w3.org/TR/2015/CR-CSP2-20150721/>.
When a CSP report is created for a script violation the source file and line number of the
source code line where the violation occurred are included in the report. We now include
the column number in the source file where the violation occurred so as to help narrow
down the operation that triggered the violation in a complicated source code line.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
LayoutTests:
Update expected results to include source file column information where the violation occurred.
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt:
- 11:45 AM Changeset in webkit [196876] by
-
- 24 edits1 move2 adds in trunk
CSP: Violation report should include HTTP status code and effective-directive of protected resource
https://bugs.webkit.org/show_bug.cgi?id=154288
<rdar://problem/24674982>
And
https://bugs.webkit.org/show_bug.cgi?id=115707
<rdar://problem/24383128>
Reviewed by Brent Fulgham.
Source/WebCore:
Include status-code and effective-directive in the Content Security Policy violation report for
the HTTP status code of the protected resource and name of the policy directive that was violated,
respectively, as per section Reporting of the Content Security Policy 2.0 spec., <https://www.w3.org/TR/2015/CR-CSP2-20150721/>.
Test: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation): Add key status-code to the report with value
equal to the HTTP response code for the document or 0 depending on whether the document was
delivered over HTTP or not. Additionally, remove ENABLE(CSP_NEXT)-guard/experimentalFeaturesEnabled()-condition
around code to include the effective-directive property in the report.
LayoutTests:
Add new test http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html to ensure
that the CSP report property status-code is 0 when the protected document is delivered over HTTPS. Fix a
correctness issue in the result for test http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
and update the expected results for the following tests now that the CSP violation report includes properties
status-code and effective-directive:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.php
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.php
http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.php
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.php
The rest of the changes to the expected results are cosmetic and reflect the difference in wording for inline
script violations between WebKit and Blink. We will consider adopting wording similar to Blink in
<https://bugs.webkit.org/show_bug.cgi?id=153242>.
- TestExpectations: Remove entries for tests that now pass. Add test http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.php.
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html. The report-uri
directive is only honored when defined in a policy delivered via an HTTP header. We convert this
HTML file to a PHP script to be able to deliver a Content-Security-Policy HTTP header.
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Cosmetic change.
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt: Update expected result now
that the report includes properties status-code and effective-directive.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-only-expected.txt: Cosmetic change.
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled-expected.txt: Update expected result now
that the report includes properties status-code and effective-directive.
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt: Cosmetic change.
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt: Update expected result now
that the report includes properties status-code and effective-directive.
- http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html: Added.
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Cosmetic change.
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Cosmetic change.
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html: Fix ill-formed markup; substitute </iframe> for </script>.
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Cosmetic change.
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Ditto.
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt: Ditto.
- 11:04 AM Changeset in webkit [196875] by
-
- 22 edits16 moves3 adds2 deletes in trunk
CSP: report-url directive should be ignored when contained in a policy defined via a meta element
https://bugs.webkit.org/show_bug.cgi?id=154307
<rdar://problem/24684817>
Reviewed by Brent Fulgham.
Source/WebCore:
The Content Security Policy report-uri directive should only be honored when defined via an HTTP header
as per section report-uri of the Content Security Policy 2.0 spec., <https://www.w3.org/TR/2015/CR-CSP2-20150721/>.
Currently we honor the report-uri directive when enforcing or monitoring a policy defined either via
an HTML meta element or an HTTP header. Instead we should only honor this directive when defined
via an HTTP header and log a message to the Web Inspector console to explain that the directive
was ignored as suggested in <https://www.w3.org/TR/2015/CR-CSP2-20150721/#delivery-html-meta-element>.
Test: http/tests/security/contentSecurityPolicy/report-uri-in-meta-tag-ignored.html
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::parse): Modified to ignore the directive report-uri when
the Content Security Policy came from an HTML meta element.
LayoutTests:
Add new test http/tests/security/contentSecurityPolicy/report-uri-in-meta-tag-ignored.html and rename and modify
existing tests to make them PHP scripts that emit a Content Security Policy HTTP header.
In addition, remove file http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html that
is no longer meaningful now that we do not honor the report-uri directive defined in a policy via a meta
element. Moreover, we have not made use of this file since <http://trac.webkit.org/changeset/176413>.
- TestExpectations: Update entries for renames.
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-and-enforce.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-and-enforce.html.
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html.
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html.
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin.html.
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-blocked-uri.html.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.html.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.html.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.html.
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-only.html.
- http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.html.
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.html.
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies.html.
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript.html.
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-uri-from-javascript.html.
- http/tests/security/contentSecurityPolicy/report-uri-in-meta-tag-ignored-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-uri-in-meta-tag-ignored.html: Added.
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative.html: Removed.
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative.php: Added.
- http/tests/security/contentSecurityPolicy/report-uri.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/report-uri.html.
- http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html: Removed. For completeness, we have
not made use of this file since <http://trac.webkit.org/changeset/176413>.
- http/tests/security/contentSecurityPolicy/resources/generate-csp-report.php:
- http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html.
- platform/wk2/TestExpectations: Update entries for renames.
- 10:52 AM Changeset in webkit [196874] by
-
- 7 edits2 moves6 adds6 deletes in trunk
CSP: sandbox directive should be ignored when contained in a policy defined via a meta element
https://bugs.webkit.org/show_bug.cgi?id=154299
<rdar://problem/24680433>
Reviewed by Brent Fulgham.
Source/WebCore:
The Content Security Policy sandbox directive should only be honored when enforcing a policy
defined via an HTTP header as per section sandbox of the Content Security Policy 2.0 spec.,
<https://www.w3.org/TR/2015/CR-CSP2-20150721/>.
Currently we honor the sandbox directive when enforcing a policy defined either via an HTML
meta element or an HTTP header. Instead we should only honor this directive when defined
via an HTTP header and log a message to the Web Inspector console to explain that the directive
was ignored as suggested in <https://www.w3.org/TR/2015/CR-CSP2-20150721/#delivery-html-meta-element>.
Tests: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header2.php
http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe.php
http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header.php
http/tests/security/contentSecurityPolicy/sandbox-in-meta-tag-ignored.html
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Substitute ContentSecurityPolicy::processHTTPEquiv() for
ContentSecurityPolicy::didReceiveHeader() as the latter was made private.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom): Updated as needed based on ContentSecurityPolicy::didReceiveHeader() change below.
(WebCore::ContentSecurityPolicy::didReceiveHeaders): Ditto.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Modified to take argument of type ContentSecurityPolicy::PolicyFrom
and pass it through to ContentSecurityPolicyDirectiveList::create().
(WebCore::ContentSecurityPolicy::reportInvalidDirectiveInHTTPEquivMeta): Logs a message to the Web Inspector console
that the specified directive was ignored because it was delivered via an HTML meta element.
- page/csp/ContentSecurityPolicy.h: Made member function ContentSecurityPolicy::didReceiveHeader() private. Defined
enum class PolicyFrom to represent the source of the Content Security Policy: HTTP equiv meta element, HTTP header, or
inherited from another ContentSecurityPolicy object (this value is only used by ContentSecurityPolicy::copyStateFrom()).
(WebCore::ContentSecurityPolicy::processHTTPEquiv): Added; turns around and calls ContentSecurityPolicy::didReceiveHeader().
The name of this function better describes its purpose - to handle the processing of a Content Security Policy
delivered via <meta http-equiv="Content-Security-Policy" content="...">.
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::create): Modified to take argument of type ContentSecurityPolicy::PolicyFrom
as pass it through to ContentSecurityPolicyDirectiveList::parse().
(WebCore::ContentSecurityPolicyDirectiveList::parse): Modified to ignore the directive sandbox when the Content Security
Policy came from an HTML meta element.
- page/csp/ContentSecurityPolicyDirectiveList.h:
LayoutTests:
Add test http/tests/security/contentSecurityPolicy/sandbox-in-meta-tag-ignored.html to ensure that we ignore
the sandbox directive when delivered via an HTML meta element and log a message to the Web Inspector console.
Remove tests http/tests/security/contentSecurityPolicy/sandbox-{allow-scripts-subframe, empty, empty-subframe}.html
that are no longer meaningful now that we ignore the sandbox directive when delivered via an HTML meta element and
create analogous tests for when the sandbox directive is delivered via an HTTP header.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header2-expected.txt: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-expected.txt.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header2.php: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/sandbox-allow-scripts.html.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-subframe.html: Removed.
This test is no longer meaningful now that we ignore the sandbox directive when delivered via an HTML meta element.
An analogous test for when the directive is delivered via an HTTP header is http/tests/security/contentSecurityPolicysandbox-allow-scripts-in-http-header.html.
- http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe.php: Added. Derived from test http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html.
- http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header.php: Added. Derived from test http/tests/security/contentSecurityPolicy/sandbox-empty.html.
- http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/sandbox-empty-subframe.html: Removed.
This test is no longer meaningful now that we ignore the sandbox directive when delivered via an HTML meta element.
The analogous test for when the directive is delivered via an HTTP header is http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header-inherited-by-subframe.php.
- http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/sandbox-empty.html: Removed.
This test is no longer meaningful now that we ignore the sandbox directive when delivered via an HTML meta element.
The analogous test for when the directive is delivered via an HTTP header is http/tests/security/contentSecurityPolicy/sandbox-empty-in-http-header.php.
- http/tests/security/contentSecurityPolicy/sandbox-in-meta-tag-ignored-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-in-meta-tag-ignored.html: Added.
- 10:43 AM Changeset in webkit [196873] by
-
- 11 edits in trunk/Source/bmalloc
bmalloc: Don't use a whole page for metadata
https://bugs.webkit.org/show_bug.cgi?id=154510
Reviewed by Andreas Kling.
(1) Don't round up metadata to a page boundary. This saves 1.5% dirty
memory on iOS and 0.2% on Mac. It also enables a future patch to allocate
smaller chunks without wasting memory.
(2) Initialize metadata lazily. This saves dirty memory when the program
allocates primarily small or large objects (but not both), leaving some
metadata uninitialized.
- bmalloc.xcodeproj/project.pbxproj: Medium objects are gone now.
- bmalloc/BumpAllocator.h:
(bmalloc::BumpAllocator::refill): Added an ASSERT to help debug a bug
I cause while working on this patch.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateSmallBumpRanges): Ditto.
(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::allocateLarge): Updated for interface change.
- bmalloc/LargeChunk.h: Changed the boundaryTagCount calculation to
a static_assert.
Don't round up to page boundary. (See above.)
(bmalloc::LargeChunk::LargeChunk): Moved code here from LargeChunk::init.
A constructor is a more natural / automatic way to do this initialization.
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::init): Deleted. Moved to LargeChunk.
- bmalloc/Sizes.h: Chagned largeChunkMetadataSize to a simpler constant
because metadata size no longer varies by page size.
- bmalloc/SmallChunk.h:
(bmalloc::SmallChunk::begin):
(bmalloc::SmallChunk::end):
(bmalloc::SmallChunk::lines):
(bmalloc::SmallChunk::pages): Use std::array to make begin/end
calculations easier.
(bmalloc::SmallChunk::SmallChunk): Treat our metadata like a series
of allocated objects. We used to avoid trampling our metadata by
starting object memory at the next page. Now we share the first page
between metadata and objects, and we account for metadata explicitly.
- bmalloc/SuperChunk.h:
(bmalloc::SuperChunk::SuperChunk):
(bmalloc::SuperChunk::smallChunk):
(bmalloc::SuperChunk::largeChunk):
(bmalloc::SuperChunk::create): Deleted. Don't eagerly run the SmallChunk
and LargeChunk constructors. We'll run them lazily as needed.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::VMHeap):
(bmalloc::VMHeap::allocateSmallChunk):
(bmalloc::VMHeap::allocateLargeChunk):
(bmalloc::VMHeap::allocateSuperChunk):
(bmalloc::VMHeap::grow): Deleted. Track small and large chunks explicitly
so we can initialize them lazily.
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateSmallPage):
(bmalloc::VMHeap::allocateLargeObject): Specify whether we're allocating
a small or large chunk since we don't allocate both at once anymore.
- 10:18 AM Changeset in webkit [196872] by
-
- 7 edits2 deletes in trunk
Unreviewed, rolling out r196866.
https://bugs.webkit.org/show_bug.cgi?id=154515
still crashy on EFL/GTK (Requested by smfr on #webkit).
Reverted changeset:
"Wheel event callback removing the window causes crash in
WebCore."
https://bugs.webkit.org/show_bug.cgi?id=150871
http://trac.webkit.org/changeset/196866
Feb 20, 2016:
- 10:14 PM Changeset in webkit [196871] by
-
- 4 edits in trunk/Source
Use of inlined asm statements causes problems for -std=c99 builds.
https://bugs.webkit.org/show_bug.cgi?id=154507
Reviewed by Dan Bernstein.
Source/bmalloc:
- bmalloc/BAssert.h:
Source/WTF:
WTF's Assertions.h may inadvertantly get included by other projects that are built
with -std=c99. The use of the inlined asm statements with the keyword "asm" is
not recognized when the -std compiler flag is used.
https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html says "When writing code that
can be compiled with -ansi and the various -std options, use asm instead of
asm (see Alternate Keywords)."
So, to be a good citizen, we can change the use of "asm" in CRASH() to "asm"
so that we don't break the build of such other projects.
- wtf/Assertions.h:
- 5:54 PM Changeset in webkit [196870] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Add the support for universal slave password
https://bugs.webkit.org/show_bug.cgi?id=154476
Reviewed by David Kilzer.
Added the support for universalSlavePassword.
- config.json:
- public/include/report-processor.php:
(ReportProcessor::process):
(ReportProcessor::authenticate_and_construct_build_data): Extracted from process().
- 4:17 PM Changeset in webkit [196869] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Opacity slider thumb sometimes goes past the bar in Visual Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=154497
Patch by Devin Rousso <Devin Rousso> on 2016-02-20
Reviewed by Timothy Hatcher.
Since WebInspector.Slider uses CSS transforms to move the slider knob
along the track, if the width of the track changes then the position
of the knob would stay the same since it was translated instead of
adjusting its position relative to the new width.
- UserInterface/Views/Slider.js:
(WebInspector.Slider.prototype.recalculateKnobX):
Resets the maxX value to 0 to ensure that a new maxX is calculated with
the current width.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.set specifiedWidth): Deleted.
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.recalculateWidth):
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
(WebInspector.VisualStyleDetailsPanel.prototype._updateProperties):
(WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
- UserInterface/Views/VisualStyleUnitSlider.js:
(WebInspector.VisualStyleUnitSlider.prototype.recalculateWidth):
- 3:51 PM Changeset in webkit [196868] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
[ES6] Implement Proxy.Construct
https://bugs.webkit.org/show_bug.cgi?id=154440
Reviewed by Oliver Hunt.
This patch is mostly an implementation of
Proxy.Construct with respect to section 9.5.13
of the ECMAScript spec.
https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-construct-argumentslist-newtarget
This patch also changes op_create_this to accept new.target's
that aren't JSFunctions. This is necessary implementing Proxy.Construct
because we might construct a JSFunction with a new.target being
a Proxy. This will also be needed when we implement Reflect.construct.
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::finishCreation):
(JSC::ProxyObject::visitChildren):
(JSC::performProxyConstruct):
(JSC::ProxyObject::getConstructData):
- runtime/ProxyObject.h:
- tests/es6.yaml:
- tests/stress/proxy-construct.js: Added.
(assert):
(throw.new.Error.let.target):
(throw.new.Error):
(assert.let.target):
(assert.let.handler.get construct):
(let.target):
(let.handler.construct):
(i.catch):
(assert.let.handler.construct):
(assert.let.construct):
(assert.else.assert.let.target):
(assert.else.assert.let.construct):
(assert.else.assert):
(new.proxy.let.target):
(new.proxy.let.construct):
(new.proxy):
- 2:47 PM Changeset in webkit [196867] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual Styles: Modifying background expands Font section
https://bugs.webkit.org/show_bug.cgi?id=154491
<rdar://problem/24755440>
Patch by Devin Rousso <Devin Rousso> on 2016-02-20
Reviewed by Timothy Hatcher.
When the user selects a new style, the Visual sidebar examines the property
editors in each subsection to see if any have a value and expands/collapses
the subsection accordingly. This issue was happening because that logic was
also being triggered when the user didn't select a new style, which is
controlled by DOMNodeStyles and the significantChange value in refresh().
- UserInterface/Base/Utilities.js:
(String.prototype.toCamelCase):
Added utility function to transform a string into a camel-cased version.
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
Dropped unused variable and added checks to make sure doubly-matching styles
don't count as a significant change and cause refreshes of the styles sidebar.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
If this function has an event, meaning it was triggered by a newly selected
selector in the selector section, loop through each subsection and perform
the logic described above, but instead only to open sections.
(WebInspector.VisualStyleDetailsPanel.prototype._generateSection.replaceDashWithCapital): Deleted.
(WebInspector.VisualStyleDetailsPanel.prototype._updateProperties):
Removed logic that was already being called by _sectionModified().
- 1:21 PM Changeset in webkit [196866] by
-
- 7 edits2 adds in trunk
Wheel event callback removing the window causes crash in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=150871
Reviewed by Brent Fulgham.
Source/WebCore:
Null check the FrameView before using it, since the iframe may have been removed
from its parent document inside the event handler.
The new test triggered a cross-load side-effect, where wheel event filtering wasn't
reset between page loads. Fix by calling clearLatchedState() in EventHandler::clear(),
which resets the filtering.
Test: fast/events/wheel-event-destroys-frame.html
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::clearLatchedState):
- page/Frame.cpp:
(WebCore::Frame::setView): If the view doesn't change (e.g. was and is null)
don't bother clearing the event handler; should avoid EventHandler::clearLatchedState()
from accessing a deleted MainFrame.
- page/WheelEventDeltaFilter.cpp:
(WebCore::WheelEventDeltaFilter::filteredDelta):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
LayoutTests:
- fast/events/wheel-event-destroys-frame-expected.txt: Added.
- fast/events/wheel-event-destroys-frame.html: Added.
- 11:51 AM Changeset in webkit [196865] by
-
- 2 edits in trunk/LayoutTests
Rebaseline inspector/model/remote-object.html for Mac after r196846
Unreviewed test gardening.
- platform/mac/inspector/model/remote-object-expected.txt:
- 10:29 AM Changeset in webkit [196864] by
-
- 7 edits in trunk/Source/WebCore
Resolve style iteratively
https://bugs.webkit.org/show_bug.cgi?id=154355
Reviewed by Andreas Kling.
Instead of a set of recursive functions use ComposedTreeIterator for traversing the DOM
tree in composed tree order.
This, along with maintaining explicit parent stack makes style resolve code more tractable
for future work.
It also makes the ComposedTreeIterator the definite authority for the shape of the composed tree
instead of duplicating it as a set of recursive style resolve functions. This eliminates
a significant source of bugs and confusion.
The render tree building code path remains recursive for now.
- css/StyleInvalidationAnalysis.cpp:
(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):
Invalidate the host element instead of the shadow root. This reduces need for special handling for shadow roots.
- dom/ComposedTreeIterator.cpp:
(WebCore::ComposedTreeIterator::initializeContextStack):
(WebCore::ComposedTreeIterator::dropAssertions):
Add support for dropping DOM mutation assertions.
(WebCore::ComposedTreeIterator::traverseShadowRoot):
- dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::context):
(WebCore::ComposedTreeIterator::current):
- dom/PseudoElement.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::TreeResolver::Scope::Scope):
(WebCore::Style::TreeResolver::Parent::Parent):
(WebCore::Style::TreeResolver::pushScope):
(WebCore::Style::resetStyleForNonRenderedDescendants):
(WebCore::Style::pseudoStyleCacheIsInvalid):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::resolveTextNode):
(WebCore::Style::TreeResolver::resolveBeforeOrAfterPseudoElement):
(WebCore::Style::TreeResolver::pushParent):
(WebCore::Style::TreeResolver::popParent):
(WebCore::Style::TreeResolver::popParentsToDepth):
Maintain explicit parent stack.
(WebCore::Style::TreeResolver::resolveComposedTree):
The main loop that iterates over the composed tree and computes style for dirty elements.
(WebCore::Style::TreeResolver::resolve):
(WebCore::Style::detachRenderTree):
(WebCore::Style::TreeResolver::resolveLocally): Deleted.
(WebCore::Style::TreeResolver::resolveChildAtShadowBoundary): Deleted.
(WebCore::Style::TreeResolver::resolveShadowTree): Deleted.
(WebCore::Style::TreeResolver::resolveChildren): Deleted.
(WebCore::Style::TreeResolver::resolveSlotAssignees): Deleted.
(WebCore::Style::TreeResolver::resolveRecursively): Deleted.
Recursive functions go away.
- style/StyleTreeResolver.h:
(WebCore::Style::TreeResolver::scope):
(WebCore::Style::TreeResolver::parent):
- 10:16 AM Changeset in webkit [196863] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Text Align segmented control blinks while editing other properties in Visual Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=154487
<rdar://problem/24754703>
Patch by Devin Rousso <Devin Rousso> on 2016-02-20
Reviewed by Timothy Hatcher.
The icon list property editor blinking issue was caused by the fact that
the selected value was toggled on/off each time the value was set on the
editor. In order to prevent this, the logic for the setter value() was
modified to just match a keyword icon to the given value and select it.
- UserInterface/Views/VisualStyleKeywordIconList.js:
(WebInspector.VisualStyleKeywordIconList.prototype.set value):
(WebInspector.VisualStyleKeywordIconList.prototype._handleKeywordChanged):
- 9:02 AM Changeset in webkit [196862] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r196780): Fake memory handler takes too long to run now.
Unreviewed bot fix.
Put the footprint comparison code behind a compile-time flag for now.
It's taking too long to run on bots, and memory is getting measured
before all the pressure relief code has a chance to run.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 8:42 AM Changeset in webkit [196861] by
-
- 3 edits in trunk/Source/WebCore
Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES
https://bugs.webkit.org/show_bug.cgi?id=154483
Patch by Olivier Blin <Olivier Blin> on 2016-02-20
Reviewed by Michael Catanzaro.
Put initializeShortDateFormat(), dateFormat(), m_shortDateFormat and
m_didCreateShortDateFormat under flag, since they are only used by
code under the ENABLE_DATE_AND_TIME_INPUT_TYPES flag.
This helps to build with a light ICU that does not provide UDate
features (with UCONFIG_NO_FORMATTING).
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::LocaleICU):
(WebCore::LocaleICU::~LocaleICU):
(WebCore::createFallbackMonthLabels): Deleted.
(WebCore::createFallbackAMPMLabels): Deleted.
- platform/text/LocaleICU.h:
- 8:31 AM Changeset in webkit [196860] by
-
- 2 edits in trunk/Source/WebCore
Remove declaration of unimplemented methods in LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=154482
Patch by Olivier Blin <Olivier Blin> on 2016-02-20
Reviewed by Michael Catanzaro.
detectSignAndGetDigitRange() and matchedDecimalSymbolIndex() are
implemented in PlatformLocale, not LocaleICU.
They were moved out from LocaleICU to NumberLocalizer in r124459
(2012), which has then been renamed as Localizer, then Locale, and
finally PlatformLocale.
- platform/text/LocaleICU.h:
- 8:30 AM Changeset in webkit [196859] by
-
- 4 edits in trunk
[cmake] Use ICU include dirs in WebKit2 and WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=154479
Patch by Olivier Blin <Olivier Blin> on 2016-02-20
Reviewed by Michael Catanzaro.
Source/WebKit2:
- CMakeLists.txt:
Tools:
- WebKitTestRunner/CMakeLists.txt:
- 3:01 AM Changeset in webkit [196858] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r196837.
https://bugs.webkit.org/show_bug.cgi?id=154495
It caused a lot of crashes in EFL and GTK bots (Requested by
KaL on #webkit).
Reverted changeset:
"Wheel event callback removing the window causes crash in
WebCore."
https://bugs.webkit.org/show_bug.cgi?id=150871
http://trac.webkit.org/changeset/196837
- 12:40 AM Changeset in webkit [196857] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Placeholder text in Visual Styles sidebar table row should be white
https://bugs.webkit.org/show_bug.cgi?id=154488
<rdar://problem/24754715>
Reviewed by Timothy Hatcher.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle):
Feb 19, 2016:
- 10:31 PM Changeset in webkit [196856] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed. Fix debug build error since r196847
Fix gcc build warning appeared as below
by removing BASSERT(refCount <= maxRefCount).
error: comparison is always true due to limited range of data type
[-Werror=type-limits]
- bmalloc/SmallLine.h:
(bmalloc::SmallLine::ref): Deleted.
- 9:51 PM Changeset in webkit [196855] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Inherited selector rows have text too low
https://bugs.webkit.org/show_bug.cgi?id=154489
<rdar://problem/24754774>
Reviewed by Timothy Hatcher.
- UserInterface/Views/VisualStyleSelectorSection.css:
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider):
- 8:41 PM Changeset in webkit [196854] by
-
- 5 edits in trunk/Source/WebCore
Land release assertions to help track down a possible HTMLCollection lifetime bug
https://bugs.webkit.org/show_bug.cgi?id=154490
Reviewed by Ryosuke Niwa.
Land release assertions to help track down a possible HTMLCollection
lifetime bug: <rdar://problem/24457478>.
- bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::getOwnPropertyNames):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
- html/HTMLCollection.h:
(WebCore::HTMLCollection::wasDeletionStarted):
- html/HTMLCollection.idl:
- 8:17 PM Changeset in webkit [196853] by
-
- 3 edits2 adds in trunk
Source/WebCore:
Bug 154366 - AX: AXObjectCache::visiblePositionForTextMarkerData() doesn't account for equivalent visibly equivalent positions
https://bugs.webkit.org/show_bug.cgi?id=154366
Patch by Doug Russell <d_russell@apple.com> on 2016-02-19
Reviewed by Chris Fleizach.
Test: accessibility/mac/text-marker-line-boundary.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
LayoutTests:
Bug 154366: AX: AXObjectCache::visiblePositionForTextMarkerData() doesn't account for visibly equivalent positions
https://bugs.webkit.org/show_bug.cgi?id=154366
Patch by Doug Russell <d_russell@apple.com> on 2016-02-19
Reviewed by Chris Fleizach.
- accessibility/mac/text-marker-line-boundary-expected.txt: Added.
- accessibility/mac/text-marker-line-boundary.html: Added.
- 7:24 PM Changeset in webkit [196852] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Color picker in Visual Styles sidebar should not default to zero alpha
https://bugs.webkit.org/show_bug.cgi?id=154474
<rdar://problem/24750217>
Patch by Devin Rousso <Devin Rousso> on 2016-02-19
Reviewed by Timothy Hatcher.
- UserInterface/Views/InlineSwatch.js:
(WebInspector.InlineSwatch.prototype._fallbackValue):
Changed the fallback value for color from transparent to white so that
the color picker starts out with an alpha value of 1.
(WebInspector.InlineSwatch.prototype._handleContextMenuEvent):
Prevents context menu events from having an effect if there is no value
for them to modify.
- 6:47 PM Changeset in webkit [196851] by
-
- 3 edits in trunk/Source/WebCore
Use more concrete types for parsing positions
https://bugs.webkit.org/show_bug.cgi?id=154481
Reviewed by Dean Jackson.
Use CSSPrimitiveValues for position-parsing functions where possible, to avoid
the need to downcast<> the values returned by the parsing functions.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parsePositionX):
(WebCore::CSSParser::parsePositionY):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parse2ValuesFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseTransformOrigin):
(WebCore::CSSParser::parsePerspectiveOrigin):
- css/CSSParser.h:
- 5:58 PM Changeset in webkit [196850] by
-
- 10 edits in trunk
[INTL] Implement Number Format Functions
https://bugs.webkit.org/show_bug.cgi?id=147605
Reviewed by Darin Adler.
Source/JavaScriptCore:
This patch implements Intl.NumberFormat.prototype.format() according
to the ECMAScript 2015 Internationalization API spec (ECMA-402 2nd edition.)
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::UNumberFormatDeleter::operator()):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::createNumberFormat):
(JSC::IntlNumberFormat::formatNumber):
(JSC::IntlNumberFormatFuncFormatNumber): Deleted.
- runtime/IntlNumberFormat.h:
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatFuncFormatNumber):
LayoutTests:
- js/intl-numberformat-expected.txt:
- js/intl-numberformat.html:
- js/number-toLocaleString-expected.txt:
- js/script-tests/intl-numberformat.js:
- js/script-tests/number-toLocaleString.js:
- 5:51 PM Changeset in webkit [196849] by
-
- 5 edits3 adds in trunk
JSObject::getPropertySlot - index-as-propertyname, override on prototype, & shadow
https://bugs.webkit.org/show_bug.cgi?id=154416
Reviewed by Geoff Garen.
Source/JavaScriptCore:
Here's the bug. Suppose you call JSObject::getOwnProperty and -
- PropertyName contains an index,
- An object on the prototype chain overrides getOwnPropertySlot, and has that index property,
- The base of the access (or another object on the prototype chain) shadows that property.
JSObject::getPropertySlot is written assuming the common case is that propertyName is not an
index, and as such walks up the prototype chain looking for non-index properties before it
tries calling parseIndex.
At the point we reach an object on the prototype chain overriding getOwnPropertySlot (which
would potentially return the property) we may have already skipped over non-overriding
objects that contain the property in index storage.
- runtime/JSObject.h:
(JSC::JSObject::getOwnNonIndexPropertySlot):
- renamed from inlineGetOwnPropertySlot to better describe behaviour; added ASSERT guarding that this method never returns index properties - if it ever does, this is unsafe for getPropertySlot.
(JSC::JSObject::getOwnPropertySlot):
- inlineGetOwnPropertySlot -> getOwnNonIndexPropertySlot.
(JSC::JSObject::getPropertySlot):
- In case of object overriding getOwnPropertySlot check if propertyName is an index.
(JSC::JSObject::getNonIndexPropertySlot):
- called by getPropertySlot if we encounter an object that overrides getOwnPropertySlot, in order to avoid repeated calls to parseIndex.
(JSC::JSObject::inlineGetOwnPropertySlot): Deleted.
- this was renamed to getOwnNonIndexPropertySlot.
(JSC::JSObject::fastGetOwnPropertySlot): Deleted.
- this was folded back in to getPropertySlot.
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::isReadableStreamDisturbed):
- fastGetOwnPropertySlot -> getOwnPropertySlot (internal method removed; test shouldn't really have been using this anyway)
LayoutTests:
- js/index-property-shadows-overriden-get-own-property-slot-expected.txt: Added.
- js/index-property-shadows-overriden-get-own-property-slot.html: Added.
- js/script-tests/index-property-shadows-overriden-get-own-property-slot.js: Added.
(test):
- added test case.
- 5:37 PM Changeset in webkit [196848] by
-
- 8 edits in trunk/Source/WebKit2
WebAutomationSession should tell its delegate when its remote end disconnects
https://bugs.webkit.org/show_bug.cgi?id=154426
<rdar://problem/24732382>
Reviewed by Timothy Hatcher.
The client might want to free up resources or close spawned windows
if the remote end has disconnected from the automation session.
- UIProcess/API/APIAutomationSessionClient.h:
(API::AutomationSessionClient::didDisconnectFromRemote): Added.
(API::AutomationSessionClient::didRequestNewWindow):
Remove WebProcessPool* argument as it is never used.
- UIProcess/API/Cocoa/_WKAutomationSession.h:
- UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession isPaired]):
Expose whether the session is paired with a remote end.
- UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h: Add method.
- UIProcess/Cocoa/AutomationSessionClient.h: Add method.
Remove WebProcessPool* argument as it is never used.
- UIProcess/Cocoa/AutomationSessionClient.mm:
(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::AutomationSessionClient::didRequestNewWindow):
(WebKit::AutomationSessionClient::didDisconnectFromRemote):
Add necessary forwarding boilerplate.
- UIProcess/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::disconnect): Inform the client.
- 5:06 PM Changeset in webkit [196847] by
-
- 5 edits3 moves1 delete in trunk/Source/bmalloc
bmalloc: Chunk, Page, and Line don't need to be class templates
https://bugs.webkit.org/show_bug.cgi?id=154480
Reviewed by Gavin Barraclough.
We needed class templates to distinguish between small and medium,
but medium is gone now.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/Chunk.h: Removed.
- bmalloc/Heap.cpp:
(bmalloc::Heap::initializeLineMetadata):
(bmalloc::Heap::allocateSmallBumpRanges):
- bmalloc/Heap.h:
- bmalloc/Line.h: Removed.
- bmalloc/Page.h: Removed.
- bmalloc/Sizes.h:
- bmalloc/SmallChunk.h: Replaced with Source/bmalloc/bmalloc/Chunk.h.
(bmalloc::SmallChunk::begin):
(bmalloc::SmallChunk::end):
(bmalloc::SmallChunk::lines):
(bmalloc::SmallChunk::pages):
(bmalloc::SmallChunk::get):
(bmalloc::SmallLine::get):
(bmalloc::SmallLine::begin):
(bmalloc::SmallLine::end):
(bmalloc::SmallPage::get):
(bmalloc::SmallPage::begin):
(bmalloc::SmallPage::end):
(bmalloc::Chunk::begin): Deleted.
(bmalloc::Chunk::end): Deleted.
(bmalloc::Chunk::lines): Deleted.
(bmalloc::Chunk::pages): Deleted.
- bmalloc/SmallLine.h: Replaced with Source/bmalloc/bmalloc/Line.h.
(bmalloc::SmallLine::ref):
(bmalloc::SmallLine::deref):
(bmalloc::Line<Traits>::begin): Deleted.
(bmalloc::Line<Traits>::end): Deleted.
(bmalloc::Line<Traits>::ref): Deleted.
(bmalloc::Line<Traits>::deref): Deleted.
- bmalloc/SmallPage.h: Replaced with Source/bmalloc/bmalloc/Page.h.
(bmalloc::SmallPage::hasFreeLines):
(bmalloc::SmallPage::setHasFreeLines):
(bmalloc::SmallPage::ref):
(bmalloc::SmallPage::deref):
(bmalloc::Page::hasFreeLines): Deleted.
(bmalloc::Page::setHasFreeLines): Deleted.
(bmalloc::Page<Traits>::ref): Deleted.
(bmalloc::Page<Traits>::deref): Deleted.
- bmalloc/SmallTraits.h: Removed.
- 4:09 PM Changeset in webkit [196846] by
-
- 11 edits in trunk
HTMLFormElement.autocomplete should only return known values
https://bugs.webkit.org/show_bug.cgi?id=154247
<rdar://problem/24658195>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline a couple of W3C HTML tests now that more checks are passing.
- web-platform-tests/html/dom/reflection-forms-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
Source/WebCore:
Update HTMLFormElement.autocomplete to only return known values:
- https://html.spec.whatwg.org/multipage/forms.html#dom-form-autocomplete
- https://html.spec.whatwg.org/multipage/forms.html#attr-form-autocomplete
Also, update HTMLInputElement.autocomplete to fall back to using the form
owner's autocomplete attribute ("on" or "off") when it's autocomplete
attribute is omitted and the input element is wearing the "autofill
expectation mantle" (i.e. the input is not hidden). If there is no
form owner, the "on" value is used instead. This behavior is specified
in:
https://html.spec.whatwg.org/multipage/forms.html#autofilling-form-controls:-the-autocomplete-attribute:attr-fe-autocomplete-7
No new tests, already covered by existing tests.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::autocomplete):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::setAutocomplete):
(WebCore::HTMLFormElement::autocomplete):
- html/HTMLFormElement.h:
- html/HTMLFormElement.idl:
LayoutTests:
Update test to expect Form.autocomplete to return "on" by
default instead of the empty string.
- fast/forms/autocomplete-expected.txt:
- fast/forms/autocomplete.html:
- 4:03 PM Changeset in webkit [196845] by
-
- 19 edits4 deletes in trunk/Source/bmalloc
bmalloc: Remove the concept of medium objects
https://bugs.webkit.org/show_bug.cgi?id=154436
Reviewed by Sam Weinig.
There's no need to distinguish medium objects from small: Small object
metadata works naturally for both as long as we allow an object to
span more than two small lines. (We already allow an object to span
more than one small line.)
This change reduces memory use because it eliminates the 1kB line size,
so we don't have to hold down 1kB lines for individual 264+ byte objects.
1kB lines were always a bit of a compromise. The main point of bump
allocation is to take advantage of cache lines. Cache lines are usually
64 bytes, so line sizes above 256 bytes are a bit of a stretch.
This change speeds up small object benchmarks because it eliminates the
branch to detect medium objects in deallocation log processing.
This change reduces virtual memory use from worst cast 4X to worst case
2X because the medium chunk is gone. iOS cares about virtual memory use
and terminates apps above ~1GB, so this change gives us more breathing room.
This change slows down medium benchmarks a bit because we end up doing
more work to recycle fragmented medium objects. Overall, the tradeoff
seems justified, since we have a net speedup and a memory use savings.
- bmalloc.xcodeproj/project.pbxproj: Removed all the medium files. We
can simplify even further in a follow-up patch, removing the base class
templates for Chunk, Page, and Line as well.
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::Allocator):
(bmalloc::Allocator::allocate):
(bmalloc::Allocator::reallocate):
(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::refillAllocator):
(bmalloc::Allocator::allocateSlowCase): Medium is gone. Small max is the
new medium max.
- bmalloc/Allocator.h:
(bmalloc::Allocator::allocateFastCase): Ditto.
- bmalloc/BumpAllocator.h:
(bmalloc::BumpAllocator::validate):
(bmalloc::BumpAllocator::allocate): No more medium.
- bmalloc/Chunk.h: No more medium.
- bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::processObjectLog): No check for medium. This is
a speedup.
(bmalloc::Deallocator::deallocateSlowCase): No more medium.
- bmalloc/Deallocator.h:
(bmalloc::Deallocator::deallocateFastCase): Ditto.
- bmalloc/Heap.cpp:
(bmalloc::Heap::initializeLineMetadata): The algorithm here changed from
iterating each line to iterating each object. This helps us accomodate
objects that might span more than two lines -- i.e., all objects between
(512 bytes, 1024 bytes].
(bmalloc::Heap::scavenge):
(bmalloc::Heap::scavengeSmallPages):
(bmalloc::Heap::scavengeLargeObjects): Medium is gone.
(bmalloc::Heap::allocateSmallBumpRanges): Allow for lines that allocate
zero objects. This happens when an object spans more than two lines --
the middle lines allocate zero objects.
Also set the "has free lines" bit to false if we consume the last free
line. This needs to be a bit now because not all pages agree on their
maximum refcount anymore, so we need an explicit signal for the transition
from maximum to maximum - 1.
(bmalloc::Heap::allocateSmallPage): This code didn't change; I just removed
the medium code.
(bmalloc::Heap::deallocateSmallLine): Changed the algorithm to check
hasFreeLines. See allocateSmallBumpRanges.
(bmalloc::Heap::scavengeMediumPages): Deleted.
(bmalloc::Heap::allocateMediumBumpRanges): Deleted.
(bmalloc::Heap::allocateMediumPage): Deleted.
(bmalloc::Heap::deallocateMediumLine): Deleted.
- bmalloc/Heap.h:
(bmalloc::Heap::derefMediumLine): Deleted.
- bmalloc/LargeChunk.h:
(bmalloc::LargeChunk::get):
(bmalloc::LargeChunk::endTag):
- bmalloc/Line.h: No more medium.
- bmalloc/MediumChunk.h: Removed.
- bmalloc/MediumLine.h: Removed.
- bmalloc/MediumPage.h: Removed.
- bmalloc/MediumTraits.h: Removed.
- bmalloc/ObjectType.cpp:
(bmalloc::objectType):
- bmalloc/ObjectType.h:
(bmalloc::isSmall):
(bmalloc::isXLarge):
(bmalloc::isSmallOrMedium): Deleted.
(bmalloc::isMedium): Deleted. No more medium.
- bmalloc/Page.h:
(bmalloc::Page::sizeClass):
(bmalloc::Page::setSizeClass):
(bmalloc::Page::hasFreeLines):
(bmalloc::Page::setHasFreeLines): Add the free lines bit. You get better
codegen if you make it the low bit, since ref / deref can then add / sub
- So do that.
- bmalloc/Sizes.h:
(bmalloc::Sizes::sizeClass): Expand the small size class to include the
medium size class.
- bmalloc/SuperChunk.h:
(bmalloc::SuperChunk::SuperChunk):
(bmalloc::SuperChunk::smallChunk):
(bmalloc::SuperChunk::largeChunk):
(bmalloc::SuperChunk::mediumChunk): Deleted. No more medium.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow):
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateSmallPage): Set the has free lines bit before
returning a Page to the Heap since this is the correct default state
when we first allocate a page.
(bmalloc::VMHeap::allocateMediumPage): Deleted.
(bmalloc::VMHeap::deallocateMediumPage): Deleted.
- 4:01 PM Changeset in webkit [196844] by
-
- 2 edits in trunk/Tools
[GTK] Fixed link error when G_DEFINE_AUTOPTR_CLEANUP_FUNC is not defined.
https://bugs.webkit.org/show_bug.cgi?id=154467
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-19
Reviewed by Michael Catanzaro.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp:
(beforeAll):
(afterAll):
- 3:56 PM Changeset in webkit [196843] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS var() function should be syntax highlighted
https://bugs.webkit.org/show_bug.cgi?id=154406
<rdar://problem/24726136>
Reviewed by Timothy Hatcher.
- UserInterface/Models/CSSCompletions.js:
Added "var" to CodeMirror value keywords for syntax highlighting.
- UserInterface/Models/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
Added "var" to accepted keywords for auto-completion.
- 3:33 PM Changeset in webkit [196842] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Rebaseline js/dom/global-constructors-attributes expectation for Mavericks. rdar://problem/24748489
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
Account for HTMLPictureElement support.
- 3:28 PM Changeset in webkit [196841] by
-
- 3 edits in branches/safari-601-branch/LayoutTests
Skip inspector/css/modify-rule-selector.html. rdar://problem/24748351
This test relies on TestPage infrastructure which is not present on the branch.
Skip inspector/css/modify-rule-selector.html
- platform/mac-wk2/TestExpectations:
Remove expectation for inspector/css/modify-rule-selector.html
- 3:27 PM Changeset in webkit [196840] by
-
- 13 edits1 move in trunk/Source/bmalloc
bmalloc: Unify VMHeap and Heap LargeObjects free lists to reduce fragmentation
https://bugs.webkit.org/show_bug.cgi?id=154192
Reviewed by Geoffrey Garen.
Change the operation of Heap and VMHeap LargeObject free lists.
Renamed Owner to VMState to track the state of each LargeObject.
Physical - The pages have been allocated.
Virtual - The pages have not been allocated.
Mixed - The object contains a mixture of Physical and Virtual pages.
VMState uses one bit each for Physical and Virtual to simplify merging states
when merging two adjacent blocks. This change enforces the rule that objects in
the Heap free list must have have the Physical bit set in their VMState while objects
in the VMHeap free list must have the Physical bit clear. Thie means that the Heap
can have LargeObjects in Physical or Mixed VMState, but the VMHeap's free list can
only contain Virtual LargeObjects.
In both Heap::allocateLarge(), we now allocate physical pages if the LargeObject we
pull from the free list has any Virtual pages before we possilby split the
object. When we merge objects, the result might be made up of Mixed page allocations.
When allocating a Mixed LargeObject, we need to allocate memory for them as well.
The scavenger deallocates both Physical and Mixed LargeObjects, placing them back into
the VMHeap's free list.
When we allocate or deallocate Mixed LargeObjects, there are pages that within these
objects that will be redundantly modified. It would require additional metadata to
eliminate this redundancy.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/BoundaryTag.h:
(bmalloc::BoundaryTag::vmState): New helper.
(bmalloc::BoundaryTag::setVMState): New helper.
(bmalloc::BoundaryTag::owner): Deleted.
(bmalloc::BoundaryTag::setOwner): Deleted.
- bmalloc/Heap.h:
(bmalloc::Heap::splitAndAllocate): New helpers.
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::vmState): New helper.
(bmalloc::LargeObject::setVMState): New helper.
- bmalloc/Heap.cpp:
(bmalloc::Heap::splitAndAllocate): New helpers.
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::deallocatePhysicalPages): Refactored from VMHeap::deallocateLargeObjectMemory.
- bmalloc/FreeList.cpp:
(bmalloc::FreeList::takeGreedy):
(bmalloc::FreeList::take):
(bmalloc::FreeList::removeInvalidAndDuplicateEntries):
- bmalloc/FreeList.h:
(bmalloc::FreeList::FreeList):
(bmalloc::FreeList::push):
- bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
(bmalloc::Heap::scavengeLargeObjects):
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::isValidAndFree):
(bmalloc::LargeObject::validateSelf):
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::SegregatedFreeList): Changed to initialize our required Physical state.
- bmalloc/SegregatedFreeList.h:
(bmalloc::SegregatedFreeList::SegregatedFreeList):
(bmalloc::SegregatedFreeList::insert):
(bmalloc::SegregatedFreeList::takeGreedy):
(bmalloc::SegregatedFreeList::take):
Replaced Owner parameters and checks with VMState::HasPhysical.
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::prevCanMerge): Removed owner from tests.
(bmalloc::LargeObject::nextCanMerge): Removed owner from tests.
(bmalloc::LargeObject::merge): Removed owner from tests. Updated to merge VMStates andset the
VMState after the merge.
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::owner): Deleted.
(bmalloc::LargeObject::setOwner): Deleted.
- bmalloc/Owner.h: Removed.
- bmalloc/VMAllocate.h:
(bmalloc::vmAllocatePhysicalPagesSloppy): Changed to round begin down to eliminate the left to right
allocation constraint.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::grow): Large space managed like small or medium as a vector of LargeChunks.
(bmalloc::VMHeap::VMHeap): Changed to initialize our required Physical state.
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateLargeObject): These no longer allocate memory.
(bmalloc::VMHeap::deallocateLargeObject): Removed setOwner. Now we set the VMState after any merges.
- bmalloc/VMState.h: Copied from Source/bmalloc/bmalloc/Owner.h.
(bmalloc::VMState::VMState):
(bmalloc::VMState::hasPhysical):
(bmalloc::VMState::hasVirtual):
(bmalloc::VMState::merge):
(bmalloc::VMState::operator ==):
(bmalloc::VMState::operator unsigned):
New class with various helpers.
- 3:24 PM Changeset in webkit [196839] by
-
- 2 edits in trunk/Source/WebCore
Drop UnsafeVectorOverflow on ElementDescendantConstIterator::m_ancestorSiblingStack
https://bugs.webkit.org/show_bug.cgi?id=154477
Reviewed by Ryosuke Niwa.
Drop UnsafeVectorOverflow on ElementDescendantConstIterator::m_ancestorSiblingStack to
restore bounds checking.
Andreas already dropped in on ElementDescendantIterator::m_ancestorSiblingStack in
r178253 but did not update the "Const" counterpart.
- dom/ElementDescendantIterator.h:
- 3:03 PM Changeset in webkit [196838] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Remove extraneous '-' from parse-filter-image test expectation. rdar://problem/24743218
- 2:59 PM Changeset in webkit [196837] by
-
- 6 edits2 adds in trunk
Wheel event callback removing the window causes crash in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=150871
Reviewed by Brent Fulgham.
Source/WebCore:
Null check the FrameView before using it, since the iframe may have been removed
from its parent document inside the event handler.
The new test triggered a cross-load side-effect, where wheel event filtering wasn't
reset between page loads. Fix by calling clearLatchedState() in EventHandler::clear(),
which resets the filtering.
Test: fast/events/wheel-event-destroys-frame.html
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
- page/WheelEventDeltaFilter.cpp:
(WebCore::WheelEventDeltaFilter::filteredDelta):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
LayoutTests:
- fast/events/wheel-event-destroys-frame-expected.txt: Added.
- fast/events/wheel-event-destroys-frame.html: Added.
- 2:56 PM Changeset in webkit [196836] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
[ES6] Implement Proxy.Call
https://bugs.webkit.org/show_bug.cgi?id=154425
Reviewed by Mark Lam.
This patch is a straight forward implementation of
Proxy.Call with respect to section 9.5.12
of the ECMAScript spec.
https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-call-thisargument-argumentslist
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::finishCreation):
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::getOwnPropertySlotByIndex):
(JSC::performProxyCall):
(JSC::ProxyObject::getCallData):
(JSC::ProxyObject::visitChildren):
- runtime/ProxyObject.h:
(JSC::ProxyObject::create):
- tests/es6.yaml:
- tests/stress/proxy-call.js: Added.
(assert):
(throw.new.Error.let.target):
(throw.new.Error.let.handler.apply):
(throw.new.Error):
(assert.let.target):
(assert.let.handler.get apply):
(let.target):
(let.handler.apply):
(i.catch):
(assert.let.handler.apply):
- 2:28 PM Changeset in webkit [196835] by
-
- 2 edits in trunk/Source/WebCore
[Win] [SVG -> OTF Converter] All uses of a font except the first one are invisible
https://bugs.webkit.org/show_bug.cgi?id=154465
Reviewed by Alex Christensen.
We should re-use the existing converted data if it exists.
Covered by existing tests.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- 2:15 PM Changeset in webkit [196834] by
-
- 5 edits in trunk/Source/WebKit2
Enhance EditorState to include TypingAttributes, alignment, and color
https://bugs.webkit.org/show_bug.cgi?id=154424
Reviewed by Dean Jackson and Sam Weinig.
TypingAttributes is already available for iOS and GTK. This patch hooks
that up on Mac as well, and it moves the calculation of that to the shared
file since there is no reason for this to be written in an iOS-only way. This
patch also adds textColor and textAlignment to EditorState, and since those
are not technically platform-specific either, they are also calculated in the
shared editorState() function.
- Shared/EditorState.cpp:
(WebKit::EditorState::PostLayoutData::encode):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::platformEditorState):
- 1:49 PM Changeset in webkit [196833] by
-
- 7 edits2 adds in trunk
ComposedTreeIterator traverses normal children for elements with empty shadow root
https://bugs.webkit.org/show_bug.cgi?id=154464
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/shadow-dom/composed-tree-basic.html
- dom/ComposedTreeIterator.cpp:
(WebCore::ComposedTreeIterator::initializeContextStack):
(WebCore::ComposedTreeIterator::traverseShadowRoot):
If the shadow root is empty continue by skipping the real children.
(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::composedTreeAsText):
(WebCore::ComposedTreeIterator::pushContext): Deleted.
- dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::context):
(WebCore::ComposedTreeIterator::current):
(WebCore::ComposedTreeIterator::traverseNext):
(WebCore::composedTreeChildren):
- testing/Internals.cpp:
(WebCore::Internals::composedTreeAsText):
Testing support.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/shadow-dom/composed-tree-basic-expected.txt: Added.
- fast/shadow-dom/composed-tree-basic.html: Added.
- 1:12 PM Changeset in webkit [196832] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Analysis tasks page complains about missing repository but with a wrong name
https://bugs.webkit.org/show_bug.cgi?id=154468
Reviewed by Chris Dumez.
Fixed the bug by using the right variable in the template literal.
- public/v3/components/customizable-test-group-form.js:
(CustomizableTestGroupForm.prototype._computeRootSetMap): Use querySelector here since Chrome doesn't have
getElementsByClassName on ShadowRoot.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Use name which is the name of
repository here.
- 1:04 PM Changeset in webkit [196831] by
-
- 5 edits in trunk/Source/WebCore
Adopt CachedRawResourceClient::shouldCacheResponse() in MediaResourceLoader and WebCoreNSURLSession
https://bugs.webkit.org/show_bug.cgi?id=154466
Reviewed by Alex Christensen.
Adopt the new shouldCacheResponse() callback so that byte-range
requests generated by WebCoreNSURLSession are not cached.
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResource::shouldCacheResponse):
- loader/MediaResourceLoader.h:
- platform/graphics/PlatformMediaResourceLoader.h:
(WebCore::PlatformMediaResourceClient::shouldCacheResponse):
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession downloadTaskWithRequest:]):
(-[WebCoreNSURLSession streamTaskWithHostName:port:]):
(-[WebCoreNSURLSession streamTaskWithNetService:]):
(-[WebCoreNSURLSessionDataTask _timingData]):
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]):
- 1:02 PM Changeset in webkit [196830] by
-
- 4 edits in trunk/LayoutTests
Re-sync W3C web-platform-tests' html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=154463
Reviewed by Ryosuke Niwa.
Re-sync W3C web-platform-tests' html/dom/interfaces.html after:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- 12:14 PM Changeset in webkit [196829] by
-
- 5 edits in tags/Safari-602.1.19.1/Source
Versioning.
- 12:12 PM Changeset in webkit [196828] by
-
- 1 copy in tags/Safari-602.1.19.1
New tag.
- 11:46 AM Changeset in webkit [196827] by
-
- 5 edits in trunk/Source/WebCore
[Mac] CORS-compliant videos throw security errors when painting to Canvas
https://bugs.webkit.org/show_bug.cgi?id=154188
<rdar://problem/22959556>
Reviewed by Alex Christensen.
Pass the CORS access check results from WebCoreNSURLSession to it's client,
MediaPlayerPrivateAVFoundationObjC.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck): Ask the WebCoreNSURLSession.
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession task:didReceiveCORSAccessCheckResult:]): Conditionally set _corsResults.
(-[WebCoreNSURLSession didPassCORSAccessChecks]): Return _corsResults.
(WebCoreNSURLSessionDataTaskClient::accessControlCheckFailed): Call -resource:accessControlCheckFailedWithError:.
(WebCoreNSURLSessionDataTaskClient::loadFailed): Call -resource:loadFailedWithError:.
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Set _response within the delegate queue.
(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:]): Renamed from resourceFinished:
(-[WebCoreNSURLSessionDataTask resource:accessControlCheckFailedWithError:]): Ditto.
(-[WebCoreNSURLSessionDataTask resource:loadFailedWithError:]): Ditto.
(-[WebCoreNSURLSessionDataTask resourceFinished:]): Ditto.
- 11:12 AM Changeset in webkit [196826] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- loader/cocoa/SubresourceLoaderCocoa.mm:
(WebCore::SubresourceLoader::willCacheResponse):
- 11:06 AM Changeset in webkit [196825] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r196703. rdar://problem/24623986
- 10:58 AM Changeset in webkit [196824] by
-
- 8 edits in trunk
AX: Inconsistency between CharacterOffset and VisiblePostition
https://bugs.webkit.org/show_bug.cgi?id=154431
Reviewed by Chris Fleizach.
Source/WebCore:
VoiceOver is not getting the correct text marker from VisiblePostition when
navigating using arrow keys. We should make the CharacterOffset behavior consistent
with VisiblePosition so that the conversion between the two won't create different
text markers.
Changes are covered in the modified tests.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetForTextMarkerData):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::startOrEndCharacterOffsetForRange):
(WebCore::AXObjectCache::startOrEndTextMarkerDataForRange):
(WebCore::AXObjectCache::characterOffsetForNodeAndOffset):
(WebCore::AXObjectCache::textMarkerDataForNextCharacterOffset):
(WebCore::AXObjectCache::textMarkerDataForPreviousCharacterOffset):
(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
(WebCore::AXObjectCache::accessibilityObjectForTextMarkerData):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::previousCharacterOffset):
(WebCore::AXObjectCache::startCharacterOffsetOfWord):
(WebCore::AXObjectCache::endCharacterOffsetOfWord):
(WebCore::AXObjectCache::previousWordStartCharacterOffset):
(WebCore::AXObjectCache::previousParagraphStartCharacterOffset):
(WebCore::AXObjectCache::previousSentenceStartCharacterOffset):
- accessibility/AXObjectCache.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
LayoutTests:
- accessibility/mac/text-marker-word-nav-expected.txt:
- accessibility/mac/text-marker-word-nav.html:
- accessibility/text-marker/text-marker-previous-next.html:
- 10:06 AM Changeset in webkit [196823] by
-
- 2 edits in trunk/Source/WebKit2
Purge as much as we can from WKDeprecatedFunctions.cpp
https://bugs.webkit.org/show_bug.cgi?id=154459
Reviewed by Sam Weinig.
- Shared/API/c/WKDeprecatedFunctions.cpp:
(WKArrayIsMutable): Deleted.
(WKPageSetVisibilityState): Deleted.
(WKDictionaryIsMutable): Deleted.
(WKDictionaryAddItem): Deleted.
(WKDictionaryRemoveItem): Deleted.
(WKPreferencesSetRegionBasedColumnsEnabled): Deleted.
(WKPreferencesGetRegionBasedColumnsEnabled): Deleted.
(WKPreferencesSetMultithreadedWebGLEnabled): Deleted.
(WKPreferencesGetMultithreadedWebGLEnabled): Deleted.
(WKPreferencesSetScreenFontSubstitutionEnabled): Deleted.
(WKPreferencesGetScreenFontSubstitutionEnabled): Deleted.
(WKInspectorIsDebuggingJavaScript): Deleted.
(WKInspectorToggleJavaScriptDebugging): Deleted.
(WKInspectorIsProfilingJavaScript): Deleted.
(WKInspectorToggleJavaScriptProfiling): Deleted.
(WKContextGetProcessModel): Deleted.
(WKGraphicsContextGetCGContext): Deleted.
(WKContextGetProcessSuppressionEnabled): Deleted.
(WKContextSetProcessSuppressionEnabled): Deleted.
- 10:05 AM Changeset in webkit [196822] by
-
- 6 edits in trunk/Source/WebCore
Allow CachedRawResource clients to opt out of caching on a per-response basis
https://bugs.webkit.org/show_bug.cgi?id=154453
Reviewed by Brady Eidson.
For CF or NS networking clients, the system loader will ask whether the client (the
SubResourceLoader in this case) wants the response to be cached. This breaks for byte
range requests due to <rdar://problem/20001985>. Allow the SubresourceLoader to query
its clients, and return null, if they opt out.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::shouldCacheResponse):
- loader/cache/CachedRawResource.h:
- loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::shouldCacheResponse):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldCacheResponse):
- loader/cocoa/SubresourceLoaderCocoa.mm:
(WebCore::SubresourceLoader::willCacheResponse):
- 9:35 AM Changeset in webkit [196821] by
-
- 11 edits in trunk
Add "databaseProcessDidCrash" to the WKContextClient; Adopt it in WKTR.
https://bugs.webkit.org/show_bug.cgi?id=154428
Reviewed by Jer Noble.
Source/WebKit2:
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetDatabaseProcessIdentifier):
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::databaseProcessDidCrash):
- UIProcess/WebContextClient.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::databaseProcessCrashed):
(WebKit::WebProcessPool::databaseProcessIdentifier):
- UIProcess/WebProcessPool.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::generatePageConfiguration):
(WTR::TestController::databaseProcessName):
(WTR::TestController::databaseProcessDidCrash):
- WebKitTestRunner/TestController.h:
- 8:49 AM Changeset in webkit [196820] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196797
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 5:25 AM Changeset in webkit [196819] by
-
- 50 edits6 adds in trunk/LayoutTests
[CSS Grid Layout Refactoring some layout tests
https://bugs.webkit.org/show_bug.cgi?id=154291
Refactored several tests so they use the shared sizing keywords
instead of specific CSS rules.
Reviewed by Sergio Villar Senin.
- fast/css-grid-layout/calc-resolution-grid-item.html:
- fast/css-grid-layout/flex-and-intrinsic-sizes-expected.txt:
- fast/css-grid-layout/flex-and-intrinsic-sizes.html:
- fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:
- fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:
- fast/css-grid-layout/grid-align-justify-margin-border-padding.html:
- fast/css-grid-layout/grid-align-justify-overflow.html:
- fast/css-grid-layout/grid-align-justify-stretch.html:
- fast/css-grid-layout/grid-align.html:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/grid-container-margin-border-padding-scrollbar.html:
- fast/css-grid-layout/grid-content-alignment-and-self-alignment.html:
- fast/css-grid-layout/grid-content-alignment-overflow.html:
- fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html:
- fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html:
- fast/css-grid-layout/grid-content-alignment-with-span.html:
- fast/css-grid-layout/grid-element-change-columns-repaint.html:
- fast/css-grid-layout/grid-element-change-rows-repaint.html:
- fast/css-grid-layout/grid-element-repeat-get-set.html:
- fast/css-grid-layout/grid-gutters-and-alignment.html:
- fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html:
- fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl.html:
- fast/css-grid-layout/grid-item-auto-margins-alignment.html:
- fast/css-grid-layout/grid-item-auto-margins-and-stretch.html:
- fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html:
- fast/css-grid-layout/grid-item-change-column-repaint.html:
- fast/css-grid-layout/grid-item-order-paint-order.html:
- fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-expected.txt: Added.
- fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-lr-expected.txt: Added.
- fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-lr.html: Added.
- fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-rl-expected.txt: Added.
- fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-rl.html: Added.
- fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding.html: Added.
- fast/css-grid-layout/grid-item-z-index-stacking-context-expected.html:
- fast/css-grid-layout/grid-item-z-index-stacking-context.html:
- fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html:
- fast/css-grid-layout/grid-justify-content-distribution.html:
- fast/css-grid-layout/grid-justify-content-vertical-lr.html:
- fast/css-grid-layout/grid-justify-content-vertical-rl.html:
- fast/css-grid-layout/justify-self-cell.html:
- fast/css-grid-layout/min-width-height-auto-and-margins.html:
- fast/css-grid-layout/minmax-fixed-logical-height-only.html:
- fast/css-grid-layout/minmax-fixed-logical-width-only.html:
- fast/css-grid-layout/minmax-max-content-resolution-columns.html:
- fast/css-grid-layout/minmax-max-content-resolution-rows.html:
- fast/css-grid-layout/named-grid-line-get-set.html:
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
- fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html:
- fast/css-grid-layout/percent-of-indefinite-track-size.html:
- fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:
- fast/css-grid-layout/place-cell-by-index.html:
- fast/css-grid-layout/resources/grid-alignment.css:
(.alignSelfCenterSafe):
(.alignSelfCenterUnsafe):
(.alignSelfEndSafe):
(.alignSelfEndUnsafe):
(.alignItemsAuto):
(.alignItemsStretch):
(.alignItemsStart):
(.alignItemsEnd):
(.alignItemsCenterSafe):
(.alignItemsCenterUnsafe):
(.alignItemsEndSafe):
(.alignItemsEndUnsafe):
(.justifySelfAuto):
(.justifySelfStretch):
(.justifySelfStart):
(.justifySelfCenter):
(.justifySelfEnd):
(.justifySelfRight):
(.justifySelfLeft):
(.justifySelfFlexStart):
(.justifySelfFlexEnd):
(.justifySelfSelfStart):
(.justifySelfSelfEnd):
(.justifySelfCenterSafe):
(.justifySelfCenterUnsafe):
(.justifyItemsAuto):
(.justifyItemsStretch):
(.justifyItemsStart):
(.justifyItemsCenter):
(.justifyItemsEnd):
(.justifyItemsCenterSafe):
(.justifyItemsCenterUnsafe):
(.justifyItemsEndSafe):
(.justifyItemsEndUnsafe):
(.selfStretch):
(.contentStart):
(.contentCenter):
(.contentEnd):
(.contentCenterSafe):
(.contentCenterUnsafe):
(.contentEndSafe):
(.contentEndUnsafe):
(.contentSpaceBetween):
(.contentSpaceAround):
(.contentSpaceEvenly):
(.contentStretch):
- fast/css-grid-layout/resources/grid.css:
(.verticalRL):
(.verticalLR):
(.horizontalTB):
(.horizontalBT):
(.inline-grid): Deleted.
(.firstRowFirstColumn): Deleted.
(.directionRTL): Deleted.
- 5:13 AM Changeset in webkit [196818] by
-
- 1 copy in releases/WebKitGTK/webkit-2.11.90
WebKitGTK+ 2.11.90
- 5:11 AM Changeset in webkit [196817] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.90 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.11.90.
- 4:11 AM Changeset in webkit [196816] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/JavaScriptCore
Merge r196810 - Add isJSString(JSCell*) variant to avoid Cell->JSValue->Cell conversion
https://bugs.webkit.org/show_bug.cgi?id=154442
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-19
Reviewed by Saam Barati.
- runtime/JSString.h:
(JSC::isJSString):
- 3:56 AM Changeset in webkit [196815] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r196809 - [GStreamer] clean-up various leaks
https://bugs.webkit.org/show_bug.cgi?id=154285
Reviewed by Carlos Garcia Campos.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init): Take full ownership of the GstTask.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Null pointer support in ASSERTs.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements): Take full ownership of the GstElementFactory pointers.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Ditto.
- 3:55 AM Changeset in webkit [196814] by
-
- 5 edits2 moves in releases/WebKitGTK/webkit-2.12
Merge r196807 - Revert to dispatching the popstate event synchronously
https://bugs.webkit.org/show_bug.cgi?id=153297
rdar://problem/24092294
Reviewed by Brent Fulgham.
Source/WebCore:
r192369 made the popstate event dispatch asynchronously, which matches what the HTML5 spec says to do. However,
due to compatibility regressions we need to revert back to dispatching synchronously. This change reverts
r192369's changes to Document.cpp, but retains the new tests.
Firing popstate synchronously makes both fast/loader/remove-iframe-during-history-navigation-different.html and
fast/loader/remove-iframe-during-history-navigation-same.html crash, because their onpopstate handlers remove
frames from the document that will later be accessed by HistoryController::recursiveGoToItem().
To prevent the crashes, this change does two things:
- Keep a reference to the current frame inside FrameLoader::loadSameDocumentItem(), since calling loadInSameDocument() might otherwise delete it.
- Handle a null frame when iterating a HistoryItem's child frames in HistoryController::recursiveGoToItem(), since calling goToItem() on one frame might cause another frame to be deleted.
Covered by existing tests. fast/loader/stateobjects/popstate-is-asynchronous.html was renamed to
fast/loader/stateobjects/popstate-is-synchronous.html and modified to expect synchronous dispatch.
- dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadSameDocumentItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveGoToItem):
LayoutTests:
Renamed and modified this test to expect synchronous dispatch.
- fast/loader/stateobjects/popstate-is-synchronous-expected.txt: Renamed from LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt.
- fast/loader/stateobjects/popstate-is-synchronous.html: Renamed from LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous.html.
- 3:48 AM Changeset in webkit [196813] by
-
- 3 edits in trunk/Source/WebCore
Blocked plug-in placeholder is sometimes not shown.
https://bugs.webkit.org/show_bug.cgi?id=154434
<rdar://problem/22584973>
Reviewed by Brent Fulgham.
m_isUnavailablePluginIndicatorHidden was set to false incorrectly as initial value.
It prevented RenderEmbeddedObject from issuing repaint when the plugin indicator
was set to visible (m_isUnavailablePluginIndicatorHidden <- false) the first time.
(The reason why the indicator showed up most of the time was because some renderer
triggered repaint on the view.)
Unable to test.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsHidden):
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): Deleted.
(WebCore::RenderEmbeddedObject::setUnavailablePluginIndicatorIsPressed): Deleted.
- rendering/RenderEmbeddedObject.h:
(WebCore::RenderEmbeddedObject::showsUnavailablePluginIndicator):
- 3:30 AM Changeset in webkit [196812] by
-
- 3 edits3 deletes in trunk/Source/JavaScriptCore
Remove more LLVM related dead code after r196729
https://bugs.webkit.org/show_bug.cgi?id=154387
Reviewed by Filip Pizlo.
- Configurations/CompileRuntimeToLLVMIR.xcconfig: Removed.
- Configurations/LLVMForJSC.xcconfig: Removed.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.props: Removed.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj: Removed.
- JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj.filters: Removed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- disassembler/X86Disassembler.cpp:
- 2:49 AM Changeset in webkit [196811] by
-
- 3 edits in trunk/Source/WebCore
Fix pessimizing-move warnings
https://bugs.webkit.org/show_bug.cgi?id=154395
Reviewed by Michael Catanzaro.
- platform/graphics/efl/CairoUtilitiesEfl.cpp:
(WebCore::evasObjectFromCairoImageSurface):
- platform/graphics/surfaces/GLTransportSurface.cpp:
(WebCore::GLTransportSurface::createTransportSurface):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
- 2:39 AM Changeset in webkit [196810] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add isJSString(JSCell*) variant to avoid Cell->JSValue->Cell conversion
https://bugs.webkit.org/show_bug.cgi?id=154442
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-19
Reviewed by Saam Barati.
- runtime/JSString.h:
(JSC::isJSString):
- 2:30 AM Changeset in webkit [196809] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] clean-up various leaks
https://bugs.webkit.org/show_bug.cgi?id=154285
Reviewed by Carlos Garcia Campos.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init): Take full ownership of the GstTask.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Null pointer support in ASSERTs.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements): Take full ownership of the GstElementFactory pointers.
(WebCore::MediaPlayerPrivateGStreamer::isAvailable): Ditto.
- 2:17 AM Changeset in webkit [196808] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unused SymbolTable::createNameScopeTable
https://bugs.webkit.org/show_bug.cgi?id=154443
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-19
Reviewed by Saam Barati.
- runtime/SymbolTable.h:
- 1:29 AM Changeset in webkit [196807] by
-
- 5 edits2 moves in trunk
Revert to dispatching the popstate event synchronously
https://bugs.webkit.org/show_bug.cgi?id=153297
rdar://problem/24092294
Reviewed by Brent Fulgham.
Source/WebCore:
r192369 made the popstate event dispatch asynchronously, which matches what the HTML5 spec says to do. However,
due to compatibility regressions we need to revert back to dispatching synchronously. This change reverts
r192369's changes to Document.cpp, but retains the new tests.
Firing popstate synchronously makes both fast/loader/remove-iframe-during-history-navigation-different.html and
fast/loader/remove-iframe-during-history-navigation-same.html crash, because their onpopstate handlers remove
frames from the document that will later be accessed by HistoryController::recursiveGoToItem().
To prevent the crashes, this change does two things:
- Keep a reference to the current frame inside FrameLoader::loadSameDocumentItem(), since calling loadInSameDocument() might otherwise delete it.
- Handle a null frame when iterating a HistoryItem's child frames in HistoryController::recursiveGoToItem(), since calling goToItem() on one frame might cause another frame to be deleted.
Covered by existing tests. fast/loader/stateobjects/popstate-is-asynchronous.html was renamed to
fast/loader/stateobjects/popstate-is-synchronous.html and modified to expect synchronous dispatch.
- dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadSameDocumentItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::recursiveGoToItem):
LayoutTests:
Renamed and modified this test to expect synchronous dispatch.
- fast/loader/stateobjects/popstate-is-synchronous-expected.txt: Renamed from LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt.
- fast/loader/stateobjects/popstate-is-synchronous.html: Renamed from LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous.html.
- 1:00 AM WebKitGTK/2.12.x created by
- 12:56 AM Changeset in webkit [196806] by
-
- 1 copy in releases/WebKitGTK/webkit-2.12
Branch WebKitGTK+ for 2.12
- 12:47 AM Changeset in webkit [196805] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r196769.
- html/HTMLTextAreaElement.idl:
- 12:09 AM Changeset in webkit [196804] by
-
- 6 edits3 deletes in trunk
[GStreamer] Bump internal jhbuild versions to 1.6.3
https://bugs.webkit.org/show_bug.cgi?id=149594
Reviewed by Michael Catanzaro.
.:
- Source/cmake/FindGStreamer.cmake: Check gst-gl version for the latest stable release of GStreamer.
Tools:
- gtk/jhbuild.modules: Bump to GStreamer 1.6.3.
- gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
- gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
- gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
LayoutTests:
- platform/gtk/TestExpectations: Skipping new failing tests for now.
Feb 18, 2016:
- 11:27 PM Changeset in webkit [196803] by
-
- 7 edits in trunk/Source
[GTK] Limit the number of tiles according to the visible area
https://bugs.webkit.org/show_bug.cgi?id=126122
Reviewed by Carlos Garcia Campos.
Source/WebCore:
TextureMapperTiledBackingStore creates tiles for whole layer bounds, which
means it creates the huge amount of textures if there is an excessively big
layer. Not only it wastes the memory and the CPU time, it even can crash GPU
drivers.
This patch modifies TextureMapperTiledBackingStore to take into account the
visible area with a coverage multiplier when creating tiles.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
Set a flag to recalculate the visible area of the layer when there are
geometric changes.
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::markVisibleRectAsDirty):
(WebCore::GraphicsLayerTextureMapper::selfOrAncestorHasActiveTransformAnimation):
(WebCore::GraphicsLayerTextureMapper::computeTransformedVisibleRect):
Compute the inverse transform matrix to map a global visible are to
the local visible area.
(WebCore::clampToContentsRectIfRectIsInfinite):
(WebCore::GraphicsLayerTextureMapper::transformedVisibleRect):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
In HiDPI, the directly composited image is uploaded to the unscaled
texture to reduce memory usages. So we should apply device scale
factor to render it correctly.
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
Create tiles which covered by visible rect with a coverage multiplier.
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize): Because we creates
nonCompositingLayer with a size of current view, we should not apply
the currently visible rect when creating / deleting tiles.
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges): Passes the current
visible rect to the GraphicsLayers.
- 11:22 PM Changeset in webkit [196802] by
-
- 7 edits1 add in trunk
Extend HashCountedSet with a method to efficiently set the count of an entry
https://bugs.webkit.org/show_bug.cgi?id=154352
Reviewed by Geoffrey Garen.
Source/WebCore:
Tested by new TestWebKitAPI tests.
- loader/ResourceLoadStatistics.cpp:
(WebCore::decodeHashCountedSet): Update to use new HashCountedSet::add method.
Source/WTF:
Tested by new TestWebKitAPI tests.
Update the HashCountedSet class with a new 'add' method to support efficient initialization of
the count of a given key. Also provide move and pointer template specializations to expand the
types of data that can be used as 'keys' in the HashCountedSet to match the underlying HashMap
implementation.
- wtf/HashCountedSet.h:
(WTF::Traits>::add): Added new overload supporting a supplied count.
Tools:
- TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
- TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
- 11:14 PM WebKitGTK/GRefPtrAndFloatingRefs created by
- 10:56 PM Changeset in webkit [196801] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r196790.
https://bugs.webkit.org/show_bug.cgi?id=154439
made fast/events/wheelevent-basic-actual.txt fail in WK2
(Requested by alexchristensen on #webkit).
Reverted changeset:
"Wheel event callback removing the window causes crash in
WebCore."
https://bugs.webkit.org/show_bug.cgi?id=150871
http://trac.webkit.org/changeset/196790
- 10:53 PM Changeset in webkit [196800] by
-
- 7 edits1 delete in trunk
Unreviewed, rolling out r196791.
https://bugs.webkit.org/show_bug.cgi?id=154438
broke windows build (Requested by alexchristensen on #webkit).
Reverted changeset:
"Extend HashCountedSet with a method to efficiently set the
count of an entry"
https://bugs.webkit.org/show_bug.cgi?id=154352
http://trac.webkit.org/changeset/196791
- 10:42 PM Changeset in webkit [196799] by
-
- 8 edits in trunk/Source/JavaScriptCore
[JSC] Improve the instruction selection of Select
https://bugs.webkit.org/show_bug.cgi?id=154432
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-18
Reviewed by Filip Pizlo.
Plenty of code but this patch is pretty dumb:
-On ARM64: use the 3 operand form of CSEL instead of forcing a source
to be alised to the destination. This gives more freedom to the register
allocator and it is one less Move to process per Select.
-On x86, introduce a fake 3 operands form and use aggressive aliasing
to try to alias both sources to the destination.
If aliasing succeed on the "elseCase", the condition of the Select
is reverted in the MacroAssembler.
If no aliasing is possible and we end up with 3 registers, the missing
move instruction is generated by the MacroAssembler.
The missing move is generated after testing the values because the destination
can use the same register as one of the test operand.
Experimental testing seems to indicate there is no macro-fusion on CMOV,
there is no measurable cost to having the move there.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::isInvertible):
(JSC::MacroAssembler::invert):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::moveConditionallyDouble):
(JSC::MacroAssemblerARM64::moveConditionallyFloat):
(JSC::MacroAssemblerARM64::moveConditionallyAfterFloatingPointCompare):
(JSC::MacroAssemblerARM64::moveConditionally32):
(JSC::MacroAssemblerARM64::moveConditionally64):
(JSC::MacroAssemblerARM64::moveConditionallyTest32):
(JSC::MacroAssemblerARM64::moveConditionallyTest64):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::moveConditionallyDouble):
(JSC::MacroAssemblerX86Common::moveConditionallyFloat):
(JSC::MacroAssemblerX86Common::moveConditionally32):
(JSC::MacroAssemblerX86Common::moveConditionallyTest32):
(JSC::MacroAssemblerX86Common::invert):
(JSC::MacroAssemblerX86Common::isInvertible):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::moveConditionally64):
(JSC::MacroAssemblerX86_64::moveConditionallyTest64):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createSelect):
(JSC::B3::Air::LowerToAir::lower):
- b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::shouldTryAliasingDef):
- b3/air/AirOpcode.opcodes:
- 9:26 PM Changeset in webkit [196798] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Sidebar focus jumps when trying to edit a color
https://bugs.webkit.org/show_bug.cgi?id=154404
<rdar://problem/24725744>
Patch by Devin Rousso <Devin Rousso> on 2016-02-18
Reviewed by Timothy Hatcher.
Clicking an inline swatch in the CSS Rules sidebar causes any focused
editor, if any, to become blurred and therefore fire its handler function.
This causes an issue because when a CodeMirror instance in the styles
sidebar becomes blurred, it is possible for the entire Rules sidebar to
refresh and recreate all of the sections (r187714), meaning that it will
reselect whatever editor was previously selected before the refresh,
causing the swatch popup to be blurred and therefore dismiss.
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorBlurActiveEditor):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createInlineSwatches.createSwatch):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._inlineSwatchBeforeClicked):
Add listener for new event and call to delegate function for handling it.
- UserInterface/Views/InlineSwatch.js:
(WebInspector.InlineSwatch.prototype._swatchElementClicked):
Now fires an event before the clicked logic happens, but still after the
click event is fired on the element.
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionBlurActiveEditor):
Clears the previously focused editor so when a reset happens no editor
is refocused.
- 9:17 PM Changeset in webkit [196797] by
-
- 15 edits in trunk
window.history / window.navigator should not be replaceable
https://bugs.webkit.org/show_bug.cgi?id=154412
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
window.history / window.navigator should not be replaceable as per
the latest HTML specification:
https://html.spec.whatwg.org/multipage/browsers.html#the-window-object
Firefox and Chrome already match the specification. This patch aligns
our behavior.
No new tests, already covered by existing tests.
- page/DOMWindow.idl:
LayoutTests:
Update / rebaseline existing tests now that window.history and
window.navigator are no longer replaceable.
- fast/dom/Window/get-set-properties-expected.txt:
- fast/dom/Window/get-set-properties.html:
- fast/dom/Window/window-property-shadowing-expected.txt:
- fast/dom/Window/window-property-shadowing.html:
- http/tests/history/cross-origin-replace-history-object-child-expected.txt:
- http/tests/history/resources/cross-origin-replaces-history-object-child-iframe.html:
- js/dom/var-declarations-shadowing-expected.txt:
- js/dom/var-declarations-shadowing.html:
- js/getOwnPropertyDescriptor-window-attributes-expected.txt:
- js/getOwnPropertyDescriptor-window-attributes.html:
- 9:12 PM Changeset in webkit [196796] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake][GTK] Clean up llvm guard in PlatformGTK.cmake
https://bugs.webkit.org/show_bug.cgi?id=154430
Reviewed by Saam Barati.
llvm isn't used anymore.
- PlatformGTK.cmake: Remove USE_LLVM_DISASSEMBLER guard.
- 8:25 PM Changeset in webkit [196795] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Revert an unintended change made in the previous commit.
- init-database.sql:
- 8:18 PM Changeset in webkit [196794] by
-
- 8 edits in trunk/Websites/perf.webkit.org
Perf dashboard should let user cancel pending A/B testing and hide failed ones
https://bugs.webkit.org/show_bug.cgi?id=154433
Reviewed by Chris Dumez.
Added a button to hide a test group in the details view (the bottom table) in the analysis task page, and
"Show hidden tests" link to show the hidden test groups on demand. When a test group is hidden, all pending
requests in the group will also be canceled since a common scenario of using this feature is that the user
had triggered an useless A/B testing; e.g. all builds will fail, wrong, etc... We can revisit and add the
capability to just cancel the pending requests and leaving the group visible later if necessary.
Run
ALTER TYPE build_request_status_type ADD VALUE 'canceled';to add the new type.
- init-database.sql: Added testgroup_hidden column to analysis_test_groups table and added 'canceled'
as a value to build_request_status_type table.
- public/api/test-groups.php:
(format_test_group): Added 'hidden' field in the JSON result.
- public/privileged-api/update-test-group.php:
(main): Added the support for updating testgroup_hidden column. When this column is set to true, also
cancel all pending build requests (by setting its request_status to 'canceled' which will be ignore by
the syncing script).
- public/v3/components/test-group-results-table.js:
(TestGroupResultsTable.prototype.setTestGroup): Reset _renderedTestGroup here so that the next call to
render() will update the table; e.g. when build requests' status change from 'Pending' to 'Canceled'.
- public/v3/models/build-request.js:
(BuildRequest.prototype.hasCompleted): A build request is considered complete/finished if it's canceled.
(BuildRequest.prototype.hasPending): Added.
(BuildRequest.prototype.statusLabel): Handle 'canceled' status.
- public/v3/models/test-group.js:
(TestGroup):
(TestGroup.prototype.updateSingleton): Added to update 'hidden' field.
(TestGroup.prototype.isHidden): Added.
(TestGroup.prototype.hasPending): Added.
(TestGroup.prototype.hasPending): Added.
(TestGroup.prototype.updateHiddenFlag): Added. Uses the privileged API to update testgroup_hidden column.
The JSON API also updates the status of the 'pending' build requests in the group to 'canceled'.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage): Added _showHiddenTestGroups and _filteredTestGroups as instance variables.
(AnalysisTaskPage.prototype._didFetchTestGroups):
(AnalysisTaskPage.prototype._showAllTestGroups): Added.
(AnalysisTaskPage.prototype._didUpdateTestGroupHiddenState): Extracted from _didFetchTestGroups.
(AnalysisTaskPage.prototype._renderTestGroupList): Use the filtered list of test groups to show the list
of test groups. When all test groups are shown, we would first show the hidden ones after the regular ones.
(AnalysisTaskPage.prototype._createTestGroupListItem): Extracted from _renderTestGroupList.
(AnalysisTaskPage.prototype._renderTestGroupDetails): Update the text inside the button to hide the test
group. Also show a warning text that the pending requests will be canceled if there are any.
(AnalysisTaskPage.prototype._hideCurrentTestGroup): Added.
(AnalysisTaskPage.cssTemplate): Updated the style.
- 6:45 PM Changeset in webkit [196793] by
-
- 10 edits1 copy in trunk
HTMLTableHeaderCellElement.scope should only return known values
https://bugs.webkit.org/show_bug.cgi?id=154423
<rdar://problem/24731018>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
Source/WebCore:
HTMLTableHeaderCellElement.scope should only return known values as per:
Known values are document here:
No new tests, already covered by existing test.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTableHeaderCellElement.cpp: Copied from Source/WebCore/html/HTMLTableHeaderCellElement.h.
(WebCore::HTMLTableHeaderCellElement::scope):
(WebCore::HTMLTableHeaderCellElement::setScope):
- html/HTMLTableHeaderCellElement.h:
- html/HTMLTableHeaderCellElement.idl:
- 6:44 PM Changeset in webkit [196792] by
-
- 4 edits in trunk/Websites/perf.webkit.org
The rows in the analysis results table should be expandable
https://bugs.webkit.org/show_bug.cgi?id=154427
Reviewed by Chris Dumez.
Added "(Expand)" link between rows that have hidden points. Upon click it inserts the hidden rows.
We insert around five rows at a time when there are hundreds of hidden points but we also avoid leaving
behind expandable rows of less than two rows.
Also fixed a bug in CustomizableTestGroupForm that getElementsById would throw in the shipping Safari
because getElementsById doesn't exist on Element.prototype by using class name instead.
- public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer):
(AnalysisResultsViewer.prototype.setCurrentTestGroup): Removed superfluous call to render().
(AnalysisResultsViewer.prototype.setPoints): Always show the start and the end points.
(AnalysisResultsViewer.prototype.buildRowGroups):
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Add an instance of ExpandableRow which
shows a "(Expand)" link to show hidden rows here.
(AnalysisResultsViewer.prototype._expandBetween): Added. Expands rows between two points.
(AnalysisResultsViewer.cssTemplate): Added rules for "(Expand)" links.
(AnalysisResultsViewer.ExpandableRow): Added.
(AnalysisResultsViewer.ExpandableRow.prototype.resultContent): Added. Overrides what's in the results column.
(AnalysisResultsViewer.ExpandableRow.prototype.heading): Added. Generates "(Expand)" link.
- public/v3/components/customizable-test-group-form.js:
(CustomizableTestGroupForm.prototype._computeRootSetMap): Use getElementsByClassName instead of
getElementById.
(CustomizableTestGroupForm.prototype._classForLabelAndRepository): Renamed from _idForLabelAndRepository.
(CustomizableTestGroupForm._constructRevisionRadioButtons): Set class name instead of id.
- public/v3/components/results-table.js:
(ResultsTable.prototype.render): Don't generate radio buttons to select a row when root set is missing;
e.g. for rows that show "(Expand)" links.
- 5:14 PM Changeset in webkit [196791] by
-
- 7 edits1 add in trunk
Extend HashCountedSet with a method to efficiently set the count of an entry
https://bugs.webkit.org/show_bug.cgi?id=154352
Reviewed by Geoffrey Garen.
Source/WebCore:
Tested by new TestWebKitAPI tests.
- loader/ResourceLoadStatistics.cpp:
(WebCore::decodeHashCountedSet): Update to use new HashCountedSet::add method.
Source/WTF:
Tested by new TestWebKitAPI tests.
Update the HashCountedSet class with a new 'add' method to support efficient initialization of
the count of a given key. Also provide move and pointer template specializations to expand the
types of data that can be used as 'keys' in the HashCountedSet to match the underlying HashMap
implementation.
- wtf/HashCountedSet.h:
(WTF::Traits>::add): Added new overload supporting a supplied count.
Tools:
- TestWebKitAPI/CMakeLists.txt: Add new HashCountedSet test files.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
- TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Added.
- 5:13 PM Changeset in webkit [196790] by
-
- 3 edits2 adds in trunk
Wheel event callback removing the window causes crash in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=150871
Reviewed by Brent Fulgham.
Source/WebCore:
Null check the FrameView before using it, since the iframe may have been removed
from its parent document inside the event handler.
Test: fast/events/wheel-event-destroys-frame.html
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformCompleteWheelEvent):
LayoutTests:
- fast/events/wheel-event-destroys-frame-expected.txt: Added.
- fast/events/wheel-event-destroys-frame.html: Added.
- 5:07 PM Changeset in webkit [196789] by
-
- 5 edits1 add in trunk/Source/JavaScriptCore
Implement Proxy.HasProperty
https://bugs.webkit.org/show_bug.cgi?id=154313
Reviewed by Filip Pizlo.
This patch is a straight forward implementation of
Proxy.HasProperty with respect to section 9.5.7
of the ECMAScript spec.
https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-hasproperty-p
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::getOwnPropertySlotCommon):
- runtime/ProxyObject.h:
- tests/es6.yaml:
- tests/stress/proxy-basic.js:
(assert):
(let.handler.has):
- tests/stress/proxy-has-property.js: Added.
(assert):
(throw.new.Error.let.handler.get has):
(throw.new.Error):
(assert.let.handler.has):
(let.handler.has):
(getOwnPropertyDescriptor):
(i.catch):
- 5:03 PM Changeset in webkit [196788] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add Native Parameter Lists to Console prototype functions
https://bugs.webkit.org/show_bug.cgi?id=154419
<rdar://problem/24730314>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-18
Reviewed by Timothy Hatcher.
- UserInterface/Models/NativeFunctionParameters.js:
- 4:51 PM Changeset in webkit [196787] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Statistically significant A/B testing results should be color coded in details view
https://bugs.webkit.org/show_bug.cgi?id=154414
Reviewed by Chris Dumez.
Color code the statistically significant comparisions in TestGroupResultsTable as done in the analysis
results viewer.
- public/v3/components/customizable-test-group-form.js:
(CustomizableTestGroupForm.cssTemplate): Build fix after r196768.
- public/v3/components/test-group-results-table.js:
(TestGroupResultsTable.prototype.buildRowGroups): Add the status as a class name.
(TestGroupResultsTable.cssTemplate): Added styles to color-code statistically significant results.
- 4:42 PM Changeset in webkit [196786] by
-
- 5 edits in trunk/Source
Modern IDB: Fix IDBGetResult encoder/decoder.
https://bugs.webkit.org/show_bug.cgi?id=154421
Reviewed by Alex Christensen.
No new tests, as Modern IDB is still disabled for WK2.
But if you manually enable it, "Basic IndexedDB Seems To Work"
Source/WebCore:
- Modules/indexeddb/IDBGetResult.h:
(WebCore::IDBGetResult::encode):
(WebCore::IDBGetResult::decode):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<IDBGetResult>::encode): Deleted.
(IPC::ArgumentCoder<IDBGetResult>::decode): Deleted.
- Shared/WebCoreArgumentCoders.h:
- 4:27 PM Changeset in webkit [196785] by
-
- 7 edits in trunk/Source/JavaScriptCore
Proxy's don't properly handle Symbols as PropertyKeys.
https://bugs.webkit.org/show_bug.cgi?id=154385
Reviewed by Mark Lam and Yusuke Suzuki.
We were converting all PropertyKeys to strings, even when
the PropertyName was a Symbol. In the spec, PropertyKeys are
either a Symbol or a String. We now respect that in Proxy.Get and
Proxy.GetOwnProperty.
- runtime/Completion.cpp:
(JSC::profiledEvaluate):
(JSC::createSymbolForEntryPointModule):
(JSC::identifierToJSValue): Deleted.
- runtime/Identifier.h:
(JSC::parseIndex):
- runtime/IdentifierInlines.h:
(JSC::Identifier::fromString):
(JSC::identifierToJSValue):
(JSC::identifierToSafePublicJSValue):
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
- tests/es6.yaml:
- tests/stress/proxy-basic.js:
(let.handler.getOwnPropertyDescriptor):
- 4:03 PM Changeset in webkit [196784] by
-
- 4 edits in trunk/Source/WebCore
Addressing post-review comments after r196747.
Unreviewed.
- css/CSSFontFaceSet.h:
- css/FontFaceSet.cpp:
(WebCore::FontFaceSet::size):
(WebCore::FontFaceSet::clear):
- css/FontFaceSet.h:
- 4:01 PM Changeset in webkit [196783] by
-
- 3 edits1 delete in trunk
.:
Get rid of the "All Source (target WebProcess)" scheme.
Rubber-stamped by Dan Bernstein.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Removed.
Tools:
Get rid of the --target-web-process and --use-web-process-xpc-service options.
Rubber-stamped by Dan Bernstein.
We now always use XPC, and --target-web-process is no longer supported.
- Scripts/webkitdirs.pm:
(execMacWebKitAppForDebugging):
(shouldTargetWebProcess): Deleted.
(determineShouldTargetWebProcess): Deleted.
(shouldUseXPCServiceForWebProcess): Deleted.
(determineShouldUseXPCServiceForWebProcess): Deleted.
(printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Deleted.
(argumentsForRunAndDebugMacWebKitApp): Deleted.
- 3:48 PM Changeset in webkit [196782] by
-
- 3 edits2 adds in trunk
Soft hyphen is not shown when it is placed at the end of an inline element
https://bugs.webkit.org/show_bug.cgi?id=153980
Reviewed by David Hyatt.
This patch handles the case when the character at the breaking position does not fit the
line and soft-hyphen, as the first breaking opportunity, is followed by this overflowing character.
(foo­bar where b overflows the line).
In such cases we don't yet have an item in the breaking history so we need to take a look at
the current context instead.
Source/WebCore:
Test: fast/text/soft-hyphen-as-first-breaking-opportunity.html
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::InlineIteratorHistory::nextBreakablePosition):
(WebCore::BreakingContext::handleText):
LayoutTests:
- fast/text/soft-hyphen-as-first-breaking-opportunity-expected.html: Added.
- fast/text/soft-hyphen-as-first-breaking-opportunity.html: Added.
- 3:43 PM Changeset in webkit [196781] by
-
- 2 edits in trunk/Tools
Skip API test WTF_ParkingLot.UnparkOneFiftyThenFiftyAll on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153997
Reviewed by Filip Pizlo.
- TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
- 3:35 PM Changeset in webkit [196780] by
-
- 4 edits in trunk/Source/WebCore
Fake memory pressure handler should log detailed memory breakdown.
<https://webkit.org/b/154415>
Reviewed by Antti Koivisto.
Piggyback on the RESOURCE_USAGE code to implement some detailed memory footprint diffing
and have the fake memory handler dump before/after/diff after it runs.
- page/ResourceUsageThread.h:
(WebCore::TagInfo::TagInfo):
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::logFootprintComparison):
(WebCore::displayNameForVMTag):
(WebCore::pagesPerVMTag):
(WebCore::TagInfo::TagInfo): Deleted.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- 2:42 PM Changeset in webkit [196779] by
-
- 9 edits in trunk/Source
Modern IDB: Implement server->client operations in WK2.
https://bugs.webkit.org/show_bug.cgi?id=154411
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::encode):
(WebCore::IDBTransactionInfo::decode):
Source/WebKit2:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::~WebIDBConnectionToClient):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::didDeleteDatabase):
(WebKit::WebIDBConnectionToServer::didOpenDatabase):
(WebKit::WebIDBConnectionToServer::didAbortTransaction):
(WebKit::WebIDBConnectionToServer::didCommitTransaction):
(WebKit::WebIDBConnectionToServer::didCreateObjectStore):
(WebKit::WebIDBConnectionToServer::didDeleteObjectStore):
(WebKit::WebIDBConnectionToServer::didClearObjectStore):
(WebKit::WebIDBConnectionToServer::didCreateIndex):
(WebKit::WebIDBConnectionToServer::didDeleteIndex):
(WebKit::WebIDBConnectionToServer::didPutOrAdd):
(WebKit::WebIDBConnectionToServer::didGetRecord):
(WebKit::WebIDBConnectionToServer::didGetCount):
(WebKit::WebIDBConnectionToServer::didDeleteRecord):
(WebKit::WebIDBConnectionToServer::didOpenCursor):
(WebKit::WebIDBConnectionToServer::didIterateCursor):
(WebKit::WebIDBConnectionToServer::fireVersionChangeEvent):
(WebKit::WebIDBConnectionToServer::didStartTransaction):
(WebKit::WebIDBConnectionToServer::notifyOpenDBRequestBlocked):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
- 2:31 PM Changeset in webkit [196778] by
-
- 5 edits in trunk/Tools
run-webkit-httpd should use webkitpy to run httpd.
https://bugs.webkit.org/show_bug.cgi?id=154271
Reviewed by Alexey Proskuryakov.
Update run-webkit-httpd to use webkitpy.port to launch httpd. Pass on http_port and http_all_interface
options to match the current run-webkit-httpd (optional) behavior.
- Scripts/run-webkit-httpd:
(parse_args):
(main):
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd.init):
- Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._prepare_config):
- Scripts/webkitpy/port/base.py:
(Port.to.start_http_server):
- 1:58 PM Changeset in webkit [196777] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196770
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 1:58 PM Changeset in webkit [196776] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/reflection-forms.html for ios-simulator after r196769
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
- 1:55 PM Changeset in webkit [196775] by
-
- 4 edits in trunk/Source/JavaScriptCore
Follow up fix to Implement Proxy.GetOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=154314
Reviewed by Filip Pizlo.
Part of the implementation was broken because
of how JSObject::getOwnPropertyDescriptor worked.
I've fixed JSObject::getOwnPropertyDescriptor to
be able to handle ProxyObject.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
- tests/stress/proxy-get-own-property.js:
(assert):
(assert.let.handler.get getOwnPropertyDescriptor):
- 1:30 PM Changeset in webkit [196774] by
-
- 2 edits in trunk/Source/WebKit2
RemoteInspector deadlocks if _WKAutomationDelegate creates/registers a target synchronously
https://bugs.webkit.org/show_bug.cgi?id=154359
<rdar://problem/24708897>
Reviewed by Joseph Pecoraro.
- UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::requestAutomationSession):
Make an NSString out of the String reference so it gets captured correctly.
- 12:59 PM Changeset in webkit [196773] by
-
- 2 edits in trunk/Source/WebCore
Fix unused-const-variable warning on non Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=154394
Reviewed by Michael Catanzaro.
- html/HTMLPlugInImageElement.cpp:
- 12:32 PM ASanWebKit edited by
- Updated for Mac OS X 10.11 El Capitan and later. (diff)
- 12:29 PM Changeset in webkit [196772] by
-
- 8 edits1 add in trunk/Source/JavaScriptCore
Implement Proxy.GetOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=154314
Reviewed by Filip Pizlo.
This patch implements Proxy.GetOwnProperty.
It's a straight forward implementation as described
in section 9.5.5 of the specification:
http://www.ecma-international.org/ecma-262/6.0/index.html#sec-proxy-object-internal-methods-and-internal-slots-getownproperty-p
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
- runtime/JSObject.cpp:
(JSC::validateAndApplyPropertyDescriptor):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::JSObject::defineOwnProperty):
(JSC::JSObject::getGenericPropertyNames):
(JSC::JSObject::getMethod):
- runtime/JSObject.h:
(JSC::JSObject::butterflyAddress):
(JSC::makeIdentifier):
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::getOwnPropertySlotCommon):
(JSC::ProxyObject::getOwnPropertySlot):
(JSC::ProxyObject::getOwnPropertySlotByIndex):
(JSC::ProxyObject::visitChildren):
- runtime/ProxyObject.h:
- tests/es6.yaml:
- tests/stress/proxy-basic.js:
(let.handler.get null):
- tests/stress/proxy-get-own-property.js: Added.
(assert):
(throw.new.Error.let.handler.getOwnPropertyDescriptor):
(throw.new.Error):
(let.handler.getOwnPropertyDescriptor):
(i.catch):
(assert.let.handler.getOwnPropertyDescriptor):
- 12:23 PM Changeset in webkit [196771] by
-
- 14 edits in trunk/Source
Modern IDB: Implement client->server operations in WK2.
https://bugs.webkit.org/show_bug.cgi?id=154400
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/shared/IDBIndexInfo.h:
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::idbServer):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::deleteDatabase):
(WebKit::WebIDBConnectionToClient::openDatabase):
(WebKit::WebIDBConnectionToClient::abortTransaction):
(WebKit::WebIDBConnectionToClient::commitTransaction):
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToClient::createObjectStore):
(WebKit::WebIDBConnectionToClient::deleteObjectStore):
(WebKit::WebIDBConnectionToClient::clearObjectStore):
(WebKit::WebIDBConnectionToClient::createIndex):
(WebKit::WebIDBConnectionToClient::deleteIndex):
(WebKit::WebIDBConnectionToClient::putOrAdd):
(WebKit::WebIDBConnectionToClient::getRecord):
(WebKit::WebIDBConnectionToClient::getCount):
(WebKit::WebIDBConnectionToClient::deleteRecord):
(WebKit::WebIDBConnectionToClient::openCursor):
(WebKit::WebIDBConnectionToClient::iterateCursor):
(WebKit::WebIDBConnectionToClient::establishTransaction):
(WebKit::WebIDBConnectionToClient::databaseConnectionClosed):
(WebKit::WebIDBConnectionToClient::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToClient::didFireVersionChangeEvent):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
- 12:18 PM Changeset in webkit [196770] by
-
- 10 edits in trunk
[Unforgeable] operations should not be writable as per Web IDL
https://bugs.webkit.org/show_bug.cgi?id=154396
<rdar://problem/24721063>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
[Unforgeable] operations should not be writable as per the Web IDL specification:
http://heycam.github.io/webidl/#es-operations
They were currently non-configurable in WebKit but still writable.
No new tests, already covered by existing test.
- bindings/scripts/CodeGeneratorJS.pm:
Mark [Unforgeable] operations as ReadOnly.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl:
Add bindings test coverage for [Unforgeable].
- 12:14 PM Changeset in webkit [196769] by
-
- 12 edits in trunk
Fix behavior of reflecting unsigned long IDL attributes that are limited to only non-negative numbers greater than zero
https://bugs.webkit.org/show_bug.cgi?id=154398
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/reflection-forms-expected.txt:
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
Source/WebCore:
Fix behavior of reflecting unsigned long IDL attributes that are limited
to only non-negative numbers greater than zero to comply with:
This patch updates the following IDL attributes:
- colgroup.span
- col.span
- input.size
- textarea.cols
- textareal.rows
All of them now:
- Have "unsigned long" type on IDL size and "unsigned" type on native side.
- On getting, return the value if it is in the range [1; 2147483647], otherwise return the default value.
- On setting, set to the input value if it is in the range [1; 2147483647], otherwise, set to the default value.
Note that as per the specification, we are supposed to throw an
IndexSizeError exception when trying to set those attributes to zero.
However, we instead use the default value to match other browsers.
It would be risky to be the only browser to throw in this case.
No new tests, already covered by existing test.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::setSize):
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
(WebCore::HTMLTableColElement::setSpan):
- html/HTMLTableColElement.h:
- html/HTMLTableColElement.idl:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseAttribute):
(WebCore::HTMLTextAreaElement::setCols):
(WebCore::HTMLTextAreaElement::setRows):
(WebCore::HTMLTextAreaElement::shouldUseInputMethod): Deleted.
- html/HTMLTextAreaElement.h:
- html/HTMLTextAreaElement.idl:
- html/parser/HTMLParserIdioms.h:
(WebCore::limitToOnlyNonNegativeNumbersGreaterThanZero):
- 12:07 PM Changeset in webkit [196768] by
-
- 6 edits1 add in trunk/Websites/perf.webkit.org
v3 UI should allow custom revisions for A/B testing
https://bugs.webkit.org/show_bug.cgi?id=154379
Reviewed by Chris Dumez.
Added the capability to customize revisions selected in the overview chart and the results viewer.
Newly added CustomizableTestGroupForm is responsible for allowing users to modify the set of revisions in
a new A/B testing group. Unlike TestGroupForm which doesn't know anything about which revisions are selected
for each project/repository, CustomizableTestGroupForm is aware of the list of revisions used in each set.
The list of revisions used in each set is represented by RootSet if users had not customized them, and
CustomRootSet otherwise; the latter was added since regular RootSet object requires CommitLog and other
DataModelObjects which are hard to create without corresponding database entries.
- public/v3/components/customizable-test-group-form.js: Added.
(CustomizableTestGroupForm): Added.
(CustomizableTestGroupForm.prototype.setRootSetMap): Added.
(CustomizableTestGroupForm.prototype._submitted): Overrides the superclass' method.
(CustomizableTestGroupForm.prototype._customize): Ditto. Unlike TestGroupForm's callback, this class'
callback passes in a root set map as the third argument.
(CustomizableTestGroupForm.prototype._computeRootSetMap): Added. Returns this._rootSetMap, which is set by
AnalysisTaskPage if user had not customized the root sets. Otherwise return a new map with CustomRootSet's.
(CustomizableTestGroupForm.prototype.render): Added. Creates a table to allow customization of root sets.
(CustomizableTestGroupForm._constructRevisionRadioButtons): Added.
(CustomizableTestGroupForm._createRadioButton): Added.
(CustomizableTestGroupForm.cssTemplate): Added.
(CustomizableTestGroupForm.formContent): Added. This method is called by TestGroupForm.htmlTemplate.
- public/v3/components/test-group-form.js:
(TestGroupForm): Updated the various methods to not directly mutate DOM. Store the state in instance
variables and update DOM in render() as done elsewhere.
(TestGroupForm.prototype.setNeedsName): Deleted. We no longer need this flag since TestGroupForm which is
used for retries never needs a name and CustomizableTestGroupForm which is used to create a new test group
always requires a name.
(TestGroupForm.prototype.setDisabled):
(TestGroupForm.prototype.setLabel):
(TestGroupForm.prototype.setRepetitionCount):
(TestGroupForm.prototype.render): Added.
(TestGroupForm.prototype._submitted): Moved the code to prevent the default action has been moved to the
constructor since this method is overridden by CustomizableTestGroupForm.
(TestGroupForm.cssTemplate): Added.
(TestGroupForm.htmlTemplate):
(TestGroupForm.formContent): Extracted from htmlTemplate.
- public/v3/index.html:
- public/v3/models/repository.js:
(Repository.sortByNamePreferringOnesWithURL): Added.
- public/v3/models/root-set.js:
(RootSet.prototype.revisionForRepository): Added so that _createTestGroupAfterVerifyingRootSetList can retrieve
the revision information from CustomRootSet without going through CommitLog objects since CustomRootSet doesn't
have associated CommitLog objects.
(CustomRootSet): Added. Used by CustomizableTestGroupForm to create a custom root map since regular RootSet
requires CommitLog and other related objects which are hard to create without database entries.
(CustomRootSet.prototype.setRevisionForRepository): Added.
(CustomRootSet.prototype.repositories): Added.
(CustomRootSet.prototype.revisionForRepository): Added.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage):
(AnalysisTaskPage.prototype.render): Removed the reference to v2 UI since v3 UI is now strictly more powerful
than v2 UI. Also update the root set maps in each form here.
(AnalysisTaskPage.prototype._retryCurrentTestGroup): No longer takes unused name argument as it got removed
from TestGroupForm.
(AnalysisTaskPage.prototype._chartSelectionDidChange): No longer updates the disabled-ness here since it's now
done in render() via setRootSetMap().
(AnalysisTaskPage.prototype._createNewTestGroupFromChart): Now takes rootSetMap as an argument.
(AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer): No longer updates the disabled-ness here
since it's now done in render() via setRootSetMap().
(AnalysisTaskPage.prototype._createNewTestGroupFromViewer): Now takes rootSetMap as an argument.
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Take a dictionary of root set labels
such as A and B, which maps to a RootSet or a newly-added CustomRootSet.
(AnalysisTaskPage.htmlTemplate): Use customizable-test-group-form for creating a new A/B testing group. Retry
form will continue to use TestGroupForm since customizing revisions is non-sensical in retries.
(AnalysisTaskPage.cssTemplate): Updated the style.
- 11:06 AM Changeset in webkit [196767] by
-
- 3 edits in trunk/Source/WebKit2
[GTK][Threaded Compositor] The web inspector doesn't work when using the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=154067
Reviewed by Carlos Garcia Campos.
The forceCompositingMode should be true for threaded compositor. We set it true for a normal webView
in _WebKitSettingsPrivate() but we do not for inspector anywhere. So DrawingArea is not
properly created for the inspector. Let's move the setting to WebPreferences::platformInitializeStore
which is a common place for the webView and the inspector.
- UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Deleted.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):
- 11:02 AM Changeset in webkit [196766] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r196765.
https://bugs.webkit.org/show_bug.cgi?id=154402
Broke Safari (Requested by andersca on #webkit).
Reverted changeset:
"Remove two unused functions"
https://bugs.webkit.org/show_bug.cgi?id=154397
http://trac.webkit.org/changeset/196765
- 10:44 AM Changeset in webkit [196765] by
-
- 3 edits in trunk/Source/WebKit2
Remove two unused functions
https://bugs.webkit.org/show_bug.cgi?id=154397
Reviewed by Tim Horton.
- UIProcess/API/C/WKContext.cpp:
(WKContextGetPluginSiteDataManager): Deleted.
(WKContextGetResourceCacheManager): Deleted.
- UIProcess/API/C/WKContext.h:
- 10:21 AM Changeset in webkit [196764] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196742
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 10:13 AM Changeset in webkit [196763] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant ASSERT_WITH_MESSAGE_UNUSED() from SOFT_LINK_FRAMEWORK_FOR_SOURCE() macro
Follow-up fix noted by Andy Estes for:
[Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
<http://webkit.org/b/154364>
- platform/mac/SoftLinking.h:
(SOFT_LINK_FRAMEWORK_FOR_SOURCE): Remove redundant
ASSERT_WITH_MESSAGE_UNUSED().
- 9:53 AM Changeset in webkit [196762] by
-
- 14 edits in trunk/LayoutTests
JSC ARM Linux test gardening after r196625
https://bugs.webkit.org/show_bug.cgi?id=154392
Reviewed by Mark Lam.
- js/script-tests/dfg-float32array.js:
- js/script-tests/dfg-float64array.js:
- js/script-tests/dfg-int16array.js:
- js/script-tests/dfg-int32array-overflow-values.js:
- js/script-tests/dfg-int32array.js:
- js/script-tests/dfg-int8array.js:
- js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
- js/script-tests/dfg-uint16array.js:
- js/script-tests/dfg-uint32array-overflow-values.js:
- js/script-tests/dfg-uint32array.js:
- js/script-tests/dfg-uint8array.js:
- js/script-tests/dfg-uint8clampedarray.js:
- js/script-tests/regress-141098.js:
- 9:25 AM Changeset in webkit [196761] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSString resolution of substrings should use StringImpl sharing optimization.
<https://webkit.org/b/154068>
<rdar://problem/24629358>
Reviewed by Antti Koivisto.
When resolving a JSString that's actually a substring of another JSString,
use the StringImpl sharing optimization to create a new string pointing into
the parent one, instead of copying out the bytes of the string.
This dramatically reduces peak memory usage on Gerrit diff viewer pages.
Another approach to this would be to induce GC far more frequently due to
the added cost of copying out these substrings. It would reduce the risk
of prolonging the life of strings only kept alive by substrings.
This patch chooses to trade that risk for less GC and lower peak memory.
- runtime/JSString.cpp:
(JSC::JSRopeString::resolveRope):
- 9:19 AM Changeset in webkit [196760] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash on SES selftest page when loading the page while WebInspector is open
https://bugs.webkit.org/show_bug.cgi?id=154378
<rdar://problem/24713422>
Reviewed by Mark Lam.
Do a partial revert of r196676 so that JSObject::getOwnPropertyDescriptor()
returns early again if it detects that getOwnPropertySlot() returns a
non-own property. This check was removed in r196676 because we assumed that
only JSDOMWindow::getOwnPropertySlot() could return non-own properties.
However, as it turns out, DebuggerScope::getOwnPropertySlot() does so as
well.
Not having the check would lead to crashes when using the debugger because
we would get a slot with the CustomAccessor attribute but getDirect() would
then fail to return the property (because it is not an own property). We
would then cast the value returned by getDirect() to a CustomGetterSetter*
and dereference it.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
- 8:55 AM Changeset in webkit [196759] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix VS build. I didn't know we still did that, but apparently there's a bot
for that.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 8:48 AM Changeset in webkit [196758] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix CMake build. This got messed up when rebasing.
- CMakeLists.txt:
- 8:45 AM Changeset in webkit [196757] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the !ENABLE(DFG_JIT) build after r195865
https://bugs.webkit.org/show_bug.cgi?id=154391
Reviewed by Filip Pizlo.
- runtime/SamplingProfiler.cpp:
(JSC::tryGetBytecodeIndex):
- 8:40 AM Changeset in webkit [196756] by
-
- 27 edits3 moves1 delete in trunk
Remove remaining references to LLVM, and make sure comments refer to the backend as "B3" not "LLVM"
https://bugs.webkit.org/show_bug.cgi?id=154383
Reviewed by Saam Barati.
Source/JavaScriptCore:
I did a grep -i llvm of all of our code and did one of the following for each occurence:
- Renamed it to B3. This is appropriate when we were using "LLVM" to mean "the FTL backend".
- Removed the reference because I found it to be dead. In some cases it was a dead comment: it was telling us things about what LLVM did and that's just not relevant anymore. In other cases it was dead code that I forgot to delete in a previous patch.
- Edited the comment in some smart way. There were comments talking about what LLVM did that were still of interest. In some cases, I added a FIXME to consider changing the code below the comment on the grounds that it was written in a weird way to placate LLVM and so we can do it better now.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGArgumentsEliminationPhase.cpp:
- dfg/DFGOSRAvailabilityAnalysisPhase.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::compileTimeStats):
- dfg/DFGPutStackSinkingPhase.cpp:
- dfg/DFGSSAConversionPhase.h:
- dfg/DFGStaticExecutionCountEstimationPhase.h:
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- disassembler/ARM64Disassembler.cpp:
(JSC::tryToDisassemble): Deleted.
- disassembler/X86Disassembler.cpp:
(JSC::tryToDisassemble):
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::initialize):
- ftl/FTLAbstractHeap.h:
- ftl/FTLFormattedValue.h:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::restoreInto):
- ftl/FTLLowerDFGToB3.cpp: Copied from Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp.
(JSC::FTL::DFG::ftlUnreachable):
(JSC::FTL::DFG::LowerDFGToB3::LowerDFGToB3):
(JSC::FTL::DFG::LowerDFGToB3::compileBlock):
(JSC::FTL::DFG::LowerDFGToB3::compileArithNegate):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiGetByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileOverridesHasInstance):
(JSC::FTL::DFG::LowerDFGToB3::isBoolean):
(JSC::FTL::DFG::LowerDFGToB3::unboxBoolean):
(JSC::FTL::DFG::LowerDFGToB3::emitStoreBarrier):
(JSC::FTL::lowerDFGToB3):
(JSC::FTL::DFG::LowerDFGToLLVM::LowerDFGToLLVM): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::compileBlock): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithNegate): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiGetByOffset): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::compileOverridesHasInstance): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::isBoolean): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::unboxBoolean): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier): Deleted.
(JSC::FTL::lowerDFGToLLVM): Deleted.
- ftl/FTLLowerDFGToB3.h: Copied from Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.h.
- ftl/FTLLowerDFGToLLVM.cpp: Removed.
- ftl/FTLLowerDFGToLLVM.h: Removed.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLWeight.h:
(JSC::FTL::Weight::frequencyClass):
(JSC::FTL::Weight::inverse):
(JSC::FTL::Weight::scaleToTotal): Deleted.
- ftl/FTLWeightedTarget.h:
(JSC::FTL::rarely):
(JSC::FTL::unsure):
- jit/CallFrameShuffler64.cpp:
(JSC::CallFrameShuffler::emitDisplace):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::ftlCalleeSaveRegisters):
- llvm: Removed.
- llvm/InitializeLLVMLinux.cpp: Removed.
- llvm/InitializeLLVMWin.cpp: Removed.
- llvm/library: Removed.
- llvm/library/LLVMTrapCallback.h: Removed.
- llvm/library/libllvmForJSC.version: Removed.
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
- runtime/Options.h:
- wasm/WASMFunctionB3IRGenerator.h: Copied from Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h.
- wasm/WASMFunctionLLVMIRGenerator.h: Removed.
- wasm/WASMFunctionParser.cpp:
Tools:
- Scripts/run-jsc-stress-tests:
- 8:12 AM Changeset in webkit [196755] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Use G_TYPE_ERROR instead of G_TYPE_POINTER for GError parameters of signals
https://bugs.webkit.org/show_bug.cgi?id=153786
Reviewed by Michael Catanzaro.
It's binary compatible and it's needed by binding generator to
properly identify those parameters as GError.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_class_init):
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkit_print_operation_class_init):
- UIProcess/API/gtk/WebKitWebResource.cpp:
(webkit_web_resource_class_init):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init):
- UIProcess/API/gtk/webkit2marshal.list:
- 3:31 AM Changeset in webkit [196754] by
-
- 2 edits4 moves in trunk/Source/WebKit2
[EFL] Move WebView from CoordinatedGraphics to efl
https://bugs.webkit.org/show_bug.cgi?id=154332
Reviewed by Csaba Osztrogonác.
- PlatformEfl.cmake:
- UIProcess/efl/WebView.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp.
- UIProcess/efl/WebView.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.h.
- UIProcess/efl/WebViewClient.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/WebViewClient.cpp.
- UIProcess/efl/WebViewClient.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/WebViewClient.h.
- 3:13 AM Changeset in webkit [196753] by
-
- 5 edits in trunk/Source/WebCore
Reduce tiling coverage immediately when memory pressure hits.
<https://webkit.org/b/154374>
Reviewed by Simon Fraser.
We already had a policy that reduced tiling coverage to a minimum while the system
is under memory pressure. However, that policy wouldn't kick in immediately after
receiving the pressure notification, but the next time we flush compositing state.
This change makes it happen sooner, improving our chances to escape death!
- page/Page.h:
- page/Page.cpp:
(WebCore::Page::forEachPage):
Add a little helper for visiting every Page.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
When under critical memory pressure, schedule a compositing flush in all Pages.
This ensures that the reduced tiling coverage policy takes effect, allowing us to
immediately drop several tiles in each visible web view.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
To ensure that this behavior is testable with the fake memory pressure notification,
make the fake handler set the "in memory pressure" state just like the real one would.
I don't know why we were not doing this previously, it was just an oversight.
After the simulation completes, it schedules a runloop callback that resets the
"in memory pressure" state.
- 2:34 AM Changeset in webkit [196752] by
-
- 2 edits in trunk/Source/JavaScriptCore
[cmake] Build system cleanup
https://bugs.webkit.org/show_bug.cgi?id=154337
Reviewed by Žan Doberšek.
- CMakeLists.txt:
- 12:46 AM Changeset in webkit [196751] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Align console prompt with execution context selector
https://bugs.webkit.org/show_bug.cgi?id=154381
Reviewed by Timothy Hatcher.
- UserInterface/Views/QuickConsole.css:
(.quick-console > .console-prompt > .CodeMirror):
(.quick-console .execution-context):
- 12:34 AM Changeset in webkit [196750] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Storage tab navigation bar should fit on a single line
https://bugs.webkit.org/show_bug.cgi?id=152473
<rdar://problem/24023435>
Patch by Devin Rousso <Devin Rousso> on 2016-02-18
Reviewed by Timothy Hatcher.
- UserInterface/Base/Utilities.js:
(Number.constrain):
Reworked logic to ensure that the returned value is never less than the
given minimum value.
- 12:29 AM Changeset in webkit [196749] by
-
- 2 edits1 delete in trunk
[CMake] Remove LLVM support
https://bugs.webkit.org/show_bug.cgi?id=154370
Reviewed by Csaba Osztrogonác.
After switching all CMake ports to B3, this was only needed for the LLVM disassembler, which
has been removed from JSC. Feel free to bring this back if restoring the LLVM disassembler,
but for the time being this is dead code.
- Source/cmake/FindLLVM.cmake: Removed.
- Source/cmake/OptionsCommon.cmake:
- 12:28 AM Changeset in webkit [196748] by
-
- 2 edits in trunk
[CMake] Remove meaningless conditional statements in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=153778
Reviewed by Csaba Osztrogonác.
- CMakeLists.txt:
Use CMAKE_FOO_OUTPUT_DIRECTORY located in CMakeLists.txt as default value.
And remove conditional statements which has enclosed these one
because they don't have meaning anymore.
Feb 17, 2016:
- 11:25 PM Changeset in webkit [196747] by
-
- 25 edits8 adds in trunk
[Font Loading] Implement FontFaceSet
https://bugs.webkit.org/show_bug.cgi?id=153348
Reviewed by Simon Fraser.
Source/WebCore:
The CSS Font Loading spec includes a FontFaceSet object which represents
a collection of FontFaces. This patch implements such an object, and
backs it with a vector of FontFaces. Similarly to the FontFace object,
FontFaceSet is separated into a FontFaceSet frontend object and a
CSSFontFaceSet backend object, which actually owns the FontFace objects.
All the interaction with Promises is performed in the frontend object.
This patch does not implement the EventTarget part of the FontFaceSet
API, so the only way to know when a font is finished loading is by using
the associated Promise objects.
The CSS Font Loading spec describes how the Document should vend an
instance of FontFaceSet which represents the font faces currently
associated with the Document. However, that functionality is
forthcoming. Currently, the only way to get a FontFaceSet is to create
one yourself (using the constructor). Therefore, this patch does not
implement the spec's notion of a "CSS-connected font face."
Test: fast/text/font-face-set-javascript.html
- CMakeLists.txt: Add new files.
- DerivedSources.make: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSFontFaceSetCustom.cpp: Added.
(WebCore::JSFontFaceSet::ready): Use the Promise member.
(WebCore::JSFontFaceSet::entries): Use existing iterator code.
(WebCore::JSFontFaceSet::keys):
(WebCore::JSFontFaceSet::values):
- css/CSSAllInOne.cpp: Add new files.
- css/CSSFontFace.cpp: We now have a collection of clients (instead of
just one). Also, we need to keep a pointer to our FontFace wrapper.
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::addClient):
(WebCore::CSSFontFace::removeClient):
(WebCore::CSSFontFace::setStatus): Rename the delegate callback to be
more clear.
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::addedToSegmentedFontFace): Deleted.
(WebCore::CSSFontFace::removedFromSegmentedFontFace): Deleted.
- css/CSSFontFace.h: Same as above.
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::Client::~Client):
(WebCore::CSSFontFace::Client::kick):
(WebCore::CSSFontFace::Client::stateChanged):
(WebCore::CSSFontFace::wrapper):
(WebCore::CSSFontFaceClient::~CSSFontFaceClient): Deleted.
- css/CSSFontFaceSet.cpp: Added. Initial imlementation.
(WebCore::CSSFontFaceSet::CSSFontFaceSet):
(WebCore::CSSFontFaceSet::~CSSFontFaceSet):
(WebCore::CSSFontFaceSet::incrementActiveCount):
(WebCore::CSSFontFaceSet::decrementActiveCount):
(WebCore::CSSFontFaceSet::has):
(WebCore::CSSFontFaceSet::add):
(WebCore::CSSFontFaceSet::remove):
(WebCore::extractFamilies):
(WebCore::familiesIntersect): Because this is an initial imlementation,
this function is not optimized. A subsequent patch (which implements
Document.fonts) will optimize this.
(WebCore::CSSFontFaceSet::matchingFaces):
(WebCore::CSSFontFaceSet::load):
(WebCore::CSSFontFaceSet::check):
(WebCore::CSSFontFaceSet::stateChanged):
- css/CSSFontFaceSet.h: Added.
(WebCore::CSSFontFaceSetClient::~CSSFontFaceSetClient):
(WebCore::CSSFontFaceSet::size):
(WebCore::CSSFontFaceSet::operator[]):
(WebCore::CSSFontFaceSet::status):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::familyNameFromPrimitive):
(WebCore::CSSFontSelector::registerLocalFontFacesForFamily):
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::familyNameFromPrimitive): Deleted.
(WebCore::CSSFontSelector::kick): Deleted.
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace):
(WebCore::CSSSegmentedFontFace::appendFontFace):
(WebCore::CSSSegmentedFontFace::kick):
(WebCore::CSSSegmentedFontFace::fontLoaded): Deleted.
- css/CSSSegmentedFontFace.h:
- css/FontFace.cpp:
(WebCore::FontFace::FontFace):
(WebCore::FontFace::~FontFace):
(WebCore::FontFace::stateChanged): Renamed to make its purpose clearer.
(WebCore::FontFace::kick): Deleted.
- css/FontFace.h:
- css/FontFaceSet.cpp: Added.
(WebCore::createPromise):
(WebCore::FontFaceSet::FontFaceSet):
(WebCore::FontFaceSet::~FontFaceSet):
(WebCore::FontFaceSet::Iterator::Iterator):
(WebCore::FontFaceSet::Iterator::next):
(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::PendingPromise::~PendingPromise):
(WebCore::FontFaceSet::has):
(WebCore::FontFaceSet::size):
(WebCore::FontFaceSet::add):
(WebCore::FontFaceSet::remove):
(WebCore::FontFaceSet::clear):
(WebCore::FontFaceSet::load): Most of the complexity of loading is
due to the promises involved. Rather than use the Javascript function
Promise.all(), this patch builds a data structure to represent the
promises which need to be resolved. When fonts finish loading, we look
at the data structure to determine which promises to resolve.
(WebCore::FontFaceSet::check):
(WebCore::FontFaceSet::status):
(WebCore::FontFaceSet::canSuspendForDocumentSuspension):
(WebCore::FontFaceSet::startedLoading):
(WebCore::FontFaceSet::completedLoading):
(WebCore::FontFaceSet::fulfillPromise): Keep the promise alive.
(WebCore::FontFaceSet::faceFinished):
- css/FontFaceSet.h: Added.
(WebCore::FontFaceSet::create):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::check):
(WebCore::FontFaceSet::createIterator):
(WebCore::FontFaceSet::PendingPromise::create):
- css/FontFaceSet.idl: Added.
- dom/EventNames.h:
- dom/EventTargetFactory.in:
LayoutTests:
- fast/text/font-face-set-javascript-expected.txt: Added.
- fast/text/font-face-set-javascript.html: Added.
- 10:37 PM Changeset in webkit [196746] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: In the styles sidebar, Option-clicking on --css-variable should jump to its definition
https://bugs.webkit.org/show_bug.cgi?id=154082
<rdar://problem/24593361>
Patch by Devin Rousso <Devin Rousso> on 2016-02-17
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked.showRangeInSourceCode):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
Now tests to see if the highlighted token was a CSS variable and if
so, attempts to show the declaration of the CSS variable instead of
the location where it is used.
- 10:28 PM Changeset in webkit [196745] by
-
- 8 edits in trunk/Source
Callers of JSString::value() should check for exceptions thereafter.
https://bugs.webkit.org/show_bug.cgi?id=154346
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
JSString::value() can throw an exception if the JS string is a rope and value()
needs to resolve the rope but encounters an OutOfMemory error. If value() is not
able to resolve the rope, it will return a null string (in addition to throwing
the exception). If a caller does not check for exceptions after calling
JSString::value(), they may eventually use the returned null string and crash the
VM.
The fix is to add all the necessary exception checks, and do the appropriate
handling if needed.
- jsc.cpp:
(functionRun):
(functionLoad):
(functionReadFile):
(functionCheckSyntax):
(functionLoadWebAssembly):
(functionLoadModule):
(functionCheckModuleSyntax):
- runtime/DateConstructor.cpp:
(JSC::dateParse):
(JSC::dateNow):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- tools/JSDollarVMPrototype.cpp:
(JSC::functionPrint):
Source/WebCore:
No new tests. The crash that results from this issue is dependent on a race
condition where an OutOfMemory error occurs precisely at the point where the
JSString::value() function is called on a rope JSString.
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::putDelegate):
- Added a comment at the site of the exception check to clarify the meaning of the return value.
- 10:13 PM Changeset in webkit [196744] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Always check the return value of dlopen() and dlsym() in Release builds
<http://webkit.org/b/154364>
Reviewed by Alexey Proskuryakov.
- platform/mac/SoftLinking.h:
(SOFT_LINK_LIBRARY): Change ASSERT_WITH_MESSAGE() to
RELEASE_ASSERT_WITH_MESSAGE().
(SOFT_LINK_FRAMEWORK): Ditto.
(SOFT_LINK_PRIVATE_FRAMEWORK): Ditto.
(SOFT_LINK_STAGED_FRAMEWORK): Ditto.
(SOFT_LINK_FRAMEWORK_IN_UMBRELLA): Ditto.
(SOFT_LINK): Ditto.
(SOFT_LINK_POINTER): Ditto.
(SOFT_LINK_CONSTANT): Ditto.
(SOFT_LINK_FRAMEWORK_FOR_SOURCE): Add
RELEASE_ASSERT_WITH_MESSAGE() when soft-link is not
optional.
- 10:03 PM Changeset in webkit [196743] by
-
- 3 edits in trunk/Source/WebInspectorUI
REGRESSION (r196620): Web Inspector: DataGrid headers and resizers are misaligned when the scrollbar is visible
https://bugs.webkit.org/show_bug.cgi?id=154280
<rdar://problem/24670567>
Reviewed by Timothy Hatcher.
Revert back to "overflow-y: overlay".
- UserInterface/Views/DataGrid.css:
(.data-grid .data-container):
- UserInterface/Views/DatabaseContentView.css:
(.storage-view.query):
- 9:44 PM Changeset in webkit [196742] by
-
- 4 edits in trunk
Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
https://bugs.webkit.org/show_bug.cgi?id=154357
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Make location.assign() / location.replace()'s parameter mandatory,
as per the specification:
https://html.spec.whatwg.org/multipage/browsers.html#the-location-interface
Previously, calling location.assign() / location.replace() without
parameter would be identical to calling location.assign("undefined") /
location.replace("undefined"), which is not useful.
After r196648, http://w3c-test.org/html/dom/interfaces.html was able to
test location.assign() / location.replace() further because they are now
on the instance (where they should be) instead of the prototype. One of
these tests calls these functions without parameter, expecting them to
throw an exception. However, in WebKit, it would not throw and it would
redirect us to http://w3c-test.org/html/dom/undefined.
Firefox and Chrome both follow the specification already and throw in
this case.
No new tests, already covered by existing test.
- page/Location.idl:
Make location.assign() / location.replace()'s parameter mandatory,
as per the specification.
- 9:27 PM Changeset in webkit [196741] by
-
- 4 edits in trunk/Source/WebInspectorUI
REGRESSION (r196620): Web Inspector: When the scrollbars are always visible, the console prompt is 1px taller
https://bugs.webkit.org/show_bug.cgi?id=154328
<rdar://problem/24692996>
Introduce a CSS variable to ensure that the quick console is the
same height as the bottom right section of the styles sidebar.
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
- UserInterface/Views/QuickConsole.css:
(.quick-console):
- UserInterface/Views/Variables.css:
(:root):
- 9:16 PM Changeset in webkit [196740] by
-
- 10 edits in trunk
Unreviewed, rolling out r196738.
https://bugs.webkit.org/show_bug.cgi?id=154380
broke css3/calc/transforms-translate.html (Requested by
alexchristensen on #webkit).
Reverted changeset:
"WebKitCSSMatrix transformList with calculated relative length
crashes Safari."
https://bugs.webkit.org/show_bug.cgi?id=153333
http://trac.webkit.org/changeset/196738
- 7:57 PM Changeset in webkit [196739] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Add Context menu separators to Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=154360
Patch by Devin Rousso <Devin Rousso> on 2016-02-17
Reviewed by Joseph Pecoraro.
In the Styles sidebar, there are three main sections for the context menu:
- Copy and Duplicate/Show-source
- Add pseudo-class rules
- Add/Select pseudo-element rules
These three sections were all put together in the same context menu, which
was very crowded as a result. Separators have been added to make it so that
these three sections are now separated and clearly show their different uses.
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
- UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
- 6:13 PM Changeset in webkit [196738] by
-
- 10 edits in trunk
WebKitCSSMatrix transformList with calculated relative length crashes Safari.
https://bugs.webkit.org/show_bug.cgi?id=153333
<rdar://problem/17198383>
Reviewed by Simon Fraser.
Source/WebCore:
WebKitCSSMatrix objects should fail to construct when not
using absolute lengths.
Updated existing tests:
- transforms/cssmatrix-2d-interface.xhtml
- transforms/cssmatrix-3d-interface.xhtml
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertTransform): Tell transformsForValue
that we don't require absolute lengths.
- css/TransformFunctions.cpp:
(WebCore::convertToFloatLength): Add an optional parameter that will
cause the conversion to fail if the primitive value has a non-absolute
length.
(WebCore::transformsForValue): Pass the parameter for requiring an
absolute length on to convertToFloatLength when necessary.
- css/TransformFunctions.h:
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue): In this case we do
require all transform strings to have absolute lengths, not ones
that depend on the font size or are calculated.
LayoutTests:
Update existing tests to exercise the non-absolute lengths for translation
and perspective functions.
- transforms/cssmatrix-2d-interface-expected.txt:
- transforms/cssmatrix-2d-interface.xhtml:
- transforms/cssmatrix-3d-interface-expected.txt:
- transforms/cssmatrix-3d-interface.xhtml:
- 6:04 PM Changeset in webkit [196737] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r196712.
https://bugs.webkit.org/show_bug.cgi?id=154371
This change caused 5 API test failures on ios-simulator
(Requested by ryanhaddad on #webkit).
Reverted changeset:
"[iOS] Purge GraphicsServices font cache on memory warning."
https://bugs.webkit.org/show_bug.cgi?id=154343
http://trac.webkit.org/changeset/196712
Patch by Commit Queue <commit-queue@webkit.org> on 2016-02-17
- 5:38 PM Changeset in webkit [196736] by
-
- 14 edits in trunk/Source/JavaScriptCore
[JSC] ARM64: Support the immediate format used for bit operations in Air
https://bugs.webkit.org/show_bug.cgi?id=154327
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-17
Reviewed by Filip Pizlo.
ARM64 supports a pretty rich form of immediates for bit operation.
There are two formats used to encode repeating patterns and common
input in a dense form.
In this patch, I add 2 new type of Arg: BitImm32 and BitImm64.
Those represents the valid immediate forms for bit operation.
On x86, any 32bits value is valid. On ARM64, all the encoding
form are tried and the immediate is used when possible.
The arg type Imm64 is renamed to BigImm to better represent what
it is: an immediate that does not fit into Imm.
- assembler/ARM64Assembler.h:
(JSC::LogicalImmediate::create32): Deleted.
(JSC::LogicalImmediate::create64): Deleted.
(JSC::LogicalImmediate::value): Deleted.
(JSC::LogicalImmediate::isValid): Deleted.
(JSC::LogicalImmediate::is64bit): Deleted.
(JSC::LogicalImmediate::LogicalImmediate): Deleted.
(JSC::LogicalImmediate::mask): Deleted.
(JSC::LogicalImmediate::partialHSB): Deleted.
(JSC::LogicalImmediate::highestSetBit): Deleted.
(JSC::LogicalImmediate::findBitRange): Deleted.
(JSC::LogicalImmediate::encodeLogicalImmediate): Deleted.
- assembler/AssemblerCommon.h:
(JSC::ARM64LogicalImmediate::create32):
(JSC::ARM64LogicalImmediate::create64):
(JSC::ARM64LogicalImmediate::value):
(JSC::ARM64LogicalImmediate::isValid):
(JSC::ARM64LogicalImmediate::is64bit):
(JSC::ARM64LogicalImmediate::ARM64LogicalImmediate):
(JSC::ARM64LogicalImmediate::mask):
(JSC::ARM64LogicalImmediate::partialHSB):
(JSC::ARM64LogicalImmediate::highestSetBit):
(JSC::ARM64LogicalImmediate::findBitRange):
(JSC::ARM64LogicalImmediate::encodeLogicalImmediate):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::and64):
(JSC::MacroAssemblerARM64::or64):
(JSC::MacroAssemblerARM64::xor64):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::bitImm):
(JSC::B3::Air::LowerToAir::bitImm64):
(JSC::B3::Air::LowerToAir::appendBinOp):
- b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::dump):
(WTF::printInternal):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::bitImm):
(JSC::B3::Air::Arg::bitImm64):
(JSC::B3::Air::Arg::isBitImm):
(JSC::B3::Air::Arg::isBitImm64):
(JSC::B3::Air::Arg::isSomeImm):
(JSC::B3::Air::Arg::value):
(JSC::B3::Air::Arg::isGP):
(JSC::B3::Air::Arg::isFP):
(JSC::B3::Air::Arg::hasType):
(JSC::B3::Air::Arg::isValidBitImmForm):
(JSC::B3::Air::Arg::isValidBitImm64Form):
(JSC::B3::Air::Arg::isValidForm):
(JSC::B3::Air::Arg::asTrustedImm32):
(JSC::B3::Air::Arg::asTrustedImm64):
- b3/air/AirOpcode.opcodes:
- b3/air/opcode_generator.rb:
- 5:25 PM Changeset in webkit [196735] by
-
- 11 edits4 moves in trunk/Source/WebKit2
Modern IDB: Rename some "UniqueIDBDatabase" classes that conflict with new classes in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=154363.
Reviewed by Alex Christensen.
Adding "Legacy" to the front of the name fixes problems for now.
And all of this gunk will go away after Modern IDB is done, anyways.
- CMakeLists.txt:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::getOrCreateLegacyUniqueIDBDatabase):
(WebKit::DatabaseProcess::removeLegacyUniqueIDBDatabase):
(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase): Deleted.
(WebKit::DatabaseProcess::removeUniqueIDBDatabase): Deleted.
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::establishConnection):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.cpp: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp.
(WebKit::LegacyUniqueIDBDatabase::calculateAbsoluteDatabaseFilename):
(WebKit::LegacyUniqueIDBDatabase::LegacyUniqueIDBDatabase):
(WebKit::LegacyUniqueIDBDatabase::~LegacyUniqueIDBDatabase):
(WebKit::LegacyUniqueIDBDatabase::filenameForDatabaseName):
(WebKit::LegacyUniqueIDBDatabase::databaseFilenameIdentifier):
(WebKit::LegacyUniqueIDBDatabase::canShareDatabases):
(WebKit::LegacyUniqueIDBDatabase::registerConnection):
(WebKit::LegacyUniqueIDBDatabase::unregisterConnection):
(WebKit::LegacyUniqueIDBDatabase::shutdown):
(WebKit::LegacyUniqueIDBDatabase::shutdownBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didShutdownBackingStore):
(WebKit::LegacyUniqueIDBDatabase::deleteDatabase):
(WebKit::LegacyUniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::LegacyUniqueIDBDatabase::openBackingStoreAndReadMetadata):
(WebKit::LegacyUniqueIDBDatabase::didOpenBackingStoreAndReadMetadata):
(WebKit::LegacyUniqueIDBDatabase::openTransaction):
(WebKit::LegacyUniqueIDBDatabase::beginTransaction):
(WebKit::LegacyUniqueIDBDatabase::commitTransaction):
(WebKit::LegacyUniqueIDBDatabase::resetTransaction):
(WebKit::LegacyUniqueIDBDatabase::rollbackTransaction):
(WebKit::LegacyUniqueIDBDatabase::postTransactionOperation):
(WebKit::LegacyUniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::LegacyUniqueIDBDatabase::changeDatabaseVersion):
(WebKit::LegacyUniqueIDBDatabase::didChangeDatabaseVersion):
(WebKit::LegacyUniqueIDBDatabase::didCreateObjectStore):
(WebKit::LegacyUniqueIDBDatabase::didDeleteObjectStore):
(WebKit::LegacyUniqueIDBDatabase::didClearObjectStore):
(WebKit::LegacyUniqueIDBDatabase::didCreateIndex):
(WebKit::LegacyUniqueIDBDatabase::didDeleteIndex):
(WebKit::LegacyUniqueIDBDatabase::didCompleteBoolRequest):
(WebKit::LegacyUniqueIDBDatabase::createObjectStore):
(WebKit::LegacyUniqueIDBDatabase::deleteObjectStore):
(WebKit::LegacyUniqueIDBDatabase::clearObjectStore):
(WebKit::LegacyUniqueIDBDatabase::createIndex):
(WebKit::LegacyUniqueIDBDatabase::deleteIndex):
(WebKit::LegacyUniqueIDBDatabase::putRecord):
(WebKit::LegacyUniqueIDBDatabase::getRecord):
(WebKit::LegacyUniqueIDBDatabase::openCursor):
(WebKit::LegacyUniqueIDBDatabase::cursorAdvance):
(WebKit::LegacyUniqueIDBDatabase::cursorIterate):
(WebKit::LegacyUniqueIDBDatabase::count):
(WebKit::LegacyUniqueIDBDatabase::deleteRange):
(WebKit::LegacyUniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::LegacyUniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::LegacyUniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::LegacyUniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::LegacyUniqueIDBDatabase::rollbackBackingStoreTransaction):
(WebKit::LegacyUniqueIDBDatabase::changeDatabaseVersionInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::createObjectStoreInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::deleteObjectStoreInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::clearObjectStoreInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::createIndexInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::deleteIndexInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::putRecordInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didPutRecordInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::getRecordFromBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didGetRecordFromBackingStore):
(WebKit::LegacyUniqueIDBDatabase::openCursorInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didIterateCursorInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::countInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didCountInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::deleteRangeInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didDeleteRangeInBackingStore):
(WebKit::LegacyUniqueIDBDatabase::didEstablishTransaction):
(WebKit::LegacyUniqueIDBDatabase::didResetTransaction):
(WebKit::LegacyUniqueIDBDatabase::resetAllTransactions):
(WebKit::LegacyUniqueIDBDatabase::finalizeRollback):
(WebKit::LegacyUniqueIDBDatabase::absoluteDatabaseDirectory):
(WebKit::LegacyUniqueIDBDatabase::postMainThreadTask):
(WebKit::LegacyUniqueIDBDatabase::performNextMainThreadTask):
(WebKit::LegacyUniqueIDBDatabase::postDatabaseTask):
(WebKit::LegacyUniqueIDBDatabase::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabase.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.h.
(WebKit::LegacyUniqueIDBDatabase::create):
(WebKit::LegacyUniqueIDBDatabase::identifier):
- DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabaseIdentifier.cpp: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.cpp.
(WebKit::LegacyUniqueIDBDatabaseIdentifier::LegacyUniqueIDBDatabaseIdentifier):
(WebKit::LegacyUniqueIDBDatabaseIdentifier::isHashTableDeletedValue):
(WebKit::LegacyUniqueIDBDatabaseIdentifier::hash):
(WebKit::LegacyUniqueIDBDatabaseIdentifier::isNull):
(WebKit::LegacyUniqueIDBDatabaseIdentifier::isolatedCopy):
(WebKit::operator==):
- DatabaseProcess/IndexedDB/LegacyUniqueIDBDatabaseIdentifier.h: Renamed from Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseIdentifier.h.
(WebKit::LegacyUniqueIDBDatabaseIdentifier::databaseName):
(WebKit::LegacyUniqueIDBDatabaseIdentifier::openingOrigin):
(WebKit::LegacyUniqueIDBDatabaseIdentifier::mainFrameOrigin):
(WebKit::LegacyUniqueIDBDatabaseIdentifierHash::hash):
(WebKit::LegacyUniqueIDBDatabaseIdentifierHash::equal):
(WebKit::LegacyUniqueIDBDatabaseIdentifierHashTraits::isEmptyValue):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- Shared/WebCrossThreadCopier.cpp:
(WebCore::LegacyUniqueIDBDatabaseIdentifier>::copy):
(WebCore::UniqueIDBDatabaseIdentifier>::copy): Deleted.
- Shared/WebCrossThreadCopier.h:
- WebKit2.xcodeproj/project.pbxproj:
- 5:17 PM Changeset in webkit [196734] by
-
- 14 edits1 add in trunk
Spread operator should be allowed when not the first argument of parameter list
https://bugs.webkit.org/show_bug.cgi?id=152721
Reviewed by Saam Barati.
Source/JavaScriptCore:
Spread arguments to functions should now be ES6 compliant. Before we
would only take a spread operator if it was the sole argument to a
function. Additionally, we would not use the Symbol.iterator on the
object to generate the arguments. Instead we would do a loop up to the
length mapping indexed properties to the corresponding argument. We fix
both these issues by doing an AST transformation from foo(...a, b, ...c, d)
to foo(...[...a, b, ...c, d]) (where the spread on the rhs uses the
old spread semantics). This solution has the downside of requiring the
allocation of another object and copying each element twice but avoids a
large change to the vm calling convention.
- interpreter/Interpreter.cpp:
(JSC::loadVarargs):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createElementList):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseArguments):
(JSC::Parser<LexerType>::parseArgument):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/Parser.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createElementList):
- tests/es6.yaml:
- tests/stress/spread-calling.js: Added.
(testFunction):
(testEmpty):
(makeObject):
(otherIterator.return.next):
(otherIterator):
(totalIter):
(throwingIter.return.next):
(throwingIter):
(i.catch):
LayoutTests:
Update tests with new semantics of spread calling. Additionally,
adjust benchmarks to run in a more reasonable time now that
spread is implemented correctly.
- js/basic-spread-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/regress/script-tests/deltablue-varargs.js:
(deltaBlue):
- js/regress/script-tests/varargs-construct.js:
- js/script-tests/basic-spread.js:
- js/script-tests/parser-syntax-check.js:
- 5:05 PM Changeset in webkit [196733] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove a wrong cast in RemoteInspector::receivedSetupMessage
https://bugs.webkit.org/show_bug.cgi?id=154361
<rdar://problem/24709281>
Reviewed by Joseph Pecoraro.
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::receivedSetupMessage):
Not only is this cast unnecessary (the constructor accepts the base class),
but it is wrong since the target could be an automation target. Remove it.
- 5:03 PM Changeset in webkit [196732] by
-
- 5 edits in trunk/Source/WebKit2
Remove WebContextSupplement::shouldTerminate, it's no longer used
https://bugs.webkit.org/show_bug.cgi?id=154367
Reviewed by Sam Weinig.
- UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::shouldTerminate): Deleted.
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::shouldTerminate): Deleted.
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::shouldTerminate): Deleted.
- 4:42 PM Changeset in webkit [196731] by
-
- 5 edits3 moves in trunk/Source/JavaScriptCore
Rename FTLB3Blah to FTLBlah
https://bugs.webkit.org/show_bug.cgi?id=154365
Rubber stamped by Geoffrey Garen, Benjamin Poulain, Awesome Kling, and Saam Barati.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLB3Compile.cpp: Removed.
- ftl/FTLB3Output.cpp: Removed.
- ftl/FTLB3Output.h: Removed.
- ftl/FTLCompile.cpp: Copied from Source/JavaScriptCore/ftl/FTLB3Compile.cpp.
- ftl/FTLOutput.cpp: Copied from Source/JavaScriptCore/ftl/FTLB3Output.cpp.
- ftl/FTLOutput.h: Copied from Source/JavaScriptCore/ftl/FTLB3Output.h.
- 4:37 PM Changeset in webkit [196730] by
-
- 2 edits in trunk/Source/WebKit2
RemoteInspector deadlocks if _WKAutomationDelegate creates/registers a target synchronously
https://bugs.webkit.org/show_bug.cgi?id=154359
<rdar://problem/24708897>
Reviewed by Joseph Pecoraro.
RemoteInspector always grabs a lock whenever receiving or sending XPC messages. If it
forwards a new session request via _WKAutomationDelegate, and the client synchronously
creates and registers a session, then RemoteInspector will try to grab the lock again
while adding the session to its registry, causing a deadlock.
- UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::requestAutomationSession): Add a dispatch_async() to
protect clients from accidentally deadlocking. They shouldn't have to care about
RemoteInspector's locking mechanisms.
- 4:11 PM Changeset in webkit [196729] by
-
- 52 edits57 deletes in trunk
Remove LLVM dependencies from WebKit
https://bugs.webkit.org/show_bug.cgi?id=154323
Reviewed by Antti Koivisto and Benjamin Poulain.
Source/JavaScriptCore:
We have switched all ports that use the FTL JIT to using B3 as the backend. This renders all
LLVM-related code dead, including the disassembler, which was only reachable when you were on
a platform that already had an in-tree disassembler.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGCommon.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::compileTimeStats):
- disassembler/ARM64Disassembler.cpp:
(JSC::tryToDisassemble):
- disassembler/ARMv7Disassembler.cpp:
(JSC::tryToDisassemble):
- disassembler/Disassembler.cpp:
(JSC::disassemble):
(JSC::disassembleAsynchronously):
- disassembler/Disassembler.h:
(JSC::tryToDisassemble):
- disassembler/LLVMDisassembler.cpp: Removed.
- disassembler/LLVMDisassembler.h: Removed.
- disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassembleWithUDis86):
- disassembler/UDis86Disassembler.h:
(JSC::tryToDisassembleWithUDis86):
- disassembler/X86Disassembler.cpp:
(JSC::tryToDisassemble):
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLAbbreviations.h: Removed.
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::AbstractHeap::decorateInstruction):
(JSC::FTL::AbstractHeap::dump):
(JSC::FTL::AbstractField::dump):
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::~IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::baseIndex):
(JSC::FTL::IndexedAbstractHeap::dump):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::dump):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):
(JSC::FTL::AbstractHeap::tbaaMetadataSlow): Deleted.
- ftl/FTLAbstractHeap.h:
(JSC::FTL::AbstractHeap::AbstractHeap):
(JSC::FTL::AbstractHeap::heapName):
(JSC::FTL::IndexedAbstractHeap::atAnyIndex):
(JSC::FTL::NumberedAbstractHeap::atAnyNumber):
(JSC::FTL::AbsoluteAbstractHeap::atAnyAddress):
(JSC::FTL::AbstractHeap::tbaaMetadata): Deleted.
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLB3Compile.cpp:
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::Output):
(JSC::FTL::Output::check):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
- ftl/FTLB3Output.h:
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
(JSC::FTL::CommonValues::initializeConstants):
- ftl/FTLCommonValues.h:
(JSC::FTL::CommonValues::initialize): Deleted.
- ftl/FTLCompile.cpp: Removed.
- ftl/FTLCompileBinaryOp.cpp: Removed.
- ftl/FTLCompileBinaryOp.h: Removed.
- ftl/FTLDWARFDebugLineInfo.cpp: Removed.
- ftl/FTLDWARFDebugLineInfo.h: Removed.
- ftl/FTLDWARFRegister.cpp: Removed.
- ftl/FTLDWARFRegister.h: Removed.
- ftl/FTLDataSection.cpp: Removed.
- ftl/FTLDataSection.h: Removed.
- ftl/FTLExceptionHandlerManager.cpp: Removed.
- ftl/FTLExceptionHandlerManager.h: Removed.
- ftl/FTLExceptionTarget.cpp:
- ftl/FTLExceptionTarget.h:
- ftl/FTLExitThunkGenerator.cpp: Removed.
- ftl/FTLExitThunkGenerator.h: Removed.
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLInlineCacheDescriptor.h: Removed.
- ftl/FTLInlineCacheSize.cpp: Removed.
- ftl/FTLInlineCacheSize.h: Removed.
- ftl/FTLIntrinsicRepository.cpp: Removed.
- ftl/FTLIntrinsicRepository.h: Removed.
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::initializeB3Code):
(JSC::FTL::JITCode::initializeB3Byproducts):
(JSC::FTL::JITCode::initializeAddressForCall):
(JSC::FTL::JITCode::contains):
(JSC::FTL::JITCode::ftl):
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::FTL::JITCode::initializeExitThunks): Deleted.
(JSC::FTL::JITCode::addHandle): Deleted.
(JSC::FTL::JITCode::addDataSection): Deleted.
(JSC::FTL::JITCode::exitThunks): Deleted.
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::b3Code):
(JSC::FTL::JITCode::handles): Deleted.
(JSC::FTL::JITCode::dataSections): Deleted.
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::codeSize):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- ftl/FTLJSCall.cpp: Removed.
- ftl/FTLJSCall.h: Removed.
- ftl/FTLJSCallBase.cpp: Removed.
- ftl/FTLJSCallBase.h: Removed.
- ftl/FTLJSCallVarargs.cpp: Removed.
- ftl/FTLJSCallVarargs.h: Removed.
- ftl/FTLJSTailCall.cpp: Removed.
- ftl/FTLJSTailCall.h: Removed.
- ftl/FTLLazySlowPath.cpp:
(JSC::FTL::LazySlowPath::LazySlowPath):
(JSC::FTL::LazySlowPath::generate):
- ftl/FTLLazySlowPath.h:
(JSC::FTL::LazySlowPath::createGenerator):
(JSC::FTL::LazySlowPath::patchableJump):
(JSC::FTL::LazySlowPath::done):
(JSC::FTL::LazySlowPath::usedRegisters):
(JSC::FTL::LazySlowPath::callSiteIndex):
(JSC::FTL::LazySlowPath::stub):
(JSC::FTL::LazySlowPath::patchpoint): Deleted.
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forValueRep):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::forStackmaps): Deleted.
- ftl/FTLLocation.h:
(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::forIndirect):
(JSC::FTL::Location::forConstant):
(JSC::FTL::Location::kind):
(JSC::FTL::Location::hasReg):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePhi):
(JSC::FTL::DFG::LowerDFGToLLVM::compileDoubleConstant):
(JSC::FTL::DFG::LowerDFGToLLVM::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToLLVM::compileStrCat):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBitAnd):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBitOr):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBitXor):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBitRShift):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBitLShift):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBitURShift):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIsUndefined):
(JSC::FTL::DFG::LowerDFGToLLVM::compileIn):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::loadButterflyWithBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::stringsEqual):
(JSC::FTL::DFG::LowerDFGToLLVM::emitRightShiftSnippet):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateCell):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::speculate):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::preparePatchpointForExceptions):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::blessSpeculation):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::DFG::LowerDFGToLLVM::exitValueForAvailability):
(JSC::FTL::DFG::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::DFG::LowerDFGToLLVM::probe):
(JSC::FTL::DFG::LowerDFGToLLVM::crash):
(JSC::FTL::DFG::LowerDFGToLLVM::compileUntypedBinaryOp): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::emitOSRExitCall): Deleted.
(JSC::FTL::DFG::LowerDFGToLLVM::callStackmap): Deleted.
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::validateReferences):
(JSC::FTL::OSRExitDescriptor::emitOSRExit):
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::gatherRegistersToSpillForCallIfException): Deleted.
(JSC::FTL::OSRExit::spillRegistersToSpillSlot): Deleted.
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot): Deleted.
(JSC::FTL::OSRExit::willArriveAtExitFromIndirectExceptionCheck): Deleted.
(JSC::FTL::OSRExit::willArriveAtOSRExitFromCallOperation): Deleted.
(JSC::FTL::OSRExit::needsRegisterRecoveryOnGenericUnwindOSRExitPath): Deleted.
- ftl/FTLOSRExit.h:
(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):
(JSC::FTL::OSRExitDescriptorImpl::OSRExitDescriptorImpl): Deleted.
- ftl/FTLOSRExitCompilationInfo.h: Removed.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileRecovery):
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLOSRExitHandle.cpp:
- ftl/FTLOSRExitHandle.h:
- ftl/FTLOutput.cpp: Removed.
- ftl/FTLOutput.h: Removed.
- ftl/FTLPatchpointExceptionHandle.cpp:
- ftl/FTLPatchpointExceptionHandle.h:
- ftl/FTLStackMaps.cpp: Removed.
- ftl/FTLStackMaps.h: Removed.
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
(JSC::FTL::State::~State):
(JSC::FTL::State::dumpState): Deleted.
- ftl/FTLState.h:
- ftl/FTLUnwindInfo.cpp: Removed.
- ftl/FTLUnwindInfo.h: Removed.
- ftl/FTLValueRange.cpp:
(JSC::FTL::ValueRange::decorateInstruction):
- ftl/FTLValueRange.h:
(JSC::FTL::ValueRange::ValueRange):
(JSC::FTL::ValueRange::begin):
(JSC::FTL::ValueRange::end):
- ftl/FTLWeight.h:
(JSC::FTL::Weight::value):
(JSC::FTL::Weight::frequencyClass):
(JSC::FTL::Weight::scaleToTotal):
- llvm/InitializeLLVM.cpp: Removed.
- llvm/InitializeLLVM.h: Removed.
- llvm/InitializeLLVMMac.cpp: Removed.
- llvm/InitializeLLVMPOSIX.cpp: Removed.
- llvm/InitializeLLVMPOSIX.h: Removed.
- llvm/LLVMAPI.cpp: Removed.
- llvm/LLVMAPI.h: Removed.
- llvm/LLVMAPIFunctions.h: Removed.
- llvm/LLVMHeaders.h: Removed.
- llvm/library/LLVMAnchor.cpp: Removed.
- llvm/library/LLVMExports.cpp: Removed.
- llvm/library/LLVMOverrides.cpp: Removed.
- llvm/library/config_llvm.h: Removed.
Source/WTF:
- wtf/Platform.h:
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
(isContentOfFileEqualToString):
(fileContains): Deleted.
(buildLLVM): Deleted.
(symlinkLLVMLibrariesIfNeeded): Deleted.
WebKitLibraries:
- LLVMIncludesElCapitan.tar.bz2: Removed.
- LLVMIncludesIOS9.tar.bz2: Removed.
- LLVMIncludesMavericks.tar.bz2: Removed.
- LLVMIncludesYosemite.tar.bz2: Removed.
- LLVMLibrariesElCapitan.tar.bz2: Removed.
- LLVMLibrariesIOS9.tar.bz2: Removed.
- LLVMLibrariesMavericks.tar.bz2: Removed.
- LLVMLibrariesYosemite.tar.bz2: Removed.
- 3:45 PM Changeset in webkit [196728] by
-
- 3 edits in trunk/Source/WebKit2
Remove an unused function
https://bugs.webkit.org/show_bug.cgi?id=154358
Reviewed by Sam Weinig.
- Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext): Deleted.
- Platform/cg/CGUtilities.h:
- 3:36 PM Changeset in webkit [196727] by
-
- 1 edit2 adds in trunk/LayoutTests
Add ios-simulator baseline for new W3C HTML tests added with r196710
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt: Added.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: Added.
- 3:35 PM Changeset in webkit [196726] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
[JSC] Remove the overflow check on ArithAbs when possible
https://bugs.webkit.org/show_bug.cgi?id=154325
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-17
Reviewed by Filip Pizlo.
This patch adds support for ArithMode for ArithAbs.
It is useful for kraken tests where Math.abs() is used
on values for which the range is known.
For example, imaging-gaussian-blur has two Math.abs() with
integers that are always in a small range around zero.
The IntegerRangeOptimizationPhase detects the range correctly
so we can just update the ArithMode depending on the input.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGIntegerRangeOptimizationPhase.cpp:
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToArithNegate):
(JSC::DFG::Node::hasArithMode):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAbs):
- tests/stress/arith-abs-integer-range-optimization.js: Added.
(negativeRange):
(negativeRangeIncludingZero):
(negativeRangeWithOverflow):
(positiveRange):
(positiveRangeIncludingZero):
(rangeWithoutOverflow):
- tests/stress/arith-abs-with-bitwise-or-zero.js: Added.
(opaqueAbs):
- 3:25 PM Changeset in webkit [196725] by
-
- 10 edits in trunk/Source
Modern IDB: More Encoder/Decoder/Messaging scaffolding for WK2 IPC.
https://bugs.webkit.org/show_bug.cgi?id=154356
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/shared/IDBDatabaseInfo.h:
(WebCore::IDBDatabaseInfo::encode):
(WebCore::IDBDatabaseInfo::decode):
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::encode):
(WebCore::IDBError::decode):
- Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::decode):
- Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::encode):
(WebCore::IDBResultData::decode):
Source/WebKit2:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::didDeleteDatabase):
(WebKit::WebIDBConnectionToClient::didOpenDatabase):
(WebKit::WebIDBConnectionToClient::didAbortTransaction):
(WebKit::WebIDBConnectionToClient::didCommitTransaction):
(WebKit::WebIDBConnectionToClient::didCreateObjectStore):
(WebKit::WebIDBConnectionToClient::didDeleteObjectStore):
(WebKit::WebIDBConnectionToClient::didClearObjectStore):
(WebKit::WebIDBConnectionToClient::didCreateIndex):
(WebKit::WebIDBConnectionToClient::didDeleteIndex):
(WebKit::WebIDBConnectionToClient::didPutOrAdd):
(WebKit::WebIDBConnectionToClient::didGetRecord):
(WebKit::WebIDBConnectionToClient::didGetCount):
(WebKit::WebIDBConnectionToClient::didDeleteRecord):
(WebKit::WebIDBConnectionToClient::didOpenCursor):
(WebKit::WebIDBConnectionToClient::didIterateCursor):
(WebKit::WebIDBConnectionToClient::fireVersionChangeEvent):
(WebKit::WebIDBConnectionToClient::didStartTransaction):
(WebKit::WebIDBConnectionToClient::notifyOpenDBRequestBlocked):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:
- 3:11 PM Changeset in webkit [196724] by
-
- 2 edits in trunk/Source/WebKit2
Fix GTK build after r196720.
- UIProcess/API/gtk/WebKitUIClient.cpp:
- 2:59 PM Changeset in webkit [196723] by
-
- 3 edits2 adds in trunk
SES selftest page crashes on nightly r196694
https://bugs.webkit.org/show_bug.cgi?id=154350
<rdar://problem/24704334>
Reviewed by Mark Lam.
Source/JavaScriptCore:
SES selftest page crashes after r196001 / r196145 when calling
Object.getOwnPropertyDescriptor(window, "length") after the window
has been reified and "length" has been shadowed by a value property.
It was crashing in JSObject::getOwnPropertyDescriptor() because
we are getting a slot that has attribute "CustomAccessor" but
the property is not a CustomGetterSetter. In this case, since
window.length is [Replaceable] and has been set to a numeric value,
it makes that the property is not a CustomGetterSetter. However,
the "CustomAccessor" attribute should have been dropped from the
slot when window.length was shadowed. Therefore, this code path
should not be exercised at all when calling
getOwnPropertyDescriptor().
The issue was that putDirectInternal() was updating the slot
attributes only if the "Accessor" flag has changed, but not
the "customAccessor" flag. This patch fixes the issue.
- runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
LayoutTests:
Add test coverage for the crash which happens when shadowing window.length
with a value after the window property and then calling
Object.getOwnPropertyDescriptor(window, "length").
- js/window-length-getOwnPropertyDescriptor-crash-expected.txt: Added.
- js/window-length-getOwnPropertyDescriptor-crash.html: Added.
- 2:11 PM Changeset in webkit [196722] by
-
- 36 edits8 adds in trunk/Source
Implement Proxy Get
https://bugs.webkit.org/show_bug.cgi?id=154081
Reviewed by Michael Saboff.
Source/JavaScriptCore:
This patch implements ProxyObject and ProxyConstructor. Their
implementations are straight forward and follow the spec.
The largest change in this patch is adding a second parameter
to PropertySlot's constructor that specifies the internal method type of
the getOwnPropertySlot inquiry. We use getOwnPropertySlot to
implement more than one Internal Method in the spec. Because
of this, we need InternalMethodType to give us context about
which Internal Method we're executing. Specifically, Proxy will
call into different handlers based on this information.
InternalMethodType is an enum with the following values:
- Get This corresponds to Get internal method in the spec.
- GetOwnProperty This corresponds to GetOwnProperty internal method in the spec.
- HasProperty This corresponds to HasProperty internal method in the spec.
- VMInquiry This is basically everything else that isn't one of the above types. This value also mandates that getOwnPropertySlot does not perform any user observable effects. I.e, it can't call a JS function.
The other non-VMInquiry InternalMethodTypes are allowed to perform user
observable effects. I.e, in future patches, ProxyObject will implement
InternalMethodType::HasProperty and InternalMethodType::GetOwnProperty, which will both be defined
to call user defined JS functions, which clearly have the right to perform
user observable effects.
This patch implements getOwnPropertySlot of ProxyObject under
InternalMethodType::Get.
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::put):
(JSC::JSCallbackObject<Parent>::staticFunctionGetter):
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::caughtValue):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ArrayPrototype.cpp:
(JSC::getProperty):
- runtime/CommonIdentifiers.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::get):
- runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::defineOwnProperty):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::regExpMatchesArrayStructure):
(JSC::JSGlobalObject::moduleRecordStructure):
(JSC::JSGlobalObject::moduleNamespaceObjectStructure):
(JSC::JSGlobalObject::proxyObjectStructure):
(JSC::JSGlobalObject::wasmModuleStructure):
- runtime/JSModuleEnvironment.cpp:
(JSC::JSModuleEnvironment::getOwnPropertySlot):
- runtime/JSModuleNamespaceObject.cpp:
(JSC::callbackGetter):
- runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
- runtime/JSObject.cpp:
(JSC::JSObject::calculatedClassName):
(JSC::JSObject::putDirectNonIndexAccessor):
(JSC::JSObject::hasProperty):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/JSObject.h:
(JSC::JSObject::getDirectIndex):
(JSC::JSObject::get):
- runtime/JSScope.cpp:
(JSC::abstractAccess):
- runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncToString):
- runtime/PropertySlot.h:
(JSC::attributesForStructure):
(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::isCacheableGetter):
(JSC::PropertySlot::isCacheableCustom):
(JSC::PropertySlot::internalMethodType):
(JSC::PropertySlot::disableCaching):
(JSC::PropertySlot::getValue):
- runtime/ProxyConstructor.cpp: Added.
(JSC::ProxyConstructor::create):
(JSC::ProxyConstructor::ProxyConstructor):
(JSC::ProxyConstructor::finishCreation):
(JSC::constructProxyObject):
(JSC::ProxyConstructor::getConstructData):
(JSC::ProxyConstructor::getCallData):
- runtime/ProxyConstructor.h: Added.
(JSC::ProxyConstructor::createStructure):
- runtime/ProxyObject.cpp: Added.
(JSC::ProxyObject::ProxyObject):
(JSC::ProxyObject::finishCreation):
(JSC::performProxyGet):
(JSC::ProxyObject::getOwnPropertySlotCommon):
(JSC::ProxyObject::getOwnPropertySlot):
(JSC::ProxyObject::getOwnPropertySlotByIndex):
(JSC::ProxyObject::visitChildren):
- runtime/ProxyObject.h: Added.
(JSC::ProxyObject::create):
(JSC::ProxyObject::createStructure):
(JSC::ProxyObject::target):
(JSC::ProxyObject::handler):
- runtime/ReflectObject.cpp:
(JSC::reflectObjectGet):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::nameFromCallee):
- tests/es6.yaml:
- tests/stress/proxy-basic.js: Added.
(assert):
(let.handler.get null):
(get let):
(let.handler.get switch):
(let.handler):
(let.theTarget.get x):
- tests/stress/proxy-in-proto-chain.js: Added.
(assert):
- tests/stress/proxy-of-a-proxy.js: Added.
(assert):
(throw.new.Error.):
- tests/stress/proxy-property-descriptor.js: Added.
(assert):
(set Object):
- wasm/WASMModuleParser.cpp:
(JSC::WASMModuleParser::getImportedValue):
Source/WebCore:
Tests are in JavaScriptCore.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::getProperty):
(WebCore::getHashAlgorithm):
- bindings/js/JSCryptoKeySerializationJWK.cpp:
(WebCore::getJSArrayFromJSON):
(WebCore::getStringFromJSON):
(WebCore::getBooleanFromJSON):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::returnValue):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::tryGetProperty):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::deletePropertyByIndex):
(WebCore::JSStorage::putDelegate):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::getProperty):
- testing/Internals.cpp:
(WebCore::Internals::isReadableStreamDisturbed):
- 2:03 PM Changeset in webkit [196721] by
-
- 2 edits in trunk/Source/JavaScriptCore
StringPrototype functions should check for exceptions after calling JSString::value().
https://bugs.webkit.org/show_bug.cgi?id=154340
Reviewed by Filip Pizlo.
JSString::value() can throw an exception if the JS string is a rope and value()
needs to resolve the rope but encounters an OutOfMemory error. If value() is not
able to resolve the rope, it will return a null string (in addition to throwing
the exception). If StringPrototype functions do not check for exceptions after
calling JSString::value(), they may eventually use the returned null string and
crash the VM.
The fix is to add all the necessary exception checks, and do the appropriate
handling if needed.
Also in a few place where when an exception is detected, we return JSValue(), I
changed it to return jsUndefined() instead to be consistent with the rest of the
file.
- runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString):
- 1:46 PM Changeset in webkit [196720] by
-
- 9 edits in trunk/Source/WebKit2
Need listener-based version of runBeforeUnloadConfirmPanel
https://bugs.webkit.org/show_bug.cgi?id=154354
rdar://problem/23736691
Reviewed by Sam Weinig.
- Shared/API/APIObject.h:
- Shared/API/c/WKBase.h:
- UIProcess/API/APIUIClient.h:
(API::UIClient::runBeforeUnloadConfirmPanel):
- UIProcess/API/C/WKPage.cpp:
(fixUpBotchedPageUIClient):
(WebKit::RunBeforeUnloadConfirmPanelResultListener::create):
(WebKit::RunBeforeUnloadConfirmPanelResultListener::~RunBeforeUnloadConfirmPanelResultListener):
(WebKit::RunBeforeUnloadConfirmPanelResultListener::call):
(WKPageRunBeforeUnloadConfirmPanelResultListenerGetTypeID):
(WKPageRunBeforeUnloadConfirmPanelResultListenerCall):
(WKPageSetPageUIClient):
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- 1:44 PM Changeset in webkit [196719] by
-
- 5 edits in trunk/LayoutTests
Add tests for iframe and overflow scrollability after navigating back
https://bugs.webkit.org/show_bug.cgi?id=154300
Fix the tests added in r196665 to be agnostic about how many pixels a wheel event scrolls.
- fast/scrolling/iframe-scrollable-after-back-expected.txt:
- fast/scrolling/iframe-scrollable-after-back.html:
- fast/scrolling/overflow-scrollable-after-back-expected.txt:
- fast/scrolling/overflow-scrollable-after-back.html:
- 1:33 PM Changeset in webkit [196718] by
-
- 1 edit3 adds in trunk/LayoutTests
[ES6] Arrow function. Arrow function should raise exception ReferenceError only when access to 'arguments' on top level
https://bugs.webkit.org/show_bug.cgi?id=152570
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-02-17
Reviewed by Saam Barati.
Add tests to ensure that arrrow function return error when it binds arguments on top level
- js/arrowfunction-lexical-bind-arguments-top-level-expected.txt: Added.
- js/arrowfunction-lexical-bind-arguments-top-level.html: Added.
- js/script-tests/arrowfunction-lexical-bind-arguments-top-level.js: Added.
- 1:27 PM Changeset in webkit [196717] by
-
- 11 edits in trunk/Source
PDFPlugin's scrollableArea container is not properly unregistered when page is going into the PageCache
https://bugs.webkit.org/show_bug.cgi?id=148182
Reviewed by Brent Fulgham.
Source/WebCore:
When handling Command-arrow key while showing a scrollable PDF, the timing of PDFPlugin
teardown and navigation could result in PDFPlugin::destroy() getting the wrong FrameView,
so the old FrameView was left with a stale pointer in its scrollableAreaSet.
Fix this by adding an explicit willDetatchRenderer() which is called on the plugin
before the Frame gets a new FrameView.
Also narrow the scope of the RefPtr<Widget> in HTMLPlugInElement::defaultEventHandler()
so that the Widget is not kept alive over a possible navigation.
I was unable to make an automated test, because reproducing the bug requires handling
a Command-arrow key event in a way that the last ref to a Widget is held over the event
handling, and this wasn't possible in an iframe.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willDetachRenderers):
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::willDetatchRenderer):
- style/StyleTreeResolver.cpp:
(WebCore::Style::detachRenderTree): Drive-by nullptr.
Source/WebKit2:
When handling Command-arrow key while showing a scrollable PDF, the timing of PDFPlugin
teardown and navigation could result in PDFPlugin::destroy() getting the wrong FrameView,
so the old FrameView was left with a stale pointer in its scrollableAreaSet.
Fix this by adding an explicit willDetatchRenderer() which is called on the plugin
before the Frame gets a new FrameView.
Also narrow the scope of the RefPtr<Widget> in HTMLPlugInElement::defaultEventHandler()
so that the Widget is not kept alive over a possible navigation.
I was unable to make an automated test, because reproducing the bug requires handling
a Command-arrow key event in a way that the last ref to a Widget is held over the event
handling, and this wasn't possible in an iframe.
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::willDetatchRenderer):
- WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::willDetatchRenderer):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::willDetatchRenderer):
- WebProcess/Plugins/PluginView.h:
- 1:17 PM Changeset in webkit [196716] by
-
- 4 edits in trunk
Add an ensure function on HashMap that takes a key and a function to make the lazy value initialization idiom easier
https://bugs.webkit.org/show_bug.cgi?id=134857
Reviewed by Geoffrey Garen.
Source/WTF:
The current idiom for adding a value to a HashMap if the key is not already present, to allow for not
unnecessarily constructing the new value if it won't be used, is:
{
auto result = map.add(key, Value());
if (!result.isNewEntry)
return result.iterator->value;
result.iterator->value = createNewValue();
return result.iterator->value;
}
or sometimes
{
auto& value = map.add(key, Value()).iterator->value;
if (!value)
value = createNewValue();
return value;
}
With this patch, you can now use the new function HashMap::ensure(key, functor). This will allow us to
change to using the following idiom:
{
return map.ensure(key, [] { return createNewValue(); });
}
The passed in functor will only be called if the key is not already present in the HashMap.
- wtf/HashMap.h:
(WTF::HashMapTranslator::translate):
(WTF::HashMapEnsureTranslator::hash):
(WTF::HashMapEnsureTranslator::equal):
(WTF::HashMapEnsureTranslator::translate):
(WTF::HashMapTranslatorAdapter::hash):
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
Add tests for HashMap::ensure.
- 12:42 PM Changeset in webkit [196715] by
-
- 10 edits in trunk/Source
Modern IDB: Encoder/Decoder/Messaging scaffolding for WK2 IPC.
https://bugs.webkit.org/show_bug.cgi?id=154351
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/IDBDatabaseIdentifier.h:
(WebCore::IDBDatabaseIdentifier::encode):
(WebCore::IDBDatabaseIdentifier::decode):
- Modules/indexeddb/shared/IDBCursorInfo.h:
(WebCore::IDBCursorInfo::encode):
(WebCore::IDBCursorInfo::decode):
- Modules/indexeddb/shared/IDBIndexInfo.h:
(WebCore::IDBIndexInfo::encode):
(WebCore::IDBIndexInfo::decode):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
(WebCore::IDBObjectStoreInfo::encode):
(WebCore::IDBObjectStoreInfo::decode):
- Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::encode):
(WebCore::IDBRequestData::decode):
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
(WebCore::IDBResourceIdentifier::encode):
(WebCore::IDBResourceIdentifier::decode):
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::encode):
(WebCore::IDBTransactionInfo::decode):
Source/WebKit2:
Implement in all of the client->server message sends, requiring many Encoder/Decoders for
IDB objects to also be implemented:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToServer::createObjectStore):
(WebKit::WebIDBConnectionToServer::deleteObjectStore):
(WebKit::WebIDBConnectionToServer::clearObjectStore):
(WebKit::WebIDBConnectionToServer::createIndex):
(WebKit::WebIDBConnectionToServer::deleteIndex):
(WebKit::WebIDBConnectionToServer::putOrAdd):
(WebKit::WebIDBConnectionToServer::getRecord):
(WebKit::WebIDBConnectionToServer::getCount):
(WebKit::WebIDBConnectionToServer::deleteRecord):
(WebKit::WebIDBConnectionToServer::openCursor):
(WebKit::WebIDBConnectionToServer::iterateCursor):
(WebKit::WebIDBConnectionToServer::establishTransaction):
(WebKit::WebIDBConnectionToServer::databaseConnectionClosed):
(WebKit::WebIDBConnectionToServer::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToServer::didFireVersionChangeEvent):
- 12:40 PM Changeset in webkit [196714] by
-
- 2 edits in trunk/Source/WebKit/ios
[iOS WK1] NSTimer in WebGeolocationProviderIOS.mm fires on the main thread without the WebThreadLock
<http://webkit.org/b/154347>
<rdar://problem/19360382>
Reviewed by Andy Estes.
This isn't testable because the GeolocationClientMock in WebCore
bypasses this code in WebKit1.
- Misc/WebGeolocationProviderIOS.mm:
(-[WebGeolocationProviderIOS _handlePendingInitialPosition:]):
Assert that this is always called on the WebThread.
(-[WebGeolocationProviderIOS registerWebView:]): Register the
NSTimer on the WebThread NSRunLoop.
- 12:29 PM Changeset in webkit [196713] by
-
- 23 edits in trunk/Source/WebInspectorUI
Web Inspector: add CSS variables for common border/background colors
https://bugs.webkit.org/show_bug.cgi?id=154302
<rdar://problem/24680944>
Reviewed by Timothy Hatcher.
Added CSS variables for commonly used border and background colors, and removed
duplicate CSS variables with less generic names. Inactive border colors declared in
rules with a body.window-inactive selector have been removed. A new rule using this
selector in Variables.css sets "--border-color" to the inactive color.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content > .pseudo-classes):
(.sidebar > .panel.details.css-style > .content ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-has-label)):
- UserInterface/Views/DataGrid.css:
(.data-grid.inline):
(.data-grid th):
(.data-grid :matches(th, td):not(:last-child)):
(body.window-inactive .data-grid th): Deleted.
(body.window-inactive .data-grid :matches(th, td):not(:last-child)): Deleted.
- UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
- UserInterface/Views/DetailsSection.css:
(.details-section):
(.details-section .details-section:first-child):
(.details-section > .header):
(.details-section > .content > .group):
(.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
- UserInterface/Views/FilterBar.css:
(.filter-bar):
- UserInterface/Views/FindBanner.css:
(.find-banner):
(body.window-inactive .find-banner): Deleted.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
(.panel.details.layer-tree .bottom-bar):
- UserInterface/Views/Main.css:
(body.docked.bottom):
(body.docked.right):
(#split-content-browser):
(#split-content-browser > .navigation-bar):
(body.window-inactive.docked.bottom): Deleted.
(body.window-inactive.docked.right): Deleted.
(body.window-inactive #split-content-browser): Deleted.
- UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view):
(.memory-category-view > .details):
(body.window-inactive .memory-category-view): Deleted.
(body.window-inactive .memory-category-view > .details): Deleted.
- UserInterface/Views/MemoryTimelineView.css:
(.timeline-view.memory):
(.timeline-view.memory > .content > .overview):
(.timeline-view.memory > .content > .details > .subtitle):
(.timeline-view.memory > .content > .overview > .divider):
(body.window-inactive .timeline-view.memory): Deleted.
(body.window-inactive .timeline-view.memory > .content > .overview): Deleted.
(body.window-inactive .timeline-view.memory > .content > .details > .subtitle): Deleted.
(body.window-inactive .timeline-view.memory > .content > .overview > .divider): Deleted.
- UserInterface/Views/NavigationBar.css:
(.navigation-bar):
(body.window-inactive .navigation-bar): Deleted.
- UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .overflow-shadow):
(body.window-inactive .sidebar > .panel.navigation > .overflow-shadow): Deleted.
- UserInterface/Views/NetworkSidebarPanel.css:
(.sidebar > .panel.navigation.network > .title-bar):
(body.window-inactive .sidebar > .panel.navigation.network > .title-bar): Deleted.
- UserInterface/Views/OverviewTimelineView.css:
(.timeline-view.overview > .timeline-ruler > .header):
(body.window-inactive .timeline-view.overview > .timeline-ruler > .header): Deleted.
- UserInterface/Views/QuickConsole.css:
(.quick-console):
(body.window-inactive .quick-console): Deleted.
- UserInterface/Views/Sidebar.css:
(.sidebar):
(.sidebar.left):
(.sidebar.right):
(body.window-inactive .sidebar.left): Deleted.
(body.window-inactive .sidebar.right): Deleted.
- UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th):
(body.window-inactive .data-grid.timeline th): Deleted.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .header):
(body.window-inactive .timeline-ruler > .header): Deleted.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .title-bar):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(body.window-inactive .sidebar > .panel.navigation.timeline > .title-bar): Deleted.
(body.window-inactive .sidebar > .panel.navigation.timeline > .title-bar.timeline-events): Deleted.
- UserInterface/Views/Toolbar.css:
(body.latest-mac .toolbar .dashboard-container):
- UserInterface/Views/Variables.css:
(:root):
(body.window-inactive *):
- UserInterface/Views/VisualStyleSelectorSection.css:
(.details-section.visual-style-selector-section:not(.collapsed) > .header):
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider):
- 12:27 PM Changeset in webkit [196712] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Purge GraphicsServices font cache on memory warning.
<https://webkit.org/b/154343>
Reviewed by Antti Koivisto.
The GS font cache was holding on to the last retain on CSS fonts after they stop being used.
Call SPI to purge it on memory pressure.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):
- platform/spi/ios/GraphicsServicesSPI.h:
- 12:22 PM Changeset in webkit [196711] by
-
- 2 edits in trunk/Source
Revert accidentally committed ChangeLogs
- 12:19 PM Changeset in webkit [196710] by
-
- 3 edits18 adds in trunk/LayoutTests
Import W3C HTML reflection tests
https://bugs.webkit.org/show_bug.cgi?id=154310
<rdar://problem/24685826>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Import W3C HTML reflection tests from:
https://github.com/w3c/web-platform-tests/tree/master/html/dom
This improves our test coverage.
- web-platform-tests/html/dom/reflection-embedded-expected.txt: Added.
- web-platform-tests/html/dom/reflection-embedded.html: Added.
- web-platform-tests/html/dom/reflection-forms-expected.txt: Added.
- web-platform-tests/html/dom/reflection-forms.html: Added.
- web-platform-tests/html/dom/reflection-grouping-expected.txt: Added.
- web-platform-tests/html/dom/reflection-grouping.html: Added.
- web-platform-tests/html/dom/reflection-metadata-expected.txt: Added.
- web-platform-tests/html/dom/reflection-metadata.html: Added.
- web-platform-tests/html/dom/reflection-misc-expected.txt: Added.
- web-platform-tests/html/dom/reflection-misc.html: Added.
- web-platform-tests/html/dom/reflection-obsolete-expected.txt: Added.
- web-platform-tests/html/dom/reflection-obsolete.html: Added.
- web-platform-tests/html/dom/reflection-sections-expected.txt: Added.
- web-platform-tests/html/dom/reflection-sections.html: Added.
- web-platform-tests/html/dom/reflection-tabular-expected.txt: Added.
- web-platform-tests/html/dom/reflection-tabular.html: Added.
- web-platform-tests/html/dom/reflection-text-expected.txt: Added.
- web-platform-tests/html/dom/reflection-text.html: Added.
LayoutTests:
Skip newly imported tests in Debug builds because they are slow.
- 12:19 PM Changeset in webkit [196709] by
-
- 2 edits in trunk/Source
Modern IDB: More WK2 IPC Scaffolding.
https://bugs.webkit.org/show_bug.cgi?id=154317
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/shared/IDBCursorInfo.cpp:
(WebCore::IDBCursorInfo::IDBCursorInfo):
- Modules/indexeddb/shared/IDBCursorInfo.h:
(WebCore::IDBCursorInfo::decode):
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::decode):
- Modules/indexeddb/shared/IDBIndexInfo.h:
(WebCore::IDBIndexInfo::decode):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
(WebCore::IDBObjectStoreInfo::decode):
- Modules/indexeddb/shared/IDBRequestData.cpp:
(WebCore::IDBRequestData::IDBRequestData):
- Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::decode):
- Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
(WebCore::IDBResourceIdentifier::decode):
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
- Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::decode):
- Modules/indexeddb/shared/IDBTransactionInfo.cpp:
(WebCore::IDBTransactionInfo::IDBTransactionInfo):
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::decode):
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- CMakeLists.txt:
- DerivedSources.make:
- WebKit2.xcodeproj/project.pbxproj:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::deleteDatabase):
(WebKit::WebIDBConnectionToClient::openDatabase):
(WebKit::WebIDBConnectionToClient::abortTransaction):
(WebKit::WebIDBConnectionToClient::commitTransaction):
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToClient::createObjectStore):
(WebKit::WebIDBConnectionToClient::deleteObjectStore):
(WebKit::WebIDBConnectionToClient::clearObjectStore):
(WebKit::WebIDBConnectionToClient::createIndex):
(WebKit::WebIDBConnectionToClient::deleteIndex):
(WebKit::WebIDBConnectionToClient::putOrAdd):
(WebKit::WebIDBConnectionToClient::getRecord):
(WebKit::WebIDBConnectionToClient::getCount):
(WebKit::WebIDBConnectionToClient::deleteRecord):
(WebKit::WebIDBConnectionToClient::openCursor):
(WebKit::WebIDBConnectionToClient::iterateCursor):
(WebKit::WebIDBConnectionToClient::establishTransaction):
(WebKit::WebIDBConnectionToClient::databaseConnectionClosed):
(WebKit::WebIDBConnectionToClient::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToClient::didFireVersionChangeEvent):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in: Added.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::didDeleteDatabase):
(WebKit::WebIDBConnectionToServer::didOpenDatabase):
(WebKit::WebIDBConnectionToServer::didAbortTransaction):
(WebKit::WebIDBConnectionToServer::didCommitTransaction):
(WebKit::WebIDBConnectionToServer::didCreateObjectStore):
(WebKit::WebIDBConnectionToServer::didDeleteObjectStore):
(WebKit::WebIDBConnectionToServer::didClearObjectStore):
(WebKit::WebIDBConnectionToServer::didCreateIndex):
(WebKit::WebIDBConnectionToServer::didDeleteIndex):
(WebKit::WebIDBConnectionToServer::didPutOrAdd):
(WebKit::WebIDBConnectionToServer::didGetRecord):
(WebKit::WebIDBConnectionToServer::didGetCount):
(WebKit::WebIDBConnectionToServer::didDeleteRecord):
(WebKit::WebIDBConnectionToServer::didOpenCursor):
(WebKit::WebIDBConnectionToServer::didIterateCursor):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in: Added.
- 12:18 PM Changeset in webkit [196708] by
-
- 4 edits1 add in trunk/Websites/perf.webkit.org
v3 UI has the capability to schedule an A/B testing in a specific range
https://bugs.webkit.org/show_bug.cgi?id=154329
Reviewed by Chris Dumez.
Extended AnalysisTaskChartPane and ResultsTable so that users can select a range of points in either
the overview chart pane and the results viewer table. Extracted TestGroupForm out of the analysis task
page and used right below those two components in the analysis task page.
- public/v3/components/results-table.js:
(ResultsTable):
(ResultsTable.prototype.setRangeSelectorLabels): Added.
(ResultsTable.prototype.setRangeSelectorCallback): Added.
(ResultsTable.prototype.selectedRange): Added.
(ResultsTable.prototype._rangeSelectorClicked): Added.
(ResultsTable.prototype.render): Generate radio boxes to select a range.
- public/v3/components/test-group-form.js:
(TestGroupForm):
(TestGroupForm.prototype.setStartCallback): Added.
(TestGroupForm.prototype.setNeedsName): Added.
(TestGroupForm.prototype.setDisabled): Added.
(TestGroupForm.prototype.setLabel): Added.
(TestGroupForm.prototype.setRepetitionCount): Added.
(TestGroupForm.prototype._submitted): Added.
(TestGroupForm.htmlTemplate): Extracted from AnalysisTaskPage.htmlTemplate.
- public/v3/index.html:
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskChartPane.prototype._mainSelectionDidChange): Added. Delegates the work to AnalysisTaskPage.
(AnalysisTaskChartPane.prototype.selectedPoints): Added.
(AnalysisTaskPage):
(AnalysisTaskPage.prototype.title):
(AnalysisTaskPage.prototype.render):
(AnalysisTaskPage.prototype._renderTestGroupDetails): Use TestGroupForm's methods instead of mutating DOM.
(AnalysisTaskPage.prototype._retryCurrentTestGroup):
(AnalysisTaskPage.prototype._chartSelectionDidChange): Added.
(AnalysisTaskPage.prototype._createNewTestGroupFromChart): Added.
(AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer): Added.
(AnalysisTaskPage.prototype._createNewTestGroupFromViewer): Added.
(AnalysisTaskPage.prototype._createRetryNameForTestGroup):
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Extracted from _retryCurrentTestGroup
so that we can call it in _createNewTestGroupFromChart and _createNewTestGroupFromViewer.
(AnalysisTaskPage.htmlTemplate):
- 12:11 PM Changeset in webkit [196707] by
-
- 4 edits2 copies in trunk
Copy http body when being redirected with 308 with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154348
Reviewed by Brady Eidson.
Source/WebKit2:
This fixes http/tests/security/cors-post-redirect-308.html
which used to assert in ResourceRequest::doUpdateResourceHTTPBody
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::willPerformHTTPRedirection):
LayoutTests:
- http/tests/navigation/post-308-response-expected.txt: Copied from LayoutTests/http/tests/navigation/post-307-response-expected.txt.
- http/tests/navigation/post-308-response.html: Copied from LayoutTests/http/tests/navigation/post-307-response.html.
- http/tests/navigation/resources/redirection-response.php:
Added a test verifying data is being sent with post requests after being redirected with an http status code of 308.
We already had non-CORS tests for 301, 302, 303, and 307, and we already had CORS tests for 301, 302, 303, 307, and 308.
This fills in the missing non-CORS test.
- 11:31 AM Changeset in webkit [196706] by
-
- 8 edits2 adds in trunk
Regression(r196648): window.showModalDialog is no longer undefined if the client does not allow showing modal dialog
https://bugs.webkit.org/show_bug.cgi?id=154330
Reviewed by Gavin Barraclough.
Source/WebCore:
window.showModalDialog is no longer undefined if the client does not
allow showing modal dialog after r196648. This patch fixes the issue
and add test coverage for this.
Test: fast/dom/Window/forbid-showModalDialog.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- Move the DOMWindow::canShowModalDialog() check *before* checking for static properties as showModalDialog is now in the static property table after r196648.
- Add check for Base::getOwnPropertySlot() first to support overriding window.showModalDialog (This behavior matches Firefox).
- Return false if DOMWindow::canShowModalDialog() returns false as this seems cleaner than claiming that the property is there but undefined.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::canShowModalDialogNow): Deleted.
This was indentical to canShowModalDialog().
(WebCore::DOMWindow::canShowModalDialog):
(WebCore::DOMWindow::setCanShowModalDialogOverride):
(WebCore::DOMWindow::showModalDialog):
- page/DOMWindow.h:
- testing/Internals.cpp:
(WebCore::Internals::setCanShowModalDialogOverride):
- testing/Internals.h:
- testing/Internals.idl:
Add support for overriding the ChromeClient's canShowModalDialog
decision and hook it up to Internals to add layout test coverage.
LayoutTests:
Add layout test to make sure that window.showModalDialog is undefined
when the client does not allow showing modal dialog and to check that
window.showModalDialog can be shadowed.
- fast/dom/Window/forbid-showModalDialog-expected.txt: Added.
- fast/dom/Window/forbid-showModalDialog.html: Added.
- 11:21 AM Changeset in webkit [196705] by
-
- 23 edits2 adds in trunk/Source
Modern IDB: More WK2 IPC Scaffolding.
https://bugs.webkit.org/show_bug.cgi?id=154317
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/shared/IDBCursorInfo.cpp:
(WebCore::IDBCursorInfo::IDBCursorInfo):
- Modules/indexeddb/shared/IDBCursorInfo.h:
(WebCore::IDBCursorInfo::decode):
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::decode):
- Modules/indexeddb/shared/IDBIndexInfo.h:
(WebCore::IDBIndexInfo::decode):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
(WebCore::IDBObjectStoreInfo::decode):
- Modules/indexeddb/shared/IDBRequestData.cpp:
(WebCore::IDBRequestData::IDBRequestData):
- Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::decode):
- Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier):
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
(WebCore::IDBResourceIdentifier::decode):
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
- Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::decode):
- Modules/indexeddb/shared/IDBTransactionInfo.cpp:
(WebCore::IDBTransactionInfo::IDBTransactionInfo):
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::decode):
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- CMakeLists.txt:
- DerivedSources.make:
- WebKit2.xcodeproj/project.pbxproj:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::deleteDatabase):
(WebKit::WebIDBConnectionToClient::openDatabase):
(WebKit::WebIDBConnectionToClient::abortTransaction):
(WebKit::WebIDBConnectionToClient::commitTransaction):
(WebKit::WebIDBConnectionToClient::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToClient::createObjectStore):
(WebKit::WebIDBConnectionToClient::deleteObjectStore):
(WebKit::WebIDBConnectionToClient::clearObjectStore):
(WebKit::WebIDBConnectionToClient::createIndex):
(WebKit::WebIDBConnectionToClient::deleteIndex):
(WebKit::WebIDBConnectionToClient::putOrAdd):
(WebKit::WebIDBConnectionToClient::getRecord):
(WebKit::WebIDBConnectionToClient::getCount):
(WebKit::WebIDBConnectionToClient::deleteRecord):
(WebKit::WebIDBConnectionToClient::openCursor):
(WebKit::WebIDBConnectionToClient::iterateCursor):
(WebKit::WebIDBConnectionToClient::establishTransaction):
(WebKit::WebIDBConnectionToClient::databaseConnectionClosed):
(WebKit::WebIDBConnectionToClient::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToClient::didFireVersionChangeEvent):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in: Added.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::didDeleteDatabase):
(WebKit::WebIDBConnectionToServer::didOpenDatabase):
(WebKit::WebIDBConnectionToServer::didAbortTransaction):
(WebKit::WebIDBConnectionToServer::didCommitTransaction):
(WebKit::WebIDBConnectionToServer::didCreateObjectStore):
(WebKit::WebIDBConnectionToServer::didDeleteObjectStore):
(WebKit::WebIDBConnectionToServer::didClearObjectStore):
(WebKit::WebIDBConnectionToServer::didCreateIndex):
(WebKit::WebIDBConnectionToServer::didDeleteIndex):
(WebKit::WebIDBConnectionToServer::didPutOrAdd):
(WebKit::WebIDBConnectionToServer::didGetRecord):
(WebKit::WebIDBConnectionToServer::didGetCount):
(WebKit::WebIDBConnectionToServer::didDeleteRecord):
(WebKit::WebIDBConnectionToServer::didOpenCursor):
(WebKit::WebIDBConnectionToServer::didIterateCursor):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in: Added.
- 11:18 AM Changeset in webkit [196704] by
-
- 12 edits1 delete in trunk
Unreviewed, rolling out r196675.
https://bugs.webkit.org/show_bug.cgi?id=154344
"Causes major slowdowns on deltablue-varargs" (Requested by
keith_miller on #webkit).
Reverted changeset:
"Spread operator should be allowed when not the first argument
of parameter list"
https://bugs.webkit.org/show_bug.cgi?id=152721
http://trac.webkit.org/changeset/196675
- 11:17 AM Changeset in webkit [196703] by
-
- 2 edits in trunk/Source/WebCore
[Win] Allow ports to disable automatic text track selection
https://bugs.webkit.org/show_bug.cgi?id=154322
<rdar://problem/24623986>
Reviewed by Brent Fulgham.
- page/CaptionUserPreferencesMediaAF.cpp:
(MTEnableCaption2015BehaviorPtr): Implement for Windows.
- 11:04 AM Changeset in webkit [196702] by
-
- 4 edits in trunk/Source
JSDOMWindow::put should not do the same thing twice
https://bugs.webkit.org/show_bug.cgi?id=154334
Reviewed by Chris Dumez.
It either calls JSGlobalObject::put or Base::put. Hint: these are basically the same thing.
In the latter case it might call lookupPut. That's redundant; JSObject::put handles static
table entries.
Source/JavaScriptCore:
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::hasOwnPropertyForWrite): Deleted.
- no longer needed.
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::put):
- just call Base::put.
(WebCore::JSDOMWindow::putByIndex):
- just call Base::putByIndex.
- 11:03 AM Changeset in webkit [196701] by
-
- 2 edits in trunk/Source/WebKit2
CMake build fix after r196698.
- PlatformMac.cmake:
- 10:50 AM Changeset in webkit [196700] by
-
- 2 edits in trunk/Source/WebKit2
CMake build fix after r196698.
- CMakeLists.txt:
- 10:16 AM Changeset in webkit [196699] by
-
- 19 edits2 adds in trunk
AX: Implement sentence related text marker functions using TextIterator
https://bugs.webkit.org/show_bug.cgi?id=154312
Reviewed by Chris Fleizach.
Source/WebCore:
Using CharacterOffset to implement sentence related text marker calls. Reused
logic from VisibleUnits class. Also fixed an issue where paragraph navigation
should skip preceding and following BR nodes.
Test: accessibility/mac/text-marker-sentence-nav.html
- accessibility/AXObjectCache.cpp:
(WebCore::resetNodeAndOffsetForReplacedNode):
(WebCore::setRangeStartOrEndWithCharacterOffset):
(WebCore::AXObjectCache::characterOffsetForNodeAndOffset):
(WebCore::AXObjectCache::previousCharacterOffset):
(WebCore::AXObjectCache::startCharacterOffsetOfWord):
(WebCore::AXObjectCache::endCharacterOffsetOfWord):
(WebCore::AXObjectCache::previousWordStartCharacterOffset):
(WebCore::AXObjectCache::leftWordRange):
(WebCore::AXObjectCache::rightWordRange):
(WebCore::AXObjectCache::characterBefore):
(WebCore::characterOffsetNodeIsBR):
(WebCore::parentEditingBoundary):
(WebCore::AXObjectCache::nextBoundary):
(WebCore::AXObjectCache::previousBoundary):
(WebCore::AXObjectCache::paragraphForCharacterOffset):
(WebCore::AXObjectCache::nextParagraphEndCharacterOffset):
(WebCore::AXObjectCache::previousParagraphStartCharacterOffset):
(WebCore::AXObjectCache::startCharacterOffsetOfSentence):
(WebCore::AXObjectCache::endCharacterOffsetOfSentence):
(WebCore::AXObjectCache::sentenceForCharacterOffset):
(WebCore::AXObjectCache::nextSentenceEndCharacterOffset):
(WebCore::AXObjectCache::previousSentenceStartCharacterOffset):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::startWordBoundary): Deleted.
(WebCore::endWordBoundary): Deleted.
(WebCore::AXObjectCache::nextWordBoundary): Deleted.
(WebCore::AXObjectCache::previousWordBoundary): Deleted.
- accessibility/AXObjectCache.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- editing/VisibleUnits.cpp:
(WebCore::startWordBoundary):
(WebCore::startOfWord):
(WebCore::endWordBoundary):
(WebCore::startSentenceBoundary):
(WebCore::startOfSentence):
(WebCore::endSentenceBoundary):
- editing/VisibleUnits.h:
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(nextParagraphEndTextMarkerForTextMarkerCallback):
(sentenceTextMarkerRangeForTextMarkerCallback):
(previousSentenceStartTextMarkerForTextMarkerCallback):
(nextSentenceEndTextMarkerForTextMarkerCallback):
(setSelectedVisibleTextRangeCallback):
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
(WTR::_convertMathMultiscriptPairsToString):
LayoutTests:
- accessibility/mac/text-marker-paragraph-nav-expected.txt:
- accessibility/mac/text-marker-paragraph-nav.html:
- accessibility/mac/text-marker-sentence-nav-expected.txt: Added.
- accessibility/mac/text-marker-sentence-nav.html: Added.
- 10:15 AM Changeset in webkit [196698] by
-
- 9 edits8 deletes in trunk/Source/WebKit2
Remove unused media cache manager code
https://bugs.webkit.org/show_bug.cgi?id=154339
Reviewed by Tim Horton.
- DerivedSources.make:
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetMediaCacheManager): Deleted.
- UIProcess/API/C/WKContext.h:
- UIProcess/API/C/WKMediaCacheManager.cpp: Removed.
(WKMediaCacheManagerGetTypeID): Deleted.
(WKMediaCacheManagerGetHostnamesWithMediaCache): Deleted.
(WKMediaCacheManagerClearCacheForHostname): Deleted.
(WKMediaCacheManagerClearCacheForAllHostnames): Deleted.
- UIProcess/API/C/WKMediaCacheManager.h: Removed.
- UIProcess/WebMediaCacheManagerProxy.cpp: Removed.
(WebKit::WebMediaCacheManagerProxy::supplementName): Deleted.
(WebKit::WebMediaCacheManagerProxy::create): Deleted.
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy): Deleted.
(WebKit::WebMediaCacheManagerProxy::~WebMediaCacheManagerProxy): Deleted.
(WebKit::WebMediaCacheManagerProxy::processPoolDestroyed): Deleted.
(WebKit::WebMediaCacheManagerProxy::processDidClose): Deleted.
(WebKit::WebMediaCacheManagerProxy::shouldTerminate): Deleted.
(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement): Deleted.
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement): Deleted.
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache): Deleted.
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache): Deleted.
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname): Deleted.
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames): Deleted.
- UIProcess/WebMediaCacheManagerProxy.h: Removed.
- UIProcess/WebMediaCacheManagerProxy.messages.in: Removed.
- UIProcess/WebProcessPool.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/MediaCache/WebMediaCacheManager.cpp: Removed.
(WebKit::WebMediaCacheManager::supplementName): Deleted.
(WebKit::WebMediaCacheManager::WebMediaCacheManager): Deleted.
(WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): Deleted.
(WebKit::WebMediaCacheManager::clearCacheForHostname): Deleted.
(WebKit::WebMediaCacheManager::clearCacheForAllHostnames): Deleted.
- WebProcess/MediaCache/WebMediaCacheManager.h: Removed.
- WebProcess/MediaCache/WebMediaCacheManager.messages.in: Removed.
- WebProcess/WebProcess.cpp:
(WebKit::m_webSQLiteDatabaseTracker): Deleted.
- 9:46 AM Changeset in webkit [196697] by
-
- 1 edit2 adds in trunk/LayoutTests
Adding an ios-specific baseline for accessibility/ios-simulator/centerpoint.html during failure investigation
https://bugs.webkit.org/show_bug.cgi?id=154137
Unreviewed test gardening.
- platform/ios-simulator/accessibility/ios-simulator/centerpoint-expected.txt: Added.
- 9:32 AM Changeset in webkit [196696] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 9:25 AM Changeset in webkit [196695] by
-
- 2 edits in trunk/LayoutTests
Skipping tests added with r196688 on ios-simulator due to reliance on unsupported mouse events.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 9:22 AM WebKitIDL edited by
- Drop [EventTarget] (diff)
- 8:50 AM Changeset in webkit [196694] by
-
- 5 edits in trunk/Source
Versioning.
- 8:48 AM Changeset in webkit [196693] by
-
- 1 copy in tags/Safari-602.1.19
New tag.
- 8:01 AM Changeset in webkit [196692] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Add singular and plural cases for "Ignore n times before stopping" label in breakpoint editor
https://bugs.webkit.org/show_bug.cgi?id=154335
<rdar://problem/24655491>
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
Added string for singular ignore count.
- UserInterface/Controllers/BreakpointPopoverController.js:
(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Remove unused variable "this._ignoreCount" and update ignore count text.
(WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
Update ignore count text as value changes.
(WebInspector.BreakpointPopoverController.prototype._updateIgnoreCountText):
Set singular text when count === 1, otherwise set plural text.
- 3:45 AM Changeset in webkit [196691] by
-
- 8 edits in trunk/Source/WebCore
[css-grid] GridSpan refactoring
https://bugs.webkit.org/show_bug.cgi?id=153868
Reviewed by Sergio Villar Senin.
Add new enum to know if a GridSpan is definite or indefinite.
That way we don't need GridUnresolvedSpan class (which is removed).
We can always have two GridSpans in GridCoordinate,
if the position is "auto" the GridSpan will be marked as indefinite.
This will allow in a follow-up patch to avoid repeated calls
to methods that resolve positions.
Most operations in GridSpan are restricted to definite GridSpans (access
to positions, iterator, etc.). For indefinite GridSpans we only need to
know that they're indefinite, we shouldn't use the rest of the data.
No new tests, no change of behavior.
- css/CSSGridTemplateAreasValue.cpp:
(WebCore::stringForPosition):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::createImplicitNamedGridLinesFromGridArea):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForNonSpanningItems):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
(WebCore::RenderGrid::gridAreaBreadthForChildIncludingAlignmentOffsets):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid): Deleted.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Deleted.
(WebCore::RenderGrid::populateGridPositions): Deleted.
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::definiteGridSpan):
(WebCore::GridSpan::indefiniteGridSpan):
(WebCore::GridSpan::operator==):
(WebCore::GridSpan::integerSpan):
(WebCore::GridSpan::resolvedInitialPosition):
(WebCore::GridSpan::resolvedFinalPosition):
(WebCore::GridSpan::begin):
(WebCore::GridSpan::end):
(WebCore::GridSpan::isDefinite):
(WebCore::GridSpan::GridSpan):
(WebCore::GridCoordinate::GridCoordinate):
- rendering/style/GridResolvedPosition.cpp:
(WebCore::initialPositionSide):
(WebCore::finalPositionSide):
(WebCore::adjustGridPositionsFromStyle):
(WebCore::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveGridPositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle):
(WebCore::implicitNamedGridLineForSide): Deleted.
(WebCore::GridResolvedPosition::isNonExistentNamedLineOrArea): Deleted.
(WebCore::resolveNamedGridLinePositionFromStyle): Deleted.
(WebCore::resolveGridPositionFromStyle): Deleted.
- rendering/style/GridResolvedPosition.h:
(WebCore::GridResolvedPosition::GridResolvedPosition): Deleted.
(WebCore::GridResolvedPosition::operator*): Deleted.
(WebCore::GridResolvedPosition::operator++): Deleted.
(WebCore::GridResolvedPosition::operator==): Deleted.
- 12:38 AM Changeset in webkit [196690] by
-
- 10 edits in trunk
Window should have its 'constructor' property on the prototype
https://bugs.webkit.org/show_bug.cgi?id=154037
<rdar://problem/24689078>
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Window should have its 'constructor' property on the prototype as per
the Web IDL specification:
http://heycam.github.io/webidl/#interface-prototype-object
Firefox and Chrome already match the specification.
No new tests, covered by:
- fast/dom/Window/window-constructor-settable.html
- fast/dom/Window/window-constructor.html
- http/tests/security/cross-origin-window-property-access.html
- imported/w3c/web-platform-tests/html/dom/interfaces.html
- bindings/scripts/CodeGeneratorJS.pm:
(ConstructorShouldBeOnInstance): Deleted.
Drop this routine as all constructors are now on the prototype.
(InstancePropertyCount):
Do not account for constructor properties as these can only be
on the prototype now.
(PrototypePropertyCount):
Increment the property count by 1 if the interface has a constructor
property (e.g. [NoInterfaceObject] interfaces do not have one).
(GeneratePropertiesHashTable):
Stop calling ConstructorShouldBeOnInstance() as it no longer exists.
Always generated the "constructor" property if:
- We are generating the prototype hash table.
and
- The interface needs a constructor (i.e. not marked as [NoInterfaceObject]).
(GenerateImplementation):
- Drop code handling the case where ConstructorShouldBeOnInstance() returns true as constructors are not always on the prototype and the ConstructorShouldBeOnInstance() routine has been dropped.
- Drop code handling [CustomProxyToJSObject]. Now that the constructor is always on the prototype, we never need to cast thisValue to a JSDOMWindow (by calling toJSDOMWindow). In the Window case, thisValue is now casted to a JSDOMWindowPrototype*, similarly to other interfaces so we don't need a special casting function anymore.
- Stop generating security checks. This only impacts Window as it is the
only interface marked as [CheckSecurity]. The cross-origin checking code
as it was would not work when "constructor" is on the prototype because
thisValue is a JSDOMWindowPrototype, not a JSDOMWindow and we have no
way of getting the wrapped window. Also, the security check is no longer
needed because:
- Accessing crossOriginWindow.constructor will not work now that constructor is on the prototype because JSDOMWindow::getOwnPropertySlot() already prevents access to the prototype in the cross-origin case.
- "constructor" is a value property, not a getter/setter. Therefore, it is no possible to use the getter/setter from a same origin window instance and call it on a cross origin window.
LayoutTests:
- http/tests/security/cross-origin-window-property-access-expected.txt:
- http/tests/security/cross-origin-window-property-access.html:
Add checks to make sure it still is not possible to access
window.constructor cross-origin.
- js/getOwnPropertyDescriptor-window-attributes-expected.txt:
- js/getOwnPropertyDescriptor-window-attributes.html:
Update test now that window has it's "constructor" attribute
on the prototype.
Feb 16, 2016:
- 11:40 PM WebKitGTK/2.10.x edited by
- (diff)
- 11:18 PM Changeset in webkit [196689] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r196620): Web Inspector: Selecting last message in the console makes the scrollbar visible
https://bugs.webkit.org/show_bug.cgi?id=154326
<rdar://problem/24692717>
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.console-item.selected::after):
Make sure the selected message marker (blue vertical line) doesn't
go over the content view.
- 11:16 PM Changeset in webkit [196688] by
-
- 22 edits13 adds in trunk
Add a way to test ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=153479
Reviewed by Michael Catanzaro.
Source/WebCore:
Tests: fast/scrolling/overlay-scrollbars-scroll-corner.html
fast/scrolling/scroll-animator-basic-events.html
fast/scrolling/scroll-animator-overlay-scrollbars-hovered.html
fast/scrolling/scroll-animator-select-list-events.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- page/FrameView.cpp:
(WebCore::FrameView::usesMockScrollAnimator):
(WebCore::FrameView::logMockScrollAnimatorMessage):
- page/FrameView.h:
- page/Settings.cpp:
(WebCore::Settings::setUsesMockScrollAnimator):
(WebCore::Settings::usesMockScrollAnimator):
- page/Settings.h:
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollAnimator):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::usesMockScrollAnimator):
(WebCore::ScrollableArea::logMockScrollAnimatorMessage):
- platform/mock/ScrollAnimatorMock.cpp: Added.
(WebCore::ScrollAnimatorMock::create):
(WebCore::ScrollAnimatorMock::ScrollAnimatorMock):
(WebCore::ScrollAnimatorMock::~ScrollAnimatorMock):
(WebCore::ScrollAnimatorMock::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMock::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMock::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMock::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMock::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMock::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMock::mouseExitedContentArea):
(WebCore::ScrollAnimatorMock::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMock::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMock::mouseIsDownInScrollbar):
- platform/mock/ScrollAnimatorMock.h: Added.
- platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::usesOverlayScrollbars):
- platform/mock/ScrollbarThemeMock.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::usesMockScrollAnimator):
(WebCore::RenderLayer::logMockScrollAnimatorMessage):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::usesMockScrollAnimator):
(WebCore::RenderListBox::logMockScrollAnimatorMessage):
- rendering/RenderListBox.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setUsesMockScrollAnimator):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- compositing/overflow/overflow-scrollbar-layer-positions-expected.txt:
- fast/scrolling/overlay-scrollbars-scroll-corner-expected.html: Added.
- fast/scrolling/overlay-scrollbars-scroll-corner.html: Added.
- fast/scrolling/scroll-animator-basic-events-expected.txt: Added.
- fast/scrolling/scroll-animator-basic-events.html: Added.
- fast/scrolling/scroll-animator-overlay-scrollbars-hovered-expected.txt: Added.
- fast/scrolling/scroll-animator-overlay-scrollbars-hovered.html: Added.
- fast/scrolling/scroll-animator-select-list-events-expected.txt: Added.
- fast/scrolling/scroll-animator-select-list-events.html: Added.
- fast/scrolling/scrollbar-tickmarks-hittest.html:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/fast/scrolling/scroll-animator-basic-events-expected.txt: Added.
- platform/mac-wk1/fast/scrolling/scroll-animator-select-list-events-expected.txt: Added.
- 10:54 PM Changeset in webkit [196687] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Enable overlay scrollbars in GTK+ after r196641.
This was blocked by bug #153404, but the commit that introduced
the regression was rolled out in r196641.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
- 10:13 PM Changeset in webkit [196686] by
-
- 6 edits in trunk/Source
FTL_USES_B3 should be unconditionally true
https://bugs.webkit.org/show_bug.cgi?id=154324
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- dfg/DFGCommon.h:
Source/WTF:
- wtf/Platform.h:
- 9:29 PM Changeset in webkit [196685] by
-
- 3 edits3 adds in trunk/Source/JavaScriptCore
FTL should support CompareEq(String:, String:)
https://bugs.webkit.org/show_bug.cgi?id=154269
rdar://problem/24499921
Reviewed by Benjamin Poulain.
Looks like a slight pdfjs slow-down, probably because we're having some recompilations. I
think we should land the increased coverage first and fix the issues after, especially since
the regression is so small and doesn't have a statistically significant effect on the overall
score.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToLLVM::nonSpeculativeCompare):
(JSC::FTL::DFG::LowerDFGToLLVM::stringsEqual):
- tests/stress/ftl-string-equality.js: Added.
- tests/stress/ftl-string-ident-equality.js: Added.
- tests/stress/ftl-string-strict-equality.js: Added.
- 8:25 PM Changeset in webkit [196684] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should support NewTypedArray
https://bugs.webkit.org/show_bug.cgi?id=154268
Reviewed by Saam Barati.
3% speed-up on pdfjs. This was already covered by many different tests.
Rolling this back in after fixing the butterfly argument.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToLLVM::compileAllocatePropertyStorage):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateBasicStorage):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateObject):
- 8:11 PM Changeset in webkit [196683] by
-
- 1 copy in tags/Safari-601.1.46.101
New tag.
- 8:04 PM Changeset in webkit [196682] by
-
- 10 edits in tags/Safari-601.1.46.100.1
Merge patch for r192036 and r196679. rdar://problem/24355523
- 8:03 PM Changeset in webkit [196681] by
-
- 5 edits in tags/Safari-601.1.46.100.1/Source
Versioning.
- 7:58 PM Changeset in webkit [196680] by
-
- 10 edits in branches/safari-601.1.46-branch
Merge patch for r192036 and r196679. rdar://problem/24355523
- 7:27 PM Changeset in webkit [196679] by
-
- 4 edits in trunk/Source/WebKit2
Allow double tap to zoom in fast-click pages
https://bugs.webkit.org/show_bug.cgi?id=154318
<rdar://problem/24223767>
Reviewed by Simon Fraser and Benjamin Poulain.
Most of the patch comes from Jon Lee.
Our fast-click algorithm exposed a number of cases where
people missed the double-tap-to-zoom behaviour. In particular,
when you double tap on a large body of text, typical in
blogs and articles.
This patch enhances the algorithm to have a parallel
double-tap gesture recognizer in the situations where
fast-click is enabled. This new gesture recongizer does
not cause the single tap to block for 350ms, so clicks
are still dispatched fast. If it fires, we already have
some information about whether we have a pending double
tap, based on the first tap.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::disableDoubleTapGesturesDuringTapIfNecessary): Remove the optimization
that only told the content view to disable on pages that allowed double taps. We now allow
them even on fast click pages.
- UIProcess/ios/WKContentViewInteraction.h: Add the new UITapGestureRecognizer for double taps
in fast click pages. This is called nonBlockingDoubleTapGestureRecognizer because, unlike
the existing DoubleTapGestureRecognizer, this one does not force the singleTapRecognizer
to wait.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]): Set up the new UITapGestureRecognizer.
(-[WKContentView cleanupInteraction]): And remove it when we're done.
(-[WKContentView _removeDefaultGestureRecognizers]): Ditto.
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView _inspectorNodeSearchRecognized:]): Something happened, we are no longer in
a potential double tap situation.
(-[WKContentView _disableDoubleTapGesturesDuringTapIfNecessary:]): Remove the check
for potential tap in progress.
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _highlightLongPressRecognized:]): Again, something happened, so we are
no longer in a double tap situation.
(-[WKContentView _longPressRecognized:]): Ditto.
(-[WKContentView _singleTapRecognized:]): Ditto.
(-[WKContentView _doubleTapRecognized:]): Ditto.
(-[WKContentView _resetIsDoubleTapPending]):
(-[WKContentView _fastDoubleTapRecognized:]): We're now pending a double tap.
(-[WKContentView _twoFingerDoubleTapRecognized:]):
(-[WKContentView _didNotHandleTapAsClick:]): If we get here and we have a pending
double tap, then trigger a zoom operation.
(-[WKContentView _setDoubleTapGesturesEnabled:]):
- 6:34 PM Changeset in webkit [196678] by
-
- 4 edits in trunk/Source
JSDOMWindow::getOwnPropertySlot should just call getStaticPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=154257
Patch by Gavin Barraclough <barraclough@apple.com> on 2016-02-16
Reviewed by Chris Dumez.
Source/JavaScriptCore:
- runtime/Lookup.h:
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):
- this could all do with a little more love. But enforce the basic precedence:
(1) regular storage properties always win over static table properties.
(2) if properties have been reified, don't consult the static tables.
(3) only if the property is not present on the object & not reified
should the static hashtable be consulted.
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- JSDOMWindow::getOwnPropertySlot should just call getStaticPropertySlot
- 6:20 PM Changeset in webkit [196677] by
-
- 1 copy in tags/Safari-601.1.46.100.1
New tag.
- 5:37 PM Changeset in webkit [196676] by
-
- 8 edits in trunk
JSDOMWindow::getOwnPropertySlot should not search photo chain
https://bugs.webkit.org/show_bug.cgi?id=154102
Reviewed by Chris Dumez.
Should only return *own* properties.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
- remove hack/special-case for DOMWindow; we no longer need this.
Source/WebCore:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotNamedItemGetter):
LayoutTests:
- fast/dom/Window/es52-globals-expected.txt:
- http/tests/security/window-named-valueOf-expected.txt:
- imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- update test results.
- 5:29 PM Changeset in webkit [196675] by
-
- 12 edits1 add in trunk
Spread operator should be allowed when not the first argument of parameter list
https://bugs.webkit.org/show_bug.cgi?id=152721
Reviewed by Saam Barati.
Source/JavaScriptCore:
Spread arguments to functions should now be ES6 compliant. Before we
would only take a spread operator if it was the sole argument to a
function. Additionally, we would not use the Symbol.iterator on the
object to generate the arguments. Instead we would do a loop up to the
length mapping indexed properties to the corresponding argument. We fix
both these issues by doing an AST transformation from foo(...a, b, ...c, d)
to foo(...[...a, b, ...c, d]) (where the spread on the rhs uses the
old spread semantics). This solution has the downside of requiring the
allocation of another object and copying each element twice but avoids a
large change to the vm calling convention.
- interpreter/Interpreter.cpp:
(JSC::loadVarargs):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createElementList):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseArguments):
(JSC::Parser<LexerType>::parseArgument):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/Parser.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createElementList):
- tests/es6.yaml:
- tests/stress/spread-calling.js: Added.
(testFunction):
(testEmpty):
(makeObject):
(otherIterator.return.next):
(otherIterator):
(totalIter):
(throwingIter.return.next):
(throwingIter):
(i.catch):
LayoutTests:
Update tests with new semantics of spread calling.
- js/basic-spread-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js:
- js/script-tests/parser-syntax-check.js:
- 5:14 PM Changeset in webkit [196674] by
-
- 4 edits in trunk/Source
CMake build fix.
- PlatformMac.cmake:
- 5:11 PM Changeset in webkit [196673] by
-
- 10 edits2 adds3 deletes in trunk
Navigator.geolocation should not be marked a [Replaceable] and should be on the prototype
https://bugs.webkit.org/show_bug.cgi?id=154304
<rdar://problem/24685092>
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
- Drop the [Replaceable] IDL extended attribute for navigator.geolocation as this does not match other browsers or the specification:
- Move Navigator attributes to the prototype, where they should be as per the Web IDL specification.
The previous behavior was meant as a workaround for a bug in the Amazon
iOS app (rdar://problem/16332749). However, I have confirmed that the
latest Amazon App no longer has any issue with those changes.
Test: js/navigator-set-geolocation.html
- Modules/geolocation/NavigatorGeolocation.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstanceForCompatibility): Deleted.
LayoutTests:
- fast/dom/Geolocation/enabled-expected.txt:
- fast/dom/Geolocation/script-tests/enabled.js:
- js/dom/delete-syntax-expected.txt:
- js/dom/script-tests/delete-syntax.js:
Update tests as they expected the navigator properties to be on the
instance rather than the prototype.
- js/dom/script-tests/shadow-navigator-geolocation-in-strict-mode-does-not-throw.js: Removed.
- js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw-expected.txt: Removed.
- js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw.html: Removed.
Drop outdated test.
- js/navigator-set-geolocation-expected.txt: Added.
- js/navigator-set-geolocation.html: Added.
Add test to make sure that Navigator.geolocation cannot be set. I verified that
this test passes in both Firefox and Chrome.
- 4:45 PM Changeset in webkit [196672] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Enable B3 on ARM64
https://bugs.webkit.org/show_bug.cgi?id=154275
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-16
Reviewed by Mark Lam.
The port passes more tests than LLVM now, let's use it by default.
- dfg/DFGCommon.h:
- 4:30 PM Changeset in webkit [196671] by
-
- 4 edits in trunk/Source/WebKit2
Use NSURLCredential from serverTrust when evaluating server trust AuthenticationChallenges with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154316
Reviewed by Brady Eidson.
This fixes http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
and many other layout tests that use https because it allows https connections with servers
with self-signed certificates when TestController::canAuthenticateAgainstProtectionSpace in
WebKitTestRunner says it's OK, or when any other WKPageNavigationClient says it's ok.
- NetworkProcess/NetworkDataTask.h:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::serverTrustCredential):
- 4:00 PM Changeset in webkit [196670] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r196268): WTFCrashWithSecurityImplication on SVG path animation tests
https://bugs.webkit.org/show_bug.cgi?id=154221
Reviewed by Brent Fulgham.
In r196268, a destructor was added to SVGListPropertyTearOff that notifies
its wrapper (the SVGAnimatedListPropertyTearoff) about its deletion. This
allows the wrapper to nullify any references to the wrapped content.
We needed to do the same thing for SVGPathSegListPropertyTearOff. Both
SVGPathSegListPropertyTearOff and SVGListPropertyTearOff inherit from
SVGListProperty and both hold pointers to SVGAnimatedListPropertyTearOff
which needs to be notified.
Tests: exiting svg path animation tests should not crash.
- svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::~SVGPathSegListPropertyTearOff):
- 3:59 PM Changeset in webkit [196669] by
-
- 4 edits2 adds in trunk
REGRESSION (r190430): WTFCrashWithSecurityImplication in:void SVGRootInlineBox::layoutCharactersInTextBoxes()
https://bugs.webkit.org/show_bug.cgi?id=154185
Reviewed by Ryosuke Niwa.
Source/WebCore:
This is a regression caused by adding support for HTMLSlotElement. The
crash happens when adding an HTMLSlotElement to anther element which should
not have it as a child like SVGTextElement for example. In this case, we
were creating a RenderText which should not be happen inside an SVG document.
The RenderText::createTextBox() was creating InlineTextBox for the slot's
text and attach it to the SVGRootInlineBox. In layoutCharactersInTextBoxes(),
the assumption is the inline box is either SVGInlineTextBox or SVGInlineFlowBox.
But since we have an InlineTextBox instead, the crash happens when casting
the InlineTextBox to SVGInlineFlowBox.
The fix is for createRenderTreeForSlotAssignees() to not create a renderer
when the parent element should not have a renderer for the this element.
This is the same thing we do for createRenderer() which handles the non
HTMLSlotElement case and which is called also from createRenderTreeRecursively().
Test: fast/shadow-dom/text-slot-child-crash.svg
- style/StyleTreeResolver.cpp:
(WebCore::Style::moveToFlowThreadIfNeeded):
(WebCore::Style::TreeResolver::createRenderer): Delete the check for
shouldCreateRenderer() and handling the case when resolvedStyle is null
since these are handled by the caller createRenderTreeRecursively().
(WebCore::Style::TreeResolver::createRenderTreeForSlotAssignees):
Assert shouldCreateRenderer() is true for this element.
(WebCore::Style::TreeResolver::createRenderTreeRecursively): Don't create
the renderer if shouldCreateRenderer() returns false. Also handle the case
when resolvedStyle is null and pass the new style to createRenderer().
- style/StyleTreeResolver.h:
LayoutTests:
Ensure that adding an HTMLSlotElement with text to an SVGTextElement will
not create a renderer and we won't crash.
- fast/shadow-dom/text-slot-child-crash-expected.txt: Added.
- fast/shadow-dom/text-slot-child-crash.svg: Added.
- 3:47 PM Changeset in webkit [196668] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r196652.
https://bugs.webkit.org/show_bug.cgi?id=154315
This change caused LayoutTest crashes (Requested by ryanhaddad
on #webkit).
Reverted changeset:
"FTL should support NewTypedArray"
https://bugs.webkit.org/show_bug.cgi?id=154268
http://trac.webkit.org/changeset/196652
- 3:45 PM Changeset in webkit [196667] by
-
- 4 edits in trunk/Source/JavaScriptCore
RemoteInspector should forward new automation session requests to its client
https://bugs.webkit.org/show_bug.cgi?id=154260
<rdar://problem/24663313>
Reviewed by Timothy Hatcher.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::listingForAutomationTarget):
Use the correct key for the session identifier in the listing. The name()
override for RemoteAutomationTarget is actually the session identifier.
(Inspector::RemoteInspector::receivedAutomationSessionRequestMessage):
- inspector/remote/RemoteInspectorConstants.h: Add new constants.
- 3:24 PM Changeset in webkit [196666] by
-
- 3 edits in trunk/Source/WebCore
Every RenderLayer should not have to remove itself from the scrollableArea set
https://bugs.webkit.org/show_bug.cgi?id=154311
Reviewed by Zalan Bujtas.
A subset of RenderLayers are are scrollable, and get registered on the FrameView,
but we pay the cost of a hash lookup for removal on every RenderLayer, which is a waste.
Store a bit that tells RenderLayer that it's in the set and needs to be removed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- 3:24 PM Changeset in webkit [196665] by
-
- 3 edits5 adds in trunk/LayoutTests
Add tests for iframe and overflow scrollability after navigating back
https://bugs.webkit.org/show_bug.cgi?id=154300
Reviewed by Brent Fulgham.
Test that sends mousewheel events to overflow and iframe, before and after navigating
forward then back.
These tests detect the regression caused by r188659.
- fast/scrolling/iframe-scrollable-after-back-expected.txt: Added.
- fast/scrolling/iframe-scrollable-after-back.html: Added.
- fast/scrolling/overflow-scrollable-after-back-expected.txt: Added.
- fast/scrolling/overflow-scrollable-after-back.html: Added.
- fast/scrolling/resources/scroll-notifying-page.html: Added.
- platform/ios-simulator/TestExpectations: Skip on iOS.
- 3:22 PM Changeset in webkit [196664] by
-
- 12 edits in trunk
CSP: Update violation report 'Content-Type' header
https://bugs.webkit.org/show_bug.cgi?id=153166
<rdar://problem/24383327>
Reviewed by Brent Fulgham.
Source/WebCore:
Inspired by Blink patch:
<https://src.chromium.org/viewvc/blink?view=rev&revision=154215>
Post the Content Security Policy violation report with Content-Type application/csp-report as
per section Reporting of the Content Security Policy 2.0 spec., <https://www.w3.org/TR/2015/CR-CSP2-20150721/>.
Currently we post CSP violation reports with Content-Type application/json.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript): Use report type ViolationReportType::XSSAuditor to PingLoader.
- loader/PingLoader.cpp:
(WebCore::PingLoader::sendViolationReport): Modified to take argument of type ViolationReportType
to determine the appropriate Content-Type header to use for the report. For a XSS Auditor violation report
we use Content-Type application/json. For a Content Security Policy violation report we use Content-Type
application/csp-report. Additionally, pass a ASCIILiteral() to ResourceRequestBase::setHTTPMethod()
as opposed to a constant string literal to avoid a copy of a constant string literal.
- loader/PingLoader.h: Add enum class ViolationReportType.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation): Use report type ViolationReportType::ContentSecurityPolicy.
LayoutTests:
Update expected results now that we post the Content Security Policy violation report with
Content-Type application/csp-report.
- TestExpectations: Update associated bugs for entries that still fail.
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Fix up HTTP_REFERER and csp-report
to reflect the correct value for HTTP_REFERER and the correct values for the report-uri and document-uri keys in the CSP
report JSON object.
- 3:16 PM Changeset in webkit [196663] by
-
- 6 edits1 add in trunk/Websites/perf.webkit.org
Extract the code specific to v2 UI out of shared statistics.js
https://bugs.webkit.org/show_bug.cgi?id=154277
Reviewed by Chris Dumez.
Extracted statistics-strategies.js out of statistics.js for v2 UI and detect-changes.js. The intent is to
deprecate this file once we implement refined statistics tools in v3 UI and adopt it in detect-changes.js.
- public/shared/statistics.js:
(Statistics.movingAverage): Extracted from the "Simple Moving Average" strategy.
(Statistics.cumultaiveMovingAverage): Extracted from the "Cumulative Moving Average" strategy.
(Statistics.exponentialMovingAverage): Extracted from the "Exponential Moving Average" strategy.
Use a temporary "movingAverage" to keep the last moving average instead of relying on the previous
entry in "averages" array to avoid special casing an array of length 1 and starting the loop at i = 1.
(Statistics.segmentTimeSeriesGreedyWithStudentsTTest): Extracted from "Segmentation: Recursive t-test"
strategy. Don't create the list of averages to match segmentTimeSeriesByMaximizingSchwarzCriterion here.
It's done in newly added averagesFromSegments.
(Statistics.segmentTimeSeriesByMaximizingSchwarzCriterion): Extracted from
"Segmentation: Schwarz criterion" strategy.
(.recursivelySplitIntoTwoSegmentsAtMaxTIfSignificantlyDifferent): Just store the start index to match
- public/v2/app.js:
(App.Pane.updateStatisticsTools):
(App.Pane._computeMovingAverageAndOutliers):
- public/v2/data.js:
- public/v2/index.html:
- public/v2/statistics-strategies.js: Added.
(StatisticsStrategies.MovingAverageStrategies): Added.
(averagesFromSegments): Extracted from "Segmentation: Schwarz criterion" strategy. Now used by both
"Segmentation: Recursive t-test" and "Segmentation: Schwarz criterion" strategies.
(StatisticsStrategies.EnvelopingStrategies): Moved from Statistics.EnvelopingStrategies.
(StatisticsStrategies.TestRangeSelectionStrategies): Moved from Statistics.TestRangeSelectionStrategies.
(createWesternElectricRule): Moved from statistics.js.
(countValuesOnSameSide): Ditto.
(StatisticsStrategies.executeStrategy): Moved from Statistics.executeStrategy.
- tools/detect-changes.js:
(computeRangesForTesting):
- 3:13 PM Changeset in webkit [196662] by
-
- 2 edits in trunk/LayoutTests
Marking pageoverlay/overlay-installation.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153337
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 2:57 PM Changeset in webkit [196661] by
-
- 13 edits1 delete in trunk/Source/WebKit2
Use pid_t everywhere, instead of PlatformProcessIdentifier
https://bugs.webkit.org/show_bug.cgi?id=154306
Reviewed by Sam Weinig.
- Platform/IPC/Connection.h:
- Platform/PlatformProcessIdentifier.h: Removed.
- UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
- UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::processIdentifier):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::didFinishLaunchingProcess):
- UIProcess/Launcher/ProcessLauncher.h:
(WebKit::ProcessLauncher::processIdentifier):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processIdentifier):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::networkProcessIdentifier):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- 2:54 PM Changeset in webkit [196660] by
-
- 2 edits2 deletes in trunk/Source/WebKit2
Remove WebKit2 header cruft
https://bugs.webkit.org/show_bug.cgi?id=154309
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- mac/WKError.h: Removed.
- mac/WKPreferences.h: Removed.
- 2:43 PM Changeset in webkit [196659] by
-
- 3 edits4 deletes in trunk/Source/WebKit2
Remove unused environment variable classes
https://bugs.webkit.org/show_bug.cgi?id=154308
Reviewed by Tim Horton.
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h: Removed.
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm: Removed.
(WebKit::DynamicLinkerEnvironmentExtractor::DynamicLinkerEnvironmentExtractor): Deleted.
(WebKit::DynamicLinkerEnvironmentExtractor::processEnvironmentVariable): Deleted.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommand): Deleted.
(WebKit::DynamicLinkerEnvironmentExtractor::processLoadCommands): Deleted.
(WebKit::DynamicLinkerEnvironmentExtractor::processSingleArchitecture): Deleted.
(WebKit::DynamicLinkerEnvironmentExtractor::processFatFile): Deleted.
(WebKit::DynamicLinkerEnvironmentExtractor::getExtractedEnvironmentVariables): Deleted.
- UIProcess/Launcher/mac/EnvironmentVariables.cpp: Removed.
(WebKit::EnvironmentVariables::EnvironmentVariables): Deleted.
(WebKit::EnvironmentVariables::~EnvironmentVariables): Deleted.
(WebKit::EnvironmentVariables::set): Deleted.
(WebKit::EnvironmentVariables::get): Deleted.
(WebKit::EnvironmentVariables::appendValue): Deleted.
(WebKit::EnvironmentVariables::valueIfVariableHasName): Deleted.
(WebKit::EnvironmentVariables::createStringForVariable): Deleted.
(WebKit::EnvironmentVariables::copyEnvironmentVariables): Deleted.
(WebKit::EnvironmentVariables::dump): Deleted.
- UIProcess/Launcher/mac/EnvironmentVariables.h: Removed.
(WebKit::EnvironmentVariables::environmentPointer): Deleted.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- WebKit2.xcodeproj/project.pbxproj:
- 2:01 PM Changeset in webkit [196658] by
-
- 6 edits in trunk/Source/JavaScriptCore
SamplingProfiler still fails with ASan enabled
https://bugs.webkit.org/show_bug.cgi?id=154301
<rdar://problem/24679502>
Reviewed by Filip Pizlo.
To fix this issue, I've come up with unsafe versions
of all operations that load memory from the thread's call
frame. All these new unsafe methods are marked with SUPPRESS_ASAN.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::callSiteAsRawBits):
(JSC::CallFrame::unsafeCallSiteAsRawBits):
(JSC::CallFrame::callSiteIndex):
(JSC::CallFrame::unsafeCallSiteIndex):
(JSC::CallFrame::stack):
(JSC::CallFrame::callerFrame):
(JSC::CallFrame::unsafeCallerFrame):
(JSC::CallFrame::friendlyFunctionName):
- interpreter/CallFrame.h:
(JSC::ExecState::calleeAsValue):
(JSC::ExecState::callee):
(JSC::ExecState::unsafeCallee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::unsafeCodeBlock):
(JSC::ExecState::scope):
(JSC::ExecState::callerFrame):
(JSC::ExecState::callerFrameOrVMEntryFrame):
(JSC::ExecState::unsafeCallerFrameOrVMEntryFrame):
(JSC::ExecState::callerFrameOffset):
(JSC::ExecState::callerFrameAndPC):
(JSC::ExecState::unsafeCallerFrameAndPC):
- interpreter/Register.h:
(JSC::Register::codeBlock):
(JSC::Register::asanUnsafeCodeBlock):
(JSC::Register::unboxedInt32):
(JSC::Register::tag):
(JSC::Register::unsafeTag):
(JSC::Register::payload):
- interpreter/VMEntryRecord.h:
(JSC::VMEntryRecord::prevTopCallFrame):
(JSC::VMEntryRecord::unsafePrevTopCallFrame):
(JSC::VMEntryRecord::prevTopVMEntryFrame):
(JSC::VMEntryRecord::unsafePrevTopVMEntryFrame):
- runtime/SamplingProfiler.cpp:
(JSC::FrameWalker::walk):
(JSC::FrameWalker::advanceToParentFrame):
(JSC::FrameWalker::isAtTop):
(JSC::FrameWalker::resetAtMachineFrame):
- 1:42 PM Changeset in webkit [196657] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196648
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 1:25 PM Changeset in webkit [196656] by
-
- 7 edits in trunk/Source
Add checks before redirecting with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154298
Reviewed by Andy Estes.
Source/WebCore:
This fixes http/tests/security/cors-post-redirect-307.html and
http/tests/navigation/post-307-response.html when using NetworkSession.
- platform/network/ResourceRequestBase.h:
WEBCORE_EXPORT some functions newly used in WebKit2.
Source/WebKit2:
- NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::create):
(WebKit::NetworkDataTask::setPendingDownload):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::~NetworkDataTask):
(WebKit::NetworkDataTask::willPerformHTTPRedirection):
Implemented based on ResourceHandle::willSendRequest but with two notable exceptions:
- When using NSURLConnection, the last http method and the current http method are not always equal, and this
check needs to change the current http method to match the last http method when being redirected with an http
status code 307. When using NSURLSession, the current http method is already updated properly.
- I did not copy the part of ResourceHandle::willSendRequest that uses a CredentialStorage. I'm trying to avoid
using CredentialStorages with NSURLSession.
(WebKit::NetworkDataTask::scheduleFailure):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
- 1:18 PM Changeset in webkit [196655] by
-
- 4 edits in trunk
CSP: Fix parsing of 'host/path' source expressions
https://bugs.webkit.org/show_bug.cgi?id=153170
<rdar://problem/24383407>
Reviewed by Brent Fulgham.
Source/WebCore:
Merged from Blink (patch by Mike West):
<https://src.chromium.org/viewvc/blink?revision=154875&view=revision>
Fixes an issue where a source of the form example.com/A/ was incorrectly considered
invalid and hence such a requested resource would be blocked. A source of this form
is valid by the definition of host-source in section Source List Syntax of the Content
Security Policy 2.0 spec., <http://www.w3.org/TR/2015/CR-CSP2-20150721/>.
- page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::ContentSecurityPolicySourceList::parseSource):
LayoutTests:
Remove entry for test http/tests/security/contentSecurityPolicy/source-list-parsing-paths-03.html
as it now passes.
- 1:17 PM Changeset in webkit [196654] by
-
- 7 edits2 adds in trunk
JSContext Inspector: Support for inline source maps
https://bugs.webkit.org/show_bug.cgi?id=154303
<rdar://problem/24670392>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-16
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Base/URLUtilities.js:
(parseDataURL):
Break a data URL into components.
- UserInterface/Controllers/SourceMapManager.js:
(WebInspector.SourceMapManager.prototype._loadAndParseSourceMap):
Handle a data URL without using NetworkAgent. Also move references
to a main frame after checking for NetworkAgent.
- UserInterface/Models/SourceMap.js:
(WebInspector.SourceMap.prototype.get sourceMappingBasePathURLComponents):
- UserInterface/Models/SourceMapResource.js:
(WebInspector.SourceMapResource.prototype.get sourceMapDisplaySubpath):
Handle JavaScript debuggable script URLs which may not be complete URLs.
(WebInspector.SourceMapResource.prototype.requestContentFromBackend):
Also handle if NetworkAgent does not exist.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
When connected to a JavaScript debuggable we were hiding disclosure
triangles as we did not expect resources to have subresources. If
a SourceMap is added, show them again.
LayoutTests:
- inspector/unit-tests/url-utilities-expected.txt: Added.
- inspector/unit-tests/url-utilities.html: Added.
- 1:16 PM Changeset in webkit [196653] by
-
- 4 edits in trunk
CSP: Disallow an empty host in a host-source source expression
https://bugs.webkit.org/show_bug.cgi?id=153168
<rdar://problem/24383366>
Reviewed by Brent Fulgham.
Source/WebCore:
Merged from Blink (patch by rob@robwu.nl):
<https://src.chromium.org/viewvc/blink?revision=180407&view=revision>
- page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::ContentSecurityPolicySourceList::parseSource):
LayoutTests:
Remove entry for test http/tests/security/contentSecurityPolicy/source-list-parsing-07.html
as it now passes.
- 1:12 PM Changeset in webkit [196652] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should support NewTypedArray
https://bugs.webkit.org/show_bug.cgi?id=154268
Reviewed by Saam Barati.
3% speed-up on pdfjs. This was already covered by many different tests.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToLLVM::compileAllocatePropertyStorage):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateBasicStorage):
(JSC::FTL::DFG::LowerDFGToLLVM::allocateObject):
- 12:58 PM Changeset in webkit [196651] by
-
- 15 edits4 adds in trunk/Source
Modern IDB: WK2 IPC Scaffolding.
https://bugs.webkit.org/show_bug.cgi?id=154296
Reviewed by Alex Christensen.
No change in behavior yet; Just laying the groundwork.
Source/WebCore:
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/shared/IDBResourceIdentifier.h:
Source/WebKit2:
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::establishIDBConnectionToServer):
(WebKit::DatabaseToWebProcessConnection::removeIDBConnectionToServer):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp: Added.
(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::~WebIDBConnectionToClient):
(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess):
(WebKit::WebIDBConnectionToClient::messageSenderConnection):
(WebKit::WebIDBConnectionToClient::connectionToClient):
(WebKit::WebIDBConnectionToClient::didDeleteDatabase):
(WebKit::WebIDBConnectionToClient::didOpenDatabase):
(WebKit::WebIDBConnectionToClient::didAbortTransaction):
(WebKit::WebIDBConnectionToClient::didCommitTransaction):
(WebKit::WebIDBConnectionToClient::didCreateObjectStore):
(WebKit::WebIDBConnectionToClient::didDeleteObjectStore):
(WebKit::WebIDBConnectionToClient::didClearObjectStore):
(WebKit::WebIDBConnectionToClient::didCreateIndex):
(WebKit::WebIDBConnectionToClient::didDeleteIndex):
(WebKit::WebIDBConnectionToClient::didPutOrAdd):
(WebKit::WebIDBConnectionToClient::didGetRecord):
(WebKit::WebIDBConnectionToClient::didGetCount):
(WebKit::WebIDBConnectionToClient::didDeleteRecord):
(WebKit::WebIDBConnectionToClient::didOpenCursor):
(WebKit::WebIDBConnectionToClient::didIterateCursor):
(WebKit::WebIDBConnectionToClient::fireVersionChangeEvent):
(WebKit::WebIDBConnectionToClient::didStartTransaction):
(WebKit::WebIDBConnectionToClient::notifyOpenDBRequestBlocked):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h: Added.
- Platform/Logging.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp: Added.
(WebKit::generateConnectionToServerIdentifier):
(WebKit::WebIDBConnectionToServer::create):
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
(WebKit::WebIDBConnectionToServer::~WebIDBConnectionToServer):
(WebKit::WebIDBConnectionToServer::messageSenderConnection):
(WebKit::WebIDBConnectionToServer::coreConnectionToServer):
(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
(WebKit::WebIDBConnectionToServer::createObjectStore):
(WebKit::WebIDBConnectionToServer::deleteObjectStore):
(WebKit::WebIDBConnectionToServer::clearObjectStore):
(WebKit::WebIDBConnectionToServer::createIndex):
(WebKit::WebIDBConnectionToServer::deleteIndex):
(WebKit::WebIDBConnectionToServer::putOrAdd):
(WebKit::WebIDBConnectionToServer::getRecord):
(WebKit::WebIDBConnectionToServer::getCount):
(WebKit::WebIDBConnectionToServer::deleteRecord):
(WebKit::WebIDBConnectionToServer::openCursor):
(WebKit::WebIDBConnectionToServer::iterateCursor):
(WebKit::WebIDBConnectionToServer::establishTransaction):
(WebKit::WebIDBConnectionToServer::databaseConnectionClosed):
(WebKit::WebIDBConnectionToServer::abortOpenAndUpgradeNeeded):
(WebKit::WebIDBConnectionToServer::didFireVersionChangeEvent):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h: Added.
- WebProcess/Databases/WebDatabaseProvider.cpp:
(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):
- WebProcess/Databases/WebDatabaseProvider.h:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::idbConnectionToServerForSession):
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- 12:50 PM Changeset in webkit [196650] by
-
- 2 edits in trunk/Source/JavaScriptCore
stress/sampling-profiler-deep-stack.js fails on ARM 32bit
https://bugs.webkit.org/show_bug.cgi?id=154255
<rdar://problem/24662996>
Reviewed by Mark Lam.
The bug here wasn't in the implementation of the sampling profiler
itself. Rather, it was a bug in the test. JSC wasn't spending a lot
of time in a function that the test assumed a lot of time was spent in.
That's because the DFG was doing a good job at optimizing the function
at the leaf of the recursion. Because of that, we often wouldn't sample it.
I fixed this by making the leaf function do more work.
- tests/stress/sampling-profiler-deep-stack.js:
(platformSupportsSamplingProfiler.foo):
- 12:35 PM Changeset in webkit [196649] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merged r196645. rdar://problem/24679618
- 12:23 PM Changeset in webkit [196648] by
-
- 13 edits in trunk
[Web IDL] Operations should be on the instance for global objects or if [Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=154120
<rdar://problem/24613231>
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/JavaScriptCore:
Have putEntry() take a thisValue parameter in addition to the base,
instead of relying on PropertySlot::thisValue() because this did not
always do the right thing. In particular, when JSDOMWindow::put() was
called to set a function, it would end up setting the new value on the
JSDOMWindowShell instead of the actual JSDOMWindow.
JSDOMWindow::getOwnPropertySlot() would then not be able to find it.
Therefore the following would fail:
$ window.open = "test"
$ console.log(window.open) prints the native function instead of "test"
- runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):
- runtime/Lookup.h:
(JSC::putEntry):
(JSC::lookupPut):
Source/WebCore:
Operations should be on the instance for global objects or if
[Unforgeable] as per the Web IDL specification:
- http://heycam.github.io/webidl/#es-operations
- http://heycam.github.io/webidl/#dfn-unforgeable-on-an-interface
This patch implements this behavior in order to align
with the specification and other browsers.
No new tests, already covered by existing tests.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
Update function names now that they have "Instance" in their
name instead of "Prototype".
(WebCore::JSDOMWindow::getOwnPropertySlot):
- Update function names now that they have "Instance" in their name instead of "Prototype".
- Move the functions hard-coding *before* the static table check now that these functions are in the static table to maintain the previous behavior.
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
Update function names now that they have "Instance" in their
name instead of "Prototype".
- bindings/scripts/CodeGeneratorJS.pm:
- Move functions to the instance if their interface is a global object or if they are marked as [Unforgeable]. Operations are now treated more like attributes, as they can now be either on the instance or the prototype. In a lot of places, I now use the naming "properties" instead of "attributes" as "properties" refer both "attributes" and "operations" / "functions".
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
Rebaseline bindings tests.
LayoutTests:
- inspector/model/remote-object-get-properties-expected.txt:
Rebaseline test because the order of static properties has changed:
functions are now before constants instead of after.
- 12:18 PM Changeset in webkit [196647] by
-
- 2 edits in trunk/Websites/webkit.org
Add a redirect for B3 documentation
https://bugs.webkit.org/show_bug.cgi?id=154293
Reviewed by Timothy Hatcher.
- .htaccess:
- 11:53 AM Changeset in webkit [196646] by
-
- 2 edits in trunk/LayoutTests
Marking webarchive/loading/missing-data.html as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153380
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 11:33 AM Changeset in webkit [196645] by
-
- 3 edits in trunk/Source/WebKit2
Revert r195826.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]):
(-[WKContentView _singleTapCommited:]):
- 11:28 AM Changeset in webkit [196644] by
-
- 4 edits1 add in trunk
ClonedArguments should not materialize its special properties unless they are being changed or deleted
https://bugs.webkit.org/show_bug.cgi?id=154128
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Before we would materialize ClonedArguments whenever they were being accessed.
However this would cause the IC to miss every time as the structure for
the arguments object would change as we went to IC it. Thus on the next
function call we would miss the cache since the new arguments object
would not have materialized the value.
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::getOwnPropertySlot):
- tests/stress/cloned-arguments-modification.js: Added.
(foo):
LayoutTests:
Have argumnets-strict-mode test the speed of spreading the arguments object.
- js/regress/script-tests/arguments-strict-mode.js:
(foo):
- 11:13 AM Changeset in webkit [196643] by
-
- 2 edits in trunk/LayoutTests
Marking fast/events/keydown-1.html as flaky on mac-wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=154297
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 11:12 AM Changeset in webkit [196642] by
-
- 5 edits7 adds in trunk
FTL should support StringFromCharCode
https://bugs.webkit.org/show_bug.cgi?id=154267
Source/JavaScriptCore:
rdar://problem/24192536
Reviewed by Mark Lam.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode): Fix a bug preventing the UntypedUse from being effective.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileStringFromCharCode): Implement the opcode.
- tests/stress/string-from-char-code-slow.js: Added.
LayoutTests:
Reviewed by Mark Lam.
- js/regress/script-tests/string-from-char-code.js: Added.
(result):
- js/regress/script-tests/untyped-string-from-char-code.js: Added.
(result):
- js/regress/string-from-char-code-expected.txt: Added.
- js/regress/string-from-char-code.html: Added.
- js/regress/untyped-string-from-char-code-expected.txt: Added.
- js/regress/untyped-string-from-char-code.html: Added.
- 10:48 AM Changeset in webkit [196641] by
-
- 4 edits in trunk/Source/WebCore
Rollout r188659. This broke scrolling of iframes and overflow when
navigating back to a page in the page cache.
The fix was overly agressive and had no layout test. I will fix the original
issue a different way.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- page/FrameView.cpp:
(WebCore::FrameView::clearScrollableAreas): Deleted.
- page/FrameView.h:
- 10:15 AM Changeset in webkit [196640] by
-
- 4 edits2 adds in trunk
[GTK] No hover-horizontal scrolling available
https://bugs.webkit.org/show_bug.cgi?id=122859
Reviewed by Michael Catanzaro.
Source/WebCore:
This is a regression of WebKit2, because in WebKit1 we used native
widgets for frame scrollbars that handled this automatically. Now
we need to also check if the mouse is over frame scrollbars to
adjust the wheel event.
Test: platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent): Pass the adjusted wheel
event to platformCompleteWheelEvent().
- page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal):
Check also frame scrollbars.
LayoutTests:
- platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll-expected.html: Added.
- platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html: Added.
- 10:13 AM Changeset in webkit [196639] by
-
- 2 edits in branches/safari-601-branch/LayoutTests/loader/stateobjects
Fix pushstate tests. rdar://problem/24527863
- 10:12 AM Changeset in webkit [196638] by
-
- 1 edit2 adds in branches/safari-601-branch/LayoutTests
Address Font Variant test failures. rdar://problem/24494903
- 9:59 AM Changeset in webkit [196637] by
-
- 6 edits in branches/safari-601-branch/Source/WebCore
Fix for rdar://problem/24494562
- 9:24 AM Changeset in webkit [196636] by
-
- 10 edits4 adds in trunk
Factor id mutation style invalidation code into a class
https://bugs.webkit.org/show_bug.cgi?id=154287
Reviewed by Andreas Kling.
Source/WebCore:
Also add a cheap basic optimization that avoids descendant invalidation if they can not be affected.
It would be easy to implement fine grained invalidation like with classes and attribute selectors.
However dynamic id changes are not common enough (nor recommended) to pay the memory cost of
the required data structures.
Test: fast/css/style-invalidation-id-change-descendants.html
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
- css/RuleFeature.h:
- dom/Element.cpp:
(WebCore::makeIdForStyleResolution):
(WebCore::Element::attributeChanged):
(WebCore::checkNeedsStyleInvalidationForIdChange): Deleted.
- style/IdChangeInvalidation.cpp: Added.
(WebCore::Style::IdChangeInvalidation::invalidateStyle):
- style/IdChangeInvalidation.h: Added.
(WebCore::Style::IdChangeInvalidation::IdChangeInvalidation):
(WebCore::Style::IdChangeInvalidation::~IdChangeInvalidation):
LayoutTests:
- fast/css/style-invalidation-id-change-descendants-expected.txt: Added.
- fast/css/style-invalidation-id-change-descendants.html: Added.
- 9:12 AM Changeset in webkit [196635] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196621
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 8:42 AM Changeset in webkit [196634] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Increase the width of the find banner's search field
https://bugs.webkit.org/show_bug.cgi?id=154284
Reviewed by Timothy Hatcher.
- UserInterface/Views/FindBanner.css:
(.find-banner > input[type="search"]):
Keep the minimum width the same as the current width.
(body .find-banner.console-find-banner):
Overwrite ".navigation-bar .item {flex-wrap: nowrap}".
- 2:00 AM Changeset in webkit [196633] by
-
- 12 edits in trunk/Source
Drop StyleResolver and SelectorQueryCache when entering PageCache.
<https://webkit.org/b/154238>
Reviewed by Antti Koivisto.
Source/WebCore:
Stop keeping these around for cached pages to save lots of memory.
We can easily rebuild them if a cached navigation occurs, and this
way we also don't need to worry about invalidating style for cached
pages in all the right places.
Restoring a cached page will now lead to a forced style recalc.
We don't try to defer this (beyond a zero-timer) since it's going
to happen anyway, and it's nicer to front-load the cost rather than
stuttering on the first user content interaction.
- dom/Document.cpp:
(WebCore::Document::setInPageCache):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear): Deleted.
- history/CachedPage.h:
(WebCore::CachedPage::markForVisitedLinkStyleRecalc): Deleted.
(WebCore::CachedPage::markForFullStyleRecalc): Deleted.
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc): Deleted.
(WebCore::PageCache::markPagesForFullStyleRecalc): Deleted.
- history/PageCache.h:
- page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors): Deleted.
- page/Page.cpp:
(WebCore::Page::setViewScaleFactor): Deleted.
(WebCore::Page::setDeviceScaleFactor): Deleted.
(WebCore::Page::setPagination): Deleted.
(WebCore::Page::setPaginationLineGridEnabled): Deleted.
(WebCore::Page::setVisitedLinkStore): Deleted.
Source/WebKit/win:
- WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::removeAllVisitedLinks): Deleted.
(WebVisitedLinkStore::addVisitedLinkHash): Deleted.
- 1:50 AM Changeset in webkit [196632] by
-
- 14 edits in trunk/Source/WebCore
[GTK] clicking on the scrollbar trough steps rather than jumps to the clicked position
https://bugs.webkit.org/show_bug.cgi?id=115363
Reviewed by Michael Catanzaro.
Allow ScrollbarTheme to decide the behavior of a button press event,
instead of only deciding whether to center on thumb or not. This
way we can match the current GTK+ behavior in WebKit, without
affecting other ports.
- platform/ScrollTypes.h: Add ScrollbarButtonPressAction enum.
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::mouseDown): Ask ScrollbarTheme to handle the
event for the pressed part and do the requested action.
- platform/ScrollbarTheme.cpp:
(WebCore::ScrollbarTheme::handleMousePressEvent): Add default
implementation. It's equivalent to the previous default implementation.
- platform/ScrollbarTheme.h:
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::handleMousePressEvent): Match current
GTK+ behavior: left click centers on thumb and right click
scrolls. Dragging the thumb works for left and middle buttons.
- platform/gtk/ScrollbarThemeGtk.h:
- platform/ios/ScrollbarThemeIOS.h: Remove shouldCenterOnThumb,
and don't override handleMousePressEvent since iOS wants the
default behavior.
- platform/ios/ScrollbarThemeIOS.mm:
- platform/mac/ScrollbarThemeMac.h: Override handleMousePressEvent
and remove shouldCenterOnThumb.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::shouldCenterOnThumb): Same implementation just made it
static to be used as helper.
(WebCore::ScrollbarThemeMac::handleMousePressEvent): Return the
desired action keeping the same behavior.
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::handleMousePressEvent): Ditto.
- platform/win/ScrollbarThemeWin.h:
- rendering/RenderScrollbarTheme.h:
- 1:45 AM Changeset in webkit [196631] by
-
- 2 edits in trunk/Source/WebCore
Mouse cursor doesn't change when entering scrollbars
https://bugs.webkit.org/show_bug.cgi?id=154243
Reviewed by Simon Fraser.
If the scrollbar is over or very close to text or a link, when
entering the scrollbar the cursor is not changed, keeping the beam
or hand cursor when using the scrollbar. Same happens for image
documents where the magnifier cursor is used and it remains when
entering the scrollbars. We should use pointer cursor always for
scrollbars.
- page/EventHandler.cpp:
(WebCore::EventHandler::updateCursor): Request also to include
frame scrollbars in hit test result.
(WebCore::EventHandler::selectCursor): Use always pointer cursor
for scrollbars.
- 1:33 AM Changeset in webkit [196630] by
-
- 2 edits in trunk/Source/WebKit2
[Mac][cmake] Unreviewed buildfix after r196488. Just for fun.
- PlatformMac.cmake:
- 12:20 AM Changeset in webkit [196629] by
-
- 15 edits4 adds in trunk
Optimize style invalidations for attribute selectors
https://bugs.webkit.org/show_bug.cgi?id=154242
Reviewed by Andreas Kling.
Source/WebCore:
Currently we invalidate the whole element subtree if there are any attribute selectors for the changed attribute.
This is slow as generally few if any elements are really affected. Using attribute selectors for dynamic styling
should be performant.
This patch implements optimization strategy for attributes similar to what we already have for classes:
- Collect a map of all rules that contains descendant-affecting attribute selectors for a given attribute.
- When an attribute value changes check if there are any such rules for it.
- Check if the value change affects the results of any of the attribute selectors.
- Only if it does invalidate the exact descendant elements affected by the rules.
Test: fast/css/style-invalidation-attribute-change-descendants.html
- WebCore.xcodeproj/project.pbxproj:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::ancestorClassRules):
(WebCore::DocumentRuleSets::ancestorAttributeRulesForHTML):
Create optimization RuleSets when needed.
- css/DocumentRuleSets.h:
(WebCore::DocumentRuleSets::uncommonAttribute):
(WebCore::DocumentRuleSets::features):
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
(WebCore::makeAttributeSelectorKey):
(WebCore::RuleFeatureSet::collectFeatures):
Collect rules with descendant affecting attribute selectors.
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::shrinkToFit):
- css/RuleFeature.h:
- css/SelectorChecker.cpp:
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::attributeSelectorMatches):
Expose function for matching single attribute selectors.
(WebCore::canMatchHoverOrActiveInQuirksMode):
- css/SelectorChecker.h:
- dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
- dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
(WebCore::makeIdForStyleResolution):
(WebCore::Element::attributeChanged):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::removeAttribute):
Add AttributeChangeInvalidation where needed.
(WebCore::Element::needsStyleInvalidation):
Move to Element from ClassChangeInvalidation.
(WebCore::Element::willModifyAttribute):
No more full style invalidation on attribute change.
- style/AttributeChangeInvalidation.cpp: Added.
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):
Invalidate local style.
Check if we need to invalidate descendants by looking into ancestorAttributeRules.
(WebCore::Style::AttributeChangeInvalidation::invalidateDescendants):
Use StyleInvalidationAnalysis to invalidate the subtree for the relevant rules.
- style/AttributeChangeInvalidation.h: Added.
(WebCore::Style::AttributeChangeInvalidation::needsInvalidation):
(WebCore::Style::AttributeChangeInvalidation::AttributeChangeInvalidation):
(WebCore::Style::AttributeChangeInvalidation::~AttributeChangeInvalidation):
If needed, invalidate descendants before and after attribute change to catch rules that start and stop applying.
LayoutTests:
- fast/css/style-invalidation-attribute-change-descendants-expected.txt: Added.
- fast/css/style-invalidation-attribute-change-descendants.html: Added.
- 12:11 AM Changeset in webkit [196628] by
-
- 4 edits2 adds in trunk
Do security checks early in JSDOMWindow::put*()
https://bugs.webkit.org/show_bug.cgi?id=154270
Reviewed by Gavin Barraclough.
Source/WebCore:
Do security checks early in JSDOMWindow::put() / JSDOMWindow::putByIndex()
and return as soon as possible. This makes it less error-prone as we need
to do the security check only once, at the top of the function.
Also lock down the security further by calling lookupPut() only if the
property name is "location". The "location" property is the only one that
can be set cross-origin. Previously, trying to set a property such as
"name" (which cannot be set cross-origin) relied on the attribute setter
doing the security check when getting called. The new check is less error
prone and will correctly prevent overriding window's method cross-origin
once these move down from the prototype (Bug 154120).
Finally, the previous code was failing to set the "location" property
cross-origin after the window has been reified. This patch fixes the
issue by always calling the original "location" property setter from the
static table in the cross-origin case.
Test: http/tests/security/cross-origin-reified-window-location-setting.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::putByIndex):
LayoutTests:
- http/tests/security/cross-frame-access-put-expected.txt:
Rebaseline. The extra security warnings are for the following properties:
closed, crypto, frameElement, pageXOffset and pageYOffset.
All these properties are read-only and therefore cannot be set (cross-origin
or not). The previous code was not doing an explicit check and ended up
trying to set these properties. However, since they are read-only, we would
silently fail to set them. The new code does the explicit check and therefore
will warn and NOT attempt to set.
- http/tests/security/cross-origin-reified-window-location-setting-expected.txt: Added.
- http/tests/security/cross-origin-reified-window-location-setting.html: Added.
Add test to check that setting window.location cross-origin still works after the
window object has been reified.
Feb 15, 2016:
- 11:14 PM Changeset in webkit [196627] by
-
- 5 edits in tags/Safari-601.5.17.1.1/Source
Versioning.
- 11:12 PM Changeset in webkit [196626] by
-
- 1 copy in tags/Safari-601.5.17.1.1
New tag.
- 11:10 PM Changeset in webkit [196625] by
-
- 14 edits in trunk/LayoutTests
[ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLINT test configuration.
https://bugs.webkit.org/show_bug.cgi?id=151611
Reviewed by Saam Barati.
These tests are only failing because they are compiling too much with the LLINT
disabled. As a result, they are using more JIT code heap space than is allowed
by the OS.
This patch excludes these tests from the noLLINT configuration on 32-bit ARM.
- js/script-tests/dfg-float32array.js:
- js/script-tests/dfg-float64array.js:
- js/script-tests/dfg-int16array.js:
- js/script-tests/dfg-int32array-overflow-values.js:
- js/script-tests/dfg-int32array.js:
- js/script-tests/dfg-int8array.js:
- js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
- js/script-tests/dfg-uint16array.js:
- js/script-tests/dfg-uint32array-overflow-values.js:
- js/script-tests/dfg-uint32array.js:
- js/script-tests/dfg-uint8array.js:
- js/script-tests/dfg-uint8clampedarray.js:
- js/script-tests/regress-141098.js:
- 10:42 PM Changeset in webkit [196624] by
-
- 2 edits4 deletes in trunk/Source/WebKit2
Removed unused files after r196478.
- Configurations/DatabaseProcess.xcconfig: Removed.
- Configurations/NetworkProcess.xcconfig: Removed.
- Configurations/PluginProcess.xcconfig: Removed.
- Configurations/WebContentProcess.xcconfig: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 9:39 PM Changeset in webkit [196623] by
-
- 2 edits in trunk/Source/WebKit2
[ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.
https://bugs.webkit.org/show_bug.cgi?id=154100
Reviewed by Carlos Garcia Campos.
Currently, fixed elements are redrawn to a backing store every time layout or scroll happens.
It results in the bad effect on performance-wise. Letting fixed element have separate layers is
necessary when threaded compositor is enabled at least. Because async scrolling requires it.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
- 9:36 PM Changeset in webkit [196622] by
-
- 27 edits8 adds in trunk
[Mac] Gather some rudimentary statistics during resource load
https://bugs.webkit.org/show_bug.cgi?id=153575
<rdar://problem/24075254>
Reviewed by Brady Eidson.
Source/WebCore:
Tested by: http/tests/navigation/statistics.html
- CMakeLists.txt:
- PlatformWin.cmake:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::updateLastHandledUserGestureTimestamp): Log user interaction
with the ResourceLoadObserver.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::willSendRequest): Track load statistics if the
user interacted with the document.
- loader/ResourceLoadObserver.cpp: Added.
- loader/ResourceLoadObserver.h: Added.
- loader/ResourceLoadStatistics.cpp: Added.
- loader/ResourceLoadStatistics.h: Added.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal): Track load statistics.
- page/Settings.cpp:
(WebCore::Settings::setResourceLoadStatisticsEnabled): Added.
- page/Settings.h:
(WebCore::Settings::resourceLoadStatisticsEnabled): Added.
- platform/Logging.h:
- testing/Internals.cpp:
(WebCore::Internals::resourceLoadStatisticsForOrigin):
(WebCore::Internals::setResourceLoadStatisticsEnabled):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/mac:
- Misc/WebKitNSStringExtras.h:
- Misc/WebKitNSStringExtras.mm:
(+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Added.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences resourceLoadStatisticsEnabled]): Added.
(-[WebPreferences setResourceLoadStatisticsEnabled:]): Added.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(WebKitInitializeApplicationCachePathIfNecessary):
(WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Added.
(-[WebView _commonInitializationWithFrameName:groupName:]): Add call to new
initialization method.
(-[WebView _preferencesChanged:]): Track changes in the user's desire to
monitor resource load statistics.
(+[WebView _applicationWillTerminate]): Write statistics to disk (if preferences
say to do so.)
Tools:
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]): Add menu item for new debug flag.
(-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
(-[SettingsController resourceLoadStatisticsEnabled]): Added.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]): React to changes in
users's desire to track resource load statistics.
LayoutTests:
- http/tests/navigation/resources/redirect-on-reload-updates-history-item-statistics.php: Added.
- http/tests/navigation/resources/redirect-updates-history-item-done-statistics.html: Added.
- http/tests/navigation/statistics-expected.txt: Added.
- http/tests/navigation/statistics.html: Added.
- 9:32 PM Changeset in webkit [196621] by
-
- 12 edits in trunk
The following properties should exist on the global object: AudioTrackList, AudioTrack, VideoTrackList, VideoTrack
https://bugs.webkit.org/show_bug.cgi?id=154250
<rdar://problem/24660829>
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
The following properties should exist on the global object:
- AudioTrackList, AudioTrack, VideoTrackList, VideoTrack
These interfaces are not marked as [NoInterfaceObject] in:
No new tests, already covered by existing tests.
- html/track/AudioTrack.idl:
- html/track/AudioTrackList.idl:
- html/track/VideoTrack.idl:
- html/track/VideoTrackList.idl:
LayoutTests:
Rebaseline now that AudioTrackList, AudioTrack, VideoTrackList and VideoTrack
are exposed on the global Window object.
- js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 9:15 PM Changeset in webkit [196620] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Non-overlay scrollbars obscure the ends of lines in the console and sidebars
https://bugs.webkit.org/show_bug.cgi?id=154276
Reviewed by Timothy Hatcher.
- UserInterface/Views/DataGrid.css:
(.data-grid .data-container):
- UserInterface/Views/DatabaseContentView.css:
(.storage-view.query):
- UserInterface/Views/LogContentView.css:
(.content-view.log):
Replace all occurrences of "overflow-y: overlay" with "overflow-y: auto".
- 9:11 PM Changeset in webkit [196619] by
-
- 5 edits in tags/Safari-602.1.18.10
Merged r196589. rdar://problem/24644805
- 9:11 PM Changeset in webkit [196618] by
-
- 5 edits in tags/Safari-602.1.18.10/Source
Versioning.
- 9:08 PM Changeset in webkit [196617] by
-
- 1 copy in tags/Safari-602.1.18.10
New tag.
- 8:51 PM Changeset in webkit [196616] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] BranchAdd can override arguments of its stackmap
https://bugs.webkit.org/show_bug.cgi?id=154274
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-15
Reviewed by Filip Pizlo.
With the 3 operands BranchAdd added in r196513, we can run into
a register allocation such that the destination register is also
used by a value in the stack map.
It use to be that BranchAdd was a 2 operand instruction.
In that form, the destination is also one of the source and
can be recovered through Sub. There is no conflict between
destination and the stackmap.
After r196513, the destination has its own value. It is uncommon
on x86 because of the aggressive aliasing but that can happen.
On ARM, that's a standard form since there is no need for aliasing.
Since the arguments of the stackmap are of type EarlyUse,
they appeared as not interfering with the destination. When the register
allocator gives the same register to the destination and something in
the stack map, the result of BranchAdd destroys the value kept alive
for the stackmap.
In this patch, I introduce a concept very similar to ForceLateUse
to keep the argument of the stackmap live in CheckAdd. The new
role is "ForceLateUseUnlessRecoverable".
In this mode, anything that is not also an input argument becomes
LateUse. As such, it interferes with the destination of CheckAdd.
The arguments are recovered by the slow patch of CheckAdd. They
remain Early use.
This new modes ensure that destination can be aliased to the source
when that's useful, while making sure it is not aliased with another
value that needs to be live on exit.
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::forEachArg):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::forEachArg):
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::forEachArgImpl):
(WTF::printInternal):
- b3/B3StackmapSpecial.h:
- b3/B3StackmapValue.h:
- 8:41 PM Changeset in webkit [196615] by
-
- 104 edits4 adds in trunk/LayoutTests
[EFL] Rebaseline after r196244.
Unreviewed test gardening.
- platform/efl/compositing/geometry/clipping-foreground-expected.txt:
- platform/efl/compositing/geometry/root-layer-update-expected.txt:
- platform/efl/compositing/overflow/ancestor-overflow-expected.txt:
- platform/efl/compositing/overflow/nested-scrolling-expected.txt:
- platform/efl/compositing/overflow/overflow-scroll-expected.txt:
- platform/efl/compositing/overflow/parent-overflow-expected.txt:
- platform/efl/compositing/overflow/scrollbar-painting-expected.txt:
- platform/efl/compositing/reflections/nested-reflection-on-overflow-expected.txt:
- platform/efl/compositing/sibling-positioning-expected.txt:
- platform/efl/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/efl/fast/block/positioning/auto/vertical-rl/007-expected.txt:
- platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
- platform/efl/fast/borders/border-antialiasing-expected.txt:
- platform/efl/fast/clip/001-expected.txt:
- platform/efl/fast/clip/013-expected.txt:
- platform/efl/fast/clip/014-expected.txt:
- platform/efl/fast/clip/016-expected.txt:
- platform/efl/fast/clip/outline-overflowClip-expected.txt:
- platform/efl/fast/css/clip-zooming-expected.txt:
- platform/efl/fast/forms/validation-message-appearance-expected.txt:
- platform/efl/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
- platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt:
- platform/efl/fast/line-grid/line-grid-into-columns-expected.txt:
- platform/efl/fast/lists/scrolled-marker-paint-expected.txt:
- platform/efl/fast/multicol/client-rects-expected.txt:
- platform/efl/fast/multicol/column-break-with-balancing-expected.txt:
- platform/efl/fast/multicol/column-rules-expected.txt:
- platform/efl/fast/multicol/column-rules-stacking-expected.txt:
- platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt:
- platform/efl/fast/multicol/float-paginate-complex-expected.txt:
- platform/efl/fast/multicol/float-paginate-empty-lines-expected.txt:
- platform/efl/fast/multicol/float-paginate-expected.txt:
- platform/efl/fast/multicol/layers-in-multicol-expected.txt:
- platform/efl/fast/multicol/layers-split-across-columns-expected.txt:
- platform/efl/fast/multicol/max-height-columns-block-expected.txt:
- platform/efl/fast/multicol/nested-columns-expected.txt:
- platform/efl/fast/multicol/newmulticol/client-rects-expected.txt:
- platform/efl/fast/multicol/overflow-across-columns-expected.txt:
- platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.txt:
- platform/efl/fast/multicol/overflow-unsplittable-expected.txt:
- platform/efl/fast/multicol/paginate-block-replaced-expected.txt:
- platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.txt:
- platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.txt:
- platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.txt:
- platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.txt:
- platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.txt:
- platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.txt:
- platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.txt:
- platform/efl/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt:
- platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.txt:
- platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.txt:
- platform/efl/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
- platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.txt:
- platform/efl/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
- platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.txt:
- platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.txt:
- platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.txt:
- platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.txt:
- platform/efl/fast/multicol/positive-leading-expected.txt:
- platform/efl/fast/multicol/scrolling-column-rules-expected.txt:
- platform/efl/fast/multicol/scrolling-overflow-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/efl/fast/multicol/table-vertical-align-expected.txt:
- platform/efl/fast/multicol/tall-image-behavior-expected.txt:
- platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
- platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
- platform/efl/fast/multicol/vertical-lr/float-paginate-expected.txt:
- platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
- platform/efl/fast/multicol/vertical-rl/float-paginate-expected.txt:
- platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
- platform/efl/fast/overflow/float-in-relpositioned-expected.txt:
- platform/efl/fast/overflow/overflow-auto-position-absolute-expected.txt:
- platform/efl/fast/overflow/overflow-rtl-expected.txt:
- platform/efl/fast/overflow/paged-x-div-expected.txt:
- platform/efl/fast/overflow/paged-x-div-with-column-gap-expected.txt:
- platform/efl/fast/overflow/paged-x-on-root-expected.txt:
- platform/efl/fast/overflow/paged-x-with-column-gap-expected.txt:
- platform/efl/fast/overflow/paged-y-div-expected.txt:
- platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt:
- platform/efl/fast/repaint/box-shadow-h-expected.txt:
- platform/efl/fast/repaint/box-shadow-v-expected.txt:
- platform/efl/fast/repaint/layer-outline-expected.txt:
- platform/efl/fast/repaint/layer-outline-horizontal-expected.txt:
- platform/efl/fast/table/edge-offsets-expected.txt:
- platform/efl/fast/transforms/overflow-with-transform-expected.txt:
- platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
- platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
- platform/efl/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
- platform/efl/scrollbars/scrollbars-on-positioned-content-expected.txt:
- platform/efl/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
- platform/efl/svg/custom/image-rescale-clip-expected.txt: Added.
- 8:07 PM Changeset in webkit [196614] by
-
- 6 edits1 delete in trunk/Source/WebCore
Stop using NSMapTable in places where we were only using it to be GC safe
<rdar://problem/24063723>
https://bugs.webkit.org/show_bug.cgi?id=154264
Reviewed by Dan Bernstein.
Switch from NSMapTable to HashMap.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMInternal.mm:
- bindings/objc/WebScriptObject.mm:
- bridge/objc/objc_instance.mm:
- platform/spi/cocoa/NSPointerFunctionsSPI.h: Removed. No longer used.
- 6:32 PM Changeset in webkit [196613] by
-
- 2 edits in trunk
Re-enable INTL on WinCairo
https://bugs.webkit.org/show_bug.cgi?id=154256
Patch by Alex Christensen <achristensen@webkit.org> on 2016-02-15
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsWin.cmake:
Peavo updated icu and it works, so let's re-enable INTL on WinCairo to catch Windows build failures.
- 6:22 PM Changeset in webkit [196612] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 5:53 PM Changeset in webkit [196611] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196607
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 4:50 PM Changeset in webkit [196610] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual sidebar minor regression fixes
https://bugs.webkit.org/show_bug.cgi?id=154237
<rdar://problem/24653135>
Patch by Devin Rousso <Devin Rousso> on 2016-02-15
Reviewed by Timothy Hatcher.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder):
Do not display the placeholder, as it is not used in comma separated value
property editors.
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle): Deleted.
Added ::before to get rid of the "-" on subtitle elements (r196266).
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
Recalculates the width for all comma separated value elements (r196266).
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
Only open/close sections with properties that have values when a new node
or selector item is selected.
(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
Make copies of the default unit lists to prevent modifying the values used
later in other sections (r194728).
- 4:20 PM Changeset in webkit [196609] by
-
- 4 edits in trunk/Source/WebKit2
Implement content sniffing check with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154261
Reviewed by Andy Estes.
This fixes http/tests/xmlhttprequest/small-chunks-response-text.html when using NetworkSession.
- NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::create):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::NetworkDataTask):
Content sniffing is enabled by default. Disable it if the NetworkLoadParameters say not to.
This is analogous to behavior in ResourceHandle::createNSURLConnection.
- 4:17 PM Changeset in webkit [196608] by
-
- 1 copy in tags/Safari-601.1.46.100
New tag.
- 3:58 PM Changeset in webkit [196607] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
Re-sync W3C web-platform-tests' html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=154259
Reviewed by Ryosuke Niwa.
Re-sync W3C web-platform-tests' html/dom/interfaces.html after:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- 3:57 PM Changeset in webkit [196606] by
-
- 9 edits2 deletes in trunk/Source/WebInspectorUI
Web Inspector: eliminate the linear and rendering frames TimelineOverview subclasses
https://bugs.webkit.org/show_bug.cgi?id=154000
<rdar://problem/24553105>
Reviewed by Timothy Hatcher.
This patch eliminates the TimelineOverview subclasses, and moves logic for switching between
a time-based or frame-based graph into the overview itself. The values of the overview's start
time, current time, and end time now match the values in the timeline recording regardless of the
current view mode. When viewing the rendering frames graph, the recording times are ignored and
all frames are included. The overview maintains separate zoom level and ruler selection settings
for each view mode.
- UserInterface/Main.html:
- UserInterface/Views/LinearTimelineOverview.js: Removed.
- UserInterface/Views/RenderingFrameTimelineOverview.js: Removed.
Removed TimelineOverview subclasses.
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.get height):
Set FPS graph height to 108 pixels.
- UserInterface/Views/TimelineOverview.css:
(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:not(:first-child)):
(.timeline-overview > .graphs-container > .timeline-overview-graph:nth-child(even)): Deleted.
(.timeline-overview > .graphs-container > .timeline-overview-graph:not(:first-child)): Deleted.
Disable alternating graph styles when showing FPS instrument.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview):
Create separate settings for timelines and FPS view modes.
(WebInspector.TimelineOverview.prototype.get viewMode):
(WebInspector.TimelineOverview.prototype.set viewMode):
(WebInspector.TimelineOverview.prototype.set startTime):
Adjust the current ruler selection when start time changes. Not necessary
when showing the FPS instrument, which doesn't have a start time.
(WebInspector.TimelineOverview.prototype.get secondsPerPixel):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
Now a wrapper around the corresponding view mode setting.
(WebInspector.TimelineOverview.prototype.set pixelAlignDuration):
(WebInspector.TimelineOverview.prototype.get scrollStartTime):
(WebInspector.TimelineOverview.prototype.set scrollStartTime):
Now a wrapper around the corresponding view mode setting.
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.get height):
Return the sum height of all visible overview graphs.
(WebInspector.TimelineOverview.prototype.shown):
Show overview graphs for the current view mode.
(WebInspector.TimelineOverview.prototype.hidden):
(WebInspector.TimelineOverview.prototype.reset):
(WebInspector.TimelineOverview.prototype.recordWasFiltered):
(WebInspector.TimelineOverview.prototype.selectRecord):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverview.prototype.layout):
Layout for both view modes is largely identical, and differs only in the treatment
of the overview's start time, current time, and end time. Time-based instruments
use time values from the recording, while the FPS instrument has a fixed start time
of zero, and a current and end time pinned to the last rendering frame.
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview._handleGestureStart):
(WebInspector.TimelineOverview.prototype._handleGestureChange):
(WebInspector.TimelineOverview.prototype._instrumentAdded):
(WebInspector.TimelineOverview.prototype._instrumentRemoved):
(WebInspector.TimelineOverview.prototype._timelineRulerMouseClicked):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
Save the selection for the current view mode.
(WebInspector.TimelineOverview.prototype._recordSelected):
(WebInspector.TimelineOverview.prototype._resetSelection.reset):
(WebInspector.TimelineOverview.prototype._resetSelection):
(WebInspector.TimelineOverview.prototype._canShowTimelineType):
(WebInspector.TimelineOverview.prototype._viewModeDidChange):
Sets zoom level, ruler selection, and graph visibility based on current view mode.
(WebInspector.TimelineOverview.prototype._createViewModeSettings):
Helper function for creating an object to track the zoom level and ruler
selection of each view mode.
(WebInspector.TimelineOverview.prototype.get _currentSettings):
Internal getter for retrieving the settings for the current view mode.
(WebInspector.TimelineOverview.prototype.canShowTimeline): Deleted.
Not needed now that the overview contains all timelines.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.shown):
(WebInspector.TimelineOverviewGraph.prototype.hidden):
Toggle CSS hidden class.
- UserInterface/Views/TimelineRecordFrame.js:
No need to query offsetHeight now that TimelineOverviewGraph has a height property.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
Create a single timeline overview.
(WebInspector.TimelineRecordingContentView.prototype.get timelineOverviewHeight):
(WebInspector.TimelineRecordingContentView.prototype.shown):
(WebInspector.TimelineRecordingContentView.prototype.hidden):
(WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the timeline overview's mode based on the current timeline view.
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
Removed special handling for the FPS overview.
Removed selection start time adjustment, which is now handled internally by TimelineOverview.
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
(WebInspector.TimelineRecordingContentView.prototype._updateFrameSelection):
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineSidebarPanel.prototype.saveStateToCookie):
(WebInspector.TimelineSidebarPanel.prototype._renderingFrameTimelineTimesUpdated):
(WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
Refresh the view mode when the content view changes.
(WebInspector.TimelineSidebarPanel.prototype._recordingSelected):
(WebInspector.TimelineSidebarPanel.prototype._viewModeSelected):
(WebInspector.TimelineSidebarPanel.prototype._viewModeForTimeline):
(WebInspector.TimelineSidebarPanel.prototype._updateViewModeIfNeeded):
Sync the tree outline, frames chart, and navigation bar with the current view mode.
(WebInspector.TimelineSidebarPanel.prototype.shown):
Refreshing the frame selection is unnecessary. It's updated by the recording content
view whenever the ruler selection changes.
(WebInspector.TimelineSidebarPanel.prototype.get viewMode): Deleted.
No longer public, since the timeline overview now owns the view mode. Internally the sidebar
still tracks the current state so it can determine when the value has changed.
(WebInspector.TimelineSidebarPanel.prototype.showTimelineOverview):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineViewForTimeline):
The sidebar should only be synced to the overview after the content view has changed.
(WebInspector.TimelineSidebarPanel.prototype.updateFrameSelection):
Removed unnecessary assertion.
(WebInspector.TimelineSidebarPanel.prototype._changeViewMode): Deleted.
Replaced by _updateViewModeIfNeeded.
- 3:57 PM Changeset in webkit [196605] by
-
- 5 edits1 move1 add2 deletes in trunk/Websites/perf.webkit.org
v1 UI and v2 UI should share statistics.js
https://bugs.webkit.org/show_bug.cgi?id=154262
Reviewed by Chris Dumez.
Share statistics.js between v1 and v2 UI.
- public/index.html:
- public/js/shared.js: Deleted.
- public/js/statistics.js: Removed.
- public/shared: Added.
- public/shared/statistics.js: Moved from Websites/perf.webkit.org/public/v2/js/statistics.js.
- public/v2/index.html:
- public/v2/js/statistics.js: Removed.
- public/v3/index.html:
- tools/detect-changes.js:
- 3:39 PM Changeset in webkit [196604] by
-
- 24 edits2 copies2 adds in trunk
[Font Loading] Implement FontFace JavaScript object
https://bugs.webkit.org/show_bug.cgi?id=153345
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/text/font-face-javascript.html
This patch implements the FontFace Javascript object. This object mostly consists of
style getters / setters, which we implement by parsing input strings and generating
output strings similarly to getComputedStyle(). This object also has a load() function
which returns a promise which will be fulfilled or rejected depending on the load.
There is also a "loaded" attribute which exposes this promise directly. Also, a status
field is exposed so script knows what the state of the load is.
Currently, loading depends on our CachedResourceLoader which is part of the Document,
so this API is not available in a non-document context.
Another caveat is that immediate-mode font loading (where the content provides an
ArrayBuffer containing the bytes of the font file) is forthcoming. This requires
changing the relationship between CSSFontFaceSource and CachedFont.
CSSFontFace has been modified to keep a strong reference to the CSSFontSelector. This
is because the lifetime of the CSSFontFace can now outlive the CSSFontSelector. When
the CSSFontSelector is removed from the Document, it explicitly clears its constituent
CSSFontFaces, thereby breaking the reference cycle.
Test: fast/text/font-face-javascript-expected.html
- CMakeLists.txt: Add new files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSDOMPromise.cpp:
(WebCore::DeferredWrapper::globalObject): Remove whitespace.
(WebCore::DeferredWrapper::deferred): Allow access to the inner JSC object.
- bindings/js/JSDOMPromise.h:
(WebCore::DOMPromise::deferred): Ditto.
- bindings/js/JSFontFaceCustom.cpp: Copied from Source/WebCore/bindings/js/JSDOMPromise.cpp.
(WebCore::JSFontFace::loaded):
(WebCore::JSFontFace::load):
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::adoptSource):
(WebCore::CSSFontFace::updateStatus): Enforce the state machine's transitions.
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::load):
- css/CSSFontFace.h:
(WebCore::CSSFontFaceClient::~CSSFontFaceClient):
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::status):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::appendSources): Update for new CSSFontFace API.
(WebCore::CSSFontSelector::registerLocalFontFacesForFamily): Ditto.
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::CSSFontSelector::kick): Ditto.
(WebCore::appendSources): Deleted.
(WebCore::registerLocalFontFacesForFamily): Deleted.
- css/CSSFontSelector.h:
- css/CSSUnicodeRangeValue.cpp: Use for serializing the "unicodeRange" property.
- css/FontFace.cpp:
(WebCore::createPromise): Implement the remaining Javascript API functions.
(WebCore::valueFromDictionary):
(WebCore::FontFace::create):
(WebCore::FontFace::FontFace):
(WebCore::FontFace::parseString):
(WebCore::FontFace::status):
(WebCore::FontFace::kick):
(WebCore::FontFace::load):
(WebCore::FontFace::fulfillPromise):
(WebCore::FontFace::rejectPromise):
(WebCore::parseString): Deleted.
- css/FontFace.h:
(WebCore::FontFace::promise):
(WebCore::FontFace::backing):
(WebCore::FontFace::create): Deleted.
- css/FontFace.idl: Copied from Source/WebCore/bindings/js/JSDOMPromise.cpp.
LayoutTests:
- fast/text/font-face-javascript-expected.txt: Added.
- fast/text/font-face-javascript.html: Added.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 2:37 PM Changeset in webkit [196603] by
-
- 61 edits in trunk/Source/WebCore
Null-deref crash in DefaultAudioDestinationNode::suspend()
https://bugs.webkit.org/show_bug.cgi?id=154248
Reviewed by Alex Christensen.
Drive-by fix: AudioContext should be a reference, not a pointer.
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
- Modules/webaudio/AnalyserNode.h:
(WebCore::AnalyserNode::create):
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):
(WebCore::AudioBasicInspectorNode::checkNumberOfChannelsForInput):
(WebCore::AudioBasicInspectorNode::updatePullStatus):
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::setBuffer):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::createBufferSource):
(WebCore::AudioContext::createMediaElementSource):
(WebCore::AudioContext::createMediaStreamDestination):
(WebCore::AudioContext::createScriptProcessor):
(WebCore::AudioContext::createBiquadFilter):
(WebCore::AudioContext::createWaveShaper):
(WebCore::AudioContext::createPanner):
(WebCore::AudioContext::createConvolver):
(WebCore::AudioContext::createDynamicsCompressor):
(WebCore::AudioContext::createAnalyser):
(WebCore::AudioContext::createGain):
(WebCore::AudioContext::createDelay):
(WebCore::AudioContext::createChannelSplitter):
(WebCore::AudioContext::createChannelMerger):
(WebCore::AudioContext::createOscillator):
- Modules/webaudio/AudioContext.h:
(WebCore::operator==):
(WebCore::operator!=):
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
(WebCore::AudioDestinationNode::render):
(WebCore::AudioDestinationNode::updateIsEffectivelyPlayingAudio):
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::scriptExecutionContext):
(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::checkNumberOfChannelsForInput):
(WebCore::AudioNode::propagatesSilence):
(WebCore::AudioNode::pullInputs):
(WebCore::AudioNode::enableOutputsIfNecessary):
(WebCore::AudioNode::deref):
(WebCore::AudioNode::finishDeref):
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::context):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::connect):
(WebCore::AudioNodeInput::disconnect):
(WebCore::AudioNodeInput::disable):
(WebCore::AudioNodeInput::enable):
(WebCore::AudioNodeInput::updateInternalBus):
(WebCore::AudioNodeInput::bus):
(WebCore::AudioNodeInput::internalSummingBus):
(WebCore::AudioNodeInput::sumAllConnections):
(WebCore::AudioNodeInput::pull):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::setNumberOfChannels):
(WebCore::AudioNodeOutput::updateNumberOfChannels):
(WebCore::AudioNodeOutput::propagateChannelCount):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore::AudioNodeOutput::paramFanOutCount):
(WebCore::AudioNodeOutput::addInput):
(WebCore::AudioNodeOutput::removeInput):
(WebCore::AudioNodeOutput::disconnectAllInputs):
(WebCore::AudioNodeOutput::addParam):
(WebCore::AudioNodeOutput::removeParam):
(WebCore::AudioNodeOutput::disconnectAllParams):
(WebCore::AudioNodeOutput::disable):
(WebCore::AudioNodeOutput::enable):
- Modules/webaudio/AudioNodeOutput.h:
(WebCore::AudioNodeOutput::context):
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::value):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):
- Modules/webaudio/AudioParam.h:
(WebCore::AudioParam::create):
(WebCore::AudioParam::AudioParam):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
- Modules/webaudio/AudioParamTimeline.h:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::finish):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/AudioSummingJunction.cpp:
(WebCore::AudioSummingJunction::AudioSummingJunction):
(WebCore::AudioSummingJunction::~AudioSummingJunction):
(WebCore::AudioSummingJunction::changedOutputs):
(WebCore::AudioSummingJunction::updateRenderingState):
- Modules/webaudio/AudioSummingJunction.h:
(WebCore::AudioSummingJunction::context):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadFilterNode.h:
(WebCore::BiquadFilterNode::create):
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::ChannelMergerNode):
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/ConvolverNode.h:
(WebCore::ConvolverNode::create):
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):
- Modules/webaudio/DefaultAudioDestinationNode.h:
(WebCore::DefaultAudioDestinationNode::create):
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
- Modules/webaudio/DelayNode.h:
(WebCore::DelayNode::create):
- Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
- Modules/webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::create):
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
(WebCore::GainNode::checkNumberOfChannelsForInput):
- Modules/webaudio/GainNode.h:
(WebCore::GainNode::create):
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::create):
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::setFormat):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::offlineRender):
(WebCore::OfflineAudioDestinationNode::notifyComplete):
- Modules/webaudio/OfflineAudioDestinationNode.h:
(WebCore::OfflineAudioDestinationNode::create):
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
(WebCore::OscillatorNode::OscillatorNode):
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::pullInputs):
(WebCore::PannerNode::process):
(WebCore::PannerNode::listener):
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/PannerNode.h:
(WebCore::PannerNode::create):
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::create):
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::initialize):
(WebCore::ScriptProcessorNode::fireProcessEvent):
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setOversample):
- Modules/webaudio/WaveShaperNode.h:
(WebCore::WaveShaperNode::create):
- 2:36 PM Changeset in webkit [196602] by
-
- 2 edits in trunk/Source/WebCore
Null-deref crash in DefaultAudioDestinationNode::suspend()
https://bugs.webkit.org/show_bug.cgi?id=154248
Reviewed by Alex Christensen.
Null-check scriptExecutionContext() before deref.
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):
- 2:33 PM Changeset in webkit [196601] by
-
- 2 edits in trunk/Tools
[EFL] Update Tools/efl/install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=154239
Reviewed by Michael Catanzaro.
- efl/install-dependencies:
- 2:25 PM Changeset in webkit [196600] by
-
- 11 edits4 adds in trunk/Source/WebKit2
Move Download authentication code to AuthenticationManager
https://bugs.webkit.org/show_bug.cgi?id=154132
Reviewed by Sam Weinig.
When a video element makes a request that receives an authentication challenge, the
AuthenticationManager receives an AuthenticationChallenge without an AuthenticationClient.
As a result, Download::receivedCredential and other functions were being called, which
sent a message to the challenge's sender. This functionality is not specific to downloads,
so I moved it from Download to AuthenticationManager.
This fixes http/tests/media/video-auth.html when using NetworkSession
because I use AuthenticationManager::receivedCredential if there is no AuthenticationClient
instead of improperly asserting that there is always an AuthenticationClient if there is no
completionHandler.
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
- NetworkProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
- NetworkProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::continueWithoutCredential): Deleted.
(WebKit::Download::useCredential): Deleted.
(WebKit::Download::cancelAuthenticationChallenge): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
- Shared/Authentication/AuthenticationManager.h:
(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):
- Shared/Authentication/cocoa: Added.
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: Added.
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
- Shared/Authentication/soup: Added.
- Shared/Authentication/soup/AuthenticationManagerSoup.cpp: Added.
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
- WebKit2.xcodeproj/project.pbxproj:
- 2:03 PM Changeset in webkit [196599] by
-
- 22 edits1 copy1 add in trunk
XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
https://bugs.webkit.org/show_bug.cgi?id=154230
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
Source/WebCore:
MLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
as per:
https://xhr.spec.whatwg.org/#xmlhttprequesteventtarget
Firefox and Chrome already match the specification.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestEventTarget.h: Added.
- xml/XMLHttpRequestEventTarget.idl: Copied from Source/WebCore/xml/XMLHttpRequestUpload.idl.
- xml/XMLHttpRequestUpload.h:
- xml/XMLHttpRequestUpload.idl:
LayoutTests:
Rebaseline tests now that XMLHttpRequestEventTarget is exposed on the
global objects.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 1:38 PM Changeset in webkit [196598] by
-
- 13 edits2 adds in trunk
Refine SimulatedMouseEvent to support Event.isTrusted
https://bugs.webkit.org/show_bug.cgi?id=154133
<rdar://problem/24616246>
Reviewed by Darin Adler.
Source/WebCore:
This patch extracts everything related to create/dispatch SimulatedMouseEvent from MouseEvent.h/cpp
and EventDispatcher.h/cpp, and produces SimulateClick.h/cpp which will handle simulated click solely.
After that, we hide the SimulatedMouseEvent and only expose simulateClick to be called. The reason is
that we both want to tell whether the call sites are from user agent/bindings and keep the
SimulatedMouseEvent intact.
Also, this patch separate Element::dispatchSimulatedClick into two: one for the user agent, and another
for the bindings. Therefore, HTMLElement.click will be treated as untrusted.
Some of the changes in this patch referred Blink r200401:
https://codereview.chromium.org/1285793004
Modified test:
LayoutTests/imported/blink/fast/events/event-trusted.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::dispatchSimulatedClick):
(WebCore::Element::dispatchSimulatedClickForBindings):
- dom/Element.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick): Deleted.
- dom/EventDispatcher.h:
- dom/MouseEvent.cpp:
(WebCore::SimulatedMouseEvent::create): Deleted.
(WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Deleted.
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Deleted.
- dom/MouseEvent.h:
- dom/SimulatedClick.cpp: Added.
(WebCore::simulateMouseEvent):
(WebCore::simulateClick):
- dom/SimulatedClick.h: Added.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::click):
LayoutTests:
- imported/blink/fast/events/event-trusted-expected.txt:
- imported/blink/fast/events/event-trusted.html:
- 1:37 PM Changeset in webkit [196597] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Show inherited CSS variables in the Style sidebar
https://bugs.webkit.org/show_bug.cgi?id=154215
rdar://problem/24644058
Reviewed by Joseph Pecoraro.
- UserInterface/Models/CSSProperty.js:
(WebInspector.CSSProperty.isInheritedPropertyName): Added.
(WebInspector.CSSProperty.prototype.update): Use WebInspector.CSSProperty.isInheritedPropertyName.
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload): Use WebInspector.CSSProperty.isInheritedPropertyName.
- 1:30 PM Changeset in webkit [196596] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
https://bugs.webkit.org/show_bug.cgi?id=154218
rdar://problem/24644192
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel): Default the setting value to 300 instead of 0, so the minimum isn't used.
- 1:25 PM Changeset in webkit [196595] by
-
- 3 edits in trunk/LayoutTests
Marking animations/animation-delay-changed.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=154253
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 1:23 PM Changeset in webkit [196594] by
-
- 12 edits5 adds in trunk
Web Inspector: Web Workers have no access to console for debugging
https://bugs.webkit.org/show_bug.cgi?id=26237
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-15
Reviewed by Timothy Hatcher.
LayoutTests/imported/w3c:
- web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt:
Update test results for a console.warn message that the test produces from a Worker.
Source/JavaScriptCore:
- inspector/ConsoleMessage.h:
Add accessor for MessageLevel.
Source/WebCore:
This adds the most basic console message support to Workers.
Messages logged from workers get surfaced through the Page's console.
This lacks support for logging and interacting with arguments,
which would be addressed when adding more complete Worker
debugging tools.
Test: inspector/console/messageAdded-from-worker.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
Set the ConsoleClient for the Worker's global object. We route
the messages to the Page's console.
- bindings/js/WorkerScriptController.h:
- workers/WorkerConsoleClient.h: Added.
- workers/WorkerConsoleClient.cpp: Added.
(WebCore::WorkerConsoleClient::WorkerConsoleClient):
(WebCore::WorkerConsoleClient::~WorkerConsoleClient):
(WebCore::WorkerConsoleClient::profile):
(WebCore::WorkerConsoleClient::profileEnd):
(WebCore::WorkerConsoleClient::count):
(WebCore::WorkerConsoleClient::time):
(WebCore::WorkerConsoleClient::timeEnd):
(WebCore::WorkerConsoleClient::timeStamp):
Stub most console methods in a Worker.
(WebCore::WorkerConsoleClient::messageWithTypeAndLevel):
Send worker log messages to the global scope and on to the main page.
- workers/WorkerGlobalScope.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):
Ideally we want to converge on simple addConsoleMessage
APIs that just take a ConsoleMessage, without a barrage
of parameters. Add these versions now.
LayoutTests:
- inspector/console/messageAdded-from-worker-expected.txt: Added.
- inspector/console/messageAdded-from-worker.html: Added.
- inspector/console/resources/worker-console-log.js: Added.
- 1:16 PM Changeset in webkit [196593] by
-
- 5 edits2 adds in trunk
Web Inspector: CSS variables are not formatted correctly
https://bugs.webkit.org/show_bug.cgi?id=154217
rdar://problem/24644154
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- UserInterface/Views/CodeMirrorFormatters.js:
(newlineBeforeToken): Check for
variable-2token in themaybepropstate.
LayoutTests:
- inspector/codemirror/prettyprinting-css-rules-expected.txt:
- inspector/codemirror/prettyprinting-css-rules.html:
- inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css: Added.
- inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css: Added.
- 1:13 PM Changeset in webkit [196592] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CodeMirror styles needs updated for CSS variables
https://bugs.webkit.org/show_bug.cgi?id=154216
rdar://problem/24644146
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Added .cm-variable-2.
(.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Ditto.
- 1:08 PM Changeset in webkit [196591] by
-
- 5 edits in trunk/Source/JavaScriptCore
[ARMv7] stress/op_rshift.js and stress/op_urshift.js are failing.
https://bugs.webkit.org/show_bug.cgi?id=151514
Reviewed by Filip Pizlo.
The issue turns out to be trivial: on ARMv7 (and traditional ARM too), arithmetic
shift right (ASR) and logical shift right (LSR) takes an immediate shift amount
from 1-32. See http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0204j/Cjacbgca.html.
An immediate shift amount of 0 is interpreted as a shift of 32 bits.
Meanwhile, our macro assembler is expecting the immediate shift value to be
between 0-31. As a result, a shift amount of 0 is being wrongly encoded with 0
bits which means shift right by 32 bits.
The fix is to check if the shift amount is 0, and if so, emit a move. Else,
emit the right shift as usual.
This issue does not affect left shifts, as the immediate shift amount for left
shifts is between 0-31 as our macro assembler expects.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::rshift32):
(JSC::MacroAssemblerARMv7::urshift32):
- tests/stress/op_rshift.js:
- tests/stress/op_urshift.js:
- Un-skip these tests. They should always pass now.
- 12:49 PM Changeset in webkit [196590] by
-
- 2 edits in trunk/Source/WebCore
CMake build fix.
- PlatformMac.cmake:
- 12:30 PM Changeset in webkit [196589] by
-
- 5 edits in trunk
Fix internal Windows build of projects built after WebKit
https://bugs.webkit.org/show_bug.cgi?id=154249
rdar://problem/24644805
Reviewed by Chris Dumez.
Source/WebKit:
- PlatformWin.cmake:
Copy all generated headers to ForwardingHeaders/WebKit, not just WebKit.h.
This should fix problems related to not finding headers from other projects, such as AccessibleApplication.h.
WebKit.h, WebKitCOMAPI.h, and CFDictionaryPropertyBag.h were copied correctly, so this should copy the rest
of the needed headers.
Tools:
- DumpRenderTree/PlatformWin.cmake:
- MiniBrowser/win/CMakeLists.txt:
Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
more like projects built internally after WebKit. They should only need to use what
is in ForwardingHeaders/WebKit.
- 12:09 PM Changeset in webkit [196588] by
-
- 3 edits2 adds in trunk
Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'
https://bugs.webkit.org/show_bug.cgi?id=154245
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch adds support for calling the EventListener API without an
explicit 'this' value. If no explicit 'this' value is passed, then we
fall back to using the global object. This matches Chrome and Firefox's
behavior. It also fixes the Dromaeo/cssquery-dojo.html test.
Test: fast/dom/Window/addEventListener-implicit-this.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateFunctionCastedThis):
LayoutTests:
Add a layout test to cover the use of the EventListener API without an
explicit 'this' value.
- fast/dom/Window/addEventListener-implicit-this-expected.txt: Added.
- fast/dom/Window/addEventListener-implicit-this.html: Added.
- 12:09 PM Changeset in webkit [196587] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr
https://bugs.webkit.org/show_bug.cgi?id=154244
rdar://problem/24290670
Reviewed by Michael Saboff.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::appendToCommaExpr): Catch the bug sooner in debug.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVariableDeclarationList): Fix the bug.
- tests/stress/for-let-comma.js: Added. This used to crash in debug and release.
- 12:01 PM Changeset in webkit [196586] by
-
- 5 edits in branches/safari-601.1.46-branch/Source/bmalloc
Merged r196536. rdar://problem/24620164
- 11:59 AM Changeset in webkit [196585] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/bmalloc
Merged r196424. rdar://problem/24620164
- 11:58 AM Changeset in webkit [196584] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/bmalloc
Merged r196421. rdar://problem/24620164
- 11:56 AM Changeset in webkit [196583] by
-
- 2 edits in trunk/Source/WebCore
Organize, deduplicate & comment JSDOMWindowCustom getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=154224
Reviewed by Chris Dumez.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::jsDOMWindowGetOwnPropertySlotNamedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- organized property access sequence into a more logical order, removed duplicated code & added comments.
(WebCore::namedItemGetter): Deleted.
- there was no need for a custom callback here; merged functionality into jsDOMWindowGetOwnPropertySlotNamedItemGetter.
(WebCore::jsDOMWindowGetOwnPropertySlotCrossOrigin): Deleted.
- renamed to jsDOMWindowGetOwnPropertySlotRestrictedAccess (this now also handles frameless access).
- 10:54 AM Changeset in webkit [196582] by
-
- 6 edits in trunk
CSP: 'sandbox' should be ignored in report-only mode
https://bugs.webkit.org/show_bug.cgi?id=153167
<rdar://problem/22708669>
Reviewed by Brent Fulgham.
Source/WebCore:
Merged from Blink (patch by Mike West):
<https://src.chromium.org/viewvc/blink?revision=165322&view=revision>
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode): Added. Logs a
console message to the console to explain that the specified directive is invalid in
report-only mode.
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::applySandboxPolicy): Do not apply sandbox
policy when in report-only mode and call ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode()
to log a message to the console.
LayoutTests:
Remove the entry from the TestExpectations file for the test
http/tests/security/contentSecurityPolicy/sandbox-report-only.html as it now passes.
- 10:53 AM Changeset in webkit [196581] by
-
- 5 edits in trunk
CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
https://bugs.webkit.org/show_bug.cgi?id=154177
<rdar://problem/22708772>
Reviewed by Brent Fulgham.
Source/WebCore:
Allow a schemeless source expression to match an HTTP or HTTPS subresource when the page is
delivered over HTTP as per section Matching Source Expressions of the Content Security Policy
2.0 spec., <https://www.w3.org/TR/2015/CR-CSP2-20150721/> (21 July 2015).
Currently we have logic that implements this functionality, but it is guarded behind the compile-
time macro ENABLE(CSP_NEXT) that is disabled by default. Instead we should always compile such
code. In subsequent commits we will move more code out from under the ENABLE(CSP_NEXT)-guard
towards removing the ENABLE_CSP_NEXT macro entirely.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::protocolMatchesSelf):
LayoutTests:
Update test case and expected result to test that a schemeless source expression
matches an HTTPS subresource (and does not trigger a Content Security Policy violation)
when the page is served over HTTP.
- http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Change "no" to "yes"
so that we consider it a success (and continue printing "PASS") when we load and execute the
script, <https://127.0.0.1:8443/security/contentSecurityPolicy/resources/script.js>.
- 9:52 AM Changeset in webkit [196580] by
-
- 2 edits in trunk/Websites/webkit.org
Fix byline to avoid bumping into content sticks out.
- wp-content/themes/webkit/style.css:
(article .byline): Bump padding to avoid content with negative margins.
- 9:44 AM Changeset in webkit [196579] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196563
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 7:53 AM Changeset in webkit [196578] by
-
- 3 edits1 add in trunk/Source/WebCore
[cmake] Consolidated Linux-specific file lists.
https://bugs.webkit.org/show_bug.cgi?id=154219
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-15
Reviewed by Gyuyoung Kim.
No new tests needed.
- PlatformEfl.cmake: Moved Linux files and include dir to Linux.cmake.
- PlatformGTK.cmake: Ditto.
- platform/Linux.cmake: Added.
- 5:30 AM Changeset in webkit [196577] by
-
- 344 edits in trunk/LayoutTests
Unreviewed. EFL gardening after r195740.
- platform/efl/tables/mozilla/bugs/bug10269-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10296-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug103533-expected.txt:
- platform/efl/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug108340-expected.txt:
- platform/efl/tables/mozilla/bugs/bug110566-expected.txt:
- platform/efl/tables/mozilla/bugs/bug11321-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug11944-expected.txt:
- platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12384-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1261-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13105-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13484-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13526-expected.txt:
- platform/efl/tables/mozilla/bugs/bug138725-expected.txt:
- platform/efl/tables/mozilla/bugs/bug14159-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug149275-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1828-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18359-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18558-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2050-expected.txt:
- platform/efl/tables/mozilla/bugs/bug20579-expected.txt:
- platform/efl/tables/mozilla/bugs/bug21299-expected.txt:
- platform/efl/tables/mozilla/bugs/bug21918-expected.txt:
- platform/efl/tables/mozilla/bugs/bug221784-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug221784-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22246-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22246-2a-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2267-expected.txt:
- platform/efl/tables/mozilla/bugs/bug23072-expected.txt:
- platform/efl/tables/mozilla/bugs/bug23151-expected.txt:
- platform/efl/tables/mozilla/bugs/bug23299-expected.txt:
- platform/efl/tables/mozilla/bugs/bug24503-expected.txt:
- platform/efl/tables/mozilla/bugs/bug24627-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2469-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug24880-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25086-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2516-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25367-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2585-expected.txt:
- platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug275625-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2757-expected.txt:
- platform/efl/tables/mozilla/bugs/bug278266-expected.txt:
- platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug28928-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29157-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2973-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3037-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3037-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30985-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3191-expected.txt:
- platform/efl/tables/mozilla/bugs/bug32205-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug32205-5-expected.txt:
- platform/efl/tables/mozilla/bugs/bug32447-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug34538-expected.txt:
- platform/efl/tables/mozilla/bugs/bug35662-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3718-expected.txt:
- platform/efl/tables/mozilla/bugs/bug39209-expected.txt:
- platform/efl/tables/mozilla/bugs/bug40828-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4284-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4429-expected.txt:
- platform/efl/tables/mozilla/bugs/bug44523-expected.txt:
- platform/efl/tables/mozilla/bugs/bug45055-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4520-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4739-expected.txt:
- platform/efl/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug51037-expected.txt:
- platform/efl/tables/mozilla/bugs/bug51140-expected.txt:
- platform/efl/tables/mozilla/bugs/bug55527-expected.txt:
- platform/efl/tables/mozilla/bugs/bug55545-expected.txt:
- platform/efl/tables/mozilla/bugs/bug55694-expected.txt:
- platform/efl/tables/mozilla/bugs/bug56405-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57300-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57828-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5798-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5799-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5838-expected.txt:
- platform/efl/tables/mozilla/bugs/bug58402-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug59354-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60013-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60749-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60992-expected.txt:
- platform/efl/tables/mozilla/bugs/bug63785-expected.txt:
- platform/efl/tables/mozilla/bugs/bug650-expected.txt:
- platform/efl/tables/mozilla/bugs/bug67864-expected.txt:
- platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug69187-expected.txt:
- platform/efl/tables/mozilla/bugs/bug709-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug75250-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug82946-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8361-expected.txt:
- platform/efl/tables/mozilla/bugs/bug83786-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8381-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9072-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug93363-expected.txt:
- platform/efl/tables/mozilla/bugs/bug96343-expected.txt:
- platform/efl/tables/mozilla/bugs/bug965-expected.txt:
- platform/efl/tables/mozilla/bugs/bug97138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug99923-expected.txt:
- platform/efl/tables/mozilla/bugs/bug99948-expected.txt:
- platform/efl/tables/mozilla/collapsing_borders/bug127040-expected.txt:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/efl/tables/mozilla/core/captions-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_auto-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
- platform/efl/tables/mozilla/core/row_span-expected.txt:
- platform/efl/tables/mozilla/dom/appendCol2-expected.txt:
- platform/efl/tables/mozilla/dom/appendRowsExpand1-expected.txt:
- platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
- platform/efl/tables/mozilla/dom/deleteCol1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteCol2-expected.txt:
- platform/efl/tables/mozilla/dom/deleteCol3-expected.txt:
- platform/efl/tables/mozilla/dom/deleteColGroup1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteColGroup2-expected.txt:
- platform/efl/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
- platform/efl/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
- platform/efl/tables/mozilla/dom/insertCellsExpand1-expected.txt:
- platform/efl/tables/mozilla/dom/insertCellsExpand2-expected.txt:
- platform/efl/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
- platform/efl/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
- platform/efl/tables/mozilla/dom/insertRowsExpand1-expected.txt:
- platform/efl/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
- platform/efl/tables/mozilla/dom/tableDom-expected.txt:
- platform/efl/tables/mozilla/marvin/body_col-expected.txt:
- platform/efl/tables/mozilla/marvin/body_tbody-expected.txt:
- platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
- platform/efl/tables/mozilla/marvin/col_span-expected.txt:
- platform/efl/tables/mozilla/marvin/table_frame_border-expected.txt:
- platform/efl/tables/mozilla/marvin/table_frame_box-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_all-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_none-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_border_0-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_border_1-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_border_2-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_border_3-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_cellspacing-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_default-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_id-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_colspan-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_height-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_colspan-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_height-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_caption_align_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_rules_none-expected.txt:
- platform/efl/tables/mozilla/marvin/x_table_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_colspan-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_height-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_nowrap-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_rowspan-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_colspan-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_height-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_nowrap-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_class-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_id-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_style-expected.txt:
- platform/efl/tables/mozilla/other/body_col-expected.txt:
- platform/efl/tables/mozilla/other/cellspacing-expected.txt:
- platform/efl/tables/mozilla/other/move_row-expected.txt:
- platform/efl/tables/mozilla/other/padding-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
- 4:28 AM Changeset in webkit [196576] by
-
- 2 edits in trunk/Source/WebCore
Fix the !(ENABLE(SVG_FONTS) ENABLE(SVG_OTF_CONVERTER)) build after r196322 https://bugs.webkit.org/show_bug.cgi?id=154104
Reviewed by Myles C. Maxfield.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::CSSFontFaceSource):
- 2:30 AM Changeset in webkit [196575] by
-
- 5 edits2 adds in trunk
Add test for class change style invalidation optimization
https://bugs.webkit.org/show_bug.cgi?id=154226
Reviewed by Myles Maxfield.
Test for https://trac.webkit.org/r196383
Source/WebCore:
Add internals.styleChangeType function.
Test: fast/css/style-invalidation-class-change-descendants.html
- testing/Internals.cpp:
(WebCore::Internals::nodeNeedsStyleRecalc):
(WebCore::asString):
(WebCore::Internals::styleChangeType):
(WebCore::Internals::description):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
- fast/css/style-invalidation-class-change-descendants.html: Added.
- 1:50 AM Changeset in webkit [196574] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL gardening. Mark more video tests to failure.
- platform/efl/TestExpectations: Added more crash tests and moved the tests to upper position.
- 1:12 AM Changeset in webkit [196573] by
-
- 9 edits in trunk/Source/JavaScriptCore
[JSC] Improve the interface of Inst::shouldTryAliasingDef()
https://bugs.webkit.org/show_bug.cgi?id=154227
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-15
Reviewed by Andreas Kling.
Using Optional<> instead of a bool+reference looks cleaner
at the call sites.
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::shouldTryAliasingDef):
- b3/B3CheckSpecial.h:
- b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::shouldTryAliasingDef):
- b3/air/AirInst.h:
- b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::shouldTryAliasingDef):
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirSpecial.cpp:
(JSC::B3::Air::Special::shouldTryAliasingDef):
- b3/air/AirSpecial.h:
- 12:39 AM Changeset in webkit [196572] by
-
- 2 edits in trunk/Source/WebKit2
[CMake][Mac] Remove WKNPAPIPlugInContainer.mm in WebKit2/PlatformMac.cmake
https://bugs.webkit.org/show_bug.cgi?id=154234
Reviewed by Csaba Osztrogonác.
- PlatformMac.cmake: Remove WKNPAPIPlugInContainer.mm.
Feb 14, 2016:
- 9:10 PM Changeset in webkit [196571] by
-
- 3 edits2 adds in trunk
[CSS Filters] When applying an SVG filter on a composited image using CSS the image is rendered without the filter
https://bugs.webkit.org/show_bug.cgi?id=154108
Reviewed by Sam Weinig.
Source/WebCore:
When checking whether we can directly composite an image, we need to check for software-rendered
filters.
Test: compositing/filters/simple-image-with-svg-filter.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
LayoutTests:
- compositing/filters/simple-image-with-svg-filter-expected.html: Added.
- compositing/filters/simple-image-with-svg-filter.html: Added.
- 8:49 PM Changeset in webkit [196570] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, land an additional Mac CMake build fix.
- PlatformMac.cmake:
- 8:47 PM Changeset in webkit [196569] by
-
- 3 edits in trunk/Source/WebKit/win
Unreviewed Window build fix.
- WebCoreStatistics.cpp:
- WebJavaScriptCollector.cpp:
- 8:43 PM Changeset in webkit [196568] by
-
- 46 edits in trunk/Source/WebCore
Drop the [EventTarget] WebKit-specific IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=154171
Reviewed by Sam Weinig.
Drop the [EventTarget] WebKit-specific IDL extended attribute now that
all interfaces inherit EventTarget when they should.
No new tests, no Web-Exposed behavior change.
- Modules/battery/BatteryManager.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBOpenDBRequest.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/mediasession/MediaRemoteControls.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorGObject.pm:
(ImplementsInterface):
(SkipFunction): Deleted.
(GenerateCFile): Deleted.
- bindings/scripts/CodeGeneratorJS.pm:
(InstanceNeedsVisitChildren):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestEventTarget.idl:
- bindings/scripts/test/TestNode.idl:
- css/FontLoader.idl:
- dom/EventTarget.idl:
- dom/MessagePort.idl:
- dom/Node.idl:
- dom/WebKitNamedFlow.idl:
- fileapi/FileReader.idl:
- html/MediaController.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackList.idl:
- html/track/VideoTrackList.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/DOMWindow.idl:
- page/EventSource.idl:
- page/Performance.idl:
- workers/WorkerGlobalScope.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestUpload.idl:
- 7:53 PM Changeset in webkit [196567] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix the Mac CMake build after r196136
- PlatformMac.cmake:
- 7:47 PM Changeset in webkit [196566] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed attempt to fix the Windows build.
- Modules/webdatabase/Database.cpp:
- bridge/c/c_utility.cpp:
- platform/MemoryPressureHandler.cpp:
- 6:23 PM Changeset in webkit [196565] by
-
- 5 edits in tags/Safari-601.5.17.1/Source
Versioning.
- 6:22 PM Changeset in webkit [196564] by
-
- 1 copy in tags/Safari-601.5.17.1
New tag.
- 6:17 PM Changeset in webkit [196563] by
-
- 29 edits3 adds in trunk
Window and WorkerGlobalScope should inherit EventTarget
https://bugs.webkit.org/show_bug.cgi?id=154170
<rdar://problem/24642377>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline now that a couple of checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Window and WorkerGlobalScope should inherit EventTarget instead of
duplicating the EventTarget API in their IDL. These were the last
interfaces that needed fixing. The next step will be to get rid
of the [EventTarget] IDL extended attribute and rely entirely
on the EventTarget inheritance.
Test:
- fast/frames/detached-frame-eventListener.html
- Covered by existing tests.
- WebCore.xcodeproj/project.pbxproj:
Add JSEventTargetCustom.h header to the project.
- bindings/js/JSDOMWindowCustom.cpp:
Drop custom bindings for Window's addEventListener() and
removeEventListener(). The only reason these needed custom
code was to add a check for frameless windows. The frameless
Window checks was moved to the respective methods in the
JSEventTarget generated bindings.
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
Set WindowPrototype's prototype to EventTarget's prototype.
- bindings/js/JSDOMWindowShell.h:
- bindings/js/JSDictionary.cpp:
Include "DOMWindow.h" to fix the build.
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::JSEventTarget::toWrapped):
Handle DOMWindow and WorkerGlobalScope explicitely in toWrapped()
and get rid of the DOM_EVENT_TARGET_INTERFACES_FOR_EACH(TRY_TO_UNWRAP_WITH_INTERFACE)
now that all interfaces inherit EventTarget when they should.
The reason DOMWindow and WorkerGlobalScope still need special
handling is because their wrappers (JSDOMWindow /
JSWorkerGlobalScope) do not subclass JSEventTarget.
(WebCore::JSEventTargetOrGlobalScope::create):
- bindings/js/JSEventTargetCustom.h: Added.
(WebCore::JSEventTargetOrGlobalScope::wrapped):
(WebCore::JSEventTargetOrGlobalScope::operator JSC::JSObject&):
(WebCore::JSEventTargetOrGlobalScope::JSEventTargetOrGlobalScope):
Add a wrapper type for JSEventTarget / JSDOMWindow and
JSWorkerGlobalScope for use in the generated bindings. This is
needed because JSDOMWindow and JSWorkerGlobalScope do not
subclass JSEventTarget. Subclassing JSEventTarget would be
complicated for them because they already subclass
JSDOMWindowBase / JSWorkerGlobalScopeBase, which subclasses
JSDOMGlobalObject.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initScript):
Set WorkerGlobalScopePrototype's prototype to EventTarget's prototype.
- bindings/scripts/CodeGeneratorJS.pm:
(ShouldGenerateToJSDeclaration):
Do not generate to toJS() implementation for interfaces that use
the [CustomProxyToJSObject] IDL extended attribute, even if they
inherit EventTarget.
(GetCastingHelperForThisObject):
To initialize castedThis from thisValue JSValue, we now use the
JSEventTargetOrGlobalScope wrapper for the EventTarget
implementation. This is to work around the fact that JSDOMWindow
and JSWorkerGlobalScope do not subclass JSEventTarget.
(GenerateFunctionCastedThis):
- Drop code handling [WorkerGlobalScope] IDL extended attribute as there is no such attribute.
- Use auto instead of auto* type for castedThis because JSEventTargetOrGlobalScope::create() returns a unique_ptr.
- Do not check that castedThis inherits JSEventTarget in the EventTarget bindings code as this no longer holds true.
(GenerateImplementation):
Generate frameless window() and security checks for EventTarget
methods when thisValue is a JSDOMWindow.
- dom/EventTarget.idl:
Add [JSCustomHeader] IDL Extended attribute as we need a header
to expose JSEventTargetOrGlobalScope class.
- page/DOMWindow.idl:
- workers/WorkerGlobalScope.idl:
Inherit EventTarget and stop duplicating the EventTarget API.
This matches the HTML specification.
LayoutTests:
- fast/frames/detached-frame-eventListener-expected.txt: Added.
- fast/frames/detached-frame-eventListener.html: Added.
Add test case to cover the use of the EventListener API on a detached
frame.
- fast/loader/window-clearing-expected.txt:
Rebaseline now that window has one more object in its prototype chain.
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
Add test coverage for cross-origin access to window.dispatchEvent() which
should not be allowed, in addition to window.addEventListener() and
window.removeEventListener() which were already tested.
- 5:42 PM Changeset in webkit [196562] by
-
- 7 edits in trunk/Source
WKAutomationDelegate's requestAutomationSession should take a suggested session identifier
https://bugs.webkit.org/show_bug.cgi?id=154012
<rdar://problem/24557697>
Reviewed by Darin Adler.
Source/JavaScriptCore:
Add a string parameter to the client method for requesting a new session.
- inspector/remote/RemoteInspector.h:
Source/WebKit2:
Add a string parameter to the delegate method for requesting a new session.
- UIProcess/API/APIAutomationClient.h:
(API::AutomationClient::didRequestAutomationSession):
(API::AutomationClient::requestAutomationSession): Deleted.
Rename the client method to better match the delegate method's name.
- UIProcess/API/Cocoa/_WKAutomationDelegate.h:
- UIProcess/Cocoa/AutomationClient.h:
- UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::AutomationClient):
(WebKit::AutomationClient::requestAutomationSession):
- 5:26 PM Changeset in webkit [196561] by
-
- 3 edits in trunk/Source/WebCore
Small tweaks to some SimpleLineLayout code
https://bugs.webkit.org/show_bug.cgi?id=154229
Reviewed by Zalan Bujtas.
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow): Use std::ceil instead of ceilf.
Use auto instead of const auto& for a for loop where the local object is
copied and not a reference.
(WebCore::SimpleLineLayout::hitTestFlow): Use modern for loop.
(WebCore::SimpleLineLayout::collectFlowOverflow): Use std::ceil instead of
ceilf. Use a modern for loop, and use slightly more descriptive local
variable names.
(WebCore::SimpleLineLayout::computeBoundingBox): Use auto instead of
const auto& as above.
(WebCore::SimpleLineLayout::computeFirstRunLocation): Use auto and use
the name "range" for the range rather than the name "it", since the range
is not an iterator.
(WebCore::SimpleLineLayout::collectAbsoluteRects): Use auto instead of
const auto& as above.
(WebCore::SimpleLineLayout::collectAbsoluteQuads): Ditto.
(WebCore::SimpleLineLayout::showLineLayoutForFlow): Use modern for loop.
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::text): Convert from a String
to a StringView using the StringView constructor instead of writing out
explicit 8-bit and 16-bit cases.
- 1:57 AM Changeset in webkit [196560] by
-
- 5 edits2 adds in trunk/Source/WebCore
Factor class change style invalidation code into a class
https://bugs.webkit.org/show_bug.cgi?id=154163
Reviewed by Andreas Kling.
Factor this piece of functionality out of Element and into ClassChangeInvalidation class.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::classStringHasClassName):
(WebCore::Element::classAttributeChanged):
(WebCore::collectClasses): Deleted.
(WebCore::computeClassChange): Deleted.
(WebCore::invalidateStyleForClassChange): Deleted.
- style/ClassChangeInvalidation.cpp: Added.
(WebCore::Style::ClassChangeInvalidation::computeClassChange):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):
- style/ClassChangeInvalidation.h: Added.
(WebCore::Style::ClassChangeInvalidation::needsInvalidation):
(WebCore::Style::ClassChangeInvalidation::ClassChangeInvalidation):
(WebCore::Style::ClassChangeInvalidation::~ClassChangeInvalidation):
Feb 13, 2016:
- 6:20 PM Changeset in webkit [196559] by
-
- 2 edits in trunk/Source/WebCore
[Win] [SVG -> OTF Converter] SVG fonts drawn into ImageBuffers are invisible
https://bugs.webkit.org/show_bug.cgi?id=154222
Reviewed by Antti Koivisto.
Windows ImageBuffer code is sensitive to broken bounding box and
descent code.
Covered by existing tests.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendHHEATable):
(WebCore::SVGToOTFFontConverter::appendOS2Table):
(WebCore::SVGToOTFFontConverter::processGlyphElement):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):
- 6:17 PM Changeset in webkit [196558] by
-
- 2 edits in trunk/Source/WebInspectorUI
Removed the unused Frameworks group.
Rubber-stamped by Sam Weinig.
- WebInspectorUI.xcodeproj/project.pbxproj:
- 5:47 PM Changeset in webkit [196557] by
-
- 2 edits in trunk/Websites/webkit.org
Adjust the appearance of mattewhite figures that are not widescreen.
- wp-content/themes/webkit/style.css:
(article .mattewhite:not(.widescreen):
- 2:48 PM Changeset in webkit [196556] by
-
- 2 edits in trunk/Websites/perf.webkit.org
v3 UI sometimes shows same dates twice on the x-axis of time series charts
https://bugs.webkit.org/show_bug.cgi?id=154210
Reviewed by Chris Dumez.
The bug was caused by the label generation code in TimeSeriesChart.computeTimeGrid never emitting hours.
Use hours instead of dates as labels when the current time's date is same as the previous label's date.
Always include dates before entering this mode to avoid just having hours as labels on the entire x-axis.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype._renderXAxis): Slightly increase the "average" width of x-axis label.
(TimeSeriesChart.computeTimeGrid): See above. Also assert that the number of labels we generate never
exceeds maxLabels as a sanity check.
(TimeSeriesChart._timeIterators): Added an iterator that increments by two hours for zoomed graphs.
- 2:45 PM Changeset in webkit [196555] by
-
- 6 edits in trunk/Source/WebCore
Add version number for default stylesheet
https://bugs.webkit.org/show_bug.cgi?id=154220
Reviewed by Ryosuke Niwa.
We currently fail to update RuleFeatureSets for shadow trees when the default stylesheet grows
(for example when media controls stylesheet is initialized).
No test since this is not causing known bugs. It is blocking optimizations in shadow trees that
rely on rule features being up-to-date.
- css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
Increment version number when the default stylesheet changes.
- css/CSSDefaultStyleSheets.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
(WebCore::DocumentRuleSets::collectFeatures):
Store the current default stylesheet version number.
- css/DocumentRuleSets.h:
(WebCore::DocumentRuleSets::features):
Collect features again if the default stylesheet has changed.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForElement):
- 2:39 PM Changeset in webkit [196554] by
-
- 3 edits in trunk/Source/WTF
Eliminate the need for WTFCrashImpl().
https://bugs.webkit.org/show_bug.cgi?id=154202
Reviewed by Alexey Proskuryakov.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 1:30 PM Changeset in webkit [196553] by
-
- 7 edits in trunk/Websites/perf.webkit.org
v3 UI should show status and associated bugs on analysis task pages
https://bugs.webkit.org/show_bug.cgi?id=154212
Reviewed by Chris Dumez.
Added the capability to see and modify the status and the list of associated of bugs on analysis task pages.
Also added the list of related tasks, which are analysis tasks associated with the same bug or have
overlapping time ranges with the same test metric but on a potentially different platform.
In addition, categorize analysis tasks with the status of "no change" or "inconclusive" as "closed" as no
further action can be taken (users can bring them back to non-closed state without any restrictions).
- public/api/analysis-tasks.php:
(format_task): Categorize 'unchanged' and 'inconclusive' analysis tasks as closed.
- public/privileged-api/associate-bug.php:
(main): Added shouldDelete as a new mechanism to disassociate a bug since v3 UI shares a single Bug object
between multiple analysis tasks (as it should have been in the first place).
- public/v3/components/chart-pane-base.js:
(ChartPaneBase):
(ChartPaneBase.prototype._fetchAnalysisTasks): Since each analysis task's change type (status/result) could
change, we need to create annotation objects during each render() call.
(ChartPaneBase.prototype.render):
(ChartPaneBase.prototype._renderAnnotations): Extracted from ChartPaneBase.prototype._fetchAnalysisTasks to
do that. I was afraid of the perf impact of this but it doesn't seem to be an issue in my testing.
(ChartPaneBase.cssTemplate): Removed superfluous margins (moved to ChartPane.cssTemplate) around the charts
since they are only useful in the charts page.
- public/v3/models/analysis-task.js:
(AnalysisTask):
(AnalysisTask.prototype.updateSingleton): Added a comment as to why object.result cannot be renamed to
object.changeType in the JSON API.
(AnalysisTask.prototype.updateName): Added.
(AnalysisTask.prototype.updateChangeType): Added.
(AnalysisTask.prototype._updateRemoteState): Added.
(AnalysisTask.prototype.associateBug): Added.
(AnalysisTask.prototype.disassociateBug): Added.
(AnalysisTask.fetchRelatedTasks): Added. See above for the criteria of related-ness.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage):
(AnalysisTaskPage.prototype.updateFromSerializedState):
(AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId): Extracted from updateFromSerializedState.
(AnalysisTaskPage.prototype._didFetchRelatedAnalysisTasks): Added.
(AnalysisTaskPage.prototype.render): Render the list of associated bugs, the list of bug trackers (so that
users can use it to associate with a new bug), and the list of related analysis tasks.
(AnalysisTaskPage.prototype._renderTestGroupList): Extracted from render since it was getting too long.
(AnalysisTaskPage.prototype._renderTestGroupDetails): Ditto.
(AnalysisTaskPage.prototype._updateChangeType): Added.
(AnalysisTaskPage.prototype._associateBug): Added.
(AnalysisTaskPage.prototype._disassociateBug): Added.
(AnalysisTaskPage.htmlTemplate): Added various elements to show and modify the status, associate bugs,
and a list of related analysis tasks.
(AnalysisTaskPage.cssTemplate): Added various styles for those form controls.
- public/v3/pages/chart-pane.js:
(ChartPane.cssTemplate): Moved the margins from ChartPaneBase.cssTemplate.
- 11:12 AM Changeset in webkit [196552] by
-
- 3 edits1 add in trunk/Source/WebCore
[cmake] Consolidate building of GStreamer and OpenWebRTC code.
https://bugs.webkit.org/show_bug.cgi?id=154116
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-13
Reviewed by Michael Catanzaro.
No new tests needed.
- PlatformEfl.cmake: Migrated shared code to GStreamer.cmake.
- PlatformGTK.cmake: Ditto.
- platform/GStreamer.cmake: Added.
- 9:41 AM Changeset in webkit [196551] by
-
- 7 edits in trunk/Source
Add thread violation checks to WebView public APIs.
https://bugs.webkit.org/show_bug.cgi?id=154183
Reviewed by Timothy Hatcher.
Source/WebCore:
No new tests. Just adding a new thread violation round.
- platform/ThreadCheck.h:
- platform/mac/ThreadCheck.mm:
- Adding WebCoreThreadViolationCheckRoundThree().
Source/WebKit/mac:
Re-landing r196527 with a newly added WebCoreThreadViolationCheckRoundThree().
Previously was using WebCoreThreadViolationCheckRoundTwo().
- Misc/WebKitVersionChecks.h:
- WebView/WebFrameView.mm:
(-[WebFrameView initWithFrame:]):
- WebView/WebView.mm:
(-[WebView setCustomTextEncodingName:]):
(-[WebView stringByEvaluatingJavaScriptFromString:]):
(-[WebView windowScriptObject]):
(-[WebView setGroupName:]):
(-[WebView setMainFrameURL:]):
(-[WebView mainFrameTitle]):
(-[WebView mainFrameIcon]):
(-[WebView setDrawsBackground:]):
(-[WebView setShouldUpdateWhileOffscreen:]):
- 5:38 AM Changeset in webkit [196550] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix WebAssembly bug URL in the feature list.
- features.json:
- 1:23 AM Changeset in webkit [196549] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: DataGrid Header Cells should have Context Menu for Sorting
https://bugs.webkit.org/show_bug.cgi?id=154050
Patch by Devin Rousso <Devin Rousso> on 2016-02-13
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.set sortOrder):
(WebInspector.DataGrid.prototype._toggledSortOrder):
Returns the opposite sort order from the current order.
(WebInspector.DataGrid.prototype._selectSortColumnAndSetOrder):
Changes the selected column to the one with the specified identifier and
then switches the sort order to the given order.
(WebInspector.DataGrid.prototype._headerCellClicked):
Moved logic for switching cells/sort-order to a separate function for
better reusability.
(WebInspector.DataGrid.prototype._contextMenuInHeader):
Adds context menu items on DataGrid header items to change the current
sort order to the specified order. If the context menu is on the selected
header item, only show the sort order that is not currently applied.
- 12:49 AM Changeset in webkit [196548] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ and hopefully EFL build after r196499.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Feb 12, 2016:
- 11:21 PM Changeset in webkit [196547] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change the last RefPtr::get() to release() in String.prototype.normalize
https://bugs.webkit.org/show_bug.cgi?id=154211
Reviewed by Ryosuke Niwa.
Change the last RefPtr::get() to release() in String.prototype.normalize.
- runtime/StringPrototype.cpp:
(JSC::normalize):
- 9:24 PM Changeset in webkit [196546] by
-
- 20 edits2 adds in trunk
AX: Implement paragraph related text marker functions using TextIterator
https://bugs.webkit.org/show_bug.cgi?id=154098
<rdar://problem/24269675>
Reviewed by Chris Fleizach.
Source/WebCore:
Using CharacterOffset to implement paragraph related text marker calls. Reused
logic from VisibleUnits class. And refactored textMarkerForCharacterOffset method
to get better performance. Also fixed an issue where we can't navigate through a text
node with line breaks in it using next/previousCharacterOffset call.
Test: accessibility/mac/text-marker-paragraph-nav.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::startOrEndTextMarkerDataForRange):
(WebCore::AXObjectCache::characterOffsetForNodeAndOffset):
(WebCore::AXObjectCache::textMarkerDataForCharacterOffset):
(WebCore::AXObjectCache::textMarkerDataForNextCharacterOffset):
(WebCore::AXObjectCache::textMarkerDataForPreviousCharacterOffset):
(WebCore::AXObjectCache::nextNode):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::previousCharacterOffset):
(WebCore::startWordBoundary):
(WebCore::AXObjectCache::startCharacterOffsetOfWord):
(WebCore::AXObjectCache::endCharacterOffsetOfWord):
(WebCore::AXObjectCache::previousWordStartCharacterOffset):
(WebCore::AXObjectCache::previousWordBoundary):
(WebCore::AXObjectCache::startCharacterOffsetOfParagraph):
(WebCore::AXObjectCache::endCharacterOffsetOfParagraph):
(WebCore::AXObjectCache::paragraphForCharacterOffset):
(WebCore::AXObjectCache::nextParagraphEndCharacterOffset):
(WebCore::AXObjectCache::previousParagraphStartCharacterOffset):
(WebCore::AXObjectCache::rootAXEditableElement):
- accessibility/AXObjectCache.h:
(WebCore::CharacterOffset::remaining):
(WebCore::CharacterOffset::isNull):
(WebCore::CharacterOffset::isEqual):
(WebCore::AXObjectCache::isNodeInUse):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(+[WebAccessibilityTextMarker textMarkerWithCharacterOffset:cache:]):
(-[WebAccessibilityObjectWrapper nextMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper previousMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(startOrEndTextmarkerForRange):
(nextTextMarkerForCharacterOffset):
(previousTextMarkerForCharacterOffset):
(-[WebAccessibilityObjectWrapper nextTextMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper previousTextMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper textMarkerForCharacterOffset:]):
(textMarkerForCharacterOffset):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper nextTextMarkerForNode:offset:]): Deleted.
(-[WebAccessibilityObjectWrapper previousTextMarkerForNode:offset:]): Deleted.
(-[WebAccessibilityObjectWrapper textMarkerForNode:offset:ignoreStart:]): Deleted.
(-[WebAccessibilityObjectWrapper textMarkerForNode:offset:]): Deleted.
- editing/VisibleUnits.cpp:
(WebCore::nextSentencePosition):
(WebCore::findStartOfParagraph):
(WebCore::findEndOfParagraph):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- editing/VisibleUnits.h:
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(nextWordEndTextMarkerForTextMarkerCallback):
(paragraphTextMarkerRangeForTextMarkerCallback):
(previousParagraphStartTextMarkerForTextMarkerCallback):
(nextParagraphEndTextMarkerForTextMarkerCallback):
(setSelectedVisibleTextRangeCallback):
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
(WTR::_convertMathMultiscriptPairsToString):
LayoutTests:
- accessibility/mac/text-marker-paragraph-nav-expected.txt: Added.
- accessibility/mac/text-marker-paragraph-nav.html: Added.
- accessibility/text-marker/text-marker-previous-next-expected.txt:
- accessibility/text-marker/text-marker-previous-next.html:
- 8:52 PM Changeset in webkit [196545] by
-
- 7 edits in trunk
[ES6] we have an incorrect syntax error when a callee of a function expression has the same name as a top-level lexical declaration
https://bugs.webkit.org/show_bug.cgi?id=154143
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
We were raising syntax errors on the following type of programs when
we shouldn't have been.
`
(function foo() { const foo = 20; });
`
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
- parser/Parser.h:
(JSC::Scope::computeLexicallyCapturedVariablesAndPurgeCandidates):
(JSC::Scope::declareCallee):
(JSC::Scope::declareVariable):
(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::hasLexicallyDeclaredVariable):
(JSC::Scope::hasDeclaredParameter):
(JSC::Scope::declareWrite):
(JSC::Scope::getCapturedVars):
LayoutTests:
- js/basic-strict-mode-expected.txt:
- js/let-syntax-expected.txt:
- js/script-tests/let-syntax.js:
- 8:48 PM Changeset in webkit [196544] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] ZeroExtend and SignExtend use incorrect addressing on ARM64
https://bugs.webkit.org/show_bug.cgi?id=154208
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-02-12
Reviewed by Filip Pizlo.
When lowering:
@1 = Load32(@x)
@2 = SExt8(@1)
LowerToAir would see there is a form of SignExtend8To32 (an alias for Load8S)
and use that.
There are two problems with that:
1) If we have an Addr, it went through legalizeMemoryOffsets() for a 32bits
load. If used on an other kind of load, there is no guarantee the addressing
is still valid.
2) If we have an Index, it is computed for the 32bits MemoryValue.
The computed index is not valid for the 8bits load.
(2) could be fixed by changing LowerToAir to use the current instruction width
instead of the B3ValueWidth but that's a bit tricky. We should just embrace
that one of our target is a Load-Store architecture.
In this patch, I just disabled the faulty forms on ARM64. We still need those operations
to be fast, this will be addressed in: https://bugs.webkit.org/show_bug.cgi?id=154207
I also strengthened the m_allowScratchRegister assertion. The instructions that do not
invalidate the temporary did not run the assertion, making this harder to debug.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::load8):
(JSC::MacroAssemblerARM64::store64):
(JSC::MacroAssemblerARM64::store32):
(JSC::MacroAssemblerARM64::loadDouble):
(JSC::MacroAssemblerARM64::storeDouble):
(JSC::MacroAssemblerARM64::branch32):
(JSC::MacroAssemblerARM64::branch64):
(JSC::MacroAssemblerARM64::getCachedDataTempRegisterIDAndInvalidate):
(JSC::MacroAssemblerARM64::getCachedMemoryTempRegisterIDAndInvalidate):
(JSC::MacroAssemblerARM64::dataMemoryTempRegister):
(JSC::MacroAssemblerARM64::cachedMemoryTempRegister):
(JSC::MacroAssemblerARM64::load):
(JSC::MacroAssemblerARM64::store):
- b3/air/AirOpcode.opcodes:
- 7:18 PM Changeset in webkit [196543] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 7:13 PM Changeset in webkit [196542] by
-
- 2 edits in trunk/Websites/webkit.org
Add a CSS class to remove padding when using mattewhite class for figures
https://bugs.webkit.org/show_bug.cgi?id=154206
Reviewed by Filip Pizlo.
- wp-content/themes/webkit/style.css:
(article .two-columns):
(article .two-columns h6):
(article .two-columns p):
(article .mattewhite):
(article .mattewhite.tightwad):
(article figure):
- 6:37 PM Changeset in webkit [196541] by
-
- 8 edits in trunk/Source/JavaScriptCore
offlineasm: Emit Dwarf2 file and location directives to allow for debugging .asm files
https://bugs.webkit.org/show_bug.cgi?id=152703
Reviewed by Mark Lam.
Added support to output Dwarf2 .file and .loc assembler directives to provide the debugging
information needed to correlate the offline assembler generated code with the source lines
in the .asm files.
Changed the tracking of file data to include a file index that was provided to the .file
directive. That index is used when emitting the .loc directives.
- offlineasm/arm.rb:
- offlineasm/arm64.rb:
- offlineasm/asm.rb:
- offlineasm/backends.rb:
- offlineasm/config.rb:
- offlineasm/parser.rb:
- offlineasm/x86.rb:
- 6:07 PM Changeset in webkit [196540] by
-
- 1 copy in tags/Safari-601.5.17
New tag.
- 6:00 PM Changeset in webkit [196539] by
-
- 1 edit14 adds in trunk/Websites/webkit.org
Unreviewed, upload some blog files.
- blog-files/compile-times.png: Added.
- blog-files/fast-isel.png: Added.
- blog-files/jetstream-latency.png: Added.
- blog-files/jetstream-throughput.png: Added.
- blog-files/jetstream.png: Added.
- blog-files/kraken.png: Added.
- blog-files/low-compile-times.png: Added.
- blog-files/low-fast-isel.png: Added.
- blog-files/low-jetstream-latency.png: Added.
- blog-files/low-jetstream-throughput.png: Added.
- blog-files/low-jetstream.png: Added.
- blog-files/low-kraken.png: Added.
- blog-files/low-octane.png: Added.
- blog-files/octane.png: Added.
- 5:49 PM Changeset in webkit [196538] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, build fix after r196520
- inspector/model/remote-object-get-properties-expected.txt:
- platform/mac/inspector/model/remote-object-expected.txt:
- 5:39 PM Changeset in webkit [196537] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 5:10 PM Changeset in webkit [196536] by
-
- 5 edits in trunk/Source/bmalloc
BASSERTs added in r196421 are causing debug test failures
https://bugs.webkit.org/show_bug.cgi?id=154113
Reviewed by Geoffrey Garen.
In VMHeap::deallocateLargeObject(), we drop the lock to deallocate the physical pages.
If the scavenger thread is running at the same time a synchronous call to scavenge()
comes in, we could call VMHeap::deallocateLargeObject() for an adjacent object while the
lock in the other thread is dropped. We fix this by checking for adjacent objects we
can merge with and loop if we have one.
- bmalloc/FreeList.h:
(bmalloc::FreeList::push): Added BASSERT to catch adding unmerged free objects
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateLarge): Changed to use nextCanMerge().
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::prevCanMerge): Repurposed prevIsAllocated.
(bmalloc::LargeObject::nextCanMerge): Repurposed nextIsAllocated.
(bmalloc::LargeObject::prevIsAllocated): Deleted.
(bmalloc::LargeObject::nextIsAllocated): Deleted.
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateLargeObject): Moved adding the extra object back to the free list
to after we set the object we'll return as being allocated.
(bmalloc::VMHeap::deallocateLargeObject):
- 5:05 PM Changeset in webkit [196535] by
-
- 3 edits in trunk/Source/bmalloc
Make BCRASH() use breakpoint traps too for non-debug OS(DARWIN).
https://bugs.webkit.org/show_bug.cgi?id=154184
Reviewed by Saam Barati.
This makes it behave consistently with WTFCrash().
- bmalloc/BAssert.h:
- bmalloc/BPlatform.h:
- 4:42 PM Changeset in webkit [196534] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196520
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 4:40 PM Changeset in webkit [196533] by
-
- 1 copy in tags/Safari-601.1.46.99
New tag.
- 4:36 PM Changeset in webkit [196532] by
-
- 3 edits in trunk/Source/WebCore
Reset results for bindings tests after r196520
Unreviewed test gardening.
No new tests needed.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(webkit_dom_test_node_dispatch_event):
- 4:36 PM Changeset in webkit [196531] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed, rolling out r196527.
https://bugs.webkit.org/show_bug.cgi?id=154204
"Need to redo as WebCoreThreadViolationCheckRoundThree"
(Requested by mlam on #webkit).
Reverted changeset:
"Add thread violation checks to WebView public APIs."
https://bugs.webkit.org/show_bug.cgi?id=154183
http://trac.webkit.org/changeset/196527
- 4:32 PM Changeset in webkit [196530] by
-
- 2 edits in trunk/Source/WebCore
Attempting build fix from https://bugs.webkit.org/show_bug.cgi?id=154144.
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
- 4:30 PM Changeset in webkit [196529] by
-
- 15 edits in branches/safari-601-branch/Source
Merge patch for rdar://problem/24626412.
- 4:24 PM Changeset in webkit [196528] by
-
- 4 edits4 adds2 deletes in trunk
CSP: 'blob:' URLs should not match 'self' in CSP source expression lists.
https://bugs.webkit.org/show_bug.cgi?id=153158
<rdar://problem/24383264>
Reviewed by Brent Fulgham.
Source/WebCore:
A blob URL should not match source 'self' by section Security Considerations for GUID URL schemes
of the Content Security Policy 2.0 spec., <https://www.w3.org/TR/CSP2/> (21 July 2015).
Tests: http/tests/security/contentSecurityPolicy/blob-url-does-not-match-source-self.html
http/tests/security/contentSecurityPolicy/blob-url-matches-source-blob.html
- page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::ContentSecurityPolicySourceList::matches): Do not make a distinction between URLs that
contain a nested URL (e.g. blob://http://www.example.com/...) and URLs that do not contain a nested
URL. The URL of the requested resource should be matched against the source list source expressions.
LayoutTests:
Add test http/tests/security/contentSecurityPolicy/blob-url-matches-source-blob.html to ensure that a
blob URL matches source "blob:".
Replaced text-only test http/tests/security/contentSecurityPolicy/blob-urls-match-self.html with an
analogous reference test http/tests/security/contentSecurityPolicy/blob-url-does-not-match-source-self.html
so as ensure that we do not regress the behavior that source 'self' should not match a blob URL
without considering the Content Security Policy violation message as part of the expected result.
The Content Security Policy violation message will differ between test runs because it references
the blob URL that triggered the violation, which is cryptographically random.
- TestExpectations: Remove entry for test http/tests/security/contentSecurityPolicy/blob-urls-match-self.html as the analogous test
blob-url-does-not-match-source-self.htm now passes.
- http/tests/security/contentSecurityPolicy/blob-url-does-not-match-source-self-expected.html: Added.
- http/tests/security/contentSecurityPolicy/blob-url-does-not-match-source-self.html: Added.
- http/tests/security/contentSecurityPolicy/blob-url-matches-source-blob-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/blob-url-matches-source-blob.html: Added.
- http/tests/security/contentSecurityPolicy/blob-urls-match-self-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/blob-urls-match-self.html: Removed. See the analogous test blob-url-does-not-match-source-self.html.
- 4:22 PM Changeset in webkit [196527] by
-
- 2 edits in trunk/Source/WebKit/mac
Add thread violation checks to WebView public APIs.
https://bugs.webkit.org/show_bug.cgi?id=154183
Reviewed by Geoffrey Garen.
This will help clients of the API detect the violations sooner rather than
having to debug mysterious crashes / failures later.
To that end, I've added thread violation checks to the following functions
because ...
- WebView/WebView.mm:
(-[WebView setCustomTextEncodingName:]):
- Uses the FrameLoader (which is for the main thread only).
(-[WebView stringByEvaluatingJavaScriptFromString:]):
- Invokes JavaScript (which is for the main thread only).
(-[WebView windowScriptObject]):
- Invokes ScriptController::windowScriptObject() which requires the JSLock.
(-[WebView setGroupName:]):
- Manipulates the PageGroup and Page (which is for the main thread only).
(-[WebView setMainFrameURL:]):
- Uses the FrameLoader (which is for the main thread only).
(-[WebView mainFrameTitle]):
- Uses the FrameLoader::documentLoader() (via [WebFrame _dataSource]) which is RefPtr, and therefore not safe for other threads to access.
(-[WebView mainFrameIcon]):
- Uses the FrameLoader::documentLoader() (via [WebFrame _dataSource]) which is RefPtr, and therefore not safe for other threads to access.
- Uses [WebIconDatabase sharedIconDatabase] which does a singleton instantiation but is not protected by a lock.
(-[WebView setDrawsBackground:]):
- Potentially manipulates a RenderView (via FrameView::setBaseBackgroundColor, via [WebFrame _updateBackgroundAndUpdatesWhileOffscreen]), and RenderView is for main thread only use.
(-[WebView setShouldUpdateWhileOffscreen:]):
- Uses [WebFrame _updateBackgroundAndUpdatesWhileOffscreen]. Hence, for the main thread only.
- 4:18 PM Changeset in webkit [196526] by
-
- 34 edits5 copies5 adds4 deletes in trunk
CSP: Implement child-src directive
https://bugs.webkit.org/show_bug.cgi?id=153562
<rdar://problem/24610087>
Reviewed by Brent Fulgham.
Source/WebCore:
Add support for the child-src directive, <https://w3c.github.io/webappsec-csp/2/#child_src> (29 August 2015),
which formally replaces the deprecated frame-src directive as of the Content Security Policy 2.0 spec. The
child-src directive was first introduced in the Content Security Policy 1.1 spec, <https://www.w3.org/TR/2014/WD-CSP11-20140211/>.
As a side effect of this change, the script URL for a Web Worker is checked against the child-src directive
as opposed to the script-src directive. This is a backward incompatible change from the CSP 1.0 spec.
Tests: http/tests/security/contentSecurityPolicy/1.1/child-src/frame-fires-load-event-when-blocked.html
http/tests/security/contentSecurityPolicy/1.1/child-src/frame-fires-load-event-when-redirect-blocked.html
http/tests/security/contentSecurityPolicy/1.1/child-src/frame-src-takes-precedence-over-child-src.html
http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked.html
http/tests/security/isolatedWorld/bypass-main-world-csp-worker-redirect.html
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy): Check child-src directive (if applicable).
- loader/ThreadableLoader.h: Add enum value EnforceChildSrcDirective to enum class ContentSecurityPolicyEnforcement to
enforce the child-src directive on redirect.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowChildContextFromSource): Added.
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::checkSourceAndReportViolation): Add message prefix for a child-src violation.
We use the same message prefix as used by Blink.
(WebCore::ContentSecurityPolicyDirectiveList::allowChildContextFromSource): Added.
(WebCore::ContentSecurityPolicyDirectiveList::allowChildFrameFromSource): Modified to check the frame-src
directive (if specified) before checking the child-src directive by <https://w3c.github.io/webappsec-csp/2/#directive-child-src-nested>.
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Parse the child-src directive.
- page/csp/ContentSecurityPolicyDirectiveList.h:
- workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL): Check if the script URL for the worker is allowed by the child-src directive
as opposed to the script-src directive. This is a backwards incompatible change from the CSP 1.0 spec.
- workers/Worker.cpp:
(WebCore::Worker::create): Enforce the child-src directive on redirects (if applicable).
LayoutTests:
Add new tests, un-skip now passing tests and update incorrect expected result for test http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked.html.
- TestExpectations: Remove entry for test http/tests/security/contentSecurityPolicy/worker-script-src.html as it now passes.
Mark all tests in http/tests/security/contentSecurityPolicy/1.1/child-src as PASS so that we run them except for tests
frame-fires-load-event-when-blocked.html and frame-fires-load-event-when-redirect-blocked.html (formerly named frame-blocked.html
and frame-redirect-blocked.html, respectively) as they depend on the fix for <https://bugs.webkit.org/show_bug.cgi?id=153150>.
Skip all other CSP 1.1 tests until we fix <https://bugs.webkit.org/show_bug.cgi?id=85558>. Group some CSP 1.1 entries together.
- fast/workers/worker-inherits-csp-blocks-eval-expected.txt: Update expected result based on change to worker-inherits-csp-blocks-eval.html.
- fast/workers/worker-inherits-csp-blocks-eval.html: Remove source 'self' from script-src directive. This was needed as
a workaround for <https://bugs.webkit.org/show_bug.cgi?id=153158> when the script URL for a worker was checked against the
script-src directive. Now that the script URL is checked against the child-src directive we do not need this workaround.
- fast/workers/worker-inherits-csp-blocks-xhr.html: Ditto.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed.html: Use js-test-{pre, post}.js as opposed to
js-test.js to avoid duplicate "TEST COMPLETE" output.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed.html: Ditto.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked-expected.txt: Update expected result based on changes to frame-blocked.html.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html: Update test to work without the fix for <https://bugs.webkit.org/show_bug.cgi?id=153150>.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-fires-load-event-when-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-fires-load-event-when-blocked.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html.
Keep a copy of the original test for when we fix <https://bugs.webkit.org/show_bug.cgi?id=153150>.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-fires-load-event-when-redirect-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-fires-load-event-when-redirect-blocked.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html.
Keep a copy of the original test for when we fix <https://bugs.webkit.org/show_bug.cgi?id=153150>.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked-expected.txt: Update expected result based on changes to frame-redirect-blocked.html.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html: Update test to work without the fix for <https://bugs.webkit.org/show_bug.cgi?id=153150>.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-src-takes-precedence-over-child-src-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-src-takes-precedence-over-child-src.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-allowed.html: Use js-test-{pre, post}.js as opposed to
js-test.js to avoid duplicate "TEST COMPLETE" output.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked-expected.txt: Update incorrect expected result to
reflect WebKit error message. The current result reflects the error message used by Blink.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked.html: Use js-test-{pre, post}.js as opposed to
js-test.js to avoid duplicate "TEST COMPLETE" output.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed-expected.txt: Removed; WebKit does not support shared Web Workers.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed.html: Removed; WebKit does not support shared Web Workers.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-blocked-expected.txt: Removed; WebKit does not support shared Web Workers.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-blocked.html: Removed; WebKit does not support shared Web Workers.
- http/tests/security/contentSecurityPolicy/resources/child-src-test.js: Remove logic for testing shared Web Workers as WebKit does not support such workers.
(window.onload): Deleted.
(injectSharedWorker): Deleted.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval-expected.txt: Update expected result based on change to worker-blob-inherits-csp-blocks-eval.html.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html: Remove source 'self' from script-src directive.
This was needed as a workaround for <https://bugs.webkit.org/show_bug.cgi?id=153158> when the script URL for a worker was checked
against the script-src directive. Now that the script URL is checked against the child-src directive we do not need this workaround.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports-expected.txt: Update
expected result based on change to worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports.html.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports.html:
Remove source 'self' from script-src directive. This was needed as a workaround for <https://bugs.webkit.org/show_bug.cgi?id=153158> when
the script URL for a worker was checked against the script-src directive. Now that the script URL is checked against the child-src directive
we do not need this workaround.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html: Ditto.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html: Add child-src 'none' and remove FIXME comment.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-redirect-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-redirect.html: Added.
- platform/ios-simulator/TestExpectations: Remove skip entry for tests in http/tests/security/contentSecurityPolicy/1.1 from this file.
Instead we will skip these tests from LayoutTests/TestExpectations since they fail for all ports.
- platform/mac/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- platform/wk2/TestExpectations: Ditto.
- 4:12 PM Changeset in webkit [196525] by
-
- 18 edits in trunk/Source
The parser doesn't properly protect against global variable references in builtins
https://bugs.webkit.org/show_bug.cgi?id=154144
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch fixes our global variable reference detection
algorithm that was broken. After fixing the algorithm, I
detected many places where we were incorrectly using global
variables. I've fixed all those.
- builtins/BuiltinExecutables.cpp:
(JSC::createExecutableInternal):
- builtins/NumberPrototype.js:
(toLocaleString):
- builtins/PromiseConstructor.js:
(race):
(reject):
(resolve):
- parser/Nodes.cpp:
(JSC::ProgramNode::ProgramNode):
(JSC::ModuleProgramNode::ModuleProgramNode):
(JSC::ProgramNode::setClosedVariables): Deleted.
- parser/Nodes.h:
(JSC::ScopeNode::setClosedVariables): Deleted.
(JSC::ProgramNode::closedVariables): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::didFinishParsing):
- parser/Parser.h:
(JSC::Scope::setIsLexicalScope):
(JSC::Scope::isLexicalScope):
(JSC::Scope::closedVariableCandidates):
(JSC::Scope::declaredVariables):
(JSC::Scope::lexicalVariables):
(JSC::Scope::finalizeLexicalEnvironment):
(JSC::Parser::positionBeforeLastNewline):
(JSC::Parser::locationBeforeLastToken):
(JSC::Parser::isFunctionMetadataNode):
(JSC::parse):
(JSC::Parser::closedVariables): Deleted.
Source/WebCore:
Change JS builtins to no longer reference global variables.
No new tests because old tests cover the issues here.
- Modules/mediastream/NavigatorUserMedia.js:
(webkitGetUserMedia):
- Modules/mediastream/RTCPeerConnection.js:
(addIceCandidate):
(getStats):
- Modules/mediastream/RTCPeerConnectionInternals.js:
(setLocalOrRemoteDescription):
- Modules/plugins/QuickTimePluginReplacement.js:
(Replacement.prototype.handleEvent):
- Modules/streams/ByteLengthQueuingStrategy.js:
(initializeByteLengthQueuingStrategy):
- Modules/streams/CountQueuingStrategy.js:
(initializeCountQueuingStrategy):
- Modules/streams/ReadableStreamInternals.js:
(teeReadableStream):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
- bindings/js/WebCoreBuiltinNames.h:
- 4:07 PM Changeset in webkit [196524] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSObject::putByIndexBeyondVectorLengthWithoutAttributes needs to go to the sparse map based on MAX_STORAGE_VECTOR_INDEX
https://bugs.webkit.org/show_bug.cgi?id=154201
rdar://problem/24291387
Reviewed by Saam Barati.
I decided against adding a test for this, because it runs for a very long time.
- runtime/JSObject.cpp:
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes): Fix the bug.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit): Fix a related bug: if this code creates an array that would have
hit the above bug, then it would probably manifest as a spin or as swapping.
- 4:06 PM Changeset in webkit [196523] by
-
- 3 edits in trunk/LayoutTests
Re-enable skipped animations tests on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=152131
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 3:34 PM Changeset in webkit [196522] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add WebAssembly to the status page
https://bugs.webkit.org/show_bug.cgi?id=154199
Reviewed by Timothy Hatcher.
- features.json:
- 3:33 PM Changeset in webkit [196521] by
-
- 10 edits2 adds in trunk/Websites/perf.webkit.org
Perf dashboard should allow renaming analysis tasks and test groups
https://bugs.webkit.org/show_bug.cgi?id=154200
Reviewed by Chris Dumez.
Allow editing names of analysis tasks and A/B testing groups in the v3 UI.
Added the support for updating the name to the privileged API at /privileged-api/update-analysis-task
and added a new prevailed API to update A/B testing groups at /privileged-api/update-test-group.
- public/privileged-api/update-analysis-task.php: Added the support for renaming the analysis task.
(main):
- public/privileged-api/update-test-group.php: Added. Supports updating the test group's name.
(main):
- public/v3/components/editable-text.js: Added.
(EditableText): Added. A new editable text label control. It looks like a text node with "(Edit)" link
at the end which allow users to go into the "editing mode", which reveals an input element.
The user can exit the editing mode by either moving the focus away from the control or clicking on
"(Save)" at the end. It calls _updateCallback in the latter case.
(EditableText.prototype.editedText): Returns the current value of the input element user.
(EditableText.prototype.setText): Sets the label. This does not live-update the input element until
the user exists the current editing mode and re-enters it.
(EditableText.prototype.setStartedEditingCallback): Sets a callback which gets called when the user
requested to enter the editing mode. Since EditableText relies on AnalysisTaskPage to render, this
callback only exits to call EditableText.render() in AnalysisTask._didStartEditingTaskName.
(EditableText.prototype.setUpdateCallback): Sets a callback which gets called when the user exits
the editing mode by activating the "(Save)" link. This callback MUST return a promise upon resolution
of which the control gets out of the editing mode. While the promise is in flight, the input element
becomes readonly.
(EditableText.prototype.render): Updates various states of the elements. When _updatingPromise is not
falsy, we make the input element readonly and show '(...)' on the link. Don't show the action link
if the label is empty (e.g. analysis task or test group is still being fetched).
(EditableText.prototype._didClick): Called when the user clicked on the action link. Enter the editing
mode or save the edited label via _updateCallback.
(EditableText.prototype._didBlur): Exit the editing mode without saving if the input element is not
focused, there is no inflight promise returned by _updateCallback, and the action link "(Save)" does
not have the focus.
(EditableText.prototype._didUpdate): Called when exiting the editing mode.
(EditableText.htmlTemplate):
(EditableText.cssTemplate):
- public/v3/index.html: Include newly added editable-text.js.
- public/v3/models/analysis-task.js:
(AnalysisTask.prototype.updateSingleton): Added.
(AnalysisTask.prototype.updateName): Added. Uses PrivilegedAPI to update the name and re-fetches
the analysis task from the sever.
(AnalysisTask._constructAnalysisTasksFromRawData): Use ensureSingleton instead of manually calling
findById since we need to update the name of the singleton object we found (via updateSingleton).
- public/v3/models/bug.js:
(Bug.ensureSingleton): Moved the code to compute the synthetic id from AnalysisTask's
_constructAnalysisTasksFromRawData.
(Bug.prototype.updateSingleton): Added. Just assert that nothing changes.
- public/v3/models/build-request.js:
(BuildRequest.prototype.updateSingleton): Added. Assert that the intrinsic values of a build request
doesn't change and update status text, status url, and build id as they could change.
- public/v3/models/commit-log.js:
(CommitLog): Made the constructor argument conform to the convention of id, object pair so that we can
use DataModelObject.ensureSingleton.
(CommitLog.ensureSingleton):
(CommitLog.prototype.updateSingleton): Extracted from CommitLog.ensureSingleton.
- public/v3/models/data-model.js:
(DataModelObject.ensureSingleton): Call newly added updateSingleton.
(DataModelObject.prototype.updateSingleton):
(LabeledObject): Removed the name map since it's never used (findByName is never called anywhere).
(LabeledObject.prototype.updateSingleton): Added. Updates _name.
(LabeledObject.findByName): Deleted.
- public/v3/models/test-group.js:
(TestGroup.prototype.updateName): Added. Uses PrivilegedAPI to update the name and re-fetches
the test group from the sever.
(TestGroup._createModelsFromFetchedTestGroups): Removed bogus code. A root set doesn't have a test
group associated with it since multiple test groups can share a single root set (this property doesn't
even exist).
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage): Removed useless _taskId and added this._testGroupLabelMap and this._taskNameLabel.
(AnalysisTaskPage.prototype.updateFromSerializedState): Cleanup.
(AnalysisTaskPage.prototype._didFetchTask): Assert that this function is called exactly once.
(AnalysisTaskPage.prototype.render): Use this._task.id() to show the v2 link. Use EditableText to show
the names of the analysis task and the associated test groups. Hide the overview chart and the list of
test groups (along with the retry/confirm button) when the analysis task failed to fetch. We always
update the names of the analysis task and the associated test groups since they could be updated by
the server.
(AnalysisTaskPage.prototype._didStartEditingTaskName): Added.
(AnalysisTaskPage.prototype._updateTaskName): Added.
(AnalysisTaskPage.prototype._updateTestGroupName): Added.
(AnalysisTaskPage.htmlTemplate): Updated the style.
- 3:25 PM Changeset in webkit [196520] by
-
- 27 edits2 adds in trunk
WebKit should expose the DOM 4 Event.isTrusted property
https://bugs.webkit.org/show_bug.cgi?id=76121
<rdar://problem/22558494>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/dom/events/Event-constructors-expected.txt:
- web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt:
- web-platform-tests/dom/events/Event-initEvent-expected.txt:
- web-platform-tests/dom/events/ProgressEvent-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/forms/the-button-element/button-events-expected.txt:
Source/WebCore:
Implements Event.isTrusted. The implementation here is slitely different from and better than
the DOM specification. Here Event.isTrusted will be initialized differently depending on the
callers of the constructors/create methods. If the caller is from user agent, the isTrusted
will be true. Otherwise, it will be false. Since a user agent dispatched event can be catched
and re-initialized/redispatched by the bindings, the flag will be unset at *Event::init*Event
and EventTarget::dispatchEventForBindings. As currently there is no way to let user agent to
dispatch a bindings created event, therefore we ensure that the Event.isTrusted is set for
events dispatched by user agent, and unset for those by bindings.
EventTarget::dispatchEvent(Event*, ExceptionCode&) is renamed to EventTarget::dispatchEventForBindings
in this patch as well. So that, together with the improved design of the API, developers in
the future will be less likely using a wrong dispatchEvent method and setting Event.isTrusted
incorrectly comparing to the DOM design.
After this patch, all events that are created by user agent should be dispatched by
EventTarget::dispatchEvent, and those are created by bindings should be dispatched by
EventTarget::dispatchEventForBindings.
Some of the changes in this patch referred Blink r198996:
https://codereview.chromium.org/1241613004
Test: imported/blink/fast/events/event-trusted.html
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateEventTargetIface):
- dom/Event.cpp:
(WebCore::Event::Event):
(WebCore::Event::initEvent):
- dom/Event.h:
(WebCore::Event::isTrusted):
(WebCore::Event::setUntrusted):
- dom/Event.idl:
- dom/EventTarget.cpp:
(WebCore::EventTarget::dispatchEventForBindings):
(WebCore::EventTarget::dispatchEvent): Deleted.
- dom/EventTarget.h:
- dom/EventTarget.idl:
- page/DOMWindow.idl:
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
- workers/WorkerGlobalScope.idl:
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMNode::dispatchEvent):
(DOMWindow::dispatchEvent):
LayoutTests:
- fast/dom/unforgeable-attributes-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- http/tests/workers/worker-importScriptsOnError-expected.txt:
- imported/blink/fast/events/event-trusted-expected.txt: Added.
- imported/blink/fast/events/event-trusted.html: Added.
- platform/ios-simulator/TestExpectations:
- 3:16 PM Changeset in webkit [196519] by
-
- 6 edits in trunk/Source/WebCore
Modern IDB: IDBObjectStore and IDBIndex need to be ActiveDOMObjects.
https://bugs.webkit.org/show_bug.cgi?id=154153
Reviewed by Alex Christensen.
No new tests (No testable change in behavior).
This is needed so that IDBObjectStore and IDBIndex JS wrappers are not garbage collected
while their IDBTransaction is still in progress.
- Modules/indexeddb/client/IDBIndexImpl.cpp:
(WebCore::IDBClient::IDBIndex::IDBIndex):
(WebCore::IDBClient::IDBIndex::activeDOMObjectName):
(WebCore::IDBClient::IDBIndex::canSuspendForDocumentSuspension):
(WebCore::IDBClient::IDBIndex::hasPendingActivity):
- Modules/indexeddb/client/IDBIndexImpl.h:
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::create):
(WebCore::IDBClient::IDBObjectStore::IDBObjectStore):
(WebCore::IDBClient::IDBObjectStore::activeDOMObjectName):
(WebCore::IDBClient::IDBObjectStore::canSuspendForDocumentSuspension):
(WebCore::IDBClient::IDBObjectStore::hasPendingActivity):
(WebCore::IDBClient::IDBObjectStore::index):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::objectStore):
(WebCore::IDBClient::IDBTransaction::createObjectStore):
(WebCore::IDBClient::IDBTransaction::createIndex):
- 3:01 PM Changeset in webkit [196518] by
-
- 6 edits5 adds in trunk
Modern IDB: Simplify the relationship between IDBObjectStore and IDBIndex.
https://bugs.webkit.org/show_bug.cgi?id=154187
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/deleteindex-3-private.html
storage/indexeddb/modern/deleteindex-3.html
Instead of allowing IDBIndex to have two different lifecycle modes, it is now always
owned by an IDBObjectStore.
To support the case where an IDBIndex is deleted from its IDBObjectStore, the object
store simply hangs on to deleted indexes until it is destroyed itself.
- Modules/indexeddb/client/IDBIndexImpl.cpp:
(WebCore::IDBClient::IDBIndex::markAsDeleted):
(WebCore::IDBClient::IDBIndex::ref):
(WebCore::IDBClient::IDBIndex::deref):
- Modules/indexeddb/client/IDBIndexImpl.h:
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::deleteIndex):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
LayoutTests:
- storage/indexeddb/modern/deleteindex-3-expected.txt: Added.
- storage/indexeddb/modern/deleteindex-3-private-expected.txt: Added.
- storage/indexeddb/modern/deleteindex-3-private.html: Added.
- storage/indexeddb/modern/deleteindex-3.html: Added.
- storage/indexeddb/modern/resources/deleteindex-3.js: Added.
- 2:44 PM Changeset in webkit [196517] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Rename domAgent to domTreeManager in DOMNode
https://bugs.webkit.org/show_bug.cgi?id=154194
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-12
Reviewed by Timothy Hatcher.
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode):
- 2:37 PM Changeset in webkit [196516] by
-
- 2 edits in trunk/Tools
Open source bot watcher's dashboard fails assertion in BuildbotQueue.prototype.compareIterationsByRevisions
https://bugs.webkit.org/show_bug.cgi?id=154180
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Remove reference to Internal
repository.
- 2:35 PM Changeset in webkit [196515] by
-
- 8 edits in trunk/Source/JavaScriptCore
Web Inspector: disambiguate the various identifier and connection types in RemoteInspector
https://bugs.webkit.org/show_bug.cgi?id=154130
Reviewed by Joseph Pecoraro.
There are multiple identifier types:
- connection identifier, a string UUID for a remote debugger process.
- session identifier, a string UUID for a remote driver/debugger instance.
- page/target identifier, a number unique within a single process.
There are multiple connection types:
- RemoteInspectorXPCConnection, a connection from RemoteInspectorXPCConnectionor to a relay.
- RemoteConnectionToTarget, a class that bridges to targets' dispatch queues.
Use consistent variable and getter names so that these don't get confused and
so that the code is easier to read. This is especially an improvement when working
with multiple target types or connection types within the same function.
- inspector/remote/RemoteConnectionToTarget.h:
- inspector/remote/RemoteConnectionToTarget.mm:
Remove the member for m_identifier since we can ask the target for its target identifier
or use a default value via WTF::Optional. There's no reason to cache the value.
(Inspector::RemoteTargetHandleRunSourceWithInfo):
(Inspector::RemoteConnectionToTarget::targetIdentifier):
(Inspector::RemoteConnectionToTarget::destination):
(Inspector::RemoteConnectionToTarget::setup):
(Inspector::RemoteConnectionToTarget::sendMessageToFrontend):
Bail out if the target pointer was somehow cleared and we can't get a useful target identifier.
(Inspector::RemoteConnectionToTarget::RemoteConnectionToTarget): Deleted.
- inspector/remote/RemoteControllableTarget.h:
- inspector/remote/RemoteInspectionTarget.cpp:
(Inspector::RemoteInspectionTarget::pauseWaitingForAutomaticInspection):
(Inspector::RemoteInspectionTarget::unpauseForInitializedInspector):
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::nextAvailableTargetIdentifier):
(Inspector::RemoteInspector::registerTarget):
(Inspector::RemoteInspector::unregisterTarget):
(Inspector::RemoteInspector::updateTarget):
(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):
(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
(Inspector::RemoteInspector::sendMessageToRemote):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupCompleted):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionFailed):
(Inspector::RemoteInspector::listingForInspectionTarget):
(Inspector::RemoteInspector::listingForAutomationTarget):
(Inspector::RemoteInspector::pushListingsNow):
(Inspector::RemoteInspector::pushListingsSoon):
(Inspector::RemoteInspector::updateHasActiveDebugSession):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDataMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedIndicateMessage):
(Inspector::RemoteInspector::receivedProxyApplicationSetupMessage):
(Inspector::RemoteInspector::receivedConnectionDiedMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
(Inspector::RemoteInspector::nextAvailableIdentifier): Deleted.
- inspector/remote/RemoteInspectorConstants.h:
- 2:34 PM Changeset in webkit [196514] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: Link preview is slow and unreliable
https://bugs.webkit.org/show_bug.cgi?id=154197
-and corresponding-
rdar://problem/24428064
Reviewed by Tim Horton.
This patch rolls http://trac.webkit.org/changeset/187471 back in. That was
how we fixed this problem ages ago. We rolled it out because it very
mysteriously seemed to cause a memory regression, but we want to track that
separately and not leave this performance regression in its place in the
meantime.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::updateActivityToken):
- 2:32 PM Changeset in webkit [196513] by
-
- 18 edits in trunk/Source/JavaScriptCore
[JSC] On x86, improve the selection of which value are selected for the UseDef part of commutative operations
https://bugs.webkit.org/show_bug.cgi?id=154151
Reviewed by Filip Pizlo.
Previously, when an instruction destroy an argument with
a UseDef use, we would try to pick a good target for the UseDef
while doing instruction selection.
For example:
@x = Add(@1, @2)
can be lowered to:
Move @1 Tmp3
Add @2 Tmp3
or
Move @2 Tmp3
Add @1 Tmp3
The choice of which value ends up copied is done by preferRightForResult()
at lowering time.
There are two common problems with the code we generate:
1) It is based on UseCount. If a value is at its last use,
it is a good target for coalescing even with a use-count > 1.
2) When both values are at their last use, the best choice
depends on the register pressure of each. We don't have that information
until we do register allocation.
This patch implements a simple idea to minimize how many of those Moves are needed.
Each commutative operation gets a 3 op variant. The register allocator then attempts
to alias *both* of them to the destination.
Since our aliasing is conservative, it removes as many copy as possible without causing
spilling.
There was an unexpected cool impovement too. If you have:
Move Tmp1, Tmp2
BranchAdd32 Tmp3, Tmp2
we would previously restore Tmp2 by substracting Tmp3 from the result.
We can now just use Tmp1. That removes quite a few Sub from the slow paths.
The problem is that simple idea uncoverred a bunch of issues that had to be fixed too.
I detail them inline below.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::and64):
- assembler/MacroAssemblerX86Common.h:
Most addition are adding an Address version of the 3 operands opcodes.
The reason for this is allow the complex addressing forms of instructions
when spilling.
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::mul32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
This was an unexpected discovery: removing tons of Move32 made floating-point heavy
code much slower.
It turns out the MoveDouble we were using has partial register dependencies.
The x86 optimization manual, Chapter 3, section 3.4.1.13 lists the move instructions executed
directly on the frontend. That's what we use now.
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::addFloat):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::mulFloat):
(JSC::MacroAssemblerX86Common::andDouble):
(JSC::MacroAssemblerX86Common::andFloat):
(JSC::MacroAssemblerX86Common::xorDouble):
(JSC::MacroAssemblerX86Common::xorFloat):
If the destination is not aliased, the version taking an address
use LoadFloat/LoadDouble instead of direct addressing.
That is because this:
Move Tmp1, Tmp2
Op [Tmp3], Tmp2
is slower than
Move [Tmp3] Tmp2
Op Tmp1, Tmp2
(sometimes significantly).
I am not exactly sure why.
(JSC::MacroAssemblerX86Common::branchAdd32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::and64):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::and64):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::mul32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::addFloat):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::mulFloat):
(JSC::MacroAssemblerX86Common::andDouble):
(JSC::MacroAssemblerX86Common::andFloat):
(JSC::MacroAssemblerX86Common::xorDouble):
(JSC::MacroAssemblerX86Common::xorFloat):
(JSC::MacroAssemblerX86Common::branchAdd32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::and64):
(JSC::MacroAssemblerX86_64::mul64):
(JSC::MacroAssemblerX86_64::xor64):
(JSC::MacroAssemblerX86_64::branchAdd64):
- assembler/X86Assembler.h:
(JSC::X86Assembler::movapd_rr):
(JSC::X86Assembler::movaps_rr):
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::shouldTryAliasingDef):
(JSC::B3::CheckSpecial::generate):
- b3/B3CheckSpecial.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/air/AirCustom.h:
(JSC::B3::Air::PatchCustom::shouldTryAliasingDef):
- b3/air/AirInst.h:
- b3/air/AirInstInlines.h:
(JSC::B3::Air::Inst::shouldTryAliasingDef):
- b3/air/AirIteratedRegisterCoalescing.cpp:
Aliasing the operands is done the same way as any coalescing.
There were problem with considering all those coalescing
as equivalent for the result.
Moves are mostly generated for Upsilon-Phis. Getting rid of
those tends to give better loops.
Sometimes, blocks have only Phis and a Jump. Coalescing
those moves gets rids of the block entirely.
Where it go interesting was that something like:
Move Tmp1, Tmp2
Op Tmp3, Tmp2
was significantly better than:
Op Tmp1, Tmp3
Move Tmp1, Tmp4
even in the same basic block.
To get back to the same performance when, I had to prioritize
regular Moves operations over argument coalescing.
Another argument for doing this is that the alias has a shorter
life in the hardware because the operation itself gets a new
virtual register from the bank.
- b3/air/AirOpcode.opcodes:
- b3/air/AirSpecial.cpp:
(JSC::B3::Air::Special::shouldTryAliasingDef):
- b3/air/AirSpecial.h:
- b3/testb3.cpp:
(JSC::B3::testCheckAddArgumentAliasing64):
(JSC::B3::testCheckAddArgumentAliasing32):
(JSC::B3::testCheckAddSelfOverflow64):
(JSC::B3::testCheckAddSelfOverflow32):
(JSC::B3::testCheckMulArgumentAliasing64):
(JSC::B3::testCheckMulArgumentAliasing32):
(JSC::B3::run):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitSaveOrCopyCalleeSavesFor):
This ruined my week.
When regenerating the frame of an inlined function that
was called through a tail call, we were ignoring r13 for some reason.
Since this patch makes it more likely to increase the degree
of each Tmp, the number of register used increased and r13 was more
commonly used.
When getting out of OSRExit, we would have that value trashed :(
The fix is simply to restore it like the other two Baseline callee saved
register.
- 2:31 PM Changeset in webkit [196512] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Avoid including ESLint until it is used
https://bugs.webkit.org/show_bug.cgi?id=154196
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-12
Reviewed by Timothy Hatcher.
- Scripts/copy-user-interface-resources.pl:
Do not include ESLint in optimized output yet.
- UserInterface/Controllers/AnalyzerManager.js:
Do not reference
eslintuntil we use it.
- UserInterface/Main.html:
Remove include to ESLint until we need it.
- 2:30 PM Changeset in webkit [196511] by
-
- 2 edits in trunk/Source/WebKit2
Get rid of a 6 year old compiler workaround
https://bugs.webkit.org/show_bug.cgi?id=154198
Reviewed by Sam Weinig.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::createService):
- 2:22 PM Changeset in webkit [196510] by
-
- 12 edits3 adds in trunk/Source/WebCore
[CSS Font Loading] Implement CSSFontFace Boilerplate
https://bugs.webkit.org/show_bug.cgi?id=154145
Reviewed by Dean Jackson.
The CSS Font Loading spec[1] dictates that the FontFace object needs to have string
accessors and mutators for a bunch of properties. Our CSSFontFace object currently
contains this parsed information, but it isn't accessible via string-based methods.
This patch adds the necessary accessors and mutators, and migrates CSSFontSelector
to use these mutators where necessary.
There is more work to come on CSSFontFace; the next step is to create an .idl file
and hook it up to our CSSFontFace object. In this patch I have left some
unimplemented pieces (for example: where the spec dictates that some operation should
throw a JavaScript exception) which will be implemented in a follow-up patch. This
patch does not have any visible behavior change; I'm separating out the boilerplate
into this patch in order to ease reviewing burden.
This patch separates the externally-facing JavaScript API into a new class, FontFace.
This class owns a CSSFontFace, which provides the backing implementation. There will
be a system of shared ownership of these objects once FontFaceSet is implemented.
No new tests because there is no behavior change.
- CMakeLists.txt: Add new files to CMake builds.
- WebCore.vcxproj/WebCore.vcxproj: Ditto for Windows.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto for Cocoa.
- css/CSSAllInOne.cpp: Ditto for All-In-One builds.
- css/CSSFontFace.cpp: Move shared code from CSSFontSelector into CSSFontFace.
(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::~CSSFontFace):
(WebCore::CSSFontFace::setFamilies):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::setWeight):
(WebCore::CSSFontFace::setUnicodeRange):
(WebCore::CSSFontFace::setVariantLigatures):
(WebCore::CSSFontFace::setVariantPosition):
(WebCore::CSSFontFace::setVariantCaps):
(WebCore::CSSFontFace::setVariantNumeric):
(WebCore::CSSFontFace::setVariantAlternates):
(WebCore::CSSFontFace::setVariantEastAsian):
(WebCore::CSSFontFace::setFeatureSettings):
- css/CSSFontFace.h: Clean up.
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::families):
(WebCore::CSSFontFace::traitsMask):
(WebCore::CSSFontFace::featureSettings):
(WebCore::CSSFontFace::variantSettings):
(WebCore::CSSFontFace::setVariantSettings):
(WebCore::CSSFontFace::setTraitsMask):
(WebCore::CSSFontFace::isLocalFallback):
(WebCore::CSSFontFace::addRange): Deleted.
(WebCore::CSSFontFace::insertFeature): Deleted.
(WebCore::CSSFontFace::setVariantCommonLigatures): Deleted.
(WebCore::CSSFontFace::setVariantDiscretionaryLigatures): Deleted.
(WebCore::CSSFontFace::setVariantHistoricalLigatures): Deleted.
(WebCore::CSSFontFace::setVariantContextualAlternates): Deleted.
(WebCore::CSSFontFace::setVariantPosition): Deleted.
(WebCore::CSSFontFace::setVariantCaps): Deleted.
(WebCore::CSSFontFace::setVariantNumericFigure): Deleted.
(WebCore::CSSFontFace::setVariantNumericSpacing): Deleted.
(WebCore::CSSFontFace::setVariantNumericFraction): Deleted.
(WebCore::CSSFontFace::setVariantNumericOrdinal): Deleted.
(WebCore::CSSFontFace::setVariantNumericSlashedZero): Deleted.
(WebCore::CSSFontFace::setVariantAlternates): Deleted.
(WebCore::CSSFontFace::setVariantEastAsianVariant): Deleted.
(WebCore::CSSFontFace::setVariantEastAsianWidth): Deleted.
(WebCore::CSSFontFace::setVariantEastAsianRuby): Deleted.
(WebCore::CSSFontFace::CSSFontFace): Deleted.
- css/CSSFontSelector.cpp: Migrate shared code into CSSFontFace, and udpate
to use the new API.
(WebCore::appendSources):
(WebCore::registerLocalFontFacesForFamily):
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::computeTraitsMask): Deleted.
(WebCore::createFontFace): Deleted.
- css/FontFace.cpp: Added. External JavaScript API. Owns a CSSFontFace.
(WebCore::FontFace::FontFace):
(WebCore::FontFace::~FontFace):
(WebCore::parseString):
(WebCore::FontFace::setFamily):
(WebCore::FontFace::setStyle):
(WebCore::FontFace::setWeight):
(WebCore::FontFace::setStretch):
(WebCore::FontFace::setUnicodeRange):
(WebCore::FontFace::setVariant):
(WebCore::FontFace::setFeatureSettings):
(WebCore::FontFace::family):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):
(WebCore::FontFace::unicodeRange):
(WebCore::FontFace::variant):
(WebCore::FontFace::featureSettings):
- css/FontFace.h: Added. Ditto.
(WebCore::FontFace::create):
- css/FontVariantBuilder.cpp: Added. Moved code here from FontVariantBuilder.h.
Refactored to support a new client (CSSFontFace).
(WebCore::extractFontVariantLigatures):
(WebCore::extractFontVariantNumeric):
(WebCore::extractFontVariantEastAsian):
(WebCore::computeFontVariant):
- css/FontVariantBuilder.h: Moved code from here into FontVariantBuilder.cpp.
(WebCore::applyValueFontVariantLigatures): Deleted.
(WebCore::applyValueFontVariantNumeric): Deleted.
(WebCore::applyValueFontVariantEastAsian): Deleted.
- css/StyleBuilderCustom.h: Update for new FontVariantBuilder API.
(WebCore::StyleBuilderCustom::applyValueFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyValueFontVariantEastAsian):
- platform/text/TextFlags.h: Provide convenience classes.
(WebCore::FontVariantLigaturesValues::FontVariantLigaturesValues):
(WebCore::FontVariantNumericValues::FontVariantNumericValues):
(WebCore::FontVariantEastAsianValues::FontVariantEastAsianValues):
- 2:17 PM Changeset in webkit [196509] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r196506; publish MediaResourceLoader.h as a private header so it can be used by
TestWebKitAPI.
- WebCore.xcodeproj/project.pbxproj:
- 2:15 PM Changeset in webkit [196508] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Tabs: Conflicts with multiple Formatters per SourceCode
https://bugs.webkit.org/show_bug.cgi?id=144717
<rdar://problem/20845163>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-12
Reviewed by Timothy Hatcher.
The underlying issue here is that each tab may create its own ContentView,
and therefore SourceCodeTextEditor, per-SourceCode. Each SourceCodeTextEditor
was mutating the SourceCode's state without listening for or expecting
updates from the other. This causes a bunch of different issues:
- editing in one tab does not get reflected in another tab for the same resource. This is common when using the Search tab to find and make an edit, then debug in another tab.
- one tab may auto format (pretty print) a resource and set the formatter on the SourceCode to make SourceCodeLocations know about formatted locations. However, a jump to location that opens a new ContentView for the same Resource will start out un-formatted, and misunderstand the location. This often results in an unexpected jump to 0:0.
The solution taken by this change is to have a single ContentView
per represented object. When that ContentView gets shown in a new
ContentViewContainer it gets transferred, leaving a tombstone in the
previous ContentViewContainer that can be revived later. This keeps
back foward lists with expected values. It also means there is a
single ContentView that doesn't need to worry about having the
state of its represented object getting overrun.
Currently this makes the assumption that we won't ever show multiple
ContentViews for the same represented object at the same time. This
may need to change if we were to support split pane editor or
something like that.
This also makes the assumption that ContentViewContainer's showEntry
and hideEntry do not modify the back forward list. That has not been
the case, and I think it is safe to assume it will never be the case.
The contracts this patch maintains:
- a ContentView is always owned by one ViewContainer. This ViewContainer is the one showing the ContentView.
- when another ViewContainer wants to share the ContentView ownership is transferred. Creating tombstones in the old ViewContainer and Reviving tombstones in the new ViewContainer.
- ViewContainer's have a tombstone per-BackForwardEntry that references the ContentView.
- In order to ensure a ContentView always gets closed, when the owning ViewContainer would close the ContentView it checks if it should instead transfer ownership of the ContentView to another interested ViewContainer.
This also maintains the contract that a ContentView should only be
closed once. When the ContentView is transferred between two
ContentViewContainers it should hide/show from the old to the new.
The last ContentViewContainer to reference a ContentView should
be the one to close the ContentView.
- UserInterface/Models/BackForwardEntry.js:
(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype.get tombstone):
(WebInspector.BackForwardEntry.prototype.set tombstone):
(WebInspector.BackForwardEntry.prototype.prepareToShow):
(WebInspector.BackForwardEntry.prototype.prepareToHide):
Tombstone state and assertions that we don't show/hide tombstones,
that should all be done before a back forward entry has become a tombstone.
- UserInterface/Views/ContentView.js:
(WebInspector.ContentView.contentViewForRepresentedObject):
(WebInspector.ContentView.closedContentViewForRepresentedObject):
(WebInspector.ContentView.resolvedRepresentedObjectForRepresentedObject):
Helpers for getting / creating / clearing the single ContentView that
is associated with a represented object.
- UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.contentViewForRepresentedObject):
(WebInspector.ContentViewContainer.prototype.showContentView):
Eliminate code that dealt with multiple content views per represented object.
That is replaced by multiple ContentViewContainers per ContentView.
(WebInspector.ContentViewContainer.prototype.replaceContentView):
This is called in special places where we don't need to worry about a tombstone.
It is an in replace of a content view.
(WebInspector.ContentViewContainer.closeAllContentViewsOfPrototype):
(WebInspector.ContentViewContainer.prototype.closeContentView):
(WebInspector.ContentViewContainer.prototype.closeAllContentViews):
(WebInspector.ContentViewContainer.prototype._disassociateFromContentView):
Deal with closing BackForwardEntrys that are tombstones.
(WebInspector.ContentViewContainer.prototype._takeOwnershipOfContentView):
(WebInspector.ContentViewContainer.prototype._placeTombstonesForContentView):
(WebInspector.ContentViewContainer.prototype._clearTombstonesForContentView):
Helpers for transfering ownership of a ContentView to a ContentViewContainer.
There is always one owner of the ContentView. Non-owners have tombstone
BackForward entries.
(WebInspector.ContentViewContainer.prototype._showEntry):
If we are showing a tombstone, gain ownership.
(WebInspector.ContentViewContainer.prototype._hideEntry):
This may happen in closing, for simplicity we bail here instead of include
messy logic at the call site. We would have already hidden this entry
when making it a tombstone.
- 2:13 PM Changeset in webkit [196507] by
-
- 2 edits in trunk/Source/WebKit2
Fix ASan build.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::copyASanDynamicLibraryPath): Deleted.
- 2:13 PM Changeset in webkit [196506] by
-
- 7 edits in trunk
[Mac] Adopt MediaResourceLoader (instead of CachedResourceLoader) in WebCoreNSURLSession.
https://bugs.webkit.org/show_bug.cgi?id=154136
Reviewed by Alex Christensen.
Source/WebCore:
MediaResourceLoader already supports using CORS attribute to verify CORS access requirements
when loading media resources, so use it, rather than CachedResourceLoader, as the backing for
WebCoreNSURLSession.
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession delegateQueue]):
(-[WebCoreNSURLSession streamTaskWithNetService:]):
(-[WebCoreNSURLSession isKindOfClass:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
(-[WebCoreNSURLSessionDataTask _restart]):
(-[WebCoreNSURLSessionDataTask _cancel]):
(-[WebCoreNSURLSessionDataTask resume]):
(-[WebCoreNSURLSessionDataTask _timingData]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]): Deleted.
(-[WebCoreNSURLSession loader]): Deleted.
(WebCore::WebCoreNSURLSessionDataTaskClient::dataSent): Deleted.
(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived): Deleted.
(WebCore::WebCoreNSURLSessionDataTaskClient::dataReceived): Deleted.
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived): Deleted.
(WebCore::WebCoreNSURLSessionDataTaskClient::notifyFinished): Deleted.
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]): Deleted.
(-[WebCoreNSURLSessionDataTask _finish]): Deleted.
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]): Deleted.
(-[WebCoreNSURLSessionDataTask resourceFinished:]): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Tools:
Use a MediaResourceLoader instead of a CachedResourceLoader for WebCoreNSURLSession.
Drive-by fix: generate USE and ENABLE macros for TestWebKitAPI by adding FEATURE_DEFINES
to GCC_PREPROCESSOR_DEFINES.
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
(TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
(TestWebKitAPI::TEST_F):
- 2:04 PM Changeset in webkit [196505] by
-
- 15 edits3 deletes in trunk/Source/WebKit2
Remove NPAPI for showing preference panes
https://bugs.webkit.org/show_bug.cgi?id=154193
Reviewed by Dan Bernstein.
No plug-ins ended up adopting this API, so there's no point in keeping it around.
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::openPluginPreferencePane): Deleted.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo): Deleted.
- Shared/Plugins/PluginModuleInfo.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::openPluginPreferencePane): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Deleted.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::openPluginPreferencePane): Deleted.
(WebKit::NetscapePlugin::plugInContainer): Deleted.
(WebKit::NetscapePlugin::platformDestroy): Deleted.
- WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.h: Removed.
- WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm: Removed.
(-[WKNPAPIPlugInContainer dealloc]): Deleted.
(-[WKNPAPIPlugInContainer _invalidate]): Deleted.
(-[WKNPAPIPlugInContainer openPlugInPreferencePane]): Deleted.
- WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainerInternal.h: Removed.
- WebProcess/Plugins/PluginController.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::openPluginPreferencePane): Deleted.
- WebProcess/Plugins/PluginView.h:
- 1:54 PM Changeset in webkit [196504] by
-
- 2 edits in tags/Safari-602.1.18.9/Source/WebKit
Merged r196502. rdar://problem/24635219
- 1:52 PM Changeset in webkit [196503] by
-
- 2 edits in trunk/Source/WebCore
Fix non-internal builds when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=152285
- platform/spi/cf/CFNetworkSPI.h:
Add SPI declaration used in r194156.
- 1:43 PM Changeset in webkit [196502] by
-
- 2 edits in trunk/Source/WebKit
Fix internal Windows WebKit debug build.
rdar://problem/24635219
- PlatformWin.cmake:
We were making WebKit.dll instead of WebKit_debug.dll.
- 1:39 PM Changeset in webkit [196501] by
-
- 2 edits in trunk/Source/WebKit2
Remove PowerPC cruft
https://bugs.webkit.org/show_bug.cgi?id=154191
Reviewed by Dan Bernstein.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginArchitecture): Deleted.
- 1:25 PM Changeset in webkit [196500] by
-
- 11 edits1 delete in trunk/Source/WebKit2
Remove more unneeded process launching code
https://bugs.webkit.org/show_bug.cgi?id=154190
Reviewed by Tim Horton.
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::getLaunchOptions): Deleted.
- UIProcess/Databases/mac/DatabaseProcessProxyMac.mm: Removed.
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getLaunchOptions): Deleted.
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::NetworkProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::pluginNeedsExecutableHeap): Deleted.
(WebKit::PluginProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions): Deleted.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::platformGetLaunchOptions): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 1:11 PM Changeset in webkit [196499] by
-
- 8 edits in trunk/Source/WebKit2
Use different process types for 32-bit and 64-bit plug-ins
https://bugs.webkit.org/show_bug.cgi?id=154186
Reviewed by Tim Horton.
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::getLaunchOptions):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
(WebKit::shouldLeakBoost):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getLaunchOptions):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::getLaunchOptions): Deleted.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
- 12:46 PM Changeset in webkit [196498] by
-
- 20 edits4 adds in trunk
[ES6] Implement @@search
https://bugs.webkit.org/show_bug.cgi?id=143889
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implement RegExp.prototype[@@search].
In ES6, String.prototype.search delegates the actual matching to it
instead of executing RegExp matching inside String.prototype.search method itself.
By customizing @@search method, we can change the behavior of String.prototype.search for
derived / customized RegExp object.
- CMakeLists.txt:
- DerivedSources.make:
- builtins/BuiltinNames.h:
(JSC::BuiltinNames::BuiltinNames): Deleted.
- builtins/BuiltinUtils.h:
- builtins/StringPrototype.js:
(search):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):
(JSC::regExpProtoFuncSearch):
- runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::create):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::finishCreation): Deleted.
(JSC::stringProtoFuncSearch): Deleted.
- runtime/StringPrototype.h:
- tests/es6.yaml:
- tests/stress/regexp-search.js: Added.
(shouldBe):
(shouldThrow):
(errorKey.toString):
(primitive.of.primitives.shouldThrow):
(testRegExpSearch):
(testSearch):
(testBoth):
(alwaysUnmatch):
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/dom/string-prototype-properties-expected.txt:
- js/regress/script-tests/v8-regexp-search.js: Added.
(runRegExpBenchmark.runBlock0):
(runRegExpBenchmark.runBlock1):
(runRegExpBenchmark):
(runRegExpBenchmark.runBlock3):
(runRegExpBenchmark.runBlock4):
- js/regress/v8-regexp-search-expected.txt: Added.
- js/regress/v8-regexp-search.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
- 12:44 PM Changeset in webkit [196497] by
-
- 2 edits in trunk/Source/JavaScriptCore
AdaptiveInferredPropertyValueWatchpoint can trigger a GC that frees its CodeBlock and thus itself
https://bugs.webkit.org/show_bug.cgi?id=154146
Reviewed by Filip Pizlo.
Consider the following: there is some CodeBlock, C, that is watching some object, O, with a
structure, S, for replacements. Also, suppose that C has no references anymore and is due to
be GCed. Now, when some new property is added to O, S will create a new structure S' and
fire its transition watchpoints. Since C is watching S for replacements it will attempt to
have its AdaptiveInferredPropertyValueWatchpoint relocate itself to S'. To do so, it needs
it allocate RareData on S'. This allocation may cause a GC, which frees C while still
executing its watchpoint handler. The solution to this is to defer GC while running
AdaptiveInferredPropertyValueWatchpointBase handlers.
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
- 12:31 PM Changeset in webkit [196496] by
-
- 5 edits in trunk/Source/WebKit2
Re-name isClickableElement in InteractionInformationAtPosition to isElement
https://bugs.webkit.org/show_bug.cgi?id=154179
Reviewed by Enrica Casucci.
The bool is set for all elements, so it’s just confusing to call it a
clickableElement instead of just element.
- Shared/ios/InteractionInformationAtPosition.h:
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _highlightLongPressRecognized:]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 12:22 PM Changeset in webkit [196495] by
-
- 2 edits in trunk/Source/WebCore
Throw out all live resource decoded data on memory pressure / suspension.
<https://webkit.org/b/154176>
Reviewed by Antti Koivisto.
When pruning live resource decoded data from the memory cache,
we normally avoid pruning anything that's been painted in the last second.
This is an optimization to avoid getting into image decoding loops.
For memory pressure / process suspension scenarios this doesn't really
make sense though:
- In the pressure case, if we have to render again soon it'll likely be a new GIF frame which we have to decode anyway.
- In the process suspension case, we might *never* render again, so we should be good citizens and drop all the decoded data we can.
This patch makes us drop all the decoded data, recently painted or not.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
- 12:20 PM Changeset in webkit [196494] by
-
- 6 edits in trunk/Source
Separate out !allowsAccess path in JSDOMWindowCustom getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=154156
Reviewed by Chris Dumez.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
- added new property names, needed by jsDOMWindowGetOwnPropertySlotDisallowAccess.
Source/WebCore:
JSDOMWindowCustom getOwnPropertySlot currently allows cross-origin access to all
static properties, relying on the property to perform the access check. This is
a little insecure, since it is error prone - someone could easily add a property
to the static table without realizing it would be automatcially exposed.
Instead, add a hard-coded filter to restrict access. As a future implementation
we might consider autogenerating this (the properties are already tagged in IDL,
we might be able to track this in a flag on the static table).
By separating out the handling of the same- and cross-origin access we can
simplify & make the policy being enforced much clearer.
- bindings/js/JSDOMBinding.cpp:
(WebCore::objectToStringFunctionGetter): Deleted.
- removed objectToStringFunctionGetter - this duplicated functionality of nonCachingStaticFunctionGetter.
- bindings/js/JSDOMBinding.h:
(WebCore::objectToStringFunctionGetter): Deleted.
- removed objectToStringFunctionGetter - this duplicated functionality of nonCachingStaticFunctionGetter.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotDisallowAccess):
- explicitly handle providing access to only the things we do want to allow cross-origin.
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
- push all !allowsAccess handling to jsDOMWindowGetOwnPropertySlotDisallowAccess
(WebCore::childFrameGetter): Deleted.
- this was just a deoptimiztion - moving access into a callback saved very little & caused more work to be duplicated.
- 12:17 PM Changeset in webkit [196493] by
-
- 3 edits in trunk/Source/WebKit2
Remove more unused process launcher code
https://bugs.webkit.org/show_bug.cgi?id=154181
Reviewed by Tim Horton.
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::processTypeAsString): Deleted.
(WebKit::ProcessLauncher::getProcessTypeFromString): Deleted.
- UIProcess/Launcher/ProcessLauncher.h:
- 12:15 PM Changeset in webkit [196492] by
-
- 122 edits2 adds in trunk/Source
Update ICU header files to version 52
https://bugs.webkit.org/show_bug.cgi?id=154160
Reviewed by Alex Christensen.
Update ICU header files to version 52 to allow the use of newer APIs.
Source/JavaScriptCore:
- icu/unicode/localpointer.h:
- icu/unicode/platform.h:
- icu/unicode/ptypes.h:
- icu/unicode/putil.h:
- icu/unicode/ucal.h:
- icu/unicode/uchar.h:
- icu/unicode/ucnv.h:
- icu/unicode/ucol.h:
- icu/unicode/uconfig.h:
- icu/unicode/udat.h:
- icu/unicode/udatpg.h:
- icu/unicode/udisplaycontext.h: Added.
- icu/unicode/uenum.h:
- icu/unicode/uformattable.h: Added.
- icu/unicode/uiter.h:
- icu/unicode/uloc.h:
- icu/unicode/umachine.h:
- icu/unicode/unorm2.h:
- icu/unicode/unum.h:
- icu/unicode/urename.h:
- icu/unicode/uscript.h:
- icu/unicode/uset.h:
- icu/unicode/ustring.h:
- icu/unicode/utf.h:
- icu/unicode/utf16.h:
- icu/unicode/utf8.h:
- icu/unicode/utf_old.h:
- icu/unicode/utypes.h:
- icu/unicode/uvernum.h:
- icu/unicode/uversion.h:
Source/WebCore:
No new tests because there is no behavior change.
- icu/unicode/bytestream.h:
- icu/unicode/chariter.h:
- icu/unicode/localpointer.h:
- icu/unicode/platform.h:
- icu/unicode/ptypes.h:
- icu/unicode/putil.h:
- icu/unicode/rep.h:
(Replaceable::Replaceable):
- icu/unicode/std_string.h:
- icu/unicode/strenum.h:
- icu/unicode/stringpiece.h:
- icu/unicode/ubrk.h:
- icu/unicode/uchar.h:
- icu/unicode/ucnv.h:
- icu/unicode/ucol.h:
- icu/unicode/ucoleitr.h:
- icu/unicode/uconfig.h:
- icu/unicode/ucsdet.h:
- icu/unicode/uenum.h:
- icu/unicode/uidna.h:
- icu/unicode/uiter.h:
- icu/unicode/uloc.h:
- icu/unicode/umachine.h:
- icu/unicode/unistr.h:
(UnicodeString::UnicodeString):
(UnicodeString::operator== ):
(UnicodeString::startsWith):
(UnicodeString::setTo):
(UnicodeString::remove):
(UnicodeString::replace): Deleted.
(UnicodeString::extract): Deleted.
(UnicodeString::char32At): Deleted.
(UnicodeString::getChar32Start): Deleted.
(UnicodeString::getChar32Limit): Deleted.
(UnicodeString::getTerminatedBuffer): Deleted.
(UnicodeString::append): Deleted.
(UnicodeString::truncate): Deleted.
- icu/unicode/unorm2.h:
- icu/unicode/uobject.h:
- icu/unicode/urename.h:
- icu/unicode/uscript.h:
- icu/unicode/usearch.h:
- icu/unicode/uset.h:
- icu/unicode/ushape.h:
- icu/unicode/ustring.h:
- icu/unicode/utext.h:
- icu/unicode/utf.h:
- icu/unicode/utf16.h:
- icu/unicode/utf8.h:
- icu/unicode/utf_old.h:
- icu/unicode/utypes.h:
- icu/unicode/uvernum.h:
- icu/unicode/uversion.h:
Source/WebKit/mac:
- icu/unicode/localpointer.h:
- icu/unicode/platform.h:
- icu/unicode/ptypes.h:
- icu/unicode/putil.h:
- icu/unicode/uchar.h:
- icu/unicode/uconfig.h:
- icu/unicode/uidna.h:
- icu/unicode/uiter.h:
- icu/unicode/umachine.h:
- icu/unicode/unorm2.h:
- icu/unicode/urename.h:
- icu/unicode/uscript.h:
- icu/unicode/ustring.h:
- icu/unicode/utf.h:
- icu/unicode/utf16.h:
- icu/unicode/utf8.h:
- icu/unicode/utf_old.h:
- icu/unicode/utypes.h:
- icu/unicode/uvernum.h:
- icu/unicode/uversion.h:
Source/WTF:
- icu/unicode/bytestream.h:
- icu/unicode/localpointer.h:
- icu/unicode/platform.h:
- icu/unicode/ptypes.h:
- icu/unicode/putil.h:
- icu/unicode/rep.h:
(Replaceable::Replaceable):
- icu/unicode/std_string.h:
- icu/unicode/strenum.h:
- icu/unicode/stringpiece.h:
- icu/unicode/uchar.h:
- icu/unicode/ucnv.h:
- icu/unicode/ucol.h:
- icu/unicode/uconfig.h:
- icu/unicode/uenum.h:
- icu/unicode/uiter.h:
- icu/unicode/uloc.h:
- icu/unicode/umachine.h:
- icu/unicode/unistr.h:
(UnicodeString::UnicodeString):
(UnicodeString::operator== ):
(UnicodeString::startsWith):
(UnicodeString::setTo):
(UnicodeString::remove):
(UnicodeString::replace): Deleted.
(UnicodeString::extract): Deleted.
(UnicodeString::char32At): Deleted.
(UnicodeString::getChar32Start): Deleted.
(UnicodeString::getChar32Limit): Deleted.
(UnicodeString::getTerminatedBuffer): Deleted.
(UnicodeString::append): Deleted.
(UnicodeString::truncate): Deleted.
- icu/unicode/unorm2.h:
- icu/unicode/uobject.h:
- icu/unicode/urename.h:
- icu/unicode/uscript.h:
- icu/unicode/uset.h:
- icu/unicode/ustring.h:
- icu/unicode/utf.h:
- icu/unicode/utf16.h:
- icu/unicode/utf8.h:
- icu/unicode/utf_old.h:
- icu/unicode/utypes.h:
- icu/unicode/uvernum.h:
- icu/unicode/uversion.h:
- 11:58 AM Changeset in webkit [196491] by
-
- 10 edits in trunk/Source/WebKit2
Remove more unused process launching code
https://bugs.webkit.org/show_bug.cgi?id=154178
Reviewed by Tim Horton.
- UIProcess/Databases/mac/DatabaseProcessProxyMac.mm:
(WebKit::shouldUseXPC): Deleted.
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/EnvironmentVariables.cpp:
(WebKit::EnvironmentVariables::preexistingProcessServiceNameKey): Deleted.
(WebKit::EnvironmentVariables::preexistingProcessTypeKey): Deleted.
- UIProcess/Launcher/mac/EnvironmentVariables.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
(WebKit::setUpTerminationNotificationHandler): Deleted.
(WebKit::addDYLDEnvironmentAdditions): Deleted.
(WebKit::tryPreexistingProcess): Deleted.
(WebKit::createProcess): Deleted.
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::shouldUseXPC): Deleted.
(WebKit::NetworkProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/ios/WebProcessProxyIOS.mm:
(WebKit::WebProcessProxy::platformGetLaunchOptions): Deleted.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::shouldUseXPC): Deleted.
(WebKit::WebProcessProxy::platformGetLaunchOptions): Deleted.
- 11:50 AM Changeset in webkit [196490] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Fast path in JSObject::defineOwnIndexedProperty() forgets to check for the posibility of a descriptor that doesn't have a value
https://bugs.webkit.org/show_bug.cgi?id=154175
rdar://problem/24291497
Reviewed by Geoffrey Garen.
- runtime/JSObject.cpp:
(JSC::JSObject::defineOwnIndexedProperty): Fix the bug.
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::putEntry): Catch the bug sooner in debug.
(JSC::SparseArrayValueMap::putDirect):
- tests/stress/sparse-define-empty-descriptor.js: Added. This used to crash in release.
- 11:43 AM Changeset in webkit [196489] by
-
- 4 edits in trunk/Source/WebKit/mac
NSRangeIsRelativeTo should not have NS prefix
https://bugs.webkit.org/show_bug.cgi?id=154174
Reviewed by Tim Horton.
NSRangeIsRelativeTo -> WebRangeIsRelativeTo
- WebView/WebFrame.mm:
(-[WebFrame _convertToDOMRange:]):
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):
- 11:28 AM Changeset in webkit [196488] by
-
- 8 edits9 adds in trunk/Source/WebKit2
Add a WebKit SPI for creating an automation session and advertise the active session via RemoteInspector
https://bugs.webkit.org/show_bug.cgi?id=153934
Reviewed by Dan Bernstein and Joseph Pecoraro.
An automation session is the main place where WebKit support for user agent automation is implemented.
A session encapsulates the state (default timeouts, page identifier mappings), objects (active automation
WebPages) and logic (how to open a window, run JS, send user input, etc.) used to implement automation
commands.
A process pool can only have one session at a time. The session is created by the WebKit client in
response to a request that comes through _WKAutomationDelegate. When a session is set on the process pool,
it is advertised to remote drivers and debuggers as a RemoteControllableTarget. A remote driver can use
the existing RemoteInspector API to connect to the session and send it automation commands.
The session has a delegate so that WebKit clients can perform actions that are outside the scope of WebKit,
such as creating new tabs, enumerating windows, or sending native user inputs.
This patch adds AutomationSession classes at the API and implementation level in WebKit2. The
implementation class contains RemoteInspector support, which cannot be used directly by WebKit clients.
AutomationSessionDelegate classes exist at both the API and implementation level to bridge between
Objective-C delegates and C++ clients. All code related to RemoteInspector and RemoteAutomationTarget
must be guarded by ENABLE(REMOTE_INSPECTOR).
- Shared/API/APIObject.h: Add new API type 'AutomationSession'.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Allocate in the wrapper.
- UIProcess/API/APIAutomationSessionClient.h: Added.
(API::AutomationSessionClient::~AutomationSessionClient):
(API::AutomationSessionClient::didRequestNewWindow): Delegate window creation to the client.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setAutomationSession:]): Keep at most one WebAutomationSession at a time.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/_WKAutomationSession.h: Added.
- UIProcess/API/Cocoa/_WKAutomationSession.mm: Added.
(-[_WKAutomationSession init]): Construct the API object in the implementation wrapper.
(-[_WKAutomationSession dealloc]): Clear the client before calling the implementation destructor.
(-[_WKAutomationSession sessionIdentifier]):
(-[_WKAutomationSession setSessionIdentifier:]):
Store the session identifier string in the implementation.
(-[_WKAutomationSession delegate]):
(-[_WKAutomationSession setDelegate:]):
Create an Objective-C adapter for the delegate if not nil and set it as the implementation's client.
(-[_WKAutomationSession _apiObject]):
- UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h: Added.
- UIProcess/API/Cocoa/_WKAutomationSessionInternal.h: Added.
(wrapper):
- UIProcess/Cocoa/AutomationSessionClient.h: Added.
Set up the boilerplate for caching delegate method availability. It will include more methods later.
- UIProcess/Cocoa/AutomationSessionClient.mm: Added. Forward requests to the SPI delegate.
(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::AutomationSessionClient::didRequestNewWindow): Delegate window creation to the client.
- UIProcess/WebAutomationSession.cpp: Added.
(WebKit::WebAutomationSession::WebAutomationSession):
By default, a session should be available and not paired to any particular remote driver.
(WebKit::WebAutomationSession::~WebAutomationSession): Require callers to clear the client first.
(WebKit::WebAutomationSession::setClient):
(WebKit::WebAutomationSession::dispatchMessageFromRemote): Stub this out for now.
(WebKit::WebAutomationSession::connect):
(WebKit::WebAutomationSession::disconnect):
To prevent multiple connection attempts, mark the target as paired when a remote client has connected.
- UIProcess/WebAutomationSession.h: Added.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setAutomationSession):
Store the session object and tell it to register itself. Unregistering happens automatically
in RemoteControllableTarget::~RemoteControllableTarget.
- UIProcess/WebProcessPool.h:
- WebKit2.xcodeproj/project.pbxproj: Add files and headers.
- 11:18 AM Changeset in webkit [196487] by
-
- 2 edits in tags/Safari-602.1.18.9/Source/WebKit
Merged r196462. rdar://problem/24622882
- 11:07 AM Changeset in webkit [196486] by
-
- 3 edits in tags/Safari-602.1.18.9/Source/WebCore
Merged r196023. rdar://problem/24411911
- 11:06 AM Changeset in webkit [196485] by
-
- 5 edits in tags/Safari-602.1.18.9/Source
Versioning.
- 11:02 AM Changeset in webkit [196484] by
-
- 1 copy in tags/Safari-602.1.18.9
New tag.
- 10:34 AM Changeset in webkit [196483] by
-
- 9 edits in trunk/Source/WebCore
[Mac] BitmapImage::decodedDataIsPurgeable() is telling lies and causing massive memory usage.
<https://webkit.org/b/154172>
Reviewed by Antti Koivisto.
The underlying mechanism in CoreAnimation that made this work is no longer in place.
Instead of keeping purgeable frames and juggling volatility bits, we were simply caching
every single frame of large GIF animations, sometimes leading to monstrous memory usage.
Remove the code from WebCore since it's not doing at all what it means to.
Now iOS and Mac will behave the same again, and frame caching decisions will be
made by WebKit, based on total pixel byte size.
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.h:
(WebCore::CachedResource::decodedDataIsPurgeable): Deleted.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToSize): Deleted.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::decodedDataIsPurgeable): Deleted.
(WebCore::BitmapImage::destroyDecodedDataIfNecessary): Deleted.
- platform/graphics/BitmapImage.h:
- platform/graphics/Image.h:
(WebCore::Image::decodedDataIsPurgeable): Deleted.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::decodedDataIsPurgeable): Deleted.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex): Deleted.
- 10:30 AM Changeset in webkit [196482] by
-
- 16 edits1 add in trunk/Source/WebCore
Modern IDB: Ref cycle between IDBObjectStore and IDBIndex.
https://bugs.webkit.org/show_bug.cgi?id=154110
Reviewed by Darin Adler.
No new tests (Currently untestable).
The lifetime of IDBObjectStore and IDBIndex are closely intertwined, but we have to break the ref cycle.
This patch does a few semi-gnarly things:
1 - Makes both IDBIndex and IDBObjectStore have a custom marking function so they can add each other as
opaque roots.
2 - Adds a lock to protect IDBObjectStore's collection of referenced indexes to support #1, as GC marking
can happen on any thread.
3 - Makes IDBIndex not be traditionally RefCounted; Instead, IDBIndex::ref()/deref() simply ref()/deref()
the owning IDBObjectStore.
4 - ...Except when somebody deletes an IDBIndex from its IDBObjectStore. Once that happens, the object
store no longer has a reference back to the index, but the index still needs a reference back to the
object store. To support this, the IDBIndex becomes "traditionally RefCounted" while holding a ref to
its IDBObjectStore.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::isModern):
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::isModern):
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/client/IDBIndexImpl.cpp:
(WebCore::IDBClient::IDBIndex::objectStore):
(WebCore::IDBClient::IDBIndex::openCursor):
(WebCore::IDBClient::IDBIndex::doCount):
(WebCore::IDBClient::IDBIndex::openKeyCursor):
(WebCore::IDBClient::IDBIndex::doGet):
(WebCore::IDBClient::IDBIndex::doGetKey):
(WebCore::IDBClient::IDBIndex::markAsDeleted):
(WebCore::IDBClient::IDBIndex::ref):
(WebCore::IDBClient::IDBIndex::deref):
(WebCore::IDBClient::IDBIndex::create): Deleted.
- Modules/indexeddb/client/IDBIndexImpl.h:
(WebCore::IDBClient::IDBIndex::modernObjectStore):
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::createIndex):
(WebCore::IDBClient::IDBObjectStore::index):
(WebCore::IDBClient::IDBObjectStore::deleteIndex):
(WebCore::IDBClient::IDBObjectStore::visitReferencedIndexes):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::createIndex):
- Modules/indexeddb/client/IDBTransactionImpl.h:
- Modules/indexeddb/legacy/LegacyIndex.cpp:
(WebCore::LegacyIndex::ref):
(WebCore::LegacyIndex::deref):
- Modules/indexeddb/legacy/LegacyIndex.h:
- bindings/js/JSIDBIndexCustom.cpp: Added.
(WebCore::JSIDBIndex::visitAdditionalChildren):
- bindings/js/JSIDBObjectStoreCustom.cpp:
(WebCore::JSIDBObjectStore::visitAdditionalChildren):
- 9:33 AM Changeset in webkit [196481] by
-
- 8 edits in trunk
[EFL][GTK] Fix ENABLE(SVG_OTF_CONVERTER) build
https://bugs.webkit.org/show_bug.cgi?id=154165
Reviewed by Alex Christensen.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Source/WebCore:
- CMakeLists.txt:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- svg/SVGToOTFFontConversion.cpp:
- svg/SVGToOTFFontConversion.h:
- 9:24 AM Changeset in webkit [196480] by
-
- 3 edits in trunk/Source/WebKit2
Get rid of NetscapePluginModule::createPluginMIMETypesPreferences
https://bugs.webkit.org/show_bug.cgi?id=154173
Reviewed by Dan Bernstein.
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences): Deleted.
- 9:23 AM Changeset in webkit [196479] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196466
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 9:10 AM Changeset in webkit [196478] by
-
- 2 edits6 deletes in trunk/Source/WebKit2
Remove legacy processes from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=154119
Reviewed by Darin Adler.
- Configurations/BaseLegacyProcess.xcconfig: Removed.
- DatabaseProcess/EntryPoint/mac/LegacyProcess/DatabaseProcessMain.mm: Removed.
(DatabaseProcessMain): Deleted.
- DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist: Removed.
- NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist: Removed.
- NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm: Removed.
(NetworkProcessMain): Deleted.
- PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist: Removed.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm: Removed.
(WebKit::PluginProcessMainDelegate::PluginProcessMainDelegate): Deleted.
(PluginProcessMain): Deleted.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h: Removed.
(WebKit::ChildProcessMainDelegate::ChildProcessMainDelegate): Deleted.
(WebKit::ChildProcessMain): Deleted.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm: Removed.
(WebKit::ChildProcessMainDelegate::~ChildProcessMainDelegate): Deleted.
(WebKit::ChildProcessMainDelegate::installSignalHandlers): Deleted.
(WebKit::ChildProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::ChildProcessMainDelegate::getConnectionIdentifier): Deleted.
(WebKit::ChildProcessMainDelegate::getClientIdentifier): Deleted.
(WebKit::ChildProcessMainDelegate::getClientProcessName): Deleted.
(WebKit::ChildProcessMainDelegate::getExtraInitializationData): Deleted.
(WebKit::ChildProcessMainDelegate::startRunLoop): Deleted.
(WebKit::ChildProcessMainDelegate::doPostRunWork): Deleted.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Removed.
(WebKit::closeUnusedFileDescriptors): Deleted.
(WebKit::BootstrapMain): Deleted.
(main): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist: Removed.
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm: Removed.
(WebKit::WebContentProcessMainDelegate::WebContentProcessMainDelegate): Deleted.
(WebContentProcessMain): Deleted.
- 9:00 AM Changeset in webkit [196477] by
-
- 12 edits in branches/safari-601.1.46-branch
Merged r196401. rdar://problem/24611749
- 8:49 AM Changeset in webkit [196476] by
-
- 22 edits in trunk/Source/WebCore
Unreviewed nit fixes after r196466.
- Modules/speech/SpeechSynthesisUtterance.idl: Fix curly bracket placement.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Use wrappableObject instead of domObject.
- bindings/scripts/test/*: Rebaseline.
- dom/WebKitNamedFlow.idl: Drop unnecessary #if case.
- 8:40 AM Changeset in webkit [196475] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] HTTP auth dialog incorrectly rendered with Accelerated Compositing enabled
https://bugs.webkit.org/show_bug.cgi?id=154159
Reviewed by Michael Catanzaro.
There are two problems here, first we are changing the cairo
operator when rendering the xcomposite window pixmap without a
proper save/restore, so it affects the drawing that happens after
that, and second problem is that we are not rendering the gray
background in AC mode because we are returning earlier.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewRenderAcceleratedCompositingResults):
(webkitWebViewBaseDraw):
- 8:37 AM Changeset in webkit [196474] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Properly handle classes inheriting from EventTarget
https://bugs.webkit.org/show_bug.cgi?id=154158
Reviewed by Michael Catanzaro.
Instead of removing its parent we now handle the case of classes
having EventTarget as parent to make them implement the interface
instead.
- bindings/scripts/CodeGeneratorGObject.pm:
(ShouldBeExposedAsInterface): Whether the parent given class
should be exposed as an interface instead of a parent class.
(GetParentClassName): Return Object as parent for classes having
a parent that should be exposed as an interface.
(GetParentImplClassName): Ditto.
(GetBaseClass): Ditto.
(GetParentGObjType): Ditto.
(SkipFunction): Add FIXME comment.
(ImplementsInterface): Helper function to check if a class
implements the given interface.
(GenerateCFile): Check whether the class implements EventTarget to
generate the interface implementation.
(GenerateInterface): Do not remove the parent class when it's EventTarget.
- 7:49 AM Changeset in webkit [196473] by
-
- 5 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r196470.
https://bugs.webkit.org/show_bug.cgi?id=154167
Broke some tests (Requested by anttik on #webkit).
Reverted changeset:
"Factor class change style invalidation code into a class"
https://bugs.webkit.org/show_bug.cgi?id=154163
http://trac.webkit.org/changeset/196470
- 7:37 AM Changeset in webkit [196472] by
-
- 3 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge r196362. rdar://problem/24611811
- 7:37 AM Changeset in webkit [196471] by
-
- 12 edits in branches/safari-601-branch
Merge r196401. rdar://problem/24611749
- 7:05 AM Changeset in webkit [196470] by
-
- 5 edits2 adds in trunk/Source/WebCore
Factor class change style invalidation code into a class
https://bugs.webkit.org/show_bug.cgi?id=154163
Reviewed by Andreas Kling.
Factor this piece of functionality out of Element and into ClassChangeInvalidation class.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::classStringHasClassName):
(WebCore::Element::classAttributeChanged):
(WebCore::collectClasses): Deleted.
(WebCore::computeClassChange): Deleted.
(WebCore::invalidateStyleForClassChange): Deleted.
- style/ClassChangeInvalidation.cpp: Added.
(WebCore::Style::ClassChangeInvalidation::computeClassChange):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):
- style/ClassChangeInvalidation.h: Added.
(WebCore::Style::ClassChangeInvalidation::needsInvalidation):
(WebCore::Style::ClassChangeInvalidation::ClassChangeInvalidation):
(WebCore::Style::ClassChangeInvalidation::~ClassChangeInvalidation):
- 5:52 AM Changeset in webkit [196469] by
-
- 2 edits in trunk/Source/WebCore
GCC buildfix in Source/WebCore/svg/SVGToOTFFontConversion.cpp
https://bugs.webkit.org/show_bug.cgi?id=154162
Reviewed by Andreas Kling.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::finishAppendingKERNSubtable):
- 4:39 AM Changeset in webkit [196468] by
-
- 2 edits in trunk/Source/WebCore
Don't invalidate the FontCache on memory pressure.
<https://webkit.org/b/154161>
Reviewed by Antti Koivisto.
Invalidating the FontCache does more harm than good:
- Anything that's still in the cache at this point is also referenced outside the cache, thus will not actually get deleted.
- Future deduplication will fail, leading to more objects.
- The global FontCache generation gets bumped, causing future style recalcs to be less efficient and breaking style sharing.
- All FontSelector invalidation callbacks will fire, potentially causing forced full-document style recalcs.
In fact, the only win from invalidating the FontCache comes from some
minor shrinkage in the containers that make up the cache itself.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory): Deleted.
- 3:37 AM Changeset in webkit [196467] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Allow applications to disable Accelerated Compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=154147
Reviewed by Carlos Garcia Campos.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore): if the environment
variable WEBKIT_DISABLE_COMPOSITING_MODE is defined, then disable AC.
Feb 11, 2016:
- 11:28 PM Changeset in webkit [196466] by
-
- 88 edits in trunk
[Web IDL] interfaces should inherit EventTarget instead of duplicating the EventTarget API
https://bugs.webkit.org/show_bug.cgi?id=154121
<rdar://problem/24613234>
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Interfaces should inherit EventTarget instead of duplicating the
EventTarget API in their IDL. Not only the duplication is ugly and
error-prone, but this also does not match the specifications and
have subtle web-exposed differences.
This patch takes care of all interfaces except for DOMWindow and
WorkerGlobalScope. Those will be updated in the follow-up patch
as they will require a little bit more work and testing.
We should also be able to get rid of the [EventTarget] WebKit IDL
attribute in a follow-up.
No new tests, already covered by existing tests.
- Modules/battery/BatteryManager.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBRequest.h:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/IDBTransaction.idl:
- Modules/mediasession/MediaRemoteControls.idl:
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.h:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.h:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/websockets/WebSocket.idl:
- css/FontLoader.idl:
- dom/EventTarget.h:
- dom/MessagePort.idl:
- dom/Node.h:
- dom/Node.idl:
- dom/WebKitNamedFlow.idl:
- fileapi/FileReader.idl:
- html/MediaController.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrack.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackList.idl:
- html/track/VideoTrackList.idl:
- loader/appcache/DOMApplicationCache.h:
- loader/appcache/DOMApplicationCache.idl:
- page/EventSource.idl:
- page/Performance.h:
- page/Performance.idl:
- workers/Worker.idl:
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.idl:
- xml/XMLHttpRequestUpload.idl:
- Drop hardcoded EventTarget operations and inherit EventTarget instead.
- Drop JSGenerateToNativeObject / JSGenerateToJSObject IDL extended attributes for interfaces inheriting the EventTarget interface as the bindings generator now does this automatically for us.
- On native side, have EventTarget subclass ScriptWrappable instead of each of its subclasses doing so. The issue was that EventTargetOwner::finalize() was calling uncacheWrapper() with an EventTarget*, which would not clear inlined cached wrapped (see clearInlineCachedWrapper()) because EventTarget did not subclass ScriptWrappable. However, cacheWrapper() is called is a specific subtype pointer (e.g. Node*) and we would decide to create an inline cached wrapper because Node subclassed ScriptWrappable (as well as EventTarget).
- WebCore.xcodeproj/project.pbxproj:
Export JSEventTarget.h as private header to fix the build.
- bindings/js/JSDOMBinding.h:
(WebCore::wrapperKey):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::uncacheWrapper):
Use new wrapperKey() function that is generated for each bindings
class that also has wrapperOwner(). This is used instead of the
C cast to void* in order to cast to the base wrapped type to fix
issues with multiple inheritance. The issue was that cacheWrapper()
was getting called with a DOM object subtype pointer (e.g.
AudioContext*) but uncacheWrapper() was getting called with a base
wrapped type pointer (e.g. EventTarget*). Most of our DOM classes
use multiple inheritance and thus the pointer values (used as keys
in the weak map) may differ.
- bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):
Call CREATE_DOM_WRAPPER() with an actual wrapped type (e.g. AudioTrack)
instead of TrackBase type. TrackBase does not have corresponding
generated bindings and therefore does not have a wrapperKey()
function.
- bindings/scripts/CodeGeneratorJS.pm:
(ShouldGenerateToWrapped):
(ShouldGenerateToJSDeclaration):
(GenerateHeader):
- Generate a wrapperKey() utility function along-side wrapperOwner() to help cast to the base wrapped type.
- Generate toWrapped() / toJS() utility functions for interfaces that inherit EventTarget as those are required by our implementation and this avoids having to explicitly have them in the IDL.
- bindings/scripts/test/*:
Rebaseline bindings tests.
LayoutTests:
Rebaseline a couple of layout tests now that interfaces inherit EventTarget
instead of duplicating the EventTarget API in their IDL.
- fast/dom/Window/window-properties-performance-expected.txt:
- fast/dom/prototype-chain-expected.txt:
- 9:21 PM Changeset in webkit [196465] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Land the change that was supposed to be the part of r196463.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._didFetchTestGroups): Select the latest test group by default.
- 9:17 PM Changeset in webkit [196464] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: SourceCodeTextEditor close() generates removeEventListener warnings
https://bugs.webkit.org/show_bug.cgi?id=154150
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-11
Reviewed by Timothy Hatcher.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.close):
Remove the event listeners in the cases that we would have added them.
If we have SourceMap information we should remove the key listener,
and if we don't we should remove the SourceMapAdded listener.
- 9:14 PM Changeset in webkit [196463] by
-
- 7 edits in trunk/Websites/perf.webkit.org
Refine v3 UI's analysis task page
https://bugs.webkit.org/show_bug.cgi?id=154152
Reviewed by Chris Dumez.
This patch makes the following refinements to the analysis task page:
- Always show the relative different of in-progress A/B testing.
- Make the annotations (colored bars) in the chart open other analysis tasks.
- Order the A/B testing groups in the reverse chronological order.
- Select the time range corresponding to the current test group.
- public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer.cssTemplate): Fixed the bug that pending and running testing groups are no longer
colored after r196440. Use a slightly more opaque color for currently running groups compared to pending ones.
- public/v3/components/chart-pane-base.js:
(ChartPaneBase.prototype.setMainSelection): Added.
(ChartPaneBase.prototype._openAnalysisTask): Moved the code from ChartPane._openAnalysisTask so that it can be
reused in both AnalysisTaskChartPane and ChartPane (in charts page).
(ChartPaneBase.prototype.router): Added. Overridden by each subclass.
- public/v3/components/test-group-results-table.js:
(TestGroupResultsTable.prototype.buildRowGroups): Always show the summary (relative difference of A to B) as
long as there are some results in each set.
- public/v3/models/test-group.js:
(TestGroup.prototype.compareTestResults): Always set .label and .fullLabel with the relative change as long as
there are some values. Keep using "pending" and "running" in .status since that would determine the color of
stacking blocks representing those A/B testing groups.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskChartPane):
(AnalysisTaskChartPane.prototype.setPage): Added.
(AnalysisTaskChartPane.prototype.router): Added.
(AnalysisTaskPage):
(AnalysisTaskPage.prototype.render): Show the list of A/B testing groups in the reverse chronological order.
Also set the main chart's selection to the time range of the current test group.
- public/v3/pages/chart-pane.js:
(ChartPane.prototype.router): Added.
(ChartPane.prototype._openAnalysisTask): Moved to ChartPaneBase.prototype._openAnalysisTask.
- 7:24 PM Changeset in webkit [196462] by
-
- 2 edits in trunk/Source/WebKit
Fix internal Windows build.
rdar://problem/24622882
- WebKit.vcxproj/WebKit.proj:
Don't define DEBUG_SUFFIX in release builds.
- 5:30 PM Changeset in webkit [196461] by
-
- 11 edits2 deletes in trunk/Source/WebKit2
Unreviewed, rolling out r196453.
https://bugs.webkit.org/show_bug.cgi?id=154142
This change broke internal iOS builds (Requested by ryanhaddad
on #webkit).
Reverted changeset:
"Move Download authentication code to AuthenticationManager"
https://bugs.webkit.org/show_bug.cgi?id=154132
http://trac.webkit.org/changeset/196453
Patch by Commit Queue <commit-queue@webkit.org> on 2016-02-11
- 5:05 PM Changeset in webkit [196460] by
-
- 3 edits in trunk/Source/WebCore
Optimize texture-complete checks
https://bugs.webkit.org/show_bug.cgi?id=98308
Reviewed by Dean Jackson.
No new tests: No change in behavior.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::initializeNewContext): Initially consider all
textures as suspect.
(WebCore::WebGLRenderingContextBase::extensions): New helper function.
(WebCore::WebGLRenderingContextBase::reshape): Mark textures as invalid when appropriate.
(WebCore::WebGLRenderingContextBase::bindTexture): Identify invalid textures and mark
them for later fix-up. Likewise, remove 'known good' textures from the fix-up pass.
(WebCore::WebGLRenderingContextBase::deleteTexture): Remove instances of the deleted texture
from our set of invalid textures.
(WebCore::WebGLRenderingContextBase::checkTextureCompleteness): Only iterate through
the 'bad' textures, rather than checking every single texture.
- html/canvas/WebGLRenderingContextBase.h:
- 5:05 PM Changeset in webkit [196459] by
-
- 2 edits1 add in trunk/Websites/perf.webkit.org
Add a script to process backlogs created while perf dashboard was in the maintenance mode
https://bugs.webkit.org/show_bug.cgi?id=154140
Reviewed by Chris Dumez.
Added a script to process the backlog JSONs created while the perf dashboard was put in the maintenance mode.
It re-submits each JSON file to the perf dashboard using the same server config file used by syncing scripts.
- public/include/report-processor.php:
(TestRunsGenerator::test_value_list_to_values_by_iterations): Fixed a bug in the error message code. It was
referencing an undeclared variable.
- tools/process-maintenance-backlog.py: Added.
- 4:59 PM Changeset in webkit [196458] by
-
- 3 edits in trunk/Source/WTF
Need WTFCrash workaround for shipping SafariForWebKitDevelopment binaries.
https://bugs.webkit.org/show_bug.cgi?id=154125
Reviewed by Joseph Pecoraro.
Presently shipping SafariForWebKitDevelopment binaries still expect to link to a
WTFCrash function. We need to provide this function as a workaround until we can
update SafariForWebKitDevelopment to use the new inlined version.
We do this by doing:
- Make WTFCrashImpl() the sole function for implementing a crash. The CRASH() macro is now defined to be WTFCrashImpl() instead of WTFCrash().
- Renamed the legacy WTFCrash() to WTFCrashImpl() for debug or non-Darwin builds. For (non-debug && OS(DARWIN)) builds, WTFCrashImpl() will be an inlined function with an asm statement that issues a breakpoint trap.
- Implement WTFCrash() as a function that calls CRASH(). This satisfies the need of shipping SafariForWebKitDevelopment binaries.
- Change WTFCrashWithSecurityImplication() to call CRASH(). This ensures that we have a consistent implementation of how we crash.
- Changed WTFLogAlwaysAndCrash() to call CRASH() instead of WTFCrash(). This is just to have consistency in that all code in the WebKit project now crashes by calling CRASH(), not WTFCrash().
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 4:40 PM Changeset in webkit [196457] by
-
- 2 edits in trunk/Source/WebKit2
Use the system PluginProcess.app for generating plug-in MIME type preferences
https://bugs.webkit.org/show_bug.cgi?id=154139
Reviewed by Dan Bernstein.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::createPropertyListFile):
- 4:31 PM Changeset in webkit [196456] by
-
- 10 edits in trunk/Source
EditingRangeIsRelativeTo::Document and NSRangeIsRelativeTo::Document should
be called EditableRoot instead
https://bugs.webkit.org/show_bug.cgi?id=154138
Reviewed by Alexey Proskuryakov.
EditableRoot is much more accurate than Document.
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _convertToDOMRange:]):
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):
Source/WebKit2:
- Shared/EditingRange.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::insertText):
(WebKit::WebViewImpl::selectedRangeWithCompletionHandler):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::rangeFromEditingRange):
- WebProcess/WebPage/WebPage.h:
- 4:17 PM Changeset in webkit [196455] by
-
- 2 edits in trunk/Source/WebCore
Assert that IDBTransaction::transitionedToFinishing transitions to finishing.
https://bugs.webkit.org/show_bug.cgi?id=154061
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::transitionedToFinishing):
Added assertion that we are transitioning to a finished or finishing state, based on Darin's feedback.
- 4:02 PM Changeset in webkit [196454] by
-
- 5 edits in trunk/Source/JavaScriptCore
Web Inspector: RemoteInspector's listings should include whether an AutomationTarget is paired
https://bugs.webkit.org/show_bug.cgi?id=154077
<rdar://problem/24589133>
Reviewed by Joseph Pecoraro.
Instead of not generating a listing for the target when it is occupied,
generate the listing with a 'paired' flag. The old flag was redundant
because a _WKAutomationDelegate will not create a session if it doesn't
support automation or it already has an active session.
- inspector/remote/RemoteAutomationTarget.cpp:
(Inspector::RemoteAutomationTarget::setIsPaired):
(Inspector::RemoteAutomationTarget::setAutomationAllowed): Deleted.
- inspector/remote/RemoteAutomationTarget.h:
Return false for remoteControlAllowed() if the target is already paired.
This function is used by RemoteInspector to deny incoming connections.
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::listingForAutomationTarget):
- inspector/remote/RemoteInspectorConstants.h:
- 4:02 PM Changeset in webkit [196453] by
-
- 11 edits4 adds in trunk/Source/WebKit2
Move Download authentication code to AuthenticationManager
https://bugs.webkit.org/show_bug.cgi?id=154132
Reviewed by Sam Weinig.
When a video element makes a request that receives an authentication challenge, the
AuthenticationManager receives an AuthenticationChallenge without an AuthenticationClient.
As a result, Download::receivedCredential and other functions were being called, which
sent a message to the challenge's sender. This functionality is not specific to downloads,
so I moved it from Download to AuthenticationManager.
This fixes http/tests/media/video-auth.html when using NetworkSession
because I use AuthenticationManager::receivedCredential if there is no AuthenticationClient
instead of improperly asserting that there is always an AuthenticationClient if there is no
completionHandler.
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/Downloads/ios/DownloadIOS.mm:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
- NetworkProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
- NetworkProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::continueWithoutCredential): Deleted.
(WebKit::Download::useCredential): Deleted.
(WebKit::Download::cancelAuthenticationChallenge): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
- Shared/Authentication/AuthenticationManager.h:
(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):
- Shared/Authentication/cocoa: Added.
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: Added.
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
- Shared/Authentication/soup: Added.
- Shared/Authentication/soup/AuthenticationManagerSoup.cpp: Added.
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
- WebKit2.xcodeproj/project.pbxproj:
- 3:39 PM Changeset in webkit [196452] by
-
- 18 edits in trunk/Source
Soft spaces are often tracked in the wrong spot
https://bugs.webkit.org/show_bug.cgi?id=154127
-and corresponding-
rdar://problem/24493140
Reviewed by Sam Weinig.
Soft spaces are in the wrong space now for two reasons. First of all, the
NSRange we get from the accepted candidate is relative to the paragraph
start, so without this patch, soft spaces are only ever right for the first
paragraph. Secondly, if focus changes for any reason other than text
insertion, soft spaces are also wrong because they need to be re-set.
Source/WebKit/mac:
New version of _convertToDOMRange takes a NSRangeIsRelativeTo so that it can
handle ranges relative to both the document and the paragraph.
- WebView/WebFrame.mm:
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
(-[WebFrame _convertNSRangeToDOMRange:]):
New enum NSRangeIsRelativeTo.
- WebView/WebFrameInternal.h:
Re-set the softSpaceRange on selection changes so long as the WebCore::Editor
is not currently handling an accepted candidate.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionChanged]):
If needToRemoveSoftSpace is true, then the replacementRange is
relative to the paragraph.
(-[WebHTMLView insertText:]):
Source/WebKit2:
New enum can be used to indicate what an EditingRange is relative to.
- Shared/EditingRange.h:
(WebKit::EditingRange::EditingRange):
didHandleAcceptedCandidate is a new message that gets sent from the
WebProcess. This lets us track a bool m_isHandlingAcceptedCandidate.
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::didHandleAcceptedCandidate):
Re-set the m_softSpaceRange on selection changes so long as
m_isHandlingAcceptedCandidate is false.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::selectionDidChange):
Set m_isHandlingAcceptedCandidate to true.
(WebKit::WebViewImpl::handleAcceptedCandidate):
Set m_isHandlingAcceptedCandidate to false.
(WebKit::WebViewImpl::didHandleAcceptedCandidate):
insertTextAsync takes a new parameter indicating what the replacementRange is
relative to. If needToRemoveSoftSpace is true, then the replacementRange is
relative to the paragraph.
(WebKit::WebViewImpl::insertText):
Pipe didHandleAcceptedCandidate through to WebViewImpl.
- UIProcess/PageClient.h:
insertTextAsync takes an EditingRangeIsRelativeTo.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::insertTextAsync):
Pipe didHandleAcceptedCandidate through to WebViewImpl.
(WebKit::WebPageProxy::didHandleAcceptedCandidate):
- UIProcess/WebPageProxy.h:
New message lets the WebProcess tell the UIProcess when the candidate has
been accepted.
- UIProcess/WebPageProxy.messages.in:
Pipe didHandleAcceptedCandidate through to WebViewImpl.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didHandleAcceptedCandidate):
insertTextAsync takes an EditingRangeIsRelativeTo. Pass that through to
rangeFromEditingRange to get the correct range.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::insertTextAsync):
Use the EditingRangeIsRelativeTo to find the right WebCore::Range.
(WebKit::WebPage::rangeFromEditingRange):
Take EditingRangeIsRelativeTo in a few places.
- WebProcess/WebPage/WebPage.h:
InsertTextAsync takes a EditingRangeIsRelativeTo.
- WebProcess/WebPage/WebPage.messages.in:
Send didHandleAccpetedCandidate to the UIProcess
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleAcceptedCandidate):
- 3:17 PM Changeset in webkit [196451] by
-
- 2 edits in tags/Safari-602.1.18.0.4/Source/WebCore
Merged r196445. rdar://problem/24511860
- 3:13 PM Changeset in webkit [196450] by
-
- 5 edits in tags/Safari-602.1.18.8/Source
Versioning.
- 3:12 PM Changeset in webkit [196449] by
-
- 5 edits in tags/Safari-602.1.18.0.4/Source
Versioning.
- 3:11 PM Changeset in webkit [196448] by
-
- 1 copy in tags/Safari-602.1.18.8
New tag.
- 3:07 PM Changeset in webkit [196447] by
-
- 1 copy in tags/Safari-602.1.18.0.4
New tag.
- 3:06 PM Changeset in webkit [196446] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG::ByteCodeParser needs to null check the result of presenceLike()
https://bugs.webkit.org/show_bug.cgi?id=154135
rdar://problem/24291586
Reviewed by Geoffrey Garen.
ByteCodeParser::presenceLike() could return a null object property condition if it detects a
contradiction. That could happen due to bogus profiling. It's totally OK - we just need to
bail from using a property condition when that happens.
- bytecode/ObjectPropertyCondition.h:
(JSC::ObjectPropertyCondition::equivalence):
(JSC::ObjectPropertyCondition::operator bool):
(JSC::ObjectPropertyCondition::object):
(JSC::ObjectPropertyCondition::condition):
(JSC::ObjectPropertyCondition::operator!): Deleted.
- bytecode/PropertyCondition.h:
(JSC::PropertyCondition::equivalence):
(JSC::PropertyCondition::operator bool):
(JSC::PropertyCondition::kind):
(JSC::PropertyCondition::uid):
(JSC::PropertyCondition::operator!): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::check):
(JSC::DFG::ByteCodeParser::load):
- 3:04 PM Changeset in webkit [196445] by
-
- 2 edits in trunk/Source/WebCore
WebContent process crashes when performing data detection on content with existing data detector links.
https://bugs.webkit.org/show_bug.cgi?id=154118
rdar://problem/24511860
Reviewed by Tim Horton.
The DOM mutation caused by removing the existing links, can shift the range endpoints.
We now save the range enpoints as positions so that we can recreate the ranges,
if a DOM mutation occurred.
- editing/cocoa/DataDetection.mm:
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::detectContentInRange):
- 3:01 PM Changeset in webkit [196444] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] SqrtFloat and CeilFloat also suffer from partial register stalls
https://bugs.webkit.org/show_bug.cgi?id=154131
Reviewed by Filip Pizlo.
Looks like I forgot to update this when adding Float support.
Credit to Filip for finding this issue.
- b3/air/AirFixPartialRegisterStalls.cpp:
- 2:52 PM Changeset in webkit [196443] by
-
- 3 edits in trunk/Websites/perf.webkit.org
AnalysisResultsViewer never uses this._smallerIsBetter
https://bugs.webkit.org/show_bug.cgi?id=154134
Reviewed by Chris Dumez.
Removed the unused instance variable _smallerIsBetter from AnalysisResultsViewer and TestGroupStackingBlock.
- public/v3/components/analysis-results-viewer.js:
(AnalysisResultsViewer): Removed the unused _smallerIsBetter.
(AnalysisResultsViewer.prototype.setSmallerIsBetter): Deleted.
(AnalysisResultsViewer.prototype.buildRowGroups):
(AnalysisResultsViewer.TestGroupStackingBlock): Removed the unused _smallerIsBetter.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._didFetchTask):
- 2:34 PM Changeset in webkit [196442] by
-
- 9 edits in trunk/Source/WebCore
Make MediaResourceLoader behave more like a CachedResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=154117
Reviewed by Alex Christensen.
MediaResourceLoader currently can only handle a single request at a time. Split the class
into two, MediaResourceLoader and MediaResource, effectively wrapping CachedResourceLoader
and CachedRawResource respectively. With this devision, the same loader can be used to issue
multiple simultaneous resource requests.
This necessecitates splitting PlatformMediaResource into two classes as well. To simplify
the HTMLMediaElement, MediaPlayer, and MediaPlayerClient APIs, do not require a client
object when creating the loader; instead, the client is required to create the resource.
This also matches the CachedRawResource API.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCreateResourceLoader): Remove the client parameter.
- html/HTMLMediaElement.h:
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::MediaResourceLoader):
(WebCore::MediaResourceLoader::~MediaResourceLoader):
(WebCore::MediaResourceLoader::requestResource): Renamed from start().
(WebCore::MediaResourceLoader::removeResource): Remove resource from live resource list.
(WebCore::MediaResource::create): Utility factory.
(WebCore::MediaResource::MediaResource):
(WebCore::MediaResource::~MediaResource):
(WebCore::MediaResource::stop): Moved from MediaResourceLoader.
(WebCore::MediaResource::setDefersLoading): Ditto.
(WebCore::MediaResource::responseReceived): Ditto.
(WebCore::MediaResource::redirectReceived): Ditto.
(WebCore::MediaResource::dataSent): Ditto.
(WebCore::MediaResource::dataReceived): Ditto.
(WebCore::MediaResource::notifyFinished): Ditto.
(WebCore::MediaResource::getOrCreateReadBuffer): Ditto.
- loader/MediaResourceLoader.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::createResourceLoader):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCreateResourceLoader):
- platform/graphics/PlatformMediaResourceLoader.h:
(WebCore::PlatformMediaResourceClient::~PlatformMediaResourceClient): Renamed from PlatformMediaResourceLoaderClient.
(WebCore::PlatformMediaResourceClient::responseReceived): Client methods now take a reference to the resource.
(WebCore::PlatformMediaResourceClient::redirectReceived): Ditto.
(WebCore::PlatformMediaResourceClient::dataSent): Ditto.
(WebCore::PlatformMediaResourceClient::dataReceived): Ditto.
(WebCore::PlatformMediaResourceClient::accessControlCheckFailed): Ditto.
(WebCore::PlatformMediaResourceClient::loadFailed): Ditto.
(WebCore::PlatformMediaResourceClient::loadFinished): Ditto.
(WebCore::PlatformMediaResourceClient::getOrCreateReadBuffer): Ditto.
(WebCore::PlatformMediaResourceLoader::PlatformMediaResourceLoader): Ditto.
(WebCore::PlatformMediaResource::PlatformMediaResource):
(WebCore::PlatformMediaResource::~PlatformMediaResource):
(WebCore::PlatformMediaResource::setClient):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
(webKitWebSrcNeedData):
(webKitWebSrcEnoughData):
(CachedResourceStreamingClient::getOrCreateReadBuffer):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::accessControlCheckFailed):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::loadFinished):
- 2:28 PM Changeset in webkit [196441] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix after r196440.
- public/v3/models/test-group.js:
(TestGroup.prototype.addBuildRequest): Clear the map instead of setting the property to null.
- 2:17 PM Changeset in webkit [196440] by
-
- 9 edits in trunk/Websites/perf.webkit.org
Perf dashboard should have UI to retry A/B testing
https://bugs.webkit.org/show_bug.cgi?id=154090
Reviewed by Chris Dumez.
Added a button to re-try an existing A/B testing group with a custom repetition count. The same button functions
as a way of confirming the progression/regression when there have been no A/B testing scheduled in the task.
Also fixed the bug that A/B testing groups that have been waiting for other test groups will be shown as "running".
- public/v3/components/results-table.js:
(ResultsTable.cssTemplate): Don't pad the list of extra repositories when it's empty.
- public/v3/components/test-group-results-table.js:
(TestGroupResultsTable.prototype.buildRowGroups): Use TestGroup.labelForRootSet instead of manually
computing the letter for each configuration set.
- public/v3/models/build-request.js:
(BuildRequest.prototype.hasStarted): Added.
- public/v3/models/data-model.js:
(DataModelObject.ensureSingleton): Added.
(DataModelObject.cachedFetch): Added noCache option. This is used when re-fetching the test groups after
creating one.
- public/v3/models/measurement-cluster.js:
(MeasurementCluster.prototype.startTime): Added.
- public/v3/models/measurement-set.js:
(MeasurementSet.prototype.hasFetchedRange): Added. Returns true only if there are no "holes" (cluster
yet to be fetched) between the specified time range. This was added to fix a bug in AnalysisTaskPage's
_didFetchMeasurement.
- public/v3/models/test-group.js:
(TestGroup): Added this._rootSetToLabel.
(TestGroup.prototype.addBuildRequest): Reset this._rootSetToLabel along with this._requestedRootSets.
(TestGroup.prototype.repetitionCount): Added. Returns the number of iterations executed per set. We assume that
every root set in the test group shares a single repetition count.
(TestGroup.prototype.requestedRootSets): Now populates this._rootSetToLabel for labelForRootSet.
(TestGroup.prototype.labelForRootSet): Added.
(TestGroup.prototype.hasStarted): Added.
(TestGroup.prototype.compareTestResults): Use 'running' and 'pending' to differentiate test groups that are waiting
for other groups to finish running from the ones that are actually running ('incomplete' before this patch).
(TestGroup.fetchByTask):
(TestGroup.createAndRefetchTestGroups): Added. Creates a new test group using the privileged-api/create-test-group
and fetches the list of test groups for the specified analysis task.
(TestGroup._createModelsFromFetchedTestGroups): Extracted from TestGroup.fetchByTask.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage): Initialize _renderedCurrentTestGroup to undefined so that we'd always can differentiate
the initial call to AnalysisTaskPage.render and subsequent calls in which it's identical to _currentTestGroup.
(AnalysisTaskPage.prototype._didFetchMeasurement): Fixed a bug that we don't exit early even when some
clusters in between startPoint and endPoint are still being fetched via newly added hasFetchedRange.
(AnalysisTaskPage.prototype.render): Update the default repetition count based on the current test group.
Also update the label of the button to "Confirm the change" if there is no A/B testing in this task.
(AnalysisTaskPage.prototype._retryCurrentTestGroup): Added. Re-triggers an existing A/B testing group or creates
the A/B testing for the entire range of the analysis task.
(AnalysisTaskPage.prototype._hasDuplicateTestGroupName): Added.
(AnalysisTaskPage.prototype._createRetryNameForTestGroup): Added.
(AnalysisTaskPage.htmlTemplate): Added form controls to re-trigger A/B testing.
(AnalysisTaskPage.cssTemplate): Updated the style.
- 2:15 PM Changeset in webkit [196439] by
-
- 37 edits in trunk
Subpixel rendering: Make focusring painting subpixel aware.
https://bugs.webkit.org/show_bug.cgi?id=154111
Reviewed by David Hyatt.
Do not integral snap focusring rects while collecting them (use device pixel snapping instead
right before passing them to GraphicsContext::drawFocusRing).
Source/WebCore:
Unable to test.
- platform/graphics/GraphicsContext.h:
- platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawFocusRingRects::create):
(WebCore::DisplayList::DrawFocusRingRects::rects):
(WebCore::DisplayList::DrawFocusRingRects::DrawFocusRingRects):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawFocusRing):
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlock::addFocusRingRects):
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects):
- rendering/RenderBox.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::paintFocusRing):
(WebCore::RenderElement::issueRepaintForOutlineAuto):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::addFocusRingRects):
- rendering/RenderInline.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
- rendering/RenderListBox.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect):
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
- rendering/RenderTextControl.h:
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects):
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects):
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::addFocusRingRects):
- rendering/svg/RenderSVGShape.h:
LayoutTests:
- platform/mac/accessibility/image-link-expected.txt:
- platform/mac/accessibility/mac/aria-columnrowheaders-expected.txt: Copied from LayoutTests/platform/mac/accessibility/table-cells-expected.txt.
- platform/mac/accessibility/mac/document-links-expected.txt: Added.
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- platform/mac/accessibility/table-with-rules-expected.txt:
- 2:12 PM Changeset in webkit [196438] by
-
- 3 edits in trunk/Source/WebCore
Addressing post-review comments after r196393
Unreviewed.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSSegmentedFontFace.h:
- 2:09 PM Changeset in webkit [196437] by
-
- 2 edits in trunk/Source/JavaScriptCore
Cannot call initializeIndex() if we didn't create the array using tryCreateUninitialized()
https://bugs.webkit.org/show_bug.cgi?id=154126
Reviewed by Saam Barati.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
- 1:45 PM Changeset in webkit [196436] by
-
- 2 edits in trunk/Tools
Large logs can bring down the webkit master
https://bugs.webkit.org/show_bug.cgi?id=122112
Reviewed by Lucas Forschler.
Implement the suggested fix of throwing away stdout / stderr.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKit1LeakTests):
- 1:43 PM Changeset in webkit [196435] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix windows build.
- DOMCoreClasses.cpp:
(DOMElement::style):
(DOMElement::offsetLeft):
- 1:24 PM Changeset in webkit [196434] by
-
- 11 edits in trunk
[INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()
https://bugs.webkit.org/show_bug.cgi?id=147602
Reviewed by Darin Adler.
Source/JavaScriptCore:
This patch implements Intl.NumberFormat.prototype.resolvedOptions() according
to the ECMAScript 2015 Internationalization API spec (ECMA-402 2nd edition.)
- runtime/IntlDateTimeFormat.cpp:
(JSC::localeData):
- runtime/IntlNumberFormat.cpp:
(JSC::localeData):
(JSC::computeCurrencySortKey):
(JSC::extractCurrencySortKey):
(JSC::computeCurrencyDigits):
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::resolvedOptions):
(JSC::IntlNumberFormat::setBoundFormat):
- runtime/IntlNumberFormat.h:
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::constructIntlNumberFormat):
(JSC::callIntlNumberFormat):
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):
- runtime/IntlObject.cpp:
(JSC::intlNumberOption):
(JSC::numberingSystemsForLocale):
(JSC::getNumberingSystemsForLocale): Deleted.
- runtime/IntlObject.h:
LayoutTests:
- js/intl-numberformat-expected.txt:
- js/script-tests/intl-numberformat.js:
(testNumberFormat):
- 1:22 PM Changeset in webkit [196433] by
-
- 4 edits in trunk/Source/JavaScriptCore
MacroAssemblerX86 should be happy with shift(cx, cx)
https://bugs.webkit.org/show_bug.cgi?id=154124
Reviewed by Saam Barati.
Prior to this change the assembler asserted that shift_amount and dest cannot be the same.
That's a good assertion for when shift_amount is not in cx. But if it's in cx already then
it's OK for them to be the same. Air will sometimes do shift(cx, cx) if you do "x << x" and
the coalescing got particularly clever.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::lshift64):
(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::urshift64):
- b3/testb3.cpp:
(JSC::B3::testLShiftSelf32):
(JSC::B3::testRShiftSelf32):
(JSC::B3::testURShiftSelf32):
(JSC::B3::testLShiftSelf64):
(JSC::B3::testRShiftSelf64):
(JSC::B3::testURShiftSelf64):
(JSC::B3::run):
- 1:04 PM Changeset in webkit [196432] by
-
- 2 edits in trunk/Source/JavaScriptCore
The sampling profiler's stack walker methods should be marked with SUPPRESS_ASAN
https://bugs.webkit.org/show_bug.cgi?id=154123
Reviewed by Mark Lam.
The entire premise of the sampling profiler is to load from
another thread's memory. We should SUPPRESS_ASAN on the
methods that do this.
- runtime/SamplingProfiler.cpp:
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::advanceToParentFrame):
(JSC::FrameWalker::isAtTop):
(JSC::FrameWalker::resetAtMachineFrame):
- 12:50 PM Changeset in webkit [196431] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196423
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 12:33 PM Changeset in webkit [196430] by
-
- 12 edits in trunk/Source/WebCore
Rename Element::style() to Element::cssomStyle()
https://bugs.webkit.org/show_bug.cgi?id=154107
Reviewed by Alex Christensen.
It implements the IDL "style" attribute that returns a CSSOM object.
Inside WebCore "style" generally refers to a RenderStyle.
- dom/Element.cpp:
(WebCore::Element::hasAttributeNS):
(WebCore::Element::cssomStyle):
(WebCore::Element::focus):
(WebCore::Element::style): Deleted.
- dom/Element.h:
(WebCore::Element::tagQName):
- dom/Element.idl:
- dom/StyledElement.cpp:
(WebCore::StyledElement::~StyledElement):
(WebCore::StyledElement::cssomStyle):
(WebCore::StyledElement::style): Deleted.
- dom/StyledElement.h:
(WebCore::StyledElement::synchronizeStyleAttributeInternal):
(WebCore::StyledElement::collectStyleForPresentationAttribute):
- editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToElement):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
(WebCore::InspectorStyleSheetForInlineStyle::inlineStyle):
(WebCore::InspectorStyleSheetForInlineStyle::elementStyleText):
- svg/SVGElement.idl:
- 11:52 AM Changeset in webkit [196429] by
-
- 8 edits1 add in trunk
[cmake] Consolidate TextureMapper file and include dir lists.
https://bugs.webkit.org/show_bug.cgi?id=154106
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-11
Reviewed by Michael Catanzaro.
.:
- Source/cmake/OptionsEfl.cmake: Expose USE_TEXTURE_MAPPER_GL to
CMake code.
- Source/cmake/OptionsWinCairo.cmake: Ditto.
Source/WebCore:
No new tests needed.
- CMakeLists.txt: Moved texmap include dir and source list to
TextureMapper.cmake, removed non-existent include dir "filters/texmap".
- PlatformEfl.cmake: Moved texmap and coordinatedgraphics include
dirs and source list to TextureMapper.cmake.
- PlatformGTK.cmake: Ditto, also removed non-existent include dir
"texmap/threadedcompositor"
- PlatformWinCairo.cmake: Moved texmap files to TextureMapper.cmake.
- platform/TextureMapper.cmake: Added.
- 11:49 AM Changeset in webkit [196428] by
-
- 6 edits in trunk/Source/WebKit2
Use BlobResourceHandle when loading blob urls, even when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=154096
Reviewed by Brady Eidson.
This fixes at least http/tests/xmlhttprequest/blob-request-byte-range.html.
- NetworkProcess/NetworkDataTask.h:
Renamed NetworkDataTaskClient::didReceiveResponse to didReceiveResponseNetworkSession
to avoid conflicting with ResourceHandleClient::didReceiveResponse.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
Make a BlobResourceHandle instead of a NetworkDataTask if we have a request for a blob url.
(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::setDefersLoading):
(WebKit::NetworkLoad::cancel):
(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::sharedDidReceiveResponse):
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::setPendingDownloadID):
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
(WebKit::NetworkLoad::cannotShowURL):
(WebKit::NetworkLoad::didReceiveResponseAsync):
(WebKit::NetworkLoad::willSendRequestAsync):
(WebKit::NetworkLoad::canAuthenticateAgainstProtectionSpaceAsync):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkLoad::supportsDataArray):
(WebKit::NetworkLoad::didReceiveDataArray):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::receivedCancellation):
(WebKit::NetworkLoad::didReceiveResponse): Deleted.
Compile ResourceHandleClient when using NetworkSession because it is used for blobs now.
Also, add null checks because we now have NetworkLoads where either m_task or m_handle is always null.
- NetworkProcess/NetworkLoad.h:
(WebKit::NetworkLoad::pendingDownloadID):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
- NetworkProcess/mac/NetworkLoadMac.mm:
(WebKit::NetworkLoad::willCacheResponseAsync):
- 11:43 AM Changeset in webkit [196427] by
-
- 2 edits in tags/Safari-602.1.18.7/Source/WebKit/win
Merged r195828. rdar://problem/24611721
- 11:39 AM Changeset in webkit [196426] by
-
- 5 edits in tags/Safari-602.1.18.7/Source
Versioning.
- 11:36 AM Changeset in webkit [196425] by
-
- 1 copy in tags/Safari-602.1.18.7
New tag.
- 10:51 AM Changeset in webkit [196424] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed build fix after r196421.
Removed BASSERTs that are firing to eliminate Debug build crashes. I'll debug locally and
enable or alter after the issue is understood.
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::merge): Removed BASSERTs that are firing.
- 10:23 AM Changeset in webkit [196423] by
-
- 40 edits in trunk
Move 'length' property to the prototype
https://bugs.webkit.org/show_bug.cgi?id=154051
<rdar://problem/24577385>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
- web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Element-children-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/attributes-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move 'length' property to the prototype, where it should be. We used to
keep it on the instance because our implementation of
getOwnPropertySlot() was wrong for interfaces with a named property
getter. However, our implementation of getOwnPropertySlot() is now
spec-compliant so this should be OK.
Moving 'length' to the prototype is also a little bit risky in terms of
performance, especially for HTMLCollection / NodeList. However, I did
not see an impact on realistic benchmarks like Speedometer and only saw
a small impact (< 5%) on micro-benchmarks. I propose we make our behavior
correct and monitor performance. If we see any benchmark we care about
regress then we should try and optimize while keeping the attribute on
the prototype.
No new tests, already covered by existing tests.
- bindings/js/JSDOMBinding.h:
(WebCore::getStaticValueSlotEntryWithoutCaching):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
(WebCore::JSHTMLDocument::nameGetter): Deleted.
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::putDelegate):
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::deletePropertyByIndex):
(WebCore::JSStorage::putDelegate):
Leverage the new hasStaticPropertyTable static property in the
generated bindings for performance.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Generate a "hasStaticPropertyTable" static const boolean property
for each bindings class so we can check at build time if
ClassInfo::staticPropHashTable is null.
(AttributeShouldBeOnInstance):
Move "length" to the prototype.
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.h:
Rebaseline bindings tests.
LayoutTests:
Rebaseline a couple of existing layout tests now that 'length' is
on the prototype.
- fast/dom/htmlcollection-getownpropertynames-expected.txt:
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
- 10:19 AM Changeset in webkit [196422] by
-
- 2 edits in trunk/Source/WebCore
Fix the !(ENABLE(SHADOW_DOM) ENABLE(DETAILS_ELEMENT)) after r196281 https://bugs.webkit.org/show_bug.cgi?id=154035
Reviewed by Antti Koivisto.
Follow-up fix after r196365. Removed guards around slotNodeIndex.
- dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::Context::Context):
- 8:01 AM Changeset in webkit [196421] by
-
- 4 edits in trunk/Source/bmalloc
bmalloc: large aligned allocations will put 1 or 2 free object on free list without merging with free neighbors
https://bugs.webkit.org/show_bug.cgi?id=154091
Reviewed by Geoffrey Garen.
If we split off any unused free object in the aligned version of Heap::allocateLarge(), we merge them with
free neighbors before putting them back on the free list. Added helpers to verify that when we
add LargeObjects to the free list their neighbors are allocated.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateLarge): Deleted private helper version and rolled it into the two the
two public versions of allocateLarge().
- bmalloc/Heap.h:
- bmalloc/LargeObject.h:
(bmalloc::LargeObject::prevIsAllocated): New helper.
(bmalloc::LargeObject::nextIsAllocated): New helper.
(bmalloc::LargeObject::merge): Check that the merge object has allocated neighbors.
- 6:30 AM Changeset in webkit [196420] by
-
- 3 edits in trunk/Source/WebKit2
Bug 154103 - [GTK] Build error after bug 154046
https://bugs.webkit.org/show_bug.cgi?id=154103
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitUserContent.cpp:
(_WebKitUserStyleSheet::_WebKitUserStyleSheet):
(webkitUserStyleSheetGetUserStyleSheet):
- UIProcess/API/gtk/WebKitUserContentPrivate.h:
- 3:52 AM Changeset in webkit [196419] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed typo fix after r190063.
- dfg/DFGSpeculativeJIT.cpp: Removed property svn:executable.
- dfg/DFGSpeculativeJIT.h: Removed property svn:executable.
- jit/JIT.h: Removed property svn:executable.
- jit/JITInlines.h: Removed property svn:executable.
- jit/JITOpcodes.cpp: Removed property svn:executable.
- 3:49 AM Changeset in webkit [196418] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Unreviewed typo fix after r190063.
- dfg/DFGSpeculativeJIT.cpp: Removed property svn:executable.
- dfg/DFGSpeculativeJIT.h: Removed property svn:executable.
- jit/JIT.h: Removed property svn:executable.
- jit/JITInlines.h: Removed property svn:executable.
- jit/JITOpcodes.cpp: Removed property svn:executable.
- 2:40 AM Changeset in webkit [196417] by
-
- 11 edits in trunk/LayoutTests
Use Testharness.js for the MathML script tests
https://bugs.webkit.org/show_bug.cgi?id=154065
Reviewed by Darin Adler.
- mathml/opentype/large-operators-munderover-expected.txt:
- mathml/opentype/large-operators-munderover.html:
- mathml/presentation/inferred-mrow-baseline-expected.txt:
- mathml/presentation/inferred-mrow-baseline.html:
- mathml/presentation/inferred-mrow-stretchy-expected.txt:
- mathml/presentation/inferred-mrow-stretchy.html:
- mathml/presentation/stretchy-depth-height-expected.txt:
- mathml/presentation/stretchy-depth-height-symmetric-expected.txt:
- mathml/presentation/stretchy-depth-height-symmetric.html:
- mathml/presentation/stretchy-depth-height.html:
- 12:11 AM Changeset in webkit [196416] by
-
- 2 edits in trunk/PerformanceTests
Fix a missing refactoring.
- Animometer/tests/master/resources/multiply.js:
(animate): Move to Utilities.lerp.
(_lerp): Deleted.
Feb 10, 2016:
- 11:42 PM Changeset in webkit [196415] by
-
- 6 edits6 adds in trunk/PerformanceTests
Add new benchmark tests.
https://bugs.webkit.org/show_bug.cgi?id=154063
Provisionally reviewed by Said Abou-Hallawa.
Add tests for get/put image data, filters, opacity, and css transforms.
- Animometer/resources/runner/benchmark-runner.js:
(_runBenchmarkAndRecordResults): Update the body background color to match that of
the stage.
(this._runNextIteration): Clear the background color style for the results page.
- Animometer/resources/runner/tests.js:
- Animometer/tests/master/focus.html: Added.
- Animometer/tests/master/image-data.html: Added.
- Animometer/tests/master/multiply.html: Added.
- Animometer/tests/master/resources/focus.js: Added.
- Animometer/tests/master/resources/image-data.js: Added.
- Animometer/tests/master/resources/multiply.js: Added.
- Animometer/tests/master/resources/stage.css: Move common styles out.
- Animometer/tests/resources/main.js: Update Stage.randomBool to use Math.random.
Add Stage.randomSign for randomly setting a direction. Add the notion of the
current timestamp of the test to Benchmark, since some animations cycle through
colors and rely on an incremental counter like the time.
- 8:06 PM Changeset in webkit [196414] by
-
- 11 edits1 add in trunk/Source/JavaScriptCore
Symbol.species accessors on builtin constructors should be configurable
https://bugs.webkit.org/show_bug.cgi?id=154097
Reviewed by Benjamin Poulain.
We did not have the Symbol.species accessors on our builtin constructors
marked as configurable. This does not accurately follow the ES6 spec as
the ES6 spec states that all default accessors on builtins should be
configurable. This means that we need an additional watchpoint on
ArrayConstructor to make sure that no users re-configures Symbol.species.
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
- runtime/ArrayPrototype.cpp:
(JSC::speciesConstructArray):
(JSC::ArrayPrototype::setConstructor):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
- runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::didChangeConstructorOrSpeciesProperties):
(JSC::ArrayPrototype::didChangeConstructorProperty): Deleted.
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSArrayBufferConstructor::finishCreation):
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::finishCreation):
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
- runtime/MapConstructor.cpp:
(JSC::MapConstructor::finishCreation):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::finishCreation):
- runtime/SetConstructor.cpp:
(JSC::SetConstructor::finishCreation):
- tests/stress/array-species-config-array-constructor.js: Added.
(A):
- tests/stress/symbol-species.js:
(testSymbolSpeciesOnConstructor):
- 7:20 PM Changeset in webkit [196413] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 7:20 PM Changeset in webkit [196412] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 6:21 PM Changeset in webkit [196411] by
-
- 1 copy in tags/Safari-601.1.46.98
New tag.
- 6:21 PM Changeset in webkit [196410] by
-
- 1 copy in tags/Safari-601.5.16
New tag.
- 5:35 PM Changeset in webkit [196409] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] The destination of Sqrt should be Def, not UseDef
https://bugs.webkit.org/show_bug.cgi?id=154086
Reviewed by Geoffrey Garen.
An unfortunate copy-paste: the destination of SqrtDouble and SqrtFloat
was defined as UseDef. As a result, the argument would be interfering
with everything defined prior.
- b3/air/AirOpcode.opcodes:
- 5:18 PM Changeset in webkit [196408] by
-
- 2 edits in trunk/LayoutTests
Removing deleted tests from ios-simulator TestExpectations
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:00 PM Changeset in webkit [196407] by
-
- 2 edits in trunk/Source/WebCore
Updating bindings test reference file for JSTestEventConstructor.cpp after r196400
Unreviewed test gardening.
No new tests needed.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
- 4:52 PM Changeset in webkit [196406] by
-
- 2 edits1 add2 deletes in trunk/Source/WebInspectorUI
Web Inspector: Add new icon for the Timeline Recording navigation bar item
https://bugs.webkit.org/show_bug.cgi?id=154089
rdar://problem/24595652
Reviewed by Brian Burg.
- UserInterface/Images/Stopwatch.png: Removed.
- UserInterface/Images/Stopwatch@2x.png: Removed.
- UserInterface/Images/Stopwatch.svg: Added.
- UserInterface/Views/TimelineIcons.css:
(.stopwatch-icon .icon): Use Stopwatch.svg.
(body:not(.mac-platform, .windows-platform) .stopwatch-icon .icon): Added for GTK+.
- 4:44 PM Changeset in webkit [196405] by
-
- 1 edit1 add in trunk/LayoutTests
Adding an ios-simulator expectation for fast/dom/event-handler-attributes.html
https://bugs.webkit.org/show_bug.cgi?id=153763
Unreviewed test gardening.
- platform/ios-simulator/fast/dom/event-handler-attributes-expected.txt: Added.
- 4:32 PM Changeset in webkit [196404] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Switching actions in Edit Breakpoint popover causes a jerk
https://bugs.webkit.org/show_bug.cgi?id=154093
<rdar://problem/24597869>
Reviewed by Timothy Hatcher.
Adjusted CodeMirror eval editor styles to match vanilla input field.
- UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-eval-editor):
- 4:29 PM Changeset in webkit [196403] by
-
- 6 edits in trunk/Tools
Remove calls to parseInt in order to work with non-integer revisions
https://bugs.webkit.org/show_bug.cgi?id=153820
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.sourceStampChanges): Remove calls to parseInt in order to work with non-integer
revisions.
(BuildbotIteration.prototype._parseData): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js:
(MockBuildbotQueueView.prototype._latestProductiveIteration): Change integers to strings in test code.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac.prototype.get oldestRecordedRevisionNumber): Ditto.
(MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Ditto.
- 4:29 PM Changeset in webkit [196402] by
-
- 5 edits in trunk/Tools
Teach dashboard code to compare non-integer revisions
https://bugs.webkit.org/show_bug.cgi?id=152345
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.compareIterationsByRevisions): Compare non-integer revisions.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._appendPendingRevisionCount): Use Trac.indexOfRevision in order to compare non-integer
revisions. Also uses new Trac.commitsOnBranchLaterThanRevision method.
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Ditto.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Use Trac.indexOfRevision in order to compare non-integer
revisions. Also uses new Trac.nextRevision method to calculate a revision range.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._commitsOnBranch): Renamed this to indicate that it should be a private method used by the latter two new
methods.
(Trac.prototype.commitsOnBranchLaterThanRevision): Finds revisions on a branch later than the specified revision.
(Trac.prototype.commitsOnBranchInRevisionRange): Finds revisions on a branch within a specified range.
(Trac.prototype.nextRevision): Finds the next revision after a given revision on a specific branch.
(Trac.prototype.indexOfRevision): Finds the index of a given revision within the recordedCommits array.
(Trac.prototype.commitsOnBranch): Deleted. Renamed to _commitsOnBranch.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests.
- 4:10 PM Changeset in webkit [196401] by
-
- 12 edits in trunk
Update "manual" caption track logic
https://bugs.webkit.org/show_bug.cgi?id=154084
<rdar://problem/24530516>
Reviewed by Dean Jackson.
No new tests, media/track/track-manual-mode.html was updated.
- English.lproj/Localizable.strings: Add new string.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTextTrack): track.setManualSelectionMode is no more.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Never enable a track automatically when
in manual selection mode.
(WebCore::HTMLMediaElement::captionPreferencesChanged): track.setManualSelectionMode is no more.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::containsOnlyForcedSubtitles): Return true for forced tracks.
(WebCore::TextTrack::kind): Deleted.
- html/track/TextTrack.h:
- html/track/TrackBase.h:
(WebCore::TrackBase::kind): De-virtualize, nobody overrides it.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::trackDisplayName): Include "forced" in the name of forced tracks.
- platform/LocalizedStrings.cpp:
(WebCore::forcedTrackMenuItemText): New.
- platform/LocalizedStrings.h:
- 4:03 PM Changeset in webkit [196400] by
-
- 100 edits in trunk/Source
Rename *Event::create* which creates events for bindings to *Event::createForBindings* and cleanup corresponding paths
https://bugs.webkit.org/show_bug.cgi?id=153903
<rdar://problem/24518146>
Reviewed by Darin Adler.
Source/WebCore:
Rename Event::create(const AtomicString&, const EventInit&) to Event::createForBindings
(const AtomicString&, const EventInit&) and for all the subclasses as well in order to
support Event.isTrusted. Besides, some of the subclasses use the create method for bindings
to create events not for bindings and vice versa. Therefore, this patch also cleanup
corresponding paths to ensure no misuse of the create mehtod. The same for Event::create()
as it is combined with Event::initEvent to create an event for bindings for legacy content.
After this patch, all call sites of *Event::create* are supposed to use *Event::create
to create events for user agent and *Event::createForBindings for bindings.
No change in behavior.
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
(WebCore::WebKitPlaybackTargetAvailabilityEvent::create):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::createForBindings):
(WebCore::WebKitPlaybackTargetAvailabilityEventInit::WebKitPlaybackTargetAvailabilityEventInit): Deleted.
- Modules/encryptedmedia/MediaKeyMessageEvent.cpp:
(WebCore::MediaKeyMessageEvent::MediaKeyMessageEvent):
(WebCore::MediaKeyMessageEventInit::MediaKeyMessageEventInit): Deleted.
- Modules/encryptedmedia/MediaKeyMessageEvent.h:
(WebCore::MediaKeyMessageEvent::create):
(WebCore::MediaKeyMessageEvent::createForBindings):
- Modules/encryptedmedia/MediaKeyNeededEvent.cpp:
(WebCore::MediaKeyNeededEvent::MediaKeyNeededEvent):
(WebCore::MediaKeyNeededEventInit::MediaKeyNeededEventInit): Deleted.
- Modules/encryptedmedia/MediaKeyNeededEvent.h:
(WebCore::MediaKeyNeededEvent::create):
(WebCore::MediaKeyNeededEvent::createForBindings):
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::sendMessage):
- Modules/gamepad/GamepadEvent.h:
(WebCore::GamepadEvent::create):
(WebCore::GamepadEvent::createForBindings):
(WebCore::GamepadEventInit::GamepadEventInit): Deleted.
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEvent::createForBindings):
(WebCore::UIRequestEvent::UIRequestEvent):
(WebCore::UIRequestEventInit::UIRequestEventInit): Deleted.
(WebCore::UIRequestEvent::create): Deleted.
- Modules/indieui/UIRequestEvent.h:
- Modules/mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEvent::createForBindings):
(WebCore::MediaStreamEventInit::MediaStreamEventInit): Deleted.
(WebCore::MediaStreamEvent::create): Deleted.
- Modules/mediastream/MediaStreamEvent.h:
- Modules/mediastream/MediaStreamTrackEvent.cpp:
(WebCore::MediaStreamTrackEvent::createForBindings):
(WebCore::MediaStreamTrackEventInit::MediaStreamTrackEventInit): Deleted.
(WebCore::MediaStreamTrackEvent::create): Deleted.
- Modules/mediastream/MediaStreamTrackEvent.h:
- Modules/mediastream/RTCDTMFToneChangeEvent.cpp:
(WebCore::RTCDTMFToneChangeEvent::createForBindings):
(WebCore::RTCDTMFToneChangeEvent::create): Deleted.
- Modules/mediastream/RTCDTMFToneChangeEvent.h:
- Modules/mediastream/RTCDataChannelEvent.cpp:
(WebCore::RTCDataChannelEvent::createForBindings):
(WebCore::RTCDataChannelEvent::create): Deleted.
- Modules/mediastream/RTCDataChannelEvent.h:
- Modules/mediastream/RTCIceCandidateEvent.cpp:
(WebCore::RTCIceCandidateEvent::createForBindings):
(WebCore::RTCIceCandidateEvent::create): Deleted.
- Modules/mediastream/RTCIceCandidateEvent.h:
- Modules/mediastream/RTCTrackEvent.cpp:
(WebCore::RTCTrackEvent::createForBindings):
(WebCore::RTCTrackEventInit::RTCTrackEventInit): Deleted.
(WebCore::RTCTrackEvent::create): Deleted.
- Modules/mediastream/RTCTrackEvent.h:
- Modules/speech/SpeechSynthesisEvent.cpp:
(WebCore::SpeechSynthesisEvent::createForBindings):
(WebCore::SpeechSynthesisEvent::create):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):
- Modules/speech/SpeechSynthesisEvent.h:
- Modules/webaudio/AudioProcessingEvent.cpp:
(WebCore::AudioProcessingEvent::create): Deleted.
- Modules/webaudio/AudioProcessingEvent.h:
(WebCore::AudioProcessingEvent::create):
(WebCore::AudioProcessingEvent::createForBindings):
- Modules/webaudio/OfflineAudioCompletionEvent.cpp:
(WebCore::OfflineAudioCompletionEvent::createForBindings):
(WebCore::OfflineAudioCompletionEvent::create): Deleted.
- Modules/webaudio/OfflineAudioCompletionEvent.h:
- Modules/websockets/CloseEvent.h:
(WebCore::CloseEvent::create):
(WebCore::CloseEvent::createForBindings):
(WebCore::CloseEvent::CloseEvent):
(WebCore::CloseEventInit::CloseEventInit): Deleted.
- bindings/objc/DOM.mm:
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- dom/AnimationEvent.cpp:
(WebCore::AnimationEventInit::AnimationEventInit): Deleted.
- dom/AnimationEvent.h:
- dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEventInit::BeforeLoadEventInit): Deleted.
- dom/ClipboardEvent.h:
- dom/CompositionEvent.cpp:
(WebCore::CompositionEventInit::CompositionEventInit): Deleted.
- dom/CompositionEvent.h:
- dom/CustomEvent.cpp:
(WebCore::CustomEventInit::CustomEventInit): Deleted.
- dom/CustomEvent.h:
- dom/DeviceMotionEvent.h:
- dom/DeviceOrientationEvent.h:
- dom/Document.cpp:
(WebCore::Document::createEvent):
- dom/Element.cpp:
(WebCore::Element::dispatchMouseEvent):
- dom/ErrorEvent.cpp:
(WebCore::ErrorEventInit::ErrorEventInit): Deleted.
- dom/ErrorEvent.h:
- dom/Event.cpp:
(WebCore::EventInit::EventInit): Deleted.
- dom/Event.h:
(WebCore::Event::createForBindings):
(WebCore::Event::create): Deleted.
- dom/FocusEvent.cpp:
(WebCore::FocusEventInit::FocusEventInit): Deleted.
- dom/FocusEvent.h:
- dom/HashChangeEvent.h:
(WebCore::HashChangeEventInit::HashChangeEventInit): Deleted.
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEventInit::KeyboardEventInit): Deleted.
- dom/KeyboardEvent.h:
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEventInit::MessageEventInit): Deleted.
- dom/MessageEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::createForBindings):
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::cloneFor):
(WebCore::MouseEventInit::MouseEventInit): Deleted.
- dom/MouseEvent.h:
(WebCore::MouseEvent::createForBindings):
(WebCore::MouseEvent::create): Deleted.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::init):
- dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::screenX):
(WebCore::MouseRelatedEvent::screenY):
(WebCore::MouseRelatedEvent::screenLocation):
(WebCore::MouseRelatedEvent::clientX):
(WebCore::MouseRelatedEvent::clientY):
(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):
(WebCore::MouseRelatedEvent::clientLocation):
(WebCore::MouseRelatedEvent::isSimulated):
(WebCore::MouseRelatedEvent::absoluteLocation):
(WebCore::MouseRelatedEvent::setAbsoluteLocation):
- dom/MutationEvent.h:
- dom/OverflowEvent.cpp:
(WebCore::OverflowEvent::OverflowEvent):
(WebCore::OverflowEvent::initOverflowEvent):
(WebCore::OverflowEventInit::OverflowEventInit): Deleted.
- dom/OverflowEvent.h:
- dom/PageTransitionEvent.cpp:
(WebCore::PageTransitionEventInit::PageTransitionEventInit): Deleted.
- dom/PageTransitionEvent.h:
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::createForBindings):
(WebCore::PopStateEventInit::PopStateEventInit): Deleted.
(WebCore::PopStateEvent::PopStateEvent): Deleted.
(WebCore::PopStateEvent::create): Deleted.
- dom/PopStateEvent.h:
- dom/ProgressEvent.cpp:
(WebCore::ProgressEventInit::ProgressEventInit): Deleted.
- dom/ProgressEvent.h:
(WebCore::ProgressEvent::createForBindings):
(WebCore::ProgressEvent::create): Deleted.
- dom/SecurityPolicyViolationEvent.h:
(WebCore::SecurityPolicyViolationEventInit::SecurityPolicyViolationEventInit): Deleted.
- dom/TextEvent.cpp:
(WebCore::TextEvent::createForBindings):
(WebCore::TextEvent::create): Deleted.
- dom/TextEvent.h:
- dom/TouchEvent.h:
- dom/TransitionEvent.cpp:
(WebCore::TransitionEventInit::TransitionEventInit): Deleted.
- dom/TransitionEvent.h:
- dom/UIEvent.cpp:
(WebCore::UIEventInit::UIEventInit): Deleted.
- dom/UIEvent.h:
(WebCore::UIEvent::createForBindings):
(WebCore::UIEvent::create): Deleted.
- dom/UIEventWithKeyState.h:
(WebCore::UIEventWithKeyState::ctrlKey):
(WebCore::UIEventWithKeyState::shiftKey):
(WebCore::UIEventWithKeyState::altKey):
(WebCore::UIEventWithKeyState::metaKey):
(WebCore::UIEventWithKeyState::UIEventWithKeyState):
- dom/WebKitAnimationEvent.cpp:
(WebCore::WebKitAnimationEventInit::WebKitAnimationEventInit): Deleted.
- dom/WebKitAnimationEvent.h:
- dom/WebKitTransitionEvent.cpp:
(WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit): Deleted.
- dom/WebKitTransitionEvent.h:
- dom/WheelEvent.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerKeyAdded):
(WebCore::HTMLMediaElement::mediaPlayerKeyError):
(WebCore::HTMLMediaElement::mediaPlayerKeyMessage):
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
- html/MediaKeyEvent.cpp:
(WebCore::MediaKeyEvent::MediaKeyEvent):
(WebCore::MediaKeyEventInit::MediaKeyEventInit): Deleted.
- html/MediaKeyEvent.h:
- html/canvas/WebGLContextEvent.cpp:
(WebCore::WebGLContextEventInit::WebGLContextEventInit): Deleted.
- html/canvas/WebGLContextEvent.h:
- html/track/TrackEvent.cpp:
(WebCore::TrackEvent::TrackEvent):
(WebCore::TrackEventInit::TrackEventInit): Deleted.
- html/track/TrackEvent.h:
- html/track/TrackListBase.cpp:
(TrackListBase::scheduleTrackEvent):
(TrackListBase::scheduleChangeEvent):
- page/EventSource.cpp:
(WebCore::EventSource::createMessageEvent):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::gatherSecurityPolicyViolationEventData): Deleted.
- storage/StorageEvent.cpp:
(WebCore::StorageEvent::createForBindings):
(WebCore::StorageEventInit::StorageEventInit): Deleted.
(WebCore::StorageEvent::create): Deleted.
- storage/StorageEvent.h:
- svg/SVGZoomEvent.h:
(WebCore::SVGZoomEvent::createForBindings):
(WebCore::SVGZoomEvent::create): Deleted.
- xml/XMLHttpRequestProgressEvent.h:
(WebCore::XMLHttpRequestProgressEvent::createForBindings):
(WebCore::XMLHttpRequestProgressEvent::create): Deleted.
Source/WebKit2:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::nextAssistableElement):
- 3:57 PM Changeset in webkit [196399] by
-
- 8 edits in trunk/Source/WebKit2
Add SPI to remove individual user scripts or user style sheets
https://bugs.webkit.org/show_bug.cgi?id=154046
rdar://problem/23596352
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController _removeUserScript:]):
(-[WKUserContentController _userStyleSheets]):
(-[WKUserContentController _addUserStyleSheet:]):
(-[WKUserContentController _removeUserStyleSheet:]):
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
- UIProcess/UserContent/WebUserContentControllerProxy.h:
(WebKit::WebUserContentControllerProxy::userStyleSheets):
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::removeUserScript):
(WebKit::WebUserContentController::removeUserStyleSheet):
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/UserContent/WebUserContentController.messages.in:
- 3:31 PM Changeset in webkit [196398] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after 196392
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 3:02 PM Changeset in webkit [196397] by
-
- 3 edits in trunk/Source/WTF
Changed WTFCrash to not trash the crash site register state.
https://bugs.webkit.org/show_bug.cgi?id=153996
Reviewed by Geoffrey Garen.
When doing post-mortem crash site analysis using data from crash reports, it is
immensely valuable to be able to infer the crashing program's state from the
register values at crash time. However, for RELEASE_ASSERT failures, we crash
using WTFCrash(), and WTFCrash() is currently implemented as a function call
that, in turn, calls a lot of other functions to do crash handling before
actually crashing. As a result, the register values captured in the crash
reports are not likely to still contain the values used by the caller function
that failed the RELEASE_ASSERT.
This patch aims to remedy this issue for non-debug builds on OS(DARWIN) ports.
It does so by changing WTFCrash() into an inlined function that has an inlined
asm statement to issues the CPU specific breakpoint trap instruction. As a
result, for non-debug OS(DARWIN) builds, crashes due to failed RELEASE_ASSERTs
will now show up in crash reports as crashing due to EXC_BREAKPOINT (SIGTRAP)
instead of a EXC_BAD_ACCESS (SIGSEGV) on address 0xbbadbeef.
For debug and non-DARWIN builds, WTFCrash() behavior currently remains unchanged.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 2:50 PM Changeset in webkit [196396] by
-
- 22 edits in trunk/Source/WebCore
Rebaselining bindings tests
Unreviewed test gardening.
No new tests needed.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCallback.cpp:
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSreadonly.cpp:
- 2:16 PM Changeset in webkit [196395] by
-
- 2 edits in trunk/Source/WebKit/mac
WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture: should assert that it is being called from the "main" thread.
https://bugs.webkit.org/show_bug.cgi?id=154059
Reviewed by Geoffrey Garen.
This makes it so that misbehaving clients which call it (indirectly) from another
thread (not the main thread) will fail faster. Otherwise, we get potential
memory corruption that results in strange crashes elsewhere later.
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
- 2:01 PM Changeset in webkit [196394] by
-
- 5 edits1 add in trunk/Source/WebCore
[cmake] Consolidate CMake code related to image decoders.
https://bugs.webkit.org/show_bug.cgi?id=154074
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-10
Reviewed by Alex Christensen.
Common image decoder sources, includes and libs are moved to
platform/ImageDecoders.cmake.
Also, added include directories of libjpeg and libpng to
WebCore_SYSTEM_INCLUDE_DIRECTORIES.
No new tests needed.
- CMakeLists.txt: Moved common include paths to ImageDecoders.cmake.
- PlatformEfl.cmake: Moved common sources and libs to ImageDecoders.cmake.
- PlatformGTK.cmake: Ditto.
- PlatformWinCairo.cmake: Moved common sources to ImageDecoders.cmake.
- platform/ImageDecoders.cmake: Added.
- 1:57 PM Changeset in webkit [196393] by
-
- 4 edits in trunk/Source/WebCore
CSSSegmentedFontFace does not need to be reference counted
https://bugs.webkit.org/show_bug.cgi?id=154083
Reviewed by Antti Koivisto.
...There is only ever a single reference to one.
No new tests because there is no behavior change.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.h:
(WebCore::CSSSegmentedFontFace::create): Deleted.
- 1:51 PM Changeset in webkit [196392] by
-
- 107 edits2 adds in trunk
[Web IDL] interface objects should be Function objects
https://bugs.webkit.org/show_bug.cgi?id=154038
<rdar://problem/24569358>
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing. Some checks still
fail because a lot of our interfaces should inherit EventTarget and
currently don't (they duplicate the EventTarget API instead).
Also, as per WebIDL, window.NodeFilter's proto should be ObjectPrototype
instead of FunctionPrototype but this is an exceptional case and our new
behavior is consistent with Firefox and Chrome.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/events/Event-constructors-expected.txt:
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/fetch/api/headers/headers-idl-expected.txt:
- web-platform-tests/fetch/api/request/request-idl-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-audio-element/audio_constructor-expected.txt:
Source/JavaScriptCore:
Update functionProtoFuncToString() to handle JSObjects that
have the TypeOfShouldCallGetCallData flag and are callable,
as these behave like functions and use ClassInfo::className()
as function name in this case.
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
Source/WebCore:
interface objects should be Function objects as per Web IDL:
So window.Event should be a Function object for e.g. but in WebKit it
is a regular EventConstructor JSObject.
Firefox and Chrome match the specification.
Test: js/interface-objects.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::callThrowTypeError):
(WebCore::DOMConstructorObject::getCallData):
When calling the interface object as a function, we throw a TypeError
with a message asking to use the 'new' operator to match the behavior
of Firefox and Chrome.
- bindings/js/JSDOMBinding.h:
Add JSC::TypeOfShouldCallGetCallData structure flag and implement
getCallData() so that typeof returns "function", as per the
specification and the behavior of other browsers.
(WebCore::DOMConstructorObject::className):
Implement className() and return "Function" to match the specification and
other browsers. Otherwise, it would fall back to using ClassInfo::className
which os the function name and interface name (e.g. "Event").
- bindings/js/JSDOMConstructor.h:
(WebCore::JSDOMConstructorNotConstructable::callThrowTypeError):
(WebCore::JSDOMConstructorNotConstructable::getCallData):
As per the specification, interfaces that do not have a [Constructor]
should throw a TypeError when called as a function. Use the "Illegal
constructor" error message to match Firefox and Chrome.
- bindings/js/JSDOMGlobalObject.h:
(WebCore::getDOMConstructor):
Instead of using objectPrototype as prototype for all DOM constructors,
we now call the prototypeForStructure() static function that is
generated for each bindings class. As per the Web IDL specification,
The Prototype internal property of an interface object for a
non-callback interface is determined as follows:
- If the interface inherits from some other interface, the value of Prototype is the interface object for that other interface.
- If the interface doesn't inherit from any other interface, the value of Prototype is %FunctionPrototype% ([ECMA-262], section 6.1.7.4).
- bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::prototypeForStructure):
Have the Image's interface object use HTMLElement's interface object
as prototype as HTMLImageElement inherits HTMLElement.
- bindings/scripts/CodeGenerator.pm:
(getInterfaceExtendedAttributesFromName):
Add a utility function to cheaply retrieve an interface's IDL extended
attributes without actually parsing the IDL. This is used to check if
an interface's parent is marked as [NoInterfaceObject] currently.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
Mark JSGlobalObject* parameter as const as the implementation does not
alter the globalObject.
(GenerateConstructorHelperMethods):
- Generate prototypeForStructure() function for each bindings class that is not marked as [NoInterfaceObject] so getDOMConstructor() knows which prototype to use for the interface object / constructor when constructing it.
- Use the interface name for the interface object, without the "Constructor" suffix, to match the behavior of Firefox and Chrome.
- bindings/scripts/test/*:
Rebaseline bindings tests.
LayoutTests:
Rebaseline / update existing layout tests now that interface objects
are now Function objects. Also add a layout test to cover various
aspects of interface objects.
- css3/blending/background-blend-mode-property-parsing-expected.txt:
- css3/blending/blend-mode-property-parsing-expected.txt:
- css3/blending/script-tests/background-blend-mode-property-parsing.js:
(shouldBeType):
- css3/blending/script-tests/blend-mode-property-parsing.js:
(shouldBeType):
- css3/filters/backdrop/backdropfilter-property-parsing-expected.txt:
- css3/filters/backdrop/script-tests/backdropfilter-property-parsing.js:
(shouldBeType):
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/script-tests/filter-property-parsing.js:
(shouldBeType):
- fast/css/image-set-parsing-expected.txt:
- fast/css/script-tests/image-set-parsing.js:
(shouldBeType):
- fast/dom/DOMException/XPathException-expected.txt:
- fast/dom/DOMException/prototype-object-expected.txt:
- fast/dom/DOMException/prototype-object.html:
- fast/dom/DOMException/resources/XPathException.js:
- fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
- fast/dom/MutationObserver/mutation-record-constructor.html:
- fast/dom/Window/element-constructors-on-window-expected.txt:
- fast/dom/call-a-constructor-as-a-function-expected.txt:
- fast/dom/constructor-proto-expected.txt:
- fast/dom/constructor-proto.html:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- fast/workers/constructor-proto-expected.txt:
- fast/workers/worker-location-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException.html:
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/script-tests/global-constructors-attributes-idb.js:
(constructorPropertiesOnGlobalObject):
- js/dom/script-tests/global-constructors-attributes.js:
(constructorPropertiesOnGlobalObject):
- js/interface-objects-expected.txt: Added.
- js/interface-objects.html: Added.
- media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- media/track/track-vttcue-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- svg/custom/SVGException-expected.txt:
- svg/custom/global-constructors-expected.txt:
- svg/custom/script-tests/SVGException.js:
- svg/custom/script-tests/global-constructors.js:
(shouldBeDefined):
- transforms/2d/transform-value-types-expected.txt:
- transforms/2d/transform-value-types.html:
- 1:45 PM Changeset in webkit [196391] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Graphical corruption in videos when enabling custom loading path
https://bugs.webkit.org/show_bug.cgi?id=154044
Reviewed by Alex Christensen.
Revert the "Drive-by fix" in r196345 as it breaks the WebCoreNSURLSessionTests.BasicOperation API test.
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
- 1:18 PM Changeset in webkit [196390] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Removed the duplicated definition of ChartPaneBase.
- public/v3/components/chart-pane-base.js:
- 1:10 PM Changeset in webkit [196389] by
-
- 2 edits in trunk/LayoutTests
Marking fast/css-generated-content/details-summary-before-after.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153029
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:07 PM Changeset in webkit [196388] by
-
- 4 edits in trunk/Source/WebCore
CSSSegmentedFontFace does not need to be reference counted
https://bugs.webkit.org/show_bug.cgi?id=154083
Reviewed by Antti Koivisto.
...There is only ever a single reference to one.
No new tests because there is no behavior change.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSFontSelector.h:
- css/CSSSegmentedFontFace.h:
(WebCore::CSSSegmentedFontFace::create): Deleted.
- 1:07 PM Changeset in webkit [196387] by
-
- 9 edits1 move1 add in trunk/Websites/perf.webkit.org
Analysis task page on v3 UI should show charts
https://bugs.webkit.org/show_bug.cgi?id=154057
Reviewed by Chris Dumez.
Extracted ChartPaneBase out of ChartPane and added an instance of its new subclass, AnalysisTaskChartPane,
to the analysis task page. The main difference is that ChartPaneBase doesn't depend on the presence of
this._chartsPage unlike ChartPane. It also doesn't have the header with toolbar (to show breakdown, etc...).
- public/v3/components/base.js:
(ComponentBase.prototype._constructShadowTree): Call htmlTemplate() and cssTemplate() with the right "this".
- public/v3/components/chart-pane-base.js: Added.
(ChartPaneBase): Extracted from ChartPane.
(ChartPaneBase.prototype.configure): Extracted from the constructor. Separating this function allows the
component to be instantiated inside a HTML template.
(ChartPaneBase.prototype._fetchAnalysisTasks): Moved from ChartPane._fetchAnalysisTasks.
(ChartPaneBase.prototype.platformId): Ditto.
(ChartPaneBase.prototype.metricId): Ditto.
(ChartPaneBase.prototype.setOverviewDomain): Ditto.
(ChartPaneBase.prototype.setMainDomain): Ditto.
(ChartPaneBase.prototype._overviewSelectionDidChange): Extracted from the constructor. This is overridden in
ChartPane and unused in AnalysisTaskChartPane.
(ChartPaneBase.prototype._mainSelectionDidChange): Extracted from ChartPane._mainSelectionDidChange.
(ChartPaneBase.prototype._mainSelectionDidZoom): Extracted from ChartPane._mainSelectionDidZoom.
(ChartPaneBase.prototype._indicatorDidChange): Extracted from ChartPane._indicatorDidChange.
(ChartPaneBase.prototype._didFetchData): Moved from ChartPane._fetchAnalysisTasks.
(ChartPaneBase.prototype._openAnalysisTask): Ditto.
(ChartPaneBase.prototype._openCommitViewer): Ditto. Also fixed a bug that we don't show the spinner while
waiting for the data to be fetched by calling this.render() here.
(ChartPaneBase.prototype._keyup): Moved from ChartPane._keyup. Also fixed the bug that the revisions list
doesn't update by calling this.render() here.
(ChartPaneBase.prototype.render): Extracted from ChartPane.render.
(ChartPaneBase.htmlTemplate): Extracted from ChartPane.htmlTemplate.
(ChartPaneBase.paneHeaderTemplate): Added. This is overridden in ChartPane and unused in AnalysisTaskChartPane.
(ChartPaneBase.cssTemplate): Extracted from ChartPane.htmlTemplate.
- public/v3/components/chart-styles.js: Renamed from public/v3/pages/page-with-charts.js.
(PageWithCharts): Renamed from PageWithCharts since it no longer extends PageWithHeading.
(ChartStyles.createChartSourceList):
- public/v3/components/commit-log-viewer.js:
(CommitLogViewer.prototype.view): Set this._repository right away instead of waiting for the fetched data
so that spinner will be shown while the data is being fetched.
- public/v3/index.html:
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskChartPane): Added extends ChartPaneBase.
(AnalysisTaskPage): Added. this._chartPane.
(AnalysisTaskPage.prototype._didFetchTask): Initialize this._chartPane with a domain.
(AnalysisTaskPage.prototype.render): Render this._chartPane.
(AnalysisTaskPage.htmlTemplate):
- public/v3/pages/chart-pane-status-view.js:
(ChartPaneStatusView): Removed the unused router from the argument list.
(ChartPaneStatusView.prototype.pointsRangeForAnalysis): Renamed from analyzeData() since it was ambiguous.
(ChartPaneStatusView.prototype.moveRepositoryWithNotification): Fixed the bug that we don't update the list
of the revisions here.
(ChartPaneStatusView.prototype.computeChartStatusLabels):
- public/v3/pages/chart-pane.js:
(ChartPane): Now extends ChartPaneBase.
(ChartPane.prototype._overviewSelectionDidChange): Extracted from the constructor.
(ChartPane.prototype._mainSelectionDidChange):
(ChartPane.prototype._mainSelectionDidZoom):
(ChartPane.prototype._indicatorDidChange):
(ChartPane.prototype.render):
(ChartPane.prototype._renderActionToolbar):
(ChartPane.paneHeaderTemplate): Extracted from htmlTemplate.
(ChartPane.cssTemplate):
(ChartPane.overviewOptions.selection.onchange): Deleted.
(ChartPane.prototype._fetchAnalysisTasks): Deleted.
(ChartPane.prototype.platformId): Deleted.
(ChartPane.prototype.metricId): Deleted.
(ChartPane.prototype.setOverviewDomain): Deleted.
(ChartPane.prototype.setMainDomain): Deleted.
(ChartPane.prototype._openCommitViewer): Deleted.
(ChartPane.prototype._didFetchData): Deleted.
(ChartPane.prototype._keyup): Deleted.
- public/v3/pages/charts-page.js:
(ChartsPage):
(ChartsPage.createDomainForAnalysisTask): Extracted by createDomainForAnalysisTask; used to set the domain
of the charts in the analysis task page.
(ChartsPage.createStateForAnalysisTask):
- public/v3/pages/dashboard-page.js:
(DashboardPage):
(DashboardPage.prototype._createChartForCell):
- 1:05 PM Changeset in webkit [196386] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Add the support for maintenance mode
https://bugs.webkit.org/show_bug.cgi?id=154072
Reviewed by Chris Dumez.
Added the crude support for maintenance mode whereby which the reports are stored in the filesystem
instead of the database.
- config.json: Added maintenanceMode and maintenanceDirectory as well as forgotten siteTitle and
remoteServer.httpdMutexDir.
- public/api/report.php:
(main): Don't connect to the database or modify database when maintenanceMode is set.
- public/include/json-header.php:
(ensure_privileged_api_data): Exit with InMaintenanceMode when maintenanceMode is set. This prevents
privileged API such as creating analysis tasks and new A/B testing groups from modifying the database.
- 12:56 PM Changeset in webkit [196385] by
-
- 2 edits in trunk/LayoutTests
Reaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196374
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 12:56 PM Changeset in webkit [196384] by
-
- 8 edits in trunk/Source/WebKit2
Fix assertions when loading from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=154079
Reviewed by Anders Carlsson.
Assertions were failing, mostly when using NetworkProcess, and mostly involving Top Sites.
When we do loading from the WebProcess (which we should eventually not allow), we were sometimes
using a private browsing session that did not exist because the UIProcess had told the NetworkProcess
to create a private browsing session with the given SessionID, but the WebProcess was not told about
the private browsing session.
Also, sometimes we were calling NetworkProcess::singleton() from the WebProcess, which caused problems
with the PlatformStrategies object being reset. This prevents that, too.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
Added an assertion that we have a network session when we have just made a NetworkingContext with the given SessionID.
- NetworkProcess/NetworkSession.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
Call NetworkProcess::singleton only when we know we are in the network process.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
Tell the WebProcesses about the new private session, too. Sometimes they use the new private session.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):
Removed useless macros that were always true for all WK2 clients.
- 12:47 PM Changeset in webkit [196383] by
-
- 13 edits in trunk/Source/WebCore
Optimize style invalidation after class attribute change
https://bugs.webkit.org/show_bug.cgi?id=154075
rdar://problem/12526450
Reviewed by Andreas Kling.
Currently a class attribute change invalidates style for the entire element subtree for any class found in the
active stylesheet set.
This patch optimizes class changes by building a new optimization structure called ancestorClassRules. It contains
rules that have class selectors in the portion of the complex selector that matches ancestor elements. The sets
of rules are hashes by the class name.
On class attribute change the existing StyleInvalidationAnalysis mechanism is used with ancestorClassRules to invalidate
exactly those descendants that are affected by the addition or removal of the class name. This is fast because the CSS JIT
makes selector matching cheap and the number of relevant rules is typically small.
This optimization is very effective on many dynamic pages. For example when focusing and unfocusing the web inspector it
cuts down the number of resolved elements from ~1000 to ~50. Even in PLT it reduces the number of resolved elements by ~11%.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::collectFeatures):
(WebCore::DocumentRuleSets::ancestorClassRules):
Create optimization RuleSets on-demand when there is an actual dynamic class change.
- css/DocumentRuleSets.h:
(WebCore::DocumentRuleSets::features):
(WebCore::DocumentRuleSets::sibling):
(WebCore::DocumentRuleSets::uncommonAttribute):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ElementRuleCollector):
Add a new constructor that doesn't requires DocumentRuleSets. Only the user and author style is required.
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
- css/ElementRuleCollector.h:
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
Collect class names that show up in the ancestor portion of the selector.
Make this a member.
(WebCore::RuleFeatureSet::collectFeatures):
Move this code from RuleData.
Add the rule to ancestorClassRules if needed.
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):
(WebCore::RuleFeatureSet::shrinkToFit):
(WebCore::recursivelyCollectFeaturesFromSelector): Deleted.
(WebCore::RuleFeatureSet::collectFeaturesFromSelector): Deleted.
- css/RuleFeature.h:
(WebCore::RuleFeature::RuleFeature):
(WebCore::RuleFeatureSet::RuleFeatureSet): Deleted.
- css/RuleSet.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::collectFeaturesFromRuleData): Deleted.
- css/RuleSet.h:
(WebCore::RuleSet::tagRules):
(WebCore::RuleSet::RuleSet): Deleted.
- css/StyleInvalidationAnalysis.cpp:
(WebCore::shouldDirtyAllStyle):
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
Add a new constructor that takes a ready made RuleSet instead of a stylesheet.
(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):
(WebCore::StyleInvalidationAnalysis::invalidateStyleForTree):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
New function for invalidating a subtree instead of the whole document.
- css/StyleInvalidationAnalysis.h:
(WebCore::StyleInvalidationAnalysis::dirtiesAllStyle):
(WebCore::StyleInvalidationAnalysis::hasShadowPseudoElementRulesInAuthorSheet):
- dom/Element.cpp:
(WebCore::classStringHasClassName):
(WebCore::collectClasses):
(WebCore::computeClassChange):
Factor to return the changed classes.
(WebCore::invalidateStyleForClassChange):
First filter out classes that don't show up in stylesheets. If something remains invalidate the current
element for inline style change (that is a style change that doesn't affect descendants).
Next check if there are any ancestorClassRules for the changed class. If so use the StyleInvalidationAnalysis
to find any affected descendants and invalidate them with inline style change as well.
(WebCore::Element::classAttributeChanged):
Invalidate for removed classes before setting new attribute value, invalidate for added classes afterwards.
(WebCore::Element::absoluteLinkURL):
(WebCore::checkSelectorForClassChange): Deleted.
- dom/ElementData.h:
(WebCore::ElementData::setClassNames):
(WebCore::ElementData::classNames):
(WebCore::ElementData::classNamesMemoryOffset):
(WebCore::ElementData::clearClass): Deleted.
(WebCore::ElementData::setClass): Deleted.
- 12:46 PM Changeset in webkit [196382] by
-
- 2 edits in tags/Safari-602.1.18.6/Source/WebKit
Merged r196377. rdar://problem/24584417
- 12:45 PM Changeset in webkit [196381] by
-
- 6 edits in trunk/PerformanceTests
Add internal benchmark tests for CSS mix-blend-modes and filters
https://bugs.webkit.org/show_bug.cgi?id=154058
Provisionally reviewed by Jon Lee.
- Animometer/resources/debug-runner/tests.js: Include the new tests in the
"HTML suite" of the debug runner.
- Animometer/resources/extensions.js:
(Utilities.browserPrefix):
(Utilities.setElementPrefixedProperty): Utility functions to allow setting
prefixed style properties.
- Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js:
Set the mix-blend-mode and the filter to some random values if the options
of the test requested that.
- Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
(parseShapeParameters): Parse the url options "blend" and "filter" and set
the corresponding flags.
- Animometer/tests/resources/main.js:
(randomStyleMixBlendMode):
(randomStyleFilter): Return random mix-blend-mode and filter.
- 12:33 PM Changeset in webkit [196380] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore
Merge r196226. rdar://problem/24417430
- 12:33 PM Changeset in webkit [196379] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r196208. rdar://problem/24417430
- 12:33 PM Changeset in webkit [196378] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r196206. rdar://problem/24417430
- 11:56 AM Changeset in webkit [196377] by
-
- 2 edits in trunk/Source/WebKit
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=154080
rdar://problem/24584417
Reviewed by Brent Fulgham.
- CMakeLists.txt:
Explicitly make WebKit dependent on WebKitGUID so that WebKit will not start building
before WebKitGUID is finished generating and copying all headers, including WebKit/WebKit.h.
- 11:54 AM Changeset in webkit [196376] by
-
- 3 edits in trunk/Source/WebCore
Addressing post-review comments after r196322
Unreviwed.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
- css/CSSFontFaceSource.h:
- 11:53 AM Changeset in webkit [196375] by
-
- 2 edits in branches/safari-601-branch/Source/WebInspectorUI
Merge patch for rdar://problem/24267980.
- 11:47 AM Changeset in webkit [196374] by
-
- 17 edits5 adds in trunk
Attributes on the Window instance should be configurable unless [Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=153920
<rdar://problem/24563211>
Reviewed by Darin Adler.
Source/JavaScriptCore:
Marking the Window instance attributes as configurable but cause
getOwnPropertyDescriptor() to report them as configurable, as
expected. However, trying to delete them would actually lead to
unexpected behavior because:
- We did not reify custom accessor properties (most of the Window properties are custom accessors) upon deletion.
- For non-reified static properties marked as configurable, JSObject::deleteProperty() would attempt to call the property setter with undefined. As a result, calling delete window.name would cause window.name to become the string "undefined" instead of the undefined value.
- runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
Now that we reify ALL properties, we only need to check the property table
if we have not reified. As a result, I dropped the 'didReify' parameter for
this function and instead only call this function if we have not yet reified.
(JSC::JSObject::putInlineSlow):
Only call putEntry() if we have not reified: Drop the
' !(entry->attributes() & BuiltinOrFunctionOrAccessor)' check as such properties now get reified as well.
(JSC::JSObject::deleteProperty):
- Call reifyAllStaticProperties() instead of reifyStaticFunctionsForDelete() so that we now reify all properties upon deletion, including the custom accessors. reifyStaticFunctionsForDelete() is now removed and the same reification function is now used by: deletion, getOwnPropertyDescriptor() and eager reification of the prototype objects in the bindings.
- Drop code that falls back to calling the static property setter with undefined if we cannot find the property in the property storage. As we now reify ALL properties, the code removing the property from the property storage should succeed, provided that the property actually exists.
(JSC::JSObject::getOwnNonIndexPropertyNames):
Only call getClassPropertyNames() if we have not reified. We should no longer
check the static property table after reifying now that we reify all
properties.
(JSC::JSObject::reifyAllStaticProperties):
Merge with reifyStaticFunctionsForDelete(). The only behavior change is the
flattening to an uncacheable dictionary, like reifyStaticFunctionsForDelete()
used to do.
- runtime/JSObject.h:
Source/WebCore:
Attributes on the Window instance should be configurable unless [Unforgeable]:
- 'constructor' property:
- Constructor properties (e.g. window.Node):
- IDL attributes:
- http://heycam.github.io/webidl/#es-attributes (configurable unless [Unforgeable], e.g. window.location)
Firefox complies with the WebIDL specification but WebKit does not for 1. and 3.
Test: fast/dom/Window/window-properties-configurable.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
For known Window properties (i.e. properties in the static property table),
if we have reified and this is same-origin access, then call
Base::getOwnPropertySlot() to get the property from the local property
storage. If we have not reified yet, or this is cross-origin access, query
the static property table. This is to match the behavior of Firefox and
Chrome which seem to keep returning the original properties upon cross
origin access, even if those were deleted or redefined.
(WebCore::JSDOMWindow::put):
The previous code used to call the static property setter for properties in
the static table. However, this does not do the right thing if properties
were reified. For example, deleting window.name and then trying to set it
again would not work. Therefore, update this code to only do this if the
properties have not been reified, similarly to what is done in
JSObject::putInlineSlow().
- bindings/scripts/CodeGeneratorJS.pm:
(ConstructorShouldBeOnInstance):
Add a FIXME comment indicating that window.constructor should be on
the prototype as per the Web IDL specification.
(GenerateAttributesHashTable):
- Mark 'constructor' property as configurable for Window, as per the specification and consistently with other 'constructor' properties: http://www.w3.org/TR/WebIDL/#interface-prototype-object
- Mark properties as configurable even though they are on the instance.
Window has its properties on the instance as per the specification:
- http://heycam.github.io/webidl/#es-attributes
- http://heycam.github.io/webidl/#PrimaryGlobal (window is [PrimaryGlobal] However, these properties should be configurable as long as they are not marked as [Unforgeable], as per 1.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
Rebaseline bindings tests.
LayoutTests:
- fast/dom/Window/window-properties-configurable-expected.txt: Added.
- fast/dom/Window/window-properties-configurable.html: Added.
Add a test to check that Window properties are reported as configurable
unless the [Unforgeable] ones and that deleting them actually works.
- fast/dom/global-constructors.html:
Update test so it no longer expects window.Node to be shadowable. As per
the specification, the "Node" property is on the window instance, not its
prototype. Therefore, it should cannot be shadowed and setting it to
something actually overwites the previous value, given that the property
is writable as per:
I have verified that the new behavior is consistent with Firefox.
- http/tests/security/cross-origin-reified-window-property-access-expected.txt: Added.
- http/tests/security/cross-origin-reified-window-property-access.html: Added.
- http/tests/security/resources/reify-window.html: Added.
Add a test case to cover cross-origin access of Window properties after
reification.
- js/getOwnPropertyDescriptor-unforgeable-attributes-expected.txt:
- js/getOwnPropertyDescriptor-unforgeable-attributes.html:
Drop window.self from the list of unforgeable attributes. This attribute
is not unforgeable in our implementation or in the specification:
- js/getOwnPropertyDescriptor-window-attributes-expected.txt:
- js/getOwnPropertyDescriptor-window-attributes.html:
- Add coverage for window.self which is a regular Window property.
- Add coverage for window.Node which is a constructor property
- Add coverage for window.constructor. It should really be on the prototype as per the specification but this at least checks that the property is configurable, as per the specification.
- Rebaseline the test as more checks are passing now that Window properties are marked as configurable.
- 11:27 AM Changeset in webkit [196373] by
-
- 3 edits in trunk/Source/WebCore
Modern IDB: Ref cycle between IDBObjectStore and IDBTransaction.
https://bugs.webkit.org/show_bug.cgi?id=154061
Reviewed by Alex Christensen.
No new tests (Currently untestable).
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::transitionedToFinishing): Make sure the new state makes sense,
set the new state, and then clear the set of referenced object stores which is no longer needed.
(WebCore::IDBClient::IDBTransaction::abort):
(WebCore::IDBClient::IDBTransaction::commit):
- Modules/indexeddb/client/IDBTransactionImpl.h:
- 11:22 AM Changeset in webkit [196372] by
-
- 9 edits in trunk/PerformanceTests
Add a ramp controller
https://bugs.webkit.org/show_bug.cgi?id=154028
Provisionally reviewed by Said Abou-Hallawa.
Enhance the graph to include a complexity-fps graph, in addition
to the time graph.
- Animometer/developer.html: Add a ramp option.
- Animometer/resources/debug-runner/animometer.css: Update the style.
- Animometer/resources/strings.js: Flatten the Strings.text constants.
- Animometer/resources/debug-runner/animometer.js:
(ResultsTable.call._addGraphButton): Refactor.
(ResultsTable.call._addTest): Add regression data.
(benchmarkController): Add a form that allows the user to switch between the two forms,
Add a form that allows the user to toggle different data. Hide certain header columns
depending on the selected controller.
- Animometer/resources/debug-runner/graph.js: Add the complexity regressions.
- Animometer/resources/debug-runner/tests.js: Add headers for the ramp results.
- Animometer/resources/runner/animometer.js:
(ResultsTable): If a header is disabled don't include them in _flattenedHeaders.
- Animometer/tests/resources/main.js:
(Controller): Allow options to specify the capacity for sample arrays.
(Regression): A piecewise regression that tries to fit a slope and a flat profile.
(_calculateRegression): Options can fix the slope and bias when calculating the minimal
error. Sweep across the samples in time (which could be backward depending on the controller)
and calculate the intersection point.
(RampController): This controller assumes that the target frame rate is below
58 FPS. It runs in two stages. The first stage quickly determines the order of
magnitude of objects needed to stress the system by the setting the complexity
to increasingly difficult tiers. Perform a series of ramps descending from a
high-water mark of complexity. The complexity needed to reach the target frame
length is done by performing a piecewise regression on each ramp, and track a
running average of these values. For the next ramp, make that running average
the center of the ramp. With a minimum complexity of 0, the high-water mark is
twice that average. The score is based on the highest complexity that can
reach 60 fps.
- 11:22 AM Changeset in webkit [196371] by
-
- 2 edits in trunk/LayoutTests
Skop fast/regions/text-break-properties.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153762
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:20 AM Changeset in webkit [196370] by
-
- 4 edits in trunk/Source/WebKit2
[Mac] Stop installing the legacy processes
https://bugs.webkit.org/show_bug.cgi?id=154062
Reviewed by Anders Carlsson.
- Configurations/All.xcconfig: Removed the legacy processes from EXCLUDED_SOURCE_FILE_NAMES for iOS, now that they are no longer included in a Copy Files build phase.
- Configurations/BaseLegacyProcess.xcconfig: Set SKIP_INSTALL to YES for OS X as well.
- WebKit2.xcodeproj/project.pbxproj: Removed the Copy Files build phase that copied the processes into the framework in engineering builds. Renamed the “Add current version symlinks” script build phase to “Add XPCServices symlink”, and changed it to do just that.
- 10:13 AM Changeset in webkit [196369] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r196251.
https://bugs.webkit.org/show_bug.cgi?id=154078
Large regression on Dromaeo needs explanation (Requested by
kling on #webkit).
Reverted changeset:
"Visiting a WeakBlock should report bytes visited, since we
reported them allocated."
https://bugs.webkit.org/show_bug.cgi?id=153978
http://trac.webkit.org/changeset/196251
- 9:50 AM Changeset in webkit [196368] by
-
- 5 edits in trunk/Source/JavaScriptCore
REGRESSION(r196331): It made ~180 JSC tests crash on ARMv7 Linux
https://bugs.webkit.org/show_bug.cgi?id=154064
Reviewed by Mark Lam.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate): Added EABI_32BIT_DUMMY_ARG where it is necessary.
- dfg/DFGSpeculativeJIT.h: Fixed the comment.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState): Added.
- wasm/WASMFunctionCompiler.h: Fixed the comment.
- 9:23 AM Changeset in webkit [196367] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
https://bugs.webkit.org/show_bug.cgi?id=153727
<rdar://problem/24429886>
Reviewed by Darin Adler.
Follow-up after r195965. Only protect those parts of CachedResource::removeClient() which
affect the MemoryCache when allowsCaching() is false.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
- 8:53 AM Changeset in webkit [196366] by
-
- 6 edits2 copies in branches/safari-601-branch/Source/JavaScriptCore
Merged r196179. rdar://problem/24574519
- 2:28 AM Changeset in webkit [196365] by
-
- 2 edits in trunk/Source/WebCore
Fix the !(ENABLE(SHADOW_DOM) ENABLE(DETAILS_ELEMENT)) after r196281 https://bugs.webkit.org/show_bug.cgi?id=154035
Reviewed by Antti Koivisto.
- dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::Context::Context):
Feb 9, 2016:
- 10:58 PM Changeset in webkit [196364] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Toggle buttons are blurry with GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=154007
Reviewed by Michael Catanzaro.
Use min-width/min-height style properties when GTK+ >= 3.19.7 to
get the size of toggle buttons.
- rendering/RenderThemeGtk.cpp:
(WebCore::setToggleSize):
(WebCore::paintToggle):
- 10:53 PM Changeset in webkit [196363] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r196183): [GTK] Broke TestInspector
https://bugs.webkit.org/show_bug.cgi?id=153945
Reviewed by Michael Catanzaro.
When the inspector view is detached and not added to a window,
which happens when it's closed, the inspector view is destroyed
because it doesn't have a parent anymore. When the inspector view
is destroyed we notify the web process that the inspector was
closed. Before r196183 this was not a problem, because the call to
WebInspectorProxy::didClose() from platformDetach() returned early
because WebInspectorProxy::didClose() had already set
m_inspectorPage to nullptr. In r196183 m_inspectorPage is set to
nullptr after platformDetach(), so we end up trying to detach the
inpector view again. To prevent this cycle, we should disconnect
the destroyed signal handler from the inspector view when
platformDetach() is called from WebInspectorProxy::didClose().
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformDetach):
- 10:02 PM Changeset in webkit [196362] by
-
- 3 edits in trunk/Source/WebInspectorUI
Regression: Web Inspector: Sometimes in Elements panel two elements showed as selected at the same time
https://bugs.webkit.org/show_bug.cgi?id=149742
<rdar://problem/24492481>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-09
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.moveChild):
Since removing and re-adding this tree element may forgot its
entire child tree, re-select the selected child that may have
just been lost in the shuffle.
- UserInterface/Views/TreeOutline.js:
(WebInspector.TreeOutline.prototype._forgetTreeElement):
When forgetting the selected tree element, also deselect the
forgotten tree element so it clears its selected state.
- 10:01 PM Changeset in webkit [196361] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
calling methods off super in a class constructor should check for TDZ
https://bugs.webkit.org/show_bug.cgi?id=154060
Reviewed by Ryosuke Niwa.
In a class constructor we need to check for TDZ when calling a method
off the super class. This is because, for super method calls, we use
the derived class's newly constructed object as the super method's
this value.
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionCallDotNode::emitBytecode):
- tests/stress/super-method-calls-check-tdz.js: Added.
(Base):
(Derived):
(test):
- 9:36 PM Changeset in webkit [196360] by
-
- 8 edits in trunk/Source/WebCore
Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
https://bugs.webkit.org/show_bug.cgi?id=146984
Reviewed by Alexey Proskuryakov.
- Modules/speech/SpeechSynthesis.h:
- contentextensions/ContentExtensionError.h:
- dom/DeviceOrientationClient.h:
- platform/graphics/Color.h:
- platform/ios/wak/WebCoreThread.h:
- platform/network/CacheValidation.h:
- platform/network/cf/CertificateInfo.h:
- 8:52 PM Changeset in webkit [196359] by
-
- 6 edits2 copies in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merged r196179. rdar://problem/24574469
- 7:12 PM Changeset in webkit [196358] by
-
- 4 edits in branches/safari-601-branch/Source/WebCore
Merged r190616. rdar://problem/24563410
- 7:11 PM Changeset in webkit [196357] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge patch for rdar://problem/24563410.
- 7:04 PM Changeset in webkit [196356] by
-
- 1 copy in tags/Safari-601.3.9.1.4
New tag.
- 7:03 PM Changeset in webkit [196355] by
-
- 4 edits in branches/safari-601.3.9.1-branch/Source/WebCore
Merged r190616. rdar://problem/24563410
- 7:00 PM Changeset in webkit [196354] by
-
- 2 edits in branches/safari-601.3.9.1-branch/Source/WebCore
Merge patch for rdar://problem/24563410.
- 6:55 PM Changeset in webkit [196353] by
-
- 5 edits in branches/safari-601.3.9.1-branch/Source
Versioning.
- 6:33 PM Changeset in webkit [196352] by
-
- 19 edits2 adds in trunk
AX: Implement word related text marker functions using TextIterator
https://bugs.webkit.org/show_bug.cgi?id=153939
<rdar://problem/24269605>
Reviewed by Chris Fleizach.
Source/WebCore:
Using CharacterOffset to implement word related text marker calls. Reused
logic from previousBoundary and nextBoundary in VisibleUnits class.
Test: accessibility/mac/text-marker-word-nav.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::rangeForNodeContents):
(WebCore::isReplacedNodeOrBR):
(WebCore::characterOffsetsInOrder):
(WebCore::resetNodeAndOffsetForReplacedNode):
(WebCore::setRangeStartOrEndWithCharacterOffset):
(WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets):
(WebCore::AXObjectCache::setTextMarkerDataWithCharacterOffset):
(WebCore::AXObjectCache::startOrEndCharacterOffsetForRange):
(WebCore::AXObjectCache::startOrEndTextMarkerDataForRange):
(WebCore::AXObjectCache::characterOffsetForNodeAndOffset):
(WebCore::AXObjectCache::textMarkerDataForCharacterOffset):
(WebCore::AXObjectCache::previousNode):
(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::previousCharacterOffset):
(WebCore::startWordBoundary):
(WebCore::endWordBoundary):
(WebCore::AXObjectCache::startCharacterOffsetOfWord):
(WebCore::AXObjectCache::endCharacterOffsetOfWord):
(WebCore::AXObjectCache::previousWordStartCharacterOffset):
(WebCore::AXObjectCache::nextWordEndCharacterOffset):
(WebCore::AXObjectCache::leftWordRange):
(WebCore::AXObjectCache::rightWordRange):
(WebCore::characterForCharacterOffset):
(WebCore::AXObjectCache::characterAfter):
(WebCore::AXObjectCache::characterBefore):
(WebCore::parentEditingBoundary):
(WebCore::AXObjectCache::nextWordBoundary):
(WebCore::AXObjectCache::previousWordBoundary):
(WebCore::AXObjectCache::rootAXEditableElement):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper previousTextMarkerForNode:offset:]):
(-[WebAccessibilityObjectWrapper textMarkerForNode:offset:ignoreStart:]):
(-[WebAccessibilityObjectWrapper textMarkerForNode:offset:]):
(textMarkerForCharacterOffset):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- editing/VisibleUnits.cpp:
(WebCore::rightWordPosition):
(WebCore::prepend):
(WebCore::appendRepeatedCharacter):
(WebCore::suffixLengthForRange):
(WebCore::prefixLengthForRange):
(WebCore::backwardSearchForBoundaryWithTextIterator):
(WebCore::forwardSearchForBoundaryWithTextIterator):
(WebCore::previousBoundary):
(WebCore::nextBoundary):
- editing/VisibleUnits.h:
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(endTextMarkerCallback):
(leftWordTextMarkerRangeForTextMarkerCallback):
(rightWordTextMarkerRangeForTextMarkerCallback):
(previousWordStartTextMarkerForTextMarkerCallback):
(nextWordEndTextMarkerForTextMarkerCallback):
(setSelectedVisibleTextRangeCallback):
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::setBoolAttributeValue):
(WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
(WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
(WTR::_convertMathMultiscriptPairsToString):
LayoutTests:
- accessibility/mac/text-marker-word-nav-expected.txt: Added.
- accessibility/mac/text-marker-word-nav.html: Added.
- accessibility/text-marker/text-marker-previous-next-expected.txt:
- accessibility/text-marker/text-marker-previous-next.html:
- 6:29 PM Changeset in webkit [196351] by
-
- 2 edits in tags/Safari-602.1.18.6/Source/WebCore
Merged r195816. rdar://problem/24580198
- 5:21 PM Changeset in webkit [196350] by
-
- 5 edits11 adds in trunk/Source/WebCore
CSP: Extract helper classes into their own files
https://bugs.webkit.org/show_bug.cgi?id=154040
<rdar://problem/24571189>
Reviewed by Brent Fulgham.
No functionality was changed. So, no new tests.
- CMakeLists.txt: Add files ContentSecurityPolicy{DirectiveList, MediaListDirective, Source, SourceList, SourceListDirective}.cpp.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- page/csp/ContentSecurityPolicy.cpp: Clean up #includes. Include header ParsingUtilities.h so that we can remove our own
variants of skip{Exactly, Until, While}(). Update code as necessary for class renames.
(WebCore::skipExactly): Deleted; instead use the analogous function in ParsingUtilities.h.
(WebCore::skipUntil): Deleted; instead use the analogous function in ParsingUtilities.h.
(WebCore::skipWhile): Deleted; instead use the analogous function in ParsingUtilities.h.
(WebCore::isSourceListNone): Moved to file ContentSecurityPolicySourceList.cpp.
(WebCore::CSPSource): Deleted; moved implementation to files ContentSecurityPolicySource.{cpp, h}.
(WebCore::CSPSourceList): Deleted; moved implementation to files ContentSecurityPolicySourceList.{cpp, h}.
(WebCore::CSPDirective): Deleted; moved implementation to file ContentSecurityPolicyDirective.h.
(WebCore::MediaListDirective): Deleted; moved implementation to files ContentSecurityPolicyMediaListDirective.{cpp, h}.
(WebCore::SourceListDirective): Deleted; moved implementation to files ContentSecurityPolicySourceListDirective.{cpp, h}.
(WebCore::CSPDirectiveList): Deleted; moved implementation to files ContentSecurityPolicyDirectiveList.{cpp, h}.
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyDirective.h: Added.
- page/csp/ContentSecurityPolicyDirectiveList.cpp: Added; removed use of ternary operator where it made the code less readable.
Updated code to make use of the functions defined in ParsingUtilities.h.
(WebCore::isExperimentalDirectiveName): Moved from file ContentSecurityPolicy.cpp.
(WebCore::isCSPDirectiveName): Ditto.
(WebCore::isDirectiveNameCharacter): Ditto.
(WebCore::isDirectiveValueCharacter): Ditto.
(WebCore::isNotASCIISpace): Ditto.
- page/csp/ContentSecurityPolicyDirectiveList.h: Added.
- page/csp/ContentSecurityPolicyMediaListDirective.cpp: Added. Updated code to make use of the functions defined in ParsingUtilities.h.
(WebCore::isMediaTypeCharacter): Moved from file ContentSecurityPolicy.cpp.
(WebCore::isNotASCIISpace): Ditto.
- page/csp/ContentSecurityPolicyMediaListDirective.h: Added.
- page/csp/ContentSecurityPolicySource.cpp: Added.
- page/csp/ContentSecurityPolicySource.h: Added.
- page/csp/ContentSecurityPolicySourceList.cpp: Added. Updated code to make use of the functions defined in ParsingUtilities.h.
(WebCore::isSourceCharacter): Moved from file ContentSecurityPolicy.cpp.
(WebCore::isHostCharacter): Ditto.
(WebCore::isPathComponentCharacter): Ditto.
(WebCore::isSchemeContinuationCharacter): Ditto.
(WebCore::isNotColonOrSlash): Ditto.
(WebCore::isSourceListNone): Ditto.
- page/csp/ContentSecurityPolicySourceList.h: Added.
- page/csp/ContentSecurityPolicySourceListDirective.cpp: Added.
- page/csp/ContentSecurityPolicySourceListDirective.h: Added.
- 5:15 PM Changeset in webkit [196349] by
-
- 3 edits in trunk/Source/WebCore
Modern IDB: TransactionOperation objects leak.
https://bugs.webkit.org/show_bug.cgi?id=154054
Reviewed by Alex Christensen.
No new tests (Currently untestable).
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::abortOnServerAndCancelRequests): Remove the TransactionOperation from
the map, as this operation doesn't complete "normally" like most others.
(WebCore::IDBClient::IDBTransaction::commitOnServer): Ditto.
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::perform): Clear the m_performFunction after use,
as it holds a lambda that holds a RefPtr to the IDBTransaction, as well as a self-ref.
(WebCore::IDBClient::TransactionOperation::completed): Clear m_completeFunction for the same reasons.
- 5:13 PM Changeset in webkit [196348] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Allow copying all headers in the request/response header tables
https://bugs.webkit.org/show_bug.cgi?id=154048
<rdar://problem/24576302>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-09
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
New "Copy Table" string.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype._contextMenuInHeader):
Add context menu support for table header cells, and give them a
"Copy Table" context menu if there is copyable data.
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
Add "Copy Table" context menu for copyable rows.
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGrid.prototype._copyTextForDataGridHeaders):
(WebInspector.DataGrid.prototype._copyTable):
(WebInspector.DataGrid.prototype._hasCopyableData):
Helpers for determining copyability and copying tab separated data.
- 5:08 PM Changeset in webkit [196347] by
-
- 8 edits in trunk/Source/WebKit2
Unreviewed, rolling out r196341.
https://bugs.webkit.org/show_bug.cgi?id=154056
This change broke existing API tests on Mac and iOS (Requested
by ryanhaddad on #webkit).
Reverted changeset:
"Add SPI to remove individual user scripts or user style
sheets"
https://bugs.webkit.org/show_bug.cgi?id=154046
http://trac.webkit.org/changeset/196341
- 4:27 PM Changeset in webkit [196346] by
-
- 2 edits in trunk/LayoutTests
Mark perf/adding-radio-buttons.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=154055
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:15 PM Changeset in webkit [196345] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Graphical corruption in videos when enabling custom loading path
https://bugs.webkit.org/show_bug.cgi?id=154044
Reviewed by Alex Christensen.
The NSOperationQueue provided by AVFoundation from the AVAssetResourceLoader queue is not
set to be a serial queue. So when adding dataReceived operations to that queue, there exists
the possibility that some operations are handled before others, and the client will receieve
data out of order.
A real NSURLSession object will only issue another operation when the first operation
completes, so emulate this behavior in WebCoreNSURLSession by using a serial dispatch queue.
The internal queue will enqueue an operation to the resource loader's queue, and block until
that operation completes, thus ensuring ordering of the data (and other) operations.
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]): Initialize _internalQueue
(-[WebCoreNSURLSession addDelegateOperation:]): Added utility method.
(-[WebCoreNSURLSession taskCompleted:]): Call -addDelegateOperation:
(-[WebCoreNSURLSession finishTasksAndInvalidate]): Ditto.
(-[WebCoreNSURLSession resetWithCompletionHandler:]): Ditto.
(-[WebCoreNSURLSession flushWithCompletionHandler:]): Ditto.
(-[WebCoreNSURLSession getTasksWithCompletionHandler:]): Ditto.
(-[WebCoreNSURLSession getAllTasksWithCompletionHandler:]): Ditto.
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Ditto.
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]): Ditto.
(-[WebCoreNSURLSessionDataTask resourceFinished:]): Ditto.
Drive-by fix:
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]): Set countOfBytesReceived outside the operation,
queue, matching NSURLSessionDataTask's behavior.
- 4:14 PM Changeset in webkit [196344] by
-
- 4 edits2 adds in trunk/LayoutTests
Rebaseline tests for ios-simulator after r196222
https://bugs.webkit.org/show_bug.cgi?id=154053
Reviewed by Zalan Bujtas.
- platform/ios-simulator-wk2/compositing/geometry/composited-in-columns-expected.txt:
- platform/ios-simulator-wk2/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
- platform/ios-simulator-wk2/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/ios-simulator-wk2/fast/inline/continuation-outlines-with-layers-expected.txt: Added.
- platform/ios-simulator-wk2/fast/layers/scroll-rect-to-visible-expected.txt:
- 4:02 PM Changeset in webkit [196343] by
-
- 2 edits in trunk/LayoutTests
Rebaseline compositing/overflow/scrollbar-painting.html for ios-simulator after r196244
Unreviewed test gardening.
- platform/ios-simulator-wk2/compositing/overflow/scrollbar-painting-expected.txt:
- 3:42 PM Changeset in webkit [196342] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: localStorage inspector very slow on big values
https://bugs.webkit.org/show_bug.cgi?id=123750
<rdar://problem/15384930>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-09
Reviewed by Timothy Hatcher.
It is not useful to show very large strings in the DOM Storage DataGrid.
This change truncates display strings to roughly 200 characters. If the
developer really wants the full value of the string they can just access
it through localStorage.
- UserInterface/Models/DOMStorageObject.js:
(WebInspector.DOMStorageObject.prototype.getEntries.innerCallback):
(WebInspector.DOMStorageObject.prototype.getEntries):
(WebInspector.DOMStorageObject.prototype.itemUpdated):
Modernize.
- UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView):
(WebInspector.DOMStorageContentView.prototype.itemRemoved):
Modernize.
(WebInspector.DOMStorageContentView.prototype.itemAdded):
(WebInspector.DOMStorageContentView.prototype.itemUpdated):
(WebInspector.DOMStorageContentView.prototype._truncateValue):
(WebInspector.DOMStorageContentView.prototype._populate):
Whenever we get a value that we will display, truncate it to
just 200 characters.
- 3:04 PM Changeset in webkit [196341] by
-
- 8 edits in trunk/Source/WebKit2
Add SPI to remove individual user scripts or user style sheets
https://bugs.webkit.org/show_bug.cgi?id=154046
rdar://problem/23596352
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKUserContentController.mm:
(-[WKUserContentController _removeUserScript:]):
(-[WKUserContentController _userStyleSheets]):
(-[WKUserContentController _addUserStyleSheet:]):
(-[WKUserContentController _removeUserStyleSheet:]):
- UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
- UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
- UIProcess/UserContent/WebUserContentControllerProxy.h:
(WebKit::WebUserContentControllerProxy::userStyleSheets):
- WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserContentController::removeUserScript):
(WebKit::WebUserContentController::removeUserStyleSheet):
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/UserContent/WebUserContentController.messages.in:
- 3:00 PM Changeset in webkit [196340] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196303
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 2:58 PM Changeset in webkit [196339] by
-
- 2 edits in trunk/Source/WebCore
[iOS Simulator] accessibility/text-marker/text-marker-range-stale-node-crash.html crashing
https://bugs.webkit.org/show_bug.cgi?id=154039
Reviewed by Chris Fleizach.
We are accessing the derefed node in the CharacterOffset object, we should create an empty
CharacterOffset object if the node is not in use.
It's covered by the test accessibility/text-marker/text-marker-range-stale-node-crash.html.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityTextMarker characterOffset]):
(-[WebAccessibilityTextMarker isIgnored]):
- 2:54 PM Changeset in webkit [196338] by
-
- 24 edits in trunk/LayoutTests
Rebaseline more tests for ios-simulator after r196244
Unreviewed test gardening.
- platform/ios-simulator-wk2/compositing/overflow/overflow-scroll-expected.txt:
- platform/ios-simulator-wk2/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
- platform/ios-simulator-wk2/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
- platform/ios-simulator-wk2/fast/block/float/overhanging-tall-block-expected.txt:
- platform/ios-simulator-wk2/fast/clip/014-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/overflow-unsplittable-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-bt-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-lr-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-rl-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-tb-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-bt-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-lr-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-rl-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-tb-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/ios-simulator-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
- platform/ios-simulator-wk2/fast/overflow/float-in-relpositioned-expected.txt:
- platform/ios-simulator-wk2/fast/overflow/overflow-auto-position-absolute-expected.txt:
- platform/ios-simulator-wk2/fast/overflow/paged-x-div-expected.txt:
- platform/ios-simulator-wk2/fast/overflow/paged-x-div-with-column-gap-expected.txt:
- platform/ios-simulator-wk2/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- 2:42 PM Changeset in webkit [196337] by
-
- 2 edits in trunk/Source/JavaScriptCore
Don't crash if we fail to parse a builtin
https://bugs.webkit.org/show_bug.cgi?id=154047
rdar://problem/24300617
Reviewed by Mark Lam.
Crashing probably seemed like a good idea at the time, but we could get here in case of a
near stack overflow, so that the parser bails because of recursion.
- parser/Parser.h:
(JSC::parse):
- 2:16 PM Changeset in webkit [196336] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Expiration column in Storage tab can't be sorted
https://bugs.webkit.org/show_bug.cgi?id=154043
<rdar://problem/24572272>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-09
Reviewed by Brian Burg.
- UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._sortDataGrid.expiresCompare):
Sort Session as the shortest time, not the longest time. Use the
cookie.expires date when sorting, not the locale string.
- 2:09 PM Changeset in webkit [196335] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r196322
Unreviewed.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::font):
- 2:01 PM Changeset in webkit [196334] by
-
- 3 edits2 adds in trunk
Outline corners do not align properly for multiline inlines.
https://bugs.webkit.org/show_bug.cgi?id=154025
Reviewed by David Hyatt.
Adjust border position when outline-offset > 0. This patch also
removes integral pixelsnapping (drawLineForBoxSide takes care of
device pixelsnapping).
Source/WebCore:
Test: fast/inline/outline-corners-with-offset.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):
LayoutTests:
- fast/inline/outline-corners-with-offset-expected.html: Added.
- fast/inline/outline-corners-with-offset.html: Added.
- 1:49 PM Changeset in webkit [196333] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Analysis task page on v3 show progression as regressions
https://bugs.webkit.org/show_bug.cgi?id=154045
Reviewed by Chris Dumez.
The bug was caused by TestGroup.compareTestResults referring to undefined _smallerIsBetter.
Retrieve it from the associated metric object via the owner analysis task.
- public/v3/models/test-group.js:
- 1:30 PM Changeset in webkit [196332] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Adopt NSURLSession properties in AVAssetResourceLoader
Rubber-stamped by Eric Carlson;
Set the correct global variable from setAVFoundationNSURLSessionEnabled().
- page/Settings.cpp:
(WebCore::Settings::setAVFoundationNSURLSessionEnabled):
- 1:19 PM Changeset in webkit [196331] by
-
- 60 edits in trunk/Source
GetValueFunc/PutValueFunc should not take both slotBase and thisValue
https://bugs.webkit.org/show_bug.cgi?id=154009
Reviewed by Geoff Garen.
In JavaScript there are two types of properties - regular value properties, and accessor properties.
One difference between these is how they are reflected by getOwnPropertyDescriptor, and another is
what object they operate on in the case of a prototype access. If you access a value property of a
prototype object it return a value pertinent to the prototype, but in the case of a prototype object
returning an accessor, then the accessor function is applied to the base object of the access.
JSC supports special 'custom' properties implemented as a c++ callback, and these custom properties
can be used to implement either value- or accessor-like behavior. getOwnPropertyDescriptor behavior
is selected via the CustomAccessor attribute. Value- or accessor-like object selection is current
supported by passing both the slotBase and the thisValue to the callback,and hoping it uses the
right one. This is probably inefficient, bug-prone, and leads to crazy like JSBoundSlotBaseFunction.
Instead, just pass one thisValue to the callback functions, consistent with CustomAccessor.
Source/JavaScriptCore:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject<Parent>::getStaticValue):
(JSC::JSCallbackObject<Parent>::staticFunctionGetter):
(JSC::JSCallbackObject<Parent>::callbackGetter):
- Merged slotBase & thisValue to custom property callbacks.
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
- Modified the call being JIT generated - GetValueFunc/PutValueFunc now only take 3, rather than 4 arguments. Selects which one to keep/drop based on access type.
(WTF::printInternal):
- bytecode/PolymorphicAccess.h:
(JSC::AccessCase::isGet):
(JSC::AccessCase::isPut):
(JSC::AccessCase::isIn):
(JSC::AccessCase::doesCalls):
(JSC::AccessCase::isGetter):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
- jit/Repatch.cpp:
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
- Split the CustomGetter/Setter access types into Value/Accessor variants.
- jsc.cpp:
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::RuntimeArray::RuntimeArray):
(WTF::RuntimeArray::lengthGetter):
- Merged slotBase & thisValue to custom property callbacks.
- runtime/CustomGetterSetter.cpp:
(JSC::callCustomSetter):
- Pass 3 arguments when calling PutValueFunc.
- runtime/CustomGetterSetter.h:
- runtime/JSBoundSlotBaseFunction.cpp:
(JSC::boundSlotBaseFunctionCall):
(JSC::JSBoundSlotBaseFunction::JSBoundSlotBaseFunction):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- callCustomSetter currently takes a flag to distinguish value/accessor calls.
- runtime/JSFunction.cpp:
(JSC::retrieveArguments):
(JSC::JSFunction::argumentsGetter):
(JSC::retrieveCallerFunction):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::nameGetter):
- runtime/JSFunction.h:
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::visitChildren):
(JSC::callbackGetter):
- Merged slotBase & thisValue to custom property callbacks.
- runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):
- callCustomSetter currently takes a flag to distinguish value/accessor calls.
- runtime/Lookup.h:
(JSC::putEntry):
- split PutPropertySlot setCustom into Value/Accessor variants.
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
(JSC::PropertySlot::customGetter):
- runtime/PropertySlot.h:
(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::getValue):
- added customGetter helper to call GetValueFunc.
- runtime/PutPropertySlot.h:
(JSC::PutPropertySlot::PutPropertySlot):
(JSC::PutPropertySlot::setNewProperty):
(JSC::PutPropertySlot::setCustomValue):
(JSC::PutPropertySlot::setCustomAccessor):
(JSC::PutPropertySlot::setThisValue):
(JSC::PutPropertySlot::customSetter):
(JSC::PutPropertySlot::context):
(JSC::PutPropertySlot::isStrictMode):
(JSC::PutPropertySlot::isCacheablePut):
(JSC::PutPropertySlot::isCacheableSetter):
(JSC::PutPropertySlot::isCacheableCustom):
(JSC::PutPropertySlot::isCustomAccessor):
(JSC::PutPropertySlot::isInitialization):
(JSC::PutPropertySlot::cachedOffset):
(JSC::PutPropertySlot::setCustomProperty): Deleted.
- split PutPropertySlot setCustom into Value/Accessor variants.
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::regExpConstructorDollar1):
(JSC::regExpConstructorDollar2):
(JSC::regExpConstructorDollar3):
(JSC::regExpConstructorDollar4):
(JSC::regExpConstructorDollar5):
(JSC::regExpConstructorDollar6):
(JSC::regExpConstructorDollar7):
(JSC::regExpConstructorDollar8):
(JSC::regExpConstructorDollar9):
(JSC::regExpConstructorInput):
(JSC::regExpConstructorMultiline):
(JSC::regExpConstructorLastMatch):
(JSC::regExpConstructorLastParen):
(JSC::regExpConstructorLeftContext):
(JSC::regExpConstructorRightContext):
(JSC::setRegExpConstructorInput):
(JSC::setRegExpConstructorMultiline):
- runtime/RegExpObject.cpp:
(JSC::RegExpObject::defineOwnProperty):
(JSC::regExpObjectSetLastIndexStrict):
(JSC::regExpObjectSetLastIndexNonStrict):
(JSC::RegExpObject::put):
- Merged slotBase & thisValue to custom property callbacks.
Source/WebCore:
- bindings/js/JSDOMBinding.cpp:
(WebCore::printErrorMessageForFrame):
(WebCore::objectToStringFunctionGetter):
- bindings/js/JSDOMBinding.h:
(WebCore::propertyNameToString):
(WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>):
(WebCore::nonCachingStaticFunctionGetter):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitAdditionalChildren):
(WebCore::childFrameGetter):
(WebCore::namedItemGetter):
(WebCore::jsDOMWindowWebKit):
(WebCore::jsDOMWindowIndexedDB):
- add missing null check, in case indexDB acessor is applied to non-window object.
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject):
(WebCore::pluginElementPropertyGetter):
- bindings/js/JSPluginElementFunctions.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::destroy):
(JSC::RuntimeArray::lengthGetter):
- bridge/runtime_array.h:
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::finishCreation):
(JSC::RuntimeMethod::lengthGetter):
- bridge/runtime_method.h:
- bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::invalidate):
(JSC::Bindings::RuntimeObject::fallbackObjectGetter):
(JSC::Bindings::RuntimeObject::fieldGetter):
(JSC::Bindings::RuntimeObject::methodGetter):
- bridge/runtime_object.h:
- Merged slotBase & thisValue to custom property callbacks.
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyNames):
(WebKit::JSNPObject::propertyGetter):
(WebKit::JSNPObject::methodGetter):
- WebProcess/Plugins/Netscape/JSNPObject.h:
- Merged slotBase & thisValue to custom property callbacks.
- 1:17 PM Changeset in webkit [196330] by
-
- 2 edits in trunk/Source/WebCore
Build-fix; add Nullibility macros around previously un-macro'd class definitions.
- platform/spi/mac/AVFoundationSPI.h:
- 1:03 PM Changeset in webkit [196329] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Exiting fullscreen through the placeholder action leaves window in empty state
https://bugs.webkit.org/show_bug.cgi?id=152979
<rdar://problem/24132309>
Reviewed by Brent Fulgham.
In r194593, we relaxed the _fullScreenState requirement in -finishedExitFullScreenAnimation: to handle
the case where the request to exit fullscreen came from outside the process. However, in so doing, we
allowed -finishedExitFullScreenAnimation: to be called twice, and in so doing, leave the original window
empty of its WebView. Tighten up the restriction of _fullScreenState to allow only the "InFullScreen"
state (to take care of the external exit command) and the "ExitingFullScreen" state, to handle the
normal teardown path.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 12:56 PM Changeset in webkit [196328] by
-
- 15 edits in trunk/Source
[Mac] Adopt NSURLSession properties in AVAssetResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=153873
Reviewed by Eric Carlson.
Source/WebCore:
Adopt a new AVAssetResourceLoader API allowing clients to specify a NSURLSession object to
use for media loading, and control the use of this property with a new Setting.
- page/Settings.cpp:
(WebCore::Settings::setAVFoundationNSURLSessionEnabled):
- page/Settings.h:
(WebCore::Settings::isAVFoundationNSURLSessionEnabled):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
- platform/spi/mac/AVFoundationSPI.h:
Source/WebKit/mac:
Add a WebKit preference to control the WebCore isAVFoundationNSURLSessionEnabled()
setting.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setAVFoundationNSURLSessionEnabled:]):
(-[WebPreferences isAVFoundationNSURLSessionEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Add a WebKit2 preference to control the WebCore isAVFoundationNSURLSessionEnabled()
setting.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAVFoundationNSURLSessionEnabled):
(WKPreferencesGetAVFoundationNSURLSessionEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 12:55 PM Changeset in webkit [196327] by
-
- 2 edits in tags/Safari-602.1.18.0.3/Source/WebCore
Merged r195975. rdar://problem/24354546
- 12:54 PM Changeset in webkit [196326] by
-
- 5 edits in tags/Safari-602.1.18.0.3/Source
Versioning.
- 12:52 PM Changeset in webkit [196325] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Limit max and min zoom factor of Inspector
https://bugs.webkit.org/show_bug.cgi?id=154041
<rdar://problem/24571326>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-09
Reviewed by Brian Burg.
Chose reasonable zoom levels that looked good to my eye and
roughly matched Safari's page zoom levels.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
Do not implicitly prevent default for zoom in/out keyboard shortcuts to
allow for a system beep if we do not do anything.
(WebInspector._increaseZoom):
(WebInspector._decreaseZoom):
Do not go beyond a max or min zoom level. Prevent default in the case
where we actually zoom, but don't prevent default where we do not
actually zoom to cause a system beep. Allow for a slight drift of
the floating point value as it increases / decreases by 0.2 at the
different zoom factors.
(WebInspector._resetZoom):
(WebInspector._showTabAtIndex):
Remove redundant prevent default calls, since it would happen
implicitly for these keyboard shortcuts.
- 12:52 PM Changeset in webkit [196324] by
-
- 1 copy in tags/Safari-602.1.18.0.3
New tag.
- 12:18 PM Changeset in webkit [196323] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Spread expressions are not fair game for direct binding
https://bugs.webkit.org/show_bug.cgi?id=154042
rdar://problem/24291413
Reviewed by Saam Barati.
Prior to this change we crashed on this:
var [x] = [...y];
Because NodesCodegen thinks that this is a direct binding. It's not, because we cannot
directly generate bytecode for "...y". This is a unique property of spread expressions, so
its sufficient to just bail out of direct binding if we see a spread expression. That's what
this patch does.
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::emitDirectBinding):
- tests/stress/spread-in-tail.js: Added.
(foo):
(catch):
- 11:50 AM Changeset in webkit [196322] by
-
- 10 edits in trunk/Source/WebCore
Decouple font creation from font loading
https://bugs.webkit.org/show_bug.cgi?id=153414
Reviewed by Darin Adler.
Previously, CSSFontFaceSource never triggered a font download until that font was actually used. This means
that the function which triggers the download also has the goal of returning a font to use. However,
the CSS Font Loading JavaScript API requires being able to trigger a font download without this extra font
creation overhead.
In addition, this patch adds an explicit (and enforced) state transition diagram. The diagram looks like
this:
=> Success
Pending => Loading
=> Failure
Therefore, the API for CSSFontFaceSource has changed to expose the concept of these new states. This means
that its user (CSSSegmentedFontFaceSource) has been updated to handle each possible state that its constituent
CSSFontFaceSources may be in.
No new tests because there is no behavior change.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::allSourcesFailed): Renamed to make the name clearer.
(WebCore::CSSFontFace::addedToSegmentedFontFace): Use references instead of pointers.
(WebCore::CSSFontFace::removedFromSegmentedFontFace): Ditto.
(WebCore::CSSFontFace::adoptSource): Renamed to make the name clearer.
(WebCore::CSSFontFace::fontLoaded): Use references instead of pointers. Also, remove old dead code.
(WebCore::CSSFontFace::font): Adapt to the new API of CSSFontFaceSource.
(WebCore::CSSFontFace::isValid): Deleted.
(WebCore::CSSFontFace::addSource): Deleted.
(WebCore::CSSFontFace::notifyFontLoader): Deleted. Old dead code.
(WebCore::CSSFontFace::notifyLoadingDone): Deleted. Old dead code.
- css/CSSFontFace.h:
(WebCore::CSSFontFace::create): Remove old dead code.
(WebCore::CSSFontFace::CSSFontFace): Use references instead of pointers.
(WebCore::CSSFontFace::loadState): Deleted. Remove old dead code.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::setStatus): Enforce state transitions.
(WebCore::CSSFontFaceSource::CSSFontFaceSource): Explicitly handle new state transitions.
(WebCore::CSSFontFaceSource::fontLoaded): Update for new states.
(WebCore::CSSFontFaceSource::load): Pulled out code from font().
(WebCore::CSSFontFaceSource::font): Moved code into load().
(WebCore::CSSFontFaceSource::isValid): Deleted.
(WebCore::CSSFontFaceSource::isDecodeError): Deleted.
(WebCore::CSSFontFaceSource::ensureFontData): Deleted.
- css/CSSFontFaceSource.h: Much cleaner API.
- css/CSSFontSelector.cpp:
(WebCore::createFontFace): Migrate to references instead of pointers. This requires a little
reorganization.
(WebCore::registerLocalFontFacesForFamily): Update to new CSSFontFaceSource API.
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::CSSFontSelector::getFontFace): Ditto.
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::CSSSegmentedFontFace): Migrate to references instead of pointers.
(WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace): Ditto.
(WebCore::CSSSegmentedFontFace::fontLoaded): Remove old dead code.
(WebCore::CSSSegmentedFontFace::appendFontFace): Cleanup.
(WebCore::CSSSegmentedFontFace::fontRanges): Adopt to new API.
(WebCore::CSSSegmentedFontFace::pruneTable): Deleted.
(WebCore::CSSSegmentedFontFace::isLoading): Deleted. Old dead code.
(WebCore::CSSSegmentedFontFace::checkFont): Deleted. Ditto.
(WebCore::CSSSegmentedFontFace::loadFont): Deleted. Ditto.
- css/CSSSegmentedFontFace.h:
(WebCore::CSSSegmentedFontFace::create): Migrate to references instead of pointers.
(WebCore::CSSSegmentedFontFace::fontSelector): Ditto.
(WebCore::CSSSegmentedFontFace::LoadFontCallback::~LoadFontCallback): Deleted.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::didAddClient): Migrate to references instead of pointers.
(WebCore::CachedFont::checkNotify): Ditto.
- loader/cache/CachedFontClient.h:
(WebCore::CachedFontClient::fontLoaded): Ditto.
- 10:57 AM Changeset in webkit [196321] by
-
- 6 edits1 copy in trunk/Source/WebKit2
All 32-bit plug-ins should use the XPC service
https://bugs.webkit.org/show_bug.cgi?id=154036
rdar://problem/16059483
Reviewed by Dan Bernstein.
Silverlight expects malloced memory from the tiny zone to be executable. It also expects
the data segment from its coreclr image to be executable.
Make this possible by:
- Shimming mach_vm_map, making sure to add the VM_PROT_EXECUTABLE bit to any memory in the tiny zone.
- Go through the address space, looking for any existing ranges from the tiny zone and mach_vm_protect them to be executable.
- Register with dyld so we'll get callbacks whenever a library is bound, look for the coreclr image, and mach_vm_protect its DATA segment to be executable.
- Platform/spi/Cocoa/DyldSPI.h: Copied from Source/WebKit2/PluginProcess/mac/PluginProcessShim.h.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::isMallocMemoryTag):
(WebKit::shouldMapMemoryExecutable):
(WebKit::initializeShim):
(WebKit::PluginProcess::platformInitializeProcess):
- PluginProcess/mac/PluginProcessShim.h:
- PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shimMachVMMap):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
(WebKit::shouldUseXPC): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 10:33 AM Changeset in webkit [196320] by
-
- 3 edits2 copies in tags/Safari-602.1.18.6
Merged r196004. rdar://problem/24439699
- 10:32 AM Changeset in webkit [196319] by
-
- 2 edits in tags/Safari-602.1.18.6/LayoutTests
Merged r196002. rdar://problem/19506502
- 10:31 AM Changeset in webkit [196318] by
-
- 14 edits13 copies in tags/Safari-602.1.18.6
Merged r196001. rdar://problem/19506502
- 10:28 AM Changeset in webkit [196317] by
-
- 5 edits in tags/Safari-602.1.18.6/Source
Versioning.
- 10:25 AM Changeset in webkit [196316] by
-
- 1 copy in tags/Safari-602.1.18.6
New tag.
- 10:25 AM Changeset in webkit [196315] by
-
- 4 edits in trunk
[GTK][EFL] Fix several build configuration related to SamplingProfiler after r196245
https://bugs.webkit.org/show_bug.cgi?id=154033
Reviewed by Michael Catanzaro.
.:
- Source/cmake/WebKitFeatures.cmake:
Source/WTF:
- wtf/Platform.h:
- 10:16 AM Changeset in webkit [196314] by
-
- 95 edits1 add in trunk/LayoutTests
[Win] Rebaseline after r196244.
Unreviewed test gardening.
- platform/win/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/win/fast/block/float/overhanging-tall-block-expected.txt:
- platform/win/fast/block/positioning/auto/vertical-rl/007-expected.txt:
- platform/win/fast/borders/border-antialiasing-expected.txt:
- platform/win/fast/clip/001-expected.txt:
- platform/win/fast/clip/013-expected.txt:
- platform/win/fast/clip/014-expected.txt:
- platform/win/fast/clip/outline-overflowClip-expected.txt:
- platform/win/fast/css/clip-zooming-expected.txt:
- platform/win/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
- platform/win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
- platform/win/fast/line-grid/line-grid-inside-columns-expected.txt:
- platform/win/fast/line-grid/line-grid-into-columns-expected.txt:
- platform/win/fast/lists/scrolled-marker-paint-expected.txt:
- platform/win/fast/multicol/client-rects-expected.txt:
- platform/win/fast/multicol/column-break-with-balancing-expected.txt:
- platform/win/fast/multicol/column-rules-expected.txt:
- platform/win/fast/multicol/column-rules-stacking-expected.txt:
- platform/win/fast/multicol/columns-shorthand-parsing-expected.txt:
- platform/win/fast/multicol/float-paginate-complex-expected.txt:
- platform/win/fast/multicol/float-paginate-empty-lines-expected.txt:
- platform/win/fast/multicol/float-paginate-expected.txt:
- platform/win/fast/multicol/layers-in-multicol-expected.txt:
- platform/win/fast/multicol/layers-split-across-columns-expected.txt:
- platform/win/fast/multicol/max-height-columns-block-expected.txt:
- platform/win/fast/multicol/nested-columns-expected.txt:
- platform/win/fast/multicol/newmulticol/client-rects-expected.txt:
- platform/win/fast/multicol/overflow-across-columns-expected.txt:
- platform/win/fast/multicol/overflow-across-columns-percent-height-expected.txt:
- platform/win/fast/multicol/overflow-unsplittable-expected.txt:
- platform/win/fast/multicol/paginate-block-replaced-expected.txt:
- platform/win/fast/multicol/pagination/BottomToTop-bt-expected.txt:
- platform/win/fast/multicol/pagination/BottomToTop-lr-expected.txt:
- platform/win/fast/multicol/pagination/BottomToTop-rl-expected.txt:
- platform/win/fast/multicol/pagination/BottomToTop-tb-expected.txt:
- platform/win/fast/multicol/pagination/LeftToRight-bt-expected.txt:
- platform/win/fast/multicol/pagination/LeftToRight-rl-expected.txt:
- platform/win/fast/multicol/pagination/LeftToRight-tb-expected.txt:
- platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt:
- platform/win/fast/multicol/pagination/RightToLeft-bt-expected.txt:
- platform/win/fast/multicol/pagination/RightToLeft-lr-expected.txt:
- platform/win/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
- platform/win/fast/multicol/pagination/RightToLeft-rl-expected.txt:
- platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
- platform/win/fast/multicol/pagination/RightToLeft-tb-expected.txt:
- platform/win/fast/multicol/pagination/TopToBottom-bt-expected.txt:
- platform/win/fast/multicol/pagination/TopToBottom-lr-expected.txt:
- platform/win/fast/multicol/pagination/TopToBottom-rl-expected.txt:
- platform/win/fast/multicol/positive-leading-expected.txt:
- platform/win/fast/multicol/scrolling-column-rules-expected.txt:
- platform/win/fast/multicol/scrolling-overflow-expected.txt:
- platform/win/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/win/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/win/fast/multicol/table-vertical-align-expected.txt:
- platform/win/fast/multicol/tall-image-behavior-expected.txt:
- platform/win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/win/fast/multicol/vertical-lr/column-rules-expected.txt:
- platform/win/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
- platform/win/fast/multicol/vertical-lr/float-paginate-expected.txt:
- platform/win/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/win/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
- platform/win/fast/multicol/vertical-rl/float-paginate-expected.txt:
- platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/win/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
- platform/win/fast/overflow/float-in-relpositioned-expected.txt:
- platform/win/fast/overflow/overflow-auto-position-absolute-expected.txt:
- platform/win/fast/overflow/overflow-rtl-expected.txt:
- platform/win/fast/overflow/paged-x-div-expected.txt:
- platform/win/fast/overflow/paged-x-div-with-column-gap-expected.txt:
- platform/win/fast/overflow/paged-x-on-root-expected.txt:
- platform/win/fast/overflow/paged-x-with-column-gap-expected.txt:
- platform/win/fast/overflow/paged-y-div-expected.txt:
- platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/win/fast/repaint/box-shadow-h-expected.txt:
- platform/win/fast/repaint/box-shadow-v-expected.txt:
- platform/win/fast/repaint/layer-outline-expected.txt:
- platform/win/fast/repaint/layer-outline-horizontal-expected.txt:
- platform/win/fast/table/edge-offsets-expected.txt:
- platform/win/fast/transforms/overflow-with-transform-expected.txt:
- platform/win/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
- platform/win/scrollbars/scrollbars-on-positioned-content-expected.txt:
- platform/win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/win/svg/custom/image-rescale-clip-expected.txt:
- 9:40 AM Changeset in webkit [196313] by
-
- 5 edits2 adds in trunk/Source/WebCore
Modern IDB: IDBOpenDBRequests leak.
https://bugs.webkit.org/show_bug.cgi?id=154032
Reviewed by Alex Christensen.
No new tests (Currently untestable).
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
Add a simple Event subclass that holds a ref to an IDBRequest, to make sure that we
drop the last ref to the request after its last event fires or is otherwise destroyed:
- Modules/indexeddb/IDBRequestCompletionEvent.cpp: Added.
(WebCore::IDBRequestCompletionEvent::IDBRequestCompletionEvent):
- Modules/indexeddb/IDBRequestCompletionEvent.h: Added.
(WebCore::IDBRequestCompletionEvent::create):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onError): IDBRequestCompletionEvent instead of Event.
(WebCore::IDBClient::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit): Ditto.
(WebCore::IDBClient::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion): Ditto.
(WebCore::IDBClient::IDBOpenDBRequest::onSuccess): Ditto.
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::dispatchEvent): After setting up the request's
completion event to fire, clear the back-ref to the request.
- 9:38 AM Changeset in webkit [196312] by
-
- 2 edits in trunk/Tools
[EFL] Remove eail related cruft after r195725
https://bugs.webkit.org/show_bug.cgi?id=154030
Reviewed by Alex Christensen.
- efl/jhbuildrc:
- 9:35 AM Changeset in webkit [196311] by
-
- 2 edits3 deletes in trunk/Tools
[EFL] Remove LLVM related cruft after r196077
https://bugs.webkit.org/show_bug.cgi?id=154031
Reviewed by Alex Christensen.
- efl/jhbuild.modules:
- efl/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
- efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
- efl/patches/llvm-version-arm64.patch: Removed.
- 9:13 AM Changeset in webkit [196310] by
-
- 2 edits in trunk/Source/WebKit/mac
checkValidity() sometimes asserts in WebUserMediaClient::pageDestroyed
https://bugs.webkit.org/show_bug.cgi?id=154029
<rdar://problem/24065022>
Reviewed by Alex Christensen.
- WebCoreSupport/WebUserMediaClient.mm:
(WebUserMediaClient::pageDestroyed): Copy map keys to a vector and clear the map before
enumerating the vector and canceling the requests. ASSERT that the map is not modified
during cleanup. Clean up the permission check map.
(WebUserMediaClient::requestUserMediaAccess): Add the request to the map before calling the
UI delegate in case it works synchronously (as it does in DRT).
(WebUserMediaClient::checkUserMediaPermission): Ditto.
(WebUserMediaClient::cancelUserMediaPermissionCheck): White-space cleanup.
(-[WebUserMediaPolicyListener allow]): Ditto.
- 9:09 AM Changeset in webkit [196309] by
-
- 82 edits12 copies2 adds in trunk/LayoutTests
[iOS] Rebaseline after r196244.
Unreviewed test gardening.
- platform/ios-simulator/compositing/geometry/clipping-foreground-expected.txt:
- platform/ios-simulator/compositing/geometry/root-layer-update-expected.txt:
- platform/ios-simulator/compositing/overflow/overflow-scroll-expected.txt:
- platform/ios-simulator/compositing/overflow/parent-overflow-expected.txt:
- platform/ios-simulator/compositing/overflow/scrollbar-painting-expected.txt:
- platform/ios-simulator/compositing/sibling-positioning-expected.txt:
- platform/ios-simulator/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Added.
- platform/ios-simulator/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Added.
- platform/ios-simulator/css3/blending/blend-mode-overflow-expected.txt:
- platform/ios-simulator/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/ios-simulator/fast/block/float/overhanging-tall-block-expected.txt:
- platform/ios-simulator/fast/borders/border-antialiasing-expected.txt:
- platform/ios-simulator/fast/clip/001-expected.txt:
- platform/ios-simulator/fast/clip/013-expected.txt:
- platform/ios-simulator/fast/clip/014-expected.txt:
- platform/ios-simulator/fast/clip/016-expected.txt:
- platform/ios-simulator/fast/clip/outline-overflowClip-expected.txt:
- platform/ios-simulator/fast/css/clip-zooming-expected.txt:
- platform/ios-simulator/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
- platform/ios-simulator/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
- platform/ios-simulator/fast/line-grid/line-grid-inside-columns-expected.txt:
- platform/ios-simulator/fast/line-grid/line-grid-into-columns-expected.txt:
- platform/ios-simulator/fast/lists/scrolled-marker-paint-expected.txt:
- platform/ios-simulator/fast/multicol/client-rects-expected.txt:
- platform/ios-simulator/fast/multicol/column-break-with-balancing-expected.txt:
- platform/ios-simulator/fast/multicol/column-rules-expected.txt:
- platform/ios-simulator/fast/multicol/column-rules-stacking-expected.txt:
- platform/ios-simulator/fast/multicol/columns-shorthand-parsing-expected.txt:
- platform/ios-simulator/fast/multicol/float-paginate-complex-expected.txt:
- platform/ios-simulator/fast/multicol/float-paginate-empty-lines-expected.txt:
- platform/ios-simulator/fast/multicol/float-paginate-expected.txt:
- platform/ios-simulator/fast/multicol/layers-in-multicol-expected.txt:
- platform/ios-simulator/fast/multicol/layers-split-across-columns-expected.txt:
- platform/ios-simulator/fast/multicol/max-height-columns-block-expected.txt:
- platform/ios-simulator/fast/multicol/nested-columns-expected.txt:
- platform/ios-simulator/fast/multicol/newmulticol/client-rects-expected.txt:
- platform/ios-simulator/fast/multicol/overflow-across-columns-expected.txt:
- platform/ios-simulator/fast/multicol/overflow-across-columns-percent-height-expected.txt:
- platform/ios-simulator/fast/multicol/overflow-unsplittable-expected.txt:
- platform/ios-simulator/fast/multicol/paginate-block-replaced-expected.txt:
- platform/ios-simulator/fast/multicol/pagination/BottomToTop-bt-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/TopToBottom-bt-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/BottomToTop-lr-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/TopToBottom-lr-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/BottomToTop-rl-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/TopToBottom-rl-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/BottomToTop-tb-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/TopToBottom-bt-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/LeftToRight-bt-expected.txt:
- platform/ios-simulator/fast/multicol/pagination/LeftToRight-rl-expected.txt:
- platform/ios-simulator/fast/multicol/pagination/LeftToRight-tb-expected.txt:
- platform/ios-simulator/fast/multicol/pagination/RightToLeft-bt-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/LeftToRight-tb-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/RightToLeft-lr-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/LeftToRight-rl-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/LeftToRight-rl-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/RightToLeft-rl-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/LeftToRight-rl-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/RightToLeft-tb-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/pagination/LeftToRight-tb-expected.txt.
- platform/ios-simulator/fast/multicol/pagination/TopToBottom-bt-expected.txt:
- platform/ios-simulator/fast/multicol/pagination/TopToBottom-lr-expected.txt:
- platform/ios-simulator/fast/multicol/pagination/TopToBottom-rl-expected.txt:
- platform/ios-simulator/fast/multicol/positive-leading-expected.txt:
- platform/ios-simulator/fast/multicol/scrolling-column-rules-expected.txt:
- platform/ios-simulator/fast/multicol/scrolling-overflow-expected.txt:
- platform/ios-simulator/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/ios-simulator/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/ios-simulator/fast/multicol/table-vertical-align-expected.txt:
- platform/ios-simulator/fast/multicol/tall-image-behavior-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-lr/column-rules-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-lr/float-paginate-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt.
- platform/ios-simulator/fast/multicol/vertical-rl/column-rules-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/vertical-lr/column-rules-expected.txt.
- platform/ios-simulator/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Copied from LayoutTests/platform/ios-simulator/fast/multicol/vertical-lr/float-paginate-complex-expected.txt.
- platform/ios-simulator/fast/multicol/vertical-rl/float-paginate-expected.txt:
- platform/ios-simulator/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/ios-simulator/fast/overflow/float-in-relpositioned-expected.txt:
- platform/ios-simulator/fast/overflow/overflow-auto-position-absolute-expected.txt:
- platform/ios-simulator/fast/overflow/overflow-rtl-expected.txt:
- platform/ios-simulator/fast/overflow/paged-x-div-expected.txt:
- platform/ios-simulator/fast/overflow/paged-x-div-with-column-gap-expected.txt:
- platform/ios-simulator/fast/overflow/paged-x-on-root-expected.txt:
- platform/ios-simulator/fast/overflow/paged-x-with-column-gap-expected.txt:
- platform/ios-simulator/fast/overflow/paged-y-div-expected.txt:
- platform/ios-simulator/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/ios-simulator/fast/regions/repaint/region-painting-via-layout-expected.txt:
- platform/ios-simulator/fast/table/edge-offsets-expected.txt:
- platform/ios-simulator/fast/transforms/overflow-with-transform-expected.txt:
- platform/ios-simulator/svg/custom/image-rescale-clip-expected.txt:
- 4:38 AM Changeset in webkit [196308] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r196286.
https://bugs.webkit.org/show_bug.cgi?id=154026
Looks like 5% iOS PLT regression (Requested by kling on
#webkit).
Reverted changeset:
"[iOS] Throw away some unlinked code when navigating to a new
page."
https://bugs.webkit.org/show_bug.cgi?id=154014
http://trac.webkit.org/changeset/196286
- 12:23 AM Changeset in webkit [196307] by
-
- 2 edits in trunk/Source/WebKit2
possible buffer overrun in Connection::processMessage of Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=153637
Patch by Fujii Hironori <Hironori.Fujii@jp.sony.com> on 2016-02-09
Reviewed by Carlos Garcia Campos.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage): Fix invalid arguments of memmove.
- 12:19 AM Changeset in webkit [196306] by
-
- 1 copy in releases/WebKitGTK/webkit-2.11.5
WebKitGTK+ 2.11.5
- 12:07 AM Changeset in webkit [196305] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.5 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.11.5.
Feb 8, 2016:
- 9:26 PM Changeset in webkit [196304] by
-
- 7 edits in trunk/PerformanceTests
Address Said's comments on the benchmark, and do some clean up.
- Animometer/developer.html:
- Animometer/resources/debug-runner/animometer.css: Add styles for averages.
- Animometer/resources/debug-runner/animometer.js: Use the right
Strings constants.
- Animometer/resources/debug-runner/graph.js:
(_addRegressionLine): Add missing code to draw the line and standard
deviation highlight.
(onGraphTypeChanged): Remove unneeded variables
(onTimeGraphOptionsChanged):
- Animometer/resources/runner/benchmark-runner.js:
(_runBenchmarkAndRecordResults): Rename samplers to suiteResults and
_suitesSamplers to _suitesResults.
- Animometer/tests/resources/main.js:
(results): Call processSamples().
(update): Change sampling timestamp comparison.
(_animateLoop): Move shouldStop call to before the update.
- Animometer/tests/resources/sampler.js:
(process): Rename to processSamples().
- 9:15 PM Changeset in webkit [196303] by
-
- 21 edits in trunk
Attribute getters should not require an explicit 'this' value for Window properties
https://bugs.webkit.org/show_bug.cgi?id=153968
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Attribute getters should not require an explicit 'this' value for
Window properties. This is because the Window interface is marked
as [ImplicitThis]:
This matches the behavior of Firefox and the expectations of the W3C
web-platform-tests.
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
In attribute getters of an interface marked as [ImplicitThis],
if 'thisValue' is undefined or null, fall back to using the
global object as 'thisValue'.
- bindings/scripts/IDLAttributes.txt:
Add support for [ImplicitThis]:
http://heycam.github.io/webidl/#ImplicitThis
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
Rebaseline bindings tests.
- page/DOMWindow.idl:
Mark Window as [ImplicitThis]:
http://heycam.github.io/webidl/#ImplicitThis
LayoutTests:
Rebaseline existing tests now that more checks are passing.
- fast/dom/Window/getOwnPropertyDescriptor-other-window-expected.txt:
- fast/dom/Window/getOwnPropertyDescriptor-other-window.html:
- js/getOwnPropertyDescriptor-window-attributes-expected.txt:
- 7:46 PM Changeset in webkit [196302] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Error construction for inlined operations should not use the inliner's CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=154021
Reviewed by Mark Lam.
Previously, if one function, A, was inlined into another function, B, in the DFG/FTL
we would use B's DFG/FTL CodeBlock to construct source information about the Error.
We would correctly compute the bytecodeOffset in A for the an expression but we would
not use one of A's CodeBlocks when looking up source. This caused crashes during
operationIn as we expected to be able to find the text "in" in the source.
- runtime/ErrorInstance.cpp:
(JSC::appendSourceToError):
- tests/stress/inlined-error-gets-correct-codeblock-for-bytecodeoffset.js: Added.
(map):
(n):
(one):
(catch):
- 7:33 PM Changeset in webkit [196301] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception merging script profiler records
https://bugs.webkit.org/show_bug.cgi?id=154004
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-08
Reviewed by Brian Burg.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._mergeScriptProfileRecords):
Stop if we've merged all script profiler records.
- 7:31 PM Changeset in webkit [196300] by
-
- 2 edits in trunk/Source/JavaScriptCore
runtimeTypeForValue should protect against seeing TDZ value
https://bugs.webkit.org/show_bug.cgi?id=154023
Reviewed by Michael Saboff.
There are a few back traces I've seen from crashes that bottom out
inside runtimeTypeForValue. I haven't been able to reproduce
any such crash, but it's likely that we're encountering the
empty JSValue. It's better to just have this function protect
against seeing the empty value instead of dereferencing a null
pointer when it thinks the value is a cell.
- runtime/RuntimeType.cpp:
(JSC::runtimeTypeForValue):
- 7:30 PM Changeset in webkit [196299] by
-
- 2 edits in trunk/PerformanceTests
Teach Controller to measure intervals, and turn off the frame length estimator.
- Animometer/tests/resources/main.js: Default interval length is 100 ms.
(start): Set the first interval.
(_measureAndResetInterval): Reports the average frame length of the interval that just
completed, and sets up the next interval.
(update): If there is no length, then just use the estimator per frame, otherwise the
estimator measures per interval. Add a didFinishInterval for subclasses to process
prior to recording the sample. Update tune() to include whether an interval had
finished.
(StepController): Step controllers don't measure on an interval basis.
- 7:30 PM Changeset in webkit [196298] by
-
- 2 edits in trunk/PerformanceTests
Minor refactoring. Rename Controller._estimator to Controller._frameLengthEstimator
and switch the parameters for start(), update(), and tune(), so that the timestamp
is first and stage is second.
- Animometer/tests/resources/main.js:
- 7:30 PM Changeset in webkit [196297] by
-
- 5 edits in trunk/PerformanceTests
Move ResultsTable functionality not needed for release tests out.
Move reporting of score and mean to selection of the time-based graph.
- Animometer/developer.html: Rename graph-options to time-graph-options.
- Animometer/resources/debug-runner/animometer.js:
(DeveloperResultsTable): Moved from runner/animometer.js. Switch from mean
values to "average" objects which can hold stdev. Move graph button and
calculation of noisy measurements here. Sophisticated header processing
is not needed in release suite.
(populateTable): Use DeveloperResultsTable.
- Animometer/resources/debug-runner/graph.js: Pull time graph creation to
its own function, and add a new onGraphTypeChanged handler in preparation
of a complexity graph to be added later.
- Animometer/resources/runner/animometer.js:
(ResultsTable): Simplify to just handle test names and scores.
- 7:30 PM Changeset in webkit [196296] by
-
- 5 edits in trunk/PerformanceTests
Tests: reuse objects already made.
Avoid thrash of object creation and removal by maintaining an index that
moves along the array as the adjust values change. If the tune value
requires more objects than the maximum size of the object array, then create
new objects. This means that the object array size never decreases.
- Animometer/tests/master/resources/canvas-stage.js: Maintain a separate
offsetIndex. For these tests, we want to avoid drawing the oldest objects,
so the scene will draw the object at offsetIndex to the end of the array.
(tune): Reverse the logic since "removal" of objects is much simpler and
involves simply changing the offsetIndex.
(animate): Update the for loop to draw from offsetIndex to the end.
(complexity): Update the definition.
- Animometer/tests/master/resources/canvas-tests.js: Maintain a separate
offsetIndex. For these tests, we want to avoid drawing the newest objects,
so the scene will draw the object at index 0 to the object at offsetIndex.
(SimpleCanvasStage.animate): Fly-by removal of local stage variable,
which is unneeded. Update the for loop to draw from offsetIndex to the end.
- Animometer/tests/simple/resources/simple-canvas-paths.js:
(SimpleCanvasStage.animate): Update the for loop to draw from 0 to
offsetIndex.
- Animometer/tests/simple/resources/simple-canvas.js:
(tune): Update logic. Here, offsetIndex represents the boundary of the last
index to render.
(animate): Update the for loop to draw from 0 to offsetIndex.
(complexity): Update the definition.
- 7:30 PM Changeset in webkit [196295] by
-
- 7 edits in trunk/PerformanceTests
Tests: refactor and update styles.
- Animometer/tests/resources/main.js: Add helper methods that return
a color that hue rotates based on the date, and a counter value that
increases based on the date. Fix randomInt() to not bias against the min and
max values.
- Animometer/tests/master/resources/canvas-tests.js: Use new helper methods.
- Animometer/tests/master/resources/dom-particles.js: Ditto.
- Animometer/tests/master/resources/particles.js: Ditto.
- Animometer/tests/simple/resources/simple-canvas-paths.js: Refactor to
use a rotating color instead of a random color. The fast switching of color
is too vivid to watch.
- Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js:
(BouncingSvgParticlesStage.call.createGradient): Fix the gradient so
that the last stop is located at the end.
- 7:30 PM Changeset in webkit [196294] by
-
- 12 edits in trunk/PerformanceTests
Refactor tune() to not return the complexity of the scene.
We have stage.complexity() now, so returning the complexity through tune
is unnecessary.
- Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
- Animometer/tests/master/resources/canvas-stage.js:
- Animometer/tests/master/resources/particles.js:
- Animometer/tests/misc/resources/canvas-electrons.js:
- Animometer/tests/misc/resources/canvas-stars.js:
- Animometer/tests/resources/main.js:
- Animometer/tests/simple/resources/simple-canvas.js:
- Animometer/tests/simple/resources/tiled-canvas-image.js:
- Animometer/tests/template/resources/template-canvas.js:
- Animometer/tests/template/resources/template-css.js:
- Animometer/tests/template/resources/template-svg.js:
- Animometer/tests/text/resources/layering-text.js:
- 7:30 PM Changeset in webkit [196293] by
-
- 4 edits in trunk/PerformanceTests
Make the fixed controller a step controller instead. Halfway through the test
it will bump up the complexity 4-fold. Calculate the step timestamp using options
instead of a separate parameter to the Controller constructor.
- Animometer/developer.html: Change value to "step"
- Animometer/resources/debug-runner/animometer.js:
(window.suitesManager.updateEditsElementsState): Show number inputs when set to "step".
- Animometer/tests/resources/main.js:
(update): Provide a hook for subclasses to tune.
(StepController): Maintain a flag determining whether we've stepped, and the time
we should step.
(Benchmark): Use the new StepController.
- 7:30 PM Changeset in webkit [196292] by
-
- 5 edits in trunk/PerformanceTests
Adjust the FPS graph scale.
Instead of making the FPS graph linearly scale, scale it based on the frame length,
but show the data in terms of FPS. Because it is inversely proportional, and most
of the data never gets below 20, concentrate the axis from 20-60 FPS, since otherwise
over half of the available graph space ends up blank.
This means we should convert all of the FPS data to frame length data.
- Animometer/resources/debug-runner/graph.js: Update the domain to be based on
frame length in milliseconds instead of FPS. Update the cursor to consider all of the
values being shown, and then pick the min and max values to represent the length of the
cursor.
- Animometer/resources/runner/animometer.js:
- Animometer/resources/strings.js:
- Animometer/tests/resources/main.js:
(processSamples): Add the ability to only sample a range of the data instead of everything
after an offset index. Update sampler to record the frame lengths instead of the frame
rate.
- 7:30 PM Changeset in webkit [196291] by
-
- 4 edits in trunk/PerformanceTests
Add option to use different methods for retrieving a timestamp.
- Animometer/developer.html: Add performance.now and Date.now options.
- Animometer/resources/runner/animometer.js: Default to performance.now.
(window.benchmarkController.startBenchmark):
- Animometer/tests/resources/main.js: Tie the desired method to _getTimestamp.
(run): Use _getTimestamp.
(_animateLoop): Ditto.
- 7:30 PM Changeset in webkit [196290] by
-
- 7 edits in trunk/PerformanceTests
Allow adding any number of markers to the graph. The markers can be labeled
and contain timestamp and sample index data. Make it a part of the controller
rather than keeping it in the sampler.
- Animometer/resources/debug-runner/animometer.css: Add styles for markers
- Animometer/resources/debug-runner/graph.js: Create the markers and add
text labels.
- Animometer/resources/runner/animometer.js: Assume the samplingTimeOffset
is just one of the marks provided.
- Animometer/resources/strings.js: Add Strings.json.marks.
- Animometer/tests/resources/main.js:
(Controller): Keep marks here. They are keyed by the marker name, so no two
markers should have the same name.
(recordFirstSample): Refactor to use mark.
(mark): Allows for arbitrary data if needed later. The timestamp maintained
is relative to the absolute start timestamp.
(containsMark): Checks whether a mark with a specific comment exists.
(processSamples): Removes the _startTimestamp offset from the marks before
setting it in results.
- Animometer/tests/resources/sampler.js: Remove marks.
- 7:30 PM Changeset in webkit [196289] by
-
- 22 edits in trunk/PerformanceTests
Get rid of options member variable in Benchmark.
Options are only needed when initializing the stage or benchmark, so there's no
need to also keep a reference to it.
- Animometer/tests/resources/main.js: Get rid of options variable in Benchmark.
Pass options to Controllers and Stages.
(Controller.Utilities.createClass):
(Benchmark.Utilities.createClass):
(get options): Deleted.
- Animometer/tests/bouncing-particles/resources/bouncing-canvas-images.js:
- Animometer/tests/bouncing-particles/resources/bouncing-canvas-particles.js:
- Animometer/tests/bouncing-particles/resources/bouncing-canvas-shapes.js:
- Animometer/tests/bouncing-particles/resources/bouncing-css-images.js:
- Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js:
- Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
- Animometer/tests/bouncing-particles/resources/bouncing-svg-images.js:
- Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js:
- Animometer/tests/master/resources/canvas-stage.js:
- Animometer/tests/master/resources/canvas-tests.js:
- Animometer/tests/master/resources/particles.js:
- Animometer/tests/misc/resources/canvas-electrons.js:
- Animometer/tests/misc/resources/canvas-stars.js:
- Animometer/tests/misc/resources/compositing-transforms.js:
- Animometer/tests/simple/resources/simple-canvas-paths.js:
- Animometer/tests/simple/resources/tiled-canvas-image.js:
- Animometer/tests/template/resources/template-canvas.js:
- Animometer/tests/template/resources/template-css.js:
- Animometer/tests/template/resources/template-svg.js:
- Animometer/tests/text/resources/layering-text.js:
- 7:25 PM Changeset in webkit [196288] by
-
- 10 edits in trunk/PerformanceTests
Update how the benchmark is run
https://bugs.webkit.org/show_bug.cgi?id=153960
Provisionally reviewed by Said Abou-Hallawa.
Introduce the notion of a Controller. It is responsible for recording, updating,
and processing the statistics and complexity of the benchmark. This allows
plugging in different Controllers.
This strips most of the functionality from Animator and BenchmarkState, so fold
what's left into Benchmark. Now, Benchmarks only own a stage and a controller, but
are responsible for driving the animation loop.
Rewrite Animator._shouldRequestAnotherFrame into two different Controllers. One
maintains a fixed complexity, and the other adapts the complexity to meet a
fixed FPS.
Fix the Kalman estimator to be modeled on a scalar variable with no model.
- Animometer/tests/resources/main.js: Remove BenchmarkState and Animator, and
replace it with a Controller. Add a FixedController and refactor the previous controller
to an AdaptiveController.
(Controller): Controllers own the estimator and the sampler. When a new frame is
displayed, the animation loop calls update(). The estimator and sampler record
stats, then tune. Samplers can track multiple series of data. The basic controller
tracks timestamp, complexity, and estimated frame rate.
The Kalman estimation is based on the frame length rather than the frame
rate. Because FPS is inverse proportional to frame length, in the case where the measured
frame length is very small, the FPS ends up being a wildly large number (in the order of
600-1000 "FPS"), and it pulls the estimator up drastically enough that it takes a while
for it to settle back down. Using frame length reduces the impact of these spikes.
Converging the estimation takes enough time to avoid initializing it immediately
when the benchmark starts. Instead, the benchmark runs for a brief period of time (100ms)
before running it in earnest. Allow controllers an opportunity to set the complexity
before starting recording.
When the benchmark is complete, the controller has an opportunity to process
the samples. The default implementation calculates the raw FPS based on the time
difference of the samples, and calculates the complexity score. This is moved from
Benchmark.processSamples.
(Controller): Initialize timestamps. These are at first relative to the start of the
benchmark, but are offset by the absolute start time during start(). By default maintain
3 data series, but subclasses can override.
(start): Calls recordFirstSample() for subclasses to override if needed.
(recordFirstSample): For basic controller, start sampling at the beginning.
(update): Update the frame length estimator and sample.
(shouldStop): Checks that the time is before _endTimestamp.
(results): Returns the processed samples.
(processSamples): Iterate through the sample data and collate them. Include scores.
(FixedComplexityController): Controller that tunes the stage to the desired complexity
prior to starting, and keeps it at that complexity.
(AdaptiveController): Have the estimator estimate the interval frame rate instead of the
raw frame rate.
The previous version of this controller ignored the frame that came after the
adjustment. The raw FPS show that whatever noise the scene change adds is negligible
compared to the noise of the system overall. Stop ignoring that frame and include all
frames in the measurements.
(Benchmark): Remove dependency on animator, and instantiate a runner based on what is
selected. Most of the loop's functionality is in Controller, so remove here.
(Benchmark.run): Remove start() since it is only called from run(), and fold it in here.
(Benchmark._animateLoop): Fold in from Animator.animateLoop. Let the benchmark run for
a brief period before calling Controller.start().
- Animometer/tests/resources/math.js: Fix the Kalman estimator. The filter estimates
a scalar variable, and makes basic assumptions regarding the model. As a result
none of the linear algebra classes are needed, so remove Matrix, Vector3, and Matrix3.
(SimpleKalmanEstimator): Calculate the gain based on the provided process and
measurement errors.
(KalmanEstimator): Deleted.
(IdentityEstimator): Deleted.
(PIDController): Refactor to use the Utilities.createClass() helper.
The Kalman filter algorithm is explained here http://greg.czerniak.info/guides/kalman1/.
The state, represented by a scalar, is the estimated frame length. There is no user
transition of the state, and the state is the same as the measurement. With this model,
the estimation error converges, so calculate the gain ahead of time.
- Animometer/developer.html: Remove fixed-after-warmup since it is not useful.
Replace the option to toggle the estimator, and make it possible to customize the
estimator's error parameters. Show raw FPS by default, and remove interval FPS,
which will be shown instead of the filtered raw FPS.
- Animometer/resources/debug-runner/animometer.css: Put the header behind the graph.
Remove #intervalFPS rules; move the color to #filteredFPS.
- Animometer/resources/debug-runner/graph.js:
(updateGraphData): Update the hr style to force the layout to be calculated
correctly. Change the tick format to be in terms of seconds, since the timestamps
are in milliseconds. Remove interval data.
- Animometer/resources/runner/animometer.js:
(window.benchmarkController.startBenchmark): Set Kalman parameters.
- Animometer/resources/runner/benchmark-runner.js:
(_runBenchmarkAndRecordResults): When a benchmark completes, expect it to return
the final data, rather than passing a sampler from the controller. This avoids
needing to expose the sampler variable in the benchmark.
- Animometer/tests/resources/sampler.js:
(process): Move the setting of the target frame rate to AdaptiveController.
- 7:04 PM Changeset in webkit [196287] by
-
- 5 edits2 adds in trunk
AX: crash at WebCore::Range::selectNodeContents(WebCore::Node*, int&)
https://bugs.webkit.org/show_bug.cgi?id=154018
Reviewed by Chris Fleizach.
Source/WebCore:
Sometimes rangeForUnorderedCharacterOffsets call is accessing derefed node objects
and leading to a crash. Fixed it by checking isNodeInUse before creating the CharacterOffset
object.
Test: accessibility/text-marker/text-marker-range-stale-node-crash.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
(WebCore::AXObjectCache::characterOffsetForTextMarkerData):
(WebCore::AXObjectCache::traverseToOffsetInRange):
- accessibility/AXObjectCache.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper rangeForTextMarkerRange:]):
(characterOffsetForTextMarker):
(-[WebAccessibilityObjectWrapper characterOffsetForTextMarker:]):
(textMarkerForVisiblePosition):
LayoutTests:
- accessibility/text-marker/text-marker-range-stale-node-crash-expected.txt: Added.
- accessibility/text-marker/text-marker-range-stale-node-crash.html: Added.
- 6:22 PM Changeset in webkit [196286] by
-
- 7 edits in trunk/Source
[iOS] Throw away some unlinked code when navigating to a new page.
<https://webkit.org/b/154014>
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- runtime/VM.cpp:
(JSC::VM::deleteAllCodeExceptCaches):
(JSC::VM::deleteAllLinkedCode): Deleted.
- runtime/VM.h:
Source/WebCore:
Extended the mechanism introduced earlier to also throw away unlinked code
that's only relevant to the page that we're navigating away from.
The new JSC::VM API is deleteAllCodeExceptCaches() and it does what it sounds
like, deleting unlinked and linked code but leaving code caches alone.
This means that if the page we're navigating to wants to parse some of the
same JS that the page we're leaving had on it, it might still be found in the
JSC::CodeCache.
Doing a back navigation to a PageCache'd page may now incur some reparsing,
just like leaving the app or tab would.
- bindings/js/GCController.cpp:
(WebCore::GCController::deleteAllCodeExceptCaches):
(WebCore::GCController::deleteAllLinkedCode): Deleted.
- bindings/js/GCController.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- 5:55 PM Changeset in webkit [196285] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Search doesn't seem to find text that is present in multiple places
https://bugs.webkit.org/show_bug.cgi?id=154016
<rdar://problem/23391307>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-08
Reviewed by Brian Burg.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.get searchableScripts):
- UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel.prototype.performSearch):
Only search scripts with a URL. Don't search the potentially
large number of anonymous scripts.
- 5:50 PM Changeset in webkit [196284] by
-
- 4 edits2 adds in trunk
Web Inspector: Zooming in on the timeline graph does not increase its time resolution from minutes
https://bugs.webkit.org/show_bug.cgi?id=154013
<rdar://problem/23844527>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-08
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Base/Utilities.js:
(Number.secondsToString):
Simplify logic and ensure that when under high resolution we
don't go above seconds for our units.
(Number.bytesToString):
Simplify logic.
- UserInterface/Views/LinearTimelineOverview.js:
(WebInspector.LinearTimelineOverview):
Reduce the rather large maximum seconds per pixel from 60 seconds
per pixel to 2 seconds per pixel. This means when the user zooms
out of a timeline they don't see such large time values.
LayoutTests:
- inspector/unit-tests/number-utilities-expected.txt: Added.
- inspector/unit-tests/number-utilities.html: Added.
Basic tests for our Number utilities methods.
- 5:26 PM Changeset in webkit [196283] by
-
- 23 edits30 adds in trunk
CSP connect-src directive should block redirects
https://bugs.webkit.org/show_bug.cgi?id=69359
<rdar://problem/24383025>
Reviewed by Brent Fulgham.
Source/WebCore:
Inspired by Blink patch:
<https://src.chromium.org/viewvc/blink?revision=150246&view=revision>
Apply the connect-src directive of the Content Security Policy for the document or worker to the redirect URL
of an XMLHttpRequest and EventSource load so as to conform to section Paths and Redirects of the CSP 2.0 spec.,
<https://w3c.github.io/webappsec-csp/2/#source-list-paths-and-redirects> (29 August 2015).
Additionally, check that each requested script URL passed to WorkerGlobalScope.importScripts() is allowed by
the CSP of the worker before initiating a load for it. If some URL i is blocked by the CSP policy
then we do not try to load URLs j >= i.
Tests: http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports.html
http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html
http/tests/security/contentSecurityPolicy/worker-csp-blocks-xhr-redirect-cross-origin.html
http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-allowed.html
http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked.html
http/tests/security/contentSecurityPolicy/worker-without-csp-importScripts-redirect-cross-origin-allowed.html
http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-redirect.html
http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-importScript-redirect-cross-origin.html
http/tests/security/isolatedWorld/bypass-main-world-csp-worker-importScripts-redirect-cross-origin.html
http/tests/security/isolatedWorld/bypass-worker-csp-for-xhr-redirect-cross-origin.html
http/tests/security/isolatedWorld/bypass-worker-csp-for-xhr.html
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start): Do not enforce a CSP directive as CSP is not applicable to File API.
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::loadResource): Do not enforce a CSP directive as CSP should not interfere
with the Web Inspector.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Modified to take an optional ContentSecurityPolicy
and pass it through to DocumentThreadableLoader::create().
(WebCore::DocumentThreadableLoader::create): Modified to take an optional ContentSecurityPolicy and pass it through
to DocumentThreadableLoader::DocumentThreadableLoader().
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Modified to take an optional ContentSecurityPolicy.
Asserts that the CSP allows the load of the request URL so as to catch when a caller creates a loader for a request
that is not allowed by the CSP. The caller should not create a loader for such a request.
(WebCore::DocumentThreadableLoader::redirectReceived): Check if the CSP allows the redirect URL. If it does not
then notify the client that the redirect check failed.
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
(WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy): Checks that the specified URL is allowed
by the enforced CSP directive.
(WebCore::DocumentThreadableLoader::contentSecurityPolicy): Returns the ContentSecurityPolicy object passed to
DocumentThreadableLoader on instantiation or the ContentSecurityPolicy object of the associated document.
- loader/DocumentThreadableLoader.h: Add overloaded variants of DocumentThreadableLoader::{create, loadResourceSynchronously}()
that take a std::unique_ptr<ContentSecurityPolicy>&&. Remove some unnecessary headers.
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Take the CSP directive to enforce and store it.
(WebCore::ThreadableLoaderOptions::isolatedCopy): Copy the CSP directive to enforce.
- loader/ThreadableLoader.h: Added member field to store the CSP directive to enforce (defaults to enforce the
directive connect-src - the most appropriate directive in most circumstances). As of the time of writing,
only WorkerGlobalScope.importScripts() enforces a different directive: script-src.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Pass the SecurityOrigin and ContentSecurityPolicy associated
with the WorkerGlobalScope to WorkerThreadableLoader::MainThreadBridge::MainThreadBridge().
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Pass a copy of the worker's ContentSecurityPolicy
to the DocumentThreadableLoader.
- loader/WorkerThreadableLoader.h:
- page/EventSource.cpp:
(WebCore::EventSource::connect): Enforce the CSP directive connect-src on redirects unless we are running in an isolated world.
- workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL): Modified to take a boolean whether to bypass the main world Content Security Policy
instead of querying for it directly.
- workers/AbstractWorker.h:
- workers/Worker.cpp:
(WebCore::Worker::create): Added FIXME to enforce child-src directive of the document's CSP to the worker's script URL
on redirect once we fix <https://bugs.webkit.org/show_bug.cgi?id=153562>. For now, do not enforce a CSP policy on redirect
of the worker's script URL.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts): Check that the requested URL is allowed by the CSP of the worker (if applicable).
Enforce the CSP directive script-src on redirects unless we are running in an isolated world.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously): Pass SecurityOrigin and ContentSecurityPolicyEnforcement to WorkerThreadableLoader.
(WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
- workers/WorkerScriptLoader.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Enforce the CSP directive connect-src on redirects unless we are running in
an isolated world.
LayoutTests:
Add more tests, update erroneous expected results, and remove some entries from TestExpectations for tests
that now pass.
- TestExpectations: Remove entries for tests that now pass. The failure of test http/tests/security/contentSecurityPolicy/worker-importscripts-blocked.html
was erroneously attributed to <https://bugs.webkit.org/show_bug.cgi?id=153562>.
- http/tests/security/contentSecurityPolicy/resources/determine-content-security-policy-header.php: Added.
- http/tests/security/contentSecurityPolicy/resources/script-set-value.js: Use global variable self instead of window so as to
make this script work both from a Document and a Web Worker. In a document, self refers to the Window object and in a worker
it refers to the WorkerGlobalScope object.
- http/tests/security/contentSecurityPolicy/resources/worker-importScript-redirect-cross-origin-allowed.php: Added.
- http/tests/security/contentSecurityPolicy/resources/worker-importScript-redirect-cross-origin-blocked.php: Added.
- http/tests/security/contentSecurityPolicy/resources/worker-xhr-allowed.php: Added.
- http/tests/security/contentSecurityPolicy/resources/worker-xhr-redirect-cross-origin-allowed.php: Added.
- http/tests/security/contentSecurityPolicy/resources/worker-xhr-redirect-cross-origin-blocked.php: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-expected.txt: Remove Blink-specific messages so that the test passes.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-block-aborts-all-subsequent-imports.html: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-importScripts-redirect-cross-origin-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/worker-csp-blocks-xhr-redirect-cross-origin-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-csp-blocks-xhr-redirect-cross-origin.html: Added.
- http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-csp-importScripts-redirect-cross-origin-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/worker-importscripts-blocked-expected.txt: Substitute Blink-specific error text with the analogous WebKit error text.
- http/tests/security/contentSecurityPolicy/worker-importscripts-blocked.html: Ditto.
- http/tests/security/contentSecurityPolicy/worker-without-csp-importScripts-redirect-cross-origin-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-without-csp-importScripts-redirect-cross-origin-allowed.html: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-redirect-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-redirect.html: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-importScript-redirect-cross-origin-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-importScript-redirect-cross-origin.html: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-importScripts-redirect-cross-origin-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-importScript-redirect-cross-origin-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-importScripts-redirect-cross-origin-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-importScripts-redirect-cross-origin.html: Added.
- http/tests/security/isolatedWorld/bypass-worker-csp-for-xhr-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-worker-csp-for-xhr-redirect-cross-origin-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-worker-csp-for-xhr-redirect-cross-origin.html: Added.
- http/tests/security/isolatedWorld/bypass-worker-csp-for-xhr.html: Added.
- 5:25 PM Changeset in webkit [196282] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Yosemite build.
- dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
(WebCore::ComposedTreeIterator::traverseNext):
- 5:15 PM Changeset in webkit [196281] by
-
- 5 edits1 add in trunk/Source/WebCore
Implement ComposedTreeIterator in terms of ElementAndTextDescendantIterator
https://bugs.webkit.org/show_bug.cgi?id=154003
Reviewed by Darin Adler.
Currently ComposedTreeIterator implements tree traversal using NodeTraversal. This makes it overly complicated.
It can also return nodes other than Element and Text which should not be part of the composed tree.
This patch adds a new iterator type, ElementAndTextDescendantIterator, similar to the existing ElementDescendantIterator.
ComposedTreeIterator is then implemented using this new iterator.
When entering a shadow tree or a slot the local iterator is pushed along with the context stack and a new local
iterator is initialized for the new context. When leaving a shadow tree the context stack is popped and the previous
local iterator becomes active.
- WebCore.xcodeproj/project.pbxproj:
- dom/ComposedTreeIterator.cpp:
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
(WebCore::ComposedTreeIterator::initializeContextStack):
(WebCore::ComposedTreeIterator::pushContext):
(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::traverseNextLeavingContext):
(WebCore::ComposedTreeIterator::advanceInSlot):
(WebCore::ComposedTreeIterator::traverseSiblingInSlot):
(WebCore::ComposedTreeIterator::initializeShadowStack): Deleted.
(WebCore::ComposedTreeIterator::traverseParentInShadowTree): Deleted.
(WebCore::ComposedTreeIterator::traverseNextSiblingSlot): Deleted.
(WebCore::ComposedTreeIterator::traversePreviousSiblingSlot): Deleted.
- dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::operator*):
(WebCore::ComposedTreeIterator::operator->):
(WebCore::ComposedTreeIterator::operator==):
(WebCore::ComposedTreeIterator::operator!=):
(WebCore::ComposedTreeIterator::operator++):
(WebCore::ComposedTreeIterator::Context::Context):
(WebCore::ComposedTreeIterator::context):
(WebCore::ComposedTreeIterator::current):
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
(WebCore::ComposedTreeIterator::traverseNext):
(WebCore::ComposedTreeIterator::traverseNextSkippingChildren):
(WebCore::ComposedTreeIterator::traverseNextSibling):
(WebCore::ComposedTreeIterator::traversePreviousSibling):
(WebCore::ComposedTreeDescendantAdapter::ComposedTreeDescendantAdapter):
(WebCore::ComposedTreeDescendantAdapter::begin):
(WebCore::ComposedTreeDescendantAdapter::end):
(WebCore::ComposedTreeDescendantAdapter::at):
(WebCore::ComposedTreeChildAdapter::Iterator::Iterator):
(WebCore::ComposedTreeChildAdapter::ComposedTreeChildAdapter):
(WebCore::ComposedTreeChildAdapter::begin):
(WebCore::ComposedTreeChildAdapter::end):
(WebCore::ComposedTreeChildAdapter::at):
(WebCore::ComposedTreeIterator::ShadowContext::ShadowContext): Deleted.
(WebCore::ComposedTreeIterator::traverseParent): Deleted.
- dom/ElementAndTextDescendantIterator.h: Added.
New iterator type that traverses Element and Text nodes (that is renderable nodes only).
It also tracks depth for future use.
- 5:06 PM Changeset in webkit [196280] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3::foldPathConstants() needs to execute its insertion set
https://bugs.webkit.org/show_bug.cgi?id=154020
Reviewed by Saam Barati.
- b3/B3FoldPathConstants.cpp:
- b3/testb3.cpp:
(JSC::B3::testFoldPathEqual): Added this. It used to crash in validation.
(JSC::B3::run):
- 3:29 PM Changeset in webkit [196279] by
-
- 1 copy in tags/Safari-601.3.9.1.3
New tag.
- 3:18 PM Changeset in webkit [196278] by
-
- 20 edits2 copies in branches/safari-601-branch
Merged r187245. rdar://problem/19861992
- 3:15 PM Changeset in webkit [196277] by
-
- 20 edits2 copies in branches/safari-601.3.9.1-branch
Merged r187245. rdar://problem/19861992
- 3:14 PM Changeset in webkit [196276] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Introduce @isObject bytecode intrinsic and use it instead of JS implemented one
https://bugs.webkit.org/show_bug.cgi?id=153976
Reviewed by Darin Adler.
Use bytecode op_is_object directly.
- builtins/GlobalObject.js:
(isObject): Deleted.
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_toString):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isObject):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Deleted.
- 3:13 PM Changeset in webkit [196275] by
-
- 22 edits in trunk/Source/WebInspectorUI
Web Inspector: Extract a few common unicode characters into global variables
https://bugs.webkit.org/show_bug.cgi?id=154008
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-08
Reviewed by Timothy Hatcher.
- UserInterface/Base/Utilities.js:
Create global variables for
emDashandellipsisto use all over the tools.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._formatParameterAsTable): Deleted.
- UserInterface/Views/DefaultDashboardView.js:
(WebInspector.DefaultDashboardView.prototype._updateDisplay):
- UserInterface/Views/HierarchicalPathComponent.js:
(WebInspector.HierarchicalPathComponent.prototype._updateElementTitleAndText):
(WebInspector.HierarchicalPathComponent.prototype._updateSelectElement.createOption):
(WebInspector.HierarchicalPathComponent.prototype._updateSelectElement):
- UserInterface/Views/HierarchicalPathNavigationItem.js:
(WebInspector.HierarchicalPathNavigationItem.prototype.updateLayout):
- UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype.set layer):
- UserInterface/Views/LayoutTimelineDataGridNode.js:
(WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
(WebInspector.LayoutTimelineDataGridNode):
- UserInterface/Views/MemoryCategoryView.js:
(WebInspector.MemoryCategoryView.prototype._updateDetails): Deleted.
(WebInspector.MemoryCategoryView): Deleted.
- UserInterface/Views/MemoryTimelineView.js:
(WebInspector.MemoryTimelineView.prototype._clearUsageLegend):
(WebInspector.MemoryTimelineView.prototype._updateUsageLegend):
(WebInspector.MemoryTimelineView.prototype._clearMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._updateMaxComparisonLegend):
- UserInterface/Views/MultipleScopeBarItem.js:
(WebInspector.MultipleScopeBarItem.set scopeBarItems.createOption):
(WebInspector.MultipleScopeBarItem.prototype.set scopeBarItems):
- UserInterface/Views/ObjectPreviewView.js:
(WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
- UserInterface/Views/ProfileNodeDataGridNode.js:
(WebInspector.ProfileNodeDataGridNode.prototype.createCellContent):
(WebInspector.ProfileNodeDataGridNode):
- UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
(WebInspector.RenderingFrameTimelineDataGridNode.prototype.createCellContent):
(WebInspector.RenderingFrameTimelineDataGridNode):
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse): Deleted.
(WebInspector.ResourceDetailsSidebarPanel.prototype._valueForSize): Deleted.
- UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ScriptTimelineDataGridNode):
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
- UserInterface/Views/TimelineDataGridNode.js:
(WebInspector.TimelineDataGridNode.prototype.createCellContent):
- UserInterface/Views/TypeTreeElement.js:
(WebInspector.TypeTreeElement.prototype.onpopulate):
- UserInterface/Views/TypeTreeView.js:
(WebInspector.TypeTreeView.prototype._populate):
(WebInspector.TypeTreeView):
- 3:12 PM Changeset in webkit [196274] by
-
- 6 edits in trunk
{Map,Set}.prototype.forEach should be visible as own properties
https://bugs.webkit.org/show_bug.cgi?id=153974
Reviewed by Darin Adler.
Source/JavaScriptCore:
Now, Map and Set uses builtin tables. We should inlude it in class info.
- runtime/MapPrototype.cpp:
- runtime/SetPrototype.cpp:
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- 3:00 PM Changeset in webkit [196273] by
-
- 2 edits in trunk/Source/JavaScriptCore
Baseline JIT should not require its input to be constant-propagated
https://bugs.webkit.org/show_bug.cgi?id=154011
rdar://problem/24290933
Reviewed by Mark Lam.
- jit/JITArithmetic.cpp:
(JSC::JIT::emitBitBinaryOpFastPath):
(JSC::JIT::emitRightShiftFastPath):
(JSC::JIT::emit_op_add):
(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mul):
- 2:31 PM Changeset in webkit [196272] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeCache should give up on evals if there are variables under TDZ
https://bugs.webkit.org/show_bug.cgi?id=154002
rdar://problem/24300998
Reviewed by Mark Lam.
Disable the code cache optimization because our approach to TDZ for scoped variables - using
a separate check_tdz opcode when logically it's the get_from_scope's job to do it - makes
caching code impossible if there are any variables in TDZ.
We should do the right thing in the future, and fold the TDZ check into the get_from_scope.
This is better not only because it will restore caching, but because our bytecode for heap
accesses is usually at the highest practically doable level of abstraction, so that ICs,
compilers and caches can see the intended meaning of the bytecode more easily.
This doesn't appear to slow anything down, but that's just because we don't have enough ES6
benchmarks. I've filed: https://bugs.webkit.org/show_bug.cgi?id=154010
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
- 2:07 PM Changeset in webkit [196271] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: ⇧⌘→ when editing text in the Elements tree shouldn't switch inspector tab
https://bugs.webkit.org/show_bug.cgi?id=154006
<rdar://problem/22892489>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-08
Reviewed by Timothy Hatcher.
- UserInterface/Views/EditingSupport.js:
(WebInspector.isEventTargetAnEditableField):
Check the WebInspector's custom editing state.
- 1:50 PM Changeset in webkit [196270] by
-
- 4 edits2 adds in trunk
Web Inspector: copy({x:1}) should copy "{x:1}", not "[object Object]"
https://bugs.webkit.org/show_bug.cgi?id=148605
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-08
Reviewed by Brian Burg.
Source/WebCore:
Test: inspector/console/command-line-api-copy.html
- inspector/CommandLineAPIModuleSource.js:
(CommandLineAPIImpl.prototype.copy):
Support copying different types. This is meant to be more
convenient then just JSON.stringify, so it handles types
like Node, Symbol, RegExp, and Function a bit better.
LayoutTests:
- inspector/console/command-line-api-copy-expected.txt: Added.
- inspector/console/command-line-api-copy.html: Added.
- http/tests/inspector/console/cross-domain-inspected-node-access-expected.txt:
- 1:47 PM Changeset in webkit [196269] by
-
- 2 edits in trunk/LayoutTests
Mark fast/text/crash-complex-text-surrogate.html as flaky on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=154005
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 12:54 PM Changeset in webkit [196268] by
-
- 19 edits2 adds in trunk
REGRESSION(r181345): SVG polyline and polygon leak page
https://bugs.webkit.org/show_bug.cgi?id=152759
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-02-08
Reviewed by Darin Adler.
Source/WebCore:
The leak happens because of cyclic reference between SVGListPropertyTearOff
and SVGAnimatedListPropertyTearOff which is derived from SVGAnimatedProperty.
There is also cyclic reference between SVGAnimatedProperty and SVGElement
and this causes the whole document to be leaked. So if the JS requests, for
example, an instance of SVGPolylineElement.points, the whole document will be
leaked.
The fix depends on having the cyclic reference as is since the owning and the
owned classes have to live together if any of them is referenced. But the owning
class caches a raw 'ref-counted' pointer of the owned class. If it is requested
for an instance of the owned class it returned a RefPtr<> of it. Once the owned
class is not used, it can delete itself. The only thing needed here is to notify
the owner class of the deletion so it cleans its caches and be able to create a
new pointer if it is requested for an instance of the owned class later.
Revert the change of r181345 in SVGAnimatedProperty::lookupOrCreateWrapper()
to break the cyclic reference between SVGElement and SVGAnimatedProperty.
Also apply the same approach in SVGAnimatedListPropertyTearOff::baseVal() and
animVal() to break cyclic reference between SVGListPropertyTearOff and
SVGAnimatedListPropertyTearOff.
Test: svg/animations/smil-leak-list-property-instances.svg
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): The SVG non-string list tear-off properties became of
type RefPtr<>. So we need to use get() with the casting expressions.
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::orientType):
Use 'auto' type for the return of SVGAnimatedProperty::lookupWrapper().
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::pathByteStream):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
Since SVGAnimatedProperty::lookupWrappe() returns a RefPtr<> we need to
use get() for the casting expressions.
(WebCore::SVGPathElement::pathSegList):
(WebCore::SVGPathElement::normalizedPathSegList):
(WebCore::SVGPathElement::animatedPathSegList):
(WebCore::SVGPathElement::animatedNormalizedPathSegList):
- svg/SVGPathElement.h:
Change the return value from raw pointer to RefPtr<>.
- svg/SVGPathSegWithContext.h:
(WebCore::SVGPathSegWithContext::animatedProperty):
Change the return type to be RefPtr<> to preserve the value from being deleted.
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::parseAttribute):
Since SVGAnimatedProperty::lookupWrapper() returns a RefPtr<> we need to
use get() for the casting expressions.
(WebCore::SVGPolyElement::points):
(WebCore::SVGPolyElement::animatedPoints):
- svg/SVGPolyElement.h:
Change the return value from raw pointer to RefPtr<>.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::setTransformString):
Since SVGAnimatedProperty::lookupWrapper() returns a RefPtr<> we need to
use get() for the casting expressions.
(WebCore::SVGViewSpec::transform):
- svg/SVGViewSpec.h:
Change the return value from raw pointer to RefPtr<>.
- svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
Change the return value from raw pointer to RefPtr<> and change the cached
value from RefPtr<> to raw pointer. If the property is null, it will be
created, its raw pointer will be cached and the only ref-counted RefPtr<>
will be returned. This will guarantee, the RefPtr<> will be deleted once
it is not used anymore.
(WebCore::SVGAnimatedListPropertyTearOff::propertyWillBeDeleted):
Clean the raw pointer caches m_baseVal and m_animVal upon deleting the
actual pointer. This function will be called from the destructor of
SVGListPropertyTearOff.
(WebCore::SVGAnimatedListPropertyTearOff::findItem):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
We have to ensure the baseVal() is created before using it.
(WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers):
(WebCore::SVGAnimatedListPropertyTearOff::currentAnimatedValue):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
(WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
(WebCore::SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded):
(WebCore::SVGAnimatedListPropertyTearOff::animValWillChange):
(WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):
For animation, a separate RefPtr<> 'm_animatingAnimVal' will be assigned
to the animVal(). This will prevent deleting m_animVal while animation.
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
Same as what is done in SVGAnimatedListPropertyTearOff.
(WebCore::SVGAnimatedPathSegListPropertyTearOff::findItem):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
Same as what is done in SVGAnimatedListPropertyTearOff.
- svg/properties/SVGAnimatedProperty.h:
(WebCore::SVGAnimatedProperty::lookupOrCreateWrapper):
Change the return value from raw reference to Ref<> and change the
cached value from Ref<> to raw pointer. This reverts the change of
r181345 in this function.
(WebCore::SVGAnimatedProperty::lookupWrapper):
Change the return value from raw pointer to RefPtr<>.
- svg/properties/SVGAnimatedPropertyMacros.h:
Use 'auto' type for the return of SVGAnimatedProperty::lookupWrapper().
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
(WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedTransformListPropertyTearOff::animVal):
Same as what is done in SVGAnimatedListPropertyTearOff.
- svg/properties/SVGListPropertyTearOff.h:
(WebCore::SVGListPropertyTearOff::~SVGListPropertyTearOff):
Call the SVGAnimatedListPropertyTearOff::propertyWillBeDeleted() to clean
its raw pointers when the RefPtr<> deletes itself.
LayoutTests:
- TestExpectations: Remove flaky tests from test expectation.
- svg/animations/smil-leak-list-property-instances-expected.txt: Added.
- svg/animations/smil-leak-list-property-instances.svg: Added.
Ensure if SVGPolylineElement.points is requested from JS, the document will
not leak.
- 12:53 PM Changeset in webkit [196267] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash when trying to chain to the old -[NSView setNeedsDisplayInRect:]
https://bugs.webkit.org/show_bug.cgi?id=154001
rdar://problem/24519975
Reviewed by Dan Bernstein.
If our replaced -[NSView setNeedsDisplayInRect:] is called before the old IMP has been initialized,
we can end up trying to call a null pointer.
Fix this by using method_exchangeImplementations instead of method_setImplementation, since the former is done
atomically.
- WebView/WebHTMLView.mm:
(-[NSView _web_setNeedsDisplayInRect:]):
(+[WebHTMLViewPrivate initialize]):
(setNeedsDisplayInRect): Deleted.
- 11:49 AM Changeset in webkit [196266] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Long values for comma separated CSS properties overflow the Visual sidebar area
https://bugs.webkit.org/show_bug.cgi?id=153890
<rdar://problem/24510216>
Patch by Devin Rousso <Devin Rousso> on 2016-02-08
Reviewed by Timothy Hatcher.
For especially long values in comma-separated CSS properties (such as
background-image), the text will not be clipped as expected due to the
way in which the width is calculated for the element (the value, inside
the title element, is the only child with a specified width other than
100%). This overflowing causes the width of the section containing that
property to expand, pushing content outside of the inspector window. To
remedy this, a specified width is set on the relevant properties based
on the width of the sidebar to ensure proper text clipping.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container): Deleted.
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list): Deleted.
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item): Deleted.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.set specifiedWidth):
Calculates the necessary subtractions from the given width value based on
the margins and size of sibling elements.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype._updateProperties):
(WebInspector.VisualStyleDetailsPanel.prototype._populateFontSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateBackgroundStyleSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection):
Added another list to each group which, if set, will pass the current
sidebar width to all contained property editors.
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype.update):
Somewhat unrelated (r196146), but added another check to ensure that the
CSS property exists before checking to see if it has an invalid value.
- 11:42 AM Changeset in webkit [196265] by
-
- 5 edits in trunk/Source
[GTK] WebKitWebView should send crossing events to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=153740
Reviewed by Michael Catanzaro.
Source/WebCore:
Update the target element under the mouse also when only updating
scrollbars, so that if the mouse enters the page when the window
is not active, the scroll animator is notified that the mouse
entered the scrollable area.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent): Call
updateMouseEventTargetNode() before early returning in case of
only updating scrollbars.
Source/WebKit2:
We don't currently handle crossing events in the web view
(enter/leave). That's why if you hover a scrollbar and leave the
window, the scrollbar is still rendered as hovered.
- Shared/gtk/WebEventFactory.cpp:
(WebKit::buttonForEvent): Handle the case of GDK_ENTER_NOTIFY and
GDK_LEAVE_NOTIFY events.
(WebKit::WebEventFactory::createWebMouseEvent): Ditto.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Add GDK_ENTER_NOTIFY_MASK and
GDK_LEAVE_NOTIFY_MASK flags to the web view event mask.
(webkitWebViewBaseCrossingNotifyEvent): Handle enter/leave notify
events by generating a mouse move event, ensuring the double to
int conversion will not cause any problem.
(webkit_web_view_base_class_init): Add an implementation for
enter_notify_event and leave_notify_event.
- 11:41 AM Changeset in webkit [196264] by
-
- 2 edits in trunk/Source/WebKit2
Infinite loop when processing mouse events synchronously
https://bugs.webkit.org/show_bug.cgi?id=153995
Reviewed by Darin Adler.
This happened with WTR in the GTK+ port after landing patch in bug
#153740. The thing is that WTR forces events handling IPC messages
to be synchronous. When a drag and drop operation is in progress,
the web process ignores mouse move events and replies with
DidReceiveEvent signal. The DidReceiveEvent message handler in
WebPageProxy checks if we have a m_nextMouseMoveEvent and handles
it, but when all this happens synchronously the
m_nextMouseMoveEvent is the current one because we haven't
returned yet from handleMouseEvent(). We need to invalidate the
m_nextMouseMoveEvent before calling handleMouseEvent().
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
- 11:33 AM Changeset in webkit [196263] by
-
- 3 edits in trunk/Source/WebCore
PiP and external playback are mutually exclusive.
https://bugs.webkit.org/show_bug.cgi?id=153988
rdar://problem/24108661
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-02-08
Reviewed by Eric Carlson.
Adding isPlayingOnSecondScreen to isPlayingOnExternalScreen allows AVKit to disable PiP
when appropriate. Testing video fullscreen mode in updateDisableExternalPlayback allows us to
turn-off external playback when entering picture-in-picture.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateDisableExternalPlayback):
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController isPlayingOnExternalScreen]):
(+[WebAVPlayerController keyPathsForValuesAffectingPlayingOnExternalScreen]):
- 11:31 AM Changeset in webkit [196262] by
-
- 4 edits in trunk/LayoutTests
IndexedDB: No test covers cursor.delete() setting the source of the request to the cursor.
https://bugs.webkit.org/show_bug.cgi?id=153992
Reviewed by Jer Noble.
- storage/indexeddb/cursor-delete-expected.txt:
- storage/indexeddb/cursor-delete-private-expected.txt:
- storage/indexeddb/resources/cursor-delete.js:
- 11:29 AM Changeset in webkit [196261] by
-
- 10 edits in trunk
[ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error
https://bugs.webkit.org/show_bug.cgi?id=150893
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-02-08
Reviewed by Saam Barati.
Source/JavaScriptCore:
'super' and 'super()' inside of the arrow function should lead to syntax error if they are used
out of the class context or they wrapped by ordinary function. Now JSC returns ReferenceError but
should return SyntaxError according to the following specs:
http://www.ecma-international.org/ecma-262/6.0/#sec-function-definitions-static-semantics-early-errors
and http://www.ecma-international.org/ecma-262/6.0/#sec-arrow-function-definitions-runtime-semantics-evaluation
Curren patch implemented only one case when super/super() are used inside of the arrow function
Case when super/super() are used within the eval:
class A {}
class B extends A {
costructor() { eval("super()");}
}
is not part of this patch and will be implemented in this issue https://bugs.webkit.org/show_bug.cgi?id=153864.
The same for case when eval with super/super() is invoked in arrow function will be
implemented in issue https://bugs.webkit.org/show_bug.cgi?id=153977.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::setExpectedSuperBinding):
(JSC::Scope::expectedSuperBinding):
(JSC::Scope::setConstructorKind):
(JSC::Scope::constructorKind):
(JSC::Parser::closestParentNonArrowFunctionNonLexicalScope):
- tests/stress/arrowfunction-lexical-bind-supercall-4.js:
- tests/stress/arrowfunction-lexical-bind-superproperty.js:
LayoutTests:
Adding tests for using of the 'super' inside of the arrow function
- js/arrowfunction-superproperty-expected.txt:
- js/arrowfunction-syntax-errors-expected.txt:
- js/script-tests/arrowfunction-superproperty.js:
- js/script-tests/arrowfunction-syntax-errors.js:
- 11:27 AM Changeset in webkit [196260] by
-
- 2 edits in trunk/Source/WebKit2
Remove weak from WKAirPlayRoutePicker.mm to fix build warning.
https://bugs.webkit.org/show_bug.cgi?id=153985
rdar://problem/24485348
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-02-08
Reviewed by Darin Adler.
Remove weak since it is only available when using ARC.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
- 10:58 AM Changeset in webkit [196259] by
-
- 4 edits in trunk/Source/WTF
Make sure that locking code that relies on module boundaries for compiler fences uses NEVER_INLINE
https://bugs.webkit.org/show_bug.cgi?id=153972
Reviewed by Andreas Kling.
When this code was written, we assumed that module boundaries were compiler fences. That might
not be the case if we ever do LTO.
- wtf/Lock.cpp:
(WTF::LockBase::lockSlow):
(WTF::LockBase::unlockSlow):
- wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionally):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::unparkAll):
(WTF::ParkingLot::forEach):
- wtf/WordLock.cpp:
(WTF::WordLock::lockSlow):
(WTF::WordLock::unlockSlow):
- 10:52 AM Changeset in webkit [196258] by
-
- 2 edits in trunk/Source/JavaScriptCore
Parser should detect error before calls to parseAssignmentExpression()
https://bugs.webkit.org/show_bug.cgi?id=153975
rdar://problem/24291231
Reviewed by Saam Barati.
Fixes a very hard-to-create situation that an internal test picked up.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::parseAssignmentExpression):
- 10:43 AM Changeset in webkit [196257] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix crash when creating webview with g_object_new
https://bugs.webkit.org/show_bug.cgi?id=153989
Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2016-02-08
Reviewed by Carlos Garcia Campos.
g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL) crashes webkit
as _WebKitWebViewBasePrivate constructor requires a mainloop, but
webkit is only initialized when a context is created (which
doesn't happen with a direct call to g_object_new).
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- 10:28 AM Changeset in webkit [196256] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r196253.
https://bugs.webkit.org/show_bug.cgi?id=153990
Caused several crashes in GTK+ bots (Requested by KaL on
#webkit).
Reverted changeset:
"[GTK] WebKitWebView should send crossing events to the
WebProcess"
https://bugs.webkit.org/show_bug.cgi?id=153740
http://trac.webkit.org/changeset/196253
- 10:23 AM Changeset in webkit [196255] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: WebInspector.Setting should have a "reset" method
https://bugs.webkit.org/show_bug.cgi?id=153971
<rdar://problem/24544101>
Reviewed by Brian Burg.
Currently UI needing to restore a setting to its default must retain a copy
of the default value. This should be a basic operation of WebInspector.Setting.
- UserInterface/Base/Setting.js:
(WebInspector.Setting):
(WebInspector.Setting.prototype.reset):
Sets value to a copy of the default.
- 9:06 AM Changeset in webkit [196254] by
-
- 2 edits in trunk/Source/WebCore
WebAVPlayerController should implement currentTimeWithinEndTimes.
https://bugs.webkit.org/show_bug.cgi?id=153983
rdar://problem/22864621
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-02-08
Reviewed by Eric Carlson.
Implement currentTimeWithinEndTimes in terms of seekToTime and AVTiming. This is a trivial
implementation becuase AVPlayer start and end times aren't used.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController currentTimeWithinEndTimes]):
(-[WebAVPlayerController setCurrentTimeWithinEndTimes:]):
(+[WebAVPlayerController keyPathsForValuesAffectingCurrentTimeWithinEndTimes]):
- 8:59 AM Changeset in webkit [196253] by
-
- 5 edits in trunk/Source
[GTK] WebKitWebView should send crossing events to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=153740
Reviewed by Michael Catanzaro.
Source/WebCore:
Update the target element under the mouse also when only updating
scrollbars, so that if the mouse enters the page when the window
is not active, the scroll animator is notified that the mouse
entered the scrollable area.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent): Call
updateMouseEventTargetNode() before early returning in case of
only updating scrollbars.
Source/WebKit2:
We don't currently handle crossing events in the web view
(enter/leave). That's why if you hover a scrollbar and leave the
window, the scrollbar is still rendered as hovered.
- Shared/gtk/WebEventFactory.cpp:
(WebKit::buttonForEvent): Handle the case of GDK_ENTER_NOTIFY and
GDK_LEAVE_NOTIFY events.
(WebKit::WebEventFactory::createWebMouseEvent): Ditto.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize): Add GDK_ENTER_NOTIFY_MASK and
GDK_LEAVE_NOTIFY_MASK flags to the web view event mask.
(webkitWebViewBaseCrossingNotifyEvent): Handle enter/leave notify
events by generating a mouse move event, ensuring the double to
int conversion will not cause any problem.
(webkit_web_view_base_class_init): Add an implementation for
enter_notify_event and leave_notify_event.
- 8:46 AM Changeset in webkit [196252] by
-
- 3 edits in trunk/Source/WebCore
WebVideoFullscreenInterface should handle video resizing.
https://bugs.webkit.org/show_bug.cgi?id=153982
rdar://problem/22031249
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-02-08
Reviewed by Eric Carlson.
Video fullscreen can be initiated before video dimension are available.
Protect against an initial width or height of zero and observe resize events
to update once video dimensions become available or change.
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateForEventName):
(WebVideoFullscreenModelVideoElement::observedEventNames):
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer layoutSublayers]):
(-[WebAVPlayerLayer videoRect]):
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions):
- 8:25 AM Changeset in webkit [196251] by
-
- 3 edits in trunk/Source/JavaScriptCore
Visiting a WeakBlock should report bytes visited, since we reported them allocated.
<https://webkit.org/b/153978>
Reviewed by Darin Adler.
When creating a WeakBlock, we tell Heap that we've allocated 1 KB (WeakBlock::blockSize)
of memory. Consequently, when visiting a WeakBlock, we should also report 1 KB of memory
visited. Otherwise Heap will think that those 1 KB already went away.
This was causing us to underestimate heap size, which affects collection scheduling.
- heap/SlotVisitor.h:
(JSC::SlotVisitor::reportMemoryVisited):
- heap/WeakBlock.cpp:
(JSC::WeakBlock::visit):
- 5:43 AM Changeset in webkit [196250] by
-
- 2 edits in trunk/LayoutTests
Timeouts in tests because of non implemented UIScriptController::singleTapAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=153833
Unreviewed.
Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-08
- platform/gtk/TestExpectations:
- 5:41 AM Changeset in webkit [196249] by
-
- 2 edits in trunk/Source/WebCore
Indent inline box test fails due to assertion in VisibleSelection::selectionFromContentsOfNode()
https://bugs.webkit.org/show_bug.cgi?id=153824
Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-08
Reviewed by Michael Catanzaro.
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
Feb 7, 2016:
- 7:22 PM Changeset in webkit [196248] by
-
- 2 edits in trunk/Source/WebCore
Remove unused enum ScrollbarOverlayState.
Rubber-stamped by Dan Bernstein.
- platform/ScrollTypes.h:
- 7:20 PM Changeset in webkit [196247] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary respondsToSelector checks for methods that exist on all supported platforms
https://bugs.webkit.org/show_bug.cgi?id=153970
Reviewed by Dan Bernstein.
-[NSScrollerImp mouseEnteredScroller], -[NSScrollerImp expansionTransitionProgress],
-[NSScrollerImpPair contentAreaScrolledInDirection:], and -[NSScrollerImp setExpanded:]
are now available on all supported OS's. No need to check for them.
- platform/mac/ScrollAnimatorMac.mm:
(macScrollbarTheme):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
(supportsUIStateTransitionProgress): Deleted.
(supportsExpansionTransitionProgress): Deleted.
(supportsContentAreaScrolledInDirection): Deleted.
- platform/mac/ScrollbarThemeMac.mm:
(+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
(+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
- 7:01 PM Changeset in webkit [196246] by
-
- 8 edits1 add in trunk/Source/WebCore
Use modern SPI header idiom for NSScrollerImp and NSScrollerImpPair
https://bugs.webkit.org/show_bug.cgi?id=153969
Reviewed by Dan Bernstein.
- WebCore.xcodeproj/project.pbxproj:
Add new file NSScrollerImpSPI.h
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
Use new include of NSScrollerImpSPI.h.
- platform/ScrollbarThemeComposite.h:
Define ScrollbarPainter more precisely as NSScrollerImp * now that the type is available to us.
- platform/mac/NSScrollerImpDetails.h:
Remove NSObject category based SPI usage with the modern one NSScrollerImpSPI.h
- platform/mac/NSScrollerImpDetails.mm:
(WebCore::recommendedScrollerStyle):
Simplify recommendedScrollerStyle() now that all OS's we ship on have +[NSScroller preferredScrollerStyle].
- platform/mac/ScrollAnimatorMac.mm:
(supportsUIStateTransitionProgress):
(supportsExpansionTransitionProgress):
(supportsContentAreaScrolledInDirection):
Stop using NSClassFromString now that we can reference the classes explicitly.
(-[WebScrollbarPainterControllerDelegate invalidate]):
(-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]):
(-[WebScrollbarPainterDelegate convertRectToLayer:]):
(-[WebScrollbarPainterDelegate shouldUseLayerPerPartForScrollerImp:]):
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
Add proper conforming to protocols and replace ids with proper types.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::supportsExpandedScrollbars):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
Stop using NSClassFromString now that we can reference the classes explicitly.
- platform/spi/mac/NSScrollerImpSPI.h: Added.
- 5:34 PM Changeset in webkit [196245] by
-
- 6 edits in trunk
[GTK][EFL] Enable SamplingProfiler
https://bugs.webkit.org/show_bug.cgi?id=153638
Reviewed by Michael Catanzaro.
.:
Enable SamplingProfiler in GTK and EFL.
And added option to CMake to switch this from the build command.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WTF:
- wtf/Platform.h:
- 4:33 PM Changeset in webkit [196244] by
-
- 145 edits2 adds in trunk
Outline does not clip when ancestor has overflow: hidden and requires layer.
https://bugs.webkit.org/show_bug.cgi?id=153901
Now that outline is part of visual overflow, we no longer need the special outline cliprect.
PaintPhaseChildOutlines drawing will switch to foreground cliprect. It ensures proper overflow clipping
at parent level. PaintPhaseSelfOutline drawing will start using the visual overflow inflated background cliprect.
With this change, outline will be using the same cliprects as the other visual overflow properties (box-shadow etc).
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/outline-with-overflow-hidden-ancestor.html
- rendering/LayerFragment.h:
(WebCore::LayerFragment::setRects):
(WebCore::LayerFragment::moveBy): Deleted.
(WebCore::LayerFragment::intersect): Deleted.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::paintForegroundForFragments): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeLayers):
LayoutTests:
- compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
- compositing/masks/mask-of-clipped-layer-expected.txt:
- css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
- css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
- css3/blending/blend-mode-isolation-turn-off-self-painting-layer2-expected.txt:
- css3/blending/blend-mode-isolation-turn-on-self-painting-layer-expected.txt:
- fast/block/positioning/negative-rel-position-expected.txt:
- fast/dynamic/staticY-expected.txt:
- fast/inline/absolute-positioned-block-in-centred-block-expected.txt:
- fast/multicol/flipped-blocks-border-after-expected.txt:
- fast/multicol/pagination-h-horizontal-bt-expected.txt:
- fast/multicol/pagination-h-horizontal-tb-expected.txt:
- fast/multicol/pagination-h-vertical-rl-expected.txt:
- fast/multicol/pagination-v-horizontal-bt-expected.txt:
- fast/multicol/pagination-v-vertical-lr-expected.txt:
- fast/multicol/pagination-v-vertical-rl-expected.txt:
- fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt:
- fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
- fast/multicol/progression-reverse-expected.txt:
- fast/multicol/vertical-rl/rules-with-border-before-expected.txt:
- fast/overflow/overflow-update-transform-expected.txt:
- fast/overflow/position-relative-expected.txt:
- fast/repaint/focus-ring-expected.txt:
- fast/repaint/focus-ring-repaint.html:
- fast/repaint/outline-with-overflow-hidden-ancestor-expected.html: Added.
- fast/repaint/outline-with-overflow-hidden-ancestor.html: Added.
- fast/table/overflow-table-collapsed-borders-cell-painting-expected.txt:
- fast/table/overflow-table-collapsed-borders-cell-painting-table-self-painting-layer-expected.txt:
- fast/table/overflow-table-collapsed-borders-section-layer-painting-expected.txt:
- fast/table/overflow-table-collapsed-borders-section-layer-table-self-painting-layer-expected.txt:
- fast/table/overflow-table-collapsed-borders-section-self-painting-layer-painting-expected.txt:
- fast/table/overflow-table-collapsed-borders-section-self-painting-layer-table-self-painting-layer-expected.txt:
- platform/mac/compositing/geometry/clipping-foreground-expected.txt:
- platform/mac/compositing/geometry/root-layer-update-expected.txt:
- platform/mac/compositing/overflow/ancestor-overflow-expected.txt:
- platform/mac/compositing/overflow/nested-scrolling-expected.txt:
- platform/mac/compositing/overflow/overflow-scroll-expected.txt:
- platform/mac/compositing/overflow/parent-overflow-expected.txt:
- platform/mac/compositing/overflow/scrollbar-painting-expected.txt:
- platform/mac/compositing/reflections/nested-reflection-on-overflow-expected.txt:
- platform/mac/compositing/sibling-positioning-expected.txt:
- platform/mac/css3/blending/blend-mode-overflow-expected.txt:
- platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
- platform/mac/fast/block/positioning/auto/vertical-rl/007-expected.txt:
- platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
- platform/mac/fast/borders/border-antialiasing-expected.txt:
- platform/mac/fast/clip/001-expected.txt:
- platform/mac/fast/clip/013-expected.txt:
- platform/mac/fast/clip/014-expected.txt:
- platform/mac/fast/clip/016-expected.txt:
- platform/mac/fast/clip/outline-overflowClip-expected.txt:
- platform/mac/fast/css/clip-zooming-expected.txt:
- platform/mac/fast/forms/validation-message-appearance-expected.txt:
- platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
- platform/mac/fast/line-grid/line-grid-inside-columns-expected.txt:
- platform/mac/fast/line-grid/line-grid-into-columns-expected.txt:
- platform/mac/fast/lists/scrolled-marker-paint-expected.txt:
- platform/mac/fast/multicol/client-rects-expected.txt:
- platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/column-rules-expected.txt:
- platform/mac/fast/multicol/column-rules-stacking-expected.txt:
- platform/mac/fast/multicol/columns-shorthand-parsing-expected.txt:
- platform/mac/fast/multicol/float-paginate-complex-expected.txt:
- platform/mac/fast/multicol/float-paginate-empty-lines-expected.txt:
- platform/mac/fast/multicol/float-paginate-expected.txt:
- platform/mac/fast/multicol/layers-in-multicol-expected.txt:
- platform/mac/fast/multicol/layers-split-across-columns-expected.txt:
- platform/mac/fast/multicol/max-height-columns-block-expected.txt:
- platform/mac/fast/multicol/nested-columns-expected.txt:
- platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-expected.txt:
- platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt:
- platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
- platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.txt:
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.txt:
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.txt:
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.txt:
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.txt:
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.txt:
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.txt:
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.txt:
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.txt:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.txt:
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.txt:
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.txt:
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.txt:
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.txt:
- platform/mac/fast/multicol/positive-leading-expected.txt:
- platform/mac/fast/multicol/scrolling-column-rules-expected.txt:
- platform/mac/fast/multicol/scrolling-overflow-expected.txt:
- platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
- platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
- platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
- platform/mac/fast/multicol/table-vertical-align-expected.txt:
- platform/mac/fast/multicol/tall-image-behavior-expected.txt:
- platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/vertical-lr/column-rules-expected.txt:
- platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
- platform/mac/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
- platform/mac/fast/multicol/vertical-lr/float-paginate-expected.txt:
- platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/mac/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
- platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
- platform/mac/fast/multicol/vertical-rl/float-paginate-expected.txt:
- platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
- platform/mac/fast/overflow/float-in-relpositioned-expected.txt:
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-expected.txt:
- platform/mac/fast/overflow/paged-x-div-expected.txt:
- platform/mac/fast/overflow/paged-x-div-with-column-gap-expected.txt:
- platform/mac/fast/overflow/paged-x-on-root-expected.txt:
- platform/mac/fast/overflow/paged-x-with-column-gap-expected.txt:
- platform/mac/fast/overflow/paged-y-div-expected.txt:
- platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/mac/fast/regions/repaint/region-painting-via-layout-expected.txt:
- platform/mac/fast/repaint/box-shadow-h-expected.txt:
- platform/mac/fast/repaint/box-shadow-v-expected.txt:
- platform/mac/fast/repaint/layer-outline-expected.txt:
- platform/mac/fast/repaint/layer-outline-horizontal-expected.txt:
- platform/mac/fast/table/edge-offsets-expected.txt:
- platform/mac/fast/transforms/overflow-with-transform-expected.txt:
- platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt:
- platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
- platform/mac/scrollbars/scrollbars-on-positioned-content-expected.txt:
- platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
- platform/mac/svg/custom/image-rescale-clip-expected.txt:
- svg/overflow/overflow-on-foreignObject-expected.txt:
- 3:16 PM Changeset in webkit [196243] by
-
- 3 edits3 adds in trunk
Source/JavaScriptCore:
Follow up patch to: [ES6] bound functions .name property should be "bound " + the target function's name
https://bugs.webkit.org/show_bug.cgi?id=153796
Reviewed by Darin Adler.
This follow-up patch addresses some comments/suggestions by
Ryosuke, Darin, and Joe. It simplifies JSBoundFunction::toStringName
and adds some tests for bound names.
- runtime/JSBoundFunction.cpp:
(JSC::hasInstanceBoundFunction):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::toStringName):
LayoutTests:
[ES6] bound functions .name property should be "bound " + the target function's name
https://bugs.webkit.org/show_bug.cgi?id=153796
Reviewed by Darin Adler.
- js/bound-function-name-expected.txt: Added.
- js/bound-function-name.html: Added.
- js/script-tests/bound-function-name.js: Added.
(assert):
(assert.foo):
(bar):
- 2:26 PM Changeset in webkit [196242] by
-
- 26 edits6 adds in trunk
CSP: Allow Web Workers initiated from an isolated world to bypass the main world Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=153622
<rdar://problem/24400023>
Source/WebCore:
Reviewed by Gavin Barraclough.
Fixes an issue where Web Workers initiated from an isolated world (say, a Safari Content Script Extension)
would be subject to the Content Security Policy of the page.
Currently code in an isolated world that does not execute in a Web Worker is exempt from the CSP of
the page. However, code that runs inside a Web Worker that was initiated from an isolated world is
subject to the CSP of the page. Instead, such Web Worker code should also be exempt from the CSP of
the page.
Tests: http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-eval.html
http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-xhr.html
http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): Modified to ask the script execution context whether to bypass the
main world Content Security Policy now that script execution context knows this information.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy): Deleted; moved logic from here...
- bindings/js/ScriptController.h:
- dom/Document.cpp:
(WebCore::Document::shouldBypassMainWorldContentSecurityPolicy): ...to here.
- dom/Document.h:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::shouldBypassMainWorldContentSecurityPolicy): Added; defaults to false -
do not bypass the main world Content Security Policy.
- page/EventSource.cpp:
(WebCore::EventSource::create): Modified to ask the script execution context whether to bypass the
main world Content Security Policy now that script execution context knows this information.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::shouldBypassMainWorldContentSecurityPolicy): Deleted.
- page/csp/ContentSecurityPolicy.h:
- workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL): Bypass the main world Content Security Policy if applicable.
Added FIXME comment to enforce the child-src directive of the document's CSP (as opposed to the script-src
directive) on the worker's script URL. Also, scriptExecutionContext()->contentSecurityPolicy() should
always be non-null just as we expect scriptExecutionContext()->securityOrigin() to be non-null. Assert
this invariant to catch cases where a ScriptExecutionContext is not properly initialized.
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create): Modified to take boolean argument shouldBypassMainWorldContentSecurityPolicy
as to whether to bypass the main world Content Security Policy and only apply the Content Security
Policy headers when shouldBypassMainWorldContentSecurityPolicy is false.
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope): Pass through a boolean argument shouldBypassMainWorldContentSecurityPolicy
as to whether to bypass the main world Content Security Policy.
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread): Ditto.
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope): Ditto.
- workers/DedicatedWorkerThread.h:
- workers/Worker.cpp:
(WebCore::Worker::create): Store whether we should bypass the main world Content Security Policy so
that we can pass it to WorkerMessagingProxy::startWorkerGlobalScope() in Worker::notifyFinished().
We need to store this decision here as opposed to determining it at any later time (say, in Worker::notifyFinished())
because it is dependent on the current JavaScript program stack at the time this function is invoked.
(WebCore::Worker::notifyFinished): Pass whether to bypass the main world Content Security Policy.
- workers/Worker.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope): Modified to take a boolean as to whether to bypass the
main world Content Security Policy and store it in a member field. Also, always instantiate a Content
Security Policy object as our current code assumes that one is always created.
- workers/WorkerGlobalScope.h:
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope): Pass through a boolean argument shouldBypassMainWorldContentSecurityPolicy
as to whether to bypass the main world Content Security Policy.
- workers/WorkerMessagingProxy.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData): Modified to take a boolean argument as to
whether to bypass the main world Content Security Policy and store it in a member field.
(WebCore::WorkerThread::WorkerThread): Pass through a boolean argument shouldBypassMainWorldContentSecurityPolicy
as to whether to bypass the main world Content Security Policy.
(WebCore::WorkerThread::workerThread): Ditto.
- workers/WorkerThread.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open): Modified to ask the script execution context whether to bypass the
main world Content Security Policy now that script execution context knows this information.
LayoutTests:
Reviewed by Gavin Barraclough and Andy Estes.
Add tests to ensure that a Web Worker initiated from an isolated world can bypass the main world
Content Security Policy.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-eval-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-eval.html: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-xhr-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-blob-xhr.html: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-expected.txt: Added.
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker.html: Added.
- 11:25 AM Changeset in webkit [196241] by
-
- 4 edits in trunk
[cmake] Move LLVM detection for LLVMDisassembler to OptionsCommon.cmake
https://bugs.webkit.org/show_bug.cgi?id=153961
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-07
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- 11:03 AM Changeset in webkit [196240] by
-
- 4 edits in trunk/Source/JavaScriptCore
String.match should defend against matches that would crash the VM
https://bugs.webkit.org/show_bug.cgi?id=153964
rdar://problem/24301119
Reviewed by Saam Barati.
This fixes a crash in an internal test case.
- runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::slowAppend): Use best practices to ensure that the size we
compute makes sense. Crash if it stops making sense, since most users of this API assume
that they are creating something small enough to fit on the stack.
- runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::size):
(JSC::MarkedArgumentBuffer::operator new): Deleted. These were ineffective. According to the
debugger, we were still calling system malloc. So, I changed the code to use fastMalloc()
directly.
(JSC::MarkedArgumentBuffer::operator delete): Deleted.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncMatch): Explicitly defend against absurd sizes. Of course, it's still
possible to crash the VM on OOME. That's sort of always been the philosophy of JSC - we
don't guarantee that you'll get a nice-looking error whenever you run out of memory,
since in a GC'd environment you can't really guarantee those things. But, if you have a
match that obvious won't fit in memory, then reporting an error is useful in case this is
a developer experimenting with a buggy regexp.
- 10:44 AM Changeset in webkit [196239] by
-
- 21 edits in trunk/Source
[Cocoa] Replace has_include guards around inclusion of Apple-internal-SDK headers with USE(APPLE_INTERNAL_SDK)
https://bugs.webkit.org/show_bug.cgi?id=153963
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- inspector/remote/RemoteInspectorXPCConnection.mm:
Source/WebCore:
- accessibility/mac/AXObjectCacheMac.mm:
- crypto/CommonCryptoUtilities.cpp:
- crypto/CommonCryptoUtilities.h:
- editing/mac/TextUndoInsertionMarkupMac.h:
- editing/mac/TextUndoInsertionMarkupMac.mm:
- platform/cocoa/TelephoneNumberDetectorCocoa.cpp:
- platform/graphics/cg/ImageSourceCG.cpp:
- platform/graphics/mac/PDFDocumentImageMac.mm:
- platform/network/ios/NetworkStateNotifierIOS.mm:
- platform/network/mac/BlobDataFileReferenceMac.mm:
- platform/network/mac/ResourceHandleMac.mm:
- rendering/RenderThemeMac.mm:
Source/WebKit/mac:
- WebView/WebPDFView.mm:
Source/WTF:
- wtf/SystemTracing.h:
- wtf/WTFThreadData.h:
- wtf/spi/darwin/CommonCryptoSPI.h:
- 2:09 AM Changeset in webkit [196238] by
-
- 4 edits in trunk
REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork
https://bugs.webkit.org/show_bug.cgi?id=153695
Reviewed by Michael Catanzaro.
Source/WebCore:
The problem is that ScrollAnimation objects are not destroyed by
the ScrollAnimator destructor, because I forgot to add a virtual
destructor for ScrollAnimation in r195661.
- platform/ScrollAnimation.h:
(WebCore::ScrollAnimation::~ScrollAnimation):
LayoutTests:
- platform/gtk/TestExpectations:
Feb 6, 2016:
- 10:34 PM Changeset in webkit [196237] by
-
- 9 edits in trunk/LayoutTests
Unreviewed, update several layout tests for WK1 after r196227.
- http/tests/security/cross-frame-access-enumeration-expected.txt:
- http/tests/security/cross-frame-access-enumeration.html:
- http/tests/security/cross-frame-access-get-expected.txt:
- http/tests/security/cross-frame-access-get.html:
- http/tests/security/cross-frame-access-history-get-expected.txt:
- http/tests/security/cross-frame-access-history-get-override-expected.txt:
- http/tests/security/cross-frame-access-history-get-override.html:
- http/tests/security/cross-frame-access-history-get.html:
- 9:55 PM Changeset in webkit [196236] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r195432): Web Inspector: bottom right section of the styles sidebar is 1px taller than the console prompt
https://bugs.webkit.org/show_bug.cgi?id=153959
<rdar://problem/24541053>
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container)::
Revert the height to what it used to be prior r195432.
- 6:21 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 6:17 PM Changeset in webkit [196235] by
-
- 5 edits in trunk/LayoutTests
[GTK] Rebaseline some tests and update expectations after r196222
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- platform/gtk/fast/clip/outline-overflowClip-expected.txt:
- platform/gtk/fast/repaint/layer-outline-expected.txt:
- platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
- 6:03 PM Changeset in webkit [196234] by
-
- 2 edits in trunk/Source/WebKit2
Call CFRelease() on SecRequirementRef when no longer needed
https://bugs.webkit.org/show_bug.cgi?id=153954
<rdar://problem/24540259>
Reviewed by Dan Bernstein.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox):
- 5:52 PM Changeset in webkit [196233] by
-
- 2 edits in trunk/LayoutTests
[GTK] imported/blink/compositing/squashing/abspos-under-abspos-overflow-scroll.html is flaky
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 5:51 PM Changeset in webkit [196232] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
FTL must store the call site index before runtime calls, even if it's the tail call slow path
https://bugs.webkit.org/show_bug.cgi?id=153955
rdar://problem/24290970
Reviewed by Saam Barati.
This is necessary because you could throw an exception in a host call on the tail call's slow
path. That'll route us to lookupExceptionHandler(), which unwinds starting with the call site
index of our frame. Bad things happen if it's not set. Prior to this patch it was possible
for the call site index field to be uninitialized, which meant that the throwing machinery
was making a wild guess about where we are.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
- tests/stress/tail-call-host-call-throw.js: Added.
- 4:45 PM Changeset in webkit [196231] by
-
- 2 edits in trunk/PerformanceTests
Code clean up: Move Rotater function closer to Stage static methods.
The Rotater is used together with those methods; keep them close.
- Animometer/tests/resources/main.js:
- 4:39 PM Changeset in webkit [196230] by
-
- 3 edits in trunk/PerformanceTests
Update the JS includes due to ResultsTable move.
- Animometer/developer.html:
- Animometer/index.html:
- 4:34 PM Changeset in webkit [196229] by
-
- 7 edits in trunk/PerformanceTests
Move createElement and createSVGElement to Utilities.
- Animometer/resources/extensions.js:
(Utilities.createElement): Added.
(Utilities.createSVGElement): Added.
(DocumentExtension.createElement): Deleted.
(DocumentExtension.createSvgElement): Deleted.
- Animometer/resources/debug-runner/animometer.js:
- Animometer/resources/runner/animometer.js:
- Animometer/tests/bouncing-particles/resources/bouncing-svg-images.js:
- Animometer/tests/bouncing-particles/resources/bouncing-svg-particles.js:
- Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js:
- 4:27 PM Changeset in webkit [196228] by
-
- 10 edits in trunk/PerformanceTests
Add a convenience function for creating a class.
The pattern for creating a class is common enough to add as a Utilities
helper function. It also makes it easy to collapse class definitions when
editing.
- Animometer/resources/debug-runner/animometer.js: Move ProgressBar definition,
since it is only used here.
- Animometer/resources/runner/animometer.js: Move ResultsDashboard and
ResultsTable definition, since it is only used here.
- Animometer/resources/extensions.js: Move Utilities definition to the top. Convert
Point, Insets, SimplePromise.
(ProgressBar): Moved to animometer.js.
(ResultsDashboard): Moved to animometer.js.
(ResultsTable): Moved to animometer.js.
- Animometer/resources/runner/benchmark-runner.js: Convert BenchmarkRunnerState,
BenchmarkRunner.
- Animometer/tests/resources/main.js: Convert Rotater, Stage, Animator, Benchmark.
- Animometer/tests/resources/sampler.js: Convert Experiment, Sampler.
Convert test primitives.
- Animometer/tests/master/resources/canvas-tests.js: Convert CanvasLineSegment,
CanvasArc, CanvasLinePoint.
- Animometer/tests/simple/resources/simple-canvas-paths.js: Convert CanvasLineSegment,
CanvasLinePoint, CanvasQuadraticSegment, CanvasQuadraticPoint, CanvasBezierSegment,
CanvasBezierPoint, CanvasArcToSegment, CanvasArcToSegmentFill, CanvasArcSegment,
CanvasArcSegmentFill, CanvasRect, CanvasRectFill.
- Animometer/tests/simple/resources/tiled-canvas-image.js: Convert CanvasImageTile.
- 4:18 PM Changeset in webkit [196227] by
-
- 18 edits2 deletes in trunk
Prevent cross-origin access to window.history
https://bugs.webkit.org/show_bug.cgi?id=153931
Reviewed by Darin Adler.
Source/WebCore:
Prevent cross-origin access to window.history to match the specification [1]
and the behavior of other browsers (tested Firefox and Chrome).
[1] https://html.spec.whatwg.org/multipage/browsers.html#security-window
No new tests, already covered by existing tests that
were updated in this patch.
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
(WebCore::JSHistory::state): Deleted.
- page/DOMWindow.idl:
- page/History.idl:
LayoutTests:
Update / rebaseline several layout tests now that cross-origin access to
window.history is prevented.
- fast/frames/sandboxed-iframe-history-denied-expected.txt:
- http/tests/history/cross-origin-replace-history-object-child-expected.txt:
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- http/tests/security/cross-frame-access-delete-expected.txt:
- http/tests/security/cross-frame-access-delete.html:
- http/tests/security/cross-frame-access-history-prototype-expected.txt:
- http/tests/security/cross-frame-access-history-put.html: Removed.
- http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt:
- http/tests/security/cross-frame-access-object-getPrototypeOf.html:
- http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
- http/tests/security/cross-frame-access-object-setPrototypeOf.html:
- http/tests/security/resources/cross-frame-iframe-for-history-put-test.html: Removed.
- 3:41 PM Changeset in webkit [196226] by
-
- 3 edits in trunk/Source/WebCore
ScrollbarPainters needs to be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=153932
-and corresponding-
rdar://problem/24015483
Reviewed by Dan Bernstein.
Darin pointed out that this was still race-y. There was still a race
condition between the destruction of the two local variables and the
destruction of the lambda on the main thread. This should fix that.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
(WebCore::ScrollingTreeFrameScrollingNodeMac::releaseReferencesToScrollbarPaintersOnTheMainThread):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
- 3:36 PM Changeset in webkit [196225] by
-
- 5 edits in trunk/PerformanceTests
Minor improvements to debug harness.
- Animometer/developer.html:
- Animometer/resources/debug-runner/animometer.css:
(#suites): Put the complexity text boxes closer to the test names.
(#options):
(#rawFPS circle): Make the interval FPS appear as a separate data series, with a line.
(#intervalFPS path):
(#intervalFPS circle):
- Animometer/resources/debug-runner/animometer.js:
(window.optionsManager.updateLocalStorageFromUI): Convert number inputs from text.
(window.suitesManager._onChangeTestCheckbox): Refactor to take a checkbox.
(window.suitesManager._createTestElement): Enhance such that typing into the complexity
input will automatically select that test for running.
(window.suitesManager.updateLocalStorageFromJSON): Make the harness work for private
browsing.
- Animometer/resources/debug-runner/graph.js: Separate the intervalFPS data, and show
more accuracy in timestamps.
- 3:31 PM Changeset in webkit [196224] by
-
- 12 edits in trunk/PerformanceTests
Refactor helper methods for getting random values for a stage.
Instead of requiring a Stage instance, just attach it to the Stage object.
- Animometer/tests/bouncing-particles/resources/bouncing-canvas-shapes.js:
- Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js:
- Animometer/tests/bouncing-particles/resources/bouncing-particles.js:
- Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js:
- Animometer/tests/master/resources/canvas-tests.js:
- Animometer/tests/master/resources/particles.js:
- Animometer/tests/misc/resources/canvas-electrons.js:
- Animometer/tests/misc/resources/canvas-stars.js:
- Animometer/tests/misc/resources/compositing-transforms.js:
- Animometer/tests/resources/main.js:
- Animometer/tests/simple/resources/simple-canvas-paths.js:
- 3:18 PM Changeset in webkit [196223] by
-
- 57 edits in trunk/Source
Finish auditing call sites of upper() and lower(), eliminate many, and rename the functions
https://bugs.webkit.org/show_bug.cgi?id=153905
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- runtime/IntlObject.cpp:
(JSC::canonicalLangTag): Use converToASCIIUppercase on the language tag.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToLowerCase): Tweak style and update for name change.
(JSC::stringProtoFuncToUpperCase): Ditto.
Source/WebCore:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported): Use convertToASCIILowercase on MIME type.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::selectText): Use new names for lower and upper. Also
tweaked style a tiny bit and used u_toupper rather than converting an entire
string to uppercase.
- dom/Document.cpp:
(WebCore::Document::addImageElementByCaseFoldedUsemap): Renamed to reflect the use
of case folding rather than lowercasing.
(WebCore::Document::removeImageElementByCaseFoldedUsemap): Ditto.
(WebCore::Document::imageElementByCaseFoldedUsemap): Ditto.
- dom/Document.h: Ditto.
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::getElementByCaseFoldedMapName): Ditto.
(WebCore::DocumentOrderedMap::getElementByCaseFoldedUsemap): Ditto.
- dom/DocumentOrderedMap.h: Ditto.
- dom/TreeScope.cpp:
(WebCore::TreeScope::getImageMap): Removed unneeded special case for null string.
Simplified logic for cases where the URL does not have a "#" character in it.
Use case folding instead of lowercase.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processText): Removed unneded special case for the empty string.
Use makCapitalized instead of Cocoa function for "capitalize". Use upper and lower
functions by their new names.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Use case folding instead of
lowerasing for the usemap attribute.
(WebCore::HTMLImageElement::insertedInto): Ditto.
(WebCore::HTMLImageElement::removedFrom): Ditto.
(WebCore::HTMLImageElement::matchesCaseFoldedUsemap): Ditto.
- html/HTMLImageElement.h: Rename since usemap is case folded now, not lowercased.
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement): Use case folding instead of lowercasing
for usemap.
(WebCore::HTMLMapElement::parseAttribute): Ditto.
- platform/Language.cpp:
(WebCore::canonicalLanguageIdentifier): Use convertToASCIILowercase for language code.
(WebCore::indexOfBestMatchingLanguageInList): Ditto.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Use new name for the upper function.
- platform/network/HTTPParsers.cpp:
(WebCore::parseContentTypeOptionsHeader): Use equalLettersIgnoringASCIICase instead
of lowercasing to check for a specific header value.
- platform/network/MIMEHeader.cpp:
(WebCore::retrieveKeyValuePairs): Use convertToASCIILowercase for MIME header name.
(WebCore::MIMEHeader::parseContentTransferEncoding): Use equalLettersIgnoringASCIICase
instead of lowercasing.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts): Make this hash ASCII case-insensitive.
(WebCore::clientCertificates): Ditto.
(WebCore::ResourceHandle::createCFURLConnection): Remove call to lower since the
set is now ASCII case-insensitive.
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Ditto.
(WebCore::ResourceHandle::setClientCertificate): Ditto.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::getNetscapeCookieFormat): Use equalLettersIgnoringASCIICase instead of
lowercasing.
- platform/network/curl/MultipartHandle.cpp:
(WebCore::MultipartHandle::didReceiveResponse): Use convertToASCIILowercase to
make a MIME type lowercase.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Removed unneeded
conversion to lowercase now that the set is ASCII case-insensitive.
(WebCore::ResourceHandle::setClientCertificate): Removed code that populates a map
that is then never used for anything.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Use convertToASCIILowercase for MIME type.
- platform/network/curl/SSLHandle.cpp: Made hash maps keyed by host names
ASCII case-insensitive.
(WebCore::addAllowedClientCertificate): Removed lowercasing since the map itself
is now ASCII case insensitve.
(WebCore::setSSLClientCertificate): Ditto. Also use auto for iterator type so we
don't have to write out the map type.
(WebCore::sslIgnoreHTTPSCertificate): Ditto.
(WebCore::certVerifyCallback): Ditto.
- platform/network/soup/ResourceHandleSoup.cpp: Made hash maps keyed by host names
ASCII case-insensitive.
(WebCore::allowsAnyHTTPSCertificateHosts): Ditto.
(WebCore::handleUnignoredTLSErrors): Ditto.
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate): Ditto.
(WebCore::ResourceHandle::setClientCertificate): Ditto.
- platform/text/LocaleToScriptMappingDefault.cpp: Made hash maps keyed by script
names ASCII case-insensitive. USE WTF_ARRAY_LENGTH as appropriate.
(WebCore::scriptNameToCode): Use modern style to initialize the map. Removed
unnecessary lowercasing of the script name before looking at the map.
(WebCore::localeToScriptCodeForFontSelection): Ditto.
- platform/text/win/LocaleWin.cpp:
(WebCore::convertLocaleNameToLCID): Made map ASCII case-insensitive and removed
unneeded lowercasing.
- platform/win/PasteboardWin.cpp:
(WebCore::clipboardTypeFromMIMEType): Use equalLettersIgnoringASCIICase instead
of lowercasing.
- rendering/RenderText.cpp:
(WebCore::applyTextTransform): Use new names for the upper and lower functions.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseIsXML): Remove unneeded lowercasing, since
DOMImplementation now has ASCII case-insensitive handling of MIME types.
Source/WebKit/mac:
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]): Use modern for loops.
(-[WebBasePluginPackage supportsExtension:]): Use convertToASCIILowercase for extension assert.
Also use modern for loop.
(-[WebBasePluginPackage supportsMIMEType:]): Ditto.
(-[WebBasePluginPackage MIMETypeForExtension:]): Ditto.
Source/WebKit/win:
- Plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::pluginForMIMEType): Use ASCII case-insensitive map rather
than lowercasing the MIME type.
(WebCore::PluginDatabase::setPreferredPluginForMIMEType): Ditto.
- Plugins/PluginDatabase.h: Make m_preferredPlugins use an ASCII case-insensitive hash.
- Plugins/PluginPackage.h: Use ASCII case-insensitive hash for maps keyed by MIME type.
- Plugins/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo): Use convertToASCIILowercase to lowercase a MIME type.
Source/WebKit2:
- NetworkProcess/CustomProtocols/CustomProtocolManager.h: Use ASCII case-insensitive hash
for set of registered schemes.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromPropertyLists): Use convertToASCIILowercase for MIME type and
for file extensions.
- Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::parseMIMEDescription): Use convertToASCIILowercase for
MIME description.
- UIProcess/API/efl/ewk_context.cpp:
(ewk_context_preferred_languages_set): Use convertToASCIILowercase for language.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages): Use convertToASCIILowercase for language.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::findPluginForExtension): Use Vector::contains instead of
writing it out using std::find.
(WebKit::pathExtension): Lowercase the result with convertToASCIILowercase instead of
leaving that to the caller.
(WebKit::PluginInfoStore::findPlugin): Removed call to lower since pathExtension
handles that now.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Use convertToASCIILowercase for MIME type.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::globalURLSchemesWithCustomProtocolHandlers): Use
an ASCII case-insensitive hash.
(WebKit::WebProcessPool::registerGlobalURLSchemeAsHavingCustomProtocolHandlers):
Remove lowercasing, since the hash is now ASCII case-insensitive.
(WebKit::WebProcessPool::unregisterGlobalURLSchemeAsHavingCustomProtocolHandlers):
Ditto.
- UIProcess/WebProcessPool.h: Use an ASCII case-insensitive hash.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize): Use convertToASCIILowercase on parameter names
and values.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::pluginSupportsExtension): Use convertToASCIILowercase for extension assertion.
Also use a modern for loop.
(WebKit::WebFrameLoaderClient::objectContentType): Make the checks for empty MIME types
a little less redundant. Reordered logic to avoid checking the list of supported MIME
types extra times, and to eliminate the need for a boolean. Use convertToASCIILowercase
on the extension.
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::lower): Deleted.
- wtf/text/AtomicString.h: Deleted the lower function.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::convertToLowercaseWithoutLocale): Renamed from lower.
(WTF::StringImpl::convertToUppercaseWithoutLocale): Renamed from upper.
(WTF::StringImpl::convertToLowercaseWithLocale): Renamed from lower.
(WTF::StringImpl::convertToUppercaseWithLocale): Renamed from upper.
(WTF::StringImpl::foldCase): Added fast cases for ASCII since this is
now used in some more-performance-critical code.
- wtf/text/StringImpl.h: Renamed lower and upper.
- wtf/text/WTFString.cpp:
(WTF::String::convertToLowercaseWithoutLocale): Renamed from lower.
(WTF::String::convertToUppercaseWithoutLocale): Renamed from upper.
(WTF::String::convertToLowercaseWithLocale): Renamed from lower.
(WTF::String::convertToUppercaseWithLocale): Renamed from upper.
- wtf/text/WTFString.h: Renamed lower and upper. Removed unneeded comment.
- 3:07 PM Changeset in webkit [196222] by
-
- 46 edits4 adds in trunk
Outline should contribute to visual overflow.
https://bugs.webkit.org/show_bug.cgi?id=153299
This patch eliminates the special outline handling (RenderView::setMaximalOutlineSize).
Now that outline is part of visual overflow, we don't have to inflate the layers to accomodate
outline borders.
This patch fixes several focusring related repaint issues. However when both the outline: auto
and the descendant renderer are composited, we still don't paint properly in certain cases. -not a regression.
(Also when parent renderer has overflow: hidden repaint does not take outline into account. -regression.)
It changes column behavior (see TestExpectations) since outline behaves now like any other visual overflow properties.
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/focus-ring-repaint.html
fast/repaint/focus-ring-repaint-with-negative-offset.html
- css/html.css: resetting to old behavior.
(:focus):
(input:focus, textarea:focus, isindex:focus, keygen:focus, select:focus):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::addOutlineVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
(WebCore::InlineFlowBox::paint): Deleted.
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::outlineStyleForRepaint):
(WebCore::RenderBlock::paint): Deleted.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock): Deleted.
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren): Deleted.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addVisualEffectOverflow):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::clippedOverflowRectForRepaint): Deleted.
- rendering/RenderBoxModelObject.h:
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::paint): Deleted.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
(WebCore::RenderElement::issueRepaintForOutlineAuto):
(WebCore::RenderElement::updateOutlineAutoAncestor):
(WebCore::RenderElement::computeMaxOutlineSize): Deleted.
(WebCore::RenderElement::styleWillChange): Deleted.
- rendering/RenderElement.h:
(WebCore::RenderElement::hasContinuation):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine): Deleted.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::isOutlinePhase): Deleted.
- rendering/RenderLineBoxList.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computePreferredLogicalWidths):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint): Deleted.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateRepaintToParentWithOutlineAutoIfNeeded): The renderer with outline: auto is responsible for
painting focusring around the descendants. If we issued repaint only on the descendant when it changes,
the focusring would not refresh properly. We have to find the ancestor with outline: auto, inflate the repaint rect and
issue the repaint on the ancestor if we crossed repaint container.
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::adjustRectForOutlineAndShadow):
(WebCore::RenderObject::setHasOutlineAutoAncestor):
(WebCore::RenderObject::adjustRectWithMaximumOutline): Deleted.
- rendering/RenderObject.h: We mark the descendants of outline: auto so that
when a child renderer changes we can propagate the repaint to the ancestor with outline.
(WebCore::RenderObject::hasOutlineAutoAncestor):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint): Deleted.
(WebCore::RenderReplaced::clippedOverflowRectForRepaint): Deleted.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paint): Deleted.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint): Deleted.
(WebCore::RenderTableCell::paintCollapsedBorders): Deleted.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
(WebCore::RenderTableRow::clippedOverflowRectForRepaint): Deleted.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::computeOverflowFromCells): Deleted.
(WebCore::RenderTableSection::paintObject): Deleted.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::platformFocusRingWidth):
- rendering/RenderView.cpp:
(WebCore::RenderView::setMaximalOutlineSize): Deleted.
- rendering/RenderView.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::outlineWidth):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/repaint/focus-ring-repaint-expected.txt: Added.
- fast/repaint/focus-ring-repaint.html: Added.
- fast/repaint/focus-ring-repaint-expected-with-negative-offset.txt: Added.
- fast/repaint/focus-ring-repaint-with-negative-offset.html: Added.
- TestExpectations:
- platform/mac/TestExpectations:
- platform/mac/compositing/geometry/ancestor-overflow-change-expected.txt:
- platform/mac/compositing/geometry/composited-in-columns-expected.txt:
- platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/mac/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
- platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/mac/fast/clip/outline-overflowClip-expected.txt:
- platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
- platform/mac/fast/repaint/4776765-expected.txt: Added.
- platform/mac/fast/repaint/focus-ring-expected.txt: Added.
- platform/mac/fast/repaint/layer-outline-expected.txt:
- platform/mac/fast/repaint/layer-outline-horizontal-expected.txt:
- platform/mac/svg/custom/focus-ring-expected.txt:
- 10:14 AM Changeset in webkit [196221] by
-
- 2 edits in trunk/LayoutTests
[GTK] Various tests are flaky
More unreviewed test gardening.
- platform/gtk/TestExpectations:
- 10:13 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 10:12 AM Changeset in webkit [196220] by
-
- 7 edits2 adds in trunk
Object.getOwnPropertyDescriptor() does not work on sub-frame's window
https://bugs.webkit.org/show_bug.cgi?id=153925
Reviewed by Darin Adler.
Source/JavaScriptCore:
Calling Object.getOwnPropertyDescriptor() on a sub-frame's window was
returning undefined for that window's own properties. The reason was
that the check getOwnPropertySlot() is using to make sure the
PropertySlot is not for a property coming from the prototype was wrong.
The check was checking that 'this != slotBase' which works fine unless
this is a JSProxy (e.g. JSDOMWindowShell). To handle proxies, the code
was also checking that 'slotBase.toThis() != this', attempting to
get the slotBase/Window's proxy. However, due to the implementation of
toThis(), we were getting the lexical global object's proxy instead of
slotBase's proxy. To avoid this issue, the new code explicitly checks
if 'this' is a JSProxy and makes sure 'JSProxy::target() != slotBase',
instead of using toThis().
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
LayoutTests:
- fast/dom/Window/getOwnPropertyDescriptor-other-window-expected.txt: Added.
- fast/dom/Window/getOwnPropertyDescriptor-other-window.html: Added.
Add test case to test calling Object.getOwnPropertyDescriptor() on a
sub-frame's window.
- http/tests/security/cross-origin-window-property-access-expected.txt:
- http/tests/security/cross-origin-window-property-access.html:
- Update test use use an iframe instead of opening a Window for convenience.
- Use an actual cross-origin URL. The previous URL was same-origin and therefore the test would have failed if window.location was a proper getter/setter instead of a 'value' descriptor.
- Add more tests to cover other Window properties (such as 'name') which are actual getter / setters to make sure using the current window's getter on a cross origin window does not bypass the security origin checks.
- http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
- http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html:
- Drop checks for properties for which cross-origin access via
getOwnPropertyDescriptor() now works. They used to not work because of the bug
this patch fixes, and not due to security checks.
- Most of these properties are part of the properties that the specification
states can be accessed cross-origin:
https://html.spec.whatwg.org/multipage/browsers.html#security-window
- ALL of these properties could already be accessed cross origin via regular
property getters (e.g. crossOriginWindow.blur) in Safari 9 so there should not
be any reason for getOwnPropertyDescriptor() not to work.
- I have also verified that Firefox allows cross-origin access for all these properties (via regular getters or getOwnPropertyDescriptor), except for the 'history' property. We may want to align our behavior here and prevent cross-origin access to 'window.history' but this is not a regression in this patch. You could already access crossOriginWindow.history in Safari 9.
- 9:33 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:26 AM Changeset in webkit [196219] by
-
- 2 edits in trunk/LayoutTests
[GTK] Various tests are flaky
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:26 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:01 AM Changeset in webkit [196218] by
-
- 2 edits in trunk/LayoutTests
[GTK] Gardening for unexpected passes
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:00 AM Changeset in webkit [196217] by
-
- 7 edits in trunk/Source
[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Add a VM API for throwing away linked code only.
- runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
- runtime/VM.h:
Source/WebCore:
When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.
In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.
This landed previously but was rolled out due to a Speedometer regression. I've made one
minor but important change here: only throw away code if we're navigating away from an
existing history item. Or in other words, don't throw away code for "force peeks" or any
other navigations that are not traditional top-level main frame navigations.
- bindings/js/GCController.cpp:
(WebCore::GCController::deleteAllLinkedCode):
- bindings/js/GCController.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- 7:55 AM WebKitGTK/Gardening/Calendar edited by
- Move myself to Saturday because Friday gardening sucks (diff)
- 5:44 AM Changeset in webkit [196216] by
-
- 2 edits in trunk/Source/WebCore
Added implementations of AXObjectCache methods for !HAVE(ACCESSIBILITY).
https://bugs.webkit.org/show_bug.cgi?id=153924
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-06
Reviewed by Andreas Kling.
No new tests needed.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::ariaModalNode): Added stub implementation.
(WebCore::AXObjectCache::postLiveRegionChangeNotification): Ditto.
(WebCore::AXObjectCache::rangeForNodeContents): Ditto.
(WebCore::AXObjectCache::setIsSynchronizingSelection): Ditto.
(WebCore::AXObjectCache::setTextSelectionIntent): Ditto.
(WebCore::AXAttributeCacheEnabler::AXAttributeCacheEnabler): Ditto.
(WebCore::AXAttributeCacheEnabler::~AXAttributeCacheEnabler): Ditto.
- 4:51 AM Changeset in webkit [196215] by
-
- 3 edits in trunk/Source/WebCore
Use scope stack instead of nested TreeResolvers for shadow trees
https://bugs.webkit.org/show_bug.cgi?id=153893
Reviewed by Andreas Kling.
Make TreeResolver per-document. This is a step towards iterative style resolve.
This is done replacing use of nested TreeResolvers with a scope stack that maintains
the style resolver and the selector filter for the current tree scope.
- style/StyleTreeResolver.cpp:
(WebCore::Style::ensurePlaceholderStyle):
(WebCore::Style::TreeResolver::Scope::Scope):
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::TreeResolver::createRenderTreeForShadowRoot):
(WebCore::Style::TreeResolver::createRenderTreeForSlotAssignees):
(WebCore::Style::TreeResolver::createRenderTreeRecursively):
(WebCore::Style::TreeResolver::resolveLocally):
(WebCore::Style::TreeResolver::resolveShadowTree):
(WebCore::Style::TreeResolver::resolveBeforeOrAfterPseudoElement):
(WebCore::Style::TreeResolver::resolveChildren):
(WebCore::Style::TreeResolver::resolveSlotAssignees):
(WebCore::Style::TreeResolver::resolveRecursively):
(WebCore::Style::TreeResolver::resolve):
(WebCore::Style::detachRenderTree):
- style/StyleTreeResolver.h:
(WebCore::Style::TreeResolver::scope):
(WebCore::Style::TreeResolver::pushScope):
(WebCore::Style::TreeResolver::pushEnclosingScope):
(WebCore::Style::TreeResolver::popScope):
- 3:29 AM Changeset in webkit [196214] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix more incorrect ASSERT introduced in r196053.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePluginX11::handleMouseEvent):
(WebKit::NetscapePluginX11::handleWheelEvent):
(WebKit::NetscapePluginX11::setFocus):
(WebKit::NetscapePluginX11::handleMouseEnterEvent):
(WebKit::NetscapePluginX11::handleMouseLeaveEvent):
(WebKit::NetscapePluginX11::handleKeyboardEvent):
- 2:12 AM Changeset in webkit [196213] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r196104.
https://bugs.webkit.org/show_bug.cgi?id=153940
Regressed Speedometer on iOS (Requested by kling on #webkit).
Reverted changeset:
"[iOS] Throw away linked code when navigating to a new page."
https://bugs.webkit.org/show_bug.cgi?id=153851
http://trac.webkit.org/changeset/196104
Feb 5, 2016:
- 11:00 PM Changeset in webkit [196212] by
-
- 2 edits in trunk/Tools
tests fail if display sleeps while run-webkit-tests is running
https://bugs.webkit.org/show_bug.cgi?id=153919
Reviewed by Alexey Proskuryakov.
- DumpRenderTree/mac/LayoutTestHelper.m:
(addDisplaySleepAssertion): Add the assertion so that the display doesn't turn off.
(releaseDisplaySleepAssertion): Release the DisplaySleep Assertion.
(simpleSignalHandler): Release the DisplaySleepAssertion in case of any iterrupt.
- 10:21 PM Changeset in webkit [196211] by
-
- 3 edits2 adds in trunk/PerformanceTests
Add a new graphics test for CanvasRenderingContext2D functions: getImageData and putImageData
https://bugs.webkit.org/show_bug.cgi?id=151716
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-02-05
Reviewed by Darin Adler.
The purpose of this test is to measure the performance of getImageData
and putImageData functions. This test draws a background on the canvas
and then gets some random tiles from this background and draw them in
destinations different from their original sources.
- Animometer/resources/debug-runner/tests.js: Adding the new test to the canvas simple tests suite.
- Animometer/resources/extensions.js:
(Array.prototype.shuffle): Shuffles the elements of an array.
(Point.zero): Returns a new Point object whose x and y are equal zero.
(Point.prototype.str): Used for debugging the Point object.
- Animometer/tests/simple/resources/tiled-canvas-image.js: Added.
(CanvasImageTile):
(CanvasImageTile.prototype.getImageData):
(CanvasImageTile.prototype.putImageData):
(Stage.call.initialize):
(Stage.call._createTiles):
(Stage.call._nextTilePosition):
(Stage.call.tune):
(Stage.call._drawBackground):
(Stage.call.animate):
(Stage.call.complexity):
(Stage.call):
- Animometer/tests/simple/tiled-canvas-image.html: Added.
- 8:53 PM Changeset in webkit [196210] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test expectations gardening.
- platform/gtk/TestExpectations:
- 8:51 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:56 PM Changeset in webkit [196209] by
-
- 1 edit in branches/safari-601-branch/LayoutTests/platform/mac/TestExpectations
Skip ES6-related Layout Tests. rdar://problem/24190123
- 5:24 PM Changeset in webkit [196208] by
-
- 2 edits in trunk/Source/WebCore
ScrollbarPainters needs to be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=153932
-and corresponding-
rdar://problem/24015483
Reviewed by Geoff Garen.
Follow-up fix since the first one was still race-y.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
- 5:15 PM Changeset in webkit [196207] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual Styles sidebar should be more forgiving to long labels
https://bugs.webkit.org/show_bug.cgi?id=153927
<rdar://problem/24343897>
Patch by Devin Rousso <Devin Rousso> on 2016-02-05
Reviewed by Timothy Hatcher.
If a label is too long for it's container, it overflows and is visible
above the rest of the elements nearby.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > .visual-style-property-title):
Adds text overflow to properties that extend beyond the container's width.
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
Now also adds the label value as a title attribute to the element, just in
case the content overflows.
- 5:08 PM Changeset in webkit [196206] by
-
- 2 edits in trunk/Source/WebCore
ScrollbarPainters needs to be deallocated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=153932
-and corresponding-
rdar://problem/24015483
Reviewed by Tim Horton.
Ensure the the destructor of ScrollingTreeFrameScrollingNodeMac and the
assignments done in this class are not responsible for deallocating the
ScrollbarPainter.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac):
(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
- 5:08 PM Changeset in webkit [196205] by
-
- 2 edits in trunk/LayoutTests
Mark css3/filters/multiple-filters-invalidation.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153933
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:49 PM Changeset in webkit [196204] by
-
- 2 edits in trunk/LayoutTests
Marking pageoverlay/overlay-small-frame-paints.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153898
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:20 PM Changeset in webkit [196203] by
-
- 2 edits in tags/Safari-602.1.18.5/Source/JavaScriptCore
Merged r196197. rdar://problem/24534864
- 4:20 PM Changeset in webkit [196202] by
-
- 2 edits in trunk/LayoutTests
Marking css3-text-decoration/text-underline-position/underline-visual-overflow-with-subpixel-position.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153315
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:19 PM Changeset in webkit [196201] by
-
- 5 edits in tags/Safari-602.1.18.5/Source
Versioning.
- 4:18 PM Changeset in webkit [196200] by
-
- 17 edits3 adds in trunk
Instance property getters / setters cannot be called on another instance of the same type
https://bugs.webkit.org/show_bug.cgi?id=153895
Reviewed by Gavin Barraclough.
Source/WebCore:
It should be possible to call instance property getters / setters on
other instances of the same type, as per the WEB IDL specification:
- http://heycam.github.io/webidl/#dfn-attribute-getter
- http://heycam.github.io/webidl/#dfn-attribute-setter
This matches the behavior of Firefox.
The issue without our bindings was that the getters / setters were
using |slotBase| instead of |thisValue| and therefore ended up using
the instance the getter was taken from instead of the actual target
object.
Test:
js/instance-property-getter-other-instance.html
js/instance-property-setter-other-instance.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- Have instance getters / setters use thisValue instead of slotBase.
- In the case of interfaces that have attributes on the instance for compatibility reasons, try the prototype object if |thisValue| does does have the right type, instead of using slotBase like previously. I believe this maintains the original compatibility intention while also behaving correctly when called on another instance.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
Rebaseline bindings tests.
LayoutTests:
- js/dom/script-tests/shadow-navigator-geolocation-in-strict-mode-does-not-throw.js:
- js/dom/shadow-navigator-geolocation-in-strict-mode-does-not-throw-expected.txt:
Extend this layout test coverage to cover the getter case in addition to the
setter case. This test covers the compatibility mode where we don't throw.
I made sure to maintain this behavior when refactoring the bindings to avoid
breakage.
- js/instance-property-getter-other-instance-expected.txt:
Rebaseline now that this test passes.
- js/instance-property-setter-other-instance-expected.txt: Added.
- js/instance-property-setter-other-instance.html: Added.
Add test to cover the setter case.
- 4:13 PM Changeset in webkit [196199] by
-
- 1 copy in tags/Safari-602.1.18.5
New tag.
- 4:13 PM Changeset in webkit [196198] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/security/cross-frame-access-custom.html as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153050
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 4:07 PM Changeset in webkit [196197] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153930
<rdar://problem/24534864>
Reviewed by Mark Lam.
- JavaScriptCore.vcxproj/JavaScriptCore.proj:
I made a typo in r196144.
- 4:06 PM Changeset in webkit [196196] by
-
- 2 edits in trunk/LayoutTests
Skipping js/basic-set.html on Mac since it is already runs as a part of run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=153879
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:55 PM Changeset in webkit [196195] by
-
- 4 edits1 move in trunk/Websites/perf.webkit.org
Testing with remote server cache is unusably slow
https://bugs.webkit.org/show_bug.cgi?id=153928
Reviewed by Chris Dumez.
Don't use the single process mode of httpd as it's way too slow even for testing.
Also we'll hit a null pointer crash (http://svn.apache.org/viewvc?view=revision&revision=1711479)
Since httpd exits immediately when launched in multi-process mode, remote-cache-server.py (renamed from
run-with-remote-server.py) now has "start" and "stop" commands to start/stop the Apache. Also added
"reset" command to reset the cache for convenience.
- Install.md: Updated the instruction.
- config.json: Fixed a typo: httpdErro*r*Log.
- tools/remote-cache-server.py: Copied from Websites/perf.webkit.org/tools/run-with-remote-server.py.
Now takes one of the following commands: "start", "stop", and "reset".
(main):
(start_httpd): Extracted from main.
(stop_httpd): Added.
- tools/remote-server-relay.conf: Removed redundant (duplicate) LoadModule's.
- tools/run-with-remote-server.py: Removed.
- 3:32 PM Changeset in webkit [196194] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153929
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 3:25 PM Changeset in webkit [196193] by
-
- 7 edits2 adds in trunk
Web Inspector: Include SamplingProfiler's expression-level data for stack frames in the protocol
https://bugs.webkit.org/show_bug.cgi?id=153455
<rdar://problem/24335884>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
We now send the sampling profiler's expression-level
line/column info in the inspector protocol.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::buildSamples):
- inspector/protocol/ScriptProfiler.json:
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::StackFrame::hasExpressionInfo):
Source/WebInspectorUI:
JSC has been collecting expression-level data in the sampling
profiler, and with this patch, we now get that information
in the inspector. With this information, we probably have
all the data we need to make real heat maps.
- UserInterface/Models/CallingContextTree.js:
(WebInspector.CallingContextTree.prototype.updateTreeWithStackTrace):
(WebInspector.CCTNode):
(WebInspector.CCTNode.prototype.findOrMakeChild):
(WebInspector.CCTNode.prototype.addTimestampAndExpressionLocation):
(WebInspector.CCTNode.prototype.addTimestamp): Deleted.
LayoutTests:
- inspector/sampling-profiler/expression-location-info-expected.txt: Added.
- inspector/sampling-profiler/expression-location-info.html: Added.
- 3:16 PM Changeset in webkit [196192] by
-
- 4 edits in tags/Safari-602.1.18.0.2/Source/bmalloc
Merged r196186. rdar://problem/18620635
- 2:30 PM Changeset in webkit [196191] by
-
- 7 edits in trunk/Source/WebCore
Modern IDB: UniqueIDBDatabase's m_databaseInfo is unsafely used from multiple threads.
https://bugs.webkit.org/show_bug.cgi?id=153912
Reviewed by Alex Christensen.
No new tests (Anything testable about this patch is already covered by existing tests).
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::infoForObjectStore):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
Teach the SQLiteIDBBackingStore to actually keep its m_databaseInfo up to date as it changes,
and to revert it when version change transactions abort:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::infoForObjectStore):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd): Use the IDBBackingStore's copy of the
IDBObjectStoreInfo, meant only for the database thread, instead of the UniqueIDBDatabase's copy,
which is meant only for the main thread.
- 2:28 PM Changeset in webkit [196190] by
-
- 2 edits1 add in trunk/Websites/perf.webkit.org
Perf dashboard should have a script to setup database
https://bugs.webkit.org/show_bug.cgi?id=153906
Reviewed by Chris Dumez.
Added tools/setup-database.py to setup the database. It retrieves the database name, username, password
and initializes a database at the specified location.
- Install.md: Updated instruction to setup postgres to use setup-database.py.
- tools/setup-database.py: Added.
(main):
(load_database_config):
(determine_psql_dir):
(start_or_stop_database):
(execute_psql_command):
- 1:53 PM Changeset in webkit [196189] by
-
- 2 edits in trunk/Tools
Fix iOS API tests after r196082
https://bugs.webkit.org/show_bug.cgi?id=153900
Patch by Alex Christensen <achristensen@webkit.org> on 2016-02-05
Reviewed by Jer Noble.
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
[WebView initialize] doesn't call JSC::initializeThreading on iOS.
- 1:41 PM Changeset in webkit [196188] by
-
- 2 edits in trunk/Source/JavaScriptCore
follow-up to: JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
https://bugs.webkit.org/show_bug.cgi?id=153663
<rdar://problem/24415092>
Rubber stamped by Joseph Pecoraro.
We were performing operations that required us to
hold the VM lock even when we might not have been holding it.
We now ensure we're holding it.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- 1:38 PM Changeset in webkit [196187] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Navigation bar in sidebars should always fit on a single line
https://bugs.webkit.org/show_bug.cgi?id=153412
<rdar://problem/24318706>
Patch by Devin Rousso <Devin Rousso> on 2016-02-05
Reviewed by Timothy Hatcher.
This happened because the allowed maximum width of the sidebar was greater
than the minimum width derived from the currently visible sidebar.
- UserInterface/Base/Utilities.js:
(Number.constrain):
Added logic to reverse the values of min and max if max is less than min.
- 1:34 PM Changeset in webkit [196186] by
-
- 4 edits in trunk/Source/bmalloc
bmalloc: largeMax calculation is wrong on iOS
https://bugs.webkit.org/show_bug.cgi?id=153923
Reviewed by Mark Lam.
Our number for largeMax was larger than what we had
space to actually allocate inside the LargeChunk. This made
it so that we would allocate a large object for something
that really should be extra large. Previously:
largeMax + sizeof(LargeChunk) > 1MB
which meant that when we would grow() to accommodate an allocation
of a particular size inside a LargeObject despite the fact that
the allocation size would be too large to actually fit in the LargeObject.
This would manifest when we had an allocation size in the range:
1MB - sizeof(LargeChunk) < allocation size < largeMax
We fix this bug by being precise in our calculation of largeMax
instead of just assuming largeChunkSize * 99/100 is enough
space for the metadata.
- bmalloc/LargeChunk.h:
(bmalloc::LargeChunk::get):
- bmalloc/Sizes.h:
- 1:22 PM Changeset in webkit [196185] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't wrap labels in Breakpoint Editor popover
https://bugs.webkit.org/show_bug.cgi?id=153926
rdar://problem/24149542
Reviewed by Brian Burg.
- UserInterface/Views/BreakpointPopoverController.css:
(.popover .edit-breakpoint-popover-content > table > tr > th): Added white-space: nowrap.
- 1:20 PM Changeset in webkit [196184] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Replace all instances of '%s' with “%s“
https://bugs.webkit.org/show_bug.cgi?id=153891
<rdar://problem/24510236>
Patch by Devin Rousso <Devin Rousso> on 2016-02-05
Reviewed by Timothy Hatcher.
Switched all WebInspector.UIString() from using to ““.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype.update):
- UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem.prototype._updateSelectorIcon):
- 1:19 PM Changeset in webkit [196183] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Error when closing page with WebInspector open
https://bugs.webkit.org/show_bug.cgi?id=152867
rdar://problem/24099423
Reviewed by Brian Burg.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::didClose): Null out m_inspectorPage after platformDetach(),
so the views can be cleaned up correctly.
- 12:52 PM Changeset in webkit [196182] by
-
- 2 edits in tags/Safari-602.1.18.4/Source/JavaScriptCore
Merged r196144. rdar://problem/24499887
- 12:51 PM Changeset in webkit [196181] by
-
- 5 edits in tags/Safari-602.1.18.4/Source
Versioning.
- 12:49 PM Changeset in webkit [196180] by
-
- 1 copy in tags/Safari-602.1.18.4
New tag.
- 11:52 AM Changeset in webkit [196179] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
Arrayify for a typed array shouldn't create a monster
https://bugs.webkit.org/show_bug.cgi?id=153908
rdar://problem/24290639
Reviewed by Mark Lam.
Previously if you convinced the DFG to emit an Arrayify to ArrayStorage and then gave it a
typed array, you'd corrupt the object.
- runtime/JSArrayBufferView.cpp:
(WTF::printInternal):
- runtime/JSArrayBufferView.h:
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):
- runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::growOutOfLineStorage):
(JSC::getBoundSlotBaseFunctionForGetterSetter):
- runtime/Structure.h:
- tests/stress/arrayify-array-storage-typed-array.js: Added. This test failed.
- tests/stress/arrayify-int32-typed-array.js: Added. This test case already had other protections, but we beefed them up.
- 11:51 AM Changeset in webkit [196178] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Move NetworkDataTask to its own header and source files
https://bugs.webkit.org/show_bug.cgi?id=153922
Reviewed by Tim Horton.
Also renamed NetworkSessionTaskClient to NetworkDataTaskClient.
- NetworkProcess/NetworkDataTask.h: Added.
(WebKit::NetworkDataTaskClient::~NetworkDataTaskClient):
(WebKit::NetworkDataTask::create):
(WebKit::NetworkDataTask::client):
(WebKit::NetworkDataTask::pendingDownloadID):
(WebKit::NetworkDataTask::pendingDownload):
(WebKit::NetworkDataTask::setPendingDownloadID):
(WebKit::NetworkDataTask::setPendingDownload):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient): Deleted.
(WebKit::NetworkDataTask::create): Deleted.
(WebKit::NetworkDataTask::client): Deleted.
(WebKit::NetworkDataTask::pendingDownloadID): Deleted.
(WebKit::NetworkDataTask::pendingDownload): Deleted.
(WebKit::NetworkDataTask::setPendingDownloadID): Deleted.
(WebKit::NetworkDataTask::setPendingDownload): Deleted.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: Added.
(WebKit::NetworkDataTask::NetworkDataTask):
(WebKit::NetworkDataTask::~NetworkDataTask):
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired):
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
(WebKit::NetworkDataTask::cancel):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::suspend):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask): Deleted.
(WebKit::NetworkDataTask::~NetworkDataTask): Deleted.
(WebKit::NetworkDataTask::scheduleFailure): Deleted.
(WebKit::NetworkDataTask::failureTimerFired): Deleted.
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication): Deleted.
(WebKit::NetworkDataTask::cancel): Deleted.
(WebKit::NetworkDataTask::resume): Deleted.
(WebKit::NetworkDataTask::suspend): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 10:52 AM Changeset in webkit [196177] by
-
- 3 edits in tags/Safari-602.1.18.0.2/Source/WebKit2
Merged r196037. rdar://problem/24399218
- 10:51 AM Changeset in webkit [196176] by
-
- 5 edits in tags/Safari-602.1.18.0.2/Source
Versioning.
- 10:49 AM Changeset in webkit [196175] by
-
- 1 copy in tags/Safari-602.1.18.0.2
New tag.
- 8:57 AM Changeset in webkit [196174] by
-
- 20 edits in trunk/Source
Clean up Blob code
https://bugs.webkit.org/show_bug.cgi?id=153910
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests, no change in behavior.
- css/StyleSheet.h:
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::normalizedContentType):
(WebCore::Blob::isNormalizedContentType):
(WebCore::Blob::registry):
- fileapi/Blob.h:
- fileapi/BlobURL.cpp:
(WebCore::BlobURL::createPublicURL):
- fileapi/BlobURL.h:
(WebCore::BlobURL::BlobURL):
(WebCore::BlobURL::blobProtocol): Deleted.
- platform/PlatformStrategies.cpp:
(WebCore::setPlatformStrategies):
(WebCore::hasPlatformStrategies): Deleted.
- platform/PlatformStrategies.h:
- platform/network/BlobRegistry.cpp:
(WebCore::blobRegistry):
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::~BlobRegistryImpl):
(WebCore::createResourceHandle):
(WebCore::registerBlobResourceHandleConstructor):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
- platform/network/BlobRegistryImpl.h:
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::BlobResourceHandle):
- platform/network/ResourceHandle.h:
Source/WebKit2:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::NetworkBlobRegistry):
(WebKit::NetworkBlobRegistry::registerFileBlobURL):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerFileBlobURL):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerFileBlobURL):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- 7:38 AM Changeset in webkit [196173] by
-
- 5 edits1 delete in trunk/Source/WebKit2
[Cocoa] Get rid of unused SPI declarations
https://bugs.webkit.org/show_bug.cgi?id=153915
Reviewed by Tim Horton.
- Platform/spi/Cocoa/NSInvocationSPI.h: Removed NSInvocation SPI method declaration.
- Platform/spi/ios/SafariServicesSPI.h: Removed.
- UIProcess/API/Cocoa/WKSecurityOrigin.mm:
(-[WKSecurityOrigin methodSignatureForSelector:]): Deleted.
(-[WKSecurityOrigin forwardInvocation:]): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm: Removed unused #import.
- WebKit2.xcodeproj/project.pbxproj: Removed reference to deleted header.
- 6:04 AM Changeset in webkit [196172] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Scrollbars incorrectly rendered with older versions of GTK+
https://bugs.webkit.org/show_bug.cgi?id=153861
Reviewed by Michael Catanzaro.
The theme doesn't really know it's a scrollbar. Older versions of
GTK+ require to explicitly add the scrollbar style class to the
child GtkStyleContext.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::createChildStyleContext):
- 6:02 AM WebKitGTK/2.10.x edited by
- (diff)
- 6:01 AM WebKitGTK/2.10.x edited by
- (diff)
- 5:58 AM Changeset in webkit [196171] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Scrollbars not correctly rendered in non GNOME environments
https://bugs.webkit.org/show_bug.cgi?id=153860
Reviewed by Michael Catanzaro.
I noticed this in a matchbox environment, where there's no
gnome-setting-daemon running. The problem is only with the
scrollbars, because we initialize the GtkSettings in
RenderThemeGtk and notify the ScrollbarTheme when it changes, but
ScrollbarTheme is created before RenderThemeGtk so we initialize
the theme properties before the GtkSettings have been
initialized. We can just let the ScrollbarTheme monitor the
theme itself instead of relying on being notified by the WebCore
layer.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::themeChangedCallback):
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
- rendering/RenderThemeGtk.cpp:
(WebCore::gtkStyleChangedCallback): Deleted.
- 1:59 AM Changeset in webkit [196170] by
-
- 3 edits in trunk/Source/WebCore
Remove DOMWrapped parameter from JSKeyValueIterator
https://bugs.webkit.org/show_bug.cgi?id=153859
Reviewed by Sam Weinig.
No change in behavior.
Using std::declval to infer DOMWrapped from JSWrapper::wrapped.
- bindings/js/JSFetchHeadersCustom.cpp:
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
- bindings/js/JSKeyValueIterator.h:
(WebCore::createIterator):
(WebCore::JSKeyValueIterator<JSWrapper>::destroy):
(WebCore::JSKeyValueIterator<JSWrapper>::next):
(WebCore::JSKeyValueIteratorPrototypeFunctionNext):
(WebCore::JSKeyValueIteratorPrototype<JSWrapper>::finishCreation):
- 1:03 AM Changeset in webkit [196169] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r193913): Web Inspector: Wrong z-index of inner sections
https://bugs.webkit.org/show_bug.cgi?id=153914
Reviewed by Timothy Hatcher.
- UserInterface/Views/DetailsSection.css:
(.details-section .details-section > .header):
- 1:01 AM Changeset in webkit [196168] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Decrease font-weight of inner sections
https://bugs.webkit.org/show_bug.cgi?id=153913
<rdar://problem/24520326>
Reviewed by Timothy Hatcher.
- UserInterface/Views/DetailsSection.css:
(.details-section .details-section > .header):
- 12:53 AM Changeset in webkit [196167] by
-
- 3 edits2 adds in trunk
AX: WebKit hanging when VoiceOver attempts to focus in on page
https://bugs.webkit.org/show_bug.cgi?id=153899
<rdar://problem/24506603>
Reviewed by Chris Fleizach.
Source/WebCore:
The VisiblePosition to CharacterOffset conversion will lead to an infinite loop if the
nextVisiblePostion call is returning the original VisiblePosition. Fixed it by breaking out
of the loop early in that situation.
Test: accessibility/text-marker/character-offset-visible-position-conversion-hang.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
LayoutTests:
- accessibility/text-marker/character-offset-visible-position-conversion-hang-expected.txt: Added.
- accessibility/text-marker/character-offset-visible-position-conversion-hang.html: Added.
Feb 4, 2016:
- 9:57 PM Changeset in webkit [196166] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: console.table background stripes are misaligned
https://bugs.webkit.org/show_bug.cgi?id=152954
<rdar://problem/24197735>
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.console-item .data-grid table.data):
(.console-item .data-grid table.data tr:nth-child(even)):
Replace CSS gradient that produces fixed height stripes with
a rule that sets background only on even table rows.
- 9:24 PM Changeset in webkit [196165] by
-
- 64 edits in trunk
Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=153500
<rdar://problem/24352458>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Be more explicit about enabling legacy profiling.
- jsc.cpp:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::hasProfiler): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling):
(JSC::JSGlobalObject::supportsProfiling): Deleted.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
(WebCore::JSDOMWindowBase::supportsProfiling): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling):
(WebCore::JSWorkerGlobalScopeBase::supportsProfiling): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::legacyProfilerEnabled):
(WebCore::InspectorController::setLegacyProfilerEnabled):
Be more explicit about enabling legacy profiling.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend): Deleted.
TimelineAgent doesn't need to recompile if using the sampling profiler.
This breaks console.profile, but console.profile should move to using
the sampling profiler as well.
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::startProfiling): Deleted.
(WebCore::stopProfiling): Deleted.
Inlined the use once static functions.
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profile):
(WebCore::PageConsoleClient::profileEnd):
Added FIXMEs for improving console.profile and profileEnd.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled):
(WebCore::Internals::setJavaScriptProfilingEnabled): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Be more explicit about enabling legacy profiling.
Source/WebKit/win:
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
Switch to the new API names.
LayoutTests:
- fast/profiler/*.html
Be more explicit about enabling legacy profiling.
- inspector/sampling-profiler/eval-source-url.html
Remove an inner loop that was causing tail call optimizations
to eliminate the sourceURL we were expecting.
- 6:01 PM Changeset in webkit [196164] by
-
- 2 edits in trunk/Source/WebCore
Follow-up: Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>
Reviewed by Darin Adler.
- plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible): Revise comments to provide a
better explanation of the function and why it exists.
- 5:31 PM Changeset in webkit [196163] by
-
- 2 edits6 deletes in trunk/Source/WebInspectorUI
Unreviewed, follow-up fix to r196151 that removes some more images.
- UserInterface/Images/Colors.png: Removed.
- UserInterface/Images/Colors@2x.png: Removed.
- UserInterface/Images/Network.png: Removed.
- UserInterface/Images/Network@2x.png: Removed.
- UserInterface/Images/Script.png: Removed.
- UserInterface/Images/Script@2x.png: Removed.
These images were supposed to also be removed.
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
Also remove references to now removed images.
- 5:20 PM Changeset in webkit [196162] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 5:19 PM Changeset in webkit [196161] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 5:18 PM Changeset in webkit [196160] by
-
- 1 copy in tags/Safari-601.1.46.97
New tag.
- 5:18 PM Changeset in webkit [196159] by
-
- 1 copy in tags/Safari-601.5.15
New tag.
- 4:51 PM Changeset in webkit [196158] by
-
- 2 edits in trunk/Tools
The status message for passing combined builder queues should say "all builds succeeded" when expanded. https://bugs.webkit.org/show_bug.cgi?id=153882
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Set status to "all builds succeeded" for combined builder queues
when expanded.
- 4:46 PM Changeset in webkit [196157] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL gardening. Mark some video tests to failure.
- platform/efl/TestExpectations:
- 4:42 PM Changeset in webkit [196156] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove ios-simulator-wk2 specific expectation for imported/w3c/web-platform-tests/html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=153844
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Removed.
- 4:36 PM Changeset in webkit [196155] by
-
- 5 edits in trunk/Source/JavaScriptCore
ArrayPrototype should have a destroy function
https://bugs.webkit.org/show_bug.cgi?id=153847
Reviewed by Filip Pizlo.
ArrayPrototype should have an destroy function as it now has a unique_ptr member that
needs to be freed at the end of the object's life cycle. Also, this patch adds an
option, gcAtEnd, that will cause jsc.cpp to do a garbage collection before exiting.
- jsc.cpp:
(runJSC):
(jscmain):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::destroy):
- runtime/ArrayPrototype.h:
- runtime/Options.h:
- 3:54 PM Changeset in webkit [196154] by
-
- 2 edits in trunk/Source/WebCore
Add Fetch API and CSS Variables to feature status
https://bugs.webkit.org/show_bug.cgi?id=153896
Reviewed by Timothy Hatcher.
- features.json:
- 3:47 PM Changeset in webkit [196153] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153844
Reviewed by Chris Dumez.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
- 3:23 PM Changeset in webkit [196152] by
-
- 6 edits in trunk/Source/JavaScriptCore
REGRESSION(192409): Cannot rely on add32() to zero-extend
https://bugs.webkit.org/show_bug.cgi?id=153897
Unreviewed rollout of r192409.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add32):
(JSC::MacroAssemblerARM64::add64):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add32):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::add8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::generateTest32):
(JSC::MacroAssemblerX86Common::clz32AfterBsr):
(JSC::MacroAssemblerX86Common::add32AndSetFlags): Deleted.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::branchAdd64):
(JSC::MacroAssemblerX86_64::repatchCall):
(JSC::MacroAssemblerX86_64::clz64AfterBsr):
(JSC::MacroAssemblerX86_64::add64AndSetFlags): Deleted.
- 3:13 PM Changeset in webkit [196151] by
-
- 4 edits5 adds8 deletes in trunk/Source/WebInspectorUI
Web Inspector: New timeline images for instruments
https://bugs.webkit.org/show_bug.cgi?id=153884
<rdar://problem/24509429>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Better names and give Memory timeline a name for an icon.
- UserInterface/Views/TreeOutline.css:
(.tree-outline.large .item .icon):
Add more padding next to large icons.
- UserInterface/Images/ColorsLarge.png: Removed.
- UserInterface/Images/ColorsLarge@2x.png: Removed.
- UserInterface/Images/Frames.png: Removed.
- UserInterface/Images/Frames@2x.png: Removed.
- UserInterface/Images/LayoutInstrument.svg: Added.
- UserInterface/Images/MemoryInstrument.svg: Added.
- UserInterface/Images/NetworkInstrument.svg: Added.
- UserInterface/Images/NetworkLarge.png: Removed.
- UserInterface/Images/NetworkLarge@2x.png: Removed.
- UserInterface/Images/RenderingFramesInstrument.svg: Added.
- UserInterface/Images/ScriptLarge.png: Removed.
- UserInterface/Images/ScriptLarge@2x.png: Removed.
Remove old timeline pngs.
- UserInterface/Images/ScriptsInstrument.svg: Added.
- UserInterface/Views/TimelineIcons.css:
(.network-icon .icon):
(.script-icon .icon):
(.memory-icon .icon):
(.layout-icon .icon):
(.rendering-frame-icon .icon):
Use the new SVGs.
(body:not(.mac-platform, .windows-platform) .network-icon .icon):
(body:not(.mac-platform, .windows-platform) .network-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .script-icon .icon):
(body:not(.mac-platform, .windows-platform) .script-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon):
Fallback to old icons for non-Mac/Windows ports using Images/gtk images.
- 2:54 PM Changeset in webkit [196150] by
-
- 2 edits in trunk/LayoutTests
media/video-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=124932
<rdar://problem/23336430>
Reviewed by Jer Noble.
- media/video-size.html: Add logic to retry each stage silently twice before logging failure because we can't predict how long it will take to load the poster frame.
- 2:07 PM Changeset in webkit [196149] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove dead ENABLE(BYTECODE_COMMENTS) cruft.
<https://webkit.org/b/153888>
Reviewed by Antti Koivisto.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock): Deleted.
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::shrinkToFit): Deleted.
- 1:52 PM Changeset in webkit [196148] by
-
- 4 edits in trunk/Source
WebKit for iOS Simulator fails to build with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=153881
Reviewed by Alex Christensen.
Source/WebCore:
Make constants have internal linkage to match the Apple Internal SDK.
- platform/spi/ios/MobileGestaltSPI.h:
Source/WebKit2:
Add version guards around SPI that is now API as of iOS SDK 9.2. Until we upgrade the iOS EWS
and iOS buildbots to use the 9.2 SDK we need to keep these SPI declarations to avoid breaking
the build.
- Platform/spi/ios/UIKitSPI.h:
- 1:51 PM Changeset in webkit [196147] by
-
- 5 edits3 adds in trunk/Source/JavaScriptCore
JSC Sampling Profiler: (host) is confusing in cases where I would expect to see JS name
https://bugs.webkit.org/show_bug.cgi?id=153663
<rdar://problem/24415092>
Reviewed by Geoffrey Garen.
We now collect the Callee in the processed StackFrame
when the Callee is a valid GC object. We later ask
the Callee for it's .displayName or .name property.
When we don't have a valid callee, we will still
use the Executable for this information.
This helps us come up with good names for frames where
the Callee object is a bound function or an InternalFunction.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- runtime/SamplingProfiler.cpp:
(JSC::reportStats):
(JSC::FrameWalker::walk):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::shutdown):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::nameFromCallee):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::stackTracesAsJSON):
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
(JSC::SamplingProfiler::StackFrame::StackFrame):
- tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.nothing):
(platformSupportsSamplingProfiler.top):
- tests/stress/sampling-profiler-bound-function-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.let.baz):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-display-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler.):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler.jaz):
(platformSupportsSamplingProfiler.makeFunction.let.result):
(platformSupportsSamplingProfiler.makeFunction):
- tests/stress/sampling-profiler-internal-function-name.js: Added.
(platformSupportsSamplingProfiler.foo):
(platformSupportsSamplingProfiler.bar):
(platformSupportsSamplingProfiler):
- 1:51 PM Changeset in webkit [196146] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Show error icons if invalid values already exist for properties in the Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153702
<rdar://problem/24424025>
Patch by Devin Rousso <Devin Rousso> on 2016-02-04
Reviewed by Timothy Hatcher.
When CSS properties have invalid values, instead of displaying the computed
value for that property in the Visual sidebar, show an error icon with the
the invalid value.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/VisualStyleNumberInputBox.css:
(.visual-style-property-container > .visual-style-property-value-container > .number-input-container > .number-input-value):
(.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder[hidden] ~ .number-input-container > .number-input-value):
By default, do not allow any pointer events to interact with the input element.
Instead, only allow interaction when the placeholder element is hidden to ensure
that the user cannot add a value when the computed value is displayed.
- UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox.prototype.set specialPropertyPlaceholderElementText):
Reset the selected keyword to "Unchanged" since this is either a warning
message or the computed value.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency):
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value):
(.visual-style-property-container > .visual-style-property-editor-warning):
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor):
Replaced document.createElement with [element].createChild for simplicity.
(WebInspector.VisualStylePropertyEditor.prototype.update):
Before assigning the value of the property to the editor, check to see if
the property is valid. If not, display an Error icon and message stating
that the current value is invalid.
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype.set specialPropertyPlaceholderElementText):
Unhides the special placeholder element with the given text as its content.
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
(WebInspector.VisualStylePropertyEditor.prototype.addDependency):
- 1:36 PM Changeset in webkit [196145] by
-
- 19 edits6 adds in trunk
Object.getOwnPropertyDescriptor() returns incomplete descriptor for instance properties
https://bugs.webkit.org/show_bug.cgi?id=153817
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing. Some checks are still
failing because getter.call(undefined) / getter.call() currently throws an exception
for Window properties but shouldn't. Global object property getters should not require
an explicit |this|.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/JavaScriptCore:
Extend support for Object.getOwnPropertyDescriptor() on native bindings
to instance properties (e.g. Unforgeable properties or Global object
properties) so that the returned descriptor has getter / setter
functions, as expected.
- runtime/JSObject.cpp:
(JSC::JSObject::reifyAllStaticProperties):
Add method that reifies all static properties, including the custom
accessors. This is similar to what is done eagerly on the prototype
objects in the bindings code.
(JSC::JSObject::getOwnPropertyDescriptor):
getOwnPropertyDescriptor() would previously fails for custom accessors
that are on the instance because getDirect() does not check the static
property table and those custom accessors were not reified (We only
reified all properties eagerly - including custom accessors - on
prototype objects. To address this issue, we now call
reifyAllStaticProperties() if the call to getDirect() fails and then
call getDirect() again. This fix is however insufficient for Window
properties because |this| is a JSDOMWindowShell / JSProxy in this case
and getDirect() / reifyAllStaticProperties() would fail as the proxy
does not actually have the properties. This issue was addressed by
checking if |this| is a JSProxy and then using JSProxy::target() instead
of |this| for the calls to getDirect() and for the reification.
- runtime/JSObject.h:
- runtime/Lookup.h:
(JSC::reifyStaticProperty):
(JSC::reifyStaticProperties):
Move most code in reifyStaticProperties() to a separate function so the
code can be shared with JSObject::reifyAllStaticProperties().
reifyStaticProperties() is currently called by the bindings on the
prototype objects.
Source/WebCore:
Update the bindings generator so that property getters / setters now
make sure |this| has the right type and throw a TypeError if it does
not, as per:
- http://heycam.github.io/webidl/#dfn-attribute-getter (step 2.4.2)
- http://heycam.github.io/webidl/#dfn-attribute-setter (step 3.5)
This was an issue when doing something like:
Object.getOwnPropertyDescriptor(window, "location").get.call(nonWindow)
We would call toJSDOMWindow(thisValue), which would return null as
thisValue is not a JSDOMWindow. We would then dereference this null
pointer and crash. We now do a null check and throw a TypeError in
this case, as per the Web IDL specification.
The generated bindings still have some non-spec compliant behavior
though:
- The getters / setters of instance properties use slotBase instead of thisValue, which means that calling instanceA's getter on instanceB returns instanceA's property insteas of instanceB's.
- Global object property getters should not require an explicit
|this| so calling the following should work:
- Object.getOwnPropertyDescriptor(window, "location").get.call() We currently throw in this case.
These issues will be addressed in follow-up patches.
Tests: js/getOwnPropertyDescriptor-unforgeable-attributes.html
js/getOwnPropertyDescriptor-window-attributes.html
js/instance-property-getter-other-instance.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionName):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjContentDocument):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjConstructor): Deleted.
(WebCore::setJSTestObjConstructorStaticStringAttr): Deleted.
(WebCore::setJSTestObjConditionalAttr3): Deleted.
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsConstructorTestSubObj):
LayoutTests:
Add layout test coverage for calling Object.getOwnPropertyDescriptor()
on instance properties (e.g. Unforgeable properties and Window properties).
- http/tests/security/cross-origin-window-property-access-expected.txt:
- http/tests/security/cross-origin-window-property-access.html:
- Fix bug causing the onload function to not find the crossOriginWindow variable.
- Update the case for accessing crossOriginWindow.location property as this is actually expected to work as per the specification: https://html.spec.whatwg.org/multipage/browsers.html#security-window
- js/dom/dom-as-prototype-assignment-exception-expected.txt:
- js/dom/getOwnPropertyDescriptor-expected.txt:
- js/dom/script-tests/dom-as-prototype-assignment-exception.js:
- js/getOwnPropertyDescriptor-unforgeable-attributes-expected.txt: Added.
- js/getOwnPropertyDescriptor-unforgeable-attributes.html: Added.
- js/getOwnPropertyDescriptor-window-attributes-expected.txt: Added.
- js/getOwnPropertyDescriptor-window-attributes.html: Added.
- js/instance-property-getter-other-instance-expected.txt: Added.
- js/instance-property-getter-other-instance.html: Added.
- js/resources/getOwnPropertyDescriptor.js:
- 1:20 PM Changeset in webkit [196144] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153886
<rdar://problem/24499887>
Reviewed by Mark Lam.
- JavaScriptCore.vcxproj/JavaScriptCore.proj:
In r190253 I changed the directory of the headers from AppleInternal/include/JavaScriptCore
to AppleInternal/include/private/JavaScriptCore. This is ok for WebCore and WebKit, but not
other projects, such as CFNetwork, which expect the public API headers to be in the old location.
This used to be done by a combination of copy-files.cmd and the old JavaScriptCore.proj.
This change copies all the API headers, which copies everything in copy-files.cmd except APIShims.h
which does not exist any more. It copies additional headers that were not copied before, but
I think this is beneficial so we do not forget to add new public headers to a list of public headers
to be copied in the internal build. Having extra public headers in the internal Windows build is
not a problem because only internal clients use the internal Windows build.
- 1:14 PM Changeset in webkit [196143] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests should be better at telling you details about test failures
https://bugs.webkit.org/show_bug.cgi?id=153845
Reviewed by Geoffrey Garen.
Here's an example of the contents of results/resultsByFamily, one of the new files that this
generates, for some local testing I'm doing. Notice how it groups families of tests together.
You won't see this unless you cat results/resultsByFamily.
regress.yaml/Regress/radar-24289839.js:
regress.yaml/Regress/radar-24289839.js.default: PASS
regress.yaml/Regress/radar-24289839.js.ftl: PASS
regress.yaml/Regress/radar-24289839.js.ftl-no-cjit: FAIL
regress.yaml/Regress/radar-24289839.js.ftl-eager-no-cjit: FAIL
regress.yaml/Regress/radar-24290639.js:
regress.yaml/Regress/radar-24290639.js.default: PASS
regress.yaml/Regress/radar-24290639.js.ftl: PASS
regress.yaml/Regress/radar-24290639.js.ftl-no-cjit: PASS
regress.yaml/Regress/radar-24290639.js.ftl-eager-no-cjit: FAIL
regress.yaml/Regress/radar-24290670.js: FAILED
- Scripts/run-jsc-stress-tests:
- 1:02 PM Changeset in webkit [196142] by
-
- 6 edits in trunk/Source/WebKit2
Web Inspector: Give nested inspectors their own process pool
https://bugs.webkit.org/show_bug.cgi?id=153880
<rdar://problem/24508310>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.
When inspecting the inspector both inspectors were using the same
Inspector process and sharing the same VM. This meant that profiling
information was confusing (memory and JavaScript sampling) because
it was showing data about both inspectors sharing the same process.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorProcessPool):
(WebKit::WebInspectorProxy::isInspectorProcessPool):
Have two process pools. The main inspector process pool (1st level inspectors)
and a nested inspector process pool (inspecting the inspector, only expected
by WebKit developers).
- UIProcess/WebInspectorProxy.h:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Pass the inspectionLevel to determine the appropriate pool to use.
- 12:38 PM Changeset in webkit [196141] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153871
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:26 PM Changeset in webkit [196140] by
-
- 2 edits in trunk/LayoutTests
Marking webgl/1.0.3/conformance/extensions/oes-texture-half-float-linear.html as flaky on mac
https://bugs.webkit.org/show_bug.cgi?id=153883
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:23 PM Changeset in webkit [196139] by
-
- 2 edits in trunk/Websites/webkit.org
Fix bad link on the Feature Status page.
https://bugs.webkit.org/show_bug.cgi?id=152086
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/status.php:
- 12:06 PM Changeset in webkit [196138] by
-
- 2 edits in trunk/Source/WebKit2
Fix the !ENABLE(NETSCAPE_PLUGIN_API) build after r196053
https://bugs.webkit.org/show_bug.cgi?id=153878
Unreviewed buildfix.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:
- 11:46 AM Changeset in webkit [196137] by
-
- 5 edits5 adds in trunk
Modern IDB: LayoutTest imported/w3c/indexeddb/keyorder-private.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=153438.
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/idbkey-array-equality-private.html
storage/indexeddb/modern/idbkey-array-equality.html
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString):
(WebCore::IDBKeyData::operator==): Fix obvious bug.
LayoutTests:
- platform/mac-wk1/TestExpectations: Re-enable the flaky test.
- resources/js-test.js:
- storage/indexeddb/modern/idbkey-array-equality-expected.txt: Added.
- storage/indexeddb/modern/idbkey-array-equality-private-expected.txt: Added.
- storage/indexeddb/modern/idbkey-array-equality-private.html: Added.
- storage/indexeddb/modern/idbkey-array-equality.html: Added.
- storage/indexeddb/modern/resources/idbkey-array-equality.js: Added.
- 11:38 AM Changeset in webkit [196136] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, fix the EFL clean build after r196123
https://bugs.webkit.org/show_bug.cgi?id=153875
- CMakeLists.txt:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- html/DOMSettableTokenList.h:
- html/DOMSettableTokenList.idl:
- 11:27 AM Changeset in webkit [196135] by
-
- 10 edits in trunk/Source/WebCore
PageGroup::captionPreferences should return a reference
https://bugs.webkit.org/show_bug.cgi?id=153877
<rdar://problem/24506917>
Reviewed by Jer Noble.
No new tests, no functional change.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::sortedTrackListForMenu):
(WebCore::MediaControlsHost::displayNameForTrack):
(WebCore::MediaControlsHost::captionMenuOffItem):
(WebCore::MediaControlsHost::captionDisplayMode):
- dom/Document.cpp:
(WebCore::Document::registerForCaptionPreferencesChangedCallbacks):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::setSelectedTextTrack):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::captionPreferencesChanged):
(WebCore::HTMLMediaElement::mediaPlayerPreferredAudioCharacteristics):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferencesChanged):
(WebCore::PageGroup::captionPreferences):
- page/PageGroup.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::updateLegibleOptions):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDisplayTrackKind):
(WebCore::InternalSettings::shouldDisplayTrackKind):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):
(WebCore::Internals::userPreferredAudioCharacteristics):
(WebCore::Internals::setUserPreferredAudioCharacteristic):
(WebCore::Internals::captionsStyleSheetOverride):
(WebCore::Internals::setCaptionsStyleSheetOverride):
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride):
(WebCore::Internals::setCaptionDisplayMode):
- 11:20 AM Changeset in webkit [196134] by
-
- 2 edits in trunk/Source/WebCore
Removed unused Settings::setPrivateBrowsingEnabled.
https://bugs.webkit.org/show_bug.cgi?id=153869
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-04
Reviewed by Alexey Proskuryakov.
Implementation of Settings::setPrivateBrowsingEnabled was removed
in r166661, but declaration is still here.
No new tests needed.
- page/Settings.h:
(WebCore::Settings::setPrivateBrowsingEnabled): Deleted.
- 11:12 AM Changeset in webkit [196133] by
-
- 2 edits in trunk/LayoutTests
Skip two flaky indexeddb tests on Yosemite Release WK2
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:29 AM Changeset in webkit [196132] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Guard use of MediaToolbox by ENABLE(AVF_CAPTIONS).
- 10:20 AM Changeset in webkit [196131] by
-
- 7 edits in trunk
Don't discard in-band cues with negative start times
https://bugs.webkit.org/show_bug.cgi?id=153867
<rdar://problem/19588632>
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated and un-skipped http/tests/media/track-in-band-hls-metadata.html.
- platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:
(WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue): ASSERT if passed negative time value.
(WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes): Ditto. Correct logging.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): ASSERT if passed negative time value.
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive): Convert negative cue times to zero.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):
Ditto.
LayoutTests:
- http/tests/media/track-in-band-hls-metadata-expected.txt:
- http/tests/media/track-in-band-hls-metadata.html: Test more attributes for correctness, fail test immediately if cue.value is undefined so the test doesn't generate an exception and exit without any results.
- platform/mac/TestExpectations: Unskip test.
- 10:03 AM Changeset in webkit [196130] by
-
- 7 edits2 adds in trunk
Specify an exception for createChannelMerger, createChannelSplitter and createPeriodicWave
https://bugs.webkit.org/show_bug.cgi?id=150925
Patch by Hyemi Shin <hyemi.sin@samsung.com> on 2016-02-04
Reviewed by Darin Adler.
createChannelMerger and createChannelSplitter should throw INDEX_SIZE_ERR
for invalid numberOfInputs value.
createPeriodicWave should throw INDEX_SIZE_ERR for invalid lengths of parameters.
Source/WebCore:
Tests: webaudio/audiochannelmerger-basic.html
webaudio/audiochannelsplitter.html
webaudio/periodicwave-lengths.html
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelSplitter):
(WebCore::AudioContext::createChannelMerger):
(WebCore::AudioContext::createPeriodicWave):
LayoutTests:
- webaudio/audiochannelmerger-basic-expected.txt: numberOfInputs could be 32.
- webaudio/audiochannelmerger-basic.html: Ditto.
- webaudio/audiochannelsplitter-expected.txt: Ditto.
- webaudio/audiochannelsplitter.html: Ditto.
- webaudio/periodicwave-lengths-expected.txt: Added.
- webaudio/periodicwave-lengths.html: Added.
- 9:45 AM Changeset in webkit [196129] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Use feature-based guards instead of OS-based guards, and wrap them around both MediaToolbox SOFT_LINK macros.
- 9:43 AM Changeset in webkit [196128] by
-
- 15 edits1 copy1 add in trunk
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Relanding.
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
- web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
- web-platform-tests/fetch/api/resources/utils.js:
(checkRequest):
(readTextStream):
Source/WebCore:
Relanding, updating bindings/js/JSKeyValueIterator.h for Windows bots.
Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.
- CMakeLists.txt:
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
- Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
- Modules/fetch/FetchHeaders.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
- bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
- bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::createIterator):
(WebCore::DOMWrapped>::destroy):
(WebCore::DOMWrapped>::next):
(WebCore::DOMWrapped>::finishCreation):
- 9:39 AM Changeset in webkit [196127] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Build fix.
- 9:34 AM Changeset in webkit [196126] by
-
- 2 edits2 adds in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset-expected.txt: Added.
- 9:27 AM Changeset in webkit [196125] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Speculative Mavericks Build Fix. rdar://problem/24417428
- 9:12 AM Changeset in webkit [196124] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r196067.
Re-enable speculative revalidation now that we have measured
the impact on the perf bots
Reverted changeset:
"Unreviewed, rolling out r195555."
https://bugs.webkit.org/show_bug.cgi?id=153443
http://trac.webkit.org/changeset/196067
- 8:57 AM Changeset in webkit [196123] by
-
- 43 edits1 delete in trunk
Merge DOMTokenList and DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=153677
<rdar://problem/24419675>
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Element-classlist-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
Update HTMLAreaElement.relList to match the specification.
Source/WebCore:
Merge DOMTokenList and DOMSettableTokenList, as per a recent
specification change:
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.idl:
- dom/Node.h:
- dom/NodeRareData.h:
- html/AttributeDOMTokenList.h:
- html/DOMSettableTokenList.cpp: Removed.
- html/DOMSettableTokenList.h:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.cpp:
(WebCore::DOMTokenList::setValue):
- html/DOMTokenList.h:
- html/DOMTokenList.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLElement.cpp:
- html/HTMLElement.idl:
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
- html/HTMLIFrameElement.h:
- html/HTMLIFrameElement.idl:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sizes):
- html/HTMLLinkElement.h:
- html/HTMLLinkElement.idl:
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::htmlFor):
- html/HTMLOutputElement.h:
- html/HTMLOutputElement.idl:
- html/HTMLTableCellElement.idl:
- page/DOMWindow.cpp:
- page/DOMWindow.idl:
LayoutTests:
Update / rebaseline several tests now that relList attributes
use [PutForward=value].
- fast/dom/HTMLElement/class-list-expected.txt:
- fast/dom/HTMLElement/class-list-quirks-expected.txt:
- fast/dom/HTMLElement/script-tests/class-list.js:
- fast/dom/rel-list-expected.txt:
- fast/dom/rel-list.html:
- 8:22 AM Changeset in webkit [196122] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r195837. rdar://problem/24001782
- 8:22 AM Changeset in webkit [196121] by
-
- 14 edits2 adds in branches/safari-601.1.46-branch
Merge r196010. rdar://problem/24416768
- 8:22 AM Changeset in webkit [196120] by
-
- 4 edits4 adds in branches/safari-601.1.46-branch
Merge r195912. rdar://problem/24416768
- 8:22 AM Changeset in webkit [196119] by
-
- 4 edits2 adds in branches/safari-601.1.46-branch
Merge r192570. rdar://problem/24416768
- 4:46 AM Changeset in webkit [196118] by
-
- 14 edits2 deletes in trunk
Unreviewed. Reverting r196115 and r19116, related tohttps://bugs.webkit.org/show_bug.cgi?id=153787.
- 3:39 AM Changeset in webkit [196117] by
-
- 5 edits2 adds in trunk/Source/WebCore
[GTK] Implement mediastream mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=153541
Reviewed by Martin Robinson.
Added the implementation of the mediaplayer for the
mediastream. The code was implemented by Philippe Normand and
Alessandro Decina.
- PlatformGTK.cmake: Added the file to the compilation.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject): Set the src of the
media element to the mediastream.
- platform/graphics/MediaPlayer.cpp:
(WebCore::buildMediaEnginesVector): Register the mediastream
mediaplayer as an option in the media engines vector.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp: Added.
(WebCore::MediaPlayerPrivateGStreamerOwr::MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::~MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::play):
(WebCore::MediaPlayerPrivateGStreamerOwr::pause):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasVideo):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasAudio):
(WebCore::MediaPlayerPrivateGStreamerOwr::currentTime):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::loadingFailed):
(WebCore::MediaPlayerPrivateGStreamerOwr::didLoadingProgress):
(WebCore::MediaPlayerPrivateGStreamerOwr::internalLoad):
(WebCore::MediaPlayerPrivateGStreamerOwr::stop):
(WebCore::MediaPlayerPrivateGStreamerOwr::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerOwr::getSupportedTypes):
(WebCore::MediaPlayerPrivateGStreamerOwr::supportsType):
(WebCore::MediaPlayerPrivateGStreamerOwr::isAvailable):
(WebCore::MediaPlayerPrivateGStreamerOwr::createGSTAudioSinkBin):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceStopped):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceMutedChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::sourceSettingsChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::preventSourceFromStopping):
(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h: Added.
(WebCore::MediaPlayerPrivateGStreamerOwr::engineDescription):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::cancelLoad):
(WebCore::MediaPlayerPrivateGStreamerOwr::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamerOwr::duration):
(WebCore::MediaPlayerPrivateGStreamerOwr::seek):
(WebCore::MediaPlayerPrivateGStreamerOwr::seeking):
(WebCore::MediaPlayerPrivateGStreamerOwr::setRate):
(WebCore::MediaPlayerPrivateGStreamerOwr::setPreservesPitch):
(WebCore::MediaPlayerPrivateGStreamerOwr::paused):
(WebCore::MediaPlayerPrivateGStreamerOwr::hasClosedCaptions):
(WebCore::MediaPlayerPrivateGStreamerOwr::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateGStreamerOwr::maxTimeSeekable):
(WebCore::MediaPlayerPrivateGStreamerOwr::buffered):
(WebCore::MediaPlayerPrivateGStreamerOwr::totalBytes):
(WebCore::MediaPlayerPrivateGStreamerOwr::bytesLoaded):
(WebCore::MediaPlayerPrivateGStreamerOwr::canLoadPoster):
(WebCore::MediaPlayerPrivateGStreamerOwr::setPoster):
(WebCore::MediaPlayerPrivateGStreamerOwr::isLiveStream):
(WebCore::MediaPlayerPrivateGStreamerOwr::audioSink):
- 3:14 AM Changeset in webkit [196116] by
-
- 3 edits in trunk/Source/WebCore/bindings/js
Unreviewed. Speculative Win Build fix
- 2:39 AM Changeset in webkit [196115] by
-
- 15 edits1 copy1 add in trunk
[Fetch API] Add support for iterating over Headers
https://bugs.webkit.org/show_bug.cgi?id=153787
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/headers/headers-structure-expected.txt:
- web-platform-tests/fetch/api/request/request-clone.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
- web-platform-tests/fetch/api/resources/utils.js: fixed typo in test.
Source/WebCore:
Covered by updated tests.
Introducing template class (JSKeyValueIterator) to support key-value iterators in DOM classes.
Using JSKeyValueIterator to implement Headers entries(), keys() and values() as custom methods.
Binding generator should be updated to generate directly these custom methods and handle iterator Symbol.
- CMakeLists.txt:
- Modules/fetch/FetchHeaders.cpp:
(WebCore::FetchHeaders::Iterator::next):
(WebCore::FetchHeaders::Iterator::Iterator):
- Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::createIterator):
- Modules/fetch/FetchHeaders.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.h:
(WebCore::jsPair):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSFetchHeadersCustom.cpp: Added.
(WebCore::JSFetchHeaders::entries):
(WebCore::JSFetchHeaders::keys):
(WebCore::JSFetchHeaders::values):
- bindings/js/JSKeyValueIterator.h: Added.
(WebCore::JSKeyValueIteratorPrototype::create):
(WebCore::JSKeyValueIteratorPrototype::createStructure):
(WebCore::JSKeyValueIteratorPrototype::JSKeyValueIteratorPrototype):
(WebCore::JSKeyValueIteratorPrototypeFuncNext):
- 2:10 AM Changeset in webkit [196114] by
-
- 15 edits in trunk/LayoutTests
Unreviewed. EFL gardening after r195740.
- platform/efl/accessibility/table-attributes-expected.txt:
- platform/efl/accessibility/table-cell-spans-expected.txt:
- platform/efl/accessibility/table-cells-expected.txt:
- platform/efl/accessibility/table-sections-expected.txt:
- platform/efl/accessibility/table-with-rules-expected.txt:
- platform/efl/css2.1/20110323/table-height-algorithm-023-expected.txt:
- platform/efl/css2.1/20110323/table-height-algorithm-024-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-43b-expected.txt:
- platform/efl/editing/deleting/5099303-expected.txt:
- platform/efl/editing/deleting/5144139-2-expected.txt:
- platform/efl/editing/deleting/5483370-expected.txt:
- platform/efl/editing/deleting/delete-to-select-table-expected.txt:
- platform/efl/editing/deleting/table-cells-expected.txt:
- platform/efl/fast/text/atsui-multiple-renderers-expected.txt:
- 2:05 AM Changeset in webkit [196113] by
-
- 3 edits in trunk
Unreviewed non X86_64 buildfix after r196077.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- 12:25 AM Changeset in webkit [196112] by
-
- 3 edits2 adds in trunk
Do not show context menu when right clicking on a scrollbar
https://bugs.webkit.org/show_bug.cgi?id=153493
Reviewed by Michael Catanzaro.
Source/WebCore:
Scrollbars don't currently handle right clicks, but we are showing
the context menu when they are right clicked. This is not desired
at least in GTK+ and I've checked that it isn't consistent with
other applications in Mac either.
Test: fast/events/contextmenu-on-scrollbars.html
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
LayoutTests:
Add a test to check that context menu event is not sent when right
clicking on a scrollbar.
- fast/events/contextmenu-on-scrollbars-expected.txt: Added.
- fast/events/contextmenu-on-scrollbars.html: Added.
Feb 3, 2016:
- 11:37 PM Changeset in webkit [196111] by
-
- 1 edit in trunk/Tools/ChangeLog
Fix a typo in Tools/ChangeLog
- 11:34 PM Changeset in webkit [196110] by
-
- 2 edits in trunk/Tools
[WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
https://bugs.webkit.org/show_bug.cgi?id=153835
Reviewed by Martin Robinson.
WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
the context menu event is not hanlded, but we are using the
returned value without null checking it.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):
- 10:07 PM Changeset in webkit [196109] by
-
- 3 edits in trunk/Tools
Format revisions for display according to repository type https://bugs.webkit.org/show_bug.cgi?id=153818
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
to repository type.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new
_formatRevisionForDisplay function.
- 9:41 PM Changeset in webkit [196108] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Make some classes non JSDestructibleObject
https://bugs.webkit.org/show_bug.cgi?id=153838
Reviewed by Geoffrey Garen.
SymbolPrototype, JSMapIterator and JSSetIterator are trivially destructible.
So there is no need to inherit JSDestructibleObject.
- runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::destroy): Deleted.
- runtime/JSMapIterator.h:
- runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::destroy): Deleted.
- runtime/JSSetIterator.h:
- runtime/MapData.h:
- runtime/SymbolPrototype.h:
- 9:38 PM Changeset in webkit [196107] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
[JSC] Symbol structure has unnecessary flags
https://bugs.webkit.org/show_bug.cgi?id=153840
Reviewed by Saam Barati.
- runtime/Symbol.h:
- tests/stress/symbol-get-own-property.js: Added.
(shouldBe):
- 9:16 PM Changeset in webkit [196106] by
-
- 2 edits in trunk/Tools
Logs/CoreSimulator filling up OS disk on WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=153853
<rdar://problem/24496003>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.
- 7:36 PM Changeset in webkit [196105] by
-
- 1 edit2 adds in trunk/LayoutTests
Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924
Reviewed by Darin Adler.
- editing/mac/spelling/accept-misspelled-candidate-expected.txt: Added.
- editing/mac/spelling/accept-misspelled-candidate.html: Added.
- 7:12 PM Changeset in webkit [196104] by
-
- 7 edits in trunk/Source
[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Add a VM API for throwing away linked code only.
- runtime/VM.cpp:
(JSC::VM::deleteAllLinkedCode):
- runtime/VM.h:
Source/WebCore:
When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.
In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.
- bindings/js/GCController.cpp:
(WebCore::GCController::deleteAllLinkedCode):
- bindings/js/GCController.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- 5:48 PM Changeset in webkit [196103] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/history/back-to-post.php as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153314
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:41 PM Changeset in webkit [196102] by
-
- 2 edits in trunk/LayoutTests
Skip imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:39 PM Changeset in webkit [196101] by
-
- 7 edits in trunk/Source
Report wasBlocked and cannotShowURL errors when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153846
Reviewed by Antti Koivisto.
Source/WebCore:
No new tests, but this fixes http/tests/xmlhttprequest/redirect-cross-origin-2.html
when using NetworkSession.
- platform/URL.h:
WEBCORE_EXPORT because we are using portAllowed in WebKit2 now.
Source/WebKit2:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::wasBlocked):
(WebKit::NetworkLoad::cannotShowURL):
(WebKit::NetworkLoad::didReceiveResponseAsync):
- NetworkProcess/NetworkLoad.h:
NetworkDataTask is now RefCounted so we can protect it when reporting errors which delete the NetworkLoad.
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
(WebKit::NetworkDataTask::create):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):
Check the validity of the requested url and check if the port is allowed like we do in the ResourceHandle constructor.
(WebKit::NetworkDataTask::~NetworkDataTask):
Don't remove the task from the NetworkSession's map if we didn't make it because there was an error.
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired):
Implemented like ResourceHandle's.
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::suspend):
Handle the failure timer like we do in ResourceHandle::setDefersLoading.
- 5:33 PM Changeset in webkit [196100] by
-
- 2 edits in trunk/LayoutTests
Marking displaylists tests as flaky on ios-simulator. Previous attempt was unsuccessful.
https://bugs.webkit.org/show_bug.cgi?id=153656
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:57 PM Changeset in webkit [196099] by
-
- 2 edits in trunk/LayoutTests
Marking transitions/clip-path-transitions.html and transitions/clip-path-path-transitions.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153809
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:56 PM Changeset in webkit [196098] by
-
- 5 edits2 adds in trunk
Web Inspector: JS PrettyPrinting unary - and + issues
https://bugs.webkit.org/show_bug.cgi?id=134007
<rdar://problem/17351953>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-03
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Views/CodeMirrorFormatters.js:
(shouldHaveSpaceBeforeToken):
(shouldHaveSpaceAfterLastToken):
(removeLastNewline):
(modifyStateForTokenPre):
(modifyStateForTokenPost):
LayoutTests:
- inspector/codemirror/prettyprinting-javascript-expected.txt:
- inspector/codemirror/prettyprinting-javascript.html:
- inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators-expected.js: Added.
- inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators.js: Added.
New tests for unary and some binary operators in JavaScript pretty printing.
- 4:35 PM Changeset in webkit [196097] by
-
- 3 edits in trunk/Tools
git-add-reviewer should work when run from a subdirectory within the repository
https://bugs.webkit.org/show_bug.cgi?id=153842
Reviewed by David Kilzer.
There are two problems that needed to be fixed:
- We can't assume .git is in $PWD/.git
- We can't specify absolute paths to
git commit
Fix these problems using the helpers in VCSUtils that were added to
fix this same issue for prepare-changeCogs.
- Scripts/VCSUtils.pm: Export gitDirectory()
- Scripts/git-add-reviewer:
(nonInteractive): Cache gitDirectory() result.
(addReviewer):
(commit):
(changeLogsForCommit): Make paths relative.
- 4:27 PM Changeset in webkit [196096] by
-
- 14 edits2 adds in branches/safari-601-branch
Merge r196010. rdar://problem/24417428
- 4:26 PM Changeset in webkit [196095] by
-
- 4 edits4 adds in branches/safari-601-branch
Merge r195912. rdar://problem/24417428
- 4:26 PM Changeset in webkit [196094] by
-
- 4 edits2 adds in branches/safari-601-branch
Merge r192570. rdar://problem/24417428
- 4:16 PM Changeset in webkit [196093] by
-
- 2 edits in trunk/Tools
Yet another Yosemite build fix.
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
- 4:05 PM Changeset in webkit [196092] by
-
- 5 edits in trunk
iOS build fix after Yosemite build fix broke iOS build.
Source/WebCore:
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
Tools:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
- 4:04 PM Changeset in webkit [196091] by
-
- 25 edits5 copies56 adds in trunk/LayoutTests
Re-sync W3C HTML web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=153832
Reviewed by Sam Weinig.
Re-sync W3C HTML web-platform-tests from:
https://github.com/w3c/web-platform-tests/tree/master/html
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03-expected.txt: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03.html: Added.
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/w3c-import.log:
- web-platform-tests/html/dom/elements-obsolete.js:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt: Added.
- web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html: Added.
- web-platform-tests/html/semantics/document-metadata/styling/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-area-element/support/hit-test.js: Added.
(onload):
- web-platform-tests/html/semantics/embedded-content/the-area-element/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.nocontext.html:
- web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log.
- web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/form-submission-0/url-encoded-expected.txt: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
- web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-button-element/button-activate-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-activate-frame.html: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-activate.html: Added.
- web-platform-tests/html/semantics/forms/the-button-element/button-events-expected.txt:
- web-platform-tests/html/semantics/forms/the-button-element/button-events.html:
- web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject.html: Added.
- web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/checkbox.html:
- web-platform-tests/html/semantics/forms/the-input-element/maxlength-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/maxlength.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/radio.html:
- web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-option-element/option-selected-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-option-element/option-selected.html: Added.
- web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html: Added.
- web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log:
- web-platform-tests/html/semantics/interactive-elements/the-details-element/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text.html:
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/rows-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/rows.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-tfoot-element/rows-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-tfoot-element/rows.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-tfoot-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/semantics/tabular-data/the-thead-element/rows-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-thead-element/rows.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-thead-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/cells-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/cells.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-tr-element/w3c-import.log:
- 4:01 PM Changeset in webkit [196090] by
-
- 9 edits in trunk/Source/WebCore
Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924
Reviewed by Darin Adler.
New document marker to mark inserted candidates. This was we can treat
inserted candidates just like a RejectedCorrection and we won’t accidentally
autocorrect them later on.
- dom/DocumentMarker.h:
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
When handling an acceptant candidate, set m_isHandlingAcceptedCandidate to
true while the text is being inserted, and then mark the range as an accepted
candidate.
- editing/Editor.cpp:
(WebCore::Editor::handleAcceptedCandidate):
- editing/Editor.h:
(WebCore::Editor::isHandlingAcceptedCandidate):
If frame.editor. isHandlingAcceptedCandidate() then return early from
markMisspellingsAfterTyping.
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping):
Add some test infrastructure.
- testing/Internals.cpp:
(WebCore::Internals::handleAcceptedCandidate):
- testing/Internals.h:
- testing/Internals.idl:
- 4:00 PM Changeset in webkit [196089] by
-
- 2 edits in trunk/Source/WebCore
[Win] Pass entire request (rather than just URL) to clients of WebCoreAVCFResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=153653
Reviewed by Brent Fulgham.
This will allow those clients to see the byte-range request ("Range:") header and respond
appropriately.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading):
- 3:53 PM Changeset in webkit [196088] by
-
- 5 edits in trunk
Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
Source/WebCore:
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
Tools:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
- 3:30 PM Changeset in webkit [196087] by
-
- 5 edits in tags/Safari-602.1.18.1.1/Source
Versioning.
- 3:26 PM Changeset in webkit [196086] by
-
- 1 copy in tags/Safari-602.1.18.1.1
New tag.
- 3:06 PM Changeset in webkit [196085] by
-
- 2 edits in trunk/Tools
[Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
https://bugs.webkit.org/show_bug.cgi?id=153827
Reviewed by Michael Catanzaro.
When an array is passed to subroutines as argument in perl,
a list containing its element is returned from the array.
Currently @$ arguments are being passed, then it is going to be one list
including all the elements not only from @ but also from $.
As a result, --cmakeargs option's value is included in @cmakeArgs
at generateBuildSystemFromCMakeProject subroutine,
so $additionalCMakeArgs doesn't needed anymore.
- Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
- 3:01 PM Changeset in webkit [196084] by
-
- 3 edits1 delete in trunk/LayoutTests
REGRESSION: LayoutTest http/tests/plugins/visible_plugins.html failing on Yosemite WK1
https://bugs.webkit.org/show_bug.cgi?id=153752
Reviewed by Alexey Proskuryakov.
Revise test to skip the plugins we expect to be displayed, and only display plugins
that are surprising.
- http/tests/plugins/visible_plugins.html:
- http/tests/plugins/visible_plugins-expected.txt:
- platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Removed.
- 2:59 PM Changeset in webkit [196083] by
-
- 2 edits in trunk/Source/WebCore
[EME][Mac] MediaKeys.createSession() fails with initData containing a contentId whose length is > 1/2 the initData.
https://bugs.webkit.org/show_bug.cgi?id=153517
<rdar://problem/24303782>
Reviewed by Eric Carlson.
The length of contentId is given in bytes, not Uint16 characters. Use the former when extracting
the contentId string from the initData.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extractKeyURIKeyIDAndCertificateFromInitData):
- 2:57 PM Changeset in webkit [196082] by
-
- 5 edits4 adds in trunk
[Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
https://bugs.webkit.org/show_bug.cgi?id=153669
Reviewed by Alex Christensen.
Source/WebCore:
API Test: WebCore.WebCoreNSURLSession
Add a NSURLSession-like object, which wraps a CachedResourceLoader and CachedRawResource, which we can
hand to lower-level frameworks, so that network loads by those frameworks use WebKit's loader.
- platform/network/cocoa/WebCoreNSURLSession.h: Added.
- platform/network/cocoa/WebCoreNSURLSession.mm: Added.
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]):
(-[WebCoreNSURLSession dealloc]):
(-[WebCoreNSURLSession copyWithZone:]):
(-[WebCoreNSURLSession delegateQueue]):
(-[WebCoreNSURLSession configuration]):
(-[WebCoreNSURLSession loader]):
(-[WebCoreNSURLSession finishTasksAndInvalidate]):
(-[WebCoreNSURLSession invalidateAndCancel]):
(-[WebCoreNSURLSession resetWithCompletionHandler:]):
(-[WebCoreNSURLSession flushWithCompletionHandler:]):
(-[WebCoreNSURLSession getTasksWithCompletionHandler:]):
(-[WebCoreNSURLSession getAllTasksWithCompletionHandler:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSession uploadTaskWithRequest:fromFile:]):
(-[WebCoreNSURLSession uploadTaskWithRequest:fromData:]):
(-[WebCoreNSURLSession uploadTaskWithStreamedRequest:]):
(-[WebCoreNSURLSession downloadTaskWithRequest:]):
(-[WebCoreNSURLSession downloadTaskWithURL:]):
(-[WebCoreNSURLSession downloadTaskWithResumeData:]):
(-[WebCoreNSURLSession streamTaskWithHostName:port:]):
(-[WebCoreNSURLSession streamTaskWithNetService:]):
(-[WebCoreNSURLSession isKindOfClass:]):
Add a C++ class which can act as a CachedRawResourceClient, passing the results back to a WebCoreNSURLSessionDataTask:
(WebCore::WebCoreNSURLSessionDataTaskClient::WebCoreNSURLSessionDataTaskClient):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataSent):
(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::notifyFinished):
Add a NSURLSessionDataTask-like object, which takes a request, then uses it to create and wrap a CachedRawResource.
Becase NSURSessionDataTask is intended to be used off-main-thread, care must be taken to dispatch back to the main-
(or web-) thread before calling CachedRawResource functions.
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
(-[WebCoreNSURLSessionDataTask copyWithZone:]):
(-[WebCoreNSURLSessionDataTask _restart]):
(-[WebCoreNSURLSessionDataTask _cancel]):
(-[WebCoreNSURLSessionDataTask _finish]):
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]):
(-[WebCoreNSURLSessionDataTask cancel]):
(-[WebCoreNSURLSessionDataTask suspend]):
(-[WebCoreNSURLSessionDataTask resume]):
(-[WebCoreNSURLSessionDataTask _timingData]):
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):
(-[WebCoreNSURLSessionDataTask resourceFinished:]):
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
Tools:
Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
calling appropriate NSURLSessionDelegate callbacks.
Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
header files will not match the one used when compiling WebCore, leading to strange crashes and weird
inconsistencies when calling, e.g., inline methods.
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
(-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
(-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
(-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
(TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
(TestWebKitAPI::TEST_F):
- 2:46 PM Changeset in webkit [196081] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Work towards rdar://problem/24190682
- 2:08 PM Changeset in webkit [196080] by
-
- 34 edits in trunk/Source
Convert another batch of String::lower callsites to something better, typically convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153789
Reviewed by Sam Weinig.
Source/WebCore:
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::isXMLMIMEType): Use equalLettersIgnoringASCIICase
and the boolean argument to endsWith to ignore ASCII case.
(WebCore::DOMImplementation::isTextMIMEType): Ditto. Also simplified the logic
by removing an if statement.
- dom/Document.cpp:
(WebCore::isSeparator): Deleted. Moved to WindowFeatures.cpp.
(WebCore::processArguments): Ditto.
(WebCore::Document::processViewport): Call the processFeaturesString function
from WindowFeatures.h; the code here was originally just a pasted copy of that code!
(WebCore::Document::processFormatDetection): Ditto.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toEncodingMimeType): Remove now-unneeded
lowercasing of MIME type before calling isSupportedImageMIMETypeForEncoding,
since the MIME type registry now ignores ASCII case. Use convertToASCIILowercase
on the return value, to preserve behavior.
(WebCore::HTMLCanvasElement::toDataURL): Minor coding style tweaks.
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseAttribute): Use convertToASCIILowercase for
the service type here.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Remove now-unneeded
lowercasing since MIME type registry now ignores ASCII case. And use
equalLettersIgnoringASCIICase for the case here.
- html/HTMLInputElement.cpp:
(WebCore::parseAcceptAttribute): Use convertToASCIILowercase for the type here.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute): Use convertToASCIILowercase for the
media value here.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType): Use convertToASCIILowercase for the
content type here.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Use convertToASCIILowercase for
the service type here.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Use convertToASCIILowercase for
the kind here.
(WebCore::HTMLTrackElement::ensureTrack): Ditto. Also use fastGetAttribute
since this is neither the style attribute nor an animatable SVG attribute.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::createCaseMap): Use convertToASCIILowercase for the local names here.
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchNode): Use containsIgnoringASCIICase instead
of combining lower with find == notFound here.
(WebCore::nodeName): Use convertToASCIILowercase here.
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementData): Use convertToASCIILowercase for node
name here.
- inspector/InspectorPageAgent.cpp:
(WebCore::createXHRTextDecoder): Remove a now-unneeded call to lower since
DOMImplementation::isXMLMIMEType now ignores ASCII case.
- inspector/InspectorStyleSheet.cpp:
(WebCore::lowercasePropertyName): Use convertToASCIILowercase for property
names here. Also use startsWith rather than a hand-written alternative.
(WebCore::InspectorStyle::populateAllProperties): Use the return value of
the add function to avoid doing a double hash table lookp.
(WebCore::InspectorStyle::styleWithProperties): Use convertToASCIILowercase
to lowercase the property name.
- inspector/NetworkResourcesData.cpp:
(WebCore::createOtherResourceTextDecoder): Remove unneeded call to lower since
DOMImplement::isXMLMIMEType now ignores ASCII case.
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest): Use convertToASCIILowercase
to lowercase the access control request header field value.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::mimeType): Use convertToASCIILowercase on the content type.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::languageIdentifier): Use convertToASCIILowercase on the language code.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open): Call parseWindowFeatures instead of using the
constructor for WindowFeatures.
(WebCore::DOMWindow::showModalDialog): Call parseDialogFeatures instead of
using the constructor for WindowFeatures.
- page/EventHandler.cpp:
(WebCore::findDropZone): Remove unneeded lowercasing and empty string checking,
and use the option SpaceSplitString already has to convert to lowercase.
(WebCore::EventHandler::handleAccessKey): Remove unneeded call to lower since
getElementByAccessKey now ignores case. Also tweaked coding style a bit.
- page/OriginAccessEntry.cpp:
(WebCore::OriginAccessEntry::OriginAccessEntry): Use convertToASCIILowercase
on the protocol and host.
(WebCore::OriginAccessEntry::matchesOrigin): Ditto.
- page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin): Remove unneeded call to lower since
SchemeRegistry now ignores ASCII case.
(WebCore::SecurityOrigin::SecurityOrigin): Use convertToASCIILowercase on
the protocol and host.
(WebCore::SecurityOrigin::setDomainFromDOM): Use convertToASCIILowercase on
the domain.
(WebCore::SecurityOrigin::canDisplay): Remove call to lower since SchemeRegistry
now ignores ASCII case and because this now uses equalIgnoringASCIICase in
one place that used to use exact matching.
- page/WindowFeatures.cpp: Refactored so this is now some helper functions
plus a struct rather than a class.
(WebCore::isSeparator): Renamed this and removed special handling for NUL.
(WebCore::parseWindowFeatures): Moved the code that was formerly in the
WindowFeatures constructor in here. Refactored the parsing into the
processFeaturesString function, shared with the functions in Document that
do the same kind of parsing. Removed the code that converts the entire string
to lowercase before parsing.
(WebCore::processFeaturesString): Moved the improved version of this function
here from Document.cpp; more efficient because it doesn't allocate strings.
(WebCore::setWindowFeature): Changed to be a function private to this file
with internal linkage. Use equalLettersIgnoringASCIICase so we no longer
rely on converting the string to lowercase before parsing.
(WebCore::parseDialogFeatures): Similar refactoring, but also changed all
the default handling to use Optional<> instead of default values.
(WebCore::boolFeature): Changed to use option and to ignore ASCII case.
(WebCore::floatFeature): Ditto.
(WebCore::parseDialogFeaturesMap): Removed the calls to lower, which are
not needed any more.
- page/WindowFeatures.h: Added default values for all the data members,
and removed all the functions from the WindowFeatures struct. Added the two
functions for parsing window and dialog features. Also added the
processFeaturesString function so we can share it with Document.cpp.
- platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): Use
equalLettersIgnoringASCIICase to ignore ASCII case.
- platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use a modern for loop,
and equalIgnoringASCIICase rather than calling lower.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load): Use convertToASCIILowercase on MIME type and
key system.
(WebCore::MediaPlayer::generateKeyRequest): Ditto.
(WebCore::MediaPlayer::addKey): Ditto.
(WebCore::MediaPlayer::cancelKeyRequest): Ditto.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon): Use
convertToASCIILowercase on vendor string.
- platform/gtk/MIMETypeRegistryGtk.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use a modern for loop,
and equalIgnoringASCIICase rather than calling lower.
- platform/mac/PasteboardMac.mm:
(WebCore::cocoaTypeFromHTMLClipboardType): Use convertToASCIILowercase
on the type. Also did a bit of renaming and tweaking the logic.
Source/WTF:
- wtf/text/StringView.h:
(WTF::StringView::toInt): Added an overload without the out parameter.
- 1:54 PM Changeset in webkit [196079] by
-
- 18 edits1 copy1 move11 adds in trunk/LayoutTests/imported/w3c
Re-sync W3C DOM web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=153831
Reviewed by Darin Adler.
Re-sync W3C DOM web-platform-tests from:
https://github.com/w3c/web-platform-tests/tree/master/dom
- web-platform-tests/dom/collections/domstringmap-supported-property-names-expected.txt: Added.
- web-platform-tests/dom/collections/domstringmap-supported-property-names.html: Added.
- web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt: Added.
- web-platform-tests/dom/collections/namednodemap-supported-property-names.html: Added.
- web-platform-tests/dom/collections/w3c-import.log:
- web-platform-tests/dom/events/Event-dispatch-propagation-stopped-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-propagation-stopped.html: Added.
- web-platform-tests/dom/events/w3c-import.log:
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/historical.html:
- web-platform-tests/dom/interface-objects-expected.txt:
- web-platform-tests/dom/interface-objects.html:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/interfaces.html:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
- web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
- web-platform-tests/dom/nodes/Element-classlist-expected.txt:
- web-platform-tests/dom/nodes/Element-classlist.html:
- web-platform-tests/dom/nodes/Node-contains-xhtml-expected.txt: Added.
- web-platform-tests/dom/nodes/Node-contains-xhtml.xhtml: Added.
- web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt:
- web-platform-tests/dom/nodes/Node-isEqualNode-xhtml-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt.
- web-platform-tests/dom/nodes/Node-isEqualNode-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode.xhtml.
- web-platform-tests/dom/nodes/Node-isEqualNode.html: Added.
- web-platform-tests/dom/nodes/attributes-expected.txt:
- web-platform-tests/dom/nodes/attributes.html:
- web-platform-tests/dom/nodes/w3c-import.log:
- web-platform-tests/dom/ranges/Range-constructor-expected.txt: Added.
- web-platform-tests/dom/ranges/Range-constructor.html: Added.
- web-platform-tests/dom/ranges/w3c-import.log:
- web-platform-tests/dom/w3c-import.log:
- 1:26 PM Changeset in webkit [196078] by
-
- 2 edits in trunk/LayoutTests
Skip http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html on ios-simulator until it can be rewritten.
https://bugs.webkit.org/show_bug.cgi?id=152993
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:21 PM Changeset in webkit [196077] by
-
- 13 edits in trunk
[GTK][EFL] Switch FTL to B3
https://bugs.webkit.org/show_bug.cgi?id=153478
Reviewed by Csaba Osztrogonác.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
Source/JavaScriptCore:
Conditionalize code to make it possible to build FTL completely without LLVM.
- CMakeLists.txt:
- dfg/DFGCommon.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
(JSC::FTL::State::~State):
Source/WTF:
Enable B3 by default on all x86.
- wtf/Platform.h:
- 1:10 PM Changeset in webkit [196076] by
-
- 2 edits in trunk/Source/WebInspectorUI
Add hanging-punctuation property to Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=153841
Reviewed by Zalan Bujtas.
- UserInterface/Models/CSSKeywordCompletions.js:
- 12:54 PM Changeset in webkit [196075] by
-
- 14 edits3 adds in trunk
Implement hanging-punctuation property parsing.
https://bugs.webkit.org/show_bug.cgi?id=18109.
Reviewed by Zalan Bujtas.
Source/WebCore:
Added parsing test in fast/css.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderEmphasisPositionFlagsToCSSValue):
(WebCore::hangingPunctuationToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent):
(WebCore::CSSParser::parseHangingPunctuation):
(WebCore::CSSParser::parseLineBoxContain):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator HangingPunctuation):
(WebCore::CSSPrimitiveValue::operator LineBreak):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertRegionBreakInside):
(WebCore::StyleBuilderConverter::convertHangingPunctuation):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
(WebCore::operator| ):
(WebCore::operator|= ):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
LayoutTests:
- fast/css/parsing-hanging-punctuation-expected.txt: Added.
- fast/css/parsing-hanging-punctuation.html: Added.
- fast/css/resources/parsing-hanging-punctuation.js: Added.
(test):
- 12:15 PM Changeset in webkit [196074] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception TimelineRuler.prototype.resize no longer exists
https://bugs.webkit.org/show_bug.cgi?id=153839
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-03
Reviewed by Brian Burg.
- UserInterface/Views/MemoryTimelineView.js:
(WebInspector.MemoryTimelineView.prototype.shown):
After r195995 the resize method was eliminated in favor of this approach.
- 12:14 PM Changeset in webkit [196073] by
-
- 2 edits in branches/safari-601-branch/Source/WebKit2
Update WebKit2.framework copyright string to include 2016.
This framework no longer exists on trunk, so we missed this as part of the merge of r194479.
- mac/Info-WebKit2.plist:
- 10:58 AM Changeset in webkit [196072] by
-
- 2 edits in trunk/Source/WebKit2
Use proposed credentials in authentication challenges with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153811
Reviewed by Darin Adler.
This fixes http/tests/xmlhttprequest/basic-auth-default.html
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
Use the proposed credential if there is one. This matches behavior in
ResourceHandle::tryHandlePasswordBasedAuthentication.
- 10:21 AM Changeset in webkit [196071] by
-
- 2 edits in trunk/Source/WTF
Fix BlockPtr's call operator
https://bugs.webkit.org/show_bug.cgi?id=153836
Reviewed by Enrica Casucci.
- wtf/BlockPtr.h:
- 9:59 AM Changeset in webkit [196070] by
-
- 7 edits in trunk/Source
Build fix.
[NSEvent context] has always returned nil. Replace uses with nullptr.
Source/WebCore:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _updateMouseoverWithEvent:]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView draggedImage:endedAt:operation:]):
Source/WebKit2:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- 9:51 AM Changeset in webkit [196069] by
-
- 2 edits in trunk/LayoutTests
Skip fast/forms/input-user-input-sanitization.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152306
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 9:49 AM Changeset in webkit [196068] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Engineering builds use manual sandboxing, but don’t need to
https://bugs.webkit.org/show_bug.cgi?id=153834
Reviewed by Anders Carlsson.
Now that engineering builds use the non-re-execing variant of XPC services, they can be
statically sandboxed and no longer need to be manually sandboxed.
- Configurations/DebugRelease.xcconfig: Don’t set WK_MANUAL_SANDBOXING_ENABLED to YES.
- WebKit2.xcodeproj/project.pbxproj: Let Xcode make changes to the built product references.
- 9:09 AM Changeset in webkit [196067] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r195555.
Temporarily disable speculative revalidation to measure the
impact on the bots
Reverted changeset:
"[WK2][NetworkCache] Enable speculative revalidation"
https://bugs.webkit.org/show_bug.cgi?id=153443
http://trac.webkit.org/changeset/195555
- 8:34 AM Changeset in webkit [196066] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r194660): Legacy WebProcess crashes in ChildProcess::initializeSandbox()
https://bugs.webkit.org/show_bug.cgi?id=153734
<rdar://problem/24433179>
Reviewed by Dan Bernstein.
Fixes an issue where clients that used the legacy WebProcess bootstrapping process would crash.
Additionally, only consider the extra initialization parameter user-directory-suffix for
unsigned apps (e.g. WebKitTestRunner).
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox):
- 3:38 AM Changeset in webkit [196065] by
-
- 6 edits in trunk/Tools
[webkitdirs] Clarify logic behind is{PortName} functions.
https://bugs.webkit.org/show_bug.cgi?id=153554
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-03
Reviewed by Michael Catanzaro.
- Scripts/webkitdirs.pm:
(prohibitUnknownPort): This function makes determinePortName()
failure fatal.
(determinePortName): Added new function which decides which port are
we building based on command line switches and platform defaults.
(portName): Added getter for determined $portName.
(isEfl): Modified to use portName().
(isGtk): Ditto.
(isWinCairo): Ditto.
(isAppleMacWebKit): Ditto.
(isAppleWinWebKit): Ditto.
(isIOSWebKit): Ditto.
(cmakeBasedPortName): Return portName() with capitalized first letter.
(determineIsEfl): Deleted.
(determineIsGtk): Deleted.
(determineIsWinCairo): Deleted.
- Scripts/build-jsc: Call prohibitUnknownPort().
- Scripts/run-minibrowser: Ditto.
- Scripts/webkitperl/FeatureList.pm: Ditto.
- Scripts/update-webkit: Call determinePortName() instead of
determineIsWinCairo().
- 3:29 AM Changeset in webkit [196064] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed speculative buildfix after r195979.
- PlatformMac.cmake:
- 3:13 AM Changeset in webkit [196063] by
-
- 254 edits in trunk/LayoutTests
Unreviewed. EFL gardening: rebaseline tests after r195740.
- platform/efl/css1/box_properties/border_width_inline-expected.txt:
- platform/efl/css1/formatting_model/floating_elements-expected.txt:
- platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/efl/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
- platform/efl/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
- platform/efl/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/efl/css2.1/t0805-c5522-brdr-02-e-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
- platform/efl/css3/css3-modsel-33-expected.txt:
- platform/efl/css3/flexbox/flexbox-baseline-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-18b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-28-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-28b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-43-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-43b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-44-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-44b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-74-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-74b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-78-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-78b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-18b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-28-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-28b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-32-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-43-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-44-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-44b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-74-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-74b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-78-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-78b-expected.txt:
- platform/efl/editing/inserting/5058163-1-expected.txt:
- platform/efl/editing/inserting/insert-paragraph-01-expected.txt:
- platform/efl/editing/inserting/insert-paragraph-02-expected.txt:
- platform/efl/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/efl/editing/selection/4818145-expected.txt:
- platform/efl/editing/selection/4889598-expected.txt:
- platform/efl/editing/selection/4895428-2-expected.txt:
- platform/efl/editing/selection/5076323-1-expected.txt:
- platform/efl/editing/selection/5076323-2-expected.txt:
- platform/efl/editing/selection/5076323-3-expected.txt:
- platform/efl/editing/selection/7152-1-expected.txt:
- platform/efl/editing/selection/7152-2-expected.txt:
- platform/efl/editing/selection/display-table-text-expected.txt:
- platform/efl/editing/selection/iframe-expected.txt:
- platform/efl/editing/selection/inline-table-expected.txt:
- platform/efl/editing/selection/mixed-editability-3-expected.txt:
- platform/efl/editing/selection/mixed-editability-4-expected.txt:
- platform/efl/editing/selection/mixed-editability-5-expected.txt:
- platform/efl/editing/selection/mixed-editability-8-expected.txt:
- platform/efl/editing/selection/mixed-editability-9-expected.txt:
- platform/efl/editing/selection/table-caret-1-expected.txt:
- platform/efl/editing/selection/table-caret-2-expected.txt:
- platform/efl/editing/selection/table-caret-3-expected.txt:
- platform/efl/editing/style/5017613-1-expected.txt:
- platform/efl/editing/style/5017613-2-expected.txt:
- platform/efl/editing/style/apple-style-editable-mix-expected.txt:
- platform/efl/editing/style/table-selection-expected.txt:
- platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/efl/fast/block/float/011-expected.txt:
- platform/efl/fast/block/margin-collapse/001-expected.txt:
- platform/efl/fast/block/margin-collapse/005-expected.txt:
- platform/efl/fast/block/margin-collapse/104-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/efl/fast/block/positioning/053-expected.txt:
- platform/efl/fast/borders/bidi-009a-expected.txt:
- platform/efl/fast/box-shadow/basic-shadows-expected.txt:
- platform/efl/fast/css-generated-content/015-expected.txt:
- platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
- platform/efl/fast/css-generated-content/table-before-after-child-add-expected.txt:
- platform/efl/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/efl/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
- platform/efl/fast/css-generated-content/table-row-before-after-expected.txt:
- platform/efl/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
- platform/efl/fast/css/first-letter-float-expected.txt:
- platform/efl/fast/dynamic/007-expected.txt:
- platform/efl/fast/dynamic/014-expected.txt:
- platform/efl/fast/dynamic/015-expected.txt:
- platform/efl/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
- platform/efl/fast/forms/button-white-space-expected.txt:
- platform/efl/fast/forms/file/file-input-direction-expected.txt:
- platform/efl/fast/forms/form-added-to-table-expected.txt:
- platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/efl/fast/forms/input-value-expected.txt:
- platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/efl/fast/invalid/td-inside-object-expected.txt:
- platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/efl/fast/overflow/overflow-auto-table-expected.txt:
- platform/efl/fast/replaced/width100percent-button-expected.txt:
- platform/efl/fast/ruby/ruby-inline-table-expected.txt:
- platform/efl/fast/selectors/018-expected.txt:
- platform/efl/fast/selectors/018b-expected.txt:
- platform/efl/fast/selectors/032-expected.txt:
- platform/efl/fast/selectors/043-expected.txt:
- platform/efl/fast/selectors/043b-expected.txt:
- platform/efl/fast/selectors/044-expected.txt:
- platform/efl/fast/selectors/044b-expected.txt:
- platform/efl/fast/selectors/078b-expected.txt:
- platform/efl/fast/table/001-expected.txt:
- platform/efl/fast/table/004-expected.txt:
- platform/efl/fast/table/006-expected.txt:
- platform/efl/fast/table/010-expected.txt:
- platform/efl/fast/table/011-expected.txt:
- platform/efl/fast/table/015-expected.txt:
- platform/efl/fast/table/016-expected.txt:
- platform/efl/fast/table/022-expected.txt:
- platform/efl/fast/table/026-expected.txt:
- platform/efl/fast/table/033-expected.txt:
- platform/efl/fast/table/035-expected.txt:
- platform/efl/fast/table/035-vertical-expected.txt:
- platform/efl/fast/table/037-expected.txt:
- platform/efl/fast/table/041-expected.txt:
- platform/efl/fast/table/auto-with-percent-height-expected.txt:
- platform/efl/fast/table/auto-with-percent-height-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/efl/fast/table/cell-coalescing-expected.txt:
- platform/efl/fast/table/cellindex-expected.txt:
- platform/efl/fast/table/colgroup-preceded-by-caption-expected.txt:
- platform/efl/fast/table/colgroup-spanning-groups-rules-expected.txt:
- platform/efl/fast/table/dynamic-descendant-percentage-height-expected.txt:
- platform/efl/fast/table/floating-th-expected.txt:
- platform/efl/fast/table/generated-caption-expected.txt:
- platform/efl/fast/table/insert-before-anonymous-ancestors-expected.txt:
- platform/efl/fast/table/insert-cell-before-form-expected.txt:
- platform/efl/fast/table/insert-row-before-form-expected.txt:
- platform/efl/fast/table/multiple-captions-display-expected.txt:
- platform/efl/fast/table/nested-percent-height-table-expected.txt:
- platform/efl/fast/table/quote-text-around-iframe-expected.txt:
- platform/efl/fast/table/rowindex-expected.txt:
- platform/efl/fast/table/rtl-cell-display-none-assert-expected.txt:
- platform/efl/fast/table/rules-attr-dynchange1-expected.txt:
- platform/efl/fast/table/rules-attr-dynchange2-expected.txt:
- platform/efl/fast/table/table-after-child-in-table-expected.txt:
- platform/efl/fast/table/table-and-parts-outline-expected.txt:
- platform/efl/fast/table/table-before-child-in-table-expected.txt:
- platform/efl/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/efl/fast/table/table-cell-after-child-in-table-expected.txt:
- platform/efl/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/efl/fast/table/table-continuation-outline-paint-crash-expected.txt:
- platform/efl/fast/table/table-hspace-align-center-expected.txt:
- platform/efl/fast/table/table-row-after-child-in-block-expected.txt:
- platform/efl/fast/table/table-row-after-child-in-table-expected.txt:
- platform/efl/fast/table/table-row-before-child-in-block-expected.txt:
- platform/efl/fast/table/table-row-before-child-in-table-expected.txt:
- platform/efl/fast/table/tableInsideCaption-expected.txt:
- platform/efl/fast/table/text-field-baseline-expected.txt:
- platform/efl/fast/table/unbreakable-images-quirk-expected.txt:
- platform/efl/fast/table/vertical-align-baseline-expected.txt:
- platform/efl/fast/text/basic/001-expected.txt:
- platform/efl/fast/text/basic/006-expected.txt:
- platform/efl/fast/text/basic/007-expected.txt:
- platform/efl/fast/text/capitalize-boundaries-expected.txt:
- platform/efl/fast/text/hyphenate-locale-expected.txt:
- platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/efl/fast/text/whitespace/024-expected.txt:
- platform/efl/fast/text/whitespace/027-expected.txt:
- platform/efl/fast/text/word-break-expected.txt:
- platform/efl/fast/transforms/transform-table-row-expected.txt:
- 3:04 AM Changeset in webkit [196062] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Reduce IPC traffic due to view state changes
https://bugs.webkit.org/show_bug.cgi?id=153745
Reviewed by Sergio Villar Senin.
Very often view state changes happen one after another in a very
short period of time, even in the same run loop iteration. For
example, when you switch to the web view window, the view is
focused and the active window flag changes as well. In that case
we are sending two messages to the web process and the page
updates its status according to the new flags in two steps. So, we
could group all state changes happening in the same run loop
iteration and notify about them all in the next iteration. This
also prevents unnecessary changes of state when we quickly go back
to a previous state, for example in focus follows mouse
configurations if you move the mouse outside the window and then
inside the window again quickly.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): Use
VirewState::Flags to keep the web view state instead of
boolean, and also to keep the flags that need to be updated. Use a
timer to update web view state flags.
(_WebKitWebViewBasePrivate::updateViewStateTimerFired): Call
WebPageProxy::viewStateDidChange() and reset the flags that need
to be updated.
(webkitWebViewBaseScheduleUpdateViewState): Update the flags that
need to be updated and schedule the timer if it's not active.
(toplevelWindowFocusInEvent): Use the flags and schedule an update.
(toplevelWindowFocusOutEvent): Ditto.
(toplevelWindowStateEvent): Also mark the view as hidden when minimized.
(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to
window-state-event instead of deprecated visibility-notify-event.
(webkitWebViewBaseMap): Use the flags and schedule an update.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseSetFocus): Ditto.
(webkitWebViewBaseIsInWindowActive): Use the flags.
(webkitWebViewBaseIsFocused): Ditto
(webkitWebViewBaseIsVisible): Ditto.
(webkitWebViewBaseIsInWindow): Removed this since it was unused.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- 2:37 AM Changeset in webkit [196061] by
-
- 4 edits in trunk
[GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
https://bugs.webkit.org/show_bug.cgi?id=145253
Reviewed by Michael Catanzaro.
Source/WebCore:
The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.
LayoutTests:
Update test expectation.
- platform/gtk/TestExpectations:
- 2:31 AM Changeset in webkit [196060] by
-
- 4 edits in trunk
REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797
Reviewed by Darin Adler.
Source/WebCore:
Always schedule messages to the main thread, even when the bus
sync handlder was called in the main thread. It seems that
GStreamer expects things to happen in the next main loop
iteration.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
LayoutTests:
Update test expectations.
- platform/gtk/TestExpectations:
- 1:56 AM Changeset in webkit [196059] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix incorrect ASSERT introduced in r196053.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePluginX11::paint): Ensure the plugin is not
windowed if paint() is called.
- 1:54 AM Changeset in webkit [196058] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] CompositingCoordinator should store the overlay layer, flush it as appropriate
https://bugs.webkit.org/show_bug.cgi?id=152058
Reviewed by Michael Catanzaro.
Previously, the CompositingCoordinator only added the overlay layer to the
layer tree, but flushing its compositing state is also required. For that to
happen, CompositingCoordinator has to store a pointer to the overlay layer
object and flush it in ::flushPendingLayerChanges().
Overlay layers are most prominently used by the Web Inspector to highlight
the DOM elements on the Web page that are being hovered in the inspector.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- 12:48 AM Changeset in webkit [196057] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix JavaScriptCore build with B3 enabled.
Include <limits.h> for UINT_MAX.
- b3/B3StackSlot.h:
- b3/air/AirStackSlot.h:
- 12:41 AM Changeset in webkit [196056] by
-
- 3 edits in trunk/Source/WebCore
[CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes
https://bugs.webkit.org/show_bug.cgi?id=153823
Reviewed by Carlos Garcia Campos.
Purging the backing stores during the CompositingCoordinator destructor
is also scheduling layer flushes in the object's client, which is an object
of the LayerTreeHost-deriving class that owns the CompositingCoordinator
object in question and is also being destroyed.
In case of ThreadedCoordinatedLayerTreeHost, this scheduling can access
the RunLoop::Timer object which has already been destroyed, causing a
crash. Another problem with this is that we're invoking a virtual function
on an object that's being destructed, which works well enough in this case
but should be discouraged in general.
In order to avoid this, add the m_isDestructing boolean to the
CompositingCoordinator class, flip it to true during the destruction,
and check for its falseness before scheduling a layer flush.
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::notifyFlushRequired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h:
- 12:34 AM Changeset in webkit [196055] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Don't use RELEASE_ASSERT in TextureMapperLayer::computeTransformsRecursive()
https://bugs.webkit.org/show_bug.cgi?id=153822
Reviewed by Carlos Garcia Campos.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
Use ASSERT to check that the m_children members are indeed children
of the current layer, RELEASE_ASSERT probably slipped in unnoticed
at some point.
- 12:33 AM Changeset in webkit [196054] by
-
- 2 edits in trunk/Source/WebCore
PlatformPathCairo: Lazily allocate the path surface
https://bugs.webkit.org/show_bug.cgi?id=153821
Reviewed by Carlos Garcia Campos.
Move the static variable that holds the Cairo surface into
the pathSurface() function (previously getPathSurface). This
way the surface will only be allocated once the function is
called for the first time from the CairoPath surface.
No change in functionality, just a cleanup.
- platform/graphics/cairo/PlatformPathCairo.cpp:
(WebCore::pathSurface):
(WebCore::CairoPath::CairoPath):
(WebCore::getPathSurface): Deleted.
- 12:18 AM Changeset in webkit [196053] by
-
- 9 edits3 adds in trunk/Source/WebKit2
[UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=151992
Reviewed by Darin Adler.
We are currently disabling all plugins when running under wayland,
for example. There are some plugins, like the one used by
extensions.gnome.org, that don't do any rendering, so there's not
reason not to support those plugins under wayland or any other
unix non-x11 platform.
X11 specific code has been moved to a new class NetscapePluginX11,
only used under X11. The common code is in NetscapePluginUnix.cpp
that will use the X11 implementatin only when needed and
available. For windowed plugins we will fail the initialization
under non-X11 plaforms, while for windowless plugins we will just
return early from paint method.
- PlatformEfl.cmake: Add new files to compilation.
- PlatformGTK.cmake: Ditto.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_set_enable_plugins): Do not disable plugins in wayland.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore): Ditto.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Use PlatformDisplay instead of
NetscapePlugin::x11HostDisplay() and don't claim to support X11
specific features under non-x11 platforms.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin): Remove X11 and GTK
specific memebers that are now moved to a dedicated class NetscapePluginX11.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(WebKit::NetscapePlugin::frameRectInWindowCoordinates): Make this public.
(WebKit::NetscapePlugin::clipRect): Add getter.
(WebKit::NetscapePlugin::size): Ditto.
(WebKit::NetscapePlugin::isWindowed): Ditto.
(WebKit::NetscapePlugin::isVisible): Ditto.
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp: Added.
(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformVisibilityDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h: Added.
(WebKit::NetscapePluginUnix::~NetscapePluginUnix):
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::displayDepth):
(WebKit::x11HostDisplay):
(WebKit::NetscapePluginX11::create):
(WebKit::NetscapePluginX11::NetscapePluginX11):
(WebKit::NetscapePluginX11::~NetscapePluginX11):
(WebKit::NetscapePluginX11::windowType):
(WebKit::NetscapePluginX11::window):
(WebKit::NetscapePluginX11::geometryDidChange):
(WebKit::NetscapePluginX11::visibilityDidChange):
(WebKit::NetscapePluginX11::paint):
(WebKit::initializeXEvent):
(WebKit::NetscapePluginX11::handleMouseEvent):
(WebKit::NetscapePluginX11::handleWheelEvent):
(WebKit::NetscapePluginX11::setFocus):
(WebKit::NetscapePluginX11::handleMouseEnterEvent):
(WebKit::NetscapePluginX11::handleMouseLeaveEvent):
(WebKit::NetscapePluginX11::handleKeyboardEvent):
(WebKit::setCommonMouseEventFields): Deleted.
(WebKit::setXKeyEventFields): Deleted.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h: Added.
Feb 2, 2016:
- 11:01 PM Changeset in webkit [196052] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result)
https://bugs.webkit.org/show_bug.cgi?id=153576
Patch by Fujii Hironori <Hironori.Fujii@jp.sony.com> on 2016-02-02
Reviewed by Darin Adler.
Source/WebCore:
Tests: fast/block/geometry-map-assertion-with-rounding-negative-half.html
The results of roundedIntPoint of FloatPoint and LayoutPoint may be different
because of the uniqueness of LayoutUnit::round introduced by this bug
<https://bugs.webkit.org/show_bug.cgi?id=107208>.
Should convert a FloatPoint to a LayoutPoint before rounding.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
LayoutTests:
- fast/block/geometry-map-assertion-with-rounding-negative-half-expected.txt: Added.
- fast/block/geometry-map-assertion-with-rounding-negative-half.html: Added.
- 10:34 PM Changeset in webkit [196051] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
JSSymbolTableObject::deleteProperty() crashes deleting Symbols
https://bugs.webkit.org/show_bug.cgi?id=153816
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.
Changes JSSymbolTableObject::deleteProperty() to check if its
symbolTable() contains the property's uid() rather than publicName().
This ensures that it will not crash in the case of Symbols.
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::deleteProperty):
- tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:
(testGlobalProxy):
- tests/stress/regress-153816.js: Added.
(deleteSymbolFromJSSymbolTableObject):
- 10:31 PM Changeset in webkit [196050] by
-
- 5 edits in tags/Safari-602.1.18.3/Source
Versioning.
- 10:28 PM Changeset in webkit [196049] by
-
- 1 copy in tags/Safari-602.1.18.3
New tag.
- 10:14 PM Changeset in webkit [196048] by
-
- 6 edits in trunk/Tools
Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
https://bugs.webkit.org/show_bug.cgi?id=153683
Reviewed by Darin Adler.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
used by any code in the Web Content process. If that ever changed, we should send it over
as a bundle parameter.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
- Scripts/webkitpy/port/mac.py:
(MacPort.setup_environ_for_server): Ditto.
- WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
(WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
environment. This is early enough that libxml2 has not been initialized yet.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Ditto.
- 10:06 PM Changeset in webkit [196047] by
-
- 2 edits in trunk/LayoutTests
Follow up for:
Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153732
- fast/viewport/viewport-warnings-7-expected.txt: Updated expected results now that
viewport parsing doesn't lowercase the string to parse it.
- 10:02 PM Changeset in webkit [196046] by
-
- 2 edits in trunk/Source/WebKit2
Remove ENABLE(GLOBAL_FASTMALLOC_NEW) guard in WebMemorySamplerLinux.cpp
https://bugs.webkit.org/show_bug.cgi?id=153812
Reviewed by Darin Adler.
r164261 already removed ENABLE_GLOBAL_FASTMALLOC_NEW guard though, WebMemorySamplerLinux
is still using it. That's why EFL and GTK memory sampler don't show fast malloc memory use.
- Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit): Deleted.
- 9:03 PM Changeset in webkit [196045] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Do not copy FP when lowering FramePointer
https://bugs.webkit.org/show_bug.cgi?id=153769
Reviewed by Michael Saboff.
That extra move is just wasted time. The fewer Moves we have,
the happier IRC is.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::lower):
- 8:53 PM Changeset in webkit [196044] by
-
- 12 edits in trunk/Source/JavaScriptCore
DFG, FTL, B3, and Air should all have a unique option for printing their graphs
https://bugs.webkit.org/show_bug.cgi?id=153815
Reviewed by Benjamin Poulain.
This patch adds a new printing option for each of the DFG/FTL compilation phases.
- b3/B3Common.cpp:
(JSC::B3::shouldDumpIR):
(JSC::B3::shouldDumpIRAtEachPhase):
- b3/B3Common.h:
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3PhaseScope.cpp:
(JSC::B3::PhaseScope::PhaseScope):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::prepareForGeneration):
- b3/air/AirPhaseScope.cpp:
(JSC::B3::Air::PhaseScope::PhaseScope):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
- dfg/DFGCommon.h:
(JSC::DFG::shouldDumpGraphAtEachPhase):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- 8:32 PM Changeset in webkit [196043] by
-
- 630 edits in trunk/LayoutTests
Unreviewed. EFL gardening: rebaseline tests after r195740.
- platform/efl/fast/replaced/005-expected.txt:
- platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/efl/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/efl/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
- platform/efl/fast/replaced/width100percent-image-expected.txt:
- platform/efl/fast/replaced/width100percent-menulist-expected.txt:
- platform/efl/fast/replaced/width100percent-radio-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- platform/efl/fast/replaced/width100percent-textarea-expected.txt:
- platform/efl/fast/replaced/width100percent-textfield-expected.txt:
- platform/efl/fast/selectors/077-expected.txt:
- platform/efl/fast/selectors/077b-expected.txt:
- platform/efl/fast/table/002-expected.txt:
- platform/efl/fast/table/003-expected.txt:
- platform/efl/fast/table/005-expected.txt:
- platform/efl/fast/table/007-expected.txt:
- platform/efl/fast/table/008-expected.txt:
- platform/efl/fast/table/009-expected.txt:
- platform/efl/fast/table/012-expected.txt:
- platform/efl/fast/table/013-expected.txt:
- platform/efl/fast/table/021-expected.txt:
- platform/efl/fast/table/023-expected.txt:
- platform/efl/fast/table/024-expected.txt:
- platform/efl/fast/table/025-expected.txt:
- platform/efl/fast/table/028-expected.txt:
- platform/efl/fast/table/028-vertical-expected.txt:
- platform/efl/fast/table/029-expected.txt:
- platform/efl/fast/table/031-expected.txt:
- platform/efl/fast/table/032-expected.txt:
- platform/efl/fast/table/034-expected.txt:
- platform/efl/fast/table/038-expected.txt:
- platform/efl/fast/table/038-vertical-expected.txt:
- platform/efl/fast/table/039-expected.txt:
- platform/efl/fast/table/040-expected.txt:
- platform/efl/fast/table/040-vertical-expected.txt:
- platform/efl/fast/table/100-percent-cell-width-expected.txt:
- platform/efl/fast/table/add-before-anonymous-child-expected.txt:
- platform/efl/fast/table/border-collapsing/001-expected.txt:
- platform/efl/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/002-expected.txt:
- platform/efl/fast/table/border-collapsing/003-expected.txt:
- platform/efl/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/004-expected.txt:
- platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/bug14274-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/efl/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/efl/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/efl/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/efl/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/efl/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
- platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/efl/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/efl/fast/table/caption-relayout-expected.txt:
- platform/efl/fast/table/cell-absolute-child-expected.txt:
- platform/efl/fast/table/cell-width-auto-expected.txt:
- platform/efl/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/efl/fast/table/colspanMinWidth-expected.txt:
- platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/efl/fast/table/dynamic-cellpadding-expected.txt:
- platform/efl/fast/table/edge-offsets-expected.txt:
- platform/efl/fast/table/empty-cells-expected.txt:
- platform/efl/fast/table/frame-and-rules-expected.txt:
- platform/efl/fast/table/giantRowspan-expected.txt:
- platform/efl/fast/table/growCellForImageQuirk-expected.txt:
- platform/efl/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/efl/fast/table/height-percent-test-expected.txt:
- platform/efl/fast/table/height-percent-test-vertical-expected.txt:
- platform/efl/fast/table/invisible-cell-background-expected.txt:
- platform/efl/fast/table/large-width-expected.txt:
- platform/efl/fast/table/max-width-integer-overflow-expected.txt:
- platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/efl/fast/table/nobr-expected.txt:
- platform/efl/fast/table/overflowHidden-expected.txt:
- platform/efl/fast/table/percent-heights-expected.txt:
- platform/efl/fast/table/percent-widths-stretch-expected.txt:
- platform/efl/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/efl/fast/table/relative-position-containment-expected.txt:
- platform/efl/fast/table/relative-position-offsets-expected.txt:
- platform/efl/fast/table/relative-position-stacking-expected.txt:
- platform/efl/fast/table/replaced-percent-height-expected.txt:
- platform/efl/fast/table/row-height-recalc-expected.txt:
- platform/efl/fast/table/rowspan-paint-order-expected.txt:
- platform/efl/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/efl/fast/table/simple_paint-expected.txt:
- platform/efl/fast/table/spanOverlapRepaint-expected.txt:
- platform/efl/fast/table/stale-grid-crash-expected.txt:
- platform/efl/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/efl/fast/table/table-anonymous-row-bug-expected.txt:
- platform/efl/fast/table/table-anonymous-section-bug-expected.txt:
- platform/efl/fast/table/table-before-child-style-update-expected.txt:
- platform/efl/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/efl/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/efl/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/efl/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/efl/fast/table/table-cell-split-expected.txt:
- platform/efl/fast/table/table-display-types-expected.txt:
- platform/efl/fast/table/table-display-types-strict-expected.txt:
- platform/efl/fast/table/table-display-types-vertical-expected.txt:
- platform/efl/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/efl/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/efl/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/efl/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/efl/fast/table/table-row-before-child-style-update-expected.txt:
- platform/efl/fast/table/table-row-outline-paint-expected.txt:
- platform/efl/fast/table/table-row-split2-expected.txt:
- platform/efl/fast/table/table-row-style-not-updated-expected.txt:
- platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/efl/fast/table/table-section-split2-expected.txt:
- platform/efl/fast/table/table-split-expected.txt:
- platform/efl/fast/table/table-split2-expected.txt:
- platform/efl/fast/table/table-style-not-updated-expected.txt:
- platform/efl/fast/table/wide-colspan-expected.txt:
- platform/efl/fast/table/wide-column-expected.txt:
- platform/efl/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/efl/fast/text/atsui-spacing-features-expected.txt:
- platform/efl/fast/text/basic/generic-family-reset-expected.txt:
- platform/efl/fast/text/international/003-expected.txt:
- platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/efl/fast/text/international/bidi-override-expected.txt:
- platform/efl/fast/text/wbr-expected.txt:
- platform/efl/fast/text/whitespace/002-expected.txt:
- platform/efl/fast/text/whitespace/003-expected.txt:
- platform/efl/fast/text/whitespace/004-expected.txt:
- platform/efl/fast/text/whitespace/005-expected.txt:
- platform/efl/fast/text/whitespace/010-expected.txt:
- platform/efl/fast/text/whitespace/011-expected.txt:
- platform/efl/fast/text/whitespace/013-expected.txt:
- platform/efl/fast/text/whitespace/014-expected.txt:
- platform/efl/fast/text/whitespace/015-expected.txt:
- platform/efl/fast/text/whitespace/016-expected.txt:
- platform/efl/fast/text/whitespace/025-expected.txt:
- platform/efl/fast/text/whitespace/026-expected.txt:
- platform/efl/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/efl/http/tests/misc/acid2-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
- platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/efl/tables/layering/paint-test-layering-1-expected.txt:
- platform/efl/tables/layering/paint-test-layering-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10009-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10036-expected.txt:
- platform/efl/tables/mozilla/bugs/bug101201-expected.txt:
- platform/efl/tables/mozilla/bugs/bug101674-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10565-expected.txt:
- platform/efl/tables/mozilla/bugs/bug10633-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug106795-expected.txt:
- platform/efl/tables/mozilla/bugs/bug106816-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113424-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1188-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12008-expected.txt:
- platform/efl/tables/mozilla/bugs/bug120107-expected.txt:
- platform/efl/tables/mozilla/bugs/bug120364-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1224-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12268-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12709-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1271-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1296-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1302-expected.txt:
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
- platform/efl/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug137388-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1430-expected.txt:
- platform/efl/tables/mozilla/bugs/bug14323-expected.txt:
- platform/efl/tables/mozilla/bugs/bug14929-expected.txt:
- platform/efl/tables/mozilla/bugs/bug15247-expected.txt:
- platform/efl/tables/mozilla/bugs/bug154780-expected.txt:
- platform/efl/tables/mozilla/bugs/bug15544-expected.txt:
- platform/efl/tables/mozilla/bugs/bug159108-expected.txt:
- platform/efl/tables/mozilla/bugs/bug15933-expected.txt:
- platform/efl/tables/mozilla/bugs/bug16012-expected.txt:
- platform/efl/tables/mozilla/bugs/bug16252-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17587-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1800-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1802-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/efl/tables/mozilla/bugs/bug1809-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18440-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18664-expected.txt:
- platform/efl/tables/mozilla/bugs/bug18955-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug19356-expected.txt:
- platform/efl/tables/mozilla/bugs/bug20804-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2123-expected.txt:
- platform/efl/tables/mozilla/bugs/bug215629-expected.txt:
- platform/efl/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22019-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug222336-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/efl/tables/mozilla/bugs/bug22513-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2296-expected.txt:
- platform/efl/tables/mozilla/bugs/bug23235-expected.txt:
- platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25004-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25074-expected.txt:
- platform/efl/tables/mozilla/bugs/bug25663-expected.txt:
- platform/efl/tables/mozilla/bugs/bug26553-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2684-expected.txt:
- platform/efl/tables/mozilla/bugs/bug269566-expected.txt:
- platform/efl/tables/mozilla/bugs/bug277062-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2773-expected.txt:
- platform/efl/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2886-expected.txt:
- platform/efl/tables/mozilla/bugs/bug28933-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29314-expected.txt:
- platform/efl/tables/mozilla/bugs/bug29429-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2954-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug2997-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30273-expected.txt:
- platform/efl/tables/mozilla/bugs/bug30559-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3103-expected.txt:
- platform/efl/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3260-expected.txt:
- platform/efl/tables/mozilla/bugs/bug33137-expected.txt:
- platform/efl/tables/mozilla/bugs/bug33855-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3454-expected.txt:
- platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
- platform/efl/tables/mozilla/bugs/bug3977-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4093-expected.txt:
- platform/efl/tables/mozilla/bugs/bug42187-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4385-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4427-expected.txt:
- platform/efl/tables/mozilla/bugs/bug44505-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4501-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
- platform/efl/tables/mozilla/bugs/bug45350-expected.txt:
- platform/efl/tables/mozilla/bugs/bug45486-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4576-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug47432-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4803-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug4849-expected.txt:
- platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5188-expected.txt:
- platform/efl/tables/mozilla/bugs/bug52505-expected.txt:
- platform/efl/tables/mozilla/bugs/bug52506-expected.txt:
- platform/efl/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug53891-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5538-expected.txt:
- platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
- platform/efl/tables/mozilla/bugs/bug56201-expected.txt:
- platform/efl/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5797-expected.txt:
- platform/efl/tables/mozilla/bugs/bug5835-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60804-expected.txt:
- platform/efl/tables/mozilla/bugs/bug60807-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6184-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6404-expected.txt:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6674-expected.txt:
- platform/efl/tables/mozilla/bugs/bug68998-expected.txt:
- platform/efl/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug72359-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7342-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
- platform/efl/tables/mozilla/bugs/bug78162-expected.txt:
- platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug86708-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8950-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug92143-expected.txt:
- platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug963-expected.txt:
- platform/efl/tables/mozilla/bugs/bug96334-expected.txt:
- platform/efl/tables/mozilla/bugs/bug97383-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/borders-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/core/col_span-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/efl/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/efl/tables/mozilla/core/margins-expected.txt:
- platform/efl/tables/mozilla/core/misc-expected.txt:
- platform/efl/tables/mozilla/core/nested1-expected.txt:
- platform/efl/tables/mozilla/core/one_row-expected.txt:
- platform/efl/tables/mozilla/core/table_frame-expected.txt:
- platform/efl/tables/mozilla/core/table_heights-expected.txt:
- platform/efl/tables/mozilla/core/table_rules-expected.txt:
- platform/efl/tables/mozilla/core/table_widths-expected.txt:
- platform/efl/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/efl/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols1-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols2-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols3-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols4-expected.txt:
- platform/efl/tables/mozilla/dom/insertCols5-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/efl/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/efl/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/efl/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_cellpadding-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_width_percent-expected.txt:
- platform/efl/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/efl/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/efl/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/efl/tables/mozilla/other/cell_widths-expected.txt:
- platform/efl/tables/mozilla/other/ms-expected.txt:
- platform/efl/tables/mozilla/other/nested2-expected.txt:
- platform/efl/tables/mozilla/other/nestedTables-expected.txt:
- platform/efl/tables/mozilla/other/slashlogo-expected.txt:
- platform/efl/tables/mozilla/other/test3-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/efl/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/efl/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/efl/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/efl/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
- 8:22 PM Changeset in webkit [196042] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
https://bugs.webkit.org/show_bug.cgi?id=153814
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Yusuke Suzuki.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptors):
- tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:
(testGlobalProxy):
- 8:16 PM Changeset in webkit [196041] by
-
- 4 edits1 delete in trunk/Source
Remove references to CallFrameInlines.h
https://bugs.webkit.org/show_bug.cgi?id=153810
Reviewed by Mark Lam.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
Source/WebCore:
- ForwardingHeaders/interpreter/CallFrameInlines.h: Removed.
- 7:17 PM Changeset in webkit [196040] by
-
- 7 edits2 adds in trunk
[JSC] Implement Object.getOwnPropertyDescriptors() proposal
https://bugs.webkit.org/show_bug.cgi?id=153799
Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implements the Object.getOwnPropertyDescriptors() proposal, which
reached Stage 3 in the TC39 process in January 2016.
https://github.com/tc39/proposal-object-getownpropertydescriptors
The method extracts a set of property descriptor objects, which can
be safely used viaObject.create().
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetOwnPropertyDescriptors):
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- 6:27 PM Changeset in webkit [196039] by
-
- 3 edits in trunk/Source/WebCore
WEBGL_debug_shaders should be disabled for OpenGLES backend also
https://bugs.webkit.org/show_bug.cgi?id=153788
Reviewed by Darin Adler.
WEBGL_debug_shaders extension is disabled for OpenGL backed platform
because the implementation is not fully compliant to the spec yet.
Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
should be disabled for OpenGLES backed platforms also.
No new tests, already covered by existing tests.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Deleted.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::supports):
- 4:12 PM Changeset in webkit [196038] by
-
- 5 edits in trunk
Modern IDB: storage/indexeddb/cursor-primary-key-order.html fails with SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153800
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing tests now unskipped).
The IndexRecords SQL schema did not order things by primaryKey.
Easy fix to the schema. Sadly requires a migration...
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::v1IndexRecordsTableSchema):
(WebCore::IDBServer::v1IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::v2IndexRecordsTableSchema):
(WebCore::IDBServer::v2IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 4:09 PM Changeset in webkit [196037] by
-
- 3 edits in trunk/Source/WebKit2
Provide handleKeyWebEvent with completion handler.
https://bugs.webkit.org/show_bug.cgi?id=153806
rdar://problem/24399218
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
- 4:08 PM Changeset in webkit [196036] by
-
- 5 edits2 adds in trunk
<attachment> should attempt to guess the icon from the file extension if all else fails
https://bugs.webkit.org/show_bug.cgi?id=153804
<rdar://problem/24448146>
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/attachment/attachment-icon-from-file-extension.html
- platform/graphics/Icon.h:
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::createIconForFileExtension):
- rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
If we can't find an icon any other way, try assuming that the title is a filename,
grab its extension, and have NSWorkspace try to work out an icon for it.
LayoutTests:
- fast/attachment/attachment-icon-from-file-extension-expected.html: Added.
- fast/attachment/attachment-icon-from-file-extension.html: Added.
- 3:46 PM Changeset in webkit [196035] by
-
- 4 edits in trunk/Source/JavaScriptCore
B3 should be able to compile trivial self-loops
https://bugs.webkit.org/show_bug.cgi?id=153802
rdar://problem/24465632
Reviewed by Michael Saboff.
Tail-duplicating a self-loop would mean doing a kind of loop unrolling. It wouldn't be
profitable even if it did work. It turns out that it doesn't work, because we edit the target
block before reading the source block, which breaks if the target and source block are the
same.
This disables tail duplication of self-loops, adds a test, and adds better validation for this
issue.
- b3/B3DuplicateTails.cpp:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::resetReachability):
- b3/testb3.cpp:
(JSC::B3::testComputeDivisionMagic):
(JSC::B3::testTrivialInfiniteLoop):
(JSC::B3::zero):
(JSC::B3::run):
- 3:42 PM Changeset in webkit [196034] by
-
- 6 edits in trunk/Source/WebKit2
Fix authentication with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153779
Reviewed by Brady Eidson.
This fixes many tests, including http/tests/xmlhttprequest/cross-origin-authorization.html.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
NetworkingContexts are not used with NetworkSession. NetworkSession is used instead.
Pass allowStoredCredentials to the NetworkLoad so it knows whether to use a session with credential storage or not.
(WebKit::NetworkLoad::didReceiveChallenge):
Always call continueCanAuthenticateAgainstProtectionSpace because we might need credentials for synchronous requests.
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
Reject the protection space if we cannot authenticate against this protection space.
If the protection space is not password-based (such as ServerTrustEvaluationRequested) and we can authenticate against this protection space,
then perform default handling instead of asking the UI process for a password, which wouldn't mean anything.
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkSession.h:
Use a NSURLSession with configuration.URLCredentialStorage = nil but with the same cookie storage for requests without credentials.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
Always send a reply message so we can always do the callbacks of NSURLSession delegates.
- 3:26 PM Changeset in webkit [196033] by
-
- 11 edits in trunk
[ES6] bound functions .name property should be "bound " + the target function's name
https://bugs.webkit.org/show_bug.cgi?id=153796
Reviewed by Mark Lam.
Source/JavaScriptCore:
See http://tc39.github.io/ecma262/#sec-function.prototype.bind for details.
What the spec says:
`
function foo() { }
foo.bind(null).name === "bound foo"
(function bar() { }).bind(null).name === "bound bar"
`
- runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
- runtime/JSBoundFunction.cpp:
(JSC::hasInstanceBoundFunction):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::visitChildren):
(JSC::JSBoundFunction::toStringName):
- runtime/JSBoundFunction.h:
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):
- tests/es6.yaml:
LayoutTests:
- inspector/runtime/getProperties-expected.txt:
- platform/mac/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt:
- platform/mac/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt:
- platform/mac/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt:
- platform/mac/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt:
- 3:21 PM Changeset in webkit [196032] by
-
- 62 edits2 moves5 adds in trunk
Get rid of anonymous stack slots
https://bugs.webkit.org/show_bug.cgi?id=151128
Reviewed by Mark Lam.
Source/JavaScriptCore:
When I first designed stack slots, the idea was that an "anonymous" stack slot was one that
behaved exactly like a C variable: if it never escaped, it would not need to get stack space
for the entire lifetime of the function - it could get any slab of stack so long as it
didn't interfere with other stack slots that would be live at the same time. The reason I
called them "anonymous" is that external code could not get its address. This felt like it
gave the stack slot anonymity. But it was never a good name for this concept.
Then I had the register allocator lower temporaries to anonymous stack slots when it spilled
them. Spilling became the sole client of anonymous stack slots.
Then I realized that there was an aspect of how spill slots work that make them want
slightly different semantics than a normal C variable. A C variable is a proper memory
location - you could do a store to only some bytes in the variable, and it's reasonable to
expect that this will not destroy the other bytes in the variable. But that means that to
compute their liveness, you have to do something like a per-byte liveness. That's overkill
for spill slots. You want any store to the spill slot to kill the whole slot even if it
writes to just part of the slot. This matches how temporaries work. So rather than implement
per-byte liveness, I decided to change the semantics of anonymous stack slots to make them
work like how I wanted spill slots to work. This was quite dirty, and put B3 in the awkward
situation that B3's anonymous stack slots behaved like spill slots. But it was OK since
nobody used anonymous stack slots in B3.
Then I added tail duplication, which required having a mechanism for introducing non-SSA
variables in B3. I decided to use anonymous stack slots for this purpose. All of a sudden
this all felt like it made sense: anonymous stack slots were just like variables! Hooray for
the amazing foresight of anonymous stack slots!
But then I realized that this was all very bad. We want B3 to be able to optimize Store and
Load operations by reasoning about how they affect bytes in memory. For example, if you do
a Load of a 64-bit value, and then you modify just the low 32 bits of that value, and then
you do a 64-bit store back to the same location, then it would be better to transform this
into 32-bit operations. We don't do this optimization yet, but it's the kind of thing that
we want B3 to be able to do. To do it, we need Store to mean that it only affects N bytes
starting at the pointer, where N is the size of the thing being stored. But that's not what
Store means for anonymous stack slots. For anonymous slots, storing to any byte in the slot
clobbers all bytes in the slot. We were never clear if you need to store directly to an
anonymous slot to get this behavior, or if any pointer that points to an anoymous slot must
exhibit this behavior when stored to. Neither kinds of semantics make sense to me.
This change fixes the problem by eradicating anonymous stack slots. In B3, they are replaced
with Variables. In Air, they are replaced with a different stack slot kind, called Spill.
There is no such thing as stack slot kinds in B3 anymore, all B3 stack slots are locked. In
Air, there is still the concept of stack slot kind - Locked or Spill.
B3 Variables are awesome. They are exactly what they seem to be. They have a type. They are
declared at the top level in the Procedure. You can access them with new opcodes, Get and
Set. This greatly simplifies demoting SSA values to variables and promoting them back to
SSA. I even made the instruction selector do the right things for variables, which means
that introducing variables won't hurt instruction selection (there will be extra moves, but
IRC will kill them). It's great to have non-SSA variables as an explicit concept in IR
because it means that you don't have to do any magic to use them - they Just Work.
Air spill slots behave almost like anonymous stack slots, with one exception: you cannot
escape them. We validate this by making it illegal to UseAddr on a spill slot. This removes
the need to answer awkward questions like: does a 32-bit Def on a pointer that may point to
a 64-bit spill slot do anything to the 32 bits above the pointer? Does it write zero to it?
Does it write zero to it just when the pointer actually points to a spill slot or always?
These are silly questions, and we don't have to answer them because the only way to refer to
a spill slot is directly. No escaping means no aliasing.
This doesn't affect performance. It just makes the compiler more fun to work with by
removing some cognitive dissonance.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ArgumentRegValue.h:
- b3/B3CCallValue.h:
- b3/B3CheckValue.cpp:
(JSC::B3::CheckValue::cloneImpl):
(JSC::B3::CheckValue::CheckValue):
- b3/B3CheckValue.h:
- b3/B3Const32Value.h:
- b3/B3Const64Value.h:
- b3/B3ConstDoubleValue.h:
- b3/B3ConstFloatValue.h:
- b3/B3ConstPtrValue.h:
(JSC::B3::ConstPtrValue::ConstPtrValue):
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::convertToOops):
(JSC::B3::ControlValue::dumpMeta):
- b3/B3ControlValue.h:
- b3/B3Effects.cpp:
(JSC::B3::Effects::interferes):
(JSC::B3::Effects::dump):
- b3/B3Effects.h:
(JSC::B3::Effects::mustExecute):
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/B3FixSSA.cpp:
(JSC::B3::demoteValues):
(JSC::B3::fixSSA):
- b3/B3FixSSA.h:
- b3/B3IndexMap.h:
(JSC::B3::IndexMap::resize):
(JSC::B3::IndexMap::clear):
(JSC::B3::IndexMap::size):
(JSC::B3::IndexMap::operator[]):
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::contains):
(JSC::B3::IndexSet::size):
(JSC::B3::IndexSet::isEmpty):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3MemoryValue.h:
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3PatchpointValue.cpp:
(JSC::B3::PatchpointValue::cloneImpl):
(JSC::B3::PatchpointValue::PatchpointValue):
- b3/B3PatchpointValue.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::addStackSlot):
(JSC::B3::Procedure::addVariable):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::addIntConstant):
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::deleteStackSlot):
(JSC::B3::Procedure::deleteVariable):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::deleteOrphans):
(JSC::B3::Procedure::calleeSaveRegisters):
(JSC::B3::Procedure::addValueImpl):
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::addAnonymousStackSlot): Deleted.
(JSC::B3::Procedure::addStackSlotIndex): Deleted.
(JSC::B3::Procedure::addValueIndex): Deleted.
- b3/B3Procedure.h:
(JSC::B3::Procedure::setBlockOrder):
(JSC::B3::Procedure::stackSlots):
(JSC::B3::Procedure::variables):
(JSC::B3::Procedure::values):
(JSC::B3::Procedure::StackSlotsCollection::StackSlotsCollection): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::size): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::at): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::operator[]): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::iterator): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator*): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator++): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator==): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator!=): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::findNext): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::begin): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::end): Deleted.
(JSC::B3::Procedure::ValuesCollection::ValuesCollection): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::iterator): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator*): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator++): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator==): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator!=): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::findNext): Deleted.
(JSC::B3::Procedure::ValuesCollection::begin): Deleted.
(JSC::B3::Procedure::ValuesCollection::end): Deleted.
(JSC::B3::Procedure::ValuesCollection::size): Deleted.
(JSC::B3::Procedure::ValuesCollection::at): Deleted.
(JSC::B3::Procedure::ValuesCollection::operator[]): Deleted.
- b3/B3ProcedureInlines.h:
(JSC::B3::Procedure::add):
- b3/B3ReduceStrength.cpp:
- b3/B3SlotBaseValue.h:
- b3/B3SparseCollection.h: Added.
(JSC::B3::SparseCollection::SparseCollection):
(JSC::B3::SparseCollection::add):
(JSC::B3::SparseCollection::addNew):
(JSC::B3::SparseCollection::remove):
(JSC::B3::SparseCollection::size):
(JSC::B3::SparseCollection::isEmpty):
(JSC::B3::SparseCollection::at):
(JSC::B3::SparseCollection::operator[]):
(JSC::B3::SparseCollection::iterator::iterator):
(JSC::B3::SparseCollection::iterator::operator*):
(JSC::B3::SparseCollection::iterator::operator++):
(JSC::B3::SparseCollection::iterator::operator==):
(JSC::B3::SparseCollection::iterator::operator!=):
(JSC::B3::SparseCollection::iterator::findNext):
(JSC::B3::SparseCollection::begin):
(JSC::B3::SparseCollection::end):
- b3/B3StackSlot.cpp:
(JSC::B3::StackSlot::deepDump):
(JSC::B3::StackSlot::StackSlot):
- b3/B3StackSlot.h:
(JSC::B3::StackSlot::byteSize):
(JSC::B3::StackSlot::index):
(JSC::B3::StackSlot::setOffsetFromFP):
(JSC::B3::StackSlot::kind): Deleted.
(JSC::B3::StackSlot::isLocked): Deleted.
- b3/B3StackSlotKind.cpp: Removed.
- b3/B3StackSlotKind.h: Removed.
- b3/B3StackmapValue.cpp:
(JSC::B3::StackmapValue::dumpMeta):
(JSC::B3::StackmapValue::StackmapValue):
- b3/B3StackmapValue.h:
- b3/B3SwitchValue.cpp:
(JSC::B3::SwitchValue::cloneImpl):
(JSC::B3::SwitchValue::SwitchValue):
- b3/B3SwitchValue.h:
- b3/B3UpsilonValue.h:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithPhi):
(JSC::B3::Value::dump):
(JSC::B3::Value::effects):
(JSC::B3::Value::checkOpcode):
- b3/B3Value.h:
- b3/B3Variable.cpp: Added.
(JSC::B3::Variable::~Variable):
(JSC::B3::Variable::dump):
(JSC::B3::Variable::deepDump):
(JSC::B3::Variable::Variable):
- b3/B3Variable.h: Added.
(JSC::B3::Variable::type):
(JSC::B3::Variable::index):
(JSC::B3::DeepVariableDump::DeepVariableDump):
(JSC::B3::DeepVariableDump::dump):
(JSC::B3::deepDump):
- b3/B3VariableValue.cpp: Added.
(JSC::B3::VariableValue::~VariableValue):
(JSC::B3::VariableValue::dumpMeta):
(JSC::B3::VariableValue::cloneImpl):
(JSC::B3::VariableValue::VariableValue):
- b3/B3VariableValue.h: Added.
- b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::addSpecial):
(JSC::B3::Air::Code::cCallSpecial):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::begin):
(JSC::B3::Air::Code::end):
(JSC::B3::Air::Code::stackSlots):
(JSC::B3::Air::Code::specials):
(JSC::B3::Air::Code::forAllTmps):
(JSC::B3::Air::Code::StackSlotsCollection::StackSlotsCollection): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::size): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::at): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::operator[]): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::iterator): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator*): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator++): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator==): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator!=): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::begin): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::end): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::SpecialsCollection): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::size): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::at): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::operator[]): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::iterator): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator*): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator++): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator==): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator!=): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::begin): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::end): Deleted.
- b3/air/AirFixObviousSpills.cpp:
- b3/air/AirInstInlines.h:
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirLiveness.h:
- b3/air/AirLowerAfterRegAlloc.cpp:
(JSC::B3::Air::lowerAfterRegAlloc):
- b3/air/AirSpecial.cpp:
(JSC::B3::Air::Special::Special):
- b3/air/AirSpecial.h:
- b3/air/AirSpillEverything.cpp:
(JSC::B3::Air::spillEverything):
- b3/air/AirStackSlot.cpp:
(JSC::B3::Air::StackSlot::dump):
(JSC::B3::Air::StackSlot::deepDump):
(JSC::B3::Air::StackSlot::StackSlot):
- b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::byteSize):
(JSC::B3::Air::StackSlot::kind):
(JSC::B3::Air::StackSlot::isLocked):
(JSC::B3::Air::StackSlot::isSpill):
(JSC::B3::Air::StackSlot::index):
(JSC::B3::Air::StackSlot::ensureSize):
- b3/air/AirStackSlotKind.cpp: Copied from Source/JavaScriptCore/b3/B3StackSlotKind.cpp.
(WTF::printInternal):
- b3/air/AirStackSlotKind.h: Copied from Source/JavaScriptCore/b3/B3StackSlotKind.h.
- b3/air/opcode_generator.rb:
- b3/air/testair.cpp:
(JSC::B3::Air::testShuffleBroadcastAllRegs):
(JSC::B3::Air::testShuffleShiftAllRegs):
(JSC::B3::Air::testShuffleRotateAllRegs):
- b3/testb3.cpp:
(JSC::B3::testStackSlot):
(JSC::B3::testStoreLoadStackSlot):
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::neg):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
Websites/webkit.org:
This changes the documentation to account for the addition of Variables and the Get and Set
opcodes, and the removal of anonymous stack slots from B3 IR.
- docs/b3/intermediate-representation.html:
- 2:34 PM Changeset in webkit [196031] by
-
- 20 edits2 adds in trunk/Source/WebCore
Factor style sharing code out of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=153768
Reviewed by Darin Adler.
Move the code to a new class, Style::SharingResolver.
When resolving document style we query the sharing resolver first before using the regular style resolver.
Other paths that call style resolver were mostly already disabling it with DisallowStyleSharing flag.
- WebCore.xcodeproj/project.pbxproj:
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::matchAllRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
More const.
- css/ElementRuleCollector.h:
(WebCore::ElementRuleCollector::setRegionForStyling):
(WebCore::ElementRuleCollector::setMedium):
- css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
- css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::setStyle):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::classNamesAffectedByRules): Deleted.
(WebCore::parentElementPreventsSharing): Deleted.
(WebCore::StyleResolver::locateCousinList): Deleted.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet): Deleted.
(WebCore::StyleResolver::canShareStyleWithControl): Deleted.
(WebCore::elementHasDirectionAuto): Deleted.
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes): Deleted.
(WebCore::StyleResolver::canShareStyleWithElement): Deleted.
(WebCore::StyleResolver::findSiblingForStyleSharing): Deleted.
(WebCore::StyleResolver::locateSharedStyle): Deleted.
Style sharing code moves to SharingResolver.
- css/StyleResolver.h:
(WebCore::StyleResolver::mediaQueryEvaluator):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::State::setElementAffectedByClassRules): Deleted.
(WebCore::StyleResolver::State::elementAffectedByClassRules): Deleted.
(WebCore::StyleResolver::styleNotYetAvailable): Deleted.
Placeholder code moves to TreeResolver.
- dom/VisitedLinkState.cpp:
(WebCore::linkAttribute):
(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- dom/VisitedLinkState.h:
(WebCore::VisitedLinkState::determineLinkState):
- html/HTMLFormControlElement.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::getUncachedPseudoStyle):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isStyleAvailable):
(WebCore::RenderStyle::hasUniquePseudoStyle):
- style/StyleSharingResolver.cpp: Added.
(WebCore::Style::SharingResolver::SharingResolver):
(WebCore::Style::parentElementPreventsSharing):
(WebCore::Style::elementHasDirectionAuto):
(WebCore::Style::SharingResolver::searchSimilar):
(WebCore::Style::SharingResolver::findSibling):
(WebCore::Style::SharingResolver::locateCousinList):
(WebCore::Style::canShareStyleWithControl):
(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::SharingResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::Style::SharingResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::Style::SharingResolver::classNamesAffectedByRules):
- style/StyleSharingResolver.h: Added.
- style/StyleTreeResolver.cpp:
(WebCore::Style::ensurePlaceholderStyle):
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::TreeResolver::styleForElement):
Try to use SharingResolver first.
Also move placeholder style handling here, it is only relevant when resolving document style.
(WebCore::Style::postResolutionCallbacksAreSuspended):
(WebCore::Style::isPlaceholderStyle):
- style/StyleTreeResolver.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::customStyleForRenderer):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::overrideComputedStyle):
- 2:34 PM Changeset in webkit [196030] by
-
- 2 edits in trunk/LayoutTests
Marking perf/show-hide-table-rows.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153803
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:58 PM Changeset in webkit [196029] by
-
- 4 edits in trunk/Websites/webkit.org
Tagline in B3 docs should match the rest of the website
https://bugs.webkit.org/show_bug.cgi?id=153801
Reviewed by Filip Pizlo.
Fix the tagline.
- docs/b3/assembly-intermediate-representation.html:
- docs/b3/index.html:
- docs/b3/intermediate-representation.html:
- 1:31 PM Changeset in webkit [196028] by
-
- 3 edits2 adds in trunk
<attachment> icon should be a folder for the custom MIME type multipart/x-folder
https://bugs.webkit.org/show_bug.cgi?id=153795
<rdar://problem/24416632>
Reviewed by Anders Carlsson.
Source/WebCore:
Test: fast/attachment/attachment-folder-icon.html
- rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
(WebCore::paintAttachmentIcon):
Mail uses this special MIME type to indicate that something is a folder, which there
isn't a normal non-deprecated MIME type for.
LayoutTests:
- fast/attachment/attachment-folder-icon-expected.html: Added.
- fast/attachment/attachment-folder-icon.html: Added.
Make sure that the rendering of an attachment with multipart/x-folder
matches that of a file reference pointing at a folder.
- 1:16 PM Changeset in webkit [196027] by
-
- 2 edits in trunk/LayoutTests
[GTK] Layout Test fast/images/animated-gif-no-layout.html is failing
https://bugs.webkit.org/show_bug.cgi?id=153798
Unreviewed gardening.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2016-02-02
- platform/gtk/TestExpectations: mark a couple tests as failing. The
green frame of the gif is being rendered in a slightly lighter green.
- 1:14 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 1:11 PM Changeset in webkit [196026] by
-
- 5 edits in trunk/LayoutTests
[Win] gardening after r195740.
Unreviewed.
- platform/win/editing/selection/5057506-2-expected.txt:
- platform/win/fast/block/margin-collapse/021-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_style-expected.txt:
- 12:51 PM Changeset in webkit [196025] by
-
- 8 edits in trunk
Modern IDB: storage/indexeddb/cursor-continue-validity.html fails.
https://bugs.webkit.org/show_bug.cgi?id=153791
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing test now unskipped).
There was a preexisting check in the SQLite cursor for remembering the current record and
refusing to refetch it.
This check was causing this bug, because we needed to refetch the current record.
Removing the check (and its associated flag) doesn't regress any other test, and fixes this one.
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
LayoutTests:
In addition to unskipping the test, I augmented it to print out more of what was going on.
The additional printed info is what helped me track down the bug, and will make it more
likely to catch any future regressions.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/cursor-continue-validity-expected.txt:
- storage/indexeddb/cursor-continue-validity-private-expected.txt:
- storage/indexeddb/resources/cursor-continue-validity.js:
- 11:50 AM Changeset in webkit [196024] by
-
- 45 edits32 adds in trunk
Add a line grid pagination SPI to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=153757
<rdar://problem/23041598>
Reviewed by Anders Carlsson.
Source/WebCore:
New tests in fast/multicol/pagination.
- page/Page.cpp:
(WebCore::Page::setPaginationLineGridEnabled):
- page/Page.h:
(WebCore::Page::paginationLineGridEnabled):
Add a boolean to the page to turn the line grid on and off.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
Propagate the body's font up to the paginated RenderView so that
it can be used to establish the line grid.
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
Set up a line grid with containment snapping by default if the
line grid enabled flag is set.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setPagination):
(WebCore::Internals::setPaginationLineGridEnabled):
(WebCore::Internals::configurationForViewport):
- testing/Internals.h:
(WebCore::Internals::setPagination):
- testing/Internals.idl:
Add support for testing the grid being enabled.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _setPaginationLineGridEnabled:]):
(-[WebView _paginationLineGridEnabled]):
- WebView/WebViewPrivate.h:
Source/WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationLineGridEnabled):
(WKPageGetPaginationLineGridEnabled):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationLineGridEnabled:]):
(-[WKBrowsingContextController paginationLineGridEnabled]):
- UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _paginationLineGridEnabled]):
(-[WKWebView _setPaginationLineGridEnabled:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setPaginationLineGridEnabled):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::paginationLineGridEnabled):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setPaginationLineGridEnabled):
WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
LayoutTests:
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png:
- platform/mac/fast/multicol/pagination/BottomToTopGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTopGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png:
- platform/mac/fast/multicol/pagination/LeftToRightGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRightGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-max-width-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png:
- platform/mac/fast/multicol/pagination/RightToLeftGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeftGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png:
- platform/mac/fast/multicol/pagination/TopToBottomGrid-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottomGrid-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/nested-transforms-expected.png:
- 11:43 AM Changeset in webkit [196023] by
-
- 3 edits in trunk/Source/WebCore
Tab suspension code shouldn't use page cache cacheability logic
https://bugs.webkit.org/show_bug.cgi?id=153680
Reviewed by Andreas Kling.
Most of PageCache::canCache() is unnecessary for tab suspension.
Also improve robustness and introduce 1 minute delay before suspending.
- page/Page.cpp:
(WebCore::Page::setPageActivityState):
(WebCore::Page::setIsVisible):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setIsPrerender):
(WebCore::Page::canTabSuspend):
Include visibility test here.
Instead of calling PageCache::canCache() just check for each frame
- that the document is loaded
- that active DOM objects allow suspension
(WebCore::Page::setIsTabSuspended):
(WebCore::Page::setTabSuspensionEnabled):
(WebCore::Page::updateTabSuspensionState):
Refactor for robustness.
(WebCore::Page::tabSuspensionTimerFired):
Call canTabSuspend, the result might have changed.
(WebCore::Page::scheduleTabSuspension): Deleted.
- page/Page.h:
- 11:33 AM Changeset in webkit [196022] by
-
- 42 edits in trunk/Source
[JSC] Introduce BytecodeIntrinsic constant rep like @undefined
https://bugs.webkit.org/show_bug.cgi?id=153737
Reviewed by Darin Adler.
Source/JavaScriptCore:
This patch enhances existing BytecodeIntrinsic mechanism to accept
@xxxform,
that will be used to represent bytecode intrinsic constants.
After this change, we can use 2 forms for bytecode intrinsics. (1) Function form (like, @toString(value))
and (2) Constant form (like @undefined).
Bytecode intrinsic constants allow us to easily expose constant values from C++ world.
For example, we can expose ArrayIterationKind flags to JS world without using private global variables.
Exposed constant values are loaded from bytecodes directly through constant registers.
While previously we expose them through private global variables, bytecode intrinsic constants
can be loaded directly from CodeBlock. And later, it will become JSConstant in DFG.
And by using this mechanism, we implement several constants. @undefined, @arrayIterationKindKeyValue etc.
- builtins/ArrayConstructor.js:
(from):
- builtins/ArrayIteratorPrototype.js:
(next):
- builtins/ArrayPrototype.js:
(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort):
(copyWithin):
- builtins/DatePrototype.js:
(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):
- builtins/GeneratorPrototype.js:
(generatorResume):
- builtins/GlobalObject.js:
(isDictionary):
- builtins/InternalPromiseConstructor.js:
(internalAll.newResolveElement):
(internalAll):
- builtins/IteratorPrototype.js:
(symbolIteratorGetter):
(symbolIterator): Deleted.
- builtins/MapPrototype.js:
(forEach):
- builtins/ModuleLoaderObject.js:
(newRegistryEntry):
(forceFulfillPromise):
(commitInstantiated):
(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestLink):
(provide):
- builtins/PromiseConstructor.js:
(all.newResolveElement):
(all):
(race):
(reject):
(resolve):
- builtins/PromiseOperations.js:
(newPromiseCapability.executor):
(newPromiseCapability):
(rejectPromise):
(fulfillPromise):
(createResolvingFunctions.resolve):
(createResolvingFunctions.reject):
(createResolvingFunctions):
(promiseReactionJob):
(promiseResolveThenableJob):
(initializePromise):
- builtins/PromisePrototype.js:
(catch):
(then):
- builtins/SetPrototype.js:
(forEach):
- builtins/StringConstructor.js:
(raw):
- builtins/StringIteratorPrototype.js:
(next):
- builtins/StringPrototype.js:
(localeCompare):
- builtins/TypedArrayConstructor.js:
(of):
(from):
- builtins/TypedArrayPrototype.js:
(every):
(find):
(findIndex):
(forEach):
(some):
(reduce):
(reduceRight):
(map):
(filter):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
(JSC::BytecodeIntrinsicRegistry::lookup):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/NodesCodegen.cpp:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::makeFunctionCallNode):
- parser/NodeConstructors.h:
(JSC::BytecodeIntrinsicNode::BytecodeIntrinsicNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isBytecodeIntrinsicNode):
(JSC::BytecodeIntrinsicNode::type):
(JSC::BytecodeIntrinsicNode::emitter):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePrimaryExpression):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createResolve):
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.
- runtime/CommonIdentifiers.h:
(JSC::CommonIdentifiers::bytecodeIntrinsicRegistry): Deleted.
- runtime/IteratorPrototype.cpp:
(JSC::IteratorPrototype::finishCreation):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::bytecodeIntrinsicRegistry):
Source/WebCore:
- Modules/fetch/FetchHeaders.js:
(initializeFetchHeaders):
- Modules/streams/ReadableStream.js:
(initializeReadableStream):
(closeDestination):
(abortDestination):
(pipeTo):
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamController):
(teeReadableStream):
(isReadableStreamReader):
(errorReadableStream):
(finishClosingReadableStream):
(enqueueInReadableStream):
(readFromReadableStreamReader):
- Modules/streams/ReadableStreamReader.js:
(releaseLock):
- Modules/streams/StreamInternals.js:
(shieldingPromiseResolve):
(promiseInvokeOrNoopNoCatch):
(promiseInvokeOrFallbackOrNoop):
(validateAndNormalizeQueuingStrategy):
- Modules/streams/WritableStream.js:
(initializeWritableStream):
(write):
- Modules/streams/WritableStreamInternals.js:
(errorWritableStream):
- 11:27 AM Changeset in webkit [196021] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/dont-wedge.html sometimes ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=153790
Reviewed by Tim Horton.
Source/WebCore:
No new tests (Failing test now unskipped).
This test uncovered an unhandled race where the main thread tried to perform an OpenDB operation
multiple times while it was already in-progress on the server thread.
There was already a flag meant to cover this race, and it just needed to be applied to one more site.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:10 AM Changeset in webkit [196020] by
-
- 3 edits in trunk
Unreviewed attempt to fix Mac CMake build after r195999.
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
Add ENABLE_RESOURCE_USAGE to CMake builds.
- 11:07 AM Changeset in webkit [196019] by
-
- 4 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=153605
Reviewed by Filip Pizlo.
Fix remaining compile errors on Win64.
- CMakeLists.txt:
- b3/B3CFG.h:
(JSC::B3::CFG::newMap):
- ftl/FTLJITCode.h:
- 10:52 AM Changeset in webkit [196018] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: undefined is not an object (evaluating 'highlightedRange.from')
https://bugs.webkit.org/show_bug.cgi?id=153685
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
The highlighted range could have just gotten removed, in which case the
marker would return undefined. Just bail in such cases.
- 10:51 AM Changeset in webkit [196017] by
-
- 240 edits in trunk/LayoutTests
[Win] gardening after r195740.
Unreviewed.
- platform/win/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_height-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_height-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_class-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_id-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/win/tables/mozilla/other/body_col-expected.txt:
- platform/win/tables/mozilla/other/cell_widths-expected.txt:
- platform/win/tables/mozilla/other/cellspacing-expected.txt:
- platform/win/tables/mozilla/other/move_row-expected.txt:
- platform/win/tables/mozilla/other/ms-expected.txt:
- platform/win/tables/mozilla/other/nested2-expected.txt:
- platform/win/tables/mozilla/other/nestedTables-expected.txt:
- platform/win/tables/mozilla/other/padding-expected.txt:
- platform/win/tables/mozilla/other/slashlogo-expected.txt:
- platform/win/tables/mozilla/other/test3-expected.txt:
- platform/win/tables/mozilla/other/test6-expected.txt:
- platform/win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/win/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/win/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
- platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
- platform/win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/win/tables/mozilla_expected_failures/other/test4-expected.txt:
- 10:24 AM Changeset in webkit [196016] by
-
- 5 edits in tags/Safari-602.1.18.2
Merged r195968. rdar://problem/24434627
- 10:23 AM Changeset in webkit [196015] by
-
- 5 edits in tags/Safari-602.1.18.2/Source
Versioning.
- 10:19 AM Changeset in webkit [196014] by
-
- 1 copy in tags/Safari-602.1.18.2
New tag.
- 10:06 AM Changeset in webkit [196013] by
-
- 6 edits in trunk
Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
https://bugs.webkit.org/show_bug.cgi?id=153683
Reviewed by Alexey Proskuryakov.
Tools:
Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Also set XPC_DUMPRENDERTREE_TEMP.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Set XPC_XML_CATALOG_FILES.
- Scripts/webkitpy/port/mac.py:
(MacPort.setup_environ_for_server): Ditto.
LayoutTests:
- platform/mac/TestExpectations: Removed the failure expectation for this test.
- 9:57 AM Changeset in webkit [196012] by
-
- 5 edits in trunk/Source/WebCore
CSP: Support checking content security policy without a script execution context
https://bugs.webkit.org/show_bug.cgi?id=153748
<rdar://problem/24439149>
Reviewed by Darin Alder.
Towards checking a Web Worker's content security policy against a redirected worker
script load or redirected XHR request for an XHR request initiated from it, we should
support instantiating a ContentSecurityPolicy object without a ScriptExecutionContext.
No functionality was changed. So, no new tests.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext): Pass |this| as a reference instead of as a pointer.
- page/csp/ContentSecurityPolicy.cpp: Remove extraneous includes ScriptState.h, TextEncoding.h,
and URL.h as they are included by ContentSecurityPolicy.h, FormDataList.h and FormData.h, respectively.
(WebCore::CSPSource::CSPSource): Take a constant reference to a ContentSecurityPolicy instead
of a pointer since we never expected a null pointer.
(WebCore::CSPSource::schemeMatches): Move logic for checking the protocol of source "self"
from here to ContentSecurityPolicy::protocolMatchesSelf() because we may not have a security
origin if ContentSecurityPolicy was initiated without a ScriptExecutionContext object.
(WebCore::CSPSourceList::allowSelf): Added.
(WebCore::CSPSourceList::CSPSourceList): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer. Remove fields from member
initialization list that can be initialized using C++11 in-class initialization syntax.
(WebCore::CSPSourceList::matches): Call ContentSecurityPolicy::urlMatchesSelf() to match the
effective URL against the URL of source "self".
(WebCore::CSPSourceList::parse): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPSourceList::parseSource): Simplify code by setting internal member fields directly
instead of via member functions.
(WebCore::CSPSourceList::parsePath): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirective::CSPDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::CSPDirective::policy): Return a reference to a const ContentSecurityPolicy.
(WebCore::MediaListDirective::MediaListDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::MediaListDirective::parse): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::SourceListDirective::SourceListDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::SourceListDirective::allows): Write in terms of CSPSourceList::allowSelf() because we
may not have a security origin to get a URL from if ContentSecurityPolicy was initiated without
a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::reportURIs): Change return type from Vector<URL> to Vector<String>
The caller will convert the strings to URLs with respect to the script execution context.
(WebCore::CSPDirectiveList::parseReportURI): Store the report URI as a string instead of a URL
because we may not have a security origin to compute the absolute URL if ContentSecurityPolicy
was initiated without a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::CSPDirectiveList): Take a reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer. It would be better to take a const
reference to a ContentSecurityPolicy, but ContentSecurityPolicy::applySandboxPolicy() needs to set
state on ContentSecurityPolicy :(
(WebCore::CSPDirectiveList::create): Ditto.
(WebCore::CSPDirectiveList::reportViolation): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirectiveList::checkEvalAndReportViolation): Ditto.
(WebCore::CSPDirectiveList::checkInlineAndReportViolation): Ditto.
(WebCore::CSPDirectiveList::parseDirective): Ditto.
(WebCore::CSPDirectiveList::parseReportURI): Store the report URI as a string instead of a URL
because we may not have a security origin to compute the absolute URL if ContentSecurityPolicy
was initiated without a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::setCSPDirective): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirectiveList::applySandboxPolicy): Ditto.
(WebCore::CSPDirectiveList::parseReflectedXSS): Ditto.
(WebCore::CSPDirectiveList::addDirective): Ditto.
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy): Modified to take the ScriptExecutionObject
as a reference and compute the CSPSource object for "self" and cache the protocol for "self". Removed
field m_overrideInlineStyleAllowed from the member initialization list and used C++11 in-class
initialization syntax to initialize it. Added overloaded constructor that takes a SecurityOrigin object.
We are not making use of this overloaded constructor at this time. We will in a subsequent patch.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Store the eval disabled error message for
the last parsed policy in a member field instead of using it as part of disabling eval execution
on the script execution context because we may not have such a context.
(WebCore::ContentSecurityPolicy::applyPolicyToScriptExecutionContext): Applies the content security
policy eval and sandbox restrictions to the script execution context.
(WebCore::ContentSecurityPolicy::urlMatchesSelf): Match the specified URL against the URL for
source "self".
(WebCore::ContentSecurityPolicy::protocolMatchesSelf): Match the protocol of the specified URL
against the protocol for source "self".
(WebCore::ContentSecurityPolicy::gatherReportURIs): Modified to use the script execution context
to compute the absolute URL for each report URI.
(WebCore::ContentSecurityPolicy::reportViolation): Bail out if we do not have a script execution
context.
(WebCore::ContentSecurityPolicy::logToConsole): Only log to the console if we have a script
execution context.
(WebCore::ContentSecurityPolicy::reportBlockedScriptExecutionToInspector): Only report blocked
script execution to the Web Inspector if we have a script execution context.
(WebCore::CSPSourceList::addSourceSelf): Deleted.
(WebCore::CSPSourceList::addSourceStar): Deleted.
(WebCore::CSPSourceList::addSourceUnsafeInline): Deleted.
(WebCore::CSPSourceList::addSourceUnsafeEval): Deleted.
(WebCore::CSPDirectiveList::gatherReportURIs): Deleted.
(WebCore::ContentSecurityPolicy::securityOrigin): Deleted.
(WebCore::ContentSecurityPolicy::url): Deleted.
(WebCore::ContentSecurityPolicy::completeURL): Deleted.
(WebCore::ContentSecurityPolicy::enforceSandboxFlags): Deleted.
- page/csp/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::enforceSandboxFlags): Accumulates the parsed sandbox flags. We
will apply the sandbox flags in ContentSecurityPolicy::applyPolicyToScriptExecutionContext().
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope): Instantiate ContentSecurityPolicy.
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Move instantiation of
ContentSecurityPolicy from here to constructor.
- 8:58 AM Changeset in webkit [196011] by
-
- 2 edits in trunk/Websites/webkit.org
Minor fixes for B3 IR documentation
https://bugs.webkit.org/show_bug.cgi?id=153782
Reviewed by Michael Saboff.
Fix minor issues that Geoff found.
- docs/b3/intermediate-representation.html:
- 8:38 AM Changeset in webkit [196010] by
-
- 14 edits2 adds in trunk
Allow ports to disable automatic text track selection
https://bugs.webkit.org/show_bug.cgi?id=153761
<rdar://problem/24416768>
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-manual-mode.html
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::manualKeyword): New.
(WebCore::MediaControlsHost::captionDisplayMode): Support 'manual' mode.
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.buildCaptionMenu): Check the 'off' item when in manual mode.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addTextTrack): Update m_captionDisplayMode when called for the first
time so it is always correct. Set the track's manual selection mode as appropriate.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Set each track's manual selection
mode as appropriate.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::kind): Return 'subtitles' for forced tracks when in manual mode.
- html/track/TextTrack.h:
- html/track/TrackBase.h:
(WebCore::TrackBase::kind): Make virtual.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::beginBlockingNotifications): New.
(WebCore::CaptionUserPreferences::endBlockingNotifications): Ditto.
(WebCore::CaptionUserPreferences::notify): Don't notify when blocked.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF): Set manual mode
when appropriate.
(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode): Check manual mode.
(WebCore::CaptionUserPreferencesMediaAF::setCaptionDisplayMode): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Return zero when in manual mode.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Consider manual mode. Fix
typos in logging.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::mediaDescriptionForKind): Return 'auxiliary' when in manual mode.
- testing/Internals.cpp:
(WebCore::Internals::setCaptionDisplayMode): Support manual mode.
LayoutTests:
- media/track/track-manual-mode-expected.txt: Added.
- media/track/track-manual-mode.html: Added.
- 8:16 AM Changeset in webkit [196009] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r195899): ASSERTION FAILED: is<Target>(source) in EventPath::retargetTouch() since r195899
https://bugs.webkit.org/show_bug.cgi?id=153741
Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-02
Reviewed by Ryosuke Niwa.
- dom/EventDispatcher.cpp:
(WebCore::EventPath::retargetTouch):
- 8:11 AM Changeset in webkit [196008] by
-
- 421 edits in trunk/LayoutTests
[Win] gardening after r195740. (more to follow)
Unreviewed.
- platform/win/tables/mozilla/bugs/bug101201-expected.txt:
- platform/win/tables/mozilla/bugs/bug101674-expected.txt:
- platform/win/tables/mozilla/bugs/bug103533-expected.txt:
- platform/win/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug106795-expected.txt:
- platform/win/tables/mozilla/bugs/bug106816-expected.txt:
- platform/win/tables/mozilla/bugs/bug108340-expected.txt:
- platform/win/tables/mozilla/bugs/bug110566-expected.txt:
- platform/win/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug113424-expected.txt:
- platform/win/tables/mozilla/bugs/bug119786-expected.txt:
- platform/win/tables/mozilla/bugs/bug120107-expected.txt:
- platform/win/tables/mozilla/bugs/bug120364-expected.txt:
- platform/win/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug137388-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug138725-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/win/tables/mozilla/bugs/bug149275-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug154780-expected.txt:
- platform/win/tables/mozilla/bugs/bug159108-expected.txt:
- platform/win/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/win/tables/mozilla/bugs/bug20579-expected.txt:
- platform/win/tables/mozilla/bugs/bug20804-expected.txt:
- platform/win/tables/mozilla/bugs/bug21299-expected.txt:
- platform/win/tables/mozilla/bugs/bug215629-expected.txt:
- platform/win/tables/mozilla/bugs/bug21918-expected.txt:
- platform/win/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug22019-expected.txt:
- platform/win/tables/mozilla/bugs/bug220536-expected.txt:
- platform/win/tables/mozilla/bugs/bug221784-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug221784-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug222336-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-2a-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/win/tables/mozilla/bugs/bug22513-expected.txt:
- platform/win/tables/mozilla/bugs/bug23072-expected.txt:
- platform/win/tables/mozilla/bugs/bug23151-expected.txt:
- platform/win/tables/mozilla/bugs/bug23235-expected.txt:
- platform/win/tables/mozilla/bugs/bug23299-expected.txt:
- platform/win/tables/mozilla/bugs/bug24200-expected.txt:
- platform/win/tables/mozilla/bugs/bug24503-expected.txt:
- platform/win/tables/mozilla/bugs/bug24627-expected.txt:
- platform/win/tables/mozilla/bugs/bug24880-expected.txt:
- platform/win/tables/mozilla/bugs/bug25004-expected.txt:
- platform/win/tables/mozilla/bugs/bug25074-expected.txt:
- platform/win/tables/mozilla/bugs/bug25086-expected.txt:
- platform/win/tables/mozilla/bugs/bug25367-expected.txt:
- platform/win/tables/mozilla/bugs/bug25663-expected.txt:
- platform/win/tables/mozilla/bugs/bug26178-expected.txt:
- platform/win/tables/mozilla/bugs/bug26553-expected.txt:
- platform/win/tables/mozilla/bugs/bug269566-expected.txt:
- platform/win/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug275625-expected.txt:
- platform/win/tables/mozilla/bugs/bug277062-expected.txt:
- platform/win/tables/mozilla/bugs/bug278266-expected.txt:
- platform/win/tables/mozilla/bugs/bug278385-expected.txt:
- platform/win/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug28928-expected.txt:
- platform/win/tables/mozilla/bugs/bug28933-expected.txt:
- platform/win/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug29157-expected.txt:
- platform/win/tables/mozilla/bugs/bug29314-expected.txt:
- platform/win/tables/mozilla/bugs/bug29429-expected.txt:
- platform/win/tables/mozilla/bugs/bug30273-expected.txt:
- platform/win/tables/mozilla/bugs/bug30418-expected.txt:
- platform/win/tables/mozilla/bugs/bug30559-expected.txt:
- platform/win/tables/mozilla/bugs/bug30985-expected.txt:
- platform/win/tables/mozilla/bugs/bug32205-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug32205-5-expected.txt:
- platform/win/tables/mozilla/bugs/bug32447-expected.txt:
- platform/win/tables/mozilla/bugs/bug33137-expected.txt:
- platform/win/tables/mozilla/bugs/bug33855-expected.txt:
- platform/win/tables/mozilla/bugs/bug34538-expected.txt:
- platform/win/tables/mozilla/bugs/bug35662-expected.txt:
- platform/win/tables/mozilla/bugs/bug38916-expected.txt:
- platform/win/tables/mozilla/bugs/bug39209-expected.txt:
- platform/win/tables/mozilla/bugs/bug40828-expected.txt:
- platform/win/tables/mozilla/bugs/bug42187-expected.txt:
- platform/win/tables/mozilla/bugs/bug44505-expected.txt:
- platform/win/tables/mozilla/bugs/bug44523-expected.txt:
- platform/win/tables/mozilla/bugs/bug45055-expected.txt:
- platform/win/tables/mozilla/bugs/bug45350-expected.txt:
- platform/win/tables/mozilla/bugs/bug45486-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/win/tables/mozilla/bugs/bug46268-expected.txt:
- platform/win/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug47432-expected.txt:
- platform/win/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug51037-expected.txt:
- platform/win/tables/mozilla/bugs/bug51140-expected.txt:
- platform/win/tables/mozilla/bugs/bug51727-expected.txt:
- platform/win/tables/mozilla/bugs/bug52505-expected.txt:
- platform/win/tables/mozilla/bugs/bug52506-expected.txt:
- platform/win/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug53891-expected.txt:
- platform/win/tables/mozilla/bugs/bug55545-expected.txt:
- platform/win/tables/mozilla/bugs/bug55694-expected.txt:
- platform/win/tables/mozilla/bugs/bug55789-expected.txt:
- platform/win/tables/mozilla/bugs/bug56201-expected.txt:
- platform/win/tables/mozilla/bugs/bug56405-expected.txt:
- platform/win/tables/mozilla/bugs/bug57300-expected.txt:
- platform/win/tables/mozilla/bugs/bug57378-expected.txt:
- platform/win/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug57828-expected.txt:
- platform/win/tables/mozilla/bugs/bug58402-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug59354-expected.txt:
- platform/win/tables/mozilla/bugs/bug60013-expected.txt:
- platform/win/tables/mozilla/bugs/bug60749-expected.txt:
- platform/win/tables/mozilla/bugs/bug60804-expected.txt:
- platform/win/tables/mozilla/bugs/bug60807-expected.txt:
- platform/win/tables/mozilla/bugs/bug60992-expected.txt:
- platform/win/tables/mozilla/bugs/bug63785-expected.txt:
- platform/win/tables/mozilla/bugs/bug67864-expected.txt:
- platform/win/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug68998-expected.txt:
- platform/win/tables/mozilla/bugs/bug69187-expected.txt:
- platform/win/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug72359-expected.txt:
- platform/win/tables/mozilla/bugs/bug75250-expected.txt:
- platform/win/tables/mozilla/bugs/bug78162-expected.txt:
- platform/win/tables/mozilla/bugs/bug82946-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug83786-expected.txt:
- platform/win/tables/mozilla/bugs/bug86708-expected.txt:
- platform/win/tables/mozilla/bugs/bug92143-expected.txt:
- platform/win/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug93363-expected.txt:
- platform/win/tables/mozilla/bugs/bug96334-expected.txt:
- platform/win/tables/mozilla/bugs/bug96343-expected.txt:
- platform/win/tables/mozilla/bugs/bug97138-expected.txt:
- platform/win/tables/mozilla/bugs/bug97383-expected.txt:
- platform/win/tables/mozilla/bugs/bug99923-expected.txt:
- platform/win/tables/mozilla/bugs/bug99948-expected.txt:
- platform/win/tables/mozilla/collapsing_borders/bug127040-expected.txt:
- platform/win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/win/tables/mozilla/core/bloomberg-expected.txt:
- platform/win/tables/mozilla/core/borders-expected.txt:
- platform/win/tables/mozilla/core/captions-expected.txt:
- platform/win/tables/mozilla/core/cell_heights-expected.txt:
- platform/win/tables/mozilla/core/col_span-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_auto-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/win/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/win/tables/mozilla/core/margins-expected.txt:
- platform/win/tables/mozilla/core/misc-expected.txt:
- platform/win/tables/mozilla/core/nested1-expected.txt:
- platform/win/tables/mozilla/core/one_row-expected.txt:
- platform/win/tables/mozilla/core/row_span-expected.txt:
- platform/win/tables/mozilla/core/table_frame-expected.txt:
- platform/win/tables/mozilla/core/table_heights-expected.txt:
- platform/win/tables/mozilla/core/table_rules-expected.txt:
- platform/win/tables/mozilla/core/table_widths-expected.txt:
- platform/win/tables/mozilla/dom/appendCol2-expected.txt:
- platform/win/tables/mozilla/dom/appendRowsExpand1-expected.txt:
- platform/win/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
- platform/win/tables/mozilla/dom/deleteCol1-expected.txt:
- platform/win/tables/mozilla/dom/deleteCol2-expected.txt:
- platform/win/tables/mozilla/dom/deleteCol3-expected.txt:
- platform/win/tables/mozilla/dom/deleteColGroup1-expected.txt:
- platform/win/tables/mozilla/dom/deleteColGroup2-expected.txt:
- platform/win/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
- platform/win/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
- platform/win/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsExpand1-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsExpand2-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
- platform/win/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/win/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/win/tables/mozilla/dom/insertCols1-expected.txt:
- platform/win/tables/mozilla/dom/insertCols2-expected.txt:
- platform/win/tables/mozilla/dom/insertCols3-expected.txt:
- platform/win/tables/mozilla/dom/insertCols4-expected.txt:
- platform/win/tables/mozilla/dom/insertCols5-expected.txt:
- platform/win/tables/mozilla/dom/insertRowsExpand1-expected.txt:
- platform/win/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
- platform/win/tables/mozilla/dom/tableDom-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/win/tables/mozilla/marvin/body_col-expected.txt:
- platform/win/tables/mozilla/marvin/body_tbody-expected.txt:
- platform/win/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/win/tables/mozilla/marvin/body_thead-expected.txt:
- platform/win/tables/mozilla/marvin/col_span-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/win/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/win/tables/mozilla/marvin/table_frame_border-expected.txt:
- platform/win/tables/mozilla/marvin/table_frame_box-expected.txt:
- platform/win/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/win/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/win/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/table_rules_all-expected.txt:
- platform/win/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/win/tables/mozilla/marvin/table_rules_none-expected.txt:
- platform/win/tables/mozilla/marvin/tables_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tables_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tables_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/win/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_0-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_1-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_2-expected.txt:
- platform/win/tables/mozilla/marvin/tables_border_3-expected.txt:
- platform/win/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
- platform/win/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
- platform/win/tables/mozilla/marvin/tables_cellpadding-expected.txt:
- platform/win/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/win/tables/mozilla/marvin/tables_cellspacing-expected.txt:
- platform/win/tables/mozilla/marvin/tables_default-expected.txt:
- platform/win/tables/mozilla/marvin/tables_id-expected.txt:
- platform/win/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_height-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_colspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_height-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
- platform/win/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/win/tables/mozilla/marvin/tables_width_percent-expected.txt:
- platform/win/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/thead_char-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/win/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/win/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/win/tables/mozilla/marvin/x_table-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_align_right-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_rules_none-expected.txt:
- platform/win/tables/mozilla/marvin/x_table_style-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/win/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- 4:26 AM Changeset in webkit [196007] by
-
- 2 edits in trunk/Tools
[EFL] Virtual Keyboard overlaps MiniBrowser's WebView
https://bugs.webkit.org/show_bug.cgi?id=153009
Reviewed by Gyuyoung Kim.
On mobile, virtual keyboard represented by ecore_imf module appears on
the top of application layer usually covering bottom part of the screen.
If the web page contains the editable content on the bottom of the page
it will be overlapped by keyboard which prevents user from seeing the
typed text.
Pack MiniBrowser layout into conformant widget to allow EFL to guess
the space that will be required by the keyboard, finally resizing it
to the desired size. As a result, webview gets resized and scrolled
into focused elements which makes the editable elements visible while
typing.
More details about elm_conformant widger can be found at:
https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
- MiniBrowser/efl/main.c:
(window_create): pack a box into conformant widget.
- 3:39 AM BuildingGtk edited by
- (diff)
- 3:35 AM Changeset in webkit [196006] by
-
- 8 edits1 add in trunk
[GTK][EFL] Upgrade OpenWebRTC dependency
https://bugs.webkit.org/show_bug.cgi?id=153489
Reviewed by Philippe Normand.
.:
- Source/cmake/FindOpenWebRTC.cmake: Bump OpenWebRTC dependency,
required to make the mediastream work.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Avoid running the mediastream API test.
- Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
default for gtk and efl.
- gtk/jhbuild-webrtc.modules: Added modules files with
dependencies required to compile and test the mediastream.
LayoutTests:
Skiped the mediastream tests by default, until we have the code
ready and gstreamer dependency is bumped.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 3:00 AM Changeset in webkit [196005] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Several tests fail due to assert not reached in DrawingArea::dispatchAfterEnsuringDrawing()
https://bugs.webkit.org/show_bug.cgi?id=153785
Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-02
Reviewed by Carlos Garcia Campos.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing):
- UIProcess/DrawingAreaProxyImpl.h:
Feb 1, 2016:
- 10:35 PM Changeset in webkit [196004] by
-
- 3 edits2 adds in trunk
object.lookupGetter() / object.lookupSetter() does not work for native bindings
https://bugs.webkit.org/show_bug.cgi?id=153765
<rdar://problem/24439699>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
Add support for CustomAccessor slots to objectProtoFuncLookupGetter() and
objectProtoFuncLookupSetter() by return getOwnPropertyDescriptor().get / set.
getOwnPropertyDescriptor() now correctly deals with CustomAccessors since
r196001.
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
LayoutTests:
Add layout tests to test that object.lookupGetter() / object.lookupSetter()
works for native bindings.
- js/lookupGetterGetter-native-bindings-expected.txt: Added.
- js/lookupGetterGetter-native-bindings.html: Added.
- 10:15 PM Changeset in webkit [196003] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Option+Up/Down should not move cursor outside of number
https://bugs.webkit.org/show_bug.cgi?id=153784
<rdar://problem/24453133>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-01
Reviewed by Timothy Hatcher.
- UserInterface/Views/CodeMirrorAdditions.js:
When selectionStart === selectionEnd we were duplicating the
movement mutation by performing it twice on the same object.
After much experimentation, I left in the existing code path
for handling mutation with a selection. It is not perfect,
but it is better then just applying the ch diff.
- 10:12 PM Changeset in webkit [196002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix http/tests/security/cross-origin-window-property-access.html
Update http/tests/security/cross-origin-window-property-access.html that was
introduced in r196001 so that it does not assert on Mac DRT. Mac DRT asserts
that testRunner.waitUntilDone() must be called *BEFORE* calling window.open().
- http/tests/security/cross-origin-window-property-access.html:
- 7:47 PM Changeset in webkit [196001] by
-
- 19 edits13 adds in trunk
Native Bindings Descriptors are Incomplete
https://bugs.webkit.org/show_bug.cgi?id=140575
<rdar://problem/19506502>
Reviewed by Oliver Hunt.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that a lot more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/JavaScriptCore:
This patch is based on initial work by Joe Pecoraro and Matthew Mirman.
This patch was initially rolled out for breaking chromeexperiments.com,
presumably because our IDL attributes were not marked as [configurable]
at the time. However, since r190104, our IDL attributes are now
configurable. Based on local testing, chromeexperiments.com seems to be
working fine now.
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/InjectedScriptSource.js:
(endsWith):
(InjectedScript.prototype.processProperties):
- runtime/JSBoundSlotBaseFunction.cpp: Added.
(JSC::boundSlotBaseFunctionCall):
(JSC::JSBoundSlotBaseFunction::JSBoundSlotBaseFunction):
(JSC::JSBoundSlotBaseFunction::create):
(JSC::JSBoundSlotBaseFunction::visitChildren):
(JSC::JSBoundSlotBaseFunction::finishCreation):
- runtime/JSBoundSlotBaseFunction.h: Added.
(JSC::JSBoundSlotBaseFunction::createStructure):
(JSC::JSBoundSlotBaseFunction::boundSlotBase):
(JSC::JSBoundSlotBaseFunction::customGetterSetter):
(JSC::JSBoundSlotBaseFunction::isSetter):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundSlotBaseFunctionStructure):
- runtime/JSObject.cpp:
(JSC::getBoundSlotBaseFunctionForGetterSetter):
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
LayoutTests:
Add test coverage.
- http/tests/security/cross-origin-window-property-access-expected.txt: Added.
- http/tests/security/cross-origin-window-property-access.html: Added.
- inspector/runtime/getProperties-expected.txt:
- js/dom/native-bindings-descriptors-expected.txt: Added.
- js/dom/native-bindings-descriptors.html: Added.
- js/dom/native-bindings-descriptors2-expected.txt: Added.
- js/dom/native-bindings-descriptors2.html: Added.
- js/dom/native-bindings-descriptors3-expected.txt: Added.
- js/dom/native-bindings-descriptors3.html: Added.
- js/dom/native-bindings-descriptors4-expected.txt: Added.
- js/dom/native-bindings-descriptors4.html: Added.
- js/dom/native-bindings-descriptors5-expected.txt: Added.
- js/dom/native-bindings-descriptors5.html: Added.
- 6:35 PM Changeset in webkit [196000] by
-
- 2 edits in trunk/LayoutTests
[GTK] [EFL] [AppleWin] Layout Test fast/shadow-dom/slot-removal-crash-2.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=153772
Reviewed by Michael Catanzaro.
Don't call wait untilDone if attachShadow is not available.
- fast/shadow-dom/slot-removal-crash-2.html:
- 5:52 PM Changeset in webkit [195999] by
-
- 32 edits6 copies14 adds in trunk
Web Inspector: High Level Memory Overview Instrument
https://bugs.webkit.org/show_bug.cgi?id=153516
<rdar://problem/24356378>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- inspector/protocol/Memory.json: Added.
- inspector/scripts/codegen/generator.py:
New Memory domain guarded by ENABLE(RESOURCE_USAGE).
This feature flag was already used in WebCore.
Source/WebCore:
Add a new agent that gathers data from the ResourceUsageThread
and sends to the frontend.
Test: inspector/memory/tracking.html
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
New files.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Add the new agent.
- inspector/InspectorMemoryAgent.h: Added.
- inspector/InspectorMemoryAgent.cpp: Added.
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorMemoryAgent::startTracking):
(WebCore::InspectorMemoryAgent::stopTracking):
(WebCore::InspectorMemoryAgent::collectSample):
Implement the agent by adding / removing it as a ResourceUsage
observer. When receiving the data forward it to the frontend.
Source/WebInspectorUI:
Use the new "Memory" domain to track page memory size over time.
This allows the timeline to help visualize total process memory
broken down into a few different categories. The timeline graph
allows seeing the total size over time, and you can drill in to
a specific section and get a better breakdown and comparison
of the different categories of memory that we currently track.
- Localizations/en.lproj/localizedStrings.js:
New UI strings.
- UserInterface/Main.html:
New files.
- UserInterface/Base/Main.js:
(WebInspector.loaded):
- UserInterface/Protocol/MemoryObserver.js:
(WebInspector.MemoryObserver.prototype.trackingStart):
(WebInspector.MemoryObserver.prototype.trackingUpdate):
(WebInspector.MemoryObserver.prototype.trackingComplete):
Add a memory observer.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.defaultInstruments):
(WebInspector.TimelineManager.prototype.memoryTrackingStart):
(WebInspector.TimelineManager.prototype.memoryTrackingUpdate):
(WebInspector.TimelineManager.prototype.memoryTrackingComplete):
Create Memory timeline records from Memory tracking updates.
- UserInterface/Models/MemoryCategory.js:
(WebInspector.MemoryCategory):
Consolidate some of the raw data of categories we get from the backend
into a set of 4 user-facing categories.
- UserInterface/Models/MemoryTimelineRecord.js: Added.
(WebInspector.MemoryTimelineRecord):
(WebInspector.MemoryTimelineRecord.memoryCategoriesFromProtocol):
(WebInspector.MemoryTimelineRecord.prototype.get timestamp):
(WebInspector.MemoryTimelineRecord.prototype.get categories):
(WebInspector.MemoryTimelineRecord.prototype.get totalSize):
(WebInspector.MemoryTimelineRecord.prototype.get startTime):
(WebInspector.MemoryTimelineRecord.prototype.get endTime):
Memory timeline record for the event data.
- UserInterface/Models/MemoryInstrument.js:
(WebInspector.MemoryInstrument):
(WebInspector.MemoryInstrument.supported):
(WebInspector.MemoryInstrument.prototype.get timelineRecordType):
(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
Instrument to start / stop memory tracking.
- UserInterface/Models/TimelineRecord.js:
Add a new "Memory" Timeline type.
- UserInterface/Views/ContentView.js:
(WebInspector.ContentView.createFromRepresentedObject):
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording):
Add the new "Memory" Timeline.
(WebInspector.TimelineRecording.prototype.addRecord):
Memory timeline records do not show in the SourceCode Timelines Overview.
- UserInterface/Views/CircleChart.css:
(.circle-chart):
(.circle-chart > svg > path.background):
(.circle-chart > .center):
- UserInterface/Views/CircleChart.js: Added.
(WebInspector.CircleChart):
(WebInspector.CircleChart.prototype.get element):
(WebInspector.CircleChart.prototype.get points):
(WebInspector.CircleChart.prototype.get size):
(WebInspector.CircleChart.prototype.get centerElement):
(WebInspector.CircleChart.prototype.get segments):
(WebInspector.CircleChart.prototype.set segments):
(WebInspector.CircleChart.prototype.get values):
(WebInspector.CircleChart.prototype.set values):
(WebInspector.CircleChart.prototype.clear):
(WebInspector.CircleChart.prototype.needsLayout):
(WebInspector.CircleChart.prototype.updateLayout):
(WebInspector.CircleChart.prototype._needsLayout):
(WebInspector.CircleChart.prototype._createCompleteCirclePathData):
(WebInspector.CircleChart.prototype._createSegmentPathData):
(WebInspector.CircleChart.prototype._updateLayout):
Standalone circle "donut" chart, copied mostly from Rendering Frames Timeline.
Initialize the chart's segments, then feed it a set of ([v1, v2, ...]) values
corresponding to each of the segments.
- UserInterface/Views/LineChart.js: Added.
(WebInspector.LineChart):
(WebInspector.LineChart.prototype.get element):
(WebInspector.LineChart.prototype.get points):
(WebInspector.LineChart.prototype.get size):
(WebInspector.LineChart.prototype.set size):
(WebInspector.LineChart.prototype.addPoint):
(WebInspector.LineChart.prototype.clear):
(WebInspector.LineChart.prototype.needsLayout):
(WebInspector.LineChart.prototype.updateLayout):
(WebInspector.LineChart.prototype._needsLayout):
(WebInspector.LineChart.prototype._updateLayout):
Standalone line chart. Uses a single SVG path, given a set of (x, y) points.
- UserInterface/Views/StackedLineChart.js: Added.
(WebInspector.StackedLineChart):
(WebInspector.StackedLineChart.prototype.get element):
(WebInspector.StackedLineChart.prototype.get points):
(WebInspector.StackedLineChart.prototype.get size):
(WebInspector.StackedLineChart.prototype.set size):
(WebInspector.StackedLineChart.prototype.initializeSections):
(WebInspector.StackedLineChart.prototype.addPointSet):
(WebInspector.StackedLineChart.prototype.clear):
(WebInspector.StackedLineChart.prototype.needsLayout):
(WebInspector.StackedLineChart.prototype.updateLayout):
(WebInspector.StackedLineChart.prototype._needsLayout):
(WebInspector.StackedLineChart.prototype._updateLayout):
Standalone stacked line chart. Initialize the chart's sections,
then feed it a set of (x, [y1, y2 ...]) points where the y
values correspond to each of the sections.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.get scrollContainerWidth):
Add a way to get this value without forcing layout all the time.
- UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.displayNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
(WebInspector.TimelineTabContentView.genericClassNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForRecord):
(WebInspector.TimelineTabContentView.displayNameForRecord):
Add placeholders for the new Memory Timeline Type.
- UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view):
(.memory-category-view > .details):
(.memory-category-view > .details > .name):
(.memory-category-view > .graph):
- UserInterface/Views/MemoryCategoryView.js: Added.
(WebInspector.MemoryCategoryView):
(WebInspector.MemoryCategoryView.prototype.get element):
(WebInspector.MemoryCategoryView.prototype.get category):
(WebInspector.MemoryCategoryView.prototype.clear):
(WebInspector.MemoryCategoryView.prototype.layoutWithDataPoints):
(WebInspector.MemoryCategoryView.prototype._updateDetails):
- UserInterface/Views/MemoryTimelineOverviewGraph.css:
(body .timeline-overview > .graphs-container > .timeline-overview-graph.memory):
(.timeline-overview-graph.memory):
(.timeline-overview-graph.memory > .legend):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.javascript):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.images):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.layers):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.page):
- UserInterface/Views/MemoryTimelineOverviewGraph.js: Added.
(WebInspector.MemoryTimelineOverviewGraph):
(WebInspector.MemoryTimelineOverviewGraph.prototype.get height):
(WebInspector.MemoryTimelineOverviewGraph.prototype.reset):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.timeToX):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.sizeToY):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.sizesToYs):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.ysForRecord):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout):
(WebInspector.MemoryTimelineOverviewGraph.prototype._updateLegend):
(WebInspector.MemoryTimelineOverviewGraph.prototype._visibleRecords):
(WebInspector.MemoryTimelineOverviewGraph.prototype._memoryTimelineRecordAdded):
- UserInterface/Views/MemoryTimelineView.css: Added.
(.timeline-view.memory):
(.timeline-view.memory > .content):
(.timeline-view.memory > .content > .overview):
(.timeline-view.memory > .content .title):
(.timeline-view.memory > .content .subtitle):
(.timeline-view.memory > .content > .details > .timeline-ruler):
(.timeline-view.memory > .content > .details > .subtitle):
(.timeline-view.memory > .content > .overview > .chart):
(.timeline-view.memory > .content > .overview > .chart > .subtitle):
(.timeline-view.memory > .content > .overview > .chart > .container):
(.timeline-view.memory > .content > .overview > .divider):
(.timeline-view.memory > .content > .overview .max-percentage):
(.timeline-view.memory .legend):
(.timeline-view.memory .legend > .row):
(.timeline-view.memory .legend > .row > .swatch):
(.timeline-view.memory .legend > .row > p):
(.timeline-view.memory .legend > .row > .label):
(.timeline-view.memory .legend > .row > .size):
(.timeline-view.memory .legend > .row > .swatch.javascript):
(.timeline-view.memory .legend > .row > .swatch.images):
(.timeline-view.memory .legend > .row > .swatch.layers):
(.timeline-view.memory .legend > .row > .swatch.page):
(.memory-category-view.javascript .line-chart > svg > path):
(.memory-category-view.images .line-chart > svg > path):
(.memory-category-view.layers .line-chart > svg > path):
(.memory-category-view.page .line-chart > svg > path):
(.timeline-view.memory .legend > .row > .swatch.current):
(.timeline-view.memory .circle-chart > svg > path.current):
(.timeline-view.memory .circle-chart > svg > path.remainder):
- UserInterface/Views/MemoryTimelineView.js: Added.
(WebInspector.MemoryTimelineView):
(WebInspector.MemoryTimelineView.displayNameForCategory):
(WebInspector.MemoryTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.MemoryTimelineView.prototype.shown):
(WebInspector.MemoryTimelineView.prototype.hidden):
(WebInspector.MemoryTimelineView.prototype.closed):
(WebInspector.MemoryTimelineView.prototype.reset):
(WebInspector.MemoryTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.MemoryTimelineView.prototype.layout.timeToX):
(WebInspector.MemoryTimelineView.prototype.layout.sizeToY):
(WebInspector.MemoryTimelineView.prototype.layout.layoutCategoryView):
(WebInspector.MemoryTimelineView.prototype.layout):
(WebInspector.MemoryTimelineView.prototype._clearUsageLegend):
(WebInspector.MemoryTimelineView.prototype._updateUsageLegend):
(WebInspector.MemoryTimelineView.prototype._clearMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._updateMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._visibleRecords):
(WebInspector.MemoryTimelineView.prototype._initializeCategoryViews.appendLegendRow):
(WebInspector.MemoryTimelineView.prototype._initializeCategoryViews):
(WebInspector.MemoryTimelineView.prototype._memoryTimelineRecordAdded):
- UserInterface/Views/Variables.css:
(:root):
Memory timeline view styles.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
- inspector/memory/tracking-expected.txt: Added.
- inspector/memory/tracking.html: Added.
Basic test for the new domain tracking commands and events.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
Skip the directory on ports that have not implemented ENABLE(RESOURCE_USAGE).
- 5:51 PM Changeset in webkit [195998] by
-
- 4 edits in trunk/Source
Fix CMake build.
- PlatformMac.cmake:
- 5:42 PM Changeset in webkit [195997] by
-
- 13 edits2 adds in trunk/Source/WebCore
Modern IDB: Cursors (still) do not keep their opening request alive.
https://bugs.webkit.org/show_bug.cgi?id=153724
Reviewed by Alex Christensen.
No new tests (All existing tests pass without flakiness).
IDBCursors did not properly keep their JS wrappers alive.
Making them ActiveDOMObjects that keep track of how many requests might be in flight fixes this.
This also makes them actually keep their opening-request live via the opaque-root mechanism.
IDBCursorWithValue also needed to opt in to all of these mechanisms.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::hasPendingActivity): The base IDBCursor always has no pending activity,
to maintain current behavior in LegacyIDB. This weirdness will go away when LegacyIDB does.
- Modules/indexeddb/IDBCursor.idl:
- Modules/indexeddb/IDBCursorWithValue.idl:
Track a count for all outstanding requests to keep the cursor alive as an ActiveDOMObject.
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::IDBCursor):
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::uncheckedIterateCursor):
(WebCore::IDBClient::IDBCursor::deleteFunction):
(WebCore::IDBClient::IDBCursor::activeDOMObjectName):
(WebCore::IDBClient::IDBCursor::canSuspendForDocumentSuspension):
(WebCore::IDBClient::IDBCursor::hasPendingActivity):
(WebCore::IDBClient::IDBCursor::decrementOutstandingRequestCount):
- Modules/indexeddb/client/IDBCursorImpl.h:
Rework the "delete" family of functions on the object store to allow for returning a modern IDBRequest.
A lot of this can go away when LegacyIDB does.
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::deleteFunction):
(WebCore::IDBClient::IDBObjectStore::doDelete):
(WebCore::IDBClient::IDBObjectStore::modernDelete):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::setSource): Setup a ScopeGuard to decrement the cursor's request
count whenever it makes sense to do so.
(WebCore::IDBClient::IDBRequest::dispatchEvent): Clear the ScopeGuard (if it exists) to decrement the count.
(WebCore::IDBClient::IDBRequest::willIterateCursor): Set the ScopeGuard.
(WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor): Clear the ScopeGuard (if it exists) to decrement the count.
- Modules/indexeddb/client/IDBRequestImpl.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::ScopeGuard::ScopeGuard): Deleted.
(WebCore::IDBServer::ScopeGuard::~ScopeGuard): Deleted.
(WebCore::IDBServer::ScopeGuard::enable): Deleted.
(WebCore::IDBServer::ScopeGuard::disable): Deleted.
- bindings/js/JSIDBCursorWithValueCustom.cpp: Added.
(WebCore::JSIDBCursorWithValue::visitAdditionalChildren):
- platform/ScopeGuard.h: Added.
(WebCore::ScopeGuard::ScopeGuard):
(WebCore::ScopeGuard::~ScopeGuard):
(WebCore::ScopeGuard::enable):
(WebCore::ScopeGuard::disable):
- 5:39 PM Changeset in webkit [195996] by
-
- 2 edits in trunk/LayoutTests
Skipping http/tests/plugins/visible_plugins.html on Yosemite during investigation.
https://bugs.webkit.org/show_bug.cgi?id=153752
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 5:27 PM Changeset in webkit [195995] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: add a LayoutReason enum to the View base class
https://bugs.webkit.org/show_bug.cgi?id=153731
<rdar://problem/24430938>
Reviewed by Brian Burg.
Added a LayoutReason enum to the View base class, which can be passed as an optional
argument to needsLayout() and updateLayout(). The value is propagated to the view's
subtree during layout.
- UserInterface/Base/Main.js:
Update top-level views with Resize layout reason when window is resized.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._positionHeaderViews):
Update header view with Resize layout reason when column is resized.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.shown):
Assume the view has been resized when shown, and update layout.
(WebInspector.OverviewTimelineView.prototype.updateLayoutForResize): Deleted.
No longer needed, handled by the View base class.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.shown):
Assume the view has been resized when shown, and update layout.
(WebInspector.TimelineOverview.prototype.layout):
Invalidate cached scroll container width if resized.
(WebInspector.TimelineOverview.prototype.updateLayoutForResize): Deleted.
No longer needed, handled by the View base class.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.layout): Deleted.
No longer needed, handled by the View base class.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.needsLayout):
(WebInspector.TimelineRuler.prototype.layout):
Update cached client width if resized.
(WebInspector.TimelineRuler.prototype.resize): Deleted.
Moved resize logic to layout override.
- UserInterface/Views/View.js:
(WebInspector.View):
(WebInspector.View.prototype.updateLayout):
Set layout reason.
(WebInspector.View.prototype.needsLayout):
Set layout reason even if an animation frame has already been scheduled,
since the layout reason could have changed.
(WebInspector.View.prototype._layoutSubtree):
Propagate layout reason to subtree, and reset the value when done.
(WebInspector.View.prototype._setLayoutReason):
Helper method for updating the layout reason. Ensures that LayoutReason.Resize
has priority over the default (LayoutReason.Dirty).
- 5:12 PM Changeset in webkit [195994] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html as flaky on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=153781
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:55 PM Changeset in webkit [195993] by
-
- 4 edits1 add in trunk/Tools
Add code to parse the git branches out of the Trac RSS feed https://bugs.webkit.org/show_bug.cgi?id=153624
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
(Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
"branches" and updated the code to work with an array instead of a string.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
fixture that contains XML with a Git branch.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
- 4:46 PM Changeset in webkit [195992] by
-
- 2 edits in trunk/Source/WebCore
Free Colormap when XWindow is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=153413
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2016-02-01
Reviewed by Žan Doberšek.
Colormap is needed to create XWindow and it should be freed when XWindow is destroyed.
Unless Colormap is freed before destroying XWindow, memory leak is suspected.
XFreeColormap therefore is needed on X11Helper.
- platform/graphics/surfaces/glx/X11Helper.cpp: Added XFreeColormap.
(WebCore::X11Helper::destroyWindow):
- 4:45 PM Changeset in webkit [195991] by
-
- 2 edits in trunk/Source/WebKit2
More iOS build fix.
- Platform/spi/ios/UIKitSPI.h:
- 4:41 PM Changeset in webkit [195990] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix.
- Platform/IPC/mac/ConnectionMac.mm:
- 4:35 PM Changeset in webkit [195989] by
-
- 2 edits in trunk/Source/WebKit2
Copy sandbox profiles during installhdrs.
Reviewed by Anders Carlsson.
- Configurations/SandboxProfiles.xcconfig:
- 4:32 PM Changeset in webkit [195988] by
-
- 1 edit2 adds in branches/safari-601-branch/LayoutTests
Merge Layout Tests for r191331. rdar://problem/24448992
- 4:20 PM Changeset in webkit [195987] by
-
- 3 edits2 adds in branches/safari-601-branch
Merge r195837. rdar://problem/24002220
- 4:19 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:00 PM Changeset in webkit [195986] by
-
- 4 edits in trunk/LayoutTests
[GTK] Unreviewed GTK+ Gardening.
- platform/efl/TestExpectations: Add fast/shadow-dom/slot-removal-crash-2.html timeout expectation.
- platform/gtk/TestExpectations: Report and update a bunch of test expectations.
- platform/win/TestExpectations: Add fast/shadow-dom/slot-removal-crash-2.html timeout expectation.
- 3:55 PM Changeset in webkit [195985] by
-
- 7 edits in trunk/Source/WebKit2
[Cocoa] Remove some more has_include guards
https://bugs.webkit.org/show_bug.cgi?id=153774
Reviewed by Tim Horton.
Guard private header includes with #if USE(APPLE_INTERNAL_SDK) rather than with has_include.
- Platform/IPC/mac/ConnectionMac.mm:
- Platform/IPC/mac/ImportanceAssertion.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
- Shared/cf/ArgumentCodersCF.cpp:
- Shared/mac/ChildProcessMac.mm:
- Shared/mac/SecItemShim.cpp:
- 3:40 PM Changeset in webkit [195984] by
-
- 2 edits in trunk/Tools
Add command line flag to DRT to output the number of tests completed in server mode.
https://bugs.webkit.org/show_bug.cgi?id=153750
Reviewed by Darin Adler.
- DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
(runTestingServerLoop):
- 3:37 PM Changeset in webkit [195983] by
-
- 3 edits in trunk/Source/WebKit2
[Xcode] Let Xcode know that the WebKit XPC service products are XPC services
https://bugs.webkit.org/show_bug.cgi?id=153773
Reviewed by Tim Horton.
- Configurations/BaseXPCService.xcconfig: Removed now-redundant definitions of MACH_O_TYPE and WRAPPER_EXTENSION.
- WebKit2.xcodeproj/project.pbxproj: Updated product types.
- 3:31 PM Changeset in webkit [195982] by
-
- 2 edits in trunk/Source/WebKit2
Crash using WKPDFView, in -[UIPDFPageView showContent]
https://bugs.webkit.org/show_bug.cgi?id=153770
<rdar://problem/20157864>
Reviewed by Anders Carlsson.
When scrolling, we throw away UIPDFPageViews, but forget to unhook their delegates.
In some cases (also because their delegate is a raw pointer, not weak), they can call
back into a deleted WKPDFView, causing a crash.
- UIProcess/ios/WKPDFView.mm:
(detachViewForPage):
Add a helper to detach a page view, and unhook its delegates.
(-[WKPDFView _clearPages]):
(-[WKPDFView _revalidateViews]):
Make use of the new helper.
- 3:19 PM Changeset in webkit [195981] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] IRC can coalesce the frame pointer with a Tmp that is modified
https://bugs.webkit.org/show_bug.cgi?id=153694
Reviewed by Filip Pizlo.
Let's say we have:
Move(FP, Tmp1)
Add64(#1, Tmp1)
If we were to coalesce the Move, we would modify the frame pointer.
Well, that's exactly what was happening with IRC.
Since the epilogue is not know to Air before IRC, the liveness analysis
never discovers that FP is live when Tmp1 is UseDef by Add64. Adding
FP would a be a problem anyway for a bunch of reasons.
I tried two ways to prevent IRC to override IRC:
1) Add an interference edge with FP for all non-duplication Defs.
2) Let coalesce() know about FP and constraint any coalescing with a re-Def.
The two are within margin of error for performance. The second one was considerably
more complicated. This patch implements the first one.
Some extra note:
-It is very important to not increment the degree of a Tmp when making it interfere
with FP. FP is not a valid color, it is not counted in the "K" colors considered
for coloring. Increasing the degree with the edge to FP would make every stage
pessimistic since there is an extra degree that can never be removed.
-I put "interferenceEdges" and "adjacencyList" in an inconsistent state.
This is intentional, "interferenceEdges" is used to test the existence of an edge,
"adjacencyList" is used to go over all the edges. In this case, we don't want
the edge with FP to be considered when pruning the graph.
- b3/air/AirIteratedRegisterCoalescing.cpp:
One branch could be transformed into an assertion: TmpLiveness is type specific now.
- b3/testb3.cpp:
(JSC::B3::testOverrideFramePointer):
(JSC::B3::run):
- 2:13 PM Changeset in webkit [195980] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/XMLHttpRequest/open-url-multi-window-4.htm as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153336
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 2:07 PM Changeset in webkit [195979] by
-
- 3 edits in trunk/Source/WebCore
Move some SPI declarations into the appropriate SPI header
https://bugs.webkit.org/show_bug.cgi?id=153755
Reviewed by Darin Adler.
- platform/graphics/cocoa/IOSurface.mm:
- platform/spi/cg/CoreGraphicsSPI.h:
- 1:50 PM Changeset in webkit [195978] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/appcache/404-resource-with-slow-main-resource.php as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153503
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:31 PM Changeset in webkit [195977] by
-
- 2 edits in trunk/LayoutTests
Marking fast/replaced/preferred-widths.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153311
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:25 PM Changeset in webkit [195976] by
-
- 2 edits in trunk/LayoutTests
Skip fast/shadow-dom/touch-event-ios.html on ios-simulator since touch events are not supported.
https://bugs.webkit.org/show_bug.cgi?id=149592
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:47 PM Changeset in webkit [195975] by
-
- 2 edits in trunk/Source/WebCore
Snapshot surfaces are forever wired after being compressed
https://bugs.webkit.org/show_bug.cgi?id=153751
<rdar://problem/24354546>
Reviewed by Darin Adler.
- platform/graphics/cocoa/IOSurface.mm:
(IOSurface::convertToFormat):
Allow IOSurfaceAccelerator to unwire surfaces after they're transformed.
- 12:40 PM Changeset in webkit [195974] by
-
- 2 edits in tags/Safari-602.1.18.0.1/Source/WebKit2
Merged r195964. rdar://problem/24424987
- 12:35 PM Changeset in webkit [195973] by
-
- 5 edits in tags/Safari-602.1.18.0.1/Source
Versioning.
- 12:33 PM Changeset in webkit [195972] by
-
- 1 copy in tags/Safari-602.1.18.0.1
New tag.
- 12:23 PM Changeset in webkit [195971] by
-
- 5 edits in trunk/Source
<rdar://problem/20150072> [iOS] Remove some file upload code only needed before iOS 9
https://bugs.webkit.org/show_bug.cgi?id=153754
Reviewed by Darin Adler.
Source/WebCore:
- English.lproj/Localizable.strings: Updated for removal of WebKit2 string.
Source/WebKit2:
- Platform/spi/ios/UIKitSPI.h: Removed conditional forward declaration of SPI.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(photoLibraryIcon): Removed check for HAVE_WEBKIT_DOC_PICKER_ICONS, which is always true in
iOS 9 and later.
(cameraIcon): Ditto.
(-[WKFileUploadPanel presentWithParameters:resultListener:]): Removed branch for when
UIDocumentMenuViewController doesn’t respond to
-_initIgnoringApplicationEntitlementForImportOfTypes:.
(-[WKFileUploadPanel _showMediaSourceSelectionSheet]): Deleted now-unused method.
- 11:45 AM Changeset in webkit [195970] by
-
- 8 edits in trunk/Source
Cache the Path instead of creating it every time it is required
https://bugs.webkit.org/show_bug.cgi?id=152939
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-02-01
Reviewed by Darin Adler.
Source/WebCore:
Instead of creating the Path object every time it is required, we should
cache it in an LRU cache. TinyLRUCache returns a reference to the cached
entry so we do not have to pay the cost of copying it either.
- platform/graphics/FloatRoundedRect.h:
(WebCore::operator!=):
Implement the inequality operator for FloatRoundedRect since it is
called by TinyLRUCache.
- rendering/ClipPathOperation.h:
Return a reference to the path in the cache since instead of creating a
new copy.
- rendering/style/BasicShapes.cpp:
(WebCore::SVGPathTranslatedByteStream::SVGPathTranslatedByteStream):
(WebCore::SVGPathTranslatedByteStream::operator==):
(WebCore::SVGPathTranslatedByteStream::operator!=):
(WebCore::SVGPathTranslatedByteStream::isEmpty):
(WebCore::SVGPathTranslatedByteStream::path):
This struct holds an offset and an SVGPathByteStream. It is the key of
the LRU cache for the the translated SVGPathByteStream.
(WebCore::EllipsePathPolicy::isKeyNull):
(WebCore::EllipsePathPolicy::createValueForKey):
(WebCore::RoundedRectPathPolicy::isKeyNull):
(WebCore::RoundedRectPathPolicy::createValueForKey):
(WebCore::PolygonPathPolicy::isKeyNull):
(WebCore::PolygonPathPolicy::createValueForKey):
(WebCore::TranslatedByteStreamPathPolicy::isKeyNull):
(WebCore::TranslatedByteStreamPathPolicy::createValueForKey):
Inherit from the LRU cache policy template, so have a specific name for
the desired path contents and pass this class explicitly to the LRU cache
template.
(WebCore::cachedEllipsePath):
(WebCore::cachedRoundedRectPath):
(WebCore::cachedPolygonPath):
(WebCore::cachedTranslatedByteStreamPath):
Return a cached path object for specific path contents.
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
(WebCore::BasicShapePath::path):
(WebCore::BasicShapeInset::path):
Get the Path object from the cache; create a new one if it does not exist.
- rendering/style/BasicShapes.h:
Change the prototype of the path() function to return a reference to the
path in the cache instead of a having to copying it.
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::operator!=):
Implement the inequality operator for SVGPathByteStream because it is
called by TinyLRUCache.
Source/WTF:
If the key type of an LRU cache can't to be strongly tided to a specific
data type; e.g. FloatRect -> Path, we need to be able to pass the policy
type to the TinyLRUCache template instead of just specializing it. This
will make the code more readable and will allow different caches for the
same key type.
- wtf/TinyLRUCache.h:
(WebCore::TinyLRUCache::get):
- 11:42 AM Changeset in webkit [195969] by
-
- 20 edits in trunk
Move properties that use custom bindings to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153735
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
Source/WebCore:
Move properties that use custom bindings to the prototype. Whether a
property's bindings code is generated or custom-written should not
impact where the property is located.
No new tests, already covered by existing tests.
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
Add null-check for staticPropHashTable. HTMLDocument no longer has
any property on the instance so staticPropHashTable is now null.
- bindings/scripts/CodeGeneratorJS.pm:
LayoutTests:
Rebaseline / update existing tests now that properties using custom
bindings are on the prototype, as expected.
- fast/mediastream/MediaStream-video-element-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt:
- inspector/model/remote-object-get-properties-expected.txt:
- js/dom/dom-attributes-on-mismatch-type-expected.txt:
- js/dom/dom-attributes-on-mismatch-type.html:
- platform/mac/inspector/model/remote-object-expected.txt:
- 11:05 AM Changeset in webkit [195968] by
-
- 5 edits in trunk
[Win] WTFHeaderDetection.h no longer needed
https://bugs.webkit.org/show_bug.cgi?id=153753
rdar://problem/24434627
Reviewed by Darin Adler.
.:
- Source/cmake/WebKitFS.cmake:
Source/WTF:
- wtf/Platform.h:
- wtf/PlatformWin.cmake:
- 10:24 AM Changeset in webkit [195967] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
https://bugs.webkit.org/show_bug.cgi?id=153736
<rdar://problem/21946301>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the new timeline overview's height before it's shown. Showing the
overview causes the rendering frames graph to do a layout, which requires
the height of the containing view to be a valid value.
- 10:22 AM Changeset in webkit [195966] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: DataGridNode should support adding go-to arrow buttons to any cell
https://bugs.webkit.org/show_bug.cgi?id=153733
<rdar://problem/24431813>
Reviewed by Brian Burg.
Provide a way to add go-to arrow buttons to any grid cell from within a
DataGridNode subclass's implementation of createCellContent.
- UserInterface/Views/DataGrid.js:
New event type, GoToArrowClicked.
(WebInspector.DataGridNode.prototype.createGoToArrowButton.buttonClicked):
(WebInspector.DataGridNode.prototype.createGoToArrowButton):
Adds a go-to arrow button to the cell's content element. Clicking the button
dispatches an event on the DataGrid, with event data containing the
DataGridNode and identifier of the cell containing the arrow button.
- 10:15 AM Changeset in webkit [195965] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
https://bugs.webkit.org/show_bug.cgi?id=153727
<rdar://problem/24429886>
Reviewed by Chris Dumez.
The
thisobject may be freed after calling deleteIfPossible(). Make the early-return-if-
deleted more explicit, and only check allowsCaching() after the deleteIfPossible() return
value check.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
- 9:56 AM Changeset in webkit [195964] by
-
- 2 edits in trunk/Source/WebKit2
Stop linking to PassKit
https://bugs.webkit.org/show_bug.cgi?id=153746
Reviewed by Tim Horton.
- Configurations/WebKit.xcconfig:
- 9:53 AM Changeset in webkit [195963] by
-
- 7 edits in trunk/Source/WebKit2
[Cocoa] Get rid of WK_ macros for initializers
https://bugs.webkit.org/show_bug.cgi?id=153744
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_DESIGNATED_INITIALIZER and WK_UNAVAILABLE.
- mac/postprocess-framework-headers.sh: Removed rules for rewriting the above macros. Also removed Foundation import that became unnecessary, and definitions that were only needed before iOS 8.
Replaced instances of the above macros with their expansions.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- 9:02 AM Changeset in webkit [195962] by
-
- 4 edits in trunk/Tools
Improvements to botwatcher's dashboard unit tests.
https://bugs.webkit.org/show_bug.cgi?id=153621
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
(PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
_popoverLinesForCommitRange have to traverse commits from different branches.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
_revisionContentWithPopoverForIteration.
- 9:01 AM Changeset in webkit [195961] by
-
- 3 edits in trunk/Tools
Refactor to add event listeners and start periodic updates for all trac instances.
https://bugs.webkit.org/show_bug.cgi?id=153609
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView): Adding event listeners for all trac instances.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
for all trac instances.
- 8:00 AM Changeset in webkit [195960] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix a build after r195899.
- dom/EventContext.h: Enabled TouchEventContext type trait specialization on iOS.
- 4:33 AM Changeset in webkit [195959] by
-
- 6 edits in trunk/LayoutTests
Unreviewed. Updating global-constructors-attributes expectations after introducing Request in r195954.
- 4:31 AM Changeset in webkit [195958] by
-
- 2 edits in trunk/Source/WebKit2
One more unreviewed speculative buildfix after r195755.
- PlatformMac.cmake:
- 4:19 AM Changeset in webkit [195957] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed speculative buildfix after r195755.
- PlatformMac.cmake:
- 3:26 AM Changeset in webkit [195956] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed speculative buildfix.
- dfg/DFGCommon.h: FTL_USES_B3 should be false if FTL JIT is disabled.
- 3:20 AM Changeset in webkit [195955] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed speculative buildfix after r195795.
- PlatformMac.cmake: Remove Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm.
- 3:05 AM Changeset in webkit [195954] by
-
- 23 edits2 copies36 adds in trunk
[Fetch API] Implement Fetch API Request
https://bugs.webkit.org/show_bug.cgi?id=153437
LayoutTests/imported/w3c:
Reviewed by Darin Adler.
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/request/request-clone.sub-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-clone.sub.html: Added.
- web-platform-tests/fetch/api/request/request-consume-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-consume.html: Added.
- web-platform-tests/fetch/api/request/request-disturbed-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-disturbed.html: Added.
- web-platform-tests/fetch/api/request/request-error-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-error.html: Added.
- web-platform-tests/fetch/api/request/request-headers-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-headers.html: Added.
- web-platform-tests/fetch/api/request/request-idl-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-idl.html: Added.
- web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-init-001.sub.html: Added.
- web-platform-tests/fetch/api/request/request-init-002-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-init-002.html: Added.
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-init-003.sub.html: Added.
- web-platform-tests/fetch/api/request/request-structure-expected.txt: Added.
- web-platform-tests/fetch/api/request/request-structure.html: Added.
- web-platform-tests/fetch/api/resources/authentication.py: Added.
(main):
- web-platform-tests/fetch/api/resources/clean-stash.py: Added.
(main):
- web-platform-tests/fetch/api/resources/inspect-headers.py: Added.
(main):
- web-platform-tests/fetch/api/resources/method.py: Added.
(main):
- web-platform-tests/fetch/api/resources/preflight.py: Added.
(main):
- web-platform-tests/fetch/api/resources/redirect.py: Added.
(main):
- web-platform-tests/fetch/api/resources/top.txt: Added.
- web-platform-tests/fetch/api/resources/trickle.py: Added.
(main):
- web-platform-tests/fetch/api/resources/utils.js: Added.
(catch):
(dirname):
(checkRequest):
(readTextStream):
Source/WebCore:
Added support for Fetch Request and Body.
Body is sharing functionality between Request and Response.
Conversion between various body types are not implemented yet.
Added a FetchOptions class. Options in this class are partially redundant with ResourceLoaderOptions.
Fixing bug in Headers constructor.
Making error reporting in case of modifying headers compliant with the spec.
Reviewed by Darin Adler.
Tests: imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-consume.html
imported/w3c/web-platform-tests/fetch/api/request/request-disturbed.html
imported/w3c/web-platform-tests/fetch/api/request/request-error.html
imported/w3c/web-platform-tests/fetch/api/request/request-headers.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-002.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-structure.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/fetch/FetchBody.cpp: Added.
(WebCore::FetchBody::initBody):
(WebCore::FetchBody::clear):
(WebCore::FetchBody::processIfEmptyOrDisturbed):
(WebCore::FetchBody::arrayBuffer):
(WebCore::FetchBody::formData):
(WebCore::FetchBody::blob):
(WebCore::FetchBody::text):
(WebCore::FetchBody::json):
- Modules/fetch/FetchBody.h: Added.
(WebCore::FetchBody::~FetchBody):
(WebCore::FetchBody::isEmpty):
(WebCore::FetchBody::isDisturbed):
(WebCore::FetchBody::setDisturbed):
(WebCore::FetchBody::setMimeType):
(WebCore::FetchBody::mimeType):
- Modules/fetch/FetchBody.idl: Added.
- Modules/fetch/FetchHeaders.cpp:
(WebCore::canWriteHeader):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):
(WebCore::FetchHeaders::fill): Helper routine implementing https://fetch.spec.whatwg.org/#concept-headers-fill
- Modules/fetch/FetchHeaders.h: Adding header getter/setter for FetchRequest.
(WebCore::FetchHeaders::fastGet):
(WebCore::FetchHeaders::fastSet):
- Modules/fetch/FetchHeaders.js: Fixing bug in constructor (covered by modified headers-basc.html test).
(initializeFetchHeaders):
- Modules/fetch/FetchOptions.h: Added.
(WebCore::FetchOptions::FetchOptions):
(WebCore::FetchOptions::type):
(WebCore::FetchOptions::destination):
(WebCore::FetchOptions::mode):
(WebCore::FetchOptions::credentials):
(WebCore::FetchOptions::cache):
(WebCore::FetchOptions::redirect):
(WebCore::FetchOptions::referrerPolicy):
(WebCore::FetchOptions::setType):
(WebCore::FetchOptions::setDestination):
(WebCore::FetchOptions::setMode):
(WebCore::FetchOptions::setCredentials):
(WebCore::FetchOptions::setCache):
(WebCore::FetchOptions::setRedirect):
(WebCore::FetchOptions::setReferrerPolicy):
- Modules/fetch/FetchRequest.cpp: Added.
(WebCore::FetchRequest::create):
(WebCore::FetchRequest::FetchRequest):
(WebCore::FetchRequest::init):
(WebCore::FetchRequest::setReferrer):
(WebCore::FetchRequest::setReferrerPolicy):
(WebCore::FetchRequest::setMode):
(WebCore::FetchRequest::setCredentials):
(WebCore::FetchRequest::setCache):
(WebCore::FetchRequest::setRedirect):
(WebCore::FetchRequest::type):
(WebCore::FetchRequest::destination):
(WebCore::FetchRequest::referrerPolicy):
(WebCore::FetchRequest::referrer):
(WebCore::FetchRequest::mode):
(WebCore::FetchRequest::credentials):
(WebCore::FetchRequest::cache):
(WebCore::FetchRequest::redirect):
(WebCore::FetchRequest::setMethod):
(WebCore::FetchRequest::clone):
- Modules/fetch/FetchRequest.h: Added.
(WebCore::FetchRequest::method):
(WebCore::FetchRequest::url):
(WebCore::FetchRequest::integrity):
(WebCore::FetchRequest::headers):
- Modules/fetch/FetchRequest.idl: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/Dictionary.h:
(WebCore::Dictionary::execState):
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
(WebCore::JSDictionary::get):
LayoutTests:
Reviewed by Darin Adler.
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
Jan 31, 2016:
- 10:34 PM Changeset in webkit [195953] by
-
- 17 edits4 adds in trunk
Add resize event for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=125715
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-01-31
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaselined test after moving 'resize' from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Tests: http/tests/media/hls/hls-video-resize.html
media/video-resize.html
Move resize javascript event from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers
Post resize event from video element when metadata loads and when content size changes.
- dom/GlobalEventHandlers.idl: Add onresize.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::createEventHandlerNameMap): Add onresizeAttr.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::scheduleResizeEvent):
(WebCore::HTMLMediaElement::scheduleResizeEventIfSizeChanged):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::scheduleResizeEvent): Sechedule event.
(WebCore::HTMLVideoElement::scheduleResizeEventIfSizeChanged): Schedule event if size has changed.
- html/HTMLVideoElement.h: Add declarations.
- page/DOMWindow.idl: Remove onresize.
Source/WebInspectorUI:
Add a display name for "resize" event.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
LayoutTests:
Update test for change: move resize javascript event from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers
- fast/dom/event-handler-attributes-expected.txt: Rebaselined.
- fast/dom/event-handler-attributes.html:
Move resize from uniqueWindowEvents to eventsInGlobalEventHandlers.
- http/tests/media/hls/hls-video-resize-expected.txt: Added.
- http/tests/media/hls/hls-video-resize.html: Added.
- js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaselined.
- media/video-resize-expected.txt: Added.
- media/video-resize.html: Added.
- media/video-test.js:
(requiredEvents): Deleted global. Value is now captured by closure.
(waitForEventsAndCall): Remove dependence on global variable, and fix event observation leak.
- 9:51 PM Changeset in webkit [195952] by
-
- 2 edits in trunk/Source/WebCore
Revert accidental behavior change from previous patch.
- platform/URL.cpp:
(WebCore::mimeTypeFromDataURL): Restore behavior where an empty MIME type would
be turned into "text/plain".
- 9:46 PM Changeset in webkit [195951] by
-
- 53 edits in trunk/Source
Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153732
Reviewed by Dean Jackson.
Source/WebCore:
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported): Added comment about mysterious call
to lower(); should probably return here and remove it.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist): Deleted. Moved into isProtocolWhitelisted.
(WebCore::isProtocolWhitelisted): Changed set to be ASCIICaseInsensitiveHash and
initialized it using a lambda instead of a separate function.
(WebCore::verifyProtocolHandlerScheme): Added a FIXME about some case sensitive
checking of the protocol prefix here.
- Modules/plugins/QuickTimePluginReplacement.mm:
(WebCore::QuickTimePluginReplacement::supportsMimeType): Changed set to be
ASCIICaseInsensitiveHash and initialized it using a lambda instead of using
an explict check for empty.
(WebCore::QuickTimePluginReplacement::supportsFileExtension): Ditto.
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::queryKeysAndValues): Use convertToASCIILowercase. The keys here are
going to be all ASCII.
(WebCore::isYouTubeURL): Use equalLettersIgnoringASCIICase instead of lowercasing
the string.
(WebCore::processAndCreateYouTubeURL): Use url.protocolIsInHTTPFamily instead of
listing "http" and then "https" explicitly. Use equalLettersIgnoringASCIICase
instead of lowercasing a string.
(WebCore::YouTubePluginReplacement::youTubeURL): Ditto.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::hostName): Use convertToASCIILowercase on host name.
(WebCore::WebSocketHandshake::host): Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Call convertToASCIILowercase instead of lower
to lowercase an element's tag name. This is a strange way to do things; typically
would be better to use some other function on Element, since tagName goes out of
its way to be capitalized, but some ATK expert can improve this later.
- css/CSSGrammar.y.in: Use the new convertToASCIILowercaseInPlace function rather
than the old lower function. We only need to lowercase the ASCII letters, and it's
also better to have the function have a clearer name.
- css/CSSParser.cpp:
(WebCore::convertToASCIILowercaseInPlace): Renamed from makeLower and made it deal
with only ASCII lowercasing.
(WebCore::CSSParserString::convertToASCIILowercaseInPlace): Renamed from lower.
(WebCore::isUniversalKeyword): Added. Helper for the function below that uses
equalLettersIgnoringASCIICase rather than lowercasing the string.
(WebCore::parseKeywordValue): Use isUniversalKeyword. Also clarified a comment.
(WebCore::CSSParser::parseAttr): Use convertToASCIILowercaseInPlace and delay
String creation until later in the function, using CSSParserString operations more.
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector): Use
convertToASCIILowercaseInPlace by its new name, with its new behavior.
- css/CSSParserValues.h: Tweaked comment and formatting a bit. Replaced the lower
function with the convertToASCIILowercaseInPlace function.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::RareData::parseNth): Rewrote this to avoid the need to
make a lowercased copy of m_argument. Use equalLettersIgnoringASCIICase, and two
calls to find. Also use String::toIntStrict so we don't have to create String
objects for substrings.
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery): Use convertToASCIILowercase for media type name.
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::serialize): Use convertToASCIILowercase for media feature name.
- dom/Document.cpp:
(WebCore::isSeparator): Tweaked formatting and removed non-helpful comment.
(WebCore::processArguments): Changed this from a static member function to a non-member
file internal function. Use a std::function instead of a function pointer with a void*
pointer. Rewrote algorithm to simplify it and use StringView instead of String for the
keys and values.
(WebCore::Document::processViewport): Use a lambda instead of a function pointer to
call setViewportFeature, so that function's interface is no longer dictated by
the exact type of the function pointer argument to processArguments.
(WebCore::Document::processFormatDetection): Use a lambda instead of the
setParserFeature function above; use equalLettersIgnoringASCIICase for both the
key and the value, since processArguments no longer lowercases the string.
(WebCore::Document::processArguments): Deleted.
- dom/Document.h: Removed unnecessary declaration of processArguments and
ArgumentsCallback. Both are now private to the cpp file.
- dom/Element.cpp:
(WebCore::makeIdForStyleResolution): Use convertToASCIILowercase. When in quirks mode,
we want to match IDs in an ASCII case-insensitive way not match compatibility caseless.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::isScriptTypeSupported): Remove the use of lower here since
the MIME type registry is now itself ASCII case-insensitive.
- dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Changed to use StringView and take a Document&, rearranged
argument order so Document& comes first.
(WebCore::findSizeValue): Ditto.
(WebCore::findScaleValue): Ditto.
(WebCore::findBooleanValue): Ditto. Also use std::abs instead of fabs, possibly
avoiding a conversion from float to double (not sure it was happening before but it's
definitely not happening now).
(WebCore::setViewportFeature): Changed to put arguments in a more logical order, to take
the ViewportArguments as a reference, not a void*, and to use StringView to avoid forcing
the caller to allocate strings. Also changed to use equalLettersIgnoringASCIICase so we
don't rely on the caller to make the key lowercase for us.
(WebCore::reportViewportWarning): Changed argument types. Added a couple comments about
mistakes in the function.
- dom/ViewportArguments.h: Removed unnecessary declaration of reportViewportWarning,
which is now private to the cpp file. Updated for new arguments to setViewportFeature.
- editing/EditorCommand.cpp:
(WebCore::executeFormatBlock): Use convertToASCIILowercase on the argument, which is
specifying a tag name.
- fileapi/Blob.cpp:
(WebCore::Blob::isValidContentType): Removed unnecessary separate loops for
8-bit and 16-bit strings. Content types are short strings and this small optimization is
not worth the additional code complexity.
(WebCore::Blob::normalizedContentType): Use convertToASCIILowercase since valid
content types are guaranteed to be all ASCII.
(WebCore::Blob::isNormalizedContentType): Removed unnecessary separate loops for
8-bit and 16-bit strings. Content types are short strings and this small optimization is
not worth the additional code complexity.
- html/parser/HTMLParserIdioms.cpp: Added now-needed include of QualifiedName.h.
- html/parser/HTMLParserIdioms.h: Removed unneeded include of QualifiedName.h and
WTFString.h. Made sure every function is declared first, even if it's also defined
later in the header in the section for functions templates and inline functions.
- loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes): Use auto& for the type of
the set of MIME types here, since it's now using ASCIICaseInsensitiveHash.
- platform/MIMETypeRegistry.cpp: Changed the MIME type sets to use
ASCIICaseInsensitiveHash since MIME type are not case sensitive.
(WebCore::initializeSupportedImageMIMETypes): Use a modern for loop.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Updated for HashSet type change.
(WebCore::initializePDFMIMETypes): Use a modern for loop.
(WebCore::initializeSupportedNonImageMimeTypes): Use a modern for loop.
(WebCore::initializeSupportedMediaMIMETypes): Updated for HashSet type change.
(WebCore::initializeUnsupportedTextMIMETypes): Use a modern for loop.
(WebCore::initializeMIMETypeRegistry): Updated for HashSet type change.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): Ditto.
(WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getPDFMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes): Ditto.
(WebCore::mimeTypeAssociationMap): Use ASCIICaseInsensitiveHash.
(WebCore::MIMETypeRegistry::getNormalizedMIMEType): Use auto to make code tighter.
- platform/MIMETypeRegistry.h: Changed return types of the getMIMETypes functions
to use ASCIICaseInsensitiveHash.
- platform/SchemeRegistry.cpp:
(WebCore::schemesForbiddenFromDomainRelaxation): Changed type to
use ASCIICaseInsensitiveHash.
- platform/URL.cpp:
(WebCore::mimeTypeFromDataURL): Use convertToASCIILowercase instead of lower.
Also removed some dead code that tried to handle the case where the data URL
has a comma as one of the first 5 characters: That can't happen since it's a
precondition of this function that the first five characters are "data:".
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getSupportedTypes): Change type of argument to
a HashSet with ASCIICaseInsensitiveHash.
- platform/graphics/MediaPlayer.h: Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::staticMIMETypeList):
Changed type of HashSet to use ASCIICaseInsensitiveHash.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::avfMIMETypes):
Changed type of HashSet to use ASCIICaseInsensitiveHash.
(WebCore::MediaPlayerPrivateAVFoundationCF::getSupportedTypes): Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
Changed type of HashSet to use ASCIICaseInsensitiveHash.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Removed
an unnecessary line of code to set a local variable to 0 just before it falls
out of scope.
(WebCore::avfMIMETypes): Ditto. Also tightened up the code a bit.
(WebCore::MediaPlayerPrivateAVFoundationObjC::getSupportedTypes): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
Changed type of HashSet to use ASCIICaseInsensitiveHash.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::mimeTypeCache): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::getSupportedTypes): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mimeTypeCache): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::shouldRejectMIMEType): Made this non-case-sensitive by using startsWith
and the "false" argument. Later change this to startsWithIgnoringASCIICase or
startsWithLettersIgnoringASCIICase.
(WebCore::addFileTypesToCache): Use ASCIICaseInsensitiveHash. ALso rewrote to
tighten up the code a bit and use modern Objective-C for loops.
(WebCore::mimeCommonTypesCache): Use ASCIICaseInsensitiveHash.
(WebCore::mimeModernTypesCache): Ditto.
(WebCore::concatenateHashSets): Ditto.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Ditto.
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): Initialied
track type set using lambda, but left it case sensitive.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::mimeTypeCache): Changed type of HashSet to use ASCIICaseInsensitiveHash.
(WebCore::MediaPlayerPrivateMediaFoundation::getSupportedTypes): Ditto.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::mimeTypeCache): Ditto.
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes): Ditto.
- platform/mock/mediasource/MockMediaPlayerMediaSource.h: Ditto.
Source/WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(newArrayWithStrings): Updated to use HashSet<String, ASCIICaseInsensitiveHash>
and also to use a modern for loop.
Source/WTF:
- wtf/text/StringView.h: Added toIntStrict. Not thrilled about the name of this
function, but generally it seems likely to be useful more often than toInt.
And it's needed for one call site in WebCore that was using String::lower.
- 8:44 PM Changeset in webkit [195950] by
-
- 3 edits4 adds in trunk
Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>
Reviewed by Darin Adler.
Source/WebCore:
Tested by http/tests/plugins/visible_plugins.html.
A number of poorly-coded sites break when WebKit reports that it understands PDF mime types,
but does not have a list of plugins that the site can iterate through.
To avoid this compatibility problem, we should also expose the "WebKit built-in PDF" plugin
to avoid this edge case.
- plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible): Add "WebKit built-in PDF" plugin.
LayoutTests:
- http/tests/plugins/visible_plugins-expected.txt: Added.
- http/tests/plugins/visible_plugins.html: Added.
- platform/mac-wk2/http/tests/plugins: Added.
- platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Added.
- 8:09 PM Changeset in webkit [195949] by
-
- 11 edits2 adds in trunk
AX: Add a boundary value to AXTextStateChangeType
https://bugs.webkit.org/show_bug.cgi?id=153085
Patch by Doug Russell <d_russell@apple.com> on 2016-01-31
Reviewed by Darin Adler.
Post an AT notification when navigation is attempted past
an editable element's boundaries.
Source/WebCore:
Test: accessibility/mac/selection-boundary-userinfo.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::showIntent):
- accessibility/AXTextStateChangeIntent.h:
- accessibility/mac/AXObjectCacheMac.mm:
(platformChangeTypeForWebCoreChangeType):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::textSelectionWithDirectionAndGranularity):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::modifyExtendingBackward): Deleted.
(WebCore::FrameSelection::textSelectionIntent): Deleted.
- editing/FrameSelection.h:
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Deleted.
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Deleted.
- editing/VisiblePosition.h:
- editing/VisibleUnits.cpp:
(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftBoundaryOfLine):
(WebCore::rightBoundaryOfLine):
(WebCore::inSameLogicalLine): Deleted.
(WebCore::endOfEditableContent): Deleted.
(WebCore::isEndOfEditableOrNonEditableContent): Deleted.
- editing/VisibleUnits.h:
LayoutTests:
- accessibility/mac/selection-boundary-userinfo-expected.txt: Added.
- accessibility/mac/selection-boundary-userinfo.html: Added.
- 7:10 PM Changeset in webkit [195948] by
-
- 26 edits10 adds in trunk
CSP: Use the served CSP header for dedicated workers
https://bugs.webkit.org/show_bug.cgi?id=153157
<rdar://problem/24383254>
And
https://bugs.webkit.org/show_bug.cgi?id=153156
<rdar://problem/24383246>
Patch by Daniel Bates <dabates@apple.com> on 2016-01-31
Reviewed by Brent Fulgham.
Source/WebCore:
Inspired by Blink commit:
<https://src.chromium.org/viewvc/blink?revision=194143&view=revision>
Implement support for respecting Content Security Policy (CSP) HTTP headers included in the
HTTP response for a Web Worker's script as per section Workers of the CSP 2.0 spec,
<https://w3c.github.io/webappsec-csp/2/#processing-model-workers> (29 August 2015).
Currently a Web Worker always inherits the CSP of its owner document. Instead a web worker
will inherit the CSP of its owner document only if its script is incapable of defining a
content security policy (i.e. its origin is a globally unique identifier). Otherwise, the
CSP HTTP headers delivered with the script will be used to define the CSP for the worker.
Tests: fast/workers/worker-inherits-csp-blocks-eval.html
fast/workers/worker-inherits-csp-blocks-xhr.html
http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html
- CMakeLists.txt: Add file ContentSecurityPolicyResponseHeaders.cpp.
- WebCore.vcxproj/WebCore.vcxproj: Add files ContentSecurityPolicyResponseHeaders.{cpp, h}.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Update code to use enum class ContentSecurityPolicyHeaderType.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument): Extract logic to collect Content Security Policy HTTP headers
into class ContentSecurityPolicyResponseHeaders and make use of it here.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::headerType): Modified to use enum class ContentSecurityPolicyHeaderType.
(WebCore::CSPDirectiveList::CSPDirectiveList): Ditto.
(WebCore::CSPDirectiveList::create): Ditto.
(WebCore::ContentSecurityPolicy::responseHeaders): Creates and returns a ContentSecurityPolicyResponseHeaders
object with the parsed CSP policy headers.
(WebCore::ContentSecurityPolicy::didReceiveHeaders): Processed the CSP policy headers represented by the
specified ContentSecurityPolicyResponseHeaders object.
(WebCore::ContentSecurityPolicy::deprecatedHeader): Deleted.
(WebCore::ContentSecurityPolicy::deprecatedHeaderType): Deleted.
- page/csp/ContentSecurityPolicy.h: Defines a class that represents a collection of CSP policy headers.
This class has two purposes:
- It extracts the CSP policy headers from a HTTP response (ResourceResponse object). We make use of this functionality in both FrameLoader::didBeginDocument() and Worker::didReceiveResponse().
- It serves as a memento that externalizes the internal CSP policy details of an instance of ContentSecurityPolicy. We make use of this memento functionality to support inheriting the CSP policy of the worker's owner document in a thread-safe manner. You can create and restore a memento using ContentSecurityPolicy::responseHeaders() and ContentSecurityPolicy::didReceiveHeaders(), respectively.
- page/csp/ContentSecurityPolicyResponseHeaders.cpp: Added.
(WebCore::ContentSecurityPolicyResponseHeaders::ContentSecurityPolicyResponseHeaders): Extracts the
CSP HTTP headers from a ResourceResponse object.
(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy): Make a copy of this object that is
safe to pass to another thread.
- page/csp/ContentSecurityPolicyResponseHeaders.h: Added.
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create): Modified to use class ContentSecurityPolicyResponseHeaders.
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create): Ditto.
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread): Ditto.
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope): Ditto.
- workers/DedicatedWorkerThread.h:
- workers/Worker.cpp:
(WebCore::Worker::didReceiveResponse): Create a ContentSecurityPolicyResponseHeaders if the origin of
the worker's script is capable of providing a CSP. Otherwise, we will inherit the CSP of the worker's owner
document in Worker::notifyFinished().
(WebCore::Worker::notifyFinished): Pass the appropriate CSP response headers to WorkerMessagingProxy::startWorkerGlobalScope().
- workers/Worker.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Renamed; formerly named applyContentSecurityPolicyFromString().
Modified to take a ContentSecurityPolicyResponseHeaders and apply it to the ContentSecurityPolicy object associated with the worker.
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyFromString): Deleted.
- workers/WorkerGlobalScope.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope): Pass the worker's ContentSecurityPolicyResponseHeaders object.
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData): Added field m_contentSecurityPolicyResponseHeaders to store
the CSP response headers to be applied to the worker's ContentSecurityPolicy object.
(WebCore::WorkerThread::WorkerThread): Modified to use ContentSecurityPolicyResponseHeaders.
(WebCore::WorkerThread::workerThread): Pass the ContentSecurityPolicyResponseHeaders object from the start up data struct
to DedicatedWorkerThread::createWorkerGlobalScope().
- workers/WorkerThread.h:
LayoutTests:
Add new tests to ensure we block eval() in blob-, file-URL workers and block XHR in a file-URL worker.
- TestExpectations: Remove now passing tests http/tests/security/contentSecurityPolicy/worker-{multiple-csp-headers, without-own-csp}.html
and update the associated bug # for tests that fail.
- fast/workers/resources/worker-inherits-csp-blocks-eval.js: Added.
(catch):
- fast/workers/resources/worker-inherits-csp-blocks-xhr.js: Added.
(catch):
- fast/workers/worker-inherits-csp-blocks-eval-expected.txt: Added.
- fast/workers/worker-inherits-csp-blocks-eval.html: Added.
- fast/workers/worker-inherits-csp-blocks-xhr-expected.txt: Added.
- fast/workers/worker-inherits-csp-blocks-xhr.html: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html: Added.
- http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers-expected.txt: Updated expected results as
the result was incorrect.
- http/tests/security/contentSecurityPolicy/worker-without-own-csp-expected.txt: Ditto.
- 6:22 PM Changeset in webkit [195947] by
-
- 322 edits in trunk/LayoutTests
Unreviewed. EFL gardening: rebaseline tests after r195740. (more to follow)
- platform/efl/css1/basic/containment-expected.txt:
- platform/efl/css1/basic/contextual_selectors-expected.txt:
- platform/efl/css1/basic/grouping-expected.txt:
- platform/efl/css1/basic/id_as_selector-expected.txt:
- platform/efl/css1/basic/inheritance-expected.txt:
- platform/efl/css1/box_properties/border-expected.txt:
- platform/efl/css1/box_properties/border_bottom-expected.txt:
- platform/efl/css1/box_properties/border_bottom_inline-expected.txt:
- platform/efl/css1/box_properties/border_bottom_width-expected.txt:
- platform/efl/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/efl/css1/box_properties/border_color-expected.txt:
- platform/efl/css1/box_properties/border_color_inline-expected.txt:
- platform/efl/css1/box_properties/border_inline-expected.txt:
- platform/efl/css1/box_properties/border_left-expected.txt:
- platform/efl/css1/box_properties/border_left_inline-expected.txt:
- platform/efl/css1/box_properties/border_left_width-expected.txt:
- platform/efl/css1/box_properties/border_left_width_inline-expected.txt:
- platform/efl/css1/box_properties/border_right-expected.txt:
- platform/efl/css1/box_properties/border_right_inline-expected.txt:
- platform/efl/css1/box_properties/border_right_width-expected.txt:
- platform/efl/css1/box_properties/border_right_width_inline-expected.txt:
- platform/efl/css1/box_properties/border_style-expected.txt:
- platform/efl/css1/box_properties/border_style_inline-expected.txt:
- platform/efl/css1/box_properties/border_top-expected.txt:
- platform/efl/css1/box_properties/border_top_inline-expected.txt:
- platform/efl/css1/box_properties/border_top_width-expected.txt:
- platform/efl/css1/box_properties/border_top_width_inline-expected.txt:
- platform/efl/css1/box_properties/clear-expected.txt:
- platform/efl/css1/box_properties/clear_float-expected.txt:
- platform/efl/css1/box_properties/float-expected.txt:
- platform/efl/css1/box_properties/float_elements_in_series-expected.txt:
- platform/efl/css1/box_properties/float_margin-expected.txt:
- platform/efl/css1/box_properties/height-expected.txt:
- platform/efl/css1/box_properties/margin-expected.txt:
- platform/efl/css1/box_properties/margin_bottom-expected.txt:
- platform/efl/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/efl/css1/box_properties/margin_inline-expected.txt:
- platform/efl/css1/box_properties/margin_left-expected.txt:
- platform/efl/css1/box_properties/margin_left_inline-expected.txt:
- platform/efl/css1/box_properties/margin_right-expected.txt:
- platform/efl/css1/box_properties/margin_right_inline-expected.txt:
- platform/efl/css1/box_properties/margin_top-expected.txt:
- platform/efl/css1/box_properties/margin_top_inline-expected.txt:
- platform/efl/css1/box_properties/padding-expected.txt:
- platform/efl/css1/box_properties/padding_bottom-expected.txt:
- platform/efl/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/efl/css1/box_properties/padding_inline-expected.txt:
- platform/efl/css1/box_properties/padding_left-expected.txt:
- platform/efl/css1/box_properties/padding_left_inline-expected.txt:
- platform/efl/css1/box_properties/padding_right-expected.txt:
- platform/efl/css1/box_properties/padding_right_inline-expected.txt:
- platform/efl/css1/box_properties/padding_top-expected.txt:
- platform/efl/css1/box_properties/padding_top_inline-expected.txt:
- platform/efl/css1/box_properties/width-expected.txt:
- platform/efl/css1/cascade/cascade_order-expected.txt:
- platform/efl/css1/cascade/important-expected.txt:
- platform/efl/css1/classification/display-expected.txt:
- platform/efl/css1/classification/list_style-expected.txt:
- platform/efl/css1/classification/list_style_image-expected.txt:
- platform/efl/css1/classification/list_style_position-expected.txt:
- platform/efl/css1/classification/list_style_type-expected.txt:
- platform/efl/css1/classification/white_space-expected.txt:
- platform/efl/css1/color_and_background/background-expected.txt:
- platform/efl/css1/color_and_background/background_attachment-expected.txt:
- platform/efl/css1/color_and_background/background_color-expected.txt:
- platform/efl/css1/color_and_background/background_image-expected.txt:
- platform/efl/css1/color_and_background/background_position-expected.txt:
- platform/efl/css1/color_and_background/background_repeat-expected.txt:
- platform/efl/css1/color_and_background/color-expected.txt:
- platform/efl/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/efl/css1/font_properties/font-expected.txt:
- platform/efl/css1/font_properties/font_family-expected.txt:
- platform/efl/css1/font_properties/font_size-expected.txt:
- platform/efl/css1/font_properties/font_style-expected.txt:
- platform/efl/css1/font_properties/font_variant-expected.txt:
- platform/efl/css1/font_properties/font_weight-expected.txt:
- platform/efl/css1/formatting_model/canvas-expected.txt:
- platform/efl/css1/formatting_model/height_of_lines-expected.txt:
- platform/efl/css1/formatting_model/inline_elements-expected.txt:
- platform/efl/css1/formatting_model/replaced_elements-expected.txt:
- platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
- platform/efl/css1/pseudo/anchor-expected.txt:
- platform/efl/css1/pseudo/firstletter-expected.txt:
- platform/efl/css1/pseudo/firstline-expected.txt:
- platform/efl/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/efl/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/efl/css1/text_properties/letter_spacing-expected.txt:
- platform/efl/css1/text_properties/line_height-expected.txt:
- platform/efl/css1/text_properties/text_align-expected.txt:
- platform/efl/css1/text_properties/text_decoration-expected.txt:
- platform/efl/css1/text_properties/text_indent-expected.txt:
- platform/efl/css1/text_properties/text_transform-expected.txt:
- platform/efl/css1/text_properties/vertical_align-expected.txt:
- platform/efl/css1/text_properties/word_spacing-expected.txt:
- platform/efl/css1/units/color_units-expected.txt:
- platform/efl/css1/units/length_units-expected.txt:
- platform/efl/css1/units/percentage_units-expected.txt:
- platform/efl/css1/units/urls-expected.txt:
- platform/efl/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/efl/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/efl/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/efl/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/efl/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/efl/css2.1/20110323/inline-table-001-expected.txt:
- platform/efl/css2.1/20110323/inline-table-002a-expected.txt:
- platform/efl/css2.1/20110323/inline-table-003-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/efl/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/efl/css2.1/20110323/table-caption-001-expected.txt:
- platform/efl/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/efl/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/efl/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/efl/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/efl/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/efl/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/efl/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/efl/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/efl/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-18-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/efl/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-18-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/efl/editing/deleting/4922367-expected.txt:
- platform/efl/editing/deleting/5126166-expected.txt:
- platform/efl/editing/deleting/5206311-1-expected.txt:
- platform/efl/editing/deleting/5433862-2-expected.txt:
- platform/efl/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/efl/editing/selection/3690703-2-expected.txt:
- platform/efl/editing/selection/3690703-expected.txt:
- platform/efl/editing/selection/3690719-expected.txt:
- platform/efl/editing/selection/5057506-2-expected.txt:
- platform/efl/editing/selection/5057506-expected.txt:
- platform/efl/editing/selection/5131716-1-expected.txt:
- platform/efl/editing/selection/5131716-2-expected.txt:
- platform/efl/editing/selection/5131716-3-expected.txt:
- platform/efl/editing/selection/5131716-4-expected.txt:
- platform/efl/editing/selection/move-by-line-001-expected.txt:
- platform/efl/editing/selection/select-all-004-expected.txt:
- platform/efl/editing/unsupported-content/table-type-after-expected.txt:
- platform/efl/editing/unsupported-content/table-type-before-expected.txt:
- platform/efl/fast/block/basic/016-expected.txt:
- platform/efl/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/efl/fast/block/float/015-expected.txt:
- platform/efl/fast/block/margin-collapse/006-expected.txt:
- platform/efl/fast/block/margin-collapse/010-expected.txt:
- platform/efl/fast/block/margin-collapse/011-expected.txt:
- platform/efl/fast/block/margin-collapse/012-expected.txt:
- platform/efl/fast/block/margin-collapse/015-expected.txt:
- platform/efl/fast/block/margin-collapse/016-expected.txt:
- platform/efl/fast/block/margin-collapse/017-expected.txt:
- platform/efl/fast/block/margin-collapse/018-expected.txt:
- platform/efl/fast/block/margin-collapse/019-expected.txt:
- platform/efl/fast/block/margin-collapse/020-expected.txt:
- platform/efl/fast/block/margin-collapse/021-expected.txt:
- platform/efl/fast/block/margin-collapse/022-expected.txt:
- platform/efl/fast/block/margin-collapse/025-expected.txt:
- platform/efl/fast/block/margin-collapse/032-expected.txt:
- platform/efl/fast/block/margin-collapse/033-expected.txt:
- platform/efl/fast/block/margin-collapse/034-expected.txt:
- platform/efl/fast/block/margin-collapse/041-expected.txt:
- platform/efl/fast/block/margin-collapse/042-expected.txt:
- platform/efl/fast/block/margin-collapse/055-expected.txt:
- platform/efl/fast/block/margin-collapse/056-expected.txt:
- platform/efl/fast/block/margin-collapse/057-expected.txt:
- platform/efl/fast/block/margin-collapse/058-expected.txt:
- platform/efl/fast/block/margin-collapse/059-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/efl/fast/block/positioning/negative-right-pos-expected.txt:
- platform/efl/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/efl/fast/borders/border-antialiasing-expected.txt:
- platform/efl/fast/borders/border-radius-different-width-001-expected.txt:
- platform/efl/fast/borders/table-borders-expected.txt:
- platform/efl/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/efl/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/efl/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/efl/fast/css-generated-content/table-parts-before-and-after-expected.txt:
- platform/efl/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/efl/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/efl/fast/css-generated-content/table-with-before-expected.txt:
- platform/efl/fast/css/003-expected.txt:
- platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/efl/fast/css/acid2-expected.txt:
- platform/efl/fast/css/acid2-pixel-expected.txt:
- platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/efl/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/efl/fast/css/caption-width-absolute-position-expected.txt:
- platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt:
- platform/efl/fast/css/caption-width-fixed-position-expected.txt:
- platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt:
- platform/efl/fast/css/caption-width-relative-position-expected.txt:
- platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt:
- platform/efl/fast/css/css3-nth-child-expected.txt:
- platform/efl/fast/css/focus-ring-detached-expected.txt:
- platform/efl/fast/css/focus-ring-multiline-expected.txt:
- platform/efl/fast/css/h1-in-section-elements-expected.txt:
- platform/efl/fast/css/image-rendering-expected.txt:
- platform/efl/fast/css/min-width-with-spanned-cell-expected.txt:
- platform/efl/fast/css/percentage-non-integer-expected.txt:
- platform/efl/fast/css/table-text-align-quirk-expected.txt:
- platform/efl/fast/css/table-text-align-strict-expected.txt:
- platform/efl/fast/dom/34176-expected.txt:
- platform/efl/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/efl/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/efl/fast/dom/row-inner-text-expected.txt:
- platform/efl/fast/dynamic/001-expected.txt:
- platform/efl/fast/dynamic/containing-block-change-expected.txt:
- platform/efl/fast/dynamic/float-withdrawal-expected.txt:
- platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/efl/fast/dynamic/subtree-table-cell-height-expected.txt:
- platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
- platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
- platform/efl/fast/forms/001-expected.txt:
- platform/efl/fast/forms/005-expected.txt:
- platform/efl/fast/forms/basic-buttons-expected.txt:
- platform/efl/fast/forms/form-element-geometry-expected.txt:
- platform/efl/fast/forms/form-hides-table-expected.txt:
- platform/efl/fast/forms/form-in-malformed-markup-expected.txt:
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/input-table-expected.txt:
- platform/efl/fast/forms/listbox-bidi-align-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/efl/fast/html/details-writing-mode-expected.txt:
- platform/efl/fast/inline-block/001-expected.txt:
- platform/efl/fast/inline-block/overflow-clip-expected.txt:
- platform/efl/fast/invalid/012-expected.txt:
- platform/efl/fast/invalid/018-expected.txt:
- platform/efl/fast/lists/004-expected.txt:
- platform/efl/fast/lists/list-marker-before-content-table-expected.txt:
- platform/efl/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/efl/fast/overflow/002-expected.txt:
- platform/efl/fast/overflow/overflow-rtl-expected.txt:
- platform/efl/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/efl/fast/overflow/table-overflow-float-expected.txt:
- platform/efl/fast/reflections/table-cell-expected.txt:
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
- platform/efl/fast/repaint/float-overflow-expected.txt:
- platform/efl/fast/repaint/float-overflow-right-expected.txt:
- platform/efl/fast/repaint/subtree-root-clip-3-expected.txt:
- platform/efl/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/efl/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- platform/efl/fast/repaint/table-cell-move-expected.txt:
- platform/efl/fast/repaint/table-cell-overflow-expected.txt:
- platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt:
- platform/efl/fast/repaint/table-col-background-expected.txt:
- platform/efl/fast/repaint/table-collapsed-border-expected.txt:
- platform/efl/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/efl/fast/repaint/table-outer-border-expected.txt:
- platform/efl/fast/repaint/table-row-expected.txt:
- platform/efl/fast/repaint/table-section-overflow-expected.txt:
- platform/efl/fast/repaint/table-section-repaint-expected.txt:
- platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
- platform/efl/fast/repaint/table-writing-modes-h-expected.txt:
- platform/efl/fast/repaint/table-writing-modes-v-expected.txt:
- 5:50 PM Changeset in webkit [195946] by
-
- 9 edits in trunk/Source
Get rid of most calls to String::upper; mostly replace them with convertToASCIIUppercase
https://bugs.webkit.org/show_bug.cgi?id=153715
Reviewed by Gyuyoung Kim.
Source/WebCore:
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::computedAttributesForElement): Use convertToASCIILowercase to fold
ASCII case when searching for fonts by name.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit): Use convertToASCIIUppercase to make
the HTTP version string canonical. Not sure why it's needed at all, but the letters
we might be uppercasing are "HTTP", so no need to handle non-ASCII.
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformLazyInit): Ditto.
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<): Use convertToASCIIUppercase when writing the spread
method type into a text stream. The method types are all ASCII.
Source/WebKit2:
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
Use convertToASCIIUppercase on language names.
Source/WTF:
- wtf/text/AtomicString.h:
(WTF::AtomicString::upper): Deleted.
- 5:20 PM Changeset in webkit [195945] by
-
- 2 edits in trunk
[EFL] All API tests are broken on 15.10
https://bugs.webkit.org/show_bug.cgi?id=153528
Reviewed by Gyuyoung Kim.
- CMakeLists.txt: Having include(WebKitCommon) statement follow
CMAKE_FOO_OUTPUT_DIRECTORY otherwise all the API tests gets blocked.
- 4:27 PM Changeset in webkit [195944] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 4:27 PM Changeset in webkit [195943] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 4:26 PM Changeset in webkit [195942] by
-
- 6 edits in trunk/Source
[Cocoa] Remove unused definition of HAVE_HEADER_DETECTION_H
https://bugs.webkit.org/show_bug.cgi?id=153729
Reviewed by Sam Weinig.
After r141700, HAVE_HEADER_DETECTION_H is no longer used.
- Configurations/Base.xcconfig:
- 4:10 PM Changeset in webkit [195941] by
-
- 1 copy in tags/Safari-601.1.46.96
New tag.
- 4:10 PM Changeset in webkit [195940] by
-
- 1 copy in tags/Safari-601.5.14
New tag.
- 4:07 PM Changeset in webkit [195939] by
-
- 2 edits in trunk/Source/JavaScriptCore
B3->Air lowering should use MoveFloat more
https://bugs.webkit.org/show_bug.cgi?id=153714
Reviewed by Sam Weinig.
This is a very minor and benign bug. It just means that we will use the more canonical
MoveFloat instruction when moving floats, rather than using MoveDouble.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::relaxedMoveForType):
- 3:05 PM Changeset in webkit [195938] by
-
- 5 edits7 adds in trunk/Source/JavaScriptCore
Should not predict OtherObj for ToThis with primitive types under strict mode
https://bugs.webkit.org/show_bug.cgi?id=153544
Reviewed by Filip Pizlo.
Currently, ToThis predicates OtherObj for primitive values.
But it's not true in strict mode.
In strict mode, ToThis does nothing on primitive values.
In this patch, we
- fix prediction. Handles primitive types in strict mode. And we also handles StringObject.
- convert it to Identity if the argument should be predicted as primitive types.
This optimization is important to implement Primitive.prototype.methods[1].
Otherwise, we always got BadType OSR exits.
[1]: https://bugs.webkit.org/show_bug.cgi?id=143889
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToThis):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- tests/stress/to-this-boolean.js: Added.
(Boolean.prototype.negate):
(Boolean.prototype.negate2):
- tests/stress/to-this-double.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-int32.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-int52.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-number.js: Added.
(Number.prototype.negate):
- tests/stress/to-this-string.js: Added.
(String.prototype.prefix):
(String.prototype.first):
(String.prototype.second):
- tests/stress/to-this-symbol.js: Added.
(Symbol.prototype.identity):
(Symbol.prototype.identity2):
- 3:00 PM Changeset in webkit [195937] by
-
- 20 edits in trunk/Source
[Cocoa] Remove has_include guards around use of WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=153728
Reviewed by Andy Estes.
Guard WebKitAdditions includes with #if USE(APPLE_INTERNAL_SDK) rather than with has_include.
Source/WebCore:
- dom/EventNames.h:
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame):
- page/MainFrame.h:
- page/PageConfiguration.h:
- platform/cocoa/WebKitAdditions.mm:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
- platform/ios/LegacyTileGridTile.mm:
Source/WebKit/mac:
- WebKitAdditions.mm:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKit2:
- Shared/Cocoa/WebKitAdditions.mm:
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/RemoteLayerBackingStore.mm:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldDispatchFakeMouseMoveEvents):
- 2:46 PM Changeset in webkit [195936] by
-
- 5 edits in tags/Safari-602.1.18.1/Source
Versioning.
- 2:42 PM Changeset in webkit [195935] by
-
- 1 copy in tags/Safari-602.1.18.1
New tag.
- 12:59 PM Changeset in webkit [195934] by
-
- 2 edits in trunk/Source/WebKit2
Include the right WebKitAdditions files
<rdar://problem/24429804>
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState):
- 12:49 PM Changeset in webkit [195933] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r195932. rdar://problem/24430138
- 12:39 PM Changeset in webkit [195932] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge patch for rdar://problem/24426332 and rdar://problem/24209109.
- 12:27 PM Changeset in webkit [195931] by
-
- 4 edits in branches/safari-601-branch/Source/WebCore
Roll out r195817.
- 11:51 AM Changeset in webkit [195930] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 11:51 AM Changeset in webkit [195929] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 11:22 AM Changeset in webkit [195928] by
-
- 37 edits in trunk
Replace CaseFoldingHash with ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=153639
Reviewed by Filip Pizlo.
Source/WebCore:
- Modules/webdatabase/DatabaseAuthorizer.h: Use ASCIICaseInsensitiveHash
for whitelisted functions. Function names are all ASCII.
- accessibility/AccessibilityObject.cpp: Use ASCIICaseInsensitiveHash
for ARIA roles. ARIA roles are all ASCII.
- crypto/CryptoAlgorithmRegistry.h: Use ASCIICaseInsensitiveHash for
crypto algorithm names. Algorithm names are all ASCII.
- css/CSSFontSelector.cpp:
(WebCore::registerLocalFontFacesForFamily): Use ASCIICaseInsensitiveHash
for font faces. Face names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- css/CSSFontSelector.h: Ditto.
- dom/DOMImplementation.cpp: Use ASCIICaseInsensitiveHash for the
FeatureSet. The features are all ASCII.
- dom/Document.h: Use ASCIICaseInsensitiveHash for the access key
map. Access keys are all ASCII.
- dom/ScriptElement.cpp:
(WebCore::isLegacySupportedJavaScriptLanguage): Use ASCIICaseInsensitiveHash
for the language set. These strings are all ASCII.
- editing/EditorCommand.cpp: Use ASCIICaseInsensitiveHash for editor
command names. These names are all ASCII.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): Use ASCIICaseInsensitiveHash
for parameter names. These names are all ASCII.
- html/InputType.cpp: Use ASCIICaseInsensitiveHash for the input types.
The input types are all ASCII.
- loader/CrossOriginAccessControl.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- loader/CrossOriginPreflightResultCache.h: Ditto.
- loader/archive/ArchiveFactory.cpp: Use ASCIICaseInsensitiveHash for
MIME types. MIME types are all ASCII.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes): Ditto.
- platform/SchemeRegistry.h: Use ASCIICaseInsensitiveHas for URL schemes.
URL schemes are all ASCII.
- platform/URL.cpp: Ditto.
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::operator==): Use ASCIICaseInsensitiveHash.
(WebCore::FontPlatformDataCacheKeyHash::hash): Use ASCIICaseInsensitiveHash.
- platform/graphics/FontCascade.cpp:
(WebCore::keysMatch): Rename from operator== since this operation is not
equality. Changed to equalIgnoringASCIICase and did a little streamlining.
(WebCore::makeFontCascadeCacheKey): Use reserveInitialCapacity for slightly
better memory use.
(WebCore::computeFontCascadeCacheHash): Use IntegerHasher to make computing
a hash more efficient by eliminating the overhead of building a vector and
even possible heap allocation and deallocation.
(WebCore::retrieveOrAddCachedFonts): Use keysMatch instead of ==.
- platform/graphics/cocoa/FontCacheCoreText.cpp: Use ASCIICaseInsensitiveHash
for font family names. These names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- platform/network/HTTPHeaderMap.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- rendering/style/RenderStyle.cpp:
(WebCore::computeFontHash): Use IntegerHasher to avoid allocating memory just
to compute a hash. Use ASCIICaseInsensitiveHash.
Source/WebKit/win:
- WebCoreStatistics.cpp:
(WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
These names are all ASCII.
- WebURLResponse.cpp:
(WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
field names. These names are all ASCII.
Source/WebKit2:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Use ASCIICaseInsensitiveHash
for MIME types. MIME types are all ASCII.
- UIProcess/Plugins/PlugInAutoStartProvider.h: Use ASCIICaseInsensitiveHash for
origins. Origin strings should use ASCII case insensitive matching and should not
fold non-ASCII case.
- WebProcess/WebPage/WebPage.h: Use ASCIICaseInsensitiveHash for MIME types.
MIME types are all ASCII.
- WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters): Use ASCIICaseInsensitiveHash to hash plug-in
origin strings. (See rationale above.)
(WebKit::hashForPlugInOrigin): Updated comment.
Source/WTF:
- wtf/text/StringHash.h: Renamed CaseFoldingHash to ASCIICaseInsensitiveHash.
(WTF::ASCIICaseInsensitiveHash::foldCase): Use toASCIILower.
(WTF::ASCIICaseInsensitiveHash::equal): Use equalIgnoringASCIICase.
Also added some assertions.
- wtf/text/StringImpl.cpp: Made the latin1CaseFoldTable private to this file,
since it's no longer needed by CaseFoldingHash. Moved it up before its first use.
(WTF::equalCompatibilityCaseless): Fixed typo in the name of this function.
(WTF::equalCompatibiltyCaselessNonNull): Deleted.
- wtf/text/StringImpl.h: Removed declarations of latin1CaseFoldTable and
equalCompatibiltyCaselessNonNull
Tools:
- Scripts/do-webcore-rename: Use script to do this rename.
- 4:08 AM Changeset in webkit [195927] by
-
- 27 edits in trunk/Source
Reduce PassRefPtr uses in dom - 5
https://bugs.webkit.org/show_bug.cgi?id=153470
Reviewed by Darin Adler.
As a step to remove PassRefPtr, this patch reduces uses of PassRefPtr in WebCore/dom.
- dom/Document.cpp:
(WebCore::Document::adoptNode):
(WebCore::Document::implicitClose):
(WebCore::Document::enqueuePopstateEvent):
(WebCore::Document::setInputCursor):
- dom/Document.h:
- dom/DocumentMarker.cpp:
(WebCore::DocumentMarkerTextMatch::instanceFor):
- dom/Event.cpp:
(WebCore::Event::setUnderlyingEvent):
- dom/Event.h:
- dom/EventDispatcher.h:
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::enqueueEvent):
- dom/GenericEventQueue.h:
- dom/MouseEvent.cpp:
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
- dom/Node.cpp:
(WebCore::Node::dispatchDOMActivateEvent):
- dom/NodeIterator.h:
- dom/PendingScript.h:
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::create):
- dom/PopStateEvent.h:
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::setCSSStyleSheet): Deleted. Nobody calls this function.
- dom/ProcessingInstruction.h:
- dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):
- dom/TextEvent.cpp:
(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::TextEvent):
- dom/TextEvent.h:
- editing/Editor.cpp:
(WebCore::Editor::pasteAsFragment):
- editing/Editor.h:
- editing/mac/EditorMac.mm:
(WebCore::Editor::replaceNodeFromPasteboard):
- 3:41 AM Changeset in webkit [195926] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] don't save to a callee saved register too early
https://bugs.webkit.org/show_bug.cgi?id=153463
If we save $gp to $s4 in pichdr, then in some cases, we were
overwriting $s4 before LLInt's pushCalleeSaves() is called (as pichdr
is at the very beginning of a function). Now we save $gp to $s4 at the
end of pushCalleeSaves().
Patch by Guillaume Emont <guijemont@igalia.com> on 2016-01-31
Reviewed by Michael Saboff.
- offlineasm/mips.rb:
- llint/LowLevelInterpreter.asm:
Move the saving of $gp to $s4 from pichdr to pushCalleeSaves(). Take
the opportunity to only save $s4 as we never use the other callee
saved registers.
- 3:41 AM Changeset in webkit [195925] by
-
- 14 edits in trunk/Source
Use std::make_unique<> when creating an unique_ptr object.
https://bugs.webkit.org/show_bug.cgi?id=153705
Reviewed by Darin Adler.
Source/WebCore:
Some factory functions have used std::unique_ptr<> for creating an unique_ptr object.
It is wrong. We have to use std::make_unique<>.
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::mockPicker):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):
- platform/cf/RunLoopObserver.cpp:
(WebCore::RunLoopObserver::create): Deleted.
- platform/cf/RunLoopObserver.h:
(WebCore::RunLoopObserver::RunLoopObserver):
- platform/graphics/avfoundation/WebMediaSessionManagerMac.cpp:
(WebCore::WebMediaSessionManagerMac::platformPicker):
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::create): Deleted.
- platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::LayerFlushScheduler):
- platform/mock/MediaPlaybackTargetPickerMock.cpp:
(WebCore::MediaPlaybackTargetPickerMock::create): Deleted.
- platform/mock/MediaPlaybackTargetPickerMock.h:
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::copyToNewContainer):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Use std::make_unique<> instead of RunLoopObserver::create().
- 1:20 AM Changeset in webkit [195924] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
https://bugs.webkit.org/show_bug.cgi?id=152436
Reviewed by Darin Adler.
GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.
- web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
- web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:
Jan 30, 2016:
- 9:57 PM Changeset in webkit [195923] by
-
- 2 edits in trunk/Source/WebInspectorUI
Add the break-* properties to Web Inspector's completion set
https://bugs.webkit.org/show_bug.cgi?id=153706
Reviewed by Darin Adler.
- UserInterface/Models/CSSKeywordCompletions.js:
- 8:11 PM Changeset in webkit [195922] by
-
- 25 edits in trunk/Source/WebKit2
[Cocoa] Get rid of many WK_ macros for nullability
https://bugs.webkit.org/show_bug.cgi?id=153718
Sam Weinig reviewed an earlier version of this change, and Simon Fraser rubber-stamped this version.
- Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_ASSUME_NONNULL_{BEGIN, END}, WK_NULLABLE, WK_NULL_UNSPECIFIED, and WK_NULLABLE_PROPERTY. Removed the __has_feature(assume_nonnull) case.
- mac/postprocess-framework-headers.sh: Removed rules for rewriting the above macros. Also chanegd to rewrite WK_NULLABLE_SPECIFIER to the modern _Nullable instead of nullable.
Replaced instances of the above macros with their expansions.
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKElementInfo.h:
- UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- 7:59 PM Changeset in webkit [195921] by
-
- 2 edits in trunk/Websites/webkit.org
B3 documentation style shouldn't have hacks for h1
https://bugs.webkit.org/show_bug.cgi?id=153725
Reviewed by Alexey Proskuryakov.
- docs/b3/style.css:
- 5:22 PM Changeset in webkit [195920] by
-
- 25 edits in trunk/Source/WebKit2
Reverted r195914, because at least one of the build.webkit.org builders still uses a compiler that doesn’t understand _Nullable.
- Shared/API/Cocoa/WKFoundation.h:
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKElementInfo.h:
- UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- mac/postprocess-framework-headers.sh:
- 5:19 PM Changeset in webkit [195919] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK debug build after r195899
- dom/EventContext.h:
(isType):
- 5:15 PM Changeset in webkit [195918] by
-
- 2 edits in trunk/Source/WebCore
Add missing include to fix building debug configuration
https://bugs.webkit.org/show_bug.cgi?id=153719
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-30
Reviewed by Darin Adler.
No new tests.
- rendering/RenderObject.cpp:
- 4:53 PM Changeset in webkit [195917] by
-
- 37 edits in trunk
Unreviewed, rolling out r195911.
https://bugs.webkit.org/show_bug.cgi?id=153723
Caused frequent assertion failures on bots (Requested by ap on
#webkit).
Reverted changeset:
"Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
https://bugs.webkit.org/show_bug.cgi?id=153639
http://trac.webkit.org/changeset/195911
- 4:41 PM Changeset in webkit [195916] by
-
- 64 edits in trunk
Unreviewed, rolling out r195799 and r195828.
https://bugs.webkit.org/show_bug.cgi?id=153722
Caused assertion failures, severely affecting EWS (Requested
by ap on #webkit).
Reverted changesets:
"Web Inspector: InspectorTimelineAgent doesn't need to
recompile functions because it now uses the sampling profiler"
https://bugs.webkit.org/show_bug.cgi?id=153500
http://trac.webkit.org/changeset/195799
"Attempt to fix the Windows build after r195799"
http://trac.webkit.org/changeset/195828
- 4:24 PM Changeset in webkit [195915] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network panel is empty until the window is resized
https://bugs.webkit.org/show_bug.cgi?id=153701
<rdar://problem/24423739>
Reviewed by Timothy Hatcher.
NetworkGridContentView shouldn't prevent a layout from being scheduled
when the network sidebar is collapsed.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView.prototype.needsLayout): Deleted.
Removed View.prototype.needsLayout override that was preventing
layouts from being scheduled as timeline records are added.
- 3:50 PM Changeset in webkit [195914] by
-
- 25 edits in trunk/Source/WebKit2
[Cocoa] Get rid of WK_ macros for nullability
https://bugs.webkit.org/show_bug.cgi?id=153718
Reviewed by Sam Weinig.
- Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_ASSUME_NONNULL_{BEGIN, END}, WK_NULLABLE, WK_NULL_UNSPECIFIED, WK_NULLABLE_SPECIFIER, and WK_NULLABLE_PROPERTY.
- mac/postprocess-framework-headers.sh: Removed rules for rewriting those macros.
Replaced instances of those macros with their expansions, but using the modern _Nullable
instead of nullable:
- UIProcess/API/Cocoa/WKBackForwardList.h:
- UIProcess/API/Cocoa/WKBackForwardListItem.h:
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKFrameInfo.h:
- UIProcess/API/Cocoa/WKNavigationAction.h:
- UIProcess/API/Cocoa/WKNavigationDelegate.h:
- UIProcess/API/Cocoa/WKNavigationResponse.h:
- UIProcess/API/Cocoa/WKScriptMessage.h:
- UIProcess/API/Cocoa/WKScriptMessageHandler.h:
- UIProcess/API/Cocoa/WKSecurityOrigin.h:
- UIProcess/API/Cocoa/WKUIDelegate.h:
- UIProcess/API/Cocoa/WKUserContentController.h:
- UIProcess/API/Cocoa/WKUserScript.h:
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
- UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.h:
- UIProcess/API/Cocoa/WKWindowFeatures.h:
- UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
- UIProcess/API/Cocoa/_WKElementInfo.h:
- UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
- UIProcess/API/Cocoa/_WKUserStyleSheet.h:
- 2:25 PM Changeset in webkit [195913] by
-
- 4 edits in trunk
Modern IDB: Some tests crash with specific odd database names.
https://bugs.webkit.org/show_bug.cgi?id=153688
Reviewed by Darin Adler.
Source/WebCore:
No new tests (2 existing tests now pass).
- platform/FileSystem.cpp:
(WebCore::shouldEscapeUChar): Return true for some surrogate-pair situations.
(WebCore::encodeForFileName): Pass along the previous and next characters, as well,
and do a two byte escaping for some characters.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:19 PM Changeset in webkit [195912] by
-
- 5 edits2 adds in trunk
More than one audio and/or text track sometimes selected in media controls menu
https://bugs.webkit.org/show_bug.cgi?id=153664
Source/WebCore:
Use an <img> element for the track menu item checkmark instead of a background image and
the ::before selector.
Reviewed by Jer Noble.
Test: media/controls/track-menu.html
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-closed-captions-container li:hover):
(audio::-webkit-media-controls-closed-captions-container li .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected:hover .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected::before): Deleted.
(audio::-webkit-media-controls-closed-captions-container li.selected:hover::before): Deleted.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.):
(Controller.prototype.getCurrentControlsStatus):
LayoutTests:
Reviewed by Jer Noble.
- media/controls/controls-test-helpers.js:
(ControlsTest.prototype.get currentState):
(ControlsTest.prototype.get video):
(ControlsTest.prototype.stateForControlsElement):
(ControlsTest.prototype.handleEvent):
(ControlsTest.prototype.setup):
(ControlsTest.prototype.start):
(ControlsTest.prototype.isEqualTo):
(ControlsTest.prototype.isNotEqualTo):
(ControlsTest.prototype.contains):
- media/controls/track-menu-expected.txt: Added.
- media/controls/track-menu.html: Added.
- 1:53 PM Changeset in webkit [195911] by
-
- 37 edits in trunk
Replace CaseFoldingHash with ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=153639
Reviewed by Filip Pizlo.
Source/WebCore:
- Modules/webdatabase/DatabaseAuthorizer.h: Use ASCIICaseInsensitiveHash
for whitelisted functions. Function names are all ASCII.
- accessibility/AccessibilityObject.cpp: Use ASCIICaseInsensitiveHash
for ARIA roles. ARIA roles are all ASCII.
- crypto/CryptoAlgorithmRegistry.h: Use ASCIICaseInsensitiveHash for
crypto algorithm names. Algorithm names are all ASCII.
- css/CSSFontSelector.cpp:
(WebCore::registerLocalFontFacesForFamily): Use ASCIICaseInsensitiveHash
for font faces. Face names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- css/CSSFontSelector.h: Ditto.
- dom/DOMImplementation.cpp: Use ASCIICaseInsensitiveHash for the
FeatureSet. The features are all ASCII.
- dom/Document.h: Use ASCIICaseInsensitiveHash for the access key
map. Access keys are all ASCII.
- dom/ScriptElement.cpp:
(WebCore::isLegacySupportedJavaScriptLanguage): Use ASCIICaseInsensitiveHash
for the language set. These strings are all ASCII.
- editing/EditorCommand.cpp: Use ASCIICaseInsensitiveHash for editor
command names. These names are all ASCII.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin): Use ASCIICaseInsensitiveHash
for parameter names. These names are all ASCII.
- html/InputType.cpp: Use ASCIICaseInsensitiveHash for the input types.
The input types are all ASCII.
- loader/CrossOriginAccessControl.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- loader/CrossOriginPreflightResultCache.h: Ditto.
- loader/archive/ArchiveFactory.cpp: Use ASCIICaseInsensitiveHash for
MIME types. MIME types are all ASCII.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes): Ditto.
- platform/SchemeRegistry.h: Use ASCIICaseInsensitiveHas for URL schemes.
URL schemes are all ASCII.
- platform/URL.cpp: Ditto.
- platform/graphics/FontCache.cpp: Reworked FontPlatformDataCacheKey struct:
Made it a conventional struct with non-prefixed data members names. Removed
the "==" operator since it was appropriate for hash table lookup but wasn't
a true equality operator. Tightened the implementations of the constructors.
(WebCore::FontPlatformDataCacheKeyHash::hash): Use ASCIICaseInsensitiveHash.
(WebCore::FontPlatformDataCacheKeyHash::equal): Do the equality check here,
not using the == operator. And use equalIgnoringASCIICase.
(WebCore::FontPlatformDataCacheKeyTraits::isEmptyValue): Added this entire
traits struct so we check empty values in a more efficient way.
(WebCore::FontCache::getCachedFontPlatformData): Added comments and tweaked
style in this function.
- platform/graphics/FontCascade.cpp:
(WebCore::keysMatch): Rename from operator== since this operation is not
equality. Changed to equalIgnoringASCIICase and did a little streamlining.
(WebCore::makeFontCascadeCacheKey): Use reserveInitialCapacity for slightly
better memory use.
(WebCore::computeFontCascadeCacheHash): Use IntegerHasher to make computing
a hash more efficient by eliminating the overhead of building a vector and
even possible heap allocation and deallocation.
(WebCore::retrieveOrAddCachedFonts): Use keysMatch instead of ==.
- platform/graphics/cocoa/FontCacheCoreText.cpp: Use ASCIICaseInsensitiveHash
for font family names. These names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.
- platform/network/HTTPHeaderMap.h: Use ASCIICaseInsensitiveHash for
HTTP header field names. These names are all ASCII.
- rendering/style/RenderStyle.cpp:
(WebCore::computeFontHash): Use IntegerHasher to avoid allocating memory just
to compute a hash. Use ASCIICaseInsensitiveHash.
Source/WebKit/win:
- WebCoreStatistics.cpp:
(WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
These names are all ASCII.
- WebURLResponse.cpp:
(WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
field names. These names are all ASCII.
Source/WebKit2:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Use ASCIICaseInsensitiveHash
for MIME types. MIME types are all ASCII.
- UIProcess/Plugins/PlugInAutoStartProvider.h: Use ASCIICaseInsensitiveHash for
origins. Origin strings should use ASCII case insensitive matching and should not
fold non-ASCII case.
- WebProcess/WebPage/WebPage.h: Use ASCIICaseInsensitiveHash for MIME types.
MIME types are all ASCII.
- WebProcess/WebProcess.cpp:
(WebKit::addCaseFoldedCharacters): Use ASCIICaseInsensitiveHash to hash plug-in
origin strings. (See rationale above.)
(WebKit::hashForPlugInOrigin): Updated comment.
Source/WTF:
- wtf/text/StringHash.h: Renamed CaseFoldingHash to ASCIICaseInsensitiveHash.
(WTF::ASCIICaseInsensitiveHash::foldCase): Use toASCIILower.
(WTF::ASCIICaseInsensitiveHash::equal): Use equalIgnoringASCIICase.
Also added some assertions.
- wtf/text/StringImpl.cpp: Made the latin1CaseFoldTable private to this file,
since it's no longer needed by CaseFoldingHash. Moved it up before its first use.
(WTF::equalCompatibilityCaseless): Fixed typo in the name of this function.
(WTF::equalCompatibiltyCaselessNonNull): Deleted.
- wtf/text/StringImpl.h: Removed declarations of latin1CaseFoldTable and
equalCompatibiltyCaselessNonNull
Tools:
- Scripts/do-webcore-rename: Use script to do this rename.
- 1:49 PM Changeset in webkit [195910] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Object tree parent items are misaligned
https://bugs.webkit.org/show_bug.cgi?id=153699
<rdar://problem/24423683>
Patch by Devin Rousso <Devin Rousso> on 2016-01-30
Reviewed by Darin Adler.
- UserInterface/Views/ObjectTreeView.css:
(.object-tree .object-tree):
Ensure that toplevel Object preview trees are displayed properly while also
making child trees inline.
- UserInterface/Views/TreeOutline.css:
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon): Deleted.
This would apply to all .icon elements contained within a non-parent item,
which is not the desired effect. Instead, this should only apply to only the
.icon element of that particular non-parent item.
- 1:39 PM Changeset in webkit [195909] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r195871.
Caused several layout tests to time out
Reverted changeset:
"Tab suspension code shouldn't use page cache cacheability
logic"
https://bugs.webkit.org/show_bug.cgi?id=153680
http://trac.webkit.org/changeset/195871
- 1:34 PM Changeset in webkit [195908] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rebaseline bindings tests after r195904.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::setJSTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::jsTestEventTargetConstructor):
(WebCore::setJSTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot):
(WebCore::jsTestOverrideBuiltinsConstructor):
(WebCore::setJSTestOverrideBuiltinsConstructor):
- 1:01 PM Changeset in webkit [195907] by
-
- 32 edits4 adds in trunk
[JS Bindings] prototype.constructor should be writable
https://bugs.webkit.org/show_bug.cgi?id=149412
<rdar://problem/22545096>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/fetch/api/headers/headers-idl-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
prototype.constructor should have the following properties:
{ Writable: true, Enumerable: false, Configurable: true }
as per the Web IDL specification:
https://heycam.github.io/webidl/#interface-prototype-object
In WebKit, it is currently not writable. It is writable in Firefox.
This patch was first landed in r190085 but was rolled out for causing
crashes: <rdar://problem/22825602>. The issue was that even though we
marked constructor as writable, we failed to generate a setter for it.
This patch addresses the issue and the crash in <rdar://problem/22825602>
no longer occurs after this change. A regression test is also added for
this crash.
Tests:
fast/dom/HTMLDocument/constructor-setter-crash.html
fast/dom/prototype-constructor-setter.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::setJSTestActiveDOMObjectConstructor):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::setJSTestClassWithJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::setJSTestCustomConstructorWithNoInterfaceObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::setJSTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::setJSTestEventConstructorConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::setJSTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::setJSTestExceptionConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::setJSTestGenerateIsReachableConstructor):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::setJSTestInterfaceConstructor):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::setJSTestJSBuiltinConstructorConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::setJSTestMediaQueryListListenerConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::setJSTestNamedConstructorConstructor):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::setJSTestNodeConstructor):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::setJSTestNondeterministicConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::setJSTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::setJSTestOverrideBuiltinsConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::setJSTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsConstructor):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::setJSattributeConstructor):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::setJSreadonlyConstructor):
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/HTMLDocument/constructor-setter-crash-expected.txt: Added.
- fast/dom/HTMLDocument/constructor-setter-crash.html: Added.
Add regression test for crash at <rdar://problem/22825602>.
- fast/dom/prototype-constructor-setter-expected.txt: Added.
- fast/dom/prototype-constructor-setter.html: Added.
Add new test checking that prototype.constructor is writable.
- js/dom/constructor-attributes-expected.txt:
Rebaseline existing test now that prototype.constructor is writable.
- 12:57 PM Changeset in webkit [195906] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3] JetStream/quicksort.c fails/hangs on Linux with GCC
https://bugs.webkit.org/show_bug.cgi?id=153647
Reviewed by Filip Pizlo.
In B3ComputeDivisionMagic, we accidentally perform sub, add operation onto signed integer. (In this case, int32_t)
But integer overflow is undefined behavior in C[1][2]
As a result, in GCC 4.9 release build, computeDivisionMagic(2) returns unexpected value.
divisor = 2
d = 2
signedMin = INT32_MIN = -2147483647 (-0x7fffffff)
t = signedMin
anc = t - 1 - (t % ad)Oops, we performed overflow operation!
So,
ancvalue becomes undefined.
In this patch, we first cast all the operated values to unsigned one.
Reading the code, there are no operations that depends on signedness. (For example, we used aboveEqual like unsigned operations for comparison.)
[1]: http://blog.llvm.org/2011/05/what-every-c-programmer-should-know.html
[2]: http://dl.acm.org/citation.cfm?id=2522728
- b3/B3ComputeDivisionMagic.h:
(JSC::B3::computeDivisionMagic):
- b3/testb3.cpp:
(JSC::B3::testComputeDivisionMagic):
(JSC::B3::run):
- 12:48 PM Changeset in webkit [195905] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shrink Heap::m_executables after cleaning it.
<https://webkit.org/b/153682>
Reviewed by Darin Adler.
The Heap::m_executables Vector was never shrunk down, despite sometimes
getting pretty huge (~500kB in my longest-running WebContent process.)
After GC has finished pruning unmarked Executables, shrink the Vector.
- heap/Heap.cpp:
(JSC::Heap::clearUnmarkedExecutables):
- 12:10 PM Changeset in webkit [195904] by
-
- 12 edits in trunk
Move more 'constructor' properties to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153667
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing. A lot of
the 'constructor' attributes checks are still failing because the
attribute is not writable. This is being addressed via Bug 149412.
- web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move more 'constructor' properties to the prototype. In particular, we
used to keep the 'constructor' on the instance for interfaces that have
an indexed / named property getter because our getOwnPropertySlot()
implementation used to be wrong for such interfaces.
However, getOwnPropertySlot() should be correct after r188590 so we
should now be able to move the 'constructor' up to the prototype for
these interfaces, as per the specification:
http://heycam.github.io/webidl/#interface-prototype-object
No new tests, already covered by existing tests.
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
Add a null check for staticPropHashTable. It is now null because this
type no longer has any property on the instance now that 'constructor'
is on the prototype.
- bindings/scripts/CodeGeneratorJS.pm:
(ConstructorShouldBeOnInstance):
LayoutTests:
Rebaseline a couple of tests now that 'constructor' is on the prototype
for more interfaces.
- fast/dom/htmlcollection-getownpropertynames-expected.txt:
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
- 12:06 PM Changeset in webkit [195903] by
-
- 5 edits in trunk/Websites/webkit.org
Improve the style of B3 documentation
https://bugs.webkit.org/show_bug.cgi?id=153674
Reviewed by Oliver Hunt.
This makes the style of the B3 documentation look like the Wiki, which I think is
appropriate for the kind of content that we're putting into it - in particular, the font
is the perfect size for dense content. The style also doesn't require much spoonfeeding
from the HTML side so you can write nice looking documentation by just using really
basic HTML constructs.
- docs/b3/assembly-intermediate-representation.html:
- docs/b3/index.html:
- docs/b3/intermediate-representation.html:
- docs/b3/style.css:
- 12:01 PM Changeset in webkit [195902] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use configured python executable when executing generate-inspector-gresource-manifest.py
https://bugs.webkit.org/show_bug.cgi?id=153712
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-30
Reviewed by Michael Catanzaro.
- PlatformGTK.cmake:
- 11:30 AM Changeset in webkit [195901] by
-
- 10 edits in trunk/Source
Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
https://bugs.webkit.org/show_bug.cgi?id=153665
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
Remove this as the flag is already defined in FeatureDefines.xcconfig files.
- 11:22 AM Changeset in webkit [195900] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebKit1 apps crash in _ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1
<http://webkit.org/b/153710>
<rdar://problem/23116706>
Reviewed by Darin Adler.
- loader/cocoa/DiskCacheMonitorCocoa.mm:
(WebCore::DiskCacheMonitor::DiskCacheMonitor):
- Fix race condition on iOS WebKit1 clients by calling the block to cancel the DiskCacheMonitor on the WebThread, which is the same thread where the CFCachedURLResponseCallBackBlock is called.
- Removed whitespace to adhere to style.
- 10:38 AM Changeset in webkit [195899] by
-
- 14 edits2 adds in trunk
TouchList should be retargeted
https://bugs.webkit.org/show_bug.cgi?id=149592
Reviewed by Antti Koivisto.
Source/WebCore:
Retarget touch target's using the same algorithm as the one used for related targets instead of
EventRelatedNodeResolver which is removed in this patch.
Also enable the retargeting on iOS.
Test: fast/shadow-dom/touch-event-ios.html
- dom/EventContext.cpp:
(WebCore::TouchEventContext::TouchEventContext):
(WebCore::TouchEventContext::handleLocalEvents):
(WebCore::TouchEventContext::checkReachability):
- dom/EventContext.h:
(WebCore::toTouchEventContext):
(WebCore::EventContext::isUnreachableNode):
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver): Deleted.
(WebCore::EventPath::EventPath):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::addRelatedNodeResolversForTouchList): Deleted.
(WebCore::EventPath::updateTouchLists): Deleted.
(WebCore::EventPath::setRelatedTarget): Removed superfluous UNUSED_PARAM since the argument is always used.
(WebCore::EventPath::retargetTouch): Extracted from updateTouchLists/setRelatedTarget. Clones Touch object
with the new target for each event context just like related targets.
(WebCore::EventPath::retargetTouchLists): Renamed from updateTouchLists. Calls retargetTouch on each Touch
object in each TouchList.
- dom/TouchEvent.h:
Tools:
Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::touchDownAtPoint): Added.
(WTR::UIScriptController::liftUpAtPoint): Added.
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
(-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::touchDownAtPoint): Added.
(WTR::UIScriptController::liftUpAtPoint): Added.
LayoutTests:
Added a regression test for retargeting touch targets on iOS.
- fast/shadow-dom/touch-event-ios-expected.txt: Added.
- fast/shadow-dom/touch-event-ios.html: Added.
- platform/mac/TestExpectations: Added the failing expectation on Mac since touch support is not enabled.
- 10:09 AM Changeset in webkit [195898] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3] REGRESSION(r195882): Should break early after modConstant replaceWithNewValue succeeds
https://bugs.webkit.org/show_bug.cgi?id=153711
Reviewed by Filip Pizlo.
Should break after modConstant replaceWithNewValue succeeds. m_value is already replaced with Identity
if modConstant succeeds. So it does not have any children. m_value->child(1) breaks testb3.
- b3/B3ReduceStrength.cpp:
- 9:03 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:03 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:02 AM Changeset in webkit [195897] by
-
- 2 edits in trunk/LayoutTests
[GTK] Two disk cache tests are failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:48 AM Changeset in webkit [195896] by
-
- 2 edits in trunk/LayoutTests
[GTK] Some W3C DOM tests are failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:38 AM Changeset in webkit [195895] by
-
- 2 edits in trunk/LayoutTests
[GTK] IndexedDB expectations gardening
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:14 AM Changeset in webkit [195894] by
-
- 2 edits in trunk/LayoutTests
[GTK] platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html is failing
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 8:03 AM Changeset in webkit [195893] by
-
- 2 edits in trunk/LayoutTests
[GTK] Some organization in the test expectations file
Unreviewed.
- platform/gtk/TestExpectations:
- 7:33 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 7:28 AM Changeset in webkit [195892] by
-
- 20 edits35 adds in trunk
Support break-after, break-before and break-inside.
https://bugs.webkit.org/show_bug.cgi?id=148814
Reviewed by Dean Jackson.
Source/WebCore:
New tests added in printing/, fast/multicol/, and fast/regions.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::convertToPageBreak):
(WebCore::convertToColumnBreak):
(WebCore::convertToRegionBreak):
For backwards compatibility, keep support for all the old properties in
computed style. This means we have to convert the break-* property values
into keywords that make sense for the legacy properties. This mainly
involves mapping "page", "column", "region" to "always" (similar rule for
the avoid-* versions as well).
(WebCore::ComputedStyleExtractor::propertyValue):
Add support for the three new break-* properties.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
Add support for the new break properties.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator BreakBetween):
(WebCore::CSSPrimitiveValue::operator BreakInside):
Add converters for the new BreakBetween and BreakInside enums. Remove
the EPageBreak enum, since it is no longer used.
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
Add the new properties and the new values supported by the properties
to the keywords lists.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertFontSynthesis):
(WebCore::StyleBuilderConverter::convertPageBreakBetween):
(WebCore::StyleBuilderConverter::convertPageBreakInside):
(WebCore::StyleBuilderConverter::convertColumnBreakBetween):
(WebCore::StyleBuilderConverter::convertColumnBreakInside):
(WebCore::StyleBuilderConverter::convertRegionBreakBetween):
(WebCore::StyleBuilderConverter::convertRegionBreakInside):
In order to map the legacy properties into the new break-* values
we have custom converter functions.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
Patch the block code to check the correct new break-* constants. For
avoidance, this means checking both the general avoid value and the
specific value (e.g., avoid-page). In place of "always", we check
the specific value (e.g., column) and then for page specifically, we
also treat "left", "right", "recto" and "verso" as "always break" for now.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
Make sure changes to the break properties trigger relayout.
- rendering/style/RenderStyle.h:
Add getters and setters for the break-* properties and remove all
occurrences of the legacy page, column and region values from the RenderStyle.
- rendering/style/RenderStyleConstants.cpp:
(WebCore::alwaysPageBreak):
We have a helper function here for mapping several constant values to "page".
- rendering/style/RenderStyleConstants.h:
Definitions of the new BreakBetween and BreakInside enums.
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):
- rendering/style/StyleMultiColData.h:
Remove the column-specific break data.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
Remove the region-specific break data and replace it with generic break
data that is now used by all three pagination models.
LayoutTests:
- TestExpectations:
- fast/multicol/standardized-break-properties-expected.txt: Added.
- fast/multicol/standardized-break-properties.html: Added.
- fast/multicol/vertical-lr/standardized-break-properties-expected.txt: Added.
- fast/multicol/vertical-lr/standardized-break-properties.html: Added.
- fast/multicol/vertical-rl/standardized-break-properties-expected.txt: Added.
- fast/multicol/vertical-rl/standardized-break-properties.html: Added.
- fast/regions/text-break-properties-expected.txt: Added.
- fast/regions/text-break-properties.html: Added.
- printing/allowed-breaks-expected.txt: Added.
- printing/allowed-breaks.html: Added.
- printing/break-after-avoid-expected.txt: Added.
- printing/break-after-avoid-page-expected.txt: Added.
- printing/break-after-avoid-page.html: Added.
- printing/break-after-avoid.html: Added.
- printing/break-always-expected.txt: Added.
- printing/break-always.html: Added.
- printing/break-avoid-expected.txt: Added.
- printing/break-avoid-page-expected.txt: Added.
- printing/break-avoid-page.html: Added.
- printing/break-avoid.html: Added.
- printing/break-display-none-expected.txt: Added.
- printing/break-display-none.html: Added.
- printing/break-inside-avoid-expected.txt: Added.
- printing/break-inside-avoid-page-expected.txt: Added.
- printing/break-inside-avoid-page.html: Added.
- printing/break-inside-avoid.html: Added.
- printing/script-tests/allowed-breaks.js: Added.
(test):
- printing/script-tests/break-after-avoid-page.js: Added.
(test):
- printing/script-tests/break-after-avoid.js: Added.
(test):
- printing/script-tests/break-always.js: Added.
(test):
- printing/script-tests/break-avoid-page.js: Added.
(test):
- printing/script-tests/break-avoid.js: Added.
(test):
- printing/script-tests/break-display-none.js: Added.
(test):
- printing/script-tests/break-inside-avoid-page.js: Added.
(test):
- printing/script-tests/break-inside-avoid.js: Added.
(test):
- 7:25 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:53 AM Changeset in webkit [195891] by
-
- 13 edits in trunk
Enable SamplingProfiler on POSIX environment
https://bugs.webkit.org/show_bug.cgi?id=153584
Reviewed by Michael Saboff.
.:
Add features.h header check. It will define GLIBC.
- Source/cmake/OptionsCommon.cmake:
Source/JavaScriptCore:
In this patch, we implement suspend and resume mechanizm for POSIX threads.
And with GLIBC, we can retrieve registers from it.
We take the following strategy.
Suspend side.
- install sigaction to the threads.
- in the profiler (suspend / resume callers), emit signal with pthread_kill and wait with POSIX semaphore.
- in the signal handler, up the POSIX semaphore. Use sem_post because it is the async-signal-safe function in POSIX.
- in the signal handler, perform sigsuspend to stop the thread until being resumed.
- in the profiler, we can be waken up from the semaphore because (3) ups.
Resume side.
- in the profiler, emit signal and wait on the semaphore.
- in the signal handler, it is waken up from the sigsuspend.
- in the signal handler, up the semaphore.
- in the profiler, the profiler is waken up from the semaphore. It is ensured that the given thread is resumed by the signal.
- heap/MachineStackMarker.cpp:
(pthreadSignalHandlerSuspendResume):
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::~Thread):
(JSC::MachineThreads::Thread::suspend):
(JSC::MachineThreads::Thread::resume):
(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):
- heap/MachineStackMarker.h:
- runtime/SamplingProfiler.cpp:
(JSC::reportStats):
- tests/stress/call-varargs-from-inlined-code-with-odd-number-of-arguments.js:
- tests/stress/call-varargs-from-inlined-code.js:
- tests/stress/v8-earley-boyer-strict.js:
Source/WTF:
Use GLIBC since mcontext_t layout depends on it.
- wtf/Platform.h:
Tools:
- Scripts/run-jsc-stress-tests:
Jan 29, 2016:
- 11:10 PM B3IntermediateRepresentation created by
- 11:10 PM BareBonesBackend created by
- 10:03 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:59 PM Changeset in webkit [195890] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark two CSS multicolumn tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:57 PM Changeset in webkit [195889] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark two scrollbar tests as crashing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:56 PM Changeset in webkit [195888] by
-
- 2 edits in trunk/LayoutTests
[GTK] Really mark imported/blink/fast/css/first-letter-float-block.html as crashing
Unreviewed test gardening. Copypaste error in the previous commit.
- platform/gtk/TestExpectations:
- 9:53 PM Changeset in webkit [195887] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark imported/blink/fast/css/first-letter-float-block.html as crashing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:49 PM Changeset in webkit [195886] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark some accessibility role tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:47 PM Changeset in webkit [195885] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark some content security policy tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:46 PM Changeset in webkit [195884] by
-
- 2 edits in trunk/LayoutTests
[GTK] Mark Ruby expansion tests as failing
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 9:42 PM Changeset in webkit [195883] by
-
- 1 edit5 adds in trunk/LayoutTests
[GTK] Add expectations for media source SourceBuffer tests
Unreviewed test gardening.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-expected.txt: Added.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt: Added.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt: Added.
- platform/gtk/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt: Added.
- 9:14 PM Changeset in webkit [195882] by
-
- 2 edits in trunk/Source/JavaScriptCore
B3 should reduce Mod(value, constant) to Div and Mul so that our Div optimizations can do things
https://bugs.webkit.org/show_bug.cgi?id=153693
Reviewed by Saam Barati.
The most efficient way to handle Mod(value, constant) is to reduce it to
Sub(value, Mul(Div(value, constant), constant)) and then let the Div optimizations do their
thing.
In the future we could add special handling of Mod(value, 1 << constant), but it's not
obvious that this would produce better code than reducing through Div, if we also make sure
that we have great optimizations for Mul and Div.
- b3/B3ReduceStrength.cpp:
- 7:31 PM Changeset in webkit [195881] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Add support for variable size timeline graphs
https://bugs.webkit.org/show_bug.cgi?id=153690
<rdar://problem/24421696>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Timothy Hatcher.
- UserInterface/Views/LayoutTimelineDataGrid.js:
(WebInspector.LayoutTimelineDataGrid): Deleted.
Remove unnecessary constructor.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype.set selectedRecord):
Default graph height.
- UserInterface/Views/RenderingFrameTimelineOverview.js:
(WebInspector.RenderingFrameTimelineOverview.prototype.get height):
Custom graph height.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.get height):
Provide a way to get the height of the overview which accumulates graph heights.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.get timelineOverviewHeight):
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._updateTimelineOverviewHeight):
Switch from assuming certain graph heights to asking the overview for its height.
- 7:19 PM Changeset in webkit [195880] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Object previews in the Console are misaligned
https://bugs.webkit.org/show_bug.cgi?id=153676
<rdar://problem/24418796>
Patch by Devin Rousso <Devin Rousso> on 2016-01-29
Reviewed by Timothy Hatcher.
- UserInterface/Views/ObjectTreeView.css:
(.object-tree .tree-outline.object.compact):
(.object-tree): Deleted.
- 6:57 PM Changeset in webkit [195879] by
-
- 2 edits in trunk/Source/WebCore
[Win] Fix compile error.
https://bugs.webkit.org/show_bug.cgi?id=153646
Reviewed by Darin Adler.
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal):
- 6:45 PM Changeset in webkit [195878] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
Array.prototype native functions should use Symbol.species to construct the result
https://bugs.webkit.org/show_bug.cgi?id=153660
Reviewed by Saam Barati.
This patch adds support for Symbol.species in the Array.prototype native functions.
We make an optimization to avoid regressions on some benchmarks by using an
adaptive watchpoint to check if Array.prototype.constructor is ever changed.
- runtime/ArrayPrototype.cpp:
(JSC::putLength):
(JSC::setLength):
(JSC::speciesConstructArray):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::ArrayPrototype::setConstructor):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::ArrayPrototypeAdaptiveInferredPropertyWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
- runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::didChangeConstructorProperty):
- runtime/ConstructData.cpp:
(JSC::construct):
- runtime/ConstructData.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- tests/es6.yaml:
- tests/stress/array-species-functions.js: Added.
(Symbol.species):
(funcThrows):
(test.species):
(test):
- 6:36 PM Changeset in webkit [195877] by
-
- 3 edits in trunk/Source/JavaScriptCore
CallLinkStatus should trust BadCell exit sites whenever there is no stub
https://bugs.webkit.org/show_bug.cgi?id=153691
Reviewed by Benjamin Poulain.
This fixes a regression in our treatment of inlining failure exit sites when deciding if we
should inline a call.
A long time ago, a BadCell exit site would ensure that a CallLinkStatus returned
takesSlowPath.
But then we added closure calls. A BadCell exit site might just mean that we should do
closure call inlining. We added a BadExecutable exit site to indicate that even closure call
inlining had failed. BadCell would no longer force CallLinkStatus to return takesSlowPath,
but BadExecutable would stuff do so.
But then we unified the IR for checking functions and executables, and the DFG stopped using
the BadExecutable exit kind. Probably this change disabled our ability to use exit site
counting for deciding when to takesSlowPath. But this isn't necessarily a disaster, since
any time you exited in this way, you'd be taken to a baseline call inline cache, and that
inline cache would record the slow path.
But then we introduced polymorphic call inlining. Polymorphic call inlining means that call
unlinking, like when one of the callees is optimized, will reset the stub. We also made it
so that the stub is like a gate for the slow path count. A clear inline cache must first
cause the creation of a stub and then cause it to overflow before the slow path is counted.
So, if the DFG or FTL exits on a cell check associated with a particular callsite being
speculatively inlined, then it's possible that nobody will know about the exit because:
- The exit kind is BadCell but CallLinkStatus needs BadExecutable to disable inlining.
- Between when we tiered up to the DFG (or FTL) and when the exit happened, one of the callees was tiered up, causing the baseline CallLinkInfo to be unlinked. Therefore, after the exit, the inline cache is in a reset state and will not count the call as taking slow path.
The challenge when dealing with this is that often, we will have an super early compilation
of a minimorphic call site before we have seen all of its small set of callees. For example
we may have seen only one of two possible callees. That early compilation will OSR exit, and
in trunk, will be recompiled with bimorphic speculative inlining. That's a pretty good
outcome. Basically, we are trusting that if during the time that the function has been
running prior to a given compilation, a callsite has only seen a small number of callees,
then it's safe to assume that it won't see another one anytime soon.
So, simply forcing the CallLinkStatus to set takesSlowPath any time there was a BadCell exit
would hurt our performance in some cases, because trunk prior to this change would have their
final compilation use speculative inlining, and this change would make guarded inlining
instead.
The compromise that I came up with relies on the fact that a CallLinkInfo must be reset quite
frequently for it to routinely happen in between tier-up to DFG (or FTL) and an exit. So,
most likely, such a CallLinkInfo will also show up as being clear when the CallLinkStatus
is built during DFG profiling. The CallLinkStatus will then fall back on the CallLinkInfo's
lastSeenCallee field, which is persistent across resets. This change just makes it so that
CallLinkStatus sets takesSlowPath if there is a BadCell exit and the status had to be
inferred from the lastSeenCallee.
This change reduces pointless recompilations in gbemu. It's an 11% speed-up on gbemu. It
doesn't seem to hurt any benchmarks.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::computeExitSiteData):
(JSC::CallLinkStatus::computeFromCallLinkInfo):
- bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::CallLinkStatus):
(JSC::CallLinkStatus::at):
(JSC::CallLinkStatus::operator[]):
(JSC::CallLinkStatus::isProved):
(JSC::CallLinkStatus::isBasedOnStub):
(JSC::CallLinkStatus::canOptimize):
(JSC::CallLinkStatus::maxNumArguments):
(JSC::CallLinkStatus::ExitSiteData::ExitSiteData): Deleted.
- 6:05 PM Changeset in webkit [195876] by
-
- 7 edits in trunk/Source/JavaScriptCore
Pack FunctionExecutable and UnlinkedFunctionExecutable harder
https://bugs.webkit.org/show_bug.cgi?id=153687
Reviewed by Andreas Kling.
This patch reduces FunctionExecutable from 120 to 104 bytes.
This patch reduces UnlinkedFunctionExecutable from 144 to 136 bytes.
- bytecode/ExecutableInfo.h:
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/ParserModes.h:
(JSC::functionNameScopeIsDynamic):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::ScriptExecutable):
- runtime/Executable.h:
(JSC::ScriptExecutable::needsActivation):
(JSC::ScriptExecutable::isArrowFunctionContext):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::derivedContextType):
(JSC::ScriptExecutable::ecmaMode):
(JSC::ScriptExecutable::finishCreation):
- 5:53 PM Changeset in webkit [195875] by
-
- 1 copy in tags/Safari-601.5.13
New tag.
- 5:51 PM Changeset in webkit [195874] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Build fix after r195857. rdar://problem/24208101
- 5:38 PM Changeset in webkit [195873] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/block/basic/016.html for ios-simulator after r195740
Unreviewed test gardening.
- platform/ios-simulator/fast/block/basic/016-expected.txt:
- 5:31 PM Changeset in webkit [195872] by
-
- 2 edits in trunk/LayoutTests
Last commit should have marked fast/text/fallback-language-han-2.html as an ImageOnlyFailure. Fixing that.
https://bugs.webkit.org/show_bug.cgi?id=152438
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:29 PM Changeset in webkit [195871] by
-
- 3 edits in trunk/Source/WebCore
Tab suspension code shouldn't use page cache cacheability logic
https://bugs.webkit.org/show_bug.cgi?id=153680
Reviewed by Andreas Kling.
Most of PageCache::canCache() is unnecessary for tab suspension.
Also improve robustness.
- page/Page.cpp:
(WebCore::Page::setPageActivityState):
(WebCore::Page::setIsVisible):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setIsPrerender):
(WebCore::Page::canTabSuspend):
Include visibility test here.
Instead of calling PageCache::canCache() just check for each frame that
- that the document is loaded
- that active DOM objects allow suspension
(WebCore::Page::setIsTabSuspended):
(WebCore::Page::setTabSuspensionEnabled):
(WebCore::Page::updateTabSuspensionState):
Refactor for robustness.
(WebCore::Page::tabSuspensionTimerFired):
Call canTabSuspend, the result might have changed.
(WebCore::Page::scheduleTabSuspension): Deleted.
- page/Page.h:
- 5:28 PM Changeset in webkit [195870] by
-
- 2 edits in trunk/LayoutTests
Mark fast/text/fallback-language-han-2.html as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=152438
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:24 PM Changeset in webkit [195869] by
-
- 2 edits in trunk/LayoutTests
Marking two WPT dom-tree-accessors/document.getElementsByName tests as failing on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=153370
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:20 PM Changeset in webkit [195868] by
-
- 2 edits in trunk/LayoutTests
Marking webarchive/loading/object.html as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153380
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:14 PM Changeset in webkit [195867] by
-
- 1 copy in tags/Safari-601.1.46.95
New tag.
- 5:13 PM Changeset in webkit [195866] by
-
- 2 edits in trunk/LayoutTests
Marking all displaylists tests as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153656
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:11 PM Changeset in webkit [195865] by
-
- 45 edits3 adds in trunk/Source/JavaScriptCore
JSC Sampling Profiler: Come up with a (program counter => CodeOrigin) mapping
https://bugs.webkit.org/show_bug.cgi?id=152629
Reviewed by Filip Pizlo.
This patch implements a mapping from PC to CodeOrigin
that lives off of JITed CodeBlocks. We build this mapping
while JITing code, and then we compress it and store
it on the CodeBlock. We only build the mapping if a debugger
has ever been attached to any global object.
CodeBlock consults this mapping when searching for a CodeOrigin
for a given PC, but it also consults other code ranges
off the main path that may own the PC. Specifically, it searches
through inline caches, OSRExits, and LazySlowPaths.
To find PC info for the LLInt, we also save the LLInt pc when
taking a stack trace where the top frame is in LLInt code.
This patch also cleans up code inside the SamplingProfier.
I realized a bug in the SamplingProfiler's implementation.
We used to walk the inline stack while gathering a stack
trace. This is wrong. It's super dangerous to do this because
we might pause the JSC process while it's modifying its
CodeOrigin table. We used to walk the inline stack while
taking a stack trace because doing so could save us from
having to verify a particular stack trace. This patch changes that.
We now have to verify all stack traces taken. This verification step
includes walking the inline stack.
Because we have a PC=>CodeOrigin map, we can now gather more
detailed information about the top-frame we pause. This allows
us to correctly observe inlining. It also allows us to observe
expression-level line/column information for the top frame.
The reason we don't consult this mapping for parent frames is
that all parent frames should set the CallSiteIndex on the call
frame header, which means we can consult that value to get inlining
and expression-level line/column information.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::Label::operator==):
(JSC::AbstractMacroAssembler::Label::isSet):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerLabel::operator==):
- b3/B3Generate.cpp:
- b3/B3Origin.h:
(JSC::B3::Origin::data):
(JSC::B3::Origin::operator==):
- b3/B3PCToOriginMap.h: Added.
(JSC::B3::PCToOriginMap::PCToOriginMap):
(JSC::B3::PCToOriginMap::appendItem):
(JSC::B3::PCToOriginMap::ranges):
- b3/B3Procedure.h:
(JSC::B3::Procedure::pcToOriginMap):
(JSC::B3::Procedure::releasePCToOriginMap):
- b3/air/AirGenerate.cpp:
(JSC::B3::Air::generate):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
(JSC::CodeBlock::setPCToCodeOriginMap):
(JSC::CodeBlock::findPC):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCodeMap):
(JSC::CodeBlock::bytecodeOffset):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::operator==):
(JSC::CodeOriginHash::hash):
(JSC::CodeOriginHash::equal):
- bytecode/InlineCallFrame.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC::CodeOrigin::walkUpInlineStack):
- bytecode/PolymorphicAccess.h:
(JSC::PolymorphicAccess::containsPC):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitWeakReferences):
(JSC::StructureStubInfo::containsPC):
- bytecode/StructureStubInfo.h:
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::hasExpressionInfo):
(JSC::UnlinkedCodeBlock::expressionInfo):
(JSC::UnlinkedCodeBlock::setThisRegister):
- debugger/Debugger.cpp:
(JSC::Debugger::attach):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::validateReferences):
(JSC::DFG::JITCode::findPC):
- dfg/DFGJITCode.h:
(JSC::DFG::JITCode::commonDataOffset):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::recordCallSiteAndGenerateExceptionHandlingOSRExitIfNeeded):
(JSC::DFG::JITCompiler::setEndOfMainPath):
(JSC::DFG::JITCompiler::setEndOfCode):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::setStartOfCode):
(JSC::DFG::JITCompiler::setForNode):
(JSC::DFG::JITCompiler::addCallSite):
(JSC::DFG::JITCompiler::pcToCodeOriginMapBuilder):
(JSC::DFG::JITCompiler::setEndOfMainPath): Deleted.
(JSC::DFG::JITCompiler::setEndOfCode): Deleted.
- dfg/DFGSlowPathGenerator.h:
(JSC::DFG::SlowPathGenerator::call):
(JSC::DFG::SlowPathGenerator::origin):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
- ftl/FTLB3Compile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
(JSC::FTL::JITCode::findPC):
- ftl/FTLJITCode.h:
(JSC::FTL::JITCode::b3Code):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):
- heap/MachineStackMarker.h:
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
- jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITCode.h:
(JSC::JITCode::findPC):
- jit/PCToCodeOriginMap.cpp: Added.
(JSC::PCToCodeOriginMapBuilder::PCToCodeOriginMapBuilder):
(JSC::PCToCodeOriginMapBuilder::appendItem):
(JSC::PCToCodeOriginMap::PCToCodeOriginMap):
(JSC::PCToCodeOriginMap::~PCToCodeOriginMap):
(JSC::PCToCodeOriginMap::memorySize):
(JSC::PCToCodeOriginMap::findPC):
- jit/PCToCodeOriginMap.h: Added.
(JSC::PCToCodeOriginMapBuilder::defaultCodeOrigin):
(JSC::PCToCodeOriginMapBuilder::didBuildMapping):
- jsc.cpp:
(functionSamplingProfilerStackTraces):
- llint/LLIntPCRanges.h:
(JSC::LLInt::isLLIntPC):
- llint/LowLevelInterpreter.asm:
- runtime/Options.h:
- runtime/SamplingProfiler.cpp:
(JSC::reportStats):
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::resetAtMachineFrame):
(JSC::FrameWalker::isValidFramePointer):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::~SamplingProfiler):
(JSC::tryGetBytecodeIndex):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::visit):
(JSC::SamplingProfiler::noticeVMEntry):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::StackFrame::functionStartLine):
(JSC::SamplingProfiler::StackFrame::functionStartColumn):
(JSC::SamplingProfiler::StackFrame::sourceID):
(JSC::SamplingProfiler::StackFrame::url):
(JSC::SamplingProfiler::releaseStackTraces):
(JSC::SamplingProfiler::stackTracesAsJSON):
(WTF::printInternal):
(JSC::SamplingProfiler::StackFrame::startLine): Deleted.
(JSC::SamplingProfiler::StackFrame::startColumn): Deleted.
(JSC::SamplingProfiler::stackTraces): Deleted.
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
(JSC::SamplingProfiler::StackFrame::StackFrame):
(JSC::SamplingProfiler::StackTrace::StackTrace):
(JSC::SamplingProfiler::totalTime):
(JSC::SamplingProfiler::setStopWatch):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::setShouldBuildPCToCodeOriginMapping):
(JSC::VM::shouldBuilderPCToCodeOriginMapping):
- tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.top):
(platformSupportsSamplingProfiler.jaz):
(platformSupportsSamplingProfiler.kaz):
- 4:34 PM Changeset in webkit [195864] by
-
- 2 edits in trunk/LayoutTests
Marking fast/parser/external-entities-in-xslt.xml as flaky on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=153683
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:06 PM Changeset in webkit [195863] by
-
- 4 edits in trunk
fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
https://bugs.webkit.org/show_bug.cgi?id=153681
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.
- html/HTMLUnknownElement.h:
(WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):
LayoutTests:
Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.
- platform/ios-simulator/TestExpectations:
- 4:01 PM Changeset in webkit [195862] by
-
- 18 edits in trunk/Source/JavaScriptCore
Remove our notion of having a single activation register
https://bugs.webkit.org/show_bug.cgi?id=153673
Reviewed by Filip Pizlo.
We have many functions lurking around where we think a function
might only have one activation register. This is clearly wrong
now that ES6 has block scoping. This patch removes this false notion.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::scopeRegister):
(JSC::CodeBlock::codeType):
(JSC::CodeBlock::setActivationRegister): Deleted.
(JSC::CodeBlock::activationRegister): Deleted.
(JSC::CodeBlock::uncheckedActivationRegister): Deleted.
(JSC::CodeBlock::needsActivation): Deleted.
- bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::usesEval):
(JSC::ExecutableInfo::isStrictMode):
(JSC::ExecutableInfo::isConstructor):
(JSC::ExecutableInfo::isClassContext):
(JSC::ExecutableInfo::needsActivation): Deleted.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::isArrowFunctionContext):
(JSC::UnlinkedCodeBlock::isClassContext):
(JSC::UnlinkedCodeBlock::setThisRegister):
(JSC::UnlinkedCodeBlock::setScopeRegister):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::thisRegister):
(JSC::UnlinkedCodeBlock::scopeRegister):
(JSC::UnlinkedCodeBlock::addPropertyAccessInstruction):
(JSC::UnlinkedCodeBlock::needsFullScopeChain): Deleted.
(JSC::UnlinkedCodeBlock::setActivationRegister): Deleted.
(JSC::UnlinkedCodeBlock::activationRegister): Deleted.
(JSC::UnlinkedCodeBlock::hasActivationRegister): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeVarLexicalEnvironment):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::destinationForAssignResult):
(JSC::BytecodeGenerator::leftHandSideNeedsCopy):
(JSC::BytecodeGenerator::emitNodeForLeftHandSide):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::activationRegister): Deleted.
(JSC::DFG::Graph::uncheckedActivationRegister): Deleted.
(JSC::DFG::Graph::machineActivationRegister): Deleted.
(JSC::DFG::Graph::uncheckedMachineActivationRegister): Deleted.
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::callSiteIndex):
(JSC::CallFrame::stack):
(JSC::CallFrame::callerFrame):
(JSC::CallFrame::friendlyFunctionName):
(JSC::CallFrame::hasActivation): Deleted.
(JSC::CallFrame::uncheckedActivation): Deleted.
(JSC::CallFrame::lexicalEnvironment): Deleted.
(JSC::CallFrame::lexicalEnvironmentOrNullptr): Deleted.
(JSC::CallFrame::setActivation): Deleted.
- interpreter/CallFrame.h:
(JSC::ExecState::scope):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScope):
(JSC::ExecState::init):
- interpreter/Register.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Executable.h:
(JSC::ScriptExecutable::usesEval):
(JSC::ScriptExecutable::usesArguments):
(JSC::ScriptExecutable::isArrowFunctionContext):
(JSC::ScriptExecutable::isStrictMode):
(JSC::ScriptExecutable::derivedContextType):
(JSC::ScriptExecutable::needsActivation): Deleted.
- runtime/JSLexicalEnvironment.h:
(JSC::asActivation):
(JSC::Register::lexicalEnvironment): Deleted.
- 3:58 PM Changeset in webkit [195861] by
-
- 2 edits in trunk/LayoutTests
Missed one rebaseline for ios-simulator after r195740 in the last patch.
Unreviewed test gardening.
- platform/ios-simulator/fast/forms/form-in-malformed-markup-expected.txt:
- 3:47 PM WindowsWithoutCygwin edited by
- Added step regarding proxy environment variables - … (diff)
- 3:45 PM Changeset in webkit [195860] by
-
- 7 edits1 delete in trunk/LayoutTests
Rebaselining tests on ios-simulator after r195740
Unreviewed test gardning.
- platform/ios-simulator-wk2/editing/inserting/paragraph-separator-in-table-1-expected.txt: Removed.
- platform/ios-simulator/compositing/contents-opaque/table-parts-expected.txt:
- platform/ios-simulator/fast/text/emoji-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- 3:43 PM Changeset in webkit [195859] by
-
- 3 edits in trunk/Websites/webkit.org
Clean up the B3 documentation a bit
https://bugs.webkit.org/show_bug.cgi?id=153678
Reviewed by Saam Barati.
- docs/b3/index.html: Fix some links and fix small issues.
- docs/b3/intermediate-representation.html: Clean up some text and fix small issues.
- 3:42 PM Changeset in webkit [195858] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Build fix after r195857. rdar://problem/24208101.
- 3:41 PM Changeset in webkit [195857] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Build fix after r195847 rdar://problem/24208101.
- 3:34 PM Changeset in webkit [195856] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Break out some IDB failures with better descriptions.
- 3:31 PM Changeset in webkit [195855] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Finish getting rid of those conflict markers.
- 3:30 PM Changeset in webkit [195854] by
-
- 25 edits10 deletes in tags/Safari-602.1.17.2
Merged r195795. rdar://problem/24074990
- 3:30 PM Changeset in webkit [195853] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Get rid of conflit markers added to ChangeLog in r195837
- 3:28 PM Changeset in webkit [195852] by
-
- 5 edits in tags/Safari-602.1.17.2/Source
Versioning.
- 3:27 PM Changeset in webkit [195851] by
-
- 1 copy in tags/Safari-602.1.17.2
New tag.
- 3:23 PM Changeset in webkit [195850] by
-
- 4 edits in trunk
Modern IDB: Getting records for key ranges with null keys aren't properly handled in SQLite backend
https://bugs.webkit.org/show_bug.cgi?id=153666
Reviewed by Tim Horton.
Source/WebCore:
No new tests (Two failing tests now pass).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:18 PM Changeset in webkit [195849] by
-
- 12 adds in branches/safari-601-branch/LayoutTests/css3
Complete the merge of the patch in rdar://problem/24190682.
- 3:15 PM Changeset in webkit [195848] by
-
- 20 edits2 adds in trunk
image-rendering: -webkit-optimize-contrast not working for background images
https://bugs.webkit.org/show_bug.cgi?id=97991
Reviewed by Darin Adler.
Source/WebCore:
Don't equate "pixelated" and "crisp-edges" values for image-rendering with low
quality scaling; they should map to InterpolationNone, not InterpolationLow.
To support this change ImageQualityController to return a InterpolationQuality
from the renamed chooseInterpolationQuality(). If the returned value is not
InterpolationDefault, set the GraphicsContext image interpolation when drawing
images and image buffers.
Remove the redundant "useLowQualityScale" from
Test: fast/images/image-rendering-interpolation.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
- html/HTMLCanvasElement.h:
- page/DragController.cpp:
(WebCore::DragController::doImageDrag):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):
(WebCore::InterpolationQualityMaintainer::InterpolationQualityMaintainer): Deleted.
(WebCore::InterpolationQualityMaintainer::~InterpolationQualityMaintainer): Deleted.
- platform/graphics/GraphicsContext.h:
(WebCore::ImagePaintingOptions::ImagePaintingOptions):
(WebCore::ImagePaintingOptions::usesDefaultInterpolation):
(WebCore::InterpolationQualityMaintainer::InterpolationQualityMaintainer):
(WebCore::InterpolationQualityMaintainer::~InterpolationQualityMaintainer):
- platform/graphics/GraphicsTypes.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::drawConsuming):
(WebCore::ImageBuffer::draw):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::interpolationQualityFromStyle):
(WebCore::ImageQualityController::chooseInterpolationQuality):
(WebCore::ImageQualityController::ImageQualityController): Deleted.
(WebCore::ImageQualityController::shouldPaintAtLowQuality): Deleted.
- rendering/ImageQualityController.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::chooseInterpolationQuality):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality): Deleted.
- rendering/RenderBoxModelObject.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintSnapshotImage):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/images/image-rendering-interpolation-expected.html: Added.
- fast/images/image-rendering-interpolation.html: Added.
- 3:13 PM Changeset in webkit [195847] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
Patch for rdar://problem/24208101
- 3:12 PM Changeset in webkit [195846] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Provide a way to clear the network panel
https://bugs.webkit.org/show_bug.cgi?id=153632
<rdar://problem/23317773>
Patch by Devin Rousso <Devin Rousso> on 2016-01-29
Reviewed by Timothy Hatcher.
Added a navigation item to the Network tab that resets the network grid's content.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.get navigationItems):
(WebInspector.NetworkGridContentView.prototype._clearNetworkItems):
- 3:10 PM Changeset in webkit [195845] by
-
- 2 edits in trunk/Source/JavaScriptCore
Air:fixObviousSpills should handle floats and doubles
https://bugs.webkit.org/show_bug.cgi?id=153197
Reviewed by Saam Barati.
This adds the most obvious handling of float spills, where we just enable load elimination on
float spill code.
- b3/air/AirFixObviousSpills.cpp:
- 3:06 PM Changeset in webkit [195844] by
-
- 2 edits in trunk/Source/WebKit2
Don’t use the “.Development” suffix for engineering builds targeting iOS devices, because the XPC cache is only aware of the unsuffixed service identifiers.
Reviewed by Chris Dumez.
- Configurations/DebugRelease.xcconfig:
- 3:01 PM Changeset in webkit [195843] by
-
- 2 edits in trunk/Tools
update-webkit-dependency fails to fetch updates through firewall on Windows
https://bugs.webkit.org/show_bug.cgi?id=153619
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-01-29
Reviewed by Myles C. Maxfield.
On Windows, when a firewall is present we need to read proxy settings
from environment variables.
This patch relies on the following environment variables being set:
HTTP_PROXY
HTTPS_PROXY
- Scripts/update-webkit-dependency:
- 2:59 PM Changeset in webkit [195842] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
https://bugs.webkit.org/show_bug.cgi?id=153671
<rdar://problem/24417029>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Brian Burg.
- UserInterface/Base/Setting.js:
(WebInspector.Setting.prototype.set value):
- 2:50 PM Changeset in webkit [195841] by
-
- 1 edit4 adds1 delete in trunk/Websites/webkit.org
B3 should have documentation
https://bugs.webkit.org/show_bug.cgi?id=153658
Reviewed by Saam Barati.
Change the documentation to use HTML instead of Markdown. Markdown has trouble with
definition lists. Things go downhill when you try to add paragraphs or code blocks to
a definition. That's unfortunate since we use definitions for the IR document.
Since there is no way to use our preferred styling for the IR document without doing a
lot of bad hacks, it's best if we just stick to HTML. It looks plain but it's highly
practical.
- docs/b3/assembly-intermediate-representation.html: Added.
- docs/b3/bare-bones-backend.md: Removed.
- docs/b3/index.html: Added.
- docs/b3/intermediate-representation.html: Added.
- docs/b3/style.css: Added.
(dd):
(dd:last-child):
- 2:11 PM Changeset in webkit [195840] by
-
- 2 edits in trunk/Source/WebKit2
One more iOS build fix.
Unreviewed.
- Platform/spi/ios/UIKitSPI.h:
- 1:29 PM Changeset in webkit [195839] by
-
- 2 edits in trunk/Websites/webkit.org
Add some defintion list styles.
- wp-content/themes/webkit/style.css:
(dl):
(dt):
(dd):
- 1:22 PM Changeset in webkit [195838] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/modern/index-3.html fails.
https://bugs.webkit.org/show_bug.cgi?id=153661
Reviewed by Tim Horton.
Source/WebCore:
No new tests (1 failing test now passes, others get closer).
When indexing a new record fails due to uniqueness constraints, remove all traces of the record.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 1:00 PM Changeset in webkit [195837] by
-
- 3 edits2 adds in trunk
Source/WebCore:
[WebGL] Check vertex array bounds before permitting a glDrawArrays to execute
https://bugs.webkit.org/show_bug.cgi?id=153643
<rdar://problem/23424456>
Reviewed by Dean Jackson.
Tested by fast/canvas/webgl/webgl-drawarrays-crash.html.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateDrawArrays): Make sure that we have at
least one buffer bound to a program if a drawArray call with a non-zero range of
requested data is being made.
(WebCore::WebGLRenderingContextBase::validateDrawElements): Drive-by formatting fix.
LayoutTests:
Test to check for stack recursion when indexed propertyNames defined using Object.defineProperty are deleted.
https://bugs.webkit.org/show_bug.cgi?id=149179
<rdar://problem/22708019>.
Patch by Pranjal Jumde <pjumde@apple.com> on 2015-12-22
Reviewed by Dean Jackson.
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt: Added.
- storage/domstorage/localstorage/delete-defineproperty-removal.html: Added.
- 12:37 PM Changeset in webkit [195836] by
-
- 3 edits in trunk/Source/JavaScriptCore
Shrink CodeBlock!
<https://webkit.org/b/153640>
Reviewed by Saam Barati.
Shrink CodeBlock by 112 bytes (from 640 to 528) by employing
these sophisticated tricks:
- Remove members that are not used by anyone.
- Don't cache both VM* and Heap* in members.
- Reorder members to minimize struct padding.
- Use RefCountedArray instead of Vector for arrays that never resize.
- Put a not-always-present HashMap in a std::unique_ptr.
This increases CodeBlock space efficiency by 20%, as we can now
fit 30 of them in a MarkedBlock, up from 25.)
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setNumParameters):
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::noticeIncomingCall):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::codeType):
(JSC::CodeBlock::ensureResultProfile):
(JSC::CodeBlock::heap):
- 12:35 PM Changeset in webkit [195835] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Duplicate tab-types being saved to setting, causing duplicate tabs to be opened
https://bugs.webkit.org/show_bug.cgi?id=153659
<rdar://problem/24413157>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Brian Burg.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector._rememberOpenTabs):
De-duplicate the setting when building the list of tabs for existing
cases where the setting has duplicates and de-duplicate storing into
the setting, which was causing the issue to begin with.
- 12:30 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 12:27 PM Changeset in webkit [195834] by
-
- 11 edits in trunk/LayoutTests
Rebaseline fast/forms tests after r195700
https://bugs.webkit.org/show_bug.cgi?id=153618
Unreviewed test gardening.
- fast/forms/date/ValidityState-rangeOverflow-date-expected.txt:
- fast/forms/date/ValidityState-rangeUnderflow-date-expected.txt:
- fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt:
- fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt:
- fast/forms/month/ValidityState-rangeOverflow-month-expected.txt:
- fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt:
- fast/forms/time/time-validity-rangeoverflow-expected.txt:
- fast/forms/time/time-validity-rangeunderflow-expected.txt:
- fast/forms/week/ValidityState-rangeOverflow-week-expected.txt:
- fast/forms/week/ValidityState-rangeUnderflow-week-expected.txt:
- 12:15 PM Changeset in webkit [195833] by
-
- 2 edits in trunk/Source/WebKit2
iOS build fix after r195826.
Unreviewed.
- Platform/spi/ios/UIKitSPI.h:
- 11:47 AM Changeset in webkit [195832] by
-
- 5 edits in trunk
Modern IDB: Fix logging that overwhelms python with strings of excessive length.
https://bugs.webkit.org/show_bug.cgi?id=153652
Reviewed by Tim Horton.
Source/WebCore:
No new tests (Two skipped tests now pass).
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::loggingString): Limit the length of the string.
- Modules/indexeddb/IDBKeyRangeData.cpp:
(WebCore::IDBKeyRangeData::loggingString): Limit the length of the string.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:46 AM Changeset in webkit [195831] by
-
- 24 edits3 adds in trunk
Exits from exceptions shouldn't jettison code
https://bugs.webkit.org/show_bug.cgi?id=153564
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We create two new exit kinds for exception-handling
OSRExits:
- ExceptionCheck: an exception check after a C call.
- GenericUnwind: an OSR exit executes because it's jumped to from genericUnwind machinery.
Having these two new exit kinds allows us to remove fields from
various OSRExit variants that store booleans indicating
if the exit is an exception handler, and if so, what kind
of exception handler. Most of this patch is just removing
those old fields and adding new equivalent functions.
This patch also implements the policy that we should never consider jettisoning
code from exits that happen from an exception check to an op_catch (it might be worth
considering a similar policy for 'throw'). We're choosing this policy because
it will almost never be more expensive, in total, to execute the OSR exit than
to execute the baseline variant of the code. When an exception is thrown, we do
really expensive work, like call through to genericUnwind, and also create an error
object with a stack trace. The cost of OSR exiting here is small in comparison to
those other operations. And penalizing a CodeBlock for OSR exiting from an exception
is silly because the basis of our implementation of exception handling in the
upper tiers is to OSR exit on a caught exception. So we used to penalize
ourselves for having an implementation that is correct w.r.t our design goals.
I've verified this hypothesis with on v8-raytrace by adding a new
benchmark that throws with very high frequency. Implementing
this policy on that benchmark results in about a 4-5% speed up.
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
(JSC::exitKindMayJettison):
(JSC::exitKindIsCountable): Deleted.
- bytecode/ExitKind.h:
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):
(JSC::DFG::JITCompiler::exceptionCheck):
(JSC::DFG::JITCompiler::recordCallSiteAndGenerateExceptionHandlingOSRExitIfNeeded):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::OSRExitBase):
(JSC::DFG::OSRExitBase::isExceptionHandler):
(JSC::DFG::OSRExitBase::isGenericUnwindHandler):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h:
(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::liveRegistersToPreserveAtExceptionHandlingCallSite):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::blessSpeculation):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::emitOSRExit):
(JSC::FTL::OSRExitDescriptor::emitOSRExitLater):
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::spillRegistersToSpillSlot):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):
(JSC::FTL::OSRExit::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExit::willArriveAtOSRExitFromCallOperation):
(JSC::FTL::exceptionTypeWillArriveAtOSRExitFromGenericUnwind): Deleted.
(JSC::FTL::OSRExit::willArriveAtOSRExitFromGenericUnwind): Deleted.
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLPatchpointExceptionHandle.cpp:
(JSC::FTL::PatchpointExceptionHandle::scheduleExitCreation):
(JSC::FTL::PatchpointExceptionHandle::scheduleExitCreationForUnwind):
(JSC::FTL::PatchpointExceptionHandle::PatchpointExceptionHandle):
(JSC::FTL::PatchpointExceptionHandle::createHandle):
- ftl/FTLPatchpointExceptionHandle.h:
LayoutTests:
- js/regress/script-tests/v8-raytrace-with-try-catch-high-frequency-throws.js: Added.
(randomException):
(Class.create):
(Object.extend):
(Flog.RayTracer.Color.prototype.initialize):
(Flog.RayTracer.Color.prototype.add):
(Flog.RayTracer.Color.prototype.addScalar):
(Flog.RayTracer.Color.prototype.subtract):
(Flog.RayTracer.Color.prototype.multiply):
(Flog.RayTracer.Color.prototype.multiplyScalar):
(Flog.RayTracer.Color.prototype.divideFactor):
(Flog.RayTracer.Color.prototype.limit):
(Flog.RayTracer.Color.prototype.distance):
(Flog.RayTracer.Color.prototype.blend):
(Flog.RayTracer.Color.prototype.brightness):
(Flog.RayTracer.Color.prototype.toString):
(Flog.RayTracer.Light.prototype.initialize):
(Flog.RayTracer.Light.prototype.toString):
(Flog.RayTracer.Vector.prototype.initialize):
(Flog.RayTracer.Vector.prototype.copy):
(Flog.RayTracer.Vector.prototype.normalize):
(Flog.RayTracer.Vector.prototype.magnitude):
(Flog.RayTracer.Vector.prototype.cross):
(Flog.RayTracer.Vector.prototype.dot):
(Flog.RayTracer.Vector.prototype.add):
(Flog.RayTracer.Vector.prototype.subtract):
(Flog.RayTracer.Vector.prototype.multiplyVector):
(Flog.RayTracer.Vector.prototype.multiplyScalar):
(Flog.RayTracer.Vector.prototype.toString):
(Flog.RayTracer.Ray.prototype.initialize):
(Flog.RayTracer.Ray.prototype.toString):
(Flog.RayTracer.Scene.prototype.initialize):
(Flog.RayTracer.Material.BaseMaterial.prototype.initialize):
(Flog.RayTracer.Material.BaseMaterial.prototype.getColor):
(Flog.RayTracer.Material.BaseMaterial.prototype.wrapUp):
(Flog.RayTracer.Material.BaseMaterial.prototype.toString):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.initialize):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.getColor):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.toString):
(Flog.RayTracer.Material.Solid.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.initialize):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.getColor):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial.toString):
(Flog.RayTracer.Material.Chessboard.prototype.Object.extend.new.Flog.RayTracer.Material.BaseMaterial):
(Flog.RayTracer.Shape.Sphere.prototype.initialize):
(Flog.RayTracer.Shape.Sphere.prototype.intersect):
(Flog.RayTracer.Shape.Sphere.prototype.toString):
(Flog.RayTracer.Shape.Plane.prototype.initialize):
(Flog.RayTracer.Shape.Plane.prototype.intersect):
(Flog.RayTracer.Shape.Plane.prototype.toString):
(Flog.RayTracer.IntersectionInfo.prototype.initialize):
(Flog.RayTracer.IntersectionInfo.prototype.toString):
(Flog.RayTracer.Camera.prototype.initialize):
(Flog.RayTracer.Camera.prototype.getRay):
(Flog.RayTracer.Camera.prototype.toString):
(Flog.RayTracer.Background.prototype.initialize):
(Flog.RayTracer.Engine.prototype.initialize):
(Flog.RayTracer.Engine.prototype.setPixel):
(Flog.RayTracer.Engine.prototype.renderScene):
(Flog.RayTracer.Engine.prototype.getPixelColor):
(Flog.RayTracer.Engine.prototype.testIntersection):
(Flog.RayTracer.Engine.prototype.getReflectionRay):
(Flog.RayTracer.Engine.prototype.rayTrace):
(renderScene):
- js/regress/v8-raytrace-with-try-catch-high-frequency-throws-expected.txt: Added.
- js/regress/v8-raytrace-with-try-catch-high-frequency-throws.html: Added.
- 11:19 AM Changeset in webkit [195830] by
-
- 1 edit3 adds in trunk/Websites/webkit.org
B3 should have documentation
https://bugs.webkit.org/show_bug.cgi?id=153658
Reviewed by Timothy Hatcher.
- docs: Added.
- docs/b3: Added.
- docs/b3/bare-bones-backend.md: Added.
- 11:15 AM Changeset in webkit [195829] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merged r195826. rdar://problem/24337778
- 11:13 AM Changeset in webkit [195828] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix the Windows build after r195799
Unreviewed build fix.
- WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
- 11:12 AM Changeset in webkit [195827] by
-
- 1100 edits12 copies50 adds in trunk/LayoutTests
[GTK] Unreviewed gardening after r195740 (v2).
https://bugs.webkit.org/show_bug.cgi?id=153654
Rebaseline another 652 tests after r195740.
Unreviewed.
- platform/gtk/accessibility/table-attributes-expected.txt:
- platform/gtk/accessibility/table-cell-spans-expected.txt:
- platform/gtk/accessibility/table-cells-expected.txt:
- platform/gtk/accessibility/table-sections-expected.txt:
- platform/gtk/accessibility/table-with-rules-expected.txt:
- platform/gtk/css2.1/20110323/inline-table-002a-expected.txt:
- platform/gtk/css2.1/20110323/table-height-algorithm-023-expected.txt:
- platform/gtk/css2.1/20110323/table-height-algorithm-024-expected.txt:
- platform/gtk/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
- platform/gtk/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
- platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
- platform/gtk/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
- platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/gtk/css2.1/t0805-c5522-brdr-02-e-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-00-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-01-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-02-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-03-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-05-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-07-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-09-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-10-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-11-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-12-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-15-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-19-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-20-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-21-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-22-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-23-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-26-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-27-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-28-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-29-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-32-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-33-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-35-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-36-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-37-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-38-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-39-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-40-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-45-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-46-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-47-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-48-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-49-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-50-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-51-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-53-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-55-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-56-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-57-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-58-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-60-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-61-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-62-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-63-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-66-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-67-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-68-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-69-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-72-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-73-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-75-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-76-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-77-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-78-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-79-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-80-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-81-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-82-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-83-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-86-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-87-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-88-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-89-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-90-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-91-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-92-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-93-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-95-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-96-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-97-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-98-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
- platform/gtk/css2.1/t170602-bdr-conflct-w-99-d-expected.png:
- platform/gtk/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-015-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-015-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-016-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-016-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-023-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-023-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-024-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-024-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-035-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-035-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-036-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-036-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-037-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-037-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-038-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-038-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-045-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-045-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-046-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-046-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-047-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-047-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-048-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-048-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-049-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-049-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-050-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-050-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-055-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-055-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-056-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-056-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-091-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-091-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-092-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-092-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-099-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-099-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-100-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-100-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-103-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-103-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-104-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-104-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-105-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-105-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-106-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-106-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-107-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-107-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-108-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-108-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-109-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-109-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-110-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-110-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-111-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-111-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-112-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-112-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-113-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-113-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-114-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-114-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-123-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-123-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-124-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-124-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-139-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-139-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-140-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-140-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-149-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-149-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-150-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-150-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-155-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-155-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-156-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-156-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-159-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-159-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-160-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-160-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-165-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-165-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-166-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-166-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-207-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-207-expected.txt:
- platform/gtk/css2.1/tables/table-anonymous-objects-208-expected.png: Added.
- platform/gtk/css2.1/tables/table-anonymous-objects-208-expected.txt:
- platform/gtk/css3/flexbox/flexbox-baseline-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-18b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-28-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-28-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-28b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-28b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-32-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-32-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-43-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-43b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-44-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-44b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-74-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-74-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-74b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-74b-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-78-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-78-expected.txt:
- platform/gtk/css3/selectors3/html/css3-modsel-78b-expected.png:
- platform/gtk/css3/selectors3/html/css3-modsel-78b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-32-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-18b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-28-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-28-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-28b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-28b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-32-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-32-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-43-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-43b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-44-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-44b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-78-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-78-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-78b-expected.png:
- platform/gtk/css3/selectors3/xml/css3-modsel-78b-expected.txt:
- platform/gtk/editing/deleting/5099303-expected.png:
- platform/gtk/editing/deleting/5099303-expected.txt:
- platform/gtk/editing/deleting/5483370-expected.png:
- platform/gtk/editing/deleting/5483370-expected.txt:
- platform/gtk/editing/deleting/delete-to-select-table-expected.png:
- platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
- platform/gtk/editing/deleting/table-cells-expected.png:
- platform/gtk/editing/deleting/table-cells-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.png:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/inserting/5058163-1-expected.png:
- platform/gtk/editing/inserting/5058163-1-expected.txt:
- platform/gtk/editing/inserting/insert-paragraph-01-expected.png:
- platform/gtk/editing/inserting/insert-paragraph-01-expected.txt:
- platform/gtk/editing/inserting/insert-paragraph-02-expected.png:
- platform/gtk/editing/inserting/insert-paragraph-02-expected.txt:
- platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/gtk/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/gtk/editing/pasteboard/5156401-1-expected.png:
- platform/gtk/editing/pasteboard/5156401-1-expected.txt:
- platform/gtk/editing/pasteboard/5387578-expected.png:
- platform/gtk/editing/pasteboard/5387578-expected.txt:
- platform/gtk/editing/selection/4818145-expected.png:
- platform/gtk/editing/selection/4818145-expected.txt:
- platform/gtk/editing/selection/4889598-expected.png:
- platform/gtk/editing/selection/4889598-expected.txt:
- platform/gtk/editing/selection/4895428-2-expected.png:
- platform/gtk/editing/selection/4895428-2-expected.txt:
- platform/gtk/editing/selection/5076323-1-expected.png:
- platform/gtk/editing/selection/5076323-1-expected.txt:
- platform/gtk/editing/selection/5076323-2-expected.png:
- platform/gtk/editing/selection/5076323-2-expected.txt:
- platform/gtk/editing/selection/5076323-3-expected.png:
- platform/gtk/editing/selection/5076323-3-expected.txt:
- platform/gtk/editing/selection/7152-1-expected.png:
- platform/gtk/editing/selection/7152-1-expected.txt:
- platform/gtk/editing/selection/7152-2-expected.png:
- platform/gtk/editing/selection/7152-2-expected.txt:
- platform/gtk/editing/selection/display-table-text-expected.png:
- platform/gtk/editing/selection/display-table-text-expected.txt:
- platform/gtk/editing/selection/iframe-expected.png:
- platform/gtk/editing/selection/iframe-expected.txt:
- platform/gtk/editing/selection/inline-table-expected.png:
- platform/gtk/editing/selection/inline-table-expected.txt:
- platform/gtk/editing/selection/mixed-editability-3-expected.png:
- platform/gtk/editing/selection/mixed-editability-3-expected.txt:
- platform/gtk/editing/selection/mixed-editability-4-expected.png:
- platform/gtk/editing/selection/mixed-editability-4-expected.txt:
- platform/gtk/editing/selection/mixed-editability-5-expected.png:
- platform/gtk/editing/selection/mixed-editability-5-expected.txt:
- platform/gtk/editing/selection/mixed-editability-8-expected.png:
- platform/gtk/editing/selection/mixed-editability-8-expected.txt:
- platform/gtk/editing/selection/mixed-editability-9-expected.png:
- platform/gtk/editing/selection/mixed-editability-9-expected.txt:
- platform/gtk/editing/selection/table-caret-1-expected.png:
- platform/gtk/editing/selection/table-caret-1-expected.txt:
- platform/gtk/editing/selection/table-caret-2-expected.png:
- platform/gtk/editing/selection/table-caret-2-expected.txt:
- platform/gtk/editing/selection/table-caret-3-expected.png:
- platform/gtk/editing/selection/table-caret-3-expected.txt:
- platform/gtk/editing/style/5017613-1-expected.png:
- platform/gtk/editing/style/5017613-1-expected.txt:
- platform/gtk/editing/style/5017613-2-expected.png:
- platform/gtk/editing/style/5017613-2-expected.txt:
- platform/gtk/editing/style/apple-style-editable-mix-expected.png:
- platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
- platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/gtk/fast/block/float/011-expected.txt:
- platform/gtk/fast/block/margin-collapse/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/005-expected.txt:
- platform/gtk/fast/block/margin-collapse/104-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/gtk/fast/block/positioning/053-expected.txt:
- platform/gtk/fast/borders/bidi-009a-expected.png:
- platform/gtk/fast/borders/bidi-009a-expected.txt:
- platform/gtk/fast/box-shadow/basic-shadows-expected.png:
- platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
- platform/gtk/fast/css-generated-content/015-expected.txt:
- platform/gtk/fast/css-generated-content/inline-display-types-expected.txt:
- platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
- platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
- platform/gtk/fast/css-generated-content/table-row-before-after-expected.txt:
- platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
- platform/gtk/fast/css/first-letter-float-expected.png:
- platform/gtk/fast/css/first-letter-float-expected.txt:
- platform/gtk/fast/css/layerZOrderCrash-expected.txt:
- platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
- platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/gtk/fast/dynamic/007-expected.txt:
- platform/gtk/fast/dynamic/014-expected.txt:
- platform/gtk/fast/dynamic/015-expected.png:
- platform/gtk/fast/dynamic/015-expected.txt:
- platform/gtk/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png:
- platform/gtk/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
- platform/gtk/fast/forms/button-white-space-expected.png:
- platform/gtk/fast/forms/button-white-space-expected.txt:
- platform/gtk/fast/forms/file/file-input-direction-expected.png:
- platform/gtk/fast/forms/file/file-input-direction-expected.txt:
- platform/gtk/fast/forms/form-added-to-table-expected.png:
- platform/gtk/fast/forms/form-added-to-table-expected.txt:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.png:
- platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/fast/invalid/table-inside-stray-table-content-expected.png:
- platform/gtk/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/gtk/fast/invalid/td-inside-object-expected.txt:
- platform/gtk/fast/lists/ordered-list-with-no-ol-tag-expected.png:
- platform/gtk/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/gtk/fast/overflow/overflow-auto-table-expected.txt:
- platform/gtk/fast/replaced/width100percent-button-expected.png:
- platform/gtk/fast/replaced/width100percent-button-expected.txt:
- platform/gtk/fast/ruby/ruby-inline-table-expected.txt:
- platform/gtk/fast/selectors/018-expected.png:
- platform/gtk/fast/selectors/018-expected.txt:
- platform/gtk/fast/selectors/018b-expected.txt:
- platform/gtk/fast/selectors/032-expected.png:
- platform/gtk/fast/selectors/032-expected.txt:
- platform/gtk/fast/selectors/043-expected.txt:
- platform/gtk/fast/selectors/043b-expected.txt:
- platform/gtk/fast/selectors/044-expected.txt:
- platform/gtk/fast/selectors/044b-expected.txt:
- platform/gtk/fast/selectors/078b-expected.png:
- platform/gtk/fast/selectors/078b-expected.txt:
- platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt:
- platform/gtk/fast/table/001-expected.txt:
- platform/gtk/fast/table/004-expected.png:
- platform/gtk/fast/table/004-expected.txt:
- platform/gtk/fast/table/006-expected.png:
- platform/gtk/fast/table/006-expected.txt:
- platform/gtk/fast/table/010-expected.txt:
- platform/gtk/fast/table/011-expected.png:
- platform/gtk/fast/table/011-expected.txt:
- platform/gtk/fast/table/015-expected.txt:
- platform/gtk/fast/table/016-expected.txt:
- platform/gtk/fast/table/022-expected.png:
- platform/gtk/fast/table/022-expected.txt:
- platform/gtk/fast/table/026-expected.txt:
- platform/gtk/fast/table/033-expected.txt:
- platform/gtk/fast/table/035-expected.png:
- platform/gtk/fast/table/035-expected.txt:
- platform/gtk/fast/table/035-vertical-expected.png:
- platform/gtk/fast/table/035-vertical-expected.txt:
- platform/gtk/fast/table/037-expected.txt:
- platform/gtk/fast/table/041-expected.png:
- platform/gtk/fast/table/041-expected.txt:
- platform/gtk/fast/table/auto-with-percent-height-expected.txt:
- platform/gtk/fast/table/auto-with-percent-height-vertical-expected.txt:
- platform/gtk/fast/table/cell-coalescing-expected.txt:
- platform/gtk/fast/table/cellindex-expected.txt:
- platform/gtk/fast/table/click-near-anonymous-table-expected.png:
- platform/gtk/fast/table/click-near-anonymous-table-expected.txt:
- platform/gtk/fast/table/colgroup-preceded-by-caption-expected.txt:
- platform/gtk/fast/table/colgroup-spanning-groups-rules-expected.txt:
- platform/gtk/fast/table/dynamic-descendant-percentage-height-expected.txt:
- platform/gtk/fast/table/floating-th-expected.txt:
- platform/gtk/fast/table/generated-caption-expected.png:
- platform/gtk/fast/table/generated-caption-expected.txt:
- platform/gtk/fast/table/insert-before-anonymous-ancestors-expected.png:
- platform/gtk/fast/table/insert-before-anonymous-ancestors-expected.txt:
- platform/gtk/fast/table/insert-cell-before-form-expected.png:
- platform/gtk/fast/table/insert-cell-before-form-expected.txt:
- platform/gtk/fast/table/insert-row-before-form-expected.png:
- platform/gtk/fast/table/insert-row-before-form-expected.txt:
- platform/gtk/fast/table/nested-percent-height-table-expected.png:
- platform/gtk/fast/table/nested-percent-height-table-expected.txt:
- platform/gtk/fast/table/quote-text-around-iframe-expected.png:
- platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
- platform/gtk/fast/table/rowindex-expected.png:
- platform/gtk/fast/table/rowindex-expected.txt:
- platform/gtk/fast/table/rtl-cell-display-none-assert-expected.png:
- platform/gtk/fast/table/rtl-cell-display-none-assert-expected.txt:
- platform/gtk/fast/table/rules-attr-dynchange1-expected.txt:
- platform/gtk/fast/table/rules-attr-dynchange2-expected.txt:
- platform/gtk/fast/table/table-after-child-in-table-expected.txt:
- platform/gtk/fast/table/table-and-parts-outline-expected.png:
- platform/gtk/fast/table/table-and-parts-outline-expected.txt:
- platform/gtk/fast/table/table-before-child-in-table-expected.txt:
- platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
- platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/gtk/fast/table/table-continuation-outline-paint-crash-expected.txt:
- platform/gtk/fast/table/table-hspace-align-center-expected.png:
- platform/gtk/fast/table/table-hspace-align-center-expected.txt:
- platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
- platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
- platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
- platform/gtk/fast/table/tableInsideCaption-expected.png:
- platform/gtk/fast/table/tableInsideCaption-expected.txt:
- platform/gtk/fast/table/text-field-baseline-expected.png:
- platform/gtk/fast/table/text-field-baseline-expected.txt:
- platform/gtk/fast/table/unbreakable-images-quirk-expected.png:
- platform/gtk/fast/table/unbreakable-images-quirk-expected.txt:
- platform/gtk/fast/table/vertical-align-baseline-expected.png:
- platform/gtk/fast/table/vertical-align-baseline-expected.txt:
- platform/gtk/fast/text/atsui-multiple-renderers-expected.png:
- platform/gtk/fast/text/atsui-multiple-renderers-expected.txt:
- platform/gtk/fast/text/basic/001-expected.png:
- platform/gtk/fast/text/basic/001-expected.txt:
- platform/gtk/fast/text/basic/006-expected.png:
- platform/gtk/fast/text/basic/006-expected.txt:
- platform/gtk/fast/text/basic/007-expected.png:
- platform/gtk/fast/text/basic/007-expected.txt:
- platform/gtk/fast/text/capitalize-boundaries-expected.png:
- platform/gtk/fast/text/capitalize-boundaries-expected.txt:
- platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
- platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
- platform/gtk/fast/text/whitespace/024-expected.png:
- platform/gtk/fast/text/whitespace/024-expected.txt:
- platform/gtk/fast/text/whitespace/027-expected.png:
- platform/gtk/fast/text/whitespace/027-expected.txt:
- platform/gtk/fast/text/word-break-expected.png:
- platform/gtk/fast/text/word-break-expected.txt:
- platform/gtk/fast/transforms/transform-table-row-expected.png:
- platform/gtk/fast/transforms/transform-table-row-expected.txt:
- platform/gtk/http/tests/misc/generated-content-inside-table-expected.txt:
- platform/gtk/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/gtk/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
- platform/gtk/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10036-expected.png:
- platform/gtk/tables/mozilla/bugs/bug10036-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug21918-expected.png.
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12384-expected.png.
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug103533-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug103533-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug106158-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug106158-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug108340-expected.png:
- platform/gtk/tables/mozilla/bugs/bug108340-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug110566-expected.png:
- platform/gtk/tables/mozilla/bugs/bug110566-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug11321-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.png.
- platform/gtk/tables/mozilla/bugs/bug11321-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug11944-expected.png:
- platform/gtk/tables/mozilla/bugs/bug11944-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug119786-expected.png:
- platform/gtk/tables/mozilla/bugs/bug119786-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug12384-expected.png:
- platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1261-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1261-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13105-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug13105-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13118-expected.png:
- platform/gtk/tables/mozilla/bugs/bug13118-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13484-expected.png:
- platform/gtk/tables/mozilla/bugs/bug13484-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug13526-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
- platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug17130-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug1828-expected.png:
- platform/gtk/tables/mozilla/bugs/bug1828-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug18558-expected.png:
- platform/gtk/tables/mozilla/bugs/bug18558-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2050-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2050-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug20579-expected.png:
- platform/gtk/tables/mozilla/bugs/bug20579-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug21299-expected.png:
- platform/gtk/tables/mozilla/bugs/bug21299-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug21918-expected.png:
- platform/gtk/tables/mozilla/bugs/bug21918-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug221784-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug221784-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug221784-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug221784-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2267-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2267-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23072-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12384-expected.png.
- platform/gtk/tables/mozilla/bugs/bug23072-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23151-expected.png:
- platform/gtk/tables/mozilla/bugs/bug23151-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug23299-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug24503-expected.png:
- platform/gtk/tables/mozilla/bugs/bug24503-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug24627-expected.png:
- platform/gtk/tables/mozilla/bugs/bug24627-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2469-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug24880-expected.png:
- platform/gtk/tables/mozilla/bugs/bug24880-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug25086-expected.png:
- platform/gtk/tables/mozilla/bugs/bug25086-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2516-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2516-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug25367-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2585-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2585-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
- platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug27038-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug27038-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug275625-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug55545-expected.png.
- platform/gtk/tables/mozilla/bugs/bug275625-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2757-expected.png:
- platform/gtk/tables/mozilla/bugs/bug2757-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug278266-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug278385-expected.png:
- platform/gtk/tables/mozilla/bugs/bug278385-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
- platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug29157-expected.png:
- platform/gtk/tables/mozilla/bugs/bug29157-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug2973-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug221784-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug30418-expected.png:
- platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug30985-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3191-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3191-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug32205-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug32205-5-expected.png:
- platform/gtk/tables/mozilla/bugs/bug32205-5-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug32447-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug32447-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3263-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3263-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug34538-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug34538-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug35662-expected.png:
- platform/gtk/tables/mozilla/bugs/bug35662-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug3718-expected.png:
- platform/gtk/tables/mozilla/bugs/bug3718-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
- platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug40828-expected.png:
- platform/gtk/tables/mozilla/bugs/bug40828-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4284-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4284-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug44523-expected.png:
- platform/gtk/tables/mozilla/bugs/bug44523-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug45055-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4520-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4520-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-3-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-3-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-5-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46268-expected.png:
- platform/gtk/tables/mozilla/bugs/bug46268-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46480-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug46480-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug4739-expected.png:
- platform/gtk/tables/mozilla/bugs/bug4739-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug48028-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug48028-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug51140-expected.png:
- platform/gtk/tables/mozilla/bugs/bug51140-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55527-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55545-expected.png:
- platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug55694-expected.png:
- platform/gtk/tables/mozilla/bugs/bug55694-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug56405-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug56405-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57300-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57300-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57378-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57378-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug57828-expected.png:
- platform/gtk/tables/mozilla/bugs/bug57828-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug5798-expected.png:
- platform/gtk/tables/mozilla/bugs/bug5798-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug5799-expected.png:
- platform/gtk/tables/mozilla/bugs/bug5799-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug5838-expected.png:
- platform/gtk/tables/mozilla/bugs/bug5838-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug58402-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug58402-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60013-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60013-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug60992-expected.png:
- platform/gtk/tables/mozilla/bugs/bug60992-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug63785-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug650-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug67864-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug67915-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug67915-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug69187-expected.png:
- platform/gtk/tables/mozilla/bugs/bug69187-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug709-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug7112-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug7112-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug75250-expected.png: Added.
- platform/gtk/tables/mozilla/bugs/bug75250-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug82946-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug82946-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8361-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug3309-2-expected.png.
- platform/gtk/tables/mozilla/bugs/bug8361-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug83786-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8381-expected.png:
- platform/gtk/tables/mozilla/bugs/bug8381-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug9072-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug9271-1-expected.png:
- platform/gtk/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug93363-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug96343-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug965-expected.png:
- platform/gtk/tables/mozilla/bugs/bug965-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug97138-expected.png:
- platform/gtk/tables/mozilla/bugs/bug97138-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug99923-expected.png:
- platform/gtk/tables/mozilla/bugs/bug99923-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug99948-expected.png:
- platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug127040-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
- platform/gtk/tables/mozilla/core/captions-expected.png:
- platform/gtk/tables/mozilla/core/captions-expected.txt:
- platform/gtk/tables/mozilla/core/col_widths_auto_auto-expected.png:
- platform/gtk/tables/mozilla/core/col_widths_auto_auto-expected.txt:
- platform/gtk/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
- platform/gtk/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
- platform/gtk/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
- platform/gtk/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
- platform/gtk/tables/mozilla/core/row_span-expected.png:
- platform/gtk/tables/mozilla/core/row_span-expected.txt:
- platform/gtk/tables/mozilla/dom/appendCol2-expected.png:
- platform/gtk/tables/mozilla/dom/appendCol2-expected.txt:
- platform/gtk/tables/mozilla/dom/appendRowsExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/appendRowsExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCellsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink2-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCol1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCol1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCol2-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCol2-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteCol3-expected.png:
- platform/gtk/tables/mozilla/dom/deleteCol3-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteColGroup1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteColGroup1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteColGroup2-expected.png:
- platform/gtk/tables/mozilla/dom/deleteColGroup2-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteRowsShrink1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsExpand2-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsExpand2-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild2-expected.png:
- platform/gtk/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
- platform/gtk/tables/mozilla/dom/insertRowsExpand1-expected.png:
- platform/gtk/tables/mozilla/dom/insertRowsExpand1-expected.txt:
- platform/gtk/tables/mozilla/dom/insertRowsRebuild1-expected.png:
- platform/gtk/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
- platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_col-expected.png:
- platform/gtk/tables/mozilla/marvin/body_col-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_tbody-expected.txt:
- platform/gtk/tables/mozilla/marvin/body_tfoot-expected.png:
- platform/gtk/tables/mozilla/marvin/body_tfoot-expected.txt:
- platform/gtk/tables/mozilla/marvin/col_span-expected.png:
- platform/gtk/tables/mozilla/marvin/col_span-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_frame_border-expected.png:
- platform/gtk/tables/mozilla/marvin/table_frame_border-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_frame_box-expected.png:
- platform/gtk/tables/mozilla/marvin/table_frame_box-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_rules_all-expected.png:
- platform/gtk/tables/mozilla/marvin/table_rules_all-expected.txt:
- platform/gtk/tables/mozilla/marvin/table_rules_none-expected.png:
- platform/gtk/tables/mozilla/marvin/table_rules_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_0-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_1-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_border_1-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_2-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_border_2-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_border_3-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_border_3-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_cellpadding-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_cellspacing-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_default-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_id-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_colspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_height-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_height-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.png:
- platform/gtk/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tbody_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tbody_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/tfoot_char-expected.png:
- platform/gtk/tables/mozilla/marvin/tfoot_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_justify-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/thead_char-expected.png:
- platform/gtk/tables/mozilla/marvin/thead_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
- platform/gtk/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.png:
- platform/gtk/tables/mozilla/marvin/x_caption_align_top-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_border_px-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
- platform/gtk/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_frame_void-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_rules_none-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_table_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tbody_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tbody_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_colspan-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_colspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_height-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_rowspan-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_rowspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_td_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_td_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tfoot_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_colspan-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_colspan-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_height-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_height-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_nowrap-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_nowrap-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_th_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_th_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_center-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_char-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_left-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_align_right-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_thead_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_thead_style-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_class-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_class-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_id-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_id-expected.txt:
- platform/gtk/tables/mozilla/marvin/x_tr_style-expected.png:
- platform/gtk/tables/mozilla/marvin/x_tr_style-expected.txt:
- platform/gtk/tables/mozilla/other/body_col-expected.png:
- platform/gtk/tables/mozilla/other/body_col-expected.txt:
- platform/gtk/tables/mozilla/other/cellspacing-expected.png:
- platform/gtk/tables/mozilla/other/cellspacing-expected.txt:
- platform/gtk/tables/mozilla/other/move_row-expected.png:
- platform/gtk/tables/mozilla/other/move_row-expected.txt:
- platform/gtk/tables/mozilla/other/padding-expected.png:
- platform/gtk/tables/mozilla/other/padding-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Copied from LayoutTests/platform/gtk/tables/mozilla/bugs/bug12384-expected.png.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-14-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-17-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7113-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.png:
- platform/gtk/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.png:
- platform/gtk/tables/mozilla_expected_failures/core/conflicts-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.png:
- platform/gtk/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
- 11:07 AM Changeset in webkit [195826] by
-
- 3 edits in trunk/Source/WebKit2
Disable text interaction with pencil.
https://bugs.webkit.org/show_bug.cgi?id=153655
rdar://problem/24337778
Reviewed by Tim Horton.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]):
(-[WKContentView _singleTapCommited:]):
- 10:59 AM Changeset in webkit [195825] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: This one still crashes, just flakily. *sigh*
- 10:46 AM Changeset in webkit [195824] by
-
- 5 edits in trunk/Source
Versioning.
- 10:43 AM Changeset in webkit [195823] by
-
- 1 copy in tags/Safari-602.1.18
New tag.
- 10:43 AM Changeset in webkit [195822] by
-
- 2 edits in trunk/LayoutTests
Marking 3 displaylist tests as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153656
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:34 AM Changeset in webkit [195821] by
-
- 5 edits in tags/Safari-602.1.17.0.3/Source
Versioning.
- 10:29 AM Changeset in webkit [195820] by
-
- 1 copy in tags/Safari-602.1.17.0.3
New tag.
- 10:00 AM Changeset in webkit [195819] by
-
- 4 edits1 delete in trunk/Source/WebInspectorUI
Web Inspector: Add font-variant-* to the visual styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=148720
<rdar://problem/22569974>
Patch by Devin Rousso <Devin Rousso> on 2016-01-29
Reviewed by Timothy Hatcher.
Added another subsection to the "Text" section for font-variant-*
properties.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Images/FontVariantSmallCaps.svg: Removed.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel):
Added another keyword grouping with the "normal" value since it is used
frequently in multiple subsections.
(WebInspector.VisualStyleDetailsPanel.prototype._populateFontSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateFontVariantsSection):
Added the five new font-variant-* properties specified in
<https://webkit.org/blog/5735/css-font-features/>.
(WebInspector.VisualStyleDetailsPanel.prototype._populateTextSpacingSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAnimationSection):
Replaced the hardcoded "normal" keyword with the new grouping.
- UserInterface/Views/VisualStyleKeywordCheckbox.css:
(.visual-style-property-container.keyword-checkbox.font-variant > .visual-style-property-value-container > input::after): Deleted.
- 9:52 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:50 AM Changeset in webkit [195818] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/forms/auto-fill-button/input-contacts-auto-fill-button.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153567
Unreviewed test gardening.
- platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
- 9:44 AM Changeset in webkit [195817] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore/dom
Applied patch from rdar://problem/24209109.
- 9:38 AM Changeset in webkit [195816] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix; one more ResourceLoaderOptions call site which needs to
be updated after adding the CachingPolicy parameter.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading):
- 9:28 AM Changeset in webkit [195815] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.7
WebKitGTK+ 2.10.7
- 9:25 AM Changeset in webkit [195814] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations: Enable some IndexedDB tests that pass.
- 9:24 AM Changeset in webkit [195813] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.7 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.7
- 8:53 AM Changeset in webkit [195812] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r195811 - [GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Guard all the new DnD-related code under GTK_CHECK_VERSION #if's to
make sure we don't bump the required version of GTK+ up to 3.16, and
it's buildable again with GTK+ >= 3.6.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler):
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::finishDrag):
- UIProcess/gtk/DragAndDropHandler.h:
- 8:26 AM Changeset in webkit [195811] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Guard all the new DnD-related code under GTK_CHECK_VERSION #if's to
make sure we don't bump the required version of GTK+ up to 3.16, and
it's buildable again with GTK+ >= 3.6.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler):
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::finishDrag):
- UIProcess/gtk/DragAndDropHandler.h:
- 2:58 AM Changeset in webkit [195810] by
-
- 8 edits2 adds in trunk/Source/WebCore
[GTK] Implement overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=153405
Reviewed by Michael Catanzaro.
Add support for overlay scrollbars to GTK+ platform following the
same style and behavior than GtkScrolledWindow. They are only
available for GTK+ >= 3.19, but honoring the GTK_OVERLAY_SCROLLING
environment variable, so they could be disable at run time, except
when threaded compositor is enabled. A new ScrollAnimator class
has been added for GTK+ to implement overlay scrollbars and still
allow smooth scrolling when available.
- PlatformGTK.cmake: Add ScrollAnimatorGtk and stop building ScrollAnimatorSmooth.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::ScrollAnimator::mouseEnteredContentArea):
Remove const to allow the ScrollAnimator to be updated.
(WebCore::ScrollAnimator::ScrollAnimator::mouseExitedContentArea): Ditto.
(WebCore::ScrollAnimator::ScrollAnimator::mouseMovedInContentArea): Ditto.
(WebCore::ScrollAnimator::ScrollAnimator::contentAreaDidShow): Ditto.
(WebCore::ScrollAnimator::ScrollAnimator::contentAreaDidHide): Ditto.
- platform/Scrollbar.h:
(WebCore::Scrollbar::opacity): Get scrollbar opacity.
(WebCore::Scrollbar::setOpacity): Set scrollbar opacity.
- platform/gtk/ScrollAnimatorGtk.cpp: Added.
(WebCore::ScrollAnimator::create): Create a ScrollAnimatorGtk.
(WebCore::ScrollAnimatorGtk::ScrollAnimatorGtk):
(WebCore::ScrollAnimatorGtk::~ScrollAnimatorGtk):
(WebCore::ScrollAnimatorGtk::ensureSmoothScrollingAnimation):
Initialize the ScrollAnimationSmooth if it doesn't exist.
(WebCore::ScrollAnimatorGtk::scroll): Ensure we have a
ScrollAnimationSmooth if smooth scrolling is enabled. This also
fixes the problem of having to reload the page after changing the
smooth scrolling setting.
(WebCore::ScrollAnimatorGtk::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorGtk::willEndLiveResize):
(WebCore::ScrollAnimatorGtk::didAddVerticalScrollbar): Register
the scrollbar if it's an overlay scrollbar and make it visible
without animating it. Start the hide animation.
(WebCore::ScrollAnimatorGtk::didAddHorizontalScrollbar): Ditto.
(WebCore::ScrollAnimatorGtk::willRemoveVerticalScrollbar):
Unregister the scrollbar if it was registered and resrt the
animation state if it was the only scrollbar.
(WebCore::ScrollAnimatorGtk::willRemoveHorizontalScrollbar): Ditto.
(WebCore::ScrollAnimatorGtk::updateOverlayScrollbarsOpacity): Update
the scrollbars opacity and invalidate the indicator.
(WebCore::easeOutCubic):
(WebCore::ScrollAnimatorGtk::overlayScrollbarAnimationTimerFired):
Update the scrollbars opacity and schedule a next frame if the
animation didn't finish or start the hide animation otherwhise.
(WebCore::ScrollAnimatorGtk::showOverlayScrollbars): Start the
fade animation to show the scrollbars if needed.
(WebCore::ScrollAnimatorGtk::hideOverlayScrollbars): Start the
dafe animation to hide the scrollbars if needed.
(WebCore::ScrollAnimatorGtk::mouseEnteredContentArea): Call
showOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::mouseExitedContentArea): Call
hideOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::mouseMovedInContentArea): Call
showOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::contentAreaDidShow): Ditto.
(WebCore::ScrollAnimatorGtk::contentAreaDidHide): Hide the
scrollbars without animations.
(WebCore::ScrollAnimatorGtk::notifyContentAreaScrolled): Call
showOverlayScrollbars().
(WebCore::ScrollAnimatorGtk::lockOverlayScrollbarStateToHidden):
Update the lock state and hide or show the scrollbars when locked
or unlocked.
- platform/gtk/ScrollAnimatorGtk.h: Added.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::backButtonRect): Pass
StyleContextMode to getOrCreateStyleContext depending on the
painting parameter.
(WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto.
(WebCore::ScrollbarThemeGtk::trackRect): Ditto.
(WebCore::ScrollbarThemeGtk::getOrCreateStyleContext): Add
StyleContextMode parameter to add the hovering class
unconditionally when using overlay scrollbars in layout mode. In
paint mode we add the hovering clas only when the scrollbar is
hovered. This way we always claim the size of the scrollbar when
hovered to be able to show the full scrollbar when the mouse is
close enough to the indicator.
(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Initialize
m_usesOverlayScrollbars.
(WebCore::ScrollbarThemeGtk::thumbRect): Pass the scrollbar to
getOrCreateStyleContext().
(WebCore::adjustRectAccordingToMargin): Fix the top margin.
(WebCore::ScrollbarThemeGtk::paintTrackBackground): Pass the
scrollbar and paint mode to getOrCreateStyleContext().
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
(WebCore::ScrollbarThemeGtk::paintThumb): Adjust the thumb
rectangle when overlay scrollbar is not hovered to its current
size, since we always claim the size of the scrollbar in hovered
mode.
(WebCore::ScrollbarThemeGtk::paintButton): Pass the scrollbar and
paint mode to getOrCreateStyleContext().
(WebCore::ScrollbarThemeGtk::paint): Take the scrollbar opacity
into account when rendering overlay scrollbars as indicators. Also
get the scrollbar opacity from the GTK+ theme and use a
transparency group when the global opacity is not full opaque.
(WebCore::ScrollbarThemeGtk::buttonSize): Pass the scrollbar to
getOrCreateStyleContext().
- platform/gtk/ScrollbarThemeGtk.h:
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
- 1:58 AM Changeset in webkit [195809] by
-
- 3 edits2 adds in trunk
[GStreamer] built-in media player doesn't update
https://bugs.webkit.org/show_bug.cgi?id=151816
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The timeline of audio controls in media document is not properly updated since it is assumed
that the controls are hidden as soon as playing. However, such full page audio always has
opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
in controlsAreHidden();
Test: media/audio-controls-timeline-in-media-document.html
- Modules/mediacontrols/mediaControlsBase.js:
(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):
LayoutTests:
- media/audio-controls-timeline-in-media-document-expected.txt: Added.
- media/audio-controls-timeline-in-media-document.html: Added.
- 1:22 AM Changeset in webkit [195808] by
-
- 9 edits in trunk/Source/WebCore
[css-grid] Store lines instead of tracks in GridResolvedPosition
https://bugs.webkit.org/show_bug.cgi?id=153592
Reviewed by Sergio Villar Senin.
Due to the new feature that allows to create implicit tracks before the
explicit ones, we will need to use lines instead of tracks in the
code to be able to implement it properly.
This is just a first simple patch using lines instead of tracks in
GridResolvedPosition. It modifies the code that was using it, as it was
considering that the resolvedFinalPosition was a track index and
not a line index.
So if we've an item positioned like:
grid-column: 2 / 5;
grid-row: 1 / span 2;
Before we were storing this information on the GridSpan:
- columns:
- resolvedInitialPosition: 1
- resolvedFinalPosition: 3
- rows:
- resolvedInitialPosition: 0
- resolvedFinalPosition: 1
And now we're storing:
- columns:
- resolvedInitialPosition: 1
- resolvedFinalPosition: 4
- rows:
- resolvedInitialPosition: 0
- resolvedFinalPosition: 2
No new tests, no change of behavior.
- css/CSSGridTemplateAreasValue.cpp:
(WebCore::stringForPosition):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::createImplicitNamedGridLinesFromGridArea):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::ensureGridSize):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
(WebCore::RenderGrid::gridAreaBreadthForChildIncludingAlignmentOffsets):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
- rendering/RenderGrid.h:
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::integerSpan):
(WebCore::GridSpan::end):
(WebCore::GridCoordinate::GridCoordinate):
- rendering/style/GridResolvedPosition.cpp:
(WebCore::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveGridPositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle):
(WebCore::resolveNamedGridLinePositionFromStyle): Deleted.
- rendering/style/GridResolvedPosition.h:
- 12:38 AM Changeset in webkit [195807] by
-
- 29 edits in branches/safari-601-branch
Merged r194479. rdar://problem/24404073
- 12:35 AM Changeset in webkit [195806] by
-
- 6 edits in branches/safari-601-branch
Merged r195615. rdar://problem/24302726
- 12:22 AM Changeset in webkit [195805] by
-
- 1 edit2 copies in branches/safari-601-branch/LayoutTests
Merged r191251. rdar://problem/24399452
- 12:20 AM Changeset in webkit [195804] by
-
- 2 edits in branches/safari-601-branch/Source/JavaScriptCore
Merge patch for rdar://problem/23968717.
- 12:12 AM Changeset in webkit [195803] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge patch for rdar://problem/24394636.
Jan 28, 2016:
- 11:21 PM Changeset in webkit [195802] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebCore
- 10:50 PM Changeset in webkit [195801] by
-
- 4 edits in trunk
Modern IDB: SQLite backend mismanages key generator values.
https://bugs.webkit.org/show_bug.cgi?id=153625
Reviewed by Andy Estes.
Source/WebCore:
No new tests (Many failing tests pass, a few get closer).
There's mixed assumptions about whether the value stored is the current value or the next value.
Fixing those assumptions fixes tests.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber): Store/retrieve the correct value.
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber): Ditto.
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber): Ditto.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 9:37 PM Changeset in webkit [195800] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3] REGRESSION(r195395): testComplex(64, 128) asserts on Linux with GCC
https://bugs.webkit.org/show_bug.cgi?id=153422
Reviewed by Filip Pizlo.
Previously proc.values() returns ValuesCollection (Not reference!).
values.values takes const ValueCollection&.
And later it produces IndexSet<Value>::Iterable<Procedure::ValuesCollection>,
it holds const ValueCollection& as its member.
But IndexSet<Value>::Iterable<Procedure::ValuesCollection> is just an instance.
So after creating this, the lifetime of the ValueCollection const reference finished.
To fix that, we hold ValuesCollection as a member of Procedure.
And change the signature to const ValuesCollection& Procedure::values().
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
- b3/B3Procedure.h:
(JSC::B3::Procedure::values):
- 7:46 PM Changeset in webkit [195799] by
-
- 62 edits in trunk
Web Inspector: InspectorTimelineAgent doesn't need to recompile functions because it now uses the sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=153500
<rdar://problem/24352458>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-28
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Be more explicit about enabling legacy profiling.
- jsc.cpp:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::hasLegacyProfiler):
(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::hasProfiler): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::supportsLegacyProfiling):
(JSC::JSGlobalObject::supportsProfiling): Deleted.
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsLegacyProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
(WebCore::JSDOMWindowBase::supportsProfiling): Deleted.
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling):
(WebCore::JSWorkerGlobalScopeBase::supportsProfiling): Deleted.
- bindings/js/JSWorkerGlobalScopeBase.h:
- inspector/InspectorController.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::legacyProfilerEnabled):
(WebCore::InspectorController::setLegacyProfilerEnabled):
Be more explicit about enabling legacy profiling.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend): Deleted.
TimelineAgent doesn't need to recompile if using the sampling profiler.
This breaks console.profile, but console.profile should move to using
the sampling profiler as well.
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::startProfiling): Deleted.
(WebCore::stopProfiling): Deleted.
Inlined the use once static functions.
- page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::profile):
(WebCore::PageConsoleClient::profileEnd):
Added FIXMEs for improving console.profile and profileEnd.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled):
(WebCore::Internals::setJavaScriptProfilingEnabled): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Be more explicit about enabling legacy profiling.
LayoutTests:
- fast/profiler/*.html
Be more explicit about enabling legacy profiling.
- inspector/sampling-profiler/eval-source-url.html
Remove an inner loop that was causing tail call optimizations
to eliminate the sourceURL we were expecting.
- 7:42 PM Changeset in webkit [195798] by
-
- 5 edits in trunk
Move attributes to the prototype for List types / and types with indexed/named property getters
https://bugs.webkit.org/show_bug.cgi?id=153599
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move attributes to the prototype for List types / and types with indexed/named property getters.
We used to keep them on the instance because:
- Our GetOwnProperty lookup used to be in incorrect order for interfaces with indexed/named property getters.
-> This was fixed recently and we now match the specification and other browsers.
- This used to regress performance when iterating over those list types
-> Local testing seems to show that this is no longer a regression (tested Speedometer and various related Bindings PerformanceTests).
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstance): Deleted.
(AttributeShouldBeOnInstanceForCompatibility): Deleted.
- 7:36 PM Changeset in webkit [195797] by
-
- 2 edits in trunk/Source/WebKit2
Enable background tab suspension by default on OSX
https://bugs.webkit.org/show_bug.cgi?id=153629
<rdar://problem/24402895>
Reviewed by Andreas Kling.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
- 6:58 PM Changeset in webkit [195796] by
-
- 2 edits in trunk/LayoutTests
Modern IDB: Enabled all of the imported IndexedDB tests that pass in the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153623
Reviewed by Andy Estes.
- platform/mac-wk1/TestExpectations: TONS of these now pass. List of failing tests is now small.
- 6:02 PM Changeset in webkit [195795] by
-
- 25 edits10 deletes in trunk
[Cocoa] Use the non-Development variants of XPC services for development
https://bugs.webkit.org/show_bug.cgi?id=152545
Reviewed by Darin Adler.
Source/WebKit2:
The purpose of the Development variants of the WebKit XPC services is to allow the service
to link against the development WebKit dylibs rather than the system ones. Instead, we
accomplish this here by including dyld environment load commands in the normal services
when the WebKit dylibs are expected to be relocated. A new build setting,
WK_RELOCATABLE_FRAMEWORKS, controls this.
To make it easy to identify engineering builds of the services at runtime, they can be
given a distinctive suffix. A new build setting, WK_XPC_SERVICE_SUFFIX, controls this.
- Configurations/DebugRelease.xcconfig: Set WK_RELOCATABLE_FRAMEWORKS to YES and WK_XPC_SERVICE_SUFFIX to ".Development".
- Configurations/BaseTarget.xcconfig: Make the quoted value of the WK_XPC_SERVICE_SUFFIX build setting available as a preprocessor macro.
- Configurations/BaseXPCService.xcconfig:
- Simplify the definition of INSTALL_PATH now that there are no Development variants.
- Define WK_RELOCATABLE_FRAMEWORKS_LDFLAGS when building relocatable frameworks to include -dyld_env options setting DYLD_FRAMEWORK_PATH to point to the directory containing WebKit.framework and DYLD_LIBRARY_PATH to the framework’s Frameworks subdirectory. When not building relocatable frameworks, define WK_RELOCATABLE_FRAMEWORKS_LDFLAGS to include a -headerpad option allowing dyld environment load commands to be added after the fact.
- Add WK_RELOCATABLE_FRAMEWORKS_LDFLAGS to OTHER_LDFLAGS.
- Define WK_XPC_SERVICE_INSERT_LIBRARIES_DIR when building relocatable frameworks to be the path to the Frameworks subdirectory of the WebKit framework containing the service. When not building relocatable frameworks, define it to the absolute path of the Frameworks subdirectory of the installed WebKit framework.
- Configurations/DatabaseService.xcconfig: Append WK_XPC_SERVICE_SUFFIX to PRODUCT_NAME, and remove no-longer-used definition of WK_XPC_SERVICE_VARIANT.
- Configurations/NetworkService.xcconfig: Append WK_XPC_SERVICE_SUFFIX to PRODUCT_NAME, add WK_RELOCATABLE_FRAMEWORKS_LDFLAGS to OTHER_LDFLAGS, and remove no-longer-used definition of WK_XPC_SERVICE_VARIANT.
- Configurations/PluginService.32.xcconfig: Ditto.
- Configurations/PluginService.64.xcconfig: Ditto.
- Configurations/WebContentService.xcconfig: Ditto.
- Configurations/DatabaseService.Development.xcconfig: Removed.
- Configurations/NetworkService.Development.xcconfig: Removed.
- Configurations/PluginService.32.Development.xcconfig: Removed.
- Configurations/PluginService.64.Development.xcconfig: Removed.
- Configurations/WebContentService.Development.xcconfig: Removed.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development: Removed.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist: Removed.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix. Use WK_XPC_SERVICE_INSERT_LIBRARIES_DIR in the value of DYLD_INSERT_LIBRARIES.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: Ditto.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist: Ditto.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix. Use WK_XPC_SERVICE_INSERT_LIBRARIES_DIR in the value of DYLD_INSERT_LIBRARIES.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Set CFBundleIdentifier to PRODUCT_NAME in order to include the optional suffix.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Ditto.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm: Removed.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler): If stdout and stderr file descriptors are included in the
bootstrap message, hook them up to the serviceâs stdout and stderr, like the Development
services do.
(main): Moved code from XPCServiceMain.Development.mm to handle the optional
OverrideLanguages array.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions): Addressed a FIXME.
(WebKit::serviceName): Removed forDevelopment argument and .Development service names.
Added WK_XPC_SERVICE_SUFFIX to the names.
(WebKit::connectToService): Updated for removal of forDevelopment argument. Removed
"framework-executable-path" key from the bootstrap message, because it was only used in
the Development variants.
(WebKit::connectToReExecService): Deleted.
(WebKit::createService): Removed call to connectToReExecService. Instead pass forDevelopment
to connectToService.
- WebKit2.xcodeproj/project.pbxproj: Removed references to removed files. Removed targets for Development services. Removed Development services from script build phase that copies services into the framework in engineering builds, and made it respect WK_XPC_SERVICE_SUFFIX.
Tools:
- Scripts/webkitdirs.pm:
(setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
set in the XPC services as well.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
Guard Malloc are enabled in XPC services as well.
- Scripts/webkitpy/port/mac.py:
(MacPort.setup_environ_for_server): Ditto.
- 4:48 PM Changeset in webkit [195794] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 4:35 PM Changeset in webkit [195793] by
-
- 1 copy in tags/Safari-601.5.12
New tag.
- 4:23 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:44 PM Changeset in webkit [195792] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 3:41 PM Changeset in webkit [195791] by
-
- 1 copy in tags/Safari-601.1.46.94
New tag.
- 3:30 PM Changeset in webkit [195790] by
-
- 6 edits in trunk/Source/WebCore
Tab suspension code hits asserts
Reviewed by Chris Dumez.
Enabling tab suspension and navigating around in a few tabs hits an assert in
ScriptExecutionContext::suspendActiveDOMObject. This is because suspend/resume reasons don't pair properly
- dom/Document.cpp:
(WebCore::Document::documentWillBecomeInactive):
(WebCore::Document::suspend):
(WebCore::Document::resume):
Provide the reason as argument.
- dom/Document.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
No need to call resumeActiveDOMObjects/resumeScriptedAnimationControllerCallbacks explicitly as Document::resume does that.
(WebCore::CachedFrame::CachedFrame):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- page/Page.cpp:
(WebCore::Page::canTabSuspend):
(WebCore::Page::setIsTabSuspended):
- 3:28 PM Changeset in webkit [195789] by
-
- 416 edits in trunk/LayoutTests
[Win] gardening after r195740. (more to follow)
Unreviewed.
- platform/win/css1/box_properties/padding_left-expected.txt:
- platform/win/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/win/fast/encoding/utf-16-big-endian-expected.txt:
- platform/win/fast/encoding/utf-16-little-endian-expected.txt:
- platform/win/fast/forms/001-expected.txt:
- platform/win/fast/forms/005-expected.txt:
- platform/win/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
- platform/win/fast/forms/basic-buttons-expected.txt:
- platform/win/fast/forms/button-white-space-expected.txt:
- platform/win/fast/forms/file/file-input-direction-expected.txt:
- platform/win/fast/forms/form-added-to-table-expected.txt:
- platform/win/fast/forms/form-element-geometry-expected.txt:
- platform/win/fast/forms/form-hides-table-expected.txt:
- platform/win/fast/forms/form-in-malformed-markup-expected.txt:
- platform/win/fast/forms/formmove3-expected.txt:
- platform/win/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/win/fast/forms/input-table-expected.txt:
- platform/win/fast/forms/input-value-expected.txt:
- platform/win/fast/forms/listbox-bidi-align-expected.txt:
- platform/win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/win/fast/html/details-writing-mode-expected.txt:
- platform/win/fast/inline-block/001-expected.txt:
- platform/win/fast/inline-block/overflow-clip-expected.txt:
- platform/win/fast/invalid/012-expected.txt:
- platform/win/fast/invalid/018-expected.txt:
- platform/win/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/win/fast/invalid/td-inside-object-expected.txt:
- platform/win/fast/lists/004-expected.txt:
- platform/win/fast/lists/list-marker-before-content-table-expected.txt:
- platform/win/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
- platform/win/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/win/fast/overflow/002-expected.txt:
- platform/win/fast/overflow/overflow-auto-table-expected.txt:
- platform/win/fast/overflow/overflow-rtl-expected.txt:
- platform/win/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/win/fast/overflow/table-overflow-float-expected.txt:
- platform/win/fast/reflections/table-cell-expected.txt:
- platform/win/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
- platform/win/fast/repaint/float-overflow-expected.txt:
- platform/win/fast/repaint/float-overflow-right-expected.txt:
- platform/win/fast/repaint/subtree-root-clip-3-expected.txt:
- platform/win/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- platform/win/fast/repaint/table-cell-move-expected.txt:
- platform/win/fast/repaint/table-cell-overflow-expected.txt:
- platform/win/fast/repaint/table-cell-vertical-overflow-expected.txt:
- platform/win/fast/repaint/table-col-background-expected.txt:
- platform/win/fast/repaint/table-collapsed-border-expected.txt:
- platform/win/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/win/fast/repaint/table-outer-border-expected.txt:
- platform/win/fast/repaint/table-row-expected.txt:
- platform/win/fast/repaint/table-section-overflow-expected.txt:
- platform/win/fast/repaint/table-section-repaint-expected.txt:
- platform/win/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
- platform/win/fast/repaint/table-writing-modes-h-expected.txt:
- platform/win/fast/repaint/table-writing-modes-v-expected.txt:
- platform/win/fast/replaced/005-expected.txt:
- platform/win/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/win/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/win/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/win/fast/replaced/width100percent-button-expected.txt:
- platform/win/fast/replaced/width100percent-checkbox-expected.txt:
- platform/win/fast/replaced/width100percent-image-expected.txt:
- platform/win/fast/replaced/width100percent-menulist-expected.txt:
- platform/win/fast/replaced/width100percent-radio-expected.txt:
- platform/win/fast/ruby/ruby-inline-table-expected.txt:
- platform/win/fast/selectors/018-expected.txt:
- platform/win/fast/selectors/018b-expected.txt:
- platform/win/fast/selectors/032-expected.txt:
- platform/win/fast/selectors/043-expected.txt:
- platform/win/fast/selectors/043b-expected.txt:
- platform/win/fast/selectors/044-expected.txt:
- platform/win/fast/selectors/044b-expected.txt:
- platform/win/fast/selectors/077-expected.txt:
- platform/win/fast/selectors/077b-expected.txt:
- platform/win/fast/selectors/078b-expected.txt:
- platform/win/fast/table/001-expected.txt:
- platform/win/fast/table/002-expected.txt:
- platform/win/fast/table/003-expected.txt:
- platform/win/fast/table/004-expected.txt:
- platform/win/fast/table/005-expected.txt:
- platform/win/fast/table/006-expected.txt:
- platform/win/fast/table/007-expected.txt:
- platform/win/fast/table/008-expected.txt:
- platform/win/fast/table/009-expected.txt:
- platform/win/fast/table/010-expected.txt:
- platform/win/fast/table/011-expected.txt:
- platform/win/fast/table/012-expected.txt:
- platform/win/fast/table/013-expected.txt:
- platform/win/fast/table/015-expected.txt:
- platform/win/fast/table/016-expected.txt:
- platform/win/fast/table/021-expected.txt:
- platform/win/fast/table/022-expected.txt:
- platform/win/fast/table/023-expected.txt:
- platform/win/fast/table/024-expected.txt:
- platform/win/fast/table/025-expected.txt:
- platform/win/fast/table/026-expected.txt:
- platform/win/fast/table/028-expected.txt:
- platform/win/fast/table/028-vertical-expected.txt:
- platform/win/fast/table/029-expected.txt:
- platform/win/fast/table/031-expected.txt:
- platform/win/fast/table/032-expected.txt:
- platform/win/fast/table/033-expected.txt:
- platform/win/fast/table/034-expected.txt:
- platform/win/fast/table/035-expected.txt:
- platform/win/fast/table/035-vertical-expected.txt:
- platform/win/fast/table/037-expected.txt:
- platform/win/fast/table/038-expected.txt:
- platform/win/fast/table/038-vertical-expected.txt:
- platform/win/fast/table/039-expected.txt:
- platform/win/fast/table/040-expected.txt:
- platform/win/fast/table/040-vertical-expected.txt:
- platform/win/fast/table/041-expected.txt:
- platform/win/fast/table/100-percent-cell-width-expected.txt:
- platform/win/fast/table/add-before-anonymous-child-expected.txt:
- platform/win/fast/table/auto-with-percent-height-expected.txt:
- platform/win/fast/table/auto-with-percent-height-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/001-expected.txt:
- platform/win/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/002-expected.txt:
- platform/win/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/003-expected.txt:
- platform/win/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/004-expected.txt:
- platform/win/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/bug14274-expected.txt:
- platform/win/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/win/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/win/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/win/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/win/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/win/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/win/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
- platform/win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/win/fast/table/caption-relayout-expected.txt:
- platform/win/fast/table/cell-absolute-child-expected.txt:
- platform/win/fast/table/cell-coalescing-expected.txt:
- platform/win/fast/table/cell-width-auto-expected.txt:
- platform/win/fast/table/cellindex-expected.txt:
- platform/win/fast/table/click-near-anonymous-table-expected.txt:
- platform/win/fast/table/colgroup-preceded-by-caption-expected.txt:
- platform/win/fast/table/colgroup-spanning-groups-rules-expected.txt:
- platform/win/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/win/fast/table/colspanMinWidth-expected.txt:
- platform/win/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/win/fast/table/dynamic-cellpadding-expected.txt:
- platform/win/fast/table/dynamic-descendant-percentage-height-expected.txt:
- platform/win/fast/table/edge-offsets-expected.txt:
- platform/win/fast/table/empty-cells-expected.txt:
- platform/win/fast/table/floating-th-expected.txt:
- platform/win/fast/table/frame-and-rules-expected.txt:
- platform/win/fast/table/generated-caption-expected.txt:
- platform/win/fast/table/giantRowspan-expected.txt:
- platform/win/fast/table/growCellForImageQuirk-expected.txt:
- platform/win/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/win/fast/table/height-percent-test-expected.txt:
- platform/win/fast/table/height-percent-test-vertical-expected.txt:
- platform/win/fast/table/insert-before-anonymous-ancestors-expected.txt:
- platform/win/fast/table/insert-cell-before-form-expected.txt:
- platform/win/fast/table/insert-row-before-form-expected.txt:
- platform/win/fast/table/invisible-cell-background-expected.txt:
- platform/win/fast/table/large-width-expected.txt:
- platform/win/fast/table/max-width-integer-overflow-expected.txt:
- platform/win/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/win/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/win/fast/table/multiple-captions-display-expected.txt:
- platform/win/fast/table/nested-percent-height-table-expected.txt:
- platform/win/fast/table/nobr-expected.txt:
- platform/win/fast/table/overflowHidden-expected.txt:
- platform/win/fast/table/percent-heights-expected.txt:
- platform/win/fast/table/percent-widths-stretch-expected.txt:
- platform/win/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/win/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/win/fast/table/quote-text-around-iframe-expected.txt:
- platform/win/fast/table/relative-position-containment-expected.txt:
- platform/win/fast/table/relative-position-offsets-expected.txt:
- platform/win/fast/table/relative-position-stacking-expected.txt:
- platform/win/fast/table/replaced-percent-height-expected.txt:
- platform/win/fast/table/row-height-recalc-expected.txt:
- platform/win/fast/table/rowspan-paint-order-expected.txt:
- platform/win/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/win/fast/table/rtl-cell-display-none-assert-expected.txt:
- platform/win/fast/table/rules-attr-dynchange1-expected.txt:
- platform/win/fast/table/rules-attr-dynchange2-expected.txt:
- platform/win/fast/table/simple_paint-expected.txt:
- platform/win/fast/table/spanOverlapRepaint-expected.txt:
- platform/win/fast/table/stale-grid-crash-expected.txt:
- platform/win/fast/table/table-after-child-in-table-expected.txt:
- platform/win/fast/table/table-and-parts-outline-expected.txt:
- platform/win/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/win/fast/table/table-anonymous-row-bug-expected.txt:
- platform/win/fast/table/table-anonymous-section-bug-expected.txt:
- platform/win/fast/table/table-before-child-in-table-expected.txt:
- platform/win/fast/table/table-before-child-style-update-expected.txt:
- platform/win/fast/table/table-cell-after-child-in-block-expected.txt:
- platform/win/fast/table/table-cell-after-child-in-table-expected.txt:
- platform/win/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/win/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/win/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/win/fast/table/table-cell-before-child-in-block-expected.txt:
- platform/win/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/win/fast/table/table-cell-split-expected.txt:
- platform/win/fast/table/table-continuation-outline-paint-crash-expected.txt:
- platform/win/fast/table/table-display-types-expected.txt:
- platform/win/fast/table/table-display-types-strict-expected.txt:
- platform/win/fast/table/table-display-types-vertical-expected.txt:
- platform/win/fast/table/table-hspace-align-center-expected.txt:
- platform/win/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/win/fast/table/table-row-after-child-in-block-expected.txt:
- platform/win/fast/table/table-row-after-child-in-table-expected.txt:
- platform/win/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/win/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/win/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/win/fast/table/table-row-before-child-in-block-expected.txt:
- platform/win/fast/table/table-row-before-child-in-table-expected.txt:
- platform/win/fast/table/table-row-before-child-style-update-expected.txt:
- platform/win/fast/table/table-row-outline-paint-expected.txt:
- platform/win/fast/table/table-row-split2-expected.txt:
- platform/win/fast/table/table-row-style-not-updated-expected.txt:
- platform/win/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/win/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/win/fast/table/table-section-split2-expected.txt:
- platform/win/fast/table/table-split-expected.txt:
- platform/win/fast/table/table-split2-expected.txt:
- platform/win/fast/table/table-style-not-updated-expected.txt:
- platform/win/fast/table/tableInsideCaption-expected.txt:
- platform/win/fast/table/text-field-baseline-expected.txt:
- platform/win/fast/table/unbreakable-images-quirk-expected.txt:
- platform/win/fast/table/vertical-align-baseline-expected.txt:
- platform/win/fast/table/wide-colspan-expected.txt:
- platform/win/fast/table/wide-column-expected.txt:
- platform/win/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/win/fast/text/atsui-spacing-features-expected.txt:
- platform/win/fast/text/basic/001-expected.txt:
- platform/win/fast/text/basic/006-expected.txt:
- platform/win/fast/text/basic/007-expected.txt:
- platform/win/fast/text/basic/generic-family-reset-expected.txt:
- platform/win/fast/text/capitalize-boundaries-expected.txt:
- platform/win/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/win/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/win/fast/text/international/bidi-override-expected.txt:
- platform/win/fast/text/textIteratorNilRenderer-expected.txt:
- platform/win/fast/text/wbr-expected.txt:
- platform/win/fast/text/whitespace/002-expected.txt:
- platform/win/fast/text/whitespace/003-expected.txt:
- platform/win/fast/text/whitespace/004-expected.txt:
- platform/win/fast/text/whitespace/005-expected.txt:
- platform/win/fast/text/whitespace/010-expected.txt:
- platform/win/fast/text/whitespace/011-expected.txt:
- platform/win/fast/text/whitespace/013-expected.txt:
- platform/win/fast/text/whitespace/014-expected.txt:
- platform/win/fast/text/whitespace/015-expected.txt:
- platform/win/fast/text/whitespace/016-expected.txt:
- platform/win/fast/text/whitespace/024-expected.txt:
- platform/win/fast/text/whitespace/025-expected.txt:
- platform/win/fast/text/whitespace/026-expected.txt:
- platform/win/fast/text/whitespace/027-expected.txt:
- platform/win/fast/text/word-break-expected.txt:
- platform/win/fast/transforms/transform-table-row-expected.txt:
- platform/win/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/win/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/win/http/tests/misc/acid2-expected.txt:
- platform/win/http/tests/misc/acid2-pixel-expected.txt:
- platform/win/http/tests/misc/generated-content-inside-table-expected.txt:
- platform/win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt:
- platform/win/tables/layering/paint-test-layering-1-expected.txt:
- platform/win/tables/layering/paint-test-layering-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug10009-expected.txt:
- platform/win/tables/mozilla/bugs/bug10036-expected.txt:
- platform/win/tables/mozilla/bugs/bug10269-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug10269-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug10296-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug10565-expected.txt:
- platform/win/tables/mozilla/bugs/bug10633-expected.txt:
- platform/win/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug11321-expected.txt:
- platform/win/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug1188-expected.txt:
- platform/win/tables/mozilla/bugs/bug11944-expected.txt:
- platform/win/tables/mozilla/bugs/bug12008-expected.txt:
- platform/win/tables/mozilla/bugs/bug1224-expected.txt:
- platform/win/tables/mozilla/bugs/bug12268-expected.txt:
- platform/win/tables/mozilla/bugs/bug12384-expected.txt:
- platform/win/tables/mozilla/bugs/bug1261-expected.txt:
- platform/win/tables/mozilla/bugs/bug12709-expected.txt:
- platform/win/tables/mozilla/bugs/bug1271-expected.txt:
- platform/win/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug1296-expected.txt:
- platform/win/tables/mozilla/bugs/bug1302-expected.txt:
- platform/win/tables/mozilla/bugs/bug13105-expected.txt:
- platform/win/tables/mozilla/bugs/bug13118-expected.txt:
- platform/win/tables/mozilla/bugs/bug13169-expected.txt:
- platform/win/tables/mozilla/bugs/bug1318-expected.txt:
- platform/win/tables/mozilla/bugs/bug13484-expected.txt:
- platform/win/tables/mozilla/bugs/bug13526-expected.txt:
- platform/win/tables/mozilla/bugs/bug14159-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug1430-expected.txt:
- platform/win/tables/mozilla/bugs/bug14323-expected.txt:
- platform/win/tables/mozilla/bugs/bug14929-expected.txt:
- platform/win/tables/mozilla/bugs/bug15247-expected.txt:
- platform/win/tables/mozilla/bugs/bug15544-expected.txt:
- platform/win/tables/mozilla/bugs/bug15933-expected.txt:
- platform/win/tables/mozilla/bugs/bug16012-expected.txt:
- platform/win/tables/mozilla/bugs/bug16252-expected.txt:
- platform/win/tables/mozilla/bugs/bug17130-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug17138-expected.txt:
- platform/win/tables/mozilla/bugs/bug17548-expected.txt:
- platform/win/tables/mozilla/bugs/bug17587-expected.txt:
- platform/win/tables/mozilla/bugs/bug1800-expected.txt:
- platform/win/tables/mozilla/bugs/bug1802-expected.txt:
- platform/win/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/win/tables/mozilla/bugs/bug1809-expected.txt:
- platform/win/tables/mozilla/bugs/bug1828-expected.txt:
- platform/win/tables/mozilla/bugs/bug18359-expected.txt:
- platform/win/tables/mozilla/bugs/bug18440-expected.txt:
- platform/win/tables/mozilla/bugs/bug18558-expected.txt:
- platform/win/tables/mozilla/bugs/bug18664-expected.txt:
- platform/win/tables/mozilla/bugs/bug18955-expected.txt:
- platform/win/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug19356-expected.txt:
- platform/win/tables/mozilla/bugs/bug2050-expected.txt:
- platform/win/tables/mozilla/bugs/bug2123-expected.txt:
- platform/win/tables/mozilla/bugs/bug2267-expected.txt:
- platform/win/tables/mozilla/bugs/bug2296-expected.txt:
- platform/win/tables/mozilla/bugs/bug2469-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug2516-expected.txt:
- platform/win/tables/mozilla/bugs/bug2585-expected.txt:
- platform/win/tables/mozilla/bugs/bug2684-expected.txt:
- platform/win/tables/mozilla/bugs/bug2757-expected.txt:
- platform/win/tables/mozilla/bugs/bug2773-expected.txt:
- platform/win/tables/mozilla/bugs/bug2886-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug2886-expected.txt:
- platform/win/tables/mozilla/bugs/bug2954-expected.txt:
- platform/win/tables/mozilla/bugs/bug2973-expected.txt:
- platform/win/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug2997-expected.txt:
- platform/win/tables/mozilla/bugs/bug3037-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug3037-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug3103-expected.txt:
- platform/win/tables/mozilla/bugs/bug3191-expected.txt:
- platform/win/tables/mozilla/bugs/bug3260-expected.txt:
- platform/win/tables/mozilla/bugs/bug3263-expected.txt:
- platform/win/tables/mozilla/bugs/bug3309-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug3454-expected.txt:
- platform/win/tables/mozilla/bugs/bug3718-expected.txt:
- platform/win/tables/mozilla/bugs/bug3977-expected.txt:
- platform/win/tables/mozilla/bugs/bug4093-expected.txt:
- platform/win/tables/mozilla/bugs/bug4284-expected.txt:
- platform/win/tables/mozilla/bugs/bug4385-expected.txt:
- platform/win/tables/mozilla/bugs/bug4427-expected.txt:
- platform/win/tables/mozilla/bugs/bug4429-expected.txt:
- platform/win/tables/mozilla/bugs/bug4501-expected.txt:
- platform/win/tables/mozilla/bugs/bug4520-expected.txt:
- platform/win/tables/mozilla/bugs/bug4527-expected.txt:
- platform/win/tables/mozilla/bugs/bug4576-expected.txt:
- platform/win/tables/mozilla/bugs/bug4739-expected.txt:
- platform/win/tables/mozilla/bugs/bug4803-expected.txt:
- platform/win/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug4849-expected.txt:
- platform/win/tables/mozilla/bugs/bug5188-expected.txt:
- platform/win/tables/mozilla/bugs/bug5538-expected.txt:
- platform/win/tables/mozilla/bugs/bug5797-expected.txt:
- platform/win/tables/mozilla/bugs/bug5798-expected.txt:
- platform/win/tables/mozilla/bugs/bug5799-expected.txt:
- platform/win/tables/mozilla/bugs/bug5835-expected.txt:
- platform/win/tables/mozilla/bugs/bug5838-expected.txt:
- platform/win/tables/mozilla/bugs/bug6184-expected.txt:
- platform/win/tables/mozilla/bugs/bug6304-expected.txt:
- platform/win/tables/mozilla/bugs/bug6404-expected.txt:
- platform/win/tables/mozilla/bugs/bug647-expected.txt:
- platform/win/tables/mozilla/bugs/bug650-expected.txt:
- platform/win/tables/mozilla/bugs/bug6674-expected.txt:
- platform/win/tables/mozilla/bugs/bug709-expected.txt:
- platform/win/tables/mozilla/bugs/bug7112-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug7112-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug7342-expected.txt:
- platform/win/tables/mozilla/bugs/bug7714-expected.txt:
- platform/win/tables/mozilla/bugs/bug8032-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug8361-expected.txt:
- platform/win/tables/mozilla/bugs/bug8381-expected.txt:
- platform/win/tables/mozilla/bugs/bug8950-expected.txt:
- platform/win/tables/mozilla/bugs/bug9072-expected.txt:
- platform/win/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/win/tables/mozilla/bugs/bug9271-1-expected.txt:
- platform/win/tables/mozilla/bugs/bug963-expected.txt:
- platform/win/tables/mozilla/bugs/bug965-expected.txt:
- platform/win/tables/mozilla/bugs/bug9879-1-expected.txt:
- 3:21 PM Changeset in webkit [195788] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the B3 build with GCC 4.9.3
https://bugs.webkit.org/show_bug.cgi?id=151624
Reviewed by Filip Pizlo.
Due to GCC 4.9's compiler issue[1], method calls inside (2 or so) nested lambdas need to use
thisto avoid internal compiler errors.
[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62272
- b3/air/AirIteratedRegisterCoalescing.cpp:
- 3:18 PM Changeset in webkit [195787] by
-
- 6 edits in trunk
Modern IDB: Fix several more problems with object store changes during cursor iteration in SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153616
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (A few failing tests pass, a few get closer).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::iterateCursor):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 3:16 PM Changeset in webkit [195786] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: Make DedicatedWorkerThread::create() an inline template method
https://bugs.webkit.org/show_bug.cgi?id=153612
Apply feedback given by Andy Estes in <https://bugs.webkit.org/show_bug.cgi?id=153612#c3> that
I inadvertently did not include in <http://trac.webkit.org/changeset/195785>.
- workers/DedicatedWorkerThread.h:
(WebCore::DedicatedWorkerThread::create): Substitute typename for class.
- 3:04 PM Changeset in webkit [195785] by
-
- 3 edits in trunk/Source/WebCore
Cleanup: Make DedicatedWorkerThread::create() an inline template method
https://bugs.webkit.org/show_bug.cgi?id=153612
Reviewed by Andy Estes.
Make use of variadic template arguments and std::forward() to forward the arguments passed
to DedicatedWorkerThread::create() to DedicatedWorkerThread::DedicatedWorkerThread(). This
removes the need to duplicate code whenever we modify the parameter types or number of
parameters taken by DedicatedWorkerThread::DedicatedWorkerThread().
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create): Deleted.
- workers/DedicatedWorkerThread.h: Reorganized listing of member functions such that we
group the creation/constructor and destructor functions.
(WebCore::DedicatedWorkerThread::create): Modified to be an inline template with variadic
parameters that std::forward()s its arguments to DedicatedWorkerThread::DedicatedWorkerThread().
- 2:52 PM Changeset in webkit [195784] by
-
- 8 edits in trunk
Modern IDB: SQLite backend doesn't handle mutation during cursor iteration.
https://bugs.webkit.org/show_bug.cgi?id=153614
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (A few failing tests pass, a few get closer).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange): Call notifyCursorsOfChanges.
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Ditto.
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
(WebCore::IDBServer::SQLiteIDBCursor::~SQLiteIDBCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor): Remember these transient backing
store cursors so they can be notified of changes.
(WebCore::IDBServer::SQLiteIDBTransaction::closeCursor): Handle removing the cursor from the right set.
(WebCore::IDBServer::SQLiteIDBTransaction::notifyCursorsOfChanges):
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:40 PM Changeset in webkit [195783] by
-
- 4 edits in trunk
Modern IDB: SQLite backend doesn't support deleting ranges with more than one key.
https://bugs.webkit.org/show_bug.cgi?id=153604
Reviewed by Andy Estes.
Source/WebCore:
No new tests (A few failing tests pass, a few get closer).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:24 PM Changeset in webkit [195782] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build after r195774.
- platform/network/ParsedContentRange.cpp:
- 1:17 PM Changeset in webkit [195781] by
-
- 3 edits in trunk/Source/WebCore
Add an ArrayValue::get overload that returns a string
https://bugs.webkit.org/show_bug.cgi?id=153613
Reviewed by Tim Horton.
- bindings/js/ArrayValue.cpp:
(WebCore::ArrayValue::get):
- bindings/js/ArrayValue.h:
- 1:14 PM Changeset in webkit [195780] by
-
- 1712 edits23 copies25 adds in trunk/LayoutTests
[GTK] Unreviewed gardening after r195740.
- platform/gtk/TestExpectations
- platform/gtk/accessibility/table-detection-expected.txt
- platform/gtk/css1/basic/containment-expected.png
- platform/gtk/css1/basic/containment-expected.txt
- platform/gtk/css1/basic/contextual_selectors-expected.png
- platform/gtk/css1/basic/contextual_selectors-expected.txt
- platform/gtk/css1/basic/grouping-expected.png
- platform/gtk/css1/basic/grouping-expected.txt
- platform/gtk/css1/basic/id_as_selector-expected.png
- platform/gtk/css1/basic/id_as_selector-expected.txt
- platform/gtk/css1/basic/inheritance-expected.png
- platform/gtk/css1/basic/inheritance-expected.txt
- platform/gtk/css1/box_properties/border-expected.png
- platform/gtk/css1/box_properties/border-expected.txt
- platform/gtk/css1/box_properties/border_bottom-expected.png
- platform/gtk/css1/box_properties/border_bottom-expected.txt
- platform/gtk/css1/box_properties/border_bottom_inline-expected.png
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt
- platform/gtk/css1/box_properties/border_bottom_width-expected.png
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.png
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_color-expected.png
- platform/gtk/css1/box_properties/border_color-expected.txt
- platform/gtk/css1/box_properties/border_color_inline-expected.png
- platform/gtk/css1/box_properties/border_color_inline-expected.txt
- platform/gtk/css1/box_properties/border_inline-expected.png
- platform/gtk/css1/box_properties/border_inline-expected.txt
- platform/gtk/css1/box_properties/border_left-expected.png
- platform/gtk/css1/box_properties/border_left-expected.txt
- platform/gtk/css1/box_properties/border_left_inline-expected.png
- platform/gtk/css1/box_properties/border_left_inline-expected.txt
- platform/gtk/css1/box_properties/border_left_width-expected.png
- platform/gtk/css1/box_properties/border_left_width-expected.txt
- platform/gtk/css1/box_properties/border_left_width_inline-expected.png
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_right-expected.png
- platform/gtk/css1/box_properties/border_right-expected.txt
- platform/gtk/css1/box_properties/border_right_inline-expected.png
- platform/gtk/css1/box_properties/border_right_inline-expected.txt
- platform/gtk/css1/box_properties/border_right_width-expected.png
- platform/gtk/css1/box_properties/border_right_width-expected.txt
- platform/gtk/css1/box_properties/border_right_width_inline-expected.png
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_style-expected.png
- platform/gtk/css1/box_properties/border_style-expected.txt
- platform/gtk/css1/box_properties/border_style_inline-expected.png
- platform/gtk/css1/box_properties/border_style_inline-expected.txt
- platform/gtk/css1/box_properties/border_top-expected.png
- platform/gtk/css1/box_properties/border_top-expected.txt
- platform/gtk/css1/box_properties/border_top_inline-expected.png
- platform/gtk/css1/box_properties/border_top_inline-expected.txt
- platform/gtk/css1/box_properties/border_top_width-expected.png
- platform/gtk/css1/box_properties/border_top_width-expected.txt
- platform/gtk/css1/box_properties/border_top_width_inline-expected.png
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt
- platform/gtk/css1/box_properties/border_width-expected.png
- platform/gtk/css1/box_properties/border_width-expected.txt
- platform/gtk/css1/box_properties/border_width_inline-expected.png
- platform/gtk/css1/box_properties/border_width_inline-expected.txt
- platform/gtk/css1/box_properties/clear-expected.png
- platform/gtk/css1/box_properties/clear-expected.txt
- platform/gtk/css1/box_properties/clear_float-expected.png
- platform/gtk/css1/box_properties/clear_float-expected.txt
- platform/gtk/css1/box_properties/float-expected.png
- platform/gtk/css1/box_properties/float-expected.txt
- platform/gtk/css1/box_properties/float_elements_in_series-expected.png
- platform/gtk/css1/box_properties/float_elements_in_series-expected.txt
- platform/gtk/css1/box_properties/float_margin-expected.png
- platform/gtk/css1/box_properties/float_margin-expected.txt
- platform/gtk/css1/box_properties/float_on_text_elements-expected.png
- platform/gtk/css1/box_properties/float_on_text_elements-expected.txt
- platform/gtk/css1/box_properties/height-expected.png
- platform/gtk/css1/box_properties/height-expected.txt
- platform/gtk/css1/box_properties/margin-expected.png
- platform/gtk/css1/box_properties/margin-expected.txt
- platform/gtk/css1/box_properties/margin_bottom-expected.png
- platform/gtk/css1/box_properties/margin_bottom-expected.txt
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.png
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt
- platform/gtk/css1/box_properties/margin_inline-expected.png
- platform/gtk/css1/box_properties/margin_inline-expected.txt
- platform/gtk/css1/box_properties/margin_left-expected.png
- platform/gtk/css1/box_properties/margin_left-expected.txt
- platform/gtk/css1/box_properties/margin_left_inline-expected.png
- platform/gtk/css1/box_properties/margin_left_inline-expected.txt
- platform/gtk/css1/box_properties/margin_right-expected.png
- platform/gtk/css1/box_properties/margin_right-expected.txt
- platform/gtk/css1/box_properties/margin_right_inline-expected.png
- platform/gtk/css1/box_properties/margin_right_inline-expected.txt
- platform/gtk/css1/box_properties/margin_top-expected.png
- platform/gtk/css1/box_properties/margin_top-expected.txt
- platform/gtk/css1/box_properties/margin_top_inline-expected.png
- platform/gtk/css1/box_properties/margin_top_inline-expected.txt
- platform/gtk/css1/box_properties/padding-expected.txt
- platform/gtk/css1/box_properties/padding_bottom-expected.png
- platform/gtk/css1/box_properties/padding_bottom-expected.txt
- platform/gtk/css1/box_properties/padding_bottom_inline-expected.png
- platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt
- platform/gtk/css1/box_properties/padding_inline-expected.png
- platform/gtk/css1/box_properties/padding_inline-expected.txt
- platform/gtk/css1/box_properties/padding_left-expected.png
- platform/gtk/css1/box_properties/padding_left-expected.txt
- platform/gtk/css1/box_properties/padding_left_inline-expected.png
- platform/gtk/css1/box_properties/padding_left_inline-expected.txt
- platform/gtk/css1/box_properties/padding_right-expected.png
- platform/gtk/css1/box_properties/padding_right-expected.txt
- platform/gtk/css1/box_properties/padding_right_inline-expected.png
- platform/gtk/css1/box_properties/padding_right_inline-expected.txt
- platform/gtk/css1/box_properties/padding_top-expected.txt
- platform/gtk/css1/box_properties/padding_top_inline-expected.png
- platform/gtk/css1/box_properties/padding_top_inline-expected.txt
- platform/gtk/css1/box_properties/width-expected.png
- platform/gtk/css1/box_properties/width-expected.txt
- platform/gtk/css1/cascade/cascade_order-expected.png
- platform/gtk/css1/cascade/cascade_order-expected.txt
- platform/gtk/css1/cascade/important-expected.png
- platform/gtk/css1/cascade/important-expected.txt
- platform/gtk/css1/classification/display-expected.png
- platform/gtk/css1/classification/display-expected.txt
- platform/gtk/css1/classification/list_style-expected.png
- platform/gtk/css1/classification/list_style-expected.txt
- platform/gtk/css1/classification/list_style_image-expected.png
- platform/gtk/css1/classification/list_style_image-expected.txt
- platform/gtk/css1/classification/list_style_position-expected.png
- platform/gtk/css1/classification/list_style_position-expected.txt
- platform/gtk/css1/classification/list_style_type-expected.png
- platform/gtk/css1/classification/list_style_type-expected.txt
- platform/gtk/css1/classification/white_space-expected.png
- platform/gtk/css1/classification/white_space-expected.txt
- platform/gtk/css1/color_and_background/background-expected.png
- platform/gtk/css1/color_and_background/background-expected.txt
- platform/gtk/css1/color_and_background/background_attachment-expected.png
- platform/gtk/css1/color_and_background/background_attachment-expected.txt
- platform/gtk/css1/color_and_background/background_color-expected.png
- platform/gtk/css1/color_and_background/background_color-expected.txt
- platform/gtk/css1/color_and_background/background_image-expected.png
- platform/gtk/css1/color_and_background/background_image-expected.txt
- platform/gtk/css1/color_and_background/background_position-expected.png
- platform/gtk/css1/color_and_background/background_position-expected.txt
- platform/gtk/css1/color_and_background/background_repeat-expected.png
- platform/gtk/css1/color_and_background/background_repeat-expected.txt
- platform/gtk/css1/color_and_background/color-expected.png
- platform/gtk/css1/color_and_background/color-expected.txt
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt
- platform/gtk/css1/font_properties/font-expected.png
- platform/gtk/css1/font_properties/font-expected.txt
- platform/gtk/css1/font_properties/font_family-expected.png
- platform/gtk/css1/font_properties/font_family-expected.txt
- platform/gtk/css1/font_properties/font_size-expected.png
- platform/gtk/css1/font_properties/font_size-expected.txt
- platform/gtk/css1/font_properties/font_style-expected.png
- platform/gtk/css1/font_properties/font_style-expected.txt
- platform/gtk/css1/font_properties/font_variant-expected.png
- platform/gtk/css1/font_properties/font_variant-expected.txt
- platform/gtk/css1/font_properties/font_weight-expected.png
- platform/gtk/css1/font_properties/font_weight-expected.txt
- platform/gtk/css1/formatting_model/canvas-expected.png
- platform/gtk/css1/formatting_model/canvas-expected.txt
- platform/gtk/css1/formatting_model/floating_elements-expected.png
- platform/gtk/css1/formatting_model/floating_elements-expected.txt
- platform/gtk/css1/formatting_model/height_of_lines-expected.png
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt
- platform/gtk/css1/formatting_model/inline_elements-expected.png
- platform/gtk/css1/formatting_model/inline_elements-expected.txt
- platform/gtk/css1/formatting_model/replaced_elements-expected.png
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt
- platform/gtk/css1/pseudo/anchor-expected.png
- platform/gtk/css1/pseudo/anchor-expected.txt
- platform/gtk/css1/pseudo/firstletter-expected.png
- platform/gtk/css1/pseudo/firstletter-expected.txt
- platform/gtk/css1/pseudo/firstline-expected.png
- platform/gtk/css1/pseudo/firstline-expected.txt
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.png
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.png
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt
- platform/gtk/css1/text_properties/letter_spacing-expected.txt
- platform/gtk/css1/text_properties/line_height-expected.png
- platform/gtk/css1/text_properties/line_height-expected.txt
- platform/gtk/css1/text_properties/text_align-expected.png
- platform/gtk/css1/text_properties/text_align-expected.txt
- platform/gtk/css1/text_properties/text_decoration-expected.png
- platform/gtk/css1/text_properties/text_decoration-expected.txt
- platform/gtk/css1/text_properties/text_indent-expected.png
- platform/gtk/css1/text_properties/text_indent-expected.txt
- platform/gtk/css1/text_properties/text_transform-expected.png
- platform/gtk/css1/text_properties/text_transform-expected.txt
- platform/gtk/css1/text_properties/vertical_align-expected.png
- platform/gtk/css1/text_properties/vertical_align-expected.txt
- platform/gtk/css1/text_properties/word_spacing-expected.png
- platform/gtk/css1/text_properties/word_spacing-expected.txt
- platform/gtk/css1/units/color_units-expected.png
- platform/gtk/css1/units/color_units-expected.txt
- platform/gtk/css1/units/length_units-expected.png
- platform/gtk/css1/units/length_units-expected.txt
- platform/gtk/css1/units/percentage_units-expected.png
- platform/gtk/css1/units/percentage_units-expected.txt
- platform/gtk/css1/units/urls-expected.png
- platform/gtk/css1/units/urls-expected.txt
- platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.png
- platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.txt
- platform/gtk/css2.1/20110323/border-conflict-style-079-expected.png
- platform/gtk/css2.1/20110323/border-conflict-style-079-expected.txt
- platform/gtk/css2.1/20110323/border-conflict-style-088-expected.png
- platform/gtk/css2.1/20110323/border-conflict-style-088-expected.txt
- platform/gtk/css2.1/20110323/dynamic-top-change-002-expected.txt
- platform/gtk/css2.1/20110323/dynamic-top-change-003-expected.txt
- platform/gtk/css2.1/20110323/inline-table-001-expected.txt
- platform/gtk/css2.1/20110323/inline-table-003-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-001-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-002-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-003-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-004-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-005-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-007-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-013-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-014-expected.txt
- platform/gtk/css2.1/20110323/margin-applies-to-015-expected.txt
- platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png
- platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt
- platform/gtk/css2.1/20110323/table-caption-001-expected.txt
- platform/gtk/css2.1/20110323/table-caption-optional-001-expected.txt
- platform/gtk/css2.1/20110323/table-caption-optional-002-expected.txt
- platform/gtk/css2.1/t040302-c61-ex-len-00-b-a-expected.txt
- platform/gtk/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt
- platform/gtk/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt
- platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt
- platform/gtk/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt
- platform/gtk/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt
- platform/gtk/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt
- platform/gtk/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-04-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-04-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-06-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-06-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-08-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-08-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-13-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-13-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-14-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-14-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-16-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-16-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-17-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-17-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-18-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-18-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-24-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-24-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-25-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-25-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-30-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-30-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-31-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-31-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-34-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-34-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-44-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-44-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-52-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-52-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-54-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-54-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-59-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-59-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-64-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-64-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-65-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-65-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-70-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-70-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-71-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-71-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-74-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-74-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-84-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-84-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-85-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-85-d-expected.txt
- platform/gtk/css2.1/t170602-bdr-conflct-w-94-d-expected.png
- platform/gtk/css2.1/t170602-bdr-conflct-w-94-d-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-177-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-178-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-179-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-180-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-181-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-189-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-190-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-191-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-192-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-193-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-194-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-195-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-196-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-205-expected.txt
- platform/gtk/css2.1/tables/table-anonymous-objects-206-expected.txt
- platform/gtk/css3/css3-modsel-33-expected.png
- platform/gtk/css3/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-18-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-18-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-29-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-29-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-29b-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-29b-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-33-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-73-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-73-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-73b-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-73b-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-77-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-77-expected.txt
- platform/gtk/css3/selectors3/html/css3-modsel-77b-expected.png
- platform/gtk/css3/selectors3/html/css3-modsel-77b-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29b-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-29b-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-33-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73b-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-73b-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77-expected.txt
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77b-expected.png
- platform/gtk/css3/selectors3/xhtml/css3-modsel-77b-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-18-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-18-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-29-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-29-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-29b-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-29b-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-33-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-33-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-73-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-73-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-73b-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-73b-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-77-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-77-expected.txt
- platform/gtk/css3/selectors3/xml/css3-modsel-77b-expected.png
- platform/gtk/css3/selectors3/xml/css3-modsel-77b-expected.txt
- platform/gtk/editing/deleting/4922367-expected.txt
- platform/gtk/editing/deleting/5126166-expected.png
- platform/gtk/editing/deleting/5126166-expected.txt
- platform/gtk/editing/deleting/5144139-2-expected.png
- platform/gtk/editing/deleting/5144139-2-expected.txt
- platform/gtk/editing/deleting/5206311-1-expected.png
- platform/gtk/editing/deleting/5206311-1-expected.txt
- platform/gtk/editing/deleting/5433862-2-expected.png
- platform/gtk/editing/deleting/5433862-2-expected.txt
- platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.png
- platform/gtk/editing/inserting/paragraph-separator-in-table-1-expected.txt
- platform/gtk/editing/pasteboard/innerText-inline-table-expected.png
- platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt
- platform/gtk/editing/selection/3690703-2-expected.png
- platform/gtk/editing/selection/3690703-2-expected.txt
- platform/gtk/editing/selection/3690703-expected.png
- platform/gtk/editing/selection/3690703-expected.txt
- platform/gtk/editing/selection/3690719-expected.png
- platform/gtk/editing/selection/3690719-expected.txt
- platform/gtk/editing/selection/5057506-2-expected.png
- platform/gtk/editing/selection/5057506-2-expected.txt
- platform/gtk/editing/selection/5057506-expected.png
- platform/gtk/editing/selection/5057506-expected.txt
- platform/gtk/editing/selection/5131716-1-expected.txt
- platform/gtk/editing/selection/5131716-2-expected.txt
- platform/gtk/editing/selection/5131716-3-expected.txt
- platform/gtk/editing/selection/5131716-4-expected.txt
- platform/gtk/editing/selection/move-by-line-001-expected.png
- platform/gtk/editing/selection/move-by-line-001-expected.txt
- platform/gtk/editing/selection/select-all-004-expected.png
- platform/gtk/editing/selection/select-all-004-expected.txt
- platform/gtk/editing/unsupported-content/table-type-after-expected.png
- platform/gtk/editing/unsupported-content/table-type-after-expected.txt
- platform/gtk/editing/unsupported-content/table-type-before-expected.png
- platform/gtk/editing/unsupported-content/table-type-before-expected.txt
- platform/gtk/fast/block/basic/016-expected.txt
- platform/gtk/fast/block/basic/quirk-percent-height-table-cell-expected.png
- platform/gtk/fast/block/basic/quirk-percent-height-table-cell-expected.txt
- platform/gtk/fast/block/float/015-expected.png
- platform/gtk/fast/block/float/015-expected.txt
- platform/gtk/fast/block/margin-collapse/006-expected.txt
- platform/gtk/fast/block/margin-collapse/010-expected.txt
- platform/gtk/fast/block/margin-collapse/011-expected.txt
- platform/gtk/fast/block/margin-collapse/012-expected.txt
- platform/gtk/fast/block/margin-collapse/015-expected.txt
- platform/gtk/fast/block/margin-collapse/016-expected.txt
- platform/gtk/fast/block/margin-collapse/017-expected.txt
- platform/gtk/fast/block/margin-collapse/018-expected.txt
- platform/gtk/fast/block/margin-collapse/019-expected.png
- platform/gtk/fast/block/margin-collapse/019-expected.txt
- platform/gtk/fast/block/margin-collapse/020-expected.png
- platform/gtk/fast/block/margin-collapse/020-expected.txt
- platform/gtk/fast/block/margin-collapse/021-expected.txt
- platform/gtk/fast/block/margin-collapse/022-expected.txt
- platform/gtk/fast/block/margin-collapse/025-expected.txt
- platform/gtk/fast/block/margin-collapse/032-expected.txt
- platform/gtk/fast/block/margin-collapse/033-expected.txt
- platform/gtk/fast/block/margin-collapse/034-expected.txt
- platform/gtk/fast/block/margin-collapse/041-expected.txt
- platform/gtk/fast/block/margin-collapse/042-expected.txt
- platform/gtk/fast/block/margin-collapse/055-expected.txt
- platform/gtk/fast/block/margin-collapse/056-expected.txt
- platform/gtk/fast/block/margin-collapse/057-expected.txt
- platform/gtk/fast/block/margin-collapse/058-expected.txt
- platform/gtk/fast/block/margin-collapse/059-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.png
- platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.png
- platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt
- platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt
- platform/gtk/fast/block/positioning/table-cell-static-position-expected.txt
- platform/gtk/fast/borders/border-antialiasing-expected.png
- platform/gtk/fast/borders/border-antialiasing-expected.txt
- platform/gtk/fast/borders/border-radius-different-width-001-expected.png
- platform/gtk/fast/borders/border-radius-different-width-001-expected.txt
- platform/gtk/fast/borders/table-borders-expected.png
- platform/gtk/fast/borders/table-borders-expected.txt
- platform/gtk/fast/css-generated-content/first-letter-in-nested-before-expected.txt
- platform/gtk/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt
- platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt
- platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt
- platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt
- platform/gtk/fast/css-generated-content/table-row-group-with-before-expected.png
- platform/gtk/fast/css-generated-content/table-row-group-with-before-expected.txt
- platform/gtk/fast/css-generated-content/table-row-with-before-expected.png
- platform/gtk/fast/css-generated-content/table-row-with-before-expected.txt
- platform/gtk/fast/css-generated-content/table-with-before-expected.png
- platform/gtk/fast/css-generated-content/table-with-before-expected.txt
- platform/gtk/fast/css/003-expected.txt
- platform/gtk/fast/css/absolute-poition-in-rtl-parent-expected.txt
- platform/gtk/fast/css/acid2-expected.png
- platform/gtk/fast/css/acid2-expected.txt
- platform/gtk/fast/css/acid2-pixel-expected.png
- platform/gtk/fast/css/acid2-pixel-expected.txt
- platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.png
- platform/gtk/fast/css/bidi-override-in-anonymous-block-expected.txt
- platform/gtk/fast/css/box-shadow-and-border-radius-expected.png
- platform/gtk/fast/css/box-shadow-and-border-radius-expected.txt
- platform/gtk/fast/css/caption-width-absolute-position-expected.txt
- platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt
- platform/gtk/fast/css/caption-width-fixed-position-expected.txt
- platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt
- platform/gtk/fast/css/caption-width-relative-position-expected.txt
- platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt
- platform/gtk/fast/css/css3-nth-child-expected.png
- platform/gtk/fast/css/css3-nth-child-expected.txt
- platform/gtk/fast/css/focus-ring-detached-expected.png
- platform/gtk/fast/css/focus-ring-detached-expected.txt
- platform/gtk/fast/css/focus-ring-multiline-expected.png
- platform/gtk/fast/css/focus-ring-multiline-expected.txt
- platform/gtk/fast/css/h1-in-section-elements-expected.png
- platform/gtk/fast/css/h1-in-section-elements-expected.txt
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt
- platform/gtk/fast/css/percentage-non-integer-expected.png
- platform/gtk/fast/css/percentage-non-integer-expected.txt
- platform/gtk/fast/css/table-text-align-quirk-expected.txt
- platform/gtk/fast/css/table-text-align-strict-expected.txt
- platform/gtk/fast/dom/34176-expected.png
- platform/gtk/fast/dom/34176-expected.txt
- platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.png
- platform/gtk/fast/dom/HTMLTableElement/colSpan-expected.txt
- platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.png
- platform/gtk/fast/dom/HTMLTableElement/createCaption-expected.txt
- platform/gtk/fast/dom/row-inner-text-expected.png
- platform/gtk/fast/dom/row-inner-text-expected.txt
- platform/gtk/fast/dynamic/001-expected.txt
- platform/gtk/fast/dynamic/containing-block-change-expected.png
- platform/gtk/fast/dynamic/containing-block-change-expected.txt
- platform/gtk/fast/dynamic/float-withdrawal-expected.png
- platform/gtk/fast/dynamic/float-withdrawal-expected.txt
- platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.png
- platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
- platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt
- platform/gtk/fast/encoding/utf-16-big-endian-expected.png
- platform/gtk/fast/encoding/utf-16-big-endian-expected.txt
- platform/gtk/fast/encoding/utf-16-little-endian-expected.png
- platform/gtk/fast/encoding/utf-16-little-endian-expected.txt
- platform/gtk/fast/forms/001-expected.png
- platform/gtk/fast/forms/001-expected.txt
- platform/gtk/fast/forms/005-expected.txt
- platform/gtk/fast/forms/basic-buttons-expected.png
- platform/gtk/fast/forms/basic-buttons-expected.txt
- platform/gtk/fast/forms/form-element-geometry-expected.png
- platform/gtk/fast/forms/form-element-geometry-expected.txt
- platform/gtk/fast/forms/form-hides-table-expected.png
- platform/gtk/fast/forms/form-hides-table-expected.txt
- platform/gtk/fast/forms/form-in-malformed-markup-expected.txt
- platform/gtk/fast/forms/formmove3-expected.png
- platform/gtk/fast/forms/formmove3-expected.txt
- platform/gtk/fast/forms/input-table-expected.png
- platform/gtk/fast/forms/input-table-expected.txt
- platform/gtk/fast/forms/listbox-bidi-align-expected.png
- platform/gtk/fast/forms/listbox-bidi-align-expected.txt
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png
- platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt
- platform/gtk/fast/html/details-writing-mode-expected.png
- platform/gtk/fast/html/details-writing-mode-expected.txt
- platform/gtk/fast/inline-block/001-expected.txt
- platform/gtk/fast/inline-block/overflow-clip-expected.png
- platform/gtk/fast/inline-block/overflow-clip-expected.txt
- platform/gtk/fast/invalid/012-expected.txt
- platform/gtk/fast/invalid/018-expected.txt
- platform/gtk/fast/lists/004-expected.png
- platform/gtk/fast/lists/004-expected.txt
- platform/gtk/fast/lists/list-marker-before-content-table-expected.png
- platform/gtk/fast/lists/list-marker-before-content-table-expected.txt
- platform/gtk/fast/multicol/span/before-child-anonymous-column-block-expected.txt
- platform/gtk/fast/multicol/table-vertical-align-expected.png
- platform/gtk/fast/overflow/002-expected.png
- platform/gtk/fast/overflow/002-expected.txt
- platform/gtk/fast/overflow/overflow-rtl-expected.png
- platform/gtk/fast/overflow/overflow-rtl-expected.txt
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png
- platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt
- platform/gtk/fast/overflow/table-overflow-float-expected.txt
- platform/gtk/fast/reflections/table-cell-expected.txt
- platform/gtk/fast/repaint/block-selection-gap-in-table-cell-expected.txt
- platform/gtk/fast/repaint/float-overflow-expected.png
- platform/gtk/fast/repaint/float-overflow-expected.txt
- platform/gtk/fast/repaint/float-overflow-right-expected.png
- platform/gtk/fast/repaint/float-overflow-right-expected.txt
- platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt
- platform/gtk/fast/repaint/table-cell-collapsed-border-expected.png
- platform/gtk/fast/repaint/table-cell-collapsed-border-expected.txt
- platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt
- platform/gtk/fast/repaint/table-cell-move-expected.png
- platform/gtk/fast/repaint/table-cell-move-expected.txt
- platform/gtk/fast/repaint/table-cell-overflow-expected.txt
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.png
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.txt
- platform/gtk/fast/repaint/table-col-background-expected.txt
- platform/gtk/fast/repaint/table-collapsed-border-expected.txt
- platform/gtk/fast/repaint/table-extra-bottom-grow-expected.png
- platform/gtk/fast/repaint/table-extra-bottom-grow-expected.txt
- platform/gtk/fast/repaint/table-outer-border-expected.txt
- platform/gtk/fast/repaint/table-row-expected.txt
- platform/gtk/fast/repaint/table-section-overflow-expected.txt
- platform/gtk/fast/repaint/table-section-repaint-expected.txt
- platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.png
- platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.txt
- platform/gtk/fast/repaint/table-writing-modes-h-expected.txt
- platform/gtk/fast/repaint/table-writing-modes-v-expected.txt
- platform/gtk/fast/replaced/005-expected.png
- platform/gtk/fast/replaced/005-expected.txt
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt
- platform/gtk/fast/replaced/selection-rect-in-table-cell-expected.png
- platform/gtk/fast/replaced/selection-rect-in-table-cell-expected.txt
- platform/gtk/fast/replaced/table-percent-height-positioned-expected.txt
- platform/gtk/fast/replaced/width100percent-checkbox-expected.png
- platform/gtk/fast/replaced/width100percent-checkbox-expected.txt
- platform/gtk/fast/replaced/width100percent-image-expected.png
- platform/gtk/fast/replaced/width100percent-image-expected.txt
- platform/gtk/fast/replaced/width100percent-menulist-expected.png
- platform/gtk/fast/replaced/width100percent-menulist-expected.txt
- platform/gtk/fast/replaced/width100percent-radio-expected.png
- platform/gtk/fast/replaced/width100percent-radio-expected.txt
- platform/gtk/fast/replaced/width100percent-searchfield-expected.png
- platform/gtk/fast/replaced/width100percent-searchfield-expected.txt
- platform/gtk/fast/replaced/width100percent-textarea-expected.png
- platform/gtk/fast/replaced/width100percent-textarea-expected.txt
- platform/gtk/fast/replaced/width100percent-textfield-expected.png
- platform/gtk/fast/replaced/width100percent-textfield-expected.txt
- platform/gtk/fast/selectors/077-expected.png
- platform/gtk/fast/selectors/077-expected.txt
- platform/gtk/fast/selectors/077b-expected.png
- platform/gtk/fast/selectors/077b-expected.txt
- platform/gtk/fast/table/002-expected.png
- platform/gtk/fast/table/002-expected.txt
- platform/gtk/fast/table/005-expected.png
- platform/gtk/fast/table/005-expected.txt
- platform/gtk/fast/table/007-expected.png
- platform/gtk/fast/table/007-expected.txt
- platform/gtk/fast/table/008-expected.txt
- platform/gtk/fast/table/009-expected.png
- platform/gtk/fast/table/009-expected.txt
- platform/gtk/fast/table/012-expected.txt
- platform/gtk/fast/table/013-expected.png
- platform/gtk/fast/table/013-expected.txt
- platform/gtk/fast/table/021-expected.png
- platform/gtk/fast/table/021-expected.txt
- platform/gtk/fast/table/023-expected.png
- platform/gtk/fast/table/023-expected.txt
- platform/gtk/fast/table/024-expected.txt
- platform/gtk/fast/table/025-expected.png
- platform/gtk/fast/table/025-expected.txt
- platform/gtk/fast/table/028-expected.png
- platform/gtk/fast/table/028-expected.txt
- platform/gtk/fast/table/028-vertical-expected.png
- platform/gtk/fast/table/028-vertical-expected.txt
- platform/gtk/fast/table/029-expected.png
- platform/gtk/fast/table/029-expected.txt
- platform/gtk/fast/table/031-expected.txt
- platform/gtk/fast/table/032-expected.txt
- platform/gtk/fast/table/034-expected.txt
- platform/gtk/fast/table/038-expected.png
- platform/gtk/fast/table/038-expected.txt
- platform/gtk/fast/table/038-vertical-expected.png
- platform/gtk/fast/table/038-vertical-expected.txt
- platform/gtk/fast/table/039-expected.png
- platform/gtk/fast/table/039-expected.txt
- platform/gtk/fast/table/040-expected.png
- platform/gtk/fast/table/040-expected.txt
- platform/gtk/fast/table/040-vertical-expected.png
- platform/gtk/fast/table/040-vertical-expected.txt
- platform/gtk/fast/table/100-percent-cell-width-expected.png
- platform/gtk/fast/table/100-percent-cell-width-expected.txt
- platform/gtk/fast/table/add-before-anonymous-child-expected.png
- platform/gtk/fast/table/add-before-anonymous-child-expected.txt
- platform/gtk/fast/table/border-collapsing/001-expected.png
- platform/gtk/fast/table/border-collapsing/001-expected.txt
- platform/gtk/fast/table/border-collapsing/001-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/001-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/002-expected.png
- platform/gtk/fast/table/border-collapsing/002-expected.txt
- platform/gtk/fast/table/border-collapsing/002-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/002-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/003-expected.txt
- platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/004-expected.png
- platform/gtk/fast/table/border-collapsing/004-expected.txt
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-expected.png
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/bug14274-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-69296-expected.png
- platform/gtk/fast/table/border-collapsing/cached-69296-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-cell-append-expected.png
- platform/gtk/fast/table/border-collapsing/cached-cell-append-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-cell-remove-expected.png
- platform/gtk/fast/table/border-collapsing/cached-cell-remove-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-width-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-col-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-col-border-width-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-col-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-row-border-color-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-row-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-row-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-table-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-table-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-color-expected.png
- platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt
- platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt
- platform/gtk/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt
- platform/gtk/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt
- platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-expected.txt
- platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.png
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-expected.txt
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png
- platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt
- platform/gtk/fast/table/caption-relayout-expected.txt
- platform/gtk/fast/table/cell-absolute-child-expected.png
- platform/gtk/fast/table/cell-absolute-child-expected.txt
- platform/gtk/fast/table/cell-width-auto-expected.txt
- platform/gtk/fast/table/colspan-with-all-percent-cells-expected.png
- platform/gtk/fast/table/colspan-with-all-percent-cells-expected.txt
- platform/gtk/fast/table/colspanMinWidth-expected.png
- platform/gtk/fast/table/colspanMinWidth-expected.txt
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.png
- platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt
- platform/gtk/fast/table/dynamic-cellpadding-expected.png
- platform/gtk/fast/table/dynamic-cellpadding-expected.txt
- platform/gtk/fast/table/edge-offsets-expected.png
- platform/gtk/fast/table/edge-offsets-expected.txt
- platform/gtk/fast/table/empty-cells-expected.png
- platform/gtk/fast/table/empty-cells-expected.txt
- platform/gtk/fast/table/frame-and-rules-expected.png
- platform/gtk/fast/table/frame-and-rules-expected.txt
- platform/gtk/fast/table/giantRowspan-expected.png
- platform/gtk/fast/table/giantRowspan-expected.txt
- platform/gtk/fast/table/growCellForImageQuirk-expected.txt
- platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt
- platform/gtk/fast/table/height-percent-test-expected.txt
- platform/gtk/fast/table/height-percent-test-vertical-expected.txt
- platform/gtk/fast/table/invisible-cell-background-expected.txt
- platform/gtk/fast/table/large-width-expected.png
- platform/gtk/fast/table/large-width-expected.txt
- platform/gtk/fast/table/max-width-integer-overflow-expected.txt
- platform/gtk/fast/table/mozilla-bug10296-vertical-align-1-expected.txt
- platform/gtk/fast/table/mozilla-bug10296-vertical-align-2-expected.txt
- platform/gtk/fast/table/nobr-expected.png
- platform/gtk/fast/table/nobr-expected.txt
- platform/gtk/fast/table/overflowHidden-expected.png
- platform/gtk/fast/table/overflowHidden-expected.txt
- platform/gtk/fast/table/percent-heights-expected.png
- platform/gtk/fast/table/percent-heights-expected.txt
- platform/gtk/fast/table/percent-widths-stretch-expected.png
- platform/gtk/fast/table/percent-widths-stretch-expected.txt
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt
- platform/gtk/fast/table/prepend-in-anonymous-table-expected.png
- platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt
- platform/gtk/fast/table/relative-position-containment-expected.txt
- platform/gtk/fast/table/relative-position-offsets-expected.txt
- platform/gtk/fast/table/relative-position-stacking-expected.txt
- platform/gtk/fast/table/replaced-percent-height-expected.png
- platform/gtk/fast/table/replaced-percent-height-expected.txt
- platform/gtk/fast/table/row-height-recalc-expected.png
- platform/gtk/fast/table/row-height-recalc-expected.txt
- platform/gtk/fast/table/rowspan-paint-order-expected.png
- platform/gtk/fast/table/rowspan-paint-order-expected.txt
- platform/gtk/fast/table/rowspan-paint-order-vertical-expected.png
- platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt
- platform/gtk/fast/table/simple_paint-expected.txt
- platform/gtk/fast/table/spanOverlapRepaint-expected.png
- platform/gtk/fast/table/spanOverlapRepaint-expected.txt
- platform/gtk/fast/table/stale-grid-crash-expected.png
- platform/gtk/fast/table/stale-grid-crash-expected.txt
- platform/gtk/fast/table/table-anonymous-cell-bug-expected.txt
- platform/gtk/fast/table/table-anonymous-row-bug-expected.txt
- platform/gtk/fast/table/table-anonymous-section-bug-expected.txt
- platform/gtk/fast/table/table-before-child-style-update-expected.txt
- platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt
- platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt
- platform/gtk/fast/table/table-cell-before-after-content-around-table-row-expected.txt
- platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt
- platform/gtk/fast/table/table-cell-split-expected.txt
- platform/gtk/fast/table/table-display-types-expected.txt
- platform/gtk/fast/table/table-display-types-strict-expected.txt
- platform/gtk/fast/table/table-display-types-vertical-expected.txt
- platform/gtk/fast/table/table-insert-before-non-anonymous-block-expected.txt
- platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt
- platform/gtk/fast/table/table-row-before-after-content-around-table-cell-expected.txt
- platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt
- platform/gtk/fast/table/table-row-before-child-style-update-expected.txt
- platform/gtk/fast/table/table-row-outline-paint-expected.png
- platform/gtk/fast/table/table-row-outline-paint-expected.txt
- platform/gtk/fast/table/table-row-split2-expected.txt
- platform/gtk/fast/table/table-row-style-not-updated-expected.txt
- platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt
- platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt
- platform/gtk/fast/table/table-section-split2-expected.txt
- platform/gtk/fast/table/table-split-expected.txt
- platform/gtk/fast/table/table-split2-expected.txt
- platform/gtk/fast/table/table-style-not-updated-expected.txt
- platform/gtk/fast/table/wide-colspan-expected.txt
- platform/gtk/fast/table/wide-column-expected.txt
- platform/gtk/fast/text/atsui-negative-spacing-features-expected.png
- platform/gtk/fast/text/atsui-negative-spacing-features-expected.txt
- platform/gtk/fast/text/atsui-spacing-features-expected.png
- platform/gtk/fast/text/atsui-spacing-features-expected.txt
- platform/gtk/fast/text/basic/generic-family-reset-expected.png
- platform/gtk/fast/text/basic/generic-family-reset-expected.txt
- platform/gtk/fast/text/international/003-expected.png
- platform/gtk/fast/text/international/003-expected.txt
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt
- platform/gtk/fast/text/international/bidi-override-expected.txt
- platform/gtk/fast/text/wbr-expected.txt
- platform/gtk/fast/text/whitespace/002-expected.txt
- platform/gtk/fast/text/whitespace/003-expected.txt
- platform/gtk/fast/text/whitespace/004-expected.txt
- platform/gtk/fast/text/whitespace/005-expected.txt
- platform/gtk/fast/text/whitespace/010-expected.txt
- platform/gtk/fast/text/whitespace/011-expected.txt
- platform/gtk/fast/text/whitespace/013-expected.txt
- platform/gtk/fast/text/whitespace/014-expected.txt
- platform/gtk/fast/text/whitespace/015-expected.txt
- platform/gtk/fast/text/whitespace/016-expected.txt
- platform/gtk/fast/text/whitespace/025-expected.txt
- platform/gtk/fast/text/whitespace/026-expected.txt
- platform/gtk/fast/writing-mode/table-percent-width-quirk-expected.txt
- platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png
- platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt
- platform/gtk/http/tests/misc/acid2-expected.png
- platform/gtk/http/tests/misc/acid2-pixel-expected.png
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png
- platform/gtk/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt
- platform/gtk/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt
- platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png
- platform/gtk/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt
- platform/gtk/tables/layering/paint-test-layering-1-expected.png
- platform/gtk/tables/layering/paint-test-layering-1-expected.txt
- platform/gtk/tables/layering/paint-test-layering-2-expected.png
- platform/gtk/tables/layering/paint-test-layering-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10009-expected.png
- platform/gtk/tables/mozilla/bugs/bug10009-expected.txt
- platform/gtk/tables/mozilla/bugs/bug101201-expected.png
- platform/gtk/tables/mozilla/bugs/bug101201-expected.txt
- platform/gtk/tables/mozilla/bugs/bug101674-expected.png
- platform/gtk/tables/mozilla/bugs/bug101674-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10296-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1055-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug1055-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10565-expected.png
- platform/gtk/tables/mozilla/bugs/bug10565-expected.txt
- platform/gtk/tables/mozilla/bugs/bug10633-expected.png
- platform/gtk/tables/mozilla/bugs/bug10633-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1067-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1067-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug1067-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug106795-expected.png
- platform/gtk/tables/mozilla/bugs/bug106795-expected.txt
- platform/gtk/tables/mozilla/bugs/bug106816-expected.png
- platform/gtk/tables/mozilla/bugs/bug106816-expected.txt
- platform/gtk/tables/mozilla/bugs/bug113235-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug113235-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug113424-expected.png
- platform/gtk/tables/mozilla/bugs/bug113424-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1163-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12008-expected.png
- platform/gtk/tables/mozilla/bugs/bug12008-expected.txt
- platform/gtk/tables/mozilla/bugs/bug120107-expected.txt
- platform/gtk/tables/mozilla/bugs/bug120364-expected.png
- platform/gtk/tables/mozilla/bugs/bug120364-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1224-expected.png
- platform/gtk/tables/mozilla/bugs/bug1224-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12268-expected.png
- platform/gtk/tables/mozilla/bugs/bug12268-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12709-expected.png
- platform/gtk/tables/mozilla/bugs/bug12709-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1271-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12908-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug12908-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12908-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug12910-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1296-expected.png
- platform/gtk/tables/mozilla/bugs/bug1296-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1302-expected.png
- platform/gtk/tables/mozilla/bugs/bug1302-expected.txt
- platform/gtk/tables/mozilla/bugs/bug13169-expected.png
- platform/gtk/tables/mozilla/bugs/bug13169-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1318-expected.png
- platform/gtk/tables/mozilla/bugs/bug1318-expected.txt
- platform/gtk/tables/mozilla/bugs/bug137388-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug137388-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug137388-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug137388-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug139524-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug139524-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug139524-4-expected.png
- platform/gtk/tables/mozilla/bugs/bug139524-4-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1430-expected.png
- platform/gtk/tables/mozilla/bugs/bug1430-expected.txt
- platform/gtk/tables/mozilla/bugs/bug14323-expected.png
- platform/gtk/tables/mozilla/bugs/bug14323-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1474-expected.png
- platform/gtk/tables/mozilla/bugs/bug14929-expected.png
- platform/gtk/tables/mozilla/bugs/bug14929-expected.txt
- platform/gtk/tables/mozilla/bugs/bug15247-expected.png
- platform/gtk/tables/mozilla/bugs/bug15247-expected.txt
- platform/gtk/tables/mozilla/bugs/bug154780-expected.png
- platform/gtk/tables/mozilla/bugs/bug154780-expected.txt
- platform/gtk/tables/mozilla/bugs/bug15544-expected.png
- platform/gtk/tables/mozilla/bugs/bug15544-expected.txt
- platform/gtk/tables/mozilla/bugs/bug159108-expected.txt
- platform/gtk/tables/mozilla/bugs/bug15933-expected.png
- platform/gtk/tables/mozilla/bugs/bug15933-expected.txt
- platform/gtk/tables/mozilla/bugs/bug16012-expected.txt
- platform/gtk/tables/mozilla/bugs/bug16252-expected.png
- platform/gtk/tables/mozilla/bugs/bug16252-expected.txt
- platform/gtk/tables/mozilla/bugs/bug17138-expected.png
- platform/gtk/tables/mozilla/bugs/bug17138-expected.txt
- platform/gtk/tables/mozilla/bugs/bug175455-4-expected.png
- platform/gtk/tables/mozilla/bugs/bug175455-4-expected.txt
- platform/gtk/tables/mozilla/bugs/bug17548-expected.png
- platform/gtk/tables/mozilla/bugs/bug17548-expected.txt
- platform/gtk/tables/mozilla/bugs/bug17587-expected.png
- platform/gtk/tables/mozilla/bugs/bug17587-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1800-expected.png
- platform/gtk/tables/mozilla/bugs/bug1800-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1802-expected.png
- platform/gtk/tables/mozilla/bugs/bug1802-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1802s-expected.png
- platform/gtk/tables/mozilla/bugs/bug1802s-expected.txt
- platform/gtk/tables/mozilla/bugs/bug1809-expected.png
- platform/gtk/tables/mozilla/bugs/bug1809-expected.txt
- platform/gtk/tables/mozilla/bugs/bug18440-expected.png
- platform/gtk/tables/mozilla/bugs/bug18440-expected.txt
- platform/gtk/tables/mozilla/bugs/bug18664-expected.png
- platform/gtk/tables/mozilla/bugs/bug18664-expected.txt
- platform/gtk/tables/mozilla/bugs/bug18955-expected.png
- platform/gtk/tables/mozilla/bugs/bug18955-expected.txt
- platform/gtk/tables/mozilla/bugs/bug19061-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug19061-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug19061-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug19061-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug19356-expected.png
- platform/gtk/tables/mozilla/bugs/bug19356-expected.txt
- platform/gtk/tables/mozilla/bugs/bug20804-expected.png
- platform/gtk/tables/mozilla/bugs/bug20804-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2123-expected.txt
- platform/gtk/tables/mozilla/bugs/bug215629-expected.txt
- platform/gtk/tables/mozilla/bugs/bug219693-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug219693-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug219693-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug219693-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22019-expected.png
- platform/gtk/tables/mozilla/bugs/bug22019-expected.txt
- platform/gtk/tables/mozilla/bugs/bug220536-expected.png
- platform/gtk/tables/mozilla/bugs/bug220536-expected.txt
- platform/gtk/tables/mozilla/bugs/bug222336-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-2a-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-2a-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22246-3a-expected.png
- platform/gtk/tables/mozilla/bugs/bug22246-3a-expected.txt
- platform/gtk/tables/mozilla/bugs/bug22513-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2296-expected.png
- platform/gtk/tables/mozilla/bugs/bug2296-expected.txt
- platform/gtk/tables/mozilla/bugs/bug23235-expected.png
- platform/gtk/tables/mozilla/bugs/bug23235-expected.txt
- platform/gtk/tables/mozilla/bugs/bug24200-expected.png
- platform/gtk/tables/mozilla/bugs/bug24200-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug25004-expected.png
- platform/gtk/tables/mozilla/bugs/bug25004-expected.txt
- platform/gtk/tables/mozilla/bugs/bug25074-expected.txt
- platform/gtk/tables/mozilla/bugs/bug25663-expected.png
- platform/gtk/tables/mozilla/bugs/bug25663-expected.txt
- platform/gtk/tables/mozilla/bugs/bug26553-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2684-expected.png
- platform/gtk/tables/mozilla/bugs/bug2684-expected.txt
- platform/gtk/tables/mozilla/bugs/bug269566-expected.txt
- platform/gtk/tables/mozilla/bugs/bug277062-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2773-expected.png
- platform/gtk/tables/mozilla/bugs/bug2773-expected.txt
- platform/gtk/tables/mozilla/bugs/bug27993-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug27993-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2886-expected.png
- platform/gtk/tables/mozilla/bugs/bug2886-expected.txt
- platform/gtk/tables/mozilla/bugs/bug28933-expected.txt
- platform/gtk/tables/mozilla/bugs/bug29058-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug29058-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug29314-expected.txt
- platform/gtk/tables/mozilla/bugs/bug29429-expected.png
- platform/gtk/tables/mozilla/bugs/bug29429-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2954-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2981-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug2981-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2981-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug2981-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug2997-expected.png
- platform/gtk/tables/mozilla/bugs/bug2997-expected.txt
- platform/gtk/tables/mozilla/bugs/bug30273-expected.png
- platform/gtk/tables/mozilla/bugs/bug30273-expected.txt
- platform/gtk/tables/mozilla/bugs/bug30559-expected.png
- platform/gtk/tables/mozilla/bugs/bug30559-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3103-expected.png
- platform/gtk/tables/mozilla/bugs/bug3103-expected.txt
- platform/gtk/tables/mozilla/bugs/bug32205-3-expected.png
- platform/gtk/tables/mozilla/bugs/bug32205-3-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3260-expected.png
- platform/gtk/tables/mozilla/bugs/bug3260-expected.txt
- platform/gtk/tables/mozilla/bugs/bug32841-expected.png
- platform/gtk/tables/mozilla/bugs/bug33137-expected.png
- platform/gtk/tables/mozilla/bugs/bug33137-expected.txt
- platform/gtk/tables/mozilla/bugs/bug33855-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3454-expected.png
- platform/gtk/tables/mozilla/bugs/bug3454-expected.txt
- platform/gtk/tables/mozilla/bugs/bug38916-expected.png
- platform/gtk/tables/mozilla/bugs/bug38916-expected.txt
- platform/gtk/tables/mozilla/bugs/bug3977-expected.png
- platform/gtk/tables/mozilla/bugs/bug3977-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4093-expected.png
- platform/gtk/tables/mozilla/bugs/bug4093-expected.txt
- platform/gtk/tables/mozilla/bugs/bug42187-expected.png
- platform/gtk/tables/mozilla/bugs/bug42187-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4385-expected.png
- platform/gtk/tables/mozilla/bugs/bug4385-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4427-expected.png
- platform/gtk/tables/mozilla/bugs/bug4427-expected.txt
- platform/gtk/tables/mozilla/bugs/bug44505-expected.png
- platform/gtk/tables/mozilla/bugs/bug44505-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4501-expected.png
- platform/gtk/tables/mozilla/bugs/bug4501-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4527-expected.png
- platform/gtk/tables/mozilla/bugs/bug4527-expected.txt
- platform/gtk/tables/mozilla/bugs/bug45350-expected.txt
- platform/gtk/tables/mozilla/bugs/bug45486-expected.png
- platform/gtk/tables/mozilla/bugs/bug45486-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4576-expected.png
- platform/gtk/tables/mozilla/bugs/bug4576-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46268-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug46268-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46268-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug46268-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46623-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug46623-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug46623-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug46623-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug47432-expected.png
- platform/gtk/tables/mozilla/bugs/bug47432-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4803-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4849-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug4849-expected.txt
- platform/gtk/tables/mozilla/bugs/bug51727-expected.png
- platform/gtk/tables/mozilla/bugs/bug51727-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5188-expected.png
- platform/gtk/tables/mozilla/bugs/bug5188-expected.txt
- platform/gtk/tables/mozilla/bugs/bug52505-expected.png
- platform/gtk/tables/mozilla/bugs/bug52505-expected.txt
- platform/gtk/tables/mozilla/bugs/bug52506-expected.png
- platform/gtk/tables/mozilla/bugs/bug52506-expected.txt
- platform/gtk/tables/mozilla/bugs/bug53690-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug53690-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug53690-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug53891-expected.png
- platform/gtk/tables/mozilla/bugs/bug53891-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5538-expected.png
- platform/gtk/tables/mozilla/bugs/bug5538-expected.txt
- platform/gtk/tables/mozilla/bugs/bug55789-expected.txt
- platform/gtk/tables/mozilla/bugs/bug56201-expected.png
- platform/gtk/tables/mozilla/bugs/bug56201-expected.txt
- platform/gtk/tables/mozilla/bugs/bug57828-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug57828-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5797-expected.png
- platform/gtk/tables/mozilla/bugs/bug5797-expected.txt
- platform/gtk/tables/mozilla/bugs/bug5835-expected.png
- platform/gtk/tables/mozilla/bugs/bug5835-expected.txt
- platform/gtk/tables/mozilla/bugs/bug59354-expected.png
- platform/gtk/tables/mozilla/bugs/bug59354-expected.txt
- platform/gtk/tables/mozilla/bugs/bug60804-expected.png
- platform/gtk/tables/mozilla/bugs/bug60804-expected.txt
- platform/gtk/tables/mozilla/bugs/bug60807-expected.png
- platform/gtk/tables/mozilla/bugs/bug60807-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6184-expected.png
- platform/gtk/tables/mozilla/bugs/bug6184-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6304-expected.png
- platform/gtk/tables/mozilla/bugs/bug6304-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6404-expected.png
- platform/gtk/tables/mozilla/bugs/bug6404-expected.txt
- platform/gtk/tables/mozilla/bugs/bug647-expected.png
- platform/gtk/tables/mozilla/bugs/bug647-expected.txt
- platform/gtk/tables/mozilla/bugs/bug6674-expected.png
- platform/gtk/tables/mozilla/bugs/bug6674-expected.txt
- platform/gtk/tables/mozilla/bugs/bug68998-expected.png
- platform/gtk/tables/mozilla/bugs/bug68998-expected.txt
- platform/gtk/tables/mozilla/bugs/bug69382-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug69382-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug69382-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug69382-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug72359-expected.txt
- platform/gtk/tables/mozilla/bugs/bug7342-expected.png
- platform/gtk/tables/mozilla/bugs/bug7342-expected.txt
- platform/gtk/tables/mozilla/bugs/bug7714-expected.png
- platform/gtk/tables/mozilla/bugs/bug7714-expected.txt
- platform/gtk/tables/mozilla/bugs/bug78162-expected.png
- platform/gtk/tables/mozilla/bugs/bug78162-expected.txt
- platform/gtk/tables/mozilla/bugs/bug82946-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug82946-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug86708-expected.png
- platform/gtk/tables/mozilla/bugs/bug86708-expected.txt
- platform/gtk/tables/mozilla/bugs/bug8950-expected.png
- platform/gtk/tables/mozilla/bugs/bug8950-expected.txt
- platform/gtk/tables/mozilla/bugs/bug9123-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug9123-1-expected.txt
- platform/gtk/tables/mozilla/bugs/bug9123-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug9123-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug92143-expected.png
- platform/gtk/tables/mozilla/bugs/bug92143-expected.txt
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png
- platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt
- platform/gtk/tables/mozilla/bugs/bug963-expected.txt
- platform/gtk/tables/mozilla/bugs/bug96334-expected.txt
- platform/gtk/tables/mozilla/bugs/bug97383-expected.png
- platform/gtk/tables/mozilla/bugs/bug97383-expected.txt
- platform/gtk/tables/mozilla/bugs/bug9879-1-expected.png
- platform/gtk/tables/mozilla/bugs/bug9879-1-expected.txt
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt
- platform/gtk/tables/mozilla/core/bloomberg-expected.png
- platform/gtk/tables/mozilla/core/bloomberg-expected.txt
- platform/gtk/tables/mozilla/core/borders-expected.png
- platform/gtk/tables/mozilla/core/borders-expected.txt
- platform/gtk/tables/mozilla/core/cell_heights-expected.png
- platform/gtk/tables/mozilla/core/cell_heights-expected.txt
- platform/gtk/tables/mozilla/core/col_span-expected.png
- platform/gtk/tables/mozilla/core/col_span-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_fix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_fix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_fixPer-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_fixPer-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_auto_per-expected.png
- platform/gtk/tables/mozilla/core/col_widths_auto_per-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_fix-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_fix-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_fixPer-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_fixPer-expected.txt
- platform/gtk/tables/mozilla/core/col_widths_fix_per-expected.png
- platform/gtk/tables/mozilla/core/col_widths_fix_per-expected.txt
- platform/gtk/tables/mozilla/core/margins-expected.txt
- platform/gtk/tables/mozilla/core/misc-expected.png
- platform/gtk/tables/mozilla/core/misc-expected.txt
- platform/gtk/tables/mozilla/core/nested1-expected.png
- platform/gtk/tables/mozilla/core/nested1-expected.txt
- platform/gtk/tables/mozilla/core/one_row-expected.png
- platform/gtk/tables/mozilla/core/one_row-expected.txt
- platform/gtk/tables/mozilla/core/table_frame-expected.png
- platform/gtk/tables/mozilla/core/table_frame-expected.txt
- platform/gtk/tables/mozilla/core/table_heights-expected.png
- platform/gtk/tables/mozilla/core/table_heights-expected.txt
- platform/gtk/tables/mozilla/core/table_rules-expected.txt
- platform/gtk/tables/mozilla/core/table_widths-expected.png
- platform/gtk/tables/mozilla/core/table_widths-expected.txt
- platform/gtk/tables/mozilla/dom/insertColGroups1-expected.png
- platform/gtk/tables/mozilla/dom/insertColGroups1-expected.txt
- platform/gtk/tables/mozilla/dom/insertColGroups2-expected.png
- platform/gtk/tables/mozilla/dom/insertColGroups2-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols1-expected.png
- platform/gtk/tables/mozilla/dom/insertCols1-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols2-expected.png
- platform/gtk/tables/mozilla/dom/insertCols2-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols3-expected.png
- platform/gtk/tables/mozilla/dom/insertCols3-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols4-expected.png
- platform/gtk/tables/mozilla/dom/insertCols4-expected.txt
- platform/gtk/tables/mozilla/dom/insertCols5-expected.png
- platform/gtk/tables/mozilla/dom/insertCols5-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt
- platform/gtk/tables/mozilla/marvin/body_thead-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_justify-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_justify-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_span-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_span-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_width_pct-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_width_pct-expected.txt
- platform/gtk/tables/mozilla/marvin/colgroup_width_px-expected.png
- platform/gtk/tables/mozilla/marvin/colgroup_width_px-expected.txt
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.png
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt
- platform/gtk/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.png
- platform/gtk/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt
- platform/gtk/tables/mozilla/marvin/table_row_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/table_row_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/table_row_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/table_row_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/table_row_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/table_row_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/table_rules_groups-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_cellpadding_pct-expected.png
- platform/gtk/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_td_width-expected.png
- platform/gtk/tables/mozilla/marvin/tables_td_width-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.png
- platform/gtk/tables/mozilla/marvin/tables_th_colspan-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_th_width-expected.png
- platform/gtk/tables/mozilla/marvin/tables_th_width-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_width_percent-expected.png
- platform/gtk/tables/mozilla/marvin/tables_width_percent-expected.txt
- platform/gtk/tables/mozilla/marvin/tables_width_px-expected.png
- platform/gtk/tables/mozilla/marvin/tables_width_px-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/tbody_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/td_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/td_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/tfoot_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/th_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/th_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/thead_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.png
- platform/gtk/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/tr_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_span-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_span-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_width_px-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_width_px-expected.txt
- platform/gtk/tables/mozilla/marvin/x_col_width_rel-expected.png
- platform/gtk/tables/mozilla/marvin/x_col_width_rel-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_span-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_span-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_colgroup_width_rel-expected.png
- platform/gtk/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_tbody_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_td_width-expected.png
- platform/gtk/tables/mozilla/marvin/x_td_width-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_center-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_center-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_left-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_left-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_align_right-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_align_right-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_rowspan-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_rowspan-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_th_width-expected.png
- platform/gtk/tables/mozilla/marvin/x_th_width-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_thead_valign_top-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_align_char-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_align_char-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_baseline-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_bottom-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_middle-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_middle-expected.txt
- platform/gtk/tables/mozilla/marvin/x_tr_valign_top-expected.png
- platform/gtk/tables/mozilla/marvin/x_tr_valign_top-expected.txt
- platform/gtk/tables/mozilla/other/cell_widths-expected.png
- platform/gtk/tables/mozilla/other/cell_widths-expected.txt
- platform/gtk/tables/mozilla/other/ms-expected.png
- platform/gtk/tables/mozilla/other/ms-expected.txt
- platform/gtk/tables/mozilla/other/nested2-expected.png
- platform/gtk/tables/mozilla/other/nested2-expected.txt
- platform/gtk/tables/mozilla/other/nestedTables-expected.png
- platform/gtk/tables/mozilla/other/nestedTables-expected.txt
- platform/gtk/tables/mozilla/other/slashlogo-expected.png
- platform/gtk/tables/mozilla/other/slashlogo-expected.txt
- platform/gtk/tables/mozilla/other/test3-expected.png
- platform/gtk/tables/mozilla/other/test3-expected.txt
- platform/gtk/tables/mozilla/other/test6-expected.png
- platform/gtk/tables/mozilla/other/test6-expected.txt
- platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.png
- platform/gtk/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt
- platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.png
- platform/gtk/tables/mozilla/other/wa_table_tr_align-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/97619-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1010-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1010-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1128-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1164-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1164-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14159-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1647-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1647-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug17826-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug17826-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug21518-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug22122-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug27993-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3105-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3105-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug56024-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug72393-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug72393-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt
- platform/gtk/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png
- platform/gtk/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.png
- platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/col_span2-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/cols1-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/cols1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/columns-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/columns-expected.txt
- platform/gtk/tables/mozilla_expected_failures/core/standards1-expected.png
- platform/gtk/tables/mozilla_expected_failures/core/standards1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png
- platform/gtk/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png
- platform/gtk/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt
- platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.png
- platform/gtk/tables/mozilla_expected_failures/other/empty_cells-expected.txt
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.png
- platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt
- 1:06 PM Changeset in webkit [195779] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Avoid recreating Timeline's DataGridNode data multiple times
https://bugs.webkit.org/show_bug.cgi?id=153608
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-28
Reviewed by Timothy Hatcher.
- UserInterface/Views/LayoutTimelineDataGridNode.js:
(WebInspector.LayoutTimelineDataGridNode.prototype.get data):
- UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
(WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
Cache the data when we create it the first time.
- 12:50 PM FTLJIT edited by
- (diff)
- 12:46 PM FTLJIT edited by
- (diff)
- 12:35 PM Changeset in webkit [195778] by
-
- 8 edits in trunk
EventHandler IDL attributes should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=153595
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that EventHandler attributes are enumerable,
as per the specification.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Most of our EventHandler IDL attributes were marked as [NotEnumerable]
but should not have been according to the specification:
- https://html.spec.whatwg.org/#globaleventhandlers
- https://html.spec.whatwg.org/#windoweventhandlers
Firefox and Chrome behave according to the specification.
This patch aligns our behavior.
No new tests, already covered by existing tests.
- dom/Document.idl:
- dom/GlobalEventHandlers.idl:
- page/WindowEventHandlers.idl:
LayoutTests:
Rebaseline test now that more EventHandler attributes are enumerable.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 12:20 PM Changeset in webkit [195777] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r192700. rdar://problem/19861992
- 12:18 PM Changeset in webkit [195776] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r194235. rdar://problem/23944407
- 12:16 PM Changeset in webkit [195775] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore
Merged r192166. rdar://problem/22956040
- 12:13 PM Changeset in webkit [195774] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix; PRId64 formatting macro for int64_t undefined, so provide Windows-specific alternative.
- platform/network/ParsedContentRange.cpp:
- 12:13 PM Changeset in webkit [195773] by
-
- 2 edits in branches/safari-601-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 12:11 PM Changeset in webkit [195772] by
-
- 3 edits in branches/safari-601-branch/Source/WebKit/win
Merge patch for rdar://problem/23025615.
- 12:03 PM Changeset in webkit [195771] by
-
- 2 edits in trunk/Source/WebCore
[ThreadedCompositor] Fix flickers happening on video when entering/leaving fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=153585
Reviewed by Michael Catanzaro.
Video thumbnail flickers where threaded compositor is enabled. This is because
a content buffer is not set to a target layer which changes before swapBuffer.
This is a very rare case though, it happens where video size changes many times in a short period.
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):
- 11:52 AM Changeset in webkit [195770] by
-
- 11 edits in trunk/Source/WebCore
Allow CachedResourceLoader clients to opt out of the MemoryCache.
https://bugs.webkit.org/show_bug.cgi?id=153549
Reviewed by Darin Adler.
Add a flag to ResourceLoaderOptions which allow loader clients to opt out of having
resources stored in the MemoryCache.
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::cachingPolicy):
Existing clients will have to add the (default) AllowCaching flag when they create a
ResourceLoaderOptions object.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::start):
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
(WebCore::ResourceLoaderOptions::setCachingPolicy):
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
Every time the CachedResource or CachedResourceLoader accesses the MemoryCache, check
to see whether the resource or the request have allowed caching before adding resources
to, removing resources from, or sourcing resource data from the MemoryCache.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::setDecodedSize):
(WebCore::CachedResource::setEncodedSize):
(WebCore::CachedResource::didAccessDecodedData):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::allowsCaching):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printPreloadStats):
(WebCore::CachedResourceLoader::defaultCachedResourceOptions):
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::allowsCaching):
- 11:40 AM Changeset in webkit [195769] by
-
- 11 edits in trunk/Source
Should avoid navigation for some data detector urls.
https://bugs.webkit.org/show_bug.cgi?id=153600
Reviewed by Tim Horton.
Source/WebCore:
Adding helper function to decide whether the default action should be performed.
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::shouldCancelDefaultAction):
Source/WebKit2:
When a tap is commited, we normally generate a synthetic click if
the node responds to click events.
This patch adds the logic to prevent that from happening if the node
is a data detector link with certain characteristics (calendar event, telephone, etc.).
If this is the case, we compute the interaction information as position, send it
over to the UI process and notify that we did not handle the tap.
The page client is now also notified of this event and can show the data detector sheet if
appropriate.
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::toolTipChanged):
(WebKit::PageClientImpl::didNotHandleTapAsClick):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView clearSelection]):
(-[WKContentView _didNotHandleTapAsClick:]):
(-[WKContentView _positionInformationDidChange:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didNotHandleTapAsClick):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::commitPotentialTap):
- 11:34 AM Changeset in webkit [195768] by
-
- 2 edits in trunk/Tools
Unreviewed buildfix after r195743.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
- 11:30 AM Changeset in webkit [195767] by
-
- 9 edits3 adds in branches/safari-601.1.46-branch
Merged r195607. rdar://problem/23962929
- 11:21 AM Changeset in webkit [195766] by
-
- 2 edits in trunk/Source/WebCore
Roll out r194555, as it introduced some bad regressions and was not
correct.
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- 11:20 AM Changeset in webkit [195765] by
-
- 5 edits in trunk
Modern IDB: Index uniqueness broken in the SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153596
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Many failing tests now pass, others improve).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateIndexesForAddRecord): Deleted.
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:17 AM Changeset in webkit [195764] by
-
- 16 edits5 adds in trunk
Custom protocol loading through AVFoundation does not support byte-range requests.
https://bugs.webkit.org/show_bug.cgi?id=152919
<rdar://problem/23664657>
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/tests/xmlhttprequest/blob-request-byte-range.html
TestWebkitAPI/Tests/WebCore/ParsedContentRange.cpp
When loading data through the AVAssetResourceLoaderDelegateProtocol, AVFoundation will issue
requests for specific byte-ranges by adding a "Range:" HTTP header to the NSURLRequest it
passes to the delegate. WebCore ignores this header, loads the entire resource, and replies
to the callback with the requested subset of the entire resource.
For byte-range requests near the end of a resource, this is inefficient, as the entire
resource up to, and including, the requested range must be loaded before any data can be
returned. Explicitly handle byte-range requests by creating a CachedResourceRequest with the
underlying NSURLRequest (which includes the "Range:" header) rather than just the request's
URL. BlobResourceHandle must be modified to add the "Content-Range:" response header to the
ResourceResponse.
To facilitate both generating and parsing the "Content-Range:" header, add a new
ParsedContentRange class for use by ResourceResponse and its clients. This class provides
methods both for parsing a "Content-Range" header value string, and for generating the
header value from elemental values.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::didGetSize):
(WebCore::BlobResourceHandle::seek):
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
- platform/network/BlobResourceHandle.h:
- platform/network/HTTPHeaderNames.in:
- platform/network/ParsedContentRange.cpp: Added.
(WebCore::areContentRangeValuesValid):
(WebCore::parseContentRange):
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::headerValue):
- platform/network/ParsedContentRange.h: Added.
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
(WebCore::ParsedContentRange::firstBytePosition):
(WebCore::ParsedContentRange::lastBytePosition):
(WebCore::ParsedContentRange::instanceLength):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::updateHeaderParsedState):
(WebCore::parseContentRangeInHeader):
(WebCore::ResourceResponseBase::contentRange):
- platform/network/ResourceResponseBase.h:
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Tools:
Add tests for new ParsedContntRange class.
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
(TestWebKitAPI::TEST):
- 11:07 AM Changeset in webkit [195763] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge follow-up fix for r194750.
- 11:04 AM Changeset in webkit [195762] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge follow-up fix for r195625.
- 11:00 AM Changeset in webkit [195761] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/html/HTMLImageElement.h
Follow-up fix to r195751. rdar://problem/24192280
- 10:55 AM Changeset in webkit [195760] by
-
- 7 edits in trunk
Storage interface's attributes / operations should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=153573
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Storage interface's attributes / operations should be enumerable:
Firefox matches the specification.
No new tests, already covered by existing test.
- storage/Storage.idl:
- 10:41 AM Changeset in webkit [195759] by
-
- 3 edits in trunk/Tools
Use isAnyWindows() instead of isCygwin() isWindows() in Perl scripts. https://bugs.webkit.org/show_bug.cgi?id=153594
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-28
Reviewed by Alex Christensen.
- Scripts/webkitdirs.pm:
(determineNumberOfCPUs):
(jscPath):
(checkFrameworks):
(setupCygwinEnv):
(wrapperPrefixIfNeeded):
(cmakeGeneratedBuildfile):
(generateBuildSystemFromCMakeProject):
- Scripts/webkitperl/features.pm:
(libraryContainsSymbol):
- 10:41 AM Changeset in webkit [195758] by
-
- 1 edit in branches/safari-601-branch/Source/WebCore/bindings/js/JSHistoryCustom.cpp
Follow-up fix for rdar://problem/24337870
- 10:40 AM Changeset in webkit [195757] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Tabs height should be 2px less to match Safari
https://bugs.webkit.org/show_bug.cgi?id=153581
<rdar://problem/24383501>
Reviewed by Darin Adler.
- UserInterface/Views/TabBar.css:
(.tab-bar):
(.tab-bar > .item):
(.tab-bar > .item.pinned):
Make the new tab button ("+") a square.
- 10:33 AM Changeset in webkit [195756] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Update Web Process sandbox profile for audiodeviceclock access
https://bugs.webkit.org/show_bug.cgi?id=153571
<rdar://problem/24134612>
Reviewed by Alexey Proskuryakov.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 10:28 AM Changeset in webkit [195755] by
-
- 25 edits2 copies1 add in trunk/Source
Get WebVideoFullscreenManager and related classes to also compile for Mac platform
with video presentation mode support.
https://bugs.webkit.org/show_bug.cgi?id=153221
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, no actual behavior change with a stub implementation of WebVideoFullscreenInterfaceMac.
- WebCore.xcodeproj/project.pbxproj:
Add PlatformView.h, WebVideoFullscreenChangeObserver.h, and WebVideoFullscreenInterfaceMac.h.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction):
- html/HTMLMediaElement.h:
Enable the code that deals with the video fullscreen layer also for Mac platform with
video presentation mode support.
- platform/cocoa/PlatformView.h:
Header file for declaring the view types for each Cocoa platform.
- platform/cocoa/WebVideoFullscreenChangeObserver.h:
(WebCore::WebVideoFullscreenChangeObserver::~WebVideoFullscreenChangeObserver):
Interface declaration moved from WebVideoFullscreenInterfaceAVKit.h.
- platform/cocoa/WebVideoFullscreenInterface.h:
Stop guarding the declaration of WebVideoFullscreenInterface to be iOS specific. It is now
enabled for iOS and Mac platform with video presentation mode support.
- platform/cocoa/WebVideoFullscreenModel.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
Enable also for Mac platform with video presentation mode support.
(WebVideoFullscreenModelVideoElement::setVideoFullscreenLayer):
Set the video fullscreen layer's anchor point to (0, 0) since we are not changing the position of
the video layer on Mac.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
Import WebVideoFullscreenChangeObserver.h now that the interface declaration has been moved to that file.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Move the declaration of WebVideoFullscreenChangeObserver to a separate header.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Import WebVideoFullscreenChangeObserver.h now that the interface declaration has been moved to that file.
- platform/mac/WebVideoFullscreenInterfaceMac.h: Added.
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(WebCore::WebVideoFullscreenInterfaceMac::~WebVideoFullscreenInterfaceMac):
(WebCore::WebVideoFullscreenInterfaceMac::setWebVideoFullscreenModel):
(WebCore::WebVideoFullscreenInterfaceMac::setWebVideoFullscreenChangeObserver):
(WebCore::WebVideoFullscreenInterfaceMac::resetMediaState):
(WebCore::WebVideoFullscreenInterfaceMac::setDuration):
(WebCore::WebVideoFullscreenInterfaceMac::setCurrentTime):
(WebCore::WebVideoFullscreenInterfaceMac::setBufferedTime):
(WebCore::WebVideoFullscreenInterfaceMac::setRate):
(WebCore::WebVideoFullscreenInterfaceMac::setVideoDimensions):
(WebCore::WebVideoFullscreenInterfaceMac::setSeekableRanges):
(WebCore::WebVideoFullscreenInterfaceMac::setCanPlayFastReverse):
(WebCore::WebVideoFullscreenInterfaceMac::setAudioMediaSelectionOptions):
(WebCore::WebVideoFullscreenInterfaceMac::setLegibleMediaSelectionOptions):
(WebCore::WebVideoFullscreenInterfaceMac::setExternalPlayback):
(WebCore::WebVideoFullscreenInterfaceMac::setWirelessVideoPlaybackDisabled):
(WebCore::WebVideoFullscreenInterfaceMac::setupFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::enterFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::cleanupFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::invalidate):
(WebCore::WebVideoFullscreenInterfaceMac::requestHideAndExitFullscreen):
(WebCore::WebVideoFullscreenInterfaceMac::preparedToReturnToInline):
(WebCore::WebVideoFullscreenInterfaceMac::setMode):
(WebCore::WebVideoFullscreenInterfaceMac::clearMode):
(WebCore::WebVideoFullscreenInterfaceMac::mayAutomaticallyShowVideoPictureInPicture):
(WebCore::WebVideoFullscreenInterfaceMac::applicationDidBecomeActive):
(WebCore::supportsPictureInPicture):
Add a stub implementation of WebVideoFullscreenInterfaceMac.
Source/WebKit2:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:
Enabled also for Mac with video presentation mode support.
(-[WKLayerHostView makeBackingLayer]):
Make sure this view uses CALayerHost for its layer.
(WebKit::WebVideoFullscreenManagerProxy::invalidate):
(WebKit::WebVideoFullscreenManagerProxy::createModelAndInterface):
(WebKit::WebVideoFullscreenManagerProxy::ensureInterface):
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
Replace WebCore::WebVideoFullscreenInterfaceAVKit with PlatformWebVideoFullscreenInterface.
(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):
+[UIWindow _synchronizeDrawingAcrossProcesses] is not available on Mac.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::viewDidLeaveWindow):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
The code that creates m_videoFullscreenManager is now enabled also on Mac with video
presentation mode support.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
Enable the API related to the video fullscreen layer also on Mac with video presentation
mode support.
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
The code that creates m_videoFullscreenManager is now enabled also on Mac with video
presentation mode support.
- WebProcess/cocoa/WebVideoFullscreenManager.h:
- WebProcess/cocoa/WebVideoFullscreenManager.messages.in:
- WebProcess/cocoa/WebVideoFullscreenManager.mm:
Enabled also for Mac with video presentation mode support.
(WebKit::WebVideoFullscreenManager::supportsVideoFullscreen):
Return false for now on Mac.
- 10:18 AM Changeset in webkit [195754] by
-
- 1 edit in branches/safari-601-branch/LayoutTests/TestExpectations
Skip test that rely on ES6. rdar://problem/24190123
- 10:15 AM Changeset in webkit [195753] by
-
- 2 deletes in branches/safari-601-branch/LayoutTests/svg/custom
Remove pattern-content-inheritance-cycle tests. rdar://problem/23910829
- 10:08 AM Changeset in webkit [195752] by
-
- 491 edits in trunk/LayoutTests
[Win] gardening after r195740. (more to follow)
Unreviewed.
- platform/win/css1/basic/containment-expected.txt:
- platform/win/css1/basic/contextual_selectors-expected.txt:
- platform/win/css1/basic/grouping-expected.txt:
- platform/win/css1/basic/id_as_selector-expected.txt:
- platform/win/css1/basic/inheritance-expected.txt:
- platform/win/css1/box_properties/border-expected.txt:
- platform/win/css1/box_properties/border_bottom-expected.txt:
- platform/win/css1/box_properties/border_bottom_inline-expected.txt:
- platform/win/css1/box_properties/border_bottom_width-expected.txt:
- platform/win/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/win/css1/box_properties/border_color-expected.txt:
- platform/win/css1/box_properties/border_color_inline-expected.txt:
- platform/win/css1/box_properties/border_inline-expected.txt:
- platform/win/css1/box_properties/border_left-expected.txt:
- platform/win/css1/box_properties/border_left_inline-expected.txt:
- platform/win/css1/box_properties/border_left_width-expected.txt:
- platform/win/css1/box_properties/border_left_width_inline-expected.txt:
- platform/win/css1/box_properties/border_right-expected.txt:
- platform/win/css1/box_properties/border_right_inline-expected.txt:
- platform/win/css1/box_properties/border_right_width-expected.txt:
- platform/win/css1/box_properties/border_right_width_inline-expected.txt:
- platform/win/css1/box_properties/border_style-expected.txt:
- platform/win/css1/box_properties/border_style_inline-expected.txt:
- platform/win/css1/box_properties/border_top-expected.txt:
- platform/win/css1/box_properties/border_top_inline-expected.txt:
- platform/win/css1/box_properties/border_top_width-expected.txt:
- platform/win/css1/box_properties/border_top_width_inline-expected.txt:
- platform/win/css1/box_properties/border_width-expected.txt:
- platform/win/css1/box_properties/border_width_inline-expected.txt:
- platform/win/css1/box_properties/clear-expected.txt:
- platform/win/css1/box_properties/clear_float-expected.txt:
- platform/win/css1/box_properties/float-expected.txt:
- platform/win/css1/box_properties/float_elements_in_series-expected.txt:
- platform/win/css1/box_properties/float_margin-expected.txt:
- platform/win/css1/box_properties/float_on_text_elements-expected.txt:
- platform/win/css1/box_properties/height-expected.txt:
- platform/win/css1/box_properties/margin-expected.txt:
- platform/win/css1/box_properties/margin_bottom-expected.txt:
- platform/win/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/win/css1/box_properties/margin_inline-expected.txt:
- platform/win/css1/box_properties/margin_left-expected.txt:
- platform/win/css1/box_properties/margin_left_inline-expected.txt:
- platform/win/css1/box_properties/margin_right-expected.txt:
- platform/win/css1/box_properties/margin_right_inline-expected.txt:
- platform/win/css1/box_properties/margin_top-expected.txt:
- platform/win/css1/box_properties/margin_top_inline-expected.txt:
- platform/win/css1/box_properties/padding-expected.txt:
- platform/win/css1/box_properties/padding_bottom-expected.txt:
- platform/win/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/win/css1/box_properties/padding_inline-expected.txt:
- platform/win/css1/box_properties/padding_left_inline-expected.txt:
- platform/win/css1/box_properties/padding_right-expected.txt:
- platform/win/css1/box_properties/padding_right_inline-expected.txt:
- platform/win/css1/box_properties/padding_top-expected.txt:
- platform/win/css1/box_properties/padding_top_inline-expected.txt:
- platform/win/css1/box_properties/width-expected.txt:
- platform/win/css1/cascade/cascade_order-expected.txt:
- platform/win/css1/cascade/important-expected.txt:
- platform/win/css1/classification/display-expected.txt:
- platform/win/css1/classification/list_style-expected.txt:
- platform/win/css1/classification/list_style_image-expected.txt:
- platform/win/css1/classification/list_style_position-expected.txt:
- platform/win/css1/classification/list_style_type-expected.txt:
- platform/win/css1/classification/white_space-expected.txt:
- platform/win/css1/color_and_background/background-expected.txt:
- platform/win/css1/color_and_background/background_attachment-expected.txt:
- platform/win/css1/color_and_background/background_color-expected.txt:
- platform/win/css1/color_and_background/background_image-expected.txt:
- platform/win/css1/color_and_background/background_position-expected.txt:
- platform/win/css1/color_and_background/background_repeat-expected.txt:
- platform/win/css1/color_and_background/color-expected.txt:
- platform/win/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/win/css1/font_properties/font-expected.txt:
- platform/win/css1/font_properties/font_family-expected.txt:
- platform/win/css1/font_properties/font_size-expected.txt:
- platform/win/css1/font_properties/font_style-expected.txt:
- platform/win/css1/font_properties/font_variant-expected.txt:
- platform/win/css1/font_properties/font_weight-expected.txt:
- platform/win/css1/formatting_model/canvas-expected.txt:
- platform/win/css1/formatting_model/floating_elements-expected.txt:
- platform/win/css1/formatting_model/height_of_lines-expected.txt:
- platform/win/css1/formatting_model/inline_elements-expected.txt:
- platform/win/css1/formatting_model/replaced_elements-expected.txt:
- platform/win/css1/formatting_model/vertical_formatting-expected.txt:
- platform/win/css1/pseudo/anchor-expected.txt:
- platform/win/css1/pseudo/firstletter-expected.txt:
- platform/win/css1/pseudo/firstline-expected.txt:
- platform/win/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/win/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/win/css1/text_properties/letter_spacing-expected.txt:
- platform/win/css1/text_properties/line_height-expected.txt:
- platform/win/css1/text_properties/text_align-expected.txt:
- platform/win/css1/text_properties/text_decoration-expected.txt:
- platform/win/css1/text_properties/text_indent-expected.txt:
- platform/win/css1/text_properties/text_transform-expected.txt:
- platform/win/css1/text_properties/vertical_align-expected.txt:
- platform/win/css1/text_properties/word_spacing-expected.txt:
- platform/win/css1/units/color_units-expected.txt:
- platform/win/css1/units/length_units-expected.txt:
- platform/win/css1/units/percentage_units-expected.txt:
- platform/win/css1/units/urls-expected.txt:
- platform/win/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/win/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/win/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/win/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/win/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/win/css2.1/20110323/inline-table-001-expected.txt:
- platform/win/css2.1/20110323/inline-table-002a-expected.txt:
- platform/win/css2.1/20110323/inline-table-003-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/win/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/win/css2.1/20110323/table-caption-001-expected.txt:
- platform/win/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/win/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/win/css2.1/20110323/table-height-algorithm-023-expected.txt:
- platform/win/css2.1/20110323/table-height-algorithm-024-expected.txt:
- platform/win/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/win/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/win/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/win/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/win/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/win/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
- platform/win/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
- platform/win/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/win/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
- platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
- platform/win/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
- platform/win/css2.1/t0805-c5522-brdr-02-e-expected.txt:
- platform/win/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/win/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
- platform/win/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-015-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-016-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-023-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-024-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-035-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-036-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-037-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-038-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-045-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-046-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-047-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-048-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-049-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-050-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-055-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-056-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-091-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-092-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-099-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-100-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-103-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-104-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-105-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-106-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-107-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-108-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-109-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-110-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-111-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-112-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-113-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-114-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-123-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-124-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-139-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-140-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-149-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-150-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-155-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-156-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-159-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-160-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-165-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-166-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-177-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-178-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-179-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-180-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-181-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-189-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-190-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-191-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-192-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-193-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-194-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-195-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-196-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-205-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-206-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-207-expected.txt:
- platform/win/css2.1/tables/table-anonymous-objects-208-expected.txt:
- platform/win/css3/css3-modsel-33-expected.txt:
- platform/win/css3/flexbox/flexbox-baseline-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-18-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-18b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-28-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-28b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-32-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-43-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-43b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-44-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-44b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-74-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-74b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-78-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-78b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-18-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-18b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-28-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-28b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-32-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-43-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-43b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-44-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-44b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-74-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-74b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-78-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-78b-expected.txt:
- platform/win/editing/deleting/4922367-expected.txt:
- platform/win/editing/deleting/5099303-expected.txt:
- platform/win/editing/deleting/5126166-expected.txt:
- platform/win/editing/deleting/5144139-2-expected.txt:
- platform/win/editing/deleting/5206311-1-expected.txt:
- platform/win/editing/deleting/5433862-2-expected.txt:
- platform/win/editing/deleting/5483370-expected.txt:
- platform/win/editing/deleting/delete-to-select-table-expected.txt:
- platform/win/editing/deleting/table-cells-expected.txt:
- platform/win/editing/execCommand/5481523-expected.txt:
- platform/win/editing/inserting/5058163-1-expected.txt:
- platform/win/editing/inserting/insert-paragraph-01-expected.txt:
- platform/win/editing/inserting/insert-paragraph-02-expected.txt:
- platform/win/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/win/editing/inserting/paragraph-separator-in-table-2-expected.txt:
- platform/win/editing/style/5017613-1-expected.txt:
- platform/win/editing/style/5017613-2-expected.txt:
- platform/win/editing/style/apple-style-editable-mix-expected.txt:
- platform/win/editing/style/table-selection-expected.txt:
- platform/win/editing/unsupported-content/table-type-after-expected.txt:
- platform/win/editing/unsupported-content/table-type-before-expected.txt:
- platform/win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
- platform/win/fast/block/basic/016-expected.txt:
- platform/win/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/win/fast/block/float/011-expected.txt:
- platform/win/fast/block/float/015-expected.txt:
- platform/win/fast/block/margin-collapse/001-expected.txt:
- platform/win/fast/block/margin-collapse/005-expected.txt:
- platform/win/fast/block/margin-collapse/006-expected.txt:
- platform/win/fast/block/margin-collapse/010-expected.txt:
- platform/win/fast/block/margin-collapse/011-expected.txt:
- platform/win/fast/block/margin-collapse/012-expected.txt:
- platform/win/fast/block/margin-collapse/015-expected.txt:
- platform/win/fast/block/margin-collapse/016-expected.txt:
- platform/win/fast/block/margin-collapse/017-expected.txt:
- platform/win/fast/block/margin-collapse/018-expected.txt:
- platform/win/fast/block/margin-collapse/019-expected.txt:
- platform/win/fast/block/margin-collapse/020-expected.txt:
- platform/win/fast/block/margin-collapse/022-expected.txt:
- platform/win/fast/block/margin-collapse/025-expected.txt:
- platform/win/fast/block/margin-collapse/032-expected.txt:
- platform/win/fast/block/margin-collapse/033-expected.txt:
- platform/win/fast/block/margin-collapse/034-expected.txt:
- platform/win/fast/block/margin-collapse/041-expected.txt:
- platform/win/fast/block/margin-collapse/042-expected.txt:
- platform/win/fast/block/margin-collapse/055-expected.txt:
- platform/win/fast/block/margin-collapse/056-expected.txt:
- platform/win/fast/block/margin-collapse/057-expected.txt:
- platform/win/fast/block/margin-collapse/058-expected.txt:
- platform/win/fast/block/margin-collapse/059-expected.txt:
- platform/win/fast/block/margin-collapse/104-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/win/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/win/fast/block/positioning/053-expected.txt:
- platform/win/fast/block/positioning/negative-right-pos-expected.txt:
- platform/win/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/win/fast/borders/bidi-009a-expected.txt:
- platform/win/fast/borders/border-antialiasing-expected.txt:
- platform/win/fast/borders/border-radius-different-width-001-expected.txt:
- platform/win/fast/borders/table-borders-expected.txt:
- platform/win/fast/box-shadow/basic-shadows-expected.txt:
- platform/win/fast/css-generated-content/015-expected.txt:
- platform/win/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/win/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/win/fast/css-generated-content/inline-display-types-expected.txt:
- platform/win/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/win/fast/css-generated-content/table-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-cell-before-content-expected.txt:
- platform/win/fast/css-generated-content/table-parts-before-and-after-expected.txt:
- platform/win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-row-before-after-expected.txt:
- platform/win/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/win/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
- platform/win/fast/css-generated-content/table-with-before-expected.txt:
- platform/win/fast/css/003-expected.txt:
- platform/win/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/win/fast/css/acid2-expected.txt:
- platform/win/fast/css/acid2-pixel-expected.txt:
- platform/win/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/win/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/win/fast/css/caption-width-absolute-position-expected.txt:
- platform/win/fast/css/caption-width-absolute-position-offset-top-expected.txt:
- platform/win/fast/css/caption-width-fixed-position-expected.txt:
- platform/win/fast/css/caption-width-fixed-position-offset-top-expected.txt:
- platform/win/fast/css/caption-width-relative-position-expected.txt:
- platform/win/fast/css/caption-width-relative-position-offset-top-expected.txt:
- platform/win/fast/css/css3-nth-child-expected.txt:
- platform/win/fast/css/first-letter-float-expected.txt:
- platform/win/fast/css/focus-ring-detached-expected.txt:
- platform/win/fast/css/focus-ring-multiline-expected.txt:
- platform/win/fast/css/h1-in-section-elements-expected.txt:
- platform/win/fast/css/image-rendering-expected.txt:
- platform/win/fast/css/layerZOrderCrash-expected.txt:
- platform/win/fast/css/min-width-with-spanned-cell-expected.txt:
- platform/win/fast/css/percentage-non-integer-expected.txt:
- platform/win/fast/css/table-text-align-quirk-expected.txt:
- platform/win/fast/css/table-text-align-strict-expected.txt:
- platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/win/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/win/fast/dom/row-inner-text-expected.txt:
- platform/win/fast/dynamic/001-expected.txt:
- platform/win/fast/dynamic/007-expected.txt:
- platform/win/fast/dynamic/014-expected.txt:
- platform/win/fast/dynamic/015-expected.txt:
- platform/win/fast/dynamic/containing-block-change-expected.txt:
- platform/win/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
- platform/win/fast/dynamic/float-withdrawal-expected.txt:
- platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/win/fast/dynamic/subtree-table-cell-height-expected.txt:
- 10:07 AM Changeset in webkit [195751] by
-
- 3 edits in branches/safari-601-branch/Source/WebCore/html
Fix failing fast/picture tests.
- 10:00 AM Changeset in webkit [195750] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merge r191322. rdar://problem/24190923
- 9:59 AM Changeset in webkit [195749] by
-
- 1 edit1 add in branches/safari-601-branch/LayoutTests
Merge r193931. rdar://problem/24190799
- 9:59 AM Changeset in webkit [195748] by
-
- 3 edits in branches/safari-601-branch/LayoutTests
Merge r194237. rdar://problem/24268438
- 9:46 AM Changeset in webkit [195747] by
-
- 1 edit in branches/safari-601-branch/LayoutTests/css3/font-feature-settings-parsing.html
Fix Font Features test failures.
- 9:44 AM Changeset in webkit [195746] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r195742.
Broke EWS
Reverted changeset:
"[webkitdirs] Clarify logic behind is{PortName} functions."
https://bugs.webkit.org/show_bug.cgi?id=153554
http://trac.webkit.org/changeset/195742
- 9:33 AM Changeset in webkit [195745] by
-
- 7 edits2 adds in trunk
[SVG] Add support for 'lighter' operator in feComposite
https://bugs.webkit.org/show_bug.cgi?id=141376
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2016-01-28
Reviewed by Darin Adler.
Source/WebCore:
Added new cases where needed to support the lighter (aka 'plus')
Porter Duff operator in SVG Filter Effects.
https://www.w3.org/TR/filter-effects/#valdef-operator-lighter
Note that in the specification, no constant was added to the IDL for
the lighter operator.
Test: svg/filters/feCompositeOpaque.html
svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
Add case to support lighter.
(WebCore::operator<<):
Add case to support lighter for text stream operations.
- platform/graphics/filters/FEComposite.h: Add case for lighter to CompositeOperationType enum.
- svg/SVGFECompositeElement.h:
(WebCore::SVGIDLEnumLimits<CompositeOperationType>::highestExposedEnumValue):
Higest exposed value is arithmetic - do not expose lighter.
(WebCore::SVGPropertyTraits<CompositeOperationType>::highestEnumValue):
Highest possible value is now lighter.
(WebCore::SVGPropertyTraits<CompositeOperationType>::toString):
Add case to support lighter.
(WebCore::SVGPropertyTraits<CompositeOperationType>::fromString):
Add case to support lighter.
LayoutTests:
Add case to support lighter to DOM manipulation test for feComposite.
Add a new reftest that tests lighter case and supercedes older
pixel test for other modes.
- svg/dom/script-tests/SVGAnimatedEnumeration-SVGFECompositeElement.js: Test DOM read/write of SVGFEComposite operator property with new lighter mode.
- svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt:
- svg/filters/feCompositeOpaque.html: Added. A reftest that supersedes svg/filters/feComposite.svg That test used opacity 0.5 which resulted in differing colors across platforms. This makes it very hard to maintain the references but it's probably still useful as a regression test. This new test uses solid colors which result in consistency across platforms and allow a reftest to be used.
- svg/filters/feCompositeOpaque-expected.html: Added.
- 9:30 AM Changeset in webkit [195744] by
-
- 2 edits in trunk/Source/JavaScriptCore
LowerToAir::preferRightForResult() should resolve use count ties by selecting the child that is closest in an idom walk
https://bugs.webkit.org/show_bug.cgi?id=153583
Reviewed by Benjamin Poulain.
This undoes the AsmBench/n-body regression in r195654 while preserving that revision's
Kraken progression.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::LowerToAir):
(JSC::B3::Air::LowerToAir::preferRightForResult):
- 9:26 AM Changeset in webkit [195743] by
-
- 74 edits7 adds in trunk
Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
https://bugs.webkit.org/show_bug.cgi?id=153411
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: fast/media/media-query-non-ASCII-case-folding.html
fast/dom/HTMLAnchorElement/anchor-non-ASCII-case-folding.html
fast/xpath/xpath-non-ASCII-case-folding.html
No tests included that cover the minor behavior changes in Document::setDomain,
CSPSource::schemeMatches, CSPSource::hostMatches, OriginAccessEntry::operator==,
UserContentURLPattern::matches, UserContentURLPattern::matchesHost,
ContentFilterUnblockHandler::canHandleRequest. Would like to add tests for those
if possible, but it seems clear all are progressions.
For background on why this is the right thing to do in almost every case:
- MIME types are all ASCII and not case sensitive (details in RFC 2045) <http://tools.ietf.org/html/rfc2045>
- case insensitive comparisons in HTML are all "ASCII case-insensitive" https://www.w3.org/TR/html/infrastructure.html#ascii-case-insensitive
- same for CSS
- Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::denyBasedOnTableName): Use equalIgnoringASCIICase.
No change in behavior since the string we are comparing with is always
"WebKitDatabaseInfoTable" in practice.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::siblingWithAriaRole): Changed argument type to take a const char*,
added some FIXMEs and use equalIgnoringCase. No change in behavior since the
strings we are comparing with are "menu" and "menuitem".
(WebCore::AccessibilityNodeObject::menuElementForMenuButton): Updated to pass
arguments in reverse order.
(WebCore::AccessibilityNodeObject::menuItemElementForMenu): Ditto.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue): Use equalIgnoringASCIICase.
No change in behavior because the property names are all ASCII constants.
- css/CSSParserValues.h: Removed unused equalIgnoringCase function.
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::mediaTypeMatch): Use equalIgnoringASCIICase.
Changes behavior: No non-ASCII case folding when matching media types.
Covered by new test.
(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Use equalIgnoringASCIICase.
No change in behavior since the only string this is ever called with is "print".
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::hasFileOfType): Use equalIgnoringASCIICase.
No change in behavior because local files will not have content types with
non-ASCII characters in them. In the extremely unlikely case that this is incorrect,
the change in behavior is a progression.
- dom/Document.cpp:
(WebCore::Document::setDomain): Use equalIgnoringASCIICase.
Changes behavior: Domains considered equal because of non-ASCII case folding
would get through without an error before, and now will properly throw an exception.
- dom/Element.cpp:
(WebCore::isStyleAttribute): Refactored into a helper function. Use
equalLettersIgnoringASCIICase. No change in behavior.
(WebCore::Element::synchronizeAttribute): Use isStyleAttribute.
- dom/TreeScope.cpp:
(WebCore::TreeScope::findAnchor): Use equalIgnoringASCIICase.
Changes behavior: Could go to an anchor and it would be considered a match because
of non-ASCII case folding. Covered by new test.
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::appendFormData): Use equalIgnoringASCIICase.
No change in behavior: comparing with an ASCII literal.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension): Ditto.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension): Ditto.
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule): Use equalLettersIgnoringASCIICase and
StringView to avoid needing a special ruleEqualIgnoringCase function.
No change in behavior.
- inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::matchesElement): Use equalIgnoringASCIICase.
Changes behavior, but it's an inspector UI thing, not a web behavior thing,
so I don't think a new regression test is needed.
- loader/HistoryController.cpp:
(WebCore::HistoryController::currentItemShouldBeReplaced): Use
equalIgnoringASCIICase. No change in behavior because we are comparing
with "about:blank".
- loader/SubframeLoader.cpp:
(WebCore::findPluginMIMETypeFromURL): Use equalIgnoringASCIICase.
No change in behavior unless a plug-in claims an extension with non-ASCII
characters. I don't think a new regression test is needed.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::shouldLoadResourceFromApplicationCache):
Use equalIgnoringASCIICase. No change in behavior because both strings are
protocols from URLs and we don't parse non-ASCII characters into protocol strings;
non-ASCII are already encoding as punycode.
- loader/appcache/ManifestParser.cpp:
(WebCore::parseManifest): Ditto.
- page/ContentSecurityPolicy.cpp:
(WebCore::isExperimentalDirectiveName): Added. Used by isDirectiveName.
Uses equalLettersIgnoringASCIICase. No change in behavior.
(WebCore::isDirectiveName): Use equalLettersIgnoringASCIICase.
No change in behavior.
(WebCore::isSourceListNone): Use equalLettersIgnoringASCIICase. No
change in behavior.
(WebCore::CSPSource::schemeMatches): Use equalLettersIgnoringASCIICase
and equalIgnoringASCIICase. It's all about comparing URL protocols. The
old code might have done something strange if someone specified a protocol
with a non-ASCII character in it.
(WebCore::CSPSource::hostMatches): Use equalIgnoringASCIICase.
(WebCore::CSPSourceList::parseSource): Use equalLettersIgnoringASCIICase.
No change in behavior.
(WebCore::CSPDirectiveList::checkSourceAndReportViolation): Tweaked code
to do less unnecessary String allocation.
(WebCore::CSPDirectiveList::parseReflectedXSS): Use
equalLettersIgnoringASCIICase. No change in behavior.
(WebCore::CSPDirectiveList::addDirective): Ditto.
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective): Use
equalLettersIgnoringASCIICase and remove unneeded global constant strings.
No change in behavior.
(WebCore::ContentSecurityPolicy::reportDirectiveAsSourceExpression):
Tweak code to eliminate unneeded local.
(WebCore::ContentSecurityPolicy::reportDuplicateDirective): Ditto.
(WebCore::ContentSecurityPolicy::reportInvalidSourceExpression): Use
equalLettersIgnoringASCIICase. No change in behavior.
- page/OriginAccessEntry.h:
(WebCore::operator==): Use equalLettersIgnoringASCIICase.
- page/Performance.cpp:
(WebCore::Performance::webkitGetEntriesByName): Use equalLettersIgnoringASCIICase.
No change in behavior.
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matches): Use equalIgnoringASCIICase to match
schemes.
(WebCore::UserContentURLPattern::matchesHost): Use equalIgnoringASCIICase to
match host names.
- platform/URL.cpp:
(WebCore::URL::init): Use equalIgnoringASCIICase, and also use StringView to
avoid having to allocate a second string just for comparison purposes. Should be
better for efficiency with no change in behavior.
- platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
(WebCore::ContentFilterUnblockHandler::canHandleRequest): Use equalIgnoringASCIICase
to compare hosts.
- platform/efl/PlatformSpeechSynthesisProviderEfl.cpp:
(WebCore::PlatformSpeechSynthesisProviderEfl::voiceName): Use StringView and
equalIgnoringASCIICase to compare language tags. No test needed because there are
no language tags with non-ASCII characters in them.
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::operator==): Changed to use the equal
function from CaseFoldingHash. In a subsequent patch we will change this to be
ASCIICaseFoldingHash since font names don't need to compare non-ASCII characters
in a case folding manner, but for now preserve behavior.
(WebCore::alternateFamilyName): Use equalLettersIgnoringASCIICase to avoid having
to use a special familyNameEqualIgnoringCase function. This does mean there will
be a null check and a length check that wasn't there before, but the actual
comparison function will be tighter. Guessing it will be a wash. Also improved
the comments and sorted the Windows cases in with the others. No behavior change.
- platform/graphics/FontCascade.cpp:
(WebCore::operator==): Changed to use the equal function from CaseFoldingHash.
Same rationale as above in FontPlatformDataCacheKey.
- platform/graphics/FontDescription.cpp:
(WebCore::FontCascadeDescription::familiesEqualForTextAutoSizing): Use
equalIgnoringASCIICase to compare font family names. Only possible change in
behavior would be if actual fonts with non-ASCII names but that were specified
with different case in style sheets. Highly unlikely this exists.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType): Use equalLettersIgnoringASCIICase.
No change in behavior.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::keySystemIsSupported): Ditto.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::isCommonlyUsedGenericFamily): Added.
(WebCore::FontCache::createFontPlatformData): Moved code into the
isCommonlyUsedGenericFamily helper and used equalIgnoringASCIICase.
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Use
equalLettersIgnoringASCIICase. No change in behavior.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::adjustedGDIFontWeight): Ditto.
(WebCore::FontCache::createFontPlatformData): Ditto.
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::supportsFormat): Ditto.
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]): Use equalIgnoringASCIICase to
compare languages. No change in behavior because languages have all-ASCII names.
- platform/network/CacheValidation.cpp:
(WebCore::shouldUpdateHeaderAfterRevalidation): Use equalIgnoringASCIICase.
No change in behavior since it's a fixed list of all ASCII headers.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader): Ditto.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest): Use equalIgnoringASCIICase.
No change in behavior because HTTP methods are all ASCII letters.
- platform/text/mac/LocaleMac.mm:
(WebCore::determineLocale): Use equalIgnoringASCIICase. No change in behavior
because locale languages identifiers are all ASCII.
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal): Ditto.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable):
Use equalIgnoringASCIICase. No change in behavior because Arabic form attribute
values are all ASCII.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod): Use equalIgnoringASCIICase.
No change in behavior because these are all fixed known ASCII HTTP method names.
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunLang::evaluate): Use equalIgnoringASCIICase. Changes behavior
if specifying a non-ASCII character. Covered by new test.
- xml/XPathStep.cpp:
(WebCore::XPath::nodeMatchesBasicTest): Use equalIgnoringASCIICase. Changes
behavior if an element local name or XPath predicate has a non-ASCII character.
Covered by new test.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(parameterValue): Use equalIgnoringASCIICase. No behavior change because the
only name we ever search for with this is "pluginspage".
Source/WebKit/win:
- Plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::MIMETypeForExtension): Use equalIgnoringASCIICase to compare
file extensions.
- Plugins/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories): Use equalLettersIgnoringASCIICase
to compare filenames.
- Plugins/PluginPackageWin.cpp:
(WebCore::PluginPackage::isPluginBlacklisted): Use equalLettersIgnoringASCIICase to
compare DLL filenames.
- Plugins/PluginStream.cpp:
(WebCore::PluginStream::destroyStream): Use equalLettersIgnoringASCIICase to check HTTP method.
- Plugins/PluginView.cpp:
(WebCore::PluginView::setParameters): Use equalLettersIgnoringASCIICase to check
plug-in parameter name.
- WebView.cpp:
(WebView::canHandleRequest): Use URL::protocolIs instead of equalIgnoringCase.
Source/WebKit2:
- Shared/API/c/WKString.cpp:
(WKStringIsEqualToUTF8CStringIgnoringCase): Use equalIgnoringASCIICase.
This is a change in behavior for callers who passed non-ASCII letters to
this function and expected case insensitive comparison.
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::streamDidReceiveResponse): Use equalIgnoringASCIICase.
No change in behavior because this is just checking a fixed ASCII MIME type.
(WebKit::PDFPlugin::manualStreamDidReceiveResponse): Ditto.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::streamDidReceiveResponse): Ditto.
(WebKit::PDFPlugin::manualStreamDidReceiveResponse): Ditto.
Source/WTF:
- wtf/text/AtomicString.h: Removed equalIgnoringCase.
Added some overloads for equalIgnoringASCIICase and moved the function bodies to
bottom of the file to make the function declarations easier to read and scan through.
I plan to do this for more of the functions in this class in the future.
- wtf/text/StringCommon.h: Added overloads for equalIgnoringASCIICase,
equalPossiblyIgnoringASCIICase, and a helper named equalIgnoringASCIICaseCommon.
Added an overload for equalLettersIgnoringASCIICase.
- wtf/text/StringImpl.cpp:
(WTF::equalIgnoringCase): Made the few remaining versions of this function private
to this file. Once we get done moving every client that should be using ASCII case
instead to new functions, these will almost certainly be deleted.
(WTF::equalIgnoringASCIICaseNonNull): Tweaked implementation a tiny bit.
- wtf/text/StringImpl.h: Sorted forward declarations at the top of the file.
Fixed some small formatting mistakes. Removed equalIgnoringCase, but left
equalIgnoringCaseNonNull behind for use by CaseFoldingHash until it is replaced
with ASCIICaseFoldingHash. Improved equalIgnoringASCIICase implementation.
Removed unneeded using for equalIgnoringASCIICase now that StringCommon.h takes
care of it.
- wtf/text/StringView.cpp:
(WTF::equalIgnoringASCIICase): Deleted. We no longer pass in the length for this,
so the arguments have changed and the implementation is also now in ASCIICommon.h
so it's an inline in the header file.
- wtf/text/StringView.h: Added an overload of equalIgnoringASCIICase,while
removing another.
- wtf/text/WTFString.h: Removed some unneeded forward delcarations. Fixed formatting
of the type name NSString *. Improved some comments. Removed equalIgnoringCase.
Separated declaration from implementation in a few cases to start making the
function declarations easier to read and scan through. I plan to do more in the future.
Tools:
- Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
have removed the function instead.
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
added overloads for const char*.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/cocoa/CrashReporterInfo.mm:
(WTR::testPathFromURL): Ditto.
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-non-ASCII-case-folding-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-non-ASCII-case-folding.html: Added.
- fast/dom/HTMLAnchorElement/resources/iframe-with-non-ASCII-matching-anchor.html: Added.
- fast/media/media-query-non-ASCII-case-folding-expected.txt: Added.
- fast/media/media-query-non-ASCII-case-folding.html: Added.
- fast/xpath/xpath-non-ASCII-case-folding-expected.txt: Added.
- fast/xpath/xpath-non-ASCII-case-folding.html: Added.
- 9:18 AM Changeset in webkit [195742] by
-
- 2 edits in trunk/Tools
[webkitdirs] Clarify logic behind is{PortName} functions.
https://bugs.webkit.org/show_bug.cgi?id=153554
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-28
Reviewed by Darin Adler.
- Scripts/webkitdirs.pm:
(determinePortName): Added new function which decides which port are
we building based on command line switches and platform defaults.
(portName): Added getter for determined $portName.
(isEfl): Modified to use portName().
(isGtk): Ditto.
(isWinCairo): Ditto.
(isAppleMacWebKit): Ditto.
(isAppleWinWebKit): Ditto.
(isIOSWebKit): Ditto.
(cmakeBasedPortName): Code replaced with portName() call.
(determineIsEfl): Deleted.
(determineIsGtk): Deleted.
(determineIsWinCairo): Deleted.
- 8:56 AM Changeset in webkit [195741] by
-
- 6 edits26 adds in branches/safari-601-branch
Merge r195710. rdar://problem/24337780
- 8:31 AM Changeset in webkit [195740] by
-
- 1833 edits2 adds in trunk
Unexpected content wrapping at http://email.osh.com/H/2/v100000152474feb8ec7c1a1f4bbe5c7c0/HTML
https://bugs.webkit.org/show_bug.cgi?id=153430
Reviewed by Simon Fraser.
Ensure that min/max preferred and computed widths never shrink while converting LayoutUnit to float and back.
Source/WebCore:
Test: fast/table/fixed-size-table-with-fixed-size-content.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths): Deleted.
LayoutTests:
- fast/table/fixed-size-table-with-fixed-size-content-expected.html: Added.
- fast/table/fixed-size-table-with-fixed-size-content.html: Added.
- platform/ios-simulator/css1/basic/containment-expected.txt:
- platform/ios-simulator/css1/basic/contextual_selectors-expected.txt:
- platform/ios-simulator/css1/basic/grouping-expected.txt:
- platform/ios-simulator/css1/basic/id_as_selector-expected.txt:
- platform/ios-simulator/css1/basic/inheritance-expected.txt:
- platform/ios-simulator/css1/box_properties/border-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_color-expected.txt:
- platform/ios-simulator/css1/box_properties/border_color_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_left_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_right_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_style-expected.txt:
- platform/ios-simulator/css1/box_properties/border_style_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_top_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/border_width-expected.txt:
- platform/ios-simulator/css1/box_properties/border_width_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/clear-expected.txt:
- platform/ios-simulator/css1/box_properties/clear_float-expected.txt:
- platform/ios-simulator/css1/box_properties/float-expected.txt:
- platform/ios-simulator/css1/box_properties/float_elements_in_series-expected.txt:
- platform/ios-simulator/css1/box_properties/float_margin-expected.txt:
- platform/ios-simulator/css1/box_properties/height-expected.txt:
- platform/ios-simulator/css1/box_properties/margin-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_bottom-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_left-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_left_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_right-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_right_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_top-expected.txt:
- platform/ios-simulator/css1/box_properties/margin_top_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_bottom-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_left-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_left_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_right-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_right_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_top-expected.txt:
- platform/ios-simulator/css1/box_properties/padding_top_inline-expected.txt:
- platform/ios-simulator/css1/box_properties/width-expected.txt:
- platform/ios-simulator/css1/cascade/cascade_order-expected.txt:
- platform/ios-simulator/css1/cascade/important-expected.txt:
- platform/ios-simulator/css1/classification/display-expected.txt:
- platform/ios-simulator/css1/classification/list_style-expected.txt:
- platform/ios-simulator/css1/classification/list_style_image-expected.txt:
- platform/ios-simulator/css1/classification/list_style_position-expected.txt:
- platform/ios-simulator/css1/classification/list_style_type-expected.txt:
- platform/ios-simulator/css1/classification/white_space-expected.txt:
- platform/ios-simulator/css1/color_and_background/background-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_attachment-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_color-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_image-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_position-expected.txt:
- platform/ios-simulator/css1/color_and_background/background_repeat-expected.txt:
- platform/ios-simulator/css1/color_and_background/color-expected.txt:
- platform/ios-simulator/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/ios-simulator/css1/font_properties/font-expected.txt:
- platform/ios-simulator/css1/font_properties/font_family-expected.txt:
- platform/ios-simulator/css1/font_properties/font_size-expected.txt:
- platform/ios-simulator/css1/font_properties/font_style-expected.txt:
- platform/ios-simulator/css1/font_properties/font_variant-expected.txt:
- platform/ios-simulator/css1/font_properties/font_weight-expected.txt:
- platform/ios-simulator/css1/formatting_model/canvas-expected.txt:
- platform/ios-simulator/css1/formatting_model/height_of_lines-expected.txt:
- platform/ios-simulator/css1/formatting_model/inline_elements-expected.txt:
- platform/ios-simulator/css1/formatting_model/replaced_elements-expected.txt:
- platform/ios-simulator/css1/formatting_model/vertical_formatting-expected.txt:
- platform/ios-simulator/css1/pseudo/anchor-expected.txt:
- platform/ios-simulator/css1/pseudo/firstletter-expected.txt:
- platform/ios-simulator/css1/pseudo/firstline-expected.txt:
- platform/ios-simulator/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/ios-simulator/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/ios-simulator/css1/text_properties/letter_spacing-expected.txt:
- platform/ios-simulator/css1/text_properties/line_height-expected.txt:
- platform/ios-simulator/css1/text_properties/text_align-expected.txt:
- platform/ios-simulator/css1/text_properties/text_decoration-expected.txt:
- platform/ios-simulator/css1/text_properties/text_indent-expected.txt:
- platform/ios-simulator/css1/text_properties/text_transform-expected.txt:
- platform/ios-simulator/css1/text_properties/vertical_align-expected.txt:
- platform/ios-simulator/css1/text_properties/word_spacing-expected.txt:
- platform/ios-simulator/css1/units/color_units-expected.txt:
- platform/ios-simulator/css1/units/length_units-expected.txt:
- platform/ios-simulator/css1/units/percentage_units-expected.txt:
- platform/ios-simulator/css1/units/urls-expected.txt:
- platform/ios-simulator/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/ios-simulator/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/ios-simulator/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/ios-simulator/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/ios-simulator/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/ios-simulator/css2.1/20110323/inline-table-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/inline-table-003-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/ios-simulator/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/ios-simulator/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/table-caption-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/ios-simulator/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/ios-simulator/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/ios-simulator/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/ios-simulator/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/ios-simulator/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/ios-simulator/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/ios-simulator/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-177-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-178-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-179-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-180-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-181-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-189-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-190-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-191-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-192-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-193-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-194-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-195-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-196-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-205-expected.txt:
- platform/ios-simulator/css2.1/tables/table-anonymous-objects-206-expected.txt:
- platform/ios-simulator/css3/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-18-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/ios-simulator/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/ios-simulator/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-18-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/ios-simulator/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/ios-simulator/editing/deleting/4922367-expected.txt:
- platform/ios-simulator/editing/deleting/5126166-expected.txt:
- platform/ios-simulator/editing/deleting/5206311-1-expected.txt:
- platform/ios-simulator/editing/deleting/5433862-2-expected.txt:
- platform/ios-simulator/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/ios-simulator/editing/selection/5057506-2-expected.txt:
- platform/ios-simulator/editing/selection/5057506-expected.txt:
- platform/ios-simulator/editing/selection/5131716-1-expected.txt:
- platform/ios-simulator/editing/selection/5131716-2-expected.txt:
- platform/ios-simulator/editing/selection/5131716-3-expected.txt:
- platform/ios-simulator/editing/selection/5131716-4-expected.txt:
- platform/ios-simulator/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/ios-simulator/fast/block/float/015-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/006-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/010-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/011-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/012-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/015-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/016-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/017-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/018-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/019-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/020-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/021-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/022-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/025-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/032-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/033-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/034-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/041-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/042-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/055-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/056-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/057-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/058-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/059-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/ios-simulator/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/ios-simulator/fast/block/positioning/negative-right-pos-expected.txt:
- platform/ios-simulator/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/ios-simulator/fast/borders/border-antialiasing-expected.txt:
- platform/ios-simulator/fast/borders/border-radius-different-width-001-expected.txt:
- platform/ios-simulator/fast/borders/table-borders-expected.txt:
- platform/ios-simulator/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/ios-simulator/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/ios-simulator/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/ios-simulator/fast/css-generated-content/table-with-before-expected.txt:
- platform/ios-simulator/fast/css/003-expected.txt:
- platform/ios-simulator/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/ios-simulator/fast/css/acid2-expected.txt:
- platform/ios-simulator/fast/css/acid2-pixel-expected.txt:
- platform/ios-simulator/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/ios-simulator/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/ios-simulator/fast/css/css3-nth-child-expected.txt:
- platform/ios-simulator/fast/css/focus-ring-detached-expected.txt:
- platform/ios-simulator/fast/css/focus-ring-multiline-expected.txt:
- platform/ios-simulator/fast/css/h1-in-section-elements-expected.txt:
- platform/ios-simulator/fast/css/percentage-non-integer-expected.txt:
- platform/ios-simulator/fast/css/table-text-align-quirk-expected.txt:
- platform/ios-simulator/fast/css/table-text-align-strict-expected.txt:
- platform/ios-simulator/fast/dom/34176-expected.txt:
- platform/ios-simulator/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/ios-simulator/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/ios-simulator/fast/dom/row-inner-text-expected.txt:
- platform/ios-simulator/fast/dynamic/001-expected.txt:
- platform/ios-simulator/fast/dynamic/containing-block-change-expected.txt:
- platform/ios-simulator/fast/dynamic/float-withdrawal-expected.txt:
- platform/ios-simulator/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/ios-simulator/fast/dynamic/subtree-table-cell-height-expected.txt:
- platform/ios-simulator/fast/forms/001-expected.txt:
- platform/ios-simulator/fast/forms/005-expected.txt:
- platform/ios-simulator/fast/forms/form-element-geometry-expected.txt:
- platform/ios-simulator/fast/forms/form-hides-table-expected.txt:
- platform/ios-simulator/fast/forms/formmove3-expected.txt:
- platform/ios-simulator/fast/forms/input-table-expected.txt:
- platform/ios-simulator/fast/forms/listbox-bidi-align-expected.txt:
- platform/ios-simulator/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/ios-simulator/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/ios-simulator/fast/html/details-writing-mode-expected.txt:
- platform/ios-simulator/fast/inline-block/001-expected.txt:
- platform/ios-simulator/fast/inline-block/overflow-clip-expected.txt:
- platform/ios-simulator/fast/invalid/012-expected.txt:
- platform/ios-simulator/fast/lists/004-expected.txt:
- platform/ios-simulator/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/ios-simulator/fast/multicol/table-vertical-align-expected.txt:
- platform/ios-simulator/fast/overflow/002-expected.txt:
- platform/ios-simulator/fast/overflow/overflow-rtl-expected.txt:
- platform/ios-simulator/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/ios-simulator/fast/overflow/table-overflow-float-expected.txt:
- platform/ios-simulator/fast/reflections/table-cell-expected.txt:
- platform/ios-simulator/fast/replaced/005-expected.txt:
- platform/ios-simulator/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/ios-simulator/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/ios-simulator/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-checkbox-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-image-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-menulist-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-radio-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-searchfield-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-textarea-expected.txt:
- platform/ios-simulator/fast/replaced/width100percent-textfield-expected.txt:
- platform/ios-simulator/fast/selectors/077-expected.txt:
- platform/ios-simulator/fast/selectors/077b-expected.txt:
- platform/ios-simulator/fast/table/002-expected.txt:
- platform/ios-simulator/fast/table/003-expected.txt:
- platform/ios-simulator/fast/table/005-expected.txt:
- platform/ios-simulator/fast/table/007-expected.txt:
- platform/ios-simulator/fast/table/008-expected.txt:
- platform/ios-simulator/fast/table/009-expected.txt:
- platform/ios-simulator/fast/table/012-expected.txt:
- platform/ios-simulator/fast/table/013-expected.txt:
- platform/ios-simulator/fast/table/021-expected.txt:
- platform/ios-simulator/fast/table/023-expected.txt:
- platform/ios-simulator/fast/table/028-expected.txt:
- platform/ios-simulator/fast/table/028-vertical-expected.txt:
- platform/ios-simulator/fast/table/029-expected.txt:
- platform/ios-simulator/fast/table/038-expected.txt:
- platform/ios-simulator/fast/table/038-vertical-expected.txt:
- platform/ios-simulator/fast/table/039-expected.txt:
- platform/ios-simulator/fast/table/040-expected.txt:
- platform/ios-simulator/fast/table/040-vertical-expected.txt:
- platform/ios-simulator/fast/table/100-percent-cell-width-expected.txt:
- platform/ios-simulator/fast/table/add-before-anonymous-child-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/001-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/002-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/003-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/ios-simulator/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/ios-simulator/fast/table/caption-relayout-expected.txt:
- platform/ios-simulator/fast/table/cell-absolute-child-expected.txt:
- platform/ios-simulator/fast/table/cell-width-auto-expected.txt:
- platform/ios-simulator/fast/table/colspanMinWidth-expected.txt:
- platform/ios-simulator/fast/table/dynamic-cellpadding-expected.txt:
- platform/ios-simulator/fast/table/edge-offsets-expected.txt:
- platform/ios-simulator/fast/table/empty-cells-expected.txt:
- platform/ios-simulator/fast/table/frame-and-rules-expected.txt:
- platform/ios-simulator/fast/table/giantRowspan-expected.txt:
- platform/ios-simulator/fast/table/growCellForImageQuirk-expected.txt:
- platform/ios-simulator/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/ios-simulator/fast/table/invisible-cell-background-expected.txt:
- platform/ios-simulator/fast/table/large-width-expected.txt:
- platform/ios-simulator/fast/table/max-width-integer-overflow-expected.txt:
- platform/ios-simulator/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/ios-simulator/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/ios-simulator/fast/table/nobr-expected.txt:
- platform/ios-simulator/fast/table/overflowHidden-expected.txt:
- platform/ios-simulator/fast/table/percent-heights-expected.txt:
- platform/ios-simulator/fast/table/percent-widths-stretch-expected.txt:
- platform/ios-simulator/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/ios-simulator/fast/table/relative-position-containment-expected.txt:
- platform/ios-simulator/fast/table/relative-position-offsets-expected.txt:
- platform/ios-simulator/fast/table/relative-position-stacking-expected.txt:
- platform/ios-simulator/fast/table/replaced-percent-height-expected.txt:
- platform/ios-simulator/fast/table/row-height-recalc-expected.txt:
- platform/ios-simulator/fast/table/rowspan-paint-order-expected.txt:
- platform/ios-simulator/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/ios-simulator/fast/table/spanOverlapRepaint-expected.txt:
- platform/ios-simulator/fast/table/stale-grid-crash-expected.txt:
- platform/ios-simulator/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/ios-simulator/fast/table/table-display-types-expected.txt:
- platform/ios-simulator/fast/table/table-display-types-strict-expected.txt:
- platform/ios-simulator/fast/table/table-display-types-vertical-expected.txt:
- platform/ios-simulator/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/ios-simulator/fast/table/table-row-outline-paint-expected.txt:
- platform/ios-simulator/fast/table/table-row-split2-expected.txt:
- platform/ios-simulator/fast/table/table-section-split2-expected.txt:
- platform/ios-simulator/fast/table/table-split-expected.txt:
- platform/ios-simulator/fast/table/table-split2-expected.txt:
- platform/ios-simulator/fast/text/basic/004-expected.txt:
- platform/ios-simulator/fast/text/basic/005-expected.txt:
- platform/ios-simulator/fast/text/emoji-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/ios-simulator/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/ios-simulator/fast/text/whitespace/002-expected.txt:
- platform/ios-simulator/fast/text/whitespace/003-expected.txt:
- platform/ios-simulator/fast/text/whitespace/004-expected.txt:
- platform/ios-simulator/fast/text/whitespace/005-expected.txt:
- platform/ios-simulator/fast/text/whitespace/010-expected.txt:
- platform/ios-simulator/fast/text/whitespace/011-expected.txt:
- platform/ios-simulator/fast/text/whitespace/015-expected.txt:
- platform/ios-simulator/fast/text/whitespace/016-expected.txt:
- platform/ios-simulator/fast/text/whitespace/025-expected.txt:
- platform/ios-simulator/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/ios-simulator/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/ios-simulator/http/tests/misc/acid2-expected.txt:
- platform/ios-simulator/http/tests/misc/acid2-pixel-expected.txt:
- platform/ios-simulator/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
- platform/ios-simulator/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10009-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug101201-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug101674-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10565-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug10633-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug106795-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug106816-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug113424-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1188-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12008-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug120107-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug120364-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1224-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12268-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12709-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1271-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1296-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1302-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug13169-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1318-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1430-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug14323-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1474-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug14929-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug15247-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug154780-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug15544-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug159108-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug15933-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug16012-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug16252-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug17138-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug17548-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug17587-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1800-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1802-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug1809-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug18440-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug18664-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug18955-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug19356-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug20804-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2123-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug215629-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22019-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug222336-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-2a-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug22513-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2296-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug23235-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug24200-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug25004-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug25074-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug25663-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2684-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug269566-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug277062-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2773-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2886-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug28933-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug29429-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2954-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug2997-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug30273-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3103-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3260-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug32841-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug33137-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug33855-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3454-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug3977-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4093-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug42187-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4385-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug44505-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4501-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4527-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug45350-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug45486-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4576-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug47432-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4803-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug4849-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug51727-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5188-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug52505-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug52506-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug53891-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5538-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug55789-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5797-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug5835-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug59354-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug60804-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug60807-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6184-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6304-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6404-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug647-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug6674-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug68998-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug72359-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug7342-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug7714-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug78162-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug86708-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug8950-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug92143-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug963-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug96334-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug97383-expected.txt:
- platform/ios-simulator/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/ios-simulator/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/ios-simulator/tables/mozilla/core/bloomberg-expected.txt:
- platform/ios-simulator/tables/mozilla/core/borders-expected.txt:
- platform/ios-simulator/tables/mozilla/core/cell_heights-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_span-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/ios-simulator/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/ios-simulator/tables/mozilla/core/margins-expected.txt:
- platform/ios-simulator/tables/mozilla/core/misc-expected.txt:
- platform/ios-simulator/tables/mozilla/core/nested1-expected.txt:
- platform/ios-simulator/tables/mozilla/core/one_row-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_frame-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_heights-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_rules-expected.txt:
- platform/ios-simulator/tables/mozilla/core/table_widths-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols1-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols2-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols3-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols4-expected.txt:
- platform/ios-simulator/tables/mozilla/dom/insertCols5-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_th_colspan-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla/other/cell_widths-expected.txt:
- platform/ios-simulator/tables/mozilla/other/ms-expected.txt:
- platform/ios-simulator/tables/mozilla/other/nested2-expected.txt:
- platform/ios-simulator/tables/mozilla/other/nestedTables-expected.txt:
- platform/ios-simulator/tables/mozilla/other/slashlogo-expected.txt:
- platform/ios-simulator/tables/mozilla/other/test3-expected.txt:
- platform/ios-simulator/tables/mozilla/other/test6-expected.txt:
- platform/ios-simulator/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/ios-simulator/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/compositing/contents-opaque/table-parts-expected.txt:
- platform/mac/css1/basic/containment-expected.txt:
- platform/mac/css1/basic/contextual_selectors-expected.txt:
- platform/mac/css1/basic/grouping-expected.txt:
- platform/mac/css1/basic/id_as_selector-expected.txt:
- platform/mac/css1/basic/inheritance-expected.txt:
- platform/mac/css1/box_properties/border-expected.txt:
- platform/mac/css1/box_properties/border_bottom-expected.txt:
- platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
- platform/mac/css1/box_properties/border_bottom_width-expected.txt:
- platform/mac/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_color-expected.txt:
- platform/mac/css1/box_properties/border_color_inline-expected.txt:
- platform/mac/css1/box_properties/border_inline-expected.txt:
- platform/mac/css1/box_properties/border_left-expected.txt:
- platform/mac/css1/box_properties/border_left_inline-expected.txt:
- platform/mac/css1/box_properties/border_left_width-expected.txt:
- platform/mac/css1/box_properties/border_left_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_right-expected.txt:
- platform/mac/css1/box_properties/border_right_inline-expected.txt:
- platform/mac/css1/box_properties/border_right_width-expected.txt:
- platform/mac/css1/box_properties/border_right_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_style-expected.txt:
- platform/mac/css1/box_properties/border_style_inline-expected.txt:
- platform/mac/css1/box_properties/border_top-expected.txt:
- platform/mac/css1/box_properties/border_top_inline-expected.txt:
- platform/mac/css1/box_properties/border_top_width-expected.txt:
- platform/mac/css1/box_properties/border_top_width_inline-expected.txt:
- platform/mac/css1/box_properties/border_width-expected.txt:
- platform/mac/css1/box_properties/border_width_inline-expected.txt:
- platform/mac/css1/box_properties/clear-expected.txt:
- platform/mac/css1/box_properties/clear_float-expected.txt:
- platform/mac/css1/box_properties/float-expected.txt:
- platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
- platform/mac/css1/box_properties/float_margin-expected.txt:
- platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
- platform/mac/css1/box_properties/height-expected.txt:
- platform/mac/css1/box_properties/margin-expected.txt:
- platform/mac/css1/box_properties/margin_bottom-expected.txt:
- platform/mac/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/mac/css1/box_properties/margin_inline-expected.txt:
- platform/mac/css1/box_properties/margin_left-expected.txt:
- platform/mac/css1/box_properties/margin_left_inline-expected.txt:
- platform/mac/css1/box_properties/margin_right-expected.txt:
- platform/mac/css1/box_properties/margin_right_inline-expected.txt:
- platform/mac/css1/box_properties/margin_top-expected.txt:
- platform/mac/css1/box_properties/margin_top_inline-expected.txt:
- platform/mac/css1/box_properties/padding-expected.txt:
- platform/mac/css1/box_properties/padding_bottom-expected.txt:
- platform/mac/css1/box_properties/padding_bottom_inline-expected.txt:
- platform/mac/css1/box_properties/padding_inline-expected.txt:
- platform/mac/css1/box_properties/padding_left-expected.txt:
- platform/mac/css1/box_properties/padding_left_inline-expected.txt:
- platform/mac/css1/box_properties/padding_right-expected.txt:
- platform/mac/css1/box_properties/padding_right_inline-expected.txt:
- platform/mac/css1/box_properties/padding_top-expected.txt:
- platform/mac/css1/box_properties/padding_top_inline-expected.txt:
- platform/mac/css1/box_properties/width-expected.txt:
- platform/mac/css1/cascade/cascade_order-expected.txt:
- platform/mac/css1/cascade/important-expected.txt:
- platform/mac/css1/classification/display-expected.txt:
- platform/mac/css1/classification/list_style-expected.txt:
- platform/mac/css1/classification/list_style_image-expected.txt:
- platform/mac/css1/classification/list_style_position-expected.txt:
- platform/mac/css1/classification/list_style_type-expected.txt:
- platform/mac/css1/classification/white_space-expected.txt:
- platform/mac/css1/color_and_background/background-expected.txt:
- platform/mac/css1/color_and_background/background_attachment-expected.txt:
- platform/mac/css1/color_and_background/background_color-expected.txt:
- platform/mac/css1/color_and_background/background_image-expected.txt:
- platform/mac/css1/color_and_background/background_position-expected.txt:
- platform/mac/css1/color_and_background/background_repeat-expected.txt:
- platform/mac/css1/color_and_background/color-expected.txt:
- platform/mac/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/mac/css1/font_properties/font-expected.txt:
- platform/mac/css1/font_properties/font_family-expected.txt:
- platform/mac/css1/font_properties/font_size-expected.txt:
- platform/mac/css1/font_properties/font_style-expected.txt:
- platform/mac/css1/font_properties/font_variant-expected.txt:
- platform/mac/css1/font_properties/font_weight-expected.txt:
- platform/mac/css1/formatting_model/canvas-expected.txt:
- platform/mac/css1/formatting_model/floating_elements-expected.txt:
- platform/mac/css1/formatting_model/height_of_lines-expected.txt:
- platform/mac/css1/formatting_model/inline_elements-expected.txt:
- platform/mac/css1/formatting_model/replaced_elements-expected.txt:
- platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/mac/css1/pseudo/anchor-expected.txt:
- platform/mac/css1/pseudo/firstletter-expected.txt:
- platform/mac/css1/pseudo/firstline-expected.txt:
- platform/mac/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/mac/css1/text_properties/letter_spacing-expected.txt:
- platform/mac/css1/text_properties/line_height-expected.txt:
- platform/mac/css1/text_properties/text_align-expected.txt:
- platform/mac/css1/text_properties/text_decoration-expected.txt:
- platform/mac/css1/text_properties/text_indent-expected.txt:
- platform/mac/css1/text_properties/text_transform-expected.txt:
- platform/mac/css1/text_properties/vertical_align-expected.txt:
- platform/mac/css1/text_properties/word_spacing-expected.txt:
- platform/mac/css1/units/color_units-expected.txt:
- platform/mac/css1/units/length_units-expected.txt:
- platform/mac/css1/units/percentage_units-expected.txt:
- platform/mac/css1/units/urls-expected.txt:
- platform/mac/css2.1/20110323/border-collapse-offset-002-expected.txt:
- platform/mac/css2.1/20110323/border-conflict-style-079-expected.txt:
- platform/mac/css2.1/20110323/border-conflict-style-088-expected.txt:
- platform/mac/css2.1/20110323/dynamic-top-change-002-expected.txt:
- platform/mac/css2.1/20110323/dynamic-top-change-003-expected.txt:
- platform/mac/css2.1/20110323/inline-table-001-expected.txt:
- platform/mac/css2.1/20110323/inline-table-003-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-001-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-002-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-003-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-004-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-005-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-006-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-007-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-013-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-014-expected.txt:
- platform/mac/css2.1/20110323/margin-applies-to-015-expected.txt:
- platform/mac/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
- platform/mac/css2.1/20110323/table-caption-001-expected.txt:
- platform/mac/css2.1/20110323/table-caption-optional-001-expected.txt:
- platform/mac/css2.1/20110323/table-caption-optional-002-expected.txt:
- platform/mac/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
- platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
- platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/mac/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
- platform/mac/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
- platform/mac/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
- platform/mac/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
- platform/mac/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-177-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-178-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-179-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-180-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-181-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-189-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-190-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-191-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-192-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-193-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-194-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-195-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-196-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-205-expected.txt:
- platform/mac/css2.1/tables/table-anonymous-objects-206-expected.txt:
- platform/mac/css3/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-29-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-29b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-73-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-73b-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-77-expected.txt:
- platform/mac/css3/selectors3/html/css3-modsel-77b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
- platform/mac/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-29-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-29b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-33-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-73-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-73b-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-77-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-77b-expected.txt:
- platform/mac/editing/deleting/4922367-expected.txt:
- platform/mac/editing/deleting/5126166-expected.txt:
- platform/mac/editing/deleting/5144139-2-expected.txt:
- platform/mac/editing/deleting/5206311-1-expected.txt:
- platform/mac/editing/deleting/5433862-2-expected.txt:
- platform/mac/editing/inserting/paragraph-separator-in-table-1-expected.txt:
- platform/mac/editing/pasteboard/innerText-inline-table-expected.txt:
- platform/mac/editing/selection/3690703-2-expected.txt:
- platform/mac/editing/selection/3690703-expected.txt:
- platform/mac/editing/selection/3690719-expected.txt:
- platform/mac/editing/selection/5057506-2-expected.txt:
- platform/mac/editing/selection/5057506-expected.txt:
- platform/mac/editing/selection/5131716-1-expected.txt:
- platform/mac/editing/selection/5131716-2-expected.txt:
- platform/mac/editing/selection/5131716-3-expected.txt:
- platform/mac/editing/selection/5131716-4-expected.txt:
- platform/mac/editing/selection/move-by-line-001-expected.txt:
- platform/mac/editing/selection/select-all-004-expected.txt:
- platform/mac/editing/unsupported-content/table-type-after-expected.txt:
- platform/mac/editing/unsupported-content/table-type-before-expected.txt:
- platform/mac/fast/block/basic/016-expected.txt:
- platform/mac/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
- platform/mac/fast/block/float/015-expected.txt:
- platform/mac/fast/block/margin-collapse/006-expected.txt:
- platform/mac/fast/block/margin-collapse/010-expected.txt:
- platform/mac/fast/block/margin-collapse/011-expected.txt:
- platform/mac/fast/block/margin-collapse/012-expected.txt:
- platform/mac/fast/block/margin-collapse/015-expected.txt:
- platform/mac/fast/block/margin-collapse/016-expected.txt:
- platform/mac/fast/block/margin-collapse/017-expected.txt:
- platform/mac/fast/block/margin-collapse/018-expected.txt:
- platform/mac/fast/block/margin-collapse/019-expected.txt:
- platform/mac/fast/block/margin-collapse/020-expected.txt:
- platform/mac/fast/block/margin-collapse/021-expected.txt:
- platform/mac/fast/block/margin-collapse/022-expected.txt:
- platform/mac/fast/block/margin-collapse/025-expected.txt:
- platform/mac/fast/block/margin-collapse/032-expected.txt:
- platform/mac/fast/block/margin-collapse/033-expected.txt:
- platform/mac/fast/block/margin-collapse/034-expected.txt:
- platform/mac/fast/block/margin-collapse/041-expected.txt:
- platform/mac/fast/block/margin-collapse/042-expected.txt:
- platform/mac/fast/block/margin-collapse/055-expected.txt:
- platform/mac/fast/block/margin-collapse/056-expected.txt:
- platform/mac/fast/block/margin-collapse/057-expected.txt:
- platform/mac/fast/block/margin-collapse/058-expected.txt:
- platform/mac/fast/block/margin-collapse/059-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/mac/fast/block/positioning/negative-right-pos-expected.txt:
- platform/mac/fast/block/positioning/table-cell-static-position-expected.txt:
- platform/mac/fast/borders/border-antialiasing-expected.txt:
- platform/mac/fast/borders/border-radius-different-width-001-expected.txt:
- platform/mac/fast/borders/table-borders-expected.txt:
- platform/mac/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
- platform/mac/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
- platform/mac/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
- platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
- platform/mac/fast/css-generated-content/table-parts-before-and-after-expected.txt:
- platform/mac/fast/css-generated-content/table-row-group-with-before-expected.txt:
- platform/mac/fast/css-generated-content/table-row-with-before-expected.txt:
- platform/mac/fast/css-generated-content/table-with-before-expected.txt:
- platform/mac/fast/css/003-expected.txt:
- platform/mac/fast/css/absolute-poition-in-rtl-parent-expected.txt:
- platform/mac/fast/css/acid2-expected.txt:
- platform/mac/fast/css/acid2-pixel-expected.txt:
- platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
- platform/mac/fast/css/box-shadow-and-border-radius-expected.txt:
- platform/mac/fast/css/caption-width-absolute-position-expected.txt:
- platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt:
- platform/mac/fast/css/caption-width-fixed-position-expected.txt:
- platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt:
- platform/mac/fast/css/caption-width-relative-position-expected.txt:
- platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt:
- platform/mac/fast/css/css3-nth-child-expected.txt:
- platform/mac/fast/css/focus-ring-detached-expected.txt:
- platform/mac/fast/css/focus-ring-multiline-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/fast/css/image-rendering-expected.txt:
- platform/mac/fast/css/min-width-with-spanned-cell-expected.txt:
- platform/mac/fast/css/percentage-non-integer-expected.txt:
- platform/mac/fast/css/table-text-align-quirk-expected.txt:
- platform/mac/fast/css/table-text-align-strict-expected.txt:
- platform/mac/fast/dom/34176-expected.txt:
- platform/mac/fast/dom/HTMLTableElement/colSpan-expected.txt:
- platform/mac/fast/dom/HTMLTableElement/createCaption-expected.txt:
- platform/mac/fast/dom/row-inner-text-expected.txt:
- platform/mac/fast/dynamic/001-expected.txt:
- platform/mac/fast/dynamic/containing-block-change-expected.txt:
- platform/mac/fast/dynamic/float-withdrawal-expected.txt:
- platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/forms/001-expected.txt:
- platform/mac/fast/forms/005-expected.txt:
- platform/mac/fast/forms/basic-buttons-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/form-hides-table-expected.txt:
- platform/mac/fast/forms/form-in-malformed-markup-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/input-table-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/forms/select-dirty-parent-pref-widths-expected.txt:
- platform/mac/fast/html/details-writing-mode-expected.txt:
- platform/mac/fast/inline-block/001-expected.txt:
- platform/mac/fast/inline-block/overflow-clip-expected.txt:
- platform/mac/fast/invalid/012-expected.txt:
- platform/mac/fast/invalid/018-expected.txt:
- platform/mac/fast/lists/004-expected.txt:
- platform/mac/fast/lists/list-marker-before-content-table-expected.txt:
- platform/mac/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
- platform/mac/fast/overflow/002-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-expected.txt:
- platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
- platform/mac/fast/overflow/table-overflow-float-expected.txt:
- platform/mac/fast/reflections/table-cell-expected.txt:
- platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
- platform/mac/fast/repaint/float-overflow-expected.txt:
- platform/mac/fast/repaint/float-overflow-right-expected.txt:
- platform/mac/fast/repaint/subtree-root-clip-3-expected.txt:
- platform/mac/fast/repaint/table-cell-collapsed-border-expected.txt:
- platform/mac/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
- platform/mac/fast/repaint/table-cell-move-expected.txt:
- platform/mac/fast/repaint/table-cell-overflow-expected.txt:
- platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt:
- platform/mac/fast/repaint/table-col-background-expected.txt:
- platform/mac/fast/repaint/table-collapsed-border-expected.txt:
- platform/mac/fast/repaint/table-extra-bottom-grow-expected.txt:
- platform/mac/fast/repaint/table-outer-border-expected.txt:
- platform/mac/fast/repaint/table-row-expected.txt:
- platform/mac/fast/repaint/table-section-overflow-expected.txt:
- platform/mac/fast/repaint/table-section-repaint-expected.txt:
- platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
- platform/mac/fast/repaint/table-writing-modes-h-expected.txt:
- platform/mac/fast/repaint/table-writing-modes-v-expected.txt:
- platform/mac/fast/replaced/005-expected.txt:
- platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
- platform/mac/fast/replaced/selection-rect-in-table-cell-expected.txt:
- platform/mac/fast/replaced/table-percent-height-positioned-expected.txt:
- platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
- platform/mac/fast/replaced/width100percent-image-expected.txt:
- platform/mac/fast/replaced/width100percent-menulist-expected.txt:
- platform/mac/fast/replaced/width100percent-radio-expected.txt:
- platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
- platform/mac/fast/replaced/width100percent-textarea-expected.txt:
- platform/mac/fast/replaced/width100percent-textfield-expected.txt:
- platform/mac/fast/selectors/077-expected.txt:
- platform/mac/fast/selectors/077b-expected.txt:
- platform/mac/fast/table/002-expected.txt:
- platform/mac/fast/table/003-expected.txt:
- platform/mac/fast/table/005-expected.txt:
- platform/mac/fast/table/007-expected.txt:
- platform/mac/fast/table/008-expected.txt:
- platform/mac/fast/table/009-expected.txt:
- platform/mac/fast/table/012-expected.txt:
- platform/mac/fast/table/013-expected.txt:
- platform/mac/fast/table/021-expected.txt:
- platform/mac/fast/table/023-expected.txt:
- platform/mac/fast/table/024-expected.txt:
- platform/mac/fast/table/025-expected.txt:
- platform/mac/fast/table/028-expected.txt:
- platform/mac/fast/table/028-vertical-expected.txt:
- platform/mac/fast/table/029-expected.txt:
- platform/mac/fast/table/031-expected.txt:
- platform/mac/fast/table/032-expected.txt:
- platform/mac/fast/table/034-expected.txt:
- platform/mac/fast/table/038-expected.txt:
- platform/mac/fast/table/038-vertical-expected.txt:
- platform/mac/fast/table/039-expected.txt:
- platform/mac/fast/table/040-expected.txt:
- platform/mac/fast/table/040-vertical-expected.txt:
- platform/mac/fast/table/100-percent-cell-width-expected.txt:
- platform/mac/fast/table/add-before-anonymous-child-expected.txt:
- platform/mac/fast/table/border-collapsing/001-expected.txt:
- platform/mac/fast/table/border-collapsing/001-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/002-expected.txt:
- platform/mac/fast/table/border-collapsing/002-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/003-expected.txt:
- platform/mac/fast/table/border-collapsing/003-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/004-expected.txt:
- platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
- platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/bug14274-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-69296-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/mac/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
- platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
- platform/mac/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
- platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
- platform/mac/fast/table/caption-relayout-expected.txt:
- platform/mac/fast/table/cell-absolute-child-expected.txt:
- platform/mac/fast/table/cell-width-auto-expected.txt:
- platform/mac/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/mac/fast/table/colspanMinWidth-expected.txt:
- platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
- platform/mac/fast/table/dynamic-cellpadding-expected.txt:
- platform/mac/fast/table/edge-offsets-expected.txt:
- platform/mac/fast/table/empty-cells-expected.txt:
- platform/mac/fast/table/frame-and-rules-expected.txt:
- platform/mac/fast/table/giantRowspan-expected.txt:
- platform/mac/fast/table/growCellForImageQuirk-expected.txt:
- platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt:
- platform/mac/fast/table/height-percent-test-expected.txt:
- platform/mac/fast/table/height-percent-test-vertical-expected.txt:
- platform/mac/fast/table/invisible-cell-background-expected.txt:
- platform/mac/fast/table/large-width-expected.txt:
- platform/mac/fast/table/max-width-integer-overflow-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
- platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
- platform/mac/fast/table/nobr-expected.txt:
- platform/mac/fast/table/overflowHidden-expected.txt:
- platform/mac/fast/table/percent-heights-expected.txt:
- platform/mac/fast/table/percent-widths-stretch-expected.txt:
- platform/mac/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/mac/fast/table/prepend-in-anonymous-table-expected.txt:
- platform/mac/fast/table/relative-position-containment-expected.txt:
- platform/mac/fast/table/relative-position-offsets-expected.txt:
- platform/mac/fast/table/relative-position-stacking-expected.txt:
- platform/mac/fast/table/replaced-percent-height-expected.txt:
- platform/mac/fast/table/row-height-recalc-expected.txt:
- platform/mac/fast/table/rowspan-paint-order-expected.txt:
- platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt:
- platform/mac/fast/table/simple_paint-expected.txt:
- platform/mac/fast/table/spanOverlapRepaint-expected.txt:
- platform/mac/fast/table/stale-grid-crash-expected.txt:
- platform/mac/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/mac/fast/table/table-anonymous-row-bug-expected.txt:
- platform/mac/fast/table/table-anonymous-section-bug-expected.txt:
- platform/mac/fast/table/table-before-child-style-update-expected.txt:
- platform/mac/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
- platform/mac/fast/table/table-cell-before-after-content-around-table-expected.txt:
- platform/mac/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
- platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
- platform/mac/fast/table/table-cell-split-expected.txt:
- platform/mac/fast/table/table-display-types-expected.txt:
- platform/mac/fast/table/table-display-types-strict-expected.txt:
- platform/mac/fast/table/table-display-types-vertical-expected.txt:
- platform/mac/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/mac/fast/table/table-row-before-after-content-around-block-expected.txt:
- platform/mac/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
- platform/mac/fast/table/table-row-before-after-content-around-table-expected.txt:
- platform/mac/fast/table/table-row-before-child-style-update-expected.txt:
- platform/mac/fast/table/table-row-outline-paint-expected.txt:
- platform/mac/fast/table/table-row-split2-expected.txt:
- platform/mac/fast/table/table-row-style-not-updated-expected.txt:
- platform/mac/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
- platform/mac/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
- platform/mac/fast/table/table-section-split2-expected.txt:
- platform/mac/fast/table/table-split-expected.txt:
- platform/mac/fast/table/table-split2-expected.txt:
- platform/mac/fast/table/table-style-not-updated-expected.txt:
- platform/mac/fast/table/wide-colspan-expected.txt:
- platform/mac/fast/table/wide-column-expected.txt:
- platform/mac/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/mac/fast/text/atsui-spacing-features-expected.txt:
- platform/mac/fast/text/basic/generic-family-reset-expected.txt:
- platform/mac/fast/text/international/003-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/mac/fast/text/international/bidi-override-expected.txt:
- platform/mac/fast/text/wbr-expected.txt:
- platform/mac/fast/text/whitespace/002-expected.txt:
- platform/mac/fast/text/whitespace/003-expected.txt:
- platform/mac/fast/text/whitespace/004-expected.txt:
- platform/mac/fast/text/whitespace/005-expected.txt:
- platform/mac/fast/text/whitespace/010-expected.txt:
- platform/mac/fast/text/whitespace/011-expected.txt:
- platform/mac/fast/text/whitespace/013-expected.txt:
- platform/mac/fast/text/whitespace/014-expected.txt:
- platform/mac/fast/text/whitespace/015-expected.txt:
- platform/mac/fast/text/whitespace/016-expected.txt:
- platform/mac/fast/text/whitespace/025-expected.txt:
- platform/mac/fast/text/whitespace/026-expected.txt:
- platform/mac/fast/writing-mode/table-percent-width-quirk-expected.txt:
- platform/mac/fast/writing-mode/vertical-align-table-baseline-expected.txt:
- platform/mac/http/tests/misc/acid2-expected.txt:
- platform/mac/http/tests/misc/acid2-pixel-expected.txt:
- platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
- platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/tables/layering/paint-test-layering-1-expected.txt:
- platform/mac/tables/layering/paint-test-layering-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10009-expected.txt:
- platform/mac/tables/mozilla/bugs/bug101201-expected.txt:
- platform/mac/tables/mozilla/bugs/bug101674-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10565-expected.txt:
- platform/mac/tables/mozilla/bugs/bug10633-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1067-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1067-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106795-expected.txt:
- platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1163-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12008-expected.txt:
- platform/mac/tables/mozilla/bugs/bug120107-expected.txt:
- platform/mac/tables/mozilla/bugs/bug120364-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1224-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12268-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12709-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1271-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12908-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12908-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug12910-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1296-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1302-expected.txt:
- platform/mac/tables/mozilla/bugs/bug13169-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug139524-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1430-expected.txt:
- platform/mac/tables/mozilla/bugs/bug14323-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1474-expected.txt:
- platform/mac/tables/mozilla/bugs/bug14929-expected.txt:
- platform/mac/tables/mozilla/bugs/bug15247-expected.txt:
- platform/mac/tables/mozilla/bugs/bug154780-expected.txt:
- platform/mac/tables/mozilla/bugs/bug15544-expected.txt:
- platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
- platform/mac/tables/mozilla/bugs/bug15933-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
- platform/mac/tables/mozilla/bugs/bug16252-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
- platform/mac/tables/mozilla/bugs/bug175455-4-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17548-expected.txt:
- platform/mac/tables/mozilla/bugs/bug17587-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1800-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1802-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1802s-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1809-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18440-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18664-expected.txt:
- platform/mac/tables/mozilla/bugs/bug18955-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug19356-expected.txt:
- platform/mac/tables/mozilla/bugs/bug20804-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2123-expected.txt:
- platform/mac/tables/mozilla/bugs/bug215629-expected.txt:
- platform/mac/tables/mozilla/bugs/bug219693-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug219693-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22019-expected.txt:
- platform/mac/tables/mozilla/bugs/bug220536-expected.txt:
- platform/mac/tables/mozilla/bugs/bug222336-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22246-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22246-3a-expected.txt:
- platform/mac/tables/mozilla/bugs/bug22513-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2296-expected.txt:
- platform/mac/tables/mozilla/bugs/bug23235-expected.txt:
- platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug25004-expected.txt:
- platform/mac/tables/mozilla/bugs/bug25074-expected.txt:
- platform/mac/tables/mozilla/bugs/bug25663-expected.txt:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2684-expected.txt:
- platform/mac/tables/mozilla/bugs/bug269566-expected.txt:
- platform/mac/tables/mozilla/bugs/bug277062-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2773-expected.txt:
- platform/mac/tables/mozilla/bugs/bug27993-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2886-expected.txt:
- platform/mac/tables/mozilla/bugs/bug28933-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29058-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29314-expected.txt:
- platform/mac/tables/mozilla/bugs/bug29429-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2954-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2981-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2981-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2997-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30273-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3103-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32205-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3260-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32841-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
- platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3454-expected.txt:
- platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
- platform/mac/tables/mozilla/bugs/bug3977-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4093-expected.txt:
- platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4385-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4427-expected.txt:
- platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4501-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug45350-expected.txt:
- platform/mac/tables/mozilla/bugs/bug45486-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4576-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46268-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46623-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug46623-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug47432-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4803-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4849-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4849-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
- platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53891-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug55789-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56201-expected.txt:
- platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5797-expected.txt:
- platform/mac/tables/mozilla/bugs/bug5835-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60804-expected.txt:
- platform/mac/tables/mozilla/bugs/bug60807-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6184-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6404-expected.txt:
- platform/mac/tables/mozilla/bugs/bug647-expected.txt:
- platform/mac/tables/mozilla/bugs/bug6674-expected.txt:
- platform/mac/tables/mozilla/bugs/bug68998-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69382-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69382-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug72359-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
- platform/mac/tables/mozilla/bugs/bug7714-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug82946-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug86708-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8950-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9123-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9123-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug92143-expected.txt:
- platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug963-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug97383-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9879-1-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/core/borders-expected.txt:
- platform/mac/tables/mozilla/core/cell_heights-expected.txt:
- platform/mac/tables/mozilla/core/col_span-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_fix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_auto_per-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_fix-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
- platform/mac/tables/mozilla/core/col_widths_fix_per-expected.txt:
- platform/mac/tables/mozilla/core/margins-expected.txt:
- platform/mac/tables/mozilla/core/misc-expected.txt:
- platform/mac/tables/mozilla/core/nested1-expected.txt:
- platform/mac/tables/mozilla/core/one_row-expected.txt:
- platform/mac/tables/mozilla/core/table_frame-expected.txt:
- platform/mac/tables/mozilla/core/table_heights-expected.txt:
- platform/mac/tables/mozilla/core/table_rules-expected.txt:
- platform/mac/tables/mozilla/core/table_widths-expected.txt:
- platform/mac/tables/mozilla/dom/insertColGroups1-expected.txt:
- platform/mac/tables/mozilla/dom/insertColGroups2-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols1-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols2-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols3-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols4-expected.txt:
- platform/mac/tables/mozilla/dom/insertCols5-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/mac/tables/mozilla/marvin/body_thead-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_span-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
- platform/mac/tables/mozilla/marvin/colgroup_width_px-expected.txt:
- platform/mac/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
- platform/mac/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/mac/tables/mozilla/marvin/table_row_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/table_row_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/table_row_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/table_rules_groups-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_td_width-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_th_width-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_width_percent-expected.txt:
- platform/mac/tables/mozilla/marvin/tables_width_px-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/td_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/th_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/thead_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/tr_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_span-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_width_px-expected.txt:
- platform/mac/tables/mozilla/marvin/x_col_width_rel-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_span-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_td_width-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_center-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_left-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_align_right-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_rowspan-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_th_width-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_align_char-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
- platform/mac/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
- platform/mac/tables/mozilla/other/cell_widths-expected.txt:
- platform/mac/tables/mozilla/other/ms-expected.txt:
- platform/mac/tables/mozilla/other/nested2-expected.txt:
- platform/mac/tables/mozilla/other/nestedTables-expected.txt:
- platform/mac/tables/mozilla/other/slashlogo-expected.txt:
- platform/mac/tables/mozilla/other/test3-expected.txt:
- platform/mac/tables/mozilla/other/test6-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/col_span2-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/cols1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/columns-expected.txt:
- platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
- platform/mac/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
- platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
- 8:30 AM Changeset in webkit [195739] by
-
- 1 edit in branches/safari-601-branch/Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp
Apply custom patch for rdar://problem/24209116
- 8:26 AM Changeset in webkit [195738] by
-
- 4 edits in branches/safari-601-branch/Source/WebCore
Cherry-pick r195592 and parts of r194672 to fix rdar://24154288
- 8:18 AM Changeset in webkit [195737] by
-
- 5 edits in trunk/Tools
[webkitdirs] Don't pass cmakeBasedPortName around.
https://bugs.webkit.org/show_bug.cgi?id=153589
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-28
Reviewed by Darin Adler.
It should be local function of webkitdirs.pm instead.
- Scripts/build-jsc: Don't pass cmakeBasedPortName to
buildCMakeProjectOrExit().
- Scripts/build-webkit: Don't pass cmakeBasedPortName to
buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
- Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
generateBuildSystemFromCMakeProject().
- Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
(generateBuildSystemFromCMakeProject): Removed $port argument as we
can get it from cmakeBasedPortName().
(buildCMakeProjectOrExit): Ditto.
- 7:16 AM Changeset in webkit [195736] by
-
- 5 edits in trunk
[GStreamer] Clean up includes and headers related with GStreamerGL
https://bugs.webkit.org/show_bug.cgi?id=153590
Reviewed by Philippe Normand.
Source/WebCore:
Remove gstglmemory from the including list and reorder includes to
organize GSTREAMER_GL related headers. It violates style rules of the
include order, but there is no clean way to include gst/gl/gl.h
without violating it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Tools:
- Scripts/webkitpy/style/checker.py: Skips
include_order check for MediaPlayerPrivateGStreamerBase.cpp
Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
- 1:06 AM Changeset in webkit [195735] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] MediaPlayerPrivateGStreamerBase::handleSyncMessage leaks GstContext
https://bugs.webkit.org/show_bug.cgi?id=153580
Reviewed by Philippe Normand.
When we creates GstContext using gst_context_new it increases refcount itself.
And the refcount of GstContext is increased when it is passed to
gst_element_set_context, also. Therefore We should unref GstContext after
using it to prevent GstContext leaks.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Added for GstContext.
(WTF::refGPtr<GstContext>): Ditto
(WTF::derefGPtr<GstContext>): Ditto
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Use GRefPtr<GstContext> to handle currect refcounting
- 12:52 AM Changeset in webkit [195734] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] B3 Tail Call with Varargs do not restore callee saved registers
https://bugs.webkit.org/show_bug.cgi?id=153579
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-28
Reviewed by Michael Saboff.
We were trashing the callee saved registers in Tail Calls.
I just copied the code from DFG to fix this :)
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
Jan 27, 2016:
- 10:46 PM Changeset in webkit [195733] by
-
- 4 edits in trunk/Source
Source/WebCore:
Fix clean CMake build after r195711.
- PlatformWin.cmake:
Copy forwarding headers from the new directory to find ContentSecurityPolicy.h.
This should fix EWS issues like the one seen in bug 153573.
Source/WebKit2:
Fix CMake build after r195722.
- PlatformMac.cmake:
Include new file.
- 10:45 PM Changeset in webkit [195732] by
-
- 2 edits in trunk/Source/WebKit2
Fix other builds.
- Configurations/WebKit.xcconfig:
- 10:23 PM Changeset in webkit [195731] by
-
- 12 edits in trunk
Expose ValidityState on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153582
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaseline W3C html test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Expose ValidityState on the global Window object:
https://html.spec.whatwg.org/#validitystate
Firefox and Chrome match the specification.
No new tests, already covered by existing tests.
- html/ValidityState.idl:
LayoutTests:
Rebaseline test now that ValidityState is exposed on the global Window
object.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 10:00 PM Changeset in webkit [195730] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't show hand cursor for edited attribute
https://bugs.webkit.org/show_bug.cgi?id=152211
<rdar://problem/23870523>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/Editing.css:
(.editing, .editing *):
- 9:33 PM Changeset in webkit [195729] by
-
- 13 edits in trunk
Expose ApplicationCache on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153578
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Rebaseline W3C HTML test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Expose ApplicationCache on the global Window object as per:
https://html.spec.whatwg.org/#the-storage-interface
Chrome follows the spec.
No new tests, already covered by existing test.
- loader/appcache/DOMApplicationCache.idl:
LayoutTests:
Rebaseline test now that ApplicationCache is exposed on the global
Window object.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 9:21 PM Changeset in webkit [195728] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3 IntRange analysis should know more about shifting
https://bugs.webkit.org/show_bug.cgi?id=153568
Reviewed by Benjamin Poulain.
This teaches the IntRange analysis that the result of a right shift is usually better than
the worst-case mask based on the shift amount. In fact, you can reach useful conclusions
from looking at the IntRange of the input. This helps because Octane/crypto does something
like:
CheckMul((@x & $268435455) >> 14, @y >> 14, ...)
If you consider just the shifts, then this may overflow. But if you consider that @x is
first masked, then the IntRange coming out of the first shift is tight enough to prove that
the CheckMul cannot overflow.
- b3/B3ReduceStrength.cpp:
- b3/testb3.cpp:
- 8:42 PM Changeset in webkit [195727] by
-
- 3 edits2 adds in trunk
REGRESSION(r190430): Assertion failure in Text::~Text()
https://bugs.webkit.org/show_bug.cgi?id=153577
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by destroyRenderTreeIfNeeded exiting early on all HTMLSlotElement as it lacks a render object.
Fixed it by explicitly avoiding the early return when child is a HTMLSlotElement.
Test: fast/shadow-dom/slot-removal-crash-2.html
- dom/ContainerNode.cpp:
(WebCore::destroyRenderTreeIfNeeded):
LayoutTests:
Added a regression test. The test hits an assertion in debug build without the fix.
- fast/shadow-dom/slot-removal-crash-2-expected.txt: Added.
- fast/shadow-dom/slot-removal-crash-2.html: Added.
- 7:33 PM Changeset in webkit [195726] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- Configurations/WebKit.xcconfig:
- 6:28 PM Changeset in webkit [195725] by
-
- 4 edits in trunk
[EFL] Remove unused accessibility related code
https://bugs.webkit.org/show_bug.cgi?id=153543
Reviewed by Darin Adler.
Source/WebKit2:
Do not need to load external library to expose WebKit's
accessibility tree. There have been changes in EFL/Elementary
in terms of support of accessibility and we should follow those.
- WebProcess/efl/WebProcessMainEfl.cpp:
(eailLibraryPath): Deleted.
(eail): Deleted.
Tools:
Removed reference to EAIL library.
It not going to be support anymore. There have been changes in
EFL/Elementary in terms of the accessibility and we should
follow those.
- efl/jhbuild-optional.modules:
- 6:21 PM Changeset in webkit [195724] by
-
- 3 edits4 adds in trunk
Garbage is displayed when root svg element has mix-blend-mode set
https://bugs.webkit.org/show_bug.cgi?id=150556
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-27
Reviewed by Darin Adler.
Source/WebCore:
This bug happens when compositing on a CALayer and drawing on a transparent
layer, so it happens with WK2 with <svg style="mix-blend-mode...">. And it
can happen with WK1 also with <svg style="opacity=...;mix-blend-mode...">.
But in both cases, the SVG root renderer should be the root of the render
tree. So it happens only with the stand alone SVG documents.
SVGRenderContext::prepareToRenderSVGContent() ignores the opacity of
the SVG root but it creates a transparent layer for the blend-mode.
But RenderLayer::beginTransparencyLayers() creates a transparent layer
for opacity and it sets the blend-mode also.
The fix is to begin two transparent layers for the SVG root renderer: one
for the opacity and the second for the blend-mode. The opacity transparent
layer will be still managed by RenderLayer::beginTransparencyLayers(). While
the blend-mode transparent layer will be managed by SVGRenderContext
::prepareToRenderSVGContent().
Tests: svg/css/mix-blend-mode-background-root.svg
svg/css/mix-blend-mode-opacity-root.svg
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
LayoutTests:
Ensure blending the SVG root renderer will be displayed correctly with
compositing when the SVG root renderer is the root of the render tree.
- svg/css/mix-blend-mode-background-root-expected.svg: Added.
- svg/css/mix-blend-mode-background-root.svg: Added.
- svg/css/mix-blend-mode-opacity-root-expected.svg: Added.
- svg/css/mix-blend-mode-opacity-root.svg: Added.
- 6:14 PM Changeset in webkit [195723] by
-
- 3 edits in trunk/Source/WebInspectorUI
CodeMirror will strip out "\r" from files with "\r\n" as newlines causing our offsets into the file to be incorrect
https://bugs.webkit.org/show_bug.cgi?id=153529
<rdar://problem/24376799>
Reviewed by Timothy Hatcher.
This problem manifested in the type token annotator inserting
tokens in the wrong places. Because our offsets are computed
based on the resource we get from backend, CodeMirror changing
the source text will cause all of our offsets to be incorrect.
- UserInterface/Views/CodeMirrorEditor.js:
(WebInspector.CodeMirrorEditor.create):
(WebInspector.CodeMirrorEditor):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.set string.update):
(WebInspector.TextEditor.prototype.set string):
- 5:36 PM Changeset in webkit [195722] by
-
- 20 edits2 adds in trunk/Source
Cache results of data detection in the UI process when load completes.
https://bugs.webkit.org/show_bug.cgi?id=153560
Reviewed by Tim Horton.
Source/WebCore:
Adding new FrameLoaderClient method to notify that data
detection is complete and provide the results.
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- loader/FrameLoaderClient.h:
Source/WebKit/mac:
Adding empty implementation for WK1.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidFinishDataDetection):
Source/WebKit2:
This patch changes when the results of data detections are sent to the
UIProcess. Before this change, they were only provided as part of
InteractionInformationAtPosition, which is populated when long press
gesture is triggered.
We need to have the results available if the client wants to allow navigation
to a data detector link, in order to allow them to retrieve the full url.
With this change, we now send the results as soon as they are computed
and keep them in the WebPageProxy object so that they can be fetched when
necessary from a WKWebView private interface.
- Shared/Cocoa/DataDetectionResult.h: Added.
- Shared/Cocoa/DataDetectionResult.mm: Added.
(WebKit::DataDetectionResult::encode):
(WebKit::DataDetectionResult::decode):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _snapshotLayerContentsForBackForwardListItem:]):
(-[WKWebView _dataDetectionResults]):
(-[WKWebView _didRelaunchProcess]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::setDataDetectionResult):
(WebKit::WebPageProxy::saveRecentSearches):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::websiteDataStore):
(WebKit::WebPageProxy::dataDetectionResults):
(WebKit::WebPageProxy::scrollingCoordinatorProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView ensurePositionInformationIsUpToDate:]):
(-[WKContentView _dataDetectionResults]):
(-[WKContentView gestureRecognizerShouldBegin:]):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDataDetection):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::setDataDetectionResults):
(WebKit::WebPage::willCommitLayerTree):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::shouldExtendIncrementalRenderingSuppression):
- 5:34 PM Changeset in webkit [195721] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r195609. rdar://problem/24337868
- 5:34 PM Changeset in webkit [195720] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r195606. rdar://problem/24242476
- 5:34 PM Changeset in webkit [195719] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merge r195492. rdar://problem/24002217
- 5:34 PM Changeset in webkit [195718] by
-
- 6 edits8 adds in branches/safari-601-branch
Merge r195477. rdar://problem/24002217
- 5:34 PM Changeset in webkit [195717] by
-
- 4 edits4 adds in branches/safari-601-branch
Merge r195162. rdar://problem/24302736
- 5:34 PM Changeset in webkit [195716] by
-
- 6 edits in branches/safari-601-branch/Source/WebCore
Merge r195132. rdar://problem/24154292
- 5:34 PM Changeset in webkit [195715] by
-
- 5 edits15 adds in branches/safari-601-branch
Merge r195075. rdar://problem/24302727
- 5:34 PM Changeset in webkit [195714] by
-
- 10 edits in branches/safari-601-branch/Source
Merge r194559. rdar://problem/24269083
- 5:34 PM Changeset in webkit [195713] by
-
- 2 edits1 add in branches/safari-601-branch/Source/JavaScriptCore
Merge r193782. rdar://problem/24358367
- 5:14 PM Changeset in webkit [195712] by
-
- 2 edits in trunk/Source/WebKit2
Include the right WebKitAdditions files
https://bugs.webkit.org/show_bug.cgi?id=153572
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
- 5:08 PM Changeset in webkit [195711] by
-
- 7 edits2 moves1 add in trunk/Source
Move ContentSecurityPolicy.{cpp, h} to its own directory
https://bugs.webkit.org/show_bug.cgi?id=153527
<rdar://problem/24359892>
Reviewed by Sam Weinig.
Source/WebCore:
Move ContentSecurityPolicy.{cpp, h} from Source/WebCore/page to Source/WebCore/page/csp.
This will facilitate separating out the policy support classes (e.g. CSPDirectiveList)
into their own files to improve the hackability of this code.
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- page/csp/ContentSecurityPolicy.cpp: Renamed from Source/WebCore/page/ContentSecurityPolicy.cpp.
- page/csp/ContentSecurityPolicy.h: Renamed from Source/WebCore/page/ContentSecurityPolicy.h.
Source/WebKit2:
Add ${WEBCORE_DIR}/page/csp to the list of WebKit2 include directories.
- CMakeLists.txt:
- 4:38 PM Changeset in webkit [195710] by
-
- 6 edits15 copies in branches/safari-601.1.46-branch
Merged r195625. rdar://problem/24337780
- 4:37 PM Changeset in webkit [195709] by
-
- 4 edits in trunk
Modern IDB: Incorrect handling of iterating cursors to their end.
https://bugs.webkit.org/show_bug.cgi?id=153569
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (3 tests now pass, others are closer to passing).
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 4:32 PM Changeset in webkit [195708] by
-
- 1 edit3 adds in trunk/LayoutTests
Layout Test fast/forms/auto-fill-button/input-contacts-auto-fill-button.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=153567.
Unreviewed test gardening.
Update expected test results for ios-simulator, win, and gtk.
Patch by Zhuo Li <zachli@apple.com> on 2016-01-27
- platform/gtk/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- platform/win/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- 4:29 PM Changeset in webkit [195707] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] adjustFrameAndStackInOSRExitCompilerThunk() can trash values in FTL
https://bugs.webkit.org/show_bug.cgi?id=153536
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-27
Reviewed by Saam Barati.
Workaround to get B3 working on ARM.
- dfg/DFGOSRExitCompilerCommon.h:
(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):
The code was using the scratch registers in a few places.
I initially tried to make is not use scratch registers anywhere
but that looked super fragile.
Instead, I just preserve the scratch registers. That's easy and
it should be relatively cheap compared to everything done on OSR Exits.
- 4:18 PM Changeset in webkit [195706] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Regression (r195303) - Changes to TreeOutline break styling of lists in Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=153563
Patch by Devin Rousso <Devin Rousso> on 2016-01-27
Reviewed by Timothy Hatcher.
Removed duplicate properties and used new methods of TreeOutline to achieve
the desired styling effects.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item.visual-style-font-family-list-item > .visual-style-comma-separated-keyword-item-editor):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles): Deleted.
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection):
- UserInterface/Views/VisualStyleSelectorTreeItem.css:
(.item.visual-style-selector-item > .icon):
(.item.visual-style-selector-item > .titles):
(.item.visual-style-selector-item > .titles > .subtitle):
(.item.visual-style-selector-item.selected > .titles > .subtitle):
(.item.visual-style-selector-item > .titles > .subtitle::before): Deleted.
- 4:17 PM Changeset in webkit [195705] by
-
- 4 edits in trunk/Source/WebCore
AX: Crash in AccessibilityTableColumn::headerObject
https://bugs.webkit.org/show_bug.cgi?id=153553
<rdar://problem/23196278>
Reviewed by Chris Fleizach.
Webkit was crashing sometimes when we asked for column headers of a table.
The columns vector of the table was reset during the iteration when we
were asking for the headerObject of each column. The column's addChildren()
function calls elementRect() for each child cell and that sometimes causes
the parent table to reset its children.
Fixed it by caching the columns vector and moving out the elementRect() logic
from AccessibilityTalbeColumn::addChildren().
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::elementRect):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::addChildren):
- accessibility/AccessibilityTableColumn.h:
- 4:16 PM Changeset in webkit [195704] by
-
- 3 edits8 deletes in trunk
Remove WebKitSystemInterface for iOS SDK < 9
https://bugs.webkit.org/show_bug.cgi?id=153570
Reviewed by Andy Estes.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
We no longer support building for iOS < 9.
- libWebKitSystemInterfaceIOSDevice8.1.a: Removed.
- libWebKitSystemInterfaceIOSDevice8.2.a: Removed.
- libWebKitSystemInterfaceIOSDevice8.3.a: Removed.
- libWebKitSystemInterfaceIOSDevice8.4.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.1.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.2.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.3.a: Removed.
- libWebKitSystemInterfaceIOSSimulator8.4.a: Removed.
- 4:02 PM Changeset in webkit [195703] by
-
- 3 edits2 copies in branches/safari-601.1.46-branch
Merged r195671. rdar://problem/24302956
- 3:55 PM Changeset in webkit [195702] by
-
- 5 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merged r195651. rdar://problem/24302943
- 3:45 PM Changeset in webkit [195701] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Use reinterpret_cast_ptr to suppress alignment warnings.
https://bugs.webkit.org/show_bug.cgi?id=153424
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-27
Reviewed by Darin Adler.
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::sortFloat):
- 3:42 PM Changeset in webkit [195700] by
-
- 25 edits in trunk
Settings a reflected DOMString attribute to null should set it to the "null" string rather than the empty string
https://bugs.webkit.org/show_bug.cgi?id=153504
<rdar://problem/24353072>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Settings a reflected DOMString attribute to null should set it to the "null"
string rather than the empty string:
- https://html.spec.whatwg.org/#reflecting-content-attributes-in-idl-attributes
- http://heycam.github.io/webidl/#es-DOMString
- http://people.mozilla.org/~jorendorff/es6-draft.html#sec-tostring
Firefox and Chrome match the specification here.
This is causing a lot of W3C HTML reflection tests to fail on WebKit, e.g.:
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
Call toString() instead of valueToStringWithNullCheck() for reflected
attributes. This way, null gets converted to the string "null", as
expected, instead of a null String object.
- html/HTMLInputElement.idl:
Dropping [TreatNullAs=NullString] IDL extended attribute for
input.defaultValue, as this is not present in the specification:
Without this change, assigning null to input.defaultValue would not
set to to the "null" string, as is expected.
- html/HTMLTextAreaElement.idl:
Dropping [TreatNullAs=NullString] IDL extended attribute for
textArea.defaultValue, as this is not present in the specification:
Without this change, assigning null to textArea.defaultValue would not
set to to the "null" string, as is expected.
- html/HTMLTitleElement.idl:
Dropping [TreatNullAs=NullString] IDL extended attribute for
title.text, as this is not present in the specification:
Without this change, assigning null to title.text would not
set to to the "null" string, as is expected.
LayoutTests:
Update existing tests as a lot of them were expecting that setting
a reflected DOMString attribute to null would set it to the empty
string instead of the string "null".
- fast/dom/domstring-attribute-reflection-expected.txt:
- fast/dom/domstring-attribute-reflection.html:
- fast/dom/element-attribute-js-null-expected.txt:
- fast/dom/element-attribute-js-null.html:
- fast/dom/ping-attribute-dom-binding-expected.txt:
- fast/dom/ping-attribute-dom-binding.html:
- fast/forms/fieldset/fieldset-name-expected.txt:
- fast/forms/fieldset/fieldset-name.html:
- fast/forms/input-minmax-expected.txt:
- fast/forms/input-minmax.html:
- fast/forms/input-pattern-expected.txt:
- fast/forms/input-pattern.html:
- fast/forms/submit-form-attributes-expected.txt:
- fast/forms/submit-form-attributes.html:
- fast/shadow-dom/HTMLSlotElement-interface.html:
- fast/shadow-dom/NonDocumentTypeChildNode-interface-assignedSlot.html:
- fast/shadow-dom/shadow-layout-after-slot-changes.html:
- svg/dom/svg-element-attribute-js-null-expected.txt:
- svg/dom/svg-element-attribute-js-null.xhtml:
- 3:31 PM Changeset in webkit [195699] by
-
- 13 edits3 adds in trunk
Support CSS3 Images values for the image-rendering property
https://bugs.webkit.org/show_bug.cgi?id=153556
Reviewed by Dean Jackson.
Source/WebCore:
CSS3 Images has the following values for image-rendering:
auto, crisp-edges, pixelated
The old code supported:
optimizeSpeed, optimizeQuality, -webkit-crisp-edges, -webkit-optimize-contrast
Add support for the new values without prefixes. Map -webkit-crisp-edges to crisp-edges,
and -webkit-optimize-contrast to crisp-edges. Support pixelated which behaves like
crisp-edges (a low quality scale).
The spec says that optimizeQuality should behave like 'auto', but that would be
a behavior change since ImageQualityController::shouldPaintAtLowQuality() currently
uses it as a trigger to avoid low quality scaling, so don't change that for now.
No new tests, covered by fast/css/script-tests/image-rendering-parsing.js
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
- css/CSSValueKeywords.in:
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.h: Need another bit.
Source/WebInspectorUI:
Add "crisp-edges", "pixelated" to the suggestions for image-rendering.
- UserInterface/Models/CSSKeywordCompletions.js:
LayoutTests:
Update for new values. Add a new SVG shape-rendering test which would have
detected a bug I caused with an earlier patch.
- fast/css/image-rendering-parsing-expected.txt:
- fast/css/script-tests/image-rendering-parsing.js:
- svg/css/script-tests/shape-rendering-parsing.js: Added.
- svg/css/shape-rendering-parsing.html: Added.
- 3:12 PM Changeset in webkit [195698] by
-
- 21 edits3 adds in trunk/Source
Add WebKitAdditions extension points to WebCore, WebKit and WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=153550
Reviewed by Sam Weinig.
Source/WebCore:
- DerivedSources.make:
Add the ability for WebKitAdditions to add events and event targets.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- bindings/scripts/InFilesCompiler.pm:
(initializeFromCommandLine):
(compile):
Handle multiple --input parameters.
- dom/EventNames.h:
Handle adding more event names.
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- page/MainFrame.cpp:
(WebCore::MainFrame::MainFrame):
- page/MainFrame.h:
- page/PageConfiguration.h:
Add extension points.
- platform/cocoa/WebKitAdditions.mm: Added.
Import additions.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Add new files.
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
Add WKA header search paths.
- WebKitAdditions.mm: Added.
Add addition files.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Add extension points.
Source/WebKit2:
- DerivedSources.make:
Add the ability for WebKitAdditions to add new message receivers.
- Shared/Cocoa/WebKitAdditions.mm: Added.
Add addition files.
- Shared/WebCoreArgumentCoders.h:
Add extension points.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::resetState):
Add extension points.
- UIProcess/WebPageProxy.h:
Add extension points.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/WebPage.cpp:
Add extension points.
- 3:03 PM Changeset in webkit [195697] by
-
- 6 edits in trunk
Modern IDB: Fix many Index tests.
https://bugs.webkit.org/show_bug.cgi?id=153561
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Many failing tests now pass).
- Modules/indexeddb/server/MemoryIndex.cpp:
(WebCore::IDBServer::MemoryIndex::getResultForKeyRange):
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
(WebCore::IDBServer::SQLiteIDBCursor::didComplete):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:57 PM Changeset in webkit [195696] by
-
- 6 edits in trunk
Modern IDB: Cursors are utterly broken in the SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153558
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (35 failures now pass, others improve).
- Fixes incorrect usage of Index cursors when ObjectStore cursors are intended.
- Improves the state of getting the cursor value vs. reaching the end of a cursor.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
(WebCore::IDBServer::SQLiteIDBCursor::currentData):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:40 PM Changeset in webkit [195695] by
-
- 27 edits1 move1 add1 delete in trunk
Getting / Setting property on prototype object must throw TypeError
https://bugs.webkit.org/show_bug.cgi?id=153547
<rdar://problem/24370650>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Gettingi / Setting property on prototype object must throw TypeError as per
Web IDL specification:
http://heycam.github.io/webidl/#dfn-attribute-getter (Step 2.4.2)
http://heycam.github.io/webidl/#dfn-attribute-setter (Step 3.5)
Firefox and Chrome already throw a TypeError in this case, as per
the specification. However, WebKit was returning null and merely
logging a deprecation error message. This patch aligns our behavior
with other browsers and the specification.
This patch also adds support for the [LenientThis] IDL extended
attribute:
http://heycam.github.io/webidl/#LenientThis
For [LenientThis] attributes, we do not throw a TypeError if the
attribute getter / setter is called on an object which does not
implement the expected interface, as per:
http://heycam.github.io/webidl/#dfn-attribute-getter (Step 2.4.1)
http://heycam.github.io/webidl/#dfn-attribute-setter (Step 3.5)
No new tests, already covered by existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
Add support for [LenientThis]:
http://heycam.github.io/webidl/#LenientThis
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
Rebaseline bindings tests.
- bindings/scripts/test/TestObj.idl:
Add coverage for [LenientThis] attributes.
- dom/Document.idl:
Mark 'onreadystatechange' as [LenientThis] as per the HTML
specification:
https://html.spec.whatwg.org/#document
- dom/GlobalEventHandlers.idl:
Mark 'onmouseeneter' / 'onmouseleave' as [LenientThis] as per the
HTML specification:
https://html.spec.whatwg.org/#globaleventhandlers
LayoutTests:
Update a few layout tests that were expecting getting a property on
the prototype object to return undefined instead of throwing.
- js/dom/dom-as-prototype-assignment-exception-expected.txt:
- js/dom/dom-attributes-on-mismatch-type-expected.txt:
- js/dom/dom-attributes-on-mismatch-type.html:
- js/dom/script-tests/dom-as-prototype-assignment-exception.js:
- 2:37 PM Changeset in webkit [195694] by
-
- 15 edits in trunk
window.atob() should ignore spaces in input
https://bugs.webkit.org/show_bug.cgi?id=153522
<rdar://problem/24357822>
Reviewed by Benjamin Poulain.
Source/WebCore:
window.atob() should ignore spaces in input as per:
Previously, WebKit would throw an exception and it was the only browser
to do so. Firefox and Chrome behavior according to the specification.
This was causing us to fail 10 checks in the following W3C HTML test:
http://w3c-test.org/html/webappapis/atob/base64.html
No new tests, updated existing test.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::atob):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- platform/network/DataURL.cpp:
(WebCore::handleDataURL):
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::decodeBase64):
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformSave):
Source/WTF:
Turn Base64DecodePolicy enum into flags so that the caller can indicate
to both validate padding AND ignore spaces.
Also make sure that the output Vector size is properly shrunk when
spaces are ignored.
- wtf/text/Base64.cpp:
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
LayoutTests:
Update window.atob() test to cover cases with spaces in
input.
- fast/dom/Window/atob-btoa-expected.txt:
- fast/dom/Window/atob-btoa.html:
- 2:31 PM Changeset in webkit [195693] by
-
- 4 edits in trunk/Source/WebCore
Move some logic related to the presentation mode button from mediaControlsiOS.js to mediaControlsApple.js
https://bugs.webkit.org/show_bug.cgi?id=153476
Reviewed by Eric Carlson.
Also, add the necessary styles to support that control in mediaControlsApple.css.
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-controls-panel.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-text-top.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-text-bottom.picture-in-picture):
(video::-webkit-media-controls-panel .picture-in-picture-button):
Use the same mask image as iOS, but with a different size and a background color specified
(since there's another rule that makes buttons within the panel have a transparent
background color).
(video::-webkit-media-controls-panel .picture-in-picture-button.return-from-picture-in-picture):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
Listen for (and stop listening for) the webkitpresentationmodechanged event if presentation
mode is supported for this video element.
(Controller.prototype.createControls):
Add a class name to the pictureInPictureButton so we can query for it in the stylesheet.
(Controller.prototype.configureInlineControls):
Call updatePictureInPictureButton().
(Controller.prototype.presentationMode):
Moved from mediaControlsiOS.js.
(Controller.prototype.isFullScreen):
Ditto, with a bug fix to not call presentationMode(), since that method calls isFullScreen(),
resulting in infinite recursion.
(Controller.prototype.updatePictureInPictureButton):
Ditto.
(Controller.prototype.handlePresentationModeChange):
Ditto.
(Controller.prototype.handleFullscreenChange):
Call handlePresentationModeChanged() if presentation mode is supported for this video element.
(Controller.prototype.controlsAlwaysVisible):
Ditto.
(Controller.prototype.handlePictureInPictureButtonClicked):
Ditto.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handlePresentationModeChange):
Most logic has been moved to the same method in mediaControlsApple.js, except
updating the style of the panelContainer, which doesn't exist in the Mac controls.
(ControllerIOS.prototype.addVideoListeners): Deleted.
(ControllerIOS.prototype.removeVideoListeners): Deleted.
(ControllerIOS.prototype.presentationMode): Deleted.
(ControllerIOS.prototype.isFullScreen): Deleted.
(ControllerIOS.prototype.handlePictureInPictureButtonClicked): Deleted.
(ControllerIOS.prototype.updatePictureInPictureButton): Deleted.
(ControllerIOS.prototype.handleFullscreenChange): Deleted.
(ControllerIOS.prototype.controlsAlwaysVisible): Deleted.
Delete all code that's already handled in the Controller.
- 2:23 PM Changeset in webkit [195692] by
-
- 3 edits in trunk/Source/WebCore
Enable API related to the video fullscreen layer in MediaPlayerPrivateMediaSourceAVFObjC
also on Mac platform with video presentation mode support.
https://bugs.webkit.org/show_bug.cgi?id=153223
Reviewed by Jer Noble.
Reuse VideoFullscreenLayerManager to manage moving the video layer between the fullscreen
layer and the inline layer depending on the current presentation mode.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
Create m_videoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::platformLayer):
Return the video inline layer from the VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer):
Call VideoFullscreenLayerManager::setVideoLayer() with the m_sampleBufferDisplayLayer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer):
Call VideoFullscreenLayerManager::didDestroyVideoLayer().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenLayer):
Call VideoFullscreenLayerManager::setVideoFullscreenLayer().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoFullscreenFrame):
Call VideoFullscreenLayerManager::setVideoFullscreenFrame().
- 2:08 PM Changeset in webkit [195691] by
-
- 2 edits in trunk/Source/JavaScriptCore
[FTL][Win64] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=153555
Reviewed by Alex Christensen.
MSVC does not accept preprocessor conditionals in macros.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- 2:04 PM Changeset in webkit [195690] by
-
- 3 edits in trunk/Tools
Fix bugs caused by incorrect usage of "branch" vs. "branchName". https://bugs.webkit.org/show_bug.cgi?id=153330
Reviewed by Daniel Bates.
In an earlier patch we started using the name "branch" to indicate a branch object, whereas
"branchName" implies that the variable or property in question is simply a string. We fixed some
inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
spotted in BuildbotQueueView.js.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
Changed branchName to branch.name in call to commitsOnBranch.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
_popoverLinesForCommitRange.
(BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
fix.
- 1:57 PM Changeset in webkit [195689] by
-
- 10 edits in trunk
Modern IDB: SQLite backend doesn't update index records as object records are added.
https://bugs.webkit.org/show_bug.cgi?id=153548
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (4 more tests pass, others improve).
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::initializeVM):
(WebCore::IDBServer::SQLiteIDBBackingStore::vm):
(WebCore::IDBServer::SQLiteIDBBackingStore::globalObject):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 12:47 PM Changeset in webkit [195688] by
-
- 2 edits in trunk/LayoutTests
LayoutTest fast/loader/stateobjects/replacestate-frequency-iframe.html is flaky on El Cap, always times out on Yosemite.
https://bugs.webkit.org/show_bug.cgi?id=153551
Unreviewed.
The iframe file name is "replacestate-iframe.html", but the main frame src refers to "replaceState-iframe.html"
Notice the case difference on the 'S'.
Apparently some of our bots have case sensitive filesystems, and others do not.
- fast/loader/stateobjects/replacestate-frequency-iframe.html:
- 12:37 PM Changeset in webkit [195687] by
-
- 3 edits in trunk/LayoutTests
Noticed while exploring:
LayoutTest fast/loader/stateobjects/replacestate-frequency-iframe.html is flaky on El Cap, always times out on Yosemite.
https://bugs.webkit.org/show_bug.cgi?id=153551
Unreviewed gardening.
Probably won't fix anything, but hey, let's try.
- fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt:
- fast/loader/stateobjects/replacestate-frequency-iframe.html:
- 12:29 PM Changeset in webkit [195686] by
-
- 12 edits1 copy1 add in trunk
Add API to access closed shadowRoot in InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=153533
Reviewed by Antti Koivisto.
Source/WebCore:
Always return the shadow root in Element.shadowRootForBindings when the DOM wrapper world has
shadowRootIsAlwaysOpen set to true. Also renamed bindingShadowRoot to shadowRootForBindings
to be consistent.
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::setShadowRootIsAlwaysOpen): Added.
(WebCore::DOMWrapperWorld::shadowRootIsAlwaysOpen): Added.
- dom/Element.cpp:
(WebCore::Element::shadowRootForBindings): Renamed from bindingShadowRoot.
- dom/Element.h:
- dom/Element.idl:
Source/WebKit2:
Added WKBundleScriptWorldMakeAllShadowRootsOpen to make all shadow roots open.
This is needed to keep supporting certain browser-level features such as autofill.
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldMakeAllShadowRootsOpen): Added.
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::makeAllShadowRootsOpen): Added.
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
Tools:
Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
(TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
(TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
- 12:24 PM Changeset in webkit [195685] by
-
- 23 edits4 adds in trunk
Need ability to specify alternate image for AutoFill button in input fields.
https://bugs.webkit.org/show_bug.cgi?id=153116.
rdar://problem/23384854.
Patch by Zhuo Li <zachli@apple.com> on 2016-01-27
Reviewed by Darin Adler.
Source/WebCore:
Add a new AutoFill button that can be shown in <input> elements.
Tests: fast/forms/auto-fill-button/input-contacts-auto-fill-button.html
fast/forms/auto-fill-button/show-correct-auto-fill-button-when-auto-fill-button-type-changes.html
- css/html.css:
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-contacts-auto-fill-button:hover):
(input::-webkit-contacts-auto-fill-button:active):
Add default style rules for the Contacts AutoFill button based on the ones used for
Manual AutoFill button.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setShowAutoFillButton):
- html/HTMLInputElement.h:
(WebCore::HTMLInputElement::autoFillButtonType):
- Replace the boolean parameter with a new parameter to specify the type of the AutoFill button.
- Declare a private variable to keep a record of the type of the current AutoFill
button.
(WebCore::HTMLInputElement::showAutoFillButton): Deleted.
- html/HTMLTextFormControlElement.h:
Declare enum for AutoFill button type.
- html/TextFieldInputType.cpp:
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
(WebCore::TextFieldInputType::shouldDrawAutoFillButton): None means the AutoFill button is not
enabled.
(WebCore::TextFieldInputType::createAutoFillButton): Only create the AutoFill button
if the type is expected.
(WebCore::TextFieldInputType::updateAutoFillButton):
Handle the case where AutoFill button type changes in the text field.
- html/TextFieldInputType.h:
- testing/Internals.cpp:
(WebCore::stringToAutoFillButtonType): Convert the string to AutoFill button type.
(WebCore::Internals::setShowAutoFillButton): Add a new parameter to specify the type of the AutoFill button.
- testing/Internals.h: Ditto.
- testing/Internals.idl: Ditto.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(toAutoFillButtonType): Convert the WebKit AutoFill button type enum to WebCore AutoFill button
type enum.
(WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabledWithButtonType): Added to be able to specify
what the AutoFill button type is. None means the AutoFill button is not shown.
(WKBundleNodeHandleSetHTMLInputElementAutoFillButtonEnabled): Deprecate this method.
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Declare an AutoFill button type enum.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutoFillButtonEnabled): None means the AutoFill button is not enabled.
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutoFillButtonEnabledWithButtonType): Use the new parameter to specify
what the AutoFill button type is.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
LayoutTests:
- fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-disabled.html: The test API has
another parameter to specify what type the AutoFill button is.
- fast/forms/auto-fill-button/hide-auto-fill-button-when-input-becomes-readonly.html: Ditto.
- fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
- fast/forms/auto-fill-button/input-contacts-auto-fill-button.html: Added.
- fast/forms/auto-fill-button/input-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/input-disabled-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/input-readonly-non-empty-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/mouse-down-input-mouse-release-auto-fill-button.html: Ditto.
- fast/forms/auto-fill-button/show-correct-auto-fill-button-when-auto-fill-button-type-changes-expected.html: Added.
- fast/forms/auto-fill-button/show-correct-auto-fill-button-when-auto-fill-button-type-changes.html: Added.
- 12:12 PM Changeset in webkit [195684] by
-
- 2 edits in trunk/Source/WebKit
[Win] Clean build fix after r195680.
- PlatformWin.cmake:
Use the post build command for the post build event.
- 12:10 PM Changeset in webkit [195683] by
-
- 2 edits in trunk/Source/JavaScriptCore
Air::TmpWidth uses a stale pointer into its HashMap after it calls add()
https://bugs.webkit.org/show_bug.cgi?id=153546
Reviewed by Saam Barati.
- b3/air/AirTmpWidth.cpp:
(JSC::B3::Air::TmpWidth::recompute):
- 12:09 PM Changeset in webkit [195682] by
-
- 4 edits2 adds in trunk
Add Node.treeRoot
https://bugs.webkit.org/show_bug.cgi?id=153537
Reviewed by Antti Koivisto.
Source/WebCore:
Exposed highestAncestor as Node.prototype.treeRoot, which was added to shadow DOM spec in
https://github.com/w3c/webcomponents/commit/6864a40fe4efa8a737e78512e3c85319ddc5bf8b
See also:
http://w3c.github.io/webcomponents/spec/shadow/#extensions-to-node-interface
Test: fast/shadow-dom/Node-interface-treeRoot.html
- dom/Node.idl:
LayoutTests:
Added a testharness.js test for Node.treeRoot. Also rebaselined a test.
- js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaselined.
- fast/shadow-dom/Node-interface-treeRoot-expected.txt: Added.
- fast/shadow-dom/Node-interface-treeRoot.html: Added.
- 12:08 PM Changeset in webkit [195681] by
-
- 6 edits in trunk
Rename HTMLSlotElement.getDistributedNodes to getAssignedNodes
https://bugs.webkit.org/show_bug.cgi?id=153534
Reviewed by Antti Koivisto.
Source/WebCore:
Did the rename.
- html/HTMLSlotElement.idl:
LayoutTests:
Updated the tests to refect the rename. Also added test cases after r192763
to assert we don't assign comment and processing instruction nodes to a slot.
- fast/shadow-dom/HTMLSlotElement-interface-expected.txt:
- fast/shadow-dom/HTMLSlotElement-interface.html:
- fast/shadow-dom/NonDocumentTypeChildNode-interface-assignedSlot.html:
- 12:00 PM Changeset in webkit [195680] by
-
- 2 edits in trunk/Source/WebKit
Fix Win EWS after r195545.
https://bugs.webkit.org/show_bug.cgi?id=153434
- PlatformWin.cmake:
Copy WebKit.h after building WebKitGUID, because it doesn't exist before.
This should fix EWS problems like the one seen in bug 153522.
- 11:54 AM Changeset in webkit [195679] by
-
- 3 edits in trunk/Tools
Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
https://bugs.webkit.org/show_bug.cgi?id=153332
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._xmlTimelineURL): Uses new function.
(Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
logic for parsing git hashes.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
Trac._parseRevisionFromURL.
- 11:11 AM Changeset in webkit [195678] by
-
- 7 edits4 adds in trunk
Need to be able to specify MIME type for <attachment> without filename or handle
https://bugs.webkit.org/show_bug.cgi?id=153552
<rdar://problem/20145857>
Reviewed by Anders Carlsson.
Tests: fast/attachment/attachment-default-icon.html
fast/attachment/attachment-type-attribute.html
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::parseAttribute):
Invalidate attachment when 'type' attribute changes.
(WebCore::HTMLAttachmentElement::attachmentType):
- html/HTMLAttachmentElement.h:
- platform/graphics/Icon.h:
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::createIconForUTI):
(WebCore::Icon::createIconForMIMEType):
Add Icon class methods to retrieve an icon given a UTI or MIME type.
- rendering/RenderThemeMac.mm:
(WebCore::paintAttachmentIcon):
Use the 'type' attribute (a MIME type) if we have one. Otherwise,
use the filename. Lastly fall back to a plain file icon (using the root
file UTI, public.data).
- fast/attachment/attachment-default-icon-expected.html: Added.
- fast/attachment/attachment-default-icon.html: Added.
- fast/attachment/attachment-type-attribute-expected.html: Added.
- fast/attachment/attachment-type-attribute.html: Added.
Add some tests.
- 10:38 AM Changeset in webkit [195677] by
-
- 2 edits in trunk/Source/WebKit2
More trying to fix the build.
- Configurations/WebKit.xcconfig:
- 10:34 AM Changeset in webkit [195676] by
-
- 3 edits in trunk/Tools
Remove Mavericks from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=153521
Reviewed by Dan Bernstein.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 10:24 AM Changeset in webkit [195675] by
-
- 20 edits in trunk
Remove ENABLE_CURRENTSRC
https://bugs.webkit.org/show_bug.cgi?id=153545
Reviewed by Simon Fraser.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 10:23 AM Changeset in webkit [195674] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the build.
- Configurations/WebKit.xcconfig:
- 8:57 AM Changeset in webkit [195673] by
-
- 2 edits in trunk/Source/WebCore
Stop echoing echo commands to stdout
https://bugs.webkit.org/show_bug.cgi?id=153531
Reviewed by Csaba Osztrogonác.
- DerivedSources.make:
- 7:35 AM Changeset in webkit [195672] by
-
- 1 edit3 adds in trunk/LayoutTests
[GTK] Problem running promises code in workers
https://bugs.webkit.org/show_bug.cgi?id=152340
Reviewed by Carlos Garcia Campos.
Test file that creates two testharness promise tests. Each test creates 10000 promises, pushes them into an
array and vends them in a timeout.
- js/promises-tests/promises-in-workers-expected.txt: Added.
- js/promises-tests/promises-in-workers.html: Added.
- js/promises-tests/promises-in-workers.js: Added.
- 7:20 AM Changeset in webkit [195671] by
-
- 3 edits2 adds in trunk
Calling video.controls=true during a scrub operation cancels scrub.
https://bugs.webkit.org/show_bug.cgi?id=153494
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-controls-drag-timeline-set-controls-property.html
Verify that the video.controls attribute actually changed before tearing down and
re-adding the media controls to the Shadow DOM.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleControlsChange):
(Controller.prototype.hasControls):
LayoutTests:
- media/media-controls-drag-timeline-set-controls-property-expected.txt: Added.
- media/media-controls-drag-timeline-set-controls-property.html: Added.
- 6:34 AM Changeset in webkit [195670] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.6
WebKitGTK+ 2.10.6
- 6:30 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 6:17 AM Changeset in webkit [195669] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.6 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.6
- 5:40 AM Changeset in webkit [195668] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195586 - [GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Source/WebKit2:
Do not allow different DnD operations over the same element at the
same time, so that any new attempt to DnD an element happening before
a previous attempt has ended will take precedence, cancelling the older
operation before going ahead with the new one.
This is consistent with how WebCore::EventHandler handles DnD operations,
preventing the web process from crashing in scenarios where the user might
try to perform many DnD operations over the same element very quickly.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler): Initialized new member.
(WebKit::DragAndDropHandler::startDrag): Ensure a previous DnD operation
is cancelled before handling the new one that has just started.
(WebKit::DragAndDropHandler::fillDragData): Protect against calling this
function from webkitWebViewBaseDragDataGet for already cancelled operations.
(WebKit::DragAndDropHandler::finishDrag): Protect against calling this
function from webkitWebViewBaseDragEnd for already cancelled operations.
- UIProcess/gtk/DragAndDropHandler.h:
LayoutTests:
New test added to check that the web process does not crash when multiple
DnD operations are quickly attempted over the same draggable element.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt: Added.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html: Added.
Added the new test to the failure expectations for mac-wk2, as there's no
suitable implementation of eventSender in place yet (see bug 42194).
- platform/mac-wk2/TestExpectations: Added failure expectation for the new test.
- 5:33 AM Changeset in webkit [195667] by
-
- 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195537 - REGRESSION(r192773): [GTK] maps.google.com unresponsive/stalls since r192773
https://bugs.webkit.org/show_bug.cgi?id=153194
Reviewed by Michael Catanzaro.
In r192773 we implemented the JavaScriptCore garbage collector
timers for the GTK+ port. Those timers schedule sources in the
current thread default main context, but JS web worker threads
implementation doesn't use WTF::RunLoop, but its own WorkerRunLoop
class that doesn't create a GMainContext for the new thread. This
means that for web sites using workers, we are now doing garbage
collection of worker VMs in the main thread which ends up in a
deadlock at some point. We need to ensure that worker threads
create a GMainContext and push it as the default one for the
thread before the WorkerGlobalScope is created. This way when the
worker Heap is created, the GC timers use the right context to
schedule their sources. And then we need to check if there are
sources pending in the thread main context on every worker run
loop iteration.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- 5:31 AM Changeset in webkit [195666] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195511 - [GTK] Fix media controls displaying without controls attribute
https://bugs.webkit.org/show_bug.cgi?id=152500
Media controls is not displayed without controls attribute by default
when the video element has text track. It'll be displayed on fullscreen
regardless of controls attribute.
Patch by Wonchul Lee <wonchul.lee@collabora.co.uk> on 2016-01-23
Reviewed by Michael Catanzaro.
Source/WebCore:
- Modules/mediacontrols/mediaControlsGtk.js:
(ControllerGtk.prototype.shouldHaveControls):
(ControllerGtk.prototype.reconnectControls):
(ControllerGtk.prototype.removeControls):
(ControllerGtk.prototype.configureControls): Deleted.
LayoutTests:
- media/video-controls-no-display-with-text-track-expected.txt: Added.
- media/video-controls-no-display-with-text-track.html: Added.
- 5:23 AM Changeset in webkit [195665] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195453 - Elements with overflow and border-radius don't show in multicolumn properly.
https://bugs.webkit.org/show_bug.cgi?id=152920
Reviewed by Simon Fraser.
Source/WebCore:
Added new test in fast/multicol.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToLayerCoords):
(WebCore::RenderLayer::offsetFromAncestor):
(WebCore::RenderLayer::clipToRect):
- rendering/RenderLayer.h:
Make sure the crawl up the containing block chain to apply clips properly offsets
to account for columns. convertToLayerCoords could already handle this, so
offsetFromAncestor now takes the same extra argument (whether or not to adjust for
columns) that convertToLayerCoords does.
LayoutTests:
- fast/multicol/border-radius-overflow-columns-expected.html: Added.
- fast/multicol/border-radius-overflow-columns.html: Added.
- 5:21 AM Changeset in webkit [195664] by
-
- 9 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195445 - REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
https://bugs.webkit.org/show_bug.cgi?id=136019
Reviewed by Dan Bernstein.
Source/WebCore:
In horizontal-bt documents (where the page starts scrolled to the bottom, and scrolling up goes into negative scroll positions),
the position of the root content layer would be set incorrectly by the scrolling thread, resulting in misplaced
content.
Fix by having the renamed "yPositionForRootContentLayer" take scroll origin into
account, and being more consistent about using scrollOrigin to position this layer.
Test: fast/scrolling/programmatic-horizontal-bt-document-scroll.html
- page/FrameView.cpp:
(WebCore::FrameView::yPositionForFooterLayer): Moved
(WebCore::FrameView::positionForRootContentLayer): Take scrollOrigin, and subtract it from the computed value.
(WebCore::FrameView::yPositionForRootContentLayer): Renamed.
- page/FrameView.h:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll): We've already pushed the new scrollPosition onto the FrameView,
so we can just use the member function to compute the positionForContentsLayer.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): This is the bug fix; FrameView::positionForRootContentLayer()
now takes scrollOrigin into account.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Rather than using the documentRect, position the root content layer
in terms of the scroll origin (which is -documentRect.location()).
Source/WebKit2:
Now call frameView.positionForRootContentLayer(), and add a FIXME questioning the
behavior in horizontal b-t documents. However, this code isn't hit now that we always
do extended backgrounds, so never have shadow layers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::shadowLayerPositionForFrame):
LayoutTests:
Test that scrolls a horizontal-bt document.
- fast/scrolling/programmatic-horizontal-bt-document-scroll-expected.html: Added.
- fast/scrolling/programmatic-horizontal-bt-document-scroll.html: Added.
- 4:34 AM Changeset in webkit [195663] by
-
- 13 edits4 adds in releases/WebKitGTK/webkit-2.10
Merge r195411 - A crash reproducible in Path::isEmpty() under RenderSVGShape::paint()
https://bugs.webkit.org/show_bug.cgi?id=149613
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-21
Reviewed by Darin Adler.
Source/WebCore:
When RenderSVGRoot::layout() realizes its layout size has changed and
it has resources which have relative sizes, it marks all the clients of
the resources for invalidates regardless whether they belong to the
same RenderSVGRoot or not. But it reruns the layout only for its children.
If one of these clients comes before the current RenderSVGRoot in the render
tree, ee end up having renderer marked for invalidation at rendering time.
This also prevents scheduling the layout if the same renderer is marked
for another invalidation later. We prevent this because we do not want
to schedule another layout for a renderer which is already marked for
invalidation. This can cause crash if the renderer is an RenderSVGPath.
The fix is to mark "only" the clients of a resource which belong to the
same RenderSVGRoot of the resource. Also we need to run the layout for
all the resources which belong to different RenderSVGRoots before running
the layout for an SVG renderer.
Tests: svg/custom/filter-update-different-root.html
svg/custom/pattern-update-different-root.html
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
We should not mark any client outside the current root for invalidation
- rendering/svg/RenderSVGResourceContainer.h: Remove unneeded private keyword.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
Code clean up; use findTreeRootObject() instead of repeating the same code.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::isEmpty): Avoid crashing if RenderSVGShape::isEmpty()
is called before calling RenderSVGShape::layout().
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout): findTreeRootObject() now returns a pointer.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::findTreeRootObject): I do think nothing
guarantees that an SVG renderer has to have an RenderSVGRoot in its
ancestors. So change this function to return a pointer. Also Provide
the non-const version of this function.
(WebCore::SVGRenderSupport::layoutDifferentRootIfNeeded): Runs the layout
if needed for all the resources which belong to different RenderSVGRoots.
(WebCore::SVGRenderSupport::layoutChildren): Make sure all the renderer's
resources which belong to different RenderSVGRoots are laid out before
running the layout for this renderer.
- rendering/svg/SVGRenderSupport.h: Remove a mysterious comment.
- rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::layoutDifferentRootIfNeeded): Run the layout for
all the resources which belong to different RenderSVGRoots outside the
context of their RenderSVGRoots.
- rendering/svg/SVGResources.h:
(WebCore::SVGResources::clipper):
(WebCore::SVGResources::markerStart):
(WebCore::SVGResources::markerMid):
(WebCore::SVGResources::markerEnd):
(WebCore::SVGResources::masker):
(WebCore::SVGResources::filter):
(WebCore::SVGResources::fill):
(WebCore::SVGResources::stroke):
Code clean up; use nullptr instead of 0.
LayoutTests:
When running the layout of an SVG root and it has resources which are
referenced by clients in other SVG roots, make sure we run the layout
for these resources before running the layout for their clients.
- svg/custom/filter-update-different-root-expected.html: Added.
- svg/custom/filter-update-different-root.html: Added.
Without this patch this test crashes because we paint a dirty RenderSVGShape.
- svg/custom/pattern-update-different-root-expected.html: Added.
- svg/custom/pattern-update-different-root.html: Added.
Without this patch this test works fine but it is good to have it to catch
cases where the SVG root needs to run re-layout for its children resources
and hence their clients if its size has changed.
- svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt:
- svg/custom/unicode-in-tspan-multi-svg-crash.html:
This test was ported from Blink in http://trac.webkit.org/changeset/166420.
The expectation of this test was changed in Blink:
https://src.chromium.org/viewvc/blink?revision=158480&view=revision.
- 4:28 AM Changeset in webkit [195662] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.10
Merge r195397 - http://victordarras.fr/cssgame/ doesn't work in Safari.
https://bugs.webkit.org/show_bug.cgi?id=153285
<rdar://problem/24212369>
Reviewed by Tim Horton.
This patch adds support for hittesting ClipPathOperation::Reference.
Source/WebCore:
Tests: svg/clip-path/hittest-clip-path-reference-miss.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceClipper):
- rendering/svg/RenderSVGResourceClipper.h:
(isType):
LayoutTests:
- svg/clip-path/hittest-clip-path-reference-miss-expected.html: Added.
- svg/clip-path/hittest-clip-path-reference-miss.html: Added.
- 2:32 AM Changeset in webkit [195661] by
-
- 6 edits5 adds2 deletes in trunk/Source/WebCore
[GTK][EFL] Rename ScrollAnimationNone as ScrollAnimationSmooth
https://bugs.webkit.org/show_bug.cgi?id=153481
Reviewed by Simon Fraser.
ScrollAnimationNone has always been used by EFL and GTK ports to
implement smooth scrolling. I think it should be possible for
other scroll animators to implement smooth scrolling or even
implement other kind of scroll animations. For example, in the
future I would like to have kinetic scrolling implemented for the
GTK+ port to match all other GTK+ application and decide at
runtime between different animations without having to use a
different scroll animator class. So, this patch also moves the
smooth scrolling animation implementation to its own class
ScrollAnimationSmooth that impements an interface ScrollAnimation
that could be used to implement other animations. This will allow
the GTK+ port to add its own scroll animator class and still
support smooth scrolling sharing the code with the
ScrollAnimationSmooth.
- PlatformEfl.cmake: Add new files to compilation and remove ScrollAnimationNone.
- PlatformGTK.cmake: Ditto.
- platform/ScrollAnimation.h: Added.
(WebCore::ScrollAnimation::serviceAnimation):
(WebCore::ScrollAnimation::ScrollAnimation):
- platform/ScrollAnimationSmooth.cpp: Added.
(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::scroll):
(WebCore::ScrollAnimationSmooth::stop):
(WebCore::ScrollAnimationSmooth::updateVisibleLengths):
(WebCore::ScrollAnimationSmooth::setCurrentPosition):
(WebCore::ScrollAnimationSmooth::serviceAnimation):
(WebCore::ScrollAnimationSmooth::~ScrollAnimationSmooth):
(WebCore::curveAt):
(WebCore::attackCurve):
(WebCore::releaseCurve):
(WebCore::coastCurve):
(WebCore::curveIntegralAt):
(WebCore::attackArea):
(WebCore::releaseArea):
(WebCore::getAnimationParametersForGranularity):
(WebCore::ScrollAnimationSmooth::updatePerAxisData):
(WebCore::ScrollAnimationSmooth::animateScroll):
(WebCore::ScrollAnimationSmooth::animationTimerFired):
(WebCore::ScrollAnimationSmooth::startNextTimer):
(WebCore::ScrollAnimationSmooth::animationTimerActive):
- platform/ScrollAnimationSmooth.h: Added.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::setCurrentPosition):
(WebCore::ScrollAnimator::updateActiveScrollSnapIndexForOffset):
(WebCore::ScrollAnimator::notifyPositionChanged):
(WebCore::ScrollAnimator::scrollOffsetOnAxis):
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::ScrollAnimator::currentPosition):
- platform/ScrollAnimatorNone.cpp: Removed.
- platform/ScrollAnimatorNone.h: Removed.
- platform/ScrollAnimatorSmooth.cpp: Added.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorSmooth::ScrollAnimatorSmooth):
(WebCore::ScrollAnimatorSmooth::~ScrollAnimatorSmooth):
(WebCore::ScrollAnimatorSmooth::scroll):
(WebCore::ScrollAnimatorSmooth::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorSmooth::cancelAnimations):
(WebCore::ScrollAnimatorSmooth::serviceScrollAnimations):
(WebCore::ScrollAnimatorSmooth::willEndLiveResize):
(WebCore::ScrollAnimatorSmooth::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorSmooth::didAddHorizontalScrollbar):
- platform/ScrollAnimatorSmooth.h: Added.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPosition):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
- 2:28 AM Changeset in webkit [195660] by
-
- 3 edits in trunk/Source/WebCore
Overlay scrollbars should always use the whole contents
https://bugs.webkit.org/show_bug.cgi?id=153352
Reviewed by Michael Catanzaro.
In case of having both horizontal and vertical scrollbars, the
scrollbars respect the scroll corner. That looks good for legacy
scrollbars that show the track, but with the overlay indicators
it looks weird that the indicator stops so early before the end of
the contents, giving the impression that there's something else to
scroll. This happens because the scroll corner is transparent, so
it's not obvious that's the scroll corner. It also happens with
the text areas having a resizer. Legacy scrollbars take into
account the resizer, which is good, but I expect overlay
scrollbars to be rendered also over the resizer. The resizer takes
precedence so you can still click and drag to resize the text area.
In the case of main frame scrollbars we are indeed returning an
empty rectangle from ScrollView::scrollCornerRect() when using
overlay scrollbars, but when calculating the size of the
scrollbars we are using the actual width/height instead of the
occupied with/height. For other scrollbars
RenderLayer::scrollCornerRect() is not checking whether scrollbars
are overlay or not and we are always returning a scroll corner
rectangle when scrollbars are present.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Use the occupied
width/height when calculating the space the one scrollbar
should leave for the other.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollCornerRect): Return an empty
rectangle when using overlay scrollbars.
- 2:24 AM Changeset in webkit [195659] by
-
- 2 edits in trunk/Source/WebCore
ScrollAnimator is not notified when mouse entered, moved or exited a RenderListBox
https://bugs.webkit.org/show_bug.cgi?id=153398
Reviewed by Michael Catanzaro.
EvenHandler is checking whether the enclosing layer of a node is
registered as scrollable area of its frame view. That doesn't work
for list boxes, because they are the scrollable area
themselves. Also when entering a list box the node under mouse is
not usually the list box itself, but any of its children, a
HTMLOptionElement or a HTMLOptGroupElement. Instead of comparing
layers, we should find the enclosing scrollable area of the target
elements and compare them to decide whether the mouse has entered,
left or moved a scrollable area.
- page/EventHandler.cpp:
(WebCore::enclosingScrollableArea): Return the enclosing
scrollable area of the given node. If the node doesn't have a
renderer, it traverses its parents. If the renderer is a
RenderListBox it is returned, otherwhise the enclosing layer is
returned.
(WebCore::EventHandler::mouseMoved): Use enclosingScrollableArea.
(WebCore::EventHandler::updateMouseEventTargetNode): Ditto.
Jan 26, 2016:
- 11:43 PM Changeset in webkit [195658] by
-
- 4 edits1 add in trunk/Tools
Sort incoming commits via date instead of revision number.
https://bugs.webkit.org/show_bug.cgi?id=153467
Reviewed by Alexey Proskuryakov.
Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
for sorting revisions. Instead we use the commit date to sort revisions chronologically.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._loaded): Sort via date instead of revision number.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
(MockTrac): Fix up the mock data to look more like real-world data.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
Fake RSS feed that adds three more commits.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
Trac._loaded().
- 11:13 PM Changeset in webkit [195657] by
-
- 2 edits in trunk/Source/WebKit2
Attempt to force a rebuild.
- DerivedSources.make:
- 10:39 PM Changeset in webkit [195656] by
-
- 3 edits in trunk/Source/WebCore
Try touching DerivedSources.make to force rebuilding.
- DerivedSources.make:
- page/DOMWindow.idl:
- 10:27 PM Changeset in webkit [195655] by
-
- 2 edits in trunk/Source/WebCore
Try to force a rebuild.
- page/DOMWindow.idl:
- 10:10 PM Changeset in webkit [195654] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] When lowering B3 to Air, preferRightForResult() should prefer values from the same block
https://bugs.webkit.org/show_bug.cgi?id=153477
Reviewed by Filip Pizlo.
In cases like this:
Block #0
@1 = something
@2 = Jump #1
Block #1
@3 = something else
@4 = Add(@3, @1)
...
@42 = Branch(@x, #1, #2)
B3LowerToAir would pick @1 for the argument copied
for what goes into the UseDef side of Add.
This created a bunch of moves that could never be coalesced.
In Kraken's imaging-desaturate, there were enough Moves to slow
down the hot loop.
Ideally, we should not use UseCount for lowering. We should use
the real liveness for preferRightForResult(), and a loop-weighted
use-count for effective addresses. The problem is keeping the cost
low for those simple helpers.
In this patch, I went with a simple heuristic: prioritize the value
defined in the same block for UseDef.
There is one other way that would be cheap but a bit invasive:
-Get rid of UseDef.
-Make every ops, 3 operands.
-Tell the register allocator to attempt aliasing of the 2 uses
with the def.
-If the allocator fails, just add a move as needed.
For now, the simple heuristic seems okay for the cases have.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::preferRightForResult):
- 7:49 PM Changeset in webkit [195653] by
-
- 2 edits in trunk/Source/JavaScriptCore
Tail duplication should break critical edges first
https://bugs.webkit.org/show_bug.cgi?id=153530
Reviewed by Benjamin Poulain.
This speeds up Octane/boyer.
- b3/B3DuplicateTails.cpp:
- 7:45 PM Changeset in webkit [195652] by
-
- 5 edits in trunk
fast/history/page-cache-webdatabase-no-transaction-db.html flakily crashes
https://bugs.webkit.org/show_bug.cgi?id=153525
Reviewed by Andreas Kling.
Source/WebCore:
The test was crashing because DatabaseThread::hasPendingDatabaseActivity()
was accessing m_openDatabaseSet from the main thread without any locking
mechanism. This is an issue because m_openDatabaseSet is altered by the
database thread.
No new tests, already covered by fast/history/page-cache-webdatabase-no-transaction-db.html.
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::DatabaseThread::hasPendingDatabaseActivity):
- Modules/webdatabase/DatabaseThread.h:
LayoutTests:
Unskip fast/history/page-cache-webdatabase-no-transaction-db.html now
that it no longer crashes.
- 7:16 PM Changeset in webkit [195651] by
-
- 5 edits in trunk/Source/WebKit2
REGRESSION (r194557): Keyboard shortcuts stop working after the WKWebView is unparented and reparented
https://bugs.webkit.org/show_bug.cgi?id=153492
<rdar://problem/24138989>
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canBecomeFirstResponder]):
(-[WKContentView becomeFirstResponder]):
(-[WKContentView resignFirstResponder]):
When WKWebView is unparented, WKContentView will attempt to resignFirstResponder upwards,
first asking WKWebView. After r194557, WKWebView will accept first responder and forward
it on to the WKContentView, which will happily accept it again, despite being the view
that's trying to resign. This will cause us to completely lose first responder,
where it was actually supposed to propagate up above WKWebView to the client.
Keep track of when WKContentView is resigning first responder, and don't
let it become first responder while it is doing so, breaking the cycle.
- UIProcess/ios/WKContentView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView canBecomeFirstResponder]):
If the WKContentView is currently in the process of resigning first responder status,
we shouldn't accept it, because clients expect to receive it.
- 7:05 PM Changeset in webkit [195650] by
-
- 10 edits1 add in trunk
Source/WebKit2:
Implement wildcard matching for plug-in policy host.
https://bugs.webkit.org/show_bug.cgi?id=153090
Patch by I-Ting Liu <iting_liu@apple.com> on 2016-01-26
Reviewed by Darin Adler.
WebPlatformStrategies decides the plug-in load policy for a host by looking
for a matched hostname in the list of plug-in policies sent by Safari. This
patch adds support for wildcard matching -- if there's a policy with hostname
"*.example.com," the policy for "foo.example.com" would be replaced with that
of "*.example.com" if there's no policy for this hostname. If there is more
than one wildcard hostname, the host with the longest wildcard hostname will
be used.
This patch adds a helper function in StringUtilites that matches a string to
another string, which may contain wildcard ('*') characters.
- Platform/mac/StringUtilities.h:
- Add WebKit::stringMatchesWildcardString.
- Remove #if ENABLE(TELEPHONE_NUMBER_DETECTION) && PLATFORM(MAC) flag so that
the compiler allows exposing StringUtilities.h.
- Add #if OBJC to allow the file to be included in WebPltformStrategies.cpp
- Platform/mac/StringUtilities.mm:
(WebKit::stringMatchesWildcardString):
Return true if the entire first given String matches the second. The second string
may contain wildcard characters.
(WebKit::wildcardRegexPatternString):
Return the regex expression from a wildcard string by replacing the wildcard
character ('*') with (".*") and escaping regular expression metacharacters.
(WebKit::formattedPhoneNumberString):
To expose StringUtilities.h for tests, we removed #if ENABLE(TELEPHONE_NUMBER_DETECTION)
&& PLATFORM(MAC) flag in the header. Add a function that returns nil for
#if !(ENABLE(TELEPHONE_NUMBER_DETECTION) && PLATFORM(MAC)) to fix the removal
of the flag in the header file.
- WebKit2.xcodeproj/project.pbxproj:
Change the file attribute of StringUtilities.h from Project to Private for
testing in TestWebKitAPI.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::longestMatchedWildcardHostForHost):
Return the wildcard hostname whose matched substring with the host is the longest.
(WebKit::WebPlatformStrategies::replaceHostWithMatchedWildcardHost):
Replace the look-up host with a matched wildcard host if there is a match and that
the matched wildcard host's plug-in identifier is the same as that of the host.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost):
Try to replace the look-up host with the wildcard host if there's no policy for
the host. Restructure the function to reduce hashmap lookup.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Declare the methods.
Source/WTF:
Implement wildcard matching for plug-in policy host.
https://bugs.webkit.org/show_bug.cgi?id=153090
Patch by I-Ting Liu <iting_liu@apple.com> on 2016-01-26
Reviewed by Darin Adler.
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
Add bridge to allow compilation.
Tools:
Add a test for WebKit::stringMatchesWildcardString.
https://bugs.webkit.org/show_bug.cgi?id=153090
Patch by I-Ting Liu <iting_liu@apple.com> on 2016-01-26
Reviewed by Darin Adler.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add the file to the project.
- TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
(TestWebKitAPI::TEST):
Test that a string matches another string that may contain wildcard characters.
- 6:41 PM Changeset in webkit [195649] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed CMake build fix after r195644.
- PlatformMac.cmake:
- 6:25 PM Changeset in webkit [195648] by
-
- 5 edits in trunk
Modern IDB: Key generator support for SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153427
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Existing failing tests now pass, others improved).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 6:16 PM Changeset in webkit [195647] by
-
- 2 edits in trunk/Source/WebKit2
Remove -d flag from make invocation.
- WebKit2.xcodeproj/project.pbxproj:
- 5:53 PM Changeset in webkit [195646] by
-
- 8 edits2 adds in trunk
Allow canvas to use display-list drawing for testing
https://bugs.webkit.org/show_bug.cgi?id=153475
Reviewed by Dean Jackson.
Source/WebCore:
Optionally have 2D <canvas> use display-list drawing, which is only enabled
via Internals for now.
Support displayListAsText() and replayDisplayListAsText() on canvas, so we can
use it to test playback optimizations. [Note that displayListAsText() always
returns an empty string currently, because the display list is cleared when the
canvas is painted to the page.]
Display list rendering is implemented by giving CanvasRenderingContext2D an
optional DisplayListDrawingContext, which packages up a display list, recorder
and recording context. The existing paintRenderingResultsToCanvas() is overridden
to replay the recorded display list into the primary canvas context.
Tracked replay display lists are stored in a static map, keyed by the CanvasRenderingContext2D.
Test: displaylists/canvas-display-list.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::setUsesDisplayListDrawing):
(WebCore::HTMLCanvasElement::setTracksDisplayListReplay):
(WebCore::HTMLCanvasElement::displayListAsText):
(WebCore::HTMLCanvasElement::replayDisplayListAsText):
- html/HTMLCanvasElement.h:
- html/canvas/CanvasRenderingContext.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::DisplayListDrawingContext::DisplayListDrawingContext):
(WebCore::contextDisplayListMap):
(WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::setTracksDisplayListReplay):
(WebCore::CanvasRenderingContext2D::displayListAsText):
(WebCore::CanvasRenderingContext2D::replayDisplayListAsText):
(WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
(WebCore::CanvasRenderingContext2D::drawingContext):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Deleted.
- html/canvas/CanvasRenderingContext2D.h:
- testing/Internals.cpp:
(WebCore::Internals::setElementUsesDisplayListDrawing):
(WebCore::Internals::setElementTracksDisplayListReplay):
(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
LayoutTests:
Simple canvas-based display list test.
- displaylists/canvas-display-list-expected.txt: Added.
- displaylists/canvas-display-list.html: Added.
- 5:31 PM Changeset in webkit [195645] by
-
- 2 edits4 deletes in trunk/Source/WebInspectorUI
Web Inspector: Remove unused FramesLarge.png variants, only the smaller Frames icon is used for the Rendering Frames timeline
https://bugs.webkit.org/show_bug.cgi?id=153523
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-26
Reviewed by Timothy Hatcher.
- UserInterface/Images/FramesLarge.png: Removed.
- UserInterface/Images/FramesLarge@2x.png: Removed.
- UserInterface/Images/gtk/FramesLarge.png: Removed.
- UserInterface/Images/gtk/FramesLarge@2x.png: Removed.
- UserInterface/Views/TimelineIcons.css:
(.rendering-frame-icon.large .icon): Deleted.
- 5:29 PM Changeset in webkit [195644] by
-
- 19 edits5 adds in trunk/Source
Generalize ResourceUsageData gathering to be used outside of ResourceUsageOverlay
https://bugs.webkit.org/show_bug.cgi?id=153509
<rdar://problem/24354291>
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::didAllocateBlock):
(JSC::Heap::didFreeBlock):
Rename the ENABLE flag.
Source/WebCore:
- CMakeLists.txt:
- PlatformMac.cmake:
- WebCore.xcodeproj/project.pbxproj:
- page/Page.cpp:
- page/Page.h:
- page/Settings.cpp:
- page/Settings.h:
- page/ResourceUsageOverlay.cpp:
- page/ResourceUsageOverlay.h:
Add new files to the build and updated ENABLE flag name.
- page/ResourceUsageData.cpp: Added.
(WebCore::ResourceUsageData::ResourceUsageData):
- page/ResourceUsageData.h: Added.
(WebCore::MemoryCategoryInfo::MemoryCategoryInfo):
Platform agnostic resource data that may be used by multiple clients,
such as the ResourceUsageOverlay and later the Inspector.
- page/ResourceUsageThread.h: Added.
- page/ResourceUsageThread.cpp: Added.
(WebCore::ResourceUsageThread::ResourceUsageThread):
(WebCore::ResourceUsageThread::singleton):
(WebCore::ResourceUsageThread::addObserver):
(WebCore::ResourceUsageThread::removeObserver):
(WebCore::ResourceUsageThread::waitUntilObservers):
(WebCore::ResourceUsageThread::notifyObservers):
(WebCore::ResourceUsageThread::createThreadIfNeeded):
(WebCore::ResourceUsageThread::threadCallback):
(WebCore::ResourceUsageThread::threadBody):
Platform agnostic resource usage thread that can be used to gather data
into a ResourceUsageData struct on a background thread and notify observers
on the main thread. Platforms need only implement ResourceUsageThread::platformThreadBody
to populate the ResourceUsageData struct with data.
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::HistoricMemoryCategoryInfo::HistoricMemoryCategoryInfo):
(WebCore::HistoricResourceUsageData::HistoricResourceUsageData):
(WebCore::historicUsageData):
(WebCore::appendDataToHistory):
(WebCore::ResourceUsageOverlay::platformInitialize):
(WebCore::ResourceUsageOverlay::platformDestroy):
(WebCore::drawMemHistory):
(WebCore::drawMemoryPie):
(WebCore::ResourceUsageOverlay::platformDraw):
Move CPU and memory resource usage calculations to ResourceUsageThread.
The overlay adds itself as an observer, and builds its RingBuffer list
of data from notifications from the ResourceUsageThread. Renamed
some of the fields.
- page/cocoa/ResourceUsageThreadCocoa.mm: Added.
(WebCore::vmPageSize):
(WebCore::TagInfo::TagInfo):
(WebCore::pagesPerVMTag):
(WebCore::cpuUsage):
(WebCore::categoryForVMTag):
(WebCore::ResourceUsageThread::platformThreadBody):
Extracted from ResourceUsageOverlayCocoa.
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatch):
Drive-by, don't call singleton again, we already have the result.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Rename the ENABLE flag.
Source/WTF:
- wtf/Platform.h:
Rename the ENABLE flag.
- 5:22 PM Changeset in webkit [195643] by
-
- 3 edits in trunk/Source/WebCore
Use initializers in HTMLCanvasElement
https://bugs.webkit.org/show_bug.cgi?id=153472
Reviewed by Michael Catanzaro.
Use initializers, and re-order member variables for better packing.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
- html/HTMLCanvasElement.h:
- 5:16 PM Changeset in webkit [195642] by
-
- 3 edits2 adds in trunk
Setting HTMLInputElement.value to null to set its value to the empty string
https://bugs.webkit.org/show_bug.cgi?id=153519
Reviewed by Ryosuke Niwa.
Source/WebCore:
Setting HTMLInputElement.value to null to set its value to the empty string:
WebKit would previously unset the value attribute instead, which caused
it to fallback to input.defaultValue if set.
Firefox and Chrome behave correctly.
Test: fast/dom/HTMLInputElement/input-value-set-null.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
LayoutTests:
Add a layout test to make sure that setting HTMLInputElement.value to null
actually sets its value to the empty string.
- fast/dom/HTMLInputElement/input-value-set-null-expected.txt: Added.
- fast/dom/HTMLInputElement/input-value-set-null.html: Added.
- 5:11 PM Changeset in webkit [195641] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r195602.
https://bugs.webkit.org/show_bug.cgi?id=153526
broke more than it fixed (Requested by thorton on #webkit).
Reverted changeset:
"REGRESSION (r194557): Keyboard shortcuts stop working after
the WKWebView is unparented and reparented"
https://bugs.webkit.org/show_bug.cgi?id=153492
http://trac.webkit.org/changeset/195602
- 5:10 PM Changeset in webkit [195640] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3] Fix control reaches end of non-void function GCC warning after r195139
https://bugs.webkit.org/show_bug.cgi?id=153426
Reviewed by Michael Catanzaro.
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::cooled):
- 4:57 PM Changeset in webkit [195639] by
-
- 2 edits in trunk/Source/JavaScriptCore
testb3 and testAir should be compiled under -O0
https://bugs.webkit.org/show_bug.cgi?id=153520
Reviewed by Benjamin Poulain.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 4:52 PM Changeset in webkit [195638] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, temporarily skip fast/history/page-cache-webdatabase-no-transaction-db.html
https://bugs.webkit.org/show_bug.cgi?id=153525
The test flakily crashes, skip it until I can fix it.
- 4:49 PM Changeset in webkit [195637] by
-
- 3 edits in trunk/Source/JavaScriptCore
B3's integer range analysis should know that Mul'ing two sufficiently small numbers will yield a number that still has a meaningful range
https://bugs.webkit.org/show_bug.cgi?id=153518
Reviewed by Benjamin Poulain.
Octane/encrypt had an addition overflow check that can be proved away by being sufficiently
sneaky about the analysis of adds, multiplies, and shifts.
I almost added these optimizations to the DFG integer range optimization phase. That phase is
very complicated. B3's integer range analysis is trivial. So I added it to B3. Eventually
we'll want this same machinery in the DFG also.
8% speed-up on Octane/encrypt.
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::dump): Dumping a constant value's name now dumps its value. This makes a huge difference for reading IR.
(JSC::B3::Value::cloneImpl):
(JSC::B3::Value::deepDump):
- 4:33 PM Changeset in webkit [195636] by
-
- 2 edits1 delete in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/semantics/interfaces.html for ios-simulator after support
for HTMLDataElement was added in r195627, removing ios-simulator-wk2 specific result.
https://bugs.webkit.org/show_bug.cgi?id=153459
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt: Removed.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
- 4:29 PM Changeset in webkit [195635] by
-
- 8 edits in trunk/Source
WebKitAdditions should be able to modify derived source rules
https://bugs.webkit.org/show_bug.cgi?id=153514
Reviewed by Tim Horton.
Source/WebCore:
- DerivedSources.make:
Include WebCoreDerivedSourcesAdditions.make.
- WebCore.xcodeproj/project.pbxproj:
Pass our WebKitAdditions paths as include paths to make.
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
- Configurations/WebKit.xcconfig:
Set WEBKITADDITIONS_HEADER_SEARCH_PATHS.
- DerivedSources.make:
Move the path computation earlier and include WebKitDerivedSourcesAdditions.make.
- WebKit2.xcodeproj/project.pbxproj:
Pass our WebKitAdditions paths as include paths to make.
- 4:08 PM Changeset in webkit [195634] by
-
- 2 edits in trunk/LayoutTests
Skipping tests added with r195625 that are unsupported on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 4:02 PM Changeset in webkit [195633] by
-
- 2 edits in tags/Safari-602.1.17.0.2/Source/WTF
Merged r195629. rdar://problem/24322314
- 4:01 PM Changeset in webkit [195632] by
-
- 11 edits in tags/Safari-602.1.17.0.2
Merged r195582. rdar://problem/24356482
- 3:59 PM Changeset in webkit [195631] by
-
- 5 edits in tags/Safari-602.1.17.0.2/Source
Versioning.
- 3:56 PM Changeset in webkit [195630] by
-
- 1 copy in tags/Safari-602.1.17.0.2
New tag.
- 3:46 PM Changeset in webkit [195629] by
-
- 2 edits in trunk/Source/WTF
Make HashTable iterators STL iterators compatible
https://bugs.webkit.org/show_bug.cgi?id=153512
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2016-01-26
Reviewed by Alex Christensen.
While r178581 makes many hash table iterators STL compatible, still several iterators are not.
This patch fixes that; inheriting std::iterator correctly to meet STL iterator requirements (like iterator_category etc.)
It could recover Windows build failure.
- wtf/HashTable.h:
- 3:22 PM Changeset in webkit [195628] by
-
- 3 edits3 adds in trunk
document.open() / write() should be prevented in beforeunload event handlers
https://bugs.webkit.org/show_bug.cgi?id=153432
Reviewed by Ryosuke Niwa.
Source/WebCore:
document.open() / write() should be prevented in beforeunload event handlers:
- https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-open (step 6)
- https://html.spec.whatwg.org/multipage/webappapis.html#dom-document-write (step 3)
- https://html.spec.whatwg.org/multipage/webappapis.html#ignore-opens-during-unload-counter
- https://html.spec.whatwg.org/multipage/browsers.html#unload-a-document
Test: fast/frames/page-beforeunload-document-open.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
LayoutTests:
Add a layout test to check that document.open() / write() is indeed
prevented inside 'beforeunload' event handlers.
- fast/frames/page-beforeunload-document-open-expected.txt: Added.
- fast/frames/page-beforeunload-document-open.html: Added.
- fast/frames/resources/page-beforeunload-document-open-frame.html: Added.
- 3:21 PM Changeset in webkit [195627] by
-
- 20 edits3 adds in trunk
Add support for HTMLDataElement
https://bugs.webkit.org/show_bug.cgi?id=153459
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline existing W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
Add support for HTMLDataElement:
https://html.spec.whatwg.org/multipage/semantics.html#the-data-element
Firefox already supports it.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDataElement.cpp: Added.
(WebCore::HTMLDataElement::create):
(WebCore::HTMLDataElement::HTMLDataElement):
- html/HTMLDataElement.h: Added.
- html/HTMLDataElement.idl: Added.
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
LayoutTests:
Rebaseline existing test now that HTMLDataElement is exposed on the
global Window object.
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 3:14 PM Changeset in webkit [195626] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r195610.
https://bugs.webkit.org/show_bug.cgi?id=153513
The test added with this change is timing out on almost every
run (Requested by ryanhaddad on #webkit).
Reverted changeset:
"Calling video.controls=true during a scrub operation cancels
scrub."
https://bugs.webkit.org/show_bug.cgi?id=153494
http://trac.webkit.org/changeset/195610
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-26
- 2:48 PM Changeset in webkit [195625] by
-
- 6 edits26 adds in trunk
History.pushState causes intense memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=153435
Reviewed by Sam Weinig, Oliver Hunt, and Geoff Garen.
Source/WebCore:
Tests: fast/loader/stateobjects/pushstate-frequency-iframe.html
fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html
fast/loader/stateobjects/pushstate-frequency.html
fast/loader/stateobjects/replacestate-frequency-iframe.html
fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html
fast/loader/stateobjects/replacestate-frequency.html
loader/stateobjects/pushstate-size-iframe.html
loader/stateobjects/pushstate-size.html
loader/stateobjects/replacestate-size-iframe.html
loader/stateobjects/replacestate-size.html
Add restrictions on how frequently push/replaceState can be called,
as well as how much of a cumulative payload they can deliver.
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- page/History.cpp:
(WebCore::History::stateObjectAdded):
- page/History.h:
LayoutTests:
- TestExpectations: Mark some of the new tests as slow.
- fast/loader/stateobjects/pushstate-frequency-expected.txt: Added.
- fast/loader/stateobjects/pushstate-frequency-iframe-expected.txt: Added.
- fast/loader/stateobjects/pushstate-frequency-iframe.html: Added.
- fast/loader/stateobjects/pushstate-frequency-with-user-gesture-expected.txt: Added.
- fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html: Added.
- fast/loader/stateobjects/pushstate-frequency.html: Added.
- fast/loader/stateobjects/replacestate-frequency-expected.txt: Added.
- fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt: Added.
- fast/loader/stateobjects/replacestate-frequency-iframe.html: Added.
- fast/loader/stateobjects/replacestate-frequency-with-user-gesture-expected.txt: Added.
- fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html: Added.
- fast/loader/stateobjects/replacestate-frequency.html: Added.
- fast/loader/stateobjects/resources/pushstate-iframe.html: Added.
- fast/loader/stateobjects/resources/replacestate-iframe.html: Added.
- loader/stateobjects/pushstate-size-expected.txt: Added.
- loader/stateobjects/pushstate-size-iframe-expected.txt: Added.
- loader/stateobjects/pushstate-size-iframe.html: Added.
- loader/stateobjects/pushstate-size.html: Added.
- loader/stateobjects/replacestate-size-expected.txt: Added.
- loader/stateobjects/replacestate-size-iframe-expected.txt: Added.
- loader/stateobjects/replacestate-size-iframe.html: Added.
- loader/stateobjects/replacestate-size.html: Added.
- loader/stateobjects/resources/pushstate-iframe.html: Added.
- loader/stateobjects/resources/replacestate-iframe.html: Added.
- 2:22 PM Changeset in webkit [195624] by
-
- 1 edit2 adds in trunk/LayoutTests
Rebaselining cssom/subpixel-offsetleft-top-width-height-values.html for ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152308
Unreviewed test gardening.
- platform/ios-simulator/cssom/subpixel-offsetleft-top-width-height-values-expected.txt: Added.
- 2:22 PM Changeset in webkit [195623] by
-
- 5 edits in trunk/Source/WebKit2
Add a private WKUIDelegate method for getting a presenting view controller for a WKWebView on iOS
https://bugs.webkit.org/show_bug.cgi?id=153510
Reviewed by Dan Bernstein.
- UIProcess/API/APIUIClient.h:
(API::UIClient::presentingViewController):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::presentingViewController):
- 2:20 PM Changeset in webkit [195622] by
-
- 3 edits in trunk/Source/JavaScriptCore
It should be possible to disable FTL for a range like we disable DFG for a range
https://bugs.webkit.org/show_bug.cgi?id=153511
Reviewed by Geoffrey Garen.
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- runtime/Options.h:
- 2:07 PM Changeset in webkit [195621] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shifts by an amount computed using BitAnd with a mask that subsumes the shift's own mask should be rewired around the BitAnd
https://bugs.webkit.org/show_bug.cgi?id=153505
Reviewed by Saam Barati.
Turn this: Shl(@x, BitAnd(@y, 63))
Into this: Shl(@x, @y)
It matters for Octane/crypto.
We should also stop FTL from generating such code, but even if we did that, we'd still want
this optimization in case user code did the BitAnd.
Also we can't stop the FTL from generating such code yet, because when targetting LLVM, you
must mask your shifts this way.
- b3/B3ReduceStrength.cpp:
- 2:05 PM Changeset in webkit [195620] by
-
- 24 edits2 moves2 adds in trunk/Source/JavaScriptCore
The thing that B3 uses to describe a stack slot should not be a Value
https://bugs.webkit.org/show_bug.cgi?id=153491
rdar://problem/24349446
Reviewed by Geoffrey Garen and Saam Barati.
Prior to this change, B3 represented stack slots by having a StackSlotValue that carried
two meanings:
- It represented a stack slot.
- It was a kind of Value for getting the base of the stack slot.
This seems like a good idea until you consider the following issues.
1) A Value can be killed if it is on an unreachable path, or if it has no effects and
nobody refers to it. But the FTL uses StackSlotValue to allocate space on the stack.
When it does this, it doesn't want it to be killed. It will dereference the object, so
killing it is a bug.
2) A premise of B3 is that it should be always legal to perform the following
transformation on a value:
value->replaceWithIdentity(insertionSet.insertValue(index, proc.clone(value)));
This inserts a new value just before the old one. The new value is a clone of the old
one. Then the old one is essentially deleted (anything that becomes an identity dies
shortly thereafter). Problem (1) prevents this from being legal, which breaks a major
premise of B3 IR.
3) A premise of B3 is that it should be always legal to perform the following
transformation on a value:
Before:
@42 = Thing(...)
After:
Branch(@doesntMatter, #yes, #no)
BB#yes:
@42_one = Thing(...)
Upsilon(@42_one, 42)
Jump(#done)
BB#no:
@42_two = Thing(...)
Upsilon(@42_two, 42)
Jump(#done)
BB#done:
@42 = Phi()
But prior to this change, such a transformation makes absolutely no sense for
StackSlot. It will "work" in the sense that the compiler will proceed undaunted, but
it will disable SSA fix-up for the cloned stack slot and we will end up allocating two
stack slots instead of one, and then we will assume that they both escape, which will
disable efficient stack allocation. Note that the moral equivalent of this
transformation could already happen due to tail duplication, and the only reason why
it's not a bug right now is that we happen to hoist stack slots to the root block. But
the whole point of our stack slots was supposed to be that they do not have to be
hoisted.
This change fixes this issue by splitting StackSlotValue into two things: SlotBaseValue,
which is a pure operation for getting the base address of a StackSlot, and StackSlot,
which is a representation of the actual stack slot. StackSlot cannot get duplicated and
can only be killed if it's anonymous. SlotBaseValue can be killed, moved, cloned,
hoisted, etc. Since it has no effects and it has a ValueKey, it's one of the most
permissive Values in the IR, just as one would hope (after all, there is actually zero
code that needs to execute to evaluate SlotBaseValue).
This fixes a crash that we saw with GuardMalloc and ASan. It also makes the IR a lot more
easy to reason about.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/B3FixSSA.cpp:
(JSC::B3::demoteValues):
(JSC::B3::fixSSA):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::addStackSlot):
(JSC::B3::Procedure::addAnonymousStackSlot):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::blocksInPostOrder):
(JSC::B3::Procedure::deleteStackSlot):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::calleeSaveRegisters):
(JSC::B3::Procedure::addStackSlotIndex):
(JSC::B3::Procedure::addValueIndex):
- b3/B3Procedure.h:
(JSC::B3::Procedure::setBlockOrder):
(JSC::B3::Procedure::StackSlotsCollection::StackSlotsCollection):
(JSC::B3::Procedure::StackSlotsCollection::size):
(JSC::B3::Procedure::StackSlotsCollection::at):
(JSC::B3::Procedure::StackSlotsCollection::operator[]):
(JSC::B3::Procedure::StackSlotsCollection::iterator::iterator):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator*):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator++):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator==):
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator!=):
(JSC::B3::Procedure::StackSlotsCollection::iterator::findNext):
(JSC::B3::Procedure::StackSlotsCollection::begin):
(JSC::B3::Procedure::StackSlotsCollection::end):
(JSC::B3::Procedure::stackSlots):
(JSC::B3::Procedure::ValuesCollection::ValuesCollection):
- b3/B3ReduceStrength.cpp:
- b3/B3SlotBaseValue.cpp: Copied from Source/JavaScriptCore/b3/B3StackSlotValue.cpp.
(JSC::B3::SlotBaseValue::~SlotBaseValue):
(JSC::B3::SlotBaseValue::dumpMeta):
(JSC::B3::SlotBaseValue::cloneImpl):
(JSC::B3::StackSlotValue::~StackSlotValue): Deleted.
(JSC::B3::StackSlotValue::dumpMeta): Deleted.
(JSC::B3::StackSlotValue::cloneImpl): Deleted.
- b3/B3SlotBaseValue.h: Copied from Source/JavaScriptCore/b3/B3StackSlotValue.h.
- b3/B3StackSlot.cpp: Added.
(JSC::B3::StackSlot::~StackSlot):
(JSC::B3::StackSlot::dump):
(JSC::B3::StackSlot::deepDump):
(JSC::B3::StackSlot::StackSlot):
- b3/B3StackSlot.h: Added.
(JSC::B3::StackSlot::byteSize):
(JSC::B3::StackSlot::kind):
(JSC::B3::StackSlot::isLocked):
(JSC::B3::StackSlot::index):
(JSC::B3::StackSlot::offsetFromFP):
(JSC::B3::StackSlot::setOffsetFromFP):
(JSC::B3::DeepStackSlotDump::DeepStackSlotDump):
(JSC::B3::DeepStackSlotDump::dump):
(JSC::B3::deepDump):
- b3/B3StackSlotValue.cpp: Removed.
- b3/B3StackSlotValue.h: Removed.
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::checkOpcode):
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::materialize):
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::addBlock):
(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::addSpecial):
- b3/air/AirCode.h:
- b3/air/AirStackSlot.cpp:
(JSC::B3::Air::StackSlot::setOffsetFromFP):
(JSC::B3::Air::StackSlot::dump):
(JSC::B3::Air::StackSlot::deepDump):
(JSC::B3::Air::StackSlot::StackSlot):
- b3/air/AirStackSlot.h:
(JSC::B3::Air::StackSlot::alignment):
(JSC::B3::Air::StackSlot::b3Slot):
(JSC::B3::Air::StackSlot::offsetFromFP):
(WTF::printInternal):
(JSC::B3::Air::StackSlot::value): Deleted.
- b3/testb3.cpp:
(JSC::B3::testStackSlot):
(JSC::B3::testStoreLoadStackSlot):
- ftl/FTLB3Compile.cpp:
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::neg):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::framePointer):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
- ftl/FTLState.h:
- 1:55 PM Changeset in webkit [195619] by
-
- 1 edit3 adds in branches/safari-601-branch/Source/WebInspectorUI
Merge r195323. rdar://problem/24302730
- 1:43 PM Changeset in webkit [195618] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r195606. rdar://problem/24243317
- 1:38 PM Changeset in webkit [195617] by
-
- 2 edits in trunk/Tools
[webkitdirs] Removed check for bison, gperf, and flex.
https://bugs.webkit.org/show_bug.cgi?id=153496
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Alex Christensen.
This prerequisites are checked in WebKitCommon.cmake and don't
have to be in $PATH.
- Scripts/webkitdirs.pm:
(checkRequiredSystemConfig):
- 1:22 PM Changeset in webkit [195616] by
-
- 2 edits in trunk/Source/WebCore
Add a Dictionary overload that returns an Optional result
https://bugs.webkit.org/show_bug.cgi?id=153507
Reviewed by Tim Horton.
- bindings/js/Dictionary.h:
(WebCore::Dictionary::get):
- 1:19 PM Changeset in webkit [195615] by
-
- 6 edits in branches/safari-601.1.46-branch
Re-enable synchronous popstate event for safari-601-branch
- 1:19 PM Changeset in webkit [195614] by
-
- 8 edits8 adds in trunk
Let SVG images not taint canvases except when containing foreignObjects
https://bugs.webkit.org/show_bug.cgi?id=119639
Patch by Philip Rogers <pdr@chromium.org> on 2016-01-26
Reviewed by Brent Fulgham.
Source/WebCore:
r153876 caused SVG images to not taint canvases but the patch allowed
for subimage resources. This can be a problem if a subimage (e.g., data
uri image) contains a foreignObject which can violate security (e.g.,
visited links).
This patch updates SVGImage::hasSingleSecurityOrigin to check if the
image contains any foreignObjects or images that themselves contain
foreignObjects. SVG images without foreignObjects are allowed to not
taint canvases.
Canvas patterns are problematic because an animated SVG image can switch
between tainting and not tainting the canvas. A FIXME has been added to
solve this, and in the meantime we cause SVG images to taint patterns.
Tests: svg/as-image/svg-canvas-pattern-with-link-tainted.html
svg/as-image/svg-canvas-svg-with-feimage-with-link-tainted.html
svg/as-image/svg-canvas-svg-with-image-with-link-tainted.html
- html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::~SVGFEImageElement):
(WebCore::SVGFEImageElement::hasSingleSecurityOrigin):
(WebCore::SVGFEImageElement::clearResourceReferences):
- svg/SVGFEImageElement.h:
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::create):
(WebCore::SVGImageElement::hasSingleSecurityOrigin):
(WebCore::SVGImageElement::isSupportedAttribute):
- svg/SVGImageElement.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
LayoutTests:
- svg/as-image/resources/svg-with-feimage-with-link.svg: Added.
- svg/as-image/resources/svg-with-image-with-link.svg: Added.
- svg/as-image/svg-canvas-pattern-with-link-tainted-expected.txt: Added.
- svg/as-image/svg-canvas-pattern-with-link-tainted.html: Added.
- svg/as-image/svg-canvas-svg-with-feimage-with-link-tainted-expected.txt: Added.
- svg/as-image/svg-canvas-svg-with-feimage-with-link-tainted.html: Added.
- svg/as-image/svg-canvas-svg-with-image-with-link-tainted-expected.txt: Added.
- svg/as-image/svg-canvas-svg-with-image-with-link-tainted.html: Added.
- 1:14 PM Changeset in webkit [195613] by
-
- 2 edits in trunk/Tools
[webkitdirs] isCMakeBuild should be true by default
https://bugs.webkit.org/show_bug.cgi?id=153497
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Michael Catanzaro.
- Scripts/webkitdirs.pm:
(isCMakeBuild):
- 1:12 PM Changeset in webkit [195612] by
-
- 2 edits in trunk/Source/WebCore
CSSGrammar.y:1742.31-34: warning: unused value: $3
https://bugs.webkit.org/show_bug.cgi?id=153462
Reviewed by Alex Christensen.
This warning indicates that we have a memory leak. From the bison manual:
"Right-hand side symbols of a rule that explicitly triggers a syntax error via YYERROR are
not discarded automatically. As a rule of thumb, destructors are invoked only when user
actions cannot manage the memory."
Arguably a design error, but that's how it is.
- css/CSSGrammar.y.in:
- 1:09 PM Changeset in webkit [195611] by
-
- 2 edits in trunk/Source/WTF
BlockPtr needs boolean operators
https://bugs.webkit.org/show_bug.cgi?id=153506
Reviewed by Tim Horton.
- wtf/BlockPtr.h:
- 12:58 PM Changeset in webkit [195610] by
-
- 3 edits2 adds in trunk
Calling video.controls=true during a scrub operation cancels scrub.
https://bugs.webkit.org/show_bug.cgi?id=153494
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-controls-drag-timeline-set-controls-property.html
Verify that the video.controls attribute actually changed before tearing down and
re-adding the media controls to the Shadow DOM.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleControlsChange):
(Controller.prototype.hasControls):
LayoutTests:
- media/media-controls-drag-timeline-set-controls-property-expected.txt: Added.
- media/media-controls-drag-timeline-set-controls-property.html: Added.
- 12:45 PM Changeset in webkit [195609] by
-
- 2 edits in trunk/Source/WebCore
[EME][Mac] Crash in [AVStreamSession addStreamDataParser:]; uncaught exception
https://bugs.webkit.org/show_bug.cgi?id=153495
Reviewed by Eric Carlson.
When AVContentKeySession is not available, fall back to pre-AVContentKeySession behavior;
namely, immediately create an AVStreamSession object in
willProvideContentKeyRequestInitializationData, rather than waiting for didProvide.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::willProvideContentKeyRequestInitializationDataForTrackID):
- 12:30 PM Changeset in webkit [195608] by
-
- 2 edits in trunk/LayoutTests
Marking svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153498
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:09 PM Changeset in webkit [195607] by
-
- 10 edits3 adds in trunk
[iOS] Documents without an explicit width should not get fast tapping
https://bugs.webkit.org/show_bug.cgi?id=153465
Source/WebCore:
<rdar://problem/23962529>
Reviewed by Simon Fraser (and Wenson Hseih).
As the title says, documents that do not set a viewport should
not get the fast click behaviour. There were complaints that we broke
double-tap to scroll in ImageDocuments where the image was narrow and long.
The fix is to just keep a flag that tells the UI process if the
width was explicit. However, it turns out that those ImageDocuments
are given an explicit device-width, which is fine for scaling but
really should behave as auto for fast tapping. So we also need
to tell the UIProcess if the viewport arguments came from an
ImageDocument.
Test: fast/events/ios/viewport-no-width-value-allows-double-tap.html
- dom/ViewportArguments.cpp:
(WebCore::findSizeValue): Add a parameter that toggles a flag
if the size was explicitly set.
(WebCore::setViewportFeature): Remember if the width was
explicit.
- dom/ViewportArguments.h: Add a widthWasExplicit flag.
(WebCore::ViewportArguments::operator==):
Source/WebKit2:
<rdar://problem/23962529>
Reviewed by Simon Fraser (and Wenson Hseih).
As the title says, documents that do not set a viewport should
not get the fast click behaviour. There were complaints that we broke
double-tap to scroll in ImageDocuments where the image was narrow and long.
The fix is to just keep a flag that tells the UI process if the
width was explicit. However, it turns out that those ImageDocuments
are given an explicit device-width, which is fine for scaling but
really should behave as auto for fast tapping. So we also need
to tell the UIProcess if the viewport arguments came from an
ImageDocument.
- Shared/mac/RemoteLayerTreeTransaction.h: Add two new flags into
the transaction.
(WebKit::RemoteLayerTreeTransaction::viewportMetaTagWidthWasExplicit):
(WebKit::RemoteLayerTreeTransaction::setViewportMetaTagWidthWasExplicit):
(WebKit::RemoteLayerTreeTransaction::viewportMetaTagCameFromImageDocument):
(WebKit::RemoteLayerTreeTransaction::setViewportMetaTagCameFromImageDocument):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::description):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]): Notice whether or not the viewport
width was explicit.
(-[WKWebView _allowsDoubleTapGestures]): Return yes if the width
was not explicit, or if the viewport came from an ImageDocument.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
LayoutTests:
Reviewed by Simon Fraser (and Wenson Hseih).
- fast/events/ios/thin-gradient.jpg: Added.
- fast/events/ios/viewport-no-width-value-allows-double-tap-expected.txt: Added.
- fast/events/ios/viewport-no-width-value-allows-double-tap.html: Added.
- platform/ios-simulator/TestExpectations:
- 12:07 PM Changeset in webkit [195606] by
-
- 2 edits in trunk/Source/WebCore
Speculative fixes for crashing in viewportChangeAffectedPicture
https://bugs.webkit.org/show_bug.cgi?id=153450
Reviewed by Dean Jackson.
Don't attach any conditions to the removal of a picture element from
the document's HashSet. This ensures that if the condition is ever
wrong for any reason, we'll still remove the picture element on
destruction.
Fix the media query evaluation to match the other evaluations (used by
the preload scanner and HTMLImageElement). This includes using the
document element's computed style instead of our own and also null
checking the document element first. This is the likely cause of the
crashes.
- html/HTMLPictureElement.cpp:
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):
- 11:57 AM Changeset in webkit [195605] by
-
- 6 edits in trunk/Source/WebCore
Make sure a page is still PageCache-able after firing the 'pagehide' events
https://bugs.webkit.org/show_bug.cgi?id=153449
Reviewed by Andreas Kling.
Make sure a page is still PageCache-able after firing the 'pagehide'
events and abort if it isn't. This should improve robustness and it is
easy for pagehide event handlers to do things that would make a Page no
longer PageCache-able and this leads to bugs that are difficult to
investigate.
To achieve this, the 'pagehide' event firing logic was moved out of the
CachedFrame constructor. It now happens earlier in
PageCache::addIfCacheable() after checking if the page is cacheable and
before constructing the CachedPage / CachedFrames. After firing the
'pagehide' event in PageCache::addIfCacheable(), we check again that
the page is still cacheable and we abort early if it is not.
- history/CachedFrame.cpp:
(WebCore::CachedFrame::CachedFrame):
- history/PageCache.cpp:
(WebCore::setInPageCache):
(WebCore::firePageHideEventRecursively):
(WebCore::PageCache::addIfCacheable):
- history/PageCache.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- 11:33 AM Changeset in webkit [195604] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove a useless #include
https://bugs.webkit.org/show_bug.cgi?id=153474
Reviewed by Alexey Proskuryakov.
- b3/B3ReduceStrength.cpp:
- 11:28 AM Changeset in webkit [195603] by
-
- 2 edits in trunk/Source/WebCore
Rubber-stamped by Tim Horton.
Add one more bit of SPI.
- platform/spi/mac/NSSpellCheckerSPI.h:
- 11:12 AM Changeset in webkit [195602] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r194557): Keyboard shortcuts stop working after the WKWebView is unparented and reparented
https://bugs.webkit.org/show_bug.cgi?id=153492
<rdar://problem/24138989>
Reviewed by Dan Bernstein.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canBecomeFirstResponder]):
(-[WKContentView becomeFirstResponder]):
(-[WKContentView resignFirstResponder]):
When WKWebView is unparented, WKContentView will attempt to resignFirstResponder upwards,
first asking WKWebView. After r194557, WKWebView will accept first responder and forward
it on to the WKContentView, which will happily accept it again, despite being the view
that's trying to resign. This will cause us to completely lose first responder,
where it was actually supposed to propagate up above WKWebView to the client.
Keep track of when WKContentView is resigning first responder, and don't
let it become first responder while it is doing so, breaking the cycle.
- 11:02 AM Changeset in webkit [195601] by
-
- 2 edits in trunk/Source/WebCore
Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=153490
Patch by Olivier Blin <Olivier Blin> on 2016-01-26
Reviewed by Michael Catanzaro.
This has been broken since r178702, which changed the Page
argument from a pointer to a reference in logCanCachePageDecision().
No new tests since this is a build fix.
- history/PageCache.cpp:
(WebCore::canCachePage):
- 10:56 AM Changeset in webkit [195600] by
-
- 5 edits9 moves in trunk/Source
Move WebVideoFullscreenManager and related classes from iOS specific folders to cocoa folders
https://bugs.webkit.org/show_bug.cgi?id=153473
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, just moving files.
- WebCore.xcodeproj/project.pbxproj:
Update due to changes to the file locations.
- platform/cocoa/WebVideoFullscreenModel.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenModel.h.
- platform/cocoa/WebVideoFullscreenModelVideoElement.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.h.
(WebCore::WebVideoFullscreenModelVideoElement::create):
Fix a style error by moving the opening curly brace down one line.
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenModelVideoElement.mm.
Source/WebKit2:
- DerivedSources.make:
Add new paths.
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.h.
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in.
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm.
(WebKit::WebVideoFullscreenManagerProxy::setSeekableRangesVector):
Fix a style error by moving the opening curly brace to the same line as the for statement.
- WebKit2.xcodeproj/project.pbxproj:
Update due to changes to the file locations.
- WebProcess/cocoa/WebVideoFullscreenManager.h: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.h.
- WebProcess/cocoa/WebVideoFullscreenManager.messages.in: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.messages.in.
- WebProcess/cocoa/WebVideoFullscreenManager.mm: Renamed from Source/WebKit2/WebProcess/ios/WebVideoFullscreenManager.mm.
(WebKit::WebVideoFullscreenInterfaceContext::setSeekableRanges):
Fix a style error by adding a missing space after a comma.
- 10:46 AM Changeset in webkit [195599] by
-
- 2 edits in trunk/LayoutTests
Skipping fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=138468
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:46 AM Changeset in webkit [195598] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/codemirror/prettyprinting-css-rules.html as flaky on mac-wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=153460
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 10:40 AM Changeset in webkit [195597] by
-
- 4 edits2 adds1 delete in trunk
Add WebKitSystemInterface for iOS 9.2
https://bugs.webkit.org/show_bug.cgi?id=153355
Rubber-stamped by David Kilzer.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
- WebKitSystemInterface.h:
- WebKitSystemInterfaceIOS.h: Removed.
- libWebKitSystemInterfaceIOSDevice9.2.a: Added.
- libWebKitSystemInterfaceIOSSimulator9.2.a: Added.
- 10:37 AM Changeset in webkit [195596] by
-
- 2 edits in trunk/Source/WebCore
Do not convert GlyphBufferAdvance to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=153429
GlyphBufferAdvance is not necessaryly convertible to FloatSize.
Also, this code was doing extra work by transforming height value.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-26
Reviewed by Antti Koivisto.
No new tests needed.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGGlyphToPathTranslator::extents):
- 10:35 AM Changeset in webkit [195595] by
-
- 6 edits2 adds in trunk/Source/WebCore
Enable API related to the video fullscreen layer in MediaPlayerPrivateAVFoundationObjC
also on Mac with video presentation mode support.
https://bugs.webkit.org/show_bug.cgi?id=153222
Reviewed by Eric Carlson.
No new tests. Covered by existing tests.
Introduce VideoFullscreenLayerManager to deal with the video layer when switching
between inline and fullscreen mode. We'll reuse it in other MediaPlayerPrivateInterface
implementations.
Now that MediaPlayerPrivateAVFoundationObjC's platform layer can be a WebVideoContainerLayer,
this exposes a bug in PlatformCALayerCocoa::clone() where we assumed the platform layer
is always an AVPlayerLayer if the PlatformCALayer's layer type is LayerTypeAVPlayerLayer.
Add a helper method to get an AVPlayerLayer from a PlatformCALayerCocoa (which also handles
WebVideoContainerLayer case) and use it in PlatformCALayerCocoa::clone().
- WebCore.xcodeproj/project.pbxproj:
Add VideoFullscreenLayerManager to the project.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
Create m_videoFullscreenLayerManager. The video inline layer, video fullscreen layer,
and the video fullscreen frame are now managed by that class.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
Just call VideoFullscreenLayerManager::setVideoLayer() to handle adding the video
layer in either the inline or fullscreen layer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer):
Call VideoFullscreenLayerManager::didDestroyVideoLayer().
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer):
Get the video inline layer from VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer):
Call VideoFullscreenLayerManager::setVideoFullscreenLayer().
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame):
Call VideoFullscreenLayerManager::setVideoFullscreenFrame().
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode):
Guard the iOS specific code properly.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):
Get the video fullscreen layer from VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateAVFoundationObjC::requiresTextTrackRepresentation):
Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds):
Get the video fullscreen layer and video fullscreen frame from VideoFullscreenLayerManager.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation):
Get the video fullscreen layer from VideoFullscreenLayerManager.
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: Added.
(WebCore::VideoFullscreenLayerManager::videoInlineLayer):
(WebCore::VideoFullscreenLayerManager::videoFullscreenLayer):
(WebCore::VideoFullscreenLayerManager::videoFullscreenFrame):
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: Added.
(-[WebVideoContainerLayer setBounds:]):
(-[WebVideoContainerLayer setPosition:]):
WebVideoContainerLayer was moved from MediaPlayerPrivateAVFoundationObjC.mm.
(WebCore::VideoFullscreenLayerManager::create):
(WebCore::VideoFullscreenLayerManager::VideoFullscreenLayerManager):
(WebCore::VideoFullscreenLayerManager::setVideoLayer):
Code moved from MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer().
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer):
Code moved from MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer().
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame):
Code moved from MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame().
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer):
Code moved from MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer().
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::clone):
Use the new PlatformCALayerCocoa::avPlayerLayer() method to get the AVPlayerLayer from both the
destination and source PlatformCALayers.
(PlatformCALayerCocoa::avPlayerLayer):
Return nil if the layer type is not LayerTypeAVPlayerLayer. Otherwise, return the
platform layer if it is indeed an AVPlayerLayer. If not, it should be a WebVideoContainerLayer
and we should return its sublayer which should be an AVPlayerLayer.
- 10:04 AM Changeset in webkit [195594] by
-
- 7 edits2 adds in trunk
First parameter to window.showModalDialog() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=153436
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Drop temporary WebKit workaround in html/dom/interfaces.html
imported W3C test. This test would previously time out without
the workaround but this is fixed now.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
Source/WebCore:
Make window.showModalDialog()'s first parameter mandatory to match the
last specification containing it:
http://dev.w3.org/html5/spec-preview/user-prompts.html#dialogs-implemented-using-separate-documents
The new behavior also matches Firefox, while Chrome no longer supports
this operation.
With this change, the W3C HTML test suite no longer hangs in the middle
because it mistakenly pops up a modal dialog during testing.
Test: fast/dom/Window/showModalDialog-mandatory-parameter.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::showModalDialog):
LayoutTests:
- fast/dom/Window/showModalDialog-mandatory-parameter-expected.txt: Added.
- fast/dom/Window/showModalDialog-mandatory-parameter.html: Added.
Add layout test to check that showModalDialog()'s first parameter is indeed
mandatory.
- fast/dom/null-page-show-modal-dialog-crash.html:
Update existing test now that showModalDialog()'s first parameter is
mandatory.
- 9:23 AM Changeset in webkit [195593] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] Fix clean build after r195545.
https://bugs.webkit.org/show_bug.cgi?id=153434
- CMakeLists.txt:
- PlatformWin.cmake:
Derived sources need to be copied after the build, but everything else should be copied before.
This should fix ews issues like the one seen in bug 153473.
- 9:17 AM Changeset in webkit [195592] by
-
- 5 edits in trunk
LayoutTest media/airplay-target-availability.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=153100
<rdar://problem/24346796>
Reviewed by Daniel Bates.
Source/WebCore:
No new tests, media/airplay-target-availability.html was updated
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::clientStateDidChange): Schedule a configuration scan if
any of the config flags have changed.
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring): Update logging.
LayoutTests:
- media/airplay-target-availability-expected.txt:
- media/airplay-target-availability.html:
- 9:00 AM Changeset in webkit [195591] by
-
- 2 edits in trunk/Source/WebCore
Main frame scrollbars not updated on hovering when using overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=153304
Reviewed by Michael Catanzaro.
Legacy scrollbars were fixed in r194155, but overlay scrollbars
are not notified when they are hovered. This is because the layer
hit test in RenderView::hitTest always returns true when using
overlay scrollbars and we are returning early in such case,
ignoring the HitTestRequest::AllowFrameScrollbars flag. So, in
case of using overlay scrollbars we still need to check the
RenderView scrollbars even when the layer hit test succeeded.
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
- 8:15 AM Changeset in webkit [195590] by
-
- 3 edits5 adds in trunk
LayoutTest http/tests/security/xssAuditor/embed-tag-in-path-unterminated.html crashing
https://bugs.webkit.org/show_bug.cgi?id=153250
<rdar://problem/12172843>
And
<rdar://problem/24248040>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Remove an incorrect assertion that the absolute URL associated with a protection space cannot
contain consecutive forward slash (/) characters. A URL can contain consecutive forward slashes.
This also makes the invariants for CredentialStorage::findDefaultProtectionSpaceForURL() symmetric
with the invariants for WebCore::protectionSpaceMapKeyFromURL().
Tests: http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html
http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html
- platform/network/CredentialStorage.cpp:
(WebCore::CredentialStorage::findDefaultProtectionSpaceForURL):
LayoutTests:
The test case http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html was derived
from a test case written by Yongjun Zhang in <https://bugs.webkit.org/attachment.cgi?id=65189> (bug #44461).
- http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html: Added.
- http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- http/tests/xmlhttprequest/basic-auth-load-URL-with-consecutive-slashes.html: Added.
- platform/wk2/http/tests/loading/basic-auth-load-URL-with-consecutive-slashes-expected.txt: Added.
- 8:08 AM Changeset in webkit [195589] by
-
- 13 edits in trunk
WebKitTestRunner: Credential cache is not cleared between tests
https://bugs.webkit.org/show_bug.cgi?id=153407
<rdar://problem/24280834>
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Expose SPI to call CredentialStorage::clearCredentials() on the default network storage
session to clear cached credentials.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::clearCachedCredentials): Added.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in: Added message ClearCachedCredentials().
- UIProcess/API/C/WKContext.cpp:
(WKContextClearCachedCredentials): Added.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::clearCachedCredentials): Notify all web processes and the
network process to clear cached credentials.
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearCachedCredentials): Clear cached credentials in the default
network storage session.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Added message ClearCachedCredentials().
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
to clear cached credentials.
- 8:06 AM Changeset in webkit [195588] by
-
- 54 edits3 deletes in trunk
Remove XMLHttpRequestException
https://bugs.webkit.org/show_bug.cgi?id=102698
<rdar://problem/24338476>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update test result now that we throw DOMException.{ABORT, NETWORK, TIMEOUT}Error instead of XMLHttpRequestException.{ABORT, NETWORK, TIMEOUT}_ERR.
- web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
- web-platform-tests/XMLHttpRequest/send-non-same-origin.sub-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-bogus-sync-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-infinite-sync-expected.txt:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-network-error-sync-expected.txt:
Source/WebCore:
Inspired by a patch by Erik Arvidsson.
As per <https://xhr.spec.whatwg.org> (21 January 2016) and <https://html.spec.whatwg.org/multipage/workers.html#dom-workerglobalscope-importscripts> (25 January 2016)
XMLHttpRequest and WorkerGlobalScope.importScripts() should throw a DOMException object instead
of a XMLHttpRequestException object when a NetworkError, AbortError, or TimeoutError occur. This
makes the behavior of WebKit more closely conform to these standards as well as the behavior of
other browsers.
- CMakeLists.txt: Remove entries for XMLHttpRequestException.idl and XMLHttpRequestException.cpp.
- DerivedSources.make: Remove entry for XMLHttpRequestException.idl.
- WebCore.order: Remove exported symbols for XMLHttpRequestException.
- WebCore.vcxproj/WebCore.vcxproj: Remove entries for JSXMLHttpRequestException.{cpp, h}, XMLHttpRequestException.{cpp, h}
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSExceptionBase.cpp:
(WebCore::toExceptionBase): Remove logic for XMLHttpRequestException.
- dom/DOMExceptions.in: Remove entry for XMLHttpRequestException.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts): Throw DOMException.NETWORK_ERR instead of XMLHttpRequestException.NETWORK_ERR.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Ditto.
(WebCore::XMLHttpRequest::didFail): Throw DOMException.ABORT_ERR instead of XMLHttpRequestException.ABORT_ERR.
(WebCore::XMLHttpRequest::didReachTimeout): Throw DOMException.TIMEOUT_ERR instead of XMLHttpRequestException.TIMEOUT_ERR.
- xml/XMLHttpRequestException.cpp: Removed.
- xml/XMLHttpRequestException.h: Removed.
- xml/XMLHttpRequestException.idl: Removed.
LayoutTests:
Update test result now that we throw DOMException.{ABORT, NETWORK, TIMEOUT}Error instead of XMLHttpRequestException.{ABORT, NETWORK, TIMEOUT}_ERR.
- fast/dom/Window/resources/window-properties.js:
- fast/dom/Window/window-lookup-precedence-expected.txt:
- fast/files/apply-blob-url-to-xhr-expected.txt:
- fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt:
- http/tests/appcache/non-html.xhtml:
- http/tests/appcache/simple.html:
- http/tests/contentextensions/sync-xhr-blocked-expected.txt:
- http/tests/local/fileapi/send-sliced-dragged-file-expected.txt:
- http/tests/workers/worker-importScripts-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt:
- http/tests/xmlhttprequest/XMLHttpRequestException.html:
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached-expected.txt:
- http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
- http/tests/xmlhttprequest/connection-error-sync-expected.txt:
- http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt:
- http/tests/xmlhttprequest/origin-exact-matching-expected.txt:
- http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt:
- http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt:
- http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt:
- http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/TestExpectations:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 7:47 AM Changeset in webkit [195587] by
-
- 2 edits in trunk/Tools
kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
https://bugs.webkit.org/show_bug.cgi?id=153483
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/kill-old-processes:
(main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
- 6:48 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 1:45 AM Changeset in webkit [195586] by
-
- 5 edits2 adds in trunk
[GTK] WebProcess crashes when quickly attempting many DnD operations
https://bugs.webkit.org/show_bug.cgi?id=138468
Reviewed by Michael Catanzaro.
Source/WebKit2:
Do not allow different DnD operations over the same element at the
same time, so that any new attempt to DnD an element happening before
a previous attempt has ended will take precedence, cancelling the older
operation before going ahead with the new one.
This is consistent with how WebCore::EventHandler handles DnD operations,
preventing the web process from crashing in scenarios where the user might
try to perform many DnD operations over the same element very quickly.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DragAndDropHandler): Initialized new member.
(WebKit::DragAndDropHandler::startDrag): Ensure a previous DnD operation
is cancelled before handling the new one that has just started.
(WebKit::DragAndDropHandler::fillDragData): Protect against calling this
function from webkitWebViewBaseDragDataGet for already cancelled operations.
(WebKit::DragAndDropHandler::finishDrag): Protect against calling this
function from webkitWebViewBaseDragEnd for already cancelled operations.
- UIProcess/gtk/DragAndDropHandler.h:
LayoutTests:
New test added to check that the web process does not crash when multiple
DnD operations are quickly attempted over the same draggable element.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash-expected.txt: Added.
- fast/events/drag-and-drop-link-fast-multiple-times-does-not-crash.html: Added.
Added the new test to the failure expectations for mac-wk2, as there's no
suitable implementation of eventSender in place yet (see bug 42194).
- platform/mac-wk2/TestExpectations: Added failure expectation for the new test.
- 1:45 AM WebKitGTK/2.10.x edited by
- (diff)
- 12:17 AM Changeset in webkit [195585] by
-
- 12 edits1 add in trunk/Source
FTLB3Output should maintain good block order like the LLVM one does
https://bugs.webkit.org/show_bug.cgi?id=152222
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This fixes FTLB3Output to emit an ordered B3 IR. This makes inspecting IR *a lot* easier.
It will also be a performance win whenever we use range-based data structures for
liveness.
Also two small other changes:
- Added some more dumping in integer range optimization phase.
- Refined the disassembler's printing of instruction width suffixes so that "jzl" is not a thing. It was using "l" as the suffix because jumps take a 32-bit immediate.
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::clone):
- b3/B3Procedure.h:
(JSC::B3::Procedure::frontendData):
(JSC::B3::Procedure::setBlockOrder):
- dfg/DFGIntegerRangeOptimizationPhase.cpp:
- disassembler/udis86/udis86_syn-att.c:
(ud_translate_att):
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::applyBlockOrder):
(JSC::FTL::Output::appendTo):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::setFrequency):
(JSC::FTL::Output::insertNewBlocksBefore):
(JSC::FTL::Output::callWithoutSideEffects):
(JSC::FTL::Output::newBlock): Deleted.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
Source/WTF:
In the FTL we need to be able to construct a list by inserting elements before other
specific elements. We didn't already have a scalable way to do this, so this adds such a
data structure to WTF. This also has changes to SentinelLinkedList to make it support
these kinds of insertions.
- WTF.xcodeproj/project.pbxproj:
- wtf/OrderMaker.h: Added.
(WTF::OrderMaker::Node::Node):
(WTF::OrderMaker::OrderMaker):
(WTF::OrderMaker::prepend):
(WTF::OrderMaker::append):
(WTF::OrderMaker::insertBefore):
(WTF::OrderMaker::insertAfter):
(WTF::OrderMaker::iterator::iterator):
(WTF::OrderMaker::iterator::operator*):
(WTF::OrderMaker::iterator::operator++):
(WTF::OrderMaker::iterator::operator==):
(WTF::OrderMaker::iterator::operator!=):
(WTF::OrderMaker::begin):
(WTF::OrderMaker::end):
(WTF::OrderMaker::newNode):
- wtf/SentinelLinkedList.h:
(WTF::BasicRawSentinelNode::isOnList):
(WTF::BasicRawSentinelNode<T>::remove):
(WTF::BasicRawSentinelNode<T>::prepend):
(WTF::BasicRawSentinelNode<T>::append):
(WTF::RawNode>::SentinelLinkedList):
(WTF::RawNode>::push):
(WTF::RawNode>::append):
(WTF::RawNode>::remove):
(WTF::RawNode>::prepend):
(WTF::RawNode>::isOnList):
Jan 25, 2016:
- 11:32 PM Changeset in webkit [195584] by
-
- 5 edits in trunk/Source/WebCore
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
No change in behavior.
- Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
- Modules/mediastream/NavigatorUserMedia.js: Making it @conditional.
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- 11:28 PM Changeset in webkit [195583] by
-
- 3 edits4 adds in trunk/LayoutTests
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
https://bugs.webkit.org/show_bug.cgi?id=152436
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
Adding temporary tests that splits garbage collection readable stream
tests in worker and window mode.
- web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt: Added.
- web-platform-tests/streams-api/readable-streams/garbage-collection-1.html: Added.
- web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt: Added.
- web-platform-tests/streams-api/readable-streams/garbage-collection-2.html: Added.
LayoutTests:
- platform/mac/TestExpectations: Marked imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html as crash/pass.
- 10:12 PM Changeset in webkit [195582] by
-
- 11 edits in trunk
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=153469
Patch by Alex Christensen <achristensen@webkit.org> on 2016-01-25
Reviewed by Brent Fulgham.
.:
- Source/cmake/WebKitMacros.cmake:
Pass the GPERF_EXECUTABLE that we found to make-hash-tools.pl.
Source/WebCore:
- CMakeLists.txt:
Pass the GPERF_EXECUTABLE that we found to perl scripts so they can use it instead of just calling gperf.
This is needed for builds where gperf is not in the PATH.
- DerivedSources.make:
Pass "gperf" as the gperf command to retain existing functionality on mac.
- bindings/scripts/preprocess-idls.pl:
(CygwinPathIfNeeded):
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
Add /cygdrive/c/cygwin/bin to the PATH before calling cygpath.
This is needed for builds where we are using cygwin, but C:/cygwin/bin is not in the PATH.
- css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
- css/makeSelectorPseudoElementsMap.py:
- css/makeprop.pl:
- platform/network/create-http-header-name-table:
Use the gperf executable passed in as a command line parameter if it is given.
- 9:43 PM Changeset in webkit [195581] by
-
- 7 edits9 adds in trunk
[ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments"
https://bugs.webkit.org/show_bug.cgi?id=145132
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-01-25
Reviewed by Saam Barati.
Source/JavaScriptCore:
Added support of ES6 arrow function specific feature, lexical bind of arguments.
http://www.ecma-international.org/ecma-262/6.0/#sec-arrow-function-definitions-runtime-semantics-evaluation
'arguments' variable in arrow function must resolve to a binding in a lexically enclosing environment.
In srict mode it points to arguments object, and in non-stric mode it points to arguments object or varible
with name 'arguments' if it was declared.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::setSourceParseMode):
(JSC::Scope::isArrowFunction):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::setIsArrowFunction):
- tests/es6.yaml:
- tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js: Added.
- tests/stress/arrowfunction-lexical-bind-arguments-non-strict-2.js: Added.
- tests/stress/arrowfunction-lexical-bind-arguments-strict.js: Added.
Source/WebInspectorUI:
Current patch is implementing lexical bind of arguments, so in this callback we need
to return to ordinary function.
- UserInterface/Base/Object.js:
(WebInspector.Object.singleFireEventListener.let.wrappedCallback):
(WebInspector.Object.singleFireEventListener):
LayoutTests:
- js/arrowfunction-lexical-bind-arguments-non-strict-expected.txt: Added.
- js/arrowfunction-lexical-bind-arguments-non-strict.html: Added.
- js/arrowfunction-lexical-bind-arguments-strict-expected.txt: Added.
- js/arrowfunction-lexical-bind-arguments-strict.html: Added.
- js/script-tests/arrowfunction-lexical-bind-arguments-non-strict.js: Added.
- js/script-tests/arrowfunction-lexical-bind-arguments-strict.js: Added.
- 9:41 PM Changeset in webkit [195580] by
-
- 3 edits in trunk/Source/WebCore
DisplayList items can log paths now
https://bugs.webkit.org/show_bug.cgi?id=153417
Reviewed by Zalan Bujtas.
Now that Path supports TextStream logging, clean up its output a little and
enable dumping of Paths in DisplayListItems.
- platform/graphics/Path.cpp:
(WebCore::operator<<):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::operator<<):
- 9:40 PM Changeset in webkit [195579] by
-
- 4 edits in trunk
Give the layout test results file a <title> showing the date and time the tests were run
https://bugs.webkit.org/show_bug.cgi?id=153187
Reviewed by Darin Adler.
Tools:
Include a 'date' property in the JSON with the date and time the tests completed.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
LayoutTests:
Generate a <title> element from the 'date' property in the JSON.
- fast/harness/results.html:
- 8:01 PM Changeset in webkit [195578] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] We should never use x18 on iOS ARM64
https://bugs.webkit.org/show_bug.cgi?id=153461
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-25
Reviewed by Filip Pizlo.
The register x18 is reserved in the iOS variant of the ARM64 ABI.
The weird thing is: if you use it, its value will change completely
randomly. It looks like it is changed by the system on interrupts.
This patch adds x18 to the reserved register and add assertions
to the assembler to prevent similar problems in the future.
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::xOrSp):
(JSC::ARM64Assembler::xOrZr):
- assembler/AbstractMacroAssembler.h:
(JSC::isIOS): Deleted.
- assembler/AssemblerCommon.h:
(JSC::isIOS):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::reservedHardwareRegisters):
- 7:13 PM Changeset in webkit [195577] by
-
- 2 edits in trunk/Source/WebCore
Fix the comment.
- rendering/style/RenderStyle.h:
- 7:12 PM Changeset in webkit [195576] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r195550.
https://bugs.webkit.org/show_bug.cgi?id=153471
broke animometer bot (and now we have crash logs!) (Requested
by kling on #webkit).
Reverted changeset:
"Restore CodeBlock jettison code Geoff accidentally removed"
https://bugs.webkit.org/show_bug.cgi?id=151241
http://trac.webkit.org/changeset/195550
- 6:57 PM Changeset in webkit [195575] by
-
- 3 edits in trunk/Source/JavaScriptCore
MarkedSpace should have more precise allocators.
<https://webkit.org/b/153448>
<rdar://problem/23897477>
Reviewed by Geoffrey Garen.
The four classes responsible for the bulk of MarkedBlock allocations today are:
- FunctionCodeBlock (640 bytes)
- UnlinkedFunctionCodeBlock (304 bytes)
- FunctionExecutable (168 bytes)
- UnlinkedFunctionExecutable (144 bytes)
Due to the size class distribution in MarkedSpace, we've been wasting quite a lot
of heap space on these objects. Our "precise" allocators allowed allocation sizes
in 16-byte increments up to 128 bytes, but after that point, we'd only allocate
in 256-byte size increments.
Thus each instance of those classes would waste space as follows:
- FunctionCodeBlock (768-byte cell, 128 bytes wasted)
- UnlinkedFunctionCodeBlock (512-byte cell, 208 bytes wasted)
- FunctionExecutable(256-byte cell, 88 bytes wasted)
- UnlinkedFunctionExecutable(256-byte cell, 112 bytes wasted)
This patch raises the limit for precise allocations from 128 to 768, allowing us
to allocate these objects with far better space efficiency.
The cost of this is 7kB worth of MarkedAllocators and 70 (~2x) more allocators to
iterate whenever we iterate all the allocators.
- heap/MarkedSpace.h:
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::forEachAllocator):
(JSC::MarkedSpace::isPagedOut):
- 6:18 PM Changeset in webkit [195574] by
-
- 13 edits2 moves in trunk/Source
Add support for DataDetectors in WK (iOS).
https://bugs.webkit.org/show_bug.cgi?id=152989
rdar://problem/22855960
Reviewed by Tim Horton.
Source/WebCore:
Adding new helper functions for data detection related tasks.
The patch also fixes a bug when creating DOM ranges from DDQueryRange
spanning multiple fragments.
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::isDataDetectorLink):
(WebCore::DataDetection::dataDetectorIdentifier):
(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):
(WebCore::resultIsURL):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::detectContentInRange):
Source/WebKit2:
Moving InteractionInformationAtPosition files to platform folder,
since this is only used on iOS and changing from .cpp to .mm.
The structure is extended to include data detection specific fields
and the relevant encode/decode functions have been updated to
handle the new fields.
The patch also adds a new WKUIDelegatePrivate method to allow
the client to provide additional context for data detection actions.
- Platform/spi/ios/UIKitSPI.h:
- Shared/InteractionInformationAtPosition.cpp: Removed.
- Shared/InteractionInformationAtPosition.h: Removed.
- Shared/ios/InteractionInformationAtPosition.h: Copied from Shared/InteractionInformationAtPosition.h.
- Shared/ios/InteractionInformationAtPosition.mm: Copied from Shared/InteractionInformationAtPosition.cpp.
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showDataDetectorsSheet]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView actionSheetAssistantDidStopInteraction:]):
(-[WKContentView dataDetectionContextForActionSheetAssistant:]):
(-[WKContentView selectedTextForActionSheetAssistant:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
- UIProcess/ios/WebPageProxyIOS.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 5:56 PM Changeset in webkit [195573] by
-
- 29 edits1 add in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Skip all inspector/sampling-profiler tests meanwhile the feature is not enabled on the GTK+ port.
Report and mark a new regression on test inspector/dom-debugger/node-removed.html timing out.
Rebaseline a bunch of tests after r194847.
- platform/gtk/TestExpectations:
- platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Rebaseline after r194847.
- platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.png: Added. Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug1188-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug1188-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug18359-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug18359-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug29326-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug29326-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug33855-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug33855-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug4382-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug4382-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug96334-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/bugs/bug96334-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/core/margins-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/core/margins-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla/dom/tableDom-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla/dom/tableDom-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Rebaseline after r194847.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Rebaseline after r194847.
- platform/gtk/transforms/2d/zoom-menulist-expected.png: Rebaseline after r194847.
- platform/gtk/transforms/2d/zoom-menulist-expected.txt: Rebaseline after r194847.
- 5:56 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:19 PM WebKitGTK/Gardening/Calendar edited by
- sign up for tomorrow since I missed last week too (diff)
- 4:43 PM Changeset in webkit [195572] by
-
- 2 edits in branches/safari-601.1.46-branch/LayoutTests
Merge r195492. rdar://problem/24001780
- 4:43 PM Changeset in webkit [195571] by
-
- 6 edits8 adds in branches/safari-601.1.46-branch
Merge r195477. rdar://problem/24001780
- 4:43 PM Changeset in webkit [195570] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r195424. rdar://problem/24222456
- 4:43 PM Changeset in webkit [195569] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r195393. rdar://problem/24042909
- 4:43 PM Changeset in webkit [195568] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r195150. rdar://problem/24208162
- 4:35 PM Changeset in webkit [195567] by
-
- 3 edits in trunk/Source/WebCore
Remove broken cache from CSSFontFaceSource
https://bugs.webkit.org/show_bug.cgi?id=153440
Reviewed by Simon Fraser.
This cache has been broken since 2013 (r158085). Given we didn't notice a perf
hit when it broke, and the fact it's been broken for years, it clearly isn't
necessary.
https://bugs.webkit.org/show_bug.cgi?id=153414 consists of a fairly invasive
change to CSSFontFaceSource; this patch includes a working version of this
cache, along with an easy way to enable/disable it (to measure possible perf
changes).
This patch is a short-term cleanup patch in the mean time until the above
invasive change gets landed.
No new tests because there is no behavior (or performance!) change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource): Deleted.
(WebCore::CSSFontFaceSource::pruneTable): Deleted.
(WebCore::CSSFontFaceSource::fontLoaded): Deleted.
- css/CSSFontFaceSource.h:
- 4:25 PM Changeset in webkit [195566] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample counts
https://bugs.webkit.org/show_bug.cgi?id=153447
<rdar://problem/24334137>
Reviewed by Joseph Pecoraro.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord):
(WebInspector.ScriptTimelineRecord.prototype.get profile):
(WebInspector.ScriptTimelineRecord.prototype.get callCount):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
- 4:16 PM Changeset in webkit [195565] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the simulator build.
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- 3:54 PM Changeset in webkit [195564] by
-
- 5 edits2 copies in trunk/Source/WebCore
Roll back in r195559 with a build fix.
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/DataDetection.mm:
- platform/cocoa/DataDetectorsCoreSoftLink.mm: Added.
- platform/cocoa/DataDetectorsCoreSoftLink.h: Added.
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- 3:44 PM Changeset in webkit [195563] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the comment about FTL_USES_B3.
- dfg/DFGCommon.h:
- 3:41 PM Changeset in webkit [195562] by
-
- 2 edits in trunk/Source/JavaScriptCore
Switch FTL to B3 on X86_64/Mac
https://bugs.webkit.org/show_bug.cgi?id=153445
Rubber stamped by Geoffrey Garen.
This finally switches from LLVM to B3 in the FTL on X86_64 on the Mac. We recommend that other
X86_64 platforms make the switch as well. We will be focusing our performance work on B3 rather
than LLVM in the future. ARM64 support is also coming soon, so we will be able to remove FTL
LLVM code once that lands.
Right now this mostly appears as perf-neutral on the major tests. However, it does have the
following immediate benefits:
- Dramatic reduction in FTL compile times, on the order of 5x-10x. This means huge speed-ups in shorter-running tests like V8Spider (21%) and JSRegress (8%).
- It makes the FTL simpler and more robust because we don't have to do stackmap section parsing. This makes it easier to add new FTL features. We are already working on features, like the sampling profiler, which will only have a FTL B3 implementation.
- Speed-ups on some throughput benchmarks like mandreel, richards, imaging-gaussian-blur. It's still a slow down on other throughput benchmarks, though.
We started writing B3 in October, so it's pretty awesome that the throughput of the code it
generates is already on par with LLVM.
This does not fundamentally change how the FTL works. FTL was built to lower DFG IR to a C-like
SSA IR, and then rely on powerful SSA optimizations and comprehensive instruction selection and
register allocation to turn that code into something that runs fast. B3 also has a C-like SSA
IR, has an instruction selector that is in some ways more powerful than LLVM's (B3 does global
instruction selection rather than block-local like LLVM), and it has a register allocator that
is in some ways more powerful also (B3 uses IRC, a mature graph coloring allocator, while LLVM
does not do graph coloring). We expect FTL B3's performance to improve a lot after we turn it
on and can focus our efforts on tuning it.
I didn't find any test regressions after running both JSC tests and layout tests. Basic
browsing still works. JetStream performance difference is within the margin of error. EWS is
happy.
- dfg/DFGCommon.h:
- 3:38 PM Changeset in webkit [195561] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r195559.
https://bugs.webkit.org/show_bug.cgi?id=153458
This change broke the iOS build (Requested by ryanhaddad on
#webkit).
Reverted changeset:
"Fix the ASAN build."
http://trac.webkit.org/changeset/195559
Patch by Commit Queue <commit-queue@webkit.org> on 2016-01-25
- 3:33 PM Changeset in webkit [195560] by
-
- 8 edits in trunk/Source/WebCore
Resolving direction and writing mode properties should not mutate document
https://bugs.webkit.org/show_bug.cgi?id=153446
Reviewed by Andreas Kling.
Replace directionSetOnDocumentElement/writingModeSetOnDocumentElement document flags them with style flags.
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueDirection):
(WebCore::StyleBuilderCustom::resetEffectiveZoom):
(WebCore::StyleBuilderCustom::applyValueWebkitWritingMode):
(WebCore::StyleBuilderCustom::applyValueWebkitTextOrientation):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForElement):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Document::markers):
(WebCore::Document::directionSetOnDocumentElement): Deleted.
(WebCore::Document::writingModeSetOnDocumentElement): Deleted.
(WebCore::Document::setDirectionSetOnDocumentElement): Deleted.
(WebCore::Document::setWritingModeSetOnDocumentElement): Deleted.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
- rendering/style/RenderStyle.h:
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- 3:12 PM Changeset in webkit [195559] by
-
- 4 edits2 adds in trunk/Source/WebCore
Fix the ASAN build.
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/DataDetection.mm:
- platform/cocoa/DataDetectorsCoreSoftLink.mm: Added.
- platform/cocoa/DataDetectorsCoreSoftLink.h: Added.
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- 3:08 PM Changeset in webkit [195558] by
-
- 13 edits in trunk
Unreviewed, rolling out r195543.
https://bugs.webkit.org/show_bug.cgi?id=153451
regressed performance of test bots by ~6% (Requested by dydz
on #webkit).
Reverted changeset:
"WebKitTestRunner: Credential cache is not cleared between
tests"
https://bugs.webkit.org/show_bug.cgi?id=153407
http://trac.webkit.org/changeset/195543
- 2:37 PM Changeset in webkit [195557] by
-
- 2 edits in trunk/Tools
Failing to upload to flakiness dashboard should not be a hard error
https://bugs.webkit.org/show_bug.cgi?id=153444
<rdar://problem/22146294>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
- 2:35 PM Changeset in webkit [195556] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/indexeddb/keyorder-private.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=153438
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 2:13 PM Changeset in webkit [195555] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][NetworkCache] Enable speculative revalidation
https://bugs.webkit.org/show_bug.cgi?id=153443
<rdar://problem/23092196>
Reviewed by Antti Koivisto.
Enable speculative revalidation to better evaluate performance and
robustness.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
- 2:07 PM Changeset in webkit [195554] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm as flaky
on ios-simulator, removing flaky expectation that was incorrectly added for a different WPT LayoutTest.
https://bugs.webkit.org/show_bug.cgi?id=153371
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:40 PM Changeset in webkit [195553] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix.
- WebView/WebHTMLView.mm:
(-[WebHTMLView initWithFrame:]):
(-[WebHTMLView insertText:]):
- 1:38 PM Changeset in webkit [195552] by
-
- 4 edits in trunk/Source/WebKit/mac
WK1: Handle soft spaces after accepted candidates
https://bugs.webkit.org/show_bug.cgi?id=153442
-and corresponding-
rdar://problem/23958418
Reviewed by Tim Horton.
The space at the end of candidates is a soft space. If that space exists,
cache the range of the space in m_softSpaceRange.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::handleAcceptedCandidate):
New ivar in WebHTMLViewPrivate softSpaceRange keeps track to the NSRange of a
soft space if the last text that was inserted has a soft space at the end.
- WebView/WebHTMLView.mm:
(-[WebHTMLView initWithFrame:]):
(-[WebHTMLView _setSoftSpaceRange:]):
When new text is inserted, find out if it is being inserted right after a
soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will
tell us if the space needs to be removed. If that is the case, then set the
replacementString to the soft space.
(-[WebHTMLView insertText:]):
- WebView/WebHTMLViewInternal.h:
- 1:12 PM Changeset in webkit [195551] by
-
- 2 edits in trunk/Source/WebCore
[Win] Another build fix after r195545
- CMakeLists.txt:
r195548 didn't change all the pre-builds back to post-builds.
- 1:04 PM Changeset in webkit [195550] by
-
- 2 edits in trunk/Source/JavaScriptCore
Restore CodeBlock jettison code Geoff accidentally removed
https://bugs.webkit.org/show_bug.cgi?id=151241
Rubber-stamped by Geoffrey Garen.
Geoff meant to add this back in <http://trac.webkit.org/changeset/190827>
but missed.
Then he added it back in, but it was rolled out due to a crash on Animometer.
I can no longer produce a crash on Animometer, either with today's version of
the benchmark, or the one that existed at the time of the rollout.
Given this, let's roll it back in and see how it goes.
- bytecode/CodeBlock.cpp:
(JSC::timeToLive):
(JSC::CodeBlock::shouldJettisonDueToOldAge):
- 12:47 PM Changeset in webkit [195549] by
-
- 10 edits in trunk/Source/JavaScriptCore
mandreel should run just as fast in FTL B3 as FTL LLVM
https://bugs.webkit.org/show_bug.cgi?id=153394
Reviewed by Gavin Barraclough.
This fixes two performance bugs and one disassembler bug.
- B3 now turns Branches into Jumps when they are dominated by a Check on the same condition. This is like the opposite of foldPathConstants() was doing.
- Air now supports adding to 8-bit or 16-bit memory locations on x86. B3 now knows how to lower Store8(Add(Load8Z(...))) and various other things to these new instructions.
- Disassembler now knows to print out the instruction's width, whenever it has one. Previously, we'd print movb, movw, movl, and movq as "mov", which is unhelpful if you're storing an immediate, for example.
This adds a bunch of tests for the new instruction forms. This is a big speed-up on
mandreel. It makes us just as fast as LLVM on that benchmark.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::add8):
(JSC::MacroAssemblerX86Common::add16):
(JSC::MacroAssemblerX86Common::add32AndSetFlags):
(JSC::MacroAssemblerX86Common::clz32AfterBsr):
- assembler/X86Assembler.h:
(JSC::X86Assembler::addl_rm):
(JSC::X86Assembler::addb_rm):
(JSC::X86Assembler::addw_rm):
(JSC::X86Assembler::addl_ir):
(JSC::X86Assembler::addl_im):
(JSC::X86Assembler::addb_im):
(JSC::X86Assembler::addw_im):
(JSC::X86Assembler::addq_rr):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::addr):
(JSC::B3::Air::LowerToAir::loadPromiseAnyOpcode):
(JSC::B3::Air::LowerToAir::loadPromise):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3PureCSE.cpp:
(JSC::B3::PureCSE::clear):
(JSC::B3::PureCSE::findMatch):
(JSC::B3::PureCSE::process):
- b3/B3PureCSE.h:
- b3/B3ReduceStrength.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testNegPtr):
(JSC::B3::testStoreAddLoad32):
(JSC::B3::testStoreAddLoadImm32):
(JSC::B3::testStoreAddLoad8):
(JSC::B3::testStoreAddLoadImm8):
(JSC::B3::testStoreAddLoad16):
(JSC::B3::testStoreAddLoadImm16):
(JSC::B3::testStoreAddLoad64):
(JSC::B3::testStoreAddLoadImm64):
(JSC::B3::testStoreAddLoad32Index):
(JSC::B3::testStoreAddLoadImm32Index):
(JSC::B3::testStoreAddLoad8Index):
(JSC::B3::testStoreAddLoadImm8Index):
(JSC::B3::testStoreAddLoad16Index):
(JSC::B3::testStoreAddLoadImm16Index):
(JSC::B3::testStoreAddLoad64Index):
(JSC::B3::testStoreAddLoadImm64Index):
(JSC::B3::testStoreSubLoad):
(JSC::B3::run):
(JSC::B3::testStoreAddLoad): Deleted.
- disassembler/udis86/udis86_syn-att.c:
(ud_translate_att):
- 12:37 PM Changeset in webkit [195548] by
-
- 3 edits in trunk/Source/WebCore
[Win] Fix clean build after r195545.
- CMakeLists.txt:
- PlatformWin.cmake:
I got a little carried away. WebCore already had a pre-build event. It was correct before r195545.
- 12:29 PM Changeset in webkit [195547] by
-
- 6 edits in trunk/Source
Handle soft spaces after accepted candidates
https://bugs.webkit.org/show_bug.cgi?id=153331
-and corresponding-
rdar://problem/23958418
Reviewed by Darin Adler.
Source/WebCore:
Candidates now come with built-in spaces, so we should not insert a space for
them.
- editing/Editor.cpp:
(WebCore::Editor::handleAcceptedCandidate):
New SPI to properly handle these soft spaces.
- platform/spi/mac/NSSpellCheckerSPI.h:
Source/WebKit2:
New member variable m_softSpaceRange keeps track to the NSRange of a soft
space if the last text that was inserted has a soft space at the end.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
The space at the end of candidates is a soft space. If that space exists,
cache the range of the space in m_softSpaceRange.
(WebKit::WebViewImpl::handleAcceptedCandidate):
When new text is inserted, find out if it is being inserted right after a
soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will
tell us if the space needs to be removed. If that is the case, then set the
replacementString to the soft space.
(WebKit::WebViewImpl::insertText):
- 12:25 PM Changeset in webkit [195546] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/heap/garbageCollected.html as flaky on mac-wk1 debug
https://bugs.webkit.org/show_bug.cgi?id=153039
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 12:12 PM Changeset in webkit [195545] by
-
- 11 edits in trunk/Source
[Win] Copy forwarding headers before building a project
https://bugs.webkit.org/show_bug.cgi?id=153434
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- CMakeLists.txt:
- PlatformWin.cmake:
Source/WebCore:
- CMakeLists.txt:
- PlatformWin.cmake:
Source/WebKit:
- PlatformWin.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- wtf/PlatformWin.cmake:
- 11:48 AM Changeset in webkit [195544] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Reduce unnecessary forced layouts in TimelineOverview
https://bugs.webkit.org/show_bug.cgi?id=153392
<rdar://problem/24312344>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-25
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.layout):
Ignore setting the scrollLeft if we would be setting it to 0.
This helps avoid a forced layout in common cases.
- 10:41 AM Changeset in webkit [195543] by
-
- 13 edits in trunk
WebKitTestRunner: Credential cache is not cleared between tests
https://bugs.webkit.org/show_bug.cgi?id=153407
<rdar://problem/24280834>
Reviewed by Brady Eidson.
Source/WebKit2:
Add SPI to call NetworkStorageSession::switchToNewTestingSession() to create a new testing session.
The new testing session will have an empty credential cache.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::switchToNewTestingSession): Added.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in: Added message SwitchToNewTestingSession().
- UIProcess/API/C/WKContext.cpp:
(WKContextResetTestingNetworkSession): Added.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::resetTestingNetworkSession): Added.
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::switchToNewTestingSession): Added.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in: Added message SwitchToNewTestingSession().
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues): Reset testing network session
to clear cached credentials.
- 10:38 AM Changeset in webkit [195542] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/loading/preload-no-store-frame-src.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152446
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:20 AM Changeset in webkit [195541] by
-
- 4 edits in trunk
Modern IDB: Implement getIndexRecord in the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153425
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Some failures now pass, other failures progressed closer to passing).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 9:55 AM Changeset in webkit [195540] by
-
- 3 edits2 adds in trunk
Media "ended" event incorrectly fires when currentTime is set
https://bugs.webkit.org/show_bug.cgi?id=150348
<rdar://problem/24247974>
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-ended-fired-once.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::invalidateCachedTime): Always mark m_cachedTime as invalid.
LayoutTests:
- media/media-ended-fired-once-expected.txt: Added.
- media/media-ended-fired-once.html: Added.
- 9:49 AM Changeset in webkit [195539] by
-
- 2 edits in trunk/Source/WebCore
Do not convert GlyphBufferAdvance to FloatSize
https://bugs.webkit.org/show_bug.cgi?id=153421
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-25
Reviewed by Simon Fraser.
No new tests needed.
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawGlyphs::computeBounds):
- 9:23 AM Changeset in webkit [195538] by
-
- 20 edits2 adds in trunk
document.createElement should be able to create a custom element
https://bugs.webkit.org/show_bug.cgi?id=153173
Reviewed by Darin Adler.
Source/WebCore:
Added the support for constructing a custom element via document.createElement.
Extracted HTMLElementFactory::createKnownElement, which returns nullptr when the specified name doesn't match
any builtin element instead of out of HTMLUnknownElement, out of HTMLElementFactory::createElement.
Test: fast/custom-elements/Document-createElement.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::constructHTMLElement): Added. Constructs a custom element by invoking its
constructor. We allow exceptions to be thrown by the constructor so the caller is responsible for checking
any exceptions in the ExecState before preceeding if the returned value is null.
- bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::constructSVGElement): Added.
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated): Exit early if the element is a custom element as the wrapper had already been
created by super() call inside the custom element'c constructor.
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState):
- bindings/js/JSMainThreadExecStateInstrumentation.h:
(WebCore::JSMainThreadExecState::instrumentFunctionInternal): Generalized from instrumentFunctionCall so that
we can use it for both call and construct.
(WebCore::JSMainThreadExecState::instrumentFunctionCall): Specialized the above function for call.
(WebCore::JSMainThreadExecState::instrumentFunctionConstruct): Ditto for construct.
- dom/CustomElementDefinitions.cpp:
(WebCore::CustomElementDefinitions::findInterface): Added.
- dom/CustomElementDefinitions.h:
- dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation): Extracted from createElement.
(WebCore::Document::createElementForBindings): Renamed from createElement. Specifies
ShouldCreateCustomElement::Create to create a custom element before using fallback elements.
- dom/Document.h:
- dom/Document.idl:
- dom/Node.h:
(WebCore::Node::isCustomElement): Added. This flag is used to identify a custom element.
(WebCore::Node::setIsCustomElement): Added.
- dom/make_names.pl: Extracted createKnownElement from createElement for createHTMLElementWithNameValidation.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument): Use qualified name object to instantiate
a style element and set type content attribute.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName): Use createElementForBindings here since we might be creating an
arbitrary element here. Also use RefPtr instead of raw pointers while mutating DOM for safety.
Source/WebKit/win:
Use createElementForBindings here since this is a C++ binding for Windows.
- DOMCoreClasses.cpp:
(DOMDocument::createElement):
Source/WebKit2:
Use createElementForBindings here since this is for SPI.
- WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):
LayoutTests:
Add a test for creating a custom elemnet via document.createElement.
The behavior is to be documented later.
- fast/custom-elements/Document-createElement-expected.txt: Added.
- fast/custom-elements/Document-createElement.html: Added.
- 9:13 AM Changeset in webkit [195537] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r192773): [GTK] maps.google.com unresponsive/stalls since r192773
https://bugs.webkit.org/show_bug.cgi?id=153194
Reviewed by Michael Catanzaro.
In r192773 we implemented the JavaScriptCore garbage collector
timers for the GTK+ port. Those timers schedule sources in the
current thread default main context, but JS web worker threads
implementation doesn't use WTF::RunLoop, but its own WorkerRunLoop
class that doesn't create a GMainContext for the new thread. This
means that for web sites using workers, we are now doing garbage
collection of worker VMs in the main thread which ends up in a
deadlock at some point. We need to ensure that worker threads
create a GMainContext and push it as the default one for the
thread before the WorkerGlobalScope is created. This way when the
worker Heap is created, the GC timers use the right context to
schedule their sources. And then we need to check if there are
sources pending in the thread main context on every worker run
loop iteration.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- 8:19 AM Changeset in webkit [195536] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: timelines clear button should be inactive if nothing can be cleared
https://bugs.webkit.org/show_bug.cgi?id=132756
Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-01-25
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.shown):
Enable clear button if timeline is not readonly and contains data, when switching timelines.
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
Enable clear button when a capturing starts.
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
Disable clear button after resetting recording.
- 8:18 AM Changeset in webkit [195535] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r195533.
https://bugs.webkit.org/show_bug.cgi?id=153423
It is again breaking builds of several ports (Requested by
youenn on #webkit).
Reverted changeset:
"WebCoreJSBuiltins do not use to do conditional include"
https://bugs.webkit.org/show_bug.cgi?id=153306
http://trac.webkit.org/changeset/195533
- 8:17 AM Changeset in webkit [195534] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines: "Timer Installed150ms delay" — no space before the delay number
https://bugs.webkit.org/show_bug.cgi?id=153416
Reviewed by Timothy Hatcher.
Fix for tree element subtitle rule that regressed in https://bugs.webkit.org/show_bug.cgi?id=153146.
- UserInterface/Views/TreeOutline.css:
(.tree-outline .item .alternate-subtitle::before):
Em dash should be inserted before both subtitle types.
- 6:06 AM Changeset in webkit [195533] by
-
- 4 edits in trunk/Source/WebCore
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.
No change in behavior.
- Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- 3:57 AM Changeset in webkit [195532] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r195531.
https://bugs.webkit.org/show_bug.cgi?id=153420
It is breaking builds of several ports (Requested by youenn on
#webkit).
Reverted changeset:
"WebCoreJSBuiltins do not use to do conditional include"
https://bugs.webkit.org/show_bug.cgi?id=153306
http://trac.webkit.org/changeset/195531
- 3:36 AM Changeset in webkit [195531] by
-
- 3 edits in trunk/Source/WebCore
WebCoreJSBuiltins do not use to do conditional include
https://bugs.webkit.org/show_bug.cgi?id=153306
Reviewed by Alex Christensen.
Removing compilation guards as builtin generator adds them in the files themselves.
No change in behavior.
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
- 2:53 AM Changeset in webkit [195530] by
-
- 21 edits22 adds in trunk
[Fetch API] Implement Fetch API Headers
https://bugs.webkit.org/show_bug.cgi?id=152384
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-basic.html: Added.
- web-platform-tests/fetch/api/headers/headers-casing-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-casing.html: Added.
- web-platform-tests/fetch/api/headers/headers-errors-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-errors.html: Added.
- web-platform-tests/fetch/api/headers/headers-idl-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-idl.html: Added.
- web-platform-tests/fetch/api/headers/headers-nameshake-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-nameshake.html: Added.
- web-platform-tests/fetch/api/headers/headers-normalize-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-normalize.html: Added.
- web-platform-tests/fetch/api/headers/headers-structure-expected.txt: Added.
- web-platform-tests/fetch/api/headers/headers-structure.html: Added.
Source/WebCore:
Adding Fetch Headers API as a wapper around HTTPHeaderMap.
Tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-casing.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-idl.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-nameshake.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-normalize.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-structure.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/fetch/FetchHeaders.cpp: Added.
(WebCore::FetchHeaders::initializeWith):
(WebCore::isForbiddenHeaderName):
(WebCore::isForbiddenResponseHeaderName):
(WebCore::isSimpleHeader):
(WebCore::canWriteHeader):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::get):
(WebCore::FetchHeaders::has):
(WebCore::FetchHeaders::set):
- Modules/fetch/FetchHeaders.h: Added.
(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::~FetchHeaders):
(WebCore::FetchHeaders::internalHeaders):
(WebCore::FetchHeaders::FetchHeaders):
- Modules/fetch/FetchHeaders.idl: Added.
- Modules/fetch/FetchHeaders.js: Added.
(initializeFetchHeaders):
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- bindings/js/WebCoreJSBuiltins.cpp:
- bindings/js/WebCoreJSBuiltins.h:
(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::fetchHeadersBuiltins):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::remove):
- platform/network/HTTPHeaderMap.h:
LayoutTests:
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 1:24 AM Changeset in webkit [195529] by
-
- 6 edits in trunk
[css-grid] grid shorthand must reset gap properties to their initial values
https://bugs.webkit.org/show_bug.cgi?id=153354
Reviewed by Darin Adler.
Source/WebCore:
Both 'grid-row-gap' & 'grid-column-gap' are considered reset-only subproperties of the
'grid' shorthand meaning that, even thought the shorthand does not offer a way to set
their values, it must in any case reset them to the initial ones.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridShorthand):
- css/CSSPropertyNames.in:
LayoutTests:
- fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- 12:18 AM Changeset in webkit [195528] by
-
- 24 edits in trunk/Source/JavaScriptCore
Reduce number of Structures created at startup.
<https://webkit.org/b/153399>
Reviewed by Darin Adler.
For *Constructor and *Prototype objects that are only created once per JSGlobalObject,
build up the Structures using addPropertyWithoutTransition() helpers to avoid creating
tons of transitions that would just end up floating around and never getting used.
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
- inspector/JSJavaScriptCallFramePrototype.cpp:
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
- runtime/ConsolePrototype.cpp:
(JSC::ConsolePrototype::finishCreation):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSArrayBufferConstructor::finishCreation):
- runtime/JSArrayBufferPrototype.cpp:
(JSC::JSArrayBufferPrototype::finishCreation):
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunctionWithoutTransition):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition): Deleted.
- runtime/JSObject.h:
- runtime/JSPromiseConstructor.cpp:
(JSC::JSPromiseConstructor::addOwnInternalSlots):
- runtime/JSPromisePrototype.cpp:
(JSC::JSPromisePrototype::addOwnInternalSlots):
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
- runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototype::finishCreation):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::finishCreation):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::finishCreation):
- runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototype::finishCreation):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- runtime/WeakMapPrototype.cpp:
(JSC::WeakMapPrototype::finishCreation):
- runtime/WeakSetPrototype.cpp:
(JSC::WeakSetPrototype::finishCreation):
Jan 24, 2016:
- 11:55 PM Changeset in webkit [195527] by
-
- 18 edits in trunk
Modern IDB: Implement deleteIndex and getCount for the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153415
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Handful of tests now pass, improvements on a handful of others).
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::deleteIndex):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::takeIndexByIdentifier):
(WebCore::IDBServer::MemoryObjectStore::deleteIndex):
(WebCore::IDBServer::MemoryObjectStore::deleteAllIndexes):
(WebCore::IDBServer::MemoryObjectStore::takeIndexByName): Deleted.
- Modules/indexeddb/server/MemoryObjectStore.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor):
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformDeleteIndex):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::deleteIndex):
- Modules/indexeddb/shared/IDBObjectStoreInfo.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 11:45 PM Changeset in webkit [195526] by
-
- 5 edits in trunk/Source/WebKit2
Report upload progress to NetworkLoadClient when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153388
Patch by Alex Christensen <achristensen@webkit.org> on 2016-01-24
Reviewed by Darin Adler.
This fixes http/tests/xmlhttprequest/upload-onload-event.html and a few other tests.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didBecomeDownload):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::didReceiveResponseAsync):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate initWithNetworkSession:]):
(-[WKNetworkSessionDelegate URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:]):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
- 11:04 PM Changeset in webkit [195525] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, speculative fix for:
Modern IDB: Some IDB tests crash in ~SQLiteIDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=153418
No new tests.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore): Clear the global object
before wiping out the VM.
- 10:13 PM Changeset in webkit [195524] by
-
- 18 edits in trunk/Source
Reduce PassRefPtr uses in dom - 4
https://bugs.webkit.org/show_bug.cgi?id=153270
Reviewed by Darin Adler.
As a step to remove PassRefPtr uses, this patch reduces the uses in WebCore/dom.
Source/WebCore:
- bindings/js/JSDeviceMotionEventCustom.cpp:
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):
- dom/DeviceMotionData.cpp:
(WebCore::DeviceMotionData::create):
(WebCore::DeviceMotionData::DeviceMotionData):
- dom/DeviceMotionData.h:
- dom/Document.cpp:
(WebCore::Document::setBodyOrFrameset):
(WebCore::Document::setFocusedElement):
(WebCore::Document::setDecoder):
(WebCore::Document::pushCurrentScript):
- dom/Document.h:
- dom/Event.cpp:
(WebCore::Event::cloneFor):
- dom/Event.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::cloneFor):
- dom/MouseEvent.h:
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodePointer::NodePointer):
(WebCore::NodeIterator::NodeIterator):
- dom/NodeIterator.h:
(WebCore::NodeIterator::create):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
- platform/ios/DeviceMotionClientIOS.mm:
(WebCore::DeviceMotionClientIOS::motionChanged):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
Source/WebKit/win:
- Plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::focusPluginElement):
- 9:23 PM Changeset in webkit [195523] by
-
- 9 edits in trunk/Source/WebCore
[Font Loading] General cleanup
https://bugs.webkit.org/show_bug.cgi?id=153403
Reviewed by Darin Adler.
It turns out that CSSFontFaceSource::m_hasExternalSVGFont exactly equals
whether or not CSSFontFaceSource::m_font is a CachedSVGFont. Therefore,
the variable is redundant.
In addition, it was being passed to functions on CSSFontFaceSource::m_font,
which means it was always true inside the CachedSVGFont subclass and
always false for the CachedFont. Therefore, there is no reason pass this
variable to these functions because its value can be determined at
authorship time.
No new tests because there is no behavior change.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::CSSFontFaceSource): Deleted.
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
(WebCore::createFontFace):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createFont):
- loader/cache/CachedFont.h:
- loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::createFont):
(WebCore::CachedSVGFont::ensureCustomFontData):
- loader/cache/CachedSVGFont.h:
- platform/network/HTTPParsers.cpp:
(WebCore::isValidHTTPToken):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
- 8:00 PM Changeset in webkit [195522] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add support for placing Views in DataGrid column headers
https://bugs.webkit.org/show_bug.cgi?id=153387
<rdar://problem/24310797>
Reviewed by Timothy Hatcher.
This patch adds a new DataGrid column property,
headerView, allowing a
custom View object to be placed in a column's header cell. The grid ensures
that the left and right edges of the view are kept in sync as columns are
resized. As most views use absolute positioning and are styled in CSS, the
vertical position and height of the view isn't set by the grid.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.insertColumn):
If the new column includes theheaderViewcolumn data property,
it should take priority overtitleDOMFragmentand title text.
The specified View object is inserted into the DOM under the
column's <th> element, and added as a subview of the data grid.
(WebInspector.DataGrid.prototype.layout):
Update header views after performing default layout.
(WebInspector.DataGrid.prototype._showColumn):
Sethiddencolumn property false instead of deleting it.
(WebInspector.DataGrid.prototype._positionHeaderViews):
Update the left and right style positions for all Views embedded in
column header cells, then update their layouts.
(WebInspector.DataGrid.prototype.resizerDragging):
Update header views after column resizers are repositioned.
- 5:19 PM Changeset in webkit [195521] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, update test after r195497
This test did not make much sense as it was, after the behavior change
in r195497.
- fast/dom/Document/document-charset-expected.txt:
- fast/dom/Document/document-charset.html:
- 5:11 PM Changeset in webkit [195520] by
-
- 45 edits2 adds in trunk
An XMLDocument interface should be exposed on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153378
<rdar://problem/24315465>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C DOM and HTML tests now that more checks are
passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Document-constructor-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Expose an XMLDocument interface on the global Window object, as per:
DOMImplementation.createDocument() now returns an XMLDocument instead
of a Document, as per:
Previously, WebKit would alias XMLDocument to Document which caused
some W3C tests to fail.
Chrome and Firefox already match the specification here.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDocumentCustom.cpp:
(WebCore::createNewDocumentWrapper):
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.h:
- dom/DOMImplementation.idl:
- dom/Document.cpp:
(WebCore::Document::cloneDocumentWithoutChildren):
- dom/Document.h:
(WebCore::Document::isXMLDocument):
(WebCore::Document::create): Deleted.
(WebCore::Document::createNonRenderedPlaceholder): Deleted.
- dom/XMLDocument.h: Added.
(WebCore::XMLDocument::create):
(WebCore::XMLDocument::createXHTML):
(WebCore::XMLDocument::XMLDocument):
(isType):
- dom/XMLDocument.idl: Added.
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):
- page/DOMWindow.idl:
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::SVGDocument):
- svg/SVGDocument.h:
- svg/SVGDocument.idl:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
LayoutTests:
Rebaseline some layout tests now that XMLDocument is exposed.
- fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt:
- fast/dom/DOMImplementation/script-tests/createDocument-namespace-err.js:
- fast/dom/Document/clone-node-expected.txt:
- fast/dom/Document/clone-node.html:
- fast/dom/Document/xml-document-focus-expected.txt:
- fast/dom/Document/xml-document-focus.xml:
- fast/dom/dom-parse-serialize-display-expected.txt:
- fast/dom/dom-parse-serialize-expected.txt:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt:
- http/tests/xmlhttprequest/supported-xml-content-types-expected.txt:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- 4:58 PM Changeset in webkit [195519] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Highlight timeline range handles on hover
https://bugs.webkit.org/show_bug.cgi?id=153395
<rdar://problem/24312364>
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .selection-handle.clamped):
Gardening. No need to repeat "1px solid".
(.timeline-ruler > .selection-handle:hover, .timeline-ruler > .selection-handle:active):
":active" pseudo selector is needed to keep the handle highligted while it's being dragged
regardress if the mouse cursor is hovering over it or not.
- 3:43 PM Changeset in webkit [195518] by
-
- 3 edits in trunk/LayoutTests
New WK1 baselines.
- platform/mac-wk1/displaylists/extent-includes-shadow-expected.txt:
- platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt:
- 3:42 PM Changeset in webkit [195517] by
-
- 9 edits in trunk
Modern IDB: Support IDBObjectStore.createIndex in the SQLite backing store.
https://bugs.webkit.org/show_bug.cgi?id=153410
Reviewed by Darin Adler.
Source/WebCore:
No new tests (Covered by unskipping many existing tests).
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
- Modules/indexeddb/server/SQLiteIDBCursor.h:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor):
- Modules/indexeddb/server/SQLiteIDBTransaction.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 12:39 PM Changeset in webkit [195516] by
-
- 7 edits in trunk
Make the dumped display list representation a bit more compact
https://bugs.webkit.org/show_bug.cgi?id=153409
Reviewed by Zalan Bujtas.
Source/WebCore:
Don't make a group for every display list item.
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::asText):
LayoutTests:
Updated results.
- displaylists/extent-includes-shadow-expected.txt:
- displaylists/extent-includes-transforms-expected.txt:
- displaylists/layer-dispay-list-expected.txt:
- displaylists/replay-skip-clipped-rect-expected.txt:
- 12:39 PM Changeset in webkit [195515] by
-
- 14 edits3 adds in trunk
Add testing for display list replay, and skip clipped-out items on replay
https://bugs.webkit.org/show_bug.cgi?id=153408
Reviewed by Zalan Bujtas.
Source/WebCore:
Make it possible to save and serialize a DisplayList of Items which were
actually applied on replay, so that replay-time optimizations can be tested.
This exposes internals.setElementTracksDisplayListReplay() and
internals.replayDisplayListForElement().
Do a trivial replay-time optimization, which is to skip items whose extents are
outside the replay clip.
Test: displaylists/replay-skip-clipped-rect.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayer::isTrackingDisplayListReplay):
(WebCore::GraphicsLayer::replayDisplayListAsText):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::layerDisplayListMap): Use a singleton map to store the replay display lists
to avoid bloating GraphicsLayerCA for test-only code. The map stores a pair of the
replay list and a clip rect, which are both dumped. Dumping the clip rect ensures that
we're reporting the replay for the correct tile in a test (since there will be a replay
for each tile).
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayerCA::replayDisplayListAsText):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/displaylists/DisplayList.h:
(WebCore::DisplayList::DisplayList::appendItem):
- platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::Replayer::replay): In the unlikely event of tracking replays,
allocate a new DisplayList and append to it items which actually get applied.
- platform/graphics/displaylists/DisplayListReplayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setIsTrackingDisplayListReplay):
(WebCore::RenderLayerBacking::replayDisplayListAsText):
- rendering/RenderLayerBacking.h:
- testing/Internals.cpp:
(WebCore::Internals::setElementTracksDisplayListReplay):
(WebCore::Internals::replayDisplayListForElement):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Test that a clipped-out rectangle is not painted.
In order to get the rect into the display list, we need to make the target
compositing layer be tiled, and to be clipped by an ancestor so that only the
second tile renders. (This complexity is required because in simpler scenarios,
the rect is clipped out at recording time.)
- displaylists/replay-skip-clipped-rect-expected.txt: Added.
- displaylists/replay-skip-clipped-rect.html: Added.
- displaylists/resources/dump-target-replay-list.js: Added.
(doTest):
- 12:39 PM Changeset in webkit [195514] by
-
- 2 edits in trunk/LayoutTests
Layout Test displaylists/extent-includes-transforms.html is flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=153308
Reviewed by Dan Bernstein.
Rather than assuming that a zero-delay timer will fire after the next layer flush,
force a flush with testRunner.display(), which fixes flakiness.
- displaylists/resources/dump-target-display-list.js:
(doTest):
- 9:06 AM Changeset in webkit [195513] by
-
- 2 edits in trunk/Tools
Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
- LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
