Timeline
Aug 27, 2016:
- 10:55 PM Changeset in webkit [205097] by
-
- 8 edits in trunk
URLParser should parse relative URLs
https://bugs.webkit.org/show_bug.cgi?id=161282
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-27
Reviewed by Darin Adler.
Source/WebCore:
Partially covered by new API tests, but once the parser is complete enough we can
use the url web platform tests to more fully test this. It's still a work in
progress only used by tests.
- platform/URLParser.cpp:
(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
Added some helper functions to reduce redundant code. When parsing relative URLs,
we often want to copy large parts of the base URL, but the stopping point differs.
(WebCore::URLParser::parse):
The parser now returns a URL instead of an Optional<URL> because a URL has a m_isValid which behaves like Optional.
- platform/URLParser.h:
(WebCore::URLParser::parse):
Source/WTF:
- wtf/text/StringView.h:
Use a std::reference_wrapper for the StringView& to make it reassignable so we can add an operator=.
Tools:
- TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
Added some tests for the new operator=.
Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::shouldFail):
Add some relative URL tests.
- 10:29 PM Changeset in webkit [205096] by
-
- 15 edits in trunk
Update generated bindings to throw a SecurityError when denying cross-origin access to properties
https://bugs.webkit.org/show_bug.cgi?id=161270
Reviewed by Darin Adler.
Source/WebCore:
Update generated bindings to throw a SecurityError when denying cross-origin
access to properties, as per the HTML specification:
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)
- https://html.spec.whatwg.org/#crossoriginproperties-(-o-)
Firefox and Chrome already throw but Webkit was logging an error message and
returning undefined instead.
No new tests, updated existing tests.
- bindings/js/JSDOMBinding.cpp:
(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToNode):
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
LayoutTests:
Update / rebaseline existing tests to reflect behavior change.
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
- http/tests/security/cross-frame-access-call-expected.txt:
- http/tests/security/cross-frame-access-call.html:
- http/tests/security/cross-origin-window-property-access-expected.txt:
- http/tests/security/location-cross-origin-expected.txt:
- http/tests/security/location-cross-origin.html:
- http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
- http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
- http/tests/security/xss-DENIED-method-with-iframe-proto.html:
- 10:24 PM Changeset in webkit [205095] by
-
- 3 edits in trunk/Source/WebCore
Follow-up fixes after r205030.
https://bugs.webkit.org/show_bug.cgi?id=161216
Reviewed by Darin Adler.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
- html/parser/HTMLParserIdioms.h:
- 6:27 PM Changeset in webkit [205094] by
-
- 13 edits in trunk
WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-27
Source/WebKit2:
Reviewed by Darin Adler
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAutomaticLinkDetectionEnabled): Added WKBundleSetAutomaticLinkDetectionEnabled definition.
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetAutomaticLinkDetectionEnabled declaration.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
- WebProcess/InjectedBundle/InjectedBundle.h: Added setAutomaticLinkDetectionEnabled declaration.
- WebProcess/WebProcess.h: Declared setTextCheckerState public.
Tools:
Reviewed by Darin Adler.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
LayoutTests:
Reviewed by Darin Adler.
- platform/wk2/TestExpectations: Removed 2 now passing tests.
- 5:40 PM Changeset in webkit [205093] by
-
- 71 edits in trunk/Source/WebCore
Add final keyword to final classes and overriden methods in WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=161182
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-08-27
Reviewed by Darin Adler.
- Mark classes in the WebCore/css directory final as appropriate.
- Update WebCore/css classes so that overriden methods in final classes are marked final.
- css/CSSAnimationTriggerScrollValue.h:
- css/CSSAspectRatioValue.h:
- css/CSSBasicShapes.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.cpp:
(WebCore::determineCategory):
- css/CSSCalculationValue.h:
- css/CSSCanvasValue.h:
- css/CSSCharsetRule.h:
- css/CSSComputedStyleDeclaration.h:
- css/CSSContentDistributionValue.h:
- css/CSSCrossfadeValue.h:
- css/CSSCursorImageValue.h:
- css/CSSCustomPropertyValue.h:
- css/CSSFilterImageValue.h:
- css/CSSFontFaceLoadEvent.h:
- css/CSSFontFaceSrcValue.h:
- css/CSSFontFeatureValue.h:
- css/CSSFontSelector.h:
- css/CSSFontValue.h:
- css/CSSFunctionValue.h:
- css/CSSGradientValue.h:
- css/CSSGridAutoRepeatValue.h:
- css/CSSGridLineNamesValue.h:
- css/CSSGridTemplateAreasValue.h:
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSKeyframeRule.h:
- css/CSSKeyframesRule.h:
- css/CSSLineBoxContainValue.h:
- css/CSSNamedImageValue.h:
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSRevertValue.h:
- css/CSSRuleList.h:
- css/CSSSegmentedFontFace.h:
- css/CSSShadowValue.h:
- css/CSSStyleSheet.cpp:
- css/CSSStyleSheet.h:
- css/CSSSupportsRule.h:
- css/CSSTimingFunctionValue.h:
- css/CSSUnicodeRangeValue.h:
- css/CSSUnknownRule.h:
- css/CSSUnsetValue.h:
- css/CSSValue.cpp:
- css/CSSVariableDependentValue.h:
- css/CSSVariableValue.h:
- css/Counter.h:
- css/DOMCSSNamespace.h:
- css/DashboardRegion.h:
- css/LengthRepeat.h:
- css/MediaList.h:
- css/MediaQueryList.h:
- css/MediaQueryMatcher.h:
- css/Pair.h:
- css/PropertySetCSSStyleDeclaration.h:
- css/RGBColor.h:
- css/Rect.h:
- css/StyleMedia.h:
- css/StyleProperties.h:
- css/StyleRule.h:
- css/StyleRuleImport.h:
- css/StyleSheetContents.h:
- css/StyleSheetList.h:
- css/ViewportStyleResolver.h:
- css/WebKitCSSFilterValue.h:
- css/WebKitCSSRegionRule.h:
- css/WebKitCSSTransformValue.h:
- css/WebKitCSSViewportRule.h:
- 5:36 PM Changeset in webkit [205092] by
-
- 6 edits in trunk/Source
Add more Editing logging
https://bugs.webkit.org/show_bug.cgi?id=161287
Reviewed by Darin Adler.
Add logging which tracks how key events get from the UI process to the
web process, and down to form fields.
- editing/Editor.cpp:
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::appliedEditing):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
- 5:15 PM Changeset in webkit [205091] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unused cxxabi.h include in JSGlobalObjectInspectorController.cpp
https://bugs.webkit.org/show_bug.cgi?id=161120
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2016-08-27
Reviewed by Darin Adler.
- inspector/JSGlobalObjectInspectorController.cpp:
- 5:14 PM Changeset in webkit [205090] by
-
- 2 edits in trunk
[Win] Enable 'warning as error' compiler setting.
https://bugs.webkit.org/show_bug.cgi?id=161243
Reviewed by Darin Adler.
- Source/cmake/OptionsWin.cmake:
- 5:13 PM Changeset in webkit [205089] by
-
- 6 edits in trunk
Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
https://bugs.webkit.org/show_bug.cgi?id=28685
<rdar://problem/16460975>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-27
Reviewed by Darin Adler.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- WebInspectorUI.xcodeproj/project.pbxproj:
Convert the file to UTF-8. Future diffs should display as text.
Tools:
- Scripts/extract-localizable-js-strings:
- Scripts/update-webkit-localizable-strings:
WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
this script still use UTF-16, so keep that the default.
- 5:12 PM Changeset in webkit [205088] by
-
- 16 edits5 deletes in trunk
Remove more custom JavaScript bindings
https://bugs.webkit.org/show_bug.cgi?id=161293
Patch by Sam Weinig <sam@webkit.org> on 2016-08-27
Reviewed by Darin Adler.
Source/WebCore:
Remove custom bindings for AudioContext, DOMFormData, MediaSession and WebKitPoint.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::MediaSession):
- Modules/mediasession/MediaSession.h:
Change to take Document explicitly, since that is what it
expecting.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
- Modules/webaudio/AudioContext.h:
Remove unused ExceptionCode parameter.
- Modules/webaudio/AudioContext.idl:
- html/DOMFormData.idl:
- html/HTMLFormElement.idl:
- page/WebKitPoint.idl:
Switch to use the generated constructor.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Remove files.
- bindings/js/JSAudioContextCustom.cpp: Removed.
- bindings/js/JSDOMFormDataCustom.cpp: Removed.
- bindings/js/JSMediaSessionCustom.cpp: Removed.
- bindings/js/JSWebKitPointCustom.cpp: Removed.
Remove in favor of generated variants.
- bindings/js/JSHTMLInputElementCustom.h: Removed.
Remove unused header.
- page/WebKitPoint.h:
(WebCore::WebKitPoint::create):
(WebCore::WebKitPoint::WebKitPoint):
Move NaN replacement into the implementation and out of the bindings.
LayoutTests:
- webaudio/audionode-expected.txt:
- webaudio/audionode.html:
Update test for correct behavior of the constructor.
- 5:11 PM Changeset in webkit [205087] by
-
- 2 edits in trunk/Tools
REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
https://bugs.webkit.org/show_bug.cgi?id=161254
Reviewed by Darin Adler.
Simplify the CSS. My understanding that the CSS was correct, and the root cause
is tracked in bug 160478.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
- 5:10 PM Changeset in webkit [205086] by
-
- 9 edits in trunk/LayoutTests
Race between creating/deleting a database in test
https://bugs.webkit.org/show_bug.cgi?id=161285
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-27
Reviewed by Darin Adler.
Because IndexedDB creation is asynchronous, we were not waiting for the
database to be completely open before sending more commands. These
could race and give unexpected results. Wait for the database to be
successfully created before interacting with it.
- inspector/indexeddb/resources/utilities.js:
(createEmptyDatabase):
(createDatabaseWithStores):
Send a single when the database creation is completed.
- inspector/indexeddb/clearObjectStore-expected.txt:
- inspector/indexeddb/clearObjectStore.html:
- inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
- inspector/indexeddb/requestData-expected.txt:
- inspector/indexeddb/requestDatabase-expected.txt:
- inspector/indexeddb/requestDatabase.html:
- inspector/indexeddb/requestDatabaseNames.html:
Listen for the database created signal before proceeding
with the test.
- 3:13 PM Changeset in webkit [205085] by
-
- 9 edits2 adds in trunk
Source/WebCore:
Add adopted callback for custom elements
https://bugs.webkit.org/show_bug.cgi?id=161284
Reviewed by Antti Koivisto.
Added the support for adoptedCallback: https://dom.spec.whatwg.org/#concept-node-adopt
For now, we only support this callback on appendChild.
Test: fast/custom-elements/adopted-callback.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::invokeCallback): Added JSDOMGlobalObject* as an argument to the callback so that
we can invoke toJS on Document in invokeAdoptedCallback.
(WebCore::JSCustomElementInterface::setAdoptedCallback): Added.
(WebCore::JSCustomElementInterface::invokeAdoptedCallback): Added.
(WebCore::JSCustomElementInterface::setAttributeChangedCallback):
- bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::hasConnectedCallback): Added.
(WebCore::JSCustomElementInterface::hasDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::hasAdoptedCallback): Added.
- bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::define):
- dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueueItem::CustomElementReactionQueueItem): Added a variant that takes two documents.
(WebCore::CustomElementReactionQueueItem::invoke):
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded): Fixed a bug that this function was always
enqueuing a callback even when the interface didn't have connectedCallback. Also, there is no need to check
the nullity of the interface since it should never be null.
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded): Added.
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded): Assert that the interface is never
null instead of exiting early.
- dom/CustomElementReactionQueue.h:
- dom/Element.cpp:
(WebCore::Element::didMoveToNewDocument): Added a call to enqueueAdoptedCallbackIfNeeded.
LayoutTests:
adoptcallback
Add adopted callback for custom elements
https://bugs.webkit.org/show_bug.cgi?id=161284
Reviewed by Antti Koivisto.
- fast/custom-elements/adopted-callback-expected.txt: Added.
- fast/custom-elements/adopted-callback.html: Added.
- fast/custom-elements/resources/document-types.js:
(const.DocumentTypes.create):
- 2:34 PM Changeset in webkit [205084] by
-
- 2 edits in trunk/Source/WebCore
Fix the !PLATFORM(WIN) && USE(CURL) build.
https://bugs.webkit.org/show_bug.cgi?id=161281
Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2016-08-27
Reviewed by Alex Christensen.
- platform/network/curl/ResourceHandleCurl.cpp:
- 1:55 PM Changeset in webkit [205083] by
-
- 2 edits in trunk/LayoutTests
html/dom/interfaces.html is flaky due to WebSocket test
https://bugs.webkit.org/show_bug.cgi?id=161290
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
- platform/mac/TestExpectations: Making html/dom/interfaces.html expectation specific to Release.
- 1:47 PM Changeset in webkit [205082] by
-
- 8 edits in trunk
[Fetch API] Opaque responses should not have any body
https://bugs.webkit.org/show_bug.cgi?id=161130
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/cors/cors-basic.js:
(cors): Adding response body checking.
Source/WebCore:
Covered by updated test.
Added a new ThreadableLoader option to receive or not opaque response body.
By default, option is set to Receive.
FetchLoader is setting it to DoNotReceive.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse): Calling didFinishLoading just after didReceiveResponse in case of Opaque responses.
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
- loader/ThreadableLoader.h:
- loader/WorkerThreadableLoader.cpp:
(WebCore::LoaderTaskOptions::LoaderTaskOptions):
- 11:43 AM Changeset in webkit [205081] by
-
- 6 edits in trunk
[Fetch API] opaqueredirect responses should have their URL set to the original URL
https://bugs.webkit.org/show_bug.cgi?id=161194
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/redirect/redirect-mode.html:
- web-platform-tests/fetch/api/redirect/redirect-mode.js:
(redirectMode): Updating test to ease the computation of the absolute URL.
Source/WebCore:
Covered by updated tests.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
- loader/SubresourceLoader.cpp: Removing isNull ASSERT since we now set the response URL.
(WebCore::SubresourceLoader::willSendRequestInternal): Setting opaqueredirect response URL to the original URL.
- 11:07 AM Changeset in webkit [205080] by
-
- 7 edits in trunk
Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
https://bugs.webkit.org/show_bug.cgi?id=161217
Reviewed by Ryosuke Niwa.
Tools:
"run-webkit-tests --print-expectations" runs the same logic as running the tests, but
dumps out the lists of tests that would be run and skipped, and, for each, the entry
in TestExpectations that determines the expected outcome of the test.
This is an improved version of webkit-patch print-expectations.
See bug for sample output.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._print_expectations_for_subset): Print out the list of tests and expected
outcome for some subset of tests.
(Manager.print_expectations): Do the same splitting by device class that running tests
does, and for each subset of tests, call _print_expectations_for_subset.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.expectation_for_skipped_test): Set the flag
expectation_line.not_applicable_to_current_platform
(TestExpectationLine.init): Init not_applicable_to_current_platform to False
(TestExpectationLine.expected_behavior): line.expectation is PASS by default,
even for skipped tests. This function returns a list relevant for display, taking the skipped
modifier into account.
(TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
(TestExpectations.readable_filename_and_line_number): Return something printable for
lines with and without filenames
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main): Handle options.print_expectations
(parse_args): Add support for --print-expectations
(_print_expectations):
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_child_processes): Make this a debug log.
LayoutTests:
Explicitly skip fast/viewport
- platform/mac/TestExpectations:
- 10:45 AM Changeset in webkit [205079] by
-
- 4 edits in trunk
script.text should behave like script.textContent on setting
<https://webkit.org/b/148852>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
Source/WebCore:
HTMLScriptElement.text should behave just like .textContent when setting,
so just forward setText() to setTextContent().
Test: import/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-text.html
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- 8:09 AM Changeset in webkit [205078] by
-
- 2 edits in trunk/LayoutTests
html/dom/interfaces.html is flaky due to WebSocket test
https://bugs.webkit.org/show_bug.cgi?id=161290
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
- platform/mac/TestExpectations: Marking html/dom/interfaces.html expectation from Skip to Pass|Failure.
- 7:31 AM Changeset in webkit [205077] by
-
- 94 edits1 move4 adds1 delete in trunk/LayoutTests
Sync web-platform-tests up to revision e827374
https://bugs.webkit.org/show_bug.cgi?id=161231
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.
- resources/ImportExpectations: Skipped some new test suites. Added 'url' test suite as Import.
- resources/TestRepositories: Updated revision to e827374
- resources/web-platform-tests-modules.json:
- web-platform-tests/XMLHttpRequest/abort-during-upload-expected.txt:
- web-platform-tests/XMLHttpRequest/abort-during-upload.htm:
- web-platform-tests/XMLHttpRequest/abort-event-order.htm:
- web-platform-tests/XMLHttpRequest/event-error-expected.txt:
- web-platform-tests/XMLHttpRequest/event-error-order.sub-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/event-error-order.sub.html: Added.
- web-platform-tests/XMLHttpRequest/event-error.html:
- web-platform-tests/XMLHttpRequest/event-error.sub-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/event-error.sub.html: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/event-error.html.
- web-platform-tests/XMLHttpRequest/event-progress.htm:
- web-platform-tests/XMLHttpRequest/resources/trickle.py:
(main):
- web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
- web-platform-tests/XMLHttpRequest/resources/xmlhttprequest-event-order.js: Added.
(global.prepare_xhr_for_event_order_test):
(global.assert_xhr_event_order_matches):
- web-platform-tests/XMLHttpRequest/response-data-progress-expected.txt:
- web-platform-tests/XMLHttpRequest/response-data-progress.htm:
- web-platform-tests/XMLHttpRequest/response-method-expected.txt:
- web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
- web-platform-tests/XMLHttpRequest/security-consideration.sub.html:
- web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
- web-platform-tests/XMLHttpRequest/send-no-response-event-order-expected.txt:
- web-platform-tests/XMLHttpRequest/send-no-response-event-order.htm:
- web-platform-tests/XMLHttpRequest/send-sync-response-event-order-expected.txt:
- web-platform-tests/XMLHttpRequest/send-sync-response-event-order.htm:
- web-platform-tests/XMLHttpRequest/w3c-import.log:
- web-platform-tests/common/get-host-info.sub.js: Added.
(get_host_info):
- web-platform-tests/common/w3c-import.log:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/interfaces.html:
- web-platform-tests/dom/nodes/attributes-expected.txt:
- web-platform-tests/dom/nodes/attributes.html:
- web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
- web-platform-tests/dom/traversal/TreeWalker-basic.html:
- web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
- web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
- web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
- web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
- web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
- web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
- web-platform-tests/domparsing/w3c-import.log:
- web-platform-tests/fetch/api/basic/scheme-about-expected.txt:
- web-platform-tests/fetch/api/basic/scheme-about-worker-expected.txt:
- web-platform-tests/fetch/api/basic/scheme-about.js:
(checkFetchResponse):
(checkKoUrl): Deleted.
- web-platform-tests/fetch/api/basic/w3c-import.log:
- web-platform-tests/fetch/api/cors/cors-cookies.js:
(corsCookies):
- web-platform-tests/fetch/api/cors/cors-redirect.js:
(corsRedirect):
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-basic.html:
- web-platform-tests/fetch/api/redirect/w3c-import.log:
- web-platform-tests/fetch/api/request/request-cache-expected.txt:
- web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm:
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub.html:
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html:
- web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub-expected.txt:
- web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html:
- web-platform-tests/html/dom/elements-forms.js:
- web-platform-tests/html/dom/elements-tabular.js:
- web-platform-tests/html/dom/elements/global-attributes/dataset-expected.txt:
- web-platform-tests/html/dom/elements/global-attributes/dataset.html:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/dom/reflection-forms-expected.txt:
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
- web-platform-tests/html/dom/reflection.js:
(ReflectionTests.typeMap.string_appeared_here.toString):
(ReflectionTests.typeMap.string_appeared_here.valueOf):
(ReflectionTests.typeMap.string_appeared_here.string_appeared_here):
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html:
- web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-event.html:
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.sub-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.sub.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort.html:
- web-platform-tests/html/semantics/interfaces-expected.txt:
- web-platform-tests/html/semantics/interfaces.html:
- web-platform-tests/html/semantics/interfaces.js:
- web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid.html:
- web-platform-tests/lint.whitelist:
- web-platform-tests/url/w3c-import.log: Added.
- 3:40 AM Changeset in webkit [205076] by
-
- 13 edits in trunk
[Fetch API] Blob type should be set from Response/Request contentType header
https://bugs.webkit.org/show_bug.cgi?id=161228
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/request/request-consume.html:
- web-platform-tests/fetch/api/request/request-headers-expected.txt:
- web-platform-tests/fetch/api/request/request-headers.html:
- web-platform-tests/fetch/api/response/response-consume-expected.txt:
- web-platform-tests/fetch/api/response/response-consume.html:
- web-platform-tests/fetch/api/response/response-init-002-expected.txt:
- web-platform-tests/fetch/api/response/response-init-002.html:
Source/WebCore:
Covered by updated tests.
Renaming FetchBody::m_mimeType to m_contentType since that better relates to Content-Type header.
Updated FetchRequest and FetchResponse to set m_contentType according request/response headers.
Handled the case of a Request created from JS, a Response created from JS and a Response created internally to
be used as resolve value in the fetch promise.
In case Content-Type is set but is empty, its empty value should be used for blob type.
Updated contentType checks to use isNull in lieu of isEmpty.
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::updateContentType): Routine to synchronize headers with m_contentType.
(WebCore::FetchBody::FetchBody): Renamed m_mimeType to m_contentType.
(WebCore::FetchBody::blob): Ditto.
- Modules/fetch/FetchBody.h: Ditto.
(WebCore::FetchBody::contentType):
(WebCore::FetchBody::setMimeType): Deleted.
(WebCore::FetchBody::mimeType): Deleted.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::setBody): set FetchBody::m_contentType according HTTP headers.
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::initializeWith): Ditto.
(WebCore::FetchResponse::BodyLoader::didReceiveResponse): Ditto.
- 2:18 AM Changeset in webkit [205075] by
-
- 3 edits in trunk/Source/WebKit2
[GTK][Threaded Compositor] Several flaky tests
https://bugs.webkit.org/show_bug.cgi?id=161242
Reviewed by Michael Catanzaro.
We still have a lot of flaky tests since we switched to the threaded compositor. The UI process might
take the screenshot too early, before everything is actually painted. I can't reproduce the problem, so this is
actually a speculative fix or workaround. Our implementation of DrawingArea::dispatchAfterEnsuringDrawing() is
quite simple, we just dispatch the callback in the next run loop iteration, which doesn't really ensures any
drawing at all. So, we can wait for draw events before dispatching the given callback. Since we don't really
know if draw events were already processed before dispatchAfterEnsuringDrawing() is called, or if there will be
more than one damage event in a short time, this patch waits up to 1 second for draw events, and if a draw
happens it stops if there isn't another draw event in the next 100ms. This should ensure a drawing if it was
really needed.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::DrawingMonitor):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::~DrawingMonitor):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::webViewDrawCallback):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::start):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::stop):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::didDraw):
(WebKit::DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing):
- UIProcess/DrawingAreaProxyImpl.h:
Aug 26, 2016:
- 10:47 PM Changeset in webkit [205074] by
-
- 2 edits in trunk/Tools
Keep trying to fix the build after r205057.
- MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
- 10:44 PM Changeset in webkit [205073] by
-
- 6 edits in trunk/Tools
Keep trying to fix the build after r205057.
- MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent config.h. This file is only meant to be built with Xcode anyway.
- MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile with Xcode 7.3 and deploy to iOS 9.0.
- MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
- MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
- MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
- 9:39 PM Changeset in webkit [205072] by
-
- 2 edits in trunk/Tools
Start trying to fix the build after r205057.
- MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
- 9:38 PM Changeset in webkit [205071] by
-
- 1 copy in tags/Safari-602.1.50.0.8
New tag.
- 8:48 PM Changeset in webkit [205070] by
-
- 2 edits in trunk/Tools
Remove Yosemite Leaks from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=161253
Reviewed by Anders Carlsson.
- TestResultServer/static-dashboards/builders.jsonp:
- 8:04 PM Changeset in webkit [205069] by
-
- 3 edits in trunk/Source/WebCore
Fix Windows build after r205065.
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/PannerNode.idl:
There's no WEB_AUDIO on Windows.
- 7:53 PM Changeset in webkit [205068] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r203535): Web Inspector: Inspector overlay node info has disappeared
https://bugs.webkit.org/show_bug.cgi?id=161264
Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.
No new tests. Fixing JavaScript error in Inspector overlay.
- inspector/InspectorOverlay.cpp:
(evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):
Add ASSERT to ensure that errors in the Inspector overlay will cause tests to crash.
- inspector/InspectorOverlayPage.js:
(DOMBuilder.prototype.appendTextNode):
Move textContent value to parameter of document.createTextNode.
- 7:51 PM Changeset in webkit [205067] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: inspector/indexeddb/deleteDatabaseNamesWithSpace.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=161283
Reviewed by Alex Christensen.
- inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
Add a short timeout between deleting a database and requesting database names
to reduce flakey results.
- 7:39 PM Changeset in webkit [205066] by
-
- 3 edits in trunk/Source/WTF
bitwise_cast uses inactive member of union
https://bugs.webkit.org/show_bug.cgi?id=161244
Patch by JF Bastien <jfbastien@apple.com> on 2016-08-26
Reviewed by Benjamin Poulain.
- wtf/Compiler.h:
Add COMPILER_HAS_CLANG_FEATURE
- wtf/StdLibExtras.h:
(WTF::bitwise_cast):
Fix C++ UB, add trivially-copyable check.
bitwise_cast stores into a union with one type and reads with
another, which is technically C++ undefined behavior because it's
accessing the wrong active member of the union. The better way to
do this is through memcpy, which compilers optimize as well
because it's known-size in known-not-to-escape storage (for small
types they'll inline and then convert stack memory access to SSA
values which may be in-register if that makes sense, which would
be a move between int/FP registers at worst).
The C++ Standard's section [basic.types] explicitly blesses memcpy:
For any trivially copyable type T, if two pointers to T point to
distinct T objects obj1 and obj2, where neither obj1 nor obj2 is a
base-class subobject, if the underlying bytes (1.7) making up obj1
are copied into obj2, 42 obj2 shall subsequently hold the same
value as obj1.
[Example:
T* t1p;
T* t2p;
provided that t2p points to an initialized object ...
std::memcpy(t1p, t2p, sizeof(T));
at this point, every subobject of trivially copyable type in *t1p contains
the same value as the corresponding subobject in *t2p
— end example ]
Whereas section [class.union] says:
In a union, at most one of the non-static data members can be
active at any time, that is, the value of at most one of the
non-static data members can be stored in a union at any time.
While we're at it, checking that sizeof(To) == sizeof(From) is
good, but we should also check that both types are trivially
copyable (can have a ctor, no dtor, and copy is defaulted as if by
memcpy for type and all subtypes). Unfortunately that trait isn't
implemented consistently in all recent compiler+stdlib
implementations, but recent clang has an equivalent builtin
(other compilers simply won't do the check, and will break on bots
with the right compilers which is better than the current silent
breakage). This builtin hack also avoids #include <type_traits>
which really doesn't save much.
- 7:01 PM Changeset in webkit [205065] by
-
- 108 edits7 deletes in trunk
Remove support for ENABLE_LEGACY_WEB_AUDIO
https://bugs.webkit.org/show_bug.cgi?id=161262
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Remove ENABLE_LEGACY_WEB_AUDIO
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Remove ENABLE_LEGACY_WEB_AUDIO.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::noteGrainOn): Deleted.
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioBufferSourceNode.idl:
(WebCore::AudioScheduledSourceNode::noteOn): Deleted.
(WebCore::AudioScheduledSourceNode::noteOff): Deleted.
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
Remove the looping attribute, as well as the noteOn, noteOff, and noteGrainOn functions.
- Modules/webaudio/AudioContext.idl:
Remove the createGainNode, createDelayNode and createJavaScriptNode functions.
- Modules/webaudio/AudioParam.idl:
Remove the setTargetValueAtTime function.
- Modules/webaudio/BiquadDSPKernel.cpp:
(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::type):
(WebCore::BiquadFilterNode::setType):
(WebCore::BiquadFilterNode::getFrequencyResponse):
- Modules/webaudio/BiquadFilterNode.h:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
(WebCore::BiquadProcessor::setType):
(WebCore::BiquadProcessor::getFrequencyResponse):
- Modules/webaudio/BiquadProcessor.h:
(WebCore::BiquadProcessor::type):
- bindings/js/JSBiquadFilterNodeCustom.cpp: Removed.
Rename BiquadProcessor::FilterType to BiquadFilterType and use it
directly from the IDL. Remove legacy filter constants from the IDL
and the need for a custom binding for the type attribute.
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::type): Deleted.
- Modules/webaudio/OscillatorNode.h:
(WebCore::OscillatorNode::type):
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::generateBasicWaveform):
- Modules/webaudio/PeriodicWave.h:
- bindings/js/JSOscillatorNodeCustom.cpp: Removed.
Remove noteOn and noteOff functions and the type integer constants.
Remove the need for a custom binding for the type attribute by renaming
the type enum OscillatorNode::Type and putting the enum in the IDL.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
(WebCore::PannerNode::distanceModel):
(WebCore::PannerNode::setDistanceModel):
(WebCore::PannerNode::panningModel): Deleted.
- Modules/webaudio/PannerNode.h:
(WebCore::PannerNode::panningModel):
- Modules/webaudio/PannerNode.idl:
- bindings/js/JSPannerNodeCustom.cpp: Removed.
- platform/audio/Distance.cpp:
(WebCore::DistanceEffect::DistanceEffect):
(WebCore::DistanceEffect::gain):
- platform/audio/Distance.h:
(WebCore::DistanceEffect::model):
(WebCore::DistanceEffect::setModel):
- platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::EqualPowerPanner):
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
- platform/audio/Panner.cpp:
(WebCore::Panner::create):
- platform/audio/Panner.h:
(WebCore::Panner::panningModel):
(WebCore::Panner::Panner):
Replace the panning model and distance model integer constants
with IDL enum support, removing the need for a custom binding.
Rename the supporting C++ enums to work with the bindings.
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::constructJSAudioContext):
Remove deprecated way of creating an offline context.
- WebCore.xcodeproj/project.pbxproj:
Update files.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Remove ENABLE_LEGACY_WEB_AUDIO
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Remove ENABLE_LEGACY_WEB_AUDIO.
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
- webaudio/audiobuffersource-loop-points.html:
- webaudio/audiobuffersource-multi-channels.html:
- webaudio/audiobuffersource-playbackState-expected.txt:
- webaudio/audiobuffersource-playbackState.html:
- webaudio/audiobuffersource-playbackrate.html:
- webaudio/audiochannelmerger-stereo.html:
- webaudio/audiochannelsplitter.html:
- webaudio/audionode-connect-order.html:
- webaudio/audionode-expected.txt:
- webaudio/audionode.html:
- webaudio/audioparam-connect-audioratesignal.html:
- webaudio/audioparam-summingjunction.html:
- webaudio/audioprocessingevent.html:
- webaudio/automatic-pull-node.html:
- webaudio/biquad-allpass.html:
- webaudio/biquad-bandpass.html:
- webaudio/biquad-getFrequencyResponse.html:
- webaudio/biquad-highpass.html:
- webaudio/biquad-highshelf.html:
- webaudio/biquad-lowpass.html:
- webaudio/biquad-lowshelf.html:
- webaudio/biquad-notch.html:
- webaudio/biquad-peaking.html:
- webaudio/biquadfilternode-basic-expected.txt:
- webaudio/biquadfilternode-basic.html:
- webaudio/convolution-mono-mono.html:
- webaudio/delaynode-max-default-delay.html:
- webaudio/delaynode-max-nondefault-delay.html:
- webaudio/delaynode-maxdelay.html:
- webaudio/delaynode-scheduling.html:
- webaudio/delaynode.html:
- webaudio/distance-exponential-expected.txt:
- webaudio/distance-exponential.html:
- webaudio/distance-inverse-expected.txt:
- webaudio/distance-inverse.html:
- webaudio/distance-linear-expected.txt:
- webaudio/distance-linear.html:
- webaudio/gain-basic.html:
- webaudio/gain.html:
- webaudio/javascriptaudionode-zero-input-channels.html:
- webaudio/javascriptaudionode.html:
- webaudio/mixing.html:
- webaudio/note-grain-on-play-expected.txt: Removed.
- webaudio/note-grain-on-play.html: Removed.
- webaudio/note-grain-on-timing-expected.txt: Removed.
- webaudio/note-grain-on-timing.html: Removed.
- webaudio/oscillator-basic-expected.txt:
- webaudio/oscillator-basic.html:
- webaudio/oscillator-custom.html:
- webaudio/oscillator-sawtooth.html:
- webaudio/oscillator-sine.html:
- webaudio/oscillator-square.html:
- webaudio/oscillator-triangle.html:
- webaudio/pannernode-basic-expected.txt:
- webaudio/pannernode-basic.html:
- webaudio/resources/audio-testing.js:
- webaudio/resources/audioparam-testing.js:
- webaudio/resources/biquad-testing.js:
- webaudio/resources/distance-model-testing.js:
- webaudio/resources/javascriptaudionode-testing.js:
- webaudio/resources/oscillator-testing.js:
- webaudio/resources/panner-model-testing.js:
- webaudio/sample-accurate-scheduling.html:
- webaudio/stereo2mono-down-mixing.html:
- webaudio/up-mixing-mono-51.html:
- webaudio/up-mixing-mono-stereo.html:
- webaudio/up-mixing-stereo-51.html:
- webaudio/waveshaper.html:
Update tests for removal of ENABLE_LEGACY_WEB_AUDIO.
- 5:36 PM Changeset in webkit [205064] by
-
- 4 edits1 add in trunk
[JSC] Implement CompareStrictEq(String, Untyped) in FTL
https://bugs.webkit.org/show_bug.cgi?id=161229
Reviewed by Geoffrey Garen.
JSTests:
- stress/compare-strict-eq-on-various-types.js: Added.
Source/JavaScriptCore:
Add (String, Untyped) uses to FTL CompareStrictEq.
This was the last use type not implemented, the node is fully
supported by FTL after this patch.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileStringToUntypedStrictEquality):
(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare):
Remove the type checks when possible.
- 5:33 PM Changeset in webkit [205063] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 5:30 PM Changeset in webkit [205062] by
-
- 8 edits in trunk/Source
Web Inspector: Frontend should have access to Resource Timing information
https://bugs.webkit.org/show_bug.cgi?id=160095
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-26
Reviewed by Alex Christensen.
Source/JavaScriptCore:
Rename ResourceTiming property.
- inspector/protocol/Network.json:
Rename navigationStart to startTime so it's applicable
for all resources and not just the main resource.
Source/WebCore:
Show correct information with Resource Timing information
from ResourceLoader rather than DocumentLoader.
No new tests, frontend doesn't use the timing data yet.
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::buildObjectForTiming): Deleted.
(WebCore::buildObjectForResourceResponse): Deleted.
(WebCore::buildObjectForCachedResource): Deleted.
Use ResourceLoader instead of DocumentLoader to get Resource Timing information.
Move functions to member functions to access the executionStopWatch.
(WebCore::InspectorNetworkAgent::didFinishLoading):
Use the load timing finishTime and convert to elapsed time for frontend.
- inspector/InspectorNetworkAgent.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
Pass the web process load timing on to the inspector.
Source/WTF:
Add method to get elapsed time for any monotonic time.
Used by InspectorNetworkAgent.
- wtf/Stopwatch.h:
(WTF::Stopwatch::elapsedTimeSinceMonotonicTime):
- 5:13 PM Changeset in webkit [205061] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, fix Windows build after r205048.
- bindings/scripts/CodeGeneratorJS.pm:
(getConditionalForFunctionConsideringOverloads):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload):
- bindings/scripts/test/TestObj.idl:
- 5:04 PM Changeset in webkit [205060] by
-
- 15 edits3 adds in trunk
Adopted custom element's callbacks should continue to work
https://bugs.webkit.org/show_bug.cgi?id=161065
Reviewed by Andreas Kling.
Source/WebCore:
When a custom element is adopted into another document, its reaction callbacks need to continue to work.
Because a different document may have its own global object, each custom element needs to remember its
original global object or JSCustomElementInterface. This patch adds the latter to the element rare data.
Tests: fast/custom-elements/connected-callbacks.html
fast/custom-elements/disconnected-callbacks.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::constructElement):
(WebCore::JSCustomElementInterface::upgradeElement):
- dom/CustomElementReactionQueue.cpp:
(WebCore::findInterfaceForCustomElement): Deleted.
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):
- dom/Element.cpp:
(WebCore::Element::insertedInto): Invoke callbacks even when the current document is not a HTML document.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::setCustomElementIsResolved): Moved from Node. Add the element interface to the rare data.
(WebCore::Element::customElementInterface): Added.
- dom/Element.h:
- dom/ElementRareData.cpp:
- dom/ElementRareData.h:
(WebCore::ElementRareData::customElementInterface): Added.
(WebCore::ElementRareData::setCustomElementInterface): Added.
- dom/Node.h:
((WebCore::Node::setCustomElementIsResolved): Deleted.
LayoutTests:
Added test cases for adopting custom elements into various kinds of documents.
- fast/custom-elements/connected-callbacks-expected.txt:
- fast/custom-elements/connected-callbacks.html:
- fast/custom-elements/defined-pseudo-class-expected.txt:
- fast/custom-elements/defined-pseudo-class.html:
- fast/custom-elements/disconnected-callbacks-expected.txt:
- fast/custom-elements/disconnected-callbacks.html:
- fast/custom-elements/resources/document-types.js: Added.
- fast/custom-elements/resources/empty-html-document.html: Added.
- 4:47 PM Changeset in webkit [205059] by
-
- 2 edits in trunk/LayoutTests
Marking webgl/max-active-contexts-webglcontextlost-prevent-default.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=161205
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:43 PM Changeset in webkit [205058] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/media/hls/hls-accessiblity-describes-video-menu.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=161144
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:28 PM Changeset in webkit [205057] by
-
- 4 edits26 adds in trunk
Add a test harness for running UI tests on the iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=161265
.:
Add the new MobileMiniBrowser project to the WebKit workspace.
Reviewed by Simon Fraser.
- WebKit.xcworkspace/contents.xcworkspacedata:
Tools:
Reviewed by Simon Fraser.
Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
can serve as a test harness for WebKit UI tests.
Also add a basic media playback test which verifies that a <video> element will begin playing in
fullscreen on an iPhone device, but will play inline on an iPad device.
- Makefile: Add MobileMiniBrowser as a Module for iOS builds.
- MobileMiniBrowser/Configurations/Base.xcconfig: Added.
- MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
- MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
- MobileMiniBrowser/Makefile: Added.
- MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
- MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
- MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
(-[AppDelegate application:didFinishLaunchingWithOptions:]):
(-[AppDelegate applicationWillResignActive:]):
(-[AppDelegate applicationDidEnterBackground:]):
(-[AppDelegate applicationWillEnterForeground:]):
(-[AppDelegate applicationDidBecomeActive:]):
(-[AppDelegate applicationWillTerminate:]):
- MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
- MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
- MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
- MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
- MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
- MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
(-[TabViewController dealloc]):
(-[TabViewController viewDidLoad]):
(-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
(-[TabViewController tableView:cellForRowAtIndexPath:]):
(-[TabViewController tableView:numberOfRowsInSection:]):
(-[TabViewController numberOfSectionsInTableView:]):
(-[TabViewController tableView:canEditRowAtIndexPath:]):
(-[TabViewController tableView:canMoveRowAtIndexPath:]):
(-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
(-[TabViewController tableView:didSelectRowAtIndexPath:]):
- MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
- MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
(-[WebViewController viewDidLoad]):
(-[WebViewController didReceiveMemoryWarning]):
(-[WebViewController reload:]):
(-[WebViewController goBack:]):
(-[WebViewController goForward:]):
(-[WebViewController urlFieldEditingBegan:]):
(-[WebViewController navigateTo:]):
(-[WebViewController showTabs:]):
(-[WebViewController selectWebViewAtIndex:]):
(-[WebViewController removeWebViewAtIndex:]):
(-[WebViewController addWebView]):
(-[WebViewController createWebView]):
(-[WebViewController removeWebView:]):
(-[WebViewController setCurrentWebView:]):
(-[WebViewController webView:didFailNavigation:withError:]):
(-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
- MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
(main):
- MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
- MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
(-[MobileMiniBrowserUITests setUp]):
(-[MobileMiniBrowserUITests tearDown]):
(-[MobileMiniBrowserUITests testBasicVideoPlayback]):
- 4:25 PM Changeset in webkit [205056] by
-
- 3 edits2 adds in trunk
ASSERT_NOT_REACHED() is touched in WebCore::minimumValueForLength
https://bugs.webkit.org/show_bug.cgi?id=125781
<rdar://problem/27684457>
Reviewed by Simon Fraser.
Source/WebCore:
RenderTableSection::calcRowLogicalHeight misused minimumValueForLength to fallback to 0 for non-fixed values.
While this patch fixes the assertion, the table section code needs works to support calc values. See webkit.org/b/161273.
Test: fast/table/assert-on-min-max-content-values.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
LayoutTests:
- fast/table/assert-on-min-max-content-values-expected.txt: Added.
- fast/table/assert-on-min-max-content-values.html: Added.
- 4:10 PM Changeset in webkit [205055] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/dom/focus-contenteditable.html for ios-simulator after r205044.
Unreviewed test gardening.
- platform/ios-simulator-wk2/fast/dom/focus-contenteditable-expected.txt:
- 3:52 PM Changeset in webkit [205054] by
-
- 2 edits in trunk/Tools
webkit-queues queue-status page should should list more recent statuses
https://bugs.webkit.org/show_bug.cgi?id=161220
Reviewed by Daniel Bates.
- QueueStatusServer/handlers/queuestatus.py:
(QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
- 3:41 PM Changeset in webkit [205053] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r204987): fast/canvas-composite-* tests are now flaky assertion failures
<https://webkit.org/b/161259>
Reviewed by Joseph Pecoraro.
Fix a blunder where HTMLCanvasElement::memoryCost() wasn't forwarding the inquiry
to ImageBuffer but HTMLCanvasElement::externalMemoryCost() was.
This fixes flaky "externalMemorySize() <= extraMemorySize()" assertions on debug bots.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::memoryCost):
- 3:16 PM Changeset in webkit [205052] by
-
- 3 edits in trunk/Source/WebKit2
Get rid of NetworkResourceLoader::sendAbortingOnFailure
https://bugs.webkit.org/show_bug.cgi?id=161267
Reviewed by Dan Bernstein.
NetworkResourceLoader::sendAbortingOnFailure sends an IPC message, and if IPC::Connection::send returns false,
it will abort the network resource load.
IPC::Connection::send will only return false if the connection is invalid, and when it becomes invalidated the
connection client member function "didClose" is invoked. For the network process, this will call abort on all outstanding
network loads.
Auditing all the sendAbortingOnFailure call sites, shows that none of them can be called with an invalid connection,
so replace sendAbortingOnFailure with send.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
This is a NetworkLoadClient function which won't be called if the load has been aborted.
(WebKit::NetworkResourceLoader::didReceiveBuffer):
Ditto.
(WebKit::NetworkResourceLoader::didFinishLoading):
Ditto. Also, update a call to sendBufferMaybeAborting to sendBuffer.
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
This is another NetworkLoadClient function.
(WebKit::NetworkResourceLoader::bufferingTimerFired):
The buffering timer is stopped when abort() is called.
(WebKit::NetworkResourceLoader::sendBuffer):
Rename this from sendBufferMaybeAborting. It has three call sites:
- didReceiveBuffer and didFinishLoading are both NetworkLoadClient functions.
- didRetrieveCacheEntry is called from didFinishLoading (a NetworkLoadClient function) and from the completion function of retrieveCacheEntry, which has an early return for when the loader has been aborted.
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
This is called from the retrieveCacheEntry completion function, which has an early return for when the loader has been aborted.
(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):
Ditto.
(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Deleted.
- NetworkProcess/NetworkResourceLoader.h:
- 3:07 PM Changeset in webkit [205051] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update expectations of tests that can either crash or timeout on iOS simulator WK1
- platform/ios-simulator-wk1/TestExpectations:
- 2:46 PM Changeset in webkit [205050] by
-
- 9 edits in trunk
The :enabled/:disabled selectors should only match elements that can be disabled.
<https://webkit.org/b/161255>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:
Source/WebCore:
Per the HTML spec, only the following elements can be actually disabled:
button, input, select, textarea, optgroup, option, menuitem, fieldset
Since HTMLOutputElement inherits from HTMLFormControlElement, it had some
misguided ideas about being disableable. This was causing it to get matched
by :enabled and :disabled selectors.
Test: imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesDisabledPseudoClass):
(WebCore::matchesEnabledPseudoClass): Renamed from isEnabled/isDisabled. Now only allows
:enabled and :disabled selectors to match elements that are actually disableable.
- html/HTMLElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::canBeActuallyDisabled):
(WebCore::HTMLElement::isActuallyDisabled): Added supporting functions for the aforementioned selectors.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::parseAttribute): Don't care about disabled state
changes in elements that are not disableable in the first place.
- 2:41 PM Changeset in webkit [205049] by
-
- 2 edits in trunk/LayoutTests
Skipping imported/w3c/web-platform-tests/html/dom/interfaces.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=161142
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:34 PM Changeset in webkit [205048] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r204028): Fix unused-but-set-variable warning in generated JSNavigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=161252
Reviewed by Ryosuke Niwa.
Improve support for [Conditional] with overloaded operations in the IDL.
No new tests, updated bindings tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GeneratePropertiesHashTable):
(getConditionalForFunctionConsideringOverloads):
(GenerateOverloadedFunctionOrConstructor):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation): Deleted.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload):
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Deleted.
- bindings/scripts/test/TestObj.idl:
- 2:23 PM Changeset in webkit [205047] by
-
- 5 edits3 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 tables tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/tables/mozilla/bugs/bug30559-expected.txt:
- platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
- platform/ios-simulator-wk1/transitions/default-timing-function-expected.txt: Added.
- 2:20 PM Changeset in webkit [205046] by
-
- 6 edits1 copy2 adds in trunk/Source/WebInspectorUI
Web Inspector: Add protocol version for iOS 10
https://bugs.webkit.org/show_bug.cgi?id=161266
<rdar://problem/28036594>
Rubber-stamped by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
Update missing localized strings.
- Versions/Inspector-iOS-10.0.json: Added.
Protocol for iOS 10.
- UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
Re-generate the legacy backend commands files.
- 2:14 PM Changeset in webkit [205045] by
-
- 2 edits in trunk/Source/bmalloc
2016-08-26 Geoffrey Garen <ggaren@apple.com>
Unreviewed build fix.
Fix the CMake build.
- CMakeLists.txt:
- 2:11 PM Changeset in webkit [205044] by
-
- 4 edits2 adds in trunk
charactersAroundPosition can be wrong because it crosses editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=161215
-and corresponding-
rdar://problem/27933564
Reviewed by Ryosuke Niwa.
Source/WebCore:
charactersAroundPosition() should not cross editing boundaries. This patch fixes
that by making nextCharacterBoundaryInDirection() take an
EditingBoundaryCrossingRule parameter to pass onto VisiblePosition::next() and
VisiblePosition::previous().
- editing/VisibleUnits.cpp:
(WebCore::nextCharacterBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::charactersAroundPosition):
LayoutTests:
New test.
- editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt: Added.
- editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html: Added.
This test is going back to its pre-https://trac.webkit.org/changeset/195078 state.
That change caused this test to have a different layout because it caused more
layouts to happen. Now that we don’t allow the call to charactersAroundPosition()
to cross editing boundaries, those layouts don’t happen, and we have the old
behavior back.
- platform/mac/fast/dom/focus-contenteditable-expected.txt:
- 1:59 PM Changeset in webkit [205043] by
-
- 5 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details sidebar
https://bugs.webkit.org/show_bug.cgi?id=161180
<rdar://problem/28003417>
Reviewed by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
New strings and file.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
Instantiate the global details sidebar.
- UserInterface/Views/StorageTabContentView.js:
(WebInspector.StorageTabContentView):
Include the new details sidebar in the Storage tab.
- UserInterface/Controllers/StorageManager.js:
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processKeyPath):
Use the protocol generated types.
- UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js: Added.
(WebInspector.IndexedDatabaseDetailsSidebarPanel):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.inspect):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype._keyPathString):
Show the sidebar for an IndexedDatabase, ObjectStore, or Index.
Show each section if we can based on the objects we have.
- 1:59 PM Changeset in webkit [205042] by
-
- 3 edits2 adds in trunk
Web Inspector: Test and address issues in IndexedDB.requestData
https://bugs.webkit.org/show_bug.cgi?id=161178
<rdar://problem/28002467>
Reviewed by Brian Burg.
Source/WebCore:
Test: inspector/indexeddb/requestData.html
- inspector/InspectorIndexedDBAgent.cpp:
(idbKeyRangeFromKeyRange):
Parsing was too strict. "lower" and "upper" keys are optional.
(WebCore::DataLoader::execute):
Ensure the skip count is passed forward.
LayoutTests:
- inspector/indexeddb/requestData-expected.txt: Added.
- inspector/indexeddb/requestData.html: Added.
- 1:59 PM Changeset in webkit [205041] by
-
- 9 edits2 adds in trunk
Web Inspector: Provide a way to clear an IndexedDB object store
https://bugs.webkit.org/show_bug.cgi?id=161167
<rdar://problem/27996932>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/IndexedDB.json:
Cleanup the protocol file.
Source/WebCore:
Test: inspector/indexeddb/clearObjectStore.html
- inspector/InspectorIndexedDBAgent.cpp:
Make the transaction for clearing an object store readwrite
instead of readonly, and activate it.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
"Clear object store".
- UserInterface/Controllers/StorageManager.js:
(WebInspector.StorageManager.prototype.clearObjectStore):
Provide a wrapper for clearing an object store.
- UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._clearButtonClicked):
Add a navigation button on ObjectStore content views to clear the object store.
LayoutTests:
- inspector/indexeddb/clearObjectStore-expected.txt: Added.
- inspector/indexeddb/clearObjectStore.html: Added.
- 1:59 PM Changeset in webkit [205040] by
-
- 3 edits4 adds in trunk/LayoutTests
Web Inspector: Test IndexedDB.requestDatabase
https://bugs.webkit.org/show_bug.cgi?id=161122
Reviewed by Brian Burg.
- inspector/indexeddb/requestDatabase-expected.txt: Added.
- inspector/indexeddb/requestDatabase.html: Added.
New tests.
- inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
- inspector/indexeddb/requestDatabaseNames.html:
Share code.
- inspector/indexeddb/resources/utilities.js: Added.
(deleteDatabaseNames):
(createEmptyDatabase):
(createDatabaseWithStores):
Helpers that can be used by each test.
- 1:59 PM Changeset in webkit [205039] by
-
- 5 edits in trunk/LayoutTests
Web Inspector: Modernize inspector/indexeddb tests
https://bugs.webkit.org/show_bug.cgi?id=161113
Reviewed by Brian Burg.
- inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt:
- inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
- inspector/indexeddb/requestDatabaseNames-expected.txt:
- inspector/indexeddb/requestDatabaseNames.html:
- 1:54 PM Changeset in webkit [205038] by
-
- 5 edits21 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 http tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt: Added.
- platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
- platform/ios-simulator-wk1/http/tests/dom/window-open-about-blank-and-access-document-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/cross-origin-modal-dialog-base-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/insecure-geolocation-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-xhr-sync-in-main-frame-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-expected.txt: Added.
- platform/ios-simulator-wk1/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 1:35 PM Changeset in webkit [205037] by
-
- 7 edits in trunk
Calling crossOriginWindow.toString() should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=161225
Reviewed by Andreas Kling.
Source/WebCore:
Calling crossOriginWindow.toString() should not be allowed:
In WebKit, we were printing a security error in the console but
returning "[object Window]" anyway.
In Firefox and Chrome, it throws an exception.
No new tests, updated existing test.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
LayoutTests:
Update existing tests to reflect the behavior change.
- http/tests/security/cross-frame-access-custom-expected.txt:
- http/tests/security/cross-frame-access-custom.html:
- http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
- http/tests/security/cross-frame-access-object-setPrototypeOf.html:
- 1:33 PM Changeset in webkit [205036] by
-
- 4 edits in trunk
[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
https://bugs.webkit.org/show_bug.cgi?id=161258
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/Cocoa/WKNSNumber.mm:
(-[WKNSNumber charValue]): Override this…
(-[WKNSNumber boolValue]): …not this.
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
(TestWebKitAPI::TEST):
- 1:29 PM Changeset in webkit [205035] by
-
- 19 edits in trunk
Web Inspector: Some CSS selectors in the UI aren't escaped
https://bugs.webkit.org/show_bug.cgi?id=151378
Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Change ElementData from sending a className string to using an array of
classes, allowing for proper escaping of each class value.
- inspector/protocol/OverlayTypes.json:
Source/WebCore:
No new tests, but logic and results of existing tests updated:
- inspector/dom/content-node-region-info.html:
- inspector/dom/content-node-region-info-expected.txt:
- inspector/dom/highlightNode-expected.txt:
- inspector/dom/highlightSelector.html:
- inspector/dom/highlightSelector-expected.txt:
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForElementData):
- inspector/InspectorOverlayPage.css:
(.pseudo-type):
(.tag-name): Deleted.
- inspector/InspectorOverlayPage.js:
(_createElementTitle):
Source/WebInspectorUI:
- UserInterface/Base/DOMUtilities.js:
(WebInspector.displayNameForNode): Deleted.
(WebInspector.linkifyNodeReference):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.get escapedIdSelector):
(WebInspector.DOMNode.prototype.get escapedClassSelector):
(WebInspector.DOMNode.prototype.get displayName):
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
Rework escaping of ids and class names into separate public functions using CSS.escape.
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
- UserInterface/Views/DOMTreeDataGridNode.js:
(WebInspector.DOMTreeDataGridNode.prototype._createNameCellDocumentFragment):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
- UserInterface/Views/DOMTreeElementPathComponent.js:
(WebInspector.DOMTreeElementPathComponent):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
- UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype.set layer):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection.prototype.update):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
LayoutTests:
- inspector/dom/content-node-region-info.html:
- inspector/dom/content-node-region-info-expected.txt:
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.
- inspector/dom/highlightNode-expected.txt:
- inspector/dom/highlightSelector.html:
- inspector/dom/highlightSelector-expected.txt:
Changed result to replace className with new classes array.
- 1:22 PM Changeset in webkit [205034] by
-
- 5 edits in trunk/Source/JavaScriptCore
Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects
https://bugs.webkit.org/show_bug.cgi?id=161213
<rdar://problem/28017986>
Reviewed by Brian Burg.
- inspector/agents/InspectorHeapAgent.cpp:
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
Don't take a final snapshot when disconnecting.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting):
- inspector/agents/InspectorScriptProfilerAgent.h:
- runtime/SamplingProfiler.h:
Don't process samples when disconnecting.
- 1:22 PM Changeset in webkit [205033] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
https://bugs.webkit.org/show_bug.cgi?id=161027
<rdar://problem/27871349>
Reviewed by Mark Lam.
For JSContext inspection, when a frontend connects keep the target alive.
This means ref'ing the JSGlobalObject / VM when the first frontend
connects and deref'ing when the last frontend disconnects.
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends): Deleted.
Now that frontends keep the global object alive, when the global object
is destroyed that must mean that no frontends exist. Remove the now
stale code path.
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Ref the target when the first frontend connects, deref when the last disconnects.
- 1:18 PM Changeset in webkit [205032] by
-
- 8 edits3 moves in trunk
Renamed XLarge* => Large*
https://bugs.webkit.org/show_bug.cgi?id=161261
Reviewed by Andreas Kling.
XLarge is not a thing anymore: We just have Small and Large.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/Heap.cpp:
(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::shrinkLarge):
(bmalloc::Heap::deallocateLarge):
- bmalloc/Heap.h:
- bmalloc/LargeMap.cpp: Copied from Source/bmalloc/bmalloc/XLargeMap.cpp.
(bmalloc::LargeMap::remove):
(bmalloc::LargeMap::add):
(bmalloc::XLargeMap::remove): Deleted.
(bmalloc::XLargeMap::add): Deleted.
- bmalloc/LargeMap.h: Copied from Source/bmalloc/bmalloc/XLargeMap.h.
(bmalloc::LargeMap::ranges):
(bmalloc::XLargeMap::ranges): Deleted.
- bmalloc/LargeRange.h: Copied from Source/bmalloc/bmalloc/XLargeRange.h.
(bmalloc::LargeRange::LargeRange):
(bmalloc::LargeRange::operator<):
(bmalloc::canMerge):
(bmalloc::merge):
(bmalloc::LargeRange::split):
(bmalloc::XLargeRange::XLargeRange): Deleted.
(bmalloc::XLargeRange::operator<): Deleted.
(bmalloc::XLargeRange::split): Deleted.
- bmalloc/VMHeap.cpp:
(bmalloc::VMHeap::tryAllocateLargeChunk):
- bmalloc/VMHeap.h:
- bmalloc/XLargeMap.cpp: Removed.
- bmalloc/XLargeMap.h: Removed.
- bmalloc/XLargeRange.h: Removed.
- 11:12 AM Changeset in webkit [205031] by
-
- 3 edits in trunk/Source/WebCore
Crash when getting font bounding rect
https://bugs.webkit.org/show_bug.cgi?id=161202
<rdar://problem/27986981>
Reviewed by Myles C. Maxfield.
We should never store GlyphData objects for later use, because they contain raw pointers to Font elements
contained in caches, and those font caches get periodically purged.
Instead, we should hold onto the ‘key’ representing the GlyphData, and simply ask the system for the
GlyphData the next time it is needed.
Tested by existing MathML tests under ASAN and GuardMalloc.
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::RenderMathMLToken): Clean up constructors.
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Use keys to get correct GlyphData when needed.
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.
(WebCore::RenderMathMLToken::firstLineBaseline): Ditto.
(WebCore::RenderMathMLToken::layoutBlock): Ditto.
(WebCore::RenderMathMLToken::paint): Ditto.
(WebCore::RenderMathMLToken::paintChildren): Ditto.
- rendering/mathml/RenderMathMLToken.h:
- 11:09 AM Changeset in webkit [205030] by
-
- 9 edits in trunk
HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
https://bugs.webkit.org/show_bug.cgi?id=161216
Reviewed by Andreas Kling.
LayoutTests/imported/w3c:
Rebaseline W3C test now that all checks are passing. Chrome is also passing all the checks.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt:
Source/WebCore:
HTMLAreaElement's coords attributes parsing does not comply with the HTML specification:
This patch aligns our parsing of this attribute with the specification and Chrome.
No new tests, rebaselined existing test.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::parseAttribute):
(WebCore::HTMLAreaElement::getRegion):
- html/HTMLAreaElement.h:
- html/parser/HTMLParserIdioms.cpp:
(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValuesInternal):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
(WebCore::parseHTMLNonNegativeInteger): Deleted.
- html/parser/HTMLParserIdioms.h:
LayoutTests:
Unskip web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html
as it is now passing and not longer crashing in debug builds.
- 11:00 AM Changeset in webkit [205029] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(WEB_SOCKETS) build
https://bugs.webkit.org/show_bug.cgi?id=161251
Reviewed by Alex Christensen.
- page/SocketProvider.h:
- 10:58 AM Changeset in webkit [205028] by
-
- 3 edits in trunk/Source/WebCore
Fix the !ENABLE(WEB_TIMING) build
https://bugs.webkit.org/show_bug.cgi?id=161250
Reviewed by Alex Christensen.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
- loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::resourceTimingInformation):
- 10:37 AM Changeset in webkit [205027] by
-
- 3 edits1 add in trunk
[ES6] newPromiseCapabilities should check the given argument is constructor
https://bugs.webkit.org/show_bug.cgi?id=161226
Reviewed by Mark Lam.
JSTests:
The arrow function should not be a constructor. So the error should be raised.
- stress/new-promise-capabilities-requires-constructor.js: Added.
(shouldThrow):
Source/JavaScriptCore:
Use @isConstructor.
- builtins/PromiseOperations.js:
- 10:36 AM Changeset in webkit [205026] by
-
- 40 edits in trunk
Trying to access cross-origin Location properties should throw a SecurityError
https://bugs.webkit.org/show_bug.cgi?id=161248
Reviewed by Alex Christensen.
Source/WebCore:
Trying to access cross-origin Location properties should throw a SecurityError:
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)
- https://html.spec.whatwg.org/#crossoriginproperties-(-o-)
Firefox and Chrome already throw. However, WebKit was logging an error message
and returning undefined.
No new tests, updated existing tests.
- bindings/js/JSDOMBinding.cpp:
(WebCore::throwSecurityError):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
LayoutTests:
Update existing tests to reflect behavior change.
- http/tests/plugins/cross-frame-object-access-expected.txt:
- http/tests/plugins/resources/cross-frame-object-access.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
- http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-custom-expected.txt:
- http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
- http/tests/security/cross-frame-access-history-get-expected.txt:
- http/tests/security/cross-frame-access-history-get-override-expected.txt:
- http/tests/security/cross-frame-access-location-get-expected.txt:
- http/tests/security/cross-frame-access-location-get-override-expected.txt:
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-port-expected.txt:
- http/tests/security/cross-frame-access-protocol-expected.txt:
- http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
- http/tests/security/location-cross-origin-expected.txt:
- http/tests/security/location-cross-origin.html:
- http/tests/security/resources/cross-frame-access.js:
(canGet):
(canGetDescriptor):
(canCall):
(toString):
- http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
- http/tests/security/xss-DENIED-defineProperty-expected.txt:
- http/tests/security/xss-DENIED-defineProperty.html:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location.html:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
- http/tests/security/xssAuditor/resources/utilities.js:
(checkIfFrameLocationMatchesSrcAndCallDone):
- 10:36 AM Changeset in webkit [205025] by
-
- 3 edits in trunk/Source/WebCore
[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161241
Reviewed by Brent Fulgham.
MSVC warns about potential use of uninitialized variables.
- accessibility/AXObjectCache.cpp:
- css/parser/CSSParserValues.cpp:
- 10:13 AM Changeset in webkit [205024] by
-
- 13 edits4 adds in trunk
[MediaStream] Add support for OverConstrainedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=161199
<rdar://problem/28011819>
Reviewed by Jer Noble.
Source/WebCore:
Test: fast/events/constructors/overconstrained-error-event-constructor.html
- CMakeLists.txt:
- DerivedSources.make:
- Modules/mediastream/OverconstrainedErrorEvent.h: Added.
(WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent):
(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::createForBindings):
(WebCore::OverconstrainedErrorEvent::error):
(WebCore::OverconstrainedErrorEvent::eventInterface):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):
- Modules/mediastream/OverconstrainedErrorEvent.idl: Added.
- WebCore.xcodeproj/project.pbxproj: Add new files.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add OverconstrainedErrorEvent converter.
- bindings/js/JSDictionary.h:
- dom/EventNames.in: Add OverconstrainedErrorEvent.
LayoutTests:
- fast/events/constructors/overconstrained-error-event-constructor-expected.txt: Added.
- fast/events/constructors/overconstrained-error-event-constructor.html: Added.
- js/dom/global-constructors-attributes-expected.txt: Updated.
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- 10:05 AM Changeset in webkit [205023] by
-
- 10 edits in trunk
toString called on proxies returns incorrect tag
https://bugs.webkit.org/show_bug.cgi?id=161111
Reviewed by Benjamin Poulain.
This patch adds a new Method table function toStringName. This function
is used by Object.prototype.toString to create the string tag that it
inserts. Right now it only changes the stringification of proxy objects.
In future patches I plan to make it work for other classes of objects as
well.
- runtime/ClassInfo.h:
- runtime/JSCell.cpp:
(JSC::JSCell::toStringName):
- runtime/JSCell.h:
- runtime/JSObject.cpp:
(JSC::JSObject::toStringName):
- runtime/JSObject.h:
- runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::toStringName):
- runtime/ProxyObject.h:
- 10:02 AM Changeset in webkit [205022] by
-
- 4 edits2 deletes in trunk/Source/bmalloc
bmalloc: speed up the lock slow path
https://bugs.webkit.org/show_bug.cgi?id=161058
Unreviewed rollout - this caused regressions <rdar://problem/28026089>.
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/ScopeExit.h: Removed.
- bmalloc/StaticMutex.cpp:
(bmalloc::StaticMutex::lockSlowCase):
- bmalloc/StaticMutex.h:
(bmalloc::StaticMutex::init):
- bmalloc/ThreadSwitch.h: Removed.
- 9:54 AM Changeset in webkit [205021] by
-
- 19 edits in trunk
Fix the ENABLE(WEBASSEMBLY) build on Linux
https://bugs.webkit.org/show_bug.cgi?id=161197
Reviewed by Mark Lam.
Source/JavaScriptCore:
- CMakeLists.txt:
- b3/B3Common.cpp:
(JSC::B3::shouldDumpIR):
- shell/CMakeLists.txt:
- wasm/JSWASMModule.h:
- wasm/WASMB3IRGenerator.cpp:
(JSC::WASM::toB3Op):
- wasm/WASMB3IRGenerator.h:
- wasm/WASMFormat.h:
- wasm/WASMFunctionParser.h:
- wasm/WASMModuleParser.cpp:
(JSC::WASM::WASMModuleParser::parseFunctionTypes):
- wasm/WASMModuleParser.h:
- wasm/WASMParser.h:
- wasm/WASMPlan.cpp:
- wasm/WASMPlan.h:
- wasm/WASMSections.cpp:
Source/WTF:
- wtf/Platform.h:
Tools:
- Scripts/build-jsc:
- 9:50 AM Changeset in webkit [205020] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=161235
Reviewed by Brent Fulgham.
YarrPattern::errorMessage has inconsistent dll linkage.
- yarr/YarrPattern.h:
- 9:50 AM Changeset in webkit [205019] by
-
- 1 copy in tags/Safari-602.1.50.0.7
New tag.
- 9:41 AM Changeset in webkit [205018] by
-
- 7 edits in trunk
The annotation-xml element does not need to be behave as an mrow
https://bugs.webkit.org/show_bug.cgi?id=161230
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-26
Reviewed by Manuel Rego Casasnovas.
Source/WebCore:
In r204779, MathMLAnnotationElement was made a MathMLRowElement just because the
annotation-xml element is generating a RenderMathMLRow. This later point is actually not
needed since annotation-xml is just a wrapper for foreign elements and so does not need to
handle special MathML features like operator spacing or stretching. We can thus move back
MathMLAnnotationElement to a generic MathMLPresentationElement and instead make the
annotation-xml element generate a generic RenderMathMLBlock renderer.
No new tests, semantics annotations already covered by existing tests.
- mathml/MathMLAnnotationElement.cpp: Replace RenderMathMLRow.h with RenderMathMLBlock.h
(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): Inherit from
MathMLPresentationElement instead of MathMLRowElement.
(WebCore::MathMLAnnotationElement::createElementRenderer): Make annotation-xml create a
RenderMathMLBlock instead of a RenderMathMLRow.
(WebCore::MathMLAnnotationElement::attributeChanged): Inherit from MathMLPresentationElement
instead of MathMLRowElement.
- mathml/MathMLAnnotationElement.h: Ditto.
LayoutTests:
- platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the
test expectation, which that was used for annotation-xml.
- platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto.
- platform/mac/accessibility/math-foreign-content-expected.txt: Ditto.
- 9:36 AM Changeset in webkit [205017] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
https://bugs.webkit.org/show_bug.cgi?id=161149
Reviewed by Carlos Garcia Campos.
Add a new function for waiting for the accesibility bus. It sets
the test environment variables before starting the GLib mainloop.
And restores the previous environment after it has finished.
It also adds a timeout (5 seconds) to abort in case it has not
been able to detect the accesibility bus before the timeout expires.
- Scripts/run-gtk-tests:
(TestRunner):
(TestRunner._wait_for_accessibility_bus):
(TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
(TestRunner._start_accessibility_daemons):
(TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
- 9:35 AM Changeset in webkit [205016] by
-
- 2 edits in trunk/Tools
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=161236
Reviewed by Brent Fulgham.
The & operator in the Test struct has no body.
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 9:33 AM Changeset in webkit [205015] by
-
- 2 edits in trunk/Source/WebCore
Typo fix after r56209
https://bugs.webkit.org/show_bug.cgi?id=161246
Reviewed by Gyuyoung Kim.
- page/FrameView.cpp:
(WebCore::FrameView::adjustMediaTypeForPrinting):
- 9:32 AM Changeset in webkit [205014] by
-
- 8 edits in trunk/Tools
[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
https://bugs.webkit.org/show_bug.cgi?id=160736
Reviewed by Carlos Garcia Campos.
This plugs run-gtk-tests into the webkitpy testing infrastructure.
As a benefit of this, run-gtk-tests now can be executed over any of
the existing supported gtk test display servers (xvfb, weston-over-xvfb,
or native xorg). A new command line switch --wayland is added for
run-gtk-tests.
- Scripts/run-gtk-tests:
(TestRunner.init): Remove the --display command line switch, its not longer useful.
Add a --wayland command line switch.
(TestRunner._start_accessibility_daemons):
(TestRunner):
(TestRunner.init):
(TestRunner._run_xvfb): Deleted.
(TestRunner._create_driver):
(TestRunner._setup_testing_environment): Delete the environment variable definitions that
are now done by driver._setup_environ_for_test().
(TestRunner._tear_down_testing_environment):
- Scripts/webkitpy/port/driver.py:
(Driver.init): Define self._server_name in the constructor of the base class.
It is used by several functions, so it makes sense to store once the value here.
(Driver._setup_environ_for_test): Factorize setting the environment for a given test.
(Driver._start): Get the environment from self._setup_environ_for_test()
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest):
(DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
- Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
(GtkPort.init):
(GtkPort._driver_class):
- Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
(WestonDriver._setup_environ_for_test):
(WestonDriver._start):
- Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
(XorgDriver._setup_environ_for_test):
(XorgDriver._start):
- Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
(XvfbDriver._setup_environ_for_test):
(XvfbDriver._start):
- 9:04 AM Changeset in webkit [205013] by
-
- 2 edits in trunk/LayoutTests
Reinstate flakiness expectations for viewport tests, as they are still flaky.
https://bugs.webkit.org/show_bug.cgi?id=153110
- platform/ios-simulator-wk2/TestExpectations:
- 7:04 AM Changeset in webkit [205012] by
-
- 5 edits in trunk
[EFL][GTK] REGRESSION(204877): Fix the clean build
https://bugs.webkit.org/show_bug.cgi?id=161240
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- Scripts/generate-forwarding-headers.pl: Added back multiple include-path support. (removed by r183389)
Tools:
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/PlatformGTK.cmake:
- 6:29 AM Changeset in webkit [205011] by
-
- 15 edits in trunk/Source/WebCore
[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161077
Reviewed by Brent Fulgham.
- css/CSSGrammar.y.includes:
- css/RuleFeature.cpp:
(WebCore::makeAttributeSelectorKey):
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::textToFragment):
- html/MediaElementSession.h:
- platform/URL.cpp:
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPHeader):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::clear):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::reset):
- rendering/RenderText.cpp:
(WebCore::RenderText::secureText):
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::mathVariant):
- style/InlineTextBoxStyle.cpp:
(WebCore::visualOverflowForDecorations):
- xml/XPathGrammar.y:
- 3:54 AM Changeset in webkit [205010] by
-
- 2 edits in trunk/Tools
EWS should indicate which bot processed the patch
https://bugs.webkit.org/show_bug.cgi?id=161222
Reviewed by Daniel Bates.
- QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
Also added "Started processing patch" message to progress_statuses.
I might consider displaying bot id in other statuses as well later on.
- 1:46 AM Changeset in webkit [205009] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r204996.
Patch by Gyuyoung Kim <gyuyoung.kim@navercorp.com> on 2016-08-26
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):
- 1:04 AM Changeset in webkit [205008] by
-
- 27 edits in trunk
Make custom constructors consistent with generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=159550
Reviewed by Youenn Fablet.
Add assertion to check DOMConstructorObject* passed in ExecState is not null.
Rename throwConstructorDocumentUnavailableError to throwConstructorScriptExecutionContextUnavailableError since
ScriptExecutionContext is not necessarily a Document.
Modify error message in case of argument error to be consistent with generated binding code: replace calls to
throwVMError with calls to throwConstructorScriptExecutionContextUnavailableError and throwArgumentTypeError.
No new test required. Modify tests and tests expectations to align with new error messages.
Source/WebCore:
- bindings/js/JSAudioContextCustom.cpp:
(WebCore::constructJSAudioContext):
- bindings/js/JSBlobCustom.cpp:
(WebCore::constructJSBlob):
- bindings/js/JSDOMBinding.cpp:
(WebCore::throwConstructorScriptExecutionContextUnavailableError):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMConstructor.h:
(WebCore::JSBuiltinConstructor<JSClass>::callConstructor):
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::constructJSDOMFormData):
- bindings/js/JSDataCueCustom.cpp:
(WebCore::constructJSDataCue):
- bindings/js/JSFileCustom.cpp:
(WebCore::constructJSFile):
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement):
- bindings/js/JSMediaSessionCustom.cpp:
(WebCore::constructJSMediaSession):
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::constructJSMutationObserver):
- bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::constructJSReadableStreamDefaultReader):
- bindings/js/JSWorkerCustom.cpp:
(WebCore::constructJSWorker):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation):
(NativeToJSValue):
(GenerateHashTableValueArray):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::construct):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodeConstructor::construct):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::construct):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
LayoutTests:
- fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
- fast/files/file-constructor-expected.txt:
- fast/files/file-constructor.html:
- 12:36 AM Changeset in webkit [205007] by
-
- 2 edits in trunk/Tools
[EFL] Change homepage url to www.ewebkit.org on MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=161184
Reviewed by Carlos Garcia Campos.
- MiniBrowser/efl/main.c: Set www.ewebkit.org.
- 12:34 AM Changeset in webkit [205006] by
-
- 5 edits in tags/Safari-601.7.7.1/Source
Versioning.
- 12:32 AM Changeset in webkit [205005] by
-
- 1 copy in tags/Safari-601.7.7.1
New tag.
Aug 25, 2016:
- 11:55 PM Changeset in webkit [205004] by
-
- 5 edits in trunk/Source
Unreviewed. Fix GTK+ build after r204986 and r204996.
Source/WebCore:
- page/DOMWindow.idl:
Source/WebKit2:
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::drawPagesForPrinting):
- 10:33 PM Changeset in webkit [205003] by
-
- 4 edits in trunk/Tools
ews queues should update status server when they start processing patch
https://bugs.webkit.org/show_bug.cgi?id=161223
Reviewed by Daniel Bates.
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(StyleQueueTest.test_style_queue_with_style_exception): Same.
(test_style_queue_with_watch_list_exception): Same.
(test_non_valid_patch): Same.
- 7:16 PM Changeset in webkit [205002] by
-
- 2 edits15 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 imported/w3c tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt: Added.
- platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc-expected.txt: Added.
- platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded-expected.txt: Added.
- platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001-expected.txt: Added.
- platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Added.
- 6:53 PM Changeset in webkit [205001] by
-
- 2 edits407 adds in trunk/LayoutTests
[iOS Simulator] Rebaseline many tests under LayoutTests/svg/ for ios-simulator and enable them for testing
https://bugs.webkit.org/show_bug.cgi?id=161166
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-25
Reviewed by Simon Fraser.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/svg/W3C-I18N: Added.
- platform/ios-simulator/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
- platform/ios-simulator/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-05-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
- platform/ios-simulator/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
- platform/ios-simulator/svg/batik: Added.
- platform/ios-simulator/svg/batik/text: Added.
- platform/ios-simulator/svg/batik/text/longTextOnPath-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/smallFonts-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textAnchor-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textAnchor2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textAnchor3-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textDecoration-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textDecoration2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textEffect-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textEffect2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textEffect3-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textFeatures-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textLayout-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textLayout2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textLength-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textOnPath-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textOnPath2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textOnPath3-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textOnPathSpaces-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textPCDATA-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textPosition-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textPosition2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textProperties-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textProperties2-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/textStyles-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/verticalText-expected.txt: Added.
- platform/ios-simulator/svg/batik/text/verticalTextOnPath-expected.txt: Added.
- platform/ios-simulator/svg/text/selection-background-color-expected.txt: Added.
- platform/ios-simulator/svg/text/small-fonts-2-expected.txt: Added.
- platform/ios-simulator/svg/text/small-fonts-3-expected.txt: Added.
- platform/ios-simulator/svg/text/small-fonts-expected.txt: Added.
- platform/ios-simulator/svg/text/text-align-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-align-02-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-align-03-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-align-04-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-align-05-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-align-06-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-altglyph-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-deco-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-fill-opacity-expected.txt: Added.
- platform/ios-simulator/svg/text/text-fonts-01-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-fonts-02-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-gradient-positioning-expected.txt: Added.
- platform/ios-simulator/svg/text/text-hkern-expected.txt: Added.
- platform/ios-simulator/svg/text/text-intro-05-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-midpoint-split-bug-expected.txt: Added.
- platform/ios-simulator/svg/text/text-path-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-path-middle-align-expected.txt: Added.
- platform/ios-simulator/svg/text/text-spacing-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-03-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-04-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-05-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-06-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-07-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-text-08-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-tref-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-tselect-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-tselect-02-f-expected.txt: Added.
- platform/ios-simulator/svg/text/text-tspan-01-b-expected.txt: Added.
- platform/ios-simulator/svg/text/text-viewbox-rescale-expected.txt: Added.
- platform/ios-simulator/svg/text/text-vkern-expected.txt: Added.
- platform/ios-simulator/svg/text/text-ws-01-t-expected.txt: Added.
- platform/ios-simulator/svg/text/text-ws-02-t-expected.txt: Added.
- platform/ios-simulator/svg/text/tspan-dynamic-positioning-expected.txt: Added.
- 5:57 PM Changeset in webkit [205000] by
-
- 2 edits in trunk/LayoutTests
js/regress/polymorphic-put-by-id.html does not exist.
- platform/ios-simulator-wk2/TestExpectations:
- 5:49 PM Changeset in webkit [204999] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 imported/mozilla tests
- platform/ios-simulator-wk1/TestExpectations:
- 5:28 PM Changeset in webkit [204998] by
-
- 5 edits1 add in trunk
CMake build fix.
Source/JavaScriptCore:
- ForwardingHeaders/JavaScriptCore/JSObjectRefPrivate.h: Added.
This is needed for the internal Windows build.
Source/WebKit:
- PlatformMac.cmake:
Availability was spelled wrong, resulting in a missing header.
Tools:
- DumpRenderTree/PlatformMac.cmake:
- 5:14 PM Changeset in webkit [204997] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 imported/blink tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width-expected.txt: Added.
- 4:09 PM Changeset in webkit [204996] by
-
- 25 edits in trunk/Source/WebKit2
Replace all IPC message send flags with OptionSet
https://bugs.webkit.org/show_bug.cgi?id=161211
Reviewed by Tim Horton.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- NetworkProcess/NetworkResourceLoader.h:
- Platform/IPC/Connection.cpp:
(IPC::WaitForMessageState::WaitForMessageState):
(IPC::Connection::sendMessage):
(IPC::Connection::sendSyncReply):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingMessage):
- Platform/IPC/Connection.h:
(IPC::Connection::send):
(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):
- Platform/IPC/MessageSender.cpp:
(IPC::MessageSender::sendMessage):
- Platform/IPC/MessageSender.h:
(IPC::MessageSender::send):
(IPC::MessageSender::sendSync):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::open):
(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::setComplexTextInputState):
- UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::getPluginProcessConnection):
- UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):
- UIProcess/WebPageProxy.cpp:
(WebKit::printingSendOptions):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::sendMessage):
(WebKit::WebPageProxy::beginPrinting):
(WebKit::WebPageProxy::endPrinting):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawPagesForPrinting):
(WebKit::WebPageProxy::setMinimumLayoutSize): Deleted.
(WebKit::WebPageProxy::setAutoSizingShouldExpandToViewHeight): Deleted.
(WebKit::WebPageProxy::handleAlternativeTextUIResult): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateViewState):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendPostLayoutEditorStateIfNeeded):
(WebKit::WebPage::postSynchronousMessageForTesting):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
- 4:02 PM Changeset in webkit [204995] by
-
- 11 edits in trunk
[JSC] Clean up the abstract interpreter for cos/sin/sqrt/fround/log
https://bugs.webkit.org/show_bug.cgi?id=161181
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-25
Reviewed by Geoffrey Garen.
JSTests:
Extend the tests to constants.
Add no-argument cases where needed.
- stress/arith-cos-on-various-types.js:
- stress/arith-fround-on-various-types.js:
- stress/arith-log-on-various-types.js:
- stress/arith-sin-on-various-types.js:
- stress/arith-sqrt-on-various-types.js:
Source/JavaScriptCore:
All the nodes are doing the exact same thing with a single
difference: how to process constants. I made that into a separate
function called from each node.
I also generalized the constant-to-number code of DoubleRep
to make it available for all those nodes.
- dfg/DFGAbstractInterpreter.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeDoubleUnaryOpEffects):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::toNumberFromPrimitive):
- runtime/JSCJSValue.h:
- 3:55 PM Changeset in webkit [204994] by
-
- 40 edits2 copies12 adds2 deletes in trunk
[DFG][FTL] Implement ES6 Generators in DFG / FTL
https://bugs.webkit.org/show_bug.cgi?id=152723
Reviewed by Filip Pizlo.
JSTests:
- stress/generator-fib-ftl-and-array.js: Added.
(fib):
- stress/generator-fib-ftl-and-object.js: Added.
(fib):
- stress/generator-fib-ftl-and-string.js: Added.
(fib):
- stress/generator-fib-ftl.js: Added.
(fib):
- stress/generator-frame-empty.js: Added.
(shouldThrow):
(shouldThrow.fib):
- stress/generator-reduced-save-point-put-to-scope.js: Added.
(shouldBe):
(gen):
- stress/generator-transfer-register-beyond-mutiple-yields.js: Added.
(shouldBe):
(gen):
Source/JavaScriptCore:
This patch introduces DFG and FTL support for ES6 generators.
ES6 generator is compiled by the BytecodeGenerator. But at the last phase, BytecodeGenerator performs "generatorification" onto the unlinked code.
In BytecodeGenerator phase, we just emit op_yield for each yield point. And we don't emit any generator related switch, save, and resume sequences
here. Those are emitted by the generatorification phase.
So the graph is super simple! Before the generatorification, the graph looks like this.
op_enter -> ...... -> op_yield -> ..... -> op_yield -> ...
Roughly speaking, in the generatorification phase, we turn out which variables should be saved and resumed at each op_yield.
This is done by liveness analysis. After that, we convert op_yield to the sequence of "op_put_to_scope", "op_ret", and "op_get_from_scope".
op_put_to_scope and op_get_from_scope sequences are corresponding to the save and resume sequences. We set up the scope for the generator frame and
perform op_put_to_scope and op_get_from_scope onto it. The live registers are saved and resumed over the generator's next() calls by using this
special generator frame scope. And we also set up the global switch for the generator.
In the generatorification phase,
- We construct the BytecodeGraph from the unlinked instructions. This constructs the basic blocks, and it is used in the subsequent analysis.
- We perform the analysis onto the unlinked code. We extract the live variables at each op_yield.
- We insert the get_from_scope and put_to_scope at each op_yield. Which registers should be saved and resumed is offered by (2). Then, clip the op_yield themselves. And we also insert the switch_imm. The jump targets of this switch are just after this op_switch_imm and each op_yield point.
One interesting point is the try-range. We split the try-range at the op_yield point in BytecodeGenerator phase.
This drops the hacky thing that is introduced in [1].
If the try-range covers the resume sequences, the exception handler's use-registers are incorrectly transferred to the entry block.
For example,
handler uses r2
try-range
label:(entry block can jump here)
r1 = get_from_scope # resume sequence starts | use r2 is transferred to the entry block!
r2 = get_from_scope |
starts usual sequences |
... |
Handler's r2 use should be considered at the
r1 = get_from_scopepoint.
Previously, we handle this edge case by treating op_resume specially in the liveness analysis[1].
To drop this workaround, we split the try-range not to cover this resume sequence.
handler uses r2
try-range
label:(entry block can jump here)
r1 = get_from_scope # resume sequence starts
r2 = get_from_scope
starts usual sequences try-range should start from here.
... |
OK. Let's show the detailed example.
- First, there is the normal bytecode sequence. Here, | represents the offsets, and [] represents the bytecodes.
bytecodes | [ ] | [ ] | [ ] | [ ] | [ ] | [ ] |
try-range <----------------------------------->
- When we emit the op_yield in the bytecode generator, we carefully split the try-range.
bytecodes | [ ] | [ ] | [op_yield] | [ ] | [ ] | [ ] |
try-range <-----------> <----------------->
- And in the generatorification phase, we insert the switch's jump target and save & resume sequences. And we also drop op_yield.
Insert save seq Insert resume seq
before op_yield. after op_yield's point.
v v
bytecodes | [ ] | [ ] | [op_yield] | [ ] | [ ] | [ ] |
try-range <-----------> <----------------->
|
Jump to here. Drop this op_yield.
- The final layout is the following.
bytecodes | [ ] | [ ][save seq][op_ret] | [resume seq] | [ ] | [ ] | [ ] |
try-range <-----------------------------> <---------------->
Jump to here.
The rewriting done by the BytecodeRewriter is executed in a batch manner. Since these modification changes the basic blocks and size of unlinked instructions,
BytecodeRewriter also performs the offset adjustment for UnlinkedCodeBlock. So, this rewriting is performed onto the BytecodeGraph rather than BytecodeBasicBlock.
The reason why we take this design is simple: we don't want to newly create the basic blocks and opcodes for this early phase like DFG. Instead, we perform the
modification and adjustment to the unlinked instructions and UnlinkedCodeBlock in a in-place manner.
Bytecode rewriting functionality is offered by BytecodeRewriter. BytecodeRewriter allows us to insert any bytecodes to any places
in a in-place manner. BytecodeRewriter handles the original bytecode offsets as labels. And you can insert bytecodes before and after
these labels. You can also insert any jumps to any places. When you insert jumps, you need to specify jump target with this labels.
These labels (original bytecode offsets) are automatically converted to the appropriate offsets by BytecodeRewriter.
After that phase, the data flow of the generator-saved-and-resumed-registers are explicitly represented by the get_from_scope and put_to_scope.
And the switch is inserted to represent the actual control flow for the generator. And op_yield is removed. Since we use the existing bytecodes (op_switch_imm, op_put_to_scope
op_ret, and op_get_from_scope), DFG and FTL changes are not necessary. This patch also drops data structures and implementations for the old generator,
op_resume, op_save implementations and GeneratorFrame.
Note that this patch does not leverage the recent multi entrypoints support in B3. After this patch is introduced, we will submit a new patch that leverages the multi
entrypoints for generator's resume and sees the performance gain.
Microbenchmarks related to generators show up to 2.9x improvements.
Baseline Patched
generator-fib 102.0116+-3.2880 34.9670+-0.2221 definitely 2.9174x faster
generator-sunspider-access-nsieve 5.8596+-0.0371 4.9051+-0.0720 definitely 1.1946x faster
generator-with-several-types 332.1478+-4.2425 124.6642+-2.4826 definitely 2.6643x faster
<geometric> 58.2998+-0.7758 27.7425+-0.2577 definitely 2.1015x faster
In ES6SampleBench's Basic, we can observe 41% improvement (Macbook Pro).
Baseline:
Geometric Mean Result: 133.55 ms +- 4.49 ms
Benchmark First Iteration Worst 2% Steady State
Air 54.03 ms +- 7.51 ms 29.06 ms +- 3.13 ms 2276.59 ms +- 61.17 ms
Basic 30.18 ms +- 1.86 ms 18.85 ms +- 0.45 ms 2851.16 ms +- 41.87 ms
Patched:
Geometric Mean Result: 121.78 ms +- 3.96 ms
Benchmark First Iteration Worst 2% Steady State
Air 52.09 ms +- 6.89 ms 29.59 ms +- 3.16 ms 2239.90 ms +- 54.60 ms
Basic 29.28 ms +- 1.46 ms 16.26 ms +- 0.66 ms 2025.15 ms +- 38.56 ms
[1]: https://bugs.webkit.org/show_bug.cgi?id=159281
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/GeneratorPrototype.js:
(globalPrivate.generatorResume):
- bytecode/BytecodeBasicBlock.cpp:
(JSC::BytecodeBasicBlock::shrinkToFit):
(JSC::BytecodeBasicBlock::computeImpl):
(JSC::BytecodeBasicBlock::compute):
(JSC::isBranch): Deleted.
(JSC::isUnconditionalBranch): Deleted.
(JSC::isTerminal): Deleted.
(JSC::isThrow): Deleted.
(JSC::linkBlocks): Deleted.
(JSC::computeBytecodeBasicBlocks): Deleted.
- bytecode/BytecodeBasicBlock.h:
(JSC::BytecodeBasicBlock::isEntryBlock):
(JSC::BytecodeBasicBlock::isExitBlock):
(JSC::BytecodeBasicBlock::leaderOffset):
(JSC::BytecodeBasicBlock::totalLength):
(JSC::BytecodeBasicBlock::offsets):
(JSC::BytecodeBasicBlock::successors):
(JSC::BytecodeBasicBlock::index):
(JSC::BytecodeBasicBlock::addSuccessor):
(JSC::BytecodeBasicBlock::BytecodeBasicBlock):
(JSC::BytecodeBasicBlock::addLength):
(JSC::BytecodeBasicBlock::leaderBytecodeOffset): Deleted.
(JSC::BytecodeBasicBlock::totalBytecodeLength): Deleted.
(JSC::BytecodeBasicBlock::bytecodeOffsets): Deleted.
(JSC::BytecodeBasicBlock::addBytecodeLength): Deleted.
- bytecode/BytecodeGeneratorification.cpp: Added.
(JSC::BytecodeGeneratorification::BytecodeGeneratorification):
(JSC::BytecodeGeneratorification::graph):
(JSC::BytecodeGeneratorification::yields):
(JSC::BytecodeGeneratorification::enterPoint):
(JSC::BytecodeGeneratorification::storageForGeneratorLocal):
(JSC::GeneratorLivenessAnalysis::GeneratorLivenessAnalysis):
(JSC::GeneratorLivenessAnalysis::computeDefsForBytecodeOffset):
(JSC::GeneratorLivenessAnalysis::computeUsesForBytecodeOffset):
(JSC::GeneratorLivenessAnalysis::run):
(JSC::BytecodeGeneratorification::run):
(JSC::performGeneratorification):
- bytecode/BytecodeGeneratorification.h: Copied from Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysisInlines.h.
- bytecode/BytecodeGraph.h: Added.
(JSC::BytecodeGraph::codeBlock):
(JSC::BytecodeGraph::instructions):
(JSC::BytecodeGraph::basicBlocksInReverseOrder):
(JSC::BytecodeGraph::blockContainsBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockForBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockWithLeaderOffset):
(JSC::BytecodeGraph::size):
(JSC::BytecodeGraph::at):
(JSC::BytecodeGraph::operator[]):
(JSC::BytecodeGraph::begin):
(JSC::BytecodeGraph::end):
(JSC::BytecodeGraph::first):
(JSC::BytecodeGraph::last):
(JSC::BytecodeGraph<Block>::BytecodeGraph):
- bytecode/BytecodeList.json:
- bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::BytecodeLivenessAnalysis::computeDefsForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeUsesForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeFullLiveness):
(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::dumpResults):
(JSC::BytecodeLivenessAnalysis::compute):
(JSC::isValidRegisterForLiveness): Deleted.
(JSC::getLeaderOffsetForBasicBlock): Deleted.
(JSC::findBasicBlockWithLeaderOffset): Deleted.
(JSC::blockContainsBytecodeOffset): Deleted.
(JSC::findBasicBlockForBytecodeOffset): Deleted.
(JSC::stepOverInstruction): Deleted.
(JSC::computeLocalLivenessForBytecodeOffset): Deleted.
(JSC::computeLocalLivenessForBlock): Deleted.
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint): Deleted.
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/BytecodeLivenessAnalysisInlines.h:
(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::stepOverInstruction):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBlock):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::runLivenessFixpoint):
- bytecode/BytecodeRewriter.cpp: Added.
(JSC::BytecodeRewriter::applyModification):
(JSC::BytecodeRewriter::execute):
(JSC::BytecodeRewriter::adjustJumpTargetsInFragment):
(JSC::BytecodeRewriter::insertImpl):
(JSC::BytecodeRewriter::adjustJumpTarget):
- bytecode/BytecodeRewriter.h: Added.
(JSC::BytecodeRewriter::InsertionPoint::InsertionPoint):
(JSC::BytecodeRewriter::InsertionPoint::operator<):
(JSC::BytecodeRewriter::InsertionPoint::operator==):
(JSC::BytecodeRewriter::Insertion::length):
(JSC::BytecodeRewriter::Fragment::Fragment):
(JSC::BytecodeRewriter::Fragment::appendInstruction):
(JSC::BytecodeRewriter::BytecodeRewriter):
(JSC::BytecodeRewriter::insertFragmentBefore):
(JSC::BytecodeRewriter::insertFragmentAfter):
(JSC::BytecodeRewriter::removeBytecode):
(JSC::BytecodeRewriter::graph):
(JSC::BytecodeRewriter::adjustAbsoluteOffset):
(JSC::BytecodeRewriter::adjustJumpTarget):
(JSC::BytecodeRewriter::calculateDifference):
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::livenessAnalysisSlow):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::isConstantRegisterIndex):
(JSC::CodeBlock::livenessAnalysis):
(JSC::CodeBlock::liveCalleeLocalsAtYield): Deleted.
- bytecode/HandlerInfo.h:
(JSC::HandlerInfoBase::handlerForIndex):
- bytecode/Opcode.h:
(JSC::isBranch):
(JSC::isUnconditionalBranch):
(JSC::isTerminal):
(JSC::isThrow):
- bytecode/PreciseJumpTargets.cpp:
(JSC::getJumpTargetsForBytecodeOffset):
(JSC::computePreciseJumpTargetsInternal):
(JSC::computePreciseJumpTargets):
(JSC::recomputePreciseJumpTargets):
(JSC::findJumpTargetsForBytecodeOffset):
- bytecode/PreciseJumpTargets.h:
- bytecode/PreciseJumpTargetsInlines.h: Added.
(JSC::extractStoredJumpTargetsForBytecodeOffset):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::handlerForBytecodeOffset):
(JSC::UnlinkedCodeBlock::handlerForIndex):
(JSC::UnlinkedCodeBlock::applyModification):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedStringJumpTable::offsetForValue):
(JSC::UnlinkedCodeBlock::numCalleeLocals):
- bytecode/VirtualRegister.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitSave): Deleted.
(JSC::BytecodeGenerator::emitResume): Deleted.
(JSC::BytecodeGenerator::emitGeneratorStateLabel): Deleted.
(JSC::BytecodeGenerator::beginGenerator): Deleted.
(JSC::BytecodeGenerator::endGenerator): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::generatorStateRegister):
(JSC::BytecodeGenerator::generatorValueRegister):
(JSC::BytecodeGenerator::generatorResumeModeRegister):
(JSC::BytecodeGenerator::generatorFrameRegister):
- bytecompiler/NodesCodegen.cpp:
(JSC::FunctionNode::emitBytecode):
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::findExceptionHandler):
(JSC::GetCatchHandlerFunctor::operator()):
(JSC::UnwindFunctor::operator()):
- interpreter/Interpreter.h:
- interpreter/InterpreterInlines.h: Copied from Source/JavaScriptCore/bytecode/PreciseJumpTargets.h.
(JSC::Interpreter::getOpcodeID):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_save): Deleted.
(JSC::JIT::emit_op_resume): Deleted.
- llint/LowLevelInterpreter.asm:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::createGeneratorParameters):
- parser/Parser.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL): Deleted.
- runtime/CommonSlowPaths.h:
- runtime/GeneratorFrame.cpp: Removed.
(JSC::GeneratorFrame::GeneratorFrame): Deleted.
(JSC::GeneratorFrame::finishCreation): Deleted.
(JSC::GeneratorFrame::createStructure): Deleted.
(JSC::GeneratorFrame::create): Deleted.
(JSC::GeneratorFrame::save): Deleted.
(JSC::GeneratorFrame::resume): Deleted.
(JSC::GeneratorFrame::visitChildren): Deleted.
- runtime/GeneratorFrame.h: Removed.
(JSC::GeneratorFrame::locals): Deleted.
(JSC::GeneratorFrame::localAt): Deleted.
(JSC::GeneratorFrame::offsetOfLocals): Deleted.
(JSC::GeneratorFrame::allocationSizeForLocals): Deleted.
- runtime/JSGeneratorFunction.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WTF:
- wtf/FastBitVector.h:
(WTF::FastBitVector::FastBitVector):
- 3:27 PM Changeset in webkit [204993] by
-
- 5 edits13 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 fast tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/fast/attachment/attachment-select-on-click-expected.txt: Added.
- platform/ios-simulator-wk1/fast/block/float/overhanging-tall-block-expected.txt: Added.
- platform/ios-simulator-wk1/fast/clip/014-expected.txt: Added.
- platform/ios-simulator-wk1/fast/encoding/utf-16-big-endian-expected.txt:
- platform/ios-simulator-wk1/fast/encoding/utf-16-little-endian-expected.txt:
- platform/ios-simulator-wk1/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
- platform/ios-simulator-wk1/fast/forms/form-element-geometry-expected.txt:
- platform/ios-simulator-wk1/fast/replaced/width100percent-textarea-expected.txt: Added.
- platform/ios-simulator-wk1/fast/shadow-dom/trusted-event-scoped-flags-expected.txt: Added.
- 3:11 PM Changeset in webkit [204992] by
-
- 16 edits2 adds in trunk
TryGetById should have a ValueProfile so that it can predict its output type
https://bugs.webkit.org/show_bug.cgi?id=160921
Patch by JF Bastien <jfbastien@apple.com> on 2016-08-25
Reviewed by Saam Barati.
JSTests:
- microbenchmarks/try-get-by-id-basic.js: Added.
(const.check):
(const.bench.f.const.fooPlusBar.createBuiltin):
- microbenchmarks/try-get-by-id-polymorphic.js: Added.
(const.check):
(fooPlusBar.createBuiltin):
(bench):
Source/JavaScriptCore:
Add a ValueProfile to TryGetById, and make sure DFG picks it up.
A microbenchmark for perfectly predicted computation shows a 20%
runtime reduction with no hit if the prediction goes polymorphic.
- bytecode/BytecodeList.json:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitTryGetById):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_try_get_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_try_get_by_id):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
Source/WTF:
Add WTF_CONCAT to StdLibExtras.h
- wtf/StdLibExtras.h:
- 3:11 PM Changeset in webkit [204991] by
-
- 2 edits2 adds in trunk/LayoutTests
WK1 Sierra: LayoutTests fast/html/marquee-scroll.html and fast/inline-block/003.html failing
rdar://problem/28017216
This test is sensitive to how WK1 does layouts as a result of updateScrollbars(),
giving different results in WK1 and WK1. Land Sierra results, and mark the test
as failing on earlier OS versions.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/fast/inline-block/003-expected.txt: Added.
- 3:02 PM Changeset in webkit [204990] by
-
- 2 edits in trunk/Tools
Fix URLParserTest with GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=161214
rdar://problem/28014390
Reviewed by Tim Horton.
The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
This just does the comparison of the CStrings instead to keep them in scope during the comparison.
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::eq):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::s): Deleted.
- 3:01 PM Changeset in webkit [204989] by
-
- 6 edits in trunk
Dragging against the end of the inline media scrubber causes the media scrubber to hide
https://bugs.webkit.org/show_bug.cgi?id=161207
Reviewed by Eric Carlson.
Source/WebCore:
Previously, we would re-enable behavior restrictions when firing an ended event. However, if the ended event is
caused by the user seeking to the end of the video, the media controls would be taken away from under the user.
To prevent this, we don't add the relevant behavior restrictions upon media ended if media was seeking before
firing the event.
Tweaked an existing WebKit API test to cover this change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::addBehaviorRestrictionsOnEndIfNecessary):
- html/HTMLMediaElement.h:
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canControlControlsManager):
Tools:
Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
controls in this case, we should actually continue showing them. This is because seeking due to user gestures
similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
- TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
(TestWebKitAPI::TEST):
- 2:59 PM Changeset in webkit [204988] by
-
- 9 edits in tags/Safari-603.1.3
Merge r204986. rdar://problem/28015060
- 2:57 PM Changeset in webkit [204987] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION: RELEASE_ASSERT in ResourceUsageThread::platformThreadBody when ASan is enabled
<https://webkit.org/b/161203>
<rdar://problem/28011251>
Reviewed by Joseph Pecoraro.
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::ResourceUsageThread::platformThreadBody): Remove overly optimistic assertions about
"GC owned" memory never being higher than total malloc memory usage. This accounting is not
really exact and pretending otherwise will just lead to crashes.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::externalMemoryCost): Hook up HTMLCanvasElement to the ImageBuffer
helper for reporting external memory cost. This makes accounting slightly more correct.
- 2:48 PM Changeset in webkit [204986] by
-
- 9 edits in trunk
Regression(r203623): Breaks App Store application
https://bugs.webkit.org/show_bug.cgi?id=161206
<rdar://problem/28015060>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add quirks for the App Store application so that we log an error message
when passing a Document node to Window.getComputedStyle() instead of
throwing an exception.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::getComputedStyle):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- platform/RuntimeApplicationChecks.h:
- platform/RuntimeApplicationChecks.mm:
(WebCore::MacApplication::isAppStore):
LayoutTests:
Rebaseline existing test as the exception message is slightly different.
- fast/dom/Window/getComputedStyle-missing-parameter-expected.txt:
- fast/dom/Window/getComputedStyle-missing-parameter.html:
- 1:53 PM Changeset in webkit [204985] by
-
- 19 edits1 delete in trunk/Source/WebKit2
Remove some more MessageRecorder gunk
https://bugs.webkit.org/show_bug.cgi?id=161209
Reviewed by Tim Horton.
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.h:
- Platform/IPC/Connection.h:
- Platform/IPC/ProcessType.h: Removed.
- PluginProcess/PluginProcess.h:
- PluginProcess/WebProcessConnection.h:
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebProcess.h:
- 12:20 PM Changeset in webkit [204984] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 fast/css tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/fast/css/layerZOrderCrash-expected.txt: Added.
- platform/ios-simulator-wk1/fast/css/viewport-units-dynamic-expected.txt: Added.
- platform/ios-simulator-wk1/fast/css/word-space-extra-expected.txt: Added.
- 12:18 PM Changeset in webkit [204983] by
-
- 12 edits2 adds in trunk
REGRESSION (r203378): [iOS] The PDF image is rendered stretched if a sub image of it is cached first
https://bugs.webkit.org/show_bug.cgi?id=160617
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-25
Reviewed by Tim Horton.
Source/WebCore:
When caching only a sub-image of the PDF ensure the source rectangle starts
at the top-left of the cached sub-image rectangle. When drawing the cached
sub-image to the destination context ensure the destination rectangle is the
sub-image rectangle so no stretching or shrinking happens.
Test: fast/images/cached-clipped-pdf.html
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setCachedPDFImageEnabled): Deleted.
- page/Settings.h:
(WebCore::Settings::isCachedPDFImageEnabled): Deleted.
- page/Settings.in:
Change the boolean setting CachedPDFImageEnabled to be enum property and
rename it PDFImageCachingPolicy. Allow the "PDFImageCachingBelowMemoryLimit"
option to be available on a;; platforms. The "PDFImageCachingClipBoundsOnly"
option is added for testing purpose. If forces recaching the PDF with each
draw and it sets the cached image rectangle to the clipping rectangle.
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::setPdfImageCachingPolicy): Take an enum instead of boolean.
(WebCore::cachedImageRect):
(WebCore::PDFDocumentImage::decodedSizeChanged): Enable PDFImageCachingBelowMemoryLimit
on all platforms.
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): Fix the source rectangle
when caching a sub-image of the PDF.
(WebCore::PDFDocumentImage::draw): Fix the destination rectangle when drawing
a sub-image to the destination context.
(WebCore::PDFDocumentImage::setCachedPDFImageEnabled): Deleted.
- platform/graphics/cg/PDFDocumentImage.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setPDFImageCachingPolicy):
(WebCore::InternalSettings::setCachedPDFImageEnabled): Deleted.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Change the internal setting CachedPDFImageEnabled to PDFImageCachingPolicy.
LayoutTests:
- fast/images/cached-clipped-pdf-expected.html: Added.
- fast/images/cached-clipped-pdf.html: Added.
- fast/images/displaced-non-cached-pdf.html:
- 12:02 PM Changeset in webkit [204982] by
-
- 3 edits in trunk/LayoutTests
Skipping imported/w3c/web-platform-tests/url/url-setters.html because it asserts.
https://bugs.webkit.org/show_bug.cgi?id=161191
Unreviewed test gardening.
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 11:45 AM Changeset in webkit [204981] by
-
- 3 edits in tags/Safari-603.1.3/Source/WebKit/mac
Merge r204974. rdar://problem/27959937
- 11:41 AM Changeset in webkit [204980] by
-
- 3 edits2 adds in trunk
Infinite recursion crash in WebCore::RenderBlockFlow::layoutBlock
https://bugs.webkit.org/show_bug.cgi?id=139474
<rdar://problem/27705190>
Reviewed by David Hyatt.
Source/WebCore:
We should just give up trying to avoid widow when the page is too small to break line.
Test: fast/multicol/assert-on-small-page-height-with-widow.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidowIfNeeded):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
- rendering/RenderBlockFlow.h:
LayoutTests:
- fast/multicol/assert-on-small-page-height-with-widow-expected.txt: Added.
- fast/multicol/assert-on-small-page-height-with-widow.html: Added.
- 11:39 AM Changeset in webkit [204979] by
-
- 2 edits in trunk/Source/JavaScriptCore
generate-js-builtins.py should generate platform independent files
https://bugs.webkit.org/show_bug.cgi?id=161196
Reviewed by Mark Lam.
- Scripts/generate-js-builtins.py: Files should be processed in fixed order.
- 11:36 AM Changeset in webkit [204978] by
-
- 5 edits in trunk/Source/WebCore
Add the ability to override the implementation name of IDL enums and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=161185
Reviewed by Anders Carlsson.
- bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
Build a dictionary of IDL name -> implementation name overrides
for enums and dictionaries up front based on ImplementedAs extended
attribute.
(HasEnumImplementationNameOverride):
(GetEnumImplementationNameOverride):
(HasDictionaryImplementationNameOverride):
(GetDictionaryImplementationNameOverride):
Expose predicate and getter for name overrides.
- bindings/scripts/CodeGeneratorJS.pm:
(GetEnumerationClassName):
(GetDictionaryClassName):
Use the override names as necessary.
- bindings/scripts/test/TestObj.idl:
Add tests for enums and dictionaries with ImplementedAs extended
attributes.
- 11:23 AM Changeset in webkit [204977] by
-
- 10 edits in trunk/Source
Don't store networkLoadTiming in the disk cache
https://bugs.webkit.org/show_bug.cgi?id=161161
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-25
Reviewed by Antti Koivisto.
Source/WebCore:
No functionality changed. So, no new tests.
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
Source/WebKit2:
- NetworkProcess/cache/NetworkCacheStorage.h: Updated version to 10.
- NetworkProcess/cache/NetworkCacheDecoder.h:
- NetworkProcess/cache/NetworkCacheEncoder.h:
- Platform/IPC/Decoder.h:
- Platform/IPC/Encoder.h:
Added isIPCDecoder/isIPCEncoder static members.
Source/WTF:
- wtf/Forward.h:
Remove Encode and Decode forward declarations.
- 11:22 AM Changeset in webkit [204976] by
-
- 21 edits17 adds in trunk
Update the Resource Timing implementation
https://bugs.webkit.org/show_bug.cgi?id=161068
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-25
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Added W3C Web Platform Tests for Resource Timing.
- web-platform-tests/resource-timing/OWNERS: Added.
- web-platform-tests/resource-timing/SyntheticResponse.py: Added.
(main):
- web-platform-tests/resource-timing/iframe-setdomain.sub.html: Added.
- web-platform-tests/resource-timing/resource-timing.html: Added.
- web-platform-tests/resource-timing/resource-timing.js: Added.
(testCases.test):
(test):
(runNextCase):
(assertInvariants):
(assertResourceEntryInvariants):
(canonicalize):
(createUniqueQueryArgument):
(getSyntheticUrl):
(initiateFetch):
(window.onload):
- web-platform-tests/resource-timing/resources/resource_timing_test0.css: Added.
(div#resource_link_css):
- web-platform-tests/resource-timing/resources/resource_timing_test0.html: Added.
- web-platform-tests/resource-timing/resources/resource_timing_test0.js: Added.
- web-platform-tests/resource-timing/resources/resource_timing_test0.png: Added.
- web-platform-tests/resource-timing/resources/resource_timing_test0.xml: Added.
- web-platform-tests/resource-timing/resources/webperftestharness.js: Added.
(wp_test):
(test_namespace):
(test_timing_order):
(test_timing_equals):
(sleep_milliseconds):
(test_true):
(test_equals):
(test_greater_than):
(test_greater_or_equals):
- web-platform-tests/resource-timing/test_resource_timing.html: Added.
- web-platform-tests/resource-timing/test_resource_timing.js: Added.
(setup):
(resolve):
(switch.):
(switch.case.string_appeared_here.xmlhttp.onload):
(switch.default.element.onload):
(onload):
(poll_for_stylesheet_load.inner):
(poll_for_stylesheet_load):
(resource_load):
Source/WebCore:
Tests: imported/w3c/web-platform-tests/resource-timing/resource-timing.html
imported/w3c/web-platform-tests/resource-timing/test_resource_timing.html
Update the Resource Timing implementation for better compatibility with the Resource Timing API spec.
Use LoadTiming for general timing information about a resources load timeline.
Mark timestamps for newly loaded resources as well as cached resources.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
StartTime and fetchStart should be equal initially.
- loader/LoadTiming.cpp:
(WebCore::LoadTiming::LoadTiming): Moved member initialization out. Removed constructor.
- loader/LoadTiming.h:
(WebCore::LoadTiming::markStartTimeAndFetchStart):
Mark startTime and fetchStart simultaneously.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init):
Mark the start time of resources.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::loadTiming):
Add LoadTiming info to handle a resources load timing.
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
- loader/ResourceTimingInformation.h:
Only pass in the URL from the ResourceRequest.
Pass LoadTiming instead of timestamps.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
Mark redirects.
(WebCore::SubresourceLoader::didFinishLoading):
Mark the responseEnd timestamp.
Add the ResourceEntry to the timeline before notifyDone is called.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadDone):
Mark timestamps for cached resources and use them instead of a cached LoadTiming.
- loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::resourceTimingInformation):
Add ResourceTimingInformation getter so SubresourceLoader.cpp can add entries before callbacks.
- page/Performance.cpp:
(WebCore::Performance::addResourceTiming):
- page/Performance.h:
Update signature: URLs and LoadTiming instead of timestamps.
- page/PerformanceResourceTiming.cpp:
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::redirectStart):
(WebCore::PerformanceResourceTiming::redirectEnd):
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):
- page/PerformanceResourceTiming.h:
Update signatures and properties to use LoadTiming.
Use LoadTiming’s redirectStart/End, fetchStart, responseStart/End.
Make sure dns and connection timestamps are in increasing order, even when cached.
- page/PerformanceResourceTiming.idl:
Add responseStart.
LayoutTests:
Skip resource outside of resource-folder.
Mark one test as flaky (see bug 161088).
- resources/testharnessreport.js:
(self.testRunner.add_completion_callback):
Updated completion callback to wait for any other completion callbacks
before finishing, so the Resource Timing tests can cleanup first.
Enabled the ResourceTiming runtime flag.
- 11:21 AM Changeset in webkit [204975] by
-
- 13 edits1 add in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 fast/multicol tests
- platform/ios-simulator-wk1/fast/multicol/overflow-unsplittable-expected.txt: Added.
- platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-bt-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-lr-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-rl-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-tb-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-bt-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-lr-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-rl-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-tb-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/vertical-rl/column-rules-expected.txt:
- platform/ios-simulator-wk1/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
- 11:12 AM Changeset in webkit [204974] by
-
- 3 edits in trunk/Source/WebKit/mac
Re-export DOMException NSStrings after r204717
https://bugs.webkit.org/show_bug.cgi?id=161200
<rdar://problem/27959937>
Patch by Anders Carlsson <andersca@apple.com> on 2016-08-25
Reviewed by Alex Christensen.
- DOM/ExceptionHandlers.mm:
(raiseDOMException):
- WebKit.exp:
- 10:50 AM Changeset in webkit [204973] by
-
- 4 edits in trunk/LayoutTests
TestExpectations cleanup
Remove references to non-existant JS tests.
- platform/ios-simulator/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 10:37 AM Changeset in webkit [204972] by
-
- 4 edits in trunk/Source/WebCore
Simplify createMouseEvent in DragController
https://bugs.webkit.org/show_bug.cgi?id=161168
Reviewed by Dan Bernstein.
- page/DragController.cpp:
(WebCore::createMouseEvent):
- platform/DragData.cpp:
(WebCore::DragData::modifierKeyState): Deleted.
- platform/DragData.h:
- 10:19 AM Changeset in webkit [204971] by
-
- 2 edits in trunk/Tools
Watch more things.
- Scripts/webkitpy/common/config/watchlist:
- 10:08 AM Changeset in webkit [204970] by
-
- 5 edits in trunk/Source/WebCore
DOMTokenList.value should be a stringifier attribute
https://bugs.webkit.org/show_bug.cgi?id=161195
Reviewed by Darin Adler.
DOMTokenList.value should be a stringifier attribute:
No new tests, this change is not observable from the Web.
- html/DOMTokenList.h:
(WebCore::DOMTokenList::toString): Deleted.
- html/DOMTokenList.idl:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::iconSizes): Deleted.
- html/HTMLLinkElement.h:
- 9:54 AM Changeset in webkit [204969] by
-
- 2 edits in trunk/Tools
Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
(https://bugs.webkit.org/show_bug.cgi?id=148437)
Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
and is not installed on the GTK Linux bots.
- Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
(writeFileWithContent): Added.
- 9:42 AM Changeset in webkit [204968] by
-
- 2 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html for mac-wk1 after r204935
Unreviewed test gardening.
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- 9:18 AM Changeset in webkit [204967] by
-
- 2 edits in trunk/LayoutTests
Skip svg/animations/animate-text-nested-transforms.html on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 9:18 AM Changeset in webkit [204966] by
-
- 2 edits in trunk/Tools
[Win] run-api-tests is failing.
https://bugs.webkit.org/show_bug.cgi?id=161140
Reviewed by Brent Fulgham.
Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
- TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
(TestWebKitAPI::TEST):
- 9:00 AM Changeset in webkit [204965] by
-
- 3 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/url/url-setters.html as failing on mac and ios-simulator wk1.
https://bugs.webkit.org/show_bug.cgi?id=161191
Unreviewed test gardening.
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 8:58 AM Changeset in webkit [204964] by
-
- 2 edits in trunk/Source/WebCore
[Mac][cmake] Unreviewed speculative buildfix after r204852, just for fun.
- PlatformMac.cmake:
- 8:46 AM Changeset in webkit [204963] by
-
- 3 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html for mac after r204935
Unreviewed test gardening.
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 8:42 AM Changeset in webkit [204962] by
-
- 2 edits in trunk/LayoutTests
Marking gamepad/gamepad-timestamp.html as flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=161148
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 8:39 AM Changeset in webkit [204961] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][Threaded Compositor] Several flaky tests due to differences in scrollbars
https://bugs.webkit.org/show_bug.cgi?id=160450
Reviewed by Michael Catanzaro.
The issue is that ThreadedCompositor::didChangeVisibleRect() dispatches the setVisibleContentsRect() call that
ends up in CompositingCoordinator. Since we're compositing the scrollbars as well, this visible contents rect
needs to encompass the complete width of the view, but that's not happening.
In case of non-overlay scrollbars, the scrollbars are clipped from this rect, but that doesn't prevent the
scrollbar overlay layers to be flushed and rendered. What does happen is that during tile creation in the
backing store the tiles that would normally intersect the visible rect of the view (if it were spanning over the
whole actual visible area) are sorted by distance to the visible rect.
The top of the two tiles used for the scrollbar is closer to the visible rect, so that gets created and filled
in first. The second tile is stored as pending for creation, and does get rendered at the point of the next
layer flush.
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::setVisibleContentsRect): Update the visible rect taking into account
the non-overlay scrollbars before passing it to the compositor.
- 2:53 AM Changeset in webkit [204960] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
Update test expectations on Windows for failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.
- platform/win/TestExpectations:
- 12:45 AM Changeset in webkit [204959] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
Update test expectations on Windows for failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.
- platform/win/TestExpectations:
- 12:04 AM Changeset in webkit [204958] by
-
- 9 edits1 add in trunk
NewRegexp should not prevent inlining
https://bugs.webkit.org/show_bug.cgi?id=154808
Patch by Caio Lima <Caio Lima> on 2016-08-25
Reviewed by Geoffrey Garen.
JSTests:
Added test where functions with NewRegExp can be inlined right now.
- stress/new-regex-inline.js: Added.
(assert):
(testRegexpInline):
(toInlineGlobal):
(withRegexp):
(inlineRegexpNotGlobal):
(toInlineRecursive):
(regexpContainsRecursive):
Source/JavaScriptCore:
In this patch we are changing the current mechanism used to represent
RegExp in NewRegexp nodes. We are changing the use of a index
pointing to RegExp in
CodeBlock->m_unlinkedCodeBlock->m_rareData->m_regexps as the operand of
NewRegexp node to RegExp address as the operand. To make sure that RegExp* is
pointing to a valid object, we are using m_graph.freezeStrong
mechanism.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::hasRegexpIndex): Deleted.
(JSC::DFG::Node::regexpIndex): Deleted.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):
Aug 24, 2016:
- 11:51 PM Changeset in webkit [204957] by
-
- 2 edits in trunk/Tools
[Win] run-api-tests is failing.
https://bugs.webkit.org/show_bug.cgi?id=161140
Reviewed by Brent Fulgham.
The number of times the move constructor is called is different on Windows in this test. This seems
to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
- TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
(TestWebKitAPI::TEST):
- 11:31 PM Changeset in webkit [204956] by
-
- 4 edits in trunk/Source/WebCore
Do not store layout parameters on the RenderMathMLRoot class
https://bugs.webkit.org/show_bug.cgi?id=161132
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-24
Reviewed by Darin Adler.
Storing layout parameters on the RenderMathMLRoot class is not really needed since reading
the parameters from the MATH table is not too expensive and updateStyle() is currently always
called in layoutBlock() and computePreferredLogicalWidths(). Most of these parameters are
actually only used in layoutBlock(). We separate horizontal and vertical parameters since
the latter are not needed for preferred width calculations. This removes the need for calling
an updateStyle functions and may also fix update issues when zooming in or out.
No new tests, already covered by existing tests.
- rendering/mathml/MathMLStyle.cpp:
(WebCore::MathMLStyle::updateStyleIfNeeded): No need to update layout parameters for the
RenderMathMLRoot class.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::styleDidChange): No need to update layout parameters.
(WebCore::RenderMathMLRoot::horizontalParameters): Move code from updateStyle to retrieve the
horizontal parameters.
(WebCore::RenderMathMLRoot::verticalParameters): Ditto for vertical parameters.
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Call horizontalParameters() to
get the kernings of the index instead of calling updateStyle().
(WebCore::RenderMathMLRoot::layoutBlock): Call horizontalParameters() and
verticalParameters() to get the layout parameters instead of calling updateStyle().
(WebCore::RenderMathMLRoot::paint): Call horizontalParameters() and verticalParameters()
to get the layout parameters.
(WebCore::RenderMathMLRoot::updateFromElement): Deleted. No need to call updateStyle().
(WebCore::RenderMathMLRoot::updateStyle): Deleted.
- rendering/mathml/RenderMathMLRoot.h: Do not override updateFromElement(). Replace some
layout parameters stored on the class with struct and helper functions to manipulate them.
- 11:25 PM Changeset in webkit [204955] by
-
- 2 edits in trunk/Tools
Fix iOS DRT build.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::zoomToScale):
- 11:07 PM Changeset in webkit [204954] by
-
- 6 edits in trunk
WorkerLocation.prototype.toString() should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=161183
Reviewed by Ryosuke Niwa.
Source/WebCore:
WorkerLocation.prototype.toString() should be enumerable:
No new tests, updated existing test.
- workers/WorkerLocation.h:
(WebCore::WorkerLocation::toString): Deleted.
- workers/WorkerLocation.idl:
Also use USVString string type instead of DOMString to match the
specification. There is no behavior change because those attributes
are readonly.
LayoutTests:
Add layout test coverage.
- fast/workers/resources/worker-location.js:
- fast/workers/worker-location-expected.txt:
- 8:06 PM Changeset in webkit [204953] by
-
- 9 edits in trunk
Location.toString() should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=161179
Reviewed by Geoffrey Garen.
Source/WebCore:
Location.toString() should be enumerable as per:
This patch stops hard-coding the toString() operation on the Location
interface and makes the 'href' attribute a stringifier attribute instead,
as per the specification. The generated toString() has the same behavior
as it used to but it is now enumerable, as it should.
No new tests, updated existing test.
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::toStringFunction): Deleted.
- page/Location.idl:
LayoutTests:
Update existing tests and add layout test coverage.
- fast/dom/Window/window-appendages-cleared-expected.txt:
- fast/dom/toString_attributes-expected.txt:
- fast/dom/toString_attributes.html:
- js/dom/toString-dontEnum-expected.txt:
- js/dom/toString-dontEnum.html:
- 7:40 PM Changeset in webkit [204952] by
-
- 11 edits2 adds in trunk
Implement
CSS.escapeas per CSSOM
https://bugs.webkit.org/show_bug.cgi?id=126337
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-24
Reviewed by Dean Jackson.
Source/WebCore:
Test: css3/escape-dom-api.html
- css/CSSOMUtils.cpp:
(WebCore::serializeIdentifier):
Update serialization to match the latest version of the spec:
<https://drafts.csswg.org/cssom/#serialize-an-identifier>
New handling for 0x0, 0x7f, just "-", and "--" is now allowed.
- css/DOMCSSNamespace.cpp:
(WebCore::DOMCSSNamespace::escape):
- css/DOMCSSNamespace.h:
- css/DOMCSSNamespace.idl:
New CSS.escape method.
LayoutTests:
CSS.escape is part of the CSSOM Spec:
https://drafts.csswg.org/cssom/#the-css.escape%28%29-method
Tests:
https://github.com/mathiasbynens/CSS.escape/blob/master/tests/tests.js
Change is based on the Blink change (patch by <rob.buis@samsung.com>) and follow-ups:
<https://chromium.googlesource.com/chromium/blink/+/c1a5ffdc924b089e70cd33ad2726b58cc8312abe>
- css3/escape-dom-api-expected.txt: Added.
- css3/escape-dom-api.html: Added.
New tests, taken from the polyfill.
- fast/css/parsing-css-nonascii-expected.txt:
- fast/css/parsing-css-nonascii.html:
- fast/css/selector-text-escape.html:
Update existing tests now that 0x7f is escaped.
- js/dom/function-removed-after-parsing-expected.txt:
- js/dom/function-removed-after-parsing.html:
Rename use of
CSS.escapehere now thatCSS.escapeexists.
- 6:55 PM Changeset in webkit [204951] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=155700
<rdar://problem/27720727>
Reviewed by David Hyatt.
Source/WebCore:
RenderBox::m_minPreferredLogicalWidth/m_maxPreferredLogicalWidth don't need special initial value since
preferredLogicalWidthsDirty flag guards them. -1 as initial value can cause problems for renderers that don't
override RenderBox::computePreferredLogicalWidths().
Test: fast/ruby/assert-when-content-size-is-negative.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::dirtyLineBoxes):
(WebCore::RenderBox::deleteLineBoxWrapper):
- rendering/RenderBox.h:
LayoutTests:
- fast/ruby/assert-when-content-size-is-negative-expected.txt: Added.
- fast/ruby/assert-when-content-size-is-negative.html: Added.
- 6:42 PM Changeset in webkit [204950] by
-
- 1 copy in tags/Safari-602.2.3
New tag.
- 6:24 PM Changeset in webkit [204949] by
-
- 8 edits6 adds1 delete in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 fast/text tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/fast/text/atsui-multiple-renderers-expected.txt:
- platform/ios-simulator-wk1/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/ios-simulator-wk1/fast/text/atsui-spacing-features-expected.txt:
- platform/ios-simulator-wk1/fast/text/font-weights-expected.txt: Added.
- platform/ios-simulator-wk1/fast/text/international/khmer-selection-expected.txt: Added.
- platform/ios-simulator-wk1/fast/text/system-font-weight-expected.txt: Added.
- platform/ios-simulator-wk1/fast/text/tatechuyoko-expected.txt: Added.
- platform/ios-simulator-wk1/fast/text/textIteratorNilRenderer-expected.txt:
- platform/ios-simulator-wk1/fast/text/wbr-expected.txt:
- platform/ios-simulator-wk1/fast/text/word-space-expected.txt: Added.
- platform/ios-simulator-wk2/fast/text/decorations-with-text-combine-expected.txt: Removed.
- platform/ios-simulator/fast/text/decorations-with-text-combine-expected.txt:
- 6:22 PM Changeset in webkit [204948] by
-
- 5 edits37 adds in trunk
Import w3c URL tests
https://bugs.webkit.org/show_bug.cgi?id=161177
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
- web-platform-tests/url: Added.
- web-platform-tests/url/OWNERS: Added.
- web-platform-tests/url/README.md: Added.
- web-platform-tests/url/a-element-expected.txt: Added.
- web-platform-tests/url/a-element-xhtml-expected.txt: Added.
- web-platform-tests/url/a-element-xhtml.xhtml: Added.
- web-platform-tests/url/a-element.html: Added.
- web-platform-tests/url/a-element.js: Added.
(setup.async_test.string_appeared_here.setup.step):
(setBase):
(bURL):
(runURLTests):
- web-platform-tests/url/historical-expected.txt: Added.
- web-platform-tests/url/historical.html: Added.
- web-platform-tests/url/historical.worker.js: Added.
(test):
- web-platform-tests/url/interfaces-expected.txt: Added.
- web-platform-tests/url/interfaces.html: Added.
- web-platform-tests/url/setters_tests.json: Added.
- web-platform-tests/url/url-constructor-expected.txt: Added.
- web-platform-tests/url/url-constructor.html: Added.
- web-platform-tests/url/url-domainToUnicode-expected.txt: Added.
- web-platform-tests/url/url-domainToUnicode.html: Added.
- web-platform-tests/url/url-setters-expected.txt: Added.
- web-platform-tests/url/url-setters.html: Added.
- web-platform-tests/url/urlsearchparams-append-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-append.html: Added.
- web-platform-tests/url/urlsearchparams-constructor-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-constructor.html: Added.
- web-platform-tests/url/urlsearchparams-delete-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-delete.html: Added.
- web-platform-tests/url/urlsearchparams-get-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-get.html: Added.
- web-platform-tests/url/urlsearchparams-getall-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-getall.html: Added.
- web-platform-tests/url/urlsearchparams-has-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-has.html: Added.
- web-platform-tests/url/urlsearchparams-set-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-set.html: Added.
- web-platform-tests/url/urlsearchparams-stringifier-expected.txt: Added.
- web-platform-tests/url/urlsearchparams-stringifier.html: Added.
- web-platform-tests/url/urltestdata.json: Added.
Source/WebCore:
Tests: imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml
imported/w3c/web-platform-tests/url/a-element.html
imported/w3c/web-platform-tests/url/historical.html
imported/w3c/web-platform-tests/url/interfaces.html
imported/w3c/web-platform-tests/url/url-constructor.html
imported/w3c/web-platform-tests/url/url-domainToUnicode.html
imported/w3c/web-platform-tests/url/url-setters.html
imported/w3c/web-platform-tests/url/urlsearchparams-append.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
imported/w3c/web-platform-tests/url/urlsearchparams-delete.html
imported/w3c/web-platform-tests/url/urlsearchparams-get.html
imported/w3c/web-platform-tests/url/urlsearchparams-getall.html
imported/w3c/web-platform-tests/url/urlsearchparams-has.html
imported/w3c/web-platform-tests/url/urlsearchparams-set.html
imported/w3c/web-platform-tests/url/urlsearchparams-stringifier.html
- platform/URL.cpp:
(WebCore::URL::setQuery):
LayoutTests:
Skip asserting test.
- 6:21 PM Changeset in webkit [204947] by
-
- 14 edits1 add in trunk
[JSC] Make FRound work with any type
https://bugs.webkit.org/show_bug.cgi?id=161129
Reviewed by Geoffrey Garen.
JSTests:
- stress/arith-fround-on-various-types.js: Added.
Source/JavaScriptCore:
Math.fround() does nothing with arguments past the first one
(https://tc39.github.io/ecma262/#sec-math.fround).
We can unify ArithFRound with the other single-input intrinsics.
Everything else is same old: if the input type is not a number,
be pessimistic about everything and do a C call.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithFRound):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithFRound):
- 5:46 PM Changeset in webkit [204946] by
-
- 2 edits in trunk/Source/WebKit2
cmake build broken by MessageRecorder removal
https://bugs.webkit.org/show_bug.cgi?id=161175
Patch by JF Bastien <jfbastien@apple.com> on 2016-08-24
Reviewed by Dean Jackson.
- PlatformMac.cmake:
- 4:58 PM Changeset in webkit [204945] by
-
- 9 edits in trunk
[iOS DRT] Hook up uiController.zoomToScale() for DRT
https://bugs.webkit.org/show_bug.cgi?id=161173
Reviewed by Tim Horton.
Tools:
Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
the WebThread!), but queue up the callback first.
- DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
- DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
(-[DumpRenderTreeWebScrollView initWithFrame:]):
(-[DumpRenderTreeWebScrollView dealloc]):
(-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
(-[DumpRenderTreeWebScrollView completedZoomToScale]):
(-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
(-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
(-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::zoomToScale):
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::context):
LayoutTests:
The one test in fast/zooming/ios works in DRT and WTR now.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 4:47 PM Changeset in webkit [204944] by
-
- 34 edits1 add in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 fast/table tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/fast/table/003-expected.txt:
- platform/ios-simulator-wk1/fast/table/024-expected.txt:
- platform/ios-simulator-wk1/fast/table/031-expected.txt:
- platform/ios-simulator-wk1/fast/table/032-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/004-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/004-vertical-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/bug14274-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-cell-append-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-cell-remove-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
- platform/ios-simulator-wk1/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
- platform/ios-simulator-wk1/fast/table/colspan-with-all-percent-cells-expected.txt:
- platform/ios-simulator-wk1/fast/table/edge-offsets-expected.txt: Added.
- platform/ios-simulator-wk1/fast/table/overflowHidden-expected.txt:
- platform/ios-simulator-wk1/fast/table/percent-widths-stretch-vertical-expected.txt:
- platform/ios-simulator-wk1/fast/table/simple_paint-expected.txt:
- platform/ios-simulator-wk1/fast/table/table-anonymous-cell-bug-expected.txt:
- platform/ios-simulator-wk1/fast/table/table-anonymous-row-bug-expected.txt:
- platform/ios-simulator-wk1/fast/table/table-anonymous-section-bug-expected.txt:
- platform/ios-simulator-wk1/fast/table/table-cell-split-expected.txt:
- platform/ios-simulator-wk1/fast/table/table-insert-before-non-anonymous-block-expected.txt:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 4:36 PM Changeset in webkit [204943] by
-
- 2 edits in trunk/Source/WebCore
Rebaseline bindings tests after r204923.
Unreviewed test gardening.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
- 4:27 PM Changeset in webkit [204942] by
-
- 4 edits in trunk/Source/JavaScriptCore
Shrink DFG::OSRExit a bit.
<https://webkit.org/b/161169>
Reviewed by Geoffrey Garen.
Rearrange the members of OSRExitBase and DFG::OSRExit to save 16 bytes per instance.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::OSRExitBase):
- 4:26 PM Changeset in webkit [204941] by
-
- 4 edits in trunk/Source
FocusController multiple dereferenced NULL pointers
https://bugs.webkit.org/show_bug.cgi?id=160808
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-24
Reviewed by Darin Adler.
Source/WebCore:
No new tests needed, fix does not change functionality.
This change fixes a number of NULL pointer dereferences which occur in FocusController.
- page/FocusController.cpp:
(WebCore::isFocusableElementOrScopeOwner): Changed KeyboardEvent reference to pointer.
(WebCore::isNonFocusableScopeOwner): Ditto.
(WebCore::isFocusableScopeOwner): Ditto.
(WebCore::shadowAdjustedTabIndex): Ditto.
(WebCore::FocusController::findFocusableElementAcrossFocusScope): Pass pointer instead of reference to KeyboardEvent.
(WebCore::FocusController::nextFocusableElementWithinScope): Ditto.
(WebCore::FocusController::previousFocusableElementWithinScope): Ditto.
(WebCore::FocusController::findElementWithExactTabIndex): Ditto.
(WebCore::nextElementWithGreaterTabIndex): Ditto.
(WebCore::previousElementWithLowerTabIndex): Ditto.
(WebCore::FocusController::nextFocusableElementOrScopeOwner): Ditto.
(WebCore::FocusController::previousFocusableElementOrScopeOwner): Ditto.
(WebCore::relinquishesEditingFocus): Ditto.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setInitialFocus): Should use nullptr, not 0 to initialize NULL pointer.
- 4:21 PM Changeset in webkit [204940] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: unexpected cursor changes while dragging ruler handle in rendering frames timeline
https://bugs.webkit.org/show_bug.cgi?id=161101
<rdar://problem/27974117>
Reviewed by Brian Burg.
-webkit-grab(bing) cursor styles shouldn't be applied to the selection
drag element when resizing.
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag):
(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag:active):
(.timeline-ruler:not(.disabled) > .selection-drag): Deleted.
(.timeline-ruler:not(.disabled) > .selection-drag:active): Deleted.
- 3:29 PM Changeset in webkit [204939] by
-
- 2 edits in branches/safari-602.1.50.0-branch/Source/WebKit2
- 3:25 PM Changeset in webkit [204938] by
-
- 3 edits2 adds in trunk
AX: VoiceOver on iOS ignores aria-checked on menuitemradio and menuitemcheckbox
https://bugs.webkit.org/show_bug.cgi?id=161118
Reviewed by Chris Fleizach.
Source/WebCore:
Added checkboxOrRadioValue and toggle trait to menuitemradio and menuitemcheckbox.
Test: accessibility/ios-simulator/menuitem-checked.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
LayoutTests:
- accessibility/ios-simulator/menuitem-checked-expected.txt: Added.
- accessibility/ios-simulator/menuitem-checked.html: Added.
- 3:05 PM Changeset in webkit [204937] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, update expectations of iOS simulator WK1 css3 tests
- TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 2:58 PM Changeset in webkit [204936] by
-
- 4 edits in trunk
Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser()
https://bugs.webkit.org/show_bug.cgi?id=161083
<rdar://problem/27986937>
Reviewed by Darin Adler.
Source/WebCore:
Call cancelParsing() right before re-creating the new parser in
Document::implicitOpen(). We would previously call removeChildren()
in between which is was an issue because it can cause JS to be
executed and therefore the parser to be re-created after we have
cancelled parsing.
No new tests, unskipped html/browsers/browsing-the-web/unloading-documents/004.html
which was consistently crashing.
- dom/Document.cpp:
(WebCore::Document::implicitOpen):
LayoutTests:
Unskip html/browsers/browsing-the-web/unloading-documents/004.html as
it is no longer crashing.
- 2:55 PM Changeset in webkit [204935] by
-
- 11 edits2 adds in trunk
[MediaStream] Add support for OverConstrained Error
https://bugs.webkit.org/show_bug.cgi?id=160790
<rdar://problem/27815715>
Reviewed by Jer Noble.
Source/WebCore:
Existing tests updated.
- DerivedSources.make:
- Modules/mediastream/OverconstrainedError.h: Added.
(WebCore::OverconstrainedError::create):
(WebCore::OverconstrainedError::constraint):
(WebCore::OverconstrainedError::message):
(WebCore::OverconstrainedError::OverconstrainedError):
- Modules/mediastream/OverconstrainedError.idl: Added.
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
- fast/dom/Window/get-set-properties-expected.txt:
- fast/dom/Window/get-set-properties.html:
- fast/dom/Window/resources/window-properties.js:
- fast/dom/Window/window-property-shadowing-expected.txt:
- fast/dom/Window/window-property-shadowing.html:
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- 2:39 PM Changeset in webkit [204934] by
-
- 1 edit7 deletes in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 css3 tests
- platform/ios-simulator-wk1/css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/blending/blend-mode-ancestor-clipping-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/blending/blend-mode-isolation-accelerated-overflow-hidden-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/blending/blend-mode-with-accelerated-sibling-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt: Removed.
- platform/ios-simulator-wk1/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
- 2:34 PM Changeset in webkit [204933] by
-
- 2 edits in trunk/Tools
Attempt to fix Windows build after r204918.
Unreviewed build fix.
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::willSendRequest):
- 2:17 PM Changeset in webkit [204932] by
-
- 3 edits in trunk/Source/WebCore
Build the platform name dynamically for the phony WebKitLegacy framework
https://bugs.webkit.org/show_bug.cgi?id=161163
Reviewed by Dan Bernstein.
- Configurations/WebKitLegacyStub.iOS.tbd:
- WebCore.xcodeproj/project.pbxproj:
- 1:53 PM Changeset in webkit [204931] by
-
- 13 edits1 move2 adds2 deletes in trunk
[iOS DRT] Get basic viewport tests working in DRT
https://bugs.webkit.org/show_bug.cgi?id=161160
Reviewed by Tim Horton.
Tools:
Hook up enough of UIScriptController in iOS DRT to be able to read viewport
scale, and get the contentVisibleRect.
Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
One test has different results between DRT and WTR, but DRT behavior seems to differ
from UIWebView here, so just give it a WK1-specific result.
- DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
- DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
(-[DumpRenderTreeBrowserView documentVisibleRect]):
- DumpRenderTree/ios/PixelDumpSupportIOS.mm:
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::zoomScale):
(WTR::UIScriptController::minimumZoomScale):
(WTR::UIScriptController::maximumZoomScale):
(WTR::UIScriptController::contentVisibleRect):
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- DumpRenderTree/mac/DumpRenderTreeMac.h:
LayoutTests:
Enable some fast/viewport/ios/ tests for ios-simulator-wk1 that work now.
"body-overflow-hidden" tests should pass everywhere now since the behavior of overflow:hidden
on the body was reverted.
- fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt:
- fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt:
- fast/viewport/ios/width-is-device-width-overflowing-expected.txt:
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk1/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Removed.
- platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Removed.
- 1:53 PM Changeset in webkit [204930] by
-
- 2 edits in trunk/Tools
Minor project rearrangement.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 1:53 PM Changeset in webkit [204929] by
-
- 2 edits in trunk/Tools
[iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
https://bugs.webkit.org/show_bug.cgi?id=161124
Reviewed by Daniel Bates.
Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
Remove some unnecessary zero initializations of static variables.
Change _setVisibleSize to use the window size, which should not be a behavior change
because this it just used for text autosizing, which is disabled by default,
and only the width is consulted.
- DumpRenderTree/mac/DumpRenderTree.mm:
(adjustWebDocumentForFlexibleViewport):
(adjustWebDocumentForStandardViewport):
(createWebViewAndOffscreenWindow):
- 1:32 PM Changeset in webkit [204928] by
-
- 15 edits in trunk/Source/JavaScriptCore
Rebaseline builtins-generator-tests since r204854 was rolled out.
Unreviewed test gardening.
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
- Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
- Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result:
- 1:32 PM Changeset in webkit [204927] by
-
- 2 edits in trunk/LayoutTests
Marking wpt LayoutTest scroll-restoration-fragment-scrolling-samedoc.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=161143
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 1:19 PM Changeset in webkit [204926] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, update expectations of iOS simulator WK1 svg tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 1:02 PM Changeset in webkit [204925] by
-
- 2 edits in trunk/LayoutTests
Unskip inspector/codemirror tests on mac-wk1 debug.
https://bugs.webkit.org/show_bug.cgi?id=161117
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 1:00 PM Changeset in webkit [204924] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Shift-Tab should unindent selected line
https://bugs.webkit.org/show_bug.cgi?id=159316
Patch by Devin Rousso <Devin Rousso> on 2016-08-24
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CodeMirrorAdditions.js:
(CodeMirror.keyMapdefault):
Changed "Shift-Tab" mapping to "indentLess".
- 12:52 PM Changeset in webkit [204923] by
-
- 4 edits2 adds in trunk
It should not be possible to access Location attributes cross origin
https://bugs.webkit.org/show_bug.cgi?id=161125
<rdar://problem/27982472>
Reviewed by Brent Fulgham.
Source/WebCore:
It should not be possible to access Location attributes cross origin:
We allow access to replace() as per the specification and consistently
with Firefox. The specification seems to indicate we should allow access
to 'href' but Firefox does not and we previously did not so I am not
allowing it in this patch.
Test: http/tests/security/location-cross-origin.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- page/Location.idl:
LayoutTests:
Add layout test coverage.
- http/tests/security/location-cross-origin-expected.txt: Added.
- http/tests/security/location-cross-origin.html: Added.
- 12:38 PM Changeset in webkit [204922] by
-
- 2 edits in branches/safari-602.1.50.0-branch/Source/WebKit2
Merge r204911. rdar://problem/27896368
- 12:37 PM Changeset in webkit [204921] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 12:35 PM Changeset in webkit [204920] by
-
- 26 edits1 copy2 moves in trunk/Source
[JSC] Move generic data structures out of B3
https://bugs.webkit.org/show_bug.cgi?id=161155
Reviewed by Saam Barati.
Source/JavaScriptCore:
Move B3's good generic data structures to WTF.
They can be used for the other kind of basic blocks and nodes.
For example, the generator patch[1] will make BytecodeBasicBlock usable with these structures.
[1]: https://bugs.webkit.org/show_bug.cgi?id=152723
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3BasicBlockUtils.h:
- b3/B3BlockWorklist.h:
- b3/B3CFG.h:
- b3/B3DuplicateTails.cpp:
- b3/B3FixSSA.cpp:
- b3/B3FixSSA.h:
- b3/B3IndexMap.h:
(JSC::B3::IndexMap::IndexMap): Deleted.
(JSC::B3::IndexMap::resize): Deleted.
(JSC::B3::IndexMap::clear): Deleted.
(JSC::B3::IndexMap::size): Deleted.
(JSC::B3::IndexMap::operator[]): Deleted.
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::IndexSet): Deleted.
(JSC::B3::IndexSet::add): Deleted.
(JSC::B3::IndexSet::addAll): Deleted.
(JSC::B3::IndexSet::remove): Deleted.
(JSC::B3::IndexSet::contains): Deleted.
(JSC::B3::IndexSet::size): Deleted.
(JSC::B3::IndexSet::isEmpty): Deleted.
(JSC::B3::IndexSet::Iterable::Iterable): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::iterator): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator*): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator++): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator==): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator!=): Deleted.
(JSC::B3::IndexSet::Iterable::begin): Deleted.
(JSC::B3::IndexSet::Iterable::end): Deleted.
(JSC::B3::IndexSet::values): Deleted.
(JSC::B3::IndexSet::indices): Deleted.
(JSC::B3::IndexSet::dump): Deleted.
- b3/B3LowerToAir.cpp:
- b3/B3PhiChildren.h:
- b3/B3Procedure.h:
(JSC::B3::Procedure::iterator::iterator): Deleted.
(JSC::B3::Procedure::iterator::operator*): Deleted.
(JSC::B3::Procedure::iterator::operator++): Deleted.
(JSC::B3::Procedure::iterator::operator==): Deleted.
(JSC::B3::Procedure::iterator::operator!=): Deleted.
(JSC::B3::Procedure::iterator::findNext): Deleted.
- b3/B3ReduceDoubleToFloat.cpp:
- b3/B3ReduceStrength.cpp:
- b3/B3SSACalculator.h:
- b3/B3UseCounts.h:
- b3/air/AirCode.h:
- b3/air/AirEliminateDeadCode.cpp:
- b3/air/AirFixObviousSpills.cpp:
- b3/air/AirFixPartialRegisterStalls.cpp:
- b3/air/AirGenerate.cpp:
- b3/air/AirGenerationContext.h:
- b3/air/AirLiveness.h:
- b3/air/AirSpillEverything.cpp:
Source/WTF:
Add IndexSet, IndexMap, and IndexedContainerIterator.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/IndexMap.h: Copied from Source/JavaScriptCore/b3/B3IndexMap.h.
(WTF::IndexMap::IndexMap):
(WTF::IndexMap::resize):
(WTF::IndexMap::clear):
(WTF::IndexMap::size):
(WTF::IndexMap::operator[]):
- wtf/IndexSet.h: Renamed from Source/JavaScriptCore/b3/B3IndexSet.h.
(WTF::IndexSet::IndexSet):
(WTF::IndexSet::add):
(WTF::IndexSet::addAll):
(WTF::IndexSet::remove):
(WTF::IndexSet::contains):
(WTF::IndexSet::size):
(WTF::IndexSet::isEmpty):
(WTF::IndexSet::Iterable::Iterable):
(WTF::IndexSet::Iterable::iterator::iterator):
(WTF::IndexSet::Iterable::iterator::operator*):
(WTF::IndexSet::Iterable::iterator::operator++):
(WTF::IndexSet::Iterable::iterator::operator==):
(WTF::IndexSet::Iterable::iterator::operator!=):
(WTF::IndexSet::Iterable::begin):
(WTF::IndexSet::Iterable::end):
(WTF::IndexSet::values):
(WTF::IndexSet::indices):
(WTF::IndexSet::dump):
- wtf/IndexedContainerIterator.h: Renamed from Source/JavaScriptCore/b3/B3IndexMap.h.
(WTF::IndexedContainerIterator::IndexedContainerIterator):
(WTF::IndexedContainerIterator::operator++):
(WTF::IndexedContainerIterator::operator==):
(WTF::IndexedContainerIterator::operator!=):
(WTF::IndexedContainerIterator::findNext):
- 12:29 PM Changeset in webkit [204919] by
-
- 2 edits in trunk/Source/WebCore
Add User Timing to the feature status page
https://bugs.webkit.org/show_bug.cgi?id=161154
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-24
Reviewed by Darin Adler.
- features.json:
- 12:27 PM Changeset in webkit [204918] by
-
- 8 edits2 deletes in trunk
WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
https://bugs.webkit.org/show_bug.cgi?id=42777
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-24
Reviewed by Darin Adler.
The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called. Removed function and test.
Tools:
- DumpRenderTree/TestRunner.cpp:
(setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
- DumpRenderTree/TestRunner.h:
(TestRunner::deferMainResourceDataLoad): Ditto.
(TestRunner::setDeferMainResourceDataLoad): Ditto.
- DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
LayoutTests:
- fast/loader/non-deferred-substitute-load-expected.txt: Removed fast/loader/non-deferred-substitute-load.html.
- fast/loader/non-deferred-substitute-load.html: Ditto.
- platform/ios-simulator-wk2/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- platform/wk2/TestExpectations: Ditto.
- 12:23 PM Changeset in webkit [204917] by
-
- 7 edits in trunk/Source
Source/bmalloc:
Add bmalloc::api::isEnabled().
<https://webkit.org/b/160534>
Reviewed by Joseph Pecoraro.
- bmalloc/bmalloc.h:
(bmalloc::api::isEnabled):
Source/WebCore:
Leaks bot hits an assertion in ResourceUsageThread::platformThreadBody
<https://webkit.org/b/160534>
Reviewed by Joseph Pecoraro.
Use the correct malloc bucket when bmalloc is disabled (which is the case on leaks bots.)
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::ResourceUsageThread::platformThreadBody):
Source/WTF:
Add WTF::isFastMallocEnabled().
<https://webkit.org/b/160534>
Reviewed by Joseph Pecoraro.
- wtf/FastMalloc.cpp:
(WTF::isFastMallocEnabled):
- wtf/FastMalloc.h:
- 12:14 PM Changeset in webkit [204916] by
-
- 9 edits2 adds in trunk
Add enum traits and use them in the IPC::Decoder
https://bugs.webkit.org/show_bug.cgi?id=161103
Reviewed by Sam Weinig.
Source/WebKit2:
- Platform/IPC/Decoder.h:
- Platform/IPC/Encoder.h:
Add new encode/decode functions.
- Shared/mac/ArgumentCodersMac.mm:
Change NSType to be a strongly typed enum. Use encode/decode
instead of encodeEnum/decodeEnum since the latter don't have the
enum check.
Source/WTF:
Add EnumTraits.h which provides a forward declaration for WTF::EnumTraits as well as
the WTF::isValidEnum function.
- WTF.xcodeproj/project.pbxproj:
- wtf/EnumTraits.h: Added.
Tools:
Add API test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
(TestWebKitAPI::TEST):
- 12:05 PM Changeset in webkit [204915] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, temporarily skipping W3C tests trying to load www1.localhost.
- 12:02 PM Changeset in webkit [204914] by
-
- 1 copy in tags/Safari-603.1.3
New tag.
- 12:01 PM Changeset in webkit [204913] by
-
- 5 edits in trunk/Source
Versioning.
- 12:00 PM Changeset in webkit [204912] by
-
- 279 edits1 add19 deletes in trunk
Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
JSTests:
- stress/array-storage-array-unshift.js: Removed.
- stress/contiguous-array-unshift.js: Removed.
- stress/double-array-unshift.js: Removed.
- stress/int32-array-unshift.js: Removed.
Source/bmalloc:
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::allocate):
(bmalloc::Allocator::tryAllocate): Deleted.
(bmalloc::Allocator::allocateImpl): Deleted.
- bmalloc/Allocator.h:
- bmalloc/Cache.h:
(bmalloc::Cache::tryAllocate): Deleted.
- bmalloc/bmalloc.h:
(bmalloc::api::tryMemalign): Deleted.
Source/JavaScriptCore:
- API/JSTypedArray.cpp:
- API/ObjCCallbackFunction.mm:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/builtins/builtins_generate_combined_implementation.py:
(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):
- Scripts/builtins/builtins_generate_internals_wrapper_implementation.py:
(BuiltinsInternalsWrapperImplementationGenerator.generate_secondary_header_includes):
- Scripts/builtins/builtins_generate_separate_implementation.py:
(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::JumpList::link):
(JSC::AbstractMacroAssembler::JumpList::linkTo):
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add32):
- assembler/MacroAssemblerCodeRef.cpp: Removed.
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::createLLIntCodePtr):
(JSC::MacroAssemblerCodePtr::dumpWithName):
(JSC::MacroAssemblerCodePtr::dump):
(JSC::MacroAssemblerCodeRef::createLLIntCodeRef):
(JSC::MacroAssemblerCodeRef::dump):
- b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::appendBoolConstant): Deleted.
- b3/B3BasicBlock.h:
- b3/B3DuplicateTails.cpp:
- b3/B3StackmapGenerationParams.h:
- b3/testb3.cpp:
(JSC::B3::run):
(JSC::B3::testPatchpointTerminalReturnValue): Deleted.
- bindings/ScriptValue.cpp:
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
- bytecode/BytecodeBasicBlock.cpp:
- bytecode/BytecodeLivenessAnalysis.cpp:
- bytecode/BytecodeUseDef.h:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::callTypeFor): Deleted.
- bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::callTypeFor):
- bytecode/CallLinkStatus.cpp:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::clearLLIntGetByIdCache): Deleted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::jitCodeMap):
(JSC::clearLLIntGetByIdCache):
- bytecode/Instruction.h:
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::isNull):
(JSC::ObjectAllocationProfile::initialize):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generateImpl):
(JSC::PolymorphicAccess::regenerate):
- bytecode/PolymorphicAccess.h:
- bytecode/PreciseJumpTargets.cpp:
- bytecode/StructureStubInfo.cpp:
- bytecode/StructureStubInfo.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::vm):
- bytecode/UnlinkedCodeBlock.h:
- bytecode/UnlinkedInstructionStream.cpp:
- bytecode/UnlinkedInstructionStream.h:
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCompile.cpp:
- ftl/FTLJITFinalizer.cpp:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileAllocateArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::initializeArrayElements):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateCell):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateVariableSizedObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::allocateArrayWithSize): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::allocatorForSize): Deleted.
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::add):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::select):
(JSC::FTL::Output::addIncomingToPhi):
(JSC::FTL::Output::appendSuccessor): Deleted.
- ftl/FTLOutput.h:
- ftl/FTLValueFromBlock.h:
(JSC::FTL::ValueFromBlock::ValueFromBlock):
(JSC::FTL::ValueFromBlock::operator bool): Deleted.
- ftl/FTLWeightedTarget.h:
(JSC::FTL::WeightedTarget::frequentedBlock): Deleted.
- heap/CellContainer.h: Removed.
- heap/CellContainerInlines.h: Removed.
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
- heap/ConservativeRoots.h:
(JSC::ConservativeRoots::roots):
- heap/CopyToken.h:
- heap/FreeList.cpp: Removed.
- heap/FreeList.h: Removed.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::gatherStackRoots):
(JSC::Heap::gatherJSStackRoots):
(JSC::Heap::gatherScratchBufferRoots):
(JSC::Heap::clearLivenessData):
(JSC::Heap::visitSmallStrings):
(JSC::Heap::visitConservativeRoots):
(JSC::Heap::removeDeadCompilerWorklistEntries):
(JSC::Heap::gatherExtraHeapSnapshotData):
(JSC::Heap::removeDeadHeapSnapshotNodes):
(JSC::Heap::visitProtectedObjects):
(JSC::Heap::visitArgumentBuffers):
(JSC::Heap::visitException):
(JSC::Heap::visitStrongHandles):
(JSC::Heap::visitHandleStack):
(JSC::Heap::visitSamplingProfiler):
(JSC::Heap::traceCodeBlocksAndJITStubRoutines):
(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::clearUnmarkedExecutables):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::collectImpl):
(JSC::Heap::suspendCompilerThreads):
(JSC::Heap::willStartCollection):
(JSC::Heap::flushOldStructureIDTables):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::stopAllocation):
(JSC::Heap::reapWeakHandles):
(JSC::Heap::pruneStaleEntriesFromWeakGCMaps):
(JSC::Heap::sweepArrayBuffers):
(JSC::Heap::snapshotMarkedSpace):
(JSC::Heap::deleteSourceProviderCaches):
(JSC::Heap::notifyIncrementalSweeper):
(JSC::Heap::writeBarrierCurrentlyExecutingCodeBlocks):
(JSC::Heap::resetAllocators):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::resumeCompilerThreads):
(JSC::Zombify::visit):
(JSC::Heap::collectWithoutAnySweep): Deleted.
(JSC::Heap::prepareForMarking): Deleted.
(JSC::Heap::forEachCodeBlockImpl): Deleted.
- heap/Heap.h:
(JSC::Heap::allocatorForObjectWithoutDestructor):
(JSC::Heap::allocatorForObjectWithDestructor):
(JSC::Heap::storageAllocator):
(JSC::Heap::jitStubRoutines):
(JSC::Heap::codeBlockSet):
(JSC::Heap::allocatorForAuxiliaryData): Deleted.
- heap/HeapCell.h:
(JSC::HeapCell::isZapped):
- heap/HeapCellInlines.h: Removed.
- heap/HeapInlines.h:
(JSC::Heap::heap):
(JSC::Heap::isLive):
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::setMarked):
(JSC::Heap::forEachCodeBlock):
(JSC::Heap::allocateObjectOfType):
(JSC::Heap::subspaceForObjectOfType):
(JSC::Heap::allocatorForObjectOfType):
(JSC::Heap::isPointerGCObject):
(JSC::Heap::isValueGCObject):
(JSC::Heap::cellSize): Deleted.
(JSC::Heap::allocateAuxiliary): Deleted.
(JSC::Heap::tryAllocateAuxiliary): Deleted.
(JSC::Heap::tryReallocateAuxiliary): Deleted.
- heap/HeapUtil.h: Removed.
- heap/LargeAllocation.cpp: Removed.
- heap/LargeAllocation.h: Removed.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::retire):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryPopFreeList):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::MarkedAllocator): Deleted.
(JSC::MarkedAllocator::tryAllocateWithoutCollectingImpl): Deleted.
(JSC::MarkedAllocator::tryAllocateWithoutCollecting): Deleted.
(JSC::MarkedAllocator::tryAllocateSlowCase): Deleted.
(JSC::MarkedAllocator::allocateSlowCaseImpl): Deleted.
(JSC::blockHeaderSize): Deleted.
(JSC::MarkedAllocator::blockSizeForBytes): Deleted.
(JSC::MarkedAllocator::tryAllocateBlock): Deleted.
(JSC::MarkedAllocator::setFreeList): Deleted.
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::offsetOfFreeListHead):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::init):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::stopAllocating):
(JSC::MarkedAllocator::offsetOfFreeList): Deleted.
(JSC::MarkedAllocator::offsetOfCellSize): Deleted.
(JSC::MarkedAllocator::tryAllocate): Deleted.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::stopAllocating):
(JSC::MarkedBlock::clearMarksWithCollectionType):
(JSC::MarkedBlock::resumeAllocating):
(JSC::MarkedBlock::didRetireBlock):
(JSC::MarkedBlock::tryCreate): Deleted.
(JSC::MarkedBlock::sweepHelperSelectScribbleMode): Deleted.
(JSC::MarkedBlock::sweepHelperSelectStateAndSweepMode): Deleted.
(JSC::MarkedBlock::forEachFreeCell): Deleted.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::FreeList::FreeList):
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::setHasAnyMarked): Deleted.
(JSC::MarkedBlock::hasAnyMarked): Deleted.
(JSC::MarkedBlock::clearHasAnyMarked): Deleted.
(JSC::MarkedBlock::cellAlign): Deleted.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::zombifySweep):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
(JSC::MarkedSpace::forEachAllocator):
(JSC::MarkedSpace::stopAllocating):
(JSC::MarkedSpace::resumeAllocating):
(JSC::MarkedSpace::isPagedOut):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearNewlyAllocated):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::initializeSizeClassForStepSize): Deleted.
(JSC::MarkedSpace::allocate): Deleted.
(JSC::MarkedSpace::tryAllocate): Deleted.
(JSC::MarkedSpace::allocateLarge): Deleted.
(JSC::MarkedSpace::tryAllocateLarge): Deleted.
(JSC::MarkedSpace::sweepLargeAllocations): Deleted.
(JSC::MarkedSpace::prepareForMarking): Deleted.
(JSC::MarkedSpace::objectCount): Deleted.
(JSC::MarkedSpace::size): Deleted.
(JSC::MarkedSpace::capacity): Deleted.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::blocksWithNewObjects):
(JSC::MarkedSpace::forEachLiveCell):
(JSC::MarkedSpace::forEachDeadCell):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::destructorAllocatorFor):
(JSC::MarkedSpace::auxiliaryAllocatorFor):
(JSC::MarkedSpace::allocateWithoutDestructor):
(JSC::MarkedSpace::allocateWithDestructor):
(JSC::MarkedSpace::allocateAuxiliary):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::sizeClassToIndex): Deleted.
(JSC::MarkedSpace::indexToSizeClass): Deleted.
(JSC::MarkedSpace::largeAllocations): Deleted.
(JSC::MarkedSpace::largeAllocationsNurseryOffset): Deleted.
(JSC::MarkedSpace::largeAllocationsOffsetForThisCollection): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionBegin): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionEnd): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionSize): Deleted.
(JSC::MarkedSpace::tryAllocateAuxiliary): Deleted.
(JSC::MarkedSpace::forEachAllocator): Deleted.
(JSC::MarkedSpace::optimalSizeFor): Deleted.
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::appendJSCellOrAuxiliary): Deleted.
(JSC::SlotVisitor::markAuxiliary): Deleted.
(JSC::SlotVisitor::noteLiveAuxiliaryCell): Deleted.
- heap/SlotVisitor.h:
- heap/WeakBlock.cpp:
(JSC::WeakBlock::create):
(JSC::WeakBlock::WeakBlock):
(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):
- heap/WeakBlock.h:
(JSC::WeakBlock::disconnectMarkedBlock):
(JSC::WeakBlock::disconnectContainer): Deleted.
- heap/WeakSet.cpp:
(JSC::WeakSet::sweep):
(JSC::WeakSet::addAllocator):
- heap/WeakSet.h:
(JSC::WeakSet::WeakSet):
- heap/WeakSetInlines.h:
(JSC::WeakSet::allocate):
- inspector/InjectedScriptManager.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
- inspector/JSJavaScriptCallFrame.cpp:
- inspector/ScriptDebugServer.cpp:
- inspector/agents/InspectorDebuggerAgent.cpp:
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/Interpreter.cpp:
(JSC::StackFrame::sourceID):
(JSC::StackFrame::sourceURL):
(JSC::StackFrame::functionName):
(JSC::loadVarargs):
(JSC::StackFrame::computeLineAndColumn):
(JSC::StackFrame::toString):
- interpreter/Interpreter.h:
(JSC::StackFrame::isNative):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitAllocate):
(JSC::AssemblyHelpers::emitAllocateJSCell):
(JSC::AssemblyHelpers::emitAllocateJSObject):
(JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize):
(JSC::AssemblyHelpers::emitAllocateVariableSized):
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator): Deleted.
- jit/GCAwareJITStubRoutine.cpp:
(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):
- jit/JIT.cpp:
(JSC::JIT::compileCTINativeCall): Deleted.
- jit/JIT.h:
(JSC::JIT::compileCTINativeCall):
- jit/JITExceptions.cpp:
(JSC::genericUnwind): Deleted.
- jit/JITExceptions.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
- jit/JITThunks.cpp:
- jit/JITThunks.h:
- jsc.cpp:
(functionDescribeArray):
(main):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntExceptions.cpp:
- llint/LLIntThunks.cpp:
- llint/LLIntThunks.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/ModuleAnalyzer.cpp:
- parser/NodeConstructors.h:
- parser/Nodes.h:
- profiler/ProfilerBytecode.cpp:
- profiler/ProfilerBytecode.h:
- profiler/ProfilerBytecodeSequence.cpp:
- runtime/ArrayConventions.h:
(JSC::indexingHeaderForArray):
(JSC::baseIndexingHeaderForArray):
(JSC::indexingHeaderForArrayStorage): Deleted.
(JSC::baseIndexingHeaderForArrayStorage): Deleted.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
(JSC::concatAppendOne):
(JSC::arrayProtoPrivateFuncConcatMemcpy):
- runtime/ArrayStorage.h:
(JSC::ArrayStorage::vectorLength):
(JSC::ArrayStorage::sizeFor):
(JSC::ArrayStorage::totalSizeFor): Deleted.
(JSC::ArrayStorage::totalSize): Deleted.
(JSC::ArrayStorage::availableVectorLength): Deleted.
(JSC::ArrayStorage::optimalVectorLength): Deleted.
- runtime/AuxiliaryBarrier.h: Removed.
- runtime/AuxiliaryBarrierInlines.h: Removed.
- runtime/Butterfly.h:
- runtime/ButterflyInlines.h:
(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::growArrayRight):
(JSC::Butterfly::availableContiguousVectorLength): Deleted.
(JSC::Butterfly::optimalContiguousVectorLength): Deleted.
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createEmpty):
- runtime/CommonSlowPathsExceptions.cpp:
- runtime/CommonSlowPathsExceptions.h:
- runtime/DataView.cpp:
- runtime/DirectArguments.h:
- runtime/ECMAScriptSpecInternalFunctions.cpp:
- runtime/Error.cpp:
- runtime/Error.h:
- runtime/ErrorInstance.cpp:
- runtime/ErrorInstance.h:
- runtime/Exception.cpp:
- runtime/Exception.h:
- runtime/GeneratorFrame.cpp:
- runtime/GeneratorPrototype.cpp:
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
- runtime/IntlCollator.cpp:
- runtime/IntlCollatorConstructor.cpp:
- runtime/IntlCollatorPrototype.cpp:
- runtime/IntlDateTimeFormat.cpp:
- runtime/IntlDateTimeFormatConstructor.cpp:
- runtime/IntlDateTimeFormatPrototype.cpp:
- runtime/IntlNumberFormat.cpp:
- runtime/IntlNumberFormatConstructor.cpp:
- runtime/IntlNumberFormatPrototype.cpp:
- runtime/IntlObject.cpp:
- runtime/IteratorPrototype.cpp:
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::appendMemcpy):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::fastSlice):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::tryCreateUninitialized): Deleted.
- runtime/JSArray.h:
(JSC::createContiguousArrayButterfly):
(JSC::createArrayButterfly):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):
- runtime/JSArrayBufferView.h:
- runtime/JSCInlines.h:
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpInContextAssumingStructure):
- runtime/JSCallee.cpp:
(JSC::JSCallee::JSCallee):
- runtime/JSCell.cpp:
(JSC::JSCell::estimatedSize):
- runtime/JSCell.h:
(JSC::JSCell::cellStateOffset):
- runtime/JSCellInlines.h:
(JSC::JSCell::vm):
(JSC::ExecState::vm):
(JSC::JSCell::classInfo):
(JSC::JSCell::callDestructor): Deleted.
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::allocateAndInitializeRareData):
(JSC::JSFunction::initializeRareData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::setFunctionName):
(JSC::JSFunction::reifyLength):
(JSC::JSFunction::reifyName):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyBoundNameIfNeeded):
- runtime/JSFunction.h:
- runtime/JSFunctionInlines.h:
(JSC::JSFunction::createWithInvalidatedReallocationWatchpoint):
(JSC::JSFunction::JSFunction):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):
- runtime/JSInternalPromise.cpp:
- runtime/JSInternalPromiseConstructor.cpp:
- runtime/JSInternalPromiseDeferred.cpp:
- runtime/JSInternalPromisePrototype.cpp:
- runtime/JSJob.cpp:
- runtime/JSMapIterator.cpp:
- runtime/JSModuleNamespaceObject.cpp:
- runtime/JSModuleRecord.cpp:
- runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::visitButterfly):
(JSC::JSObject::copyBackingStore):
(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::createInitialArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):
- runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::globalObject): Deleted.
- runtime/JSObjectInlines.h:
- runtime/JSPromise.cpp:
- runtime/JSPromiseConstructor.cpp:
- runtime/JSPromiseDeferred.cpp:
- runtime/JSPromisePrototype.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSScope.cpp:
(JSC::JSScope::resolve):
- runtime/JSScope.h:
(JSC::JSScope::vm):
(JSC::JSScope::globalObject): Deleted.
- runtime/JSSetIterator.cpp:
- runtime/JSStringIterator.cpp:
- runtime/JSTemplateRegistryKey.cpp:
- runtime/JSTypedArrayViewConstructor.cpp:
- runtime/JSTypedArrayViewPrototype.cpp:
- runtime/JSWeakMap.cpp:
- runtime/JSWeakSet.cpp:
- runtime/MapConstructor.cpp:
- runtime/MapIteratorPrototype.cpp:
- runtime/MapPrototype.cpp:
- runtime/NativeErrorConstructor.cpp:
- runtime/NativeStdFunctionCell.cpp:
- runtime/Operations.h:
(JSC::scribbleFreeCells): Deleted.
(JSC::scribble): Deleted.
- runtime/Options.h:
- runtime/PropertyTable.cpp:
- runtime/ProxyConstructor.cpp:
- runtime/ProxyObject.cpp:
- runtime/ProxyRevoke.cpp:
- runtime/RegExp.cpp:
(JSC::RegExp::match):
(JSC::RegExp::matchConcurrently):
(JSC::RegExp::matchCompareWithInterpreter):
- runtime/RegExp.h:
- runtime/RegExpConstructor.h:
- runtime/RegExpInlines.h:
(JSC::RegExp::matchInline):
- runtime/RegExpMatchesArray.h:
(JSC::tryCreateUninitializedRegExpMatchesArray):
(JSC::createRegExpMatchesArray):
- runtime/RegExpPrototype.cpp:
(JSC::genericSplit):
- runtime/RuntimeType.cpp:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::processUnverifiedStackTraces):
- runtime/SetConstructor.cpp:
- runtime/SetIteratorPrototype.cpp:
- runtime/SetPrototype.cpp:
- runtime/StackFrame.cpp: Removed.
- runtime/StackFrame.h: Removed.
- runtime/StringConstructor.cpp:
- runtime/StringIteratorPrototype.cpp:
- runtime/TemplateRegistry.cpp:
- runtime/TestRunnerUtils.cpp:
(JSC::finalizeStatsAtEndOfTesting): Deleted.
- runtime/TestRunnerUtils.h:
- runtime/TypeProfilerLog.cpp:
- runtime/TypeSet.cpp:
- runtime/VM.cpp:
(JSC::VM::ensureStackCapacityForCLoop): Deleted.
(JSC::VM::isSafeToRecurseSoftCLoop): Deleted.
- runtime/VM.h:
- runtime/VMEntryScope.h:
- runtime/VMInlines.h:
(JSC::VM::ensureStackCapacityFor):
(JSC::VM::isSafeToRecurseSoft):
- runtime/WeakMapConstructor.cpp:
- runtime/WeakMapData.cpp:
- runtime/WeakMapPrototype.cpp:
- runtime/WeakSetConstructor.cpp:
- runtime/WeakSetPrototype.cpp:
- testRegExp.cpp:
(testOneRegExp):
- tools/JSDollarVM.cpp:
- tools/JSDollarVMPrototype.cpp:
(JSC::JSDollarVMPrototype::isInObjectSpace):
Source/WebCore:
- ForwardingHeaders/heap/HeapInlines.h: Removed.
- ForwardingHeaders/interpreter/Interpreter.h: Added.
- ForwardingHeaders/runtime/AuxiliaryBarrierInlines.h: Removed.
- Modules/indexeddb/IDBCursorWithValue.cpp:
- Modules/indexeddb/client/TransactionOperation.cpp:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
- bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp:
- bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp:
- bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp:
- bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp:
- bindings/js/JSClientRectCustom.cpp:
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDeviceMotionEventCustom.cpp:
- bindings/js/JSDeviceOrientationEventCustom.cpp:
- bindings/js/JSErrorEventCustom.cpp:
- bindings/js/JSIDBCursorWithValueCustom.cpp:
- bindings/js/JSIDBIndexCustom.cpp:
- bindings/js/JSPopStateEventCustom.cpp:
- bindings/js/JSWebGL2RenderingContextCustom.cpp:
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
- bindings/js/WorkerScriptController.cpp:
- contentextensions/ContentExtensionParser.cpp:
- dom/ErrorEvent.cpp:
- html/HTMLCanvasElement.cpp:
- html/MediaDocument.cpp:
- inspector/CommandLineAPIModule.cpp:
- loader/EmptyClients.cpp:
- page/CaptionUserPreferences.cpp:
- page/Frame.cpp:
- page/PageGroup.cpp:
- page/UserContentController.cpp:
- platform/mock/mediasource/MockBox.cpp:
- testing/GCObservation.cpp:
Source/WebKit2:
- UIProcess/ViewGestureController.cpp:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebProcessPool.cpp:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::tryFastAlignedMalloc): Deleted.
- wtf/FastMalloc.h:
- wtf/ParkingLot.cpp:
(WTF::ParkingLot::forEach):
(WTF::ParkingLot::forEachImpl): Deleted.
- wtf/ParkingLot.h:
(WTF::ParkingLot::parkConditionally):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::forEach): Deleted.
- wtf/ScopedLambda.h:
(WTF::scopedLambdaRef): Deleted.
Tools:
- DumpRenderTree/TestRunner.cpp:
- DumpRenderTree/mac/DumpRenderTree.mm:
(DumpRenderTreeMain):
- Scripts/run-jsc-stress-tests:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
LayoutTests:
- 11:53 AM Changeset in webkit [204911] by
-
- 2 edits in trunk/Source/WebKit2
In some cases, an IPC::Connection won't know when the other end has gone away
https://bugs.webkit.org/show_bug.cgi?id=161153
rdar://problem/27896368
Reviewed by Dan Bernstein.
When being asked to invalidate a connection that isn't yet connected, make sure to release
our send and receive rights so that the other end will get a failure when trying to connect.
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::platformInvalidate):
- 11:44 AM Changeset in webkit [204910] by
-
- 2 edits in trunk/Tools
Try to fix Production builds.
PRODUCTION_FRAMEWORKS_DIR was undefined here.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- 11:35 AM Changeset in webkit [204909] by
-
- 5 edits1 add in trunk
Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
https://bugs.webkit.org/show_bug.cgi?id=161152
Reviewed by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCreateFrameHandle): Added. Creates a handle with the frame’s frameID.
- UIProcess/API/C/WKFrame.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
- 11:33 AM Changeset in webkit [204908] by
-
- 5 edits2 adds in trunk
ASSERTION FAILED: childrenInline() in WebCore::RenderBlockFlow::hasLines
https://bugs.webkit.org/show_bug.cgi?id=139396
<rdar://problem/27704339>
Reviewed by David Hyatt.
Source/WebCore:
RenderBlockFlow::hasLines() should be able to handle the block-children case.
Test: fast/ruby/assert-with-block-rt-child-and-emphasis.html
- rendering/RenderBlock.h:
(WebCore::RenderBlock::hasLines): Deleted.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::hasLines):
- rendering/RenderBlockFlow.h:
LayoutTests:
- fast/ruby/assert-with-block-rt-child-and-emphasis-expected.txt: Added.
- fast/ruby/assert-with-block-rt-child-and-emphasis.html: Added.
- 11:33 AM Changeset in webkit [204907] by
-
- 2 edits in trunk/LayoutTests
[Win] http server is not starting.
https://bugs.webkit.org/show_bug.cgi?id=161134
Reviewed by Alexey Proskuryakov.
Avoid setting the php ini folder twice, it is not allowed by xampp.
- http/conf/apache2.4-httpd-win.conf:
- 11:12 AM Changeset in webkit [204906] by
-
- 4 edits2 adds in trunk
AX: Add test for line text marker range on iOS
https://bugs.webkit.org/show_bug.cgi?id=161108
<rdar://problem/27976405>
Reviewed by Chris Fleizach.
Tools:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::textMarkerRangeForElement):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
LayoutTests:
Added a new test to test line text marker ranges on iOS.
- accessibility/ios-simulator/text-marker-range-for-line-expected.txt: Added.
- accessibility/ios-simulator/text-marker-range-for-line.html: Added.
- 10:54 AM Changeset in webkit [204905] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Can’t "po" WKObject instances
https://bugs.webkit.org/show_bug.cgi?id=161151
Reviewed by Anders Carlsson.
- Shared/Cocoa/WKObject.mm:
(-[WKObject debugDescription]): Implement and forward to the target or print a generic
description.
- 10:35 AM Changeset in webkit [204904] by
-
- 2 edits in trunk/LayoutTests
Changing gamepad test to try to get more info about the failure mode on the bots.
Unreviewed.
- gamepad/gamepad-timestamp.html:
- 10:15 AM Changeset in webkit [204903] by
-
- 1 edit6 adds in trunk/LayoutTests
Add ios-simulator baseline for newly imported test.
https://bugs.webkit.org/show_bug.cgi?id=161143
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt: Added.
- 10:06 AM Changeset in webkit [204902] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, temporarily mark imported/w3c/web-platform-tests/html/dom/interfaces.html as flaky.
- 9:55 AM Changeset in webkit [204901] by
-
- 5 edits in trunk
js/regress/put-by-id-transition-with-indexing-header.html and svg/carto.net/window.svg fail in debug after r204854
https://bugs.webkit.org/show_bug.cgi?id=161115
Reviewed by Keith Miller.
Source/JavaScriptCore:
There were two small goofs.
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::isNull): The new policy is that the allocator can be null. So now the way you tell if the profile is null is by checking the structure.
- jit/JITOperations.cpp: This was using DeferGC, which is now definitely wrong. It forces the GC to happen when the structure and butterfly are mismatched. It's better for the GC to happen before we put the butterfly in the object.
LayoutTests:
- 9:47 AM Changeset in webkit [204900] by
-
- 2 edits in trunk/LayoutTests
Gardening: restoring 2 test expectations removed in r204870 by mistake.
https://bugs.webkit.org/show_bug.cgi?id=161096
Not reviewed.
- 9:40 AM Changeset in webkit [204899] by
-
- 2 edits in trunk/LayoutTests
Temporarily skip inspector/codemirror tests on mac-wk1 debug.
https://bugs.webkit.org/show_bug.cgi?id=161117
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 9:26 AM Changeset in webkit [204898] by
-
- 2 edits in trunk
Add svn:global-ignores to the root to ignore *.pyc files everythere in the repository.
- .: Added property svn:global-ignores.
- 9:23 AM Changeset in webkit [204897] by
-
- 2 edits in trunk/Source/JavaScriptCore
AssemblyHelpers::emitAllocateWithNonNullAllocator() crashes in the FTL on ARM64
https://bugs.webkit.org/show_bug.cgi?id=161138
rdar://problem/27985868
Reviewed by Saam Barati.
The FTL expects that this method can be used with scratch registers disallowed, but it
uses addPtr(Addr, Reg).
The solution is to only use addPtr(Addr, Reg) on x86.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):
- 9:22 AM Changeset in webkit [204896] by
-
- 11 edits2 adds in trunk
Get timestamps and ids working in WK2 gamepads (and test them!)
https://bugs.webkit.org/show_bug.cgi?id=161112
Reviewed by Alex Christensen.
Source/WebKit2:
- Shared/Gamepad/GamepadData.cpp:
(WebKit::GamepadData::GamepadData):
(WebKit::GamepadData::encode):
(WebKit::GamepadData::decode):
- Shared/Gamepad/GamepadData.h:
(WebKit::GamepadData::id):
(WebKit::GamepadData::index): Deleted.
- UIProcess/Gamepad/UIGamepad.cpp:
(WebKit::UIGamepad::UIGamepad):
(WebKit::UIGamepad::condensedGamepadData):
(WebKit::UIGamepad::fullGamepadData): Include the ID for initial WebGamepad creation.
(WebKit::UIGamepad::gamepadData): Deleted.
- UIProcess/Gamepad/UIGamepad.h:
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::snapshotGamepads):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::gamepadConnected):
(WebKit::WebProcessPool::setInitialConnectedGamepads):
- WebProcess/Gamepad/WebGamepad.cpp:
(WebKit::WebGamepad::WebGamepad):
(WebKit::WebGamepad::updateValues):
LayoutTests:
- gamepad/gamepad-polling-access-expected.txt:
- gamepad/gamepad-polling-access.html:
- gamepad/gamepad-timestamp-expected.txt: Added.
- gamepad/gamepad-timestamp.html: Added.
- 6:35 AM Changeset in webkit [204895] by
-
- 9 edits in trunk
2016] Allow assignment in for-in head in not-strict mode
https://bugs.webkit.org/show_bug.cgi?id=160955
Reviewed by Saam Barati.
This patch allow make assignment in for..in head in not-strict mode,
according to the spec https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads
Source/JavaScriptCore:
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitLoopHeader):
(JSC::ForInNode::emitMultiLoopBytecode):
- parser/Nodes.h:
(JSC::ExpressionNode::isAssignResolveNode):
(JSC::AssignResolveNode::identifier):
(JSC::ExpressionNode::isResolveNode): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseForStatement):
JSTests:
- stress/for-in-tests.js:
(foo):
(boo):
(catch):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 3:42 AM Changeset in webkit [204894] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r204624 and r204648.
prefix, namespaceURI and localName attributes were moved from Node to Attr/Element in r204624 and prefix was
also made readonly in r204648.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_node_get_namespace_uri):
(webkit_dom_node_get_prefix):
(webkit_dom_node_set_prefix):
(webkit_dom_node_get_local_name):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/webkitdom.symbols:
- 2:29 AM Changeset in webkit [204893] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Fix test_ewk2_view
https://bugs.webkit.org/show_bug.cgi?id=161131
Reviewed by Gyuyoung Kim.
ewk_view_title_changed: null is treated as the string "null" after r203487.
ewk_view_page_contents_get: aligned encoding labels after r204605.
- UIProcess/API/efl/tests/resources/resultMHTML.mht:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 1:59 AM Changeset in webkit [204892] by
-
- 4 edits in trunk/Tools
[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161079
Reviewed by Brent Fulgham.
- MiniBrowser/win/WebDownloadDelegate.cpp:
- MiniBrowser/win/WinMain.cpp:
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
- 1:07 AM Changeset in webkit [204891] by
-
- 6 edits2 adds in trunk/LayoutTests
[Fetch API] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=161128
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-24
- TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt: Added.
- platform/mac-wk2/TestExpectations:
- platform/win/TestExpectations:
- 12:55 AM Changeset in webkit [204890] by
-
- 1 copy in releases/WebKitGTK/webkit-2.12.4
WebKitGTK+ 2.12.4
- 12:52 AM Changeset in webkit [204889] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.12.4 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.12.4.
Aug 23, 2016:
- 11:38 PM Changeset in webkit [204888] by
-
- 6 edits3 adds in branches/safari-602-branch
Merge r204521. rdar://problem/27075526
- 11:38 PM Changeset in webkit [204887] by
-
- 4 edits in branches/safari-602-branch/Source/WebCore
Merge r204610. rdar://problem/27750446
- 11:15 PM Changeset in webkit [204886] by
-
- 7 edits in trunk/Source
Add some logging for WKSelectionDrawingInfo
https://bugs.webkit.org/show_bug.cgi?id=161055
Reviewed by Tim Horton.
Source/WebCore:
Add TextStream dumping for SelectionRect.
- platform/ios/SelectionRect.cpp:
(WebCore::operator<<):
- platform/ios/SelectionRect.h:
Source/WebKit2:
Add a Selection logging channel for WK2, and dump WKSelectionDrawingInfo when it changes.
- Platform/Logging.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(WebKit::operator<<):
(-[WKContentView _updateChangedSelection:]):
- 10:56 PM Changeset in webkit [204885] by
-
- 42 edits in trunk/Source/WebCore
More consistent header inclusions in the MathML module
https://bugs.webkit.org/show_bug.cgi?id=161080
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-23
Reviewed by Darin Adler.
We adjust header inclusion in the MathML module so that:
- implementation file's own header is outside the #if ENABLE(MATHML)
- There is always a blank line after the #if ENABLE(MATHML)
No new tests, behavior is unchanged.
- mathml/MathMLAnnotationElement.cpp:
- mathml/MathMLAnnotationElement.h:
- mathml/MathMLElement.cpp:
- mathml/MathMLFractionElement.cpp:
- mathml/MathMLFractionElement.h:
- mathml/MathMLMathElement.cpp:
- mathml/MathMLMathElement.h:
- mathml/MathMLMencloseElement.cpp:
- mathml/MathMLMencloseElement.h:
- mathml/MathMLOperatorDictionary.cpp:
- mathml/MathMLOperatorElement.cpp:
- mathml/MathMLOperatorElement.h:
- mathml/MathMLPaddedElement.cpp:
- mathml/MathMLPaddedElement.h:
- mathml/MathMLPresentationElement.cpp:
- mathml/MathMLPresentationElement.h:
- mathml/MathMLRowElement.cpp:
- mathml/MathMLRowElement.h:
- mathml/MathMLScriptsElement.cpp:
- mathml/MathMLScriptsElement.h:
- mathml/MathMLSelectElement.h:
- mathml/MathMLSpaceElement.cpp:
- mathml/MathMLSpaceElement.h:
- mathml/MathMLTokenElement.cpp:
- mathml/MathMLUnderOverElement.cpp:
- mathml/MathMLUnderOverElement.h:
- rendering/mathml/MathMLStyle.cpp:
- rendering/mathml/MathOperator.cpp:
- rendering/mathml/MathOperator.h:
- rendering/mathml/RenderMathMLBlock.cpp:
- rendering/mathml/RenderMathMLFenced.cpp:
- rendering/mathml/RenderMathMLFencedOperator.cpp:
- rendering/mathml/RenderMathMLFraction.cpp:
- rendering/mathml/RenderMathMLMath.cpp:
- rendering/mathml/RenderMathMLMenclose.cpp:
- rendering/mathml/RenderMathMLMenclose.h:
- rendering/mathml/RenderMathMLOperator.cpp:
- rendering/mathml/RenderMathMLRoot.cpp:
- rendering/mathml/RenderMathMLRow.cpp:
- rendering/mathml/RenderMathMLScripts.cpp:
- rendering/mathml/RenderMathMLUnderOver.cpp:
- 9:57 PM Changeset in webkit [204884] by
-
- 2 edits in trunk/Tools
Fix Windows DRT build.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::mainFrameJSContext):
- 9:03 PM Changeset in webkit [204883] by
-
- 2 edits in trunk/Tools
Try to fix Windows build.
Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
so that perl finds CodeGeneratorDumpRenderTree.pm.
- DumpRenderTree/CMakeLists.txt:
- 8:39 PM Changeset in webkit [204882] by
-
- 14 edits1 add in trunk
It should be easy to run ES6SampleBench from the jsc shell
https://bugs.webkit.org/show_bug.cgi?id=161085
Reviewed by Yusuke Suzuki.
PerformanceTests:
This patch makes ES6 sample bench runnable through the
jscshell.
To do that, you need to be in the PerformanceTests/ES6SampleBench
directory and runjsc cli.js. To make this work, the benchmark
is now aware of being run in two modes: via the browser, and via
the shell. Each entry point will set a variableisInBrowser,
and the benchmark will do different things based on if that
variable is true or false.
- ES6SampleBench/Air/benchmark.js:
- ES6SampleBench/Air/stress-test.js:
- ES6SampleBench/Basic/benchmark.js:
(runBenchmark):
- ES6SampleBench/Basic/stress-test.js:
- ES6SampleBench/air_benchmark.js:
- ES6SampleBench/basic_benchmark.js:
- ES6SampleBench/cli.js: Added.
(return.doRun):
(makeBenchmarkRunner):
- ES6SampleBench/driver.js:
(Driver):
(Driver.prototype._recomputeSummary):
(Driver.prototype._iterate.window.setTimeout):
(Driver.prototype._iterate):
(Driver.prototype._updateIterations):
- ES6SampleBench/glue.js:
(reportResult):
- ES6SampleBench/index.html:
- ES6SampleBench/results.js:
(Results):
(Results.prototype.reportRunning):
(Results.prototype.reportDone):
(Results.prototype.reportError):
- ES6SampleBench/stats.js:
(Stats):
(Stats.prototype.toString):
(Stats.prototype._update):
Source/JavaScriptCore:
This patch adds a new function called
runStringto the shell.
It takes in a string, and executes it in a new global object.
Then, it returns the global object it executed the code in.
This allows the code to stash some kind of a result on the global,
and then have the caller ofrunStringextract the result.
- jsc.cpp:
(GlobalObject::finishCreation):
(functionRunString):
- 7:36 PM Changeset in webkit [204881] by
-
- 10 edits1 add in trunk
[JSC] Make ArithLog works with any type
https://bugs.webkit.org/show_bug.cgi?id=161110
Reviewed by Geoffrey Garen.
JSTests:
- stress/arith-log-on-various-types.js: Added.
Source/JavaScriptCore:
Same old: if the type is not a number, assume the worst in every
phase and generate a fallback function call.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithLog):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithLog):
- 7:23 PM Changeset in webkit [204880] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: !view().layoutStateEnabled() style().styleType() == FIRST_LETTER in WebCore::RenderInline::clippedOverflowRectForRepaint https://bugs.webkit.org/show_bug.cgi?id=155363
<rdar://problem/27720434>
Reviewed by David Hyatt.
Source/WebCore:
Loosen ASSERT to include calls when the inline has a self painting layer. It's valid to end up here during layout when
the layer's composite state changes.
Test: fast/layers/assert-on-self-painting-inline-with-scrolling.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
LayoutTests:
- fast/layers/assert-on-self-painting-inline-with-scrolling-expected.txt: Added.
- fast/layers/assert-on-self-painting-inline-with-scrolling.html: Added.
- 7:19 PM Changeset in webkit [204879] by
-
- 4 edits in trunk/Source/WebCore
Create a phony WebKitLegacy framework that the WebCoreTestSupport dylib can find
https://bugs.webkit.org/show_bug.cgi?id=161123
Reviewed by Dan Bernstein.
- Configurations/WebCore.xcconfig:
Use the WebKitLegacy.tbd file from the phony framework.
- Configurations/WebCoreTestSupport.xcconfig:
Look for WebKitLegacy.framework in the phony framework path.
- WebCore.xcodeproj/project.pbxproj:
Add a new phase that creates a phony WebKitLegacy framework.
- 7:13 PM Changeset in webkit [204878] by
-
- 8 edits8 adds in trunk
Add support for CanvasRenderingContext2D.resetTransform()
https://bugs.webkit.org/show_bug.cgi?id=161089
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001-expected.html: Added.
- web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001.html: Added.
Import W3C test to cover CanvasRenderingContext2D.resetTransform().
- web-platform-tests/html/dom/interfaces-expected.txt:
Rebaseline existing test now that more checks are passing.
Source/WebCore:
Add support for CanvasRenderingContext2D.resetTransform():
Firefox and Chrome already support this.
Tests:
imported/blink/fast/canvas/canvas-resetTransform.html
imported/w3c/web-platform-tests/2dcontext/transformations/canvas_transformations_reset_001.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::resetTransform):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
Import corresponding Blink test.
- imported/blink/fast/canvas/canvas-resetTransform-expected.txt: Added.
- imported/blink/fast/canvas/canvas-resetTransform.html: Added.
- imported/blink/fast/canvas/script-tests/canvas-resetTransform.js: Added.
- platform/ios-simulator/TestExpectations:
Skip new Canvas test on iOS as it is failing (very small visual difference).
- 7:03 PM Changeset in webkit [204877] by
-
- 21 edits2 copies8 moves7 adds in trunk
Hook up UIScriptController in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=161064
Reviewed by Sam Weinig.
Tools:
Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
in fast/harness which test this.
Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
WK2-isms. Fix the makefiles to refer to the new location.
Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
by ID and firing them once they are complete.
- DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
- DumpRenderTree/CMakeLists.txt:
- DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestRunner.cpp:
(runUIScriptCallback):
(TestRunner::staticFunctions):
(TestRunner::cacheTestRunnerCallback):
(TestRunner::callTestRunnerCallback):
(TestRunner::clearTestRunnerCallbacks):
(nextUIScriptCallbackID):
(TestRunner::runUIScript):
(TestRunner::callUIScriptCallback):
(TestRunner::uiScriptDidComplete):
(TestRunner::cleanup):
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
- DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
- DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::mainFrameJSContext):
- DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
(WTR::UIScriptController::doAsyncTask):
- DumpRenderTree/win/DumpRenderTree.cpp:
- TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
(WTR::JSWrappable::~JSWrappable):
(WTR::JSValueMakeStringOrNull):
- TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
(WTR::JSWrapper::wrap):
(WTR::JSWrapper::unwrap):
(WTR::unwrapObject):
(WTR::JSWrapper::initialize):
(WTR::JSWrapper::finalize):
- TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
(WTR::toJS):
(WTR::setProperty):
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
- TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
- TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
(WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
- TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
- TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/DerivedSources.make:
- WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
(WTR::JSWrappable::~JSWrappable): Deleted.
(WTR::JSValueMakeStringOrNull): Deleted.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
(WTR::JSWrapper::wrap): Deleted.
(WTR::JSWrapper::unwrap): Deleted.
(WTR::unwrapObject): Deleted.
(WTR::JSWrapper::initialize): Deleted.
(WTR::JSWrapper::finalize): Deleted.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
(WTR::toJS): Deleted.
(WTR::setProperty): Deleted.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::runUISideScript):
(WTR::TestInvocation::uiScriptDidComplete):
- WebKitTestRunner/TestInvocation.h:
- WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
- WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
- WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/config.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::contentVisibleRect):
LayoutTests:
fast/harness/ui-side-scripts.html and fast/harness/concurrent-ui-side-scripts.html
pass in DumpRenderTree now.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 7:00 PM Changeset in webkit [204876] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/canvas-alphaImageData-behavior.html doesn't appear to be flakey any
more. Removing the "Fail" marker for macOS Sierra.
<rdar://problem/22950905>
- platform/mac/TestExpectations:
- 6:57 PM Changeset in webkit [204875] by
-
- 4 edits in trunk/LayoutTests
iOS layout test gardening in fast/events
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 6:57 PM Changeset in webkit [204874] by
-
- 2 edits in trunk/LayoutTests
Fix a formatting error in TestExpectations.
- platform/ios-simulator-wk1/TestExpectations:
- 6:01 PM Changeset in webkit [204873] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update expectations of iOS simulator WK1 editing tests
- platform/ios-simulator-wk1/TestExpectations:
- 5:30 PM Changeset in webkit [204872] by
-
- 9 edits4 adds in trunk
REGRESSION: SVG clip-path doesn't work on root <svg>
https://bugs.webkit.org/show_bug.cgi?id=129180
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-23
Reviewed by Tim Horton.
Source/WebCore:
Build the resources cache for the RenderSVGRoot element when it's been
inserted in the render tree. Remove the resources cache before removing
the RenderSVGRoot from the render tree. No worries for the child <svg>
elements since their renderers are of type RenderSVGViewportContainer.
Tests: svg/clip-path/clip-path-on-svg-003.svg
svg/clip-path/clip-path-on-svg-004.svg
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::insertedIntoTree):
(WebCore::RenderSVGRoot::willBeRemovedFromTree):
- rendering/svg/RenderSVGRoot.h:
These changes are very similar to what we do for adding and removing the
child SVG elements in RenderSVGRoot::addChild() and removeChild().
LayoutTests:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- svg/clip-path/clip-path-on-svg-003-expected.svg: Added.
- svg/clip-path/clip-path-on-svg-003.svg: Added.
- svg/clip-path/clip-path-on-svg-004-expected.svg: Added.
- svg/clip-path/clip-path-on-svg-004.svg: Added.
- 5:24 PM Changeset in webkit [204871] by
-
- 16 edits2 adds in trunk
HTMLAreaElement should have a stringifier
https://bugs.webkit.org/show_bug.cgi?id=161105
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that all checks are passing.
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-stringifier-expected.txt:
Source/WebCore:
HTMLAreaElement should have a stringifier:
- https://html.spec.whatwg.org/multipage/embedded-content.html#htmlareaelement
- https://html.spec.whatwg.org/multipage/semantics.html#htmlhyperlinkelementutils
- http://heycam.github.io/webidl/#idl-stringifiers
- http://heycam.github.io/webidl/#es-stringifier
Chrome and Firefox already support this.
This patch does the following:
- Add support for stringifier on attributes to our bindings generator.
- Add stringifier to the HTMLHyperlinkElementUtils.href attribute as per the specification
- Drops the explicit toString on HTMLAnchorElement as HTMLAnchorElement implements HTMLHyperlinkElementUtils.
Test: fast/dom/toString_attributes.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateInterface):
(AddStringifierOperationIfNeeded):
- bindings/scripts/IDLParser.pm:
(parseAttributeOrOperationOrIterator):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::toString): Deleted.
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
- html/HTMLHyperlinkElementUtils.idl:
LayoutTests:
Add layout test coverage to check that HTMLAreaElement.prototype.toString
and HTMLAnchorElement.prototype.toString have the right attributes:
- fast/dom/toString_attributes-expected.txt: Added.
- fast/dom/toString_attributes.html: Added.
- js/dom/toString-dontEnum-expected.txt:
- js/dom/toString-dontEnum.html:
- 4:39 PM Changeset in webkit [204870] by
-
- 6 edits1 copy1 delete in trunk
JSC should have a "microbenchmarks" directory instead of "regress" directory
https://bugs.webkit.org/show_bug.cgi?id=161096
Rubber stamped by Mark Lam.
JSTests:
- microbenchmarks: Copied from LayoutTests/js/regress/script-tests.
Tools:
This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
directory and removes all the related html and txt files. I did this because
that directory was only there for microbenchmarks, and not for "regression"
tests. I also changed the various scripts to point to it.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- Scripts/run-jsc-benchmarks:
LayoutTests:
- TestExpectations:
- js/regress: Removed.
- js/regress/ArrayBuffer-DataView-alloc-large-long-lived-expected.txt: Removed.
- js/regress/ArrayBuffer-DataView-alloc-large-long-lived.html: Removed.
- js/regress/ArrayBuffer-DataView-alloc-long-lived-expected.txt: Removed.
- js/regress/ArrayBuffer-DataView-alloc-long-lived.html: Removed.
- js/regress/ArrayBuffer-Int32Array-byteOffset-expected.txt: Removed.
- js/regress/ArrayBuffer-Int32Array-byteOffset.html: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-expected.txt: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived-expected.txt: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-large-long-lived.html: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-long-lived-buffer-expected.txt: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-long-lived-buffer.html: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-long-lived-expected.txt: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc-long-lived.html: Removed.
- js/regress/ArrayBuffer-Int8Array-alloc.html: Removed.
- js/regress/DataView-custom-properties-expected.txt: Removed.
- js/regress/DataView-custom-properties.html: Removed.
- js/regress/Float32Array-matrix-mult-expected.txt: Removed.
- js/regress/Float32Array-matrix-mult.html: Removed.
- js/regress/Float32Array-to-Float64Array-set-expected.txt: Removed.
- js/regress/Float32Array-to-Float64Array-set.html: Removed.
- js/regress/Float64Array-alloc-long-lived-expected.txt: Removed.
- js/regress/Float64Array-alloc-long-lived.html: Removed.
- js/regress/Float64Array-to-Int16Array-set-expected.txt: Removed.
- js/regress/Float64Array-to-Int16Array-set.html: Removed.
- js/regress/HashMap-put-get-iterate-expected.txt: Removed.
- js/regress/HashMap-put-get-iterate-keys-expected.txt: Removed.
- js/regress/HashMap-put-get-iterate-keys.html: Removed.
- js/regress/HashMap-put-get-iterate.html: Removed.
- js/regress/HashMap-string-put-get-iterate-expected.txt: Removed.
- js/regress/HashMap-string-put-get-iterate.html: Removed.
- js/regress/Int16Array-alloc-long-lived-expected.txt: Removed.
- js/regress/Int16Array-alloc-long-lived.html: Removed.
- js/regress/Int16Array-bubble-sort-expected.txt: Removed.
- js/regress/Int16Array-bubble-sort-with-byteLength-expected.txt: Removed.
- js/regress/Int16Array-bubble-sort-with-byteLength.html: Removed.
- js/regress/Int16Array-bubble-sort.html: Removed.
- js/regress/Int16Array-load-int-mul-expected.txt: Removed.
- js/regress/Int16Array-load-int-mul.html: Removed.
- js/regress/Int16Array-to-Int32Array-set-expected.txt: Removed.
- js/regress/Int16Array-to-Int32Array-set.html: Removed.
- js/regress/Int32Array-Int8Array-view-alloc-expected.txt: Removed.
- js/regress/Int32Array-Int8Array-view-alloc.html: Removed.
- js/regress/Int32Array-alloc-expected.txt: Removed.
- js/regress/Int32Array-alloc-large-expected.txt: Removed.
- js/regress/Int32Array-alloc-large.html: Removed.
- js/regress/Int32Array-alloc-long-lived-expected.txt: Removed.
- js/regress/Int32Array-alloc-long-lived.html: Removed.
- js/regress/Int32Array-alloc.html: Removed.
- js/regress/Int8Array-alloc-long-lived-expected.txt: Removed.
- js/regress/Int8Array-alloc-long-lived.html: Removed.
- js/regress/Int8Array-load-expected.txt: Removed.
- js/regress/Int8Array-load-with-byteLength-expected.txt: Removed.
- js/regress/Int8Array-load-with-byteLength.html: Removed.
- js/regress/Int8Array-load.html: Removed.
- js/regress/JSONP-negative-0-expected.txt: Removed.
- js/regress/JSONP-negative-0.html: Removed.
- js/regress/Number-isNaN-expected.txt: Removed.
- js/regress/Number-isNaN.html: Removed.
- js/regress/abc-forward-loop-equal-expected.txt: Removed.
- js/regress/abc-forward-loop-equal.html: Removed.
- js/regress/abc-postfix-backward-loop-expected.txt: Removed.
- js/regress/abc-postfix-backward-loop.html: Removed.
- js/regress/abc-simple-backward-loop-expected.txt: Removed.
- js/regress/abc-simple-backward-loop.html: Removed.
- js/regress/abc-simple-forward-loop-expected.txt: Removed.
- js/regress/abc-simple-forward-loop.html: Removed.
- js/regress/abc-skippy-loop-expected.txt: Removed.
- js/regress/abc-skippy-loop.html: Removed.
- js/regress/abs-boolean-expected.txt: Removed.
- js/regress/abs-boolean.html: Removed.
- js/regress/adapt-to-double-divide-expected.txt: Removed.
- js/regress/adapt-to-double-divide.html: Removed.
- js/regress/aliased-arguments-getbyval-expected.txt: Removed.
- js/regress/aliased-arguments-getbyval.html: Removed.
- js/regress/allocate-big-object-expected.txt: Removed.
- js/regress/allocate-big-object.html: Removed.
- js/regress/apply-not-apply-expected.txt: Removed.
- js/regress/apply-not-apply.html: Removed.
- js/regress/arguments-expected.txt: Removed.
- js/regress/arguments-named-and-reflective-expected.txt: Removed.
- js/regress/arguments-named-and-reflective.html: Removed.
- js/regress/arguments-out-of-bounds-expected.txt: Removed.
- js/regress/arguments-out-of-bounds.html: Removed.
- js/regress/arguments-strict-mode-expected.txt: Removed.
- js/regress/arguments-strict-mode.html: Removed.
- js/regress/arguments.html: Removed.
- js/regress/arity-mismatch-inlining-expected.txt: Removed.
- js/regress/arity-mismatch-inlining.html: Removed.
- js/regress/array-access-polymorphic-structure-expected.txt: Removed.
- js/regress/array-access-polymorphic-structure.html: Removed.
- js/regress/array-nonarray-polymorhpic-access-expected.txt: Removed.
- js/regress/array-nonarray-polymorhpic-access.html: Removed.
- js/regress/array-nonarray-polymorphic-access-expected.txt: Removed.
- js/regress/array-nonarray-polymorphic-access.html: Removed.
- js/regress/array-prototype-every-expected.txt: Removed.
- js/regress/array-prototype-every.html: Removed.
- js/regress/array-prototype-forEach-expected.txt: Removed.
- js/regress/array-prototype-forEach.html: Removed.
- js/regress/array-prototype-map-expected.txt: Removed.
- js/regress/array-prototype-map.html: Removed.
- js/regress/array-prototype-reduce-expected.txt: Removed.
- js/regress/array-prototype-reduce.html: Removed.
- js/regress/array-prototype-reduceRight-expected.txt: Removed.
- js/regress/array-prototype-reduceRight.html: Removed.
- js/regress/array-prototype-some-expected.txt: Removed.
- js/regress/array-prototype-some.html: Removed.
- js/regress/array-splice-contiguous-expected.txt: Removed.
- js/regress/array-splice-contiguous.html: Removed.
- js/regress/array-with-double-add-expected.txt: Removed.
- js/regress/array-with-double-add.html: Removed.
- js/regress/array-with-double-increment-expected.txt: Removed.
- js/regress/array-with-double-increment.html: Removed.
- js/regress/array-with-double-mul-add-expected.txt: Removed.
- js/regress/array-with-double-mul-add.html: Removed.
- js/regress/array-with-double-sum-expected.txt: Removed.
- js/regress/array-with-double-sum.html: Removed.
- js/regress/array-with-int32-add-sub-expected.txt: Removed.
- js/regress/array-with-int32-add-sub.html: Removed.
- js/regress/array-with-int32-or-double-sum-expected.txt: Removed.
- js/regress/array-with-int32-or-double-sum.html: Removed.
- js/regress/arrowfunction-call-expected.txt: Removed.
- js/regress/arrowfunction-call-in-class-constructor-expected.txt: Removed.
- js/regress/arrowfunction-call-in-class-constructor.html: Removed.
- js/regress/arrowfunction-call-in-class-method-expected.txt: Removed.
- js/regress/arrowfunction-call-in-class-method.html: Removed.
- js/regress/arrowfunction-call-in-function-expected.txt: Removed.
- js/regress/arrowfunction-call-in-function.html: Removed.
- js/regress/arrowfunction-call.html: Removed.
- js/regress/asmjs_bool_bug-expected.txt: Removed.
- js/regress/asmjs_bool_bug.html: Removed.
- js/regress/assign-custom-setter-expected.txt: Removed.
- js/regress/assign-custom-setter-polymorphic-expected.txt: Removed.
- js/regress/assign-custom-setter-polymorphic.html: Removed.
- js/regress/assign-custom-setter.html: Removed.
- js/regress/basic-set-expected.txt: Removed.
- js/regress/basic-set.html: Removed.
- js/regress/big-int-mul-expected.txt: Removed.
- js/regress/big-int-mul.html: Removed.
- js/regress/bigswitch-expected.txt: Removed.
- js/regress/bigswitch-indirect-expected.txt: Removed.
- js/regress/bigswitch-indirect-symbol-expected.txt: Removed.
- js/regress/bigswitch-indirect-symbol-or-undefined-expected.txt: Removed.
- js/regress/bigswitch-indirect-symbol-or-undefined.html: Removed.
- js/regress/bigswitch-indirect-symbol.html: Removed.
- js/regress/bigswitch-indirect.html: Removed.
- js/regress/bigswitch.html: Removed.
- js/regress/boolean-test-expected.txt: Removed.
- js/regress/boolean-test.html: Removed.
- js/regress/bound-function-call-expected.txt: Removed.
- js/regress/bound-function-call.html: Removed.
- js/regress/bound-function-construction-performance-expected.txt: Removed.
- js/regress/bound-function-construction-performance.html: Removed.
- js/regress/branch-fold-expected.txt: Removed.
- js/regress/branch-fold.html: Removed.
- js/regress/branch-on-string-as-boolean-expected.txt: Removed.
- js/regress/branch-on-string-as-boolean.html: Removed.
- js/regress/bug-153431-expected.txt: Removed.
- js/regress/bug-153431.html: Removed.
- js/regress/build-large-object-expected.txt: Removed.
- js/regress/build-large-object.html: Removed.
- js/regress/by-val-generic-expected.txt: Removed.
- js/regress/by-val-generic.html: Removed.
- js/regress/call-or-not-call-expected.txt: Removed.
- js/regress/call-or-not-call.html: Removed.
- js/regress/call-spread-apply-expected.txt: Removed.
- js/regress/call-spread-apply.html: Removed.
- js/regress/call-spread-call-expected.txt: Removed.
- js/regress/call-spread-call.html: Removed.
- js/regress/captured-assignments-expected.txt: Removed.
- js/regress/captured-assignments.html: Removed.
- js/regress/cast-int-to-double-expected.txt: Removed.
- js/regress/cast-int-to-double.html: Removed.
- js/regress/cell-argument-expected.txt: Removed.
- js/regress/cell-argument.html: Removed.
- js/regress/cfg-simplify-expected.txt: Removed.
- js/regress/cfg-simplify.html: Removed.
- js/regress/chain-getter-access-expected.txt: Removed.
- js/regress/chain-getter-access.html: Removed.
- js/regress/cmpeq-obj-to-obj-other-expected.txt: Removed.
- js/regress/cmpeq-obj-to-obj-other.html: Removed.
- js/regress/concat-append-one-expected.txt: Removed.
- js/regress/concat-append-one.html: Removed.
- js/regress/constant-test-expected.txt: Removed.
- js/regress/constant-test.html: Removed.
- js/regress/create-lots-of-functions-expected.txt: Removed.
- js/regress/create-lots-of-functions.html: Removed.
- js/regress/cse-new-array-buffer-expected.txt: Removed.
- js/regress/cse-new-array-buffer.html: Removed.
- js/regress/cse-new-array-expected.txt: Removed.
- js/regress/cse-new-array.html: Removed.
- js/regress/custom-setter-getter-as-put-get-by-id-expected.txt: Removed.
- js/regress/custom-setter-getter-as-put-get-by-id.html: Removed.
- js/regress/delay-tear-off-arguments-strictmode-expected.txt: Removed.
- js/regress/delay-tear-off-arguments-strictmode.html: Removed.
- js/regress/deltablue-for-of-expected.txt: Removed.
- js/regress/deltablue-for-of.html: Removed.
- js/regress/deltablue-varargs-expected.txt: Removed.
- js/regress/deltablue-varargs.html: Removed.
- js/regress/destructuring-arguments-expected.txt: Removed.
- js/regress/destructuring-arguments.html: Removed.
- js/regress/destructuring-parameters-overridden-by-function-expected.txt: Removed.
- js/regress/destructuring-parameters-overridden-by-function.html: Removed.
- js/regress/destructuring-swap-expected.txt: Removed.
- js/regress/destructuring-swap.html: Removed.
- js/regress/direct-arguments-getbyval-expected.txt: Removed.
- js/regress/direct-arguments-getbyval.html: Removed.
- js/regress/direct-arguments-length-expected.txt: Removed.
- js/regress/direct-arguments-length.html: Removed.
- js/regress/direct-arguments-overridden-length-expected.txt: Removed.
- js/regress/direct-arguments-overridden-length.html: Removed.
- js/regress/direct-arguments-possibly-overridden-length-expected.txt: Removed.
- js/regress/direct-arguments-possibly-overridden-length.html: Removed.
- js/regress/div-boolean-double-expected.txt: Removed.
- js/regress/div-boolean-double.html: Removed.
- js/regress/div-boolean-expected.txt: Removed.
- js/regress/div-boolean.html: Removed.
- js/regress/double-get-by-val-out-of-bounds-expected.txt: Removed.
- js/regress/double-get-by-val-out-of-bounds.html: Removed.
- js/regress/double-pollution-getbyval-expected.txt: Removed.
- js/regress/double-pollution-getbyval.html: Removed.
- js/regress/double-pollution-putbyoffset-expected.txt: Removed.
- js/regress/double-pollution-putbyoffset.html: Removed.
- js/regress/double-real-use-expected.txt: Removed.
- js/regress/double-real-use.html: Removed.
- js/regress/double-to-int32-typed-array-expected.txt: Removed.
- js/regress/double-to-int32-typed-array-no-inline-expected.txt: Removed.
- js/regress/double-to-int32-typed-array-no-inline.html: Removed.
- js/regress/double-to-int32-typed-array.html: Removed.
- js/regress/double-to-uint32-typed-array-expected.txt: Removed.
- js/regress/double-to-uint32-typed-array-no-inline-expected.txt: Removed.
- js/regress/double-to-uint32-typed-array-no-inline.html: Removed.
- js/regress/double-to-uint32-typed-array.html: Removed.
- js/regress/elidable-new-object-dag-expected.txt: Removed.
- js/regress/elidable-new-object-dag.html: Removed.
- js/regress/elidable-new-object-roflcopter-expected.txt: Removed.
- js/regress/elidable-new-object-roflcopter.html: Removed.
- js/regress/elidable-new-object-then-call-expected.txt: Removed.
- js/regress/elidable-new-object-then-call.html: Removed.
- js/regress/elidable-new-object-tree-expected.txt: Removed.
- js/regress/elidable-new-object-tree.html: Removed.
- js/regress/empty-string-plus-int-expected.txt: Removed.
- js/regress/empty-string-plus-int.html: Removed.
- js/regress/emscripten-cube2hash-expected.txt: Removed.
- js/regress/emscripten-cube2hash.html: Removed.
- js/regress/eval-compute-expected.txt: Removed.
- js/regress/eval-compute.html: Removed.
- js/regress/eval-not-eval-compute-args-expected.txt: Removed.
- js/regress/eval-not-eval-compute-args.html: Removed.
- js/regress/eval-not-eval-compute-expected.txt: Removed.
- js/regress/eval-not-eval-compute.html: Removed.
- js/regress/exit-length-on-plain-object-expected.txt: Removed.
- js/regress/exit-length-on-plain-object.html: Removed.
- js/regress/external-arguments-getbyval-expected.txt: Removed.
- js/regress/external-arguments-getbyval.html: Removed.
- js/regress/external-arguments-putbyval-expected.txt: Removed.
- js/regress/external-arguments-putbyval.html: Removed.
- js/regress/fixed-typed-array-storage-expected.txt: Removed.
- js/regress/fixed-typed-array-storage-var-index-expected.txt: Removed.
- js/regress/fixed-typed-array-storage-var-index.html: Removed.
- js/regress/fixed-typed-array-storage.html: Removed.
- js/regress/fold-double-to-int-expected.txt: Removed.
- js/regress/fold-double-to-int.html: Removed.
- js/regress/fold-get-by-id-to-multi-get-by-offset-expected.txt: Removed.
- js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int-expected.txt: Removed.
- js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int.html: Removed.
- js/regress/fold-get-by-id-to-multi-get-by-offset.html: Removed.
- js/regress/fold-multi-get-by-offset-to-get-by-offset-expected.txt: Removed.
- js/regress/fold-multi-get-by-offset-to-get-by-offset.html: Removed.
- js/regress/fold-multi-get-by-offset-to-poly-get-by-offset-expected.txt: Removed.
- js/regress/fold-multi-get-by-offset-to-poly-get-by-offset.html: Removed.
- js/regress/fold-multi-put-by-offset-to-poly-put-by-offset-expected.txt: Removed.
- js/regress/fold-multi-put-by-offset-to-poly-put-by-offset.html: Removed.
- js/regress/fold-multi-put-by-offset-to-put-by-offset-expected.txt: Removed.
- js/regress/fold-multi-put-by-offset-to-put-by-offset.html: Removed.
- js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset-expected.txt: Removed.
- js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.html: Removed.
- js/regress/fold-put-by-id-to-multi-put-by-offset-expected.txt: Removed.
- js/regress/fold-put-by-id-to-multi-put-by-offset.html: Removed.
- js/regress/fold-put-by-val-with-string-to-multi-put-by-offset-expected.txt: Removed.
- js/regress/fold-put-by-val-with-string-to-multi-put-by-offset.html: Removed.
- js/regress/fold-put-by-val-with-symbol-to-multi-put-by-offset-expected.txt: Removed.
- js/regress/fold-put-by-val-with-symbol-to-multi-put-by-offset.html: Removed.
- js/regress/fold-put-structure-expected.txt: Removed.
- js/regress/fold-put-structure.html: Removed.
- js/regress/for-of-iterate-array-entries-expected.txt: Removed.
- js/regress/for-of-iterate-array-entries.html: Removed.
- js/regress/for-of-iterate-array-keys-expected.txt: Removed.
- js/regress/for-of-iterate-array-keys.html: Removed.
- js/regress/for-of-iterate-array-values-expected.txt: Removed.
- js/regress/for-of-iterate-array-values.html: Removed.
- js/regress/freeze-and-do-work-expected.txt: Removed.
- js/regress/freeze-and-do-work.html: Removed.
- js/regress/fround-expected.txt: Removed.
- js/regress/fround.html: Removed.
- js/regress/ftl-library-inlining-dataview-expected.txt: Removed.
- js/regress/ftl-library-inlining-dataview.html: Removed.
- js/regress/ftl-library-inlining-expected.txt: Removed.
- js/regress/ftl-library-inlining.html: Removed.
- js/regress/ftl-polymorphic-StringFromCharCode-expected.txt: Removed.
- js/regress/ftl-polymorphic-StringFromCharCode.html: Removed.
- js/regress/ftl-polymorphic-bitand-expected.txt: Removed.
- js/regress/ftl-polymorphic-bitand.html: Removed.
- js/regress/ftl-polymorphic-bitor-expected.txt: Removed.
- js/regress/ftl-polymorphic-bitor.html: Removed.
- js/regress/ftl-polymorphic-bitxor-expected.txt: Removed.
- js/regress/ftl-polymorphic-bitxor.html: Removed.
- js/regress/ftl-polymorphic-div-expected.txt: Removed.
- js/regress/ftl-polymorphic-div.html: Removed.
- js/regress/ftl-polymorphic-lshift-expected.txt: Removed.
- js/regress/ftl-polymorphic-lshift.html: Removed.
- js/regress/ftl-polymorphic-mul-expected.txt: Removed.
- js/regress/ftl-polymorphic-mul.html: Removed.
- js/regress/ftl-polymorphic-rshift-expected.txt: Removed.
- js/regress/ftl-polymorphic-rshift.html: Removed.
- js/regress/ftl-polymorphic-sub-expected.txt: Removed.
- js/regress/ftl-polymorphic-sub.html: Removed.
- js/regress/ftl-polymorphic-urshift-expected.txt: Removed.
- js/regress/ftl-polymorphic-urshift.html: Removed.
- js/regress/function-call-expected.txt: Removed.
- js/regress/function-call.html: Removed.
- js/regress/function-dot-apply-expected.txt: Removed.
- js/regress/function-dot-apply.html: Removed.
- js/regress/function-test-expected.txt: Removed.
- js/regress/function-test.html: Removed.
- js/regress/function-with-eval-expected.txt: Removed.
- js/regress/function-with-eval.html: Removed.
- js/regress/gcse-expected.txt: Removed.
- js/regress/gcse-poly-get-expected.txt: Removed.
- js/regress/gcse-poly-get-less-obvious-expected.txt: Removed.
- js/regress/gcse-poly-get-less-obvious.html: Removed.
- js/regress/gcse-poly-get.html: Removed.
- js/regress/gcse.html: Removed.
- js/regress/generator-create-expected.txt: Removed.
- js/regress/generator-create.html: Removed.
- js/regress/generator-fib-expected.txt: Removed.
- js/regress/generator-fib.html: Removed.
- js/regress/generator-function-create-expected.txt: Removed.
- js/regress/generator-function-create.html: Removed.
- js/regress/generator-sunspider-access-nsieve-expected.txt: Removed.
- js/regress/generator-sunspider-access-nsieve.html: Removed.
- js/regress/generator-with-several-types-expected.txt: Removed.
- js/regress/generator-with-several-types.html: Removed.
- js/regress/get-by-id-bimorphic-check-structure-elimination-expected.txt: Removed.
- js/regress/get-by-id-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
- js/regress/get-by-id-bimorphic-check-structure-elimination-simple.html: Removed.
- js/regress/get-by-id-bimorphic-check-structure-elimination.html: Removed.
- js/regress/get-by-id-chain-from-try-block-expected.txt: Removed.
- js/regress/get-by-id-chain-from-try-block.html: Removed.
- js/regress/get-by-id-check-structure-elimination-expected.txt: Removed.
- js/regress/get-by-id-check-structure-elimination.html: Removed.
- js/regress/get-by-id-proto-or-self-expected.txt: Removed.
- js/regress/get-by-id-proto-or-self.html: Removed.
- js/regress/get-by-id-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
- js/regress/get-by-id-quadmorphic-check-structure-elimination-simple.html: Removed.
- js/regress/get-by-id-self-or-proto-expected.txt: Removed.
- js/regress/get-by-id-self-or-proto.html: Removed.
- js/regress/get-by-val-out-of-bounds-expected.txt: Removed.
- js/regress/get-by-val-out-of-bounds.html: Removed.
- js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-expected.txt: Removed.
- js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
- js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple.html: Removed.
- js/regress/get-by-val-with-string-bimorphic-check-structure-elimination.html: Removed.
- js/regress/get-by-val-with-string-chain-from-try-block-expected.txt: Removed.
- js/regress/get-by-val-with-string-chain-from-try-block.html: Removed.
- js/regress/get-by-val-with-string-check-structure-elimination-expected.txt: Removed.
- js/regress/get-by-val-with-string-check-structure-elimination.html: Removed.
- js/regress/get-by-val-with-string-proto-or-self-expected.txt: Removed.
- js/regress/get-by-val-with-string-proto-or-self.html: Removed.
- js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
- js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.html: Removed.
- js/regress/get-by-val-with-string-self-or-proto-expected.txt: Removed.
- js/regress/get-by-val-with-string-self-or-proto.html: Removed.
- js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.html: Removed.
- js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination.html: Removed.
- js/regress/get-by-val-with-symbol-chain-from-try-block-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-chain-from-try-block.html: Removed.
- js/regress/get-by-val-with-symbol-check-structure-elimination-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-check-structure-elimination.html: Removed.
- js/regress/get-by-val-with-symbol-proto-or-self-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-proto-or-self.html: Removed.
- js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.html: Removed.
- js/regress/get-by-val-with-symbol-self-or-proto-expected.txt: Removed.
- js/regress/get-by-val-with-symbol-self-or-proto.html: Removed.
- js/regress/get_by_val-Int32Array-expected.txt: Removed.
- js/regress/get_by_val-Int32Array.html: Removed.
- js/regress/get_callee_monomorphic-expected.txt: Removed.
- js/regress/get_callee_monomorphic.html: Removed.
- js/regress/get_callee_polymorphic-expected.txt: Removed.
- js/regress/get_callee_polymorphic.html: Removed.
- js/regress/getter-expected.txt: Removed.
- js/regress/getter-no-activation-expected.txt: Removed.
- js/regress/getter-no-activation.html: Removed.
- js/regress/getter-prototype-expected.txt: Removed.
- js/regress/getter-prototype.html: Removed.
- js/regress/getter-richards-expected.txt: Removed.
- js/regress/getter-richards-try-catch-expected.txt: Removed.
- js/regress/getter-richards-try-catch.html: Removed.
- js/regress/getter-richards.html: Removed.
- js/regress/getter.html: Removed.
- js/regress/global-isNaN-expected.txt: Removed.
- js/regress/global-isNaN.html: Removed.
- js/regress/global-object-access-with-mutating-structure-expected.txt: Removed.
- js/regress/global-object-access-with-mutating-structure.html: Removed.
- js/regress/global-var-const-infer-expected.txt: Removed.
- js/regress/global-var-const-infer-fire-from-opt-expected.txt: Removed.
- js/regress/global-var-const-infer-fire-from-opt.html: Removed.
- js/regress/global-var-const-infer.html: Removed.
- js/regress/hard-overflow-check-equal-expected.txt: Removed.
- js/regress/hard-overflow-check-equal.html: Removed.
- js/regress/hard-overflow-check-expected.txt: Removed.
- js/regress/hard-overflow-check.html: Removed.
- js/regress/hoist-make-rope-expected.txt: Removed.
- js/regress/hoist-make-rope.html: Removed.
- js/regress/hoist-poly-check-structure-effectful-loop-expected.txt: Removed.
- js/regress/hoist-poly-check-structure-effectful-loop.html: Removed.
- js/regress/hoist-poly-check-structure-expected.txt: Removed.
- js/regress/hoist-poly-check-structure.html: Removed.
- js/regress/implicit-bigswitch-indirect-symbol-expected.txt: Removed.
- js/regress/implicit-bigswitch-indirect-symbol.html: Removed.
- js/regress/imul-double-only-expected.txt: Removed.
- js/regress/imul-double-only.html: Removed.
- js/regress/imul-int-only-expected.txt: Removed.
- js/regress/imul-int-only.html: Removed.
- js/regress/imul-mixed-expected.txt: Removed.
- js/regress/imul-mixed.html: Removed.
- js/regress/in-four-cases-expected.txt: Removed.
- js/regress/in-four-cases.html: Removed.
- js/regress/in-one-case-false-expected.txt: Removed.
- js/regress/in-one-case-false.html: Removed.
- js/regress/in-one-case-true-expected.txt: Removed.
- js/regress/in-one-case-true.html: Removed.
- js/regress/in-two-cases-expected.txt: Removed.
- js/regress/in-two-cases.html: Removed.
- js/regress/indexed-properties-in-objects-expected.txt: Removed.
- js/regress/indexed-properties-in-objects.html: Removed.
- js/regress/infer-closure-const-then-mov-expected.txt: Removed.
- js/regress/infer-closure-const-then-mov-no-inline-expected.txt: Removed.
- js/regress/infer-closure-const-then-mov-no-inline.html: Removed.
- js/regress/infer-closure-const-then-mov.html: Removed.
- js/regress/infer-closure-const-then-put-to-scope-expected.txt: Removed.
- js/regress/infer-closure-const-then-put-to-scope-no-inline-expected.txt: Removed.
- js/regress/infer-closure-const-then-put-to-scope-no-inline.html: Removed.
- js/regress/infer-closure-const-then-put-to-scope.html: Removed.
- js/regress/infer-closure-const-then-reenter-expected.txt: Removed.
- js/regress/infer-closure-const-then-reenter-no-inline-expected.txt: Removed.
- js/regress/infer-closure-const-then-reenter-no-inline.html: Removed.
- js/regress/infer-closure-const-then-reenter.html: Removed.
- js/regress/infer-constant-global-property-expected.txt: Removed.
- js/regress/infer-constant-global-property.html: Removed.
- js/regress/infer-constant-property-expected.txt: Removed.
- js/regress/infer-constant-property.html: Removed.
- js/regress/infer-one-time-closure-expected.txt: Removed.
- js/regress/infer-one-time-closure-ten-vars-expected.txt: Removed.
- js/regress/infer-one-time-closure-ten-vars.html: Removed.
- js/regress/infer-one-time-closure-two-vars-expected.txt: Removed.
- js/regress/infer-one-time-closure-two-vars.html: Removed.
- js/regress/infer-one-time-closure.html: Removed.
- js/regress/infer-one-time-deep-closure-expected.txt: Removed.
- js/regress/infer-one-time-deep-closure.html: Removed.
- js/regress/inline-arguments-access-expected.txt: Removed.
- js/regress/inline-arguments-access.html: Removed.
- js/regress/inline-arguments-aliased-access-expected.txt: Removed.
- js/regress/inline-arguments-aliased-access.html: Removed.
- js/regress/inline-arguments-local-escape-expected.txt: Removed.
- js/regress/inline-arguments-local-escape.html: Removed.
- js/regress/inline-get-scoped-var-expected.txt: Removed.
- js/regress/inline-get-scoped-var.html: Removed.
- js/regress/inlined-put-by-id-transition-expected.txt: Removed.
- js/regress/inlined-put-by-id-transition.html: Removed.
- js/regress/inlined-put-by-val-with-string-transition-expected.txt: Removed.
- js/regress/inlined-put-by-val-with-string-transition.html: Removed.
- js/regress/inlined-put-by-val-with-symbol-transition-expected.txt: Removed.
- js/regress/inlined-put-by-val-with-symbol-transition.html: Removed.
- js/regress/instanceof-bound-expected.txt: Removed.
- js/regress/instanceof-bound.html: Removed.
- js/regress/int-or-other-abs-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-abs-then-get-by-val.html: Removed.
- js/regress/int-or-other-abs-zero-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-abs-zero-then-get-by-val.html: Removed.
- js/regress/int-or-other-add-expected.txt: Removed.
- js/regress/int-or-other-add-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-add-then-get-by-val.html: Removed.
- js/regress/int-or-other-add.html: Removed.
- js/regress/int-or-other-div-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-div-then-get-by-val.html: Removed.
- js/regress/int-or-other-max-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-max-then-get-by-val.html: Removed.
- js/regress/int-or-other-min-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-min-then-get-by-val.html: Removed.
- js/regress/int-or-other-mod-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-mod-then-get-by-val.html: Removed.
- js/regress/int-or-other-mul-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-mul-then-get-by-val.html: Removed.
- js/regress/int-or-other-neg-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-neg-then-get-by-val.html: Removed.
- js/regress/int-or-other-neg-zero-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-neg-zero-then-get-by-val.html: Removed.
- js/regress/int-or-other-sub-expected.txt: Removed.
- js/regress/int-or-other-sub-then-get-by-val-expected.txt: Removed.
- js/regress/int-or-other-sub-then-get-by-val.html: Removed.
- js/regress/int-or-other-sub.html: Removed.
- js/regress/int-overflow-local-expected.txt: Removed.
- js/regress/int-overflow-local.html: Removed.
- js/regress/int52-spill-expected.txt: Removed.
- js/regress/int52-spill.html: Removed.
- js/regress/integer-divide-expected.txt: Removed.
- js/regress/integer-divide.html: Removed.
- js/regress/integer-modulo-expected.txt: Removed.
- js/regress/integer-modulo.html: Removed.
- js/regress/is-boolean-fold-expected.txt: Removed.
- js/regress/is-boolean-fold-tricky-expected.txt: Removed.
- js/regress/is-boolean-fold-tricky.html: Removed.
- js/regress/is-boolean-fold.html: Removed.
- js/regress/is-function-fold-expected.txt: Removed.
- js/regress/is-function-fold-tricky-expected.txt: Removed.
- js/regress/is-function-fold-tricky-internal-function-expected.txt: Removed.
- js/regress/is-function-fold-tricky-internal-function.html: Removed.
- js/regress/is-function-fold-tricky.html: Removed.
- js/regress/is-function-fold.html: Removed.
- js/regress/is-number-fold-expected.txt: Removed.
- js/regress/is-number-fold-tricky-expected.txt: Removed.
- js/regress/is-number-fold-tricky.html: Removed.
- js/regress/is-number-fold.html: Removed.
- js/regress/is-object-or-null-fold-expected.txt: Removed.
- js/regress/is-object-or-null-fold-functions-expected.txt: Removed.
- js/regress/is-object-or-null-fold-functions.html: Removed.
- js/regress/is-object-or-null-fold-less-tricky-expected.txt: Removed.
- js/regress/is-object-or-null-fold-less-tricky.html: Removed.
- js/regress/is-object-or-null-fold-tricky-expected.txt: Removed.
- js/regress/is-object-or-null-fold-tricky.html: Removed.
- js/regress/is-object-or-null-fold.html: Removed.
- js/regress/is-object-or-null-trickier-function-expected.txt: Removed.
- js/regress/is-object-or-null-trickier-function.html: Removed.
- js/regress/is-object-or-null-trickier-internal-function-expected.txt: Removed.
- js/regress/is-object-or-null-trickier-internal-function.html: Removed.
- js/regress/is-object-or-null-tricky-function-expected.txt: Removed.
- js/regress/is-object-or-null-tricky-function.html: Removed.
- js/regress/is-object-or-null-tricky-internal-function-expected.txt: Removed.
- js/regress/is-object-or-null-tricky-internal-function.html: Removed.
- js/regress/is-string-fold-expected.txt: Removed.
- js/regress/is-string-fold-tricky-expected.txt: Removed.
- js/regress/is-string-fold-tricky.html: Removed.
- js/regress/is-string-fold.html: Removed.
- js/regress/is-undefined-fold-expected.txt: Removed.
- js/regress/is-undefined-fold-tricky-expected.txt: Removed.
- js/regress/is-undefined-fold-tricky.html: Removed.
- js/regress/is-undefined-fold.html: Removed.
- js/regress/large-int-captured-expected.txt: Removed.
- js/regress/large-int-captured.html: Removed.
- js/regress/large-int-expected.txt: Removed.
- js/regress/large-int-neg-expected.txt: Removed.
- js/regress/large-int-neg.html: Removed.
- js/regress/large-int.html: Removed.
- js/regress/lazy-array-species-watchpoints-expected.txt: Removed.
- js/regress/lazy-array-species-watchpoints.html: Removed.
- js/regress/licm-dragons-expected.txt: Removed.
- js/regress/licm-dragons-out-of-bounds-expected.txt: Removed.
- js/regress/licm-dragons-out-of-bounds.html: Removed.
- js/regress/licm-dragons-overflow-expected.txt: Removed.
- js/regress/licm-dragons-overflow.html: Removed.
- js/regress/licm-dragons.html: Removed.
- js/regress/load-varargs-elimination-expected.txt: Removed.
- js/regress/load-varargs-elimination.html: Removed.
- js/regress/locale-compare-expected.txt: Removed.
- js/regress/locale-compare.html: Removed.
- js/regress/logical-not-expected.txt: Removed.
- js/regress/logical-not-weird-types-expected.txt: Removed.
- js/regress/logical-not-weird-types.html: Removed.
- js/regress/logical-not.html: Removed.
- js/regress/lots-of-fields-expected.txt: Removed.
- js/regress/lots-of-fields.html: Removed.
- js/regress/make-indexed-storage-expected.txt: Removed.
- js/regress/make-indexed-storage.html: Removed.
- js/regress/make-rope-cse-expected.txt: Removed.
- js/regress/make-rope-cse.html: Removed.
- js/regress/many-foreach-calls-expected.txt: Removed.
- js/regress/many-foreach-calls.html: Removed.
- js/regress/many-repeat-stores-expected.txt: Removed.
- js/regress/many-repeat-stores.html: Removed.
- js/regress/map-for-each-expected.txt: Removed.
- js/regress/map-for-each.html: Removed.
- js/regress/map-for-of-expected.txt: Removed.
- js/regress/map-for-of.html: Removed.
- js/regress/marsaglia-larger-ints-expected.txt: Removed.
- js/regress/marsaglia-larger-ints.html: Removed.
- js/regress/marsaglia-osr-entry-expected.txt: Removed.
- js/regress/marsaglia-osr-entry.html: Removed.
- js/regress/math-random-expected.txt: Removed.
- js/regress/math-random.html: Removed.
- js/regress/math-trunc-expected.txt: Removed.
- js/regress/math-trunc.html: Removed.
- js/regress/math-with-out-of-bounds-array-values-expected.txt: Removed.
- js/regress/math-with-out-of-bounds-array-values.html: Removed.
- js/regress/max-boolean-expected.txt: Removed.
- js/regress/max-boolean.html: Removed.
- js/regress/megamorphic-load-expected.txt: Removed.
- js/regress/megamorphic-load.html: Removed.
- js/regress/method-on-number-expected.txt: Removed.
- js/regress/method-on-number.html: Removed.
- js/regress/min-boolean-expected.txt: Removed.
- js/regress/min-boolean.html: Removed.
- js/regress/minus-boolean-double-expected.txt: Removed.
- js/regress/minus-boolean-double.html: Removed.
- js/regress/minus-boolean-expected.txt: Removed.
- js/regress/minus-boolean.html: Removed.
- js/regress/misc-bugs-847389-jpeg2000-expected.txt: Removed.
- js/regress/misc-bugs-847389-jpeg2000.html: Removed.
- js/regress/misc-strict-eq-expected.txt: Removed.
- js/regress/misc-strict-eq.html: Removed.
- js/regress/mod-boolean-double-expected.txt: Removed.
- js/regress/mod-boolean-double.html: Removed.
- js/regress/mod-boolean-expected.txt: Removed.
- js/regress/mod-boolean.html: Removed.
- js/regress/mul-boolean-double-expected.txt: Removed.
- js/regress/mul-boolean-double.html: Removed.
- js/regress/mul-boolean-expected.txt: Removed.
- js/regress/mul-boolean.html: Removed.
- js/regress/neg-boolean-expected.txt: Removed.
- js/regress/neg-boolean.html: Removed.
- js/regress/negative-zero-divide-expected.txt: Removed.
- js/regress/negative-zero-divide.html: Removed.
- js/regress/negative-zero-modulo-expected.txt: Removed.
- js/regress/negative-zero-modulo.html: Removed.
- js/regress/negative-zero-negate-expected.txt: Removed.
- js/regress/negative-zero-negate.html: Removed.
- js/regress/nested-function-parsing-expected.txt: Removed.
- js/regress/nested-function-parsing.html: Removed.
- js/regress/new-array-buffer-dead-expected.txt: Removed.
- js/regress/new-array-buffer-dead.html: Removed.
- js/regress/new-array-buffer-push-expected.txt: Removed.
- js/regress/new-array-buffer-push.html: Removed.
- js/regress/new-array-dead-expected.txt: Removed.
- js/regress/new-array-dead.html: Removed.
- js/regress/new-array-push-expected.txt: Removed.
- js/regress/new-array-push.html: Removed.
- js/regress/no-inline-constructor-expected.txt: Removed.
- js/regress/no-inline-constructor.html: Removed.
- js/regress/number-test-expected.txt: Removed.
- js/regress/number-test.html: Removed.
- js/regress/object-and-expected.txt: Removed.
- js/regress/object-and.html: Removed.
- js/regress/object-closure-call-expected.txt: Removed.
- js/regress/object-closure-call.html: Removed.
- js/regress/object-get-own-property-symbols-on-large-array-expected.txt: Removed.
- js/regress/object-get-own-property-symbols-on-large-array.html: Removed.
- js/regress/object-int-add-array-expected.txt: Removed.
- js/regress/object-int-add-array.html: Removed.
- js/regress/object-int-add-expected.txt: Removed.
- js/regress/object-int-add.html: Removed.
- js/regress/object-int-and-array-expected.txt: Removed.
- js/regress/object-int-and-array.html: Removed.
- js/regress/object-int-mul-array-expected.txt: Removed.
- js/regress/object-int-mul-array.html: Removed.
- js/regress/object-int-sub-array-expected.txt: Removed.
- js/regress/object-int-sub-array.html: Removed.
- js/regress/object-int-sub-expected.txt: Removed.
- js/regress/object-int-sub.html: Removed.
- js/regress/object-lshift-expected.txt: Removed.
- js/regress/object-lshift.html: Removed.
- js/regress/object-or-expected.txt: Removed.
- js/regress/object-or.html: Removed.
- js/regress/object-rshift-expected.txt: Removed.
- js/regress/object-rshift.html: Removed.
- js/regress/object-test-expected.txt: Removed.
- js/regress/object-test.html: Removed.
- js/regress/object-urshift-expected.txt: Removed.
- js/regress/object-urshift.html: Removed.
- js/regress/object-xor-expected.txt: Removed.
- js/regress/object-xor.html: Removed.
- js/regress/obvious-sink-pathology-expected.txt: Removed.
- js/regress/obvious-sink-pathology-taken-expected.txt: Removed.
- js/regress/obvious-sink-pathology-taken.html: Removed.
- js/regress/obvious-sink-pathology.html: Removed.
- js/regress/obviously-elidable-new-object-expected.txt: Removed.
- js/regress/obviously-elidable-new-object.html: Removed.
- js/regress/plus-boolean-arith-expected.txt: Removed.
- js/regress/plus-boolean-arith.html: Removed.
- js/regress/plus-boolean-double-expected.txt: Removed.
- js/regress/plus-boolean-double.html: Removed.
- js/regress/plus-boolean-expected.txt: Removed.
- js/regress/plus-boolean.html: Removed.
- js/regress/poly-chain-access-different-prototypes-expected.txt: Removed.
- js/regress/poly-chain-access-different-prototypes-simple-expected.txt: Removed.
- js/regress/poly-chain-access-different-prototypes-simple.html: Removed.
- js/regress/poly-chain-access-different-prototypes.html: Removed.
- js/regress/poly-chain-access-expected.txt: Removed.
- js/regress/poly-chain-access-simpler-expected.txt: Removed.
- js/regress/poly-chain-access-simpler.html: Removed.
- js/regress/poly-chain-access.html: Removed.
- js/regress/poly-stricteq-expected.txt: Removed.
- js/regress/poly-stricteq.html: Removed.
- js/regress/polymorphic-array-call-expected.txt: Removed.
- js/regress/polymorphic-array-call.html: Removed.
- js/regress/polymorphic-get-by-id-expected.txt: Removed.
- js/regress/polymorphic-get-by-id.html: Removed.
- js/regress/polymorphic-put-by-id-expected.txt: Removed.
- js/regress/polymorphic-put-by-id.html: Removed.
- js/regress/polymorphic-put-by-val-with-string-expected.txt: Removed.
- js/regress/polymorphic-put-by-val-with-string.html: Removed.
- js/regress/polymorphic-put-by-val-with-symbol-expected.txt: Removed.
- js/regress/polymorphic-put-by-val-with-symbol.html: Removed.
- js/regress/polymorphic-structure-expected.txt: Removed.
- js/regress/polymorphic-structure.html: Removed.
- js/regress/polyvariant-monomorphic-get-by-id-expected.txt: Removed.
- js/regress/polyvariant-monomorphic-get-by-id.html: Removed.
- js/regress/prevent-extensions-and-do-work-expected.txt: Removed.
- js/regress/prevent-extensions-and-do-work.html: Removed.
- js/regress/proto-getter-access-expected.txt: Removed.
- js/regress/proto-getter-access.html: Removed.
- js/regress/prototype-access-with-mutating-prototype-expected.txt: Removed.
- js/regress/prototype-access-with-mutating-prototype.html: Removed.
- js/regress/put-by-id-expected.txt: Removed.
- js/regress/put-by-id-replace-and-transition-expected.txt: Removed.
- js/regress/put-by-id-replace-and-transition.html: Removed.
- js/regress/put-by-id-slightly-polymorphic-expected.txt: Removed.
- js/regress/put-by-id-slightly-polymorphic.html: Removed.
- js/regress/put-by-id-transition-with-indexing-header-expected.txt: Removed.
- js/regress/put-by-id-transition-with-indexing-header.html: Removed.
- js/regress/put-by-id.html: Removed.
- js/regress/put-by-val-direct-expected.txt: Removed.
- js/regress/put-by-val-direct.html: Removed.
- js/regress/put-by-val-large-index-blank-indexing-type-expected.txt: Removed.
- js/regress/put-by-val-large-index-blank-indexing-type.html: Removed.
- js/regress/put-by-val-machine-int-expected.txt: Removed.
- js/regress/put-by-val-machine-int.html: Removed.
- js/regress/put-by-val-with-string-expected.txt: Removed.
- js/regress/put-by-val-with-string-replace-and-transition-expected.txt: Removed.
- js/regress/put-by-val-with-string-replace-and-transition.html: Removed.
- js/regress/put-by-val-with-string-slightly-polymorphic-expected.txt: Removed.
- js/regress/put-by-val-with-string-slightly-polymorphic.html: Removed.
- js/regress/put-by-val-with-string.html: Removed.
- js/regress/put-by-val-with-symbol-expected.txt: Removed.
- js/regress/put-by-val-with-symbol-replace-and-transition-expected.txt: Removed.
- js/regress/put-by-val-with-symbol-replace-and-transition.html: Removed.
- js/regress/put-by-val-with-symbol-slightly-polymorphic-expected.txt: Removed.
- js/regress/put-by-val-with-symbol-slightly-polymorphic.html: Removed.
- js/regress/put-by-val-with-symbol.html: Removed.
- js/regress/rare-osr-exit-on-local-expected.txt: Removed.
- js/regress/rare-osr-exit-on-local.html: Removed.
- js/regress/raytrace-with-empty-try-catch-expected.txt: Removed.
- js/regress/raytrace-with-empty-try-catch.html: Removed.
- js/regress/raytrace-with-try-catch-expected.txt: Removed.
- js/regress/raytrace-with-try-catch.html: Removed.
- js/regress/regexp-exec-expected.txt: Removed.
- js/regress/regexp-exec.html: Removed.
- js/regress/regexp-last-index-expected.txt: Removed.
- js/regress/regexp-last-index.html: Removed.
- js/regress/regexp-prototype-is-not-instance-expected.txt: Removed.
- js/regress/regexp-prototype-is-not-instance.html: Removed.
- js/regress/regexp-prototype-search-observable-side-effects-expected.txt: Removed.
- js/regress/regexp-prototype-search-observable-side-effects.html: Removed.
- js/regress/regexp-prototype-search-observable-side-effects2-expected.txt: Removed.
- js/regress/regexp-prototype-search-observable-side-effects2.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects2-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects2.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-flags-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-flags.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-global-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-global.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-ignoreCase-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-ignoreCase.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-multiline-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-multiline.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-sticky-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-sticky.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-unicode-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects3-unicode.html: Removed.
- js/regress/regexp-prototype-split-observable-side-effects4-expected.txt: Removed.
- js/regress/regexp-prototype-split-observable-side-effects4.html: Removed.
- js/regress/regexp-prototype-test-observable-side-effects-expected.txt: Removed.
- js/regress/regexp-prototype-test-observable-side-effects.html: Removed.
- js/regress/regexp-prototype-test-observable-side-effects2-expected.txt: Removed.
- js/regress/regexp-prototype-test-observable-side-effects2.html: Removed.
- js/regress/regexp-set-last-index-expected.txt: Removed.
- js/regress/regexp-set-last-index.html: Removed.
- js/regress/register-pressure-from-osr-expected.txt: Removed.
- js/regress/register-pressure-from-osr.html: Removed.
- js/regress/repeat-multi-get-by-offset-expected.txt: Removed.
- js/regress/repeat-multi-get-by-offset.html: Removed.
- js/regress/rest-parameter-construction-performance-expected.txt: Removed.
- js/regress/rest-parameter-construction-performance.html: Removed.
- js/regress/richards-empty-try-catch-expected.txt: Removed.
- js/regress/richards-empty-try-catch.html: Removed.
- js/regress/richards-try-catch-expected.txt: Removed.
- js/regress/richards-try-catch.html: Removed.
- js/regress/scoped-arguments-length-expected.txt: Removed.
- js/regress/scoped-arguments-length.html: Removed.
- js/regress/scoped-arguments-overridden-length-expected.txt: Removed.
- js/regress/scoped-arguments-overridden-length.html: Removed.
- js/regress/scoped-arguments-possibly-overridden-length-expected.txt: Removed.
- js/regress/scoped-arguments-possibly-overridden-length.html: Removed.
- js/regress/script-tests: Removed.
- js/regress/script-tests/ArrayBuffer-DataView-alloc-large-long-lived.js: Removed.
- js/regress/script-tests/ArrayBuffer-DataView-alloc-long-lived.js: Removed.
- js/regress/script-tests/ArrayBuffer-Int32Array-byteOffset.js: Removed.
- js/regress/script-tests/ArrayBuffer-Int8Array-alloc-large-long-lived.js: Removed.
- js/regress/script-tests/ArrayBuffer-Int8Array-alloc-long-lived-buffer.js: Removed.
- js/regress/script-tests/ArrayBuffer-Int8Array-alloc-long-lived.js: Removed.
- js/regress/script-tests/ArrayBuffer-Int8Array-alloc.js: Removed.
- js/regress/script-tests/DataView-custom-properties.js: Removed.
- js/regress/script-tests/Float32Array-matrix-mult.js: Removed.
- js/regress/script-tests/Float32Array-to-Float64Array-set.js: Removed.
- js/regress/script-tests/Float64Array-alloc-long-lived.js: Removed.
- js/regress/script-tests/Float64Array-to-Int16Array-set.js: Removed.
- js/regress/script-tests/HashMap-put-get-iterate-keys.js: Removed.
- js/regress/script-tests/HashMap-put-get-iterate.js: Removed.
- js/regress/script-tests/HashMap-string-put-get-iterate.js: Removed.
- js/regress/script-tests/Int16Array-alloc-long-lived.js: Removed.
- js/regress/script-tests/Int16Array-bubble-sort-with-byteLength.js: Removed.
- js/regress/script-tests/Int16Array-bubble-sort.js: Removed.
- js/regress/script-tests/Int16Array-load-int-mul.js: Removed.
- js/regress/script-tests/Int16Array-to-Int32Array-set.js: Removed.
- js/regress/script-tests/Int32Array-Int8Array-view-alloc.js: Removed.
- js/regress/script-tests/Int32Array-alloc-large.js: Removed.
- js/regress/script-tests/Int32Array-alloc-long-lived.js: Removed.
- js/regress/script-tests/Int32Array-alloc.js: Removed.
- js/regress/script-tests/Int8Array-alloc-long-lived.js: Removed.
- js/regress/script-tests/Int8Array-load-with-byteLength.js: Removed.
- js/regress/script-tests/Int8Array-load.js: Removed.
- js/regress/script-tests/JSONP-negative-0.js: Removed.
- js/regress/script-tests/Number-isNaN.js: Removed.
- js/regress/script-tests/abc-forward-loop-equal.js: Removed.
- js/regress/script-tests/abc-postfix-backward-loop.js: Removed.
- js/regress/script-tests/abc-simple-backward-loop.js: Removed.
- js/regress/script-tests/abc-simple-forward-loop.js: Removed.
- js/regress/script-tests/abc-skippy-loop.js: Removed.
- js/regress/script-tests/abs-boolean.js: Removed.
- js/regress/script-tests/adapt-to-double-divide.js: Removed.
- js/regress/script-tests/aliased-arguments-getbyval.js: Removed.
- js/regress/script-tests/allocate-big-object.js: Removed.
- js/regress/script-tests/apply-not-apply.js: Removed.
- js/regress/script-tests/arguments-named-and-reflective.js: Removed.
- js/regress/script-tests/arguments-out-of-bounds.js: Removed.
- js/regress/script-tests/arguments-strict-mode.js: Removed.
- js/regress/script-tests/arguments.js: Removed.
- js/regress/script-tests/arity-mismatch-inlining.js: Removed.
- js/regress/script-tests/array-access-polymorphic-structure.js: Removed.
- js/regress/script-tests/array-nonarray-polymorhpic-access.js: Removed.
- js/regress/script-tests/array-prototype-every.js: Removed.
- js/regress/script-tests/array-prototype-forEach.js: Removed.
- js/regress/script-tests/array-prototype-map.js: Removed.
- js/regress/script-tests/array-prototype-reduce.js: Removed.
- js/regress/script-tests/array-prototype-reduceRight.js: Removed.
- js/regress/script-tests/array-prototype-some.js: Removed.
- js/regress/script-tests/array-splice-contiguous.js: Removed.
- js/regress/script-tests/array-with-double-add.js: Removed.
- js/regress/script-tests/array-with-double-increment.js: Removed.
- js/regress/script-tests/array-with-double-mul-add.js: Removed.
- js/regress/script-tests/array-with-double-sum.js: Removed.
- js/regress/script-tests/array-with-int32-add-sub.js: Removed.
- js/regress/script-tests/array-with-int32-or-double-sum.js: Removed.
- js/regress/script-tests/arrowfunction-call-in-class-constructor.js: Removed.
- js/regress/script-tests/arrowfunction-call-in-class-method.js: Removed.
- js/regress/script-tests/arrowfunction-call-in-function.js: Removed.
- js/regress/script-tests/arrowfunction-call.js: Removed.
- js/regress/script-tests/asmjs_bool_bug.js: Removed.
- js/regress/script-tests/assign-custom-setter-polymorphic.js: Removed.
- js/regress/script-tests/assign-custom-setter.js: Removed.
- js/regress/script-tests/basic-set.js: Removed.
- js/regress/script-tests/big-int-mul.js: Removed.
- js/regress/script-tests/bigswitch-indirect-symbol-or-undefined.js: Removed.
- js/regress/script-tests/bigswitch-indirect-symbol.js: Removed.
- js/regress/script-tests/bigswitch-indirect.js: Removed.
- js/regress/script-tests/bigswitch.js: Removed.
- js/regress/script-tests/boolean-test.js: Removed.
- js/regress/script-tests/bound-function-call.js: Removed.
- js/regress/script-tests/bound-function-construction-performance.js: Removed.
- js/regress/script-tests/branch-fold.js: Removed.
- js/regress/script-tests/branch-on-string-as-boolean.js: Removed.
- js/regress/script-tests/bug-153431.js: Removed.
- js/regress/script-tests/build-large-object.js: Removed.
- js/regress/script-tests/by-val-generic.js: Removed.
- js/regress/script-tests/call-or-not-call.js: Removed.
- js/regress/script-tests/call-spread-apply.js: Removed.
- js/regress/script-tests/call-spread-call.js: Removed.
- js/regress/script-tests/captured-assignments.js: Removed.
- js/regress/script-tests/cast-int-to-double.js: Removed.
- js/regress/script-tests/cell-argument.js: Removed.
- js/regress/script-tests/cfg-simplify.js: Removed.
- js/regress/script-tests/chain-getter-access.js: Removed.
- js/regress/script-tests/cmpeq-obj-to-obj-other.js: Removed.
- js/regress/script-tests/concat-append-one.js: Removed.
- js/regress/script-tests/constant-test.js: Removed.
- js/regress/script-tests/create-lots-of-functions.js: Removed.
- js/regress/script-tests/cse-new-array-buffer.js: Removed.
- js/regress/script-tests/cse-new-array.js: Removed.
- js/regress/script-tests/custom-setter-getter-as-put-get-by-id.js: Removed.
- js/regress/script-tests/delay-tear-off-arguments-strictmode.js: Removed.
- js/regress/script-tests/deltablue-for-of.js: Removed.
- js/regress/script-tests/deltablue-varargs.js: Removed.
- js/regress/script-tests/destructuring-arguments.js: Removed.
- js/regress/script-tests/destructuring-parameters-overridden-by-function.js: Removed.
- js/regress/script-tests/destructuring-swap.js: Removed.
- js/regress/script-tests/direct-arguments-getbyval.js: Removed.
- js/regress/script-tests/direct-arguments-length.js: Removed.
- js/regress/script-tests/direct-arguments-overridden-length.js: Removed.
- js/regress/script-tests/direct-arguments-possibly-overridden-length.js: Removed.
- js/regress/script-tests/div-boolean-double.js: Removed.
- js/regress/script-tests/div-boolean.js: Removed.
- js/regress/script-tests/double-get-by-val-out-of-bounds.js: Removed.
- js/regress/script-tests/double-pollution-getbyval.js: Removed.
- js/regress/script-tests/double-pollution-putbyoffset.js: Removed.
- js/regress/script-tests/double-real-use.js: Removed.
- js/regress/script-tests/double-to-int32-typed-array-no-inline.js: Removed.
- js/regress/script-tests/double-to-int32-typed-array.js: Removed.
- js/regress/script-tests/double-to-uint32-typed-array-no-inline.js: Removed.
- js/regress/script-tests/double-to-uint32-typed-array.js: Removed.
- js/regress/script-tests/elidable-new-object-dag.js: Removed.
- js/regress/script-tests/elidable-new-object-roflcopter.js: Removed.
- js/regress/script-tests/elidable-new-object-then-call.js: Removed.
- js/regress/script-tests/elidable-new-object-tree.js: Removed.
- js/regress/script-tests/empty-string-plus-int.js: Removed.
- js/regress/script-tests/emscripten-cube2hash.js: Removed.
- js/regress/script-tests/eval-compute.js: Removed.
- js/regress/script-tests/eval-not-eval-compute-args.js: Removed.
- js/regress/script-tests/eval-not-eval-compute.js: Removed.
- js/regress/script-tests/exit-length-on-plain-object.js: Removed.
- js/regress/script-tests/external-arguments-getbyval.js: Removed.
- js/regress/script-tests/external-arguments-putbyval.js: Removed.
- js/regress/script-tests/fixed-typed-array-storage-var-index.js: Removed.
- js/regress/script-tests/fixed-typed-array-storage.js: Removed.
- js/regress/script-tests/fold-double-to-int.js: Removed.
- js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset-rare-int.js: Removed.
- js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset.js: Removed.
- js/regress/script-tests/fold-multi-get-by-offset-to-get-by-offset.js: Removed.
- js/regress/script-tests/fold-multi-get-by-offset-to-poly-get-by-offset.js: Removed.
- js/regress/script-tests/fold-multi-put-by-offset-to-poly-put-by-offset.js: Removed.
- js/regress/script-tests/fold-multi-put-by-offset-to-put-by-offset.js: Removed.
- js/regress/script-tests/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.js: Removed.
- js/regress/script-tests/fold-put-by-id-to-multi-put-by-offset.js: Removed.
- js/regress/script-tests/fold-put-by-val-with-string-to-multi-put-by-offset.js: Removed.
- js/regress/script-tests/fold-put-by-val-with-symbol-to-multi-put-by-offset.js: Removed.
- js/regress/script-tests/fold-put-structure.js: Removed.
- js/regress/script-tests/for-of-iterate-array-entries.js: Removed.
- js/regress/script-tests/for-of-iterate-array-keys.js: Removed.
- js/regress/script-tests/for-of-iterate-array-values.js: Removed.
- js/regress/script-tests/freeze-and-do-work.js: Removed.
- js/regress/script-tests/fround.js: Removed.
- js/regress/script-tests/ftl-library-inlining-dataview.js: Removed.
- js/regress/script-tests/ftl-library-inlining.js: Removed.
- js/regress/script-tests/ftl-polymorphic-StringFromCharCode.js: Removed.
- js/regress/script-tests/ftl-polymorphic-bitand.js: Removed.
- js/regress/script-tests/ftl-polymorphic-bitor.js: Removed.
- js/regress/script-tests/ftl-polymorphic-bitxor.js: Removed.
- js/regress/script-tests/ftl-polymorphic-div.js: Removed.
- js/regress/script-tests/ftl-polymorphic-lshift.js: Removed.
- js/regress/script-tests/ftl-polymorphic-mul.js: Removed.
- js/regress/script-tests/ftl-polymorphic-rshift.js: Removed.
- js/regress/script-tests/ftl-polymorphic-sub.js: Removed.
- js/regress/script-tests/ftl-polymorphic-urshift.js: Removed.
- js/regress/script-tests/function-call.js: Removed.
- js/regress/script-tests/function-dot-apply.js: Removed.
- js/regress/script-tests/function-test.js: Removed.
- js/regress/script-tests/function-with-eval.js: Removed.
- js/regress/script-tests/gcse-poly-get-less-obvious.js: Removed.
- js/regress/script-tests/gcse-poly-get.js: Removed.
- js/regress/script-tests/gcse.js: Removed.
- js/regress/script-tests/generator-create.js: Removed.
- js/regress/script-tests/generator-fib.js: Removed.
- js/regress/script-tests/generator-function-create.js: Removed.
- js/regress/script-tests/generator-sunspider-access-nsieve.js: Removed.
- js/regress/script-tests/generator-with-several-types.js: Removed.
- js/regress/script-tests/get-by-id-bimorphic-check-structure-elimination-simple.js: Removed.
- js/regress/script-tests/get-by-id-bimorphic-check-structure-elimination.js: Removed.
- js/regress/script-tests/get-by-id-chain-from-try-block.js: Removed.
- js/regress/script-tests/get-by-id-check-structure-elimination.js: Removed.
- js/regress/script-tests/get-by-id-proto-or-self.js: Removed.
- js/regress/script-tests/get-by-id-quadmorphic-check-structure-elimination-simple.js: Removed.
- js/regress/script-tests/get-by-id-self-or-proto.js: Removed.
- js/regress/script-tests/get-by-val-out-of-bounds.js: Removed.
- js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination-simple.js: Removed.
- js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination.js: Removed.
- js/regress/script-tests/get-by-val-with-string-chain-from-try-block.js: Removed.
- js/regress/script-tests/get-by-val-with-string-check-structure-elimination.js: Removed.
- js/regress/script-tests/get-by-val-with-string-proto-or-self.js: Removed.
- js/regress/script-tests/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.js: Removed.
- js/regress/script-tests/get-by-val-with-string-self-or-proto.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-chain-from-try-block.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-check-structure-elimination.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-proto-or-self.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.js: Removed.
- js/regress/script-tests/get-by-val-with-symbol-self-or-proto.js: Removed.
- js/regress/script-tests/get_by_val-Int32Array.js: Removed.
- js/regress/script-tests/get_callee_monomorphic.js: Removed.
- js/regress/script-tests/get_callee_polymorphic.js: Removed.
- js/regress/script-tests/getter-no-activation.js: Removed.
- js/regress/script-tests/getter-prototype.js: Removed.
- js/regress/script-tests/getter-richards-try-catch.js: Removed.
- js/regress/script-tests/getter-richards.js: Removed.
- js/regress/script-tests/getter.js: Removed.
- js/regress/script-tests/global-isNaN.js: Removed.
- js/regress/script-tests/global-object-access-with-mutating-structure.js: Removed.
- js/regress/script-tests/global-var-const-infer-fire-from-opt.js: Removed.
- js/regress/script-tests/global-var-const-infer.js: Removed.
- js/regress/script-tests/hard-overflow-check-equal.js: Removed.
- js/regress/script-tests/hard-overflow-check.js: Removed.
- js/regress/script-tests/hoist-make-rope.js: Removed.
- js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js: Removed.
- js/regress/script-tests/hoist-poly-check-structure.js: Removed.
- js/regress/script-tests/implicit-bigswitch-indirect-symbol.js: Removed.
- js/regress/script-tests/imul-double-only.js: Removed.
- js/regress/script-tests/imul-int-only.js: Removed.
- js/regress/script-tests/imul-mixed.js: Removed.
- js/regress/script-tests/in-four-cases.js: Removed.
- js/regress/script-tests/in-one-case-false.js: Removed.
- js/regress/script-tests/in-one-case-true.js: Removed.
- js/regress/script-tests/in-two-cases.js: Removed.
- js/regress/script-tests/indexed-properties-in-objects.js: Removed.
- js/regress/script-tests/infer-closure-const-then-mov-no-inline.js: Removed.
- js/regress/script-tests/infer-closure-const-then-mov.js: Removed.
- js/regress/script-tests/infer-closure-const-then-put-to-scope-no-inline.js: Removed.
- js/regress/script-tests/infer-closure-const-then-put-to-scope.js: Removed.
- js/regress/script-tests/infer-closure-const-then-reenter-no-inline.js: Removed.
- js/regress/script-tests/infer-closure-const-then-reenter.js: Removed.
- js/regress/script-tests/infer-constant-global-property.js: Removed.
- js/regress/script-tests/infer-constant-property.js: Removed.
- js/regress/script-tests/infer-one-time-closure-ten-vars.js: Removed.
- js/regress/script-tests/infer-one-time-closure-two-vars.js: Removed.
- js/regress/script-tests/infer-one-time-closure.js: Removed.
- js/regress/script-tests/infer-one-time-deep-closure.js: Removed.
- js/regress/script-tests/inline-arguments-access.js: Removed.
- js/regress/script-tests/inline-arguments-aliased-access.js: Removed.
- js/regress/script-tests/inline-arguments-local-escape.js: Removed.
- js/regress/script-tests/inline-get-scoped-var.js: Removed.
- js/regress/script-tests/inlined-put-by-id-transition.js: Removed.
- js/regress/script-tests/inlined-put-by-val-with-string-transition.js: Removed.
- js/regress/script-tests/inlined-put-by-val-with-symbol-transition.js: Removed.
- js/regress/script-tests/instanceof-bound.js: Removed.
- js/regress/script-tests/int-or-other-abs-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-abs-zero-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-add-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-add.js: Removed.
- js/regress/script-tests/int-or-other-div-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-max-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-min-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-mod-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-mul-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-neg-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-neg-zero-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-sub-then-get-by-val.js: Removed.
- js/regress/script-tests/int-or-other-sub.js: Removed.
- js/regress/script-tests/int-overflow-local.js: Removed.
- js/regress/script-tests/int52-spill.js: Removed.
- js/regress/script-tests/integer-divide.js: Removed.
- js/regress/script-tests/integer-modulo.js: Removed.
- js/regress/script-tests/is-boolean-fold-tricky.js: Removed.
- js/regress/script-tests/is-boolean-fold.js: Removed.
- js/regress/script-tests/is-function-fold-tricky-internal-function.js: Removed.
- js/regress/script-tests/is-function-fold-tricky.js: Removed.
- js/regress/script-tests/is-function-fold.js: Removed.
- js/regress/script-tests/is-number-fold-tricky.js: Removed.
- js/regress/script-tests/is-number-fold.js: Removed.
- js/regress/script-tests/is-object-or-null-fold-functions.js: Removed.
- js/regress/script-tests/is-object-or-null-fold-less-tricky.js: Removed.
- js/regress/script-tests/is-object-or-null-fold-tricky.js: Removed.
- js/regress/script-tests/is-object-or-null-fold.js: Removed.
- js/regress/script-tests/is-object-or-null-trickier-function.js: Removed.
- js/regress/script-tests/is-object-or-null-trickier-internal-function.js: Removed.
- js/regress/script-tests/is-object-or-null-tricky-function.js: Removed.
- js/regress/script-tests/is-object-or-null-tricky-internal-function.js: Removed.
- js/regress/script-tests/is-string-fold-tricky.js: Removed.
- js/regress/script-tests/is-string-fold.js: Removed.
- js/regress/script-tests/is-undefined-fold-tricky.js: Removed.
- js/regress/script-tests/is-undefined-fold.js: Removed.
- js/regress/script-tests/large-int-captured.js: Removed.
- js/regress/script-tests/large-int-neg.js: Removed.
- js/regress/script-tests/large-int.js: Removed.
- js/regress/script-tests/lazy-array-species-watchpoints.js: Removed.
- js/regress/script-tests/licm-dragons-out-of-bounds.js: Removed.
- js/regress/script-tests/licm-dragons-overflow.js: Removed.
- js/regress/script-tests/licm-dragons.js: Removed.
- js/regress/script-tests/load-varargs-elimination.js: Removed.
- js/regress/script-tests/locale-compare.js: Removed.
- js/regress/script-tests/logical-not-weird-types.js: Removed.
- js/regress/script-tests/logical-not.js: Removed.
- js/regress/script-tests/lots-of-fields.js: Removed.
- js/regress/script-tests/make-indexed-storage.js: Removed.
- js/regress/script-tests/make-rope-cse.js: Removed.
- js/regress/script-tests/many-foreach-calls.js: Removed.
- js/regress/script-tests/many-repeat-stores.js: Removed.
- js/regress/script-tests/map-for-each.js: Removed.
- js/regress/script-tests/map-for-of.js: Removed.
- js/regress/script-tests/marsaglia-larger-ints.js: Removed.
- js/regress/script-tests/marsaglia-osr-entry.js: Removed.
- js/regress/script-tests/math-random.js: Removed.
- js/regress/script-tests/math-trunc.js: Removed.
- js/regress/script-tests/math-with-out-of-bounds-array-values.js: Removed.
- js/regress/script-tests/max-boolean.js: Removed.
- js/regress/script-tests/megamorphic-load.js: Removed.
- js/regress/script-tests/method-on-number.js: Removed.
- js/regress/script-tests/min-boolean.js: Removed.
- js/regress/script-tests/minus-boolean-double.js: Removed.
- js/regress/script-tests/minus-boolean.js: Removed.
- js/regress/script-tests/misc-bugs-847389-jpeg2000.js: Removed.
- js/regress/script-tests/misc-strict-eq.js: Removed.
- js/regress/script-tests/mod-boolean-double.js: Removed.
- js/regress/script-tests/mod-boolean.js: Removed.
- js/regress/script-tests/mul-boolean-double.js: Removed.
- js/regress/script-tests/mul-boolean.js: Removed.
- js/regress/script-tests/neg-boolean.js: Removed.
- js/regress/script-tests/negative-zero-divide.js: Removed.
- js/regress/script-tests/negative-zero-modulo.js: Removed.
- js/regress/script-tests/negative-zero-negate.js: Removed.
- js/regress/script-tests/nested-function-parsing.js: Removed.
- js/regress/script-tests/new-array-buffer-dead.js: Removed.
- js/regress/script-tests/new-array-buffer-push.js: Removed.
- js/regress/script-tests/new-array-dead.js: Removed.
- js/regress/script-tests/new-array-push.js: Removed.
- js/regress/script-tests/no-inline-constructor.js: Removed.
- js/regress/script-tests/number-test.js: Removed.
- js/regress/script-tests/object-and.js: Removed.
- js/regress/script-tests/object-closure-call.js: Removed.
- js/regress/script-tests/object-get-own-property-symbols-on-large-array.js: Removed.
- js/regress/script-tests/object-int-add-array.js: Removed.
- js/regress/script-tests/object-int-add.js: Removed.
- js/regress/script-tests/object-int-and-array.js: Removed.
- js/regress/script-tests/object-int-mul-array.js: Removed.
- js/regress/script-tests/object-int-sub-array.js: Removed.
- js/regress/script-tests/object-int-sub.js: Removed.
- js/regress/script-tests/object-lshift.js: Removed.
- js/regress/script-tests/object-or.js: Removed.
- js/regress/script-tests/object-rshift.js: Removed.
- js/regress/script-tests/object-test.js: Removed.
- js/regress/script-tests/object-urshift.js: Removed.
- js/regress/script-tests/object-xor.js: Removed.
- js/regress/script-tests/obvious-sink-pathology-taken.js: Removed.
- js/regress/script-tests/obvious-sink-pathology.js: Removed.
- js/regress/script-tests/obviously-elidable-new-object.js: Removed.
- js/regress/script-tests/plus-boolean-arith.js: Removed.
- js/regress/script-tests/plus-boolean-double.js: Removed.
- js/regress/script-tests/plus-boolean.js: Removed.
- js/regress/script-tests/poly-chain-access-different-prototypes-simple.js: Removed.
- js/regress/script-tests/poly-chain-access-different-prototypes.js: Removed.
- js/regress/script-tests/poly-chain-access-simpler.js: Removed.
- js/regress/script-tests/poly-chain-access.js: Removed.
- js/regress/script-tests/poly-stricteq.js: Removed.
- js/regress/script-tests/polymorphic-array-call.js: Removed.
- js/regress/script-tests/polymorphic-get-by-id.js: Removed.
- js/regress/script-tests/polymorphic-put-by-id.js: Removed.
- js/regress/script-tests/polymorphic-put-by-val-with-string.js: Removed.
- js/regress/script-tests/polymorphic-put-by-val-with-symbol.js: Removed.
- js/regress/script-tests/polymorphic-structure.js: Removed.
- js/regress/script-tests/polyvariant-monomorphic-get-by-id.js: Removed.
- js/regress/script-tests/prevent-extensions-and-do-work.js: Removed.
- js/regress/script-tests/proto-getter-access.js: Removed.
- js/regress/script-tests/prototype-access-with-mutating-prototype.js: Removed.
- js/regress/script-tests/put-by-id-replace-and-transition.js: Removed.
- js/regress/script-tests/put-by-id-slightly-polymorphic.js: Removed.
- js/regress/script-tests/put-by-id-transition-with-indexing-header.js: Removed.
- js/regress/script-tests/put-by-id.js: Removed.
- js/regress/script-tests/put-by-val-direct.js: Removed.
- js/regress/script-tests/put-by-val-large-index-blank-indexing-type.js: Removed.
- js/regress/script-tests/put-by-val-machine-int.js: Removed.
- js/regress/script-tests/put-by-val-with-string-replace-and-transition.js: Removed.
- js/regress/script-tests/put-by-val-with-string-slightly-polymorphic.js: Removed.
- js/regress/script-tests/put-by-val-with-string.js: Removed.
- js/regress/script-tests/put-by-val-with-symbol-replace-and-transition.js: Removed.
- js/regress/script-tests/put-by-val-with-symbol-slightly-polymorphic.js: Removed.
- js/regress/script-tests/put-by-val-with-symbol.js: Removed.
- js/regress/script-tests/rare-osr-exit-on-local.js: Removed.
- js/regress/script-tests/raytrace-with-empty-try-catch.js: Removed.
- js/regress/script-tests/raytrace-with-try-catch.js: Removed.
- js/regress/script-tests/regexp-exec.js: Removed.
- js/regress/script-tests/regexp-last-index.js: Removed.
- js/regress/script-tests/regexp-prototype-is-not-instance.js: Removed.
- js/regress/script-tests/regexp-prototype-search-observable-side-effects.js: Removed.
- js/regress/script-tests/regexp-prototype-search-observable-side-effects2.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects2.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects3-flags.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects3-global.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects3-ignoreCase.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects3-multiline.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects3-sticky.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects3-unicode.js: Removed.
- js/regress/script-tests/regexp-prototype-split-observable-side-effects4.js: Removed.
- js/regress/script-tests/regexp-prototype-test-observable-side-effects.js: Removed.
- js/regress/script-tests/regexp-prototype-test-observable-side-effects2.js: Removed.
- js/regress/script-tests/regexp-set-last-index.js: Removed.
- js/regress/script-tests/register-pressure-from-osr.js: Removed.
- js/regress/script-tests/repeat-multi-get-by-offset.js: Removed.
- js/regress/script-tests/rest-parameter-construction-performance.js: Removed.
- js/regress/script-tests/richards-empty-try-catch.js: Removed.
- js/regress/script-tests/richards-try-catch.js: Removed.
- js/regress/script-tests/scoped-arguments-length.js: Removed.
- js/regress/script-tests/scoped-arguments-overridden-length.js: Removed.
- js/regress/script-tests/scoped-arguments-possibly-overridden-length.js: Removed.
- js/regress/script-tests/seal-and-do-work.js: Removed.
- js/regress/script-tests/set-for-each.js: Removed.
- js/regress/script-tests/set-for-of.js: Removed.
- js/regress/script-tests/setter-prototype.js: Removed.
- js/regress/script-tests/setter.js: Removed.
- js/regress/script-tests/simple-activation-demo.js: Removed.
- js/regress/script-tests/simple-getter-access.js: Removed.
- js/regress/script-tests/simple-poly-call-nested.js: Removed.
- js/regress/script-tests/simple-poly-call.js: Removed.
- js/regress/script-tests/simple-regexp-exec-folding-fail.js: Removed.
- js/regress/script-tests/simple-regexp-exec-folding.js: Removed.
- js/regress/script-tests/simple-regexp-test-folding-fail-with-hoisted-regexp.js: Removed.
- js/regress/script-tests/simple-regexp-test-folding-fail.js: Removed.
- js/regress/script-tests/simple-regexp-test-folding-with-hoisted-regexp.js: Removed.
- js/regress/script-tests/simple-regexp-test-folding.js: Removed.
- js/regress/script-tests/sin-boolean.js: Removed.
- js/regress/script-tests/singleton-scope.js: Removed.
- js/regress/script-tests/sink-function.js: Removed.
- js/regress/script-tests/sink-huge-activation.js: Removed.
- js/regress/script-tests/sinkable-new-object-dag.js: Removed.
- js/regress/script-tests/sinkable-new-object-taken.js: Removed.
- js/regress/script-tests/sinkable-new-object.js: Removed.
- js/regress/script-tests/slow-array-profile-convergence.js: Removed.
- js/regress/script-tests/slow-convergence.js: Removed.
- js/regress/script-tests/slow-ternaries.js: Removed.
- js/regress/script-tests/sorting-benchmark.js: Removed.
- js/regress/script-tests/sparse-conditional.js: Removed.
- js/regress/script-tests/splice-to-remove.js: Removed.
- js/regress/script-tests/strcat-const.js: Removed.
- js/regress/script-tests/strcat-length-const.js: Removed.
- js/regress/script-tests/strict-osr-entry.js: Removed.
- js/regress/script-tests/string-char-code-at.js: Removed.
- js/regress/script-tests/string-concat-object.js: Removed.
- js/regress/script-tests/string-concat-pair-object.js: Removed.
- js/regress/script-tests/string-concat-pair-simple.js: Removed.
- js/regress/script-tests/string-concat-simple.js: Removed.
- js/regress/script-tests/string-cons-repeat.js: Removed.
- js/regress/script-tests/string-cons-tower.js: Removed.
- js/regress/script-tests/string-equality.js: Removed.
- js/regress/script-tests/string-from-char-code.js: Removed.
- js/regress/script-tests/string-get-by-val-big-char.js: Removed.
- js/regress/script-tests/string-get-by-val-out-of-bounds-insane.js: Removed.
- js/regress/script-tests/string-get-by-val-out-of-bounds.js: Removed.
- js/regress/script-tests/string-get-by-val.js: Removed.
- js/regress/script-tests/string-hash.js: Removed.
- js/regress/script-tests/string-long-ident-equality.js: Removed.
- js/regress/script-tests/string-out-of-bounds.js: Removed.
- js/regress/script-tests/string-prototype-search-observable-side-effects.js: Removed.
- js/regress/script-tests/string-prototype-search-observable-side-effects2.js: Removed.
- js/regress/script-tests/string-prototype-search-observable-side-effects3.js: Removed.
- js/regress/script-tests/string-prototype-search-observable-side-effects4.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects2.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects3-flags.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects3-global.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects3-ignoreCase.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects3-multiline.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects3-sticky.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects3-unicode.js: Removed.
- js/regress/script-tests/string-prototype-split-observable-side-effects4.js: Removed.
- js/regress/script-tests/string-repeat-arith.js: Removed.
- js/regress/script-tests/string-repeat-not-resolving-fixed.js: Removed.
- js/regress/script-tests/string-repeat-not-resolving-no-inline.js: Removed.
- js/regress/script-tests/string-repeat-not-resolving.js: Removed.
- js/regress/script-tests/string-repeat-resolving-fixed.js: Removed.
- js/regress/script-tests/string-repeat-resolving-no-inline.js: Removed.
- js/regress/script-tests/string-repeat-resolving.js: Removed.
- js/regress/script-tests/string-repeat-single-not-resolving.js: Removed.
- js/regress/script-tests/string-repeat-single-resolving.js: Removed.
- js/regress/script-tests/string-repeat-small-not-resolving.js: Removed.
- js/regress/script-tests/string-repeat-small-resolving.js: Removed.
- js/regress/script-tests/string-replace-empty.js: Removed.
- js/regress/script-tests/string-replace-generic.js: Removed.
- js/regress/script-tests/string-replace.js: Removed.
- js/regress/script-tests/string-rope-with-object.js: Removed.
- js/regress/script-tests/string-sub.js: Removed.
- js/regress/script-tests/string-test.js: Removed.
- js/regress/script-tests/string-transcoding.js: Removed.
- js/regress/script-tests/string-var-equality.js: Removed.
- js/regress/script-tests/structure-hoist-over-transitions.js: Removed.
- js/regress/script-tests/substring-concat-weird.js: Removed.
- js/regress/script-tests/substring-concat.js: Removed.
- js/regress/script-tests/substring.js: Removed.
- js/regress/script-tests/switch-char-constant.js: Removed.
- js/regress/script-tests/switch-char.js: Removed.
- js/regress/script-tests/switch-constant.js: Removed.
- js/regress/script-tests/switch-string-basic-big-var.js: Removed.
- js/regress/script-tests/switch-string-basic-big.js: Removed.
- js/regress/script-tests/switch-string-basic-var.js: Removed.
- js/regress/script-tests/switch-string-basic.js: Removed.
- js/regress/script-tests/switch-string-big-length-tower-var.js: Removed.
- js/regress/script-tests/switch-string-length-tower-var.js: Removed.
- js/regress/script-tests/switch-string-length-tower.js: Removed.
- js/regress/script-tests/switch-string-short.js: Removed.
- js/regress/script-tests/switch.js: Removed.
- js/regress/script-tests/symbol-tostringtag.js: Removed.
- js/regress/script-tests/tear-off-arguments-simple.js: Removed.
- js/regress/script-tests/tear-off-arguments.js: Removed.
- js/regress/script-tests/temporal-structure.js: Removed.
- js/regress/script-tests/to-int32-boolean.js: Removed.
- js/regress/script-tests/to-number-constructor-number-string-number-string.js: Removed.
- js/regress/script-tests/to-number-constructor-only-number.js: Removed.
- js/regress/script-tests/to-number-constructor-only-string.js: Removed.
- js/regress/script-tests/to-number-constructor-string-number-string-number.js: Removed.
- js/regress/script-tests/to-number-number-string-number-string.js: Removed.
- js/regress/script-tests/to-number-only-number.js: Removed.
- js/regress/script-tests/to-number-only-string.js: Removed.
- js/regress/script-tests/to-number-string-number-string-number.js: Removed.
- js/regress/script-tests/try-catch-get-by-val-cloned-arguments.js: Removed.
- js/regress/script-tests/try-catch-get-by-val-direct-arguments.js: Removed.
- js/regress/script-tests/try-catch-get-by-val-scoped-arguments.js: Removed.
- js/regress/script-tests/typed-array-get-set-by-val-profiling.js: Removed.
- js/regress/script-tests/typed-array-subarray.js: Removed.
- js/regress/script-tests/undefined-property-access.js: Removed.
- js/regress/script-tests/undefined-test.js: Removed.
- js/regress/script-tests/unprofiled-licm.js: Removed.
- js/regress/script-tests/untyped-string-from-char-code.js: Removed.
- js/regress/script-tests/v8-raytrace-with-empty-try-catch.js: Removed.
- js/regress/script-tests/v8-raytrace-with-try-catch-high-frequency-throws.js: Removed.
- js/regress/script-tests/v8-raytrace-with-try-catch.js: Removed.
- js/regress/script-tests/v8-regexp-search.js: Removed.
- js/regress/script-tests/varargs-call.js: Removed.
- js/regress/script-tests/varargs-construct-inline.js: Removed.
- js/regress/script-tests/varargs-construct.js: Removed.
- js/regress/script-tests/varargs-inline.js: Removed.
- js/regress/script-tests/varargs-strict-mode.js: Removed.
- js/regress/script-tests/varargs.js: Removed.
- js/regress/script-tests/weird-inlining-const-prop.js: Removed.
- js/regress/seal-and-do-work-expected.txt: Removed.
- js/regress/seal-and-do-work.html: Removed.
- js/regress/set-for-each-expected.txt: Removed.
- js/regress/set-for-each.html: Removed.
- js/regress/set-for-of-expected.txt: Removed.
- js/regress/set-for-of.html: Removed.
- js/regress/setter-expected.txt: Removed.
- js/regress/setter-prototype-expected.txt: Removed.
- js/regress/setter-prototype.html: Removed.
- js/regress/setter.html: Removed.
- js/regress/simple-activation-demo-expected.txt: Removed.
- js/regress/simple-activation-demo.html: Removed.
- js/regress/simple-getter-access-expected.txt: Removed.
- js/regress/simple-getter-access.html: Removed.
- js/regress/simple-poly-call-expected.txt: Removed.
- js/regress/simple-poly-call-nested-expected.txt: Removed.
- js/regress/simple-poly-call-nested.html: Removed.
- js/regress/simple-poly-call.html: Removed.
- js/regress/simple-regexp-exec-folding-expected.txt: Removed.
- js/regress/simple-regexp-exec-folding-fail-expected.txt: Removed.
- js/regress/simple-regexp-exec-folding-fail.html: Removed.
- js/regress/simple-regexp-exec-folding.html: Removed.
- js/regress/simple-regexp-test-folding-expected.txt: Removed.
- js/regress/simple-regexp-test-folding-fail-expected.txt: Removed.
- js/regress/simple-regexp-test-folding-fail-with-hoisted-regexp-expected.txt: Removed.
- js/regress/simple-regexp-test-folding-fail-with-hoisted-regexp.html: Removed.
- js/regress/simple-regexp-test-folding-fail.html: Removed.
- js/regress/simple-regexp-test-folding-with-hoisted-regexp-expected.txt: Removed.
- js/regress/simple-regexp-test-folding-with-hoisted-regexp.html: Removed.
- js/regress/simple-regexp-test-folding.html: Removed.
- js/regress/sin-boolean-expected.txt: Removed.
- js/regress/sin-boolean.html: Removed.
- js/regress/singleton-scope-expected.txt: Removed.
- js/regress/singleton-scope.html: Removed.
- js/regress/sink-function-expected.txt: Removed.
- js/regress/sink-function.html: Removed.
- js/regress/sink-huge-activation-expected.txt: Removed.
- js/regress/sink-huge-activation.html: Removed.
- js/regress/sinkable-new-object-dag-expected.txt: Removed.
- js/regress/sinkable-new-object-dag.html: Removed.
- js/regress/sinkable-new-object-expected.txt: Removed.
- js/regress/sinkable-new-object-taken-expected.txt: Removed.
- js/regress/sinkable-new-object-taken.html: Removed.
- js/regress/sinkable-new-object.html: Removed.
- js/regress/slow-array-profile-convergence-expected.txt: Removed.
- js/regress/slow-array-profile-convergence.html: Removed.
- js/regress/slow-convergence-expected.txt: Removed.
- js/regress/slow-convergence.html: Removed.
- js/regress/slow-ternaries-expected.txt: Removed.
- js/regress/slow-ternaries.html: Removed.
- js/regress/sortamorphic-load-expected.txt: Removed.
- js/regress/sortamorphic-load.html: Removed.
- js/regress/sorting-benchmark-expected.txt: Removed.
- js/regress/sorting-benchmark.html: Removed.
- js/regress/sparse-conditional-expected.txt: Removed.
- js/regress/sparse-conditional.html: Removed.
- js/regress/splice-to-remove-expected.txt: Removed.
- js/regress/splice-to-remove.html: Removed.
- js/regress/strcat-const-expected.txt: Removed.
- js/regress/strcat-const.html: Removed.
- js/regress/strcat-length-const-expected.txt: Removed.
- js/regress/strcat-length-const.html: Removed.
- js/regress/strict-osr-entry-expected.txt: Removed.
- js/regress/strict-osr-entry.html: Removed.
- js/regress/string-char-code-at-expected.txt: Removed.
- js/regress/string-char-code-at.html: Removed.
- js/regress/string-concat-object-expected.txt: Removed.
- js/regress/string-concat-object.html: Removed.
- js/regress/string-concat-pair-object-expected.txt: Removed.
- js/regress/string-concat-pair-object.html: Removed.
- js/regress/string-concat-pair-simple-expected.txt: Removed.
- js/regress/string-concat-pair-simple.html: Removed.
- js/regress/string-concat-simple-expected.txt: Removed.
- js/regress/string-concat-simple.html: Removed.
- js/regress/string-cons-repeat-expected.txt: Removed.
- js/regress/string-cons-repeat.html: Removed.
- js/regress/string-cons-tower-expected.txt: Removed.
- js/regress/string-cons-tower.html: Removed.
- js/regress/string-equality-expected.txt: Removed.
- js/regress/string-equality.html: Removed.
- js/regress/string-from-char-code-expected.txt: Removed.
- js/regress/string-from-char-code.html: Removed.
- js/regress/string-get-by-val-big-char-expected.txt: Removed.
- js/regress/string-get-by-val-big-char.html: Removed.
- js/regress/string-get-by-val-expected.txt: Removed.
- js/regress/string-get-by-val-out-of-bounds-expected.txt: Removed.
- js/regress/string-get-by-val-out-of-bounds-insane-expected.txt: Removed.
- js/regress/string-get-by-val-out-of-bounds-insane.html: Removed.
- js/regress/string-get-by-val-out-of-bounds.html: Removed.
- js/regress/string-get-by-val.html: Removed.
- js/regress/string-hash-expected.txt: Removed.
- js/regress/string-hash.html: Removed.
- js/regress/string-long-ident-equality-expected.txt: Removed.
- js/regress/string-long-ident-equality.html: Removed.
- js/regress/string-out-of-bounds-expected.txt: Removed.
- js/regress/string-out-of-bounds.html: Removed.
- js/regress/string-prototype-search-observable-side-effects-expected.txt: Removed.
- js/regress/string-prototype-search-observable-side-effects.html: Removed.
- js/regress/string-prototype-search-observable-side-effects2-expected.txt: Removed.
- js/regress/string-prototype-search-observable-side-effects2.html: Removed.
- js/regress/string-prototype-search-observable-side-effects3-expected.txt: Removed.
- js/regress/string-prototype-search-observable-side-effects3.html: Removed.
- js/regress/string-prototype-search-observable-side-effects4-expected.txt: Removed.
- js/regress/string-prototype-search-observable-side-effects4.html: Removed.
- js/regress/string-prototype-split-observable-side-effects-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects.html: Removed.
- js/regress/string-prototype-split-observable-side-effects2-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects2.html: Removed.
- js/regress/string-prototype-split-observable-side-effects3-flags-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects3-flags.html: Removed.
- js/regress/string-prototype-split-observable-side-effects3-global-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects3-global.html: Removed.
- js/regress/string-prototype-split-observable-side-effects3-ignoreCase-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects3-ignoreCase.html: Removed.
- js/regress/string-prototype-split-observable-side-effects3-multiline-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects3-multiline.html: Removed.
- js/regress/string-prototype-split-observable-side-effects3-sticky-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects3-sticky.html: Removed.
- js/regress/string-prototype-split-observable-side-effects3-unicode-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects3-unicode.html: Removed.
- js/regress/string-prototype-split-observable-side-effects4-expected.txt: Removed.
- js/regress/string-prototype-split-observable-side-effects4.html: Removed.
- js/regress/string-repeat-arith-expected.txt: Removed.
- js/regress/string-repeat-arith.html: Removed.
- js/regress/string-repeat-not-resolving-expected.txt: Removed.
- js/regress/string-repeat-not-resolving-fixed-expected.txt: Removed.
- js/regress/string-repeat-not-resolving-fixed.html: Removed.
- js/regress/string-repeat-not-resolving-no-inline-expected.txt: Removed.
- js/regress/string-repeat-not-resolving-no-inline.html: Removed.
- js/regress/string-repeat-not-resolving-noinline-expected.txt: Removed.
- js/regress/string-repeat-not-resolving-noinline.html: Removed.
- js/regress/string-repeat-not-resolving.html: Removed.
- js/regress/string-repeat-resolving-expected.txt: Removed.
- js/regress/string-repeat-resolving-fixed-expected.txt: Removed.
- js/regress/string-repeat-resolving-fixed.html: Removed.
- js/regress/string-repeat-resolving-no-inline-expected.txt: Removed.
- js/regress/string-repeat-resolving-no-inline.html: Removed.
- js/regress/string-repeat-resolving.html: Removed.
- js/regress/string-repeat-single-not-resolving-expected.txt: Removed.
- js/regress/string-repeat-single-not-resolving.html: Removed.
- js/regress/string-repeat-single-resolving-expected.txt: Removed.
- js/regress/string-repeat-single-resolving.html: Removed.
- js/regress/string-repeat-small-not-resolving-expected.txt: Removed.
- js/regress/string-repeat-small-not-resolving.html: Removed.
- js/regress/string-repeat-small-resolving-expected.txt: Removed.
- js/regress/string-repeat-small-resolving.html: Removed.
- js/regress/string-replace-empty-expected.txt: Removed.
- js/regress/string-replace-empty.html: Removed.
- js/regress/string-replace-expected.txt: Removed.
- js/regress/string-replace-generic-expected.txt: Removed.
- js/regress/string-replace-generic.html: Removed.
- js/regress/string-replace.html: Removed.
- js/regress/string-rope-with-object-expected.txt: Removed.
- js/regress/string-rope-with-object.html: Removed.
- js/regress/string-sub-expected.txt: Removed.
- js/regress/string-sub.html: Removed.
- js/regress/string-test-expected.txt: Removed.
- js/regress/string-test.html: Removed.
- js/regress/string-transcoding-expected.txt: Removed.
- js/regress/string-transcoding.html: Removed.
- js/regress/string-var-equality-expected.txt: Removed.
- js/regress/string-var-equality.html: Removed.
- js/regress/structure-hoist-over-transitions-expected.txt: Removed.
- js/regress/structure-hoist-over-transitions.html: Removed.
- js/regress/substring-concat-expected.txt: Removed.
- js/regress/substring-concat-weird-expected.txt: Removed.
- js/regress/substring-concat-weird.html: Removed.
- js/regress/substring-concat.html: Removed.
- js/regress/substring-expected.txt: Removed.
- js/regress/substring.html: Removed.
- js/regress/switch-char-constant-expected.txt: Removed.
- js/regress/switch-char-constant.html: Removed.
- js/regress/switch-char-expected.txt: Removed.
- js/regress/switch-char.html: Removed.
- js/regress/switch-constant-expected.txt: Removed.
- js/regress/switch-constant.html: Removed.
- js/regress/switch-expected.txt: Removed.
- js/regress/switch-string-basic-big-expected.txt: Removed.
- js/regress/switch-string-basic-big-var-expected.txt: Removed.
- js/regress/switch-string-basic-big-var.html: Removed.
- js/regress/switch-string-basic-big.html: Removed.
- js/regress/switch-string-basic-expected.txt: Removed.
- js/regress/switch-string-basic-var-expected.txt: Removed.
- js/regress/switch-string-basic-var.html: Removed.
- js/regress/switch-string-basic.html: Removed.
- js/regress/switch-string-big-length-tower-var-expected.txt: Removed.
- js/regress/switch-string-big-length-tower-var.html: Removed.
- js/regress/switch-string-length-tower-expected.txt: Removed.
- js/regress/switch-string-length-tower-var-expected.txt: Removed.
- js/regress/switch-string-length-tower-var.html: Removed.
- js/regress/switch-string-length-tower.html: Removed.
- js/regress/switch-string-short-expected.txt: Removed.
- js/regress/switch-string-short.html: Removed.
- js/regress/switch.html: Removed.
- js/regress/symbol-tostringtag-expected.txt: Removed.
- js/regress/symbol-tostringtag.html: Removed.
- js/regress/tear-off-arguments-expected.txt: Removed.
- js/regress/tear-off-arguments-simple-expected.txt: Removed.
- js/regress/tear-off-arguments-simple.html: Removed.
- js/regress/tear-off-arguments.html: Removed.
- js/regress/temporal-structure-expected.txt: Removed.
- js/regress/temporal-structure.html: Removed.
- js/regress/to-int32-boolean-expected.txt: Removed.
- js/regress/to-int32-boolean.html: Removed.
- js/regress/to-number-constructor-number-string-number-string-expected.txt: Removed.
- js/regress/to-number-constructor-number-string-number-string.html: Removed.
- js/regress/to-number-constructor-only-number-expected.txt: Removed.
- js/regress/to-number-constructor-only-number.html: Removed.
- js/regress/to-number-constructor-only-string-expected.txt: Removed.
- js/regress/to-number-constructor-only-string.html: Removed.
- js/regress/to-number-constructor-string-number-string-number-expected.txt: Removed.
- js/regress/to-number-constructor-string-number-string-number.html: Removed.
- js/regress/to-number-number-string-number-string-expected.txt: Removed.
- js/regress/to-number-number-string-number-string.html: Removed.
- js/regress/to-number-only-number-expected.txt: Removed.
- js/regress/to-number-only-number.html: Removed.
- js/regress/to-number-only-string-expected.txt: Removed.
- js/regress/to-number-only-string.html: Removed.
- js/regress/to-number-string-number-string-number-expected.txt: Removed.
- js/regress/to-number-string-number-string-number.html: Removed.
- js/regress/try-catch-get-by-val-cloned-arguments-expected.txt: Removed.
- js/regress/try-catch-get-by-val-cloned-arguments.html: Removed.
- js/regress/try-catch-get-by-val-direct-arguments-expected.txt: Removed.
- js/regress/try-catch-get-by-val-direct-arguments.html: Removed.
- js/regress/try-catch-get-by-val-scoped-arguments-expected.txt: Removed.
- js/regress/try-catch-get-by-val-scoped-arguments.html: Removed.
- js/regress/typed-array-get-set-by-val-profiling-expected.txt: Removed.
- js/regress/typed-array-get-set-by-val-profiling.html: Removed.
- js/regress/typed-array-subarray-expected.txt: Removed.
- js/regress/typed-array-subarray.html: Removed.
- js/regress/undefined-property-access-expected.txt: Removed.
- js/regress/undefined-property-access.html: Removed.
- js/regress/undefined-test-expected.txt: Removed.
- js/regress/undefined-test.html: Removed.
- js/regress/unprofiled-licm-expected.txt: Removed.
- js/regress/unprofiled-licm.html: Removed.
- js/regress/untyped-string-from-char-code-expected.txt: Removed.
- js/regress/untyped-string-from-char-code.html: Removed.
- js/regress/v8-raytrace-with-empty-try-catch-expected.txt: Removed.
- js/regress/v8-raytrace-with-empty-try-catch.html: Removed.
- js/regress/v8-raytrace-with-try-catch-expected.txt: Removed.
- js/regress/v8-raytrace-with-try-catch-high-frequency-throws-expected.txt: Removed.
- js/regress/v8-raytrace-with-try-catch-high-frequency-throws.html: Removed.
- js/regress/v8-raytrace-with-try-catch.html: Removed.
- js/regress/v8-regexp-search-expected.txt: Removed.
- js/regress/v8-regexp-search.html: Removed.
- js/regress/varargs-call-expected.txt: Removed.
- js/regress/varargs-call.html: Removed.
- js/regress/varargs-construct-expected.txt: Removed.
- js/regress/varargs-construct-inline-expected.txt: Removed.
- js/regress/varargs-construct-inline.html: Removed.
- js/regress/varargs-construct.html: Removed.
- js/regress/varargs-expected.txt: Removed.
- js/regress/varargs-inline-expected.txt: Removed.
- js/regress/varargs-inline.html: Removed.
- js/regress/varargs-strict-mode-expected.txt: Removed.
- js/regress/varargs-strict-mode.html: Removed.
- js/regress/varargs.html: Removed.
- js/regress/weird-inlining-const-prop-expected.txt: Removed.
- js/regress/weird-inlining-const-prop.html: Removed.
- 4:36 PM Changeset in webkit [204869] by
-
- 15 edits in trunk/Source/JavaScriptCore
Rebaseline builtins-generator-tests after r204854.
Unreviewed test gardening.
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
- Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
- Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result:
- 4:24 PM Changeset in webkit [204868] by
-
- 4 edits in trunk
%TypedArray%.prototype.slice needs to check that the source and destination have not been detached.
https://bugs.webkit.org/show_bug.cgi?id=161031
<rdar://problem/27937019>
Reviewed by Geoffrey Garen.
JSTests:
- stress/typedarray-slice.js:
(get let):
(get try):
(testSpeciesWithTransferring):
Source/JavaScriptCore:
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncSlice):
- 4:21 PM Changeset in webkit [204867] by
-
- 2 edits in trunk/LayoutTests
Skip some tests:
https://bugs.webkit.org/show_bug.cgi?id=161114 svg/carto.net/window.svg fails in debug after r204854
https://bugs.webkit.org/show_bug.cgi?id=161115 js/regress/put-by-id-transition-with-indexing-header.html sometimes fails in debug after r204854
- 4:19 PM Changeset in webkit [204866] by
-
- 9 edits in trunk/Source/JavaScriptCore
REGRESSION(204854): ASan is unhappy
https://bugs.webkit.org/show_bug.cgi?id=161109
Reviewed by Geoffrey Garen.
I messed up RegExpConstructor: it ends up being a callee and a large allocation.
This fixes it to not be a large allocation.
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::InternalFunction):
- runtime/RegExp.cpp:
(JSC::RegExp::match):
(JSC::RegExp::matchConcurrently):
(JSC::RegExp::matchCompareWithInterpreter):
- runtime/RegExp.h:
- runtime/RegExpConstructor.h:
- runtime/RegExpInlines.h:
(JSC::RegExp::matchInline):
- runtime/RegExpPrototype.cpp:
(JSC::genericSplit):
- testRegExp.cpp:
(testOneRegExp):
- 4:16 PM Changeset in webkit [204865] by
-
- 79 edits2 adds in trunk/LayoutTests
Unreviewed, rebase iOS simulator WK1 editing tests.
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-contents-003-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-018-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-022-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-br-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-br-003-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-br-010-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-character-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-contiguous-ws-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-emoji-expected.txt: Added.
- platform/ios-simulator-wk1/editing/deleting/delete-hr-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-image-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-image-002-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-image-003-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-002-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-003-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-005-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-007-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-009-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-010-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-013-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-015-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-line-017-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-listitem-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-listitem-002-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-selection-001-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/delete-ws-fixup-002-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/list-item-1-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/merge-unrendered-space-expected.txt:
- platform/ios-simulator-wk1/editing/deleting/non-smart-delete-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-3778059-fix-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-br-at-tabspan-003-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-br-quoted-001-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-br-quoted-004-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-br-quoted-006-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-012-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-014-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-017-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-018-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-020-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-022-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-025-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-div-027-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-html-crash-01-expected.txt: Added.
- platform/ios-simulator-wk1/editing/inserting/insert-paragraph-04-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-text-at-tabspan-001-expected.txt:
- platform/ios-simulator-wk1/editing/inserting/insert-text-at-tabspan-003-expected.txt:
- platform/ios-simulator-wk1/editing/selection/5057506-2-expected.txt:
- platform/ios-simulator-wk1/editing/selection/5057506-expected.txt:
- platform/ios-simulator-wk1/editing/selection/5131716-1-expected.txt:
- platform/ios-simulator-wk1/editing/selection/5131716-2-expected.txt:
- platform/ios-simulator-wk1/editing/selection/5131716-3-expected.txt:
- platform/ios-simulator-wk1/editing/selection/5131716-4-expected.txt:
- platform/ios-simulator-wk1/editing/style/block-styles-007-expected.txt:
- platform/ios-simulator-wk1/editing/style/create-block-for-style-002-expected.txt:
- platform/ios-simulator-wk1/editing/style/create-block-for-style-003-expected.txt:
- platform/ios-simulator-wk1/editing/style/create-block-for-style-010-expected.txt:
- platform/ios-simulator-wk1/editing/style/create-block-for-style-012-expected.txt:
- platform/ios-simulator-wk1/editing/style/create-block-for-style-013-expected.txt:
- platform/ios-simulator-wk1/editing/style/relative-font-size-change-002-expected.txt:
- platform/ios-simulator-wk1/editing/style/relative-font-size-change-004-expected.txt:
- platform/ios-simulator-wk1/editing/style/style-3998892-fix-expected.txt:
- platform/ios-simulator-wk1/editing/style/style-boundary-004-expected.txt:
- platform/ios-simulator-wk1/editing/undo/undo-delete-expected.txt:
- 3:50 PM Changeset in webkit [204864] by
-
- 2 edits in trunk/Tools
Fix EFL build.
- TestWebKitAPI/CMakeLists.txt:
Include new directory.
- 3:48 PM Changeset in webkit [204863] by
-
- 2 edits in trunk/Source/WebCore
Fix clean Windows build.
- PlatformWin.cmake:
Add another forwarding headers directory.
- 3:23 PM Changeset in webkit [204862] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: resource tree elements should provide "Download File" context menu items
https://bugs.webkit.org/show_bug.cgi?id=158035
Patch by Devin Rousso <Devin Rousso> on 2016-08-23
Reviewed by Joseph Pecoraro.
Add a context menu item to elements representing resources that
initiates a download of that resource.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Main.js:
(WebInspector.saveDataToFile):
Add support for saving base64 objects.
- UserInterface/Base/MIMETypeUtilities.js:
(WebInspector.fileExtensionForMIMEType):
Returns a file extension for the given MIME type if able.
- UserInterface/Views/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype.onattach):
Add contextmenu event listener since superclass onattach call is explicitly not used.
- UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.appendContextMenuItems):
Add Save File context menu item.
- UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype.onattach):
(WebInspector.ResourceTreeElement.prototype._handleContextMenuEvent):
Add contextmenu event listener and Save File context menu item.
- 3:16 PM Changeset in webkit [204861] by
-
- 2 edits in trunk/Source/JavaScriptCore
strict mode eval should not fire the var injection watch point
https://bugs.webkit.org/show_bug.cgi?id=161104
Reviewed by Geoffrey Garen.
Strict mode eval can't do any variable injections. It was
an oversight that we fired the var injection watchpoint when
the eval is in strict mode.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- 2:47 PM Changeset in webkit [204860] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: hasOverflowingCell == this->hasOverflowingCell() in WebCore::RenderTableSection::computeOverflowFromCells
https://bugs.webkit.org/show_bug.cgi?id=155702
<rdar://problem/27720731>
Reviewed by David Hyatt.
Source/WebCore:
The simplified layout path for table/section should also clear the slow path flag for visual overflow (since it recomputes
the overflow for the descendant cells).
Test: fast/table/assert-when-visual-overflow-is-cleared.html
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layout):
LayoutTests:
- fast/table/assert-when-visual-overflow-is-cleared-expected.txt: Added.
- fast/table/assert-when-visual-overflow-is-cleared.html: Added.
- 2:29 PM Changeset in webkit [204859] by
-
- 2 edits in trunk/Source/WebKit2
Another CMake build fix attempt after r204852.
- CMakeLists.txt:
- 2:11 PM Changeset in webkit [204858] by
-
- 17 edits2 deletes in trunk/Source/WebCore
[Cocoa] Reduce uses of CGFonts
https://bugs.webkit.org/show_bug.cgi?id=160896
Reviewed by Darin Adler.
There are a few places where we unnecessarily use CGFonts instead of
CTFonts. We have had an ongoing effort throughout the past few years
of elliminating all of our uses of CGFonts, and this patch moves us
in that direction.
Most of the changes in this patch are straightforward (e.g.
CGFontGetUnitsPerEm() -> CTFontGetUnitsPerEm()). However, there is
one notable change: from CGContextShowGlyphsWithAdvances() to
CTFontDrawGlyphs(). This migration does not cause a performance
regression.
No new tests because there is no behavior change.
- WebCore.xcodeproj/project.pbxproj: Delete unnecessary
FontServicesIOS files.
- platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::xHeight): Migrate to Optional<float>
(WebCore::FontMetrics::setXHeight):
(WebCore::FontMetrics::hasXHeight):
(WebCore::FontMetrics::hasCapHeight): Ditto.
(WebCore::FontMetrics::floatCapHeight):
(WebCore::FontMetrics::setCapHeight):
(WebCore::FontMetrics::capHeight):
(WebCore::FontMetrics::setZeroWidth): No one ever used the
m_hasZeroWidth variable, so this patch removes it.
(WebCore::FontMetrics::reset):
(WebCore::FontMetrics::FontMetrics): Deleted.
(WebCore::FontMetrics::setHasXHeight): Deleted. No one ever calls
this, so this patch removes it.
(WebCore::FontMetrics::hasZeroWidth): Deleted.
(WebCore::FontMetrics::setHasZeroWidth): Deleted.
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::TextMatrixRestorer::TextMatrixRestorer): Rather than leaving
the text matrix stale after using it, this class cleans it up after us.
This means that the text matrix doesn't have to be reset in other places
which draw text.
(WebCore::TextMatrixRestorer::~TextMatrixRestorer):
(WebCore::TextMatrixRestorer::savedMatrix):
(WebCore::showGlyphsWithAdvances): Migrate from
CGContextShowGlyphsWithAdvances() to CTFontDrawGlyphs()
(WebCore::FontCascade::drawGlyphs): See above comment about the text
matrix.
(WebCore::RenderingStyleSaver::RenderingStyleSaver): Deleted.
(WebCore::RenderingStyleSaver::~RenderingStyleSaver): Deleted.
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::shouldUseAdjustment): Taken from FontServicesIOS.
(WebCore::Font::platformInit): Migrate from CG to CT for some direct
replacement API calls.
(WebCore::Font::platformCharWidthInit): Ditto.
(WebCore::Font::determinePitch): Ditto.
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::openTypeTable): Ditto.
(WebCore::FontPlatformData::description): Ditto.
- platform/graphics/ios/FontServicesIOS.h: Removed. No longer needed
after migrating from CGContextShowGlyphsWithAdvances() to
CTFontDrawGlyphs().
(WebCore::FontServicesIOS::ascent): Deleted.
(WebCore::FontServicesIOS::descent): Deleted.
(WebCore::FontServicesIOS::lineGap): Deleted.
(WebCore::FontServicesIOS::lineSpacing): Deleted.
(WebCore::FontServicesIOS::xHeight): Deleted.
(WebCore::FontServicesIOS::capHeight): Deleted.
(WebCore::FontServicesIOS::unitsPerEm): Deleted.
- platform/graphics/ios/FontServicesIOS.mm: Removed. Moved into
Font::platformInit().
(WebCore::shouldUseAdjustment): Deleted.
(WebCore::isCourier): Deleted.
(WebCore::FontServicesIOS::FontServicesIOS): Deleted.
- platform/graphics/opentype/OpenTypeCG.cpp:
(WebCore::OpenType::tryGetTypoMetrics): Migrate from CG to CT for some
direct replacement API calls.
- platform/graphics/opentype/OpenTypeCG.h: Ditto.
- platform/graphics/win/FontCGWin.cpp:
(WebCore::FontCascade::drawGlyphs): Restore the text matrix.
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::Font::platformWidthForGlyph): Deleted.
- platform/spi/cg/CoreGraphicsSPI.h:
- platform/spi/cocoa/CoreTextSPI.h:
- rendering/RenderThemeIOS.mm:
(WebCore::paintAttachmentText): Deleted.
- rendering/RenderThemeMac.mm:
(WebCore::paintAttachmentTitle): Deleted.
(WebCore::paintAttachmentSubtitle): Deleted.
- 1:43 PM Changeset in webkit [204857] by
-
- 2 edits in trunk/Source/JavaScriptCore
Spilling of constant tmps should make it easier for the spill code optimizer to rematerialize the constant
https://bugs.webkit.org/show_bug.cgi?id=160150
Reviewed by Benjamin Poulain.
When we spill in-place for admitsStack()==true, we prevent rematerialization if that
argument doesn't also admit immediates (which it almost certainly won't do). So, we
prevent remat.
This fixes the issue by avoiding in-place spilling for warm uses of constants. I don't
know if this helps performance, but I do know that it make the codegen for
bigswitch-indirect-symbol look a lot better. Prior to this change, the prolog would have
a constant materialization for each symbol that function used, and then it would spill
that constant. This removes all of that yucky code.
This also changes how IRC detects constant Tmps. Previously we would say that a Tmp is a
constant if the number of const defs was equal to the number of defs. But it's possible
for each of the const defs to produce a different value. This is unlikely considering
how B3->Air lowering works and how our SSA works - each def would have its own register.
But, regardless, this picks a more precise way of detecting constants: the number of
const defs must be 1 and the number of defs must be 1.
- b3/air/AirIteratedRegisterCoalescing.cpp:
- 1:29 PM Changeset in webkit [204856] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, fix CLoop build.
This fixes the CLoop build while still ensuring that Interpreter.h is a project header.
- llint/LowLevelInterpreter.cpp:
- runtime/VM.cpp:
(JSC::VM::ensureStackCapacityForCLoop):
(JSC::VM::isSafeToRecurseSoftCLoop):
- runtime/VM.h:
- runtime/VMInlines.h:
(JSC::VM::ensureStackCapacityFor):
(JSC::VM::isSafeToRecurseSoft):
- 1:20 PM Changeset in webkit [204855] by
-
- 2 edits in trunk/Source/WebCore
Fix CMake build after r204852.
- CMakeLists.txt:
There were some non-ASCII characters here causing problems.
- 12:52 PM Changeset in webkit [204854] by
-
- 268 edits19 adds1 delete in trunk
Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
https://bugs.webkit.org/show_bug.cgi?id=160125
Reviewed by Geoffrey Garen.
JSTests:
Most of the things I did properly covered by existing tests, but I found some simple cases of
unshifting that had sketchy coverage.
- stress/array-storage-array-unshift.js: Added.
- stress/contiguous-array-unshift.js: Added.
- stress/double-array-unshift.js: Added.
- stress/int32-array-unshift.js: Added.
Source/bmalloc:
I needed to tryMemalign, so I added such a thing.
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::allocate):
(bmalloc::Allocator::tryAllocate):
(bmalloc::Allocator::allocateImpl):
(bmalloc::Allocator::reallocate):
- bmalloc/Allocator.h:
- bmalloc/Cache.h:
(bmalloc::Cache::allocate):
(bmalloc::Cache::tryAllocate):
- bmalloc/bmalloc.h:
(bmalloc::api::malloc):
(bmalloc::api::tryMemalign):
(bmalloc::api::memalign):
Source/JavaScriptCore:
In order to make the GC concurrent (bug 149432), we would either need to enable concurrent
copying or we would need to not copy. Concurrent copying carries a 1-2% throughput overhead
from the barriers alone. Considering that MarkedSpace does a decent job of avoiding
fragmentation, it's unlikely that it's worth paying 1-2% throughput for copying. So, we want
to get rid of copied space. This change moves copied space's biggest client over to marked
space.
Moving butterflies to marked space means having them use the new Auxiliary HeapCell
allocation path. This is a fairly mechanical change, but it caused performance regressions
everywhere, so this change also fixes MarkedSpace's performance issues.
At a high level the mechanical changes are:
- We use AuxiliaryBarrier instead of CopyBarrier.
- We use tryAllocateAuxiliary instead of tryAllocateStorage. I got rid of the silly CheckedBoolean stuff, since it's so much more trouble than it's worth.
- The JITs have to emit inlined marked space allocations instead of inline copy space allocations.
- Everyone has to get used to zeroing their butterflies after allocation instead of relying on them being pre-zeroed by the GC. Copied space would zero things for you, while marked space doesn't.
That's about 1/3 of this change. But this led to performance problems, which I fixed with
optimizations that amounted to a major MarkedSpace rewrite:
- MarkedSpace always causes internal fragmentation for array allocations because the vector length we choose when we resize usually leads to a cell size that doesn't correspond to any size class. I got around this by making array allocations usually round up vectorLength to the maximum allowed by the size class that we would have allocated in. Also, ensureLengthSlow() and friends first make sure that the requested length can't just be fulfilled with the current allocation size. This safeguard means that not every array allocation has to do size class queries. For example, the fast path of new Array(length) never does any size class queries, under the assumption that (1) the speed gained from avoiding an ensureLengthSlow() call, which then just changes the vectorLength by doing the size class query, is too small to offset the speed lost by doing the query on every allocation and (2) new Array(length) is a pretty good hint that resizing is not very likely.
- Size classes in MarkedSpace were way too precise, which led to external fragmentation. This changes MarkedSpace size classes to use a linear progression for very small sizes followed by a geometric progression that naturally transitions to a hyperbolic progression. We want hyperbolic sizes when we get close to blockSize: for example the largest size we want is payloadSize / 2 rounded down, to ensure we get exactly two cells with minimal slop. The next size down should be payloadSize / 3 rounded down, and so on. After the last precise size (80 bytes), we proceed using a geometric progression, but round up each size to minimize slop at the end of the block. This naturally causes the geometric progression to turn hyperbolic for large sizes. The size class configuration happens at VM start-up, so can be controlled with runtime options. I found that a base of 1.4 works pretty well.
- Large allocations caused massive internal fragmentation, since the smallest large allocation had to use exactly blockSize, and the largest small allocation used blockSize / 2. The next size up - the first large allocation size to require two blocks - also had 50% internal fragmentation. This is because we required large allocations to be blockSize aligned, so that MarkedBlock::blockFor() would work. I decided to rewrite all of that. Cells no longer have to be owned by a MarkedBlock. They can now alternatively be owned by a LargeAllocation. These two things are abstracted as CellContainer. You know that a cell is owned by a LargeAllocation if the MarkedBlock::atomSize / 2 bit is set. Basically, large allocations are deliberately misaligned by 8 bytes. This actually works out great since (1) typed arrays won't use large allocations anyway since they have their own malloc fallback and (2) large array butterflies already have a 8 byte header, which means that the 8 byte base misalignment aligns the large array payload on a 16 byte boundary. I took extreme care to make sure that the isLargeAllocation bit checks are as rare as possible; for example, ExecState::vm() skips the check because we know that callees must be small allocations. It's also possible to use template tricks to do one check for cell container kind, and then invoke a function specialized for MarkedBlock or a function specialized for LargeAllocation. LargeAllocation includes stubs for all MarkedBlock methods that get used from functions that are template-specialized like this. That's mostly to speed up the GC marking code. Most other code can use CellContainer API or HeapCell API directly. That's another thing: HeapCell, the common base of JSCell and auxiliary allocations, is now smart enough to do a lot of things for you, like HeapCell::vm(), HeapCell::heap(), HeapCell::isLargeAllocation(), and HeapCell::cellContainer(). The size cutoff for large allocations is runtime-configurable, so long as you don't choose something so small that callees end up large. I found that 400 bytes is roughly optimal. This means that the MarkedBlock size classes end up being:
16, 32, 48, 64, 80, 112, 160, 224, 320
The next size class would have been 432, but that's above the 400 byte cutoff. All of this
is configurable with --sizeClassProgression and --largeAllocationCutoff. You can see what
size classes you end up with by doing --dumpSizeClasses=true.
- Copied space uses 64KB blocks, while marked space used to use 16KB blocks. Allocating a lot of stuff in 16KB blocks is slower than allocating it in 64KB blocks. I got more speed from changing MarkedBlock::blockSize to 64KB. This would have been a space fail before, but now that we have LargeAllocation, it ends up being an overall win.
- Even after all of that, copying butterflies was still faster because it allowed us to skip sweeping dead space. A good GC allocates over dead bytes without explicitly freeing them, so the GC pause is O(size of live), not O(size of live + dead). O(dead) is usually much larger than O(live), especially in an eden collection. Copying satisfies this premise while mark+sweep does not. So, I invented a new kind of allocator: bump'n'pop. Previously, our MarkedSpace allocator was a freelist pop. That's simple and easy to inline but requires that we walk the block to build a free list. This means walking dead space. The new allocator allows totally free MarkedBlocks to simply set up a bump-pointer arena instead. The allocator is a hybrid of bump-pointer and freelist pop. It tries bump first. The bump pointer always bumps by cellSize, so the result of filling a block with bumping looks as if we had used freelist popping to fill it. Additionally, each MarkedBlock now has a bit to quickly tell if the block is entirely free. This makes sweeping O(1) whenever a MarkedBlock is completely empty, which is the common case because of the generational hypothesis: the number of objects that survive an eden collection is a tiny fraction of the number of objects that had been allocated, and this fraction is so small that there are typically fewer than one survivors per MarkedBlock. This change was enough to make this change a net win over tip-of-tree.
- FTL now shares the same allocation fast paths as everything else, which is great, because bump'n'pop has gnarly control flow. We don't really want B3 to have to think about that control flow, since it won't be able to improve the machine code we write ourselves. GC fast paths are best written in assembly. So, I've empowered B3 to have even better support for Patchpoint terminals. It's now totally fine for a Patchpoint terminal to be non-Void. So, the new FTL allocation fast paths are just Patchpoint terminals that call through to AssemblyHelpers::emitAllocate(). B3 still reasons about things like constant-folding the size class calculation and constant-hoisting the allocator. Also, I gave the FTL the ability to constant-fold some allocator logic (in case we first assume that we're doing a variable-length allocation but then realize that the length is known). I think it makes sense to have constant folding rules in FTL::Output, or whatever the B3 IR builder is, since this makes lowering easier (you can constant fold during lowering more easily) and it reduces the amount of malloc traffic. In the future, we could teach B3 how to better constant-fold this code. That would require allowing loads to be constant-folded, which is doable but hella tricky.
All of this put together gives us neutral perf on JetStream, Speedometer, and PLT3. SunSpider
sometimes gets penalized depending on how you run it. By comparison, the alternative approach
of using a copy barrier would have cost us 1-2%. That's the real apples-to-apples comparison
if your premise is that we should have a concurrent GC. After we finish removing copied
space, we will be barrier-ready for concurrent GC: we already have a marking barrier and we
simply won't need a copying barrier. This change gets us there for the purposes of our
benchmarks, since the remaining clients of copied space are not very important. On the other
hand, if we keep copying, then getting barrier-ready would mean adding back the copy barrier,
which costs more perf.
We might get bigger speed-ups once we remove CopiedSpace altogether. That requires moving
typed arrays and a few other weird things over to Aux MarkedSpace.
This also includes some header sanitization. The introduction of AuxiliaryBarrier, HeapCell,
and CellContainer meant that I had to include those files from everywhere. Fortunately,
just including JSCInlines.h (instead of manually including the files that includes) is
usually enough. So, I made most of JSC's cpp files include JSCInlines.h, which is something
that we were already basically doing. In places where JSCInlines.h would be too much, I just
included HeapInlines.h. This got weird, because we previously included HeapInlines.h from
JSObject.h. That's bad because it led to some circular dependencies, so I fixed it - but that
meant having to manually include HeapInlines.h from the places that previously got it
implicitly via JSObject.h. But that led to more problems for some reason: I started getting
build errors because non-JSC files were having trouble including Opcode.h. That's just silly,
since Opcode.h is meant to be an internal JSC header. So, I made it an internal header and
made it impossible to include it from outside JSC. This was a lot of work, but it was
necessary to get the patch to build on all ports. It's also a net win. There were many places
in WebCore that were transitively including a *ton* of JSC headers just because of the
JSObject.h->HeapInlines.h edge and a bunch of dependency edges that arose from some public
(for WebCore) JSC headers needing Interpreter.h or Opcode.h for bad reasons.
- API/JSTypedArray.cpp:
- API/ObjCCallbackFunction.mm:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/builtins/builtins_generate_combined_implementation.py:
(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):
- Scripts/builtins/builtins_generate_internals_wrapper_implementation.py:
(BuiltinsInternalsWrapperImplementationGenerator.generate_secondary_header_includes):
- Scripts/builtins/builtins_generate_separate_implementation.py:
(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::JumpList::JumpList):
(JSC::AbstractMacroAssembler::JumpList::link):
(JSC::AbstractMacroAssembler::JumpList::linkTo):
(JSC::AbstractMacroAssembler::JumpList::append):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add32):
- b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::appendIntConstant):
(JSC::B3::BasicBlock::appendBoolConstant):
(JSC::B3::BasicBlock::clearSuccessors):
- b3/B3BasicBlock.h:
- b3/B3DuplicateTails.cpp:
- b3/B3StackmapGenerationParams.h:
- b3/testb3.cpp:
(JSC::B3::testBranchBitAndImmFusion):
(JSC::B3::testPatchpointTerminalReturnValue):
(JSC::B3::zero):
(JSC::B3::run):
- bindings/ScriptValue.cpp:
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
- bytecode/ObjectAllocationProfile.h:
(JSC::ObjectAllocationProfile::initialize):
- bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generateImpl):
- bytecode/StructureStubInfo.cpp:
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCompile.cpp:
- ftl/FTLJITFinalizer.cpp:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::initializeArrayElements):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::emitRightShiftSnippet):
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):
(JSC::FTL::DFG::LowerDFGToB3::storeStructure):
(JSC::FTL::DFG::LowerDFGToB3::allocateCell):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatorForSize):
(JSC::FTL::DFG::LowerDFGToB3::allocateVariableSizedObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::add):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::select):
(JSC::FTL::Output::unreachable):
(JSC::FTL::Output::appendSuccessor):
(JSC::FTL::Output::speculate):
(JSC::FTL::Output::addIncomingToPhi):
- ftl/FTLOutput.h:
- ftl/FTLValueFromBlock.h:
(JSC::FTL::ValueFromBlock::ValueFromBlock):
(JSC::FTL::ValueFromBlock::operator bool):
(JSC::FTL::ValueFromBlock::value):
(JSC::FTL::ValueFromBlock::block):
- ftl/FTLWeightedTarget.h:
(JSC::FTL::WeightedTarget::target):
(JSC::FTL::WeightedTarget::weight):
(JSC::FTL::WeightedTarget::frequentedBlock):
- heap/CellContainer.h: Added.
(JSC::CellContainer::CellContainer):
(JSC::CellContainer::operator bool):
(JSC::CellContainer::isMarkedBlock):
(JSC::CellContainer::isLargeAllocation):
(JSC::CellContainer::markedBlock):
(JSC::CellContainer::largeAllocation):
- heap/CellContainerInlines.h: Added.
(JSC::CellContainer::isMarkedOrRetired):
(JSC::CellContainer::isMarked):
(JSC::CellContainer::isMarkedOrNewlyAllocated):
(JSC::CellContainer::setHasAnyMarked):
(JSC::CellContainer::cellSize):
(JSC::CellContainer::weakSet):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
- heap/ConservativeRoots.h:
(JSC::ConservativeRoots::size):
(JSC::ConservativeRoots::roots):
- heap/CopyToken.h:
- heap/FreeList.cpp: Added.
(JSC::FreeList::dump):
- heap/FreeList.h: Added.
(JSC::FreeList::FreeList):
(JSC::FreeList::list):
(JSC::FreeList::bump):
(JSC::FreeList::operator==):
(JSC::FreeList::operator!=):
(JSC::FreeList::operator bool):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::gatherStackRoots):
(JSC::Heap::gatherJSStackRoots):
(JSC::Heap::gatherScratchBufferRoots):
(JSC::Heap::clearLivenessData):
(JSC::Heap::visitSmallStrings):
(JSC::Heap::visitConservativeRoots):
(JSC::Heap::removeDeadCompilerWorklistEntries):
(JSC::Heap::gatherExtraHeapSnapshotData):
(JSC::Heap::removeDeadHeapSnapshotNodes):
(JSC::Heap::visitProtectedObjects):
(JSC::Heap::visitArgumentBuffers):
(JSC::Heap::visitException):
(JSC::Heap::visitStrongHandles):
(JSC::Heap::visitHandleStack):
(JSC::Heap::visitSamplingProfiler):
(JSC::Heap::traceCodeBlocksAndJITStubRoutines):
(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::clearUnmarkedExecutables):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::collectWithoutAnySweep):
(JSC::Heap::collectImpl):
(JSC::Heap::suspendCompilerThreads):
(JSC::Heap::willStartCollection):
(JSC::Heap::flushOldStructureIDTables):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::stopAllocation):
(JSC::Heap::reapWeakHandles):
(JSC::Heap::pruneStaleEntriesFromWeakGCMaps):
(JSC::Heap::sweepArrayBuffers):
(JSC::Heap::snapshotMarkedSpace):
(JSC::Heap::deleteSourceProviderCaches):
(JSC::Heap::notifyIncrementalSweeper):
(JSC::Heap::writeBarrierCurrentlyExecutingCodeBlocks):
(JSC::Heap::resetAllocators):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::resumeCompilerThreads):
(JSC::Zombify::visit):
- heap/Heap.h:
(JSC::Heap::subspaceForObjectDestructor):
(JSC::Heap::subspaceForAuxiliaryData):
(JSC::Heap::allocatorForObjectWithoutDestructor):
(JSC::Heap::allocatorForObjectWithDestructor):
(JSC::Heap::allocatorForAuxiliaryData):
(JSC::Heap::storageAllocator):
- heap/HeapCell.h:
(JSC::HeapCell::zap):
(JSC::HeapCell::isZapped):
- heap/HeapCellInlines.h: Added.
(JSC::HeapCell::isLargeAllocation):
(JSC::HeapCell::cellContainer):
(JSC::HeapCell::markedBlock):
(JSC::HeapCell::largeAllocation):
(JSC::HeapCell::heap):
(JSC::HeapCell::vm):
(JSC::HeapCell::cellSize):
(JSC::HeapCell::allocatorAttributes):
(JSC::HeapCell::destructionMode):
(JSC::HeapCell::cellKind):
- heap/HeapInlines.h:
(JSC::Heap::isCollecting):
(JSC::Heap::heap):
(JSC::Heap::isLive):
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::setMarked):
(JSC::Heap::cellSize):
(JSC::Heap::writeBarrier):
(JSC::Heap::allocateWithoutDestructor):
(JSC::Heap::allocateObjectOfType):
(JSC::Heap::subspaceForObjectOfType):
(JSC::Heap::allocatorForObjectOfType):
(JSC::Heap::allocateAuxiliary):
(JSC::Heap::tryAllocateAuxiliary):
(JSC::Heap::tryReallocateAuxiliary):
(JSC::Heap::tryAllocateStorage):
(JSC::Heap::didFreeBlock):
(JSC::Heap::isPointerGCObject): Deleted.
(JSC::Heap::isValueGCObject): Deleted.
- heap/HeapUtil.h: Added.
(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):
(JSC::HeapUtil::isValueGCObject):
- heap/LargeAllocation.cpp: Added.
(JSC::LargeAllocation::tryCreate):
(JSC::LargeAllocation::LargeAllocation):
(JSC::LargeAllocation::lastChanceToFinalize):
(JSC::LargeAllocation::shrink):
(JSC::LargeAllocation::visitWeakSet):
(JSC::LargeAllocation::reapWeakSet):
(JSC::LargeAllocation::clearMarks):
(JSC::LargeAllocation::clearMarksWithCollectionType):
(JSC::LargeAllocation::isEmpty):
(JSC::LargeAllocation::sweep):
(JSC::LargeAllocation::destroy):
(JSC::LargeAllocation::dump):
- heap/LargeAllocation.h: Added.
(JSC::LargeAllocation::fromCell):
(JSC::LargeAllocation::cell):
(JSC::LargeAllocation::isLargeAllocation):
(JSC::LargeAllocation::heap):
(JSC::LargeAllocation::vm):
(JSC::LargeAllocation::weakSet):
(JSC::LargeAllocation::clearNewlyAllocated):
(JSC::LargeAllocation::isNewlyAllocated):
(JSC::LargeAllocation::isMarked):
(JSC::LargeAllocation::isMarkedOrNewlyAllocated):
(JSC::LargeAllocation::isLive):
(JSC::LargeAllocation::hasValidCell):
(JSC::LargeAllocation::cellSize):
(JSC::LargeAllocation::aboveLowerBound):
(JSC::LargeAllocation::belowUpperBound):
(JSC::LargeAllocation::contains):
(JSC::LargeAllocation::attributes):
(JSC::LargeAllocation::testAndSetMarked):
(JSC::LargeAllocation::setMarked):
(JSC::LargeAllocation::clearMarked):
(JSC::LargeAllocation::setHasAnyMarked):
(JSC::LargeAllocation::headerSize):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::isListPagedOut):
(JSC::MarkedAllocator::isPagedOut):
(JSC::MarkedAllocator::retire):
(JSC::MarkedAllocator::tryAllocateWithoutCollectingImpl):
(JSC::MarkedAllocator::tryAllocateWithoutCollecting):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::tryAllocateSlowCase):
(JSC::MarkedAllocator::allocateSlowCaseImpl):
(JSC::blockHeaderSize):
(JSC::MarkedAllocator::blockSizeForBytes):
(JSC::MarkedAllocator::tryAllocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::lastChanceToFinalize):
(JSC::MarkedAllocator::setFreeList):
(JSC::MarkedAllocator::tryAllocateHelper): Deleted.
(JSC::MarkedAllocator::tryPopFreeList): Deleted.
(JSC::MarkedAllocator::tryAllocate): Deleted.
(JSC::MarkedAllocator::allocateBlock): Deleted.
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::destruction):
(JSC::MarkedAllocator::cellKind):
(JSC::MarkedAllocator::heap):
(JSC::MarkedAllocator::takeLastActiveBlock):
(JSC::MarkedAllocator::offsetOfFreeList):
(JSC::MarkedAllocator::offsetOfCellSize):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::stopAllocating):
(JSC::MarkedAllocator::resumeAllocating):
(JSC::MarkedAllocator::offsetOfFreeListHead): Deleted.
(JSC::MarkedAllocator::MarkedAllocator): Deleted.
(JSC::MarkedAllocator::init): Deleted.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::tryCreate):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelperSelectResetMode):
(JSC::MarkedBlock::sweepHelperSelectStateAndSweepMode):
(JSC::MarkedBlock::stopAllocating):
(JSC::MarkedBlock::clearMarksWithCollectionType):
(JSC::MarkedBlock::lastChanceToFinalize):
(JSC::MarkedBlock::resumeAllocating):
(JSC::MarkedBlock::didRetireBlock):
(JSC::MarkedBlock::forEachFreeCell):
(JSC::MarkedBlock::create): Deleted.
(JSC::MarkedBlock::callDestructor): Deleted.
(JSC::MarkedBlock::sweepHelper): Deleted.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::VoidFunctor::returnValue):
(JSC::MarkedBlock::setHasAnyMarked):
(JSC::MarkedBlock::hasAnyMarked):
(JSC::MarkedBlock::clearHasAnyMarked):
(JSC::MarkedBlock::firstAtom):
(JSC::MarkedBlock::isAtomAligned):
(JSC::MarkedBlock::cellAlign):
(JSC::MarkedBlock::blockFor):
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::cellSize):
(JSC::MarkedBlock::isMarkedOrRetired):
(JSC::MarkedBlock::FreeList::FreeList): Deleted.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::initializeSizeClassForStepSize):
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::allocateLarge):
(JSC::MarkedSpace::tryAllocateLarge):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::sweepABit):
(JSC::MarkedSpace::sweepLargeAllocations):
(JSC::MarkedSpace::zombifySweep):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
(JSC::MarkedSpace::stopAllocating):
(JSC::MarkedSpace::resumeAllocating):
(JSC::MarkedSpace::isPagedOut):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearNewlyAllocated):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::didFinishIterating):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::forEachAllocator): Deleted.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::sizeClassIndex):
(JSC::MarkedSpace::subspaceForObjectsWithDestructor):
(JSC::MarkedSpace::subspaceForObjectsWithoutDestructor):
(JSC::MarkedSpace::subspaceForAuxiliaryData):
(JSC::MarkedSpace::blocksWithNewObjects):
(JSC::MarkedSpace::largeAllocations):
(JSC::MarkedSpace::largeAllocationsNurseryOffset):
(JSC::MarkedSpace::largeAllocationsOffsetForThisCollection):
(JSC::MarkedSpace::largeAllocationsForThisCollectionBegin):
(JSC::MarkedSpace::largeAllocationsForThisCollectionEnd):
(JSC::MarkedSpace::largeAllocationsForThisCollectionSize):
(JSC::MarkedSpace::forEachLiveCell):
(JSC::MarkedSpace::forEachDeadCell):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::destructorAllocatorFor):
(JSC::MarkedSpace::auxiliaryAllocatorFor):
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::tryAllocate):
(JSC::MarkedSpace::allocateWithoutDestructor):
(JSC::MarkedSpace::allocateWithDestructor):
(JSC::MarkedSpace::allocateAuxiliary):
(JSC::MarkedSpace::tryAllocateAuxiliary):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::forEachAllocator):
(JSC::MarkedSpace::forEachSubspace):
(JSC::MarkedSpace::optimalSizeFor):
(JSC::MarkedSpace::objectCount): Deleted.
(JSC::MarkedSpace::size): Deleted.
(JSC::MarkedSpace::capacity): Deleted.
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::clearMarkStack):
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendJSCellOrAuxiliary):
(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::markAuxiliary):
(JSC::SlotVisitor::noteLiveAuxiliaryCell):
(JSC::SetCurrentCellScope::SetCurrentCellScope):
(JSC::SlotVisitor::visitChildren):
- heap/SlotVisitor.h:
- heap/WeakBlock.cpp:
(JSC::WeakBlock::create):
(JSC::WeakBlock::destroy):
(JSC::WeakBlock::WeakBlock):
(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):
- heap/WeakBlock.h:
(JSC::WeakBlock::disconnectContainer):
(JSC::WeakBlock::disconnectMarkedBlock): Deleted.
- heap/WeakSet.cpp:
(JSC::WeakSet::sweep):
(JSC::WeakSet::addAllocator):
- heap/WeakSet.h:
(JSC::WeakSet::WeakSet):
- heap/WeakSetInlines.h:
(JSC::WeakSet::allocate):
- inspector/InjectedScriptManager.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
- inspector/JSJavaScriptCallFrame.cpp:
- inspector/ScriptDebugServer.cpp:
- inspector/agents/InspectorDebuggerAgent.cpp:
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitAllocate):
(JSC::AssemblyHelpers::emitAllocateJSCell):
(JSC::AssemblyHelpers::emitAllocateJSObject):
(JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize):
(JSC::AssemblyHelpers::emitAllocateVariableSized):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_create_this):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_create_this):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
- jsc.cpp:
(functionDescribeArray):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/ModuleAnalyzer.cpp:
- runtime/ArrayConventions.h:
(JSC::indexIsSufficientlyBeyondLengthForSparseMap):
(JSC::indexingHeaderForArrayStorage):
(JSC::baseIndexingHeaderForArrayStorage):
(JSC::indexingHeaderForArray): Deleted.
(JSC::baseIndexingHeaderForArray): Deleted.
- runtime/ArrayStorage.h:
(JSC::ArrayStorage::length):
(JSC::ArrayStorage::setLength):
(JSC::ArrayStorage::vectorLength):
(JSC::ArrayStorage::setVectorLength):
(JSC::ArrayStorage::copyHeaderFromDuringGC):
(JSC::ArrayStorage::sizeFor):
(JSC::ArrayStorage::totalSizeFor):
(JSC::ArrayStorage::totalSize):
(JSC::ArrayStorage::availableVectorLength):
(JSC::ArrayStorage::optimalVectorLength):
- runtime/AuxiliaryBarrier.h: Added.
(JSC::AuxiliaryBarrier::AuxiliaryBarrier):
(JSC::AuxiliaryBarrier::clear):
(JSC::AuxiliaryBarrier::get):
(JSC::AuxiliaryBarrier::slot):
(JSC::AuxiliaryBarrier::operator bool):
(JSC::AuxiliaryBarrier::setWithoutBarrier):
- runtime/AuxiliaryBarrierInlines.h: Added.
(JSC::AuxiliaryBarrier<T>::AuxiliaryBarrier):
(JSC::AuxiliaryBarrier<T>::set):
- runtime/Butterfly.h:
(JSC::Butterfly::fromBase):
(JSC::Butterfly::fromPointer):
- runtime/ButterflyInlines.h:
(JSC::Butterfly::availableContiguousVectorLength):
(JSC::Butterfly::optimalContiguousVectorLength):
(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::growArrayRight):
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createEmpty):
- runtime/DataView.cpp:
- runtime/DirectArguments.h:
- runtime/ECMAScriptSpecInternalFunctions.cpp:
- runtime/GeneratorFrame.cpp:
- runtime/GeneratorPrototype.cpp:
- runtime/IntlCollator.cpp:
- runtime/IntlCollatorConstructor.cpp:
- runtime/IntlCollatorPrototype.cpp:
- runtime/IntlDateTimeFormat.cpp:
- runtime/IntlDateTimeFormatConstructor.cpp:
- runtime/IntlDateTimeFormatPrototype.cpp:
- runtime/IntlNumberFormat.cpp:
- runtime/IntlNumberFormatConstructor.cpp:
- runtime/IntlNumberFormatPrototype.cpp:
- runtime/JSArray.cpp:
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::tryCreateUninitialized):
(JSC::JSArray::setLengthWritable):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::appendMemcpy):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::fastSlice):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
- runtime/JSArray.h:
(JSC::createContiguousArrayButterfly):
(JSC::createArrayButterfly):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized): Deleted.
- runtime/JSArrayBufferView.h:
- runtime/JSCInlines.h:
- runtime/JSCJSValue.cpp:
- runtime/JSCallee.cpp:
- runtime/JSCell.cpp:
(JSC::JSCell::estimatedSize):
(JSC::JSCell::copyBackingStore):
- runtime/JSCell.h:
(JSC::JSCell::cellStateOffset):
- runtime/JSCellInlines.h:
(JSC::JSCell::visitChildren):
(JSC::ExecState::vm):
(JSC::JSCell::canUseFastGetOwnProperty):
(JSC::JSCell::classInfo):
(JSC::JSCell::toBoolean):
(JSC::JSCell::pureToBoolean):
(JSC::JSCell::callDestructor):
(JSC::JSCell::vm): Deleted.
- runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::allocateAndInitializeRareData):
(JSC::JSFunction::initializeRareData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::setFunctionName):
(JSC::JSFunction::reifyLength):
(JSC::JSFunction::reifyName):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyBoundNameIfNeeded):
- runtime/JSFunction.h:
- runtime/JSFunctionInlines.h:
(JSC::JSFunction::createWithInvalidatedReallocationWatchpoint):
(JSC::JSFunction::JSFunction):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):
- runtime/JSInternalPromise.cpp:
- runtime/JSInternalPromiseConstructor.cpp:
- runtime/JSInternalPromiseDeferred.cpp:
- runtime/JSInternalPromisePrototype.cpp:
- runtime/JSJob.cpp:
- runtime/JSMapIterator.cpp:
- runtime/JSModuleNamespaceObject.cpp:
- runtime/JSModuleRecord.cpp:
- runtime/JSObject.cpp:
(JSC::getClassPropertyNames):
(JSC::JSObject::visitButterfly):
(JSC::JSObject::visitChildren):
(JSC::JSObject::heapSnapshot):
(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::createInitialArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::putDirectNativeFunctionWithoutTransition):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):
(JSC::JSObject::copyButterfly): Deleted.
(JSC::JSObject::copyBackingStore): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::initializeIndex):
(JSC::JSObject::globalObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putOwnDataProperty):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary): Deleted.
- runtime/JSObjectInlines.h:
- runtime/JSPromise.cpp:
- runtime/JSPromiseConstructor.cpp:
- runtime/JSPromiseDeferred.cpp:
- runtime/JSPromisePrototype.cpp:
- runtime/JSPropertyNameIterator.cpp:
- runtime/JSScope.cpp:
(JSC::JSScope::resolve):
- runtime/JSScope.h:
(JSC::JSScope::globalObject):
(JSC::Register::operator=):
(JSC::JSScope::vm): Deleted.
- runtime/JSSetIterator.cpp:
- runtime/JSStringIterator.cpp:
- runtime/JSTemplateRegistryKey.cpp:
- runtime/JSTypedArrayViewConstructor.cpp:
- runtime/JSTypedArrayViewPrototype.cpp:
- runtime/JSWeakMap.cpp:
- runtime/JSWeakSet.cpp:
- runtime/MapConstructor.cpp:
- runtime/MapPrototype.cpp:
- runtime/NativeStdFunctionCell.cpp:
- runtime/Operations.h:
(JSC::jsAdd):
(JSC::resetFreeCellsBadly):
(JSC::resetBadly):
- runtime/Options.h:
- runtime/PropertyTable.cpp:
- runtime/ProxyConstructor.cpp:
- runtime/ProxyObject.cpp:
- runtime/ProxyRevoke.cpp:
- runtime/RegExpMatchesArray.h:
(JSC::tryCreateUninitializedRegExpMatchesArray):
(JSC::createRegExpMatchesArray):
- runtime/RuntimeType.cpp:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::processUnverifiedStackTraces):
- runtime/SetConstructor.cpp:
- runtime/SetPrototype.cpp:
- runtime/TemplateRegistry.cpp:
- runtime/TypeProfilerLog.cpp:
- runtime/TypeSet.cpp:
- runtime/WeakMapConstructor.cpp:
- runtime/WeakMapData.cpp:
- runtime/WeakMapPrototype.cpp:
- runtime/WeakSetConstructor.cpp:
- runtime/WeakSetPrototype.cpp:
- tools/JSDollarVMPrototype.cpp:
(JSC::JSDollarVMPrototype::isInObjectSpace):
(JSC::JSDollarVMPrototype::isInStorageSpace):
Source/WebCore:
No new tests because no new WebCore behavior.
Just rewiring #includes.
- ForwardingHeaders/heap/HeapInlines.h: Added.
- ForwardingHeaders/runtime/AuxiliaryBarrierInlines.h: Added.
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
- bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp:
- bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp:
- bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp:
- bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp:
- bindings/js/JSClientRectCustom.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMStringListCustom.cpp:
- bindings/js/JSErrorEventCustom.cpp:
- bindings/js/JSPopStateEventCustom.cpp:
- bindings/js/JSWebGL2RenderingContextCustom.cpp:
- contentextensions/ContentExtensionParser.cpp:
- dom/ErrorEvent.cpp:
- inspector/CommandLineAPIModule.cpp:
- testing/GCObservation.cpp:
(WebCore::GCObservation::GCObservation):
Source/WebKit2:
Just rewiring some #includes.
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
Source/WTF:
I needed tryFastAlignedMalloc() so I added it.
- wtf/FastMalloc.cpp:
(WTF::fastAlignedMalloc):
(WTF::tryFastAlignedMalloc):
(WTF::fastAlignedFree):
- wtf/FastMalloc.h:
Tools:
- DumpRenderTree/TestRunner.cpp: Rewire some #includes.
- Scripts/run-jsc-stress-tests: New test flag!
- 12:41 PM Changeset in webkit [204853] by
-
- 44 edits3 copies2 adds2 deletes in trunk
WK2 Gamepad layout test support.
https://bugs.webkit.org/show_bug.cgi?id=134671
Source/WebCore:
Reviewed by Alex Christensen.
No new tests (Covered by changes to existing tests).
Add a MockGamepadProvider and expose it in WebCoreTestSupport.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::reset): Deleted. Gamepads should either always be enabled during tests
(As in Mac WK2), or never enabled (As in all other platforms).
- bindings/generic/RuntimeEnabledFeatures.h:
- platform/gamepad/GamepadProvider.h:
(WebCore::GamepadProvider::isMockGamepadProvider):
- testing/MockGamepad.cpp: Copied from Source/WebKit2/Shared/Gamepad/GamepadData.cpp.
(WebCore::MockGamepad::MockGamepad):
(WebCore::MockGamepad::updateDetails):
(WebCore::MockGamepad::setAxisValue):
(WebCore::MockGamepad::setButtonValue):
- testing/MockGamepad.h: Copied from Source/WebKit2/UIProcess/Gamepad/UIGamepad.h.
- testing/MockGamepadProvider.cpp: Added.
(WebCore::MockGamepadProvider::singleton):
(WebCore::MockGamepadProvider::MockGamepadProvider):
(WebCore::MockGamepadProvider::startMonitoringGamepads):
(WebCore::MockGamepadProvider::stopMonitoringGamepads):
(WebCore::MockGamepadProvider::setMockGamepadDetails):
(WebCore::MockGamepadProvider::connectMockGamepad):
(WebCore::MockGamepadProvider::disconnectMockGamepad):
(WebCore::MockGamepadProvider::setMockGamepadAxisValue):
(WebCore::MockGamepadProvider::setMockGamepadButtonValue):
(WebCore::MockGamepadProvider::gamepadInputActivity):
- testing/MockGamepadProvider.h: Copied from Source/WebKit2/WebProcess/Gamepad/WebGamepadProvider.h.
(WebCore::MockGamepadProvider::~MockGamepadProvider):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::installMockGamepadProvider):
(WebCoreTestSupport::connectMockGamepad):
(WebCoreTestSupport::disconnectMockGamepad):
(WebCoreTestSupport::setMockGamepadDetails):
(WebCoreTestSupport::setMockGamepadAxisValue):
(WebCoreTestSupport::setMockGamepadButtonValue):
- testing/js/WebCoreTestSupport.h:
Source/WebKit2:
Reviewed by Alex Christensen.
- Teach the UIGamepadProvider to use the default shared provider.
- Especially if its the MockGamepadProvider, don't overwrite it.
- Shared/Gamepad/GamepadData.cpp:
(WebKit::GamepadData::GamepadData):
(WebKit::GamepadData::encode):
(WebKit::GamepadData::decode):
(WebKit::GamepadData::loggingString):
(WebKit::GamepadData::isNull): Deleted.
- Shared/Gamepad/GamepadData.h:
(WebKit::GamepadData::GamepadData):
(WebKit::GamepadData::isNull):
(WebKit::GamepadData::index):
(WebKit::GamepadData::axisValues):
(WebKit::GamepadData::buttonValues):
- UIProcess/Gamepad/UIGamepad.h:
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::UIGamepadProvider):
(WebKit::UIGamepadProvider::~UIGamepadProvider):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):
(WebKit::UIGamepadProvider::startMonitoringGamepads):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::platformSetDefaultGamepadProvider):
- UIProcess/Gamepad/UIGamepadProvider.h:
- UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:
(WebKit::UIGamepadProvider::platformSetDefaultGamepadProvider):
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringGamepads): Deleted.
(WebKit::UIGamepadProvider::platformStopMonitoringGamepads): Deleted.
(WebKit::UIGamepadProvider::platformGamepads): Deleted.
- UIProcess/WebPageProxy.h:
- WebProcess/Gamepad/WebGamepad.cpp:
(WebKit::WebGamepad::WebGamepad):
(WebKit::WebGamepad::updateValues):
- WebProcess/Gamepad/WebGamepad.h:
- WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::gamepadConnected):
- WebProcess/Gamepad/WebGamepadProvider.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.h:
Tools:
Reviewed by Alex Christensen.
Have the injected bundle expose the MockGamepadProvider to the UI process, which will then
feed back into the UIGamepadProvider.
Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
- WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setMockGamepadDetails):
(WTR::TestRunner::setMockGamepadAxisValue):
(WTR::TestRunner::setMockGamepadButtonValue):
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(-[WebKitTestRunnerWindow initWithFrame:]):
(-[WebKitTestRunnerWindow dealloc]):
(WTR::PlatformWebView::keyWindow):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::wtr_NSApplication_keyWindow):
(WTR::TestController::platformInitialize):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(+[WebKitTestRunnerWindow _WTR_keyWindow]):
(-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
(-[WebKitTestRunnerWindow dealloc]):
(WTR::PlatformWebView::keyWindow):
- WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::wtr_NSApplication_keyWindow):
(WTR::TestController::platformInitialize):
- WebKitTestRunner/mac/main.mm:
LayoutTests:
Reviewed by Alex Christensen.
- gamepad/gamepad-api-expected.txt:
- gamepad/gamepad-api.html:
- gamepad/gamepad-out-of-range-crasher-expected.txt: Removed.
- gamepad/gamepad-out-of-range-crasher.html: Removed.
- gamepad/gamepad-polling-access-expected.txt:
- gamepad/gamepad-polling-access.html:
- platform/mac/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Added.
- 12:37 PM Changeset in webkit [204852] by
-
- 9 edits6 moves1 add in trunk/Source
Add pref for enabling new CSS parsing and move parser files into subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=161095
Reviewed by Sam Weinig.
Source/WebCore:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp: Removed.
- css/CSSParser.h: Removed.
- css/CSSParserMode.h: Removed.
- css/CSSParserValues.cpp: Removed.
- css/CSSParserValues.h: Removed.
- css/SVGCSSParser.cpp: Removed.
- css/parser: Added.
- css/parser/CSSParser.cpp: Copied from css/CSSParser.cpp.
- css/parser/CSSParser.h: Copied from css/CSSParser.h.
- css/parser/CSSParserMode.h: Copied from css/CSSParserMode.h.
- css/parser/CSSParserValues.cpp: Copied from css/CSSParserValues.cpp.
- css/parser/CSSParserValues.h: Copied from css/CSSParserValues.h.
- css/parser/SVGCSSParser.cpp: Copied from css/SVGCSSParser.cpp.
- page/Settings.in:
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetNewCSSParserEnabled):
(WKPreferencesGetNewCSSParserEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 12:23 PM Changeset in webkit [204851] by
-
- 43 edits25 moves266 adds8 deletes in trunk/JSTests
Update/add new test262 tests
https://bugs.webkit.org/show_bug.cgi?id=161098
Reviewed by Saam Barati.
- test262.yaml:
- test262/test/annexB/language/statements/for-in/bare-initializer.js: Added.
- test262/test/annexB/language/statements/for-in/const-initializer.js: Added.
- test262/test/annexB/language/statements/for-in/let-initializer.js: Added.
- test262/test/annexB/language/statements/for-in/nonstrict-initializer.js: Added.
(a):
- test262/test/annenxB/language/statements/for-in/strict-initializer.js: Added.
- test262/test/annexB/language/statements/for-in/var-arraybindingpattern-initializer.js: Added.
- test262/test/annexB/language/statements/for-in/var-objectbindingpattern-initializer.js: Added.
- test262/test/built-ins/AsyncFunction/AsyncFunction-construct.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunction-is-extensible.js: Added.
(AsyncFunction.async):
- test262/test/built-ins/AsyncFunction/AsyncFunction-is-subclass.js: Added.
(async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunction-length.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunction-name.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunction-prototype.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunction.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunctionPrototype-is-extensible.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunctionPrototype-prototype.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/AsyncFunctionPrototype-to-string.js: Added.
(AsyncFunction.async.foo):
- test262/test/built-ins/AsyncFunction/instance-construct.js: Added.
(async.foo):
- test262/test/built-ins/AsyncFunction/instance-has-name.js: Added.
(async.foo):
- test262/test/built-ins/AsyncFunction/instance-length.js: Added.
(async.l0):
(async.l1):
(async.l2):
- test262/test/built-ins/AsyncFunction/instance-prototype-property.js: Added.
(async.foo):
- test262/test/built-ins/AsyncFunction/is-not-a-global.js: Added.
- test262/test/built-ins/DataView/prototype/getFloat32/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getFloat32/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getFloat32/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getFloat64/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getFloat64/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getFloat64/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getInt16/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getInt16/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getInt16/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getInt32/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getInt32/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getInt32/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getInt8/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getInt8/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getInt8/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getUint16/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getUint16/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getUint16/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getUint32/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getUint32/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getUint32/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/getUint8/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/getUint8/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/getUint8/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setFloat32/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setFloat32/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setFloat32/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setFloat32/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setFloat32/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setFloat64/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setFloat64/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setFloat64/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setFloat64/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setFloat64/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setInt16/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setInt16/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setInt16/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setInt16/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setInt16/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setInt32/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setInt32/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setInt32/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setInt32/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setInt32/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setInt8/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setInt8/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setInt8/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setInt8/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setInt8/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setUint16/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setUint16/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setUint16/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setUint16/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setUint16/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setUint32/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setUint32/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setUint32/range-check-after-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setUint8/detached-buffer-after-toindex-byteoffset.js: Renamed from JSTests/test262/test/built-ins/DataView/prototype/setUint8/detached-buffer-after-integer-byteoffset.js.
- test262/test/built-ins/DataView/prototype/setUint8/detached-buffer-before-outofrange-byteoffset.js:
- test262/test/built-ins/DataView/prototype/setUint8/index-check-before-value-conversion.js:
- test262/test/built-ins/DataView/prototype/setUint8/range-check-after-value-conversion.js:
- test262/test/built-ins/Function/prototype/bind/instance-construct-newtarget-boundtarget-bound.js: Added.
(A):
- test262/test/built-ins/Function/prototype/bind/instance-construct-newtarget-boundtarget.js: Added.
(A):
- test262/test/built-ins/Function/prototype/bind/instance-construct-newtarget-self-new.js: Added.
(A):
- test262/test/built-ins/Function/prototype/bind/instance-construct-newtarget-self-reflect.js: Added.
(A):
- test262/test/built-ins/Function/prototype/toString/AsyncFunction.js: Added.
(async.f):
- test262/test/built-ins/Function/prototype/toString/async-function-declaration.js: Added.
(async.f):
- test262/test/built-ins/Function/prototype/toString/async-function-expression.js: Added.
(let.f.async.f):
- test262/test/built-ins/Function/prototype/toString/async-method.js: Added.
(let.f.async.f):
(let.g.async.string_appeared_here):
- test262/test/built-ins/JSON/parse/reviver-array-define-prop-err.js: Added.
(defineProperty):
- test262/test/built-ins/JSON/parse/reviver-array-delete-err.js: Added.
(deleteProperty):
- test262/test/built-ins/JSON/parse/reviver-array-length-coerce-err.js: Added.
(uncoercible.valueOf):
(get if):
- test262/test/built-ins/JSON/parse/reviver-array-length-get-err.js: Added.
(get if):
- test262/test/built-ins/JSON/parse/reviver-call-err.js: Added.
- test262/test/built-ins/JSON/parse/reviver-get-name-err.js: Added.
(thrower):
- test262/test/built-ins/JSON/parse/reviver-object-define-prop-err.js: Added.
(defineProperty):
- test262/test/built-ins/JSON/parse/reviver-object-delete-err.js: Added.
(deleteProperty):
- test262/test/built-ins/JSON/parse/reviver-object-own-keys-err.js: Added.
(ownKeys):
- test262/test/built-ins/Number/prototype/toExponential/infinity.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/nan.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/prop-desc.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/return-abrupt-tointeger-fractiondigits-symbol.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/return-abrupt-tointeger-fractiondigits.js: Added.
(fd1.valueOf):
(fd2.toString):
- test262/test/built-ins/Number/prototype/toExponential/return-values.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/this-is-0-fractiondigits-is-0.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/this-is-0-fractiondigits-is-not-0.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/this-type-not-number-or-number-object.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/tointeger-fractiondigits.js: Added.
- test262/test/built-ins/Number/prototype/toExponential/undefined-fractiondigits.js: Added.
- test262/test/built-ins/Object/getOwnPropertyDescriptors/duplicate-keys.js:
- test262/test/built-ins/Object/getOwnPropertyDescriptors/proxy-undefined-descriptor.js: Added.
(badProxyHandlers.allowProxyTraps.getOwnPropertyDescriptor):
(badProxyHandlers.allowProxyTraps.ownKeys):
- test262/test/built-ins/Proxy/setPrototypeOf/boolean-trap-result-extensible-target.js: Removed.
(setPrototypeOf): Deleted.
- test262/test/built-ins/Proxy/setPrototypeOf/internals-call-order.js: Added.
(target.new.Proxy.Object.create.isExtensible):
(target.new.Proxy.Object.create.getPrototypeOf):
(target.new.Proxy.Object.create):
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/not-extensible-target-not-same-target-prototype.js:
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/not-extensible-target-same-target-prototype.js:
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/not-extensible-trap-is-false-return-false.js: Removed.
(setPrototypeOf): Deleted.
- test262/test/built-ins/Proxy/setPrototypeOf/return-abrupt-from-get-trap.js: Added.
- test262/test/built-ins/Proxy/setPrototypeOf/return-abrupt-from-isextensible-target.js: Added.
(isExtensible):
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/return-abrupt-from-target-getprototypeof.js: Added.
(getPrototypeOf):
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/return-abrupt-from-trap.js: Renamed from JSTests/test262/test/built-ins/Proxy/setPrototypeOf/return-is-abrupt.js.
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/return-is-abrupt.js:
(setPrototypeOf): Deleted.
- test262/test/built-ins/Proxy/setPrototypeOf/toboolean-trap-result-false.js: Added.
(isExtensible):
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/toboolean-trap-result-true-target-is-extensible.js: Added.
(isExtensible):
(getPrototypeOf):
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/trap-is-not-callable.js:
- test262/test/built-ins/Proxy/setPrototypeOf/trap-is-undefined-or-null.js: Added.
(setPrototypeOf):
- test262/test/built-ins/Proxy/setPrototypeOf/trap-is-undefined.js: Removed.
- test262/test/built-ins/RegExp/lastIndex.js: Added.
- test262/test/built-ins/RegExp/prototype/global/15.10.7.2-1.js: Removed.
- test262/test/built-ins/RegExp/prototype/global/this-val-invalid-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/global/this-val-non-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/global/this-val-regexp-prototype.js: Added.
- test262/test/built-ins/RegExp/prototype/ignoreCase/15.10.7.3-1.js: Removed.
- test262/test/built-ins/RegExp/prototype/ignoreCase/this-val-invalid-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/ignoreCase/this-val-non-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/ignoreCase/this-val-regexp-prototype.js: Added.
- test262/test/built-ins/RegExp/prototype/lastIndex/15.10.7.5-1.js: Removed.
- test262/test/built-ins/RegExp/prototype/lastIndex/15.10.7.5-2.js: Removed.
- test262/test/built-ins/RegExp/prototype/lastIndex/S15.10.7.5_A8.js: Removed.
(re.hasOwnProperty): Deleted.
(re.propertyIsEnumerable): Deleted.
(count.0): Deleted.
- test262/test/built-ins/RegExp/prototype/lastIndex/S15.10.7.5_A9.js: Removed.
(re.hasOwnProperty): Deleted.
(catch): Deleted.
- test262/test/built-ins/RegExp/prototype/multiline/15.10.7.4-1.js: Removed.
- test262/test/built-ins/RegExp/prototype/multiline/this-val-invalid-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/multiline/this-val-non-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/multiline/this-val-regexp-prototype.js: Added.
- test262/test/built-ins/RegExp/prototype/no-regexp-matcher.js: Added.
- test262/test/built-ins/RegExp/prototype/source/15.10.7.1-1.js: Removed.
- test262/test/built-ins/RegExp/prototype/source/this-val-invalid-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/source/this-val-non-obj.js: Added.
(get Object):
- test262/test/built-ins/RegExp/prototype/source/this-val-regexp-prototype.js: Added.
- test262/test/built-ins/RegExp/prototype/source/value-empty.js: Added.
- test262/test/built-ins/RegExp/prototype/source/value-line-terminator.js: Added.
- test262/test/built-ins/RegExp/prototype/source/value-u.js: Added.
- test262/test/built-ins/RegExp/prototype/source/value.js: Added.
- test262/test/built-ins/RegExp/prototype/sticky/this-val-invalid-obj.js: Renamed from JSTests/test262/test/built-ins/RegExp/prototype/sticky/this-invalid-obj.js.
- test262/test/built-ins/RegExp/prototype/sticky/this-val-non-obj.js: Renamed from JSTests/test262/test/built-ins/RegExp/prototype/sticky/this-non-obj.js.
- test262/test/built-ins/RegExp/prototype/sticky/this-val-regexp-prototype.js: Added.
- test262/test/built-ins/RegExp/prototype/sticky/this-val-regexp.js: Renamed from JSTests/test262/test/built-ins/RegExp/prototype/sticky/this-regexp.js.
- test262/test/built-ins/RegExp/prototype/unicode/this-val-invalid-obj.js: Renamed from JSTests/test262/test/built-ins/RegExp/prototype/unicode/this-invald-obj.js.
- test262/test/built-ins/RegExp/prototype/unicode/this-val-non-obj.js: Renamed from JSTests/test262/test/built-ins/RegExp/prototype/unicode/this-non-obj.js.
- test262/test/built-ins/RegExp/prototype/unicode/this-val-regexp-prototype.js: Added.
- test262/test/built-ins/RegExp/prototype/unicode/this-val-regexp.js: Renamed from JSTests/test262/test/built-ins/RegExp/prototype/unicode/this-regexp.js.
- test262/test/built-ins/String/numeric-properties.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/date-is-infinity-throws.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/date-is-nan-throws.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/formatToParts.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/length.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/main.js: Added.
(reduce):
(compareFTPtoFormat):
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/name.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/return-abrupt-tonumber-date.js: Added.
(obj1.valueOf):
(obj2.toString):
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/this-has-not-internal-throws.js: Added.
- test262/test/intl402/DateTimeFormat/prototype/formatToParts/this-is-not-object-throws.js: Added.
- test262/test/intl402/NumberFormat/prototype/formatToParts/formatToParts.js: Added.
- test262/test/intl402/NumberFormat/prototype/formatToParts/length.js: Added.
- test262/test/intl402/NumberFormat/prototype/formatToParts/main.js: Added.
(reduce):
(compareFTPtoFormat):
- test262/test/intl402/NumberFormat/prototype/formatToParts/name.js: Added.
- test262/test/intl402/NumberFormat/prototype/formatToParts/return-abrupt-tonumber.js: Added.
(obj1.valueOf):
(obj2.toString):
- test262/test/intl402/NumberFormat/prototype/formatToParts/this-has-not-internal-throws.js: Added.
- test262/test/intl402/NumberFormat/prototype/formatToParts/this-is-not-object-throws.js: Added.
- test262/test/language/arguments-object/10.6-10-c-ii-2-s.js:
(foo): Deleted.
- test262/test/language/arguments-object/unmapped/via-params-dflt.js: Added.
(dflt):
- test262/test/language/arguments-object/unmapped/via-params-dstr.js: Added.
(dstr):
- test262/test/language/arguments-object/unmapped/via-params-rest.js: Added.
(rest):
- test262/test/language/arguments-object/unmapped/via-strict.js: Renamed from JSTests/test262/test/language/arguments-object/10.6-10-c-ii-2-s.js.
(foo):
- test262/test/language/block-scope/syntax/redeclaration-global/allowed-to-redeclare-function-declaration-with-function-declaration.js:
(f): Deleted.
- test262/test/language/eval-code/direct/super-call-arrow.js: Added.
(catch):
- test262/test/language/eval-code/direct/super-call-fn.js: Added.
(f):
- test262/test/language/eval-code/direct/super-call.js: Added.
(catch):
- test262/test/language/eval-code/direct/super-prop-arrow.js: Added.
(catch):
- test262/test/language/eval-code/direct/super-prop-method.js: Added.
(o.method):
- test262/test/language/eval-code/direct/super-prop.js: Added.
(catch):
- test262/test/language/eval-code/indirect/super-call.js: Added.
(catch):
(try.m):
- test262/test/language/eval-code/indirect/super-prop.js: Added.
(catch):
(try.m):
- test262/test/language/expressions/arrow-function/params-trailing-comma-length.js: Added.
(assert.sameValue):
- test262/test/language/expressions/arrow-function/params-trailing-comma.js: Added.
- test262/test/language/expressions/async-arrow-function/arrow-returns-promise.js: Added.
(p.then):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-NSPL-with-USD.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-arguments-in-formal-parameters.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-await-in-formals-default.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-await-in-formals.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-body-contains-super-call.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-body-contains-super-property.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-duplicate-parameters.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-eval-in-formal-parameters.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-formals-body-duplicate.js: Added.
(async):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-formals-contains-super-call.js: Added.
(async.foo.super):
- test262/test/language/expressions/async-arrow-function/early-errors-arrow-formals-contains-super-property.js: Added.
(async):
- test262/test/language/expressions/async-function/early-errors-expression-NSPL-with-USD.js: Added.
(async):
- test262/test/language/expressions/async-function/early-errors-expression-binding-identifier-arguments.js: Added.
(async.arguments):
- test262/test/language/expressions/async-function/early-errors-expression-binding-identifier-eval.js: Added.
(async.eval):
- test262/test/language/expressions/async-function/early-errors-expression-body-contains-super-call.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/early-errors-expression-body-contains-super-property.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/early-errors-expression-eval-in-formal-parameters.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/early-errors-expression-formals-body-duplicate.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/early-errors-expression-formals-contains-super-call.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/early-errors-expression-formals-contains-super-property.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/early-errors-expression-not-simple-assignment-target.js: Added.
(async.foo):
- test262/test/language/expressions/async-function/expression-returns-promise.js: Added.
(p.async):
- test262/test/language/expressions/async-function/syntax-expression-is-PrimaryExpression.js: Added.
(async.foo):
- test262/test/language/expressions/await/await-BindingIdentifier-in-global.js: Added.
(async.await):
- test262/test/language/expressions/await/await-BindingIdentifier-nested.js: Added.
(async.foo.await):
(async.foo):
- test262/test/language/expressions/await/await-awaits-thenable-not-callable.js: Added.
(async.foo):
- test262/test/language/expressions/await/await-awaits-thenables-that-throw.js: Added.
(thenable.then):
(async.foo):
- test262/test/language/expressions/await/await-awaits-thenables.js: Added.
(thenable.then):
(async.foo):
- test262/test/language/expressions/await/await-in-function.js: Added.
(foo):
- test262/test/language/expressions/await/await-in-generator.js: Added.
(foo):
- test262/test/language/expressions/await/await-in-global.js: Added.
- test262/test/language/expressions/await/await-in-nested-function.js: Added.
(async.foo.bar):
(async.foo):
- test262/test/language/expressions/await/await-in-nested-generator.js: Added.
(async.foo.bar):
(async.foo):
- test262/test/language/expressions/await/await-throws-rejections.js: Added.
(async.foo):
- test262/test/language/expressions/await/early-errors-await-not-simple-assignment-target.js: Added.
(async.foo):
- test262/test/language/expressions/await/no-operand.js: Added.
(async.foo):
- test262/test/language/expressions/await/syntax-await-has-UnaryExpression-with-MultiplicativeExpression.js: Added.
(async.foo):
- test262/test/language/expressions/await/syntax-await-has-UnaryExpression.js: Added.
(async.foo):
- test262/test/language/expressions/call/trailing-comma.js: Added.
(foo):
- test262/test/language/expressions/function/arguments-with-arguments-fn.js: Added.
(f):
- test262/test/language/expressions/function/arguments-with-arguments-lex.js: Added.
(f):
- test262/test/language/expressions/function/params-trailing-comma-arguments.js: Added.
(f1):
(f2):
- test262/test/language/expressions/function/params-trailing-comma-length.js: Added.
(assert.sameValue):
- test262/test/language/expressions/function/params-trailing-comma.js: Added.
- test262/test/language/expressions/generators/arguments-with-arguments-fn.js: Added.
(g):
- test262/test/language/expressions/generators/arguments-with-arguments-lex.js: Added.
(g):
- test262/test/language/expressions/generators/params-trailing-comma-arguments.js: Added.
(f1):
(f2):
- test262/test/language/expressions/generators/params-trailing-comma-length.js: Added.
(assert.sameValue):
- test262/test/language/expressions/generators/params-trailing-comma.js: Added.
- test262/test/language/expressions/object/computed-property-evaluation-order.js: Added.
- test262/test/language/expressions/object/method-definition/async-super-call-body.js: Added.
(sup.method):
(child.async.method):
- test262/test/language/expressions/object/method-definition/async-super-call-param.js: Added.
(sup.method):
(child.async.method.x.super.method):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-NSPL-with-USD.js: Added.
(foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-arguments-in-formal-parameters.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals-default.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-body-contains-super-call.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-eval-in-formal-parameters.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-formals-body-duplicate.js: Added.
(async.foo):
- test262/test/language/expressions/object/method-definition/early-errors-object-method-formals-contains-super-call.js: Added.
(async.foo.foo.super):
- test262/test/language/expressions/object/method-definition/object-method-returns-promise.js: Added.
(obj.async.method):
- test262/test/language/expressions/object/method-definition/params-trailing-comma-arguments.js: Added.
(obj.f1):
(obj.f2):
- test262/test/language/expressions/object/method-definition/params-trailing-comma-length.js: Added.
(obj.one):
(obj.two):
- test262/test/language/expressions/object/method-definition/params-trailing-comma-rest.js: Added.
(m):
- test262/test/language/expressions/object/method-definition/params-trailing-comma.js: Added.
(one):
(two):
- test262/test/language/global-code/decl-func-dup.js: Renamed from JSTests/test262/test/language/block-scope/syntax/redeclaration-global/allowed-to-redeclare-function-declaration-with-function-declaration.js.
(f):
- test262/test/language/global-code/decl-func.js: Added.
(brandNew):
- test262/test/language/global-code/decl-lex-configurable-global.js: Added.
- test262/test/language/global-code/decl-lex-deletion.js: Added.
(test262class):
- test262/test/language/global-code/decl-lex-restricted-global.js: Added.
- test262/test/language/global-code/decl-lex.js: Added.
(test262class):
- test262/test/language/global-code/decl-var.js: Added.
- test262/test/language/global-code/return.js: Added.
- test262/test/language/global-code/script-decl-func-dups.js: Added.
- test262/test/language/global-code/script-decl-func-err-non-configurable.js: Added.
- test262/test/language/global-code/script-decl-func-err-non-extensible.js: Added.
- test262/test/language/global-code/script-decl-func.js: Added.
- test262/test/language/global-code/script-decl-lex-deletion.js: Added.
- test262/test/language/global-code/script-decl-lex-lex.js: Added.
(test262Class):
- test262/test/language/global-code/script-decl-lex-restricted-global.js: Added.
- test262/test/language/global-code/script-decl-lex-var.js: Added.
(test262Fn):
- test262/test/language/global-code/script-decl-lex.js: Added.
- test262/test/language/global-code/script-decl-var-collision.js: Added.
(test262Class):
- test262/test/language/global-code/script-decl-var-err.js: Added.
- test262/test/language/global-code/script-decl-var.js: Added.
- test262/test/language/global-code/super-call-arrow.js: Added.
- test262/test/language/global-code/super-call.js: Added.
- test262/test/language/global-code/super-prop-arrow.js: Added.
- test262/test/language/global-code/super-prop.js: Added.
- test262/test/language/global-code/yield-non-strict.js: Added.
(catch):
- test262/test/language/global-code/yield-strict.js: Added.
- test262/test/language/literals/regexp/lastIndex.js: Added.
- test262/test/language/literals/regexp/u-unicode-esc-bounds.js:
- test262/test/language/literals/regexp/y-assertion-start.js: Added.
- test262/test/language/module-code/instn-star-err-not-found-faulty_FIXTURE.js:
- test262/test/language/module-code/instn-star-err-not-found.js:
- test262/test/language/module-code/namespace/internals/get-own-property-str-found-init.js:
- test262/test/language/module-code/parse-err-return.js: Added.
- test262/test/language/module-code/parse-err-yield.js: Added.
- test262/test/language/rest-parameters/params-trailing-comma-rest.js: Added.
- test262/test/language/statements/async-function/declaration-returns-promise.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-NSPL-with-USD.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-arguments-in-formal-parameters.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-await-in-formals-default.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-await-in-formals.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-binding-identifier-arguments.js: Added.
(async.arguments):
- test262/test/language/statements/async-function/early-errors-declaration-binding-identifier-eval.js: Added.
(async.eval):
- test262/test/language/statements/async-function/early-errors-declaration-body-contains-super-call.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-body-contains-super-property.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-duplicate-parameters.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-eval-in-formal-parameters.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-formals-body-duplicate.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-formals-contains-super-call.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-declaration-formals-contains-super-property.js: Added.
(async.foo):
- test262/test/language/statements/async-function/early-errors-no-async-generator.js: Added.
(async.foo):
- test262/test/language/statements/async-function/evaluation-body-that-returns-after-await.js: Added.
(async.foo):
(foo.then):
- test262/test/language/statements/async-function/evaluation-body-that-returns.js: Added.
(async.foo):
(foo.then):
- test262/test/language/statements/async-function/evaluation-body-that-throws-after-await.js: Added.
(async.foo):
(foo.then):
- test262/test/language/statements/async-function/evaluation-body-that-throws.js: Added.
(async.foo):
(foo.then):
- test262/test/language/statements/async-function/evaluation-body.js: Added.
(async.foo):
- test262/test/language/statements/async-function/evaluation-default-that-throws.js: Added.
(async.foo):
(foo.then):
- test262/test/language/statements/async-function/evaluation-mapped-arguments.js: Added.
(async.foo):
- test262/test/language/statements/async-function/evaluation-this-value-global.js: Added.
(async.foo):
- test262/test/language/statements/async-function/evaluation-this-value-passed.js: Added.
(async.foo):
- test262/test/language/statements/async-function/evaluation-unmapped-arguments.js: Added.
(async.foo):
- test262/test/language/statements/async-function/syntax-declaration-line-terminators-allowed.js: Added.
(async.foo):
- test262/test/language/statements/async-function/syntax-declaration-no-line-terminator.js: Added.
(async.foo):
- test262/test/language/statements/async-function/syntax-declaration.js: Added.
(async.foo):
(foo.then):
- test262/test/language/statements/class/definition/class-method-returns-promise.js: Added.
(Foo.prototype.async.method):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-NSPL-with-USD.js: Added.
(Foo.prototype.async.bar):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-arguments-in-formal-parameters.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-await-in-formals-default.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-await-in-formals.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-body-contains-super-call.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-duplicate-parameters.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-eval-in-formal-parameters.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-formals-body-duplicate.js: Added.
(Foo.async.foo):
(Foo):
- test262/test/language/statements/class/definition/early-errors-class-method-formals-contains-super-call.js: Added.
(Foo.prototype.async.foo):
(Foo):
- test262/test/language/statements/class/definition/methods-async-super-call-body.js: Added.
(A.prototype.async.method):
(A):
(B.prototype.async.method):
(B):
- test262/test/language/statements/class/definition/methods-async-super-call-param.js: Added.
(A.prototype.async.method):
(A):
(B.prototype.async.method):
(B):
- test262/test/language/statements/class/definition/params-trailing-comma-arguments.js: Added.
(C.prototype.f1):
(C.prototype.f2):
(C):
- test262/test/language/statements/class/definition/params-trailing-comma-length.js: Added.
(C.prototype.one):
(C.prototype.two):
(C):
- test262/test/language/statements/class/definition/params-trailing-comma-rest.js: Added.
(C.prototype.m):
(C):
- test262/test/language/statements/class/definition/params-trailing-comma.js: Added.
(C.prototype.one):
(C.prototype.two):
(C):
- test262/test/language/statements/function/arguments-with-arguments-fn.js: Added.
(f):
- test262/test/language/statements/function/arguments-with-arguments-lex.js: Added.
(f):
- test262/test/language/statements/function/params-trailing-comma-arguments.js: Added.
(f1):
(f2):
- test262/test/language/statements/function/params-trailing-comma-length.js: Added.
(one):
(two):
- test262/test/language/statements/function/params-trailing-comma.js: Added.
(one):
(two):
- test262/test/language/statements/generators/arguments-with-arguments-fn.js: Added.
(g):
- test262/test/language/statements/generators/arguments-with-arguments-lex.js: Added.
(g):
- test262/test/language/statements/generators/params-trailing-comma-length.js: Added.
(one):
(two):
- test262/test/language/statements/generators/params-trailing-comma.js: Added.
(one):
(two):
- test262/test262-Revision.txt:
- 12:12 PM Changeset in webkit [204850] by
-
- 4 edits1 add in trunk
REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
https://bugs.webkit.org/show_bug.cgi?id=161047
rdar://problem/27434307
Reviewed by Lucas Forschler.
Tools:
- Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
LayoutTests:
- http/conf/php.ini: Added. On macOS at least, there is no global php.ini, so we
only need to override this one default setting.
- platform/mac/TestExpectations: Unmarked the test.
- 12:09 PM Changeset in webkit [204849] by
-
- 13 edits2 adds in trunk
[JSC] Make Math.cos() and Math.sin() work with any argument type
https://bugs.webkit.org/show_bug.cgi?id=161069
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-23
Reviewed by Geoffrey Garen.
JSTests:
- stress/arith-cos-on-various-types.js: Added.
- stress/arith-sin-on-various-types.js: Added.
Source/JavaScriptCore:
Same as the ArithSqrt patch: add a generic path if the argument
is not a number.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithCos):
(JSC::DFG::SpeculativeJIT::compileArithSin):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithSin):
(JSC::FTL::DFG::LowerDFGToB3::compileArithCos):
- 12:07 PM Changeset in webkit [204848] by
-
- 4 edits in trunk
[ES6] Module namespace object's Symbol.iterator method should only accept module namespace objects
https://bugs.webkit.org/show_bug.cgi?id=161097
Reviewed by Keith Miller.
JSTests:
- test262.yaml:
Source/JavaScriptCore:
- runtime/JSModuleNamespaceObject.cpp:
(JSC::moduleNamespaceObjectSymbolIterator):
- 12:02 PM Changeset in webkit [204847] by
-
- 3 edits in trunk/Source/WebCore
[MediaStream] Templatize MediaConstraint
https://bugs.webkit.org/show_bug.cgi?id=161092
Reviewed by Jer Noble.
No new tests, no functional change.
- platform/mediastream/MediaConstraints.cpp:
(WebCore::BooleanConstraint::getExact):
(WebCore::BooleanConstraint::getIdeal):
(WebCore::MediaConstraint::getMin): Deleted.
(WebCore::MediaConstraint::getMax): Deleted.
(WebCore::MediaConstraint::getExact): Deleted.
(WebCore::MediaConstraint::getIdeal): Deleted.
(WebCore::IntConstraint::create): Deleted.
(WebCore::IntConstraint::setMin): Deleted.
(WebCore::IntConstraint::setMax): Deleted.
(WebCore::IntConstraint::setExact): Deleted.
(WebCore::IntConstraint::setIdeal): Deleted.
(WebCore::IntConstraint::getMin): Deleted.
(WebCore::IntConstraint::getMax): Deleted.
(WebCore::IntConstraint::getExact): Deleted.
(WebCore::IntConstraint::getIdeal): Deleted.
(WebCore::DoubleConstraint::create): Deleted.
(WebCore::DoubleConstraint::setMin): Deleted.
(WebCore::DoubleConstraint::setMax): Deleted.
(WebCore::DoubleConstraint::setExact): Deleted.
(WebCore::DoubleConstraint::setIdeal): Deleted.
(WebCore::DoubleConstraint::getMin): Deleted.
(WebCore::DoubleConstraint::getMax): Deleted.
(WebCore::DoubleConstraint::getExact): Deleted.
(WebCore::DoubleConstraint::getIdeal): Deleted.
(WebCore::BooleanConstraint::create): Deleted.
(WebCore::BooleanConstraint::setExact): Deleted.
(WebCore::BooleanConstraint::setIdeal): Deleted.
(WebCore::StringConstraint::create): Deleted.
- platform/mediastream/MediaConstraints.h:
(WebCore::MediaConstraint::getMin):
(WebCore::MediaConstraint::getMax):
(WebCore::MediaConstraint::getExact):
(WebCore::MediaConstraint::getIdeal):
(WebCore::NumericConstraint::setMin):
(WebCore::NumericConstraint::setMax):
(WebCore::NumericConstraint::setExact):
(WebCore::NumericConstraint::setIdeal):
(WebCore::NumericConstraint::setHasMin): Deleted.
(WebCore::NumericConstraint::setHasMax): Deleted.
(WebCore::NumericConstraint::setHasExact): Deleted.
(WebCore::NumericConstraint::setHasIdeal): Deleted.
(WebCore::NumericConstraint::hasMin): Deleted.
(WebCore::NumericConstraint::hasMax): Deleted.
(WebCore::NumericConstraint::hasExact): Deleted.
(WebCore::NumericConstraint::hasIdeal): Deleted.
- 12:00 PM Changeset in webkit [204846] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: No open/copy src resource in context menu
https://bugs.webkit.org/show_bug.cgi?id=159028
Patch by Devin Rousso <Devin Rousso> on 2016-08-23
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
Add options in the context menu of link attributes of DOM nodes to
- Open in New Tab
- Reveal in Resources Tab
- Copy Link Address
- 11:56 AM Changeset in webkit [204845] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r204226): LayoutTest editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html "crashing" without a crashlog
https://bugs.webkit.org/show_bug.cgi?id=160782
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-23
Reviewed by Alexey Proskuryakov.
Rolling out r204650.
- platform/mac-wk2/TestExpectations: editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html removed from list of flakey tests.
- 11:49 AM Changeset in webkit [204844] by
-
- 6 edits672 adds in trunk/LayoutTests
Import html/browsers web platform tests
https://bugs.webkit.org/show_bug.cgi?id=161067
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Import html/browsers web platform tests from upstream.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/001-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/001-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/001-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/MANIFEST: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/PopStateEvent.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name-3.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name-4.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/browsing_context_name_cross_origin.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/contains.json: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/events-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/events.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/resources/blank1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/resources/blank2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/resources/page-with-fragment.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/resources/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-basic-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-basic.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/unset_context_name-1-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/unset_context_name-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/unset_context_name.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/001-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/001-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/001-3.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/001-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/002-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/002-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/002-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/002.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/003-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/003-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/003-3.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/003-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/003.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/004-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/004-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/004-3.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/004-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/004.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/005-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/005.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/006-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/006.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/007-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/007.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/008-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/008.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/009-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/009.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/010-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/010.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/011-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/011.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/012-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/012.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/013-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/013.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/014-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/014.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/015-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/015.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/MANIFEST: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/blank.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_location-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_location-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_location-3.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_location-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_location.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_submit-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_submit-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_submit-3.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_submit-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/child_navigates_parent_submit.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/click.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/empty_fragment-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/empty_fragment.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/empty_fragment_iframe.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/href.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-query-fragment-components-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-query-fragment-components.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_data_url-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_data_url-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_data_url.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_same_origin-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_same_origin-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_same_origin.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-parent-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-parent.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-src-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-src.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-src-about-blank-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-src-about-blank.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/support/dummy.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/support/location-set.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/support/set-parent-src.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/support/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-image-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-image.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-media/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-text/load-text-plain-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-text/load-text-plain.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/read-text/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/001-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/002-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/002.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/003.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/004-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/004.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/005-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/005.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/006-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/006.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/007-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/007.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/MANIFEST: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-anchor-name.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-id-top-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-id-top.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-top-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-to-top.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/002-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/002.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/003-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/003.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/005-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/005.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/MANIFEST: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/base.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-history-back-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-history-back-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-history-back.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-navigation-of-parent-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-navigation-of-parent-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-navigation-of-parent-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/beforeunload-on-navigation-of-parent.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/contains.json: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/navigation-within-beforeunload-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/navigation-within-beforeunload-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/navigation-within-beforeunload-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/navigation-within-beforeunload.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/pagehide-on-history-forward-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/pagehide-on-history-forward-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/pagehide-on-history-forward.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/001-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/001-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/001-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/002-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/002-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/002.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/003-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/003.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/MANIFEST: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/manual-001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/manual-002.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/manual-003.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/manual-004.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/manual-005.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/manual-006.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/next.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/prompt/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/001-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/001a.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/001b.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/002-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/002a.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/002b.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/003-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/003a.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/003b.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/004-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/004a.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/004b.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/005-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/005a.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/005b.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/support/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/001-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/001-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/001-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/002-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/002-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/002.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/003-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/003-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/003.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/004-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/004-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/004.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/006-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/006-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/006-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/006.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/007-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/007-2.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/007-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/007.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/008-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/008-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/008.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/009-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/009-expected.txt: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/009.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/MANIFEST: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/manual-001-1.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/manual-001.html: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/w3c-import.log: Added.
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/w3c-import.log: Added.
- web-platform-tests/html/browsers/history/the-history-interface/004-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/004.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/005-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/005.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/006-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/006.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/007-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/007.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/008-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/008.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/008.js: Added.
(test):
- web-platform-tests/html/browsers/history/the-history-interface/009-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/009-3.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/009-5.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/009-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/009.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/010-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/010-3.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/010-5.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/010-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/010.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/011-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/011.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/012-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/012.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/blank.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/blank2.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/blank3.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_001-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_001.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_004-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_004.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_005-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_005.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_006-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_006.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_007-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/combination_history_007.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history.js: Added.
(parse_query):
(onunload):
- web-platform-tests/html/browsers/history/the-history-interface/history_back-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_back-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_back.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_back_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_back_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_entry.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_forward-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_forward-2.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_forward-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_forward.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_forward_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_forward_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_minus-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_minus.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_no_argument.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_plus-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_plus.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_undefined.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_zero-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_zero-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_go_zero.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_pushstate-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_pushstate.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_pushstate_err-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_pushstate_err.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_pushstate_nooptionalparam-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_pushstate_nooptionalparam.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_replacestate-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_replacestate.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_replacestate_err-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_replacestate_err.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_replacestate_nooptionalparam-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_replacestate_nooptionalparam.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_state-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/history_state.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/002-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/002-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/002.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/filler.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/w3c-import.log: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/history.js: Added.
(parse_query):
(onunload):
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/history_entry.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/traverse_the_history_unload_prompt_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/traverse_the_history_unload_prompt_2-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/traverse_the_session_history_unload_prompt_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/traverse_the_session_history_unload_prompt_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/traverse_the_session_history_unload_prompt_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/non-automated/w3c-import.log: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_2-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_2-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_2.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_3-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_4-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_4-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_4.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_5.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_unload_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_unload_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_unload_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_2-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_2-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_after_load_2.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_onload_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_onload_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_onload_1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_onload_2-1.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_onload_2-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-history-interface/traverse_the_history_write_onload_2.html: Added.
- web-platform-tests/html/browsers/history/the-history-interface/w3c-import.log: Added.
- web-platform-tests/html/browsers/history/the-location-interface/allow_prototype_cycle_through_location.sub-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/allow_prototype_cycle_through_location.sub.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/contains.json: Added.
- web-platform-tests/html/browsers/history/the-location-interface/cross_origin_joined_frame.sub.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/document_location-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/document_location.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location-stringifier-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location-stringifier.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_assign_about_blank-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_assign_about_blank-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_assign_about_blank.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_hash.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_host-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_host.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_hostname-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_hostname.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_href-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_href.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_origin-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_origin.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_pathname-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_pathname.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_port-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_port.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_protocol-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_protocol.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_reload-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_reload-iframe.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_reload.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_replace-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_replace.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_search-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/location_search.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/manual_click_assign_during_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/manual_click_assign_during_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/manual_click_location_replace_during_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/manual_click_location_replace_during_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/manual_form_submit_assign_during_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/manual_form_submit_assign_during_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/reload_in_resize-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/non-automated/w3c-import.log: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_open_write-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_open_write-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_open_write.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_write-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_write-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_write.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_write_onload-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_write_onload-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_document_write_onload.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/reload_post_1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/same_origin_frame.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_assign_during_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_assign_during_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_assign_during_load-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_assign_during_load.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_location_assign_during_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_location_assign_during_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_location_assign_during_load-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_click_location_assign_during_load.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_form_submit_assign_during_load-1.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_form_submit_assign_during_load-2.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_form_submit_assign_during_load-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/scripted_form_submit_assign_during_load.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub-expected.txt: Added.
- web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm: Added.
- web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/browser-state/navigator_online_online-expected.txt: Added.
- web-platform-tests/html/browsers/offline/browser-state/navigator_online_online.html: Added.
- web-platform-tests/html/browsers/offline/browser-state/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/changestonetworkingmodel/original-id.json: Added.
- web-platform-tests/html/browsers/offline/changestonetworkingmodel/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/introduction-4/contains.json: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_cached-expected.txt: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_cached.html: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_checking-expected.txt: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_checking.html: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_noupdate-expected.txt: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_noupdate.html: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_progress-expected.txt: Added.
- web-platform-tests/html/browsers/offline/introduction-4/event_progress.html: Added.
- web-platform-tests/html/browsers/offline/introduction-4/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/manifest_url_check-expected.txt: Added.
- web-platform-tests/html/browsers/offline/manifest_url_check.html: Added.
- web-platform-tests/html/browsers/offline/manifests/contains.json: Added.
- web-platform-tests/html/browsers/offline/manifests/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/resources/css/clock.css: Added.
(output):
- web-platform-tests/html/browsers/offline/resources/css/offline.css: Added.
(.connectivity):
- web-platform-tests/html/browsers/offline/resources/css/online.css: Added.
(.connectivity):
- web-platform-tests/html/browsers/offline/resources/css/result.css: Added.
(.manualpass):
(.manualfail):
(.pass):
(.fail):
- web-platform-tests/html/browsers/offline/resources/css/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/resources/html/clock.html: Added.
- web-platform-tests/html/browsers/offline/resources/html/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/resources/js/clock.js: Added.
(setTimeout):
- web-platform-tests/html/browsers/offline/resources/js/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/resources/manifest/clock.manifest: Added.
- web-platform-tests/html/browsers/offline/resources/manifest/section_empty.manifest: Added.
- web-platform-tests/html/browsers/offline/resources/manifest/section_many.manifest: Added.
- web-platform-tests/html/browsers/offline/resources/manifest/url_check.manifest: Added.
- web-platform-tests/html/browsers/offline/resources/manifest/w3c-import.log: Added.
- web-platform-tests/html/browsers/offline/w3c-import.log: Added.
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.sub-expected.txt: Added.
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.sub.html: Added.
- web-platform-tests/html/browsers/origin/cross-origin-objects/frame.html: Added.
- web-platform-tests/html/browsers/origin/cross-origin-objects/w3c-import.log: Added.
- web-platform-tests/html/browsers/origin/cross-origin-objects/win-documentdomain.sub.html: Added.
- web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain-expected.txt: Added.
- web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/document_domain.html: Added.
- web-platform-tests/html/browsers/origin/relaxing-the-same-origin-restriction/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/Document-defaultView-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/Document-defaultView.html: Added.
- web-platform-tests/html/browsers/the-window-object/Window-document-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/Window-document.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/indexed-browsing-contexts-01-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/indexed-browsing-contexts-01.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/indexed-browsing-contexts-02-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/indexed-browsing-contexts-02.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/indexed-browsing-contexts-03-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/indexed-browsing-contexts-03.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/iterator-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/iterator.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/test1.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/test2.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/test3.html: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/window_length-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/accessing-other-browsing-contexts/window_length.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/callback.js: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_beforeunload-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_beforeunload-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_beforeunload.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_script_defer-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_script_defer-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_script_defer.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_unload-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_unload-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/close_unload.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/001-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/001-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/001.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/002-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/002-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/002.html: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_1-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_1-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_1-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_2-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_2-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_2.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_3-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_3-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_3-3.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_3-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_3.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_4-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_4-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_4-3.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_4-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/discard_iframe_history_4.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/discard_iframe_history_1-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/discard_iframe_history_1-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/discard_iframe_history_2-1.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/discard_iframe_history_2-2.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/discard_iframe_history_2-3.html: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/non-automated/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/garbage-collection-and-browsing-contexts/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/named-objects-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/named-objects.html: Added.
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/test.html: Added.
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/window-null-names-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/window-null-names.html: Added.
- web-platform-tests/html/browsers/the-window-object/security-window/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub.html: Added.
- web-platform-tests/html/browsers/the-window-object/w3c-import.log: Added.
- web-platform-tests/html/browsers/the-window-object/window-aliases-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-aliases.html: Added.
- web-platform-tests/html/browsers/the-window-object/window-indexed-properties-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-indexed-properties-strict.html: Added.
- web-platform-tests/html/browsers/the-window-object/window-indexed-properties.html: Added.
- web-platform-tests/html/browsers/the-window-object/window-named-properties-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-named-properties.html: Added.
- web-platform-tests/html/browsers/the-window-object/window-properties-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-properties.html: Added.
- web-platform-tests/html/browsers/the-window-object/window-prototype-chain-expected.txt: Added.
- web-platform-tests/html/browsers/the-window-object/window-prototype-chain.html: Added.
- web-platform-tests/html/browsers/windows/auxiliary-browsing-contexts/contains.json: Added.
- web-platform-tests/html/browsers/windows/auxiliary-browsing-contexts/w3c-import.log: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/001-1.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/001-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/001.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/002-1.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/002-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/002.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/MANIFEST: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-existing-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-existing.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-parent-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-parent.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-self-1-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-self-1.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-self-2-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-choose-self-2.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-default-name-expected.txt: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/browsing-context-default-name.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/existing.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/message.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/parent1.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/parent2.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/self1.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/self2.html: Added.
- web-platform-tests/html/browsers/windows/browsing-context-names/w3c-import.log: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/MANIFEST: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/contains.json: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub-expected.txt: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/test.html: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/testcase3.html: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/w3c-import.log: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-top-001-expected.txt: Added.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/window-top-001.html: Added.
- web-platform-tests/html/browsers/windows/noreferrer-cross-origin-close-manual.sub.html: Added.
- web-platform-tests/html/browsers/windows/noreferrer-cross-origin-window-name.sub.html: Added.
- web-platform-tests/html/browsers/windows/noreferrer-expected.txt: Added.
- web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Added.
- web-platform-tests/html/browsers/windows/noreferrer-window-name.html: Added.
- web-platform-tests/html/browsers/windows/noreferrer.html: Added.
- web-platform-tests/html/browsers/windows/support-close.html: Added.
- web-platform-tests/html/browsers/windows/support-named-null-opener.html: Added.
- web-platform-tests/html/browsers/windows/support-nested-browsing-contexts.html: Added.
- web-platform-tests/html/browsers/windows/support-opener-null.html: Added.
- web-platform-tests/html/browsers/windows/support-post-to-opener.html: Added.
- web-platform-tests/html/browsers/windows/support-window-name-echo.html: Added.
- web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub-expected.txt: Added.
- web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html: Added.
- web-platform-tests/html/browsers/windows/w3c-import.log: Added.
LayoutTests:
Skip resource files.
- 11:36 AM Changeset in webkit [204843] by
-
- 3 edits1 add in trunk/Source/WebCore
Add a workaround for iOS Frameworks that expect DOM bindings to be in WebCore
https://bugs.webkit.org/show_bug.cgi?id=161093
Reviewed by Dan Bernstein.
Create a text-based stub library that looks enough like WebKitLegacy that we can trick the linker
into creating a LC_REEXPORT_DYLIB load command in WebCore.
- Configurations/WebCore.xcconfig:
Link against this WebKitLegacyStub tbd file on iOS 9.0, 9.3 and 10.0.
- Configurations/WebKitLegacyStub.iOS.tbd:
Add new tbd file.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- 11:14 AM Changeset in webkit [204842] by
-
- 11 edits5 adds in trunk
[ES6] Modules'
export default function/classshould be declaration
https://bugs.webkit.org/show_bug.cgi?id=160499
Reviewed by Saam Barati.
JSTests:
Add several module tests. And flip the failed tests flags in test262.
- modules/export-default-function-name-in-assignment-expression.js: Added.
(export.default):
- modules/export-default-function-name-in-class-declaration.js: Added.
- modules/export-default-function-name-in-function-declaration.js: Added.
(export.default):
- modules/export-default-function-name-in-generator-declaration.js: Added.
(export.default):
- stress/method-name.js: Added.
(testSyntax):
(testSyntaxError):
(testSyntaxError.Hello.prototype.hello.hello):
(testSyntaxError.Hello):
(SyntaxError.Unexpected.identifier.string_appeared_here.Expected.an.opening.string_appeared_here.before.a.method.testSyntaxError.let.obj.hello.hello):
(testSyntaxError.Hello.prototype.get hello):
(testSyntaxError.Hello.prototype.set hello):
- test262.yaml:
Source/JavaScriptCore:
Previously, we parsed the following cases as FunctionExpression and ClassExpression.
`
export default function () { }
export default class { }
`
But, as per ES6 spec, the above
function ...andclass ...parts should be parsed
as function declaration and class declaration. This has big difference; the instantiation
of the function declarations are done in the function prologue.
In this patch, we correctly parse the above cases as declaration. To handle no-named
declarations, we add a new flag, DeclarationDefaultContext. This indicates [Default]
flag in the ES6 spec's BNF.
Furthermore, this patch also fixes the following name related bugs.
- The bug related to "export default"'s function name. If the name is not provided (like the above case), the name of the function becomes
"default", not "*default*". This is special handling in ES6 spec. We handle this in JSFunction's reifyName.
class Hello { hello hello() { } }is accepted. We introduced FunctionRequirements::Unnamed and fix this bug.
- parser/ModuleScopeData.h:
(JSC::ModuleScopeData::exportBinding):
Exported names are already guranteed uniqueness by m_exportedNames. Not necessary to use set here. Use vector instead.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
If we pass FunctionRequirements::NoRequirements, we need to initialize functionInfo.name / classInfo.className
with the default fallback name. For example, in the aboveexport defaultcase, we initialize it with*default*.
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClassDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parseClassExpression):
(JSC::Parser<LexerType>::parseFunctionExpression):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseArrowFunctionExpression):
- parser/Parser.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::reifyName):
- 11:09 AM Changeset in webkit [204841] by
-
- 5 edits in trunk
Unreviewed, rolling out r204243.
Caused some layout test failures
Reverted changeset:
"Write API test to cover crash fix in r204135"
https://bugs.webkit.org/show_bug.cgi?id=160587
http://trac.webkit.org/changeset/204243
- 10:32 AM Changeset in webkit [204840] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT::updateTopCallframe() in the baseline JIT should use PC instead of PC+1
https://bugs.webkit.org/show_bug.cgi?id=158955
Reviewed by Mark Lam.
This will make the baseline JIT consistent with the rest of the tiers.
- jit/JITInlines.h:
(JSC::JIT::updateTopCallFrame):
- 8:34 AM Changeset in webkit [204839] by
-
- 17 edits1 move1 delete in trunk
CanvasRenderingContext2D should not have a CanvasRenderingContext parent interface
https://bugs.webkit.org/show_bug.cgi?id=161054
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
CanvasRenderingContext2D should not have a CanvasRenderingContext parent interface
as per:
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCanvasRenderingContext.h: Renamed from Source/WebCore/bindings/js/JSCanvasRenderingContextCustom.cpp.
(WebCore::toJS):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSCanvasRenderingContext2D::visitAdditionalChildren):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::getCSSCanvasContext):
(WebCore::JSDocument::createTouchList): Deleted.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- dom/Document.idl:
- html/canvas/CanvasRenderingContext.idl: Removed.
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/WebGL2RenderingContext.idl:
- html/canvas/WebGLRenderingContext.idl:
- html/canvas/WebGLRenderingContextBase.idl:
- 8:26 AM Changeset in webkit [204838] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.12/Source/JavaScriptCore
Merge r200387 - Crash: Array.prototype.slice() and .splice() can call fastSlice() after an array is truncated
https://bugs.webkit.org/show_bug.cgi?id=157322
Reviewed by Filip Pizlo.
Check to see if the source array has changed length before calling fastSlice().
If it has, take the slow path.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
- tests/stress/regress-157322.js: New test.
- 8:17 AM Changeset in webkit [204837] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.12/Source/JavaScriptCore
Merge r199277 - Allocation sinking SSA Defs are allowed to have replacements
https://bugs.webkit.org/show_bug.cgi?id=156444
Reviewed by Filip Pizlo.
Consider the following program and the annotations that explain why
the SSA defs we create in allocation sinking can have replacements.
function foo(a1) {
let o1 = {x: 20, y: 50};
let o2 = {y: 40, o1: o1};
let o3 = {};
We're Defing a new variable here, call it o3_field.
o3_field is defing the value that is the result of
a GetByOffset that gets eliminated through allocation sinking.
o3.field = o1.y;
dontCSE();
This control flow is here to not allow the phase to consult
its local SSA mapping (which properly handles replacements)
for the value of o3_field.
if (a1) {
a1 = true;
} else {
a1 = false;
}
Here, we ask for the reaching def of o3_field, and assert
it doesn't have a replacement. It does have a replacement
though. The original Def was the GetByOffset. We replaced
that GetByOffset with the value of the o1_y variable.
let value = o3.field;
assert(value === 50);
}
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- tests/stress/allocation-sinking-defs-may-have-replacements.js: Added.
(dontCSE):
(assert):
(foo):
- 6:53 AM Changeset in webkit [204836] by
-
- 1 edit3 deletes in releases/WebKitGTK/webkit-2.12/LayoutTests
Merge r200378 - Unreviewed, drop outdated layout test after r200375.
- fast/workers/resources/worker-replace-self.js: Removed.
- fast/workers/worker-replace-self-expected.txt: Removed.
- fast/workers/worker-replace-self.html: Removed.
- 6:52 AM Changeset in webkit [204835] by
-
- 3 edits9 adds in releases/WebKitGTK/webkit-2.12
Merge r200375 - WorkerGlobalScope's self, location and navigator attributes should not be replaceable
https://bugs.webkit.org/show_bug.cgi?id=157296
<rdar://problem/25962738>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-05-03
Reviewed by Chris Dumez.
Source/WebCore:
Tests: http/tests/workers/location-readonly.html
http/tests/workers/navigator-readonly.html
http/tests/workers/self-readonly.html
- workers/WorkerGlobalScope.idl:
The 'self', 'location', and 'navigator' properties of the WorkerGlobalScope must be immutable.
See: https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface
LayoutTests:
- http/tests/workers/location-readonly-expected.txt: Added.
- http/tests/workers/location-readonly.html: Added.
- http/tests/workers/navigator-readonly-expected.txt: Added.
- http/tests/workers/navigator-readonly.html: Added.
- http/tests/workers/self-readonly-expected.txt: Added.
- http/tests/workers/self-readonly.html: Added.
- http/tests/workers/worker-location.js: Added.
- http/tests/workers/worker-navigator.js: Added.
- http/tests/workers/worker-self.js: Added.
- 6:43 AM Changeset in webkit [204834] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r203013 - Move shouldInheritSecurityOriginFromOwner() from URL to Document
https://bugs.webkit.org/show_bug.cgi?id=158987
Reviewed by Alex Christensen.
The URL class should not have knowledge of the concept of an origin or the semantics of origin
inheritance as these are higher level concepts. We should make URL::shouldInheritSecurityOriginFromOwner()
a static non-member, non-friend function of Document because its implements the origin semantics
for a Document object as described in section Origin of the HTML5 spec., <https://html.spec.whatwg.org/multipage/browsers.html#origin> (8 July 2016).
These semantics only apply to Documents.
No functionality changed. So, no new tests.
- dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner): Added.
(WebCore::Document::initSecurityContext): Modified to call WebCore::shouldInheritSecurityOriginFromOwner().
(WebCore::Document::initContentSecurityPolicy): Ditto.
- platform/URL.cpp:
(WebCore::URL::shouldInheritSecurityOriginFromOwner): Deleted.
- platform/URL.h:
- 6:43 AM Changeset in webkit [204833] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r202174 - Ignore case in the check for security origin inheritance
https://bugs.webkit.org/show_bug.cgi?id=158878
Reviewed by Alex Christensen.
Source/WebCore:
Darin Adler commented in https://bugs.webkit.org/show_bug.cgi?id=158855:
"Are these comparisons intentionally case sensitive? Shouldn’t they ignore ASCII
case? We could use equalIgnoringASCIICase and equalLettersIgnoringASCIICase for
those two lines instead of using ==. URL::parse normalizes letters in the scheme
and host by using toASCIILower, but does not normalize letters elsewhere in the
URL, such as in the "blank" or "srcdoc" in the above URLs."
Test: http/tests/dom/window-open-about-uppercase-blank-and-access-document.html
- platform/URL.cpp:
(WebCore::URL::shouldInheritSecurityOriginFromOwner):
LayoutTests:
- http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
- http/tests/dom/window-open-about-uppercase-blank-and-access-document.html: Added.
- 6:43 AM Changeset in webkit [204832] by
-
- 5 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r202151 - Restrict security origin inheritance to empty, about:blank, and about:srcdoc URLs
https://bugs.webkit.org/show_bug.cgi?id=158855
<rdar://problem/26142632>
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/tests/dom/window-open-about-blank-and-access-document.html
http/tests/dom/window-open-about-webkit-org-and-access-document.html
Document.cpp previously checked whether a document should inherit its owner's
security origin by checking if the URL is either empty or blank. URL.cpp in
turn only checks if the protocol is "about:" in the isBlankURL() function.
Thus all about:* URLs inherited security origin. This patch restricts
security origin inheritance to empty, about:blank, and about:srcdoc URLs.
Quotes and links from the WHATWG spec regarding about:srcdoc:
7.1 Browsing contexts
A browsing context can have a creator browsing context, the browsing context
that was responsible for its creation. If a browsing context has a parent
browsing context, then that is its creator browsing context. Otherwise, if the
browsing context has an opener browsing context, then that is its creator
browsing context. Otherwise, the browsing context has no creator browsing
context.
https://html.spec.whatwg.org/multipage/browsers.html#concept-document-bc
7.1.1 Nested browsing contexts
Certain elements (for example, iframe elements) can instantiate further
browsing contexts. These are called nested browsing contexts. If a browsing
context P has a Document D with an element E that nests another browsing
context C inside it, then C is said to be nested through D, and E is said to
be the browsing context container of C. If the browsing context container
element E is in the Document D, then P is said to be the parent browsing
context of C and C is said to be a child browsing context of P. Otherwise,
the nested browsing context C has no parent browsing context.
https://html.spec.whatwg.org/multipage/browsers.html#nested-browsing-context
4.8.5 The iframe element
The iframe element represents a nested browsing context.
...
If the srcdoc attribute is specified
Navigate the element's child browsing context to a new response whose
url list consists of about:srcdoc ...
https://html.spec.whatwg.org/multipage/embedded-content.html#attr-iframe-srcdoc
- dom/Document.cpp:
(WebCore::Document::initSecurityContext):
Now uses the URL::shouldInheritSecurityOriginFromOwner() function instead.
(WebCore::Document::initContentSecurityPolicy):
Now uses the URL::shouldInheritSecurityOriginFromOwner() function instead.
(WebCore::shouldInheritSecurityOriginFromOwner): Deleted.
Moved to URL::shouldInheritSecurityOriginFromOwner() and restricted the check.
- platform/URL.cpp:
(WebCore::URL::shouldInheritSecurityOriginFromOwner):
- platform/URL.h:
Moved the function from Document and restricted the check to only allow
security origin inheritance for empty, about:blank, and about:srcdoc URLs.
LayoutTests:
- http/tests/dom/window-open-about-blank-and-access-document-expected.txt: Added.
- http/tests/dom/window-open-about-blank-and-access-document.html: Added.
- http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Added.
- http/tests/dom/window-open-about-webkit-org-and-access-document.html: Added.
- 6:39 AM Changeset in webkit [204831] by
-
- 2 edits in trunk/Tools
Order feature option list in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=161074
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-08-23
Reviewed by Michael Catanzaro.
Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
- Scripts/webkitperl/FeatureList.pm:
- 6:36 AM Changeset in webkit [204830] by
-
- 7 edits in trunk/Source/WebCore
Share and improve extraction of character for operator and token elements
https://bugs.webkit.org/show_bug.cgi?id=160462
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-03
Reviewed by Darin Adler.
No new tests, already covered by existing tests.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::stripLeadingAndTrailingWhitespace): Make this a protected member of
MathMLElement so that it can be used in MathMLTokenElement.
(WebCore::skipLeadingAndTrailingWhitespace): Deleted.
- mathml/MathMLElement.h: Declare stripLeadingAndTrailingWhitespace.
- mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::parseOperatorChar): Use convertToSingleCodePoint to extract
a code point more efficiently. For now, we continue to only handle BMP characters.
- mathml/MathMLTokenElement.cpp:
(WebCore::MathMLTokenElement::convertToSingleCodePoint): Helper function to try and convert a
string to a single code point after having removed leading and trailing space.
- mathml/MathMLTokenElement.h: Declare convertToSingleCodePoint.
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Use convertToSingleCodePoint to extract
a code point more efficiently.
- 6:08 AM Changeset in webkit [204829] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/LayoutTests
Merge r201375 - Update dom/Window/messageevent-source-postmessage-reified.html after r201315
https://bugs.webkit.org/show_bug.cgi?id=158048
Reviewed by Darin Adler.
We need to delete a property that is part of the Window's static table
now in order to force the reification.
- fast/dom/Window/messageevent-source-postmessage-reified.html:
- 6:08 AM Changeset in webkit [204828] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/JavaScriptCore
Merge r201315 - REGRESSION (196374): deleting a global property is expensive
https://bugs.webkit.org/show_bug.cgi?id=158005
Reviewed by Chris Dumez.
- runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty): We only need to reify static properties
if the name being deleted matches a static property. Otherwise, we can
be sure that delete won't observe any static properties.
- 5:59 AM Changeset in webkit [204827] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201332 - REGRESSION (r196629): Safari can get into a state where switching Reader theme doesn't apply to the webpage
https://bugs.webkit.org/show_bug.cgi?id=158018
<rdar://problem/24732776>
Reviewed by Darin Adler.
When a tab goes to background we clear the style resolver. It is recreated lazily when the tab is again active.
However style invalidation code tests if the style resolver exists and skips the invalidation if it doesn't.
With sufficiently simple document (like in Reader) we may never create one for other reasons and so style
invalidation doesn't work.
No test, don't know how to make one.
- dom/Element.cpp:
(WebCore::Element::needsStyleInvalidation):
Remove styleResolverIfExists() check and do the invalidation normally.
Instead check for forced style recalc. If there is one pending we don't need to bother with invalidation.
- 5:57 AM Changeset in webkit [204826] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.12
Merge r201516 - REGRESSION (r189567): Elements with aspect ratios not handled correctly inside flexbox.
https://bugs.webkit.org/show_bug.cgi?id=158040
Reviewed by Zalan Bujtas.
Source/WebCore:
Added new tests in fast/flexbox.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::clientLogicalBottomAfterRepositioning):
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisLengthIsDefinite):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
(WebCore::RenderFlexibleBox::crossAxisLengthIsDefinite):
(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing):
(WebCore::RenderFlexibleBox::adjustChildSizeForAspectRatioCrossAxisMinAndMax):
(WebCore::RenderFlexibleBox::useChildAspectRatio):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::resetAutoMarginsAndLogicalTopInCrossAxis):
(WebCore::RenderFlexibleBox::mainAxisOverflowForChild):
(WebCore::RenderFlexibleBox::mainAxisExtentIsDefinite): Deleted.
(WebCore::RenderFlexibleBox::mainAxisLengthIsIndefinite): Deleted.
- rendering/RenderFlexibleBox.h:
(WebCore::RenderFlexibleBox::isFlexibleBoxImpl):
LayoutTests:
- fast/flexbox/aspect-ratio-intrinsic-adjust-expected.html: Added.
- fast/flexbox/aspect-ratio-intrinsic-adjust.html: Added.
- fast/flexbox/resources/subjects_sm.png: Added.
- 5:56 AM WebKitGTK/2.12.x edited by
- (diff)
- 5:54 AM Changeset in webkit [204825] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/JavaScriptCore
Merge r202899 - [ARMv7] REGRESSION(r197655): ASSERTION FAILED: (cond == Zero) (cond == NonZero) https://bugs.webkit.org/show_bug.cgi?id=159419
Reviewed by Benjamin Poulain.
Allow Signed and PositiveOrZero conditions too because tst instruction updates N and Z flags.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchTest32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTest32): Add assertions to avoid possible bugs in the future.
- 5:53 AM Changeset in webkit [204824] by
-
- 10 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r199017 - Regression(r196145): Crash in getOwnPropertyDescriptor on http://www.history.com/shows/vikings
https://bugs.webkit.org/show_bug.cgi?id=156136
<rdar://problem/25410767>
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
Add a few more identifiers for using in the generated bindings.
- runtime/CommonIdentifiers.h:
Source/WebCore:
The page was crashing when doing the following:
Object.getOwnPropertyDescriptor(window, "indexedDB")
getOwnPropertyDescriptor() expected getDirect() to return a CustomGetterSetter for
CustomAccessors but it was not the case for window.indexedDB. The reason was that
window.indexedDB was a special property, which is not part of the static table but
returned by GetOwnPropertySlot() if IndexedDB feature is enabled. This weirdness
was due to our bindings generator not having proper support for [EnabledAtRuntime]
properties on Window.
This patch adds support for [EnabledAtRuntime] properties on Window by omitting
these properties from the static property table and then setting them at runtime
in JSDOMWindow::finishCreation() if the corresponding feature is enabled.
window.indexedDB now looks like a regular property when IndexedDB is enabled
and getOwnPropertyDescriptor() works as expected for this property.
Test: storage/indexeddb/indexeddb-getownpropertyDescriptor.html
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):
- Modules/indexeddb/DOMWindowIndexedDatabase.h:
The generated bindings pass DOMWindow by reference instead of pointer so update
the implementation accordingly.
- Modules/indexeddb/DOMWindowIndexedDatabase.idl:
Add 'indexedDB' and 'webkitIndexedDB' properties and mark them as
[EnabledAtRuntime]. Now that the bindings generator correctly handles
[EnabledAtRuntime] properties on the Window, there is no need to
custom-handle them in JSDOMWindowCustom.
- bindings/js/JSDOMWindowCustom.cpp:
Drop custom handling for 'indexedDB' and 'webkitIndexedDB' properties
in getOwnPropertySlot(). The generated bindings code now makes sure to
only set those properties on the Window if IndexedDB is enabled so we
can let the regular code path look up those properties.
- bindings/scripts/CodeGeneratorJS.pm:
(GetJSCAttributesForAttribute):
(GenerateHeader):
(GeneratePropertiesHashTable):
(GenerateImplementation):
Add support for [EnabledAtRuntime] properties on DOMWindow. For such
properties, we do the following:
- Omit them from the static property table
- In JSDOMWindow::finishCreation(), dynamically add those properties at runtime if the corresponding feature is enabled.
Note that this works for constructors as well.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::assertIDBFactory):
Pass Window by reference instead of pointer.
LayoutTests:
Add a layout test to confirm that calling Object.getOwnPropertyDescriptor(window, "indexedDB")
does not crash and works as expected.
- storage/indexeddb/indexeddb-getownpropertyDescriptor-expected.txt: Added.
- storage/indexeddb/indexeddb-getownpropertyDescriptor.html: Added.
- 5:30 AM Changeset in webkit [204823] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12
Merge r203446 - JSC JIT Broken on ARMv7 Traditional (without Thumb2)
https://bugs.webkit.org/show_bug.cgi?id=159880
Reviewed by Carlos Garcia Campos.
- Source/cmake/OptionsCommon.cmake: Use the BFD linker on ARM traditional because of a gold linker bug.
- 5:30 AM WebKitGTK/2.12.x edited by
- (diff)
- 5:28 AM Changeset in webkit [204822] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r202145 - Include cstdlib before using std::atexit
https://bugs.webkit.org/show_bug.cgi?id=158681
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2016-06-16
Reviewed by Brent Fulgham.
- platform/graphics/PlatformDisplay.cpp:
- 5:28 AM Changeset in webkit [204821] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201595 - [Wayland] PlatformDisplayWayland destructor is super crashy
https://bugs.webkit.org/show_bug.cgi?id=157973
Reviewed by Michael Catanzaro.
EGL registers two at exist callbacks one to finish the display and another one to unload drivers, the one to
finish the display happens first. When our destructor is called the _eglFiniDisplay callback has already been
called, so we have a valid pointer for an already finished display. Then eglTerminate tries to find the display
in the global display list, but fails and for some reason it crashes when trying to return an error.
If atexit is called after the global PlatformDisplay constructor, the atexit handler is called before the
destructor. The atexit callbacks are called in reverse order, so if we register an atexit handler after the
global instace has been created and after EGL has been initialized, we could terminate the EGL display before
the EGL atexit handlers and the global PlatformDisplay destructor.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::initializeEGLDisplay):
- 5:27 AM WebKitGTK/2.12.x edited by
- (diff)
- 5:23 AM Changeset in webkit [204820] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203976 - REGRESSION (r196383): Drop down CSS menus not working on cnet.com, apmex.com
https://bugs.webkit.org/show_bug.cgi?id=160390
Reviewed by Simon Fraser.
Source/WebCore:
The case here is that we have a rule like
.enableHover:hover .child { ... }
and the "enableHover" class is added dynamically. The class change invalidation optimization code would figure out
that nothing needs to be invalidated as the class change doesn't make the rule match (since :hover doesn't match).
However for event driven hover to actually work the hover element needs to have its childrenAffectedByHover bit set.
This bits is set when the selector match is attempted, whether it actually matches or not. Since we optimized away
the style invalidation we never set the bit either.
Fix by treating :hover as always matching (==ignored) when collecting rules for invalidation optimization purposes.
Dynamic pseudo elements are already treated this way for similar reasons.
Test: fast/selectors/hover-invalidation-descendant-dynamic.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
Match always in CollectingRulesIgnoringVirtualPseudoElements mode (now slightly misnamed).
This mode is used for optimization purposes in StyleInvalidationAnalysis (which we care about here) and
StyleSharingResolver. The change is fine for both.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
Same change for the slow path selector checker.
LayoutTests:
- fast/selectors/hover-invalidation-descendant-dynamic-expected.txt: Added.
- fast/selectors/hover-invalidation-descendant-dynamic.html: Added.
- 5:23 AM WebKitGTK/2.12.x edited by
- (diff)
- 5:17 AM Changeset in webkit [204819] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/po
Merge r204372 - [GTK] German translation update
https://bugs.webkit.org/show_bug.cgi?id=152228
Rubber-Stamped by Michael Catanzaro.
Patch by Bernd Homuth <dev@hmt.im> on 2016-08-11
- de.po: Update to reviewed translation from 2016-08-05.
- 5:16 AM Changeset in webkit [204818] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r204250 - [GTK] Bad performance in accelerated compositing mode with the modesetting intel driver and DRI3 enabled
https://bugs.webkit.org/show_bug.cgi?id=160491
Reviewed by Michael Catanzaro.
This is becoming the default in several linux distributions and it makes WebKitGTK+ unusable in accelerated
compositing mode, which is now always enabled because since we switched to use the threaded compositor. The
problem seems to be an optimization of the intel driver for windows that are offscreen, and our redirected
window is always positioned at ScreenWidth + 1, 0. Using negative coordinates to position the redirected window
offscreen fixes the problem.
See also https://bugs.freedesktop.org/show_bug.cgi?id=85064.
- WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp:
(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Position the parent window at -1, -1.
- 5:14 AM Changeset in webkit [204817] by
-
- 3 edits in trunk/LayoutTests
[WK2] http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html fails
https://bugs.webkit.org/show_bug.cgi?id=161052
<rdar://problem/27954577>
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-23
- platform/mac-wk2/TestExpectations: Adding Failure/Timeout expectation to
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html
- platform/wk2/TestExpectations: Removing Timeout expectation from
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html
- 5:13 AM Changeset in webkit [204816] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r204080 - [GTK] Document how to initialize WebKitFaviconDatabase
https://bugs.webkit.org/show_bug.cgi?id=160391
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
- 5:11 AM Changeset in webkit [204815] by
-
- 9 edits1 copy in releases/WebKitGTK/webkit-2.12/Source
Merge r203155 - [GTK] WebKitGtk+ uses too many file descriptors
https://bugs.webkit.org/show_bug.cgi?id=152316
Reviewed by Michael Catanzaro.
Source/WebKit2:
The problem is that we are keeping file descriptors open in SharedMemory objects. Those objects can be kept
alive for a long time, for example in case of cached resources sent from the network process as shareable
resources. The thing is that we keep the file descriptor in the SharedMemory object only to be able to create a
Handle, duplicating the file descriptor. However, we are also assuming that we create handles for SharedMemory
objects created by another handle which is wrong. SharedMemory objects are created to map a file or data and
then a handle is created to send it to another process, or to map an existing file or data for a given handle
received from another process. They can also be created to wrap another map, but in that case we don't own the
file descritor nor the mapped data. So, after mapping from a handle, we no longer need the file descriptor, and
it can be closed to release it, while the mapped memory data will still be alive until munmap() is called. This
drastically reduces the amount of file descriptors used by WebKitGTK+.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readBytesFromSocket): Use setCloseOnExec().
(IPC::Connection::createPlatformConnection): Ditto.
- Platform/SharedMemory.h:
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::map): Close the file descriptor right after mmap.
(WebKit::SharedMemory::~SharedMemory): Close the file descriptor only if it hasn't been closed yet.
(WebKit::SharedMemory::createHandle): Add an ASSERT to ensure we only try to create a handle for SharedMemory
objects having a valid file descriptor. Use dupCloseOnExec() to duplicate the handle and set the close on exec flag.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Use setCloseOnExec().
Source/WTF:
Add helper functions to duplicate a file descriptor setting close on exec flag, and also to set close on exec
flag to an existing file descriptor.
- wtf/UniStdExtras.h:
- wtf/UniStdExtras.cpp
(WTF::setCloseOnExec):
(WTF::dupCloseOnExec):
- 4:42 AM Changeset in webkit [204814] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12
[GTK] Null Node dereference in FrameSelection::notifyAccessibilityForSelectionChange of FrameSelectionAtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=159411
Patch by Fujii Hironori <Fujii Hironori> on 2016-07-04
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Tests:
editing/selection/selection-in-iframe-removed-crash.html
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
Added a null check for the return value of containerNode().
LayoutTests:
- platform/gtk/TestExpectations: Removed a crash expectation of
editing/selection/selection-in-iframe-removed-crash.html.
- 4:42 AM Changeset in webkit [204813] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r202807 - [GTK] Null WebCore::Range dereference in WebEditorClient::updateGlobalSelection
https://bugs.webkit.org/show_bug.cgi?id=159341
Patch by Fujii Hironori <Fujii Hironori> on 2016-07-04
Reviewed by Carlos Garcia Campos.
FrameSelection::toNormalizedRange() can return null. Null check is
needed.
Tests:
editing/input/set-value-on-input-and-delete.html
editing/selection/selection-in-iframe-removed-crash.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html
imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::updateGlobalSelection): Do not update
global selection if FrameSelection::toNormalizedRange() returns
null.
- 4:40 AM Changeset in webkit [204812] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r202801 - [GTK] ASSERTION_FAILED: m_key != PTHREAD_KEYS_MAX when defining WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH
https://bugs.webkit.org/show_bug.cgi?id=158149
Patch by Fujii Hironori <Fujii Hironori> on 2016-07-04
Reviewed by Carlos Garcia Campos.
WTF::sleep can not be used at the beginning of web process because
WTF is not initialized at the moment yet.
- WebProcess/gtk/WebProcessMainGtk.cpp: Use g_usleep instead of WTF::sleep.
- 4:38 AM Changeset in webkit [204811] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r201921 - [GTK] Browser plugins crash under Wayland
https://bugs.webkit.org/show_bug.cgi?id=157605
Reviewed by Michael Catanzaro.
Fail the initialization of windowed plugins if we don't have a platform implementation.
- WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:
(WebKit::NetscapePlugin::platformPostInitialize):
- 4:36 AM Changeset in webkit [204810] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r201749 - [GTK] Hide GTK+ 2 plugins if GTK+ 2 plugin process was built but is not installed
https://bugs.webkit.org/show_bug.cgi?id=158419
Reviewed by Carlos Garcia Campos.
- UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::getPluginInfo):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 4:36 AM Changeset in webkit [204809] by
-
- 12 edits2 moves in trunk/Source/WebCore
Rename MathMLInlineContainerElement to MathMLPresentationElement
https://bugs.webkit.org/show_bug.cgi?id=161053
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-23
Reviewed by Manuel Rego Casasnovas.
MathMLInlineContainerElement sounds a bad name for something that is now going to produce
RenderMathMLBlocks. MathML has two kinds of markup (presentation MathML and content MathML).
We only implement presentation MathML and most of the MathML elements are currently
implemented as MathMLInlineContainerElement. Hence we rename MathMLInlineContainerElement
to MathMLPresentationElement and will move more code from MathMLElement into that new class
in follow-up bugs. Also, other elements in the MathML namespace could be handled by a
separate MathMLUnknownElement class for consistency with SVG and HTML classes.
No new tests, behavior is unchanged.
- CMakeLists.txt: Rename MathMLInlineContainerElement to MathMLPresentationElement.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAllInOne.cpp: Ditto.
- mathml/MathMLFractionElement.cpp: Ditto.
- mathml/MathMLFractionElement.h: Ditto.
- mathml/MathMLPresentationElement.cpp: Ditto.
- mathml/MathMLPresentationElement.h: Ditto.
- mathml/MathMLRowElement.cpp: Ditto.
- mathml/MathMLRowElement.h: Ditto.
- mathml/MathMLScriptsElement.cpp: Ditto.
- mathml/MathMLScriptsElement.h: Ditto.
- mathml/mathtags.in: Ditto.
- rendering/mathml/RenderMathMLFraction.h: Remove useless include.
- 4:35 AM Changeset in webkit [204808] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r201381 - [Unix] Potential buffer overrun of m_fileDescriptors in readBytesFromSocket of ConnectionUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=158058
Patch by Fujii Hironori <Fujii Hironori> on 2016-05-25
Reviewed by Carlos Garcia Campos.
Memcpy does not check the boundary of m_fileDescriptors in
readBytesFromSocket of ConnectionUnix.cpp. This is not a problem
in normal cases, but in the case when Web process is hijacked and
malicious IPC packets were sent. WTF::Vector already has two
members m_capacity and m_size. There is no need to have a
separate member m_fileDescriptorsSize to remember the number of
remaining data.
- Platform/IPC/Connection.h: Remove members m_readBufferSize and
m_fileDescriptorsSize.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::platformInitialize): Removed initialization of
m_readBufferSize and m_fileDescriptorsSize. Reserve initial
capacity for m_readBuffer and m_fileDescriptors.
(IPC::Connection::processMessage): Replace m_readBufferSize and
m_fileDescriptorsSize with m_readBuffer.size() and
m_fileDescriptors.size(). Use Vector::shrink() to reset the
number of remaining data in the buffers.
(IPC::readBytesFromSocket) : Change argument types to WTF::Vector
instead of pointers and sizes.
(IPC::Connection::readyReadHandler): Call new readBytesFromSocket
- 4:16 AM Changeset in webkit [204807] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2
Merge r202939 - Fix crash when sending failure message to closed WebProcess
https://bugs.webkit.org/show_bug.cgi?id=159526
<rdar://problem/26767037>
Reviewed by Brady Eidson.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFailLoading):
Check to see if there is a connection before using it to send a message.
Sometimes it was null.
I think this could be tested if we had real network loading from TestWebKitAPI
by cancelling slow loads and closing WebProcesses around the same time, but no such infrastructure exists yet.
- 4:14 AM Changeset in webkit [204806] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r203129 - [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
https://bugs.webkit.org/show_bug.cgi?id=159663
<rdar://problem/18995873>
Reviewed by Benjamin Poulain.
Source/WebKit2:
Protect against bad database data in LocalStorageDatabase::importItems(). We
crash if the database contains a null key or a null value so protect against
it given that we have evidence it can happen.
With this change, I can no longer reproduce the UIProcess crash on evernote.com
that is documented at <rdar://problem/18995873>.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::importItems):
Tools:
Add API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
(-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):
- 4:11 AM Changeset in webkit [204805] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203249 - editing/spelling/spellcheck-async.html sometimes crashes with GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=142969
<rdar://problem/27331095>
Reviewed by Alex Christensen.
Fix based on a Blink change (patch by <rouslan@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/c713736b122c2224804b2db72f1f711cb47ee260%5E%21/#F1>
Source/WebCore:
Test: editing/spelling/copy-paste-crash.html
editing/spelling/spellcheck-async.html
- editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::didSucceed):
(WebCore::SpellCheckRequest::didCancel):
LayoutTests:
- editing/spelling/copy-paste-crash-expected.txt: Added.
- editing/spelling/copy-paste-crash.html: Added.
- platform/platform/mac-wk2/TestExpectations: Skip test on mac-wk2 since all Spelling tests are
currently broken (see <https://webkit.org/b/105616>).
- 4:08 AM Changeset in webkit [204804] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r203503 - [Cairo] Fix a crash in fast/canvas/canvas-getImageData-invalid-result-buffer-crash.html
https://bugs.webkit.org/show_bug.cgi?id=160014
Reviewed by Michael Catanzaro.
In r202887 some null checks were added for JSArray::createUninitialized (and related) but not for the
ImageBuffer cairo implementation.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::getImageData): Return early if Uint8ClampedArray::createUninitialized() returns nullptr.
- 4:08 AM Changeset in webkit [204803] by
-
- 8 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r202887 - Return values of JSArray::createUninitialized (and related) are not consistently checked for nullptr
https://bugs.webkit.org/show_bug.cgi?id=159495
<rdar://problem/26075433>
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/canvas/canvas-getImageData-invalid-result-buffer-crash.html
- html/ImageData.cpp:
(WebCore::ImageData::ImageData): Assert at construction if we could not create a valid
buffer.
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::createArrayBuffer): Check for a null buffer before using it.
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData): Ditto.
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplySoftware): Ditto.
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::copyImageBytes): Ditto.
(WebCore::FilterEffect::copyUnmultipliedImage): Ditto.
(WebCore::FilterEffect::copyPremultipliedImage): Ditto.
LayoutTests:
- fast/canvas/canvas-getImageData-invalid-result-buffer-crash.html: Added.
- fast/canvas/canvas-getImageData-invalid-result-buffer-crash-expected.txt: Added.
- 4:03 AM Changeset in webkit [204802] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203729 - Infinite Canvas context save() causes WebKit to crash
https://bugs.webkit.org/show_bug.cgi?id=159586
<rdar://problem/26759984>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-07-26
Reviewed by Simon Fraser.
Source/WebCore:
Limit the size of the canvas context state stack to 1024 * 16 saves. All
the saves which come after that limit will stay unrealized. The restore()
should not have any effect till there is no unrealized saves.
Test: fast/canvas/canvas-context-save-limit.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::realizeSaves):
(WebCore::CanvasRenderingContext2D::realizeSavesLoop):
- html/canvas/CanvasRenderingContext2D.h:
LayoutTests:
- fast/canvas/canvas-context-save-limit-expected.txt: Added.
- fast/canvas/canvas-context-save-limit.html: Added.
- 3:58 AM Changeset in webkit [204801] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r204631 - DumpRenderTree crashed in com.apple.WebCore: WebCore::DOMWindow::resetDOMWindowProperties + 607
https://bugs.webkit.org/show_bug.cgi?id=160983
<rdar://problem/26768524>
Reviewed by Brent Fulgham.
Update DOMWindow::frameDestroyed() to ref the window object as the crash
traces seem to indicate it can get destroyed during the execution of this
method. Also update the code in the ~Frame destructor to not iterate over
the list of FrameDestructionObservers because observers remove themselves
from the list when they get destroyed.
No new tests, do not know how to reproduce.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::frameDestroyed):
- page/Frame.cpp:
(WebCore::Frame::~Frame):
- 3:56 AM Changeset in webkit [204800] by
-
- 9 edits1 copy1 add17 deletes in releases/WebKitGTK/webkit-2.12
Merge r204197 - marquee with "truespeed" animates at > 60fps, hogging CPU
https://bugs.webkit.org/show_bug.cgi?id=160609
Reviewed by David Hyatt.
Source/WebCore:
A <marquee truespeed="" scrollDelay="0"> would fire a zero-delay timer and also
fail to animate, hogging CPU.
Fix to cap the timer at 16ms intervals. We don't believe it's necessary to
maintain web compatibility here.
Tested by existing tests.
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::minimumDelay):
- html/HTMLMarqueeElement.h:
LayoutTests:
Convert marquee tests into ref tests, removing all the platform expectations.
- fast/html/marquee-scroll-expected.html: Copied from LayoutTests/fast/html/marquee-scroll.html.
- fast/html/marquee-scroll.html:
- fast/html/marquee-scrollamount-expected.html: Added.
- fast/html/marquee-set-truespeed.html:
- platform/efl/fast/html/marquee-scroll-expected.png: Removed.
- platform/efl/fast/html/marquee-scroll-expected.txt: Removed.
- platform/efl/fast/html/marquee-scrollamount-expected.png: Removed.
- platform/efl/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/gtk/fast/html/marquee-scroll-expected.png: Removed.
- platform/gtk/fast/html/marquee-scroll-expected.txt: Removed.
- platform/gtk/fast/html/marquee-scrollamount-expected.png: Removed.
- platform/gtk/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/ios-simulator/fast/html/marquee-scroll-expected.txt: Removed.
- platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/mac-wk1/TestExpectations:
- platform/mac/fast/html/marquee-scroll-expected.png: Removed.
- platform/mac/fast/html/marquee-scroll-expected.txt: Removed.
- platform/mac/fast/html/marquee-scrollamount-expected.png: Removed.
- platform/mac/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/win/TestExpectations:
- platform/win/fast/html/marquee-scroll-expected.txt: Removed.
- platform/win/fast/html/marquee-scrollamount-expected.txt: Removed.
- 3:45 AM Changeset in webkit [204799] by
-
- 3 edits2 moves1 add1 delete in releases/WebKitGTK/webkit-2.12
Merge r203695 - Allow LocalStorage by default for file URLs.
https://bugs.webkit.org/show_bug.cgi?id=160169
Reviewed by Brent Fulgham.
Source/WebCore:
Test: storage/domstorage/localstorage/file-can-access.html
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccessStorage): Remove the m_universalAccess check for local URLs.
LayoutTests:
- storage/domstorage/localstorage/blocked-file-access-expected.txt: Removed.
- storage/domstorage/localstorage/file-can-access-expected.txt: Added.
- storage/domstorage/localstorage/file-can-access.html: Renamed from LayoutTests/storage/domstorage/localstorage/blocked-file-access.html.
- storage/domstorage/localstorage/resources/unblocked-example.html: Renamed from LayoutTests/storage/domstorage/localstorage/resources/blocked-example.html.
- 3:45 AM Changeset in webkit [204798] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Revert "Unreviewed. Fix compatibility issue with 2.12.1 regarding local storage access from file URLs."
This reverts commit 6df4cefb055caf694b9939dd5bbe94595bd52c9b.
- 3:41 AM Changeset in webkit [204797] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203288 - WebKit should prevent push/replace state with username in URL.
<rdar://problem/27361737> and https://bugs.webkit.org/show_bug.cgi?id=159818
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/security/history-username-password.html
- page/History.cpp:
(WebCore::History::stateObjectAdded): Don't allow URLs with usernames/passwords.
LayoutTests:
- http/tests/security/history-username-password-expected.txt: Added.
- http/tests/security/history-username-password.html: Added.
- 3:39 AM Changeset in webkit [204796] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203258 - Remove credentials in URL when accessed through location.href
https://bugs.webkit.org/show_bug.cgi?id=139562
<rdar://problem/27331164>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/security/location-href-clears-username-password.html
The reason for this change is to not allow scripts on the page to
exfiltrate username and password from the URL.
- page/Location.cpp:
(WebCore::Location::href):
Now checks if there is a username or password in the URL. If so,
it copies the URL and removes the username and password.
LayoutTests:
The reason for this change is to not allow scripts on the page to
exfiltrate username and password from the URL.
- http/tests/security/location-href-clears-username-password-expected.txt: Added.
- http/tests/security/location-href-clears-username-password.html: Added.
Test case adapted from https://src.chromium.org/viewvc/blink?revision=189367&view=revision.
- 3:18 AM Changeset in webkit [204795] by
-
- 8 edits5 adds in trunk
Implement redirect support post CORS-preflight
https://bugs.webkit.org/show_bug.cgi?id=159056
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-23
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/cors/cors-redirect-preflight-expected.txt: Added.
- web-platform-tests/fetch/api/cors/cors-redirect-preflight-worker-expected.txt: Added.
- web-platform-tests/fetch/api/cors/cors-redirect-preflight-worker.html: Added.
- web-platform-tests/fetch/api/cors/cors-redirect-preflight.html: Added.
- web-platform-tests/fetch/api/cors/cors-redirect-preflight.js: Added.
(corsRedirect):
Source/WebCore:
Tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight-worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.html
Covered also by rebased tests.
Enabling to follow cross-origin redirections for not-simple requests, through preflight checks.
Making sure that same-origin redirections to cross-origin resources use preflight if they are not simple.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
LayoutTests:
- TestExpectations: Skipping new fetch worker test in Debug mode as it may crash and disrupt other tests.
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
- http/tests/xmlhttprequest/redirections-and-user-headers-expected.txt:
- http/tests/xmlhttprequest/redirections-and-user-headers.html:
- 3:15 AM Changeset in webkit [204794] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203684 - The web process hangs when computing elements-based snap points for a container with large max scroll offset
https://bugs.webkit.org/show_bug.cgi?id=152605
<rdar://problem/25353661>
Reviewed by Simon Fraser.
Source/WebCore:
Fixes a bug in the computation of axis snap points. The ScrollSnapPoints object, which tracks
snap points along a particular axis, has two flags, hasRepeat and usesElements. For elements-
based snapping, both flags would be turned on, since StyleBuilderConverter::convertScrollSnapPoints
short-circuits for elements-based snapping and does not default usesRepeat to false. To address this,
we make ScrollSnapPoints not repeat(100%) by default.
Test: css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertScrollSnapPoints): Deleted.
- rendering/style/StyleScrollSnapPoints.cpp:
(WebCore::ScrollSnapPoints::ScrollSnapPoints):
LayoutTests:
Adds a scroll snap offset computation test case that would have previously
caused the web process to hang before this patch.
- css3/scroll-snap/scroll-snap-elements-container-larger-than-children-expected.txt: Added.
- css3/scroll-snap/scroll-snap-elements-container-larger-than-children.html: Added.
- 3:09 AM Changeset in webkit [204793] by
-
- 3 edits8 adds in releases/WebKitGTK/webkit-2.12
Merge r202712 - Drawing an SVG image into a <canvas> that is not in the DOM draws the wrong region
https://bugs.webkit.org/show_bug.cgi?id=159276
Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Dean Jackson.
Source/WebCore:
In the event where the <img> element that we are passing to CanvasRenderingContext2D.drawImage()
points to an SVG resource, we ensure that the container for the SVG image is sized to match the
HTML element. The necessity for setting this container size, explained in webkit.org/b/148845,
is that we must ensure a cached image does not have an outdated container size.
Tests: svg/as-image/img-with-svg-resource-in-dom-and-drawImage.html
svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage.html
svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage.html
svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
LayoutTests:
Adding a series of new tests to check we correctly respect mismatching source and
destination rectangles with SVG images as sources, both with the source <img> element
being present and absent from the DOM, and explicit sizes being set or not set.
- svg/as-image/img-with-svg-resource-in-dom-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-in-dom-and-drawImage.html: Added.
- svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage-expected.html: Added.
- svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage.html: Added.
- 3:05 AM Changeset in webkit [204792] by
-
- 7 edits in releases/WebKitGTK/webkit-2.12
Merge r202104 - GoogleMaps transit schedule explorer comes up blank initially
https://bugs.webkit.org/show_bug.cgi?id=158803
rdar://problem/25818080
Source/WebCore:
Reviewed by Andreas Kling.
In case we had something like
.foo bar { ... }
and later a new stylesheet was added dynamically that contained
.foo baz { ... }
we would fail to add the new rules to the descendant invalidation rule sets for ".foo". This could
cause some style invalidations to be missed.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::collectFeatures):
Reset the ancestorClassRules and ancestorAttributeRulesForHTML rule set caches when new style sheets
are added (==collectFeatures is called).
LayoutTests:
Reviewed by Andreas Kling
Expand the tests to cover this case.
- fast/css/style-invalidation-attribute-change-descendants-expected.txt:
- fast/css/style-invalidation-attribute-change-descendants.html:
- fast/css/style-invalidation-class-change-descendants-expected.txt:
- fast/css/style-invalidation-class-change-descendants.html:
- 2:57 AM Changeset in webkit [204791] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201608 - Fix a couple of mistakes in CSSParserValue memory management
https://bugs.webkit.org/show_bug.cgi?id=158307
<rdar://problem/26127225>
Source/WebCore:
Patch by Darin Adler <Darin Adler> on 2016-06-02
Reviewed by Daniel Bates.
- css/CSSGrammar.y.in: Added a destructor for calc_func_term. This presumably
fixes some memory leaks in error cases. Removed an assertion about not needing
a call to destroy that was far too limited. Tweaked formatting of the percentage
ase in the key production. Indented calc_func_term to make it consistent with
other productions nearby.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValueList::~CSSParserValueList): Use a modern for loop.
(WebCore::CSSParserValueList::deleteValueAt): Deleted. Unused function, and also
would have resulted in a memory leak unless the code already extracted the value
from the list.
(WebCore::CSSParserValueList::extend): Properly transfer ownership from one value
list to the other by setting the unit to 0 in the donor.
- css/CSSParserValues.h: Removed unused deleteValueAt function.
LayoutTests:
Reviewed by Darin Adler.
- fast/css/calc-with-two-variables-crash-expected.txt: Added.
- fast/css/calc-with-two-variables-crash.html: Added.
- 2:52 AM Changeset in webkit [204790] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r202022 - SVG elements don't blend correctly into HTML
https://bugs.webkit.org/show_bug.cgi?id=158718
<rdar://problem/26782004>
Reviewed by Antoine Quint.
Source/WebCore:
We were not creating any transparency layers for the root SVG nodes.
This is ok if the SVG is the root document, because it is the backdrop.
However, if it is inline SVG, it needs to apply the operation in
order to composite into the document.
Test: svg/css/mix-blend-mode-with-inline-svg.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
LayoutTests:
- svg/css/mix-blend-mode-with-inline-svg-expected.html: Added.
- svg/css/mix-blend-mode-with-inline-svg.html: Added.
- 2:51 AM Changeset in webkit [204789] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201889 - Changing canvas height immediately after page load does not relayout canvas
https://bugs.webkit.org/show_bug.cgi?id=156097
Patch by Antoine Quint <Antoine Quint> on 2016-06-09
Reviewed by Zalan Bujtas.
Source/WebCore:
Promote the logic use to identify whether we should perform a layout after a change of
intrinsic size from RenderImage to RenderReplaced such that RenderCanvas may use it
in canvasSizeChanged() and correctly update its layout in the case where the width
or height attribute is updated and there are no explicit sizing performed with CSS.
Additionally, this will also account for the object-fix property to only perform
a layout if necessary.
Test: fast/canvas/canvas-css-size-after-height-change-with-display-flex.html
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::repaintOrMarkForLayout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):
- rendering/RenderReplaced.h:
LayoutTests:
- fast/canvas/canvas-css-size-after-height-change-with-display-flex-expected.html: Added.
- fast/canvas/canvas-css-size-after-height-change-with-display-flex.html: Added.
- 2:41 AM Changeset in webkit [204788] by
-
- 25 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201740 - URLs containing tabs or newlines are parsed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=143381
<rdar://problem/26567214>
Reviewed by Brent Fulgham.
Source/WebCore:
- Strip any tabs and newlines in the URL input.
- Replace the original stripping URL leading and trailing white spaces logic with WTFString's
builtin, and move this logic to the very begining of the URL parser.
- Enhance the protocolIs method to ignore any leading whitespace/control characters, and
tabs/newlines of the examining url.
Test: fast/url/tab-and-newline-stripping.html
- platform/URL.cpp:
(WebCore::isTabNewline):
(WebCore::shouldTrimFromURL):
(WebCore::URL::init):
(WebCore::protocolIs):
LayoutTests:
- fast/dom/DOMURL/set-href-attribute-host-expected.txt:
- fast/dom/DOMURL/set-href-attribute-host.html:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js:
- fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:
- fast/url/segments-expected.txt:
- fast/url/segments-from-data-url-expected.txt:
- fast/url/segments-from-data-url.html:
- fast/url/segments.html:
- fast/url/tab-and-newline-stripping-expected.txt: Added.
- fast/url/tab-and-newline-stripping.html: Added.
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
- http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
- http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
- 2:39 AM Changeset in webkit [204787] by
-
- 6 edits2 deletes in releases/WebKitGTK/webkit-2.12
Merge r201292 - Unreviewed, rolling out r200414.
This change appears to have broken the 'write a reply' field
on Nextdoor.com
Reverted changeset:
"Clicks inside button elements are sometimes discarded when
the mouse moves"
https://bugs.webkit.org/show_bug.cgi?id=39620
http://trac.webkit.org/changeset/200414
- 2:21 AM Changeset in webkit [204786] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201358 - [Font Loading] Crash during font download failure after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=158013
<rdar://problem/25148032>
Reviewed by Darin Adler.
Source/WebCore:
Usually, ownership during font loading is top-down - JavaScript owns a JSFontFace,
which owns a FontFace, which owns a CSSFontFace. However, when we receive the
asynchronous callback that a font finished loading, the call comes in from the
bottom - it is delivered from the CSSFontFaceSource to the CSSFontFace, and then
to the FontFace. If a garbage collection had previously run, we might remove
the last reference to ourself during this asynchronous callback. A simple guard
makes sure this doesn't happen.
Test: fast/text/font-face-crash.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded):
LayoutTests:
- fast/text/font-face-crash-expected.txt: Added.
- fast/text/font-face-crash.html: Added.
- 2:18 AM Changeset in webkit [204785] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201218 - Scrolling broken in iTunes connect pages
https://bugs.webkit.org/show_bug.cgi?id=157678
Reviewed by Zalan Bujtas.
Source/WebCore:
Added fast/flexbox/nested-columns-min-intrinsic-disabled.html
Turn off minimum intrinsic size adjustment for flexboxes. This violates the spec,
but until we can produce good results that is what we need to do. Blink has also
turned off nested columns intrinsic sizing as well, so we match them with this
change.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
LayoutTests:
- fast/flexbox/nested-column-intrinsic-min-disabled-expected.html: Added.
- fast/flexbox/nested-column-intrinsic-min-disabled.html: Added.
- 1:43 AM Changeset in webkit [204784] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200171 - SVG SMIL animations run at less than 60fps
https://bugs.webkit.org/show_bug.cgi?id=157119
rdar://problem/25971304
Reviewed by Tim Horton.
If you re-fetch current time while doing animation computations you're gonna have
a bad time.
More specifically, SMILTimeContainer::startTimer() re-fetched elapsedTime() when
computing the delay for the next timer fire, then clamped to 16.667ms, so the timer
would actually be scheduled at intervals greater than desired, causing a ~54fps framerate.
Fix by using the elapsedTime fetched at the start of animation processing.
Tested by iOS content-animation performance tests.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement): Just cleanup.
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::notifyIntervalsChanged):
(WebCore::SMILTimeContainer::resume):
(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SMILTimeContainer.h:
- 1:42 AM Changeset in webkit [204783] by
-
- 5 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r200164 - CSS and SVG animations should run at 60fps
https://bugs.webkit.org/show_bug.cgi?id=157113
rdar://problem/24337280
rdar://problem/24337328
Reviewed by Dean Jackson.
For both CSS and SVG animations we used a 0.025s frame interval, which translates to
40fps. That caused these animations to look extra janky compared with accelerated
animations.
So use a 16.667ms frame interval for both.
Tested by content-animation benchmark tests.
- page/animation/AnimationController.cpp:
- svg/animation/SMILTime.h:
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateNextProgressTime):
- 1:33 AM Changeset in webkit [204782] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r203425 - REGRESSION(r203415): ASSERTION FAILED: !m_layoutRoot->container() !m_layoutRoot->container()->needsLayout() https://bugs.webkit.org/show_bug.cgi?id=159952
Reviewed by Simon Fraser.
Update ASSERTs to reflect new functionality, that is, now we can end up in a state
where the container (RenderView) of one of the dirty subtrees is dirty.
See r203415.
Covered by editing/pasteboard/drag-drop-input-in-svg.svg
- page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
- 1:32 AM Changeset in webkit [204781] by
-
- 3 edits3 adds in releases/WebKitGTK/webkit-2.12
Merge r203415 - theguardian.co.uk crossword puzzles are sometimes not displaying text
https://bugs.webkit.org/show_bug.cgi?id=159924
<rdar://problem/27409483>
Reviewed by Simon Fraser.
Source/WebCore:
This patch fixes the case when
- 2 disjoint subtrees are dirty
- RenderView is also dirty.
and we end up not laying out one of the 2 subtrees.
In FrameView::scheduleRelayoutOfSubtree, we assume that when the RenderView is dirty
we already have a pending full layout which means that any previous subtree layouts have already been
converted to full layouts.
However this assumption is incorrect. RenderView can get dirty without checking if there's
already a pending subtree layout.
One option to solve this problem would be to override RenderObject::setNeedsLayout in RenderView
so that when the RenderView gets dirty, we could also convert any pending subtree layout to full layout.
However RenderObject::setNeedsLayout is a hot function and making it virtual would impact performance.
The other option is to always normalize subtree layouts in FrameView::scheduleRelayoutOfSubtree().
This patch implements the second option.
Test: fast/misc/subtree-layouts.html
- page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
LayoutTests:
- fast/misc/subtree-layouts-expected.html: Added.
- fast/misc/subtree-layouts.html: Added.
- 1:31 AM Changeset in webkit [204780] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r203091 - Unable to edit fields or drag to select text in Dashboard widgets.
https://bugs.webkit.org/show_bug.cgi?id=159647
<rdar://problem/26941698>
Reviewed by Brent Fulgham.
RenderObject::computeAbsoluteRepaintRect's first paramenter is no longer in/out. Use the return
value to set the clip on the dashboard region.
Not testable.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addAnnotatedRegions):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addAnnotatedRegions):
- 1:28 AM Changeset in webkit [204779] by
-
- 27 edits2 copies in trunk/Source/WebCore
Introduce a MathMLRowElement class for mrow-like elements
https://bugs.webkit.org/show_bug.cgi?id=161050
Reviewed by Darin Adler.
We introduce a MathMLRowElement class for elements creating RenderMathMLRow renderers.
We also force constructors of the corresponding renderer classes to accept MathMLRowElement.
It's not clear whether semantics-xml really needs to create RenderMathMLRow but for now
we make MathMLAnnotationElement inherits from MathMLRowElement to preserve that behavior.
No new tests, behavior is unchanged.
- CMakeLists.txt: Add MathMLRowElement files.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAllInOne.cpp: Ditto.
- mathml/MathMLInlineContainerElement.cpp: Remove unused headers.
(WebCore::MathMLInlineContainerElement::createElementRenderer): Handle some mrow-like
elements in the MathMLRowElement class.
(WebCore::MathMLInlineContainerElement::acceptsDisplayStyleAttribute): Ditto.
(WebCore::MathMLInlineContainerElement::childrenChanged): Deleted. We only need to calculate
the form for operators inside a MathMLRowElement.
(WebCore::MathMLInlineContainerElement::acceptsMathVariantAttribute): Deleted. mstyle is
handled in the MathMLRowElement class.
- mathml/MathMLInlineContainerElement.h: Update function declarations.
- mathml/MathMLMathElement.cpp: Make this class inherits from MathMLRowElement.
- mathml/MathMLMathElement.h: Ditto.
- mathml/MathMLPaddedElement.cpp: Ditto.
- mathml/MathMLPaddedElement.h: Ditto.
- mathml/MathMLSelectElement.cpp: Ditto.
- mathml/MathMLSelectElement.h: Ditto.
- mathml/MathMLAnnotationElement.cpp: Ditto.
- mathml/MathMLAnnotationElement.h: Ditto.
- mathml/MathMLRowElement.cpp: New class for mrow-like element.
(WebCore::MathMLRowElement::MathMLRowElement):
(WebCore::MathMLRowElement::create):
(WebCore::MathMLRowElement::childrenChanged): Move code from MathMLInlineContainerElement.
(WebCore::MathMLRowElement::createElementRenderer): Ditto.
(WebCore::MathMLRowElement::acceptsDisplayStyleAttribute): Ditto.
(WebCore::MathMLRowElement::acceptsMathVariantAttribute): Ditto.
- mathml/MathMLRowElement.h:
- mathml/mathtags.in: Map tags creating RenderMathMLRow renderers to MathMLRowElement.
- rendering/mathml/RenderMathMLFenced.cpp: Force the constructor to take MathMLRowElement.
- rendering/mathml/RenderMathMLFenced.h: Ditto.
- rendering/mathml/RenderMathMLMath.cpp: Ditto.
- rendering/mathml/RenderMathMLMath.h: Ditto.
- rendering/mathml/RenderMathMLMenclose.cpp: Force the constructor to take MathMLMencloseElement.
- rendering/mathml/RenderMathMLMenclose.h: Ditto.
- rendering/mathml/RenderMathMLRoot.cpp: Force the constructor to take MathMLRowElement.
- rendering/mathml/RenderMathMLRoot.h: Ditto.
- rendering/mathml/RenderMathMLRow.cpp: Ditto and add an helper function element() to
retrieve the MathMLRowElement.
- rendering/mathml/RenderMathMLRow.h: Ditto.
- 1:23 AM Changeset in webkit [204778] by
-
- 4 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r203045 - Fix LogicalSelectionOffsetCaches to work with detached render tree.
https://bugs.webkit.org/show_bug.cgi?id=159605
<rdar://problem/27248845>
Reviewed by Brent Fulgham.
Source/WebCore:
When the renderer that is being destroyed is on a selection boundary,
we need to ensure that all its cached pointers across the selection code (e.g. SelectionSubtreeData)
are getting reset. In order to do that, we call clearSelection() on the RenderView.
One of the last steps of clearing selection is to collect the selection gaps. Selection gaps uses this
LogicalSelectionOffsetCaches helper class to collect selection information across blocks.
LogicalSelectionOffsetCaches normally operates on rooted renderers. However we need to ensure sure that
it can also handle renderers that are no longer part of the render tree.
Test: fast/text/selection-on-a-detached-tree.html
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset):
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):
LayoutTests:
- fast/text/selection-on-a-detached-tree-expected.txt: Added.
- fast/text/selection-on-a-detached-tree.html: Added.
- 1:22 AM Changeset in webkit [204777] by
-
- 4 edits3 adds in releases/WebKitGTK/webkit-2.12
Merge r202769 - prepareForDestruction() always needs to be called before destroying the Document object.
https://bugs.webkit.org/show_bug.cgi?id=159372
rdar://problem/26788150
Reviewed by Antti Koivisto.
We should never start destroying the Document object without calling prepareForDestruction() first.
It ensures that render tree gets nuked before we start tearing down the node tree.
Source/WebCore:
Test: fast/history/page-cache-destroy-document.html
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
LayoutTests:
- fast/history/page-cache-destroy-document-expected.txt: Added.
- fast/history/page-cache-destroy-document.html: Added.
- fast/history/resources/page-cache-destroy-helper.html: Added.
- 12:35 AM Changeset in webkit [204776] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] URTBF after r204743.
- Shared/WebBatteryStatus.cpp: Remove Arguments.h.
- 12:23 AM Changeset in webkit [204775] by
-
- 15 edits1 copy2 adds in trunk/Source/WebInspectorUI
Web Inspector: Add visual editor for spring() timing-function
https://bugs.webkit.org/show_bug.cgi?id=159315
Patch by Devin Rousso <Devin Rousso> on 2016-08-23
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Main.html:
- UserInterface/Base/Utilities.js:
(Number.prototype.maxDecimals):
Limits the number of decimals for the number object via rounding.
- UserInterface/Controllers/CodeMirrorSpringEditingController.js:
(WebInspector.CodeMirrorSpringEditingController.prototype.get initialValue):
(WebInspector.CodeMirrorSpringEditingController.prototype.get cssClassName):
(WebInspector.CodeMirrorSpringEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorSpringEditingController.prototype.popoverDidPresent):
(WebInspector.CodeMirrorSpringEditingController.prototype.popoverDidDismiss):
(WebInspector.CodeMirrorSpringEditingController.prototype._springEditorSpringChanged):
Controller for Spring editors inside CodeMirror instances.
- UserInterface/Models/Geometry.js:
(WebInspector.Spring):
(WebInspector.Spring.fromValues):
(WebInspector.Spring.fromString):
(WebInspector.Spring.prototype.copy):
(WebInspector.Spring.prototype.toString):
(WebInspector.Spring.prototype.solve):
(WebInspector.Spring.prototype.calculateDuration):
Spring data class based on <https://webkit.org/demos/spring/>.
- UserInterface/Models/TextMarker.js:
(WebInspector.TextMarker.Type):
Added Spring marker type.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createInlineSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createInlineSwatches.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._inlineSwatchValueChanged):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._inlineSwatchValueChanged.update):
- UserInterface/Views/CodeMirrorTextMarkers.js:
(createCodeMirrorSpringTextMarkers):
- UserInterface/Views/InlineSwatch.css:
(.inline-swatch:matches(.bezier, .spring)):
(.inline-swatch:matches(.bezier, .spring):hover):
(.inline-swatch:matches(.bezier, .spring):active):
(.inline-swatch:matches(.bezier, .spring) > span):
(.inline-swatch.bezier): Deleted.
(.inline-swatch.bezier:hover): Deleted.
(.inline-swatch.bezier:active): Deleted.
(.inline-swatch.bezier > span): Deleted.
- UserInterface/Views/InlineSwatch.js:
(WebInspector.InlineSwatch):
(WebInspector.InlineSwatch.prototype._fallbackValue):
(WebInspector.InlineSwatch.prototype._swatchElementClicked):
(WebInspector.InlineSwatch.prototype._valueEditorValueDidChange):
(WebInspector.InlineSwatch.Type):
Added support for Spring editor Inline Swatches.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._updateEditableMarkers):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):
- UserInterface/Views/SpringEditor.css:
(.spring-editor):
(.spring-editor > .spring-preview):
(.spring-editor > .spring-preview > div):
(.spring-editor > .spring-timing):
(.spring-editor > .spring-timing > div):
(.spring-editor > .spring-timing:matches(::before, ::after)):
(.spring-editor > .spring-timing::before):
(.spring-editor > .spring-timing::after):
(.spring-editor > :matches(.spring-preview, .spring-timing) > div):
(.spring-editor > .animate:matches(.spring-preview, .spring-timing) > div):
(.spring-editor > .number-input-container > .number-input-row):
(.spring-editor > .number-input-container > .number-input-row > .number-input-row-title):
(.spring-editor > .number-input-container > .number-input-row > input):
(.spring-editor > .number-input-container > .number-input-row > input[type="range"]):
- UserInterface/Views/SpringEditor.js:
(WebInspector.SpringEditor):
(WebInspector.SpringEditor.prototype.get element):
(WebInspector.SpringEditor.prototype.set spring):
(WebInspector.SpringEditor.prototype.get spring):
(WebInspector.SpringEditor.prototype._handleNumberInputInput):
(WebInspector.SpringEditor.prototype._handleNumberInputKeydown):
(WebInspector.SpringEditor.prototype._handleNumberSliderInput):
(WebInspector.SpringEditor.prototype._handleNumberSliderMousedown):
(WebInspector.SpringEditor.prototype._handleNumberSliderMouseup):
(WebInspector.SpringEditor.prototype._changeSpringForInput):
(WebInspector.SpringEditor.prototype._resetPreviewAnimation):
(WebInspector.SpringEditor.prototype._updatePreviewAnimation):
(WebInspector.SpringEditor.Event):
Visual editor for CSS Spring timing function values. Organized into 5 rows:
- Preview: shows movement of spring and total duration
- Mass: slider and input for "mass" parameter
- Stiffness: slider and input for "stiffness" parameter
- Damping: slider and input for "damping" parameter
- Initial Velocity: slider and input for "initial velocity" parameter
The preview animation will loop indefinitely until the user clicks the animation row
or changes the value of one of the parameters, at which point the duration will also
be recalculated.
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.createSpringMarkers):
(WebInspector.TextEditor.prototype.editingControllerForMarker):
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.set value):
(WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._generateTextFromLonghandProperties):
Add support for CSS spring timing functions by allowing parenthesis in comma separated
values so long as there are no commas inside the parenthesis.
- UserInterface/Views/VisualStyleTimingEditor.css:
(.visual-style-property-container.timing-editor > .visual-style-property-value-container > .inline-swatch:matches(.bezier, .spring)):
(.visual-style-property-container.timing-editor > .visual-style-property-value-container:not(.spring-value) > .inline-swatch.spring):
(.visual-style-property-container.timing-editor > .visual-style-property-value-container > .inline-swatch.bezier): Deleted.
(.visual-style-property-container.timing-editor > .visual-style-property-value-container:not(.bezier-value) > .inline-swatch.bezier): Deleted.
- UserInterface/Views/VisualStyleTimingEditor.js:
(WebInspector.VisualStyleTimingEditor):
(WebInspector.VisualStyleTimingEditor.prototype.get value):
(WebInspector.VisualStyleTimingEditor.prototype.set value):
(WebInspector.VisualStyleTimingEditor.prototype.get synthesizedValue):
(WebInspector.VisualStyleTimingEditor.prototype.parseValue):
(WebInspector.VisualStyleTimingEditor.prototype.get _bezierValue):
(WebInspector.VisualStyleTimingEditor.prototype.set _bezierValue):
(WebInspector.VisualStyleTimingEditor.prototype.get _springValue):
(WebInspector.VisualStyleTimingEditor.prototype.set _springValue):
(WebInspector.VisualStyleTimingEditor.prototype._handleKeywordChanged):
(WebInspector.VisualStyleTimingEditor.prototype._springSwatchValueChanged):
(WebInspector.VisualStyleTimingEditor.prototype.get bezierValue): Renamed.
(WebInspector.VisualStyleTimingEditor.prototype.set bezierValue): Renamed.
Duplicate Bezier custom timing function logic for Spring timing functions.
- 12:17 AM Changeset in webkit [204774] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r202251 - Set the end position on the placeholder BidiRun properly.
https://bugs.webkit.org/show_bug.cgi?id=158958
Reviewed by Myles C. Maxfield.
rdar://problem/26609266
The second paramenter for BidiRun indicates the end position and not the length of the run.
This was regressed at r102875 where only the start position was changed from 0 to pos.
Source/WebCore:
Test: fast/text/international/bidi-style-in-isolate-crash.html
- rendering/InlineIterator.h:
(WebCore::addPlaceholderRunForIsolatedInline):
LayoutTests:
- fast/text/international/bidi-style-in-isolate-crash-expected.txt: Added.
- fast/text/international/bidi-style-in-isolate-crash.html: Added.
- 12:12 AM Changeset in webkit [204773] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r202146 - [New Block-Inside-Inline Model] Do not attempt to re-run margin collapsing on the block sequence.
https://bugs.webkit.org/show_bug.cgi?id=158854
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/block/inside-inlines/crash-on-first-line-change.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::marginCollapseLinesFromStart):
LayoutTests:
- fast/block/inside-inlines/crash-on-first-line-change-expected.txt: Added.
- fast/block/inside-inlines/crash-on-first-line-change.html: Added.
- 12:09 AM Changeset in webkit [204772] by
-
- 3 edits in trunk/Source/WebKit2
Use Messages::XXX...::Reply explicitly
https://bugs.webkit.org/show_bug.cgi?id=161075
Reviewed by Carlos Garcia Campos.
std::tuple's constructor is annotated as
explicit.
So we cannot use the implicit conversion here.
This causes the build failure in EFL and GTK.
Looking through code, the other places use ::Reply explicitly.
So in this patch, we follow that.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::supportsFullScreen):
- 12:09 AM Changeset in webkit [204771] by
-
- 6 edits2 copies2 adds in releases/WebKitGTK/webkit-2.12
Merge r202123 - Decouple the percent height and positioned descendants maps.
https://bugs.webkit.org/show_bug.cgi?id=158773
Reviewed by David Hyatt and Chris Dumez.
Source/WebCore:
We track renderers with percent height across multiple containers using
HashMap<const RenderBox*, std::unique_ptr<HashSet<const RenderBlock*>>>.
We also use the same data structure to track positioned descendants.
However a positioned renderer can have only one containing block so tracking it
with a 1:many type is defective.
It allows multiple inserts for positioned descendants, which could lead to
inconsistent layout state as the rendering logic expects these type of renderers
with only one containing block.
This patch decouples percent height and positioned tracking by introducing
the PositionedDescendantsMap class. This class is responsible for tracking
the positioned descendants inbetween layouts.
No change in functionality.
Tests: fast/block/positioning/change-containing-block-for-absolute-positioned.html
fast/block/positioning/change-containing-block-for-fixed-positioned.html
- rendering/RenderBlock.cpp:
(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::PositionedDescendantsMap::addDescendant): Add more defensive ASSERT_NOT_REACHED
to the double insert branch when webkit.org/b/158772 gets fixed.
(WebCore::PositionedDescendantsMap::removeDescendant):
(WebCore::PositionedDescendantsMap::removeContainingBlock):
(WebCore::PositionedDescendantsMap::positionedRenderers):
(WebCore::positionedDescendantsMap):
(WebCore::removeBlockFromPercentageDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::positionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::removePercentHeightDescendant):
(WebCore::RenderBlock::percentHeightDescendants):
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
(WebCore::removeBlockFromDescendantAndContainerMaps): Deleted.
- rendering/RenderBlock.h:
LayoutTests:
Various dynamic containing block changing tests.
- fast/block/fixed-position-reparent-when-transition-is-removed.html:
- fast/block/positioning/change-containing-block-for-absolute-positioned-expected.txt: Added.
- fast/block/positioning/change-containing-block-for-absolute-positioned.html: Added.
- fast/block/positioning/change-containing-block-for-fixed-positioned-expected.txt: Added.
- fast/block/positioning/change-containing-block-for-fixed-positioned.html: Added.
- 12:09 AM Changeset in webkit [204770] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r202044 - Make RenderBlock::insertInto/RemoveFromTrackedRendererMaps functions static.
https://bugs.webkit.org/show_bug.cgi?id=158722
Reviewed by Simon Fraser.
These functions manipulate static tracker hashmaps. They don't need to be on RenderBlock.
This is also in preparation for decoupling positioned descendant tracking from descendent percentage height handling.
(gPositionedDescendantsMap and gPercentHeightDescendantsMap)
No change in functionality.
- rendering/RenderBlock.cpp:
(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps): Deleted.
(WebCore::RenderBlock::removeFromTrackedRendererMaps): Deleted.
- rendering/RenderBlock.h:
- 12:07 AM Changeset in webkit [204769] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=161043
Reviewed by Mark Lam.
Ignore warning about bit shift by too large amount.
- jit/PCToCodeOriginMap.cpp:
Aug 22, 2016:
- 11:59 PM Changeset in webkit [204768] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201985 - Cleanup RenderBlock::removePositionedObjects
https://bugs.webkit.org/show_bug.cgi?id=158670
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::removePositionedObjects):
- rendering/RenderBlock.h:
- 11:52 PM Changeset in webkit [204767] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201984 - Remove positioned descendants when RenderBlock is no longer a containing block.
https://bugs.webkit.org/show_bug.cgi?id=158655
<rdar://problem/26510032>
Reviewed by Simon Fraser.
Normally the RenderView is the containing block for fixed positioned renderers.
However when a renderer acquires some transform related properties, it becomes the containing
block for all the fixed positioned renderers in its descendant tree.
When the last transform related property is removed, the renderer is no longer a containing block
and we need to remove all these positioned renderers from the descendant tracker map (gPositionedDescendantsMap).
They will be inserted back into the tracker map during the next layout (either under the RenderView or
under the next transformed renderer in the ancestor chain).
Source/WebCore:
Test: fast/block/fixed-position-reparent-when-transition-is-removed.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removePositionedObjectsIfNeeded):
LayoutTests:
- fast/block/fixed-position-reparent-when-transition-is-removed-expected.txt: Added.
- fast/block/fixed-position-reparent-when-transition-is-removed.html: Added.
- 11:51 PM Changeset in webkit [204766] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201666 - Incorrect rendering on boostmobile FAQ page
https://bugs.webkit.org/show_bug.cgi?id=158303
<rdar://problem/26603462>
Reviewed by Chris Dumez.
Initial value for background-color is 'transparent'. see https://drafts.csswg.org/css-backgrounds-3/#background-color
Source/WebCore:
Test: fast/selectors/non-visited-link-backround-color.html
- css/CSSPropertyNames.in:
LayoutTests:
- fast/selectors/non-visited-link-backround-color-expected.html: Added.
- fast/selectors/non-visited-link-backround-color.html: Added.
- 11:44 PM Changeset in webkit [204765] by
-
- 50 edits in trunk
Drop TextTrackCue's constructor as per the latest specification
https://bugs.webkit.org/show_bug.cgi?id=161061
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt:
Source/WebCore:
Drop TextTrackCue's constructor as per the latest specification:
Firefox and Chrome do not have this constructor. Web Authors
are supposed to use the VTTCue constructor instead.
No new tests, rebaselined existing tests.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): Deleted.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::cueShadowPseudoId): Deleted.
- html/track/TextTrackCue.idl:
LayoutTests:
Update existing tests to use VTTCue's constructor instead of
TextTrackCue's.
- js/dom/constructor-length.html:
- media/track/getCueAsHTMLCrash.html:
- media/track/opera/interfaces/TextTrack/activeCues.html:
- media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html:
- media/track/opera/interfaces/TextTrackCue/line.html:
- media/track/opera/interfaces/TextTrackCue/onenter.html:
- media/track/opera/interfaces/TextTrackCue/onexit.html:
- media/track/opera/interfaces/TextTrackCue/snapToLines.html:
- media/track/opera/interfaces/TextTrackCue/text.html:
- media/track/opera/interfaces/TextTrackCue/vertical.html:
- media/track/opera/interfaces/TextTrackCueList/getter.html:
- media/track/opera/track/track-element/src-clear-cues.html:
- media/track/opera/track/webvtt/rendering/reftest/repaint.html:
- media/track/regions-webvtt/text-track-cue-region-attribute.html:
- media/track/track-add-remove-cue-expected.txt:
- media/track/track-add-remove-cue.html:
- media/track/track-cue-empty-cue-text.html:
- media/track/track-cue-empty-text-crash.html:
- media/track/track-cue-inline-assertion-crash.html:
- media/track/track-cue-negative-timestamp-expected.txt:
- media/track/track-cue-negative-timestamp.html:
- media/track/track-cue-rendering-empty-cue-crash.html:
- media/track/track-cue-rendering-mode-changed.html:
- media/track/track-disabled-addcue.html:
- media/track/track-remove-active-cue-crash.html:
- media/track/w3c/interfaces/TextTrack/addCue.html:
- media/track/w3c/interfaces/TextTrack/cues.html:
- media/track/w3c/interfaces/TextTrack/removeCue.html:
- media/track/w3c/interfaces/TextTrackCue/align.html:
- media/track/w3c/interfaces/TextTrackCue/endTime.html:
- media/track/w3c/interfaces/TextTrackCue/id.html:
- media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html:
- media/track/w3c/interfaces/TextTrackCue/startTime.html:
- media/track/w3c/interfaces/TextTrackCue/track.html:
- media/track/w3c/interfaces/TextTrackCueList/getCueById.html:
- media/track/w3c/interfaces/TextTrackCueList/length.html:
- media/video-controls-captions.html:
- platform/mac/js/dom/constructor-length-expected.txt:
- 11:35 PM Changeset in webkit [204764] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201407 - Setting overflow:hidden does not always repaint clipped content.
https://bugs.webkit.org/show_bug.cgi?id=116994
rdar://problem/26476697
Issue repaint for both layout and visual overflow rects when the container starts
clipping overflow content.
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/overflow-hidden-repaint.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateFromStyle):
LayoutTests:
- fast/repaint/overflow-hidden-repaint-expected.html: Added.
- fast/repaint/overflow-hidden-repaint.html: Added.
- 11:34 PM Changeset in webkit [204763] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r201384 - Addressing post-review comments on r200971.
Reviewed by Darin Adler.
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- 11:24 PM Changeset in webkit [204762] by
-
- 8 edits in releases/WebKitGTK/webkit-2.12
Merge r201346 - fast/table/neighboring-cells-when-collapsed-border-changes.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=158009
Reviewed by David Hyatt.
RenderTable::invalidateCollapsedBorders() early returns on m_collapsedEmptyBorderIsPresent
which prevents us from marking neighboring cells dirty when style changes.
Decouple the "invalidate the collapsed borders" and the "mark the neighboring cells dirty" logic.
Source/WebCore:
Covered by existing tests. (and now we agree with FF on cached-change-cell-border-width.html)
- rendering/RenderTable.cpp:
(WebCore::RenderTable::invalidateCollapsedBorders):
(WebCore::markCellDirtyWhenCollapsedBorderChanges): Deleted.
- rendering/RenderTableCell.cpp:
(WebCore::markCellDirtyWhenCollapsedBorderChanges):
(WebCore::RenderTableCell::styleDidChange):
LayoutTests:
- fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Progression. FF agrees.
- fast/table/neighboring-cells-when-collapsed-border-changes.html:
- platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- platform/mac-wk1/TestExpectations:
- platform/mac/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
- 11:22 PM Changeset in webkit [204761] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.12
Merge r201296 - Changing border color and size simultaneously fails to repaint.
https://bugs.webkit.org/show_bug.cgi?id=157967
<rdar://problem/26423918>
Reviewed by David Hyatt.
This patch ensures that the neighboring tables cells are dirtied when collapsed border change requires layout.
Source/WebCore:
Test: fast/table/neighboring-cells-when-collapsed-border-changes.html
- rendering/RenderTable.cpp:
(WebCore::markCellDirtyWhenCollapsedBorderChanges):
(WebCore::RenderTable::invalidateCollapsedBorders):
LayoutTests:
- fast/table/neighboring-cells-when-collapsed-border-changes-expected.html: Added.
- fast/table/neighboring-cells-when-collapsed-border-changes.html: Added.
- 11:19 PM Changeset in webkit [204760] by
-
- 10 edits4 adds in releases/WebKitGTK/webkit-2.12
Merge r201234 -
width: 1%on nested table cell causes its table to hog horizontal space
https://bugs.webkit.org/show_bug.cgi?id=144696
<rdar://problem/20839572>
Reviewed by David Hyatt and Tim Horton.
This patch is based on https://chromium.googlesource.com/chromium/src/+/9428cfb16993a2329e87c65da096ca295132ef0f
Source/WebCore:
Tests: fast/table/inner-percent-width-affects-outer-floated-div.html
fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html
- rendering/AutoTableLayout.cpp:
(WebCore::shouldScaleColumnsForParent):
(WebCore::shouldScaleColumnsForSelf):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::shouldScaleColumns): Deleted.
- rendering/AutoTableLayout.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
- rendering/TableLayout.h:
(WebCore::TableLayout::scaledWidthFromPercentColumns):
LayoutTests:
- fast/table/inner-percent-width-affects-outer-floated-div-expected.html: Added.
- fast/table/inner-percent-width-affects-outer-floated-div.html: Added.
- fast/table/inner-percent-width-doesnt-affect-ancestor-columns-expected.html: Added.
- fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html: Added.
- platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- platform/mac/fast/table/max-width-integer-overflow-expected.txt:
- 11:09 PM Changeset in webkit [204759] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles -> Computed -> Box Model shows NaN x NaN for invisible elements
https://bugs.webkit.org/show_bug.cgi?id=161038
Patch by Devin Rousso <Devin Rousso> on 2016-08-22
Reviewed by Joseph Pecoraro.
- UserInterface/Base/Utilities.js:
Add figureDash variable.
- UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
Moved isNaN check of value to common createElement.
- 10:56 PM Changeset in webkit [204758] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual styles sidebar should do something sane for SVG elements
https://bugs.webkit.org/show_bug.cgi?id=148269
Patch by Devin Rousso <Devin Rousso> on 2016-08-22
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.get ownerSVGElement):
(WebInspector.DOMNode.prototype.isSVGElement):
Climbs ancestor tree to determine if node is an SVG node.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
(WebInspector.VisualStyleDetailsPanel.prototype._populatePositionSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateDimensionsSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateFillSection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateStrokeSection):
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container.inactive):
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container)):
- UserInterface/Views/VisualStyleRelativeNumberSlider.css:
(.visual-style-property-container.number-input-box.relative-number-slider > .relative-slider):
- UserInterface/Views/VisualStyleUnitSlider.css:
(.visual-style-property-container.unit-slider > .visual-style-property-value-container > .slider):
(.visual-style-property-container.unit-slider.opacity > .visual-style-property-value-container > .slider): Deleted.
- 10:34 PM Changeset in webkit [204757] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual Styles: "Text -> Content" section should only be visible for pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=158272
Patch by Devin Rousso <Devin Rousso> on 2016-08-22
Reviewed by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/VisualStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive):
(.sidebar > .panel.details.css-style .visual > .details-section :matches(.details-section, .group).inactive > *):
(.visual-style-property-container.transition): Deleted.
(.visual-style-property-container.animation): Deleted.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
(WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection):
- 10:12 PM Changeset in webkit [204756] by
-
- 3 edits in trunk/Tools
Stop python icon bouncing in the dock while running browser benchmarks.
https://bugs.webkit.org/show_bug.cgi?id=161066
Reviewed by Ryosuke Niwa.
Bouncing python icon may impact browser benchmark results.
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepare_env):
(OSXBrowserDriver.restore_env):
- 10:12 PM Changeset in webkit [204755] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Entering ":n" in Open Resource Dialog, where n > number of lines, should jump to the last line
https://bugs.webkit.org/show_bug.cgi?id=160840
Patch by Devin Rousso <Devin Rousso> on 2016-08-22
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TextEditor.js:
(TextEditor.prototype.revealPosition):
Limit the given line and column to the maximum number of lines and the column count on the
resulting line.
- 9:47 PM Changeset in webkit [204754] by
-
- 7 edits4 adds in trunk/Source/WebInspectorUI
Web Inspector: Add indicator to matched selector being a pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=160893
Patch by Devin Rousso <Devin Rousso> on 2016-08-22
Reviewed by Joseph Pecoraro.
Instead of using "{}" icons for CSS rules, use a "P" icon with the same coloring to identify
that the rule contains a pseudo-selector that is currently being applied to the selected element.
- UserInterface/Base/Utilities.js:
(Array.prototype.toggleIncludes):
Toggles whether or not to include the given value in the array based on its existence or a
"force" flag parameter.
- UserInterface/Images/StyleRuleAuthorPseudo.svg:
- UserInterface/Images/StyleRuleInspectorPseudo.svg:
- UserInterface/Images/StyleRuleUserAgentPseudo.svg:
- UserInterface/Images/StyleRuleUserPseudo.svg:
- UserInterface/Models/CSSRule.js:
(WebInspector.CSSRule.prototype.hasMatchedPseudoElementSelector):
- UserInterface/Models/CSSSelector.js:
(WebInspector.CSSSelector.prototype.isPseudoElementSelector):
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
- UserInterface/Views/StyleRuleIcons.css:
(.author-style-rule-icon.pseudo-element-selector .icon):
(.user-style-rule-icon.pseudo-element-selector .icon):
(.user-agent-style-rule-icon.pseudo-element-selector .icon):
(.inspector-style-rule-icon.pseudo-element-selector .icon):
- UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem):
(WebInspector.VisualStyleSelectorTreeItem.prototype.get iconClassName):
(WebInspector.VisualStyleSelectorTreeItem.prototype._updateSelectorIcon):
- 6:49 PM Changeset in webkit [204753] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update failure list of iOS simulator WK1 compositing test.
- platform/ios-simulator-wk1/TestExpectations:
- 6:32 PM Changeset in webkit [204752] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, iOS simulator WK1 tests gardening.
Move the following tests from failure to pass:
compositing/iframes/become-composited-nested-iframes.html,
compositing/images/clip-on-directly-composited-image.html,
compositing/overflow/dynamic-composited-scrolling-status.html.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 6:04 PM Changeset in webkit [204751] by
-
- 2 edits30 deletes in trunk/LayoutTests
Unreviewed, iOS simulator WK1 tests rebasing.
- platform/ios-simulator-wk1/compositing/absolute-inside-out-of-view-fixed-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/backface-visibility-in-3dtransformed-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/border-radius-no-backing-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/filter-no-backing-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/masked-child-no-backing-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/no-backing-for-opacity-0-child-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/replaced-child-no-backing-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/backing/toggle-opacity-0-child-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/bounds-in-flipped-writing-mode-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/clipping/border-radius-overflow-hidden-stacking-context-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/columns/ancestor-clipped-in-paginated-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/columns/clipped-in-paginated-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/columns/composited-columns-vertical-rl-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/columns/composited-nested-columns-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/background-clip-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/background-color-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/body-background-painted-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/body-background-skipped-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/filter-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/layer-opacity-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/layer-transform-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/opaque-with-scrolled-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/table-parts-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/contents-opaque/visibility-hidden-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/bounds-clipped-composited-child-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/bounds-ignores-hidden-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/clip-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/clip-inside-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/fixed-transformed-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/foreground-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/iframes/resizer-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/mismatched-rotated-transform-animation-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/multiple-keyframes-animation-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-animation-clipping-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-animation-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-transformed-3d-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/scale-rotation-animation-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/subpixel-adjacent-layers-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/translate-animation-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/translate-scale-animation-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/layer-creation/will-change-change-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/masks/clip-path-composited-descendent-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/masks/mask-layer-size-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/media-controls-bar-appearance-big-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/media-controls-bar-appearance-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/overflow-trumps-transform-style-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/overflow/resize-painting-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/regions/fixed-transformed-in-named-flow-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/repaint/positioned-movement-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/rtl/rtl-relative-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/video/video-object-position-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/visibility/layer-visible-content-expected.txt: Removed.
- platform/ios-simulator-wk1/compositing/visible-rect/backing-change-height-from-zero-expected.txt: Removed.
- platform/ios-simulator-wk2/compositing/layer-creation/overlap-animation-container-expected.txt: Removed.
- platform/ios-simulator/compositing/layer-creation/overlap-animation-container-expected.txt:
- 5:48 PM Changeset in webkit [204750] by
-
- 1 copy in tags/Safari-602.1.50.0.6
New tag.
- 5:43 PM Changeset in webkit [204749] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed, build fix on GCC environment
https://bugs.webkit.org/show_bug.cgi?id=161058
std::forward is declared in <utility> header.
- bmalloc/ScopeExit.h:
- 5:03 PM Changeset in webkit [204748] by
-
- 17 edits1 copy1 move in trunk
Unreviewed, rolling out r204745.
Broke the Windows build
Reverted changeset:
"CanvasRenderingContext2D should not have a
CanvasRenderingContext parent interface"
https://bugs.webkit.org/show_bug.cgi?id=161054
http://trac.webkit.org/changeset/204745
- 4:30 PM Changeset in webkit [204747] by
-
- 6 edits3 adds in branches/safari-602.1.50.0-branch
Merge r204521. rdar://problem/27075526
- 4:23 PM Changeset in webkit [204746] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 4:23 PM Changeset in webkit [204745] by
-
- 17 edits1 move1 delete in trunk
CanvasRenderingContext2D should not have a CanvasRenderingContext parent interface
https://bugs.webkit.org/show_bug.cgi?id=161054
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
CanvasRenderingContext2D should not have a CanvasRenderingContext parent interface
as per:
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCanvasRenderingContext.h: Renamed from Source/WebCore/bindings/js/JSCanvasRenderingContextCustom.cpp.
(WebCore::toJS):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSCanvasRenderingContext2D::visitAdditionalChildren):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::getCSSCanvasContext):
(WebCore::JSDocument::createTouchList): Deleted.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- dom/Document.idl:
- html/canvas/CanvasRenderingContext.idl: Removed.
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/WebGL2RenderingContext.idl:
- html/canvas/WebGLRenderingContext.idl:
- html/canvas/WebGLRenderingContextBase.idl:
- 4:18 PM Changeset in webkit [204744] by
-
- 4 edits2 adds in trunk/Source/bmalloc
bmalloc: speed up the lock slow path
https://bugs.webkit.org/show_bug.cgi?id=161058
Reviewed by Filip Pizlo.
It is generally accepted practice that a lock should yield instead of
spinning when a lock acquisition fails, to avoid wasting CPU and power.
There are two problems with this generally accepted practice:
(1) It's a fallacy that yielding is free. In reality, yielding itself
consumes CPU and power -- by performing a syscall, running the OS
scheduler, and possibly performing a context switch. (Instruments
traces of MallocBench show the cost of yielding.) Therefore, spinning a
little to avoid yielding can actually *save* CPU and power.
(2) std::this_thread_yield() on Darwin is way too aggressive: It not only
yields but also depresses your priority to absolute zero for 10ms. A
recent PLT trace showed a few spots where the main thread just gave up
on loading and rendering a page for 10ms so an unimportant background
task could run.
To correct these problems, this patch adds a little bit of spinning to
the bmalloc lock slow path.
Below are performance results on various CPUs.
Mac Pro (12 hyperthreaded cores = 24 threads):
Baseline Patch Δ
Execution Time:
message_one 173ms 173ms
message_many 953ms 927ms 1.03x faster
churn --parallel 60ms 41ms 1.46x faster
list_allocate --parallel 224ms 143ms 1.57x faster
tree_allocate --parallel 1,190ms 758ms 1.57x faster
tree_churn --parallel 1,517ms 906ms 1.67x faster
facebook --parallel 6,519ms 4,580ms 1.42x faster
reddit --parallel 5,097ms 3,411ms 1.49x faster
flickr --parallel 4,903ms 3,501ms 1.4x faster
theverge --parallel 6,641ms 4,505ms 1.47x faster
<geometric mean> 1,158ms 832ms 1.39x faster
<arithmetic mean> 2,728ms 1,895ms 1.44x faster
<harmonic mean> 332ms 240ms 1.38x faster
MacBook Air (2 hyperthreaded cores = 4 threads):
Baseline Patch Δ
Execution Time:
message_one 911ms 907ms 1.0x faster
message_many 515ms 513ms 1.0x faster
churn --parallel 132ms 134ms ! 1.02x slower
list_allocate --parallel 104ms 102ms 1.02x faster
tree_allocate --parallel 117ms 111ms 1.05x faster
tree_churn --parallel 154ms 151ms 1.02x faster
facebook --parallel 719ms 687ms 1.05x faster
reddit --parallel 382ms 341ms 1.12x faster
flickr --parallel 372ms 345ms 1.08x faster
theverge --parallel 489ms 444ms 1.1x faster
<geometric mean> 299ms 287ms 1.04x faster
<arithmetic mean> 390ms 374ms 1.04x faster
<harmonic mean> 227ms 220ms 1.03x faster
iPad (2 cores = 2 threads):
[ Doesn't run Ruby, so no pretty subtest output. ]
Baseline Patch Δ
Execution Time: 174.14ms 171.5ms 1.02x faster
- bmalloc.xcodeproj/project.pbxproj:
- bmalloc/ScopeExit.h: Added. A barebones very wimpy version of
WTF::ScopeExit.
(bmalloc::ScopeExit::ScopeExit):
(bmalloc::ScopeExit::~ScopeExit):
(bmalloc::makeScopeExit):
- bmalloc/StaticMutex.cpp:
(bmalloc::StaticMutex::lockSlowCase): Spin before yielding -- that's the
speedup. Don't spin if another CPU is already spinning. In theory, more
than one spinner accomplishes nothing, and I found that there's a cutoff
around 8 or 16 spinners that becomes performance negative on Mac Pro.
(Note: Another way to accomplish a similar result, if you don't want to
use a bit of state in the lock, is to spin for a random duration between
0 and aLot. I tested a version of WTF::WeakRandom with unsynchronized
static state and it worked great. But I ultimately opted for the explicit
bit because I thought it was clearer.)
- bmalloc/StaticMutex.h:
(bmalloc::StaticMutex::init): Initialize our new bit.
- bmalloc/ThreadSwitch.h: Added.
(bmalloc::threadSwitch): Don't call yield() on Darwin because it's too
aggressive. swtch() does what we want: Go run something else, without
any other side-effects.
- 3:44 PM Changeset in webkit [204743] by
-
- 19 edits1 delete in trunk/Source/WebKit2
Remove Arguments.h
https://bugs.webkit.org/show_bug.cgi?id=161060
Reviewed by Tim Horton.
- Platform/IPC/Arguments.h: Removed.
(IPC::Arguments::Arguments): Deleted.
(IPC::Arguments::encode): Deleted.
(IPC::Arguments::decode): Deleted.
- Platform/IPC/Connection.h:
- Platform/IPC/HandleMessage.h:
- Shared/AssistedNodeInformation.cpp:
- Shared/Cocoa/DataDetectionResult.mm:
- Shared/EditorState.cpp:
- Shared/WebContextMenuItemData.cpp:
- Shared/WebMouseEvent.cpp:
- Shared/WebPlatformTouchPoint.cpp:
- Shared/WebPopupItem.cpp:
- Shared/WebTouchEvent.cpp:
- Shared/WebWheelEvent.cpp:
- Shared/ios/InteractionInformationAtPosition.mm:
- Shared/ios/WebPlatformTouchPointIOS.cpp:
- Shared/ios/WebTouchEventIOS.cpp:
- Shared/mac/WebGestureEvent.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 3:10 PM Changeset in webkit [204742] by
-
- 4 edits in trunk/Source/WebKit2
Move tuple coding to ArgumentCoders.h
https://bugs.webkit.org/show_bug.cgi?id=161059
Reviewed by Tim Horton.
- Platform/IPC/ArgumentCoders.h:
(IPC::TupleCoder::encode):
(IPC::TupleCoder::decode):
- Platform/IPC/Arguments.h:
(IPC::TupleCoder::encode): Deleted.
(IPC::TupleCoder::decode): Deleted.
- Scripts/webkit/messages.py:
(forward_declarations_and_headers):
- 2:59 PM Changeset in webkit [204741] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 2:38 PM Changeset in webkit [204740] by
-
- 4 edits in trunk/Source
Actually enable the WASM build.
https://bugs.webkit.org/show_bug.cgi?id=160933
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Fix bug where we assumed that every frame would have a CodeBlock.
- inspector/ScriptCallStackFactory.cpp:
(Inspector::CreateScriptCallStackFunctor::operator()):
Source/WTF:
- wtf/FeatureDefines.h:
- 2:31 PM Changeset in webkit [204739] by
-
- 3 edits in trunk/Source/WebKit2
Simplify the generated message structs
https://bugs.webkit.org/show_bug.cgi?id=161057
Reviewed by Geoffrey Garen.
Use a class template to transform the Reply and Argument tuple types for encoding/decoding
instead of generating them for each message.
- Platform/IPC/HandleMessage.h:
(IPC::handleMessage):
(IPC::handleMessageDelayed):
- Scripts/webkit/messages.py:
(reply_type):
(message_to_struct_declaration):
(decode_type): Deleted.
- 2:21 PM Changeset in webkit [204738] by
-
- 2 edits in trunk/LayoutTests
Skip the test in http/tests/navigation/ping-attribute in iOS WebKit 2
Touch events are not supported in WebKit for iOS Simulator built with the public iOS SDK.
The tests simulate mouse events when run in DumpRenderTree. And simulating mouse events
is supported in WebKit for iOS Simulator built with the public iOS SDK.
- platform/ios-simulator-wk2/TestExpectations:
- 2:11 PM Changeset in webkit [204737] by
-
- 7 edits3 deletes in trunk/Source/WebKit2
Remove MessageRecorder
https://bugs.webkit.org/show_bug.cgi?id=161022
Reviewed by Tim Horton.
- Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<uuid_t>::encode): Deleted.
(IPC::ArgumentCoder<uuid_t>::decode): Deleted.
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::dispatchSyncMessage): Deleted.
(IPC::Connection::dispatchMessage): Deleted.
- Platform/IPC/Connection.h:
- Platform/IPC/Encoder.cpp:
(IPC::Encoder::encodeHeader): Deleted.
- Platform/IPC/MessageRecorder.cpp: Removed.
(IPC::MessageRecorder::isEnabled): Deleted.
(IPC::MessageRecorder::recordOutgoingMessage): Deleted.
(IPC::MessageRecorder::recordIncomingMessage): Deleted.
(IPC::MessageRecorder::MessageProcessingToken::MessageProcessingToken): Deleted.
(IPC::MessageRecorder::MessageProcessingToken::~MessageProcessingToken): Deleted.
- Platform/IPC/MessageRecorder.h: Removed.
(IPC::MessageRecorder::MessageRecorder): Deleted.
- Platform/IPC/MessageRecorderProbes.d: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 1:28 PM Changeset in webkit [204736] by
-
- 11 edits2 adds in trunk
Make NetworkLoadTiming use double for higher precision in Resource Timing
https://bugs.webkit.org/show_bug.cgi?id=161051
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-22
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/misc/resource-timing-resolution.html
- page/Performance.h:
- page/Performance.cpp:
(WebCore::Performance::now):
(WebCore::Performance::reduceTimeResolution):
Add new function to reduce time resolution.
- page/PerformanceResourceTiming.cpp:
(WebCore::monotonicTimeToDocumentMilliseconds):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):
Only use the reduced timing resolution for full timestamps and deltas.
(WebCore::PerformanceResourceTiming::connectStart): Use doubles.
- page/PerformanceResourceTiming.h: Use doubles.
- page/PerformanceTiming.cpp: Use doubles.
(WebCore::toIntegerMilliseconds): Use doubles.
(WebCore::PerformanceTiming::connectStart): Use doubles.
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToFetchStart): Use doubles.
- page/PerformanceTiming.h: Use doubles.
- platform/network/NetworkLoadTiming.h: Use doubles.
- platform/network/curl/ResourceHandleManager.cpp: Use doubles.
(WebCore::milisecondsSinceRequest): Use doubles.
(WebCore::calculateWebTimingInformations): Use doubles.
- platform/network/soup/ResourceHandleSoup.cpp: Use doubles.
(WebCore::milisecondsSinceRequest): Use doubles.
(WebCore::networkEventCallback): Use doubles.
LayoutTests:
Test that resources timing information are close deltas to a multiple of expected resolution.
- http/tests/misc/resource-timing-resolution-expected.txt: Added.
- http/tests/misc/resource-timing-resolution.html: Added.
- 1:13 PM Changeset in webkit [204735] by
-
- 6 edits in trunk/Source
Fix Mac CMake build after r204717.
- PlatformMac.cmake:
- 1:11 PM Changeset in webkit [204734] by
-
- 4 edits2 adds in trunk
[css-grid] Stretch alignment doesn't work for orthogonal flows
https://bugs.webkit.org/show_bug.cgi?id=160076
Reviewed by Darin Adler.
Source/WebCore:
After implementing orthogonal flow support for track sizing and basic
alignment logic, we can now implement stretching logic in orthogonal
scenarios, which was not allowed so far.
Thanks to the recent changes which made the grid layout code more
independent to the grid container's and its children's flow, the
implementation of the stretching logic can be done in a clearer way.
This patch implements the missing logic and performs some refactoring
so it became flow direction independent.
Test: fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
LayoutTests:
Additional layout tests to verify the stretching logic works as
expected in orthogonal flow scenarios.
- fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows-expected.txt: Added.
- fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html: Added.
- 12:48 PM Changeset in webkit [204733] by
-
- 2 edits in trunk/Source/WebCore
Invalid resource load statistics iterator when redirecting
https://bugs.webkit.org/show_bug.cgi?id=161021
<rdar://problem/27856875>
Reviewed by Dean Jackson.
If a load is the result of a redirect, an additional entry is added to the HashSet
containing the visited domains. This invalidates any existing iterators, so we
need to get a new iterator for further updates.
No change in functionality.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logSubresourceLoading):
- 12:45 PM Changeset in webkit [204732] by
-
- 22 edits6 adds6 deletes in trunk
Rename CustomElementsRegistry to CustomElementRegistry
https://bugs.webkit.org/show_bug.cgi?id=161028
Reviewed by Darin Adler.
Source/JavaScriptCore:
Added customElements and CustomElementRegistry to the common identifiers list as they're used on JSDOMWindow
to hide window.customElements and CustomElementRegistry interface behind a runtime flag.
- runtime/CommonIdentifiers.h:
Source/WebCore:
Renamed CustomElementsRegistry to CustomElementRegistry per https://github.com/w3c/webcomponents/issues/548.
Also hide window.customElements and CustomElementRegistry interface behind a runtime enabled.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomElementRegistryCustom.cpp: Renamed from JSCustomElementsRegistryCustom.cpp.
(WebCore::getCustomElementCallback):
(WebCore::JSCustomElementRegistry::define):
- bindings/js/JSHTMLElementCustom.cpp:
(WebCore::constructJSHTMLElement):
- dom/CustomElementReactionQueue.cpp:
(WebCore::findInterfaceForCustomElement):
- dom/CustomElementRegistry.cpp: Renamed from CustomElementsRegistry.cpp.
(WebCore::CustomElementRegistry::create):
(WebCore::CustomElementRegistry::CustomElementRegistry):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::addElementDefinition):
(WebCore::CustomElementRegistry::addUpgradeCandidate):
(WebCore::CustomElementRegistry::findInterface):
(WebCore::CustomElementRegistry::containsConstructor):
- dom/CustomElementRegistry.h: Renamed from CustomElementsRegistry.h.
- dom/CustomElementRegistry.idl: Renamed from CustomElementsRegistry.idl.
- dom/Document.cpp:
(WebCore::createUpgradeCandidateElement):
(WebCore::createHTMLElementWithNameValidation):
(WebCore::createFallbackHTMLElement):
- dom/Element.cpp:
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::ensureCustomElementRegistry):
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
Updated the tests and expected results after the rename.
- fast/custom-elements/CustomElementRegistry-expected.txt: Renamed from LayoutTests/fast/custom-elements/CustomElementsRegistry-expected.txt.
- fast/custom-elements/CustomElementRegistry.html: Renamed from LayoutTests/fast/custom-elements/CustomElementsRegistry.html.
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 12:12 PM Changeset in webkit [204731] by
-
- 2 edits in trunk/LayoutTests
Attempt to fix the iOS 9 Simulator test bots after <https://trac.webkit.org/changeset/204720>
(https://bugs.webkit.org/show_bug.cgi?id=156857)
Fix JavaScript TypeErrors, "undefined is not an object". Both uiController.singleTapAtPoint() and
testRunner.runUIScript() expect to be passed a callback function.
Additionally, explicitly check that window.testRunner is non-null before checking whether
testRunner.runUIScript is non-null to avoid a JavaScript TypeError in desktop Safari.
- http/tests/navigation/ping-attribute/resources/utilities.js:
(clickElement):
- 12:03 PM Changeset in webkit [204730] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=161049
Reviewed by Michael Saboff.
- runtime/VM.h:
- Deleted unused friend class ClearExceptionScope.
- 12:00 PM Changeset in webkit [204729] by
-
- 6 edits2 adds in trunk
Add support for GlobalEventHandlers.oncuechange attribute
https://bugs.webkit.org/show_bug.cgi?id=161046
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add support for GlobalEventHandlers.oncuechange attribute:
Test: fast/media/window-oncuechange.html
- dom/GlobalEventHandlers.idl:
LayoutTests:
Add layout test coverage.
- fast/media/window-oncuechange-expected.txt: Added.
- fast/media/window-oncuechange.html: Added.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 11:02 AM Changeset in webkit [204728] by
-
- 14 edits2 adds in trunk
<select> menu on iPad causes shifting of hit-testing areas
https://bugs.webkit.org/show_bug.cgi?id=150079
Reviewed by Tim Horton.
Source/WebKit2:
-isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
so when it changes we have to update visible rects. We were doing this on focus, but failing
to do it on blur.
Added the ability to test by:
- Making it possible to initiate an animated scroll in the UI process
- Adding callbacks for starting and ending interaction with a form control. Sadly
the "ending interaction" for <select> popovers on iPad isn't late enough, since we
have no way currently to know when the dimming view behind the popover animates out,
so for now the test keeps trying to tap a button.
Test: fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _zoomToPoint:atScale:animated:]):
(-[WKWebView _scrollToRect:origin:minimumScrollDistance:]):
(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _zoomToFocusRect:selectionRect:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):
(-[WKWebView didStartFormControlInteraction]):
(-[WKWebView didEndFormControlInteraction]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInset:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setIsEditable:]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
(-[WKContentView _stopAssistingNode]):
Tools:
-isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
so when it changes we have to update visible rects. We were doing this on focus, but failing
to do it on blur.
Added the ability to test by:
- Making it possible to initiate an animated scroll in the UI process
- Adding callbacks for starting and ending interaction with a form control. Sadly
the "ending interaction" for <select> popovers on iPad isn't late enough, since we
have no way currently to know when the dimming view behind the popover animates out,
so for now the test keeps trying to tap a button.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptContext.h:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setDidStartFormControlInteractionCallback):
(WTR::UIScriptController::didStartFormControlInteractionCallback):
(WTR::UIScriptController::setDidEndFormControlInteractionCallback):
(WTR::UIScriptController::didEndFormControlInteractionCallback):
(WTR::UIScriptController::scrollToOffset):
(WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
(WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView didStartFormControlInteraction]):
(-[TestRunnerWKWebView didEndFormControlInteraction]):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::contentOffsetBoundedInValidRange):
(WTR::UIScriptController::scrollToOffset):
(WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
(WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
LayoutTests:
This test:
- Scrolls in the ui process, so that position:fixed kicks in
- Taps on a <select>, which disabled position:fixed behavior
- Chooses a <select> option, dismissing the <select>, which restores position:fixed behavior
- Tries to tap a button inside position:fixed.
- fast/forms/ios/ipad/unfocus-inside-fixed-hittest-expected.txt: Added.
- fast/forms/ios/ipad/unfocus-inside-fixed-hittest.html: Added.
- 10:26 AM Changeset in webkit [204727] by
-
- 5 edits1 delete in trunk/Tools
[EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
https://bugs.webkit.org/show_bug.cgi?id=160927
Reviewed by Daniel Bates.
- Scripts/process-linux-coredump: Removed.
- Scripts/webkitpy/port/efl.py:
(EflPort._get_crash_log):
- Scripts/webkitpy/port/gtk.py:
(GtkPort._get_crash_log):
- Scripts/webkitpy/port/linux_get_crash_log.py:
(GDBCrashLogGenerator.init):
(GDBCrashLogGenerator.generate_crash_log):
- Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
(GDBCrashLogGeneratorTest.test_generate_crash_log):
- 10:23 AM Changeset in webkit [204726] by
-
- 2 edits in trunk/Source/WebCore
Fix bindings tests after r204717.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
There was an extra space.
- 10:20 AM Changeset in webkit [204725] by
-
- 4 edits in trunk/Source
Mostly fix Mac CMake build after r204717.
- PlatformMac.cmake:
- 10:19 AM Changeset in webkit [204724] by
-
- 4 edits2 adds in trunk
Can't style descendants in shadow tree using the :host pseudo class
https://bugs.webkit.org/show_bug.cgi?id=160754
Reviewed by Darin Adler.
Source/WebCore:
"The :host pseudo-class, when evaluated in the context of a shadow tree, matches the shadow tree’s shadow host."
Currently :host() works for styling the host element itself (:host(.foo) { ... }). It should also be usable
for styling elements in the shadow tree:
:host(.foo) div { ... }
Test: fast/shadow-dom/css-scoping-host-descendant.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchHostPseudoClass):
(WebCore::localContextForParent):
Move to shadow host if we are matching :host and are at the root of the shadow tree.
Set didMoveToShadowHost bit in the context.
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
Call the existing matchHostPseudoClass to do :host matching if didMoveToShadowHost bit has been set.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
Disallow :host in the compiler (cases where it would match didn't reach the compiler before).
LayoutTests:
- fast/shadow-dom/css-scoping-host-descendant-expected.html: Added.
- fast/shadow-dom/css-scoping-host-descendant.html: Added.
- 9:40 AM Changeset in webkit [204723] by
-
- 3 edits in trunk/Tools
check-webkit-style does not work with Lambda functions in C++
https://bugs.webkit.org/show_bug.cgi?id=160910
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-22
Reviewed by Darin Adler.
This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
- Scripts/webkitpy/style/checkers/cpp.py:
(regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
(check_for_non_standard_constructs): Added lambda function check.
(check_spacing_for_function_call): Added lambda function check.
(check_braces): Added lambda function check.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
- 9:28 AM WebKitGTK/2.12.x edited by
- Propose r204250 (diff)
- 9:19 AM Changeset in webkit [204722] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r202177 - Potential null dereferencing on a detached positioned renderer.
https://bugs.webkit.org/show_bug.cgi?id=158879
Reviewed by Simon Fraser.
This patch fixes the case when the while loop to search for the absolute positioned ancestor
returns null (it happens when positioned renderer has been detached from the render tree).
Speculative fix.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
- rendering/RenderBlock.h:
- 9:18 AM Changeset in webkit [204721] by
-
- 3 edits in trunk/Source/WebCore
Use memoize pattern for the menclose notation attribute
https://bugs.webkit.org/show_bug.cgi?id=160461
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-22
Reviewed by Darin Adler.
Currently, MathMLMencloseElement::parseAttribute parse the "notation" attribute each time it
is changed. We change this to use the memoize pattern as done for other MathML attributes:
We store m_notationFlags in an Optional<uint16_t> where Optnull means that the
attribute is dirty and must be parsed again.
No new tests, already covered by existing tests.
- mathml/MathMLMencloseElement.cpp:
(WebCore::MathMLMencloseElement::parseNotationAttribute): Move parsing of the "notation"
attribute from parseAttribute into this separate helper function.
(WebCore::MathMLMencloseElement::hasNotation): This now check whether the attribute and
dirty and parse it if necessary.
(WebCore::MathMLMencloseElement::parseAttribute): Just make the attribute dirty rather than
parsing it immediately.
- mathml/MathMLMencloseElement.h: hasNotation is no longer const as it may update the
m_notationsFlags. We declare parseNotationAttribute(). Finally, we wrap m_notationFlags
in an Optional<uint16_t> and make addNotation extract the value.
- 9:13 AM Changeset in webkit [204720] by
-
- 11 edits4 deletes in trunk
[iOS] <a ping> and <area ping> tests time out
https://bugs.webkit.org/show_bug.cgi?id=156857
Reviewed by Simon Fraser.
Source/WebCore:
Export HTMLAreaElement::imageElement() so that we can make use of it in WebKit2.
- html/HTMLAreaElement.h:
Source/WebKit2:
Support single tapping on an HTML area element in WebKit2 just as we do in Legacy WebKit.
WebKit2 commits to clicking a "clickable" DOM node on a single tap only if it has a
renderer. An HTML area element represents a hyperlink in an image map and does not have
a renderer.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary): Compute the tap highlight with respect
to the renderer for the image map associated with the tapped HTML area element (if it has one).
(WebKit::WebPage::commitPotentialTap): Allow committing a potential tap on an HTML area element.
LayoutTests:
Update test to use work in WebKitTestRunner and unskip the tests.
Also remove some unused files.
- http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html: Include external JavaScript
script resources/utilities.js and write code in terms of clickElement(). Additionally, add HTML5 doctype
tag and put <head> on its own line so as to be consistent with the placement of </head> on its own line.
- http/tests/navigation/ping-attribute/anchor-cross-origin.html: Ditto.
- http/tests/navigation/ping-attribute/anchor-same-origin.html: Ditto.
- http/tests/navigation/ping-attribute/resources/check-ping.php: Removed.
- http/tests/navigation/ping-attribute/resources/delete-ping.php: Removed.
- http/tests/navigation/ping-attribute/resources/ping-file-path.php: Removed.
- http/tests/navigation/ping-attribute/resources/save-Ping.php: Removed.
- http/tests/navigation/ping-attribute/resources/utilities.js:
(clearLastPingResultAndRunTest):
(clickElement): Make use of UIScriptController to click the element via a tap on platforms that
support touch events and implement UIScriptController (window.uiController).
- platform/ios-simulator-wk2/TestExpectations: Unskip ping-attribute tests.
- platform/ios-simulator/TestExpectations: Ditto.
- 9:05 AM Changeset in webkit [204719] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r202482 - [GStreamer] top/bottom black bars added needlessly in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158980
Patch by Philippe Normand <philn@igalia.com> on 2016-06-27
Reviewed by Carlos Garcia Campos.
The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.
Fixes an issue where black borders were added on top and bottom of
fullscreen video.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
- 9:01 AM Changeset in webkit [204718] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore
Merge r202615 - [GStreamer] Adaptive streaming issues
https://bugs.webkit.org/show_bug.cgi?id=144040
Reviewed by Philippe Normand.
There are multiple deadlocks in the web process when HLS content is loaded by GStreamer. It happens because gst
is using several threads to download manifest, fragments, monitor the downloads, etc. To download the fragments
and manifest it always creates the source element in a separate thread, something that is not actually expected
to happen in WebKit source element. Our source element is always scheduling tasks (start, stop, need-data,
enough-data and seek) to the main thread, and those downloads that use the ResourceHandleStreamingClient
(there's no player associated) also happen in the main thread, because libsoup calls all its async callbacks in
the main thread. So, the result is that it can happen that we end up blocking the main thread in a lock until
the download finishes, but the download never finishes because tasks are scheduled in the main thread that is
blocked in a lock. This can be prevented by always using a secondary thread for downloads made by
ResourceHandleStreamingClient, using its own run loop with a different GMainContext so that libsoup sends
callbacks to the right thread. We also had to refactor the tasks a bit, leaving the thread safe parts to be run
in the calling thread always, and only scheduling to the main thread in case of not using
ResourceHandleStreamingClient and only for the non thread safe parts.
This patch also includes r200455 that was rolled out, but it was a perfectly valid workaround for GST bug.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::ensureGRef): Consume the floating ref if needed.
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init): Check if object is being created in the main thread.
(webKitWebSrcStop): Stop the media resource loader in the main thread and the resource handle streaming in the
current thread.
(webKitWebSrcStart): Start the media resource loader in the main thread and the resource handle streaming in
the current thread.
(webKitWebSrcChangeState): Call webKitWebSrcStart and webKitWebSrcStop in the current thread.
(webKitWebSrcNeedData): Update status in the current thread and notify the media resource loader in the main thread.
(webKitWebSrcEnoughData): Ditto.
(webKitWebSrcSeek): Ditto.
(webKitWebSrcSetMediaPlayer): Add an assert to ensure that source elements used by WebKit are always created in
the main thread.
(ResourceHandleStreamingClient::ResourceHandleStreamingClient): Use a secondary thread to do the download.
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Stop the secondary thread.
(ResourceHandleStreamingClient::setDefersLoading): Notify the secondary thread.
- 8:51 AM Changeset in webkit [204717] by
-
- 158 edits342 adds1 delete in trunk/Source
Source/WebCore:
[Cocoa] Move Objective-C DOM bindings from WebCore to legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=160654
Patch by Darin Adler <Darin Adler> on 2016-08-22
Reviewed by Alex Christensen.
- DerivedSources.cpp: Removed ExceptionCodeDescription.h from the list here.
It will be included by the .cpp files as appropriate and should not be included
without including config.h first.
- WebCore.xcodeproj/project.pbxproj: Removed the Objective-C DOM source files.
Added private exports of various headers that are now used directly or indirectly
by legacy WebKit to implement the bindings. Moved WebScriptObject.* files from
bindings/objc to bridge/objc. Moved WebKitAvailability.h into platform/cocoa; it
can be moved to WebKit of we move the Objective-C bridge there too. Also ran
sort-Xcode-project-file.
- bindings/js/JSDOMBinding.cpp:
(WebCore::valueToUSVString): Fixed a comment typo.
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::toWrapped): Added.
- bindings/js/JSDOMWindowShell.h: Added a toWrapped function for use by the
Objective-C bindings.
- bindings/js/JSMainThreadExecState.h: Exported symbols needed by the Objective-C bindings.
- bindings/js/JSNamedNodeMapCustom.cpp: Updated includes since NamedNodeMap.h no longer
includes Attr.h.
- bindings/js/ScriptController.h: Exported symbols needed by the Objective-C bindings.
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject): Removed code that asserted the type of the
object; this assertion can't be done in WebCore any more and is not critical to keep.
(WebCore::ScriptController::disconnectPlatformScriptObjects): Use the new
disconnectWindowWrapper function to call up to the Objective-C bindings code in WebKit.
- bindings/objc/*: Moved all these files to WebKit/mac/DOM, except for a few that were moved
to bridge/objc.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Added support for the new ExportToWrappedFunction attribute so
classes that need to can export what is needed by WebKit.
- bindings/scripts/IDLAttributes.txt: Added ExportToWrappedFunction.
- bridge/objc/WebScriptObject.h: Moved from bindings/objc.
- bridge/objc/WebScriptObject.mm: Moved from bindings/objc.
(WebCore::initializeDOMWrapperHooks): Added. Used by WebKit to add the hooks needed so that
WebScriptObject can integrate with the DOM bindings.
(WebCore::disconnectWindowWrapper): Added.
(+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]): Added code that
uses createDOMWrapperFunction to set up wrappers that are found or created by WebKit.
- bridge/objc/WebScriptObjectPrivate.h: Moved from bindings/objc.
- css/CSSFontFaceRule.h: Exported symbols needed by the Objective-C bindings.
- css/CSSGroupingRule.h: Ditto.
- css/CSSImportRule.h: Ditto.
- css/CSSMediaRule.h: Ditto.
- css/CSSPageRule.h: Ditto.
- css/CSSPrimitiveValue.h: Ditto.
- css/CSSRule.h: Ditto.
- css/CSSRule.idl: Ditto.
- css/CSSRuleList.idl: Ditto.
- css/CSSStyleRule.h: Ditto.
- css/CSSStyleSheet.h: Ditto.
- css/CSSValue.h: Ditto.
- css/CSSValue.idl: Ditto.
- css/Counter.idl: Ditto.
- css/MediaList.h: Ditto.
- css/MediaList.idl: Ditto.
- css/MediaQueryEvaluator.h: Ditto.
- css/RGBColor.h: Ditto.
- css/RGBColor.idl: Ditto.
- css/Rect.idl: Ditto.
- css/StyleSheet.idl: Ditto.
- css/StyleSheetList.h: Ditto.
- css/StyleSheetList.idl: Ditto.
- dom/Attr.h: Ditto.
- dom/CharacterData.h: Ditto.
- dom/CollectionIndexCache.h: Ditto.
- dom/ContainerNode.h: Ditto.
- dom/DOMImplementation.cpp: Ditto.
- dom/DOMImplementation.h: Ditto.
- dom/DOMImplementation.idl: Ditto.
- dom/Document.h: Ditto.
- dom/DocumentFragment.h: Ditto.
- dom/Element.h: Ditto.
- dom/Event.h: Ditto.
- dom/Event.idl: Ditto.
- dom/EventTarget.h: Ditto.
- dom/KeyboardEvent.h: Ditto.
- dom/LifecycleCallbackQueue.h: Ditto.
- dom/MouseEvent.h: Ditto.
- dom/MouseRelatedEvent.h: Ditto.
- dom/MutationEvent.h: Ditto.
- dom/NamedNodeMap.h: Ditto.
- dom/NamedNodeMap.idl: Ditto.
- dom/NativeNodeFilter.h: Ditto.
- dom/Node.h: Ditto.
- dom/NodeIterator.h: Ditto.
- dom/NodeIterator.idl: Ditto.
- dom/NodeList.idl: Ditto.
- dom/NodeTraversal.h: Ditto.
- dom/OverflowEvent.h: Ditto.
- dom/QualifiedName.h: Ditto.
- dom/Range.h: Ditto.
- dom/ScriptElement.h: Ditto.
- dom/Text.h: Ditto.
- dom/TextEvent.h: Ditto.
- dom/TreeScope.h: Ditto.
- dom/TreeWalker.h: Ditto.
- dom/TreeWalker.idl: Ditto.
- dom/UIEvent.h: Ditto.
- dom/WheelEvent.h: Ditto.
- dom/make_dom_exceptions.pl: Ditto.
- editing/EditingStyle.h: Ditto.
- editing/FrameSelection.h: Ditto.
- editing/ios/EditorIOS.mm: Removed unneeded include of Objective-C DOM header.
- editing/mac/EditorMac.mm: Ditto.
- fileapi/Blob.h: Exported symbols needed by the Objective-C bindings.
- fileapi/File.h: Ditto.
- fileapi/FileList.h: Ditto.
- html/DOMTokenList.h: Ditto.
- html/HTMLAnchorElement.h: Ditto.
- html/HTMLAreaElement.h: Ditto.
- html/HTMLBaseElement.h: Ditto.
- html/HTMLButtonElement.h: Ditto.
- html/HTMLCanvasElement.h: Ditto.
- html/HTMLCollection.h: Ditto.
- html/HTMLCollection.idl: Ditto.
- html/HTMLDocument.h: Ditto.
- html/HTMLElement.h: Ditto.
- html/HTMLFormControlElement.h: Ditto.
- html/HTMLFormElement.h: Ditto.
- html/HTMLFrameElementBase.h: Ditto.
- html/HTMLFrameOwnerElement.h: Ditto.
- html/HTMLImageElement.h: Ditto.
- html/HTMLInputElement.h: Ditto.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::setActive): Tweaked types a bit.
(WebCore::HTMLLabelElement::setHovered): Ditto.
(WebCore::HTMLLabelElement::defaultEventHandler): Ditto.
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents): Ditto.
(WebCore::HTMLLabelElement::focus): Ditto.
(WebCore::HTMLLabelElement::accessKeyAction): Ditto.
- html/HTMLLabelElement.h: Exported symbols needed by the Objective-C bindings.
- html/HTMLLinkElement.h: Ditto.
- html/HTMLMapElement.h: Ditto.
- html/HTMLMarqueeElement.h: Ditto.
- html/HTMLMediaElement.h: Ditto.
- html/HTMLOListElement.h: Ditto.
- html/HTMLOptionElement.h: Ditto.
- html/HTMLOptionsCollection.h: Ditto.
- html/HTMLOptionsCollection.idl: Ditto.
- html/HTMLScriptElement.h: Ditto.
- html/HTMLSelectElement.h: Ditto.
- html/HTMLStyleElement.h: Ditto.
- html/HTMLTableCellElement.h: Ditto.
- html/HTMLTableColElement.h: Ditto.
- html/HTMLTableElement.h: Ditto.
- html/HTMLTableRowElement.h: Ditto.
- html/HTMLTableSectionElement.h: Ditto.
- html/HTMLTextAreaElement.h: Ditto.
- html/HTMLTextFormControlElement.h: Ditto.
- html/HTMLTitleElement.h: Ditto.
- html/HTMLVideoElement.h: Ditto.
- html/LabelableElement.h: Ditto.
- loader/EmptyClients.h: Updated documentFragmentFromDelegate, which was
returning a newly created document fragment with a raw pointer. This works
because the implementation internally uses Objective-C and autorelease, but
is too fragile to rely on for the future.
- page/DOMWindow.h: Exported symbols needed by the Objective-C bindings.
- page/EditorClient.h: Updated document fragment functions.
- page/Frame.h: Removed indexCountOfWordPrecedingSelection, already unused.
Removed innerLineHeight and styleAtSelectionStart, formerly used by legacy WebKit,
which used Objective-C DOM objects in their interfaces.
- page/ios/FrameIOS.mm:
(WebCore::Frame::indexCountOfWordPrecedingSelection): Deleted.
(WebCore::Frame::innerLineHeight): Deleted.
(WebCore::Frame::styleAtSelectionStart): Deleted.
- platform/DragImage.h: Exported symbols needed by the Objective-C bindings.
- platform/ScrollView.h: Ditto.
- platform/URL.h: Ditto.
- platform/cocoa/WebKitAvailability.h: Moved from bindings/objc.
- platform/cocoa/WebPlaybackSessionModelMediaElement.mm: Removed unneeded includes
of Objective-C DOM headers.
- platform/cocoa/WebVideoFullscreenModelVideoElement.mm: Ditto.
- platform/ios/PasteboardIOS.mm: Ditto.
- platform/ios/wak/WebCoreThread.mm:
(StartWebThread): Took out the call to WebCoreObjCDeallocOnWebThread for DOMObject.
This class is now defined in legacy WebKit, so we do the code there there along
with the other WebKit classes.
- platform/ios/wak/WebCoreThreadSafe.h: Removed the unwise additional definition of
WebScriptObject and DOMObject in this file. Really this entire file needs to go.
- platform/text/TextEncoding.h: Exported symbols needed by the Objective-C bindings.
- rendering/HitTestResult.h: Ditto.
- rendering/RenderLayer.h: Ditto.
- rendering/RenderObject.h: Ditto.
- rendering/RenderThemeGtk.cpp: Rewrote code that was unnecessarily using
NamedNodeMap and Attr nodes just to get the value of an attribute.
- rendering/style/RenderStyle.h: Exported symbols needed by the Objective-C bindings.
- xml/XMLHttpRequest.cpp: Added include needed now that XMLDocument.h is not
included by DOMImplementation.h.
- xml/XPathExpression.h: Exported symbols needed by the Objective-C bindings.
- xml/XPathExpression.idl: Ditto.
- xml/XPathNSResolver.h: Ditto.
- xml/XPathResult.cpp:
(WebCore::XPathResult::snapshotLength): Use unsigned instead of unsigned long.
(WebCore::XPathResult::snapshotItem): Ditto.
- xml/XPathResult.h: Exported symbols needed by the Objective-C bindings. Also
updated types as above.
- xml/XPathResult.idl: Ditto.
Source/WebKit:
Move Objective-C DOM bindings from WebCore to legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=160654
Patch by Darin Adler <Darin Adler> on 2016-08-22
Reviewed by Alex Christensen.
- WebKit.xcodeproj/project.pbxproj: Added the new source files to the project.
For now they all have project visibility, since MigrateHeaders.make takes care
of exporting them as public and private. Later, we can likely use the built-in
Xcode feature instead of that script. Also pass DOM as an acceptable prefix
when calling check-for-inappropriate-objc-class-names. Also sorted this file
with the sort-Xcode-project-file script.
Source/WebKit/mac:
Move Objective-C DOM bindings from WebCore to legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=160654
Patch by Darin Adler <Darin Adler> on 2016-08-22
Reviewed by Alex Christensen.
- DOM: Added lots of files to the directory.
The files are just as they were in bindings/objc except that the paths of includes
have been updated as needed, and the code no longer is defined inside the WebCore
namespace, requring changes to various functions and their call sites. Also removed
all the WEBCORE_EXPORT since we export differently here in legacy WebKit.
- DOM/DOMInternal.h: Moved. Replaced createDOMWrapper with initializeDOMWrapperHooks.
- DOM/DOMUtility.mm: Moved.
(createDOMWrapper): Simplified to use toWrapped and not do unneeded namespace tricks.
(disconnectWindowWrapper): Added.
(initializeDOMWrapperHooks): Added.
- MigrateHeaders.make: Removed all the internal headers since they are now just
normal project headers. Added the "DOM" directory to the VPATH. Some of the headers
from WebCore are still being migrated, so we can't remove WebCorePrivateHeaders yet.
- WebCoreSupport/WebEditorClient.h: Updated to return RefPtr<DocumentFragment>.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::documentFragmentFromDelegate): Use RefPtr.
- WebKit.exp: Added exports for all the classes that used to use WEBCORE_EXPORT to
be exported from WebCore.
- WebView/WebFrame.mm:
(-[WebFrame innerLineHeight:]): Moved code from WebCore::Frame::innerLineHeight here.
No longer depend on whether this node happens to be in this frame. Also removed
unneeded null check since a node's document can't be null.
- WebView/WebHTMLView.mm: Removed uneeded include of ExceptionHandlers.h, which
is now here in WebKitLegacy instead of WebCore. But no need to include it at all.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Call
initializeDOMWrapperHooks so WebScriptObject can create DOM binding wrappers when
making a script object for a DOM object, rather than just a generic script object.
(+[WebView enableWebThread]): Added a call to WebCoreObjCDeallocOnWebThread here for
DOMObject along with the other classes. This was done in WebCore before, but DOMObject is now
defined here in legacy WebKit.
(-[WebView styleAtSelectionStart]): Moved code from WebCore::Frame::styleAtSelectionStart here.
Replaced incorrect code that called "new PropertySetCSSStyleDeclaration" with a misleading comment
about reference counting; that code was leaking all the style declarations. Instead use
MutableStyleProperties::ensureCSSStyleDeclaration, which is designed for this purpose.
Source/WebKit2:
Move Objective-C DOM bindings from WebCore to legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=160654
Patch by Darin Adler <Darin Adler> on 2016-08-22
Reviewed by Alex Christensen.
- WebProcess/WebCoreSupport/WebEditorClient.h: Updated to use RefPtr.
- WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::documentFragmentFromDelegate): Ditto.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: Removed unneeded includes
of Objective-C DOM headers that are now part of legacy WebKit, not WebCore.
But this file doesn't need to depend on those headers at all.
- 8:39 AM Changeset in webkit [204716] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Wait a few seconds before release network activity assertion after a load
https://bugs.webkit.org/show_bug.cgi?id=160975
<rdar://problem/27910964>
Reviewed by Darin Adler.
Some apps do several loads one after the other in a non-visible view.
This causes us to release the background assertion every time a load
completes and then take one again less than a second after. Every
time we release the assertion, we send a PrepareToSuspend IPC to the
WebContent process, which does all the clean up to get ready to
suspend, only to get a CancelPrepareReadyToSuspend later on because
the next load has started. To work around this problem, we now wait
a few seconds before releasing the background activity after a load.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::releaseNetworkActivityToken):
(WebKit::NavigationState::didChangeIsLoading):
- 8:32 AM WebKitGTK/2.12.x edited by
- (diff)
- 8:18 AM Changeset in webkit [204715] by
-
- 9 edits2 moves in trunk/Source/WebCore
Rename MathMLTextElement to MathMLTokenElement
https://bugs.webkit.org/show_bug.cgi?id=160542
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-22
Reviewed by Darin Adler.
No new tests, behavior is unchanged.
- CMakeLists.txt: Rename MathMLTextElement to MathMLTokenElement.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAllInOne.cpp: Ditto.
- mathml/MathMLOperatorElement.cpp: Ditto.
- mathml/MathMLOperatorElement.h: Ditto.
- mathml/MathMLTokenElement.cpp: Ditto. Also remove dead code in childShouldCreateRenderer
to handle the case of mspace since that element uses its own class and forbids child creation
in RenderMathMLSpace::isChildAllowed.
- mathml/MathMLTokenElement.h: Rename MathMLTextElement to MathMLTokenElement.
- mathml/mathtags.in: Ditto.
- rendering/mathml/RenderMathMLToken.cpp: Move inclusion of MathMLTokenElement.h and
implementation of element() here.
- rendering/mathml/RenderMathMLToken.h: Do not implement element() in the header so that
we only need need to predeclare MathMLTokenElement instead of including its header.
- 7:12 AM Changeset in webkit [204714] by
-
- 24 edits1 add in trunk
[ES6] Module should not allow HTML comments
https://bugs.webkit.org/show_bug.cgi?id=161041
Reviewed by Saam Barati.
JSTests:
- modules/html-comments.js: Added.
(shouldThrow):
- test262.yaml:
Source/JavaScriptCore:
ES6 Modules intentionally disable HTML comments[1].
[1]: https://tc39.github.io/ecma262/#sec-html-like-comments
- API/JSScriptRef.cpp:
(parseScript):
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::CacheKey::CacheKey):
- bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::commentMode):
(JSC::ExecutableInfo::superBinding): Deleted.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::commentMode):
(JSC::UnlinkedCodeBlock::superBinding): Deleted.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::commentMode):
(JSC::BytecodeGenerator::makeFunction):
(JSC::BytecodeGenerator::superBinding): Deleted.
- parser/Lexer.cpp:
(JSC::Lexer<T>::Lexer):
(JSC::Lexer<T>::lex):
- parser/Lexer.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
- parser/Parser.h:
(JSC::parse):
- parser/ParserModes.h:
- parser/SourceCodeKey.h:
(JSC::SourceCodeFlags::SourceCodeFlags):
(JSC::SourceCodeKey::SourceCodeKey):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
- runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::checkModuleSyntax):
- runtime/Executable.cpp:
(JSC::ProgramExecutable::checkSyntax):
- runtime/Executable.h:
- runtime/ModuleLoaderPrototype.cpp:
(JSC::moduleLoaderPrototypeParseModule):
- 6:51 AM Changeset in webkit [204713] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/bmalloc
Merge r204091 - [bmalloc] Merging of XLargeRanges can leak the upper range
https://bugs.webkit.org/show_bug.cgi?id=160403
Reviewed by Michael Saboff.
- bmalloc/Heap.cpp:
(bmalloc::Heap::scavengeLargeObjects): Don't use removePhysical().
Recorded physical size is a performance optimization. It is not the
truth. So it might be zero even if a range contains physical pages.
Instead, iterate each range in the map unconditionally.
The map can shrink when we release the lock, so we must clamp our
iterator each time through the loop.
The map can grow when we release the lock, but we don't care because
growth restarts the scavenger from the beginning.
- bmalloc/XLargeMap.cpp:
(bmalloc::XLargeMap::removePhysical): Deleted. Not used anymore.
- bmalloc/XLargeMap.h:
(bmalloc::XLargeMap::ranges): Added direct access for the sake of
scavengeLargeObjects. (This violates our naming conventions -- I'll do
a rename in a follow-up patch.)
- 6:51 AM Changeset in webkit [204712] by
-
- 4 edits in releases/WebKitGTK/webkit-2.12/Source/bmalloc
Merge r203100 - Crash due to abort() calling libc++.1.dylib: std::1::thread::detach()
https://bugs.webkit.org/show_bug.cgi?id=159655
Reviewed by Sam Weinig.
It's not entirely clear what was happening in these crashes, but our
use of detach() was 100% forward-looking, so we can just remove it for
now.
This patch removes the ability for the scavenger owner to die before
the scavenger thread dies (which was unused) and also removes the
ability for the scavenger thread to exit (which was used, but we
messed up and did thread joining lazily, so we never got any benefit
from thread exit.)
We can add these features back when we need them, and make them work then.
- bmalloc/AsyncTask.h:
(bmalloc::Function>::AsyncTask): We start out in the running state now
because we know that starting our thread will run it.
(bmalloc::Function>::~AsyncTask): We don't support destruction anymore.
(bmalloc::Function>::runSlowCase): I removed the Exited state.
(bmalloc::Function>::threadRunLoop): I removed the Exited and
ExitRequested states.
- bmalloc/Heap.h:
- bmalloc/VMHeap.h:
- 6:51 AM Changeset in webkit [204711] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/bmalloc
Merge r201983 - Crash in com.apple.WebKit.WebContent at std::1::call_once_proxy<std::__1::tuple<CrashReporterSupportLibrary()::$_0&&> >
<https://webkit.org/b/158660>
<rdar://problem/25652686>
Reviewed by Darin Adler.
- bmalloc/Logging.cpp: Switch to use
BSOFT_LINK_PRIVATE_FRAMEWORK() to link
CrashReporterSupport.framework.
- bmalloc/darwin/BSoftLinking.h:
(BSOFT_LINK_PRIVATE_FRAMEWORK): Rename from BSOFT_LINK_FRAMEWORK.
Switch to use /System/Library/PrivateFrameworks/.
- 6:51 AM Changeset in webkit [204710] by
-
- 5 edits in releases/WebKitGTK/webkit-2.12/Source/bmalloc
Merge r201969 - Implement logging for RELEASE_BASSERT_WITH_MESSAGE() in BAssert.h
<http://webkit.org/b/155992>
Reviewed by Geoff Garen.
- bmalloc/BAssert.h:
(BLOG_ERROR): Add method to always log error messages.
(RELEASE_BASSERT_WITH_MESSAGE): Use BLOG_ERROR() to implement
logging in Debug builds.
- bmalloc/BPlatform.h:
(BPLATFORM_MAC): Add.
(BUSE): Add BUSE() macro.
(BATTRIBUTE_PRINTF): Add.
(BUSE_OS_LOG): Add.
- bmalloc/Logging.cpp:
(bmalloc::reportAssertionFailureWithMessage): Add. Logs to
stderr.
- bmalloc/Logging.h:
(bmalloc::reportAssertionFailureWithMessage): Add declaration.
- 6:51 AM Changeset in webkit [204709] by
-
- 2 edits in releases/WebKitGTK/webkit-2.12/Source/bmalloc
Merge r201772 - Prevents integer overflow in Vector.h
https://bugs.webkit.org/show_bug.cgi?id=158455
<rdar://problem/20235469>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-06-07
Reviewed by Mark Lam.
- bmalloc/Vector.h:
(bmalloc::Vector<T>::reallocateBuffer):
- 6:33 AM Changeset in webkit [204708] by
-
- 16 edits in releases/WebKitGTK/webkit-2.12
Merge r201087 - [GTK] accessibility/meter-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=115633
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2016-05-25
Source/WebCore:
The meter's value description should be exposed in the same fashion
as (we should have been exposing) aria-valuetext, namely through the
"valuetext" AtkObject attribute. This exposure is now in place. Also
implement AccessibilityProgressIndicator::valueDescription() so that
the ports do not have to special-case meter in the platform wrappers.
Map the meter element to the correct role (ATK_ROLE_LEVEL_BAR), and
ignore a previously-included accessible object resulting from the
use of the title attribute on a meter. Finally, do not expose the
meter's title as the accessible name because the HTML spec suggests
authors can supply the numeric unit as the value of title.
No new test file as the failure was identified by meter-element.html.
Seven new test cases were added for additional coverage. Also updated
the ATK expectations for spinbutton-value.html to reflect that we are now
exposing the value of aria-valuetext.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::helpText):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForChildren):
(WebCore::AccessibilityNodeObject::visibleText):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::valueDescription):
- accessibility/AccessibilityProgressIndicator.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
(atkRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Implement AccessibilityUIElement::valueDescription() and add mapping
from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::valueDescription):
LayoutTests:
Seven new test cases were added to meter-element.html for additional
coverage. Also updated the ATK expectations for spinbutton-value.html
to reflect that we are now exposing the value of aria-valuetext.
- accessibility/meter-element.html: New test cases added.
- platform/gtk/TestExpectations: Unskip the previously-failing test.
- platform/gtk/accessibility/meter-element-expected.txt: Updated.
- platform/gtk/accessibility/spinbutton-value-expected.txt: Updated.
- platform/mac/accessibility/meter-element-expected.txt: Updated.
- 6:04 AM Changeset in webkit [204707] by
-
- 82 edits3 copies2 moves7 adds2 deletes in releases/WebKitGTK/webkit-2.12
Merge r201072, r201216 - AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
https://bugs.webkit.org/show_bug.cgi?id=157822
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2016-05-25
Reviewed by Chris Fleizach.
Remove the old code which was overriding WebCore Accessibility and always use
AccessibilityText.
If the AccessibilityText's textSource is HelpText or SummaryText, it should be exposed
as the AtkObject description. If the textSource is TitleTagText and there is no other
text alternative, the value should also be exposed in this fashion. Note that AtkObject's
description property is equivalent to AXAPI's AXHelp property.
If the AccessibilityText's textSource is anything other than the above, the first
non-empty value should be exposed as the AtkObject name. Depending on the source of
the name content, AtkObject's name property can be the equivalent of AXAPI's AXTitle.
However, most of the time, AtkObject's name property is equivalent to AXAPI's
AXDescription property.
By making these changes, what WebKit exposes for ATK is now extremely similar to what
WebKit exposes on the Mac (modulo the property names) and also with what is defined in
the HTML Accessibility and Accessible Name and Description Computation API mappings specs.
Now that the exposure is correct, the Layout Tests needed to be adjusted accordingly because
asking for the "AXDescription" gives you the AXDescription on the Mac and the AtkObject
description in GNU/Linux. But as indicated above, what ATK calls a "description" is what
the Mac calls "help."
Ultimately our Layout Tests and/or our platform TestRunner API should be modified to deal
with these differences more gracefully. (Bug https://bugs.webkit.org/show_bug.cgi?id=157187
has been opened for that task.) In the meantime, the existing tests have been given platform
checks to ask for the right property on each platform. This was done in such a way as to not
require other (non-ATK) platforms change their current expectations files.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
Tools:
AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
https://bugs.webkit.org/show_bug.cgi?id=157822
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2016-05-25
Reviewed by Chris Fleizach.
Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
nullptr upon failure.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::helpText):
LayoutTests:
AX: Layout tests related to text alternative computation need to be done differently
https://bugs.webkit.org/show_bug.cgi?id=157187
Create several utility methods to facilitate retrieval of platform-independent
attribute values from platform-specific attributes:
- platformValueForW3CName() and platformValueForW3CDescription() to retrieve a specific piece of text alternative information, stripping off the platform attribute name by default. These methods should make it possible to share tests and expectations files because the text alternative calculation defined by the W3C accessibility specifications should be the same for all platforms. (The differences are the result of the unique platform mappings.)
- platformTextAlternatives() to dump out all the text alternative attributes and values, preserving the platform-specific attribute name. This, along with the use of the platformValue* methods with attribute name enabled, should make it possible to have shared tests with platform-specific expectations without the need to check the platform in the test itself.
- platformRoleForComboBox() and platformRoleForStaticText() to eliminate the need for platform-specific expectations files simply because such an element happens to be included in the test file and verifying that element's role is desired.
Begin using these methods in the tests related to text alternative computation
which had platform-specific checks and update the expectations files.
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2016-05-25
Reviewed by Chris Fleizach.
- accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Updated.
- accessibility/alt-tag-on-image-with-nonimage-role.html: Updated.
- accessibility/aria-help-expected.txt: Added.
- accessibility/aria-help.html: Updated.
- accessibility/aria-label-expected.txt: Updated.
- accessibility/aria-label.html: Updated.
- accessibility/aria-labeled-with-hidden-node-expected.txt: Updated.
- accessibility/aria-labeled-with-hidden-node.html: Updated.
- accessibility/aria-labelledby-on-input-expected.txt: Updated.
- accessibility/aria-labelledby-on-input.html: Updated.
- accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Updated.
- accessibility/aria-labelledby-overrides-aria-labeledby.html: Updated.
- accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
- accessibility/aria-labelledby-overrides-label.html: Updated.
- accessibility/aria-labelledby-stay-within-expected.txt: Updated.
- accessibility/aria-labelledby-stay-within.html: Updated.
- accessibility/aria-labelledby-with-descendants-expected.txt: Updated.
- accessibility/aria-labelledby-with-descendants.html: Updated.
- accessibility/aria-namefrom-author-expected.txt: Updated.
- accessibility/aria-namefrom-author.html: Updated.
- accessibility/aria-text-role-expected.txt: Updated.
- accessibility/aria-text-role.html: Updated.
- accessibility/canvas-description-and-role-expected.txt: Updated.
- accessibility/canvas-description-and-role.html: Updated.
- accessibility/canvas-fallback-content.html: Updated.
- accessibility/empty-image-with-title-expected.txt: Updated.
- accessibility/empty-image-with-title.html: Updated.
- accessibility/fieldset-element-expected.txt: Updated.
- accessibility/fieldset-element.html: Updated.
- accessibility/focusable-div-expected.txt: Updated.
- accessibility/focusable-div.html: Updated.
- accessibility/help-text.html: Updated.
- accessibility/img-alt-tag-only-whitespace-expected.txt: Updated.
- accessibility/img-alt-tag-only-whitespace.html: Updated.
- accessibility/img-aria-button-alt-tag-expected.txt: Updated.
- accessibility/img-aria-button-alt-tag.html: Updated.
- accessibility/img-fallsback-to-title.html: Updated.
- accessibility/input-image-alt-expected.txt: Updated.
- accessibility/input-image-alt.html: Updated.
- accessibility/loading-iframe-sends-notification.html: Updated.
- accessibility/self-referencing-aria-labelledby-expected.txt: Updated.
- accessibility/self-referencing-aria-labelledby.html: Updated.
- accessibility/svg-bounds.html: Updated.
- accessibility/svg-group-element-with-title-expected.txt: Updated.
- accessibility/svg-group-element-with-title.html: Updated.
- accessibility/svg-image-expected.txt: Updated.
- accessibility/svg-image.html: Updated.
- accessibility/svg-labelledby-expected.txt: Updated.
- accessibility/svg-labelledby.html: Updated.
- accessibility/svg-remote-element.html: Updated.
- accessibility/w3c-svg-description-calculation.html: Updated.
- accessibility/w3c-svg-name-calculation.html: Updated.
- platform/gtk/TestExpectations: Updated.
- platform/gtk/accessibility/aria-hidden-negates-no-visibility-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
- platform/gtk/accessibility/aria-labelledby-overrides-label-expected.txt: Added.
- platform/gtk/accessibility/aria-option-role-expected.txt: Added.
- platform/gtk/accessibility/aria-switch-text-expected.txt: Updated.
- platform/gtk/accessibility/aria-text-role-expected.txt: Added.
- platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
- platform/gtk/accessibility/empty-image-with-title-expected.txt: Added.
- platform/gtk/accessibility/help-text-expected.txt: Added.
- platform/gtk/accessibility/image-link-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/image-map1-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/image-map2-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Updated.
- platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Updated.
- platform/gtk/accessibility/math-multiscript-attributes-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/media-element-expected.txt: Updated.
- platform/gtk/accessibility/radio-button-title-label-expected.txt: Updated.
- platform/gtk/accessibility/svg-bounds-expected.txt: Added.
- platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
- platform/gtk/accessibility/table-attributes-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/table-cell-spans-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/table-cells-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/table-detection-expected.txt: Updated (Gardening).
- platform/gtk/accessibility/table-sections-expected.txt: Updated (Gardening).
- platform/mac/accessibility/aria-help-expected.txt: Removed.
- platform/mac/accessibility/canvas-description-and-role-expected.txt: Updated.
- platform/mac/accessibility/fieldset-element-expected.txt: Removed.
- platform/mac/accessibility/img-fallsback-to-title-expected.txt: Updated.
- platform/win/accessibility/canvas-description-and-role-expected.txt: Updated.
- resources/accessibility-helper.js:
(platformValueForW3CName): Added.
(platformValueForW3CDescription): Added.
(platformTextAlternatives): Added.
(platformRoleForComboBox): Added.
(platformRoleForStaticText): Added.
- 5:23 AM Changeset in webkit [204706] by
-
- 3 edits in releases/WebKitGTK/webkit-2.12/Source/JavaScriptCore
Merge r196886 - Remove arrowfunction test cases that rely on arguments variable in jsc
https://bugs.webkit.org/show_bug.cgi?id=154517
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-02-21
Reviewed by Yusuke Suzuki.
Allow to jsc has the same behavior in javascript as browser has
- tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js:
- tests/stress/arrowfunction-lexical-bind-arguments-strict.js:
- 2:53 AM Changeset in webkit [204705] by
-
- 4 edits in trunk/Source
[Fetch API] Activate fetch api runtime flag by default
https://bugs.webkit.org/show_bug.cgi?id=160452
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-22
Reviewed by Alex Christensen.
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- 12:09 AM Changeset in webkit [204704] by
-
- 2 edits in trunk/LayoutTests
LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=160510
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-22
Reviewed by Darin Adler.
- http/tests/fetch/fetch-in-worker.js:
(stream.new.ReadableStream): Enqueuing a Uint8Array not a string, so that the fetch promise is not rejected. This should take care of Fail flakiness.
Crash flakiness in Debug mode may still happen due to promise use in Worker.
- 12:02 AM Changeset in webkit [204703] by
-
- 4 edits in trunk/Source/WebKit2
[SOUP] Change MessageDecoder with Decoder
https://bugs.webkit.org/show_bug.cgi?id=161040
Patch by Gyuyoung Kim <gyuyoung.kim@navercorp.com> on 2016-08-22
Reviewed by Darin Adler.
Clean up MessageDecoder in files of Soup.
- Scripts/webkit/MessageReceiverSuperclass-expected.cpp:
(WebKit::WebPage::didReceiveMessage):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
- WebProcess/soup/WebSoupRequestManager.h:
Aug 21, 2016:
- 11:02 PM Changeset in webkit [204702] by
-
- 17 edits in trunk/Source
Use Document& instead of Document* when getting cookies
https://bugs.webkit.org/show_bug.cgi?id=161011
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-21
Reviewed by Darin Adler.
Source/WebCore:
No change in behavior.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processBuffer):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):
- dom/Document.cpp:
(WebCore::Document::cookie):
(WebCore::Document::setCookie):
(WebCore::Document::referrer):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::getResourceTree):
- loader/CookieJar.cpp:
(WebCore::networkingContext):
(WebCore::storageSession):
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::addCookie):
- loader/CookieJar.h:
- page/Navigator.cpp:
(WebCore::Navigator::cookieEnabled):
(WebCore::Navigator::javaEnabled):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getCookies):
(WebKit::NetscapePluginInstanceProxy::setCookies):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView setVariable:forURL:value:length:]):
Source/WebKit/win:
- Plugins/PluginView.cpp:
(WebCore::PluginView::getValueForURL):
Source/WebKit2:
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::getCookiesForFrame):
(WebKit::WebAutomationSessionProxy::deleteCookie):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
(WebKit::PluginView::getAuthenticationInfo):
- 10:42 PM Changeset in webkit [204701] by
-
- 4 edits in trunk
URLParser should parse IPv4 addresses
https://bugs.webkit.org/show_bug.cgi?id=161023
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-21
Reviewed by Darin Adler.
Source/WebCore:
Covered by new API tests because URLParser isn't used anywhere in WebCore yet.
- platform/URLParser.cpp:
(WebCore::URLParser::authorityEndReached):
(WebCore::serializeIPv4):
(WebCore::parseIPv4Number):
(WebCore::pow256):
(WebCore::parseIPv4Host):
(WebCore::parseIPv6Host):
(WebCore::URLParser::hostEndReached):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::checkURLDifferences):
We are already getting differences between the old URL::parse and the new URLParser.
(TestWebKitAPI::shouldFail):
- 9:04 PM Changeset in webkit [204700] by
-
- 6 edits in trunk/Source/WebCore
Remove a few custom bindings
https://bugs.webkit.org/show_bug.cgi?id=161039
Patch by Sam Weinig <sam@webkit.org> on 2016-08-21
Reviewed by Darin Adler.
Remove custom bindings for CanvasRenderingContext2D's webkitLineDash attribute and commit function.
- WebCore.xcodeproj/project.pbxproj:
Sort files.
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::commit): Deleted.
(WebCore::JSCanvasRenderingContext2D::webkitLineDash): Deleted.
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash): Deleted.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::webkitLineDashOffset): Deleted.
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset): Deleted.
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
- 8:47 PM Changeset in webkit [204699] by
-
- 3 edits1 add in trunk
[DFG] Should not fixup AnyIntUse in 32_64
https://bugs.webkit.org/show_bug.cgi?id=161029
Reviewed by Saam Barati.
JSTests:
- typeProfiler/int52-dfg.js: Added.
(test):
Source/JavaScriptCore:
DFG fixup phase uses AnyIntUse even in 32bit DFG. This patch removes this incorrect filtering.
If the 32bit DFG see the TypeAnyInt, it should fallback to the NumberUse case.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 1:36 PM Changeset in webkit [204698] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r204697
https://bugs.webkit.org/show_bug.cgi?id=161029
JSTests:
- typeProfiler/int52-dfg.js: Removed.
(test): Deleted.
- typeProfiler/number-filter-dfg.js: Removed.
(test): Deleted.
Source/JavaScriptCore:
32bit is OK. DFGSpeculativeJIT64.cpp shortcut also need some cares.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 12:45 PM Changeset in webkit [204697] by
-
- 3 edits2 adds in trunk
[DFG] Should not fixup AnyIntUse in 32_64
https://bugs.webkit.org/show_bug.cgi?id=161029
Reviewed by Saam Barati.
JSTests:
- typeProfiler/int52-dfg.js: Added.
(test):
- typeProfiler/number-filter-dfg.js: Added.
(test):
Source/JavaScriptCore:
DFG fixup phase uses AnyIntUse even in 32bit DFG. This patch removes this incorrect filtering.
If the 32bit DFG see the TypeAnyInt, it should fallback to the NumberUse case.
And this patch also fixes the case that the type set only contains TypeNumber. Previously,
we used NumberUse edge filtering. But it misses AnyInt logging: While the NumberUse filter
passes both TypeAnyInt and TypeNumber, the type set only logged TypeNumber.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- 11:13 AM Changeset in webkit [204696] by
-
- 1 edit in trunk/Tools/ChangeLog
Fix up title in ChangeLog entry for r204695.
- 11:08 AM Changeset in webkit [204695] by
-
- 3 edits1 add in trunk/Tools
prepare-ChangeLog lists modified methods as having been deleted
https://bugs.webkit.org/show_bug.cgi?id=148437
Reviewed by Dan Bernstein.
- Scripts/prepare-ChangeLog:
(diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
assumes that its line ranges were from a unified diff without any context lines.
(extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
(extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
- Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
- Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
(discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
to /dev/null for the duration of the function call.
- 8:41 AM Changeset in webkit [204694] by
-
- 2 edits11 adds in trunk/LayoutTests
[Mac] Rebase some failing XMLHttpRequest tests
https://bugs.webkit.org/show_bug.cgi?id=161036
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-21
- TestExpectations: Unmarking rebased tests as failing.
- platform/ios-simulator/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt.
- platform/ios-simulator/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt.
- platform/ios-simulator/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt.
- platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt.
- platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt.
- platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt.
- 6:36 AM Changeset in webkit [204693] by
-
- 4 edits3 adds in trunk
cross-origin requests redirected fail or drop author requested headers
https://bugs.webkit.org/show_bug.cgi?id=112471
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-21
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/xmlhttprequest/redirections-and-user-headers.html
Storing original headers in DocumentThreadableLoader.
In case of cross-origin redirection in CORS mode, set the new request headers to the original headers.
Add a special handling to Authorization header that should not be used when it is already removed by the network layer.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
LayoutTests:
- http/tests/xmlhttprequest/redirections-and-user-headers-expected.txt: Added.
- http/tests/xmlhttprequest/redirections-and-user-headers.html: Added.
- http/tests/xmlhttprequest/resources/access-control-preflight-redirect.php: Added.
- 5:18 AM Changeset in webkit [204692] by
-
- 10 edits1 copy1 add in trunk/Source/WebCore
Introduce a MathMLAnnotationElement class for the annotation/annotation-xml elements
https://bugs.webkit.org/show_bug.cgi?id=160540
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-21
Reviewed by Darin Adler.
The <annotation> element can only contain text whereas the <annotation-xml> element can
contain some elements as described in the HTML5 RelaxNG schema. For this reason, they have
been implemented in the separate MathMLTextElement and MathMLInlineContainerElement
respectively. However, they are actually closer to each other than to token elements or
presentation containers. In particular they support very different attributes and are
considered by the <semantics> tag. Hence we move their implementations in a new
MathMLAnnotation class.
No new tests, already covered by existing tests.
- CMakeLists.txt: Add MathMLAnnotationElement.
- mathml/MathMLAllInOne.cpp: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAnnotationElement.cpp: Added.
(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): ASSERT that this class is only
for annotation and annotation-xml.
(WebCore::MathMLAnnotationElement::create):
(WebCore::MathMLAnnotationElement::createElementRenderer): Move implementation from
MathMLTextElement and MathMLInlineContainerElement.
(WebCore::MathMLAnnotationElement::childShouldCreateRenderer): Move implementation from
MathMLTextElement and MathMLElement.
(WebCore::MathMLAnnotationElement::attributeChanged): Move implementation from MathMLElement.
- mathml/MathMLAnnotationElement.h: Override isSemanticAnnotation and isPresentationMathML
to return true.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::childShouldCreateRenderer): Move the annotation-xml case into
MathMLAnnotationElement.
(WebCore::MathMLElement::attributeChanged): Deleted. This was only used for semantic
annotations and so the code is moved into MathMLAnnotationElement.
- mathml/MathMLElement.h:
(WebCore::MathMLElement::isMathMLToken): Return false and let derived class override this.
(WebCore::MathMLElement::isSemanticAnnotation): Ditto.
(WebCore::MathMLElement::updateSelectedChild): Make this public so that is can be used
by MathMLAnnotationElement::attributeChanged.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createElementRenderer): The annotation-xml case is
now handled in MathMLAnnotationElement.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createElementRenderer): The annotation case is handled is now
handled in MathMLAnnotationElement.
(WebCore::MathMLTextElement::childShouldCreateRenderer): Ditto.
- mathml/MathMLTextElement.h: Override isToken to return true.
- mathml/mathtags.in: Map annotation and annotation-xml to MathMLAnnotationElement.
- 3:55 AM Changeset in webkit [204691] by
-
- 2 edits1 delete in trunk/Source/WebCore
[GTK] Clean up CursorGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=157794
Reviewed by Darin Adler.
We use GdkCursorType extensively in CursorGtk.cpp, but GTK+ does not support this anymore
and they're only sure to work under X11. Instead, use supported CSS cursor names. This
follows the grand tradition of replacing constants with hardcoded string values, but such
is the new best practice in GTK+ world.
Also, we have a bunch of custom cursors copied from Firefox. Each of these cursors is
nowadays guaranteed to be provided by GTK+, so we don't need any of these anymore.
- platform/gtk/CursorGtk.cpp:
(WebCore::createNamedCursor):
(WebCore::Cursor::ensurePlatformCursor):
- platform/gtk/CursorGtk.h: Removed.
Aug 20, 2016:
- 10:21 PM Changeset in webkit [204690] by
-
- 8 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r204668
r204668 changed MessageDecoder with Decoder though, MessageDecoder remained
in EFL specific files.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- UIProcess/WebVibrationProxy.h:
- WebProcess/Battery/WebBatteryManager.h:
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::didReceiveCoordinatedLayerTreeHostMessage):
- WebProcess/WebPage/AcceleratedDrawingArea.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
- 8:26 PM Changeset in webkit [204689] by
-
- 1 edit1 delete in trunk/Tools
[EFL] Remove unnecessary a patch to mute ecore warnings
https://bugs.webkit.org/show_bug.cgi?id=160997
Patch by Gyuyoung Kim <gyuyoung.kim@navercorp.com> on 2016-08-20
Reviewed by Darin Adler.
There is no warning messages during the layout test and perf test
after bumping efl version from 1.17 to 1.18. Remove it.
- efl/patches/ecore_remove_warnings.patch: Removed.
- 8:06 PM Changeset in webkit [204688] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- dom/UIEvent.h:
- 7:21 PM Changeset in webkit [204687] by
-
- 74 edits in trunk/Source/WebCore
Removed Objective-C specific attributes from IDL, made conditionals more consistent
https://bugs.webkit.org/show_bug.cgi?id=160900
Reviewed by Sam Weinig.
Removed all Objective-C-specific attributes from all the various IDL files where
they were used. Except, oops, Sam already did that, and so everything just merged!
Now that Objective-C is gone, made all the conditionals be based on LANGUAGE_GOBJECT
specifically. Later we should cut these down because many were not actually needed
for the GObject bindings, actually only for Objective-C. Also made the style of
conditional consistent. Also re-sorted attributes in alphabetical order in many cases
and made formatting more consistent without fancy indentation. Also removed old comments
that tried to document where various operations and attributes were defined; it's not
helpful to track "this was part of DOM level 2" at this point. Also fixed a variety of
types to explicitly state the values are nullable in cases where the generated code
is currently not affected by that; mostly read-only attribute types.
- Modules/mediasession/HTMLMediaElementMediaSession.idl:
- Modules/mediastream/HTMLMediaElementMediaStream.idl:
- animation/AnimationTimeline.idl:
- animation/DocumentAnimation.idl:
- bindings/scripts/IDLAttributes.txt:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValue.idl:
- css/RGBColor.idl:
- css/StyleSheet.idl:
- dom/CharacterData.idl:
- dom/DOMCoreException.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/KeyboardEvent.idl:
- dom/MessageEvent.idl:
- dom/MessagePort.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NonElementParentNode.idl:
- dom/Range.idl:
- dom/Slotable.idl:
- dom/UIEvent.idl:
- dom/WheelEvent.idl:
- fileapi/FileException.idl:
- html/DOMTokenList.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLCollection.idl:
- html/HTMLDocument.idl:
- html/HTMLElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLOptionElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableColElement.idl:
- html/HTMLVideoElement.idl:
- html/ImageData.idl:
- html/URLUtils.idl:
- html/track/TextTrack.idl:
- page/AbstractView.idl:
- page/DOMSelection.idl:
- page/DOMWindow.idl:
- page/Location.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- svg/SVGException.idl:
- svg/SVGExternalResourcesRequired.idl:
- svg/SVGFilterPrimitiveStandardAttributes.idl:
- svg/SVGFitToViewBox.idl:
- svg/SVGPathSeg.idl:
- svg/SVGTests.idl:
- svg/SVGURIReference.idl:
- svg/SVGZoomAndPan.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/Worker.idl:
- workers/WorkerGlobalScope.idl:
- xml/XPathException.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
See above for summary of changes.
- 6:43 PM Changeset in webkit [204686] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remote Inspector: some methods don't need to be marked virtual anymore
https://bugs.webkit.org/show_bug.cgi?id=161033
Reviewed by Darin Adler.
This probably happened when this code was last refactored and moved around.
- inspector/remote/RemoteConnectionToTarget.h:
- 6:09 PM Changeset in webkit [204685] by
-
- 35 edits in trunk/Source/WebCore
Remove Objective-C specific extended attributes from the bindings
https://bugs.webkit.org/show_bug.cgi?id=161034
Reviewed by Dan Bernstein.
- Removes ObjCPolymorphic, ObjCProtocol, ObjCLegacyUnnamedParameters and ObjCExplicitAtomicString extended attributes.
- animation/AnimationTimeline.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- dom/CharacterData.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NonElementParentNode.idl:
- dom/Range.idl:
- dom/UIEvent.idl:
- html/HTMLCollection.idl:
- html/HTMLSelectElement.idl:
- svg/SVGExternalResourcesRequired.idl:
- svg/SVGFilterPrimitiveStandardAttributes.idl:
- svg/SVGFitToViewBox.idl:
- svg/SVGPathSeg.idl:
- svg/SVGTests.idl:
- svg/SVGURIReference.idl:
- svg/SVGZoomAndPan.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- 5:54 PM Changeset in webkit [204684] by
-
- 37 edits in trunk/Source/WebCore
Roll out r204683.
- 4:43 PM Changeset in webkit [204683] by
-
- 37 edits in trunk/Source/WebCore
Remove Objective-C specific extended attributes / features from the bindings
https://bugs.webkit.org/show_bug.cgi?id=161034
Reviewed by Dan Bernstein.
- Removes ObjCPolymorphic, ObjCProtocol, ObjCLegacyUnnamedParameters and ObjCExplicitAtomicString extended attributes.
- Remove support for multiple inheritance from the IDLParser.
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/IDLParser.pm:
- animation/AnimationTimeline.idl:
- css/CSSMediaRule.idl:
- css/CSSPrimitiveValue.idl:
- css/CSSRule.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSStyleSheet.idl:
- css/CSSValue.idl:
- css/StyleSheet.idl:
- dom/CharacterData.idl:
- dom/DOMImplementation.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/MouseEvent.idl:
- dom/MutationEvent.idl:
- dom/NamedNodeMap.idl:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/NonElementParentNode.idl:
- dom/Range.idl:
- dom/UIEvent.idl:
- html/HTMLCollection.idl:
- html/HTMLSelectElement.idl:
- svg/SVGExternalResourcesRequired.idl:
- svg/SVGFilterPrimitiveStandardAttributes.idl:
- svg/SVGFitToViewBox.idl:
- svg/SVGPathSeg.idl:
- svg/SVGTests.idl:
- svg/SVGURIReference.idl:
- svg/SVGZoomAndPan.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
- 3:00 PM Changeset in webkit [204682] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Web Content service with a restricted entitlement may load arbitrary dylibs
https://bugs.webkit.org/show_bug.cgi?id=156668
<rdar://problem/25429784>
Reviewed by Sam Weinig.
- Configurations/WebContentService.xcconfig: Enable library validation when the Web Content service is given the XPC domain extension entitlement.
- 2:40 PM Changeset in webkit [204681] by
-
- 28 edits1 delete in trunk/Source/WebCore
Stop pretending that AbstractView is a thing, it's not
https://bugs.webkit.org/show_bug.cgi?id=161032
Reviewed by Dan Bernstein.
Remove AbstractView.idl, the AbstractView typedef of DOMWindow, and
all special casing of the name AbstractView in the JS code generator.
No change in behavior.
- DerivedSources.make:
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEvent::createForBindings):
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
- Modules/indieui/UIRequestEvent.h:
(WebCore::UIRequestEvent::receiver):
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/CodeGeneratorJS.pm:
(ShouldGenerateToJSDeclaration):
(GetImplClassName):
- dom/CompositionEvent.cpp:
(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::~CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):
- dom/CompositionEvent.h:
- dom/FocusEvent.cpp:
(WebCore::FocusEvent::isFocusEvent):
(WebCore::FocusEvent::FocusEvent):
- dom/FocusEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::~KeyboardEvent):
(WebCore::KeyboardEvent::initKeyboardEvent):
- dom/KeyboardEvent.h:
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::createForBindings):
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::~MouseEvent):
(WebCore::MouseEvent::initMouseEvent):
- dom/MouseEvent.h:
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::contentsScrollOffset):
- dom/MouseRelatedEvent.h:
- dom/SimulatedClick.cpp:
- dom/TextEvent.cpp:
(WebCore::TextEvent::createForBindings):
(WebCore::TextEvent::create):
(WebCore::TextEvent::createForPlainTextPaste):
(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::createForDrop):
(WebCore::TextEvent::createForDictation):
(WebCore::TextEvent::TextEvent):
(WebCore::TextEvent::~TextEvent):
(WebCore::TextEvent::initTextEvent):
- dom/TextEvent.h:
- dom/TouchEvent.h:
- dom/UIEvent.cpp:
(WebCore::UIEvent::UIEvent):
(WebCore::UIEvent::~UIEvent):
(WebCore::UIEvent::initUIEvent):
- dom/UIEvent.h:
(WebCore::UIEvent::create):
(WebCore::UIEvent::createForBindings):
(WebCore::UIEvent::view):
(WebCore::UIEvent::detail):
- dom/UIEventWithKeyState.h:
(WebCore::UIEventWithKeyState::UIEventWithKeyState):
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEvent::initWebKitWheelEvent):
- dom/WheelEvent.h:
- page/AbstractView.idl: Removed.
- 10:29 AM Changeset in webkit [204680] by
-
- 7 edits in trunk/Tools
REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
https://bugs.webkit.org/show_bug.cgi?id=160985
Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
device shutdown seems to happen as result of killing Simulator.apps, and we're racing
with that.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_config):
- Scripts/webkitpy/port/base.py:
(Port.driver_cmd_line_for_logging):
(Port.driver_cmd_line): Deleted.
- Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver.cmd_line):
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.init):
(IOSSimulatorPort.driver_cmd_line_for_logging):
(IOSSimulatorPort._create_simulators):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort._quit_ios_simulator):
(IOSSimulatorPort.clean_up_test_run):
(IOSSimulatorPort._create_device):
(IOSSimulatorPort):
(IOSSimulatorPort._remove_device):
(IOSSimulatorPort._testing_device):
(IOSSimulatorPort.device_id_for_worker_number):
(IOSSimulatorPort._set_device_class): Deleted.
(IOSSimulatorPort.testing_device): Deleted.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_driver_cmd_line):
- Scripts/webkitpy/xcode/simulator.py:
(Device.shutdown):
(Device):
(Device.delete):
(Device.reset):
(Simulator):
(Simulator.create_device):
(Simulator.remove_device):
(Simulator.device_number):
(Simulator.device_state_description):
(Simulator.wait_until_device_is_in_state):
- 7:44 AM Changeset in webkit [204679] by
-
- 32 edits1 delete in trunk
Location.ancestorOrigins should return a FrozenArray<USVString>
https://bugs.webkit.org/show_bug.cgi?id=161018
Reviewed by Ryosuke Niwa and Chris Dumez.
Source/JavaScriptCore:
- runtime/ObjectConstructor.h:
(JSC::objectConstructorFreeze):
Export objectConstructorFreeze so it can be used to freeze DOM FrozenArrays.
Source/WebCore:
Updated tests: fast/dom/Window/Location/ancestor-origins.html
fast/dom/indexed-getters-returning-string.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):
- Modules/indexeddb/IDBDatabase.h:
Remove unused ScriptExecutionContext parameter.
- Modules/indexeddb/IDBDatabase.idl:
There is no need for a custom implementation anymore.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
Remove JSDOMStringListCustom.cpp, which is no longer needed.
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsArray): Deleted.
Remove overload of jsArray that took a DOMStringList.
- bindings/js/JSDOMBinding.h:
(WebCore::jsFrozenArray):
Add jsFrozenArray which returns an JSArray which has had the moral
equivalent of Object.freeze() called on it. This follows
http://heycam.github.io/webidl/#es-frozen-array.
- bindings/js/JSDOMStringListCustom.cpp:
Removed.
- bindings/js/JSIDBDatabaseCustom.cpp:
(WebCore::JSIDBDatabase::transaction): Deleted.
Remove no longer necessary custom implementation of transaction.
- bindings/scripts/CodeGenerator.pm:
(IsRefPtrType):
(IsSVGAnimatedType):
(IsSequenceType):
(GetSequenceType):
(IsFrozenArrayType):
(GetFrozenArrayInnerType):
- bindings/scripts/CodeGeneratorJS.pm:
(AreTypesDistinguishableForOverloadResolution):
(GenerateOverloadedFunctionOrConstructor):
(GetNativeType):
(GetNativeVectorInnerType):
(GetNativeTypeForCallbacks):
(JSValueToNative):
(NativeToJSValue):
- bindings/scripts/IDLParser.pm:
(parseNonAnyType):
Add support for FrozenArray, closely matching the sequence code.
- bindings/scripts/test/JS/JSTestCallback.cpp:
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
- bindings/scripts/test/JS/JSTestCallbackFunction.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
Updated bindings test results.
- dom/DOMStringList.idl:
Remove JSCustomToNativeObject, which is no longer needed.
- inspector/InspectorIndexedDBAgent.cpp:
Update calls to IDBDatabase::transaction.
- page/Location.cpp:
(WebCore::Location::ancestorOrigins):
- page/Location.h:
Change ancestorOrigins to return a Vector<String> rather than
a DOMStringList.
- page/Location.idl:
Change ancestorOrigins to return a FrozenArray<USVString>, matching
the HTML5 spec.
LayoutTests:
Update existing tests to account for the change in type of Location.ancestorOrigins.
- fast/dom/Window/Location/ancestor-origins-expected.txt:
- fast/dom/Window/Location/ancestor-origins.html:
- fast/dom/indexed-getters-returning-string-expected.txt:
- fast/dom/indexed-getters-returning-string.html:
- 4:39 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 2:38 AM Changeset in webkit [204678] by
-
- 20 edits in trunk/Source/WebKit2
[GTK] Unreviewed GTK build fix since r204665 and 204668
https://bugs.webkit.org/show_bug.cgi?id=161020
- CMakeLists.txt:
- Platform/IPC/MessageRecorder.cpp:
(IPC::MessageRecorder::recordOutgoingMessage):
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
(IPC::Connection::sendOutgoingMessage):
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
- PlatformGTK.cmake:
- Scripts/webkit/LegacyMessageReceiver-expected.cpp:
(Messages::WebPage::GetPluginProcessConnection::DelayedReply::DelayedReply):
(Messages::WebPage::TestMultipleAttributes::DelayedReply::DelayedReply):
(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):
- Scripts/webkit/LegacyMessages-expected.h:
- Scripts/webkit/MessageReceiver-expected.cpp:
(Messages::WebPage::GetPluginProcessConnection::DelayedReply::DelayedReply):
(Messages::WebPage::TestMultipleAttributes::DelayedReply::DelayedReply):
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- Scripts/webkit/Messages-expected.h:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::FilterOperations>::encode):
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
(IPC::ArgumentCoder<TransformOperations>::encode):
(IPC::ArgumentCoder<TransformOperations>::decode):
(IPC::encodeTimingFunction):
(IPC::decodeTimingFunction):
(IPC::ArgumentCoder<TextureMapperAnimation>::encode):
(IPC::ArgumentCoder<TextureMapperAnimation>::decode):
(IPC::ArgumentCoder<TextureMapperAnimations>::encode):
(IPC::ArgumentCoder<TextureMapperAnimations>::decode):
(IPC::ArgumentCoder<WebCore::GraphicsSurfaceToken>::encode):
(IPC::ArgumentCoder<WebCore::GraphicsSurfaceToken>::decode):
(IPC::ArgumentCoder<SurfaceUpdateInfo>::encode):
(IPC::ArgumentCoder<SurfaceUpdateInfo>::decode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::decode):
(IPC::ArgumentCoder<TileUpdateInfo>::encode):
(IPC::ArgumentCoder<TileUpdateInfo>::decode):
(IPC::ArgumentCoder<TileCreationInfo>::encode):
(IPC::ArgumentCoder<TileCreationInfo>::decode):
(IPC::encodeCoordinatedSurface):
(IPC::decodeCoordinatedSurface):
(IPC::ArgumentCoder<CoordinatedGraphicsState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsState>::decode):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::Handle::decode):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/WebBatteryStatus.cpp:
(WebKit::WebBatteryStatus::Data::encode):
(WebKit::WebBatteryStatus::Data::decode):
- Shared/WebBatteryStatus.h:
- Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::encodeImage):
(IPC::decodeImage):
(IPC::encodeDataObject):
(IPC::decodeDataObject):
(IPC::ArgumentCoder<DragData>::encode):
(IPC::ArgumentCoder<DragData>::decode):
(IPC::encodeGKeyFile):
(IPC::decodeGKeyFile):
(IPC::encode):
(IPC::decode):
- Shared/gtk/ArgumentCodersGtk.h:
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
(IPC::ArgumentCoder<CertificateInfo>::encode):
(IPC::ArgumentCoder<CertificateInfo>::decode):
(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData):
(IPC::ArgumentCoder<Credential>::encodePlatformData):
(IPC::ArgumentCoder<Credential>::decodePlatformData):
- UIProcess/LegacySessionStateCodingNone.cpp:
(WebKit::encodeLegacySessionState):
(WebKit::decodeLegacySessionState):
- UIProcess/WebBatteryManagerProxy.h:
- 1:04 AM Changeset in webkit [204677] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, build fix attempt after r204665 and r204668.
- PlatformGTK.cmake:
Aug 19, 2016:
- 9:53 PM Changeset in webkit [204676] by
-
- 2 edits in trunk/Source/WebKit2
Another build fix attempt after r204665 and r204668.
- CMakeLists.txt:
- 9:44 PM Changeset in webkit [204675] by
-
- 2 edits in trunk/Source/WebKit2
GTK+ / EFL build fix attempt after r204665.
- CMakeLists.txt:
- 8:10 PM Changeset in webkit [204674] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
Unreviewed, roll out part of r204662 to see if it addresses flakiness.
- web-platform-tests/html/dom/interfaces.html:
- 7:59 PM Changeset in webkit [204673] by
-
- 4 edits in branches/safari-602.1.50.1-branch/Tools
2016-08-19 Alexey Proskuryakov <ap@apple.com>
Adopt SimServiceContext in LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=161000
<rdar://problem/25765594>
Reviewed by Daniel Bates.
- LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
- LayoutTestRelay/LayoutTestRelay/main.m:
- 7:53 PM Changeset in webkit [204672] by
-
- 7 edits in trunk/Tools
Unreviewed, rolling out r204659.
This change appears to have caused ios-simulator LayoutTests
to fail when shutting down the simulator
Reverted changeset:
"REGRESSION (r204477): Running LayoutTests on ios-simulator
became ~15 minutes slower"
https://bugs.webkit.org/show_bug.cgi?id=160985
http://trac.webkit.org/changeset/204659
- 7:51 PM Changeset in webkit [204671] by
-
- 4 edits in branches/safari-602-branch/Tools
2016-08-19 Alexey Proskuryakov <ap@apple.com>
Adopt SimServiceContext in LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=161000
<rdar://problem/25765594>
Reviewed by Daniel Bates.
- LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
- LayoutTestRelay/LayoutTestRelay/main.m:
- 7:00 PM Changeset in webkit [204670] by
-
- 20 edits1 add in trunk
[JSC] ArithSqrt should work with any argument type
https://bugs.webkit.org/show_bug.cgi?id=160954
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-19
Reviewed by Saam Barati.
JSTests:
- stress/arith-sqrt-on-various-types.js: Added.
(let.validInputTypedTestCases.validInputTestCases.map):
(isIdentical):
(opaqueAllTypesSqrt):
(testAllTypesCall):
(testSingleTypeCall):
(opaqueSqrtForSideEffects):
(testSideEffect.let.testObject.valueOf):
(testSideEffect):
(opaqueSqrtForCSE):
(testCSE.let.testObject.valueOf):
(testCSE):
(testException.opaqueSqrtWithException):
(testException):
Source/JavaScriptCore:
Previsouly, ArithSqrt would always OSR Exit if the argument
is not typed Integer, Double, or Boolean.
Since we can't recover by generalizing to those, we continuously
OSR Exit and recompile the same code over and over again.
This patch introduces a fallback to handle the remaining types.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGMayExit.cpp:
This is somewhat unrelated. While discussing the design of this
with Filip, we decided not to use ToNumber+ArithSqrt despite
the guarantee that ToNumber does not OSR Exit.
Since it does not OSR Exit, we should say so in mayExitImpl().
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithSqrt):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithSqrt):
- 5:45 PM Changeset in webkit [204669] by
-
- 10 edits2 moves1 add in trunk
Mark CanvasPath operations' parameters as mandatory when they should be
https://bugs.webkit.org/show_bug.cgi?id=161014
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Mark CanvasPath operations as mandatory when they should be:
This patch moves the CanvasPath methods from CanvasRenderingContext2D
and Path2D to a new CanvasPath interface, to avoid duplication and
match the specification.
The parameters were correctly marked as mandatory in WebKit on
CanvasRenderingContext2D but not on Path2D.
Those parameters are correctly marked as mandatory in Chrome and Firefox.
No new tests, rebaselined existing test.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/CanvasPath.cpp: Renamed from Source/WebCore/html/canvas/CanvasPathMethods.cpp.
(WebCore::CanvasPath::closePath):
(WebCore::CanvasPath::moveTo):
(WebCore::CanvasPath::lineTo):
(WebCore::CanvasPath::quadraticCurveTo):
(WebCore::CanvasPath::bezierCurveTo):
(WebCore::CanvasPath::arcTo):
(WebCore::normalizeAngles):
(WebCore::CanvasPath::arc):
(WebCore::CanvasPath::ellipse):
(WebCore::CanvasPath::rect):
- html/canvas/CanvasPath.h: Renamed from Source/WebCore/html/canvas/CanvasPathMethods.h.
(WebCore::CanvasPath::~CanvasPath):
(WebCore::CanvasPath::CanvasPath):
(WebCore::CanvasPath::hasInvertibleTransform):
- html/canvas/CanvasPath.idl: Added.
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
- html/canvas/DOMPath.h:
- html/canvas/DOMPath.idl:
- 5:11 PM Changeset in webkit [204668] by
-
- 266 edits2 moves2 deletes in trunk/Source/WebKit2
Merge MessageDecoder and ArgumentDecoder into Decoder
https://bugs.webkit.org/show_bug.cgi?id=161019
Reviewed by Tim Horton.
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- NetworkProcess/CustomProtocols/CustomProtocolManager.h:
- NetworkProcess/Downloads/DownloadID.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
- NetworkProcess/NetworkResourceLoadParameters.h:
- NetworkProcess/NetworkResourceLoader.h:
- Platform/IPC/ArgumentCoder.h:
- Platform/IPC/ArgumentCoders.cpp:
- Platform/IPC/ArgumentCoders.h:
- Platform/IPC/ArgumentDecoder.cpp:
- Platform/IPC/ArgumentDecoder.h:
- Platform/IPC/Arguments.h:
- Platform/IPC/Attachment.cpp:
- Platform/IPC/Attachment.h:
- Platform/IPC/Connection.cpp:
- Platform/IPC/Connection.h:
- Platform/IPC/DataReference.cpp:
- Platform/IPC/DataReference.h:
- Platform/IPC/Decoder.cpp: Renamed from Source/WebKit2/Platform/IPC/ArgumentDecoder.cpp.
- Platform/IPC/Decoder.h: Renamed from Source/WebKit2/Platform/IPC/ArgumentDecoder.h.
- Platform/IPC/HandleMessage.h:
- Platform/IPC/MessageDecoder.cpp: Removed.
- Platform/IPC/MessageDecoder.h: Removed.
- Platform/IPC/MessageReceiver.h:
- Platform/IPC/MessageReceiverMap.cpp:
- Platform/IPC/MessageReceiverMap.h:
- Platform/IPC/MessageRecorder.cpp:
- Platform/IPC/MessageRecorder.h:
- Platform/IPC/StringReference.cpp:
- Platform/IPC/StringReference.h:
- Platform/IPC/mac/ConnectionMac.mm:
- Platform/IPC/mac/MachPort.h:
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp:
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginCreationParameters.cpp:
- PluginProcess/PluginCreationParameters.h:
- PluginProcess/PluginProcess.cpp:
- PluginProcess/PluginProcess.h:
- PluginProcess/WebProcessConnection.cpp:
- PluginProcess/WebProcessConnection.h:
- Scripts/webkit/messages.py:
- Shared/API/APIData.cpp:
- Shared/API/APIData.h:
- Shared/API/APIError.cpp:
- Shared/API/APIError.h:
- Shared/API/APIFrameHandle.cpp:
- Shared/API/APIFrameHandle.h:
- Shared/API/APIGeometry.cpp:
- Shared/API/APIGeometry.h:
- Shared/API/APINumber.h:
- Shared/API/APIPageGroupHandle.cpp:
- Shared/API/APIPageGroupHandle.h:
- Shared/API/APIPageHandle.cpp:
- Shared/API/APIPageHandle.h:
- Shared/API/APIURL.h:
- Shared/API/APIURLRequest.cpp:
- Shared/API/APIURLRequest.h:
- Shared/API/APIURLResponse.cpp:
- Shared/API/APIURLResponse.h:
- Shared/API/Cocoa/RemoteObjectInvocation.h:
- Shared/API/Cocoa/RemoteObjectInvocation.mm:
- Shared/API/Cocoa/RemoteObjectRegistry.h:
- Shared/AssistedNodeInformation.cpp:
- Shared/AssistedNodeInformation.h:
- Shared/Authentication/AuthenticationManager.h:
- Shared/ChildProcess.h:
- Shared/Cocoa/DataDetectionResult.h:
- Shared/Cocoa/DataDetectionResult.mm:
- Shared/Cocoa/LoadParametersCocoa.mm:
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
- Shared/ContextMenuContextData.cpp:
- Shared/ContextMenuContextData.h:
- Shared/Databases/DatabaseProcessCreationParameters.cpp:
- Shared/Databases/DatabaseProcessCreationParameters.h:
- Shared/Databases/IndexedDB/WebIDBResult.cpp:
- Shared/Databases/IndexedDB/WebIDBResult.h:
- Shared/EditorState.cpp:
- Shared/EditorState.h:
- Shared/FontInfo.cpp:
- Shared/FontInfo.h:
- Shared/Gamepad/GamepadData.cpp:
- Shared/Gamepad/GamepadData.h:
- Shared/LayerTreeContext.cpp:
- Shared/LayerTreeContext.h:
- Shared/LoadParameters.cpp:
- Shared/LoadParameters.h:
- Shared/NavigationActionData.cpp:
- Shared/NavigationActionData.h:
- Shared/PlatformPopupMenuData.cpp:
- Shared/PlatformPopupMenuData.h:
- Shared/Plugins/NPIdentifierData.cpp:
- Shared/Plugins/NPIdentifierData.h:
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/Plugins/NPVariantData.cpp:
- Shared/Plugins/NPVariantData.h:
- Shared/Plugins/PluginProcessCreationParameters.cpp:
- Shared/Plugins/PluginProcessCreationParameters.h:
- Shared/PrintInfo.cpp:
- Shared/PrintInfo.h:
- Shared/SandboxExtension.h:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
- Shared/SessionState.cpp:
- Shared/SessionState.h:
- Shared/ShareableBitmap.cpp:
- Shared/ShareableBitmap.h:
- Shared/ShareableResource.cpp:
- Shared/ShareableResource.h:
- Shared/StatisticsData.cpp:
- Shared/StatisticsData.h:
- Shared/UpdateInfo.cpp:
- Shared/UpdateInfo.h:
- Shared/UserData.cpp:
- Shared/UserData.h:
- Shared/VisibleContentRectUpdateInfo.cpp:
- Shared/VisibleContentRectUpdateInfo.h:
- Shared/WebBackForwardListItem.h:
- Shared/WebCompiledContentExtensionData.cpp:
- Shared/WebCompiledContentExtensionData.h:
- Shared/WebConnection.h:
- Shared/WebContextMenuItemData.cpp:
- Shared/WebContextMenuItemData.h:
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h:
- Shared/WebEvent.cpp:
- Shared/WebEvent.h:
- Shared/WebGeolocationPosition.cpp:
- Shared/WebGeolocationPosition.h:
- Shared/WebHitTestResultData.cpp:
- Shared/WebHitTestResultData.h:
- Shared/WebKeyboardEvent.cpp:
- Shared/WebMouseEvent.cpp:
- Shared/WebNavigationDataStore.h:
- Shared/WebPageCreationParameters.cpp:
- Shared/WebPageCreationParameters.h:
- Shared/WebPageGroupData.cpp:
- Shared/WebPageGroupData.h:
- Shared/WebPlatformTouchPoint.cpp:
- Shared/WebPopupItem.cpp:
- Shared/WebPopupItem.h:
- Shared/WebPreferencesStore.cpp:
- Shared/WebPreferencesStore.h:
- Shared/WebProcessCreationParameters.cpp:
- Shared/WebProcessCreationParameters.h:
- Shared/WebTouchEvent.cpp:
- Shared/WebUserContentControllerDataTypes.cpp:
- Shared/WebUserContentControllerDataTypes.h:
- Shared/WebWheelEvent.cpp:
- Shared/WebsiteData/WebsiteData.cpp:
- Shared/WebsiteData/WebsiteData.h:
- Shared/cf/ArgumentCodersCF.cpp:
- Shared/cf/ArgumentCodersCF.h:
- Shared/ios/InteractionInformationAtPosition.h:
- Shared/ios/InteractionInformationAtPosition.mm:
- Shared/ios/QuickLookDocumentData.cpp:
- Shared/ios/QuickLookDocumentData.h:
- Shared/ios/WebPlatformTouchPointIOS.cpp:
- Shared/ios/WebTouchEventIOS.cpp:
- Shared/mac/ArgumentCodersMac.h:
- Shared/mac/ArgumentCodersMac.mm:
- Shared/mac/AttributedString.h:
- Shared/mac/AttributedString.mm:
- Shared/mac/ColorSpaceData.h:
- Shared/mac/ColorSpaceData.mm:
- Shared/mac/ObjCObjectGraph.h:
- Shared/mac/ObjCObjectGraph.mm:
- Shared/mac/RemoteLayerBackingStore.h:
- Shared/mac/RemoteLayerBackingStore.mm:
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
- Shared/mac/SandboxExtensionMac.mm:
- Shared/mac/SecItemRequestData.cpp:
- Shared/mac/SecItemRequestData.h:
- Shared/mac/SecItemResponseData.cpp:
- Shared/mac/SecItemResponseData.h:
- Shared/mac/SecItemShim.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
- Shared/mac/WebGestureEvent.cpp:
- Shared/mac/WebGestureEvent.h:
- Shared/mac/WebHitTestResultData.mm:
- UIProcess/API/APIHitTestResult.h:
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/ChildProcessProxy.cpp:
- UIProcess/ChildProcessProxy.h:
- UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:
- UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h:
- UIProcess/Databases/DatabaseProcessProxy.cpp:
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
- UIProcess/Storage/StorageManager.h:
- UIProcess/UserContent/WebUserContentControllerProxy.h:
- UIProcess/VisitedLinkStore.h:
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebProcessPool.cpp:
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/ios/SmartMagnificationController.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/SecItemShimProxy.h:
- UIProcess/mac/ViewGestureController.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/ApplePay/WebPaymentCoordinator.h:
- WebProcess/Automation/WebAutomationSessionProxy.h:
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/FullScreen/WebFullScreenManager.h:
- WebProcess/Geolocation/WebGeolocationManager.h:
- WebProcess/IconDatabase/WebIconDatabaseProxy.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/Plugins/Plugin.cpp:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- WebProcess/Plugins/PluginProcessConnectionManager.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
- WebProcess/Storage/StorageAreaMap.h:
- WebProcess/UserContent/WebUserContentController.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/ViewGestureGeometryCollector.h:
- WebProcess/WebPage/ViewUpdateDispatcher.h:
- WebProcess/WebPage/VisitedLinkTableController.h:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- WebProcess/cocoa/WebPlaybackSessionManager.h:
- WebProcess/cocoa/WebVideoFullscreenManager.h:
- 4:09 PM Changeset in webkit [204667] by
-
- 7 edits in trunk/Source/WebCore
RenderObject::containingBlock() cleanup.
https://bugs.webkit.org/show_bug.cgi?id=161013
Reviewed by Simon Fraser.
Move ::containingBlockForAbsolutePosition and ::containingBlockForFixedPosition
to RenderElement after tightening containingBlock() callsites.
No change in functionality.
- dom/Element.cpp:
(WebCore::layoutOverflowRectContainsAllDescendants):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::containingBlockForFixedPosition):
(WebCore::RenderElement::containingBlockForAbsolutePosition):
- rendering/RenderElement.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleWillChange):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::containingBlockForFixedPosition): Deleted.
(WebCore::RenderObject::containingBlockForAbsolutePosition): Deleted.
- rendering/RenderObject.h:
- 3:55 PM Changeset in webkit [204666] by
-
- 2 edits in trunk/Source/WebKit2
Update Xcode project.
- WebKit2.xcodeproj/project.pbxproj:
- 3:52 PM Changeset in webkit [204665] by
-
- 219 edits2 moves2 deletes in trunk/Source/WebKit2
Merge MessageEncoder and ArgumentEncoder into Encoder
https://bugs.webkit.org/show_bug.cgi?id=161016
Reviewed by Tim Horton.
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didReceiveSyncMessage):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- NetworkProcess/Downloads/DownloadID.h:
(IPC::ArgumentCoder<WebKit::DownloadID>::encode):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
- NetworkProcess/NetworkProcessCreationParameters.h:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode):
- NetworkProcess/NetworkResourceLoadParameters.h:
- Platform/IPC/ArgumentCoder.h:
(IPC::ArgumentCoder::encode):
- Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<std::chrono::system_clock::time_point>::encode):
(IPC::ArgumentCoder<AtomicString>::encode):
(IPC::ArgumentCoder<CString>::encode):
(IPC::ArgumentCoder<String>::encode):
(IPC::ArgumentCoder<uuid_t>::encode):
- Platform/IPC/ArgumentCoders.h:
(IPC::SimpleArgumentCoder::encode):
(IPC::ArgumentCoder<OptionSet<T>>::encode):
(IPC::ArgumentCoder<WTF::Optional<T>>::encode):
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::allocBuffer): Deleted.
(IPC::freeBuffer): Deleted.
(IPC::ArgumentEncoder::ArgumentEncoder): Deleted.
(IPC::ArgumentEncoder::~ArgumentEncoder): Deleted.
(IPC::roundUpToAlignment): Deleted.
(IPC::ArgumentEncoder::reserve): Deleted.
(IPC::ArgumentEncoder::grow): Deleted.
(IPC::ArgumentEncoder::encodeFixedLengthData): Deleted.
(IPC::ArgumentEncoder::encodeVariableLengthByteArray): Deleted.
(IPC::copyValueToBuffer): Deleted.
(IPC::ArgumentEncoder::encode): Deleted.
(IPC::ArgumentEncoder::addAttachment): Deleted.
(IPC::ArgumentEncoder::releaseAttachments): Deleted.
- Platform/IPC/ArgumentEncoder.h:
(IPC::ArgumentEncoder::encodeEnum): Deleted.
(IPC::ArgumentEncoder::encode): Deleted.
(IPC::ArgumentEncoder::operator<<): Deleted.
(IPC::ArgumentEncoder::buffer): Deleted.
(IPC::ArgumentEncoder::bufferSize): Deleted.
- Platform/IPC/Arguments.h:
(IPC::TupleCoder::encode):
(IPC::Arguments::encode):
- Platform/IPC/Attachment.cpp:
(IPC::Attachment::encode):
- Platform/IPC/Attachment.h:
- Platform/IPC/Connection.cpp:
(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::createSyncMessageEncoder):
(IPC::Connection::sendMessage):
(IPC::Connection::sendSyncReply):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::sendOutgoingMessages):
(IPC::Connection::dispatchSyncMessage):
- Platform/IPC/Connection.h:
(IPC::Connection::send):
(IPC::Connection::sendSync):
- Platform/IPC/DataReference.cpp:
(IPC::DataReference::encode):
(IPC::SharedBufferDataReference::encode):
- Platform/IPC/DataReference.h:
- Platform/IPC/Encoder.cpp: Renamed from Source/WebKit2/Platform/IPC/ArgumentEncoder.cpp.
(IPC::allocBuffer):
(IPC::freeBuffer):
(IPC::Encoder::Encoder):
(IPC::Encoder::~Encoder):
(IPC::Encoder::isSyncMessage):
(IPC::Encoder::shouldDispatchMessageWhenWaitingForSyncReply):
(IPC::Encoder::setIsSyncMessage):
(IPC::Encoder::setShouldDispatchMessageWhenWaitingForSyncReply):
(IPC::Encoder::setFullySynchronousModeForTesting):
(IPC::Encoder::wrapForTesting):
(IPC::roundUpToAlignment):
(IPC::Encoder::reserve):
(IPC::Encoder::encodeHeader):
(IPC::Encoder::grow):
(IPC::Encoder::encodeFixedLengthData):
(IPC::Encoder::encodeVariableLengthByteArray):
(IPC::copyValueToBuffer):
(IPC::Encoder::encode):
(IPC::Encoder::addAttachment):
(IPC::Encoder::releaseAttachments):
- Platform/IPC/Encoder.h: Renamed from Source/WebKit2/Platform/IPC/ArgumentEncoder.h.
- Platform/IPC/HandleMessage.h:
(IPC::handleMessage):
(IPC::handleMessageDelayed):
- Platform/IPC/MessageEncoder.cpp: Removed.
(IPC::MessageEncoder::MessageEncoder): Deleted.
(IPC::MessageEncoder::~MessageEncoder): Deleted.
(IPC::MessageEncoder::encodeHeader): Deleted.
(IPC::MessageEncoder::isSyncMessage): Deleted.
(IPC::MessageEncoder::shouldDispatchMessageWhenWaitingForSyncReply): Deleted.
(IPC::MessageEncoder::setIsSyncMessage): Deleted.
(IPC::MessageEncoder::setShouldDispatchMessageWhenWaitingForSyncReply): Deleted.
(IPC::MessageEncoder::setFullySynchronousModeForTesting): Deleted.
(IPC::MessageEncoder::wrapForTesting): Deleted.
- Platform/IPC/MessageEncoder.h: Removed.
(IPC::MessageEncoder::messageReceiverName): Deleted.
(IPC::MessageEncoder::messageName): Deleted.
(IPC::MessageEncoder::destinationID): Deleted.
(IPC::MessageEncoder::UUID): Deleted.
- Platform/IPC/MessageReceiver.h:
(IPC::MessageReceiver::didReceiveSyncMessage):
- Platform/IPC/MessageReceiverMap.cpp:
(IPC::MessageReceiverMap::dispatchSyncMessage):
- Platform/IPC/MessageReceiverMap.h:
- Platform/IPC/MessageRecorder.h:
- Platform/IPC/MessageSender.cpp:
(IPC::MessageSender::sendMessage):
- Platform/IPC/MessageSender.h:
(IPC::MessageSender::send):
- Platform/IPC/StringReference.cpp:
(IPC::StringReference::encode):
- Platform/IPC/StringReference.h:
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::open):
(IPC::Connection::sendOutgoingMessage):
- Platform/IPC/mac/MachPort.h:
(IPC::MachPort::encode):
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::encode):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::encode):
- PluginProcess/PluginCreationParameters.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
- Scripts/webkit/messages.py:
(message_to_struct_declaration):
(forward_declarations_and_headers):
(generate_message_handler):
(headers_for_type): Deleted.
- Shared/API/APIData.cpp:
(API::Data::encode):
- Shared/API/APIData.h:
- Shared/API/APIError.cpp:
(API::Error::encode):
- Shared/API/APIError.h:
- Shared/API/APIFrameHandle.cpp:
(API::FrameHandle::encode):
- Shared/API/APIFrameHandle.h:
- Shared/API/APIGeometry.cpp:
(API::Point::encode):
(API::Size::encode):
(API::Rect::encode):
- Shared/API/APIGeometry.h:
- Shared/API/APINumber.h:
(API::Number::encode):
- Shared/API/APIPageGroupHandle.cpp:
(API::PageGroupHandle::encode):
- Shared/API/APIPageGroupHandle.h:
- Shared/API/APIPageHandle.cpp:
(API::PageHandle::encode):
- Shared/API/APIPageHandle.h:
- Shared/API/APIURL.h:
(API::URL::encode):
- Shared/API/APIURLRequest.cpp:
(API::URLRequest::encode):
- Shared/API/APIURLRequest.h:
- Shared/API/APIURLResponse.cpp:
(API::URLResponse::encode):
- Shared/API/APIURLResponse.h:
- Shared/API/Cocoa/RemoteObjectInvocation.h:
- Shared/API/Cocoa/RemoteObjectInvocation.mm:
(WebKit::RemoteObjectInvocation::encode):
- Shared/AssistedNodeInformation.cpp:
(WebKit::OptionItem::encode):
(WebKit::AssistedNodeInformation::encode):
- Shared/AssistedNodeInformation.h:
- Shared/Cocoa/DataDetectionResult.h:
- Shared/Cocoa/DataDetectionResult.mm:
(WebKit::DataDetectionResult::encode):
- Shared/Cocoa/LoadParametersCocoa.mm:
(WebKit::LoadParameters::platformEncode):
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::Payment>::encode):
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMethod>::encode):
(IPC::ArgumentCoder<PaymentRequest>::encode):
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<PaymentRequest::LineItem>::encode):
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::encode):
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::encode):
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::encode):
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::encode):
- Shared/ContextMenuContextData.h:
- Shared/Databases/DatabaseProcessCreationParameters.cpp:
(WebKit::DatabaseProcessCreationParameters::encode):
- Shared/Databases/DatabaseProcessCreationParameters.h:
- Shared/Databases/IndexedDB/WebIDBResult.cpp:
(WebKit::WebIDBResult::encode):
- Shared/Databases/IndexedDB/WebIDBResult.h:
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::PostLayoutData::encode):
- Shared/EditorState.h:
- Shared/FontInfo.cpp:
(WebKit::FontInfo::encode):
- Shared/FontInfo.h:
- Shared/Gamepad/GamepadData.cpp:
(WebKit::GamepadData::encode):
- Shared/Gamepad/GamepadData.h:
- Shared/LayerTreeContext.cpp:
(WebKit::LayerTreeContext::encode):
- Shared/LayerTreeContext.h:
- Shared/LoadParameters.cpp:
(WebKit::LoadParameters::encode):
(WebKit::LoadParameters::platformEncode):
- Shared/LoadParameters.h:
- Shared/NavigationActionData.cpp:
(WebKit::NavigationActionData::encode):
- Shared/NavigationActionData.h:
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
- Shared/PlatformPopupMenuData.h:
- Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::encode):
- Shared/Plugins/NPIdentifierData.h:
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::encode):
- Shared/Plugins/NPVariantData.h:
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::encode):
- Shared/Plugins/PluginProcessCreationParameters.h:
- Shared/PrintInfo.cpp:
(WebKit::PrintInfo::encode):
- Shared/PrintInfo.h:
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::Handle::encode):
(WebKit::SandboxExtension::HandleArray::encode):
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateOverflowScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFixedNode>::encode):
(ArgumentCoder<ScrollingStateStickyNode>::encode):
(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::encode):
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
- Shared/SessionState.cpp:
(WebKit::HTTPBody::Element::encode):
(WebKit::HTTPBody::encode):
(WebKit::FrameState::encode):
(WebKit::PageState::encode):
(WebKit::BackForwardListItemState::encode):
(WebKit::BackForwardListState::encode):
- Shared/SessionState.h:
- Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::encode):
- Shared/ShareableBitmap.h:
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::encode):
- Shared/ShareableResource.h:
- Shared/StatisticsData.cpp:
(WebKit::StatisticsData::encode):
- Shared/StatisticsData.h:
- Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::encode):
- Shared/UpdateInfo.h:
- Shared/UserData.cpp:
(WebKit::UserData::encode):
- Shared/UserData.h:
- Shared/VisibleContentRectUpdateInfo.cpp:
(WebKit::VisibleContentRectUpdateInfo::encode):
- Shared/VisibleContentRectUpdateInfo.h:
- Shared/WebBackForwardListItem.h:
- Shared/WebCompiledContentExtensionData.cpp:
(WebKit::WebCompiledContentExtensionData::encode):
- Shared/WebCompiledContentExtensionData.h:
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::encode):
- Shared/WebContextMenuItemData.h:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<AffineTransform>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<TransformationMatrix>::encode):
(IPC::ArgumentCoder<LinearTimingFunction>::encode):
(IPC::ArgumentCoder<CubicBezierTimingFunction>::encode):
(IPC::ArgumentCoder<StepsTimingFunction>::encode):
(IPC::ArgumentCoder<SpringTimingFunction>::encode):
(IPC::ArgumentCoder<FloatPoint>::encode):
(IPC::ArgumentCoder<FloatPoint3D>::encode):
(IPC::ArgumentCoder<FloatRect>::encode):
(IPC::ArgumentCoder<FloatSize>::encode):
(IPC::ArgumentCoder<FloatRoundedRect>::encode):
(IPC::ArgumentCoder<FloatQuad>::encode):
(IPC::ArgumentCoder<ViewportArguments>::encode):
(IPC::ArgumentCoder<IntPoint>::encode):
(IPC::ArgumentCoder<IntRect>::encode):
(IPC::ArgumentCoder<IntSize>::encode):
(IPC::pathEncodeApplierFunction):
(IPC::ArgumentCoder<Path>::encode):
(IPC::ArgumentCoder<RecentSearch>::encode):
(IPC::ArgumentCoder<Region::Span>::encode):
(IPC::ArgumentCoder<Region>::encode):
(IPC::ArgumentCoder<Length>::encode):
(IPC::ArgumentCoder<ViewportAttributes>::encode):
(IPC::ArgumentCoder<MimeClassInfo>::encode):
(IPC::ArgumentCoder<PluginInfo>::encode):
(IPC::ArgumentCoder<AuthenticationChallenge>::encode):
(IPC::ArgumentCoder<ProtectionSpace>::encode):
(IPC::ArgumentCoder<Credential>::encode):
(IPC::encodeImage):
(IPC::encodeOptionalImage):
(IPC::ArgumentCoder<Cursor>::encode):
(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceError>::encode):
(IPC::ArgumentCoder<SelectionRect>::encode):
(IPC::ArgumentCoder<WindowFeatures>::encode):
(IPC::ArgumentCoder<Color>::encode):
(IPC::ArgumentCoder<CompositionUnderline>::encode):
(IPC::ArgumentCoder<Cookie>::encode):
(IPC::ArgumentCoder<DatabaseDetails>::encode):
(IPC::ArgumentCoder<Highlight>::encode):
(IPC::encodeSharedBuffer):
(IPC::ArgumentCoder<PasteboardWebContent>::encode):
(IPC::ArgumentCoder<PasteboardImage>::encode):
(IPC::ArgumentCoder<DictationAlternative>::encode):
(IPC::ArgumentCoder<FileChooserSettings>::encode):
(IPC::ArgumentCoder<GrammarDetail>::encode):
(IPC::ArgumentCoder<TextCheckingRequestData>::encode):
(IPC::ArgumentCoder<TextCheckingResult>::encode):
(IPC::ArgumentCoder<URL>::encode):
(IPC::ArgumentCoder<UserStyleSheet>::encode):
(IPC::ArgumentCoder<MediaSessionMetadata>::encode):
(IPC::ArgumentCoder<UserScript>::encode):
(IPC::ArgumentCoder<ScrollableAreaParameters>::encode):
(IPC::ArgumentCoder<FixedPositionViewportConstraints>::encode):
(IPC::ArgumentCoder<StickyPositionViewportConstraints>::encode):
(IPC::ArgumentCoder<FilterOperation>::encode):
(IPC::ArgumentCoder<FilterOperations>::encode):
(IPC::ArgumentCoder<SessionID>::encode):
(IPC::ArgumentCoder<BlobPart>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encode):
(IPC::ArgumentCoder<DictionaryPopupInfo>::encode):
(IPC::ArgumentCoder<ExceptionDetails>::encode):
(IPC::ArgumentCoder<ResourceLoadStatistics>::encode):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebEvent.cpp:
(WebKit::WebEvent::encode):
- Shared/WebEvent.h:
- Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::Data::encode):
- Shared/WebGeolocationPosition.h:
- Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::encode):
(WebKit::WebHitTestResultData::platformEncode):
- Shared/WebHitTestResultData.h:
- Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::encode):
- Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::encode):
- Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::encode):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
- Shared/WebPageCreationParameters.h:
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
- Shared/WebPageGroupData.h:
- Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::encode):
- Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::encode):
- Shared/WebPopupItem.h:
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::Value::encode):
(WebKit::WebPreferencesStore::encode):
- Shared/WebPreferencesStore.h:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
- Shared/WebProcessCreationParameters.h:
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::encode):
- Shared/WebUserContentControllerDataTypes.cpp:
(WebKit::WebUserScriptData::encode):
(WebKit::WebUserStyleSheetData::encode):
(WebKit::WebScriptMessageHandlerData::encode):
- Shared/WebUserContentControllerDataTypes.h:
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::encode):
- Shared/WebsiteData/WebsiteData.cpp:
(WebKit::WebsiteData::Entry::encode):
(WebKit::WebsiteData::encode):
- Shared/WebsiteData/WebsiteData.h:
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::encode):
- Shared/cf/ArgumentCodersCF.h:
- Shared/ios/InteractionInformationAtPosition.h:
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode):
- Shared/ios/QuickLookDocumentData.cpp:
(WebKit::QuickLookDocumentData::encode):
- Shared/ios/QuickLookDocumentData.h:
- Shared/ios/WebPlatformTouchPointIOS.cpp:
(WebKit::WebPlatformTouchPoint::encode):
- Shared/ios/WebTouchEventIOS.cpp:
(WebKit::WebTouchEvent::encode):
- Shared/mac/ArgumentCodersMac.h:
- Shared/mac/ArgumentCodersMac.mm:
(IPC::encode):
- Shared/mac/AttributedString.h:
- Shared/mac/AttributedString.mm:
(WebKit::AttributedString::encode):
- Shared/mac/ColorSpaceData.h:
- Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::encode):
- Shared/mac/ObjCObjectGraph.h:
- Shared/mac/ObjCObjectGraph.mm:
(WebKit::ObjCObjectGraph::encode):
- Shared/mac/RemoteLayerBackingStore.h:
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode):
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::encode):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::encode):
(WebKit::SandboxExtension::HandleArray::encode):
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::encode):
- Shared/mac/SecItemRequestData.h:
- Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::encode):
- Shared/mac/SecItemResponseData.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<CertificateInfo>::encode):
(IPC::encodeNSError):
(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData):
(IPC::ArgumentCoder<Credential>::encodePlatformData):
(IPC::ArgumentCoder<MachSendRight>::encode):
(IPC::ArgumentCoder<KeypressCommand>::encode):
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode):
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData):
- Shared/mac/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::encode):
- Shared/mac/WebGestureEvent.h:
- Shared/mac/WebHitTestResultData.mm:
(WebKit::WebHitTestResultData::platformEncode):
- UIProcess/API/APIHitTestResult.h:
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
- UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Notifications/WebNotification.cpp:
- UIProcess/Notifications/WebNotification.h:
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendMessage):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::dispatchSyncMessage):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::encode):
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.h:
- WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::KeyframeValue::encode):
(WebKit::PlatformCAAnimationRemote::Properties::encode):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::create):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::BackingStoreFlusher):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
- WebProcess/WebProcess.h:
- 3:52 PM Changeset in webkit [204664] by
-
- 6 edits1 add in trunk
Implement preferLowPowerToHighPerformance for WebGL
https://bugs.webkit.org/show_bug.cgi?id=161017
<rdar://problem/26819135>
Reviewed by Myles Maxfield.
.:
A manual test that creates contexts with and without preferLowPowerToHighPerformance
to see what is used. This has to be manual because it depends on the hardware
configuration, and we don't have a way to detect it up-front. Also, if the
code was failing, it would be the same result as on a single GPU system.
- ManualTests/webgl-preferLowPowerToHighPerformance.html: Added.
Source/WebCore:
Implement preferLowPowerToHighPerformance on macOS by
passing the correct CGL attribute when creating the
pixel format.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::get3DContextAttributes):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::setPixelFormat):
(WebCore::GraphicsContext3D::GraphicsContext3D):
LayoutTests:
Now that we implement preferLowPowerToHighPerformance we can
retain its value in the context creation attributes object.
- fast/canvas/webgl/context-creation-attributes-expected.txt:
- 3:49 PM Changeset in webkit [204663] by
-
- 3 edits1 add in trunk
Make custom Error properties (line, column, sourceURL) configurable and writable
https://bugs.webkit.org/show_bug.cgi?id=160984
<rdar://problem/27905979>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-19
Reviewed by Saam Barati.
JSTests:
- stress/native-error-properties.js: Added.
(assert):
(shouldNotThrow):
(checkEmptyErrorPropertiesDescriptors):
(checkNonEmptyErrorPropertiesDescriptors):
The spec only describes the "message" property, so
ensure it has the right descriptor attributes.
(checkErrorPropertiesWritable):
Ensure common error property names are writable.
In strict mode this would have thrown an exception
if they were readonly.
Source/JavaScriptCore:
- runtime/Error.cpp:
(JSC::addErrorInfoAndGetBytecodeOffset):
(JSC::addErrorInfo):
- 3:44 PM Changeset in webkit [204662] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
Re-sync html/dom/interfaces.html web-platform-test from upstream
https://bugs.webkit.org/show_bug.cgi?id=161012
Reviewed by Ryosuke Niwa.
Re-sync html/dom/interfaces.html web-platform-test from upstream.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- 3:42 PM Changeset in webkit [204661] by
-
- 10 edits5 deletes in trunk/Source
Remove empty files and empty namespace blocks
https://bugs.webkit.org/show_bug.cgi?id=160990
Reviewed by Alex Christensen.
- CMakeLists.txt:
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ValueProfile.cpp: Removed.
- runtime/WatchdogMac.cpp: Removed.
- runtime/WatchdogNone.cpp: Removed.
- runtime/StringIteratorPrototype.cpp:
Remove empty namespace block.
- runtime/JSDestructibleObject.h:
Drive-by add missing copyright.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/MessagePortChannel.cpp: Removed.
- page/DatabaseProvider.h:
- platform/mock/mediasource/MockTracks.cpp: Removed.
- 3:24 PM Changeset in webkit [204660] by
-
- 2 edits in trunk/Tools
Build fix for non-USE_SIM_SERVICE_CONTEXT builds
- LayoutTestRelay/LayoutTestRelay/main.m: (main):
- 3:13 PM Changeset in webkit [204659] by
-
- 7 edits in trunk/Tools
REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
https://bugs.webkit.org/show_bug.cgi?id=160985
Reviewed by Alexey Proskuryakov.
r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
must not be @memoized, because their return value depends on the value of simulator_device_type().
Fix by adding some global state in simulator.py that tracks the created devices
in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
and delete them in clean_up_test_run().
Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
that killing the Simulator apps isn't enough.
Simulator tracks the devices in a global dictionary, since state needs to persist
across different instances of IOSSimulatorPort.
Annoyingly, the "Command line:" dumping tried to access a device before we'd done
any setup. Rather than implicitly creating a device here (which the old code did),
override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
and set flag to say that device_id_for_worker_number() doesn't need to return a real
device id.
- Scripts/webkitpy/layout_tests/views/printing.py:
(print_options):
(Printer.print_config):
- Scripts/webkitpy/port/base.py:
(Port.driver_cmd_line_for_logging):
(Port.driver_cmd_line): Deleted.
- Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver.cmd_line):
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.init):
(IOSSimulatorPort.driver_cmd_line_for_logging):
(IOSSimulatorPort._create_simulators):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort.clean_up_test_run):
(IOSSimulatorPort._create_device):
(IOSSimulatorPort):
(IOSSimulatorPort._remove_device):
(IOSSimulatorPort._testing_device):
(IOSSimulatorPort.device_id_for_worker_number):
(IOSSimulatorPort._set_device_class): Deleted.
(IOSSimulatorPort.testing_device): Deleted.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_driver_cmd_line):
- Scripts/webkitpy/xcode/simulator.py:
(Device.shutdown):
(Device.delete):
(Device.reset):
(Simulator.create_device):
(Simulator.remove_device):
(Simulator.device_number):
(Simulator.device_state_description):
(Simulator.wait_until_device_is_in_state):
- 3:13 PM Changeset in webkit [204658] by
-
- 4 edits in trunk/Source/WebCore
Addressing post-review comments after r204592
https://bugs.webkit.org/show_bug.cgi?id=160895
Unreviewed.
No new tests because there is no behavior change.
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::showText):
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::drawTextAtPoint):
- platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::drawLayer):
- 3:09 PM Changeset in webkit [204657] by
-
- 2 edits1 add in branches/safari-602.1.50.1-branch/LayoutTests
Test gardening for rdar://problem/27595142.
- 3:03 PM Changeset in webkit [204656] by
-
- 4 edits in trunk/Tools
Adopt SimServiceContext in LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=161000
<rdar://problem/25765594>
Reviewed by Daniel Bates.
- LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
- LayoutTestRelay/LayoutTestRelay/main.m:
- 2:55 PM Changeset in webkit [204655] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Windows build after r204652.
Unreviewed build fix.
- dom/DOMAllInOne.cpp:
- 2:47 PM Changeset in webkit [204654] by
-
- 8 edits in trunk/Source/WebCore
Migrate from ints to unsigneds in a few more places in rendering code
https://bugs.webkit.org/show_bug.cgi?id=161006
Reviewed by Alex Christensen.
No new tests because there is no behavior change.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText):
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::drawText):
- platform/text/BidiResolver.h:
(WebCore::BidiCharacterRun::BidiCharacterRun):
(WebCore::BidiCharacterRun::start):
(WebCore::BidiCharacterRun::stop):
- rendering/BidiRun.cpp:
(WebCore::BidiRun::BidiRun):
- rendering/BidiRun.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::findFirstTrailingSpace):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
- rendering/line/BreakingContext.h:
- 2:40 PM Changeset in webkit [204653] by
-
- 4 edits in trunk/Source/WebCore
Migrate RenderText::stringView() to unsigneds
https://bugs.webkit.org/show_bug.cgi?id=161005
Reviewed by Alex Christensen.
No new tests because there is no behavior change.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
- rendering/RenderText.cpp:
(WebCore::RenderText::stringView):
- rendering/RenderText.h:
- 2:02 PM Changeset in webkit [204652] by
-
- 10 edits2 moves in trunk/Source/WebCore
Rename LifecycleCallback to CustomElementReaction
https://bugs.webkit.org/show_bug.cgi?id=160991
Reviewed by Chris Dumez.
Renamed LifecycleCallbackQueue and CustomElementLifecycleProcessingStack
to CustomElementReactionQueue and CustomElementReactionStack per the latest spec:
https://html.spec.whatwg.org/#custom-element-reactions
No new tests since this is just a rename of classes which are not exposed to the Web.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomElementsRegistryCustom.cpp:
(WebCore::getCallback): Renamed from getLifecycleCallback.
(WebCore::JSCustomElementsRegistry::define):
(WebCore::getLifecycleCallback): Deleted.
- bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadNullState):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
- bindings/scripts/test/TestObj.idl:
- dom/CustomElementReactionQueue.cpp: Moved from Source/WebCore/dom/LifecycleCallbackQueue.cpp.
(WebCore::CustomElementReactionQueueItem::CustomElementReactionQueueItem):
(WebCore::CustomElementReactionQueue::CustomElementReactionQueue):
(WebCore::CustomElementReactionQueue::~CustomElementReactionQueue):
(WebCore::CustomElementReactionQueue::enqueueElementUpgrade):
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::invokeAll):
(WebCore::CustomElementReactionStack::ensureCurrentQueue):
(WebCore::CustomElementReactionStack::processQueue):
- dom/CustomElementReactionQueue.h: Moved from Source/WebCore/dom/LifecycleCallbackQueue.h.
(WebCore::CustomElementReactionStack::CustomElementReactionStack):
(WebCore::CustomElementReactionStack::~CustomElementReactionStack):
(WebCore::CustomElementReactionStack::hasCurrentProcessingStack):
- dom/Document.cpp:
(WebCore::createFallbackHTMLElement):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
- 1:40 PM Changeset in webkit [204651] by
-
- 2 edits in trunk/LayoutTests
Rebaseline imported/w3c/web-platform-tests/html/semantics/interfaces.html for ios-simulator after r204647.
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
- 1:33 PM Changeset in webkit [204650] by
-
- 2 edits in trunk/LayoutTests
Marking editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html as flaky on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=160782
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:15 PM Changeset in webkit [204649] by
-
- 2 edits in trunk/Tools
Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
Reviewed by Kocsen Chung.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
- 12:44 PM Changeset in webkit [204648] by
-
- 9 edits7 deletes in trunk
Attr.prefix / Element.prefix attribute should be readonly
https://bugs.webkit.org/show_bug.cgi?id=160998
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Attr.prefix / Element.prefix attribute should be readonly:
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
- dom/Attr.idl:
- dom/Element.idl:
LayoutTests:
Update existing tests to reflect behavior change and drop a few
outdated tests.
- fast/dom/Element/prefix-setter-exception-expected.txt: Removed.
- fast/dom/Element/prefix-setter-exception.html: Removed.
- fast/dom/Element/setAttributeNode-case-insensitivity.html:
- fast/dom/bad-href-attribute-expected.txt: Removed.
- fast/dom/bad-href-attribute.html: Removed.
- fast/dom/node-prefix-setter-namespace-exception-expected.txt: Removed.
- fast/dom/node-prefix-setter-namespace-exception.html: Removed.
- fast/dom/script-tests/node-prefix-setter-namespace-exception.js: Removed.
- svg/custom/xlink-prefix-generation-in-attributes-expected.txt:
- svg/custom/xlink-prefix-generation-in-attributes.html:
- 12:33 PM Changeset in webkit [204647] by
-
- 4 edits in trunk
<command> should be an HTMLUnknownElement and <basefont> should be an HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=161004
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
Rebaseline a W3C test now that more checks are passing.
- web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
<command> should be an HTMLUnknownElement and <basefont> should be an HTMLElement as per:
<basefont> is already an HTMLElement in Firefox and Chrome. <command> is an
HTMLUnknownElement in Firefox but an HTMLElement in Chrome.
No new tests, rebaselined existing test.
- html/HTMLTagNames.in:
- 12:33 PM Changeset in webkit [204646] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
Web Inspector: Make an icon for Code Coverage Profiler
https://bugs.webkit.org/show_bug.cgi?id=160872
<rdar://problem/27855650>
Reviewed by Joseph Pecoraro.
Add a "C" icon, similar to the existing "T" (Type Profiler) icon.
"C" can stand for Code Coverage or Control Flow.
- UserInterface/Images/NavigationItemCodeCoverage.svg: Added.
- 12:23 PM Changeset in webkit [204645] by
-
- 5 edits in trunk
AX: iOS, Wrong axLabel on static text if heading has multiple children
https://bugs.webkit.org/show_bug.cgi?id=160981
Reviewed by Chris Fleizach.
Source/WebCore:
Headings are using textUnderElement to compute the accessibilityLabel on iOS, so normally it's
the concatenation of all the children's accessibilityLabel. Therefore, we shouldn't use accessibilityLabel
to check for user defined text on headings. Instead, baseAccessibilityDescription will return the
alternate text we want.
Changes are covered in the modified test.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
LayoutTests:
- accessibility/ios-simulator/heading-with-aria-label-expected.txt:
- accessibility/ios-simulator/heading-with-aria-label.html:
- 12:12 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 12:07 PM Changeset in webkit [204644] by
-
- 7 edits5 adds in trunk/LayoutTests
[GTK] Gardening: Layout tests expectations updates and test rebaselines.
Unreviewed.
LayoutTests/imported/w3c:
The test below contained wrong results (FAIL strings instead of PASS).
There are many more. I'm only updating this 3 ones because they are passing
on the GTK+ port, but the tooling gives Failures due to the wrong expectation
files. Reported https://bugs.webkit.org/show_bug.cgi?id=161003 regarding this.
- web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
LayoutTests:
- TestExpectations: Mark as failing 3 tests from imported/w3c/web-platform-tests/XMLHttpRequest that had wrong results.
- platform/gtk/TestExpectations: Update list for imported/w3c/web-platform-tests/XMLHttpRequest and merge repeated results.
- platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added. Rebaseline after r201449 (updated version of libicu).
- platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added. Rebaseline after r201449 (updated version of libicu).
- platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added. Rebaseline after r201449 (updated version of libicu).
- platform/gtk/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added. Rebaseline after r201449 (updated version of libicu).
- 11:58 AM Changeset in webkit [204643] by
-
- 2 edits in trunk/Tools
Partial revert of r203811 - this key is not needed.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
- 11:41 AM Changeset in webkit [204642] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Console log counter on the dashboard should be better at displaying large numbers
https://bugs.webkit.org/show_bug.cgi?id=160054
Patch by Devin Rousso <Devin Rousso> on 2016-08-19
Reviewed by Matt Baker.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Utilities.js:
(Number.abbreviate):
Add logic for formatting a number as "#K", "#M", and "#B" when it is very large.
- UserInterface/Views/DefaultDashboardView.js:
(WebInspector.DefaultDashboardView.prototype._updateDisplay):
(WebInspector.DefaultDashboardView.prototype._formatPossibleLargeNumber): Deleted.
(WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
- 11:30 AM Changeset in webkit [204641] by
-
- 11 edits2 adds3 deletes in trunk
Resource Timing: Make PerformanceEntryList a sequence as per spec
https://bugs.webkit.org/show_bug.cgi?id=160963
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-19
Reviewed by Alex Christensen.
Source/WebCore:
Change PerformanceEntryList to be a sequence of PerformanceEntry instead of an object.
Test: http/tests/performance/performance-resource-timing-entries-iterable.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- PlatformGTK.cmake:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorGObject.pm:
Remove references to {JS,}PerformanceEntryList.{cpp,h,idl}.
- page/Performance.cpp:
(WebCore::Performance::getEntries):
(WebCore::Performance::getEntriesByType):
(WebCore::Performance::getEntriesByName):
- page/Performance.h:
Methods now operate on a Vector of PerformanceEntry.
- page/Performance.idl:
Typedef PerformanceEntryList as a sequence of PerformanceEntry.
- page/PerformanceEntryList.cpp: Removed.
(WebCore::PerformanceEntryList::PerformanceEntryList): Deleted.
(WebCore::PerformanceEntryList::~PerformanceEntryList): Deleted.
(WebCore::PerformanceEntryList::length): Deleted.
(WebCore::PerformanceEntryList::item): Deleted.
(WebCore::PerformanceEntryList::append): Deleted.
(WebCore::PerformanceEntryList::appendAll): Deleted.
(WebCore::PerformanceEntryList::sort): Deleted.
- page/PerformanceEntryList.h: Removed.
(WebCore::PerformanceEntryList::create): Deleted.
- page/PerformanceEntryList.idl: Removed.
LayoutTests:
Testing that PerformanceEntryList (window.performance.getEntries()) is iterable.
- http/tests/performance/performance-resource-timing-entries-iterable-expected.txt: Added.
- http/tests/performance/performance-resource-timing-entries-iterable.html: Added.
- 11:24 AM Changeset in webkit [204640] by
-
- 3 edits in trunk/Tools
Another attempt to fix the iOS 9.3 build
Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 11:24 AM Changeset in webkit [204639] by
-
- 2 edits1 add in branches/safari-602.1.50.0-branch/LayoutTests
Test gardening for rdar://problem/27595142.
- 11:21 AM Changeset in webkit [204638] by
-
- 3 edits in trunk/Source/WebCore
[Mac] fix PiP context menu typos
https://bugs.webkit.org/show_bug.cgi?id=160999
<rdar://problem/27885070>
Reviewed by Jer Noble.
- English.lproj/Localizable.strings: "Picture-in-Picture" -> "Picture in Picture".
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagEnterVideoEnhancedFullscreen): Ditto.
(WebCore::contextMenuItemTagExitVideoEnhancedFullscreen): Ditto.
- 11:10 AM Changeset in webkit [204637] by
-
- 33 edits in trunk/Source
Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
https://bugs.webkit.org/show_bug.cgi?id=160923
Reviewed by Tim Horton.
Source/WebCore:
didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones)
dispatchDidLayout(LayoutMilestones) -> dispatchDidReachLayoutMilestone(LayoutMilestones)
- dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didReachLayoutMilestone):
(WebCore::FrameLoader::didLayout): Deleted.
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- page/FrameView.cpp:
(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):
(WebCore::FrameView::firePaintRelatedMilestonesIfNeeded):
- page/LayoutMilestones.h: Formatting
- page/Page.cpp:
(WebCore::Page::addRelevantRepaintedObject):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
(WebFrameLoaderClient::dispatchDidLayout): Deleted.
Source/WebKit/win:
didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones)
dispatchDidLayout(LayoutMilestones) -> dispatchDidReachLayoutMilestone(LayoutMilestones)
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
(WebFrameLoaderClient::dispatchDidLayout): Deleted.
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones)
dispatchDidLayout(LayoutMilestones) -> dispatchDidReachLayoutMilestone(LayoutMilestones)
Avoided changing functions that are exposed as API/SPI.
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::didReachLayoutMilestone):
(API::LoaderClient::didLayout): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didLayoutForCustomContentProvider):
(WebKit::WebPageProxy::didReachLayoutMilestone):
(WebKit::WebPageProxy::didLayout): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didReachLayoutMilestone):
(setUpPageLoaderClient):
(didLayout): Deleted.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didReachLayoutMilestone):
(WebKit::InjectedBundlePageLoaderClient::didLayout): Deleted.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
(WebKit::WebFrameLoaderClient::dispatchDidLayout): Deleted.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::dispatchDidReachLayoutMilestone):
(WebKit::DrawingArea::dispatchDidLayout): Deleted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dispatchDidReachLayoutMilestone):
(WebKit::WebPage::dispatchDidLayout): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidReachLayoutMilestone):
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidLayout): Deleted.
- 10:34 AM Changeset in webkit [204636] by
-
- 1 copy in tags/Safari-601.1.46.146
New tag.
- 10:10 AM Changeset in webkit [204635] by
-
- 2 edits in trunk
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=160994
Reviewed by Anders Carlsson.
Ignore warning when function declared with declspec(noreturn) has non void return type.
- Source/cmake/OptionsWin.cmake:
- 10:07 AM Changeset in webkit [204634] by
-
- 6 edits in trunk/WebKitLibraries
Attempt to fix the iOS 9.3 build
Reorder the keys in the text-based stubs to make linker happy.
- WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework/AppSupport.tbd:
- WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework/AssertionServices.tbd:
- WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework/CorePDF.tbd:
- WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework/GraphicsServices.tbd:
- WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework/IOSurface.tbd:
- 9:41 AM Changeset in webkit [204633] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=160995
Avoid setting unknown compile option on source file.
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- 9:08 AM Changeset in webkit [204632] by
-
- 2 edits in trunk/LayoutTests
Unskip tests that now pass on ios-simulator.
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 8:46 AM Changeset in webkit [204631] by
-
- 3 edits in trunk/Source/WebCore
DumpRenderTree crashed in com.apple.WebCore: WebCore::DOMWindow::resetDOMWindowProperties + 607
https://bugs.webkit.org/show_bug.cgi?id=160983
<rdar://problem/26768524>
Reviewed by Brent Fulgham.
Update DOMWindow::frameDestroyed() to ref the window object as the crash
traces seem to indicate it can get destroyed during the execution of this
method. Also update the code in the ~Frame destructor to not iterate over
the list of FrameDestructionObservers because observers remove themselves
from the list when they get destroyed.
No new tests, do not know how to reproduce.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::frameDestroyed):
- page/Frame.cpp:
(WebCore::Frame::~Frame):
- 8:36 AM Changeset in webkit [204630] by
-
- 7 edits in trunk
WebKit should unset event propagation flags after dispatch
https://bugs.webkit.org/show_bug.cgi?id=160853
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/events/Event-dispatch-multiple-stopPropagation-expected.txt:
- web-platform-tests/dom/events/Event-initEvent-expected.txt:
- web-platform-tests/dom/events/Event-propagation-expected.txt:
Source/WebCore:
WebKit should unset event propagation flags after dispatch to reflect
the latest DOM specification:
No new tests, rebaselined existing tests.
- dom/Event.h:
(WebCore::Event::resetPropagationFlags):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- dom/EventTarget.cpp:
(WebCore::EventTarget::dispatchEvent):
- 12:26 AM Changeset in webkit [204629] by
-
- 2 edits in trunk/Tools
Remove Yosemite Leaks bot from config.json
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/config.json:
Aug 18, 2016:
- 10:42 PM Changeset in webkit [204628] by
-
- 3 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore
Merge r204572. rdar://problem/27889416
- 8:07 PM Changeset in webkit [204627] by
-
- 7 edits in trunk/Source
Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
https://bugs.webkit.org/show_bug.cgi?id=160979
Rubber-stamped by Simon Fraser.
Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
an Apple-internal build.
Source/WebCore:
- Configurations/Base.xcconfig: Define WK_TARGET_IOS_VERSION_MAJOR.
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
- 7:53 PM Changeset in webkit [204626] by
-
- 2 edits in trunk/Source/WebCore
Re-landing:
Support WebIDL unions (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=160769
Reviewed by Chris Dumez.
This is the first part of an effort to add support for union types
in our code generators. This change:
- Adds a domType struct to hold the parsed type information. For now, we only use it temporarily while parsing, and don't expose it to the code generators, but that will change in a later patch.
- Remove support for scoped identifiers for types. They are not supported by WebIDL.
- Make debugging the parser easier by providing backtraces when asserting.
There should be no observable changes.
- bindings/scripts/IDLParser.pm:
- 7:44 PM Changeset in webkit [204625] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, Fix CMake build after r204614
- PlatformMac.cmake:
- 7:40 PM Changeset in webkit [204624] by
-
- 19 edits in trunk
Move prefix / namespaceURI / localName attributes from Node to Attr / Element
https://bugs.webkit.org/show_bug.cgi?id=160988
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C test now that more checks are passing.
- web-platform-tests/dom/historical-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Move prefix / namespaceURI / localName attributes from Node to Attr / Element
as per the latest DOM specification:
Firefox and Chrome match the specification.
No new tests, rebaselined existing tests.
- dom/Attr.h:
- dom/Attr.idl:
- dom/Element.h:
- dom/Element.idl:
- dom/Node.idl:
LayoutTests:
Update existing layout tests to reflect behavior change.
- fast/dom/Node/initial-values-expected.txt:
- fast/dom/Node/script-tests/initial-values.js:
- http/tests/misc/createElementNamespace1-expected.txt:
- http/tests/misc/createElementNamespace1.xml:
- http/tests/misc/createElementNamespace2-expected.txt:
- http/tests/misc/createElementNamespace2.xhtml:
- http/tests/misc/createElementNamespace3-expected.txt:
- http/tests/misc/createElementNamespace3.html:
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 7:37 PM Changeset in webkit [204623] by
-
- 7 edits in trunk/LayoutTests/imported/w3c
Re-sync DOM web platform tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=160980
Reviewed by Ryosuke Niwa.
Re-sync DOM web platform tests from upstream.
- web-platform-tests/dom/events/Event-initEvent-expected.txt:
- web-platform-tests/dom/events/Event-initEvent.html:
- web-platform-tests/dom/events/Event-propagation-expected.txt:
- web-platform-tests/dom/events/Event-propagation.html:
- web-platform-tests/dom/nodes/Node-properties.html:
- 6:41 PM Changeset in webkit [204622] by
-
- 1 copy in tags/Safari-602.2.2
New tag.
- 6:07 PM Changeset in webkit [204621] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Network Processes & Database processes do not exit promptly
https://bugs.webkit.org/show_bug.cgi?id=160978
<rdar://problem/27914081>
Reviewed by Anders Carlsson.
Network Processes & Database processes do not exit promptly. They hang
for 10 seconds until they log the following message:
com.apple.WebKit.Networking: (WebKit) #WK: Exiting process early due to unacknowledged closed-connection
Then forcefully call exit(0).
To address the issue, we now call ChildProcess::stopRunLoop() instead
of RunLoop::current().stop(). stopRunLoop() works as expected on iOS
after r202723.
There is no impact on Mac because stopRunLoop() calls
RunLoop::current().stop().
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):
- 6:01 PM Changeset in webkit [204620] by
-
- 3 edits in trunk/Source/WebCore
Binding NULL pointer to reference in WebCore::RenderObject
https://bugs.webkit.org/show_bug.cgi?id=160830
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-18
Reviewed by Myles C. Maxfield.
No new tests needed, existing functionality not changed.
Fixes a dereferenced NULL pointer bound to a reference through a minor re-factor.
- rendering/InlineIterator.h:
(WebCore::InlineIterator::clear): Explicit clear occurs, instead of a call to moveTo.
(WebCore::InlineIterator::moveToStartOf): Swapped pointer for reference.
(WebCore::InlineIterator::moveTo): Swapped pointer for reference.
(WebCore::InlineIterator::increment): Explicitly call clear for clarity.
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::commitLineBreakClear): Commit a line break and clear the iterator.
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth): Swapped pointer for reference.
(WebCore::BreakingContext::InlineIteratorHistory::moveTo): Swapped pointer for reference.
(WebCore::BreakingContext::increment): Explicitly call clear for clarity.
(WebCore::BreakingContext::handleBR): Swapped pointer for passed reference.
(WebCore::BreakingContext::handleReplaced): Explicitly call clear for clarity.
(WebCore::tryHyphenating): Swapped pointer for passed reference.
(WebCore::BreakingContext::handleText): Replaced all render object passing with references. Note that the caller explicitly checks if m_current.renderer() exists before calling this function.
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded): Explicitly call clear for clarity.
(WebCore::BreakingContext::handleEndOfLine): Explicitly call clear for clarity.
- 5:55 PM Changeset in webkit [204619] by
-
- 3 edits in trunk/Source/WebCore
Windows build fix after r204611. Use the fully qualified name to avoid the ambiguity in VC++.
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::invokeCallback):
- bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
- 5:50 PM Changeset in webkit [204618] by
-
- 7 edits2 adds in trunk
Support passing preferLowPowerToHighPerformance and failIfMajorPerformanceCaveat
https://bugs.webkit.org/show_bug.cgi?id=160982
<rdar://problem/27915946>
Reviewed by Simon Fraser.
Source/WebCore:
Update WebGLContextAttributes to be compliant with the specification,
by adding preferLowPowerToHighPerformance and failIfMajorPerformanceCaveat.
They are not implemented yet, so asking the created context what
values it used should give the default.
Test: fast/canvas/webgl/context-creation-attributes.html
- html/canvas/WebGLContextAttributes.cpp:
(WebCore::WebGLContextAttributes::preferLowPowerToHighPerformance):
(WebCore::WebGLContextAttributes::setPreferLowPowerToHighPerformance):
(WebCore::WebGLContextAttributes::failIfMajorPerformanceCaveat):
(WebCore::WebGLContextAttributes::setFailIfMajorPerformanceCaveat):
- html/canvas/WebGLContextAttributes.h:
- html/canvas/WebGLContextAttributes.idl:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::create): Deleted.
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::Attributes::Attributes): Deleted.
LayoutTests:
Very simple test that creates some WebGL contexts with various
creation attributes and outputs the result.
- fast/canvas/webgl/context-creation-attributes-expected.txt: Added.
- fast/canvas/webgl/context-creation-attributes.html: Added.
- 5:12 PM Changeset in webkit [204617] by
-
- 13 edits in trunk/Source
Move an NPAPI-only function from WebCore to WebKit
https://bugs.webkit.org/show_bug.cgi?id=160967
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createScriptObjectForPluginElement): Deleted.
- bindings/js/ScriptController.h:
- bridge/NP_jsobject.h:
Source/WebKit/mac:
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:value:]):
(-[WebNetscapePluginView _destroyPlugin]):
Source/WebKit/win:
- Plugins/PluginView.cpp:
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::getValue):
- Plugins/PluginView.h:
- 4:21 PM Changeset in webkit [204616] by
-
- 1 copy in tags/Safari-602.1.50.0.5
New tag.
- 4:15 PM Changeset in webkit [204615] by
-
- 2 edits in trunk/Source/WebCore
Building test fix after r204611.
- bindings/scripts/test/TestObj.idl:
- 4:11 PM Changeset in webkit [204614] by
-
- 5 edits3 adds in trunk
[Cocoa] API::Number needs to be wrapped by an NSNumber
https://bugs.webkit.org/show_bug.cgi?id=160977
<rdar://problem/27877735>
Reviewed by Anders Carlsson.
Source/WebKit2:
We introduce a single WKNSNumber class to wrap three distinct API::Number instantiations
corresponding to the Boolean, UInt64 and Double types.
Test: TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Create a WKNSNumber to contain any of the number types, and set
its _type ivar accordingly.
- Shared/Cocoa/WKNSNumber.h: Added.
(WebKit::wrapper):
- Shared/Cocoa/WKNSNumber.mm: Added.
(-[WKNSNumber dealloc]): Call the appropriate destructor.
(-[WKNSNumber objCType]): Implement this NSValue primitive method.
(-[WKNSNumber getValue:]): Ditto.
(-[WKNSNumber boolValue]): Implement this NSNumber method corresponding to one of our
possible types.
(-[WKNSNumber doubleValue]): Ditto.
(-[WKNSNumber unsignedLongLongValue]): Ditto.
(-[WKNSNumber copyWithZone:]): Implement this NSCopying method by retaining self.
(-[WKNSNumber _apiObject]): Implement this WKObject method by returning the appropriate
API object.
- WebKit2.xcodeproj/project.pbxproj: Added references to new files.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
(TestWebKitAPI::TEST):
- 4:03 PM Changeset in webkit [204613] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, nit fix after r204605 reported by Darin.
- platform/text/TextCodecICU.cpp:
- 3:55 PM Changeset in webkit [204612] by
-
- 3 edits1 add in trunk
ScopedArguments is using the wrong owner object for a write barrier.
https://bugs.webkit.org/show_bug.cgi?id=160976
<rdar://problem/27328506>
Reviewed by Keith Miller.
JSTests:
- stress/scoped-arguments-write-barrier-should-be-on-scope-object.js: Added.
Source/JavaScriptCore:
- runtime/ScopedArguments.h:
(JSC::ScopedArguments::setIndexQuickly):
- 3:19 PM Changeset in webkit [204611] by
-
- 13 edits4 adds in trunk
Add basic support for connected and disconnected callbacks
https://bugs.webkit.org/show_bug.cgi?id=160950
Reviewed by Chris Dumez.
Source/WebCore:
Added the basic support for custom elements' connectedCallback and disconnectedCallback. These callbacks
are enqueued by inserting and removing a node as spec'ed by https://dom.spec.whatwg.org/#concept-node-insert
and https://dom.spec.whatwg.org/#concept-node-remove
For now, we only support callbacks on appendChild and removeChild to limit the amount of code changes and
tests that need to be included in this patch.
This patch also renames InvokesCustomElementLifecycleCallbacks IDL attribute to CEReactions to match
the latest specification: https://html.spec.whatwg.org/multipage/scripting.html#cereactions
Tests: fast/custom-elements/connected-callbacks.html
fast/custom-elements/disconnected-callbacks.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::invokeCallback): Extracted from invokeAttributeChangedCallback.
(WebCore::JSCustomElementInterface::setConnectedCallback): Added.
(WebCore::JSCustomElementInterface::invokeConnectedCallback): Added.
(WebCore::JSCustomElementInterface::setDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::invokeDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::setAttributeChangedCallback):
(WebCore::JSCustomElementInterface::invokeAttributeChangedCallback): Renamed from attributeChanged.
- bindings/js/JSCustomElementInterface.h: Added m_connectedCallback and m_disconnectedCallback as instance
variables. Also removed the superfluous mutable qualifier from m_constructor m_attributeChangedCallback.
- bindings/js/JSCustomElementsRegistryCustom.cpp:
(WebCore::JSCustomElementsRegistry::define): Store connectedCallback and disconnectedCallback.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- dom/CustomElementsRegistry.idl:
- dom/Element.cpp:
(WebCore::Element::insertedInto): Call enqueueConnectedCallbackIfNeeded.
(WebCore::Element::removedFrom): Call enqueueDisconnectedCallbackIfNeeded.
- dom/Element.idl:
- dom/LifecycleCallbackQueue.cpp:
(WebCore::LifecycleQueueItem::invoke): Added calls to invokeConnectedCallback and invokeDisconnectedCallback.
(WebCore::findInterfaceForCustomElement): Extracted from enqueueAttributeChangedCallbackIfNeeded.
(WebCore::LifecycleCallbackQueue::enqueueConnectedCallbackIfNeeded): Added.
(WebCore::LifecycleCallbackQueue::enqueueDisconnectedCallbackIfNeeded): Added.
(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallbackIfNeeded):
(WebCore::CustomElementLifecycleProcessingStack::ensureCurrentQueue):
- dom/LifecycleCallbackQueue.h:
- dom/Node.idl:
LayoutTests:
Added W3C style testharness.js tests for connectedCallback and disconnectedCallback.
Four test cases are failing due to a bug in window-less document's custom element registry,
which will be addressed in a future patch.
- fast/custom-elements/connected-callbacks-expected.txt: Added.
- fast/custom-elements/connected-callbacks.html: Added.
- fast/custom-elements/disconnected-callbacks-expected.txt: Added.
- fast/custom-elements/disconnected-callbacks.html: Added.
- 2:19 PM Changeset in webkit [204610] by
-
- 4 edits in trunk/Source/WebCore
Update the accessibility titles for list insertion
https://bugs.webkit.org/show_bug.cgi?id=160972
-and corresponding-
rdar://problem/27750446
Reviewed by Chris Fleizach.
Update accessibility titles based on feedback.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
(WebCore::insertListTypeNone):
(WebCore::insertListTypeBulleted):
(WebCore::insertListTypeBulletedAccessibilityTitle):
(WebCore::insertListTypeNumbered):
(WebCore::insertListTypeNumberedAccessibilityTitle):
(WebCore::insertListTypeNoneAccessibilityTitle): Deleted.
- platform/LocalizedStrings.h:
- 2:11 PM Changeset in webkit [204609] by
-
- 3 edits in branches/safari-602.1.50.0-branch/Source/JavaScriptCore
Merge r204572. rdar://problem/27889416
- 1:53 PM Changeset in webkit [204608] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 1:25 PM Changeset in webkit [204607] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add LLINT probe() macro for X86_64.
https://bugs.webkit.org/show_bug.cgi?id=160968
Reviewed by Geoffrey Garen.
- llint/LowLevelInterpreter.asm:
- 12:55 PM Changeset in webkit [204606] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
https://bugs.webkit.org/show_bug.cgi?id=160964
Reviewed by Anders Carlsson.
Followed the guidelines for SPI naming.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _isCookieStoragePartitioningEnabled]): Renamed from -cookieStoragePartitioningEnabled.
(-[WKProcessPool _setCookieStoragePartitioningEnabled:]): Renamed from -setCookieStoragePartitioningEnabled:.
(-[WKProcessPool cookieStoragePartitioningEnabled]): Renamed to -_isCookieStoragePartitioningEnabled.
(-[WKProcessPool setCookieStoragePartitioningEnabled:]): Renamed to -_setCookieStoragePartitioningEnabled:.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- 12:53 PM Changeset in webkit [204605] by
-
- 18 edits in trunk
Align our encoding labels with the encoding specification
https://bugs.webkit.org/show_bug.cgi?id=160931
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that we are passing a lot more checks. For reference,
Firefox 48 passes 624 out of 654, and Chrome 52 passes 651 out of 654.
Before this change, WebKit was only passing 501 out of 654 and is now passing
- The only checks we're failing is due to "Big5-HKSCS" not being an alias
to "Big5".
- web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
Source/WebCore:
Align our encoding labels with the encoding specification:
This also aligns with Firefox and Chrome.
No new tests, rebaselined existing test.
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerEncodingNames):
- platform/text/TextCodecLatin1.cpp:
(WebCore::TextCodecLatin1::registerEncodingNames):
(WebCore::newStreamingTextDecoderWindowsLatin1): Deleted.
(WebCore::TextCodecLatin1::registerCodecs): Deleted.
- platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::registerEncodingNames):
LayoutTests:
Update / rebaseline existing tests to reflect the code change.
The new baselines match Chrome and Firefox.
- fast/encoding/bracket-in-tag-expected.txt:
- fast/encoding/charset-invalid-expected.txt:
- fast/encoding/charset-replacement-expected.txt:
- fast/encoding/misplaced-xml-declaration-expected.txt:
- fast/encoding/pseudo-xml-expected.txt:
- http/tests/misc/char-encoding-bocu-1-blacklisted-expected.txt:
- http/tests/misc/char-encoding-bocu-1-blacklisted.html:
- http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt:
- http/tests/misc/char-encoding-scsu-blacklisted-expected.txt:
- http/tests/misc/char-encoding-scsu-blacklisted.html:
- http/tests/misc/frame-default-enc-different-domain-expected.txt:
- 12:04 PM Changeset in webkit [204604] by
-
- 2 edits in trunk/Source/WebKit2
Generated messages headers should use #pragma once
https://bugs.webkit.org/show_bug.cgi?id=160965
Reviewed by Anders Carlsson.
- Scripts/webkit/messages.py:
(generate_messages_header): Used #pragma once instead of a header guard.
- 11:59 AM Changeset in webkit [204603] by
-
- 15 edits in trunk/Source
[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
https://bugs.webkit.org/show_bug.cgi?id=160964
Reviewed by Brent Fulgham.
Source/WebCore:
- page/Settings.cpp:
(WebCore::Settings::setCookieStoragePartitioningEnabled): Deleted.
- page/Settings.h:
(WebCore::Settings::cookieStoragePartitioningEnabled): Deleted.
- platform/network/NetworkStorageSession.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp: Defined cookieStoragePartitioningEnabled.
(WebCore::NetworkStorageSession::setCookieStoragePartitioningEnabled): Set cookieStoragePartitioningEnabled.
(WebCore::cookieStoragePartition): Used cookieStoragePartitioningEnabled instead of Settings::cookieStoragePartitioningEnabled().
Source/WebKit2:
- NetworkProcess/NetworkProcess.h: Declared setCookieStoragePartitioningEnabled().
- NetworkProcess/NetworkProcess.messages.in: Added message SetCookieStoragePartitioningEnabled.
- NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode): Encoded cookieStoragePartitioningEnabled.
(WebKit::NetworkProcessCreationParameters::decode): Decoded cookieStoragePartitioningEnabled.
- NetworkProcess/NetworkProcessCreationParameters.h: Declared cookieStoragePartitioningEnabled.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Called NetworkStorageSession::setCookieStoragePartitioningEnabled() given the cookieStoragePartitioningEnabled parameter.
(WebKit::NetworkProcess::setCookieStoragePartitioningEnabled):
Called NetworkStorageSession::setCookieStoragePartitioningEnabled().
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool cookieStoragePartitioningEnabled]): Returned WebProcessPool::cookieStoragePartitioningEnabled().
(-[WKProcessPool setCookieStoragePartitioningEnabled:]): Called WebProcessPool::setCookieStoragePartitioningEnabled().
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Declared cookieStoragePartitioningEnabled as a property.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
Set the cookieStoragePartitioningEnabled parameter from m_cookieStoragePartitioningEnabled.
(WebKit::WebProcessPool::setCookieStoragePartitioningEnabled):
Set m_cookieStoragePartitioningEnabled and sent the NetworkProcess::SetCookieStoragePartitioningEnabled message.
- UIProcess/WebProcessPool.h: Declared cookieStoragePartitioningEnabled.
- 11:06 AM Changeset in webkit [204602] by
-
- 2 edits in trunk/LayoutTests
Land test expectations for rdar://problem/27723718.
- platform/mac-wk1/TestExpectations:
- 11:05 AM Changeset in webkit [204601] by
-
- 13 edits2 adds in trunk
AX: Audio Description tracks are not labeled correctly, causing user confusion
https://bugs.webkit.org/show_bug.cgi?id=160652
<rdar://problem/27742208>
Reviewed by Antoine Quint.
- http/tests/media/hls/hls-accessiblity-describes-video-menu-expected.txt: Added.
- http/tests/media/hls/hls-accessiblity-describes-video-menu.html: Added.
- media/trackmenu-test.js:
(clickCCButton): Fail immediately if "video" is null or not a media element. Make failure
logging more descriptive.
- platform/gtk/TestExpectations: Skip new test.
- platform/ios-simulator/media/video-controls-captions-trackmenu-expected.txt: Updated for
clickCCButton error message change.
- platform/ios-simulator/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Ditto.
- platform/ios-simulator/media/video-controls-captions-trackmenu-localized-expected.txt: Ditto.
- platform/ios-simulator/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
- 10:54 AM Changeset in webkit [204600] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unused SlotVisitor::append() variant.
https://bugs.webkit.org/show_bug.cgi?id=160961
Reviewed by Saam Barati.
- heap/SlotVisitor.h:
- jit/JITWriteBarrier.h:
(JSC::JITWriteBarrier::get):
(JSC::SlotVisitor::append): Deleted.
- 10:26 AM Changeset in webkit [204599] by
-
- 3 edits in trunk/Source/WebCore
Fix WinCairo build after r204592.
- PlatformAppleWin.cmake:
- PlatformWin.cmake:
- 10:23 AM Changeset in webkit [204598] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 10:17 AM Changeset in webkit [204597] by
-
- 5 edits in trunk/Source/JavaScriptCore
Make @Array(size) a bytecode intrinsic
https://bugs.webkit.org/show_bug.cgi?id=160867
Reviewed by Mark Lam.
There were a few places in the code where we were emitting
@Array(size)
ornew @Array(size). Since we have a bytecode operation that already
represents this, called new_array_with_size, it's faster to just make a
bytecode intrinsic for the this operation. This patch does that and
the intrinsic is called@newArrayWithSize. This might be around a
1% speedup on ES6 sample bench, but it's within the noise. This is just
a good bytecode operation to have because it's common enough to
create arrays and it's good to make that fast in all tiers.
- builtins/ArrayConstructor.js:
(of):
(from):
- builtins/ArrayPrototype.js:
(filter):
(map):
(sort.stringSort):
(sort):
(concatSlowPath):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isObject):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_newArrayWithSize):
- 9:10 AM Changeset in webkit [204596] by
-
- 3 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html after r204594.
Unreviewed test gardening.
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 9:06 AM Changeset in webkit [204595] by
-
- 10 edits in trunk/Source/WebCore
[MediaStream] cleanup MediaConstraints
https://bugs.webkit.org/show_bug.cgi?id=160957
Reviewed by Antoine Quint.
No new tests, no behavior change.
- Modules/mediastream/CaptureDeviceManager.cpp:
(CaptureDeviceManager::sessionSupportsConstraint): Use MediaConstraint::type
- bindings/js/JSMediaDevicesCustom.cpp:
(WebCore::initializeStringConstraintWithList): MediaConstraint::create now takes the constraint
type, not name.
(WebCore::createStringConstraint): Ditto.
(WebCore::createBooleanConstraint): Ditto.
(WebCore::createDoubleConstraint): Ditto.
(WebCore::createIntConstraint): Ditto.
(WebCore::parseMediaTrackConstraintSetForKey): Pass constraint type.
- platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaConstraint::create): MediaConstraint constructor now takes the constraint.
(WebCore::IntConstraint::create): Take type, not name.
(WebCore::IntConstraint::setMin): Ditto.
(WebCore::DoubleConstraint::create): Ditto.
(WebCore::BooleanConstraint::create): Ditto.
(WebCore::StringConstraint::create): Ditto.
- platform/mediastream/MediaConstraints.h:
- platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:
(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Make static.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Ditto.
- platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::sessionSupportsConstraint): Use MediaConstraint::type
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::applyConstraints): nameForConstraint is a static method. Add
error logging.
- platform/mock/MediaConstraintsMock.cpp:
(WebCore::isSatisfiable): Use constraint type.
- 6:58 AM Changeset in webkit [204594] by
-
- 28 edits10 copies6 adds in trunk
[web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
https://bugs.webkit.org/show_bug.cgi?id=156096
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-08-18
Reviewed by Dean Jackson.
Adds:
Source/JavaScriptCore:
- Animatable interface and implementation of getAnimations in Element.
- Interface and implementation for Document getAnimations method.
- AnimationEffect interface and class stub.
- KeyframeEffect interface and constructor implementation.
- 'Animation' interface, constructor and query methods for effect and timeline.
- Remove runtime condition on Web animation interfaces (compile time flag is specified).
- runtime/CommonIdentifiers.h:
Source/WebCore:
- Animatable interface and implementation of getAnimations in Element.
- Interface and implementation for Document getAnimations method.
- AnimationEffect interface and class stub.
- KeyframeEffect interface and constructor implementation.
- 'Animation' interface, constructor and query methods for effect and timeline.
- Remove runtime condition on Web animation interfaces (compile time flag is specified).
Test: webanimations/Document.html
- CMakeLists.txt:
- DerivedSources.make:
- PlatformGTK.cmake:
- WebCore.xcodeproj/project.pbxproj:
- animation/Animatable.idl: Copied from Source/WebCore/animation/AnimationTimeline.idl.
- animation/AnimationEffect.cpp: Copied from Source/WebCore/animation/AnimationTimeline.cpp.
(WebCore::AnimationEffect::AnimationEffect):
(WebCore::AnimationEffect::~AnimationEffect):
(WebCore::AnimationEffect::setAnimation):
(WebCore::AnimationEffect::isCurrent):
(WebCore::AnimationEffect::isInEffect):
- animation/AnimationEffect.h: Copied from Source/WebCore/animation/DocumentTimeline.cpp.
- animation/AnimationEffect.idl: Copied from Source/WebCore/animation/DocumentAnimation.idl.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::destroy):
(WebCore::AnimationTimeline::attachAnimation):
(WebCore::AnimationTimeline::detachAnimation):
- animation/AnimationTimeline.h:
- animation/AnimationTimeline.idl:
- animation/DocumentAnimation.cpp:
(WebCore::DocumentAnimation::timeline):
(WebCore::DocumentAnimation::getAnimations):
(WebCore::DocumentAnimation::addAnimation):
(WebCore::DocumentAnimation::removeAnimation):
- animation/DocumentAnimation.h:
(WebCore::DocumentAnimation::getAnimations):
- animation/DocumentAnimation.idl:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::create):
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::attach):
(WebCore::DocumentTimeline::detach):
- animation/DocumentTimeline.h:
- animation/DocumentTimeline.idl:
- animation/KeyframeEffect.cpp: Copied from Source/WebCore/animation/DocumentTimeline.cpp.
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::~KeyframeEffect):
- animation/KeyframeEffect.h: Copied from Source/WebCore/animation/DocumentTimeline.h.
- animation/KeyframeEffect.idl: Copied from Source/WebCore/animation/DocumentTimeline.idl.
- animation/WebAnimation.cpp: Copied from Source/WebCore/animation/DocumentAnimation.cpp.
(WebCore::WebAnimation::create):
(WebCore::WebAnimation::WebAnimation):
(WebCore::WebAnimation::~WebAnimation):
- animation/WebAnimation.h: Copied from Source/WebCore/animation/DocumentAnimation.h.
- animation/WebAnimation.idl: Copied from Source/WebCore/animation/DocumentTimeline.idl.
- bindings/scripts/CodeGeneratorGObject.pm:
- dom/Element.cpp:
(WebCore::Element::getAnimations):
- dom/Element.h:
- dom/Element.idl:
Source/WebKit/mac:
- Setup interface for enabling runtime flag for Web animations through preferences.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webAnimationsEnabled]):
(-[WebPreferences setWebAnimationsEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
LayoutTests:
- Animatable interface and implementation of getAnimations in Element.
- Interface and implementation for Document getAnimations method.
- AnimationEffect interface and class stub.
- KeyframeEffect interface and constructor implementation.
- 'Animation' interface, constructor and query methods for effect and timeline.
- Remove runtime condition on Web animation interfaces (compile time flag is specified).
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- webanimations/Document-expected.txt: Added.
- webanimations/Document.html: Added.
- webanimations/script-tests/Document.js: Added.
- 2:23 AM Changeset in webkit [204593] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
Update test expectations on Windows for failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.
- platform/win/TestExpectations:
Aug 17, 2016:
- 11:38 PM Changeset in webkit [204592] by
-
- 10 edits3 adds in trunk
[Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=160895
Reviewed by Dean Jackson.
Source/WebCore:
Migrate to CTLineDraw() instead.
This patch also adds support for linking to the existing CoreText framework on Windows.
No new tests because there is no behavior change.
- PlatformWin.cmake:
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::showText):
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::drawTextAtPoint):
- platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::drawLayer):
- platform/spi/win/CoreTextSPIWin.cpp: Added.
- platform/spi/win/CoreTextSPIWin.h: Added.
Source/WebKit:
Link to the existing CoreText framework.
- PlatformWin.cmake:
Tools:
Link to the existing CoreText framework.
- DumpRenderTree/PlatformWin.cmake:
- TestWebKitAPI/PlatformWin.cmake:
- 11:22 PM Changeset in webkit [204591] by
-
- 15 edits2 adds in trunk
[CSS] The parser should not get rid of empty namespace specification in front of element name selectors
https://bugs.webkit.org/show_bug.cgi?id=160936
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:
Source/WebCore:
There are two places where you can specify an empty namespace
in selectors:
- Element name (e.g. "|name")
- Attribute name (e.g. "[|name]")
In the first case, if we have an empty namespace, the selector
should match that.
In the second case, the default namespace of attribute is already
empty so it is just the same as "[name]".
Our code was just discarding any empty namespace. This is fine
for attributes but for names that is transforming "|name" into "name"
which is invalid.
This patch updates those cases to differentiate:
- Null prefix -> There was no namespace specified.
- Empty prefix -> There was a namespace prefix and it is empty.
Test: fast/selectors/empty-namespace-with-element-selector.html
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::determineNameInNamespace):
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
- css/CSSParser.h:
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::determineNamespace): Deleted.
LayoutTests:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
- fast/selectors/empty-namespace-with-element-selector-expected.txt: Added.
- fast/selectors/empty-namespace-with-element-selector.html: Added.
- 10:37 PM Changeset in webkit [204590] by
-
- 11 edits in branches/safari-602-branch/Source
Merge r204587. rdar://problem/27807479
- 8:07 PM Changeset in webkit [204589] by
-
- 4 edits in trunk/Source/WebCore
[Web IDL] Add support for dictionary members of dictionary types
https://bugs.webkit.org/show_bug.cgi?id=160902
Reviewed by Sam Weinig.
Add support for dictionary members of dictionary types.
No new tests, updated bindings tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldNotTolerateNull>):
- bindings/scripts/test/TestObj.idl:
- 6:35 PM Changeset in webkit [204588] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add WASM support for i64 simple opcodes.
https://bugs.webkit.org/show_bug.cgi?id=160928
Reviewed by Michael Saboff.
This patch also removes the unsigned int32 mod operator, which is not supported by B3 yet.
- wasm/WASMB3IRGenerator.cpp:
(JSC::WASM::toB3Op):
(JSC::WASM::B3IRGenerator::unaryOp):
- wasm/WASMFunctionParser.h:
(JSC::WASM::WASMFunctionParser<Context>::parseExpression):
- wasm/WASMOps.h:
- 5:46 PM Changeset in webkit [204587] by
-
- 11 edits in trunk/Source
Add support for additional networks
https://bugs.webkit.org/show_bug.cgi?id=160951
rdar://problem/27807479
Reviewed by Sam Weinig.
Source/WebCore:
- Modules/applepay/ApplePaySession.cpp:
(WebCore::createSupportedNetworks):
(WebCore::createPaymentRequest):
(WebCore::ApplePaySession::create):
- Modules/applepay/PaymentRequest.cpp:
(WebCore::isAdditionalValidSupportedNetwork):
(WebCore::PaymentRequest::isValidSupportedNetwork):
- Modules/applepay/PaymentRequest.h:
(WebCore::PaymentRequest::supportedNetworks):
(WebCore::PaymentRequest::setSupportedNetworks):
- Modules/applepay/PaymentRequestValidator.cpp:
(WebCore::PaymentRequestValidator::validateSupportedNetworks):
- Modules/applepay/PaymentRequestValidator.h:
Source/WebKit2:
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<PaymentRequest>::decode):
(IPC::ArgumentCoder<PaymentRequest::SupportedNetworks>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::SupportedNetworks>::decode): Deleted.
- Shared/WebCoreArgumentCoders.h:
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toAdditionalSupportedNetwork):
(WebKit::toSupportedNetwork):
(WebKit::toSupportedNetworks):
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::supportsVersion):
- 4:57 PM Changeset in webkit [204586] by
-
- 3 edits1 add in trunk
We allow assignments to const variables when in a for-in/for-of loop
https://bugs.webkit.org/show_bug.cgi?id=156673
Patch by JF Bastien <jfbastien@apple.com> on 2016-08-17
Reviewed by Filip Pizlo.
JSTests:
- stress/for-in-of-const.js: Added.
(expect_nothrow):
(expect_throw):
(capture):
Source/JavaScriptCore:
for-in and for-of weren't checking whether iteration variable from
parent scopes were const. Assigning to such variables should
throw, but used not to.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
- 4:54 PM Changeset in webkit [204585] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 4:48 PM Changeset in webkit [204584] by
-
- 3 edits in branches/safari-602-branch/Source/WebKit/win
Merge r204575. rdar://problem/27850667
- 4:46 PM Changeset in webkit [204583] by
-
- 3 edits in branches/safari-602-branch/Source/JavaScriptCore
Merge r204572. rdar://problem/27889416
- 4:44 PM Changeset in webkit [204582] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 4:29 PM Changeset in webkit [204581] by
-
- 5 edits in trunk
Use find_library within Windows build
https://bugs.webkit.org/show_bug.cgi?id=160904
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2016-08-17
Reviewed by Brent Fulgham.
.:
- Source/cmake/FindICU.cmake:
- Source/cmake/OptionsWin.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- 4:08 PM Changeset in webkit [204580] by
-
- 2 edits in trunk/Tools
[Win] Remove old libraries from build inputs
https://bugs.webkit.org/show_bug.cgi?id=160949
Reviewed by Dean Jackson.
Modify the download script to remove the old 'icuuc.lib' and
'icuin.lib' files for Windows builds.
- Scripts/update-webkit-auxiliary-libs:
- 4:02 PM Changeset in webkit [204579] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Tab should not layout if not visible
https://bugs.webkit.org/show_bug.cgi?id=160920
<rdar://problem/27876629>
Reviewed by Timothy Hatcher.
Avoid updating the current time when the Network tab is hidden.
The timer, and any debounced timer cancellations, need to be stopped
as soon as the view is hidden.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView.prototype.hidden):
(WebInspector.NetworkGridContentView.prototype._networkTimelineRecordAdded):
(WebInspector.NetworkGridContentView.prototype._stopUpdatingCurrentTime):
(WebInspector.NetworkGridContentView):
- 3:24 PM Changeset in webkit [204578] by
-
- 1 copy in tags/Safari-602.1.50.1.3
New tag.
- 3:18 PM Changeset in webkit [204577] by
-
- 2 edits in trunk/Tools
Extra logging for crash reason
https://bugs.webkit.org/show_bug.cgi?id=160943
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-17
Reviewed by Alexey Proskuryakov.
A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
- Scripts/webkitpy/port/server_process.py:
(ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
(ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
(ServerProcess.has_crashed): Ditto.
- 3:04 PM Changeset in webkit [204576] by
-
- 1 copy in tags/Safari-602.1.50.0.4
New tag.
- 3:02 PM Changeset in webkit [204575] by
-
- 3 edits in branches/safari-602.1.50.0-branch/Source/WebKit/win
Merge patch for rdar://problem/27850667.
- 2:31 PM Changeset in webkit [204574] by
-
- 3 edits in branches/safari-602.1.50.1-branch/Source/JavaScriptCore
Merge r204572. rdar://problem/27889416
- 2:24 PM Changeset in webkit [204573] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 2:22 PM Changeset in webkit [204572] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fixed a potential bug in MarkedArgumentBuffer.
https://bugs.webkit.org/show_bug.cgi?id=160948
<rdar://problem/27889416>
Reviewed by Oliver Hunt.
I haven't been able to produce an observable test case after some trying.
- runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::addMarkSet): New helper function -- I broke
this out from existing code for clarity, but the behavior is the same.
(JSC::MarkedArgumentBuffer::expandCapacity): Ditto.
(JSC::MarkedArgumentBuffer::slowAppend): Always addMarkSet() on the slow
path. This is faster than the old linear scan, and I think it might
avoid cases the old scan could miss.
- runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::append): Account for the case where someone
has called clear() or removeLast().
(JSC::MarkedArgumentBuffer::mallocBase): No behavior change -- but it's
clearer to test the buffers directly instead of inferring what they
might be based on capacity.
- 2:20 PM Changeset in webkit [204571] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Select elements in DOM hierarchy are misaligned
https://bugs.webkit.org/show_bug.cgi?id=160885
Patch by Devin Rousso <Devin Rousso> on 2016-08-17
Reviewed by Timothy Hatcher.
- UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component > select):
- 2:00 PM Changeset in webkit [204570] by
-
- 4 edits1 add in trunk
Remove an invalid assertion in the DFG backend's GetById emitter.
https://bugs.webkit.org/show_bug.cgi?id=160925
<rdar://problem/27248961>
Reviewed by Filip Pizlo.
JSTests:
- stress/dfg-get-by-id-should-not-assert-non-null-prediction.js: Added.
Source/JavaScriptCore:
The DFG backend's GetById assertion that the node's prediction not be SpecNone
is just plain wrong. It assumes that we can never have a GetById node without a
type prediction, but this is not true. The following test case proves otherwise:
function foo() {
"use strict";
return --argumentscallee;
}
Will remove the assertion. Nothing else needs to change as the DFG is working
correctly without the assertion.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 1:41 PM Changeset in webkit [204569] by
-
- 5 edits in branches/safari-602.1.50.1-branch/Source
Versioning.
- 1:22 PM Changeset in webkit [204568] by
-
- 7 edits in trunk/Source
Remove a couple of unused WKSI function pointers
https://bugs.webkit.org/show_bug.cgi?id=160946
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- 12:58 PM Changeset in webkit [204567] by
-
- 5 edits in trunk/Source
Move WKSignedPublicKeyAndChallengeString into WebCore and make it proper C++
https://bugs.webkit.org/show_bug.cgi?id=160945
Reviewed by Dan Bernstein.
Source/WebCore:
- platform/mac/SSLKeyGeneratorMac.mm:
(WebCore::getSubjectPublicKey):
(WebCore::signPublicKeyAndChallenge):
(WebCore::signedPublicKeyAndChallengeString):
Source/WTF:
- wtf/RetainPtr.h:
(WTF::RetainPtr::operator&):
Cast this to the right type.
- wtf/spi/cocoa/SecuritySPI.h:
Add new SPI.
- 12:56 PM Changeset in webkit [204566] by
-
- 24 edits in trunk/Source
Remove CSS_IMAGE_SET feature define
https://bugs.webkit.org/show_bug.cgi?id=160944
Reviewed by Dean Jackson.
Source/WebCore:
This seems to be enabled everywhere already (except Mac cmake build which it keep breaking).
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::CSSCursorImageValue):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cloneForCSSOM):
- css/CSSImageSetValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseVariableDependentValue):
(WebCore::isImageSetFunctionValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):
- css/CSSParser.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapNinePieceImage):
- css/CSSValue.cpp:
(WebCore::CSSValue::traverseSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
- css/CSSValue.h:
(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isGradientValue):
(WebCore::CSSValue::isNamedImageValue):
(WebCore::CSSValue::isImageSetValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isInheritedValue):
- css/StyleBuilderConverter.h:
(WebCore::isImageShape):
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueContent):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
- css/StyleResolver.h:
(WebCore::StyleResolver::applyPropertyToRegularStyle):
- css/makeprop.pl:
(generateFillLayerPropertyValueSetter):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::cssValue):
- rendering/style/StylePendingImage.h:
- style/StylePendingResources.cpp:
(WebCore::Style::loadPendingImage):
Source/WTF:
- wtf/FeatureDefines.h:
- 12:19 PM Changeset in webkit [204565] by
-
- 6 edits2 adds in trunk
[Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
https://bugs.webkit.org/show_bug.cgi?id=160938
<rdar://problem/27876652>
Reviewed by Anders Carlsson.
Source/WebKit2:
-[NSString isEqualToString:] calls an internal NSObject method on its argument, which
NSString subclasses override to return YES, but WKObject does not override and does not
forward to its target NSString.
To fix this issue and other similar issues, we make WKObject a root class instead of an
NSObject subclass.
Test: TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm
- Platform/spi/Cocoa/objcSPI.h: Added.
- Shared/Cocoa/WKObject.h: Make WKObject a root class instead of inhereting from NSObject.
- Shared/Cocoa/WKObject.mm:
(+[WKObject class]): Return self.
(-[WKObject allowsWeakReference]): Added. Called by the Objective-C runtime.
(-[WKObject retainWeakReference]): Ditto.
(-[WKObject hash]): If we don’t have a target, return our address.
(-[WKObject superclass]): Implement this NSObject protocol method.
(-[WKObject class]): Ditto.
(-[WKObject self]): Ditto.
(-[WKObject performSelector:]): Ditto.
(-[WKObject performSelector:withObject:]): Ditto.
(-[WKObject performSelector:withObject:withObject:]): Ditto.
(-[WKObject isProxy]): Ditto.
(-[WKObject respondsToSelector:]): Changed to not call super.
(-[WKObject conformsToProtocol:]): Ditto.
(-[WKObject description]): Ditto.
(-[WKObject retain]): Implement this NSObject protocol method.
(-[WKObject release]): Ditto.
(-[WKObject autorelease]): Ditto.
(-[WKObject retainCount]): Ditto.
(-[WKObject zone]): Ditto.
(-[WKObject dealloc]): Deleted.
(-[WKObject classForCoder]): Deleted.
(-[WKObject classForKeyedArchiver]): Deleted.
(-[WKObject _cfTypeID]): Deleted.
- WebKit2.xcodeproj/project.pbxproj: Added reference to new file.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
(TestWebKitAPI::TEST):
- 11:15 AM Changeset in webkit [204564] by
-
- 2 edits in trunk/Source/WebCore
Try to fix CMake build.
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::cssValue):
- 11:01 AM Changeset in webkit [204563] by
-
- 7 edits2 adds in trunk
AX: Support abbreviations in iOS
https://bugs.webkit.org/show_bug.cgi?id=160907
Reviewed by Joanmarie Diggs.
Source/WebCore:
Expose the expandedTextValue attribute for iOS, so that VoiceOver can speak abbreviations correctly.
Test: accessibility/ios-simulator/abbreviation.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper textMarkersForRange:]):
(-[WebAccessibilityObjectWrapper accessibilityExpandedTextValue]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetSpelling):
(AXAttributeStringSetExpandedTextValue):
(AXAttributedStringAppendText):
(AXAttributeStringSetexpandedTextValue): Deleted.
Tools:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::stringAttributeValue):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::stringAttributeValue):
LayoutTests:
- accessibility/ios-simulator/abbreviation-expected.txt: Added.
- accessibility/ios-simulator/abbreviation.html: Added.
- 10:48 AM Changeset in webkit [204562] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: rapid updates to status icons in Visual Styles sidebar causes flicker
https://bugs.webkit.org/show_bug.cgi?id=160887
Patch by Devin Rousso <Devin Rousso> on 2016-08-17
Reviewed by Timothy Hatcher.
- UserInterface/Views/VisualStyleBasicInput.js:
(WebInspector.VisualStyleBasicInput):
- UserInterface/Views/VisualStyleColorPicker.js:
(WebInspector.VisualStyleColorPicker):
- UserInterface/Views/VisualStyleNumberInputBox.js:
(WebInspector.VisualStyleNumberInputBox):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
- UserInterface/Views/VisualStylePropertyNameInput.js:
(WebInspector.VisualStylePropertyNameInput):
- 10:12 AM Changeset in webkit [204561] by
-
- 8 copies1 add in releases/Apple/Safari Technology Preview 11
Added a tag for Safari Technology Preview release 11.
- 9:37 AM Changeset in webkit [204560] by
-
- 14 edits2 deletes in trunk/Source/WebCore
Remove StyleCachedImageSet
https://bugs.webkit.org/show_bug.cgi?id=160941
Reviewed by Simon Fraser.
It is almost the same as StyleCachedImage. Just use that.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::detachPendingImage):
(WebCore::CSSImageSetValue::~CSSImageSetValue):
(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::bestImageForScaleFactor):
(WebCore::CSSImageSetValue::bestFitImage):
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):
(WebCore::CSSImageSetValue::customCSSText):
(WebCore::CSSImageSetValue::traverseSubresources):
(WebCore::CSSImageSetValue::cachedImageSet): Deleted.
- css/CSSImageSetValue.h:
(WebCore::CSSImageSetValue::create):
(WebCore::CSSImageSetValue::compareByScaleFactor):
- css/StyleResolver.cpp:
- page/EventHandler.cpp:
- rendering/style/ShapeValue.cpp:
(WebCore::ShapeValue::isImageValid):
- rendering/style/StyleAllInOne.cpp:
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::StyleCachedImage):
Add scale factor and CSSImageSetValue backpointer, the only additional features of StyleCachedImageSet.
(WebCore::StyleCachedImage::cssValue):
(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::imageHasRelativeWidth):
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleCachedImageSet.cpp: Removed.
- rendering/style/StyleCachedImageSet.h: Removed.
- rendering/style/StyleImage.h:
(WebCore::StyleImage::isCachedImage):
(WebCore::StyleImage::isPendingImage):
(WebCore::StyleImage::isGeneratedImage):
(WebCore::StyleImage::StyleImage):
(WebCore::StyleImage::isCachedImageSet): Deleted.
- style/StylePendingResources.cpp:
(WebCore::Style::loadPendingImage):
- 7:59 AM Changeset in webkit [204559] by
-
- 5 edits in trunk
[EFL] Bump efl version from 1.17 to 1.18
https://bugs.webkit.org/show_bug.cgi?id=160899
Patch by Gyuyoung Kim <gyuyoung.kim@navercorp.com> on 2016-08-17
Reviewed by Antonio Gomes.
.:
- Source/cmake/OptionsEfl.cmake: Update ewebkit version to 1.18.0.
Tools:
To use efl-1.18, EFL port needs to update install dependencies as well.
- efl/install-dependencies:
- efl/jhbuild.modules:
- 7:39 AM Changeset in webkit [204558] by
-
- 4 edits1 add in trunk
[Win] Add tests for linked fonts.
https://bugs.webkit.org/show_bug.cgi?id=160898
Reviewed by Brent Fulgham.
Add tests for https://trac.webkit.org/changeset/204502.
Source/WebCore:
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::appendLinkedFonts):
(WebCore::getLinkedFonts):
Tools:
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
(TestWebKitAPI::TEST):
- 4:12 AM Changeset in webkit [204557] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix test_ewk2_view after r203612
https://bugs.webkit.org/show_bug.cgi?id=160937
Reviewed by Gyuyoung Kim.
Default parameter values for window.alert() / prompt() / confirm() was
changed from "undefined" to the empty string after r203612.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 4:07 AM Changeset in webkit [204556] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r204449, r204450 and r204451.
Attributes designMode, embeds, plugins, scripts and compatMode have been moved from HTMLDocument to Document.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_document_get_design_mode):
(webkit_dom_html_document_set_design_mode):
(webkit_dom_html_document_get_compat_mode):
(webkit_dom_html_document_get_embeds):
(webkit_dom_html_document_get_plugins):
(webkit_dom_html_document_get_scripts):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/webkitdom.symbols:
- 1:50 AM Changeset in webkit [204555] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r204312.
HTMLInputElement capture attribute now returns the actual capture value, instead of whether it's present or
not. This patch renames webkit_dom_html_input_element_get_capture as
webkit_dom_html_input_element_get_capture_type and deprecates webkit_dom_html_input_element_get_capture.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_input_element_get_capture):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/webkitdom.symbols:
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GetEffectiveFunctionName):
Aug 16, 2016:
- 10:48 PM Changeset in webkit [204554] by
-
- 3 edits2 adds in trunk
[iOS WK2] Don't throw touchMove events on the floor
https://bugs.webkit.org/show_bug.cgi?id=160935
Reviewed by Tim Horton.
Source/WebKit2:
EventDispatcher claimed to coalesce touchMove events, but actually threw away any
touchMove if there was one in the queue when the next non-move event came along.
Fix to strictly coalesce touchMove events, so a start/move/end stream always fires
a move event. This is necessary for move-based interaction to work in testing,
for example the added range slider test.
Test: fast/forms/ios/drag-range-thumb.html
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::touchEvent):
LayoutTests:
Test for range slider interaction with synthesized touch events.
- fast/forms/ios/drag-range-thumb-expected.txt: Added.
- fast/forms/ios/drag-range-thumb.html: Added.
- 9:42 PM Changeset in webkit [204553] by
-
- 11 edits2 moves in trunk
customElements.define should retrieve lifecycle callbacks
https://bugs.webkit.org/show_bug.cgi?id=160797
Reviewed by Chris Dumez.
Source/WebCore:
Updated JSCustomElementInterface to invoke Get(constructor, "prototype") and Get(prototype, callbackName)
for each lifecycle callback as required by the latest specification:
https://html.spec.whatwg.org/#dom-customelementsregistry-define
Also added the support for "observedAttributes" property on the custom elements constructor which defines
the list of attributes for which attributeChangedCallback is invoked.
Test: fast/custom-elements/CustomElementsRegistry.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::setAttributeChangedCallback): Added.
(WebCore::JSCustomElementInterface::attributeChanged): Invoke m_attributeChangedCallback instead of on the
result of Get(element, "attributeChangedCallback").
- bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::observesAttribute): Added.
- bindings/js/JSCustomElementsRegistryCustom.cpp:
(WebCore::getLifecycleCallback): Added.
(WebCore::JSCustomElementsRegistry::define): Invoke Get(prototype, callbackName) for each callback. Also
store attributedChangedCallback and observedAttributes to JSCustomElementInterface. Other callbacks will
be stored in the future when the support for those callbacks are added.
- dom/Element.cpp:
(WebCore::Element::attributeChanged): Moved more code into enqueueAttributeChangedCallbackIfNeeded.
- dom/LifecycleCallbackQueue.cpp:
(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallbackIfNeeded): Added an early exit for when
the given attribute is not observed by the custom element. Also moved the logic to retrieve
JSCustomElementInterface from Element::attributeChanged and renamed it from enqueueAttributeChangedCallback.
- bindings/js/JSDOMBinding.h:
(WebCore::toNativeArray): Throw a TypeError when the argument is not an object.
- bindings/js/JSDOMConvert.h:
(WebCore::Converter<Vector<T>>::convert): Removed a FIXME comment.
LayoutTests:
Added test cases for CustomElementsRegistry.define to make sure it invokes Get(constructor, "prototype")
and Get(prototype, callbackName) for each lifecycle callback.
Also updated the tests to reflect the support for observedAttributes which specifies the list of attributes
for which attributeChangedCallback is invoked.
- fast/custom-elements/CustomElementsRegistry-expected.txt: Renamed from Document-defineElement-expected.txt.
- fast/custom-elements/CustomElementsRegistry.html: Renamed from Document-defineElement.html.
- fast/custom-elements/Document-defineElement-expected.txt: Removed.
- fast/custom-elements/Document-defineElement.html: Removed.
- fast/custom-elements/attribute-changed-callback-expected.txt:
- fast/custom-elements/attribute-changed-callback.html: Added test cases for "observedAttributes".
- fast/custom-elements/lifecycle-callback-timing.html:
- 8:18 PM Changeset in webkit [204552] by
-
- 6 edits8 adds in trunk
Subpixel rendering: Cleanup RenderLayerBacking::updateGeometry.
https://bugs.webkit.org/show_bug.cgi?id=156860
<rdar://problem/25432352>
Reviewed by Simon Fraser.
Source/WebCore:
This patch cleans up the subpixel adjustment computation for the graphics layers
in RenderLayerBacking::updateGeometry.
It also fixes subpixel jiggling with clipping layers (both ancestor and child containment layers).
Tests: compositing/hidpi-ancestor-subpixel-clipping.html
compositing/hidpi-sibling-composited-content-offset.html
compositing/hidpi-subpixel-transform-origin.html
fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::paintChildClippingMaskForFragments):
(WebCore::RenderLayer::paintOverflowControlsForFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::subpixelOffsetFromRendererChanged):
(WebCore::subpixelForLayerPainting):
(WebCore::computeOffsetFromRenderer):
(WebCore::snappedGraphicsLayerRect):
(WebCore::computeOffsetFromAncestorGraphicsLayer):
(WebCore::ComputedOffsets::ComputedOffsets): This is a helper class to hold offset values.
(WebCore::ComputedOffsets::fromAncestorGraphicsLayer):
(WebCore::ComputedOffsets::fromParentGraphicsLayer):
(WebCore::ComputedOffsets::fromPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::computePrimaryGraphicsLayerRect):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::devicePixelFractionGapFromRendererChanged): Deleted.
(WebCore::pixelFractionForLayerPainting): Deleted.
(WebCore::calculateDevicePixelOffsetFromRenderer): Deleted.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Deleted.
- rendering/RenderLayerBacking.h:
LayoutTests:
- compositing/hidpi-ancestor-subpixel-clipping-expected.html: Added.
- compositing/hidpi-ancestor-subpixel-clipping.html: Added.
- compositing/hidpi-sibling-composited-content-offset-expected.html: Added.
- compositing/hidpi-sibling-composited-content-offset.html: Added.
- compositing/hidpi-subpixel-transform-origin-expected.html: Added.
- compositing/hidpi-subpixel-transform-origin.html: Added.
- fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt: Added.
- fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html: Added.
- 8:17 PM Changeset in webkit [204551] by
-
- 12 edits2 adds2 deletes in trunk
Unreviewed, rolling out r204540, r204545, and r204547.
https://bugs.webkit.org/show_bug.cgi?id=160932
Broke Windows builds (Requested by rniwa on #webkit).
Reverted changesets:
"customElements.define should retrieve lifecycle callbacks"
https://bugs.webkit.org/show_bug.cgi?id=160797
http://trac.webkit.org/changeset/204540
"Windows build fix attempt after r204540."
http://trac.webkit.org/changeset/204545
"Another Windows build fix attempt. The error message doesn't
make any sense to me."
http://trac.webkit.org/changeset/204547
- 7:42 PM Changeset in webkit [204550] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, CMake build fix after r204532
- PlatformMac.cmake:
- 7:30 PM Changeset in webkit [204549] by
-
- 3 edits in trunk/Tools
prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
https://bugs.webkit.org/show_bug.cgi?id=160924
Reviewed by Stephanie Lewis.
Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
test the generate function list machinery without requiring a SCM checkout by substituting a delegate
object that mocks out the file system and SCM operations.
- Scripts/VCSUtils.pm:
(parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
- Scripts/prepare-ChangeLog:
(generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
abstracting the logic to query the file system and SCM into functions on a delegate object that
we pass to it.
(actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
(diffHeaderFormat): Deleted.
- 7:29 PM Changeset in webkit [204548] by
-
- 4 edits in trunk/Source
Unreviewed, CMake build fix
- PlatformMac.cmake:
- 7:23 PM Changeset in webkit [204547] by
-
- 2 edits in trunk/Source/WebCore
Another Windows build fix attempt. The error message doesn't make any sense to me.
- bindings/js/JSCustomElementsRegistryCustom.cpp:
(WebCore::JSCustomElementsRegistry::define):
- 7:01 PM Changeset in webkit [204546] by
-
- 2 edits in trunk/Websites/webkit.org
[JSC] Update the documentation of B3's Return opcode
https://bugs.webkit.org/show_bug.cgi?id=160912
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-16
Reviewed by Filip Pizlo.
- docs/b3/intermediate-representation.html:
- 6:55 PM Changeset in webkit [204545] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix attempt after r204540.
- bindings/js/JSBindingsAllInOne.cpp:
- 5:41 PM Changeset in webkit [204544] by
-
- 6 edits in trunk
URLParser should parse URLs without credentials
https://bugs.webkit.org/show_bug.cgi?id=160913
Reviewed by Brady Eidson.
Source/WebCore:
When parsing a URL, after the scheme we do not know if we are parsing a username and password
or if we are parsing the host until we hit a '@' indicating the end of the credentials or a /, ?, or #
indicating the end of the host. Because there are significantly different rules for serializing usernames,
passwords, and hosts (all of which have yet to be implemented in URLParser) we put the code points after the
scheme in a special buffer that will be processed once we know what we are parsing.
In the future, this could be optimized by assuming that we are parsing the host and if we encounter a '@' character,
then do some extra work. This would save us the effort of copying the host twice because most URLs don't have credentials.
This is covered by a new URLParser API test.
- platform/Logging.h:
- platform/URLParser.cpp:
(WebCore::isC0Control):
(WebCore::isC0ControlOrSpace):
(WebCore::isTabOrNewline):
(WebCore::isSpecialScheme):
(WebCore::URLParser::parse):
(WebCore::URLParser::authorityEndReached):
(WebCore::URLParser::hostEndReached):
(WebCore::URLParser::allValuesEqual):
(WebCore::isASCIIDigit): Deleted.
(WebCore::isASCIIAlpha): Deleted.
(WebCore::isASCIIAlphanumeric): Deleted.
- platform/URLParser.h:
(WebCore::URLParser::parse):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::s):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
- 5:25 PM Changeset in webkit [204543] by
-
- 19 edits2 adds in trunk
Add support for ShadowRoot.mode attribute
https://bugs.webkit.org/show_bug.cgi?id=160919
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Add support for ShadowRoot.mode attribute:
Test: fast/shadow-dom/ShadowRoot-mode.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- dom/Element.cpp:
(WebCore::Element::bindingsOffsetParent):
(WebCore::Element::addShadowRoot):
(WebCore::Element::attachShadow):
(WebCore::Element::shadowRootForBindings):
(WebCore::Element::userAgentShadowRoot):
(WebCore::Element::ensureUserAgentShadowRoot):
- dom/Node.cpp:
(WebCore::Node::isUnclosedNode):
(WebCore::Node::assignedSlotForBindings):
(WebCore::Node::isInUserAgentShadowTree):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::styleResolver):
- dom/ShadowRoot.h:
- dom/ShadowRoot.idl:
- dom/SlotAssignment.cpp:
(WebCore::SlotAssignment::didChangeSlot):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::create):
- inspector/InspectorDOMAgent.cpp:
(WebCore::shadowRootType):
(WebCore::InspectorDOMAgent::buildObjectForNode):
- rendering/HitTestResult.cpp:
(WebCore::moveOutOfUserAgentShadowTree):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::selectionPseudoStyle):
- rendering/RenderLayer.cpp:
(WebCore::rendererForScrollbar):
- svg/SVGElement.cpp:
(WebCore::SVGElement::correspondingUseElement):
- testing/Internals.cpp:
(WebCore::Internals::shadowRootType):
LayoutTests:
Add layout test coverage.
- fast/shadow-dom/ShadowRoot-mode-expected.txt: Added.
- fast/shadow-dom/ShadowRoot-mode.html: Added.
- 5:18 PM Changeset in webkit [204542] by
-
- 2 edits in trunk/Source/JavaScriptCore
Heap::collectAllGarbage() should work with JSC_useImmortalObjects=true.
https://bugs.webkit.org/show_bug.cgi?id=160917
Reviewed by Filip Pizlo.
If we do an synchronous GC when JSC_useImmortalObjects=true, we'll get a
RELEASE_ASSERT failure:
$ JSC_useImmortalObjects=true jsc
gc()
Trace/BPT trap: 5
This is because Heap::collectAllGarbage() is doing an explicit sweep of the
MarkedSpace, and the sweeper is expecting to see no RetiredBlocks. However, we
make objects immortal by retiring their blocks. As a result, there is a mismatch
in expectancy.
The fix is simply to not run the sweeper when JSC_useImmortalObjects=true.
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
- 4:59 PM Changeset in webkit [204541] by
-
- 2 edits in trunk/Source/WTF
Enable WebAssembly in the build.
https://bugs.webkit.org/show_bug.cgi?id=160916
Reviewed by Benjamin Poulain.
This patch turns on WebAssembly on all the platforms that support B3.
Turning on WebAssembly by default lets us check the build on every
platform.
- wtf/FeatureDefines.h:
- 4:55 PM Changeset in webkit [204540] by
-
- 11 edits2 moves in trunk
customElements.define should retrieve lifecycle callbacks
https://bugs.webkit.org/show_bug.cgi?id=160797
Reviewed by Chris Dumez.
Source/WebCore:
Updated JSCustomElementInterface to invoke Get(constructor, "prototype") and Get(prototype, callbackName)
for each lifecycle callback as required by the latest specification:
https://html.spec.whatwg.org/#dom-customelementsregistry-define
Also added the support for "observedAttributes" property on the custom elements constructor which defines
the list of attributes for which attributeChangedCallback is invoked.
Test: fast/custom-elements/CustomElementsRegistry.html
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::setAttributeChangedCallback): Added.
(WebCore::JSCustomElementInterface::attributeChanged): Invoke m_attributeChangedCallback instead of on the
result of Get(element, "attributeChangedCallback").
- bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::observesAttribute): Added.
- bindings/js/JSCustomElementsRegistryCustom.cpp:
(WebCore::getLifecycleCallback): Added.
(WebCore::JSCustomElementsRegistry::define): Invoke Get(prototype, callbackName) for each callback. Also
store attributedChangedCallback and observedAttributes to JSCustomElementInterface. Other callbacks will
be stored in the future when the support for those callbacks are added.
- dom/Element.cpp:
(WebCore::Element::attributeChanged): Moved more code into enqueueAttributeChangedCallbackIfNeeded.
- dom/LifecycleCallbackQueue.cpp:
(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallbackIfNeeded): Added an early exit for when
the given attribute is not observed by the custom element. Also moved the logic to retrieve
JSCustomElementInterface from Element::attributeChanged and renamed it from enqueueAttributeChangedCallback.
- bindings/js/JSDOMBinding.h:
(WebCore::toNativeArray): Throw a TypeError when the argument is not an object.
- bindings/js/JSDOMConvert.h:
(WebCore::Converter<Vector<T>>::convert): Removed a FIXME comment.
LayoutTests:
Added test cases for CustomElementsRegistry.define to make sure it invokes Get(constructor, "prototype")
and Get(prototype, callbackName) for each lifecycle callback.
Also updated the tests to reflect the support for observedAttributes which specifies the list of attributes
for which attributeChangedCallback is invoked.
- fast/custom-elements/CustomElementsRegistry-expected.txt: Renamed from Document-defineElement-expected.txt.
- fast/custom-elements/CustomElementsRegistry.html: Renamed from Document-defineElement.html.
- fast/custom-elements/Document-defineElement-expected.txt: Removed.
- fast/custom-elements/Document-defineElement.html: Removed.
- fast/custom-elements/attribute-changed-callback-expected.txt:
- fast/custom-elements/attribute-changed-callback.html: Added test cases for "observedAttributes".
- fast/custom-elements/lifecycle-callback-timing.html:
- 4:31 PM Changeset in webkit [204539] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add WASM I32 simple operators.
https://bugs.webkit.org/show_bug.cgi?id=160914
Reviewed by Benjamin Poulain.
This patch adds support for the i32 simple binary operators.
- wasm/WASMB3IRGenerator.cpp:
(JSC::WASM::toB3Op):
(JSC::WASM::B3IRGenerator::binaryOp):
- wasm/WASMFunctionParser.h:
(JSC::WASM::WASMFunctionParser<Context>::parseExpression):
- wasm/WASMOps.h:
- 4:05 PM Changeset in webkit [204538] by
-
- 2 edits in trunk/Source/WTF
Fix a thinko.
- wtf/Scope.h:
- 4:00 PM Changeset in webkit [204537] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- Configurations/WebCore.xcconfig:
- 3:56 PM Changeset in webkit [204536] by
-
- 7 edits9 deletes in trunk
Align isDefaultNamespace() / lookupPrefix() / lookupNamespaceURI() with the specification
https://bugs.webkit.org/show_bug.cgi?id=160911
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/nodes/Node-lookupNamespaceURI-expected.txt:
Source/WebCore:
Align isDefaultNamespace() / lookupPrefix() / lookupNamespaceURI() with the specification:
- https://dom.spec.whatwg.org/#dom-node-isdefaultnamespace
- https://dom.spec.whatwg.org/#dom-node-lookupprefix
- https://dom.spec.whatwg.org/#dom-node-lookupnamespaceuri
Our implementation now matches closely the text of the DOM specification
and we pass more W3C tests as it fixes the following bug:
- isDefaultNamespace(null) / isDefaultNamespace() was not returning true for in cases where the node's default namespace was null. Our implementation was returning false instead of comparing the node's default namespace (in this case null) with the input namespace (in this case null).
No new tests, rebaselined existing test.
- dom/Node.cpp:
(WebCore::locateDefaultNamespace):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::locateNamespacePrefix):
(WebCore::Node::lookupPrefix):
(WebCore::appendTextContent): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::setTextContent): Deleted.
- dom/Node.h:
- xml/NativeXPathNSResolver.cpp:
(WebCore::NativeXPathNSResolver::lookupNamespaceURI):
LayoutTests:
Drop several outdated tests.
- dom/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt: Removed.
- dom/xhtml/level3/core/nodeisdefaultnamespace03.js: Removed.
- dom/xhtml/level3/core/nodeisdefaultnamespace03.xhtml: Removed.
- dom/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt: Removed.
- dom/xhtml/level3/core/nodelookupnamespaceuri08.js: Removed.
- dom/xhtml/level3/core/nodelookupnamespaceuri08.xhtml: Removed.
- dom/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt: Removed.
- dom/xhtml/level3/core/nodelookupnamespaceuri09.js: Removed.
- dom/xhtml/level3/core/nodelookupnamespaceuri09.xhtml: Removed.
- 3:51 PM Changeset in webkit [204535] by
-
- 8 edits2 copies in trunk/Source/WebKit2
[iOS WK2] Clean up form select code
https://bugs.webkit.org/show_bug.cgi?id=160915
Reviewed by Enrica Casucci.
Some minor forms-related cleanup:
- Give WKFormSelectPopover and WKFormSelectPicker their own header files, making
things easier to find.
- Remove WKContentView *_view member variables from classes which also stored
the view in their base classes.
Sort the project file.
- UIProcess/ios/forms/WKFormPopover.h:
- UIProcess/ios/forms/WKFormPopover.mm:
(-[WKFormRotatingAccessoryPopover accessoryDone]):
(-[WKFormRotatingAccessoryPopover initWithView:]): Deleted.
- UIProcess/ios/forms/WKFormSelectControl.h:
- UIProcess/ios/forms/WKFormSelectControl.mm:
- UIProcess/ios/forms/WKFormSelectPicker.h: Copied from Source/WebKit2/UIProcess/ios/forms/WKFormSelectControl.h.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
- UIProcess/ios/forms/WKFormSelectPopover.h: Copied from Source/WebKit2/UIProcess/ios/forms/WKFormSelectControl.h.
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover initWithView:hasGroups:]):
- WebKit2.xcodeproj/project.pbxproj:
- 3:48 PM Changeset in webkit [204534] by
-
- 7 edits2 adds in trunk
Placeholder does not show the first time going into picture-in-picture on video without controls
https://bugs.webkit.org/show_bug.cgi?id=160868
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/controls/pip-placeholder-without-video-controls.html
If the media controls script is not injected by the time webkitpresentationmodechanged
event fires, the script that updates the stylesheet to show the placeholder won't execute.
To fix this, doing one of the following would work:
- Ensure the shadow dom for the video is set up when we schedule the
webkitpresentationmodechanged event.
- Make sure the styles are set up correctly to show the placeholder if needed
when the Controller object (in mediaControlsApple.js) is created.
Doing both here following what we did for the wireless playback status.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
Call updatePictureInPicturePlaceholder() so it updates the styles to show the
placeholder if needed.
(Controller.prototype.updatePictureInPicturePlaceholder):
Extract the logic that updates the placeholder into a separate method so it can
be called when we initialize Controller.
(Controller.prototype.handlePresentationModeChange):
Call updatePictureInPicturePlaceholder().
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.updatePictureInPicturePlaceholder):
Renamed from handlePresentationModeChange().
(ControllerIOS.prototype.handlePresentationModeChange): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
Call configureMediaControls() which ensures the shadow root gets added if needed.
LayoutTests:
Test that a video without controls attribute does show after going into picture-in-picture.
- TestExpectations:
- media/controls/pip-placeholder-without-video-controls-expected.txt: Added.
- media/controls/pip-placeholder-without-video-controls.html: Added.
- platform/mac-wk2/TestExpectations:
- 3:44 PM Changeset in webkit [204533] by
-
- 2 edits in trunk/Source/WebCore
Rename FrameView::m_layoutDisallowed to m_layoutDisallowedCount
https://bugs.webkit.org/show_bug.cgi?id=160918
Reviewed by Zalan Bujtas.
m_layoutDisallowedCount makes it clearer that it's accumulated.
- page/FrameView.h:
- 3:41 PM Changeset in webkit [204532] by
-
- 2 edits1 move in trunk/Source/WebCore
Rename SSLKeyGeneratorMac.cpp to SSLKeyGeneratorMac.mm.
Rubber-stamped by Dan Bernstein.
- platform/mac/SSLKeyGeneratorMac.mm: Renamed from platform/mac/SSLKeyGeneratorMac.cpp.
- 3:39 PM Changeset in webkit [204531] by
-
- 13 edits1 move1 add1 delete in trunk/Source
Migrate line breaking code from ints to Optional<unsigned>s
https://bugs.webkit.org/show_bug.cgi?id=160859
Reviewed by Darin Adler.
Source/WebCore:
Previously, we were using -1 to mean "before the beginning of the string". Now,
Nullopt means that.
This patch also renames break_lines.{h,cpp} to BreakLines.{h.cpp}. This file was
originally named during the KHTML days.
No new tests because there is no behavior change.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- rendering/BreakLines.cpp: Renamed from Source/WebCore/rendering/break_lines.cpp.
- rendering/BreakLines.h: Renamed from Source/WebCore/rendering/break_lines.h.
(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePositionNonLoosely):
(WebCore::nextBreakablePositionLoosely):
(WebCore::nextBreakablePositionKeepingAllWords):
(WebCore::nextBreakablePositionKeepingAllWordsIgnoringNBSP):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
(WebCore::nextBreakablePositionLoose):
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::isBreakable):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::moveTo):
(WebCore::InlineIterator::nextBreakablePosition):
(WebCore::InlineIterator::setNextBreakablePosition):
(WebCore::InlineIterator::InlineIterator): Deleted.
- rendering/InlineTextBox.cpp:
- rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
- rendering/RenderingAllInOne.cpp:
- rendering/SimpleLineLayoutTextFragmentIterator.h:
- rendering/break_lines.h:
(WebCore::isBreakableSpace): Deleted.
(WebCore::shouldBreakAfter): Deleted.
(WebCore::needsLineBreakIterator): Deleted.
(WebCore::nextBreakablePositionNonLoosely): Deleted.
(WebCore::nextBreakablePositionLoosely): Deleted.
(WebCore::nextBreakablePositionKeepingAllWords): Deleted.
(WebCore::nextBreakablePositionKeepingAllWordsIgnoringNBSP): Deleted.
(WebCore::nextBreakablePosition): Deleted.
(WebCore::nextBreakablePositionIgnoringNBSP): Deleted.
(WebCore::nextBreakablePositionLoose): Deleted.
(WebCore::nextBreakablePositionIgnoringNBSPLoose): Deleted.
(WebCore::isBreakable): Deleted.
- rendering/line/BreakingContext.h:
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::InlineIteratorHistory::nextBreakablePosition):
(WebCore::BreakingContext::InlineIteratorHistory::moveTo):
(WebCore::tryHyphenating):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord):
Source/WebKit/ios:
- Misc/WebUIKitSupport.mm:
(WebKitGetLastLineBreakInBuffer):
- 3:33 PM Changeset in webkit [204530] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
Re-sync imported/w3c/web-platform-tests/dom/ranges/Range-mutations.html with upstream
https://bugs.webkit.org/show_bug.cgi?id=160903
Reviewed by Ryosuke Niwa.
Re-sync imported/w3c/web-platform-tests/dom/ranges/Range-mutations.html with upstream
after https://github.com/w3c/web-platform-tests/pull/3468.
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
- web-platform-tests/dom/ranges/Range-mutations.html:
- 3:32 PM Changeset in webkit [204529] by
-
- 5 edits2 adds in trunk
Add WTF::ScopeExit
https://bugs.webkit.org/show_bug.cgi?id=160908
Reviewed by Geoffrey Garen.
Source/WTF:
WTF::ScopeExit and WTF::makeScopeExit let you define an object that will invoke a function when the
object goes out of scope. This is going to be used to avoid spagetti-code and gotos in a future patch.
The class is modeled after the LWG paper "P0052 - Generic Scope Guard and RAII Wrapper for the Standard Library".
- WTF.xcodeproj/project.pbxproj:
- wtf/Scope.h: Added.
(WTF::makeScopeExit):
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
(TestWebKitAPI::TEST):
- 3:26 PM Changeset in webkit [204528] by
-
- 3 edits2 adds2 deletes in trunk
DOM4: getElementsByClassName should include non StyledElements
https://bugs.webkit.org/show_bug.cgi?id=94718
Reviewed by Ryosuke Niwa.
Source/WebCore:
getElementsByClassName() now includes non StyledElements as per the latest
DOM specification:
The new behavior is consistent with Firefox and Chrome.
Test: fast/dom/getElementsByClassName/non-styled-element.html
- dom/ClassCollection.h:
(WebCore::ClassCollection::elementMatches):
LayoutTests:
- fast/dom/getElementsByClassName/011-expected.txt: Removed.
- fast/dom/getElementsByClassName/011.xml: Removed.
Drop outdated test. It is failing in Firefox and Chrome.
- fast/dom/getElementsByClassName/non-styled-element-expected.txt: Added.
- fast/dom/getElementsByClassName/non-styled-element.html: Added.
Add layout test coverage.
- 3:24 PM Changeset in webkit [204527] by
-
- 2 edits in trunk/Tools
EWS logs file are rotated too quickly
https://bugs.webkit.org/show_bug.cgi?id=160724
Reviewed by Daniel Bates.
Currently we are rotating the log file after 10 iterations of queue. If the queue
doesn't have any pending patches, these iterations result in very small amount of
logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
This results in a lot of log files in a day. This patch ensures that we rotate the
log file when its file size is greater than or equal to 100 KB.
- EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
- 3:20 PM Changeset in webkit [204526] by
-
- 15 edits2 moves4 deletes in trunk
WKSI static library should be named by major iOS revision, not individual updates
https://bugs.webkit.org/show_bug.cgi?id=160727
<rdar://problem/22274848>
Reviewed by Alexey Proskuryakov.
Source/WebKit/mac:
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/WebKitLegacy.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
- Configurations/BaseTarget.xcconfig:
- Configurations/DebugRelease.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- Scripts/copy-webkitlibraries-to-product-directory:
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
WebKitLibraries:
- libWebKitSystemInterfaceIOSDevice9.0.a: Removed.
- libWebKitSystemInterfaceIOSDevice9.2.a: Removed.
- libWebKitSystemInterfaceIOSDevice9.a: Renamed from WebKitLibraries/libWebKitSystemInterfaceIOSDevice9.3.a.
- libWebKitSystemInterfaceIOSSimulator9.0.a: Removed.
- libWebKitSystemInterfaceIOSSimulator9.2.a: Removed.
- libWebKitSystemInterfaceIOSSimulator9.a: Renamed from WebKitLibraries/libWebKitSystemInterfaceIOSSimulator9.3.a.
- 3:15 PM Changeset in webkit [204525] by
-
- 15 edits4 adds in trunk
Make it possible to test iOS select elements, and add iPhone and iPad tests for them
https://bugs.webkit.org/show_bug.cgi?id=160909
Reviewed by Enrica Casucci.
Source/WebKit2:
Hook up form-related UIScriptController functions, and plumb through the various
<select> pickers the ability to select a row.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView dismissFormAccessoryView]):
(-[WKWebView selectFormAccessoryPickerRow:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectFormAccessoryPickerRow:]):
- UIProcess/ios/forms/WKFormSelectControl.h:
- UIProcess/ios/forms/WKFormSelectControl.mm:
(-[WKFormSelectControl selectRow:inComponent:extendingSelection:]):
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker selectRow:inComponent:extendingSelection:]):
(-[WKSelectSinglePicker selectRow:inComponent:extendingSelection:]):
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectPopover selectRow:inComponent:extendingSelection:]):
Tools:
Add functions to UIScriptController to dismiss the form accessory view for iOS,
and to programmatically pick a row from a <select> picker.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::dismissFormAccessoryView):
(WTR::UIScriptController::selectFormAccessoryPickerRow):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::dismissFormAccessoryView):
(WTR::UIScriptController::selectFormAccessoryPickerRow):
LayoutTests:
Add iPhone and iPad tests for the <select> pickers. The iPhone test has to
use a didShowKeyboardCallback to know when to select the appropriate row,
and to dismiss the picker. The iPad test can just select the row, which also
dismisses the popover.
- fast/forms/ios/choose-select-option-expected.txt: Added.
- fast/forms/ios/choose-select-option.html: Added.
- fast/forms/ios/ipad/choose-select-option-expected.txt: Added.
- fast/forms/ios/ipad/choose-select-option.html: Added.
- 2:44 PM Changeset in webkit [204524] by
-
- 16 edits in trunk/Source
Cleanup WK2 platform gamepad handling.
https://bugs.webkit.org/show_bug.cgi?id=160871
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No currently testable change in behavior).
This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently
monitoring gamepad inputs because an interested WKWebView is not front and center.
3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.
- platform/gamepad/GamepadProviderClient.h:
(WebCore::GamepadProviderClient::setInitialConnectedGamepads):
- platform/gamepad/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::stopMonitoringInput):
(WebCore::HIDGamepadProvider::startMonitoringInput):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
- platform/gamepad/mac/HIDGamepadProvider.h:
Source/WebKit2:
This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently
monitoring gamepad inputs because an interested WKWebView is not front and center.
3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.
- Platform/Logging.h:
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::setInitialConnectedGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::viewBecameActive):
(WebKit::UIGamepadProvider::viewBecameInactive):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::snapshotGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
(WebKit::UIGamepadProvider::UIGamepadProvider): Deleted.
(WebKit::UIGamepadProvider::scheduleDisableGamepadMonitoring): Deleted.
(WebKit::UIGamepadProvider::disableMonitoringTimerFired): Deleted.
- UIProcess/Gamepad/UIGamepadProvider.h:
- UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setInitialConnectedGamepads):
- UIProcess/WebProcessPool.h:
- WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::setInitialGamepads):
- WebProcess/Gamepad/WebGamepadProvider.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setInitialGamepads):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 2:18 PM Changeset in webkit [204523] by
-
- 14 edits2 moves4 adds in trunk
[iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
https://bugs.webkit.org/show_bug.cgi?id=160878
Reviewed by Tim Horton.
Source/WebKit2:
Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
now that we have the ability to run tests in the iPad simulator.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView forceIPadStyleZoomOnInputFocus]): Deleted.
(-[WKWebView setForceIPadStyleZoomOnInputFocus:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView inputAccessoryView]):
(-[WKContentView requiresAccessoryView:]): Deleted.
(-[WKContentView forceIPadStyleZoomOnInputFocus]): Deleted.
(-[WKContentView setForceIPadStyleZoomOnInputFocus:]): Deleted.
Tools:
Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
now that we have the ability to run tests in the iPad simulator.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
(WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues): Deleted.
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
(WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
LayoutTests:
Move forms/ios/focus-input-via-button-ipad.html into fast/forms/ios/ipad, making it
an iPad test, which allows for the removal of the "useIPadBehavior" flag.
Add fast/viewport/ios/ipad/width-is-device-width.html with iPad-specific results.
- fast/forms/ios/ipad/focus-input-via-button-expected.txt: Renamed from LayoutTests/fast/forms/ios/focus-input-via-button-ipad-expected.txt.
- fast/forms/ios/ipad/focus-input-via-button.html: Renamed from LayoutTests/fast/forms/ios/focus-input-via-button-ipad.html.
- fast/forms/ios/resources/zooming-test-utils.js:
(testZoomAfterTap):
- fast/viewport/ios/ipad/width-is-device-width-expected.txt: Added.
- fast/viewport/ios/ipad/width-is-device-width.html: Added.
- platform/ios-simulator-wk2/TestExpectations: Enable fast/viewport/ios, because leaving
them skipped from the base TestExpectations is evil.
- 1:58 PM Changeset in webkit [204522] by
-
- 10 edits in trunk
querySelector() / querySelectorAll() should always throw a SyntaxError when failing to parse selector string
https://bugs.webkit.org/show_bug.cgi?id=160906
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/Element-matches-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:
Source/WebCore:
querySelector() / querySelectorAll() should always throw a SyntaxError
when failing to parse selector string:
- https://dom.spec.whatwg.org/#dom-parentnode-queryselector
- https://dom.spec.whatwg.org/#scope-match-a-selectors-string
In some cases, WebKit was throwing a NamespaceError instead.
No new tests, rebaselined existing tests.
- dom/SelectorQuery.cpp:
(WebCore::SelectorQueryCache::add):
LayoutTests:
Rebaseline several layout tests now that we throw a different exception type.
- fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt:
- fast/css/parsing-css-attribute-case-insensitive-value-2-expected.txt:
- fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
- 1:32 PM Changeset in webkit [204521] by
-
- 6 edits3 adds in trunk
Upgrade-Insecure-Request state is improperly retained between navigations
https://bugs.webkit.org/show_bug.cgi?id=160905
<rdar://problem/27075526>
Reviewed by Andy Estes.
Source/WebCore:
Correct the handling of Upgrade-Insecure-Request state to match the specification, so that
performing top-level navigation to sites that do not have the Upgrade-Insecure-Request header
does not automatically upgrade insecure loads. The same loads performed in an iframe should
be upgraded.
The iframe case was already handled in our tests, but a new test is added that models the top-level
navigation and confirms that an upgrade is not performed.
Tests: http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation.html
- dom/Document.cpp:
(WebCore::Document::initContentSecurityPolicy): Properly inherit Upgrade-Insecure-Request state for children
of existing frames.
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin): Retain the history of upgraded resources (per the specification) so that
we continue to upgrade resources that were upgraded during earlier navigations. Note that we do NOT want to
retain the state of the Upgrade-Insecure-Requests header itself.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom): Update to use new helper function.
(WebCore::ContentSecurityPolicy::copyUpgradeInsecureRequestStateFrom): New helper function.
- page/csp/ContentSecurityPolicy.h:
LayoutTests:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-site.html: Added.
- 12:57 PM Changeset in webkit [204520] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: DOM nodes shift when hovering over them in Console
https://bugs.webkit.org/show_bug.cgi?id=160789
<rdar://problem/27815600>
Reviewed by Matt Baker.
- UserInterface/Views/FormattedValue.css:
(.formatted-node > .tree-outline.dom ol): Deleted.
- 12:29 PM Changeset in webkit [204519] by
-
- 9 edits1 add in trunk
Add an address-of operator to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=160879
Reviewed by Tim Horton.
Source/WTF:
This will make some security-related code from WebKitSystemInterface easier to port.
- wtf/HashIterators.h:
(WTF::HashTableValuesIterator::get):
- wtf/HashTable.h:
(WTF::HashTableBucketInitializer<true>::initialize):
Use std::addressof instead of &, in case & is overloaded.
- wtf/RetainPtr.h:
(WTF::RetainPtr::operator&):
Implement this.
Tools:
Test HashMap and HashSet with an object whose operator& is deleted.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Sort the Xcode project.
- TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
(DeletedAddressOfOperator::DeletedAddressOfOperator):
(DeletedAddressOfOperator::value):
(DeletedAddressOfOperator::operator==):
(WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
(WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):
- 12:25 PM Changeset in webkit [204518] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Data grid has a double left border when the first column is hidden
https://bugs.webkit.org/show_bug.cgi?id=160723
<rdar://problem/27778081>
Reviewed by Timothy Hatcher.
This patch exploits the fact hiding columns that aren't first in DataGrid don't create double
borders.
- UserInterface/Views/DataGrid.css:
(.data-grid table.header,):
(.data-grid :matches(th, td):first-child):
(@media (-webkit-min-device-pixel-ratio: 2)):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
- 12:08 PM Changeset in webkit [204517] by
-
- 3 edits2 adds in trunk
ctx.drawImage should clip source rect if it is outside the source image
https://bugs.webkit.org/show_bug.cgi?id=160804
Reviewed by Simon Fraser.
Source/WebCore:
According to the specification [1]"
"When the source rectangle is outside the source image, the source rectangle
must be clipped to the source image and the destination rectangle must be
clipped in the same proportion."
Firefox and Chrome behave according to the specification. This patch aligns
our behavior.
[1] https://html.spec.whatwg.org/multipage/scripting.html#dom-context-2d-drawimage
Test: fast/canvas/drawImage-srcRect-clipping.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
LayoutTests:
Add layout test coverage.
- fast/canvas/drawImage-srcRect-clipping-expected.html: Added.
- fast/canvas/drawImage-srcRect-clipping.html: Added.
- 12:04 PM Changeset in webkit [204516] by
-
- 34 edits2 adds in trunk
⛱ : Implement parsing of Media Constraints for getUserMedia algorithm in Media Capture and Streaming Spec
https://bugs.webkit.org/show_bug.cgi?id=160533
<rdar://problem/27688483>
Patch by George Ruan <gruan@apple.com> on 2016-08-16
Reviewed by Chris Dumez.
Source/WebCore:
Two getUserMedia tests have been updated to reflect changes and cover limited
testing of the parsing of media constraints when given to getUserMedia().
Current testing infrastructure doesn't support full testing of the parsing
of media constraints. Either a mock needs to be created or the selectSettings()
algorithm will need to be implemented so we can see the constraints reflected
by the settings of media stream tracks. See https://bugs.webkit.org/show_bug.cgi?id=160791.
The specification on media constraints and how they are provided to getUserMedia() and
applyConstraints() has changed. These constraints are parsed in the bindings and are
stored in a new class MediaConstraint with derived classes LongConstraint, DoubleConstraint,
BooleanConstraint, and StringConstraint, each holding their respective type of constraint
value.
- CMakeLists.txt: Add JSMediaDevicesCustom.cpp and MediaConstraints.cpp.
- Modules/mediastream/CaptureDeviceManager.cpp:
(CaptureDeviceManager::verifyConstraintsForMediaType): Make changes according
to how format of MediaConstraint was changed.
(CaptureDeviceManager::sessionSupportsConstraint): Ditto.
(CaptureDeviceManager::isSupportedFrameRate): Ditto. Also for the time being
support constraint validation with a static acceptable frame rate range of 0-60.
See relevant https://bugs.webkit.org/show_bug.cgi?id=160794 for supporting
constraint validation of frame rate dynamically.
- Modules/mediastream/CaptureDeviceManager.h: Make changes according to how
format of MediaConstraint was changed.
- Modules/mediastream/MediaConstraintsImpl.cpp: Remove code for parsing media
constraints in the legacy format with keys 'mandatory' and 'optional'. Removal
of legacy code is fine since MEDIA_STREAM feature flag is not enabled for any port.
(WebCore::MediaConstraintsImpl::create): Ditto
(WebCore::MediaConstraintsImpl::initialize): Still used by applyConstraints().
Added FIXME to remove after applyConstraints implementation is changed according
to w3c spec changes.
(WebCore::MediaConstraintsImpl::mandatoryConstraints): Make changes according to
how media constraint data is now stored.
(WebCore::MediaConstraintsImpl::advancedConstraints): Ditto.
(WebCore::MediaConstraintsImpl::getMandatoryConstraints): Deleted.
(WebCore::MediaConstraintsImpl::getOptionalConstraints): Deleted.
(WebCore::MediaConstraintsImpl::getMandatoryConstraintValue): Deleted.
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue): Deleted.
- Modules/mediastream/MediaConstraintsImpl.h:
(WebCore::MediaConstraintsImpl::MediaConstraintsImpl): Add a constructor to allow
construction of MediaConstraintsImpl object based on how the custom binding code
for MediaDevices would parse the media constraints given to getUserMedia().
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getUserMedia): Make changes according to how media constraint
data is now stored.
- Modules/mediastream/MediaDevices.h: Ditto.
- Modules/mediastream/MediaDevices.idl: Add custom binding to parse media constraints,
since we do not have support for automatic binding generation of sequence of dictionaries,
dictionary inheritance, dictionaries inside of dictionaries, disjunctions, or dictionaries
without an interface.
- Modules/mediastream/MediaStreamTrack.cpp: Add FIXME with related bug.
(WebCore::MediaStreamTrack::applyConstraints): Ditto.
- Modules/mediastream/UserMediaRequest.cpp: Make changes according to how media constraint
data is now parsed and stored.
(WebCore::UserMediaRequest::start): Ditto.
(WebCore::UserMediaRequest::UserMediaRequest): Ditto.
(WebCore::UserMediaRequest::didCreateStream): Ditto.
(WebCore::parseOptions): Deleted.
- Modules/mediastream/UserMediaRequest.h: Ditto.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp: Added JSMediaDevicesCustom.cpp.
- bindings/js/JSMediaDevicesCustom.cpp: Added. Custom bindings to parse media constraints.
(WebCore::initializeStringConstraintWithList): Initialize string constraint 'exact' or 'ideal'
value according to an ArrayValue.
(WebCore::createStringConstraint): Given a dictionary acting as a 'MediaTrackConstraintSet'
and a string constraint key (e.g for facingMode), creates a native StringConstraint class to hold
the data.
(WebCore::createBooleanConstraint): Ditto but for constraints of type boolean.
(WebCore::createDoubleConstraint): Ditto but for constraints of type double.
(WebCore::createIntConstraint): Ditto but for constraints of type long.
(WebCore::parseMediaTrackConstraintSetForKey): Parses a given dictionary acting as a
'MediaTrackConstraintSet' for a constraint as the key and creates the correct native object to hold
the data.
(WebCore::parseAdvancedConstraints): Parses the advanced constraints.
(WebCore::parseConstraints): Parses the constraints of a Dictionary acting as a
'MediaTrackConstraints'.
(WebCore::JSMediaDevices::getUserMedia): Parses the constraint input to getUserMedia.
- platform/mediastream/MediaConstraints.cpp: Added. Add MediaConstraint classes with derived
classes IntConstraint, DoubleConstraint, BooleanConstraint, and StringConstraint to act as
containers for the parsed data from getUserMedia().
(WebCore::MediaConstraint::create): Factory that creates the correct derived class based on the
name of a media constraint.
(WebCore::MediaConstraint::getMin): Interface for getting the min value for a constraint.
ASSERT checks are in place to prevent calling getMin with the incorrect constraint type.
(WebCore::MediaConstraint::getMax): Ditto but for max value of constraint.
(WebCore::MediaConstraint::getExact): Ditto but for exact value of constraint.
(WebCore::MediaConstraint::getIdeal): Ditto but for ideal value of constraint.
(WebCore::IntConstraint::create): Creates a long constraint.
(WebCore::IntConstraint::setMin): Sets min value of constraint.
(WebCore::IntConstraint::setMax): Sets max value of constraint.
(WebCore::IntConstraint::setExact): Sets exact value of constraint.
(WebCore::IntConstraint::setIdeal): Sets ideal value of constraint.
(WebCore::IntConstraint::getMin): Overrides interface function and gets min value of constraint.
(WebCore::IntConstraint::getMax): Ditto but for max value of constraint.
(WebCore::IntConstraint::getExact): Ditto but for exact value of constraint.
(WebCore::IntConstraint::getIdeal): Ditto but for ideal value of constraint.
(WebCore::DoubleConstraint::create): Ditto, DoubleConstraint instead of IntConstraint.
(WebCore::DoubleConstraint::setMin): Ditto.
(WebCore::DoubleConstraint::setMax): Ditto.
(WebCore::DoubleConstraint::setExact): Ditto.
(WebCore::DoubleConstraint::setIdeal): Ditto.
(WebCore::DoubleConstraint::getMin): Ditto.
(WebCore::DoubleConstraint::getMax): Ditto.
(WebCore::DoubleConstraint::getExact): Ditto.
(WebCore::DoubleConstraint::getIdeal): Ditto.
(WebCore::BooleanConstraint::create): Ditto, BooleanConstraint instead of IntConstraint.
(WebCore::BooleanConstraint::setExact): Ditto.
(WebCore::BooleanConstraint::setIdeal): Ditto.
(WebCore::BooleanConstraint::getExact): Ditto.
(WebCore::BooleanConstraint::getIdeal): Ditto.
(WebCore::StringConstraint::create): Ditto, StringConstraint instead of IntConstraint.
(WebCore::StringConstraint::setExact): Ditto.
(WebCore::StringConstraint::appendExact): Appends string to 'exact' value of StringConstraint.
(WebCore::StringConstraint::setIdeal): Ditto.
(WebCore::StringConstraint::appendIdeal): Appends string to 'ideal' value of StringConstraint.
(WebCore::StringConstraint::getExact): Ditto.
(WebCore::StringConstraint::getIdeal): Ditto.
- platform/mediastream/MediaConstraints.h: Add MediaConstraint classes with derived
classes IntConstraint, DoubleConstraint, BooleanConstraint, and StringConstraint to act as
containers for the parsed data from getUserMedia().
(WebCore::MediaConstraint::~MediaConstraint):
(WebCore::MediaConstraint::name): Get name of constraint.
(WebCore::MediaConstraint::MediaConstraint): Constructor.
(WebCore::NumericConstraint::NumericConstraint): Base class of DoubleConstraint and IntConstraint.
(WebCore::NumericConstraint::setHasMin): Sets whether object has min vlaue.
(WebCore::NumericConstraint::setHasMax): Ditto but for max.
(WebCore::NumericConstraint::setHasExact): Ditto but for exact.
(WebCore::NumericConstraint::setHasIdeal): Ditto but for ideal.
(WebCore::NumericConstraint::hasMin): Gets whether object has min value.
(WebCore::NumericConstraint::hasMax): Ditto but for max.
(WebCore::NumericConstraint::hasExact): Ditto but for exact.
(WebCore::NumericConstraint::hasIdeal): Ditto but for ideal.
- platform/mediastream/RealtimeMediaSourceCenter.h: Parameters can be reference since
lifetime is guaranteed and ownership is not taken.
- platform/mediastream/mac/AVCaptureDeviceManager.h: Ditto.
- platform/mediastream/mac/AVCaptureDeviceManager.mm: Ditto.
(WebCore::AVCaptureDeviceManager::verifyConstraintsForMediaType): Ditto.
(WebCore::AVCaptureDeviceManager::sessionSupportsConstraint): Make changes according to
how media constraint data is stored.
(WebCore::AVCaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints):
Ditto.
(WebCore::AVCaptureDeviceManager::isSupportedFrameRate): Ditto.
- platform/mediastream/mac/AVVideoCaptureSource.h: Change frame rate from 'float' to 'double'.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setFrameRateConstraint): Ditto.
(WebCore::AVVideoCaptureSource::applyConstraints): Make changes according to how media constraint
data is stored. The implementation of applyConstraints has also drastically changed, and a FIXME
is associated.
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
The bindings will always pass a non-null MediaConstraints object to
getUserMedia() so a pointer MediaConstraints parameter is not necessary.
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream): Ditto.
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.h: Change 'override' to 'final'
since RealtimeMediaSourceCenterMac is a 'final' class.
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp: Ditto to
RealtimeMediaSourceCenterMac.
(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Ditto.
(WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints):
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h: Ditto.
- platform/mock/MediaConstraintsMock.cpp: Change how constraint validation is mocked.
(WebCore::isLongMediaConstraintSatisfiable): Sets arbitrary min and max supported value to be 0 and 10,
respectively. Then checks if constraint is satisfiable.
(WebCore::isDoubleMediaConstraintSatisfiable): Ditto but with double.
(WebCore::isBooleanMediaConstraintSatisfiable): Mock a boolean constraint to only be satisfiable if the
'exact' value is true.
(WebCore::isStringMediaConstraintSatisfiable): Mock a string constraint to only be satisfiable if the
'exact' value has the string 'valid'
(WebCore::isSatisfiable): Checks if a certain constraint is satisfiable.
(WebCore::MediaConstraintsMock::verifyConstraints): Verifies if the constraints are satisfiable.
(WebCore::isSupported): Deleted.
(WebCore::isValid): Deleted.
- platform/mock/MediaConstraintsMock.h: Change argument of MediaConstraints to raw pointer.
- platform/mock/MockRealtimeMediaSourceCenter.cpp: Change arguments of MediaConstraints to a raw pointer
and make changes according to how the MediaConstraint was changed.
(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):
- platform/mock/MockRealtimeMediaSourceCenter.h: Change argument of MediaConstraints to raw pointer.
LayoutTests:
Implementation of parsing of media constraints passed to getUserMedia has changed to meet
the current w3c standards. Three major changes have been introduced
- If the parameter in getUserMedia is missing a TypeError is thrown, according to the IDL spec
- Given a Dictionary value with neither 'audio' nor 'video' keys having dictionary values
or 'true', the promise is rejected with a TypeError
- If the constraints cannot be satisfied the promise is rejected with a DataError. This should
be changed to an OverConstrainedError in the future. See
https://bugs.webkit.org/show_bug.cgi?id=160790
- fast/mediastream/MediaDevices-getUserMedia-expected.txt:
- fast/mediastream/MediaDevices-getUserMedia.html: Added limited testing of parsing of
media constraints for getUserMedia(), this includes only testing of mandatory constraints
and whether the promise is rejected if the constraints cannot be satisfied.
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/getusermedia.html: As format of media constraints have changed, the test
has been updated to reflect those changes.
- 11:11 AM Changeset in webkit [204515] by
-
- 3 edits in trunk/Source/WebCore
Fix WinCairo build after r204512.
- platform/network/curl/SocketStreamHandleImpl.h:
- platform/network/curl/SocketStreamHandleImplCurl.cpp:
(WebCore::createCopy):
(WebCore::SocketStreamHandleImpl::createCopy): Deleted.
- 11:03 AM Changeset in webkit [204514] by
-
- 4 edits in trunk/Tools
False crashes in fast/text/emoji-gender-* tests
https://bugs.webkit.org/show_bug.cgi?id=160779
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-16
Reviewed by Alexey Proskuryakov.
Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
- Scripts/webkitpy/port/driver.py:
(Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
- Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
- Scripts/webkitpy/port/server_process.py:
(ServerProcess.write): Allow caller to disable crash flag on exception.
- 10:26 AM Changeset in webkit [204513] by
-
- 4 edits1 move in trunk/Source/WebInspectorUI
Web Inspector: Do not request Scope Chain lists if section is collapsed (mainly Global Variables)
https://bugs.webkit.org/show_bug.cgi?id=140567
<rdar://problem/19504745>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-16
Reviewed by Timothy Hatcher.
- UserInterface/Main.html:
New file name.
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.fillSection):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Avoid fetching object properties until the user expands the section.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateWatchExpressionsSection):
Avoid fetching scope variable properties until the user expands the section.
- UserInterface/Views/ObjectPropertiesDetailSectionRow.js: Renamed from Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js.
(WebInspector.ObjectPropertiesDetailSectionRow):
(WebInspector.ObjectPropertiesDetailSectionRow.prototype.get objectTree):
(WebInspector.ObjectPropertiesDetailSectionRow.prototype._detailsSectionCollapsedStateChanged):
Rename and simplify the class since it always has an ObjectTreeView.
By default the section will auto-expand the ObjectTreeView, however
if provided a details section group, it will defer expanion until
the group expands.
- 10:14 AM Changeset in webkit [204512] by
-
- 15 edits in trunk/Source
Clean up WebSockets
https://bugs.webkit.org/show_bug.cgi?id=160889
Reviewed by Darin Adler.
Source/WebCore:
We should use size_t's instead of ints for data lengths.
SocketStreamHandleClient is now purely virtual.
A few places that will need SocketStreamHandleImpls instead of SocketStreamHandles now have them.
This patch doesn't change behavior.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
- Modules/websockets/WebSocketChannel.h:
- platform/network/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandle::state):
(WebCore::SocketStreamHandle::send):
- platform/network/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::bufferedAmount):
(WebCore::SocketStreamHandle::client): Deleted.
- platform/network/SocketStreamHandleClient.h:
(WebCore::SocketStreamHandleClient::~SocketStreamHandleClient):
(WebCore::SocketStreamHandleClient::didOpenSocketStream): Deleted.
(WebCore::SocketStreamHandleClient::didCloseSocketStream): Deleted.
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData): Deleted.
(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount): Deleted.
(WebCore::SocketStreamHandleClient::didFailSocketStream): Deleted.
- platform/network/cf/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::create):
- platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
- platform/network/curl/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::create):
- platform/network/soup/SocketStreamHandleImpl.h:
- platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::SocketStreamHandleImpl::create):
Source/WebKit2:
- UIProcess/InspectorServer/WebSocketServerConnection.cpp:
(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
- UIProcess/InspectorServer/WebSocketServerConnection.h:
- 10:05 AM Changeset in webkit [204511] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: add "Copy Selected" context menu item to Console
https://bugs.webkit.org/show_bug.cgi?id=151836
Patch by Devin Rousso <Devin Rousso> on 2016-08-16
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._previousMessageRepeatCountUpdated):
(WebInspector.LogContentView.prototype._handleContextMenuEvent):
(WebInspector.LogContentView.prototype._mousedown):
- 9:57 AM Changeset in webkit [204510] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual Styles: "Text -> Content" isn't escaped
https://bugs.webkit.org/show_bug.cgi?id=158271
Patch by Devin Rousso <Devin Rousso> on 2016-08-16
Reviewed by Timothy Hatcher.
- UserInterface/Base/Utilities.js:
(String.prototype.hasMatchingEscapedQuotes):
Checks that the given string has property escaped quotes (single or double).
- UserInterface/Views/VisualStyleBasicInput.js:
(WebInspector.VisualStyleBasicInput):
(WebInspector.VisualStyleBasicInput.prototype._handleInputElementInput):
- 9:57 AM Changeset in webkit [204509] by
-
- 16 edits in trunk/Source
Unreviewed, rolling out r204506.
Broke the build
Reverted changeset:
"Cleanup WK2 platform gamepad handling."
https://bugs.webkit.org/show_bug.cgi?id=160871
http://trac.webkit.org/changeset/204506
- 9:56 AM Changeset in webkit [204508] by
-
- 18 edits1 delete in trunk/Source
[Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
https://bugs.webkit.org/show_bug.cgi?id=160891
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Removed EditorCocoa.h.
- editing/Editor.cpp: Removed member initialization for members now
initialized in the class definition.
- editing/Editor.h: Added FragmentAndResources struct, createFragment
member function, and _WebCreateFragment function. Also initialize all the
scalar data members here instead of in the constructor.
- editing/cocoa/EditorCocoa.h: Removed. This was unused.
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::createFragment): Added. Calls through to WebKitLegacy
using soft linking for now, but later should be implemented here in WebCore.
- editing/ios/EditorIOS.mm:
(WebCore::Editor::createFragmentAndAddResources): Call createFragment.
- editing/mac/EditorMac.mm:
(WebCore::Editor::createFragmentAndAddResources): Call createFragment.
- loader/EmptyClients.h: Removed documentFragmentFromAttributedString
implementation.
- page/EditorClient.h: Removed documentFragmentFromAttributedString.
Two reasons: The first is that this is now implemented in WebCore. While
there is a call through to WebKitLegacy, it's a temporary thing and done
with soft linking. The second reason is that this returned a raw pointer,
which is not safe in general. Was safe here because it was returning a
pointer owned by an autoreleased Objective-C object.
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
- WebCoreSupport/WebEditorClient.mm:
(attributesForAttributedStringConversion): Replaced the
createExcludedElementsForAttributedStringConversion function with this one.
No good reason to keep the array around instead of the dictionary.
(_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
This is now a global function exported so it can be called by WebCore with
a different way of returning its value.
- WebKit.exp: Added _WebCreateFragment.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Removed long-ago-obsolete workaround for Radar bug 5052369.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
- WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Deleted.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::createExcludedElementsForAttributedStringConversion): Deleted.
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Deleted.
- 9:52 AM Changeset in webkit [204507] by
-
- 30 edits in trunk/Source/WebInspectorUI
Modernize model objects simple getters
https://bugs.webkit.org/show_bug.cgi?id=160863
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-16
Reviewed by Timothy Hatcher.
Simplify the style of many Model objects with basic accessors.
We reduce them to a single line and group them together so
that they can be more easily read at a glance.
- UserInterface/Models/AnalyzerMessage.js:
- UserInterface/Models/ApplicationCacheFrame.js:
- UserInterface/Models/ApplicationCacheManifest.js:
- UserInterface/Models/BreakpointAction.js:
- UserInterface/Models/CSSMedia.js:
- UserInterface/Models/CSSSelector.js:
- UserInterface/Models/CollectionEntry.js:
- UserInterface/Models/CollectionEntryPreview.js:
- UserInterface/Models/DOMStorageObject.js:
- UserInterface/Models/DatabaseObject.js:
- UserInterface/Models/DatabaseTableObject.js:
- UserInterface/Models/ExecutionContext.js:
- UserInterface/Models/GarbageCollection.js:
- UserInterface/Models/IndexedDatabase.js:
- UserInterface/Models/IndexedDatabaseObjectStore.js:
- UserInterface/Models/IndexedDatabaseObjectStoreIndex.js:
- UserInterface/Models/ObjectPreview.js:
- UserInterface/Models/ProbeSet.js:
- UserInterface/Models/PropertyDescriptor.js:
- UserInterface/Models/PropertyPath.js:
- UserInterface/Models/PropertyPreview.js:
- UserInterface/Models/SourceCodePosition.js:
- UserInterface/Models/SourceCodeSearchMatchObject.js:
- UserInterface/Models/SourceCodeTimeline.js:
- UserInterface/Models/StructureDescription.js:
- UserInterface/Models/TextRange.js:
- UserInterface/Models/Timeline.js:
- UserInterface/Models/TimelineRecording.js:
- UserInterface/Models/TypeDescription.js:
- 9:27 AM Changeset in webkit [204506] by
-
- 16 edits in trunk/Source
Cleanup WK2 platform gamepad handling.
https://bugs.webkit.org/show_bug.cgi?id=160871
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No currently testable change in behavior).
This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently
monitoring gamepad inputs because an interested WKWebView is not front and center.
3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.
- platform/gamepad/GamepadProviderClient.h:
(WebCore::GamepadProviderClient::setInitialConnectedGamepads):
- platform/gamepad/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::stopMonitoringInput):
(WebCore::HIDGamepadProvider::startMonitoringInput):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
- platform/gamepad/mac/HIDGamepadProvider.h:
Source/WebKit2:
This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently
monitoring gamepad inputs because an interested WKWebView is not front and center.
3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.
- Platform/Logging.h:
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::setInitialConnectedGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::viewBecameActive):
(WebKit::UIGamepadProvider::viewBecameInactive):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::snapshotGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
(WebKit::UIGamepadProvider::UIGamepadProvider): Deleted.
(WebKit::UIGamepadProvider::scheduleDisableGamepadMonitoring): Deleted.
(WebKit::UIGamepadProvider::disableMonitoringTimerFired): Deleted.
- UIProcess/Gamepad/UIGamepadProvider.h:
- UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setInitialConnectedGamepads):
- UIProcess/WebProcessPool.h:
- WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::setInitialGamepads):
- WebProcess/Gamepad/WebGamepadProvider.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setInitialGamepads):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 9:23 AM Changeset in webkit [204505] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r204494.
https://bugs.webkit.org/show_bug.cgi?id=160901
Broke the iOS build (Requested by cdumez on #webkit).
Reverted changeset:
"Drop unused EventTarget::hasActiveEventListeners()"
https://bugs.webkit.org/show_bug.cgi?id=160869
http://trac.webkit.org/changeset/204494
Patch by Commit Queue <commit-queue@webkit.org> on 2016-08-16
- 8:58 AM Changeset in webkit [204504] by
-
- 2 edits in trunk/JSTests
Unreviewed, rolling out r204464.
This is no longer needed after r204495.
Reverted changeset:
"Skip failing test mozilla/ecma/LexicalConventions/7.7.3.js"
https://bugs.webkit.org/show_bug.cgi?id=160662
http://trac.webkit.org/changeset/204464
- 8:53 AM Changeset in webkit [204503] by
-
- 2 edits in trunk/Source/WebCore
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: Regenerated results, which were affected by the sequence<T> change last night.
- 2:43 AM Changeset in webkit [204502] by
-
- 2 edits in trunk/Source/WebCore
[Win] Hardening of getLinkedFonts function.
https://bugs.webkit.org/show_bug.cgi?id=160850
The SUCCEEDED macro should only be used for functions returning a HRESULT type.
Also, make sure a string array index will not exceed the string length.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::getLinkedFonts):
- 12:55 AM Changeset in webkit [204501] by
-
- 3 edits1 move4 deletes in trunk/Source/WebCore
Simplify SocketStreamError
https://bugs.webkit.org/show_bug.cgi?id=160888
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-16
Reviewed by Darin Adler.
SocketStreamErrorBase and platform-specific SocketStreamError were overly complicated.
They had many functions that were never used. There's no reason to have two separate classes.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/SocketStreamError.h: Copied from Source/WebCore/platform/network/SocketStreamErrorBase.h.
(WebCore::SocketStreamError::SocketStreamError):
(WebCore::SocketStreamError::isNull):
(WebCore::SocketStreamError::errorCode):
(WebCore::SocketStreamError::failingURL):
(WebCore::SocketStreamError::localizedDescription):
(WebCore::SocketStreamErrorBase::isNull): Deleted.
(WebCore::SocketStreamErrorBase::errorCode): Deleted.
(WebCore::SocketStreamErrorBase::failingURL): Deleted.
(WebCore::SocketStreamErrorBase::localizedDescription): Deleted.
(WebCore::SocketStreamErrorBase::SocketStreamErrorBase): Deleted.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
- platform/network/SocketStreamErrorBase.cpp: Removed.
- platform/network/SocketStreamErrorBase.h: Removed.
- platform/network/cf/SocketStreamError.h: Removed.
- platform/network/curl/SocketStreamError.h: Removed.
- platform/network/soup/SocketStreamError.h: Removed.
Aug 15, 2016:
- 11:50 PM Changeset in webkit [204500] by
-
- 19 edits8 adds in trunk
Conversion to sequence<T> is broken for iterable objects
https://bugs.webkit.org/show_bug.cgi?id=160801
Reviewed by Darin Adler.
Source/JavaScriptCore:
Export functions used to iterate over iterable objects.
- runtime/IteratorOperations.h:
(JSC::forEachInIterable):
Source/WebCore:
Added the proper iterator support for sequence<T> with one caveat that we don't check for RegExp object
per https://github.com/heycam/webidl/issues/145.
See http://heycam.github.io/webidl/#es-sequence and http://heycam.github.io/webidl/#es-overloads
Tests: bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl
- bindings/js/JSDOMBinding.cpp:
(WebCore::hasIteratorMethod): Added. A helper function for checking whether a JSValue is iterable or not.
- bindings/js/JSDOMBinding.h:
(WebCore::NativeValueTraits<unsigned>::nativeValue): Removed the check for isNumber to match the spec'ed
behavior at http://heycam.github.io/webidl/#es-unsigned-long which calls ToNumber first without checking
whether the value is a number or not.
(WebCore::toRefPtrNativeArray): Replaced isJSArray check by isObject check and throw a TypeError. Deployed
forEachInIterable to support non-JSArray iterable objects. Also removed the function pointer from the third
argument since we were always calling JSCT::toWrapped.
(WebCore::toNativeArray): Ditto.
- bindings/js/JSDOMConvert.h:
(WebCore::Converter<Vector<T>>::convert): Removed the comment about toNativeArray not throwing when value
is not an object.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadedFunctionOrConstructor): Removed the check for isJSArray for sequence<T> as an iterable
object is not necessary a JSArray.
(WillConvertUndefinedToDefaultParameterValue): Don't return 1 for all sequences since toNativeArray and
toRefPtrNativeArray now throws on undefined due to isObject check.
(JSValueToNative): Removed the third argument from toRefPtrNativeArray.
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequence.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequence.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequencePrivate.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceIsEmpty):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: Added.
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h: Added.
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
- bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl: Added.
LayoutTests:
Added test cases for converting non-JSArray objects to sequence<T> for MutationObserver, FontFaceSet, and WebSocket.
- fast/dom/MutationObserver/observe-exceptions-expected.txt:
- fast/dom/MutationObserver/observe-exceptions.html:
- fast/text/font-face-set-javascript-expected.txt:
- fast/text/font-face-set-javascript.html:
- http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Rebaselined due to js-test-pre.js change.
- http/tests/resources/js-test-pre.js: Merged ToT from resources/js-test-pre.js.
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt: Rebaselined due to js-test-pre.js change.
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt: Ditto.
- http/tests/websocket/tests/hybi/websocket-constructor-protocols-expected.txt: Added.
- http/tests/websocket/tests/hybi/websocket-constructor-protocols.html: Added.
- 11:48 PM Changeset in webkit [204499] by
-
- 6 edits in trunk/Source/WebCore
Rename RegisteredEventListener::listener() to callback() for clarity
https://bugs.webkit.org/show_bug.cgi?id=160873
Reviewed by Darin Adler.
Rename RegisteredEventListener::listener() to callback() for clarity
and to match the specification:
Always calling listener->listener() seems wrong.
- bindings/js/JSCommandLineAPIHostCustom.cpp:
(WebCore::getJSListenerFunctions):
- dom/EventListenerMap.cpp:
(WebCore::findListener):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):
- dom/EventTarget.cpp:
(WebCore::EventTarget::getAttributeEventListener):
(WebCore::EventTarget::fireEventListeners):
- dom/RegisteredEventListener.h:
(WebCore::RegisteredEventListener::callback):
(WebCore::RegisteredEventListener::RegisteredEventListener):
(WebCore::RegisteredEventListener::listener): Deleted.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- 11:41 PM Changeset in webkit [204498] by
-
- 2 edits in trunk/Tools
webkitpy error in TestRunResults.merge()
https://bugs.webkit.org/show_bug.cgi?id=160882
Reviewed by Daniel Bates.
The argument to TestRunResults.merge() can be None if there are no device-specifc
initial results or retry results in Manager.run(), so just return early in that case.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.merge):
- 11:24 PM Changeset in webkit [204497] by
-
- 9 edits in trunk/Source/WebCore
Add support for dictionary members of non nullable wrapper types
https://bugs.webkit.org/show_bug.cgi?id=160876
Reviewed by Darin Adler.
Add support for dictionary members of non nullable wrapper types. We
only supported nullable wrapper types as dictionary members so far.
No new tests, updated bindings tests.
- bindings/js/JSDOMConvert.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent):
(GenerateParametersCheck):
(JSValueToNative):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::construct):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldNotTolerateNull>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldTolerateNull>):
(WebCore::jsTestObjPrototypeFunctionAttachShadowRoot):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::construct):
- bindings/scripts/test/TestObj.idl:
- 10:14 PM Changeset in webkit [204496] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
https://bugs.webkit.org/show_bug.cgi?id=160856
Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Joseph Pecoraro.
- UserInterface/Base/DOMUtilities.js:
(WebInspector.linkifyNodeReference):
Add option to truncate the text of the linkified node.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
Increase the max-height to partially show additional classes if many are set.
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
Trucate the name of inherited nodes so they don't take up as much space in the sidebar.
- UserInterface/Views/VisualStyleSelectorSection.css:
(.details-section.visual-style-selector-section > .header > .current-selector): Deleted.
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles): Deleted.
Removed since they are already inherited.
- 9:17 PM Changeset in webkit [204495] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Regression 204203-204210] 32-bit ASSERTION FAILED: !m_data[index].name.isValid()
https://bugs.webkit.org/show_bug.cgi?id=160881
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-15
Reviewed by Mark Lam.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
We were trying to set the result of the Identity node to the same
value as the source of the Identity.
That is pretty messed up.
- 8:32 PM Changeset in webkit [204494] by
-
- 5 edits in trunk/Source/WebCore
Drop unused EventTarget::hasActiveEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=160869
Reviewed by Alex Christensen.
- dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::containsActive): Deleted.
- dom/EventListenerMap.h:
- dom/EventTarget.cpp:
(WebCore::EventTarget::hasActiveEventListeners): Deleted.
- dom/EventTarget.h:
- 7:27 PM Changeset in webkit [204493] by
-
- 12 edits in trunk
Speed up compile times by not including wtf/Variant.h so much
https://bugs.webkit.org/show_bug.cgi?id=160847
Patch by Sam Weinig <sam@webkit.org> on 2016-08-15
Reviewed by Alex Christensen and Saam Barati.
Source/WebCore:
"using std::experimental::variant" caused internal compiler errors in MSVC2015,
so we are just writing std::experimental where we use it for now.
We should move variant into the std::experimental namespace.
- bindings/js/JSNodeOrString.cpp:
(WebCore::toNodeOrStringVector):
- bindings/js/JSNodeOrString.h:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::childElementCount):
(WebCore::ContainerNode::append):
(WebCore::ContainerNode::prepend):
- dom/ContainerNode.h:
- dom/Node.cpp:
(WebCore::Node::appendChild):
(WebCore::nodeSetPreTransformedFromNodeOrStringVector):
(WebCore::firstFollowingSiblingNotInNodeSet):
(WebCore::Node::convertNodesOrStringsIntoNode):
(WebCore::Node::before):
(WebCore::Node::after):
(WebCore::Node::replaceWith):
- dom/Node.h:
(WebCore::Node::setStyleChange):
(WebCore::Node::customPseudoId):
Source/WTF:
- wtf/Forward.h:
Add forward declaration of std::variant.
- wtf/StdLibExtras.h:
Remove references to std::variant. Move them to wtf/Variant.h
Tools:
- TestWebKitAPI/Tests/WTF/Variant.cpp:
(TestWebKitAPI::TEST):
Explicitly use std::experimental::variant.
- 7:06 PM Changeset in webkit [204492] by
-
- 5 edits5 adds in trunk
ASSERTION FAILURE: [[videoLayer delegate] isKindOfClass:getUIViewClass()] in WebAVPlayerLayerView_videoView()
https://bugs.webkit.org/show_bug.cgi?id=160433
Reviewed by Eric Carlson.
Source/WebCore:
Early return from WebAVPlayerLayerView_videoView() if the PiP layer does not have a non-nil delegate view.
Test: media/controls/close-page-with-picture-in-picture-video-assertion-failure.html
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebAVPlayerLayerView_videoView):
LayoutTests:
Add a layout test to ensure that we do not cause an assertion failure when exiting PiP by closing the tab.
- TestExpectations: Skip media/control/ipad tests on all ports. We will re-enable these tests for iOS.
- media/controls/close-page-with-picture-in-picture-video-assertion-failure-expected.txt: Added.
- media/controls/close-page-with-picture-in-picture-video-assertion-failure.html: Added.
- media/controls/resources/picture-in-picture.html: Added.
- platform/ios-simulator/TestExpectations: Mark tests media/control/ipad as Pass so that we run them
in the iPad simulator.
- 6:43 PM Changeset in webkit [204491] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Close button on selected item in Network tab is misaligned
https://bugs.webkit.org/show_bug.cgi?id=160884
Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Matt Baker.
- UserInterface/Views/NetworkSidebarPanel.css:
(.sidebar > .panel.navigation.network .status .close.status-button):
- 6:34 PM Changeset in webkit [204490] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=160875
Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Matt Baker.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder): Deleted.
Reworked to apply more generally to editors without titles.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container.missing-dependency > .visual-style-property-editor-warning):
(.visual-style-property-container.invalid-value > .visual-style-property-editor-warning):
(.visual-style-property-container:matches(.missing-dependency, .invalid-value) > *:first-child:matches(.visual-style-property-value-container)):
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) > .visual-style-special-property-placeholder):
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency): Deleted.
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value): Deleted.
Reworked class names to be on the element container instead of the icon.
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype.update):
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):
- 4:32 PM Changeset in webkit [204489] by
-
- 7 edits in trunk/Source
Web Inspector: Introduce a method to enable code coverage profiler without enabling type profiler
https://bugs.webkit.org/show_bug.cgi?id=160750
<rdar://problem/27793469>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::disableTypeProfiler):
(Inspector::InspectorRuntimeAgent::enableControlFlowProfiler):
(Inspector::InspectorRuntimeAgent::disableControlFlowProfiler):
(Inspector::InspectorRuntimeAgent::setTypeProfilerEnabledState):
(Inspector::InspectorRuntimeAgent::setControlFlowProfilerEnabledState):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
(WebInspector.loaded):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
- 4:31 PM Changeset in webkit [204488] by
-
- 2 edits in trunk/Source/JavaScriptCore
Array.prototype.map builtin should go on the fast path when constructor===@Array
https://bugs.webkit.org/show_bug.cgi?id=160836
Reviewed by Keith Miller.
In the FTL, we were not compiling the result array in Array.prototype.map
efficiently when the result array should use the Array constructor
(which is the common case). We used to compile it as:
x: JSConstant(Array)
y: Construct(@x, ...)
instead of
y: NewArrayWithSize(...)
This patch changes the builtin to go down the fast path when certain
conditions are met. Often, the check to go down the fast path will
be constant folded because we always create a normal array from the
Array constructor.
This is around a 5% speedup on ES6 Sample Bench.
I also made similar changes for Array.prototype.filter
and Array.prototype.concat on its slow path.
- builtins/ArrayPrototype.js:
- 3:43 PM Changeset in webkit [204487] by
-
- 2 edits1 add in branches/safari-602-branch/LayoutTests
Test gardening for rdar://problem/27595142.
- 3:42 PM Changeset in webkit [204486] by
-
- 8 edits27545 adds1 delete in branches/safari-602.1.50.1-branch
Merge r203972.
2016-08-01 Keith Miller <keith_miller@apple.com>
We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372
Rubber stamped by Geoffrey Garen.
This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.
- JSTests/: Copied from Source/JavaScriptCore/tests.
- Source/JavaScriptCore/tests/: Deleted.
- Scripts/import-test262-tests:
- Scripts/run-javascriptcore-tests:
- Scripts/update-javascriptcore-test-res:
- 2:52 PM Changeset in webkit [204485] by
-
- 7 edits1 add in trunk/Source/JavaScriptCore
Make JSValue::strictEqual() handle failures to resolve JSRopeStrings.
https://bugs.webkit.org/show_bug.cgi?id=160832
<rdar://problem/27577556>
Reviewed by Geoffrey Garen.
Currently, JSValue::strictEqualSlowCaseInline() (and peers) will blindly try to
access the StringImpl of a JSRopeString that fails to resolve its rope. As a
result, we'll crash with null pointer dereferences.
We can fix this by introducing a JSString::equal() method that will do the
equality comparison, but is aware of the potential failures to resolve ropes.
JSValue::strictEqualSlowCaseInline() (and peers) will now call JSString::equal()
instead of accessing the underlying StringImpl directly.
Also added some exception checks.
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITOperations.cpp:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
- runtime/JSString.cpp:
(JSC::JSString::equalSlowCase):
- runtime/JSString.h:
- runtime/JSStringInlines.h: Added.
(JSC::JSString::equal):
- 2:35 PM Changeset in webkit [204484] by
-
- 8 edits7 copies4 adds in trunk/Source
Implement WASM Parser and B3 IR generator
https://bugs.webkit.org/show_bug.cgi?id=160681
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
This patch adds the skeleton for a WebAssembly pipeline. The
pipeline is designed in order to make it easy to have as much of
the compilation process threaded as possible. The flow of the
pipeline roughly goes as follows:
1) Create a WASMPlan with the VM and a Vector of the
assembly. Currently the plan will process all the work
synchronously, however, in the future this can be offloaded to
other threads.
2) The plan will run the WASMModuleParser, which collates all the
information needed to compile each module function
independently. Since, we are still in the early phases, the only
information is the starting and ending byte of the function's
body. The module parser, however, still scans both and
semi-validates the type and the function sections.
3) Each function is decoded and compiled. In the future this
should also include a opcode validation phase. The
WASMFunctionParser is templatized so that a validator should be
able to use most of the same code the B3 IR generator does.
4) When the plan has finished it will fill a Vector of
B3::Compilation objects that correspond to the respective function
in the WASM module.
The current testing plan for the modules is to inline the the
binary generated by the spec's OCaml prototype. The inlined binary
is passed to a WASMPlan then invoked to check the result of the
function. In the future we should add a more robust testing
infrastructure.
- JavaScriptCore.xcodeproj/project.pbxproj:
- testWASM.cpp:
(printUsageStatement):
(CommandLine::parseArguments):
(invoke):
(runWASMTests):
(main):
- wasm/JSWASMModule.h:
(JSC::JSWASMModule::globalVariableTypes):
- wasm/WASMB3IRGenerator.cpp: Added.
(JSC::WASM::B3IRGenerator::B3IRGenerator):
(JSC::WASM::B3IRGenerator::addLocal):
(JSC::WASM::B3IRGenerator::binaryOp):
(JSC::WASM::B3IRGenerator::addConstant):
(JSC::WASM::B3IRGenerator::addBlock):
(JSC::WASM::B3IRGenerator::endBlock):
(JSC::WASM::B3IRGenerator::addReturn):
(JSC::WASM::B3IRGenerator::unify):
(JSC::WASM::B3IRGenerator::initializeIncommingTypes):
(JSC::WASM::B3IRGenerator::unifyValuesWithLevel):
(JSC::WASM::B3IRGenerator::stackForControlLevel):
(JSC::WASM::B3IRGenerator::blockForControlLevel):
(JSC::WASM::parseAndCompile):
- wasm/WASMB3IRGenerator.h: Copied from Source/WTF/wtf/DataLog.h.
- wasm/WASMFormat.h:
- wasm/WASMFunctionParser.h: Added.
(JSC::WASM::WASMFunctionParser<Context>::WASMFunctionParser):
(JSC::WASM::WASMFunctionParser<Context>::parse):
(JSC::WASM::WASMFunctionParser<Context>::parseBlock):
(JSC::WASM::WASMFunctionParser<Context>::parseExpression):
- wasm/WASMModuleParser.cpp: Added.
(JSC::WASM::WASMModuleParser::parse):
(JSC::WASM::WASMModuleParser::parseFunctionTypes):
(JSC::WASM::WASMModuleParser::parseFunctionSignatures):
(JSC::WASM::WASMModuleParser::parseFunctionDefinitions):
- wasm/WASMModuleParser.h: Copied from Source/WTF/wtf/DataLog.h.
(JSC::WASM::WASMModuleParser::WASMModuleParser):
(JSC::WASM::WASMModuleParser::functionInformation):
- wasm/WASMOps.h: Copied from Source/WTF/wtf/DataLog.h.
- wasm/WASMParser.h: Added.
(JSC::WASM::WASMParser::parseVarUInt32):
(JSC::WASM::WASMParser::WASMParser):
(JSC::WASM::WASMParser::consumeCharacter):
(JSC::WASM::WASMParser::consumeString):
(JSC::WASM::WASMParser::parseUInt32):
(JSC::WASM::WASMParser::parseUInt7):
(JSC::WASM::WASMParser::parseVarUInt1):
(JSC::WASM::WASMParser::parseValueType):
- wasm/WASMPlan.cpp: Copied from Source/WTF/wtf/DataLog.h.
(JSC::WASM::Plan::Plan):
- wasm/WASMPlan.h: Copied from Source/WTF/wtf/DataLog.h.
- wasm/WASMSections.cpp: Copied from Source/WTF/wtf/DataLog.h.
(JSC::WASM::WASMSections::lookup):
- wasm/WASMSections.h: Copied from Source/WTF/wtf/DataLog.h.
(JSC::WASM::WASMSections::validateOrder):
Source/WTF:
- wtf/DataLog.h:
(WTF::dataLogLn): Add a new dataLog function, dataLogLn that
automagically includes a new line at the end of the print.
- wtf/LEBDecoder.h:
(decodeUInt32):
(decodeInt32): Change the LEBDecoder to take a pointer and length
rather than a Vector.
- 2:23 PM Changeset in webkit [204483] by
-
- 12 edits8 moves in trunk/Source
Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl
https://bugs.webkit.org/show_bug.cgi?id=160858
Reviewed by Brady Eidson.
Source/WebCore:
No new tests. No change in behavior, except GTK's SocketStreamHandleImpl is now safely ThreadSafeRefCounted.
This is preparation for making a new kind of SocketStreamHandle which is a proxy that communicates with the NetworkProcess in WebKit2.
- CMakeLists.txt:
- PlatformAppleWin.cmake:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- PlatformWinCairo.cmake:
- WebCore.xcodeproj/project.pbxproj:
- page/SocketProvider.cpp:
(WebCore::SocketProvider::createSocketStreamHandle):
- platform/network/SocketStreamHandle.cpp: Copied from Source/WebCore/platform/network/SocketStreamHandleBase.cpp.
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::state):
(WebCore::SocketStreamHandle::send):
(WebCore::SocketStreamHandle::close):
(WebCore::SocketStreamHandle::disconnect):
(WebCore::SocketStreamHandle::sendPendingData):
(WebCore::SocketStreamHandleBase::SocketStreamHandleBase): Deleted.
(WebCore::SocketStreamHandleBase::state): Deleted.
(WebCore::SocketStreamHandleBase::send): Deleted.
(WebCore::SocketStreamHandleBase::close): Deleted.
(WebCore::SocketStreamHandleBase::disconnect): Deleted.
(WebCore::SocketStreamHandleBase::sendPendingData): Deleted.
- platform/network/SocketStreamHandle.h: Copied from Source/WebCore/platform/network/SocketStreamHandleBase.h.
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::client):
(WebCore::SocketStreamHandleBase::~SocketStreamHandleBase): Deleted.
(WebCore::SocketStreamHandleBase::client): Deleted.
- platform/network/SocketStreamHandleBase.cpp: Removed.
- platform/network/SocketStreamHandleBase.h: Removed.
- platform/network/cf/SocketStreamHandle.h: Removed.
- platform/network/cf/SocketStreamHandleCFNet.cpp: Removed.
- platform/network/cf/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/cf/SocketStreamHandle.h.
(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandle::create): Deleted.
- platform/network/cf/SocketStreamHandleImplCFNet.cpp: Copied from Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp.
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::scheduleStreams):
(WebCore::SocketStreamHandleImpl::retainSocketStreamHandle):
(WebCore::SocketStreamHandleImpl::releaseSocketStreamHandle):
(WebCore::SocketStreamHandleImpl::copyPACExecutionDescription):
(WebCore::SocketStreamHandleImpl::pacExecutionCallback):
(WebCore::SocketStreamHandleImpl::executePACFileURL):
(WebCore::SocketStreamHandleImpl::removePACRunLoopSource):
(WebCore::SocketStreamHandleImpl::chooseProxy):
(WebCore::SocketStreamHandleImpl::chooseProxyFromArray):
(WebCore::SocketStreamHandleImpl::createStreams):
(WebCore::SocketStreamHandleImpl::getStoredCONNECTProxyCredentials):
(WebCore::authenticationSchemeFromAuthenticationMethod):
(WebCore::SocketStreamHandleImpl::addCONNECTCredentials):
(WebCore::SocketStreamHandleImpl::copyCFStreamDescription):
(WebCore::SocketStreamHandleImpl::readStreamCallback):
(WebCore::SocketStreamHandleImpl::writeStreamCallback):
(WebCore::SocketStreamHandleImpl::reportErrorToClient):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::port):
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::scheduleStreams): Deleted.
(WebCore::SocketStreamHandle::retainSocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::releaseSocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::copyPACExecutionDescription): Deleted.
(WebCore::SocketStreamHandle::pacExecutionCallback): Deleted.
(WebCore::SocketStreamHandle::executePACFileURL): Deleted.
(WebCore::SocketStreamHandle::removePACRunLoopSource): Deleted.
(WebCore::SocketStreamHandle::chooseProxy): Deleted.
(WebCore::SocketStreamHandle::chooseProxyFromArray): Deleted.
(WebCore::SocketStreamHandle::createStreams): Deleted.
(WebCore::SocketStreamHandle::getStoredCONNECTProxyCredentials): Deleted.
(WebCore::SocketStreamHandle::addCONNECTCredentials): Deleted.
(WebCore::SocketStreamHandle::copyCFStreamDescription): Deleted.
(WebCore::SocketStreamHandle::readStreamCallback): Deleted.
(WebCore::SocketStreamHandle::writeStreamCallback): Deleted.
(WebCore::SocketStreamHandle::reportErrorToClient): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::port): Deleted.
- platform/network/curl/SocketStreamHandle.h: Removed.
- platform/network/curl/SocketStreamHandleCurl.cpp: Removed.
- platform/network/curl/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/curl/SocketStreamHandle.h.
(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandle::create): Deleted.
- platform/network/curl/SocketStreamHandleImplCurl.cpp: Copied from Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp.
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::readData):
(WebCore::SocketStreamHandleImpl::sendData):
(WebCore::SocketStreamHandleImpl::waitForAvailableData):
(WebCore::SocketStreamHandleImpl::startThread):
(WebCore::SocketStreamHandleImpl::stopThread):
(WebCore::SocketStreamHandleImpl::didReceiveData):
(WebCore::SocketStreamHandleImpl::didOpenSocket):
(WebCore::SocketStreamHandleImpl::createCopy):
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::readData): Deleted.
(WebCore::SocketStreamHandle::sendData): Deleted.
(WebCore::SocketStreamHandle::waitForAvailableData): Deleted.
(WebCore::SocketStreamHandle::startThread): Deleted.
(WebCore::SocketStreamHandle::stopThread): Deleted.
(WebCore::SocketStreamHandle::didReceiveData): Deleted.
(WebCore::SocketStreamHandle::didOpenSocket): Deleted.
(WebCore::SocketStreamHandle::createCopy): Deleted.
- platform/network/soup/SocketStreamHandle.h: Removed.
- platform/network/soup/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/soup/SocketStreamHandle.h.
- platform/network/soup/SocketStreamHandleImplSoup.cpp: Copied from Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp.
(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::connected):
(WebCore::SocketStreamHandleImpl::connectedCallback):
(WebCore::SocketStreamHandleImpl::readBytes):
(WebCore::SocketStreamHandleImpl::readReadyCallback):
(WebCore::SocketStreamHandleImpl::didFail):
(WebCore::SocketStreamHandleImpl::writeReady):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandleImpl::stopWaitingForSocketWritability):
(WebCore::SocketStreamHandleImpl::writeReadyCallback):
(WebCore::SocketStreamHandle::create): Deleted.
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::connected): Deleted.
(WebCore::SocketStreamHandle::connectedCallback): Deleted.
(WebCore::SocketStreamHandle::readBytes): Deleted.
(WebCore::SocketStreamHandle::readReadyCallback): Deleted.
(WebCore::SocketStreamHandle::didFail): Deleted.
(WebCore::SocketStreamHandle::writeReady): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Deleted.
(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Deleted.
(WebCore::SocketStreamHandle::writeReadyCallback): Deleted.
- platform/network/soup/SocketStreamHandleSoup.cpp: Removed.
Source/WebKit2:
- WebProcess/Network/WebSocketProvider.cpp:
(WebKit::WebSocketProvider::createSocketStreamHandle):
- 2:11 PM Changeset in webkit [204482] by
-
- 2 edits in trunk/Source/WebKit/mac
Another build fix.
- WebKit.exp:
- 2:08 PM Changeset in webkit [204481] by
-
- 22 edits2 copies17 adds in trunk
Expose crypto.getRandomValues to Web Workers
https://bugs.webkit.org/show_bug.cgi?id=104851
<rdar://problem/27285714>
Reviewed by Darin Adler.
Source/WebCore:
Tests: crypto/webkitSubtle/disallowed-in-worker.html
crypto/workers/crypto-gc-worker.html
crypto/workers/crypto-random-values-limits-worker.html
crypto/workers/crypto-random-values-types-worker.html
crypto/workers/crypto-random-values-worker.html
Expose both crypto and crypto.getRandomValues to Web Workers. However, webkitSubtle is
disabled in Web Workers. This change also refactors a bit on IDLs related to Crypto
interface.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
Introduce GlobalCrypto Interface which is used to repalace the partial IDL in both
DOMWindow and WorkerGlobalScope with sub-implememtations.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::visitAdditionalChildren):
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::visitAdditionalChildren):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- dom/Document.idl:
Add support of GenerateIsReachable=ImplScriptExecutionContext, which allow registered
JS Objects to live as long as ScriptExecutionContext lives, i.e. Document and
WorkerGlobalScope.
- page/Crypto.cpp:
(WebCore::Crypto::Crypto):
(WebCore::Crypto::webkitSubtle):
(WebCore::Crypto::document): Deleted.
- page/Crypto.h:
(WebCore::Crypto::create):
- page/Crypto.idl:
Change the opaque root of Crypto to ScriptExecutionContext such that it perserves
the same live time in both Window and Web Worker. And disable WebKitSubtle in Web
Workers.
- page/DOMWindow.idl:
- page/GlobalCrypto.idl: Added.
Replace partial IDL to sub-implementation of crypto attribute.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::crypto):
- workers/WorkerGlobalScope.h:
- workers/WorkerGlobalScope.idl:
Introduce crypto attribute to Web Workers.
LayoutTests:
- crypto/crypto-random-values-limits.html:
- crypto/crypto-random-values-types.html:
- crypto/crypto-random-values.html:
- crypto/webkitSubtle/disallowed-in-worker-expected.txt: Added.
- crypto/webkitSubtle/disallowed-in-worker.html: Added.
- crypto/webkitSubtle/resources/disallowed-in-worker.js: Added.
- crypto/workers/crypto-gc-worker-expected.txt: Added.
- crypto/workers/crypto-gc-worker.html: Added.
- crypto/workers/crypto-random-values-limits-worker-expected.txt: Added.
- crypto/workers/crypto-random-values-limits-worker.html: Added.
- crypto/workers/crypto-random-values-types-worker-expected.txt: Added.
- crypto/workers/crypto-random-values-types-worker.html: Added.
- crypto/workers/crypto-random-values-worker-expected.txt: Added.
- crypto/workers/crypto-random-values-worker.html: Added.
- crypto/workers/resources/crypto-gc-worker.js: Added.
(startTest):
(continueTest):
(finishTest):
- crypto/workers/resources/crypto-random-limits-worker.js: Added.
(catch):
- crypto/workers/resources/crypto-random-values-types-worker.js: Copied from LayoutTests/crypto/crypto-random-values-types.html.
(checkIntegerTypes):
(checkNonIntegerTypes):
- crypto/workers/resources/crypto-random-values-worker.js: Copied from LayoutTests/crypto/crypto-random-values.html.
(catch):
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- 2:04 PM Changeset in webkit [204480] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] B3 Neg opcode should support float
https://bugs.webkit.org/show_bug.cgi?id=160795
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-15
Reviewed by Geoffrey Garen.
This is required to implement WASM f32.neg opcode.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::negateFloat):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/B3ReduceDoubleToFloat.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testNegDouble):
(JSC::B3::testNegFloat):
(JSC::B3::testNegFloatWithUselessDoubleConversion):
(JSC::B3::run):
- 1:55 PM Changeset in webkit [204479] by
-
- 96 edits in trunk/Source
Use #pragma once in inspector headers
https://bugs.webkit.org/show_bug.cgi?id=160861
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-15
Reviewed by Mark Lam.
- inspector/*.h:
- 1:51 PM Changeset in webkit [204478] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix build.
- Configurations/WebKitLegacy.xcconfig:
- WebKit.mac.exp:
- 1:50 PM Changeset in webkit [204477] by
-
- 13 edits in trunk/Tools
Allow a port to run tests with a custom device setup
https://bugs.webkit.org/show_bug.cgi?id=160833
Reviewed by Daniel Bates.
These changes allow the IOSSimulator port to run tests in iPad mode.
This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
in this case 'ipad'. When specified, any test in a directory with a suffix that matches
a custom device will be collected into a set, and run in that device's environment after
the other tests have run.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._custom_device_for_test): If the test contains a directory matching a
custom device suffix, return that custom device.
(Manager._set_up_run): Push the custom device class, if any, into options so
that the Worker can get to it.
(Manager.run): Go through the list of tests, and break it down into device-generic
tests, and tests for each device class. _run_test_subset is then called for
each collection of tests, and the results merged.
(Manager._run_test_subset): Some lines unwrapped.
(Manager._end_test_run):
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init): Unwrapped a line.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.merge): Add this function to merge TestRunResults
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_workers_and_shards): Print the custom device, if any.
- Scripts/webkitpy/port/base.py:
(Port): Base port has empty array of custom devices.
(Port.setup_test_run): Add device_class argument.
- Scripts/webkitpy/port/driver.py:
(DriverInput.repr):
(Driver.check_driver.implementation):
- Scripts/webkitpy/port/efl.py:
(EflPort.setup_test_run):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_test_run):
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
(IOSSimulatorPort.init):
(IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
based on the custom device class.
(IOSSimulatorPort._set_device_class):
(IOSSimulatorPort._create_simulators): Factor some code into this function.
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort.testing_device):
(IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
seemed wrong for this function. That was moved to setup_test_run().
(IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
but this happened too early, before we knew which kind of devices to create. Devices
are now created in setup_test_run().
- Scripts/webkitpy/port/win.py:
(WinPort.setup_test_run):
- 1:45 PM Changeset in webkit [204476] by
-
- 3 edits1 delete in trunk/Source/WebKit
Remove OldWebAssertions.c
https://bugs.webkit.org/show_bug.cgi?id=160862
Reviewed by Dan Bernstein.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.
- Misc/OldWebAssertions.c: Removed.
(WebReportAssertionFailure): Deleted.
(WebReportError): Deleted.
- 1:40 PM Changeset in webkit [204475] by
-
- 8 edits27545 adds1 delete in branches/safari-602.1.50.0-branch
Merge r203972.
2016-08-01 Keith Miller <keith_miller@apple.com>
We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372
Rubber stamped by Geoffrey Garen.
This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.
- JSTests/: Copied from Source/JavaScriptCore/tests.
- Source/JavaScriptCore/tests/: Deleted.
- Scripts/import-test262-tests:
- Scripts/run-javascriptcore-tests:
- Scripts/update-javascriptcore-test-res:
- 12:16 PM Changeset in webkit [204474] by
-
- 4 edits2 deletes in trunk/Source/WebKit
Remove WebKeyGenerator
https://bugs.webkit.org/show_bug.cgi?id=160854
Reviewed by Dan Bernstein.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
This SPI class is no longer used by Safari.
- WebCoreSupport/WebKeyGenerator.h: Removed.
- WebCoreSupport/WebKeyGenerator.mm: Removed.
(+[WebKeyGenerator sharedGenerator]): Deleted.
(toWebCertificateParseResult): Deleted.
(-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.
- WebView/WebFrameView.mm:
- 12:11 PM Changeset in webkit [204473] by
-
- 2 edits in trunk/Source/WebKit2
Fix iOS build.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):
- 11:59 AM Changeset in webkit [204472] by
-
- 23 edits in trunk/Source
Rename LOG_ALWAYS
https://bugs.webkit.org/show_bug.cgi?id=160768
Rename LOG_ALWAYS and friends, given that the first parameter to it is
a boolean expression that determines whether or not logging should be
performed.
Reviewed by Chris Dumez.
Source/WebCore:
No new tests. No new functionality is added. Only some macro names
have been changed.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::ReliefLogger::logMemoryUsageChange):
- platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::IOSurface):
Source/WebKit2:
- NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::didReceiveResponse):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::cancelPrepareToSuspend):
(WebKit::NetworkProcess::processDidResume):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
- Platform/IPC/Connection.cpp:
(IPC::Connection::waitForSyncReply):
- Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::didChangeIsLoading):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::updateAssertionNow):
(WebKit::ProcessThrottler::updateAssertion):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateActivityToken):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::WebProcessProxy::didSetAssertionState):
(WebKit::WebProcessProxy::setIsHoldingLockedFiles):
- UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(WebKit::ProcessAssertion::ProcessAssertion):
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::layerVolatilityTimerFired):
(WebKit::WebPage::markLayersVolatile):
(WebKit::WebPage::cancelMarkLayersVolatile):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::processWillSuspendImminently):
(WebKit::WebProcess::prepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::processDidResume):
Source/WTF:
- wtf/Assertions.h:
- 11:57 AM Changeset in webkit [204471] by
-
- 12 edits24 adds in trunk
Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
private frameworks and libraries
https://bugs.webkit.org/show_bug.cgi?id=155931
<rdar://problem/25807989>
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.
- Configurations/Base.xcconfig:
Source/WebCore:
Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.
- Configurations/WebKitLegacy.xcconfig:
Source/WebKit2:
Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.
- Configurations/BaseTarget.xcconfig:
Tools:
Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
WebKitLibraries:
Add text-based stubs for private frameworks in iOS 9 and iOS 10 beta.
- WebKitPrivateFrameworkStubs: Added.
- WebKitPrivateFrameworkStubs/iOS: Added.
- WebKitPrivateFrameworkStubs/iOS/10: Added.
- WebKitPrivateFrameworkStubs/iOS/10/AppSupport.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/10/AppSupport.framework/AppSupport.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/10/AssertionServices.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/10/AssertionServices.framework/AssertionServices.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/10/CorePDF.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/10/CorePDF.framework/CorePDF.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/10/GraphicsServices.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/10/GraphicsServices.framework/GraphicsServices.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/10/IOSurface.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/10/IOSurface.framework/IOSurface.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/9: Added.
- WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework/AppSupport.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework/AssertionServices.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework/CorePDF.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework/GraphicsServices.tbd: Added.
- WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework: Added.
- WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework/IOSurface.tbd: Added.
- 11:48 AM Changeset in webkit [204470] by
-
- 27 edits in trunk/Source/JavaScriptCore
Reduce includes of Debugger.h
https://bugs.webkit.org/show_bug.cgi?id=160827
Reviewed by Mark Lam.
- API/JSTypedArray.cpp:
- bytecode/UnlinkedCodeBlock.h:
- bytecode/UnlinkedFunctionExecutable.cpp:
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
- dfg/DFGPlan.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- ftl/FTLJITCode.h:
- inspector/ScriptCallStackFactory.cpp:
- inspector/agents/InspectorDebuggerAgent.h:
- jit/JITOpcodes.cpp:
- jit/JITOpcodes32_64.cpp:
- jit/JITOperations.cpp:
- llint/LLIntOffsetsExtractor.cpp:
- parser/Nodes.cpp:
- parser/Parser.cpp:
- parser/Parser.h:
- runtime/Completion.cpp:
- runtime/Executable.cpp:
- runtime/Executable.h:
- runtime/FunctionConstructor.cpp:
- runtime/SamplingProfiler.cpp:
- runtime/SamplingProfiler.h:
- runtime/VMEntryScope.cpp:
- 11:16 AM Changeset in webkit [204469] by
-
- 17 edits in trunk
Add a setting and preferences to enable visual viewport mode
https://bugs.webkit.org/show_bug.cgi?id=160843
Reviewed by Sam Weinig.
Source/WebCore:
Add a visualViewportEnabled setting, in the start of a group at the bottom
of the file which is intended as the future home for all runtime-enabled
settings.
- page/Settings.in:
Source/WebKit/mac:
Hook up the visualViewportEnabled setting for WebKit1.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences visualViewportEnabled]):
(-[WebPreferences setVisualViewportEnabled:]):
- WebView/WebPreferencesPrivate.h:
Source/WebKit2:
Hook up the visualViewportEnabled setting for WebKit2.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _visualViewportEnabled]):
(-[WKPreferences _setVisualViewportEnabled:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController visualViewportEnabled]):
(-[SettingsController toggleVisualViewportEnabled:]):
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]):
- 10:53 AM Changeset in webkit [204468] by
-
- 2 edits in trunk/Source/WebCore
Fix WinCairo build after r204466.
- platform/network/curl/SocketStreamHandleCurl.cpp:
- 10:37 AM Changeset in webkit [204467] by
-
- 2 edits in trunk/Source/WebCore
Fix GTK build after r204466.
- platform/gtk/DataObjectGtk.h:
- 10:21 AM Changeset in webkit [204466] by
-
- 519 edits in trunk/Source
Remove unused includes of wtf headers
https://bugs.webkit.org/show_bug.cgi?id=160839
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-15
Reviewed by Alex Christensen.
Source/JavaScriptCore:
- Lots of files.
Source/WebCore:
- Lots of files.
Source/WebKit:
- Storage/StorageSyncManager.h:
- Storage/StorageThread.cpp:
- Storage/StorageThread.h:
- Storage/WebDatabaseProvider.cpp:
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WebKit/ios:
- Misc/WebGeolocationCoreLocationProvider.h:
- WebView/WebPDFViewIOS.mm:
- WebView/WebPlainWhiteView.mm:
Source/WebKit/mac:
- History/BinaryPropertyList.cpp:
- History/WebBackForwardList.mm:
- History/WebHistoryItemInternal.h:
- Misc/WebNSFileManagerExtras.mm:
- Plugins/Hosted/NetscapePluginHostProxy.h:
- WebCoreSupport/WebPlatformStrategies.mm:
- WebCoreSupport/WebSelectionServiceController.mm:
- WebCoreSupport/WebUserMediaClient.h:
Source/WebKit/win:
- WebFrame.h:
Source/WebKit2:
- Lots of files.
Source/WTF:
- wtf/BackwardsGraph.h:
- wtf/DataLog.cpp:
- wtf/WorkQueue.cpp:
- wtf/text/StringImpl.cpp:
- wtf/unicode/icu/CollatorICU.cpp:
- 10:15 AM Changeset in webkit [204465] by
-
- 4 edits in trunk/Source/WebCore
Remove unused WebSocketChannel::willOpenSocketStream
https://bugs.webkit.org/show_bug.cgi?id=160851
Reviewed by Daniel Bates.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::willOpenSocketStream): Deleted.
- Modules/websockets/WebSocketChannel.h:
- platform/network/SocketStreamHandleClient.h:
(WebCore::SocketStreamHandleClient::willOpenSocketStream): Deleted.
- 10:14 AM Changeset in webkit [204464] by
-
- 2 edits in trunk/JSTests
Skip failing test mozilla/ecma/LexicalConventions/7.7.3.js
https://bugs.webkit.org/show_bug.cgi?id=160662
Unreviewed test gardening.
- mozilla/ecma/LexicalConventions/7.7.3.js:
- 9:53 AM Changeset in webkit [204463] by
-
- 3 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html for mac-wk1, mark as failing on Yosemite.
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- 9:43 AM Changeset in webkit [204462] by
-
- 9 edits3 copies4 adds in trunk/Source
Move the plug-in and WebGL blacklist code to WebCore
https://bugs.webkit.org/show_bug.cgi?id=160831
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/BlacklistUpdater.h: Added.
(WebCore::BlacklistUpdater::queue):
(WebCore::BlacklistUpdater::pluginBlacklist):
(WebCore::BlacklistUpdater::webGLBlacklist):
- platform/mac/BlacklistUpdater.mm: Added.
(WebCore::BlacklistUpdater::readBlacklistData):
(WebCore::BlacklistUpdater::reloadIfNecessary):
(WebCore::BlacklistUpdater::initializeQueue):
- platform/mac/PluginBlacklist.h: Added.
- platform/mac/PluginBlacklist.mm: Added.
(WebCore::PluginBlacklist::loadPolicyForPluginVersion):
(WebCore::PluginBlacklist::isPluginUpdateAvailable):
(WebCore::PluginBlacklist::create):
(WebCore::PluginBlacklist::~PluginBlacklist):
(WebCore::PluginBlacklist::splitOSVersion):
(WebCore::PluginBlacklist::loadPolicyForPlugin):
(WebCore::PluginBlacklist::isUpdateAvailable):
(WebCore::PluginBlacklist::PluginBlacklist):
- platform/mac/WebGLBlacklist.h: Added.
- platform/mac/WebGLBlacklist.mm: Added.
(WebCore::OSBuildInfo::OSBuildInfo):
(WebCore::OSBuildInfo::operator==):
(WebCore::OSBuildInfo::operator>):
(WebCore::OSBuildInfo::operator<=):
(WebCore::OSBuildInfo::operator<):
(WebCore::buildInfoFromOSBuildString):
(WebCore::WebGLBlacklist::shouldBlockWebGL):
(WebCore::WebGLBlacklist::shouldSuggestBlockingWebGL):
(WebCore::matchesGPU):
(WebCore::gpuMaskFromString):
(WebCore::matchesBuildInfo):
(WebCore::WebGLBlacklist::create):
(WebCore::WebGLBlacklist::shouldBlock):
(WebCore::WebGLBlacklist::shouldSuggestBlocking):
(WebCore::WebGLBlacklist::WebGLBlacklist):
(WebCore::WebGLBlacklist::~WebGLBlacklist):
- platform/spi/cf/CFUtilitiesSPI.h: Added.
Source/WebKit/mac:
Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
- WebCoreSupport/WebFrameLoaderClient.mm:
(shouldBlockPlugin):
(WebFrameLoaderClient::createPlugin):
(WebFrameLoaderClient::createJavaAppletWidget):
(shouldBlockWebGL):
(WebFrameLoaderClient::webGLPolicyForURL):
(WebFrameLoaderClient::resolveWebGLPolicyForURL):
Source/WebKit2:
Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm:
(WebKit::getPlatformPluginModuleInformation):
- Shared/Plugins/PluginModuleInfo.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextIsPlugInUpdateAvailable):
(WKContextShouldBlockWebGL):
(WKContextShouldSuggestBlockWebGL):
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
(WebKit::WKPlugInModuleLoadPolicyToPluginModuleLoadPolicy): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
- 9:10 AM Changeset in webkit [204461] by
-
- 2 edits1 add in trunk/Source/WebKit2
Add Sandbox profile for Enterprise support version of Flash Player
https://bugs.webkit.org/show_bug.cgi?id=160753
<rdar://problem/17614483>
Reviewed by Andy Estes.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player ESR.plugin.sb: Added.
- WebKit2.xcodeproj/project.pbxproj: Add reference to new sandbox profile.
- 2:56 AM Changeset in webkit [204460] by
-
- 2 edits in trunk/Tools
Allow using make-dist with non-GTK ports
https://bugs.webkit.org/show_bug.cgi?id=160842
Reviewed by Michael Catanzaro.
This patch adds support for setting base name of tarball and argument
passed to cmake's -DPORT= via command line arguments.
- gtk/make-dist.py:
(Distcheck.configure):
(Distcheck.check):
(get_tarball_root_and_output_filename_from_arguments):
Aug 14, 2016:
- 5:48 PM Changeset in webkit [204459] by
-
- 13 edits1 delete in trunk/Source/WebCore
Align the event listener firing code with the latest DOM Specification and simplify it
https://bugs.webkit.org/show_bug.cgi?id=160828
Reviewed by Darin Adler.
Align the event listener firing code with the latest DOM specification:
- https://dom.spec.whatwg.org/#concept-event-listener-invoke
- https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke
- https://dom.spec.whatwg.org/#concept-event-listener
The following changes were made:
- RegisteredEventListener (equivalent to "event listener" in the spec) is now RefCounted
- RegisteredEventListener now has a wasRemoved flag as in specification.
- fireEventListeners() is now iterating over a copy of the event listeners, as in the specification. We rely on the wasRemoved removed flag to avoid executing event listeners that were removed while we iterate.
Previously, the code was modifying the event listeners vector we were
iterating on. Doing so safely lead to complicated and error prone code.
The new code is much simpler and easier to reason about.
This change seems to be perf-neutral on Speedometer.
No new tests, no web-exposed behavior change.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCommandLineAPIHostCustom.cpp:
(WebCore::getJSListenerFunctions):
- dom/DOMAllInOne.cpp:
- dom/EventListenerMap.cpp:
(WebCore::EventListenerMap::assertNoActiveIterators):
(WebCore::EventListenerMap::containsCapturing):
(WebCore::EventListenerMap::containsActive):
(WebCore::findListener):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):
(WebCore::EventListenerMap::clear): Deleted.
- dom/EventListenerMap.h:
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::assertNoActiveIterators):
- dom/EventTarget.cpp:
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::getAttributeEventListener):
(WebCore::FiringEventListenersScope::FiringEventListenersScope):
(WebCore::FiringEventListenersScope::~FiringEventListenersScope):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::setAttributeEventListener): Deleted.
(WebCore::EventTarget::hasActiveEventListeners): Deleted.
(WebCore::EventTarget::dispatchEventForBindings): Deleted.
(WebCore::EventTarget::getEventListeners): Deleted.
- dom/EventTarget.h:
(WebCore::EventTarget::isFiringEventListeners):
- dom/RegisteredEventListener.cpp: Removed.
- dom/RegisteredEventListener.h:
(WebCore::RegisteredEventListener::Options::Options):
(WebCore::RegisteredEventListener::create):
(WebCore::RegisteredEventListener::listener):
(WebCore::RegisteredEventListener::useCapture):
(WebCore::RegisteredEventListener::isPassive):
(WebCore::RegisteredEventListener::isOnce):
(WebCore::RegisteredEventListener::wasRemoved):
(WebCore::RegisteredEventListener::markAsRemoved):
(WebCore::RegisteredEventListener::RegisteredEventListener):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorDOMAgent.h:
(WebCore::EventListenerInfo::EventListenerInfo):
- svg/SVGElement.cpp:
(WebCore::hasLoadListener):
- 5:02 PM Changeset in webkit [204458] by
-
- 6 edits1 delete in trunk/Source/WebKit2
[Cocoa] Remove deprecated _WKFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=160848
Reviewed by Anders Carlsson.
- Shared/API/Cocoa/WebKitPrivate.h: Removed #import.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _formDelegate]): Moved into WKBinaryCompatibilityIOS10 cateogry implementation,
chaged type to id <_WKInputDelegate>.
(-[WKWebView _setFormDelegate:]): Ditto.
- UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed property declaration.
- UIProcess/API/Cocoa/_WKFormDelegate.h: Removed.
- WebKit2.xcodeproj/project.pbxproj: Removed reference to header.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Fixed comment.
- 4:04 PM Changeset in webkit [204457] by
-
- 4 edits in trunk/JSTests
[2016] Set correct status for test262 after implementation of Object.values&Object.entries
https://bugs.webkit.org/show_bug.cgi?id=160844
Reviewed by Saam Barati.
Patch contains fix statuses of specs in the test262 test collection after implementation of
Object.values and Object.entries functions. Also patch contains small fixes in tests of the
tests for Object.values/entries functions.
- stress/object-entries.js:
(Object.getOwnPropertyDescriptor):
- stress/object-values.js:
(Object.getOwnPropertyDescriptor):
- test262.yaml:
- 3:42 PM Changeset in webkit [204456] by
-
- 12 edits in trunk/Source
Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
https://bugs.webkit.org/show_bug.cgi?id=160725
Reviewed by Sam Weinig.
Source/WebCore:
- platform/cocoa/ThemeCocoa.mm: Unconditionally include header dlfcn.h as it
exists in both the public iOS 9.3 SDK and iOS 10 beta SDK.
- platform/spi/cocoa/CoreTextSPI.h: Add SPI declarations for constants that were
used in r204107.
- platform/spi/cocoa/PassKitSPI.h: Remove unnecessary #import statements when
building with the Apple Internal SDK. Include header PassKit/PassKit.h when
building for iOS.
- platform/spi/cocoa/QuartzCoreSPI.h: No need to define CLayer.contentsFormat
when building with the iOS 10 beta SDK as it is now part of the public API.
Source/WebKit/mac:
OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
silence the complier warning.
- WebView/WebView.mm:
(-[WebView _dispatchTileDidDraw:]):
Source/WebKit2:
- Platform/spi/ios/UIKitSPI.h: Add SPI for UITextInputSuggestionDelegate.
- UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Remove unnecessary include of PKPaymentMerchantSession.h.
Source/WTF:
For now, disable OS_LOG when building with the iOS 10 beta SDK until
we have the fix for <rdar://problem/27758343>.
- wtf/Platform.h:
- 3:38 PM Changeset in webkit [204455] by
-
- 3 edits in trunk/Source/WebCore
Dereferenced NULL pointer in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=160823
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-14
Reviewed by Darin Adler.
No behavior changed, new tests unneeded.
This change was initiated by a NULL pointer dereference to provide this unused argument.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::addStyleProperties): Removed unused function argument.
(WebCore::StyleResolver::CascadedProperties::addMatch): Ditto.
- css/StyleResolver.h: Ditto.
- 2:45 PM Changeset in webkit [204454] by
-
- 5 edits1 delete in trunk/Source/WebKit2
[Cocoa] Remove deprecated _WKVisitedLinkProvider declarations that aren’t needed
https://bugs.webkit.org/show_bug.cgi?id=160846
Reviewed by Darin Adler.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _visitedLinkProvider]): Moved into WKBinaryCompatibilityIOS10
cateogry implementation, changed type to _WKVisitedLinkStore.
(-[WKWebViewConfiguration _setVisitedLinkProvider:]): Ditto.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Removed property declaration.
- UIProcess/API/Cocoa/_WKVisitedLinkProvider.h: Removed.
- UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm: Moved declaration in here.
- WebKit2.xcodeproj/project.pbxproj: Updated for header removal.
- 11:29 AM Changeset in webkit [204453] by
-
- 2 edits in trunk/Source/WebCore
Fix GTK Debug bots after r204400
https://bugs.webkit.org/show_bug.cgi?id=160818
Reviewed by Carlos Garcia Campos.
Because the GTK EWS bot doesn't run tests, I missed this.
No new tests because there is no behavior change.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect):
Aug 13, 2016:
- 6:29 PM Changeset in webkit [204452] by
-
- 2 edits in trunk/Source/WTF
Build fix follow-up to r204433.
- wtf/StdLibExtras.h:
(WTF::makeVisitor): Don’t use an auto return type.
- 5:10 PM Changeset in webkit [204451] by
-
- 3 edits2 adds in trunk
'compatMode' property should be on Document, not HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=160819
Reviewed by Sam Weinig.
Source/WebCore:
'compatMode' property should be on Document, not HTMLDocument:
WebKit had it on both. Firefox and Chrome have it on Document only.
Test: fast/dom/Document/compatMode-location.html
- html/HTMLDocument.idl:
LayoutTests:
Add layout test coverage.
- fast/dom/Document/compatMode-location-expected.txt: Added.
- fast/dom/Document/compatMode-location.html: Added.
- 3:37 PM Changeset in webkit [204450] by
-
- 5 edits in trunk
Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
https://bugs.webkit.org/show_bug.cgi?id=160829
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
to match the latest specification:
This also matches Chrome.
No new tests, rebaselined existing test.
- dom/Document.idl:
- html/HTMLDocument.idl:
- 3:36 PM Changeset in webkit [204449] by
-
- 9 edits in trunk
Move designMode attribute from HTMLDocument to Document
https://bugs.webkit.org/show_bug.cgi?id=160838
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move designMode attribute from HTMLDocument to Document to match the
latest HTML specification:
This also matches Chrome.
No new tests, rebaselined existing test.
- dom/Document.cpp:
(WebCore::Document::designMode):
(WebCore::Document::setDesignMode):
- dom/Document.h:
- dom/Document.idl:
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::bgColor): Deleted.
(WebCore::HTMLDocument::setBgColor): Deleted.
(WebCore::HTMLDocument::fgColor): Deleted.
- html/HTMLDocument.h:
- html/HTMLDocument.idl:
- 1:30 PM Changeset in webkit [204448] by
-
- 2 edits in trunk/Tools
[GTK] Install script lacks gstreamer related dependencies
https://bugs.webkit.org/show_bug.cgi?id=160814
Reviewed by Carlos Garcia Campos.
- gtk/install-dependencies: Fedora case had already listed this dependencies,
but both Arch and Debian/Ubuntu were missing them.
- 11:59 AM Changeset in webkit [204447] by
-
- 2 edits in trunk/Tools
make-dist.py should not allow unknown rules in manifest
https://bugs.webkit.org/show_bug.cgi?id=160841
Reviewed by Carlos Garcia Campos.
- gtk/make-dist.py:
(Manifest.process_line):
- 10:17 AM Changeset in webkit [204446] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=160803
Reviewed by Brent Fulgham.
Initialize local variables.
- jit/JIT.cpp:
(JSC::JIT::compileWithoutLinking):
- runtime/Error.cpp:
(JSC::addErrorInfoAndGetBytecodeOffset):
- 8:32 AM Changeset in webkit [204445] by
-
- 3 edits in trunk/Tools
[EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
https://bugs.webkit.org/show_bug.cgi?id=160809
Reviewed by Carlos Garcia Campos.
- efl/install-dependencies: Factorize the previous logic for handling the php5/7
case, and use it also for the new package names of libpng and libgeoclue.
- gtk/install-dependencies: Ditto.
Aug 12, 2016:
- 11:11 PM Changeset in webkit [204444] by
-
- 3 edits in trunk/Tools
Skip to check directories existence in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=160691
Reviewed by Alex Christensen.
CMake checks if directories are there itself. So CMake ports
don't need to check it in the build-webkit script.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
(determineSourceDir):
(isCMakeBuild):
- 10:05 PM Changeset in webkit [204443] by
-
- 1 copy in tags/Safari-602.1.50.0.3
New tag.
- 10:01 PM Changeset in webkit [204442] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 9:20 PM Changeset in webkit [204441] by
-
- 21 edits1 add in trunk
getElementsByTagName() should take a qualifiedName in parameter
https://bugs.webkit.org/show_bug.cgi?id=160682
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
- web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/case-expected.txt:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml:
Re-sync this test from upstream as it was outdated after:
Source/WebCore:
getElementsByTagName() should take a qualifiedName in parameter, not a
localName, according to the latest DOM specification:
- https://dom.spec.whatwg.org/#dom-document-getelementsbytagname
- https://dom.spec.whatwg.org/#concept-getelementsbytagname
The new behavior matches Firefox and Edge. There is a slight
compatiblity risk but we should give it a try.
No new tests, rebaselined existing tests.
- WebCore.xcodeproj/project.pbxproj:
- dom/AllDescendantsCollection.h: Added.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):
- dom/Node.cpp:
(WebCore::NodeListsNodeData::invalidateCaches):
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCachedTagCollectionNS):
(WebCore::NodeListsNodeData::removeCachedTagCollectionNS):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):
- dom/TagCollection.cpp:
(WebCore::makeQualifiedName):
(WebCore::splitQualifiedName):
(WebCore::TagCollectionNS::TagCollectionNS):
(WebCore::TagCollectionNS::~TagCollectionNS):
(WebCore::TagCollection::TagCollection):
(WebCore::TagCollection::~TagCollection):
(WebCore::HTMLTagCollection::HTMLTagCollection):
(WebCore::HTMLTagCollection::~HTMLTagCollection):
- dom/TagCollection.h:
(WebCore::TagCollection::elementMatches):
(WebCore::TagCollectionNS::elementMatches):
(WebCore::HTMLTagCollection::elementMatches):
- html/CollectionType.h:
- html/GenericCachedHTMLCollection.cpp:
(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches):
- html/HTMLCollection.cpp:
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
LayoutTests:
Update existing tests to reflect behavior change.
- fast/dom/getElementsByClassName/010.xml:
- fast/dom/getElementsByClassName/011.xml:
- 8:05 PM Changeset in webkit [204440] by
-
- 6 edits in trunk/Source
Remove always true JSC::Debugger::needPauseHandling virtual method
https://bugs.webkit.org/show_bug.cgi?id=160822
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Mark Lam.
Source/JavaScriptCore:
All subclasses return true for this method. Just remove the method.
- debugger/Debugger.cpp:
(JSC::Debugger::pauseIfNeeded):
- inspector/ScriptDebugServer.h:
Source/WebKit/mac:
- WebView/WebScriptDebugger.h:
- 7:14 PM Changeset in webkit [204439] by
-
- 35 edits6 adds in trunk
Inline store loop for CopyRest in DFG and FTL for certain array modes
https://bugs.webkit.org/show_bug.cgi?id=159612
Reviewed by Filip Pizlo.
JSTests:
- stress/rest-parameter-having-a-bad-time.js: Added.
- stress/rest-parameter-many-arguments.js: Added.
- stress/rest-parameter-various-types.js: Added.
Source/JavaScriptCore:
This patch changes the old copy_rest bytecode to actually allocate the rest array itself.
The bytecode is now called create_rest with an analogous CreateRest node in the DFG/FTL.
This allows the bytecode to be in control of what type of indexingType the array is allocated
with. We always allocate using ArrayWithContiguous storage unless we're havingABadTime().
This also makes allocating and writing into the array fast. On the fast path, the DFG/FTL
JIT will fast allocate the array and its storage, and we will do a memmove from the rest
region of arguments into the array's storage.
I'm seeing a 1-2% speedup on ES6SampleBench, and about a 2x speedup
on micro benchmarks that just test rest creation speed.
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitRestParameter):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::uses):
(JSC::DFG::Graph::isWatchingHavingABadTimeWatchpoint):
(JSC::DFG::Graph::compilation):
- dfg/DFGNode.h:
(JSC::DFG::Node::numberOfArgumentsToSkip):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCreateClonedArguments):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileGetRestLength):
(JSC::DFG::SpeculativeJIT::compileCopyRest): Deleted.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileGetRestLength):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileAllocateArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileCopyRest): Deleted.
- interpreter/CallFrame.h:
(JSC::ExecState::addressOfArgumentsStart):
(JSC::ExecState::argument):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_argument_count):
(JSC::JIT::emit_op_create_rest):
(JSC::JIT::emit_op_copy_rest): Deleted.
- jit/JITOperations.h:
- llint/LowLevelInterpreter.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
LayoutTests:
- js/regress/rest-parameter-construction-performance-expected.txt: Added.
- js/regress/rest-parameter-construction-performance.html: Added.
- js/regress/script-tests/rest-parameter-construction-performance.js: Added.
(foo):
(test1):
(test2.foo):
(test2):
- 7:02 PM Changeset in webkit [204438] by
-
- 7 edits in trunk/Source/JavaScriptCore
Add a helper class for enumerating elements in an iterable object
https://bugs.webkit.org/show_bug.cgi?id=160800
Reviewed by Benjamin Poulain.
Added iteratorForIterable which provides an abstraction for iterating over an iterable object,
and deployed it in the constructors of Set, WeakSet, Map, and WeakMap.
Also added a helper function iteratorForIterable, which retrieves the iterator out of an iterable object.
- runtime/IteratorOperations.cpp:
(JSC::iteratorForIterable): Added.
- runtime/IteratorOperations.h:
(JSC::forEachInIterable): Added.
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/SetConstructor.cpp:
(JSC::constructSet):
- runtime/WeakMapConstructor.cpp:
(JSC::constructWeakMap):
- runtime/WeakSetConstructor.cpp:
(JSC::constructWeakSet):
- 5:56 PM Changeset in webkit [204437] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add application/vnd.api+json as a valid JSON MIME-type
https://bugs.webkit.org/show_bug.cgi?id=160834
rdar://problem/27608536
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CodeMirrorAdditions.js: Add Add application/vnd.api+json to extraJSONTypes.
- 5:11 PM Changeset in webkit [204436] by
-
- 1 copy in tags/Safari-602.1.50.0.2
New tag.
- 5:08 PM Changeset in webkit [204435] by
-
- 1 copy in tags/Safari-602.1.50.1.2
New tag.
- 4:54 PM Changeset in webkit [204434] by
-
- 8 edits27545 adds1 delete in branches/safari-602-branch
Merge r203972.
2016-08-01 Keith Miller <keith_miller@apple.com>
We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372
Rubber stamped by Geoffrey Garen.
This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.
- JSTests/: Copied from Source/JavaScriptCore/tests.
- Source/JavaScriptCore/tests/: Deleted.
- Scripts/import-test262-tests:
- Scripts/run-javascriptcore-tests:
- Scripts/update-javascriptcore-test-res:
- 4:35 PM Changeset in webkit [204433] by
-
- 4 edits in trunk/Source/WTF
Make variant only available when compiling for C++14 or greater
https://bugs.webkit.org/show_bug.cgi?id=160813
Patch by Sam Weinig <sam@webkit.org> on 2016-08-12
Reviewed by Anders Carlsson.
- wtf/Compiler.h:
- wtf/StdLibExtras.h:
- wtf/Variant.h:
- 4:34 PM Changeset in webkit [204432] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Instances of WKObject subclasses don’t work correctly with CFGetTypeID()
https://bugs.webkit.org/show_bug.cgi?id=160820
<rdar://problem/27825875>
Reviewed by Anders Carlsson.
- Shared/Cocoa/WKObject.mm:
(-[WKObject _cfTypeID]): Override this internal method and forward to the target object.
- 4:12 PM Changeset in webkit [204431] by
-
- 5 edits in trunk
Make URLParser work with URLs missing URL parts
https://bugs.webkit.org/show_bug.cgi?id=160824
Reviewed by Brady Eidson.
Source/WebCore:
My initial implementation of URLParser didn't work correctly with URLs missing parts,
like a URL with no fragment, or a URL with no query. This fixes and tests parsing such URLS.
Covered by new API tests.
- platform/URLParser.cpp:
(WebCore::URLParser::parse):
(WebCore::URLParser::allValuesEqual):
- platform/URLParser.h:
(WebCore::URLParser::parse):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::s):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::eq): Deleted.
- 4:08 PM Changeset in webkit [204430] by
-
- 2 edits in trunk/Tools
Add HashCountedSet API tests to TestWTFLibrary target
https://bugs.webkit.org/show_bug.cgi?id=160815
Reviewed by Alex Christensen.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Added HashCountedSet.cpp and sorted the file reference section
according to UNIX sort.
- 3:55 PM WebKitIDL edited by
- (diff)
- 3:53 PM Changeset in webkit [204429] by
-
- 27 edits4 moves in trunk/Source
Rename DocumentLoadTiming and ResourceLoadTiming
https://bugs.webkit.org/show_bug.cgi?id=160821
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-12
Reviewed by Alex Christensen.
Source/WebCore:
Renames ResourceLoadTiming to NetworkLoadTiming.
Renames DocumentLoadTiming to LoadTiming as well as
navigationStart() to startTime(), so it's generic for
both the main resource and subresources.
- CMakeLists.txt:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
- PlatformMac.cmake:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorNetworkAgent.cpp:
(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceResponse):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::timing):
(WebCore::DocumentLoader::resetTiming):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
- loader/LoadTiming.cpp: Renamed from Source/WebCore/loader/DocumentLoadTiming.cpp.
(WebCore::LoadTiming::LoadTiming):
(WebCore::LoadTiming::monotonicTimeToZeroBasedDocumentTime):
(WebCore::LoadTiming::monotonicTimeToPseudoWallTime):
(WebCore::LoadTiming::markStartTime):
(WebCore::LoadTiming::addRedirect):
- loader/LoadTiming.h: Renamed from Source/WebCore/loader/DocumentLoadTiming.h.
(WebCore::LoadTiming::markUnloadEventStart):
(WebCore::LoadTiming::markUnloadEventEnd):
(WebCore::LoadTiming::markRedirectStart):
(WebCore::LoadTiming::markRedirectEnd):
(WebCore::LoadTiming::markFetchStart):
(WebCore::LoadTiming::setResponseEnd):
(WebCore::LoadTiming::markLoadEventStart):
(WebCore::LoadTiming::markLoadEventEnd):
(WebCore::LoadTiming::setHasSameOriginAsPreviousDocument):
(WebCore::LoadTiming::startTime):
(WebCore::LoadTiming::unloadEventStart):
(WebCore::LoadTiming::unloadEventEnd):
(WebCore::LoadTiming::redirectStart):
(WebCore::LoadTiming::redirectEnd):
(WebCore::LoadTiming::redirectCount):
(WebCore::LoadTiming::fetchStart):
(WebCore::LoadTiming::responseEnd):
(WebCore::LoadTiming::loadEventStart):
(WebCore::LoadTiming::loadEventEnd):
(WebCore::LoadTiming::hasCrossOriginRedirect):
(WebCore::LoadTiming::hasSameOriginAsPreviousDocument):
(WebCore::LoadTiming::referenceMonotonicTime):
(WebCore::LoadTiming::referenceWallTime):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
- page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::redirectCount):
- page/PerformanceResourceTiming.cpp:
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):
- page/PerformanceResourceTiming.h:
- page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::navigationStart):
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::connectEnd):
(WebCore::PerformanceTiming::secureConnectionStart):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::loadTiming):
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds):
- page/PerformanceTiming.h:
- platform/network/NetworkLoadTiming.h: Renamed from Source/WebCore/platform/network/ResourceLoadTiming.h.
(WebCore::NetworkLoadTiming::NetworkLoadTiming):
(WebCore::NetworkLoadTiming::operator=):
(WebCore::NetworkLoadTiming::isolatedCopy):
(WebCore::NetworkLoadTiming::operator==):
(WebCore::NetworkLoadTiming::operator!=):
(WebCore::NetworkLoadTiming::encode):
(WebCore::NetworkLoadTiming::decode):
- platform/network/ResourceHandle.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::compare):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::networkLoadTiming):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
- platform/network/cocoa/NetworkLoadTiming.mm: Renamed from Source/WebCore/platform/network/cocoa/ResourceLoadTiming.mm.
(WebCore::timingValue):
(WebCore::copyTimingData):
(WebCore::setCollectsTimingData):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::calculateWebTimingInformations):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::getConnectionTimingData):
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::didStartRequest):
(WebCore::networkEventCallback):
Source/WebKit2:
Rename ResourceLoadTiming to NetworkLoadTiming.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
- 3:32 PM Changeset in webkit [204428] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Command-Shift-O causes infinite loop if web page has frames
https://bugs.webkit.org/show_bug.cgi?id=160810
Reviewed by Joseph Pecoraro.
- UserInterface/Views/OpenResourceDialog.js:
(WebInspector.OpenResourceDialog.prototype._addResourcesForFrame):
"frame" doesn't change inside the loop.
- 3:02 PM Changeset in webkit [204427] by
-
- 8 edits in branches/safari-602-branch/Source/WebKit2
Merge r204414. rdar://problem/27624095
- 2:56 PM Changeset in webkit [204426] by
-
- 8 edits in branches/safari-602.1.50.1-branch/Source/WebKit2
Merge r204414. rdar://problem/27624095
- 2:53 PM Changeset in webkit [204425] by
-
- 8 edits in branches/safari-602.1.50.0-branch/Source/WebKit2
Merge r204414. rdar://problem/27624095
- 2:46 PM Changeset in webkit [204424] by
-
- 6 edits in trunk/Source
Remove unused includes of RefCountedLeakCounter.h
https://bugs.webkit.org/show_bug.cgi?id=160817
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Mark Lam.
Source/JavaScriptCore:
- parser/Nodes.cpp:
- runtime/Structure.cpp:
Source/WebCore:
- bindings/js/JSEventListener.cpp:
- rendering/RenderBlockLineLayout.cpp:
- 2:38 PM Changeset in webkit [204423] by
-
- 1 edit1 add in trunk/LayoutTests
Add mac-wk1 baseline for js/dom/global-constructors-attributes.html after r204396.
Unreviewed test gardening.
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt: Added.
- 2:38 PM Changeset in webkit [204422] by
-
- 3 edits3 adds in trunk
ASSERTION FAILED: : line >= firstLine in BytecodeGenerator::emitExpressionInfo.
https://bugs.webkit.org/show_bug.cgi?id=160535
<rdar://problem/27328151>
Source/JavaScriptCore:
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.
lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token
- parser/Parser.h:
(JSC::Parser::restoreLexerState):
LayoutTests:
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.
lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token
- js/multiline-function-crash-expected.txt: Added.
- js/multiline-function-crash.html: Added.
- js/script-tests/multiline-function-crash.js: Added.
- 2:24 PM Changeset in webkit [204421] by
-
- 3 edits in trunk/Tools
run-benchmark should run JetStream 1.1 instead of 1.0.1
https://bugs.webkit.org/show_bug.cgi?id=160816
Reviewed by Filip Pizlo.
Use the latest JetStream 1.1 in run-benchmark.
- Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder.exit):
- Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
- Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
change to JetStream directory.
- 2:09 PM Changeset in webkit [204420] by
-
- 1 edit3 deletes in trunk/LayoutTests
Unreviewed, rolling out r204416.
This test fails with a debug assertion
Reverted changeset:
"ASSERTION FAILED: : line >= firstLine in
BytecodeGenerator::emitExpressionInfo."
https://bugs.webkit.org/show_bug.cgi?id=160535
http://trac.webkit.org/changeset/204416
- 1:46 PM Changeset in webkit [204419] by
-
- 8 edits1 add in trunk
[ES2016] Implement Object.entries
https://bugs.webkit.org/show_bug.cgi?id=160412
Reviewed by Saam Barati.
This patch adds entries function to Object that returns list of
key+values pairs. Patch did according to the point of
spec https://tc39.github.io/ecma262/#sec-object.entries
Source/JavaScriptCore:
- builtins/ObjectConstructor.js:
(globalPrivate.enumerableOwnProperties):
(entries):
- runtime/ObjectConstructor.cpp:
JSTests:
- stress/object-entries.js:
(compare):
(string_appeared_here.forEach):
(const.getInvokedFunctions.):
(const.getInvokedFunctions):
(Array.prototype.push):
- stress/object-values.js:
- 1:34 PM Changeset in webkit [204418] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Support for :lineNumber syntax in Open Resource Dialog
https://bugs.webkit.org/show_bug.cgi?id=159732
<rdar://problem/27684491>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Matt Baker.
Allow the Open Resource Dialog to support line/column syntax.
Other tools allow "<name>:<line>:<column>" syntax, where the
location data at the end is optional. If the <name> portion
is missing, the location can be used for the active content
view, assuming it has text data and has lines.
- UserInterface/Base/Main.js:
(WebInspector.focusedOrVisibleContentView):
Expose a function to access the current focused / visible content view.
(WebInspector.dialogWasDismissed):
Include passing on cookie data when showing a represented object.
- UserInterface/Views/Dialog.js:
(WebInspector.Dialog):
(WebInspector.Dialog.prototype.get visible):
(WebInspector.Dialog.prototype.get delegate):
(WebInspector.Dialog.prototype.get representedObject):
(WebInspector.Dialog.prototype.get cookie):
(WebInspector.Dialog.prototype.dismiss):
- UserInterface/Models/ResourceQueryResult.js:
(WebInspector.ResourceQueryResult):
(WebInspector.ResourceQueryResult.prototype.get cookie):
Include cookie data along with the represented object in matches
and dialog results.
- UserInterface/Controllers/ResourceQueryController.js:
(WebInspector.ResourceQueryController.prototype.executeQuery):
Cut off location data from a query, and stash it on the query result.
A query can be "<name>:<line>:<column>", and the line/column data
becomes cookie data for the resource.
- UserInterface/Views/OpenResourceDialog.js:
(WebInspector.OpenResourceDialog.prototype._populateResourceTreeOutline):
If the query is just ":<line>:<column>" have it jump to a location
in the current content view if applicable.
(WebInspector.OpenResourceDialog.prototype._handleKeydownEvent):
(WebInspector.OpenResourceDialog.prototype._treeSelectionDidChange):
When dismissing, include cookie data.
- 1:03 PM Changeset in webkit [204417] by
-
- 4 edits in trunk
Initial URLParser implementation
https://bugs.webkit.org/show_bug.cgi?id=160811
Reviewed by Brady Eidson.
Source/WebCore:
There are a lot of missing parts, but it works in one case, so I test that one case.
- platform/URLParser.cpp:
(WebCore::isC0Control):
(WebCore::isC0ControlOrSpace):
(WebCore::isTabOrNewline):
(WebCore::isASCIIDigit):
(WebCore::isASCIIAlpha):
(WebCore::isASCIIAlphanumeric):
(WebCore::isSpecialScheme):
(WebCore::URLParser::parse):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::eq):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
- 11:53 AM Changeset in webkit [204416] by
-
- 1 edit3 adds in trunk/LayoutTests
ASSERTION FAILED: : line >= firstLine in BytecodeGenerator::emitExpressionInfo.
https://bugs.webkit.org/show_bug.cgi?id=160535
<rdar://problem/27328151>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.
lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token
- js/multiline-function-crash-expected.txt: Added.
- js/multiline-function-crash.html: Added.
- js/script-tests/multiline-function-crash.js: Added.
- 11:51 AM Changeset in webkit [204415] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test for fixed nullptr deref error
https://bugs.webkit.org/show_bug.cgi?id=160807
<rdar://problem/15576693>
Unreviewed test gardening.
- mathml/row-clone-crash-expected.txt: Added.
- mathml/row-clone-crash.html: Added.
- 11:50 AM Changeset in webkit [204414] by
-
- 8 edits in trunk/Source/WebKit2
message loading never finishes in Mail
https://bugs.webkit.org/show_bug.cgi?id=160806
rdar://problem/27624095
Reviewed by Dan Bernstein.
Add more checks for when a process goes away before we've established a proper connection to it.
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::receiveSourceEventHandler):
Handle the MACH_NOTIFY_NO_SENDERS and MACH_NOTIFY_SEND_ONCE messages here. Also, once we receive a send
right from the other side, stop listening for the MACH_NOTIFY_NO_SENDERS notification.
- UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching):
Null check the connection identifier.
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::ProcessLauncher):
(WebKit::processLauncherWorkQueue): Deleted.
Get rid of the process launcher queue - we're not doing any blocking work here.
- UIProcess/Launcher/ProcessLauncher.h:
Add a weak factory.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::systemDirectoryPath):
Move this before launchProcess().
(WebKit::ProcessLauncher::launchProcess):
Merge createService and connectToService into launchProcess. Also make the following changes:
- Use mach_port_request_notification to get a notification for when our receive right loses all its senders.
This lets us listen for the other process going away before we have a send right for it.
- Use xpc_connection_set_event_handler to listen for errors, so we can detect the process going away before
we've sent a message to it.
(WebKit::connectToService): Deleted.
(WebKit::createService): Deleted.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching):
If we failed to launch, call networkProcessCrashedOrFailedToLaunch so we'll unblock any waiting web processes.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching):
Null check the connection and XPC connection before trying to get its pid.
- 9:54 AM Changeset in webkit [204413] by
-
- 3 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html after r204396.
Unreviewed test gardening.
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 9:51 AM Changeset in webkit [204412] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r204404.
https://bugs.webkit.org/show_bug.cgi?id=160805
"Broke the build for some Apple Internal projects" (Requested
by bradee-oh on #webkit).
Reverted changeset:
"Support WebIDL unions (Part 1)"
https://bugs.webkit.org/show_bug.cgi?id=160769
http://trac.webkit.org/changeset/204404
- 8:55 AM Changeset in webkit [204411] by
-
- 3 edits in trunk/Tools
Fix the 32-bit Mac build after:
Add WK2 ExperimentalFeature support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=160788
Reviewed by NOBODY (OOPS!).
Sprinkle "#if WK_API_ENABLED"s liberally.
- MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
- 3:38 AM Changeset in webkit [204410] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Performance problems with bigger video resolution in the webrtc media player
https://bugs.webkit.org/show_bug.cgi?id=153826
Reviewed by Alejandro G. Castro.
Keep the OpenWebRTC video renderer size synchronized with the Media element size.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::setSize):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
- 3:35 AM Changeset in webkit [204409] by
-
- 6 edits in trunk
[GStreamer][OWR] Video rendering fixes
https://bugs.webkit.org/show_bug.cgi?id=160764
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
The video renderer of OpenWebRTC now uses OpenGL so we have two
options to correctly handle this in WebKit:
- if USE_GSTREAMER_GL is enabled then we simply pass our GL appsink to the renderer and there is no need to create glupload and glcolorconvert element on WebKit side because those elements are already created on OpenWebRTC side.
- if USE_GSTREAMER_GL is disabled then we need our sink to download frames from the GPU so that rendering can be done with the WebKit video sink in main memory.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink): Split out GL appsink management
to a separate method that can be used by sub-classes.
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL): Use new createGLAppSink method.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink): handle GStreamer-GL configurations
and pass a different element to the renderer depending on the configuration.
Tools:
- gtk/jhbuild.modules: Bump to current OpenWebRTC master.
- 2:11 AM Changeset in webkit [204408] by
-
- 2 edits in trunk/Tools
Add missing return statement in convertFast function added in r204376.
Unreviewed.
- Scripts/webkitpy/common/system/path.py:
(_CygPath.convertFast):
Aug 11, 2016:
- 10:52 PM Changeset in webkit [204407] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 9:55 PM Changeset in webkit [204406] by
-
- 1 copy in tags/Safari-603.1.2
New tag.
- 9:55 PM Changeset in webkit [204405] by
-
- 1 delete in tags/Safari-603.1.2
Delete tag.
- 9:34 PM Changeset in webkit [204404] by
-
- 2 edits in trunk/Source/WebCore
Support WebIDL unions (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=160769
Reviewed by Chris Dumez.
This is the first part of an effort to add support for union types
in our code generators. This change:
- Adds a domType struct to hold the parsed type information. For now, we only use it temporarily while parsing, and don't expose it to the code generators, but that will change in a later patch.
- Remove support for scoped identifiers for types. They are not supported by WebIDL.
- Make debugging the parser easier by providing backtraces when asserting.
There should be no observable changes.
- bindings/scripts/IDLParser.pm:
- 8:38 PM Changeset in webkit [204403] by
-
- 3 edits1 add in trunk
OverridesHasInstance should not branch across register allocations.
https://bugs.webkit.org/show_bug.cgi?id=160792
<rdar://problem/27361778>
Reviewed by Benjamin Poulain.
JSTests:
- stress/OverrideHasInstance-should-not-branch-across-register-allocations.js: Added.
Source/JavaScriptCore:
The OverrideHasInstance node has a branch test that is emitted conditionally.
It also has a bug where it allocated a register after this branch, which is not
allowed and would fail an assertion introduced in https://trac.webkit.org/r145931.
From the ChangeLog for r145931:
"This [assertion that register allocations are not branched around] protects
against the case where an allocation could have spilled register contents to free
up a register and that spill only occurs on one path of many through the code.
A subsequent fill of the spilled register may load garbage."
Because the branch isn't always emitted, this bug has gone unnoticed until now.
This patch fixes this issue by pre-allocating the registers before emitting the
branch in OverrideHasInstance.
Note: this issue is only present in DFGSpeculativeJIT64.cpp. The 32-bit version
is doing it right.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:33 PM Changeset in webkit [204402] by
-
- 8 edits in trunk/Source/JavaScriptCore
[JSC] Make B3 Return opcode work without arguments
https://bugs.webkit.org/show_bug.cgi?id=160787
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-11
Reviewed by Keith Miller.
We need a way to create functions that do not return values.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::retVoid):
- b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::appendNewControlValue):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Validate.cpp:
- b3/B3Value.h:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testReturnVoid):
(JSC::B3::run):
- 6:29 PM Changeset in webkit [204401] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Don't monitor gamepads at all unless an interested WebPageProxy is in the active window.
https://bugs.webkit.org/show_bug.cgi?id=160760
Reviewed by Tim Horton.
This patch makes it such that the UIProcess will only listen to the platform gamepad mechanism
if a WebPageProxy that is interested in gamepads is in the active window.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::windowDidBecomeKey):
(WebKit::WebViewImpl::windowDidResignKey):
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::UIGamepadProvider):
(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::scheduleGamepadStateSync):
(WebKit::UIGamepadProvider::platformGamepadConnected):
(WebKit::UIGamepadProvider::platformGamepadDisconnected):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):
(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::viewBecameActive):
(WebKit::UIGamepadProvider::viewBecameInactive):
(WebKit::UIGamepadProvider::scheduleDisableGamepadMonitoring):
(WebKit::UIGamepadProvider::disableMonitoringTimerFired):
(WebKit::UIGamepadProvider::startMonitoringGamepads):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::updateTimerFired): Deleted.
(WebKit::UIGamepadProvider::startOrStopSynchingGamepadState): Deleted.
- UIProcess/Gamepad/UIGamepadProvider.h:
- 6:22 PM Changeset in webkit [204400] by
-
- 52 edits in trunk/Source/WebCore
Migrate from ints to unsigneds when referring to indices into strings
https://bugs.webkit.org/show_bug.cgi?id=160735
Reviewed by Simon Fraser.
There are a few cases where we use ints to refer to indices into strings:
- A simple historical accident. These were migrated to unsigneds directly.
- Where we use -1 as a sentinal value. These were migrated to Optional<unsigned>.
This patch only modifies rendering code (rather than DOM code). There are a few
places in DOM code (such as Position and Node::maxCharacterOffset()) which also
erroneously use ints; however, I didn't want this change to be observable from
script and I wanted to keep this patch to a reasonable size.
No new tests because there is no behavior change.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::setCaretVisibility):
- platform/DragImage.cpp:
(WebCore::createDragImageForRange):
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::glyphBufferForTextRun):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
(WebCore::FontCascade::getGlyphsAndAdvancesForSimpleText):
(WebCore::FontCascade::drawEmphasisMarksForSimpleText):
(WebCore::FontCascade::drawGlyphBuffer):
(WebCore::offsetToMiddleOfGlyphAtIndex):
(WebCore::FontCascade::adjustSelectionRectForSimpleText):
- platform/graphics/FontCascade.h:
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontAt):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::shrink):
(WebCore::GlyphBuffer::swap):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawGlyphs):
(WebCore::GraphicsContext::drawEmphasisMarks):
- platform/graphics/GraphicsContext.h:
- platform/graphics/Latin1TextIterator.h:
(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):
- platform/graphics/SurrogatePairAwareTextIterator.h:
(WebCore::SurrogatePairAwareTextIterator::currentCharacter):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):
- platform/graphics/WidthIterator.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsToContext):
(WebCore::drawGlyphsShadow):
(WebCore::FontCascade::drawGlyphs):
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):
(WebCore::FontCascade::adjustSelectionRectForComplexText):
- platform/graphics/cocoa/FontCascadeCocoa.mm:
(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::showGlyphsWithAdvances):
(WebCore::FontCascade::drawGlyphs):
(WebCore::FontCascade::dashesForIntersectionsWithRect):
(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawGlyphs):
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect):
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/win/FontCGWin.cpp:
(WebCore::FontCascade::drawGlyphs):
- platform/graphics/win/FontWin.cpp:
(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paintSelection):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::clampedOffset):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::positionForOffset):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::offsetRun):
(WebCore::InlineTextBox::InlineTextBox): Deleted.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::localCaretRect):
- rendering/RenderInline.h:
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::localCaretRect):
- rendering/RenderLineBreak.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionStartEnd):
(WebCore::RenderObject::localCaretRect):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::isSelected):
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
- rendering/RenderText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::setSelectionState):
- rendering/RenderView.cpp:
(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):
(WebCore::RenderView::getSelection):
(WebCore::RenderView::clearSelection):
(WebCore::RenderView::RenderView): Deleted.
- rendering/RenderView.h:
- rendering/SelectionSubtreeRoot.cpp:
(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot): Deleted.
- rendering/SelectionSubtreeRoot.h:
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionClear):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartEndPositions):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::clearSelection):
(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData): Deleted.
- rendering/TextPainter.cpp:
(WebCore::TextPainter::drawTextOrEmphasisMarks):
(WebCore::TextPainter::paintTextWithShadows):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintText):
- rendering/TextPainter.h:
(WebCore::TextPainter::addEmphasis):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintTextWithShadows):
(WebCore::SVGInlineTextBox::paintText):
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::calculateGlyphBoundaries):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):
- rendering/svg/SVGTextQuery.h:
- 6:12 PM Changeset in webkit [204399] by
-
- 1 copy in tags/Safari-602.2.1
New tag.
- 6:02 PM Changeset in webkit [204398] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: fix gcc builds after r204387.
Not reviewed.
Apparently, gcc is not sophisticated enough to realize that the end of the
function is unreachable, and is wrongly complaining about "control reaches end of
non-void function". I'm restoring the RELEASE_ASSERT_NOT_REACHED() and return
statement at the end of MarkedBlock::sweepHelper() to appease gcc.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper):
- 5:35 PM Changeset in webkit [204397] by
-
- 4 edits in trunk/Tools
Add WK2 ExperimentalFeature support to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=160788
Reviewed by Alex Christensen.
- MiniBrowser/mac/AppDelegate.h:
- MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
(defaultPreferences):
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleExperimentalFeature:]):
- 5:35 PM Changeset in webkit [204396] by
-
- 2 edits in trunk/Source/WebKit2
Make Gamepads be a WK2 ExperimentalFeature.
https://bugs.webkit.org/show_bug.cgi?id=160788
Reviewed by Alex Christensen.
- Shared/WebPreferencesDefinitions.h:
- 5:34 PM Changeset in webkit [204395] by
-
- 12 edits in trunk/Source
Don't use a NetworkingContext when creating SocketStreamHandles
https://bugs.webkit.org/show_bug.cgi?id=160732
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-11
Reviewed by Brady Eidson.
Source/WebCore:
No change in behavior. After r204327 a SessionID is all we need to get the NetworkStorageSession,
and we pass the SessionID to the SocketStreamHandle constructor, so use that instead.
SessionIDs can be serialized and sent over IPC. NetworkingContexts can't.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
- page/SocketProvider.cpp:
(WebCore::SocketProvider::createSocketStreamHandle):
- page/SocketProvider.h:
- platform/network/cf/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::getStoredCONNECTProxyCredentials):
- platform/network/curl/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
- platform/network/soup/SocketStreamHandle.h:
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::create):
Source/WebKit2:
- WebProcess/Network/WebSocketProvider.cpp:
(WebKit::WebSocketProvider::createSocketStreamHandle):
- WebProcess/Network/WebSocketProvider.h:
- 5:33 PM Changeset in webkit [204394] by
-
- 21 edits in trunk/Source
Use StringBuilder::appendLiteral when possible don't append result of makeString
https://bugs.webkit.org/show_bug.cgi?id=160772
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-11
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- API/tests/ExecutionTimeLimitTest.cpp:
(testExecutionTimeLimit):
- API/tests/PingPongStackOverflowTest.cpp:
(PingPongStackOverflowObject_hasInstance):
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::toString):
(JSC::RestParameterNode::toString):
- runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::sanitizedToString):
- runtime/Options.cpp:
(JSC::Options::dumpOption):
Source/WebCore:
StringBuilder::append does an unnecessary strlen call.
append(makeString(...)) always does unnecessary allocations and copies.
It's currently only used in debug logging, but we shouldn't have this pattern in WebKit.
- Modules/indexeddb/server/IndexValueStore.cpp:
(WebCore::IDBServer::IndexValueStore::loggingString):
- Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::loggingString):
- Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:
(WebCore::IDBObjectStoreInfo::loggingString):
- contentextensions/CombinedURLFilters.cpp:
(WebCore::ContentExtensions::prefixTreeVertexToString):
(WebCore::ContentExtensions::recursivePrint):
- html/HTMLMediaElement.cpp:
(WebCore::actionName):
- html/MediaElementSession.cpp:
(WebCore::restrictionName):
- loader/ResourceLoadStatistics.cpp:
(WebCore::appendBoolean):
(WebCore::appendHashCountedSet):
(WebCore::ResourceLoadStatistics::toString):
- platform/PODInterval.h:
(WebCore::PODInterval::toString):
- platform/URL.cpp:
(WebCore::URL::setHost):
(WebCore::URL::setHostAndPort):
(WebCore::URL::serialize):
- testing/Internals.cpp:
(WebCore::appendOffsets):
(WebCore::Internals::scrollSnapOffsets):
Source/WebKit2:
- Shared/Gamepad/GamepadData.cpp:
(WebKit::GamepadData::isNull):
(WebKit::GamepadData::loggingString):
- Shared/Gamepad/GamepadData.h:
- UIProcess/WebProcessPool.h:
- 5:22 PM Changeset in webkit [204393] by
-
- 13 edits4 adds in trunk/Source/JavaScriptCore
[JSC] Revert most of r203808
https://bugs.webkit.org/show_bug.cgi?id=160784
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-11
Reviewed by Geoffrey Garen.
Switching to fastMalloc() caused regressions on Jetstream and Octane
on MacBook Air. I was able to get back some of it in the following
patches but the tests that never go to FTL are still regressed.
This patch revert r203808 except of the node index.
Nodes are allocated with the custom allocator like before but they are
now also kept in a table, addressed by the node index.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3SparseCollection.h:
(JSC::B3::SparseCollection::packIndices): Deleted.
- dfg/DFGAllocator.h: Added.
(JSC::DFG::Allocator::Region::size):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::Allocator::Region::regionFor):
(JSC::DFG::Allocator<T>::Allocator):
(JSC::DFG::Allocator<T>::~Allocator):
(JSC::DFG::Allocator<T>::allocate):
(JSC::DFG::Allocator<T>::free):
(JSC::DFG::Allocator<T>::freeAll):
(JSC::DFG::Allocator<T>::reset):
(JSC::DFG::Allocator<T>::indexOf):
(JSC::DFG::Allocator<T>::allocatorOf):
(JSC::DFG::Allocator<T>::bumpAllocate):
(JSC::DFG::Allocator<T>::freeListAllocate):
(JSC::DFG::Allocator<T>::allocateSlow):
(JSC::DFG::Allocator<T>::freeRegionsStartingAt):
(JSC::DFG::Allocator<T>::startBumpingIn):
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(JSC::DFG::Graph::addNodeToMapByIndex):
(JSC::DFG::Graph::deleteNode):
(JSC::DFG::Graph::packNodeIndices):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::addNode):
(JSC::DFG::Graph::maxNodeCount):
(JSC::DFG::Graph::nodeAt):
- dfg/DFGLongLivedState.cpp: Added.
(JSC::DFG::LongLivedState::LongLivedState):
(JSC::DFG::LongLivedState::~LongLivedState):
(JSC::DFG::LongLivedState::shrinkToFit):
- dfg/DFGLongLivedState.h: Added.
- dfg/DFGNode.h:
- dfg/DFGNodeAllocator.h: Added.
(operator new ):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::runThread):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 5:08 PM Changeset in webkit [204392] by
-
- 2 edits in trunk/LayoutTests
Marking transitions/clip-path-transitions.html and transitions/clip-path-path-transitions.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=153809
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:05 PM Changeset in webkit [204391] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r204264): Web Inspector: Uncaught Exception in Network tab when reloading a web page
https://bugs.webkit.org/show_bug.cgi?id=160781
<rdar://problem/27810452>
Reviewed by Matt Baker.
WebInspector.TimelineDataGrid.prototype.closed was removed in r204264.
Define a stub method on DataGrid so it's available to all its subclasses.
- UserInterface/Views/DataGrid.js:
this._dataGrid.closed()
- 3:27 PM Changeset in webkit [204390] by
-
- 6 edits1 add5 deletes in trunk
Align Range.surroundContents() with the latest DOM specification
https://bugs.webkit.org/show_bug.cgi?id=160777
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that all checks are passing.
- web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:
Source/WebCore:
Align Range.surroundContents() with the latest DOM specification:
In particular, the following changes were made:
- Drop early check to see if startContainer() accepts children like newParent. This check is not in the specification. Let the later call to Range.insertNode() take care of doing the check and throwing.
- Drop early check to see if newParent contains the range's start node, for the same reasons as above.
- Move extractContents() call *before* removing newParent's children to match the order in the specification (steps 3 & 4).
This makes our behavior much closer to Firefox's as well.
No new tests, rebaselined existing W3C test.
- dom/Range.cpp:
(WebCore::Range::surroundContents):
LayoutTests:
Rebaseline existing due to behavior change.
- fast/dom/Range/surroundContents-1-expected.txt:
- fast/dom/Range/surroundContents-1.html:
- 2:25 PM Changeset in webkit [204389] by
-
- 2 edits in trunk/Tools
Keep EWS logs for longer
https://bugs.webkit.org/show_bug.cgi?id=160776
Reviewed by Daniel Bates.
- EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
- 2:21 PM Changeset in webkit [204388] by
-
- 4 edits in trunk
The jsc shell's Element host constructor should throw if it fails to construct an object.
https://bugs.webkit.org/show_bug.cgi?id=160773
<rdar://problem/27328608>
Reviewed by Saam Barati.
JSTests:
- stress/generational-opaque-roots.js:
Source/JavaScriptCore:
The Element object is a test object provided in the jsc shell for testing use only.
JavaScriptCore expects host constructors to either throw an error or return a
constructed object. Element has a host constructor that did not obey this contract.
As a result, the following statement will fail a RELEASE_ASSERT:
new (Element.bind())
This is now fixed.
- jsc.cpp:
(functionCreateElement):
- 2:18 PM Changeset in webkit [204387] by
-
- 7 edits1 add in trunk
Disallow synchronous sweeping for eden GCs.
https://bugs.webkit.org/show_bug.cgi?id=160716
Reviewed by Geoffrey Garen.
JSTests:
- stress/eden-gc-with-retired-blocks.js: Added.
- This test is just in case we add back support for eden GCs with synchronous sweeping in the future.
Source/JavaScriptCore:
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collectAndSweep): Deleted.
- heap/Heap.h:
(JSC::Heap::collectAllGarbage): Deleted.
- No need for a separate collectAndSweep() anymore since we only call it for FullCollections.
- Since we've already swept all the blocks, I cleared m_blockSnapshot so that the IncrementalSweeper can bail earlier when it runs later.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper):
- Removed the unreachable return statement.
- heap/MarkedBlock.h:
- Document what "Retired" means.
- tools/JSDollarVMPrototype.cpp:
(JSC::JSDollarVMPrototype::edenGC):
- 2:17 PM Changeset in webkit [204386] by
-
- 5 edits2 deletes in trunk/Tools
iOS DRT/WTR project cleanup
https://bugs.webkit.org/show_bug.cgi?id=160778
Reviewed by Tim Horton.
Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
Remove AppDelegate.* which were unused.
Exclude ios/Launch.storyboard on more platforms.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
- WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
- WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
(-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
- 1:49 PM Changeset in webkit [204385] by
-
- 12 edits in trunk/LayoutTests
Rebaseline more iOS tests after r204363.
Unreviewed test gardening.
- fast/events/ios/keyboard-scrolling-distance-expected.txt:
- fast/events/ios/keyboard-should-not-trigger-resize-expected.txt:
- fast/forms/ios/accessory-bar-navigation-expected.txt:
- fast/forms/ios/focus-input-in-fixed-expected.txt:
- fast/forms/ios/focus-input-in-iframe-expected.txt:
- fast/forms/ios/focus-input-via-button-expected.txt:
- fast/forms/ios/focus-input-via-button-ipad-expected.txt:
- fast/forms/ios/focus-input-via-button-no-scaling-expected.txt:
- fast/forms/ios/focus-long-textarea-expected.txt:
- fast/forms/ios/zoom-after-input-tap-expected.txt:
- fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
- 1:21 PM Changeset in webkit [204384] by
-
- 2 edits in trunk/Tools
Fix Yosemite bots' cookie accept policies after r204365.
https://bugs.webkit.org/show_bug.cgi?id=160758
- TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
(TEST):
This makes the test fully clean up after itself.
- 1:20 PM Changeset in webkit [204383] by
-
- 2 edits in trunk/Tools
Fix Yosemite bots' cookie accept policies after r204365.
https://bugs.webkit.org/show_bug.cgi?id=160758
- TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
(TEST):
I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
causing any problems because there are no other API tests that do anything with cookies.
My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
to reset any bots that have run tests since r204365. I will commit a followup that sets it to originalCookieAcceptPolicy.
- 12:45 PM Changeset in webkit [204382] by
-
- 7 edits in trunk/Tools
EWS should check if the patch is still valid before executing every major step
https://bugs.webkit.org/show_bug.cgi?id=160739
rdar://problem/27768813
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run): validate method is now executed in base class.
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
(EarlyWarningSystemTask.run): validate method is now executed in base class.
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
- Scripts/webkitpy/tool/commands/perfalizer.py:
(PerfalizerTask.validate): Added.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_manual_reject_during_processing): Updated test case.
- 12:22 PM Changeset in webkit [204381] by
-
- 2 edits in trunk/Source/WebKit/mac
Regression(r204268): Mail crashes when trying to compose an email
https://bugs.webkit.org/show_bug.cgi?id=160775
Reviewed by Anders Carlsson.
Properly initialize PageConfiguration.pluginInfoProvider in
[WebView initSimpleHTMLDocumentWithStyle] to avoid a null
dereference in Mail when trying to compose an email.
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 12:09 PM Changeset in webkit [204380] by
-
- 8 edits3 adds in trunk
Add URLParser stub
https://bugs.webkit.org/show_bug.cgi?id=160770
Reviewed by Sam Weinig.
Source/WebCore:
Added API test stub.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/URL.h:
- platform/URLParser.cpp: Added.
(WebCore::URLParser::parse):
- platform/URLParser.h: Added.
(WebCore::URLParser::parse):
Tools:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
(TestWebKitAPI::TEST_F):
- 11:39 AM Changeset in webkit [204379] by
-
- 2 edits in trunk/Source/WTF
Add NSButtonType to AppKitCompatibilityDeclarations.h.
https://bugs.webkit.org/show_bug.cgi?id=160767.
Patch by Maureen Daum <mdaum@apple.com> on 2016-08-11
Reviewed by Dan Bernstein.
Add NSButtonType to AppKitCompatibilityDeclarations.h so that we can use the new
names but still build successfully on older OS versions.
- wtf/mac/AppKitCompatibilityDeclarations.h:
- 11:14 AM Changeset in webkit [204378] by
-
- 7 edits1 add1 delete in trunk/Tools
[iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
https://bugs.webkit.org/show_bug.cgi?id=160761
Reviewed by Tim Horton.
Give iOS DRT a Launch storyboard.
Have it use a UIViewController so future forms testing works correctly.
Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
can run in iPad mode.
Remove empty InfoPlist.strings files.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ios/Info.plist:
- DumpRenderTree/ios/Launch.storyboard: Added.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
- 10:48 AM Changeset in webkit [204377] by
-
- 8 edits in trunk
Move dataset attribute from Element to HTMLElement / SVGElement
https://bugs.webkit.org/show_bug.cgi?id=160766
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Move dataset attribute from Element to HTMLElement / SVGElement as per
the specifications:
- https://html.spec.whatwg.org/multipage/dom.html#htmlelement
- https://svgwg.org/svg2-draft/types.html#InterfaceSVGElement
Firefox and Chrome seem to have dataset on HTMLElement but not on
SVGElement (yet).
No new tests, rebaselined existing test.
- dom/Element.idl:
- html/HTMLElement.idl:
- svg/SVGElement.idl:
LayoutTests:
Rebaseline existing tests now that properties are in different order
when iterating.
- js/dom/dom-static-property-for-in-iteration-expected.txt:
- 10:42 AM Changeset in webkit [204376] by
-
- 2 edits in trunk/Tools
[Win] Unable to reliably run tests in parallel
https://bugs.webkit.org/show_bug.cgi?id=140914
Reviewed by Brent Fulgham.
The cygpath utility function can fail badly when running with multiple DumpRenderTree
processes. We can use string replacement to convert the Cygwin path to a Windows path
instead.
- Scripts/webkitpy/common/system/path.py:
(cygpathFast):
- Scripts/webkitpy/port/driver.py:
(Driver._command_from_driver_input):
- 9:34 AM Changeset in webkit [204375] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, update MediaRemoteSPI.h after r204082.
- platform/spi/mac/MediaRemoteSPI.h:
- 6:55 AM Changeset in webkit [204374] by
-
- 2 edits in trunk/LayoutTests
Unskip 2d.gradient.interpolate.colouralpha on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=160765
<rdar://problem/24025664>
Patch by Antoine Quint <Antoine Quint> on 2016-08-11
Reviewed by Eric Carlson.
We fixed the tests in https://bugs.webkit.org/show_bug.cgi?id=160689 but forgot to unskip them.
- platform/mac/TestExpectations:
- 5:02 AM Changeset in webkit [204373] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=160734
Reviewed by Sam Weinig.
Add static cast from int to uint32_t.
- bytecode/ArithProfile.h:
- 4:26 AM Changeset in webkit [204372] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] German translation update
https://bugs.webkit.org/show_bug.cgi?id=152228
Rubber-Stamped by Michael Catanzaro.
Patch by Bernd Homuth <dev@hmt.im> on 2016-08-11
- de.po: Update to reviewed translation from 2016-08-05.
- 3:22 AM Changeset in webkit [204371] by
-
- 4 edits in trunk/LayoutTests
Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=160689
<rdar://problem/24025664>
Patch by Antoine Quint <Antoine Quint> on 2016-08-11
Reviewed by Dean Jackson.
When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.
LayoutTests/imported/w3c:
- canvas/2d.gradient.interpolate.colouralpha.html:
LayoutTests:
- canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:
Aug 10, 2016:
- 8:35 PM Changeset in webkit [204370] by
-
- 13 edits in trunk
Web Inspector: Should be able to Edit Node Attributes and Styles for non-UserAgent Shadow DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=160762
<rdar://problem/27798271>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-10
Reviewed by Ryosuke Niwa.
Source/WebCore:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::addInspectedNode):
Allow editing shadow DOM nodes as long as they are not in a UserAgent shadow tree.
Source/WebInspectorUI:
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.isInUserAgentShadowTree):
(WebInspector.DOMNode.prototype.isShadowRoot):
(WebInspector.DOMNode.prototype.isUserAgentShadowRoot):
(WebInspector.DOMNode.prototype.ancestorShadowRoot):
(WebInspector.DOMNode.prototype.ancestorShadowHost):
Add methods for determining the shadow root, host, and easily
checking the type of shadow tree a node is in.
- UserInterface/Models/CSSStyleDeclaration.js:
(WebInspector.CSSStyleDeclaration.prototype.get editable):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.get editable):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked):
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection.prototype._addNewRule):
Allow editing shadow DOM nodes as long as they are not in a UserAgent shadow tree.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._populateContextMenu):
Disallow "Log Element" on UserAgent shadow tree nodes.
LayoutTests:
- inspector/dom/shadowRootType-expected.txt:
- inspector/dom/shadowRootType.html:
Add tests for DOMNode.prototype.isInUserAgentShadowTree.
- 8:26 PM Changeset in webkit [204369] by
-
- 6 edits3 adds in trunk/LayoutTests
Pull in recent upstream web-platform-tests changes for dom/ and html/
https://bugs.webkit.org/show_bug.cgi?id=160759
Reviewed by Alex Christensen.
- web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
- web-platform-tests/dom/events/EventTarget-dispatchEvent.html:
- web-platform-tests/dom/nodes/Document-Element-getElementsByTagName.js:
(test_getElementsByTagName):
- web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
- 7:21 PM Changeset in webkit [204368] by
-
- 6 edits2 adds in trunk
Optimization in Node.insertBefore() is not spec-compliant
https://bugs.webkit.org/show_bug.cgi?id=160746
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
Source/WebCore:
We have an optimization in Node.insertBefore(newNode, refChild) to avoid
doing any work when newNode == refChild or newNode.nextSibling == refChild.
This optimization is not in the specification:
The issue is that this optimization is observable with DOM mutation
observers / listeners or DOM ranges.
This patch addresses the issue by dropping the optimization. This case
does not seem common enough to be worth optimizing for. However, if it
turns out to regress the performance of things we care about, we could
fallback to doing the optimization only when it is not observable.
Test: fast/dom/Node/insertBefore-no-op-mutationobserver.html
- dom/ContainerNode.cpp:
(WebCore::checkAcceptChild):
Move refChild->parent() == parent check from insertBefore() to our
pre-insertion check function, right after checking if newNode contains
parent. This was done in order to match more closely the specification
and to make sure that exception are thrown in the correct order:
(WebCore::ContainerNode::insertBefore):
Drop the (refChild->previousSibling() == &newChild refChild == &newChild) optimization as it is not spc-compliant.
- If refChild is newNode, then set refChild to newChild.nextSibling as per:
LayoutTests:
Add layout test to make sure mutation observers / listeners are always
notified when Node.insertBefore() is called.
- fast/dom/Node/insertBefore-no-op-mutationobserver-expected.txt: Added.
- fast/dom/Node/insertBefore-no-op-mutationobserver.html: Added.
- 7:08 PM Changeset in webkit [204367] by
-
- 39 edits2 moves2 adds in trunk
Move document.defineElement to customElements.define
https://bugs.webkit.org/show_bug.cgi?id=160731
Reviewed by Chris Dumez.
Source/WebCore:
Replaced Document.prototype.defineElement by CustomElementsRegistry.prototype.define to match
the latest HTML specification: https://html.spec.whatwg.org/#custom-elements-api
This patch renames the existing CustomElementDefinitions to CustomElementsRegistry and exposes
it on window.customElements. CustomElementDefinitions is now owned by DOMWindow instead of
Document to match the spec's new semantics.
No new tests. The existing tests have been updated to reflect the change.
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomElementsRegistryCustom.cpp: Added.
(WebCore::JSCustomElementsRegistry::define): Moved from JSDocumentCustom. Removed the check for
the existence of DOMWindow since CustomElementsRegistry is an attribute on DOMWindow itself.
- bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::defineElement): Deleted.
- bindings/js/JSHTMLElementCustom.cpp: Added the code to check the existence of DOMWindow since
the registry is associated with DOMWindow, not Document.
(WebCore::constructJSHTMLElement):
- dom/CustomElementsRegistry.cpp: Renamed from Source/WebCore/dom/CustomElementDefinitions.cpp.
(WebCore::CustomElementsRegistry::create): Added.
(WebCore::CustomElementsRegistry::CustomElementsRegistry): Added.
(WebCore::CustomElementsRegistry::~CustomElementsRegistry): Added.
(WebCore::CustomElementsRegistry::addElementDefinition): Moved from CustomElementDefinitions.
(WebCore::CustomElementsRegistry::addUpgradeCandidate): Ditto.
(WebCore::CustomElementsRegistry::findInterface): Ditto.
(WebCore::CustomElementsRegistry::containsConstructor): Ditto.
- dom/CustomElementsRegistry.h: Renamed from Source/WebCore/dom/CustomElementDefinitions.h.
- dom/CustomElementsRegistry.idl: Added.
- dom/Document.cpp:
(WebCore::createUpgradeCandidateElement): Extracted out of createHTMLElementWithNameValidation
and createFallbackHTMLElement to share code.
(WebCore::createHTMLElementWithNameValidation):
(WebCore::createFallbackHTMLElement): This function was missing a check for the runtime flag.
Sharing code with createHTMLElementWithNameValidation via createUpgradeCandidateElement fixes it.
(WebCore::Document::ensureCustomElementDefinitions): Deleted.
- dom/Document.h:
(WebCore::Document::customElementDefinitions): Deleted.
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::ensureCustomElementsRegistry): Added. Moved from Document.
- page/DOMWindow.h:
- page/DOMWindow.idl: Added customElements on DOMWindow.
LayoutTests:
Updated the tests and their expected results to reflect the move of Document.prototype.defineElement to
CustomElementsRegistry.prototype.define. I'm going to rename tests in a follow up.
- fast/custom-elements/Document-createElement.html:
- fast/custom-elements/Document-defineElement-expected.txt:
- fast/custom-elements/Document-defineElement.html: Removed test cases for testing defining elements
in a viewless/windowless document since those documents don't have a corresponding window object.
- fast/custom-elements/HTMLElement-constructor.html:
- fast/custom-elements/attribute-changed-callback.html:
- fast/custom-elements/defined-pseudo-class.html:
- fast/custom-elements/defined-rule.html:
- fast/custom-elements/lifecycle-callback-timing.html:
- fast/custom-elements/parser/parser-constructs-custom-element-in-document-write.html:
- fast/custom-elements/parser/parser-constructs-custom-element-synchronously.html:
- fast/custom-elements/parser/parser-constructs-custom-elements-expected.txt:
- fast/custom-elements/parser/parser-constructs-custom-elements.html:
- fast/custom-elements/parser/parser-fallsback-to-unknown-element.html:
- fast/custom-elements/parser/parser-sets-attributes-and-children.html:
- fast/custom-elements/parser/parser-uses-constructed-element.html:
- fast/custom-elements/parser/parser-uses-registry-of-owner-document.html:
- fast/custom-elements/upgrading/Node-cloneNode.html:
- fast/custom-elements/upgrading/upgrading-parser-created-element.html:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 6:22 PM Changeset in webkit [204366] by
-
- 2 edits in trunk/Source/WebCore
Fix WinCairo build after r204327.
- platform/network/NetworkStorageSessionStub.cpp:
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Renamed from create...
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
- 6:14 PM Changeset in webkit [204365] by
-
- 4 edits2 adds in trunk
Fix crash when changing cookie accept policy after r204327
https://bugs.webkit.org/show_bug.cgi?id=160758
Reviewed by Simon Fraser.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
(-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
- 5:09 PM Changeset in webkit [204364] by
-
- 5 edits in trunk/Tools
[iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
https://bugs.webkit.org/show_bug.cgi?id=160757
Reviewed by Tim Horton.
When programmatically creating the test UIWindow, make a root UIViewController and parent
the WKWebView in its view. This makes the app more like a normal UIKit application.
Move the WKWebView down 20px to avoid the status bar.
Give the UIWindow a gray background so it's obvious where the window and view positioned.
Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
Remove duplicate references to Launch.storyboard.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
- WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
(-[AppDelegate applicationWillResignActive:]): Deleted.
(-[AppDelegate applicationDidEnterBackground:]): Deleted.
(-[AppDelegate applicationWillEnterForeground:]): Deleted.
(-[AppDelegate applicationDidBecomeActive:]): Deleted.
(-[AppDelegate applicationWillTerminate:]): Deleted.
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::viewRectForWindowRect):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::setWindowFrame):
- 5:09 PM Changeset in webkit [204363] by
-
- 12 edits1 delete in trunk
[iOS WK2] Use the simulated device's screen size, rather than a harcoded size
https://bugs.webkit.org/show_bug.cgi?id=160748
Reviewed by Tim Horton.
Tools:
Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
opens the door for tests using other device sizes.
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformConfigureViewForTest):
LayoutTests:
Move fast/viewport/ios skipping to ios-simulator-wk2/TestExpectations since the tests
are WK2-only.
- fast/viewport/ios/width-is-device-width-expected.txt:
- fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt:
- platform/ios-simulator/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt:
- platform/ios-simulator/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt:
- platform/ios-simulator/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt:
- platform/ios-simulator/fast/scrolling/ios/touch-stacking-expected.txt:
- platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt: Removed.
- 4:45 PM Changeset in webkit [204362] by
-
- 6 edits1 add in trunk
Baseline GetByVal and PutByVal for cache ID stubs need to handle exceptions
https://bugs.webkit.org/show_bug.cgi?id=160749
Reviewed by Filip Pizlo.
JSTests:
New test that causes baseline GetByValWithCachedId and PutByValWithCachedId
stubs to be generated and then throws exceptions for those stub to handle
to verify that they are properly handled.
- stress/regress-160749.js: Added.
(testCachedGetByVal.):
(testCachedGetByVal.get for):
(testCachedGetByVal):
(testCachedPutByVal.):
(testCachedPutByVal.set for):
(testCachedPutByVal):
Source/JavaScriptCore:
We were emitting "callOperation()" calls in emitGetByValWithCachedId() and
emitPutByValWithCachedId() without linking the exception checks created by the
code emitted. This manifested itself in various ways depending on the processor.
This is due to what the destination is for an unlinked branch. On X86, an unlinked
branch goes tot he next instructions. On ARM64, we end up with an infinite loop
as we branch to the same instruction. On ARM we branch to 0 as the branch is to
an absolute address of 0.
Now we save the exception handler address for the original generated function and
link the exception cases for these by-val stubs to this handler.
- bytecode/ByValInfo.h:
(JSC::ByValInfo::ByValInfo): Added the address of the exception handler we should
link to.
- jit/JIT.cpp:
(JSC::JIT::link): Compute the linked exception handler address and pass it to
the ByValInfo constructor.
(JSC::JIT::privateCompileExceptionHandlers): Make sure that we generate the
exception handler if we have any by-val handlers.
- jit/JIT.h:
Added a label for the exception handler. We'll link this later for the
by value handlers.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByValWithCachedId):
(JSC::JIT::privateCompilePutByValWithCachedId):
Link exception branches to the exception handler for the main function.
- 4:30 PM Changeset in webkit [204361] by
-
- 8 edits3 adds in trunk
AX: Media controls timeline should have percentage value description
https://bugs.webkit.org/show_bug.cgi?id=160619
Reviewed by Eric Carlson.
Source/WebCore:
Added aria-valuetext attribute to the timeline slider and set its value to
the percentage format. Also formatted the elapsed/remaining timer's description
so that it's more human readable.
Test: http/tests/media/hls/video-duration-accessibility.html
- English.lproj/mediaControlsLocalizedStrings.js:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.drawVolumeBackground):
(Controller.prototype.formatTimeDescription):
(Controller.prototype.formatTime):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):
LayoutTests:
- http/tests/media/hls/video-duration-accessibility-expected.txt: Added.
- http/tests/media/hls/video-duration-accessibility.html: Added.
- http/tests/media/resources/hls/generate-vod.php: Added.
- media/media-controls-accessibility-expected.txt:
- platform/efl/accessibility/media-element-expected.txt:
- platform/gtk/accessibility/media-element-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- 4:19 PM Changeset in webkit [204360] by
-
- 3 edits1 add in trunk
DFG's flushForTerminal() needs to add PhantomLocals for bytecode live locals.
https://bugs.webkit.org/show_bug.cgi?id=160755
<rdar://problem/27488507>
Reviewed by Filip Pizlo.
JSTests:
- stress/need-bytecode-liveness-for-unreachable-blocks-at-dfg-time.js: Added.
Source/JavaScriptCore:
If the DFG sees that an inlined function will result in an OSR exit every time,
it will treat all downstream blocks as dead. However, it still needs to keep
locals that are alive in the bytecode alive for the compiled function so that
those locals are properly written to the stack by the OSR exit ramp.
The existing code neglected to do this. This patch remedies this issue.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::addFlushOrPhantomLocal):
(JSC::DFG::ByteCodeParser::phantomLocalDirect):
(JSC::DFG::ByteCodeParser::flushForTerminal):
- 3:37 PM Changeset in webkit [204359] by
-
- 3 edits in trunk/Source/WebCore
Revert back to the old style member function state machine for callbacks
https://bugs.webkit.org/show_bug.cgi?id=160756
Reviewed by Tim Horton.
This is another step towards merging SQLTransactionBackend and SQLTransaction,
and using a single state machine for both sides.
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
(WebCore::SQLTransaction::scheduleCallback):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::handleTransactionError):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::debugStepName):
- Modules/webdatabase/SQLTransaction.h:
- 3:32 PM Changeset in webkit [204358] by
-
- 18 edits1 copy2 adds in trunk
[ES2016] Implement Object.values
https://bugs.webkit.org/show_bug.cgi?id=160410
Reviewed by Saam Baraty, Yusuke Suzuki.
This patch adds values function to Object that return list of
own values of the object. Patch did according to the point of
spec http://tc39.github.io/ecma262/#sec-object.values
Also patch adds generic builtin intrinsic constants:
@IterationKindKey/@IterationKindValue/@IterationKindKeyValue
that is used in EnumerableOwnProperties to set Kind of operation
and replace own IterationKind enums in following iterators:
ArrayIterator, MapIterator, and SetIterator
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/ObjectConstructor.js:
(globalPrivate.enumerableOwnProperties):
(values):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::getInternalProperties):
- runtime/ArrayIteratorPrototype.h:
- runtime/IterationKind.h: Copied from Source/JavaScriptCore/builtins/ObjectConstructor.js.
- runtime/JSMapIterator.h:
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::kind):
(JSC::JSMapIterator::JSMapIterator):
- runtime/JSSetIterator.h:
(JSC::JSSetIterator::create):
(JSC::JSSetIterator::next):
(JSC::JSSetIterator::kind):
(JSC::JSSetIterator::JSSetIterator):
- runtime/MapPrototype.cpp:
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):
(JSC::privateFuncMapIterator):
- runtime/ObjectConstructor.cpp:
- runtime/SetPrototype.cpp:
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::privateFuncSetIterator):
Source/WebCore:
- ForwardingHeaders/runtime/IterationKind.h: Added.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
JSTests:
- stress/object-values.js: Added.
(compare):
(string_appeared_here.forEach):
(const.getInvokedFunctions.):
(const.getInvokedFunctions):
(Array.prototype.push):
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- 2:54 PM Changeset in webkit [204357] by
-
- 4 edits in trunk/Source/WebCore
Move more functions to from SQLTransactionBackend to SQLTransaction
https://bugs.webkit.org/show_bug.cgi?id=160752
Reviewed by Tim Horton.
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::acquireLock):
(WebCore::SQLTransaction::openTransactionAndPreflight):
(WebCore::SQLTransaction::runStatements):
(WebCore::SQLTransaction::cleanupAndTerminate):
(WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
- Modules/webdatabase/SQLTransaction.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
- 2:31 PM Changeset in webkit [204356] by
-
- 8 edits in trunk/Source/WebCore
Begin moving member functions from SQLTransactionBackend to SQLTransaction
https://bugs.webkit.org/show_bug.cgi?id=160747
Reviewed by Tim Horton.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::performClose):
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseTransactionTask::doPerformTask):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::lockAcquired):
(WebCore::SQLTransaction::performNextStep):
(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransaction::enqueueStatement):
(WebCore::SQLTransaction::getNextStatement):
(WebCore::SQLTransaction::runCurrentStatement):
(WebCore::SQLTransaction::handleCurrentStatementError):
(WebCore::SQLTransaction::handleTransactionError):
(WebCore::SQLTransaction::postflightAndCommit):
(WebCore::SQLTransaction::acquireOriginLock):
(WebCore::SQLTransaction::releaseOriginLockIfNeeded):
- Modules/webdatabase/SQLTransaction.h:
(WebCore::SQLTransaction::backend): Deleted.
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::enqueueStatement): Deleted.
(WebCore::SQLTransactionBackend::performNextStep): Deleted.
(WebCore::SQLTransactionBackend::executeSQL): Deleted.
(WebCore::SQLTransactionBackend::lockAcquired): Deleted.
(WebCore::SQLTransactionBackend::getNextStatement): Deleted.
(WebCore::SQLTransactionBackend::runCurrentStatement): Deleted.
(WebCore::SQLTransactionBackend::handleCurrentStatementError): Deleted.
(WebCore::SQLTransactionBackend::handleTransactionError): Deleted.
(WebCore::SQLTransactionBackend::postflightAndCommit): Deleted.
(WebCore::SQLTransactionBackend::acquireOriginLock): Deleted.
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded): Deleted.
- Modules/webdatabase/SQLTransactionBackend.h:
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::shutdown):
- 2:25 PM Changeset in webkit [204355] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Speed up SparseCollection & related maps
https://bugs.webkit.org/show_bug.cgi?id=160733
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-10
Reviewed by Saam Barati.
On MBA, Graph::addNode() shows up in profiles due to SparseCollection::add().
This is unfortunate.
The first improvement is to build the new unique_ptr in the empty slot
instead of moving a new value into it.
Previously, the code would load the previous value, test if it is null
then invoke the destructor and finally fastFree(). The initial test
obviously fails so that's a whole bunch of code that is never executed.
With the new code, we just have a store.
I also removed the bounds checking on our maps based on node index.
Those bounds checks are never eliminated by clang because the index
is always loaded from memory instead of being computed.
There are unfortunately too many nodes processed and the bounds checks
get costly.
- b3/B3SparseCollection.h:
(JSC::B3::SparseCollection::add):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::abstractValuesCache):
- dfg/DFGInPlaceAbstractState.h:
- 2:23 PM Changeset in webkit [204354] by
-
- 2 edits in trunk/Source/WTF
[JSC] TinyPtrSet::deleteListIfNecessary() no longer needs to test for reservedValue
https://bugs.webkit.org/show_bug.cgi?id=160721
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-10
Reviewed by Sam Weinig.
Previously, TinyPtrSet was using a ThinFlag if there was no OutOfLineList.
A side effect is that isThin() was false for reservedValue. When deleting
the list, we had to consider both cases: isThin() and reservedValue.
In r204065, I changed the flag to a FatFlag to ensure TinyPtrSet can be initialized
with bzero().
This changes the value of isThin() of reservedValue to true since reservedValue
does not have the FatFlag bit set.
This patch removes the useless condition from deleteListIfNecessary().
- wtf/TinyPtrSet.h:
(WTF::TinyPtrSet::deleteListIfNecessary):
- 2:20 PM Changeset in webkit [204353] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: rebase inspector/model/remote-object-get-properties.html and unskip
https://bugs.webkit.org/show_bug.cgi?id=160738
<rdar://problem/27788116>
Reviewed by Joseph Pecoraro.
- TestExpectations:
- inspector/model/remote-object-get-properties-expected.txt:
- 2:19 PM Changeset in webkit [204352] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove some useless code I left when rewriting CSE's large maps
https://bugs.webkit.org/show_bug.cgi?id=160720
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-10
Reviewed by Michael Saboff.
- dfg/DFGCSEPhase.cpp:
The maps m_worldMap && m_sideStateMap are useless. They come from the previous
iteration that had weaker constraints.
Also move m_heapMap after m_fallbackStackMap since that is the order
in which they are used in the algorithm.
- 2:15 PM Changeset in webkit [204351] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove AbstractInterpreter::executeEdges(unsigned), it is no longer used anywhere
https://bugs.webkit.org/show_bug.cgi?id=160708
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-10
Reviewed by Mark Lam.
- dfg/DFGAbstractInterpreter.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEdges): Deleted.
- 2:00 PM Changeset in webkit [204350] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/fetch/fetch-in-worker-crash.html as a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=160510
Unreviewed test gardening.
- 1:30 PM Changeset in webkit [204349] by
-
- 8 edits in trunk/Source/WebCore
Move all SQLTransactionBackend member variables to SQLTransaction
https://bugs.webkit.org/show_bug.cgi?id=160745
Reviewed by Tim Horton.
- Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):
- Modules/webdatabase/ChangeVersionWrapper.h:
(WebCore::ChangeVersionWrapper::sqlError): Deleted.
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::hasCallback): Deleted.
(WebCore::SQLTransaction::hasSuccessCallback): Deleted.
(WebCore::SQLTransaction::hasErrorCallback): Deleted.
- Modules/webdatabase/SQLTransaction.h:
(WebCore::SQLTransaction::isReadOnly):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::~SQLTransactionBackend):
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::requestTransitToState):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
(WebCore::SQLTransactionBackend::currentStatement): Deleted.
(WebCore::SQLTransactionBackend::transactionError): Deleted.
(WebCore::SQLTransactionBackend::setShouldRetryCurrentStatement): Deleted.
(WebCore::SQLTransactionBackend::enqueueStatementBackend): Deleted.
- Modules/webdatabase/SQLTransactionBackend.h:
(WebCore::SQLTransactionBackend::database): Deleted.
(WebCore::SQLTransactionBackend::isReadOnly): Deleted.
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::releaseLock):
- 1:25 PM Changeset in webkit [204348] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 1:24 PM Changeset in webkit [204347] by
-
- 2 edits in trunk/Source/WebCore
Sort the project file.
- WebCore.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [204346] by
-
- 5 edits in branches/safari-602.1.50.1-branch/Source
Versioning.
- 1:23 PM Changeset in webkit [204345] by
-
- 10 edits in trunk
Sort the feature flags in the FEATURE_DEFINES lines
https://bugs.webkit.org/show_bug.cgi?id=160742
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 1:21 PM Changeset in webkit [204344] by
-
- 1 edit2 adds in trunk/LayoutTests
Add JS array sort test case
https://bugs.webkit.org/show_bug.cgi?id=160680
Incorporate a test case related to a improper JavaScript Array
sorting behavior. The actual bug was fixed more than a year ago,
as a side effect of Bug 144013, but no test case was provided.
- js/array-sort-crash-expected.txt: Added.
- js/array-sort-crash.html: Added.
- 1:21 PM Changeset in webkit [204343] by
-
- 5 edits in trunk/Source
Versioning.
- 1:17 PM Changeset in webkit [204342] by
-
- 1 copy in tags/Safari-603.1.2
New tag.
- 12:59 PM Changeset in webkit [204341] by
-
- 3 edits in trunk/Tools
Logging and other minor improvements to iOS webkitpy
https://bugs.webkit.org/show_bug.cgi?id=160722
Reviewed by Dan Bates.
Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
to make it easier to debug launching issues.
Have reset_preferences() reset the device, rather than just nuking the data
directory (which broke some versions of the simulator).
Make the Simulator.app launch in the background with open -g.
Wait for the simulator device to be in a known state in some more places.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort._quit_ios_simulator):
(IOSSimulatorPort.clean_up_test_run):
(IOSSimulatorPort.setup_environ_for_server):
(IOSSimulatorPort.reset_preferences):
- Scripts/webkitpy/xcode/simulator.py:
(Device.create):
(Device.delete):
(Device):
(Device.reset):
(Simulator.wait_until_device_is_booted):
(Simulator.wait_until_device_is_in_state):
(Simulator):
(Simulator.delete_device):
(Simulator.reset_device):
(Simulator.lookup_or_create_device):
- 12:37 PM Changeset in webkit [204340] by
-
- 3 edits in trunk/LayoutTests
Marking inspector/model/remote-object-get-properties.html as failing
https://bugs.webkit.org/show_bug.cgi?id=160738
Unreviewed test gardening.
- TestExpectations:
- platform/mac/TestExpectations:
- 12:35 PM Changeset in webkit [204339] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Can't click on the lower half of "S" icon in JavaScript Allocations timeline
https://bugs.webkit.org/show_bug.cgi?id=160743
<rdar://problem/27790098>
Reviewed by Timothy Hatcher.
"S" icons are covered by .scroll-container, which has
z-index: calc(var(--z-index-resizer) + 1).
Set larger z-index on the "S" icons.
- UserInterface/Views/HeapAllocationsTimelineOverviewGraph.css:
(.timeline-overview-graph.heap-allocations > img.snapshot):
- 11:41 AM Changeset in webkit [204338] by
-
- 12 edits in trunk/Source/WebCore
Make SQLTransactionBackend a member of SQLTransaction
https://bugs.webkit.org/show_bug.cgi?id=160741
Reviewed by Tim Horton.
This is another step towards merging SQLTransaction and SQLTransactionBackend.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::performClose):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::runTransaction):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseTransactionTask::doPerformTask):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseTransactionTask::transaction):
- Modules/webdatabase/DatabaseThread.cpp:
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::deliverSuccessCallback):
(WebCore::SQLTransaction::executeSQL):
(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransaction::setBackend): Deleted.
- Modules/webdatabase/SQLTransaction.h:
(WebCore::SQLTransaction::backend):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::requestTransitToState):
(WebCore::SQLTransactionBackend::create): Deleted.
- Modules/webdatabase/SQLTransactionBackend.h:
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):
- Modules/webdatabase/SQLTransactionCoordinator.h:
- 10:37 AM Changeset in webkit [204337] by
-
- 5 edits2 adds in trunk
child-transform-with-anchor-point-expected.html renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=160616
Reviewed by Zalan Bujtas.
Source/WebCore:
If a layer has perspective, we need to ensure that its bounds don't collapse to 0x0 when clipped out,
otherwise the sublayerTransform geometry gets messed up.
Test: compositing/geometry/clipped-out-perspective.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
LayoutTests:
- compositing/geometry/clipped-out-perspective-expected.html: Added.
- compositing/geometry/clipped-out-perspective.html: Added.
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Rebaseline.
- platform/mac-wk1/TestExpectations:
- 10:32 AM Changeset in webkit [204336] by
-
- 26 edits in trunk/Source/WebCore
Remove support for array types in IDLs
https://bugs.webkit.org/show_bug.cgi?id=160729
Reviewed by Anders Carlsson.
Array types have been removed from WebIDL in favor of sequence<> and FrozenArray<>.
- Replace all current uses of Array types with sequences. This causes no functional change.
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/IDLParser.pm:
Remove array support from the generators.
- Modules/gamepad/Gamepad.idl:
- Modules/gamepad/NavigatorGamepad.idl:
- Modules/gamepad/deprecated/Gamepad.idl:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaTrackConstraints.idl:
- Modules/mediastream/RTCConfiguration.idl:
- Modules/mediastream/RTCIceServer.idl:
- Modules/mediastream/RTCTrackEvent.idl:
- crypto/CryptoKey.idl:
- dom/MessageEvent.idl:
- testing/Internals.idl:
Switch from array to sequence.
- 10:19 AM Changeset in webkit [204335] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Skip a JSC test that's timing out and an inspector test that needs to be rebased after r204321
- TestExpectations:
- js/regress/script-tests/bound-function-construction-performance.js:
(makeBoundFunc):
- 10:05 AM Changeset in webkit [204334] by
-
- 3 edits in trunk/Source/WebCore
Use unsigned for locations in URL
https://bugs.webkit.org/show_bug.cgi?id=160706
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-10
Reviewed by Sam Weinig.
No change in behavior.
- platform/URL.cpp:
(WebCore::isSchemeFirstChar):
(WebCore::findFirstOf):
(WebCore::checkEncodedString):
(WebCore::URL::host):
(WebCore::URL::protocolIs):
(WebCore::URL::setPort):
(WebCore::URL::setUser):
(WebCore::URL::setPass):
(WebCore::escapeAndAppendNonHierarchicalPart):
(WebCore::copyPathRemovingDots):
(WebCore::URL::serialize):
(WebCore::isDefaultPortForScheme):
(WebCore::hostPortIsEmptyButCredentialsArePresent):
(WebCore::URL::parse):
(WebCore::protocolHostAndPortAreEqual):
(WebCore::hostsAreEqual):
(WebCore::protocolIs):
(WebCore::findHostnamesInMailToURL):
(WebCore::findHostnameInHierarchicalURL):
(WebCore::encodeHostnames):
(WebCore::encodeRelativeString):
- platform/URL.h:
- 9:47 AM Changeset in webkit [204333] by
-
- 10 edits in trunk/Source/WebCore
Move SQLTransactionBackend construction inside SQLTransaction
https://bugs.webkit.org/show_bug.cgi?id=160726
Reviewed by Tim Horton.
This is the first step towards re-merging SQLTransactionBackend and SQLTransaction and clean up the code.
- Modules/webdatabase/ChangeVersionWrapper.cpp:
- Modules/webdatabase/ChangeVersionWrapper.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::performClose):
(WebCore::Database::scheduleTransactionStep):
(WebCore::Database::changeVersion):
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseTask.cpp:
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
- Modules/webdatabase/SQLTransaction.h:
(WebCore::SQLTransactionWrapper::~SQLTransactionWrapper):
(WebCore::SQLTransaction::backend):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::requestTransitToState):
- Modules/webdatabase/SQLTransactionBackend.h:
(WebCore::SQLTransactionWrapper::~SQLTransactionWrapper): Deleted.
- 8:57 AM Changeset in webkit [204332] by
-
- 2 edits in trunk/Tools
[GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=160697
Reviewed by Antonio Gomes.
- Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
list of environment variables to copy.
- 7:49 AM Changeset in webkit [204331] by
-
- 3 edits2 adds in trunk
It should be possible to re-initialize a MutationEvent after it's been dispatched
https://bugs.webkit.org/show_bug.cgi?id=160703
Reviewed by Sam Weinig.
Source/WebCore:
It should be possible to re-initialize a MutationEvent after it's been dispatched,
similarly to Event:
Test: fast/events/initMutationEvent-after-dispatch.html
- dom/MutationEvent.cpp:
(WebCore::MutationEvent::initMutationEvent):
LayoutTests:
Add layout test coverage.
- fast/events/initMutationEvent-after-dispatch-expected.txt: Added.
- fast/events/initMutationEvent-after-dispatch.html: Added.
- 1:37 AM Changeset in webkit [204330] by
-
- 15 edits1 copy2 moves3 adds1 delete in trunk/Source
[ES6] Add ModuleLoaderPrototype and move methods to it
https://bugs.webkit.org/show_bug.cgi?id=160633
Reviewed by Saam Barati.
Source/JavaScriptCore:
In the future, we need to add the ability to create the new Loader object (by users).
So rather than holding all the methods in the ModuleLoaderObject instance, moving them
to ModuleLoaderPrototype and create the default JSModuleLoader instance is better.
No behavior change.
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/ModuleLoaderObject.js:
(setStateToMax): Deleted.
(newRegistryEntry): Deleted.
(ensureRegistered): Deleted.
(forceFulfillPromise): Deleted.
(fulfillFetch): Deleted.
(fulfillTranslate): Deleted.
(fulfillInstantiate): Deleted.
(commitInstantiated): Deleted.
(instantiation): Deleted.
(requestFetch): Deleted.
(requestTranslate): Deleted.
(requestInstantiate): Deleted.
(requestResolveDependencies.): Deleted.
(requestResolveDependencies): Deleted.
(requestInstantiateAll): Deleted.
(requestLink): Deleted.
(requestReady): Deleted.
(link): Deleted.
(moduleEvaluation): Deleted.
(provide): Deleted.
(loadAndEvaluateModule): Deleted.
(loadModule): Deleted.
(linkAndEvaluateModule): Deleted.
- builtins/ModuleLoaderPrototype.js: Renamed from Source/JavaScriptCore/builtins/ModuleLoaderObject.js.
(setStateToMax):
(newRegistryEntry):
(ensureRegistered):
(forceFulfillPromise):
(fulfillFetch):
(fulfillTranslate):
(fulfillInstantiate):
(commitInstantiated):
(instantiation):
(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestResolveDependencies.):
(requestResolveDependencies):
(requestInstantiateAll):
(requestLink):
(requestReady):
(link):
(moduleEvaluation):
(provide):
(loadAndEvaluateModule):
(loadModule):
(linkAndEvaluateModule):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- jsc.cpp:
(GlobalObject::moduleLoaderResolve):
(GlobalObject::moduleLoaderFetch):
- runtime/Completion.cpp:
(JSC::loadAndEvaluateModule):
(JSC::loadModule):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::moduleLoader):
(JSC::JSGlobalObject::moduleLoaderStructure):
- runtime/JSModuleLoader.cpp: Added.
(JSC::JSModuleLoader::JSModuleLoader):
(JSC::JSModuleLoader::finishCreation):
(JSC::printableModuleKey):
(JSC::JSModuleLoader::provide):
(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::resolve):
(JSC::JSModuleLoader::fetch):
(JSC::JSModuleLoader::translate):
(JSC::JSModuleLoader::instantiate):
(JSC::JSModuleLoader::evaluate):
- runtime/JSModuleLoader.h: Copied from Source/JavaScriptCore/runtime/ModuleLoaderObject.h.
(JSC::JSModuleLoader::create):
(JSC::JSModuleLoader::createStructure):
- runtime/JSModuleRecord.h:
- runtime/ModuleLoaderObject.cpp: Removed.
(JSC::ModuleLoaderObject::ModuleLoaderObject): Deleted.
(JSC::ModuleLoaderObject::finishCreation): Deleted.
(JSC::printableModuleKey): Deleted.
(JSC::ModuleLoaderObject::provide): Deleted.
(JSC::ModuleLoaderObject::loadAndEvaluateModule): Deleted.
(JSC::ModuleLoaderObject::loadModule): Deleted.
(JSC::ModuleLoaderObject::linkAndEvaluateModule): Deleted.
(JSC::ModuleLoaderObject::resolve): Deleted.
(JSC::ModuleLoaderObject::fetch): Deleted.
(JSC::ModuleLoaderObject::translate): Deleted.
(JSC::ModuleLoaderObject::instantiate): Deleted.
(JSC::ModuleLoaderObject::evaluate): Deleted.
(JSC::moduleLoaderObjectParseModule): Deleted.
(JSC::moduleLoaderObjectRequestedModules): Deleted.
(JSC::moduleLoaderObjectModuleDeclarationInstantiation): Deleted.
(JSC::moduleLoaderObjectResolve): Deleted.
(JSC::moduleLoaderObjectFetch): Deleted.
(JSC::moduleLoaderObjectTranslate): Deleted.
(JSC::moduleLoaderObjectInstantiate): Deleted.
(JSC::moduleLoaderObjectEvaluate): Deleted.
- runtime/ModuleLoaderObject.h:
(JSC::ModuleLoaderObject::create): Deleted.
(JSC::ModuleLoaderObject::createStructure): Deleted.
- runtime/ModuleLoaderPrototype.cpp: Added.
(JSC::ModuleLoaderPrototype::ModuleLoaderPrototype):
(JSC::moduleLoaderPrototypeParseModule):
(JSC::moduleLoaderPrototypeRequestedModules):
(JSC::moduleLoaderPrototypeModuleDeclarationInstantiation):
(JSC::moduleLoaderPrototypeResolve):
(JSC::moduleLoaderPrototypeFetch):
(JSC::moduleLoaderPrototypeTranslate):
(JSC::moduleLoaderPrototypeInstantiate):
(JSC::moduleLoaderPrototypeEvaluate):
- runtime/ModuleLoaderPrototype.h: Renamed from Source/JavaScriptCore/runtime/ModuleLoaderObject.h.
(JSC::ModuleLoaderPrototype::create):
(JSC::ModuleLoaderPrototype::createStructure):
Source/WebCore:
No behavior change.
- ForwardingHeaders/runtime/JSModuleLoader.h: Added.
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::moduleLoaderResolve):
(WebCore::JSDOMWindowBase::moduleLoaderFetch):
(WebCore::JSDOMWindowBase::moduleLoaderEvaluate):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSModuleLoader.cpp:
(WebCore::JSModuleLoader::resolve):
(WebCore::JSModuleLoader::fetch):
(WebCore::JSModuleLoader::evaluate):
- bindings/js/JSModuleLoader.h:
- 1:18 AM Changeset in webkit [204329] by
-
- 2 edits in trunk/Source/WebCore
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=160687
Reviewed by Sam Weinig.
Avoid forward declarations with different dll linkage.
- platform/spi/cf/CFNetworkSPI.h:
- 1:14 AM Changeset in webkit [204328] by
-
- 2 edits in trunk/Source/WebCore
[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=160690
Reviewed by Sam Weinig.
Use static cast to convert from enum to unsigned.
- platform/network/ProtectionSpaceHash.h:
(WebCore::ProtectionSpaceHash::hash):
- 12:01 AM Changeset in webkit [204327] by
-
- 33 edits1 add in trunk/Source
Move NetworkStorageSession management to WebCore
https://bugs.webkit.org/show_bug.cgi?id=160173
Reviewed by Brady Eidson.
Source/WebCore:
No new tests. No change in behaviour.
Just moving the mapping from SessionID to NetworkStorageSession so we can use it from WebCore.
I need this so we can get to the NetworkStorageSession from SocketStreamHandle without requiring a NetworkingContext.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- loader/CookieJar.cpp:
- platform/network/NetworkStorageSession.cpp: Added.
(WebCore::globalSessionMap):
(WebCore::NetworkStorageSession::storageSession):
(WebCore::NetworkStorageSession::destroySession):
(WebCore::NetworkStorageSession::forEach):
Moved from forEachNetworkStorageSession and fixed the FIXME. This function now includes the default NetworkStorageSession.
- platform/network/NetworkStorageSession.h:
- platform/network/NetworkingContext.h:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::cookieStorage):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
- platform/network/cf/SocketStreamHandleCFNet.cpp:
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Deleted.
- platform/network/soup/ResourceHandleSoup.cpp:
Source/WebKit/mac:
- WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
- WebCoreSupport/WebPlatformStrategies.mm:
- WebView/WebView.mm:
Source/WebKit/win:
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(identifierBase):
(WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::blockedError):
(WebFrameNetworkingContext::storageSession):
(privateSession): Deleted.
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createPasteboardStrategy):
(WebPlatformStrategies::createBlobRegistry):
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::storageSession):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::sessionID):
NetworkSessions no longer own NetworkStorageSessions, but they should still have the same lifetime.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(WebKit::NetworkSession::setSourceApplicationAuditTokenData):
(WebKit::NetworkSession::create):
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::networkStorageSession):
(WebKit::NetworkSession::clearCredentials):
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
- Shared/SessionTracker.cpp:
(WebKit::SessionTracker::networkSession):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::storageSession): Deleted.
(WebKit::staticStorageSessionMap): Deleted.
(WebKit::SessionTracker::sessionID): Deleted.
(WebKit::SessionTracker::forEachNetworkStorageSession): Deleted.
- Shared/SessionTracker.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
(WebKit::WebPlatformStrategies::addCookie):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
Aug 9, 2016:
- 10:44 PM Changeset in webkit [204326] by
-
- 5 edits in trunk
Optimization in Node.replaceChild() is not spec-compliant
https://bugs.webkit.org/show_bug.cgi?id=160730
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt:
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
Source/WebCore:
We have an optimization in Node.replaceChild() to avoid doing any work
when the reference child and the new child are the same node. This
optimization is not spec-compliant:
This is an issue because it is observable via Mutation observers /
listeners or DOM ranges.
To address the issue, this patch drops the optimization. This is
probably not common enough to be worth optimizing for. However,
if it turns out to regress performance of things we care about,
we can fall back to do the optimization only in cases where it
is not observable.
No new tests, rebaselined existing tests.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
- Drop the oldChild == newChild optimization which is not in the specification.
- Add a null check for oldChild.parentNode() before trying to remove it from its parent, as per step 12 of the specification. oldChild.parentNode() is null when oldChild is newChild.
- Make sure we enqueue separate mutation records for the adoption of newNode into parent's node document and for the removal of oldChild / insertion of newChild. This is mandated by the specification (steps 10 and 15). Without this change, the following test would still not pass after dropping the optimization: imported/w3c/web-platform-tests/dom/nodes/MutationObserver-childList.html
- 9:08 PM Changeset in webkit [204325] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 8:58 PM Changeset in webkit [204324] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r204274. rdar://problem/27688892
- 8:55 PM Changeset in webkit [204323] by
-
- 2 edits in trunk/Source/WebKit2
Fix iOS build.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setPluginLoadClientPolicy): Deleted.
(WebKit::WebProcessPool::clearPluginClientPolicies): Deleted.
- 8:47 PM Changeset in webkit [204322] by
-
- 5 edits2 adds in trunk
Optimization in Node::appendChild() is not spec-compliant
https://bugs.webkit.org/show_bug.cgi?id=160728
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
Source/WebCore:
We have an optimization in Node::appendChild() that avoid doing any work
if the node to be appended is already the last child. This optimization
is not spec-compliant:
The issue is that this is observable via DOM Mutation observers / listeners
or DOM ranges.
To address the issue, this patch drops the optimization in appendChild().
This seems like an odd case to optimize for as I am not convinced it is
common to call parent.appendChild(parent.lastChild). If it turns out to
regress the performance of things we care about though, we could fall
back to do the optimization only when it is not observable.
Test: fast/dom/Node/appendChild-no-op-mutationobserver.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::appendChild): Deleted.
LayoutTests:
Add layout test to make sure that mutation events are always fired
when calling Node::appendChild(), even if the new node is already
the last child.
- fast/dom/Node/appendChild-no-op-mutationobserver-expected.txt: Added.
- fast/dom/Node/appendChild-no-op-mutationobserver.html: Added.
- 8:39 PM Changeset in webkit [204321] by
-
- 8 edits4 adds in trunk
JSBoundFunction should lazily generate its name string
https://bugs.webkit.org/show_bug.cgi?id=160678
<rdar://problem/27043194>
Reviewed by Mark Lam.
JSTests:
- stress/bound-function-lazy-name-generation.js: Added.
(assert):
(test.let.f):
(test.f):
(test):
Source/JavaScriptCore:
We were eagerly allocating the BoundFunction's 'name' string
by prepending the "bound " prefix. This patch makes the 'name'
string creation lazy like we do with ordinary JSFunctions.
This is a 25% speedup on the microbenchmark I added that measures
bound function creation speed. Hopefully this also helps us recover
from a 1% Speedometer regression that was introduced in the original
bound function "bound " prefixing patch.
- runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):
- runtime/JSBoundFunction.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::finishCreation):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyBoundNameIfNeeded):
- runtime/JSFunction.h:
LayoutTests:
- js/regress/bound-function-construction-performance-expected.txt: Added.
- js/regress/bound-function-construction-performance.html: Added.
- js/regress/script-tests/bound-function-construction-performance.js: Added.
(makeBoundFunc):
(foo.f):
(foo):
- 6:31 PM Changeset in webkit [204320] by
-
- 19 edits in trunk/Source
Instantiate WebKit plug-ins at layout time, instead of at style resolution time
https://bugs.webkit.org/show_bug.cgi?id=160715
Reviewed by Tim Horton.
Source/WebCore:
This gets rid of the differentiation of WebKit plug-ins and Netscape plug-ins, and
always instantiates plug-ins at layout time.
Initially, plug-ins were always instantiated after style recalc, but that lead to bugs
where plug-ins wouldn't be instantiated with their correct size. Fixing that bug lead
to a regression in the Web Clip widget which is why the special casing was introduced.
The Web Clip widget has now been fixed, so we can get rid of the special case.
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget):
- html/HTMLAppletElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget):
- html/HTMLEmbedElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget):
- html/HTMLObjectElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::isImageType):
(WebCore::HTMLPlugInImageElement::wouldLoadAsPlugIn):
(WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
(WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin): Deleted.
- html/HTMLPlugInImageElement.h:
- loader/EmptyClients.h:
- loader/FrameLoaderTypes.h:
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::shouldUsePlugin):
- page/FrameView.cpp:
(WebCore::FrameView::updateEmbeddedObject):
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::objectContentType):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::objectContentType):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
- 6:16 PM Changeset in webkit [204319] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix assertions after r204311.
Range::textNodeSplit() can now get called with a node that
does not have a nextSibling(), in the case where this node
does not have a parent.
- dom/Range.cpp:
(WebCore::Range::textNodeSplit):
- 5:49 PM Changeset in webkit [204318] by
-
- 14 edits1 copy in trunk/Source/WebKit2
[WK2] Only send gamepad input events to the currently focused page.
https://bugs.webkit.org/show_bug.cgi?id=160699
Reviewed by Tim Horton.
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::updateTimerFired):
(WebKit::UIGamepadProvider::platformWebProcessProxyForGamepadInput):
- UIProcess/Gamepad/UIGamepadProvider.h:
- UIProcess/Gamepad/mac/UIGamepadProviderMac.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKViewInternal.h.
(WebKit::UIGamepadProvider::platformWebPageProxyForGamepadInput):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gamepadActivity):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::gamepadActivity): Deleted.
- UIProcess/WebProcessPool.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::gamepadActivity):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::gamepadActivity): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 5:31 PM Changeset in webkit [204317] by
-
- 7 edits in trunk/Source/WebKit2
Remove code that would tell clients whenever the list of installed plug-ins changes
https://bugs.webkit.org/show_bug.cgi?id=160719
Reviewed by Tim Horton.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::PluginInfoStore): Deleted.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Deleted.
- UIProcess/Plugins/PluginInfoStore.h:
(WebKit::PluginInfoStoreClient::~PluginInfoStoreClient): Deleted.
(WebKit::PluginInfoStoreClient::PluginInfoStoreClient): Deleted.
(WebKit::PluginInfoStore::setClient): Deleted.
(WebKit::PluginInfoStore::client): Deleted.
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable): Deleted.
- UIProcess/WebContextClient.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::m_hiddenPageThrottlingTimer): Deleted.
(WebKit::WebProcessPool::pluginInfoStoreDidLoadPlugins): Deleted.
- UIProcess/WebProcessPool.h:
- 5:10 PM Changeset in webkit [204316] by
-
- 6 edits2 adds in trunk
CharacterData.data setter optimization is not spec-compliant and is observable
https://bugs.webkit.org/show_bug.cgi?id=160712
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
Source/WebCore:
We have an optimization in CharacterData.setData() that avoid doing any
work if the new data is identical to the old data. However, this
optimization is not spec-compliant:
This is an issue because this is observable using DOM mutation observer
or ranges.
To address the issue, we now:
- Only use the optimization if there are not DOM mutation observers / listeners on the page.
- We now update the associated range when we use the fast path as well.
Test: fast/dom/Text/setData-no-op-mutation.html
- dom/CharacterData.cpp:
(WebCore::canUseSetDataOptimization):
(WebCore::CharacterData::setData):
LayoutTests:
Add test coverage to make sure that DOM Mutation observers get notified
when CharacterData.data is set to the same data.
- fast/dom/Text/setData-no-op-mutation-expected.txt: Added.
- fast/dom/Text/setData-no-op-mutation.html: Added.
- 4:32 PM Changeset in webkit [204315] by
-
- 1 copy in tags/Safari-602.1.50.1.1
New tag.
- 4:31 PM Changeset in webkit [204314] by
-
- 1 copy in tags/Safari-602.1.50.0.1
New tag.
- 4:22 PM Changeset in webkit [204313] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Don't filter out the latest data point in chart data sampling
https://bugs.webkit.org/show_bug.cgi?id=160714
Reviewed by Chris Dumez.
Exclude the last data point from sampling so that it's always included in the "sampled" charts data.
Without this, the last data point can change as we zoom out the time domain.
Luckily, we already had a mechanism to exclude the user selected point from sampling. Extend this
feature by supporting an array of point IDs instead of a single ID to exclude from filering.
- public/v3/components/interactive-time-series-chart.js:
(InteractiveTimeSeriesChart.prototype._sampleTimeSeries): Replaced exclusionPointID by excludedPoints.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype._ensureSampledTimeSeries): Put the last data point in excludedPoints.
(TimeSeriesChart.prototype._sampleTimeSeries): Check point's id against the list of IDs.
- 3:58 PM Changeset in webkit [204312] by
-
- 26 edits in trunk
Implement functionality of media capture on iOS
https://bugs.webkit.org/show_bug.cgi?id=158945
<rdar://problem/26893343>
Patch by George Ruan <gruan@apple.com> on 2016-08-09
Reviewed by Tim Horton.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Enable media capture feature
for iOS.
Source/WebCore:
No new tests, feature requires user gesture which we are unable to
test currently.
- Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
for iOS.
- html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent): Modified call for
mediaCaptureType property.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::mediaCaptureType): Returns
MediaCaptureType according to the value of the capture attribute on
the HTMLInputElement.
(WebCore::HTMLInputElement::shouldUseMediaCapture): Deleted.
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: As the capture attribute is specified as
a boolean attribute in the Media Capture spec, this is a non-standard
web-facing change with accordance to the proposal #1102. We would like
to be able to specify a capture device to pull up upon interaction
with the input type file element. In favor of not introducing a new
attribute to specify the capture device, we reuse the capture
attribute with a set of enumerated values (user, environment, none) to
specify the desired media capture behavior.
- platform/FileChooser.h: Created enum MediaCaptureType representing
whether the front or rear camera shoul dbe shown when the capture
attribute is specified.
Source/WebKit/ios:
- DefaultDelegates/WebDefaultUIKitDelegate.m:
(-[WebDefaultUIKitDelegate
webView:runOpenPanelForFileButtonWithResultListener:configuration:]):
Use a dictionary instead of passing each parameter in separately.
(-[WebDefaultUIKitDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:acceptMIMETypes:]): Deleted.
- WebCoreSupport/WebChromeClientIOS.mm:
(webMediaCaptureType): Converts from WebCore::MediaCaptureType to
WebMediaCaptureType.
(WebChromeClientIOS::runOpenPanel):
- WebKit.iOS.exp: Expose NSDictionary keys for
runOpenPanelForFileButtonWithResultListener.
- WebView/WebUIKitDelegate.h: Add WebMediaCaptureType enum and
NSDictionary keys for
runOpenPanelForFileButtonWithResultListener.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
for iOS.
Source/WebKit2:
For a input type file element on iOS, the media capture attribute can
now be used to specify which camera to pull up immediately, as opposed
to having to select the camera from a file picker menu. If the
specified capture type camera device is unavailable, the other
built-in camera will be pulled up instead. If no camera is available,
then the file picker menu will be presented to the user.
- Configurations/FeatureDefines.xcconfig: Enable Media Capture feature
on iOS.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<FileChooserSettings>::encode): Encode enum
MediaCaptureType.
(IPC::ArgumentCoder<FileChooserSettings>::decode): Decode enum
MediaCaptureType.
- UIProcess/API/APIOpenPanelParameters.cpp:
(API::OpenPanelParameters::mediaCaptureType):
(API::OpenPanelParameters::capture): Deleted.
- UIProcess/API/APIOpenPanelParameters.h: Capture attribute is now
represented with MediaCaptureType instead of boolean.
- UIProcess/API/C/WKOpenPanelParametersRef.cpp:
(WKOpenPanelParametersGetMediaCaptureType): Change function name to
better represent function.
(WKOpenPanelParametersGetCaptureEnabled): Deleted.
- UIProcess/API/C/WKOpenPanelParametersRef.h:
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(cameraDeviceForMediaCaptureType): Translate MediaCaptureType to media
device.
(-[WKFileUploadPanel presentWithParameters:resultListener:]):
Immediately pull up media capture device if devices are available and
capture attribute is present.
(-[WKFileUploadPanel _showDocumentPickerMenu]): Only show option to
use media capture device if it is available for the source type.
(-[WKFileUploadPanel _adjustMediaCaptureType]): Determines correct
fallback option for the media capture device.
(-[WKFileUploadPanel _shouldMediaCaptureOpenMediaDevice]): Checks if
the media capture device should be immediately pulled up.
(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]): Specified the
media capture device to use.
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
Capture feature on iOS.
- 3:30 PM Changeset in webkit [204311] by
-
- 5 edits in trunk
Calling splitText() on a parent-less Text node should update associated ranges
https://bugs.webkit.org/show_bug.cgi?id=160710
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/ranges/Range-mutations-expected.txt:
Source/WebCore:
Calling splitText() on a parent-less Text node should update associated ranges:
Previously, we would only update ranges for Text nodes that have a parent.
No new tests, rebaselined existing test.
- dom/Range.cpp:
(WebCore::boundaryTextNodesSplit):
(WebCore::Range::textNodeSplit): Deleted.
- dom/Text.cpp:
(WebCore::Text::splitText):
- 3:25 PM Changeset in webkit [204310] by
-
- 2 edits in branches/safari-602.1.50.1-branch/Source/WebCore
Merge r204274. rdar://problem/27688892
- 3:20 PM Changeset in webkit [204309] by
-
- 2 edits in branches/safari-602.1.50.1-branch/LayoutTests
Merge r203458. rdar://problem/27434307
- 3:20 PM Changeset in webkit [204308] by
-
- 2 edits in branches/safari-602.1.50.1-branch/LayoutTests
Merge r204201. rdar://problem/27710755
- 3:20 PM Changeset in webkit [204307] by
-
- 2 edits1 delete in branches/safari-602.1.50.1-branch/LayoutTests
Merge r204267. rdar://problem/27595142
- 3:08 PM Changeset in webkit [204306] by
-
- 5 edits in branches/safari-602.1.50.1-branch/Source
Versioning.
- 3:03 PM Changeset in webkit [204305] by
-
- 6 edits in trunk
Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
https://bugs.webkit.org/show_bug.cgi?id=160671
<rdar://problem/27756112>
Reviewed by Mark Lam.
Source/JavaScriptCore:
There was a bug in our captured variable analysis when a function has a default
parameter expression that is a function that captures something from the parent scope.
The bug was that we were relying on the SourceProviderCache to succeed for the
analysis to work. This is obviously wrong. I've fixed this to work regardless
of getting a cache hit. To prevent future bugs that rely on the success of the
SourceProviderCache, I've made the validate testing mode disable the SourceProviderCache
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
- parser/Parser.h:
(JSC::Scope::setInnerArrowFunctionUsesEvalAndUseArgumentsIfNeeded):
(JSC::Scope::addClosedVariableCandidateUnconditionally):
(JSC::Scope::collectFreeVariables):
- runtime/Options.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 2:54 PM Changeset in webkit [204304] by
-
- 3 edits in trunk/LayoutTests
[macOS Sierra] Fix flaky test: media/controls/picture-in-picture.html
https://bugs.webkit.org/show_bug.cgi?id=160707
Reviewed by Eric Carlson.
This test became flaky after r201474 when we started to delay showing
the inline placeholder until we are sure the video layer has been moved
into the video fullscreen layer. This means we can't guarantee that the
placeholder is visible right away after the video's presentation mode
changes to "picture-in-picture".
To fix this, we'll update the test so that we'll wait until the placeholder
becomes visible before testing its visibility without the "controls" attribute.
- media/controls/picture-in-picture.html:
- platform/mac-wk2/TestExpectations:
- 2:50 PM Changeset in webkit [204303] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Build fix after r204187. interval has to be a getter, not a method.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart.prototype._renderTimeSeries):
- public/v3/models/measurement-adaptor.js:
(MeasurementAdaptor.prototype.applyTo):
- 2:36 PM Changeset in webkit [204302] by
-
- 2 edits in trunk/Source/WTF
Fix windows build.
- wtf/Variant.h:
(std::experimental::visit_helper2::visit):
MSVC does not support extended constexpr. Use a ternary operator instead of an if statement.
- 2:35 PM Changeset in webkit [204301] by
-
- 2 edits in branches/safari-602.1.50.0-branch/LayoutTests
Merge r203458. rdar://problem/27434307
- 2:35 PM Changeset in webkit [204300] by
-
- 2 edits in branches/safari-602.1.50.0-branch/LayoutTests
Merge r204201. rdar://problem/27710755
- 2:35 PM Changeset in webkit [204299] by
-
- 2 edits1 delete in branches/safari-602.1.50.0-branch/LayoutTests
Merge r204267. rdar://problem/27595142
- 2:34 PM Changeset in webkit [204298] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Fix a typo that was supposed to be fixed in r204296 before landing.
- public/v3/pages/chart-pane.js:
(ChartPane):
(ChartPane.prototype.updateFromSerializedState):
(ChartPane.prototype._analyzeRange):
(ChartPane.prototype._renderTrendLinePopover):
(ChartPane.prototype._trendLineTypeDidChange):
- 2:29 PM Changeset in webkit [204297] by
-
- 15 edits4 copies1 add in trunk/Source/WebKit2
Implement "dumb" WK2 support for gamepads.
https://bugs.webkit.org/show_bug.cgi?id=160700
Reviewed by Alex Christensen.
With this patch, gamepads work in WK2.
Things known to be missing to make this mechanism more "smart":
- Refresh values along with display sync instead of on a 60hz timer (bug 160673)
- Only send updated values to the current focused web page (bug 160699)
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- Shared/Gamepad/GamepadData.cpp: Copied from Source/WebKit2/UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp.
(WebKit::GamepadData::encode):
(WebKit::GamepadData::decode):
(WebKit::GamepadData::isNull):
(WebKit::GamepadData::loggingString):
- Shared/Gamepad/GamepadData.h: Copied from Source/WebKit2/WebProcess/Gamepad/WebGamepad.h.
- UIProcess/Gamepad/UIGamepad.cpp: Copied from Source/WebKit2/UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp.
(WebKit::UIGamepad::UIGamepad):
(WebKit::UIGamepad::updateFromPlatformGamepad):
(WebKit::UIGamepad::gamepadData):
- UIProcess/Gamepad/UIGamepad.h: Copied from Source/WebKit2/WebProcess/Gamepad/WebGamepad.h.
(WebKit::UIGamepad::index):
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::UIGamepadProvider):
(WebKit::UIGamepadProvider::updateTimerFired):
(WebKit::UIGamepadProvider::startOrStopSynchingGamepadState):
(WebKit::UIGamepadProvider::platformGamepadConnected):
(WebKit::UIGamepadProvider::platformGamepadDisconnected):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):
(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::platformGamepads):
- UIProcess/Gamepad/UIGamepadProvider.h:
- UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:
(WebKit::UIGamepadProvider::platformGamepads):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::gamepadConnected):
(WebKit::WebProcessPool::gamepadDisconnected):
(WebKit::WebProcessPool::gamepadActivity):
- UIProcess/WebProcessPool.h:
- WebProcess/Gamepad/WebGamepad.cpp:
(WebKit::WebGamepad::WebGamepad):
(WebKit::WebGamepad::axisValues):
(WebKit::WebGamepad::buttonValues):
(WebKit::WebGamepad::updateValues):
- WebProcess/Gamepad/WebGamepad.h:
- WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::gamepadConnected):
(WebKit::WebGamepadProvider::gamepadDisconnected):
(WebKit::WebGamepadProvider::gamepadActivity):
(WebKit::WebGamepadProvider::platformGamepads):
- WebProcess/Gamepad/WebGamepadProvider.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::gamepadConnected):
(WebKit::WebProcess::gamepadDisconnected):
(WebKit::WebProcess::gamepadActivity):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 2:22 PM Changeset in webkit [204296] by
-
- 14 edits2 adds in trunk/Websites/perf.webkit.org
Always show segmentation on v3 charts page
https://bugs.webkit.org/show_bug.cgi?id=160576
Rubber-stamped by Chris Dumez.
Added "Trend Lines" popover to select and customize a moving average or a segmentation to show on charts page
and made Schwarz criterion segmentation the default trend line for all charts.
Because computing the segmentation is expensive, we use WebWorker to parallelize the computation via AsyncTask.
We also compute and cache the segmentation for each cluster separately to avoid processing the entire measurement
set as that could take 10-20s total, which was a huge problem in v2 UI. v3 UI's approach is more incremental and
even opens up an opportunity to cache the results in the server side.
Also brought back "shading" for the confidence interval drawing as done in v1 and v2 UI.
- public/shared/statistics.js:
(Statistics.segmentTimeSeriesByMaximizingSchwarzCriterion): Added segmentCountWeight and gridSize as arguments
to customize the algorithm.
(Statistics.splitIntoSegmentsUntilGoodEnough): Takes segmentCountWeight as BirgeAndMassartC.
- public/v3/async-task.js: Added.
(AsyncTask): Added. This class represents a task such as computing segmentation to be executed in a worker.
(AsyncTask.prototype.execute): Added. Returns a promise that gets resolved when the specified task completes.
(AsyncTaskWorker.waitForAvailableWorker): Added. Calls the given callback with the first available worker. When
all workers are processing some tasks, it waits until one becomes available by putting the callback into a queue.
_didRecieveMessage pops an item out of this queue when a worker completes a task. We don't use a promise here
because calling this function multiple times synchronously could result in all the returned promises getting
resolved with the same worker as none of the callers get to lock away the first available worker until the end
of the current micro-task.
(AsyncTaskWorker._makeWorkerEventuallyAvailable): Added. A helper function for waitForAvailableWorker. Start
a new worker if the number of workers we've started is less than the number of extra cores (e.g. 7 if there are
8 cores on the machine). Avoid starting a new worker if we've started a new worker within the last 50 ms since
starting a new worker takes some time.
(AsyncTaskWorker._findAvailableWorker): Added. Finds a worker that's available right now if there is any.
(AsyncTaskWorker): Added. An instance of AsyncTaskWorker represents a Web worker.
(AsyncTaskWorker.prototype.id): Added.
(AsyncTaskWorker.prototype.sendTask): Added. Sends a task represented by AsyncTask to the worker.
(AsyncTaskWorker.prototype._didRecieveMessage): Added. This function gets called when the current task completes
in the worker. Pop the next callback if some caller of waitForAvailableWorker is still waiting. Otherwise stop
the worker after one second of waiting to avoid worker churning.
(AsyncTaskWorker.workerDidRecieveMessage): Added. Called by onmessage on the worker. Executes the specified task
and sends back a message upon completion with the appropriate timing data.
- public/v3/components/chart-pane-base.js:
(ChartPaneBase.prototype.configure): Uses _createSourceList.
(ChartPaneBase.prototype._createSourceList): Added. Extracted from configure to customize the source list for
the main chart and the overview chart.
(ChartPaneBase.prototype._updateSourceList): Uses _createSourceList.
- public/v3/components/chart-styles.js:
(ChartStyles.createSourceList): Added a boolean showPoint as an extra argument. This specifies whether circles
are drawn for each data point.
(ChartStyles.baselineStyle): Added styles for foreground lines and background lines. They're used for trend lines
and underlying raw data respectively when trend lines are shown.
(ChartStyles.targetStyle): Ditto.
(ChartStyles.currentStyle): Ditto.
- public/v3/components/time-series-chart.js:
(TimeSeriesChart): Added _trendLines, _renderedTrendLines, and _fetchedTimeSeries as instance variables.
(TimeSeriesChart.prototype.setSourceList): Clear _fetchedTimeSeries before calling setSourceList for consistency.
(TimeSeriesChart.prototype.sourceList): Added.
(TimeSeriesChart.prototype.clearTrendLines): Added.
(TimeSeriesChart.prototype.setTrendLine): Added. Preserves the existing trend lines for other sources. This is
necessary because segmentation for "current" and "baseline" lines may become available at different times, and we
don't want to clear one or the other when setting one.
(TimeSeriesChart.prototype._layout): Added a call to _ensureTrendLines.
(TimeSeriesChart.prototype._renderChartContent): Call _renderTimeSeries for trend lines. Trend lines are always
foreground lines and "regular" raw data points are drawn as background if there are trend lines.
(TimeSeriesChart.prototype._renderTimeSeries): Added layerName as an argument. It could be an empty string,
"foreground", or "background". Draw a "shade" just like v1 and v2 UI instead of vertical lines for the confidence
intervals. Pick "foreground", "background", or "regular" chart style based on layerName. Also avoid drawing data
points when *PointRadius is set to zero to reduce the runtime of this function.
(TimeSeriesChart.prototype._sourceOptionWithFallback): Added.
(TimeSeriesChart.prototype._ensureSampledTimeSeries): When *PointRadius is 0, show as many points as there are x
coordinates as a fallback instead of showing every point.
(TimeSeriesChart.prototype._ensureTrendLines): Added. Returns true if the chart contents haven't been re-rendered
since the last update to trend lines. This flag is unset by setTrendLine.
- public/v3/index.html:
- public/v3/models/measurement-cluster.js:
(MeasurementCluster.prototype.addToSeries): Store the data points' index to idMap to help aid MeasurementSet's
_cachedClusterSegmentation efficiently re-create the segmentation from the cache.
- public/v3/models/measurement-set.js:
(MeasurementSet): Added _segmentationCache as an instance variable.
(MeasurementSet.prototype.fetchSegmentation): Added. Calls _cachedClusterSegmentation on each cluster, and
constructs the time series representation of the segmentation from the results.
(MeasurementSet.prototype._cachedClusterSegmentation): Computes and caches the segmentation for each cluster.
The cache of segmentation stores ID of each measurement set at which segment changes instead of its index since
the latter could change in any moment when a new test result is reported, or an existing test result is removed
from the time series; e.g. when it's marked as an outlier.
(MeasurementSet.prototype._validateSegmentationCache): Added. Checks whether the cached segmentation's name and
its parameters match that of the requested one.
(MeasurementSet.prototype._invokeSegmentationAlgorithm): Added. Invokes the segmentation algorithm either in the
main thread or in a Web worker via AsyncTask API based on the size of the time series. While parallelizing the
work is beneficial when the data set is large, the overhead can add up if we keep processing a very small data
set in a worker.
- public/v3/models/time-series.js: Made the file compatible with Node.
(TimeSeries.prototype.length): Added.
(TimeSeries.prototype.valuesBetweenRange): Added.
- public/v3/pages/chart-pane.js:
(createTrendLineExecutableFromAveragingFunction): Added.
(ChartTrendLineTypes): Added. Similar to StatisticsStrategies (statistics-strategies.js) in v2 UI.
(ChartPane): Added _trendLineType, _trendLineParameters, _trendLineVersion, and _renderedTrendLineOptions as
instance variables.
(ChartPane.prototype.serializeState): Serialize the trend line option. This format is compatible with v2 UI.
(ChartPane.prototype.updateFromSerializedState): Ditto. Parsing is compatible with v2 UI except that we now have
the default trend line set when the specified ID doesn't match an existing type ID.
(ChartPane.prototype._renderActionToolbar): Added a call to _renderTrendLinePopover. This is the popover that
specifies the type of a trend line to show as well as its parameters.
(ChartPane.prototype._renderTrendLinePopover): Added. A popover for specifying and customizing a trend line.
(ChartPane.prototype._trendLineTypeDidChange): Added. Called when a new trend line is selected.
(ChartPane.prototype._defaultParametersForTrendLine): Added.
(ChartPane.prototype._trendLineParameterDidChange): Added. Called when the trend lines' parameters are changed.
(ChartPane.prototype._didFetchData): Added. Overrides the one in ChartPaneBase to trigger a trend line update.
(ChartPane.prototype._updateTrendLine): Added. Update the trend line. Since segmentation can take an arbitrary
long time, avoid updating trend lines if this function had been called again (possibly for a different trend line
type or with different parameters) before the results become available; hence the versioning.
(ChartPane.paneHeaderTemplate): Added the trend line popover.
(ChartPane.cssTemplate): Added styles for the trend line popover. Also use a more opaque background color behind
popovers when the -webkit-backdrop-filter property is not supported.
- public/v3/pages/dashboard-page.js:
(DashboardPage.prototype._createChartForCell): Call createSourceList with showPoints set to true to preserve the
existing behavior.
- tools/js/v3-models.js: Include TimeSeries object.
- unit-tests/measurement-set-tests.js: Added two test cases for MeasurementSet's fetchSegmentation.
- unit-tests/resources/almost-equal.js: Added.
(almostEqual): Extracted out of statistics-tests.js.
- unit-tests/statistics-tests.js:
- 2:22 PM Changeset in webkit [204295] by
-
- 5 edits in branches/safari-602.1.50.0-branch/Source
Versioning.
- 2:13 PM Changeset in webkit [204294] by
-
- 2 edits in trunk/Source/WebCore
Drop unused NodeListsNodeData::isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=160704
Reviewed by Ryosuke Niwa.
Drop unused NodeListsNodeData::isEmpty(). Its implementation is incorrect
anyway because it fails to check if the m_childNodeList / m_emptyChildNodeList
members are null.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::isEmpty): Deleted.
- 1:59 PM Changeset in webkit [204293] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Crash in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=160686
Reviewed by Sam Weinig.
We need to specify a plugin info provider object in the page configuration.
- WebView.cpp:
(WebView::initWithFrame):
- 1:33 PM Changeset in webkit [204292] by
-
- 2 edits in trunk/Tools
Make directory reading code in iOSSimulatorDevices() more strict
https://bugs.webkit.org/show_bug.cgi?id=160702
Reviewed by Tim Horton.
- Scripts/webkitdirs.pm:
(iOSSimulatorDevices):
- 1:31 PM Changeset in webkit [204291] by
-
- 16 edits2 deletes in trunk
Source/WebCore:
Replace NodeOrString with std::variant<Ref<Node>, String>
https://bugs.webkit.org/show_bug.cgi?id=160638
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj:
Remove NodeOrString.h/cpp
- bindings/js/JSNodeOrString.cpp:
- bindings/js/JSNodeOrString.h:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::append):
(WebCore::ContainerNode::prepend):
- dom/ContainerNode.h:
- dom/Node.cpp:
(WebCore::nodeSetPreTransformedFromNodeOrStringVector):
(WebCore::firstFollowingSiblingNotInNodeSet):
(WebCore::Node::convertNodesOrStringsIntoNode):
(WebCore::Node::before):
(WebCore::Node::after):
(WebCore::Node::replaceWith):
- dom/Node.h:
Replace NodeOrString with std::variant<Ref<Node>, String> and move convertNodesOrStringsIntoNode
into Node.
- dom/NodeOrString.cpp: Removed.
- dom/NodeOrString.h: Removed.
Source/WTF:
Replace NodeOrString with std::variant<RefPtr<Node>, String>
https://bugs.webkit.org/show_bug.cgi?id=160638
Reviewed by Anders Carlsson.
- wtf/StdLibExtras.h:
(WTF::Visitor::Visitor):
(WTF::makeVisitor):
Add WTF::makeVisitor() which takes a list of lambdas to use
an an overload set for a visitor object.
Also, re-export std::experimental::variant (and helpers) in the std
namespace using type aliasing.
- wtf/Variant.h:
Make std::experimental::variant work in WebCore.
Tools:
Replace NodeOrString with std::variant<RefPtr<Node>, String>
https://bugs.webkit.org/show_bug.cgi?id=160638
Reviewed by Anders Carlsson.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/Tests/WTF/Variant.cpp:
Add additional tests for the initial state of std::variant and using
makeVisitor for visiting.
- 12:57 PM Changeset in webkit [204290] by
-
- 2 edits in trunk/Source/WebKit/win
Fix build.
- WebCoreSupport/WebPlatformStrategies.h:
- 12:30 PM Changeset in webkit [204289] by
-
- 6 edits in trunk/Tools
EWS logging should ensure the logging to file is stopped on queue termination
https://bugs.webkit.org/show_bug.cgi?id=160698
rdar://problem/24464570
Reviewed by Daniel Bates.
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine._stopping): Stop logging to file on queue termination.
(QueueEngine._begin_logging): Configure the Python logger to log to file.
- Scripts/webkitpy/common/system/logutils.py:
(configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
(AbstractQueue.queue_log_path): Same.
(AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
(AbstractQueue.init): Removed host parameter, not required anymore, it was required by logging initialization
which moved to QueueEngine now.
(PatchProcessingQueue.init): Same.
(CommitQueue.init): Same.
(AbstractReviewQueue.init): Same.
(StyleQueue.init): Same.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(TestCommitQueue): Removed host parameter.
(TestCommitQueue.init): Same.
(AbstractPatchQueueTest.test_next_patch): Same.
(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
(test_commit_queue_failure): Same.
(mock_run_webkit_patch):
(MockCommitQueueTask.results_from_patch_test_run): Same.
(test_rollout_lands): Same.
(test_non_valid_patch): Same.
(test_auto_retry): Same.
(test_style_queue_with_watch_list_exception): Same.
(TestQueue.init): Deleted.
(TestReviewQueue.init): Deleted.
(TestFeederQueue.init): Deleted.
- 11:52 AM Changeset in webkit [204288] by
-
- 5 edits2 copies in trunk
It should be possible to re-initialize a CustomEvent after it's been dispatched
https://bugs.webkit.org/show_bug.cgi?id=160664
Reviewed by Darin Adler.
Source/WebCore:
It should be possible to re-initialize a CustomEvent after it's been dispatched:
Test: fast/events/initCustomEvent-after-dispatch.html
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
LayoutTests:
- fast/events/initCustomEvent-after-dispatch-expected.txt: Copied from LayoutTests/fast/events/initEvent-after-dispatch-expected.txt.
- fast/events/initCustomEvent-after-dispatch.html: Copied from LayoutTests/fast/events/initEvent-after-dispatch.html.
Add layout test coverage.
- fast/events/initEvent-after-dispatch-expected.txt:
- fast/events/initEvent-after-dispatch.html:
Fix related layout test.
- 11:06 AM Changeset in webkit [204287] by
-
- 18 edits1 delete in trunk/Source
Get rid of PluginStrategy
https://bugs.webkit.org/show_bug.cgi?id=160696
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.cpp:
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pluginStrategy): Deleted.
- plugins/PluginInfoProvider.h:
- plugins/PluginStrategy.h: Removed.
(WebCore::PluginStrategy::~PluginStrategy): Deleted.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createPluginStrategy): Deleted.
- WebCoreSupport/WebPluginInfoProvider.h:
- WebCoreSupport/WebPluginInfoProvider.mm:
(WebPluginInfoProvider::setPluginLoadClientPolicy): Deleted.
(WebPluginInfoProvider::clearPluginClientPolicies): Deleted.
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createPluginStrategy): Deleted.
Source/WebKit2:
- NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createPluginStrategy): Deleted.
- NetworkProcess/NetworkProcessPlatformStrategies.h:
- WebProcess/Plugins/WebPluginInfoProvider.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createPluginStrategy): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 10:47 AM Changeset in webkit [204286] by
-
- 1 copy in branches/safari-602.1.50.1-branch
New Branch.
- 10:46 AM Changeset in webkit [204285] by
-
- 1 copy in branches/safari-602.1.50.0-branch
New Branch.
- 10:01 AM Changeset in webkit [204284] by
-
- 3 edits in trunk/Source/WebKit2
Add WKPage SPI for looking up a WKFrame given a WKFrameHandle
https://bugs.webkit.org/show_bug.cgi?id=160695
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPage.cpp:
(WKPageLookUpFrameFromHandle): Added. Gets the frame from the map in the page’s process and
returns it if it belongs to the page.
- UIProcess/API/C/WKPagePrivate.h:
- 9:57 AM Changeset in webkit [204283] by
-
- 2 edits in trunk/Tools
webkit-gtk tarball fails to build due to missing files
https://bugs.webkit.org/show_bug.cgi?id=160684
Reviewed by Alex Christensen.
- gtk/manifest.txt.in: Added back spi directories.
- 9:57 AM Changeset in webkit [204282] by
-
- 8 edits in trunk/Source/WebKit
Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=160694
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createPluginStrategy):
(WebPlatformStrategies::refreshPlugins): Deleted.
(WebPlatformStrategies::getPluginInfo): Deleted.
(WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
(WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
(WebPlatformStrategies::clearPluginClientPolicies): Deleted.
- WebCoreSupport/WebPluginInfoProvider.mm:
(WebPluginInfoProvider::refreshPlugins):
(WebPluginInfoProvider::getPluginInfo):
(WebPluginInfoProvider::getWebVisiblePluginInfo):
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createPluginStrategy):
(WebPlatformStrategies::refreshPlugins): Deleted.
(WebPlatformStrategies::getPluginInfo): Deleted.
(WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPluginInfoProvider.cpp:
(WebPluginInfoProvider::refreshPlugins):
(WebPluginInfoProvider::getPluginInfo):
(WebPluginInfoProvider::getWebVisiblePluginInfo):
- 9:26 AM Changeset in webkit [204281] by
-
- 6 edits in trunk/Source/WebKit2
Move plug-in code from WebPlatformStrategies to WebPluginInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=160679
Reviewed by Alex Christensen.
- WebProcess/Plugins/WebPluginInfoProvider.cpp:
(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):
(WebKit::WebPluginInfoProvider::clearPluginClientPolicies):
(WebKit::WebPluginInfoProvider::refreshPlugins):
(WebKit::WebPluginInfoProvider::getPluginInfo):
(WebKit::WebPluginInfoProvider::getWebVisiblePluginInfo):
(WebKit::WebPluginInfoProvider::populatePluginCache):
(WebKit::WebPluginInfoProvider::pluginLoadClientPolicyForHost):
(WebKit::WebPluginInfoProvider::longestMatchedWildcardHostForHost):
(WebKit::WebPluginInfoProvider::replaceHostWithMatchedWildcardHost):
- WebProcess/Plugins/WebPluginInfoProvider.h:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createPluginStrategy):
(WebKit::WebPlatformStrategies::WebPlatformStrategies): Deleted.
(WebKit::WebPlatformStrategies::refreshPlugins): Deleted.
(WebKit::WebPlatformStrategies::getPluginInfo): Deleted.
(WebKit::WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
(WebKit::WebPlatformStrategies::setPluginLoadClientPolicy): Deleted.
(WebKit::WebPlatformStrategies::clearPluginClientPolicies): Deleted.
(WebKit::WebPlatformStrategies::longestMatchedWildcardHostForHost): Deleted.
(WebKit::WebPlatformStrategies::replaceHostWithMatchedWildcardHost): Deleted.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost): Deleted.
(WebKit::WebPlatformStrategies::populatePluginCache): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setPluginLoadClientPolicy):
(WebKit::WebProcess::clearPluginClientPolicies):
- 8:51 AM Changeset in webkit [204280] by
-
- 2 edits in branches/safari-602-branch/LayoutTests
Merge r203458. rdar://problem/27434307
- 3:37 AM Changeset in webkit [204279] by
-
- 2 edits in trunk/Tools
[GTK] Build the jhbuild with -O2 optimization level by default
https://bugs.webkit.org/show_bug.cgi?id=160544
Reviewed by Michael Catanzaro.
- gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
which don't increases the required disk space significatively and
provides better debug information than no passing it.
- 2:11 AM Changeset in webkit [204278] by
-
- 3 edits in trunk/Tools
Allow more --cmakeargs option in build-jsc and build-webkit
https://bugs.webkit.org/show_bug.cgi?id=160340
Reviewed by Michael Catanzaro.
- Scripts/build-jsc:
- Scripts/build-webkit:
- 12:25 AM Changeset in webkit [204277] by
-
- 2 edits in trunk/Tools
Do not check if WebKitLibraries folder exists on EFL and GTK
https://bugs.webkit.org/show_bug.cgi?id=160659
Reviewed by Csaba Osztrogonác.
Though WebKitLibraries is only needed by mac and win ports,
EFL and GTK ports have checked whether it exists.
- Scripts/build-webkit:
Aug 8, 2016:
- 8:26 PM Changeset in webkit [204276] by
-
- 5 edits in trunk/Source/WebCore
Ensure StringView lifetime is correct inside InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=160584
Reviewed by Darin Adler.
A TextRun contains a StringView. Previously, we had a helper function which
could possibly create a new string, and then create a TextRun whose StringView
pointed inside this new string. Then, the string would be destroyed because it
was on the stack.
Luckily, this is benign because this new string would always share a
StringImpl with the string passed into the function (and the StringView
would point into this StringImpl). However, relying on this is dangerous
and we are trying to enforce StringView lifetime checks in
https://bugs.webkit.org/show_bug.cgi?id=160384.
The solution is to make a helper function which returns this built string
so that the caller can own this built string, thereby extending its lifetime.
Unfortunately, this built string can't be a StringView because the same
mechanism must be used for text-combine, which returns originalText(), which
may return a built string if it is a RenderCounter. Perhaps it would be
valuable to migrate RenderCounter::originalText() to something else, or to
divorce text-combine from originalText(), but that is out of scope for this
patch. Similarly, hyphenation uses this same mechanism, but because the
hyphenated string needs to be created, we must own the string storage (so
StringView is incorrect here).
Another reason is for performance: StringView::substring() is faster to use
than String::substringSharingImpl(), since it does not allocate and destroy a
StringImpl on the heap. This patch migrates away from
String::substringSharingImpl() and onto StringView::substring().
No new tests because there is no behavior change.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::hyphenatedStringForTextRun):
(WebCore::InlineTextBox::constructTextRun):
- rendering/InlineTextBox.h:
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::maybeGetCombinedStringForRendering):
(WebCore::RenderCombineText::getStringToRender): Deleted.
- rendering/RenderCombineText.h:
- 6:17 PM Changeset in webkit [204275] by
-
- 6 edits in trunk/Tools
Some EWS console logs doesn't go to log file
https://bugs.webkit.org/show_bug.cgi?id=160585
rdar://problem/24464570
Reviewed by Daniel Bates.
- Scripts/webkitpy/common/system/logutils.py:
(FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
any possible overwriting.
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
- Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.open_text_file_for_writing): Same.
- Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
(RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
This will ensure that all the sub-modules inside webkitpy will log to file.
- 6:06 PM Changeset in webkit [204274] by
-
- 2 edits in trunk/Source/WebCore
Clear fullscreen mode state after exiting fullscreen mode to keep state in sync.
https://bugs.webkit.org/show_bug.cgi?id=160668
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-08-08
Reviewed by Jon Lee.
When exiting fullscreen while in auto picture in picture mode, fullscreen mode gets
out of sync, causing exit fullscreen to fail. This change updates the state
to keep it correct.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
- 5:52 PM Changeset in webkit [204273] by
-
- 4 edits in trunk/Source/WebCore
[Web IDL] We should resolve typedefs for dictionary members
https://bugs.webkit.org/show_bug.cgi?id=160675
Reviewed by Sam Weinig.
Resolve typedefs for dictionary member types.
Added bindings test coverage.
- bindings/scripts/IDLParser.pm:
(applyTypedefs):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convert<TestObj::Dictionary>):
- bindings/scripts/test/TestObj.idl:
- 5:48 PM Changeset in webkit [204272] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for rdar://problem/27711048.
- platform/mac/TestExpectations:
- 5:22 PM Changeset in webkit [204271] by
-
- 6 edits in trunk/Tools
Have the iOS platform interit from the Apple platform in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=160672
Reviewed by Dan Bates.
The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
ApplePort.
Since WinPort also inherits from ApplePort, it needs to stub out some things
that are unavailable on Windows (leaks, sampling).
Some SnowLeopard-related code and the associated test were removed.
- Scripts/webkitpy/port/apple.py:
(ApplePort.init):
(ApplePort):
(ApplePort._make_leak_detector):
(ApplePort.default_timeout_ms):
(ApplePort.supports_per_test_timeout):
(ApplePort.should_retry_crashes):
(ApplePort._generate_all_test_configurations):
(ApplePort.check_for_leaks):
(ApplePort.print_leaks_summary):
(ApplePort._path_to_webcore_library):
(ApplePort.show_results_html_file):
(ApplePort._merge_crash_logs):
(ApplePort._look_for_all_crash_logs_in_log_dir):
(ApplePort._get_crash_log):
(ApplePort.look_for_new_crash_logs):
(ApplePort.sample_process):
(ApplePort.sample_file_path):
(ApplePort.look_for_new_samples):
(ApplePort._path_to_helper):
(ApplePort.determine_full_port_name): Deleted.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort):
(IOSSimulatorPort.init):
(IOSSimulatorPort.default_timeout_ms): Deleted.
(IOSSimulatorPort.supports_per_test_timeout): Deleted.
(IOSSimulatorPort.should_retry_crashes): Deleted.
(IOSSimulatorPort.check_for_leaks): Deleted.
(IOSSimulatorPort.print_leaks_summary): Deleted.
(IOSSimulatorPort._path_to_webcore_library): Deleted.
(IOSSimulatorPort.show_results_html_file): Deleted.
(IOSSimulatorPort.sample_file_path): Deleted.
(IOSSimulatorPort._merge_crash_logs): Deleted.
(IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
(IOSSimulatorPort.look_for_new_crash_logs): Deleted.
(IOSSimulatorPort.look_for_new_samples): Deleted.
(IOSSimulatorPort.sample_process): Deleted.
(IOSSimulatorPort._path_to_helper): Deleted.
(IOSSimulatorPort.make_command): Deleted.
- Scripts/webkitpy/port/mac.py:
(MacPort.init):
(MacPort.make_command):
(MacPort._build_java_test_support):
(MacPort): Deleted.
(MacPort.default_timeout_ms): Deleted.
(MacPort.supports_per_test_timeout): Deleted.
(MacPort.should_retry_crashes): Deleted.
(MacPort.default_child_processes): Deleted.
(MacPort.check_for_leaks): Deleted.
(MacPort.print_leaks_summary): Deleted.
(MacPort._path_to_webcore_library): Deleted.
(MacPort.show_results_html_file): Deleted.
(MacPort.sample_file_path): Deleted.
(MacPort._merge_crash_logs): Deleted.
(MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
(MacPort.look_for_new_crash_logs): Deleted.
(MacPort.look_for_new_samples): Deleted.
(MacPort.sample_process): Deleted.
(MacPort._path_to_helper): Deleted.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_default_child_processes): Deleted.
- Scripts/webkitpy/port/win.py:
(WinPort.look_for_new_samples):
(WinPort):
(WinPort.sample_process):
(WinPort._make_leak_detector):
(WinPort.check_for_leaks):
(WinPort.print_leaks_summary):
(WinPort._path_to_webcore_library):
- 5:08 PM Changeset in webkit [204270] by
-
- 2 edits in trunk/Source/WebCore
Fix the Windows build.
- plugins/PluginInfoProvider.h:
- 5:01 PM Changeset in webkit [204269] by
-
- 2 edits in branches/safari-602-branch/LayoutTests
Merge r204201. rdar://problem/27710755
- 4:43 PM Changeset in webkit [204268] by
-
- 23 edits8 adds in trunk/Source
Add a new PluginInfoProvider class, to replace PluginStrategy
https://bugs.webkit.org/show_bug.cgi?id=160670
Reviewed by Sam Weinig.
Source/WebCore:
Add a per page PluginInfoProvider class that's going to ultimately replace the plug-in strategy.
- WebCore.xcodeproj/project.pbxproj:
- loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::refreshPlugins):
(WebCore::Page::pluginData):
(WebCore::Page::pluginInfoProvider):
- page/Page.h:
- page/PageConfiguration.cpp:
- page/PageConfiguration.h:
- plugins/DOMPluginArray.cpp:
(WebCore::DOMPluginArray::refresh):
- plugins/DOMPluginArray.h:
- plugins/PluginData.cpp:
(WebCore::PluginData::PluginData):
(WebCore::PluginData::webVisiblePlugins):
(WebCore::PluginData::publiclyVisiblePlugins):
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::refresh): Deleted.
- plugins/PluginData.h:
(WebCore::PluginData::create):
(WebCore::PluginData::PluginData): Deleted.
- plugins/PluginInfoProvider.cpp: Added.
(WebCore::PluginInfoProvider::~PluginInfoProvider):
(WebCore::PluginInfoProvider::addPage):
(WebCore::PluginInfoProvider::removePage):
- plugins/PluginInfoProvider.h: Added.
- replay/SerializationMethods.cpp:
(JSC::EncodingTraits<PluginData>::decodeValue):
(JSC::DeserializedPluginData::DeserializedPluginData): Deleted.
Source/WebKit:
Add new files.
- PlatformWin.cmake:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
- WebCoreSupport/WebPluginInfoProvider.h: Added.
- WebCoreSupport/WebPluginInfoProvider.mm: Added.
(WebPluginInfoProvider::singleton):
(WebPluginInfoProvider::WebPluginInfoProvider):
(WebPluginInfoProvider::~WebPluginInfoProvider):
(WebPluginInfoProvider::refreshPlugins):
(WebPluginInfoProvider::getPluginInfo):
(WebPluginInfoProvider::getWebVisiblePluginInfo):
(WebPluginInfoProvider::setPluginLoadClientPolicy):
(WebPluginInfoProvider::clearPluginClientPolicies):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/win:
Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
- WebCoreSupport/WebPluginInfoProvider.cpp: Added.
(WebPluginInfoProvider::singleton):
(WebPluginInfoProvider::WebPluginInfoProvider):
(WebPluginInfoProvider::~WebPluginInfoProvider):
(WebPluginInfoProvider::refreshPlugins):
(WebPluginInfoProvider::getPluginInfo):
(WebPluginInfoProvider::getWebVisiblePluginInfo):
- WebCoreSupport/WebPluginInfoProvider.h: Added.
Source/WebKit2:
Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/WebPluginInfoProvider.cpp: Added.
(WebKit::WebPluginInfoProvider::singleton):
(WebKit::WebPluginInfoProvider::WebPluginInfoProvider):
(WebKit::WebPluginInfoProvider::~WebPluginInfoProvider):
(WebKit::WebPluginInfoProvider::refreshPlugins):
(WebKit::WebPluginInfoProvider::getPluginInfo):
(WebKit::WebPluginInfoProvider::getWebVisiblePluginInfo):
(WebKit::WebPluginInfoProvider::setPluginLoadClientPolicy):
(WebKit::WebPluginInfoProvider::clearPluginClientPolicies):
- WebProcess/Plugins/WebPluginInfoProvider.h: Added.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_userInterfaceLayoutDirection):
- 3:57 PM Changeset in webkit [204267] by
-
- 2 edits1 delete in branches/safari-602-branch/LayoutTests
Test gardening for rdar://problem/27595142.
- 2:43 PM Changeset in webkit [204266] by
-
- 3 edits4 adds in trunk
Popups opened from a sandboxed iframe should themselves be sandboxed
https://bugs.webkit.org/show_bug.cgi?id=134850
<rdar://problem/27375388>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
Now copies the opener's frame loader effective sandbox flags to the
new frame loader.
LayoutTests:
- http/tests/security/resources/anchor-tag-with-blank-target.html: Added.
- http/tests/security/resources/page-executing-javascript.html: Added.
- http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
- http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html: Added.
- 2:41 PM Changeset in webkit [204265] by
-
- 2 edits in trunk/Tools
Unreviewed: moved myself to the reviewers list.
- Scripts/webkitpy/common/config/contributors.json:
- 1:56 PM Changeset in webkit [204264] by
-
- 10 edits in trunk/Source/WebInspectorUI
Web Inspector: Popover for Color Picker should update position when window resizes
https://bugs.webkit.org/show_bug.cgi?id=160321
Reviewed by Brian Burg.
- UserInterface/Views/Popover.js:
(WebInspector.Popover):
(WebInspector.Popover.prototype.set windowResizeHandler):
(WebInspector.Popover.prototype.dismiss):
(WebInspector.Popover.prototype.handleEvent):
(WebInspector.Popover.prototype._addListenersIfNeeded):
The popover already has a set of window listeners, add "resize" to
the list. If there is a resize, invoke a resize handler. The resize
handler will only be called while the popover is visible.
- UserInterface/Views/HeapSnapshotDataGridTree.js:
(WebInspector.HeapSnapshotDataGridTree):
(WebInspector.HeapSnapshotDataGridTree.prototype.get visible):
(WebInspector.HeapSnapshotDataGridTree.prototype.get popoverNode):
(WebInspector.HeapSnapshotDataGridTree.prototype.set popoverNode):
(WebInspector.HeapSnapshotDataGridTree.prototype.get popoverTargetElement):
(WebInspector.HeapSnapshotDataGridTree.prototype.set popoverTargetElement):
(WebInspector.HeapSnapshotDataGridTree.prototype.get popover):
(WebInspector.HeapSnapshotDataGridTree.prototype.willDismissPopover):
- UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
Update heap snapshot popovers to reposition on window resize.
Set a target to reposition around, since the popover is shared.
- UserInterface/Views/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection.prototype._addProbeButtonClicked):
Update probe expression popover to respect window resizes.
- UserInterface/Views/VisualStylePropertyEditor.js:
(WebInspector.VisualStylePropertyEditor.prototype._showPropertyInfoPopover):
Though not yet visible, update this to respect window resizes.
- UserInterface/Views/InlineSwatch.js:
(WebInspector.InlineSwatch.prototype._swatchElementClicked):
Add a window resize handler to reposition over the swatch element.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._updatePopoverForSelectedNode):
(WebInspector.LayerTreeDetailsSidebarPanel): Deleted.
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._windowResized): Deleted.
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._showPopoverForSelectedNodeSoon):
(WebInspector.TimelineDataGrid): Deleted.
(WebInspector.TimelineDataGrid.prototype.closed): Deleted.
(WebInspector.TimelineDataGrid.prototype.handleEvent): Deleted.
(WebInspector.TimelineDataGrid.prototype._windowResized): Deleted.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype.willDismissPopover): Deleted.
Replace custom popover repositioning with standard Popover handling.
- 1:30 PM Changeset in webkit [204263] by
-
- 34 edits2 adds in trunk
Align Selection API with the specification
https://bugs.webkit.org/show_bug.cgi?id=160663
Reviewed by Ryosuke Niwa.
Source/WebCore:
Align Selection API with the specification:
In particular, the following changes were made:
- Mark parameters as non-nullable when they should be.
- Mark parameters as mandatory when they should be.
- Use "unsigned long" type for offsets instead of "long".
This aligns our behavior with Firefox and Chrome.
Note that the Node parameters to setBaseAndExtent() operation were kept
nullable, which does not match the specification. This is intentional
as I worry about compatibility risk, especially considering they are
still nullable in Chrome. Only Firefox marks them as non-nullable.
Test: editing/selection/bad-input.html
- dom/Position.h:
(WebCore::Position::LegacyEditingOffset::value):
(WebCore::Position::LegacyEditingOffset::LegacyEditingOffset):
(WebCore::createLegacyEditingPosition):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::rangeCount):
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::extend):
(WebCore::DOMSelection::getRangeAt):
(WebCore::DOMSelection::addRange):
(WebCore::DOMSelection::deleteFromDocument):
(WebCore::DOMSelection::containsNode):
(WebCore::DOMSelection::selectAllChildren):
(WebCore::DOMSelection::shadowAdjustedOffset):
(WebCore::DOMSelection::modify): Deleted.
(WebCore::DOMSelection::shadowAdjustedNode): Deleted.
(WebCore::DOMSelection::isValidForPosition): Deleted.
- page/DOMSelection.h:
- page/DOMSelection.idl:
LayoutTests:
- editing/selection/bad-input-expected.txt: Added.
- editing/selection/bad-input.html: Added.
Add new layout test to cover passing bad input to the Selection API.
This new test is passing completely in Firefox and Chrome.
- editing/execCommand/apply-style-text-decoration-crash.html:
- editing/execCommand/applyblockelement-visiblepositionforindex-crash.html:
- editing/execCommand/ident-crashes-topnode-is-text.html:
- editing/execCommand/indent-pre-expected.txt:
- editing/execCommand/indent-pre.html:
- editing/execCommand/overtype.html:
- editing/selection/containsNode-expected.txt:
- editing/selection/containsNode.html:
- editing/selection/move-by-line-003.html:
- editing/selection/script-tests/DOMSelection-DocumentType.js:
- editing/selection/script-tests/DOMSelection-crossing-document.js:
(clear):
- editing/selection/selection-invalid-offset-expected.txt:
- fast/block/float/float-list-changed-before-layout-crash.html:
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- fast/events/selectstart-by-arrow-keys.html:
- fast/html/nav-element.html:
- fast/html/script-tests/article-element.js:
- fast/html/script-tests/aside-element.js:
- fast/html/script-tests/footer-element.js:
- fast/html/script-tests/header-element.js:
- fast/html/script-tests/hgroup-element.js:
- fast/html/script-tests/main-element.js:
- fast/html/script-tests/section-element.js:
- imported/blink/accessibility/event-on-deleted-iframe-causes-crash.html:
- imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html:
- svg/custom/unicode-in-tspan-multi-svg-crash.html:
Update existing tests to use the Selection API properly.
- 12:39 PM Changeset in webkit [204262] by
-
- 2 edits in trunk/Source/WebCore
Regression(r204239): Caused flaky crashes under ~Database()
https://bugs.webkit.org/show_bug.cgi?id=160665
<rdar://problem/27748065>
Reviewed by Brady Eidson.
Make sure the scriptExecution context only gets ref'd / deref'd
on the context thread. Document / WorkerGlobalScope are not
ThreadSafeRefCounted.
No new tests, already covered by:
storage/websql/open-database-creation-callback.html
- Modules/webdatabase/Database.cpp:
(WebCore::Database::~Database):
- 11:56 AM Changeset in webkit [204261] by
-
- 4 edits in trunk
ASSERTION FAILED: hasInlineStorage() in JSFinalObject::visitChildren().
https://bugs.webkit.org/show_bug.cgi?id=160666
Reviewed by Keith Miller.
JSTests:
- stress/object-constructor-should-be-new-target-aware.js:
Source/JavaScriptCore:
This assertion is benign. JSFinalObject::visitChildren() calls
JSObject::inlineStorage() to get a pointer to the object's inline storage, and
later passes it to visitor.appendValuesHidden() with a previously computed
storageSize. When storageSize is 0, appendValuesHidden() ends up doing nothing.
However, before we get there, JSObject::inlineStorage() will be asserting
hasInlineStorage() and this assertion will fail when storageSize is 0.
We can fix this assertion failure by simply adding a storageSize check before
calling hasInlineStorage() and visitor.appendValuesHidden().
- runtime/JSObject.cpp:
(JSC::JSFinalObject::visitChildren):
- 11:38 AM Changeset in webkit [204260] by
-
- 13 edits2 adds in trunk
Don't set document.domain to an IP address fragment
https://bugs.webkit.org/show_bug.cgi?id=126045
<rdar://problem/27331794>
Reviewed by Daniel Bates.
Source/WebCore:
This patch matches the following Blink one:
https://chromium.googlesource.com/chromium/blink//b19a57fdb323d5a80d3a1cb0a6b343558c4237b0
IP address octets should not be treated as subdomains when setting
document.domain. The specs say:
'The domain attribute's setter must run these steps: ...
- If host is not equal to effectiveDomain, then run these substeps:
- If host or effectiveDomain is not a domain, then throw a "SecurityError" DOMException.'
https://html.spec.whatwg.org/multipage/browsers.html#relaxing-the-same-origin-restriction
Last Updated 5 August 2016
'A host is a domain, an IPv4 address, or an IPv6 address.'
https://url.spec.whatwg.org/#concept-domain
Last Updated 28 July 2016
Test: http/tests/security/set-domain-remove-subdomain-for-ip-address.html
- dom/Document.cpp:
(WebCore::Document::setDomain):
Now checks whether the security origin is allowed to remove
subdomains. If not, it throws a security error.
- page/OriginAccessEntry.cpp:
(WebCore::OriginAccessEntry::OriginAccessEntry):
Constructor now expects an IP address setting.
(WebCore::OriginAccessEntry::matchesOrigin):
Now also checks whether the host in an IP address and returns
false if IP addresses aren't configured to be treated as domains.
- page/OriginAccessEntry.h:
Introduced new enum for IP address setting.
Constructor now expects an IP address setting.
(WebCore::OriginAccessEntry::ipAddressSettings):
New getter.
(WebCore::operator==):
Now also requires IP address settings to match.
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
Changes to match OriginAccessEntry's new constructor.
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
Changes to match OriginAccessEntry's new constructor.
- page/Settings.in:
Added a setting to allow IP address octets to be treated as
subdomains. This way our existing tests setting document.domain
still work.
LayoutTests:
IP address octets should not be treated as subdomains when setting document.domain.
- http/tests/security/aboutBlank/security-context-alias.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/security/aboutBlank/security-context-grandchildren-alias.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/security/set-domain-remove-subdomain-for-ip-address-expected.txt: Added.
- http/tests/security/set-domain-remove-subdomain-for-ip-address.html: Added.
- http/tests/security/setDomainRelaxationForbiddenForURLScheme.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/workers/worker-document-domain-security.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/xmlhttprequest/document-domain-set.html:
Now enables the new setting treatIPAddressesAsDomains.
- 10:54 AM Changeset in webkit [204259] by
-
- 57 edits5 deletes in trunk/Source/WebCore
Remove more unused bindings code
https://bugs.webkit.org/show_bug.cgi?id=160568
Reviewed by Sam Weinig.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMDocument.mm:
(-[DOMDocument execCommand:userInterface:]):
(-[DOMDocument execCommand:]):
(-[DOMDocument getMatchedCSSRules:pseudoElement:]):
- bindings/objc/DOMHTMLBaseFontElement.mm:
- bindings/objc/DOMHTMLCollection.mm:
(-[DOMHTMLCollection tags:]):
- bindings/objc/DOMWheelEvent.mm:
(-[DOMWheelEvent isHorizontal]):
- css/RGBColor.idl:
- dom/Attr.idl:
- dom/DOMImplementation.idl:
- dom/Document.h:
- dom/Document.idl:
- dom/Element.idl:
- dom/EventException.h: Removed.
(WebCore::EventException::EventException): Deleted.
- dom/EventException.idl: Removed.
- dom/KeyboardEvent.idl:
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::messagePort): Deleted.
(WebCore::MessageEvent::initMessageEvent): Deleted.
- dom/MessageEvent.h:
- dom/MessagePort.cpp:
(WebCore::MessagePort::postMessage): Deleted.
- dom/MessagePort.h:
- dom/Node.idl:
- dom/NodeFilter.idl:
- dom/OverflowEvent.idl:
- dom/WheelEvent.h:
- dom/WheelEvent.idl:
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::tags):
- html/HTMLAllCollection.h:
- html/HTMLAnchorElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBaseFontElement.cpp: Removed.
(WebCore::HTMLBaseFontElement::HTMLBaseFontElement): Deleted.
- html/HTMLBaseFontElement.h: Removed.
- html/HTMLBaseFontElement.idl: Removed.
- html/HTMLButtonElement.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::tags): Deleted.
- html/HTMLCollection.h:
- html/HTMLCollection.idl:
- html/HTMLElement.idl:
- html/HTMLFieldSetElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLHyperlinkElementUtils.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLLabelElement.idl:
- html/HTMLLegendElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.idl:
- html/HTMLTableCellElement.idl:
- html/HTMLTextAreaElement.idl:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::postMessage): Deleted.
- page/DOMWindow.h:
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::postMessage): Deleted.
- workers/DedicatedWorkerGlobalScope.h:
- workers/Worker.cpp:
(WebCore::Worker::postMessage): Deleted.
- workers/Worker.h:
- 10:26 AM Changeset in webkit [204258] by
-
- 2 edits in trunk/LayoutTests
Land test expectations for rdar://problem/27711048.
- platform/mac/TestExpectations:
- 10:25 AM Changeset in webkit [204257] by
-
- 15 edits in trunk/Source
Addressing late review feedback in bug 160605
https://bugs.webkit.org/show_bug.cgi?id=160605
Reviewed by Darin's suggestions.
Source/WebCore:
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::maybeStartMonitoringGamepads):
(WebCore::GamepadManager::maybeStopMonitoringGamepads):
- platform/gamepad/EmptyGamepadProvider.cpp:
(WebCore::EmptyGamepadProvider::startMonitoringGamepads):
(WebCore::EmptyGamepadProvider::stopMonitoringGamepads):
- platform/gamepad/EmptyGamepadProvider.h:
- platform/gamepad/GamepadProvider.h:
- platform/gamepad/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::startMonitoringGamepads):
(WebCore::HIDGamepadProvider::stopMonitoringGamepads):
- platform/gamepad/mac/HIDGamepadProvider.h:
(WebCore::HIDGamepadProvider::platformGamepads): Deleted.
Source/WebKit2:
- UIProcess/Gamepad/UIGamepadProvider.cpp:
(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
- UIProcess/Gamepad/UIGamepadProvider.h:
- UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:
(WebKit::UIGamepadProvider::platformStartMonitoringGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringGamepads):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::startedUsingGamepads):
(WebKit::WebProcessPool::stoppedUsingGamepads):
(WebKit::WebProcessPool::processStoppedUsingGamepads):
- UIProcess/WebProcessPool.h:
- WebProcess/Gamepad/WebGamepadProvider.cpp:
(WebKit::WebGamepadProvider::startMonitoringGamepads):
(WebKit::WebGamepadProvider::stopMonitoringGamepads):
- WebProcess/Gamepad/WebGamepadProvider.h:
- 10:24 AM Changeset in webkit [204256] by
-
- 2 edits in trunk/Tools
Update API tests in mac/SetDocumentURI.mm after r204247
https://bugs.webkit.org/show_bug.cgi?id=160660
Reviewed by Alex Christensen.
- TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
(TestWebKitAPI::TEST):
- 9:43 AM Changeset in webkit [204255] by
-
- 18 edits in trunk/Source/JavaScriptCore
Web Inspector: clean up prefixing of Automation protocol generated files
https://bugs.webkit.org/show_bug.cgi?id=160635
<rdar://problem/27735327>
Reviewed by Timothy Hatcher.
Introduce different settings for the 'protocol group' name for C++ vs. Objective-C.
Use 'WD' as the prefix for generated Objective-C frontend dispatchers and helpers.
Continue using 'Automation' as the prefix for generated C++ backend dispatchers.
- inspector/scripts/codegen/cpp_generator.py:
(CppGenerator.protocol_name):
- inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:
(ObjCProtocolTypeConversionsImplementationGenerator.generate_output):
(ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_category_interface):
(ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_category_implementation):
Adjust the class name. Generate one category per protocol domain to keep it easy to read.
- inspector/scripts/codegen/models.py:
- inspector/scripts/codegen/objc_generator.py:
(ObjCGenerator.protocol_name):
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
Rebaseline test results.
- 9:35 AM Changeset in webkit [204254] by
-
- 5 edits2 adds in trunk
It should be possible to re-initialize an Event after it's been dispatched
https://bugs.webkit.org/show_bug.cgi?id=160651
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/events/Event-propagation-expected.txt:
Source/WebCore:
Allow re-initialization of an Event that's already been dispatched, as
per the latest DOM specification:
Firefox already follows the specification here.
No new tests, rebaselined existing test.
Test: fast/events/initEvent-after-dispatch.html
- dom/Event.cpp:
(WebCore::Event::initEvent):
- Replace dispatched() check with isBeingDispatched() in order to allow initialization of an already dispatched event but prevent initialization of an event that is currently being dispatched as per: https://dom.spec.whatwg.org/#dom-event-initevent (step 1)
- Reset target to null as per: https://dom.spec.whatwg.org/#concept-event-initialize (step 4)
LayoutTests:
Add layout test coverage.
- fast/events/initEvent-after-dispatch-expected.txt: Added.
- fast/events/initEvent-after-dispatch.html: Added.
- 9:18 AM Changeset in webkit [204253] by
-
- 8 edits in trunk/Tools
run-webkit-tests should trigger a spindump when WebContent process is unresponsive
https://bugs.webkit.org/show_bug.cgi?id=159827
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-08
Reviewed by Daniel Bates.
This change was spurred by a process hang which occurred between tests and did
not produce a meaningful crashlog.
- Scripts/webkitpy/port/driver.py:
(Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort):
(IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
- Scripts/webkitpy/port/mac.py:
(MacPort):
(MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
- Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
- Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
- WebKitTestRunner/TestController.h:
(WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
Aug 7, 2016:
- 11:05 PM Changeset in webkit [204252] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r204236.
Text.replaceWholeText was removed from DOM API.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_text_replace_whole_text):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- 10:54 PM Changeset in webkit [204251] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API break after r204113.
Document.defaultCharset was removed from DOM API.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_document_get_default_charset):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- 10:40 PM Changeset in webkit [204250] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Bad performance in accelerated compositing mode with the modesetting intel driver and DRI3 enabled
https://bugs.webkit.org/show_bug.cgi?id=160491
Reviewed by Michael Catanzaro.
This is becoming the default in several linux distributions and it makes WebKitGTK+ unusable in accelerated
compositing mode, which is now always enabled because since we switched to use the threaded compositor. The
problem seems to be an optimization of the intel driver for windows that are offscreen, and our redirected
window is always positioned at ScreenWidth + 1, 0. Using negative coordinates to position the redirected window
offscreen fixes the problem.
See also https://bugs.freedesktop.org/show_bug.cgi?id=85064.
- WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp:
(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow): Position the parent window at -1, -1.
- 10:38 PM Changeset in webkit [204249] by
-
- 9 edits2 moves in trunk/Source/WebKit2
Duplicated code in DrawingAreaProxyImpl and CoordinatedDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=160506
Reviewed by Michael Catanzaro.
Same logic as in r202855 but in the UI process. CoordinatedDrawingAreaProxy is just a copy paste of
DrawingAreaProxyImpl with non-accelerated code path removed. There's actually nothing (or very little) specific
to coordinated graphics in the CoordinatedDrawingAreaProxy implementation. This patch renames
CoordinatedDrawingAreaProxy as AcceleratedDrawingAreaProxy and makes DrawingAreaProxyImpl inherit from it, so
that in case of accelerated compositing the parent class is used, and DrawingAreaProxyImpl only adds the non
accelerated code path.
To simplify the common API of AcceleratedDrawingAreaProxy, I have changed CoordinatedLayerTreeHostProxy to
receive a WebPageProxy in the constructor instead of a drawing area, since the drawing area was used just to get
the page proxy.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- UIProcess/AcceleratedDrawingAreaProxy.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp.
(WebKit::AcceleratedDrawingAreaProxy::AcceleratedDrawingAreaProxy):
(WebKit::AcceleratedDrawingAreaProxy::~AcceleratedDrawingAreaProxy):
(WebKit::AcceleratedDrawingAreaProxy::alwaysUseCompositing):
(WebKit::AcceleratedDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::AcceleratedDrawingAreaProxy::sizeDidChange):
(WebKit::AcceleratedDrawingAreaProxy::deviceScaleFactorDidChange):
(WebKit::AcceleratedDrawingAreaProxy::visibilityDidChange):
(WebKit::AcceleratedDrawingAreaProxy::waitForBackingStoreUpdateOnNextPaint):
(WebKit::AcceleratedDrawingAreaProxy::didUpdateBackingStoreState):
(WebKit::AcceleratedDrawingAreaProxy::enterAcceleratedCompositingMode):
(WebKit::AcceleratedDrawingAreaProxy::exitAcceleratedCompositingMode):
(WebKit::AcceleratedDrawingAreaProxy::updateAcceleratedCompositingMode):
(WebKit::AcceleratedDrawingAreaProxy::backingStoreStateDidChange):
(WebKit::AcceleratedDrawingAreaProxy::sendUpdateBackingStoreState):
(WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState):
(WebKit::AcceleratedDrawingAreaProxy::setNativeSurfaceHandleForCompositing):
(WebKit::AcceleratedDrawingAreaProxy::destroyNativeSurfaceHandleForCompositing):
- UIProcess/AcceleratedDrawingAreaProxy.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h.
(WebKit::AcceleratedDrawingAreaProxy::isInAcceleratedCompositingMode):
(WebKit::AcceleratedDrawingAreaProxy::coordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::updateViewport):
(WebKit::CoordinatedLayerTreeHostProxy::commitCoordinatedGraphicsState):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHostProxy::renderNextFrame):
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- UIProcess/CoordinatedGraphics/PageViewportController.cpp:
(WebKit::PageViewportController::syncVisibleContents):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::paint):
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::~DrawingAreaProxyImpl): Deleted.
(WebKit::DrawingAreaProxyImpl::update): Deleted.
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Deleted.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon): Deleted.
(WebKit::DrawingAreaProxyImpl::discardBackingStore): Deleted.
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setVisible):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::createDrawingAreaProxy):
- 7:48 PM Changeset in webkit [204248] by
-
- 11 edits8 adds in trunk
[ES6] Module namespace object should not allow unset IC
https://bugs.webkit.org/show_bug.cgi?id=160553
Reviewed by Saam Barati.
JSTests:
- modules/namespace-object-get-property.js: Added.
(import.as.ns.from.string_appeared_here.shouldThrow):
- modules/namespace-object-has-property.js: Added.
- modules/namespace-object-inline-caching.js: Added.
(import.as.A.from.string_appeared_here.import.as.B.from.string_appeared_here.lookup):
(shouldBe.lookup.lookup):
(shouldBe.lookup):
- modules/namespace-object-inline-caching/a.js: Added.
- modules/namespace-object-inline-caching/b.js: Added.
- modules/namespace-object-try-get.js: Added.
(import.as.ns.from.string_appeared_here.tryGetByIdText):
(tryGetByIdTextStrict):
- modules/namespace-object-typed-array-fast-path.js: Added.
- test262.yaml:
Source/JavaScriptCore:
Previously, module namespace object accidentally allow "unset IC". But this "unsetness" does not rely on
the structure. We should disable inline caching onto the namespace object. Once it is needed, we should
create the special caching for namespace object like the following: it should be similar to monomorphic IC,
but it caches the object itself instead of the structure. It checks the object itself (And in DFG, it should be
CheckCell) and loads the value from the target module environment directly[1].
And this patch also set setIsTaintedByProxy for the module namespace object to notify to the caller that
this object has impure ::getOwnPropertySlot. Then this function is now renamed to setIsTaintedByOpaqueObject.
We drop the hack in JSModuleNamespaceObject::getOwnPropertySlot since we already introduced InternalMethodType
for ProxyObject. Previously we cannot distinguish ::HasProperty and ::GetOwnProperty. So not to throw any
errors for ::HasProperty case, we used slot.setCustom to delay the observable operation.
But, this hack lacks the support for hasOwnProperty: hasOwnProperty uses GetOwnProperty, so it should throw an error.
However the previous implementation does not throw an error since the delayed observable part (custom function part) is
skipped in hasOwnProperty implementation. We now remove this custom property hack and fix the corresponding failure
in test262.
[1]: https://bugs.webkit.org/show_bug.cgi?id=160590
- jit/JITOperations.cpp:
- runtime/ArrayPrototype.cpp:
(JSC::getProperty):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlot):
(JSC::callbackGetter): Deleted.
- runtime/JSModuleNamespaceObject.h:
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::getPureResult):
- runtime/PropertySlot.h:
(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::setIsTaintedByOpaqueObject):
(JSC::PropertySlot::isTaintedByOpaqueObject):
(JSC::PropertySlot::setIsTaintedByProxy): Deleted.
(JSC::PropertySlot::isTaintedByProxy): Deleted.
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::getOwnPropertySlotCommon):
- 7:47 PM Changeset in webkit [204247] by
-
- 10 edits3 deletes in trunk
Node.baseURI should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=160649
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/dom/interfaces-expected.txt:
Rebaseline now that one more check is passing.
- web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
Rebaseline now that the baseURI is "about:blank" instead of null. The check
is still failing. We are falling back to using the document's URL, as expected.
However, the document's URL should not be "about:blank" in this case, which is
why we are failing the previous check.
Source/WebCore:
Node.baseURI should not be nullable as per the latest DOM specification:
It is not nullable in Firefox. It is supposed to fallback to using the
document's URL. The document's URL is "about:blank" by default so
baseURI() now returns "about:blank" in the internal URL is null,
similarly to what we do for Document.URL (c.g. urlForBindings()).
No new tests, rebaselined existing test.
- dom/Node.cpp:
(WebCore::Node::baseURI):
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
Drop outdated DOM test.
- dom/xhtml/level3/core/nodegetbaseuri02-expected.txt: Removed.
- dom/xhtml/level3/core/nodegetbaseuri02.js: Removed.
- dom/xhtml/level3/core/nodegetbaseuri02.xhtml: Removed.
- 6:33 PM Changeset in webkit [204246] by
-
- 22 edits in trunk
Drop SVGDocument as per the SVG2 specification
https://bugs.webkit.org/show_bug.cgi?id=160361
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
Source/WebCore:
Drop SVGDocument as per the SVG2 specification:
SVGDocument has been merged into Document.
Chrome and Edge have dropped SVGDocument already, Firefox has not.
No new tests, rebaselined existing test.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
- bindings/js/JSDocumentCustom.cpp:
(WebCore::createNewDocumentWrapper): Deleted.
- bindings/js/JSXMLDocumentCustom.cpp:
(WebCore::toJSNewlyCreated):
(WebCore::toJS): Deleted.
- page/DOMWindow.idl:
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::rootElement):
(WebCore::SVGDocument::zoomAndPanEnabled):
(WebCore::SVGDocument::startPan):
(WebCore::SVGDocument::updatePan):
- svg/SVGDocument.h:
- svg/SVGDocument.idl:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::rootElement):
LayoutTests:
Update / rebaseline existing tests to reflect behavior change.
- platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt:
- svg/custom/clone-node-expected.txt:
- svg/custom/clone-node.html:
- svg/custom/frame-getSVGDocument.html:
- svg/custom/global-constructors-expected.txt:
- svg/custom/manually-parsed-svg-allowed-in-dashboard-expected.txt:
- svg/custom/script-tests/global-constructors.js:
- 1:50 PM Changeset in webkit [204245] by
-
- 10 edits in trunk
[Cocoa] Reply block leaks if the remote object doesn’t call it
https://bugs.webkit.org/show_bug.cgi?id=160642
Reviewed by Sam Weinig.
Source/WebKit2:
- Shared/API/Cocoa/RemoteObjectRegistry.h: Declared new member functions.
- Shared/API/Cocoa/RemoteObjectRegistry.messages.in: Added ReleaseUnusedReplyBlock message.
- Shared/API/Cocoa/RemoteObjectRegistry.mm:
(WebKit::RemoteObjectRegistry::sendUnusedReply): Send the ReleaseUnusedReplyBlock message.
(WebKit::RemoteObjectRegistry::releaseUnusedReplyBlock): Message receiver that call through
to -_releaseReplyWithID:.
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _invokeMethod:]): Define a ReplyBlockCallChecker object and
capture an instance of it in the reply block we pass to the exported object. Have that
block set a flag on the checker when it’s called. If the checker gets destroyed without
the block having been called, which means that the block got destroyed without being
called, call sendUnusedReply to let the other side know that the block will not be invoked.
(-[_WKRemoteObjectRegistry _releaseReplyWithID:]): Added. Removed the pending reply from the
map, which release the block.
- Shared/API/Cocoa/_WKRemoteObjectRegistryInternal.h:
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
(TEST): Added a test case that checks that the reply block is released even when it’s not
called.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
calling the completion handler.
- 12:40 PM Changeset in webkit [204244] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION (r201245): switching between Computed and Visual Styles panels causes internal error
https://bugs.webkit.org/show_bug.cgi?id=160604
<rdar://problem/27723416>
Reviewed by Timothy Hatcher.
- UserInterface/Views/StyleDetailsPanel.js:
(WebInspector.StyleDetailsPanel.prototype.shown):
Only perform a layout if needed. Subclasses access node style
data during layout, which may not exist yet.
- 12:08 PM Changeset in webkit [204243] by
-
- 5 edits in trunk
Write API test to cover crash fix in r204135
https://bugs.webkit.org/show_bug.cgi?id=160587
Reviewed by Darin Adler.
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::terminateProcess):
Stop calling resetStateAfterProcessExited() after calling
requestTermination() because requestTermination() now calls
didClose() which calls processDidCrash() which already calls
resetStateAfterProcessExited(). Because the processDidCrash()
delegates may start new loads, we really do not want to
reset the state again after calling the delegates.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):
- Call didClose() in WebProcessProxy::requestTermination() so that the processDidCrash() delegates get called in API tests whenever a WebContent process is terminated to simulate a crash.
- Stop calling shutDown() and webConnection()->didClose() because didClose() already does this for us.
Tools:
Add API test to cover crash fix in r204135. This reproduces the crash
by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
callback.
- TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
(-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
(TEST):
- 10:14 AM Changeset in webkit [204242] by
-
- 17 edits in trunk
Un-expose DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=160643
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Un-expose DOMSettableTokenList. We merged DOMSettableTokenList into
DOMTokenList a while back, as per the specification. At the time, we
kept DOMSettableTokenList on Window, as an alias to DOMTokenList.
However, Firefox and Chrome dropped DOMSettableTokenList completely.
We now do the same as other browsers.
No new tests, rebaselined existing test.
- page/DOMWindow.idl:
LayoutTests:
Update / rebaseline existing tests.
- fast/dom/HTMLLinkElement/sizes-setter-expected.txt:
- fast/dom/HTMLLinkElement/sizes-setter.html:
- fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
- fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
- fast/frames/sandbox-attribute-expected.txt:
- fast/frames/sandbox-attribute.html:
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 10:05 AM Changeset in webkit [204241] by
-
- 2 edits in trunk/Source/WebCore
DocumentRuleSets::collectFeatures() should shrink-to-fit.
<https://webkit.org/b/160646>
Reviewed by Darin Adler.
We forgot to shrink-wrap the RuleFeatureSet in DocumentRuleSets
after collecting the document-wide features.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::collectFeatures):
- 12:40 AM Changeset in webkit [204240] by
-
- 2 edits in trunk/LayoutTests
LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=160510
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-07
- TestExpectations: Marking fetch-in-worker-crash.html as flaky
Aug 6, 2016:
- 10:52 PM Changeset in webkit [204239] by
-
- 45 edits in trunk/Source/WebCore
Purge all uses of PassRefPtr in WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=159965
Reviewed by Chris Dumez.
Final clean up in Modules directory.
No new tests, no behavior changes.
- Modules/gamepad/deprecated/GamepadList.cpp:
(WebCore::GamepadList::set):
- Modules/gamepad/deprecated/GamepadList.h:
- Modules/indexeddb/IDBGetResult.h:
(WebCore::IDBGetResult::IDBGetResult):
- Modules/indieui/UIRequestEvent.cpp:
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
- Modules/indieui/UIRequestEvent.h:
(WebCore::UIRequestEvent::receiver):
- Modules/mediasource/MediaSourceRegistry.h:
- Modules/mediasource/SampleMap.cpp:
(WebCore::SampleMap::addSample):
- Modules/mediasource/SampleMap.h:
(WebCore::SampleMap::addRange):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::textTrackAddCue):
(WebCore::SourceBuffer::textTrackRemoveCue):
- Modules/mediasource/SourceBuffer.h:
- Modules/mediastream/CaptureDeviceManager.cpp:
(CaptureDeviceManager::bestSourcesForTypeAndConstraints):
- Modules/mediastream/CaptureDeviceManager.h:
- Modules/mediastream/MediaDevicesRequest.h:
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalRemoveTrack):
- Modules/mediastream/MediaStreamRegistry.h:
- Modules/mediastream/MediaStreamTrackEvent.cpp:
(WebCore::MediaStreamTrackEvent::create):
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::track):
- Modules/mediastream/MediaStreamTrackEvent.h:
- Modules/mediastream/MediaTrackConstraints.cpp:
(WebCore::MediaTrackConstraints::create):
(WebCore::MediaTrackConstraints::MediaTrackConstraints):
(WebCore::MediaTrackConstraints::optional):
- Modules/mediastream/MediaTrackConstraints.h:
- Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::create):
(WebCore::RTCDTMFSender::RTCDTMFSender):
- Modules/mediastream/RTCDTMFSender.h:
- Modules/mediastream/RTCDataChannelEvent.cpp:
(WebCore::RTCDataChannelEvent::create):
(WebCore::RTCDataChannelEvent::RTCDataChannelEvent):
(WebCore::RTCDataChannelEvent::channel):
- Modules/mediastream/RTCDataChannelEvent.h:
- Modules/mediastream/RTCIceServer.h:
- Modules/mediastream/RTCStatsReport.h:
- Modules/mediastream/SourceInfo.cpp:
(WebCore::SourceInfo::create):
(WebCore::SourceInfo::SourceInfo):
- Modules/mediastream/SourceInfo.h:
- Modules/mediastream/UserMediaClient.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::didCreateStream):
- Modules/mediastream/UserMediaRequest.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::~Database):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackAddCue):
(WebCore::HTMLMediaElement::textTrackRemoveCue):
- html/HTMLMediaElement.h:
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::textTrackAddCue):
(WebCore::HTMLTrackElement::textTrackRemoveCue):
- html/HTMLTrackElement.h:
- html/track/TextTrack.h:
- platform/graphics/SourceBufferPrivateClient.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):
- platform/mediastream/MediaStreamCreationClient.h:
- platform/mediastream/mac/AVCaptureDeviceManager.h:
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::bestSourcesForTypeAndConstraints):
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
- platform/mock/mediasource/MockSourceBufferPrivate.cpp:
(WebCore::MockSourceBufferPrivate::didReceiveSample):
- 9:21 PM Changeset in webkit [204238] by
-
- 4 edits in trunk
Unreviewed, rolling out r204226.
Broke some API tests
Reverted changeset:
"Write API test to cover crash fix in r204135"
https://bugs.webkit.org/show_bug.cgi?id=160587
http://trac.webkit.org/changeset/204226
- 8:22 PM Changeset in webkit [204237] by
-
- 5 edits2 adds in trunk
a.replaceChild(a, a) should throw a HierarchyRequestError
https://bugs.webkit.org/show_bug.cgi?id=160640
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
Source/WebCore:
a.replaceChild(a, a) should throw a HierarchyRequestError, because 'a'
is a host-including inclusive ancestor of 'a':
However, the call is merely ignored in WebKit.
No new tests, rebaselined existing test.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
LayoutTests:
- fast/dom/Node/replaceChild-notFoundError-expected.txt: Added.
- fast/dom/Node/replaceChild-notFoundError.html: Added.
- 8:06 PM Changeset in webkit [204236] by
-
- 12 edits17 deletes in trunk
Drop legacy Text.replaceWholeText() API
https://bugs.webkit.org/show_bug.cgi?id=160641
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop legacy Text.replaceWholeText() API, which is no longer in the
specification:
Firefox and Chrome already dropped support for it.
No new tests, rebaselined existing test.
- dom/Text.idl:
LayoutTests:
Drop outdated tests / checks.
- dom/xhtml/level3/core/textreplacewholetext01-expected.txt: Removed.
- dom/xhtml/level3/core/textreplacewholetext01.js: Removed.
- dom/xhtml/level3/core/textreplacewholetext01.xhtml: Removed.
- dom/xhtml/level3/core/textreplacewholetext02-expected.txt: Removed.
- dom/xhtml/level3/core/textreplacewholetext02.js: Removed.
- dom/xhtml/level3/core/textreplacewholetext02.xhtml: Removed.
- dom/xhtml/level3/core/textreplacewholetext03-expected.txt: Removed.
- dom/xhtml/level3/core/textreplacewholetext03.js: Removed.
- dom/xhtml/level3/core/textreplacewholetext03.xhtml: Removed.
- dom/xhtml/level3/core/textreplacewholetext04-expected.txt: Removed.
- dom/xhtml/level3/core/textreplacewholetext04.js: Removed.
- dom/xhtml/level3/core/textreplacewholetext04.xhtml: Removed.
- dom/xhtml/level3/core/textreplacewholetext05-expected.txt: Removed.
- dom/xhtml/level3/core/textreplacewholetext05.js: Removed.
- dom/xhtml/level3/core/textreplacewholetext05.xhtml: Removed.
- fast/dom/Attr/change-id-via-attr-node-value-expected.txt:
- fast/dom/Attr/change-id-via-attr-node-value.html:
- fast/dom/Text/replaceWholeText-expected.txt: Removed.
- fast/dom/Text/replaceWholeText.html: Removed.
- fast/storage/storage-detached-iframe-expected.txt:
- fast/storage/storage-detached-iframe.html:
- http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
- http/tests/security/xss-DENIED-iframe-src-alias.html:
- platform/mac/inspector/model/remote-object-expected.txt:
- 7:43 PM Changeset in webkit [204235] by
-
- 10 edits in trunk
Align Range.createContextualFragment() input validation with the specification
https://bugs.webkit.org/show_bug.cgi?id=160634
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/domparsing/createContextualFragment-expected.txt:
Source/WebCore:
Align Range.createContextualFragment() input validation with the specification:
In particular, we were throwing a NOT_SUPPORTED_ERR when element had localname
"html" but was not in the HTML namespace. We should not throw in this case.
Firefox complies with the specification here.
No new tests, rebaselined existing test.
- dom/Range.cpp:
(WebCore::Range::createContextualFragment): Deleted.
- 7:29 PM Changeset in webkit [204234] by
-
- 9 edits in trunk
[Web IDL] Add support for [Unscopable] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=160637
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/nodes/remove-unscopable-expected.txt:
Source/WebCore:
Add support for [Unscopable] extended attribute:
No new tests, rebaselined existing test.
- bindings/scripts/CodeGeneratorJS.pm:
(addUnscopableProperties):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
- bindings/scripts/test/TestObj.idl:
- dom/ChildNode.idl:
- dom/ParentNode.idl:
- 6:50 PM Changeset in webkit [204233] by
-
- 4 edits in trunk/Source/WebInspectorUI
REGRESSION (r203253): Node details sidebar flickers while resizing
https://bugs.webkit.org/show_bug.cgi?id=160631
<rdar://problem/27733024>
Reviewed by Timothy Hatcher.
Sidebar panel layouts can be expensive, and should be performed only
when necessary (i.e., when the panel is shown for the first time, or
model data changed while the panel was hidden).
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype._recalculateWidth):
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel.prototype.shown):
- UserInterface/Views/View.js:
(WebInspector.View.prototype.updateLayoutIfNeeded):
Update the layout if an initial layout was never performed.
- 6:41 PM Changeset in webkit [204232] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] -[_WKRemoteObjectRegistry() _invokeMethod:] leaks a block
https://bugs.webkit.org/show_bug.cgi?id=160636
Reviewed by Darin Adler.
- Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
(-[_WKRemoteObjectRegistry _invokeMethod:]): Release the block returned from
NSMakeSpecialForwardingCaptureBlock.
- 4:43 PM Changeset in webkit [204231] by
-
- 3 edits in trunk/LayoutTests/imported/w3c
imported/w3c/web-platform-tests/fetch/api/basic/mode-same-origin.html and -worker.html are failing after r204224
https://bugs.webkit.org/show_bug.cgi?id=160639
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-06
- web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt: Rebaased after redirect.py update in
https://bugs.webkit.org/show_bug.cgi?id=160593.
- web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt: Ditto.
- 12:33 PM Changeset in webkit [204230] by
-
- 3 edits in trunk/Tools
EWS Style Queue fails to process patches which fails validation
https://bugs.webkit.org/show_bug.cgi?id=160632
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.validate): Add more information about validation failure.
(StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_non_valid_patch): Add a unit test to test the above code path.
- 11:23 AM Changeset in webkit [204229] by
-
- 1 copy in tags/Safari-602.1.50
New tag.
- 11:19 AM Changeset in webkit [204228] by
-
- 2 edits in trunk/Source/WebCore
Simplify valueToUSVString
https://bugs.webkit.org/show_bug.cgi?id=160628
Reviewed by Sam Weinig.
- bindings/js/JSDOMBinding.cpp:
(WebCore::isUnmatchedSurrogatePair): Deleted. This function was incorrectly named,
since it actually returned true if any surrogate code unit was passed.
(WebCore::valueToUSVString): Added a fast path for 8-bit characters that doesn't
bother iterating the string at all. Changed the fast path to actually check for
surrogate pairs. Use StringView::codePoints rather than writing our own loop that
does the same thing. In the slow path, use StringView::codePoints to make the logic
clear rather than writing out exactly what the specification says. This gets rid of
all the many constants the old version of the function contained.
- 9:01 AM Changeset in webkit [204227] by
-
- 6 edits2 adds in trunk
WTF needs a variant implementation
https://bugs.webkit.org/show_bug.cgi?id=160618
Patch by Sam Weinig <sam@webkit.org> on 2016-08-06
Reviewed by Darin Adler.
Source/WTF:
Add an implementation of std::experimental::variant matching the C++17 draft http://wg21.link/n4606
taken from https://bitbucket.org/anthonyw/variant/src (5bce47fa788648f79e5ea1d77b0eef2e8f0b2999) and
modified to support compiling without exceptions (where it used to throw, we lovingly CRASH()).
- WTF.xcodeproj/project.pbxproj:
Add new file.
- wtf/Compiler.h:
Add COMPILER_SUPPORTS define for C++ exceptions.
- wtf/Variant.h: Added.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
Add tests for the variant implementation.
- 8:13 AM Changeset in webkit [204226] by
-
- 4 edits in trunk
Write API test to cover crash fix in r204135
https://bugs.webkit.org/show_bug.cgi?id=160587
Reviewed by Darin Adler.
Source/WebKit2:
Call didClose() in WebProcessProxy::requestTermination() so that
the processDidCrash() delegates get called in API tests whenever
a WebContent process is terminated to simulate a crash.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):
Tools:
Add API test to cover crash fix in r204135. This reproduces the crash
by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
callback.
- TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
(-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
(TEST):
- 1:51 AM Changeset in webkit [204225] by
-
- 9 edits in trunk
[Fetch API] Fetching with a FormData body should reject until it is implemented
https://bugs.webkit.org/show_bug.cgi?id=160595
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-06
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Adding new tests to cover changes.
Removing HEAD with body test as it throws as expected and is redundant with
web-platform-tests/fetch/api/request/request-init-002.html.
- web-platform-tests/fetch/api/basic/request-headers-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers.js:
(checkContentType):
(requestHeaders):
Source/WebCore:
Covered by updated tests.
This patch ensures that fetch will throw if trying to upload something that is not supported.
This is the case of BufferSource (FetchBody does not yet extract it) and FormData (no upload support yet).
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract): Added a FIXME.
- Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::bodyType): Getter used by FetchResponse.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::setBody): Throwing if given body parameter cannot be extracted by FetchBody.
This ensures that a fetch with a body that cannot be uploaded will fail.
This is the case of BufferSource which is not yet supported.
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::fetch): Rejecting fetch promise if trying to upload a FormData as it is not implemented.
- 1:50 AM Changeset in webkit [204224] by
-
- 11 edits in trunk
[Fetch API] Fetch API should strip fragment and credentials from URLs used as referrer
https://bugs.webkit.org/show_bug.cgi?id=160593
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-06
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/basic/referrer-expected.txt:
- web-platform-tests/fetch/api/basic/referrer-worker-expected.txt:
- web-platform-tests/fetch/api/basic/referrer.js:
(runTest): Adding more tests.
One test is failing as the redirection from same-origin to cross-origin is stripping the referer header.
But none is added afterwards. Hence cross-origin redirected request is sent without any referer header.
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt: Rebasing according redirect.py script changes.
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt: Ditto.
- web-platform-tests/fetch/api/resources/redirect.py:
(main): Fixing rediret.py script.
Source/WebCore:
Covered by updated tests.
Stripping of referrer value before sending a load request.
Fixing bug in workers as referrer value was overwritten by WorkerThreadableLoader.
The current handling of referrer values as HTTP header is not great as this may trigger unnecessary preflighting.
Refactoring should allow passing it as a separate parameter and setting it after preflighting as per
https://fetch.spec.whatwg.org/#http-network-or-cache-fetch.
Also a newly added test is failing, as SubresourceLoader is removing the referer header in case of a cross-origin redirection.
But none is added back.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::internalRequest): Stripping referrer value.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Do not override referrer value if one is defined.
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateReferrerHeader): Adding assertion to ensure referrer value does not contain
credentials and/or fragment identifiers.
- 1:48 AM Changeset in webkit [204223] by
-
- 3 edits in trunk/LayoutTests
LayoutTest http/tests/fetch/fetch-in-worker-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=160510
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-06
Reviewed by Sam Weinig.
- http/tests/fetch/fetch-in-worker-crash.html:
- http/tests/fetch/fetch-in-worker.js:
Adding a new test based on a ReadableStream that is not closed and therefore Response.text promise cannot resolve.
Removing the blob resolve message as there is no guarantee that blob load will finish after the test is done.
- 1:00 AM Changeset in webkit [204222] by
-
- 7 edits10 adds in trunk/Source/WebKit2
Lay WebProcess/UIProcess groundwork for an IPC GamepadProvider.
https://bugs.webkit.org/show_bug.cgi?id=160605
Reviewed by Alex Christensen.
This patch:
- Introduces the GamepadProvider that the WebProcess will use (WebGamepadProvider)
- Has that provider message to the UIProcess notifying interest in gamepad state
- Introduces a GamepadProviderClient in the UIProcess (UIGamepadProvider) that will use one of the existing GamepadProviders to pass gamepad state along to WebProcesses.
- Adds an empty skeleton for the soon-to-be-used WebGamepad, which will be the "PlatformGamepad" for WebProcesses.
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- UIProcess/Gamepads/UIGamepadProvider.cpp: Added.
(WebKit::UIGamepadProvider::singleton):
(WebKit::UIGamepadProvider::UIGamepadProvider):
(WebKit::UIGamepadProvider::~UIGamepadProvider):
(WebKit::UIGamepadProvider::platformGamepadConnected):
(WebKit::UIGamepadProvider::platformGamepadDisconnected):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):
(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::platformStartMonitoringGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringGamepads):
- UIProcess/Gamepads/UIGamepadProvider.h: Added.
- UIProcess/Gamepads/mac/UIGamepadProviderHID.cpp: Added.
(WebKit::UIGamepadProvider::platformStartMonitoringGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringGamepads):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::startedUsingGamepads):
(WebKit::WebProcessPool::stoppedUsingGamepads):
(WebKit::WebProcessPool::processStoppedUsingGamepads):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessPool.messages.in:
- WebProcess/Gamepad/WebGamepad.cpp: Added.
- WebProcess/Gamepad/WebGamepad.h: Added.
- WebProcess/Gamepad/WebGamepadProvider.cpp: Added.
(WebKit::WebGamepadProvider::singleton):
(WebKit::WebGamepadProvider::WebGamepadProvider):
(WebKit::WebGamepadProvider::~WebGamepadProvider):
(WebKit::WebGamepadProvider::startMonitoringGamepads):
(WebKit::WebGamepadProvider::stopMonitoringGamepads):
(WebKit::WebGamepadProvider::platformGamepads):
- WebProcess/Gamepad/WebGamepadProvider.h: Added.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Aug 5, 2016:
- 11:28 PM Changeset in webkit [204221] by
-
- 3 edits in trunk/Source/WebCore
[ES6] Add ScriptElement::determineScriptType
https://bugs.webkit.org/show_bug.cgi?id=149576
Reviewed by Ryosuke Niwa.
Change ScriptElement::isScriptTypeSupported to ScriptElement::determineScriptType.
And introduce ScriptType, which is either "classic" or "module".
And support "module" type in ScriptElement[1, 2].
But this patch does not contain any module tag support code.
This will be implemented in the subsequent patch.
[1]: https://html.spec.whatwg.org/multipage/webappapis.html#integration-with-the-javascript-module-system
[2]: https://html.spec.whatwg.org/multipage/scripting.html#attr-script-type
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::determineScriptType):
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::isScriptTypeSupported): Deleted.
- dom/ScriptElement.h:
- 10:37 PM Changeset in webkit [204220] by
-
- 12 edits in trunk/Source/WebCore
NULL Reference Error in ElementRuleCollector
https://bugs.webkit.org/show_bug.cgi?id=160362
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-05
Reviewed by Darin Adler.
No new tests, existing CSS tests cover this change.
Undefined behavior sanitizer found a reference bound to a NULL pointer.
The root cause of this issue was a discrepancy between whether an author style needed to be defined. In some logic, an undefined author style was considered acceptable, but in other logic, author style was always assumed to be defined. To fix this, a variable was added so that while author style is always defined, there is a flag indicating if this definition occurred in the constructor for use by functions which allow an undefined author style.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::DocumentRuleSets): Define author style by default.
(WebCore::DocumentRuleSets::resetAuthorStyle): Switch author style flag.
- css/DocumentRuleSets.h: Added author style flag, changed authorStyle accessor to reference from pointer.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ElementRuleCollector): Original location of undefined behavior.
(WebCore::ElementRuleCollector::matchHostPseudoClassRules): Changed pointer to reference.
(WebCore::ElementRuleCollector::matchSlottedPseudoElementRules): Changed pointer to reference.
- css/PageRuleCollector.cpp:
(WebCore::PageRuleCollector::matchAllPageRules): Check new flag, changed pointer to reference.
- css/StyleResolver.cpp: Changed pointer to reference.
- dom/Document.cpp: Dito.
- style/AttributeChangeInvalidation.cpp: Dito.
- style/ClassChangeInvalidation.cpp: Dito.
- style/IdChangeInvalidation.cpp: Dito.
- style/StyleSharingResolver.cpp: Dito.
- 10:34 PM Changeset in webkit [204219] by
-
- 7 edits17 adds in trunk
DOMException should be constructible
https://bugs.webkit.org/show_bug.cgi?id=160626
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Import WebIDL tests from W3C web-platform-tests.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constants-expected.txt: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constants.html: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor-expected.txt: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor.html: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object-expected.txt: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.html: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.js: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/constructor-object.worker.js: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions-expected.txt: Added.
- web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html: Added.
- web-platform-tests/WebIDL/ecmascript-binding/has-instance-expected.txt: Added.
- web-platform-tests/WebIDL/ecmascript-binding/has-instance.html: Added.
- web-platform-tests/WebIDL/ecmascript-binding/interface-object-expected.txt: Added.
- web-platform-tests/WebIDL/ecmascript-binding/interface-object.html: Added.
Source/WebCore:
DOMException should be constructible:
- http://heycam.github.io/webidl/#dfn-DOMException
- http://heycam.github.io/webidl/#es-DOMException-constructor-object
DOMException already has a constructor in Firefox and Chrome so this
aligns our behavior with other browsers.
Test: imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/DOMException-constructor.html
- dom/DOMCoreException.cpp:
(WebCore::errorCodeFromName):
(WebCore::DOMCoreException::create):
(WebCore::DOMCoreException::DOMCoreException):
- dom/DOMCoreException.h:
- dom/DOMCoreException.idl:
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
- dom/ExceptionBase.h:
- 8:48 PM Changeset in webkit [204218] by
-
- 4 edits2 adds in trunk/Source
Add LEBDecoder and tests
https://bugs.webkit.org/show_bug.cgi?id=160625
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Adds a new target testWASM that is currently used to test the LEB decoder.
In the future, if we add more support for WASM we will put more tests
here.
- JavaScriptCore.xcodeproj/project.pbxproj:
- testWASM.cpp: Added.
(CommandLine::CommandLine):
(printUsageStatement):
(CommandLine::parseArguments):
(runLEBTests):
(main):
Source/WTF:
Adds some LEB decoder functions to WTF. These are used in the
WASM spec to encode numbers in a semi-compressed format.
- WTF.xcodeproj/project.pbxproj:
- wtf/LEBDecoder.h: Added.
(decodeUInt32):
(decodeInt32):
- 8:17 PM Changeset in webkit [204217] by
-
- 4 edits in trunk
Align Range.insertNode() input validation with the specification
https://bugs.webkit.org/show_bug.cgi?id=160624
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/dom/ranges/Range-insertNode-expected.txt:
Source/WebCore:
Align Range.insertNode() input validation with the specification:
- https://dom.spec.whatwg.org/#dom-range-insertnode
- https://dom.spec.whatwg.org/#concept-range-insert (step 1)
In particular, if range’s start node is a ProcessingInstruction or
Comment node, is a Text node whose parent is null, or is node, then
we should throw a HierarchyRequestError.
Chrome behaves according to the specification.
No new tests, rebaselined existing test.
- dom/Range.cpp:
(WebCore::Range::insertNode):
- 7:33 PM Changeset in webkit [204216] by
-
- 5 edits in trunk/Source/WebCore
[Web IDL] Add support for 'any' type in dictionaries
https://bugs.webkit.org/show_bug.cgi?id=160511
Reviewed by Sam Weinig.
Add support for 'any' type in dictionaries. It will pass the value as
a JSValue to the implementation. If the member is not present, it will
pass jsUndefined() to the implementation.
Having 'any' support in dictionaries is a convenient workaround for
types we don't support yet (e.g. union types).
No new tests, updated bindings tests.
- bindings/js/JSDOMConvert.h:
(WebCore::Converter<JSC::JSValue>::convert):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convert<TestObj::Dictionary>):
- bindings/scripts/test/TestObj.idl:
- 7:32 PM Changeset in webkit [204215] by
-
- 60 edits in trunk
[Web IDL] Add support for USVString type
https://bugs.webkit.org/show_bug.cgi?id=160608
Reviewed by Sam Weinig.
Source/WebCore:
Add support for USVString type in our bindings generator:
Also start using USVString instead of DOMString when suitable as per
the following specifications:
Test: js/dom/webidl-type-mapping.html
- Modules/websockets/CloseEvent.idl:
- Modules/websockets/WebSocket.idl:
- bindings/js/JSDOMBinding.cpp:
(WebCore::isUnmatchedSurrogatePair):
(WebCore::valueToUSVString):
(WebCore::valueToUSVStringTreatingNullAsEmptyString):
(WebCore::valueToUSVStringWithUndefinedOrNullCheck):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open):
(WebCore::handlePostMessage):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::handleInitMessageEvent):
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::importScripts):
- bindings/scripts/CodeGenerator.pm:
(SkipIncludeHeader):
(IsStringOrEnumType):
(IsStringType):
(IsRefPtrType):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
(JSValueToNative):
(NativeToJSValue):
- bindings/scripts/IDLParser.pm:
(parseNonAnyType):
- dom/Document.idl:
- dom/ErrorEvent.idl:
- dom/HashChangeEvent.idl:
- dom/MessageEvent.idl:
- dom/Node.idl:
- html/DOMFormData.idl:
- html/DOMURL.idl:
- html/HTMLAnchorElement.idl:
- html/HTMLAppletElement.idl:
- html/HTMLAreaElement.idl:
- html/HTMLBaseElement.idl:
- html/HTMLButtonElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFormElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLHyperlinkElementUtils.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLImageElement.idl:
- html/HTMLInputElement.idl:
- html/HTMLLinkElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLModElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLQuoteElement.idl:
- html/HTMLScriptElement.idl:
- html/HTMLSourceElement.idl:
- html/HTMLTrackElement.idl:
- html/HTMLVideoElement.idl:
- html/URLUtils.idl:
- page/DOMWindow.idl:
- page/EventSource.idl:
- page/History.idl:
- page/Location.idl:
- storage/StorageEvent.idl:
- testing/TypeConversions.h:
(WebCore::TypeConversions::testString):
(WebCore::TypeConversions::setTestString):
(WebCore::TypeConversions::testUSVString):
(WebCore::TypeConversions::setTestUSVString):
- testing/TypeConversions.idl:
- workers/Worker.idl:
- workers/WorkerGlobalScope.idl:
LayoutTests:
Add layout test coverage for USVString.
- js/dom/webidl-type-mapping-expected.txt:
- js/dom/webidl-type-mapping.html:
This test is based on the corresponding one from Blink.
- 6:40 PM Changeset in webkit [204214] by
-
- 2 edits in trunk/LayoutTests
Add back a newline that was accidentally removed from an expected.txt file.
Unreviewed test gardening.
- platform/ios-simulator/compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
- 6:30 PM Changeset in webkit [204213] by
-
- 6 edits in branches/safari-602-branch
Merge r204210. rdar://problem/27592694
- 6:19 PM Changeset in webkit [204212] by
-
- 9 edits30 adds in branches/safari-602-branch/LayoutTests
Test gardening for rdar://problem/27595142.
- 6:16 PM Changeset in webkit [204211] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 6:13 PM Changeset in webkit [204210] by
-
- 6 edits in trunk
revert r202466 r202546 this causes regressions in media loading with temporary redirects.
https://bugs.webkit.org/show_bug.cgi?id=160613
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-08-05
Reviewed by Jon Lee.
Source/WebCore:
No new tests. Skipping two tests.
This reverts a change that attempted to fix temporary redirects with media loading.
The change introduced problems. Reverting this to require media stack to properly
handle redirects.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin):
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]): Deleted.
(-[WebCoreNSURLSession updateHasSingleSecurityOrigin:]): Deleted.
(-[WebCoreNSURLSession dataTaskWithRequest:]): Deleted.
(-[WebCoreNSURLSession dataTaskWithURL:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Deleted.
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]): Deleted.
LayoutTests:
Reverting a fix that enabled two tests. These tests now fail and are skipped.
- platform/mac/TestExpectations:
- 6:05 PM Changeset in webkit [204209] by
-
- 2 edits in trunk/Source/JavaScriptCore
32-bit JSC test failure: stress/instanceof-late-constant-folding.js
https://bugs.webkit.org/show_bug.cgi?id=160620
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 5:53 PM Changeset in webkit [204208] by
-
- 7 edits2 deletes in trunk/Source/WebKit2
Unreviewed, rolling out r204195.
https://bugs.webkit.org/show_bug.cgi?id=160623
This change causes assertion failures in LayoutTests and API
tests. (Requested by ryanhaddad on #webkit).
Reverted changeset:
"Lay WebProcess/UIProcess groundwork for an IPC
GamepadProvider."
https://bugs.webkit.org/show_bug.cgi?id=160605
http://trac.webkit.org/changeset/204195
Patch by Commit Queue <commit-queue@webkit.org> on 2016-08-05
- 5:49 PM Changeset in webkit [204207] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove the first LocalCSE
https://bugs.webkit.org/show_bug.cgi?id=160615
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-05
Reviewed by Saam Barati.
LocalCSE is the most expensive phase in DFG (excluding FTL).
The combination of two LocalCSEs does not seem to pay for its cost.
Doing a single LocalCSE is always after ConstantFolding and StrengthReduction
is always a win on my machine.
- dfg/DFGCleanUpPhase.cpp:
(JSC::DFG::CleanUpPhase::run):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 5:46 PM Changeset in webkit [204206] by
-
- 7 edits1 add in trunk
various math operations don't properly check for an exception after calling toNumber() on the lhs
https://bugs.webkit.org/show_bug.cgi?id=160154
Reviewed by Mark Lam.
JSTests:
- stress/to-number-throws-correct-exception.js: Added.
(test.let.test.runTest.):
(test.let.test.runTest.get f):
(test.let.test.runTest):
(test.let.test):
(test):
(test2.runTest.):
(test2.runTest.get f):
(test2.runTest):
(test2):
Source/JavaScriptCore:
We must check for an exception after calling toNumber() on the lhs
because this can throw an exception. If we called toNumber() on
the rhs without first checking for an exception after the toNumber()
on the lhs, this can lead us to execute effectful code or deviate
from the standard in subtle ways. I fixed this bug in various places
by always checking for an exception after calling toNumber() on the
lhs for the various bit and arithmetic operations.
This patch also found a commutativity bug inside DFGStrengthReduction.
We could end up commuting the lhs and rhs of say an "|" expression
even when the lhs/rhs may not be numbers. This is wrong because
executing toNumber() on the lhs/rhs has strict ordering guarantees
by the specification and is observable by user programs.
- dfg/DFGOperations.cpp:
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleCommutativity):
- jit/JITOperations.cpp:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/Operations.cpp:
(JSC::jsAddSlowCase):
- 5:32 PM Changeset in webkit [204205] by
-
- 2 edits in trunk/Source/WebCore
Add a tiny bit more image logging
https://bugs.webkit.org/show_bug.cgi?id=160621
Reviewed by Tim Horton.
Add logging related to image subsampling.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameImageAtIndex):
- 5:01 PM Changeset in webkit [204204] by
-
- 2 edits in trunk/Source/JavaScriptCore
compilePutByValForIntTypedArray() has a slow path in the middle of its processing
https://bugs.webkit.org/show_bug.cgi?id=160614
Reviewed by Keith Miller.
In compilePutByValForIntTypedArray() we were calling out to the slow path
operationToInt32() and then returning back to the middle of code to finish
the processing of writing the value to the array. When we make the slow
path call, we trash any temporary registers that have been allocated.
In general slow path calls should finish the operation in progress and
continue processing at the beginning of the next node.
This was discovered while working on the register argument changes, when
we SpeculateStrictInt32Operand on the value child node. That child node's
value was live in register with a spill format of DataFormatJSInt32. In that
case we allocate a new temporary register and copy just the lower 32 bits from
the child register to the new temp register. That temp register gets trashed
when we make the operationToInt32() slow path call.
I spent some time trying to devise a test with the current code base and wasn't
successful. This case is tested with the register argument changes in progress.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
- 5:01 PM Changeset in webkit [204203] by
-
- 3 edits2 adds in trunk
AX: Asking for group members of radio button that has no name attribute will cause crash
https://bugs.webkit.org/show_bug.cgi?id=160583
Reviewed by Chris Fleizach.
Source/WebCore:
The NameToGroupMap is null when there's no name attribute on the radio buttons. Added a
check so that we don't try to get a value from a null HashSet.
Test: accessibility/mac/radio-button-no-name-crash.html
- dom/RadioButtonGroups.cpp:
(WebCore::RadioButtonGroups::groupMembers):
LayoutTests:
- accessibility/mac/radio-button-no-name-crash-expected.txt: Added.
- accessibility/mac/radio-button-no-name-crash.html: Added.
- 4:57 PM Changeset in webkit [204202] by
-
- 2 edits in trunk/LayoutTests
Disk cache tests produce many undefined value warnings
https://bugs.webkit.org/show_bug.cgi?id=160601
Reviewed by Daniel Bates.
- http/tests/cache/disk-cache/resources/generate-response.cgi: Cleaned up header
and parameter handling. Removed a couple unnecessary checks for $cgi->http.
- 4:54 PM Changeset in webkit [204201] by
-
- 2 edits in trunk/LayoutTests
Work around broken <Files> directive in some Apache versions
https://bugs.webkit.org/show_bug.cgi?id=160610
Reviewed by Daniel Bates.
The problem is tracked as rdar://problem/27725655
- http/tests/misc/.htaccess:
- 4:41 PM Changeset in webkit [204200] by
-
- 1 copy in tags/Safari-602.1.49
New tag.
- 4:36 PM Changeset in webkit [204199] by
-
- 2 edits in trunk/LayoutTests
Rebaselining compositing/masks/compositing-clip-path-change-no-repaint.html for ios-simulator.
Unreviewed test gardening.
- platform/ios-simulator/compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
- 4:29 PM Changeset in webkit [204198] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: observer in WebCore::BitmapImage::drawPattern
https://bugs.webkit.org/show_bug.cgi?id=141637
<rdar://problem/27709864>
Reviewed by Tim Horton.
Source/WebCore:
Test: fast/images/image-source-assert.html
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern): Remove invalid assertion.
LayoutTests:
- fast/images/image-source-assert-expected.txt: Added.
- fast/images/image-source-assert.html: Added.
- 3:34 PM Changeset in webkit [204197] by
-
- 10 edits1 copy1 add17 deletes in trunk
marquee with "truespeed" animates at > 60fps, hogging CPU
https://bugs.webkit.org/show_bug.cgi?id=160609
Reviewed by David Hyatt.
Source/WebCore:
A <marquee truespeed="" scrollDelay="0"> would fire a zero-delay timer and also
fail to animate, hogging CPU.
Fix to cap the timer at 16ms intervals. We don't believe it's necessary to
maintain web compatibility here.
Tested by existing tests.
- html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::minimumDelay):
- html/HTMLMarqueeElement.h:
LayoutTests:
Convert marquee tests into ref tests, removing all the platform expectations.
- fast/html/marquee-scroll-expected.html: Copied from LayoutTests/fast/html/marquee-scroll.html.
- fast/html/marquee-scroll.html:
- fast/html/marquee-scrollamount-expected.html: Added.
- fast/html/marquee-set-truespeed.html:
- platform/efl/fast/html/marquee-scroll-expected.png: Removed.
- platform/efl/fast/html/marquee-scroll-expected.txt: Removed.
- platform/efl/fast/html/marquee-scrollamount-expected.png: Removed.
- platform/efl/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/gtk/fast/html/marquee-scroll-expected.png: Removed.
- platform/gtk/fast/html/marquee-scroll-expected.txt: Removed.
- platform/gtk/fast/html/marquee-scrollamount-expected.png: Removed.
- platform/gtk/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/ios-simulator/fast/html/marquee-scroll-expected.txt: Removed.
- platform/ios-simulator/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/mac-wk1/TestExpectations:
- platform/mac/fast/html/marquee-scroll-expected.png: Removed.
- platform/mac/fast/html/marquee-scroll-expected.txt: Removed.
- platform/mac/fast/html/marquee-scrollamount-expected.png: Removed.
- platform/mac/fast/html/marquee-scrollamount-expected.txt: Removed.
- platform/win/TestExpectations:
- platform/win/fast/html/marquee-scroll-expected.txt: Removed.
- platform/win/fast/html/marquee-scrollamount-expected.txt: Removed.
- 3:26 PM Changeset in webkit [204196] by
-
- 12 edits2 deletes in trunk
Unreviewed, rolling out r204181.
This change caused an existing LayoutTest to fail on WK1
Reverted changeset:
"Don't set document.domain to an IP address fragment"
https://bugs.webkit.org/show_bug.cgi?id=126045
http://trac.webkit.org/changeset/204181
- 2:54 PM Changeset in webkit [204195] by
-
- 7 edits10 adds in trunk/Source/WebKit2
Lay WebProcess/UIProcess groundwork for an IPC GamepadProvider.
https://bugs.webkit.org/show_bug.cgi?id=160605
Reviewed by Alex Christensen.
This patch:
- Introduces the GamepadProvider that the WebProcess will use (WebGamepadProvider)
- Has that provider message to the UIProcess notifying interest in gamepad state
- Introduces a GamepadProviderClient in the UIProcess (UIGamepadProvider) that will use one of the existing GamepadProviders to pass gamepad state along to WebProcesses.
- Adds an empty skeleton for the soon-to-be-used WebGamepad, which will be the "PlatformGamepad" for WebProcesses.
- CMakeLists.txt:
- WebKit2.xcodeproj/project.pbxproj:
- UIProcess/Gamepads/UIGamepadProvider.cpp: Added.
(WebKit::UIGamepadProvider::singleton):
(WebKit::UIGamepadProvider::UIGamepadProvider):
(WebKit::UIGamepadProvider::~UIGamepadProvider):
(WebKit::UIGamepadProvider::platformGamepadConnected):
(WebKit::UIGamepadProvider::platformGamepadDisconnected):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):
(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::platformStartMonitoringGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringGamepads):
- UIProcess/Gamepads/UIGamepadProvider.h: Added.
- UIProcess/Gamepads/mac/UIGamepadProviderHID.cpp: Added.
(WebKit::UIGamepadProvider::platformStartMonitoringGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringGamepads):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::~WebProcessPool):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::startedUsingGamepads):
(WebKit::WebProcessPool::stoppedUsingGamepads):
(WebKit::WebProcessPool::processStoppedUsingGamepads):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessPool.messages.in:
- WebProcess/Gamepad/WebGamepad.cpp: Added.
- WebProcess/Gamepad/WebGamepad.h: Added.
- WebProcess/Gamepad/WebGamepadProvider.cpp: Added.
(WebKit::WebGamepadProvider::singleton):
(WebKit::WebGamepadProvider::WebGamepadProvider):
(WebKit::WebGamepadProvider::~WebGamepadProvider):
(WebKit::WebGamepadProvider::startMonitoringGamepads):
(WebKit::WebGamepadProvider::stopMonitoringGamepads):
(WebKit::WebGamepadProvider::platformGamepads):
- WebProcess/Gamepad/WebGamepadProvider.h: Added.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 2:53 PM Changeset in webkit [204194] by
-
- 3 edits in trunk/Tools
run-api-tests should use a headed simulator
https://bugs.webkit.org/show_bug.cgi?id=160611
Reviewed by Sam Weinig.
CADisplayLink doesn't work in a headless simulator, but is
vital for the proper functioning of WebKit2 painting on iOS.
So, we should not use a headless simulator.
- Scripts/run-api-tests:
Launch a simulator app, don't just boot the simulator.
- TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
Re-enable a test that works now.
- 2:22 PM Changeset in webkit [204193] by
-
- 4 edits in trunk/LayoutTests
Sierra WK1: compositing/masks/compositing-clip-path-change-no-repaint.html failing
rdar://problem/26789221
Make this test less sensitive to platform repaint differences.
- compositing/masks/compositing-clip-path-change-no-repaint-expected.txt:
- compositing/masks/compositing-clip-path-change-no-repaint.html:
- platform/mac-wk1/TestExpectations:
- 2:19 PM Changeset in webkit [204192] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r204128.
https://bugs.webkit.org/show_bug.cgi?id=160607
Solve the issue by removing the workaround for static files
(Requested by jonlee_ on #webkit).
Reverted changeset:
"Temporary redirected m3u8 streaming stopped working."
https://bugs.webkit.org/show_bug.cgi?id=160472
http://trac.webkit.org/changeset/204128
- 1:27 PM Changeset in webkit [204191] by
-
- 6 edits2 deletes in trunk/LayoutTests
Remove testRunner.handleErrorPages()
https://bugs.webkit.org/show_bug.cgi?id=160552
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-05
Reviewed by Daniel Bates.
handleErrorPages() was implemented by the Qt WebKit port, per
https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
on other ports. Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
feature was never implemented on Mac.
- fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
- fast/history/back-forward-reset-after-error-handling.html: Removed test.
- platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
- platform/gtk/TestExpectations: Ditto.
- platform/ios-simulator/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 1:22 PM Changeset in webkit [204190] by
-
- 3 edits in trunk/Websites/perf.webkit.org
segmentTimeSeriesByMaximizingSchwarzCriterion returns a bogus result on empty charts
https://bugs.webkit.org/show_bug.cgi?id=160575
Rubber-stamped by Chris Dumez.
The bug was caused by an early return in segmentTimeSeriesByMaximizingSchwarzCriterion.
Removed this early return as the one in splitIntoSegmentsUntilGoodEnough was sufficient.
Also factored out a few functions in findOptimalSegmentation so that they can be better
optimized in JSC's DFG and FTL tiers, and removed unused debuggingTestingRangeNomination.
- public/shared/statistics.js:
(Statistics.segmentTimeSeriesByMaximizingSchwarzCriterion): Removed an early return.
(Statistics.splitIntoSegmentsUntilGoodEnough):
(.allocateCostUpperTriangularForSegmentation): Extracted from findOptimalSegmentation.
(.allocatePreviousNodeForSegmentation): Ditto.
(.findOptimalSegmentationInternal): Ditto.
(.findOptimalSegmentation):
- unit-tests/statistics-tests.js: Added a test case.
- 1:21 PM Changeset in webkit [204189] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Perf dashboard sometimes tries to fetch a non-existent measurement-set JSON
https://bugs.webkit.org/show_bug.cgi?id=160577
Rubber-stamped by Chris Dumez.
The bug was caused by findClusters computing the first cluster's endTime incorrectly. Namely, we were
multiplying the number of clusters by clusterStart instead of clusterSize with an off-by-one error.
- public/v3/models/measurement-set.js:
(MeasurementSet.prototype.findClusters): Folded computeClusterStart into where clusterEnd is computed
for clarity. Also fixed a bug that we were not computing the first cluster to fetch correctly when
the fetched time range started before clusterStart (i.e. when startTime - clusterStart is negative).
Finally, fixed the main bug by multiplying the number of clusters by clusterSize instead of
clusterStart to compute the end time of the very first cluster in this measurement set. Because what
we're computing here is the end time of the first cluster, not the start time, we also need to subtract
one from the number of clusters. e.g. if there was exactly one cluster, then firstClusterEndTime is
identically equal to lastClusterEndTime.
(MeasurementSet.prototype.fetchedTimeSeries): Removed the unused argument to TimeSeries's constructor.
- unit-tests/analysis-task-tests.js: Fixed the tests for the latest version of Mocha which complains if
we returned a promise in unit tests when "done" function is used.
- unit-tests/checkconfig.js: Ditto.
- unit-tests/measurement-set-tests.js: Added a test case for findClusters and a test to make sure
fetchBetween doesn't try to fetch a cluster before the first cluster in the set. Also fixed other test
cases which were relying on the bug this patch fixed.
- 1:19 PM Changeset in webkit [204188] by
-
- 6 edits in trunk
[Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
https://bugs.webkit.org/show_bug.cgi?id=160589
Reviewed by Tim Horton.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeInvocationArguments): Encode NSRange by wrapping in an NSValue.
(decodeInvocationArguments): Decode wrapped NSRange.
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
(remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
blocks, which wasn’t caught because the test wasn’t run correctly.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
(TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
added a test that sends over an NSRange.
- TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
(-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
handler with the range‘s location and length.
- 1:19 PM Changeset in webkit [204187] by
-
- 3 edits in trunk/Websites/perf.webkit.org
MeasurementCluster's addToSeries is slow
https://bugs.webkit.org/show_bug.cgi?id=160581
Rubber-stamped by Chris Dumez.
The bulk of time was spent in MeasurementAdaptor.prototype.applyTo where we computed the interval.
Since some of data points are filtered out by TimeSeriesChart component before intervals are used,
we can significantly reduce the CPU time by lazily compute them. This patch reduces the runtime of
applyTo from ~60ms to ~30ms on my machine.
- public/v3/models/measurement-adaptor.js:
(MeasurementAdaptor.prototype.applyTo): Lazily compute and cache the interval. Also cache the build
object instead of always creating a new object.
- public/v3/models/measurement-cluster.js:
(MeasurementCluster.prototype.addToSeries): Call applyTo first before checking whether the point is
an outlier or its id to avoid extracting those values twice since they show up in the profiler. Also
use "of" instead "forEach" since "of" seems to be faster here.
- 12:38 PM Changeset in webkit [204186] by
-
- 5 edits2 adds in trunk
validity assertion fails after removing a child of an <optgroup> element
https://bugs.webkit.org/show_bug.cgi?id=155720
<rdar://problem/27720746>
Reviewed by Brent Fulgham.
Source/WebCore:
All calls to HTMLSelectElement::setRecalcListItems also need to call HTMLSelectElement::updateValidity.
Test: fast/dom/HTMLSelectElement/select-remove-from-optgroup.html
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::recalcSelectOptions): Call 'updateValidity' after 'setRecalcListItems'.
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedInto): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute): Ditto.
LayoutTests:
Add new test case that triggers a debug assertion when the HTMLSelectElement state
is not updated properly.
- fast/dom/HTMLSelectElement/select-remove-from-optgroup-expected.txt: Added.
- fast/dom/HTMLSelectElement/select-remove-from-optgroup.html: Added.
- 12:29 PM Changeset in webkit [204185] by
-
- 5 edits2 deletes in branches/safari-602-branch
- 12:16 PM Changeset in webkit [204184] by
-
- 3 edits4 deletes in trunk
Unreviewed, rolling out r204174.
The test for this change is failing on WK1
Reverted changeset:
"Popups opened from a sandboxed iframe should themselves be
sandboxed"
https://bugs.webkit.org/show_bug.cgi?id=134850
http://trac.webkit.org/changeset/204174
- 12:16 PM Changeset in webkit [204183] by
-
- 2 edits in trunk/Tools
Fixing tests failing after r204175.
Unreviewed.
- TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
- 12:16 PM Changeset in webkit [204182] by
-
- 3 edits1 add in trunk
Assertion failure when accessing TDZ variable in catch through eval
https://bugs.webkit.org/show_bug.cgi?id=160554
Reviewed by Mark Lam and Keith Miller.
JSTests:
- stress/catch-variables-under-tdz.js: Added.
(test):
Source/JavaScriptCore:
When we were calculating the variables under TDZ from a JSScope,
the algorithm was not taking into account that a catch scope
has variables under TDZ.
- runtime/JSScope.cpp:
(JSC::JSScope::collectVariablesUnderTDZ):
- 11:57 AM Changeset in webkit [204181] by
-
- 12 edits2 adds in trunk
Don't set document.domain to an IP address fragment
https://bugs.webkit.org/show_bug.cgi?id=126045
<rdar://problem/27331794>
Reviewed by Daniel Bates.
Source/WebCore:
This patch matches the following Blink one:
https://chromium.googlesource.com/chromium/blink/+/b19a57fdb323d5a80d3a1cb0a6b343558c4237b0
IP address octets should not be treated as subdomains when setting
document.domain. The specs say:
'The domain attribute's setter must run these steps: ...
- If host is not equal to effectiveDomain, then run these substeps:
- If host or effectiveDomain is not a domain, then throw a "SecurityError" DOMException.'
https://html.spec.whatwg.org/multipage/browsers.html#relaxing-the-same-origin-restriction
Last Updated 5 August 2016
'A host is a domain, an IPv4 address, or an IPv6 address.'
https://url.spec.whatwg.org/#concept-domain
Last Updated 28 July 2016
Test: http/tests/security/set-domain-remove-subdomain-for-ip-address.html
- dom/Document.cpp:
(WebCore::Document::setDomain):
Now checks whether the security origin is allowed to remove
subdomains. If not, it throws a security error.
- page/OriginAccessEntry.cpp:
(WebCore::OriginAccessEntry::OriginAccessEntry):
Constructor now expects an IP address setting.
(WebCore::OriginAccessEntry::matchesOrigin):
Now also checks whether the host in an IP address and returns
false if IP addresses aren't configured to be treated as domains.
- page/OriginAccessEntry.h:
Introduced new enum for IP address setting.
Constructor now expects an IP address setting.
(WebCore::OriginAccessEntry::ipAddressSettings):
New getter.
(WebCore::operator==):
Now also requires IP address settings to match.
- page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
Changes to match OriginAccessEntry's new constructor.
(WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
Changes to match OriginAccessEntry's new constructor.
- page/Settings.in:
Added a setting to allow IP address octets to be treated as
subdomains. This way our existing tests setting document.domain
still work.
LayoutTests:
IP address octets should not be treated as subdomains when
setting document.domain.
- http/tests/security/aboutBlank/security-context-alias.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/security/aboutBlank/security-context-grandchildren-alias.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/security/set-domain-remove-subdomain-for-ip-address-expected.txt: Added.
- http/tests/security/set-domain-remove-subdomain-for-ip-address.html: Added.
- http/tests/workers/worker-document-domain-security.html:
Now enables the new setting treatIPAddressesAsDomains.
- http/tests/xmlhttprequest/document-domain-set.html:
Now enables the new setting treatIPAddressesAsDomains.
- 11:53 AM Changeset in webkit [204180] by
-
- 11 edits10 deletes in trunk/Source
Delete out of date WASM code.
https://bugs.webkit.org/show_bug.cgi?id=160603
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch removes a bunch of the wasm files that we are unlikey to use
with the newer wasm spec. If we end up needing any of the deleted code
later we can restore it at that time.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITOperations.cpp:
- jsc.cpp:
(GlobalObject::finishCreation): Deleted.
(functionLoadWebAssembly): Deleted.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall): Deleted.
- runtime/Executable.cpp:
(JSC::WebAssemblyExecutable::prepareForExecution): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Deleted.
(JSC::JSGlobalObject::visitChildren): Deleted.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::wasmModuleStructure): Deleted.
- wasm/WASMConstants.h: Removed.
- wasm/WASMFunctionB3IRGenerator.h: Removed.
(JSC::WASMFunctionB3IRGenerator::MemoryAddress::MemoryAddress): Deleted.
(JSC::WASMFunctionB3IRGenerator::startFunction): Deleted.
(JSC::WASMFunctionB3IRGenerator::endFunction): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildSetLocal): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildSetGlobal): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildReturn): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildImmediateI32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildImmediateF32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildImmediateF64): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildGetLocal): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildGetGlobal): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildConvertType): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildLoad): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildStore): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildUnaryI32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildUnaryF32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildUnaryF64): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildBinaryI32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildBinaryF32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildBinaryF64): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildRelationalI32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildRelationalF32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildRelationalF64): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildMinOrMaxI32): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildMinOrMaxF64): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildCallInternal): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildCallIndirect): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildCallImport): Deleted.
(JSC::WASMFunctionB3IRGenerator::appendExpressionList): Deleted.
(JSC::WASMFunctionB3IRGenerator::discard): Deleted.
(JSC::WASMFunctionB3IRGenerator::linkTarget): Deleted.
(JSC::WASMFunctionB3IRGenerator::jumpToTarget): Deleted.
(JSC::WASMFunctionB3IRGenerator::jumpToTargetIf): Deleted.
(JSC::WASMFunctionB3IRGenerator::startLoop): Deleted.
(JSC::WASMFunctionB3IRGenerator::endLoop): Deleted.
(JSC::WASMFunctionB3IRGenerator::startSwitch): Deleted.
(JSC::WASMFunctionB3IRGenerator::endSwitch): Deleted.
(JSC::WASMFunctionB3IRGenerator::startLabel): Deleted.
(JSC::WASMFunctionB3IRGenerator::endLabel): Deleted.
(JSC::WASMFunctionB3IRGenerator::breakTarget): Deleted.
(JSC::WASMFunctionB3IRGenerator::continueTarget): Deleted.
(JSC::WASMFunctionB3IRGenerator::breakLabelTarget): Deleted.
(JSC::WASMFunctionB3IRGenerator::continueLabelTarget): Deleted.
(JSC::WASMFunctionB3IRGenerator::buildSwitch): Deleted.
- wasm/WASMFunctionCompiler.h: Removed.
(JSC::operationConvertJSValueToInt32): Deleted.
(JSC::operationConvertJSValueToDouble): Deleted.
(JSC::operationDiv): Deleted.
(JSC::operationMod): Deleted.
(JSC::operationUnsignedDiv): Deleted.
(JSC::operationUnsignedMod): Deleted.
(JSC::operationConvertUnsignedInt32ToDouble): Deleted.
(JSC::sizeOfMemoryType): Deleted.
(JSC::WASMFunctionCompiler::MemoryAddress::MemoryAddress): Deleted.
(JSC::WASMFunctionCompiler::WASMFunctionCompiler): Deleted.
(JSC::WASMFunctionCompiler::startFunction): Deleted.
(JSC::WASMFunctionCompiler::endFunction): Deleted.
(JSC::WASMFunctionCompiler::buildSetLocal): Deleted.
(JSC::WASMFunctionCompiler::buildSetGlobal): Deleted.
(JSC::WASMFunctionCompiler::buildReturn): Deleted.
(JSC::WASMFunctionCompiler::buildImmediateI32): Deleted.
(JSC::WASMFunctionCompiler::buildImmediateF32): Deleted.
(JSC::WASMFunctionCompiler::buildImmediateF64): Deleted.
(JSC::WASMFunctionCompiler::buildGetLocal): Deleted.
(JSC::WASMFunctionCompiler::buildGetGlobal): Deleted.
(JSC::WASMFunctionCompiler::buildConvertType): Deleted.
(JSC::WASMFunctionCompiler::buildLoad): Deleted.
(JSC::WASMFunctionCompiler::buildStore): Deleted.
(JSC::WASMFunctionCompiler::buildUnaryI32): Deleted.
(JSC::WASMFunctionCompiler::buildUnaryF32): Deleted.
(JSC::WASMFunctionCompiler::buildUnaryF64): Deleted.
(JSC::WASMFunctionCompiler::buildBinaryI32): Deleted.
(JSC::WASMFunctionCompiler::buildBinaryF32): Deleted.
(JSC::WASMFunctionCompiler::buildBinaryF64): Deleted.
(JSC::WASMFunctionCompiler::buildRelationalI32): Deleted.
(JSC::WASMFunctionCompiler::buildRelationalF32): Deleted.
(JSC::WASMFunctionCompiler::buildRelationalF64): Deleted.
(JSC::WASMFunctionCompiler::buildMinOrMaxI32): Deleted.
(JSC::WASMFunctionCompiler::buildMinOrMaxF64): Deleted.
(JSC::WASMFunctionCompiler::buildCallInternal): Deleted.
(JSC::WASMFunctionCompiler::buildCallIndirect): Deleted.
(JSC::WASMFunctionCompiler::buildCallImport): Deleted.
(JSC::WASMFunctionCompiler::appendExpressionList): Deleted.
(JSC::WASMFunctionCompiler::discard): Deleted.
(JSC::WASMFunctionCompiler::linkTarget): Deleted.
(JSC::WASMFunctionCompiler::jumpToTarget): Deleted.
(JSC::WASMFunctionCompiler::jumpToTargetIf): Deleted.
(JSC::WASMFunctionCompiler::startLoop): Deleted.
(JSC::WASMFunctionCompiler::endLoop): Deleted.
(JSC::WASMFunctionCompiler::startSwitch): Deleted.
(JSC::WASMFunctionCompiler::endSwitch): Deleted.
(JSC::WASMFunctionCompiler::startLabel): Deleted.
(JSC::WASMFunctionCompiler::endLabel): Deleted.
(JSC::WASMFunctionCompiler::breakTarget): Deleted.
(JSC::WASMFunctionCompiler::continueTarget): Deleted.
(JSC::WASMFunctionCompiler::breakLabelTarget): Deleted.
(JSC::WASMFunctionCompiler::continueLabelTarget): Deleted.
(JSC::WASMFunctionCompiler::buildSwitch): Deleted.
(JSC::WASMFunctionCompiler::localAddress): Deleted.
(JSC::WASMFunctionCompiler::temporaryAddress): Deleted.
(JSC::WASMFunctionCompiler::appendCall): Deleted.
(JSC::WASMFunctionCompiler::appendCallWithExceptionCheck): Deleted.
(JSC::WASMFunctionCompiler::emitNakedCall): Deleted.
(JSC::WASMFunctionCompiler::appendCallSetResult): Deleted.
(JSC::WASMFunctionCompiler::callOperation): Deleted.
(JSC::WASMFunctionCompiler::boxArgumentsAndAdjustStackPointer): Deleted.
(JSC::WASMFunctionCompiler::callAndUnboxResult): Deleted.
(JSC::WASMFunctionCompiler::convertValueToInt32): Deleted.
(JSC::WASMFunctionCompiler::convertValueToDouble): Deleted.
(JSC::WASMFunctionCompiler::convertDoubleToValue): Deleted.
- wasm/WASMFunctionParser.cpp: Removed.
(JSC::nameOfType): Deleted.
(JSC::WASMFunctionParser::checkSyntax): Deleted.
(JSC::WASMFunctionParser::compile): Deleted.
(JSC::WASMFunctionParser::parseFunction): Deleted.
(JSC::WASMFunctionParser::parseLocalVariables): Deleted.
(JSC::WASMFunctionParser::parseStatement): Deleted.
(JSC::WASMFunctionParser::parseReturnStatement): Deleted.
(JSC::WASMFunctionParser::parseBlockStatement): Deleted.
(JSC::WASMFunctionParser::parseIfStatement): Deleted.
(JSC::WASMFunctionParser::parseIfElseStatement): Deleted.
(JSC::WASMFunctionParser::parseWhileStatement): Deleted.
(JSC::WASMFunctionParser::parseDoStatement): Deleted.
(JSC::WASMFunctionParser::parseLabelStatement): Deleted.
(JSC::WASMFunctionParser::parseBreakStatement): Deleted.
(JSC::WASMFunctionParser::parseBreakLabelStatement): Deleted.
(JSC::WASMFunctionParser::parseContinueStatement): Deleted.
(JSC::WASMFunctionParser::parseContinueLabelStatement): Deleted.
(JSC::WASMFunctionParser::parseSwitchStatement): Deleted.
(JSC::WASMFunctionParser::parseExpression): Deleted.
(JSC::WASMFunctionParser::parseExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseImmediateExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseUnaryExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseBinaryExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseRelationalI32ExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseRelationalF32ExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseRelationalF64ExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseMinOrMaxExpressionI32): Deleted.
(JSC::WASMFunctionParser::parseExpressionF32): Deleted.
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionF32): Deleted.
(JSC::WASMFunctionParser::parseImmediateExpressionF32): Deleted.
(JSC::WASMFunctionParser::parseUnaryExpressionF32): Deleted.
(JSC::WASMFunctionParser::parseBinaryExpressionF32): Deleted.
(JSC::WASMFunctionParser::parseExpressionF64): Deleted.
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionF64): Deleted.
(JSC::WASMFunctionParser::parseImmediateExpressionF64): Deleted.
(JSC::WASMFunctionParser::parseUnaryExpressionF64): Deleted.
(JSC::WASMFunctionParser::parseBinaryExpressionF64): Deleted.
(JSC::WASMFunctionParser::parseMinOrMaxExpressionF64): Deleted.
(JSC::WASMFunctionParser::parseExpressionVoid): Deleted.
(JSC::WASMFunctionParser::parseGetLocalExpression): Deleted.
(JSC::WASMFunctionParser::parseGetGlobalExpression): Deleted.
(JSC::WASMFunctionParser::parseSetLocal): Deleted.
(JSC::WASMFunctionParser::parseSetGlobal): Deleted.
(JSC::WASMFunctionParser::parseMemoryAddress): Deleted.
(JSC::WASMFunctionParser::parseLoad): Deleted.
(JSC::WASMFunctionParser::parseStore): Deleted.
(JSC::WASMFunctionParser::parseCallArguments): Deleted.
(JSC::WASMFunctionParser::parseCallInternal): Deleted.
(JSC::WASMFunctionParser::parseCallIndirect): Deleted.
(JSC::WASMFunctionParser::parseCallImport): Deleted.
(JSC::WASMFunctionParser::parseConditional): Deleted.
(JSC::WASMFunctionParser::parseComma): Deleted.
(JSC::WASMFunctionParser::parseConvertType): Deleted.
- wasm/WASMFunctionParser.h: Removed.
(JSC::WASMFunctionParser::WASMFunctionParser): Deleted.
- wasm/WASMFunctionSyntaxChecker.h: Removed.
(JSC::WASMFunctionSyntaxChecker::MemoryAddress::MemoryAddress): Deleted.
(JSC::WASMFunctionSyntaxChecker::startFunction): Deleted.
(JSC::WASMFunctionSyntaxChecker::endFunction): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildSetLocal): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildSetGlobal): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildReturn): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildImmediateI32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildImmediateF32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildImmediateF64): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildGetLocal): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildGetGlobal): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildConvertType): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildLoad): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildStore): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildUnaryI32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildUnaryF32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildUnaryF64): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildBinaryI32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildBinaryF32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildBinaryF64): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildRelationalI32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildRelationalF32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildRelationalF64): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxI32): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxF64): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildCallInternal): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildCallImport): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildCallIndirect): Deleted.
(JSC::WASMFunctionSyntaxChecker::appendExpressionList): Deleted.
(JSC::WASMFunctionSyntaxChecker::discard): Deleted.
(JSC::WASMFunctionSyntaxChecker::linkTarget): Deleted.
(JSC::WASMFunctionSyntaxChecker::jumpToTarget): Deleted.
(JSC::WASMFunctionSyntaxChecker::jumpToTargetIf): Deleted.
(JSC::WASMFunctionSyntaxChecker::startLoop): Deleted.
(JSC::WASMFunctionSyntaxChecker::endLoop): Deleted.
(JSC::WASMFunctionSyntaxChecker::startSwitch): Deleted.
(JSC::WASMFunctionSyntaxChecker::endSwitch): Deleted.
(JSC::WASMFunctionSyntaxChecker::startLabel): Deleted.
(JSC::WASMFunctionSyntaxChecker::endLabel): Deleted.
(JSC::WASMFunctionSyntaxChecker::breakTarget): Deleted.
(JSC::WASMFunctionSyntaxChecker::continueTarget): Deleted.
(JSC::WASMFunctionSyntaxChecker::breakLabelTarget): Deleted.
(JSC::WASMFunctionSyntaxChecker::continueLabelTarget): Deleted.
(JSC::WASMFunctionSyntaxChecker::buildSwitch): Deleted.
(JSC::WASMFunctionSyntaxChecker::stackHeight): Deleted.
(JSC::WASMFunctionSyntaxChecker::updateTempStackHeight): Deleted.
(JSC::WASMFunctionSyntaxChecker::updateTempStackHeightForCall): Deleted.
- wasm/WASMModuleParser.cpp: Removed.
(JSC::WASMModuleParser::WASMModuleParser): Deleted.
(JSC::WASMModuleParser::parse): Deleted.
(JSC::WASMModuleParser::parseModule): Deleted.
(JSC::WASMModuleParser::parseConstantPoolSection): Deleted.
(JSC::WASMModuleParser::parseSignatureSection): Deleted.
(JSC::WASMModuleParser::parseFunctionImportSection): Deleted.
(JSC::WASMModuleParser::parseGlobalSection): Deleted.
(JSC::WASMModuleParser::parseFunctionDeclarationSection): Deleted.
(JSC::WASMModuleParser::parseFunctionPointerTableSection): Deleted.
(JSC::WASMModuleParser::parseFunctionDefinitionSection): Deleted.
(JSC::WASMModuleParser::parseFunctionDefinition): Deleted.
(JSC::WASMModuleParser::parseExportSection): Deleted.
(JSC::WASMModuleParser::getImportedValue): Deleted.
(JSC::parseWebAssembly): Deleted.
- wasm/WASMModuleParser.h: Removed.
- wasm/WASMReader.cpp: Removed.
(JSC::WASMReader::readUInt32): Deleted.
(JSC::WASMReader::readFloat): Deleted.
(JSC::WASMReader::readDouble): Deleted.
(JSC::WASMReader::readCompactInt32): Deleted.
(JSC::WASMReader::readCompactUInt32): Deleted.
(JSC::WASMReader::readString): Deleted.
(JSC::WASMReader::readType): Deleted.
(JSC::WASMReader::readExpressionType): Deleted.
(JSC::WASMReader::readExportFormat): Deleted.
(JSC::WASMReader::readByte): Deleted.
(JSC::WASMReader::readOpStatement): Deleted.
(JSC::WASMReader::readOpExpressionI32): Deleted.
(JSC::WASMReader::readOpExpressionF32): Deleted.
(JSC::WASMReader::readOpExpressionF64): Deleted.
(JSC::WASMReader::readOpExpressionVoid): Deleted.
(JSC::WASMReader::readVariableTypes): Deleted.
(JSC::WASMReader::readOp): Deleted.
(JSC::WASMReader::readSwitchCase): Deleted.
- wasm/WASMReader.h: Removed.
(JSC::WASMReader::WASMReader): Deleted.
(JSC::WASMReader::offset): Deleted.
(JSC::WASMReader::setOffset): Deleted.
Source/WTF:
Add Feature define for WebAssembly on mac.
- wtf/FeatureDefines.h:
- 11:36 AM Changeset in webkit [204179] by
-
- 15 edits2 adds in trunk
Window's named properties should be exposed on a WindowProperties object in its prototype
https://bugs.webkit.org/show_bug.cgi?id=160354
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Window's named properties should be exposed on a WindowProperties object
in its prototype:
Firefox and Chrome both comply with the specification. However, WebKit
had no "WindowProperties" object in the Window prototype chain and the
named properties are exposed on the Window object itself.
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess): Deleted.
(WebCore::JSDOMWindow::put): Deleted.
(WebCore::JSDOMWindow::putByIndex): Deleted.
(WebCore::JSDOMWindow::getEnumerableLength): Deleted.
- bindings/js/JSDOMWindowProperties.cpp: Added.
(WebCore::jsDOMWindowPropertiesGetOwnPropertySlotNamedItemGetter):
(WebCore::JSDOMWindowProperties::getOwnPropertySlot):
(WebCore::JSDOMWindowProperties::getOwnPropertySlotByIndex):
- bindings/js/JSDOMWindowProperties.h: Added.
(WebCore::JSDOMWindowProperties::create):
(WebCore::JSDOMWindowProperties::createStructure):
(WebCore::JSDOMWindowProperties::JSDOMWindowProperties):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
LayoutTests:
- fast/dom/Window/es52-globals-expected.txt:
Update / Rebaseline test now that named properties are no longer reported as "own"
properties on the Window object. I have verified that the test gives the
same result in Firefox and Chrome.
- fast/loader/window-clearing-expected.txt:
Rebaseline test that prints one more line because there is one more
object in Window's prototype chain.
- http/tests/security/window-named-proto-expected.txt:
- http/tests/security/window-named-valueOf-expected.txt:
Rebaseline 2 security tests that give slightly different output. The new
output is identical to the one in Firefox and Chrome. The tests are not
failing since they are not alert'ing content from the other frame.
The reason those tests were logging a security error is because we would
previously prevent named property access if the frame name conflicts with
a property name in the Window prototype, and we now no longer
differentiate this case.
- 11:27 AM Changeset in webkit [204178] by
-
- 6 edits2 copies13 moves6 adds in trunk/Source/WebCore
Create platform/gamepad directory, and make GamepadProvider pure virtual (with a default empty implementation).
https://bugs.webkit.org/show_bug.cgi?id=160599
Reviewed by Alex Christensen.
No new tests (No behavior change).
Except for the GamepadProvider/EmptyGamepadProvider split, this is just moving files around.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- WebCore.xcodeproj/project.pbxproj:
- platform/Linux.cmake:
- platform/gamepad.h: Removed.
- platform/gamepad/EmptyGamepadProvider.cpp:
(WebCore::EmptyGamepadProvider::startMonitoringGamepads):
(WebCore::EmptyGamepadProvider::stopMonitoringGamepads):
(WebCore::EmptyGamepadProvider::platformGamepads):
- platform/gamepad/EmptyGamepadProvider.h:
- platform/gamepad/GamepadProvider.cpp: Renamed from Source/WebCore/platform/GamepadProvider.cpp.
(WebCore::GamepadProvider::singleton):
(WebCore::GamepadProvider::setSharedProvider):
- platform/gamepad/GamepadProvider.h: Renamed from Source/WebCore/platform/GamepadProvider.h.
(WebCore::GamepadProvider::~GamepadProvider):
- platform/gamepad/GamepadProviderClient.h: Renamed from Source/WebCore/platform/GamepadProviderClient.h.
(WebCore::GamepadProviderClient::~GamepadProviderClient):
- platform/gamepad/PlatformGamepad.h: Renamed from Source/WebCore/platform/PlatformGamepad.h.
(WebCore::PlatformGamepad::~PlatformGamepad):
(WebCore::PlatformGamepad::id):
(WebCore::PlatformGamepad::index):
(WebCore::PlatformGamepad::lastUpdateTime):
(WebCore::PlatformGamepad::connectTime):
(WebCore::PlatformGamepad::PlatformGamepad):
- platform/gamepad/deprecated/Gamepads.h: Renamed from Source/WebCore/platform/Gamepads.h.
- platform/gamepad/efl/GamepadsEfl.cpp: Renamed from Source/WebCore/platform/efl/GamepadsEfl.cpp.
(WebCore::GamepadDeviceEfl::resetFdHandler):
(WebCore::GamepadDeviceEfl::deviceFile):
(WebCore::GamepadDeviceEfl::GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::~GamepadDeviceEfl):
(WebCore::GamepadDeviceEfl::readCallback):
(WebCore::GamepadsEfl::onGamePadChange):
(WebCore::GamepadsEfl::GamepadsEfl):
(WebCore::GamepadsEfl::~GamepadsEfl):
(WebCore::GamepadsEfl::registerDevice):
(WebCore::GamepadsEfl::unregisterDevice):
(WebCore::GamepadsEfl::updateGamepadList):
(WebCore::sampleGamepads):
- platform/gamepad/glib/GamepadsGlib.cpp: Renamed from Source/WebCore/platform/glib/GamepadsGlib.cpp.
(WebCore::GamepadDeviceGlib::GamepadDeviceGlib):
(WebCore::GamepadDeviceGlib::~GamepadDeviceGlib):
(WebCore::GamepadDeviceGlib::readCallback):
(WebCore::GamepadsGlib::GamepadsGlib):
(WebCore::GamepadsGlib::~GamepadsGlib):
(WebCore::GamepadsGlib::registerDevice):
(WebCore::GamepadsGlib::unregisterDevice):
(WebCore::GamepadsGlib::updateGamepadList):
(WebCore::GamepadsGlib::onUEventCallback):
(WebCore::GamepadsGlib::isGamepadDevice):
(WebCore::sampleGamepads):
- platform/gamepad/linux/GamepadDeviceLinux.cpp: Renamed from Source/WebCore/platform/linux/GamepadDeviceLinux.cpp.
(WebCore::GamepadDeviceLinux::GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::~GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::updateForEvent):
(WebCore::GamepadDeviceLinux::normalizeAxisValue):
(WebCore::GamepadDeviceLinux::normalizeButtonValue):
- platform/gamepad/linux/GamepadDeviceLinux.h: Renamed from Source/WebCore/platform/linux/GamepadDeviceLinux.h.
(WebCore::GamepadDeviceLinux::connected):
(WebCore::GamepadDeviceLinux::id):
(WebCore::GamepadDeviceLinux::timestamp):
(WebCore::GamepadDeviceLinux::axesCount):
(WebCore::GamepadDeviceLinux::axesData):
(WebCore::GamepadDeviceLinux::buttonsCount):
(WebCore::GamepadDeviceLinux::buttonsData):
- platform/gamepad/mac/HIDGamepad.cpp: Renamed from Source/WebCore/platform/mac/HIDGamepad.cpp.
(WebCore::HIDGamepad::HIDGamepad):
(WebCore::HIDGamepad::getCurrentValueForElement):
(WebCore::HIDGamepad::initElements):
(WebCore::HIDGamepad::initElementsFromArray):
(WebCore::HIDGamepad::maybeAddButton):
(WebCore::HIDGamepad::maybeAddAxis):
(WebCore::HIDGamepad::valueChanged):
- platform/gamepad/mac/HIDGamepad.h: Renamed from Source/WebCore/platform/mac/HIDGamepad.h.
(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadElement::~HIDGamepadElement):
(WebCore::HIDGamepadElement::isButton):
(WebCore::HIDGamepadElement::isAxis):
(WebCore::HIDGamepadButton::HIDGamepadButton):
(WebCore::HIDGamepadAxis::HIDGamepadAxis):
(WebCore::HIDGamepad::hidDevice):
- platform/gamepad/mac/HIDGamepadProvider.cpp: Renamed from Source/WebCore/platform/mac/HIDGamepadProvider.cpp.
(WebCore::deviceMatchingDictionary):
(WebCore::deviceAddedCallback):
(WebCore::deviceRemovedCallback):
(WebCore::deviceValuesChangedCallback):
(WebCore::HIDGamepadProvider::singleton):
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::indexForNewlyConnectedDevice):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):
(WebCore::HIDGamepadProvider::openAndScheduleManager):
(WebCore::HIDGamepadProvider::closeAndUnscheduleManager):
(WebCore::HIDGamepadProvider::startMonitoringGamepads):
(WebCore::HIDGamepadProvider::stopMonitoringGamepads):
(WebCore::HIDGamepadProvider::deviceAdded):
(WebCore::HIDGamepadProvider::deviceRemoved):
(WebCore::HIDGamepadProvider::valuesChanged):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):
(WebCore::HIDGamepadProvider::removeGamepadForDevice):
- platform/gamepad/mac/HIDGamepadProvider.h: Renamed from Source/WebCore/platform/mac/HIDGamepadProvider.h.
(WebCore::HIDGamepadProvider::platformGamepads):
- 10:43 AM Changeset in webkit [204177] by
-
- 3 edits1 delete in trunk/Source/WebCore
Unreviewed, rolling out r204147.
https://bugs.webkit.org/show_bug.cgi?id=160602
Considering another implementation (Requested by eric_carlson
on #webkit).
Reverted changeset:
"Add long, boolean, double, and String Media Constraint
classes"
https://bugs.webkit.org/show_bug.cgi?id=160524
http://trac.webkit.org/changeset/204147
- 10:08 AM Changeset in webkit [204176] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix 32-bit OverridesHasInstance in the DFG.
https://bugs.webkit.org/show_bug.cgi?id=160600
Reviewed by Mark Lam.
In https://trac.webkit.org/changeset/204140, we fixed an issue where the DFG might
do the wrong thing if it proved that the Symbol.hasInstance value for a constructor
was a constant late in compilation. That fix was ommited from the 32-bit version,
causing the new test to fail.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:57 AM Changeset in webkit [204175] by
-
- 3 edits in trunk/Tools
Build fix after 204053.
Unreviewed.
- TestWebKitAPI/Configurations/Base.xcconfig:
- TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
(-[MockContentFilterEnabler initWithCoder:]):
(-[MockContentFilterEnabler dealloc]):
- 9:51 AM Changeset in webkit [204174] by
-
- 3 edits4 adds in trunk
Popups opened from a sandboxed iframe should themselves be sandboxed
https://bugs.webkit.org/show_bug.cgi?id=134850
<rdar://problem/27375388>
Reviewed by Brent Fulgham.
Source/WebCore:
This replicates the behavior in Chrome, Firefox, and according to the reporter
also in Internet Explorer. See the Mozilla bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1037381#c1
Test: http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html
- page/Chrome.cpp:
(WebCore::Chrome::createWindow):
Now copies the opener's frame loader effective sandbox flags to the new
frame loader.
LayoutTests:
- http/tests/security/resources/anchor-tag-with-blank-target.html: Added.
- http/tests/security/resources/page-executing-javascript.html: Added.
- http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
- http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html: Added.
- 9:42 AM Changeset in webkit [204173] by
-
- 2 edits in trunk/Source/WebCore
- DerivedSources.make: Fix all places that were using tabs instead of spaces outside
the actual make rules, where tabs are required as part of make syntax.
- 9:26 AM Changeset in webkit [204172] by
-
- 6 edits in trunk
[Fetch API] SubresourceLoader::checkRedirectionCrossOriginAccessControl should not always assert in SameOrigin mode
https://bugs.webkit.org/show_bug.cgi?id=160594
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-05
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
- web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt:
- web-platform-tests/fetch/api/basic/mode-same-origin.js: Adding redirection tests for same origin mode.
Source/WebCore:
Covered by rebased tests.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
It should not throw is mode is SameOrigin and resource is same origin.
- 9:22 AM Changeset in webkit [204171] by
-
- 5 edits in trunk
[Fetch API] Response.blob should not assert in case the created blob is empty
https://bugs.webkit.org/show_bug.cgi?id=160592
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-05
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/request/request-consume-expected.txt:
- web-platform-tests/fetch/api/request/request-consume.html: Adding response with empty blob test.
Source/WebCore:
Covered bu updated test.
- Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::takeAsBlob): Removing assertion as a response may have a body but with no data in it.
- 9:20 AM Changeset in webkit [204170] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r204159. rdar://problem/27669831
- 9:20 AM Changeset in webkit [204169] by
-
- 5 edits2 adds in branches/safari-602-branch
Merge r204128. rdar://problem/27592694
- 8:39 AM Changeset in webkit [204168] by
-
- 3 edits in trunk/Tools
Print test name in "Last character read from DRT..." error message.
https://bugs.webkit.org/show_bug.cgi?id=160559
Reviewed by Michael Catanzaro.
- Scripts/webkitpy/port/driver.py:
(Driver.run_test):
(Driver._read_first_block):
(Driver._read_optional_image_block):
(Driver._read_block):
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_read_block):
(DriverTest.test_read_binary_block):
(DriverTest.test_read_base64_block):
- 6:43 AM Changeset in webkit [204167] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r204123.
https://bugs.webkit.org/show_bug.cgi?id=160597
Caused layout test timeouts on Windows. (Requested by perarne
on #webkit).
Reverted changeset:
"[Win] Unable to reliably run tests in parallel"
https://bugs.webkit.org/show_bug.cgi?id=140914
http://trac.webkit.org/changeset/204123
- 4:25 AM Changeset in webkit [204166] by
-
- 15 edits2 deletes in trunk
Unreviewed, rolling out r203935.
https://bugs.webkit.org/show_bug.cgi?id=160596
looks like a 1-2% PLUM regression on iPhone 6s (Requested by
kling_ on #webkit).
Reverted changeset:
"Window's named properties should be exposed on a
WindowProperties object in its prototype"
https://bugs.webkit.org/show_bug.cgi?id=160354
http://trac.webkit.org/changeset/203935
- 2:19 AM Changeset in webkit [204165] by
-
- 2 edits in trunk/LayoutTests
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html is failing on iOS-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=160591
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-05
- platform/ios-simulator-wk2/TestExpectations:
- 12:39 AM Changeset in webkit [204164] by
-
- 10 edits5 adds in trunk
[Fetch API] Activate CSP checks
https://bugs.webkit.org/show_bug.cgi?id=160445
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-05
Reviewed by Daniel Bates.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/policies/csp-blocked-expected.txt:
- web-platform-tests/fetch/api/policies/csp-blocked-worker-expected.txt:
Source/WebCore:
Tests: http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start): Adding CSP and URL upgrade checks.
LayoutTests:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-fetch-in-main-frame-window.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-xhr-in-main-frame-window.html:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-main-frame.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-fetch-in-worker.html: Added.
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-xhr-in-main-frame-expected.txt:
- platform/mac-wk2/TestExpectations: Marking new worker test as failing at loading https resource from loader.
It gets a "The certificate for this server is invalid" error.
- platform/wk2/TestExpectations: Marking new frame test as timing out for WK2 as fetch is not activated in the pop-up window.
- 12:25 AM Changeset in webkit [204163] by
-
- 16 edits in trunk
DocumentThreadableLoader should report an error when getting a null CachedResource
https://bugs.webkit.org/show_bug.cgi?id=160444
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-05
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/event-error-expected.txt:
- web-platform-tests/XMLHttpRequest/getresponseheader-error-state-expected.txt:
- web-platform-tests/XMLHttpRequest/timeout-cors-async-expected.txt:
- web-platform-tests/fetch/api/cors/cors-cookies-expected.txt:
- web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt:
Source/WebCore:
Covered by existing and rebased tests.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest): Calling didFail with an AccessControl error if unable to have a CachedResource.
The resource error type AccessControl is important as it indicates to some clients that they should not retry loading the same resource (EventSource notably).
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Removed handling of ThreadableLoader::create returning null.
This should be handled in didFail callback. This allows aligning behavior of
WorkerThreadableLoaderi::MainThreadBridge and XMLHttpRequest as ThreadableLoader clients.
(WebCore::XMLHttpRequest::didFail): Handle the case of didFail being called synchronously from ThreadableLoader::create.
In that case, use a timer to dispatch network events asynchronously.
LayoutTests:
- fast/frames/frame-unload-crash.html:
- http/tests/contentextensions/async-xhr-onerror-expected.txt:
- http/tests/eventsource/eventsource-reconnect-during-navigate-crash-expected.txt:
- http/tests/navigation/subframe-pagehide-handler-starts-load-expected.txt:
- http/tests/navigation/subframe-pagehide-handler-starts-load2-expected.txt:
- http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:
Aug 4, 2016:
- 11:46 PM Changeset in webkit [204162] by
-
- 11 edits in trunk
Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
https://bugs.webkit.org/show_bug.cgi?id=151241
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
This patch rolls back in the jettisoning policy from https://bugs.webkit.org/show_bug.cgi?id=149727.
We can now jettison a CodeBlock when it has been alive for a long time
and is only pointed to by its owner executable. I haven't been able to get this
patch to crash on anything it used to crash on, so I suspect we've fixed the bugs that
were causing this before. I've also added some stress options for this feature that
will cause us to either eagerly old-age jettison or to old-age jettison whenever it's legal.
These options helped me find a bug where we would ask an Executable to create a CodeBlock,
and then the Executable would do some other allocations, causing a GC, immediately causing
the CodeBlock to jettison. There is a small chance that this was the bug we were seeing before,
however, it's unlikely given that the previous timing metrics require at least 5 second between
compiling to jettisoning.
This patch also enables the stress options for various modes
of JSC stress tests.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldJettisonDueToWeakReference):
(JSC::timeToLive):
(JSC::CodeBlock::shouldJettisonDueToOldAge):
- interpreter/CallFrame.h:
(JSC::ExecState::callee):
(JSC::ExecState::unsafeCallee):
(JSC::ExecState::codeBlock):
(JSC::ExecState::addressOfCodeBlock):
(JSC::ExecState::unsafeCodeBlock):
(JSC::ExecState::scope):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
(JSC::setupJIT):
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/Executable.h:
(JSC::ScriptExecutable::prepareForExecution):
- runtime/Options.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 8:29 PM WikiStart edited by
- (diff)
- 7:59 PM Changeset in webkit [204161] by
-
- 7 edits in trunk
Add support for DOMTokenList.replace()
https://bugs.webkit.org/show_bug.cgi?id=160573
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/Element-classlist-expected.txt:
Source/WebCore:
Add support for DOMTokenList.replace():
https://dom.spec.whatwg.org/#dom-domtokenlist-replace
No new tests, rebaselined existing tests.
- html/DOMTokenList.cpp:
(WebCore::tokenContainsHTMLSpace):
(WebCore::DOMTokenList::validateToken):
(WebCore::DOMTokenList::replace):
- html/DOMTokenList.h:
- html/DOMTokenList.idl:
- 7:50 PM Changeset in webkit [204160] by
-
- 4 edits1 add in trunk
[ES6] JSModuleNamespaceObject's Symbol.iterator function should have name
https://bugs.webkit.org/show_bug.cgi?id=160549
Reviewed by Saam Barati.
JSTests:
- modules/namespace-object-symbol-iterator-name.js: Added.
- test262.yaml:
Source/JavaScriptCore:
ES6 Module's namespace[Symbol.iterator] function should have the name, "[Symbol.iterator]".
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::finishCreation):
- 7:35 PM Changeset in webkit [204159] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Some videos in iBooks erroneously go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=160582
<rdar://problem/27669831>
Reviewed by Jon Lee.
No new tests because we can't currently mock the iBooks application bundle ID.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
- 7:09 PM Changeset in webkit [204158] by
-
- 1 edit4 adds in trunk/Websites/webkit.org
Add some files for a Content Security Policy blog post
- blog-files/content-security-policy/compass-base.css: Added.
(.compass):
- blog-files/content-security-policy/csp-style-hash.html: Added.
- blog-files/content-security-policy/icons.svg: Added; derived from file
Websites/webkit.org/wp-content/themes/webkit/images/icons.svg. I am explicitly
not referencing file Websites/webkit.org/wp-content/themes/webkit/images/icons.svg
so that csp-style-hash.html is not affected by changes to this file.
- 6:51 PM Changeset in webkit [204157] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 5:46 PM Changeset in webkit [204156] by
-
- 4 edits in trunk/Tools
UI improvements to Flakiness Dashboard.
https://bugs.webkit.org/show_bug.cgi?id=153295
Patch by Dean Johnson <dean_johnson@apple.com> on 2016-08-04
Reviewed by Alexey Proskuryakov.
- TestResultServer/static-dashboards/flakiness_dashboard.css:
(td.options-container): Center text in most fields.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(createBugHTML): Text/Grammar updates.
(tableHeaders): Ditto.
(htmlForSingleTestRow): Ditto.
(headerForTestTableHtml): Ditto.
- TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
(ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
- 5:23 PM Changeset in webkit [204155] by
-
- 3 edits in trunk/Tools
[GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
https://bugs.webkit.org/show_bug.cgi?id=160518
Reviewed by Michael Catanzaro.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
- gtk/install-dependencies:
- 5:20 PM Changeset in webkit [204154] by
-
- 2 edits in trunk/Source/WebCore
[Fontconfig] Segmentation fault in WebCore::FontCache::lastResortFallbackFont
https://bugs.webkit.org/show_bug.cgi?id=141432
Reviewed by Myles C. Maxfield.
Crash more cleanly when we can't find any last resort fallback font.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::lastResortFallbackFont):
- 4:49 PM Changeset in webkit [204153] by
-
- 1 copy in tags/Safari-602.1.48
New tag.
- 4:46 PM Changeset in webkit [204152] by
-
- 4 edits2 deletes in trunk/Source/WebInspectorUI
Web Inspector: UI polish for Edit Breakpoint dialog
https://bugs.webkit.org/show_bug.cgi?id=160566
<rdar://problem/27706378>
Reviewed by Timothy Hatcher.
- UserInterface/Images/BreakpointActionAdd.svg: Removed.
- UserInterface/Images/BreakpointActionRemove.svg: Removed.
Use Plus13.svg and Minus.svg instead.
- UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-button-container):
(.breakpoint-action-append-button,):
(.breakpoint-action-append-button):
(.breakpoint-action-remove-button):
Button styles should match Xcode.
(.breakpoint-action-append-button:active,): Deleted.
Brightness on activation no longer needed.
- UserInterface/Views/BreakpointActionView.js:
(WebInspector.BreakpointActionView):
Add a button container so buttons can float together.
- UserInterface/Views/BreakpointPopoverController.css:
(.wide .edit-breakpoint-popover-condition > .CodeMirror):
Increase condition field width by the same amount as the popover.
- 4:24 PM Changeset in webkit [204151] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Syncing script's configuration duplicates a lot of boilerplate
https://bugs.webkit.org/show_bug.cgi?id=160574
Rubber-stamped by Chris Dumez.
This patch makes each configuration accept an array of platforms and types so that we can write:
{"type": "speedometer", "builder": "mba", "platform": "Trunk El Capitan MacBookAir"},
{"type": "speedometer", "builder": "mbp", "platform": "Trunk El Capitan MacBookPro"},
{"type": "speedometer", "builder": "mba", "platform": "Trunk Sierra MacBookAir"},
{"type": "speedometer", "builder": "mbp", "platform": "Trunk Sierra MacBookPro"},
{"type": "jetstream", "builder": "mba", "platform": "Trunk El Capitan MacBookAir"},
{"type": "jetstream", "builder": "mbp", "platform": "Trunk El Capitan MacBookPro"},
{"type": "jetstream", "builder": "mba", "platform": "Trunk Sierra MacBookAir"},
{"type": "jetstream", "builder": "mbp", "platform": "Trunk Sierra MacBookPro"},
more concisely as:
{"builder": "mba", "types": ["speedometer", "jetstream"],
"platforms": ["Trunk El Capitan MacBookAir", "Trunk Sierra MacBookAir"]},
{"builder": "mbp", "types": ["speedometer", "jetstream"],
"platforms": ["Trunk El Capitan MacBookPro", "Trunk Sierra MacBookPro"]},
- tools/js/buildbot-syncer.js:
(BuildbotSyncer._loadConfig):
(BuildbotSyncer._expandTypesAndPlatforms): Added. Clones a new configuration entry for each type
and platform.
(BuildbotSyncer._createTestConfiguration): Extracted from _loadConfig.
(BuildbotSyncer._validateAndMergeConfig): Added a new argument that specifies a property that
shouldn't be merged into the configuration. Also added the support for 'types' and 'platforms',
and merged the code for verify an array of strings. Finally, allow the appearance of 'properties'
since this function can now be called on a cloned configuration in which 'arguments' had already
been renamed to 'properties'.
- unit-tests/buildbot-syncer-tests.js: Added a test case to parse a consolidated configuration.
(sampleiOSConfigWithExpansions): Added.
- unit-tests/resources/mock-v3-models.js:
(MockModels.inject): Added a few more mock models for the newly added test.
- 3:43 PM Changeset in webkit [204150] by
-
- 14 edits in trunk
Move insertAdjacent*() API from HTMLElement to Element
https://bugs.webkit.org/show_bug.cgi?id=160567
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/domparsing/insert_adjacent_html-expected.txt:
Source/WebCore:
Move insertAdjacent*() API from HTMLElement to Element:
- https://w3c.github.io/DOM-Parsing/#extensions-to-the-element-interface
- https://dom.spec.whatwg.org/#element
Firefox and Chrome both have insertAdjacentHTML() on Element.
Chrome has insertAdjacentText() / insertAdjacentElement() on Element as
well. Firefox does not have this API at all.
Also align insertAdjacentHTML() with the specification so that we
now throw a NO_MODIFICATION_ALLOWED_ERR if called with "beforebegin" /
"afterend" on a parent-less element. This is as per:
Previously, WebKit would just silently ignore such calls. The new
behavior with consistent with both Firefox and Chrome.
No new tests, rebaselined existing tests.
- dom/Element.cpp:
(WebCore::Element::insertAdjacent):
(WebCore::Element::insertAdjacentElement):
(WebCore::contextElementForInsertion):
(WebCore::Element::insertAdjacentHTML):
(WebCore::Element::insertAdjacentText):
- dom/Element.h:
- dom/Element.idl:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacent): Deleted.
(WebCore::HTMLElement::insertAdjacentElement): Deleted.
(WebCore::contextElementForInsertion): Deleted.
(WebCore::HTMLElement::insertAdjacentHTML): Deleted.
(WebCore::HTMLElement::insertAdjacentText): Deleted.
- html/HTMLElement.h:
- html/HTMLElement.idl:
LayoutTests:
Rebaseline several tests to reflect behavior change.
- fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt:
- fast/dom/HTMLElement/script-tests/insertAdjacentHTML-errors.js:
- fast/dynamic/insertAdjacentElement-expected.txt:
- 3:38 PM Changeset in webkit [204149] by
-
- 2 edits in trunk/Source/WebCore
Another build fix attempt.
- bindings/gobject/WebKitDOMDeprecated.cpp:
- 3:37 PM Changeset in webkit [204148] by
-
- 1 edit8 adds in trunk/LayoutTests
Add some extra test coverage for active touch event handler on subdocuments
https://bugs.webkit.org/show_bug.cgi?id=160276
Reviewed by Alex Christensen.
I wrote some tests while chasing a bug.
Documents are handled differently than other EventTarget. We had no test coverage
for that.
- fast/events/touch/ios/touch-event-listeners-on-detached-document-expected.txt: Added.
- fast/events/touch/ios/touch-event-listeners-on-detached-document.html: Added.
- fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame-expected.txt: Added.
- fast/events/touch/ios/touch-event-listeners-on-subdocument-then-detach-from-frame.html: Added.
- fast/events/touch/ios/touch-event-listeners-on-subdocuments-expected.txt: Added.
- fast/events/touch/ios/touch-event-listeners-on-subdocuments.html: Added.
- fast/events/touch/ios/touch-event-listeners-on-template-document-expected.txt: Added.
- fast/events/touch/ios/touch-event-listeners-on-template-document.html: Added.
- 3:34 PM Changeset in webkit [204147] by
-
- 3 edits1 add in trunk/Source/WebCore
Add long, boolean, double, and String Media Constraint classes
https://bugs.webkit.org/show_bug.cgi?id=160524
<rdar://problem/27685132>
Patch by George Ruan <gruan@apple.com> on 2016-08-04
Reviewed by Eric Carlson.
No new tests. The current patch is untestable, but functionality
will be tested in a future patch.
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/MediaConstraints.cpp: Added.
(WebCore::BaseConstraint::create): Initializes min, max, exact, ideal
value of constraint with dictionary.
(WebCore::BaseConstraint::createEmptyDerivedConstraint): Factory
for all derived constraints.
(WebCore::LongConstraint::create): Creates LongConstraint with name.
(WebCore::LongConstraint::setMin): Sets mandatory min constraint value.
(WebCore::LongConstraint::setMax): Sets mandatory max constraint value.
(WebCore::LongConstraint::setExact): Sets mandatory exact constraint
value.
(WebCore::LongConstraint::setIdeal): Sets optional ideal constraint
value.
(WebCore::LongConstraint::initializeWithDictionary): Parses user input
and sets min, max, exact, ideal values.
(WebCore::DoubleConstraint::create): Ditto.
(WebCore::DoubleConstraint::setMin): Ditto.
(WebCore::DoubleConstraint::setMax): Ditto.
(WebCore::DoubleConstraint::setExact): Ditto.
(WebCore::DoubleConstraint::setIdeal): Ditto.
(WebCore::DoubleConstraint::initializeWithDictionary): Ditto.
(WebCore::BooleanConstraint::create): Ditto.
(WebCore::BooleanConstraint::setExact): Ditto.
(WebCore::BooleanConstraint::setIdeal): Ditto.
(WebCore::BooleanConstraint::initializeWithDictionary): Ditto.
(WebCore::StringConstraint::create): Ditto.
(WebCore::StringConstraint::setExact): Ditto.
(WebCore::StringConstraint::setIdeal): Ditto.
(WebCore::StringConstraint::initializeWithDictionary): Ditto.
- platform/mediastream/MediaConstraints.h: Add abstract classes
BaseConstraint and NumericConstraint, and final classes
DoubleConstraint, LongConstraint, BooleanConstraint, and
StringConstraint.
(WebCore::BaseConstraint::~BaseConstraint):
(WebCore::BaseConstraint::name): Name of constraint associated with.
(WebCore::BaseConstraint::BaseConstraint):
(WebCore::NumericConstraint::setHasMin): Sets min constraint value.
(WebCore::NumericConstraint::setHasMax): Sets max constraint value.
(WebCore::NumericConstraint::setHasExact): Sets exact constraint
value.
(WebCore::NumericConstraint::setHasIdeal): Sets ideal constraint
value.
(WebCore::NumericConstraint::hasMin): Determines whether constraint
has a minimum value.
(WebCore::NumericConstraint::hasMax): Determines whether constraint
has a maximum value.
(WebCore::NumericConstraint::hasExact): Determines whether constraint
has an exact value.
(WebCore::NumericConstraint::NumericConstraint):
- 3:11 PM Changeset in webkit [204146] by
-
- 2 edits in branches/safari-602-branch/Source/WebKit2
Merge r204135. rdar://problem/19814215
- 3:05 PM Changeset in webkit [204145] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the GTK+ build.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_document_get_elements_by_tag_name):
(webkit_dom_document_get_elements_by_tag_name_ns):
(webkit_dom_document_get_elements_by_class_name):
(webkit_dom_element_get_elements_by_tag_name):
(webkit_dom_element_get_elements_by_tag_name_ns):
(webkit_dom_element_get_elements_by_class_name):
- 3:02 PM Changeset in webkit [204144] by
-
- 2 edits in trunk/LayoutTests
Rebaseline http/tests/security/cross-frame-access-put.html after r204126.
Unreviewed test gardening.
- http/tests/security/cross-frame-access-put-expected.txt:
- 3:02 PM Changeset in webkit [204143] by
-
- 6 edits in trunk/Source/WebCore
Add support for wrapper types in dictionaries
https://bugs.webkit.org/show_bug.cgi?id=160487
Reviewed by Sam Weinig.
Add support for nullable wrapper types in dictionaries.
A TypeError is thrown if the conversion fails.
No new tests, updated bindings tests.
- bindings/js/JSDOMConvert.h:
(WebCore::convertWrapperType):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryImplementationContent):
- bindings/scripts/IDLParser.pm:
(parseDictionaryMember):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convert<TestObj::Dictionary>):
- bindings/scripts/test/TestObj.idl:
- 2:45 PM Changeset in webkit [204142] by
-
- 7 edits in trunk
[Mac][cmake] Fix the build after Objective-C bindings generator removal
https://bugs.webkit.org/show_bug.cgi?id=160545
.:
Reviewed by Alex Christensen.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
Reviewed by Alex Christensen.
- CMakeLists.txt:
- PlatformMac.cmake:
Source/WebKit:
Reviewed by Alex Christensen.
- PlatformMac.cmake:
- 2:34 PM Changeset in webkit [204141] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix Windows build after r204134.
Unreviewed build fix.
- dom/DOMAllInOne.cpp:
- 2:11 PM Changeset in webkit [204140] by
-
- 4 edits1 add in trunk
ASSERTION FAILED: !hasInstanceValueNode->isCellConstant() defaultHasInstanceFunction == hasInstanceValueNode->asCell() https://bugs.webkit.org/show_bug.cgi?id=160562
JSTests:
Reviewed by Mark Lam.
- stress/instanceof-late-constant-folding.js: Added.
(Constructor):
(value):
(body):
Source/JavaScriptCore:
<rdar://problem/27704825>
Reviewed by Mark Lam.
This patch fixes an issue where we would emit incorrect code in the DFG when constant folding would
convert a GetByOffset into a constant late in compilation. Additionally, it removes invalid assertions
associated with the assumption that this could not happen.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileOverridesHasInstance): Deleted.
- 2:07 PM Changeset in webkit [204139] by
-
- 3 edits in trunk/Tools
Optimize bot watcher's dashboard a little
https://bugs.webkit.org/show_bug.cgi?id=160515
rdar://problem/26096900
Reviewed by Lucas Forschler.
Made re-sorting after loading an iteration more efficient.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._updateWithData):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.updateIterationPosition):
- 2:05 PM Changeset in webkit [204138] by
-
- 5 edits1 delete in branches/safari-602-branch
- 1:59 PM Changeset in webkit [204137] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove unused intrinsic member of NativeExecutable
https://bugs.webkit.org/show_bug.cgi?id=160560
Reviewed by Saam Barati.
NativeExecutable has an Intrinsic member. It appears that this member is never
used. Instead we use the Intrinsic member NativeExecutable's super class,
ExecutableBase.
- runtime/Executable.h:
- 1:51 PM Changeset in webkit [204136] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Popover's arrow is misplaced
https://bugs.webkit.org/show_bug.cgi?id=151236
<rdar://problem/23527296>
Reviewed by Brian Burg.
- UserInterface/Views/Popover.js:
(WebInspector.Popover.prototype._setAnchorPoint):
Drive-by style fix.
(WebInspector.Popover.prototype._drawFrame):
Position the arrow so that the arrow head doesn't overlap the
rounded corners of its edge.
- 1:33 PM Changeset in webkit [204135] by
-
- 2 edits in trunk/Source/WebKit2
Crash under NavigationState::NavigationClient::processDidCrash()
https://bugs.webkit.org/show_bug.cgi?id=160563
<rdar://problem/19814215>
Reviewed by Sam Weinig.
When WebPageProxy::close() gets called, make sure we destroy the page's
navigationClient. If we don't then the navigationClient can outlive the
navigationState, causing crashes when navigationClient tries to use its
stale navigationState member reference later on. This happens when the
WebPageProxy outlives its WKWebView because:
- WebPageProxy owns the navigationClient
- WKWebView owns the navigationState
- navigationClient has a reference to the navigationState as member.
WebPageProxy can outlive the WKWebView because it is refCounted. It
can happen for example when the client application uses the
RelatedPage API as this extend the lifetime of the related WebPage's
proxy but the application may not keep the related WKWebView alive.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
Note that it is safe to null out m_navigationClient here instead of
creating a fresh one because there is a null check before every use
of m_navigationClient in WebPageProxy.
- 1:27 PM Changeset in webkit [204134] by
-
- 15 edits6 deletes in trunk/Source/WebCore
Remove more Objective-C specific bindings code
https://bugs.webkit.org/show_bug.cgi?id=160564
Reviewed by Sam Weinig.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSNodeCustom.cpp:
- bindings/objc/DOMDocument.mm:
- bindings/objc/DOMEntity.mm:
(-[DOMEntity publicId]):
(-[DOMEntity systemId]):
(-[DOMEntity notationName]):
- bindings/objc/DOMEntityReference.mm:
(kit): Deleted.
- bindings/objc/DOMEntityReferenceInternal.h: Removed.
- bindings/objc/DOMNodeIterator.mm:
(-[DOMNodeIterator expandEntityReferences]):
- bindings/objc/DOMTreeWalker.mm:
(-[DOMTreeWalker expandEntityReferences]):
- dom/Document.idl:
- dom/Entity.h: Removed.
(WebCore::Entity::publicId): Deleted.
(WebCore::Entity::systemId): Deleted.
(WebCore::Entity::notationName): Deleted.
(WebCore::Entity::Entity): Deleted.
- dom/Entity.idl: Removed.
- dom/EntityReference.cpp: Removed.
(WebCore::EntityReference::EntityReference): Deleted.
- dom/EntityReference.h: Removed.
- dom/EntityReference.idl: Removed.
- dom/NodeIterator.idl:
- dom/Traversal.h:
(WebCore::NodeIteratorBase::expandEntityReferences): Deleted.
- dom/TreeWalker.idl:
- 1:12 PM Changeset in webkit [204133] by
-
- 5 edits in trunk/Source/WebCore
Simplify overloads for HTMLSelectElement.add() / HTMLOptionsCollection.add()
https://bugs.webkit.org/show_bug.cgi?id=160527
Reviewed by Ryosuke Niwa.
Simplify overloads for HTMLSelectElement.add() / HTMLOptionsCollection.add().
We now have 2 overloads instead of 3 while achieving the same web-facing
behavior.
- html/HTMLOptionsCollection.h:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::add): Deleted.
- html/HTMLSelectElement.idl:
- 1:02 PM Changeset in webkit [204132] by
-
- 5 edits1 add in branches/safari-602-branch
Merge r204107. rdar://problem/27685273
- 12:33 PM Changeset in webkit [204131] by
-
- 10 edits in trunk/Source/WebCore
Move Objective-C bindings specific code into the bindings
https://bugs.webkit.org/show_bug.cgi?id=160561
Reviewed by Tim Horton.
- bindings/objc/DOMDocument.mm:
(-[DOMDocument createEntityReference:]):
(-[DOMDocument getElementsByTagName:]):
(-[DOMDocument getElementsByTagNameNS:localName:]):
(-[DOMDocument getElementsByClassName:]):
- bindings/objc/DOMElement.mm:
(-[DOMElement getElementsByTagName:]):
(-[DOMElement getElementsByTagNameNS:localName:]):
(-[DOMElement getElementsByClassName:]):
- css/CSSCharsetRule.idl:
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagNameForObjC): Deleted.
(WebCore::ContainerNode::getElementsByTagNameNSForObjC): Deleted.
(WebCore::ContainerNode::getElementsByClassNameForObjC): Deleted.
- dom/ContainerNode.h:
- dom/Document.cpp:
(WebCore::Document::createEntityReference): Deleted.
- dom/Document.h:
- dom/Document.idl:
- dom/Element.idl:
- 12:33 PM Changeset in webkit [204130] by
-
- 9 edits in trunk/Source/JavaScriptCore
[JSC] Speed up InPlaceAbstractState::endBasicBlock()
https://bugs.webkit.org/show_bug.cgi?id=160539
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-04
Reviewed by Mark Lam.
This patch does small improvements to our handling
of value propagation to the successors.
One key insight is that using HashMap to map Nodes
to Value in valuesAtTail is too inefficient at the scale
we use it. Instead, I reuse our existing mapping
from every Node to its value, abstracted by forNode().
Since we are not going to use the mapping after endBasicBlock()
I can replace whatever we had there. The next beginBasicBlock()
will setup the new value as needed.
In endBasicBlock(), valuesAtTail is now a vector of all values live
at tail. For each node, I merge the previous live at tail with
the new value, then replace the value in the mapping.
Liveness Analysis guarantees we won't have duplicates there which
make the replacement sound.
Next, when propagating, I take the vector of values lives at head
and use the global node->value mapping to find its new abstract value.
Again, Liveness Analysis guarantees I won't find a value live at head
that was not replaced by the merging at tail of the predecessor.
All our live lists have become vectors instead of HashTable.
The mapping from Node to Value is always done by array indexing.
Same big-O, much smaller constant.
- dfg/DFGAtTailAbstractState.cpp:
(JSC::DFG::AtTailAbstractState::AtTailAbstractState):
(JSC::DFG::AtTailAbstractState::createValueForNode):
(JSC::DFG::AtTailAbstractState::forNode):
- dfg/DFGAtTailAbstractState.h:
I did not look much into this state, I just made it equivalent
to the previous mapping.
- dfg/DFGBasicBlock.h:
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
AbstractValue is big enough that we really don't want to copy it twice.
(JSC::DFG::InPlaceAbstractState::merge):
(JSC::DFG::setLiveValues): Deleted.
- dfg/DFGInPlaceAbstractState.h:
- dfg/DFGPhiChildren.h:
This is heap allocated by AbstractInterpreter. It should use fastMalloc().
- 12:13 PM Changeset in webkit [204129] by
-
- 17 edits in trunk/Source/WebCore
Clean up the deprecated Objective-C binding methods
https://bugs.webkit.org/show_bug.cgi?id=160558
Reviewed by Tim Horton.
Put the deprecated methods in their respective category @implementation, and
simply have them call their non-deprecated counterparts.
- bindings/objc/DOMCSSMediaRule.mm:
(-[DOMCSSMediaRule deleteRule:]):
(-[DOMCSSMediaRule insertRule::]):
- bindings/objc/DOMCSSPrimitiveValue.mm:
(-[DOMCSSPrimitiveValue setFloatValue::]):
(-[DOMCSSPrimitiveValue setStringValue::]):
- bindings/objc/DOMCSSStyleDeclaration.mm:
(-[DOMCSSStyleDeclaration setProperty:::]):
- bindings/objc/DOMCSSStyleSheet.mm:
(-[DOMCSSStyleSheet insertRule::]):
- bindings/objc/DOMCharacterData.mm:
(-[DOMCharacterData deleteData:length:]):
(-[DOMCharacterData replaceData:length:data:]):
(-[DOMCharacterData remove]):
(-[DOMCharacterData substringData::]):
(-[DOMCharacterData insertData::]):
(-[DOMCharacterData deleteData::]):
(-[DOMCharacterData replaceData:::]):
- bindings/objc/DOMDocument.mm:
(-[DOMDocument createProcessingInstruction::]):
(-[DOMDocument importNode::]):
(-[DOMDocument createElementNS::]):
(-[DOMDocument createAttributeNS::]):
(-[DOMDocument getElementsByTagNameNS::]):
(-[DOMDocument createNodeIterator::::]):
(-[DOMDocument createTreeWalker::::]):
(-[DOMDocument getOverrideStyle::]):
(-[DOMDocument createExpression::]):
(-[DOMDocument evaluate:::::]):
(-[DOMDocument getComputedStyle::]):
- bindings/objc/DOMElement.mm:
(-[DOMElement setAttribute::]):
(-[DOMElement getAttributeNS::]):
(-[DOMElement setAttributeNS:::]):
(-[DOMElement removeAttributeNS::]):
(-[DOMElement getElementsByTagNameNS::]):
(-[DOMElement getAttributeNodeNS::]):
(-[DOMElement hasAttributeNS::]):
- bindings/objc/DOMEvent.mm:
(-[DOMEvent stopImmediatePropagation]):
(-[DOMEvent initEvent:::]):
- bindings/objc/DOMHTMLSelectElement.mm:
(-[DOMHTMLSelectElement remove:]):
(-[DOMHTMLSelectElement add::]):
- bindings/objc/DOMMouseEvent.mm:
(-[DOMMouseEvent initMouseEvent:::::::::::::::]):
- bindings/objc/DOMMutationEvent.mm:
(-[DOMMutationEvent initMutationEvent::::::::]):
- bindings/objc/DOMNamedNodeMap.mm:
(-[DOMNamedNodeMap getNamedItemNS::]):
(-[DOMNamedNodeMap removeNamedItemNS::]):
- bindings/objc/DOMNode.mm:
(-[DOMNode insertBefore::]):
(-[DOMNode replaceChild::]):
(-[DOMNode isSupported::]):
- bindings/objc/DOMRange.mm:
(-[DOMRange setStart::]):
(-[DOMRange setEnd::]):
(-[DOMRange compareBoundaryPoints::]):
- bindings/objc/DOMUIEvent.mm:
(-[DOMUIEvent initUIEvent:::::]):
- bindings/objc/DOMXPathExpression.mm:
(-[DOMXPathExpression evaluate:::]):
- 11:48 AM Changeset in webkit [204128] by
-
- 5 edits2 adds in trunk
Temporary redirected m3u8 streaming stopped working.
https://bugs.webkit.org/show_bug.cgi?id=160472
rdar://problem/27592694
Patch by Jeremy Jones <jeremyj@apple.com> on 2016-08-04
Reviewed by Alex Christensen.
Source/WebCore:
Test: http/tests/media/hls/hls-redirect.html
The change for https://trac.webkit.org/changeset/202466 hides knowledge of the temporary redirected URL from
WebCoreNSURLSession clients. MPEG playlists (e.g. .m3u8) can contain paths relative to the redirected URL.
This change exposes the redirected URL for MPEG playlists.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeMPEGPlaylistMIMETypes): Added.
(WebCore::initializeMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isMPEGPlaylistMIMEType): Added.
- platform/MIMETypeRegistry.h:
- platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]): Add MPEG playlist condition.
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]): Add MPEG playlist condition.
LayoutTests:
This tests that m3u8 files can be loaded when going through a temporary redirect.
- http/tests/media/hls/hls-redirect-expected.txt: Added.
- http/tests/media/hls/hls-redirect.html: Added.
- 11:07 AM Changeset in webkit [204127] by
-
- 25 edits32 adds in trunk
Content Blocker cannot block WebSocket connections
https://bugs.webkit.org/show_bug.cgi?id=160159
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-04
Reviewed by Brady Eidson.
Source/WebCore:
Tests: http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.php
http/tests/websocket/tests/hybi/contentextensions/block-cookies.php
http/tests/websocket/tests/hybi/contentextensions/block-worker.html
http/tests/websocket/tests/hybi/contentextensions/block.html
http/tests/websocket/tests/hybi/contentextensions/display-none-worker.html
http/tests/websocket/tests/hybi/contentextensions/display-none.html
http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html
http/tests/websocket/tests/hybi/contentextensions/upgrade.html
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpgradeURL):
(WebCore::ThreadableWebSocketChannelClientWrapper::suspend):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didClose):
(WebCore::WebSocket::didUpgradeURL):
(WebCore::WebSocket::getFramingOverhead):
- Modules/websockets/WebSocket.h:
Added didUpgradeURL to WebSocketChannelClient so the WebSocketChannel can tell the WebSocket
that it has upgraded a ws: url to a wss: url.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::~WebSocketChannel):
(WebCore::WebSocketChannel::connect):
If content extensions are being used, run the URL through the content extension and apply its actions
before connecting the WebSocket. This is done in WebSocketChannel instead of WebSocket like the CSP checks
because we need access to the Document in order to get access to the main document's URL for if-domain and
unless-domain rules, and to apply any display:none css to the Document.
(WebCore::WebSocketChannel::disconnect):
- Modules/websockets/WebSocketChannelClient.h:
(WebCore::WebSocketChannelClient::~WebSocketChannelClient):
(WebCore::WebSocketChannelClient::WebSocketChannelClient):
(WebCore::WebSocketChannelClient::didConnect):
(WebCore::WebSocketChannelClient::didReceiveMessage):
(WebCore::WebSocketChannelClient::didReceiveBinaryData):
(WebCore::WebSocketChannelClient::didReceiveMessageError):
(WebCore::WebSocketChannelClient::didUpdateBufferedAmount):
(WebCore::WebSocketChannelClient::didStartClosingHandshake):
(WebCore::WebSocketChannelClient::didClose):
Made WebSocketChannelClient purely virtual to avoid accidentally making an implementation that is missing functionality.
(WebCore::WebSocketChannelClient::didUpgradeURL): Added.
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::getExpectedWebSocketAccept):
(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::clientOrigin):
(WebCore::WebSocketHandshake::clientLocation):
(WebCore::WebSocketHandshake::clientHandshakeMessage):
Only put cookies on the WebSocket's handshake if we are allowed to use cookies.
(WebCore::WebSocketHandshake::clientHandshakeRequest):
A WebSocketHandshake always has a Document* for its ScriptExecutionContext, so I replaced m_context with
m_document and removed a suspicious-looking check for is<Document> that turned out to not be suspicious at all.
(WebCore::WebSocketHandshake::reset):
(WebCore::WebSocketHandshake::clearDocument):
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::clearScriptExecutionContext): Deleted.
- Modules/websockets/WebSocketHandshake.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpgradeURL):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- contentextensions/ContentExtensionActions.h:
Before this change we would pass a ResourceRequest as a parameter to the content extension engine.
The ResourceRequest would be used to get the URL, and it would be modified by possibly disabling cookies
or making the URL https. Any display:none CSS rules added were put into the Document through the DocumentLoader.
The only information it needed to return was whether the load was blocked.
To make content extensions work with WebSockets, we need to pass a URL as a parameter instead of a ResourceRequest
because there is no ResourceRequest with WebSockets, only a URL. We can still put CSS rules in through the DocumentLoader,
but the rest of the actions need to be returned through the return value, which is then processed by the callers.
BlockedStatus is now a struct containing a set of actions to apply, and applyBlockedStatusToRequest is a helper function
that applies the actions to the ResourceRequests we have at all previously existing call sites of processContentExtensionRulesForLoad.
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::globalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::displayNoneCSSRule):
(WebCore::ContentExtensions::applyBlockedStatusToRequest):
- contentextensions/ContentExtensionsBackend.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
Here, we also only had a URL. Before, we were making a ResourceRequest from the URL just for the content extension engine,
but now we can just pass the URL.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
- loader/PingLoader.cpp:
(WebCore::processContentExtensionRulesForLoad):
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- page/UserContentProvider.cpp:
(WebCore::contentExtensionsEnabled):
(WebCore::UserContentProvider::processContentExtensionRulesForLoad):
(WebCore::UserContentProvider::actionsForResourceLoad):
- page/UserContentProvider.h:
LayoutTests:
- http/tests/contentextensions/make-https-expected.txt:
Rebased to reflect slight change in console logged messages which contain the same information.
- http/tests/websocket/tests/hybi/contentextensions: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-cookies-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.php: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.php.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-cookies.php: Copied from LayoutTests/http/tests/websocket/tests/hybi/httponly-cookie.pl.
- http/tests/websocket/tests/hybi/contentextensions/block-cookies.php.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-worker-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-worker.html: Added.
- http/tests/websocket/tests/hybi/contentextensions/block-worker.html.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/block.html: Added.
- http/tests/websocket/tests/hybi/contentextensions/block.html.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/display-none-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/display-none-worker-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/display-none-worker.html: Added.
- http/tests/websocket/tests/hybi/contentextensions/display-none-worker.html.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/display-none.html: Added.
- http/tests/websocket/tests/hybi/contentextensions/display-none.html.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/resources: Added.
- http/tests/websocket/tests/hybi/contentextensions/resources/block-cookies-worker.js: Added.
- http/tests/websocket/tests/hybi/contentextensions/resources/block-worker.js: Added.
- http/tests/websocket/tests/hybi/contentextensions/resources/display-none-worker.js: Added.
- http/tests/websocket/tests/hybi/contentextensions/resources/echo-cookie_wsh.py: Copied from LayoutTests/http/tests/websocket/tests/hybi/echo-cookie_wsh.py.
- http/tests/websocket/tests/hybi/contentextensions/resources/echo_wsh.py: Added.
- http/tests/websocket/tests/hybi/contentextensions/resources/upgrade-worker.js: Added.
- http/tests/websocket/tests/hybi/contentextensions/upgrade-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/upgrade-worker-expected.txt: Added.
- http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html: Added.
- http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html.json: Added.
- http/tests/websocket/tests/hybi/contentextensions/upgrade.html: Added.
- http/tests/websocket/tests/hybi/contentextensions/upgrade.html.json: Added.
- 11:03 AM Changeset in webkit [204126] by
-
- 7 edits in trunk
Prototype property of an interface object for a callback interface must be the Object.prototype object
https://bugs.webkit.org/show_bug.cgi?id=160555
Reviewed by Geoffrey Garen.
LayoutTests/imported/w3c:
Rebaseline W3C trst now that one more check is passing.
- web-platform-tests/dom/interfaces-expected.txt:
Source/WebCore:
Prototype property of an interface object for a callback interface
must be the Object.prototype object:
This impacts NodeFilter, which is a callback interface.
No new tests, rebaselined existing test.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
LayoutTests:
Rebaseline existing test.
- platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
- 10:48 AM Changeset in webkit [204125] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add placeholder graphs to TimelineOverview while editing
https://bugs.webkit.org/show_bug.cgi?id=160485
<rdar://problem/27670755>
Reviewed by Brian Burg.
Insert placeholder elements in TimelineOverview's graph container
when editing instruments. This allows alternating overview graph styles
to be shown for disabled instruments, and ensures that every tree element
has a corresponding element in the overview during dragging/reordering
of instruments (see https://webkit.org/b/157957).
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype._startEditingInstruments):
(WebInspector.TimelineOverview.prototype._stopEditingInstruments):
- 10:47 AM Changeset in webkit [204124] by
-
- 4 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: UI polish for Open Quickly and Goto Line dialogs
https://bugs.webkit.org/show_bug.cgi?id=159849
<rdar://problem/27383068>
Reviewed by Brian Burg.
- UserInterface/Images/Search.svg: Added.
Magnifying glass icon.
- UserInterface/Views/GoToLineDialog.css:
(.go-to-line-dialog):
(.go-to-line-dialog > div):
(.go-to-line-dialog > div::before):
- UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .field):
(.open-resource-dialog > .field::before):
(.open-resource-dialog.has-results > .tree-outline):
(.open-resource-dialog > .tree-outline .item):
Add search icon to left of the input field in both dialogs,
and adjust styles to better match Xcode 8.
- UserInterface/Views/OpenResourceDialog.js:
(WebInspector.OpenResourceDialog):
Remove "input" event listener, as styles are now toggled in _updateFilter.
(WebInspector.OpenResourceDialog.prototype._updateFilter):
Toggle "has-results" and "non-empty" class names.
(WebInspector.OpenResourceDialog.prototype._handleInputEvent): Deleted.
(WebInspector.OpenResourceDialog.prototype._clear): Deleted.
Moved class toggle to _updateFilter.
- 10:02 AM Changeset in webkit [204123] by
-
- 3 edits in trunk/Tools
[Win] Unable to reliably run tests in parallel
https://bugs.webkit.org/show_bug.cgi?id=140914
Reviewed by Brent Fulgham.
The cygpath utility function can fail badly when running with multiple DumpRenderTree
processes. We can use string replacement to convert the Cygwin path to a Windows path
instead.
- Scripts/webkitpy/common/system/path.py:
(cygpathFast):
- Scripts/webkitpy/port/driver.py:
(Driver._command_from_driver_input):
- 9:28 AM Changeset in webkit [204122] by
-
- 9 edits in trunk
Element.insertAdjacent*() should throw a SYNTAX_ERR for invalid "where" parameter
https://bugs.webkit.org/show_bug.cgi?id=160514
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt:
- web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt:
- web-platform-tests/dom/nodes/insert-adjacent-expected.txt:
Source/WebCore:
Element.insertAdjacent*() should throw a SYNTAX_ERR for invalid "where" parameter:
We were throwing a NOT_SUPPORTED_ERR instead.
No new tests, rebaselined existing tests.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::insertAdjacent):
LayoutTests:
Rebaseline existing test now that a different exception is thrown.
- fast/dynamic/insertAdjacentElement-expected.txt:
- fast/dynamic/insertAdjacentText-expected.txt:
- 9:10 AM Changeset in webkit [204121] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r204100. rdar://problem/27310475
- 8:59 AM Changeset in webkit [204120] by
-
- 2 edits in trunk/JSTests
[JSC] fix generator-syntax.js JSTest again after yield grammar fix
https://bugs.webkit.org/show_bug.cgi?id=160550
Reviewed by Yusuke Suzuki.
- stress/generator-syntax.js:
(testYieldBindingIdentifier):
- 7:46 AM Changeset in webkit [204119] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ES7] Update features.json for exponentiation expression
https://bugs.webkit.org/show_bug.cgi?id=160541
Reviewed by Mark Lam.
- features.json:
- 2:26 AM Changeset in webkit [204118] by
-
- 3 edits in trunk/Source/WebCore
WebRTC: OWR: Add support for the muted state in the mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=160502
Modified the load, play and stop methods to handle the new
situation where the mediaSource could be empty, until the remote
side sends the information to create the receiver.
Reviewed by Philippe Normand.
No new tests, we need to upstream the owr endpoint to check this
situation.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::play): Check the muted
state of the tracks if required, we do it using the new
maybeHandleChangeMutedState function.
(WebCore::MediaPlayerPrivateGStreamerOwr::load): Add always the
observer of the track to check when it is unmuted, and we delay
enabling/setting the source until the play or the unmute.
(WebCore::MediaPlayerPrivateGStreamerOwr::internalLoad): Removed,
we now do all in the load method.
(WebCore::MediaPlayerPrivateGStreamerOwr::stop): Remove the
mediasource when disabling. Removed the m_stopped state, it was
there because the internalLoad was called multiple times.
(WebCore::MediaPlayerPrivateGStreamerOwr::trackMutedChanged):
Check the muted state and handle it, we use the new method
maybeHandleChangeMutedState.
(WebCore::MediaPlayerPrivateGStreamerOwr::maybeHandleChangeMutedState):
Check if the track is muted or not, in case it is muted disable
the the renderer and remove its mediasource. If it is not muted
enable the renderer and set the mediasource.
(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink): Move
the workaround for the renderer to this method when it is created.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
Removed internalLoad method and the m_stopped attribute used to
call internalLoad multiple times.
- 12:56 AM Changeset in webkit [204117] by
-
- 25 edits5 adds in trunk
DocumentThreadableLoader should pass the fetch mode to underlying loader code
https://bugs.webkit.org/show_bug.cgi?id=160399
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-04
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Updated expectations.
Added new tests to check specifically for Origin header in case of redirections.
Updated server-side redirect.py python script to generate valid Location URLs.
- web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt:
- web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt:
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-origin-expected.txt: Added.
- web-platform-tests/fetch/api/redirect/redirect-origin-worker-expected.txt: Added.
- web-platform-tests/fetch/api/redirect/redirect-origin-worker.html: Added.
- web-platform-tests/fetch/api/redirect/redirect-origin.html: Added.
- web-platform-tests/fetch/api/redirect/redirect-origin.js: Added.
(testOriginAfterRedirection):
- web-platform-tests/fetch/api/redirect/redirect-schemes-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-schemes.html: Updated test so that fetches are done in a deterministic order, one after the other is finished.
- web-platform-tests/fetch/api/resources/redirect.py:
(main):
Source/WebCore:
Tests: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-origin-worker.html
imported/w3c/web-platform-tests/fetch/api/redirect/redirect-origin.html
Covered by existing and rebased tests.
DocumentThredableLoader was previously loading resources in NoCors mode and doing the cors checks on it own.
This was duplicating code and increasing the risk of being not consistent.
DocumentThreadableLoader is now passing the fetch mode given by client to underlying loader code.
This allows removing some CORS checks in DocumentThreadableLoader code for redirections.
Updated SubresourceLoader redirection CORS checks to be on par with DocumentThreadableLoader.
In particular, aligning the code with https://fetch.spec.whatwg.org/#http-redirect-fetch.
The error logging situation is not perfect as some errors are properly logged in the console while some others are not.
For instance blockedError (due to forbidden port for instance) reason is not logged on the console.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived): Updating redirection checking as SubresourceLoader is already doing most of the checks.
(WebCore::DocumentThreadableLoader::didReceiveResponse): Removing temp hack as tainting is now computed by underlying loader code.
(WebCore::DocumentThreadableLoader::loadRequest): Removing fetch mode change.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal): Updating cancellation error and improve error logging.
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl): Improved the checks and error reporting.
Tried to align as much as possible to https://fetch.spec.whatwg.org/#http-redirect-fetch.
- loader/SubresourceLoader.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didFail): Added an error message to the console in case of access control error.
LayoutTests:
- TestExpectations:
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-redirect-blocked-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-worker-redirect-expected.txt:
- http/tests/workers/worker-redirect-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-async.html: Fixed bugs in the test and updated comments.
- http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
- http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt:
- http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt:
Aug 3, 2016:
- 11:53 PM Changeset in webkit [204116] by
-
- 3 edits in trunk/LayoutTests
LayoutTest imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm failing
https://bugs.webkit.org/show_bug.cgi?id=159724
Unreviewed..
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-04
- TestExpectations: Removing Crash expectation since it is only occuring on Debug Mac bots.
- platform/mac/TestExpectations: Skipping test in Debug for Mac bots.
- 10:26 PM Changeset in webkit [204115] by
-
- 6 edits in trunk
Object.getOwnPropertyNames() on NamedNodeMap fails to return named properties
https://bugs.webkit.org/show_bug.cgi?id=160517
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
- web-platform-tests/dom/nodes/attributes-expected.txt:
Source/WebCore:
Object.getOwnPropertyNames() on NamedNodeMap should return named
properties' names as per:
No new tests, rebaselined existing tests.
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::supportedPropertyNames):
- dom/NamedNodeMap.h:
- 10:11 PM Changeset in webkit [204114] by
-
- 15 edits in trunk
Drop DocumentType.internalSubset attribute
https://bugs.webkit.org/show_bug.cgi?id=160530
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/historical-expected.txt:
Source/JavaScriptCore:
Drop DocumentType.internalSubset attribute.
- inspector/protocol/DOM.json:
Source/WebCore:
Drop DocumentType.internalSubset attribute.
It is no longer in the DOM specification:
- https://dom.spec.whatwg.org/#documenttype
- https://w3c.github.io/DOM-Parsing/#xml-serializing-a-documenttype-node
Other browsers have already dropped it. In WebKit, it was always null
anyway.
No new tests, rebaselined existing test.
- bindings/objc/DOMDocumentType.mm:
(-[DOMDocumentType internalSubset]):
- dom/DocumentType.h:
- dom/DocumentType.idl:
- dom/Node.cpp:
(WebCore::Node::isEqualNode): Deleted.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendDocumentType): Deleted.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode): Deleted.
Source/WebInspectorUI:
Drop DocumentType.internalSubset attribute.
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode): Deleted.
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.titleForDOMNode): Deleted.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo): Deleted.
- 10:09 PM Changeset in webkit [204113] by
-
- 10 edits2 deletes in trunk
Drop legacy Document.defaultCharset attribute
https://bugs.webkit.org/show_bug.cgi?id=160536
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop legacy Document.defaultCharset attribute.
It is no longer in the specification:
Firefox and Chrome have already dropped it.
No new tests, rebaselined existing test.
- bindings/objc/DOMDocument.mm:
(-[DOMDocument defaultCharset]):
- dom/Document.cpp:
(WebCore::Document::defaultCharsetForBindings):
- dom/Document.h:
- dom/Document.idl:
LayoutTests:
- fast/dom/Document/document-charset-expected.txt:
- fast/dom/Document/document-charset.html:
Drop defaultCharset checks.
- fast/frames/detached-frame-document-defaultCharset-expected.txt: Removed.
- fast/frames/detached-frame-document-defaultCharset.html: Removed.
Drop test that is no longer useful now that we dropped defaultCharset.
- 8:43 PM Changeset in webkit [204112] by
-
- 8 edits in trunk/Source/JavaScriptCore
[JSC] Improve the memory locality of DFG Node's AbstractValues
https://bugs.webkit.org/show_bug.cgi?id=160443
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-03
Reviewed by Mark Lam.
The AbstractInterpreter spends a lot of time on memory operations
for AbstractValues. This patch attempts to improve the situation
by putting the values closer together in memory.
First, AbstractValue is moved out of DFG::Node and it kept in
a vector addressed by node indices.
I initially moved them to InPlaceAbstractState but I quickly discovered
initializing the values in the vector was costly.
I moved the vector to Graph as a cache shared by every instantiation of
InPlaceAbstractState. It is mainly there to avoid constructors and destructors
of AbstractValue. The patch of https://bugs.webkit.org/show_bug.cgi?id=160370
should also help eventually.
I instrumented CFA to find how packed is SparseCollection.
The answer is it can be very sparse, which is bad for CFA.
I added packIndices() to repack the collection before running
liveness since that's where we start using the memory intensively.
This is a measurable improvement but it implies we can no longer
keep indices on a side channel between phases since they may change.
- b3/B3SparseCollection.h:
(JSC::B3::SparseCollection::packIndices):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::packNodeIndices):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::abstractValuesCache):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::InPlaceAbstractState):
- dfg/DFGInPlaceAbstractState.h:
(JSC::DFG::InPlaceAbstractState::forNode):
- dfg/DFGLivenessAnalysisPhase.cpp:
(JSC::DFG::performLivenessAnalysis):
- dfg/DFGNode.h:
- 7:36 PM Changeset in webkit [204111] by
-
- 7 edits in trunk
Clarify SyntaxErrors around yield and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=158460
Reviewed by Saam Barati.
Fix and unskip tests which erroneously asserted that
yieldis not a
valid BindingIdentifier, and improve error message for YieldExpressions
occuring in Arrow formal parameters.
JSTests:
- stress/generator-syntax.js:
- stress/yield-out-of-generator.js:
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::Scope::MaybeParseAsGeneratorForScope::MaybeParseAsGeneratorForScope):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseYieldExpression):
- parser/Parser.h:
- 6:38 PM Changeset in webkit [204110] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 6:27 PM Changeset in webkit [204109] by
-
- 2 edits in trunk/LayoutTests
Marking media/track/track-in-band-cues-added-once.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=142152
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:00 PM Changeset in webkit [204108] by
-
- 21 edits2 deletes in trunk/Source/WebCore
Remove some unneeded #ifs now that the Objective-C bindings are frozen
https://bugs.webkit.org/show_bug.cgi?id=160532
Reviewed by Tim Horton.
- DerivedSources.make:
- Modules/mediasession/HTMLMediaElementMediaSession.idl:
- Modules/mediastream/HTMLMediaElementMediaStream.idl:
- WebCore.xcodeproj/project.pbxproj:
- animation/DocumentAnimation.idl:
- dom/ChildNode.idl:
- dom/Document.idl:
- dom/Element.idl:
- dom/Event.idl:
- dom/ParentNode.idl:
- fileapi/Blob.idl:
- fileapi/FileError.idl:
- html/DOMSettableTokenList.h: Removed.
- html/DOMSettableTokenList.idl: Removed.
- html/HTMLCanvasElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLFrameElement.idl:
- html/HTMLIFrameElement.idl:
- html/HTMLMediaElement.idl:
- html/HTMLObjectElement.idl:
- html/HTMLOptionsCollection.idl:
- html/HTMLVideoElement.idl:
- 4:50 PM Changeset in webkit [204107] by
-
- 5 edits1 add in trunk
[iOS] SF-Heavy is not accessible from web content
https://bugs.webkit.org/show_bug.cgi?id=160522
<rdar://problem/27685273>
Reviewed by Simon Fraser.
Source/WebCore:
The mappings we were using from CSS font-weight to CoreText font weight were inaccurate.
Instead, these new mappings should be used.
Test: fast/text/system-font-weight.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::systemFontModificationAttributes):
LayoutTests:
- platform/ios-simulator/fast/text/system-font-weight-expected.txt: iOS 9 is not
expected to pass this test, but there is no way to specify that currently using
TestExpectations. Instead, we can create an iOS 9 specific result.
- fast/text/system-font-weight-expected.txt:
- fast/text/system-font-weight.html:
- 4:44 PM LayoutTestDashboards edited by
- (diff)
- 4:41 PM Changeset in webkit [204106] by
-
- 1 copy in tags/Safari-602.1.47
New tag.
- 4:25 PM Changeset in webkit [204105] by
-
- 2 edits in trunk/Tools
Document instructions for increasing process and file limits
https://bugs.webkit.org/show_bug.cgi?id=160528
rdar://problem/24777576
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_child_processes):
- 3:53 PM Changeset in webkit [204104] by
-
- 5 edits3 deletes in trunk
Remove the Objective-C bindings generator
https://bugs.webkit.org/show_bug.cgi?id=160526
Reviewed by Sam Weinig.
Source/WebCore:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/PublicDOMInterfaces.h: Removed.
- bindings/scripts/CodeGeneratorObjC.pm: Removed.
- bindings/scripts/test/ObjC/DOMFloat64Array.h: Removed.
- bindings/scripts/test/ObjC/DOMFloat64Array.mm: Removed.
- bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMInterfaceName.h: Removed.
- bindings/scripts/test/ObjC/DOMInterfaceName.mm: Removed.
- bindings/scripts/test/ObjC/DOMInterfaceNameInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h: Removed.
- bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCallback.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCallback.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestCallbackFunction.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCallbackFunction.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestCallbackFunctionInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestClassWithJSBuiltinConstructor.h: Removed.
- bindings/scripts/test/ObjC/DOMTestClassWithJSBuiltinConstructor.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestClassWithJSBuiltinConstructorInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObject.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObject.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObjectInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Removed.
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestEventConstructor.h: Removed.
- bindings/scripts/test/ObjC/DOMTestEventConstructor.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestEventTarget.h: Removed.
- bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestException.h: Removed.
- bindings/scripts/test/ObjC/DOMTestException.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Removed.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestGlobalObject.h: Removed.
- bindings/scripts/test/ObjC/DOMTestGlobalObject.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestGlobalObjectInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestImplements.cpp: Removed.
- bindings/scripts/test/ObjC/DOMTestImplements.h: Removed.
- bindings/scripts/test/ObjC/DOMTestInterface.h: Removed.
- bindings/scripts/test/ObjC/DOMTestInterface.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestIterable.h: Removed.
- bindings/scripts/test/ObjC/DOMTestIterable.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestIterableInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.h: Removed.
- bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructorInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h: Removed.
- bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestNamedConstructor.h: Removed.
- bindings/scripts/test/ObjC/DOMTestNamedConstructor.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestNode.h: Removed.
- bindings/scripts/test/ObjC/DOMTestNode.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestNondeterministic.h: Removed.
- bindings/scripts/test/ObjC/DOMTestNondeterministic.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestNondeterministicInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestObj.h: Removed.
- bindings/scripts/test/ObjC/DOMTestObj.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestObjInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h: Removed.
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestOverrideBuiltins.h: Removed.
- bindings/scripts/test/ObjC/DOMTestOverrideBuiltins.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestOverrideBuiltinsInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Removed.
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMTestSupplemental.cpp: Removed.
- bindings/scripts/test/ObjC/DOMTestSupplemental.h: Removed.
- bindings/scripts/test/ObjC/DOMTestTypedefs.h: Removed.
- bindings/scripts/test/ObjC/DOMTestTypedefs.mm: Removed.
- bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMattribute.h: Removed.
- bindings/scripts/test/ObjC/DOMattribute.mm: Removed.
- bindings/scripts/test/ObjC/DOMattributeInternal.h: Removed.
- bindings/scripts/test/ObjC/DOMreadonly.h: Removed.
- bindings/scripts/test/ObjC/DOMreadonly.mm: Removed.
- bindings/scripts/test/ObjC/DOMreadonlyInternal.h: Removed.
- bindings/scripts/test/ObjC/ObjCTestSupplemental.cpp: Removed.
- bindings/scripts/test/ObjC/ObjCTestSupplemental.h: Removed.
Tools:
- Scripts/run-bindings-tests:
Update test.
- 3:46 PM IncreasingKernelLimits edited by
- (diff)
- 2:55 PM IncreasingKernelLimits created by
- 2:31 PM Changeset in webkit [204103] by
-
- 136 edits58 deletes in trunk/Source/WebCore
Remove dead bindings code
https://bugs.webkit.org/show_bug.cgi?id=160521
Reviewed by Tim Horton.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMBlob.mm:
(core): Deleted.
- bindings/objc/DOMBlobInternal.h:
- bindings/objc/DOMCDATASection.mm:
(core): Deleted.
- bindings/objc/DOMCDATASectionInternal.h:
- bindings/objc/DOMCSSCharsetRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSCharsetRuleInternal.h: Removed.
- bindings/objc/DOMCSSFontFaceRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSFontFaceRuleInternal.h: Removed.
- bindings/objc/DOMCSSImportRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSImportRuleInternal.h: Removed.
- bindings/objc/DOMCSSMediaRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSMediaRuleInternal.h: Removed.
- bindings/objc/DOMCSSPageRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSPageRuleInternal.h: Removed.
- bindings/objc/DOMCSSPrimitiveValue.mm:
(core): Deleted.
- bindings/objc/DOMCSSPrimitiveValueInternal.h:
- bindings/objc/DOMCSSRule.mm:
(core): Deleted.
- bindings/objc/DOMCSSRuleInternal.h:
- bindings/objc/DOMCSSRuleList.mm:
(core): Deleted.
- bindings/objc/DOMCSSRuleListInternal.h:
- bindings/objc/DOMCSSStyleRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSStyleRuleInternal.h: Removed.
- bindings/objc/DOMCSSStyleSheet.mm:
(core): Deleted.
- bindings/objc/DOMCSSStyleSheetInternal.h:
- bindings/objc/DOMCSSUnknownRule.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSUnknownRuleInternal.h: Removed.
- bindings/objc/DOMCSSValue.mm:
(core): Deleted.
- bindings/objc/DOMCSSValueInternal.h:
- bindings/objc/DOMCSSValueList.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCSSValueListInternal.h: Removed.
- bindings/objc/DOMCharacterData.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMCharacterDataInternal.h: Removed.
- bindings/objc/DOMComment.mm:
(core): Deleted.
- bindings/objc/DOMCommentInternal.h:
- bindings/objc/DOMCounter.mm:
(core): Deleted.
- bindings/objc/DOMCounterInternal.h:
- bindings/objc/DOMDOMImplementation.mm:
(core): Deleted.
- bindings/objc/DOMDOMImplementationInternal.h:
- bindings/objc/DOMDOMTokenList.mm:
(core): Deleted.
- bindings/objc/DOMDOMTokenListInternal.h:
- bindings/objc/DOMEntity.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMEntityInternal.h: Removed.
- bindings/objc/DOMEntityReference.mm:
(core): Deleted.
- bindings/objc/DOMEntityReferenceInternal.h:
- bindings/objc/DOMFile.mm:
(core): Deleted.
- bindings/objc/DOMFileInternal.h:
- bindings/objc/DOMHTMLAnchorElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLAnchorElementInternal.h: Removed.
- bindings/objc/DOMHTMLAppletElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLAppletElementInternal.h: Removed.
- bindings/objc/DOMHTMLAreaElement.mm:
(kit): Deleted.
- bindings/objc/DOMHTMLAreaElementInternal.h:
- bindings/objc/DOMHTMLBRElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLBRElementInternal.h: Removed.
- bindings/objc/DOMHTMLBaseElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLBaseElementInternal.h: Removed.
- bindings/objc/DOMHTMLBaseFontElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLBaseFontElementInternal.h: Removed.
- bindings/objc/DOMHTMLBodyElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLBodyElementInternal.h: Removed.
- bindings/objc/DOMHTMLButtonElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLButtonElementInternal.h: Removed.
- bindings/objc/DOMHTMLCanvasElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLCanvasElementInternal.h: Removed.
- bindings/objc/DOMHTMLCollection.mm:
(core): Deleted.
- bindings/objc/DOMHTMLCollectionInternal.h:
- bindings/objc/DOMHTMLDListElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLDListElementInternal.h: Removed.
- bindings/objc/DOMHTMLDirectoryElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLDirectoryElementInternal.h: Removed.
- bindings/objc/DOMHTMLDivElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLDivElementInternal.h: Removed.
- bindings/objc/DOMHTMLEmbedElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLEmbedElementInternal.h: Removed.
- bindings/objc/DOMHTMLFieldSetElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLFieldSetElementInternal.h: Removed.
- bindings/objc/DOMHTMLFontElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLFontElementInternal.h: Removed.
- bindings/objc/DOMHTMLFormElement.mm:
(core): Deleted.
- bindings/objc/DOMHTMLFormElementInternal.h:
- bindings/objc/DOMHTMLFrameElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLFrameElementInternal.h: Removed.
- bindings/objc/DOMHTMLFrameSetElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLFrameSetElementInternal.h: Removed.
- bindings/objc/DOMHTMLHRElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLHRElementInternal.h: Removed.
- bindings/objc/DOMHTMLHeadElement.mm:
(core): Deleted.
- bindings/objc/DOMHTMLHeadElementInternal.h:
- bindings/objc/DOMHTMLHeadingElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLHeadingElementInternal.h: Removed.
- bindings/objc/DOMHTMLHtmlElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLHtmlElementInternal.h: Removed.
- bindings/objc/DOMHTMLIFrameElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLIFrameElementInternal.h: Removed.
- bindings/objc/DOMHTMLImageElement.mm:
(kit): Deleted.
- bindings/objc/DOMHTMLImageElementInternal.h:
- bindings/objc/DOMHTMLLIElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLLIElementInternal.h: Removed.
- bindings/objc/DOMHTMLLabelElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLLabelElementInternal.h: Removed.
- bindings/objc/DOMHTMLLegendElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLLegendElementInternal.h: Removed.
- bindings/objc/DOMHTMLLinkElement.mm:
(kit): Deleted.
- bindings/objc/DOMHTMLLinkElementInternal.h:
- bindings/objc/DOMHTMLMapElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLMapElementInternal.h: Removed.
- bindings/objc/DOMHTMLMarqueeElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLMarqueeElementInternal.h: Removed.
- bindings/objc/DOMHTMLMediaElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLMediaElementInternal.h: Removed.
- bindings/objc/DOMHTMLMenuElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLMenuElementInternal.h: Removed.
- bindings/objc/DOMHTMLMetaElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLMetaElementInternal.h: Removed.
- bindings/objc/DOMHTMLModElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLModElementInternal.h: Removed.
- bindings/objc/DOMHTMLOListElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLOListElementInternal.h: Removed.
- bindings/objc/DOMHTMLObjectElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLObjectElementInternal.h: Removed.
- bindings/objc/DOMHTMLOptGroupElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLOptGroupElementInternal.h: Removed.
- bindings/objc/DOMHTMLOptionsCollection.mm:
(core): Deleted.
- bindings/objc/DOMHTMLOptionsCollectionInternal.h:
- bindings/objc/DOMHTMLParagraphElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLParagraphElementInternal.h: Removed.
- bindings/objc/DOMHTMLParamElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLParamElementInternal.h: Removed.
- bindings/objc/DOMHTMLPreElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLPreElementInternal.h: Removed.
- bindings/objc/DOMHTMLQuoteElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLQuoteElementInternal.h: Removed.
- bindings/objc/DOMHTMLScriptElement.mm:
(core): Deleted.
- bindings/objc/DOMHTMLScriptElementInternal.h:
- bindings/objc/DOMHTMLSelectElement.mm:
(kit): Deleted.
- bindings/objc/DOMHTMLSelectElementInternal.h:
- bindings/objc/DOMHTMLStyleElement.mm:
(kit): Deleted.
- bindings/objc/DOMHTMLStyleElementInternal.h:
- bindings/objc/DOMHTMLTableColElement.mm:
(kit): Deleted.
- bindings/objc/DOMHTMLTableColElementInternal.h:
- bindings/objc/DOMHTMLTableElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLTableElementInternal.h: Removed.
- bindings/objc/DOMHTMLTableRowElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLTableRowElementInternal.h: Removed.
- bindings/objc/DOMHTMLTitleElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLTitleElementInternal.h: Removed.
- bindings/objc/DOMHTMLUListElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLUListElementInternal.h: Removed.
- bindings/objc/DOMHTMLVideoElement.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMHTMLVideoElementInternal.h: Removed.
- bindings/objc/DOMKeyboardEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMKeyboardEventInternal.h: Removed.
- bindings/objc/DOMMediaError.mm:
(core): Deleted.
- bindings/objc/DOMMediaErrorInternal.h:
- bindings/objc/DOMMediaList.mm:
(core): Deleted.
- bindings/objc/DOMMediaListInternal.h:
- bindings/objc/DOMMouseEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMMouseEventInternal.h: Removed.
- bindings/objc/DOMMutationEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMMutationEventInternal.h: Removed.
- bindings/objc/DOMNamedNodeMap.mm:
(core): Deleted.
- bindings/objc/DOMNamedNodeMapInternal.h:
- bindings/objc/DOMNodeIterator.mm:
(core): Deleted.
- bindings/objc/DOMNodeIteratorInternal.h:
- bindings/objc/DOMNodeList.mm:
(core): Deleted.
- bindings/objc/DOMNodeListInternal.h:
- bindings/objc/DOMOverflowEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMOverflowEventInternal.h: Removed.
- bindings/objc/DOMProgressEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMProgressEventInternal.h: Removed.
- bindings/objc/DOMRGBColor.mm:
(core): Deleted.
- bindings/objc/DOMRGBColorInternal.h:
- bindings/objc/DOMRect.mm:
(core): Deleted.
- bindings/objc/DOMRectInternal.h:
- bindings/objc/DOMStyleSheet.mm:
(core): Deleted.
- bindings/objc/DOMStyleSheetInternal.h:
- bindings/objc/DOMStyleSheetList.mm:
(core): Deleted.
- bindings/objc/DOMStyleSheetListInternal.h:
- bindings/objc/DOMText.mm:
(core): Deleted.
- bindings/objc/DOMTextEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMTextEventInternal.h: Removed.
- bindings/objc/DOMTextInternal.h:
- bindings/objc/DOMTimeRanges.mm:
(core): Deleted.
- bindings/objc/DOMTimeRangesInternal.h:
- bindings/objc/DOMTreeWalker.mm:
(core): Deleted.
- bindings/objc/DOMTreeWalkerInternal.h:
- bindings/objc/DOMUIEvent.mm:
(core): Deleted.
(kit): Deleted.
- bindings/objc/DOMUIEventInternal.h: Removed.
- bindings/objc/DOMWheelEvent.mm:
(kit): Deleted.
- bindings/objc/DOMWheelEventInternal.h:
- bindings/objc/DOMXPathExpression.mm:
(core): Deleted.
- bindings/objc/DOMXPathExpressionInternal.h:
- 2:08 PM Changeset in webkit [204102] by
-
- 19 edits2 deletes in branches/safari-602-branch
- 2:08 PM Changeset in webkit [204101] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
- 1:57 PM Changeset in webkit [204100] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Work around AVPlayer setMuted bug
https://bugs.webkit.org/show_bug.cgi?id=160519
<rdar://problem/27310475>
Reviewed by Dean Jackson.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Only override
supportsMuting on iOS.
- 1:49 PM Changeset in webkit [204099] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page
https://bugs.webkit.org/show_bug.cgi?id=158028
<rdar://problem/26516663>
Reviewed by Timothy Hatcher.
Remove Command-L shortcut for opening the Line Number dialog, since
we already support Control-G.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor): Deleted.
- 1:23 PM Changeset in webkit [204098] by
-
- 8 copies1 add in releases/Apple/Safari Technology Preview 10
Added a tag for Safari Technology Preview release 10.
- 1:06 PM Changeset in webkit [204097] by
-
- 4 edits in trunk/Source/WebKit2
[SOUP] Deduplicate WebProcessPool::setIgnoreTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=160489
Reviewed by Alex Christensen.
WebProcessPool::setIgnoreTLSErrors has identical implementation in WebProcessPoolEfl.cpp
and WebProcessPoolGtk.cpp. We have WebProcessPoolSoup.cpp and this function is specific to
the soup network backend, so move it there.
- UIProcess/efl/WebProcessPoolEfl.cpp:
(WebKit::WebProcessPool::setIgnoreTLSErrors): Deleted.
- UIProcess/gtk/WebProcessPoolGtk.cpp:
(WebKit::WebProcessPool::setIgnoreTLSErrors): Deleted.
- UIProcess/soup/WebProcessPoolSoup.cpp:
(WebKit::WebProcessPool::setIgnoreTLSErrors):
- 12:40 PM Changeset in webkit [204096] by
-
- 11 edits1 copy1 delete in trunk/LayoutTests
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Renamed from LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt:
- 12:10 PM Changeset in webkit [204095] by
-
- 4 edits2 adds in branches/safari-602-branch
Merge r204074. rdar://problem/25856238
- 12:10 PM Changeset in webkit [204094] by
-
- 3 edits in branches/safari-602-branch/Source/WebCore
Merge r204089. rdar://problem/27313234
- 11:50 AM Changeset in webkit [204093] by
-
- 4 edits1 add in trunk
REGRESSION(r203368): broke some test262 tests
https://bugs.webkit.org/show_bug.cgi?id=160479
Reviewed by Mark Lam.
JSTests:
Added a stress test for this case, since we don't always run test262.
- stress/freeze-setter.js: Added.
(let.o.set foo):
Source/JavaScriptCore:
The optimization in r203368 overlooked a subtle detail: freezing should not set ReadOnly on
Accessor properties.
- runtime/Structure.cpp:
(JSC::Structure::nonPropertyTransition):
- runtime/StructureTransitionTable.h:
(JSC::setsDontDeleteOnAllProperties):
(JSC::setsReadOnlyOnNonAccessorProperties):
(JSC::setsReadOnlyOnAllProperties): Deleted.
- 11:44 AM Changeset in webkit [204092] by
-
- 2 edits in trunk/Tools
Revise a TestWebKitAPI comment to mention the actual underlying problem
- TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
- 11:43 AM Changeset in webkit [204091] by
-
- 4 edits in trunk/Source/bmalloc
[bmalloc] Merging of XLargeRanges can leak the upper range
https://bugs.webkit.org/show_bug.cgi?id=160403
Reviewed by Michael Saboff.
- bmalloc/Heap.cpp:
(bmalloc::Heap::scavengeLargeObjects): Don't use removePhysical().
Recorded physical size is a performance optimization. It is not the
truth. So it might be zero even if a range contains physical pages.
Instead, iterate each range in the map unconditionally.
The map can shrink when we release the lock, so we must clamp our
iterator each time through the loop.
The map can grow when we release the lock, but we don't care because
growth restarts the scavenger from the beginning.
- bmalloc/XLargeMap.cpp:
(bmalloc::XLargeMap::removePhysical): Deleted. Not used anymore.
- bmalloc/XLargeMap.h:
(bmalloc::XLargeMap::ranges): Added direct access for the sake of
scavengeLargeObjects. (This violates our naming conventions -- I'll do
a rename in a follow-up patch.)
- 11:35 AM Changeset in webkit [204090] by
-
- 230 edits in trunk/LayoutTests
Fix logging in W3C tests
https://bugs.webkit.org/show_bug.cgi?id=160513
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C tests.
- web-platform-tests/XMLHttpRequest/open-url-about-blank-window-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-javascript-window-2-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-javascript-window-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-multi-window-4-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-multi-window-5-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-multi-window-expected.txt:
- web-platform-tests/XMLHttpRequest/send-content-type-string-expected.txt:
- web-platform-tests/dom/collections/domstringmap-supported-property-names-expected.txt:
- web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
- web-platform-tests/dom/nodes/Comment-constructor-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_bmp-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_css-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_gif-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_html-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_jpg-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_01-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_02-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_png-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_txt-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_xml-expected.txt:
- web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
- web-platform-tests/dom/nodes/Element-childElement-null-expected.txt:
- web-platform-tests/dom/nodes/Element-childElement-null-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-dynamic-remove-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-dynamic-remove-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-nochild-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-nochild-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-childElementCount-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-children-expected.txt:
- web-platform-tests/dom/nodes/Element-firstElementChild-entity-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-firstElementChild-expected.txt:
- web-platform-tests/dom/nodes/Element-firstElementChild-namespace-expected.txt:
- web-platform-tests/dom/nodes/Element-firstElementChild-namespace-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-firstElementChild-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt:
- web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt:
- web-platform-tests/dom/nodes/Element-lastElementChild-expected.txt:
- web-platform-tests/dom/nodes/Element-lastElementChild-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-nextElementSibling-expected.txt:
- web-platform-tests/dom/nodes/Element-nextElementSibling-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-previousElementSibling-expected.txt:
- web-platform-tests/dom/nodes/Element-previousElementSibling-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Element-siblingElement-null-expected.txt:
- web-platform-tests/dom/nodes/Element-siblingElement-null-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Node-appendChild-expected.txt:
- web-platform-tests/dom/nodes/Node-contains-xml-expected.txt:
- web-platform-tests/dom/nodes/Node-isEqualNode-xhtml-expected.txt:
- web-platform-tests/dom/nodes/Node-removeChild-expected.txt:
- web-platform-tests/dom/nodes/Text-constructor-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-19-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-20-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-21-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-22-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-23-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-24-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-25-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-26-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-27-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-28-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-29-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-30-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-31-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-basic-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-currentNode-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-traversal-reject-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-traversal-skip-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most-expected.txt:
- web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree-expected.txt:
- web-platform-tests/domparsing/innerhtml-05-expected.txt:
- web-platform-tests/fetch/nosniff/image-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-xhtml-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.images-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-01-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-02-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-06-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/049-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/050-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/051-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-write/document.write-02-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-02-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/001-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/004-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/005-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/006-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/007-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/008-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/009-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/011-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/012-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/013-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/014-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/015-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/016-expected.txt:
- web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/document.open-03-expected.txt:
- web-platform-tests/html/dom/reflection-embedded-expected.txt:
- web-platform-tests/html/dom/reflection-forms-expected.txt:
- web-platform-tests/html/dom/reflection-grouping-expected.txt:
- web-platform-tests/html/dom/reflection-metadata-expected.txt:
- web-platform-tests/html/dom/reflection-misc-expected.txt:
- web-platform-tests/html/dom/reflection-obsolete-expected.txt:
- web-platform-tests/html/dom/reflection-sections-expected.txt:
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
- web-platform-tests/html/dom/reflection-text-expected.txt:
- web-platform-tests/html/semantics/disabled-elements/disabledElement-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_multiple-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/addCue-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/removeCue-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/endTime-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/id-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/pauseOnExit-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/startTime-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/track-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/getCueById-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/getter-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/length-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/video_008-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/video_volume_check-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-dimension-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/error-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/select-an-image-source-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/update-media-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-object-element/object-handler-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-video-element/video-tabindex-expected.txt:
- web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-customError-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-patternMismatch-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
- web-platform-tests/html/semantics/forms/the-button-element/button-validation-expected.txt:
- web-platform-tests/html/semantics/forms/the-datalist-element/datalistoptions-expected.txt:
- web-platform-tests/html/semantics/forms/the-fieldset-element/disabled-001-expected.txt:
- web-platform-tests/html/semantics/forms/the-fieldset-element/disabled-002-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-matches-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-01-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-indexed-element-expected.txt:
- web-platform-tests/html/semantics/forms/the-form-element/form-nameditem-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/button-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/radio-groupname-case-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/reset-expected.txt:
- web-platform-tests/html/semantics/forms/the-option-element/option-text-backslash-expected.txt:
- web-platform-tests/html/semantics/forms/the-output-element/output-expected.txt:
- web-platform-tests/html/semantics/forms/the-progress-element/progress-expected.txt:
- web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-expected.txt:
- web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem-expected.txt:
- web-platform-tests/html/semantics/forms/the-select-element/select-named-getter-expected.txt:
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-expected.txt:
- web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_003-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_004-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_005-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_006-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_007-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_008-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/async_010-expected.txt:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-noembed-noframes-iframe-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/checked-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/dir-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/dir01-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/enabled-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/indeterminate-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/required-optional-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-table-element/tBodies-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-tbody-element/insertRow-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-tr-element/cells-expected.txt:
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-getter-01-expected.txt:
- web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-setter-01-expected.txt:
LayoutTests:
Fix logging in W3C tests. Some W3C tests have no visible output or
output in the wrong order because we fail to use the test's "log"
<div> and always append the log lines to the body.
- resources/testharnessreport.js:
(self.testRunner.add_completion_callback):
- 11:17 AM Changeset in webkit [204089] by
-
- 3 edits in trunk/Source/WebCore
Cleanup HTMLMediaElement track lists.
https://bugs.webkit.org/show_bug.cgi?id=160470
Reviewed by Brent Fulgham.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::willRemove): Remove unnecessary ASSERT and NULL check.
- html/track/TextTrackList.cpp:
(TextTrackList::~TextTrackList): Call clearElement so media element and client pointers are
cleared.
- 11:11 AM Changeset in webkit [204088] by
-
- 11 edits in trunk
[Mac] media/pip-video-going-into-fullscreen.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=160469
Reviewed by Eric Carlson.
Source/WebCore:
When going from picture-in-picture directly to fullscreen, fix the issue where the
presentation mode unexpectedly changes back to inline after changing to fullscreen.
On Mac, standard fullscreen is not handled by WebVideoFullscreenManager.
When going from picture-in-picture directly to fullscreen, we call
WebVideoFullscreenInterfaceMac::exitFullscreenWithoutAnimationToMode().
We should update m_mode to VideoFullscreenModeStandard there to keep it in sync
with the fullscreen mode in HTMLMediaElement. Otherwise, we'll inadvertently
update the mode to inline when we clear the VideoFullscreenModePictureInPicture mode
in -[WebVideoFullscreenInterfaceMacObjC pipDidClose:].
Since standard fullscreen on Mac doesn't make use of the video fullscreen layer,
we need to make sure we return the video layer back to inline when the presentation
mode changes to "fullscreen". We only do this on Mac because iOS does use
the video fullscreen layer for standard fullscreen.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::setPreparedToReturnVideoLayerToInline):
Renamed from MediaControlsHost::setPreparedForInline to make it clear this is about
whether the video layer should be inline.
(WebCore::MediaControlsHost::setPreparedForInline): Deleted.
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.shouldReturnVideoLayerToInline):
On Mac, the video layer is inline when the presentation mode is "inline" or "fullscreen".
(Controller.prototype.handlePresentationModeChange):
Call shouldReturnVideoLayerToInline() to determine whether the video layer should be inline.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.shouldReturnVideoLayerToInline):
Override this method since on iOS, the video layer is only inline when the presentation
mode is "inline".
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::setPreparedToReturnVideoLayerToInline):
(WebCore::HTMLMediaElement::setPreparedForInline): Deleted.
- html/HTMLMediaElement.h:
- platform/mac/WebVideoFullscreenInterfaceMac.mm:
(WebCore::WebVideoFullscreenInterfaceMac::enterFullscreen):
Remove the assertion that the mode must be "picture-in-picture". I've run into this
assertion in layout tests. Since the EnterFullscreen message is sent in a dispatch_async
block in WebVideoFullscreenManager::didSetupFullscreen(), there's a chance that the
fullscreen mode tracked in WebVideoFullscreenInterfaceMac has already changed to
something else when WebVideoFullscreenInterfaceMac::enterFullscreen() is called.
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreenWithoutAnimationToMode):
If exiting to standard fullscreen, update m_mode to VideoFullscreenModeStandard.
LayoutTests:
Re-enable media/pip-video-going-into-fullscreen.html on Sierra.
- platform/mac-wk2/TestExpectations:
- 11:05 AM Changeset in webkit [204087] by
-
- 2 edits1 add in trunk/Tools
Benchmark test content-animation timeouts always
https://bugs.webkit.org/show_bug.cgi?id=160057
Reviewed by Simon Fraser.
- Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
- Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(start):
- 10:22 AM Changeset in webkit [204086] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r204082. rdar://problem/27547583
- 10:15 AM Changeset in webkit [204085] by
-
- 4 edits in trunk
http/tests/fetch/fetch-in-worker-crash.html is sometimes crashing
https://bugs.webkit.org/show_bug.cgi?id=160498
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-03
Reviewed by Chris Dumez.
Source/WebCore:
Covered by http/tests/fetch/fetch-in-worker-crash.html.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Taking a reference of the client wrapper to ensure it can be cleaned-up successfully.
LayoutTests:
- http/tests/fetch/fetch-in-worker.js:
(onmessage): Reducing flakiness risk by making fetch http load being delayed.
- 10:12 AM Changeset in webkit [204084] by
-
- 6 edits2 adds in trunk
Lacking support on a arm-traditional disassembler.
https://bugs.webkit.org/show_bug.cgi?id=123717
Reviewed by Mark Lam.
.:
- Source/cmake/FindLLVM.cmake: Added back the r196749 state.
- Source/cmake/OptionsCommon.cmake: Added back the r196749 state.
Source/JavaScriptCore:
- CMakeLists.txt:
- disassembler/ARMLLVMDisassembler.cpp: Added, based on pre r196729 LLVMDisassembler, but it is ARM traditional only now.
(JSC::tryToDisassemble):
Source/WTF:
- wtf/Platform.h:
- 9:53 AM Changeset in webkit [204083] by
-
- 4 edits40 copies11 adds in trunk/Source/WebCore
Freeze the last of the Objective-C bindings
https://bugs.webkit.org/show_bug.cgi?id=160482
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMAttr.h: Added.
- bindings/objc/DOMAttr.mm: Added.
- bindings/objc/DOMAttrInternal.h: Added.
- bindings/objc/DOMCDATASection.h: Added.
- bindings/objc/DOMCDATASection.mm: Added.
- bindings/objc/DOMCDATASectionInternal.h: Added.
- bindings/objc/DOMCharacterData.h
- bindings/objc/DOMCharacterData.mm: Added.
- bindings/objc/DOMCharacterDataInternal.h: Added.
- bindings/objc/DOMComment.h: Added.
- bindings/objc/DOMComment.mm: Added.
- bindings/objc/DOMCommentInternal.h: Added.
- bindings/objc/DOMDOMImplementation.h: Added.
- bindings/objc/DOMDOMImplementation.mm: Added.
- bindings/objc/DOMDOMImplementationInternal.h: Added.
- bindings/objc/DOMDocument.h: Added.
- bindings/objc/DOMDocument.mm: Added.
- bindings/objc/DOMDocumentFragment.h: Added.
- bindings/objc/DOMDocumentFragment.mm: Added.
- bindings/objc/DOMDocumentFragmentInternal.h: Added.
- bindings/objc/DOMDocumentFragmentPrivate.h: Added.
- bindings/objc/DOMDocumentInternal.h: Added.
- bindings/objc/DOMDocumentPrivate.h: Added.
- bindings/objc/DOMDocumentType.h: Added.
- bindings/objc/DOMDocumentType.mm: Added.
- bindings/objc/DOMDocumentTypeInternal.h: Added.
- bindings/objc/DOMElement.h: Added.
- bindings/objc/DOMElement.mm: Added.
- bindings/objc/DOMElementInternal.h: Added.
- bindings/objc/DOMEntity.h: Added.
- bindings/objc/DOMEntity.mm: Added.
- bindings/objc/DOMEntityInternal.h: Added.
- bindings/objc/DOMEntityReference.h: Added.
- bindings/objc/DOMEntityReference.mm: Added.
- bindings/objc/DOMEntityReferenceInternal.h: Added.
- bindings/objc/DOMNamedNodeMap.h: Added.
- bindings/objc/DOMNamedNodeMap.mm: Added.
- bindings/objc/DOMNamedNodeMapInternal.h: Added.
- bindings/objc/DOMNode.h: Added.
- bindings/objc/DOMNode.mm: Added.
- bindings/objc/DOMNodeInternal.h: Added.
- bindings/objc/DOMNodeList.h: Added.
- bindings/objc/DOMNodeList.mm: Added.
- bindings/objc/DOMNodeListInternal.h: Added.
- bindings/objc/DOMNodePrivate.h: Added.
- bindings/objc/DOMProcessingInstruction.h: Added.
- bindings/objc/DOMProcessingInstruction.mm: Added.
- bindings/objc/DOMProcessingInstructionInternal.h: Added.
- bindings/objc/DOMText.h: Added.
- bindings/objc/DOMText.mm: Added.
- bindings/objc/DOMTextEvent.mm:
- bindings/objc/DOMTextEventInternal.h:
- bindings/objc/DOMTextInternal.h: Added.
- 9:33 AM Changeset in webkit [204082] by
-
- 2 edits in trunk/Source/WebCore
[Mac][iOS] Adopt MediaRemote "seek to playback position"
https://bugs.webkit.org/show_bug.cgi?id=160405
<rdar://problem/27547583>
Reviewed by Dean Jackson.
- platform/ios/RemoteCommandListenerIOS.mm:
(WebCore::RemoteCommandListenerIOS::RemoteCommandListenerIOS): Fix a typo.
- 9:12 AM Changeset in webkit [204081] by
-
- 1 edit2 moves in trunk/LayoutTests
Unreviewed, move LayoutTest out of platform/ios-simulator/ios.
- fast/events/touch/ios/Touch-attributes-prototype-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/touch/Touch-attributes-prototype-expected.txt.
- fast/events/touch/ios/Touch-attributes-prototype.html: Renamed from LayoutTests/platform/ios-simulator/ios/touch/Touch-attributes-prototype.html.
- 7:35 AM Changeset in webkit [204080] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Document how to initialize WebKitFaviconDatabase
https://bugs.webkit.org/show_bug.cgi?id=160391
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
- 3:41 AM Changeset in webkit [204079] by
-
- 61 edits2 copies22 adds4 deletes in trunk/LayoutTests/imported/w3c
Refresh wpt tests up to d686014
https://bugs.webkit.org/show_bug.cgi?id=160446
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-03
Reviewed by Alex Christensen.
- resources/ImportExpectations:
- resources/TestRepositories:
- resources/web-platform-tests-modules.json:
- web-platform-tests/XMLHttpRequest/FormData-append.html:
- web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.any.js: Added.
(test):
(string_appeared_here.test):
(string_appeared_here.async_test):
- web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.html: Removed.
- web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.js: Removed.
- web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.worker.js: Removed.
- web-platform-tests/XMLHttpRequest/headers-normalize-response-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/headers-normalize-response.htm: Added.
- web-platform-tests/XMLHttpRequest/open-url-multi-window.htm:
- web-platform-tests/XMLHttpRequest/resources/last-modified.py:
(main):
- web-platform-tests/XMLHttpRequest/resources/parse-headers.py: Added.
(main):
- web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
- web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
- web-platform-tests/XMLHttpRequest/responsexml-document-properties.htm:
- web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-empty.htm:
- web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async.htm:
- web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-get-head.htm:
- web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-none.htm:
- web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm:
- web-platform-tests/XMLHttpRequest/w3c-import.log:
- web-platform-tests/dom/events/AddEventListenerOptions-once-expected.txt: Added.
- web-platform-tests/dom/events/AddEventListenerOptions-once.html: Added.
- web-platform-tests/dom/events/w3c-import.log:
- web-platform-tests/dom/lists/DOMTokenList-iteration-expected.txt: Added.
- web-platform-tests/dom/lists/DOMTokenList-iteration.html: Added.
- web-platform-tests/dom/lists/w3c-import.log:
- web-platform-tests/dom/nodes/Node-childNodes-expected.txt:
- web-platform-tests/dom/nodes/Node-childNodes.html:
- web-platform-tests/domparsing/insert_adjacent_html-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers.js:
- web-platform-tests/fetch/api/basic/request-referrer-expected.txt: Added.
- web-platform-tests/fetch/api/basic/request-referrer.html: Added.
- web-platform-tests/fetch/api/basic/request-referrer.js: Added.
(testReferrer):
- web-platform-tests/fetch/api/basic/w3c-import.log:
- web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-no-referrer-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-no-referrer-worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-no-referrer.html.headers:
- web-platform-tests/fetch/api/policies/referrer-no-referrer.js.headers:
- web-platform-tests/fetch/api/policies/referrer-origin-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-expected.txt.
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-worker-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-expected.txt.
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-worker.html: Added.
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.html: Added.
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.html.headers: Added.
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.js: Added.
(promise_test):
- web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.js.headers: Added.
- web-platform-tests/fetch/api/policies/referrer-origin-worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-origin.html.headers:
- web-platform-tests/fetch/api/policies/referrer-origin.js.headers:
- web-platform-tests/fetch/api/policies/referrer-unsafe-url-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-unsafe-url-worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-unsafe-url.html.headers:
- web-platform-tests/fetch/api/policies/referrer-unsafe-url.js.headers:
- web-platform-tests/fetch/api/policies/w3c-import.log:
- web-platform-tests/fetch/api/request/request-cache-expected.txt:
- web-platform-tests/fetch/api/request/resources/get-host-info.sub.js: Removed.
- web-platform-tests/fetch/nosniff/resources/image.py:
(main):
- web-platform-tests/fetch/nosniff/stylesheet-expected.txt:
- web-platform-tests/fetch/nosniff/stylesheet.html:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-expected.txt:
- web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li.html:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open-expected.txt: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open.html: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-03-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-03.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods-expected.txt:
- web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods.html:
- web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt: Added.
- web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html: Added.
- web-platform-tests/html/semantics/tabular-data/the-table-element/w3c-import.log:
- web-platform-tests/lint.whitelist:
- web-platform-tests/service-workers/tools/blink-import.py:
(main):
- 12:50 AM Changeset in webkit [204078] by
-
- 13 edits2 adds in trunk
Implement nested rest destructuring w.r.t the ES7 spec
https://bugs.webkit.org/show_bug.cgi?id=160423
Reviewed by Filip Pizlo.
JSTests:
- stress/destructuring-rest-element.js: Added.
(assert):
(test):
(arr):
(eq):
(gen):
(fakeGen.return.Symbol.iterator):
(fakeGen):
- stress/rest-elements.js:
(testSyntaxError.String.raw):
- stress/rest-parameter-is-destructuring.js: Added.
(assert):
(test):
(foo):
(bar):
- test262.yaml:
Source/JavaScriptCore:
The spec has updated the BindingRestElement grammar production to be:
BindingRestElement:
BindingIdentifier
BindingingPattern.
It used to only allow BindingIdentifier in the grammar production.
I've updated our engine to account for this. The semantics are exactly
what you'd expect. For example:
let [a, ...[b, ...c]] = expr();
means that we create an array for the first rest element...[b, ...c]
and then perform the binding of[b, ...c]to that array. And so on,
applied recursively through the pattern.
- bytecompiler/NodesCodegen.cpp:
(JSC::RestParameterNode::collectBoundIdentifiers):
(JSC::RestParameterNode::toString):
(JSC::RestParameterNode::bindValue):
(JSC::RestParameterNode::emit):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createBindingLocation):
(JSC::ASTBuilder::createRestParameter):
(JSC::ASTBuilder::createAssignmentElement):
- parser/NodeConstructors.h:
(JSC::AssignmentElementNode::AssignmentElementNode):
(JSC::RestParameterNode::RestParameterNode):
(JSC::DestructuringAssignmentNode::DestructuringAssignmentNode):
- parser/Nodes.h:
(JSC::RestParameterNode::name): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseFormalParameters):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 12:38 AM Changeset in webkit [204077] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix Windows build after r204065
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::observeTransitions):
AbstractValue is bigger on Windows for an unknown reason.
- 12:07 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 12:06 AM Changeset in webkit [204076] by
-
- 2 edits in trunk/LayoutTests
Activate directory index generation for Apache test server
https://bugs.webkit.org/show_bug.cgi?id=160451
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-03
Reviewed by Alexey Proskuryakov.
- http/conf/apache2.4-httpd.conf:
- 12:00 AM Changeset in webkit [204075] by
-
- 10 edits in trunk/Source/WebCore
Move determination of operator direction into DOM class and reduce relayout
https://bugs.webkit.org/show_bug.cgi?id=160339
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.
We move the determination of operator direction into MathMLOperatorElement. We also simplify
a bit RenderMathMLFencedOperator so that the update of operator properties are done
immediately in updateOperatorContent and the resolution of to LayoutUnit is implemented
in leadingSpace, trailingSpace, minSize and maxSize. After that, setOperatorProperties is no
longer necessary and we can remove many calls that used to update operator properties and
force relayout.
No new tests, already covered by existing tests.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::childrenChanged): No need to call updateOperatorProperties.
- mathml/MathMLOperatorElement.cpp: Change names from "text" to "char".
(WebCore::MathMLOperatorElement::parseOperatorChar): Parse character and isVertical in this function.
(WebCore::MathMLOperatorElement::operatorChar):
(WebCore::MathMLOperatorElement::childrenChanged):
(WebCore::MathMLOperatorElement::computeDictionaryProperty): Call operatorChar().character.
(WebCore::MathMLOperatorElement::parseOperatorText): Deleted.
(WebCore::MathMLOperatorElement::operatorText): Deleted.
- mathml/MathMLOperatorElement.h: Use a new structure to hold both the character and direction
and change names from "text" to "char".
- rendering/mathml/RenderMathMLFencedOperator.cpp:
(WebCore::RenderMathMLFencedOperator::updateOperatorContent): Update both the character and
direction using MathMLOperatorElement::parseOperatorChar. Then set the boolean properties
and leading/trailing space using the operator dictionary. minsize and maxsize are constant
so we do not need to set them any more.
(WebCore::RenderMathMLFencedOperator::leadingSpace): Resolve the spacing read from the
dictionary to LayoutUnit. Note that it can never be negative.
(WebCore::RenderMathMLFencedOperator::trailingSpace): Ditto.
(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator): Deleted.
(WebCore::RenderMathMLFencedOperator::setOperatorProperties): Deleted.
- rendering/mathml/RenderMathMLFencedOperator.h: We use the new OperatorChar structure for
accessors and members. We make minSize and maxSize just return the default values and delete
the corresponding members. Finally, leading and trailing space are now stored as unsigned
short in MathUnit.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::textContent): Use the new OperatorChar structure.
(WebCore::RenderMathMLOperator::isVertical): Helper function forwarding to MathMLOperatorElement.
(WebCore::RenderMathMLOperator::stretchTo): Use isVertical() and remove setOperatorProperties().
(WebCore::RenderMathMLOperator::resetStretchSize): Ditto.
(WebCore::RenderMathMLOperator::updateMathOperator): Rename rebuildTokenContent as this is
now really only used to update MathOperator and hence replace the condition on
useMathOperator() with an ASSERT.
(WebCore::RenderMathMLOperator::updateTokenContent): Call updateMathOperator instead of
rebuildTokenContent.
(WebCore::RenderMathMLOperator::verticalStretchedOperatorShift): We use isVertical().
(WebCore::RenderMathMLOperator::paint): Ditto.
(WebCore::RenderMathMLOperator::setOperatorProperties): Deleted. This is no longer needed.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Deleted.
(WebCore::RenderMathMLOperator::rebuildTokenContent): Deleted. Renamed updateMathOperator.
(WebCore::RenderMathMLOperator::styleDidChange): No need to call updateOperatorProperties.
(WebCore::RenderMathMLOperator::updateOperatorProperties): Ditto..
- rendering/mathml/RenderMathMLOperator.h: Update some declaration and remove m_isVertical.
(WebCore::RenderMathMLOperator::isVertical): Deleted.
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::updateOperatorProperties): Deleted. This is no longer needed.
- rendering/mathml/RenderMathMLRow.h: Ditto.
Aug 2, 2016:
- 11:35 PM Changeset in webkit [204074] by
-
- 4 edits2 adds in trunk
Update breaking rules to match ICU 57
https://bugs.webkit.org/show_bug.cgi?id=160488
<rdar://problem/25856238>
Reviewed by Darin Adler.
Source/WTF:
This patch fixes a typo in the uax14AssignmentsAfter rules which
was causing flag emoji to have line breaking opportunities in their
middles. It also fixes significant language issues for languages
such as Hebrew, and adds correct breaking opportunities around
hyphens.
- wtf/text/TextBreakIterator.cpp:
(WTF::cursorMovementIterator):
(WTF::uax14AssignmentsAfter):
(WTF::uax14Forward):
(WTF::uax14Reverse):
LayoutTests:
- fast/text/flag-emoji-line-break-expected.html: Added.
- fast/text/flag-emoji-line-break.html: Added.
- platform/mac/TestExpectations: Mark the test as failing on Yosemite.
- 11:16 PM Changeset in webkit [204073] by
-
- 8 edits2 adds in branches/safari-602-branch
Merge r204050. rdar://problem/27313234
- 11:16 PM Changeset in webkit [204072] by
-
- 8 edits2 moves in branches/safari-602-branch
Merge r204062. rdar://problem/27592936
- 11:16 PM Changeset in webkit [204071] by
-
- 9 edits2 adds in branches/safari-602-branch
Merge r203955. rdar://problem/27629346
- 11:15 PM Changeset in webkit [204070] by
-
- 3 edits in branches/safari-602-branch/Source/WebKit2
Merge r204057. rdar://problem/27534205
- 11:15 PM Changeset in webkit [204069] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203984. rdar://problem/27409854
- 11:15 PM Changeset in webkit [204068] by
-
- 19 edits2 adds in branches/safari-602-branch
Merge r203982. rdar://problem/27547583
- 10:38 PM Changeset in webkit [204067] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 10:33 PM Changeset in webkit [204066] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix 32bits jsc after r204065
Default constructed JSValue() are not equal to zero in 32bits.
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::AbstractValue):
- 8:45 PM Changeset in webkit [204065] by
-
- 7 edits in trunk/Source
[JSC] Simplify the initialization of AbstractValue in the AbstractInterpreter
https://bugs.webkit.org/show_bug.cgi?id=160370
Reviewed by Saam Barati.
Source/JavaScriptCore:
We use a ton of AbstractValue to run the Abstract Interpreter.
When we set up the initial values, the compiler sets
a zero on a first word, a one on a second word, and a zero
again on a third word.
Since no vector or double-store can deal with 3 words, unrolling
is done by repeating those instructions.
The reason for the one was TinyPtrSet. It needed a flag for
empty value to identify the set as thin. I flipped the flag to "fat"
to make sure TinyPtrSet is initialized to zero.
With that done, I just had to clean some places to make
the initialization shorter.
It makes the binary easier to follow but this does not help with
the bigger problem: the time spent per block on Abstract Interpreter.
- bytecode/Operands.h:
The traits were useless, no client code defines it.
(JSC::Operands::Operands):
(JSC::Operands::ensureLocals):
Because of the size of the function, llvm is not inlining it.
We were literally loading 3 registers from memory and storing
them in the vector.
Now that AbstractValue has a VectorTraits, we should just rely
on the memset of Vector when possible.
(JSC::Operands::getLocal):
(JSC::Operands::setArgumentFirstTime):
(JSC::Operands::setLocalFirstTime):
(JSC::Operands::clear):
(JSC::OperandValueTraits::defaultValue): Deleted.
(JSC::OperandValueTraits::isEmptyForDump): Deleted.
- bytecode/OperandsInlines.h:
(JSC::Operands<T>::dumpInContext):
(JSC::Operands<T>::dump):
(JSC::Traits>::dumpInContext): Deleted.
(JSC::Traits>::dump): Deleted.
- dfg/DFGAbstractValue.cpp:
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::AbstractValue):
Source/WTF:
- wtf/TinyPtrSet.h:
(WTF::TinyPtrSet::isThin):
(WTF::TinyPtrSet::set):
- 7:56 PM Changeset in webkit [204064] by
-
- 3 edits in trunk/Source/WebCore
Drop custom bindings code for HTMLSelectElement.remove()
https://bugs.webkit.org/show_bug.cgi?id=160477
Reviewed by Darin Adler.
Drop custom bindings code for HTMLSelectElement.remove() and use
overloading instead.
- bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove): Deleted.
- html/HTMLSelectElement.idl:
- 7:56 PM Changeset in webkit [204063] by
-
- 10 edits in trunk
Drop custom bindings code for HTMLOptionsCollection.remove()
https://bugs.webkit.org/show_bug.cgi?id=160475
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Drop custom bindings code for HTMLOptionsCollection.remove() and use
overloading instead. The overload that take an HTMLOptionElement is
WebKit-specific and should probably be dropped at some point:
This patch also fixes several bugs:
- The parameter is now mandatory. This is consistent with the specification, Firefox and Chrome.
- HTMLOptionsCollection.prototype.remove.length is now 1 instead of 0.
No new tests, rebaselined existing tests.
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove): Deleted.
- html/HTMLOptionsCollection.idl:
LayoutTests:
Update existing tests to reflect behavior change.
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- js/dom/select-options-remove-expected.txt:
- js/resources/select-options-remove.js:
- 7:38 PM Changeset in webkit [204062] by
-
- 8 edits2 moves in trunk
AX: Simulated touch events are not working on iOS
https://bugs.webkit.org/show_bug.cgi?id=160395
<rdar://problem/27633597>
Reviewed by Chris Fleizach.
Source/WebCore:
We should mark the simulated touch as a potential tap otherwise it won't
be handled on iOS. Also, we need to dispatch both touch start and touch end
to mimic the real touch events. Last, added a has event listeners check,
because iOS is dispatching mouse click events for elements without touch event
listeners.
Test: accessibility/ios-simulator/press-fires-touch-events.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::dispatchTouchEvent):
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::dispatchSimulatedTouchEvent):
- platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
Tools:
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
LayoutTests:
- accessibility/ios-simulator/press-fires-touch-events-expected.txt: Added.
- accessibility/ios-simulator/press-fires-touch-events.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/ios/accessibility/press-fires-touch-events-expected.txt: Removed.
- platform/ios-simulator/ios/accessibility/press-fires-touch-events.html: Removed.
- 7:20 PM Changeset in webkit [204061] by
-
- 9 edits in trunk/Source
Clean up some useless AtomicString atoms
https://bugs.webkit.org/show_bug.cgi?id=160471
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-02
Reviewed by Geoffrey Garen.
Source/WebCore:
The only uses of "commentAtom" and "textAtom" where for their
respective overload of Node::nodeName().
Those methods return a string, we should not keep them in the atomic
string table just to hold a small String alive. They were also the only
two nodes to behave that way.
The atom xlinkAtom was only used by createForeignAttributesMap(), which
is itself only invoked once. There is no need for the symbol xlinkAtom.
- dom/CDATASection.cpp:
(WebCore::CDATASection::nodeName):
- dom/Comment.cpp:
(WebCore::Comment::nodeName):
- dom/Document.cpp:
(WebCore::Document::nodeName):
- dom/Text.cpp:
(WebCore::Text::nodeName):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::createForeignAttributesMap):
Source/WTF:
- wtf/text/AtomicString.h:
- wtf/text/StringStatics.cpp:
(WTF::AtomicString::init): Deleted.
- 6:57 PM Changeset in webkit [204060] by
-
- 2 edits in trunk/Tools
run-javascriptcore-tests should accept multiple --extra-tests
https://bugs.webkit.org/show_bug.cgi?id=160486
Reviewed by Saam Barati.
We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
test suites. This does it by using GetOpt::Long's array support.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- 6:46 PM Changeset in webkit [204059] by
-
- 1 add1 delete in trunk/JSTests
Rename Changelog to ChangeLog
Rubber stamped by Keith Miller.
- Changelog: Removed.
- 6:28 PM Changeset in webkit [204058] by
-
- 15 edits1 add in trunk
update a class extending null w.r.t the ES7 spec
https://bugs.webkit.org/show_bug.cgi?id=160417
Reviewed by Keith Miller.
Source/JavaScriptCore:
When a class extends null, it should not be marked as a derived class.
This was changed in the ES2016 spec, and this patch makes the needed
changes in JSC to follow the spec. This allows classes to extend
null and have their default constructor invoked without throwing an exception.
This also prevents |this| from being under TDZ at the start of the constructor.
Because ES6 allows arbitrary expressions in theclass <ident> extends <expr>
syntax, we don't know statically if a constructor is extending null or not.
Therefore, we don't always know statically if it's a base or derived constructor.
I solved this by putting a boolean on the constructor function under a private
symbol named isDerivedConstructor when doing class construction. We only need
to put this boolean on constructors that may extend null. Constructors that are
declared in a class with no extends syntax can tell statically that they are a base constructor.
I've also renamed the ConstructorKind::Derived enum value to be
ConstructorKind::Extends to better indicate that we can't answer
the "am I a derived constructor?" question statically.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createDefaultConstructor):
- builtins/BuiltinNames.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitLoadArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::ensureThis):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- bytecompiler/NodesCodegen.cpp:
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/ParserModes.h:
LayoutTests:
- js/class-syntax-extends-expected.txt:
- js/class-syntax-super-expected.txt:
- js/script-tests/class-syntax-extends.js:
- js/script-tests/class-syntax-super.js:
- 6:22 PM Changeset in webkit [204057] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r203385): Frequent RELEASE_ASSERT in WebKit::RemoteLayerTreeDrawingArea::flushLayers()
https://bugs.webkit.org/show_bug.cgi?id=160481
<rdar://problem/27534205>
Reviewed by Simon Fraser.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
If the UI process sends a didUpdate message while the Web process is in
the middle of flushing on a background thread, the drawing area will
allow another commit to start on the main thread, which then (rightfully)
causes the RELEASE_ASSERT.
This is normally not a problem, because didRefreshDisplay (which sends the didUpdate)
bails if m_didUpdateMessageState is anything other than NotSent, and m_didUpdateMessageState
is only NotSent if the Web process has sent a commit (and thus will not commit again until
it gets a didUpdate). This is the fundamental mechanism that avoids multiple commits being
in flight at once.
In r203385, I added a path where didRefreshDisplay could be called
before the first commit arrived (by way of
_applicationWillEnterForeground -> viewStateDidChange -> waitForDidUpdateViewState).
This caused trouble because m_didUpdateMessageState is initialized to NotSent,
which means that we could end up sending a didUpdate immediately, before the first
commit arrives - even worse, while the first commit is being flushed on a background thread,
leading the aforementioned RELEASE_ASSERT to fire.
Instead, initialize it to Sent (which I've renamed to DoesNotNeedDidUpdate), so that
we won't send a didUpdate until after the first commit arrives (at which point
the two processes are in agreement about the order of things).
It's not currently possible to API test this for multiple reasons, though it is fairly
easy to write a test app that reproduces reliably (by simulating suspend/resume notifications
inside the didFinishNavigation: callback).
- 6:14 PM Changeset in webkit [204056] by
-
- 2 edits1 copy1 add in branches/safari-602-branch/LayoutTests
Merge r203992. rdar://problem/27611932
- 5:43 PM Changeset in webkit [204055] by
-
- 2 edits in trunk/LayoutTests
Skip media/track/track-remove-crash.html on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=160367
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:31 PM Changeset in webkit [204054] by
-
- 3 edits80 adds in trunk/Source/WebCore
Freeze the Objective-C DOM Event and CSS bindings
https://bugs.webkit.org/show_bug.cgi?id=160476
Reviewed by Tim Horton.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCSSCharsetRule.h: Added.
- bindings/objc/DOMCSSCharsetRule.mm: Added.
- bindings/objc/DOMCSSCharsetRuleInternal.h: Added.
- bindings/objc/DOMCSSFontFaceRule.h: Added.
- bindings/objc/DOMCSSFontFaceRule.mm: Added.
- bindings/objc/DOMCSSFontFaceRuleInternal.h: Added.
- bindings/objc/DOMCSSImportRule.h: Added.
- bindings/objc/DOMCSSImportRule.mm: Added.
- bindings/objc/DOMCSSImportRuleInternal.h: Added.
- bindings/objc/DOMCSSMediaRule.h: Added.
- bindings/objc/DOMCSSMediaRule.mm: Added.
- bindings/objc/DOMCSSMediaRuleInternal.h: Added.
- bindings/objc/DOMCSSPageRule.h: Added.
- bindings/objc/DOMCSSPageRule.mm: Added.
- bindings/objc/DOMCSSPageRuleInternal.h: Added.
- bindings/objc/DOMCSSPrimitiveValue.h: Added.
- bindings/objc/DOMCSSPrimitiveValue.mm: Added.
- bindings/objc/DOMCSSPrimitiveValueInternal.h: Added.
- bindings/objc/DOMCSSRule.h: Added.
- bindings/objc/DOMCSSRule.mm: Added.
- bindings/objc/DOMCSSRuleInternal.h: Added.
- bindings/objc/DOMCSSRuleList.h: Added.
- bindings/objc/DOMCSSRuleList.mm: Added.
- bindings/objc/DOMCSSRuleListInternal.h: Added.
- bindings/objc/DOMCSSStyleDeclaration.h: Added.
- bindings/objc/DOMCSSStyleDeclaration.mm: Added.
- bindings/objc/DOMCSSStyleDeclarationInternal.h: Added.
- bindings/objc/DOMCSSStyleRule.h: Added.
- bindings/objc/DOMCSSStyleRule.mm: Added.
- bindings/objc/DOMCSSStyleRuleInternal.h: Added.
- bindings/objc/DOMCSSStyleSheet.h: Added.
- bindings/objc/DOMCSSStyleSheet.mm: Added.
- bindings/objc/DOMCSSStyleSheetInternal.h: Added.
- bindings/objc/DOMCSSUnknownRule.h: Added.
- bindings/objc/DOMCSSUnknownRule.mm: Added.
- bindings/objc/DOMCSSUnknownRuleInternal.h: Added.
- bindings/objc/DOMCSSValue.h: Added.
- bindings/objc/DOMCSSValue.mm: Added.
- bindings/objc/DOMCSSValueInternal.h: Added.
- bindings/objc/DOMCSSValueList.h: Added.
- bindings/objc/DOMCSSValueList.mm: Added.
- bindings/objc/DOMCSSValueListInternal.h: Added.
- bindings/objc/DOMCounter.h: Added.
- bindings/objc/DOMCounter.mm: Added.
- bindings/objc/DOMCounterInternal.h: Added.
- bindings/objc/DOMEvent.h: Added.
- bindings/objc/DOMEvent.mm: Added.
- bindings/objc/DOMEventInternal.h: Added.
- bindings/objc/DOMEventListener.h: Added.
- bindings/objc/DOMEventTarget.h: Added.
- bindings/objc/DOMKeyboardEvent.h: Added.
- bindings/objc/DOMKeyboardEvent.mm: Added.
- bindings/objc/DOMKeyboardEventInternal.h: Added.
- bindings/objc/DOMMouseEvent.h: Added.
- bindings/objc/DOMMouseEvent.mm: Added.
- bindings/objc/DOMMouseEventInternal.h: Added.
- bindings/objc/DOMMutationEvent.h: Added.
- bindings/objc/DOMMutationEvent.mm: Added.
- bindings/objc/DOMMutationEventInternal.h: Added.
- bindings/objc/DOMOverflowEvent.h: Added.
- bindings/objc/DOMOverflowEvent.mm: Added.
- bindings/objc/DOMOverflowEventInternal.h: Added.
- bindings/objc/DOMProgressEvent.h: Added.
- bindings/objc/DOMProgressEvent.mm: Added.
- bindings/objc/DOMProgressEventInternal.h: Added.
- bindings/objc/DOMRGBColor.h: Added.
- bindings/objc/DOMRGBColor.mm: Added.
- bindings/objc/DOMRGBColorInternal.h: Added.
- bindings/objc/DOMRect.h: Added.
- bindings/objc/DOMRect.mm: Added.
- bindings/objc/DOMRectInternal.h: Added.
- bindings/objc/DOMTextEvent.h: Added.
- bindings/objc/DOMTextEvent.mm: Added.
(-[DOMTextEvent data]):
(-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
- bindings/objc/DOMTextEventInternal.h: Added.
- bindings/objc/DOMUIEvent.h: Added.
- bindings/objc/DOMUIEvent.mm: Added.
- bindings/objc/DOMUIEventInternal.h: Added.
- bindings/objc/DOMWheelEvent.h: Added.
- bindings/objc/DOMWheelEvent.mm: Added.
- bindings/objc/DOMWheelEventInternal.h: Added.
- 5:00 PM Changeset in webkit [204053] by
-
- 20 edits in trunk
Allow building with content filtering disabled.
https://bugs.webkit.org/show_bug.cgi?id=160454
Reviewed by Simon Fraser.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- platform/PlatformContentFilter.h:
(WebCore::PlatformContentFilter::unblockRequestDeniedScript):
- platform/cocoa/NetworkExtensionContentFilter.h:
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::unblockHandler):
- platform/cocoa/ParentalControlsContentFilter.h:
- testing/MockContentFilter.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::blockedByContentFilterError):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<KeypressCommand>::decode):
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode):
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode):
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(WebKit::blockedByContentFilterError):
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 4:43 PM Changeset in webkit [204052] by
-
- 15 edits in trunk
Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
https://bugs.webkit.org/show_bug.cgi?id=160474
<rdar://problem/27668170>
Reviewed by Simon Fraser.
The fixes are behaviour we want. They just caused a regression
on medium.com (reverted in http://trac.webkit.org/r203380).
Now that we've branched, revert the reversion (which itself
was a reversion), so we can fix the actual bug:
https://bugs.webkit.org/show_bug.cgi?id=160478
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::addPropertyWithPrefixingVariant):
(WebCore::CSSParser::parseTransitionShorthand):
- css/CSSPropertyNames.in:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::removeShorthandProperty):
(WebCore::StyleProperties::asText):
(WebCore::MutableStyleProperties::removeProperty): Deleted.
(WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted.
(WebCore::MutableStyleProperties::setProperty): Deleted.
(WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted.
(WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted.
(WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted.
- css/StyleProperties.h:
LayoutTests:
- animations/fill-mode-forwards-zero-duration.html:
- animations/play-state-start-paused.html:
- animations/script-tests/spring-parsing.js:
(testSpring):
- animations/spring-parsing-expected.txt:
- animations/unprefixed-properties-expected.txt:
- animations/unprefixed-properties.html:
- fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt:
- fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt:
- 4:29 PM Changeset in webkit [204051] by
-
- 1 copy in tags/Safari-602.1.46
New tag.
- 4:03 PM Changeset in webkit [204050] by
-
- 8 edits2 adds in trunk
Cleanup HTMLMediaElement track lists.
https://bugs.webkit.org/show_bug.cgi?id=160470
Reviewed by David Kilzer.
Source/WebCore:
Test: media/range-extract-contents-crash.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::willRemove): ASSERT if media element is NULL.
- html/track/TextTrackList.cpp:
(TextTrackList::clearElement): Clear track media element pointers and client.
- html/track/TextTrackList.h:
- html/track/TrackListBase.cpp:
(TrackListBase::~TrackListBase): Call clearElement.
(TrackListBase::clearElement): Clear track media element pointers and client.
- html/track/TrackListBase.h:
LayoutTests:
- media/range-extract-contents-crash-expected.txt: Added.
- media/range-extract-contents-crash.html: Added.
- 3:59 PM Changeset in webkit [204049] by
-
- 5 edits in trunk/Source/WebCore
Remove more Objective-C bindings that are not used
https://bugs.webkit.org/show_bug.cgi?id=160473
Reviewed by Sam Weinig.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCSS.mm:
(kitClass):
- dom/Document.idl:
- 3:55 PM Changeset in webkit [204048] by
-
- 10 edits in trunk
Drop custom bindings for FormData.append()
https://bugs.webkit.org/show_bug.cgi?id=160466
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
Source/WebCore:
Drop custom bindings for FormData.append(). We no longer need them now
that we have proper support for overloads after r204028.
This patch also fixes the fact that FormData.prototype.append.length
was 0 instead of 2.
No new tests, rebaselined existing test.
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::JSDOMFormData::append): Deleted.
- html/DOMFormData.cpp:
(WebCore::DOMFormData::append):
- html/DOMFormData.h:
- html/DOMFormData.idl:
- html/FileInputType.cpp:
(WebCore::FileInputType::appendFormData):
- html/FormDataList.cpp:
(WebCore::FormDataList::appendBlob):
- html/FormDataList.h:
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::appendBlob):
- 3:42 PM Changeset in webkit [204047] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r203799.
https://bugs.webkit.org/show_bug.cgi?id=160467
Decided on a different solution (Requested by jonlee_ on
#webkit).
Reverted changeset:
"Captions do not render in PiP window when element is hidden"
https://bugs.webkit.org/show_bug.cgi?id=160265
http://trac.webkit.org/changeset/203799
- 3:23 PM Changeset in webkit [204046] by
-
- 4 edits in trunk/Source/WebCore
Remove unused functions in URL
https://bugs.webkit.org/show_bug.cgi?id=160468
Reviewed by Geoffrey Garen.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::extractInnerURL):
- platform/URL.cpp:
(WebCore::mimeTypeFromURL):
(WebCore::URL::stringCenterEllipsizedToLength):
(WebCore::URL::isSafeToSendToAnotherThread): Deleted.
- platform/URL.h:
(WebCore::URL::operator NSString*):
(WebCore::URL::innerURL): Deleted.
- 3:23 PM Changeset in webkit [204045] by
-
- 14 edits in trunk
Named / Indexed properties should be configurable
https://bugs.webkit.org/show_bug.cgi?id=160457
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
- web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
Source/WebCore:
Report Named / Indexed properties as being configurable to comply with
the Web IDL specification:
- http://heycam.github.io/webidl/#getownproperty-guts (step 1. and 2.)
Firefox and Chrome also report them as being configurable.
No new tests, rebaselined existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
LayoutTests:
Update / rebaseline existing tests to reflect behavior change.
- fast/dom/NodeList/nodelist-name-getter-properties-expected.txt:
- fast/dom/NodeList/nodelist-name-getter-properties.html:
- js/dom/getOwnPropertyDescriptor-expected.txt:
- js/resources/getOwnPropertyDescriptor.js:
- 3:16 PM Changeset in webkit [204044] by
-
- 13 edits in trunk
Remove more unused/uninstalled Objective-C DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=160464
Reviewed by Darin Adler.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/objc/DOMEvents.h:
- bindings/objc/DOMEvents.mm:
(kitClass): Deleted.
- dom/Document.idl:
Source/WebKit/mac:
Stop installing unused headers.
- MigrateHeaders.make:
LayoutTests:
Update test results.
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- 2:44 PM Changeset in webkit [204043] by
-
- 9 edits in trunk
[WebIDL] Extend new overload resolution algorithm support to constructors
https://bugs.webkit.org/show_bug.cgi?id=160455
Reviewed by Ryosuke Niwa.
Source/WebCore:
Extend new overload resolution algorithm support (added in r204028) to
constructors as well. It was only used for operations. Remove code that
is now dead from the bindings generator.
We now share the same code of generating the overload resolution code
for operations and constructors.
No new tests, rebaselined existing tests.
- bindings/scripts/CodeGenerator.pm:
(LinkOverloadedFunctions):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadedFunctionOrConstructor):
(GenerateImplementation):
(GenerateConstructorDefinitions):
(GenerateConstructorDefinition):
(GetFunctionLength): Deleted.
(LengthOfLongestFunctionParameterList): Deleted.
(GetNativeTypeForConversions): Deleted.
(GetGnuVTableNameForInterface): Deleted.
(GetGnuMangledNameForInterface): Deleted.
(GetGnuVTableOffsetForType): Deleted.
(GenerateConstructorHelperMethods): Deleted.
- bindings/scripts/IDLParser.pm:
(applyExtendedAttributeList): Deleted.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsConstructor::construct):
- bindings/scripts/test/TestOverloadedConstructors.idl:
LayoutTests:
Update / rebaseline existing test as we now provide slightly different
exception messages when given bad overloaded constructor parameters.
- fast/canvas/canvas-imageData-expected.txt:
- fast/canvas/script-tests/canvas-imageData.js:
- 2:33 PM Changeset in webkit [204042] by
-
- 2 edits in branches/safari-602-branch/LayoutTests
Merge r203917. rdar://problem/27430381
- 2:28 PM Changeset in webkit [204041] by
-
- 5 edits in trunk
Removing IndexedDB WebsiteData can fail for some users.
https://bugs.webkit.org/show_bug.cgi?id=160463
Reviewed by Alex Christensen.
Source/WebCore:
Covered by changes to API test IndexedDB.StoreBlobThenDelete.
For a few months in trunk WebKit, deleting an IndexedDB using WebsiteDataStore API would only
delete the "IndexedDB.sqlite3" file, but would leave the "-wal" and "-shm" files behind.
We'd then fail to delete the directory itself, tricking API clients to think there are still
databases in the given origin.
Furthermore, the code to delete a database first checks for the existence of "IndexedDB.sqlite3"
then refuses to do any further cleanup if it doesn't exist.
We should just always run the entire delete procedure even if IndexedDB.sqlite does not exist.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::removeAllDatabasesForOriginPath):
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::deleteDatabaseFile):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
- 2:17 PM Changeset in webkit [204040] by
-
- 2 edits in trunk/Source/WebCore
Fix Mac CMake build.
- PlatformMac.cmake:
Some ObjC bindings have been frozen.
- 2:15 PM Changeset in webkit [204039] by
-
- 2 edits in trunk/LayoutTests
Marking two media tests as flaky crashes on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=160367
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 1:26 PM Changeset in webkit [204038] by
-
- 6 edits in trunk/Source/WebCore
More cleanup of MathML operator parsing
https://bugs.webkit.org/show_bug.cgi?id=160336
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.
No new tests, behavior is unchanged.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): Deleted. This function is no longer used.
- rendering/mathml/RenderMathMLBlock.h: Ditto.
- rendering/mathml/RenderMathMLFencedOperator.h: Move some length members from
RenderMathMLOperator and override the accessors. Also override useMathOperator() since it is
always true for anonymous mfenced operators.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::textContent): No need to ASSERT !isAnonymous since this
function is overriden by RenderMathMLFencedOperator.
(WebCore::RenderMathMLOperator::isInvisibleOperator): Use a temporary variable to call
textContent only once.
(WebCore::RenderMathMLOperator::leadingSpace): Helper function to determine the leading space.
(WebCore::RenderMathMLOperator::trailingSpace): Helper function to determine the trailing space.
(WebCore::RenderMathMLOperator::minSize): Helper function to determine the min space.
(WebCore::RenderMathMLOperator::maxSize): Helper function to determine the max space.
(WebCore::RenderMathMLOperator::setOperatorProperties): This is now only used to set m_isVertical.
(WebCore::RenderMathMLOperator::stretchTo): Call maxSize and minSize when necessary.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Call leadingSpace and trailingSpace.
(WebCore::RenderMathMLOperator::layoutBlock): Ditto.
(WebCore::RenderMathMLOperator::useMathOperator): Remove the case for anonymous operators as
this is now handled in the derived class.
(WebCore::RenderMathMLOperator::paint): Call leadingSpace.
- rendering/mathml/RenderMathMLOperator.h: Remove length members and declare helper functions
to get these lengths from MathMLOperatorElement.
(WebCore::RenderMathMLOperator::setLeadingSpace): Deleted. This is no longer used.
(WebCore::RenderMathMLOperator::setTrailingSpace): Deleted. This is no longer used.
- 12:53 PM Changeset in webkit [204037] by
-
- 9 edits in trunk
Move parsing of operator length attributes to MathMLOperatorElement
https://bugs.webkit.org/show_bug.cgi?id=160301
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.
Source/WebCore:
We move parsing of operator attributes lspace, rspace minsize, maxsize into the class
MathMLOperatorElement. We rely on the existing MathMLElement::Length structure and expand
it to handle the "infinity" case of maxsize that we always resolve as intMaxForLayoutUnit.
We also improve the resolution of a negative value for minsize and maxsize since the MathML
recommendation says it should be rounded up to the nearest valid value (which is zero)
instead of ignoring the attribute and using the default value. This is similar to r203285
for mfrac@linethickness. We also update the existing test for minsize/maxsize to take into
account that change.
No new tests, already covered by existing tests.
- mathml/MathMLElement.h: Add an "Infinity" type for MathML Length.
- mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::leadingSpace): Helper function to retrieve the cached value
for the lspace attribute, parse it if necessary.
(WebCore::MathMLOperatorElement::trailingSpace): Ditto for rspace.
(WebCore::MathMLOperatorElement::minSize): Ditto for minsize.
(WebCore::MathMLOperatorElement::maxSize): Ditto for maxsize. This attribute also accepts the
"infinity" value.
(WebCore::MathMLOperatorElement::parseAttribute): Mark attributes dirty.
- mathml/MathMLOperatorElement.h: Declare Length members and accessors.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::toUserUnits): Resolve Infinity as intMaxForLayoutUnit.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::setOperatorProperties): We use toUserUnits to resolve the
lengths. Negative maxsize and minsize values now fallback to 0 instead of their default
values. We also remove the !isAnonymous() check since setOperatorProperties is overriden
in the RenderMathMLFencedOperator class.
LayoutTests:
- mathml/presentation/stretchy-minsize-maxsize-expected.html: Update the test for negative
minsize and maxsize to align on the behavior suggested in the MathML recommendation.
- mathml/presentation/stretchy-minsize-maxsize.html: Ditto.
- 12:23 PM Changeset in webkit [204036] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build error fix.
- mathml/MathMLOperatorElement.cpp:
(WebCore::propertyFlagToAttributeName): Return a nullQName to avoid warnings on some platforms.
- 12:16 PM Changeset in webkit [204035] by
-
- 3 edits in trunk/Source/WebCore
Stop building Objective-C bindings that aren't exposed anywhere
https://bugs.webkit.org/show_bug.cgi?id=160458
Reviewed by Darin Adler.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- 12:13 PM Changeset in webkit [204034] by
-
- 5 edits in trunk
HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements
https://bugs.webkit.org/show_bug.cgi?id=160456
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
Rebaseline. We are still failing but on the next check.
- web-platform-tests/dom/nodes/Element-children-expected.txt:
Rebaseline now that one more check is passing.
Source/WebCore:
HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements:
Our slow path which relies on HTMLCollection::updateNamedElementCache() does the right
thing. However, we have a fast path in
CachedHTMLCollection<HTMLCollectionClass, traversalType>::namedItem() that was missing a
check.
Firefox and Chrome both behave correctly here.
No new tests, rebaselined existing tests.
- html/CachedHTMLCollection.h:
(WebCore::traversalType>::namedItem):
- 12:12 PM WebKitIDL edited by
- StrictTypeChecking no longer exists as of r204033 (diff)
- 12:11 PM Changeset in webkit [204033] by
-
- 6 edits in trunk/Source/WebCore
Kill [StrictTypeChecking] IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=160382
Reviewed by Darin Adler.
Kill [StrictTypeChecking] IDL extended attribute. Its only remaining
use was on DOMString parameters for a few CanvasRenderingContext2D
operations in order to work around a bug in our overload resolution.
However, as of r204028, we implement the Web IDL overload resolution
algorithm and [StrictTypeChecking] is now a no-op and is no longer
needed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestTypedefs.idl:
- html/canvas/CanvasRenderingContext2D.idl:
- 11:47 AM Changeset in webkit [204032] by
-
- 8 edits in trunk/Source/WebCore
Move parsing of boolean operator properties into MathMLOperatorElement
https://bugs.webkit.org/show_bug.cgi?id=160190
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.
No new tests, already covered by existing tests.
- mathml/MathMLOperatorDictionary.h: Add a bit mask with all the property flags set.
- mathml/MathMLOperatorElement.cpp:
(WebCore::attributeNameToPropertyFlag): helper function to map from attribute name to flag.
(WebCore::MathMLOperatorElement::computeOperatorFlag): Helper function to update one
bit of m_properties.flags from the corresponding boolean attribute. The default value is
taken from the operator dictionary data stored in m_dictionaryProperty.flags.
(WebCore::MathMLOperatorElement::hasProperty): Returns whether the operator has a property,
parsing it again if the corresponding attribute is dirty.
(WebCore::MathMLOperatorElement::childrenChanged): Make all properties dirty.
(WebCore::propertyFlagToAttributeName): helper function to map from flag to attribute name.
(WebCore::MathMLOperatorElement::parseAttribute): Make all properties dirty if the form
attribute changed. Make each property dirty when the corresponding attribute changed.
(WebCore::MathMLOperatorElement::flags): Deleted. Replaced with the finer hasProperty function.
- mathml/MathMLOperatorElement.h: Define new structure, member and functions to handle
operator properties.
- rendering/mathml/RenderMathMLFencedOperator.cpp:
(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator): Move m_operatorFlags from
the base class to the derived class.
- rendering/mathml/RenderMathMLFencedOperator.h: Ditto.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator): Ditto.
(WebCore::RenderMathMLOperator::hasOperatorFlag): Just call hasOperatorFlag from the
MathMLOperatorElement class.
(WebCore::RenderMathMLOperator::setOperatorProperties): We do not initialize m_operatorFlags
since it has been removed from the base class. We also do not parse attributes since this
has been moved to the MathMLOperatorElement class.
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute): Deleted.
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttributeValue): Deleted.
- rendering/mathml/RenderMathMLOperator.h: Move m_operatorFlags from the base class to the
derived class, remove some parsing helper functions and update hasOperatorFlag to make it
overridable.
- 10:42 AM Changeset in webkit [204031] by
-
- 4 edits28 adds in trunk/Source/WebCore
Freeze another bunch of Objective-C binding files
https://bugs.webkit.org/show_bug.cgi?id=160435
Reviewed by Alex Christensen.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMAbstractView.h: Added.
- bindings/objc/DOMAbstractView.mm:
- bindings/objc/DOMAbstractViewInternal.h: Added.
- bindings/objc/DOMMediaList.h: Added.
- bindings/objc/DOMMediaList.mm: Added.
- bindings/objc/DOMMediaListInternal.h: Added.
- bindings/objc/DOMNodeFilter.h: Added.
- bindings/objc/DOMNodeIterator.h: Added.
- bindings/objc/DOMNodeIterator.mm: Added.
- bindings/objc/DOMNodeIteratorInternal.h: Added.
- bindings/objc/DOMRange.h: Added.
- bindings/objc/DOMRange.mm: Added.
- bindings/objc/DOMRangeInternal.h: Added.
- bindings/objc/DOMStyleSheet.h: Added.
- bindings/objc/DOMStyleSheet.mm: Added.
- bindings/objc/DOMStyleSheetInternal.h: Added.
- bindings/objc/DOMStyleSheetList.h: Added.
- bindings/objc/DOMStyleSheetList.mm: Added.
- bindings/objc/DOMStyleSheetListInternal.h: Added.
- bindings/objc/DOMTreeWalker.h: Added.
- bindings/objc/DOMTreeWalker.mm: Added.
- bindings/objc/DOMTreeWalkerInternal.h: Added.
- bindings/objc/DOMXPathExpression.h: Added.
- bindings/objc/DOMXPathExpression.mm: Added.
- bindings/objc/DOMXPathExpressionInternal.h: Added.
- bindings/objc/DOMXPathNSResolver.h: Added.
- bindings/objc/DOMXPathResult.h: Added.
- bindings/objc/DOMXPathResult.mm: Added.
- bindings/objc/DOMXPathResultInternal.h: Added.
- 10:27 AM Changeset in webkit [204030] by
-
- 4 edits in trunk/Source/WebCore
[MathML] Use more auto for local variables
https://bugs.webkit.org/show_bug.cgi?id=160453
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.
No new tests, behavior is unchanged.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::colSpan):
(WebCore::MathMLElement::rowSpan):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::defaultEventHandler):
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
- 10:03 AM Changeset in webkit [204029] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix build after r204014.
Unreviewed build fix.
- loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willCacheResponse):
- 10:02 AM Changeset in webkit [204028] by
-
- 32 edits in trunk
[WebIDL] Implement overload resolution algorithm
https://bugs.webkit.org/show_bug.cgi?id=160394
Reviewed by Darin Adler.
Source/WebCore:
Implement overload resolution algorithm:
This means that our support for operation overloading in our IDL is
now a lot more extensive than it used to be and is now compliant with
the Web IDL specification.
In particular, overloading should now work for a lot more parameter
types which means that:
- We should be able to drop some custom bindings code in a follow-up patch.
- We will be able to drop the [StrictTypeChecking] attribute which was a hack used to make overloading work for parameters of type DOMString.
Also, the order of the overloads in the IDL no longer impacts the
generated bindings code. It used to be that you needed to put the
overloads with the more specific parameter types first in order for the
generated bindings code to be somewhat correct.
No new tests, rebaselined bindings tests.
- bindings/scripts/CodeGenerator.pm:
(IsStringOrEnumType):
- bindings/scripts/CodeGeneratorJS.pm:
(IsNullableType):
(StripNullable):
(ComputeEffectiveOverloadSet):
(AreTypesDistinguishableForOverloadResolution):
(GetDistinguishingArgumentIndex):
(GetOverloadThatMatches):
(GenerateOverloadedFunction):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction2Promise): Deleted.
- bindings/scripts/test/TestObj.idl:
- dom/EventTarget.h:
- dom/EventTarget.idl:
- html/HTMLOptionsCollection.h:
- html/HTMLOptionsCollection.idl:
- html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::add):
- html/HTMLSelectElement.idl:
LayoutTests:
Update / Rebaseline existing test. There is no major behavior change.
We sometimes get a different exception message than we used to.
- fast/canvas/canvas-clip-path-expected.txt:
- fast/canvas/canvas-fill-path-expected.txt:
- fast/canvas/canvas-path-addPath-expected.txt:
- fast/canvas/canvas-path-isPointInPath-expected.txt:
- fast/canvas/canvas-path-isPointInStroke-expected.txt:
- fast/canvas/canvas-putImageData-expected.txt:
- fast/canvas/canvas-putImageData.js:
- fast/canvas/canvas-stroke-path-expected.txt:
- fast/canvas/webgl/script-tests/texImageTest.js:
- fast/canvas/webgl/texImageTest-expected.txt:
- fast/dom/HTMLSelectElement/add-expected.txt:
- fast/dom/HTMLSelectElement/add.html:
- fast/dom/HTMLSelectElement/options-collection-add-expected.txt:
- fast/dom/HTMLSelectElement/options-collection-add.html:
- fast/dom/incompatible-operations-expected.txt:
- js/dom/select-options-add-expected.txt:
- webaudio/audiobuffer-expected.txt:
- webaudio/audiobuffer.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/textures/tex-image-with-invalid-data.html:
- 9:57 AM Changeset in webkit [204027] by
-
- 2 edits in trunk/Source/WebCore
[macOS] Guard workaround in r203314 for only OSes which need it
https://bugs.webkit.org/show_bug.cgi?id=160440
Reviewed by Simon Fraser.
The workarond introduced in r203314 only needs to be applied on
certain OSes.
No new tests because there is no behavior change.
- platform/text/mac/TextBoundaries.mm:
(WebCore::findNextWordFromIndex):
- 8:46 AM Changeset in webkit [204026] by
-
- 4 edits in trunk/Source/WebCore
Remove CachedResourceRequest initiatingDocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=160449
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
Reviewed by Alex Christensen.
No change of behavior.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Removing call to setInitiator.
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setInitiator): Deleted.
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::initiatingDocumentLoader): Deleted.
- 8:37 AM Changeset in webkit [204025] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM] Disable Inline Caching on ARMv7 traditional until proper fix
https://bugs.webkit.org/show_bug.cgi?id=159759
Reviewed by Saam Barati.
- jit/JITMathIC.h:
(JSC::JITMathIC::generateInline):
- 8:15 AM EnvironmentVariables edited by
- (diff)
- 6:22 AM Changeset in webkit [204024] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
Update test expectations on Windows for many failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.
- platform/win/TestExpectations:
- 5:45 AM Changeset in webkit [204023] by
-
- 4 edits in trunk/LayoutTests
Skip fetch API worker tests in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=160448
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt: Rebasing
LayoutTests:
- 4:28 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 4:27 AM Changeset in webkit [204022] by
-
- 10 edits in trunk/Source/WebCore
Move parsing of the form attribute to MathMLOperatorElement
https://bugs.webkit.org/show_bug.cgi?id=160239
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-28
Reviewed by Darin Adler.
We move the parsing of the mo@form attribute to the MathMLOperatorElement class. Note that
when the attribute is not explicit, the form may also be guessed by searching into the
operator dictionary. Hence we also start moving the determination of the default dictionary
properties. Moving the actual parsing of the corresponding attributes will be done in
follow-up commits.
No new tests, already covered by existing tests.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::childrenChanged): Make the form of operators dirty
if its siblings have changed.
- mathml/MathMLOperatorDictionary.cpp:
(WebCore::MathMLOperatorDictionary::search): Merge old getEntry functions into one helper
function that returns an Optional<Entry>.
(WebCore::MathMLOperatorDictionary::getEntry): Deleted
- mathml/MathMLOperatorDictionary.h: Declare MathMLOperatorDictionary::find.
- mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::dictionaryProperty): We determine the operator form by
parsing the corresponding attribute or by using heuristics if that attribute is not
specified. We also read dictionary the corresponding dictionary properties.
(WebCore::MathMLOperatorElement::flags): Return the flags read from the dictionary.
(WebCore::MathMLOperatorElement::defaultLeadingSpace): Return the space read from the dictionary.
(WebCore::MathMLOperatorElement::defaultTrailingSpace): Return the space read from the dictionary.
(WebCore::MathMLOperatorElement::childrenChanged): Make the dictionary properties dirty.
(WebCore::MathMLOperatorElement::parseAttribute): Make the dictionary properties dirty when
the form changes.
- mathml/MathMLOperatorElement.h: New member to store dictionary properties and expose them.
- rendering/mathml/RenderMathMLFencedOperator.cpp:
(WebCore::RenderMathMLFencedOperator::setOperatorProperties): We implement the case specific
to anonymous mfenced operators here.
- rendering/mathml/RenderMathMLFencedOperator.h: Move the m_operatorForm member here and
declare the overriden function setOperatorProperties.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::setOperatorProperties): Simplify this code since the logic
has been moved to the element classes.
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry): Deleted.
- rendering/mathml/RenderMathMLOperator.h: Remove setOperatorPropertiesFromOpDictEntry, make
members accessible to RenderMathMLFencedOperator and remove m_operatorForm.
- 2:43 AM Changeset in webkit [204021] by
-
- 17 edits in trunk/Source/WebCore
Use Optional members to store parsed MathML attributes.
https://bugs.webkit.org/show_bug.cgi?id=160400
Patch by Frederic Wang <fwang.igalia.com> on 2016-08-02
Reviewed by Darin Adler.
Parsed MathML attributes are stored on the element classes using the memoize pattern to
minimize the number of parsing updates. Currently, a dirty flag for each member
indicate when it must be parsed again. We change this to wrap these members into an
Optional<T> container instead, where a null value indicates that the member is dirty.
No new tests, behavior is unchanged.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::cachedMathMLLength):
(WebCore::MathMLElement::cachedBooleanAttribute):
(WebCore::MathMLElement::parseMathVariantAttribute):
(WebCore::MathMLElement::specifiedDisplayStyle):
(WebCore::MathMLElement::specifiedMathVariant):
- mathml/MathMLElement.h:
- mathml/MathMLFractionElement.cpp:
(WebCore::MathMLFractionElement::lineThickness):
(WebCore::MathMLFractionElement::cachedFractionAlignment):
(WebCore::MathMLFractionElement::parseAttribute):
- mathml/MathMLFractionElement.h:
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::parseAttribute):
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::specifiedDisplayStyle):
(WebCore::MathMLMathElement::parseAttribute):
- mathml/MathMLOperatorElement.cpp:
(WebCore::MathMLOperatorElement::operatorText):
- mathml/MathMLPaddedElement.cpp:
(WebCore::MathMLPaddedElement::parseAttribute):
- mathml/MathMLPaddedElement.h:
- mathml/MathMLScriptsElement.cpp:
(WebCore::MathMLScriptsElement::parseAttribute):
- mathml/MathMLScriptsElement.h:
- mathml/MathMLSpaceElement.cpp:
(WebCore::MathMLSpaceElement::parseAttribute):
- mathml/MathMLSpaceElement.h:
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::parseAttribute):
- mathml/MathMLUnderOverElement.cpp:
(WebCore::MathMLUnderOverElement::parseAttribute):
- mathml/MathMLUnderOverElement.h:
- rendering/mathml/MathMLStyle.cpp:
(WebCore::MathMLStyle::resolveMathMLStyle):
- rendering/mathml/MathMLStyle.h:
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::mathVariant):
(WebCore::RenderMathMLToken::updateMathVariantGlyph):
- 1:07 AM Changeset in webkit [204020] by
-
- 8 edits5 adds in trunk
[Fetch API] Fetch promises should not reject or resolve when ActiveDOMObjects are being stopped
https://bugs.webkit.org/show_bug.cgi?id=160420
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/cors/cors-preflight-redirect-worker-expected.txt: Added.
- web-platform-tests/fetch/nosniff/worker-expected.txt: Added.
Source/WebCore:
Test: http/tests/fetch/fetch-in-worker-crash.html
Promises should not be rejected when FetchResponse/FetchRequest are stopped as ActiveDOMObject.
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::cleanConsumePromise): Allowing to nullify the promise used to consume body.
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::stop): Nullifying the body consume promise if any.
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::BodyLoader::stop): Nullifying the fetch promise if any.
LayoutTests:
- TestExpectations:
- http/tests/fetch/fetch-in-worker-crash-expected.txt: Added.
- http/tests/fetch/fetch-in-worker-crash.html: Added.
- http/tests/fetch/fetch-in-worker.js: Added.
(onmessage):
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker-expected.txt:
- 12:20 AM Changeset in webkit [204019] by
-
- 23 edits5 adds in trunk
[Fetch API] Add support to ReferrerPolicy
https://bugs.webkit.org/show_bug.cgi?id=160404
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/basic/referrer-expected.txt: Added.
- web-platform-tests/fetch/api/basic/referrer-worker-expected.txt: Added.
- web-platform-tests/fetch/api/basic/referrer-worker.html: Added.
- web-platform-tests/fetch/api/basic/referrer.html: Added.
- web-platform-tests/fetch/api/basic/referrer.js: Added.
(runTest):
- web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
(corsPreflightReferrer): fix infrastructure bug in test and fix expected referrer policy in default case.
- web-platform-tests/fetch/api/cors/cors-preflight-worker-expected.txt:
Source/WebCore:
Tests: imported/w3c/web-platform-tests/fetch/api/basic/referrer-worker.html
imported/w3c/web-platform-tests/fetch/api/basic/referrer.html
Refactored ThreadableLoader API to take more references.
Updated loading code in CachedResource to take into account referrer policy, that can be set by fetch API.
To enable correct handling of OriginWhenCrossOrigin policy, the computation of the cross-origin status of a request is
moved from ResourceLoader to CachedResource.
Referrer is passed to the loading code through HTTP headers.
This was triggering preflighting for Workers request as WorkerThreadableLoader was setting the referrer.
It is now done in DocumentThreadableLoader::loadRequest so that preflighting is done before setting the referrer.
Note that this referrer setting is only a way to pass a specific referrer value to the loading code.
CachedResource code will compute the actual referer value based on the referrer policy.
It might be good in the future to have a different way of conveying this information to CachedResource, maybe
through CachedResourceRequest.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start): Refactoring of ThreadableLoader API.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::internalRequest): Setting referrer if it has a specific value.
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start): Ractoring of ThreadableLoader API.
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight): Set referrer in the preflight request if any.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Refactoring of ThreadableLoader API.
(WebCore::DocumentThreadableLoader::create): Ditto.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
- loader/DocumentThreadableLoader.h:
(WebCore::DocumentThreadableLoader::referrer): Storing referrer in case one is defined.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::init): Removing of cross origin computation since it is done earlier in CachedResource.
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create): Refactoring of ThreadableLoader API.
(WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.
- loader/ThreadableLoader.h:
- loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::create): Ditto.
(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper): Ditto.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Ditto.
(WebCore::WorkerThreadableLoader::loadResourceSynchronously): Removing setting of referrer in header and passing
it as a parameter.
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto.
- loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::create): Refactoring of ThreadableLoader API.
- loader/cache/CachedResource.cpp:
(WebCore::addAdditionalRequestHeadersToRequest): Computation of referrer based on referrer policy.
(WebCore::CachedResource::addAdditionalRequestHeaders): Ditto.
(WebCore::CachedResource::load): Computation of cross origin status.
(WebCore::CachedResource::varyHeaderValuesMatch):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::options):
- page/EventSource.cpp:
(WebCore::EventSource::connect): Refactoring of ThreadableLoader API.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously): Ditto.
(WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest): Ditto.
- 12:19 AM Changeset in webkit [204018] by
-
- 25 edits2 adds in trunk/Source
Refactor data passed along for a "GetRecord" request.
https://bugs.webkit.org/show_bug.cgi?id=160352
Reviewed by Tim Horton.
Source/WebCore:
No new tests (No behavior change).
Adding this new object lets us easily add new data passed along for GetRecord
requests going forward.
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::getRecordOnServer):
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::getRecord):
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::getRecord):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::getRecord):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::getRecord):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBGetRecordData.cpp: Added.
(WebCore::IDBGetRecordData::isolatedCopy):
- Modules/indexeddb/shared/IDBGetRecordData.h: Added.
(WebCore::IDBGetRecordData::encode):
(WebCore::IDBGetRecordData::decode):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::getRecord):
- Modules/indexeddb/shared/InProcessIDBServer.h:
Source/WebKit2:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::getRecord):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::getRecord):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
Aug 1, 2016:
- 11:51 PM Changeset in webkit [204017] by
-
- 5 edits in branches/safari-602-branch/Source/JavaScriptCore
Merge r204010. rdar://problem/27534844
- 11:51 PM Changeset in webkit [204016] by
-
- 3 edits4 adds in branches/safari-602-branch
Merge r203990. rdar://problem/27534844
- 11:51 PM Changeset in webkit [204015] by
-
- 5 edits3 adds in branches/safari-602-branch
Merge r203985. rdar://problem/26310261
- 11:46 PM Changeset in webkit [204014] by
-
- 34 edits in trunk/Source/WebCore
[Fetch API] Pass directly FetchRequest fetch options to ThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=160407
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-01
Reviewed by Sam Weinig.
No change of behavior.
Added a ResourceLoaderOptions constructor that takes a FetchOptions as input.
Removed setters and getters of ResourceLoaderOptions as it is a struct.
Updated member fields accordingly.
Updated code accordingly.
Removed explicit option setting if it is the same as the default value.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::cachedFont):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::loadResource):
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):
(WebCore::CrossOriginPreflightChecker::startPreflight):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::init):
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::setDefersLoading):
(WebCore::ResourceLoader::setDataBufferingPolicy):
(WebCore::ResourceLoader::addDataOrBuffer):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveDataOrBuffer):
(WebCore::ResourceLoader::didFinishLoadingOnePart):
(WebCore::ResourceLoader::cleanupForError):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::shouldSendResourceLoadCallbacks):
(WebCore::ResourceLoader::setSendCallbackPolicy):
(WebCore::ResourceLoader::shouldSniffContent):
(WebCore::ResourceLoader::shouldIncludeCertificateInfo):
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::sendLoadCallbacks): Deleted.
(WebCore::ResourceLoaderOptions::setSendLoadCallbacks): Deleted.
(WebCore::ResourceLoaderOptions::sniffContent): Deleted.
(WebCore::ResourceLoaderOptions::setSniffContent): Deleted.
(WebCore::ResourceLoaderOptions::dataBufferingPolicy): Deleted.
(WebCore::ResourceLoaderOptions::setDataBufferingPolicy): Deleted.
(WebCore::ResourceLoaderOptions::allowCredentials): Deleted.
(WebCore::ResourceLoaderOptions::setAllowCredentials): Deleted.
(WebCore::ResourceLoaderOptions::securityCheck): Deleted.
(WebCore::ResourceLoaderOptions::setSecurityCheck): Deleted.
(WebCore::ResourceLoaderOptions::certificateInfoPolicy): Deleted.
(WebCore::ResourceLoaderOptions::setCertificateInfoPolicy): Deleted.
(WebCore::ResourceLoaderOptions::contentSecurityPolicyImposition): Deleted.
(WebCore::ResourceLoaderOptions::setContentSecurityPolicyImposition): Deleted.
(WebCore::ResourceLoaderOptions::defersLoadingPolicy): Deleted.
(WebCore::ResourceLoaderOptions::setDefersLoadingPolicy): Deleted.
(WebCore::ResourceLoaderOptions::cachingPolicy): Deleted.
(WebCore::ResourceLoaderOptions::setCachingPolicy): Deleted.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::load):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::setDataBufferingPolicy):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::shouldSendResourceLoadCallbacks):
(WebCore::CachedResource::dataBufferingPolicy):
(WebCore::CachedResource::allowsCaching):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin):
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::allowsCaching):
- loader/cache/CachedResourceRequestInitiators.cpp:
(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
- loader/cache/CachedResourceRequestInitiators.h:
- loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willCacheResponse):
(WebCore::ResourceLoader::didReceiveDataArray):
- page/EventSource.cpp:
(WebCore::EventSource::connect):
- style/StylePendingResources.cpp:
(WebCore::Style::loadPendingImage):
(WebCore::Style::loadPendingSVGFilters):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::requestImageResource):
- svg/SVGFontFaceUriElement.cpp:
(WebCore::SVGFontFaceUriElement::loadFont):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::updateExternalDocument):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
- 11:42 PM Changeset in webkit [204013] by
-
- 31 edits1 move3 adds1 delete in trunk/Source
[GTK] Move the redirected XComposite window to the web process
https://bugs.webkit.org/show_bug.cgi?id=160389
Reviewed by Žan Doberšek.
Source/WebCore:
Add helper methods to PlatformDisplayX11 to query X extensions supported by the display.
- platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::supportsXComposite):
(WebCore::PlatformDisplayX11::supportsXDamage):
- platform/graphics/x11/PlatformDisplayX11.h:
Source/WebKit2:
In the current code, the UI process creates the redirected window that the web process uses to render
accelerated contents. The redirected window is sent to the web process as native surface handle, and using
XDamage extension the UI process takes a pixmap of the redirected window to render into the widget when there
are updates. This requires several points of synchronization between UI and web processes. When the web view is
resized, the UI process first resizes the redirected window and then sends a new backing store ID to the web
process. The time between the redirected window is resized and the web process renders the new contents the UI
process keeps rendering the previous contents with the previous size in the new window with the new size. This
makes the resize process slow, and it produces rendering artifacts quite often. The redirected window is created
when the web view is realized, to be able to inherit the XVisual from the parent window, and the native window
handle is sent to the web process. The time until the window is realized, the web process doesn't have a context
to render into, so the UI process simply renders an empty page. When the web view is unrealized, for example if
the web view is reparented, the redirected window is destroyed, and a sync message is sent to the web process to
destroy the current gl context and stop drawing. This needs to happen synchronously, because the UI process
can't remove the redirected window until the web process has stopped rendering into it. This makes also the
reparenting process quite unstable and risky.
To all those synchronization points we now have to add the synchronization with the compositing thread when
using the threaded compositor. The threaded compositor made resizing, reparenting, etc. even worse. We can't
avoid the synchronization with the threaded compositor, but we can reduce the synchronization points and improve
the current ones by moving the redirected window to the web process. In this case is web process who creates the
redirected window, so we can be sure that it always has a valid native surface handle to render into. This means
we no longer need the IPC message to send the native surface handle from the UI process to the web process, nor
the sync message to destroy it either. This also means we no longer need to wait until the view is realized to
start rendering accelerated contents, and we don't need to stop when it's unrealized either. We don't really
need to inherit the XVisual from the parent window if the redirected window always uses always a RGBA visual
when available. That way we always render into a transparent window that is composed into the web view
widget. And when the web view is resized, we no longer need to destroy the GL context either, because we use the
same redirected window as the native handle, but create a new pixmap that is what we send to the UI process as
layer tree context ID. The layer tree context ID is already sent to the UI process by the drawing area as part
of the backing store update process, so we don't need any new IPC message for this. When the web view is
resized, the UI process sends a backing store state update message to the web process that updates its size,
relayouts and then renders the new contents, so that when the update backing store state reply gets to the UI
process, we already have a new pixmap with the new contents updated. This makes resizing smooth again, and
avoids flickering and rendering artifacts. And finally all this also prevents several race conditions that were
causing X errors and web process crashes.
- PlatformGTK.cmake:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::create): Make it possible to optionally pass a native surface handle for
compositing to the ThreadedCompositor contructor.
(WebKit::ThreadedCompositor::ThreadedCompositor): Initialize the native surface handle and make the scene active
after the thread initialization if we already have a valid handle.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::enterAcceleratedCompositingMode): Pass the layer tree context ID to the web view.
(WebKit::PageClientImpl::updateAcceleratedCompositingMode): Notify the web view about the update.
(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode): Deleted.
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetAcceleratedCompositingPixmap): Helper function to update the pixmap used to render the
accelerated contents.
(webkitWebViewBaseRealize): Remove the code to create the redirected window.
(webkitWebViewBaseUnrealize): Remove the code to destroy the redirected window.
(webkitWebViewBaseDispose): Reset the accelerated compositing pixmap.
(webkitWebViewRenderAcceleratedCompositingResults): Use the accelerated compositing pixmap surface.
(webkitWebViewBaseSizeAllocate): Remove the code to resize the redirected window.
(webkitWebViewBaseEnterAcceleratedCompositingMode): Update the accelerated compositing pixmap.
(webkitWebViewBaseUpdateAcceleratedCompositingMode): Ditto.
(webkitWebViewBaseExitAcceleratedCompositingMode): Reset the accelerated compositing pixmap.
(webkitWebViewBaseDidRelaunchWebProcess): Remove the code to send native surface handle to the web process.
(webkitWebViewBasePageClosed): Reset the accelerated compositing pixmap.
(_WebKitWebViewBasePrivate::updateViewStateTimerFired): Deleted.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState): Handle the case when the layer tree context ID
changes without leaving the accelerated compositing mode, calling updateAcceleratedCompositingMode().
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Let the web view know we are leaving accelerated
compositing mode even when it's forced, since in case of web process crash we need to leave the accelerated
compositing mode in the UI process.
(WebKit::DrawingAreaProxyImpl::willEnterAcceleratedCompositingMode): This message was added only to prepare the
redirected window when the web process was about to enter accelerated compositing mode, so it's no longer needed.
(WebKit::DrawingAreaProxyImpl::setNativeSurfaceHandleForCompositing): This is now only used when building
without redirected XComposite window support.
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willEnterAcceleratedCompositingMode): Deleted.
- UIProcess/WebPageProxy.h:
- UIProcess/efl/WebView.h:
- UIProcess/gtk/RedirectedXCompositeWindow.cpp: Removed.
- UIProcess/gtk/XDamageNotifier.cpp: Helper class to be notified about XDamage events.
(WebKit::XDamageNotifier::singleton):
(WebKit::XDamageNotifier::XDamageNotifier):
(WebKit::XDamageNotifier::add):
(WebKit::XDamageNotifier::remove):
(WebKit::XDamageNotifier::filterXDamageEvent):
(WebKit::XDamageNotifier::notify):
- UIProcess/gtk/XDamageNotifier.h: Added.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode): Deleted.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::willEnterAcceleratedCompositingMode): Deleted.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::enterAcceleratedCompositingMode): Remove code to send
WillEnterAcceleratedCompositingMode message.
(WebKit::AcceleratedDrawingArea::setNativeSurfaceHandleForCompositing): This is now only used when building
without redirected XComposite window support.
- WebProcess/WebPage/AcceleratedDrawingArea.h:
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Create a redirected window and
pass the window ID as native surface handle to the threaded compositor. Use the redirected window pixmap as
layer tree context.
(WebKit::ThreadedCoordinatedLayerTreeHost::invalidate): Destroy the redirected window.
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged): Resize the redirected window and
update the layer tree context.
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange): Ditto.
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Create a redirected window and texture mapper that uses the window
ID as native surface handle. Use the redirected window pixmap as layer tree context.
(WebKit::LayerTreeHostGtk::makeContextCurrent): Use the redirected window as native handle.
(WebKit::LayerTreeHostGtk::invalidate): Destroy the redirected window.
(WebKit::LayerTreeHostGtk::sizeDidChange): Resize the redirected window and update the layer tree context.
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged): Ditto.
(WebKit::LayerTreeHostGtk::createTextureMapper): Helper function to create the texture mapper.
(WebKit::LayerTreeHostGtk::setNativeSurfaceHandleForCompositing): Use createTextureMapper().
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- WebProcess/WebPage/gtk/RedirectedXCompositeWindow.cpp: Added.
(WebKit::RedirectedXCompositeWindow::create):
(WebKit::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebKit::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebKit::RedirectedXCompositeWindow::resize):
- WebProcess/WebPage/gtk/RedirectedXCompositeWindow.h: Renamed from Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.h.
(WebKit::RedirectedXCompositeWindow::window):
(WebKit::RedirectedXCompositeWindow::pixmap):
- 11:00 PM Changeset in webkit [204012] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 10:40 PM Changeset in webkit [204011] by
-
- 10 edits in trunk/Source/WebKit2
Database Process: ASSERTION FAILED: filePaths.size() == result.handles().size() with SANDBOX_EXTENSIONS disabled
https://bugs.webkit.org/show_bug.cgi?id=160398
Reviewed by Brady Eidson.
Same assert as in bug #160188, but this time in preregisterSandboxExtensionsIfNecessary.
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseProcess.messages.in:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::handleGetResult):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::preregisterSandboxExtensionsForOptionallyFileBackedBlob):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Databases/DatabaseProcessProxy.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::preregisterSandboxExtensionsIfNecessary):
- 10:38 PM Changeset in webkit [204010] by
-
- 5 edits in trunk/Source/JavaScriptCore
REGRESSION (r203990): JSC Debug test stress/arity-check-ftl-throw.js failing
https://bugs.webkit.org/show_bug.cgi?id=160438
Reviewed by Mark Lam.
In r203990 I fixed a bug where CommonSlowPaths.h/arityCheckFor() was basically failing at
catching stack overflow due to large parameter count. It would only catch regular old stack
overflow, like if the frame pointer was already past the limit.
This had a secondary problem: unfortunately all of our tests for what happens when you overflow
the stack due to large parameter count were not going down that path at all, so we haven't had
test coverage for this in ages. There were bugs in all tiers of the engine when handling this
case.
We need to be able to roll back the topCallFrame on paths that are meant to throw an exception
from the caller. Otherwise, we'd crash in StackVisitor because it would see a busted stack
frame. Rolling back like this "just works" except when the caller is the VM entry frame. I had
some choices here. I could have forced anyone who is rolling back to always skip VM entry
frames. They can't do it in a way that changes the value of VM::topVMEntryFrame, which is what
a stack frame roll back normally does, since exception unwinding needs to see the current value
of topVMEntryFrame. So, we have a choice to either try to magically avoid all of the paths that
look at topCallFrame, or give topCallFrame a state that unambiguously signals that we are
sitting right on top of a VM entry frame without having succeeded at making a JS call. The only
place that really needs to know is StackVisitor, which wants to start scanning at topCallFrame.
To signal this, I could have either made topCallFrame point to the real top JS call frame
without also rolling back topVMEntryFrame, or I could make topCallFrame == topVMEntryFrame. The
latter felt somehow cleaner. I filed a bug (https://bugs.webkit.org/show_bug.cgi?id=160441) for
converting topCallFrame to a void*, which would give us a chance to harden the rest of the
engine against this case.
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::StackVisitor):
We may do ShadowChicken processing, which invokes StackVisitor, when we have topCallFrame
pointing at topVMEntryFrame. This teaches StackVisitor how to handle this case. I believe that
StackVisitor is the only place that needs to be taught about this at this time, because it's
one of the few things that access topCallFrame along this special path.
- jit/JITOperations.cpp: Roll back the top call frame.
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL): Roll back the top call frame.
- 10:02 PM Changeset in webkit [204009] by
-
- 5 edits in trunk/Source
[JSC][ARM64] Fix branchTest32/64 taking an immediate as mask
https://bugs.webkit.org/show_bug.cgi?id=160439
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-01
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branchTest64):
- b3/air/AirOpcode.opcodes:
Fix the ARM64 codegen to lower BitImm64 without using a scratch register.
Source/WTF:
- wtf/MathExtras.h:
(getLSBSet):
This was not working at all for MacroAssembler.
Since TrustedImm32/64 are signed integers, the arithmetic shift would
never get rid of the top bit and we get an infinite loop.
- 8:59 PM Changeset in webkit [204008] by
-
- 11 edits in trunk
_WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
https://bugs.webkit.org/show_bug.cgi?id=160437
<rdar://problem/27578272>
Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-01
Reviewed by Brady Eidson.
Source/WebKit2:
This preserves the behavior of the NSURLConnection/NSURLDownload code path.
decideDestinationWithSuggestedFilename might need some information from the didReceiveResponse callback
in order to decide what the suggested filename should be.
- NetworkProcess/Downloads/Download.cpp:
(WebKit::Download::didReceiveAuthenticationChallenge):
(WebKit::Download::didReceiveResponse):
(WebKit::Download::didReceiveData):
- NetworkProcess/Downloads/Download.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::setPendingDownloadID):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
- NetworkProcess/NetworkLoad.h:
(WebKit::NetworkLoad::pendingDownloadID):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::pendingDownloadCanceled):
(WebKit::NetworkProcess::findPendingDownloadLocation):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(-[DownloadDelegate _download:didReceiveResponse:]):
(-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(runTest):
Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
- 6:50 PM Changeset in webkit [204007] by
-
- 2 edits in trunk/Tools
[Tools] The GDB backtrace report tool don't checks the gdb return code.
https://bugs.webkit.org/show_bug.cgi?id=160414
Reviewed by Michael Catanzaro.
- Scripts/webkitpy/port/linux_get_crash_log.py:
(GDBCrashLogGenerator._wait_for_corefile):
- 6:44 PM Changeset in webkit [204006] by
-
- 5 edits in trunk/Source/WebCore
Shrink MediaQuerySets to fit after parsing.
<https://webkit.org/b/160419>
Reviewed by Antti Koivisto.
Add shrinkToFit() helpers to MediaQuerySet and MediaQuery
and call it after parsing to remove extra capacity from their
internal vectors.
This reduces memory usage by 1.24MB on theverge.com.
- css/CSSParser.cpp:
(WebCore::CSSParser::createMediaRule):
- css/MediaList.cpp:
(WebCore::MediaQuerySet::parse):
(WebCore::MediaQuerySet::shrinkToFit):
- css/MediaList.h:
- css/MediaQuery.h:
(WebCore::MediaQuery::shrinkToFit):
- 6:39 PM Changeset in webkit [204005] by
-
- 5 edits2 adds in trunk
<attachment> action label doesn't wrap, but needs to for some localizations
https://bugs.webkit.org/show_bug.cgi?id=160431
<rdar://problem/27526464>
Reviewed by Simon Fraser.
Test: fast/attachment/attachment-wrapping-action.html
- rendering/RenderThemeIOS.mm:
(WebCore::AttachmentInfo::buildWrappedLines):
(WebCore::AttachmentInfo::AttachmentInfo):
(WebCore::AttachmentInfo::buildTitleLines): Deleted.
Rework buildTitleLines into buildWrappedLines so that we have a
generic way to add lines that wrap up to N lines and then center-truncate.
Make use of it for the action text, and follow the same rules/width as
the title text already does.
- fast/attachment/attachment-wrapping-action-expected-mismatch.html: Added.
- fast/attachment/attachment-wrapping-action.html: Added.
Add a test that ensures that the action label wraps by filling one with
non-breaking and breaking spaces, which will wrap onto two lines, and one
with just a single space, which will always fit in one line, and ensuring
that they do not match.
- 5:31 PM Changeset in webkit [204004] by
-
- 3 edits in trunk/LayoutTests
[iOS] Fix fast/events/touch/document-create-touch-list-ios.html
https://bugs.webkit.org/show_bug.cgi?id=160429
Reviewed by Ryosuke Niwa.
Fix several bugs in fast/events/touch/document-create-touch-list-ios.html:
- Use proper parameters to TouchEvent.initTouchEvent() so that it no longer throws.
- For the check testing passing bad parameters to createTouchList(), print PASS if it throws instead of FAIL since this is the expected behavior.
- fast/events/touch/document-create-touch-list-ios-expected.txt:
- fast/events/touch/script-tests/document-create-touch-list-ios.js:
(catch): Deleted.
- 5:27 PM Changeset in webkit [204003] by
-
- 2 edits in branches/safari-602-branch/LayoutTests
Merge r204002.
2016-08-01 Alexey Proskuryakov <ap@apple.com>
Sierra test expectations gardening for editing/input/password-echo-textnode.html.
- platform/mac/TestExpectations:
- 5:19 PM Changeset in webkit [204002] by
-
- 2 edits in trunk/LayoutTests
Sierra test expectations gardening for editing/input/password-echo-textnode.html.
- platform/mac/TestExpectations:
- 5:11 PM Changeset in webkit [204001] by
-
- 4 edits in trunk/Source
Source/WebCore:
Build fix.
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Bring back a file - it needs to be copied by WebCore.
- MigrateHeaders.make:
- 4:51 PM Changeset in webkit [204000] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove another file.
- MigrateHeaders.make:
- 4:47 PM Changeset in webkit [203999] by
-
- 1 copy in tags/Safari-602.1.45
New tag.
- 4:45 PM Changeset in webkit [203998] by
-
- 4 edits in branches/safari-602-branch/Source/WebCore
Roll out r203799. rdar://problem/27556788
- 4:37 PM Changeset in webkit [203997] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove a file.
- MigrateHeaders.make:
- 4:22 PM Changeset in webkit [203996] by
-
- 10 edits in trunk/Source/JavaScriptCore
[B3] Fusing immediates into test instructions should work again
https://bugs.webkit.org/show_bug.cgi?id=160073
Reviewed by Sam Weinig.
When we introduced BitImm, we forgot to change the Branch(BitAnd(value, constant))
fusion. This emits test instructions, so it should use BitImm for the constant. But it
was still using Imm! This meant that isValidForm() always returned false.
This fixes the code path to use BitImm, and turns off our use of BitImm64 on x86 since
it provides no benefit on x86 and has some risk (the code appears to play fast and loose
with the scratch register).
This is not an obvious progression on anything, so I added comprehensive tests to
testb3, which check that we selected the optimal instruction in a variety of situations.
We should add more tests like this!
Rolling this back in after fixing ARM64. The bug was that branchTest32|64 on ARM64 doesn't
actually support BitImm or BitImm64, at least not yet. Disabling that in AirOpcodes makes
this patch not a regression on ARM64. That change was reviewed by Benjamin Poulain.
- b3/B3BasicBlock.h:
(JSC::B3::BasicBlock::successorBlock):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createGenericCompare):
- b3/B3LowerToAir.h:
- b3/air/AirArg.cpp:
(JSC::B3::Air::Arg::isRepresentableAs):
(JSC::B3::Air::Arg::usesTmp):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::isRepresentableAs):
(JSC::B3::Air::Arg::castToType):
(JSC::B3::Air::Arg::asNumber):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::size):
(JSC::B3::Air::Code::at):
- b3/air/AirOpcode.opcodes:
- b3/air/AirValidate.h:
- b3/air/opcode_generator.rb:
- b3/testb3.cpp:
(JSC::B3::compile):
(JSC::B3::compileAndRun):
(JSC::B3::lowerToAirForTesting):
(JSC::B3::testSomeEarlyRegister):
(JSC::B3::testBranchBitAndImmFusion):
(JSC::B3::zero):
(JSC::B3::run):
- 4:21 PM Changeset in webkit [203995] by
-
- 2 edits in trunk/Source/WebCore
Another build fix.
- WebCore.xcodeproj/project.pbxproj:
- 4:04 PM Changeset in webkit [203994] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't set
width:calc(100% - 0px); left:0pxon console messages
https://bugs.webkit.org/show_bug.cgi?id=160428
<rdar://problem/27646033>
Reviewed by Timothy Hatcher.
Console messages inside console.group() are indented. Console messages outside of
console.group() aren't and there is no reason to set inline styles that do nothing
on each one of them.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
- 3:51 PM Changeset in webkit [203993] by
-
- 11 edits13 copies1 move4 adds in trunk/Source/WebCore
Freeze the last of the HTML Objective-C bindings
https://bugs.webkit.org/show_bug.cgi?id=160430
Reviewed by Tim Horton.
Also, remove a bunch of form validation related methods that were never exposed/used.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMBlob.h: Added.
- bindings/objc/DOMBlob.mm: Added.
- bindings/objc/DOMBlobInternal.h: Added.
- bindings/objc/DOMDOMTokenList.h: Added.
- bindings/objc/DOMDOMTokenList.mm: Added.
- bindings/objc/DOMDOMTokenListInternal.h: Added.
- bindings/objc/DOMFile.h: Added.
- bindings/objc/DOMFile.mm: Added.
- bindings/objc/DOMFileInternal.h: Added.
- bindings/objc/DOMFileList.h: Added.
- bindings/objc/DOMFileList.mm: Added.
- bindings/objc/DOMFileListInternal.h: Added.
- bindings/objc/DOMHTMLButtonElement.mm:
- bindings/objc/DOMHTMLFieldSetElement.mm:
- bindings/objc/DOMHTMLInputElement.mm:
- bindings/objc/DOMHTMLInputElementPrivate.h:
- bindings/objc/DOMHTMLObjectElement.mm:
- bindings/objc/DOMHTMLSelectElement.mm:
- bindings/objc/DOMHTMLTextAreaElement.mm:
- bindings/objc/DOMHTMLTextAreaElementPrivate.h:
- bindings/objc/DOMMediaError.h: Added.
- bindings/objc/DOMMediaError.mm: Added.
- bindings/objc/DOMMediaErrorInternal.h: Added.
- bindings/objc/DOMTimeRanges.h: Added.
- bindings/objc/DOMTimeRanges.mm: Added.
- bindings/objc/DOMTimeRangesInternal.h: Added.
- 3:44 PM Changeset in webkit [203992] by
-
- 3 edits1 copy1 add in trunk/LayoutTests
Land updated baseline for rdar://problem/27611932.
- editing/mac/attributed-string/font-style-variant-effect-expected.txt:
- platform/mac-elcapitan/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Copied from LayoutTests/editing/mac/attributed-string/font-style-variant-effect-expected.txt.
- platform/mac-wk1/TestExpectations:
- 3:31 PM Changeset in webkit [203991] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Grid column resizer elements positioned incorrectly
https://bugs.webkit.org/show_bug.cgi?id=160311
<rdar://problem/27595586>
Reviewed by Brian Burg.
Perform a resize layout on a newly shown tab content view if the tab
browser was resized before showing the tab.
- UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype.layout):
Mark all recent tab content views (except for the current view)
as needing a resize layout.
(WebInspector.TabBrowser.prototype._tabBarItemSelected):
If the tab browser was resized while the view was hidden, update the
view's layout for the new content view container size.
- 3:20 PM Changeset in webkit [203990] by
-
- 4 edits1 add in trunk
Rationalize varargs stack overflow checks
https://bugs.webkit.org/show_bug.cgi?id=160425
Reviewed by Michael Saboff.
- ftl/FTLLink.cpp:
(JSC::FTL::link): AboveOrEqual 0 is a tautology. The code meant GreaterThanOrEqual, since the error code is -1.
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor): Use roundUpToMultipleOf(), which is almost certainly what we meant when we said %.
- 2:32 PM Changeset in webkit [203989] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.xcodeproj/project.pbxproj:
- 2:16 PM Changeset in webkit [203988] by
-
- 5 edits173 adds in trunk/Source
Freeze all the DOMHTML* Objective-C bindings
https://bugs.webkit.org/show_bug.cgi?id=160424
Reviewed by Tim Horton.
Source/WebCore:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMHTMLAnchorElement.h: Added.
- bindings/objc/DOMHTMLAnchorElement.mm: Added.
- bindings/objc/DOMHTMLAnchorElementInternal.h: Added.
- bindings/objc/DOMHTMLAppletElement.h: Added.
- bindings/objc/DOMHTMLAppletElement.mm: Added.
- bindings/objc/DOMHTMLAppletElementInternal.h: Added.
- bindings/objc/DOMHTMLAreaElement.h: Added.
- bindings/objc/DOMHTMLAreaElement.mm: Added.
- bindings/objc/DOMHTMLAreaElementInternal.h: Added.
- bindings/objc/DOMHTMLBRElement.h: Added.
- bindings/objc/DOMHTMLBRElement.mm: Added.
- bindings/objc/DOMHTMLBRElementInternal.h: Added.
- bindings/objc/DOMHTMLBaseElement.h: Added.
- bindings/objc/DOMHTMLBaseElement.mm: Added.
- bindings/objc/DOMHTMLBaseElementInternal.h: Added.
- bindings/objc/DOMHTMLBaseFontElement.h: Added.
- bindings/objc/DOMHTMLBaseFontElement.mm: Added.
- bindings/objc/DOMHTMLBaseFontElementInternal.h: Added.
- bindings/objc/DOMHTMLBodyElement.h: Added.
- bindings/objc/DOMHTMLBodyElement.mm: Added.
- bindings/objc/DOMHTMLBodyElementInternal.h: Added.
- bindings/objc/DOMHTMLButtonElement.h: Added.
- bindings/objc/DOMHTMLButtonElement.mm: Added.
- bindings/objc/DOMHTMLButtonElementInternal.h: Added.
- bindings/objc/DOMHTMLCanvasElement.h: Added.
- bindings/objc/DOMHTMLCanvasElement.mm: Added.
- bindings/objc/DOMHTMLCanvasElementInternal.h: Added.
- bindings/objc/DOMHTMLCollection.h: Added.
- bindings/objc/DOMHTMLCollection.mm: Added.
- bindings/objc/DOMHTMLCollectionInternal.h: Added.
- bindings/objc/DOMHTMLDListElement.h: Added.
- bindings/objc/DOMHTMLDListElement.mm: Added.
- bindings/objc/DOMHTMLDListElementInternal.h: Added.
- bindings/objc/DOMHTMLDirectoryElement.h: Added.
- bindings/objc/DOMHTMLDirectoryElement.mm: Added.
- bindings/objc/DOMHTMLDirectoryElementInternal.h: Added.
- bindings/objc/DOMHTMLDivElement.h: Added.
- bindings/objc/DOMHTMLDivElement.mm: Added.
- bindings/objc/DOMHTMLDivElementInternal.h: Added.
- bindings/objc/DOMHTMLDocument.h: Added.
- bindings/objc/DOMHTMLDocument.mm: Added.
- bindings/objc/DOMHTMLDocumentInternal.h: Added.
- bindings/objc/DOMHTMLElement.h: Added.
- bindings/objc/DOMHTMLElement.mm: Added.
- bindings/objc/DOMHTMLElementInternal.h: Added.
- bindings/objc/DOMHTMLEmbedElement.h: Added.
- bindings/objc/DOMHTMLEmbedElement.mm: Added.
- bindings/objc/DOMHTMLEmbedElementInternal.h: Added.
- bindings/objc/DOMHTMLFieldSetElement.h: Added.
- bindings/objc/DOMHTMLFieldSetElement.mm: Added.
- bindings/objc/DOMHTMLFieldSetElementInternal.h: Added.
- bindings/objc/DOMHTMLFontElement.h: Added.
- bindings/objc/DOMHTMLFontElement.mm: Added.
- bindings/objc/DOMHTMLFontElementInternal.h: Added.
- bindings/objc/DOMHTMLFormElement.h: Added.
- bindings/objc/DOMHTMLFormElement.mm: Added.
- bindings/objc/DOMHTMLFormElementInternal.h: Added.
- bindings/objc/DOMHTMLFrameElement.h: Added.
- bindings/objc/DOMHTMLFrameElement.mm: Added.
- bindings/objc/DOMHTMLFrameElementInternal.h: Added.
- bindings/objc/DOMHTMLFrameSetElement.h: Added.
- bindings/objc/DOMHTMLFrameSetElement.mm: Added.
- bindings/objc/DOMHTMLFrameSetElementInternal.h: Added.
- bindings/objc/DOMHTMLHRElement.h: Added.
- bindings/objc/DOMHTMLHRElement.mm: Added.
- bindings/objc/DOMHTMLHRElementInternal.h: Added.
- bindings/objc/DOMHTMLHeadElement.h: Added.
- bindings/objc/DOMHTMLHeadElement.mm: Added.
- bindings/objc/DOMHTMLHeadElementInternal.h: Added.
- bindings/objc/DOMHTMLHeadingElement.h: Added.
- bindings/objc/DOMHTMLHeadingElement.mm: Added.
- bindings/objc/DOMHTMLHeadingElementInternal.h: Added.
- bindings/objc/DOMHTMLHtmlElement.h: Added.
- bindings/objc/DOMHTMLHtmlElement.mm: Added.
- bindings/objc/DOMHTMLHtmlElementInternal.h: Added.
- bindings/objc/DOMHTMLIFrameElement.h: Added.
- bindings/objc/DOMHTMLIFrameElement.mm: Added.
- bindings/objc/DOMHTMLIFrameElementInternal.h: Added.
- bindings/objc/DOMHTMLImageElement.h: Added.
- bindings/objc/DOMHTMLImageElement.mm: Added.
- bindings/objc/DOMHTMLImageElementInternal.h: Added.
- bindings/objc/DOMHTMLInputElement.h: Added.
- bindings/objc/DOMHTMLInputElement.mm: Added.
- bindings/objc/DOMHTMLInputElementInternal.h: Added.
- bindings/objc/DOMHTMLInputElementPrivate.h: Added.
- bindings/objc/DOMHTMLLIElement.h: Added.
- bindings/objc/DOMHTMLLIElement.mm: Added.
- bindings/objc/DOMHTMLLIElementInternal.h: Added.
- bindings/objc/DOMHTMLLabelElement.h: Added.
- bindings/objc/DOMHTMLLabelElement.mm: Added.
- bindings/objc/DOMHTMLLabelElementInternal.h: Added.
- bindings/objc/DOMHTMLLegendElement.h: Added.
- bindings/objc/DOMHTMLLegendElement.mm: Added.
- bindings/objc/DOMHTMLLegendElementInternal.h: Added.
- bindings/objc/DOMHTMLLinkElement.h: Added.
- bindings/objc/DOMHTMLLinkElement.mm: Added.
- bindings/objc/DOMHTMLLinkElementInternal.h: Added.
- bindings/objc/DOMHTMLMapElement.h: Added.
- bindings/objc/DOMHTMLMapElement.mm: Added.
- bindings/objc/DOMHTMLMapElementInternal.h: Added.
- bindings/objc/DOMHTMLMarqueeElement.h: Added.
- bindings/objc/DOMHTMLMarqueeElement.mm: Added.
- bindings/objc/DOMHTMLMarqueeElementInternal.h: Added.
- bindings/objc/DOMHTMLMediaElement.h: Added.
- bindings/objc/DOMHTMLMediaElement.mm: Added.
- bindings/objc/DOMHTMLMediaElementInternal.h: Added.
- bindings/objc/DOMHTMLMenuElement.h: Added.
- bindings/objc/DOMHTMLMenuElement.mm: Added.
- bindings/objc/DOMHTMLMenuElementInternal.h: Added.
- bindings/objc/DOMHTMLMetaElement.h: Added.
- bindings/objc/DOMHTMLMetaElement.mm: Added.
- bindings/objc/DOMHTMLMetaElementInternal.h: Added.
- bindings/objc/DOMHTMLModElement.h: Added.
- bindings/objc/DOMHTMLModElement.mm: Added.
- bindings/objc/DOMHTMLModElementInternal.h: Added.
- bindings/objc/DOMHTMLOListElement.h: Added.
- bindings/objc/DOMHTMLOListElement.mm: Added.
- bindings/objc/DOMHTMLOListElementInternal.h: Added.
- bindings/objc/DOMHTMLObjectElement.h: Added.
- bindings/objc/DOMHTMLObjectElement.mm: Added.
- bindings/objc/DOMHTMLObjectElementInternal.h: Added.
- bindings/objc/DOMHTMLObjectElementPrivate.h: Added.
- bindings/objc/DOMHTMLOptGroupElement.h: Added.
- bindings/objc/DOMHTMLOptGroupElement.mm: Added.
- bindings/objc/DOMHTMLOptGroupElementInternal.h: Added.
- bindings/objc/DOMHTMLOptionElement.h: Added.
- bindings/objc/DOMHTMLOptionElement.mm: Added.
- bindings/objc/DOMHTMLOptionElementInternal.h: Added.
- bindings/objc/DOMHTMLOptionsCollection.h: Added.
- bindings/objc/DOMHTMLOptionsCollection.mm: Added.
- bindings/objc/DOMHTMLOptionsCollectionInternal.h: Added.
- bindings/objc/DOMHTMLParagraphElement.h: Added.
- bindings/objc/DOMHTMLParagraphElement.mm: Added.
- bindings/objc/DOMHTMLParagraphElementInternal.h: Added.
- bindings/objc/DOMHTMLParamElement.h: Added.
- bindings/objc/DOMHTMLParamElement.mm: Added.
- bindings/objc/DOMHTMLParamElementInternal.h: Added.
- bindings/objc/DOMHTMLPreElement.h: Added.
- bindings/objc/DOMHTMLPreElement.mm: Added.
- bindings/objc/DOMHTMLPreElementInternal.h: Added.
- bindings/objc/DOMHTMLQuoteElement.h: Added.
- bindings/objc/DOMHTMLQuoteElement.mm: Added.
- bindings/objc/DOMHTMLQuoteElementInternal.h: Added.
- bindings/objc/DOMHTMLScriptElement.h: Added.
- bindings/objc/DOMHTMLScriptElement.mm: Added.
- bindings/objc/DOMHTMLScriptElementInternal.h: Added.
- bindings/objc/DOMHTMLSelectElement.h: Added.
- bindings/objc/DOMHTMLSelectElement.mm: Added.
- bindings/objc/DOMHTMLSelectElementInternal.h: Added.
- bindings/objc/DOMHTMLStyleElement.h: Added.
- bindings/objc/DOMHTMLStyleElement.mm: Added.
- bindings/objc/DOMHTMLStyleElementInternal.h: Added.
- bindings/objc/DOMHTMLTableCaptionElement.h: Added.
- bindings/objc/DOMHTMLTableCaptionElement.mm: Added.
- bindings/objc/DOMHTMLTableCaptionElementInternal.h: Added.
- bindings/objc/DOMHTMLTableCellElement.h: Added.
- bindings/objc/DOMHTMLTableCellElement.mm: Added.
- bindings/objc/DOMHTMLTableCellElementInternal.h: Added.
- bindings/objc/DOMHTMLTableColElement.h: Added.
- bindings/objc/DOMHTMLTableColElement.mm: Added.
- bindings/objc/DOMHTMLTableColElementInternal.h: Added.
- bindings/objc/DOMHTMLTableElement.h: Added.
- bindings/objc/DOMHTMLTableElement.mm: Added.
- bindings/objc/DOMHTMLTableElementInternal.h: Added.
- bindings/objc/DOMHTMLTableRowElement.h: Added.
- bindings/objc/DOMHTMLTableRowElement.mm: Added.
- bindings/objc/DOMHTMLTableRowElementInternal.h: Added.
- bindings/objc/DOMHTMLTableSectionElement.h: Added.
- bindings/objc/DOMHTMLTableSectionElement.mm: Added.
- bindings/objc/DOMHTMLTableSectionElementInternal.h: Added.
- bindings/objc/DOMHTMLVideoElement.h: Added.
- bindings/objc/DOMHTMLVideoElement.mm: Added.
- bindings/objc/DOMHTMLVideoElementInternal.h: Added.
Source/WebKit/mac:
Don't migrate DOMHTMLEmbedElementPrivate.h - it was just an empty header.
- MigrateHeaders.make:
- 2:06 PM Changeset in webkit [203987] by
-
- 4 edits1 delete in trunk
Make wpt server generate its certificates in layout test results folder
https://bugs.webkit.org/show_bug.cgi?id=160422
Patch by Youenn Fablet <youenn@apple.com> on 2016-08-01
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- resources/_wpt_certs/.gitignore: Removed.
- resources/_wpt_certs/localhost.key: Removed.
- resources/_wpt_certs/localhost.pem: Removed.
- resources/config.json:
Tools:
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
- 2:03 PM Changeset in webkit [203986] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Waterfall graph in Network tab shows too much whitespace/dead time
https://bugs.webkit.org/show_bug.cgi?id=160373
Reviewed by Timothy Hatcher.
Track the start and end time separate from the ruler to remove
leading/trailing whitespace in the graph. Also prevent network
record bars from being clipped.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.get zeroTime):
Set equal to the ruler start time.
(WebInspector.NetworkGridContentView.prototype.reset):
Reset start and end time.
(WebInspector.NetworkGridContentView.prototype.layout):
Set the initial values for ruler start/zero time if needed.
(WebInspector.NetworkGridContentView.prototype._networkTimelineRecordAdded):
Set the start time if needed.
Reduce debounce from 250ms to 150ms. This prevents the current time from
exceeding the end time by as wide a margin, while keeping the current
time "timer" from being restarted too frequently.
(WebInspector.NetworkGridContentView.prototype._stopUpdatingCurrentTime):
Update the ruler end time and schedule a layout.
Add padding equal to the time needed to draw a network bar at minimum width
to prevent bars from being clipped.
- 1:49 PM Changeset in webkit [203985] by
-
- 5 edits3 adds in trunk
REGRESSION(r198943): drop-down menu navigation on fiddlevideo.com doesn't appear on iOS, works on OS X
https://bugs.webkit.org/show_bug.cgi?id=160406
Source/WebCore:
rdar://problem/26310261
Reviewed by Simon Fraser.
On iOS we generate synthetic mouse events from taps. Click event is generated on tap only if the move event
doesn't produce visible changes to the document. This is important to make certain types of drop down menus
work.
The information on mutations is passed via WKContentObservation side channel which is updated from varous parts
of the code. Newly visible elements are detected CheckForVisibilityChangeOnRecalcStyle during style resolution.
This got broken by the style refactoring because it assumes that renderer is mutated along with style computation.
However mutation is now a separate step performed by RenderTreeUpdater.
Fix by moving CheckForVisibilityChange to RenderTreeUpdater.
Test: fast/content-observation/click-event-suppression-on-content-change.html
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::Parent::Parent):
(WebCore::RenderTreeUpdater::updateElementRenderer):
(WebCore::RenderTreeUpdater::tearDownRenderer):
(WebCore::elementImplicitVisibility):
(WebCore::CheckForVisibilityChange::CheckForVisibilityChange):
(WebCore::CheckForVisibilityChange::~CheckForVisibilityChange):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::pushParent):
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::elementImplicitVisibility): Deleted.
(WebCore::Style::CheckForVisibilityChangeOnRecalcStyle::CheckForVisibilityChangeOnRecalcStyle): Deleted.
(WebCore::Style::CheckForVisibilityChangeOnRecalcStyle::~CheckForVisibilityChangeOnRecalcStyle): Deleted.
LayoutTests:
Reviewed by Simon Fraser.
This stuff has had zero test coverage. Adding a basic UIScript based test.
- TestExpectations:
- fast/content-observation/click-event-suppression-on-content-change-expected.txt: Added.
- fast/content-observation/click-event-suppression-on-content-change.html: Added.
- 1:48 PM Changeset in webkit [203984] by
-
- 2 edits in trunk/Source/WebCore
[iOS] A video element that does not pause after exiting from fullscreen should be allowed to continue playing inline
https://bugs.webkit.org/show_bug.cgi?id=160416
<rdar://problem/27409854>
Reviewed by Alex Christensen.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::exitFullscreen): If playback normally requires fullscreen but the
element was not paused when exiting from fullscreen, set the 'playsinline' attribute so we won't
force fullscreen if playback is paused and resumes, and set the 'controls' attribute so the
user can control playback.
- 1:34 PM Changeset in webkit [203983] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj:
- 12:49 PM Changeset in webkit [203982] by
-
- 19 edits2 adds in trunk
[Mac][iOS] Adopt MediaRemote "seek to playback position"
https://bugs.webkit.org/show_bug.cgi?id=160405
<rdar://problem/27547583>
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/remote-control-command-seek.html
- Modules/webaudio/AudioContext.h: Update for didReceiveRemoteControlCommand argument change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didReceiveRemoteControlCommand): Support SeekToPlaybackPositionCommand.
Drive by fix, support Stop command.
(WebCore::HTMLMediaElement::supportsSeeking): New.
- html/HTMLMediaElement.h:
- platform/RemoteCommandListener.h:
(WebCore::RemoteCommandListenerClient::didReceiveRemoteControlCommand): Add command argument.
(WebCore::RemoteCommandListenerClient::supportsSeeking): New.
(WebCore::RemoteCommandListener::updateSupportedCommands): Ditto.
(WebCore::RemoteCommandListener::client): Ditto.
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::didReceiveRemoteControlCommand): Add command argument.
(WebCore::PlatformMediaSession::supportsSeeking): New, pass through to client.
- platform/audio/PlatformMediaSession.h:
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::setCurrentSession): Tell remote command listener to
update supported commands.
(WebCore::PlatformMediaSessionManager::currentSession): Make const.
(WebCore::PlatformMediaSessionManager::didReceiveRemoteControlCommand): Add command argument.
(WebCore::PlatformMediaSessionManager::supportsSeeking): New, pass through to session.
- platform/audio/PlatformMediaSessionManager.h:
- platform/ios/RemoteCommandListenerIOS.h:
(WebCore::RemoteCommandListenerIOS::createWeakPtr):
- platform/ios/RemoteCommandListenerIOS.mm:
(WebCore::RemoteCommandListenerIOS::RemoteCommandListenerIOS): Support changePlaybackPositionCommand.
(WebCore::RemoteCommandListenerIOS::~RemoteCommandListenerIOS): Remove seekToTime target.
(WebCore::RemoteCommandListenerIOS::updateSupportedCommands): Update changePlaybackPositionCommand.
- platform/mac/MediaRemoteSoftLink.cpp:
- platform/mac/MediaRemoteSoftLink.h:
- platform/mac/RemoteCommandListenerMac.h:
- platform/mac/RemoteCommandListenerMac.mm:
(WebCore::RemoteCommandListenerMac::updateSupportedCommands): New, split out of constructor.
(WebCore::RemoteCommandListenerMac::RemoteCommandListenerMac): Split setup logic out into
updateSupportedCommands. Support MRMediaRemoteCommandSeekToPlaybackPosition. Don't assert when
receiving an unsupported command, it happens. Return error when a command isn't supported or
fails.
- testing/Internals.cpp:
(WebCore::Internals::postRemoteControlCommand): Add command argument parameter. Support
seektoplaybackposition.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/remote-control-command-seek-expected.txt: Added.
- media/remote-control-command-seek.html: Added.
- 12:35 PM Changeset in webkit [203981] by
-
- 4 edits6 adds in trunk/Source/WebCore
Freeze DOMHTMLTitleElement and DOMHTMLUListElement bindings
https://bugs.webkit.org/show_bug.cgi?id=160415
Reviewed by Sam Weinig.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMHTMLTitleElement.h: Added.
- bindings/objc/DOMHTMLTitleElement.mm: Added.
- bindings/objc/DOMHTMLTitleElementInternal.h: Added.
- bindings/objc/DOMHTMLUListElement.h: Added.
- bindings/objc/DOMHTMLUListElement.mm: Added.
- bindings/objc/DOMHTMLUListElementInternal.h: Added.
- 11:51 AM Changeset in webkit [203980] by
-
- 5 edits2 adds in branches/safari-602-branch
Merge r203976. rdar://problem/27580049
- 11:48 AM Changeset in webkit [203979] by
-
- 12 edits in trunk/Source/JavaScriptCore
Sub should be a Math IC
https://bugs.webkit.org/show_bug.cgi?id=160270
Reviewed by Mark Lam.
This makes Sub an IC like Mul and Add. I'm seeing the following
improvements of average Sub size on Unity and JetStream:
| JetStream | Unity 3D |
------| ------------- Old | 202 bytes | 205 bytes |
------| ------------- New | 134 bytes | 134 bytes |
------------------------------------
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::addJITMulIC):
(JSC::CodeBlock::addJITSubIC):
(JSC::CodeBlock::findStubInfo):
(JSC::CodeBlock::dumpMathICStats):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::stubInfoBegin):
(JSC::CodeBlock::stubInfoEnd):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithSub):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithAddOrSub):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emit_op_pow):
- jit/JITMathIC.h:
- jit/JITMathICForwards.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITSubGenerator.cpp:
(JSC::JITSubGenerator::generateInline):
(JSC::JITSubGenerator::generateFastPath):
- jit/JITSubGenerator.h:
(JSC::JITSubGenerator::JITSubGenerator):
(JSC::JITSubGenerator::isLeftOperandValidConstant):
(JSC::JITSubGenerator::isRightOperandValidConstant):
(JSC::JITSubGenerator::arithProfile):
(JSC::JITSubGenerator::didEmitFastPath): Deleted.
(JSC::JITSubGenerator::endJumpList): Deleted.
(JSC::JITSubGenerator::slowPathJumpList): Deleted.
- 11:45 AM Changeset in webkit [203978] by
-
- 5 edits in trunk/PerformanceTests
Add an option to run the MotionMark tests with classic tile size (512x512)
https://bugs.webkit.org/show_bug.cgi?id=160371
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-01
Reviewed by Darin Adler.
Setting the body to large size (3000x3000) and overflow to scroll forces
the classic tile size (512x512). This option does not affect the canvas
tests because the canvas is displayed on one tile regardless of its size.
- Animometer/developer.html:
- Animometer/resources/debug-runner/animometer.css:
(body.showing-test-container.tiles-big):
(body.showing-test-container.tiles-classic):
- Animometer/resources/debug-runner/animometer.js:
- Animometer/resources/runner/animometer.js:
(window.benchmarkController.startBenchmark):
- 11:30 AM Changeset in webkit [203977] by
-
- 2 edits in trunk/LayoutTests
Update Apache configuration for Arch Linux
https://bugs.webkit.org/show_bug.cgi?id=160408
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2016-08-01
Reviewed by Ryosuke Niwa.
Arch Linux now ships Apache 2.4 and PHP 7, so the configuration file
used for the layout tests is updated to be compatible with the newer
versions.
- http/conf/archlinux-httpd.conf: Updated.
- 11:05 AM WebKitGTK/2.12.x edited by
- (diff)
- 11:00 AM Changeset in webkit [203976] by
-
- 5 edits2 adds in trunk
REGRESSION (r196383): Drop down CSS menus not working on cnet.com, apmex.com
https://bugs.webkit.org/show_bug.cgi?id=160390
Reviewed by Simon Fraser.
Source/WebCore:
The case here is that we have a rule like
.enableHover:hover .child { ... }
and the "enableHover" class is added dynamically. The class change invalidation optimization code would figure out
that nothing needs to be invalidated as the class change doesn't make the rule match (since :hover doesn't match).
However for event driven hover to actually work the hover element needs to have its childrenAffectedByHover bit set.
This bits is set when the selector match is attempted, whether it actually matches or not. Since we optimized away
the style invalidation we never set the bit either.
Fix by treating :hover as always matching (==ignored) when collecting rules for invalidation optimization purposes.
Dynamic pseudo elements are already treated this way for similar reasons.
Test: fast/selectors/hover-invalidation-descendant-dynamic.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
Match always in CollectingRulesIgnoringVirtualPseudoElements mode (now slightly misnamed).
This mode is used for optimization purposes in StyleInvalidationAnalysis (which we care about here) and
StyleSharingResolver. The change is fine for both.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
Same change for the slow path selector checker.
LayoutTests:
- fast/selectors/hover-invalidation-descendant-dynamic-expected.txt: Added.
- fast/selectors/hover-invalidation-descendant-dynamic.html: Added.
- 10:49 AM Changeset in webkit [203975] by
-
- 3 edits in trunk/Tools
Function Call on NULL Object
https://bugs.webkit.org/show_bug.cgi?id=160325
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-01
Reviewed by Darin Adler.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
- 10:49 AM Changeset in webkit [203974] by
-
- 3 edits4 adds in trunk/Source/WebCore
[Cocoa] Freeze Objective-C bindings and stop autogenerating them: Step 1 - Convert a single file
https://bugs.webkit.org/show_bug.cgi?id=160386
Reviewed by Anders Carlsson.
No behavior change, no tests changed. I tested this locally by putting "#error" into the
files in the DerivedSources directory to make sure the build doesn't use those files even
if there are stale copies still sitting there.
Moving the bindings from WebCore to the legacy part of WebKit is something we also want to
do, but that is quite challenging to do one file at a time, so we will do that later.
For this first file, I did some hand edits to make the code in a the file a little less
peculiar. It's still awkward to have all those JSMainThreadNullState in there; should double
check that we really need them.
An important follow up step will be to cut down on the bindings. We have lots of bindings
that are only in the Private.h header, and it would be good to find a way to cut down on those.
And on iOS we would like eliminate these bindings entirely since they are not API there.
- DerivedSources.make: Moved HTMLTextAreaElement from a list we use for both JavaScript and
Objective-C DOM bindings to a list we use only for JavaScript bindings.
- WebCore.xcodeproj/project.pbxproj: Removed references to generated DOMHTMLTextAreaElement
files and instead reference the checked-in copies.
- bindings/objc/DOMHTMLTextAreaElement.h: Added.
- bindings/objc/DOMHTMLTextAreaElement.mm: Added.
- bindings/objc/DOMHTMLTextAreaElementInternal.h: Added.
- bindings/objc/DOMHTMLTextAreaElementPrivate.h: Added.
- 6:34 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 12:44 AM Changeset in webkit [203973] by
-
- 8 edits2 copies in trunk/Source/WebCore
Introduce a RenderMathMLFencedOperator class
https://bugs.webkit.org/show_bug.cgi?id=160245
Patch by Frederic Wang <fwang@igalia.com> on 2016-08-01
Reviewed by Darin Adler.
We introduce a class to handle all the code specific to anonymous mfenced operators. In
particular many members of the RenderMathMLOperator class are going to be removed while
fixing bug 156537 but they may still need to stored and exposed in some way by mfenced
operators.
No new tests, behavior is unchanged.
- CMakeLists.txt: Add RenderMathMLFencedOperator.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMathMLFencedOperator): Function to allow casting to
RenderMathMLFencedOperator.
- rendering/mathml/RenderMathMLFenced.cpp: Use RenderMathMLFencedOperator instead of
RenderMathMLOperator and use the new name updateOperatorContent.
(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::createMathMLOperator):
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h: Use RenderMathMLFencedOperator instead of
RenderMathMLOperator.
- rendering/mathml/RenderMathMLFencedOperator.cpp: New class derived from RenderMathMLOperator
(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator): Init form and operator
flags with the specified parameters and init the text content.
(WebCore::RenderMathMLFencedOperator::updateOperatorContent): We move the
RenderMathMLOperator::updateTokenContent function used by anonymous operators here. It is
renamed to avoid build errors due to conflicts with the other
RenderMathMLOperator::updateTokenContent function.
- rendering/mathml/RenderMathMLFencedOperator.h: New class for anonymous mfenced operators
with getter and setter for the m_textContent. Also override RenderMathMLFencedOperator to
allow casting to RenderMathMLFencedOperator.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator): Simplify the constructors. Some
initializations is moved in RenderMathMLOperator.h while other code is moved to
RenderMathMLFencedOperator.
(WebCore::RenderMathMLOperator::textContent): No need to handle the anonymous case here since
it is handled in RenderMathMLFencedOperator.
(WebCore::RenderMathMLOperator::updateTokenContent): We delete the version used for anonymous
operators and move it into RenderMathMLFencedOperator.
- rendering/mathml/RenderMathMLOperator.h: Make the class and some members overridable and
exposed to the derived RenderMathMLFencedOperator class. We also move initialization of some
members here.
- 12:28 AM Changeset in webkit [203972] by
-
- 6 edits1 move1 add in trunk
We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372
Rubber stamped by Geoffrey Garen.
This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.
- JSTests/: Copied from Source/JavaScriptCore/tests.
- Source/JavaScriptCore/tests/: Deleted.
- Scripts/import-test262-tests:
- Scripts/run-javascriptcore-tests:
- Scripts/update-javascriptcore-test-res:
- 12:02 AM Changeset in webkit [203971] by
-
- 21 edits in trunk/Source/WebCore
Reduce the number of ResourceRequest copies in DocumentThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=160338
Patch by Youenn Fablet <youennf@gmail.com> on 2016-08-01
Reviewed by Darin Adler.
No observable change of behavior.
Updating one of CachedResourceReques constructor to take a ResourceRequest&&.
This allows reducing a ResourceRequest copy in DocumentThreadableLoader.
Updating DocumentLoader and MediaResourceLoader accordingly (future optimization steps may look at making these
two loaders more efficient with regards to Resource Request).
Updating ThreadableLoader to take a ResourceRequest&&.
This allows reducing the number of copies in DocumentThreadableLoader.
Updating clients of ThreadableLoader accordingly.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start):
- dom/Document.cpp:
(WebCore::Document::didLoadResourceSynchronously):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::didLoadResourceSynchronously):
- dom/ScriptExecutionContext.h:
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::loadResource):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadResourceSynchronously):
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
- loader/MediaResourceLoader.cpp:
(WebCore::MediaResourceLoader::requestResource):
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
- loader/ThreadableLoader.h:
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::loadResourceSynchronously):
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::create):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest):
- loader/cache/CachedResourceRequest.h:
- page/EventSource.cpp:
(WebCore::EventSource::connect):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Jul 31, 2016:
- 11:51 PM Changeset in webkit [203970] by
-
- 13 edits2 adds in branches/safari-602-branch
Merge r203842. rdar://problem/27553464
- 11:51 PM Changeset in webkit [203969] by
-
- 3 edits4 adds in branches/safari-602-branch
Merge r203931. rdar://problem/27317407
- 11:51 PM Changeset in webkit [203968] by
-
- 5 edits2 adds in branches/safari-602-branch
Merge r203928. rdar://problem/27179484
- 11:51 PM Changeset in webkit [203967] by
-
- 3 edits2 adds in branches/safari-602-branch
Merge r203924. rdar://problem/27355214
- 11:51 PM Changeset in webkit [203966] by
-
- 6 edits in branches/safari-602-branch
Merge r203916. rdar://problem/27594995
- 11:51 PM Changeset in webkit [203965] by
-
- 11 edits2 adds in branches/safari-602-branch
Merge r203913. rdar://problem/27558003
- 11:51 PM Changeset in webkit [203964] by
-
- 2 edits in branches/safari-602-branch/Source/WebKit2
Merge r203909. rdar://problem/27078089
- 11:51 PM Changeset in webkit [203963] by
-
- 2 edits in branches/safari-602-branch/Tools
Merge r203905. rdar://problem/27610246
- 11:51 PM Changeset in webkit [203962] by
-
- 4 edits in branches/safari-602-branch/Source/WebCore
Merge r203799. rdar://problem/27556788
- 11:00 PM Changeset in webkit [203961] by
-
- 5 edits in trunk
Fetch Response built-ins should use @makeThisTypeError
https://bugs.webkit.org/show_bug.cgi?id=160290
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-31
Reviewed by Darin Adler.
Source/WebCore:
Covered by updated test.
Fixed type error checks.
Making use of @makeThisTypeError to have the correct error message.
Updating arrayBuffer, blob, json and text to return rejected promises in lieu of throwing
in case the 'this' value is not q Response object.
- Modules/fetch/FetchResponse.js:
(clone): Updated instanceof check and making use of @makeThisTypeError.
(arrayBuffer): Ditto.
(blob): Ditto.
(formData): Ditto.
(json): Ditto.
(text): Ditto.
LayoutTests:
- fetch/fetch-error-messages-expected.txt:
- fetch/fetch-error-messages.html:
- 10:43 PM Changeset in webkit [203960] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Implement missing WebCore::moveFile() using GLib functions
https://bugs.webkit.org/show_bug.cgi?id=160363
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2016-07-31
Reviewed by Carlos Garcia Campos.
- platform/glib/FileSystemGlib.cpp:
(WebCore::moveFile): Function added.
- 7:13 PM Changeset in webkit [203959] by
-
- 5 edits in tags/Safari-602.1.44.0.1/Source
Versioning.
- 7:11 PM Changeset in webkit [203958] by
-
- 1 copy in tags/Safari-602.1.44.0.1
New tag.
- 5:37 PM Changeset in webkit [203957] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Should check Test262Error correctly
https://bugs.webkit.org/show_bug.cgi?id=159862
Reviewed by Saam Barati.
Test262Error in the harness does not have "name" property.
Rather than checking "name" property, peforminginstanceofis better to check the class of the exception.
- jsc.cpp:
(checkUncaughtException):
- runtime/JSObject.h:
- tests/test262.yaml:
- 4:36 PM Changeset in webkit [203956] by
-
- 29 edits in trunk/Source/WebCore
Drop [StrictTypeChecking] in cases where it is a no-op
https://bugs.webkit.org/show_bug.cgi?id=160387
Reviewed by Darin Adler.
Drop [StrictTypeChecking] in cases where it is a no-op. After r203949 & r203950,
[StrictTypeChecking] only has an impact when used on operation parameters of
string types and is currently used as a workaround for bugs in our overload
resolution algorithm.
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCRtpSender.idl:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestTypedefs.idl:
- html/canvas/ANGLEInstancedArrays.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGL2RenderingContext.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLLoseContext.idl:
- html/canvas/WebGLRenderingContextBase.idl:
- svg/SVGAngle.idl:
- svg/SVGColor.idl:
- svg/SVGLength.idl:
- svg/SVGLengthList.idl:
- svg/SVGMatrix.idl:
- svg/SVGNumberList.idl:
- svg/SVGPaint.idl:
- svg/SVGPathSegList.idl:
- svg/SVGPoint.idl:
- svg/SVGPointList.idl:
- svg/SVGStringList.idl:
- svg/SVGTransform.idl:
- svg/SVGTransformList.idl:
- 1:02 PM Changeset in webkit [203955] by
-
- 9 edits2 adds in trunk
AX: Add a check for touch event listener on iOS accessibility object
https://bugs.webkit.org/show_bug.cgi?id=160388
Reviewed by Chris Fleizach.
Source/WebCore:
dispatchTouchEvent() is not working correctly within AXPress() sometimes. Need to
investigate it more in the future. Now, adding a check for the touch event listener
on the object's node so that iOS can handle dispatching the touch event instead.
Test: accessibility/ios-simulator/has-touch-event-listener.html
- accessibility/AccessibilityObject.h:
- accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
(WebCore::AccessibilityObject::hasTouchEventListener):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(appendStringToResult):
(-[WebAccessibilityObjectWrapper _accessibilityHasTouchEventListener]):
(-[WebAccessibilityObjectWrapper _accessibilityValueIsAutofilled]):
Tools:
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::boolAttributeValue):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::boolAttributeValue):
LayoutTests:
- accessibility/ios-simulator/has-touch-event-listener-expected.txt: Added.
- accessibility/ios-simulator/has-touch-event-listener.html: Added.
- 1:31 AM Changeset in webkit [203954] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][Unix] Implement missing WebKit::SharedMemory::create() function
https://bugs.webkit.org/show_bug.cgi?id=160364
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2016-07-31
Reviewed by Carlos Garcia Campos.
The WebKit::SharedMemory::create() function is missing for the Unix
platform, which is also used by the GTK+ port. The latter is going
to need this in place to use the common content filtering code.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::accessModeMMap): Added helper function to convert a
SharedMemory::Protection value into flags useable with mmap().
(WebKit::SharedMemory::create): Added. Implementation reuses code
existing in the SharedMemory::allocate() function.
(WebKit::SharedMemory::allocate): Reimplemented in terms of
SharedMemory::create().
- 12:04 AM Changeset in webkit [203953] by
-
- 11 edits1 copy3 adds in trunk/Source/JavaScriptCore
[ES6] Module binding can be exported by multiple names
https://bugs.webkit.org/show_bug.cgi?id=160343
Reviewed by Saam Barati.
ES6 Module can export the same local binding by using multiple names.
For example,
`
var value = 42;
export { value };
export { value as value2 };
`
Currently, we only allowed one local binding to be exported with one name. So, in the above case,
the local binding "value" is exported as "value2" and "value" name is not exported. This is wrong.
To fix this issue, we collect the correspondence (local name => exported name) to the local bindings
in the parser. Previously, we only maintained the exported local bindings in the parser. And utilize
this information when creating the export entries in ModuleAnalyzer.
And this patch also moves ModuleScopeData from the Scope object to the Parser class since exported
names should be managed per-module, not per-scope.
This change fixes several test262 failures.
- JavaScriptCore.xcodeproj/project.pbxproj:
- parser/ModuleAnalyzer.cpp:
(JSC::ModuleAnalyzer::exportVariable):
(JSC::ModuleAnalyzer::analyze):
(JSC::ModuleAnalyzer::exportedBinding): Deleted.
(JSC::ModuleAnalyzer::declareExportAlias): Deleted.
- parser/ModuleAnalyzer.h:
- parser/ModuleScopeData.h: Copied from Source/JavaScriptCore/parser/ModuleAnalyzer.h.
(JSC::ModuleScopeData::create):
(JSC::ModuleScopeData::exportedBindings):
(JSC::ModuleScopeData::exportName):
(JSC::ModuleScopeData::exportBinding):
- parser/Nodes.cpp:
(JSC::ProgramNode::ProgramNode):
(JSC::ModuleProgramNode::ModuleProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionNode::FunctionNode):
- parser/Nodes.h:
(JSC::ModuleProgramNode::moduleScopeData):
- parser/NodesAnalyzeModule.cpp:
(JSC::ExportDefaultDeclarationNode::analyzeModule):
(JSC::ExportNamedDeclarationNode::analyzeModule): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseModuleSourceElements):
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClassDeclaration):
(JSC::Parser<LexerType>::parseExportSpecifier):
(JSC::Parser<LexerType>::parseExportDeclaration):
- parser/Parser.h:
(JSC::Parser::exportName):
(JSC::Parser<LexerType>::parse):
(JSC::ModuleScopeData::create): Deleted.
(JSC::ModuleScopeData::exportedBindings): Deleted.
(JSC::ModuleScopeData::exportName): Deleted.
(JSC::ModuleScopeData::exportBinding): Deleted.
(JSC::Scope::Scope): Deleted.
(JSC::Scope::setSourceParseMode): Deleted.
(JSC::Scope::moduleScopeData): Deleted.
(JSC::Scope::setIsModule): Deleted.
- tests/modules/aliased-names.js: Added.
- tests/modules/aliased-names/main.js: Added.
(change):
- tests/stress/modules-syntax-error-with-names.js:
(export.Cocoa):
(SyntaxError.Cannot.export.a.duplicate.name):
- tests/test262.yaml:
Jul 30, 2016:
- 6:08 PM Changeset in webkit [203952] by
-
- 5 edits2 adds in trunk
Assertion failure while setting the length of an ArrayClass array.
https://bugs.webkit.org/show_bug.cgi?id=160381
<rdar://problem/27328703>
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
When setting large length values, we're currently treating ArrayClass as a
ContiguousIndexingType array. This results in an assertion failure. This is
now fixed.
There are currently only 2 places where we create arrays with indexing type
ArrayClass: ArrayPrototype and RuntimeArray. The fix in JSArray:;setLength()
takes care of ArrayPrototype.
RuntimeArray already checks for the setting of its length property, and will
throw a RangeError. Hence, there's no change is needed for the RuntimeArray.
Instead, I added some test cases ensure that the check and throw behavior does
not change without notice.
- runtime/JSArray.cpp:
(JSC::JSArray::setLength):
- tests/stress/array-setLength-on-ArrayClass-with-large-length.js: Added.
(toString):
(assertEqual):
- tests/stress/array-setLength-on-ArrayClass-with-small-length.js: Added.
(toString):
(assertEqual):
LayoutTests:
Test that RuntimeArrays will throw an error if we try to set its length.
- platform/mac/fast/dom/wrapper-classes-objc.html:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- 5:46 PM Changeset in webkit [203951] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed, rebaseline bindings tests.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property): Deleted.
(webkit_dom_test_obj_get_property): Deleted.
(webkit_dom_test_obj_class_init): Deleted.
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjStrictTypeCheckingAttribute): Deleted.
(WebCore::jsTestObjStrictFloat): Deleted.
(WebCore::setJSTestObjStrictTypeCheckingAttribute): Deleted.
(WebCore::setJSTestObjStrictFloat): Deleted.
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj strictTypeCheckingAttribute]): Deleted.
(-[DOMTestObj setStrictTypeCheckingAttribute:]): Deleted.
(-[DOMTestObj strictFloat]): Deleted.
(-[DOMTestObj setStrictFloat:]): Deleted.
- 5:29 PM Changeset in webkit [203950] by
-
- 18 edits in trunk
Enable strict type checking for Window dictionary members
https://bugs.webkit.org/show_bug.cgi?id=160356
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt:
Source/WebCore:
Enable strict type checking for Window dictionary members. Technically,
we should do strict type checking of all wrapper types but this patch
focuses on Window because it is common to pass a Window dictionary
member to Event constructors.
By strict type checking, I mean that we should throw a TypeError is
the value is not null/undefined and does not implement the Window
interface:
Firefox and Chrome comply with the specification already.
No new tests, updated / rebaselined existing tests.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
LayoutTests:
Update existing tests to reflect behavior change.
- fast/events/constructors/composition-event-constructor-expected.txt:
- fast/events/constructors/composition-event-constructor.html:
- fast/events/constructors/focus-event-constructor-expected.txt:
- fast/events/constructors/focus-event-constructor.html:
- fast/events/constructors/keyboard-event-constructor-expected.txt:
- fast/events/constructors/keyboard-event-constructor.html:
- fast/events/constructors/mouse-event-constructor.html:
- fast/events/constructors/ui-event-constructor-expected.txt:
- fast/events/constructors/ui-event-constructor.html:
- fast/events/constructors/wheel-event-constructor.html:
- platform/mac/fast/events/constructors/mouse-event-constructor-expected.txt:
- platform/mac/fast/events/constructors/wheel-event-constructor-expected.txt:
- resources/js-test-pre.js:
Add a shouldThrowErrorName() utility function that is similar to shouldThrow()
but only checks the error name instead of the full error message. Checking
only the error name has the benefit of working across browsers and facilitating
refactoring of error messages.
- 5:23 PM Changeset in webkit [203949] by
-
- 43 edits in trunk
[WebIDL] Enable strict type checking for nullable attribute setters of wrapper types
https://bugs.webkit.org/show_bug.cgi?id=160375
Reviewed by Darin Adler.
Source/WebCore:
Enable strict type checking for nullable attribute setters of wrapper types:
For such attributes, if the JS tries to assign a value that is not null /
undefined and does not have the expected wrapper type, then we now throw a
TypeError instead of silently converting the value to null.
This behavior is consistent with Chrome and Firefox. It also helps identify
bugs in JavaScript code.
No new tests, updated existing tests.
- Modules/webaudio/AudioBufferSourceNode.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjTestNullableObjAttr):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
- bindings/scripts/test/TestObj.idl:
- dom/Document.idl:
- html/HTMLTableElement.idl:
- svg/SVGAngle.idl:
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.idl:
- svg/SVGAnimatedNumber.idl:
- svg/SVGLength.idl:
- svg/SVGMatrix.idl:
- svg/SVGNumber.idl:
- svg/SVGPathSegArcAbs.idl:
- svg/SVGPathSegArcRel.idl:
- svg/SVGPathSegCurvetoCubicAbs.idl:
- svg/SVGPathSegCurvetoCubicRel.idl:
- svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
- svg/SVGPathSegCurvetoCubicSmoothRel.idl:
- svg/SVGPathSegCurvetoQuadraticAbs.idl:
- svg/SVGPathSegCurvetoQuadraticRel.idl:
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
- svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
- svg/SVGPathSegLinetoAbs.idl:
- svg/SVGPathSegLinetoHorizontalAbs.idl:
- svg/SVGPathSegLinetoHorizontalRel.idl:
- svg/SVGPathSegLinetoRel.idl:
- svg/SVGPathSegLinetoVerticalAbs.idl:
- svg/SVGPathSegLinetoVerticalRel.idl:
- svg/SVGPathSegMovetoAbs.idl:
- svg/SVGPathSegMovetoRel.idl:
- svg/SVGPoint.idl:
- svg/SVGPreserveAspectRatio.idl:
- svg/SVGRect.idl:
LayoutTests:
Rebaseline / update existing tests to reflect behavior change.
- fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt:
- fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html:
- webaudio/convolver-setBuffer-null-expected.txt:
- webaudio/convolver-setBuffer-null.html:
- 2:12 PM Changeset in webkit [203948] by
-
- 2 edits in branches/safari-602-branch/LayoutTests
Merge r203947.
2016-07-30 Alexey Proskuryakov <ap@apple.com>
macOS Sierra test result gardening for media/video-loop.html.
- platform/mac/TestExpectations:
- 2:08 PM Changeset in webkit [203947] by
-
- 2 edits in trunk/LayoutTests
macOS Sierra test result gardening for media/video-loop.html.
- platform/mac/TestExpectations:
- 1:33 PM Changeset in webkit [203946] by
-
- 2 edits in branches/safari-602-branch/LayoutTests
Merge r203945.
2016-07-30 Alexey Proskuryakov <ap@apple.com>
macOS Sierra test result gardening.
- platform/mac-wk1/TestExpectations:
- 1:30 PM Changeset in webkit [203945] by
-
- 2 edits in trunk/LayoutTests
macOS Sierra test result gardening.
- platform/mac-wk1/TestExpectations:
- 12:27 PM Changeset in webkit [203944] by
-
- 2 edits in trunk/Source/WebKit2
[Xcode] WebKit.framework is touched on incremental build even if nothing’s changed
https://bugs.webkit.org/show_bug.cgi?id=160383
Reviewed by Tim Horton.
- WebKit2.xcodeproj/project.pbxproj: Removed the output files listed under the Copy iOS Sandbox Profiles for Manual Sandboxing script build phase, because it doesn’t produce those files on macOS. With no outputs listed, the script will still run every time, but the fact that it has run won’t trigger touching the framework.
- 12:27 PM Changeset in webkit [203943] by
-
- 4 edits2 adds in trunk
Synchronous preflight should check for successful responses
https://bugs.webkit.org/show_bug.cgi?id=159350
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-30
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/xmlhttprequest/access-control-preflight-not-successful.html
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::doPreflight): Adding successful response check for synchronous
preflighting.
LayoutTests:
- http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt: Added.
- http/tests/xmlhttprequest/access-control-preflight-not-successful.html: Added, not all tests are passing as CORS checks.
for redirections are not well supported for synchronous loading.
- http/tests/xmlhttprequest/resources/status-404-without-body.php:
- 7:16 AM Changeset in webkit [203942] by
-
- 2 edits in trunk/Tools
Unreviewed: add myself to the reviewers list.
- Scripts/webkitpy/common/config/contributors.json:
- 1:35 AM Changeset in webkit [203941] by
-
- 24 edits in trunk
[WebIDL] Enable strict type checking for operations' nullable parameters of wrapper types
https://bugs.webkit.org/show_bug.cgi?id=160374
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
Source/WebCore:
Enable strict type checking for operations' nullable parameters of
wrapper types to comply with the Web IDL specification:
For such parameters, if the JS passes a value that is not null /
undefined and does not have the expected wrapper type, then we now
throw a TypeError instead of silently converting the value to null.
This behavior is consistent with Chrome and Firefox. It also helps
identify bugs in JavaScript code.
No new tests, rebaselined existing tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapper):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalNullableWrapperIsNull):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalXPathNSResolver):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter2):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): Deleted.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod): Deleted.
(WebCore::jsTestObjPrototypeFunctionOrange): Deleted.
LayoutTests:
Update / rebaseline existing tests to reflect behavior change. Also fix
several bugs in tests that became obvious now that we throw.
- editing/execCommand/indent-pre-expected.txt:
- editing/execCommand/indent-pre.html:
- editing/selection/4895428-2.html:
- editing/selection/move-by-word-visually-null-box.html:
- fast/dom/DOMImplementation/detached-doctype.html:
- fast/dom/MutationObserver/observe-attributes.html:
- fast/dom/Node/contains-method-expected.txt:
- fast/dom/Node/script-tests/contains-method.js:
- fast/dom/Window/webkitConvertPoint.html:
- fast/dom/adopt-node-crash-2.html:
- fast/dom/incompatible-operations-expected.txt:
- fast/dom/incompatible-operations.html:
- fast/events/selectstart-by-arrow-keys.html:
- fast/images/image-copy-memory-usage.html:
- fast/xsl/xslt-processor-expected.txt:
- http/tests/misc/webtiming-cross-origin-and-back1.html:
- platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt:
- svg/custom/unicode-in-tspan-multi-svg-crash.html:
Jul 29, 2016:
- 11:39 PM Changeset in webkit [203940] by
-
- 4 edits in trunk/Tools
Undo r203939, and copy over a rule that clips the logos.
Sierra wasn't the only logo without transparency.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
- 9:42 PM Changeset in webkit [203939] by
-
- 3 edits in trunk/Tools
The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
https://bugs.webkit.org/show_bug.cgi?id=160377
Patch by Alan Sien Wei Hshieh <hshieh@apple.com> on 2016-07-29
Reviewed by Brian Weinstein.
Update assets to remove the white background and use a transparent background instead.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
- 8:22 PM Changeset in webkit [203938] by
-
- 12 edits in trunk/Source/ThirdParty/ANGLE
ANGLE: Fix global constructors and exit-time destructors
<https://webkit.org/b/160332>
Reviewed by Darin Adler.
- Configurations/Base.xcconfig:
- Add warning flags.
- src/common/angleutils.cpp:
(FormatString):
- src/common/angleutils.h:
(MakeStaticString):
- src/common/debug.cpp:
- src/common/mathutil.cpp:
(gl::g_sharedexp_max):
(gl::convertRGBFloatsTo999E5):
- src/compiler/translator/ShaderLang.cpp:
(ShGetUniformRegisterMap):
- src/libANGLE/Caps.cpp:
(gl::TextureCapsMap::get):
- src/libANGLE/Device.cpp:
(egl::GetDeviceSet):
- src/libANGLE/Display.cpp:
(egl::Display::getClientExtensionString):
- src/libANGLE/formatutils.cpp:
(gl::BuildFormatMap):
(gl::BuildInternalFormatInfoMap):
(gl::GetInternalFormatMap):
(gl::BuildAllSizedInternalFormatSet):
(gl::GetSizedInternalFormat):
(gl::GetAllSizedInternalFormats):
- src/libANGLE/validationES3.cpp:
(gl::BuildES3FormatSet):
(gl::ValidateTexImageFormatCombination):
(gl::BuildSizedEffectiveInternalFormatList):
(gl::BuildUnsizedEffectiveInternalFormatList):
(gl::GetEffectiveInternalFormat):
(gl::BuildValidES3CopyTexImageCombinations):
(gl::IsValidES3CopyTexImageCombination):
- Fix global constructors and exit-time destructors.
- 7:02 PM Changeset in webkit [203937] by
-
- 3 edits in trunk/Source/JavaScriptCore
TypedArray super constructor has some incompatabilities
https://bugs.webkit.org/show_bug.cgi?id=160369
Reviewed by Filip Pizlo.
This patch fixes the length proprety of the TypedArray super constructor.
Additionally, the TypedArray super constructor should no longer be callable.
Also, this patch fixes the expected result of some test262 tests.
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
(JSC::constructTypedArrayView):
(JSC::JSTypedArrayViewConstructor::getCallData):
- tests/test262.yaml:
- 6:25 PM Changeset in webkit [203936] by
-
- 2 edits in trunk/Tools
Ignore most check-webkit-style checks for ANGLE project
<https://webkit.org/b/160333>
Reviewed by Daniel Bates.
- Scripts/webkitpy/style/checker.py: Ignore all checkers except:
- No tabs.
- No spaces at the end of lines.
- No carriage returns (DOS line endings).
- 6:08 PM Changeset in webkit [203935] by
-
- 15 edits2 adds in trunk
Window's named properties should be exposed on a WindowProperties object in its prototype
https://bugs.webkit.org/show_bug.cgi?id=160354
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Window's named properties should be exposed on a WindowProperties object
in its prototype:
Firefox and Chrome both comply with the specification. However, WebKit
had no "WindowProperties" object in the Window prototype chain and the
named properties are exposed on the Window object itself.
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess): Deleted.
(WebCore::JSDOMWindow::put): Deleted.
(WebCore::JSDOMWindow::putByIndex): Deleted.
(WebCore::JSDOMWindow::getEnumerableLength): Deleted.
- bindings/js/JSDOMWindowProperties.cpp: Added.
(WebCore::jsDOMWindowPropertiesGetOwnPropertySlotNamedItemGetter):
(WebCore::JSDOMWindowProperties::getOwnPropertySlot):
(WebCore::JSDOMWindowProperties::getOwnPropertySlotByIndex):
- bindings/js/JSDOMWindowProperties.h: Added.
(WebCore::JSDOMWindowProperties::create):
(WebCore::JSDOMWindowProperties::createStructure):
(WebCore::JSDOMWindowProperties::JSDOMWindowProperties):
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
LayoutTests:
- fast/dom/Window/es52-globals-expected.txt:
Update / Rebaseline test now that named properties are no longer reported as "own"
properties on the Window object. I have verified that the test gives the
same result in Firefox and Chrome.
- fast/loader/window-clearing-expected.txt:
Rebaseline test that prints one more line because there is one more
object in Window's prototype chain.
- http/tests/security/window-named-proto-expected.txt:
- http/tests/security/window-named-valueOf-expected.txt:
Rebaseline 2 security tests that give slightly different output. The new
output is identical to the one in Firefox and Chrome. The tests are not
failing since they are not alert'ing content from the other frame.
The reason those tests were logging a security error is because we would
previously prevent named property access if the frame name conflicts with
a property name in the Window prototype, and we now no longer
differentiate this case.
- 5:54 PM Changeset in webkit [203934] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/xmlhttprequest/workers/methods-async.html as flaky on ios-simulator release WK2
https://bugs.webkit.org/show_bug.cgi?id=160368
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 5:53 PM Changeset in webkit [203933] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 5:39 PM Changeset in webkit [203932] by
-
- 3 edits1 copy1 move in trunk/LayoutTests
Rebaseline fast/block/float/overhanging-tall-block.html for Sierra.
Unreviewed test gardening.
- platform/mac-elcapitan/fast/block/float/overhanging-tall-block-expected.png: Renamed from LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.png.
- platform/mac-elcapitan/fast/block/float/overhanging-tall-block-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt.
- platform/mac/TestExpectations:
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
- 5:30 PM Changeset in webkit [203931] by
-
- 3 edits4 adds in trunk
Crash under HTMLMediaElement::{resolve, reject}PendingPlayPromises() when playback is interrupted
https://bugs.webkit.org/show_bug.cgi?id=160366
<rdar://problem/27317407>
Reviewed by Eric Carlson.
Source/WebCore:
Fixes a crash/assertion failure in DeferredWrapper::{resolve, rejectWithValue}() caused by a Promise
being settled twice. In particular, if a system interruption occurs when media.play() is invoked
the returned Promise may ultimately be settled twice upon cessation of the interruption.
A Promise can be settled (resolved) exactly once. When a system interruption occurs media
playback is paused and resumes on cessation of the interruption. Currently we also immediately
reject the Promise p retuned by media.play() if the interruption occurs during its invocation.
So, when we resume playback on cessation of an interruption we try to resolve p again. But a
Promise can only be resolved once and hence we violate the assertions that p has both a valid
reference to a JSPromiseDeferred object and a reference to the global object of the page.
Tests: media/non-existent-video-playback-interrupted.html
media/video-playback-interrupted.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::play): Modified to reject the Promise and return immediately if
playInternal() returns false.
(WebCore::HTMLMediaElement::playInternal): Treat an interruption as success and return true
so that HTMLMediaElement::play() adds the Promise to the end of the list of pending promises.
We treat an interruption as a success because we will resume playback (assuming the media
can be loaded and is well-formed) upon cessation of the interruption and therefore can either
fulfill or reject the Promise object returned by media.play().
LayoutTests:
- media/non-existent-video-playback-interrupted-expected.txt: Added.
- media/non-existent-video-playback-interrupted.html: Added.
- media/video-playback-interrupted-expected.txt: Added.
- media/video-playback-interrupted.html: Added.
- 5:13 PM Changeset in webkit [203930] by
-
- 2 edits in trunk/Source/WebCore
[iOS] HTMLMediaElement::updateVolume() calls MediaPlayer::volume() on null media player
https://bugs.webkit.org/show_bug.cgi?id=160353
Reviewed by Eric Carlson.
Using testing functions HTMLMediaElement::updateVolume() can be called on a <video> element
without an associated video. We should support this usage on iOS just as we do for non-iOS
ports.
The use of testing functions to call HTMLMediaElement::updateVolume() on a <video> element
without an associated video is demonstrated by the test LayoutTests/media/video-muted-after-setting-page-muted-state.html.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateVolume):
- 5:11 PM Changeset in webkit [203929] by
-
- 2 edits in trunk/LayoutTests
Land test expectations for rdar://problem/27611932.
- platform/mac-wk1/TestExpectations:
- 5:11 PM Changeset in webkit [203928] by
-
- 5 edits2 adds in trunk
Media controls are not displayed for some autoplaying videos at certain browser dimensions
https://bugs.webkit.org/show_bug.cgi?id=160360
<rdar://problem/27179484>
Reviewed by Myles C. Maxfield.
Source/WebCore:
Previously, if a video's aspect ratio fell outside of the range [0.5, 1.8], we would
not consider it main content and would subsequently not show media controls for it.
This meant that on many websites that scale video dimensions to match the mainframe,
if the mainframe is too wide (e.g. full bounds on a widescreen display) we would not
consider the video to be main content. To fix this, we only consider aspect ratio to
be a requirement if the video does not already take up most of the space in the
mainframe.
Covered by two new TestWebKitAPI unit tests.
- html/MediaElementSession.cpp:
(WebCore::isElementLargeRelativeToMainFrame):
(WebCore::isElementLargeEnoughForMainContent):
Tools:
Adds two tests verifying that videos may be considered main content as long as they
are large enough and cover a majority of the mainframe's viewport.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
- 5:07 PM Changeset in webkit [203927] by
-
- 2 edits23 adds in trunk/LayoutTests
Test gardening on ios-simualtor after some media tests were unskipped in r203906.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/media/audio-controls-rendering-expected.txt: Added.
- platform/ios-simulator/media/audio-repaint-expected.txt: Added.
- platform/ios-simulator/media/controls-strict-expected.txt: Added.
- platform/ios-simulator/media/controls-styling-strict-expected.txt: Added.
- platform/ios-simulator/media/controls-without-preload-expected.txt: Added.
- platform/ios-simulator/media/media-controls-clone-expected.txt: Added.
- platform/ios-simulator/media/track/track-cue-rendering-horizontal-expected.txt: Added.
- platform/ios-simulator/media/track/track-cue-rendering-vertical-expected.txt: Added.
- platform/ios-simulator/media/video-aspect-ratio-expected.txt: Added.
- platform/ios-simulator/media/video-controls-captions-trackmenu-expected.txt: Added.
- platform/ios-simulator/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
- platform/ios-simulator/media/video-controls-captions-trackmenu-localized-expected.txt: Added.
- platform/ios-simulator/media/video-controls-captions-trackmenu-sorted-expected.txt: Added.
- platform/ios-simulator/media/video-controls-rendering-expected.txt: Added.
- platform/ios-simulator/media/video-display-toggle-expected.txt: Added.
- platform/ios-simulator/media/video-empty-source-expected.txt: Added.
- platform/ios-simulator/media/video-layer-crash-expected.txt: Added.
- platform/ios-simulator/media/video-no-audio-expected.txt: Added.
- platform/ios-simulator/media/video-transformed-expected.txt: Added.
- platform/ios-simulator/media/video-volume-slider-expected.txt: Added.
- platform/ios-simulator/media/video-zoom-controls-expected.txt: Added.
- platform/ios-simulator/media/video-zoom-expected.txt: Added.
- 5:07 PM Changeset in webkit [203926] by
-
- 1 copy in tags/Safari-602.1.44
New tag.
- 4:42 PM Changeset in webkit [203925] by
-
- 2 edits in trunk/Source/JavaScriptCore
Undefined Behavior in JSValue cast from NaN
https://bugs.webkit.org/show_bug.cgi?id=160322
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-07-29
Reviewed by Mark Lam.
JSValues can be constructed from doubles, and in some cases, are deliberately constructed with NaN values.
In circumstances where NaN is bound through the default JSValue constructor, however, an undefined conversion
to int32_t occurs. While the subsequent if statement should fail and construct the JSValue through the explicit
double constructor, given that the deliberate use of NaN is fairly common, it seems that the jsNaN() function
should immediately call the explicit double constructor both for efficiency and to prevent inadvertent
suppressing of any other bugs which may be instantiating a JSValue with a NaN double.
- runtime/JSCJSValueInlines.h:
(JSC::jsNaN): Explicit double construction for NaN JSValues to avoid undefined behavior.
- 4:41 PM Changeset in webkit [203924] by
-
- 3 edits2 adds in trunk
Do not set negative rate on AVSampleBufferRenderSynchronizer.
https://bugs.webkit.org/show_bug.cgi?id=160326
<rdar://problem/27355214>
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setRateDouble):
LayoutTests:
Negative rate is not supported at the moment.
- http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control-expected.txt: Added.
- http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html: Added.
- 3:04 PM Changeset in webkit [203923] by
-
- 7 edits in trunk/Source/JavaScriptCore
Refactor DFG::Node::hasLocal() to accessesStack()
https://bugs.webkit.org/show_bug.cgi?id=160357
Reviewed by Filip Pizlo.
Refactoring in preparation for using register arguments for JavaScript calls.
Renamed Node::hasLocal() to Node::accessesStack() and changed all uses accordingly.
Also changed uses of Node::hasVariableAccessData() to accessesStack() where that
use guards stack operation logic associated with the Node's VariableAccessData.
The hasVariableAccessData() check now implies no more than the node has a
VariableAccessData and nothing about its use of that data to coordinate stack
accesses.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
- dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock):
- dfg/DFGMaximalFlushInsertionPhase.cpp:
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):
- dfg/DFGNode.h:
(JSC::DFG::Node::containsMovHint):
(JSC::DFG::Node::accessesStack):
(JSC::DFG::Node::hasLocal): Deleted.
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- dfg/DFGValidate.cpp:
- 3:01 PM Changeset in webkit [203922] by
-
- 4 edits in trunk/LayoutTests
[macOS Sierra] Test gardening after r198859
https://bugs.webkit.org/show_bug.cgi?id=160358
<rdar://problem/26422274>
Reviewed by Zalan Bujtas.
RTL Scrollbars are not enabled on WK1, so this test should be marked in the
same way as all the other RTL scrollbars tests.
- TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 1:58 PM Changeset in webkit [203921] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] Use the same data structures for DFG and Air Liveness Analysis
https://bugs.webkit.org/show_bug.cgi?id=160346
Reviewed by Geoffrey Garen.
In Air, we minimized memory accesses during liveness analysis
with a couple of tricks:
-Use a single Sparse Set ADT for the live value of each block.
-Manipulate compact positive indices instead of hashing values.
This patch brings the same ideas to DFG.
This patch still uses the same fixpoint algorithms.
The reason is Edge's KillStatus used by other phases. We cannot
use a block-boundary liveness algorithm and update KillStatus
simultaneously. It's something I'll probably revisit at some point.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::forAllValues):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::dump):
- dfg/DFGBasicBlock.h:
- dfg/DFGGraph.h:
(JSC::DFG::Graph::maxNodeCount):
(JSC::DFG::Graph::nodeAt):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::setLiveValues):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
- dfg/DFGLivenessAnalysisPhase.cpp:
(JSC::DFG::LivenessAnalysisPhase::LivenessAnalysisPhase):
(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::processBlock):
(JSC::DFG::LivenessAnalysisPhase::addChildUse):
(JSC::DFG::LivenessAnalysisPhase::process): Deleted.
- 1:43 PM Changeset in webkit [203920] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Inactive/active network bar segments overlap when latency is zero
https://bugs.webkit.org/show_bug.cgi?id=160147
<rdar://problem/27516007>
Reviewed by Joseph Pecoraro.
TimelineRecordBar should hide the inactive segment when its duration
is less than the minimum displayable size. The active segment can
assume the whole width of the bar.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype.get secondsPerPixel):
Make secondsPerPixel available during TimelineRecordBars.refresh.
- UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.prototype.refresh):
Check inactive duration against the minimum display size,
and add/remove DOM nodes and bar styles as needed.
- 1:29 PM Changeset in webkit [203919] by
-
- 2 edits in trunk/LayoutTests
Remove a Sierra specific expectation for http/tests/navigation/forward-and-cancel.html,
we already have an identical one in platform/mac.
- platform/mac-wk1/TestExpectations:
- 1:18 PM Changeset in webkit [203918] by
-
- 2 edits in trunk/LayoutTests
Skip some media tests that fail on iOS
- platform/ios-simulator/TestExpectations:
- 12:46 PM Changeset in webkit [203917] by
-
- 2 edits in trunk/LayoutTests
[macOS Sierra] Unskip new emoji group candidates tests
https://bugs.webkit.org/show_bug.cgi?id=160351
<rdar://problem/27430381>
Reviewed by Alexey Proskuryakov.
- platform/mac/TestExpectations:
- 12:45 PM Changeset in webkit [203916] by
-
- 6 edits in trunk
Backspace key removes only the rainbow from the rainbow flag
https://bugs.webkit.org/show_bug.cgi?id=160349
<rdar://problem/27594995>
Reviewed by Dean Jackson.
Source/WebCore:
In r203330 I added support for new emoji group candidates. I accidentally
missed one of the new emoji code points.
Test: editing/deleting/delete-emoji.html
- platform/text/CharacterProperties.h:
(WebCore::isEmojiGroupCandidate):
LayoutTests:
- platform/mac/editing/deleting/delete-emoji-expected.txt:
- platform/mac-yosemite/editing/deleting/delete-emoji-expected.txt:
- platform/ios-simulator/editing/deleting/delete-emoji-expected.txt:
- 12:27 PM Changeset in webkit [203915] by
-
- 2 edits in trunk/Tools
Gardening: removed unused variable.
Not reviewed.
- TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- 12:19 PM Changeset in webkit [203914] by
-
- 5 edits in branches/safari-602-branch/Source/WebCore
Merge r203904. rdar://problem/27610935
- 12:11 PM Changeset in webkit [203913] by
-
- 11 edits2 adds in trunk
AX: Media controls accessibility improvement
https://bugs.webkit.org/show_bug.cgi?id=160223
<rdar://problem/27558003>
Reviewed by Eric Carlson.
Source/WebCore:
Changes in this patch:
- Added a change observer for volume slider so that it will handle accessibility increment/decrement functions correctly.
- Update the timer div's aria-label when time changes.
- Added a keydown handler for left/right arrow adjusting the timeline, so that the value increment/decrement in a reasonable way.
- Changed the mute button's role to checkbox since it only has on/off states.
Test: media/media-controls-accessibility.html
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.updatePictureInPictureButton):
(Controller.prototype.timelineStepFromVideoDuration):
(Controller.prototype.incrementTimelineValue):
(Controller.prototype.decrementTimelineValue):
(Controller.prototype.showInlinePlaybackPlaceholderWhenSafe):
(Controller.prototype.handleTimelineMouseUp):
(Controller.prototype.handleTimelineKeyDown):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.updateVideoVolume):
(Controller.prototype.handleVolumeSliderInput):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.handleVolumeSliderMouseDown):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):
(Controller.prototype.updateVolume):
LayoutTests:
- accessibility/mac/video-volume-slider-accessibility-expected.txt:
- accessibility/mac/video-volume-slider-accessibility.html:
- accessibility/media-emits-object-replacement-expected.txt:
- media/media-controls-accessibility-expected.txt: Added.
- media/media-controls-accessibility.html: Added.
- platform/efl/accessibility/media-element-expected.txt:
- platform/efl/accessibility/media-emits-object-replacement-expected.txt:
- platform/gtk/accessibility/media-element-expected.txt:
- platform/gtk/accessibility/media-emits-object-replacement-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- 11:58 AM Changeset in webkit [203912] by
-
- 5 edits in trunk/Source/WebInspectorUI
REGRESSION (r195456): Web Inspector: Changing tabs in Styles sidebar shouldn't change sidebar's width
https://bugs.webkit.org/show_bug.cgi?id=159646
<rdar://problem/27286338>
Reviewed by Brian Burg.
Remember sidebar width on per tab basis. For example, Node, Styles, and Layers sidebar panels in
Elements tab should all have the same width, but Resource sidebar panel in Debugger tab should NOT
share its width Element tab's sidebar.
TabContentView stores the width but TabBrowser manages saving and restoring it.
The same way collapsed sidebar state is handled.
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.set collapsed):
Don't change sidebar's width when sidebar panels change.
(WebInspector.Sidebar.prototype._recalculateWidth):
(WebInspector.Sidebar.prototype.set selectedSidebarPanel): Deleted.
Pass newWidth as an argument so it can be saved in TabBrowser.
- UserInterface/Views/SidebarPanel.js:
(WebInspector.SidebarPanel): Deleted.
(WebInspector.SidebarPanel.prototype.get savedWidth): Deleted.
(WebInspector.SidebarPanel.prototype.sizeDidChange): Deleted.
Remove the per sidebar panel width setting that was added in r195456.
- UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype._detailsSidebarWidthDidChange):
(WebInspector.TabBrowser.prototype._showDetailsSidebarPanelsForTabContentView):
- UserInterface/Views/TabContentView.js:
(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.get detailsSidebarWidthSetting):
Store details sidebar width on TabContentView.
- 11:52 AM Changeset in webkit [203911] by
-
- 2 edits in trunk/Source/WTF
Make StringView capable of being passed or returned in only 2 registers.
https://bugs.webkit.org/show_bug.cgi?id=160344
Reviewed by Geoffrey Garen.
We just need to #if out copy and move constructors and assignment operators.
After this change, the following test code:
JS_EXPORT_PRIVATE StringView returnStringView(StringView sv)
{
return sv;
}
... compiles to the following for x86_64:
ZN3JSC16returnStringViewEN3WTF10StringViewE:
000000000093fb20 pushq %rbp
000000000093fb21 movq %rsp, %rbp
000000000093fb24 movq %rdi, %rax Copy from arg word 0 to ret word 0.
000000000093fb27 movq %rsi, %rdx Copy from arg word 1 to ret word 1.
000000000093fb2a popq %rbp
000000000093fb2b retq
... and this for arm64:
ZN3JSC16returnStringViewEN3WTF10StringViewE:
0000000000818504 ret arg word 0 and 1 are in the same regs as ret word 0 and 1.
- wtf/text/StringView.h:
(WTF::StringView::StringView):
(WTF::StringView::~StringView):
(WTF::StringView::operator=):
- 11:47 AM Changeset in webkit [203910] by
-
- 2 edits in trunk/Source/WebCore
Remove an unused line of code.
https://bugs.webkit.org/show_bug.cgi?id=160350
Reviewed by Simon Fraser.
No new tests because there's no behavior change. Just removing dead code.
SVGInlineTextBox::paintText() instantiates a local variable selectionTextRun.
Thanks to analysis by Said Abou-Hallawa, we know that selectionTextRun
was introduced in https://trac.webkit.org/changeset/61393, but was later
rendered unused in https://trac.webkit.org/changeset/62099 because we
switched to using paintTextWithShadows() with the selectionStyle. Hence,
selectionTextRun can be removed.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintText):
- 11:45 AM Changeset in webkit [203909] by
-
- 2 edits in trunk/Source/WebKit2
Crash with an Invalid Web Process IPC Message ID: WebPageProxy.AttributedStringForCharacterRangeCallback
https://bugs.webkit.org/show_bug.cgi?id=160334
<rdar://problem/27078089>
Reviewed by Alexey Proskuryakov.
The crash is most likely caused by an MESSAGE_CHECK failure in WebPageProxy::attributedStringForCharacterRangeCallback
which marks the currently dispatching message was invalid inside the macro.
Make sure we never fail this check by sending an empty EditingRange in attributedSubstringForCharacterRangeAsync when
the editing range we're about to send to the UIProcess is invalid in WebProcess.
Unfortunately, no new tests since we don't have any reproduction and I couldn't spot any code path in which we end up
with an invalid EditingRage here with multiple inspection of the relevant code.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::attributedSubstringForCharacterRangeAsync):
- 11:40 AM Changeset in webkit [203908] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Assertion in NetworkGridContentView when updating data grid for the first time
https://bugs.webkit.org/show_bug.cgi?id=160330
<rdar://problem/27600905>
Reviewed by Brian Burg.
When the first grid node is added, a view layout and current time update
are scheduled. A view layout occurring before the current time is updated
should be skipped, since the ruler end time hasn't been set.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView.prototype.layout):
Skip layout until current time is updated.
(WebInspector.NetworkGridContentView.prototype._update):
Remove unused variablesstartTimeandendTime. Don't force a layout
if the elapsed time is zero.
- 11:38 AM Changeset in webkit [203907] by
-
- 3 edits1 delete in trunk/Source
Remove PassRef.h after r177259
https://bugs.webkit.org/show_bug.cgi?id=160348
Reviewed by Andreas Kling.
Source/WebKit/win:
- WebCoreSupport/WebVisitedLinkStore.h:
Source/WTF:
- wtf/PassRef.h: Removed.
- 10:54 AM Changeset in webkit [203906] by
-
- 3 edits in trunk/LayoutTests
Unskip some media tests on iOS when run in WebKitTestRunner
As a step towards running the various media tests on iOS, unskip LayoutTests/media
when run in WebKitTestRunner in the iOS Simulator. Incorporate the reasons we skip some
of the iOS tests from r189372. For now continue to skip LayoutTest/media when run in
DumpRenderTree in the iOS Simulator as many tests crash and are otherwise flaky. Further
investigation is required.
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 10:49 AM Changeset in webkit [203905] by
-
- 2 edits in trunk/Tools
Add TestWebKitAPI support for interacting with media controls
https://bugs.webkit.org/show_bug.cgi?id=160342
<rdar://problem/27610246>
Reviewed by Beth Dakin.
Adds support for testing interaction with some media controls, as well as a basic test
verifying that media control teardown after interaction does not result in a crash.
- TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
(-[WKWebView mouseDownAtPoint:]):
(-[WKWebView performAfterLoading:]):
(TestWebKitAPI::TEST):
- 10:47 AM Changeset in webkit [203904] by
-
- 5 edits in trunk/Source/WebCore
Change internal AVCaptureDeviceType typedef name
https://bugs.webkit.org/show_bug.cgi?id=160345
<rdar://problem/27610935>
Reviewed by Dean Jackson.
- platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::create): AVCaptureDeviceType -> AVCaptureDeviceTypedef
(WebCore::AVAudioCaptureSource::AVAudioCaptureSource): Ditto.
- platform/mediastream/mac/AVCaptureDeviceManager.mm:
(WebCore::AVCaptureDeviceManager::captureDeviceList): Ditto.
(WebCore::shouldConsiderDeviceInDeviceList): Ditto.
(WebCore::AVCaptureDeviceManager::refreshCaptureDeviceList): Ditto.
(WebCore::AVCaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints): Ditto.
(WebCore::AVCaptureDeviceManager::deviceConnected): Ditto.
(WebCore::AVCaptureDeviceManager::deviceDisconnected): Ditto.
(-[WebCoreAVCaptureDeviceManagerObserver deviceDisconnected:]): Ditto.
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::globaVideoCaptureSerialQueue): Ditto.
(WebCore::AVMediaCaptureSource::AVMediaCaptureSource): Ditto.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::create): Ditto.
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource): Ditto.
- 10:38 AM Changeset in webkit [203903] by
-
- 2 edits in trunk/Source/WebCore
color-gamut media query returns incorrect results
https://bugs.webkit.org/show_bug.cgi?id=160166
<rdar://problem/27537577>
Reviewed by Darin Adler.
While I was unable to reproduce the originator's issue,
we communicated via email and it might have been related
to a customized color space calibration on an external
display.
Anyway, I took this opportunity to update to use the
more appropriate API for detection on macOS Sierra.
Covered by the existing fast/media/mq-color-gamut.html test.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenSupportsExtendedColor): Use NSScreen canRepresentDisplayGamut.
- 10:19 AM Changeset in webkit [203902] by
-
- 4 edits in trunk
Crash Log Clobbering on Unbound Crashes
https://bugs.webkit.org/show_bug.cgi?id=160198
<rdar://problem/27472618>
Patch by Jonathan Bedard <Jonathan Bedard> on 2016-07-29
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs): Fix header order.
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
- 10:00 AM Changeset in webkit [203901] by
-
- 5 edits4 adds in trunk
HTMLVideoElement with MediaStream src shows paused image when all video tracks are disabled
https://bugs.webkit.org/show_bug.cgi?id=160222
<rdar://problem/27557313>
Patch by George Ruan <gruan@apple.com> on 2016-07-29
Reviewed by Eric Carlson.
Source/WebCore:
Tests: fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html
fast/mediastream/MediaStream-video-element-video-tracks-disabled.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSampleBufferFromTrack): Change criteria to enqueue a
Sample Buffer to the AVSampleBufferDisplayLayer to allow an initial frame to be shown.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::shouldEnqueueVideoSampleBuffer): Allow an initial frame to be shown.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::flushAndRemoveVideoSampleBuffers): Removes all buffers from the
AVSampleBufferDisplayLayer.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer): Make the AVSampleBufferDisplayLayer's background black.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode): Remove all buffers from the AVSampleBufferDisplayLayer
when state of MediaPlayerPrivateMediaStreamAVFObjC is changed to None of PaintItBlack.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updatePausedImage): Updates paused image.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause): Calls updatePausedImage.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext): Allow an initial frame to be painted to canvas.
LayoutTests:
- fast/mediastream/MediaStream-video-element-video-tracks-disabled-expected.html: Added.
- fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled-expected.txt: Added.
- fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html: Added. Checks
that the video frames display captured media if all video tracks were disabled and then a single
video track is re-enabled. This test also checks that an initial frame is painted to
canvas if the video has not yet been played.
- fast/mediastream/MediaStream-video-element-video-tracks-disabled.html: Added. Reference tests the
frames of the video to be black, since the canvas is painted black regardless of the state of the video frames
if displayMode of MediaPlayerPrivateMediaStreamAVFObjC is PaintItBlack.
- platform/mac-wk2/TestExpectations: MediaStream-video-element-video-tracks-disabled.html fails on El
Capitan due to incorrect behavior of AVSampleBufferDisplayLayer's API call flushAndRemoveImage.
- 7:12 AM Changeset in webkit [203900] by
-
- 16 edits in trunk
[Fetch API] Activate credentials mode
https://bugs.webkit.org/show_bug.cgi?id=160292
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-29
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/cors/cors-cookies-expected.txt:
- web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-cookies.js: Fixin otherRemote computation.
(corsCookies): ensuring cookie clean-up is done in case of error before going to the next test.
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
- web-platform-tests/fetch/api/credentials/cookies-expected.txt:
- web-platform-tests/fetch/api/credentials/cookies-worker-expected.txt:
Source/WebCore:
Covered by updated and rebased tests.
Previously the allowCredentials option was computed by DocumentThreadableLoader clients.
This option is really similar to the credentials flag in the fetch specification and should be handled at lower levels.
In the future, it might be good to retire that option.
In case of Omit mode, we need to explicitely disable cookies in DocumentThreadableLoader.
This should be updated so that ResourceLoader does it, depending on credential flag being set or not.
Updated DocumentThreadableLoader clients to only use FetchOptions::Credentials.
This allows to link code more easely to specification.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start): Removing use of allowCredentials option. Using FetchOptions::Credentials instead.
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start): Ditto.
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::loadResource): Ditto.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Computing allowCredentials from FetchOptions::Credentials.
(WebCore::DocumentThreadableLoader::loadRequest): Enabling cookie only if allowed to use credentials. This is in
particular useful for FetchOptions::Credentials::Omit mode.
- page/EventSource.cpp:
(WebCore::EventSource::connect): Removing use of allowCredentials option. Using FetchOptions::Credentials instead.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously): Ditto.
(WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
- xml/XMLHttpRequest.cpp: Ditto.
(WebCore::XMLHttpRequest::createRequest):
- 7:00 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 4:08 AM Changeset in webkit [203899] by
-
- 18 edits4 copies1 delete in trunk
CrossOrigin preflight checker should compute the right Access-Control-Request-Headers value
https://bugs.webkit.org/show_bug.cgi?id=160028
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-29
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/cors/cors-no-preflight-expected.txt:
- web-platform-tests/fetch/api/cors/cors-no-preflight-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-no-preflight.js:
(corsNoPreflight): fixing bugs in that test and adding new test to cover mime type checking that should ignore case.
- web-platform-tests/fetch/api/cors/cors-preflight-worker.html:
- web-platform-tests/fetch/api/cors/cors-preflight.html:
- web-platform-tests/fetch/api/cors/cors-preflight.js:
(corsPreflight): Adding safe headers to the request and checking more precisely sent Access-Control-Request-Headers header value.
Source/WebCore:
Covered by updated test.
Computing Access-Control-Request-Headers value according https://fetch.spec.whatwg.org/#cors-preflight-fetch:
- Remove safe headers
- lowercase header names
- sort lexicographically header names
The only difference is that we keep separating headers with ', ' instead of ',' as per the spec.
Also, some headers that might be safe are still marked as unsafe (DPR, Downlink...).
Moved setting of Origin header after preflighting, consistently with fetch spec.
- loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest): Implementing new computation of Access-Control-Request-Headers.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest): Removing call to updateRequestForAccessControl (which sets Origin header value).
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Adding call to updateRequestForAccessControl.
(WebCore::DocumentThreadableLoader::preflightSuccess): Ditto.
- platform/network/HTTPParsers.cpp:
(WebCore::isCrossOriginSafeRequestHeader): Helper routine to implement https://fetch.spec.whatwg.org/#cors-safelisted-request-header.
- platform/network/HTTPParsers.h:
LayoutTests:
Rebasing regular tests. Also updating skipped worker tests.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight-worker-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-redirect-worker-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight-worker-expected.txt: Added.
- platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-preflight-redirect-worker-expected.txt: Added.
- platform/mac/TestExpectations:
- 3:49 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 2:58 AM Changeset in webkit [203898] by
-
- 2 edits in trunk/Tools
Update for contributors.json
https://bugs.webkit.org/show_bug.cgi?id=160294
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2016-07-29
- Scripts/webkitpy/common/config/contributors.json:
- 12:59 AM Changeset in webkit [203897] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, ByValInfo is only used in JIT enabled environments
https://bugs.webkit.org/show_bug.cgi?id=158908
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- 12:37 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 12:21 AM Changeset in webkit [203896] by
-
- 6 edits in trunk/Source/WebCore
Parse the operator text on the MathMLOperatorElement class.
https://bugs.webkit.org/show_bug.cgi?id=160241
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-29
Reviewed by Darin Adler.
The text of the MathML operators is important to determine form or dictionary properties and
hence provide default values when no explicit attributes are privided. Since that text only
depends on the MathML DOM content, it makes sense to move its parsing into
MathMLOperatorElement. Anonymous operators created by the mfenced elements still need to be
handled specially and this will be true for all the operator properties that can just be
determined in MathMLOperatorElement. Hence in a follow-up patch we will introduce a class
to move all the code specific to mfenced in a class derived from RenderMathMLOperator while
we continue to move the corresponding code for non-anonymous into MathMLOperatorElement.
No new tests, behavior is unchanged.
- mathml/MathMLOperatorElement.cpp: Include header for hyphenMinus/minusSign characters.
(WebCore::MathMLOperatorElement::parseOperatorText): Move that code from rebuildTokenContent
(WebCore::MathMLOperatorElement::operatorText): Helper function to get the cached text.
(WebCore::MathMLOperatorElement::childrenChanged): Make the cached text dirty.
- mathml/MathMLOperatorElement.h: Update defitions and add a member for the operator text.
- mathml/MathMLTextElement.h: Make childrenChanged overridable.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::element): Helper function to cast to a MathMLOperatorElement.
(WebCore::RenderMathMLOperator::textContent): Helper function to call
MathMLOperatorElement::operatorText or fallback to m_textContent for anonymous operators.
m_textContent and this special case can be moved into a derived class later.
(WebCore::RenderMathMLOperator::setOperatorProperties): Call textContent().
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLOperator::rebuildTokenContent): Remove the string parameter and the
parsing of the operator text.
(WebCore::RenderMathMLOperator::updateTokenContent): Call textContent(). The special function
for anonymous operators also parses the text content but this could be moved into a derived
class later.
(WebCore::RenderMathMLOperator::shouldAllowStretching): Call textContent().
(WebCore::RenderMathMLOperator::useMathOperator): Ditto.
(WebCore::RenderMathMLOperator::RenderMathMLOperator): No need to initialize m_textContent
as it is not used anymore for non-anonymous renderers.
- rendering/mathml/RenderMathMLOperator.h: Update definitions and call textContent().
- 12:15 AM Changeset in webkit [203895] by
-
- 33 edits1 add in trunk/Source/JavaScriptCore
JSC::Symbol should be hash-consed
https://bugs.webkit.org/show_bug.cgi?id=158908
Reviewed by Filip Pizlo.
Previously, SymbolImpls held by symbols represent identity of symbols.
When we check the equality between symbols, we need to load SymbolImpls of symbols and compare them.
This patch performs hash-consing onto the symbols. We cache symbols in per-VM's SymbolImpl-keyed WeakGCMap.
When creating a new symbol from SymbolImpl, we first query to this map and reuse the previously created symbol
if it is found. This ensures that one-on-one correspondence between SymbolImpl and symbol. So now, we can use
pointer-comparison to query the equality of symbols.
This change drops SymbolImpl loads when checking the equality. Furthermore, we can use DFG CheckCell to symbol
when we would like to ensure that the given value is the expected symbol. This cleans up GetByVal's symbol-keyd
caching. Then, we changed CheckIdent to CheckStringIdent since it only checks the string case now. The symbol
case is handled by CheckCell.
Additionally, this patch also cleans up Map / Set implementation since we can use the logic for JSCell to symbols.
The performance effects in the related benchmarks are the followings.
baseline patch
bigswitch-indirect-symbol-or-undefined 85.6214+-1.0063 63.0522+-0.8615 definitely 1.3579x faster
bigswitch-indirect-symbol 84.9653+-0.6258 80.4900+-0.8008 definitely 1.0556x faster
fold-put-by-val-with-symbol-to-multi-put-by-offset
9.4396+-0.3726 9.2941+-0.3311 might be 1.0157x faster
inlined-put-by-val-with-symbol-transition
49.5477+-0.2401 ? 49.7533+-0.3369 ?
get-by-val-with-symbol-self-or-proto 11.9740+-0.0798 ? 12.1706+-0.2723 ? might be 1.0164x slower
get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple
4.1364+-0.0841 4.0872+-0.0925 might be 1.0120x faster
put-by-val-with-symbol 11.3709+-0.0223 11.3613+-0.0264
get-by-val-with-symbol-proto-or-self 11.8984+-0.0706 ? 11.9030+-0.0787 ?
polymorphic-put-by-val-with-symbol 31.4176+-0.0558 31.3825+-0.0447
implicit-bigswitch-indirect-symbol 61.3115+-0.6577 58.0098+-0.1212 definitely 1.0569x faster
get-by-val-with-symbol-bimorphic-check-structure-elimination-simple
3.3139+-0.0565 2.9947+-0.0732 definitely 1.1066x faster
get-by-val-with-symbol-chain-from-try-block
2.2316+-0.0179 2.2137+-0.0210
get-by-val-with-symbol-bimorphic-check-structure-elimination
10.6031+-0.2216 10.0939+-0.1977 definitely 1.0504x faster
get-by-val-with-symbol-check-structure-elimination
8.5576+-0.1521 7.7107+-0.1308 definitely 1.1098x faster
put-by-val-with-symbol-slightly-polymorphic
3.1957+-0.0538 2.9181+-0.0708 definitely 1.0951x faster
put-by-val-with-symbol-replace-and-transition
11.8253+-0.0757 11.6590+-0.0351 definitely 1.0143x faster
<geometric> 13.3911+-0.0527 12.7376+-0.0457 definitely 1.0513x faster
- bytecode/ByValInfo.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasUidOperand):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSymbolEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleSymbolEquality):
(JSC::DFG::SpeculativeJIT::compileCheckStringIdent):
(JSC::DFG::SpeculativeJIT::extractStringImplFromBinarySymbols): Deleted.
(JSC::DFG::SpeculativeJIT::compileCheckIdent): Deleted.
(JSC::DFG::SpeculativeJIT::compileSymbolUntypedEquality): Deleted.
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileSymbolUntypedEquality):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileSymbolUntypedEquality):
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckStringIdent):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckIdent): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::lowSymbolUID): Deleted.
- jit/JIT.h:
- jit/JITOperations.cpp:
(JSC::tryGetByValOptimize):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emitByValIdentifierCheck):
(JSC::JIT::privateCompileGetByValWithCachedId):
(JSC::JIT::privateCompilePutByValWithCachedId):
(JSC::JIT::emitIdentifierCheck): Deleted.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitPutByValWithCachedId):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dumpInContextAssumingStructure):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline): Deleted.
- runtime/JSFunction.cpp:
(JSC::JSFunction::setFunctionName):
- runtime/MapData.h:
- runtime/MapDataInlines.h:
(JSC::JSIterator>::clear): Deleted.
(JSC::JSIterator>::find): Deleted.
(JSC::JSIterator>::add): Deleted.
(JSC::JSIterator>::remove): Deleted.
(JSC::JSIterator>::replaceAndPackBackingStore): Deleted.
- runtime/Symbol.cpp:
(JSC::Symbol::finishCreation):
(JSC::Symbol::create):
- runtime/Symbol.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- tests/stress/symbol-equality-over-gc.js: Added.
(shouldBe):
(test):
- 12:13 AM Changeset in webkit [203894] by
-
- 2 edits1 add in branches/safari-602-branch/Source/JavaScriptCore
Merge r203851. rdar://problem/27299339
- 12:13 AM Changeset in webkit [203893] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203825. rdar://problem/27578447
- 12:12 AM Changeset in webkit [203892] by
-
- 2 edits1 add in branches/safari-602-branch/Source/JavaScriptCore
Merge r203793. rdar://problem/27572612
- 12:12 AM Changeset in webkit [203891] by
-
- 2 edits1 add in branches/safari-602-branch/Source/JavaScriptCore
Merge r203790. rdar://problem/27328525
- 12:12 AM Changeset in webkit [203890] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203789. rdar://problem/27574519
- 12:12 AM Changeset in webkit [203889] by
-
- 2 edits in branches/safari-602-branch/Source/WebKit2
Merge r203780. rdar://problem/27569255
- 12:12 AM Changeset in webkit [203888] by
-
- 4 edits in branches/safari-602-branch/Source/WebCore
Merge r203801. rdar://problem/26102954
- 12:12 AM Changeset in webkit [203887] by
-
- 5 edits4 adds in branches/safari-602-branch
Merge r203764. rdar://problem/27434423
- 12:12 AM Changeset in webkit [203886] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203775. rdar://problem/23325160
- 12:12 AM Changeset in webkit [203885] by
-
- 2 edits in branches/safari-602-branch/Tools
Merge r203755. rdar://problem/23325160
- 12:12 AM Changeset in webkit [203884] by
-
- 16 edits2 adds in branches/safari-602-branch
Merge r203743. rdar://problem/23325160
- 12:12 AM Changeset in webkit [203883] by
-
- 24 edits in branches/safari-602-branch
Merge r203855. rdar://problem/27557968
- 12:12 AM Changeset in webkit [203882] by
-
- 28 edits2 adds in branches/safari-602-branch
Merge r203752. rdar://problem/27557968
- 12:12 AM Changeset in webkit [203881] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203746. rdar://problem/27527151
- 12:12 AM Changeset in webkit [203880] by
-
- 3 edits in branches/safari-602-branch/Source/WebKit2
Merge r203741. rdar://problem/27480873
- 12:12 AM Changeset in webkit [203879] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203737. rdar://problem/21090897
- 12:12 AM Changeset in webkit [203878] by
-
- 2 edits in branches/safari-602-branch/Source/WebKit2
Merge r203724. rdar://problem/27536113
- 12:12 AM Changeset in webkit [203877] by
-
- 7 edits in branches/safari-602-branch
Merge r203711. rdar://problem/27279453
- 12:11 AM Changeset in webkit [203876] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203706. rdar://problem/27457941
- 12:11 AM Changeset in webkit [203875] by
-
- 6 edits2 adds in branches/safari-602-branch
Merge r203698. rdar://problem/26986673
- 12:11 AM Changeset in webkit [203874] by
-
- 7 edits in branches/safari-602-branch/Tools
Merge r203700. rdar://problem/27010112
- 12:11 AM Changeset in webkit [203873] by
-
- 3 edits2 moves1 add1 delete in branches/safari-602-branch
Merge r203695. rdar://problem/27010112
- 12:11 AM Changeset in webkit [203872] by
-
- 3 edits2 adds in branches/safari-602-branch
Merge r203694. rdar://problem/27220338
- 12:11 AM Changeset in webkit [203871] by
-
- 7 edits3 adds in branches/safari-602-branch
Merge r203690. rdar://problem/26668526
- 12:11 AM Changeset in webkit [203870] by
-
- 4 edits in branches/safari-602-branch/Source/WebKit2
Merge r203687. rdar://problem/27399998
- 12:11 AM Changeset in webkit [203869] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r203683. rdar://problem/27525634
- 12:11 AM Changeset in webkit [203868] by
-
- 2 edits in branches/safari-602-branch/Source/WebInspectorUI
Merge r203673. rdar://problem/27517481
- 12:11 AM Changeset in webkit [203867] by
-
- 3 edits in branches/safari-602-branch/Source/WebKit2
Merge r203671. rdar://problem/27409315
- 12:11 AM Changeset in webkit [203866] by
-
- 3 edits2 adds in branches/safari-602-branch
Merge r203669. rdar://problem/27285070
- 12:11 AM Changeset in webkit [203865] by
-
- 3 edits2 adds in branches/safari-602-branch
Merge r203667. rdar://problem/27506489
- 12:11 AM Changeset in webkit [203864] by
-
- 2 edits in branches/safari-602-branch/Source/WebInspectorUI
Merge r203636. rdar://problem/27431121
- 12:11 AM Changeset in webkit [203863] by
-
- 5 edits in branches/safari-602-branch/Source/WebKit2
Merge r203635. rdar://problem/27505943
- 12:11 AM Changeset in webkit [203862] by
-
- 7 edits in branches/safari-602-branch/Source
Merge r203631. rdar://problem/24606557
- 12:11 AM Changeset in webkit [203861] by
-
- 3 edits in branches/safari-602-branch/Source/WebKit2
Merge r203630. rdar://problem/27504958
- 12:11 AM Changeset in webkit [203860] by
-
- 4 edits in branches/safari-602-branch
Merge r203629. rdar://problem/27438936
- 12:11 AM Changeset in webkit [203859] by
-
- 4 edits2 adds in branches/safari-602-branch
Merge r203622. rdar://problem/27495748
Jul 28, 2016:
- 11:45 PM Changeset in webkit [203858] by
-
- 21 edits in trunk
Binding generator should expose the visible interface name in error messages
https://bugs.webkit.org/show_bug.cgi?id=160192
Source/WebCore:
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-28
Reviewed by Darin Adler.
Covered by updated layout and binding tests.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation): Using visibleInterfaceName instead of interfaceName.
(GenerateFunctionCastedThis): Ditto.
(GenerateParametersCheck): Ditto.
(GenerateConstructorDefinition): Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Rebased.
- bindings/scripts/test/TestObj.idl: Adding ConstructorCallWith to exercice change in GenerateConstructorDefinition.
LayoutTests:
Patch by Youenn Fablet <youennf@gmail.com> on 2016-07-28
Reviewed by Darin Adler.
- editing/selection/extend-expected.txt:
- fast/dom/Window/getComputedStyle-missing-parameter-expected.txt:
- fast/dom/Window/getComputedStyle-missing-parameter.html:
- fetch/fetch-error-messages-expected.txt:
- fetch/fetch-error-messages.html: Adding test for Request.
- js/dom/toString-and-valueOf-override-expected.txt:
- js/getOwnPropertyDescriptor-unforgeable-attributes-expected.txt:
- js/getOwnPropertyDescriptor-window-attributes-expected.txt:
- media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- webaudio/createMediaStreamSource-null-expected.txt:
- webaudio/createMediaStreamSource-null.html:
- webaudio/decode-audio-data-basic-expected.txt:
- webaudio/decode-audio-data-basic.html:
- webaudio/mediaelementaudiosourcenode-expected.txt:
- webaudio/mediaelementaudiosourcenode.html:
- 10:22 PM Changeset in webkit [203857] by
-
- 17 edits in trunk/Source
Split calculateCacheSizes in two methods
https://bugs.webkit.org/show_bug.cgi?id=160237
Reviewed by Darin Adler.
Source/WebCore:
Rename getVolumeFreeSizeForPath as volumeFreeSizeForPath and make it available to all platforms adding an
implementation for mac.
- platform/FileSystem.h:
- platform/efl/FileSystemEfl.cpp:
(WebCore::volumeFreeSizeForPath):
(WebCore::getVolumeFreeSizeForPath): Deleted.
- platform/glib/FileSystemGlib.cpp:
(WebCore::volumeFreeSizeForPath):
(WebCore::getVolumeFreeSizeForPath): Deleted.
- platform/mac/FileSystemMac.mm:
(WebCore::volumeFreeSizeForPath):
- platform/win/FileSystemWin.cpp:
(WebCore::volumeFreeSizeForPath):
Source/WebKit2:
It's used to calculate memory and disk cache sizes, but only the web process is interested in memory caches, and
the network process in disk cache. We can also avoid a lot of duplicated code between ports to set the cache model.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::setCacheModel): Use calculateURLCacheSizes to set the disk cache size and call
platformSetURLCacheSize if not set to allow ports to setup platform specific cache.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformSetURLCacheSize): Remove common code that is now in cross-platform file.
(WebKit::volumeFreeSize): Deleted.
(WebKit::NetworkProcess::platformSetCacheModel): Renamed to platformSetURLCacheSize().
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::platformSetURLCacheSize): Remove common code that is now in cross-platform file.
(WebKit::getCacheDiskFreeSize): Deleted.
(WebKit::NetworkProcess::platformSetCacheModel): Renamed to platformSetURLCacheSize().
- Shared/CacheModel.cpp:
(WebKit::calculateMemoryCacheSizes): Calculate the memory and page cache sizes.
(WebKit::calculateURLCacheSizes): Calculate the disk cache size.
(WebKit::calculateCacheSizes): Deleted.
- Shared/CacheModel.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess): Tell the page cache to clear backing stores for GTK+ port too. This was done before when
setting the cache model.
(WebKit::WebProcess::setCacheModel): Use calculateMemoryCacheSizes to setup memory caches and call
platformSetCacheModel to allow ports do more setup according to the cache model.
(WebKit::WebProcess::clearResourceCaches): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformSetCacheModel): Remove common code that is now in cross-platform file.
(WebKit::volumeFreeSize): Deleted.
(WebKit::WebProcess::platformClearResourceCaches): Deleted.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel): Remove common code that is now in cross-platform file.
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformClearResourceCaches): Deleted.
- 10:16 PM Changeset in webkit [203856] by
-
- 5 edits in trunk/Source/WebKit2
Database Process: ASSERTION FAILED: paths.size() == handles.size() with SANDBOX_EXTENSIONS disabled
https://bugs.webkit.org/show_bug.cgi?id=160188
Reviewed by Sergio Villar Senin.
This happens in ports with sandbox extensions disabled, and it's making several tests to crash in debug
builds. The SandboxExtension implementation is empty in case of building with sandbox extensions disabled, so
that we are actually allocating no extensions at all in
NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs(). When the message arrives to database
process, we have a list of paths, but an empty list of hanldes which causes the assertion. We can just avoid
that message entirely in case of building without sandbox extensions.
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseProcess.messages.in:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs):
- 10:14 PM UpdatingANGLE edited by
- (diff)
- 8:03 PM Changeset in webkit [203855] by
-
- 24 edits in trunk
Remove deprecated SPI for video inline / fullscreen controls
https://bugs.webkit.org/show_bug.cgi?id=160318
Reviewed by Tim Horton.
Source/WebCore:
r203752 deprecated the SPI allowsInlineMediaPlaybackWithPlaysInlineAttribute
and allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute (in favor of
inlineMediaPlaybackRequiresPlaysInlineAttribute). This patch removes the
deprecated SPI symbols.
No new tests because there is no behavior change.
- page/Settings.cpp:
- page/Settings.in:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Deleted.
(WebCore::InternalSettings::Backup::restoreTo): Deleted.
(WebCore::InternalSettings::setAllowsInlineMediaPlaybackWithPlaysInlineAttribute): Deleted.
(WebCore::InternalSettings::setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute): Deleted.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Deleted.
(-[WebPreferences allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
(-[WebPreferences setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
(-[WebPreferences allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
(-[WebPreferences setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Deleted.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAllowsInlineMediaPlaybackWithPlaysInlineAttribute): Deleted.
(WKPreferencesGetAllowsInlineMediaPlaybackWithPlaysInlineAttribute): Deleted.
(WKPreferencesSetAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute): Deleted.
(WKPreferencesGetAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]): Deleted.
(-[WKWebViewConfiguration copyWithZone:]): Deleted.
(-[WKWebViewConfiguration _allowsInlineMediaPlaybackWithPlaysInlineAttribute]): Deleted.
(-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackWithPlaysInlineAttribute:]): Deleted.
(-[WKWebViewConfiguration _allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute]): Deleted.
(-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Deleted.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): Deleted.
- TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
(RequiresUserActionForPlaybackTest::SetUp): Deleted.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues): Deleted.
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration): Deleted.
- 7:09 PM Changeset in webkit [203854] by
-
- 2 edits in trunk/Tools
[iOS] TestWebKitAPI bundle targets are not code signed
https://bugs.webkit.org/show_bug.cgi?id=160328
<rdar://problem/27409246>
Patch by Daniel Bates <dabates@apple.com> on 2016-07-28
Reviewed by Andy Estes.
Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
- TestWebKitAPI/Configurations/Base.xcconfig:
- 6:23 PM Changeset in webkit [203853] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
ASSERTION FAILED in errorProtoFuncToString() when Error name is a single char string.
https://bugs.webkit.org/show_bug.cgi?id=160324
<rdar://problem/27389572>
Reviewed by Keith Miller.
The issue is that errorProtoFuncToString() was using jsNontrivialString() to
generate the error string even when the name string can be a single character
string. This is incorrect. We should be using jsString() instead.
- runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
- tests/stress/errors-with-simple-names-or-messages-should-not-crash-toString.js: Added.
- 6:19 PM Changeset in webkit [203852] by
-
- 9 edits2 adds in trunk
Add support for Element.getAttributeNames()
https://bugs.webkit.org/show_bug.cgi?id=160327
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/attributes-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add support for Element.getAttributeNames():
Firefox already supports this, Chrome 52 does not yet.
Test: fast/dom/Element/getAttributeNames.html
- bindings/js/JSDOMBinding.h:
(WebCore::JSValueTraits<AtomicString>::arrayJSValue):
- dom/Element.cpp:
(WebCore::Element::getAttributeNames):
- dom/Element.h:
- dom/Element.idl:
LayoutTests:
Add layout test coverage. I have verified that this test is passing in
Firefox 47.
- fast/dom/Element/getAttributeNames-expected.txt: Added.
- fast/dom/Element/getAttributeNames.html: Added.
- 5:30 PM Changeset in webkit [203851] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
ARM64: Fused left shift with a right shift can create NaNs from integers
https://bugs.webkit.org/show_bug.cgi?id=160329
Reviewed by Geoffrey Garen.
When we fuse a left shift and a right shift of integers where the shift amounts
are the same and the size of the quantity being shifted is 8 bits, we rightly
generate a sign extend byte instruction. On ARM64, we were sign extending
to a 64 bit quantity, when we really wanted to sign extend to a 32 bit quantity.
Checking the ARM64 marco assembler and we were extending to 64 bits for all
four combinations of zero / sign and 8 / 16 bits.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::zeroExtend16To32):
(JSC::MacroAssemblerARM64::signExtend16To32):
(JSC::MacroAssemblerARM64::zeroExtend8To32):
(JSC::MacroAssemblerARM64::signExtend8To32):
- tests/stress/regress-160329.js: New test added.
(narrow):
- 4:52 PM Changeset in webkit [203850] by
-
- 2 edits in trunk/Tools
Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
- TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
(animatedResizeWebView):
(TEST):
This test times out only when run in the WebKit Testing simulator environment,
but not in a fresh simulator. Disabling to keep the bots green while under investigation.
- 4:29 PM Changeset in webkit [203849] by
-
- 8 edits in trunk
window.open.length should be 0
https://bugs.webkit.org/show_bug.cgi?id=160323
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
window.open.length should be 0 as all its parameters are optional:
It is 2 in WebKit. Firefox and Chrome agree with the specification and return 0.
No new tests, rebaselined existing test.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::open):
Minor code optimization.
- page/DOMWindow.idl:
Update IDL to match the specification and our custom implementation.
This makes us return the right "length" value.
LayoutTests:
Update existing test to reflect behavior change.
- js/dom/function-length-expected.txt:
- js/dom/function-length.html:
- 4:15 PM Changeset in webkit [203848] by
-
- 11 edits in trunk
Parameters to Event.initEvent() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160320
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameters to Event.initEvent() should be mandatory:
Firefox agrees with the specification. Chrome does not.
No new tests, rebaselined existing tests.
- dom/Event.idl:
Source/WebInspectorUI:
Update WebInspector accordingly.
- UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Update existing tests to make sure they call initEvent() will all 3
parameters.
- fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml:
- fast/forms/form-submission-create-crash.xhtml:
- js/arity-mismatch-at-vmentry.html:
- 3:21 PM Changeset in webkit [203847] by
-
- 8 edits in trunk/Source
Move a Mail.app workaround closer to where it's actually needed
https://bugs.webkit.org/show_bug.cgi?id=160317
Reviewed by Tim Horton.
Source/WebCore:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadArchive):
- platform/network/cf/ResourceRequest.h:
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::applyWebArchiveHackForMail): Deleted.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::applyWebArchiveHackForMail): Deleted.
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSendRequest):
- WebView/WebFrame.mm:
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Deleted.
- 3:17 PM Changeset in webkit [203846] by
-
- 4 edits in trunk
2 first parameters to window.postMessage() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160319
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
2 first parameters to window.postMessage() should be mandatory:
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
- 3:05 PM Changeset in webkit [203845] by
-
- 11 edits in trunk
First parameter to canvas.getContext() / probablySupportsContext() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160312
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline several W3C tests now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/context.arguments.missing-expected.txt:
Source/WebCore:
First parameter to canvas.getContext() / probablySupportsContext()
should be mandatory:
Firefox and Chrome agree with the specification for getContext().
Neither of them supports probablySupportsContext().
No new tests, rebaselined existing tests.
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
(WebCore::JSHTMLCanvasElement::probablySupportsContext):
- html/HTMLCanvasElement.idl:
Source/WebInspectorUI:
Update WebInspector accordingly.
- UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Update existing test to reflect behavior change.
- fast/canvas/webgl/canvas-supports-context-expected.txt:
- fast/canvas/webgl/canvas-supports-context.html:
- 2:51 PM Changeset in webkit [203844] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
https://bugs.webkit.org/show_bug.cgi?id=160093
<rdar://problem/27499300>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._positionHeaderViews):
Remove early return so that a header view in a hidden column will have
its width resized to zero, matching the column.
- 2:38 PM Changeset in webkit [203843] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Waterfall view should be visible in Network tab and Network Timeline
https://bugs.webkit.org/show_bug.cgi?id=160061
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-07-28
Reviewed by Joseph Pecoraro.
Adds a Timeline-column (waterfall) to the Network tab and Network Timeline.
- Localizations/en.lproj/localizedStrings.js:
Add "Timeline" localized string.
- UserInterface/Views/NetworkGridContentView.js:
(WebInspector.NetworkGridContentView):
Add the Timeline-column with a TimelineRuler as the headerview,
and properties for updating current time.
(WebInspector.NetworkGridContentView.prototype.get secondsPerPixel):
(WebInspector.NetworkGridContentView.prototype.get startTime):
(WebInspector.NetworkGridContentView.prototype.get currentTime):
(WebInspector.NetworkGridContentView.prototype.get endTime):
Acting as a graphDataSource used by TimelineDataGridNode.
(WebInspector.NetworkGridContentView.prototype.shown):
(WebInspector.NetworkGridContentView.prototype.reset):
(WebInspector.NetworkGridContentView.prototype.layout):
Refresh graphs and update the TimelineRuler on layout changes.
(WebInspector.NetworkGridContentView.prototype._networkTimelineRecordAdded):
Add listeners for when resources are finished to stop the timer.
(WebInspector.NetworkGridContentView.prototype._update):
(WebInspector.NetworkGridContentView.prototype._startUpdatingCurrentTime):
(WebInspector.NetworkGridContentView.prototype._stopUpdatingCurrentTime):
Adding a timer which updates the TimelineRuler and the layout
if any non-finished requests are running.
- UserInterface/Views/NetworkTimelineView.js:
(WebInspector.NetworkTimelineView):
Add the Timeline-column with a TimelineRuler as the headerview.
(WebInspector.NetworkTimelineView.prototype.get secondsPerPixel):
(WebInspector.NetworkTimelineView.prototype.layout):
Refresh graphs on layout changes.
- UserInterface/Views/TimelineDataGrid.css:
(.tree-outline.timeline-data-grid .item:hover .subtitle):
(.data-grid.timeline th):
(.data-grid.timeline th.graph-column > .timeline-ruler):
(.data-grid.timeline td.graph-column):
(.data-grid.timeline td.graph-column > .cell-content):
(.data-grid.timeline td.graph-column .timeline-record-bar):
- 2:19 PM Changeset in webkit [203842] by
-
- 13 edits2 adds in trunk
Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
https://bugs.webkit.org/show_bug.cgi?id=160289
<rdar://problem/27553464>
Reviewed by Simon Fraser.
API Tests: WebKit2.AnimatedResizeDoesNotHang, WebKit2.ResizeWithHiddenContentDoesNotHang
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):
Avoid calling _endAnimatedResize when a commit comes in when we haven't yet received
a dynamic viewport update reply (and thus don't have a transaction ID to wait on).
Previously, in this case, _resizeAnimationTransformTransactionID would be 0,
and *any* commit would cause _endAnimatedResize to be called, causing us to always
fall into the worst-case sync wait.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::synchronizeDynamicViewportUpdate):
Make use of waitForDidUpdateViewState instead of having a separate waitForAndDispatchImmediately
here, because it knows to do things like dispatch the didUpdate message if it's still
pending. This also shortens the sync wait timeout from 1s to 500ms, which makes it
consistent with e.g. the newly-parented-view timeout duration, and should be nothing
but positive.
- Platform/IPC/Connection.cpp:
(IPC::Connection::timeoutRespectingIgnoreTimeoutsForTesting):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
- Platform/IPC/Connection.h:
(IPC::Connection::ignoreTimeoutsForTesting):
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration ignoreSynchronousMessagingTimeoutsForTesting]):
(-[_WKProcessPoolConfiguration setIgnoreSynchronousMessagingTimeoutsForTesting:]):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processDidFinishLaunching):
Add a mechanism for clients to cause all synchronous message timeouts to be effectively infinite.
The new API tests use this to ensure that the test will time out if they ever enter
the bad state (otherwise, the shorter sync wait timeout could make the test still pass).
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
(-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
(-[AnimatedResizeWebView _endAnimatedResize]):
(animatedResizeWebView):
(TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
Add two tests that ensure that hidden-content and animated resizes
don't cause unnecessary synchronous waits. Only the hidden-content
one fails before my patch, but it seemed reasonable to add both anyway.
- 2:17 PM Changeset in webkit [203841] by
-
- 2 edits in trunk/Source/WebKit/mac
Use a RetainPtr in WebFrameLoaderClient::assignIdentifierToInitialRequest
https://bugs.webkit.org/show_bug.cgi?id=160315
Reviewed by Tim Horton.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::assignIdentifierToInitialRequest):
- 2:07 PM Changeset in webkit [203840] by
-
- 10 edits in trunk
Parameter to table.deleteRow() / body.deleteRow() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160307
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameter to table.deleteRow() / body.deleteRow() should be mandatory:
- https://html.spec.whatwg.org/multipage/tables.html#the-table-element
- https://html.spec.whatwg.org/multipage/tables.html#htmltablesectionelement
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
- html/HTMLTableElement.idl:
- html/HTMLTableSectionElement.idl:
Source/WebInspectorUI:
Update WebInspector accordingly.
- UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Update existing test to reflect behavior change.
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- 2:02 PM Changeset in webkit [203839] by
-
- 4 edits4 deletes in trunk
Unreviewed, rolling out r203826.
https://bugs.webkit.org/show_bug.cgi?id=160314
The test added with this change fails on El Capitan WK2.
(Requested by ryanhaddad on #webkit).
Reverted changeset:
"HTMLVideoElement with MediaStream src shows paused image when
all video tracks are disabled"
https://bugs.webkit.org/show_bug.cgi?id=160222
http://trac.webkit.org/changeset/203826
Patch by Commit Queue <commit-queue@webkit.org> on 2016-07-28
- 1:56 PM Changeset in webkit [203838] by
-
- 3 edits in branches/safari-602-branch/LayoutTests
2016-07-28 Alexey Proskuryakov <ap@apple.com>
macOS Sierra test result gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 1:55 PM Changeset in webkit [203837] by
-
- 3 edits in trunk/LayoutTests
macOS Sierra test result gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 1:54 PM Changeset in webkit [203836] by
-
- 10 edits in trunk
2 first parameters to input.setSelectionRange() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160310
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
2 first parameters to input.setSelectionRange() should be mandatory:
Calling this method without the 2 first parameters makes little
sense.
Firefox agrees with the specification, Chrome does not.
No new tests, rebaselined existing test.
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::setSelectionRange):
- html/HTMLInputElement.idl:
Source/WebInspectorUI:
Update WebInspector accordingly.
- UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Update existing test to reflect behavior change.
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- 1:40 PM Changeset in webkit [203835] by
-
- 2 edits in trunk/Source/WebCore
Remove an unnecessary comment from UUID.h
https://bugs.webkit.org/show_bug.cgi?id=160313
Reviewed by Simon Fraser.
- platform/UUID.h:
- 1:28 PM Changeset in webkit [203834] by
-
- 3 edits1 add in trunk/Source
StringView should have an explicit m_is8Bit field.
https://bugs.webkit.org/show_bug.cgi?id=160282
<rdar://problem/27327943>
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- tests/stress/string-joining-long-strings-should-not-crash.js: Added.
(catch):
Source/WTF:
The current implementation reserves 1 bit in the 32-bit m_length field as an
is16Bit flag. As a result, a StringView is incapable of handling strings that
have a length of 32-bit in size. This results in a mismatch with the
expectations of String, StringImpl, and JavaScriptCore's JSString which all
support a 32-bit unsigned length.
This patch fixes this issue by introducing an explicit m_is8Bit field, thereby
allowing m_length to be a full 32-bit again.
We also introduced a clear() convenience method to set the fields of StringView
to empty values. Previously, we were duplicating the code for clearing those
fields. We now call clear() in all those places instead.
Note: in clear(), we set m_is8Bit to true because we want an empty StringView
to be 8-bit rather than 16-bit. This is consistent with what the empty() method
returns.
- wtf/text/StringView.h:
(WTF::StringView::setUnderlyingString):
(WTF::StringView::StringView):
(WTF::StringView::operator=):
(WTF::StringView::initialize):
(WTF::StringView::clear):
(WTF::StringView::empty):
(WTF::StringView::length):
(WTF::StringView::operator bool):
(WTF::StringView::is8Bit):
(WTF::StringView::substring):
(WTF::StringView::getCharactersWithUpconvert):
(WTF::StringView::toString):
(WTF::StringView::toAtomicString):
(WTF::StringView::toFloat):
(WTF::StringView::toInt):
(WTF::StringView::toIntStrict):
(WTF::StringView::toStringWithoutCopying):
(WTF::StringView::find):
- 1:21 PM Changeset in webkit [203833] by
-
- 9 edits in trunk
Parameter to tr.deleteCell() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160308
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameter to tr.deleteCell() should be mandatory:
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing tests.
- html/HTMLTableRowElement.idl:
Source/WebInspectorUI:
Report tr.deleteCell() parameter as mandatory.
- UserInterface/Models/NativeFunctionParameters.js:
LayoutTests:
Update existing test to reflect behavior change.
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
- 1:21 PM Changeset in webkit [203832] by
-
- 4 edits in trunk/Tools
webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
<https://webkit.org/b/83342>
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.revisions_changing_file): Remove code to raise an exception
when the file doesn't exist. If a file was moved or renamed,
then this caused the script to terminate, which was very
frustrating when you wanted a list of reviewers.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SCMTest._shared_test_revisions_changing_file): Update test
expectation to return an empty list of revisions.
(test_create_patch_is_full_patch): Drive-by fix when running all
webkitpy tests (including scm tests).
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.revisions_changing_file): Catch ScriptError exceptions and
return an empty array of revisions if this occurs.
- 1:18 PM Changeset in webkit [203831] by
-
- 5 edits in trunk
[Bindings] "length" value of overloaded operations may be wrong
https://bugs.webkit.org/show_bug.cgi?id=160303
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
"length" value of overloaded operations may be wrong because we fail to
account for overloads when computing the length of a function:
No new tests, rebaselined existing test.
- bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionLength):
- bindings/scripts/test/JS/JSTestObj.cpp:
- 1:12 PM Changeset in webkit [203830] by
-
- 9 edits in trunk/Tools
EWS error message "Error: * did not process patch" should include explanation
https://bugs.webkit.org/show_bug.cgi?id=159903
<rdar://problem/27410788>
Reviewed by Alexey Proskuryakov.
- QueueStatusServer/handlers/statusbubble.py:
(StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
is not processed.
- QueueStatusServer/handlers/processingtimesjson.py:
(ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
of the code.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.validate): Add more information about validation failure.
(CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
- Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
(EarlyWarningSystemTask.validate): Add more information about validation failure.
(EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchIsNotValid.init): Add the failure_message argument.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
failure details.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.process_work_item): Same.
(StyleQueue.review_patch): Same.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_non_valid_patch): Updated test-cases messages to match the above changes.
- 12:53 PM Changeset in webkit [203829] by
-
- 5 edits in tags/Safari-602.1.43.0.1/Source
Versioning.
- 12:50 PM Changeset in webkit [203828] by
-
- 2 edits in trunk/LayoutTests
Marking fast/dom/Window/child-window-focus.html as flaky on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=160309
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 12:50 PM Changeset in webkit [203827] by
-
- 1 copy in tags/Safari-602.1.43.0.1
New tag.
- 11:26 AM Changeset in webkit [203826] by
-
- 4 edits4 adds in trunk
HTMLVideoElement with MediaStream src shows paused image when all video tracks are disabled
https://bugs.webkit.org/show_bug.cgi?id=160222
<rdar://problem/27557313>
Patch by George Ruan <gruan@apple.com> on 2016-07-28
Reviewed by Eric Carlson.
Source/WebCore:
Tests: fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html
fast/mediastream/MediaStream-video-element-video-tracks-disabled.html
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSampleBufferFromTrack): Change criteria to enqueue a
Sample Buffer to the AVSampleBufferDisplayLayer to allow an initial frame to be shown.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::shouldEnqueueVideoSampleBuffer): Allow an initial frame to be shown.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::flushAndRemoveVideoSampleBuffers): Removes all buffers from the
AVSampleBufferDisplayLayer.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer): Make the AVSampleBufferDisplayLayer's background black.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode): Remove all buffers from the AVSampleBufferDisplayLayer
when state of MediaPlayerPrivateMediaStreamAVFObjC is changed to None of PaintItBlack.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updatePausedImage): Updates paused image.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause): Calls updatePausedImage.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext): Allow an initial frame to be painted to canvas.
LayoutTests:
- fast/mediastream/MediaStream-video-element-video-tracks-disabled-expected.html: Added.
- fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled-expected.txt: Added.
- fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html: Added. Checks
that the video frames display captured media if all video tracks were disabled and then a single
video track is re-enabled. This test also checks that an initial frame is painted to
canvas if the video has not yet been played.
- fast/mediastream/MediaStream-video-element-video-tracks-disabled.html: Added. Reference tests the
frames of the video to be black, since the canvas is painted black regardless of the state of the video frames
if displayMode of MediaPlayerPrivateMediaStreamAVFObjC is PaintItBlack.
- 11:19 AM Changeset in webkit [203825] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r202880): Default controls pip glyph inverted
https://bugs.webkit.org/show_bug.cgi?id=160304
<rdar://problem/27578447>
Reviewed by Eric Carlson.
I accidentally committed the "Exit Picture-in-picture" glyph
for the "Enter Picture-in-picture" buttons :(
- Modules/mediacontrols/mediaControlsApple.css:
(video::-webkit-media-controls-panel .picture-in-picture-button):
Use the correct artwork.
- 11:17 AM Changeset in webkit [203824] by
-
- 5 edits in trunk/Source
Versioning.
- 11:17 AM Changeset in webkit [203823] by
-
- 2 edits in trunk/LayoutTests
Unskip some CSS tests that previously timed out on ios-simulator.
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 11:16 AM Changeset in webkit [203822] by
-
- 1 copy in tags/Safari-603.1.1
New tag.
- 11:14 AM Changeset in webkit [203821] by
-
- 3 edits2 adds in trunk
First parameter to SVGDocument.createEvent() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160296
Reviewed by Alex Christensen.
Source/WebCore:
First parameter to SVGDocument.createEvent() should be mandatory:
- https://www.w3.org/TR/SVG2/struct.html#InterfaceDocumentExtensions
- https://dom.spec.whatwg.org/#document
This patch drops createEvent() from SVGDocument so that the spec-compliant
Document.createEvent() is used instead. In the specification, SVGDocument
no longer exists and is a simple Document.
Firefox and Chrome agree with the specification.
Test: svg/dom/SVGDocument-createEvent.html
- svg/SVGDocument.idl:
LayoutTests:
Add test coverage.
- svg/dom/SVGDocument-createEvent-expected.txt: Added.
- svg/dom/SVGDocument-createEvent.html: Added.
- 11:04 AM Changeset in webkit [203820] by
-
- 6 edits in trunk
Parameters to CanvasGradient.addColorStop() should be mandatory
https://bugs.webkit.org/show_bug.cgi?id=160297
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Parameters to CanvasGradient.addColorStop() should be mandatory:
Firefox and Chrome agree with the specification.
No new tests, rebaselined existing test.
- html/canvas/CanvasGradient.idl:
LayoutTests:
Rebaseline existing test due to behavior change.
- platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
- 11:01 AM Changeset in webkit [203819] by
-
- 4 edits2 adds in trunk/LayoutTests
Unskip some compositing tests on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=152131
Unreviewed test gardening.
- 8:43 AM Changeset in webkit [203818] by
-
- 18 edits6 moves in trunk
[Streams API] Replace ReadableStreamController by ReadableStreamDefaultController
https://bugs.webkit.org/show_bug.cgi?id=160242
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-07-28
Reviewed by Youenn Fablet.
Replaced ReadableStreamController by ReadableStreamDefaultController to align
with updated Streams API specification.
No change in functionality.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/streams/ReadableStream.js:
(initializeReadableStream):
- Modules/streams/ReadableStreamDefaultController.idl: Renamed from Source/WebCore/Modules/streams/ReadableStreamController.idl.
- Modules/streams/ReadableStreamDefaultController.js: Renamed from Source/WebCore/Modules/streams/ReadableStreamController.js.
(enqueue):
(error):
(close):
(desiredSize):
- Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamDefaultController):
(isReadableStreamDefaultController):
- Modules/streams/ReadableStreamSource.h:
(WebCore::ReadableStreamSource::controller):
(WebCore::ReadableStreamSource::start):
- Modules/streams/ReadableStreamSource.idl:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::addBuiltinGlobals):
- bindings/js/JSReadableStreamPrivateConstructors.cpp:
(WebCore::constructJSReadableStreamDefaultController):
(WebCore::JSBuiltinReadableStreamDefaultControllerPrivateConstructor::initializeExecutable):
(WebCore::createReadableStreamDefaultControllerPrivateConstructor):
- bindings/js/JSReadableStreamPrivateConstructors.h:
- bindings/js/JSReadableStreamSourceCustom.cpp:
(WebCore::JSReadableStreamSource::start):
- bindings/js/ReadableStreamDefaultController.cpp: Renamed from Source/WebCore/bindings/js/ReadableStreamController.cpp.
(WebCore::callFunction):
(WebCore::ReadableStreamDefaultController::invoke):
(WebCore::ReadableStreamDefaultController::isControlledReadableStreamLocked):
- bindings/js/ReadableStreamDefaultController.h: Renamed from Source/WebCore/bindings/js/ReadableStreamController.h.
(WebCore::ReadableStreamDefaultController::ReadableStreamDefaultController):
(WebCore::ReadableStreamDefaultController::close):
(WebCore::ReadableStreamDefaultController::error):
(WebCore::ReadableStreamDefaultController::enqueue):
(WebCore::ReadableStreamDefaultController::globalObject):
(WebCore::ReadableStreamDefaultController::error<String>):
- bindings/js/WebCoreBuiltinNames.h:
LayoutTests:
- streams/readable-stream-default-controller-error-expected.txt: Renamed from LayoutTests/streams/readable-stream-controller-error-expected.txt.
- streams/readable-stream-default-controller-error.html: Renamed from LayoutTests/streams/readable-stream-controller-error.html.
- streams/readable-stream-error-messages-expected.txt:
- streams/readable-stream-error-messages.html:
- streams/reference-implementation/readable-stream-expected.txt:
- 5:07 AM Changeset in webkit [203817] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM] Typo fix after r121885
https://bugs.webkit.org/show_bug.cgi?id=160288
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::maxJumpReplacementSize):
- 2:28 AM Changeset in webkit [203816] by
-
- 2 edits in trunk/Source/JavaScriptCore
64-bit alignment check isn't necessary in ARMAssembler::prepareExecutableCopy after r202214
https://bugs.webkit.org/show_bug.cgi?id=159711
Reviewed by Mark Lam.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::prepareExecutableCopy):
- 2:27 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 1:30 AM Changeset in webkit [203815] by
-
- 35 edits in trunk
Compute fetch response type in case of cross-origin requests
https://bugs.webkit.org/show_bug.cgi?id=158565
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-28
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebasing fetch API tests as filtering is now done.
Rebasing XHR tests as console messages are no longer available when trying to access non-exposed headers.
- web-platform-tests/XMLHttpRequest/getresponseheader-cookies-and-more-expected.txt:
- web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt:
- web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-basic-expected.txt:
- web-platform-tests/fetch/api/cors/cors-filtering-expected.txt:
- web-platform-tests/fetch/api/request/request-cache-expected.txt:
Source/WebCore:
Covered by rebased tests.
Implementing Response filtering based on Response tainting in ResourceResponse.
Refactoring code in FetchHeaders and CrossOriginAccessControl.cpp accordingly.
Computing response tainting in SubresourceLoader for all resources.
This is used by DocumentThreadableLoader which now filters responses accordingly for all its clients including fetch and XHR.
Response tainting notably allows computing the response type and filtering out headers in case of cross origin responses.
Removing the filtering implemented in XMLHttpRequest as this is done before it gets access to the headers.
This is triggering some rebasing in the XHR tests as error messages triggered by trying to access unsafe headers no longer happen.
This filtering currently requires creating a new ResourceResponse object from the one sent from CachedResource.
This is done so as the same ResourceResponse may be reused accross loads and may be filtered differently by given to two different DocumentThreadableLoader
This can be mitigated in the future by changing ThreadableLoaderClient API to pass a ResourceResponse&&.
- Modules/fetch/FetchHeaders.cpp: Moving header checking in HTTParsers.h/.cpp
(WebCore::isForbiddenHeaderName): Deleted.
(WebCore::isForbiddenResponseHeaderName): Deleted.
(WebCore::isSimpleHeader): Deleted.
- loader/CrossOriginAccessControl.cpp:
(WebCore::parseAccessControlExposeHeadersAllowList): Deleted.
- loader/CrossOriginAccessControl.h: Moving header checking in HTTParsers.h/.cpp
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::responseReceived):
(WebCore::DocumentThreadableLoader::didReceiveResponse): Doing response filtering. Since underlying loaders are
not yet aware that fetch mode may be cors (it is always no-cors currently), the tainting needs to be updated.
(WebCore::DocumentThreadableLoader::loadRequest): Computing response tainting in case of synchronous calls to ensure headers are filtered for synchronous XHR.
- loader/DocumentThreadableLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::init): Getting origin from its resource and setting response tainting accordingly
(WebCore::SubresourceLoader::willSendRequestInternal): Always calling checkRedirectionCrossOriginAccessControl
to ensure response tainting is computed, even for no-cors resources.
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl): Computing response tainting in case of redirection.
- loader/SubresourceLoader.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load): Computing resource origin from the HTTP headers or from the document if none is
set in the HTTP headers.
(WebCore::CachedResource::setCrossOrigin): Helper routine to set response tainting.
(WebCore::CachedResource::isCrossOrigin): Helper routine to know whether resource is cross origin
(WebCore::CachedResource::isClean):
(WebCore::CachedResource::setResponse): Removing m_responseType
- loader/cache/CachedResource.h:
(WebCore::CachedResource::responseTainting):
(WebCore::CachedResource::origin):
(WebCore::CachedResource::setOpaqueRedirect): Deleted.
- platform/network/HTTPParsers.cpp: Implementing safe response header checking
(WebCore::parseAccessControlExposeHeadersAllowList):
(WebCore::isForbiddenHeaderName):
(WebCore::isForbiddenResponseHeaderName):
(WebCore::isSimpleHeader):
(WebCore::isCrossOriginSafeHeader):
- platform/network/HTTPParsers.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::hasHTTPOrigin): Added.
(WebCore::ResourceRequestBase::clearHTTPOrigin):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp: Implementation of response filtering.
(WebCore::ResourceResponseBase::filterResponse):
- platform/network/ResourceResponseBase.h:
- xml/XMLHttpRequest.cpp:
(WebCore::isSetCookieHeader): Deleted.
(WebCore::XMLHttpRequest::getAllResponseHeaders): Removing header filtering since DocumentThreadableLoader does it.
(WebCore::XMLHttpRequest::getResponseHeader): Ditto.
LayoutTests:
Rebasing fetch API tests as filtering is now done.
Rebasing XHR tests as console messages are no longer available when trying to access non-exposed headers.
- http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt:
- http/tests/xmlhttprequest/access-control-response-with-expose-headers-expected.txt:
- http/tests/xmlhttprequest/get-dangerous-headers-expected.txt:
- http/tests/xmlhttprequest/getResponseHeader-expected.txt:
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt:
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt:
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-expected.txt: