Context Navigation

← Previous Period
Next Period →

Timeline

Apr 14, 2017:

11:48 PM Changeset in webkit [215389] by Wenson Hsieh

3 edits in trunk/Source/WebCore

Implement a way in WebItemProviderPasteboard to perform actions after file loading completes
https://bugs.webkit.org/show_bug.cgi?id=170839
<rdar://problem/31286130>

Reviewed by Tim Horton, Andy Estes, and Dan Bernstein.

Introduces -[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:], which performs an action
after all item providers which are able to provide content are done loading their content into temporary file
URLs. If no item providers have available data, we will immediately invoke the action with an empty URL array.

For each item provider with data, we save the local URL returned in the load completion block to a randomly
generated path in the container's temporary directory. When all files are finished loading, we then invoke the
action with all file URLs that successfully loaded.

No new tests, since there is no change in behavior.

platform/ios/WebItemProviderPasteboard.h:
platform/ios/WebItemProviderPasteboard.mm:

(temporaryFileURLForDataInteractionContent):
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:]):

8:12 PM Changeset in webkit [215388] by Nikita Vasilyev

8 edits
6 adds in trunk

Web Inspector: WebSockets: messages with non-latin letters are displayed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=170760

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add payloadLength property, which is used to display size. When payloadLength is unavailable,
it is calculated from payloadData by Web Inspector frontend.

This fixes <webkit.org/b/170609> Web Inspector: WebSockets: Transferred size is incorrect.

inspector/protocol/Network.json:

Source/WebCore:

Add payloadLength property, which is used to display size. When payloadLength is unavailable,
it is calculated from payloadData by Web Inspector frontend.

This fixes <webkit.org/b/170609> Web Inspector: WebSockets: Transferred size is incorrect.

Tests: http/tests/websocket/tests/hybi/inspector/binary.html

http/tests/websocket/tests/hybi/inspector/send-and-receive.html

inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didReceiveWebSocketFrame):
(WebCore::InspectorNetworkAgent::didSendWebSocketFrame):

Source/WebInspectorUI:

Add payloadLength property, which is used to display size. When payloadLength is unavailable,
it is calculated from payloadData by Web Inspector frontend.

This fixes <webkit.org/b/170609> Web Inspector: WebSockets: Transferred size is incorrect.

UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype._webSocketFrameReceivedOrSent):

UserInterface/Models/WebSocketResource.js:

(WebInspector.WebSocketResource.prototype.addFrame):

LayoutTests:

Test sending and receiving text and binary (blob and array buffer) data.

http/tests/websocket/tests/hybi/inspector/binary-expected.txt: Added.
http/tests/websocket/tests/hybi/inspector/binary.html: Added.
http/tests/websocket/tests/hybi/inspector/binary_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):
(all_distinct_bytes):

http/tests/websocket/tests/hybi/inspector/send-and-receive-expected.txt: Added.
http/tests/websocket/tests/hybi/inspector/send-and-receive.html: Added.
http/tests/websocket/tests/hybi/inspector/send-and-receive_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

7:13 PM Changeset in webkit [215387] by sbarati@apple.com

3 edits
1 add in trunk

ParseInt intrinsic in DFG backend doesn't properly flush its operands
https://bugs.webkit.org/show_bug.cgi?id=170865

Reviewed by Mark Lam and Geoffrey Garen.

JSTests:

stress/parse-int-intrinsic-dfg-backend-flush.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

The DFG backend code needed to first call .gpr()/.jsValueRegs()
before calling flushRegisters(), or the input JSValueOperand would
not be flushed.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileParseInt):

6:52 PM Changeset in webkit [215386] by mark.lam@apple.com

27 edits in trunk

Update architectures in xcconfig files.
https://bugs.webkit.org/show_bug.cgi?id=170867
<rdar://problem/31628104>

Reviewed by Joseph Pecoraro.

Source/bmalloc:

Configurations/Base.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/JavaScriptCore.xcconfig:
Configurations/ToolExecutable.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/opus.xcconfig:

Source/WebCore:

No new tests needed. Only updating xcconfig files.

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

No new tests needed. Only updating xcconfig files.

Configurations/Base.xcconfig:
Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
MobileMiniBrowser/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:

6:14 PM Changeset in webkit [215385] by Wenson Hsieh

23 edits
2 adds in trunk/Source

[WK2] Support Icon creation from file URLs on iOS
https://bugs.webkit.org/show_bug.cgi?id=170809
<rdar://problem/31286130>

Reviewed by Tim Horton.

Source/WebCore:

Minor tweaks and refactoring to support displaying a WebCore::Icon from a list of filepaths on iOS. Please see
below annotations for more details. No new tests yet, as behavior on Mac should not have changed, and behavior
on iOS will not change until later patches land. Tests will be added in a later patch.

Most of the changes here remove platform special-casing in FileInputType for iOS and Mac, refactoring the code
such that it works for both platforms while preserving behavior.

html/FileInputType.cpp:

(WebCore::FileInputType::~FileInputType):
(WebCore::FileInputType::setFiles):
(WebCore::FileInputType::filesChosen):

html/FileInputType.h:

Un-guard m_fileIconLoader on iOS, and un-guard m_displayString for Mac. Consolidate logic in both version of
filesChosen and remove the iOS-specific version. Behavior when passing in an empty display string and null Icon
will be the same as that of the existing filesChosen method on Mac. Also, introduce a version of setFiles that
takes an additional RequestIcon enum that indicates whether or not to additionally use the new filepaths to
request an Icon update. filesChosen invokes this with RequestIcon::No if a non-null Icon was specified, as is
the case when uploading a file via the image picker on iOS.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::displayString):

html/HTMLInputElement.h:
html/InputType.cpp:
html/InputType.h:
loader/EmptyClients.h:
page/ChromeClient.h:

Introduce ChromeClient::createIconForFiles, which generates an icon representing the content at a list of file
paths. See WebKit and WebKit2 ChangeLogs for more details.

platform/FileChooser.h:

(WebCore::FileChooserClient::filesChosen):

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::fileTextValue):

Remove platform special-casing when generating the text to display when uploading a file. If a displayString
is specified, then we use the contents of the displayString; otherwise, fall back to using the input element's
FileList to compute the display string.

Source/WebKit/ios:

Adjust for changes in the ChromeClient in WebCore.

WebCoreSupport/WebChromeClientIOS.h:
WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::createIconForFiles):

Source/WebKit/mac:

Adjust for changes in the ChromeClient in WebCore.

WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::loadIconForFiles):
(WebChromeClient::createIconForFiles):

Source/WebKit2:

Refactors file icon generation logic to support showing an Icon representing the content at a list of file paths
on iOS. Pulls out logic in WKFileUploadPanel responsible for generating the thumbnail image for a file input into
separate helpers in WebIconUtilities, and then uses these utilities in both WKFileUploadPanel and
WebChromeClientIOS.

Shared/ios/WebIconUtilities.h: Added.
Shared/ios/WebIconUtilities.mm: Added.

(WebKit::squareCropRectForSize):
(WebKit::squareImage):
(WebKit::thumbnailSizedImageForImage):
(WebKit::fallbackIconForFile):
(WebKit::iconForImageFile):
(WebKit::iconForVideoFile):
(WebKit::iconForFile):

Add logic for generating thumbnail icons, moved from WKFileUploadPanel.mm.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(squareCropRectForSize): Deleted.
(squareImage): Deleted.
(thumbnailSizedImageForImage): Deleted.
(fallbackIconForFile): Deleted.
(iconForImageFile): Deleted.
(iconForVideoFile): Deleted.
(iconForFile): Deleted.

Remove logic for generating thumbnail icons.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::loadIconForFiles):
(WebKit::WebChromeClient::createIconForFiles):

Rather than call Icon::createIconForFiles directly, loadIconForFiles now consults ChromeClient::createIconForFiles
instead. On other platforms, this just turns around and calls Icon::createIconForFiles, but on iOS, we use the
utilities introduced in WebIconUtilities to generate a file icon.

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::createIconForFiles):

5:52 PM Changeset in webkit [215384] by beidson@apple.com

13 edits
1 add in trunk

Fix basic WKURLSchemeHandler bugs.
<rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862

Reviewed by Andy Estes.

Source/WebCore:

Covered by new API tests.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveDataOrBuffer):

Source/WebKit2:

UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

UIProcess/WebURLSchemeHandlerTask.cpp:

(WebKit::WebURLSchemeHandlerTask::didReceiveResponse):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::addURLSchemeHandlerTaskProxy):
(WebKit::WebLoaderStrategy::removeURLSchemeHandlerTaskProxy):
(WebKit::WebLoaderStrategy::remove):

WebProcess/Network/WebLoaderStrategy.h:

WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp:

(WebKit::WebURLSchemeHandlerProxy::startNewTask):
(WebKit::WebURLSchemeHandlerProxy::taskDidComplete):
(WebKit::WebURLSchemeHandlerProxy::taskDidStopLoading):

WebProcess/WebPage/WebURLSchemeHandlerProxy.h:

WebProcess/WebPage/WebURLSchemeHandlerTaskProxy.cpp:

(WebKit::WebURLSchemeHandlerTaskProxy::WebURLSchemeHandlerTaskProxy):
(WebKit::WebURLSchemeHandlerTaskProxy::stopLoading):
(WebKit::WebURLSchemeHandlerTaskProxy::didReceiveResponse):
(WebKit::WebURLSchemeHandlerTaskProxy::didReceiveData):
(WebKit::WebURLSchemeHandlerTaskProxy::didComplete):
(WebKit::WebURLSchemeHandlerTaskProxy::hasLoader):

WebProcess/WebPage/WebURLSchemeHandlerTaskProxy.h:

(WebKit::WebURLSchemeHandlerTaskProxy::identifier):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.

(-[SchemeHandler initWithData:mimeType:]):
(-[SchemeHandler dealloc]):
(-[SchemeHandler webView:startTask:]):
(-[SchemeHandler webView:stopTask:]):
(TEST):

5:18 PM Changeset in webkit [215383] by jmarcell@apple.com

2 edits in branches/safari-603-branch/Source/JavaScriptCore

Cherry-pick r214637. rdar://problem/31615783

5:17 PM Changeset in webkit [215382] by jiewen_tan@apple.com

20 edits
4 copies
23 adds in trunk

[WebCrypto] Support HKDF
https://bugs.webkit.org/show_bug.cgi?id=170636
<rdar://problem/23539827>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker-expected.txt:
web-platform-tests/WebCryptoAPI/derive_bits_keys/test_hkdf-expected.txt:
web-platform-tests/WebCryptoAPI/import_export/symmetric_importKey.worker-expected.txt:
web-platform-tests/WebCryptoAPI/import_export/test_symmetric_importKey-expected.txt:

Source/WebCore:

This patch implements HKDF according to the spec: https://www.w3.org/TR/WebCryptoAPI/#hkdf.
Supported operations include deriveKey, deriveBits, importKey and getKeyLength.

Tests: crypto/subtle/ecdh-import-key-derive-hkdf-key.html

crypto/subtle/hkdf-derive-bits-malformed-parametrs.html
crypto/subtle/hkdf-import-key-derive-bits.html
crypto/subtle/hkdf-import-key-derive-hmac-key.html
crypto/subtle/hkdf-import-key-malformed-parameters.html
crypto/subtle/hkdf-import-key.html
crypto/workers/subtle/hkdf-import-key-derive-bits.html
crypto/workers/subtle/hkdf-import-key-derive-hmac-key.html
crypto/workers/subtle/hkdf-import-key.html

CMakeLists.txt:
DerivedSources.make:
PlatformGTK.cmake:
PlatformMac.cmake:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
Rename HKDF_CTR to HKDF.

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
Rename HKDF_CTR to HKDF.

crypto/CommonCryptoUtilities.h:
crypto/CryptoAlgorithmIdentifier.h:
crypto/CryptoAlgorithmParameters.h:
crypto/algorithms/CryptoAlgorithmHKDF.cpp: Added.

(WebCore::CryptoAlgorithmHKDF::create):
(WebCore::CryptoAlgorithmHKDF::identifier):
(WebCore::CryptoAlgorithmHKDF::deriveBits):
(WebCore::CryptoAlgorithmHKDF::importKey):
(WebCore::CryptoAlgorithmHKDF::getKeyLength):

crypto/algorithms/CryptoAlgorithmHKDF.h: Added.
crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp: Added.

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/mac/CryptoAlgorithmHKDFMac.cpp: Added.

(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):

crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

crypto/parameters/CryptoAlgorithmHkdfParams.h: Added.
crypto/parameters/HkdfParams.idl: Added.

LayoutTests:

TestExpectations:
crypto/subtle/ecdh-import-key-derive-hkdf-key-expected.txt: Added.
crypto/subtle/ecdh-import-key-derive-hkdf-key.html: Added.
crypto/subtle/hkdf-derive-bits-malformed-parametrs-expected.txt: Added.
crypto/subtle/hkdf-derive-bits-malformed-parametrs.html: Added.
crypto/subtle/hkdf-import-key-derive-bits-expected.txt: Added.
crypto/subtle/hkdf-import-key-derive-bits.html: Added.
crypto/subtle/hkdf-import-key-derive-hmac-key-expected.txt: Added.
crypto/subtle/hkdf-import-key-derive-hmac-key.html: Added.
crypto/subtle/hkdf-import-key-expected.txt: Added.
crypto/subtle/hkdf-import-key-malformed-parameters-expected.txt: Added.
crypto/subtle/hkdf-import-key-malformed-parameters.html: Added.
crypto/subtle/hkdf-import-key.html: Added.
crypto/workers/subtle/hkdf-import-key-derive-bits-expected.txt: Added.
crypto/workers/subtle/hkdf-import-key-derive-bits.html: Added.
crypto/workers/subtle/hkdf-import-key-derive-hmac-key-expected.txt: Added.
crypto/workers/subtle/hkdf-import-key-derive-hmac-key.html: Added.
crypto/workers/subtle/hkdf-import-key-expected.txt: Added.
crypto/workers/subtle/hkdf-import-key.html: Added.
crypto/workers/subtle/resources/hkdf-import-key-derive-bits.js: Added.
crypto/workers/subtle/resources/hkdf-import-key-derive-hmac-key.js: Added.
crypto/workers/subtle/resources/hkdf-import-key.js: Added.

5:09 PM Changeset in webkit [215381] by commit-queue@webkit.org

2 edits in trunk/Tools

webkit-patch failed to detect git repository
https://bugs.webkit.org/show_bug.cgi?id=170859

Patch by Bill Ming <mbbill@gmail.com> on 2017-04-14
Reviewed by Daniel Bates.

Windows cmd does not accept single quoted path. So, using
double quotes here will provide better platform compatibility.

Scripts/VCSUtils.pm:

(isGitDirectory):
(isGitSVNDirectory):
(svnRevisionForDirectory):
(svnInfoForPath):

4:26 PM Changeset in webkit [215380] by Ryan Haddad

3 edits in trunk/Tools

Unreviewed, rolling out r215374.

This change causes LayoutTests to exit early with crashes on
Sierra.

Reverted changeset:

"webkitpy: Ignore previously launched pid when system is under
stress"
https://bugs.webkit.org/show_bug.cgi?id=170741
http://trac.webkit.org/changeset/215374

4:20 PM Changeset in webkit [215379] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

WebAssembly: B3IRGenerator should use phis for result types
https://bugs.webkit.org/show_bug.cgi?id=170863

Reviewed by Filip Pizlo.

Currently, we use variables for the result types of control flow in
Wasm. We did this originally since we weren't sure that the phis we
generated would be optimal. Since then, we have verified that the edges
in wasm control flow ensure that each upsilon will dominate its phi
so we don't need to use variables.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::ControlData::ControlData):
(JSC::Wasm::B3IRGenerator::addTopLevel):
(JSC::Wasm::B3IRGenerator::addBlock):
(JSC::Wasm::B3IRGenerator::addLoop):
(JSC::Wasm::B3IRGenerator::unify):

4:03 PM Changeset in webkit [215378] by Dewei Zhu

12 edits
2 adds in trunk/Websites/perf.webkit.org

Add sub-commit UI in commit log viewer.
https://bugs.webkit.org/show_bug.cgi?id=170379

Reviewed by Ryosuke Niwa.

Add an API to return sub-commits for a given commit.
Add sub-commit difference viewer into commit log viewer to show changed sub-commits between two commits.
Add 'ownsSubCommits' info in 'api/commits' return values.
Extend 'api/manifest' to include whether a repositories owns other repositories.
Only show this sub-commit difference viewer when a repository owns other repositories and both commits owns sub-commits.
Add unit tests for those new features.

browser-tests/commit-log-viewer-tests.js: Updated test cases.
public/api/commits.php: Added 'sub-commits' to provide sub-commit for a given commit.
public/include/commit-log-fetcher.php: Added function to query sub-commit from database. Added 'repository' and 'ownsSubCommits' fields in returning commits.
public/v3/components/expand-collapse-button.js: Added.

(ExpandCollapseButton):
(ExpandCollapseButton.prototype.didConstructShadowTree): Changes state on click and dispatches 'toggle' event.
(ExpandCollapseButton.sizeFactor):
(ExpandCollapseButton.buttonContent):
(ExpandCollapseButton.cssTemplate):

public/v3/components/commit-log-viewer.js:

(CommitLogViewer.prototype._renderCommitList): Added sub-commit viewer if two adjacent commits both have sub-commits.
(CommitLogViewer.cssTemplate):

public/v3/components/sub-commit-viewer.js: Added.

(SubCommitViewer): Added 'SubCommitViewer' class to represent the sub-commit differences between two given commits.`
(SubCommitViewer.prototype.didConstructShadowTree): Makes 'expand-collapse' button listen to 'toggle' event.
(SubCommitViewer.prototype._toggleVisibility): Updates UI once 'expand-collapse' button is clicked.
(SubCommitViewer.prototype.render): Render sub-commit view based on the state.
(SubCommitViewer.prototype._renderSubcommitTable): Generates sub-commits difference table entries.
(SubCommitViewer.htmlTemplate):
(SubCommitViewer.cssTemplate):

public/v3/index.html: Added 'sub-commit-viewer.js' and 'expand-collapse-button.js'.
public/v3/models/commit-log.js:

(CommitLog): Added '_subCommits'.
(CommitLog.prototype.updateSingleton): Updates 'rawData.ownsSubCommits' as well.
(CommitLog.prototype.ownsSubCommits):
(CommitLog.prototype.subCommits): Added. Returns sub-commits.
(CommitLog.prototype.fetchSubCommits): Added. Fetches sub-commits if haven't fetched them before.
(CommitLog.prototype._buildSubCommitMap): Added. Creates a map which maps repositories to commits.
(CommitLog.diffSubCommits): Added. Finds difference between two given commits.
(CommitLog.fetchBetweenRevisions): Updated due to '_constructFromRawData' change.
(CommitLog.fetchForSingleRevision): Updated due to '_constructFromRawData' change.
(CommitLog._constructFromRawData): Removed first argument 'repository' as it can be determined by calling 'Repository.findById'.

public/v3/models/repository.js:

(Repository):
(Repository.prototype.owner): Returns the owner id.
(Repository.prototype.ownedRepositories): Returns a list of repositories owned by this repository.

server-tests/api-commits-tests.js: Added tests for 'sub-commits' filter.
server-tests/api-manifest-tests.js: Added a test.
unit-tests/commit-log-tests.js: Added tests for 'fetchSubCommits' and 'diffSubCommits'.
unit-tests/resources/mock-v3-models.js: Added 'ownerRepository' and 'ownedRepository'.

3:17 PM Changeset in webkit [215377] by mitz@apple.com

2 edits in trunk/Tools

[ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
https://bugs.webkit.org/show_bug.cgi?id=170856

Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.

TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:

2:03 PM Changeset in webkit [215376] by Ryan Haddad

2 edits in trunk/LayoutTests

Skip workers/wasm-* LayoutTests on ios-simulator.

Unreviewed test gardening.

platform/ios/TestExpectations:

1:59 PM Changeset in webkit [215375] by Alan Bujtas

6 edits
2 adds in trunk

text-align start / end failure in table cells
https://bugs.webkit.org/show_bug.cgi?id=141417
<rdar://problem/31051672>

Reviewed by Antti Koivisto.

Source/WebCore:

Apply "text-align: center" on th elements when parent's computed value for the 'text-align' property
is its initial value, unless it is explicitly set.

Test: fast/table/center-th-when-parent-has-initial-text-align.html

css/CSSProperties.json:
css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialTextAlign):
(WebCore::StyleBuilderCustom::applyValueTextAlign):

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::applyProperty):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::hasExplicitlySetTextAlign):
(WebCore::RenderStyle::setHasExplicitlySetTextAlign):
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlySetTextAlign):
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlySetTextAlign):

LayoutTests:

fast/table/center-th-when-parent-has-initial-text-align-expected.html: Added.
fast/table/center-th-when-parent-has-initial-text-align.html: Added.

1:52 PM Changeset in webkit [215374] by Jonathan Bedard

3 edits in trunk/Tools

webkitpy: Ignore previously launched pid when system is under stress
https://bugs.webkit.org/show_bug.cgi?id=170741

Unreviewed infrastructure fix.

Drivers are destroyed between failing layout tests, which is not necessary and
prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._kill_driver): Do not destroy drivers when they are stopped.

Scripts/webkitpy/port/driver.py:

(Driver.stop): Reset driver values set in initializer.

1:52 PM Changeset in webkit [215373] by achristensen@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix Windows build after r215368.
https://bugs.webkit.org/show_bug.cgi?id=170641

CMakeLists.txt:

Add new directory containing files needed in WebCore.

1:34 PM Changeset in webkit [215372] by aestes@apple.com

2 edits in trunk/Tools

[ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
https://bugs.webkit.org/show_bug.cgi?id=167594

Re-enabled this API test now that webkit.org/b/161967 is fixed.

TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:

(TEST):

1:29 PM Changeset in webkit [215371] by aestes@apple.com

4 edits in trunk

[ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
https://bugs.webkit.org/show_bug.cgi?id=161967

Reviewed by Alexey Proskuryakov.

Source/WebCore:

DataDetectorsCoreSPI.h defined DDQueryOffset as a struct of two CFIndexes, which is 16 bytes
on LP64, but the struct is actually defined as two CFIndex-typed 32-bit bitfields, which is
8 bytes on LP64. This breaks the ABI on Public SDK builds when calling functions that take
or return DDQueryOffsets.

platform/spi/cocoa/DataDetectorsCoreSPI.h: Updated the DDQueryOffset definition for

Public SDK builds, and added a static_assert to detect future size changes at compile time.

Tools:

TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:

(TEST): Re-enabled WebKit2.DataDetectionReferenceDate.

12:50 PM Changeset in webkit [215370] by caitp@igalia.com

3 edits
1 add in trunk

[JSC] use ExpressionErrorClassifier for AwaitExpression operand
https://bugs.webkit.org/show_bug.cgi?id=170844

Reviewed by Saam Barati.

JSTests:

stress/regress-170732.js: Added.

Source/JavaScriptCore:

In parseAssignmentExpression(), several cover grammars are handled, and
use ExpressionErrorClassifier to record hints about which grammars to
try.

In parseAwaitExpression(), the hints recorded during parsing of the
operand need to be discarded, because if they propagate to the outer
parseAssignmentExpression(), the hints will lead the parser down invalid
branches that should be skipped.

This change adds an additional ExpressionErrorClassifier to
parseAwaitExpression(), in order to discard hints recorded trying to
parse the operand.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseAwaitExpression):

11:48 AM Changeset in webkit [215369] by Konstantin Tokarev

2 edits in trunk/Source/WebCore

Removed unused and unimplemented methods from MediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=170848

Reviewed by Jer Noble.

No new tests needed.

platform/graphics/MediaPlayer.h:

11:09 AM Changeset in webkit [215368] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

WebAssembly: There is a short window of time where a CodeBlock could be destroyed before all of its async compilation callbacks are called
https://bugs.webkit.org/show_bug.cgi?id=170641

Reviewed by Keith Miller.

There is an unlikely race when a CodeBlock compilation fails,
the module compiles a new CodeBlock for that memory mode, all while
the CodeBlock is notifying its callbacks that it has finished.
There is a chance that the Module could deref its failed CodeBlock
at that point, destroying it, before the callbacks were able to
grab a Ref to the CodeBlock. This patch fixes the race by having the
callbacks ref the CodeBlock.

This patch also has the Plan clear out all of its callbacks
once it gets completed. This adds an extra defense to anybody
that grabs refs to the Plan in the callback.

wasm/WasmCodeBlock.cpp:

(JSC::Wasm::CodeBlock::CodeBlock):
(JSC::Wasm::CodeBlock::compileAsync):

wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::complete):

10:57 AM Changeset in webkit [215367] by Ryan Haddad

2 edits in trunk/Tools

Unreviewed, rolling out r215363.

This change causes LayoutTests to exit early with crashes.

Reverted changeset:

"webkitpy: Ignore previously launched pid when system is under
stress"
https://bugs.webkit.org/show_bug.cgi?id=170741
http://trac.webkit.org/changeset/215363

10:57 AM Changeset in webkit [215366] by mmaxfield@apple.com

5 edits
1 add in trunk

Add performance test for asking the platform for a font for U+2060 WORD JOINER
https://bugs.webkit.org/show_bug.cgi?id=170842

Reviewed by Tim Horton.

PerformanceTests:

Layout/word-joiner.html: Added.

Source/WebCore:

No new tests because there is no behavior change.

platform/graphics/WidthCache.h:

(WebCore::WidthCache::add):
(WebCore::WidthCache::addSlowCase):

Source/WTF:

wtf/unicode/CharacterNames.h:

10:43 AM Changeset in webkit [215365] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

Air::RegLiveness should be constraint-based
https://bugs.webkit.org/show_bug.cgi?id=170817

Reviewed by Saam Barati.

Previously, I changed the Air liveness analyses based on Air::Liveness<> to be
constraint-based and this was a significant speed-up. Now I'm adding the same
functionality to RegLiveness.

This is a 1% speed-up on wasm B3 -O1 compile times.

b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
b3/air/AirLivenessAdapter.h:

(JSC::B3::Air::LivenessAdapter::LivenessAdapter):
(JSC::B3::Air::LivenessAdapter::prepareToCompute):
(JSC::B3::Air::LivenessAdapter::actionsAt):

b3/air/AirRegLiveness.cpp:

(JSC::B3::Air::RegLiveness::RegLiveness):
(JSC::B3::Air::RegLiveness::LocalCalcForUnifiedTmpLiveness::LocalCalcForUnifiedTmpLiveness):
(JSC::B3::Air::RegLiveness::LocalCalcForUnifiedTmpLiveness::execute):
(JSC::B3::Air::RegLiveness::LocalCalc::execute): Deleted.

b3/air/AirRegLiveness.h:

(JSC::B3::Air::RegLiveness::Actions::Actions):
(JSC::B3::Air::RegLiveness::LocalCalcBase::LocalCalcBase):
(JSC::B3::Air::RegLiveness::LocalCalcBase::live):
(JSC::B3::Air::RegLiveness::LocalCalcBase::isLive):
(JSC::B3::Air::RegLiveness::LocalCalc::LocalCalc):
(JSC::B3::Air::RegLiveness::LocalCalc::execute):
(JSC::B3::Air::RegLiveness::LocalCalc::live): Deleted.
(JSC::B3::Air::RegLiveness::LocalCalc::isLive): Deleted.

10:31 AM Changeset in webkit [215364] by Ryan Haddad

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r215350.

This change broke the Windows build.

Reverted changeset:

"Remove unused SharedBuffer constructor"
https://bugs.webkit.org/show_bug.cgi?id=170828
http://trac.webkit.org/changeset/215350

10:08 AM Changeset in webkit [215363] by Jonathan Bedard

2 edits in trunk/Tools

webkitpy: Ignore previously launched pid when system is under stress
https://bugs.webkit.org/show_bug.cgi?id=170741

Unreviewed infrastructure fix.

Drivers are destroyed between failing layout tests, which is not necessary and
prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._kill_driver): Do not destroy drivers when they are stopped.

9:04 AM Changeset in webkit [215362] by jer.noble@apple.com

29 edits in trunk/Source

[MediaSource] Push capabilities across process boundary during UIProcess capture.
https://bugs.webkit.org/show_bug.cgi?id=170814

Reviewed by Eric Carlson.

Source/WebCore:

There's no real reason for RealtimeMediaSourceCapabilities to be RefCounted nor to keep them from
being created on the stack. So in addition to making that class coder-compliant, change all the
classes that vend capabilities to use a unique_ptr<> instead of a RefPtr<>.

Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::capabilities):

Modules/webaudio/MediaStreamAudioSource.h:
platform/mediastream/MediaEndpoint.cpp:
platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::capabilities):

platform/mediastream/MediaStreamTrackPrivate.h:
platform/mediastream/RealtimeMediaSource.h:
platform/mediastream/RealtimeMediaSourceCapabilities.h:

(WebCore::CapabilityValueOrRange::encode):
(WebCore::CapabilityValueOrRange::decode):
(WebCore::RealtimeMediaSourceCapabilities::RealtimeMediaSourceCapabilities):
(WebCore::RealtimeMediaSourceCapabilities::supportedConstraints):
(WebCore::RealtimeMediaSourceCapabilities::setSupportedConstraints):
(WebCore::RealtimeMediaSourceCapabilities::encode):
(WebCore::RealtimeMediaSourceCapabilities::decode):
(WebCore::RealtimeMediaSourceCapabilities::create): Deleted.

platform/mediastream/RealtimeMediaSourceSettings.h:
platform/mediastream/mac/AVMediaCaptureSource.h:
platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::initializeCapabilities):
(WebCore::AVMediaCaptureSource::capabilities):

platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::capabilities):

platform/mediastream/mac/CoreAudioCaptureSource.h:
platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::capabilities):

platform/mediastream/mac/RealtimeIncomingAudioSource.h:
platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::capabilities):

platform/mediastream/mac/RealtimeIncomingVideoSource.h:
platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::initializeCapabilities):
(WebCore::MockRealtimeMediaSource::capabilities):

platform/mock/MockRealtimeMediaSource.h:
platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:

Source/WebKit2:

Make a new synchronous getter for capabilities(), moderated by only requesting the capabilities() cross-process
the first time called.

UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::capabilities):
(WebKit::UserMediaCaptureManagerProxy::supportedConstraints):

UIProcess/Cocoa/UserMediaCaptureManagerProxy.h:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.messages.in:
WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::Source::setCapabilities):
(WebKit::UserMediaCaptureManager::capabilities):

WebProcess/cocoa/UserMediaCaptureManager.h:

8:13 AM Changeset in webkit [215361] by Jonathan Bedard

2 edits in trunk/Tools

webkitpy: Ignore previously launched pid when system is under stress
https://bugs.webkit.org/show_bug.cgi?id=170741

Unreviewed infrastructure fix.

Server processes are destroyed in the driver, which is not necessary and prevents
the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.

Scripts/webkitpy/port/driver.py:

(Driver.run_test): Do not destroy server process.
(Driver._start): Only create the server process if it is None.
(Driver.stop): Do not destroy server process.

2:08 AM Changeset in webkit [215360] by gskachkov@gmail.com

2 edits in trunk/JSTests

Safari 10.1 JSON.parse returns incorrect object for numeric keys with decimal values
https://bugs.webkit.org/show_bug.cgi?id=170442

Reviewed by Yusuke Suzuki.

stress/object-number-properties.js:

12:59 AM Changeset in webkit [215359] by Yusuke Suzuki

3 edits
1 add in trunk

[JSC] Date.parse should accept wider range of representation
https://bugs.webkit.org/show_bug.cgi?id=170720

Reviewed by Darin Adler.

JSTests:

stress/date-relaxed.js: Added.

(shouldBe):
(throw.new.Error):

Source/WTF:

We would like to relax Date.parse to accept the representation "May 8".
At that time, we choose 2000 as a default year. This is because of
the following reason.

According to the V8, this default value is compatible to the old KJS. While current V8 uses 2001, SpiderMonkey does not have such a fallback path. So this reason is not big deal.

It is a leap year. When using new Date("Feb 29"), we assume that people want to save month and day. Leap year can save user inputs if they is valid. If we use the current year instead, the current year may not be a leap year. In that case, new Date("Feb 29").getMonth() becomes 2 (March).

wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

Apr 13, 2017:

11:51 PM Changeset in webkit [215358] by webkit@devinrousso.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Implement autocompletion for CSS variables
https://bugs.webkit.org/show_bug.cgi?id=154441

Reviewed by Joseph Pecoraro.

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.completionControllerCompletionsNeeded):
Add CSS variables to the list of matching completions based on those defined in the current
node's computed style.

9:47 PM Changeset in webkit [215357] by commit-queue@webkit.org

4 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: No context menu available via ENABLE_INSPECTOR_SERVER
https://bugs.webkit.org/show_bug.cgi?id=170705

Patch by Ross Kirsling <Ross Kirsling> on 2017-04-13
Reviewed by Joseph Pecoraro.

Reintroduce old SoftContextMenu class (removed in r157278) and apply various fixes:

Remove legacy globals and prototype extensions.
Align JS/CSS style with current front-end code.
Update UI and fix UX to replicate the macOS native context menu.

Scripts/copy-user-interface-resources.pl:

Add copyright line for Sony Interactive Entertainment.

UserInterface/Base/InspectorFrontendHostStub.js:

(WebInspector.InspectorFrontendHostStub.prototype.showContextMenu):
Use SoftContextMenu.

UserInterface/Main.html:

Include SoftContextMenu.

UserInterface/Views/SoftContextMenu.css: Added.

(.soft-context-menu-glass-pane):
(.soft-context-menu):
(.soft-context-menu > .item):
(.soft-context-menu > .item.disabled):
(.soft-context-menu > .item.highlighted):
(.soft-context-menu > .item > .checkmark):
(.soft-context-menu > .item > .label):
(.soft-context-menu > .item > .submenu-arrow):
(.soft-context-menu > .separator):
(.soft-context-menu > .separator > .line):

UserInterface/Views/SoftContextMenu.js: Added.

(WebInspector.SoftContextMenu):
(WebInspector.SoftContextMenu.prototype.show):
(WebInspector.SoftContextMenu.prototype._consumeEvent):
(WebInspector.SoftContextMenu.prototype._parentGlassPaneElement):
(WebInspector.SoftContextMenu.prototype._createMenuItem):
(WebInspector.SoftContextMenu.prototype._createSeparator):
(WebInspector.SoftContextMenu.prototype._repositionMenuOnScreen):
(WebInspector.SoftContextMenu.prototype._showSubMenu):
(WebInspector.SoftContextMenu.prototype._hideSubMenu):
(WebInspector.SoftContextMenu.prototype._menuItemContextMenu):
(WebInspector.SoftContextMenu.prototype._menuItemMouseDown):
(WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(WebInspector.SoftContextMenu.prototype._menuItemMouseOver):
(WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(WebInspector.SoftContextMenu.prototype._menuKeyDown):
(WebInspector.SoftContextMenu.prototype._glassPaneMouseDown):
(WebInspector.SoftContextMenu.prototype._focus):
(WebInspector.SoftContextMenu.prototype._triggerAction):
(WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(WebInspector.SoftContextMenu.prototype._highlightPrevious):
(WebInspector.SoftContextMenu.prototype._highlightNext):
(WebInspector.SoftContextMenu.prototype._discardMenu):
(WebInspector.SoftContextMenu.prototype._discardSubMenus):

9:46 PM Changeset in webkit [215356] by jfbastien@apple.com

2 edits in trunk/Source/JavaScriptCore

WebAssembly: fix windows build
https://bugs.webkit.org/show_bug.cgi?id=170832

Reviewed by Mark Lam.

My previous patch re-declared isIOS which AssemblerCommon.h
already provided, and which was already included by Options.cpp.

runtime/Options.cpp:

9:33 PM Changeset in webkit [215355] by mitz@apple.com

12 edits
3 adds in trunk

[Cocoa] Allow clients to specify in _WKProcessPoolConfiguration additional directory sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=170387

Reviewed by Sam Weinig.

Source/WebKit2:

Test: TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm

Added an additionalReadAccessAllowedURLs property to _WKProcessPoolConfiguration.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the new

additionalSandboxExtensionHandles member.

(WebKit::WebProcessCreationParameters::decode): Decode it.

Shared/WebProcessCreationParameters.h: Added additionalSandboxExtensionHandles member.

UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy): Copy new m_additionalReadAccessAllowedPaths member.

UIProcess/API/APIProcessPoolConfiguration.h: Added m_additionalReadAccessAllowedPaths member and accessor functions.

UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: Declared new additionalReadAccessAllowedURLs property whose value is an array of URLs to which the Web Content process will be given read access.
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration additionalReadAccessAllowedURLs]): New getter that returns

an array of file URLs from the ProcessPoolConfiguration's additionalReadAccessAllowedPaths().

(-[_WKProcessPoolConfiguration setAdditionalReadAccessAllowedURLs:]): New setter that checks

that the given URLs are file URLs and populates the ProcessPoolConfiguration's
additionalReadAccessAllowedPaths with their paths.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::resolvePathsForSandboxExtensions): Populate the new

m_resolvedPaths.additionalWebProcessSandboxExtensionPaths with resolved paths from the
ProcessPoolConfiguration's additionalReadAccessAllowedPaths.

(WebKit::WebProcessPool::createNewWebProcess): Populate the WebProcessCreationParameters's

additionalSandboxExtensionHandles member with read-only sandbox extensions created from
the resolved paths.

UIProcess/WebProcessPool.h: Added additionalWebProcessSandboxExtensionPaths member to the Paths struct.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Consume the additional sandbox extensions.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm: Added.

(TEST):

TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsPlugin.mm: Added.

(-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[AdditionalReadAccessAllowedURLsPlugIn dealloc]):
(-[AdditionalReadAccessAllowedURLsPlugIn readStringFromURL:completionHandler:]):

TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLsProtocol.h: Added.

9:25 PM Changeset in webkit [215354] by mitz@apple.com

2 edits in trunk/Source/WTF

WTF installs an extra copy of a header outside /usr/local/include/wtf

WTF.xcodeproj/project.pbxproj: Demoted PriorityQueue.h from Private to Project.

7:10 PM Changeset in webkit [215353] by sbarati@apple.com

21 edits
30 adds in trunk

WebAssembly: We should be able to postMessage a JSWebAssemblyModule
https://bugs.webkit.org/show_bug.cgi?id=170573

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch adds a callback to JSRunLoopTimer to notify
clients that a timer has been set. This is used inside
WorkerRunLoop in WebCore so that its RunLoop can perform
an iteration when it sees that a timer got set.

JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSRunLoopTimer.cpp:

(JSC::JSRunLoopTimer::scheduleTimer):
(JSC::JSRunLoopTimer::addTimerSetNotification):
(JSC::JSRunLoopTimer::removeTimerSetNotification):

runtime/JSRunLoopTimer.h:
wasm/WasmCodeBlock.cpp:

(JSC::Wasm::CodeBlock::~CodeBlock):

wasm/WasmCodeBlock.h:
wasm/WasmModule.cpp:

(JSC::Wasm::Module::~Module):
(JSC::Wasm::Module::signatureIndexFromFunctionIndexSpace):
(JSC::Wasm::makeValidationCallback):
(JSC::Wasm::Module::validateSync):
(JSC::Wasm::Module::validateAsync):
(JSC::Wasm::Module::validateSyncImpl): Deleted.
(JSC::Wasm::Module::makeValidationCallback): Deleted.

wasm/WasmModule.h:

(JSC::Wasm::Module::validateSync): Deleted.
(JSC::Wasm::Module::validateAsync): Deleted.
(JSC::Wasm::Module::signatureIndexFromFunctionIndexSpace): Deleted.
(JSC::Wasm::Module::nonNullCodeBlock): Deleted.

wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::create):

wasm/js/JSWebAssemblyCodeBlock.h:

(JSC::JSWebAssemblyCodeBlock::create): Deleted.

wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::source):

wasm/js/JSWebAssemblyModule.h:

(JSC::JSWebAssemblyModule::source): Deleted.

wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

wasm/js/WebAssemblyModulePrototype.cpp:

Source/WebCore:

This patch's main purpose is to implement postMessage of JSWebAssemblyModule.
The spec text describing the behavior is: https://github.com/WebAssembly/design/blob/master/JS.md#structured-clone-of-a-webassemblymodule
We only allow for JSWebAssemblyModule to be serialized in the postMessage
context. More work needs to be done to make it valid to store a module in
IndexDB.

All that is needed to serialize a JSWebAssemblyModule is grab a Ref
to its underlying Wasm::Module. So, when doing a postMessage, all we
do is grab this Ref, and then re-create the JSWebAssemblyModule from
the Wasm::Module in the new VM/global object. Because the code for
Wasm::Module is VM-independent, this is all that's needed. This turned
out nicely, because it requires little knowledge from WebCore about
what it means to clone a JSWebAssemblyModule.

The second significant part of this patch is teaching WorkerRunLoop about
the various timers inside JSC. Before, the WorkerRunLoop wouldn't always
wake up to address JSC timers. I noticed this bug when I was writing
tests to make sure that Wasm was running concurrently in different
workers. The bug is that the WorkerRunLoop's message queue has no insight
into a timer being scheduled. This effected the PromiseDeferredTimer that
Wasm uses, as well as the various GC timers that Heap uses. Now, WorkerRunLoop
will set itself up to be notified when timers are set. When a timer is
set, the WorkerRunLoop will perform an iteration to to reset its top
level MessageQueue timeout to be no longer than the next timer fire date.

Tests: storage/indexeddb/wasm-exceptions.html

workers/wasm-hashset-many.html
workers/wasm-hashset.html
workers/wasm-long-compile-many.html
workers/wasm-long-compile.html

ForwardingHeaders/heap/GCActivityCallback.h: Added.
ForwardingHeaders/runtime/JSRunLoopTimer.h: Added.
ForwardingHeaders/runtime/PromiseDeferredTimer.h: Added.
ForwardingHeaders/wasm: Added.
ForwardingHeaders/wasm/js: Added.
ForwardingHeaders/wasm/js/JSWebAssemblyModule.h: Added.
bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

bindings/js/SerializedScriptValue.h:
bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::addTimerSetNotification):
(WebCore::WorkerScriptController::removeTimerSetNotification):

bindings/js/WorkerScriptController.h:
workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):

LayoutTests:

storage/indexeddb/resources/wasm-exceptions.js: Added.

(const._fail):
(const.isNotA.assert.isNotA):
(const):
(switch.typeof):
(Builder):
(Builder.prototype.setChecked):
(Builder.prototype.setPreamble):
(Builder.prototype._functionIndexSpaceKeyHash):
(Builder.prototype._registerFunctionToIndexSpace):
(Builder.prototype._getFunctionFromIndexSpace):
(Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):
(Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.const.codeBuilder.End.switch.case.string_appeared_here.e):
(Builder.prototype._registerSectionBuilders.this.Unknown):
(prepareDatabase):
(testDatabase):

storage/indexeddb/wasm-exceptions-expected.txt: Added.
storage/indexeddb/wasm-exceptions.html: Added.
workers/wasm-hashset: Added.
workers/wasm-hashset-expected.txt: Added.
workers/wasm-hashset-many-expected.txt: Added.
workers/wasm-hashset-many.html: Added.
workers/wasm-hashset.html: Added.
workers/wasm-hashset/many-test.js: Added.

(reallyDone):
(console.log):
(console.error):
(console.assert):
(i.worker.onmessage):
(Module.print):
(Module.printErr):
(Module.canvas):
(Module.setStatus):
(Module):
(setValue):
(getValue):
(allocate):
(getMemory):
(Pointer_stringify):
(AsciiToString):
(stringToAscii):
(UTF8ArrayToString):
(UTF8ToString):
(stringToUTF8Array):
(stringToUTF8):
(lengthBytesUTF8):
(demangle):
(demangleAll):
(stackTrace):
(alignUp):
(updateGlobalBuffer):
(updateGlobalBufferViews):
(abortOnCannotGrowMemory):
(enlargeMemory):
(getTotalMemory):
(callRuntimeCallbacks):
(preRun):
(ensureInitRuntime):
(preMain):
(exitRuntime):
(postRun):
(addOnPreRun):
(addOnInit):
(addOnPreMain):
(addOnExit):
(addOnPostRun):
(intArrayFromString):
(intArrayToString):
(writeStringToMemory):
(writeArrayToMemory):
(writeAsciiToMemory):
(Math.string_appeared_here):
(addRunDependency):
(removeRunDependency):
(integrateWasmJS.asm2wasmImports.string_appeared_here):
(integrateWasmJS.lookupImport):
(integrateWasmJS.mergeMemory):
(integrateWasmJS.fixImports):
(integrateWasmJS.getBinary):
(integrateWasmJS.doJustAsm):
(integrateWasmJS.receiveInstance):
(integrateWasmJS.):
(integrateWasmJS.doNativeWasm):
(integrateWasmJS.doWasmPolyfill):
(integrateWasmJS.Module.string_appeared_here):
(integrateWasmJS):
(_setErrNo):
(ZSt18uncaught_exceptionv):
(EXCEPTIONS.deAdjust):
(EXCEPTIONS.addRef):
(EXCEPTIONS.decRef):
(EXCEPTIONS.clearRef):
(_cxa_find_matching_catch):
(_gxx_personality_v0):
(_lock):
(_emscripten_memcpy_big):
(_gettimeofday):
(_abort):
(SYSCALLS):
(SYSCALLS.get getStr):
(SYSCALLS.get64):
(SYSCALLS.getZero):
(try._syscall146.printChar):
(_syscall146):
(_syscall54):
(_unlock):
(_syscall6):
(invoke_ii):
(invoke_iiii):
(invoke_v):
(_malloc.Module.string_appeared_here):
(getTempRet0.Module.string_appeared_here):
(_free.Module.string_appeared_here):
(_main.Module.string_appeared_here):
(setTempRet0.Module.string_appeared_here):
(establishStackSpace.Module.string_appeared_here):
(stackSave.Module.string_appeared_here):
(_memset.Module.string_appeared_here):
(_sbrk.Module.string_appeared_here):
(_emscripten_get_global_libc.Module.string_appeared_here):
(_memcpy.Module.string_appeared_here):
(_errno_location.Module.string_appeared_here):
(setThrew.Module.string_appeared_here):
(_fflush.Module.string_appeared_here):
(stackAlloc.Module.string_appeared_here):
(stackRestore.Module.string_appeared_here):
(_llvm_bswap_i32.Module.string_appeared_here):
(runPostSets.Module.string_appeared_here):
(dynCall_ii.Module.string_appeared_here):
(dynCall_iiii.Module.string_appeared_here):
(dynCall_v.Module.string_appeared_here):
(else.applyMemoryInitializer):
(else):
(else.useRequest):
(ExitStatus):
(dependenciesFulfilled):
(Module.string_appeared_here.Module.callMain.callMain.pad):
(Module.string_appeared_here.Module.callMain):
(run.doRun):
(run):
(exit):

workers/wasm-hashset/many-worker.js: Added.

(console.log):
(console.error):
(console.assert):
(Module.print):
(Module.printErr):
(Module.canvas):
(Module.setStatus):
(Module):
(setValue):
(getValue):
(allocate):
(getMemory):
(Pointer_stringify):
(AsciiToString):
(stringToAscii):
(UTF8ArrayToString):
(UTF8ToString):
(stringToUTF8Array):
(stringToUTF8):
(lengthBytesUTF8):
(demangle):
(demangleAll):
(stackTrace):
(alignUp):
(updateGlobalBuffer):
(updateGlobalBufferViews):
(abortOnCannotGrowMemory):
(enlargeMemory):
(getTotalMemory):
(callRuntimeCallbacks):
(preRun):
(ensureInitRuntime):
(preMain):
(exitRuntime):
(postRun):
(addOnPreRun):
(addOnInit):
(addOnPreMain):
(addOnExit):
(addOnPostRun):
(intArrayFromString):
(intArrayToString):
(writeStringToMemory):
(writeArrayToMemory):
(writeAsciiToMemory):
(Math.string_appeared_here):
(addRunDependency):
(removeRunDependency):
(integrateWasmJS.asm2wasmImports.string_appeared_here):
(integrateWasmJS.lookupImport):
(integrateWasmJS.mergeMemory):
(integrateWasmJS.fixImports):
(integrateWasmJS.getBinary):
(integrateWasmJS.doJustAsm):
(integrateWasmJS.receiveInstance):
(integrateWasmJS.doNativeWasm):
(integrateWasmJS.doWasmPolyfill):
(integrateWasmJS.Module.string_appeared_here):
(integrateWasmJS):
(_setErrNo):
(ZSt18uncaught_exceptionv):
(EXCEPTIONS.deAdjust):
(EXCEPTIONS.addRef):
(EXCEPTIONS.decRef):
(EXCEPTIONS.clearRef):
(_cxa_find_matching_catch):
(_gxx_personality_v0):
(_lock):
(_emscripten_memcpy_big):
(_gettimeofday):
(_abort):
(SYSCALLS):
(SYSCALLS.get getStr):
(SYSCALLS.get64):
(SYSCALLS.getZero):
(try._syscall146.printChar):
(_syscall146):
(_syscall54):
(_unlock):
(_syscall6):
(invoke_ii):
(invoke_iiii):
(invoke_v):
(_malloc.Module.string_appeared_here):
(getTempRet0.Module.string_appeared_here):
(_free.Module.string_appeared_here):
(_main.Module.string_appeared_here):
(setTempRet0.Module.string_appeared_here):
(establishStackSpace.Module.string_appeared_here):
(stackSave.Module.string_appeared_here):
(_memset.Module.string_appeared_here):
(_sbrk.Module.string_appeared_here):
(_emscripten_get_global_libc.Module.string_appeared_here):
(_memcpy.Module.string_appeared_here):
(_errno_location.Module.string_appeared_here):
(setThrew.Module.string_appeared_here):
(_fflush.Module.string_appeared_here):
(stackAlloc.Module.string_appeared_here):
(stackRestore.Module.string_appeared_here):
(_llvm_bswap_i32.Module.string_appeared_here):
(runPostSets.Module.string_appeared_here):
(dynCall_ii.Module.string_appeared_here):
(dynCall_iiii.Module.string_appeared_here):
(dynCall_v.Module.string_appeared_here):
(else.applyMemoryInitializer):
(else):
(else.useRequest):
(ExitStatus):
(dependenciesFulfilled):
(Module.string_appeared_here.Module.callMain.callMain.pad):
(Module.string_appeared_here.Module.callMain):
(run.doRun):
(run):
(exit):

workers/wasm-hashset/test.js: Added.

(reallyDone):
(console.log):
(console.error):
(console.assert):
(Module.print):
(Module.printErr):
(Module.canvas):
(Module.setStatus):
(Module):
(setValue):
(getValue):
(allocate):
(getMemory):
(Pointer_stringify):
(AsciiToString):
(stringToAscii):
(UTF8ArrayToString):
(UTF8ToString):
(stringToUTF8Array):
(stringToUTF8):
(lengthBytesUTF8):
(demangle):
(demangleAll):
(stackTrace):
(alignUp):
(updateGlobalBuffer):
(updateGlobalBufferViews):
(abortOnCannotGrowMemory):
(enlargeMemory):
(getTotalMemory):
(callRuntimeCallbacks):
(preRun):
(ensureInitRuntime):
(preMain):
(exitRuntime):
(postRun):
(addOnPreRun):
(addOnInit):
(addOnPreMain):
(addOnExit):
(addOnPostRun):
(intArrayFromString):
(intArrayToString):
(writeStringToMemory):
(writeArrayToMemory):
(writeAsciiToMemory):
(Math.string_appeared_here):
(addRunDependency):
(removeRunDependency):
(integrateWasmJS.asm2wasmImports.string_appeared_here):
(integrateWasmJS.lookupImport):
(integrateWasmJS.mergeMemory):
(integrateWasmJS.fixImports):
(integrateWasmJS.getBinary):
(integrateWasmJS.doJustAsm):
(integrateWasmJS.receiveInstance):
(integrateWasmJS.doNativeWasm):
(integrateWasmJS.doWasmPolyfill):
(integrateWasmJS.Module.string_appeared_here):
(integrateWasmJS):
(_setErrNo):
(ZSt18uncaught_exceptionv):
(EXCEPTIONS.deAdjust):
(EXCEPTIONS.addRef):
(EXCEPTIONS.decRef):
(EXCEPTIONS.clearRef):
(_cxa_find_matching_catch):
(_gxx_personality_v0):
(_lock):
(_emscripten_memcpy_big):
(_gettimeofday):
(_abort):
(SYSCALLS):
(SYSCALLS.get getStr):
(SYSCALLS.get64):
(SYSCALLS.getZero):
(try._syscall146.printChar):
(_syscall146):
(_syscall54):
(_unlock):
(_syscall6):
(invoke_ii):
(invoke_iiii):
(invoke_v):
(_malloc.Module.string_appeared_here):
(getTempRet0.Module.string_appeared_here):
(_free.Module.string_appeared_here):
(_main.Module.string_appeared_here):
(setTempRet0.Module.string_appeared_here):
(establishStackSpace.Module.string_appeared_here):
(stackSave.Module.string_appeared_here):
(_memset.Module.string_appeared_here):
(_sbrk.Module.string_appeared_here):
(_emscripten_get_global_libc.Module.string_appeared_here):
(_memcpy.Module.string_appeared_here):
(_errno_location.Module.string_appeared_here):
(setThrew.Module.string_appeared_here):
(_fflush.Module.string_appeared_here):
(stackAlloc.Module.string_appeared_here):
(stackRestore.Module.string_appeared_here):
(_llvm_bswap_i32.Module.string_appeared_here):
(runPostSets.Module.string_appeared_here):
(dynCall_ii.Module.string_appeared_here):
(dynCall_iiii.Module.string_appeared_here):
(dynCall_v.Module.string_appeared_here):
(else.applyMemoryInitializer):
(else):
(else.useRequest):
(ExitStatus):
(dependenciesFulfilled):
(Module.string_appeared_here.Module.callMain.callMain.pad):
(Module.string_appeared_here.Module.callMain):
(run.doRun):
(run):
(exit):

workers/wasm-hashset/worker.js: Added.

(console.log):
(console.error):
(console.assert):
(Module.print):
(Module.printErr):
(Module.canvas):
(Module.setStatus):
(Module):
(setValue):
(getValue):
(allocate):
(getMemory):
(Pointer_stringify):
(AsciiToString):
(stringToAscii):
(UTF8ArrayToString):
(UTF8ToString):
(stringToUTF8Array):
(stringToUTF8):
(lengthBytesUTF8):
(demangle):
(demangleAll):
(stackTrace):
(alignUp):
(updateGlobalBuffer):
(updateGlobalBufferViews):
(abortOnCannotGrowMemory):
(enlargeMemory):
(getTotalMemory):
(callRuntimeCallbacks):
(preRun):
(ensureInitRuntime):
(preMain):
(exitRuntime):
(postRun):
(addOnPreRun):
(addOnInit):
(addOnPreMain):
(addOnExit):
(addOnPostRun):
(intArrayFromString):
(intArrayToString):
(writeStringToMemory):
(writeArrayToMemory):
(writeAsciiToMemory):
(Math.string_appeared_here):
(addRunDependency):
(removeRunDependency):
(integrateWasmJS.asm2wasmImports.string_appeared_here):
(integrateWasmJS.lookupImport):
(integrateWasmJS.mergeMemory):
(integrateWasmJS.fixImports):
(integrateWasmJS.getBinary):
(integrateWasmJS.doJustAsm):
(integrateWasmJS.receiveInstance):
(integrateWasmJS.):
(integrateWasmJS.doNativeWasm):
(integrateWasmJS.doWasmPolyfill):
(integrateWasmJS.Module.string_appeared_here):
(integrateWasmJS):
(_setErrNo):
(ZSt18uncaught_exceptionv):
(EXCEPTIONS.deAdjust):
(EXCEPTIONS.addRef):
(EXCEPTIONS.decRef):
(EXCEPTIONS.clearRef):
(_cxa_find_matching_catch):
(_gxx_personality_v0):
(_lock):
(_emscripten_memcpy_big):
(_gettimeofday):
(_abort):
(SYSCALLS):
(SYSCALLS.get getStr):
(SYSCALLS.get64):
(SYSCALLS.getZero):
(try._syscall146.printChar):
(_syscall146):
(_syscall54):
(_unlock):
(_syscall6):
(invoke_ii):
(invoke_iiii):
(invoke_v):
(_malloc.Module.string_appeared_here):
(getTempRet0.Module.string_appeared_here):
(_free.Module.string_appeared_here):
(_main.Module.string_appeared_here):
(setTempRet0.Module.string_appeared_here):
(establishStackSpace.Module.string_appeared_here):
(stackSave.Module.string_appeared_here):
(_memset.Module.string_appeared_here):
(_sbrk.Module.string_appeared_here):
(_emscripten_get_global_libc.Module.string_appeared_here):
(_memcpy.Module.string_appeared_here):
(_errno_location.Module.string_appeared_here):
(setThrew.Module.string_appeared_here):
(_fflush.Module.string_appeared_here):
(stackAlloc.Module.string_appeared_here):
(stackRestore.Module.string_appeared_here):
(_llvm_bswap_i32.Module.string_appeared_here):
(runPostSets.Module.string_appeared_here):
(dynCall_ii.Module.string_appeared_here):
(dynCall_iiii.Module.string_appeared_here):
(dynCall_v.Module.string_appeared_here):
(else.applyMemoryInitializer):
(else):
(else.useRequest):
(ExitStatus):
(dependenciesFulfilled):
(Module.string_appeared_here.Module.callMain.callMain.pad):
(Module.string_appeared_here.Module.callMain):
(run.doRun):
(run):
(exit):

workers/wasm-long-compile-expected.txt: Added.
workers/wasm-long-compile-many-expected.txt: Added.
workers/wasm-long-compile-many.html: Added.
workers/wasm-long-compile.html: Added.
workers/wasm-resources: Added.
workers/wasm-resources/long-compile-many.js: Added.

(done):
(i.async.run):
(i.worker.onmessage):

workers/wasm-resources/long-compile-worker.js: Added.

workers/wasm-resources/long-compile.js: Added.

(done):
(async.run):
(worker.onmessage):

6:56 PM Changeset in webkit [215352] by dino@apple.com

4 edits
2 adds in trunk

Large negative animation-delays may not work depending on machine uptime
https://bugs.webkit.org/show_bug.cgi?id=166962
<rdar://problem/30091526>

Reviewed by Tim Horton.

Source/WebCore:

If you set a really negative animation delay, it would cause
AnimationBase::m_startTime to become negative, because the delay
value was "bigger" than monotonicallyIncreasingTime.

However, the state machine was using -1 to mean that the start time
hadn't yet been set. Classic cmarrin!

Replace all the special values with std::optional, and use nullopt
to mean the value doesn't exist yet.

Test: animations/large-negative-delay.html

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::getTimeToNextEvent):
(WebCore::AnimationBase::freezeAtTime):
(WebCore::AnimationBase::getElapsedTime):

page/animation/AnimationBase.h: Use std::optional.

(WebCore::AnimationBase::paused):

LayoutTests:

animations/large-negative-delay-expected.txt: Added.
animations/large-negative-delay.html: Added.

5:09 PM Changeset in webkit [215351] by mark.lam@apple.com

3 edits
1 add in trunk

Should use flushDirect() when flushing the scopeRegister due to needsScopeRegister().
https://bugs.webkit.org/show_bug.cgi?id=170661
<rdar://problem/31579046>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-170661.js: Added.

Source/JavaScriptCore:

Previously, we were using flush() to flush the outermost frame's scopeRegister.
This is incorrect because flush() expects the VirtualRegister value passed to
it to be that of the top most inlined frame. In the event that we reach a
terminal condition while inside an inlined frame, flush() will end up flushing
the wrong register. The fix is simply to use flushDirect() instead.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):

4:54 PM Changeset in webkit [215350] by achristensen@apple.com

4 edits in trunk/Source/WebCore

Remove unused SharedBuffer constructor
https://bugs.webkit.org/show_bug.cgi?id=170828

Reviewed by Brady Eidson.

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):

platform/SharedBuffer.h:

(WebCore::SharedBuffer::create):

4:51 PM Changeset in webkit [215349] by commit-queue@webkit.org

16 edits in trunk

Change Intl prototypes to plain objects
https://bugs.webkit.org/show_bug.cgi?id=168178

Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2017-04-13
Reviewed by JF Bastien.

Source/JavaScriptCore:

builtins/StringPrototype.js:

(localeCompare): Create default Collator once instead of using prototype.

runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototype::IntlCollatorPrototype):

runtime/IntlCollatorPrototype.h:
runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::IntlDateTimeFormatPrototype):

runtime/IntlDateTimeFormatPrototype.h:
runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::IntlNumberFormatPrototype):

runtime/IntlNumberFormatPrototype.h:
runtime/IntlObject.cpp:

(JSC::IntlObject::finishCreation): Don't set constructor on each prototype.

LayoutTests:

js/intl-collator-expected.txt:
js/intl-datetimeformat-expected.txt:
js/intl-numberformat-expected.txt:
js/script-tests/intl-collator.js:
js/script-tests/intl-datetimeformat.js:
js/script-tests/intl-numberformat.js:

4:44 PM Changeset in webkit [215348] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=169719

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

4:20 PM Changeset in webkit [215347] by Antti Koivisto

5 edits
2 adds in trunk

Don't invalidate composition for style changes in non-composited layers
https://bugs.webkit.org/show_bug.cgi?id=170805
<rdar://problem/31606185>

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/updates/animation-non-composited.html

In most cases they can't affect composition. Composition updates are expensive, this can
save a lot of work (tumblr.com animations hit this at the moment).

rendering/RenderElement.h:

(WebCore::RenderElement::createsGroup):
(WebCore::RenderElement::createsGroupForStyle):

Factor to a static function so we can test style directly.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::layerStyleChanged):
(WebCore::RenderLayerCompositor::styleChangeMayAffectIndirectCompositingReasons):

Test if style change might cause compositing change that can't be determined without compositing update.

rendering/RenderLayerCompositor.h:

LayoutTests:

compositing/updates/animation-non-composited-expected.txt: Added.
compositing/updates/animation-non-composited.html: Added.

4:20 PM Changeset in webkit [215346] by Jonathan Bedard

2 edits in trunk/Tools

webkitpy: Ignore previously launched pid when system is under stress
https://bugs.webkit.org/show_bug.cgi?id=170741

Reviewed by David Kilzer.

We have seen cases where xcrun simctl launch will return a pid of a previous
process and the process will appear to be running even though it is crashing.
Ensure that the PID that simulator_process is receiving is not the pid of the
previously run process.

Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Check to make sure we aren't receiving an old PID.

4:13 PM Changeset in webkit [215345] by oliver@apple.com

18 edits in trunk/Source

allocationSize should use safe arithmetic by default
https://bugs.webkit.org/show_bug.cgi?id=170804

Reviewed by JF Bastien.

Make all allocationSize() functions work in terms
of Checked<size_t>

Source/JavaScriptCore:

runtime/DirectArguments.h:

(JSC::DirectArguments::offsetOfSlot):
(JSC::DirectArguments::allocationSize):

runtime/HashMapImpl.h:

(JSC::HashMapBuffer::allocationSize):

runtime/JSArray.h:

(JSC::JSArray::allocationSize):

runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::allocationSize):

runtime/JSAsyncFunction.h:

(JSC::JSAsyncFunction::allocationSize):

runtime/JSFixedArray.h:

(JSC::JSFixedArray::allocationSize):

runtime/JSFunction.h:

(JSC::JSFunction::allocationSize):

runtime/JSGeneratorFunction.h:

(JSC::JSGeneratorFunction::allocationSize):

runtime/JSModuleNamespaceObject.h:
runtime/JSObject.h:

(JSC::JSFinalObject::allocationSize):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::allocationSize):

runtime/ScopedArguments.h:

(JSC::ScopedArguments::allocationSize):

runtime/VM.h:

(JSC::ScratchBuffer::allocationSize):

wasm/js/JSWebAssemblyCodeBlock.h:

(JSC::JSWebAssemblyCodeBlock::offsetOfImportStubs):
(JSC::JSWebAssemblyCodeBlock::allocationSize):

wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::allocationSize):

Source/WTF:

wtf/text/StringImpl.h:

(WTF::StringImpl::allocationSize):
(WTF::StringImpl::tailOffset):

3:48 PM Changeset in webkit [215344] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark webrtc/video-mute.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170704

Unreviewed test gardening.

TestExpectations:

3:24 PM Changeset in webkit [215343] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/media-controls-timeline-updates-when-hovered.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=165553

Unreviewed test gardening.

platform/mac/TestExpectations:

3:15 PM Changeset in webkit [215342] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/track/track-cue-rendering-rtl.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170831

Unreviewed test gardening.

platform/mac/TestExpectations:

3:11 PM Changeset in webkit [215341] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark inspector/sampling-profiler/named-function-expression.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170830

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

2:48 PM Changeset in webkit [215340] by jfbastien@apple.com

35 edits
3 adds in trunk

WebAssembly: manage memory better
https://bugs.webkit.org/show_bug.cgi?id=170628

Reviewed by Keith Miller, Michael Saboff.

JSTests:

wasm/Builder.js: move a helper out so tests can use it

(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):

wasm/WASM.js: add utilities to classify opcodes

(export.opcodes):
(export.const.memoryAccessInfo.op.const.sign):

wasm/function-tests/memory-access-past-4gib.js: Added. This test

fails before this patch.
(const.op.of.WASM.opcodes):

wasm/function-tests/memory-many.js: Added. This simple tests

just shouldn't crash. In verbose mode it's useful at determining
if the GC falls behind or not.

wasm/function-tests/memory-multiagent.js: Added. Emulate postMessage.

(const.startAgents.numAgentsToStart.a.agent.receiveBroadcast):
(const.startAgents.numAgentsToStart.a.write.const.idx.Math.random):
(const.broadcastToAgents):

wasm/js-api/extension-MemoryMode.js: verbose logging.

(testMemoryNoMax):
(testMemory):
(testInstanceNoMemory):
(testInstanceNoMax):
(testInstance):

wasm/utilities.js: move a utility here.

Source/JavaScriptCore:

WebAssembly fast memories weren't managed very well. This patch
refactors it and puts us in a good position to further improve our
fast memory handling in the future.

We now cache fast memories at a process granularity, but make sure
that they don't consume dirty pages. We add a cap to the total
number of allocated fast memories to avoid ASLR degradation.

We teach the GC about memories as a kind of resource it should
care about because it didn't have visibility into the amount of
memory each represented. This allows benchmarks which allocate
memories back-to-back to reliably get fast memories 100% of the
time, even on a system under load, which wasn't the case
before. This reliability yields roughly 8% perf bump on x86-64
WasmBench.

The GC heuristic is as follows: each time we allocate a fast
memory we notify the GC, which then keeps track of the total
number of fast memories allocated since it last GC'd. We
separately keep track of the total number of fast memories which
have ever existed at any point in time (cached + allocated). This
is a monotonically-increasing high watermark. The GC will force a
full collection if, since it last ran, half or more of the high
watermark of fast memories was allocated.

At the same time, if we fail obtaining a fast memory from the
cache we do a GC to try to find one. If that fails we'll allocate
a new one (this can also fail, then we go to slow memory). This
can also be improved, but it's a good start.

This currently disables fast memories on iOS because getting fast
memories isn't a guaranteed thing. Rather, we get quite a few of
them and achieve significant speedups, but benchmarks which
allocate memories back-to-back end up falling behind because the
GC can conservatively hold onto memories, which then yields a perf
cliff. That cliff isn't reliable, WasmBench gets roughly 10 of 18
fast memories when in theory it should get all of them fast (as
MacOS does). The patch significantly improves the state of iOS
though, and in a follow-up we could re-enable fast memories.

Part of this good positioning is a facility to pre-allocate fast
memories very early at startup, before any fragmentation
occurs. This is currently disabled but worked extremely reliably
on iOS. Once we fix the above issues we'll want to re-visit and
turn on pre-allocation.

We also avoid locking for fast memory identification when
performing signal handling. I'm very nervous about acquiring locks
in a signal handler because in general signals can happen when
we've messed up. This isn't the case with fast memories: we're
raising a signal on purpose and handling it. However this doesn't
mean we won't mess up elsewhere! This will get more complicated
once we add support for multiple threads sharing memories and
being able to grow their memories. One example: the code calls
CRASH(), which executes the following code in release:

*(int *)(uintptr_t)0xbbadbeef = 0;

This is a segfault, which our fast memory signal handler tries to
handle. It does so by first figuring out whether 0xbbadbeef is in
a fast memory region, reqiring a lock. If we CRASH() while holding
the lock then our thread self-deadlocks, giving us no crash report
and a bad user experience.

Avoiding a lock therefore it's not about speed or reduced
contention. In fact, I'd use something else than a FIFO if these
were a concern. We're also doing syscalls, which dwarf any locking
cost.

We now only allocate 4GiB + redzone of 64k * 128 for fast memories
instead of 8GiB. This patch reuses the logic from
B3::WasmBoundsCheck to perform bounds checks when accesses could
exceed the redzone. We'll therefore benefit from CSE goodness when
it reaches WasmBoundsCheck. See bug #163469.

b3/B3LowerToAir.cpp: fix a baaaaddd bug where unsigned->signed

conversion allowed out-of-bounds reads by -2GiB. I'll follow-up in
bug #170692 to prevent this type of bug once and for all.
(JSC::B3::Air::LowerToAir::lower):

b3/B3Validate.cpp: update WasmBoundsCheck validation.
b3/B3Value.cpp:

(JSC::B3::Value::effects): update WasmBoundsCheck effects.

b3/B3WasmBoundsCheckValue.cpp:

(JSC::B3::WasmBoundsCheckValue::WasmBoundsCheckValue):
(JSC::B3::WasmBoundsCheckValue::redzoneLimit):
(JSC::B3::WasmBoundsCheckValue::dumpMeta):

b3/B3WasmBoundsCheckValue.h:

(JSC::B3::WasmBoundsCheckValue::maximum):

b3/air/AirCustom.cpp:

(JSC::B3::Air::WasmBoundsCheckCustom::isValidForm):

b3/testb3.cpp:

(JSC::B3::testWasmBoundsCheck):

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::reportWebAssemblyFastMemoriesAllocated):
(JSC::Heap::webAssemblyFastMemoriesThisCycleAtThreshold):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didAllocateWebAssemblyFastMemories):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::collectIfNecessaryOrDefer):

heap/Heap.h:
runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

runtime/Options.cpp:
runtime/Options.h:
wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::fixupPointerPlusOffset):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::emitLoadOp):
(JSC::Wasm::B3IRGenerator::emitStoreOp):
(JSC::Wasm::createJSToWasmWrapper):

wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):

wasm/WasmMemory.cpp: Rewrite.

(JSC::Wasm::makeString):
(JSC::Wasm::Memory::initializePreallocations):
(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::~Memory):
(JSC::Wasm::Memory::fastMappedRedzoneBytes):
(JSC::Wasm::Memory::fastMappedBytes):
(JSC::Wasm::Memory::maxFastMemoryCount):
(JSC::Wasm::Memory::addressIsInActiveFastMemory):
(JSC::Wasm::Memory::grow):

wasm/WasmMemory.h:

(Memory::maxFastMemoryCount):
(Memory::addressIsInActiveFastMemory):

wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):
(JSC::JSWebAssemblyInstance::globalMemoryByteSize):

wasm/js/JSWebAssemblyInstance.h:
wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::grow):
(JSC::JSWebAssemblyMemory::finishCreation):
(JSC::JSWebAssemblyMemory::visitChildren):

Source/WebCore:

Re-use a VM tag which was intended for JavaScript core, was then
used by our GC, and is now unused. If I don't do this then
WebAssembly fast memories will make vmmap look super weird because
it'll look like multi-gigabyte of virtual memory are allocated as
part of our process' regular memory!

Separately I need to update vmmap and other tools to print the
right name. Right now this tag gets identified as "JS garbage
collector".

page/ResourceUsageData.cpp:

(WebCore::ResourceUsageData::ResourceUsageData):

page/ResourceUsageData.h:
page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::HistoricResourceUsageData::HistoricResourceUsageData):

page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::displayNameForVMTag):
(WebCore::categoryForVMTag):

Source/WTF:

Separately I need to update vmmap and other tools to print the
right name. Right now this tag gets identified as "JS garbage
collector".

wtf/OSAllocator.h:
wtf/VMTags.h:

Websites/webkit.org:

docs/b3/intermediate-representation.html: typos

2:41 PM Changeset in webkit [215339] by Ryan Haddad

1 edit
7 adds in trunk/LayoutTests

Add ios-simulator baseline for imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached.html.

Unreviewed test gardening.

platform/ios-simulator/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt: Added.

2:39 PM Changeset in webkit [215338] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark http/tests/inspector/network/resource-request-headers.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170702

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

2:26 PM Changeset in webkit [215337] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Update the comments for the number of bits in RenderStyle::InheritedFlags.

Rubber-stamped by Zalan Bujtas

rendering/style/RenderStyle.h:

2:00 PM Changeset in webkit [215336] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-support/volume-support-click.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=164229

Unreviewed test gardening.

platform/mac/TestExpectations:

1:58 PM Changeset in webkit [215335] by jmarcell@apple.com

9 edits
1 add in branches/safari-603-branch

Cherry-pick r211294. rdar://problem/31512298

1:08 PM Changeset in webkit [215334] by Jonathan Bedard

6 edits
2 adds in trunk/Tools

Build ImageDiff with host SDK
https://bugs.webkit.org/show_bug.cgi?id=168531

Reviewed by David Kilzer.

ImageDiff should be built and run with the host SDK, not the target SDK.
Build ImageDiff twice, once for the target SDK and once for the host
as an intermediate step towards building for only the host SDK.

ImageDiff/Makefile: Added.
Makefile: Add ImageDiff to list of targets.
Scripts/build-imagediff: Build bmalloc and WTF for the host.
Scripts/build-webkit: Build ImageDiff for host.
Scripts/webkitdirs.pm: Export extractNonMacOSHostConfiguration.

(extractNonMacOSHostConfiguration): Remove non-host configuration data from the array.

Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Added.
Scripts/webkitpy/port/base.py:

(Port.check_build): Attempt to build image diff if not found.
(Port.check_image_diff): Enable logging flag.
(Port._build_image_diff): Allow webkitpy to build image-diff during testing.

12:54 PM Changeset in webkit [215333] by BJ Burg

2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: goto arrow is floated to the wrong side
https://bugs.webkit.org/show_bug.cgi?id=170816

Reviewed by Matt Baker.

Float it to the other side if necessary.

UserInterface/Views/Main.css:

(.go-to-link):
(body[dir=ltr] .go-to-link:not(.dont-float)):
(body[dir=rtl] .go-to-link:not(.dont-float)):

12:42 PM Changeset in webkit [215332] by Chris Dumez

3 edits in trunk/LayoutTests

LayoutTest svg/animations/animated-svg-image-outside-viewport-paused.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=170745

Reviewed by Tim Horton.

Test was relying on a setTimeout(30) and was flaky. Now use shouldBecomeEqual() to make the
test more robust.

svg/animations/animated-svg-image-outside-viewport-paused-expected.txt:
svg/animations/animated-svg-image-outside-viewport-paused.html:

12:34 PM Changeset in webkit [215331] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Addressing post-review comment after r215314.
https://bugs.webkit.org/show_bug.cgi?id=169015

Reviewed by Alexey Proskuryakov.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontDatabase::fontForPostScriptName):

12:19 PM Changeset in webkit [215330] by weinig@apple.com

37 edits in trunk/Source/WebCore

[WebIDL] Add support for extended attributes on types in WebIDL
https://bugs.webkit.org/show_bug.cgi?id=170759

Reviewed by Alex Christensen.

Update parsing for WebIDL grammar changes.
Adds an extended attributes hash to IDLType that is filled according to the WebIDL annotated type rules.
Updates code generation to take advantage of IDLType's extended attribute simplifying some existing code.
Update IDLs in the project to adhere to the new grammar.

Modules/indexeddb/IDBFactory.idl:
Modules/indexeddb/IDBIndex.idl:
Modules/indexeddb/IDBKeyRange.idl:
Modules/indexeddb/IDBObjectStore.idl:
Modules/websockets/WebSocket.idl:
crypto/parameters/AesCtrParams.idl:
crypto/parameters/AesKeyParams.idl:
crypto/parameters/Pbkdf2Params.idl:
crypto/parameters/RsaKeyGenParams.idl:
testing/TypeConversions.idl:

Update for grammar change.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):
(GetBaseIDLType):
(GetIDLType):
(GetIntegerConversionConfiguration):
(GetStringConversionConfiguration):
(JSValueToNative):
(UnsafeToNative):
(NativeToJSValueDOMConvertNeedsState):
(NativeToJSValueDOMConvertNeedsGlobalObject):
(NativeToJSValue):
Remove the need for the type's context in many places since type
associated extended attributes are now on the type itself.

bindings/scripts/IDLParser.pm:

(copyExtendedAttributes):
Move up so it can be reused.

(isExtendedAttributeApplicableToTypes):
Add temporary predicated to indicate which attributes should be moved to types. This
logic should be moved to IDLAttributes.txt.

(moveExtendedAttributesApplicableToTypes):
Add helper to move attributes to the type's extended attributes hash if applicable.

(makeSimpleType):
Use initializer syntax to simplify.

(cloneType):
Support cloning types with extended attributes.

(typeByApplyingTypedefs):
When constructing the clone for a typedef application, move any applicable attributes
to the clone from the original type.

(parseDictionaryMember):
(parseTypedef):
(parseAttributeOrOperationRest):
(parseAttributeRest):
(parseOperationOrIterator):
(parseSpecialOperation):
(parseOptionalIterableInterface):
(parseMapLikeProperties):
(parseOptionalOrRequiredArgument):
(parseType):
(parseTypeWithExtendedAttributes):
(parseUnionMemberType):
(parseNonAnyType):
Update for new grammar, moving applicable attributes eagerly.

(assertNoExtendedAttributesInTypedef): Deleted.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionClassMethodWithClampOnOptional):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClampOnOptionalCaller):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRangeOnOptional):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithEnforceRangeOnOptionalCaller):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsAttributeWithClamp):
(WebCore::jsTestTypedefsAttributeWithClampGetter):
(WebCore::jsTestTypedefsAttributeWithClampInTypedef):
(WebCore::jsTestTypedefsAttributeWithClampInTypedefGetter):
(WebCore::setJSTestTypedefsAttributeWithClamp):
(WebCore::setJSTestTypedefsAttributeWithClampFunction):
(WebCore::setJSTestTypedefsAttributeWithClampInTypedef):
(WebCore::setJSTestTypedefsAttributeWithClampInTypedefFunction):
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClampInTypedef):
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClampInTypedefCaller):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestTypedefs.idl:

Update for new grammar. Add some new tests for uncovered cases.

11:53 AM Changeset in webkit [215329] by achristensen@apple.com

4 edits in trunk/Source

Fix CMake build
https://bugs.webkit.org/show_bug.cgi?id=170815

Reviewed by Beth Dakin.

Source/WebCore:

platform/spi/cocoa/AVKitSPI.h:

Source/WebKit2:

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _setShouldCaptureAudioInUIProcess:]):

11:44 AM Changeset in webkit [215328] by jfbastien@apple.com

2 edits in trunk/Source/WebCore

cmake-build-fix

11:28 AM Changeset in webkit [215327] by commit-queue@webkit.org

9 edits in trunk

Remove RTCSignalingState::Closed
https://bugs.webkit.org/show_bug.cgi?id=170811

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-13
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing and rebased tests.

Adding RTCPeerConnection::isClosed to better match the isClosed internal slot in webrtc specification.
Using isClosed instead of checking signalingState value.
Implementing isClosed in terms of m_connectionState which has a Closed value.

Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask):
(WebCore::MediaEndpointPeerConnection::replaceTrackTask):

Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::createOffer):
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createOfferFailed):
(WebCore::PeerConnectionBackend::createAnswer):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::createAnswerFailed):
(WebCore::PeerConnectionBackend::setLocalDescription):
(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setLocalDescriptionFailed):
(WebCore::PeerConnectionBackend::setRemoteDescription):
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
(WebCore::PeerConnectionBackend::addIceCandidate):
(WebCore::PeerConnectionBackend::addIceCandidateSucceeded):
(WebCore::PeerConnectionBackend::addIceCandidateFailed):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::queuedCreateOffer):
(WebCore::RTCPeerConnection::queuedCreateAnswer):
(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::setConfiguration):
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore::RTCPeerConnection::doClose):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

Modules/mediastream/RTCPeerConnection.h:
Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::signalingState):

platform/mediastream/RTCSignalingState.h:

LayoutTests:

webrtc/connection-state.html:

10:54 AM Changeset in webkit [215326] by commit-queue@webkit.org

3 edits in trunk

[WinCairo] Assign WEBKIT_LIBRARIES_DIR to CMAKE_PREFIX_PATH
https://bugs.webkit.org/show_bug.cgi?id=170797

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-04-13
Reviewed by Alex Christensen.

Source/cmake/FindCairo.cmake:
Source/cmake/OptionsWin.cmake:

10:39 AM Changeset in webkit [215325] by Alan Bujtas

3 edits in trunk/Source/WebCore

BreakingContext::WordTrailingSpace cleanup.
https://bugs.webkit.org/show_bug.cgi?id=170750

Reviewed by Myles C. Maxfield.

No change in functionality.

rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

rendering/line/BreakingContext.h:

(WebCore::WordTrailingSpace::WordTrailingSpace):
(WebCore::WordTrailingSpace::width):
(WebCore::BreakingContext::handleText):

10:29 AM Changeset in webkit [215324] by Jonathan Bedard

2 edits in trunk/LayoutTests

Remove compositing/masks/solid-color-masked.html expectation
https://bugs.webkit.org/show_bug.cgi?id=168054

Unreviewed test gardening.

platform/ios/TestExpectations: Remove compositing/masks/solid-color-masked.html.

9:54 AM Changeset in webkit [215323] by commit-queue@webkit.org

1 edit
4 adds in trunk/LayoutTests

Add some more WebRTC tests
https://bugs.webkit.org/show_bug.cgi?id=170796

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-13
Reviewed by Eric Carlson.

webrtc/multi-video-expected.txt: Added.
webrtc/multi-video.html: Added.
webrtc/video-with-data-channel-expected.txt: Added.
webrtc/video-with-data-channel.html: Added.

9:40 AM Changeset in webkit [215322] by commit-queue@webkit.org

10 edits
2 adds in trunk

[Readable Streams API] Implement cloneArrayBuffer in WebCore
https://bugs.webkit.org/show_bug.cgi?id=170008

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-04-13
Reviewed by Youenn Fablet.

Source/WebCore:

Implemented cloneArrayBuffer based on existing structuredCloneArrayBuffer
implementation. The code has been factorized so that both cloneArrayBuffer
and structuredCloneArrayBuffer rely on the same code (which is basically
the previous implementation of structuredCloneArrayBuffer + the ability
to clone only a part of considered buffer).

Test: streams/clone-array-buffer.html

Modules/streams/ReadableByteStreamInternals.js: Deleted cloneArrayBuffer JS implementation.
bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals): Add cloneArrayBuffer private declaration.

bindings/js/StructuredClone.cpp:

(WebCore::cloneArrayBufferImpl): Added (mostly based on previous structuredCloneArrayBuffer).
(WebCore::cloneArrayBuffer): Added.
(WebCore::structuredCloneArrayBuffer): Updated.

bindings/js/StructuredClone.h: Added cloneArrayBuffer declaration.
bindings/js/WebCoreBuiltinNames.h: Added cloneArrayBuffer declaration.
testing/Internals.cpp: Added support for testing cloneArrayBuffer.
testing/Internals.h: Added support for testing cloneArrayBuffer.
testing/Internals.idl: Added support for testing cloneArrayBuffer.

LayoutTests:

Added test to check cloneArrayBuffer behaviour.

streams/clone-array-buffer-expected.txt: Added.
streams/clone-array-buffer.html: Added.

9:38 AM Changeset in webkit [215321] by commit-queue@webkit.org

9 edits in trunk

onnegotiationneeded should only be called once
https://bugs.webkit.org/show_bug.cgi?id=170785

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-13
Reviewed by Alex Christensen.

Source/WebCore:

Covered by updated test.

Disabling explicit call to markAsNeedingNegotiation in case libwebrtc is used as libwebrtc is calling it.
Making sure removeTrack gets notified up to libwebrtc.

Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::notifyRemovedTrack):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::completeAddTransceiver):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::removeTrack):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::notifyRemovedTrack):

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

webrtc/negotiatedneeded-event-addStream.html:

9:37 AM Changeset in webkit [215320] by hyatt@apple.com

4 edits
2 adds in trunk

Rendering flexbox children across columns
https://bugs.webkit.org/show_bug.cgi?id=164166
<rdar://problem/29055587>

Reviewed by Zalan Bujtas.

Source/WebCore:

Added fast/multicol/flexbox-rows.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForUnsplittableChild):

LayoutTests:

fast/multicol/flexbox-rows-expected.html: Added.
fast/multicol/flexbox-rows.html: Added.

8:28 AM Changeset in webkit [215319] by achristensen@apple.com

6 edits in trunk

Clean up SharedBuffer public functions
https://bugs.webkit.org/show_bug.cgi?id=170795

Reviewed by Andreas Kling.

Source/WebCore:

Make some member functions that are now only used internally private.

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::platformDataSize): Deleted.

platform/SharedBuffer.h:

Tools:

TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

7:17 AM Changeset in webkit [215318] by Yusuke Suzuki

6 edits in trunk/Source

[JSC] Use proper ifdef guard for code using MachineContext
https://bugs.webkit.org/show_bug.cgi?id=170800

Reviewed by Carlos Alberto Lopez Perez.

Source/JavaScriptCore:

This patch drops MachineContext use if it is not available.
This situation can be considered like, building WebKit with musl.
In that case, we simply disable features that rely on MachineContext.
Examples are wasm fast memory, sampling profiler, and code profiling.

runtime/Options.cpp:

(JSC::overrideDefaults):

tools/CodeProfiling.cpp:

(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):
Previously, PLATFORM(GTK) is excluded. But it is not obvious why it is excluded.
This patch just includes such platforms.

wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::enableFastMemory):

Source/WTF:

SamplingProfiler and FastMemory rely on MachineContext feature.

wtf/Platform.h:

1:31 AM Changeset in webkit [215317] by Antti Koivisto

2 edits in trunk/LayoutTests

Try to unflake a test.

http/tests/cache/disk-cache/disk-cache-media-small.html:

Apr 12, 2017:

11:55 PM Changeset in webkit [215316] by mitz@apple.com

52 edits in trunk

[Mac] Future-proof .xcconfig files
https://bugs.webkit.org/show_bug.cgi?id=170802

Reviewed by Tim Horton.

Source/bmalloc:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Source/JavaScriptCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/ThirdParty/ANGLE:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Source/ThirdParty/libwebrtc:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/opus.xcconfig:

Source/WebCore:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebCore/PAL:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebInspectorUI:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit/mac:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WebKit2:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:
Configurations/FeatureDefines.xcconfig:
Configurations/Version.xcconfig:

Source/WTF:

Configurations/Base.xcconfig:
Configurations/DebugRelease.xcconfig:

Tools:

DumpRenderTree/mac/Configurations/Base.xcconfig:
DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
MiniBrowser/Configurations/Base.xcconfig:
MiniBrowser/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/Base.xcconfig:
TestWebKitAPI/Configurations/DebugRelease.xcconfig:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
WebKitTestRunner/Configurations/Base.xcconfig:
WebKitTestRunner/Configurations/DebugRelease.xcconfig:

11:38 PM Changeset in webkit [215315] by beidson@apple.com

26 edits
4 adds
2 deletes in trunk

QuotaExceededError when saving to localStorage in private mode.
https://bugs.webkit.org/show_bug.cgi?id=157010

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by changes to existing test).

LocalStorage in private browsing is now effectively SessionStorage.
It's ephemeral, per-tab, and copied over to tabs window.open()'ed from the current.

loader/EmptyClients.cpp:

(WebCore::EmptyStorageNamespaceProvider::createEphemeralLocalStorageNamespace):

page/Chrome.cpp:

(WebCore::Chrome::createWindow):

page/Page.cpp:

(WebCore::Page::ephemeralLocalStorage):
(WebCore::Page::setEphemeralLocalStorage):

page/Page.h:

page/SecurityOriginData.h:

storage/Storage.cpp:

(WebCore::Storage::length):
(WebCore::Storage::key):
(WebCore::Storage::getItem):
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::clear):
(WebCore::Storage::contains):
(WebCore::Storage::isDisabledByPrivateBrowsing): Deleted.

storage/StorageMap.h:

storage/StorageNamespaceProvider.cpp:

(WebCore::StorageNamespaceProvider::localStorageArea):

storage/StorageNamespaceProvider.h:

storage/StorageType.h:

(WebCore::isLocalStorage):
(WebCore::isPersistentLocalStorage):

Source/WebKit:

Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::createEphemeralLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::StorageNamespaceImpl):
(WebKit::StorageNamespaceImpl::~StorageNamespaceImpl):
(WebKit::StorageNamespaceImpl::copy):
(WebKit::StorageNamespaceImpl::close):

Storage/StorageNamespaceImpl.h:

Storage/WebStorageNamespaceProvider.cpp:

(WebKit::WebStorageNamespaceProvider::createEphemeralLocalStorageNamespace):

Storage/WebStorageNamespaceProvider.h:

Source/WebKit2:

WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):

WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::createEphemeralLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::storageArea):
(WebKit::StorageNamespaceImpl::ephemeralLocalStorageArea):
(WebKit::StorageNamespaceImpl::copy):

WebProcess/Storage/StorageNamespaceImpl.h:

WebProcess/Storage/WebStorageNamespaceProvider.cpp:

(WebKit::WebStorageNamespaceProvider::createEphemeralLocalStorageNamespace):

WebProcess/Storage/WebStorageNamespaceProvider.h:

LayoutTests:

platform/mac-wk2/TestExpectations:
storage/domstorage/localstorage/private-browsing-affects-storage-expected.txt:
storage/domstorage/localstorage/private-browsing-affects-storage.html:
storage/domstorage/localstorage/resources/private-browsing-1.html: Added.
storage/domstorage/localstorage/resources/private-browsing-2.html: Added.
storage/domstorage/localstorage/resources/private-browsing-3.html: Added.
storage/domstorage/localstorage/resources/private-browsing-storage-2.html: Added.
storage/domstorage/sessionstorage/private-browsing-affects-storage-expected.txt: Removed.
storage/domstorage/sessionstorage/private-browsing-affects-storage.html: Removed.

10:49 PM Changeset in webkit [215314] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

[Cocoa] Suppress font download dialog in new matching algorithm
https://bugs.webkit.org/show_bug.cgi?id=169015

Reviewed by Alexey Proskuryakov.

Not testable.

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontDatabase::lookupPostScriptName):

9:29 PM Changeset in webkit [215313] by Yusuke Suzuki

2 edits in trunk/Source/WebKit2

Unreviewed, fix build failure on Ubuntu LTS GTK bot
https://bugs.webkit.org/show_bug.cgi?id=170781

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

8:12 PM Changeset in webkit [215312] by commit-queue@webkit.org

12 edits
1 add in trunk

test262: test262/test/built-ins/NativeErrors/EvalError/proto.js
https://bugs.webkit.org/show_bug.cgi?id=170668

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-12
Reviewed by Keith Miller.

JSTests:

ChakraCore.yaml:
ChakraCore/test/Lib/error.baseline-jsc: Added.

This test does not match the spec.

test262.yaml:

Source/JavaScriptCore:

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
The Prototype of NativeError Constructor's should be the %Error%.
https://tc39.github.io/ecma262/#sec-properties-of-the-nativeerror-constructors

LayoutTests:

ietestcenter/Javascript/15.2.3.2-2-12-expected.txt:
ietestcenter/Javascript/15.2.3.2-2-13-expected.txt:
ietestcenter/Javascript/15.2.3.2-2-14-expected.txt:
ietestcenter/Javascript/15.2.3.2-2-15-expected.txt:
ietestcenter/Javascript/15.2.3.2-2-16-expected.txt:
ietestcenter/Javascript/15.2.3.2-2-17-expected.txt:

These tests are now out of date.

7:51 PM Changeset in webkit [215311] by commit-queue@webkit.org

9 edits in trunk

test262: test262/test/language/literals/regexp/u-dec-esc.js
https://bugs.webkit.org/show_bug.cgi?id=170687

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-12
Reviewed by Michael Saboff.

JSTests:

test262.yaml:

Source/JavaScriptCore:

yarr/YarrParser.h:

(JSC::Yarr::Parser::parseEscape):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPattern::errorMessage):
(JSC::Yarr::YarrPattern::compile):

yarr/YarrPattern.h:

In unicoe patterns, invalid backreferences are an error.

LayoutTests:

js/regexp-unicode-expected.txt:
js/script-tests/regexp-unicode.js:

Extend test to test invalid backreferences.

7:26 PM Changeset in webkit [215310] by fpizlo@apple.com

6 edits
2 adds in trunk/Source/JavaScriptCore

Move common stack allocation utilities out of AirAllocateStackByGraphColoring.cpp
https://bugs.webkit.org/show_bug.cgi?id=170799

Reviewed by Michael Saboff and Keith Miller.

When I added stack allocation to allocateRegistersByLinearScan, I reused a handful of
utility functions from AirAllocateStackByGraphColoring.cpp. I accomplished this by
putting their declarations in AirAllocateStackByGraphColoring.h.

That was pretty weird.

This patch moves a family of stack allocation helper functions out of
AirAllocateStackByGraphColoring.cpp and into the new AirStackAllocation.h|cpp. The
linear scan stack allocator no longer has to include the other stack allocator's
header, which addresses my OCD.

I moved the functions transitively reachable from the two functions that the linear
scan allocator needed. This forced me to give them better names (i.e. no "fooBarImpl")
and short descriptive comments. I think that such comments are useful in code that is
doing a convoluted version of some theoretical concept.

No behavior change.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
b3/air/AirAllocateRegistersAndStackByLinearScan.cpp:
b3/air/AirAllocateStackByGraphColoring.cpp:

(JSC::B3::Air::allocateStackByGraphColoring):
(JSC::B3::Air::allocateEscapedStackSlots): Deleted.
(JSC::B3::Air::updateFrameSizeBasedOnStackSlots): Deleted.

b3/air/AirAllocateStackByGraphColoring.h:
b3/air/AirStackAllocation.cpp: Added.

(JSC::B3::Air::attemptAssignment):
(JSC::B3::Air::assign):
(JSC::B3::Air::allocateAndGetEscapedStackSlotsWithoutChangingFrameSize):
(JSC::B3::Air::allocateEscapedStackSlots):
(JSC::B3::Air::updateFrameSizeBasedOnStackSlots):

b3/air/AirStackAllocation.h: Added.

5:40 PM Changeset in webkit [215309] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r215242-215243): [ios-simulator] API test WebKit1.AudioSessionCategoryIOS is failing
https://bugs.webkit.org/show_bug.cgi?id=170777
<rdar://problem/31592877>

Reviewed by Jer Noble.

No new tests, fixes an existing test.

platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState): Pass parameters to lambda by reference.

5:36 PM Changeset in webkit [215308] by jmarcell@apple.com

1 copy in tags/Safari-603.2.3

Tag Safari-603.2.3.

5:34 PM Changeset in webkit [215307] by jmarcell@apple.com

1 delete in tags/Safari-603.2.3

Deleting tag.

4:41 PM Changeset in webkit [215306] by jmarcell@apple.com

7 edits in trunk/Source

Versioning.

4:37 PM Changeset in webkit [215305] by jmarcell@apple.com

1 copy in tags/Safari-604.1.17

Tag Safari-604.1.17.

4:07 PM Changeset in webkit [215304] by eric.carlson@apple.com

3 edits in trunk/Source/WebKit2

[MediaStream] rename -[WKWebView _stopMediaCapture]
https://bugs.webkit.org/show_bug.cgi?id=170791
<rdar://problem/31589204>

Reviewed by Youenn Fablet.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _muteMediaCapture]):
(-[WKWebView _stopMediaCapture]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

3:49 PM Changeset in webkit [215303] by jmarcell@apple.com

5 edits in branches/safari-603-branch/Source

Versioning.

3:44 PM Changeset in webkit [215302] by Ryan Haddad

2 edits in trunk/Source/WebKit2

Unreviewed build fix.

UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didSelectPaymentMethod:handler:]):
(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didSelectShippingMethod:handler:]):
(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didSelectShippingContact:handler:]):
(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingMethodSelection):
(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):
(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentMethodSelection):

3:44 PM Changeset in webkit [215301] by Jonathan Bedard

6 edits in trunk/LayoutTests

Move expectation for compositing/iframes/iframe-size-from-zero.htm to top level

Unreviewed test gardening.

TestExpectations: Marked compositing/iframes/iframe-size-from-zero.html as flaky.
platform/ios-wk1/TestExpectations: Move test expectation to top level.
platform/mac-wk1/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.
platform/wk2/TestExpectations: Ditto.

3:34 PM Changeset in webkit [215300] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[MediaStream] Set correct audio session category when capturing audio
https://bugs.webkit.org/show_bug.cgi?id=170736
<rdar://problem/31559405>

Unreviewed, update an assertion I missed in r215242.

platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::PlatformMediaSession):

3:26 PM Changeset in webkit [215299] by achristensen@apple.com

5 edits in trunk

Remove unused SharedBuffer::wrapCFDataArray
https://bugs.webkit.org/show_bug.cgi?id=170794

Reviewed by Brady Eidson.

Source/WebCore:

It's unused since r215280.

platform/SharedBuffer.h:
platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::wrapCFDataArray): Deleted.

Tools:

TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:

(TestWebKitAPI::TEST_F):

3:23 PM Changeset in webkit [215298] by jer.noble@apple.com

3 edits in trunk/Source/WebKit2

[WK2] Add a C-API for creating a WKContextConfigurationRef with legacy options.
https://bugs.webkit.org/show_bug.cgi?id=170790

Reviewed by Alex Christensen.

UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCreate):
(WKContextConfigurationCreateWithLegacyOptions):

UIProcess/API/C/WKContextConfigurationRef.h:

3:06 PM Changeset in webkit [215297] by jer.noble@apple.com

10 edits in trunk/Source/WebKit2

[WK2] Do not pass microphone sandbox extension to WebProcess if capturing is happening in UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=170781

Reviewed by Alex Christensen.

Simultaneously, allow clients to configure whether capturing will occur in the UIProcess through
_WKProcessPoolConfiguration.

UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

UIProcess/API/APIProcessPoolConfiguration.h:
UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationShouldCaptureAudioInUIProcess):
(WKContextConfigurationSetShouldCaptureAudioInUIProcess):

UIProcess/API/C/WKContextConfigurationRef.h:
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _shouldCaptureAudioInUIProcess]):
(-[WKWebViewConfiguration _setShouldCaptureAudioInUIProcess:]):

UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration shouldCaptureAudioInUIProcess]):
(-[_WKProcessPoolConfiguration setShouldCaptureAudioInUIProcess:]):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

2:59 PM Changeset in webkit [215296] by jmarcell@apple.com

1 copy in tags/Safari-603.2.3

Tag Safari-603.2.3.

2:51 PM Changeset in webkit [215295] by Beth Dakin

2 edits in trunk/Source/WebKit/mac

Build fix.

WebView/WebViewData.h:

2:46 PM Changeset in webkit [215294] by Keith Rollin

2 edits in trunk/Source/WebKit2

Add some missing NetworkResourceLoader logging
https://bugs.webkit.org/show_bug.cgi?id=170139

Reviewed by Alex Christensen.

Once execution enters the lambda in
NetworkResourceLoader::retrieveCacheEntry, there is little indication
of which exit point was taken. If flow enters into startNetworkLoad,
we'll get some logging from that function, but not from the others.
Add some logging so that we know what the result was from looking up
the resource in the cache.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):

2:34 PM Changeset in webkit [215293] by jmarcell@apple.com

4 edits in branches/safari-603-branch

Cherry-pick r215117. rdar://problem/31512298

2:22 PM Changeset in webkit [215292] by fpizlo@apple.com

22 edits
2 moves
2 adds
2 deletes in trunk

B3 -O1 should not allocateStackByGraphColoring
https://bugs.webkit.org/show_bug.cgi?id=170742

Reviewed by Keith Miller.

One of B3 -O1's longest running phases is allocateStackByGraphColoring. One approach to
this would be to make that phase cheaper. But it's weird that this phase reruns
liveness after register allocation already ran liveness. If only it could reuse the
liveness computed by register allocation then it would run a lot faster. At -O2, we do
not want this, since we run phases between register allocation and stack allocation,
and those phases are free to change the liveness of spill slots (in fact,
fixObviousSpills will both shorten and lengthen live ranges because of load and store
elimination, respectively). But at -O1, we don't really need to run any phases between
register and stack allocation.

This changes Air's backend in the following ways:

Linear scan does stack allocation. This means that we don't need to run allocateStackByGraphColoring at all. In reality, we reuse some of its innards, but we don't run the expensive part of it (liveness->interference->coalescing->coloring). This is a speed-up because we only run liveness once and reuse it for both register and stack allocation.

Phases that previously ran between register and stack allocation are taken care of, each in its own special way:

-> handleCalleSaves: this is now a utility function called by both

allocateStackByGraphColoring and allocateRegistersAndStackByLinearScan.

-> fixObviousSpills: we didn't run this at -O1, so nothing needs to be done.

-> lowerAfterRegAlloc: this needed to be able to run before stack allocation because

it could change register usage (vis a vis callee saves) and it could introduce
spill slots. I changed this phase to have a secondary mode for when it runs after
stack allocation.

The part of allocateStackByGraphColoring that lowered stack addresses and took care of the call arg area is now a separate phase called lowerStackArgs. We run this phase regardless of optimization level. It's a cheap and general lowering.

This also removes spillEverything, because we never use that phase, we never test it,
and it got in the way in this refactoring.

This is a 21% speed-up on wasm -O1 compile times. This does not significantly change
-O1 throughput. We had already disabled allocateStack's most important optimization
(spill coalescing). This probably regresses average stack frame size, but I didn't
measure by how much. Stack frame size is really not that important. The algorithm in
allocateStackByGraphColoring is about much more than optimal frame size; it also
tries to avoid having to zero-extend 32-bit spills, it kills dead code, and of course
it coalesces.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
b3/B3Procedure.cpp:

(JSC::B3::Procedure::calleeSaveRegisterAtOffsetList):
(JSC::B3::Procedure::calleeSaveRegisters): Deleted.

b3/B3Procedure.h:
b3/B3StackmapGenerationParams.cpp:

(JSC::B3::StackmapGenerationParams::unavailableRegisters):

b3/air/AirAllocateRegistersAndStackByLinearScan.cpp: Copied from Source/JavaScriptCore/b3/air/AirAllocateRegistersByLinearScan.cpp.

(JSC::B3::Air::allocateRegistersAndStackByLinearScan):
(JSC::B3::Air::allocateRegistersByLinearScan): Deleted.

b3/air/AirAllocateRegistersAndStackByLinearScan.h: Copied from Source/JavaScriptCore/b3/air/AirAllocateRegistersByLinearScan.h.
b3/air/AirAllocateRegistersByLinearScan.cpp: Removed.
b3/air/AirAllocateRegistersByLinearScan.h: Removed.
b3/air/AirAllocateStackByGraphColoring.cpp:

(JSC::B3::Air::allocateEscapedStackSlots):
(JSC::B3::Air::updateFrameSizeBasedOnStackSlots):
(JSC::B3::Air::allocateStackByGraphColoring):

b3/air/AirAllocateStackByGraphColoring.h:
b3/air/AirArg.cpp:

(JSC::B3::Air::Arg::stackAddr):

b3/air/AirArg.h:

(JSC::B3::Air::Arg::stackAddr): Deleted.

b3/air/AirCode.cpp:

(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::setCalleeSaveRegisterAtOffsetList):
(JSC::B3::Air::Code::calleeSaveRegisterAtOffsetList):
(JSC::B3::Air::Code::dump):

b3/air/AirCode.h:

(JSC::B3::Air::Code::setStackIsAllocated):
(JSC::B3::Air::Code::stackIsAllocated):
(JSC::B3::Air::Code::calleeSaveRegisters):

b3/air/AirGenerate.cpp:

(JSC::B3::Air::prepareForGeneration):
(JSC::B3::Air::generate):

b3/air/AirHandleCalleeSaves.cpp:

(JSC::B3::Air::handleCalleeSaves):

b3/air/AirHandleCalleeSaves.h:
b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

b3/air/AirLowerStackArgs.cpp: Added.

(JSC::B3::Air::lowerStackArgs):

b3/air/AirLowerStackArgs.h: Added.
b3/testb3.cpp:

(JSC::B3::testPinRegisters):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

jit/RegisterAtOffsetList.h:
wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile):

2:11 PM Changeset in webkit [215291] by dino@apple.com

19 edits in trunk/LayoutTests

canvas/2d.gradient.* LayoutTests failing
https://bugs.webkit.org/show_bug.cgi?id=170757
<rdar://problem/31177990>

Reviewed by Antoine Quint.

Add a fudge factor to the gradient tests, since we can
now produce noisy (nicer looking) gradients. There might
be 1 or 2 bits of difference per pixel.

canvas/philip/tests.js:

(_assertPixelWithGradientNoise):

canvas/philip/tests/2d.gradient.linear.transform.1.html:
canvas/philip/tests/2d.gradient.linear.transform.2.html:
canvas/philip/tests/2d.gradient.linear.transform.3.html:
canvas/philip/tests/2d.gradient.radial.cone.bottom.html:
canvas/philip/tests/2d.gradient.radial.cone.cylinder.html:
canvas/philip/tests/2d.gradient.radial.cone.front.html:
canvas/philip/tests/2d.gradient.radial.cone.shape1.html:
canvas/philip/tests/2d.gradient.radial.cone.top.html:
canvas/philip/tests/2d.gradient.radial.inside1.html:
canvas/philip/tests/2d.gradient.radial.inside2.html:
canvas/philip/tests/2d.gradient.radial.inside3.html:
canvas/philip/tests/2d.gradient.radial.outside1.html:
canvas/philip/tests/2d.gradient.radial.outside2.html:
canvas/philip/tests/2d.gradient.radial.outside3.html:
canvas/philip/tests/2d.gradient.radial.touch2.html:
fast/canvas/script-tests/canvas-gradient-on-compositing.js:
fast/canvas/canvas-gradient-on-compositing-expected.html:

2:08 PM Changeset in webkit [215290] by andersca@apple.com

6 edits in trunk/Source

Tweak WebCore::setMetadataURL function
https://bugs.webkit.org/show_bug.cgi?id=170786

Reviewed by Beth Dakin.

Source/WebCore:

Get rid of the "referrer" parameter, it isn't used. Make the remaining parameters const. Swap the
urlString and path parameters since that makes more sense. Use String instead of NSString in the call to WKSetMetadataURL.

platform/FileSystem.cpp:

(WebCore::setMetadataURL): Deleted.

platform/FileSystem.h:
platform/mac/FileSystemMac.mm:

(WebCore::setMetadataURL):

Source/WebKit2:

Update for WebCore changes.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::namesOfPromisedFilesDroppedAtDestination):

2:04 PM Changeset in webkit [215289] by Brent Fulgham

2 edits in trunk/Source/WebKit2

[WK2][Mac] Stop allowing access to disk arbitration process
https://bugs.webkit.org/show_bug.cgi?id=170517
<rdar://problem/31071151>

Reviewed by Alex Christensen.

WebProcess/com.apple.WebProcess.sb.in:

1:55 PM Changeset in webkit [215288] by bweinstein@apple.com

2 edits in trunk/Source/WebKit/mac

Should always override -[WebStorageManager init].
https://bugs.webkit.org/show_bug.cgi?id=170787
-and corresponding-
rdar://problem/31371835

Reviewed by Anders Carlsson.

Storage/WebStorageManager.mm:

(-[WebStorageManager init]):

1:54 PM Changeset in webkit [215287] by mmaxfield@apple.com

20 edits
2 adds in trunk

Well-known variations should clamp to the values listed in the @font-face block
https://bugs.webkit.org/show_bug.cgi?id=169260

Reviewed by Dean Jackson.

Source/WebCore:

Most of this patch is plumbing the variation ranges from the CSSFontFace object
to preparePlatformFont() where variation values get applied.

Beyond that, there is one other piece of this patch - a nonspecified value in an
@font-face block shouldn't perform any clamping, but a specified value should be
clamped. This means that we need to retain whether or not a value is specified.
This patch does this by migrating CSSFontFace from using FontSelectionCapabilities
to using FontSelectionSpecifiedCapabilities, which has its internals behind
std::optionals which represent whether or not the value was specified. For the
purposes of font selection, these unspecified values are replaced with default
values.

Test: fast/text/variations/font-face-clamp.html

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::font):

css/CSSFontFace.h:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

css/CSSFontFaceSource.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::createFont):
(WebCore::CachedFont::platformDataFromCustomData):

loader/cache/CachedFont.h:
loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::createFont):
(WebCore::CachedSVGFont::platformDataFromCustomData):

loader/cache/CachedSVGFont.h:
platform/graphics/FontCache.cpp:

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKeyHash::hash):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::fontForFamily):

platform/graphics/FontCache.h:

(WebCore::FontCache::fontForFamily):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::createFontPlatformDataForTesting):

platform/graphics/FontSelectionAlgorithm.h:

(WebCore::FontSelectionRange::uniqueValue):
(WebCore::FontSelectionCapabilities::operator==):
(WebCore::FontSelectionCapabilities::operator!=):
(WebCore::FontSelectionSpecifiedCapabilities::computeFontSelectionCapabilities):
(WebCore::FontSelectionSpecifiedCapabilities::operator==):
(WebCore::FontSelectionSpecifiedCapabilities::operator!=):
(WebCore::FontSelectionSpecifiedCapabilities::operator=):
(WebCore::FontSelectionSpecifiedCapabilities::computeWeight):
(WebCore::FontSelectionSpecifiedCapabilities::computeWidth):
(WebCore::FontSelectionSpecifiedCapabilities::computeSlope):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::lastResortFallbackFont):

platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

platform/graphics/mac/FontCustomPlatformData.h:

LayoutTests:

fast/text/variations/font-face-clamp-expected.html: Added.
fast/text/variations/font-face-clamp.html: Added.

1:47 PM Changeset in webkit [215286] by Jonathan Bedard

2 edits in trunk/LayoutTests

Remove two passing canvas tests from ios expectations

Unreviewed test gardening.

platform/ios/TestExpectations:

1:22 PM Changeset in webkit [215285] by Beth Dakin

2 edits in trunk/Source/WebKit2

32-bit build fix.

UIProcess/API/mac/WKView.mm:

(-[WKView _mediaPlaybackControlsView]):

1:20 PM Changeset in webkit [215284] by Beth Dakin

2 edits in trunk/Source/WebCore

Speculative open source build fix.

platform/spi/cocoa/AVKitSPI.h:

1:04 PM Changeset in webkit [215283] by Beth Dakin

3 edits in trunk/Source/WebKit2

More 32-bit build fix.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaPlaybackControlsView]):
(-[WKWebView _addMediaPlaybackControlsView:]):

UIProcess/API/mac/WKView.mm:

(-[WKView _mediaPlaybackControlsView]):
(-[WKView _addMediaPlaybackControlsView:]):

12:56 PM Changeset in webkit [215282] by Beth Dakin

3 edits in trunk/Source/WebKit2

Another 32 bit build fix.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::mediaPlaybackControlsView):

12:49 PM Changeset in webkit [215281] by Beth Dakin

2 edits in trunk/Source/WebKit/mac

Speculative build fix.

WebView/WebViewData.h:

12:40 PM Changeset in webkit [215280] by achristensen@apple.com

17 edits
1 delete in trunk/Source

Stop using didReceiveDataArray callback on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=170780

Reviewed by Brady Eidson.

Source/WebCore:

didReceiveDataArray was an optimization that improved performance on iOS but is not needed any more.
The only platform where this is used is El Capitan, and didReceiveData works fine on that platform.
I've left some cleanup still to be done in SharedBuffer, and doing that is the motivation for this change.

WebCore.xcodeproj/project.pbxproj:
loader/ResourceLoader.h:
loader/SubresourceLoader.h:
loader/cf/SubresourceLoaderCF.cpp: Removed.
loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray): Deleted.

platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::supportsDataArray): Deleted.
(WebCore::ResourceHandleClient::didReceiveDataArray): Deleted.

platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegate::makeConnectionClient):
(WebCore::ResourceHandleCFURLConnectionDelegate::didReceiveDataArrayCallback): Deleted.

platform/network/cf/ResourceHandleCFURLConnectionDelegate.h:
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray): Deleted.

platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveDataArray): Deleted.

platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]): Deleted.

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveDataArray:]): Deleted.

Source/WebKit2:

NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::supportsDataArray): Deleted.
(WebKit::NetworkLoad::didReceiveDataArray): Deleted.

NetworkProcess/NetworkLoad.h:

12:28 PM Changeset in webkit [215279] by Beth Dakin

2 edits in trunk/Source/WebKit2

Speculative build fix.

UIProcess/API/Cocoa/WKViewPrivate.h:

12:17 PM Changeset in webkit [215278] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

REGRESSION: LayoutTest webrtc/negotiatedneeded-event-addStream.html is frequently crashing
https://bugs.webkit.org/show_bug.cgi?id=170754
<rdar://problem/31573169>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-12

TestExpectations: Marking test as crashing.

12:12 PM Changeset in webkit [215277] by Beth Dakin

2 edits in trunk/Source/WebCore

Attempted build fix.

platform/spi/cocoa/AVKitSPI.h:

12:08 PM Changeset in webkit [215276] by jmarcell@apple.com

2 edits in branches/safari-603-branch/Source/WebKit2

Cherry-pick 214376. rdar://problem/31502340

12:02 PM Changeset in webkit [215275] by Beth Dakin

2 edits in trunk/Source/WebKit2

Attempted build fix.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

11:38 AM Changeset in webkit [215274] by Beth Dakin

14 edits in trunk/Source

Adopt AVKit name change from AVFunctionBar* to AVTouchBar*
https://bugs.webkit.org/show_bug.cgi?id=170693
-and corresponding-
rdar://problem/31230018

Source/WebCore:

Reviewed by San Weinig.

Since the new names only apply to some versions of macOS, this patch uses typedefs
for the older OS’s. SO:

AVFunctionBarScrubber is now AVTouchBarScrubber

AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider

AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption

And the protocol AVFunctionBarPlaybackControlsControlling is now
AVTouchBarPlaybackControlsControlling

platform/mac/WebPlaybackControlsManager.h:
platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager audioFunctionBarMediaSelectionOptions]):
(-[WebPlaybackControlsManager setAudioFunctionBarMediaSelectionOptions:]):
(-[WebPlaybackControlsManager currentAudioFunctionBarMediaSelectionOption]):
(-[WebPlaybackControlsManager setCurrentAudioFunctionBarMediaSelectionOption:]):
(-[WebPlaybackControlsManager legibleFunctionBarMediaSelectionOptions]):
(-[WebPlaybackControlsManager setLegibleFunctionBarMediaSelectionOptions:]):
(-[WebPlaybackControlsManager currentLegibleFunctionBarMediaSelectionOption]):
(-[WebPlaybackControlsManager setCurrentLegibleFunctionBarMediaSelectionOption:]):
(mediaSelectionOptions):

Here is where the typedefs and #define are declared.

platform/spi/cocoa/AVKitSPI.h:

Source/WebKit/mac:

Reviewed by Sam Weinig.

Since the new names only apply to some versions of macOS, this patch uses typedefs
for the older OS’s. SO:

AVFunctionBarScrubber is now AVTouchBarScrubber

AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider

AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption

And the protocol AVFunctionBarPlaybackControlsControlling is now
AVTouchBarPlaybackControlsControlling

Soft links and allocations cannot use the typedefs.

WebView/WebView.mm:

(-[WebView updateMediaTouchBar]):

WebView/WebViewData.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Since the new names only apply to some versions of macOS, this patch uses typedefs
for the older OS’s. SO:

AVFunctionBarScrubber is now AVTouchBarScrubber

AVFunctionBarPlaybackControlsProvider is now AVTouchBarPlaybackControlsProvider

AVFunctionBarMediaSelectionOption is now AVTouchBarMediaSelectionOption

And the protocol AVFunctionBarPlaybackControlsControlling is now
AVTouchBarPlaybackControlsControlling

Use the new name.

UIProcess/API/Cocoa/WKViewPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaPlaybackControlsView]):
(-[WKWebView _addMediaPlaybackControlsView:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/mac/WKView.mm:

(-[WKView _mediaPlaybackControlsView]):
(-[WKView _addMediaPlaybackControlsView:]):

UIProcess/Cocoa/WebViewImpl.h:

Soft links and allocations cannot use the typedefs.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::mediaPlaybackControlsView):
(WebKit::WebViewImpl::updateMediaTouchBar):

11:10 AM Changeset in webkit [215273] by eric.carlson@apple.com

2 edits in trunk/Source/WebKit2

[MediaStream] Audio source in UI process not identified as capture source
https://bugs.webkit.org/show_bug.cgi?id=170776

Reviewed by Youenn Fablet.

WebProcess/cocoa/UserMediaCaptureManager.cpp: Override isCaptureSource.

10:35 AM Changeset in webkit [215272] by msaboff@apple.com

4 edits
1 add in trunk

Implement Object.isFrozen() and Object.isSealed() per ECMA spec
https://bugs.webkit.org/show_bug.cgi?id=170753

Reviewed by Mark Lam.

JSTests:

Added JSC baseline and enabled defineIndexProperty test.

Note that JSC differs from Chakra in that a JSC doesn't use indexed
properties placed on the Array prototype when sorting the indexed
properties of an Object. This is behavior is considered undefined
in the standard.

ChakraCore.yaml:
ChakraCore/test/es5/defineIndexProperty.baseline-jsc: Added.

Source/JavaScriptCore:

runtime/ObjectConstructor.cpp:

(JSC::testIntegrityLevel): Added local helper as described in the ECMA standard.

(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
Eliminated incomplete special handling of JSFinalObjects.

(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
Refactored to use the new testIntegrityLevel() helper.

10:23 AM Changeset in webkit [215271] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

Allow iOS to toggle webRTCAPI legacy flag.
https://bugs.webkit.org/show_bug.cgi?id=170735

Patch by Andrew Gold <agold@apple.com> on 2017-04-12
Reviewed by Eric Carlson.

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _webRTCLegacyAPIEnabled]):
(-[WKPreferences _setWebRTCLegacyAPIEnabled:]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

10:19 AM Changeset in webkit [215270] by Yusuke Suzuki

7 edits in trunk/Source

Use HAVE(MACHINE_CONTEXT) instead of USE(MACHINE_CONTEXT)
https://bugs.webkit.org/show_bug.cgi?id=170770

Rubber stamped by Mark Lam.

Source/JavaScriptCore:

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThread::Registers::framePointer):
(JSC::MachineThreads::MachineThread::Registers::instructionPointer):
(JSC::MachineThreads::MachineThread::Registers::llintPC):

runtime/MachineContext.h:

(JSC::MachineContext::stackPointer):
(JSC::MachineContext::framePointer):
(JSC::MachineContext::instructionPointer):
(JSC::MachineContext::argumentPointer<1>):
(JSC::MachineContext::llintInstructionPointer):

Source/WTF:

wtf/Platform.h:
wtf/PlatformRegisters.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::getRegisters):

9:59 AM Changeset in webkit [215269] by Yusuke Suzuki

8 edits in trunk/Source

[JSC] Clean up heap/MachineStackMarker by introducing USE(MACHINE_CONTEXT)
https://bugs.webkit.org/show_bug.cgi?id=170770

Reviewed by Mark Lam.

Source/JavaScriptCore:

We use USE(MACHINE_CONTEXT) to clean up runtime/MachineContext.h. And
we clean up heap/MachineStackMarker.cpp by using MachineContext functions.

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::MachineThread::Registers::stackPointer):
(JSC::MachineThreads::MachineThread::Registers::framePointer):
(JSC::MachineThreads::MachineThread::Registers::instructionPointer):
(JSC::MachineThreads::MachineThread::Registers::llintPC):

heap/MachineStackMarker.h:
runtime/MachineContext.h:

Source/WTF:

We add a new define USE_MACHINE_CONTEXT, which becomes true if mcontext_t exists
and we know the way to retrieve values from mcontext_t.

wtf/Platform.h:
wtf/PlatformRegisters.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::getRegisters):

8:52 AM Changeset in webkit [215268] by achristensen@apple.com

3 edits in trunk/Source/WebCore

Fix WinCairo build after r215265
https://bugs.webkit.org/show_bug.cgi?id=170502

m_threadId was removed in the header but not in the constructor implementation.
Initializer lists are our friends.

platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::CurlDownloadManager):
(WebCore::CurlDownload::CurlDownload): Deleted.

platform/network/curl/CurlDownload.h:

5:33 AM Changeset in webkit [215267] by Yusuke Suzuki

3 edits in trunk/Source/WebCore

Unreviewed, build fix for Win and GTK
https://bugs.webkit.org/show_bug.cgi?id=170758

platform/posix/SharedBufferPOSIX.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

platform/win/SharedBufferWin.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

5:16 AM Changeset in webkit [215266] by Yusuke Suzuki

2 edits in trunk/Source/WebKit2

Unreviewed, build fix for GTK port after r215262
https://bugs.webkit.org/show_bug.cgi?id=170758

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didRead):

5:08 AM Changeset in webkit [215265] by Yusuke Suzuki

94 edits
3 moves
2 adds in trunk

[WTF] Introduce Thread class and use RefPtr<Thread> and align Windows Threading implementation semantics to Pthread one
https://bugs.webkit.org/show_bug.cgi?id=170502

Reviewed by Mark Lam.

Source/JavaScriptCore:

API/tests/CompareAndSwapTest.cpp:

(testCompareAndSwap):

JavaScriptCore.xcodeproj/project.pbxproj:
b3/air/testair.cpp:
b3/testb3.cpp:

(JSC::B3::run):

bytecode/SuperSampler.cpp:

(JSC::initializeSuperSampler):

dfg/DFGWorklist.cpp:
disassembler/Disassembler.cpp:
heap/Heap.cpp:

(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::notifyIsSafeToCollect):

heap/Heap.h:
heap/MachineStackMarker.cpp:

(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThread):
(JSC::MachineThreads::removeThreadIfFound):
(JSC::MachineThreads::MachineThread::MachineThread):
(JSC::MachineThreads::MachineThread::getRegisters):
(JSC::MachineThreads::MachineThread::Registers::stackPointer):
(JSC::MachineThreads::MachineThread::Registers::framePointer):
(JSC::MachineThreads::MachineThread::Registers::instructionPointer):
(JSC::MachineThreads::MachineThread::Registers::llintPC):
(JSC::MachineThreads::MachineThread::captureStack):
(JSC::MachineThreads::tryCopyOtherThreadStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(pthreadSignalHandlerSuspendResume): Deleted.
(JSC::threadData): Deleted.
(JSC::MachineThreads::Thread::Thread): Deleted.
(JSC::MachineThreads::Thread::createForCurrentThread): Deleted.
(JSC::MachineThreads::Thread::operator==): Deleted.
(JSC::MachineThreads::machineThreadForCurrentThread): Deleted.
(JSC::MachineThreads::ThreadData::ThreadData): Deleted.
(JSC::MachineThreads::ThreadData::~ThreadData): Deleted.
(JSC::MachineThreads::ThreadData::suspend): Deleted.
(JSC::MachineThreads::ThreadData::resume): Deleted.
(JSC::MachineThreads::ThreadData::getRegisters): Deleted.
(JSC::MachineThreads::ThreadData::Registers::stackPointer): Deleted.
(JSC::MachineThreads::ThreadData::Registers::framePointer): Deleted.
(JSC::MachineThreads::ThreadData::Registers::instructionPointer): Deleted.
(JSC::MachineThreads::ThreadData::Registers::llintPC): Deleted.
(JSC::MachineThreads::ThreadData::freeRegisters): Deleted.
(JSC::MachineThreads::ThreadData::captureStack): Deleted.

heap/MachineStackMarker.h:

(JSC::MachineThreads::MachineThread::suspend):
(JSC::MachineThreads::MachineThread::resume):
(JSC::MachineThreads::MachineThread::threadID):
(JSC::MachineThreads::MachineThread::stackBase):
(JSC::MachineThreads::MachineThread::stackEnd):
(JSC::MachineThreads::threadsListHead):
(JSC::MachineThreads::Thread::operator!=): Deleted.
(JSC::MachineThreads::Thread::suspend): Deleted.
(JSC::MachineThreads::Thread::resume): Deleted.
(JSC::MachineThreads::Thread::getRegisters): Deleted.
(JSC::MachineThreads::Thread::freeRegisters): Deleted.
(JSC::MachineThreads::Thread::captureStack): Deleted.
(JSC::MachineThreads::Thread::platformThread): Deleted.
(JSC::MachineThreads::Thread::stackBase): Deleted.
(JSC::MachineThreads::Thread::stackEnd): Deleted.

jit/ICStats.cpp:

(JSC::ICStats::ICStats):
(JSC::ICStats::~ICStats):

jit/ICStats.h:
jsc.cpp:

(functionDollarAgentStart):
(startTimeoutThreadIfNeeded):

runtime/JSLock.cpp:

(JSC::JSLock::lock):

runtime/JSLock.h:

(JSC::JSLock::ownerThread):
(JSC::JSLock::currentThreadIsHoldingLock):

runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::isValidFramePointer):
(JSC::SamplingProfiler::SamplingProfiler):
(JSC::SamplingProfiler::createThreadIfNecessary):
(JSC::SamplingProfiler::takeSample):

runtime/SamplingProfiler.h:
runtime/VM.h:

(JSC::VM::ownerThread):

runtime/VMTraps.cpp:

(JSC::findActiveVMAndStackBounds):
(JSC::VMTraps::SignalSender::send):
(JSC::VMTraps::fireTrap):

Source/WebCore:

Mechanical change. Use Thread:: APIs.

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::IDBServer):

Modules/indexeddb/server/IDBServer.h:
Modules/webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::~AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::runLoop):

Modules/webaudio/AsyncAudioDecoder.h:
Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::uninitialize):
(WebCore::OfflineAudioDestinationNode::startRendering):

Modules/webaudio/OfflineAudioDestinationNode.h:
Modules/webdatabase/Database.cpp:

(WebCore::Database::securityOrigin):

Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::start):
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):

Modules/webdatabase/DatabaseThread.h:

(WebCore::DatabaseThread::getThreadID):

bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):

fileapi/AsyncFileStream.cpp:

(WebCore::callOnFileThread):

loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::open):
(WebCore::IconDatabase::close):

loader/icon/IconDatabase.h:
page/ResourceUsageThread.cpp:

(WebCore::ResourceUsageThread::createThreadIfNeeded):

page/ResourceUsageThread.h:
page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::ScrollingThread):
(WebCore::ScrollingThread::isCurrentThread):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::threadCallback):

page/scrolling/ScrollingThread.h:
platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::loadAsynchronously):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):

platform/audio/HRTFDatabaseLoader.h:
platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::~ReverbConvolver):

platform/audio/ReverbConvolver.h:
platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(ResourceHandleStreamingClient::ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient):

platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::loaderRunLoop):

platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::startThreadIfNeeded):
(WebCore::CurlDownloadManager::stopThread):

platform/network/curl/CurlDownload.h:
platform/network/curl/SocketStreamHandleImpl.h:
platform/network/curl/SocketStreamHandleImplCurl.cpp:

(WebCore::SocketStreamHandleImpl::startThread):
(WebCore::SocketStreamHandleImpl::stopThread):

workers/WorkerThread.cpp:

(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):

workers/WorkerThread.h:

(WebCore::WorkerThread::threadID):

Source/WebKit:

Mechanical change. Use Thread:: APIs.

Storage/StorageThread.cpp:

(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):

Storage/StorageThread.h:

Source/WebKit2:

Mechanical change. Use Thread:: APIs.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::IOChannel::readSyncInThread):

Platform/IPC/Connection.cpp:

(IPC::Connection::processIncomingMessage):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

UIProcess/linux/MemoryPressureMonitor.cpp:

(WebKit::MemoryPressureMonitor::MemoryPressureMonitor):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

This patch is refactoring of WTF Threading mechanism to merge JavaScriptCore's threading extension to WTF Threading.
Previously, JavaScriptCore requires richer threading features (such as suspending and resuming threads), and they
are implemented for PlatformThread in JavaScriptCore. But these features should be implemented in WTF Threading side
instead of maintaining JSC's own threading features too. This patch removes these features from JSC and move it to
WTF Threading.

However, current WTF Threading has one problem: Windows version of WTF Threading has different semantics from Pthreads
one. In Windows WTF Threading, we cannot perform any operation after the target thread is detached: WTF Threading stop
tracking the state of the thread once the thread is detached. But this is not the same to Pthreads one. In Pthreads,
pthread_detach just means that the resource of the thread will be destroyed automatically. While some operations like
pthread_join will be rejected, some operations like pthread_kill will be accepted.

The problem is that detached thread can be suspended and resumed in JSC. For example, in jsc.cpp, we start the worker
thread and detach it immediately. In worker thread, we will create VM and thus concurrent GC will suspend and resume
the detached thread. However, in Windows WTF Threading, we have no reference to the detached thread. Thus we cannot
perform suspend and resume operations onto the detached thread.

To solve the problem, we change Windows Threading mechanism drastically to align it to the Pthread semantics. In the
new Threading, we have RefPtr<Thread> class. It holds a handle to a platform thread. We can perform threading operations
with this class. For example, Thread::suspend is offered. And we use destructor of the thread local variable to release
the resources held by RefPtr<Thread>. In Windows, Thread::detach does nothing because the resource will be destroyed
automatically by RefPtr<Thread>.

To do so, we introduce ThreadHolder for Windows. This is similar to the previous ThreadIdentifierData for Pthreads.
It holds RefPtr<Thread> in the thread local storage (technically, it is Fiber Local Storage in Windows). Thread::current()
will return this reference.

The problematic situation is that the order of the deallocation of the thread local storage is not defined. So we should
not touch thread local storage in the destructor of the thread local storage. To avoid such edge cases, we have
currentThread() / Thread::currentID() APIs. They are safe to be called even in the destructor of the other thread local
storage. And in Windows, in the FLS destructor, we will create the thread_local variable to defer the destruction of
the ThreadHolder. We ensure that this destructor is called after the other FLS destructors are called in Windows 10.

This patch is performance neutral.

WTF.xcodeproj/project.pbxproj:
benchmarks/ConditionSpeedTest.cpp:
benchmarks/LockFairnessTest.cpp:
benchmarks/LockSpeedTest.cpp:
wtf/AutomaticThread.cpp:

(WTF::AutomaticThread::start):

wtf/CMakeLists.txt:
wtf/MainThread.h:
wtf/MemoryPressureHandler.h:
wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::tryLockFor):
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):

wtf/ParallelJobsGeneric.h:

(WTF::ParallelEnvironment::ThreadPrivate::ThreadPrivate): Deleted.

wtf/ParkingLot.cpp:

(WTF::ParkingLot::forEachImpl):

wtf/ParkingLot.h:

(WTF::ParkingLot::forEach):

wtf/PlatformRegisters.h: Renamed from Source/JavaScriptCore/runtime/PlatformThread.h.
wtf/RefPtr.h:

(WTF::RefPtr::RefPtr):

wtf/ThreadFunctionInvocation.h:

(WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):

wtf/ThreadHolder.cpp: Added.

(WTF::ThreadHolder::~ThreadHolder):
(WTF::ThreadHolder::initialize):

wtf/ThreadHolder.h: Renamed from Source/WTF/wtf/ThreadIdentifierDataPthreads.h.

(WTF::ThreadHolder::thread):
(WTF::ThreadHolder::ThreadHolder):

wtf/ThreadHolderPthreads.cpp: Renamed from Source/WTF/wtf/ThreadIdentifierDataPthreads.cpp.

(WTF::ThreadHolder::initializeOnce):
(WTF::ThreadHolder::current):
(WTF::ThreadHolder::destruct):

wtf/ThreadHolderWin.cpp: Added.

(WTF::threadMapMutex):
(WTF::threadMap):
(WTF::ThreadHolder::initializeOnce):
(WTF::ThreadHolder::current):
(WTF::ThreadHolder::destruct):

wtf/ThreadSpecific.h:
wtf/Threading.cpp:

(WTF::Thread::normalizeThreadName):
(WTF::threadEntryPoint):
(WTF::Thread::create):
(WTF::Thread::setCurrentThreadIsUserInteractive):
(WTF::Thread::setCurrentThreadIsUserInitiated):
(WTF::Thread::setGlobalMaxQOSClass):
(WTF::Thread::adjustedQOSClass):
(WTF::Thread::dump):
(WTF::initializeThreading):
(WTF::normalizeThreadName): Deleted.
(WTF::createThread): Deleted.
(WTF::setCurrentThreadIsUserInteractive): Deleted.
(WTF::setCurrentThreadIsUserInitiated): Deleted.
(WTF::setGlobalMaxQOSClass): Deleted.
(WTF::adjustedQOSClass): Deleted.

wtf/Threading.h:

(WTF::Thread::id):
(WTF::Thread::operator==):
(WTF::Thread::operator!=):
(WTF::Thread::joinableState):
(WTF::Thread::didBecomeDetached):
(WTF::Thread::didJoin):
(WTF::Thread::hasExited):
(WTF::currentThread):

wtf/ThreadingPthreads.cpp:

(WTF::Thread::Thread):
(WTF::Thread::~Thread):
(WTF::Thread::signalHandlerSuspendResume):
(WTF::Thread::initializePlatformThreading):
(WTF::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::createInternal):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::changePriority):
(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::current):
(WTF::Thread::currentID):
(WTF::Thread::signal):
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
(WTF::Thread::didExit):
(WTF::Thread::establish):
(WTF::PthreadState::PthreadState): Deleted.
(WTF::PthreadState::joinableState): Deleted.
(WTF::PthreadState::pthreadHandle): Deleted.
(WTF::PthreadState::didBecomeDetached): Deleted.
(WTF::PthreadState::didExit): Deleted.
(WTF::PthreadState::didJoin): Deleted.
(WTF::PthreadState::hasExited): Deleted.
(WTF::threadMapMutex): Deleted.
(WTF::initializeThreading): Deleted.
(WTF::threadMap): Deleted.
(WTF::identifierByPthreadHandle): Deleted.
(WTF::establishIdentifierForPthreadHandle): Deleted.
(WTF::pthreadHandleForIdentifierWithLockAlreadyHeld): Deleted.
(WTF::createThreadInternal): Deleted.
(WTF::initializeCurrentThreadInternal): Deleted.
(WTF::changeThreadPriority): Deleted.
(WTF::waitForThreadCompletion): Deleted.
(WTF::detachThread): Deleted.
(WTF::threadDidExit): Deleted.
(WTF::currentThread): Deleted.
(WTF::signalThread): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::Thread):
(WTF::Thread::~Thread):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::initializePlatformThreading):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::createInternal):
(WTF::Thread::changePriority):
(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::resume):
(WTF::Thread::getRegisters):
(WTF::Thread::current):
(WTF::Thread::currentID):
(WTF::Thread::didExit):
(WTF::Thread::establish):
(WTF::initializeCurrentThreadInternal): Deleted.
(WTF::threadMapMutex): Deleted.
(WTF::initializeThreading): Deleted.
(WTF::threadMap): Deleted.
(WTF::storeThreadHandleByIdentifier): Deleted.
(WTF::threadHandleForIdentifier): Deleted.
(WTF::clearThreadHandleForIdentifier): Deleted.
(WTF::createThreadInternal): Deleted.
(WTF::changeThreadPriority): Deleted.
(WTF::waitForThreadCompletion): Deleted.
(WTF::detachThread): Deleted.
(WTF::currentThread): Deleted.

wtf/WorkQueue.cpp:

(WTF::WorkQueue::concurrentApply):

wtf/WorkQueue.h:
wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::dispatchQOSClass):

wtf/generic/WorkQueueGeneric.cpp:

(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):

wtf/linux/MemoryPressureHandlerLinux.cpp:

(WTF::MemoryPressureHandler::EventFDPoller::EventFDPoller):
(WTF::MemoryPressureHandler::EventFDPoller::~EventFDPoller):

wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

Tools:

Mechanical change. Use Thread:: APIs.

DumpRenderTree/JavaScriptThreading.cpp:

(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

DumpRenderTree/mac/DumpRenderTree.mm:

(testThreadIdentifierMap):

TestWebKitAPI/Tests/WTF/Condition.cpp:
TestWebKitAPI/Tests/WTF/Lock.cpp:

(TestWebKitAPI::runLockTest):

TestWebKitAPI/Tests/WTF/ParkingLot.cpp:

3:14 AM Changeset in webkit [215264] by Manuel Rego Casasnovas

1 edit
2 adds in trunk/LayoutTests

[css-grid] Replaced elements don't properly resolve percentage heights
https://bugs.webkit.org/show_bug.cgi?id=159670

Reviewed by Darin Adler.

The issue was fixed in r213149 (bug #168657), but the Blink test was not imported.
This patch only adds the test to avoid regressions in the future.

fast/css-grid-layout/grid-item-with-percent-height-replaced-element-expected.txt: Added.
fast/css-grid-layout/grid-item-with-percent-height-replaced-element.html: Added.

3:09 AM Changeset in webkit [215263] by Antti Koivisto

15 edits
2 adds in trunk

Cache small media resources in disk cache
https://bugs.webkit.org/show_bug.cgi?id=170676
<rdar://problem/31532649>

Reviewed by Andreas Kling.

Source/WebCore:

Test: http/tests/cache/disk-cache/disk-cache-media-small.html

Testing support. Functional changes are in WebKit2.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCreateResourceLoader):
(WebCore::HTMLMediaElement::lastMediaResourceLoaderForTesting):

html/HTMLMediaElement.h:
loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::MediaResourceLoader):
(WebCore::MediaResourceLoader::addResponseForTesting):
(WebCore::MediaResource::responseReceived):

loader/MediaResourceLoader.h:
platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):

We can now receive cached responses.

testing/Internals.cpp:

(WebCore::responseSourceToString):
(WebCore::Internals::xhrResponseSource):
(WebCore::Internals::mediaResponseSources):
(WebCore::Internals::mediaResponseContentRanges):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeRetrieveDecision):

Allow retrieving media resources.

(WebKit::NetworkCache::expectedTotalResourceSizeFromContentRange):
(WebKit::NetworkCache::expectedTotalResourceSize):
(WebKit::NetworkCache::makeStoreDecision):

Store media resource if we can figure out its total size and it is less than 5MB
(and it is cacheable by the usual rules).

LayoutTests:

http/tests/cache/disk-cache/disk-cache-media-small-expected.txt: Added.
http/tests/cache/disk-cache/disk-cache-media-small.html: Added.

2:25 AM Changeset in webkit [215262] by commit-queue@webkit.org

23 edits in trunk

Modernize vector adoption
https://bugs.webkit.org/show_bug.cgi?id=170758

Patch by Alex Christensen <achristensen@webkit.org> on 2017-04-12
Reviewed by Geoffrey Garen.

Source/WebCore:

Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids):

Modules/indexeddb/IDBGetResult.cpp:

(WebCore::IDBGetResult::dataFromBuffer):

Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::decode):

Modules/indexeddb/server/IDBSerialization.cpp:

(WebCore::serializeIDBKeyData):
(WebCore::decodeKey):

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::loadCache):

loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseNextPart):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::createCustomFontData):

loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::ensureCustomFontData):

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::create):
(WebCore::utf8Buffer):
(WebCore::SharedBuffer::adoptVector): Deleted.

platform/SharedBuffer.h:
platform/ThreadSafeDataBuffer.h:

(WebCore::ThreadSafeDataBufferImpl::ThreadSafeDataBufferImpl):
(WebCore::ThreadSafeDataBuffer::create):
(WebCore::ThreadSafeDataBuffer::ThreadSafeDataBuffer):
(WebCore::ThreadSafeDataBuffer::decode):
(): Deleted.
(WebCore::ThreadSafeDataBuffer::adoptVector): Deleted.

platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):

platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::decodeBase64):
(WebCore::DataURLDecoder::decodeEscaped):

Source/WebKit2:

NetworkProcess/capture/NetworkCaptureEvent.cpp:

(WebKit::NetworkCapture::JSONCoder<WebCore::SharedBuffer>::decode):

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::bufferForType):

Tools:

TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

1:01 AM Changeset in webkit [215261] by pvollan@apple.com

14 edits
6 adds in trunk

Implement stroke-color CSS property.
https://bugs.webkit.org/show_bug.cgi?id=169352

Reviewed by Jon Lee.

Source/WebCore:

Support setting text stroke color using the CSS property stroke-color, see https://drafts.fxtf.org/paint/.
Text stroke color can currently be set with the -webkit-text-stroke-color property. To make sure this still
works, I added a check to determine if the stroke-color property has been explicitly set. If it has not been
set, we fall back to the value of the -webkit-text-stroke-color property.

Tests: fast/css/stroke-color-fallback.html

fast/css/stroke-color.html
fast/css/visited-link-stroke-color.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSProperties.json:
css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueStrokeColor):

css/StyleResolver.cpp:

(WebCore::isValidVisitedLinkProperty):

css/parser/CSSParserFastPaths.cpp:

(WebCore::isColorPropertyID):

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

rendering/TextDecorationPainter.cpp:

(WebCore::decorationColor):

rendering/TextPaintStyle.cpp:

(WebCore::computeTextPaintStyle):
(WebCore::computeTextSelectionPaintStyle):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::colorIncludingFallback):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::strokeColor):
(WebCore::RenderStyle::setStrokeColor):
(WebCore::RenderStyle::setVisitedLinkStrokeColor):
(WebCore::RenderStyle::visitedLinkStrokeColor):
(WebCore::RenderStyle::setHasExplicitlySetStrokeColor):
(WebCore::RenderStyle::hasExplicitlySetStrokeColor):

rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

rendering/style/StyleRareInheritedData.h:

LayoutTests:

fast/css/stroke-color-expected.html: Added.
fast/css/stroke-color-fallback-expected.html: Added.
fast/css/stroke-color-fallback.html: Added.
fast/css/stroke-color.html: Added.
fast/css/visited-link-stroke-color-expected.html: Added.
fast/css/visited-link-stroke-color.html: Added.

12:29 AM Changeset in webkit [215260] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed GTK+ debug build fix. Drop an unused debug-only member
variable in the CompositingRunLoop class.

Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

Apr 11, 2017:

11:50 PM Changeset in webkit [215259] by zandobersek@gmail.com

21 edits
2 adds in trunk/Source

[GTK] Use the DisplayRefreshMonitor facilities
https://bugs.webkit.org/show_bug.cgi?id=170599

Reviewed by Carlos Garcia Campos.

Source/WebCore:

CMakeLists.txt: Add missing files to the build.
platform/graphics/DisplayRefreshMonitor.cpp: Build fixes.

(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updatePlatformLayer): Mark the
platform layer as updated in the layer's CoordinatedGraphicsState.

platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

Source/WebKit2:

ThreadedCompositor gains a DisplayRefreshMonitor member that it can use
to better coordinate display refresh callbacks on the main thread. Still,
because currently the GTK+ port doesn't have a reliable way of notifying
the ThreadedCompositor of a vsync event, a timer targeting 60FPS is used
in order to keep the updates at a reasonable rate. When the timer is fired,
the ThreadedCompositor decides how to proceed based on state changes that
might have occurred during composition or whether there's any display
refresh callbacks that require handling on the main thread.

CompositingRunLoop now stores its state in an atomic variable that's then
inspected whenever a new update is scheduled or completed. When scheduled,
if there's no update in progress, a new update is requested through the
timer. If there's already an update in progress, a new update is marked
as pending after the current one completes. In that case, when the update
is completed, a new update is requested through the timer.

ThreadedDisplayRefreshMonitor is used to coordinate updates between the
main and the composition thread whenever the CoordinatedGraphics state
demands it, or whenever there are clients registered to that monitor that
require an update (e.g. a requestAnimationFrame() callback). After the
update on the composition thread is finished, and the DisplayRefreshMonitor
object requires an update, a callback at the same priority as the layer
flush timer is scheduled on the main thread. In that callback we handle
any clients registered for this DisplayRefreshMonitor before proceeding
to handle any changes to the CoordinatedGraphics scene. In case the
DisplayRefreshMonitor clients or the layer flushes already queued up
any changes to the state, we immediately ask the ThreadedCompositor for
an update.

PlatformGTK.cmake:
Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::updateViewport):
(WebKit::CoordinatedGraphicsScene::commitSceneState):

Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::isActive):
(WebKit::CompositingRunLoop::scheduleUpdate):
(WebKit::CompositingRunLoop::stopUpdates):
(WebKit::CompositingRunLoop::updateCompleted):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::CompositingRunLoop::isCurrent):
(WebKit::CompositingRunLoop::startUpdateTimer): Deleted.
(WebKit::CompositingRunLoop::stopUpdateTimer): Deleted.

Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

(): Deleted.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing):
(WebKit::ThreadedCompositor::updateViewport):
(WebKit::ThreadedCompositor::scheduleDisplayImmediately):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::displayRefreshMonitor):
(WebKit::ThreadedCompositor::renderNextFrameIfNeeded):
(WebKit::ThreadedCompositor::completeCoordinatedUpdateIfNeeded):
(WebKit::ThreadedCompositor::coordinateUpdateCompletionWithClient):
(WebKit::ThreadedCompositor::performFrameCompletion):

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp: Added.

(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::requiresDisplayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::dispatchDisplayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::invalidate):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::createDisplayRefreshMonitor):

WebProcess/WebPage/AcceleratedDrawingArea.h:
WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::createDisplayRefreshMonitor):

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::createDisplayRefreshMonitor):

Source/WTF:

wtf/Platform.h: Enable USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for the GTK+ port.
wtf/glib/RunLoopSourcePriority.h: Add the DisplayRefreshMonitorTimer entry that

matches the value of LayerFlushTimer.

11:12 PM Changeset in webkit [215258] by jmarcell@apple.com

5 edits in branches/safari-603-branch

Cherry-pick 214358. rdar://problem/31502340

9:37 PM Changeset in webkit [215257] by rniwa@webkit.org

3 edits
1 add in trunk/Websites/perf.webkit.org

Retrying an A/B testing does not set the repetition count in some cases
https://bugs.webkit.org/show_bug.cgi?id=170695

Reviewed by Joseph Pecoraro.

When selecting an existing A/B test group, the analysis task page automatically sets the repetition count
of its retry to be that of the original test group. However, this information wasn't being passed correctly
to the code that actually created a test group. As a result, the retried test group's repetition count does
not match that of the original group or the number shown to the user on UI.

Fixed the bug by updating this._repetitionCount in setRepetitionCount.

browser-tests/index.html:
browser-tests/test-group-form-tests.js: Added. Added tests.

(.createTestGroupFormWithContext): Added.

public/v3/components/test-group-form.js:

(TestGroupForm.prototype.setRepetitionCount):
(TestGroupForm.formContent):
(TestGroupForm):

8:05 PM Changeset in webkit [215256] by Matt Baker

5 edits
4 adds in trunk/Source/WebInspectorUI

Web Inspector: checkboxes in Settings screen use inappropriate layout
https://bugs.webkit.org/show_bug.cgi?id=166993
<rdar://problem/30002272>

Reviewed by Devin Rousso.

Localizations/en.lproj/localizedStrings.js:

New checkbox setting strings.

UserInterface/Main.html:

New settings view classes.

UserInterface/Views/GeneralSettingsView.js: Added.

(WebInspector.GeneralSettingsView):
(WebInspector.GeneralSettingsView.prototype.initialLayout):
Move settings UI creation from SettingsTabContentView.

UserInterface/Views/SettingEditor.js: Added.

Basic setting editor UI for the following input types: checkbox,
number, and select. In the future it may be useful to include
additional types, such as radio buttons.

(WebInspector.SettingEditor):
(WebInspector.SettingEditor.createForSetting):
(WebInspector.SettingEditor.prototype.get element):
(WebInspector.SettingEditor.prototype.get type):
(WebInspector.SettingEditor.prototype.get label):
(WebInspector.SettingEditor.prototype.get value):
(WebInspector.SettingEditor.prototype.set value):
(WebInspector.SettingEditor.prototype._createEditorElement):

UserInterface/Views/SettingsGroup.js: Added.

A container holding editors for one or more WebInspector.Settings.
Every editor belongs to a group. SettingsView provides convenience
methods for adding settings and groups, so create instances directly
shouldn't normally be necessary.

(WebInspector.SettingsGroup):
(WebInspector.SettingsGroup.prototype.get element):
(WebInspector.SettingsGroup.prototype.addSetting):
(WebInspector.SettingsGroup.prototype.addCustomSetting):

UserInterface/Views/SettingsTabContentView.css:

Refactored styles to more closely match Xcode settings UI.
Eliminated redundant use of "setting" from CSS class names.

(.content-view.settings):
(.content-view.settings .navigation-bar .item.radio.button.text-only):
(.content-view.settings .navigation-bar .item.radio.button.text-only.selected):
(.content-view.settings > .settings-view > .separator):
(.content-view.settings > .settings-view > .container):
(.content-view.settings > .settings-view > .container > .title):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .title):
(body[dir=rtl] .content-view.settings > .settings-view > .container > .title):
(.content-view.settings > .settings-view > .container > .editor-group):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(.content-view.settings > .header): Deleted.
(.content-view.settings > .separator): Deleted.
(.content-view.settings > .setting-container): Deleted.
(.content-view.settings > .setting-container.combined): Deleted.
(.content-view.settings > .setting-container > .setting-name): Deleted.
(body[dir=ltr] .content-view.settings > .setting-container > .setting-name): Deleted.
(body[dir=rtl] .content-view.settings > .setting-container > .setting-name): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller input): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]): Deleted.
(body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]): Deleted.
(body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller select): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller input[type="number"]): Deleted.
(body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]): Deleted.
(body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]): Deleted.

UserInterface/Views/SettingsTabContentView.js:

To better organize the growing number of settings, multiple settings views
are now supported, with a navigation bar for switching between them. For
now there is a single "General" setting view, and and the navigation bar
is hidden. Adding a second view will cause the bar to be shown.

(WebInspector.SettingsTabContentView):
(WebInspector.SettingsTabContentView.prototype.get type):
(WebInspector.SettingsTabContentView.prototype.get selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.addSettingsView):
(WebInspector.SettingsTabContentView.prototype._navigationItemSelected):
(WebInspector.SettingsTabContentView.prototype.layout): Deleted.
No longer needed.

UserInterface/Views/SettingsView.js: Added.

Base class for displaying editing UI for a collection of related
WebInspector.Setting objects.

(WebInspector.SettingsView):
(WebInspector.SettingsView.prototype.get identifier):
(WebInspector.SettingsView.prototype.get displayName):
A string suitable for display in a NavigationBar showing a list of
SettingsViews (e.g. "General", "Text Editing", "Fonts & Colors", etc).

(WebInspector.SettingsView.prototype.addSetting):
Add UI for a setting, consisting of a title, an editor appropriate for
the setting's value type, and optional label and formatting options.
For example:

addSetting("Setting 1:", new WebInspector.Setting(…, true), "Item one")
addSetting("Setting 2:", new WebInspector.Setting(…, 1), "units")

will create a checkbox and number input field:

Setting 1: [x] Item one
Setting 2: [ 1] units

(WebInspector.SettingsView.prototype.addCustomSetting):
Add UI for a specific editor type, with optional formatting options.
A setting can be updated in response to changes in the editor's value.

(WebInspector.SettingsView.prototype.addGroup):
Add a group, for listing multiple settings under one title. For example:

group = addGroup("Title:")
group.addSetting(new WebInspector.Setting(…, true), "Item one")
group.addSetting(new WebInspector.Setting(…, false), "Item two")

will create two checkboxes under the same title:

Title: [x] Item one

[ ] Item two

(WebInspector.SettingsView.prototype.addSeparator):
Add vertical space between two settings or groups.

4:24 PM Changeset in webkit [215255] by achristensen@apple.com

14 edits in trunk/Source/WebKit2

Modernize and clean up code
https://bugs.webkit.org/show_bug.cgi?id=170752

Reviewed by Sam Weinig.

NetworkProcess/NetworkResourceLoader.h:
Shared/WebPreferencesStore.h:
UIProcess/API/APIHitTestResult.cpp:

(API::HitTestResult::create):

UIProcess/API/APIHitTestResult.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
(WKPreferencesCreateCopy):

UIProcess/Authentication/AuthenticationChallengeProxy.h:
UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::copy):

UIProcess/WebPreferences.h:
WebProcess/Network/WebLoaderStrategy.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addTextCheckingRequest):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::rangeForBlockAtPoint):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::WebPage::changeBlockSelection):
(WebKit::WebPage::rangeForGranularityAtPoint):
(WebKit::WebPage::computePagesForPrintingAndDrawToPDF):

4:03 PM Changeset in webkit [215254] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Modern Media Controls] Allow modern-media-controls to be provided through WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=170722
<rdar://problem/31553089>

Patch by Antoine Quint <Antoine Quint> on 2017-04-11
Reviewed by Dean Jackson.

If modern media controls source files are provided through WebKitAdditions, use these instead
of the sources found in the WebCore module.

WebCore.xcodeproj/project.pbxproj:

3:48 PM Changeset in webkit [215253] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

LayoutTest webrtc/video-mute.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=170704

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

webrtc/video-mute.html: Trying to make it less flaky.

3:47 PM Changeset in webkit [215252] by commit-queue@webkit.org

2 edits
2 adds in trunk/LayoutTests

[WK1] Add captureStream test with webrtc
https://bugs.webkit.org/show_bug.cgi?id=170746

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

platform/mac-wk1/TestExpectations: Activating this new test in WK1.
webrtc/captureCanvas-webrtc-expected.txt: Added.
webrtc/captureCanvas-webrtc.html: Added.

3:47 PM Changeset in webkit [215251] by commit-queue@webkit.org

14 edits in trunk/LayoutTests

Migrating webrtc tests to latest API
https://bugs.webkit.org/show_bug.cgi?id=170709

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

webrtc/audio-peer-connection-webaudio.html:
webrtc/libwebrtc/descriptionGetters.html:
webrtc/negotiatedneeded-event-addStream.html:
webrtc/peer-connection-audio-mute.html:
webrtc/peer-connection-audio-mute2.html:
webrtc/peer-connection-remote-audio-mute.html:
webrtc/peer-connection-remote-audio-mute2.html:
webrtc/release-after-getting-track.html:
webrtc/video-disabled-black.html:
webrtc/video-mute.html:
webrtc/video-remote-mute.html:
webrtc/video-with-receiver.html:
webrtc/video.html:

2:30 PM Changeset in webkit [215250] by dino@apple.com

12 edits in trunk

Disable outdated WritableStream API
https://bugs.webkit.org/show_bug.cgi?id=170749
<rdar://problem/31446233>

Reviewed by Tim Horton.

The API we implement is no longer accurate. Disable it until we
are compatible with the new specification

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

1:39 PM Changeset in webkit [215249] by mrajca@apple.com

4 edits in trunk

Consider the current document when allowing autoplay quirks.
https://bugs.webkit.org/show_bug.cgi?id=170744

Reviewed by Eric Carlson.

Added API test.

In addition to checking if the top-level document supports autoplay quirks, we should check
if the current document supports quirks. This allows all embedded YouTube videos (which use
iframes) to play correctly if the client allows autoplay quirks on youtube.com.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks):

12:51 PM Changeset in webkit [215248] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r215245.

This change broke internal builds.

Reverted changeset:

"[Modern Media Controls] Allow modern-media-controls to be
provided through WebKitAdditions"
https://bugs.webkit.org/show_bug.cgi?id=170722
http://trac.webkit.org/changeset/215245

12:13 PM Changeset in webkit [215247] by mitz@apple.com

8 edits
3 adds
1 delete in trunk

[Cocoa] WebKit unnecessarily soft-links CorePrediction
https://bugs.webkit.org/show_bug.cgi?id=170644

Reviewed by Sam Weinig.

Source/WebKit2:

Configurations/BaseTarget.xcconfig: Defined HAVE_CORE_PREDICTION and added HAVE_CORE_PREDICTION to the preprocessor defintions when the former is YES.

Configurations/WebKit.xcconfig: Have the linker link against CorePrediction where available. On macOS, use weak linking, because CorePrediction is not available in the Base System.

Platform/classifier/cocoa/CorePredictionSoftLink.h: Removed.

Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.cpp: Guarded with #if HAVE(CORE_PREDICTION).

(WebKit::isNullFunctionPointer): Added this helper.
(WebKit::ResourceLoadStatisticsClassifierCocoa::canUseCorePrediction): Replaced

dlopen()-based runtime check with a null check.

Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.h: Guarded with #if HAVE(CORE_PREDICTION).

Platform/spi/Cocoa/CorePredictionSPI.h: Added.

UIProcess/WebResourceLoadStatisticsStore.h: Updated guards to include HAVE(CORE_PREDICTION).

WebKit2.xcodeproj/project.pbxproj: pdated file references for removal and addition.

WebKitLibraries:

WebKitPrivateFrameworkStubs/iOS/10/CorePrediction.framework: Added this framework stub.
WebKitPrivateFrameworkStubs/iOS/10/CorePrediction.framework/CorePrediction.tbd: Added.

11:43 AM Changeset in webkit [215246] by commit-queue@webkit.org

11 edits
3 copies
3 adds in trunk

Add SPI for handling geolocation authorization requests
https://bugs.webkit.org/show_bug.cgi?id=170362
rdar://problem/17508627

Patch by David Quesada <david_quesada@apple.com> on 2017-04-11
Reviewed by Alex Christensen.

Source/WebKit2:

Add a new WKUIDelegate method for the WKGeolocationProviderIOS to call when a web page
requests geolocation access. To support testing this change, make it possible to override
the CoreLocation abstraction WKGeolocationProviderIOS uses. There is now a configurable
object on the process pool that implements a protocol for providing location updates for
web views in the process pool. If the client doesn't provide this object,
WKGeolocationProviderIOS falls back to an object that wraps the existing WebKit1
WebGeolocationCoreLocationProvider and conforms to the new protocol.

Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

Shared/WebGeolocationPosition.h:

(WebKit::WebGeolocationPosition::create):

UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate_b):

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _coreLocationProvider]):
(-[WKProcessPool _setCoreLocationProvider:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/_WKGeolocationCoreLocationProvider.h: Copied from Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.cpp.
UIProcess/API/Cocoa/_WKGeolocationPosition.h: Copied from Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.cpp.
UIProcess/API/Cocoa/_WKGeolocationPosition.mm: Added.

(WebKit::if):
(-[_WKGeolocationPosition dealloc]):
(-[_WKGeolocationPosition _apiObject]):

UIProcess/API/Cocoa/_WKGeolocationPositionInternal.h: Copied from Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.cpp.

(WebKit::wrapper):

UIProcess/ios/WKGeolocationProviderIOS.mm:

(kit):
(-[WKGeolocationProviderIOS initWithProcessPool:]):
(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WKGeolocationProviderIOS positionChanged:]):
(-[WKLegacyCoreLocationProvider setListener:]):
(-[WKLegacyCoreLocationProvider requestGeolocationAuthorization]):
(-[WKLegacyCoreLocationProvider start]):
(-[WKLegacyCoreLocationProvider stop]):
(-[WKLegacyCoreLocationProvider setEnableHighAccuracy:]):
(-[WKLegacyCoreLocationProvider geolocationAuthorizationGranted]):
(-[WKLegacyCoreLocationProvider geolocationAuthorizationDenied]):
(-[WKLegacyCoreLocationProvider positionChanged:]):
(-[WKLegacyCoreLocationProvider errorOccurred:]):
(-[WKLegacyCoreLocationProvider resetGeolocation]):
Implement a new class that bridges the currently used WebGeolocationCoreLocationProvider
to conform to the _WKGeolocationCoreLocationProvider protocol that WKGeolocationProviderIOS
expects.

WebKit2.xcodeproj/project.pbxproj:

Tools:

Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
provide a stub object to simulate the various configurations of geolocation permissions:

The app doesn't have permission to use geolocation.
The app is allowed to use geolocation, but the UI delegate denies the web view permission.
The app is allowed to use geolocation, and the UI delegate allows the web view permission.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.

(-[TestCoreLocationProvider setListener:]):
(-[TestCoreLocationProvider requestGeolocationAuthorization]):
(-[TestCoreLocationProvider start]):
(-[TestCoreLocationProvider stop]):
(-[TestCoreLocationProvider setEnableHighAccuracy:]):
(expectException):
(-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
(-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.

11:41 AM Changeset in webkit [215245] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Modern Media Controls] Allow modern-media-controls to be provided through WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=170722
<rdar://problem/31553089>

Patch by Antoine Quint <Antoine Quint> on 2017-04-11
Reviewed by Dean Jackson.

If modern media controls source files are provided through WebKitAdditions, use these instead
of the sources found in the WebCore module.

WebCore.xcodeproj/project.pbxproj:

11:39 AM Changeset in webkit [215244] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for CF ports after r215241
https://bugs.webkit.org/show_bug.cgi?id=170725

heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::nextFireTime):

11:29 AM Changeset in webkit [215243] by mrajca@apple.com

5 edits
1 add in trunk

Change autoplay state to "prevented" when media is paused due to restrictions.
https://bugs.webkit.org/show_bug.cgi?id=170686

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

Currently, the autoplay state is set to "prevented" when playback is about to begin without
user interaction and there are restrictions in place. We should also be setting this flag when
autoplay is allowed but due to a change in audio tracks, for example, it gets paused.

This patch also moves some common logic into setPlaybackWithoutUserGesture without changing behavior.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::setPlaybackWithoutUserGesture):
(WebCore::HTMLMediaElement::updateShouldPlay):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST):

11:27 AM Changeset in webkit [215242] by eric.carlson@apple.com

9 edits in trunk/Source

[MediaStream] Set correct audio session category when capturing audio
https://bugs.webkit.org/show_bug.cgi?id=170736
<rdar://problem/31559405>

Reviewed by Jer Noble.

Source/WebCore:

No new tests yet, filed bug 170737.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Initialize m_mediaSession.
(WebCore::MediaStream::statusDidChange): Call canProduceAudioChanged.
(WebCore::MediaStream::mediaType): New. Return MediaStreamCapturingAudio when actively
capturing audio.
(WebCore::MediaStream::presentationType):
(WebCore::MediaStream::characteristics):
(WebCore::MediaStream::mayResumePlayback):
(WebCore::MediaStream::suspendPlayback):
(WebCore::MediaStream::sourceApplicationIdentifier):
(WebCore::MediaStream::canProduceAudio):

Modules/mediastream/MediaStream.h:

platform/audio/PlatformMediaSession.h: Add MediaStreamCapturingAudio.
platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::has): Adjust assert for MediaStreamCapturingAudio.
(WebCore::PlatformMediaSessionManager::count): Ditto.

platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState): Set small preferred buffer size when
capturing audio. Set audio session category to PlayAndRecord whenever there is a media
stream that is capturing audio.

Source/WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

11:25 AM Changeset in webkit [215241] by Yusuke Suzuki

11 edits in trunk

[WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
https://bugs.webkit.org/show_bug.cgi?id=170725

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch makes GCActivityCallback return MonotonicTime instead of raw double value.

heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::nextFireTime):

heap/GCActivityCallback.h:

Source/WebCore:

Use MonotonicTime instead of raw doubles.
Currently, large part of data structures and helper functions are the same in
ResourceUsageOverlayCocoa.mm and ResourceUsageOverlayLinux.cpp. This should be
unified in a separate patch.

page/ResourceUsageData.h:
page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::gcTimerString):
(WebCore::ResourceUsageOverlay::platformDraw):

page/linux/ResourceUsageOverlayLinux.cpp:

(WebCore::gcTimerString):

Source/WTF:

Make MonotonicTime more constexpr friendly mainly to annotate MonotonicTime::nan() as constexpr.

wtf/MonotonicTime.h:

(WTF::MonotonicTime::MonotonicTime):
(WTF::MonotonicTime::fromRawSeconds):
(WTF::MonotonicTime::infinity):
(WTF::MonotonicTime::nan):
(WTF::MonotonicTime::secondsSinceEpoch):
(WTF::MonotonicTime::operator bool):
(WTF::MonotonicTime::operator+):
(WTF::MonotonicTime::operator-):
(WTF::MonotonicTime::operator==):
(WTF::MonotonicTime::operator!=):
(WTF::MonotonicTime::operator<):
(WTF::MonotonicTime::operator>):
(WTF::MonotonicTime::operator<=):
(WTF::MonotonicTime::operator>=):

Tools:

TestWebKitAPI/Tests/WTF/Time.cpp:

(TestWebKitAPI::TEST):

10:34 AM Changeset in webkit [215240] by mitz@apple.com

2 edits in trunk/Source/WebKit/mac

[iOS] Simple HTML documents should allow non-markup JavaScript
https://bugs.webkit.org/show_bug.cgi?id=170734

Reviewed by Sam Weinig.

WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting

but disabled scripting markup.

10:27 AM Changeset in webkit [215239] by commit-queue@webkit.org

9 edits in trunk

Activate WebRTC data channel tests for WK1
https://bugs.webkit.org/show_bug.cgi?id=170710

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing and activated tests.

Making LibWebRTCProvider::factory not static.
For that purpose LibWebRTCMediaEndpoint now stores its peer connection factory reference.
Making LibWebRTCProvider use libebrtc networking by default.

Removing some no longer needed checks related to libwebrtc availability.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::factory):

platform/mediastream/libwebrtc/LibWebRTCProvider.h:

Source/WebKit2:

WebProcess/Network/webrtc/LibWebRTCProvider.h: Making sure networking is not done in the Web process.

LayoutTests:

platform/mac-wk1/TestExpectations:

10:06 AM Changeset in webkit [215238] by commit-queue@webkit.org

53 edits in trunk

MediaStream id should be equal to msid
https://bugs.webkit.org/show_bug.cgi?id=170712

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
web-platform-tests/webrtc/no-media-call-expected.txt:
web-platform-tests/webrtc/promises-call-expected.txt:
web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription-expected.txt:

Source/WebCore:

Covered by rebased tests.

Setting MediaStream id to libwebrtc mediastream label.
Refactoring to use more Ref<> in MediaStream code.

Making PeerConnection use the libwebrtc backend by default for layout tests instead of the mock.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::createTrackPrivateVector):
(WebCore::MediaStream::MediaStream):

Modules/mediastream/MediaStream.h:
Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::lookUp):

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):

platform/graphics/MediaPlayer.h:
platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::MediaStreamPrivate):

platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivate::create):

testing/Internals.cpp:

(WebCore::Internals::Internals):

LayoutTests:

Removing no longer needed/Adding needed calls to useMockRTCPeerConnectionFactory.

fast/mediastream/RTCPeerConnection-inspect-answer.html:
fast/mediastream/RTCPeerConnection-inspect-offer.html:
fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html:
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html:
fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html:
webrtc/audio-peer-connection-webaudio.html:
webrtc/audio-replace-track.html:
webrtc/connection-state.html:
webrtc/datachannel/basic.html:
webrtc/datachannel/bufferedAmountLowThreshold.html:
webrtc/datachannel/datachannel-gc.html:
webrtc/datachannel/datachannel-stats.html:
webrtc/datachannel/filter-ice-candidate.html:
webrtc/ephemeral-certificates-and-cnames.html:
webrtc/libwebrtc/descriptionGetters.html:
webrtc/negotiatedneeded-event-addStream.html:
webrtc/no-port-zero-in-upd-candidates.html:
webrtc/peer-connection-audio-mute.html:
webrtc/peer-connection-audio-mute2.html:
webrtc/peer-connection-remote-audio-mute.html:
webrtc/peer-connection-remote-audio-mute2.html:
webrtc/release-after-getting-track.html:
webrtc/video-disabled-black.html:
webrtc/video-getParameters.html:
webrtc/video-mediastreamtrack-stats.html:
webrtc/video-mute.html:
webrtc/video-remote-mute.html:
webrtc/video-replace-track-to-null.html:
webrtc/video-replace-track.html:
webrtc/video-stats.html:
webrtc/video-with-receiver.html:
webrtc/video.html:

10:03 AM Changeset in webkit [215237] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[jsc] Add missing MacroAssemblerMIPS::or32() implementation
https://bugs.webkit.org/show_bug.cgi?id=169714

Patch by Guillaume Emont <guijemont@igalia.com> on 2017-04-11
Reviewed by Michael Catanzaro.

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::or32):
Added or32(TrustedImm32, Address).

10:00 AM Changeset in webkit [215236] by Chris Fleizach

6 edits in trunk

AX: Web article navigation does not work (article rotor for Facebook, Twitter, Messages etc.)
https://bugs.webkit.org/show_bug.cgi?id=170330
<rdar://problem/31366105>

Reviewed by Joanmarie Diggs.

Source/WebCore:

Add a search ability for the "article" role.

Test: accessibility/mac/search-predicate-article.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):

accessibility/AccessibilityObject.h:
accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):

accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(createAccessibilitySearchKeyMap):

LayoutTests:

accessibility/mac/search-predicate-article-expected.txt:
accessibility/mac/search-predicate-article.html:

9:54 AM Changeset in webkit [215235] by commit-queue@webkit.org

7 edits in trunk

test262: test262/test/annexB/language/comments/multi-line-html-close.js
https://bugs.webkit.org/show_bug.cgi?id=170648

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-11
Reviewed by Keith Miller.

JSTests:

test262.yaml:

Source/JavaScriptCore:

parser/Lexer.cpp:

(JSC::Lexer<T>::lex):
A multi-line comment that contains a line terminator is itself treated
like a line terminator. An HTML Close Comment that comes after it can
therefore treat it like it is at the start of a line, because it was
immediately preceeded by the equivalent of a line terminator.

LayoutTests:

js/parser-xml-close-comment-expected.txt:
js/script-tests/parser-xml-close-comment.js:

Update test coverage for JavaScript HTML comments.

9:38 AM Changeset in webkit [215234] by commit-queue@webkit.org

24 edits
1 add in trunk

test262: test262/test/built-ins/Array/S15.4.3_A2.2.js
https://bugs.webkit.org/show_bug.cgi?id=170652

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-11
Reviewed by Michael Saboff.

JSTests:

stress/native-constructors-length.js: Added.

(assertLengthDescriptorAttributes):
Add a quick test for the length properties of all native constructors.

ChakraCore/test/es5/enumerable.baseline-jsc:

Rebaseline expectations for this test.

test262.yaml:

Source/JavaScriptCore:

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::finishCreation):

runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::finishCreation):

runtime/DateConstructor.cpp:

(JSC::DateConstructor::finishCreation):

runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::finishCreation):

runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation):

runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):

runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):

runtime/StringConstructor.cpp:

(JSC::StringConstructor::finishCreation):

runtime/SymbolConstructor.cpp:

(JSC::SymbolConstructor::finishCreation):
Ensure the "length" property on these native constructors is configurable (deletable).

LayoutTests:

ietestcenter/Javascript/15.2.3.3-4-186-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-191-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-194-expected.txt:
ietestcenter/Javascript/15.2.3.3-4-201-expected.txt:
ietestcenter/Javascript/15.3.3.2-1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.3/S15.4.3_A2.2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.1_Date.prototype.constructor/S15.9.5.1_A3_T2-expected.txt:

These tests expected the opposite, they are now out of date.

9:26 AM Changeset in webkit [215233] by Chris Fleizach

17 edits in trunk/Source

AX: PDF plugin needs to support PDF-DOM Mode
https://bugs.webkit.org/show_bug.cgi?id=170589

Reviewed by Tim Horton.

Source/WebCore:

Provide WebCore support for accessibility connect to PDF document.
This includes the ability to connect a PDF annotation created node within WebKit to

its PDFAnnotation parent (through use of shadowPluginParent).

accessibility/AXObjectCache.h:
accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXPostNotificationWithUserInfo):

accessibility/mac/WebAccessibilityObjectWrapperMac.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper shadowPluginParent]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

html/HTMLAttributeNames.in:
plugins/PluginViewBase.h:

(WebCore::PluginViewBase::accessibilityShadowPluginParentForElement):

Source/WebKit2:

Provide access to DOM objects with PDF document. This mean:

1) Support a different set of attributes for WKPDFPluginAccessibilityObject.

WKPDFPluginAccessibilityObject is now a group instead of forwarding attribute calls to the pdf layer.

2) Connect the focused UI element to the active annotation if possible.
3) Mark the PDF associated nodes with an attribute so they can be identified later so their correct parent can be found.

WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginAccessibilityObject pdfLayerController]):
(-[WKPDFPluginAccessibilityObject setPdfLayerController:]):
(-[WKPDFPluginAccessibilityObject convertRectToScreenSpace:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityActionNames]):
(-[WKPDFPluginAccessibilityObject accessibilityParameterizedAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityFocusedUIElement]):
(-[WKPDFPluginAccessibilityObject accessibilityAssociatedControlForAnnotation:]):
(-[WKPDFPluginAccessibilityObject accessibilityHitTest:]):
(WebKit::PDFPlugin::convertFromRootViewToPDFView):
(WebKit::PDFPlugin::convertFromPDFViewToScreen):
(WebKit::PDFPlugin::pluginHandlesContentOffsetForAccessibilityHitTest):
(WebKit::PDFPlugin::axObjectCache):
(WebKit::PDFPlugin::accessibilityShadowPluginParentForElement):

WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach):

WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::accessibilityShadowPluginParentForElement):
(WebKit::Plugin::pluginHandlesContentOffsetForAccessibilityHitTest):

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::accessibilityShadowPluginParentForElement):

WebProcess/Plugins/PluginView.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

8:59 AM Changeset in webkit [215232] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for Windows after r215228 part 2
https://bugs.webkit.org/show_bug.cgi?id=170723

Since GCActivityCallback class is annotated exported, we do not need to annotate each member.

heap/GCActivityCallback.h:

8:51 AM Changeset in webkit [215231] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r215153): Request Animation Frame broken when building without REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR
https://bugs.webkit.org/show_bug.cgi?id=170719

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-04-11
Reviewed by Žan Doberšek.

This is because when not using the display refresh monitor, the timer is always used, not only when throttling,
but since r215153 the rAF timer is always aligned to 30ms.

Fixes: fast/animation/request-animation-frame-too-rapid.html

dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::scheduleAnimation): Only do the timer alignment when throttling.

8:47 AM Changeset in webkit [215230] by Yusuke Suzuki

2 edits in trunk/Source/WTF

Unreviewed, build fix for Windows port after r215228
https://bugs.webkit.org/show_bug.cgi?id=170723

wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::timerFired):

8:10 AM Changeset in webkit [215229] by yoav@yoav.ws

14 edits in trunk

[link preload] Double downloads of preloaded content when it's in MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=170122

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests, but unflaked http/tests/preload/single_download_preload_headers_charset.html.

The test was flaky because it appears as if MemoryCache is not being evicted between runs,
and running multiple iterations of the test resulted in preloaded being taken out of MemoryCache
and not having the unknown encoding flag. In those cases, the result was a double download and
a failed test.

loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::setEncoding): Set the m_encodingSet flag.

loader/TextResourceDecoder.h: Added an m_encodingSet flag initialized to false.
loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::setEncoding): Assert that stylesheets don't maintain decoded text.

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource): Remove initialization of hasUnknownEncoding flag.

loader/cache/CachedResource.h:

(WebCore::CachedResource::hasUnknownEncoding): Remove.
(WebCore::CachedResource::setHasUnknownEncoding): Remove.
(WebCore::CachedResource::CachedResource): Remove initialization of hasUnknownEncoding flag.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Set the encoding in case it changed.

LayoutTests:

TestExpectations: Removed flakiness label from the header preload charset test.
fast/loader/cache-encoding-expected.txt: Changed expectation.
fast/loader/cache-encoding.html: Modified behavior to stick with the first decoded string.
http/tests/preload/preload-encoding-expected.txt: Changed expectation.
http/tests/preload/preload-encoding.html: Modified behavior to stick with the first decoded string.
imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-01-expected.txt: This test refers to the same file

twice and expects different decoding for it each time. This is the behavior that we modified, and therefore the test expectation is changed as well.

8:09 AM WebKitGTK/2.16.x edited by Michael Catanzaro

(diff)

8:08 AM WebKitGTK/2.16.x edited by Michael Catanzaro

(diff)

7:56 AM Changeset in webkit [215228] by Yusuke Suzuki

19 edits in trunk/Source

[JSC][GTK] Use RunLoop::Timer in GTK port
https://bugs.webkit.org/show_bug.cgi?id=170723

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

This patch makes GTK port use RunLoop::Timer for JSRunLoopTimer.
Only Cocoa-based ports use platform-specific Timer because it
has additional feature that changes RunLoop to the WebThread one.

And we enable Heap timers in all the ports including JSCOnly port.

heap/EdenGCActivityCallback.cpp:

(JSC::EdenGCActivityCallback::lastGCLength):

heap/EdenGCActivityCallback.h:
heap/FullGCActivityCallback.cpp:

(JSC::FullGCActivityCallback::lastGCLength):

heap/FullGCActivityCallback.h:
heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::doWork):
(JSC::GCActivityCallback::scheduleTimer):
(JSC::GCActivityCallback::cancelTimer):
(JSC::GCActivityCallback::nextFireTime):
(JSC::GCActivityCallback::didAllocate):

heap/GCActivityCallback.h:
heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doWork):
(JSC::IncrementalSweeper::doSweep):

heap/IncrementalSweeper.h:
heap/StopIfNecessaryTimer.cpp:

(JSC::StopIfNecessaryTimer::scheduleSoon):

runtime/JSRunLoopTimer.cpp:

(JSC::JSRunLoopTimer::setRunLoop):
(JSC::JSRunLoopTimer::scheduleTimer):
(JSC::JSRunLoopTimer::cancelTimer):
(JSC::JSRunLoopTimer::JSRunLoopTimer):
(JSC::JSRunLoopTimer::~JSRunLoopTimer):
(JSC::JSRunLoopTimer::timerDidFireCallback):

runtime/JSRunLoopTimer.h:
runtime/PromiseDeferredTimer.cpp:

(JSC::PromiseDeferredTimer::scheduleWorkSoon):

Source/WTF:

Add secondsUntilFire method. And add setName and setPriority
for GTK RunLoop::Timer.

wtf/RunLoop.h:
wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::TimerBase::secondsUntilFire):

wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::secondsUntilFire):

wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::setName):
(WTF::RunLoop::TimerBase::secondsUntilFire):

wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::isActive):
(WTF::RunLoop::TimerBase::secondsUntilFire):

6:19 AM Changeset in webkit [215227] by magomez@igalia.com

6 edits in trunk/Source/WebCore

REGRESSION(r215211): [GTK] Lots of image related tests are timing out, causing the test bot to exit early
https://bugs.webkit.org/show_bug.cgi?id=170727

Reviewed by Carlos Garcia Campos.

Since r215211 ImageDecoder::isSizeAvailable() calls encodedDataStatus() in the different decoder implementations,
and those implementations force a partial decoding of the image if the size is not available yet. But
ImageDecoder::isSizeAvailable() was already being used inside the decoders assuming that it wasn't going to
force this partial decoding. Due to this, there are some situations where the partial decoding is not
desired but it's happening anyway. For example, the check in setSize(), which causes the partial decoding
to happen again and again because no value is actually set to the animation size (which causes the timouts
in the test bot).

To avoid this, replace all the calls to ImageDecoder::isSizeAvailable() inside the decoders with calls to
ImageDecoder::encodedDataStatus(), which doesn't force the partial decoding.

Covered by existent tests.

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setSize):

platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):

platform/image-decoders/jpeg/JPEGImageDecoder.h:
platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::frameBufferAtIndex):

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

5:44 AM Changeset in webkit [215226] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[jsc][mips] Add missing MacroAssembler functions after r214187
https://bugs.webkit.org/show_bug.cgi?id=170089

Patch by Guillaume Emont <guijemont@igalia.com> on 2017-04-11
Reviewed by Yusuke Suzuki.

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::loadFloat): Added.
(JSC::MacroAssemblerMIPS::storeFloat): Added.

4:19 AM Changeset in webkit [215225] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Attach popup menu to web view widget
https://bugs.webkit.org/show_bug.cgi?id=145866

Use gtk_menu_attach_to_widget() to let GTK+ know that popup menus belong to a certain web view.
This improves the positioning choices that the toolkit can do, and solves a long-standing issue
that caused long popup menus to hang outside of the available display area under Wayland.

Based on a patch by Jonas Ådahl <jadahl@gmail.com>.

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-11
Reviewed by Carlos Garcia Campos.

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

3:22 AM Changeset in webkit [215224] by magomez@igalia.com

7 edits in trunk/Source/WebCore

REGRESSION(r215211): [GTK] Lots of image related tests are crashing, causing the test bot to exit early
https://bugs.webkit.org/show_bug.cgi?id=170721

Reviewed by Carlos Garcia Campos.

r215211 caused an infinite loop because of calls between ImageDecoder::isSizeAvailable() and the specializations of
ImageDecoder::encodedDataStatus(). Change the different decoders so ImageDecoder::encodedDataStatus doesn't call
ImageDecoder::isSizeAvailable().

Covered by existent tests.

platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::encodedDataStatus):

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::encodedDataStatus):

platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::encodedDataStatus):

platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::encodedDataStatus):

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::encodedDataStatus):

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::encodedDataStatus):

2:34 AM Changeset in webkit [215223] by Yusuke Suzuki

9 edits in trunk/Source

[JSC] Enable JSRunLoopTimer for JSCOnly and Windows
https://bugs.webkit.org/show_bug.cgi?id=170655

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

runtime/JSRunLoopTimer.cpp:

(JSC::JSRunLoopTimer::JSRunLoopTimer):
(JSC::JSRunLoopTimer::scheduleTimer):
(JSC::JSRunLoopTimer::cancelTimer):

runtime/JSRunLoopTimer.h:

Source/WTF:

This patch makes RunLoop::Timer in Generic and Windows thread-safe to use it
in JSC's JSRunLoopTimer. Eventually, we would like to replace JSRunLoopTimer's
platform-dependent implementation to WTF::RunLoop::Timer.

wtf/RunLoop.h:
wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::TimerBase::start):

wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::ScheduledTask::EarliestSchedule::operator()):
(WTF::RunLoop::populateTasks):
(WTF::RunLoop::runImpl):
(WTF::RunLoop::schedule):
(WTF::RunLoop::scheduleAndWakeUp):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::TimerBase):

wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

2:20 AM Changeset in webkit [215222] by Manuel Rego Casasnovas

4 edits in trunk/LayoutTests

[css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
https://bugs.webkit.org/show_bug.cgi?id=167538

Reviewed by Darin Adler.

fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
as the caret was not always painted in the test runner.
The test was checking for a crash in simplified layout (see bug #163450)
and has nothing to do with the caret or "autofocus" behavior.
"autofocus" was needed to get the crash, so this change modifies
the test to blur the element, so the caret is not painted anymore.

fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:

Don't focus the input element.

fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur

the input element to avoid showing the caret.

platform/mac-wk2/TestExpectations: Remove file from expectations.

1:29 AM Changeset in webkit [215221] by zandobersek@gmail.com

2 edits in trunk

[CMake] OpenWebRTC libraries path isn't properly deduced
https://bugs.webkit.org/show_bug.cgi?id=170670

Reviewed by Carlos Garcia Campos.

When using OpenWebRTC installation that's outside of the usual Jhbuild
installation directories, the library paths are ignored because the
dependency libraries are simply gathered from the pkg-config file.

Instead, the pkg-config data should be used to search for the correct
paths to the header and library locations. Both libopenwebrtc and
libopenwebrtc_gst libraries are needed, so the two library paths are
concatenated into the OPENWEBRTC_LIBRARIES variable.

Source/cmake/FindOpenWebRTC.cmake:

1:27 AM Changeset in webkit [215220] by zandobersek@gmail.com

3 edits in trunk/Source/WTF

REGRESSION(r213645): It made JSC tests super slow and timeout on AArch64 Linux
https://bugs.webkit.org/show_bug.cgi?id=169510

Reviewed by Saam Barati.

Add the volatile qualifiers for ASM statements that set up ldxr and stxr
instruction calls when HAVE(LL_SC) is enabled for aarch64 platforms.

This avoids indefinite execution when running GCC-compiled JSC on Linux.
Specific bug or expected behavior that differs from Clang wasn't determined.

HAVE(LL_SC) is re-enabled on non-Darwin aarch64 platforms.

wtf/Atomics.h:
wtf/Platform.h:

Apr 10, 2017:

11:18 PM Changeset in webkit [215219] by achristensen@apple.com

12 edits in trunk

Revert r215217
https://bugs.webkit.org/show_bug.cgi?id=170703

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

10:46 PM Changeset in webkit [215218] by Chris Dumez

2 edits in trunk/Source/WebCore

Fix bad change in r215167.
https://bugs.webkit.org/show_bug.cgi?id=170656

Reviewed by Yusuke Suzuki.

Revert mistake made in r215167.

rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::caretBlinkInterval):

10:05 PM Changeset in webkit [215217] by achristensen@apple.com

12 edits in trunk

Continue enabling WebRTC
https://bugs.webkit.org/show_bug.cgi?id=170703

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:57 PM Changeset in webkit [215216] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

PlayerLayerView +layerClass methods should use return type Class.
https://bugs.webkit.org/show_bug.cgi?id=165406

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-04-10
Reviewed by Sam Weinig.

No new tests because not behavior change.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPictureInPicturePlayerLayerView_layerClass):
(WebAVPlayerLayerView_layerClass):

8:33 PM Changeset in webkit [215215] by commit-queue@webkit.org

2 edits in trunk/Tools

Have parseRevisionProperty use default repo name as the Buildbot key.
https://bugs.webkit.org/show_bug.cgi?id=170696

Patch by Kocsen Chung <Kocsen Chung> on 2017-04-10
Reviewed by Daniel Bates.

Previously, we needed to set a key and a fallbackKey when addressing
Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
that the repo name maps exactly to that key for every repository other
than WebKit.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Set key = repositoryName and only use fallback keys when dealing with WebKit.

7:49 PM Changeset in webkit [215214] by aakash_jain@apple.com

2 edits in trunk/Tools

Add test262 JavaScriptCore tests to dashboard
https://bugs.webkit.org/show_bug.cgi?id=170711

Rubber-stamped by Joseph Pecoraro.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): Added test262 JSC tests to dashboard.

6:14 PM Changeset in webkit [215213] by jiewen_tan@apple.com

2 edits in trunk/LayoutTests

Unreviewed, test expectations update

platform/wk2/TestExpectations:

5:40 PM Changeset in webkit [215212] by commit-queue@webkit.org

16 edits in trunk

REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
https://bugs.webkit.org/show_bug.cgi?id=170707
<rdar://problem/27788755>

Patch by Alex Christensen <achristensen@webkit.org> on 2017-04-10
Reviewed by Tim Horton.

Source/WebKit2:

We fix this by sending the UserContentController with the WebPageCreationParameters
instead of in a IPC message immediately following creation. By the time the WebPage
receives its second message, it has already started loading the first main resource.

I also changed all instances of calling ChildProcessProxy::connection() to send a message
in favor of calling ChildProcessProxy::send, which does the same thing except if a child
process has not started, it will put the message in a queue and send it when the process
is finished launching. This was necessary because the UserContentController is now connected
to the process sooner, so there were some API tests that would try to send messages between
initiating a process launch and finishing a process launch, and this change preserves the
existing behavior in those cases.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):
(WebKit::DatabaseProcessProxy::didFinishLaunching):

UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::cancel):
(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):

UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserContentWorldUse):
(WebKit::WebUserContentControllerProxy::removeUserContentWorldUses):
(WebKit::WebUserContentControllerProxy::addUserScript):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
(WebKit::WebUserContentControllerProxy::addUserScriptMessageHandler):
(WebKit::WebUserContentControllerProxy::removeUserMessageHandlerForName):
(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
(WebKit::WebUserContentControllerProxy::addContentExtension):
(WebKit::WebUserContentControllerProxy::removeContentExtension):
(WebKit::WebUserContentControllerProxy::removeAllContentExtensions):

UIProcess/UserContent/WebUserContentControllerProxy.h:
UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::removeAll):
(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::sendTable):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::finishInitializingWebPageAfterProcessLaunch):
(WebKit::WebPageProxy::creationParameters):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addWebUserContentControllerProxy):

UIProcess/WebProcessProxy.h:
WebProcess/UserContent/WebUserContentController.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_backgroundCPULimit):

Tools:

TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST_F):

TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):

5:24 PM Changeset in webkit [215211] by commit-queue@webkit.org

33 edits
1 add in trunk/Source/WebCore

CachedImage should stop decoding images when unknown type is detected
https://bugs.webkit.org/show_bug.cgi?id=170530

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-04-10
Reviewed by Tim Horton.

If the status of the encoded data is "unknown type", WebKit should stop
decoding the rest of the data. Ideally WebKit should also cancel loading
the rest of the encoded data.

To do that we need to add a function to the ImageDecoder to return the
encodedDataStatus(). We also need to change the return type of Image::setData()
and Image::dataChanged() form bool to EncodedDataStatus.

WebCore.xcodeproj/project.pbxproj: Add ImageTypes.h to the WebCore project.
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer): Replace checking !sizeAvailable
by checking if encodedDataStatus isn't an error but it has not reached
sizeAvailable state

loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker): Unrelated clean-up.
(WebCore::CachedResourceClientWalker::next): Ditto.

loader/icon/IconRecord.cpp:

(WebCore::IconRecord::setImageData): Image::setData() used to return a bool. Now it returns
an EncodedDataStatus. !setData() now means setData() < EncodedDataStatus::SizeAvailable.

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::dataChanged): Replace the return of dataChanged() from bool
by EncodedDataStatus.

platform/graphics/BitmapImage.h: Replace isSizeAvailable() by a new function

named encodedDataStatus().

platform/graphics/Image.cpp:

(WebCore::Image::setData): Code clean-up and adding a clarification comment.

platform/graphics/Image.h: Change the return of setData() and dataChanged() to be

EncodedDataStatus.
(WebCore::Image::dataChanged): Return EncodedDataStatus::Unknown as an indication
the size is not available but we do not have an error.

platform/graphics/ImageTypes.h: Added.

Image definitions which are shared among Image, ImageDecoder, ImageSource,
ImageFrameCache and ImageFrame used to be added to ImageFrame.h. This has
been annoying since these definitions aren't related to ImageFrame only.
A new header file named ImageTypes.h is to the to include such definitions.
(WebCore::operator++):

platform/graphics/ImageFrame.h:

(WebCore::operator++): Deleted.

platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::ImageFrameCache): This is the case of a BitmapImage without
a decoder but with a NativeImage. The status has to be EncodedDataStatus::Complete.
(WebCore::ImageFrameCache::growFrames): Replace if (isSizeAvailable()) by
if (encodedDataStatus() >= EncodedDataStatus::SizeAvailable).
(WebCore::ImageFrameCache::metadata): Ditto.
(WebCore::ImageFrameCache::encodedDataStatus): This is a replacement for isSizeAvailable().
Don't cache the EncodedDataStatus until it is Complete. Don't call didDecodeProperties()
until the status >= EncodedDataStatus::SizeAvailable.
(WebCore::ImageFrameCache::isSizeAvailable): Deleted.

platform/graphics/ImageFrameCache.h: Replace isSizeAvailable() by encodedDataStatus().
platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::dataChanged): Make return an EncodedDataStatus instead of returning
a bool for isSizeAvailable.

platform/graphics/ImageSource.h:

(WebCore::ImageSource::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus().
(WebCore::ImageSource::isSizeAvailable): Deleted.

platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus().
The logic of this function is the following:

-- CGImageSourceGetStatus() can return kCGImageStatusUnexpectedEOF, kCGImageStatusInvalidData
or kCGImageStatusReadingHeader even if CG will end up recovering form the error and drawing
the image. Actually CG initializes the status of CGImageSource before receiving any data
with kCGImageStatusInvalidData. So the status will be considered an error only if all the
data is received but CG does not move the status of this CGImageSource to Complete.
-- If CGImageSourceGetStatus() returns Incomplete, this means CG already created the image
reader and therefore the image type is known.
-- If CGImageSourceGetStatus() returns UnknownType, this means CG could not create the
image reader and this should be considered an error.

(WebCore::ImageDecoder::isSizeAvailable): Deleted.

platform/graphics/cg/ImageDecoderCG.h: Replace isSizeAvailable() by encodedDataStatus().
platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::dataChanged): The PDFDocument is created only when allDataReceived.

platform/graphics/cg/PDFDocumentImage.h: Change the return type from bool to EncodedDataStatus.
platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::encodedDataStatus): Add a new function encodedDataStatus(). Deduce the
status of the encoded data from the flags m_failed, m_isAllDataReceived and m_sizeAvailable in
this order.
(WebCore::ImageDecoder::isSizeAvailable): Make this function uses encodedDataStatus().

platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus().
(WebCore::BMPImageDecoder::isSizeAvailable): Deleted.

platform/image-decoders/bmp/BMPImageDecoder.h:
platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::encodedDataStatus): Ditto.
(WebCore::GIFImageDecoder::isSizeAvailable): Deleted.

platform/image-decoders/gif/GIFImageDecoder.h:
platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::encodedDataStatus): Ditto.
(WebCore::ICOImageDecoder::isSizeAvailable): Deleted.

platform/image-decoders/ico/ICOImageDecoder.h:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::encodedDataStatus): Ditto.
(WebCore::JPEGImageDecoder::isSizeAvailable): Deleted.

platform/image-decoders/jpeg/JPEGImageDecoder.h:
platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::encodedDataStatus): Ditto.
(WebCore::PNGImageDecoder::isSizeAvailable): Deleted.

platform/image-decoders/png/PNGImageDecoder.h:
platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::encodedDataStatus): Ditto.
(WebCore::WEBPImageDecoder::isSizeAvailable): Deleted.

platform/image-decoders/webp/WEBPImageDecoder.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged): m_page is created only when allDataReceived is true.

svg/graphics/SVGImage.h:

5:23 PM Changeset in webkit [215210] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark two newly imported web-platform-tests as failing.

Unreviewed test gardening.

TestExpectations:

5:11 PM Changeset in webkit [215209] by achristensen@apple.com

7 edits in trunk

Add API to get available content extension identifiers in a WKContentExtensionStore
https://bugs.webkit.org/show_bug.cgi?id=170093

Reviewed by Geoffrey Garen.

Source/WebKit2:

UIProcess/API/APIContentExtensionStore.cpp:

(API::constructedPathPrefix):
(API::constructedPathFilter):
(API::constructedPath):
(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers):

UIProcess/API/APIContentExtensionStore.h:
UIProcess/API/Cocoa/WKContentExtensionStore.h:
UIProcess/API/Cocoa/WKContentExtensionStore.mm:

(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:releasesArgument:]):
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore getAvailableContentExtensionIdentifiers:]):
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):

Tools:

TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(TEST_F):

4:59 PM Changeset in webkit [215208] by mmaxfield@apple.com

2 edits in trunk/Source/WebCore

Mark SVG-Within-OpenType as "Under Consideration"
https://bugs.webkit.org/show_bug.cgi?id=170706

Reviewed by Brady Eidson.

features.json:

3:22 PM Changeset in webkit [215207] by Wenson Hsieh

4 edits in trunk/Tools

Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
https://bugs.webkit.org/show_bug.cgi?id=170658

Reviewed by Tim Horton.

Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
preparation is synchronous, or passes if it is asynchronous.

TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView initWithFrame:]):
(-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
(-[TestWKWebView _setUpTestWindow:]):

2:46 PM Changeset in webkit [215206] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets: Don't clip data in the data grid
https://bugs.webkit.org/show_bug.cgi?id=170559

Reviewed by Timothy Hatcher.

Long lines without spaces should be broken down into several lines instead of being ellipsized.

UserInterface/Views/WebSocketContentView.css:

(.web-socket.content-view > .data-grid td.data-column,):

2:45 PM Changeset in webkit [215205] by rniwa@webkit.org

33 edits
2 adds in trunk/Websites/perf.webkit.org

Add the UI for scheduling a A/B testing with a custom root
https://bugs.webkit.org/show_bug.cgi?id=170622

Reviewed by Anders Carlsson.

This patch adds the support for creating a new analysis task with a custom darwinup roots. A follow up patch
would update the syncing script to schedule such an A/B testing job to a buildbot instance.

ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace

the file path for the backup.

init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column

to store the root file in commit_set_relationships.

public/api/build-requests.php:

(main): Include the uploaded files.

public/api/commits.php:

(main): Added the support for querying the latest commits for a given platform. This is used in a new page
to create a custom analysis task to autofill the latest revisions for a given platform.

public/api/test-groups.php:

(main): Include the uploaded files.

public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::construct): Added a list of uploaded_files and a map from its id.
(BuildRequestsFetcher::uploaded_files): Added.
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Added the support for including custom roots' id in
each commit set, and inserting its meta data in the list of uplaoded files.

public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_latest_for_platform): Added. Finds the latest commit for a given platform. Ideally,
we should be finding the latest commit for a given platform, but this is very slow so instead find the commit
of the latest build for a given platform.

public/privileged-api/create-test-group.php:

(main): Added the support for creating an analysis task along with a group.
(commit_sets_from_revision_sets): Added the support for custom roots. Verify the specified uploaded file exists
and include it in commit_set_relationships. Because commits and upload files are stored in a different column
in commit_set_relationships, this function now stores the information for each row of commit_set_relationships
except the commit set ID, which is unknown until the set is created, instead of a commit ID.
(ensure_commit_sets): Made the each entry in a commit set a row instead of a commit ID as done. As this format
is only by v2 UI and detect-changes.js, we don't add the support for specifying custom roots here.

public/privileged-api/upload-file.php:

(main): Fixed a typo. Also added one more error check.

public/v3/components/custom-analysis-task-configurator.js: Added. The UI for selecting a test, a platform,

and a set of revisions, as well as custom roots for a custom A/B testing job. The first set of revision with
custom roots is referred as "baseline", and the second configuration is referred as "comparison" in this class.
(CustomAnalysisTaskConfigurator):
(CustomAnalysisTaskConfigurator.prototype.tests): Added.
(CustomAnalysisTaskConfigurator.prototype.platform): Added.
(CustomAnalysisTaskConfigurator.prototype.commitSets): Added. Returns a pair of baseline and comparsion if both
have been configured by the user.
(CustomAnalysisTaskConfigurator.prototype.didConstructShadowTree): Added.
(CustomAnalysisTaskConfigurator.prototype._configureComparison): Added. Called when the user is to configu the
"comparison" configuration.
(CustomAnalysisTaskConfigurator.prototype.render): Added.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests): Added. Renders the list of top-level tests
that can be scheduled by a triggerable.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerablePlatforms): Added. Renders the list of platforms
that can be schedule with the currently selected list of tests by a triggerable. Note that the current UI only
lets the user select a single test but the intent is to allow multiple tests to be selected in the near future.
(CustomAnalysisTaskConfigurator.prototype._buildCheckboxList): Added. Creates a list of radio boxes to select
an item with a callback for each. It automatically sets "selected" class on the selected item. It's used to
render both the list of tests and platforms.
(CustomAnalysisTaskConfigurator.prototype._updateTriggerable): Added. Finds the triggerable for a given list of
tests and platforms. Returns an error when some tests belong to another triggearalbe.
(CustomAnalysisTaskConfigurator.prototype._updateRepositoryGroups): Added. Finds a repository group to use when
the current triggerable has changed. We try to use the repository group of the same name if there is any, and
defaults to the first repository group if there is none. This allows the set of repositories to be specified to
more or less persist across different triggerables. For example, if iOS platforms and Mac platforms use two
distinct triggerables , and both triggerables have two repository groups: one that only specify the OS and the
other that specifies both teh OS and WebKit revision, then this code allows the choice the user had made to
specify either just the OS or the OS and WebKit will be preserved when the user switches from an iOS platform
to a Mac platform.
(CustomAnalysisTaskConfigurator.prototype._updateCommitSetMap): Added. Create a commit set map, the format that
TestGroup.createWithTask accepts given "baseline" and "comparison" commit sets. Pretend "comparison" is not set
if two sets are identical since it makes no sense to schedule an A/B testing job when A and B are identical.
(CustomAnalysisTaskConfigurator.prototype._computeCommitSet): Added. Creates a commit set using the revisions
and the csutom roots the user had specified.
(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Added. Renders the pane to specify revisions
and custom roots for "baseline" and "comparison".
(CustomAnalysisTaskConfigurator.prototype._renderBaselineRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._renderComparisonRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._optionalRepositoryList): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionTable): Added. Creates a table for specifying revisions
and custom roots along with a list of repository groups to pick. The set of repositories and custom roots are
shown at the all if all repository groups require them. Otherwise, they are grouped at the bottom as optional.
(CustomAnalysisTaskConfigurator.prototype._buildRepositoryGroupList): Added.
(CustomAnalysisTaskConfigurator.prototype._selectRepositoryGroup): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionInput): Added. Creates an input element to specify
a revision for a given repository. Autofills it with the latest commit for the currently selected platform if
the user had not modified the field by the time the revisions are fetched.
(CustomAnalysisTaskConfigurator.htmlTemplate): Added.
(CustomAnalysisTaskConfigurator.cssTemplate): Added.

public/v3/components/instant-file-uploader.js: Added. A form to upload a custom darwinup root in "baseline"

or "comparison" configurations of CustomAnalysisTaskConfigurator. It's "instant" because it auto-detects when a
file to be uploaded had already been uploaded elsewhere by checking its SHA-256 hash.
(InstantFileUploader):
(InstantFileUploader.prototype.hasFileToUpload): Added.
(InstantFileUploader.prototype.uploadedFiles): Added.
(InstantFileUploader.prototype.addUploadedFile): Added. It's called on the uploader for "comparison"
configuration when the uploader for "baseline" configuration dipsatches "uploadedFile" action to automatically
mirror the newly uploaded custom root to "comparision" configuration.
(InstantFileUploader.prototype.didConstructShadowTree): Added.
(InstantFileUploader.prototype.render): Added.
(InstantFileUploader.prototype._renderUploadedFiles): Added. Renders the list of the uploaded files.
(InstantFileUploader.prototype._renderPreuploadFiles): Added. Renders the list of the files to be uploaded with
a progress bar.
(InstantFileUploader.prototype._updateUploadStatus): Added. Updates the progress bar for uploading the file.
(InstantFileUploader.prototype._formatUploadError): Added.
(InstantFileUploader.prototype._didFileInputChange): Added. Called when the user picks a file to uploaded on
the input element. Fetch the meta data for the uploaded file with the same SHA-256 hash if there is any, and
start uploading the file if there isn't one.
(InstantFileUploader.prototype._removeUploadedFile): Added.
(InstantFileUploader.prototype._didUploadFile): Added. Move a file from the list of files to be uploaded to
the list of uploaded files.
(InstantFileUploader.htmlTemplate): Added.
(InstantFileUploader.cssTemplate): Added.

public/v3/index.html:

public/v3/models/analysis-task.js:

(AnalysisTask): Made platform and metric optional as it is now.
(AnalysisTask.findByPlatformAndMetric): Skip analysis tasks without a platform or a metric.
(AnalysisTask.prototype.isCustom): Added. Returns true for a custom analysis task.
(AnalysisTask.fetchRelatedTasks): Skip custom analysis tasks.
(AnalysisTask._constructAnalysisTasksFromRawData): Construct analysis tasks even if they were missing a metric
or a platform instead of silently skipping them.

public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Construct uploaded file objects returned by /api/build-requests.

public/v3/models/commit-log.js:

(CommitLog.fetchLatestCommitForPlatform): Added.

public/v3/models/commit-set.js:

(CommitSet): Added this._customRoots.
(CommitSet.prototype.customRoots): Returns this._customRoots.
(CommitSet.prototype.equals): Returns false when the set of custom roots are not equal.
(CommitSet.areCustomRootsEqual): Added.
(CustomCommitSet):
(CustomCommitSet.prototype.equals): Added.
(CustomCommitSet.prototype.customRoots): Added.
(CustomCommitSet.prototype.addCustomRoot): Added.

public/v3/models/manifest.js:

(Manifest._didFetchManifest): Store fileUploadSizeLimit in the manifest as UploadedFile.fileUploadSizeLimit.
This allows a file size check in the client size instead of uploading it to the server and receiving an error.

public/v3/models/metric.js:

(Metric.formatTime): Moved from ChartPaneStatusView to be also used by InstantFileUploader._renderUploadedFiles.

public/v3/models/test-group.js:

(TestGroup.prototype.createWithTask): Added.
(TestGroup.prototype.createAndRefetchTestGroups):
(TestGroup.prototype._revisionSetsFromCommitSets): Added. Extracted from createAndRefetchTestGroups.
(TestGroup.prototype._fetchTestGroupsForTask): Added. Extracted from createAndRefetchTestGroups.

public/v3/models/triggerable.js:

(Triggerable.triggerablePlatformsForTests): Added.
(Triggerable.sortByNamePreferringSmallerRepositories): Added.

public/v3/models/uploaded-file.js:

(UploadedFile.prototype.createdAt): Added.
(UploadedFile.prototype.filename): Added.
(UploadedFile.prototype.author): Added.
(UploadedFile.prototype.size): Added.
(UploadedFile.uploadFile): Added a client-side check for the file size using UploadedFile.fileUploadSizeLimit.
(UploadedFile.fetchUnloadedFileWithIdenticalHash): Ditto. Also fixed a bug that 404 was resulting in a rejected
promise instead of a resolved promise with null.

public/v3/pages/analysis-category-page.js:

(AnalysisCategoryPage.prototype._reconstructTaskList): Modernized the code. Added the support for platform and
metric being null for some analysis tasks.

public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._didFetchTask): Don't fetch the measurement set or create a chart for custom tasks.
(AnalysisTaskPage.prototype.render): Don't display the charts or the stacking table for custom tasks.
(AnalysisTaskPage.prototype._renderTaskNameAndStatus): Don't try to show the full test name for custom tasks
since it's not associated with exactly one pair.

public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView.prototype._renderBuildRevisionTable):
(ChartPaneStatusView.prototype._formatTime): Moved to Metric.formatTime.

public/v3/pages/chart-pane.js:

(ChartPane.prototype._analyzeRange): Set inProgress to true to hide CustomAnalysisTaskConfigurator in
CreateAnalysisTaskPage when creating a non-custom analysis task for a specific range.

public/v3/pages/create-analysis-task-page.js:

(CreateAnalysisTaskPage): This page now shows CustomAnalysisTaskConfigurator by default, and lets a user create
a custom analysis task by picking a test, a platform, and a set of revisions and custom darwinup roots.
(CreateAnalysisTaskPage.prototype.updateFromSerializedState): Show a message when inProgress is set. This is
the old behavior of this page.
(CreateAnalysisTaskPage.prototype.didConstructShadowTree): Added.
(CreateAnalysisTaskPage.prototype._createAnalysisTaskWithGroup): Added.
(CreateAnalysisTaskPage.prototype.render):
(CreateAnalysisTaskPage.prototype._renderMessage): Added. Hides CustomAnalysisTaskConfigurator and the select
element to specify the numebr of iterations when a message is set.
(CreateAnalysisTaskPage.htmlTemplate):
(CreateAnalysisTaskPage.cssTemplate):

public/v3/pages/page-router.js:

(PageRouter.prototype.route): Always enqueue the page to re-render when the route has changed.

server-tests/api-build-requests-tests.js: Updated test cases now that the response contains a list of

uploaded files associated with build requests.

server-tests/privileged-api-create-test-group-tests.js: Added test cases for creating a custom analysis task

and a test group with custom roots.

server-tests/resources/mock-data.js:

(MockData.addMockData): Updated the mock data to satisfy new constraint on analysis-tasks table.

tools/js/remote.js: Include global.FormData from form-data.js.

unit-tests/build-request-tests.js:

(sampleBuildRequestData): Updated the mock response.

unit-tests/buildbot-syncer-tests.js:

(createSampleBuildRequest): Ditto.

unit-tests/test-groups-tests.js:

(sampleTestGroup): Ditto.

2:44 PM Changeset in webkit [215204] by andersca@apple.com

2 edits in trunk/Source/WebKit/mac

Remove call to WKShowKeyAndMain
https://bugs.webkit.org/show_bug.cgi?id=170691
rdar://problem/31050032

Reviewed by Beth Dakin.

Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter makeKeyWindow]):

2:43 PM Changeset in webkit [215203] by rniwa@webkit.org

36 edits
1 delete in trunk

.:
Elftoolchain ar doesn't support response files
https://bugs.webkit.org/show_bug.cgi?id=170105

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-04-08
Reviewed by Michael Catanzaro.

WebKit enables the use of response files when cmake and ninja is used.
However, the default implementation of ar command used in FreeBSD, which
is part of elftoolchain project, doesn't support reading arguments from
response files. To avoid causing undefined reference error on FreeBSD,
we disable the use of response files when elftoolchain ar is detected.

Source/cmake/OptionsCommon.cmake:

Websites/perf.webkit.org:
Unreviewed, rolling out r215202.
https://bugs.webkit.org/show_bug.cgi?id=170694

Committed incorrectly (Requested by rniwa on #webkit).

Reverted changeset:

"Add the UI for scheduling a A/B testing with a custom root"
https://bugs.webkit.org/show_bug.cgi?id=170622
http://trac.webkit.org/changeset/215202

Patch by Commit Queue <commit-queue@webkit.org> on 2017-04-10

2:38 PM Changeset in webkit [215202] by rniwa@webkit.org

36 edits
5 adds in trunk

Add the UI for scheduling a A/B testing with a custom root
https://bugs.webkit.org/show_bug.cgi?id=170622

Reviewed by Anders Carlsson.

ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace

the file path for the backup.

init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column

to store the root file in commit_set_relationships.

public/api/build-requests.php:

(main): Include the uploaded files.

public/api/commits.php:

(main): Added the support for querying the latest commits for a given platform. This is used in a new page
to create a custom analysis task to autofill the latest revisions for a given platform.

public/api/test-groups.php:

(main): Include the uploaded files.

public/include/build-requests-fetcher.php:

public/include/commit-log-fetcher.php:

public/privileged-api/create-test-group.php:

public/privileged-api/upload-file.php:

(main): Fixed a typo. Also added one more error check.

public/v3/components/custom-analysis-task-configurator.js: Added. The UI for selecting a test, a platform,

public/v3/components/instant-file-uploader.js: Added. A form to upload a custom darwinup root in "baseline"

public/v3/index.html:

public/v3/models/analysis-task.js:

public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Construct uploaded file objects returned by /api/build-requests.

public/v3/models/commit-log.js:

(CommitLog.fetchLatestCommitForPlatform): Added.

public/v3/models/commit-set.js:

public/v3/models/manifest.js:

public/v3/models/metric.js:

(Metric.formatTime): Moved from ChartPaneStatusView to be also used by InstantFileUploader._renderUploadedFiles.

public/v3/models/test-group.js:

public/v3/models/triggerable.js:

(Triggerable.triggerablePlatformsForTests): Added.
(Triggerable.sortByNamePreferringSmallerRepositories): Added.

public/v3/models/uploaded-file.js:

public/v3/pages/analysis-category-page.js:

(AnalysisCategoryPage.prototype._reconstructTaskList): Modernized the code. Added the support for platform and
metric being null for some analysis tasks.

public/v3/pages/analysis-task-page.js:

public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView.prototype._renderBuildRevisionTable):
(ChartPaneStatusView.prototype._formatTime): Moved to Metric.formatTime.

public/v3/pages/chart-pane.js:

(ChartPane.prototype._analyzeRange): Set inProgress to true to hide CustomAnalysisTaskConfigurator in
CreateAnalysisTaskPage when creating a non-custom analysis task for a specific range.

public/v3/pages/create-analysis-task-page.js:

public/v3/pages/page-router.js:

(PageRouter.prototype.route): Always enqueue the page to re-render when the route has changed.

server-tests/api-build-requests-tests.js: Updated test cases now that the response contains a list of

uploaded files associated with build requests.
*server-tests/api-commits-tests.js: Added a test case for /api/commits/<repository-name>/latest?platform=X.

server-tests/privileged-api-create-test-group-tests.js: Added test cases for creating a custom analysis task

and a test group with custom roots.

server-tests/resources/mock-data.js:

(MockData.addMockData): Updated the mock data to satisfy new constraint on analysis-tasks table. Also inserted
more commits, builds, and build_commits rows for testing /api/commits/<repository-name>/latest?platform=X.

tools/js/remote.js: Include global.FormData from form-data.js.

unit-tests/analysis-task-tests.js: Added a test for calling findByPlatformAndMetric when there is a custom

analysis task.
(sampleAnalysisTask): Removed the category since /api/analysis-tasks/ no longer generate this property.
(sampleCustomAnalysisTask): Added.

unit-tests/build-request-tests.js:

(sampleBuildRequestData): Updated the mock response. Added a test case for fetcing custom roots.

unit-tests/buildbot-syncer-tests.js:

(createSampleBuildRequest): Ditto.

unit-tests/test-groups-tests.js:

(sampleTestGroup): Ditto.

2:24 PM Changeset in webkit [215201] by commit-queue@webkit.org

19 edits
2 adds in trunk/Source

Add CoreAudioCaptureSource.
https://bugs.webkit.org/show_bug.cgi?id=170112
rdar://problem/30293338

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-04-10
Source/WebCore:

Reviewed by Eric Carlson.

No new tests because this provides the same funcitonality as AVAudioCaptureSource.
Funcionality is covered by existing test cases.

Add CoreAudioCaptureSource for audio capture. And use it by default in AVCaptureDeviceManager.
Add UseAVFoundationAudioCapture setting to switch back to AVFoundation for audio capture.

WebCore.xcodeproj/project.pbxproj:
page/Settings.cpp:

(WebCore::Settings::useAVFoundationAudioCapture):
(WebCore::Settings::setUseAVFoundationAudioCapture):

page/Settings.h:
platform/mediastream/mac/AVCaptureDeviceManager.h:
platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::setUseAVFoundationAudioCapture):

platform/mediastream/mac/CoreAudioCaptureSource.cpp: Added.

(WebCore::CoreAudioCaptureSource::create):
(WebCore::CoreAudioCaptureSource::factory):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::preferredSampleRate):
(WebCore::CoreAudioCaptureSource::preferredIOBufferDuration):
(WebCore::CoreAudioCaptureSource::configureMicrophoneProc):
(WebCore::CoreAudioCaptureSource::configureSpeakerProc):
(WebCore::CoreAudioCaptureSource::addMicrophoneDataConsumer):
(WebCore::CoreAudioCaptureSource::removeMicrophoneDataConsumer):
(WebCore::CoreAudioCaptureSource::addEchoCancellationSource):
(WebCore::CoreAudioCaptureSource::removeEchoCancellationSource):
(WebCore::CoreAudioCaptureSource::checkTimestamps):
(WebCore::CoreAudioCaptureSource::provideSpeakerData):
(WebCore::CoreAudioCaptureSource::speakerCallback):
(WebCore::CoreAudioCaptureSource::processMicrophoneSamples):
(WebCore::CoreAudioCaptureSource::microphoneCallback):
(WebCore::CoreAudioCaptureSource::defaultOutputDevice):
(WebCore::CoreAudioCaptureSource::defaultInputDevice):
(WebCore::CoreAudioCaptureSource::setupAudioUnits):
(WebCore::CoreAudioCaptureSource::startProducingData):
(WebCore::CoreAudioCaptureSource::stopProducingData):
(WebCore::CoreAudioCaptureSource::suspend):
(WebCore::CoreAudioCaptureSource::resume):
(WebCore::CoreAudioCaptureSource::capabilities):
(WebCore::CoreAudioCaptureSource::settings):

platform/mediastream/mac/CoreAudioCaptureSource.h: Added.
platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):

Source/WebKit/mac:

Reviewed by Eric Carlson.

Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences useAVFoundationAudioCapture]):
(-[WebPreferences setUseAVFoundationAudioCapture:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Reviewed by Tim Horton.

Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetUseAVFoundationAudioCapture):
(WKPreferencesGetUseAVFoundationAudioCapture):

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:02 PM Changeset in webkit [215200] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Wrap legacy MediaStream API in runtime flag
https://bugs.webkit.org/show_bug.cgi?id=169877

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-10
Reviewed by Alex Christensen.

Covered by binding tests.

Marking navigator.getUserMedia and MediaStreamEvent as runtime enabled if mediastream and webrtclegacy api flags
are on.
Updated binding generator to support multiple runtime flags.

Modules/mediastream/MediaStreamEvent.idl:
Modules/mediastream/NavigatorUserMedia.idl:
bindings/scripts/CodeGeneratorJS.pm:

(GetRuntimeEnableFunctionName):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

bindings/scripts/test/TestObj.idl:

1:00 PM Changeset in webkit [215199] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-slider/volume-slider-value.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167475

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

12:59 PM Changeset in webkit [215198] by commit-queue@webkit.org

8 edits in trunk/Source/WebCore

Remove deprecated parts of media stream spec
https://bugs.webkit.org/show_bug.cgi?id=169879

Patch by Youenn Fablet <youenn@apple.com> on 2017-04-10
Reviewed by Jon Lee.

Removing MediaStreamTrackState 'new' value which was unused.
Removing MediaStreamTrack _readonly attribute which was unused.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readonly): Deleted.

Modules/mediastream/MediaStreamTrack.h:
Modules/mediastream/MediaStreamTrack.idl:
platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::readonly): Deleted.

platform/mediastream/MediaStreamTrackPrivate.h:
platform/mediastream/RealtimeMediaSource.h:

12:53 PM Changeset in webkit [215197] by Brent Fulgham

4 edits
2 adds in trunk

[WK2][macOS] Block access to Apple Events before launch.
https://bugs.webkit.org/show_bug.cgi?id=170626
<rdar://problem/16079334>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Clear the environment of the AppleEvent server name before initializing
AppKit so we never bother connecting.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(main):

Tools:

Add a new TestWebKitAPI test that fails if Apple Events are sent.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.

(TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
(TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):

12:38 PM Changeset in webkit [215196] by mark.lam@apple.com

11 edits in trunk/Source/JavaScriptCore

Move ProbeContext and ProbeFunction out of AbstractMacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=170681

Reviewed by Michael Saboff.

This is a refactoring step towards enabling custom probe printers the way printInternal() works for dataLog.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::ProbeContext::gpr): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::fpr): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::gprName): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::fprName): Deleted.

assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

assembler/MacroAssembler.h:

(JSC::ProbeContext::gpr):
(JSC::ProbeContext::fpr):
(JSC::ProbeContext::gprName):
(JSC::ProbeContext::fprName):

assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::probe):

assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeTrampoline):
(JSC::MacroAssemblerARM64::probe):

assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssemblerARMv7::probe):

assembler/MacroAssemblerPrinter.cpp:
assembler/MacroAssemblerPrinter.h:
assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssemblerX86Common::probe):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::abstractStructure):
(JSC::FTL::DFG::LowerDFGToB3::probe): Deleted.

Deleted because this became a useless place-holder after the transition to B3.

12:01 PM Changeset in webkit [215195] by commit-queue@webkit.org

2 edits in trunk/Tools

[JSC] Do not run FTL stress tests on MIPS
https://bugs.webkit.org/show_bug.cgi?id=170684

Patch by Guillaume Emont <guijemont@igalia.com> on 2017-04-10
Reviewed by Carlos Alberto Lopez Perez.

run-jsc-stress-tests does not correctly detect MIPS platforms, and its
logic to detect if the platform supports FTL ignores that MIPS does
not support FTL. This adds detection of MIPS (with the magic number
determined empirically) and fixes the determination of whether we
support FTL.

Scripts/run-jsc-stress-tests:

11:34 AM Changeset in webkit [215194] by keith_miller@apple.com

9 edits
2 adds
1 delete in trunk/JSTests

WebAssembly: Update spec tests
https://bugs.webkit.org/show_bug.cgi?id=170683

Rubber-stamped by JF Bastien.

wasm.yaml:
wasm/spec-tests/br_table.wast.js:
wasm/spec-tests/conversions.wast.js: Removed.
wasm/spec-tests/f32_bitwise.wast.js: Added.
wasm/spec-tests/f32_cmp.wast.js:
wasm/spec-tests/f64_bitwise.wast.js: Added.
wasm/spec-tests/f64_cmp.wast.js:
wasm/spec-tests/i32.wast.js:
wasm/spec-tests/i64.wast.js:
wasm/spec-tests/int_exprs.wast.js:
wasm/spec-tests/memory.wast.js:

11:31 AM Changeset in webkit [215193] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

WebAssembly: Fix B3IRGenerator for BrTable
https://bugs.webkit.org/show_bug.cgi?id=170685

Reviewed by JF Bastien.

For some reason this didn't get included in r215141.

This fixes an issue with BrTable and loops where we would use the loop's return type
as the branch target type.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::ControlData::resultForBranch):
(JSC::Wasm::B3IRGenerator::unifyValuesWithBlock):

11:11 AM Changeset in webkit [215192] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Placeholder text is clipped in the 'Enter Class Name' field at the bottom of Rules style sidebar in some localizations
https://bugs.webkit.org/show_bug.cgi?id=167641
<rdar://problem/26541953>

Reviewed by Joseph Pecoraro.

Make the "Enter Class Name" text field span the entire width of the Styles sidebar.

UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"]): Deleted.
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon): Deleted.
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class.active > .add-class-icon,): Deleted.

UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
Remove the checkbox, which didn't do anything, and the plus icon. Make the "Enter Class Name" text field visible by default.

11:11 AM Changeset in webkit [215191] by Jonathan Bedard

2 edits in trunk/Tools

webkitpy: Increase estimate for processes run by iOS Simulators
https://bugs.webkit.org/show_bug.cgi?id=170678
<rdar://problem/31534061>

Reviewed by Aakash Jain.

Previously, it was estimated that each simulated iOS device would run about 100
processes. With newer versions of iOS, this is closer to 125.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort): Increase process estimate from 100 to 125.

11:06 AM Changeset in webkit [215190] by commit-queue@webkit.org

5 edits in trunk

[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
https://bugs.webkit.org/show_bug.cgi?id=170553

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-10
Reviewed by Michael Catanzaro.

Source/WebKit2:

Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when building with GTK+ 3.22 or
newer. This allows the Wayland GTK+ backend to properly position popup menus, and also avoids
using functions which were deprecated starting at that GTK+ release.

UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::show): Use gtk_menu_popup_at_pointer() as there is always a
pointer event that can be passed to it.

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_popup_at_rect(), using the coordinates
of the control passed as reference rectangle. Some conditional code is needed because with newer
GTK+ versions a relative offset instead of an absolute position is needed.

Tools:

Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
to properly position popup menus, and also avoids using functions
which were deprecated starting at that GTK+ release.

MiniBrowser/gtk/BrowserSearchBar.c:

(searchEntryMenuIconPressedCallback):
Update MiniBrowser to use gtk_menu_popup_at_pointer().

10:58 AM Changeset in webkit [215189] by Wenson Hsieh

9 edits in trunk

REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
https://bugs.webkit.org/show_bug.cgi?id=170677
<rdar://problem/31512633>

Reviewed by Tim Horton.

Tools:

Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
to allow dropping URLs to trigger page navigation.

DumpRenderTree/TestOptions.h:
DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/mac/UIDelegate.h:
DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate resetToConsistentStateBeforeTesting:]):
(-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):

LayoutTests:

Turn enableDragDestinationActionLoad on in these two LayoutTests via WKTR options.

fast/events/drag-to-navigate.html:
fast/events/only-valid-drop-targets-receive-file-drop.html:

10:55 AM Changeset in webkit [215188] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Opening a popup menu does not pre-select the active item
https://bugs.webkit.org/show_bug.cgi?id=170680

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-10
Reviewed by Michael Catanzaro.

UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_shell_select_item() to
ensure that the active item appears selected right after popping up the menu.

10:54 AM Changeset in webkit [215187] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-up-support/volume-up-support.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170682

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

10:35 AM Changeset in webkit [215186] by commit-queue@webkit.org

2 edits in trunk/Tools

update-webkit-dependency should report $response->message for diagnose
https://bugs.webkit.org/show_bug.cgi?id=170666

Patch by Fujii Hironori <Fujii Hironori> on 2017-04-10
Reviewed by Alex Christensen.

Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.

10:28 AM Changeset in webkit [215185] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r215175.

This change caused a flaky crash in existing media tests.

Reverted changeset:

"Add fallback fonts to video captions stylesheet."
https://bugs.webkit.org/show_bug.cgi?id=170495
http://trac.webkit.org/changeset/215175

10:07 AM Changeset in webkit [215184] by Wenson Hsieh

5 edits
1 add in trunk

Data interaction on an image enclosed by an anchor should vend the anchor's URL
https://bugs.webkit.org/show_bug.cgi?id=170660
<rdar://problem/31043220>

Reviewed by Tim Horton.

Source/WebCore:

When writing an image embedded inside an anchor to the pasteboard, actually use the enclosing anchor's href if
it exists. Previously, we were simply dropping this argument on the floor.

Covered by 2 new DataInteractionTests: ImageInLinkToInput and ImageInLinkWithoutHREFToInput.

editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

Tools:

Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
rects, but should not be.

See WebCore ChangeLog for more details.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

9:44 AM Changeset in webkit [215183] by Ryan Haddad

4 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r215131.

Unreviewed test gardening.

platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:

9:05 AM Changeset in webkit [215182] by jonlee@apple.com

7 edits in trunk/Source

Update localizable strings to "full screen" from "fullscreen"
https://bugs.webkit.org/show_bug.cgi?id=170675
rdar://problem/28207034

Reviewed by Antoine Quint.

Source/WebCore:

For localizable strings, it should consistently be "full screen" instead of "fullscreen".

English.lproj/Localizable.strings:
English.lproj/modern-media-controls-localized-strings.js:
platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagExitVideoFullscreen):
(WebCore::localizedMediaControlElementString):

platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::exitFullScreenButtonAccessibilityTitle):

Source/WebInspectorUI:

UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName): For localizable strings, it should consistently be
"full screen" instead of "fullscreen".

6:49 AM Changeset in webkit [215181] by akling@apple.com

11 edits
2 adds in trunk

Don't generate extra scrolling tiles for non-visible pages.
https://bugs.webkit.org/show_bug.cgi?id=167213
<rdar://problem/30105774>

Reviewed by Antti Koivisto.

Source/WebCore:

Reduce the tiling coverage to a minimum when the page is non-visible.
On macOS, this means that fully occluded web views can maintain a smaller set of tiles
in non-volatile surfaces, reducing net footprint.

Test: compositing/tiling/non-visible-window-tile-coverage.html

rendering/RenderLayerBacking.cpp:

(WebCore::computePageTiledBackingCoverage): If the page's activity state is non-visible, use minimal tile coverage.

platform/ScrollView.h:
page/FrameView.h:
page/FrameView.cpp:

(WebCore::FrameView::hide): Call adjustTiledBackingCoverage() in hide() since it now takes page visibility into account.

(WebCore::FrameView::enableSpeculativeTilingIfNeeded):

testing/Internals.cpp:

(WebCore::Internals::setSpeculativeTilingDelayDisabledForTesting):

testing/Internals.h:
testing/Internals.idl: Add an internals API for disabling the 500ms delay before speculative tiling begins after

the main frame load finishes. This is needed for reliably testing this change.

LayoutTests:

TestExpectations:
compositing/tiling/non-visible-window-tile-coverage-expected.txt: Added.
compositing/tiling/non-visible-window-tile-coverage.html: Added.
platform/mac-wk2/TestExpectations:

5:55 AM Changeset in webkit [215180] by berto@igalia.com

2 edits in trunk/Source/WTF

[GTK] Fix x32 build
https://bugs.webkit.org/show_bug.cgi?id=170673

Patch by Thorsten Glaser <tg@mirbsd.de> on 2017-04-10
Reviewed by Carlos Alberto Lopez Perez.

wtf/Platform.h:

4:48 AM Changeset in webkit [215179] by Carlos Garcia Campos

3 edits
6 adds
1 delete in trunk/Tools

[GTK] Remove the GDK dependency from ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=85299

Reviewed by Žan Doberšek.

Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
and also add CG implementation.

ImageDiff/CMakeLists.txt:
ImageDiff/Cairo.cmake: Added.
ImageDiff/ImageDiff.cpp: Added.

(main):

ImageDiff/PlatformGTK.cmake:
ImageDiff/PlatformImage.cpp: Added.

(ImageDiff::PlatformImage::isCompatible):
(ImageDiff::PlatformImage::difference):

ImageDiff/PlatformImage.h: Added.
ImageDiff/cairo/PlatformImageCairo.cpp: Added.

(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

ImageDiff/gtk/ImageDiff.cpp: Removed.

4:44 AM Changeset in webkit [215178] by Carlos Garcia Campos

4 edits in trunk

REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
https://bugs.webkit.org/show_bug.cgi?id=170667

Reviewed by Žan Doberšek.

Tools:

In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
that value.

WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.

LayoutTests:

Unskip then test that is passing now.

platform/gtk/TestExpectations:

4:04 AM Changeset in webkit [215177] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Enable DOM timer throttling and CSS animations suspension
https://bugs.webkit.org/show_bug.cgi?id=170669

Reviewed by Žan Doberšek.

Shared/WebPreferencesDefinitions.h:

3:16 AM Changeset in webkit [215176] by commit-queue@webkit.org

9 edits in trunk/Tools

WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
https://bugs.webkit.org/show_bug.cgi?id=170653

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-04-10
Reviewed by Tim Horton.

When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().

WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
results were created in the web process.

WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.

WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
(WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
(WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).

WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage): Ditto.

3:01 AM Changeset in webkit [215175] by pvollan@apple.com

2 edits in trunk/Source/WebCore

Add fallback fonts to video captions stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=170495

Reviewed by Myles C. Maxfield.

The kCTFontCascadeListAttribute key is used to obtain the cascade list for a font reference.

I have not added a test, since CaptionUserPreferences::testingMode() returns true when running tests,
preventing this code path from being executed.

page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsDefaultFontCSS):

1:28 AM Changeset in webkit [215174] by Carlos Garcia Campos

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark several tests as failing/timing out.

platform/gtk/TestExpectations:

1:02 AM Changeset in webkit [215173] by Chris Dumez

130 edits in trunk

Drop Timer::startOneShot() overload taking a double
https://bugs.webkit.org/show_bug.cgi?id=170659

Reviewed by Yusuke Suzuki.

Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.

Source/WebCore:

Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::startTimerIfNeeded):

Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::configureWatchdogTimer):

Modules/mediasession/WebMediaSessionManager.h:
Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

Modules/vibration/Vibration.cpp:

(WebCore::Vibration::timerFired):

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::close):

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::enqueuePasswordValueChangeNotification):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::focusAriaModalNode):

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setStatus):

css/StyleResolver.cpp:

(WebCore::StyleResolver::addToMatchedPropertiesCache):

dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::finishedParsing):

dom/ScriptedAnimationController.cpp:
editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::startAlternativeTextUITimer):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addBehaviorRestrictionsOnEndIfNecessary):
(WebCore::HTMLMediaElement::handleSeekToPlaybackPosition):

html/SearchInputType.cpp:

(WebCore::SearchInputType::startSearchEventTimer):

html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):

html/canvas/WebGLRenderingContextBase.cpp:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startTimer):
(WebCore::MediaControlPanelElement::makeTransparent):

html/track/VTTRegion.cpp:

(WebCore::VTTRegion::startTimer):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameScheduledNavigation):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameScheduledNavigation):

inspector/InspectorPageAgent.h:
loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::startTimer):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::documentDidFinishLoadEvent):

loader/icon/IconDatabase.cpp:
page/EventHandler.cpp:
page/EventSource.cpp:

(WebCore::EventSource::scheduleReconnect):

page/FocusController.cpp:

(WebCore::FocusController::setFocusedElementNeedsRepaint):

page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::enableSpeculativeTilingIfNeeded):

page/Settings.cpp:

(WebCore::Settings::Settings):

page/Settings.h:

(WebCore::Settings::setTimeWithoutMouseMovementBeforeHidingControls):
(WebCore::Settings::timeWithoutMouseMovementBeforeHidingControls):

page/SuspendableTimer.h:
page/animation/CSSAnimationController.cpp:
page/mac/EventHandlerMac.mm:
page/mac/TextIndicatorWindow.mm:

(WebCore::TextIndicatorWindow::setTextIndicator):

platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::stop):

platform/ScrollAnimationSmooth.cpp:

(WebCore::getAnimationParametersForGranularity):
(WebCore::ScrollAnimationSmooth::updatePerAxisData):
(WebCore::ScrollAnimationSmooth::animateScroll):
(WebCore::ScrollAnimationSmooth::animationTimerFired):
(WebCore::ScrollAnimationSmooth::startNextTimer):

platform/ScrollAnimationSmooth.h:
platform/Timer.h:

(WebCore::TimerBase::startRepeating):

platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::scheduleClientDataBufferingCheck):

platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::scheduleStatelessScrollSnap):

platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::gamepadHadInput):

platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::openAndScheduleManager):
(WebCore::HIDGamepadProvider::valuesChanged):

platform/glib/MainThreadSharedTimerGLib.cpp:

(WebCore::MainThreadSharedTimer::setFireInterval):

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startTimer):
(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::resetAnimation):

platform/graphics/BitmapImage.h:
platform/graphics/MediaPlaybackTargetPicker.cpp:
platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::scheduleScratchBufferPurge):

platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::schedulePrune):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):

platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3DManager::updateHighPerformanceState):

platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):

platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::scheduleReleaseUnusedBuffers):
(WebCore::TextureMapperPlatformLayerProxy::releaseUnusedBuffersTimerFired):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
platform/gtk/ScrollAnimatorGtk.cpp:

(WebCore::ScrollAnimatorGtk::overlayScrollbarAnimationTimerFired):
(WebCore::ScrollAnimatorGtk::showOverlayScrollbars):
(WebCore::ScrollAnimatorGtk::hideOverlayScrollbars):

platform/gtk/ScrollAnimatorGtk.h:
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):

platform/mock/MediaPlaybackTargetPickerMock.cpp:
platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::TimerEvent):

platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):

platform/network/PingHandle.h:
platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::add):
(WebCore::ResourceHandleManager::cancel):

platform/network/mac/NetworkStateNotifierMac.cpp:
platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::sendPendingRequest):

rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::restartTimer):

rendering/RenderLayerCompositor.cpp:
rendering/RenderProgress.cpp:

(WebCore::RenderProgress::RenderProgress):

rendering/RenderProgress.h:
rendering/RenderText.cpp:

(WebCore::SecureTextTimer::restart):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::animationRepeatIntervalForProgressBar):

rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsFadeOutDuration):

rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):

rendering/RenderThemeGtk.h:
rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::animationRepeatIntervalForProgressBar):

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):

replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::dispatchInputSoon):

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::startTimer):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setTimeWithoutMouseMovementBeforeHidingControls):

testing/InternalSettings.h:
testing/Internals.cpp:

(WebCore::Internals::setImageFrameDecodingDuration):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit:

Storage/StorageAreaSync.cpp:
Storage/StorageTracker.cpp:

(WebKit::StorageTracker::StorageTracker):

Storage/StorageTracker.h:

(WebKit::StorageTracker::storageDatabaseIdleInterval):
(WebKit::StorageTracker::setStorageDatabaseIdleInterval):

Source/WebKit/mac:

Plugins/WebNetscapePluginView.mm:

(PluginTimer::start):

Storage/WebStorageManager.mm:

(+[WebStorageManager setStorageDatabaseIdleInterval:]):

Source/WebKit/win:

Plugins/PluginMessageThrottlerWin.cpp:

(WebCore::PluginMessageThrottlerWin::appendMessage):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):

Plugins/PluginViewWin.cpp:

(WebCore::PluginView::invalidateRect):

WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::scheduleLayerFlush):

Source/WebKit2:

NetworkProcess/PingLoad.h:
NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::startTimeout):

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm:

(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
(IPC::Connection::terminateSoon):

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::setMinimumLifetime):

PluginProcess/PluginProcess.h:
Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess):

Shared/ChildProcess.h:

(WebKit::ChildProcess::setTerminationTimeout):

Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::startUpdateTimer):

Shared/Plugins/PluginProcessCreationParameters.h:
Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::initializeTimers):

Shared/WebProcessCreationParameters.h:
UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:

(API::SharedJSContext::ensureContext):

UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::shutDownProcess):

UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

UIProcess/Cocoa/ViewGestureController.cpp:

(WebKit::ViewGestureController::SnapshotRemovalTracker::startWatchdog):

UIProcess/Cocoa/ViewGestureController.h:
UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::start):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::didDraw):

UIProcess/Gamepad/UIGamepadProvider.cpp:
UIProcess/Plugins/PluginProcessProxy.cpp:
UIProcess/ProcessThrottler.cpp:
UIProcess/ResponsivenessTimer.cpp:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::DragGesture::begin):

UIProcess/mac/WebInspectorProxyMac.mm:
WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::exitAcceleratedCompositingModeNow):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

WebProcess/WebProcess.cpp:

Tools:

TestWebKitAPI/Tests/WTF/RunLoop.cpp:

(TestWebKitAPI::TEST):

WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

12:39 AM Changeset in webkit [215172] by magomez@igalia.com

6 edits in trunk

REGRESSION(r205841): [GTK] Test fast/images/animated-png.html is failing since r205841
https://bugs.webkit.org/show_bug.cgi?id=168425

Reviewed by Said Abou-Hallawa.

Source/WebCore:

There is a problem with animations that are blending their frames into the previous frame. Due to a change
in how pixel components are premultiplied (the result is now rounded up), the parameters to the blending
operation may vary in one unit, causing the result of the blending to be different from the expected result.
In order to fix this, a new parameter is added to indicate whether we want to use rounding up when
premultiplying or not, and ImageBackingStore uses that parameter to disable rounding up.

Adjusted the expectation for fast/images/animated-png.html, as it must pass now.

platform/graphics/Color.cpp:

(WebCore::premultipliedChannel):
(WebCore::makePremultipliedRGBA):

platform/graphics/Color.h:
platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue):

LayoutTests:

Adjusted expectation for fast/images/animated-png.html. It must pass now.

platform/gtk/TestExpectations:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed