Timeline



Jun 6, 2017:

11:49 PM Changeset in webkit [217875] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Use a dedicated node flag to identify a Document node
​https://bugs.webkit.org/show_bug.cgi?id=173037

Reviewed by Chris Dumez.

Use a Node flag to identify a Document node instead of checking this == document() which loads TreeScope.

  • dom/Document.h:

(WebCore::Node::isDocumentNode): Deleted.

  • dom/Node.h:

(WebCore::Node::isDocumentNode):

9:19 PM Changeset in webkit [217874] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win][x86-64] Some callee saved registers aren't preserved
​https://bugs.webkit.org/show_bug.cgi?id=171266

Patch by Fujii Hironori <Fujii Hironori> on 2017-06-06
Reviewed by Saam Barati.

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::calleeSaveRegisters): Added edi and esi for X86_64 Windows.

9:12 PM Changeset in webkit [217873] by mitz@apple.com
  • 4 edits in trunk/Source

Fixed building with the macOS 10.13 Apple Internal SDK when targeting macOS 10.12.

Source/WebCore:

  • platform/spi/cocoa/PassKitSPI.h:

Source/WebKit2:

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didAuthorizePayment:handler:]):
(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didSelectPaymentMethod:handler:]):
(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didSelectShippingMethod:handler:]):
(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewController:didSelectShippingContact:handler:]):

8:46 PM Changeset in webkit [217872] by Chris Dumez
  • 5 edits in trunk/Source

Unreviewed, rolling out r214974.

Causes some tabs to start using a huge amount of CPU after 8
minutes in the background

Reverted changeset:

"Make inactive web processes behave as though under memory
pressure."
​https://bugs.webkit.org/show_bug.cgi?id=170042
​http://trac.webkit.org/changeset/214974

8:25 PM Changeset in webkit [217871] by Brent Fulgham
  • 7 edits in trunk/Source/WebKit2

[WK2][Cocoa] Allow network process to bind addresses without webrtc extension
​https://bugs.webkit.org/show_bug.cgi?id=173032
<rdar://problem/32597426>

Reviewed by Youenn Fablet.

Remove the unnecessary WebRTC sandbox extension handle and conditional sandbox rules, since we've
decided that all WebKit clients should be able to use the WebRTC protocol.

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode): Remove unused sandbox extension from serialization.
(WebKit::NetworkProcessCreationParameters::decode): Ditto.

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): We no longer send the sandbox extension,
so don't attempt to consume it.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Remove check for 'com.apple.webkit.webrtc'

extension. Make rules conditional on building with WEB_RTC feature enabled.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Remove check for 'com.apple.webkit.webrtc'
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess): Do not create unnecessary sandbox extension
handle.

7:17 PM Changeset in webkit [217870] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Crash trying to drag the entire text of a long book out of Mail compose view
​https://bugs.webkit.org/show_bug.cgi?id=173042
<rdar://problem/32382059>

Reviewed by Simon Fraser.

Source/WebCore:

Creating a TextIndicator that is hundreds of thousands of pixels tall
is not a good idea. We introduced TextIndicatorOptionDoNotClipToVisibleRect
so that (for example) an image that overhangs the edge of the page would
contain the entire image, instead of just the visible fragment.
Instead, rename this option to ExpandClipBeyondVisibleRect, and make it
not unclip *entirely*, but expand the clip significantly (50% in each direction)
beyond the bounds of the current visible rect. Also, make use of exposed
area information for this clipping; otherwise, clients with very large views
inside scrollable areas (like Mail) would still try to create large TextIndicators.

  • page/TextIndicator.cpp:

(WebCore::initializeIndicator):

  • page/TextIndicator.h:

Source/WebKit2:

  • WebProcess/WebPage/ios/FindControllerIOS.mm:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDataInteraction):
Adapt to the new name.

5:28 PM Changeset in webkit [217869] by mark.lam@apple.com
  • 8 edits
    1 add in trunk

Contiguous storage butterfly length should not exceed MAX_STORAGE_VECTOR_LENGTH.
​https://bugs.webkit.org/show_bug.cgi?id=173035
<rdar://problem/32554593>

Reviewed by Geoffrey Garen and Filip Pizlo.

JSTests:

  • stress/regress-173035.js: Added.

Source/JavaScriptCore:

Also added and fixed up some assertions.

  • runtime/ArrayConventions.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::setLength):

  • runtime/JSObject.cpp:

(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::reallocateAndShrinkButterfly):

  • runtime/JSObject.h:

(JSC::JSObject::ensureLength):

  • runtime/RegExpObject.cpp:

(JSC::collectMatches):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncSplitFast):

4:45 PM Changeset in webkit [217868] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked workers/bomb.html as flaky on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=167757

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
4:31 PM Changeset in webkit [217867] by Chris Dumez
  • 8 edits
    1 add in trunk

RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
​https://bugs.webkit.org/show_bug.cgi?id=173033
<rdar://problem/32591099>

Reviewed by Simon Fraser.

Source/WebCore:

History::scrollRestoration() was returning a bad value because HistoryItem::m_shouldRestoreScrollPosition
was initialized from FrameState::shouldRestoreScrollPosition member, which was not initialized when
restored from the legacy session restore API.

Tests: WebKit2.RestoreSessionStateContainingScrollRestoration* API tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationImplementationContent):
Drop the RELEASE_ASSERT that was added to debug this and use the regular debug ASSERT.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::setShouldRestoreScrollPosition):
Make sure we notify that the HistoryItem has changed when setShouldRestoreScrollPosition()
is called.

Source/WebKit2:

  • Shared/SessionState.h:

Make sure FrameState::shouldRestoreScrollPosition and other struct members are always
intialized.

  • UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::encodeFrameStateNode):
(WebKit::decodeBackForwardTreeNode):
Make sure FrameState::shouldRestoreScrollPosition is properly encoded / decoded.

Tools:

Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
(TestWebKitAPI::TEST):

4:06 PM Changeset in webkit [217866] by sbarati@apple.com
  • 3 edits
    1 add in trunk

Make sure we restore SP when doing calls that could be to JS
​https://bugs.webkit.org/show_bug.cgi?id=172946
<rdar://problem/32579026>

Reviewed by JF Bastien.

JSTests:

  • wasm/function-tests/many-args-tail-call-sp-restored.js: Added.

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.f1):
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.end):
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.f2):
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.let.instance.new.WebAssembly.Instance.new.WebAssembly.Module.builder.WebAssembly):

Source/JavaScriptCore:

I was worried that there was a bug where we'd call JS, JS would tail call,
and we'd end up with a bogus SP. However, this bug does not exist since wasm
always calls to JS through a stub, and the stub treats SP as a callee save.

I wrote a test for this, and also made a note that this is the needed ABI.

  • wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToJs):

4:04 PM Changeset in webkit [217865] by aestes@apple.com
  • 4 edits
    1 add in trunk

REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
​https://bugs.webkit.org/show_bug.cgi?id=172849
<rdar://problem/32567454>

Reviewed by Darin Adler.

Source/WebKit2:

This is the Mac equivalent of what was fixed in r208295. This time we use -[NSURL path] to
construct a WTF::String instead of calling String::fromUTF8() on -[NSURL fileSystemRepresentation].

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::runOpenPanel):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.

(-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):

3:59 PM WebKitGTK/2.16.x edited by clopez@igalia.com
(diff)
3:38 PM Changeset in webkit [217864] by Darin Adler
  • 9 edits in trunk

Update to slightly stricter rules for custom element names from more recent standard draft
​https://bugs.webkit.org/show_bug.cgi?id=173019

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/interfaces-expected.txt: Expect more PASS.

Source/WebCore:

  • bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::validateCustomElementNameAndThrowIfNeeded): Add more error strings for various error cases.

  • dom/Document.cpp:

(WebCore::isPotentialCustomElementNameCharacter): Added. Implements the PCENChar production
from the standard by listing all the ranges exactly as they appear in the standard.
(WebCore::Document::validateCustomElementName): Added a check that the first character is
a lowercase ASCII letter. Added a check that all characters are potential custom element
name characters.

  • dom/Document.h: Update the CustomElementNameValidationStatus with new values for

the various new error cases. Not sure that validateCustomElementName really belongs
in the Document class in the first place. Also seems that the error strings could be
in validateCustomElementName rather than in a separate bindings function, obviating
the need for the enum.

LayoutTests:

  • platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt: Expect more PASS.
  • platform/ios/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt: Ditto.
3:36 PM Changeset in webkit [217863] by yoav@yoav.ws
  • 33 edits in trunk

[preload] Conditional support for media preloading and align media as values.
​https://bugs.webkit.org/show_bug.cgi?id=172501

Reviewed by Dean Jackson.

Source/WebCore:

As discussed at ​https://bugs.webkit.org/show_bug.cgi?id=171720#c11 media preloading may not work
since the backend may not reuse such resources properly.
This patch makes support for media preloading conditional on a setting, in order to avoid double downloads in these cases.
It also aligns the media as values to the spec, and splitting them into "video" and "audio".

No new tests but related tests were modified to remove media preloading tests as the setting is off by default.

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::resourceTypeFromAsAttribute): Make handling of MediaResource conditional on setting. Align as values to spec.
(WebCore::createLinkPreloadResourceClient): Make handling of MediaResource conditional on setting.
(WebCore::LinkLoader::isSupportedType): Make handling of MediaResource conditional on setting.

  • page/RuntimeEnabledFeatures.h: Added a media preloading preference.

(WebCore::RuntimeEnabledFeatures::setMediaPreloadingEnabled):
(WebCore::RuntimeEnabledFeatures::mediaPreloadingEnabled):

  • page/Settings.in: Added a media preloading preference.

Source/WebKit:

Add media preloading preference and hook it up to runtime enabled features.

  • mac/WebView/WebPreferenceKeysPrivate.h: Added a media preloading preference.
  • mac/WebView/WebPreferences.mm:

(WebKit::WebPreferences::setMediaPreloadingEnabled):
(WebKit::WebPreferences::mediaPreloadingEnabled):

  • mac/WebView/WebPreferencesPrivate.h:

(WebKit::WebPreferences::setMediaPreloadingEnabled):
(WebKit::WebPreferences::mediaPreloadingEnabled):

  • mac/WebView/WebView.mm: Set runtime enabled feature based on preference.
  • win/Interfaces/IWebPreferencesPrivate.idl: define mediaPreloadEnabled and setMediaPreloadingEnabled
  • win/WebPreferences.cpp: Initialize media preloading as false and define setter and getter.

(WebKit::WebPreferences::setMediaPreloadingEnabled):
(WebKit::WebPreferences::mediaPreloadingEnabled):

  • win/WebPreferences.h:
  • win/WebPreferenceKeysPrivate.h:
  • win/WebView.cpp: Set runtime enabled feature based on preference.

Source/WebKit2:

Add media preloading preference and hook it up to runtime enabled features.

  • Shared/WebPreferencesDefinitions.h: Added a macro defining media preloading preference.
  • UIProcess/API/C/WKPreferences.cpp:

(WebKit2::WKPreferences::WKPreferencesSetMediaPreloadingEnabled):
(WebKit2::WKPreferences::WKPreferencesGetMediaPreloadingEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: Set runtime enabled feature based on preference.

Tools:

Turn on media preloading preference for tests.

  • DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
  • DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
  • WebKitTestRunner/TestController.cpp: Turn on media preloading preference.

LayoutTests:

Tests checking media resources preloading support were removed.

  • http/tests/preload/download_resources.html: Replaced "media" with "video".
  • http/tests/preload/download_resources_from_header_iframe-expected.txt: Changed expectation due to added "audio" test.
  • http/tests/preload/onload_event.html: Replaced "media" with "video".
  • http/tests/preload/preloadscanner_download_resources.html: Replaced "media" with "video".
  • http/tests/preload/resources/download_resources_from_header.php: Replaced "media" with "video" and "audio".
  • http/tests/preload/resources/nph-invalid_resources_from_header.pl: Replaced "media" with "video".
  • http/tests/preload/single_download_preload.html: Replaced "media" with "video" and "audio".
  • http/tests/preload/single_download_preload_headers.php: Replaced "media" with "video" and "audio".
  • http/tests/preload/single_download_preload_headers_charset.php: Replaced "media" with "video" and "audio".
3:29 PM Changeset in webkit [217862] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[WebCore] Enable REQUEST_ANIMATION_FRAME_TIMER for all ports
​https://bugs.webkit.org/show_bug.cgi?id=172780

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-06-06
Reviewed by Alex Christensen.

Source/WebCore:

No new tests. No change in behavior.

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::addThrottlingReason):
(WebCore::ScriptedAnimationController::removeThrottlingReason):
(WebCore::ScriptedAnimationController::isThrottled):
(WebCore::ScriptedAnimationController::interval):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::displayRefreshFired):

  • dom/ScriptedAnimationController.h:
  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::scheduleAnimation): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/Curl.cmake: Added.
  • platform/ScrollAnimationSmooth.cpp:

(WebCore::ScrollAnimationSmooth::ScrollAnimationSmooth):
(WebCore::ScrollAnimationSmooth::stop):
(WebCore::ScrollAnimationSmooth::animationTimerFired):
(WebCore::ScrollAnimationSmooth::startNextTimer):
(WebCore::ScrollAnimationSmooth::animationTimerActive):
(WebCore::ScrollAnimationSmooth::serviceAnimation): Deleted.

  • platform/ScrollAnimationSmooth.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scheduleAnimation): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::syncDisplayState):

Source/WTF:

  • wtf/Platform.h:
3:20 PM Changeset in webkit [217861] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

OMG tier up checks should be a patchpoint
​https://bugs.webkit.org/show_bug.cgi?id=172944

Reviewed by Saam Barati.

Tier up checks in BBQ should be done as a patchpoint rather than individual B3 opcodes.
In order to reduce code generated out of line in each function. We generate a single stub
that pushes all the callee-saves. This looks like a 5-10% compile time speedup.

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::emitTierUpCheck):
(JSC::Wasm::B3IRGenerator::addLoop):

  • wasm/WasmThunks.cpp:

(JSC::Wasm::triggerOMGTierUpThunkGenerator):

  • wasm/WasmThunks.h:
3:09 PM Changeset in webkit [217860] by Darin Adler
  • 18 edits in trunk/Source

Cut down use of WTF_ARRAY_LENGTH
​https://bugs.webkit.org/show_bug.cgi?id=172997

Reviewed by Chris Dumez.

Source/JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::singleEscape): Use WTF_ARRAY_LENGTH instead of ARRAY_SIZE.

  • runtime/NumberPrototype.cpp:

(JSC::toStringWithRadix): Use std::end instead of WTF_ARRAY_LENGTH.

Source/WebCore:

  • contentextensions/NFAToDFA.cpp: Remove unused SetTransitions class.
  • dom/Document.cpp:

(WebCore::Document::~Document): Use modern for loop instead of WTF_ARRAY_LENGTH.

  • dom/make_names.pl:

(printDefinitions): Ditto.
(printFactoryCppFile): Ditto.
(printWrapperFactoryCppFile): Ditto.

  • platform/URL.cpp:

(WebCore::portAllowed): Use std::is_sorted, std::begin, and std::end
in sort assertion to greatly streamline it and eliminate use of WTF_ARRAY_LENGTH.
Also allow the sort assertion to run every time; slightly optimizing debug builds
was not worth having the code be messy.

  • platform/URLParser.cpp:

(WebCore::URLParser::appendNumberToASCIIBuffer): Use std::end instead of
WTF_ARRAY_LENGTH.

  • platform/graphics/FontCascade.cpp: Make fontFamiliesWithInvalidCharWidth be

a constant array rather than a non-constant array to constant strings.
(WebCore::FontCascade::hasValidAverageCharWidth): Streamline the hash table
initialization to avoid heap allocation and use a modern for loop instead of
WTF_ARRAY_LENGTH.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::disableComponentsOnce): Use a modern for loop instead of WTF_ARRAY_LENGTH.

  • platform/network/CacheValidation.cpp:

(WebCore::shouldUpdateHeaderAfterRevalidation): Ditto. Also use the
startsWithIgnoringASCIICase function rather than the version that folds
arbitrary Unicode case.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::pruneBlacklistedCodecs): Use modern for loops to make the code considerably
easier to read and avoid WTF_ARRAY_LENGTH.

  • platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::monthLabels): Use modern for loop instead of WTF_ARRAY_LENGTH.
(WebCore::LocaleMac::shortMonthLabels): Ditto.

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::combineText): Ditto.

Source/WTF:

  • wtf/DateMath.cpp:

(WTF::equalLettersIgnoringASCIICase): Added helper function template.
(WTF::parseDateFromNullTerminatedCharacters): Use a modern for loop instead of
WTF_ARRAY_LENGTH. Use startsWithLettersIgnoringASCIICase and
equalLettersIgnoringASCIICase instead of strncasecmp.

  • wtf/text/IntegerToStringConversion.h:

(WTF::numberToStringImpl): Use std::end instead of WTF_ARRAY_LENGTH.
(WTF::writeNumberToBufferImpl): Ditto.

3:04 PM Changeset in webkit [217859] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Allow FileReader to open files multiple times

If multiple file readers open files they are prevented by default due to
Windows' file locking.

Allow FileReader to open multiple files for reading at the same time on wincairo
​https://bugs.webkit.org/show_bug.cgi?id=172632

Patch by Isaac Devine <​isaac@devinesystems.co.nz> on 2017-06-06
Reviewed by Darin Adler.

  • platform/win/FileSystemWin.cpp:

(WebCore::openFile): Use the appropriate sharing options to allow multiple opens

2:46 PM Changeset in webkit [217858] by Beth Dakin
  • 18 edits in trunk/Source

Netflix seeking quirk should also apply to Now Playing, and should always use the
livestream UI
​https://bugs.webkit.org/show_bug.cgi?id=173030
-and corresponding-
rdar://problem/32228660

Reviewed by Darin Adler.

Source/WebCore:

This patch rolls out much of ​https://trac.webkit.org/changeset/217791/webkit in
favor of an approach that can be used to apply the quirk to Now Playing in
addition to Touch Bar. This patch also changes the UI in both Touch Bar and Now
Playing to match live stream UI, which means there is no playhead. This hopefully
makes it less confusing that taps on the timeline will have no effect.

supportsSeeking() should return false for Netflix. That function needs to be
public now.

  • html/HTMLMediaElement.cpp:

(WebCore::needsSeekingSupportQuirk):
(WebCore::HTMLMediaElement::supportsSeeking):

  • html/HTMLMediaElement.h:

Here is where we get the desired result in Now Playing. Make sure the
currentSession supportsSeeking() before relying on the time and duration info for
the sake of Now Playing.

  • platform/audio/mac/MediaSessionManagerMac.mm:

(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):

We can roll out allowsTouchBarScrubbing() and rely on supportsSeeking().

  • platform/cocoa/WebPlaybackSessionModel.h:

(WebCore::WebPlaybackSessionModelClient::mutedChanged):
(WebCore::WebPlaybackSessionModelClient::allowsTouchBarScrubbingChanged): Deleted.

  • platform/cocoa/WebPlaybackSessionModelMediaElement.h:
  • platform/cocoa/WebPlaybackSessionModelMediaElement.mm:

(WebCore::WebPlaybackSessionModelMediaElement::updateForEventName):

And here is where we get the desired result for Touch Bar. Make sure the the media
element supportsSeeking() before relying on the duration.
(WebCore::WebPlaybackSessionModelMediaElement::duration):

We can roll out allowsTouchBarScrubbing() and rely on supportsSeeking().
(WebCore::WebPlaybackSessionModelMediaElement::allowsTouchBarScrubbing): Deleted.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:
  • platform/mac/WebPlaybackControlsManager.h:

Currently the Touch Bar live stream UI lets you seek, which results in broken
behavior on real live streams and on Netflix. Prevent that by preventing scrubbing
for NaN and infinite durations.

  • platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager canBeginTouchBarScrubbing]):

We can roll out allowsTouchBarScrubbing() and rely on supportsSeeking().

  • platform/mac/WebPlaybackSessionInterfaceMac.h:
  • platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::setPlayBackControlsManager):
(WebCore::WebPlaybackSessionInterfaceMac::allowsTouchBarScrubbingChanged): Deleted.

Source/WebKit2:

See WebCore ChangeLog for more details. We can roll out allowsTouchBarScrubbing()
and rely on supportsSeeking().

  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:
  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.messages.in:
  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm:

(WebKit::WebPlaybackSessionModelContext::setAllowsTouchBarScrubbing): Deleted.
(WebKit::WebPlaybackSessionManagerProxy::setAllowsTouchBarScrubbing): Deleted.

  • WebProcess/cocoa/WebPlaybackSessionManager.h:
  • WebProcess/cocoa/WebPlaybackSessionManager.mm:

(WebKit::WebPlaybackSessionInterfaceContext::allowsTouchBarScrubbingChanged): Deleted.
(WebKit::WebPlaybackSessionManager::allowsTouchBarScrubbingChanged): Deleted.

2:27 PM Changeset in webkit [217857] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/hkdf.worker.html as flaky on mac.
​https://bugs.webkit.org/show_bug.cgi?id=170907

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
2:02 PM Changeset in webkit [217856] by Jonathan Bedard
  • 6 edits in trunk/Tools

webkitpy: Return correct process names from SimulatorProcess
​https://bugs.webkit.org/show_bug.cgi?id=172940

Reviewed by Aakash Jain.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
(DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
(DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.

  • Scripts/webkitpy/port/driver.py:

(Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
_server_process.name() will not return the correct process name for iOS.
(Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
(Driver._read_block): Ditto.

  • Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
process_name() instead of name().

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._start): Use process_name() instead of name().
(ServerProcess.stop): Ditto.
(ServerProcess.name): Deleted.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.process_name): Check the provided bundle for the process name.

1:39 PM Changeset in webkit [217855] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

test-webkitpy: stop forking unsafely from within a spawned process
​https://bugs.webkit.org/show_bug.cgi?id=172774

Patch by Dean Johnson <​dean_johnson@apple.com> on 2017-06-06
Reviewed by Darin Adler.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(Builder.init): We don't use mechanize.Browser() as part of testing, so only initialize it when
it's going to be used.
(Builder.force_build):

1:28 PM Changeset in webkit [217854] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening.

  • platform/gtk/TestExpectations: Clean up the Web Crypto API test expectations.

Unskip the crypto/subtle/, crypto/workers/subtle/ and
imported/w3c/web-platform-tests/WebCryptoAPI/ directories and add expectations
that skip the remaining failing layout tests, instead of skipping those
directories and maintaining expectations for the passing tests.

1:25 PM Changeset in webkit [217853] by Jonathan Bedard
  • 17 edits in trunk/Tools

webkitpy: Process crash-logs for iOS devices
​https://bugs.webkit.org/show_bug.cgi?id=171976
<rdar://problem/32134551>

Reviewed by David Kilzer.

When running layout tests on an iOS device, crash logs should be processed.
Implement crash log searching and parsing for iOS devices.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs): Moved process regular expression for Darwin to class variable.
(CrashLogs.init): Accept optional list of crash logs to ignore.
(CrashLogs.find_newest_log): Add iOS as a potential platform.
(CrashLogs.find_all_logs): Ditto.
(CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
Do not assume that a Darwin crash log starts with the process.
(CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
shared code for parsing Darwin crash logs.
(CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
object so that crash logs already on the system before testing are not parsed.
(CrashLogs._find_newest_log_win.is_crash_log): Ditto.
(CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
(CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(make_mock_crash_report_darwin): Crash logs may not have their process on the first line.

  • Scripts/webkitpy/common/system/systemhost.py:

(SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
systems is just the crashlog, use this behavior by default.

  • Scripts/webkitpy/common/system/systemhost_mock.py:

(MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
systems is just the crashlog, use this behavior by default.

  • Scripts/webkitpy/port/apple.py:

(ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
(ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
the system before testing begins

  • Scripts/webkitpy/port/base.py:

(Port._get_crash_log): Pass optional target host when getting crash logs.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
CrashLogs object.
(DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
logs to be skipped to CrashLogs object.

  • Scripts/webkitpy/port/darwin_testcase.py:

(DarwinTest.test_get_crash_log): Removed unused local function.
(DarwinTest.test_get_crash_log.fake_time_cb): Deleted.

  • Scripts/webkitpy/port/device.py:

(Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
name, call it. Otherwise, assume the default behavior and read the file at the provided path.

  • Scripts/webkitpy/port/driver.py:

(Driver._get_crash_log): Pass optional target host when getting crash logs.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort._get_crash_log): Pass optional target host when getting crash logs.

  • Scripts/webkitpy/port/ios.py: Ditto.

(IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
to be skipped for each host.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
(IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
(IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
host is specified. Else, search all connected devices for the specified crash-log.
(IOSDevicePort.look_for_new_crash_logs): Deleted.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
(IOSDeviceTest.test_get_crash_log): Ditto.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.process_name): Check the provided bundle for the process name.

  • Scripts/webkitpy/port/win.py:

(WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
logs to be skipped to CrashLogs object.

  • Scripts/webkitpy/port/wpe.py:

(WPEPort._get_crash_log): Pass optional target host when getting crash logs.

1:10 PM Changeset in webkit [217852] by Konstantin Tokarev
  • 7 edits in trunk/Source

Add missing <functional> includes
​https://bugs.webkit.org/show_bug.cgi?id=173017

Patch by Thiago Macieira <​thiago.macieira@intel.com>
Reviewed by Yusuke Suzuki.

This patch fixes compilation with GCC 7.

Source/JavaScriptCore:

  • inspector/InspectorBackendDispatcher.h:

Source/WebCore:

No new tests needed.

  • css/CSSValue.h:
  • css/StyleSheetContents.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h:
1:06 PM Changeset in webkit [217851] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move storage/websql/alter-to-info-table.html failure expectation.
​https://bugs.webkit.org/show_bug.cgi?id=156718

Unreviewed test gardening

storage/websql/alter-to-info-table.html fails on iOS-simulator,
but passes on device.

  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
12:52 PM Changeset in webkit [217850] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/fullscreen-api-enabled-media-with-presentation-mode.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=172998

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:51 PM Changeset in webkit [217849] by Konstantin Tokarev
  • 2 edits in trunk/Source/WebCore

Fix compilation with !ENABLE(SVG_FONTS)
​https://bugs.webkit.org/show_bug.cgi?id=172731

Reviewed by Darin Adler.

No new tests needed.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::load):

12:35 PM Changeset in webkit [217848] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Safari doesn't load newest The Order of the Stick comic.
​https://bugs.webkit.org/show_bug.cgi?id=172949
<rdar://problem/32389730>

Reviewed by Antti Koivisto.

Source/WebCore:

As part of the table layout, RenderTableSection::layoutRows calls the RenderTableCell's layout() directly
(skipping the RenderTableRow parent). If during this call the RenderTableCell (or any of its descendant) marks the ancestor
chain dirty, this dirty flag on the RenderTableRows will never be cleared and we'll end up early returning from RenderTableSection::paint.
For certain type of float objects, we need to invalidate the line layout path during layout (and we mark the ancestors dirty).
This patch takes a conservative approach and marks the ancestors dirty only when the renderer is not dirty yet, but
as part of webkit.org/b/172947 we should revisit and validate whether the setNeedsLayout() is required at all.

Test: fast/table/floating-table-sibling-is-invisible.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::invalidateLineLayoutPath):

LayoutTests:

  • fast/table/floating-table-sibling-is-invisible-expected.html: Added.
  • fast/table/floating-table-sibling-is-invisible.html: Added.
11:45 AM Changeset in webkit [217847] by ddkilzer@apple.com
  • 6 edits in trunk/Tools

Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
<​https://webkit.org/b/172804>

Reviewed by Darin Adler.

WTF_ATTRIBUTE_PRINTF() only works outside the current
compilation unit if it's on the declaration, not the
implementation, of a function or class method.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
  • DumpRenderTree/TestNetscapePlugIn/main.cpp:
  • Remove redundant CRASH() macro definition. Use the one from <wtf/Assertions.h> instead.
11:35 AM Changeset in webkit [217846] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix 32-bit build.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_unreachable):

11:28 AM Changeset in webkit [217845] by jer.noble@apple.com
  • 7 edits in trunk/Source

[Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
​https://bugs.webkit.org/show_bug.cgi?id=173008

Reviewed by Eric Carlson.

Source/WebKit/mac:

Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences mediaUserGestureInheritsFromDocument]):
(-[WebPreferences setMediaUserGestureInheritsFromDocument:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

11:27 AM Changeset in webkit [217844] by commit-queue@webkit.org
  • 9 edits in trunk

[css-conditional] The one-string version of CSS.supports should be wrapped in implied parentheses.
​https://bugs.webkit.org/show_bug.cgi?id=172906

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-06-06
Reviewed by Darin Adler.

Source/WebCore:

From ​https://drafts.csswg.org/css-conditional/#the-css-interface:

When invoked with a single conditionText argument, it must return
true if conditionText, when either parsed and evaluated as a
supports_condition or parsed as a declaration, wrapped in implied
parentheses, and evaluated as a supports_condition, would return
true.

Note the "wrapped in implied parentheses" bit.

Gecko is fixing it in ​https://bugzil.la/1338486, and Blink in
​https://crbug.com/729403.

Tests: css3/supports-dom-api.html

imported/w3c/web-platform-tests/cssom/CSS.html

  • css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseSupportsCondition):

  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeSupportsRule):

  • css/parser/CSSSupportsParser.cpp:

(WebCore::CSSSupportsParser::supportsCondition):

  • css/parser/CSSSupportsParser.h:

LayoutTests:

  • css3/supports-dom-api-expected.txt:
  • css3/supports-dom-api.html: Added test
11:15 AM Changeset in webkit [217843] by Joseph Pecoraro
  • 17 edits
    1 delete in trunk

Unreviewed rollout r217807. Caused a test to crash.

JSTests:

  • heapProfiler/class-names.js: Removed.
  • heapProfiler/driver/driver.js:

(CheapHeapSnapshotNode):
(CheapHeapSnapshot):
(createCheapHeapSnapshot):
(HeapSnapshot):
(createHeapSnapshot):

  • typeProfiler/inheritance.js:

(wrapper.A):
(wrapper.B):
(wrapper.C):
(wrapper):

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::buildSnapshot):
(JSC::HeapSnapshotBuilder::json):
(): Deleted.

  • heap/HeapSnapshotBuilder.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):

Source/WebInspectorUI:

  • UserInterface/Proxies/HeapSnapshotNodeProxy.js:

(WebInspector.HeapSnapshotNodeProxy):
(WebInspector.HeapSnapshotNodeProxy.deserialize):

  • UserInterface/Views/HeapSnapshotClassDataGridNode.js:

(WebInspector.HeapSnapshotClassDataGridNode.prototype.createCellContent):

  • UserInterface/Views/HeapSnapshotClusterContentView.js:

(WebInspector.HeapSnapshotClusterContentView.iconStyleClassNameForClassName):

  • UserInterface/Views/HeapSnapshotDataGridTree.js:

(WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):

  • UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:

(WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler.appendPathRow):

  • UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:

(HeapSnapshot):
(HeapSnapshot.updateCategoriesAndMetadata):
(HeapSnapshot.prototype.serializeNode):
(HeapSnapshot.prototype._gcRootPathes.visitNode):
(HeapSnapshot.prototype._gcRootPathes):

LayoutTests:

  • inspector/unit-tests/heap-snapshot-expected.txt:
  • inspector/unit-tests/heap-snapshot.html:
11:11 AM Changeset in webkit [217842] by Joseph Pecoraro
  • 2 edits in trunk/Websites/webkit.org

Add a WebGPU test to the experimental features test page
​https://bugs.webkit.org/show_bug.cgi?id=172953

Reviewed by Darin Adler.

  • experimental-features.html:
11:11 AM Changeset in webkit [217841] by Joseph Pecoraro
  • 10 edits in trunk

Move Resource Timing / User Timing from experimental features into main preferences
​https://bugs.webkit.org/show_bug.cgi?id=172950

Reviewed by Darin Adler.

Source/WebCore:

  • features.json:

Graduate some features from In Development to Supported.

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:

Move Resource Timing and User Timing out of the Experimental Features section.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Move out no longer experimental features to the main list.

Websites/webkit.org:

  • experimental-features.html:

Remove no longer experimental features.

11:08 AM Changeset in webkit [217840] by fpizlo@apple.com
  • 19 edits
    1 add in trunk

index out of bound in bytecodebasicblock
​https://bugs.webkit.org/show_bug.cgi?id=172963

Reviewed by Saam Barati and Mark Lam.
JSTests:

  • stress/dfg-call-class-constructor.js: Added.

(Foo):
(i.catch):

Source/JavaScriptCore:


We were leaving an unterminated basic block when generating CodeForCall for a class
constructor. This was mostly benign since that unterminated block was not reachable, but it
does cause an ASSERT.

This fixes the issue by appending op_unreachable to that block. I added op_unreachable because
this really is the cleanest and most idiomatic way to solve this problem, so even though it
makes the change bigger it's probabably worth it.

  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/Opcode.h:

(JSC::isTerminal):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::emitUnreachable):

  • bytecompiler/BytecodeGenerator.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileUnreachable):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_unreachable):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

Source/WTF:

  • wtf/Assertions.h:

(UNREACHABLE_FOR_PLATFORM):

10:41 AM Changeset in webkit [217839] by graouts@webkit.org
  • 5 edits in trunk/LayoutTests

Rebaseline and enable media/modern-media-controls/audio
​https://bugs.webkit.org/show_bug.cgi?id=172996
<rdar://problem/32590725>

Reviewed by Eric Carlson.

The new controls design switches the AirPlay and mute button order around.

  • media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
  • media/modern-media-controls/audio/audio-controls-buttons.html:
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
10:13 AM Changeset in webkit [217838] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GTK][Wayland] Do not pass value of $DISPLAY to wl_display_connect()
​https://bugs.webkit.org/show_bug.cgi?id=172993

Reviewed by Žan Doberšek.

No new tests needed.

  • platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::create): Instead of using the "DISPLAY" environment variable (meant for X11),
pass a null pointer to "wl_display_connect()". This function checks the value of the "WAYLAND_DISPLAY" environment
variable itself and therefore we do not need to pass it ourselves.

9:53 AM Changeset in webkit [217837] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Add an option to disable getUserMedia prompt in case of mock capture sources
​https://bugs.webkit.org/show_bug.cgi?id=172981
<rdar://problem/32580325>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-06-06
Reviewed by Eric Carlson.

Source/WebKit/mac:

Defining the option, getter and setter.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences mockCaptureDevicesPromptEnabled]):
(-[WebPreferences setMockCaptureDevicesPromptEnabled:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Adding mockCaptureDevicesPromptEnabled option.
Allowing any getUserMedia request if mock is on and prompt is off.

Renaming UserMediaProcessManager::willEnableMediaStreamInPage to muteCaptureMediaStreamsExceptIn.
This eases reading the code.
Making sure that a page for which a new getUserMedia MediaStream will be created is capture-unmuted.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::muteCaptureMediaStreamsExceptIn):
(WebKit::UserMediaProcessManager::willCreateMediaStream):

  • UIProcess/UserMediaProcessManager.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMuted):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::activateMediaStreamCaptureInPage):

9:29 AM Changeset in webkit [217836] by graouts@webkit.org
  • 5 edits in trunk

Rebaseline and enable media/modern-media-controls/airplay-support
​https://bugs.webkit.org/show_bug.cgi?id=172980
Source/WebCore:

Reviewed by Eric Carlson.

Fixing a small issue in the modern media controls code which would yield
an error when manually creating a MediaController without a MediaControlsHost.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.get isAudio):

LayoutTests:

<rdar://problem/32589074>

Reviewed by Eric Carlson.

The test passes as-is on macOS, but needs to be skipped on iOS since we can't test AirPlay.

  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
9:27 AM Changeset in webkit [217835] by graouts@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline and enable media/modern-media-controls/airplay-placard
​https://bugs.webkit.org/show_bug.cgi?id=172977
<rdar://problem/32588681>

Reviewed by Eric Carlson.

These two tests work fine as-is, we just need to enable them.

  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
9:26 AM Changeset in webkit [217834] by graouts@webkit.org
  • 6 edits in trunk/LayoutTests

Rebaseline and enable media/modern-media-controls/airplay-button
​https://bugs.webkit.org/show_bug.cgi?id=172975
<rdar://problem/32588422>

Reviewed by Eric Carlson.

  • media/modern-media-controls/airplay-button/airplay-button-expected.txt:
  • media/modern-media-controls/airplay-button/airplay-button-on.html: Remove some unnecessary

code, the path to the icon directory is provided directly by media-controls-loader.js.

  • media/modern-media-controls/airplay-button/airplay-button.html: Remove the test for the "icon"

CSS class since buttons no longer carry this class. We also update the assumptions to use SVG
assets.

  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
9:16 AM Changeset in webkit [217833] by Ryan Haddad
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r217812.

This change caused test failures on arm64.

Reverted changeset:

"OMG tier up checks should be a patchpoint"
​https://bugs.webkit.org/show_bug.cgi?id=172944
​http://trac.webkit.org/changeset/217812

8:19 AM Changeset in webkit [217832] by Carlos Garcia Campos
  • 7 edits in trunk

[WPE] Enable remote inspector
​https://bugs.webkit.org/show_bug.cgi?id=172971

Reviewed by Žan Doberšek.

.:

Add private option for remote inspector enabled by default.

  • Source/cmake/OptionsWPE.cmake:

Source/JavaScriptCore:

We can just build the current glib remote inspector, without adding a frontend implementation and using a
WebKitGTK+ browser as frontend for now.

  • PlatformWPE.cmake: Add remote inspector files to compilation.
  • inspector/remote/glib/RemoteInspectorUtils.cpp:

(Inspector::backendCommands): Load the inspector resources library.

Source/WebKit2:

Initialize the remote inpector if needed.

  • UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::initializeRemoteInspectorServer):
(WebKit::WebProcessPool::platformInitialize):

8:16 AM Changeset in webkit [217831] by Carlos Garcia Campos
  • 5 edits in trunk/Source

[GLIB] Make remote inspector DBus protocol common to all glib based ports
​https://bugs.webkit.org/show_bug.cgi?id=172970

Reviewed by Žan Doberšek.

Source/JavaScriptCore:

We are currently using "webkitgtk" in the names of DBus interfaces and object paths inside an ifdef with the
idea that other ports could use their own names. However, the protocol is the same, so we could use the same
names and make all glib based ports compatible to each other. This way we could use the GTK+ MiniBrowser to
debug WPE, without having to implement the frontend part in WPE yet.

  • inspector/remote/glib/RemoteInspectorGlib.cpp: Use webkit instead of webkitgtk and reomve platform idfeds.
  • inspector/remote/glib/RemoteInspectorServer.cpp: Ditto.

Source/WebKit2:

Use webkit instead of webkitgtk and reomve platform idfeds.

  • UIProcess/glib/RemoteInspectorClient.cpp:
8:15 AM Changeset in webkit [217830] by Carlos Garcia Campos
  • 2 edits in trunk/Source/JavaScriptCore

[GTK] Web Process deadlock when closing the remote inspector frontend
​https://bugs.webkit.org/show_bug.cgi?id=172973

Reviewed by Žan Doberšek.

We are taking the remote inspector mutex twice. First close message is received, and receivedCloseMessage()
takes the mutex. Then RemoteConnectionToTarget::close() is called that, when connected, calls
PageDebuggable::disconnect() that ends up calling RemoteInspector::updateTarget() that also takes the remote
inspector mutex. We should release the mutex before calling RemoteConnectionToTarget::close().

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::receivedCloseMessage):

7:53 AM Changeset in webkit [217829] by Yusuke Suzuki
  • 2 edits in trunk/Source/bmalloc

struct does not accept initializer-form if member has initializers in GCC 4.9
​https://bugs.webkit.org/show_bug.cgi?id=172974

Reviewed by Carlos Garcia Campos.

struct cannot accept initializer-form constructor (like, ListNode<T> t { ... }) if
the member of the struct has a default initializer.
Here is a simple snippet.

template<typename T>
struct Pair {

T* prev { nullptr };
T* next { nullptr };

};

Pair<int> pair { nullptr, nullptr }; compile erorr in GCC 4.9.

Instead, we define a default constructor (to invoke default initializers) and a constructor
to accept the above initialization.

  • bmalloc/List.h:

(bmalloc::ListNode::ListNode):
(bmalloc::List::iterator::iterator):

7:46 AM Changeset in webkit [217828] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[WPE] Don't disable Web security preference by default
​https://bugs.webkit.org/show_bug.cgi?id=172964

Reviewed by Carlos Garcia Campos.

  • UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::View): Don't disable Web security by default.

7:39 AM Changeset in webkit [217827] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

Try to fix the GTK build.

Unreviewed.

  • bmalloc/List.h:

(bmalloc::List::List):

7:30 AM Changeset in webkit [217826] by graouts@webkit.org
  • 4 edits in trunk

Update modern media controls testing utilities
​https://bugs.webkit.org/show_bug.cgi?id=172976
<rdar://problem/32588432>

Reviewed by Eric Carlson.

Source/WebCore:

Stop logging an error when we're not able to load UI Strings since UI strings
are not defined in the majority of modern-media-controls tests as we load the
code directly from the modern-media-controls module and can't reach into the
English.lproj directory, nor is it necessary.

  • Modules/modern-media-controls/main.js:

(UIString):

LayoutTests:

Update the list of CSS files to load to match the current list of
existing CSS files in the modern-media-controls module.

  • media/modern-media-controls/resources/media-controls-loader.js:
4:46 AM Changeset in webkit [217825] by clopez@igalia.com
  • 1 edit
    1 add in trunk/Tools

[WPE] Add an install-dependencies script
​https://bugs.webkit.org/show_bug.cgi?id=172948

Reviewed by Žan Doberšek.

It is based on the gtk/install-dependencies script.
Includes support for Debian based distrubutions, Fedora and Arch.
It has been tested on a minimal Debian 9 chroot.

  • wpe/install-dependencies: Added.
2:01 AM Changeset in webkit [217824] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GStreamer] Use the same draw timer and mutex when AC disabled or building without OpenGL
​https://bugs.webkit.org/show_bug.cgi?id=172923

Reviewed by Michael Catanzaro.

We have two different paths to do the same. When building without OpenGL, the VideoRenderRequestScheduler has
its own timer and we need to add ifdefs to handle that. But when building with OpenGL we still support
non-accelerated rendering that does the same than the VideoRenderRequestScheduler timer, but using the media
player timer instead. We can simplify the code and remove more ifdefs by using the media player timer and mutex
in all cases for non-accelerated rendering.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(VideoRenderRequestScheduler::start):
(VideoRenderRequestScheduler::stop):
(VideoRenderRequestScheduler::requestRender):
(VideoRenderRequestScheduler::VideoRenderRequestScheduler): Deleted.
(VideoRenderRequestScheduler::render): Deleted.

1:10 AM Changeset in webkit [217823] by graouts@webkit.org
  • 60 edits
    4 copies
    2 moves
    31 adds
    94 deletes in trunk

Update media controls to match latest design specs
​https://bugs.webkit.org/show_bug.cgi?id=172932

Reviewed by Dean Jackson.

Source/WebCore:

The media controls specs have changed and we now implement them. The main controls bar now
appears to be floating, with a rounded corners and a margin around it. Some of the controls
it used to contain now may appear outside of it. Specifically, the fullscreen and
picture-in-picture buttons now are displayed in a dedicated controls bar in the top-left
corner and the mute button, on iOS (where we don't support changing the volume when inline),
is displayed in the top right corner.

Another small UI improvement is that we display an activity indicator when we are waiting
for data to initiate or resume playback instead of showing the elapsed time label. We also
make displaying the scrubber more important than displaying other controls, except for the
play/pause button, when width becomes scarce. Finally, we no longer use a speci layer type
for the controls bar backgrounds, we now use the same "backdrop-filter" and tint overlay
on both macOS and iOS.

Since this work had previously been done through WebKitAdditions, we remove the specific
build phase code that we added for this purpose and are now only ever looking for media
controls code in the WebCore source tree.

  • Modules/modern-media-controls/controls/activity-indicator.css: Added.

(.activity-indicator):
(.activity-indicator > div):
(.activity-indicator > .ne):
(.activity-indicator > .e):
(.activity-indicator > .se):
(.activity-indicator > .s):
(.activity-indicator > .sw):
(.activity-indicator > .w):
(.activity-indicator > .nw):
(@keyframes activity-indicator-pulse):
(to):

  • Modules/modern-media-controls/controls/airplay-button.js:
  • Modules/modern-media-controls/controls/auto-hide-controller.js: Added.

(AutoHideController):
(AutoHideController.prototype.get fadesWhileIdle):
(AutoHideController.prototype.set fadesWhileIdle):
(AutoHideController.prototype.handleEvent):
(AutoHideController.prototype.gestureRecognizerStateDidChange):
(AutoHideController.prototype.mediaControlsFadedStateDidChange):
(AutoHideController.prototype.mediaControlsBecameInvisible):
(AutoHideController.prototype._cancelNonEnforcedAutoHideTimer):
(AutoHideController.prototype._cancelAutoHideTimer):
(AutoHideController.prototype._resetAutoHideTimer):
(AutoHideController.prototype._autoHideTimerFired):

  • Modules/modern-media-controls/controls/background-click-delegate-notifier.js: Added.

(BackgroundClickDelegateNotifier):
(BackgroundClickDelegateNotifier.prototype.handleEvent):

  • Modules/modern-media-controls/controls/background-tint.css:

(.background-tint,):
(.background-tint > .blur):
(.background-tint > .tint):

  • Modules/modern-media-controls/controls/button.css:

(button):
(button > picture):
(button.skip-back > picture,):
(button.on > picture):
(button:active > picture):
(button.corner):
(button.center,):
(button.center):
(button.small-center):
(button.center > .background-tint,):
(button.center > picture,):
(button.center:active > picture,):

  • Modules/modern-media-controls/controls/button.js:

(Button.prototype.get iconName):
(Button.prototype.set iconName):
(Button.prototype.get on):
(Button.prototype.set on):
(Button.prototype.get style):
(Button.prototype.set style):
(Button.prototype.get scaleFactor):
(Button.prototype.set scaleFactor):
(Button.prototype.handleEvent):
(Button.prototype.commit):
(Button.prototype._loadImage):
(Button.prototype._imageSourceDidLoad):
(Button.prototype._updateImage):
(Button.prototype._updateImageMetrics):
(Button):

  • Modules/modern-media-controls/controls/buttons-container.css:

(.buttons-container):
(.ios .buttons-container button):

  • Modules/modern-media-controls/controls/buttons-container.js:
  • Modules/modern-media-controls/controls/controls-bar.css:

(.controls-bar):
(.controls-bar.faded): Deleted.

  • Modules/modern-media-controls/controls/controls-bar.js:

(ControlsBar.prototype.get children):
(ControlsBar.prototype.set children):
(ControlsBar.prototype.commitProperty):
(ControlsBar.prototype.get userInteractionEnabled): Deleted.
(ControlsBar.prototype.set userInteractionEnabled): Deleted.
(ControlsBar.prototype.get fadesWhileIdle): Deleted.
(ControlsBar.prototype.set fadesWhileIdle): Deleted.
(ControlsBar.prototype.get visible): Deleted.
(ControlsBar.prototype.set visible): Deleted.
(ControlsBar.prototype.get faded): Deleted.
(ControlsBar.prototype.set faded): Deleted.
(ControlsBar.prototype.handleEvent): Deleted.
(ControlsBar.prototype.gestureRecognizerStateDidChange): Deleted.
(ControlsBar.prototype._cancelNonEnforcedAutoHideTimer): Deleted.
(ControlsBar.prototype._cancelAutoHideTimer): Deleted.
(ControlsBar.prototype._resetAutoHideTimer): Deleted.
(ControlsBar.prototype._autoHideTimerFired): Deleted.

  • Modules/modern-media-controls/controls/fullscreen-button.js:
  • Modules/modern-media-controls/controls/icon-button.css: Removed.
  • Modules/modern-media-controls/controls/icon-button.js: Removed.
  • Modules/modern-media-controls/controls/icon-service.js:

(const.iconService.new.IconService.prototype.imageForIconAndLayoutTraits):
(const.iconService.new.IconService.prototype._fileNameAndPlatformForIconAndLayoutTraits):
(const.iconService.new.IconService):
(const.iconService.new.IconService.prototype.imageForIconNameAndLayoutTraits): Deleted.
(const.iconService.new.IconService.prototype._fileNameAndPlatformForIconNameAndLayoutTraits): Deleted.

  • Modules/modern-media-controls/controls/inline-layout-support.js: Removed.
  • Modules/modern-media-controls/controls/inline-media-controls.css: Added.

(.media-controls.inline > .controls-bar):
(.media-controls.inline > .controls-bar.top-left):
(.media-controls.inline.audio > .controls-bar):
(.media-controls.inline > .controls-bar > *):
(.media-controls.inline > button.mute):
(.media-controls.inline > button.play-pause.corner):
(.media-controls.inline.audio > button.play-pause.corner):
(.media-controls.inline > .controls-bar button):
(.media-controls.inline button.start.center > picture,):
(.media-controls.inline button.start.small-center > picture,):
(.media-controls.inline .time-control,):

  • Modules/modern-media-controls/controls/inline-media-controls.js: Added.

(InlineMediaControls):
(InlineMediaControls.prototype.set shouldUseAudioLayout):
(InlineMediaControls.prototype.set shouldUseSingleBarLayout):
(InlineMediaControls.prototype.get showsStartButton):
(InlineMediaControls.prototype.set showsStartButton):
(InlineMediaControls.prototype.showPlacard):
(InlineMediaControls.prototype.hidePlacard):
(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype.commitProperty):
(InlineMediaControls.prototype.get preferredMuteButtonStyle):
(InlineMediaControls.prototype._topLeftContainerButtons):
(InlineMediaControls.prototype._leftContainerButtons):
(InlineMediaControls.prototype._rightContainerButtons):
(InlineMediaControls.prototype._droppableButtons):

  • Modules/modern-media-controls/controls/ios-inline-media-controls.css: Removed.
  • Modules/modern-media-controls/controls/ios-inline-media-controls.js:

(IOSInlineMediaControls.prototype.get showsStartButton):
(IOSInlineMediaControls.prototype.set showsStartButton):
(IOSInlineMediaControls.prototype.gestureRecognizerStateDidChange):
(IOSInlineMediaControls.prototype._pinchGestureRecognizerStateDidChange):
(IOSInlineMediaControls.prototype._tapGestureRecognizerStateDidChange):
(IOSInlineMediaControls):
(IOSInlineMediaControls.prototype.layout): Deleted.
(IOSInlineMediaControls.prototype.layoutTraitsDidChange): Deleted.

  • Modules/modern-media-controls/controls/layout-item.js:
  • Modules/modern-media-controls/controls/layout-node.js:

(LayoutNode.prototype.commitProperty):

  • Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css: Removed.
  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen .buttons-container.left):
(.media-controls.mac.fullscreen .buttons-container.center):
(.media-controls.mac.fullscreen .time-control):
(.media-controls.mac.fullscreen > .controls-bar .status-label):
(.media-controls.mac.fullscreen > .controls-bar > .background-tint > div): Deleted.
(.media-controls.mac.fullscreen .volume.slider): Deleted.
(.media-controls.mac.fullscreen button.volume-down): Deleted.
(.media-controls.mac.fullscreen button.volume-up): Deleted.
(.media-controls.mac.fullscreen button.rewind): Deleted.
(.media-controls.mac.fullscreen button.play-pause): Deleted.
(.media-controls.mac.fullscreen button.forward): Deleted.
(.media-controls.mac.fullscreen .time-label): Deleted.
(.media-controls.mac.fullscreen .scrubber): Deleted.

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype.handleEvent):
(MacOSFullscreenMediaControls.prototype.layout):
(MacOSFullscreenMediaControls.prototype._handleMousedown):
(MacOSFullscreenMediaControls.prototype._handleMousemove):

  • Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline .volume-slider-container):
(.media-controls.mac.inline.audio .volume-slider-container):
(.media-controls.mac.inline .volume-slider-container > .background-tint):
(.media-controls.mac.inline .volume-slider-container > .background-tint > div):
(.media-controls.mac.inline .volume-slider-container > .slider):
(.media-controls.mac.inline > .controls-bar): Deleted.
(.media-controls.mac.inline > .controls-bar > *): Deleted.
(.media-controls.mac.inline > button.start > div): Deleted.
(.media-controls.mac.inline > .controls-bar button): Deleted.
(.media-controls.mac.inline button.play-pause): Deleted.
(.media-controls.mac.inline button.skip-back): Deleted.
(.media-controls.mac.inline .scrubber.slider): Deleted.
(.media-controls.mac.inline button.mute): Deleted.
(.media-controls.mac.inline button.airplay): Deleted.
(.media-controls.mac.inline button.pip): Deleted.
(.media-controls.mac.inline button.tracks): Deleted.
(.media-controls.mac.inline button.fullscreen): Deleted.
(.media-controls.mac.inline .time-label,): Deleted.
(.media-controls.mac.inline .volume.slider): Deleted.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.layout):
(MacOSInlineMediaControls.prototype.get preferredMuteButtonStyle):
(MacOSInlineMediaControls.prototype.handleEvent):
(MacOSInlineMediaControls.prototype.layoutTraitsDidChange): Deleted.

  • Modules/modern-media-controls/controls/macos-media-controls.js: Removed.
  • Modules/modern-media-controls/controls/media-controls.css:

(:host(audio)):
(*):
(:host(audio), *):
(.media-controls-container):
(.media-controls):
(.media-controls > *):
(.media-controls.shows-tracks-panel > .controls-bar,):
(.media-controls.faded > *:not(.placard)):
(.media-controls .time-label,):

  • Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.get visible):
(MediaControls.prototype.set visible):
(MediaControls.prototype.get faded):
(MediaControls.prototype.set faded):
(MediaControls.prototype.showTracksPanel):
(MediaControls.prototype.hideTracksPanel):
(MediaControls.prototype.isPointInControls):
(MediaControls.prototype.handleEvent):
(MediaControls.prototype.commitProperty):
(MediaControls.prototype.get layoutTraits): Deleted.
(MediaControls.prototype.set layoutTraits): Deleted.
(MediaControls.prototype.get showsStartButton): Deleted.
(MediaControls.prototype.set showsStartButton): Deleted.
(MediaControls.prototype.get placard): Deleted.
(MediaControls.prototype.get showsPlacard): Deleted.
(MediaControls.prototype.showPlacard): Deleted.
(MediaControls.prototype.hidePlacard): Deleted.
(MediaControls.prototype.controlsBarVisibilityDidChange): Deleted.
(MediaControls.prototype.controlsBarFadedStateDidChange): Deleted.
(MediaControls.prototype.layoutTraitsDidChange): Deleted.
(MediaControls.prototype.layout): Deleted.
(MediaControls.prototype._invalidateChildren): Deleted.

  • Modules/modern-media-controls/controls/media-document.css:

(:host(.media-document)):
(:host(.media-document.audio.mac)):

  • Modules/modern-media-controls/controls/mute-button.js:
  • Modules/modern-media-controls/controls/pip-button.js:
  • Modules/modern-media-controls/controls/placard.css:

(.placard):
(.placard .container):
(.placard button):
(.placard button > picture):
(.placard .icon): Deleted.

  • Modules/modern-media-controls/controls/placard.js:

(Placard.):
(Placard.prototype.layout):

  • Modules/modern-media-controls/controls/play-pause-button.js:

(PlayPauseButton):
(PlayPauseButton.prototype.commit):

  • Modules/modern-media-controls/controls/scheduler.js:

(const.scheduler.new.prototype.scheduleLayout):
(const.scheduler.new.prototype.unscheduleLayout):
(const.scheduler.new.prototype._requestFrameIfNeeded):
(const.scheduler.new.prototype._frameDidFire):
(const.scheduler.new.prototype._layout):

  • Modules/modern-media-controls/controls/scrubber.js: Removed.
  • Modules/modern-media-controls/controls/seek-button.js:
  • Modules/modern-media-controls/controls/skip-back-button.js:
  • Modules/modern-media-controls/controls/skip-forward-button.js: Added.

(SkipForwardButton):

  • Modules/modern-media-controls/controls/slider.css:

(.slider):
(.slider > .custom-slider,):
(.slider > .custom-slider):
(.slider > .custom-slider > *):
(.slider > .custom-slider > .fill):
(.slider > .custom-slider > .track):
(.slider > .custom-slider > .primary):
(.slider > .custom-slider > .secondary):
(.slider > .custom-slider > .knob):
(.slider > input):
(.slider > input::-webkit-slider-thumb):
(.slider.disabled > input,):
(.ios .slider > input):
(.ios .slider > input::-webkit-slider-runnable-track):
(.ios .slider > input::-webkit-slider-thumb):
(.slider > canvas,): Deleted.
(.slider > canvas): Deleted.

  • Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.set inputAccessibleLabel):
(Slider.prototype.get disabled):
(Slider.prototype.set disabled):
(Slider.prototype.get secondaryValue):
(Slider.prototype.set secondaryValue):
(Slider.prototype._formatTime):
(Slider.prototype.commitProperty):
(Slider.prototype.commit):
(Slider.prototype.draw): Deleted.
(addRoundedRect): Deleted.

  • Modules/modern-media-controls/controls/start-button.css: Removed.
  • Modules/modern-media-controls/controls/start-button.js: Removed.
  • Modules/modern-media-controls/controls/status-label.css:

(.status-label):

  • Modules/modern-media-controls/controls/status-label.js:

(StatusLabel.prototype.get enabled):
(StatusLabel.prototype.set enabled): Deleted.

  • Modules/modern-media-controls/controls/text-tracks.css:

(video::-webkit-media-text-track-container):
(video::-webkit-media-text-track-container.visible-controls-bar):
(video::-webkit-media-text-track-container.visible-controls-bar.compact-controls-bar): Deleted.

  • Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.set duration):
(TimeControl.prototype.set currentTime):
(TimeControl.prototype.get loading):
(TimeControl.prototype.set loading):
(TimeControl.prototype.get minimumWidth):
(TimeControl.prototype.get idealMinimumWidth):
(TimeControl.prototype.layout):
(TimeControl.prototype._performIdealLayout):
(TimeControl.prototype.get useSixDigitsForTimeLabels): Deleted.
(TimeControl.prototype.set useSixDigitsForTimeLabels): Deleted.
(TimeControl.prototype.get isSufficientlyWide): Deleted.

  • Modules/modern-media-controls/controls/time-label.css:

(.time-label):

  • Modules/modern-media-controls/controls/time-label.js:

(TimeLabel.prototype.setValueWithNumberOfDigits):
(TimeLabel.prototype.commitProperty):
(TimeLabel.prototype._formattedTime):
(doubleDigits):
(TimeLabel.prototype.set value): Deleted.

  • Modules/modern-media-controls/controls/tracks-button.js:
  • Modules/modern-media-controls/controls/tracks-panel.css:

(.tracks-panel > .scrollable-container):
(.tracks-panel section):
(.tracks-panel section > h3):
(.tracks-panel > .background-tint > div,): Deleted.

  • Modules/modern-media-controls/controls/volume-down-button.js:
  • Modules/modern-media-controls/controls/volume-slider.css: Removed.
  • Modules/modern-media-controls/controls/volume-slider.js: Removed.
  • Modules/modern-media-controls/controls/volume-up-button.js:
  • Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js:

(GestureRecognizer.prototype.gestureBegan):
(GestureRecognizer.prototype._removeTrackingListeners):

  • Modules/modern-media-controls/gesture-recognizers/tap.js:

(TapGestureRecognizer.prototype.touchesMoved):

(UIString):
(formatTimeByUnit):

  • Modules/modern-media-controls/media/audio-support.js: Added.

(AudioSupport.prototype.get control):
(AudioSupport.prototype.get mediaEvents):
(AudioSupport.prototype.get tracksToMonitor):
(AudioSupport.prototype.syncControl):
(AudioSupport):

  • Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype._updateControls):
(ControlsVisibilitySupport):

  • Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.buttonWasPressed):
(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):
(FullscreenSupport.prototype.iOSInlineMediaControlsRecognizedPinchInGesture): Deleted.

  • Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.get isAudio):
(MediaController.prototype.get isYouTubeEmbedWithTitle):
(MediaController.prototype.get isFullscreen):
(MediaController.prototype.get layoutTraits):
(MediaController.prototype.iOSInlineMediaControlsRecognizedTapGesture):
(MediaController.prototype.iOSInlineMediaControlsRecognizedPinchInGesture):
(MediaController.prototype._updateControlsIfNeeded):
(MediaController.prototype._updateTextTracksClassList):
(MediaController.prototype.controlsBarFadedStateDidChange): Deleted.

  • Modules/modern-media-controls/media/media-document-controller.js:

(MediaDocumentController.prototype._mediaDocumentHasMetadata):

  • Modules/modern-media-controls/media/placard-support.js:

(PlacardSupport.prototype._updatePlacard):
(PlacardSupport):

  • Modules/modern-media-controls/media/scrubbing-support.js:

(ScrubbingSupport.prototype.get mediaEvents):
(ScrubbingSupport.prototype.syncControl):
(ScrubbingSupport):

  • Modules/modern-media-controls/media/skip-back-support.js:
  • Modules/modern-media-controls/media/skip-forward-support.js: Added.

(SkipForwardSupport.prototype.get control):
(SkipForwardSupport.prototype.get mediaEvents):
(SkipForwardSupport.prototype.buttonWasPressed):
(SkipForwardSupport.prototype.syncControl):
(SkipForwardSupport):

  • Modules/modern-media-controls/media/start-support.js:

(StartSupport):
(StartSupport.prototype.handleEvent):
(StartSupport.prototype._shouldShowStartButton):
(StartSupport.prototype.get control): Deleted.
(StartSupport.prototype.syncControl): Deleted.

  • Modules/modern-media-controls/media/status-support.js:

(StatusSupport.prototype.get mediaEvents):
(StatusSupport.prototype.syncControl):
(StatusSupport):

  • Modules/modern-media-controls/media/time-control-support.js: Renamed from Source/WebCore/Modules/modern-media-controls/media/time-labels-support.js.

(TimeControlSupport.prototype.syncControl):
(TimeControlSupport):

  • Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport.prototype.syncControl):

  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Update test expectations to make a few of the tests we had already rebaselined pass.

  • TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
12:57 AM Changeset in webkit [217822] by sbarati@apple.com
  • 4 edits in trunk

Add a version number to ARES-6
​https://bugs.webkit.org/show_bug.cgi?id=172962

Reviewed by Yusuke Suzuki.

  • ARES-6/glue.js:

(driver.reportResult):

Jun 5, 2017:

11:30 PM Changeset in webkit [217821] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html and update TestExpectations.

Unreviewed test gardening.

  • fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events-expected.txt:
10:44 PM Changeset in webkit [217820] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip storage/domstorage/sessionstorage/set-item-synchronous-keydown.html on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=172943

Unreviewed test gardening.

  • platform/ios/TestExpectations:
9:53 PM Changeset in webkit [217819] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix features.json by adding an ESNext section.

Unreviewed.

  • features.json:
9:47 PM Changeset in webkit [217818] by Wenson Hsieh
  • 6 edits in trunk

Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
​https://bugs.webkit.org/show_bug.cgi?id=172891
<rdar://problem/32204540>

Reviewed by Darin Adler.

Source/WebCore:

Tweaks some logic in PlatformPasteboardIOS and WebItemProviderPasteboard to correctly construct objects in
-valuesForPasteboardType:inItemSet:. Previously, we have a hard-coded map of UTI type to Class in the form of
static helpers titled is{RichText, String, URL, Image, Color}Type in WebItemProviderPasteboard. We would use
these functions to determine whether an NSAttributedString, NSString, NSURL, UIImage or UIColor should be
constructed using the loaded item provider data. This is incorrect for some UTIs, such as public.html, which
cannot actually be used to construct an NSAttributedString -- this caused -valuesForPasteboardType:inItemSet: to
always return nil when attempting to create an object corresponding to public.html.

To fix this, we refactor -valuesForPasteboardType:inItemSet: to instead iterate through UIItemProviderReading-
conformant classes in search for a class that can be created for the given UTI type. If no such class exists, we
then fall back to custom WebKit handling of the dropped UTI type, which so far only includes reading an NSString
with public.plain-text if the UTI is public.html (i.e. reading the HTML source from loaded item provider data).

Covered by 2 new API tests:
DataInteractionTests.ExternalSourceHTMLToContentEditable
DataInteractionTests.ExternalSourceAttributedStringToContentEditable

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::readString):

In some cases, -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] may now return an
NSAttributedString when an NSString was previously created. This adjusts for that possibility by returning just
the plain text, -[NSAttributedString string], if the read object was an NSAttributedString.

  • platform/ios/WebItemProviderPasteboard.mm:

(allLoadableClasses):
(classForTypeIdentifier):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):

See description above for more details.

(isRichTextType): Deleted.
(isStringType): Deleted.
(isURLType): Deleted.
(isColorType): Deleted.
(isImageType): Deleted.

Removes these heuristics that attempt to "guess" the best UIItemProviderReading class to try and load for a
given UTI type.

  • rendering/RenderText.cpp:

(WebCore::RenderText::draggedContentRangesBetweenOffsets):

Adds a nil check to fix a debug assertion hit when running DataInteractionTests.

Tools:

Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
contenteditable. See WebCore ChangeLog for more details.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

9:00 PM Changeset in webkit [217817] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

Unreviewed GTK expectations gardening

Mark a few tests as crashing.

  • platform/gtk/TestExpectations:
8:51 PM Changeset in webkit [217816] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Follow-up: Update JSC's features.json
​https://bugs.webkit.org/show_bug.cgi?id=172942

Rubber-stamped by Jon Davis.

  • features.json: Change "Supported in preview" to

"Supported" to try to fix <​https://webkit.org/status/>.

8:22 PM Changeset in webkit [217815] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

Try to fix the GTK build.

Unreviewed.

  • bmalloc/List.h:
7:59 PM Changeset in webkit [217814] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

We don't properly parse init_expr when the opcode is an unexpected opcode
​https://bugs.webkit.org/show_bug.cgi?id=172945

Reviewed by JF Bastien.

The bug is a simple typo. It should use the constant
true instead of false when invoking the WASM_PARSER_FAIL_IF
macro. This failure is already caught by spec tests that fail
on arm64 devices.

  • wasm/WasmModuleParser.cpp:
7:59 PM Changeset in webkit [217813] by Chris Dumez
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: RunLoop::isMain() in com.apple.WebKit: IPC::Connection::sendSyncMessage + 128
​https://bugs.webkit.org/show_bug.cgi?id=172943
<rdar://problem/31288058>

Reviewed by Alexey Proskuryakov.

Make test clean a little bit more robust.

  • storage/domstorage/sessionstorage/set-item-synchronous-keydown.html:
7:34 PM Changeset in webkit [217812] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

OMG tier up checks should be a patchpoint
​https://bugs.webkit.org/show_bug.cgi?id=172944

Reviewed by Saam Barati.

Tier up checks in BBQ should be done as a patchpoint rather than individual B3 opcodes.
In order to reduce code generated out of line in each function. We generate a single stub
that pushes all the callee-saves. This looks like a 5-10% compile time speedup.

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::emitTierUpCheck):
(JSC::Wasm::B3IRGenerator::addLoop):

  • wasm/WasmThunks.cpp:

(JSC::Wasm::triggerOMGTierUpThunkGenerator):

  • wasm/WasmThunks.h:
7:21 PM Changeset in webkit [217811] by ggaren@apple.com
  • 12 edits in trunk/Source/bmalloc

bmalloc: Small and large objects should share memory
​https://bugs.webkit.org/show_bug.cgi?id=172880
<rdar://problem/31494732>

Reviewed by Sam Weinig.

This reduces our high water mark memory usage on JetStream on macOS
by 10%-20%. It also has the nice side effect that we can free small
object metadata after returning from a high water mark.

No change in throughput.

Our old algorithm allocated small object chunks and large objects in
segregated virtual memory and never recycled addresses between them.
This provided a slight security benefit because we could apply guard
pages between the segregated ranges and we would never reuse the same
virtual address for object and metadata memory.

Our new algorithm allocates small object chunks from the large object
allocator. This naturally recycles memory between small chunks and large
objects, and between small chunks of different page classes. This allows
us to shift memory between allocation types as a program moves between
different phases of allocation, and to delete small object chunk metadata
when a program shrinks back from a high water mark.

Two intuitions I had about memory use turned out to be backwards in
this context:

(1) I thought that this optimization would work because it allowed you to
allocate and free a 4MB object and then reuse that large allocation to
service small allocations. In practice, the common benefit seems to be
the opposite: After you allocate and free many small objects, you can
stitch them together to allocate a large object without growing the heap.

(2) I thought that it would be more memory-efficient to allocate
fine-grained pages from the large object allocator. In practice, giving
the large object allocator too many arbitrarily-sized ranges to manage
leads to fragmentation. Meanwhile, segregated fit is a powerful memory
optimization. So, it's best to return small object memory to the large
allocator only when a whole small object chunk is free.

  • bmalloc/Chunk.h:

(bmalloc::Chunk::ref):
(bmalloc::Chunk::deref):
(bmalloc::Chunk::refCount):
(bmalloc::Chunk::freePages): We keep a free list per chunk and refcount
each chunk so we can notice when a chunk becomes empty, and return it
to the large allocator.

(bmalloc::forEachPage): A new helper function for iterating the pages
in a Chunk.

(bmalloc::Chunk::Chunk): Use forEachPage instead of manual iteration.
Use { } initialization because we don't get zero-initialized by the OS
anymore.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::concurrentScavenge):
(bmalloc::Heap::scavenge): Don't bother unlocking while scavenging. I
wasn't able to show it to be a consistent speedup. A more promising
approach, if we find a motivating example, is for the scavenger to give
up and return early if any other client is waiting on the lock.

(bmalloc::Heap::allocateSmallChunk): New helper function for allocating
a small chunk. It allocates through the large allocator to facilitate
sharing. We still allocate a chunk at a time instead of a page at a time.
Surprisingly, more precise page-at-a-time allocation is worse for memory
use because of fragmentation. Segregated fit is a powerful optimization.

(bmalloc::Heap::deallocateSmallChunk): New helper function for deallocating
a small chunk.

(bmalloc::Heap::allocateSmallPage): Updated for new APIs.

(bmalloc::Heap::deallocateSmallLine): Updated for new APIs. Note that
we cache one free chunk per page class. This avoids churn in the large
allocator when you free(malloc(X)).

(bmalloc::Heap::allocateSmallBumpRangesByMetadata):
(bmalloc::Heap::allocateSmallBumpRangesByObject):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::scavengeSmallPages): Deleted.
(bmalloc::Heap::scavengeLargeObjects): Deleted.

  • bmalloc/Heap.h:
  • bmalloc/LargeMap.h:

(bmalloc::LargeMap::begin):
(bmalloc::LargeMap::end): Added iteration helpers for scavenging.

  • bmalloc/LargeRange.h:

(bmalloc::LargeRange::physicalSize): Added a comment about something
that I confused myself about in this patch.

  • bmalloc/List.h:

(bmalloc::List::iterator::operator*):
(bmalloc::List::iterator::operator->):
(bmalloc::List::iterator::operator!=):
(bmalloc::List::iterator::operator++):
(bmalloc::List::begin):
(bmalloc::List::end):
(bmalloc::List::pushFront):
(bmalloc::List::remove):
(bmalloc::ListNode::ListNode): Deleted. Added iteration helpers for
scavenging. Changed the default state of a Node to null pointers instead
of self pointers to distinguish the null node from the empty node for
easier debugging.

  • bmalloc/Sizes.h: Changed the chunk size to 1MB to increase the chances

of a chunk becoming free and recyclable.

  • bmalloc/SmallPage.h:

(bmalloc::SmallPage::hasPhysicalPages):
(bmalloc::SmallPage::setHasPhysicalPages): Track physical state by page
instead of implicitly by which list a page is in. It's simpler not
to have to move chunks and pages between physical vs virtual lists.

(bmalloc::SmallPage::SmallPage): Deleted.

  • bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::tryAllocateLargeChunk):
(bmalloc::VMHeap::allocateSmallChunk): Deleted.

  • bmalloc/VMHeap.h:

(bmalloc::VMHeap::allocateSmallPage): Deleted.
(bmalloc::VMHeap::deallocateSmallPage): Deleted. Small chunk allocation
just forwards to the large allocator now.

  • bmalloc/bmalloc.h:

(bmalloc::api::scavenge):

7:03 PM Changeset in webkit [217810] by Chris Dumez
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: RunLoop::isMain() in com.apple.WebKit: IPC::Connection::sendSyncMessage + 128
​https://bugs.webkit.org/show_bug.cgi?id=172943
<rdar://problem/31288058>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

In Connection::sendMessage(), make sure we only ever transform asynchronous messages into synchronous
ones if sendMessage() is called on the main thread. This is necessary because we no longer support
sending synchronous messages from a background thread since r205125.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::sendMessage):
(IPC::Connection::sendSyncMessage):

LayoutTests:

Add better test coverage.

  • storage/domstorage/sessionstorage/set-item-synchronous-keydown-expected.txt: Added.
  • storage/domstorage/sessionstorage/set-item-synchronous-keydown.html: Added.
5:03 PM Changeset in webkit [217809] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

Revert r217405, this headerpad increase is no longer needed.

Rubber-stamped by Dan Bernstein.

  • Configurations/BaseXPCService.xcconfig:
5:03 PM Changeset in webkit [217808] by Joseph Pecoraro
  • 4 edits in trunk/Source/JavaScriptCore

Remove unused VM members
​https://bugs.webkit.org/show_bug.cgi?id=172941

Reviewed by Mark Lam.

  • runtime/HashMapImpl.h:

(JSC::HashMapImpl::selectStructure): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
4:52 PM Changeset in webkit [217807] by commit-queue@webkit.org
  • 17 edits
    1 add in trunk

Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view
​https://bugs.webkit.org/show_bug.cgi?id=172848
<rdar://problem/25709212>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-06-05
Reviewed by Saam Barati.

JSTests:

  • typeProfiler/inheritance.js:

Rewrite the test slightly for clarity. The hoisting was confusing.

  • heapProfiler/class-names.js: Added.

(MyES5Class):
(MyES6Class):
(MyES6Subclass):
Test object types and improved class names.

  • heapProfiler/driver/driver.js:

(CheapHeapSnapshotNode):
(CheapHeapSnapshot):
(createCheapHeapSnapshot):
(HeapSnapshot):
(createHeapSnapshot):
Update snapshot parsing from version 1 to version 2.

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.h:
  • heap/HeapSnapshotBuilder.cpp:

Update the snapshot version. Change the node's 0 | 1 internal value
to be a 32bit bit flag. This is nice in that it is both compatible
with the previous snapshot version and the same size. We can use more
flags in the future.

(JSC::HeapSnapshotBuilder::json):
In cases where the classInfo gives us "Object" check for a better
class name by checking (o).proto.constructor.name. We avoid this
check in cases where (o).hasOwnProperty("constructor") which is the
case for most Foo.prototype objects. Otherwise this would get the
name of the Foo superclass for the Foo.prototype object.

  • runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):
Handle some possible edge cases that were not handled before. Such
as a JSObject without a GlobalObject, and an object which doesn't
have a default getPrototype. Try to make the code a little clearer.

Source/WebInspectorUI:

  • UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:

(HeapSnapshot):
Support the new snapshot version. The only thing that changes are the
node flags, and its actually completely compatible with version 1.

(HeapSnapshot.updateCategoriesAndMetadata):
List the count of object type instances in each class category.

(HeapSnapshot.prototype.serializeNode):
Include whether or not the node is an object type.

  • UserInterface/Proxies/HeapSnapshotNodeProxy.js:

(WebInspector.HeapSnapshotNodeProxy):
(WebInspector.HeapSnapshotNodeProxy.deserialize):
Add a new Node isObjectType property based on the new data.

  • UserInterface/Views/HeapSnapshotClassDataGridNode.js:

(WebInspector.HeapSnapshotClassDataGridNode.prototype.createCellContent):

  • UserInterface/Views/HeapSnapshotClusterContentView.js:

(WebInspector.HeapSnapshotClusterContentView.iconStyleClassNameForClassName):
If a class contains 50% or more object type instances then it as such
instead of defaulting to native.

  • UserInterface/Views/HeapSnapshotDataGridTree.js:

(WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):

  • UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:

(WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
We can be more specific than the default if the individual instance is
known to be an object type.

LayoutTests:

  • inspector/unit-tests/heap-snapshot-expected.txt:
  • inspector/unit-tests/heap-snapshot.html:

Update for the new node flag.

4:51 PM Changeset in webkit [217806] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for macOS 10.12

  • platform/spi/cocoa/AVKitSPI.h:
4:32 PM Changeset in webkit [217805] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update JSC's features.json
​https://bugs.webkit.org/show_bug.cgi?id=172942

Rubber stamped by Mark Lam.

  • features.json:
4:22 PM Changeset in webkit [217804] by jmarcell@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

4:15 PM Changeset in webkit [217803] by mitz@apple.com
  • 6 edits in trunk/Source

Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.

Source/WebCore:

  • platform/mac/WebPlaybackControlsManager.h:
  • platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager togglePictureInPicture]):

Source/WebKit2:

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::mediaPlaybackControlsView):

4:04 PM Changeset in webkit [217802] by mitz@apple.com
  • 5 edits in trunk/Source

Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.

Source/WebCore:

  • platform/spi/cocoa/AVKitSPI.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView updateMediaTouchBar]):

  • WebView/WebViewData.h:
4:01 PM Changeset in webkit [217801] by dbates@webkit.org
  • 2 edits
    1 add in trunk/Tools

webkitpy: Abstract Executive class
​https://bugs.webkit.org/show_bug.cgi?id=172928
<rdar://problem/32569531>

Reviewed by Ryosuke Niwa.

Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
This will make it straightforward to create additional derived classes that
adhere to the same interface, say for iOS on-device testing.

  • Scripts/webkitpy/common/system/abstractexecutive.py: Added.

(AbstractExecutive):
(AbstractExecutive.run_and_throw_if_fail):
(AbstractExecutive.cpu_count):
(AbstractExecutive.interpreter_for_script):
(AbstractExecutive.shell_command_for_script):
(AbstractExecutive.kill_process):
(AbstractExecutive.check_running_pid):
(AbstractExecutive.running_pids):
(AbstractExecutive.wait_newest):
(AbstractExecutive.wait_limited):
(AbstractExecutive.interrupt):
(AbstractExecutive.default_error_handler):
(AbstractExecutive.ignore_error):
(AbstractExecutive._stringify_args):
(AbstractExecutive.command_for_printing):
(AbstractExecutive.run_command):
(AbstractExecutive.popen):
(AbstractExecutive.run_in_parallel):

  • Scripts/webkitpy/common/system/executive.py:

(Executive):
(Executive.cpu_count):
(Executive.running_pids):
(Executive.kill_all):
(Executive._compute_stdin):
(Executive.interpreter_for_script): Deleted.
(Executive.shell_command_for_script): Deleted.
(Executive.wait_newest): Deleted.
(Executive.wait_limited): Deleted.
(Executive.default_error_handler): Deleted.
(Executive.ignore_error): Deleted.
(Executive.command_for_printing): Deleted.

3:41 PM Changeset in webkit [217800] by Konstantin Tokarev
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix missing semicolon in r217795

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::calculateNaturalSize):

3:40 PM Changeset in webkit [217799] by jer.noble@apple.com
  • 28 edits
    4 adds in trunk/Source

Allow clients to specify a list of codecs which should require hardware decode support.
​https://bugs.webkit.org/show_bug.cgi?id=172787

Reviewed by Alex Christensen.

Source/WebCore:

Add a new setting, checked by HTMLMediaElement, which allows MediaPlayerPrivate implementation
to require that the specified codecs have hardware support. This requirement will be supported
in the normal media loading path and the MSE path on Cocoa ports.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaCodecsRequiringHardwareSupport):

  • html/HTMLMediaElement.h:
  • page/Settings.cpp:

(WebCore::Settings::setMediaCodecsRequiringHardwareSupport):

  • page/Settings.h:

(WebCore::Settings::mediaCodecsRequiringHardwareSupport):

  • platform/cocoa/VideoToolboxSoftLink.cpp:
  • platform/cocoa/VideoToolboxSoftLink.h:
  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaCodecsRequiringHardwareSupport):

  • platform/graphics/avfoundation/objc/AVAssetTrackUtilities.h: Added.
  • platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm: Added.

(WebCore::assetTrackMeetsHardwareDecodeRequirements):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability):
(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):

Source/WebKit2:

Add a WKWebPageConfiguration (and associated WebPreferences and WKPreferencesRef) properties
allowing clients to require specified codecs have hardware decode support. Also open up the
sandbox on Cocoa ports to services required to check for hardware decode availability.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMediaCodecsRequiringHardwareSupport):
(WKPreferencesCopyMediaCodecsRequiringHardwareSupport):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _mediaCodecsRequiringHardwareSupport]):
(-[WKWebViewConfiguration _setMediaCodecsRequiringHardwareSupport:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

Add a couple of convenience methods:

  • a String::split() that returns a vector (rather than taking an out-reference to a vector).
  • A Vector::map() template which takes a Callable and returns a Vector of a different type.
  • wtf/Vector.h:

(WTF::Vector::map):

  • wtf/text/WTFString.h:

(WTF::String::split):

3:28 PM Changeset in webkit [217798] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.

  • platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager togglePictureInPicture]):

3:12 PM Changeset in webkit [217797] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.

  • platform/spi/mac/AVFoundationSPI.h:
2:54 PM Changeset in webkit [217796] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.

  • platform/spi/cocoa/IOSurfaceSPI.h:
2:45 PM Changeset in webkit [217795] by Konstantin Tokarev
  • 3 edits in trunk/Source/WebCore

Fix MediaPlayerPrivateMediaFoundation::naturalSize
​https://bugs.webkit.org/show_bug.cgi?id=172908

Reviewed by Alex Christensen.

MediaPlayerPrivateMediaFoundation::naturalSize should return size of
video frame corrected by PAR, not size of video element.

No new tests needed.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::load):
(WebCore::MediaPlayerPrivateMediaFoundation::naturalSize):
(WebCore::MediaPlayerPrivateMediaFoundation::setNaturalSize):
(WebCore::calculateNaturalSize):
(WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::setMediaType):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
2:04 PM Changeset in webkit [217794] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Destroy the associated renderer subtree when display: contents node is deleted.
​https://bugs.webkit.org/show_bug.cgi?id=172920
<rdar://problem/32446045>

Reviewed by Antti Koivisto.

Since display: contents node does not create a renderer, we need to explicitly check
and distinguish it from the display: none case.

Covered by existing tests.

  • dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

  • dom/Node.cpp:

(WebCore::Node::~Node): Promote ASSERT(!renderer()) to ASSERT_WITH_SECURITY_IMPLICATION.

  • dom/Text.cpp:

(WebCore::Text::~Text): Redundant assert. Text is a Node.

2:00 PM Changeset in webkit [217793] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Add iOS to platform
​https://bugs.webkit.org/show_bug.cgi?id=172931

Reviewed by Daniel Bates.

  • Scripts/webkitpy/common/system/platforminfo.py:

PlatformInfo.init): Use platform_module.release() as the os_version for iOS device.
(PlatformInfo.is_ios): Added.
(PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.is_ios): Added.

1:54 PM Changeset in webkit [217792] by clopez@igalia.com
  • 2 edits in trunk/Tools

[WPE][JHBuild] Switch github repository from ​git:// to ​https://
​https://bugs.webkit.org/show_bug.cgi?id=172921

Reviewed by Alex Christensen.

  • wpe/jhbuild.modules:
1:29 PM Changeset in webkit [217791] by Beth Dakin
  • 16 edits in trunk/Source

Modify Netflix controlsManager quirk to prevent only scrubbing
​https://bugs.webkit.org/show_bug.cgi?id=172881
-and corresponding-
rdar://problem/32228660

Reviewed by Andy Estes.

Source/WebCore:

Instead of preventing Netflix from getting a controlsManager at all, this patch
ONLY prevents touch bar scrubbing from working. This means that Netflix will now
get controls in the TouchBar, it means that the play/pause and PiP buttons will be
functional, and it means that the timeline will accurately represent the current
time, BUT users will not be able to use the timeline to scrub the video. This also
allows Netflix to work with other MediaRemote clients such as AirPods.

Remove the quirk code from here, since this is no longer the right place to test
if the MediaElement is hosted at Netflix.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::bestMediaElementForShowingPlaybackControlsManager):
(WebCore::needsPlaybackControlsManagerQuirk): Deleted.

Pass around a new bool allowsTouchBarScrubbing.

  • platform/cocoa/WebPlaybackSessionModel.h:

(WebCore::WebPlaybackSessionModelClient::allowsTouchBarScrubbingChanged):

  • platform/cocoa/WebPlaybackSessionModelMediaElement.h:

Here’s where we check if we need quirky behavior.

  • platform/cocoa/WebPlaybackSessionModelMediaElement.mm:

(WebCore::WebPlaybackSessionModelMediaElement::updateForEventName):
(WebCore::WebPlaybackSessionModelMediaElement::allowsTouchBarScrubbing):

Return the bool we have plumbed through tracking whether the current site
allowsTouchBarScrubbing from the existing delegate method
canBeginTouchBarScrubbing. We will always return NO for video elements on Netflix,
and this will prevent users from be able to scrub with the TouchBar on Netflix.

  • platform/mac/WebPlaybackControlsManager.h:
  • platform/mac/WebPlaybackControlsManager.mm:

(-[WebPlaybackControlsManager canBeginTouchBarScrubbing]):

More plumbing.

  • platform/mac/WebPlaybackSessionInterfaceMac.h:
  • platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::allowsTouchBarScrubbingChanged):
(WebCore::WebPlaybackSessionInterfaceMac::setPlayBackControlsManager):

Source/WebKit2:

Plumbing for allowsTouchBarScrubbing. See WebCore ChangeLog for more details.

  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:
  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.messages.in:
  • UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm:

(WebKit::WebPlaybackSessionModelContext::setAllowsTouchBarScrubbing):
(WebKit::WebPlaybackSessionManagerProxy::setAllowsTouchBarScrubbing):

  • WebProcess/cocoa/WebPlaybackSessionManager.h:
  • WebProcess/cocoa/WebPlaybackSessionManager.mm:

(WebKit::WebPlaybackSessionInterfaceContext::allowsTouchBarScrubbingChanged):
(WebKit::WebPlaybackSessionManager::allowsTouchBarScrubbingChanged):

11:19 AM Changeset in webkit [217790] by jmarcell@apple.com
  • 1 copy in tags/Safari-603.3.4

Tag Safari-603.3.4.

10:49 AM Changeset in webkit [217789] by sbarati@apple.com
  • 2 edits in trunk/Websites/browserbench.org

Update index.html to include ARES-6.

Rubber stamped by Ryosuke Niwa.

  • index.html:
9:50 AM Changeset in webkit [217788] by Ryan Haddad
  • 6 edits
    8 adds in branches/safari-603-branch/LayoutTests

Merge r216126.

9:35 AM Changeset in webkit [217787] by Ryan Haddad
  • 41 edits
    2 adds in trunk/LayoutTests

Rebaseline tests for Windows after r217772.
​https://bugs.webkit.org/show_bug.cgi?id=172866

Unreviewed test gardening.

  • platform/win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt:
  • platform/win/svg/batik/filters/filterRegions-expected.txt:
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/win/svg/batik/paints/patternRegionA-expected.txt:
  • platform/win/svg/batik/paints/patternRegions-expected.txt:
  • platform/win/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/win/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/win/svg/batik/text/smallFonts-expected.txt:
  • platform/win/svg/batik/text/textAnchor-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt:
  • platform/win/svg/batik/text/textEffect-expected.txt:
  • platform/win/svg/batik/text/textEffect2-expected.txt:
  • platform/win/svg/batik/text/textEffect3-expected.txt:
  • platform/win/svg/batik/text/textFeatures-expected.txt:
  • platform/win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/win/svg/batik/text/textLayout-expected.txt:
  • platform/win/svg/batik/text/textLayout2-expected.txt:
  • platform/win/svg/batik/text/textLength-expected.txt:
  • platform/win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/win/svg/batik/text/textPosition-expected.txt:
  • platform/win/svg/batik/text/textProperties-expected.txt:
  • platform/win/svg/batik/text/textProperties2-expected.txt:
  • platform/win/svg/batik/text/textStyles-expected.txt:
  • platform/win/svg/custom/broken-internal-references-expected.txt:
  • platform/win/svg/custom/path-textPath-simulation-expected.txt:
  • platform/win/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/win/svg/hixie/perf/001-expected.txt:
  • platform/win/svg/hixie/perf/002-expected.txt:
  • platform/win/svg/text/text-path-01-b-expected.txt:
  • platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
9:27 AM Changeset in webkit [217786] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GStreamer] Deadlock in MediaPlayerPrivateGStreamer::changePipelineState, web process often locks up on seeking in a youtube video that has already fully buffered
​https://bugs.webkit.org/show_bug.cgi?id=170003

Reviewed by Michael Catanzaro.

When video sink is requested to render a frame, the GstBaseSink preroll mutex is taken. Then WebKit media player
schedules a repaint in the main thread, taking the draw mutex and waiting on draw condition. It can happen that
before the repaint is done in the main thread, a pause is requested in the main thread, causing a change state
from PLAYING to PAUSE. When the change state reaches the video sink gst_base_sink_change_state() tries to get
the preroll mutex. This causes a deadlock because the main thread is waiting to get the preroll mutex, but the
other thread is waiting for the main thread to do the repaint. GStreamer handles this case by calling unlock()
on the video sink before trying to get the preroll mutex, but the media player doesn't cancel the pending
repaint when using coordinated graphics. This patch adds a new signal to WebKitVideoSink "repaint-cancelled" to
notify the media player to cancel the pending prepaint.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint): Release the draw mutex and notify the condition.
(WebCore::MediaPlayerPrivateGStreamerBase::repaintCancelledCallback): Call cancelRepaint().
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): Connect to WebKitVideoSink::repaint-cancelled.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRepaintCancelled): Emit WebKitVideoSink::repaint-cancelled.
(webkitVideoSinkUnlock): Call webkitVideoSinkRepaintCancelled().
(webkitVideoSinkStop): Ditto.
(webkit_video_sink_class_init): Add WebKitVideoSink::repaint-cancelled signal.

9:25 AM Changeset in webkit [217785] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GStreamer] Cleanup ifdefs in MediaPlayerPrivateGStreamerBase
​https://bugs.webkit.org/show_bug.cgi?id=172918

Reviewed by Michael Catanzaro.

The code in MediaPlayerPrivateGStreamerBase is quite difficult to follow with all the ifdefs for the
possibilities when rendering. Some of them are even dead code now that all ports using GStreamer are using also
coordinated graphics.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(VideoRenderRequestScheduler::VideoRenderRequestScheduler):
(VideoRenderRequestScheduler::stop):
(VideoRenderRequestScheduler::requestRender):
(webkitVideoSinkRequestRender):

9:05 AM Changeset in webkit [217784] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix compile warning when building GTK+ port without OpenGL.

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

9:03 AM Changeset in webkit [217783] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build with OpenGL disabled after r217779.

  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::mainFrameContentSizeChanged):

8:59 AM Changeset in webkit [217782] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Remove debug-only flag for flaky test http/tests/navigation/statistics.html.
​https://bugs.webkit.org/show_bug.cgi?id=172454

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
8:42 AM Changeset in webkit [217781] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
​https://bugs.webkit.org/show_bug.cgi?id=172887
<rdar://problem/32546061>

Reviewed by Sam Weinig.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::applyAutocorrection):
applyAutocorrection can call its completion handler synchronously,
which makes UIScriptController unhappy (see bug 172884).

5:33 AM Changeset in webkit [217780] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Do not force video sample's buffer release when the platformLayerProxy is inactive
​https://bugs.webkit.org/show_bug.cgi?id=172916

Reviewed by Carlos Garcia Campos.

When MediaPlayerPrivateGStreamerBase's plarformLayerProxy was inactive, a copy of the video sample
was being done (without the buffer) and set, causing the sample's buffer to get freed. This was done
to avoid stalling the gstreamer pipeline in situations where the video was set to display:none, as the
platformLayerProxy would keep all the available buffers. But this can't happen nowadays as setting
the video to display:none invalidates the proxy, causing it to release the references to the
gstreamer buffers it's using. Also, the current code is causing a crash when using gstreamer-gl and
the video is hidden but its contents are being painted through webgl or an accelerated canvas. So,
remove this sample copy as it's not necessary anymore.

Covered by existent tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

5:01 AM Changeset in webkit [217779] by Carlos Garcia Campos
  • 9 edits
    4 deletes in trunk/Source/WebKit2

[WPE] Use AcceleratedDrawingArea instead of its fork
​https://bugs.webkit.org/show_bug.cgi?id=172496

Reviewed by Žan Doberšek.

WPE uses its own drawing area implementation, which is actually a fork of AcceleratedDrawingArea, but simplified
for the case of compositing being always forced. AcceleratedDrawingArea already handles the case of compositing
being forced, so now that WPE is upstream we could simply use AcceleratedDrawingArea instead.

  • PlatformWPE.cmake:
  • Shared/DrawingAreaInfo.h: Remove DrawingAreaTypeWPE type.
  • UIProcess/API/wpe/DrawingAreaProxyWPE.cpp: Removed.
  • UIProcess/API/wpe/DrawingAreaProxyWPE.h: Removed.
  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy): Create an AcceleratedDrawingAreaProxy.

  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::mainFrameContentSizeChanged): Moved from DrawingAreaImpl since it actually
belongs here.

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create): Create an AcceleratedDrawingArea for WPE port.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: Remove mainFrameContentSizeChanged() that doesn't belong here.
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/wpe/DrawingAreaWPE.cpp: Removed.
  • WebProcess/WebPage/wpe/DrawingAreaWPE.h: Removed.
2:11 AM Changeset in webkit [217778] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline media/modern-media-controls/audio/audio-controls-metrics.html
​https://bugs.webkit.org/show_bug.cgi?id=172915

Patch by Antoine Quint <Antoine Quint> on 2017-06-05
Reviewed by Antoine Quint.

The default height of <audio> elements is now 31pt.

  • media/modern-media-controls/audio/audio-controls-metrics-expected.txt:
  • media/modern-media-controls/audio/audio-controls-metrics.html:
12:45 AM Changeset in webkit [217777] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Fix the condition to decide whether the MediaPlayer can be rendered accelerated
​https://bugs.webkit.org/show_bug.cgi?id=172852

Reviewed by Michael Catanzaro.

Before this change, in order to determine whether the MediaPlayer rendering could be accelerated we
needed the player to have a renderer or it would return false. The renderer was needed in order to
access the RenderLayerCompositor and check whether the chrome would be overwriting the accelerated
compositing setting. But we don't have that option in WebKitGTK+ or WPE, so we can just check the
accelerated compositing setting directly.

Another problems with the approach before this change is that accelerated rendering was being disabled
when the video element was not visible, as there's no video renderer. Due to this, cases where the video
is painted through an accelerated canvas or webgl would not be using hardware accelerated copies.

Covered by existent tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged):

Jun 4, 2017:

11:09 PM Changeset in webkit [217776] by Simon Fraser
  • 5 edits
    2 adds in trunk

Percentages are calculated wrong in SVG transform CSS property
​https://bugs.webkit.org/show_bug.cgi?id=172901

Reviewed by Zalan Bujtas.
Source/WebCore:

The code added in r217236 was just fetching viewBox(), but that can be empty.
SVGLengthContext::determineViewport() does the correct thing to get
the appropriate viewport.

Test: svg/transforms/percent-transform-values-viewbox.html

  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform):

LayoutTests:

  • svg/transforms/percent-transform-values-viewbox-expected.html: Added.
  • svg/transforms/percent-transform-values-viewbox.html: Added.
  • svg/transforms/transform-origin-css-property-expected.xhtml:
  • svg/transforms/transform-origin-css-property.xhtml: Make this test a bit less

annoying to maintain by applying the transforms relative to the fill-box, which means all
the transform origins are no longer offset by the box position. Other tests exercise
view-box relative transform origins.

1:56 PM Changeset in webkit [217775] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

[MediaStream] Page capture state not reported correctly
​https://bugs.webkit.org/show_bug.cgi?id=172897
<rdar://problem/32493318>

Reviewed by Youenn Fablet.

Source/WebCore:

Test: fast/mediastream/media-stream-track-muted.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::mediaState): Test for audio and video mute on the tracks.
(WebCore::MediaStream::characteristicsChanged): Call statusDidChange when m_mediaState
changes instead of m_muted, so the page is informed when just audio or video mute state
changes.

  • Modules/mediastream/MediaStream.h:
  • testing/Internals.cpp:

(WebCore::Internals::setMediaStreamTrackMuted): New.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/mediastream/media-stream-track-muted-expected.txt: Added.
  • fast/mediastream/media-stream-track-muted.html: Added.
11:19 AM Changeset in webkit [217774] by Darin Adler
  • 26 edits in trunk/Source

Streamline handling of attributes, using references as much as possible
​https://bugs.webkit.org/show_bug.cgi?id=172899

Reviewed by Chris Dumez.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::valueForRange): Use reference to value of
attribute instead of copy to avoid reference count churn.
(WebCore::AccessibilityNodeObject::maxValueForRange): Ditto.
(WebCore::AccessibilityNodeObject::minValueForRange): Ditto.

  • accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::childElementWithMatchingLanguage): Ditto.
(WebCore::AccessibilitySVGElement::accessibilityDescription): Ditto.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::StyleAttributeMutationScope::StyleAttributeMutationScope): Ditto.

  • editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::shouldCancelDefaultAction): Use the
equalLettersIgnoringASCIICase function instead of using
both equalIgnoringASCIICase and convertToASCIILowercase.

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::HTMLAudioElement): Marked this inline since we
want it inlined the one place it's used.
(WebCore::HTMLAudioElement::create): Use auto and named the local variable
just element.
(WebCore::HTMLAudioElement::createForJSConstructor): Call create rather than
repeating the code from create. Use setAttributeWithoutSynchronization directly
rather than calling helper functions. Removed unneeded null check;
setAttributeWithoutSynchronization handles null by removing the attribute.

  • html/HTMLAudioElement.h: Changed src argument of createForJSConstructor to

take AtomicString since that is what we need for an attribute value.

  • html/HTMLAudioElement.idl: Use [AtomicString] for src argument.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality): Use reference to value of
attribute instead of copy to avoid reference count churn.
(WebCore::HTMLElement::shouldAutocorrect): Ditto.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Call the new
parsedMediaAttribute instead of the old mediaQuerySet function. Other than the
name, the only change is that the result is now a const pointer.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType): Removed unnecessary local variable,
resulting in code that is slightly cleaner and possibly eliminating reference
count chrun.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSrc): Deleted.
(WebCore::HTMLMediaElement::selectNextSourceChild): Use parsedMediaAttribute and
removed rendudant direct check of whether mediaAttr is present. Changed logging to
get the media attribute directly rather than with a helper function. Changed type
to get the type attribute directly rather than with a helper function.
(WebCore::HTMLMediaElement::sourceWasAdded): Take a reference rather than a pointer.
(WebCore::HTMLMediaElement::sourceWasRemoved): Ditto.
(WebCore::HTMLMediaElement::doesHaveAttribute): Use reference to value of
attribute instead of copy to avoid reference count churn.

  • html/HTMLMediaElement.h: Updated for the above.
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto): Pass reference instead of pointer.
(WebCore::HTMLSourceElement::removedFrom): Ditto.
(WebCore::HTMLSourceElement::setSrc): Deleted.
(WebCore::HTMLSourceElement::media): Deleted.
(WebCore::HTMLSourceElement::setMedia): Deleted.
(WebCore::HTMLSourceElement::type): Deleted.
(WebCore::HTMLSourceElement::setType): Deleted.
(WebCore::HTMLSourceElement::parseAttribute): Clear out m_cachedParsedMediaAttribute.
This makes the parsing be lazy. The old code would parse the attribute value to make
a MediaQuerySet here, but we do it in parsedMediaAttribute now.
(WebCore::HTMLSourceElement::parsedMediaAttribute): Added. Creates a MediaQuerySet
if needed, and returns it or null.

  • html/HTMLSourceElement.h: Removed include of MediaList.h. Removed unneeded media,

type, setSrc, setMedia, and setType functions. Replaced the mediaQuerySet function
with the parsedMediaAttribute, which returns a const pointer rather than non-const,
and is also non-inline because it lazily creates the MediaQuerySet as needed. Replaced
m_mediaQuerySet with m_cachedParsedMediaAttribute.

  • html/HTMLSourceElement.idl: Use [Reflect] for both type and media.
  • html/MediaDocument.cpp: Modernize the MediaDocumentParser constructor.

(WebCore::MediaDocumentParser::createDocumentStructure): Instead of setSrc, use
setAttributeWithoutSynchronization for the src attribute just as we do for all the
other attributes of the newly created video element.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled): Use reference to
value of attribute instead of copy to avoid reference count churn.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL): Ditto.

  • rendering/RenderThemeIOS.mm:

(WebCore::getAttachmentProgress): Ditto.

  • rendering/RenderThemeMac.mm:

(WebCore::AttachmentLayout::layOutSubtitle): Ditto.
(WebCore::RenderThemeMac::paintAttachment): Ditto.

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::buildHorizontalKerningPair): Ditto.

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::buildVerticalKerningPair): Ditto.

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource): Ditto. Also use parentElement
instead of writing out code that does exactly what it does.

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
passed in element can't be null. Removed unnecessary conversion from NSString to String
and then back to NSString.

11:00 AM Changeset in webkit [217773] by weinig@apple.com
  • 41 edits
    38 adds
    4 deletes in trunk

Can't use Object.defineProperty() to add an item to a DOMStringMap or Storage
​https://bugs.webkit.org/show_bug.cgi?id=172687

Reviewed by Darin Adler.

Source/WebCore:

  • Adds support for generating the defineOwnProperty ClassInfo method table hook to add support for Object.defineProperty(). The implementation follows WebIDL section 3.9.3 DefineOwnProperty?. (​https://heycam.github.io/webidl/#legacy-platform-object-defineownproperty)
  • Adds support for generating named setters in addition to the already supported indexed setters as much of the required work was needed to make defineOwnProperty work for those properties. This patch does not aim to follow WebIDL faithfully, but rather to generate as close to the custom code as possible. A follow up change will attempt to match WebIDL more closely (which will also require changes to GetOwnPropertySlot?).
  • Removes the need for custom bindings in DOMStringMap, HTMLOptionsCollection and HTMLSelectElement. Gets us one function away from supporting Storage.
  • Tidies up generated headers a bit by grouping all the ClassInfo method table hooks together.
  • Removes support for CustomIndexedSetter, which is no longer used.

Test: js/dom/legacy-platform-object-defineOwnProperty.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Removed now unneeded custom bindings.

  • bindings/js/JSDOMStringMapCustom.cpp: Removed.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.h: Removed.
  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::putDelegate): Deleted.
Remove more code that is now generated.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateIndexedGetter):

  • Add missing check for indexed setter operation when determining if the property should be ReadOnly.
  • Add support for custom implementation name, matching GenerateNamedGetter.
  • Convert to taking an outputArray and indent to allow more flexibility going forward.

(GenerateNamedGetter):

  • Add missing check for named setter operation when determining if the property should be ReadOnly.
  • Convert to taking an outputArray and indent to allow more flexibility going forward.

(GenerateGetOwnPropertySlotBody):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomGetOwnPropertySlot is set.

(GenerateGetOwnPropertySlotBodyByIndex):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomGetOwnPropertySlotByIndex is set.

(GenerateGetOwnPropertyNames):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomEnumerateProperty is set.

(GenerateInvokeIndexedPropertySetter):
Added. Implements the 'invoke an indexed property setter' algorithm (​https://heycam.github.io/webidl/#invoke-indexed-setter)

(GenerateInvokeNamedPropertySetter):
Added. Implements the 'invoke a named property setter' algorithm (​https://heycam.github.io/webidl/#invoke-named-setter)

(GeneratePut):
(GeneratePutByIndex):

  • Convert to taking an outputArray and indent to allow more flexibility going forward.
  • Take over responsibility for checking and bailing if CustomPut is set.
  • Adds support for CEReactions.
  • Adopts GenerateInvokeIndexedPropertySetter and GenerateInvokeNamedPropertySetter to simplify code.
  • Removes support for CustomIndexedSetter, which is no longer used.
  • Replaces use direct checking of OverrideBuiltins with check if any interface it inherits has it, which is how it is specified to work.

(GenerateIsUnforgeablePropertyName):
Added. Helper subroutine to generate a function that compares a property name
agains all the property names defined as Unforgeable on the interface. Used by
GenerateDefineOwnProperty.

(GenerateDefineOwnProperty):
Added. Implements section 3.9.3 DefineOwnProperty? (​https://heycam.github.io/webidl/#legacy-platform-object-defineownproperty)
Adds support for CEReactions.

(GenerateDeletePropertyCommon):
Switch from getting OverrideBuiltins directly off the interface to using InheritsExtendedAttribute.

(GenerateNamedDeleterDefinition):
Switch signature to match peer generators.

(InstanceOverridesGetOwnPropertySlot):
Update for rename of JSCustomGetOwnPropertySlotAndDescriptor to CustomGetOwnPropertySlotAndDescriptor.

(InstanceOverridesGetOwnPropertySlotByIndex):
Added. Like InstanceOverridesGetOwnPropertySlot, but checks for the new CustomGetOwnPropertySlotByIndex
rather than CustomGetOwnPropertySlot.

(InstanceOverridesGetOwnPropertyNames):
Added. Moves complex predicate out of line.

(InstanceOverridesPut):
Removes now unused CustomIndexedSetter, and adds CustomPutFunction, which used to be checked separately.

(InstanceOverridesDefineOwnProperty):
Added.

(GenerateHeader):

  • Moves more structure flags together.
  • Simplifies predicates and moves the ClassInfo method table hooks together.

(GenerateImplementation):

  • Moves the ClassInfo method table hooks together
  • Adds call to GenerateDefineOwnProperty.

(GenerateLegacyCallerDefinitions):
Simplify bail condition to match other generators.

(GeneratePrototypeDeclaration):
Update for new extended attribute names.

(InstanceOverridesCall):
Renamed from IsCallable for consistency.

(HasComplexGetOwnProperty):
Deleted. Unused.

(InstanceOverridesPutImplementation):
Deleted. Unused.

(InstanceOverridesPutDeclaration):
Deleted. Unused.

(IsCallable):
Renamed, for consistency, to InstanceOverridesCall .

  • bindings/scripts/IDLAttributes.json:

Renames a few of the extended attributes to remove the JS prefix. This time
around I only did the ones in the area I was working, but we should probably
remove most of the rest.

  • css/CSSStyleDeclaration.idl:

Update for JSCustomGetOwnPropertySlotAndDescriptor -> CustomGetOwnPropertySlotAndDescriptor rename.

  • dom/DOMStringMap.idl:

Remove CustomNamedSetter and add uncomment out the setter.

  • dom/DatasetDOMStringMap.cpp:

(WebCore::DatasetDOMStringMap::setNamedItem):
(WebCore::DatasetDOMStringMap::setItem): Deleted.

  • dom/DatasetDOMStringMap.h:

Rename setItem to setNamedItem, which is what the generator expects.

  • dom/Node.idl:

Update for JSCustomPushEventHandlerScope -> CustomPushEventHandlerScope rename.

  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLObjectElement.idl:

Update for JSCustomGetOwnPropertySlotAndDescriptor -> CustomGetOwnPropertySlotAndDescriptor rename.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::isSupportedPropertyName):

  • html/HTMLCollection.h:

Add isSupportedPropertyName function which is used by the bindings and is now needed.

  • html/HTMLElement.idl:

Update for JSCustomPushEventHandlerScope -> CustomPushEventHandlerScope rename.

  • html/HTMLOptionsCollection.h:

(WebCore::HTMLOptionsCollection::setItem):
Add setItem() implementation which just forwards to the select element. Also, add
a type alias to make the implementations of item and namedItem less verbose.

  • html/HTMLOptionsCollection.idl:

Remove CustomIndexedSetter and uncomment the setter.

  • html/HTMLSelectElement.idl:

Remove CustomIndexedSetter and uncomment the setter. Also, reformat
to match the WHATWG spec.

  • page/DOMWindow.idl:

Update for JSCustomDefineOwnProperty -> CustomDefineOwnProperty rename. Add
CustomGetOwnPropertySlotByIndex which is now needed to remove some unsound
assumptions the generator was making.

  • page/Location.idl:

Update for removal of JS prefix from a bunch of extended attributes.

  • page/UserMessageHandlersNamespace.idl:

Update for JSCustomGetOwnPropertySlotAndDescriptor -> CustomGetOwnPropertySlotAndDescriptor rename.

  • storage/Storage.idl:

Remove CustomNamedSetter and uncomment the setter.

  • bindings/scripts/test/JS/JSInterfaceName.h:
  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.h: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h:
  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h:
  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h:
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp: Added.
  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h: Added.
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
  • bindings/scripts/test/TestIndexedSetterNoIdentifier.idl: Added.
  • bindings/scripts/test/TestIndexedSetterThrowingException.idl: Added.
  • bindings/scripts/test/TestIndexedSetterWithIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedAndIndexedSetterNoIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedAndIndexedSetterThrowingException.idl: Added.
  • bindings/scripts/test/TestNamedAndIndexedSetterWithIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedDeleterWithIdentifier.idl:
  • bindings/scripts/test/TestNamedSetterNoIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedSetterThrowingException.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithIdentifier.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithOverrideBuiltins.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithUnforgableProperties.idl: Added.
  • bindings/scripts/test/TestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.idl: Added.

Added new tests and updated some results.

LayoutTests:

  • js/dom/legacy-platform-object-defineOwnProperty-expected.txt: Added.
  • js/dom/legacy-platform-object-defineOwnProperty.html: Added.

New tests for Object.defineProperty on Storage and DOMStringMap.

  • js/dom/named-property-deleter.html:

Fix test which was deleting the wrong property. This doesn't change the result,
but is now actually testing the thing it meant to.

  • storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
  • storage/domstorage/localstorage/delete-defineproperty-removal.html:

Convert to testharness.js and show that the results are now correct.

10:57 AM Changeset in webkit [217772] by Simon Fraser
  • 83 edits in trunk

Object bounding box wrong for some paths
​https://bugs.webkit.org/show_bug.cgi?id=172866

Reviewed by Tim Horton.
Source/WebCore:

RenderSVGShape::calculateObjectBoundingBox() should use boundingRect()
rather than fastBoundingRect(), because the latter includes control points.

Covered by existing tests.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::calculateObjectBoundingBox):

LayoutTests:

So many new baselines.

  • platform/ios/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/ios/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/ios/svg/batik/text/longTextOnPath-expected.txt:
  • platform/ios/svg/batik/text/smallFonts-expected.txt:
  • platform/ios/svg/batik/text/textAnchor-expected.txt:
  • platform/ios/svg/batik/text/textDecoration-expected.txt:
  • platform/ios/svg/batik/text/textEffect-expected.txt:
  • platform/ios/svg/batik/text/textEffect2-expected.txt:
  • platform/ios/svg/batik/text/textEffect3-expected.txt:
  • platform/ios/svg/batik/text/textFeatures-expected.txt:
  • platform/ios/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/ios/svg/batik/text/textLayout-expected.txt:
  • platform/ios/svg/batik/text/textLayout2-expected.txt:
  • platform/ios/svg/batik/text/textLength-expected.txt:
  • platform/ios/svg/batik/text/textOnPath-expected.txt:
  • platform/ios/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/ios/svg/batik/text/textPosition-expected.txt:
  • platform/ios/svg/batik/text/textPosition2-expected.txt:
  • platform/ios/svg/batik/text/textProperties-expected.txt:
  • platform/ios/svg/batik/text/textProperties2-expected.txt:
  • platform/ios/svg/batik/text/textStyles-expected.txt:
  • platform/ios/svg/batik/text/verticalText-expected.txt:
  • platform/ios/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/ios/svg/custom/broken-internal-references-expected.txt:
  • platform/ios/svg/custom/path-textPath-simulation-expected.txt:
  • platform/ios/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/ios/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/ios/svg/custom/second-inline-text-expected.txt:
  • platform/ios/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/custom/animate-path-morphing-expected.txt:
  • platform/mac/svg/custom/broken-internal-references-expected.txt:
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/mac/svg/custom/second-inline-text-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • svg/custom/control-points-for-S-and-T-expected.txt:
  • svg/custom/use-nested-transform-expected.txt:
9:38 AM Changeset in webkit [217771] by Konstantin Tokarev
  • 10 edits
    1 add in trunk/Source

Fix build of Windows-specific code with ICU 59.1
​https://bugs.webkit.org/show_bug.cgi?id=172729

Reviewed by Darin Adler.

Source/JavaScriptCore:

Fix conversions from WTF::String to wchar_t* and vice versa.

  • jsc.cpp:

(currentWorkingDirectory):
(fetchModuleFromLocalFileSystem):

  • runtime/DateConversion.cpp:

(JSC::formatDateTime):

Source/WebCore:

Fix conversions from WTF::String to wchar_t* and vice versa.
No new tests needed.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateMediaFoundation::startCreateMediaSource):

Source/WebKit/win:

Fix conversions from WTF::String to wchar_t* and vice versa.

  • Plugins/PluginDatabaseWin.cpp:

(WebCore::addPluginPathsFromRegistry):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
(WebCore::safariPluginsDirectory):
(WebCore::addMacromediaPluginDirectories):

  • Plugins/PluginPackageWin.cpp:

(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • Plugins/PluginViewWin.cpp:

(WebCore::PluginView::handlePostReadFile):

Source/WTF:

  • wtf/text/win/WCharStringExtras.h: Added new header file wuth helper

functions for conversion between WTF::String and wchart_t*.
(WTF::stringToNullTerminatedWChar):
(WTF::wcharToString):
(WTF::nullTerminatedWCharToString):

9:26 AM Changeset in webkit [217770] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Drop unnecessary USE(CF) guard for getenv
​https://bugs.webkit.org/show_bug.cgi?id=172903

Reviewed by Sam Weinig.

getenv is not related to USE(CF) and OS(UNIX). It seems that this
ifdef only hits in WinCairo, but WinCairo can use getenv.
Moreover, in VM::VM, we already use getenv without any ifdef guard.

This patch just drops it.

  • runtime/VM.cpp:

(JSC::enableAssembler):

9:21 AM Changeset in webkit [217769] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Drop OS(DARWIN) for uintptr_t type conflict
​https://bugs.webkit.org/show_bug.cgi?id=172904

Reviewed by Sam Weinig.

In non-Darwin environment, uintptr_t may have the same type
to uint64_t. We avoided the compile error by using OS(DARWIN).
But, since it depends on cstdint implementaion rather than OS, it is flaky.
Instead, we just use template parameter IntegralType.
And we describe the type constraint in a SFINAE manner.

  • dfg/DFGOpInfo.h:

(JSC::DFG::OpInfo::OpInfo):

8:51 AM Changeset in webkit [217768] by Jonathan Bedard
  • 7 edits in trunk/LayoutTests

Unreviewed test gardening

Gardening test expectations for layout tests on iOS device. Moving
expectations for tests which fail on Simulator but pass on device.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
8:21 AM Changeset in webkit [217767] by Chris Dumez
  • 7 edits
    3 adds in trunk

Implement DOMMatrixReadOnly.transformPoint()
​https://bugs.webkit.org/show_bug.cgi?id=172900

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt:

Source/WebCore:

Implement DOMMatrixReadOnly.transformPoint():

Test: imported/blink/fast/dom/geometry-interfaces-dom-matrix-transformPoint.html

  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::transformPoint):

  • css/DOMMatrixReadOnly.h:
  • css/DOMMatrixReadOnly.idl:

LayoutTests:

  • imported/blink/fast/dom/geometry-interfaces-dom-matrix-transformPoint-expected.txt: Added.
  • imported/blink/fast/dom/geometry-interfaces-dom-matrix-transformPoint.html: Added.
  • imported/blink/fast/dom/resources/geometry-interfaces-test-helpers.js: Added.

Import test coverage from Blink.

4:26 AM Changeset in webkit [217766] by zandobersek@gmail.com
  • 3 edits
    2 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Add a few test failure expectations, linking them to
existing bugs. Update or add GTK+-specific baselines for three tests.

  • platform/gtk/TestExpectations:
  • platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt: Added.
  • platform/gtk/compositing/backing-store-attachment-1-expected.txt: Added.
  • platform/gtk/css1/box_properties/acid_test-expected.txt:
3:24 AM Changeset in webkit [217765] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

[GCrypt] Improve comments in AES, PBKDF2, RSA-SSA algorithm implementations
​https://bugs.webkit.org/show_bug.cgi?id=172894

Reviewed by Michael Catanzaro.

Add or improve code comments in libgcrypt implementations for the AES_CBC,
AES_GCM, AES_KW, PBKDF2 and RSA-SSA algorithms.

  • crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp: Add generic comments that

describe each operation that's performed.
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp: Ditto.

(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):

  • crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp: Ditto.

(WebCore::gcryptWrapKey):
(WebCore::gcryptUnwrapKey):

  • crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp: Ditto.

(WebCore::gcryptDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptVerify): Align the verification results comment with the
one that's used in the ECDSA implementation.

Jun 3, 2017:

6:54 PM Changeset in webkit [217764] by Chris Dumez
  • 10 edits
    2 adds in trunk

Implement DOMMatrix's fromFloat32Array / fromFloat64Array & toFloat32Array / toFloat64Array
​https://bugs.webkit.org/show_bug.cgi?id=172898

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline web-platform-test now that more checks are passing.

  • web-platform-tests/css/geometry-1/DOMMatrix-newobject-expected.txt:

Source/WebCore:

Implement DOMMatrix's fromFloat32Array / fromFloat64Array & toFloat32Array / toFloat64Array
as per:

Test: http/wpt/geometry/DOMMatrix-from-to-typed-arrays.html

  • css/DOMMatrix.cpp:

(WebCore::DOMMatrix::fromFloat32Array):
(WebCore::DOMMatrix::fromFloat64Array):

  • css/DOMMatrix.h:
  • css/DOMMatrix.idl:
  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::fromFloat32Array):
(WebCore::DOMMatrixReadOnly::fromFloat64Array):
(WebCore::DOMMatrixReadOnly::toFloat32Array):
(WebCore::DOMMatrixReadOnly::toFloat64Array):

  • css/DOMMatrixReadOnly.h:
  • css/DOMMatrixReadOnly.idl:

LayoutTests:

Add layout test coverage.

  • http/wpt/geometry/DOMMatrix-from-to-typed-arrays-expected.txt: Added.
  • http/wpt/geometry/DOMMatrix-from-to-typed-arrays.html: Added.
2:09 PM Changeset in webkit [217763] by Simon Fraser
  • 12 edits
    1 copy
    3 adds in trunk

Implement DOMPointReadOnly.matrixTransform()
​https://bugs.webkit.org/show_bug.cgi?id=172896

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

New baselines.

  • web-platform-tests/css/geometry-1/DOMPoint-002-expected.txt:
  • web-platform-tests/css/geometry-1/historical-expected.txt:

Source/WebCore:

DOMPointReadOnly.matrixTransform() creates the matrix or throws, then uses
a new function in TransformationMatrix to map x,y,z,w through the matrix.

Test: http/wpt/geometry/DOMPoint-003.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/DOMMatrixReadOnly.h:

(WebCore::DOMMatrixReadOnly::transformationMatrix):

  • dom/DOMPointReadOnly.cpp: Copied from Source/WebCore/dom/DOMPointReadOnly.idl.

(WebCore::DOMPointReadOnly::matrixTransform):

  • dom/DOMPointReadOnly.h:
  • dom/DOMPointReadOnly.idl:
  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::map4ComponentPoint):

  • platform/graphics/transforms/TransformationMatrix.h:

LayoutTests:

DOMPoint-003.html should be upstreamed at some point.

  • http/wpt/geometry/DOMPoint-003-expected.txt: Added.
  • http/wpt/geometry/DOMPoint-003.html: Added.
11:07 AM Changeset in webkit [217762] by mmaxfield@apple.com
  • 4 edits in trunk/Source/WebCore

Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
​https://bugs.webkit.org/show_bug.cgi?id=172886

Reviewed by Simon Fraser.

The number of arguments is getting out of control.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::platformFontWithFamilySpecialCase):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/spi/cocoa/CoreTextSPI.h:
10:58 AM Changeset in webkit [217761] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening

  • platform/ios/TestExpectations: Update expectation for tests passing

after ​https://bugs.webkit.org/show_bug.cgi?id=139968.

9:31 AM Changeset in webkit [217760] by Yusuke Suzuki
  • 9 edits
    4 adds in trunk

Script modules should be able to import data urls
​https://bugs.webkit.org/show_bug.cgi?id=171594

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/scripting-1/the-script-element/data-url-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-data-url-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/runtime-error-data-url-expected.txt:

Source/WebCore:

Tests: js/dom/classic-script-with-data-url.html

js/dom/modules/module-script-with-data-url.html

Script tag resources should have SameOriginDataURLFlag::Set to load data URLs
since script tags should treat data URLs as same origin.

  • bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache):

LayoutTests:

  • http/tests/security/script-with-dataurl-expected.txt:
  • http/tests/security/script-with-dataurl.html:

Now, the spec is changed and errors from data: scripts should not be muted.
​https://github.com/whatwg/html/issues/1778

  • js/dom/classic-script-with-data-url-expected.txt: Added.
  • js/dom/classic-script-with-data-url.html: Added.
  • js/dom/modules/module-script-with-data-url-expected.txt: Added.
  • js/dom/modules/module-script-with-data-url.html: Added.
9:21 AM Changeset in webkit [217759] by Simon Fraser
  • 4 edits in trunk/Source

Sort the project file.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
9:11 AM Changeset in webkit [217758] by Jonathan Bedard
  • 3 edits in trunk/Tools

webkitpy: Add contextmanager to disable logging for a block
​https://bugs.webkit.org/show_bug.cgi?id=172876

Reviewed by Daniel Bates.

Add a context manager which will use an OutputCapture object to capture logging
in a block and hold it in a variable.

  • Scripts/webkitpy/common/system/outputcapture.py:

(OutputCaptureScope):
(OutputCaptureScope.init): Construct with OutputCapture object.
(OutputCaptureScope.enter): Begin capturing output.
(OutputCaptureScope.exit): Restore output and save captured output to a variable.
output and retain the resulting log.

  • Scripts/webkitpy/common/system/outputcapture_unittest.py:

(OutputCaptureTest.test_output_capture_scope): Added.

8:26 AM Changeset in webkit [217757] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move css3/flexbox/image-percent-max-height.html failure expectation.
​https://bugs.webkit.org/show_bug.cgi?id=126898

Unreviewed test gardening

css3/flexbox/image-percent-max-height.html fails on iOS-simulator,
but passes on device.

  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
6:36 AM Changeset in webkit [217756] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Unreviewed buildfix after r217711.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::xor32):

4:24 AM Changeset in webkit [217755] by Yusuke Suzuki
  • 4 edits
    1 add in trunk

ASSERTION FAILED: "We should only declare a function as a lexically scoped variable in scopes where var declarations aren't allowed. ..." for function redeclaration with async function module export
​https://bugs.webkit.org/show_bug.cgi?id=168844

Reviewed by Saam Barati.

JSTests:

  • modules/async-function-export.js: Added.

(f):
(export.async.f):

Source/JavaScriptCore:

As the same to the exported function declaration, we should set statementDepth = 1 for exported async function declaration.

  • parser/Parser.cpp:

(JSC::DepthManager::DepthManager):
(JSC::Parser<LexerType>::parseExportDeclaration):

  • parser/Parser.h:

(JSC::Parser::DepthManager::DepthManager): Deleted.
(JSC::Parser::DepthManager::~DepthManager): Deleted.

3:29 AM Changeset in webkit [217754] by zandobersek@gmail.com
  • 7 edits
    1 add in trunk/Source/WebCore

[GCrypt] Gather SUBTLE_CRYPTO utility functions in a single header
​https://bugs.webkit.org/show_bug.cgi?id=172870

Reviewed by Jiewen Tan.

Gather the helper functions used across different source files
for libgcrypt-backed SUBTLE_CRYPTO implementations in a single
header file.

  • crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:

(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::hashAlgorithmName): Deleted.
(WebCore::mpiData): Deleted.

  • crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:

(WebCore::gcryptDeriveBits):
(WebCore::macAlgorithmForHashFunction): Deleted.

  • crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:

(WebCore::gcryptDeriveBits):

  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::mpiData): Deleted.

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::hashAlgorithmName): Deleted.
(WebCore::mpiData): Deleted.

  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::hashAlgorithmName): Deleted.
(WebCore::mpiData): Deleted.

  • crypto/gcrypt/GCryptUtilities.h: Added.

(WebCore::hashAlgorithmName):
(WebCore::hmacAlgorithm):
(WebCore::digestAlgorithm):
(WebCore::hashCryptoDigestAlgorithm):
(WebCore::mpiData):

3:27 AM Changeset in webkit [217753] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GCrypt] Fix PK verification for ECDSA
​https://bugs.webkit.org/show_bug.cgi?id=172857

Reviewed by Michael Catanzaro.

No new tests -- covered by existing tests.

  • crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:

(WebCore::gcryptVerify): Return true if the verification succeeded or false
in any other case, avoiding spilling information about the exact cause of
verification failure.

1:07 AM Changeset in webkit [217752] by Chris Dumez
  • 3 edits in trunk/LayoutTests

http/tests/cache/disk-cache/shattered-deduplication.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=172868
<rdar://problem/31249379>

Reviewed by Antti Koivisto.

http/tests/cache/disk-cache/shattered-deduplication.html was flaky due to PDF banner
fade-in / fade-out animation.

<rdar://problem/31249379> is fixed for me with the proposed changes.

  • http/tests/cache/disk-cache/shattered-deduplication-expected.html:
  • Wait 1 second before calling notifyDone() to give the PDF as much time to render as

the test page.

  • Reduce frame height to 30 to not have to worry about the PDF tool banner being visible or not (as it fades in and out). 30 is still enough to see the color and confirm the test is passing.
  • http/tests/cache/disk-cache/shattered-deduplication.html:
  • Reduce frame height to 30 to not have to worry about the PDF tool banner being visible or not (as it fades in and out). 30 is still enough to see the color and confirm the test is passing.

Jun 2, 2017:

9:40 PM Changeset in webkit [217751] by Alan Bujtas
  • 4 edits in trunk

Cleanup FrameView::autoSizeIfEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=172889
<rdar://problem/32550783>

Reviewed by Tim Horton.

Source/WebCore:

This patch ensures that we always have a clean tree (and a valid and current document size) when
setting m_autoSizeContentSize.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:

(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
(TEST):

8:44 PM Changeset in webkit [217750] by Devin Rousso
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab
​https://bugs.webkit.org/show_bug.cgi?id=172621

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ContentBrowserTabContentView.js:

(WebInspector.ContentBrowserTabContentView):
(WebInspector.ContentBrowserTabContentView.prototype.shown):

  • UserInterface/Views/TabContentView.js:

(WebInspector.TabContentView):
(WebInspector.TabContentView.prototype.get navigationSidebarPanel):

  • UserInterface/Views/NetworkTabContentView.js:

(WebInspector.NetworkTabContentView.prototype.canShowRepresentedObject):

  • UserInterface/Views/SearchTabContentView.js:

(WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
Use public getter for navigationSidebarPanel.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.initialLayout): Added.
Load information about the current frame once the sidebar panel is displayed.

8:37 PM Changeset in webkit [217749] by Devin Rousso
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Use initialLayout for DetailsSidebarPanel classes
​https://bugs.webkit.org/show_bug.cgi?id=172381

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:

(WebInspector.ApplicationCacheDetailsSidebarPanel):
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.DOMNodeDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:

(WebInspector.IndexedDatabaseDetailsSidebarPanel):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.layout):

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel):
(WebInspector.ProbeDetailsSidebarPanel.prototype.initialLayout): Added.

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel):
(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
(WebInspector.ResourceDetailsSidebarPanel.prototype.initialLayout): Added.
(WebInspector.ResourceDetailsSidebarPanel.prototype.layout):
(WebInspector.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):

7:27 PM Changeset in webkit [217748] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

REGRESSION(r216212): RenderReplaced::paint() should not save and restore the context unless it has to
​https://bugs.webkit.org/show_bug.cgi?id=172883
<rdar://problem/32548614>

Reviewed by Tim Horton.

After implementing dragged content fading, RenderReplace::paint is now always guarded by unnecessary calls to
GraphicsContext::save and GraphicsContext::restore, even when there is no dragged content being rendered. To
address this, we initialize our GraphicsContextStateSaver with saveAndRestore = false, indicating that we don't
want to immediately try and save the context.

If we are in a dragged content range, we will then call GraphicsContextStateSaver::save, which saves the
graphics context and also causes the GraphicsContextStateSaver to eventually try and restore() when it is
destroyed. Otherwise, in the common codepath where the renderer is not in a dragged content range, the
constructor and destructor of GraphicsContextStateSaver will be no-ops with respect to saving and restoring the
graphics context.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

6:35 PM Changeset in webkit [217747] by Yusuke Suzuki
  • 1 edit
    4 adds in trunk/JSTests

ES2015 modules - Export default function hoisting
​https://bugs.webkit.org/show_bug.cgi?id=170174

Reviewed by Saam Barati.

This issue itself is solved by fixing function declaration hoisting rules.
This patch just adds the specific test to modules tests to ensure the bug
is fixed.

  • modules/export-default-function-hoisting.js: Added.
  • modules/export-default-function-hoisting/cappuccino.js: Added.

(import.drinkCocoa.from.string_appeared_here.export.default.drinkCappuccino):

  • modules/export-default-function-hoisting/cocoa.js: Added.

(export.default.drinkCocoa):

6:18 PM Changeset in webkit [217746] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown
​https://bugs.webkit.org/show_bug.cgi?id=172608

Reviewed by Timothy Hatcher.

  • UserInterface/Views/ConsolePrompt.js:

(WebInspector.ConsolePrompt.prototype.shown): Deleted.

  • UserInterface/Views/DatabaseContentView.js:

(WebInspector.DatabaseContentView.prototype.shown): Deleted.

  • UserInterface/Views/QuickConsole.js:

(WebInspector.QuickConsole):

6:09 PM Changeset in webkit [217745] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Defer installing mach breakpoint handler until watchdog is actually called
​https://bugs.webkit.org/show_bug.cgi?id=172885

Reviewed by Saam Barati.

Eagerly installing the mach breakpoint handler causes issues with Xcode GUI debugging.
This hides the issue, so it won't occur as often.

  • runtime/VMTraps.cpp:

(JSC::VMTraps::SignalSender::send):
(JSC::VMTraps::VMTraps): Deleted.

  • runtime/VMTraps.h:
4:58 PM Changeset in webkit [217744] by Devin Rousso
  • 5 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values
​https://bugs.webkit.org/show_bug.cgi?id=167076
<rdar://problem/30033629>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAttributes):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._attributeNodeValueChanged):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid): Deleted.
Rework creation of the attributes DataGrid so that it is only created once and cleared for
new content. Nodes in the DataGrid are now EditableDataGridNode instances so that attribute
names and values can be changed from within the sidebar. The DataGrid is also sorted based
on attribute name, to make finding attributes easier.

  • UserInterface/Views/DataGrid.css:

(.data-grid tr.editable .cell-content > input):
(body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .content .data-grid tr:not(.editable) td.value-column):
(.details-section > .content .data-grid tr:not(.editable) td.value-column > div):
(.details-section > .content .data-grid td.value-column): Deleted.
(.details-section > .content .data-grid td.value-column > div): Deleted.

  • UserInterface/Main.html:
  • UserInterface/Views/EditableDataGridNode.js: Added.

(WebInspector.EditableDataGridNode):
(WebInspector.EditableDataGridNode.prototype.get element):
(WebInspector.EditableDataGridNode.prototype.createCellContent):
(WebInspector.EditableDataGridNode.prototype._handleKeyPress):
(WebInspector.EditableDataGridNode.prototype._handleBlur):
(WebInspector.EditableDataGridNode.prototype._notifyInputElementValueChanged):
Special type of DataGridNode that wraps the content of each cell in an <input>.

4:48 PM Changeset in webkit [217743] by Chris Dumez
  • 8 edits in trunk

ResourceLoadStatistics are not using unique paths during test runs
​https://bugs.webkit.org/show_bug.cgi?id=172861
<rdar://problem/32442251>

Reviewed by Darin Adler.

Source/WebKit2:

Add WKContextConfigurationSetResourceLoadStatisticsDirectory() C API to allow
WKTR to use a custom directory.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/C/WKContextConfigurationRef.cpp:

(WKContextConfigurationCopyResourceLoadStatisticsDirectory):
(WKContextConfigurationSetResourceLoadStatisticsDirectory):

  • UIProcess/API/C/WKContextConfigurationRef.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::legacyWebsiteDataStoreConfiguration):

Tools:

Make sure WebKitTestRunner sets a temporary path for saving resource
load statistics.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::generateContextConfiguration):

4:40 PM Changeset in webkit [217742] by mmaxfield@apple.com
  • 11 edits
    4 adds in trunk

REGRESSION(r213464): [iOS] Fonts get too bold when the "Bold Text" accessibility setting is enabled
​https://bugs.webkit.org/show_bug.cgi?id=172737
Source/WebCore:

Reviewed by Simon Fraser.

Revert the part of r213464 which changed how we calculate the weights of system fonts.

Add an InternalSetting to trigger our mock of the accessbility "Bold Text" setting. We can't
use the real setting, so instead we just ask for bold fonts instead of regular fonts when this
setting is true.

Tests: fast/text/accessibility-bold-system-font.html

fast/text/accessibility-bold-system-font-2.html

  • platform/graphics/FontCache.h:

(WebCore::FontCache::shouldMockBoldSystemFontForAccessibility):
(WebCore::FontCache::setShouldMockBoldSystemFontForAccessibility):

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::platformFontWithFamilySpecialCase):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::shouldMockBoldSystemFontForAccessibility):
(WebCore::RenderTheme::setShouldMockBoldSystemFontForAccessibility):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::cssWeightOfSystemFont):
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldMockBoldSystemFontForAccessibility):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

<rdar://problem/31608236>

Reviewed by Simon Fraser.

  • fast/text/accessibility-bold-system-font-2-expected.html: Added.
  • fast/text/accessibility-bold-system-font-2.html: Added.
  • fast/text/accessibility-bold-system-font-expected.txt: Added.
  • fast/text/accessibility-bold-system-font.html: Added.
  • platform/mac/TestExpectations:
4:11 PM Changeset in webkit [217741] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark webrtc/captureCanvas-webrtc.html as flaky on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=170870

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
4:10 PM Changeset in webkit [217740] by Jonathan Bedard
  • 3 edits in trunk/LayoutTests

Move compositing/overflow/dynamic-composited-scrolling-status.html failure expectation.
​https://bugs.webkit.org/show_bug.cgi?id=152439

Unreviewed test gardening

compositing/overflow/dynamic-composited-scrolling-status.html fails on iOS-simulator WK2,
but passes on device.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/TestExpectations:
4:07 PM Changeset in webkit [217739] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark webrtc/audio-replace-track.html as flaky on iOS and remove Timeout expectation for macOS.
​https://bugs.webkit.org/show_bug.cgi?id=171895

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
4:07 PM Changeset in webkit [217738] by beidson@apple.com
  • 7 edits in trunk

Prevent scheme handlers from handling all built-in URL schemes.
<rdar://problem/32404790> and ​https://bugs.webkit.org/show_bug.cgi?id=172869

Reviewed by Andy Estes.

Source/WebCore:

Covered by API test.

This patch refactors SchemeRegistry to keep a base, constant set of each of the special
URL schemes that WebKit knows about by default.

It then exposes that list through a new method to support WK2 API.

  • platform/SchemeRegistry.cpp:

(WebCore::allBuiltinSchemes):
(WebCore::builtinLocalURLSchemes):
(WebCore::localURLSchemes):
(WebCore::builtinSecureSchemes):
(WebCore::secureSchemes):
(WebCore::builtinSchemesWithUniqueOrigins):
(WebCore::schemesWithUniqueOrigins):
(WebCore::builtinEmptyDocumentSchemes):
(WebCore::emptyDocumentSchemes):
(WebCore::builtinCanDisplayOnlyIfCanRequestSchemes):
(WebCore::canDisplayOnlyIfCanRequestSchemes):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::builtinCORSEnabledSchemes):
(WebCore::CORSEnabledSchemes):
(WebCore::SchemeRegistry::isBuiltinScheme):

  • platform/SchemeRegistry.h:

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(+[WKWebView handlesURLScheme:]): Check against WebCore's new master list of URL schemes.

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
4:06 PM Changeset in webkit [217737] by Simon Fraser
  • 31 edits
    2 copies
    2 adds in trunk/Source

All scroll peformance logging should happen in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=172874
rdar://problem/24474830

Reviewed by Tim Horton.

Printing to stdout from the WebProcess doesn't show up anywhere in non-development builds,
so we have to log from the UI process.

Achieve this by adding a PerformanceLoggingClient to Page which forwards messages to
WebPageProxy, which prints them with the same format they had before. Some plumbing through
PlatformCALayerClient and GraphicsLayerClient is required to get messages from TileControllers
through to something that can get to Page.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):

  • page/Page.h:

(WebCore::Page::performanceLoggingClient):

  • page/PageConfiguration.cpp:
  • page/PageConfiguration.h:
  • page/PerformanceLoggingClient.cpp: Added.

(WebCore::PerformanceLoggingClient::synchronousScrollingReasonsAsString):

  • page/PerformanceLoggingClient.h: Added.

(WebCore::PerformanceLoggingClient::~PerformanceLoggingClient):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::reportExposedUnfilledArea):
(WebCore::AsyncScrollingCoordinator::reportSynchronousScrollingReasonsChanged):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ScrollingTree::reportExposedUnfilledArea):

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ThreadedScrollingTree::reportExposedUnfilledArea):

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeMac::exposedUnfilledArea):
(WebCore::ScrollingTreeFrameScrollingNodeMac::logExposedUnfilledArea): Deleted.
(WebCore::logThreadedScrollingMode): Deleted.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::logFilledVisibleFreshTile):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerLogFilledVisibleFreshTile):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerLogFilledVisibleFreshTile):

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::logFilledVisibleFreshTile):

  • platform/graphics/ca/TileController.h:
  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):

  • platform/graphics/ca/TileGrid.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::logFilledVisibleFreshTile):

  • rendering/RenderLayerBacking.h:

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::logScrollingEvent):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPerformanceLoggingClient.cpp: Added.

(WebKit::WebPerformanceLoggingClient::WebPerformanceLoggingClient):
(WebKit::WebPerformanceLoggingClient::logScrollingEvent):

  • WebProcess/WebCoreSupport/WebPerformanceLoggingClient.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

3:20 PM Changeset in webkit [217736] by commit-queue@webkit.org
  • 8 edits in trunk

[JSCOnly] Build static jsc.exe on Windows
​https://bugs.webkit.org/show_bug.cgi?id=172833

Patch by Stephan Szabo <​stephan.szabo@am.sony.com> on 2017-06-02
Reviewed by Konstantin Tokarev.

.:

  • Source/cmake/OptionsJSCOnly.cmake:

Source/WTF:

  • wtf/PlatformJSCOnly.cmake:

Tools:

  • CMakeLists.txt:
  • Scripts/build-jsc:
3:12 PM Changeset in webkit [217735] by Alan Bujtas
  • 2 edits in trunk/Tools

Disable ViewportSizeForViewportUnits tests on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=172872

Reviewed by Tim Horton.

  • TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2:16 PM Changeset in webkit [217734] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

[MediaStream iOS] Cleanup video muting/unmuting when tab visibility changes
​https://bugs.webkit.org/show_bug.cgi?id=172858

Reviewed by Youenn Fablet.

Source/WebCore:

Test: platform/ios/mediastream/video-muted-in-background-tab.html

  • dom/Document.cpp:

(WebCore::Document::visibilityStateChanged): Call notifyMediaCaptureOfVisibilityChanged.
(WebCore::Document::notifyMediaCaptureOfVisibilityChanged): Renamed from notifyVisibilityChangedToMediaCapture.
Set m_videoCaptureMutedForVisibilityChange when capture is muted because the document is hidden,
and clear it when visibility changes when capture is disabled. Don't unmute when the document
becomes visible unless this m_videoCaptureMutedForVisibilityChange is still true.
(WebCore::Document::notifyVisibilityChangedToMediaCapture): Deleted.

  • dom/Document.h:
  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility): Renamed from
setVisibility.
(WebCore::RealtimeMediaSourceCenter::setVisibility): Deleted.

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSourceFactory::setVideoCaptureMutedForPageVisibility): Ditto.
(WebCore::AVVideoCaptureSourceFactory::setVisibility): Deleted.

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSourceFactory::setVideoCaptureMutedForPageVisibility): Ditto.
(WebCore::MockRealtimeVideoSourceFactory::setVisibility): Deleted.

LayoutTests:

  • platform/ios/mediastream/video-muted-in-background-tab-expected.txt: Added.
  • platform/ios/mediastream/video-muted-in-background-tab.html: Added.
1:57 PM Changeset in webkit [217733] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Existing query in Search tab doesn't perform search on reload
​https://bugs.webkit.org/show_bug.cgi?id=172663

Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search.changed > .banner):
(.sidebar > .panel.navigation.search.changed > .banner > a):
(.sidebar > .panel.navigation.search.changed > :matches(.content, .empty-content-placeholder)):

  • UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
(WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
(WebInspector.SearchSidebarPanel.prototype._contentChanged):
Listen for any "resource added" event, and show the content changed banner when one occurs.

1:48 PM Changeset in webkit [217732] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Moved test expectation for http/tests/preload/viewport/meta-viewport-link-headers.php to correct file.
​https://bugs.webkit.org/show_bug.cgi?id=172518

Unreviewed test gardening

  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
12:57 PM Changeset in webkit [217731] by Chris Dumez
  • 3 edits in trunk/LayoutTests

REGRESSION: LayoutTest fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=161549
<rdar://problem/28213429>

Reviewed by Simon Fraser.

  • fast/scrolling/arrow-key-scroll-in-rtl-document.html:

Call eventSender.callAfterScrollingCompletes() in the next event loop iteration to
address the flakiness.

  • platform/mac-wk2/TestExpectations:

Unskip test.

12:40 PM Changeset in webkit [217730] by fred.wang@free.fr
  • 6 edits
    5 adds in trunk

[Mac] Include frames in the scrolling tree when ScrollingTreeIncludesFrames=true
​https://bugs.webkit.org/show_bug.cgi?id=172825

Patch by Frederic Wang <​fwang@igalia.com> on 2017-06-02
Reviewed by Simon Fraser.

Source/WebCore:

This commit generalizes RenderLayerCompositor/ScrollingCoordinator so that it handles the
case of non-main frames. When ScrollingTreeIncludesFrames=true, all the frames will appear
in the scrolling tree on Mac WK2.

Test: fast/scrolling/scrolling-tree-includes-frame.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView): Do not to restrict to the
main frame.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking): Do not to restrict to the main frame.
(WebCore::RenderLayerCompositor::useCoordinatedScrollingForLayer): Make this function a class
member so it can call hasCoordinatedScrolling and no longer needs a RenderView parameter.
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus): Do not to restrict to the
main frame.

  • rendering/RenderLayerCompositor.h: Introduce useCoordinatedScrollingForLayer.

LayoutTests:

Add a new test to check whether a non-main frame appears in the scrolling tree when
ScrollingTreeIncludesFrames=true. For now this is only happens for Mac WK2. Also update
the iOS WK2 reference for scrolling-iframe-expected.html

  • fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added.
  • fast/scrolling/scrolling-tree-includes-frame.html: Added.
  • platform/ios-simulator/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added.
  • platform/ios-wk2/compositing/iframes/scrolling-iframe-expected.txt: Update reference.
  • platform/mac-wk1/fast/scrolling/scrolling-tree-includes-frame-expected.txt: Added.
12:15 PM Changeset in webkit [217729] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r206386): Xactimate Website Crashes @ com.apple.WebKit: WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant + 255
​https://bugs.webkit.org/show_bug.cgi?id=172846
<rdar://problem/31093005>

Reviewed by Mark Lam.

Follow-up to r217695 to deal with exceptions potentially thrown by
NPRuntimeObjectMap::convertJSValueToNPVariant() as well.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

12:04 PM Changeset in webkit [217728] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Add abilility to specify presentingApplicationPID for a WebProcessPool.
​https://bugs.webkit.org/show_bug.cgi?id=172839
rdar://problem/32247170

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-06-02
Reviewed by Tim Horton.

Expose presentingApplicationPID through WebProcessPoolConfiguration.
This allows rehosted WebViews to specify the hosting application.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration setPresentingApplicationPID:]):
(-[_WKProcessPoolConfiguration presentingApplicationPID]):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

12:04 PM Changeset in webkit [217727] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WebCore] DragImageRef should correspond to USE(CAIRO)
​https://bugs.webkit.org/show_bug.cgi?id=172863

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-06-02
Reviewed by Carlos Alberto Lopez Perez.

No new tests. No change in behavior.

  • platform/DragImage.h:
11:42 AM Changeset in webkit [217726] by fred.wang@free.fr
  • 6 edits
    7 adds in trunk

[Mac] Use compositing for frames when ScrollingTreeIncludesFrames=true
​https://bugs.webkit.org/show_bug.cgi?id=172851

Patch by Frederic Wang <​fwang@igalia.com> on 2017-06-02
Reviewed by Simon Fraser.

Source/WebCore:

When fast frame scrolling is supported on mac (bug 171667), scrollable frames will require
special composited layer. This commit enables that on mac but only when
ScrollingTreeIncludesFrames=true, so that the default behavior is unchanged.

Test: compositing/iframes/compositing-for-scrollable-iframe.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame): Do not enable frame
compositing when ScrollingTreeIncludesFrames=false.
Rename ScrollableInnerFrameTrigger to ScrollableNonMainFrameTrigger.

  • page/ChromeClient.h: Rename ScrollableInnerFrameTrigger.

Source/WebKit2:

When fast frame scrolling is supported on mac (bug 171667), scrollable frames will require
special composited layer. This commit enables that on mac but only when
ScrollingTreeIncludesFrames=true, so that the default behavior is unchanged.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Make scrollable inner frame trigger

compositing on Mac by default. This is ignored on mac when ScrollingTreeIncludesFrames=false.
Rename ScrollableInnerFrameTrigger to ScrollableNonMainFrameTrigger.

LayoutTests:

This commit adds a test to check whether scrollable iframes require a special composited
layer when ScrollingTreeIncludesFrames=true. This is currently only done on Mac WK2.

  • compositing/iframes/compositing-for-scrollable-iframe.html: Added. This is a basic test

printing the layer tree of a page with an iframe.

  • platform/ios-simulator/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
  • platform/mac/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
  • platform/mac-wk1/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Added.
11:38 AM Changeset in webkit [217725] by Alan Bujtas
  • 13 edits
    1 add in trunk

Allow clients to override viewport size for CSS viewport units.
​https://bugs.webkit.org/show_bug.cgi?id=172838
<rdar://problem/32523441>

Reviewed by Tim Horton.

Source/WebKit2:

This enables auto-sizing clients to ensure that styles relative to the viewport are
resolved to a set value (presumably the size of the container) as opposed to the preferred
document size (which is set as the FrameView size).

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _viewportSizeForCSSViewportUnits]):
(-[WKWebView _setViewportSizeForCSSViewportUnits:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setViewportSizeForCSSViewportUnits):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::viewportSizeForCSSViewportUnits):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):
(WebKit::WebPage::setViewportSizeForCSSViewportUnits):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::viewportSizeForCSSViewportUnits):

  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.

(TEST):

11:20 AM Changeset in webkit [217724] by Simon Fraser
  • 20 edits in trunk

Get <chrono> out of StdLibExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=172744

Reviewed by Zalan Bujtas.

Source/WebCore:

Only bring in <chrono> and namespace std::literals::chrono_literals when necessary.

  • fileapi/FileReader.cpp:
  • inspector/InspectorOverlay.cpp:
  • loader/CrossOriginPreflightResultCache.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime):

  • page/ResourceUsageThread.cpp:

(WebCore::ResourceUsageThread::threadBody):

  • page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::jettisonExpensiveObjectsOnTopLevelNavigation):

  • platform/network/CacheValidation.cpp:

(WebCore::computeFreshnessLifetimeForHTTPFamily):

  • platform/network/CacheValidation.h:

Source/WebKit2:

Only bring in <chrono> and namespace std::literals::chrono_literals when necessary.

  • NetworkProcess/cache/NetworkCache.cpp:
  • NetworkProcess/cache/NetworkCacheFileSystem.h:
  • NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::computeRecordWorth):

  • Shared/mac/RemoteLayerBackingStoreCollection.mm:
  • WebProcess/Cookies/WebCookieManager.h:

Source/WTF:

We hates std::chrono. Don't include it everywhere to discourage use.

  • wtf/StdLibExtras.h:

Tools:

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
11:14 AM Changeset in webkit [217723] by aestes@apple.com
  • 12 edits
    2 adds in trunk

[Cocoa] Add a "supportedCountries" property to ApplePayPaymentRequest
​https://bugs.webkit.org/show_bug.cgi?id=172832
<rdar://problem/30735544>

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePaySessionV3.html

  • Modules/applepay/ApplePayPaymentRequest.h:
  • Modules/applepay/ApplePayPaymentRequest.idl:
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

  • Modules/applepay/PaymentRequest.h:

(WebCore::PaymentRequest::supportedCountries):
(WebCore::PaymentRequest::setSupportedCountries):

  • Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):

  • platform/spi/cocoa/PassKitSPI.h:

Source/WebKit2:

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<PaymentRequest>::encode):
(IPC::ArgumentCoder<PaymentRequest>::decode):

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toNSSet):
(WebKit::toPKPaymentRequest):

LayoutTests:

  • http/tests/ssl/applepay/ApplePaySessionV3-expected.txt: Added.
  • http/tests/ssl/applepay/ApplePaySessionV3.html: Added.
  • platform/mac-wk2/TestExpectations:
10:58 AM Changeset in webkit [217722] by fpizlo@apple.com
  • 7 edits in trunk

Atomics.load and Atomics.store need to be fully fenced
​https://bugs.webkit.org/show_bug.cgi?id=172844

Reviewed by Keith Miller.

Source/JavaScriptCore:

Implement fully fenced loads and stores in FTL using AtomicXchgAdd(0, ptr) for the load and
AtomicXchg(value, ptr) for the store.

DFG needed no changes because it implements all atomics using a CAS loop.

AtomicsObject.cpp now uses new Atomic<> API for fully fences loads and stores.

Prior to this change, we used half fences (acquire/release) for atomic loads and stores. This
is not correct according to my current understanding of the SAB memory model, which requires
that atomic operations are SC with respect to everything not just other atomics.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::atomicWeakCAS):

  • ftl/FTLOutput.h:
  • runtime/AtomicsObject.cpp:

Source/WTF:

Add loadFullyFenced and storeFullyFenced to Atomic<>.

  • wtf/Atomics.h:

(WTF::Atomic::loadFullyFenced):
(WTF::Atomic::storeRelaxed):
(WTF::Atomic::storeFullyFenced):
(WTF::atomicLoadFullyFenced):
(WTF::atomicStoreFullyFenced):

Websites/webkit.org:

Update documentation to say that the canonical way to do fully fenced loads and stores is
AtomicXchgAdd(0, ptr) and AtomicXchg(value, ptr), respectively.

  • docs/b3/intermediate-representation.html:
10:54 AM Changeset in webkit [217721] by Devin Rousso
  • 11 edits
    3 adds in trunk

Web Inspector: Should see active Web Sockets when opening Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=172312

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/websocket/tests/hybi/inspector/before-load.html

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::~WebSocket):
(WebCore::WebSocket::allActiveWebSockets):
(WebCore::WebSocket::allActiveWebSocketsMutex):
(WebCore::WebSocket::channel):
(WebCore::WebSocket::eventTargetInterface):
Add a static set of all WebSocket objects and provide getters to access web socket metadata.

  • Modules/websockets/ThreadableWebSocketChannel.h:

(WebCore::ThreadableWebSocketChannel::isWebSocketChannel):

  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::isWebSocketChannel):
(WebCore::WebSocketChannel::identifier):
(WebCore::WebSocketChannel::clientHandshakeRequest):
(WebCore::WebSocketChannel::serverHandshakeResponse):
(WebCore::WebSocketChannel::handshakeMode):
(WebCore::WebSocketChannel::isType):
Provide getters to access web socket metadata.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):
Loops over the static set of all WebSocket objects and sends events for each to the frontend.

Source/WebInspectorUI:

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.initialize): Removed.
Rework order of agent enable calls to ensure that the main frame is initialized before any
websocket events are dispatched.

  • UserInterface/Models/WebSocketResource.js:

(WebInspector.WebSocketResource.ReadyState):
Change symbol strings in enum for better printing in tests.

LayoutTests:

Test that WebSockets created before the inspector loads are also tracked.

  • http/tests/websocket/tests/hybi/inspector/before-load-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/before-load.html: Added.
  • http/tests/websocket/tests/hybi/inspector/before-load_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

10:01 AM Changeset in webkit [217720] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Xcode] Header postprocessing should be based on the target OS version rather than the builder OS version
​https://bugs.webkit.org/show_bug.cgi?id=172860

Reviewed by Anders Carlsson.

  • Configurations/WebKit.xcconfig: Use TARGET_MAC_OS_X_VERSION_MAJOR
9:47 AM Changeset in webkit [217719] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix linking errors on iOS after r217712.

  • platform/OrientationNotifer.h:

(WebCore::OrientationNotifier::Observer::setNotifier):

9:26 AM Changeset in webkit [217718] by bshafiei@apple.com
  • 2 edits in tags/Safari-604.1.23.0.5/Source/WebCore

Build fix. rdar://problem/32530825

9:25 AM Changeset in webkit [217717] by Ryan Haddad
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, attempt to fix the iOS build after r217711.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::xor32):
(JSC::MacroAssemblerARM64::xor64):

9:20 AM Changeset in webkit [217716] by bshafiei@apple.com
  • 7 edits in tags/Safari-604.1.23.0.5/Source

Versioning.

9:19 AM Changeset in webkit [217715] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Merge r211465.

9:17 AM Changeset in webkit [217714] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.23.0.5

New tag.

9:17 AM Changeset in webkit [217713] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked fast/images/slower-decoding-than-animation-image.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172666

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:08 AM Changeset in webkit [217712] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Crash under OrientationNotifier::Observer::setNotifier()
​https://bugs.webkit.org/show_bug.cgi?id=172847
<rdar://problem/32519127>

Reviewed by Youenn Fablet.

Update OrientationNotifier::Observer::setNotifier() to unregister itself from
its current notifier if it already has one. This is needed because
Internals::setCameraMediaStreamTrackOrientation() may be used to override the
notifier of an observer. If we override the notifier without unregistering
the observer from its previous notifier, then the previous notifier will not
get notified when the observer gets destroyed.

No new tests, already covered by webrtc/video-rotation.html that is currently
failing on some bots.

  • platform/OrientationNotifer.h:

(WebCore::OrientationNotifier::Observer::setNotifier):

8:59 AM Changeset in webkit [217711] by fpizlo@apple.com
  • 27 edits
    1 add in trunk/Source/JavaScriptCore

GC should use scrambled free-lists
​https://bugs.webkit.org/show_bug.cgi?id=172793

Reviewed by Mark Lam.

Previously, our bump'n'pop allocator would use a conventional linked-list for the free-list.
The linked-list would be threaded through free memory, as is the usual convention.

This scrambles the next pointers of that free-list. It also scrambles the head pointer, because
this leads to a more natural fast-path structure and saves one register on ARM64.

The secret with which pointers are scrambled is per-allocator. Allocators choose a new secret
every time they do a sweep-to-pop.

This doesn't change the behavior of the bump part of bump'n'pop, but it does refactor the code
quite a bit. Previously, there were four copies of the allocator fast path: two in
MarkedAllocatorInlines.h, one in MarkedAllocator.cpp, and one in AssemblyHelpers.h. The JIT one
was obviously different-looking, but the other three were almost identical. This moves all of
that logic into FreeList. There are now just two copies of the allocator: FreeListInlines.h and
AssemblyHelpers.h.

This appears to be just as fast as our previously allocator.

(JSC::FreeList::FreeList):
(JSC::FreeList::~FreeList):
(JSC::FreeList::clear):
(JSC::FreeList::initializeList):
(JSC::FreeList::initializeBump):
(JSC::FreeList::contains):
(JSC::FreeList::dump):

  • heap/FreeList.h:

(JSC::FreeList::allocationWillFail):
(JSC::FreeList::originalSize):
(JSC::FreeList::addressOfList):
(JSC::FreeList::offsetOfBlock):
(JSC::FreeList::offsetOfList):
(JSC::FreeList::offsetOfIndex):
(JSC::FreeList::offsetOfPayloadEnd):
(JSC::FreeList::offsetOfRemaining):
(JSC::FreeList::offsetOfOriginalSize):
(JSC::FreeList::FreeList): Deleted.
(JSC::FreeList::list): Deleted.
(JSC::FreeList::bump): Deleted.
(JSC::FreeList::operator==): Deleted.
(JSC::FreeList::operator!=): Deleted.
(JSC::FreeList::operator bool): Deleted.

  • heap/FreeListInlines.h: Added.

(JSC::FreeList::addFreeCell):
(JSC::FreeList::allocate):
(JSC::FreeList::forEach):
(JSC::FreeList::toOffset):
(JSC::FreeList::fromOffset):

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::sweepNextBlock):

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::didConsumeFreeList):
(JSC::MarkedAllocator::tryAllocateWithoutCollecting):
(JSC::MarkedAllocator::tryAllocateIn):
(JSC::MarkedAllocator::allocateSlowCaseImpl):
(JSC::MarkedAllocator::stopAllocating):
(JSC::MarkedAllocator::prepareForAllocation):
(JSC::MarkedAllocator::resumeAllocating):
(JSC::MarkedAllocator::sweep):
(JSC::MarkedAllocator::setFreeList): Deleted.

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::freeList):
(JSC::MarkedAllocator::isFreeListedCell): Deleted.

  • heap/MarkedAllocatorInlines.h:

(JSC::MarkedAllocator::isFreeListedCell):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocate):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::stopAllocating):
(JSC::MarkedBlock::Handle::lastChanceToFinalize):
(JSC::MarkedBlock::Handle::resumeAllocating):
(JSC::MarkedBlock::Handle::zap):
(JSC::MarkedBlock::Handle::sweep):
(JSC::MarkedBlock::Handle::isFreeListedCell):
(JSC::MarkedBlock::Handle::forEachFreeCell): Deleted.

  • heap/MarkedBlock.h:
  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::finishSweepKnowingSubspace):
(JSC::MarkedBlock::Handle::isFreeListedCell): Deleted.

  • heap/Subspace.cpp:

(JSC::Subspace::finishSweep):

  • heap/Subspace.h:
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

  • runtime/JSDestructibleObjectSubspace.cpp:

(JSC::JSDestructibleObjectSubspace::finishSweep):

  • runtime/JSDestructibleObjectSubspace.h:
  • runtime/JSSegmentedVariableObjectSubspace.cpp:

(JSC::JSSegmentedVariableObjectSubspace::finishSweep):

  • runtime/JSSegmentedVariableObjectSubspace.h:
  • runtime/JSStringSubspace.cpp:

(JSC::JSStringSubspace::finishSweep):

  • runtime/JSStringSubspace.h:
  • wasm/js/JSWebAssemblyCodeBlockSubspace.cpp:

(JSC::JSWebAssemblyCodeBlockSubspace::finishSweep):

  • wasm/js/JSWebAssemblyCodeBlockSubspace.h:
8:18 AM Changeset in webkit [217710] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed WPE gardening.

  • platform/wpe/TestExpectations: Add a few test failure expectations.
  • platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Rebaseline.
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt: Ditto.
4:35 AM Changeset in webkit [217709] by jfernandez@igalia.com
  • 7 edits
    2 adds in trunk

[css-grid] Logical margin incorrectly applied during the tracks sizing algorithm of auto tracks
​https://bugs.webkit.org/show_bug.cgi?id=172836

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

When computing min-content and max-content of the content-sized tracks
we are using the marginIntrinsicLogicalWidthForChild function, which
uses the grid's writing-mode to determine wether to use the child's
margin width or height. This is not correct when the grid item is
orthogonal.

This patch changes how we compute the tracks width so we use always
the item's marginLogicalWidth, which depends only on its own writing
mode.

Test: fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild):

LayoutTests:

Test to verify different cases of auto-sized tracks and orthogonal items with margins.

  • fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows-expected.txt: Added.
  • fast/css-grid-layout/grid-track-sizing-with-margins-and-orthogonal-flows.html: Added.
3:18 AM Changeset in webkit [217708] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Invalidate the shadow subtree style when slotted pseudo rules are present.
​https://bugs.webkit.org/show_bug.cgi?id=172822

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-06-02
Reviewed by Antti Koivisto.

No new tests, this is tested by
fast/shadow-dom/css-scoping-slot-with-id.html, once we don't force an
Inherit style change for slots. I could add some more tests for stuff
with descendant combinators and similar I guess, though.

  • style/AttributeChangeInvalidation.cpp:

(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):

  • style/ClassChangeInvalidation.cpp:

(WebCore::Style::ClassChangeInvalidation::invalidateStyle):

  • style/IdChangeInvalidation.cpp:

(WebCore::Style::IdChangeInvalidation::invalidateStyle):

2:57 AM Changeset in webkit [217707] by yoon@igalia.com
  • 5 edits in trunk/Source/WebKit2

REGRESSION(r217214): [Coordinated Graphics] UpdateAtlas didn't released while resetting testrunner
​https://bugs.webkit.org/show_bug.cgi?id=172746

Reviewed by Žan Doberšek.

After clearing update atlases in CompositingCoordinator, we should
release update atlases at the compositing thread, too.

We cannot remove update atlases from the CoordinatedGraphicsScene
without regard to update scheduling, since previously committed scene
states can try to use already released update atlases.
To prevent this timing problem, releasing update atlases should be done
with a update scheduler.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::syncRemoteContent):
(WebKit::CoordinatedGraphicsScene::appendUpdate):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:

Use WTF::Function instead of std::function

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::ThreadedCompositor::flushPendingLayerChanges):
Release UpdateAtlases at the end of compositing states update, too.
(WebKit::CompositingCoordinator::clearUpdateAtlases):

2:18 AM Changeset in webkit [217706] by magomez@igalia.com
  • 6 edits in trunk/Source/WebCore

[GTK+][WPE] Allow TextureMapperShaderProgram to perform colorspace conversions with the source texture pixels
​https://bugs.webkit.org/show_bug.cgi?id=172749

Reviewed by Žan Doberšek.

Currently TextureMapperGL is only able to paint properly textures that are in RGBA format. There are
situations where we will want it to be able to handle other formats (for example BGRA for gstreamer-gl).
To make this possible without having to perform the color conversion in the CPU, we add a new color
conversion matrix to TextureMapperShaderProgram. This matrix will perform the color space conversion
in the GPU, just after sampling the source texture.

Also, add a new flag to TextureMapperGL to indicate that a color conversion is required to handle a
texture. This flag will be set to the TextureMapperPlatformLayerBuffers as required, and TextureMapperGL
will set the appropriate color space matrix to the shader. Initially only the flag for BGRA->RGBA conversion
is defined, but support for new transformations can be added as needed.

VideoTextureCopierGStreamer also uses the TextureMapperShaderProgram to perform texture sampling, but for
the moment it just sets an identity matrix because when using gstreamer-gl, the format of the video frames
is RGBA. This will be changed soon to use BGRA.

No new tests.

  • platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:

(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::colorSpaceMatrixForFlags):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:
  • platform/graphics/texmap/TextureMapperShaderProgram.h:
2:08 AM Changeset in webkit [217705] by jfernandez@igalia.com
  • 9 edits
    2 adds in trunk

[css-grid] Margin wrong applied when stretching an orthogonal item in fixed size track
​https://bugs.webkit.org/show_bug.cgi?id=172590

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

All the test cases of these tests pass with this change, so updating their expectations accordingly.

  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-006-expected.txt:
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-lr-006-expected.txt:
  • web-platform-tests/css/css-grid-1/alignment/grid-self-alignment-stretch-vertical-rl-006-expected.txt:

Source/WebCore:

We need to consider orthogonality when using the item's logical margin to
compute the available space for stretching.

The issue this patch fixes is only reproducible when the grid layout logic
is executed several times, since probably the item doesn't need to be
laid out again. In such cases, we just get the cached logical margins
but we were not taking orthogonality into account.

Test: fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::marginLogicalSizeForChild):
(WebCore::RenderGrid::availableAlignmentSpaceForChildBeforeStretching):

  • rendering/RenderGrid.h:

LayoutTests:

  • TestExpectations: 2 tests pass now but 3 more fail because of bug #172836
  • fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts-expected.html: Added.
  • fast/css-grid-layout/grid-item-stretching-must-not-depend-on-previous-layouts.html: Added.
12:52 AM Changeset in webkit [217704] by zandobersek@gmail.com
  • 5 edits
    1 add in trunk

[WPE] Enable SUBTLE_CRYPTO
​https://bugs.webkit.org/show_bug.cgi?id=172756

Reviewed by Michael Catanzaro.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
  • wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
  • wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents

exhausting entropy when running the crypto layout tests.

LayoutTests:

  • platform/wpe/TestExpectations: Enable tests under crypto/ and

imported/w3c/web-platform-tests/WebCryptoAPI/ in general, but add
the test expectations for failing tests under those directories.

12:47 AM Changeset in webkit [217703] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Use @globalPrivate for concatSlowPath
​https://bugs.webkit.org/show_bug.cgi?id=172802

Reviewed by Darin Adler.

Use @globalPrivate instead of manually putting it to JSGlobalObject.

  • builtins/ArrayPrototype.js:

(concatSlowPath): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

Note: See TracTimeline for information about the timeline view.