Context Navigation

← Previous Period
Next Period →

Timeline

Dec 6, 2017:

11:37 PM Changeset in webkit [225622] by Chris Dumez

23 edits
3 adds in trunk

We should be able to recover after a Service Worker process crash
https://bugs.webkit.org/show_bug.cgi?id=180477

Reviewed by Brady Eidson and Youenn Fablet.

Source/WebCore:

Test: http/tests/workers/service/postmessage-after-sw-process-crash.https.html

workers/service/server/SWServer.cpp:

(WebCore::SWServer::serverToContextConnectionCreated):
Once the connection with the context process is established, process "run service worker"
requests that ocurred while establishing the connection.

(WebCore::SWServer::runServiceWorkerIfNecessary):
Take in a lambda function that gets called after the "run service worker" request
is processed. We used to assert that we had a connection to the context process.
We now wait for the connection to be established to process the request, thus
making the operation asynchronous.

(WebCore::SWServer::runServiceWorker):
Split some logic out of runServiceWorkerIfNecessary() to reuse in serverToContextConnectionCreated().

(WebCore::SWServer::markAllWorkersAsTerminated):
Add method to mark all service workers as terminated. This is called when the Service
Worker process crashes.

workers/service/server/SWServer.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker):
Update calls to SWServer::runServiceWorkerIfNecessary() that that it is asynchronous
and takes in a lambda.

StorageProcess/ServiceWorker/WebSWServerConnection.h:

(WebKit::WebSWServerConnection::ipcConnection const):
Add getter for the underlying IPC connection.

StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::didClose):
(WebKit::StorageProcess::connectionToContextProcessWasClosed):
Move some code to connectionToContextProcessWasClosed() to avoid duplication.
Also, relaunch the Service Worker process if it has exited but we still
have SWServer connections to regular Web Processes.

(WebKit::StorageProcess::needsServerToContextConnection const):
Utility function to determine if we still need the service worker process.
The current rule is that we need the service worker (aka "context") process
if we still have SWServer connections to regular Web Processes.

StorageProcess/StorageProcess.h:

StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didClose):
If didClose() is called for the connection to the service worker context,
let the StorageProcess know so that it can clear its state and relaunch
the process if necessary.

UIProcess/API/C/WKContext.cpp:

(WKContextTerminateServiceWorkerProcess):

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _terminateServiceWorkerProcess]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

Add SPI to terminate the service worker process.

UIProcess/WebProcessPool.cpp:

(WebKit::m_serviceWorkerProcessTerminationTimer):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::terminateServiceWorkerProcess):

UIProcess/WebProcessPool.h:

We used to shutdown the ServiceWorker process right away as soon as the last regular
WebProcess was gone. We now give it a grace period of 5 seconds in case a new
WebProcess gets launched shortly after.

Tools:

Add testRunner API to terminate the Service Worker process.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::terminateServiceWorkerProcess):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::terminateServiceWorkerProcess):

WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Add layout test coverage.

http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt: Added.
http/tests/workers/service/postmessage-after-sw-process-crash.https.html: Added.
http/tests/workers/service/resources/postmessage-after-sw-process-crash.js: Added.

10:47 PM Changeset in webkit [225621] by sbarati@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Fix iOS (and maybe other platform) build

workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::openSQLiteDatabase):

10:10 PM Changeset in webkit [225620] by mark.lam@apple.com

23 edits
4 moves in trunk/Source

Refactoring: Rename ScrambledPtr to Poisoned.
https://bugs.webkit.org/show_bug.cgi?id=180514

Reviewed by Saam Barati.

Source/JavaScriptCore:

API/JSCallbackObject.h:
API/JSObjectRef.cpp:

(classInfoPrivate):

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
assembler/MacroAssemblerCodeRef.h:

(JSC::FunctionPtr::FunctionPtr):
(JSC::FunctionPtr::value const):
(JSC::FunctionPtr::executableAddress const):
(JSC::ReturnAddressPtr::ReturnAddressPtr):
(JSC::ReturnAddressPtr::value const):
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):
(JSC::MacroAssemblerCodePtr::poisonedPtr const):
(JSC::MacroAssemblerCodePtr:: const):
(JSC::MacroAssemblerCodePtr::operator! const):
(JSC::MacroAssemblerCodePtr::operator== const):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtr::scrambledPtr const): Deleted.

b3/B3LowerMacros.cpp:
b3/testb3.cpp:

(JSC::B3::testInterpreter):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewStringObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateDestructibleObject):

jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadArgumentWithSpecificClass):

jit/ThunkGenerators.cpp:

(JSC::virtualThunkFor):
(JSC::boundThisNoArgsFunctionCallGenerator):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):

llint/LowLevelInterpreter64.asm:
runtime/InitializeThreading.cpp:

(JSC::initializeThreading):

runtime/JSCPoisonedPtr.cpp: Copied from Source/JavaScriptCore/runtime/JSCScrambledPtr.cpp.

(JSC::initializePoison):
(JSC::initializeScrambledPtrKeys): Deleted.

runtime/JSCPoisonedPtr.h: Copied from Source/JavaScriptCore/runtime/JSCScrambledPtr.h.
runtime/JSCScrambledPtr.cpp: Removed.
runtime/JSCScrambledPtr.h: Removed.
runtime/JSDestructibleObject.h:

(JSC::JSDestructibleObject::classInfo const):

runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::classInfo const):

runtime/Structure.h:
runtime/VM.h:

Source/WTF:

We're switching our nomenclature to "poisoning" instead of "scrambling" pointers.
This allows us to use shorter names.

This patch is almost purely refactoring, except for one change: the PoisonedImpl
template class (previously ScrambledPtr) has been modified to allow usage of
a constexpr uint32_t poison value (see Int32Poisoned) in addition to a runtime
determined uintptr_t poison value (see Poisoned).

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Poisoned.cpp: Copied from Source/WTF/wtf/ScrambledPtr.cpp.

(WTF::makePoison):
(WTF::makeScrambledPtrKey): Deleted.

wtf/Poisoned.h: Copied from Source/WTF/wtf/ScrambledPtr.h.

(WTF::PoisonedImpl::PoisonedImpl):
(WTF::PoisonedImpl::assertIsPoisoned const):
(WTF::PoisonedImpl::assertIsNotPoisoned const):
(WTF::PoisonedImpl::unpoisoned const):
(WTF::PoisonedImpl::operator-> const):
(WTF::PoisonedImpl::bits const):
(WTF::PoisonedImpl::operator! const):
(WTF::PoisonedImpl::operator bool const):
(WTF::PoisonedImpl::operator== const):
(WTF::PoisonedImpl::operator==):
(WTF::PoisonedImpl::operator=):
(WTF::PoisonedImpl::poison):
(WTF::PoisonedImpl::unpoison):
(WTF::ScrambledPtr::ScrambledPtr): Deleted.
(WTF::ScrambledPtr::assertIsScrambled const): Deleted.
(WTF::ScrambledPtr::assertIsNotScrambled const): Deleted.
(WTF::ScrambledPtr::descrambled const): Deleted.
(WTF::ScrambledPtr::operator-> const): Deleted.
(WTF::ScrambledPtr::bits const): Deleted.
(WTF::ScrambledPtr::operator! const): Deleted.
(WTF::ScrambledPtr::operator bool const): Deleted.
(WTF::ScrambledPtr::operator== const): Deleted.
(WTF::ScrambledPtr::operator==): Deleted.
(WTF::ScrambledPtr::operator=): Deleted.
(WTF::ScrambledPtr::scramble): Deleted.
(WTF::ScrambledPtr::descramble): Deleted.

wtf/ScrambledPtr.cpp: Removed.
wtf/ScrambledPtr.h: Removed.

9:39 PM Changeset in webkit [225619] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari 11.0.2

Added a tag for Safari 11.0.2.

8:06 PM Changeset in webkit [225618] by Darin Adler

90 edits
1 copy
1 add in trunk

Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
https://bugs.webkit.org/show_bug.cgi?id=180009

Reviewed by Alex Christensen.

Source/JavaScriptCore:

bytecode/ArrayProfile.cpp: Removed include of StringExtras.h.
bytecode/CodeBlock.cpp: Ditto.
bytecode/ExecutionCounter.cpp: Ditto.
runtime/ConfigFile.cpp: Ditto.
runtime/DatePrototype.cpp: Ditto.
runtime/IndexingType.cpp: Ditto.
runtime/JSCJSValue.cpp: Ditto.
runtime/JSDateMath.cpp: Ditto.
runtime/JSGlobalObjectFunctions.cpp: Ditto.
runtime/Options.cpp: Ditto.

(JSC::parse): Use equalLettersIgnoringASCIICase instead of strcasecmp.

Source/WebCore:

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeAsStream): Update to use size since the result of
encode is now Vector rather than CString. And for the new UnencodableHandling.
(WebCore::FetchBody::consumeText): Removed now-unneeded type cast. Ditto.
(WebCore::FetchBody::bodyAsFormData const): Ditto.
(WebCore::FetchBody::take): Pass result of encode directly to SharedBuffer::create.

Modules/websockets/WebSocketDeflater.cpp: Removed include of StringExtras.h.
bridge/IdentifierRep.h: Ditto.
bridge/c/c_instance.cpp: Ditto.

fileapi/BlobBuilder.cpp:

(WebCore::BlobBuilder::append): Updated for CString to Vector change and
for UnencodableHandling.

html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset): Call the decode function
with all the arguments since there is only one decode function now.

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::computeContentSecurityPolicySHA256Hash): Updated for CString to Vector
change and for UnencodableHandling.

loader/ResourceCryptographicDigest.cpp:

(WebCore::cryptographicDigestForBytes): Changed argument type to const void*.

loader/ResourceCryptographicDigest.h: Ditto.

loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::TextResourceDecoder): Moved initialization of data
members to class definition.
(WebCore::TextResourceDecoder::create): Moved function body here from the header.
(WebCore::TextResourceDecoder::setEncoding): Use equalLettersIgnoringASCIICase.
(WebCore::TextResourceDecoder::shouldAutoDetect const): Updated for name change
to m_parentFrameAutoDetectedEncoding, which obviates a comment.
(WebCore::TextResourceDecoder::flush): Ditto.

loader/TextResourceDecoder.h: Moved initialization here from constructor.

Moved function bodies out of the class. Renamed m_hintEncoding to
m_parentFrameAutoDetectedEncoding since that is a more accurate description.

loader/appcache/ApplicationCacheStorage.cpp: Removed include of StringExtras.h.
page/FrameTree.cpp: Ditto.
page/PageSerializer.cpp: Ditto.

(WebCore::PageSerializer::serializeFrame): Pass result of encode directly to
StringBuffer::create and update for UnencodableHandling.
(WebCore::PageSerializer::serializeCSSStyleSheet): Ditto.

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::findHashOfContentInPolicies const): Ditto.

platform/FileHandle.cpp: Removed include of StringExtras.h.

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::create): Added an overload that takes Vector<uint8_t>.

platform/SharedBuffer.h: Ditto.

platform/URLParser.cpp:

(WebCore::URLParser::encodeQuery): Updated since encode returns a Vector instead
of a CString now and for UnencodableHandling.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Ditto.

platform/graphics/ca/PlatformCALayer.cpp: Removed include of StringExtras.h.

platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::handleDataURL): Updated for Vector instead
of CString.

platform/network/FormData.cpp:

(WebCore::FormData::create): Added new overload, and simplified some existing ones.
(WebCore::normalizeStringData): Changed return type to Vector<uint8_t> and updated
for UnencodableHandling.
(WebCore::FormData::appendMultiPartStringValue): Updated for change in type of
result of normalizeStringData.

platform/network/FormData.h: Updated for the above and updated comments.

platform/network/FormDataBuilder.cpp: Made this a namespace instead of a class.

(WebCore::FormDataBuilder::append): Added an overload for Vector<uint8_t>.
(WebCore::FormDataBuilder::appendQuoted): Renamed from appendQuotedString and
changed the argument type.
(WebCore::FormDataBuilder::appendFormURLEncoded): Moved logic up from the
encodeStringAsFormData function into a new separate helper.
(WebCore::FormDataBuilder::addFilenameToMultiPartHeader): Updated for change to
UnencodableHandling.
(WebCore::FormDataBuilder::beginMultiPartHeader): Changed argument type.
(WebCore::FormDataBuilder::addKeyValuePairAsFormData): Ditto.
(WebCore::FormDataBuilder::encodeStringAsFormData): Updated to call helper.

platform/network/FormDataBuilder.h: Updated for the above.

platform/text/DecodeEscapeSequences.h: Use Vector<uint8_t> instead of

Vector<char>, also updated the code that calls encode for the new return type
and updated for change to UnencodableHandler.

platform/text/TextCodec.cpp:

(WebCore::TextCodec::getUnencodableReplacement): Updated since we are using
std::array now, so the out argument is easier to understand, also updated for
change to UnencodablaHandler.

platform/text/TextCodec.h: Use std::array for the UnencodableReplacementArray

type, removed the overload of decode so there is only one decode function.

platform/text/TextCodecICU.cpp:

(WebCore::ICUConverterWrapper::~ICUConverterWrapper): Deleted.
Not needed any more since we use ICUConverterPtr instead now.
(WebCore::cachedConverterICU): Deleted.
(WebCore::TextCodecICU::create): Deleted. Callers just use make_unique
directly now.
(WebCore::TextCodecICU::registerCodecs): Rewrote to use lambdas instead
of functions with void* pointers.
(WebCore::TextCodecICU::TextCodecICU): Moved initializers into the header.
(WebCore::TextCodecICU::~TextCodecICU): Moved the body of releaseICUConverter
in here. Also greatly simplified it now that ICUConverterPtr handles closing
it as needed.
(WebCore::TextCodecICU::releaseICUConverter const): Deleted.
(WebCore::TextCodecICU::createICUConverter const): Rewrote to simplfy now that
we can use ICUConverterPtr.
(WebCore::ErrorCallbackSetter::ErrorCallbackSetter): Take a reference instead
of a pointer.
(WebCore::ErrorCallbackSetter::~ErrorCallbackSetter): Ditto.
(WebCore::TextCodecICU::decode): Use equalLettersIgnoringASCIICase instead of
strcasecmp.
(WebCore::TextCodecICU::encode): Return a Vector instead of a CString.
Take a StringView instead of a pointer and length. Simplified
the backslash-as-currency-symbol code by using String::replace.

platform/text/TextCodecICU.h: Updated for above. Fixed indentation.

Added a new ICUConverterPtr typedef that uses std::unique_ptr to close the
converter; combined with move semantics it simplifies things so we don't have
to be so careful about calling ucnv_close.

platform/text/TextCodecLatin1.cpp: Renamed the Latin-1 to Unicode table from

"table" to latin1ConversionTable.
(WebCore::TextCodecLatin1::registerCodecs): Use a lambda.
(WebCore::encodeComplexWindowsLatin1): Return a Vector instad of CString.
Also use StringView::codePoints instead of our own U16_NEXT.
(WebCore::TextCodecLatin1::encode): More of the same.

platform/text/TextCodecLatin1.h: Updated for the above.

platform/text/TextCodecReplacement.cpp:

(WebCore::TextCodecReplacement::create): Deleted.
(WebCore::TextCodecReplacement::TextCodecReplacement): Deleted.
(WebCore::TextCodecReplacement::registerCodecs): Use a lambda.

platform/text/TextCodecReplacement.h: Updated for the above.

platform/text/TextCodecUTF16.cpp:

(WebCore::newStreamingTextDecoderUTF16LE): Deleted.
(WebCore::newStreamingTextDecoderUTF16BE): Deleted.
(WebCore::TextCodecUTF16::registerCodecs): Use lambdas.
(WebCore::TextCodecUTF16::encode): Return a Vector.

platform/text/TextCodecUTF16.h: Updated for the above.

platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::registerCodecs): Use a lambda.
(WebCore::TextCodecUTF8::encode): Return a Vector.

platform/text/TextCodecUTF8.h: Updated for the above.

platform/text/TextCodecUserDefined.cpp:

(WebCore::newStreamingTextDecoderUserDefined): Deleted.
(WebCore::TextCodecUserDefined::registerCodecs): Use a lambda.
(WebCore::encodeComplexUserDefined): Return a Vector.
(WebCore::TextCodecUserDefined::encode): Ditto.

platform/text/TextCodecUserDefined.h: Updated for the above.

platform/text/TextEncoding.cpp: Changed TextCodecMap to just hold a

WTF::Function instead of holding a function and an additional data pointer.
(WebCore::TextEncoding::TextEncoding): Use equalLettersIgnoringASCIICase
instead of a special isReplacementEncoding function.
(WebCore::TextEncoding::encode const): Return a Vector instead of a CString.
Pass StringView instead of a pointer and length.

platform/text/TextEncoding.h: Updated for the above.

platform/text/TextEncodingRegistry.cpp:

(WebCore::addToTextCodecMap): Removed the additionalData pointer and used
WTFMove since NewTextCodecFunction is now a WTF::Function rather than a C
function pointer.
(WebCore::isReplacementEncoding): Deleted.
(WebCore::newTextCodec): Use find instead of get now that the fucntions in
the map are WTF::Function and can't be copied.
(WebCore::dumpTextEncodingNameMap): Deleted.

platform/text/TextEncodingRegistry.h: Updated for the above.

platform/text/win/TextCodecWin.cpp:

(WebCore::TextCodecWin::encode): Updated comment.

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send): Updated for change to UnencodableHandling.

xml/XSLTUnicodeSort.cpp: Removed include of StringExtras.h.
xml/parser/XMLDocumentParser.cpp: Ditto.
xml/parser/XMLDocumentParserLibxml2.cpp: Ditto.

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj: Added UnencodableHandling.h.
pal/text/UnencodableHandling.h: Moved the UnencodableHandling enumeration

here from TextCodec.h and changed it to an enum class.

Source/WebKit:

WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::initializeProtectionSpace): Use equalLettersIgnoringASCIICase instead
of strcasecmp.

Source/WebKitLegacy/mac:

History/HistoryPropertyList.mm: Removed include of StringExtras.h.

Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
of strcasecmp.

WebView/WebPreferences.mm:

(contains): Ditto. Also made this a template so it's easier to call on an array.
(cacheModelForMainBundle): Take advantage of the above to make it cleaner.

Source/WTF:

wtf/Assertions.cpp: Removed include of StringExtras.h.

(WTFLogChannelByName): Use equalIgnoringASCIICase instead of strcasecmp.

wtf/DateMath.cpp: Removed include of StringExtras.h.
wtf/MD5.cpp: Ditto. Also removed include of CString.h.
wtf/SHA1.cpp: Ditto.

wtf/StringExtras.h:

(strncasecmp): Deleted.
(strcasecmp): Deleted.

wtf/StringPrintStream.cpp: Removed include of StringExtras.h.
wtf/text/Base64.cpp: Ditto.

wtf/text/LineEnding.cpp:

(WTF::normalizeLineEndingsToLF): Replaced old more general purpose function with
this. Changed argument type to vector and used an rvalue reference and return value.
Also fixed some small logic errors.
(WTF::normalizeLineEndingsToCRLF): Ditto.
(WTF::normalizeLineEndingsToNative): Updated for above changes.

wtf/text/LineEnding.h: Updated for above changes.

wtf/text/StringCommon.h:

(WTF::equalIgnoringASCIICase): Added overload for const char*.
(WTF::equalLettersIgnoringASCIICase): Ditto.

wtf/text/TextStream.cpp: Removed include of StringExtras.h.
wtf/text/WTFString.cpp: Ditto.
wtf/unicode/icu/CollatorICU.cpp: Ditto.

Tools:

DumpRenderTree/cg/PixelDumpSupportCG.cpp: Removed include of StringExtras.h.

TestWebKitAPI/CMakeLists.txt: Added LineEnding.cpp.
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
TestWebKitAPI/Tests/WTF/LineEnding.cpp: Added. Has tests for the LineEnding

functions rewritten in this patch.

TestWebKitAPI/Tests/WebCore/TextCodec.cpp: Updated test now that the decode

function doesn't have defaults for as many arguments any more. Also changed so
that the tests log the fact that the decode function returns an error and updated
expected results to expect all the errors.

WebKitTestRunner/cg/TestInvocationCG.cpp: Ditto.

7:52 PM Changeset in webkit [225617] by Yusuke Suzuki

11 edits in trunk/Source/WTF

[WTF] Remove XXXLockBase since constexpr constructor can initialize static variables without calling global constructors
https://bugs.webkit.org/show_bug.cgi?id=180495

Reviewed by Mark Lam.

Very nice feature of C++11 is that constexpr constructor can initialize static global variables
without calling global constructors. We do not need to have XXXLockBase with derived XXXLock
class since StaticXXXLock can have constructors as long as it is constexpr.
We remove bunch of these classes, and set XXXLock() = default; explicitly for readability.
C++11's default constructor is constexpr as long as its member's default constructor / default
initializer is constexpr.

wtf/Condition.h:

(WTF::ConditionBase::construct): Deleted.
(WTF::ConditionBase::waitUntil): Deleted.
(WTF::ConditionBase::waitFor): Deleted.
(WTF::ConditionBase::wait): Deleted.
(WTF::ConditionBase::notifyOne): Deleted.
(WTF::ConditionBase::notifyAll): Deleted.
(WTF::Condition::Condition): Deleted.

wtf/CountingLock.h:

(WTF::CountingLock::CountingLock): Deleted.
(WTF::CountingLock::~CountingLock): Deleted.

wtf/Lock.cpp:

(WTF::Lock::lockSlow):
(WTF::Lock::unlockSlow):
(WTF::Lock::unlockFairlySlow):
(WTF::Lock::safepointSlow):
(WTF::LockBase::lockSlow): Deleted.
(WTF::LockBase::unlockSlow): Deleted.
(WTF::LockBase::unlockFairlySlow): Deleted.
(WTF::LockBase::safepointSlow): Deleted.

wtf/Lock.h:

(WTF::LockBase::construct): Deleted.
(WTF::LockBase::lock): Deleted.
(WTF::LockBase::tryLock): Deleted.
(WTF::LockBase::try_lock): Deleted.
(WTF::LockBase::unlock): Deleted.
(WTF::LockBase::unlockFairly): Deleted.
(WTF::LockBase::safepoint): Deleted.
(WTF::LockBase::isHeld const): Deleted.
(WTF::LockBase::isLocked const): Deleted.
(WTF::LockBase::isFullyReset const): Deleted.
(WTF::Lock::Lock): Deleted.

wtf/ReadWriteLock.cpp:

(WTF::ReadWriteLock::readLock):
(WTF::ReadWriteLock::readUnlock):
(WTF::ReadWriteLock::writeLock):
(WTF::ReadWriteLock::writeUnlock):
(WTF::ReadWriteLockBase::construct): Deleted.
(WTF::ReadWriteLockBase::readLock): Deleted.
(WTF::ReadWriteLockBase::readUnlock): Deleted.
(WTF::ReadWriteLockBase::writeLock): Deleted.
(WTF::ReadWriteLockBase::writeUnlock): Deleted.

wtf/ReadWriteLock.h:

(WTF::ReadWriteLock::read):
(WTF::ReadWriteLock::write):
(WTF::ReadWriteLockBase::ReadLock::tryLock): Deleted.
(WTF::ReadWriteLockBase::ReadLock::lock): Deleted.
(WTF::ReadWriteLockBase::ReadLock::unlock): Deleted.
(WTF::ReadWriteLockBase::WriteLock::tryLock): Deleted.
(WTF::ReadWriteLockBase::WriteLock::lock): Deleted.
(WTF::ReadWriteLockBase::WriteLock::unlock): Deleted.
(WTF::ReadWriteLockBase::read): Deleted.
(WTF::ReadWriteLockBase::write): Deleted.
(WTF::ReadWriteLock::ReadWriteLock): Deleted.

wtf/RecursiveLockAdapter.h:

(WTF::RecursiveLockAdapter::RecursiveLockAdapter): Deleted.

wtf/WordLock.cpp:

(WTF::WordLock::lockSlow):
(WTF::WordLock::unlockSlow):
(WTF::WordLockBase::lockSlow): Deleted.
(WTF::WordLockBase::unlockSlow): Deleted.

wtf/WordLock.h:

(WTF::WordLockBase::lock): Deleted.
(WTF::WordLockBase::unlock): Deleted.
(WTF::WordLockBase::isHeld const): Deleted.
(WTF::WordLockBase::isLocked const): Deleted.
(WTF::WordLockBase::isFullyReset const): Deleted.
(WTF::WordLock::WordLock): Deleted.

wtf/WorkQueue.cpp:

7:36 PM Changeset in webkit [225616] by commit-queue@webkit.org

16 edits
1 copy
1 move
6 adds
1 delete in trunk

Support the decoding="sync/async" syntax for image async attribute
https://bugs.webkit.org/show_bug.cgi?id=179432

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-12-06
Reviewed by Darin Adler.

Source/WebCore:

Support the HTMLElementImage decoding attribute to allow controlling the
decoding of an image as per:

https://github.com/whatwg/html/pull/3221
https://whatpr.org/html/3221/images.html#decoding-images

Tests: fast/images/decode-decoding-attribute-async-large-image.html

fast/images/decoding-attribute-async-small-image.html
fast/images/decoding-attribute-dynamic-async-small-image.html
fast/images/decoding-attribute-sync-large-image.html

html/HTMLAttributeNames.in:
html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::decodingMode const):

html/HTMLImageElement.h:
html/HTMLImageElement.idl:
platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):

platform/graphics/DecodingOptions.h:

(WebCore::DecodingOptions::DecodingOptions):
(WebCore::DecodingOptions::isAuto const):
(WebCore::DecodingOptions::isAsynchronousCompatibleWith const):
(WebCore::DecodingOptions::isNone const): Deleted.

platform/graphics/ImageDecoder.h:
platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::clearImage):

platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameAtIndexCacheIfNeeded):

platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:
platform/graphics/cg/ImageDecoderCG.h:
platform/graphics/win/ImageDecoderDirect2D.h:
platform/image-decoders/ScalableImageDecoder.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::decodingModeForImageDraw const):
The element attributes and the document settings should be checked before
checking our heuristics. And since the "decoding" attribute is per an image
and isLargeImageAsyncDecodingEnabledForTesting() is a global setting, the
decoding attribute should be checked first.

LayoutTests:

fast/images/async-attribute-with-small-image-expected.html: Removed.
fast/images/async-attribute-with-small-image.html: Removed.
fast/images/decode-decoding-attribute-async-large-image-expected.html: Added.
fast/images/decode-decoding-attribute-async-large-image.html: Added.
fast/images/decoding-attribute-async-small-image-expected.html: Added.
fast/images/decoding-attribute-async-small-image.html: Added.
fast/images/decoding-attribute-dynamic-async-small-image-expected.html: Added.
fast/images/decoding-attribute-dynamic-async-small-image.html: Added.
fast/images/decoding-attribute-sync-large-image-expected.html: Added.
fast/images/decoding-attribute-sync-large-image.html: Added.

7:30 PM Changeset in webkit [225615] by commit-queue@webkit.org

16 edits in trunk/Source

[Web App Manifest] Add SPI for applying a manifest to a top-level browsing context
https://bugs.webkit.org/show_bug.cgi?id=180368
rdar://problem/34748067

Patch by David Quesada <david_quesada@apple.com> on 2017-12-06
Reviewed by Geoffrey Garen.

Source/WebCore:

Support applying a manifest to a top-level browsing context by adding a manifest
property on PageConfiguration to be stored on MainFrame instances created from the
configuration.

No new tests, no change in behavior.

page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame):

page/MainFrame.h:
page/PageConfiguration.h:

Source/WebKit:

Add a new property WKWebViewConfiguration._applicationManifest to specify manifest
to apply to application contexts (aka. top-level browsing contexts, i.e. web views).
The manifest is ultimately stored on the MainFrame of the Pages created from the
web view configuration.

No new tests, no change in behavior.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):
(API::PageConfiguration::applicationManifest const):
(API::PageConfiguration::setApplicationManifest):

UIProcess/API/APIPageConfiguration.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _applicationManifest]):
(-[WKWebViewConfiguration _setApplicationManifest:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
UIProcess/API/Cocoa/_WKApplicationManifestInternal.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

7:23 PM Changeset in webkit [225614] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

AX: Layout test imported/w3c/web-platform-tests/html/syntax/parsing/html5lib_tests1.html flaky crash
https://bugs.webkit.org/show_bug.cgi?id=173540
<rdar://problem/35386393>

Unreviewed test gardening.

r225613 fixed the flaky crash.

Patch by Fujii Hironori <Fujii Hironori> on 2017-12-06

platform/gtk/TestExpectations: Unmarked the test case.

4:55 PM Changeset in webkit [225613] by Alan Bujtas

5 edits in trunk/Source/WebCore

Remove nodes from AXObjectCache when the associated subframe document is getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=180503
<rdar://problem/35891328

Reviewed by Chris Fleizach.

While AXObjectCache lives on the mainframe's document, it caches nodes from every subframe document.
When a node is being destroyed, we deregister it from the AX cache through the Node's destructor.
Soon after the document is detached from the frame/frame is detached from the frame tree, this codepath
is no longer available (no access to the AXObjectCache object) and from this point we are unable to deregister
nodes associated with the current document.
In AXObjectCache::prepareForDocumentDestruction(), we preemptively remove all the cached nodes associated
with the about-to-be-destroyed document.

Covered by existing tests.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::filterForRemoval):
(WebCore::AXObjectCache::prepareForDocumentDestruction): Collecting the nodes and removing them later is
not the most performant way but in order to have a single code path for the de-registration (AXObjectCache::remove)
I think it's worth going down the slower path -which should not really be that slower anyway since those
lists tend to stay small.
(WebCore::AXObjectCache::clearTextMarkerNodesInUse): Deleted.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::remove):

dom/Document.cpp:

(WebCore::Document::prepareForDestruction):

dom/Node.cpp:

(WebCore::Node::willBeDeletedFrom):
(WebCore::Node::moveNodeToNewDocument):

4:49 PM Changeset in webkit [225612] by Matt Lewis

2 edits in trunk/LayoutTests

Adjusted expectations for inspector/worker/resources-in-worker.html.
https://bugs.webkit.org/show_bug.cgi?id=168091

Unreviewed test gardening.

platform/mac/TestExpectations:

4:43 PM Changeset in webkit [225611] by ap@apple.com

2 edits in trunk/Tools

Exclude another leak callstack.

Scripts/webkitpy/port/leakdetector.py: (LeakDetector._callstacks_to_exclude_from_leaks):

4:41 PM Changeset in webkit [225610] by beidson@apple.com

11 edits
2 copies
2 adds in trunk/Source/WebCore

Start writing ServiceWorker registrations to disk.
https://bugs.webkit.org/show_bug.cgi?id=180488

Reviewed by Chris Dumez.

No new tests (No observable behavior change).

As registrations changes occurs, we now write them to disk.
We don't re-read them in yet.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

workers/service/ServiceWorkerRegistrationData.cpp:

(WebCore::ServiceWorkerRegistrationData::isolatedCopy const):

workers/service/ServiceWorkerRegistrationData.h:

(WebCore::ServiceWorkerRegistrationData::encode const):
(WebCore::ServiceWorkerRegistrationData::decode):

workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::toDatabaseKey const):

workers/service/ServiceWorkerRegistrationKey.h:

workers/service/server/RegistrationDatabase.cpp: Added.

(WebCore::v1RecordsTableSchema):
(WebCore::v1RecordsTableSchemaAlternate):
(WebCore::databaseFilename):
(WebCore::RegistrationDatabase::RegistrationDatabase):
(WebCore::RegistrationDatabase::~RegistrationDatabase):
(WebCore::RegistrationDatabase::openSQLiteDatabase):
(WebCore::RegistrationDatabase::ensureValidRecordsTable):
(WebCore::updateViaCacheToString):
(WebCore::workerTypeToString):
(WebCore::RegistrationDatabase::pushChanges):
(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):
(WebCore::RegistrationDatabase::databaseFailedToOpen):
(WebCore::RegistrationDatabase::databaseOpenedAndRecordsImported):

workers/service/server/RegistrationDatabase.h: Copied from Source/WebCore/workers/service/ServiceWorkerRegistrationData.cpp.

(WebCore::RegistrationDatabase::isClosed const):

workers/service/server/RegistrationStore.cpp: Added.

(WebCore::RegistrationStore::RegistrationStore):
(WebCore::RegistrationStore::~RegistrationStore):
(WebCore::RegistrationStore::scheduleDatabasePushIfNecessary):
(WebCore::RegistrationStore::pushChangesToDatabase):
(WebCore::RegistrationStore::updateRegistration):
(WebCore::RegistrationStore::removeRegistration):
(WebCore::RegistrationStore::databaseFailedToOpen):
(WebCore::RegistrationStore::databaseOpenedAndRecordsImported):

workers/service/server/RegistrationStore.h: Copied from Source/WebCore/workers/service/ServiceWorkerRegistrationData.cpp.

workers/service/server/SWServer.cpp:

(WebCore::SWServer::removeRegistration):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::updateWorker):
(WebCore::SWServer::installContextData):

workers/service/server/SWServer.h:

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::data const):

workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::setLastUpdateTime):

4:40 PM Changeset in webkit [225609] by jmarcell@apple.com

7 edits in branches/safari-604.5.100-branch/Source

Versioning.

4:37 PM Changeset in webkit [225608] by jmarcell@apple.com

7 edits in trunk/Source

Versioning.

4:34 PM Changeset in webkit [225607] by jmarcell@apple.com

7 edits in branches/safari-604-branch/Source

Versioning.

4:34 PM Changeset in webkit [225606] by jmarcell@apple.com

3 edits
2 adds in branches/safari-604-branch

Cherry-pick r225497. rdar://problem/34604139

4:32 PM Changeset in webkit [225605] by jmarcell@apple.com

1 copy in tags/Safari-604.5.100.2

Tag Safari-604.5.100.2.

4:28 PM Changeset in webkit [225604] by jmarcell@apple.com

1 copy in tags/Safari-604.5.2

Tag Safari-604.5.2.

4:18 PM Changeset in webkit [225603] by jeffm@apple.com

4 edits in trunk

-[WKWebViewConfiguration copyWithZone] doesn't copy _groupIdentifier
https://bugs.webkit.org/show_bug.cgi?id=180504

Reviewed by Geoffrey Garen.

Source/WebKit:

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
Copy _groupIdentifier.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:

Add a test to verify that the _groupIdentifier is copied.

4:11 PM UpdatingANGLE edited by dino@apple.com

(diff)

4:10 PM UpdatingANGLE edited by dino@apple.com

(diff)

4:02 PM Changeset in webkit [225602] by webkit@devinrousso.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: spurious warnings shown for commands that changed pixel contents
https://bugs.webkit.org/show_bug.cgi?id=180505
<rdar://problem/35891651>

Reviewed by Brian Burg.

UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.apply.getContent):
(WI.RecordingAction.prototype.apply):

3:30 PM Changeset in webkit [225601] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark webgl/1.0.2/conformance/textures/gl-teximage.html as failing again.

Unreviewed test gardening.

platform/ios/TestExpectations:

3:04 PM Changeset in webkit [225600] by webkit@devinrousso.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Style Redesign: filtering removes header if one rule has no match even if others do
https://bugs.webkit.org/show_bug.cgi?id=180467

Reviewed by Timothy Hatcher.

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel.prototype.applyFilter):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionFilterApplied):

3:02 PM Changeset in webkit [225599] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, fix build after r225577.

bindings/js/JSDOMGlobalObject.cpp:

2:26 PM Changeset in webkit [225598] by commit-queue@webkit.org

32 edits
3 copies
9 adds in trunk

[Web App Manifest] Add SPI for fetching the manifest
https://bugs.webkit.org/show_bug.cgi?id=180294
rdar://problem/34747968

Patch by David Quesada <david_quesada@apple.com> on 2017-12-06
Reviewed by Geoffrey Garen.

Source/WebCore:

Test: applicationmanifest/developer-warnings.html

Modules/applicationmanifest/ApplicationManifest.h:

(WebCore::ApplicationManifest::encode const):
(WebCore::ApplicationManifest::decode):

Modules/applicationmanifest/ApplicationManifestParser.cpp:

(WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
(WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):

Drive-by wording changes. Since the warning is prefixed with "parsing
application manifest:", remove a redundant use of "application manifest".

Source/WebKit:

Add a new method -[WKWebView _getApplicationManifestWithCompletionHandler:] to request
the manifest associated with the current page.

Shared/API/APIObject.h:
Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

UIProcess/API/APIApplicationManifest.h: Copied from Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h.

Add a new API object type for application manifests.

UIProcess/API/C/WKPage.cpp:

(WKPageGetApplicationManifest_b):

Add a C version of this SPI for WebKitTestRunner.

UIProcess/API/C/WKPagePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getApplicationManifestWithCompletionHandler:]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/_WKApplicationManifest.h: Copied from Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h.
UIProcess/API/Cocoa/_WKApplicationManifest.mm: Added.

(-[_WKApplicationManifest initWithCoder:]):
(-[_WKApplicationManifest encodeWithCoder:]):
(+[_WKApplicationManifest applicationManifestFromJSON:manifestURL:documentURL:]):
(-[_WKApplicationManifest _apiObject]):
(nullableNSString):
(-[_WKApplicationManifest name]):
(-[_WKApplicationManifest shortName]):
(-[_WKApplicationManifest applicationDescription]):
(-[_WKApplicationManifest scope]):
(-[_WKApplicationManifest startURL]):

UIProcess/API/Cocoa/_WKApplicationManifestInternal.h: Copied from Source/WebCore/Modules/applicationmanifest/ApplicationManifest.h.

(API::wrapper):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::applicationManifestCallback):
(WebKit::WebPageProxy::getApplicationManifest):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::finishedLoadingApplicationManifest):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getApplicationManifest):
(WebKit::WebPage::didFinishLoadingApplicationManifest):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Added.

Added two API tests for _WKApplicationManifest:

Testing _WKApplicationManifest's conformance to NSCoding.
Testing -[WKWebView _getApplicationManifestWithCompletionHandler:], verifying the values of the resulting _WKApplicationManifest.

(TestWebKitAPI::TEST):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Added a new testRunner method getApplicationManifestThen(), used by the LayoutTests
to request the document load its associated manifest. The layout tests formerly called
an unimplemented function getManifestThen(), but I added 'Application' to somewhat
differentiate this from the app cache manifest.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::getApplicationManifestThen):
(WTR::TestRunner::didGetApplicationManifest):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

TestExpectations:

Skip the app manifest-related layout tests for now while the feature is still disabled.
Also moved the expectations disabling the manifest-src layout tests (which now pass
when the feature is enabled) to the same location in the file.

applicationmanifest/developer-warnings-expected.txt: Added.
applicationmanifest/developer-warnings.html: Added.
applicationmanifest/multiple-links-expected.txt: Added.
applicationmanifest/multiple-links.html: Added.

Add a layout test to verify only the first manifest link is loaded when there
are multiple on the page.

applicationmanifest/resources/developer-warnings.manifest: Added.

Add a layout test to verify that warnings generated while parsing the manifest are
logged to the console.

http/tests/security/contentSecurityPolicy/manifest-src-allowed.html:

Replaced calls to getManifestThen() with getApplicationManifestThen().

http/tests/security/contentSecurityPolicy/manifest-src-blocked-expected.txt:

Updated the expected console message to reflect the current wording for CSP violations.

http/tests/security/contentSecurityPolicy/manifest-src-blocked.html:

Replaced calls to getManifestThen() with getApplicationManifestThen().

http/tests/security/contentSecurityPolicy/manifest.test/manifest.json:

Removed a trailing newline that was causing JSON parsing to fail.

2:24 PM Changeset in webkit [225597] by pvollan@apple.com

9 edits in trunk/Source

The WebProcess should use the NSRunLoop runloop type.
https://bugs.webkit.org/show_bug.cgi?id=179804
<rdar://problem/14012823>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests.

platform/mac/EventLoopMac.mm:

(WebCore::EventLoop::cycle):

Source/WebKit:

Platform/IPC/mac/ConnectionMac.mm:

(IPC::AccessibilityProcessSuspendedNotification):

Shared/ChildProcess.h:
Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::launchServicesCheckIn):

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::shouldLeakBoost):

WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeProcess):

2:24 PM Changeset in webkit [225596] by Antti Koivisto

4 edits in trunk/Source/WebCore

Prefer ids and classes over tag names in selector filter
https://bugs.webkit.org/show_bug.cgi?id=180433
<rdar://problem/35859103>

Reviewed by Zalan Bujtas.

There are only four slots in the filter and currently we just pick whatever identifiers we find traversing the selector
from right to left. More specific selector types are on average more valuable (id > class > tag) so we should prefer them.

This appears to be 4-5% StyleBench progression.

css/RuleSet.cpp:

(WebCore::RuleData::RuleData):

css/SelectorFilter.cpp:

(WebCore::collectSimpleSelectorHash):
(WebCore::collectSelectorHashes):

This function collects all hashes from the selector.

(WebCore::chooseSelectorHashesForFilter):

This function chooses the most valuable hashes to use with the filter.

(WebCore::SelectorFilter::collectHashes):

Factor into two separate steps.

(WebCore::collectDescendantSelectorIdentifierHashes): Deleted.
(WebCore::SelectorFilter::collectIdentifierHashes): Deleted.

css/SelectorFilter.h:

(WebCore::SelectorFilter::fastRejectSelector const):

2:21 PM Changeset in webkit [225595] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Details section headers overlap Classes container in the Computed Styles panel
https://bugs.webkit.org/show_bug.cgi?id=180380

Reviewed by Timothy Hatcher.

UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ :matches(.options-container, .class-list-container)):

1:53 PM Changeset in webkit [225594] by jer.noble@apple.com

9 edits in trunk/Source/WebCore

[EME] Make CDMInstance& parameter passed through MediaPlayer non-const
https://bugs.webkit.org/show_bug.cgi?id=180484

Reviewed by Jon Lee.

One can only call const methods on const references, and the obvious intent
of these methods is for the callee to call non-const methods on the parameters.

Modules/encryptedmedia/MediaKeys.h:

(WebCore::MediaKeys::cdmInstance):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::cdmInstanceAttached):
(WebCore::MediaPlayer::cdmInstanceDetached):
(WebCore::MediaPlayer::attemptToDecryptWithInstance):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateInterface::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateInterface::attemptToDecryptWithInstance):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateGStreamerBase::attemptToDecryptWithInstance):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):

platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

1:34 PM Changeset in webkit [225593] by commit-queue@webkit.org

5 edits
517 adds in trunk/LayoutTests

Import WPT workers test suite
https://bugs.webkit.org/show_bug.cgi?id=180464

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-06
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

resources/import-expectations.json:
resources/resource-files.json:
workers: Added.

LayoutTests:

TestExpectations: skip some timing out tests or testing shared workers.

1:02 PM Changeset in webkit [225592] by n_wang@apple.com

4 edits in trunk/Source/WebKit

AX: [iOS] Post accessibility notification when a web process changes its suspended state
https://bugs.webkit.org/show_bug.cgi?id=180458
<rdar://problem/35869115>

Reviewed by Chris Dumez.

Post accessibility notification with the pid information when a web process
becomes suspended or resumes running.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::processDidResume):

WebProcess/WebProcess.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::accessibilityProcessSuspendedNotification):

12:51 PM Changeset in webkit [225591] by commit-queue@webkit.org

7 edits
1 delete in trunk

Preflight should bypass service worker
https://bugs.webkit.org/show_bug.cgi?id=180463

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-06
Reviewed by Alex Christensen.

Source/WebCore:

Covered by updated test.

loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight): Ensure service worker is not used.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didFail): Tighten check and clear resource proactively to not hit loadRequest ASSERT.

LayoutTests:

http/tests/workers/service/resources/service-worker-crossorigin-fetch.js: Removed.
http/tests/workers/service/resources/service-worker-crossorigin-fetch-worker.js:

(event.event.request.url.endsWith):

http/tests/workers/service/resources/service-worker-crossorigin-fetch.js:

(async.test):

http/tests/workers/service/service-worker-crossorigin-fetch-expected.txt:
http/tests/workers/service/service-worker-crossorigin-fetch.html:

12:42 PM Changeset in webkit [225590] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed build fix, removed unused lambda capture.

NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::open):

12:39 PM Changeset in webkit [225589] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview 45

Added a tag for Safari Technology Preview release 45.

12:37 PM Changeset in webkit [225588] by Ryan Haddad

3 edits in trunk/LayoutTests

Update TestExpectations for http/tests/workers/service/registration-task-queue-scheduling-1.html.
https://bugs.webkit.org/show_bug.cgi?id=179342

Unreviewed test gardening.

TestExpectations:
platform/mac/TestExpectations:

12:28 PM Changeset in webkit [225587] by Matt Baker

8 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab initial user experience is poor when no canvases exist
https://bugs.webkit.org/show_bug.cgi?id=179329
<rdar://problem/35842036>

Reviewed by Timothy Hatcher.

This patch adds a new method, WI.createNavigationItemHelp, for creating command
help to display in a message text view. The method accepts a format string and
NavigationItem, and returns a DOM element. For example,

WI.createNavigationItemHelp("Press %s to do X.", navigationItem)

returns:

<div class="navigation-item-help">

Press <div class="navigation-bar"><div class="item">...</div></div> to do X.

</div>

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Main.js:

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.importRecording):
Importing a recording should be a manager command with a corresponding
event, so that it's decoupled from any specific location in the UI.

UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):

UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._recordingImportedOrStopped):
(WI.CanvasTabContentView.prototype._recordingStopped): Deleted.
(WI.CanvasTabContentView.prototype._navigationSidebarImport): Deleted.

UserInterface/Views/Main.css:

(.message-text-view .navigation-item-help):
(.message-text-view .navigation-item-help .navigation-bar):
(.message-text-view .navigation-item-help .navigation-bar > .item):
New styles for a NavigationItem appearing inline as part of descriptive
text. Wrapped in a fake navigation bar so navigation item styles are picked up.

UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel.prototype.initialLayout):
(WI.RecordingNavigationSidebarPanel.prototype._importNavigationItemClicked): Deleted.
Moved import code to CanvasManager.

11:56 AM Changeset in webkit [225586] by Said Abou-Hallawa

1 edit in trunk/Source/WebCore/ChangeLog

Storage Access API: Make document.hasStorageAccess a function and always allow access for same-origin iframes
https://bugs.webkit.org/show_bug.cgi?id=176944
<rdar://problem/34440658>

Patch by John Wilander <wilander@apple.com> on 2017-12-06
Reviewed by Brent Fulgham.

Test: http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-without-user-gesture.html

This change introduces document.hasStorageAccess() as a function which
returns a promise instead of being a property. Since cookie access can
be due to both a granted request and recent user interaction as first
party, the WebKit::WebResourceLoadStatisticsStore needs to be consulted.

dom/Document.cpp:

(WebCore::Document::hasStorageAccess):
(WebCore::Document::requestStorageAccess):

Removed check of the previous m_hasStorageAccess member.
Same-origin check done earlier. This was a request/suggestion
from Mozilla.

dom/Document.h:

(WebCore::Document::hasStorageAccess const): Deleted.

Now uses a promise.

dom/Document.idl:
page/ChromeClient.h:

11:45 AM Changeset in webkit [225585] by dino@apple.com

2 edits in trunk/Source/ThirdParty/ANGLE

Update ANGLE's changes.diff
https://bugs.webkit.org/show_bug.cgi?id=180491

Reviewed by Antoine Quint.

Here is the list of things we've changed from the
ANGLE commit that we merged in.

changes.diff:

11:43 AM Changeset in webkit [225584] by dino@apple.com

4 edits in trunk

Some iOS tests failing after ANGLE update
https://bugs.webkit.org/show_bug.cgi?id=180487
<rdar://problem/35885969>

Reviewed by Antoine Quint.

Source/ThirdParty/ANGLE:

The iOS OpenGL compiler doesn't like function declarations with
nameless array parameters. See:
<rdar://problem/35885989> Nameless array parameters in function declaration cause compiler error

While that is being fixed, tell ANGLE's translator to not cull
the names from parameters. This is not a bug in ANGLE, so we won't
fix it upstream at the moment.

src/compiler/translator/ParseContext.cpp:

(sh::TParseContext::addFunctionPrototypeDeclaration):

LayoutTests:

Unskip some WebGL tests.

platform/ios/TestExpectations:

11:41 AM Changeset in webkit [225583] by wilander@apple.com

43 edits
1 copy
2 adds in trunk

Storage Access API: Make document.hasStorageAccess a function and always allow access for same-origin iframes
https://bugs.webkit.org/show_bug.cgi?id=176944
<rdar://problem/34440658>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-without-user-gesture.html

dom/Document.cpp:

(WebCore::Document::hasStorageAccess):
(WebCore::Document::requestStorageAccess):

Removed check of the previous m_hasStorageAccess member.
Same-origin check done earlier. This was a request/suggestion
from Mozilla.

dom/Document.h:

(WebCore::Document::hasStorageAccess const): Deleted.

Now uses a promise.

dom/Document.idl:
page/ChromeClient.h:

Source/WebKit:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::hasStorageAccess):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):

Now adds an entry for granted access. A bug found through testing.
Switched from WTF::Function to WTF::CompletionHandler.

UIProcess/WebResourceLoadStatisticsStore.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::hasStorageAccess):
(WebKit::WebsiteDataStore::requestStorageAccess):

Switched from WTF::Function to WTF::CompletionHandler.

UIProcess/WebsiteData/WebsiteDataStore.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::hasStorageAccess):
(WebKit::WebChromeClient::requestStorageAccess):

Switched from WTF::Function to WTF::CompletionHandler.

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hasStorageAccess):
(WebKit::WebPage::requestStorageAccess):

Switched from WTF::Function to WTF::CompletionHandler.

WebProcess/WebPage/WebPage.h:

LayoutTests:

These tests now use the new document.hasStorageAccess() function
instead of the previous document.hasStorageAccess property.
The added test is a break out of the negative case of an iframe
calling the API when no user gesture is processed.

http/tests/storageAccess/request-and-deny-storage-access-cross-origin-iframe-expected.txt:
http/tests/storageAccess/request-and-deny-storage-access-cross-origin-iframe.html:
http/tests/storageAccess/request-and-deny-storage-access-cross-origin-sandboxed-iframe-expected.txt:
http/tests/storageAccess/request-and-deny-storage-access-cross-origin-sandboxed-iframe.html:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-non-sandboxed-iframe-expected.txt:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-non-sandboxed-iframe.html:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-expected.txt:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-expected.txt:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction-expected.txt:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-without-user-interaction-expected.txt:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-nested-iframe-expected.txt:
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-nested-iframe.html:
http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-with-unique-origin-expected.txt:
http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-without-allow-token-expected.txt:
http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-without-allow-token.html:
http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-without-user-gesture-expected.txt: Added.
http/tests/storageAccess/request-storage-access-cross-origin-sandboxed-iframe-without-user-gesture.html: Added.
http/tests/storageAccess/request-storage-access-same-origin-iframe-expected.txt:
http/tests/storageAccess/request-storage-access-same-origin-iframe.html:
http/tests/storageAccess/request-storage-access-same-origin-sandboxed-iframe-expected.txt:
http/tests/storageAccess/request-storage-access-same-origin-sandboxed-iframe-without-allow-token-expected.txt:
http/tests/storageAccess/request-storage-access-same-origin-sandboxed-iframe-without-allow-token.html:
http/tests/storageAccess/request-storage-access-top-frame-expected.txt:
http/tests/storageAccess/request-storage-access-top-frame.html:
http/tests/storageAccess/resources/request-storage-access-iframe.html:
http/tests/storageAccess/resources/request-storage-access-without-user-gesture-iframe.html: Added.
platform/mac-wk2/TestExpectations:

Marked the new test case as [ Pass ]

11:38 AM Changeset in webkit [225582] by jmarcell@apple.com

1 copy in tags/Safari-605.1.16

Tag Safari-605.1.16.

11:00 AM Changeset in webkit [225581] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION (r225537): Crash in WebCore::SWServerWorker::setHasPendingEvents(bool) + 68
https://bugs.webkit.org/show_bug.cgi?id=180481

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-06
Reviewed by Chris Dumez.

Replacing ASSERT by if null check since there is no strong guarantee right now that there is a registration
in SWServer registration map associated to a SWServerWorker.

workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::setHasPendingEvents):

10:58 AM Changeset in webkit [225580] by webkit@devinrousso.com

4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r225569): CSSStyleDetailsSidebarPanel no longer exists
https://bugs.webkit.org/show_bug.cgi?id=180466

Reviewed by Joseph Pecoraro.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.applyFilter):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleEditorFilterApplied):

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel.prototype.applyFilter):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionFilterApplied):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.applyFilter):

10:58 AM Changeset in webkit [225579] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() in void JSC::sanitizeStackForVM(JSC::VM *)
https://bugs.webkit.org/show_bug.cgi?id=180438
<rdar://problem/35862342>

Reviewed by Yusuke Suzuki.

A couple inspector methods that take stacktraces need
to grab the JSLock.

inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):

10:55 AM Changeset in webkit [225578] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

CacheStorageEngineConnection should protect its IPC Connection when doing asynchronous tasks
https://bugs.webkit.org/show_bug.cgi?id=180461

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-06
Reviewed by Chris Dumez.

Protecting the IPC connection instead of the CacheStorageEngineConnection
since CacheStorageEngineConnection only keeps a reference to the NetworkConnectionToWebProcess.

NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::retrieveRecords):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
(WebKit::CacheStorageEngineConnection::clearMemoryRepresentation):

10:40 AM Changeset in webkit [225577] by Chris Dumez

24 edits in trunk

ServiceWorkers API should reject promises when calling objects inside detached frames
https://bugs.webkit.org/show_bug.cgi?id=180444

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline test now that it is passing some checks.

web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt:
web-platform-tests/service-workers/service-worker/register-closed-window.https-expected.txt:

Source/WebCore:

ServiceWorkers API should reject promises when calling objects inside detached frames.

No new tests, rebaselined existing test.

bindings/js/JSDOMPromiseDeferred.h:

(WebCore::callPromiseFunction):
Use the caller's globalObject instead of the lexicalGlobalObject when constructing the
deferred promise. The bug became visible when working on this service worker bug since
rejecting the promise when the frame is detached did not actually work. The issue is
that since the promise was created with the detached frame's globalObject, then it was
suspended and would not run script.

bindings/js/JSDOMWindowBase.cpp:

(WebCore::callerGlobalObject):
(WebCore::incumbentDOMWindow):

bindings/js/JSDOMWindowBase.h:

Add convenience function to get the caller's globalObject. It was carved out of
incumbentDOMWindow().

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):

workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):
Reject the promise when m_isStopped flag is set (i.e. ActiveDOMObject::stop()
has been called).

LayoutTests:

TestExpectations:

Unskip test that no longer times out and starts passing a few checks.

fast/dom/navigator-detached-no-crash-expected.txt:

Rebaseline test now that promise is rejected.

http/tests/media/media-stream/disconnected-frame-permission-denied-expected.txt:
http/tests/media/media-stream/disconnected-frame-permission-denied.html:

Update and rebaseline test now that the promise is rejected. I verified that this
behavior is consistent with Chrome.

9:44 AM Changeset in webkit [225576] by Matt Lewis

2 edits in trunk/LayoutTests

Marked storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=176693

Unreviewed test gardening.

platform/mac/TestExpectations:

9:31 AM Changeset in webkit [225575] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Mac] REGRESSION (r224527): Drawing a path with box-shadow takes double the blur-radius on Retina display
https://bugs.webkit.org/show_bug.cgi?id=180460
<rdar://problem/35869866>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-12-06
Reviewed by Daniel Bates.

Disable using CGContextDrawPathDirect() for macOS High Sierra or earlier.
This API has a bug when drawing a path with a shadow on Retina display.

platform/graphics/cg/GraphicsContextCG.cpp:

9:13 AM Changeset in webkit [225574] by commit-queue@webkit.org

5 edits in trunk

Service Worker fetch should filter HTTP headers that are added by CachedResourceLoader/CachedResource
https://bugs.webkit.org/show_bug.cgi?id=180462

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-06
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/fetch-response-taint.https-expected.txt:

Source/WebCore:

Coved by rebased test.

loader/CrossOriginAccessControl.cpp:

(WebCore::cleanRedirectedRequestForAccessControl): Accept header is a safe header so it is fine to keep it.

workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent): Cleaning headers added by CachedResourceLoader/CachedResource.

3:46 AM Changeset in webkit [225573] by zandobersek@gmail.com

8 edits
4 adds in trunk/Source

[CoordGraphics] Introduce Nicosia::PaintingContext, add Cairo implementation
https://bugs.webkit.org/show_bug.cgi?id=180239

Reviewed by Michael Catanzaro.

Source/WebCore:

As the next step in the Nicosia abstraction formation, we introduce
Nicosia::PaintingContext. Implementations of this class will leverage a
chosen 2D graphics library to paint (through GraphicsContext) into the
memory area that's specified by a given Nicosia::Buffer object.

Nicosia::Buffer is slimmed down to only control the memory that's
required for rasterization of an RGBA32 painting output. It mimics the
Cairo ImageBuffer implementation by using FastMalloc to allocate the
necessary memory. In the future this class might become an interface of
which different implementations will be providing memory that's
allocated through different ways. For instance, when GLES3 is available,
it would be possible to map GPU memory into the process memory space and
rasterize into that, effectively eliminating need for GPU uploads.

Since the ImageBuffer use in Nicosia::Buffer is dropped, the context()
and uploadImage() methods are also removed. The functionality of
ImageBuffer that was leveraged for CoordinatedGraphics rasterization
still remains used through the PaintingContextCairo implementation. In
the constructor of that class, with the target Nicosia::Buffer provided,
we construct the cairo_surface_t and cairo_t objects that are necessary
to create a combination of PlatformContextCairo and GraphicsContext
objects that we can then use for rasterization.

Reference of the passed-in Nicosia::Buffer object is increased for the
lifetime of the cairo_surface_t object that will be drawing into that
buffer's memory area. This ensures the memory area doesn't disappear
from a live cairo_surface_t. Still, the expectation is that the
cairo_surface_t object won't outlive the PaintingContextCairo object's
lifetime, since the cairo_t object is also managed here and deleted in
the destructor. To test that, we use a cairo_surface_t user data key
that in its destroy callback dereferences the Nicosia::Buffer object and
also marks the deletion process for the related PaintingContextCairo
object as complete. This m_deletionComplete value is tested in the
destructor of the class, once all the Cairo references are nulled out.

The PaintingContext objects should be limited to a single scope,
enabling the implementation resources to assume that the lifetime of the
implementation object won't extend outside of the scope where it was
created. To ensure that, the PaintingContext::paint() static function is
added that creates the PaintingContext object and then executes the
passed-in functor, passing it the GraphicsContext that should be used
for drawing. Drawing is thus limited to that functor only, and the
PaintingContext's create() function and the virtual graphicsContext()
are not made public in the class.

No new tests -- no change in functionality.

platform/TextureMapper.cmake:
platform/graphics/nicosia/NicosiaBuffer.cpp:

(Nicosia::Buffer::Buffer):
(Nicosia::Buffer::context): Deleted.
(Nicosia::Buffer::uploadImage): Deleted.

platform/graphics/nicosia/NicosiaBuffer.h:

(Nicosia::Buffer::stride const):
(Nicosia::Buffer::data const):

platform/graphics/nicosia/NicosiaPaintingContext.cpp: Copied from Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp.

(Nicosia::PaintingContext::create):

platform/graphics/nicosia/NicosiaPaintingContext.h: Copied from Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp.

(Nicosia::PaintingContext::paint):

platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp: Added.

(Nicosia::PaintingContextCairo::PaintingContextCairo):
(Nicosia::PaintingContextCairo::~PaintingContextCairo):
(Nicosia::PaintingContextCairo::graphicsContext):

platform/graphics/nicosia/NicosiaPaintingContextCairo.h: Copied from Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h.
platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp:

(Nicosia::PaintingEngineBasic::paint):

platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::update):

Source/WebKit:

With Nicosia::Buffer now only providing the memory area into which the
tile content was rasterized, we can simplify the BitmapTexture update
greatly -- we don't have to create a BitmapImage anymore and retrieve
memory pointer from the contained cairo_surface_t object. Instead, we
just copy to GPU the memory that Nicosia::Buffer controls.

Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::swapBuffers):

12:51 AM Changeset in webkit [225572] by webkit@devinrousso.com

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: display related pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=176187
<rdar://problem/34194917>

Reviewed by Timothy Hatcher.

Localizations/en.lproj/localizedStrings.js:

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.css:

(.spreadsheet-style-panel .section-header):
(.spreadsheet-style-panel .section-header .node-link):
(.spreadsheet-style-panel .section-header .node-link:hover):
(.spreadsheet-style-panel .section-inherited): Deleted.
(.spreadsheet-style-panel .section-inherited .node-link): Deleted.
(.spreadsheet-style-panel .section-inherited .node-link:hover): Deleted.
After all of the matched and inherited styles are added, loop over each pseudo-element, get
the DOMNodeStyles for each, refresh them if needed, and then add the header and sections.

UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype.refreshIfNeeded):
(WI.DOMNodeStyles.prototype.refresh):
Return a reference to the DOMNodeStyles object once the refresh promise is resolved.

UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.get displayName):
If the node is a pseudo-element, display the pseudo-type instead of the node name.

12:24 AM Changeset in webkit [225571] by webkit@devinrousso.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: [PARITY] Styles Redesign: Ability to add new style rules
https://bugs.webkit.org/show_bug.cgi?id=178329
<rdar://problem/35001005>

Reviewed by Timothy Hatcher.

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.newRuleButtonClicked):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.newRuleButtonContextMenu):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype._addNewRule):
Implement the two functions that CSSStyleDetailsSidebarPanel expects to exist in order for
the selected panel to support adding a new rule.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):
If the _selectorElement has not been created yet, set a flag and focus it once layout() has
been called (thereby ensuring that initialLayout() has been called).

Dec 5, 2017:

11:56 PM Changeset in webkit [225570] by webkit@devinrousso.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: for newly added properties, pressing delete in empty value field should focus on name field
https://bugs.webkit.org/show_bug.cgi?id=179831
<rdar://problem/35626976>

Reviewed by Timothy Hatcher.

UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._handleKeyDown):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBackspace):

11:54 PM Changeset in webkit [225569] by webkit@devinrousso.com

5 edits in trunk/Source/WebInspectorUI

Web Inspector: [PARITY] Styles Redesign: Make filtering work
https://bugs.webkit.org/show_bug.cgi?id=178331
<rdar://problem/35001015>

Reviewed by Timothy Hatcher.

Since both the sections and editors (per-section) use View semantics, we cannot simply
search for instances of the filtered text since not all of the subviews may have called
layout() yet. Instead, we have to rely on event listeners to relay information as to whether
the filtered text was matched up the chain, applying the correct style classes along the way.

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.refresh):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.applyFilter):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.filterDidChange):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype._handleSectionFilterApplied):
Save the "Inherited From" elements so that they can be hidden if no styles inherited from
that node match the filter.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.applyFilter):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._renderSelector):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._createMediaHeader):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleEditorFilterApplied):
Save the media header elements so that they can also be filtered.

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.applyFilter):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.applyFilter):
(WI.SpreadsheetStyleProperty.prototype._update):
Move the name and value elements to a new container so that filter highlight won't also
apply to the checkbox or warning element.

11:01 PM Changeset in webkit [225568] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: adding a property before or after the first one appends it to the end
https://bugs.webkit.org/show_bug.cgi?id=180321
<rdar://problem/35816402>

Reviewed by Timothy Hatcher.

UserInterface/Models/CSSStyleDeclaration.js:

(WI.CSSStyleDeclaration.prototype._rangeAfterPropertyAtIndex):

UserInterface/Models/TextRange.js:

(WI.TextRange.prototype.collapseToStart):

9:25 PM Changeset in webkit [225567] by commit-queue@webkit.org

5 edits in trunk

[GTK] Layout test media/track/track-in-band-duplicate-tracks-when-source-changes.html crashes and times out
https://bugs.webkit.org/show_bug.cgi?id=160131

Patch by Fujii Hironori <Fujii Hironori> on 2017-12-05
Reviewed by Eric Carlson.

Source/WebCore:

Null dereference can be happen if VideoTrack and AudioTrack are
disconnected from its media element.

No new tests, no behavior change.

html/track/AudioTrack.cpp:

(WebCore::AudioTrack::willRemove): Null-check mediaElement.

html/track/VideoTrack.cpp:

(WebCore::VideoTrack::setLanguage): Ditto.

LayoutTests:

platform/gtk/TestExpectations:

8:47 PM Changeset in webkit [225566] by Chris Dumez

8 edits
2 adds in trunk

ServiceWorkerGlobalScope prototype chain should be immutable
https://bugs.webkit.org/show_bug.cgi?id=180450

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline test that no longer times out.

web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:

Source/WebCore:

ServiceWorkerGlobalScope prototype chain should be immutable, similarly
to what we do for DOMWindow. This is covered by a web-platform-test
which was timing out because it was successfuly overwriting the
ServiceWorkerGlobalScope prototype.

No new tests, rebaselined existing test.

workers/DedicatedWorkerGlobalScope.idl:
workers/WorkerGlobalScope.idl:
workers/service/ServiceWorkerGlobalScope.idl:

LayoutTests:

TestExpectations:

Unskip test that no longer times out.

7:54 PM Changeset in webkit [225565] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Fast binding generation by batching several files at once
https://bugs.webkit.org/show_bug.cgi?id=179958

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-12-05
Reviewed by Alex Christensen.

Passing several files to the sub process at once and reducing the total cost of
process generation. Especially Windows port has great speed improvement because
its implementation of fork/exec is terrible.

bindings/scripts/generate-bindings-all.pl:

(spawnGenerateBindingsIfNeeded):

bindings/scripts/generate-bindings.pl:

(generateBindings):

6:41 PM Changeset in webkit [225564] by commit-queue@webkit.org

27 edits
2 copies
2 adds in trunk/Source

[Web App Manifest] Support fetching the app manifest
https://bugs.webkit.org/show_bug.cgi?id=180292

Patch by David Quesada <david_quesada@apple.com> on 2017-12-05
Reviewed by Geoffrey Garen.

Add support in WebCore for loading and parsing application manifests. This functionality
is currently exposed with two methods: DocumentLoader::loadApplicationManifest() to call
to start loading the manifest, and FrameLoaderClient::finishedLoadingApplicationManifest()
for clients to override in order to be notified of the loaded manifest.

No new tests, since no functionality is exposed to web content or embedders yet. The
needed SPI will be added in an upcoming patch.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:

Added CachedApplicationManifest and ApplicationManifestLoader.

html/HTMLLinkElement.h:
html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):

Add "manifest" as a supported 'rel' type for links.

html/LinkRelAttribute.h:
inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJSON):
(WebCore::InspectorPageAgent::inspectorResourceType):

inspector/agents/InspectorPageAgent.h:
loader/ApplicationManifestLoader.cpp: Added.

Added a class ApplicationManifestLoader which handles creating a ResourceRequest,
loading the resource from the CachedResourceLoader, and parsing the resulting text.
This class and its relation to DocumentLoader are roughly based on that of IconLoader,
which serves a similar purpose - requesting a resource on the page and ultimately
providing it to the embedder.

(WebCore::ApplicationManifestLoader::ApplicationManifestLoader):
(WebCore::ApplicationManifestLoader::~ApplicationManifestLoader):
(WebCore::ApplicationManifestLoader::startLoading):
(WebCore::ApplicationManifestLoader::stopLoading):
(WebCore::ApplicationManifestLoader::processManifest):
(WebCore::ApplicationManifestLoader::notifyFinished):

loader/ApplicationManifestLoader.h: Copied from Source/WebCore/page/csp/ContentSecurityPolicyDirectiveNames.h.
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::loadApplicationManifest):
(WebCore::DocumentLoader::finishedLoadingApplicationManifest):
(WebCore::DocumentLoader::notifyFinishedLoadingApplicationManifest):

loader/DocumentLoader.h:
loader/FrameLoaderClient.h:
loader/LinkLoader.cpp:

(WebCore::createLinkPreloadResourceClient):
(WebCore::LinkLoader::isSupportedType):

loader/ResourceLoadInfo.cpp:

(WebCore::toResourceType):

loader/SubresourceLoader.cpp:

(WebCore::logResourceLoaded):

loader/cache/CachedApplicationManifest.cpp: Added.

(WebCore::CachedApplicationManifest::CachedApplicationManifest):
(WebCore::CachedApplicationManifest::finishLoading):
(WebCore::CachedApplicationManifest::setEncoding):
(WebCore::CachedApplicationManifest::encoding const):
(WebCore::CachedApplicationManifest::process):

Add a method to process the fetched text into an ApplicationManifest. CachedApplicationManifest
does not store the resulting ApplicationManifest because the text of an application
manifest can yield a different ApplicationManifest depending on the URL of the document
processing it.

loader/cache/CachedApplicationManifest.h: Copied from Source/WebCore/page/csp/ContentSecurityPolicyDirectiveNames.h.
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::defaultPriorityForResourceType):

loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestApplicationManifest):
(WebCore::contentTypeFromResourceType):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):

loader/cache/CachedResourceLoader.h:
page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::applicationManifestKey):

page/DiagnosticLoggingKeys.h:
page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowManifestFromSource const):

page/csp/ContentSecurityPolicy.h:
page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForManifest const):
(WebCore::ContentSecurityPolicyDirectiveList::addDirective):

page/csp/ContentSecurityPolicyDirectiveList.h:
page/csp/ContentSecurityPolicyDirectiveNames.cpp:
page/csp/ContentSecurityPolicyDirectiveNames.h:

6:18 PM Changeset in webkit [225563] by commit-queue@webkit.org

14 edits in trunk

Switch windows build to Visual Studio 2017
https://bugs.webkit.org/show_bug.cgi?id=172412

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-12-05
Reviewed by Per Arne Vollan.

Source/cmake/OptionsMSVC.cmake:

Source/JavaScriptCore:

JavaScriptCore.vcxproj/JavaScriptCore.proj:

Source/WebCore:

Only changes proj file to update generator

WebCore.vcxproj/WebCore.proj:

Source/WebKitLegacy:

WebKitLegacy.vcxproj/WebKitLegacy.proj:

Source/WTF:

WTF.vcxproj/WTF.proj:
wtf/Compiler.h:

Tools:

Scripts/build-webkit:
Scripts/webkitdirs.pm:

(visualStudioInstallDir):
(visualStudioInstallDirFallback):
(msBuildInstallDir):
(setupAppleWinEnv):
(setupCygwinEnv):
(generateBuildSystemFromCMakeProject):
(pickLegacyVisualStudioInstallation): Deleted.
(visualStudioInstallDirLegacy): Deleted.
(visualStudioVersion): Deleted.
(visualStudioVersionFromInstallDir): Deleted.

5:59 PM Changeset in webkit [225562] by Brent Fulgham

11 edits
2 adds in trunk

Limit user agent versioning to an upper bound
https://bugs.webkit.org/show_bug.cgi?id=180365
<rdar://problem/34550617>

Reviewed by Joseph Pecoraro.

Source/WebCore:

Freeze the version reported as User Agent to OS 10.13.4 (OS 11.3 on iOS) and WebKit 605.1.15
for User Agent purposes.

Test: fast/dom/navigator-userAgent-frozen.html

page/cocoa/UserAgent.h:
page/cocoa/UserAgent.mm:

(WebCore::versionPredatesFreeze): Helper function. Returns true for Version 10.13.3 or older.
(WebCore::systemMarketingVersionForUserAgentString):
(WebCore::userAgentBundleVersion):
(WebCore::userVisibleWebKitBundleVersionFromFullVersion): Deleted.
(WebCore::userAgentBundleVersionFromFullVersionString): Deleted.

page/ios/UserAgentIOS.mm:

(WebCore::standardUserAgentWithApplicationName): Don't take the WebKit bundle version
as an argument, or pass it to the user agent string generator.

page/mac/UserAgentMac.mm:

(WebCore::standardUserAgentWithApplicationName): Ditto.

Source/WebKit:

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::standardUserAgent): Don't pass the WebKit bundle version when
creatin the User Agent string.
(WebKit::webKitBundleVersionString): Deleted.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::standardUserAgent): Ditto.
(WebKit::webKitBundleVersionString): Deleted.

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
creating the User Agent string.
(webKitBundleVersionString): Deleted.

LayoutTests:

fast/dom/navigator-userAgent-frozen-expected.txt: Added.
fast/dom/navigator-userAgent-frozen.html: Added.

5:47 PM Changeset in webkit [225561] by jfernandez@igalia.com

7 edits
582 copies
288 adds
1 delete in trunk/LayoutTests

[css-grid] Update imported Web Platform Tests
https://bugs.webkit.org/show_bug.cgi?id=180345

Reviewed by Manuel Rego Casasnovas and Youenn Fablet.

LayoutTests/imported/w3c:

Import new grid related Web Platform tests.
Rename the css/css-grid-1/ folder to css/css-grid/ to sync upstream folder hierarchy.
Imported css/resources/ because the check-layout-th.js script has been moved there.

LayoutTests:

Added specific bugs to the expectations file for the new imported tests that fail for now.
Removed from the expectations file a test that has been deleted recently.

TestExpectations:
platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

5:46 PM Changeset in webkit [225560] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Empty Message View in Network Tab has padding at top
https://bugs.webkit.org/show_bug.cgi?id=180453

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-05
Reviewed by Matt Baker.

UserInterface/Views/NetworkTableContentView.css:

(.content-view.network .message-text-view): Deleted.

5:31 PM Changeset in webkit [225559] by aestes@apple.com

2 edits in trunk/Source/WebKitLegacy/mac

[Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
https://bugs.webkit.org/show_bug.cgi?id=180457
<rdar://problem/35143007>

Reviewed by Tim Horton.

None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
check for this macro during post-processing.

postprocess-headers.sh:

5:30 PM Changeset in webkit [225558] by aestes@apple.com

4 edits in trunk/Source

[Darwin] Simplify use of TargetConditionals
https://bugs.webkit.org/show_bug.cgi?id=180455
<rdar://problem/35142971>

Reviewed by Tim Horton.

There's no need to check if TARGET_* macros are defined on Darwin platforms, since
TargetConditionals.h always defines them. Also, we can simplify

(TARGET_OS_EMBEDDED

TARGET_OS_IPHONE

TARGET_IPHONE_SIMULATOR) to TARGET_OS_IPHONE.

Source/bmalloc:

bmalloc/BPlatform.h:

Source/WTF:

wtf/Platform.h:

4:57 PM Changeset in webkit [225557] by Chris Dumez

3 edits in trunk/LayoutTests

Unreviewed, rebaseline service worker test after r225549.

http/tests/workers/service/ServiceWorkerGlobalScope-properties-expected.txt:
http/tests/workers/service/ServiceWorkerGlobalScope-properties.html:

4:55 PM Changeset in webkit [225556] by Lucas Forschler

1 copy in branches/buildbot-0.9

New branch for buildbot 0.9 development.

3:59 PM Changeset in webkit [225555] by Matt Lewis

18 edits
2 moves in trunk/Source

Unreviewed, rolling out r225430.

This caused an API failure on release.

Reverted changeset:

"Move DateComponents into WTF"
https://bugs.webkit.org/show_bug.cgi?id=180211
https://trac.webkit.org/changeset/225430

3:30 PM Changeset in webkit [225554] by Simon Fraser

3 edits
2 adds in trunk

Composited frames incorrectly get requestAnimationFrame throttled
https://bugs.webkit.org/show_bug.cgi?id=178396

Reviewed by Zalan Bujtas.

Source/WebCore:

If a composited iframe was inside overflow:scroll, and the overflow was scrolled to the left
further than the window width, then RenderLayer::childrenClipRect() would return an empty rectangle
and we'd incorrectly consider the iframe out of view, and thus throttle its requestAnimationFrame.

childrenClipRect() was taking unscaledDocumentRect(), applying the clip, and then mapping the result
from local to absolute coordinates (which mapped it through the overflow scroll offset). This is incorrect
because it considers the unscaledDocumentRect() to be in local coordinates, which it is not.

Instead, start with the infinite rect, which essentially tells us if we have any clipping, and then
intersect that with the document rect at the end. Something similar is done in other places that call.
calculateRects().

Test: fast/animation/request-animation-frame-throttle-inside-overflow-scroll.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

LayoutTests:

fast/animation/request-animation-frame-throttle-inside-overflow-scroll-expected.txt: Added.
fast/animation/request-animation-frame-throttle-inside-overflow-scroll.html: Added.

3:15 PM Changeset in webkit [225553] by achristensen@apple.com

4 edits in trunk

Fix crash when loading a file URL that does not have a fileSystemPath representation
https://bugs.webkit.org/show_bug.cgi?id=180448
<rdar://problem/22805921>

Reviewed by Chris Dumez.

Source/WebKit:

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::assumeReadAccessToBaseURL):
Check if a String is null before adding it to a HashSet.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:

(TEST):
Test opening a URL that used to crash WebKit.

3:01 PM Changeset in webkit [225552] by msaboff@apple.com

6 edits in trunk

Make WebKit build for ARM64_32
https://bugs.webkit.org/show_bug.cgi?id=180447

Reviewed by Mark Lam.

Source/WebCore:

No new test as this isn't a change to functionality.

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::TransformationMatrix::multiply): Fallback to the C++ version for
ARM64_32.

Source/WTF:

Add the 'w' (32bit) pointer qualifier for ARM64_32 pointers in inline assembly.

wtf/darwin/WeakLinking.h:

(WTF::isNullFunctionPointer):

Tools:

Add an instance of the _TestWTFAlwaysMissing for arm64_32 architecture.

TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:

2:50 PM Changeset in webkit [225551] by fpizlo@apple.com

7 edits in trunk/Source

bmalloc IsoHeap needs to allow a thread to deallocate some size for the first time
https://bugs.webkit.org/show_bug.cgi?id=180443

Reviewed by Saam Barati.
Source/bmalloc:

It's true that we can expect a heap to already be initialized if we try to deallocate in it. But it
may not have its deallocator initialized on this thread yet.

This is easily fixed by adding a null check on the deallocate path. That's probably not going to
change perf at all. But doing that allows me to get rid of a lot of weird stuff I previously did to
avoid that null check, like creating a dummy TLS in the DebugHeap case.

bmalloc/IsoTLS.cpp:

(bmalloc::IsoTLS::debugFree):
(bmalloc::IsoTLS::deallocateSlow): Deleted.

bmalloc/IsoTLS.h:
bmalloc/IsoTLSInlines.h:

(bmalloc::IsoTLS::allocateImpl):
(bmalloc::IsoTLS::allocateSlow):
(bmalloc::IsoTLS::deallocateImpl):
(bmalloc::IsoTLS::deallocateSlow):
(bmalloc::IsoTLS::ensureHeapAndEntries):

Source/WTF:

With this change it's possible to reenable isoheaps on iOS.

wtf/IsoMalloc.h:
wtf/IsoMallocInlines.h:

2:50 PM Changeset in webkit [225550] by jfbastien@apple.com

9 edits in trunk

WebAssembly: don't eagerly checksum
https://bugs.webkit.org/show_bug.cgi?id=180441
<rdar://problem/35156628>

Reviewed by Saam Barati.

JSTests:

Checksum is now disabled, so tests only have <?> as the module
name.

wasm/function-tests/nameSection.js:
wasm/function-tests/stack-overflow.js:

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.assertOverflows):
(assertOverflows.assertThrows):
(assertOverflows):

wasm/function-tests/stack-trace.js:

Source/JavaScriptCore:

Make checksumming of module optional for now. The bots think the
checksum hurt compile-time. I'd measured it and couldn't see a
difference, and still can't at this point in time, but we'll see
if disabling it fixes the bots. If so then I can make it lazy upon
first backtrace construction, or I can try out MD5 instead of
SHA1.

runtime/Options.h:
wasm/WasmModuleInformation.cpp:

(JSC::Wasm::ModuleInformation::ModuleInformation):

wasm/WasmModuleInformation.h:
wasm/WasmNameSection.h:

(JSC::Wasm::NameSection::NameSection):

2:46 PM Changeset in webkit [225549] by Chris Dumez

4 edits in trunk

XMLHttpRequest should not be exposed to service workers
https://bugs.webkit.org/show_bug.cgi?id=180446

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that has one more check passing.

web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:

Source/WebCore:

Stop exposing XMLHttpRequest to service workers, as per:

https://xhr.spec.whatwg.org/#interface-xmlhttprequest

xml/XMLHttpRequest.idl:

2:34 PM Changeset in webkit [225548] by aakash_jain@apple.com

1 edit
1 move in trunk/Tools

[build.webkit.org] Rename mastercfg_unittest to steps_unittest
https://bugs.webkit.org/show_bug.cgi?id=180432

Rubber-stamped by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Removed.
BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Copied from BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py.

2:28 PM Changeset in webkit [225547] by Nikita Vasilyev

15 edits
4 copies
2 moves in trunk/Source/WebInspectorUI

Web Inspector: Styles: make Computed a top-level sidebar tab
https://bugs.webkit.org/show_bug.cgi?id=174229
<rdar://problem/33170193>

Reviewed by Matt Baker.

Styles dropdown tab selector was removed. Styles and Computed are now top-level sidebar tabs.

Visual styles is no longer visible in the Styles sidebar tabs by default but can be enabled in the settings.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Base/Setting.js:
UserInterface/Main.html:
UserInterface/Views/CSSStyleDeclarationSection.js:

(WI.CSSStyleDeclarationSection.prototype.findMatchingPropertiesAndSelectors):

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WI.CSSStyleDeclarationTextEditor.prototype.findMatchingProperties):
(WI.CSSStyleDeclarationTextEditor.prototype.removeNonMatchingProperties):

UserInterface/Views/ComputedStyleDetailsSidebarPanel.js: Added.

(WI.ComputedStyleDetailsSidebarPanel):

UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline.prototype._ondragover):
(WI.DOMTreeOutline.prototype._ondrop):

UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

UserInterface/Views/GeneralStyleDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css.
UserInterface/Views/GeneralStyleDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js.

(WI.GeneralStyleDetailsSidebarPanel):
(WI.GeneralStyleDetailsSidebarPanel.prototype.get panel):
(WI.GeneralStyleDetailsSidebarPanel.prototype.visibilityDidChange):
(WI.GeneralStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
(WI.GeneralStyleDetailsSidebarPanel.prototype.layout):
(WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout):
(WI.GeneralStyleDetailsSidebarPanel.prototype.sizeDidChange):
(WI.GeneralStyleDetailsSidebarPanel.prototype.get _initialScrollOffset):
(WI.GeneralStyleDetailsSidebarPanel.prototype._updateNoForcedPseudoClassesScrollOffset):
(WI.GeneralStyleDetailsSidebarPanel.prototype._showPanel):
(WI.GeneralStyleDetailsSidebarPanel.prototype._newRuleButtonClicked):
(WI.GeneralStyleDetailsSidebarPanel.prototype._newRuleButtonContextMenu):
(WI.GeneralStyleDetailsSidebarPanel.prototype._populateClassToggles):
(WI.GeneralStyleDetailsSidebarPanel.prototype._createToggleForClassName):
(WI.GeneralStyleDetailsSidebarPanel.prototype._filterDidChange):
Styles and Computed tabs share a few UI components, such as force state (:hover, :focus, etc.),
filter field, and CSS class toggle components. To implement this, CSSStyleDetailsSidebarPanel was renamed
to GeneralStyleDetailsSidebarPanel.

CSSStyleDetailsSidebarPanel used to support several panels. This is no longer the case with GeneralStyleDetailsSidebarPanel:

_initiallySelectedPanel was removed.
_selectedPanel was replaced by _panel.

UserInterface/Views/GroupNavigationItem.js:

(WI.GroupNavigationItem.prototype.get minimumWidth):

UserInterface/Views/NavigationBar.css:

(.navigation-bar .item,):
(.sidebar-navigation-bar):
(.sidebar-navigation-bar .holder):

UserInterface/Views/NavigationBar.js:

(WI.NavigationBar.prototype._calculateMinimumWidth):
Minor optimization: don't toggle class names when there are no visible navigation items.

UserInterface/Views/RulesStyleDetailsPanel.js:

(WI.RulesStyleDetailsPanel.prototype.filterDidChange):

UserInterface/Views/RulesStyleDetailsSidebarPanel.js: Copied from Source/WebInspectorUI/UserInterface/Views/NavigationBar.css.

(WI.RulesStyleDetailsSidebarPanel):

UserInterface/Views/SearchTabContentView.js:

(WI.SearchTabContentView):

UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

UserInterface/Views/Sidebar.js:

(WI.Sidebar):

UserInterface/Views/SidebarNavigationBar.js: Copied from Source/WebInspectorUI/UserInterface/Views/NavigationBar.css.

(WI.SidebarNavigationBar):
(WI.SidebarNavigationBar.prototype.insertNavigationItem):
(WI.SidebarNavigationBar.prototype._calculateMinimumWidth):
SidebarNavigationBar wraps navigation items in an element so it can correctly calculate the width of all items with spacing between them.

UserInterface/Views/StyleDetailsPanel.js:

(WI.StyleDetailsPanel.prototype.get _initialScrollOffset):

UserInterface/Views/VisualStyleDetailsSidebarPanel.js: Copied from Source/WebInspectorUI/UserInterface/Views/NavigationBar.css.

(WI.VisualStyleDetailsSidebarPanel):

2:09 PM Changeset in webkit [225546] by commit-queue@webkit.org

23 edits in trunk

Web Inspector: content views for resources loaded through XHR do not reflect declared mime-type
https://bugs.webkit.org/show_bug.cgi?id=141389
<rdar://problem/19767070>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-05
Reviewed by Brian Burg.

Source/WebCore:

Updated: http/tests/inspector/network/xhr-response-body.html:

http/tests/inspector/network/fetch-response-body.html:

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl): Deleted.

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishXHRLoading): Deleted.
Remove special handling of XHR content that decoded output as text.

inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::requestId const):
(WebCore::NetworkResourcesData::ResourceData::loaderId const):
(WebCore::NetworkResourcesData::ResourceData::frameId const):
(WebCore::NetworkResourcesData::ResourceData::url const):
(WebCore::NetworkResourcesData::ResourceData::content const):
(WebCore::NetworkResourcesData::ResourceData::isContentEvicted const):
(WebCore::NetworkResourcesData::ResourceData::textEncodingName const):

inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::shouldBufferResourceData):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):

Make NetworkResourcesData only create a text decoder for resources we
really think are text, and buffer resource data if it is text data
or if it is a resource that would otherwise not be buffered by WebCore
(such as XHRs with a DoNotBufferData policy). This ensures that the
Inspector will have data to show for resources that won't be cached.

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::sourceMapURLForResource):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::hasTextContent): Deleted.
(WebCore::InspectorPageAgent::cachedResourceContent): Deleted.
(WebCore::InspectorPageAgent::createTextDecoder): Deleted.
(WebCore::textContentForCachedResource): Deleted.

inspector/agents/InspectorPageAgent.h:
inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didReceiveData):
(WebCore::InspectorNetworkAgent::willDestroyCachedResource):
(WebCore::InspectorNetworkAgent::getResponseBody):
(WebCore::InspectorNetworkAgent::shouldTreatAsText):
(WebCore::InspectorNetworkAgent::createTextDecoder):
(WebCore::InspectorNetworkAgent::textContentForCachedResource):
(WebCore::InspectorNetworkAgent::cachedResourceContent):
(WebCore::textContentForResourceData):
(WebCore::InspectorNetworkAgent::searchOtherRequests):
(WebCore::isErrorStatusCode): Deleted.
(WebCore::InspectorNetworkAgent::didFinishXHRLoading): Deleted.

inspector/agents/InspectorNetworkAgent.h:

Move static PageAgent functions related to the generic data tuple
(content, base64Encoded) to NetworkAgent. Also generalize it to
not rely on the CachedResourceType, but instead rely on the MIME type.
This has a few changes in behavior:

Images, may now be text if they have a text mime type (image/svg+xml).
XHR / Fetch / Other may be sent as text if they have a text mime type.
XHR / Fetch / Other are not assumed to be text, and may be sent as base64 encoded.

For this to be useful the frontend should also check the mime type and
display an appropriate ContentView.

Source/WebInspectorUI:

UserInterface/Base/Utilities.js:

Blob <-> Text conversion helpers.

UserInterface/Models/Resource.js:

(WI.Resource.prototype.createObjectURL):
Previously all Image resources were assumed to have base64Encoded data
which we automatically convert to a Blob. Now that some image data
can be transfered as text, convert that to a Blob here since the output
is expected to be a Blob.

UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.showGenericNoContentMessage):

UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.contentAvailable):
(WI.TextResourceContentView.prototype._contentDidPopulate):

UserInterface/Views/ImageResourceContentView.js:

(WI.ImageResourceContentView.prototype.contentAvailable):
Better handle no content cases.

UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype.get responseContentView):
(WI.ResourceClusterContentView.prototype._contentViewForResourceType):
Make a best effort to find a good ContentView to show the resource data.
This is done by looking at the ResourceType and MIME Type.

UserInterface/Views/SVGImageResourceClusterContentView.js:

(WI.SVGImageResourceClusterContentView.prototype._showContentViewForIdentifier):
Handle if image data is now text (the image/svg+xml case).

LayoutTests:

http/tests/inspector/network/fetch-response-body-expected.txt:
http/tests/inspector/network/fetch-response-body.html:
http/tests/inspector/network/xhr-response-body-expected.txt:
http/tests/inspector/network/xhr-response-body.html:

Update tests for new expectations now that binary data shows as binary.

2:09 PM Changeset in webkit [225545] by jmarcell@apple.com

7 edits in branches/safari-604.5.100-branch/Source

Versioning.

2:03 PM Changeset in webkit [225544] by jmarcell@apple.com

2 edits in branches/safari-604.5.100-branch/Source/WebCore

Cherry-pick r225528. rdar://problem/35839452

2:03 PM Changeset in webkit [225543] by jmarcell@apple.com

4 edits
4 adds in branches/safari-604.5.100-branch

Cherry-pick r225381. rdar://problem/35839452

2:03 PM Changeset in webkit [225542] by jmarcell@apple.com

10 edits
7 adds in branches/safari-604.5.100-branch

Cherry-pick r225273. rdar://problem/35839459

2:03 PM Changeset in webkit [225541] by jmarcell@apple.com

3 edits
1 add in branches/safari-604.5.100-branch

Cherry-pick r225239. rdar://problem/35839454

1:55 PM Changeset in webkit [225540] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

IsoAlignedMemoryAllocator needs to free all of its memory when the VM destructs
https://bugs.webkit.org/show_bug.cgi?id=180425

Reviewed by Saam Barati.

Failure to do so causes leaks after starting workers.

heap/IsoAlignedMemoryAllocator.cpp:

(JSC::IsoAlignedMemoryAllocator::~IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::tryAllocateAlignedMemory):

1:52 PM Changeset in webkit [225539] by jmarcell@apple.com

2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r225528. rdar://problem/35838154

1:52 PM Changeset in webkit [225538] by jmarcell@apple.com

4 edits
4 adds in branches/safari-604-branch

Cherry-pick r225381. rdar://problem/35838154

1:51 PM Changeset in webkit [225537] by commit-queue@webkit.org

22 edits
3 adds in trunk

Implement https://w3c.github.io/ServiceWorker/#clients-claim
https://bugs.webkit.org/show_bug.cgi?id=180261

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-05
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/activation.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/serviceworkerclients-claim.https.html

Implement claim by going to the storage process and then iterate over clients to see whether active worker can be set.
Update SWServerWorker to call registration tryClear/tryActivate whenever a service worker has no pending event.

workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::claim):

workers/service/context/SWContextManager.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::claim):
(WebCore::SWServer::doRegistrationMatching):
(WebCore::SWServer::doRegistrationMatching const): Deleted.

workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::doRegistrationMatching):

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::controlClient):

workers/service/server/SWServerRegistration.h:
workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::claim):

workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::claim):

workers/service/server/SWServerWorker.h:

Source/WebKit:

Add IPC plumbery for clients claim between ServiceWorker process and Storage process.

StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::claimCompleted):

StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::claim):
(WebKit::WebSWContextManagerConnection::claimCompleted):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

http/tests/workers/service/serviceworkerclients-claim-worker.js: Added.
http/tests/workers/service/serviceworkerclients-claim.https-expected.txt: Added.
http/tests/workers/service/serviceworkerclients-claim.https.html: Added.

1:40 PM Changeset in webkit [225536] by pvollan@apple.com

2 edits in trunk/Source/JavaScriptCore

[Win64] Compile error in testmasm.cpp.
https://bugs.webkit.org/show_bug.cgi?id=180436

Reviewed by Mark Lam.

Fix MSVC warning (32-bit shift implicitly converted to 64 bits).

assembler/testmasm.cpp:

(JSC::testGetEffectiveAddress):

1:36 PM Changeset in webkit [225535] by pvollan@apple.com

5 edits in trunk/Source

[Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=180431
<rdar://problem/34531264>

Reviewed by Simon Fraser.

Source/WebCore:

No new tests, covered by existing tests.

When a scroll layer is required, we will create an overflow control hosts layer.
In this case the method RenderLayerCompositor::shouldCompositeOverflowControls()
should return true, otherwise the scrollbars will not be rendered.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls const):

Source/WebKitLegacy/win:

Fix the signatures of GraphicsLayerClient that should have been overridden, and use
'override' to make sure this doesn't break in the future.

WebView.cpp:

(WebView::notifyAnimationStarted):
(WebView::paintContents):

WebView.h:

1:30 PM Changeset in webkit [225534] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Fix style issues in mastercfg_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=180439

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added imports directly instead of relying

on imports from other files. We will try to import minimum required modules. Currently we are importing
everything from master.cfg, loadConfig.py, factories.py and steps.py

1:24 PM Changeset in webkit [225533] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Call "Terminate Service Worker" on all workers when all their clients are gone
https://bugs.webkit.org/show_bug.cgi?id=179552
<rdar://problem/35836323>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-05

workers/service/server/SWServer.cpp: Reducing from 60_s to 10_s based on bugzilla comment.

1:24 PM Changeset in webkit [225532] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Unskip some more Service Worker tests
https://bugs.webkit.org/show_bug.cgi?id=180428

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-05

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:

LayoutTests:

TestExpectations:

12:56 PM Changeset in webkit [225531] by Chris Dumez

18 edits in trunk

Add support for ServiceWorkerContainer.prototype.ready
https://bugs.webkit.org/show_bug.cgi?id=180383

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test coverage container.ready now that it is passing.

web-platform-tests/service-workers/service-worker/ready.https-expected.txt:

Source/WebCore:

Add support for ServiceWorkerContainer.prototype.ready:

https://w3c.github.io/ServiceWorker/#navigator-service-worker-ready

No new tests, rebaselined existing test.

workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::ready):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerRegistrationKey.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::resolveRegistrationReadyRequests):

workers/service/server/SWServer.h:
workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::activate):
(WebCore::SWServerRegistration::setIsUninstalling):

workers/service/server/SWServerRegistration.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::whenRegistrationReady):
(WebKit::WebSWServerConnection::resolveRegistrationReadyRequests):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::whenRegistrationReady):
(WebKit::WebSWClientConnection::registrationReady):
(WebKit::WebSWClientConnection::getRegistrations):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebSWClientConnection.messages.in:

12:34 PM Changeset in webkit [225530] by Yusuke Suzuki

6 edits in trunk/Source/WTF

[WTF] Remove m_atomicStringTableDestructor in Thread by querying the condition at thread destruction
https://bugs.webkit.org/show_bug.cgi?id=180429

Reviewed by Alex Christensen.

We now have a pointer to the AtomicStringTable::destroy in Thread.
This pointer becomes nullptr only when the thread is the web thread not to destroy AtomicStringTable
twice in the UI thread and the web thread.

Instead of having a pointer in each Thread, we query whether the current thread is the web thread at
Thread destruction. And use this information to call AtomicStringTable::destroy. Then, we can drop
m_atomicStringTableDestructor field in Thread.

wtf/Threading.cpp:

(WTF::Thread::didExit):

wtf/Threading.h:
wtf/mac/MainThreadMac.mm:
wtf/text/AtomicStringTable.cpp:

(WTF::AtomicStringTable::create):
(WTF::AtomicStringTable::destroy):

wtf/text/AtomicStringTable.h:

12:26 PM Changeset in webkit [225529] by Yusuke Suzuki

2 edits in trunk/Source/WebCore

Modernize WebThread code for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=180344

Reviewed by Alex Christensen.

When touching Thread and its initialization component, we need to touch
web thread initialization code too. However, since web thread code is old,
it's style is not following to WebKit coding style guidelines.

This patch first modernizes WebThread code for further refactoring.

Type* instead of Type *.
Use std::call_once instead of pthread_once.
Use static_cast instead of C-cast.
Use nullptr instead of NULL.
Use ret or !ret instead of ret != 0 or ret == 0.
Do not use #pragma unused.
if-else with one statement should not have braces.

In this patch, we do not change pthread_condition_t to WTF::Condition and
pthread_mutex_t to WTF::Lock since web thread code requires extra care about
threading.

No behavior change.

platform/ios/wak/WebCoreThread.mm:

(-[NSObject releaseOnMainThread]):
(SendMessage):
(HandleDelegateSource):
(SendDelegateMessage):
(WebThreadAdoptAndRelease):
(lockWebCoreReleaseLock):
(unlockWebCoreReleaseLock):
(WebCoreObjCDeallocOnWebThreadImpl):
(WebCoreObjCDeallocWithWebThreadLockImpl):
(HandleWebThreadReleaseSource):
(WebThreadCallDelegate):
(WebThreadPostNotification):
(WebThreadCallDelegateAsync):
(WebThreadMakeNSInvocation):
(MainRunLoopAutoUnlock):
(_WebThreadAutoLock):
(WebRunLoopLock):
(WebRunLoopUnlock):
(MainRunLoopUnlockGuard):
(CurrentThreadContext):
(RunWebThread):
(StartWebThread):
(WebTimedConditionLock):
(_WebTryThreadLock):
(WebThreadUnlockFromAnyThread):
(WebThreadUnlockGuardForMail):
(_WebThreadUnlock):
(WebThreadIsLocked):
(WebThreadLockPopModal):
(WebThreadCurrentContext):
(WebThreadEnable):
(FreeThreadContext): Deleted.
(InitThreadContextKey): Deleted.

11:06 AM Changeset in webkit [225528] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix non-unified build after r225381
https://bugs.webkit.org/show_bug.cgi?id=180434

Reviewed by Keith Miller.

loader/ResourceTimingInformation.cpp:

FrameLoader.h is included in other files that are combined with this file in unified builds,
but we need to merge r225381 to a branch that doesn't use unified builds. This build failure
would've come up randomly in the future when we add files, too.

10:54 AM Changeset in webkit [225527] by Simon Fraser

12 edits
2 deletes in trunk

Remove webkitGetImageDataHD and webkitPutImageDataHD from canvas API
https://bugs.webkit.org/show_bug.cgi?id=180387

Reviewed by Dean Jackson.

Source/WebCore:

CanvasRenderingContext2D.webkitGetImageDataHD and webkitPutImageDataHD were never standardized,
and Blink removed support in 2014 (https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/FOPH5dloGG8).

Since our canvas backing store is always 1x, they have no use anyway, so remove them.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD const): Deleted.
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD): Deleted.

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.idl:

Source/WebInspectorUI:

Since our canvas backing store is always 1x, they have no use anyway, so remove them.

UserInterface/Models/NativeFunctionParameters.js:
UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.getImageParameters):
(WI.RecordingAction):

UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._classNameForAction.classNameForActionName):
(WI.RecordingActionTreeElement._classNameForAction):

LayoutTests:

Remove the test.

fast/canvas/2d.imageDataHD-expected.txt: Removed.
fast/canvas/2d.imageDataHD.html: Removed.
platform/win/TestExpectations:

10:42 AM Changeset in webkit [225526] by commit-queue@webkit.org

14 edits in trunk/Source

Implement setting of service worker to client in SWServer without going to WebProcess
https://bugs.webkit.org/show_bug.cgi?id=180382

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-05
Reviewed by Chris Dumez.

Source/WebCore:

No change of behavior.

This patch removes the notification of active worker setting from ScriptExecution/WebProcess up to SWServer/StorageProcess.
Instead, active worker setting is fully done/controlled in SWServer.
Whenever there is a change, SWServer notifies WebProcess and ScriptExecutionContext gets updated accordingly.

dom/Document.cpp:

(WebCore::Document::setServiceWorkerConnection):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setActiveServiceWorker):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

workers/service/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::setClientActiveWorker):
(WebCore::SWServer::registerServiceWorkerClient):
(WebCore::SWServer::registrationFromServiceWorkerIdentifier):
(WebCore::SWServer::unregisterServiceWorkerClient):
(WebCore::SWServer::Connection::serviceWorkerStartedControllingClient): Deleted.
(WebCore::SWServer::Connection::serviceWorkerStoppedControllingClient): Deleted.
(WebCore::SWServer::serviceWorkerStartedControllingClient): Deleted.
(WebCore::SWServer::serviceWorkerStoppedControllingClient): Deleted.

workers/service/server/SWServer.h:
workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::activate):

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::registerServiceWorkerClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::registerServiceWorkerClient):
(WebKit::WebSWClientConnection::serviceWorkerStartedControllingClient): Deleted.
(WebKit::WebSWClientConnection::serviceWorkerStoppedControllingClient): Deleted.

WebProcess/Storage/WebSWClientConnection.h:

9:58 AM Changeset in webkit [225525] by aakash_jain@apple.com

2 edits in trunk/Tools

[build.webkit.org] Rename MasterCfgTest to RunWebKitTestsTest
https://bugs.webkit.org/show_bug.cgi?id=180391

Rubber-stamped by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunWebKitTestsTest): Renamed from MasterCfgTest.

9:53 AM Changeset in webkit [225524] by fpizlo@apple.com

66 edits
21 adds
3 deletes in trunk

GC constraint solving should be parallel
https://bugs.webkit.org/show_bug.cgi?id=179934

Reviewed by JF Bastien.
PerformanceTests:

Added a version of splay that measures latency in a way that run-jsc-benchmarks groks.

Octane/splay.js: Added.

(this.Setup.setup.setup):
(this.TearDown.tearDown.tearDown):
(Benchmark):
(BenchmarkResult):
(BenchmarkResult.prototype.valueOf):
(BenchmarkSuite):
(alert):
(Math.random):
(BenchmarkSuite.ResetRNG):
(RunStep):
(BenchmarkSuite.RunSuites):
(BenchmarkSuite.CountBenchmarks):
(BenchmarkSuite.GeometricMean):
(BenchmarkSuite.GeometricMeanTime):
(BenchmarkSuite.AverageAbovePercentile):
(BenchmarkSuite.GeometricMeanLatency):
(BenchmarkSuite.FormatScore):
(BenchmarkSuite.prototype.NotifyStep):
(BenchmarkSuite.prototype.NotifyResult):
(BenchmarkSuite.prototype.NotifyError):
(BenchmarkSuite.prototype.RunSingleBenchmark):
(RunNextSetup):
(RunNextBenchmark):
(RunNextTearDown):
(BenchmarkSuite.prototype.RunStep):
(GeneratePayloadTree):
(GenerateKey):
(SplayUpdateStats):
(InsertNewNode):
(SplaySetup):
(SplayTearDown):
(SplayRun):
(SplayTree):
(SplayTree.prototype.isEmpty):
(SplayTree.prototype.insert):
(SplayTree.prototype.remove):
(SplayTree.prototype.find):
(SplayTree.prototype.findMax):
(SplayTree.prototype.findGreatestLessThan):
(SplayTree.prototype.exportKeys):
(SplayTree.prototype.splay_):
(SplayTree.Node):
(SplayTree.Node.prototype.traverse_):
(report):
(start):

Source/JavaScriptCore:

This makes it possible to do constraint solving in parallel. This looks like a 1% Speedometer
speed-up. It's more than 1% on trunk-Speedometer.

The constraint solver supports running constraints in parallel in two different ways:

Run multiple constraints in parallel to each other. This only works for constraints that can tolerate other constraints running concurrently to them (constraint.concurrency() == ConstraintConcurrency::Concurrent). This is the most basic kind of parallelism that the constraint solver supports. All constraints except the JSC SPI constraints are concurrent. We could probably make them concurrent, but I'm playing it safe for now.

A constraint can create parallel work for itself, which the constraint solver will interleave with other stuff. A constraint can report that it has parallel work by returning ConstraintParallelism::Parallel from its executeImpl() function. Then the solver will allow that constraint's doParallelWorkImpl() function to run on as many GC marker threads as are available, for as long as that function wants to run.

It's not possible to have a non-concurrent constraint that creates parallel work.

The parallelism is implemented in terms of the existing GC marker threads. This turns out to be
most natural for two reasons:

No need to start any other threads.

The constraints all want to be passed a SlotVisitor. Running on the marker threads means having access to those threads' SlotVisitors. Also, it means less load balancing. The solver will create work on each marking thread's SlotVisitor. When the solver is done "stealing" a marker thread, that thread will have work it can start doing immediately. Before this change, we had to contribute the work found by the constraint solver to the global worklist so that it could be distributed to the marker threads by load balancing. This change probably helps to avoid that load balancing step.

A lot of this change is about making it easy to iterate GC data structures in parallel. This
change makes almost all constraints parallel-enabled, but only the DOM's output constraint uses
the parallel work API. That constraint iterates the marked cells in two subspaces. This change
makes it very easy to compose parallel iterators over subspaces, allocators, blocks, and cells.
The marked cell parallel iterator is composed out of parallel iterators for the others. A parallel
iterator is just an iterator that can do an atomic next() very quickly. We abstract them using
RefPtr<SharedTask<...()>>, where ... is the type returned from the iterator. We know it's done
when it returns a falsish version of ... (in the current code, that's always a pointer type, so
done is indicated by null).

API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint):

API/JSVirtualMachine.mm:

(scanExternalObjectGraph):
(scanExternalRememberedSet):

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bytecode/AccessCase.cpp:

(JSC::AccessCase::propagateTransitions const):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitWeakly):
(JSC::CodeBlock::shouldJettisonDueToOldAge):
(JSC::shouldMarkTransition):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):

dfg/DFGWorklist.cpp:
ftl/FTLCompile.cpp:

(JSC::FTL::compile):

heap/ConstraintParallelism.h: Added.

(WTF::printInternal):

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::runFixpointPhase):
(JSC::Heap::stopThePeriphery):
(JSC::Heap::resumeThePeriphery):
(JSC::Heap::addCoreConstraints):
(JSC::Heap::setBonusVisitorTask):
(JSC::Heap::runTaskInParallel):
(JSC::Heap::forEachSlotVisitor): Deleted.

heap/Heap.h:

(JSC::Heap::worldIsRunning const):
(JSC::Heap::runFunctionInParallel):

heap/HeapInlines.h:

(JSC::Heap::worldIsStopped const):
(JSC::Heap::isMarked):
(JSC::Heap::incrementDeferralDepth):
(JSC::Heap::decrementDeferralDepth):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::forEachSlotVisitor):
(JSC::Heap::collectorBelievesThatTheWorldIsStopped const): Deleted.
(JSC::Heap::isMarkedConcurrently): Deleted.

heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::appendNode):

heap/LargeAllocation.h:

(JSC::LargeAllocation::isMarked):
(JSC::LargeAllocation::isMarkedConcurrently): Deleted.

heap/LockDuringMarking.h:

(JSC::lockDuringMarking):

heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::parallelNotEmptyBlockSource):

heap/MarkedAllocator.h:
heap/MarkedBlock.h:

(JSC::MarkedBlock::aboutToMark):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::areMarksStaleWithDependency): Deleted.
(JSC::MarkedBlock::isMarkedConcurrently): Deleted.

heap/MarkedSpace.h:

(JSC::MarkedSpace::activeWeakSetsBegin):
(JSC::MarkedSpace::activeWeakSetsEnd):
(JSC::MarkedSpace::newActiveWeakSetsBegin):
(JSC::MarkedSpace::newActiveWeakSetsEnd):

heap/MarkingConstraint.cpp:

(JSC::MarkingConstraint::MarkingConstraint):
(JSC::MarkingConstraint::execute):
(JSC::MarkingConstraint::quickWorkEstimate):
(JSC::MarkingConstraint::workEstimate):
(JSC::MarkingConstraint::doParallelWork):
(JSC::MarkingConstraint::finishParallelWork):
(JSC::MarkingConstraint::doParallelWorkImpl):
(JSC::MarkingConstraint::finishParallelWorkImpl):

heap/MarkingConstraint.h:

(JSC::MarkingConstraint::lastExecuteParallelism const):
(JSC::MarkingConstraint::parallelism const):
(JSC::MarkingConstraint::quickWorkEstimate): Deleted.
(JSC::MarkingConstraint::workEstimate): Deleted.

heap/MarkingConstraintSet.cpp:

(JSC::MarkingConstraintSet::MarkingConstraintSet):
(JSC::MarkingConstraintSet::add):
(JSC::MarkingConstraintSet::executeConvergence):
(JSC::MarkingConstraintSet::executeConvergenceImpl):
(JSC::MarkingConstraintSet::executeAll):
(JSC::MarkingConstraintSet::ExecutionContext::ExecutionContext): Deleted.
(JSC::MarkingConstraintSet::ExecutionContext::didVisitSomething const): Deleted.
(JSC::MarkingConstraintSet::ExecutionContext::shouldTimeOut const): Deleted.
(JSC::MarkingConstraintSet::ExecutionContext::drain): Deleted.
(JSC::MarkingConstraintSet::ExecutionContext::didExecute const): Deleted.
(JSC::MarkingConstraintSet::ExecutionContext::execute): Deleted.
(): Deleted.

heap/MarkingConstraintSet.h:
heap/MarkingConstraintSolver.cpp: Added.

(JSC::MarkingConstraintSolver::MarkingConstraintSolver):
(JSC::MarkingConstraintSolver::~MarkingConstraintSolver):
(JSC::MarkingConstraintSolver::didVisitSomething const):
(JSC::MarkingConstraintSolver::execute):
(JSC::MarkingConstraintSolver::drain):
(JSC::MarkingConstraintSolver::converge):
(JSC::MarkingConstraintSolver::runExecutionThread):
(JSC::MarkingConstraintSolver::didExecute):

heap/MarkingConstraintSolver.h: Added.
heap/OpaqueRootSet.h: Removed.
heap/ParallelSourceAdapter.h: Added.

(JSC::ParallelSourceAdapter::ParallelSourceAdapter):
(JSC::createParallelSourceAdapter):

heap/SimpleMarkingConstraint.cpp: Added.

(JSC::SimpleMarkingConstraint::SimpleMarkingConstraint):
(JSC::SimpleMarkingConstraint::~SimpleMarkingConstraint):
(JSC::SimpleMarkingConstraint::quickWorkEstimate):
(JSC::SimpleMarkingConstraint::executeImpl):

heap/SimpleMarkingConstraint.h: Added.
heap/SlotVisitor.cpp:

(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::updateMutatorIsStopped):
(JSC::SlotVisitor::mutatorIsStoppedIsUpToDate const):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::performIncrementOfDraining):
(JSC::SlotVisitor::didReachTermination):
(JSC::SlotVisitor::hasWork):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::drainInParallelPassively):
(JSC::SlotVisitor::waitForTermination):
(JSC::SlotVisitor::addOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRoot const): Deleted.
(JSC::SlotVisitor::containsOpaqueRootTriState const): Deleted.
(JSC::SlotVisitor::mergeIfNecessary): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable): Deleted.
(JSC::SlotVisitor::mergeOpaqueRoots): Deleted.

heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot const):
(JSC::SlotVisitor::vm):
(JSC::SlotVisitor::vm const):

heap/Subspace.cpp:

(JSC::Subspace::parallelAllocatorSource):
(JSC::Subspace::parallelNotEmptyMarkedBlockSource):

heap/Subspace.h:
heap/SubspaceInlines.h:

(JSC::Subspace::forEachMarkedCellInParallel):

heap/VisitCounter.h: Added.

(JSC::VisitCounter::VisitCounter):
(JSC::VisitCounter::visitCount const):

heap/VisitingTimeout.h: Removed.
heap/WeakBlock.cpp:

(JSC::WeakBlock::specializedVisit):

runtime/Structure.cpp:

(JSC::Structure::isCheapDuringGC):
(JSC::Structure::markIfCheap):

Source/WebCore:

No new tests because no change in behavior. This change is best tested using DOM-GC-intensive
benchmarks like Speedometer and Dromaeo.

This parallelizes the DOM's output constraint, and makes some small changes to make this more
scalable.

ForwardingHeaders/heap/SimpleMarkingConstraint.h: Added.
ForwardingHeaders/heap/VisitingTimeout.h: Removed.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/DOMGCOutputConstraint.cpp: Added.

(WebCore::DOMGCOutputConstraint::DOMGCOutputConstraint):
(WebCore::DOMGCOutputConstraint::~DOMGCOutputConstraint):
(WebCore::DOMGCOutputConstraint::executeImpl):
(WebCore::DOMGCOutputConstraint::doParallelWorkImpl):
(WebCore::DOMGCOutputConstraint::finishParallelWorkImpl):

bindings/js/DOMGCOutputConstraint.h: Added.
bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::initNormalWorld):

dom/Node.cpp:

(WebCore::Node::eventTargetDataConcurrently):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::clearEventTargetData):

Source/WTF:

This does some changes to make it easier to do parallel constraint solving:

I finally removed dependencyWith. This was a silly construct whose only purpose is to confuse people about what it means to have a dependency chain. I took that as an opportunity to grealy simplify the GC's use of dependency chaining.

Added more logic to Deque<>, since I use it for part of the load balancer.

Made it possible to profile lock contention. See https://bugs.webkit.org/show_bug.cgi?id=180250#c0 for some preliminary measurements.

Introduced holdLockIf, which makes it easy to perform predicated lock acquisition. We use that to pick a lock in WebCore.

Introduced CountingLock. It's like WTF::Lock except it also enables optimistic read transactions sorta like Java's StampedLock.

WTF.xcodeproj/project.pbxproj:
wtf/Atomics.h:

(WTF::dependency):
(WTF::DependencyWith::DependencyWith): Deleted.
(WTF::dependencyWith): Deleted.

wtf/BitVector.h:

(WTF::BitVector::iterator::operator++):

wtf/CMakeLists.txt:
wtf/ConcurrentPtrHashSet.cpp: Added.

(WTF::ConcurrentPtrHashSet::ConcurrentPtrHashSet):
(WTF::ConcurrentPtrHashSet::~ConcurrentPtrHashSet):
(WTF::ConcurrentPtrHashSet::deleteOldTables):
(WTF::ConcurrentPtrHashSet::clear):
(WTF::ConcurrentPtrHashSet::initialize):
(WTF::ConcurrentPtrHashSet::addSlow):
(WTF::ConcurrentPtrHashSet::resizeIfNecessary):
(WTF::ConcurrentPtrHashSet::resizeAndAdd):
(WTF::ConcurrentPtrHashSet::Table::create):

wtf/ConcurrentPtrHashSet.h: Added.

(WTF::ConcurrentPtrHashSet::contains):
(WTF::ConcurrentPtrHashSet::add):
(WTF::ConcurrentPtrHashSet::size const):
(WTF::ConcurrentPtrHashSet::Table::maxLoad const):
(WTF::ConcurrentPtrHashSet::hash):
(WTF::ConcurrentPtrHashSet::cast):
(WTF::ConcurrentPtrHashSet::containsImpl const):
(WTF::ConcurrentPtrHashSet::addImpl):

wtf/Deque.h:

(WTF::inlineCapacity>::takeFirst):

wtf/FastMalloc.h:
wtf/Lock.cpp:

(WTF::LockBase::lockSlow):

wtf/Locker.h:

(WTF::holdLockIf):

wtf/ScopedLambda.h:
wtf/SharedTask.h:

(WTF::SharedTask<PassedResultType):
(WTF::SharedTask<ResultType): Deleted.

wtf/StackShot.h: Added.

(WTF::StackShot::StackShot):
(WTF::StackShot::operator=):
(WTF::StackShot::array const):
(WTF::StackShot::size const):
(WTF::StackShot::operator bool const):
(WTF::StackShot::operator== const):
(WTF::StackShot::hash const):
(WTF::StackShot::isHashTableDeletedValue const):
(WTF::StackShot::operator> const):
(WTF::StackShot::deletedValueArray):
(WTF::StackShotHash::hash):
(WTF::StackShotHash::equal):

wtf/StackShotProfiler.h: Added.

(WTF::StackShotProfiler::StackShotProfiler):
(WTF::StackShotProfiler::profile):
(WTF::StackShotProfiler::run):

Tools:

Scripts/run-jsc-benchmarks: Add splay-latency test, since this change needed to be carefully validated with that benchmark.
TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp: Added. This has unit tests of the new concurrent data structure. The tests focus on correctness under serial execution, which appears to be enough for now (it's so easy to catch a concurrency bug by just running the GC).

(TestWebKitAPI::TEST):

9:28 AM Changeset in webkit [225523] by Yusuke Suzuki

3 edits in trunk/Source/WTF

[WTF] Use m_suspendCount instead of m_suspended flag in Thread
https://bugs.webkit.org/show_bug.cgi?id=180427

Reviewed by Carlos Garcia Campos.

When resuming the thread, signal handler is reinvoked once before sigsuspend is resumed.
But this handler should not do anything since it is just a signal for sigsuspend.
Previously, we use m_suspenedd flag to distinguish between suspending and resuming signal
handler invocations.

But this additional m_suspended flag is not necessary since we can use m_suspendCount instead.
This patch drops m_suspended and use m_suspendCount. Since semaphore operations emit full memory
barrier, m_suspendCount is loaded and stored as we expect.

wtf/Threading.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::signalHandlerSuspendResume):
(WTF::Thread::suspend):
(WTF::Thread::resume):

8:21 AM Changeset in webkit [225522] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[Win] Skip tests that depend on UIScriptController::zoomToScale
https://bugs.webkit.org/show_bug.cgi?id=180423

Patch by Ali Juma <ajuma@chromium.org> on 2017-12-05
Reviewed by Frédéric Wang.

Test gardening.

UIScriptController::zoomToScale is not implemented on Windows, so skip tests that use it.

platform/win/TestExpectations:

12:22 AM Changeset in webkit [225521] by graouts@webkit.org

2 edits in trunk/Source/WebCore

<video> and scale() transforms yield shrunk small or clipped controls
https://bugs.webkit.org/show_bug.cgi?id=180358
<rdar://problem/34436124>

Unreviewed.

Use DOMMatrix vs. WebKitCSSMatrix per Simon's post-commit review feedback.

Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsSize):

12:02 AM Changeset in webkit [225520] by zandobersek@gmail.com

6 edits in trunk/LayoutTests

Unreviewed WPE gardening. Rebaseline a quintet of SVG tests.

platform/wpe/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
platform/wpe/svg/custom/feComponentTransfer-Discrete-expected.txt:
platform/wpe/svg/custom/feComponentTransfer-Gamma-expected.txt:
platform/wpe/svg/custom/feComponentTransfer-Linear-expected.txt:
platform/wpe/svg/custom/feComponentTransfer-Table-expected.txt:

Dec 4, 2017:

11:51 PM Changeset in webkit [225519] by jfbastien@apple.com

2 edits in trunk/Source/JavaScriptCore

Math: don't redundantly check for exceptions, just release scope
https://bugs.webkit.org/show_bug.cgi?id=180395

Rubber stamped by Mark Lam.

Two of the exceptions checks could just have been exception scope
releases before the return, which is ever-so-slightly more
efficient. The same technically applies where we have loops over
parameters, but doing the scope release there isn't really more
efficient and is way harder to read.

runtime/MathObject.cpp:

(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncPow):

10:25 PM Changeset in webkit [225518] by jmarcell@apple.com

10 edits
7 adds in branches/safari-604-branch

Cherry-pick r225273. rdar://problem/35838163

10:25 PM Changeset in webkit [225517] by jmarcell@apple.com

3 edits
1 add in branches/safari-604-branch

Cherry-pick r225239. rdar://problem/35838157

9:23 PM Changeset in webkit [225516] by mitz@apple.com

8 copies
1 add in releases/Apple/iOS 11.2

Added a tag for iOS 11.2.

9:20 PM Changeset in webkit [225515] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari 11.0.1

Added a tag for Safari 11.0.1.

9:18 PM Changeset in webkit [225514] by mitz@apple.com

8 copies
1 add in releases/Apple/iOS 11.1

Added a tag for iOS 11.1

6:06 PM Changeset in webkit [225513] by Chris Dumez

17 edits
3 adds in trunk

Support container.getRegistration() / getRegistrations() inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180360

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/activation.https-expected.txt:

Rebaseline test with slightly different output.

web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html:

With my change, this test started running and passing a check before timing out. When investigating the time
out, I found out that this is caused by the test unregistering the worker while the test is still running
in the service worker, which causes the worker to terminate early. To address the issue, we no longer add
a cleanup step to unregister. The test now passes all checks.

Source/WebCore:

Support container.getRegistration() / getRegistrations() inside service workers
by making sure we hop to the right thread when needed.

Test: http/tests/workers/service/ServiceWorkerGlobalScope_getRegistration.html

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::postTaskTo):

dom/ScriptExecutionContext.h:
workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::clearPendingJobs):

workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::didFinishGetRegistrationRequest):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::didFinishGetRegistrationsRequest):
(WebCore::ServiceWorkerContainer::stop):

workers/service/ServiceWorkerContainer.h:

Source/WebKit:

WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::didMatchRegistration):
(WebKit::WebSWClientConnection::didGetRegistrations):
(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::getRegistrations):

LayoutTests:

Add layout test coverage.

http/tests/workers/service/ServiceWorkerGlobalScope_getRegistration-expected.txt: Added.
http/tests/workers/service/ServiceWorkerGlobalScope_getRegistration.html: Added.
http/tests/workers/service/resources/ServiceWorkerGlobalScope_getRegistration-worker.js: Added.

5:37 PM Changeset in webkit [225512] by Simon Fraser

5 edits in trunk/Source/WebCore

Cleanup code that computes iframe content offsets in FrameView
https://bugs.webkit.org/show_bug.cgi?id=180385

Reviewed by Zalan Bujtas.

The coordinate conversion functions in FrameView explicitly added borderLeft/paddingLeft
and borderTop/paddingTop to compute the offset from the contents of a frame to its parent renderer.

This is equivalent to the call to contextBoxRect() that RenderWidget::updateWidgetGeometry() does,
which also takes left-side scrollbars into account.

Coordinate offsets don't need height and width, so add RenderBox::contentBoxLocation() that just
computes the top left, and use it in FrameView.

page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::convertToContainingView const):
(WebCore::FrameView::convertFromContainingView const):

platform/graphics/FloatPoint.h:

(WebCore::FloatPoint::scaled const):
(WebCore::FloatPoint::scaled): Deleted.

rendering/RenderBox.cpp:

(WebCore::RenderBox::contentBoxLocation const):

rendering/RenderBox.h:

5:24 PM Changeset in webkit [225511] by n_wang@apple.com

13 edits
2 adds in trunk

AX: AOM: Implement relation type properties
https://bugs.webkit.org/show_bug.cgi?id=179500

Reviewed by Ryosuke Niwa.

Source/WebCore:

Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/

Implemented the AOM support for activeDescendant, details and errorMessage.
The corresponding ARIA attributes all take IDREFs, and the AOM properties
take references to AccessibleNodes instead.

Test: accessibility/mac/AOM-relation-property.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::getAttribute const):
(WebCore::AccessibilityObject::hasProperty const):
(WebCore::AccessibilityObject::stringValueForProperty const):
(WebCore::AccessibilityObject::boolValueForProperty const):
(WebCore::AccessibilityObject::intValueForProperty const):
(WebCore::AccessibilityObject::unsignedValueForProperty const):
(WebCore::AccessibilityObject::doubleValueForProperty const):
(WebCore::AccessibilityObject::elementValueForProperty const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::elementsFromProperty const):
(WebCore::AccessibilityObject::elementsReferencedByProperty const):
(WebCore::AccessibilityObject::ariaActiveDescendantReferencingElements const):
(WebCore::AccessibilityObject::ariaDetailsElements const):
(WebCore::AccessibilityObject::ariaDetailsReferencingElements const):
(WebCore::AccessibilityObject::ariaErrorMessageElements const):
(WebCore::AccessibilityObject::ariaErrorMessageReferencingElements const):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::activeDescendant const):

accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueRelation):
(WebCore::AccessibleNode::attributeFromAXPropertyName):
(WebCore::AccessibleNode::setRelationProperty):
(WebCore::AccessibleNode::singleRelationValueForProperty):
(WebCore::AccessibleNode::activeDescendant const):
(WebCore::AccessibleNode::setActiveDescendant):
(WebCore::AccessibleNode::details const):
(WebCore::AccessibleNode::setDetails):
(WebCore::AccessibleNode::errorMessage const):
(WebCore::AccessibleNode::setErrorMessage):

accessibility/AccessibleNode.h:
accessibility/AccessibleNode.idl:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
(WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):

LayoutTests:

Only enable this test on WK2.

accessibility/mac/AOM-relation-property-expected.txt: Added.
accessibility/mac/AOM-relation-property.html: Added.
platform/mac-wk1/TestExpectations:

5:19 PM Changeset in webkit [225510] by beidson@apple.com

2 edits in trunk/Source/WebKit

Followup to:
Get a directory path to SWServers for storing ServiceWorker registrations
https://bugs.webkit.org/show_bug.cgi?id=180362

Unreviewed.

StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::swServerForSession): Change this ASSERT which is invalid in private browsing sessions.

5:13 PM Changeset in webkit [225509] by Simon Fraser

12 edits in trunk

Minor DisplayRefreshMonitor-related cleanup
https://bugs.webkit.org/show_bug.cgi?id=179802

Reviewed by Sam Weinig.

Source/WebCore:

New trace point for when the CVDisplayLink fires on its own thread.

Some #pragma once, and put all the WellKnownRunLoopOrders in one place.

inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

platform/cf/RunLoopObserver.h:
platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

platform/graphics/ca/LayerFlushScheduler.h:
platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::LayerFlushScheduler):

Source/WebKit:

Use RunLoopObserver::WellKnownRunLoopOrders. We want to fire before layer flushing.

UIProcess/WebPageProxy.cpp:

(WebKit::m_configurationPreferenceValues):

Source/WTF:

New trace point for when the CVDisplayLink fires on its own thread.

wtf/SystemTracing.h:

Tools:

New trace point for when the CVDisplayLink fires on its own thread.

Tracing/SystemTracePoints.plist:

5:11 PM Changeset in webkit [225508] by Brent Fulgham

2 edits in trunk/Source/WebKit

Don't force creation of process pool when enabling resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=180374
<rdar://problem/35545639>

Reviewed by Alex Christensen.

Pass appropriate arguments to the 'processPool' accessor so that we only get the
set of existing process pools. We don't want to pay the cost of launching new
process pools just to set this flag. The flag will be properly set when the pools
are created as soon as a WebView is instantiated.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):

4:57 PM Changeset in webkit [225507] by commit-queue@webkit.org

16 edits
5 adds in trunk

Add a class for parsing application manifests
https://bugs.webkit.org/show_bug.cgi?id=177973
rdar://problem/34747949

Patch by David Quesada <david_quesada@apple.com> on 2017-12-04
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Source/WebCore:

Add a new struct ApplicationManifest, along with ApplicationManifestParser to initialize
ApplicationManifests from JSON data, according to the App Manifest spec. Just a basic subset
of the manifests's properties are implemented to start with.

ApplicationManifestParser is tested by new unit tests in TestWebKitAPI.

Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
Modules/applicationmanifest/ApplicationManifest.h: Added.
Modules/applicationmanifest/ApplicationManifestParser.cpp: Added.

(WebCore::ApplicationManifestParser::parse):
The main entry point for eventual clients (and currently the unit tests) to invoke
ApplicationManifestParser. There is a variant that accepts a ScriptExecutionContext that
uses the context exclusively for logging console warnings while parsing the manifest, and
not for actually executing any scripts.
(WebCore::ApplicationManifestParser::ApplicationManifestParser):
(WebCore::ApplicationManifestParser::parseManifest):
(WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
(WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
(WebCore::ApplicationManifestParser::logDeveloperWarning):
(WebCore::ApplicationManifestParser::parseStartURL):
(WebCore::ApplicationManifestParser::parseName):
(WebCore::ApplicationManifestParser::parseDescription):
(WebCore::ApplicationManifestParser::parseShortName):
(WebCore::isInScope):
(WebCore::ApplicationManifestParser::parseScope):
(WebCore::ApplicationManifestParser::parseGenericString):

Modules/applicationmanifest/ApplicationManifestParser.h: Added.
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
features.json: Change the Web App Manifest feature status to "In Development"

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Source/WebKit:

Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Tools:

Add basic unit tests for ApplicationManifestParser. For each of the implemented top-level properties,
attempt to parse manifests with varying types of valid and invalid data to ensure the resulting
ApplicationManifest is configured with the appropriate values per the spec.

TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: Added.

(ApplicationManifestParserTest::SetUp):
(ApplicationManifestParserTest::parseString):
(ApplicationManifestParserTest::parseTopLevelProperty):
(ApplicationManifestParserTest::testStartURL):
(ApplicationManifestParserTest::testName):
(ApplicationManifestParserTest::testDescription):
(ApplicationManifestParserTest::testShortName):
(ApplicationManifestParserTest::testScope):
(assertManifestHasDefaultValues):
(TEST_F):

4:51 PM Changeset in webkit [225506] by Alan Bujtas

4 edits in trunk/Source/WebCore

RenderMultiColumnFlow::fragmentedFlowDescendantInserted should not destroy incoming newDescendant
https://bugs.webkit.org/show_bug.cgi?id=180181

Reviewed by Antti Koivisto.

This is in preparation for having all multicolumn related tree mutation in RenderTreeUpdaterMultiColumn.

Covered by fast/multicol/column-span-range-crash.html

rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):

rendering/RenderMultiColumnFlow.h:
style/RenderTreeUpdaterMultiColumn.cpp:

(WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow):

4:13 PM Changeset in webkit [225505] by Wenson Hsieh

3 edits in trunk/Source/WebKit

Rename a static helper in TouchBarMenuItemData.cpp to match style guidelines.
https://bugs.webkit.org/show_bug.cgi?id=180305

Reviewed by Andy Estes.

Style guidelines state that we should use bare words for getters, so getItemType should just be
itemType. Since this collides with the itemType member variable, this patch also renames that
member variable to the more concise "type".

No change in behavior.

Shared/TouchBarMenuItemData.cpp:

(WebKit::itemType):
(WebKit::TouchBarMenuItemData::TouchBarMenuItemData):
(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):
(WebKit::getItemType): Deleted.

Shared/TouchBarMenuItemData.h:

(WebKit::operator==):

4:11 PM Changeset in webkit [225504] by jmarcell@apple.com

4 edits
1 add in tags/Safari-605.1.15.2

Cherry-pick r225383. rdar://problem/35709469

4:09 PM Changeset in webkit [225503] by jmarcell@apple.com

7 edits in tags/Safari-605.1.15.2/Source

Versioning.

4:07 PM Changeset in webkit [225502] by jmarcell@apple.com

1 copy in tags/Safari-605.1.15.2

New tag.

4:06 PM Changeset in webkit [225501] by BJ Burg

9 edits in trunk/Source

Web Automation: add flag to preserve legacy page screenshot behavior
https://bugs.webkit.org/show_bug.cgi?id=180313
<rdar://problem/34379930>

Reviewed by Joseph Pecoraro.

Source/WebDriver:

Set the clipToViewport flag to true when sending Automation.takeScreenshot.
This preserves the current behavior for this driver implementation.

Session.cpp:

(WebDriver::Session::takeScreenshot):

Source/WebKit:

For compatibility with JSON Wire Protocol implemented by Safari,
we need to retain the ability to perform whole page contents
snapshots using Automation.takeScreenshot. Add an extra flag,
clipToViewport, which can be used by W3C-conforming drivers.

UIProcess/Automation/Automation.json: Add new flag.
UIProcess/Automation/WebAutomationSession.h:
UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::takeScreenshot):

WebProcess/Automation/WebAutomationSessionProxy.h:
WebProcess/Automation/WebAutomationSessionProxy.messages.in:
WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::snapshotRectForScreenshot):
(WebKit::WebAutomationSessionProxy::takeScreenshot):
If the flag is false, take a screenshot of the whole page contents.

4:03 PM Changeset in webkit [225500] by aakash_jain@apple.com

3 edits in trunk/Tools

Add docstring in EarlyWarningSystemTask to explain return values
https://bugs.webkit.org/show_bug.cgi?id=180303

Reviewed by Daniel Bates.

Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

(EarlyWarningSystemTask.run): Added docstring to explain return values.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch): Added comment to explain the result of unlocking a patch.

3:34 PM Changeset in webkit [225499] by jfbastien@apple.com

57 edits
1 add in trunk

Update std::expected to match libc++ coding style
https://bugs.webkit.org/show_bug.cgi?id=180264

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Update various uses of Expected.

wasm/WasmModule.h:
wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseImport):
(JSC::Wasm::ModuleParser::parseTableHelper):
(JSC::Wasm::ModuleParser::parseTable):
(JSC::Wasm::ModuleParser::parseMemoryHelper):

wasm/WasmParser.h:
wasm/generateWasmValidateInlinesHeader.py:

(loadMacro):
(storeMacro):

wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::createStub):

wasm/js/JSWebAssemblyModule.h:

Source/WebCore:

Update various uses of Expected, mostly renaming valueOr and
hasValue to the STL naming convention.

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):

Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::open):
(WebCore::DOMCacheStorage::remove):

Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::recordsDataOrErrorFromRecords):
(WebCore::recordsOrErrorFromRecordsData):

bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadRule):
(WebCore::ContentExtensions::loadEncodedRules):
(WebCore::ContentExtensions::parseRuleList):

css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::loadBestFitImage):

css/CSSImageValue.cpp:

(WebCore::CSSImageValue::loadImage):

css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

dom/CallbackResult.h:

(WebCore::CallbackResult<ReturnType>::type const):
(WebCore::CallbackResult<ReturnType>::releaseReturnValue):

dom/Element.cpp:

(WebCore::Element::getIntegralAttribute const):
(WebCore::Element::getUnsignedIntegralAttribute const):

dom/ExceptionOr.h:

(WebCore::ExceptionOr<ReturnType>::hasException const):
(WebCore::ExceptionOr<void>::hasException const):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::maxLengthAttributeChanged):
(WebCore::HTMLInputElement::minLengthAttributeChanged):

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLengthAttributeChanged):
(WebCore::HTMLTextAreaElement::minLengthAttributeChanged):

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLNonNegativeInteger):

html/parser/HTMLParserIdioms.h:

(WebCore::limitToOnlyHTMLNonNegative):

loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::loadMainResource):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::loadLink):

loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load):

loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

platform/URLParser.cpp:

(WebCore::URLParser::parseIPv4Host):

platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::startLoading):

platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):

svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateExternalDocument):

xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

Source/WebKit:

Update various uses of Expected, mostly renaming valueOr and
hasValue to the STL naming convention.

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::Engine::clearMemoryRepresentation):

NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::ReadRecordTaskCounter::appendRecord):
(WebKit::CacheStorage::Cache::updateRecordToDisk):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::readCachesFromDisk):

NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::createResolver):

Platform/IPC/ArgumentCoders.h:

Source/WTF:

As of https://wg21.link/p0323r4 std::expected is on its way to the
Library Fundamentals v3 TS (LEWG and EWG voted for this, but LWG
hasn't done wording review yet, hence "on its way"). The API is
therefore pretty close to what will be in the TS, and I've gotten
requests for an easily usable implementation of std::expected. I
talked to our clang team and they'll help me migrate our
implementation to libc++, but our implementation has to look more
like libc++ than it does now. Once in libc++ I'll maintain changes
on both sides to make sure neither is out-of-date for too long.

Fork std::unexpected into its own header.
Add mild support for an exception-based implementation, but don't do noexcept yet.
Rename everything to follow STL style, and keep a global using or variable alias where possible to reduce WebKit code churn.
Minor API updates to remove things that aren't in the proposal anymore.

wtf/Expected.h:

(std::experimental::fundamentals_v3::bad_expected_access<void>::bad_expected_access):
(std::experimental::fundamentals_v3::bad_expected_access::bad_expected_access):
(std::experimental::fundamentals_v3::bad_expected_access::error):
(std::experimental::fundamentals_v3::bad_expected_access::error const):
(std::experimental::fundamentals_v3::expected_detail::constexpr_base::constexpr_base):
(std::experimental::fundamentals_v3::expected_detail::base::base):
(std::experimental::fundamentals_v3::expected_detail::base::~base):
(std::experimental::fundamentals_v3::expected::expected):
(std::experimental::fundamentals_v3::expected::operator=):
(std::experimental::fundamentals_v3::expected::swap):
(std::experimental::fundamentals_v3::expected::operator-> const):
(std::experimental::fundamentals_v3::expected::operator->):
(std::experimental::fundamentals_v3::expected::operator* const):
(std::experimental::fundamentals_v3::expected::operator*):
(std::experimental::fundamentals_v3::expected::has_value const):
(std::experimental::fundamentals_v3::expected::value const):
(std::experimental::fundamentals_v3::expected::value):
(std::experimental::fundamentals_v3::expected::error const):
(std::experimental::fundamentals_v3::expected::error):
(std::experimental::fundamentals_v3::expected::value_or const):
(std::experimental::fundamentals_v3::expected::value_or):
(std::experimental::fundamentals_v3::operator==):
(std::experimental::fundamentals_v3::operator!=):
(std::experimental::fundamentals_v3::swap):
(WTF::Unexpected::Unexpected): Deleted.
(WTF::Unexpected::value const): Deleted.
(WTF::Unexpected::value): Deleted.
(WTF::operator==): Deleted.
(WTF::operator!=): Deleted.
(WTF::makeUnexpected): Deleted.
(WTF::ExpectedDetail::Throw): Deleted.
(WTF::ExpectedDetail::destroy): Deleted.
(WTF::ExpectedDetail::std::is_trivially_destructible<T>::value): Deleted.
(WTF::ExpectedDetail::ConstexprBase::ConstexprBase): Deleted.
(WTF::ExpectedDetail::Base::Base): Deleted.
(WTF::ExpectedDetail::Base::~Base): Deleted.
(WTF::Expected::Expected): Deleted.
(WTF::Expected::operator=): Deleted.
(WTF::Expected::swap): Deleted.
(WTF::Expected::operator-> const): Deleted.
(WTF::Expected::operator->): Deleted.
(WTF::Expected::operator* const): Deleted.
(WTF::Expected::operator*): Deleted.
(WTF::Expected::operator bool const): Deleted.
(WTF::Expected::hasValue const): Deleted.
(WTF::Expected::value const): Deleted.
(WTF::Expected::value): Deleted.
(WTF::Expected::error const): Deleted.
(WTF::Expected::error): Deleted.
(WTF::Expected::getUnexpected const): Deleted.
(WTF::Expected::valueOr const): Deleted.
(WTF::Expected::valueOr): Deleted.
(WTF::swap): Deleted.
(WTF::makeExpected): Deleted.
(WTF::makeExpectedFromError): Deleted.

wtf/Forward.h:
wtf/Optional.h:
wtf/StdLibExtras.h:
wtf/Unexpected.h: Added.

(std::experimental::fundamentals_v3::unexpected::unexpected):
(std::experimental::fundamentals_v3::unexpected::value const):
(std::experimental::fundamentals_v3::unexpected::value):
(std::experimental::fundamentals_v3::operator==):
(std::experimental::fundamentals_v3::operator!=):
(makeUnexpected):

Tools:

Update tests according to name changes as well as removal of
now-gone APIs.

TestWebKitAPI/Tests/WTF/Expected.cpp:

(std::experimental::fundamentals_v3::operator<<):
(TestWebKitAPI::TEST):
(WTF::operator<<): Deleted.

TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:

(TestWebKitAPI::testParseHTMLInteger):
(TestWebKitAPI::testParseHTMLNonNegativeInteger):

3:05 PM Changeset in webkit [225498] by Ross Kirsling

2 edits in trunk/Tools

download-latest-github-release.py should use existing release ANY time latest is not found
https://bugs.webkit.org/show_bug.cgi?id=180293

Reviewed by Per Arne Vollan.

Scripts/download-latest-github-release.py:

(find_latest_release):
Handle all URLErrors, not just HTTPErrors. Stop special-casing 404s.

(main):
Rearrange logic so any failure to detect a latest release falls back to an existing release. Improve logging.

(Status):
(download_release):
(load_version_info): Renamed from existing_version info.
(has_latest_release): Deleted.
Cleanup.

2:52 PM Changeset in webkit [225497] by Alan Bujtas

3 edits
2 adds in trunk

REGRESSION (r211531): Text flow changes and overlaps other text after double-click selecting paragraph
https://bugs.webkit.org/show_bug.cgi?id=180377
<rdar://problem/34337967>

Reviewed by Antti Koivisto.

Source/WebCore:

Take floats into account when computing the available width for a certain vertical position.

Test: fast/block/float/simple-line-layout-float-shrink-line.html

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::updateLineConstrains):

LayoutTests:

fast/block/float/simple-line-layout-float-shrink-line-expected.html: Added.
fast/block/float/simple-line-layout-float-shrink-line.html: Added.

2:51 PM Changeset in webkit [225496] by commit-queue@webkit.org

3 edits in trunk/Tools

Exclude some more leak callstacks
https://bugs.webkit.org/show_bug.cgi?id=180379

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-04
Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/port/leakdetector.py:

(LeakDetector._types_to_exclude_from_leaks):
(LeakDetector._callstacks_to_exclude_from_leaks):
(LeakDetector._leaks_args):
(LeakDetector._types_to_exlude_from_leaks): Deleted.

Scripts/webkitpy/port/leakdetector_unittest.py:

(LeakDetectorTest.test_leaks_args):

2:49 PM Changeset in webkit [225495] by commit-queue@webkit.org

3 edits
2 adds in trunk

<video> and scale() transforms yield shrunk small or clipped controls
https://bugs.webkit.org/show_bug.cgi?id=180358
<rdar://problem/34436124>

Patch by Antoine Quint <Antoine Quint> on 2017-12-04
Reviewed by Dean Jackson.

Source/WebCore:

To compute the bounds of the media controls, we would call getBoundingClientRect()
on the root-most element in the shadow root, which is styled to have width and height
set to 100%, which allows to match the metrics of the host media element, without
the borders.

However, if the host media element has CSS transforms applied, these would be factored
into calls to getBoundingClientRect() and the controls would be too large and clipped,
in case the scale was more than 1, or shrunk, in case the scale was less than 1.

To obtain correct metrics, we computed the complete transformation matrix applied to
the host media element, and apply its inverted matrix to each corner point of the
bounds returned for the root-most container element in the shadow root.

Then we compute the width and height of this transformed rectangle and set those to
be our media controls' metrics.

Test: media/modern-media-controls/css/transformed-media.html

Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsSize):
(MediaController.prototype._controlsWidth): Deleted.

LayoutTests:

Write a new test that ensures that we reflect the width and height, not accounting
for borders, of the host media element when sizing media controls.

media/modern-media-controls/css/transformed-media-expected.txt: Added.
media/modern-media-controls/css/transformed-media.html: Added.

2:47 PM Changeset in webkit [225494] by commit-queue@webkit.org

4 edits
2 deletes in trunk

Cursor is not visible after exiting full screen video
https://bugs.webkit.org/show_bug.cgi?id=180247
<rdar://problem/33885922>

Patch by Antoine Quint <Antoine Quint> on 2017-12-04
Reviewed by Dean Jackson.

Source/WebCore:

There is a dedicated NSCursor method to temporarily hide the mouse cursor while the mouse is idle,
so we use this platform functionality, already exposed through the page chrome, instead which
implements the expected behavior. Now, the mouse cursor is hidden while the mouse is stationary
when a <video> is fullscreen, as before, but as soon as the user exits fullscreen, the mouse cursor
reappears.

No test provided as I don't believe this platform behavior can be tested, there is no API to query
whether the cursor is visible.

page/EventHandler.cpp:

(WebCore::EventHandler::cancelAutoHideCursorTimer):
(WebCore::EventHandler::autoHideCursorTimerFired):

LayoutTests:

Remove the existing test which would query a cursor state that is no longer relevant.

fullscreen/video-cursor-auto-hide-expected.txt: Removed.
fullscreen/video-cursor-auto-hide.html: Removed.
platform/gtk/TestExpectations:

2:44 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

2:06 PM Changeset in webkit [225493] by jfbastien@apple.com

2 edits in trunk/JSTests

Proxy all functions, except the $ objects
https://bugs.webkit.org/show_bug.cgi?id=180375

Reviewed by Saam Barati.

It looks like this test may have broken some executions because I
call some internal objects. Explicitly ignore objects whose name
starts with "$" because it's a bad idea anyways.

stress/proxy-all-the-parameters.js:

(generateObjects):
(get throw):

2:00 PM Changeset in webkit [225492] by sbarati@apple.com

3 edits
1 add in trunk

We need to leave room on the top of the stack for the FTL TailCall slow path so it doesn't overwrite things we want to retrieve when doing a stack walk when throwing an exception
https://bugs.webkit.org/show_bug.cgi?id=180366
<rdar://problem/35685877>

Reviewed by Michael Saboff.

JSTests:

stress/ftl-tail-call-throw-exception-from-slow-path-recover-stack-values.js: Added.

(theParent):
(test1.base.getParentStaticValue):
(test1.base):
(test1.v_24888.prototype.set prop):
(test1.v_24888):
(test2.base.getParentStaticValue):
(test2.base):
(test2.v_24888.prototype.set prop):
(test2.v_24888):
(test2):

Source/JavaScriptCore:

On the TailCall slow path, the CallFrameShuffler will build the frame with
respect to SP instead of FP. However, this may overwrite slots on the stack
that are needed if the slow path C call does a stack walk. The slow path
C call does a stack walk when it throws an exception. This patch fixes
this bug by ensuring that the top of the stack in the FTL always has enough
space to allow CallFrameShuffler to build a frame without overwriting any
items on the stack that are needed when doing a stack walk.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):

1:56 PM Changeset in webkit [225491] by Chris Dumez

3 edits in trunk/Source/WebCore

ServiceWorkerGlobalScope::skipWaiting(Ref<DeferredPromise>&&) is unsafe
https://bugs.webkit.org/show_bug.cgi?id=180372

Reviewed by Youenn Fablet.

Ref the WorkerThread and capture it in the lambda. Keep the pending promises in
a HashMap on the ServiceWorkerGlobalScope so that they stay on the worker thread.

workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::skipWaiting):

workers/service/ServiceWorkerGlobalScope.h:

1:50 PM Changeset in webkit [225490] by beidson@apple.com

20 edits in trunk/Source

Get a directory path to SWServers for storing ServiceWorker registrations.
https://bugs.webkit.org/show_bug.cgi?id=180362

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (No observable behavior change yet).

workers/service/server/SWServer.cpp:

(WebCore::SWServer::SWServer):

workers/service/server/SWServer.h:

Source/WebKit:

This gets all of the plumbing in place for specifying a ServiceWorker registration storage path
in a particular WebsiteDataStore.

Shared/Storage/StorageProcessCreationParameters.cpp:

(WebKit::StorageProcessCreationParameters::encode const):
(WebKit::StorageProcessCreationParameters::decode):

Shared/Storage/StorageProcessCreationParameters.h:

StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::initializeWebsiteDataStore):
(WebKit::StorageProcess::swServerForSession):

StorageProcess/StorageProcess.h:

UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithLegacyOptions):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):

UIProcess/API/APIProcessPoolConfiguration.h:

UIProcess/API/APIWebsiteDataStore.h:
UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):

UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:

(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore):

UIProcess/WebProcessPool.h:

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::storageProcessParameters):

UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedServiceWorkerRegistrationDirectory const):

UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory):

UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory):

1:43 PM Changeset in webkit [225489] by Michael Catanzaro

2 edits in trunk/LayoutTests

[GTK] Unreviewed layout test gardening

platform/gtk/TestExpectations:

1:40 PM Changeset in webkit [225488] by webkit@devinrousso.com

30 edits in trunk

Web Inspector: provide method for recording CanvasRenderingContext2D from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=175166
<rdar://problem/34040740>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

inspector/protocol/Recording.json:

Add optional name that will be used by the frontend for uniquely identifying the Recording.

inspector/JSGlobalObjectConsoleClient.h:
inspector/JSGlobalObjectConsoleClient.cpp:

(Inspector::JSGlobalObjectConsoleClient::record):
(Inspector::JSGlobalObjectConsoleClient::recordEnd):

runtime/ConsoleClient.h:
runtime/ConsoleObject.cpp:

(JSC::ConsoleObject::finishCreation):
(JSC::consoleProtoFuncRecord):
(JSC::consoleProtoFuncRecordEnd):

Source/WebCore:

No new tests, updated existing tests.

inspector/InspectorCanvas.h:
inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::resetRecordingData):

inspector/InspectorCanvasAgent.h:
inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):

inspector/InspectorInstrumentation.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleStartRecordingCanvas):
(WebCore::InspectorInstrumentation::consoleStartRecordingCanvasImpl):

page/PageConsoleClient.h:
page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::record):
(WebCore::PageConsoleClient::recordEnd):

workers/WorkerConsoleClient.h:
workers/WorkerConsoleClient.cpp:

(WebCore::WorkerConsoleClient::record):
(WebCore::WorkerConsoleClient::recordEnd):

Source/WebInspectorUI:

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.recordingFinished):
If a name is sent with the payload, use it as the suggested name.

UserInterface/Models/NativeFunctionParameters.js:

Add console.record and console.recordEnd.

UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype.showRepresentedObject):
Drive-by: remove logic that toggled the collapsed state of the navigation sidebar, as this
was not very controllable by the user and often was aggravating.

(WI.CanvasTabContentView.prototype._recordingStopped):
Only show the recording if it was not started from the console. This can determined by
CanvasManager when it recieves a recording if the recording's source is not the same as the
current canvas being recorded.

LayoutTests:

inspector/canvas/recording-2d-expected.txt:
inspector/canvas/recording-2d.html:

(performConsoleRecording):

inspector/canvas/recording-webgl-expected.txt:
inspector/canvas/recording-webgl.html:

(performConsoleRecording):

inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer):

js/console-expected.txt:
js/console.html:

12:40 PM Changeset in webkit [225487] by Matt Baker

24 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab initial user interface needs some polish
https://bugs.webkit.org/show_bug.cgi?id=179330
<rdar://problem/35367581>

Reviewed by Joseph Pecoraro.

Update the Canvas overview placeholder text and prevent appearance of
the vertical scrollbar when no canvases exist. This patch also includes
a bunch of cleanup of code that creates content placeholder text throughout
the UI, and makes sure all text is styled consistently.

Localizations/en.lproj/localizedStrings.js:

Updated Canvas overview message text.

UserInterface/Base/Main.js:

Make the "message text view" a container with child message element, instead
of a simple element with text content. This makes it simpler to customize
the message (by adding buttons, more text, etc).

UserInterface/Views/CanvasDetailsSidebarPanel.css:

(.sidebar > .panel.details.canvas .details-section.canvas-extensions .content > ul):
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder): Deleted.
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder > .message): Deleted.

UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):

UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
Customize the content placeholder to include a description beneath
the "No Canvas Contexts" message.

UserInterface/Views/CollectionContentView.css:

(.content-view.collection):
Change overflow-y to auto, to prevent scrollbar from appearing when
"Show scroll bars" system preference is enabled on macOS.

UserInterface/Views/CollectionContentView.js:

Add support for custom content placeholders.
(WI.CollectionContentView):
(WI.CollectionContentView.prototype._showContentPlaceholder):
(WI.CollectionContentView.prototype._hideContentPlaceholder):

UserInterface/Views/ContentView.css:

(.content-view > .message-text-view):
(.content-view > .message-text-view > .message):

UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger > .content):
(.sidebar > .panel.navigation.debugger > :matches(.content, .empty-content-placeholder)): Deleted.

UserInterface/Views/DetailsSection.css:

(.details-section > .content > .group > .row > .message-text-view):

UserInterface/Views/Main.css:

(.message-text-view):
(.message-text-view > .message):
(.message-text-view.error):

UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .overflow-shadow):
(.sidebar > .panel.navigation > .content .empty-content-placeholder): Deleted.
(.sidebar > .panel.navigation > .content > .empty-content-placeholder): Deleted.
(.sidebar > .panel.navigation > .content .empty-content-placeholder > .message): Deleted.

UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
(WI.NavigationSidebarPanel.prototype._createEmptyContentPlaceholderIfNeeded):

UserInterface/Views/NetworkTableContentView.css:

(.content-view.network .message-text-view):
(.content-view.network .message-text-view > .message):
Workaround to prevent "No Filter Results" message from being styled like
"full width" messages displayed in ContentViews (large, bold font).
This is needed because the placeholder message element is a immediate child
of the network content view, rather than the network table.

(.content-view.network .empty-content-placeholder): Deleted.
(body[dir=ltr] .content-view.network .empty-content-placeholder): Deleted.
(body[dir=rtl] .content-view.network .empty-content-placeholder): Deleted.
(.content-view.network .empty-content-placeholder > .message): Deleted.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._showEmptyFilterResultsMessage):

UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content):
(.sidebar > .panel.navigation.recording > :matches(.content, .empty-content-placeholder)): Deleted.

UserInterface/Views/ResourceSidebarPanel.css:

(.sidebar > .panel.navigation.resource > .content):
(.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)): Deleted.

UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style > .content > .rules > .message-text-view):
(.sidebar > .panel.details.css-style > .content > .rules:not(.filter-non-matching) > .message-text-view):
(.sidebar > .panel.details.css-style > .content > .rules:not(.filter-non-matching) > .no-filter-results): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results > .no-filter-results-message): Deleted.

UserInterface/Views/RulesStyleDetailsPanel.js:

(WI.RulesStyleDetailsPanel):

UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search > :matches(.content, .message-text-view)):
(.sidebar > .panel.navigation.search.changed > :matches(.content, .message-text-view)):
(.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)): Deleted.
(.sidebar > .panel.navigation.search.changed > :matches(.content, .empty-content-placeholder)): Deleted.

UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):

UserInterface/Views/StorageSidebarPanel.css:

(.sidebar > .panel.navigation.storage > .content):
(.sidebar > .panel.navigation.storage > :matches(.content, .empty-content-placeholder)): Deleted.

UserInterface/Views/Variables.css:

(:root):

12:35 PM Changeset in webkit [225486] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Call "Terminate Service Worker" on all workers when all their clients are gone
https://bugs.webkit.org/show_bug.cgi?id=179552

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

Tested manually.

When SWServer detects that there is no longer any client for a given client origin,
it iterates through the running workers to terminate them if they have the given client origin.
A timer of 60 seconds is used in case a user closes a tab or a window, and reopens one with the same origin shortly after.

workers/service/server/SWServer.cpp:

(WebCore::SWServer::findClientByIdentifier):
(WebCore::SWServer::matchAll):
(WebCore::SWServer::registerServiceWorkerClient):
(WebCore::SWServer::unregisterServiceWorkerClient):

workers/service/server/SWServer.h:

12:31 PM Changeset in webkit [225485] by Antti Koivisto

4 edits in trunk/Source/WebCore

Enable selector filtering for ::before and ::after pseudo element resolution
https://bugs.webkit.org/show_bug.cgi?id=180364

Reviewed by Ryosuke Niwa.

Since these pseudo elements are now resolved by TreeResolver we can use selector filter for them.

This is 10%+ progression in StyleBench pseudo element subtest.

css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleForElement):

css/StyleResolver.h:
style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolvePseudoStyle):

11:37 AM Changeset in webkit [225484] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore/PAL

Unreviewed WPE build fix.

pal/PlatformWPE.cmake: Use GLIB_INCLUDE_DIRS for building the PAL library.

10:55 AM Changeset in webkit [225483] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
https://bugs.webkit.org/show_bug.cgi?id=180359

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

This algorithm is needed for implementation of claim.
As per specification, it is run for every client unload, hence why this is put in removeClientUsingRegistration.

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::removeClientUsingRegistration):
(WebCore::SWServerRegistration::handleClientUnload):

workers/service/server/SWServerRegistration.h:

10:37 AM Changeset in webkit [225482] by Antti Koivisto

6 edits in trunk/Source/WebCore

Remove duplicates from selector filter hashes
https://bugs.webkit.org/show_bug.cgi?id=180354

Reviewed by Simon Fraser.

We have only four slots for hashes in RuleSet and adding more regresses performance. To use the limited slots
better we should eliminate duplicates.

This patch also switches to using std::array instead of a C array for the hashes.

The patch reduces the number of selectors passing through the selector filter in StyleBench by ~0.4%.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForList):

css/RuleSet.cpp:

(WebCore::RuleData::RuleData):

css/RuleSet.h:

(WebCore::RuleData::descendantSelectorIdentifierHashes const):

css/SelectorFilter.cpp:

(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorFilter::collectIdentifierHashes):

css/SelectorFilter.h:

(WebCore::SelectorFilter::fastRejectSelector const):

10:13 AM Changeset in webkit [225481] by Chris Dumez

5 edits in trunk/Source/WebCore

WorkerCacheStorageConnection should handle the case of terminated workers
https://bugs.webkit.org/show_bug.cgi?id=180304

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

No web page observable change of behavior.

Reworked WorkerCacheStorageConnection hopping.
Instead of refing/unrefing itself, it refs the worker thread and the main thread connection.
This worker thread is then used on the way back from the main thread.

Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):

Modules/cache/WorkerCacheStorageConnection.h:
workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::cacheStorageConnection):

workers/WorkerGlobalScope.h:

8:45 AM Changeset in webkit [225480] by fred.wang@free.fr

5 edits in trunk/Source

Make ScrollingTreeNode::enclosingFrameNode return the node itself for frame nodes
https://bugs.webkit.org/show_bug.cgi?id=180353

Patch by Frederic Wang <fwang@igalia.com> on 2017-12-04
Reviewed by Antonio Gomes.

This function was introduced in bug 175135 to solve a rendering bug with fixed positioned
nodes in overflow nodes. For a frame node, the reference frame to use for fixed nodes is
actually the frame node itself or otherwise we will get the same rendering bug. This patch
makes enclosingFrameNode return the node itself when it is a frame node and renames it to
clarify this behavior. Currently, enclosingFrameNode is not used for frame nodes so the
behavior is unchanged.

Source/WebCore:

No new tests, behavior is unchanged.

page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::enclosingFrameNodeIncludingSelf): Start the search from a frame
scrolling node from the node itself. Renamed to make explicit that this function may include
the node itself.

page/scrolling/ScrollingTreeNode.h: Renamed.

Source/WebKit:

UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Use auto* and
the new function name.

8:41 AM Changeset in webkit [225479] by Ms2ger@igalia.com

2 edits
3 adds in trunk/LayoutTests

[GTK] Rebaseline imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
https://bugs.webkit.org/show_bug.cgi?id=180357

Unreviewed test gardening.

The difference with the platform-neutral expectation is whitespace-only.

platform/gtk/TestExpectations:
platform/gtk/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: Added.

7:32 AM Changeset in webkit [225478] by Antti Koivisto

2 edits in trunk/PerformanceTests

Fix StyleBench/InteractiveRunner.html
https://bugs.webkit.org/show_bug.cgi?id=180355

StyleBench/InteractiveRunner.html:

7:15 AM Changeset in webkit [225477] by Michael Catanzaro

8 edits
3 adds in trunk/Source

Source/WebCore:
[WPE][GTK] Implement PAL::SleepDisabler
https://bugs.webkit.org/show_bug.cgi?id=178485

Reviewed by Carlos Garcia Campos.

Add a comment to warn about some odd use of SleepDisabler in HTMLMediaElement.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::shouldDisableSleep const):

Source/WebCore/PAL:
[WPE][GTK] Implement PAL::SleepDisabler
https://bugs.webkit.org/show_bug.cgi?id=178485

Reviewed by Carlos Garcia Campos.

pal/PlatformGTK.cmake:
pal/PlatformWPE.cmake:
pal/system/SleepDisabler.cpp:
pal/system/glib/SleepDisablerGLib.cpp: Added.

(PAL::SleepDisabler::create):
(PAL::SleepDisablerGLib::SleepDisablerGLib):
(PAL::SleepDisablerGLib::~SleepDisablerGLib):
(PAL::SleepDisablerGLib::acquireInhibitor):
(PAL::SleepDisablerGLib::releaseInhibitor):

pal/system/glib/SleepDisablerGLib.h: Added.

Source/WebKit:
[GTK] Implement PAL::SleepDisabler
https://bugs.webkit.org/show_bug.cgi?id=178485

Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose):
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):
(screenSaverInhibitedCallback): Deleted.
(webkitWebViewBaseSendInhibitMessageToScreenSaver): Deleted.
(screenSaverProxyCreatedCallback): Deleted.
(webkitWebViewBaseInhibitScreenSaver): Deleted.
(webkitWebViewBaseUninhibitScreenSaver): Deleted.

5:27 AM WebDriverStatus edited by Carlos Garcia Campos

(diff)

5:20 AM WebDriverStatus edited by Carlos Garcia Campos

(diff)

3:34 AM Changeset in webkit [225476] by Carlos Garcia Campos

8 edits in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

imported/w3c/importer.json:
imported/w3c/tools/webdriver/webdriver/client.py:
imported/w3c/tools/webdriver/webdriver/error.py:
imported/w3c/webdriver/tests/element_retrieval/get_active_element.py:
imported/w3c/webdriver/tests/interaction/element_clear.py:
imported/w3c/webdriver/tests/sessions/status.py:
imported/w3c/webdriver/tests/support/wait.py:

3:30 AM Changeset in webkit [225475] by fred.wang@free.fr

13 edits
2 copies in trunk/Source/WebCore

Bug 161300 - Move RenderMathMLRoot:RootType and RenderMathMLScripts:ScriptsType to element classes
https://bugs.webkit.org/show_bug.cgi?id=161300

Patch by Frederic Wang <fwang@igalia.com> on 2017-12-04
Reviewed by Darin Adler.

RenderMathMLRoot::m_kind and RenderMathMLScripts::m_scriptType are initialized in the
constructors of the renderer classes from the tag name of the corresponding elements.
This patch moves them into the corresponding element classes and makes them const members
parsed in the constructors. It also introduces a MathMLRootElement class deriving from
MathMLRowElement to store the new member. Finally, the types are redefined as enum classes.

No new tests, behavior unchanged and already covered by existing tests.

Sources.txt: Add MathMLRootElement files.
WebCore.xcodeproj/project.pbxproj: Ditto.
mathml/MathMLAllInOne.cpp: Ditto.
mathml/MathMLRootElement.cpp:

(WebCore::element): Override this function to downcast to MathMLRootElement.
(WebCore::rootTypeOf): Helper function to parse the root type, moved from RenderMathMLRoot.
(WebCore::MathMLRootElement::MathMLRootElement): Initialize the root type.
(WebCore::MathMLRootElement::create):
(WebCore::MathMLRootElement::createElementRenderer): Moved from MathMLRowElement.

mathml/MathMLRootElement.h: New class deriving from MathMLRowElement, with a RootType

member exposed to the renderer class.

mathml/MathMLRowElement.cpp: Remove header for RenderMathMLRoot.h.

(WebCore::MathMLRowElement::createElementRenderer): Moved to MathMLRootElement.

mathml/MathMLScriptsElement.cpp: Introduce a script type.

(WebCore::scriptTypeOf): Helper function to parse the script type, moved from
RenerMathMLScripts.
(WebCore::MathMLScriptsElement::MathMLScriptsElement): Initialize the script type.

mathml/MathMLScriptsElement.h: Add new script type member.

(WebCore::MathMLScriptsElement::scriptType const): Expose the script type to the renderer
class.

mathml/mathtags.in: Map <msqrt> and <mroot> to MathMLRootElement.
rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::RenderMathMLRoot): Use MathMLRootElement and remove parsing of
the root type.
(WebCore::RenderMathMLRoot::rootType const): Helper function to access the root type from
the element class.
(WebCore::RenderMathMLRoot::isValid const): Use rootType() and add prefix for enum class
values.
(WebCore::RenderMathMLRoot::getBase const): Ditto.
(WebCore::RenderMathMLRoot::getIndex const): Ditto.
(WebCore::RenderMathMLRoot::horizontalParameters): Ditto.
(WebCore::RenderMathMLRoot::verticalParameters): Ditto.
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLRoot::layoutBlock): Ditto.
(WebCore::RenderMathMLRoot::paint): Ditto.

rendering/mathml/RenderMathMLRoot.h: Define root type as an enum class, replace

MathMLRowElement with MathMLRootElement, declare and use new rootType() function and remove
the m_kind member.

rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::RenderMathMLScripts): Remove parsing of script type.
(WebCore::RenderMathMLScripts::scriptType const): Helper function to access the script type
from the element class.
(WebCore::RenderMathMLScripts::validateAndGetReferenceChildren): Use scriptType() and add
prefix for enum class values.
(WebCore::RenderMathMLScripts::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLScripts::verticalMetrics): Ditto.
(WebCore::RenderMathMLScripts::layoutBlock): Ditto.

rendering/mathml/RenderMathMLScripts.h: Define root type as an enum class, declare the

scriptType() function and remove the m_scriptType member.

rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::isValid const): Use scriptType() and add prefix for enum
class values.
(WebCore::RenderMathMLUnderOver::under const): Ditto.
(WebCore::RenderMathMLUnderOver::over const): Ditto.
(WebCore::RenderMathMLUnderOver::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLUnderOver::hasAccent const): Ditto.
(WebCore::RenderMathMLUnderOver::layoutBlock): Ditto.

3:29 AM Changeset in webkit [225474] by Carlos Garcia Campos

5 edits in trunk/Source/WebDriver

WebDriver: implement element property command
https://bugs.webkit.org/show_bug.cgi?id=180244

Reviewed by Brian Burg.

13.3 Get Element Property
https://w3c.github.io/webdriver/webdriver-spec.html#get-element-property

Fixes: imported/w3c/webdriver/tests/state/get_element_property.py::test_no_browsing_context

imported/w3c/webdriver/tests/state/get_element_property.py::test_handle_prompt_dismiss
imported/w3c/webdriver/tests/state/get_element_property.py::test_handle_prompt_accept
imported/w3c/webdriver/tests/state/get_element_property.py::test_handle_prompt_missing_value
imported/w3c/webdriver/tests/state/get_element_property.py::test_element_stale

Session.cpp:

(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):

Session.h:
WebDriverService.cpp:

(WebDriver::WebDriverService::getElementProperty):

WebDriverService.h:

12:52 AM Changeset in webkit [225473] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GStreamer] More leaks in TextCombinerGStreamer
https://bugs.webkit.org/show_bug.cgi?id=180331

Reviewed by Michael Catanzaro.

I've noticed more leaks reading the code, but I couldn't check them with valgrind, because I don't know how to
trigger that code path. This patch cleans up the file using smart pointer everywhere.

platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_pad_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerReleasePad):

12:49 AM Changeset in webkit [225472] by jer.noble@apple.com

17 edits
7 adds in trunk

Include 'video/*' in image request Accept header if browser supports video media in image contexts.
https://bugs.webkit.org/show_bug.cgi?id=179178

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/images/image-supports-video.html

Ensure that 'video/*' is included in the Accept header by asking the ImageDecoder whether "Video"
media is supported. The ImageDecoder will ask all it's constituent decoders, which aside from
ImageDecoderAVFObjC will say only support the "Image" media type.

Drive-by fix: Make sure the MIMETypeRegistry includes all the types supported by AVFoundation when
ImageDecoderAVFObjC is enabled. Also, now that Image reports it can support video mime types, check
whether MediaDocument can support a given mime type before asking ImageDocument.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

loader/LinkLoader.cpp:

(WebCore::LinkLoader::isSupportedType):

loader/cache/CachedResourceRequest.cpp:

(WebCore::acceptHeaderValueFromType):

platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageOrSVGMIMEType): Deleted.

platform/MIMETypeRegistry.h:
platform/graphics/ImageDecoder.cpp:

(WebCore::ImageDecoder::supportsMediaType):

platform/graphics/ImageDecoder.h:
platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:

(WebCore::ImageDecoderAVFObjC::supportsMediaType):

platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::supportsContentType):

platform/graphics/cg/ImageDecoderCG.h:
platform/graphics/win/ImageDecoderDirect2D.h:
platform/image-decoders/ScalableImageDecoder.h:

(WebCore::ScalableImageDecoder::supportsMediaType):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

LayoutTests:

http/tests/images/image-supports-video-expected.txt: Added.
http/tests/images/image-supports-video.html: Added.
http/tests/misc/resources/image-checks-for-accept.php:
http/tests/resources/redirect-to-video-if-accepted.php: Added.
platform/ios/TestExpectations:
platform/mac/imported/w3c/web-platform-tests/html/semantics/the-img-element/update-the-source-set-expected.txt: Added.

Dec 3, 2017:

10:26 PM Changeset in webkit [225471] by tpopela@redhat.com

3 edits in trunk/Source/WTF

Build fails on x86_64 and arm64 with BMalloc disabled
https://bugs.webkit.org/show_bug.cgi?id=180188

Reviewed by Carlos Garcia Campos.

Add missing methods in WTF's Gigacage.h and fix g_gigacageBasePtr
definition.

wtf/Gigacage.cpp:
wtf/Gigacage.h:

(Gigacage::basePtr):
(Gigacage::isEnabled):

10:13 PM Changeset in webkit [225470] by Yusuke Suzuki

71 edits
1 add in trunk

WTF shouldn't have both Thread and ThreadIdentifier
https://bugs.webkit.org/show_bug.cgi?id=180308

Reviewed by Darin Adler.

Source/JavaScriptCore:

heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStacks):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):

runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):

runtime/JSLock.h:

(JSC::JSLock::currentThreadIsHoldingLock):

runtime/VM.cpp:

(JSC::VM::throwException):

runtime/VM.h:

(JSC::VM::throwingThread const):
(JSC::VM::clearException):

tools/HeapVerifier.cpp:

(JSC::HeapVerifier::printVerificationHeader):

Source/WebCore:

No behavior change.

Modules/indexeddb/IDBActiveDOMObject.h:

(WebCore::IDBActiveDOMObject::originThread const):
(WebCore::IDBActiveDOMObject::performCallbackOnOriginThread):
(WebCore::IDBActiveDOMObject::callFunctionOnOriginThread):
(WebCore::IDBActiveDOMObject::originThreadID const): Deleted.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::~IDBCursor):
(WebCore::IDBCursor::sourcesDeleted const):
(WebCore::IDBCursor::transaction const):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::uncheckedIterateCursor):
(WebCore::IDBCursor::deleteFunction):
(WebCore::IDBCursor::setGetResult):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::hasPendingActivity const):
(WebCore::IDBDatabase::name const):
(WebCore::IDBDatabase::version const):
(WebCore::IDBDatabase::objectStoreNames const):
(WebCore::IDBDatabase::renameObjectStore):
(WebCore::IDBDatabase::renameIndex):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::connectionToServerLost):
(WebCore::IDBDatabase::maybeCloseInServer):
(WebCore::IDBDatabase::activeDOMObjectName const):
(WebCore::IDBDatabase::canSuspendForDocumentSuspension const):
(WebCore::IDBDatabase::stop):
(WebCore::IDBDatabase::startVersionChangeTransaction):
(WebCore::IDBDatabase::didStartTransaction):
(WebCore::IDBDatabase::willCommitTransaction):
(WebCore::IDBDatabase::didCommitTransaction):
(WebCore::IDBDatabase::willAbortTransaction):
(WebCore::IDBDatabase::didAbortTransaction):
(WebCore::IDBDatabase::didCommitOrAbortTransaction):
(WebCore::IDBDatabase::fireVersionChangeEvent):
(WebCore::IDBDatabase::dispatchEvent):
(WebCore::IDBDatabase::didCreateIndexInfo):
(WebCore::IDBDatabase::didDeleteIndexInfo):

Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::~IDBIndex):
(WebCore::IDBIndex::name const):
(WebCore::IDBIndex::setName):
(WebCore::IDBIndex::objectStore):
(WebCore::IDBIndex::keyPath const):
(WebCore::IDBIndex::unique const):
(WebCore::IDBIndex::multiEntry const):
(WebCore::IDBIndex::rollbackInfoForVersionChangeAbort):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::doCount):
(WebCore::IDBIndex::doGet):
(WebCore::IDBIndex::doGetKey):
(WebCore::IDBIndex::getAll):
(WebCore::IDBIndex::getAllKeys):
(WebCore::IDBIndex::markAsDeleted):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::~IDBObjectStore):
(WebCore::IDBObjectStore::name const):
(WebCore::IDBObjectStore::setName):
(WebCore::IDBObjectStore::keyPath const):
(WebCore::IDBObjectStore::indexNames const):
(WebCore::IDBObjectStore::transaction):
(WebCore::IDBObjectStore::autoIncrement const):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::openKeyCursor):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::getKey):
(WebCore::IDBObjectStore::putOrAdd):
(WebCore::IDBObjectStore::doDelete):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::doCount):
(WebCore::IDBObjectStore::getAll):
(WebCore::IDBObjectStore::getAllKeys):
(WebCore::IDBObjectStore::markAsDeleted):
(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):

Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::~IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onError):
(WebCore::IDBOpenDBRequest::versionChangeTransactionDidFinish):
(WebCore::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit):
(WebCore::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
(WebCore::IDBOpenDBRequest::dispatchEvent):
(WebCore::IDBOpenDBRequest::onSuccess):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onDeleteDatabaseSuccess):
(WebCore::IDBOpenDBRequest::requestCompleted):
(WebCore::IDBOpenDBRequest::requestBlocked):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):
(WebCore:: const):
(WebCore::IDBRequest::setSource):
(WebCore::IDBRequest::setVersionChangeTransaction):
(WebCore::IDBRequest::transaction const):
(WebCore::IDBRequest::sourceObjectStoreIdentifier const):
(WebCore::IDBRequest::sourceIndexIdentifier const):
(WebCore::IDBRequest::requestedObjectStoreRecordType const):
(WebCore::IDBRequest::requestedIndexRecordType const):
(WebCore::IDBRequest::eventTargetInterface const):
(WebCore::IDBRequest::activeDOMObjectName const):
(WebCore::IDBRequest::canSuspendForDocumentSuspension const):
(WebCore::IDBRequest::hasPendingActivity const):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
(WebCore::IDBRequest::setResultToUndefined):
(WebCore::IDBRequest::resultCursor):
(WebCore::IDBRequest::willIterateCursor):
(WebCore::IDBRequest::didOpenOrIterateCursor):
(WebCore::IDBRequest::completeRequestAndDispatchEvent):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::objectStoreNames const):
(WebCore::IDBTransaction::db):
(WebCore::IDBTransaction::error const):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abortDueToFailedRequest):
(WebCore::IDBTransaction::transitionedToFinishing):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::internalAbort):
(WebCore::IDBTransaction::abortOnServerAndCancelRequests):
(WebCore::IDBTransaction::activeDOMObjectName const):
(WebCore::IDBTransaction::canSuspendForDocumentSuspension const):
(WebCore::IDBTransaction::hasPendingActivity const):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::isActive const):
(WebCore::IDBTransaction::isFinishedOrFinishing const):
(WebCore::IDBTransaction::addRequest):
(WebCore::IDBTransaction::removeRequest):
(WebCore::IDBTransaction::scheduleOperation):
(WebCore::IDBTransaction::schedulePendingOperationTimer):
(WebCore::IDBTransaction::pendingOperationTimerFired):
(WebCore::IDBTransaction::operationCompletedOnServer):
(WebCore::IDBTransaction::scheduleCompletedOperationTimer):
(WebCore::IDBTransaction::completedOperationTimerFired):
(WebCore::IDBTransaction::commit):
(WebCore::IDBTransaction::commitOnServer):
(WebCore::IDBTransaction::finishAbortOrCommit):
(WebCore::IDBTransaction::didStart):
(WebCore::IDBTransaction::notifyDidAbort):
(WebCore::IDBTransaction::didAbort):
(WebCore::IDBTransaction::didCommit):
(WebCore::IDBTransaction::fireOnComplete):
(WebCore::IDBTransaction::fireOnAbort):
(WebCore::IDBTransaction::enqueueEvent):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::createObjectStore):
(WebCore::IDBTransaction::createObjectStoreOnServer):
(WebCore::IDBTransaction::didCreateObjectStoreOnServer):
(WebCore::IDBTransaction::renameObjectStore):
(WebCore::IDBTransaction::renameObjectStoreOnServer):
(WebCore::IDBTransaction::didRenameObjectStoreOnServer):
(WebCore::IDBTransaction::createIndex):
(WebCore::IDBTransaction::createIndexOnServer):
(WebCore::IDBTransaction::didCreateIndexOnServer):
(WebCore::IDBTransaction::renameIndex):
(WebCore::IDBTransaction::renameIndexOnServer):
(WebCore::IDBTransaction::didRenameIndexOnServer):
(WebCore::IDBTransaction::requestOpenCursor):
(WebCore::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBTransaction::openCursorOnServer):
(WebCore::IDBTransaction::didOpenCursorOnServer):
(WebCore::IDBTransaction::iterateCursor):
(WebCore::IDBTransaction::iterateCursorOnServer):
(WebCore::IDBTransaction::didIterateCursorOnServer):
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
(WebCore::IDBTransaction::requestGetAllIndexRecords):
(WebCore::IDBTransaction::getAllRecordsOnServer):
(WebCore::IDBTransaction::didGetAllRecordsOnServer):
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestGetValue):
(WebCore::IDBTransaction::requestGetKey):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::getRecordOnServer):
(WebCore::IDBTransaction::didGetRecordOnServer):
(WebCore::IDBTransaction::requestCount):
(WebCore::IDBTransaction::getCountOnServer):
(WebCore::IDBTransaction::didGetCountOnServer):
(WebCore::IDBTransaction::requestDeleteRecord):
(WebCore::IDBTransaction::deleteRecordOnServer):
(WebCore::IDBTransaction::didDeleteRecordOnServer):
(WebCore::IDBTransaction::requestClearObjectStore):
(WebCore::IDBTransaction::clearObjectStoreOnServer):
(WebCore::IDBTransaction::didClearObjectStoreOnServer):
(WebCore::IDBTransaction::requestPutOrAdd):
(WebCore::IDBTransaction::putOrAddOnServer):
(WebCore::IDBTransaction::didPutOrAddOnServer):
(WebCore::IDBTransaction::deleteObjectStore):
(WebCore::IDBTransaction::deleteObjectStoreOnServer):
(WebCore::IDBTransaction::didDeleteObjectStoreOnServer):
(WebCore::IDBTransaction::deleteIndex):
(WebCore::IDBTransaction::deleteIndexOnServer):
(WebCore::IDBTransaction::didDeleteIndexOnServer):
(WebCore::IDBTransaction::operationCompletedOnClient):
(WebCore::IDBTransaction::establishOnServer):
(WebCore::IDBTransaction::activate):
(WebCore::IDBTransaction::deactivate):

Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::removeItemsMatchingCurrentThread):

Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::TransactionOperation::~TransactionOperation):
(WebCore::IDBClient::TransactionOperation::perform):
(WebCore::IDBClient::TransactionOperation::transitionToCompleteOnThisThread):
(WebCore::IDBClient::TransactionOperation::transitionToComplete):
(WebCore::IDBClient::TransactionOperation::doComplete):
(WebCore::IDBClient::TransactionOperation::originThread const):
(WebCore::IDBClient::TransactionOperation::originThreadID const): Deleted.

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::lock):
(WebCore::AudioContext::tryLock):
(WebCore::AudioContext::unlock):
(WebCore::AudioContext::isAudioThread const):
(WebCore::AudioContext::isGraphOwner const):

Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::setAudioThread):
(WebCore::AudioContext::audioThread const):

Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):

Modules/webdatabase/Database.cpp:

(WebCore::Database::performClose):
(WebCore::Database::securityOrigin):

Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::operator=):
(WebCore::DatabaseDetails::thread const):
(WebCore::DatabaseDetails::threadID const): Deleted.

Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::detailsForNameAndOrigin):

Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):

Modules/webdatabase/DatabaseThread.h:

(WebCore::DatabaseThread::getThread):
(WebCore::DatabaseThread::getThreadID): Deleted.

Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):

bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):

bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):

page/ResourceUsageOverlay.h:
page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::isCurrentThread):

platform/Supplementable.h:

(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::removeSupplement):
(WebCore::Supplementable::requireSupplement):
(WebCore::Supplementable::Supplementable): Deleted.

platform/Timer.cpp:

(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::start):
(WebCore::TimerBase::stop):
(WebCore::TimerBase::setNextFireTime):

platform/Timer.h:

(WebCore::TimerBase::isActive const):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::shouldAutoActivateFontIfNeeded):

platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):
(WebCore::TextureMapperPlatformLayerProxy::invalidate):
(WebCore::TextureMapperPlatformLayerProxy::getAvailableBuffer):
(WebCore::TextureMapperPlatformLayerProxy::appendToUnusedBuffers):
(WebCore::TextureMapperPlatformLayerProxy::swapBuffer):

platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:

(): Deleted.

platform/ios/wak/WebCoreThread.mm:

(RunWebThread):
(StartWebThread):

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):

platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::sqlite3Handle const):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::isContextThread const):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):

workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):

workers/WorkerThread.h:

(WebCore::WorkerThread::thread const):
(WebCore::WorkerThread::threadID const): Deleted.

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):
(WebCore::ServiceWorkerContainer::contextIdentifier):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):
(WebCore::ServiceWorkerJob::resolvedWithRegistration):
(WebCore::ServiceWorkerJob::resolvedWithUnregistrationResult):
(WebCore::ServiceWorkerJob::startScriptFetch):
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):
(WebCore::ServiceWorkerJob::notifyFinished):

workers/service/ServiceWorkerJob.h:
xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::matchFunc):
(WebCore::openFunc):
(WebCore::initializeXMLParser):
(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLParserContext::createMemoryParser):

Source/WebKit:

UIProcess/API/glib/IconDatabase.cpp:
UIProcess/GenericCallback.h:

(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):

Source/WTF:

We should use a pointer of WTF::Thread instead of ThreadIdentifier.

One problem is that Windows support library uses WTF::createThread,
which returns ThreadIdentifier. So we cannot drop ThreadIdentifier
in Windows environment. This patch keeps ThreadIdentifier in Windows.

wtf/MainThread.cpp:

(WTF::initializeMainThread):
(WTF::isMainThread):
(WTF::canAccessThreadLocalDataForThread):

wtf/MainThread.h:
wtf/ParkingLot.cpp:

(WTF::ParkingLot::parkConditionallyImpl):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::unparkOneImpl):
(WTF::ParkingLot::unparkCount):

wtf/RecursiveLockAdapter.h:

(WTF::RecursiveLockAdapter::lock):
(WTF::RecursiveLockAdapter::unlock):
(WTF::RecursiveLockAdapter::tryLock):

wtf/Threading.cpp:

(WTF::Thread::dump const):

wtf/Threading.h:

(WTF::Thread::id const):
(WTF::Thread::operator==): Deleted.
(WTF::Thread::operator!=): Deleted.
(WTF::currentThread): Deleted.

wtf/ThreadingPrimitives.h:
wtf/ThreadingPthreads.cpp:

(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::initializeCurrentTLS):
(WTF::Thread::suspend):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::currentID): Deleted.

wtf/ThreadingWin.cpp:

(WTF::Thread::waitForCompletion):
(WTF::Thread::suspend):
(WTF::Thread::currentDying):

wtf/mac/MainThreadMac.mm:

(WTF::initializeApplicationUIThread):
(WTF::initializeWebThreadPlatform):
(WTF::canAccessThreadLocalDataForThread):
(WTF::initializeApplicationUIThreadIdentifier): Deleted.
(WTF::initializeWebThreadIdentifier): Deleted.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):
(runThread): Deleted.
(runPthread): Deleted.
(testThreadIdentifierMap): Deleted.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
TestWebKitAPI/Tests/WTF/Threading.cpp: Added.

(TestWebKitAPI::TEST):

9:40 PM Changeset in webkit [225469] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

WebSocketChannel should ensure its client is live when calling it in error case
https://bugs.webkit.org/show_bug.cgi?id=180285

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-03
Reviewed by Darin Adler.

No observable change of behavior.
This makes it consistent with other calls of didReceiveMessageError.

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):

7:34 PM Changeset in webkit [225468] by ap@apple.com

2 edits in trunk/Source/WebCore

WebArchiveResourceWebResourceHandler leaks when pasting
https://bugs.webkit.org/show_bug.cgi?id=180339

Reviewed by Joseph Pecoraro.

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attributesForAttributedStringConversion):

6:15 PM Changeset in webkit [225467] by Chris Dumez

17 edits
1 move
17 adds
37 deletes in trunk/LayoutTests

Re-sync Service Workers web-platform-tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=180336

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync Service Workers web-platform-tests from upstream 6df98083a2be.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html: Added.
web-platform-tests/service-workers/service-worker/about-blank-replacement.https-expected.txt: Added.
web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html: Added.
web-platform-tests/service-workers/service-worker/activation.https.html:
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-event-respond-with-partial-stream.https-expected.txt: Added.
web-platform-tests/service-workers/service-worker/fetch-event-respond-with-partial-stream.https.html: Added.
web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
web-platform-tests/service-workers/service-worker/foreign-fetch-basics.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-basics.https.html: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-cors.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-cors.https.html: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-event.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-event.https.html: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-workers.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/foreign-fetch-workers.https.html: Removed.
web-platform-tests/service-workers/service-worker/iframe-sandbox-register-link-element.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/iframe-sandbox-register-link-element.https.html: Removed.
web-platform-tests/service-workers/service-worker/interfaces-window.https-expected.txt:
web-platform-tests/service-workers/service-worker/link-element-register-basic.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-basic.https.html: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-mime-types.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-mime-types.https.html: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-scope.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-scope.https.html: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-script-url.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-script-url.https.html: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-script.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-script.https.html: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-security-error.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/link-element-register-security-error.https.html: Removed.
web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt:
web-platform-tests/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-scope.html: Added.
web-platform-tests/service-workers/service-worker/register-foreign-fetch-errors.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/register-foreign-fetch-errors.https.html: Removed.
web-platform-tests/service-workers/service-worker/register-link-header.https-expected.txt: Removed.
web-platform-tests/service-workers/service-worker/register-link-header.https.html: Removed.
web-platform-tests/service-workers/service-worker/registration-iframe.https.html:
web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html:
web-platform-tests/service-workers/service-worker/resource-timing.https-expected.txt:
web-platform-tests/service-workers/service-worker/resource-timing.https.html:
web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-frame.py: Added.

(main):

web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-ping-frame.py: Added.

(main):

web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-popup-frame.py: Added.

(main):

web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-uncontrolled-nested-frame.html: Added.
web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-worker.js: Added.

(async.getClientByURL):
(async.pingPong.waitForPong.return.new.Promise):
(async.pingPong.waitForPong):
(async.pingPong):
(async.evt.url.searchParams):
(async.evt.evt.respondWith.async):
(evt.evt.waitUntil.async):

web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js:

(self.onfetch):

web-platform-tests/service-workers/service-worker/resources/empty.js: Added.
web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-partial-stream-worker.js: Added.

(evt.evt.request.url.includes):

web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js:

(handleClientId):

web-platform-tests/service-workers/service-worker/resources/foreign-fetch-cors-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/foreign-fetch-event-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helper-iframe.html: Removed.
web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helper-script.js: Removed.
web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helper-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helpers.js: Removed.
web-platform-tests/service-workers/service-worker/resources/foreign-fetch-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/iframe-register-link-element.html: Removed.
web-platform-tests/service-workers/service-worker/resources/install-worker-helper.html: Removed.
web-platform-tests/service-workers/service-worker/resources/interfaces-idls.js:
web-platform-tests/service-workers/service-worker/resources/link-header.py: Removed.
web-platform-tests/service-workers/service-worker/resources/register-foreign-fetch-errors-worker.js: Removed.
web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.html.
web-platform-tests/service-workers/service-worker/resources/sandboxed-iframe-fetch-event-iframe.html: Added.
web-platform-tests/service-workers/service-worker/resources/sandboxed-iframe-fetch-event-worker.js: Added.

(event.waitUntil.self.clients.matchAll.then):

web-platform-tests/service-workers/service-worker/resources/sandboxed-iframe-navigator-serviceworker-iframe.html: Added.
web-platform-tests/service-workers/service-worker/resources/test-helpers.sub.js:
web-platform-tests/service-workers/service-worker/resources/w3c-import.log:
web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https-expected.txt: Added.
web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https.html: Added.
web-platform-tests/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https-expected.txt: Added.
web-platform-tests/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https.html: Added.
web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt:
web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt:
web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt:
web-platform-tests/service-workers/service-worker/w3c-import.log:

LayoutTests:

Skip new tests that are timing out and remove entries for tests
that were removed.

TestExpectations:
tests-options.json:

4:28 PM Changeset in webkit [225466] by aakash_jain@apple.com

2 edits in trunk/Tools

webkitpy EWS keeps retrying a failing patch
https://bugs.webkit.org/show_bug.cgi?id=180302

Reviewed by Alexey Proskuryakov.

Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._test_patch): Instead of returning false, call report_failure()
which raises an exception, this exception is catched by earlywarningsystem.py and
it posts a comment on bugzilla. Returning false simply unlocks the patch and returns
it to the queue.

3:08 PM Changeset in webkit [225465] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https.html as flaky

TestExpectations:

3:00 PM Changeset in webkit [225464] by Caio Lima

6 edits in trunk/Source/JavaScriptCore

Rename DestroyFunc to avoid redefinition on unified build
https://bugs.webkit.org/show_bug.cgi?id=180335

Reviewed by Filip Pizlo.

Changing DestroyFunc structures to more specific names to avoid
conflits on unified builds.

heap/HeapCellType.cpp:

(JSC::HeapCellType::finishSweep):
(JSC::HeapCellType::destroy):

runtime/JSDestructibleObjectHeapCellType.cpp:

(JSC::JSDestructibleObjectHeapCellType::finishSweep):
(JSC::JSDestructibleObjectHeapCellType::destroy):

runtime/JSSegmentedVariableObjectHeapCellType.cpp:

(JSC::JSSegmentedVariableObjectHeapCellType::finishSweep):
(JSC::JSSegmentedVariableObjectHeapCellType::destroy):

runtime/JSStringHeapCellType.cpp:

(JSC::JSStringHeapCellType::finishSweep):
(JSC::JSStringHeapCellType::destroy):

wasm/js/JSWebAssemblyCodeBlockHeapCellType.cpp:

(JSC::JSWebAssemblyCodeBlockHeapCellType::finishSweep):
(JSC::JSWebAssemblyCodeBlockHeapCellType::destroy):

2:48 PM Changeset in webkit [225463] by Darin Adler

14 edits
1 copy
1 add in trunk

Add WTF::Hasher, an easier to use replacement for WTF::IntegerHasher
https://bugs.webkit.org/show_bug.cgi?id=180318

Reviewed by JF Bastien.

Source/WTF:

WTF.xcodeproj/project.pbxproj: Added Hasher.h.
wtf/CMakeLists.txt: Ditto.

wtf/Forward.h: Added Hasher and TextStream.

wtf/Hasher.h: Moved StringHasher into a separate header. Added Hasher.

Marked IntegerHasher deprecated.

wtf/text/CString.cpp: Include StringHasher.h instead of Hasher.h.
wtf/text/StringHash.h: Ditto.

wtf/text/StringHasher.h: Added. Moved StringHasher here from Hasher.h.

wtf/text/StringImpl.h: Include StringHasher.h instead of Hasher.h.

wtf/text/WTFString.h: Added a hash function. This was useful in some

adoption I was doing in WebCore, not included in this patch.

wtf/unicode/UTF8.cpp: Include StringHasher.h instead of Hasher.h.

Tools:

TestWebKitAPI/CMakeLists.txt: Added Hasher.cpp.
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.

TestWebKitAPI/Tests/WTF/Hasher.cpp: Added. Contains tests of the new

WTF::Hasher class.

TestWebKitAPI/Tests/WTF/StringHasher.cpp: Include StringHasher.h instead of

Hasher.h.

2:24 PM Changeset in webkit [225462] by Chris Dumez

20 edits in trunk

Support serviceWorker.postMessage() inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180328

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:

Source/WebCore:

Support serviceWorker.postMessage() inside service workers.

No new tests, unskipped and rebaselined existing test that is
now passing.

workers/service/SWClientConnection.h:
workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorker):

workers/service/context/SWContextManager.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::fireMessageEvent):
(WebCore::ServiceWorkerThread::postMessageToServiceWorker):

workers/service/context/ServiceWorkerThread.h:

Source/WebKit:

Support serviceWorker.postMessage() inside service workers.

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorker):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerFromServiceWorker):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

Unskip WPT test that no longer times out.

TestExpectations:

1:34 PM Changeset in webkit [225461] by Chris Dumez

13 edits in trunk/LayoutTests

Unreviewed, unskip / rebaseline a few web platform tests.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
web-platform-tests/service-workers/service-worker/clients-matchall-on-evaluation.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
web-platform-tests/service-workers/service-worker/postmessage-to-client.https-expected.txt:
web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt:
web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:

LayoutTests:

TestExpectations:

12:32 PM Changeset in webkit [225460] by Chris Dumez

22 edits in trunk

Implement self.skipWaiting() inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180329

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt:
web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt:
web-platform-tests/service-workers/service-worker/postmessage-from-waiting-serviceworker.https-expected.txt:
web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt:

Source/WebCore:

Implement self.skipWaiting() inside service workers:

https://w3c.github.io/ServiceWorker/#service-worker-global-scope-skipwaiting

Also fixes a bug where tryActivate() was calling activate() even though the
registration's active worker was "in use":

https://w3c.github.io/ServiceWorker/#try-activate-algorithm

No new tests, rebaselined existing tests.

workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::skipWaiting):

workers/service/context/SWContextManager.h:
workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::tryActivate):

workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::skipWaiting):

workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::skipWaiting):

workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::isSkipWaitingFlagSet const):

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::didFinishSkipWaiting):

StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::skipWaiting):
(WebKit::WebSWContextManagerConnection::didFinishSkipWaiting):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

http/tests/workers/service/resources/service-worker-fetch-worker.js:

add self.skipWaiting() now that we properly wait when the registation's
active worker is in use. This is needed because this worker script is
used by http/tests/workers/service/controller-change.html. The
'controllerchange' event is only fired if an active worker is being
replaced while in use due to the waiting worker calling skipWaiting().

1:08 AM Changeset in webkit [225459] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GStreamer] GstPad leaked in WebKitTextCombiner
https://bugs.webkit.org/show_bug.cgi?id=180314

Reviewed by Michael Catanzaro.

gst_element_get_static_pad() returns a full reference that si never freed, because gst_ghost_pad_new doesn't
take the ownership of the given pad.

platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_init):

1:07 AM Changeset in webkit [225458] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GStreamer] GstCaps leaked in MediaPlayerPrivateGStreamer::createGSTPlayBin
https://bugs.webkit.org/show_bug.cgi?id=180311

Reviewed by Michael Catanzaro.

gst_caps_new_empty_simple() is passed directly to g_object_set(). The returned caps should be freed with
gst_caps_unref().

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Dec 2, 2017:

9:32 PM Changeset in webkit [225457] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Move registration activation and clearing from SWServerJobQueue to SWServerRegistration
https://bugs.webkit.org/show_bug.cgi?id=180325

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-02
Reviewed by Chris Dumez.

No change of behavior.

These algorithms fit naturally in SWServerRegistration and will be used as part of clients.claim.

workers/service/server/SWServer.cpp:

(WebCore::SWServer::clearAll):
(WebCore::SWServer::didFinishActivation):

workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::runUnregisterJob):
(WebCore::SWServerJobQueue::tryActivate): Deleted.
(WebCore::SWServerJobQueue::activate): Deleted.
(WebCore::SWServerJobQueue::didFinishActivation): Deleted.
(WebCore::SWServerJobQueue::tryClearRegistration): Deleted.
(WebCore::clearRegistrationWorker): Deleted.
(WebCore::SWServerJobQueue::clearRegistration): Deleted.

workers/service/server/SWServerJobQueue.h:
workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::tryClear):
(WebCore::clearRegistrationWorker):
(WebCore::SWServerRegistration::clear):
(WebCore::SWServerRegistration::tryActivate):
(WebCore::SWServerRegistration::activate):
(WebCore::SWServerRegistration::didFinishActivation):

workers/service/server/SWServerRegistration.h:

8:17 PM Changeset in webkit [225456] by Chris Dumez

7 edits
3 adds in trunk

Support container.register() / registration.unregister() / inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180326

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test that now passes most checks.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https-expected.txt:

Source/WebCore:

Support container.register() / registration.unregister() / inside service workers.
This is mostly about removing the is<Document>() checks and adding testing given
that most of the work was done in r225455.

Test: http/tests/workers/service/ServiceWorkerGlobalScope_register.html

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):

workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):

LayoutTests:

TestExpectations:

Unskip test for registration.unregister() that now passes.

http/tests/workers/service/ServiceWorkerGlobalScope_register-expected.txt: Added.
http/tests/workers/service/ServiceWorkerGlobalScope_register.html: Added.
http/tests/workers/service/resources/ServiceWorkerGlobalScope_register-worker.js: Added.

Add test coverage for container.register().

6:32 PM Changeset in webkit [225455] by Chris Dumez

14 edits
3 adds in trunk

Support serviceWorkerRegistration.update() inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180215

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test that no longer times out. The test still fails even
though we support update(). The issue is that the second frame load
uses the new worker (because of the update()) instead of the old one.
The test seems to expect that the new service worker is still in
waiting state at the point the second frame is loaded. However, for us
it is already activated.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt:

Source/WebCore:

Support serviceWorkerRegistration.update() inside service workers. The code paths
for job scheduling and resolution have been made thread safe by hopping to the right
thread when necessary. In particular, ServiceWorkerContainer always makes sure to to
a callOnMainThread() before calling methods on the SWClientConnection. Also, the
SWClientConnection relies on a new postTaskTo() method before calling methods on the
job.

Test: http/tests/workers/service/self_registration_update.html

workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
(WebCore::SWClientConnection::clearPendingJobs):
(WebCore::SWClientConnection::postTaskTo):

workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):
(WebCore::ServiceWorkerContainer::contextIdentifier):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::ServiceWorkerJob):

workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::contextIdentifier):

workers/service/ServiceWorkerJobClient.h:
workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):

workers/service/ServiceWorkerTypes.h:

LayoutTests:

Add layout test coverage and unskip WPT test that no longer times out.

TestExpectations:
http/tests/workers/service/resources/self_registration_update-worker.js: Added.
http/tests/workers/service/self_registration_update-expected.txt: Added.
http/tests/workers/service/self_registration_update.html: Added.

3:11 PM Changeset in webkit [225454] by Simon Fraser

4 edits in trunk/Source/WebCore

Make IOSurface::Locker and use it in ImageBufferDataCG
https://bugs.webkit.org/show_bug.cgi?id=180317

Reviewed by Zalan Bujtas.

Add an RAII IOSurface::Locker which can lock readonly or readwrite. Access
to the IOSurface base address is through the locker.

Add IOSurface::bytesPerRow() to wrap IOSurfaceGetBytesPerRow().

After this, there is only one location where we access the IOSurfaceRef
directly, in WebGL code.

platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::toBGRAData const):
(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

platform/graphics/cocoa/IOSurface.h:
platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::bytesPerRow const):

12:35 PM Changeset in webkit [225453] by Simon Fraser

17 edits in trunk/Source/WebCore

Add an AlphaPremultiplication enum and use it consistently
https://bugs.webkit.org/show_bug.cgi?id=180316

Reviewed by Zalan Bujtas.

ImageBuffer-related code sometimes used the 'Multiply' enum, and sometimes
a bool to represent alpha premultiplication. Make an enum class and use it
everywhere. Re-order and rename some parameters to clarify the meaning of this
argument.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::putImageData):

platform/graphics/GraphicsTypes.cpp:

(WebCore::operator<<):

platform/graphics/GraphicsTypes.h:
platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::genericConvertToLuminanceMask):

platform/graphics/ImageBuffer.h:
platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData const):
(WebCore::ImageBuffer::getPremultipliedImageData const):
(WebCore::ImageBuffer::putByteArray):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData const):
(WebCore::ImageBuffer::getPremultipliedImageData const):
(WebCore::ImageBuffer::putByteArray):

platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

platform/graphics/cg/ImageBufferDataCG.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::imageBufferResult):

platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

platform/graphics/win/ImageBufferDataDirect2D.h:
platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::getUnmultipliedImageData const):
(WebCore::ImageBuffer::getPremultipliedImageData const):
(WebCore::ImageBuffer::putByteArray):

11:41 AM Changeset in webkit [225452] by commit-queue@webkit.org

23 edits
2 copies
3 adds in trunk

Implement https://w3c.github.io/ServiceWorker/#clients-getall
https://bugs.webkit.org/show_bug.cgi?id=180276

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-02
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
web-platform-tests/service-workers/service-worker/navigate-window.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/serviceworkerclients-matchAll.https.html

Move Clients QueryOptions to its own class since it is used by various parties.
Add encoder/decoder routines.

Add a ServieWorkerClientInformation which replaces SWServer::ClientInformation structure.
This is what is sent back as a result to matchAll requests.
Add encoder/decoder routines.

Implement matchAll by hopping to the main thread, making IPC to the storage process.
SWServer in storage process then iterates through the relevant service workers and does some filtering.
Additional filtering and information should be gathered in future patches to fully implement the algorithm.

Add to SWServer a HashMap to easily identify by which service worker a client is controlled, if any.
This map is updated at the same time registrations are updated.

matchAll is given a callback as in the future, window client information will be retrieved asynchronously.

WebCore.xcodeproj/project.pbxproj:
workers/service/ServiceWorkerClientInformation.h: Added.

(WebCore::ServiceWorkerClientInformation::isolatedCopy const):
(WebCore::ServiceWorkerClientInformation::encode const):
(WebCore::ServiceWorkerClientInformation::decode):

workers/service/ServiceWorkerClientQueryOptions.h: Added.

(WebCore::ServiceWorkerClientQueryOptions::encode const):
(WebCore::ServiceWorkerClientQueryOptions::decode):

workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::matchAll):

workers/service/ServiceWorkerClients.h:
workers/service/context/SWContextManager.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::matchAll):
(WebCore::SWServer::registerServiceWorkerClient):

workers/service/server/SWServer.h:
workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::matchAll):

workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::matchAll):

workers/service/server/SWServerWorker.h:

Source/WebKit:

Add IPC plumbery for clients.matchAll between ServiceWorker process and Storage process.

StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::matchAllCompleted):

StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::matchAll):
(WebKit::WebSWContextManagerConnection::matchAllCompleted):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

http/tests/workers/service/serviceworkerclients-matchAll-worker.js: Added.
http/tests/workers/service/serviceworkerclients-matchAll.https-expected.txt: Added.
http/tests/workers/service/serviceworkerclients-matchAll.https.html: Added.

10:41 AM Changeset in webkit [225451] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Remote Web Inspector window always shows up at the default size
https://bugs.webkit.org/show_bug.cgi?id=180284
<rdar://problem/35430255>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-02
Reviewed by Brian Burg.

UIProcess/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
Give remote web inspector windows an autosave name so that their frame can
be automatically saved and restored by the system.

10:00 AM Changeset in webkit [225450] by beidson@apple.com

6 edits
2 adds in trunk/Source

Factor out the "databaseTaskQueue" parts of IDBServer into something reusable.
https://bugs.webkit.org/show_bug.cgi?id=180298

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (Refactor only).

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseRunLoop): Deleted.
(WebCore::IDBServer::IDBServer::handleTaskRepliesOnMainThread): Deleted.

Modules/indexeddb/server/IDBServer.h:

(): Deleted.

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:

wtf/CrossThreadTaskHandler.cpp: Added.

(WTF::CrossThreadTaskHandler::CrossThreadTaskHandler):
(WTF::CrossThreadTaskHandler::~CrossThreadTaskHandler):
(WTF::CrossThreadTaskHandler::postTask):
(WTF::CrossThreadTaskHandler::postTaskReply):
(WTF::CrossThreadTaskHandler::taskRunLoop):
(WTF::CrossThreadTaskHandler::handleTaskRepliesOnMainThread):

wtf/CrossThreadTaskHandler.h: Added.

9:55 AM Changeset in webkit [225449] by Simon Fraser

14 edits in trunk/Source

Add a log channel for viewports
https://bugs.webkit.org/show_bug.cgi?id=180295

Reviewed by Zalan Bujtas.

Add a "Viewports" log channel to log viewport scaling information, and enhance the
WebKit "VisibleRects" channel to log additional data for the same reason.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::processViewport):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::completed):

page/FrameView.cpp:

(WebCore::FrameView::resetScrollbarsAndClearContentsSize):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::autoSizeIfEnabled):
(WebCore::FrameView::setWasScrolledByUser):

page/LayoutContext.cpp:

(WebCore::LayoutContext::layout):

page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setContentsSize):
(WebCore::ViewportConfiguration::setViewportArguments):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::operator<<):
(WebCore::ViewportConfiguration::description const):
(WebCore::ViewportConfiguration::dump const):

page/ViewportConfiguration.h:
platform/Logging.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::setFixedLayoutSize):

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:nextValidLayerTreeTransactionID:]):
(-[WKWebView _dispatchSetMinimumLayoutSize:]):
(-[WKWebView _endAnimatedResize]):
(-[WKWebView _resizeWhileHidingContentWithUpdates:]):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFixedLayoutSize):
(WebKit::WebPage::mainFrameDidLayout):
(WebKit::WebPage::didCommitLoad):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::scaleAfterViewportWidthChange):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSize):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::resetViewportDefaultConfiguration):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateVisibleContentRects):

7:13 AM Changeset in webkit [225448] by Carlos Garcia Campos

7 edits in trunk/Source

WebDriver: handle user prompts shown while executing scripts
https://bugs.webkit.org/show_bug.cgi?id=179979

Reviewed by Brian Burg.

Source/WebDriver:

15.2 Executing Script
https://w3c.github.io/webdriver/webdriver-spec.html#executing-script

The rules to execute a function body are as follows. The algorithm will return success with the JSON
representation of the function’s return value, or an error if the evaluation of the function results in a
JavaScript exception being thrown or at any point during its execution an unhandled user prompt appears.

If at any point during the algorithm a user prompt appears, the user prompt handler must be invoked. If its
return value is an error, it must immediately return with that error and abort all subsequent substeps of this
algorithm.

This will be covered by new WPT tests that will be available after the next upgrade.

CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle UnexpectedAlertOpen internal error.

Session.cpp:

(WebDriver::Session::handleUserPrompts): Move code to handleUnexpectedAlertOpen() and call it instead.
(WebDriver::Session::handleUnexpectedAlertOpen): Code moved here to be used also by executeScript().
(WebDriver::Session::executeScript): In case of UnexpectedAlertOpen error, call handleUnexpectedAlertOpen().

Session.h:

Source/WebKit:

UIProcess/Automation/Automation.json: Add UnexpectedAlertOpen error.
UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::willShowJavaScriptDialog): Finish pending evaluateJavaScriptFunction operations
with UnexpectedAlertOpen error.

6:56 AM Changeset in webkit [225447] by Carlos Garcia Campos

16 edits
1 add
1 delete in trunk

WebDriver: auto-install pytest instead of importing it from wpt tools directory
https://bugs.webkit.org/show_bug.cgi?id=180243

Reviewed by Brian Burg.

Tools:

We don't really need the (old) version included in wpt tools dir, so we can simply remove it and use autoinstall
instead.

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Check pytest.
(AutoinstallImportHook._install_pytest): Install pytest.

Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py: Import autoinstalled pytest.
Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C.run): Update the subtest path since the new pytest uses a different strategy for
rootdir.

Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Import autoinstalled pytest.

WebDriverTests:

imported/selenium/py/conftest.py: Stop patching this to use yield_fixture, new pytest supports this.
imported/selenium/py/setup.cfg: Stop patching this, since pytest supports tool:pytest as group name.
imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py: Stop patching this to use yield_fixture,

new pytest supports this.

imported/selenium/py/test/selenium/webdriver/common/cookie_tests.py: Ditto.
imported/selenium/py/test/selenium/webdriver/common/frame_switching_tests.py: Ditto.
imported/selenium/py/test/selenium/webdriver/common/page_load_timeout_tests.py: Ditto.
imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py: Ditto.
imported/selenium/py/test/selenium/webdriver/safari/conftest.py: Ditto.
imported/selenium/py/test/selenium/webdriver/support/event_firing_webdriver_tests.py: Ditto.
imported/w3c/importer.json: Stop importing pytest.
imported/w3c/pytest.ini: Added.
imported/w3c/tools/pytest/: Removed.

12:47 AM Changeset in webkit [225446] by Wenson Hsieh

6 edits in trunk/Source/WebKit

Make some minor adjustments to TouchBarMenuData and TouchBarMenuItemData
https://bugs.webkit.org/show_bug.cgi?id=180305

Reviewed by Joseph Pecoraro.

Mark some methods and parameters as const, use the default constructor in more places, and also remove a few
extraneous imported headers.

Shared/TouchBarMenuData.cpp:

(WebKit::TouchBarMenuData::TouchBarMenuData):

Add a FIXME regarding the use of the 'id' attribute.

(WebKit::TouchBarMenuData::decode):

Shared/TouchBarMenuData.h:

(WebKit::TouchBarMenuData::items const):
(WebKit::TouchBarMenuData::setID):
(WebKit::TouchBarMenuData::isPageCustomized const):
(WebKit::TouchBarMenuData::items): Deleted.
(WebKit::TouchBarMenuData::isPageCustomized): Deleted.

Shared/TouchBarMenuItemData.cpp:

(WebKit::getItemType):

Change a helper method from a static class function to a static function in the implementation file.

(WebKit::TouchBarMenuItemData::TouchBarMenuItemData):
(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):
(WebKit::TouchBarMenuItemData::getItemType): Deleted.

Shared/TouchBarMenuItemData.h:

(WebKit::operator==):

Remove the commandName member variable, since it doesn't make sense to propagate an event handler
attribute from WebCore to the client layer.

UIProcess/WebPageProxy.messages.in:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed