Version 3 (modified by Carlos Garcia Campos, 13 years ago) (diff)

Add comment about includes

Adding new API to WebKit2 GTK+

  • Patches including new public API should be approved by at least two reviewers
  • Patches should include API documentation for new methods, properties, signals, etc.
  • Patches should always include unit tests for new API when possible
  • Follow coding style guidelines
    • Use GNOME coding style for public headers and generated code (get_type(), init() and class_init() methods)
    • Use WebKit coding style for all other code, including unit tests, See
    • You can use check-webkit-style script to make sure your patch follows the WebKit coding style
  • Use the placement new syntax for private structures
    • Let glib allocate the private structure using g_type_class_add_private() as usual
    • In the init method use the following syntax
      static void webkit_foo_init(WebKitFoo* foo)
          WebKitFooPrivate* priv = G_TYPE_INSTANCE_GET_PRIVATE(foo, WEBKIT_TYPE_FOO, WebKitFooPrivate);
          foo->priv = priv;
          new (priv) WebKitFooPrivate();
    • And in finalize method call the destructor manually
      static void webkitFooFinalize(GObject* object)
  • Use wtf classes (CString, HashMap, etc.) and GRefPtr/GOwnPtr for attributes so that they are automatically freed by the private structure destructor
  • Don't make private structures public in Private.h headers, keep them in the corresponding .cpp file and add private API for accessing them when needed.
  • Use GObject properties only for attributes that can change their value at any time, so that users can monitor them connecting to notify signal.
  • Add always public get/set methods even for attributes that are GObject properties
  • Protect arguments of public methods using g_return_if_fail() and g_return_val_if_fail() macros
    • For private methods use ASSERT or g_assert() instead, but only when it's really needed
  • Protect public headers so that they can't be included directly in client code, adding the following code at the top of the file (after the license text):
    #if !defined(__WEBKIT2_H_INSIDE__) && !defined(WEBKIT2_COMPILATION)
    #error "Only <webkit2/webkit2.h> can be included directly."
    #ifndef WebKitFoo_h
    #define WebKitFoo_h
  • Don't expose the C API in public API or headers
  • Including other headers:
    • Use always the angle-bracket form of #include directive in public headers
    • In private headers or .cpp files
      • Use the angle-bracket form for header files from other libraries, including WebCore, JavaScriptCore or the WebKit2 C API
      • Use the quoted form for header files of WebKit2