Changes between Version 1 and Version 2 of detect a RenderObject is destroyed unsafely


Ignore:
Timestamp:
Apr 25, 2011 12:02:58 PM (9 years ago)
Author:
Simon Fraser
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • detect a RenderObject is destroyed unsafely

    v1 v2  
    2626Two approaches
    27271. Global "I'm holding a ref to some renderer, so don't destroy any". Addresses risk of being too specific
    28 2. Smart-pointer type object: RenderPtr
     282. Smart-pointer type object: RenderPtr.
    2929
    30 
     30(We look at some stack traces).
     31We should protect against higher-level re-entrancy issues e.g. updating style/layout in painting.
    3132
    3233
    3334'''Actionable things'''
    3435Rename the detach() method
     36Assert isMainThread() in Document::updateStyleForAllDocuments()