Changes between Version 1 and Version 2 of detect a RenderObject is destroyed unsafely
- Timestamp:
- Apr 25, 2011 12:02:58 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
detect a RenderObject is destroyed unsafely
v1 v2 26 26 Two approaches 27 27 1. Global "I'm holding a ref to some renderer, so don't destroy any". Addresses risk of being too specific 28 2. Smart-pointer type object: RenderPtr 28 2. Smart-pointer type object: RenderPtr. 29 29 30 30 (We look at some stack traces). 31 We should protect against higher-level re-entrancy issues e.g. updating style/layout in painting. 31 32 32 33 33 34 '''Actionable things''' 34 35 Rename the detach() method 36 Assert isMainThread() in Document::updateStyleForAllDocuments()