Context Navigation

← Previous Period
Next Period →

Timeline

Dec 2, 2007:

11:53 PM Changeset in webkit [28329] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/collector.cpp:

11:43 PM Changeset in webkit [28328] by ggaren@apple.com

47 edits
1 add in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

Second step in refactoring JSGlobalObject: moved virtual functions from
Interpreter to JSGlobalObject.

Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
believe his lies.

JavaScriptGlue:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

JSRun.cpp:
JSRun.h:
JSValueWrapper.cpp: (getThreadGlobalExecState):
JavaScriptGlue.cpp: (JSRunCopyGlobalObject): (JSRunEvaluate):

WebCore:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

Moved virtual ScriptInterpreter functions to Window.

WebKit/mac:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

WebView/WebFrame.mm: (-[WebFrame globalContext]): Use the toRef function instead of manually casting.

9:52 PM QtWebKitContrib edited by Simon Hausmann

(diff)

8:57 PM Changeset in webkit [28327] by Darin Adler

17 edits
22 adds in trunk

WebCore:

Reviewed by Mitz.

fix <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

There were two problems here:

1) Incorrect HTMLCollection behavior led to us trying to insert a

new row inside an existing row instead of next to it. The fix for
this is to make HTMLCollection work better for table-related
collections.

2) HTMLTableRowElement::insertCell would return a bad pointer if

the insertion failed. The code should have failed, but not crashed,
so it's worth fixing that too.

While fixing the HTMLCollection issues, I did some clean-up of that
class and its derived classes.

Test: fast/dom/HTMLTableElement/rows.html
Test: fast/dom/HTMLTableElement/tBodies.html
Test: fast/dom/HTMLTableRowElement/cells.html
Test: fast/dom/HTMLTableRowElement/insertCell.html
Test: fast/dom/HTMLTableSectionElement/rows.html

bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated because collectionType() was renamed to type().

html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Updated for data member name changes. Also added a protected constructor for use by derived classes that pass in a CollectionInfo. (WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of the header. (WebCore::isTableSection): Added. (WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem, because the old name was grammatically incorrect and thus a bit confusing. Changed to operate on Element* instead of Node*, and use 0 to start rather than passing in the base node (required since the base node can be a document, which is not an element). Generalized the code that made NodeChildren not descend into deeper descendants so it can be used for TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the switch statement and got rid of the "found" boolean since we can just return when we find something. Got rid of the default case, and instead listed all the enum values. Also changed to use a for loop for clarity. (WebCore::HTMLCollection::calcLength): Updated for itemAfter changes. (WebCore::HTMLCollection::item): Ditto. (WebCore::HTMLCollection::nextItem): Ditto. (WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element instead of a Node pointer. (WebCore::HTMLCollection::namedItem): More of the same. (WebCore::HTMLCollection::updateNameCache): Ditto. (WebCore::HTMLCollection::namedItems): Ditto. (WebCore::HTMLCollection::nextNamedItem): Ditto. (WebCore::HTMLCollection::tags): Ditto.

html/HTMLCollection.h: Added a type FormElements, so that the HTMLFormCollection would not have a type of DocImages, which is what it previously did. Changed the base parameter to be a PassRefPtr to make it clear we take ownership of it. Added a comment explaining why we should change the name CollectionInfo. Made a lot more members private instead of protected. Renamed traverseNextItem to itemAfter. Changed most functions to take Element* instead of Node*.

html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Added. (WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass collection info into the base class. (WebCore::HTMLFormCollection::calcLength): Updated to use base() so we don't need to get at m_base directly. (WebCore::HTMLFormCollection::item): Same, but for info(). (WebCore::HTMLFormCollection::getNamedItem): Removed unused first argument. (WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded checks that the base is still an element and still a form, since that's guaranteed. (WebCore::HTMLFormCollection::nextItem): Use info(). (WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of Element, some name changes. (WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere. (WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop to be much simpler. (WebCore::HTMLFormCollection::updateNameCache): More of the same.

html/HTMLFormCollection.h: Changed constructor to take an HTMLFormElement, using a PassRefPtr to communicate transfer of ownership. Made everything private instead of protected. Removed unneeded override of firstItem. Made getNamedItem and nextNamedItemInternal non-virtual. Removed unused first argument of getNamedItem. Added declaration of formCollectionInfo.

html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass collection info into the base class. (WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and changed into a for loop.

html/HTMLNameCollection.h: Updated for name changes. Made function private instead of public. Used PassRefPtr in constructor.

html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to pass collection info into the base class. (WebCore::HTMLOptionsCollection::add): Updated for public/private changes in the base class. (WebCore::HTMLOptionsCollection::selectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setLength): Ditto.

html/HTMLOptionsCollection.h: Changed constructor parameter to be a PassRefPtr.

html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr and PassRefPtr since this creates a new object. This alone fixed the crash. Also cleaned up logic a bit to be more readable.

html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr. Also reordered functions a bit to make things a little more logical and removed the unused ncols data member.

html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not TableRows. This mistake was harmless before because TableRows and TSectionRows were handled identically inside HTMLCollection, but that is no longer the case with this fix.

bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the fact that HTMLOptionsCollection no longer includes HTMLOptionElement. I don't think this really should be a special case -- might be worth returning later to see if this can be optimized.

LayoutTests:

Reviewed by Mitz.

tests for table-related HTMLCollection classes for misnested tables and for <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

fast/dom/HTMLTableElement/resources: Added.
fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableElement/resources/rows.js: Added.
fast/dom/HTMLTableElement/resources/tBodies.js: Added.
fast/dom/HTMLTableElement/rows-expected.txt: Added.
fast/dom/HTMLTableElement/rows.html: Added.
fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
fast/dom/HTMLTableElement/tBodies.html: Added.
fast/dom/HTMLTableRowElement: Added.
fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
fast/dom/HTMLTableRowElement/cells.html: Added.
fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
fast/dom/HTMLTableRowElement/insertCell.html: Added.
fast/dom/HTMLTableRowElement/resources: Added.
fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableRowElement/resources/cells.js: Added.
fast/dom/HTMLTableSectionElement: Added.
fast/dom/HTMLTableSectionElement/resources: Added.
fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
fast/dom/HTMLTableSectionElement/rows.html: Added.

8:41 PM Changeset in webkit [28326] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More planned renaming.

5:05 PM Changeset in webkit [28325] by Nikolas Zimmermann

4 edits in trunk/WebCore

Reviewed by Adam.

RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.

Fixes:

svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
svg/custom/deep-dynamic-updates.svg
svg/custom/use-clipped-hit.svg
svg/custom/image-clipped-hit.svg

3:40 PM Changeset in webkit [28324] by weinig@apple.com

2 edits in trunk/WebKitTools

Rubber stamped by Anders.

Use [NSURL absoluteString] instead of [NSURL description] in order to get
more uniform results cross platform.

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):

3:32 PM Changeset in webkit [28323] by weinig@apple.com

3 edits
2 moves in trunk/WebKitTools

Rubber stamped by Niko.

Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.

DumpRenderTree/win/DumpRenderTree.cpp:
DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
DumpRenderTree/win/FrameLoaderDelegate.h: Removed.

12:20 PM Changeset in webkit [28322] by beidson@apple.com

7 edits in trunk/WebCore

Reviewed by Darin

databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
like all other notifications we send out!

platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
platform/SecurityOriginData.h:

storage/DatabaseTracker.cpp: (WebCore::notificationMutex): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue (WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications on the main thread (WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
storage/DatabaseTracker.h:

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!" (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto

12:18 PM WebKit Team edited by rwlbuis@webkit.org

(diff)

11:32 AM Changeset in webkit [28321] by rwlbuis@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16002
Load SVG (and other) UA StyleSheets dynamically when needed

Load svg sheet when needed.

6:13 AM QtWebKitTodo edited by Simon Hausmann

(diff)

4:59 AM Changeset in webkit [28320] by mrowe@apple.com

2 edits in trunk/WebCore

Speculative Windows build fix.

4:02 AM Changeset in webkit [28319] by Nikolas Zimmermann

4 edits
31 copies
1 move in trunk/WebCore

Rubber stamped by Eric.

Move platform/graphics/svg to graphics/svg as discussed on webkit-dev.
Updated all project files.

3:22 AM Changeset in webkit [28318] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Maciej.
Fix IDL lookup in subdirectories. Missing 'my' prefix for the 'thisDir' variable.

3:08 AM BuildingGtk edited by alp@atoker.com

Mention the Debian WebKit packaging team and its mailing lists (diff)

12:32 AM Changeset in webkit [28317] by Adam Roben

1 edit
1 add in trunk/WebKitSite

Add another screenshot

blog-files/InspectElementMenu.png: Added.

12:16 AM Changeset in webkit [28316] by alp@webkit.org

7 edits
1 add in trunk

2007-12-01 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which
takes care of extern "C".

Introduce a webkit.h convenience header.

Remove another left-over from the old API.

12:07 AM Changeset in webkit [28315] by Adam Roben

2 edits
2 adds in trunk/WebKitSite

Add some Inspector screenshots for an upcoming blog post

Rubberstamped by Mark Rowe.

blog-files/InspectorCSSEditing.png: Added.
blog-files/InspectorFonts.png: Added.

Dec 1, 2007:

11:56 PM Changeset in webkit [28314] by beidson@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Tim

Added a default database quota of 5mb to the default WebPreferences

WebView/WebPreferences.m: (+[WebPreferences initialize]):

10:43 PM Changeset in webkit [28313] by alp@webkit.org

4 edits in trunk/WebKit/gtk

2007-12-01 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=15687
[Gtk] Allow API clients to interact with JavaScript in web pages

Include the necessary JavaScriptCore headers directly in the public
API headers.

This is the last of a series of changes needed to allow GTK+
applications to access the JS API.

Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
developers will still have to include the individual JS API headers
individually if they want to use it in their applications.

Patch also removes some old legacy use of GDK that was in
WebKitWebFrame. No ABI change.

WebView/webkitdefines.h:
WebView/webkitwebframe.h:
WebView/webkitwebview.h:

10:14 PM Changeset in webkit [28312] by Antti Koivisto

3 edits
4 adds in trunk

WebCore:

Reviewed by Adam.

Fix a crash when removing a loading media element from the tree.
Follow the spec by invoking pause() when element is removed from the tree instead of unloading.

Tests: http/tests/media/remove-while-loading.html

media/remove-from-document.html

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):

LayoutTests:

Reviewed by Adam.

Test that removing a media element when it is loading does not crash.
Test that media is paused when it is removed from the tree.

http/tests/media/remove-while-loading-expected.txt: Added.
http/tests/media/remove-while-loading.html: Added.
media/remove-from-document-expected.txt: Added.
media/remove-from-document.html: Added.

9:24 PM Changeset in webkit [28311] by alp@webkit.org

3 edits in trunk/JavaScriptCore

2007-12-01 Alp Toker <alp@atoker.com>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT

Add JS_EXPORT to kJSClassDefinitionEmpty.

Make the gcc compiler check take precedence over the WIN32

_WIN32

check to ensure that symbols are exported on Windows when using gcc.

Add a TODO referencing the bug about JS_EXPORT in the Win build
(http://bugs.webkit.org/show_bug.cgi?id=16227)

Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:

extern extern const JSClassDefinition kJSClassDefinitionEmpty;

(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)

API/JSBase.h:
API/JSObjectRef.h:

3:59 PM Changeset in webkit [28310] by ggaren@apple.com

2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Restored the test string in this test.

manual-tests/window-open-features-parsing.html:

3:56 PM Changeset in webkit [28309] by ggaren@apple.com

25 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.

Reversed the ownership relationship between Interpreter and JSGlobalObject.
Now, the JSGlobalObject owns the Interpreter, and top-level objects
that need the two to persist just protect the JSGlobalObject from GC.

Global object bootstrapping looks a little odd right now, but it will
make much more sense soon, after further rounds of refactoring.

bindings/runtime_root.h: Made this class inherit from RefCounted, to avoid code duplication.

kjs/collector.cpp: (KJS::Collector::collect): No need to give special GC treatment to Interpreters, since we mark their global objects, which mark them.

kjs/interpreter.cpp: (KJS::Interpreter::mark): No need to mark our global object, since it marks us.
kjs/interpreter.h: Don't inherit from RefCounted -- JSGlobalObject owns us directly.

kjs/testkjs.cpp: Modified to follow the new rules. (createGlobalObject): (runWithScripts):

JavaScriptGlue:

Reviewed by Beth Dakin.

Modified to follow new JSGlobalObject/Interpreter ownership rules
in JavaScriptCore.

JSRun.cpp: (JSRun::JSRun): (JSRun::GetInterpreter): (JSRun::Evaluate): (JSRun::CheckSyntax):
JSRun.h:
JSValueWrapper.cpp: (unprotectGlobalObject): (initializeGlobalObjectKey): (getThreadGlobalExecState):

WebCore:

Reviewed by Beth Dakin.

Modified WebCore to follow the new JSGlobalObject/Interpreter ownership
rules in JavaScriptCore.

bindings/js/kjs_binding.cpp:
bindings/js/kjs_binding.h: Removed stale, unused interpreterForGlobalObject().

bindings/js/kjs_proxy.cpp: Changed to store a global object, rather than an interpreter. (WebCore::KJSProxy::finishedWithEvent): Need to NULL check m_globalObject here because we no longer unnecessarily instantiate it.

bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
bindings/js/kjs_window.h: Removed redundant and less efficient interpreter() function -- global objects have direct access to their interpreters now.

Changed these functions to pass around JSGlobalObjects instead of
Interpreters:

page/Frame.cpp: (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject):
page/Frame.h:
page/mac/WebCoreFrameBridge.mm: (createRootObject):

3:35 PM Changeset in webkit [28308] by treat@webkit.org

2 edits in trunk/WebKitTools

Check to see if the directory exists and exit if not.

2:32 PM BuildingGtk edited by alp@atoker.com

Add links to distribution packages (diff)

2:29 PM Changeset in webkit [28307] by weinig@apple.com

4 edits in trunk/WebKit/win

Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.

Rubber stamped by Adam Roben.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::selectionRect):
WebView.h:

2:15 PM Changeset in webkit [28306] by mitz@apple.com

2 edits in trunk/PlanetWebKit

Reviewed by Mark Rowe.

config.ini: Correct blog name.

1:08 PM Changeset in webkit [28305] by timothy@apple.com

1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update StringsNotToBeLocalized.txt.

11:43 AM UsingGitWithWebKit edited by Adam Roben

(diff)

11:04 AM Changeset in webkit [28304] by Darin Adler

3 edits in trunk/WebCore

Reviewed by Mitz.

fix problem tracked by these bugs: http://bugs.webkit.org/show_bug.cgi?id=16097 <rdar://problem/5619305> Safari crashes during load of LexisNexis search results <rdar://problem/5510779> CrashTracer: [USER] 25 crashes in Safari at WebCore::DocumentLoader::isLoadingMultipartContent const

loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Create an ImageDocumentElement instead of an HTMLImageElement. (WebCore::ImageDocument::scale): Added a null check for m_imageElement. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto. (WebCore::ImageDocument::windowSizeChanged): Ditto. (WebCore::ImageDocumentElement::~ImageDocumentElement): Call disconnectImageElement so m_imageElement will be set to 0 if we're still connected to the document. (WebCore::ImageDocumentElement::willMoveToNewOwnerDocument): Ditto.

loader/ImageDocument.h: Changed image element type to be ImageDocumentElement instead of HTMLImageElement. Also added a disconnectImageElement function that sets m_imageElement to 0.

10:44 AM Changeset in webkit [28303] by Darin Adler

1 edit
1 delete in trunk/WebCore

remove the empty directories

ksvg2: Removed.
ksvg2/css: Removed.
ksvg2/events: Removed.
ksvg2/misc: Removed.
ksvg2/scripts: Removed.

10:09 AM Changeset in webkit [28302] by Darin Adler

1 edit in trunk/SunSpider/hosted

Ignore another file that's now part of hosted SunSpider.

8:51 AM Changeset in webkit [28301] by mrowe@apple.com

5 edits in trunk

2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>

Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

Reviewed by Darin Adler.

xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader):

Test: http/tests/xmlhttprequest/set-dangerous-headers.html

2007-12-01 Julien Chaffraix <julien.chaffraix@gmail.com>

Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

Reviewed by Darin Adler.

http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
http/tests/xmlhttprequest/set-dangerous-headers.html: Added tests for new headers

8:41 AM Changeset in webkit [28300] by mrowe@apple.com

3 edits in trunk/WebCore

2007-12-01 Rahul Abrol <ra5ul@comcast.net>

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=16128
Ignore resizable=no for window.open().

bindings/js/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures):
manual-tests/window-open-features-parsing.html:

8:33 AM Changeset in webkit [28299] by mitz@apple.com

7 edits
2 adds in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

Test: fast/dynamic/subtree-common-root.html

page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added a parameter to let this method return the layout root for a pending layout as well. (WebCore::FrameView::scheduleRelayoutOfSubtree): Pass the new root to markContainingBlocksForLayout(). Otherwise, markContainingBlocksForLayout() could mark past the new root, if it had previously been marked as having a normal child needing layout and then was reached via a positioned child.
page/FrameView.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth):
rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): Fixed the ASSERT so that it would really catch deletion of the layout root. (WebCore::RenderObject::markContainingBlocksForLayout): Added the newRoot parameter, which tells this method where to stop marking.
rendering/RenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

test for <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

fast/dynamic/subtree-common-root-expected.txt: Added.
fast/dynamic/subtree-common-root.html: Added.

8:28 AM Changeset in webkit [28298] by mitz@apple.com

29 edits
1 delete in trunk/WebCore

Reviewed by Darin Adler.

fold FontStyle into TextRun

WebCore.xcodeproj/project.pbxproj:
platform/graphics/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
platform/graphics/Font.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setText): (WebCore::TextRun::allowTabs): (WebCore::TextRun::xPos): (WebCore::TextRun::padding): (WebCore::TextRun::rtl): (WebCore::TextRun::ltr): (WebCore::TextRun::directionalOverride): (WebCore::TextRun::applyRunRounding): (WebCore::TextRun::applyWordRounding): (WebCore::TextRun::spacingDisabled): (WebCore::TextRun::disableSpacing): (WebCore::TextRun::disableRoundingHacks): (WebCore::TextRun::setRTL): (WebCore::TextRun::setDirectionalOverride):
platform/graphics/FontStyle.h: Removed.
platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawBidiText): (WebCore::GraphicsContext::drawHighlightForText):
platform/graphics/GraphicsContext.h:
platform/graphics/StringTruncator.cpp: (WebCore::stringWidth):
platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
platform/graphics/qt/FontQt.cpp: (WebCore::generateComponents): (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::offsetForPosition): (WebCore::cursorToX): (WebCore::Font::selectionRectForText):
platform/graphics/win/FontWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
platform/graphics/wx/FontWx.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
platform/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): (WebCore::UniscribeController::offsetForPosition): (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::resetControlAndState): (WebCore::UniscribeController::shapeAndPlaceItem):
platform/win/UniscribeController.h:
platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint):
rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcPrefWidths):
rendering/RenderImage.cpp:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
rendering/RenderText.h: (WebCore::RenderText::allowTabs):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection):
rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox):
rendering/SVGRootInlineBox.h:

4:58 AM Changeset in webkit [28297] by mrowe@apple.com