⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 12, 2010:

11:42 PM Changeset in webkit [57503] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Finish IPv4 URL parsing test
​https://bugs.webkit.org/show_bug.cgi?id=37493

I rushed the first version of this test because I wanted to get the
framework in the tree for other folks to work on the other tests. The
expected.txt file matches KURL but the PASS/FAIL indiciations match
GURL.

  • fast/url/ipv4-expected.txt:
  • fast/url/script-tests/ipv4.js:
11:09 PM Changeset in webkit [57502] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-12 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37480

Implements the anchor tests from <​http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1102>.

  • fast/url/anchor-expected.txt: Added.
  • fast/url/anchor.html: Added.
  • fast/url/script-tests/anchor.js: Added.
9:52 PM Changeset in webkit [57501] by eric@webkit.org
  • 4 edits
    1 copy
    4 adds in trunk/LayoutTests

2010-04-12 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37480

Implements all of the non-encoding specific query string tests from
<​http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>.

Also, moved JavaScript function canonicalize to external JavaScript
script /resources/utilities.js since this function is being called
by tests ipv4.html, query.html, and trivial.html.

  • fast/url/ipv4.html:
  • fast/url/query-expected.txt: Added.
  • fast/url/query.html: Added.
  • fast/url/resources: Added.
  • fast/url/resources/utilities.js: Added. (canonicalize):
  • fast/url/script-tests/TEMPLATE.html: Include external JavaScript script resources/utilities.js.
  • fast/url/script-tests/query.js: Added.
  • fast/url/trivial.html:
9:38 PM Changeset in webkit [57500] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make new-run-webkit-test PrettyPatch failure reporting more awesome
​https://bugs.webkit.org/show_bug.cgi?id=37487

I also fixed an Executive/executive typo.

  • Scripts/webkitpy/layout_tests/port/base.py:
9:00 PM Changeset in webkit [57499] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should only build java support files on Mac
​https://bugs.webkit.org/show_bug.cgi?id=37482

Only the mac needs java support files, so I pushed _build_java
down into the Mac port using a new hook "_check_port_build".
In the process I noticed a bunch of code which could be shared
between all ports and thus got rid of _tests_for_disabled_features
and version() copy/paste between all webkit ports.
I also made check_build only bother to check for ImageDiff if we're
using pixel tests.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
8:00 PM Changeset in webkit [57498] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping two tests on Chromium because they fail.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [57497] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, trying to make scripts work on machines without
Ruby...

  • Scripts/webkitpy/layout_tests/port/base.py:
7:29 PM Changeset in webkit [57496] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
​https://bugs.webkit.org/show_bug.cgi?id=37461

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

getRect() of Element can be used instead of absoluteClippedOverflowRect of RenderObject when
the node is currently offscreen in an scroll overflowed content.

Test: fast/events/spatial-navigation/snav-simple-content-overflow.html

  • page/SpatialNavigation.cpp:

(WebCore::renderRectRelativeToRootDocument):

LayoutTests:

  • fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt: Added.
  • fast/events/spatial-navigation/snav-simple-content-overflow.html: Added.
7:28 PM Changeset in webkit [57495] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed style fix.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

7:13 PM Changeset in webkit [57494] by yael.aharon@nokia.com
  • 10 edits
    4 adds in trunk

Accessibility support for progress element
​https://bugs.webkit.org/show_bug.cgi?id=37275

Reviewed by Darin Adler.

WebCore:

Implement AccessibilityProgressIndicator to hook up progress element to accessibility framework.

Test: platform/mac/accessibility/progressbar.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityProgressIndicator.cpp: Added.
  • accessibility/AccessibilityProgressIndicator.h: Added.
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:

LayoutTests:

  • platform/mac/accessibility/progressbar-expected.txt: Added.
  • platform/mac/accessibility/progressbar.html: Added.
7:07 PM Changeset in webkit [57493] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test that started failing with r57492.

  • storage/open-database-over-quota.html:
6:04 PM Changeset in webkit [57492] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Throwing a SECURITY_ERR when openDatabase() cannot open a database
for whatever reason, as required by the spec.
​https://bugs.webkit.org/show_bug.cgi?id=33916

Reviewed by Dimitri Glazkov.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

5:59 PM Changeset in webkit [57491] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-12 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Add stub files for running new-run-webkit-tests for the Qt port

  • platform/qt/test_expectations.txt: Added.

2010-04-12 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Add stub files for running new-run-webkit-tests for the Qt port

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/qt.py: Added.
5:47 PM Changeset in webkit [57490] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-04-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

WebKit should have more robust last-chance font fallback on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37473
<rdar://problem/7789438> Crash in FontFallbackList::determinePitch
<rdar://problem/7233762> Crash in FontFallbackList::fontDataAt


Look harder for a suitable last-resort font. Previously, we checked for
"Times New Roman" followed by DEFAULT_GUI_FONT.


We now look for:

  • Typically installed Unicode-capable fonts, in order of coverage
  • DEFAULT_GUI_FONT
  • SPI_GETNONCLIENTMETRICS fonts


  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
5:11 PM Changeset in webkit [57489] by abarth@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add some ip4v tests (will revise in a minute)
​https://bugs.webkit.org/show_bug.cgi?id=37476

  • fast/url/ipv4-expected.txt: Added.
  • fast/url/ipv4.html: Added.
  • fast/url/script-tests/ipv4.js: Added.
  • fast/url/script-tests/trivial.js: (canonicalize):
  • fast/url/trivial-expected.txt:
4:42 PM Changeset in webkit [57488] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add a trivial test for URL parsing
​https://bugs.webkit.org/show_bug.cgi?id=37475

Hopefully this will be the starting point for many URL tests.

  • fast/url/script-tests/TEMPLATE.html: Added.
  • fast/url/script-tests/trivial.js: Added. (canonicalize):
  • fast/url/trivial-expected.txt: Added.
  • fast/url/trivial.html: Added.
4:20 PM Changeset in webkit [57487] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add #ifdef so that WKView is not included on the mac if not
compiling objective-c.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WebKit2.h:
4:15 PM Changeset in webkit [57486] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Modify run_webkit_tests.py to not call sys.exit() at the end of test
run; doing so makes it more difficult to embed the routine for,
among other things, unit tests. We push the exit calling up into
new-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=37464

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:10 PM Changeset in webkit [57485] by andersca@apple.com
  • 1 edit
    1 add in trunk/WebKit2

Add WebKit2 solution file.

Reviewed by Adam Roben.

  • WebKit2.sln: Added.
4:10 PM QtWebKitGraphics edited by Simon Fraser
(diff)
4:10 PM QtWebKitGraphics edited by Simon Fraser
(diff)
3:14 PM Changeset in webkit [57484] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/style/RenderStyle.cpp

Fix debug build bustage.

3:10 PM ReviewTool edited by maruel@chromium.org
(diff)
2:55 PM Changeset in webkit [57483] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-12 Eric Seidel <​eric@webkit.org>

Unreviewed.

Add stub Gtk implementation for new-run-webkit-tests.

  • platform/gtk/test_expectations.txt: Copied from LayoutTests/animations/resources/dynamic-stylesheet-insertion-inserted.css.

2010-04-12 Eric Seidel <​eric@webkit.org>

Unreviewed.

Add stub Gtk implementation for new-run-webkit-tests.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py: Added.
2:53 PM Changeset in webkit [57482] by hyatt@apple.com
  • 18 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37469, clean up ShadowData to be encapsulated properly.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForShadow):

  • page/animation/AnimationBase.cpp:

(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperShadow::blend):

  • page/mac/FrameMac.mm:

(WebCore::Frame::fontAttributesForSelectionStart):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/InlineTextBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustRectForOutlineAndShadow):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintCharacters):

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
(WebCore::RenderStyle::getBoxShadowExtent):
(WebCore::RenderStyle::getBoxShadowHorizontalExtent):
(WebCore::RenderStyle::getBoxShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textShadow):
(WebCore::InheritedFlags::boxShadow):

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::~ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::blur):
(WebCore::ShadowData::spread):
(WebCore::ShadowData::style):
(WebCore::ShadowData::color):
(WebCore::ShadowData::next):
(WebCore::ShadowData::setNext):

2:53 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
2:50 PM ReviewTool edited by maruel@chromium.org
(diff)
2:48 PM ReviewTool created by maruel@chromium.org
1:51 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:49 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:48 PM Accelerated Compositing edited by Simon Fraser
(diff)
1:47 PM Changeset in webkit [57481] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] LayoutTests/platform/gtk/Skipped clean up
​https://bugs.webkit.org/show_bug.cgi?id=37465

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • platform/gtk/Skipped: Clean up needed after r57289 and r57292.
1:47 PM Accelerated Compositing edited by Simon Fraser
(diff)
1:45 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:42 PM Changeset in webkit [57480] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-04-12 William Siegrist <​wsiegrist@apple.com>

Add new Qt bots for Windows release, Windows debug, Linux release minimal, Linux armv5 release, and Linux armv7 release.

1:41 PM Accelerated Compositing created by Simon Fraser
1:40 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:39 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:37 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:30 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:30 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:29 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:28 PM Transforms-Transitions-Animations created by Simon Fraser
1:26 PM Changeset in webkit [57479] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37463, clean up NinePieceImage.

Reviewed by Mark Rowe.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::slices):
(WebCore::NinePieceImage::setSlices):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):

12:28 PM Changeset in webkit [57478] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping a new test on Chromium, because the test is
using an API that is not yet implemented in Chromium.

  • platform/chromium/test_expectations.txt:
12:23 PM Changeset in webkit [57477] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r57476, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

  • platform/qt/Skipped: fast/history/multiple-classes-visited.html skipped.
11:42 AM Changeset in webkit [57476] by hyatt@apple.com
  • 4 edits
    2 adds
    1 delete in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.

Reviewed by Sam Weinig.

WebCore:

Added fast/history/multiple-classes-visited.html.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):

LayoutTests:

  • fast/history/multiple-classes-visited-expected.txt: Added.
  • fast/history/multiple-classes-visited.html: Added.
11:31 AM April 2010 Meeting edited by evan@chromium.org
add my name, alphabetize (diff)
11:03 AM Changeset in webkit [57475] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails with exception on systems missing ruby
​https://bugs.webkit.org/show_bug.cgi?id=37441

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Catch failures similar to how wdiff code path does.
    • After one failure, stop trying.
10:28 AM April 2010 Meeting edited by mjs@apple.com
(diff)
10:28 AM April 2010 Meeting edited by mjs@apple.com
(diff)
10:20 AM April 2010 Meeting edited by Simon Fraser
(diff)
10:02 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:59 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:58 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:56 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:46 AM Changeset in webkit [57474] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-04-12 Dirk Schulze <​krit@webkit.org>

Unreviewed build fix.

Make comma/whitespace around arc flags optional in SVG path syntax
​https://bugs.webkit.org/show_bug.cgi?id=37431

Fix the SL build.

  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag):
9:42 AM April 2010 Meeting edited by Simon Fraser
(diff)
9:41 AM April 2010 Meeting edited by Simon Fraser
(diff)
9:39 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:28 AM April 2010 Meeting edited by ddkilzer@webkit.org
(diff)
8:49 AM Changeset in webkit [57473] by eric@webkit.org
  • 6 edits in trunk

2010-04-12 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Add tests to handle that comma/whitespace around arc flags are optional
and that arc flags can only be 0 or 1 in SVG path syntax:
​https://bugs.webkit.org/show_bug.cgi?id=37431

  • svg/dom/fuzz-path-parser-expected.txt: One test now fails due to flags not 0 or 1
  • svg/dom/path-parser-expected.txt: Add test results for missing whitespace and flags not 0 or 1
  • svg/dom/script-tests/path-parser.js: Add 6 tests to check that whitespace is optional after flags and flags must be 0 or 1

2010-04-12 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Make comma/whitespace around arc flags optional in SVG path syntax and ensure flags are
either 0 or 1: ​https://bugs.webkit.org/show_bug.cgi?id=37431

  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): function to read in a 0 or 1 for largeArcFlag and sweepFlag (WebCore::SVGPathParser::parseSVG): modify/simplify arc parsing by using parseArcFlag()
8:24 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:23 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:12 AM April 2010 Meeting edited by Simon Hausmann
(diff)
8:09 AM April 2010 Meeting edited by adam.bergkvist@ericsson.com
(diff)
8:07 AM April 2010 Meeting edited by pmuellr@yahoo.com
(diff)
7:58 AM April 2010 Meeting edited by darin@chromium.org
(diff)
7:57 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:47 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:37 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:35 AM April 2010 Meeting edited by Simon Hausmann
(diff)
6:47 AM QtWebKitBackportingFixes edited by joseph.ligman@nokia.com
(diff)
3:59 AM Changeset in webkit [57472] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for Mac when building with build-webkit --qt

Reviewed by nobody, build fix.

Specifying no configuration on Mac builds WebCore both in debug
and release. JavaScriptCore has to follow this rule as well.

3:52 AM BuildingQtOnLinux edited by nicholas@nicholaswilson.me.uk
added dependency on fontconfig (diff)
2:20 AM Changeset in webkit [57471] by aestes@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Inserting my name in the correct location.

1:03 AM Changeset in webkit [57470] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Fix how we import simplejson based on how it's used in this file.
This fixes exceptions raised when trying to write the simplejson output.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

Apr 11, 2010:

11:53 PM April 2010 Meeting edited by xan@webkit.org
(diff)
11:19 PM April 2010 Meeting edited by levin@chromium.org
(diff)
11:11 PM April 2010 Meeting edited by levin@chromium.org
(diff)
10:47 PM April 2010 Meeting edited by levin@chromium.org
(diff)
10:41 PM April 2010 Meeting edited by mjs@apple.com
(diff)
9:54 PM Changeset in webkit [57469] by abarth@webkit.org
  • 41 edits
    2 deletes in trunk

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57468.
​http://trac.webkit.org/changeset/57468
​https://bugs.webkit.org/show_bug.cgi?id=37433

Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Removed.
  • loader/DocumentWriter.h: Removed.
  • loader/FrameLoader.cpp: (WebCore::canReferToParentFrameEncoding): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::replaceDocument): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h:
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
9:34 PM April 2010 Meeting edited by morrita@google.com
(diff)
9:20 PM Changeset in webkit [57468] by abarth@webkit.org
  • 41 edits
    2 adds in trunk

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::finishedLoading):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::encoding): (WebKit::WebFrameImpl::commitDocumentData):
  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebSearchableFormData.cpp: (WebCore::GetFormEncoding):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::pageEncoding):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::finishedLoading):
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebView/WebFrame.mm: (-[WebFrame _canProvideDocumentSource]): (-[WebFrame _receivedData:textEncodingName:]):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

Update these callsites because the method moved to DocumentWriter.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Factor DocumentWriter out of FrameLoader
​https://bugs.webkit.org/show_bug.cgi?id=37175

This patch separates the begin/write/end cycle of decoding network
bytes and putting them into a document from the rest of the loading
machinery. The code and state required to write bytes into a document
doesn't interact very much with the rest of the loading machinery.

No tests because there is no behavior change (hopefully!).

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • dom/Document.cpp: (WebCore::Document::close):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/DocumentWriter.cpp: Added.
  • loader/DocumentWriter.h: Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::didEndDocument): (WebCore::FrameLoader::willSetEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::addExtraFieldsToRequest):
  • loader/FrameLoader.h: (WebCore::FrameLoader::writer): (WebCore::FrameLoader::isDisplayingInitialEmptyDocument):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::replaceMediaElementTimerFired):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::dataEncoding):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
9:05 PM April 2010 Meeting edited by ben@webkit.org
(diff)
8:52 PM Changeset in webkit [57467] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-04-11 Chris Jerdonek <Chris Jerdonek>

Reviewed by Shinichiro Hamaji.

Refactored check-webkit-style so that the StyleChecker class
has no dependencies on patch-related concepts.

​https://bugs.webkit.org/show_bug.cgi?id=37065

This patch is an intermediate step towards making the StyleChecker
class a generalized file processor that can do arbitary operations
on the files corresponding to a list of paths. This patch
also simplifies the unit-testing of patch-checking code.

  • Scripts/check-webkit-style:
    • Updated to use the new PatchChecker class.
  • Scripts/webkitpy/style/checker.py:
    • Refactored the StyleChecker.check_patch() method into the check() method of a new PatchChecker class.
  • Scripts/webkitpy/style/checker_unittest.py:
    • Refactored the unit tests as necessary, changing the StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
8:50 PM April 2010 Meeting edited by ben@webkit.org
(diff)
8:02 PM April 2010 Meeting edited by dimich@chromium.org
(diff)
7:56 PM April 2010 Meeting edited by morrita@google.com
(diff)
7:54 PM Changeset in webkit [57466] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Unreviewed.

Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
​https://bugs.webkit.org/show_bug.cgi?id=37430

We need some basic unit testing of this script, or we're going to keep
breaking it like this. Added missing namespace qualifiers and
propagated renaming of an option.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:47 PM Changeset in webkit [57465] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-04-11 Tony Chang <​tony@chromium.org>

Not reviewed, layout test fix for QT bots.

Update paste expected results on QT and skip a new d&d test.

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/onpaste-text-html-expected.txt: Added.
7:21 PM Changeset in webkit [57464] by tony@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-11 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
​https://bugs.webkit.org/show_bug.cgi?id=37193

  • editing/pasteboard/onpaste-text-html-expected.txt: Added.
  • editing/pasteboard/onpaste-text-html.html: Added.
  • fast/events/ondrop-text-html-expected.txt: Added.
  • fast/events/ondrop-text-html.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-04-07 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] implement getData('text/html') for paste and drop events
​https://bugs.webkit.org/show_bug.cgi?id=37193

Tests: editing/pasteboard/onpaste-text-html.html

fast/events/ondrop-text-html.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): add html type (WebCore::ClipboardChromium::clearData): implement clear text/html (WebCore::ClipboardChromium::getData): implement get text/html (similar to text/plain) (WebCore::ClipboardChromium::setData): implement set text/html
7:16 PM Changeset in webkit [57463] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Break new-run-webkit-tests options into groups for easier re-use and possible relocation
​https://bugs.webkit.org/show_bug.cgi?id=37408

new-run-webkit-tests currently has one huge function for
dealing with all options-parsing.
This patch is a first attempt at trying to split that large
function down into smaller (hopefully more readable?) chunks
dealing with the different areas of options.
For example, it would make sense to move configuration
options off into some module which deals with the vagries of
WebKit's configuration system. It would also make sense to move
Chromium options off onto the Chromium port object (where they are used).
It may make sense to move results.json options over to the results.json code.
This change is a first iteration, and we will certainly need more
refinement to this code over time. Hopefully I didn't make things
harder to read here.

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:07 PM April 2010 Meeting edited by ariya@webkit.org
add myself (diff)
6:58 PM Changeset in webkit [57462] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

create-rollout copy needs to be updated to reflect removal of --no-build
​https://bugs.webkit.org/show_bug.cgi?id=37425

Removed --no-build and --no-test from the instructions because these
don't exist anymore.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
    • Updated the expected results to reflect the new copy.
  • Scripts/webkitpy/tool/steps/postdiffforrevert.py:
6:04 PM Changeset in webkit [57461] by tony@chromium.org
  • 5 edits in trunk

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
​http://trac.webkit.org/changeset/57460
​https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tonywork on #webkit).

  • DEPS:
  • gyp_webkit:

2010-04-11 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57460.
​http://trac.webkit.org/changeset/57460
​https://bugs.webkit.org/show_bug.cgi?id=37424

broke chromium builders (Requested by tonywork on #webkit).

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
5:49 PM Changeset in webkit [57460] by tony@chromium.org
  • 5 edits in trunk

2010-04-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
​https://bugs.webkit.org/show_bug.cgi?id=36578

  • DEPS:
  • gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.

2010-04-11 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] update chromium DEPS for upstream compile
​https://bugs.webkit.org/show_bug.cgi?id=36578

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between WebKit.gyp and webkit.gyp.
4:57 PM April 2010 Meeting edited by tkent@chromium.org
(diff)
4:44 PM April 2010 Meeting edited by yutak@chromium.org
(diff)
4:22 PM April 2010 Meeting edited by tkent@chromium.org
Add tkent to attendees list (diff)
4:08 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
4:05 PM April 2010 Meeting edited by abarth@webkit.org
(diff)
3:55 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
3:47 PM April 2010 Meeting edited by eric@webkit.org
(diff)
3:25 PM ApplicationsGtk edited by khorben@defora.org
Added DeforaOS Surfer (diff)
3:23 PM ApplicationsGtk edited by khorben@defora.org
Typos (diff)
3:18 PM April 2010 Meeting edited by jamesr@google.com
(diff)
3:09 PM April 2010 Meeting edited by kbr@google.com
(diff)
2:42 PM April 2010 Meeting edited by staikos@kde.org
(diff)
2:22 PM Changeset in webkit [57459] by mrowe@apple.com
  • 2 edits in tags/Safari-533.4.1/JavaScriptCore

Merge r57457.

2:15 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:14 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:14 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:12 PM Changeset in webkit [57458] by weinig@apple.com
  • 5 edits
    1 add in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37417
Move duplicated internal CoreIPC message kinds to a
header.

Reviewed by Darin Adler.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/CoreIPCMessageKinds.h: Added.

(CoreIPC::CoreIPCMessage::):
(CoreIPC::):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
2:05 PM April 2010 Meeting edited by mjs@apple.com
(diff)
2:04 PM Changeset in webkit [57457] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/7851332> Fix the build.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.cpp:

(WTF::TCMallocStats::): Initialize extra members of malloc_introspection_t to zero.

2:04 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:55 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:54 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:46 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:43 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:43 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:42 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:41 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:41 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:37 PM April 2010 Meeting edited by weinig@apple.com
(diff)
1:35 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:34 PM Changeset in webkit [57456] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Disable not-implemented warnings by default for now.

Rubber-stamped by Anders Carlsson.

  • Shared/NotImplemented.h:
1:33 PM April 2010 Meeting edited by weinig@apple.com
(diff)
1:32 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:31 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:31 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:30 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:30 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:28 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:25 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:24 PM April 2010 Meeting edited by Chris Jerdonek
Typo fix (diff)
1:22 PM April 2010 Meeting edited by mjs@apple.com
(diff)
1:20 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:19 PM Changeset in webkit [57455] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Seidel.

svn-apply errors out when removing directories in git
​https://bugs.webkit.org/show_bug.cgi?id=34871

  • Scripts/svn-apply: (isDirectoryEmptyForRemoval): early break if the directory doesn't exist (scmRemove): have git ignore unmatched files
1:18 PM Changeset in webkit [57454] by weinig@apple.com
  • 12 edits in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=37399
Remove use of STL data structures from CoreIPC code

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeBytes):
(CoreIPC::ArgumentDecoder::removeAttachment):

  • Platform/CoreIPC/ArgumentDecoder.h:

Use WTF::Deque instead of std::queue and WTF::Vector
instead of std::vector. Replace use of malloc/free with
fastMalloc/fastFree.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::addAttachment):
(CoreIPC::ArgumentEncoder::releaseAttachments):

  • Platform/CoreIPC/ArgumentEncoder.h:

Use WTF::Vector instead of std::list. Replace use of malloc/free
with fastMalloc/fastFree.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchMessages):

  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):
Use WTF::Vector instead of std::queue.

  • Platform/RunLoop.cpp:

(RunLoop::performWork):
(RunLoop::scheduleWork):

  • Platform/RunLoop.h:

Ditto.

  • Platform/WorkQueue.h:
  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::scheduleWork):
(WorkQueue::performWork):
Ditto.

1:17 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:16 PM April 2010 Meeting edited by eric@webkit.org
(diff)
1:15 PM April 2010 Meeting edited by eric@webkit.org
(diff)
12:09 PM Changeset in webkit [57453] by dbates@webkit.org
  • 4 edits
    3 deletes in trunk/WebKitTools

2010-04-11 Daniel Bates <​dbates@rim.com>

No review, rolling out 57440.
​http://trac.webkit.org/changeset/57440
​https://bugs.webkit.org/show_bug.cgi?id=27204

Did not handle Git patches that included both file and property
changes to the same file. Rolling this change out while I look
into this.

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:
  • Scripts/svn-unapply:
  • Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
  • Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
11:51 AM Changeset in webkit [57452] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Seidel.

Minor Updates and Cleanup to the Contributing Page
​https://bugs.webkit.org/show_bug.cgi?id=37415

  • coding/contributing.html:
11:43 AM Changeset in webkit [57451] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Fix typo in log path for AbstractQueue
​https://bugs.webkit.org/show_bug.cgi?id=37414

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
10:34 AM Changeset in webkit [57450] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-11 Adam Barth <​abarth@webkit.org>

Unreviewed. Add missing import statement.

  • Scripts/webkitpy/common/system/executive.py:
8:37 AM Changeset in webkit [57449] by eric@webkit.org
  • 7 edits in trunk

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

Unskip:

http/tests/security/no-referrer.html
fast/loader/onload-willSendRequest-null-for-frame.html
fast/loader/onload-willSendRequest-null-for-script.html

​https://bugs.webkit.org/show_bug.cgi?id=37410

  • platform/qt/Skipped:

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

​https://bugs.webkit.org/show_bug.cgi?id=37410

  • WebCoreSupport/FrameLoaderClientQt.cpp: (qt_set_will_send_request_returns_null): (qt_set_will_send_request_clear_headers): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

2010-04-11 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader

​https://bugs.webkit.org/show_bug.cgi?id=37410

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setWillSendRequestReturnsNull): (LayoutTestController::setWillSendRequestClearHeader):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
2:05 AM Changeset in webkit [57448] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

[Qt] Unreviewed buildfix for --debug build after r57433.

Refactor Qt DRT support in QtWebKit
​https://bugs.webkit.org/show_bug.cgi?id=35844

  • QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();

(launcherMain):

12:46 AM Changeset in webkit [57447] by Joseph Pecoraro
  • 2 edits in trunk/WebKitTools

2010-04-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Mark Rowe.

Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
​https://bugs.webkit.org/show_bug.cgi?id=37407

  • Scripts/commit-log-editor:
12:41 AM Changeset in webkit [57446] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

2010-04-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add PrettyPatch links to new-run-webkit-tests output
​https://bugs.webkit.org/show_bug.cgi?id=37406

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • We're leaking a file handle here, add a FIXME.
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
    • Add pretty diff links.
  • Scripts/webkitpy/layout_tests/port/base.py:
    • Add support for generating pretty diffs using PrettyPatch.
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • We're leaking another file handle here, another FIXME.
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
    • Update write_output_files signature.
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
    • Remove unused arguments from write_output_files.
    • Add support for dumping pretty diffs to write_output_files.
    • Fix a bunch of file descriptor leaks in this file.
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
    • Update write_output_files signature.
Note: See TracTimeline for information about the timeline view.