⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 13, 2010:

11:36 PM Changeset in webkit [57567] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Rubber-stamped by Xan Lopez.

Skipping svg/custom/use-instanceRoot-as-event-target.xhtml
​https://bugs.webkit.org/show_bug.cgi?id=37544

Skipping plugins/setProperty.html
​https://bugs.webkit.org/show_bug.cgi?id=37545

Skipping media/audio-delete-while-slider-thumb-clicked.html
​https://bugs.webkit.org/show_bug.cgi?id=37546

Skipping media/video-currentTime-set2.html
​https://bugs.webkit.org/show_bug.cgi?id=37547

Skipping media/video-seekable.html
​https://bugs.webkit.org/show_bug.cgi?id=37548

Skipping media/video-currentTime-set.html
​https://bugs.webkit.org/show_bug.cgi?id=37549

Skipping fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html
​https://bugs.webkit.org/show_bug.cgi?id=37550

Skipping media/video-seeking.html
​https://bugs.webkit.org/show_bug.cgi?id=37551

Skipping media/video-timeupdate-reverse-play.html
​https://bugs.webkit.org/show_bug.cgi?id=37552

  • platform/gtk/Skipped:
11:22 PM Changeset in webkit [57566] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip xss-DENIED-iframe-src-alias.html on Windows

<​http://webkit.org/b/37096> tracks making this test not time out.

Reviewed by Eric Seidel.

  • platform/win/Skipped:
11:13 PM Changeset in webkit [57565] by Adam Roben
  • 2 edits in trunk/LayoutTests

Update Windows results for text-control-intrinsic-widths.html

<​http://webkit.org/b/37091> tracks deciding whether these results are
better than the previous ones or not.

Reviewed by Eric Seidel.

  • platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:
11:12 PM Changeset in webkit [57564] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r57511): many new graphics / svg related leaks
​https://bugs.webkit.org/show_bug.cgi?id=37527

The content of a HashMap was not correctly deleted. Fixed this
in the DTor and in invalidateClient of RenderSVGResourceClipper.

  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient):
11:12 PM Changeset in webkit [57563] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows failing results for mouse-drag-from-frame-to-other-frame.html

<​http://webkit.org/b/37494> tracks fixing this test.

Reviewed by Eric Seidel.

  • platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Added.
11:11 PM Changeset in webkit [57562] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows failing results for font-face-opentype.html

<​http://webkit.org/b/37089> tracks fixing this test.

Reviewed by Eric Seidel.

  • platform/win/fast/css/font-face-opentype-expected.txt: Added.
11:09 PM Changeset in webkit [57561] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Roben.

Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
​https://bugs.webkit.org/show_bug.cgi?id=33297

This is an experiment. The bots have been green for
a while. We'll see if adding them under sheriff-bot protection
will keep them green.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
10:56 PM Changeset in webkit [57560] by darin@chromium.org
  • 3 edits in trunk/LayoutTests

2010-04-13 Darin Fisher <​darin@chromium.org>

Update skipped lists for failing tests:
fast/loader/frame-src-change-not-added-to-history.html
fast/loader/frame-location-change-not-added-to-history.html

  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
10:29 PM Changeset in webkit [57559] by eric@webkit.org
  • 12 edits in trunk

2010-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Oliver Hunt.

Fix a potential integer overflow in WebGL*Array::slice()
​https://bugs.webkit.org/show_bug.cgi?id=37466

  • fast/canvas/webgl/array-unit-tests-expected.txt: Add tests that would cause overflow without this fix, but work fine with this fix.
  • fast/canvas/webgl/array-unit-tests.html: Ditto.

2010-04-13 Zhenyao Mo <​zmo@google.com>

Reviewed by Oliver Hunt.

Fix a potential integer overflow in WebGL*Array::slice()
​https://bugs.webkit.org/show_bug.cgi?id=37466

  • html/canvas/WebGLArray.h: (WebCore::WebGLArray::clampOffsetAndNumElements): Input parameter "offset"'s semantic changed from in bytes from buffer to in elements from array view; calculate offset in bytes from buffer inside the function, avoiding overflow.
  • html/canvas/WebGLByteArray.cpp: (WebCore::WebGLByteArray::slice): Changed according to new semantic of WebCore::WebGLArray::clampOffsetAndNumElements.
  • html/canvas/WebGLFloatArray.cpp: (WebCore::WebGLFloatArray::slice): Ditto.
  • html/canvas/WebGLIntArray.cpp: (WebCore::WebGLIntArray::slice): Ditto.
  • html/canvas/WebGLShortArray.cpp: (WebCore::WebGLShortArray::slice): Ditto.
  • html/canvas/WebGLUnsignedByteArray.cpp: (WebCore::WebGLUnsignedByteArray::slice): Ditto.
  • html/canvas/WebGLUnsignedIntArray.cpp: (WebCore::WebGLUnsignedIntArray::slice): Ditto.
  • html/canvas/WebGLUnsignedShortArray.cpp: (WebCore::WebGLUnsignedShortArray::slice): Ditto.
9:52 PM Changeset in webkit [57558] by darin@chromium.org
  • 6 edits
    4 adds in trunk

2010-04-13 Darin Fisher <​darin@chromium.org>

Reviewed by Brady Eidson.

If the browsing context's session history contains only one Document,
and that was the about:blank Document created when the browsing context
was created, then the navigation must be done with replacement enabled.

​https://bugs.webkit.org/show_bug.cgi?id=37126

Tests: fast/loader/frame-location-change-not-added-to-history.html

fast/loader/frame-src-change-not-added-to-history.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::findFrameForNavigation):
  • loader/HistoryController.cpp: (WebCore::HistoryController::currentItemShouldBeReplaced):
  • loader/HistoryController.h:
9:29 PM Changeset in webkit [57557] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing a constant in the Rietveld unit test.

  • Scripts/webkitpy/common/net/rietveld_unittest.py
9:12 PM Changeset in webkit [57556] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding missing Mock to fix python tests.

  • Scripts/webkitpy/tool/mocktool.py:
5:29 PM Changeset in webkit [57555] by ggaren@apple.com
  • 8 edits in trunk

Separated a DOMWrapperWorld's behavior of keeping wrappers alive from
its own lifetime, so a DOMWrapperWorld's controller can throw away
its wrappers even before its refcount reaches 0.

Reviewed by Oliver Hunt.

WebCore:

  • WebCore.base.exp:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::registerWorld):
(WebCore::DOMWrapperWorld::unregisterWorld):

  • bindings/js/DOMWrapperWorld.h: Factored out DOMWrapperWorld registration

and unregistration into helper functions, so unregistering could be done manually.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::destroyWindowShell): Added an ASSERT to match
similar code.

WebKit/mac:

  • WebView/WebScriptWorld.h:
  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld unregisterWorld]): Exported this function through WebKit.

5:28 PM Changeset in webkit [57554] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Update the test results after r57544.

  • http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers-expected.txt:
5:25 PM Changeset in webkit [57553] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping fast/js/kde/string-1-n.html,
See ​https://bugs.webkit.org/show_bug.cgi?id=37532

Skipping fast/js/kde/string-2-n.html.
​https://bugs.webkit.org/show_bug.cgi?id=37534

Skipping inspector/console-format.html
​https://bugs.webkit.org/show_bug.cgi?id=37535

Skipping media/video-reverse-play-duration.html
​https://bugs.webkit.org/show_bug.cgi?id=37536

Skipping plugins/round-trip-npobject.html
​https://bugs.webkit.org/show_bug.cgi?id=37537

Skipping svg/custom/use-on-clip-path-with-transformation.svg
​https://bugs.webkit.org/show_bug.cgi?id=37539

Skipping http/tests/security/xss-DENIED-mime-type-execute-as-html.html
​https://bugs.webkit.org/show_bug.cgi?id=37540

  • platform/gtk/Skipped:
5:23 PM Changeset in webkit [57552] by ojan@chromium.org
  • 11 edits
    1 copy
    2 adds in trunk/WebKitTools

2010-04-13 Ojan Vafai <​ojan@chromium.org>

Reviewed by David Levin.

Add experimental prototype Rietveld integration to webkit-patch upload
​https://bugs.webkit.org/show_bug.cgi?id=37418

This patch adds bare-bones integrtion with Rietveld for code reviews.
The behavior is hidden behind the --fancy-review command line flag.
Currently, there's no support for uploading more than one patch per
issue (which is a nice feature of Rietveld). The plan is to play with
this for a bit and see if it's useful.

Modified from Adam's original patch to autoinstall the rietveld upload script.

  • Scripts/webkitpy/common/config/init.py:
  • Scripts/webkitpy/common/net/rietveld.py: Added.
  • Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/postcodereview.py: Added.
  • Scripts/webkitpy/tool/steps/postdiff.py:
5:22 PM Changeset in webkit [57551] by weinig@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

Add Makefile to MiniBrowser.

Rubber-stamped by Mark Rowe.

  • MiniBrowser/Makefile: Added.
4:54 PM Changeset in webkit [57550] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Unreviewed, just adding a sanity check.

Add check to make sure commit-queue can never commit too short a message
​https://bugs.webkit.org/show_bug.cgi?id=37528

The commit-queue made bogus messages here:
​http://trac.webkit.org/changeset/57532
​http://trac.webkit.org/changeset/57534

This was a regression caused by adding unicode parsing for
our ChangeLog files. Popen does not seem to play nice with
unicode strings.

I'm also adding an "assert" to make sure short ChangeLogs never happen again.

  • Scripts/webkitpy/common/system/executive.py:
    • Cast input to strings before passing to POpen
  • Scripts/webkitpy/tool/steps/commit.py:
    • Validate that commit messages are not to short.
4:51 PM Changeset in webkit [57549] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Fix reported leaks when quitting MiniBrowser with open pages.

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.h: Make close() public.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::didClose): If the UIProcess disappears, close
the live pages in an effort to not leak.

  • WebProcess/WebProcess.h:
4:30 PM Changeset in webkit [57548] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Do a JS collection and clear the memory cache to improve leaks output
when exiting. Only do this in debug builds as it is slow.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shutdown):
(WebKit::WebProcess::didClose):

4:29 PM April 2010 Meeting edited by yuzo@google.com
(diff)
4:22 PM Changeset in webkit [57547] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Post a null event after calling [NSApp stop] to flush the run loop
and finish teardown.

Reviewed by Adele Peterson.

  • Platform/mac/RunLoopMac.mm:

(RunLoop::stop):

4:20 PM CommitterTips edited by yuzo@google.com
(diff)
4:19 PM Changeset in webkit [57546] by Adam Roben
  • 2 edits in trunk/WebKitTools

Robustify new-run-webkit-tests against paths with spaces in them

Reviewed by Eric Seidel.

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:

(LayoutTestApacheHttpd.init): Quote all paths that we pass to
Apache to ensure that paths with spaces in them are interpreted
correctly.

4:04 PM Changeset in webkit [57545] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix, update platform specific expected file after r57534.

  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
3:58 PM Changeset in webkit [57544] by chang.shu@nokia.com
  • 5 edits
    2 adds in trunk

2010-04-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=34653

Based on W3C spec and Firefox behavior, while invoking XHR Send with parameter
as String, the charset in Content-Type should be forced to set to UTF-8.

Test: http/tests/xmlhttprequest/request-encoding2.html

  • platform/network/HTTPParsers.cpp: (WebCore::extractCharsetFromMediaType): (WebCore::findCharsetInMediaType):
  • platform/network/HTTPParsers.h:
  • xml/XMLHttpRequest.cpp: (WebCore::setCharsetInMediaType): (WebCore::XMLHttpRequest::send):

2010-04-13 Chang Shu <​chang.shu@nokia.com>

Reviewed by Darin Fisher.

Added test for forcing UTF-8 charset.
​https://bugs.webkit.org/show_bug.cgi?id=34653

  • http/tests/xmlhttprequest/request-encoding2-expected.txt: Added.
  • http/tests/xmlhttprequest/request-encoding2.html: Added.
3:55 PM Changeset in webkit [57543] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping more new tests, we still do not have results. Remove test
that does not exist anymore:
svg/custom/clip-path-display-none-child.svg

  • platform/gtk/Skipped:
3:50 PM Changeset in webkit [57542] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Unreviewed buildfix after r57537.

  • DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3:44 PM Changeset in webkit [57541] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping fast/history/multiple-classes-visited.html test,
See ​https://bugs.webkit.org/show_bug.cgi?id=37526

  • platform/gtk/Skipped:
3:43 PM Changeset in webkit [57540] by weinig@apple.com
  • 3 edits
    1 copy in trunk/WebKitTools

Make building new webkit API and MiniBrowser a little easier.

Reviewed by Maciej Stachowiak.

  • Scripts/build-webkit: Make building with --webkit2 build the

MiniBrowser as well and tell you how to use it.

  • Scripts/run-minibrowser: Copied from Scripts/run-safari.
  • Scripts/webkitdirs.pm: Add runMiniBrowser function.
3:34 PM Changeset in webkit [57539] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r57530, because of
missing layoutTestController.evaluateScriptInIsolatedWorld()

  • platform/qt/Skipped:
    • storage/statement-error-callback-isolated-world.html skipped.
    • storage/statement-success-callback-isolated-world.html skipped.
    • storage/transaction-callback-isolated-world.html skipped.
    • storage/transaction-error-callback-isolated-world.html skipped.
3:31 PM Changeset in webkit [57538] by alex
  • 2 edits in trunk/LayoutTests

2010-04-13 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Xan Lopez.

Skipping new tests, we still do not have results.

  • platform/gtk/Skipped:
3:23 PM Changeset in webkit [57537] by timothy@apple.com
  • 24 edits
    2 adds in trunk

SecurityOrigin needs a way to remove individual OriginAccessEntries
​https://bugs.webkit.org/show_bug.cgi?id=37449

Reviewed by Dave Hyatt.

WebCore:

Test: http/tests/xmlhttprequest/origin-whitelisting-removal.html

  • WebCore.base.exp: Added SecurityOrigin::removeOriginAccessWhitelistEntry.
  • page/OriginAccessEntry.h:

(WebCore::OriginAccessEntry::protocol): Added. Returns m_protocol.
(WebCore::OriginAccessEntry::host): Added. Returns m_host.
(WebCore::OriginAccessEntry::subdomainSettings): Added. Returns m_subdomainSettings.
(WebCore::operator==): Added. Compares OriginAccessEntry.
(WebCore::operator!=): Ditto.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry): Use the add method to prevent a
second hash lookup.
(WebCore::SecurityOrigin::removeOriginAccessWhitelistEntry): Added. Find a matching
OriginAccessEntry and remove it.

  • page/SecurityOrigin.h: Added removeOriginAccessWhitelistEntry.

WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _removeOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
Call SecurityOrigin::removeOriginAccessWhitelistEntry.

  • WebView/WebViewPrivate.h: Added _removeOriginAccessWhitelistEntryWithSourceOrigin.

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.

  • WebView.h: Added removeOriginAccessWhitelistEntry.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
(LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::removeOriginAccessWhitelistEntry): Added.

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
(LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.

LayoutTests:

  • http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt: Added.
  • http/tests/xmlhttprequest/origin-whitelisting-removal.html: Added.
  • platform/gtk/Skipped: Added origin-whitelisting-removal.html.
  • platform/qt/Skipped: Ditto.
3:23 PM Changeset in webkit [57536] by timothy@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Make Joseph Pecoraro a reviewer.

3:15 PM Changeset in webkit [57535] by timothy@apple.com
  • 40 edits in trunk

Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.

SecurityOrigin needs a way to remove individual OriginAccessEntries
​https://bugs.webkit.org/show_bug.cgi?id=37449

Reviewed by Dave Hyatt.

WebCore:

  • WebCore.base.exp:
  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::addOriginAccessWhitelistEntry):
(WebCore::SecurityOrigin::resetOriginAccessWhitelists):

  • page/SecurityOrigin.h:

WebKit/chromium:

  • src/WebSecurityPolicy.cpp:

(WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
(WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):

WebKit/gtk:

  • webkit/webkitprivate.cpp:

(webkit_white_list_access_from_origin):
(webkit_reset_origin_access_white_lists):

WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _addOriginAccessWhitelistEntryWithSourceOrigin:destinationProtocol:destinationHost:allowDestinationSubdomains:]):
(+[WebView _resetOriginAccessWhitelists]):

  • WebView/WebViewPrivate.h:

WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):

WebKit/win:

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::addOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):

  • WebView.h:

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(addOriginAccessWhitelistEntryCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:

(LayoutTestController::addOriginAccessWhitelistEntry):

LayoutTests:

  • http/tests/security/local-image-from-remote-whitelisted-expected.txt:
  • http/tests/security/local-image-from-remote-whitelisted.html:
  • http/tests/xmlhttprequest/origin-whitelisting-all.html:
  • http/tests/xmlhttprequest/origin-whitelisting-exact-match.html:
  • http/tests/xmlhttprequest/origin-whitelisting-https.html:
  • http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains.html:
  • http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html:
  • http/tests/xmlhttprequest/origin-whitelisting-subdomains.html:
3:01 PM Changeset in webkit [57534] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2

2:59 PM Changeset in webkit [57533] by ggaren@apple.com
  • 6 edits in trunk/WebCore

Tidied up some more DOMWrapperWorld lifetime issues.

Reviewed by Mark Rowe.

Made DOMWrapperWorld aware of its JSDOMWindowShells, so it can clear them.

  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::~DOMWrapperWorld):

  • bindings/js/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::didCreateWindowShell):
(WebCore::DOMWrapperWorld::didDestroyWindowShell): Functionality for
tracking window shells that reference a given DOMWrapperWorld.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowShell):
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):

  • bindings/js/ScriptController.h: Refactored to update a DOMWrapperWorld

when adding or removing a JSDOMWindowShell.

  • dom/Document.cpp:

(WebCore::Document::destroyAllWrapperCaches): Changed to use isEmpty(),
which is slightly faster and simpler than iterator comparison.

2:51 PM Changeset in webkit [57532] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2

2:28 PM Changeset in webkit [57531] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-04-13 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

the commit-queue hates Tor Arne Vestbø
​https://bugs.webkit.org/show_bug.cgi?id=37511

We were failing to read reviewers out of ChangeLogs
when the reviewer has unicode characters in his/her name.
I fixed this by explicitly decoding from utf8 every time we
read in a ChangeLog file (they are always UTF8).

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
2:19 PM Changeset in webkit [57530] by dumi@chromium.org
  • 26 edits
    8 adds in trunk

WebCore: Make all HTML5 DB callbacks run in the correct context.
​https://bugs.webkit.org/show_bug.cgi?id=27698

Reviewed by Adam Barth.

Tests: storage/statement-error-callback-isolated-world.html

storage/statement-success-callback-isolated-world.html
storage/transaction-callback-isolated-world.html
storage/transaction-error-callback-isolated-world.html

  • bindings/js/JSCustomSQLStatementCallback.cpp:

(WebCore::JSCustomSQLStatementCallback::JSCustomSQLStatementCallback):
(WebCore::JSCustomSQLStatementCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:

(WebCore::JSCustomSQLStatementErrorCallback::JSCustomSQLStatementErrorCallback):
(WebCore::JSCustomSQLStatementErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:

(WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
(WebCore::JSCustomSQLTransactionCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:

(WebCore::JSCustomSQLTransactionErrorCallback::JSCustomSQLTransactionErrorCallback):
(WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):

  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:

(WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback):
(WebCore::V8CustomSQLStatementCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementCallback.h:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback):
(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:

(WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback):
(WebCore::V8CustomSQLTransactionCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLTransactionCallback.h:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:

(WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback):
(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):

  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
  • storage/SQLStatement.cpp:

(WebCore::SQLStatement::performCallback):

  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):

  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:

(WebCore::SQLTransactionErrorCallback::~SQLTransactionErrorCallback):

LayoutTests: Test that the HTML5 DB callbacks run in the correct context.
​https://bugs.webkit.org/show_bug.cgi?id=27698

Reviewed by Adam Barth.

  • storage/statement-error-callback-isolated-world-expected.txt: Added.
  • storage/statement-error-callback-isolated-world.html: Added.
  • storage/statement-success-callback-isolated-world-expected.txt: Added.
  • storage/statement-success-callback-isolated-world.html: Added.
  • storage/transaction-callback-isolated-world-expected.txt: Added.
  • storage/transaction-callback-isolated-world.html: Added.
  • storage/transaction-error-callback-isolated-world-expected.txt: Added.
  • storage/transaction-error-callback-isolated-world.html: Added.
1:14 PM BuildingQtOnLinux edited by robert@roberthogan.net
(diff)
1:13 PM BuildingQtOnLinux edited by robert@roberthogan.net
(diff)
12:14 PM Changeset in webkit [57529] by eric@webkit.org
  • 4 edits in trunk

2010-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix search behavior in Profiles tab.

​https://bugs.webkit.org/show_bug.cgi?id=37498

2010-04-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix search behavior in Heap profiles.

​https://bugs.webkit.org/show_bug.cgi?id=37498

  • src/js/HeapProfilerPanel.js:
11:58 AM Changeset in webkit [57528] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37513, clean up StyleBoxData and the RenderStyle variable that uses it.

Reviewed by Oliver Hunt.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::width):
(WebCore::InheritedFlags::height):
(WebCore::InheritedFlags::minWidth):
(WebCore::InheritedFlags::maxWidth):
(WebCore::InheritedFlags::minHeight):
(WebCore::InheritedFlags::maxHeight):
(WebCore::InheritedFlags::verticalAlignLength):
(WebCore::InheritedFlags::boxSizing):
(WebCore::InheritedFlags::setWidth):
(WebCore::InheritedFlags::setHeight):
(WebCore::InheritedFlags::setMinWidth):
(WebCore::InheritedFlags::setMaxWidth):
(WebCore::InheritedFlags::setMinHeight):
(WebCore::InheritedFlags::setMaxHeight):
(WebCore::InheritedFlags::setVerticalAlignLength):
(WebCore::InheritedFlags::hasAutoZIndex):
(WebCore::InheritedFlags::setHasAutoZIndex):
(WebCore::InheritedFlags::zIndex):
(WebCore::InheritedFlags::setZIndex):
(WebCore::InheritedFlags::setBoxSizing):

  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

  • rendering/style/StyleBoxData.h:

(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):
(WebCore::StyleBoxData::zIndex):
(WebCore::StyleBoxData::hasAutoZIndex):
(WebCore::StyleBoxData::boxSizing):

11:28 AM WikiStart edited by ddkilzer@webkit.org
(diff)
11:17 AM Changeset in webkit [57527] by yael.aharon@nokia.com
  • 4 edits in trunk/WebCore

Minor fix to pass RenderProgress instead of RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=37481

Reviewed by Tor Arne Vestbo.

  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityProgressIndicator.cpp:
  • accessibility/AccessibilityProgressIndicator.h:
11:10 AM Changeset in webkit [57526] by hyatt@apple.com
  • 4 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37510, clean up StyleBackgroundData

Reviewed by Oliver Hunt.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::operator==):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::hasBackground):
(WebCore::InheritedFlags::hasBackgroundImage):
(WebCore::InheritedFlags::hasFixedBackgroundImage):
(WebCore::InheritedFlags::outlineWidth):
(WebCore::InheritedFlags::outlineStyle):
(WebCore::InheritedFlags::outlineStyleIsAuto):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::backgroundImage):
(WebCore::InheritedFlags::backgroundRepeatX):
(WebCore::InheritedFlags::backgroundRepeatY):
(WebCore::InheritedFlags::backgroundComposite):
(WebCore::InheritedFlags::backgroundAttachment):
(WebCore::InheritedFlags::backgroundClip):
(WebCore::InheritedFlags::backgroundOrigin):
(WebCore::InheritedFlags::backgroundXPosition):
(WebCore::InheritedFlags::backgroundYPosition):
(WebCore::InheritedFlags::backgroundSizeType):
(WebCore::InheritedFlags::backgroundSizeLength):
(WebCore::InheritedFlags::accessBackgroundLayers):
(WebCore::InheritedFlags::backgroundLayers):
(WebCore::InheritedFlags::outlineOffset):
(WebCore::InheritedFlags::resetOutline):
(WebCore::InheritedFlags::setBackgroundColor):
(WebCore::InheritedFlags::setBackgroundXPosition):
(WebCore::InheritedFlags::setBackgroundYPosition):
(WebCore::InheritedFlags::setBackgroundSize):
(WebCore::InheritedFlags::setBackgroundSizeLength):
(WebCore::InheritedFlags::setOutlineWidth):
(WebCore::InheritedFlags::setOutlineStyle):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::clearBackgroundLayers):
(WebCore::InheritedFlags::inheritBackgroundLayers):
(WebCore::InheritedFlags::setOutlineOffset):

  • rendering/style/StyleBackgroundData.h:

(WebCore::StyleBackgroundData::background):
(WebCore::StyleBackgroundData::color):
(WebCore::StyleBackgroundData::outline):

11:04 AM Changeset in webkit [57525] by Adam Roben
  • 2 edits in trunk/WebKitTools

Revert r57523

11:00 AM Changeset in webkit [57524] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-webkit-tests on Windows with spaces in the path

Fixes <​http://webkit.org/b/37509>.

Reviewed by Steve Falkenburg.

  • Scripts/run-webkit-tests:

(convertPathUsingCygpath): Remove spaces from the path before passing
them to cygpath, then add them back in after conversion, as some
versions of cygpath seem to convert spaces into newlines.

10:59 AM Changeset in webkit [57523] by Adam Roben
  • 2 edits in trunk/WebKitTools

Revert "run-webkit-tests should respect argument order"

This reverts commit adc7db320e18d5a866dbf63a2ed7192471c86c85.

10:46 AM Changeset in webkit [57522] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Use the system clipboard instead of a private clipboard.

Fix various problems in the previous implementation.

​https://bugs.webkit.org/show_bug.cgi?id=37421

No new tests needed.

  • platform/haiku/PasteboardHaiku.cpp: (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::generalPasteboard):
    • Don't leak the pasteboard at program exit.

(WebCore::AutoClipboardLocker::AutoClipboardLocker):
(WebCore::AutoClipboardLocker::~AutoClipboardLocker):
(WebCore::AutoClipboardLocker::isLocked):

  • helper class for locking a BClipboard.

(WebCore::Pasteboard::writeSelection):

  • Use AddData(B_MIME_TYPE) as required by clipboard protocol.
  • Make sure we don't end up with unwanted UTF-8 characters for regular line breaks.

(WebCore::Pasteboard::writePlainText):

  • Use AddData(B_MIME_TYPE) as required by clipboard protocol.

(WebCore::Pasteboard::plainText):

  • Use FindData(B_MIME_TYPE) as required by clipboard protocol.

(WebCore::Pasteboard::documentFragment):

  • Implemented.

(WebCore::Pasteboard::writeURL):

  • Needs to use AddData(B_MIME_TYPE) instead of AddString().

(WebCore::Pasteboard::clear):

10:20 AM Changeset in webkit [57521] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Fix bridging Widget to native top-level BView.
​https://bugs.webkit.org/show_bug.cgi?id=37419

In the Haiku port, there is no mapping between native widgets
and WebCore Widget instances. There is only a top-level BView
which renders a web page into a bitmap. For certain WebCore widget
functionality, we need to access this BView, like for setting the
current cursor or forcing focus. On the other hand, setting a
platform widget pointer on Widget results into completely different
behavior, like ScrollView tries to forward everything instead of
handling stuff itself. To make this work, the pointer to a "top-level"
BView is stored in every Widget for the Haiku port.

No new tests needed.

  • platform/Widget.h:
    • Added the m_topLevelPlatformWidget member for the Haiku platform.

(WebCore::Widget::setPlatformWidget):
(WebCore::Widget::topLevelPlatformWidget):
(WebCore::Widget::setTopLevelPlatformWidget):

  • platform/haiku/WidgetHaiku.cpp: (WebCore::AutoPlatformWidgetLocker::AutoPlatformWidgetLocker): (WebCore::AutoPlatformWidgetLocker::~AutoPlatformWidgetLocker): (WebCore::AutoPlatformWidgetLocker::isLocked):
    • helper class for locking the BView looper thread with a timeout

(WebCore::Widget::Widget):
(WebCore::Widget::setFocus):

  • Make sure the top-level view receives keyboard input.

(WebCore::Widget::setCursor):

  • Set the cursor on the top-level view.

(WebCore::Widget::show):
(WebCore::Widget::hide):

  • Don't show/hide the top-level view, but make the code correct for whenever we would map an individual BView per Widget.
  • Use setSelfVisible() and isParentVisible() like in other ports.
10:08 AM Changeset in webkit [57520] by eric@webkit.org
  • 4 edits in trunk

2010-04-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Levin.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

​https://bugs.webkit.org/show_bug.cgi?id=36426

No new tests as there is no new functionality.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.

2010-04-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by David Levin.

Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

​https://bugs.webkit.org/show_bug.cgi?id=36426

  • src/ResourceHandle.cpp: Track state across ResourceHandle invocations. (WebCore::ResourceHandleInternal::ResourceHandleInternal): (WebCore::ResourceHandleInternal::): (WebCore::ResourceHandleInternal::start): (WebCore::ResourceHandleInternal::cancel): (WebCore::ResourceHandleInternal::didReceiveResponse): (WebCore::ResourceHandleInternal::didReceiveData): (WebCore::ResourceHandleInternal::didFinishLoading): (WebCore::ResourceHandleInternal::didFail):
9:49 AM Changeset in webkit [57519] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Abhishek Arya <​inferno@chromium.org>

Reviewed by Adam Barth.

Add a null ptr check for m_popupClient.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::abandon): Add a null ptr check
9:42 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:56 AM Changeset in webkit [57518] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-04-13 William Siegrist <​wsiegrist@apple.com>

Add a temporary bot to test new-run-webkit-tests

8:52 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:51 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:45 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:44 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:41 AM Mobile Features Talk edited by treat@kde.org
(diff)
8:41 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
8:38 AM Mobile Features Talk created by treat@kde.org
8:36 AM April 2010 Meeting edited by treat@kde.org
(diff)
8:31 AM Changeset in webkit [57517] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Use the system's default font family as last fall back font.
​https://bugs.webkit.org/show_bug.cgi?id=37501

No new tests needed.

  • platform/graphics/haiku/FontCacheHaiku.cpp: (WebCore::FontCache::getLastResortFallbackFont):
    • Use the system's default font family (from be_plain_font global).
8:21 AM Changeset in webkit [57516] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Eskil Blomfeldt <​eblomfel@trolltech.com>, Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Use integer pixel metric QFont API to fix rounding errors in text rendering on the Mac
​https://bugs.webkit.org/show_bug.cgi?id=36532

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::floatWidthForComplexText): (WebCore::Font::font):
8:11 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:54 AM Changeset in webkit [57515] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix, platform specific expected file updated after r57511.

  • platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.txt: updated.
7:50 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
7:36 AM Changeset in webkit [57514] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Cannot effectively delete properties in the Styles sidebar pane
​https://bugs.webkit.org/show_bug.cgi?id=37499

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::applyStyleText):
7:17 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:49 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
6:45 AM Changeset in webkit [57513] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

Use the Haiku MIME type data base as a fall back for unknown file extensions.
​https://bugs.webkit.org/show_bug.cgi?id=34686

Covered by existing tests.

  • platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::):
    • fixed coding style issues

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):

  • fall back to the system MIME database for unknown types.
  • return empty String as last resort, this is used elsewhere as indicator for unknown types.
6:36 AM Changeset in webkit [57512] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-04-13 Stephan Aßmus <​superstippi@gmx.de>

Reviewed by David Levin.

[Haiku] Use all the new system cursors available in recent Haiku revisions.
<​https://bugs.webkit.org/show_bug.cgi?id=37385>

Covered by existing tests.

  • platform/haiku/CursorHaiku.cpp: (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=):
    • Adapted to maintain an owned BCursor instance.

(WebCore::createCursorByID):

  • helper function to create a Cursor instance by BCursorID constant.

(WebCore::pointerCursor):

  • NULL BCursor triggers using the system cursor.

(WebCore::moveCursor):
(WebCore::crossCursor):
(WebCore::handCursor):
(WebCore::iBeamCursor):
(WebCore::waitCursor):
(WebCore::helpCursor):
(WebCore::eastResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northEastResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::westResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::columnResizeCursor):
(WebCore::rowResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::cellCursor):
(WebCore::contextMenuCursor):
(WebCore::noDropCursor):
(WebCore::copyCursor):
(WebCore::progressCursor):
(WebCore::aliasCursor):
(WebCore::noneCursor):
(WebCore::notAllowedCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::grabCursor):
(WebCore::grabbingCursor):

  • Use the new system cursors.
5:45 AM Changeset in webkit [57511] by krit@webkit.org
  • 28 edits
    130 adds
    1 delete in trunk

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

<clipPath> doesn't correctly handle <text> elements
​https://bugs.webkit.org/show_bug.cgi?id=12571

Adds support for text elements as clipPath, heterogenous clip rules, as well
as clipping of clipPath.
A fast code path let platforms clip simple shapes directly. All other variants
are drawn to a seperate ImageBuffer, which is used as a mask. This happens the same
way we like we do it on SVG Masking. This needs temporary changes to the RenderStyle
of clipPath childs. Values like stroke, resources, opacity have to be ignored.

Tests: svg/clip-path/clip-path-child-clipped.svg

svg/clip-path/clip-path-childs-clipped.svg
svg/clip-path/clip-path-clipped-evenodd-twice.svg
svg/clip-path/clip-path-clipped-no-content.svg
svg/clip-path/clip-path-clipped-nonzero.svg
svg/clip-path/clip-path-clipped.svg
svg/clip-path/clip-path-evenodd-nonzero.svg
svg/clip-path/clip-path-evenodd.svg
svg/clip-path/clip-path-nonzero-evenodd.svg
svg/clip-path/clip-path-nonzero.svg
svg/clip-path/clip-path-objectBoundingBox.svg
svg/clip-path/clip-path-on-clipped-use.svg
svg/clip-path/clip-path-on-g-and-child.svg
svg/clip-path/clip-path-on-g.svg
svg/clip-path/clip-path-on-svg-and-child.svg
svg/clip-path/clip-path-on-svg.svg
svg/clip-path/clip-path-recursive-call-by-child.svg
svg/clip-path/clip-path-recursive-call.svg
svg/clip-path/clip-path-text-and-shape.svg
svg/clip-path/clip-path-text-and-stroke.svg
svg/clip-path/clip-path-text.svg
svg/clip-path/clip-path-use-as-child.svg
svg/clip-path/clip-path-use-as-child2.svg
svg/clip-path/clip-path-use-as-child3.svg
svg/clip-path/clip-path-use-as-child4.svg
svg/clip-path/clip-path-use-as-child5.svg
svg/clip-path/clip-path-userSpaceOnUse.svg
svg/clip-path/clip-path-with-container.svg
svg/clip-path/clip-path-with-different-unittypes.svg
svg/clip-path/clip-path-with-different-unittypes2.svg
svg/clip-path/clip-path-with-invisibile-child.svg
svg/clip-path/clip-path-with-text-clipped.svg

  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGShadowTreeRootContainer): identify use-element renderer
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients): (WebCore::RenderSVGResourceClipper::invalidateClient): (WebCore::RenderSVGResourceClipper::applyResource): (WebCore::RenderSVGResourceClipper::pathOnlyClipping): direct clipping for simple shapes (WebCore::RenderSVGResourceClipper::applyClippingToContext): direct clipping or maskImage? (WebCore::RenderSVGResourceClipper::createClipData): creates maskImage for clipping (WebCore::RenderSVGResourceClipper::resourceBoundingBox):
  • rendering/RenderSVGResourceClipper.h:
  • rendering/RenderSVGShadowTreeRootContainer.h: identify use-Element by renderer (WebCore::RenderSVGShadowTreeRootContainer::isSVGShadowTreeRootContainer):
  • rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): hack to get texts working on clipping (masks and pattern)
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::rendererClipChild): get renderer of referenced object
  • svg/SVGUseElement.h:

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

<clipPath> doesn't correctly handle <text> elements
​https://bugs.webkit.org/show_bug.cgi?id=12571

33 new Tests for SVG's clip-path. Test behavior of different clip objects
like text as well as different clip rules.
Other older tests are rendered correctly now.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.checksum:
  • platform/mac/svg/batik/text/textEffect2-expected.png:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textProperties-expected.checksum:
  • platform/mac/svg/batik/text/textProperties-expected.png:
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/clip-path: Added.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-text-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-text-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-text-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Added.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.checksum: Added.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
  • platform/mac/svg/custom/clip-path-child-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-href-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-units-changes-expected.txt:
  • platform/mac/svg/custom/clip-path-with-transform-expected.txt:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt:
  • platform/mac/svg/filters/filterRes-expected.checksum:
  • svg/clip-path: Added.
  • svg/clip-path/clip-path-child-clipped.svg: Added.
  • svg/clip-path/clip-path-childs-clipped.svg: Added.
  • svg/clip-path/clip-path-clipped-evenodd-twice.svg: Added.
  • svg/clip-path/clip-path-clipped-no-content.svg: Added.
  • svg/clip-path/clip-path-clipped-nonzero.svg: Added.
  • svg/clip-path/clip-path-clipped.svg: Added.
  • svg/clip-path/clip-path-evenodd-nonzero.svg: Added.
  • svg/clip-path/clip-path-evenodd.svg: Added.
  • svg/clip-path/clip-path-nonzero-evenodd.svg: Added.
  • svg/clip-path/clip-path-nonzero.svg: Added.
  • svg/clip-path/clip-path-objectBoundingBox.svg: Added.
  • svg/clip-path/clip-path-on-clipped-use.svg: Added.
  • svg/clip-path/clip-path-on-g-and-child.svg: Added.
  • svg/clip-path/clip-path-on-g.svg: Added.
  • svg/clip-path/clip-path-on-svg-and-child.svg: Added.
  • svg/clip-path/clip-path-on-svg.svg: Added.
  • svg/clip-path/clip-path-recursive-call-by-child.svg: Added.
  • svg/clip-path/clip-path-recursive-call.svg: Added.
  • svg/clip-path/clip-path-text-and-shape.svg: Added.
  • svg/clip-path/clip-path-text-and-stroke.svg: Added.
  • svg/clip-path/clip-path-text.svg: Added.
  • svg/clip-path/clip-path-use-as-child.svg: Added.
  • svg/clip-path/clip-path-use-as-child2.svg: Added.
  • svg/clip-path/clip-path-use-as-child3.svg: Added.
  • svg/clip-path/clip-path-use-as-child4.svg: Added.
  • svg/clip-path/clip-path-use-as-child5.svg: Added.
  • svg/clip-path/clip-path-userSpaceOnUse.svg: Added.
  • svg/clip-path/clip-path-with-container.svg: Added.
  • svg/clip-path/clip-path-with-different-unittypes.svg: Added.
  • svg/clip-path/clip-path-with-different-unittypes2.svg: Added.
  • svg/clip-path/clip-path-with-invisibile-child.svg: Added.
  • svg/clip-path/clip-path-with-text-clipped.svg: Added.
  • svg/custom/clip-path-display-none-child.svg: Removed.
5:25 AM QtWebKitFeaturePlanning edited by Henry Haverinen
(diff)
4:39 AM Changeset in webkit [57510] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Checksum of svg/filters/filterRes.svg was not updated properly after rebasing.
It's only visible when using "run-webkit-tests --tolerance 0 -p svg"

  • platform/mac/svg/filters/filterRes-expected.checksum:
3:48 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
3:35 AM Changeset in webkit [57509] by Nikolas Zimmermann
  • 28 edits in trunk/WebCore

2010-04-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG renderers should track transform/path changes, instead of pulling every time from SVG DOM
​https://bugs.webkit.org/show_bug.cgi?id=15389

RenderPath caches repaint rectangles (fill/stroke bbox etc.) though this caching
was effectively useless because every layout() call caused them to be reset to empty rects.
Furthermore RenderPath::layout() queried the SVG DOM upon every invocation to retrieve
the Path object, instead of only doing it when necessary. Even the TransformationMatrix
was polled everytime from the SVG DOM.

Move the knownledge wheter we need to update path/transform into the render tree and
only update when necessary. This should result in a huge performance increase, with
the drawback of adding slightly more memory, because we need to add booleans indicating
the status of path/transform (is dirty?).

Doesn't affect any tests, only performance.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::layout):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::setNeedsTransformUpdate):
  • rendering/RenderObject.h: (WebCore::RenderObject::setNeedsTransformUpdate): (WebCore::RenderObject::setNeedsBoundariesUpdate):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): (WebCore::RenderPath::layout): (WebCore::RenderPath::invalidateCachedBoundaries): (WebCore::RenderPath::styleWillChange):
  • rendering/RenderPath.h: (WebCore::RenderPath::setNeedsBoundariesUpdate): (WebCore::RenderPath::setNeedsPathUpdate): (WebCore::RenderPath::setNeedsTransformUpdate): (WebCore::RenderPath::localToParentTransform): (WebCore::RenderPath::localTransform):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::setNeedsTransformUpdate):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::invalidateClients):
  • rendering/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::invalidateClients):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::invalidateClients):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::layout):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::setNeedsTransformUpdate):
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer): (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
  • rendering/RenderSVGTransformableContainer.h: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::setNeedsTransformUpdate): (WebCore::RenderSVGTransformableContainer::localTransform):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::calculateAnimatedValue): (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::svgAttributeChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):
2:34 AM QtWebKitTableOfFeatures20 edited by Henry Haverinen
(diff)
12:49 AM Changeset in webkit [57508] by mnaganov@chromium.org
  • 4 edits in trunk

Unreviewed build fixes for Qt and Chromium ports.

Unreviewed Qt build fix: add new .idl files to WebCore.pri

  • WebCore.pri:

Unreviewed Chromium build fix: pin to a newer V8 revision (4386).

  • DEPS:
12:48 AM Changeset in webkit [57507] by abarth@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-04-13 Adam Barth <​abarth@webkit.org>

Unreviewed, but approved by Dumitru Daniliuc. (This patch is intended
to fix the downstream Chromium build bots. Hopefully it will work!)

Add a driver script for the new websocket server
​https://bugs.webkit.org/show_bug.cgi?id=37495

websocket_server.py can't be run directly because its a module and not
a standalone script. This used to work by accident because it didn't
depend on any other modules.

  • Scripts/new-run-webkit-websocketserver: Added.
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
12:38 AM Changeset in webkit [57506] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, adding another fast/url/ test to Chromium's
test_expectations.txt.

  • platform/chromium/test_expectations.txt:
12:22 AM Changeset in webkit [57505] by mnaganov@chromium.org
  • 23 edits
    7 copies
    2 moves
    1 add
    2 deletes in trunk

2010-04-12 Mikhail Naganov <​mnaganov@chromium.org>

Replace hand-written JavaScriptProfile* bindings with idl-based, and
in Chromium port, bind them to the new V8's profiler API that is
aligned with JSC.

​https://bugs.webkit.org/show_bug.cgi?id=37448

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/JSScriptProfileNodeCustom.cpp: Added. (WebCore::JSScriptProfileNode::callUID): (WebCore::JSScriptProfileNode::children):
  • bindings/js/JavaScriptProfile.cpp: Removed.
  • bindings/js/JavaScriptProfile.h: Removed.
  • bindings/js/JavaScriptProfileNode.cpp: Removed.
  • bindings/js/JavaScriptProfileNode.h: Removed.
  • bindings/js/ScriptProfileNode.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScriptProfile.cpp: Added. (WebCore::ScriptProfile::title): (WebCore::ScriptProfile::uid): (WebCore::ScriptProfile::head):
  • bindings/v8/ScriptProfile.h: (WebCore::ScriptProfile::create): (WebCore::ScriptProfile::ScriptProfile):
  • bindings/v8/ScriptProfileNode.cpp: Added. (WebCore::ScriptProfileNode::functionName): (WebCore::ScriptProfileNode::url): (WebCore::ScriptProfileNode::lineNumber): (WebCore::ScriptProfileNode::totalTime): (WebCore::ScriptProfileNode::selfTime): (WebCore::ScriptProfileNode::numberOfCalls): (WebCore::ScriptProfileNode::children): (WebCore::ScriptProfileNode::visible): (WebCore::ScriptProfileNode::callUID):
  • bindings/v8/ScriptProfileNode.h: Added. (WebCore::ScriptProfileNode::create): (WebCore::ScriptProfileNode::~ScriptProfileNode): (WebCore::ScriptProfileNode::ScriptProfileNode):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::start): (WebCore::ScriptProfiler::stop):
  • bindings/v8/custom/V8ConsoleCustom.cpp: Added. (WebCore::V8Console::profilesAccessorGetter):
  • bindings/v8/custom/V8ScriptProfileCustom.cpp: Added. (WebCore::toV8):
  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Added. (WebCore::V8ScriptProfileNode::childrenAccessorGetter): (WebCore::V8ScriptProfileNode::callUIDAccessorGetter): (WebCore::toV8):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getProfile):
  • inspector/ScriptProfile.idl: Added.
  • inspector/ScriptProfileNode.idl: Added.
  • inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.getProfile):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.populateInterface): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
  • page/Console.idl:
  • platform/android/TemporaryLinkStubs.cpp:
  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
  • src/js/ProfilerAgent.js: (devtools.ProfilerAgent): (devtools.ProfilerAgent.prototype.initializeProfiling): (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules): (devtools.ProfilerAgent.prototype._didGetLogLines):
  • src/js/Tests.js:
12:01 AM Changeset in webkit [57504] by dbates@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-04-13 Daniel Bates <​dbates@rim.com>

Unreviewed, fix bug url mentioned in the change log
for change set 57502 <​http://trac.webkit.org/changeset/57502>.

Inadvertently listed the bug url to be <​https://bugs.webkit.org/show_bug.cgi?id=37480>.
Instead, it should be <​https://bugs.webkit.org/show_bug.cgi?id=37490>.

Apr 12, 2010:

11:42 PM Changeset in webkit [57503] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Finish IPv4 URL parsing test
​https://bugs.webkit.org/show_bug.cgi?id=37493

I rushed the first version of this test because I wanted to get the
framework in the tree for other folks to work on the other tests. The
expected.txt file matches KURL but the PASS/FAIL indiciations match
GURL.

  • fast/url/ipv4-expected.txt:
  • fast/url/script-tests/ipv4.js:
11:09 PM Changeset in webkit [57502] by eric@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-04-12 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37480

Implements the anchor tests from <​http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1102>.

  • fast/url/anchor-expected.txt: Added.
  • fast/url/anchor.html: Added.
  • fast/url/script-tests/anchor.js: Added.
9:52 PM Changeset in webkit [57501] by eric@webkit.org
  • 4 edits
    1 copy
    4 adds in trunk/LayoutTests

2010-04-12 Daniel Bates <​dbates@rim.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=37480

Implements all of the non-encoding specific query string tests from
<​http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>.

Also, moved JavaScript function canonicalize to external JavaScript
script /resources/utilities.js since this function is being called
by tests ipv4.html, query.html, and trivial.html.

  • fast/url/ipv4.html:
  • fast/url/query-expected.txt: Added.
  • fast/url/query.html: Added.
  • fast/url/resources: Added.
  • fast/url/resources/utilities.js: Added. (canonicalize):
  • fast/url/script-tests/TEMPLATE.html: Include external JavaScript script resources/utilities.js.
  • fast/url/script-tests/query.js: Added.
  • fast/url/trivial.html:
9:38 PM Changeset in webkit [57500] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make new-run-webkit-test PrettyPatch failure reporting more awesome
​https://bugs.webkit.org/show_bug.cgi?id=37487

I also fixed an Executive/executive typo.

  • Scripts/webkitpy/layout_tests/port/base.py:
9:00 PM Changeset in webkit [57499] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests should only build java support files on Mac
​https://bugs.webkit.org/show_bug.cgi?id=37482

Only the mac needs java support files, so I pushed _build_java
down into the Mac port using a new hook "_check_port_build".
In the process I noticed a bunch of code which could be shared
between all ports and thus got rid of _tests_for_disabled_features
and version() copy/paste between all webkit ports.
I also made check_build only bother to check for ImageDiff if we're
using pixel tests.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
8:00 PM Changeset in webkit [57498] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping two tests on Chromium because they fail.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [57497] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed, trying to make scripts work on machines without
Ruby...

  • Scripts/webkitpy/layout_tests/port/base.py:
7:29 PM Changeset in webkit [57496] by tonikitoo@webkit.org
  • 3 edits
    2 adds in trunk

Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
​https://bugs.webkit.org/show_bug.cgi?id=37461

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

getRect() of Element can be used instead of absoluteClippedOverflowRect of RenderObject when
the node is currently offscreen in an scroll overflowed content.

Test: fast/events/spatial-navigation/snav-simple-content-overflow.html

  • page/SpatialNavigation.cpp:

(WebCore::renderRectRelativeToRootDocument):

LayoutTests:

  • fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt: Added.
  • fast/events/spatial-navigation/snav-simple-content-overflow.html: Added.
7:28 PM Changeset in webkit [57495] by tonikitoo@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed style fix.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfCloser):

7:13 PM Changeset in webkit [57494] by yael.aharon@nokia.com
  • 10 edits
    4 adds in trunk

Accessibility support for progress element
​https://bugs.webkit.org/show_bug.cgi?id=37275

Reviewed by Darin Adler.

WebCore:

Implement AccessibilityProgressIndicator to hook up progress element to accessibility framework.

Test: platform/mac/accessibility/progressbar.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:
  • accessibility/AccessibilityProgressIndicator.cpp: Added.
  • accessibility/AccessibilityProgressIndicator.h: Added.
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:

LayoutTests:

  • platform/mac/accessibility/progressbar-expected.txt: Added.
  • platform/mac/accessibility/progressbar.html: Added.
7:07 PM Changeset in webkit [57493] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test that started failing with r57492.

  • storage/open-database-over-quota.html:
6:04 PM Changeset in webkit [57492] by dumi@chromium.org
  • 3 edits in trunk/WebCore

Throwing a SECURITY_ERR when openDatabase() cannot open a database
for whatever reason, as required by the spec.
​https://bugs.webkit.org/show_bug.cgi?id=33916

Reviewed by Dimitri Glazkov.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

5:59 PM Changeset in webkit [57491] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-12 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Add stub files for running new-run-webkit-tests for the Qt port

  • platform/qt/test_expectations.txt: Added.

2010-04-12 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

Add stub files for running new-run-webkit-tests for the Qt port

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/qt.py: Added.
5:47 PM Changeset in webkit [57490] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2010-04-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Dan Bernstein.

WebKit should have more robust last-chance font fallback on Windows
​https://bugs.webkit.org/show_bug.cgi?id=37473
<rdar://problem/7789438> Crash in FontFallbackList::determinePitch
<rdar://problem/7233762> Crash in FontFallbackList::fontDataAt


Look harder for a suitable last-resort font. Previously, we checked for
"Times New Roman" followed by DEFAULT_GUI_FONT.


We now look for:

  • Typically installed Unicode-capable fonts, in order of coverage
  • DEFAULT_GUI_FONT
  • SPI_GETNONCLIENTMETRICS fonts


  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::fontDataFromDescriptionAndLogFont): (WebCore::FontCache::getLastResortFallbackFont):
5:11 PM Changeset in webkit [57489] by abarth@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Jeremy Orlow.

Add some ip4v tests (will revise in a minute)
​https://bugs.webkit.org/show_bug.cgi?id=37476

  • fast/url/ipv4-expected.txt: Added.
  • fast/url/ipv4.html: Added.
  • fast/url/script-tests/ipv4.js: Added.
  • fast/url/script-tests/trivial.js: (canonicalize):
  • fast/url/trivial-expected.txt:
4:42 PM Changeset in webkit [57488] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2010-04-12 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Add a trivial test for URL parsing
​https://bugs.webkit.org/show_bug.cgi?id=37475

Hopefully this will be the starting point for many URL tests.

  • fast/url/script-tests/TEMPLATE.html: Added.
  • fast/url/script-tests/trivial.js: Added. (canonicalize):
  • fast/url/trivial-expected.txt: Added.
  • fast/url/trivial.html: Added.
4:20 PM Changeset in webkit [57487] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add #ifdef so that WKView is not included on the mac if not
compiling objective-c.

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WebKit2.h:
4:15 PM Changeset in webkit [57486] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-04-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

Modify run_webkit_tests.py to not call sys.exit() at the end of test
run; doing so makes it more difficult to embed the routine for,
among other things, unit tests. We push the exit calling up into
new-run-webkit-tests.

​https://bugs.webkit.org/show_bug.cgi?id=37464

  • Scripts/new-run-webkit-tests:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:10 PM Changeset in webkit [57485] by andersca@apple.com
  • 1 edit
    1 add in trunk/WebKit2

Add WebKit2 solution file.

Reviewed by Adam Roben.

  • WebKit2.sln: Added.
4:10 PM QtWebKitGraphics edited by Simon Fraser
(diff)
4:10 PM QtWebKitGraphics edited by Simon Fraser
(diff)
3:14 PM Changeset in webkit [57484] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/style/RenderStyle.cpp

Fix debug build bustage.

3:10 PM ReviewTool edited by maruel@chromium.org
(diff)
2:55 PM Changeset in webkit [57483] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-04-12 Eric Seidel <​eric@webkit.org>

Unreviewed.

Add stub Gtk implementation for new-run-webkit-tests.

  • platform/gtk/test_expectations.txt: Copied from LayoutTests/animations/resources/dynamic-stylesheet-insertion-inserted.css.

2010-04-12 Eric Seidel <​eric@webkit.org>

Unreviewed.

Add stub Gtk implementation for new-run-webkit-tests.

  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py: Added.
2:53 PM Changeset in webkit [57482] by hyatt@apple.com
  • 18 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37469, clean up ShadowData to be encapsulated properly.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForShadow):

  • page/animation/AnimationBase.cpp:

(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperShadow::blend):

  • page/mac/FrameMac.mm:

(WebCore::Frame::fontAttributesForSelectionStart):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesHorizontally):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineTextBox.cpp:

(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/InlineTextBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateRects):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustRectForOutlineAndShadow):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintCharacters):

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):
(WebCore::RenderStyle::getBoxShadowExtent):
(WebCore::RenderStyle::getBoxShadowHorizontalExtent):
(WebCore::RenderStyle::getBoxShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::textShadow):
(WebCore::InheritedFlags::boxShadow):

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::getSVGShadowExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::~ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::blur):
(WebCore::ShadowData::spread):
(WebCore::ShadowData::style):
(WebCore::ShadowData::color):
(WebCore::ShadowData::next):
(WebCore::ShadowData::setNext):

2:53 PM April 2010 Meeting edited by maruel@chromium.org
(diff)
2:50 PM ReviewTool edited by maruel@chromium.org
(diff)
2:48 PM ReviewTool created by maruel@chromium.org
1:51 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:49 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:48 PM Accelerated Compositing edited by Simon Fraser
(diff)
1:47 PM Changeset in webkit [57481] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] LayoutTests/platform/gtk/Skipped clean up
​https://bugs.webkit.org/show_bug.cgi?id=37465

Reviewed by Gustavo Noronha.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

  • platform/gtk/Skipped: Clean up needed after r57289 and r57292.
1:47 PM Accelerated Compositing edited by Simon Fraser
(diff)
1:45 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:42 PM Changeset in webkit [57480] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-04-12 William Siegrist <​wsiegrist@apple.com>

Add new Qt bots for Windows release, Windows debug, Linux release minimal, Linux armv5 release, and Linux armv7 release.

1:41 PM Accelerated Compositing created by Simon Fraser
1:40 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:39 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:37 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:30 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:30 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:29 PM Transforms-Transitions-Animations edited by Simon Fraser
(diff)
1:28 PM Transforms-Transitions-Animations created by Simon Fraser
1:26 PM Changeset in webkit [57479] by hyatt@apple.com
  • 5 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=37463, clean up NinePieceImage.

Reviewed by Mark Rowe.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImage):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::slices):
(WebCore::NinePieceImage::setSlices):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):

12:28 PM Changeset in webkit [57478] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, skipping a new test on Chromium, because the test is
using an API that is not yet implemented in Chromium.

  • platform/chromium/test_expectations.txt:
12:23 PM Changeset in webkit [57477] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip new test introduced in r57476, because of unimplemented
layoutTestController.computedStyleIncludingVisitedInfo()

  • platform/qt/Skipped: fast/history/multiple-classes-visited.html skipped.
11:42 AM Changeset in webkit [57476] by hyatt@apple.com
  • 4 edits
    2 adds
    1 delete in trunk

​https://bugs.webkit.org/show_bug.cgi?id=37455, :visited doesn't work with multiple classes/ids.

Reviewed by Sam Weinig.

WebCore:

Added fast/history/multiple-classes-visited.html.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkSelector):

LayoutTests:

  • fast/history/multiple-classes-visited-expected.txt: Added.
  • fast/history/multiple-classes-visited.html: Added.
11:31 AM April 2010 Meeting edited by evan@chromium.org
add my name, alphabetize (diff)
11:03 AM Changeset in webkit [57475] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

new-run-webkit-tests fails with exception on systems missing ruby
​https://bugs.webkit.org/show_bug.cgi?id=37441

  • Scripts/webkitpy/layout_tests/port/base.py:
    • Catch failures similar to how wdiff code path does.
    • After one failure, stop trying.
10:28 AM April 2010 Meeting edited by mjs@apple.com
(diff)
10:28 AM April 2010 Meeting edited by mjs@apple.com
(diff)
10:20 AM April 2010 Meeting edited by Simon Fraser
(diff)
10:02 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:59 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:58 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:56 AM April 2010 Meeting edited by mjs@apple.com
(diff)
9:46 AM Changeset in webkit [57474] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-04-12 Dirk Schulze <​krit@webkit.org>

Unreviewed build fix.

Make comma/whitespace around arc flags optional in SVG path syntax
​https://bugs.webkit.org/show_bug.cgi?id=37431

Fix the SL build.

  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag):
9:42 AM April 2010 Meeting edited by Simon Fraser
(diff)
9:41 AM April 2010 Meeting edited by Simon Fraser
(diff)
9:39 AM April 2010 Meeting edited by levin@chromium.org
(diff)
9:28 AM April 2010 Meeting edited by ddkilzer@webkit.org
(diff)
8:49 AM Changeset in webkit [57473] by eric@webkit.org
  • 6 edits in trunk

2010-04-12 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Add tests to handle that comma/whitespace around arc flags are optional
and that arc flags can only be 0 or 1 in SVG path syntax:
​https://bugs.webkit.org/show_bug.cgi?id=37431

  • svg/dom/fuzz-path-parser-expected.txt: One test now fails due to flags not 0 or 1
  • svg/dom/path-parser-expected.txt: Add test results for missing whitespace and flags not 0 or 1
  • svg/dom/script-tests/path-parser.js: Add 6 tests to check that whitespace is optional after flags and flags must be 0 or 1

2010-04-12 Jeff Schiller <​codedread@gmail.com>

Reviewed by Dirk Schulze.

Make comma/whitespace around arc flags optional in SVG path syntax and ensure flags are
either 0 or 1: ​https://bugs.webkit.org/show_bug.cgi?id=37431

  • svg/SVGParserUtilities.cpp: (WebCore::parseArcFlag): function to read in a 0 or 1 for largeArcFlag and sweepFlag (WebCore::SVGPathParser::parseSVG): modify/simplify arc parsing by using parseArcFlag()
8:24 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:23 AM April 2010 Meeting edited by levin@chromium.org
(diff)
8:12 AM April 2010 Meeting edited by Simon Hausmann
(diff)
8:09 AM April 2010 Meeting edited by adam.bergkvist@ericsson.com
(diff)
8:07 AM April 2010 Meeting edited by pmuellr@yahoo.com
(diff)
7:58 AM April 2010 Meeting edited by darin@chromium.org
(diff)
7:57 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:47 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:37 AM April 2010 Meeting edited by Simon Hausmann
(diff)
7:35 AM April 2010 Meeting edited by Simon Hausmann
(diff)
6:47 AM QtWebKitBackportingFixes edited by joseph.ligman@nokia.com
(diff)
3:59 AM Changeset in webkit [57472] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix for Mac when building with build-webkit --qt

Reviewed by nobody, build fix.

Specifying no configuration on Mac builds WebCore both in debug
and release. JavaScriptCore has to follow this rule as well.

3:52 AM BuildingQtOnLinux edited by nicholas@nicholaswilson.me.uk
added dependency on fontconfig (diff)
2:20 AM Changeset in webkit [57471] by aestes@apple.com
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Inserting my name in the correct location.

1:03 AM Changeset in webkit [57470] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-04-12 Tony Chang <​tony@chromium.org>

Reviewed by Eric Seidel.

Fix how we import simplejson based on how it's used in this file.
This fixes exceptions raised when trying to write the simplejson output.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Note: See TracTimeline for information about the timeline view.