Timeline
Oct 14, 2010:
- 11:52 PM Changeset in webkit [69841] by
-
- 2 edits2 adds in trunk/WebCore
2010-10-14 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
https://bugs.webkit.org/show_bug.cgi?id=47689
<rdar://problem/8552250>
The test requires using setTimeout(). So we put it in manual-tests.
- editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear(). (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before start timer for next autocorrection check.
- manual-tests/autocorrection: Added.
- manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.
- 11:33 PM Changeset in webkit [69840] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-14 Wei Jia <wjia@chromium.org>
Reviewed by Darin Fisher.
Retrieve info of lock keys from stashed currentInputEvent which
is stored by chromium when it passes input event to WebCore.
Retrieving only when stashed event is a keyboard event, which
means synthetic KeyboardEvent inherits lock key state from real
keyboard event.
https://bugs.webkit.org/show_bug.cgi?id=46518
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
- 11:31 PM Changeset in webkit [69839] by
-
- 2 edits in trunk/WebKitTools
2010-10-14 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] WTR is sloooow
https://bugs.webkit.org/show_bug.cgi?id=47695
- WebKitTestRunner/qt/TestControllerQt.cpp: Change the timer interval of RunUntilConditionLoop from 50 milliseconds to 1 to avoid wasting time after the test had been finished.
- 11:17 PM Changeset in webkit [69838] by
-
- 6 edits in trunk/LayoutTests
2010-10-14 Martin Robinson <mrobinson@igalia.com>
Rebaseline some failing tests.
- platform/gtk/fast/events/keydown-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- 10:14 PM Changeset in webkit [69837] by
-
- 2 edits in trunk/WebKitSite
Add guideline for constructors doing implicit type conversion to coding style.
https://bugs.webkit.org/show_bug.cgi?id=47646
Reviewed by Darin Adler.
- coding/coding-style.html:
- 9:09 PM Changeset in webkit [69836] by
-
- 15 edits4 adds in trunk
2010-10-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang and Darin Adler.
execCommand FormatBlock creates lots of blockquotes
https://bugs.webkit.org/show_bug.cgi?id=19795
The bug was caused by WebKit's not reusing the block node added by previous iteration
and its inserting block node at wrong places.
Fixed the bug by rewriting FormatBlockCommand::formatRange. New code resembles that of
IndentOutdentCommand::indentIntoBlockquote. The difference between two is that formatRange
avoids the existing block elements when replacing blocks and it also adds a placeholder
when removing the existing block caused paragraphs to collapse.
Also fixed a bug in moveParagraphWithClones where erroneous br is added to the start of
the block element to which the paragraph is moved if the block element is the start of a paragraph
and not the end of a paragraph.
Tests: editing/execCommand/format-block-multiple-paragraphs.html
editing/execCommand/format-block-table.html
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphWithClones): No longer adds erroneous br.
- editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Rewritten; see above. (WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement and moved from htmlediting.cpp. (WebCore::enclosingBlockToSplitTreeTo): Added.
- editing/FormatBlockCommand.h:
- editing/VisiblePosition.cpp: (WebCore::enclosingBlockFlowElement): Changed the return type to Element*
- editing/VisiblePosition.h:
2010-10-14 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang and Darin Adler.
execCommand FormatBlock creates lots of blockquotes
https://bugs.webkit.org/show_bug.cgi?id=19795
Added tests to ensure WebKit does not add multiple block elements when applying block element to
multiple paragraphs. Also added a test to ensure formatBlock works with tables.
- fast/html/nav-element-expected.txt: Preserved new lines and removed redundant br.
- editing/execCommand/format-block-expected.txt: Preserved span and removed erroneous br.
- editing/execCommand/format-block-from-range-selection-expected.txt: Merged dl's and removed erroneous br.
- editing/execCommand/format-block-multiple-paragraphs-expected.txt: Added.
- editing/execCommand/format-block-multiple-paragraphs.html: Added.
- editing/execCommand/format-block-table-expected.txt: Added.
- editing/execCommand/format-block-table.html: Added.
- editing/execCommand/format-block-with-braces-expected.txt: Removed erroneous br.
- 8:08 PM Changeset in webkit [69835] by
-
- 2 edits in trunk/LayoutTests
2010-10-14 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, asssigned a bug number to failing filesystem tests.
- platform/chromium/drt_expectations.txt:
- 7:54 PM Changeset in webkit [69834] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-14 John Abd-El-Malek <jam@chromium.org>
Reviewed by Tony Chang.
[chromium] null check the widget before sending it data as calling didReceiveData might delete it
https://bugs.webkit.org/show_bug.cgi?id=47708
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
- 7:45 PM Changeset in webkit [69833] by
-
- 7 edits in trunk
2010-10-14 Nathan Vander Wilt <nate@andyet.net>
Reviewed by Darin Adler.
Added parser for ECMAScript 5 standard date format, so Date.parse can handle RFC 3339 timestamps: https://bugs.webkit.org/show_bug.cgi?id=44632
- runtime/DateConversion.cpp: (JSC::parseDate):
- wtf/DateMath.cpp: (WTF::ymdhmsToSeconds): (WTF::parseES5DateFromNullTerminatedCharacters):
- wtf/DateMath.h:
2010-10-14 Nathan Vander Wilt <nate@andyet.net>
Reviewed by Darin Adler.
Added tests for https://bugs.webkit.org/show_bug.cgi?id=44632
- fast/js/date-parse-test-expected.txt:
- fast/js/script-tests/date-parse-test.js: (testDateParseExact):
- 6:54 PM Changeset in webkit [69832] by
-
- 3 edits in trunk/WebKitTools
2010-10-14 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing an exception seen on the commit-queue.
I should have unit tested this function before.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 6:50 PM Changeset in webkit [69831] by
-
- 7 edits2 adds in trunk
2010-10-14 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Crash in HTMLTextFormControlElement::selection()
https://bugs.webkit.org/show_bug.cgi?id=47522
Patch by Ryosuke Niwa <rniwa@webkit.org>
The bug was caused by our triggering layout inside RenderTextControl::selection.
Fixed it by changing the return type of RenderTextControl::selection to PassRefPtr<Range> from VisibleSelection.
Test: fast/forms/render-text-crash.html
- editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Calls HTMLTextFormControlElement::selection.
- html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::selection): Calls RenderTextControl::selection.
- html/HTMLFormControlElement.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection): Changed the return type.
- rendering/RenderTextControl.h:
2010-10-14 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Crash in HTMLTextFormControlElement::selection()
https://bugs.webkit.org/show_bug.cgi?id=47522
Patch by Ryosuke Niwa <rniwa@webkit.org>
Added a test to ensure WebKit does not crash when moving selection between input elements.
- fast/forms/render-text-crash-expected.txt: Added.
- fast/forms/render-text-crash.html: Added.
- 6:10 PM Changeset in webkit [69830] by
-
- 2 edits in branches/chromium/552/WebCore
Merge 69529 - 2010-10-11 James Robinson <jamesr@chromium.org>
Reviewed by Kenneth Russell.
[chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=47241
Avoid initializing accelerated graphics objects on CanvasRenderingContext2D
if there is no drawingContext associated with the canvas.
Test: fast/canvas/access-zero-sized-canvas.html
fast/canvas/canvas-skia-excessive-size.html
fast/canvas/toDataURL-noData.html
with --accelerated-compositing and --accelerated-2d-canvas
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):
- 5:51 PM Changeset in webkit [69829] by
-
- 18 edits in trunk/WebKitTools
2010-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue should not fail patches due to flaky tests
https://bugs.webkit.org/show_bug.cgi?id=47647
This patch makes it so that the *same* flaky test has to fail
twice in a row to have a false negative from a flaky test.
If different flaky tests fail (or if a test fails and then passes
in a second run) then we will warn in the bug that we encountered
a flaky test.
This patch grew to include moving port off of steps onto tool
(which Adam wrote and then I integrated), as well as removing the
use of tool from CommitQueueTask.
- Scripts/webkitpy/common/config/ports.py:
- Added a layout_test_results_path method. This covers old-run-webkit-tests but doesn't cover NRWT. This is probably not the long term solution, but putting this knowledge on port makes more sense than in LayoutTestResults.
- Scripts/webkitpy/common/net/buildbot.py:
- LayoutTestResults shouldn't know how to fetch from the network, make the Build code do that instead.
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Code style fix.
- Scripts/webkitpy/common/net/layouttestresults.py:
- Remove code for reading from the network.
- Scripts/webkitpy/common/net/layouttestresults_unittest.py:
- Test the new entrypoint.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Make the delegate interface explicit.
- Remove the _tool member, since using the delegate for everything is cleaner.
- Teach the testing logic how to deal with flaky tests.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Update to match the CommitQueueTask changes.
- Scripts/webkitpy/tool/commands/queues.py:
- Use the new CommitQueueTaskDelegate interface.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Fix the SecondThoughtsCommitQueue test which was broken.
- Add a new test to make sure the flaky test reporting works.
- Scripts/webkitpy/tool/main.py:
- Store the port on the tool object.
- Scripts/webkitpy/tool/mocktool.py:
- Add a port() accessor to MockTool
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Move port() off of Step and onto Tool.
- Scripts/webkitpy/tool/steps/build.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Two tests with the same name! only the latter was being run.
- Scripts/webkitpy/tool/steps/update.py:
- 5:50 PM Changeset in webkit [69828] by
-
- 3 edits2 copies in branches/chromium/552
Merge 69827 - 2010-10-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696
Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.
- fast/forms/select-listbox-focus-displaynone.html: Added.
2010-10-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696
Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.
Test: fast/forms/select-listbox-focus-displaynone.html
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
- 5:47 PM Changeset in webkit [69827] by
-
- 3 edits2 adds in trunk
2010-10-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696
Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.
- fast/forms/select-listbox-focus-displaynone.html: Added.
2010-10-14 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696
Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.
Test: fast/forms/select-listbox-focus-displaynone.html
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
- 5:35 PM Changeset in webkit [69826] by
-
- 9 edits in trunk/WebKit2
2010-10-14 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Plumb accelerated compositing prefs through WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46860
<rdar://problem/8495312>
Wire up the prefs to enable accelerated compositing, and
show debug borders and repaint counters.
- Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore): (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferencesPrivate.cpp: (WKPreferencesSetAcceleratedCompositingEnabled): (WKPreferencesGetAcceleratedCompositingEnabled): (WKPreferencesSetCompositingBordersVisible): (WKPreferencesGetCompositingBordersVisible): (WKPreferencesSetCompositingRepaintCountersVisible): (WKPreferencesGetCompositingRepaintCountersVisible):
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::setAcceleratedCompositingEnabled): (WebKit::WebPreferences::acceleratedCompositingEnabled): (WebKit::WebPreferences::setCompositingBordersVisible): (WebKit::WebPreferences::compositingBordersVisible): (WebKit::WebPreferences::setCompositingRepaintCountersVisible): (WebKit::WebPreferences::compositingRepaintCountersVisible):
- UIProcess/WebPreferences.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::preferencesDidChange): (WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/WebPage.h:
- 5:27 PM Changeset in webkit [69825] by
-
- 4 edits in trunk/WebKit/qt
2010-09-27 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
[Qt] Added functions for obtaining and checking the supported content types.
http://webkit.org/b/37880
- Api/qwebpage.cpp: (extractContentTypeFromHash): (extractContentTypeFromPluginVector): (QWebPage::supportedContentTypes): (QWebPage::supportsContentType):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::supportedContentType):
- 5:24 PM Changeset in webkit [69824] by
-
- 1 edit3 adds in trunk/LayoutTests
2010-10-14 Steve Block <steveblock@google.com>
Reviewed by Adam Barth.
Document behaviour of href when document base URI is changed after href atribute has been set
https://bugs.webkit.org/show_bug.cgi?id=47665
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-prevents-rebase.js: Added.
- fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase-expected.txt: Added.
- fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase.html: Added.
- 5:16 PM Changeset in webkit [69823] by
-
- 1 edit in branches/chromium/552/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp
Merge 69706 - No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
https://bugs.webkit.org/show_bug.cgi?id=47432
Patch by Victoria Kirst <vrk@google.com> on 2010-10-13
Reviewed by James Robinson.
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::cleanupResources):
- 4:35 PM Changeset in webkit [69822] by
-
- 9 edits in trunk/WebCore
This patch lays the groundwork for
https://bugs.webkit.org/show_bug.cgi?id=47514 CSS transforms should
affect scrolling
by adding topmostPosition().
Reviewed by Dave Hyatt.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::topmostPosition):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::topmostPosition):
- rendering/RenderBox.h:
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::topmostPosition):
- rendering/RenderMedia.h:
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::topmostPosition):
- rendering/RenderTableSection.h:
- 4:24 PM Changeset in webkit [69821] by
-
- 5 edits in trunk/WebCore
2010-10-14 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] fix compilation warnings in imported libsoup code
https://bugs.webkit.org/show_bug.cgi?id=47674
Fixed some warnings caused by comparisons between signed and
unsigned integer expressions
- platform/network/soup/cache/soup-directory-input-stream.c: (webkit_soup_directory_input_stream_read):
- platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
- platform/network/soup/cache/soup-request-file.c: (webkit_soup_request_file_ensure_file):
- platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_is_fresh_enough): (webkit_soup_cache_has_response):
- 4:22 PM Changeset in webkit [69820] by
-
- 4 edits in trunk/WebKitTools
2010-10-14 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
new-run-webkit-tests will now handle missing Ruby installs (or
missing PrettyPatch scripts) more cleanly - previously this
would be detected when we actually tried to create the diff, and
the error message was obscure. Now we'll log a warning up front
and otherwise be silent.
This change also refactors some global variables to be class or
instance variables to be slightly more testable and more
modular. There are no cases where we create lots of port objects
and can't afford to test for configurations repeatedly, so
there's no performance concern here.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- 4:20 PM Changeset in webkit [69819] by
-
- 2 edits in trunk/WebCore
2010-10-14 Andreas Kling <kling@webkit.org>
Unreviewed buildfix, RetainPtr is a mac thing..
- platform/network/soup/ProxyServerSoup.cpp:
- 4:18 PM Changeset in webkit [69818] by
-
- 26 edits24 adds in trunk
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
Rebaseline tests which depend on form control font size.
- platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/gtk/editing/selection/drag-select-1-expected.txt:
- platform/gtk/editing/selection/drag-text-delay-expected.txt:
- platform/gtk/editing/selection/select-box-expected.txt:
- platform/gtk/fast/css/input-search-padding-expected.txt:
- platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/gtk/fast/events/keydown-1-expected.txt:
- platform/gtk/fast/forms/box-shadow-override-expected.txt:
- platform/gtk/fast/forms/button-style-color-expected.txt:
- platform/gtk/fast/forms/input-button-sizes-expected.txt:
- platform/gtk/fast/forms/input-text-drag-down-expected.txt:
- platform/gtk/fast/forms/placeholder-stripped-expected.txt:
- platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
- platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/gtk/transforms/2d/zoom-menulist-expected.txt:
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
Have form controls use the font specified in GtkSettings. This font is
the default control font in GTK+ applications and Firefox. We need to
pass the string through Pango to get a valid font name and size.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::getScreenDPI): A helper function which returns the DPI of the default screen or 96 as a fallback. (WebCore::RenderThemeGtk::systemFont): Calculate the system font by looking at the GtkSettings value and pushing it through Pango to get the font family and font size.
2010-10-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134
- DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Initialize the font control size when running DumpRenderTree to a standard value.
- 4:12 PM Changeset in webkit [69817] by
-
- 2 edits1 add in trunk/WebCore
2010-10-14 Andreas Kling <kling@webkit.org>
Soup buildfix for r69808: add ProxyServer stub.
- GNUmakefile.am:
- platform/network/soup/ProxyServerSoup.cpp: Added. (WebCore::proxyServersForURL):
- 4:05 PM Changeset in webkit [69816] by
-
- 5 edits in branches/safari-533.19-branch
Versioning.
- 4:04 PM Changeset in webkit [69815] by
-
- 3 edits in trunk/WebCore
2010-10-14 Andreas Kling <kling@webkit.org>
Fix GTK+ build after r69808.
- GNUmakefile.am:
- platform/network/curl/ProxyServerCurl.cpp: (WebCore::proxyServersForURL):
- 4:04 PM Changeset in webkit [69814] by
-
- 1 copy in tags/Safari-533.19.4
New tag.
- 4:02 PM Changeset in webkit [69813] by
-
- 2 edits in trunk/WebCore
2010-10-14 Simon Fraser <Simon Fraser>
Another build fix. Export FrameLoader::networkingContext()
- WebCore.exp.in:
- 3:58 PM Changeset in webkit [69812] by
-
- 3 edits5 adds in branches/safari-533.19-branch
Merge r62683.
- 3:56 PM Changeset in webkit [69811] by
-
- 4 edits in trunk/WebCore
2010-10-14 Simon Fraser <Simon Fraser>
Fix the build after r69808.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/cf/ProxyServerCFNet.cpp: (WebCore::proxyServersForURL):
- 3:46 PM Changeset in webkit [69810] by
-
- 2 edits in trunk/WebCore
Windows build fix following r69806.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):
- 3:32 PM Changeset in webkit [69809] by
-
- 5 edits6 adds in trunk
2010-10-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
- WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn
2010-10-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
- DumpRenderTree/DumpRenderTree.gypi: files to compile
- DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
- 3:16 PM Changeset in webkit [69808] by
-
- 13 edits in trunk
2010-10-14 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling
Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
https://bugs.webkit.org/show_bug.cgi?id=34539
These missing NPN functions cause Java applets to crash in ports such
as QtWebkit that rely on webkit for Java applet support.
- plugins/PluginDebug.cpp: (WebCore::prettyNameForNPNURLVariable):
- plugins/PluginDebug.h:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
- plugins/PluginView.cpp: (WebCore::PluginView::getValueForURL): (WebCore::PluginView::setValueForURL): (WebCore::PluginView::getAuthenticationInfo):
- plugins/PluginView.h:
- plugins/npapi.cpp: (NPN_GetValueForURL): (NPN_SetValueForURL): (NPN_GetAuthenticationInfo):
- platform/network/ProxyServer.h:
- platform/network/cf/ProxyServerCFNet.cpp: (WebCore::proxyServersForURL):
- platform/network/qt/ProxyServerQt.cpp: (WebCore::proxyServersForURL):
- 2:56 PM Changeset in webkit [69807] by
-
- 2 edits in trunk/WebCore
Windows build fix following r69806.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::markupToCFHTML):
- 2:45 PM Changeset in webkit [69806] by
-
- 2 edits in trunk/WebKitTools
2010-10-14 Victor Wang <victorw@chromium.org>
Reviewed by Nate Chapin.
[Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
- 2:18 PM Changeset in webkit [69805] by
-
- 2 edits in trunk/WebKitTools
2010-10-14 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
test-webkitpy spews Delegate terminated queue messages
https://bugs.webkit.org/show_bug.cgi?id=47678
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- 2:11 PM Changeset in webkit [69804] by
-
- 4 edits in trunk/WebCore
2010-10-14 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Cache link status at linkProgram and use it in useProgram instead of querying GPU
https://bugs.webkit.org/show_bug.cgi?id=47685
- html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
- html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):
- 2:05 PM Changeset in webkit [69803] by
-
- 4 edits in trunk
2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69795.
http://trac.webkit.org/changeset/69795
https://bugs.webkit.org/show_bug.cgi?id=47687
'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).
- platform/qt/Skipped:
2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69795.
http://trac.webkit.org/changeset/69795
https://bugs.webkit.org/show_bug.cgi?id=47687
'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
- 2:03 PM Changeset in webkit [69802] by
-
- 5 edits in trunk/WebKit2
Reviewed by Sam Weinig.
WebKit2: Store the certificate chain in PlatformCertificateInfo.
https://bugs.webkit.org/show_bug.cgi?id=47603
- Shared/API/c/win/WKCertificateInfoWin.cpp: (WKCertificateInfoGetCertificateChainLength): (WKCertificateInfoGetCertificateContextAtIndex):
- Shared/API/c/win/WKCertificateInfoWin.h:
- Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Get the chain context from the response and duplicate the certificate contexts in the chain to store in m_certificateChain. (WebKit::PlatformCertificateInfo::~PlatformCertificateInfo): Free all the certificate contexts in the chain. (WebKit::PlatformCertificateInfo::operator=): Duplicate the certificate contexts from the other PlatformCertificateInfo's certificate chain to store in m_certificateChain. (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode): (WebKit::PlatformCertificateInfo::clearCertificateChain): Free all the certificate contexts in the chain and clear the vector.
- Shared/win/PlatformCertificateInfo.h: (WebKit::PlatformCertificateInfo::certificateChain):
- 1:48 PM Changeset in webkit [69801] by
-
- 2 edits in trunk/WebCore
2010-10-14 Justin Schuh <jschuh@chromium.org>
Reviewed by James Robinson.
Style fix for r69735
https://bugs.webkit.org/show_bug.cgi?id=47684
No logic change. Existing tests apply.
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection):
- 1:16 PM Changeset in webkit [69800] by
-
- 14 edits28 deletes in branches/chromium/517
Revert 66670 - 2010-09-01 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
- fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
- fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
- fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
- fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
- fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
- fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
- fast/dom/HTMLScriptElement/resources/defer.js: Added.
- fast/dom/HTMLScriptElement/resources/external.js: Added.
- fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
- fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
- fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
- fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
- http/tests/misc/resources/defer-script.js: Added.
- http/tests/misc/resources/external-script.js: Added.
- http/tests/misc/resources/script-debug-body-background.js: Added.
- http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
- http/tests/misc/resources/slow-defer-script.cgi: Added.
- http/tests/misc/resources/slow-stylesheet.cgi: Added.
- http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
- http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
- http/tests/misc/script-defer-expected.txt: Added.
- http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.
2010-09-01 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html
fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html
- dom/Document.cpp: (WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
- dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser): (WebCore::DocumentParser::startParsing): (WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping. (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::detach):
- dom/DocumentParser.h: (WebCore::DocumentParser::isParsing): (WebCore::DocumentParser::isActive): (WebCore::DocumentParser::isStopping): (WebCore::DocumentParser::isDetached):
- dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::exitText):
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::notifyFinished):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
- html/parser/HTMLScriptRunner.h:
- loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish):
TBR=tonyg@chromium.org
BUG=57196
Review URL: http://codereview.chromium.org/3776004
- 12:52 PM Changeset in webkit [69799] by
-
- 8 edits in trunk/WebCore
2010-10-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: encapsulate ScriptState into ConsoleMessage instead of passing it as additional parameter
https://bugs.webkit.org/show_bug.cgi?id=47675
No new tests. This refactoring is covered by existing inspector tests.
- bindings/js/JSConsoleCustom.cpp:
- bindings/js/ScriptCallFrame.cpp:
- bindings/js/ScriptCallFrame.h: (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
- inspector/InspectorController.h:
- 12:48 PM Changeset in webkit [69798] by
-
- 44 edits1 add in trunk
2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Gavin Barraclough.
Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664
Add StringTypeAdapter<char> to accept single characters for makeString().
- wtf/text/StringConcatenate.h: (WTF::makeString):
2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Gavin Barraclough.
Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664
- ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo):
- dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError):
- history/PageCache.cpp: (WebCore::logCanCacheFrameDecision):
- html/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
- inspector/CodeGeneratorInspector.pm:
- inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::count):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::createBreakpointId):
- inspector/InspectorDebuggerAgent.cpp: (WebCore::formatBreakpointId):
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName): (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
- loader/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::shouldAllowNavigation):
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
- page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
- page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject):
- platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createKeyMap): (WebCore::createWindowsKeyMap):
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition):
- platform/graphics/brew/ImageBrew.cpp: (WebCore::Image::loadPlatformResource):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL):
- platform/graphics/efl/ImageEfl.cpp: (WebCore::loadResourceSharedBuffer):
- platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
- platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier):
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
- platform/graphics/win/WebLayer.cpp: (WebCore::WebLayer::drawInContext):
- platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL):
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::setSynchronous):
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager):
- platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCFHTML):
- platform/win/Language.cpp: (WebCore::defaultLanguage):
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
- svg/SVGUseElement.cpp: (WebCore::dumpInstanceTree):
- websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
- websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer):
- websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):
2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Gavin Barraclough.
Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664
Rebaseline two xssAuditor tests, that have been changed, after switching from String::format() -> makeString().
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- 12:47 PM Changeset in webkit [69797] by
-
- 4 edits in trunk/WebKitLibraries
Rubber-stamped by Adam Roben.
Fix Windows build.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 12:40 PM Changeset in webkit [69796] by
-
- 2 edits in trunk/WebKit/gtk
2010-10-14 Joone Hur <joone@kldp.org>
Reviewed by Andreas Kling.
[GTK] google.co.kr was missed when checking Google domains
https://bugs.webkit.org/show_bug.cgi?id=47652
WebKitGtk+ maintains a list of Google domains for working well with Google sites.
Add google.co.kr also to the list to be checked with other Google domains.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::initializeDomainsList): Added google.co.kr.
- 12:38 PM Changeset in webkit [69795] by
-
- 4 edits in trunk
2010-10-14 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Fix http/tests/misc/redirect-to-external-url.html
Support the test in FrameLoaderClientQt and unskip.
- platform/qt/Skipped:
2010-10-14 Robert Hogan <robert@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Fix http/tests/misc/redirect-to-external-url.html
Support the test in FrameLoaderClientQt and unskip.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
- 12:29 PM Changeset in webkit [69794] by
-
- 2 edits in branches/chromium/552/WebCore
Merge 69634 - 2010-10-12 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Pass platform path (rather than virtual path) when creating File from FileEntry
https://bugs.webkit.org/show_bug.cgi?id=47563
No new tests, the new test for FileWriter will be verifying this.
- fileapi/FileEntry.cpp: (WebCore::FileEntry::file):
- 12:29 PM Changeset in webkit [69793] by
-
- 2 edits in trunk/WebCore
2010-10-14 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Small cleanup in PluginViewGtk
https://bugs.webkit.org/show_bug.cgi?id=47588
Remove some dead code and use PlatformRefPtr for cairo surfaces.
No new tests, only refactoring.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):
- 12:23 PM Changeset in webkit [69792] by
-
- 2 edits in trunk/WebKit/efl
2010-10-14 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Eric Seidel.
[EFL] Use data_set after data_get to keep refcount correct.
https://bugs.webkit.org/show_bug.cgi?id=47110
The call to evas_object_image_data_set was missed in this function,
which caused the refcount of the data being always increased on every
scroll.
- ewk/ewk_view_single.c: (_ewk_view_single_smart_scrolls_process):
- 12:22 PM Changeset in webkit [69791] by
-
- 2 edits in trunk/WebCore
2010-10-14 Dawit Alemayehu <adawit@kde.org>
Reviewed by Andreas Kling.
Fix compile error when bulding webkit's Qt port using the "--v8" option.
https://bugs.webkit.org/show_bug.cgi?id=47455
- platform/qt/PlatformBridge.h:
- 12:22 PM Changeset in webkit [69790] by
-
- 4 edits in trunk/WebKit2
Make sure WebKit2 only loads each plugin once
Fixes <http://webkit.org/b/47677> <rdar://problem/8552178> WebKit2 can
load the same plugin multiple times
Reviewed by Sam Weinig.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::addFromVector): Helper function that adds all the elements
from a Vector to a HashSet.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Put all the plugin
paths into a HashSet, then load the plugins specified in the HashSet.
On Windows, the HashSet is case-insensitive, just like the file
system.
- UIProcess/Plugins/PluginInfoStore.h: Removed loadPluginsInDirectory,
which is no longer used.
- UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Changed to store the paths in a Vector instead of a HashSet now that
loadPluginsIfNecessary will handle duplicates for us.
- 12:22 PM Changeset in webkit [69789] by
-
- 6 edits in trunk/WebKit2
Load plugins that are specified in the MozillaPlugins registry key
Fixes <http://webkit.org/b/44271> <rdar://problem/8329750> WebKit2
should load plugins specified in the MozillaPlugins registry key (like
old WebKit does)
I couldn't think of a good way to test this.
Reviewed by Steve Falkenburg.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Also load plugins
specified by individualPluginPaths.
- UIProcess/Plugins/PluginInfoStore.h: Added individualPluginPaths and
some comments.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::individualPluginPaths):
- UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
(WebKit::PluginInfoStore::individualPluginPaths):
Stubbed out.
- UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Ported this code from WebCore's PluginDatabaseWin.cpp. I slightly
cleaned it up and changed it to use a case-insensitive hash, since
paths on Windows are case-insensitive.
- 12:21 PM Changeset in webkit [69788] by
-
- 14 edits1 copy2 adds in trunk
Call ::DefWindowProcW for unhandled key events
::DefWindowProcW does important things for at least some key events
(e.g., it generates a WM_SYSCOMMAND message when the Alt key is
released), so we need to make sure to call it when we don't handle key
events.
Fixes <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
the Alt key when MiniBrowser's WKView is focused doesn't send focus to
the menu bar
Reviewed by Steve Falkenburg.
WebKit2:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didNotHandleKeyEvent):
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::didNotHandleKeyEvent):
- UIProcess/API/qt/qwkpage_p.h:
Stubbed out didNotHandleKeyEvent.
- UIProcess/PageClient.h: Added didNotHandleKeyEvent.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent): Tell the PageClient about the
unhandled event.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::onKeyEvent): Added a comment.
(WebKit::WebView::didNotHandleKeyEvent): Pass the event to
::DefWindowProcW.
- UIProcess/win/WebView.h: Added didNotHandleKeyEvent.
WebKitTools:
Test that pressing the Alt key generates a WM_SYSCOMMAND message
- TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
TestWebKitAPI/win to the include path so that WindowMessageObserver
can be found.
- TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
Windows-specific members.
(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
Added this simple setter.
- TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
(TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
Initialize our lone data member.
(TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
Simple getter.
(TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
when a WM_SYSCOMMAND message is received.
(TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
WM_SYSKEYUP message is not handled.
(TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
pressing the Alt key and check that a WM_SYSCOMMAND message got sent
to the WKView's parent window.
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
member function so it could access PlatformWebView::wndProc. Use
PlatformWebView::wndProc as the WNDPROC.
(TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
data member and pass the this pointer to CreateWindowEx so we can
store it on the HWND.
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
constants from here to the top of the file.
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
the same messages that Notepad receives when you press the Alt key.
(TestWebKitAPI::PlatformWebView::wndProc): Added.
- When WM_CREATE is received, we set the PlatformWebView instance pointer as a property on the HWND so we can access it later.
- For other messages, we try to get the PlatformWebView instance pointer from the HWND property.
- When WM_NCDESTROY is received (which is the last message we will receive), we remove the PlatformWebView instance property.
- Pass messages to the parent window's message observer, if there is one.
- Pass all messages through to ::DefWindowProcW.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
and AltKeyGeneratesWMSysCommand.
- TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
used to observe messages sent to one or more windows.
- 12:19 PM Changeset in webkit [69787] by
-
- 3 edits in trunk/JavaScriptCore
need way to measure size of JITed ARM code
https://bugs.webkit.org/show_bug.cgi?id=47121
Patch by David Goodwin <david_goodwin@apple.com> on 2010-10-14
Reviewed by Darin Adler.
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpLinkStats):
(JSC::LinkBuffer::dumpCode):
- 11:52 AM Changeset in webkit [69786] by
-
- 5 edits4 adds in trunk
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
Added a platform-specific test which verifies that if XSettings
specifies subpixel aliasing, it is the default rendering style.
- platform/gtk/fonts/xsettings_antialias_settings-expected.checksum: Added.
- platform/gtk/fonts/xsettings_antialias_settings-expected.png: Added.
- platform/gtk/fonts/xsettings_antialias_settings-expected.txt: Added.
- platform/gtk/fonts/xsettings_antialias_settings.html: Added.
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
Fix logic that merges XSettings defaults and FontConfig settings. If
FontConfig or XSettings specifies a subpixel order, we force subpixel
anti-aliasing on. If anti-aliasing is turned on explicitly, only
override the setting if it was previously off, otherwise we ignore
the user's preference for subpixel or gray antialiasing.
Test: platform/gtk/fonts/xsettings_antialias_settings.html
- platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::setCairoFontOptionsFromFontConfigPattern): Fix merging of XSettings and FontConfig anti-aliasing settings. (WebCore::getDefaultFontOptions): Added this helper. (WebCore::FontPlatformData::FontPlatformData): Use the getDefaultFontOptions helper.
2010-10-01 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033
- DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Added this method which initializes XSettings font settings to consistent values before running a test. For the one test in which we need subpixel aliasing turned on, do that. (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings. (runTest): Pass the testURL to initializeFonts.
- 11:50 AM Changeset in webkit [69785] by
-
- 1 edit40 adds in trunk/LayoutTests
2010-10-14 Nate Chapin <Nate Chapin>
Unreviewed, test tweaks.
Add Chromium win/linux results for http://trac.webkit.org/changeset/69774.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- 11:45 AM Changeset in webkit [69784] by
-
- 4 edits in trunk/WebKitLibraries
Reviewed by Steve Falkenburg.
Add wkGetSSLCertificateChainContext for fetching the certificate chain.
Needed for https://bugs.webkit.org/show_bug.cgi?id=47603.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 11:36 AM Changeset in webkit [69783] by
-
- 3 edits in trunk/WebKit/efl
2010-10-14 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add setting api for enabling encoding detector
https://bugs.webkit.org/show_bug.cgi?id=45427
Add settings api for enabling encoding detector.
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_encoding_detector_set): (ewk_view_setting_encoding_detector_get):
- ewk/ewk_view.h:
- 11:30 AM Changeset in webkit [69782] by
-
- 13 edits in trunk/WebCore
Support typed arrays in workers
https://bugs.webkit.org/show_bug.cgi?id=47616
Reviewed by David Levin.
To support typed arrays in workers, we need to expose constructors in
WorkerContext and add NoStaticTables attribute.
I also add File API feature guard to the constructors defined in
DOMWindow.
- bindings/js/JSDOMWindowCustom.cpp: Add File API feature guard to the
constructors defined in DOMWindow.
- html/canvas/ArrayBuffer.idl: Add NoStaticTables attribute.
- html/canvas/ArrayBufferView.idl: Add NoStaticTables attribute.
- html/canvas/Float32Array.idl: Add NoStaticTables attribute.
- html/canvas/Int16Array.idl: Add NoStaticTables attribute.
- html/canvas/Int32Array.idl: Add NoStaticTables attribute.
- html/canvas/Int8Array.idl: Add NoStaticTables attribute.
- html/canvas/Uint16Array.idl: Add NoStaticTables attribute.
- html/canvas/Uint32Array.idl: Add NoStaticTables attribute.
- html/canvas/Uint8Array.idl: Add NoStaticTables attribute.
- page/DOMWindow.idl: Add File API feature guard to the constructors
defined in DOMWindow.
- workers/WorkerContext.idl: Expose type array constructors.
- 11:00 AM Changeset in webkit [69781] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-14 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The backreference checking isn't working in some cases with YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46904
The Interpreter::matchBackReference() function returns true without matching
when a backreference points to the same parentheses where it is.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchBackReference):
- 10:47 AM Changeset in webkit [69780] by
-
- 1 edit9 adds in trunk/LayoutTests
Add baselines and pixel results for some new tests.
- platform/gtk/fast/forms/textfield-focus-ring-expected.checksum: Added.
- platform/gtk/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/gtk/fast/forms/textfield-focus-ring-expected.txt: Added.
- platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Added.
- platform/gtk/fast/images/imagemap-focus-ring-expected.png: Added.
- platform/gtk/fast/images/imagemap-focus-ring-expected.txt: Added.
- platform/gtk/fast/inline/inline-focus-ring-expected.checksum: Added.
- platform/gtk/fast/inline/inline-focus-ring-expected.png: Added.
- platform/gtk/fast/inline/inline-focus-ring-expected.txt: Added.
- 10:45 AM Changeset in webkit [69779] by
-
- 2 edits in trunk/WebCore
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Ariya Hidayat.
[Qt] Avoid creating empty transparency layers in ImageBuffer::clip()
We were creating empty layers for sub-1 height/width clips due to
using IntRect(FloatRect) instead of enclosingIntRect().
This lead to a bunch of QPainter warnings on the console since you
can't draw on an empty QPixmap.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::clip):
- 10:31 AM Changeset in webkit [69778] by
-
- 1 edit18 adds in trunk/LayoutTests
2010-10-14 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test fix.
Expected results for tests added in http://trac.webkit.org/changeset/69766.
- platform/chromium-linux/fast/forms/textfield-focus-ring-expected.checksum: Added.
- platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/chromium-linux/fast/images/imagemap-focus-ring-expected.checksum: Added.
- platform/chromium-linux/fast/images/imagemap-focus-ring-expected.png: Added.
- platform/chromium-linux/fast/inline/inline-focus-ring-expected.checksum: Added.
- platform/chromium-linux/fast/inline/inline-focus-ring-expected.png: Added.
- platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
- platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
- platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.checksum: Added.
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt: Added.
- platform/chromium-win/fast/images/imagemap-focus-ring-expected.checksum: Added.
- platform/chromium-win/fast/images/imagemap-focus-ring-expected.png: Added.
- platform/chromium-win/fast/images/imagemap-focus-ring-expected.txt: Added.
- platform/chromium-win/fast/inline/inline-focus-ring-expected.checksum: Added.
- platform/chromium-win/fast/inline/inline-focus-ring-expected.png: Added.
- platform/chromium-win/fast/inline/inline-focus-ring-expected.txt: Added.
- 10:31 AM Changeset in webkit [69777] by
-
- 3 edits in trunk/WebKit/qt
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Allow rendering of accelerated-compositing with TextureMapper, inside a QWebFrame. The frame will render the regular content,
either normally or through tiled backingstore, then let the TextureMapper layer render itself to the active context, and
then render the scrollbar and pan icon. This is different from the current implementation, which uses additional QGraphicsItems for AC
and the scrollbar overlay.
- Api/qgraphicswebview.cpp: (QGraphicsWebView::paint):
- Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderRelativeCoords):
- 10:23 AM Changeset in webkit [69776] by
-
- 2 edits in trunk/WebCore
[cairo] Typo in determining fixed width fonts
https://bugs.webkit.org/show_bug.cgi?id=47470
It must be a single ampersand otherwise the
&& FT_FACE_FLAG_FIXED_WIDTH will always be true.
- platform/graphics/cairo/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 10:13 AM Changeset in webkit [69775] by
-
- 2 edits in trunk/WebCore
2010-10-14 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html
https://bugs.webkit.org/show_bug.cgi?id=47666
Do a less strict decoding of base64 data url's as it was done
before. The actual problem is most likely
https://bugs.webkit.org/show_bug.cgi?id=47661 tough.
- platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
- 10:12 AM Changeset in webkit [69774] by
-
- 4 edits50 adds in trunk
2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Andreas Kling.
SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660
Adding layout tests for feConvolveMatrix dynamic DOM changes. SVGDOM tests cases will be in the following patch because of patch-size limitation (2M in bugzilla).
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html: Added.
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-edgeMode-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js: Added. (executeTest):
2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>
Reviewed by Andreas Kling.
SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660
The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
The patch also implements the simple setOrder and setKernelUnitLength methods.
Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::setOrder): (WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
- svg/SVGFEConvolveMatrixElement.h:
- 9:57 AM Changeset in webkit [69773] by
-
- 6 edits in trunk
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] Text breaking is slow: enable ICU as an opt-in
https://bugs.webkit.org/show_bug.cgi?id=40332
Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
Because of the inclusion of ICU headers, some explicit casting was necessary in UnicodeQt4.h
- JavaScriptCore.pri:
- wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::mirroredChar): (WTF::Unicode::combiningClass): (WTF::Unicode::direction): (WTF::Unicode::category):
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] Text breaking is slow: enable ICU as an opt-in
https://bugs.webkit.org/show_bug.cgi?id=40332
Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
No new tests, this should be covered by existing tests.
- WebCore.pro:
- platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::currentTextBreakLocaleID):
- 9:52 AM Changeset in webkit [69772] by
-
- 3 edits in trunk/WebCore
2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
This patch enables compilation of TextureMapper with Media. It has an initial non-working implementation of a video layer, to be integrated
once other parts of TextureMapper are fully working.
No new tests: this is new implementation that's not enabled yet.
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::TextureMapperVideoLayerQt::TextureMapperVideoLayerQt): (WebCore::TextureMapperVideoLayerQt::setPlatformLayerClient): (WebCore::TextureMapperVideoLayerQt::paint): (WebCore::TextureMapperVideoLayerQt::size): (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQt::platformLayer):
- platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQt::platformLayer):
- 9:40 AM Changeset in webkit [69771] by
-
- 2 edits in trunk/LayoutTests
2010-10-14 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations update.
- platform/chromium/test_expectations.txt:
- 9:40 AM Changeset in webkit [69770] by
-
- 3 edits in trunk/WebKitTools
2010-10-14 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=47655
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/common/config/ports_unittest.py:
- 9:18 AM Changeset in webkit [69769] by
-
- 3 edits in trunk/LayoutTests
2010-10-14 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update expectations for some inspector tests.
- inspector/debugger-pause-in-eval-script-expected.txt:
- inspector/extensions-events-expected.txt:
- 9:13 AM Changeset in webkit [69768] by
-
- 2 edits in trunk/WebCore
2010-10-14 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fixed crashes in the GTK 64bits bot, we have to use NULL instead
of 0 when calling these glib APIs, 0 is compiled as a char and in
64bits systems it is not correct.
- platform/network/soup/cache/soup-requester.c: (webkit_soup_requester_new): (webkit_soup_requester_request_uri):
- 9:00 AM Changeset in webkit [69767] by
-
- 2 edits in trunk/WebCore
2010-10-14 Daniel Bates <dbates@rim.com>
Attempt to fix the Qt and GTK builds based on the build bot results from <http://webkit.sed.hu>.
- rendering/RenderInline.cpp: Include header "RenderTheme.h"
- 8:40 AM Changeset in webkit [69766] by
-
- 6 edits12 adds in trunk
2010-10-14 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632
Fixes an issue where RenderInline::paintOutline() and RenderImage::paintFocusRings()
would draw a focus ring regardless of whether the port-specific theme is able to
draw a focus ring. Instead, these methods should only draw a focus ring if the
theme is unable to draw a focus ring.
Also, extracted common focus ring drawing code from RenderObject::paintOutline()
and RenderInline::paintOutline() into RenderObject::paintFocusRing().
Tests: fast/forms/textfield-focus-ring.html
fast/images/imagemap-focus-ring.html
fast/inline/inline-focus-ring.html
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRings): Modified to only draw a focus ring if the the theme does not draw one.
- rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): Modified to call RenderObject::paintFocusRing().
- rendering/RenderObject.cpp:
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): Added. (WebCore::RenderObject::paintOutline): Modified to call RenderObject::paintFocusRing().
- rendering/RenderObject.h:
2010-10-14 Daniel Bates <dbates@rim.com>
Reviewed by Darin Adler.
Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632
Pixel tests to ensure that we don't regress focus ring drawing for RenderObject
(fast/forms/textfield-focus-ring.html), RenderImage (fast/images/imagemap-focus-ring.html)
and RenderInline (fast/inline/inline-focus-ring.html) on ports that support focus
ring drawing.
- fast/forms/textfield-focus-ring.html: Added.
- fast/images/imagemap-focus-ring.html: Added.
- fast/inline/inline-focus-ring.html: Added.
- platform/mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
- platform/mac/fast/forms/textfield-focus-ring-expected.png: Added.
- platform/mac/fast/forms/textfield-focus-ring-expected.txt: Added.
- platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
- platform/mac/fast/images/imagemap-focus-ring-expected.png: Added.
- platform/mac/fast/images/imagemap-focus-ring-expected.txt: Added.
- platform/mac/fast/inline/inline-focus-ring-expected.checksum: Added.
- platform/mac/fast/inline/inline-focus-ring-expected.png: Added.
- platform/mac/fast/inline/inline-focus-ring-expected.txt: Added.
- 8:16 AM Changeset in webkit [69765] by
-
- 2 edits in trunk/LayoutTests
2010-10-14 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
[chromium] Update test_expectations following Skia roll in chromium.
- platform/chromium/test_expectations.txt:
- 7:14 AM Changeset in webkit [69764] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-10-14 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
DeviceOrientation crash when page is in page cache and is navigated while listener is registered
https://bugs.webkit.org/show_bug.cgi?id=47257
This crash is avoided now that pages using DeviceOrientation are not put in
the page cache. See https://bugs.webkit.org/show_bug.cgi?id=47408.
This test serves to document the fact that the underlying problem needs to
be addressed before the page cache is enabled for DeviceOrientation.
- fast/dom/DeviceOrientation/event-after-navigation-expected.txt: Added.
- fast/dom/DeviceOrientation/event-after-navigation.html: Added.
- fast/dom/DeviceOrientation/resources/event-after-navigation-new.html: Added.
- fast/dom/DeviceOrientation/script-tests/event-after-navigation.js: Added.
- 6:48 AM Changeset in webkit [69763] by
-
- 9 edits in trunk/WebCore
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Move load and dom content event timers into InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=47668
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateScriptObject):
- inspector/InspectorResource.h:
- inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired):
- 6:18 AM Changeset in webkit [69762] by
-
- 2 edits in trunk
2010-10-14 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Fix -Werror after r68637 on x86 platforms.
Qt's build system sets QT_ARCH statically to i386 or x86_64 accordingly,
so check for this instead of only checking for x86.
- WebKit.pri:
- 6:03 AM Changeset in webkit [69761] by
-
- 11 edits1 move1 add1 delete in trunk/WebCore
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Re-landing r69757.
- 5:56 AM Changeset in webkit [69760] by
-
- 6 edits in trunk/WebCore
2010-10-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: implement pausing on window events and timeouts
https://bugs.webkit.org/show_bug.cgi?id=47542
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl): (WebCore::InspectorInstrumentation::didDispatchEventImpl): (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::didFireTimerImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
- inspector/InspectorInstrumentation.h:
- inspector/front-end/BreakpointManager.js: (WebInspector.EventListenerBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpoint.prototype._condition): (WebInspector.EventListenerBreakpoint.prototype._uiEventName):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
- 5:43 AM Changeset in webkit [69759] by
-
- 2 edits in trunk/WebCore
2010-10-14 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Andreas Kling.
Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273
Warning fix after r69755. Missing default cases added.
- html/canvas/CanvasStyle.cpp: (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): (WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
- 5:01 AM Changeset in webkit [69758] by
-
- 11 edits1 move1 add1 delete in trunk/WebCore
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out r69757.
- 4:38 AM Changeset in webkit [69757] by
-
- 11 edits1 move1 add1 delete in trunk/WebCore
2010-10-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract content-related methods into InspectorResourceAgent.
https://bugs.webkit.org/show_bug.cgi?id=47415
This is needed for resource-tracking-less operation of resources panel.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes):
- inspector/InspectorResource.h:
- inspector/InspectorResourceAgent.cpp: Added. (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResourceType): (WebCore::InspectorResourceAgent::cachedResource):
- inspector/InspectorResourceAgent.h: Added.
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/InspectorUtilities.cpp: Removed.
- inspector/InspectorUtilities.h: Removed.
- 4:02 AM Changeset in webkit [69756] by
-
- 2 edits in trunk/LayoutTests
2010-10-14 Hayato Ito <hayato@chromium.org>
Unreviewed, build fix.
Skip a test that does not have an expected result.
<http://trac.webkit.org/changeset/69751> lacked prefix of 'platform/gtk'.
- platform/gtk/Skipped:
- 3:47 AM Changeset in webkit [69755] by
-
- 9 edits3 adds in trunk
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273
Add support for "currentColor" in CanvasRenderingContext2D APIs.
If the canvas is in-document, "currentColor" is replaced by canvas.style.color,
otherwise we use fully opaque black.
For gradient addColorStop(), "currentColor" always means fully opaque black.
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext
Test: fast/canvas/canvas-currentColor.html
- html/canvas/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::setShadowColor): (WebCore::CanvasRenderingContext2D::setShadow):
- html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::currentColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::CanvasStyle): (WebCore::CanvasStyle::createFromString): (WebCore::CanvasStyle::createFromStringWithOverrideAlpha): (WebCore::CanvasStyle::isEquivalentColor): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
- html/canvas/CanvasStyle.h: (WebCore::CanvasStyle::isCurrentColor): (WebCore::CanvasStyle::hasOverrideAlpha): (WebCore::CanvasStyle::overrideAlpha):
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273
Added test to verify support for "currentColor" value in CanvasRenderingContext2D.
Also unskipped 3 tests which now pass:
- canvas/philip/tests/2d.fillStyle.parse.current.basic.html
- canvas/philip/tests/2d.fillStyle.parse.current.changed.html
- canvas/philip/tests/2d.fillStyle.parse.current.removed.html
Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext
- fast/canvas/canvas-currentColor-expected.txt: Added.
- fast/canvas/canvas-currentColor.html: Added.
- fast/canvas/script-tests/canvas-currentColor.js: Added. (attachCanvasToDocument): (tryLinearGradientColor): (tryRadialGradientColor):
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- 2:20 AM Changeset in webkit [69754] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix after r69749.
- platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
- 2:13 AM Changeset in webkit [69753] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-14 Anton Faern <anton@bladehawke.com>
Reviewed by Csaba Osztrogonác.
https://bugs.webkit.org/show_bug.cgi?id=47658
NetBSD was not included in the WTF_PLATFORM_FOO to WTF_OS_FOO
change. This means that OS(NETBSD) is also undefined.
- wtf/Platform.h: s/_PLATFORM_/_OS_/ for NetBSD
- 1:42 AM Changeset in webkit [69752] by
-
- 4 edits2 adds in trunk
2010-10-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358
Test: inspector/debugger-eval-on-call-frame.html
- inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): don't embrace expression evaluated in the local scope of a call frame into with(window) to avoid shadowing local variables by global ones.
2010-10-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358
- inspector/debugger-eval-on-call-frame-expected.txt: Added.
- inspector/debugger-eval-on-call-frame.html: Added.
- 1:39 AM Changeset in webkit [69751] by
-
- 2 edits in trunk/LayoutTests
2010-10-14 Hayato Ito <hayato@chromium.org>
Unreviewed, build fix.
Skip a test that does not have an expected result.
- platform/gtk/Skipped:
- 1:18 AM Changeset in webkit [69750] by
-
- 3 edits in trunk/LayoutTests
2010-10-14 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393
Re-enable this test since the debugString() discrepancy issue
disappeared with <http://trac.webkit.org/changeset/69386>
- platform/mac-tiger/Skipped:
- platform/win/Skipped:
- 1:02 AM Changeset in webkit [69749] by
-
- 14 edits4 adds in trunk
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement getParameter from the URL API
https://bugs.webkit.org/show_bug.cgi?id=46610
Test various interesting cases in parameter parsing.
- fast/dom/anchor-getParameter-expected.txt: Added.
- fast/dom/anchor-getParameter.html: Added.
- http/tests/misc/location-getParameter-expected.txt: Added.
- http/tests/misc/location-getParameter.html: Added.
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Implement getParameter from the URL API
https://bugs.webkit.org/show_bug.cgi?id=46610
Another API from
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en#
getParameter lets a web site easily read the value of a URL parameter.
This API is for the simple case of a non-repeated parameter name.
getParameterAll will handle repeated parameter names in a future patch.
Tests: fast/dom/anchor-getParameter.html
http/tests/misc/location-getParameter.html
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::getParameter):
- html/HTMLAnchorElement.h:
- html/HTMLAnchorElement.idl:
- page/Location.cpp: (WebCore::Location::getParameter):
- page/Location.h:
- page/Location.idl:
- platform/KURL.cpp: (WebCore::KURL::copyParsedQueryTo):
- platform/KURLGoogle.cpp: (WebCore::KURL::copyParsedQueryTo):
- platform/KURL.h:
- 12:53 AM Changeset in webkit [69748] by
-
- 2 edits in trunk/WebCore
2010-10-14 Alejandro G. Castro <alex@igalia.com>
Unreviewed. GTK build fix.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
- 12:18 AM Changeset in webkit [69747] by
-
- 8 edits6 adds in trunk
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 12:10 AM Changeset in webkit [69746] by
-
- 1 edit2 adds in trunk/WebCore
2010-10-14 Chris Rogers <crogers@google.com>
Reviewed by Chris Fleizach.
Add DelayDSPKernel files
https://bugs.webkit.org/show_bug.cgi?id=47518
No new tests since audio API is not yet implemented.
- webaudio/DelayDSPKernel.cpp: Added. (WebCore::DelayDSPKernel::DelayDSPKernel): (WebCore::DelayDSPKernel::process): (WebCore::DelayDSPKernel::reset):
- webaudio/DelayDSPKernel.h: Added. (WebCore::DelayDSPKernel::maxDelayTime): (WebCore::DelayDSPKernel::setDelayFrames): (WebCore::DelayDSPKernel::delayProcessor):
Oct 13, 2010:
- 11:58 PM Changeset in webkit [69745] by
-
- 8 edits in trunk/LayoutTests
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Sync tests from html5lib.
https://bugs.webkit.org/show_bug.cgi?id=47627
- html5lib/resources/adoption02.dat: Copied from html5lib.
- html5lib/resources/entities01.dat: Ditto.
- html5lib/resources/pending-spec-changes.dat: Ditto.
- html5lib/resources/tests21.dat: Ditto.
- html5lib/runner-expected.txt: 2 tests now pass.
- platform/chromium/html5lib/runner-expected.txt: Ditto.
- platform/win/html5lib/runner-expected.txt: Ditto.
- 11:55 PM Changeset in webkit [69744] by
-
- 4 edits in trunk/WebKitTools
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
beat diff_parser with the ugly stick
https://bugs.webkit.org/show_bug.cgi?id=47626
- Scripts/webkitpy/common/checkout/diff_parser.py:
- Scripts/webkitpy/style/patchreader.py:
- Scripts/webkitpy/style/patchreader_unittest.py:
- 11:45 PM Changeset in webkit [69743] by
-
- 5 edits in trunk/JavaScriptCore
2010-10-13 David Goodwin <david_goodwin@apple.com>
Reviewed by Oliver Hunt.
ARMv7 JIT should generated conditional branches when possible
https://bugs.webkit.org/show_bug.cgi?id=47384
Use different jump padding sizes for conditional and unconditional
jumps (12 bytes and 10 bytes respectively). This allows the JIT to
include the IT instruction as part of the conditional jump sequence
which in turn allows it to optimize away the IT using an ARMv7
conditional branch instruction. Use 2-byte B(T1) and 4-byte B(T3) for
conditional branches when displacement is in range. Also use IT/B(T4)
for conditional branch when displacement does not fit in B(T3).
For unconditional jump, instruction selection options are:
B(T2), B(T4), MOVW/MOVT/BX. For conditional jump, instruction selection
options are: B(T1), B(T3), IT/B(T4), ITTT/MOVW/MOVT/BX.
- assembler/ARMv7Assembler.cpp:
- assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpSrc::JmpSrc): (JSC::ARMv7Assembler::ifThenElse): (JSC::ARMv7Assembler::jumpSizeDelta): (JSC::ARMv7Assembler::canCompact): (JSC::ARMv7Assembler::computeJumpType): (JSC::ARMv7Assembler::link): (JSC::ARMv7Assembler::canBeJumpT1): (JSC::ARMv7Assembler::canBeJumpT3): (JSC::ARMv7Assembler::canBeJumpT4): (JSC::ARMv7Assembler::linkJumpT1): (JSC::ARMv7Assembler::linkJumpT3): (JSC::ARMv7Assembler::linkJumpT4): (JSC::ARMv7Assembler::linkConditionalJumpT4): (JSC::ARMv7Assembler::linkBX): (JSC::ARMv7Assembler::linkConditionalBX): (JSC::ARMv7Assembler::linkJumpAbsolute):
- assembler/LinkBuffer.h: (JSC::LinkBuffer::linkCode):
- assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::canCompact): (JSC::MacroAssemblerARMv7::computeJumpType): (JSC::MacroAssemblerARMv7::jumpSizeDelta): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch):
- 11:32 PM Changeset in webkit [69742] by
-
- 7 edits in trunk
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
WebKitGtk+ to use the new API from the imported SoupURILoader code
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
ResourceHandleSoup now does everything via SoupURILoader. This means
that all URLs are handled via the same code path, where WebCore simply
asks libsoup for a WebKitSoupRequest and the request returns an input
stream. Many of ResourceHandleSoup's data members are now PlatformRefPtr
as well, to simplify reference counting
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::restartedCallback): (WebCore::gotChunkCallback): (WebCore::parseDataUrl): (WebCore::cleanupSoupRequestOperation): (WebCore::sendRequestCallback): (WebCore::startHttp): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::closeCallback): (WebCore::readCallback): (WebCore::startGio):
- platform/network/soup/ResourceRequest.h:
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessage):
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
WebKitGtk+ to use the new API from the imported SoupURILoader code
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
ResourceHandleInternal m_msg is now called m_soupMessage.
- webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
- 11:28 PM Changeset in webkit [69741] by
-
- 3 edits in trunk/LayoutTests
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Rebaseline canvas/philip/tests/2d.gradient.radial.negative.html. It seems
that the result for this test is only differing by two newlines. Also skip
a failing test on GTK+.
- canvas/philip/tests/2d.gradient.radial.negative-expected.txt: Rebaseline.
- platform/gtk/Skipped: Skip failing test.
- 10:54 PM Changeset in webkit [69740] by
-
- 3 edits2 adds in trunk/WebKitTools
2010-10-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Break LayoutTestResults out into its own file
https://bugs.webkit.org/show_bug.cgi?id=47637
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- Scripts/webkitpy/common/net/layouttestresults.py: Added.
- Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
- 10:49 PM Changeset in webkit [69739] by
-
- 2 edits7 adds in trunk/LayoutTests
2010-10-13 Shinichiro Hamaji <hamaji@chromium.org>
Update chromium's test expectations.
- platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
- platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
- platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
- platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
- platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
- platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
- platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 10:28 PM Changeset in webkit [69738] by
-
- 3 edits in trunk/WebKitTools
2010-10-13 Adam Barth <abarth@webkit.org>
Unreviewed.
Chromium port can't run JavaScriptCore tests
https://bugs.webkit.org/show_bug.cgi?id=47654
This lets webkit-patch build-and-test work on Chromium.
- Scripts/webkitpy/common/config/ports.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- 10:04 PM Changeset in webkit [69737] by
-
- 9 edits in trunk/WebKitTools
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make --port a global option and pass the port information to the commit-queue subprocess
https://bugs.webkit.org/show_bug.cgi?id=47650
This patch paves the way to run the commit-queue on a non-Mac port.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/commands/queuestest.py:
- Scripts/webkitpy/tool/main.py:
- Scripts/webkitpy/tool/steps/options.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/update.py:
- 10:00 PM Changeset in webkit [69736] by
-
- 3 edits in trunk/WebKitTools
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Introduce the ChromiumXVFBPort for running commit-queue on EC2
https://bugs.webkit.org/show_bug.cgi?id=47653
I'm not entirely sure this is the best way to do this, but we need to
run the tests under XVFB on EC2 because the EC2 instances don't have a
real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
that way. The idea is that XVFB is like a platform for the Chromium
port, but we don't have a real notion of platform separate from port.
- Scripts/webkitpy/common/config/ports.py:
- 9:55 PM Changeset in webkit [69735] by
-
- 3 edits2 adds in trunk
2010-10-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Prevent block logical height of a root inline box from overflowing by clamping it
at INT_MAX. Otherwise, we will not be able to properly dirty the set of lines during
removal a floating object.
https://bugs.webkit.org/show_bug.cgi?id=45611
Test: fast/overflow/overflow-block-logical-height-crash.html
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection):
2010-10-12 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Adler.
Tests that overflowing the block logical height of a root inline box does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=45611
- fast/overflow/overflow-block-logical-height-crash-expected.txt: Added.
- fast/overflow/overflow-block-logical-height-crash.html: Added.
- 9:11 PM Changeset in webkit [69734] by
-
- 3 edits in trunk/WebKit2
Memory smasher in WebKit2 InjectedBundleHitTestResult::absoluteLinkURL
https://bugs.webkit.org/show_bug.cgi?id=47648
Reviewed by Jon Honeycutt.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::absoluteLinkURL):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: Return a String instead of
a const String&.
- 9:11 PM Changeset in webkit [69733] by
-
- 2 edits in trunk/WebKit2
PlatformMouseEvents need to contain modifier flags
https://bugs.webkit.org/show_bug.cgi?id=47651
Reviewed by Jon Honeycutt.
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
Fill in m_modifierFlags.
- 7:40 PM Changeset in webkit [69732] by
-
- 5 edits in branches/safari-533.19-branch
Versioning.
- 7:36 PM Changeset in webkit [69731] by
-
- 1 copy in tags/Safari-533.19.3
New tag.
- 7:31 PM Changeset in webkit [69730] by
-
- 4 edits in branches/safari-533.19-branch/WebCore
Merge r69596.
- 7:31 PM Changeset in webkit [69729] by
-
- 5 edits in branches/safari-533.19-branch
Versioning.
- 7:16 PM Changeset in webkit [69728] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-13 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Darin Adler.
Don't depend on Windows on sched_yield and sched.h
https://bugs.webkit.org/show_bug.cgi?id=45543
sched.h is part of pthreads and sched_yield is implemented
in pthreads-win32 as Sleep(0). This patch avoids a gratuitous
dependency on pthreads-win32 in this file.
- wtf/TCSpinLock.h: (TCMalloc_SlowLock):
- 7:13 PM Changeset in webkit [69727] by
-
- 7 edits in trunk
2010-09-23 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Canvas: radialGradient with negative radius should throw exception
https://bugs.webkit.org/show_bug.cgi?id=37176
Remove test from skipped lists now that it passes.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
2010-10-13 James Robinson <jamesr@chromium.org>
Reviewed by Darin Adler.
Throw INDEX_SIZE_ERR exception if createRadialGradient is called with a negative radius
Canvas: radialGradient with negative radius should throw exception
https://bugs.webkit.org/show_bug.cgi?id=37176
This matches the canvas 2d specification, Opera, IE9 beta and our behavior for arc()
and arcTo(). Also fixes some PassRefPtr/RefPtr errors in this file.
Test: canvas/philip/tests/2d.gradient.radial.negative.html
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createLinearGradient): (WebCore::CanvasRenderingContext2D::createRadialGradient): (WebCore::createEmptyImageData): (WebCore::CanvasRenderingContext2D::measureText):
- 7:03 PM Changeset in webkit [69726] by
-
- 2 edits in trunk/WebCore
2010-10-13 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Darin Adler.
Add WebCore/plugins/win directory to CFLAGS
https://bugs.webkit.org/show_bug.cgi?id=45547
- GNUmakefile.am:
- 6:30 PM Changeset in webkit [69725] by
-
- 2 edits in trunk/WebCore
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Build fix for older versions of libsoup.
- platform/network/soup/cache/soup-request-file.c: (webkit_soup_request_file_ensure_file): Access the path member of the SoupURI directly.
- 6:26 PM WebKit Team edited by
- (diff)
- 6:12 PM WebKit Team edited by
- Add DRT/Chromium to tkent's area (diff)
- 6:08 PM Changeset in webkit [69724] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-13 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
[Chromium] Enable FILE_SYSTEM by default for chromium
https://bugs.webkit.org/show_bug.cgi?id=47639
- features.gypi: Add FILE_SYSTEM=1. Also remove FILE_READER=1 as it seems to be not used anymore.
- 6:01 PM Changeset in webkit [69723] by
-
- 3 edits3 adds in trunk/JavaScriptCore
[BREWMP] Port unicode
https://bugs.webkit.org/show_bug.cgi?id=45716
Reviewed by Kent Tamura.
Brew MP port uses only the subset of ICU library to reduce the binary size.
Follow the WinCE's implementation.
- wtf/Platform.h:
- wtf/unicode/Unicode.h:
- wtf/unicode/brew/UnicodeBrew.cpp: Added.
(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::foldCase):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isUpper):
(WTF::Unicode::isLower):
(WTF::Unicode::isDigit):
(WTF::Unicode::isPunct):
(WTF::Unicode::isAlphanumeric):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::direction):
(WTF::Unicode::category):
(WTF::Unicode::decompositionType):
(WTF::Unicode::combiningClass):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::digitValue):
(WTF::Unicode::isSpace):
(WTF::Unicode::isLetter):
- wtf/unicode/brew/UnicodeBrew.h: Added.
(WTF::Unicode::isArabicChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic):
(WTF::Unicode::umemcasecmp):
- 5:59 PM WebKit Team edited by
- Add Yuta Kitamura (yutak). (diff)
- 5:49 PM Changeset in webkit [69722] by
-
- 1 edit2 adds in trunk/WebCore
[BREWMP] Add TextBoundaries and TextBreakIterator
https://bugs.webkit.org/show_bug.cgi?id=46105
Reviewed by Kent Tamura.
Copy the implementation of WinCE port.
- platform/text/brew/TextBoundariesBrew.cpp: Added.
(WebCore::findNextWordFromIndex):
(WebCore::findWordBoundary):
- platform/text/brew/TextBreakIteratorBrew.cpp: Added.
(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::TextBreakIterator::reset):
(WebCore::TextBreakIterator::following):
(WebCore::TextBreakIterator::preceding):
(WebCore::WordBreakIterator::first):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):
(WebCore::CharBreakIterator::first):
(WebCore::CharBreakIterator::next):
(WebCore::CharBreakIterator::previous):
(WebCore::LineBreakIterator::first):
(WebCore::LineBreakIterator::next):
(WebCore::LineBreakIterator::previous):
(WebCore::SentenceBreakIterator::first):
(WebCore::SentenceBreakIterator::next):
(WebCore::SentenceBreakIterator::previous):
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):
(WebCore::textBreakFirst):
(WebCore::textBreakNext):
(WebCore::textBreakPreceding):
(WebCore::textBreakFollowing):
(WebCore::textBreakCurrent):
(WebCore::isTextBreak):
(WebCore::cursorMovementIterator):
- 5:39 PM Changeset in webkit [69721] by
-
- 57 edits in trunk
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.
- storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
- storage/IDBCursor.h: (WebCore::IDBCursor::continueFunction):
- storage/IDBCursor.idl:
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
- storage/IDBCursorBackendImpl.h:
- storage/IDBCursorBackendInterface.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactory.h: (WebCore::IDBFactory::open):
- storage/IDBFactory.idl:
- storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
- storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
- storage/IDBIndex.idl:
- storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
- storage/IDBIndexBackendImpl.h:
- storage/IDBIndexBackendInterface.h:
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
- storage/IDBTransaction.h:
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::objectStore):
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
- public/WebIDBCursor.h:
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- public/WebIDBObjectStore.h:
- public/WebIDBTransactionCallbacks.h:
- src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
- src/IDBCursorBackendProxy.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction):
- src/IDBDatabaseProxy.h:
- src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
- src/IDBIndexBackendProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
- src/IDBObjectStoreProxy.h:
- src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
- src/WebIDBCursorImpl.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::transaction):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
- 5:36 PM Changeset in webkit [69720] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Incorrect use of alternate content inside the <object> element
https://bugs.webkit.org/show_bug.cgi?id=11803
Our current behavior appears to match Firefox and the spec. Opera
seems to do what the bug reporter requests, but our current behavior
seems more sane.
- fast/forms/fallback-content-submission-expected.txt: Added.
- fast/forms/fallback-content-submission.html: Added.
- fast/parser/object-with-textarea-fallback-expected.txt: Added.
- fast/parser/object-with-textarea-fallback.html: Added.
- 5:32 PM Changeset in webkit [69719] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-13 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634
- src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
- 5:32 PM Changeset in webkit [69718] by
-
- 7 edits19 adds in trunk
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
This patch adds HTTP caching support to libsoup networking backend.
This code will eventually be part of libsoup, but has been temporarily
imported into the WebCore tree for testing purposes. All libsoup code
is located in WebCore/platform/network/soup/cache. The webkit prefix
was added to all the symbols to prevent problems when this lands in
libsoup. Some external API was also added under webkit/ directory and
will be used by library clients to enable HTTP caching.
There are two parts to this imported code, the first one is the code
under WebCore/platform/network/soup/cache/ that contains all the
SoupURILoader code that supports the development of the cache. The
second part is the HTTP cache implementation located in
WebCore/platform/network/soup/cache/webkit/.
- GNUmakefile.am:
- platform/network/soup/cache/soup-directory-input-stream.c: Added. (webkit_soup_directory_input_stream_parse_info): (webkit_soup_directory_input_stream_read_next_file): (webkit_soup_directory_input_stream_read): (webkit_soup_directory_input_stream_close): (webkit_soup_directory_input_stream_class_init): (webkit_soup_directory_input_stream_init): (webkit_soup_directory_input_stream_new):
- platform/network/soup/cache/soup-directory-input-stream.h: Added.
- platform/network/soup/cache/soup-http-input-stream.c: Added. (webkit_soup_http_input_stream_finalize): (webkit_soup_http_input_stream_class_init): (webkit_soup_http_input_stream_seekable_iface_init): (webkit_soup_http_input_stream_init): (webkit_soup_http_input_stream_queue_message): (webkit_soup_http_input_stream_new): (webkit_soup_http_input_stream_got_headers): (webkit_soup_http_input_stream_got_chunk): (webkit_soup_http_input_stream_finished): (webkit_soup_http_input_stream_cancelled): (webkit_soup_http_input_stream_prepare_for_io): (webkit_soup_http_input_stream_done_io): (set_error_if_http_failed): (read_from_leftover): (webkit_soup_http_input_stream_send_internal): (send_sync_finished): (webkit_soup_http_input_stream_send): (webkit_soup_http_input_stream_read): (webkit_soup_http_input_stream_close): (wrapper_callback): (send_async_thread): (webkit_soup_http_input_stream_send_async_in_thread): (send_async_finished): (webkit_soup_http_input_stream_send_async_internal): (webkit_soup_http_input_stream_send_async): (webkit_soup_http_input_stream_send_finish): (read_async_done): (webkit_soup_http_input_stream_read_async): (webkit_soup_http_input_stream_read_finish): (webkit_soup_http_input_stream_close_async): (webkit_soup_http_input_stream_close_finish): (webkit_soup_http_input_stream_tell): (webkit_soup_http_input_stream_can_seek): (webkit_soup_http_input_stream_seek): (webkit_soup_http_input_stream_can_truncate): (webkit_soup_http_input_stream_truncate): (webkit_soup_http_input_stream_get_message):
- platform/network/soup/cache/soup-http-input-stream.h: Added.
- platform/network/soup/cache/soup-request-data.c: Added. (webkit_soup_request_data_init): (webkit_soup_request_data_finalize): (webkit_soup_request_data_check_uri): (uri_decoded_copy): (webkit_soup_request_data_send): (webkit_soup_request_data_get_content_length): (webkit_soup_request_data_get_content_type): (webkit_soup_request_data_class_init):
- platform/network/soup/cache/soup-request-data.h: Added.
- platform/network/soup/cache/soup-request-file.c: Added. (webkit_soup_request_file_get_file): (webkit_soup_request_file_init): (webkit_soup_request_file_finalize): (webkit_soup_request_file_check_uri): (webkit_soup_request_file_ftp_main_loop_quit): (webkit_soup_request_file_ensure_file_ftp): (webkit_soup_request_file_ensure_file): (webkit_soup_request_file_send): (webkit_soup_request_file_send_async_thread): (webkit_soup_request_file_send_async): (webkit_soup_request_file_send_finish): (webkit_soup_request_file_get_content_length): (webkit_soup_request_file_get_content_type): (webkit_soup_request_file_class_init):
- platform/network/soup/cache/soup-request-file.h: Added.
- platform/network/soup/cache/soup-request-http.c: Added. (webkit_soup_request_http_get_message): (webkit_soup_request_http_init): (webkit_soup_request_http_check_uri): (webkit_soup_request_http_finalize): (webkit_soup_request_http_send): (sent_async): (conditional_get_ready_cb): (send_async_cb): (webkit_soup_request_http_send_async): (webkit_soup_request_http_send_finish): (webkit_soup_request_http_get_content_length): (webkit_soup_request_http_get_content_type): (webkit_soup_request_http_class_init):
- platform/network/soup/cache/soup-request-http.h: Added.
- platform/network/soup/cache/soup-request.c: Added. (webkit_soup_request_init): (webkit_soup_request_finalize): (webkit_soup_request_set_property): (webkit_soup_request_get_property): (webkit_soup_request_initable_init): (webkit_soup_request_default_check_uri): (webkit_soup_request_default_send_async): (webkit_soup_request_default_send_finish): (webkit_soup_request_send): (webkit_soup_request_send_async): (webkit_soup_request_send_finish): (webkit_soup_request_class_init): (webkit_soup_request_initable_interface_init): (webkit_soup_request_get_uri): (webkit_soup_request_get_session): (webkit_soup_request_get_content_length): (webkit_soup_request_get_content_type):
- platform/network/soup/cache/soup-request.h: Added.
- platform/network/soup/cache/soup-requester.c: Added. (webkit_soup_requester_init): (finalize): (webkit_soup_requester_class_init): (init_request_types): (webkit_soup_requester_new): (webkit_soup_requester_request): (webkit_soup_requester_request_uri): (webkit_soup_scheme_is_valid): (webkit_soup_requester_add_protocol): (webkit_soup_requester_remove_protocol): (webkit_soup_error_quark):
- platform/network/soup/cache/soup-requester.h: Added.
- platform/network/soup/cache/webkit/soup-cache-private.h: Added.
- platform/network/soup/cache/webkit/soup-cache.c: Added. (get_cacheability): (webkit_soup_cache_entry_free): (copy_headers): (update_headers): (webkit_soup_cache_entry_get_current_age): (webkit_soup_cache_entry_is_fresh_enough): (webkit_soup_message_get_cache_key): (webkit_soup_cache_entry_set_freshness): (webkit_soup_cache_entry_new): (webkit_soup_cache_writing_fixture_free): (close_ready_cb): (write_ready_cb): (msg_got_chunk_cb): (msg_got_body_cb): (webkit_soup_cache_entry_delete): (lru_compare_func): (cache_accepts_entries_of_size): (make_room_for_new_entry): (webkit_soup_cache_entry_insert_by_key): (msg_restarted_cb): (append_to_ready_cb): (msg_got_headers_cb): (webkit_soup_cache_send_response): (request_started): (attach): (webkit_soup_cache_session_feature_init): (webkit_soup_cache_init): (webkit_soup_cache_finalize): (webkit_soup_cache_set_property): (webkit_soup_cache_get_property): (webkit_soup_cache_constructed): (webkit_soup_cache_type_get_type): (webkit_soup_cache_class_init): (webkit_soup_cache_new): (webkit_soup_cache_has_response): (webkit_soup_cache_get_cacheability): (force_flush_timeout): (webkit_soup_cache_flush): (remove_cache_item): (webkit_soup_cache_clear): (webkit_soup_cache_generate_conditional_request): (pack_entry): (webkit_soup_cache_dump): (webkit_soup_cache_load): (webkit_soup_cache_set_max_size): (webkit_soup_cache_get_max_size):
- platform/network/soup/cache/webkit/soup-cache.h: Added.
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
Bump the required version of GLib. The serialization/deserialization
code of libsoup caching code uses GVariant, which was added to GLib in
version 2.24.
- GNUmakefile.am: Add paths for soup HTTP cache code.
- autotools/webkit.m4: Increase required glib version.
2010-10-13 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add HTTP caching support
https://bugs.webkit.org/show_bug.cgi?id=44261
Add include paths for the new soup HTTP cache code.
- GNUmakefile.am: Add paths for the new soup HTTP cache code.
- 5:27 PM Changeset in webkit [69717] by
-
- 2 edits in trunk/WebCore
Chromium build fix.
- bindings/v8/ScriptProfiler.cpp:
- 5:21 PM Changeset in webkit [69716] by
-
- 4 edits2 adds in trunk
2010-10-13 Chris Evans <cevans@google.com>
Reviewed by Jian Li.
Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows
https://bugs.webkit.org/show_bug.cgi?id=47382
Add test for Blob.slice() integer overflow.
- fast/files/blob-slice-overflow.html: Added.
- fast/files/blob-slice-overflow-expected.txt: Added.
2010-10-13 Chris Evans <cevans@google.com>
Reviewed by Jian Li.
Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows
https://bugs.webkit.org/show_bug.cgi?id=47382
Fix integer overflow errors in Blob.slice and BlobBuilder.append.
Test: fast/files/blob-slice-overflow.html
- fileapi/Blob.cpp: (WebCore::Blob::slice): handle integer overflow properly.
- fileapi/BlobBuilder.cpp: (WebCore::BlobBuilder::append): use correct type for vector length.
- 5:16 PM Changeset in webkit [69715] by
-
- 4 edits in trunk/WebCore
Build fix - remove some redundant references to ScriptString.
- WebCore.gypi:
- WebCore.pro:
- bindings/v8/ScriptProfiler.cpp:
- 4:58 PM Changeset in webkit [69714] by
-
- 2 edits in trunk/WebKitTools
2010-10-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[Qt] QtTestBrowser shows two Url input fields
https://bugs.webkit.org/show_bug.cgi?id=47613
- QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI):
- 4:42 PM Changeset in webkit [69713] by
-
- 2 edits in trunk/WebKitTools
2010-10-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tony Chang.
[gdb] Add pretty-print supports for UString, Identifier and JSString
https://bugs.webkit.org/show_bug.cgi?id=47601
- gdb/webkit.py:
- 4:34 PM Changeset in webkit [69712] by
-
- 4 edits3 deletes in trunk/WebCore
Bug 47621 - Remove bindings/v8/ScriptString
This is now redundant.
Reviewed by Oliver Hunt.
- bindings/v8/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::functionName):
- bindings/v8/ScriptFunctionCall.cpp:
- bindings/v8/ScriptFunctionCall.h:
- bindings/v8/ScriptString.h: Removed.
- bindings/v8/ScriptStringImpl.cpp: Removed.
- bindings/v8/ScriptStringImpl.h: Removed.
- 4:12 PM Changeset in webkit [69711] by
-
- 4 edits in trunk
Draw the find overlay holes
https://bugs.webkit.org/show_bug.cgi?id=47631
Reviewed by John Sullivan.
WebCore:
Export symbols needed by WebKit2.
- WebCore.exp.in:
WebKit2:
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::drawRect):
Draw the white frames and the holes.
- 4:10 PM Changeset in webkit [69710] by
-
- 7 edits in trunk
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Adler.
Implement onreadystatechange event handler for Documents
https://bugs.webkit.org/show_bug.cgi?id=26140
- fast/dom/Document/readystate-expected.txt:
- fast/dom/Document/readystate.html:
2010-10-13 James Simonsen <simonjam@chromium.org>
Reviewed by Darin Adler.
Implement onreadystatechange event handler for Documents
https://bugs.webkit.org/show_bug.cgi?id=26140
Test: fast/dom/Document/readystate.html
- dom/Document.cpp: (WebCore::Document::setReadyState): Fire readystatechangeevent. (WebCore::Document::open): Clear event listeners.
- dom/Document.h: Add readystatechange event.
- dom/Document.idl: Ditto.
- 4:07 PM Changeset in webkit [69709] by
-
- 3 edits in trunk/LayoutTests
No review. Fix layout test, now that behavior is correct.
AX: accessibilityIsIgnored not respected on ARIA tables
https://bugs.webkit.org/show_bug.cgi?id=47564
- accessibility/aria-hidden-with-elements-expected.txt:
- accessibility/aria-hidden-with-elements.html:
- 4:03 PM Changeset in webkit [69708] by
-
- 2 edits in trunk/WebKitTools/EWSTools
Mark these scripts executable
- 3:53 PM Changeset in webkit [69707] by
-
- 3 edits1 add in trunk
AX: accessibilityIsIgnored not respected on ARIA tables
https://bugs.webkit.org/show_bug.cgi?id=47564
Reviewed by Beth Dakin.
WebCore:
For platforms that ignore column headers and header container objects (everything
except Mac) on accessibility tables, that choice needs to be respected in
ARIA tables as well.
GTK is the only open platform doing this, so I'll have to collect the result of this
test. It was copied from table-hierarchy.html, but changed to use ARIA tables.
Test: platform/gtk/accessibility/aria-table-hierarchy.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChildren):
LayoutTests:
Will gather the results from GTK after this runs.
- platform/gtk/accessibility/aria-table-hierarchy.html: Added.
- 3:50 PM Changeset in webkit [69706] by
-
- 2 edits in trunk/WebCore
No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
https://bugs.webkit.org/show_bug.cgi?id=47432
Patch by Victoria Kirst <vrk@google.com> on 2010-10-13
Reviewed by James Robinson.
- platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::cleanupResources):
- 3:48 PM Changeset in webkit [69705] by
-
- 1 edit1 add in trunk/WebKitTools
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add list of Ubuntu packages needed by the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47628
I've been copy/pasting this list between bots, but it's better to have
this checked in.
- EWSTools/ubuntu-ews-packages: Added.
- 3:46 PM Changeset in webkit [69704] by
-
- 5 edits in trunk
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix.
- WebCoreSupport/FrameLoaderClientEfl.h: Use String instead of WebCore::String.
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix.
- CMakeLists.txt: Add ContextShadow.cpp.
- CMakeListsEfl.txt: Add ContextShadowCairo.cpp.
- 3:39 PM Changeset in webkit [69703] by
-
- 3 edits in trunk/WebKitTools
2010-10-13 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Csaba Osztrogonác.
[EFL] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=47290
- BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the EFL port.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the EFL port.
- 3:25 PM Changeset in webkit [69702] by
-
- 3 edits in trunk/LayoutTests
2010-10-13 Zhenyao Mo <zmo@google.com>
Unreviewed, update WebGL test expectations.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 3:24 PM Changeset in webkit [69701] by
-
- 2 edits in trunk/WebCore
2010-10-13 Martin Robinson <mrobinson@igalia.com>
Reviewed by Holger Freyther.
[GTK] r69681 caused some tests to crash
https://bugs.webkit.org/show_bug.cgi?id=47622
Properly initialize m_layerContext on the ContextShadow so that in situations
where beginShadowLayer bails out early with a null return value, it is set
to null. This may happen when the first call to beginShadowLayer on a particular
ContextShadow uses a region which is entirely outside the clip region or which
is empty.
- platform/graphics/cairo/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): Properly initialize m_layerContext.
- 2:44 PM Changeset in webkit [69700] by
-
- 2 edits in trunk/WebCore
Don't set the fill/stroke colorspace before filling/stroking
https://bugs.webkit.org/show_bug.cgi?id=47619
Reviewed by Beth Dakin.
Setting the colorspace has the side-effect of setting the color to black, which is
not what we want. When fill/stroke is called, a fill/stroke color should already have been set.
Pixel tests show no regressions from this change.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
- 2:29 PM Changeset in webkit [69699] by
-
- 3 edits in trunk/WebCore
Unreviewed WinCairo build fix.
New ContextShadow class not built for Windows builds.
- WebCore.vcproj/WebCore.vcproj: Add missing files for
building ContextShadow on WinCairo.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
Add missing include for ContextShadow definition.
- 2:19 PM Changeset in webkit [69698] by
-
- 5 edits1 delete in branches/chromium/552
Merge 69586 - 2010-10-12 Dave Moore <davemoore@chromium.org>
Reviewed by Tony Chang.
Use new WebThemeEngine api on chromium / linux to draw scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=47473
- platform/chromium/ChromiumBridge.h:
- platform/chromium/ScrollbarThemeChromiumLinux.cpp:
2010-10-12 Dave Moore <davemoore@chromium.org>
Reviewed by Tony Chang.
Use new WebThemeEngine api on chromium / linux to draw scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=47473
- public/WebThemeEngine.h: Removed.
- chromium/src/ChromiumBridge.cpp:
- 2:19 PM Changeset in webkit [69697] by
-
- 3 edits in trunk/LayoutTests
2010-10-13 Nate Chapin <Nate Chapin>
Unreviewed, Chromium expectations update.
Fix line endings in a couple of inspector test expectations.
- platform/chromium/inspector/console-trace-in-eval-expected.txt:
- platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
- 2:02 PM Changeset in webkit [69696] by
-
- 2 edits in branches/chromium/552/WebKitTools
Merge 69591 - 2010-10-12 Tony Chang <tony@chromium.org>
Unreviewed, fixing DRT compile on Windows after r69586.
- DumpRenderTree/chromium/WebThemeEngineDRT.h:
- 1:51 PM Changeset in webkit [69695] by
-
- 2 edits in trunk/WebCore
Chromium build fix pt1.
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
- 1:40 PM Changeset in webkit [69694] by
-
- 4 edits in trunk/WebKit2
Use WKSI to get wheel event deltas
https://bugs.webkit.org/show_bug.cgi?id=47617
Reviewed by Darin Adler.
- Shared/mac/WebEventFactory.mm:
(WebKit::WebEventFactory::createWebWheelEvent):
Call WKGetWheelEventDeltas.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:]):
Call InitWebCoreSystemInterface.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Use dispatch_once.
- 1:29 PM Changeset in webkit [69693] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-13 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Revert changes to WebViewImpl in r69633
https://bugs.webkit.org/show_bug.cgi?id=47610
Revert change to WebViewImpl.cpp in
http://trac.webkit.org/changeset/69633 which incorrectly used
PassRefPtr for a local variable instead of RefPtr. This was a fix
for changes in http://trac.webkit.org/changeset/69619 and
http://trac.webkit.org/changeset/69624 .
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 1:28 PM Changeset in webkit [69692] by
-
- 2 edits2 adds in trunk/WebKit2
Fix the Cairo build
- Shared/cairo/BackingStoreCairo.cpp: Added.
(WebKit::BackingStore::createGraphicsContext):
(WebKit::BackingStore::paint):
Stubbed out.
- win/WebKit2.vcproj: Build BackingStoreCG.cpp in CG builds and
BackingStoreCairo.cpp in Cairo builds.
- 1:24 PM Changeset in webkit [69691] by
-
- 2 edits in trunk/WebKit2
Build fix.
- Shared/cg/BackingStoreCG.cpp:
- 1:20 PM Changeset in webkit [69690] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:18 PM Changeset in webkit [69689] by
-
- 8 edits in trunk
Send over find indicator information to the UI process
https://bugs.webkit.org/show_bug.cgi?id=47612
Reviewed by Sam Weinig.
WebCore:
Export symbols needed by WebKit2.
- WebCore.exp.in:
WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
Add stub.
- UIProcess/WebPageProxy.messages.in:
Add SetFindIndicator.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::FindController):
Initialize m_isShowingFindIndicator.
(WebKit::FindController::findString):
Update the find indicator if needed.
(WebKit::FindController::updateFindIndicator):
Compute find indicator information, paint the find indicator text into a
backing store and send it over.
(WebKit::FindController::resetFindIndicator):
Send a SetFindIndicator message with a null backing store.
- 1:10 PM Changeset in webkit [69688] by
-
- 40 edits1 delete in trunk
https://bugs.webkit.org/show_bug.cgi?id=43987
Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
to construct their internal result string. Remove ScriptString (this is now
redundant).
Reviewed by Oliver Hunt.
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsOwnedStringOrNull):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::responseText):
- bindings/js/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::ScriptCallFrame):
- bindings/js/ScriptCallFrame.h:
(WebCore::ScriptCallFrame::functionName):
- bindings/js/ScriptCallStack.h:
- bindings/js/ScriptFunctionCall.cpp:
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptString.h: Removed.
- dom/ScriptExecutionContext.h:
- fileapi/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::abort):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::result):
(WebCore::FileReader::convertToText):
(WebCore::FileReader::convertToDataURL):
- fileapi/FileReader.h:
- fileapi/FileReaderSync.cpp:
(WebCore::FileReaderSyncLoader::FileReaderSyncLoader):
(WebCore::FileReaderSyncLoader::didReceiveData):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
(WebCore::FileReaderSync::read):
(WebCore::FileReaderSync::convertToText):
- fileapi/FileReaderSync.h:
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::FileReaderSync):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorController::scriptImported):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp:
(WebCore::InspectorResource::setOverrideContent):
- inspector/InspectorResource.h:
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoadNotifier.h:
- workers/WorkerScriptLoader.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::responseText):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::dropProtection):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):
- xml/XMLHttpRequest.h:
WebKit/efl:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceByXMLHttpRequest):
- WebCoreSupport/FrameLoaderClientEfl.h:
WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.cpp:
WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 1:04 PM Changeset in webkit [69687] by
-
- 3 edits1 add in trunk/WebKit2
Add BackingStoreQt.cpp file with stubbed out BackingStore member functions
https://bugs.webkit.org/show_bug.cgi?id=47614
Reviewed by Sam Weinig.
- Shared/BackingStore.h:
Remove unused include.
- Shared/qt/BackingStoreQt.cpp: Added.
(WebKit::BackingStore::createGraphicsContext):
(WebKit::BackingStore::paint):
- WebKit2.pro:
Add BackingStore.cpp, BackingStore.h and BackingStoreQt.cpp
- 1:01 PM Changeset in webkit [69686] by
-
- 2 edits3 adds in trunk/JavaScriptCore
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add URLQueryCanonicalizer
https://bugs.webkit.org/show_bug.cgi?id=45088
This class canonicalizes the query component of URLs. The main tricky
bit there is the convertCharset function, which I've moved to a
templated dependency. There'll likely be more about that in future
patches.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/url/src/URLEscape.cpp: Added.
- wtf/url/src/URLEscape.h: Added. (WTF::appendEscapedCharacter):
- wtf/url/src/URLQueryCanonicalizer.h: Added. (WTF::URLQueryCanonicalizer::canonicalize): (WTF::URLQueryCanonicalizer::isAllASCII): (WTF::URLQueryCanonicalizer::appendRaw8BitQueryString): (WTF::URLQueryCanonicalizer::convertToQueryEncoding):
- 12:54 PM Changeset in webkit [69685] by
-
- 6 edits in trunk/WebKitTools
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Csaba Osztrogonác.
webkit-patch build shouldn't need --build to actually build!
https://bugs.webkit.org/show_bug.cgi?id=47438
Yeah, requiring --build for the build command is really dumb. We did
this originally because the build step is usually optional in other
commands. We don't have a good way of reversing the default for an
option in one command. This approach is slightly hacky since --build
still shows up as an option on the help page, but at least it makes
progress. Passing --build is harmless, so the EWS bots shouldn't
explode because of this change.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 12:38 PM Changeset in webkit [69684] by
-
- 2 edits in trunk/LayoutTests
2010-10-13 Robert Hogan <robert@webkit.org>
Rubber-stamped by Csaba Osztrogonac.
[Qt] editing/execCommand/move-selection-back-line.html fails in DRT
Unskip test that now passes.
- platform/qt/Skipped:
- 12:29 PM Changeset in webkit [69683] by
-
- 19 edits1 add in trunk
JavaScriptCore: Bug 43987 - Downloading using XHR is much slower than before
Change StringBuilder to use overcapacity in a StringImpl, rather than a Vector.
Fundamentally this should be the same (copies current contents to expand capacity,
rather than using a rope), but this approach allows the intermadiate state of the
String to be inspected in the buffer without copying to resolve.
Reviewed by Oliver Hunt.
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::Holder::appendNextProperty):
Renamed StringBuilder::size() -> length() (to match other String types).
- runtime/UStringBuilder.h:
(JSC::UStringBuilder::append):
(JSC::UStringBuilder::toUString):
Update for changes in parent class, can just 'using' the append methods.
- wtf/text/StringBuilder.cpp: Added.
(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::length):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::clear):
Class updated to use overcapacity in a StringImpl, rather than a Vector.
- Android.mk:
- Android.v8.wtf.mk:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/wtf.pri:
WebCore: Bug 43987 - Downloading using XHR is much slower than before
Reviewed by Oliver Hunt.
- svg/SVGPathStringBuilder.cpp:
(WebCore::SVGPathStringBuilder::result):
StringBuilder::size() -> StringBuilder::length().
WebKit/chromium: Bug 43987 - Downloading using XHR is much slower than before
Reviewed by Oliver Hunt.
- src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
- 12:21 PM Changeset in webkit [69682] by
-
- 2 edits in trunk/WebCore
2010-10-13 Yong Li <yoli@rim.com>
Reviewed by Oliver Hunt.
Fix potential misaligned memory access in CloneDeserializer::readLittleEndian and readString
that can result crash on ARM (<v6).
https://bugs.webkit.org/show_bug.cgi?id=47594
No new test added, because the crash can be produced by existing tests like:
LayoutTests/fast/events/message-channel-gc-4.html
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readLittleEndian): (WebCore::CloneDeserializer::readString):
- 12:18 PM Changeset in webkit [69681] by
-
- 63 edits in trunk
2010-09-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Activate ContextShadow in all places where shadows are drawn
https://bugs.webkit.org/show_bug.cgi?id=46475
Rebaselined tests. All these changes seem reasonable. In some cases, the
new results are much better / closer matches to Chromium.
- platform/gtk/fast/box-shadow/basic-shadows-expected.checksum:
- platform/gtk/fast/box-shadow/basic-shadows-expected.png:
- platform/gtk/fast/box-shadow/inset-expected.checksum:
- platform/gtk/fast/box-shadow/inset-expected.png:
- platform/gtk/fast/css/shadow-multiple-expected.checksum:
- platform/gtk/fast/css/shadow-multiple-expected.png:
- platform/gtk/fast/text/shadow-no-blur-expected.checksum:
- platform/gtk/fast/text/shadow-no-blur-expected.png:
- platform/gtk/fast/text/shadow-translucent-fill-expected.checksum:
- platform/gtk/fast/text/shadow-translucent-fill-expected.png:
- platform/gtk/fast/text/stroking-decorations-expected.checksum:
- platform/gtk/fast/text/stroking-decorations-expected.png:
- platform/gtk/fast/text/stroking-expected.checksum:
- platform/gtk/fast/text/stroking-expected.png:
- platform/gtk/fast/transforms/shadows-expected.checksum:
- platform/gtk/fast/transforms/shadows-expected.png:
- platform/gtk/svg/css/arrow-with-shadow-expected.checksum:
- platform/gtk/svg/css/arrow-with-shadow-expected.png:
- platform/gtk/svg/css/composite-shadow-text-expected.checksum:
- platform/gtk/svg/css/composite-shadow-text-expected.png:
- platform/gtk/svg/css/group-with-shadow-expected.checksum:
- platform/gtk/svg/css/group-with-shadow-expected.png:
- platform/gtk/svg/css/path-with-shadow-expected.checksum:
- platform/gtk/svg/css/path-with-shadow-expected.png:
- platform/gtk/svg/css/shadow-with-large-radius-expected.checksum:
- platform/gtk/svg/css/shadow-with-large-radius-expected.png:
- platform/gtk/svg/css/shadow-with-negative-offset-expected.checksum:
- platform/gtk/svg/css/shadow-with-negative-offset-expected.png:
2010-10-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Activate ContextShadow in all places where shadows are drawn
https://bugs.webkit.org/show_bug.cgi?id=46475
Turn on ContextShadow for the Cairo port and remove all old shadow code.
Shadow tiling optimizations will be added in a followup patch to ContextShadowCairo.
- platform/graphics/GraphicsContext.h: Add a ContextShadow forward declaration for Cairo.
- platform/graphics/cairo/FontCairo.cpp: Switch to using ContextShadow. (WebCore::prepareContextForGlyphDrawing): Added this helper which sets up the translation on the specified cairo_t to prepare for drawing glyphs. (WebCore::drawGlyphsToContext): Added this helper which draws the glyphs to a cairo_t, while properly handling glyphs with synthetic bold. (WebCore::Font::drawGlyphs): Removed old shadow code and replaced it with ContextShadow usage.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): Modified this to use ContextShadow and to take an enum argument specifying whether to fill or stroke the solid figure for the shadow. (WebCore::fillCurrentCairoPath): Updated drawPathShadow call. (WebCore::strokeCurrentCairoPath): Ditto. (WebCore::GraphicsContext::savePlatformState): Save the ContextShadow. (WebCore::GraphicsContext::restorePlatformState): Restore the ContextShadow. (WebCore::GraphicsContext::drawPath): Updated drawPathShadow call. (WebCore::GraphicsContext::fillRect): Uses ContextShadow now. (WebCore::GraphicsContext::setPlatformShadow): Uses ContextShadow now. (WebCore::GraphicsContext::contextShadow): Added. (WebCore::GraphicsContext::clearPlatformShadow): Clears the ContextShadow member. (WebCore::GraphicsContext::fillRoundedRect): Updated drawPathShadow call.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::hasShadow): Added.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Updated to use ContextShadow.
- 12:15 PM Changeset in webkit [69680] by
-
- 4 edits in trunk/WebKit2
Unreviewed build fixes after r69538.
- UIProcess/WebBackForwardList.h: Add missing include directive
for CoreFoundation.
- UIProcess/cf/WebBackForwardListCF.cpp: Add missing include
directives for RetainPtr.h and CoreFoundation.
- UIProcess/cf/WebPageProxyCF.cpp: Add missing include directive
for RetainPtr.h.
- 11:50 AM Changeset in webkit [69679] by
-
- 1 edit2 moves in trunk/LayoutTests
2010-10-13 Nate Chapin <Nate Chapin>
Unreviewed, Chromium test fix.
Move a couple of platform-specific results that were added to the wrong directory.
- platform/chromium/console-trace-in-eval-expected.txt: Removed.
- platform/chromium/console-uncaught-exception-in-eval-expected.txt: Removed.
- platform/chromium/inspector/console-trace-in-eval-expected.txt: Copied from LayoutTests/platform/chromium/console-trace-in-eval-expected.txt.
- platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt: Copied from LayoutTests/platform/chromium/console-uncaught-exception-in-eval-expected.txt.
- 11:49 AM Changeset in webkit [69678] by
-
- 4 edits in trunk
Start compiling BackingStore on Windows
Rubber-stamped by Anders Carlsson.
Export tryFastRealloc for WebKit2's benefit
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added
tryFastRealloc. Removed RegExpObject::info, which is now exported via
JS_EXPORTDATA.
WebKit2:
- win/WebKit2.vcproj: Added BackingStore.
- 11:49 AM Changeset in webkit [69677] by
-
- 2 edits1 move1 add in trunk/WebKit2
Rename BackingStoreMac.mm to BackingStoreCG.cpp
There's nothing Mac-specific about this file.
Rubber-stamped by Anders Carlsson.
- Shared/cg/BackingStoreCG.cpp: Renamed from WebKit2/Shared/mac/BackingStoreMac.mm.
- WebKit2.xcodeproj/project.pbxproj: Updated for rename.
- 11:31 AM Changeset in webkit [69676] by
-
- 2 edits in trunk/LayoutTests
2010-10-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69667.
http://trac.webkit.org/changeset/69667
https://bugs.webkit.org/show_bug.cgi?id=47598
"Most of the tests seem to fail in the bots for some reason"
(Requested by xan_ on #webkit).
- platform/gtk/Skipped:
- 11:12 AM Changeset in webkit [69675] by
-
- 3 edits in trunk/WebKit/chromium
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Tony Chang.
[Chromium] Clean up WebPageSerializerImpl::serialize
https://bugs.webkit.org/show_bug.cgi?id=47577
This patch shouldn't have any behavior change. I'm just trying to
understand what this code does.
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer): (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer): (WebKit::WebPageSerializerImpl::serialize):
- src/WebPageSerializerImpl.h:
- 11:10 AM Changeset in webkit [69674] by
-
- 7 edits in trunk/WebKitTools
2010-10-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69638.
http://trac.webkit.org/changeset/69638
https://bugs.webkit.org/show_bug.cgi?id=47595
"Broke win and chromium-win bots" (Requested by dglazkov on
#webkit).
- Scripts/webkitpy/common/system/path.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 11:01 AM Changeset in webkit [69673] by
-
- 12 edits in trunk
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
- WebCore.gyp/WebCore.gyp:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/GeolocationServiceChromium.cpp:
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
- WebKit.gyp:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
- src/ChromiumBridge.cpp:
- src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::createWebGeolocationServiceMock): (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition): (WebKit::WebGeolocationServiceMock::setMockGeolocationError):
2010-10-13 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
https://bugs.webkit.org/show_bug.cgi?id=47586
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 11:01 AM Changeset in webkit [69672] by
-
- 2 edits in trunk/WebKit2
Allow all signals to be delivered to the web process
https://bugs.webkit.org/show_bug.cgi?id=47602
<rdar://problem/8546399>
Reviewed by Sam Weinig.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- 10:40 AM Changeset in webkit [69671] by
-
- 12 edits2 adds in trunk
Let WebCore handle scrolling when the spacebar is pressed on Windows
WebCore already has code to do this, and WebKit2 was doing it on
keydown instead of keypress, which caused problems with text fields.
WebCore's spacebar-handling code is currently compiled out on Mac and
Qt, so we continue to handle spacebar in WebKit2 on those platforms.
Fixes <http://webkit.org/b/47544> <rdar://problem/8540645> REGRESSION:
Pressing spacebar in a text field in WebKit2 does not insert a space,
scrolls the page instead
Test: WebKit2/SpacebarScrolling
Reviewed by Sam Weinig.
WebKit2:
- WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
Removed handling for spacebar presses. WebCore already does this for
us, and does it better.
WebKitTools:
Test that pressing the spacebar in a text field does not scroll the
document
- TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
- TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- TestWebKitAPI/win/copy-resources.cmd:
Added new files.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
We use this to track what the result of calling into JavaScript was.
(TestWebKitAPI::didFinishLoadForFrame): Records when the page
finishes loading.
(TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
event is not handled.
(TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
executing and whether the result matched our expectation.
(TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
(TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
complete, and returns whether we got back the expected result.
(TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
spacebar inside a text field does not scroll the document and that
pressing it outside the text field does scroll the document.
- TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::isKeyDown): Checks the event's type.
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
code from DRT's EventSendingController.
- TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
(TestWebKitAPI::Util::isKeyDown): Checks the message's type.
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
same messages that get sent when you press spacebar in Notepad.
- 10:26 AM Changeset in webkit [69670] by
-
- 2 edits in trunk/WebKit/chromium
2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531
Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- 10:21 AM Changeset in webkit [69669] by
-
- 2 edits2 adds in trunk/JavaScriptCore
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
[WTFURL] Add a mechanism for classifying types of characters
https://bugs.webkit.org/show_bug.cgi?id=45085
Various characters have different escaping rules depending on where
they are in URLs. This patch adds a table containing that information.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/url/src/URLCharacterTypes.cpp: Added.
- wtf/url/src/URLCharacterTypes.h: Added. (WTF::URLCharacterTypes::isQueryChar): (WTF::URLCharacterTypes::isIPv4Char): (WTF::URLCharacterTypes::isHexChar): (WTF::URLCharacterTypes::isCharOfType):
- 9:40 AM Changeset in webkit [69668] by
-
- 3 edits in trunk/WebKit/chromium
2010-10-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
[Chromium] Clean up SerializeDomParam
https://bugs.webkit.org/show_bug.cgi?id=47580
This patch just renames a bunch of the members of this struct to be
more sensible. No behavior change, well, except for one struct member
that wasn't initialized. I didn't trace through this code to see if
the uninitialized value was used anywhere, but initializing all the
values seems like a good idea.
- src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag): (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer): (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString): (WebKit::WebPageSerializerImpl::buildContentForNode):
- src/WebPageSerializerImpl.h:
- 8:53 AM Changeset in webkit [69667] by
-
- 2 edits in trunk/LayoutTests
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Unskip some fast/js tests that seem to be working now.
- platform/gtk/Skipped:
- 8:44 AM Changeset in webkit [69666] by
-
- 2 edits in trunk/WebCore
Unreviewed fix
Need to check for the existence of DeviceOrientation and DeviceMotion controllers
These features can be disabled at run time, so an enable guard is not sufficient.
This bug was introduced in http://trac.webkit.org/changeset/69646
Tested with existing tests.
- history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
- 8:39 AM Changeset in webkit [69665] by
-
- 2 edits in trunk/JavaScriptCore
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Csaba Osztrogonác.
Missing parameters for bytecode dump of next_pname
https://bugs.webkit.org/show_bug.cgi?id=47590
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): add missing parameters to the dump.
- 8:24 AM Changeset in webkit [69664] by
-
- 2 edits in trunk/LayoutTests
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update test expectation.
- inspector/console-trace-expected.txt:
- 7:44 AM Changeset in webkit [69663] by
-
- 17 edits1 move1 add in trunk/JavaScriptCore
2010-10-13 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Add wtf/text/StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47584
Move runtime/StringConcatenate.h to wtf/text, make it work for Strings too.
Add a special runtime/UStringConcatenate.h class that inherits from StringConcatenate, and extends it for use with UString.
Exactly the same design that has been followed while refactoring StringBuilder.
The UString variants can all be removed as soon as WTF::String & JSC::UString converge.
- GNUmakefile.am: Add wtf/text/StringConcatenate.h and runtime/UStringConcatenate.h.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- bytecode/CodeBlock.cpp: s/makeString/makeUString/ (JSC::escapeQuotes): (JSC::valueToSourceString): (JSC::constantName): (JSC::idName): (JSC::CodeBlock::registerName): (JSC::regexpToSourceString): (JSC::regexpName):
- bytecompiler/NodesCodegen.cpp: Ditto. (JSC::substitute):
- profiler/Profiler.cpp: Ditto. (JSC::Profiler::createCallIdentifier):
- runtime/ExceptionHelpers.cpp: Ditto. (JSC::createUndefinedVariableError): (JSC::createErrorMessage): (JSC::createInvalidParamError):
- runtime/FunctionConstructor.cpp: Ditto. (JSC::constructFunction):
- runtime/FunctionPrototype.cpp: Ditto. (JSC::insertSemicolonIfNeeded):
- runtime/JSONObject.cpp: Ditto. (JSC::Stringifier::indent):
- runtime/JSStringBuilder.h: (JSC::jsMakeNontrivialString):
- runtime/RegExpConstructor.cpp: Ditto. (JSC::constructRegExp):
- runtime/RegExpObject.cpp: Ditto. (JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp: Ditto. (JSC::regExpProtoFuncCompile):
- runtime/StringConcatenate.h: Removed.
- runtime/UStringConcatenate.h: Added. Only contains the StringTypeAdapter<JSC::UString> code and the makeUString variants, the rest lives in wtf/text/StringConcatenate.h (JSC::makeUString):
- wtf/text/StringConcatenate.h: Copied from runtime/StringConcatenate.h. (WTF::makeString):
- 7:43 AM Changeset in webkit [69662] by
-
- 16 edits6 adds in trunk
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: stack information is inconsistent between console.trace and runtime errors.
https://bugs.webkit.org/show_bug.cgi?id=47252
- console.trace() is now formatted the same way as other stack traces
- If there is @ sourceURL=url line at the end of eval'ed script source the url will be shown in the stack traces for script. That is why ScriptCallFrame::sourceURL type has changed from KURL to String.
Tests: inspector/console-trace-in-eval.html
inspector/console-uncaught-exception-in-eval.html
- bindings/js/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
- bindings/js/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
- bindings/v8/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
- bindings/v8/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
- bindings/v8/ScriptCallStack.cpp: (WebCore::getFrameLocation): (WebCore::ScriptCallStack::create):
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback):
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::CallFrame::buildInspectorObject): (WebCore::ConsoleMessage::ConsoleMessage):
- inspector/ConsoleMessage.h:
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage):
- page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::timeEnd):
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: stack information is inconsistent between console.trace and runtime errors.
https://bugs.webkit.org/show_bug.cgi?id=47252
- inspector/console-trace-in-eval-expected.txt: Added.
- inspector/console-trace-in-eval.html: Added.
- inspector/console-uncaught-exception-in-eval-expected.txt: Added.
- inspector/console-uncaught-exception-in-eval.html: Added.
- platform/chromium/console-trace-in-eval-expected.txt: Added.
- platform/chromium/console-uncaught-exception-in-eval-expected.txt: Added.
2010-10-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: stack information is inconsistent between console.trace and runtime errors.
https://bugs.webkit.org/show_bug.cgi?id=47252
- DEPS: bump up V8 revision
- 7:42 AM Changeset in webkit [69661] by
-
- 10 edits in trunk/WebKit2
Add ability for WK2 to set domain relaxation forbidden for a URL scheme.
https://bugs.webkit.org/show_bug.cgi?id=47562
Reviewed by Jon Honeycutt.
Add the schemes for which domain relaxation is forbidden to the
WebProcessCreationParameters.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextSetDomainRelaxationForbiddenForURLScheme):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
Copy over the schemes for which domain relaxation is forbidden to
WebProcessCreationParameters.
(WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme):
Only send a message to the WebProcess if it is valid.
- UIProcess/WebContext.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Set domain relaxation forbidden for the schemes in
WebProcesCreationParameters.urlSchemesForWhichDomainRelaxationIsForbidden.
(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Add the SetDomainRelaxationFobiddenForURLScheme message.
- 7:37 AM Changeset in webkit [69660] by
-
- 2 edits in trunk/WebCore
2010-10-13 Kent Tamura <tkent@chromium.org>
Unreviewed, a trivial change.
Run sort-Xcode-project-file.
- WebCore.xcodeproj/project.pbxproj:
- 7:34 AM Changeset in webkit [69659] by
-
- 4 edits in trunk/WebKitTools
Fix a couple of issues with the TestWebKitAPI build
- TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
- TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
Fixed a typo.
- TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
to set our output and intermediate directories so that we don't spew
files into the source tree.
- 7:08 AM Changeset in webkit [69658] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
- platform/qt/Skipped: Reskip fast/events/spatial-navigation/snav-clipped-overflowed-content.html again, because it still fails.
- 7:07 AM Changeset in webkit [69657] by
-
- 3 edits in trunk/WebKitTools
2010-10-13 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
WTR should accept relative paths
https://bugs.webkit.org/show_bug.cgi?id=47486
- WebKitTestRunner/StringFunctions.h:
- WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL): Moved from StringFunctions.h since it is used only here. Extend relative paths to absolute.
- 6:58 AM Changeset in webkit [69656] by
-
- 6 edits1 copy10 adds in trunk
Make TestWebKitAPI work on Windows
Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
Reviewed by Sam Weinig.
WebKit/win:
Build TestWebKitAPI on Windows
- WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
TestWebKitAPIGenerated and made them build just after
WebKitTestRunner.
WebKitTools:
- Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
- Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
run on Windows.
(runTest): Added code to run TestWebKitAPI.exe on Windows and to die
on unsupported platforms.
(populateTests): Added code to run TestWebKitAPI.exe on Windows and to
die on other platforms. Extracted some formerly-Mac-specific code to
be cross-platform and made it handle any style of line-endings.
- TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
Links against CFLite.
- TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
Contains most properties for the project.
- TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
Added. Links against CoreFoundation.
- TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
section and moved the cross-platform section after the
platform-specific parts.
- TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
(TestWebKitAPI::Util::run): Runs a normal message pump until we're
done.
(TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
(TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
resource path.
(TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
WKURL.
- TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
(TestWebKitAPI::registerWindowClass):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
This was mostly copied from WebKitTestRunner's PlatformWebView.
- TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
build-api-tests script.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
TestWebKitAPI.exe.
- TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
through to copy-resources.cmd.
- TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
or deletes resources from TestWebKitAPI.resources.
- TestWebKitAPI/win/main.cpp: Added.
(main): Calls through to TestsController.
- 6:46 AM Changeset in webkit [69655] by
-
- 10 edits in trunk
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Remove more warnings from the g-i scanner run
https://bugs.webkit.org/show_bug.cgi?id=47255
Fixes almost all warnings coming from the g-i scanner.
- GNUmakefile.am: Add missing files and include dirs to the scanner run.
WebKit/gtk:
2010-10-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Remove more warnings from the g-i scanner run
https://bugs.webkit.org/show_bug.cgi?id=47255
Fixes almost all warnings coming from the g-i scanner.
- webkit/webkitsecurityorigin.cpp: Rename parameter names in gtk-doc blurb to the actual name of the parameter.
- webkit/webkitsoupauthdialog.c: ditto. (webkit_soup_auth_dialog_class_init): Write missing doc for the 'current-toplevel' signal.
- webkit/webkitsoupauthdialog.h: Rename signal parameter to its actual name.
- webkit/webkitwebdatabase.cpp: Rename parameter names in gtk-doc blurb to the actual name of the parameter.
- webkit/webkitwebinspector.cpp: ditto. (webkit_web_inspector_class_init): ditto.
- webkit/webkitwebview.cpp: ditto. (webkit_web_view_class_init): ditto.
- webkit/webkitwebview.h: Rename the parameter names to be in sync with the ones we use in the function definition.
- 6:32 AM Changeset in webkit [69654] by
-
- 4 edits in trunk/LayoutTests
2010-10-13 Antonio Gomes <agomes@rim.com>
Unreviewed clean up of Spatial Navigation tests listed in Mac, Gtk and Qt's Skipped files.
- platform/qt/Skipped: Unskip fast/events/spatial-navigation/snav-clipped-overflowed-content.html
- platform/gtk/Skipped: Added reference to the respective bug # for the skipped spatial navigation tests.
- platform/mac/Skipped: Ditto.
- 6:09 AM Changeset in webkit [69653] by
-
- 3 edits in trunk/WebKit2
2010-10-13 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Simplify code generation in WebKit2/DerivedSources.pro
https://bugs.webkit.org/show_bug.cgi?id=47543
- DerivedSources.pro: General generator rules added instead of copy/paste code to converge Makefile.DerivedSources.
- WebKit2.pro: PluginProcess' headers and sources added.
- 6:05 AM QtWebKitFeatures21 edited by
- (diff)
- 6:04 AM QtWebKitFeatures21 edited by
- (diff)
- 5:49 AM Changeset in webkit [69652] by
-
- 2 edits in trunk/LayoutTests
2010-10-13 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, build fix.
Bring back the storage/change-version.html CRASH expectation (still crashes on the main waterfall).
- platform/chromium/test_expectations.txt:
- 5:27 AM Changeset in webkit [69651] by
-
- 3 edits2 adds in trunk
2010-10-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
Wrong ASSERT when select element has size 0
https://bugs.webkit.org/show_bug.cgi?id=47567
- fast/dom/HTMLSelectElement/click-size-zero-no-crash-expected.txt: Added.
- fast/dom/HTMLSelectElement/click-size-zero-no-crash.html: Added.
2010-10-13 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Andreas Kling.
Wrong ASSERT when select element has size 0
https://bugs.webkit.org/show_bug.cgi?id=47567
Keep the ASSERT only if the size of the element list is more than 0
Test: fast/dom/HTMLSelectElement/click-size-zero-no-crash.html
- dom/SelectElement.cpp: (WebCore::SelectElement::updateListBoxSelection): (WebCore::SelectElement::listBoxDefaultEventHandler):
- 5:14 AM Changeset in webkit [69650] by
-
- 8 edits in trunk
2010-10-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support viewport configuration and add new arguments for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=47084
Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::dispatchViewportDataDidChange):
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
- ewk/ewk_private.h:
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_viewport_attributes_compute): (ewk_view_viewport_attributes_set): (ewk_view_viewport_attributes_get): (ewk_view_device_pixel_ratio_get):
- ewk/ewk_view.h:
2010-10-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Support viewport configuration and add new arguments for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=47084
Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.
- EWebLauncher/main.c: (on_viewport_changed):
- 5:05 AM Changeset in webkit [69649] by
-
- 4 edits in trunk/WebKit2
2010-10-13 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Use flag instead of magic word to mark memory map free/used
Original patch by Antti Koivisto.
- Shared/qt/MappedMemory.h: (WebKit::MappedMemory::mapSize): (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::isFree): (WebKit::MappedMemory::data):
- Shared/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::cleanUp):
- Shared/qt/UpdateChunk.cpp: (WebKit::mapMemory): (WebKit::mapFile): (WebKit::UpdateChunk::data): (WebKit::UpdateChunk::decode):
- 4:56 AM Changeset in webkit [69648] by
-
- 2 edits in trunk/WebKit/qt
2010-10-13 Dinu Jacob <dinu.jacob@nokia.com>
Reviewed by Andreas Kling.
[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=47540
Updated symbols for Symbian - added viewportAttributesForSize and
made viewportConfigurationForSize absent based on the API change in
47325
- symbian/eabi/QtWebKitu.def:
- 3:17 AM Changeset in webkit [69647] by
-
- 3 edits6 adds in trunk/LayoutTests
2010-10-13 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Rebaseline some windows tests. Add new expectations for two SVG tests.
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-2-expected.txt:
- platform/win/svg/batik: Added.
- platform/win/svg/batik/masking: Added.
- platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
- platform/win/svg/zoom: Added.
- platform/win/svg/zoom/page: Added.
- platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- 3:00 AM Changeset in webkit [69646] by
-
- 6 edits12 adds in trunk
2010-10-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Pages using DeviceOrientation and DeviceMotion should not go into the page cache
https://bugs.webkit.org/show_bug.cgi?id=47408
- fast/dom/DeviceMotion/no-page-cache-expected.txt: Added.
- fast/dom/DeviceMotion/no-page-cache.html: Added.
- fast/dom/DeviceMotion/resources: Added.
- fast/dom/DeviceMotion/resources/cached-page-1.html: Added.
- fast/dom/DeviceMotion/resources/cached-page-2.html: Added.
- fast/dom/DeviceMotion/script-tests/no-page-cache.js: Added. (reportPageOneOnload):
- fast/dom/DeviceOrientation/no-page-cache-expected.txt: Added.
- fast/dom/DeviceOrientation/no-page-cache.html: Added.
- fast/dom/DeviceOrientation/resources: Added.
- fast/dom/DeviceOrientation/resources/cached-page-1.html: Added.
- fast/dom/DeviceOrientation/resources/cached-page-2.html: Added.
- fast/dom/DeviceOrientation/script-tests/no-page-cache.js: Added. (reportPageOneOnload):
2010-10-13 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Pages using DeviceOrientation and DeviceMotion should not go into the page cache
https://bugs.webkit.org/show_bug.cgi?id=47408
Tests: fast/dom/DeviceMotion/no-page-cache.html
fast/dom/DeviceOrientation/no-page-cache.html
- dom/DeviceMotionController.h: (WebCore::DeviceMotionController::isActive):
- dom/DeviceOrientationController.h: (WebCore::DeviceOrientationController::isActive):
- history/PageCache.cpp: (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCache):
- page/Page.cpp:
- 2:54 AM QtWebKitFeatures21 edited by
- (diff)
- 2:24 AM Changeset in webkit [69645] by
-
- 2 edits in trunk/LayoutTests
2010-10-13 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, build fix.
Disable printing/simultaneous-position-float-change.html as LayoutTestController::setPrinting()
is not implemented in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=47578
- platform/chromium/test_expectations.txt:
- 2:18 AM QtWebKitFeatures21 created by
- 2:14 AM Changeset in webkit [69644] by
-
- 1 edit9 adds in trunk/LayoutTests
2010-10-13 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed: Chromium pixel baselines for new ruby test.
Add baselines for the new ruby test introduced in WK r69642.
- platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.checksum: Added.
- platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.png: Added.
- platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.txt: Added.
- platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.checksum: Added.
- platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Added.
- platform/chromium-win/fast/ruby/ruby-beforeafter-expected.checksum: Added.
- platform/chromium-win/fast/ruby/ruby-beforeafter-expected.png: Added.
- platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt: Added.
- 2:03 AM Changeset in webkit [69643] by
-
- 4 edits4 adds in trunk
2010-10-13 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Make resource identifiers unique across pages
https://bugs.webkit.org/show_bug.cgi?id=47002
- http/tests/misc/iframe-reparenting-id-collision-expected.txt: Added.
- http/tests/misc/iframe-reparenting-id-collision.html: Added.
- http/tests/misc/resources/iframe-reparenting-id-collision-page.html: Added.
- http/tests/misc/resources/send-async-xhr.html: Added.
2010-10-13 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Make resource identifiers unique across pages
https://bugs.webkit.org/show_bug.cgi?id=47002
Test: http/tests/misc/iframe-reparenting-id-collision.html
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::ProgressTracker): (WebCore::ProgressTracker::createUniqueIdentifier):
- loader/ProgressTracker.h:
- 12:25 AM Changeset in webkit [69642] by
-
- 8 edits1 copy5 adds in trunk
2010-10-07 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Davit Hyatt.
Bug 41040 - :before/:after content should not become part of a ruby base
https://bugs.webkit.org/show_bug.cgi?id=41040
Also related to:
https://bugs.webkit.org/show_bug.cgi?id=40895.
https://bugs.webkit.org/show_bug.cgi?id=43722.
Layout tests: verify that generated content is outside of the ruby base.
Also, tests shouldn't crash.
- fast/ruby/after-doesnt-crash-expected.txt:
- fast/ruby/after-doesnt-crash.html: Added.
- fast/ruby/before-doesnt-crash.html:
- fast/ruby/ruby-beforeafter.html: Added.
- platform/gtk/Skipped:
- platform/mac/fast/ruby/ruby-beforeafter-expected.checksum: Added.
- platform/mac/fast/ruby/ruby-beforeafter-expected.png: Added.
- platform/mac/fast/ruby/ruby-beforeafter-expected.txt: Added.
- platform/qt/Skipped:
Explicitly handle :before and :after content in the default way.
Test: fast/ruby/ruby-beforeafter.html
fast/ruby/after-doesnt-crash.html
- rendering/RenderObject.h: (WebCore::RenderObject::isBeforeContent):
- rendering/RenderRuby.cpp: (WebCore::lastRubyRun): (WebCore::RenderRubyAsInline::addChild): (WebCore::RenderRubyAsInline::removeChild): (WebCore::RenderRubyAsBlock::addChild): (WebCore::RenderRubyAsBlock::removeChild):
