Context Navigation

← Previous Period
Next Period →

Timeline

Dec 16, 2010:

9:46 PM Changeset in webkit [74233] by tkent@chromium.org

11 edits in trunk/LayoutTests

Unreviewed, test expectation update.

Update Chromium-Linux results changed by r74232.
https://bugs.webkit.org/show_bug.cgi?id=50365

platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum:
platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.png:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum:
platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png:
platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:

9:19 PM Changeset in webkit [74232] by tkent@chromium.org

8 edits in trunk/WebCore

2010-12-16 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Kent Tamura.

Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Linux
https://bugs.webkit.org/show_bug.cgi?id=50365

No new tests. But this makes Chromimium Linux show
fast/blockflow/japanese-*-text.html and other vertical
writing text correctly as on WebKit and Chromimum for Mac.

platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
platform/graphics/chromium/FontPlatformDataLinux.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::orientation):
platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: (WebCore::substituteWithVerticalGlyphs): (WebCore::GlyphPage::fill):

9:06 PM Changeset in webkit [74231] by tkent@chromium.org

2 edits in trunk/LayoutTests

2010-12-16 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

platform/chromium/test_expectations.txt: Remove SLOW for fail-on-update-2.html.

7:51 PM Changeset in webkit [74230] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2010-12-16 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

Update BUG comment in test expectations files
https://bugs.webkit.org/show_bug.cgi?id=51216

Change the BUG[0-9]+ description to BUG(CR|WK|V8_)[0-9]+ where necessary.

platform/chromium/test_expectations.txt:
platform/mac/test_expectations.txt:
platform/qt/test_expectations.txt:

7:36 PM Changeset in webkit [74229] by tonikitoo@webkit.org

5 edits
2 moves in trunk

2010-12-05 Antonio Gomes <agomes@rim.com>

Reviewed by Ariya Hidayat.

[Qt] Fix caret browsing navigation mode
https://bugs.webkit.org/show_bug.cgi?id=50536

WebKit/qt:

Caret browsing can consume editing commands even when the start
of current selection is not a editable content. r69582 missed this
case because caret browsing feature testing is very poor today.

This commit reintroduces part of the removed code in r69582 but
guarded by a isCaretBrowsingEnabled() check. No regression found.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

LayoutTests:

/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html
is one of the few tests actually tests the caret browsing feature.
Patch makes the test not Gtk+ specific, and Qt now passes on it.

editing/selection/caret-mode-paragraph-keys-navigation-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation-expected.tx t.
editing/selection/caret-mode-paragraph-keys-navigation.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-paragraph-keys-navigation.html.
fast/events/multiline-link-arrow-navigation.html:

7:28 PM Changeset in webkit [74228] by commit-queue@webkit.org

5 edits in trunk/WebCore

2010-12-16 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia.com>

Reviewed by Eric Carlson.

Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133

Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
to launch fullscreen video player for playing the html5 video. The
idea is that a browser vendor can specify this behavior through the
platform plugin or something else by using this interface.

No new tests because no client implements requiresFullscreenForVideoPlayback yet.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::exitFullscreen):
page/Chrome.cpp: (WebCore::Chrome::requiresFullscreenForVideoPlayback):
page/Chrome.h:
page/ChromeClient.h: (WebCore::ChromeClient::requiresFullscreenForVideoPlayback):

7:05 PM Changeset in webkit [74227] by levin@chromium.org

2 edits in trunk/WebKitTools

2010-12-16 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
https://bugs.webkit.org/show_bug.cgi?id=51210

The error only shows up when using python 2.6 or later.

Scripts/webkitpy/style/checkers/xml.py: Replace the usage of the decprecated field error,message with something equivalent.

6:47 PM Changeset in webkit [74226] by steveblock@google.com

5 edits in trunk/WebCore

2010-12-16 Steve Block <steveblock@google.com>

Reviewed by Steve Block.

GeolocationPositionCache needs refactoring
https://bugs.webkit.org/show_bug.cgi?id=50826

No new tests, refactoring only.

page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::makeCachedPositionCallbacks): (WebCore::Geolocation::haveSuitableCachedPosition): (WebCore::Geolocation::positionChangedInternal):
page/Geolocation.h:
page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::instance): (WebCore::GeolocationPositionCache::GeolocationPositionCache): (WebCore::GeolocationPositionCache::addUser): (WebCore::GeolocationPositionCache::removeUser): (WebCore::GeolocationPositionCache::setDatabasePath): (WebCore::GeolocationPositionCache::setCachedPosition): (WebCore::GeolocationPositionCache::cachedPosition): (WebCore::GeolocationPositionCache::readFromDatabase): (WebCore::GeolocationPositionCache::writeToDatabase):
page/GeolocationPositionCache.h: (WebCore::GeolocationPositionCacheWrapper::GeolocationPositionCacheWrapper): (WebCore::GeolocationPositionCacheWrapper::~GeolocationPositionCacheWrapper): (WebCore::GeolocationPositionCacheWrapper::setCachedPosition): (WebCore::GeolocationPositionCacheWrapper::cachedPosition):

6:28 PM Changeset in webkit [74225] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

2010-12-16 Yong Li <yoli@rim.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=51199
Add decoding tests for UTF-16 LE/BE and their variants.
Also, check the full decoded text but not only the first one.

fast/encoding/char-decoding.html:
fast/encoding/char-decoding-expected.txt:
fast/encoding/resources/char-decoding-utils.js:

6:20 PM Changeset in webkit [74224] by weinig@apple.com

18 edits in trunk/WebKit2

Add svn:eol-style native to the message.in files as a favor to Darin Adler.

Reviewed by Darin Adler.

PluginProcess/PluginControllerProxy.messages.in: Added property svn:eol-style.
PluginProcess/PluginProcess.messages.in: Added property svn:eol-style.
PluginProcess/WebProcessConnection.messages.in: Added property svn:eol-style.
Shared/Plugins/NPObjectMessageReceiver.messages.in: Added property svn:eol-style.
UIProcess/Downloads/DownloadProxy.messages.in: Added property svn:eol-style.
UIProcess/Plugins/PluginProcessProxy.messages.in: Added property svn:eol-style.
UIProcess/WebContext.messages.in: Added property svn:eol-style.
UIProcess/WebDatabaseManagerProxy.messages.in: Added property svn:eol-style.
UIProcess/WebInspectorProxy.messages.in: Added property svn:eol-style.
UIProcess/WebPageProxy.messages.in: Added property svn:eol-style.
UIProcess/WebProcessProxy.messages.in: Added property svn:eol-style.
WebProcess/Authentication/AuthenticationManager.messages.in: Added property svn:eol-style.
WebProcess/Plugins/PluginProxy.messages.in: Added property svn:eol-style.
WebProcess/WebCoreSupport/WebDatabaseManager.messages.in: Added property svn:eol-style.
WebProcess/WebPage/WebInspector.messages.in: Added property svn:eol-style.
WebProcess/WebPage/WebPage.messages.in: Added property svn:eol-style.
WebProcess/WebProcess.messages.in: Added property svn:eol-style.

6:13 PM Changeset in webkit [74223] by mihaip@chromium.org

4 edits in trunk/WebKitTools

2010-12-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Add --exit-after-n-failures/crashes to NRWT
https://bugs.webkit.org/show_bug.cgi?id=51160

Abort test run (in a similar way to how control-C is handled) when
--exit-after-n-failures/crashes-or-timeouts are passed and we've reached
that number of unexpected failures/crashes/timeouts.

Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

5:56 PM Changeset in webkit [74222] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations to mark
http/tests/appcache/fail-on-update-2.html as flaky with TIMEOUT.

platform/chromium/test_expectations.txt:

5:52 PM Changeset in webkit [74221] by evan@chromium.org

2 edits in trunk/JavaScriptCore

2010-12-16 Evan Martin <evan@chromium.org>

Reviewed by Darin Fisher.

[chromium] useless warnings when building on Windows
https://bugs.webkit.org/show_bug.cgi?id=50985

Disable some compiler warnings that aren't indicative of real problems.

JavaScriptCore.gyp/JavaScriptCore.gyp:

5:44 PM Changeset in webkit [74220] by ariya@webkit.org

6 edits in trunk

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208

GraphicsContext does not override SmoothPixmapTransform (see also
r62762). To keep the same behavior, canvas default image interpolation
quality is set to medium and QWebView's render hints by default also
include SmoothPixmapTransform.

html/HTMLCanvasElement.h:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext should respect QWebView render hints
https://bugs.webkit.org/show_bug.cgi?id=51208

Add some checks to ensure that GraphicsContext (via QWebFrame)
does not clobber the render hints.

Api/qwebview.cpp: (QWebViewPrivate::QWebViewPrivate):
tests/qwebframe/tst_qwebframe.cpp:

4:29 PM Changeset in webkit [74219] by weinig@apple.com

9 edits in trunk/WebKit2

Move NSURLCache initialization from the ProcessLauncherMac to the centralized
WebContext initialize WebProcess mechanism.

Reviewed by Anders Carlsson.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

Shared/WebProcessCreationParameters.h:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

WebProcess/win/WebProcessWin.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::setShouldPaintNativeControls):

3:26 PM Changeset in webkit [74218] by dbates@webkit.org

2 edits in trunk/WebCore

2010-12-16 Daniel Bates <dbates@rim.com>

Formatting fix; un-indent one level all lines in [2793, 2808] (with respect to r74217)
so as to be consistent with the formatting of the rest of this file.

Also, add an empty line between the win32* and wince* conditional include blocks.

WebCore.pro:

3:17 PM Changeset in webkit [74217] by dbates@webkit.org

2 edits in trunk/WebCore

2010-12-16 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

[Qt] Only include ScrollAnimatorWin.h and compile ScrollAnimatorWin.cpp
on Windows if ENABLE_SMOOTH_SCROLLING=1
https://bugs.webkit.org/show_bug.cgi?id=51215

Conditionally include the files ScrollAnimatorWin.h and ScrollAnimatorWin.cpp when building
the Qt Windows with smooth scrolling enabled.

No change in functionality since these files are guarded by ENABLE(SMOOTH_SCROLLING).

WebCore.pro:

3:12 PM Changeset in webkit [74216] by rniwa@webkit.org

2 edits in trunk/WebKit/mac

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Cameron Zwarich.

REGRESSION(r74172): 125 java tests fail on Mac
https://bugs.webkit.org/show_bug.cgi?id=51214

The regression was caused by an incorrectly adding sizeof(struct fat_header)
to a pointer for uint32_t as supposed to uint8_t.

Fixed the bug by explicitly casting it to uint8_t* before the addition.

Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isNativeLibraryData:]):

2:21 PM Changeset in webkit [74215] by xan@webkit.org

2 edits in trunk/LayoutTests

2010-12-16 Xan Lopez <xlopez@igalia.com>

[GTK] fast/dom/gc-11.html fails in 64bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=51213

platform/gtk/Skipped:

2:08 PM Changeset in webkit [74214] by rniwa@webkit.org

3 edits
2 adds in trunk

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('JustifyCenter') adds extra BR
https://bugs.webkit.org/show_bug.cgi?id=51082

The bug was caused by moveParagraphContentsToNewBlockIfNecessary's adding a placeholder br
to new block and not removing it later. Fixed the bug by removing it when the paragraph
moved into the block didn't have a br at the end.

Test: editing/execCommand/justify.html

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('JustifyCenter') adds extra BR
https://bugs.webkit.org/show_bug.cgi?id=51082

Added a test to ensure WebKit executes Justify* properly. In particular,
this test ensures WebKit does not erroneously add a BR at the end of each block.

editing/execCommand/justify-expected.txt: Added.
editing/execCommand/justify.html: Added.

2:06 PM Changeset in webkit [74213] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

platform/chromium/test_expectations.txt:

1:52 PM Changeset in webkit [74212] by mihaip@chromium.org

2 edits in trunk/LayoutTests

2010-12-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Remove Chromium platform/chromium/accessibility
expectations, that directory doesn't exist anymore as of r74039.

platform/chromium/test_expectations.txt:

1:45 PM Changeset in webkit [74211] by commit-queue@webkit.org

9 edits
1 add in trunk/LayoutTests

2010-12-16 Cosmin Truta <ctruta@chromium.org>

Reviewed by Adam Roben.

More rebaselining needed for new-run-webkit-tests update
https://bugs.webkit.org/show_bug.cgi?id=51147

Some cases were missed while rebaselining in bug 51018.

platform/chromium-mac/editing/execCommand/outdent-blockquote-test2-expected.txt:
platform/chromium-mac/editing/pasteboard/copy-standalone-image-expected.txt:
platform/chromium-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt:
platform/chromium-mac/http/tests/security/cross-frame-access-get-override-expected.txt:
platform/chromium-mac/svg/custom/use-invalid-style-expected.txt:
platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt:
platform/chromium-win/platform/win/plugins/get-value-netscape-window-expected.txt:
platform/chromium/plugins/document-open-expected.txt: Added.
plugins/document-open-expected.txt: Rolled out change from r74097.

1:37 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

1:36 PM Changeset in webkit [74210] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=51166
ExecutableAllocator::cacheFlush should call sys_cache_control

Patch by Pratik Solanki <psolanki@apple.com> on 2010-12-16
Reviewed by Geoffrey Garen.

jit/ExecutableAllocator.h:

(JSC::ExecutableAllocator::cacheFlush): Use the more correct and forward looking API -
sys_cache_control(kCacheFunctionPrepareForExecution,...).

1:36 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

1:21 PM XBL2UseCases edited by Dimitri Glazkov

(diff)

1:11 PM Changeset in webkit [74209] by andersca@apple.com

4 edits in trunk/WebKit2

2010-12-16 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Defer getting a PluginProcessConnection object until the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=51207
<rdar://problem/8731306>

Before this change, we would pass the PluginProcessConnection to the PluginProxy constructor, but not
call PluginProcessConnection::addPluginProxy (which associates the plug-in proxy with the connection)
until the plug-in is initialized.

This could lead to a PluginProxy holding a reference to a PluginProcessConnection when the PluginProxyConnection
itself did not know anything about the PluginProxy. This would happen when a page with plug-ins is opened in a background
tab, with the plug-ins not yet initialized.

Because of this, we could end up in a weird state, where the PluginProcessConnection would think that there are no
more plug-ins alive, and invalidate (and null out) the underlying CoreIPC connection, which would lead to crashes
when trying to send messages to the connection during later initialization.

The fix is to pass the plug-in path to the PluginProxy constructor, and get the connection from PluginProxy::initialize.

PluginProcessConnection object

WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::create): (WebKit::PluginProxy::PluginProxy): (WebKit::PluginProxy::initialize):
WebProcess/Plugins/PluginProxy.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):

1:10 PM QtWebKitFeatures22 created by Ademar Reis

1:08 PM Changeset in webkit [74208] by jianli@chromium.org

2 edits in trunk/WebCore

Unreviewed. Fixed chromium build break caused by r74207.

platform/ContextMenuItem.h:

1:02 PM QtWebKitRelease22 edited by Ademar Reis

(diff)

12:30 PM Changeset in webkit [74207] by leandro@webkit.org

12 edits
2 deletes in trunk

2010-12-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.

CMakeListsEfl.txt:
WebCoreSupport/ContextMenuClientEfl.cpp: Removed.
WebCoreSupport/ContextMenuClientEfl.h: Removed.
ewk/ewk_contextmenu.cpp: (ewk_context_menu_item_append):
ewk/ewk_view.cpp: (_ewk_view_priv_new):

2010-12-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.

CMakeListsEfl.txt:
platform/ContextMenu.h:
platform/ContextMenuItem.h:
platform/efl/ContextMenuEfl.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createNativeMenuFromItems): (WebCore::ContextMenu::nativeMenu):
platform/efl/ContextMenuItemEfl.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::nativeMenuItem): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::setEnabled): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setSubMenu):

2010-12-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix.

Disable ContextMenu support for now while support for
CROSS_PLATFORM_MENUS is written.

cmake/OptionsEfl.cmake:

12:18 PM Changeset in webkit [74206] by enrica@apple.com

2 edits in trunk/WebKit2

WebKit2: Cannot copy two successive selections using cmd-c
<rdar://problem/8680309>
https://bugs.webkit.org/show_bug.cgi?id=51203

Reviewed by Maciej Stachowiak.

The previous implementation assumed a call sequence from AppKit that
was not always happening.
When the user clicks on the pulldown menu, AppKit sends validateUserInterfaceItem
calls for each element that needs validation and we used to count the number of
validation requests being sent to the web process.
All these calls are made before we have the chance to get one reply from the WebProcess.
We also delayed the menu update until we had received all the replies to the validation requests.
At that point we called update on the menu to trigger the validation one more time with
the data retrived from the WebProcess.
When the user simply presses cmd-c, only one call to vaidateUserInterfaceItem is made
and the menu update triggered the validation of all the menu entries causing the internal
state to be out of sync.
The new implementation is very simple: for each validation request from AppKit we send
a request to the WebProcess and we cache a reference to the menu item being validated.
When the WebProcess replies, we retrieve the menu item from our cache and update its state.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]): Removed initialization of deleted memebers.
(-[WKView validateUserInterfaceItem:]): Request validation to the WebProcess and return YES to
allow AppKit to do the keyBinding processing.
(-[WKView _setUserInterfaceItemState:enabled:state:]): Called when the WebProcess replies to the
validation request to check/uncheck and enable/disable the menu item.

12:07 PM Changeset in webkit [74205] by andersca@apple.com

2 edits in trunk/WebKit2

Don't try to call plug-in member functions if the plug-in hasn't been initialized
https://bugs.webkit.org/show_bug.cgi?id=51205
<rdar://problem/8730204>

Reviewed by Oliver Hunt.

Make sure that all PluginView functions that can be called while a plug-in has not been
initialized (if the plug-in page is in a background tab for example) have an additional
check for m_isInitialized.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setWindowIsFocused):
(WebKit::PluginView::windowAndViewFramesChanged):
(WebKit::PluginView::platformLayer):
(WebKit::PluginView::scriptObject):
(WebKit::PluginView::privateBrowsingStateChanged):
(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::setFocus):

12:01 PM Changeset in webkit [74204] by rniwa@webkit.org

3 edits
2 adds in trunk

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
https://bugs.webkit.org/show_bug.cgi?id=51164

Fixed the bug by always enabling the StyleWithCSS command.

Test: editing/style/stylewithcss-without-selection.html

editing/EditorCommand.cpp: (WebCore::createCommandMap): StyleWithCSS is enabled rather than enabledInRichlyEditableText.

2010-12-16 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

execCommand('styleWithCSS') is ignored when selection isn't inside a contenteditable area
https://bugs.webkit.org/show_bug.cgi?id=51164

Added a test to ensure WebKit accepts StyleWithCSS command even if the current selection
isn't inside a contenteditable region.

editing/style/stylewithcss-without-selection-expected.txt: Added.
editing/style/stylewithcss-without-selection.html: Added.

11:45 AM Changeset in webkit [74203] by andersca@apple.com

2 edits in trunk/WebKit2

Add a bunch of m_isStarted assertions to plug-in code.

Reviewed by John Sullivan.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::frameDidFinishLoading):
(WebKit::NetscapePlugin::frameDidFail):
(WebKit::NetscapePlugin::didEvaluateJavaScript):
(WebKit::NetscapePlugin::streamDidReceiveResponse):
(WebKit::NetscapePlugin::streamDidReceiveData):
(WebKit::NetscapePlugin::streamDidFinishLoading):
(WebKit::NetscapePlugin::streamDidFail):
(WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
(WebKit::NetscapePlugin::manualStreamDidReceiveData):
(WebKit::NetscapePlugin::manualStreamDidFinishLoading):
(WebKit::NetscapePlugin::manualStreamDidFail):
(WebKit::NetscapePlugin::handleMouseEvent):
(WebKit::NetscapePlugin::handleWheelEvent):
(WebKit::NetscapePlugin::handleMouseEnterEvent):
(WebKit::NetscapePlugin::handleMouseLeaveEvent):
(WebKit::NetscapePlugin::handleKeyboardEvent):
(WebKit::NetscapePlugin::setFocus):
(WebKit::NetscapePlugin::pluginScriptableNPObject):
(WebKit::NetscapePlugin::privateBrowsingStateChanged):

11:37 AM Changeset in webkit [74202] by andersca@apple.com

5 edits in trunk

Save the manual plug-in stream data and redeliver it when the plug-in is initialized
https://bugs.webkit.org/show_bug.cgi?id=51201

Reviewed by Darin Adler.

WebCore:

Export SharedBuffer related symbols.

WebCore.exp.in:

WebKit2:

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):
Initialize m_manualStreamState.

(WebKit::PluginView::manualLoadDidReceiveResponse):
If the plug-in hasn't been initialized, store the response.

(WebKit::PluginView::manualLoadDidReceiveData):
If the plug-in hasn't been initialized, store the data.

(WebKit::PluginView::manualLoadDidFinishLoading):
If the plug-in hasn't been initialized, update the state.

(WebKit::PluginView::manualLoadDidFail):
If the plug-in hasn't been initialized, store the error and update the state.

(WebKit::PluginView::initializePlugin):
Call redeliverManualStream.

(WebKit::PluginView::redeliverManualStream):
Redeliver the manual stream to the plug-in.

WebProcess/Plugins/PluginView.h:

10:56 AM Changeset in webkit [74201] by andreas.kling@nokia.com

2 edits in trunk/WebKit2

2010-12-16 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Turn off drawing area updates if the item is not visible

The updates are controlled by the QGraphicsItem::visible property.

UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKViewPrivate::updateViewportSize): (QGraphicsWKView::setGeometry): (QGraphicsWKView::itemChange):

10:45 AM Changeset in webkit [74200] by levin@chromium.org

3 edits in trunk/WebKitTools

2010-12-16 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style unit tests has some duplicate boilerplate code.
https://bugs.webkit.org/show_bug.cgi?id=49519

Scripts/webkitpy/style/checkers/cpp.py: (update_include_state): Replaced the "io" parameter with the global configuration _unit_test_config. This allowed not calling into functions at a low level and also not plumbing through the injection information through many levels of code. (check_for_include_what_you_use): Ditto. (process_file_data): Added the ability to set up the unit test config to allow for injection.
Scripts/webkitpy/style/checkers/cpp_unittest.py: (ErrorCollector.init): Added support for having a filter for errors. (ErrorCollector.call): Ditto. (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config. (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions. (CppStyleTestBase.perform_single_line_lint): Replace specific calls to functions in the cpp.py with generic processing and a filter that indicates what errors should be kept. (CppStyleTestBase.perform_multi_line_lint): Ditto. (CppStyleTestBase.perform_language_rules_check): Ditto. (CppStyleTestBase.perform_function_lengths_check): Ditto. (CppStyleTestBase.perform_pass_ptr_check): Ditto. (CppStyleTestBase.perform_include_what_you_use): Ditto. (CppStyleTest.test_multi_line_comments): Added another error message which applies to the test case. (CppStyleTest.test_spacing_for_binary_ops): Fixed test to not have config.h, since it is processed as a header file. (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name style and indentation in checked code. (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Fixed line number. (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Ditto.

10:06 AM Changeset in webkit [74199] by ap@apple.com

1 edit in trunk/WebCore/ChangeLog

Correcting Radar number.

10:01 AM Changeset in webkit [74198] by pfeldman@chromium.org

4 edits in trunk/WebCore

2010-12-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: timeline records should only operate WebCore time.
https://bugs.webkit.org/show_bug.cgi?id=51127

inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
inspector/TimelineRecordFactory.cpp: (WebCore::TimelineRecordFactory::createResourceFinishData):
inspector/TimelineRecordFactory.h:

9:54 AM Changeset in webkit [74197] by ap@apple.com

2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=50996
<rdar://problem/8086718> Consider disabling DNS prefetch when proxy is used

No new tests, cannot test DNS.

platform/network/cf/DNSCFNet.cpp: (WebCore::proxyIsEnabledInSystemPreferences): Check if accessing example.com is going to use a proxy. This is only an estimate - even with a proxy is configured in system preferences, an actual request can go directly to the host if a PAC script says so. (WebCore::DNSResolveQueue::add): Check if proxy is enabled when sending immediate requests. (WebCore::DNSResolveQueue::fired): Ditto when sending queued ones.

9:50 AM Changeset in webkit [74196] by Martin Robinson

2 edits in trunk/WebKit/gtk

2010-12-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[Gtk] scrolling artifacts
https://bugs.webkit.org/show_bug.cgi?id=45029

Call gdk_window_process_updates() right after moving the window
when scrolling.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):

9:33 AM Changeset in webkit [74195] by scherkus@chromium.org

2 edits
8 deletes in trunk/LayoutTests

2010-12-16 Andrew Scherkus <scherkus@chromium.org>

Unreviewed. Updating Chromium media test expectations.

platform/chromium-mac/media/audio-constructor-expected.txt: Removed.
platform/chromium-mac/media/audio-constructor-preload-expected.txt: Removed.
platform/chromium-mac/media/audio-constructor-src-expected.txt: Removed.
platform/chromium-mac/media/media-load-event-expected.txt: Removed.
platform/chromium-win/media/audio-constructor-expected.txt: Removed.
platform/chromium-win/media/audio-constructor-preload-expected.txt: Removed.
platform/chromium-win/media/audio-constructor-src-expected.txt: Removed.
platform/chromium-win/media/media-load-event-expected.txt: Removed.
platform/chromium/test_expectations.txt:

9:01 AM Changeset in webkit [74194] by wsiegrist@apple.com

1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

William Siegrist <wsiegrist@apple.com>

Unreviewed buildbot master config change to prevent slave shutdowns via web interface.

8:56 AM Changeset in webkit [74193] by yurys@chromium.org

4 edits in trunk/WebCore

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Console always scroll to the bottom on new events
https://bugs.webkit.org/show_bug.cgi?id=51189

When new messages are added to the console it will auto scroll
only if it was already scrolled down to the last record.

inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView): (WebInspector.ConsoleView.prototype._scheduleScrollIntoView): (WebInspector.ConsoleView.prototype._isScrolledToLastMessage): (WebInspector.ConsoleView.prototype.addMessage):

8:32 AM Changeset in webkit [74192] by ariya@webkit.org

3 edits in trunk/JavaScriptCore

2010-12-16 Ariya Hidayat <ariya@sencha.com>

Reviewed by Andreas Kling.

[JSC] Const correctness in ASTBuilder and SyntaxChecker
https://bugs.webkit.org/show_bug.cgi?id=51141

parser/ASTBuilder.h: (JSC::ASTBuilder::getName): (JSC::ASTBuilder::getType): (JSC::ASTBuilder::isResolve):
parser/SyntaxChecker.h: (JSC::SyntaxChecker::operatorStackPop):

7:57 AM Changeset in webkit [74191] by podivilov@chromium.org

5 edits in trunk/WebCore

2010-12-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: update CallStackSidebarPane placards and status message in the same event handler.
https://bugs.webkit.org/show_bug.cgi?id=51174

inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._debuggerPaused): (WebInspector.BreakpointManager.prototype._debuggerResumed):
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.pausedScript):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused):

7:47 AM Changeset in webkit [74190] by yurys@chromium.org

1 edit
3 adds in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations for svg/repaint/filter-repaint.svg

platform/chromium-mac/svg/repaint/filter-repaint-expected.checksum: Added.
platform/chromium-mac/svg/repaint/filter-repaint-expected.png: Added.

7:05 AM Changeset in webkit [74189] by jorlow@chromium.org

2 edits in trunk/WebKit/chromium

2010-12-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Enable client-based geolocation in Chromium
https://bugs.webkit.org/show_bug.cgi?id=50562

features.gypi:

6:55 AM Changeset in webkit [74188] by hans@chromium.org

4 edits in trunk

2010-12-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Fix IDBDatabaseError code offset bug
https://bugs.webkit.org/show_bug.cgi?id=51177

IDBDatabaseError::code() needs to return the error code without
offset. But when the IDBDatabaseError is created, the code comes with
an offset (it gets passed a IDBDatabaseException::IDBDatabaseExceptionCode).

However, in Chromium, IDBDatabaseErrors are sometimes also created via
WebIDBDatabaseError when they are sent across IPC, and then the error
code comes *without* offset. Provide a second create() function for
this case.

storage/IDBDatabaseError.h: (WebCore::IDBDatabaseError::create): (WebCore::IDBDatabaseError::createWithoutOffset): (WebCore::IDBDatabaseError::code):

2010-12-16 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Fix IDBDatabaseError code offset bug
https://bugs.webkit.org/show_bug.cgi?id=51177

WebIDBDatabaseError must use the
IDBDatabaseError::createWithoutOffset() function.

src/WebIDBDatabaseError.cpp: (WebKit::WebIDBDatabaseError::assign):

6:44 AM Changeset in webkit [74187] by xan@webkit.org

10 edits
3 deletes in trunk

Revert "2010-12-15 Helder Correia <helder@sencha.com>"

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

Breaks canvas tests in GTK+.

6:31 AM Changeset in webkit [74186] by xan@webkit.org

6 edits in trunk

2010-12-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74162.
http://trac.webkit.org/changeset/74162
https://bugs.webkit.org/show_bug.cgi?id=51185

More breakage in GTK+ (Requested by xan_ on #webkit).

fast/encoding/char-decoding-expected.txt:
fast/encoding/char-decoding.html:
fast/encoding/resources/char-decoding-utils.js: (decode):

2010-12-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74162.
http://trac.webkit.org/changeset/74162
https://bugs.webkit.org/show_bug.cgi?id=51185

More breakage in GTK+ (Requested by xan_ on #webkit).

platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::registerEncodingNames):

6:09 AM Changeset in webkit [74185] by apavlov@chromium.org

5 edits in trunk

2010-12-16 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Up/Down/PageUp/PageDown on a CSS property numeric value commit the value editor
https://bugs.webkit.org/show_bug.cgi?id=51114

The r74038 regressed the behaviour. This patch additionally ensures that both Metrics and Styles panes
are updated once a stylesheet is reverted.

WebCore:

inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype._stylesPaneEdited): (WebInspector.ElementsPanel.prototype._metricsPaneEdited): (WebInspector.ElementsPanel.prototype._styleSheetChanged):

LayoutTests:

inspector/styles-add-blank-property-expected.txt:
inspector/styles-add-blank-property.html:

5:26 AM Changeset in webkit [74184] by yurys@chromium.org

2 edits in trunk/WebCore

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Mac Debug Clang compilation.

platform/graphics/FontFastPath.cpp: (WebCore::Font::getGlyphsAndAdvancesForSimpleText):

5:13 AM Changeset in webkit [74183] by alex

2 edits in trunk/WebCore

2010-12-16 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Fix GTK3 compilation after 74129.

platform/gtk/WidgetRenderingContextGtk3.cpp:

5:01 AM Changeset in webkit [74182] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

4:44 AM Changeset in webkit [74181] by yurys@chromium.org

10 edits
4 adds in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
platform/chromium-linux/svg/filters/feComposite-expected.checksum:
platform/chromium-linux/svg/filters/feComposite-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
platform/chromium-mac/svg/filters/feComposite-expected.checksum: Added.
platform/chromium-mac/svg/filters/feComposite-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
platform/chromium-win/svg/filters/feComposite-expected.checksum:
platform/chromium-win/svg/filters/feComposite-expected.png:
platform/chromium/test_expectations.txt:

3:34 AM Changeset in webkit [74180] by yurys@chromium.org

73 edits in trunk/LayoutTests

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations to match changes made in r74177.

platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/chromium-mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:

3:20 AM Changeset in webkit [74179] by yurys@chromium.org

2 edits in trunk/WebCore

2010-12-16 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Debug compilation after r74177

platform/graphics/filters/FEComposite.cpp: (WebCore::arithmetic):

12:40 AM Changeset in webkit [74178] by tkent@chromium.org

2 edits in trunk/WebCore

2010-12-16 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

Fix a warning on 32-bit Mac.

platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::emphasisMarkFontData): 0.5 -> 0.5f

12:32 AM Changeset in webkit [74177] by zherczeg@webkit.org

27 edits in trunk

Improve feArithmeticFilter
https://bugs.webkit.org/show_bug.cgi?id=51105

Reviewed by Dirk Schulze.

WebCore:

In case of the arithmetic operator on feComposite filter, we could use
different result passing modes depend on its type. Furthermore, the
number of executed multiplications is reduced if k1 or k4 argument is zero.

2% speedup on WebCore/manual-tests/svg-filter-animation.svg

platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixels):
(WebCore::arithmetic):
(WebCore::FEComposite::apply):

LayoutTests:

No visible changes.

platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
platform/mac-leopard/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:

Dec 15, 2010:

11:48 PM Changeset in webkit [74176] by yurys@chromium.org

3 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

10:52 PM Changeset in webkit [74175] by mitz@apple.com

3 edits in trunk/WebKit2

<rdar://problem/8731320> WebProcess's CFNetwork cache is in ~/Library/Caches/com.apple.WebProcess

Reviewed by Sam Weinig.

UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess): Get the location, disk capacity and memory capacity
of the UI process's NSURLCache and pass them to the WebProcess.

WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): If an NSURLCache location was passed on the command line, set the
shared NSURLCache to that path and use the specified capacities as initial values.

10:32 PM Changeset in webkit [74174] by mitz@apple.com

2 edits in trunk/WebKit2

Allow responses to be cached by the NSURLCache.

Reviewed by Sam "I blame undersea" Weinig.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::willCacheResponse): Changed to return the response instead of 0.

10:14 PM Changeset in webkit [74173] by Laszlo Gombos

2 edits in trunk/WebKit/qt

2010-12-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antonio Gomes.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814

Change the test case according to the changes introduced by
r72603 and enable the test case.

tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):

8:35 PM Changeset in webkit [74172] by cwzwarich@webkit.org

2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

Clang -Wcast-align gives an error in WebBasePluginPackage.mm
https://bugs.webkit.org/show_bug.cgi?id=51144

Fix an alignment issue. OSSwapInt32 takes data that is 32-bit aligned on ARM, but
we were calling it on a byte array 32 bits at a time. While this is okay in practice,
since TCMalloc won't give us a non-32-bit aligned block array of bytes and Vector's
inline storage is at the beginning of the Vector, it is still better to fix this
and silence the warning.

Plugins/WebBasePluginPackage.mm:

(swapIntsInHeader):
(-[WebBasePluginPackage isNativeLibraryData:]):

7:31 PM Changeset in webkit [74171] by commit-queue@webkit.org

3 edits in trunk/WebKit/chromium

2010-12-15 Chris Guillory <chris.guillory@google.com>

Reviewed by Darin Fisher.

Expose AccessibilityObject::url() to Chromium
https://bugs.webkit.org/show_bug.cgi?id=51046

public/WebAccessibilityObject.h:
src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::url):

6:26 PM Changeset in webkit [74170] by bweinstein@apple.com

3 edits in trunk/WebCore

WebKit2 should exit auto scrolling mode when losing focus
https://bugs.webkit.org/show_bug.cgi?id=49209

Reviewed by Jon Honeycutt.

When a page loses focus, make sure that we stop the autoscroll timer, which exits pan scrolling mode. We
don't want to automatically scroll when a page doesn't have focus.

Updated manual-tests/autoscroll.html with instructions to test this bug.

manual-tests/autoscroll.html:
page/FocusController.cpp:

(WebCore::FocusController::setFocused):

6:23 PM Changeset in webkit [74169] by mitz@apple.com

33 edits in trunk/WebCore

Font support for the text-emphasis CSS property
Part of <rdar://problem/7720300> Support the CSS3 text-emphasis property
https://bugs.webkit.org/show_bug.cgi?id=48539

Reviewed by Darin Adler.

platform/graphics/Font.cpp:

(WebCore::Font::drawEmphasisMarks): Added. Calls through to drawEmphasisMarksFor{Simple,Complex}Text.
(WebCore::Font::canReceiveTextEmphasis): Added. For simple text, checks if the character should
have an emphasis mark.

platform/graphics/Font.h:

platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter): Replaced the forceSmallCaps boolean with a FontDataVariant
parameter and made this function work with other variants.
(WebCore::Font::getEmphasisMarkGlyphData): Added. Returns glyph data for the first character of
the emphasis mark. This function may not work if the emphasis mark uses a complex script, but none
of the standard emphasis marks do so.
(WebCore::Font::emphasisMarkAscent): Added.
(WebCore::Font::emphasisMarkDescent): Added.
(WebCore::Font::emphasisMarkHeight): Added.
(WebCore::Font::getGlyphsAndAdvancesForSimpleText): Moved much of the logic from drawSimpleText()
into this new function, which also has a ForTextEmphasis parameter, which is passed along to the
WidthIterator.
(WebCore::Font::drawSimpleText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForSimpleText): Added.
(WebCore::Font::drawGlyphBuffer): Removed the unused TextRun parameter.
(WebCore::offsetToMiddleOfGlyph): Added this helper.
(WebCore::offsetToMiddleOfGlyphAtIndex): Added this other helper.
(WebCore::Font::drawEmphasisMarks): Added. Draws emphasis marks for a given glyph buffer by placing
one mark centered above each glyph. Zero glyphs in the buffer indicate that no mark should be drawn.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawEmphasisMarks): Added. Calls through to Font::drawEmphasisMarks().

platform/graphics/GraphicsContext.h:

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData): Removed initialization of deleted members.
(WebCore::SimpleFontData::~SimpleFontData): Removed derived font data cleanup, which now happens
in ~DerivedFontData.
(WebCore::SimpleFontData::brokenIdeographFontData): Changed to use m_derivedFontData.
(WebCore::SimpleFontData::DerivedFontData::DerivedFontData): Added. This lazily-allocated struct
contains the SimpleFontData for small caps, broken ideograph and emphasis mark.
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData): Added.

platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::variantFontData): Added. This is used by Font::glyphDataForCharacter().

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Added forTextEmphasis parameter.
(WebCore::WidthIterator::advance): When used for text emphasis, replace glyphs with the zero glyph
if they should not receive an emphasis mark.

platform/graphics/WidthIterator.h:

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/chromium/FontLinux.cpp:

(WebCore::TextRunWalker::nextScriptRun): Updated for change to Font::glyphDataForCharacter().
(WebCore::TextRunWalker::setupFontForScriptRun): Ditto.
(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.

platform/graphics/chromium/SimpleFontDataLinux.cpp:

platform/graphics/efl/FontEfl.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

platform/graphics/gtk/FontGtk.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/haiku/FontHaiku.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/haiku/SimpleFontDataHaiku.cpp:

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Added forTextEmphasis parameter.
(WebCore::ComplexTextController::collectComplexTextRuns): Updated for change to Font::glyphDataForCharacter().
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): When used for text emphasis, replace glyphs with the zero glyph
if they should not receive an emphasis mark.

platform/graphics/mac/ComplexTextController.h:

platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Moved much of the logic from drawComplexText()
into this new function, which also has a ForTextEmphasis parameter, which is passed along to the
ComplexTextController.
(WebCore::Font::drawComplexText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForComplexText): Added.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy): Adopted m_derivedFontData.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.

platform/graphics/pango/SimpleFontDataPango.cpp:

(WebCore::SimpleFontData::platformDestroy): Removed redundant clearing of derived font.
(WebCore::SimpleFontData::scaledFontData): Moved code from smallCapsFontData() here and generalized.
(WebCore::SimpleFontData::smallCapsFontData): Adopted m_derivedFontData and scaledFontData().
(WebCore::SimpleFontData::emphasisMarkFontData): Added.

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::emphasisMarkAscent): Added stub.
(WebCore::Font::emphasisMarkDescent): Ditto.
(WebCore::Font::emphasisMarkHeight): Ditto.
(WebCore::Font::drawEmphasisMarksForSimpleText): Ditto.
(WebCore::Font::drawEmphasisMarksForComplexText): Ditto.

platform/graphics/win/FontWin.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Moved much of the logic from drawComplexText()
into this new function, which also has a ForTextEmphasis parameter. Currently returns an empty
glyph buffer for text emphasis.
(WebCore::Font::drawComplexText): Left the drawing part here.
(WebCore::Font::drawEmphasisMarksForComplexText): Added.

platform/graphics/win/SimpleFontDataWin.cpp:

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::advance): Updated for change to Font::glyphDataForCharacter().

platform/graphics/wince/FontWinCE.cpp:

(WebCore::Font::drawEmphasisMarksForComplexText): Added stub.

platform/graphics/wince/SimpleFontDataWinCE.cpp:

platform/graphics/wx/FontWx.cpp:

(WebCore::Font::getGlyphsAndAdvancesForComplexText): Added stub.
(WebCore::Font::drawComplexText): Updated for removal of unused TextRun parameter to drawGlyphBuffer().
(WebCore::Font::drawEmphasisMarksForComplexText): Added.

platform/graphics/wx/SimpleFontDataWx.cpp:

platform/text/CharacterNames.h: Added characters used in Font::canReceiveTextEmphasis().

6:20 PM Rebaseline edited by jamesr@google.com

(diff)

6:13 PM Changeset in webkit [74168] by Beth Dakin

3 edits in trunk/WebCore

Fix for https://bugs.webkit.org/show_bug.cgi?id=51150 WebView's
_scaleWebView SPI doesn't work on pages with compositing layers
-and corresponding-
<rdar://problem/8604713>

Reviewed by Darin Adler.

paintingGoesToWindow() should return false if the owning layer has
a transform.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintingGoesToWindow):

Use docWidth() and docHeight() instead of rightLayoutOverflow() and
bottomLayoutOverflow() since docWidth/Height are now the preferred
way to query physical dimensions of the document.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):

5:33 PM Changeset in webkit [74167] by commit-queue@webkit.org

2 edits in trunk/WebCore

2010-12-15 Alex Bredariol Grilo <abgrilo@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Fix timer calling time in SharedTimerEfl

No new features, so no tests added.

The usage of ecore_timer_loop_add instead of ecore_timer_add corrects
the problem that the timer is not called at the correct time. Since this
code runs in a single thread, all multiple thread operations were
removed.

platform/efl/SharedTimerEfl.cpp: (WebCore::stopSharedTimer): (WebCore::addNewTimer):

5:16 PM Changeset in webkit [74166] by bweinstein@apple.com

4 edits
1 add in trunk/LayoutTests

Rebaseline Windows XP results after r73993. Windows 7 results were landed in r73998, but some XP
rebaselines were needed as well.

platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
platform/win-xp/fast/text/international/bold-bengali-expected.txt:
platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
platform/win-xp/transforms/2d/hindi-rotated-expected.txt:

5:15 PM Changeset in webkit [74165] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] StillImage::draw() shouldn't call setCompositionMode() unless the QPaintEngine has Porter-Duff composition
https://bugs.webkit.org/show_bug.cgi?id=49918

Go through GraphicsContext::setCompositeOperation() which does the check for us.

platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):

5:07 PM Changeset in webkit [74164] by enrica@apple.com

12 edits in trunk/WebKit2

Add IME support to WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=51049
The implementation is very close to the one in WebKit.
The main change is the addition of handlers for WM_IME_STARTCOMPOSITION,
WM_IME_REQUEST, WM_IME_COMPOSITION, WM_IME_ENDCOMPOSITION,
WM_IME_SELECT, WM_IME_SETCONTEXT and a number of new messages
between the UI process and the WebProcess to send/retrieve
the data being handled by the messages listed above.

Reviewed by Adam Roben.

UIProcess/PageClient.h: Added compositionSelectionChanged for Windows platform.
UIProcess/WebPageProxy.cpp:

The following methods send synchronous messages to the WebProcess.
(WebKit::WebPageProxy::firstRectForCharacterInSelectedRange): Retrieves the rectangle to position
the cnadidates window.
(WebKit::WebPageProxy::getSelectedText): Retrieves the currently selected text.
The following methods send asynchronous messages to the WebProcess.
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::didChangeSelection): Name changed.
(WebKit::WebPageProxy::didChangeCompositionSelection): Called when there is a change
in the composition selection.

UIProcess/WebPageProxy.messages.in: Added messages corresponding to the methods above.
UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc): Added handling of messages for IME.
The following are the handlers for the window message being sent during composition.
(WebKit::WebView::onIMEComposition):
(WebKit::WebView::onIMEEndComposition):
(WebKit::WebView::onIMERequestCharPosition):
(WebKit::WebView::onIMERequestReconvertString):
(WebKit::WebView::onIMERequest):
(WebKit::WebView::onIMESelect):
(WebKit::WebView::onIMESetContext):

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Added notification
of composition selection changed for Windows.

WebProcess/WebPage/win/WebPageWin.cpp:

The following are the WebProcess counterparts of the new messages.
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::firstRectForCharacterInSelectedRange):
(WebKit::WebPage::getSelectedText):

4:58 PM Changeset in webkit [74163] by commit-queue@webkit.org

4 edits in trunk/WebKitTools

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74136.
http://trac.webkit.org/changeset/74136
https://bugs.webkit.org/show_bug.cgi?id=51135

r74136 breaks chromium canary bots because some tests are not
rebaselined correctly to resolve EOL differences (Requested by
jianli on #webkit).

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/test.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

4:55 PM Changeset in webkit [74162] by commit-queue@webkit.org

6 edits in trunk

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=51035
Add tests for UTF-16 BE/LE and their variants.
Also, check the full decoded text but not only the first one.

fast/encoding/char-decoding.html:
fast/encoding/char-decoding-expected.txt:
fast/encoding/resources/char-decoding-utils.js:

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

UTF-16 and its variants should be treated as Big Endian when BOM
is absent.
https://bugs.webkit.org/show_bug.cgi?id=51035

Test: fast/encoding/char-decoding.html (changed)

platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::registerEncodingNames):

4:12 PM Changeset in webkit [74161] by darin@chromium.org

3 edits in trunk/WebKit/chromium

2010-12-14 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] AssociatedURLLoader leaks m_realLoader to its WebURLLoaderClient.
https://bugs.webkit.org/show_bug.cgi?id=51062

src/AssociatedURLLoader.cpp: Intercept WebURLLoaderClient methods and forward |this| as the WebURLLoader parameter. (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::willSendRequest): (WebKit::AssociatedURLLoader::didSendData): (WebKit::AssociatedURLLoader::didReceiveResponse): (WebKit::AssociatedURLLoader::didDownloadData): (WebKit::AssociatedURLLoader::didReceiveData): (WebKit::AssociatedURLLoader::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::didFinishLoading): (WebKit::AssociatedURLLoader::didFail):
src/AssociatedURLLoader.h:

4:02 PM Changeset in webkit [74160] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

size status bubble to it's contents on the code review page
https://bugs.webkit.org/show_bug.cgi?id=51142

PrettyPatch/PrettyPatch.rb:
code-review.js:

4:00 PM Changeset in webkit [74159] by mihaip@chromium.org

4 edits
1 add
11 deletes in trunk/LayoutTests

2010-12-15 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

fast/parser/remove-block-in-residual-style.html does not need pixel output
https://bugs.webkit.org/show_bug.cgi?id=51120

fast/parser/remove-block-in-residual-style.html just checks that we
don't crash, it doesn't need pixel output.

(noticed while doing Snow Leopard rebaselines)

fast/parser/remove-block-in-residual-style-expected.txt: Added.
fast/parser/remove-block-in-residual-style.html:
platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/chromium-mac/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/chromium-mac/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/chromium-win/fast/parser/remove-block-in-residual-style-expected.txt: Removed.
platform/gtk/Skipped:
platform/mac/fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
platform/mac/fast/parser/remove-block-in-residual-style-expected.png: Removed.
platform/mac/fast/parser/remove-block-in-residual-style-expected.txt: Removed.
platform/qt/Skipped:
platform/qt/fast/parser/remove-block-in-residual-style-expected.txt: Removed.

3:59 PM Changeset in webkit [74158] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-12-15 Adam Roben <Adam Roben>

Teach check-webkit-style to check .vcproj and .vsprops files for XML
syntax errors

Fixes <http://webkit.org/b/51103> check-webkit-style should check for
XML syntax errors in .vcproj/.vsprops files

Reviewed by Dave Levin.

Scripts/webkitpy/style/checker.py: Added lists of file extensions that should be treated as XML and that should be allowed to contain carriage returns. (These lists happen to be identical currently.) (FileType): Added a new XML type. (CheckerDispatcher.should_check_and_strip_carriage_returns): Added. Just does a simple file extension check. (CheckerDispatcher._file_type): Added a case for XML files. (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML files (surprise!). (StyleProcessor.process): Ask the dispatcher whether we should pass the lines through the carriage checker.

Scripts/webkitpy/style/checker_unittest.py: (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns): Added. Checks a few file names to see if carriage returns are allowed or not. (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to other assert_checker_* functions. (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other test_*_paths functions. (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other test_*_paths functions. (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj file from this test case, as vcproj files now have a type. (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns): Added. Similar to the other should_* functions. (StyleProcessor_CodeCoverageTest.test_processcarriage_returns_not_stripped): Added. Checks that carriage returns aren't checked for or stripped for allowed files.

Scripts/webkitpy/style/checkers/xml.py: Added. (XMLChecker.init): Simple init method. (XMLChecker.check): Pass each line through the expat parser, and record a style error for any errors thrown by the parser.

Scripts/webkitpy/style/checkers/xml_unittest.py: Added. (XMLCheckerTest.assert_no_error): Checks that the given XML does not produce a style error. (XMLCheckerTest.assert_error): Checks that the given XML produces an error of the given category on the given line. (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for checking that the XMLChecker constructor works properly. (XMLCheckerTest.test_conflict_marker): Tests that conflict markers cause a style error (see, e.g., r73887). (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags cause a style error (see, e.g., r73773). (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works properly. (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing tags cause a style error (see, e.g., r72795). (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a style error.

3:55 PM Changeset in webkit [74157] by weinig@apple.com

3 edits in trunk/WebKit2

Loading webkit.org over and over is slower in WebKit2 than WebKit1, looks like page is not cached
<rdar://problem/8774683>
https://bugs.webkit.org/show_bug.cgi?id=51143

Reviewed by Brady Eidson.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canCachePage): Return true as long as we
are not a custom representation (eg. a PDF).
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Always return true.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Enable the page cache.

3:49 PM Changeset in webkit [74156] by Simon Fraser

4 edits
2 adds in trunk

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Percentage Z values in 3d transform functions and transform-origin should cause the property to be invalid
https://bugs.webkit.org/show_bug.cgi?id=51070

Treat as inavlid -webkit-transform values that include a percentage value in translateZ()
or in the third parameter to translate3d().

Test: transforms/3d/general/3dtransform-values.html

css/CSSParser.cpp: (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin): Whitespace change.

3:49 PM Changeset in webkit [74155] by Simon Fraser

3 edits
4 adds in trunk

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Chris Marrin.

Reflection does not render properly when -webkit-transform is toggled, untoggled, and retoggled
https://bugs.webkit.org/show_bug.cgi?id=50967

If a reflection on a compositied, transformed element is toggled on, off and on,
then we pick up a cached layer clone that has the wrong transform set on it.

The fix is to reset those properties on the layer clones that get changed
when the GraphicsLayer gains a structural layer (for reflection flattening).

Test: compositing/reflections/remove-add-reflection.html

platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::ensureStructuralLayer):

3:48 PM Changeset in webkit [74154] by commit-queue@webkit.org

10 edits
2 copies
1 add in trunk

2010-12-15 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Add new test to ensure that shadows are correctly transformed keeping
the relative offset to the shape.

fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
fast/canvas/canvas-transforms-fillRect-shadow.html: Added.
fast/canvas/script-tests/canvas-scale-fillPath-shadow.js:
fast/canvas/script-tests/canvas-scale-fillRect-shadow.js:
fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Now using a lineWidth > 1 to make it easier to test and more fair among all ports, since there can be different transformation smoothness or aliasing settings.
fast/canvas/script-tests/canvas-transforms-fillRect-shadow.js: Added.

2010-12-15 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Canvas shadow offset should not be affected by any transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

On a canvas context, shadows are currently affected by all
transformations except scaling. According to the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#shadows

"The shadowOffsetX and shadowOffsetY attributes specify the distance
that the shadow will be offset in the positive horizontal and positive
vertical distance respectively. Their values are in coordinate space
units. They are not affected by the current transformation matrix."

NOTE: this applies only to canvas, not to box shadows.

Test: fast/canvas/canvas-transforms-fillRect-shadow.html

platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::calculateLayerBoundingRect):
platform/graphics/ContextShadow.h: (WebCore::ContextShadow::setShadowsIgnoreTransforms): (WebCore::ContextShadow::shadowsIgnoreTransforms): (WebCore::ContextShadow::offset):
platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::mustUseContextShadow): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow):

3:45 PM BuildingOnWindows edited by jhoneycutt@apple.com

After rebasing all of the DLLs in /usr/bin and /bin, I've not had any … (diff)

3:41 PM Changeset in webkit [74153] by timothy@apple.com

2 edits in trunk/WebCore

Fix a regression where the Web Inspector console would be empty
if the Inspector is localized.

https://bugs.webkit.org/show_bug.cgi?id=51145

Reviewed by Joseph Pecoraro.

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.createFilterElement): Add a label argument so the UI string
is separate from the classname. Code clean up.
(WebInspector.ConsoleView.prototype.filter): Remove toLowerCase and use string compare.
(WebInspector.ConsoleView): Pass separate classnames and labels to createFilterElement.

3:35 PM Changeset in webkit [74152] by Simon Fraser

7 edits in trunk

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

WebKit2 in compositing mode no longer has font smoothing
https://bugs.webkit.org/show_bug.cgi?id=50733

Only turn off font smoothing for layers whose contents are
not opaque. This allows the root GraphicsLayer in WebKit2 to
set the opaque flag, and get smoothed text.

platform/graphics/mac/WebLayer.mm: (drawLayerContents):

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson.

WebKit2 in compositing mode no longer has font smoothing
https://bugs.webkit.org/show_bug.cgi?id=50733

Tell the root GraphicsLayer that its contents are opaque
if the WebPage draws its background, and that background
is not transparent.

The GraphicsLayer then uses the 'contentsOpaque' setting to
determine whether to use font smoothing.

Add pageBackgroundTransparencyChanged() to DrawingArea
so that the WebPage can inform the DrawingArea when the
background transparency changes.

WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::pageBackgroundTransparencyChanged): (WebKit::DrawingArea::onPageClose):
WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::pageBackgroundTransparencyChanged):
WebProcess/WebPage/LayerBackedDrawingArea.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setDrawsBackground): (WebKit::WebPage::setDrawsTransparentBackground):

3:34 PM Changeset in webkit [74151] by Simon Fraser

6 edits
1 add in trunk/WebCore

2010-12-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Allow disabling of font smoothing in compositing layers to be overridden by style
https://bugs.webkit.org/show_bug.cgi?id=50732

Add methods to GraphicsContext to get and set font smoothing,
and have them be part of the graphics state.

Fix Font::drawGlyphs() to allow the font's smoothing mode (from style)
to override the current smoothing mode of the context. The global
shouldUseSmoothing() still has final say.

Turn off smoothing in compositing layers with this, rather than
the non-stateful 'allow' method.

manual-tests/compositing/font-smoothing.html: Added. Manual test because DRT disables font smoothing.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShouldSmoothFonts): (WebCore::GraphicsContext::shouldSmoothFonts): (WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShouldSmoothFonts):
platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
platform/graphics/mac/WebLayer.mm: (drawLayerContents):

3:33 PM Changeset in webkit [74150] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix goofups from r74142 and r74130
https://bugs.webkit.org/show_bug.cgi?id=51146

Accidentally shrank the inline comment boxes and made
the toolbar not show up when there were image diffs.

PrettyPatch/PrettyPatch.rb:
code-review.js:

3:32 PM Changeset in webkit [74149] by Adam Roben

3 edits
2 adds in trunk/WebKitTools

Teach check-webkit-style to check .vcproj and .vsprops files for XML syntax errors

Fixes <http://webkit.org/b/51103> check-webkit-style should check for
XML syntax errors in .vcproj/.vsprops files

Reviewed by Dave Levin.

Scripts/webkitpy/style/checker.py: Added lists of file extensions

that should be treated as XML and that should be allowed to contain
carriage returns. (These lists happen to be identical currently.)
(FileType): Added a new XML type.
(CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
Just does a simple file extension check.
(CheckerDispatcher._file_type): Added a case for XML files.
(CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
files (surprise!).
(StyleProcessor.process): Ask the dispatcher whether we should pass the
lines through the carriage checker.

Scripts/webkitpy/style/checker_unittest.py:

(CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
Added. Checks a few file names to see if carriage returns are allowed
or not.
(CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
other assert_checker_* functions.
(CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
test_*_paths functions.
(CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
test_*_paths functions.
(CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
file from this test case, as vcproj files now have a type.
(StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
Added. Similar to the other should_* functions.
(StyleProcessor_CodeCoverageTest.test_processcarriage_returns_not_stripped):
Added. Checks that carriage returns aren't checked for or stripped for
allowed files.

Scripts/webkitpy/style/checkers/xml.py: Added.

(XMLChecker.init): Simple init method.
(XMLChecker.check): Pass each line through the expat parser, and record
a style error for any errors thrown by the parser.

Scripts/webkitpy/style/checkers/xml_unittest.py: Added.

(XMLCheckerTest.assert_no_error): Checks that the given XML does not
produce a style error.
(XMLCheckerTest.assert_error): Checks that the given XML produces an
error of the given category on the given line.
(XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
checking that the XMLChecker constructor works properly.
(XMLCheckerTest.test_conflict_marker): Tests that conflict markers
cause a style error (see, e.g., r73887).
(XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
cause a style error (see, e.g., r73773).
(XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
properly.
(XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
tags cause a style error (see, e.g., r72795).
(XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
style error.

3:26 PM Changeset in webkit [74148] by mdelaney@apple.com

2 edits in trunk/WebCore

2010-12-15 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

IOSurface bounds checks on bytesPerRow and allocSize are incorrect
https://bugs.webkit.org/show_bug.cgi?id=51137

No new tests added. For those using this new functionality, many current canvas layout tests will now pass.

platform/graphics/cg/ImageBufferCG.cpp:

3:12 PM Changeset in webkit [74147] by kbr@google.com

6 edits
2 adds in trunk

2010-12-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to MKL
https://bugs.webkit.org/show_bug.cgi?id=50986

Fixed bug in log2 emulation function provided for Windows port of
Web Audio API.

wtf/MathExtras.h: (log2):

2010-12-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to MKL
https://bugs.webkit.org/show_bug.cgi?id=50986

Ported FFTFrame to Intel's MKL. This patch contains the port and
initial, though not complete, build system changes. Tested so far
with a unit test by Chris Rogers (which requires code changes to
AudioContext.cpp and is not being checked in). Further testing to
follow once layout tests are available for the Web Audio API.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/audio/FFTFrame.h:
platform/audio/mkl: Added.
platform/audio/mkl/FFTFrameMKL.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::getUpToDateComplexData): (WebCore::FFTFrame::descriptorHandleForSize):

3:10 PM Changeset in webkit [74146] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

2010-12-15 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

Skip tests for unimplmented media features (aspect ratio video,
full screen, reverse-playback, video-preloading, context menu).
will enable these tests once these features are implemented.
https://bugs.webkit.org/show_bug.cgi?id=51085

platform/chromium/test_expectations.txt:

3:06 PM Changeset in webkit [74145] by commit-queue@webkit.org

4 edits
2 adds in trunk

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Reproduce stack overflow when there are too many sibling inline boxes.
https://bugs.webkit.org/show_bug.cgi?id=48255

fast/overflow/lots-of-sibling-inline-boxes.html: Added.

2010-12-15 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Fix stack overflow when there are too many sibling inline boxes by using
a loop to traverse children instead of calling each sibling from the first child.
https://bugs.webkit.org/show_bug.cgi?id=48255

Test: fast/overflow/lots-of-sibling-inline-boxes.html

rendering/InlineBox.h: (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::next):
rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::setConstructed):

3:03 PM Changeset in webkit [74144] by andersca@apple.com

3 edits in trunk/WebKit2

2010-12-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix assertion in plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html test
https://bugs.webkit.org/show_bug.cgi?id=51136

Ensure that a plug-in that has explicitly cancelled the manual stream won't get any more callbacks.

PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::PluginControllerProxy): (WebKit::PluginControllerProxy::cancelManualStreamLoad): (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse): (WebKit::PluginControllerProxy::manualStreamDidReceiveData): (WebKit::PluginControllerProxy::manualStreamDidFinishLoading): (WebKit::PluginControllerProxy::manualStreamDidFail):
PluginProcess/PluginControllerProxy.h:

2:56 PM Changeset in webkit [74143] by Lucas Forschler

2 edits in trunk/WebKitTools

https://bugs.webkit.org/show_bug.cgi?id=51117
Add a new leopard test bot
really really commit to trunk this time.

Reviewed by Stephanie Lewis.

BuildSlaveSupport/build.webkit.org-config/config.json:

2:51 PM Changeset in webkit [74142] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

add ability to view for file context to the review tool
https://bugs.webkit.org/show_bug.cgi?id=51057

At the beginning/end of each file diff and between each
hunk add links to expand the context. For now it grabs the
tip of tree version of the file and tries to apply the diff
to that file. If it can't apply, then it gives up as we
wouldn't want to show the wrong lines of context.

In the future, we can consider adding the upload svn revision
to the diff itself, then we could fallback to the file at that
revision if tip of tree doesn't apply.

PrettyPatch/PrettyPatch.rb:
code-review.js:

2:44 PM Changeset in webkit [74141] by bweinstein@apple.com

2 edits in trunk/WebKit2

Windows Build Fix. A .h file was added to the vcproj twice, but not its corresponding cpp file.

win/WebKit2.vcproj:

2:27 PM Changeset in webkit [74140] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test_expectations to skip a test that
causes DRT to crash in dbg mode.

platform/chromium/test_expectations.txt:

1:52 PM Changeset in webkit [74139] by weinig@apple.com

27 edits
10 adds in trunk

WebKit2: Can't add files to an <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=51087

Reviewed by Anders Carlsson.

WebCore:

Add exported function.

WebCore.exp.in:

WebKit2:

Scripts/webkit2/messages.py:

Adds new types.

Shared/API/c/WKBase.h:

Adds WKOpenPanelParametersRef and WKOpenPanelResultListenerRef.

Shared/APIObject.h:

Adds TypeOpenPanelParameters and TypeOpenPanelResultListener.

Shared/WebOpenPanelParameters.cpp: Added.

(WebKit::WebOpenPanelParameters::create):
(WebKit::WebOpenPanelParameters::WebOpenPanelParameters):
(WebKit::WebOpenPanelParameters::~WebOpenPanelParameters):
(WebKit::WebOpenPanelParameters::Data::encode):
(WebKit::WebOpenPanelParameters::Data::decode):

Shared/WebOpenPanelParameters.h: Added.

(WebKit::WebOpenPanelParameters::allowMultipleFiles):
(WebKit::WebOpenPanelParameters::type):
Class representing options one can pass to open panel.

UIProcess/API/C/WKAPICast.h:

Add casts for WebOpenPanelParameters and WebOpenPanelResultListenerProxy.

UIProcess/API/C/WKOpenPanelParameters.cpp: Added.

(WKOpenPanelParametersGetTypeID):
(WKOpenPanelParametersGetAllowsMultipleFiles):

UIProcess/API/C/WKOpenPanelParameters.h: Added.
UIProcess/API/C/WKOpenPanelResultListener.cpp: Added.

(WKOpenPanelResultListenerGetTypeID):
(WKOpenPanelResultListenerChooseFiles):
(WKOpenPanelResultListenerCancel):

UIProcess/API/C/WKOpenPanelResultListener.h: Added.

Add API wrappers.

UIProcess/API/C/WKPage.h:

Add new UI callback, WKPageRunOpenPanelCallback.

UIProcess/API/C/WebKit2.h:

Add includes for new API headers.

UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):
Stub out the runOpenPanel callback.

UIProcess/WebOpenPanelResultListenerProxy.cpp: Added.

(WebKit::WebOpenPanelResultListenerProxy::WebOpenPanelResultListenerProxy):
(WebKit::WebOpenPanelResultListenerProxy::~WebOpenPanelResultListenerProxy):
(WebKit::WebOpenPanelResultListenerProxy::chooseFiles):
(WebKit::WebOpenPanelResultListenerProxy::cancel):
(WebKit::WebOpenPanelResultListenerProxy::invalidate):

UIProcess/WebOpenPanelResultListenerProxy.h: Added.

(WebKit::WebOpenPanelResultListenerProxy::create):
(WebKit::WebOpenPanelResultListenerProxy::type):
Adds the listener used to choose files for <input type=file>

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
(WebKit::WebPageProxy::didCancelForOpenPanel):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runOpenPanel):

UIProcess/WebUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runOpenPanel):

WebProcess/WebPage/WebOpenPanelResultListener.cpp: Added.

(WebKit::WebOpenPanelResultListener::create):
(WebKit::WebOpenPanelResultListener::WebOpenPanelResultListener):
(WebKit::WebOpenPanelResultListener::~WebOpenPanelResultListener):
(WebKit::WebOpenPanelResultListener::didChooseFiles):

WebProcess/WebPage/WebOpenPanelResultListener.h: Added.

(WebKit::WebOpenPanelResultListener::disconnectFromPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::setActiveOpenPanelResultListener):
(WebKit::WebPage::didChooseFilesForOpenPanel):
(WebKit::WebPage::didCancelForOpenPanel):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::activeOpenPanelResultListener):

WebProcess/WebPage/WebPage.messages.in:

Pipe through file choosing.

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
win/WebKit2.vcproj:
win/WebKit2Generated.make:

Add new files.

WebKitTools:

MiniBrowser/mac/BrowserWindowController.m:

(runOpenPanel):
(-[BrowserWindowController awakeFromNib]):
Add simple implementation of runOpenPanel callback.

MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):
Stub out runOpenPanel callback.

1:48 PM Changeset in webkit [74138] by eric@webkit.org

12 edits in trunk/WebKitTools

2010-12-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should upload failure diffs when tests flake
https://bugs.webkit.org/show_bug.cgi?id=51051

To make this testable I needed to pipe FileSystem down onto tool.
We've wanted it there for a long time anyway.

This patch is kinda a big hack. But we don't have a nice
way to read results.html files. I think this will need further
revision before this code actually feels clean.

As part of testing this change, I had to make MockBugzilla.create_bug
actually return an id (like it should) which required updating
a few other unit test results (for the better).

The results_matching_keys change in layouttestresults/rebasline
was an alternate path which I decided not to use in the end, but
I left the change as it seemed an improvement.

Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
Scripts/webkitpy/common/net/layouttestresults.py:
Scripts/webkitpy/tool/bot/flakytestreporter.py:
Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/rebaseline.py:
Scripts/webkitpy/tool/main.py:
Scripts/webkitpy/tool/mocktool.py:

1:00 PM Changeset in webkit [74137] by andreas.kling@nokia.com

2 edits in trunk/WebCore

2010-12-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] screenIsMonochrome() is broken
https://bugs.webkit.org/show_bug.cgi?id=49957

platform/qt/PlatformScreenQt.cpp: (WebCore::screenIsMonochrome):

12:39 PM Changeset in webkit [74136] by commit-queue@webkit.org

4 edits in trunk/WebKitTools

2010-12-15 Cosmin Truta <ctruta@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests ignores trailing EOL differences in text tests
https://bugs.webkit.org/show_bug.cgi?id=36983

Changed the handling of new-line characters within new-run-webkit-tests
to match old-run-webkit-tests. Differences in leading and trailing empty
lines in text expectation files are no longer ignored.

Scripts/webkitpy/layout_tests/port/base.py:
Scripts/webkitpy/layout_tests/port/test.py: Added unit tests. Removed old duplicate unit test entries.
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

12:26 PM Changeset in webkit [74135] by ojan@chromium.org

2 edits in trunk/WebKitTools

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
https://bugs.webkit.org/show_bug.cgi?id=51125

QueueStatusServer/templates/statusbubble.html:

12:15 PM Changeset in webkit [74134] by andersca@apple.com

4 edits in trunk/WebKit2

2010-12-15 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Semi-reproducible crash in ChunkedUpdateDrawingArea::paintIntoUpdateChunk closing a particular yahoo page
https://bugs.webkit.org/show_bug.cgi?id=51126
<rdar://problem/8771219>

Laying out the web page can cause the drawing area to change so we need to protect against this.

WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display):
WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::display):
WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::updateLayoutRunLoopObserverFired):

11:58 AM Changeset in webkit [74133] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Mark a failed test in chromium test expectations.

platform/chromium/test_expectations.txt:

11:39 AM Changeset in webkit [74132] by Martin Robinson

2 edits in trunk/WebCore

2010-12-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=48486

Implement button rendering in RenderThemeGtk. The implementation
from gtk{2,3}drawing.cpp will be removed once menu list button rendering
is implemented in RenderThemeGtk as well.

No new tests, as this should not change functionality.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintButton): Add an implementation of button rendering that uses WidgetRenderingContext.

11:34 AM Changeset in webkit [74131] by bweinstein@apple.com

6 edits in trunk/WebKit2

WebKit2: WebPageWin needs implementations of hasLocalDataForURL and canHandleRequest
https://bugs.webkit.org/show_bug.cgi?id=51090

Reviewed by Adam Roben.

Implement these functions for WebKit2 on Windows.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hasLocalDataForURL): Does the cross-platform part of the check for having local

data (file URL or subresource), then calls platformHasLocalDataForURL to let the platform do
their specific checks.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformHasLocalDataForURL): Moved the cross-platform code from here to WebPage::hasLocalDataForURL.

WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::platformHasLocalDataForURL): Renamed from hasLocalDataForURL.

WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::platformHasLocalDataForURL): Renamed from hasLocalDataForURL and implemented with CFNetwork calls. This is the

CFNetwork equivalent of the code in WebPageMac::platformHasLocalDataForURL.

(WebKit::WebPage::canHandleRequest): Copied the line of code from WebView::canHandleRequest in WebKit1, with a FIXME saying

this might not be enough (although it was in WebKit1 on Windows).

11:33 AM Changeset in webkit [74130] by ojan@chromium.org

3 edits in trunk/BugsSite

2010-12-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[reviewtool] should always show overall comments text box
https://bugs.webkit.org/show_bug.cgi?id=45870

PrettyPatch/PrettyPatch.rb:
code-review.js:

11:22 AM QtWebKitRelease22 edited by Ademar Reis

(diff)

11:19 AM Changeset in webkit [74129] by Martin Robinson

9 edits in trunk/WebCore

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move input type=range rendering to RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=47836

Begin moving widget rendering out of the old Mozilla theme drawing code,
which should remove many lines of code when completed. WidgetRenderingContext
now hides the GTK+ 2 vs. 3 API differences, so that RenderThemeGtk can stay
version agnostic.

No new tests as this patch does not change functionality.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): gtkContainer() now returns a GtkWidget, so update the cast here. (WebCore::RenderThemeGtk::getGtkStateType): Added this helper which converts a RenderObject state into a GtkStateType. (WebCore::RenderThemeGtk::paintRenderObject): Removed work-arounds for scale painting, as it's not handled by this method any longer. (WebCore::RenderThemeGtk::paintSliderTrack): Updated to use WidgetRenderingContext. (WebCore::RenderThemeGtk::paintSliderThumb): Ditto. (WebCore::RenderThemeGtk::adjustSliderThumbSize): Get the size properties directly from the widget now instead of asking the Mozilla code. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Added this helper which reduces the amount of code quite a bit. (WebCore::RenderThemeGtk::gtkContainer): Updated to use helper. (WebCore::RenderThemeGtk::gtkButton): Ditto. (WebCore::RenderThemeGtk::gtkEntry): Ditto. (WebCore::RenderThemeGtk::gtkTreeView): Ditto. (WebCore::RenderThemeGtk::gtkVScale): Added. (WebCore::RenderThemeGtk::gtkHScale): Added. (WebCore::RenderThemeGtk::platformColorsDidChange): Removed GTK_CONTAINER cast.
platform/gtk/RenderThemeGtk.h: Updated to add new GtkHScale and GtkVScale members.
platform/gtk/WidgetRenderingContext.h: Aded new methods to proxy gtk_paint_box, gtk_paint_focus and gtk_paint_slider.
platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintBox): Added. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintBox): Ditto. (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto. (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
platform/gtk/gtk2drawing.c: Removed defunct code! (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtk3drawing.c: Ditto. (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtkdrawing.h:

10:59 AM Changeset in webkit [74128] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.

10:59 AM Changeset in webkit [74127] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Removing another two suppressions for CSS entities garbage collection.

platform/chromium/test_expectations.txt:

10:57 AM Changeset in webkit [74126] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix for r74119.

Fix debugger tests.

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.captureStackTrace):

10:51 AM Changeset in webkit [74125] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Adjusting v8-dependent test expectations.

platform/chromium/test_expectations.txt:

10:49 AM Changeset in webkit [74124] by Martin Robinson

13 edits
2 deletes in trunk

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am:
configure.ac:

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am:
platform/network/soup/cache/webkit/soup-cache.h:

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am:

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

GNUmakefile.am: Removed.
Scripts/generate-forwarding-headers.pl:
WebKit2Prefix.h:
gtk/webkit2.pc.in: Removed.

2010-12-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74117.
http://trac.webkit.org/changeset/74117
https://bugs.webkit.org/show_bug.cgi?id=51113

This broke the GTK1 build. (Requested by mrobinson on
#webkit).

Scripts/webkitdirs.pm:

10:35 AM Changeset in webkit [74123] by Stephanie Lewis

2 edits in /

https://bugs.webkit.org/show_bug.cgi?id=51117
Add a new leopard WK2 test bot

Reviewed by Stephanie Lewis.

BuildSlaveSupport/build.webkit.org-config/config.json:

10:16 AM Changeset in webkit [74122] by jianli@chromium.org

2 edits in trunk/WebCore

Unreviewed. Fixed a clang compiling error by making the forward
declaration of MediaPlayerFactory be consistent with the definition.

platform/graphics/MediaPlayer.h:

10:10 AM Changeset in webkit [74121] by hyatt@apple.com

9 edits in trunk/WebCore

Rename pageY to pageLogicalOffset, since for vertical writing modes it is an x-position rather than a
y-position.

Reviewed by Simon Fraser.

rendering/LayoutState.cpp:

(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):

rendering/LayoutState.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::setPageLogicalOffset):

rendering/RenderBlock.h:

(WebCore::RenderBlock::pageLogicalOffset):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

10:05 AM Changeset in webkit [74120] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium/test_expectations.txt:

9:36 AM Changeset in webkit [74119] by podivilov@chromium.org

9 edits in trunk/WebCore

2010-12-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move scripts storage from ScriptsPanel to DebuggerModel.
https://bugs.webkit.org/show_bug.cgi?id=50908

inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._debuggerPaused):
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.update):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype._setBreakpoint): (WebInspector.DebuggerModel.prototype.scriptForSourceID): (WebInspector.DebuggerModel.prototype.scriptsForURL): (WebInspector.DebuggerModel.prototype.queryScripts): (WebInspector.DebuggerModel.prototype.parsedScriptSource): (WebInspector.DebuggerModel.prototype.failedToParseScriptSource): (WebInspector.DebuggerModel.prototype.breakpointRestored): (WebInspector.DebuggerModel.prototype.debuggerPaused): (WebInspector.DebuggerModel.prototype.debuggerResumed):
inspector/front-end/Resource.js:
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): eliminate sourceIDMap
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._setBreakpoint):
inspector/front-end/SourceView.js: (WebInspector.SourceView):
inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.parsedScriptSource): (WebInspector.failedToParseScriptSource):

9:27 AM Changeset in webkit [74118] by eric.carlson@apple.com

3 edits in trunk/WebCore

2010-12-15 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

MediaPlayer should try all installed media engines
https://bugs.webkit.org/show_bug.cgi?id=50209

platform/graphics/MediaPlayer.cpp: (WebCore::bestMediaEngineForTypeAndCodecs): Rename from chooseBestEngineForTypeAndCodecs. Take optional parameter for current engine. (WebCore::nextMediaEngine): New, return the next media engine in the list. (WebCore::MediaPlayer::MediaPlayer): Initialize reload timer. (WebCore::MediaPlayer::load): Store url, mime type, and codecs parameter in member variables. (WebCore::MediaPlayer::loadWithNextMediaEngine): New, initiate loading with the next media engine. (WebCore::MediaPlayer::supportsType): Make contentType parameter const. (WebCore::MediaPlayer::reloadTimerFired): New, call loadWithNextMediaEngine. (WebCore::MediaPlayer::networkStateChanged): If network state signals a failure and the file's metadata has not loaded, give the next installed engine a try.
platform/graphics/MediaPlayer.h:

9:10 AM BuildingGtk edited by Martin Robinson

Made required build steps more prominant (diff)

8:51 AM Changeset in webkit [74117] by commit-queue@webkit.org

13 edits
3 adds in trunk

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

GNUmakefile.am: Changes to build either of WebKit1 or WebKit2. It basically excludes all WebKit/gtk/webkit/ files when building WebKit2. Also, exludes Unittests, DumprenderTree, GtkLauncher etc for WebKit2.
configure.ac: Option for enable or disable WebKit2.

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port
(https://bugs.webkit.org/show_bug.cgi?id=37369)

No new functionality added or deleted. Only makefile change. Hence, no tests added.

GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

GNUmakefile.am: Added WebCore/bindings/gobject to webkitgtk_sources & webkitgtk_cppflags. They should get compiled only when WebKit/gtk/GNUmakefile.am is getting included but not with WebKit2/GNUmakefile.am inclusion.

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

GNUmakefile.am: Added.
Scripts/generate-forwarding-headers.pl: For GTK port, taking 1 extra argument for copying network headers.
WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
gtk: Added.
gtk/webkit2.pc.in: Added.

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Change generate-forwarding-headers.pl for GTK port usage
(https://bugs.webkit.org/show_bug.cgi?id=37369)

Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.

8:13 AM Changeset in webkit [74116] by yurys@chromium.org

2 edits
2 deletes in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-mac/storage/private-browsing-noread-nowrite-expected.txt: Removed.
platform/chromium-win/storage/private-browsing-noread-nowrite-expected.txt: Removed.
platform/chromium/test_expectations.txt: test private-browsing-readonly.html was renamed into private-browsing-noread-nowrite.html in r74093, changing expecations accrodingly.

8:00 AM Changeset in webkit [74115] by commit-queue@webkit.org

10 edits in trunk

2010-12-15 Jarred Nicholls <jarred@sencha.com>

Reviewed by Andreas Kling.

[Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:
platform/qt/fast/js/global-constructors-expected.txt:

2010-12-15 Jarred Nicholls <jarred@sencha.com>

Reviewed by Andreas Kling.

[Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839

No new tests. fast/files tests work when manually operated.
They do not automatically work due to Qt's inability to handle multi-file
inputs (https://bugs.webkit.org/show_bug.cgi?id=22048) as well as Qt's DRT
is missing an eventSender.beginDragWithFiles implementation.

WebCore.pri:
WebCore.pro:
features.pri:
platform/qt/FileSystemQt.cpp: (WebCore::directoryName): (WebCore::readFromFile): (WebCore::seekFile):

6:31 AM Changeset in webkit [74114] by yurys@chromium.org

10 edits
9 adds in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline Chromium tests.

platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
platform/chromium-linux/fast/box-shadow/inset-expected.checksum:
platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/css/focus-ring-detached-expected.checksum: Added.
platform/chromium-linux/fast/css/focus-ring-detached-expected.png: Added.
platform/chromium-linux/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/chromium-linux/fast/css/focus-ring-multiline-expected.png: Added.
platform/chromium-mac/fast/css/focus-ring-detached-expected.checksum: Added.
platform/chromium-mac/fast/css/focus-ring-detached-expected.png: Added.
platform/chromium-mac/fast/css/focus-ring-multiline-expected.checksum: Added.
platform/chromium-mac/fast/css/focus-ring-multiline-expected.png: Added.
platform/chromium-win/fast/css/focus-ring-detached-expected.checksum:
platform/chromium-win/fast/css/focus-ring-detached-expected.png:
platform/chromium-win/fast/css/focus-ring-detached-expected.txt:
platform/chromium-win/fast/css/focus-ring-multiline-expected.checksum:
platform/chromium-win/fast/css/focus-ring-multiline-expected.png:
platform/chromium-win/fast/css/focus-ring-multiline-expected.txt:
platform/chromium/test_expectations.txt:

5:47 AM Changeset in webkit [74113] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark fast/dom/global-constructors.html as flaky on Chromium.

platform/chromium/test_expectations.txt:

5:38 AM Changeset in webkit [74112] by sergio@webkit.org

2 edits in trunk/LayoutTests

2010-12-15 Sergio Villar Senin <svillar@igalia.com>

Unreviewed, skipping failing tests in the bots.

[GTK] HTTP tests failing/crashing in the bots
https://bugs.webkit.org/show_bug.cgi?id=51104

platform/gtk/Skipped:

5:14 AM Changeset in webkit [74111] by yurys@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark one more compositing test as timing out on chromium-gpu.

platform/chromium-gpu/test_expectations.txt:

4:52 AM Changeset in webkit [74110] by yurys@chromium.org

13 edits
9 adds in trunk/LayoutTests

2010-12-15 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline Chromium test expectations.

platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/chromium-linux/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/chromium-mac/http/tests/misc/authentication-sent-to-redirect-expected.txt: Added.
platform/chromium-mac/storage/private-browsing-noread-nowrite-expected.txt: Added.
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
platform/chromium-win/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
platform/chromium-win/http/tests/misc/authentication-sent-to-redirect-expected.txt: Added.
platform/chromium-win/storage/private-browsing-noread-nowrite-expected.txt: Added.

4:43 AM Changeset in webkit [74109] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2010-12-15 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix for r74103.

Fix dom-breakpoints test.

inspector/dom-breakpoints.html:

4:34 AM Changeset in webkit [74108] by commit-queue@webkit.org

2 edits in trunk/WebKit2

2010-12-15 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt][WK2] webkit2 does not compile on OS X
https://bugs.webkit.org/show_bug.cgi?id=50128

prctl(2) is only available on Linux, so use an atexit handler for killing
all the child processes when the process is exiting.

UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::cleanupProcesses): (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::processStateChanged): (WebKit::ProcessLauncherHelper::instance):

3:27 AM Changeset in webkit [74107] by Antti Koivisto

9 edits
2 adds in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=49548
WebCore cache stores duplicate copies of subresources with URL fragments

Reviewed by Alexey Proskuryakov.

Strip fragment identifiers from HTTP and file URLs for the memory cache.
Changed some CachedResourceLoader and MemoryCache interfaces to use KURLs instead of strings to reduce repeated URL parsing.

Test: http/tests/cache/subresource-fragment-identifier.html

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::cachedResource):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::cachedResource):
(WebCore::CachedResourceLoader::checkForReload):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):

loader/cache/CachedResourceLoader.h:
loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::requestResource):
(WebCore::MemoryCache::requestUserCSSStyleSheet):
(WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
(WebCore::MemoryCache::resourceForURL):

loader/cache/MemoryCache.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=49548
WebCore cache stores duplicate copies of subresources with URL fragments

Reviewed by Alexey Proskuryakov.

http/tests/cache/subresource-fragment-identifier-expected.txt: Added.
http/tests/cache/subresource-fragment-identifier.html: Added.

2:57 AM Changeset in webkit [74106] by antonm@chromium.org

2 edits in trunk/WebCore

2010-12-15 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[v8] Next round of CSS GC story: proper grouping of CSSStyleDeclarations
https://bugs.webkit.org/show_bug.cgi?id=50965

bindings/v8/V8GCController.cpp: (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper): (WebCore::DOMObjectGrouperVisitor::addAllItems):

2:49 AM Changeset in webkit [74105] by commit-queue@webkit.org

1 edit in trunk/ChangeLog

2010-12-14 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

2:40 AM Changeset in webkit [74104] by commit-queue@webkit.org

1 edit in trunk/ChangeLog

2010-12-14 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

2:39 AM Changeset in webkit [74103] by podivilov@chromium.org

13 edits in trunk/WebCore

2010-12-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: push persistent breakpoints into backend state cookie so they hit on navigation.
https://bugs.webkit.org/show_bug.cgi?id=48858

BreakpointManager pushes all persistent breakpoints to backend when loaded.
InspectorController restores sticky breakpoints from cookie on navigation.

inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
inspector/InspectorController.h:
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::getObject): (WebCore::InspectorState::setObject): (WebCore::InspectorState::registerObject):
inspector/InspectorState.h:
inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype._removeListElement): (WebInspector.BreakpointsSidebarPane.prototype._projectChanged): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._projectChanged):
inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane):
inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
inspector/front-end/Settings.js: (WebInspector.Settings.prototype.inspectedURLChanged): (WebInspector.Settings.prototype.get projectId): (WebInspector.Settings.prototype.findSettingForAllProjects): (WebInspector.Settings.prototype._formatProjectKey):
inspector/front-end/inspector.js: (WebInspector.createDOMBreakpointsSidebarPane): (WebInspector.createXHRBreakpointsSidebarPane): (WebInspector.reset): (WebInspector.inspectedURLChanged):

2:24 AM Changeset in webkit [74102] by mario@webkit.org

2 edits in trunk/WebCore

2010-12-15 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, fix compilation warnings after r74066.

rendering/RenderBox.cpp: (WebCore::layersUseImage): Place this static function between the same if-def region used in the only place where it's called from.

1:47 AM Changeset in webkit [74101] by commit-queue@webkit.org

3 edits
2 adds in trunk

2010-12-15 Emil Eklund <eae@chromium.org>

Reviewed by Adam Barth.

Added test for infinite loop in ContainerNode::willRemoveChildren.
https://bugs.webkit.org/show_bug.cgi?id=51079

fast/dom/containerNode-expected.txt: Added.
fast/dom/containerNode.html: Added.

2010-12-15 Emil Eklund <eae@chromium.org>

Reviewed by Adam Barth.

Change ContainerNode::willRemoveChildren to not fire mutation events for children
added as a result of a mutation event, thereby avoiding an infinite loop.
https://bugs.webkit.org/show_bug.cgi?id=51079

Test: fast/dom/containerNode.html

dom/ContainerNode.cpp: (WebCore::willRemoveChildren): Don't fire mutation events for children added during a mutation event.

12:10 AM Changeset in webkit [74100] by Csaba Osztrogonác

2 edits
1 copy in trunk/LayoutTests

Unreviewed.

platform/qt/Skipped: Add http/tests/misc/authentication-sent-to-redirect.html because of missing layoutTestController.setHandlesAuthenticationChallenges()
platform/qt/plugins/document-open-expected.txt: Copied from LayoutTests/plugins/document-open-expected.txt.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed