Context Navigation

← Previous Period
Next Period →

Timeline

Sep 23, 2011:

10:42 PM Changeset in webkit [95905] by barraclough@apple.com

3 edits in trunk

Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.

Add cmake options to enable DFG JIT compilation for EFL port

Source/cmake/OptionsEfl.cmake:
Source/cmakeconfig.h.cmake:

10:30 PM Changeset in webkit [95904] by commit-queue@webkit.org

2 edits in trunk/Tools

[DRT] Include the right config file for EFL's DRT.
https://bugs.webkit.org/show_bug.cgi?id=67042

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Martin Robinson.

Ports which use CMake as their buildsystem (such as the EFL one) also
have config.h files, but they are named differently, so include the
right one depending on the buildsystem being used.

DumpRenderTree/config.h:

10:11 PM Changeset in webkit [95903] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Fix the build.

loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck): Get rid of the exit-time destructor.

10:04 PM Changeset in webkit [95902] by barraclough@apple.com

21 edits
4 adds in trunk/Source/JavaScriptCore

Add JSVALUE32_64 support to DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=67460

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-23
Reviewed by Gavin Barraclough.

This is the initial attempt to add JSVALUE32_64 support to DFG JIT.
It's tested on IA32 Linux EFL port currently. It still cannot run
all the test cases and benchmarks so should be turned off now.

The major work includes:
1) dealing with JSVALUE32_64 data format in DFG JIT;
2) bindings between 64-bit JS Value and 32-bit registers;
3) handling of function calls. Currently for DFG operation function
calls we follow the X86 cdecl calling convention on Linux, and the
implementation is in a naive way by pushing the arguments into stack
one by one.

The known issues include:
1) some code duplicates unnecessarily, especially in Speculative JIT
code generation, where most of the operations on SpeculataInteger /
SpeculateDouble should be identical to the JSVALUE64 code. Refactoring
is needed in the future;
2) lack of op_call and op_construct support, comparing to current
JSVALUE64 DFG;
3) currently integer speculations assume to be StrictInt32;
4) lack of JSBoolean speculations;
5) boxing and unboxing doubles could be improved;
6) DFG X86 register description is different with the baseline JIT,
the timeoutCheckRegister is used for general purpose usage;
7) calls to runtime functions with primitive double parameters (e.g.
fmod) don't work. Support needs to be added to the assembler to
implement the mechanism of passing double parameters for X86 cdecl
convention.

And there should be many other hidden bugs which should be exposed and
resolved in later debugging process.

CMakeListsEfl.txt:
assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::loadDouble):
(JSC::MacroAssemblerX86::storeDouble):

assembler/X86Assembler.h:

(JSC::X86Assembler::movsd_rm):

bytecode/StructureStubInfo.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGFPRInfo.h:

(JSC::DFG::FPRInfo::debugName):

dfg/DFGGPRInfo.h:

(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

dfg/DFGGenerationInfo.h:

(JSC::DFG::needDataFormatConversion):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::gpr):
(JSC::DFG::GenerationInfo::tagGPR):
(JSC::DFG::GenerationInfo::payloadGPR):
(JSC::DFG::GenerationInfo::fpr):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillDouble):

dfg/DFGJITCodeGenerator.cpp:
dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::allocate):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::registersMatched):
(JSC::DFG::JITCodeGenerator::silentSpillGPR):
(JSC::DFG::JITCodeGenerator::silentFillGPR):
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
(JSC::DFG::JITCodeGenerator::silentFillAllRegisters):
(JSC::DFG::JITCodeGenerator::boxDouble):
(JSC::DFG::JITCodeGenerator::unboxDouble):
(JSC::DFG::JITCodeGenerator::spill):
(JSC::DFG::addressOfDoubleConstant):
(JSC::DFG::integerResult):
(JSC::DFG::jsValueResult):
(JSC::DFG::setupResults):
(JSC::DFG::callOperation):
(JSC::JSValueOperand::JSValueOperand):
(JSC::JSValueOperand::~JSValueOperand):
(JSC::JSValueOperand::isDouble):
(JSC::JSValueOperand::fill):
(JSC::JSValueOperand::tagGPR):
(JSC::JSValueOperand::payloadGPR):
(JSC::JSValueOperand::fpr):
(JSC::GPRTemporary::~GPRTemporary):
(JSC::GPRTemporary::gpr):
(JSC::GPRResult2::GPRResult2):

dfg/DFGJITCodeGenerator32_64.cpp: Added.

(JSC::DFG::JITCodeGenerator::clearGenerationInfo):
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::fillStorage):
(JSC::DFG::JITCodeGenerator::useChildren):
(JSC::DFG::JITCodeGenerator::isStrictInt32):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeUInt32ToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCheckHasInstance):
(JSC::DFG::JITCodeGenerator::nonSpeculativeInstanceOf):
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::cachedPutById):
(JSC::DFG::JITCodeGenerator::cachedGetMethod):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranchNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompareNull):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeStrictEq):
(JSC::DFG::JITCodeGenerator::emitBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
(JSC::DFG::JITCodeGenerator::emitCall):
(JSC::DFG::JITCodeGenerator::speculationCheck):
(JSC::DFG::dataFormatString):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):

dfg/DFGJITCompiler.cpp:
dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::tagForGlobalVar):
(JSC::DFG::JITCompiler::payloadForGlobalVar):
(JSC::DFG::JITCompiler::appendCallWithExceptionCheck):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::boxDouble):
(JSC::DFG::JITCompiler::unboxDouble):
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):

dfg/DFGJITCompiler32_64.cpp: Added.

(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::jitAssertIsInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSInt32):
(JSC::DFG::JITCompiler::jitAssertIsJSNumber):
(JSC::DFG::JITCompiler::jitAssertIsJSDouble):
(JSC::DFG::JITCompiler::jitAssertIsCell):
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):

dfg/DFGJITCompilerInlineMethods.h: Added.

(JSC::DFG::JITCompiler::emitLoadTag):
(JSC::DFG::JITCompiler::emitLoadPayload):
(JSC::DFG::JITCompiler::emitLoad):
(JSC::DFG::JITCompiler::emitLoad2):
(JSC::DFG::JITCompiler::emitLoadDouble):
(JSC::DFG::JITCompiler::emitLoadInt32ToDouble):
(JSC::DFG::JITCompiler::emitStore):
(JSC::DFG::JITCompiler::emitStoreInt32):
(JSC::DFG::JITCompiler::emitStoreCell):
(JSC::DFG::JITCompiler::emitStoreBool):
(JSC::DFG::JITCompiler::emitStoreDouble):

dfg/DFGNode.h:
dfg/DFGOperations.cpp:
dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryCachePutByID):

dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT.h:

(JSC::DFG::ValueRecovery::inGPR):
(JSC::DFG::ValueRecovery::inPair):
(JSC::DFG::ValueRecovery::tagGPR):
(JSC::DFG::ValueRecovery::payloadGPR):

dfg/DFGSpeculativeJIT32_64.cpp: Added.

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

runtime/JSValue.h:

9:23 PM Changeset in webkit [95901] by Darin Adler

6034 edits in trunk/Source

Set eol-style to native on many source files where it was unset.

8:51 PM Changeset in webkit [95900] by abarth@webkit.org

3 edits in trunk/Source/WebCore

Canvas security checks show up on HTML5GamingTest benchmark
https://bugs.webkit.org/show_bug.cgi?id=68743

Reviewed by Oliver Hunt.

Prior to this patch, the canvas security checks took as much as 4% of
the time on the HTML5GamingTest benchmark:

http://craftymind.com/factory/guimark2/HTML5GamingTest.html

This patch uses a couple of AtomicStrings and shuffles around the order
of the security check to take this down to around 0.1% (which is near
the noise floor of what I can measure with my profiler).

html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

8:24 PM Changeset in webkit [95899] by commit-queue@webkit.org

7 edits in trunk

Source/WebCore: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
Return early without throwing an exception if source rectangle is out of
bounds to match the spec.

LayoutTests: Unwarranted DOM Exception when canvas2D drawImage is called with src
rect is out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Patch by Justin Novosad <junov@chromium.org> on 2011-09-23
Reviewed by Oliver Hunt.

fast/canvas/drawImage-with-invalid-args-expected.txt:
fast/canvas/drawImage-with-invalid-args.html:

This test covers (among other things) cases where the source rectangle is
_completely_ outside the bounds of the source image. It was modified to no
longer expect DOM exceptions

platform/chromium/test_expectations.txt:

Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
is now expected to fail

platform/mac/Skipped:

Skipping canvas/philip/tests/2d.drawImage.outsidesource.html

8:20 PM Changeset in webkit [95898] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Printing of notImplemented() when logging enabled.
https://bugs.webkit.org/show_bug.cgi?id=64590

Printing of notImplemented() method was enabled on Debug builds only.
Now it is enabled when logging is enabled.

Patch by Lukasz Slachciak <l.slachciak@samsung.com> on 2011-09-23
Reviewed by Oliver Hunt.

No new tests because there is no new functionality.

platform/NotImplemented.h: Non-debug mode replaced with non-logging mode.

8:12 PM Changeset in webkit [95897] by mihaip@chromium.org

3 edits
2 adds in trunk

[Chromium] REGRESSION (r95725): Resizing a window doesn't resize the contents
https://bugs.webkit.org/show_bug.cgi?id=68730

Reviewed by James Robinson.

Source/WebCore:

Adds a missing contentsResized() call in ScrollView::setFrameRect.

Test: fast/dom/Window/window-resize-contents.html

platform/ScrollView.cpp:

(WebCore::ScrollView::setFrameRect):

LayoutTests:

Test for resizing of the window triggering resizing of contents.

fast/dom/Window/window-resize-contents-expected.txt: Added.
fast/dom/Window/window-resize-contents.html: Added.

8:12 PM Changeset in webkit [95896] by commit-queue@webkit.org

2 edits in trunk

[CMake] Detect amd64 as a valid 64-bit architecture.
https://bugs.webkit.org/show_bug.cgi?id=67481

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-23
Reviewed by Oliver Hunt.

Some operating systems (generally the BSDs) use amd64 instead of x86_64
to report they're running on 64 bits, so consider it a valid value.

Source/CMakeLists.txt:

7:07 PM Changeset in webkit [95895] by fpizlo@apple.com

7 edits
1 add in trunk/Source/JavaScriptCore

wtf/BitVector.h has a variety of bugs which manifest when the
vector grows beyond 63 bits
https://bugs.webkit.org/show_bug.cgi?id=68746

Reviewed by Oliver Hunt.

Out-of-lined slow path code in BitVector so that not every user
of CodeBlock ends up having to compile it. Fixed a variety of
index computation and size computation bugs.

I have not seen these issues manifest themselves, but they are
blocking a patch that uses BitVector more aggressively.

GNUmakefile.list.am:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
wtf/BitVector.cpp: Added.

(BitVector::BitVector):
(BitVector::operator=):
(BitVector::resize):
(BitVector::clearAll):
(BitVector::OutOfLineBits::create):
(BitVector::OutOfLineBits::destroy):
(BitVector::resizeOutOfLine):

wtf/BitVector.h:

(WTF::BitVector::ensureSize):
(WTF::BitVector::get):
(WTF::BitVector::set):
(WTF::BitVector::clear):
(WTF::BitVector::byteCount):
(WTF::BitVector::OutOfLineBits::numWords):
(WTF::BitVector::OutOfLineBits::bits):
(WTF::BitVector::outOfLineBits):

wtf/CMakeLists.txt:
wtf/wtf.pri:

6:25 PM Changeset in webkit [95894] by adamk@chromium.org

18 edits in trunk

Add ENABLE_MUTATION_OBSERVERS feature flag
https://bugs.webkit.org/show_bug.cgi?id=68732

Reviewed by Ojan Vafai.

This flag will guard an implementation of the "Mutation Observers" proposed in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html

configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:

Source/WebKit/chromium:

features.gypi:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

6:19 PM Changeset in webkit [95893] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

De-virtualize JSCell::getJSNumber
https://bugs.webkit.org/show_bug.cgi?id=68651

Reviewed by Oliver Hunt.

Added a new JSType to check whether or not something is a
NumberObject (which includes NumberPrototype) in TypeInfo::isNumberObject because there's not
currently a better way to determine whether something is indeed a NumberObject.
Also de-virtualized JSCell::getJSNumber, having it check the TypeInfo
for whether the object is a NumberObject or not. This patch is part of
the larger process of de-virtualizing JSCell.

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
runtime/JSCell.cpp:

(JSC::JSCell::getJSNumber):

runtime/JSCell.h:

(JSC::JSValue::getJSNumber):

runtime/JSType.h:
runtime/JSTypeInfo.h:

(JSC::TypeInfo::isNumberObject):

runtime/JSValue.h:
runtime/NumberObject.cpp:

(JSC::NumberObject::getJSNumber):

runtime/NumberObject.h:

(JSC::NumberObject::createStructure):

runtime/NumberPrototype.h:

(JSC::NumberPrototype::createStructure):

6:12 PM Changeset in webkit [95892] by mihaip@chromium.org

2 edits
3 adds in trunk/LayoutTests

Rebaseline fast/ruby/ruby-text-before-after-content.html for Chromium Mac.

Mark media/controls-right-click-on-timebar.html as flaky.

platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/ruby/ruby-text-before-after-content-expected.txt: Added.
platform/chromium-mac/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium/test_expectations.txt:

5:44 PM Changeset in webkit [95891] by jcivelli@chromium.org

2 edits in trunk/Source/WebKit/chromium

Making some WebBlob methods exportable.
This is needed by the shared lib chromium build.
https://bugs.webkit.org/show_bug.cgi?id=68709

Reviewed by Darin Fisher.

public/WebBlob.h:

5:23 PM Changeset in webkit [95890] by commit-queue@webkit.org

16 edits
4 adds in trunk

.: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

Source/autotools/symbols.filter:

Source/WebCore: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

Tests: fast/dom/scroll-element-to-rect-centered.html

fast/dom/scroll-element-to-rect.html

WebCore.exp.in:
page/FrameView.cpp:

(WebCore::FrameView::scrollElementToRect):

page/FrameView.h:
testing/Internals.cpp:

(WebCore::Internals::scrollElementToRect):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/chromium: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

public/WebView.h:

(WebKit::WebView::scrollFocusedNodeIntoRect):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

Source/WebKit2: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

win/WebKit2.def:
win/WebKit2CFLite.def:

LayoutTests: Refactor WebViewImpl::scrollFocusedNodeIntoRect to a better place and add tests
https://bugs.webkit.org/show_bug.cgi?id=68198

Patch by Varun Jain <varunjain@google.com> on 2011-09-23
Reviewed by Dimitri Glazkov.

fast/dom/scroll-element-to-rect-centered-expected.txt: Added.
fast/dom/scroll-element-to-rect-centered.html: Added.
fast/dom/scroll-element-to-rect-expected.txt: Added.
fast/dom/scroll-element-to-rect.html: Added.

5:07 PM Changeset in webkit [95889] by mihaip@chromium.org

7 edits in trunk/Source

Unreviewed, rolling out r95860.
http://trac.webkit.org/changeset/95860
https://bugs.webkit.org/show_bug.cgi?id=68648

Breaks overhang rendering on Chromium Mac

Source/WebCore:

platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromium.h:
platform/chromium/ScrollbarThemeChromiumMac.h:
platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
(WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):

Source/WebKit/chromium:

features.gypi:

4:43 PM Changeset in webkit [95888] by dino@apple.com

10 edits
6 adds in trunk

Add -webkit-filter to CSSPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=68675

Reviewed by Simon Fraser.

Add property and rudimentary parsing for -webkit-filter. The
property value isn't preserved anywhere yet. Add
stub definition for computed style.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilter):

css/CSSParser.h:
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

New test for rudimentary parsing of -webkit-filter.
Since currently only the Apple port enables the
feature, add this new test to the platform skip lists
for GTK, QT and Chromium.

css3/filters/filter-property-expected.txt: Added.
css3/filters/filter-property.html: Added.
css3/filters/script-tests/TEMPLATE.html: Added.
css3/filters/script-tests/filter-property.js: Added.
platform/chromium/test_expectations.txt:
platform/gtk/Skipped:
platform/qt/Skipped:

4:28 PM Changeset in webkit [95887] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

Resolve opcodes should have value profiling.
https://bugs.webkit.org/show_bug.cgi?id=68723

Reviewed by Oliver Hunt.

This adds value profiling to all forms of op_resolve in the
old JIT, and patches that information into the DFG along with
performing the appropriate type propagation.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveGlobalDataIndex):
(JSC::DFG::Node::hasPrediction):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emit_op_resolve_skip):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emitSlow_op_resolve_global):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_global_dynamic):

jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

4:25 PM Changeset in webkit [95886] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Remove preserves3D() from CCLayerDelegate, replacing it by setting the
value explicitly after creating a layer, or setting its delegate.
https://bugs.webkit.org/show_bug.cgi?id=68295

Patch by Antoine Labour <piman@chromium.org> on 2011-09-23
Reviewed by James Robinson.

Covered by compositing/ layeout tests.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::setupContentsLayer):

platform/graphics/chromium/GraphicsLayerChromium.h:
platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setPreserves3D):
(WebCore::LayerChromium::preserves3D):

4:24 PM Changeset in webkit [95885] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

chrome.dll!WebCore::ApplyStyleCommand::applyBlockStyle ReadAV@NULL (64db547804532a84be2e53721e499e9e)
https://bugs.webkit.org/show_bug.cgi?id=51639

Patch by Jay Soffian <jaysoffian@gmail.com> on 2011-09-23
Reviewed by Tony Chang.

Add repro for a crash inside WebCore::ApplyStyleCommand::applyBlockStyle. Fixed by r94840.

editing/style/justify-without-enclosing-block-expected.txt: Added.
editing/style/justify-without-enclosing-block.xhtml: Added.

4:19 PM Changeset in webkit [95884] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix windows build.

4:17 PM Changeset in webkit [95883] by abarth@webkit.org

2 edits in trunk/LayoutTests

Note flaky test.

platform/chromium/test_expectations.txt:

4:16 PM Changeset in webkit [95882] by mrowe@apple.com

5 edits in trunk/Source

Versioning.

4:14 PM Changeset in webkit [95881] by mrowe@apple.com

1 copy in tags/Safari-535.4

New tag.

4:12 PM Changeset in webkit [95880] by commit-queue@webkit.org

1 edit
4 adds in trunk/LayoutTests

Add a few more possiblities to the test cases for xss denial.
https://bugs.webkit.org/show_bug.cgi?id=47120

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-23
Reviewed by Adam Barth.

http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Added.
http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Added.
http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt: Added.
http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces.html: Added.

4:11 PM Changeset in webkit [95879] by jchaffraix@webkit.org

2 edits in trunk/Source/WebCore

Implicit conversion double to float in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68722

Reviewed by Simon Fraser.

platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::adjustBlurRadius): Added 2 explicit
conversions.

4:02 PM Changeset in webkit [95878] by commit-queue@webkit.org

13 edits in trunk

[WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68556

Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.

Source/WebKit2:

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

Shared/API/c/WKGeometry.h:

(operator==):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEventSyncForTesting): initialize "handled"

Tools:

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

WebKitTestRunner/EventSenderProxy.h:
WebKitTestRunner/InjectedBundle/EventSendingController.h:
WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::leapForward):

WebKitTestRunner/qt/EventSenderProxyQt.cpp:

(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButton):
(WTR::getModifiers):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::leapForward):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::postEvent):

WebKitTestRunner/qt/WebKitTestRunner.pro:

LayoutTests:

Unskip passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-23
Reviewed by Darin Adler.

platform/qt-wk2/Skipped:

3:59 PM Changeset in webkit [95877] by barraclough@apple.com

4 edits
3 adds in trunk

Source/JavaScriptCore: Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

parser/JSParser.cpp:

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

parser/SourceProviderCacheItem.h:

LayoutTests: gh@apple.com>

Strict mode does not work in non-trivial nested functions.
https://bugs.webkit.org/show_bug.cgi?id=68740

Reviewed by Oliver Hunt.

Function-info caching does not preserve all state that it should.

fast/js/nested-functions-expected.txt: Added.
fast/js/nested-functions.html: Added.
fast/js/script-tests/nested-functions.js: Added.

(runTests.test1):
(runTests.test2):
(runTests.test3):
(runTests):

3:58 PM Changeset in webkit [95876] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

ValueToDouble handling in prediction propagation should be ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=68724

Reviewed by Oliver Hunt.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

3:47 PM Changeset in webkit [95875] by commit-queue@webkit.org

2 edits in trunk/Tools

[chromium] Make the layout test script's kill timeout proportional to --time-out-ms
https://bugs.webkit.org/show_bug.cgi?id=68026

Patch by Lei Zhang <thestig@chromium.org> on 2011-09-23
Reviewed by Dirk Pranke.

Scripts/webkitpy/layout_tests/port/chromium.py:

3:45 PM Changeset in webkit [95874] by mitz@apple.com

3 edits
2 adds in trunk

<rdar://problem/10178576> REGRESSION (r95391): Crash in -[WebCascadeList objectAtIndex:] when a font-family list contains missing fonts
https://bugs.webkit.org/show_bug.cgi?id=68737

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/text/combining-character-sequence-fallback-crash.html

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(-[WebCascadeList initWithFont:WebCore::character:]): Changed to intialize _count to the exact
number of FontData instances in the fallback list rather than the number of font families in the
font description.

LayoutTests:

fast/text/combining-character-sequence-fallback-crash-expected.txt: Added.
fast/text/combining-character-sequence-fallback-crash.html: Added.

3:44 PM Changeset in webkit [95873] by adamk@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Remove WEBWIDGET_HAS_ANIMATE_CHANGES #define
https://bugs.webkit.org/show_bug.cgi?id=68720

Reviewed by James Robinson.

References to this macro were removed in http://crrev.com/102314.

public/WebWidget.h:

3:41 PM Changeset in webkit [95872] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Build fix.

3:34 PM Changeset in webkit [95871] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Crash in WebCore::DatabaseObserver
https://bugs.webkit.org/show_bug.cgi?id=67805

Patch by Stephen Chenney <schenney@chromium.org> on 2011-09-23
Reviewed by David Levin.

src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::canEstablishDatabase): Added a check for a
null frame or page, and return false if null. Investigated
changing the fall-through return value to false but decided against
it given the way the code is used and existing default values for
related code. Reproduction and testing depends on having a document
with no frame or no page, which sometimes happens in practice but is
hard to construct explicitly.

3:28 PM Changeset in webkit [95870] by commit-queue@webkit.org

10 edits
4 adds
1 delete in trunk

[Chromium] Fix CSS 3D corner anti-aliasing.
https://bugs.webkit.org/show_bug.cgi?id=68087

Patch by David Reveman <reveman@chromium.org> on 2011-09-23
Reviewed by James Robinson.

Source/WebCore:

Render sharp corners more correctly by adding bounding box
edges to anti-aliasing shaders.

Test: platform/chromium/compositing/3d-corners.html

platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderRGBATexAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexClampSwizzleAlphaAA::getShaderString):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::getShaderString):

platform/graphics/chromium/cc/CCRenderSurface.cpp:

(WebCore::CCRenderSurface::drawLayer):
(WebCore::CCRenderSurface::drawSurface):

platform/graphics/chromium/cc/CCRenderSurface.h:
platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::draw):
(WebCore::CCTiledLayerImpl::drawTiles):

platform/graphics/chromium/cc/CCTiledLayerImpl.h:

LayoutTests:

Add a test to check sharp corner rendering of CSS 3D transformed
elements.

platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.checksum: Removed.
platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Added.
platform/chromium-gpu-linux/platform/chromium/compositing/3d-corners-expected.png: Added.
platform/chromium-gpu-linux/platform/chromium/compositing/backface-visibility-transformed-expected.png:
platform/chromium-gpu-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium/compositing/3d-corners-expected.txt: Added.
platform/chromium/compositing/3d-corners.html: Added.
platform/chromium/test_expectations.txt:

3:22 PM Changeset in webkit [95869] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Add failing expectations for tests added by r95852.

platform/chromium/test_expectations.txt:

3:13 PM Changeset in webkit [95868] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG implementation of PutScopedVar corrupts register allocation
https://bugs.webkit.org/show_bug.cgi?id=68735

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-23
Reviewed by Oliver Hunt.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

3:10 PM Changeset in webkit [95867] by barraclough@apple.com

3 edits in trunk/LayoutTests

Updating now-passing Layout test.

Rubber stamped by geoff garen

fast/js/Object-getOwnPropertyNames-expected.txt:
fast/js/script-tests/Object-getOwnPropertyNames.js:

3:08 PM Changeset in webkit [95866] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/rendering

Merge 95857 - Source/WebCore: Style not updated for :before, :after content
in ruby text.
BUG=97546
Review URL: http://codereview.chromium.org/8037003

3:05 PM Changeset in webkit [95865] by oliver@apple.com

17 edits
2 adds in trunk/Source

Make write barriers actually do something when enabled
https://bugs.webkit.org/show_bug.cgi?id=68717

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a basic card marking style write barrier to JSC (currently
turned off). This requires two scratch registers in the JIT
so there was some register re-arranging to satisfy that requirement.
Happily this produced a minor perf bump in sunspider (~0.5%).

Turning the barriers on causes an overall regression of around 1.5%

JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store8):

assembler/X86Assembler.h:

(JSC::X86Assembler::movb_i8m):

dfg/DFGJITCodeGenerator.cpp:

(JSC::DFG::JITCodeGenerator::isKnownNotCell):
(JSC::DFG::JITCodeGenerator::writeBarrier):
(JSC::DFG::JITCodeGenerator::markCellCard):
(JSC::DFG::JITCodeGenerator::cachedPutById):

dfg/DFGJITCodeGenerator.h:
dfg/DFGRepatch.cpp:

(JSC::DFG::tryCachePutByID):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

heap/CardSet.h: Added.

(JSC::CardSet::CardSet):
(JSC::::cardForAtom):
(JSC::::cardMarkedForAtom):
(JSC::::markCardForAtom):

heap/Heap.cpp:
heap/Heap.h:

(JSC::Heap::addressOfCardFor):
(JSC::Heap::writeBarrierFastCase):

heap/MarkedBlock.h:

(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
(JSC::MarkedBlock::offsetOfCards):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emitWriteBarrier):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_put_global_var):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header, and fix an evaluation ordering
issue that shows up if you try to use write barriers.

ForwardingHeaders/heap/CardSet.h: Added.
bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

2:59 PM Changeset in webkit [95864] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=68077
SH4 assemblers doesn't refer to executable memory handle.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-23
Reviewed by Gavin Barraclough.

assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branch8):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::executableCopy):

2:51 PM Changeset in webkit [95863] by jamesr@google.com

4 edits in trunk/Source/WebCore

Avoid updating compositing state during paint
https://bugs.webkit.org/show_bug.cgi?id=68727

Reviewed by Simon Fraser.

We shouldn't update our compositing state in the middle of a paint. The call to
updateCompositingAndLayerListsIfNeeded() was added to RenderLayer::paintLayer in r45715, which was intended to
fix this exact issue. Based off the ChangeLog entries, I think that this was just a typo.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

rendering/RenderLayerCompositor.h:

2:51 PM Changeset in webkit [95862] by inferno@chromium.org

1 edit
3 adds in trunk/LayoutTests

Unreviewed. Chromium rebaselines for r95857.

platform/chromium-linux/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.png: Added.
platform/chromium-win/fast/ruby/ruby-text-before-after-content-expected.txt: Added.

2:48 PM Changeset in webkit [95861] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

occasional crash in Chromium in dispatching keyEvent
https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.

Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::keyEvent):

2:39 PM Changeset in webkit [95860] by fsamuel@chromium.org

7 edits in trunk/Source

Refactor paintOverhangAreas to allow non-Mac Chromium platforms to reuse code
https://bugs.webkit.org/show_bug.cgi?id=68648

Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests because there's no change in functionality (yet).

platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium):
(WebCore::ScrollbarThemeChromium::paintOverhangAreas):

platform/chromium/ScrollbarThemeChromium.h:
platform/chromium/ScrollbarThemeChromiumMac.h:
platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):

Source/WebKit/chromium:

features.gypi:

2:35 PM Changeset in webkit [95859] by ojan@chromium.org

8 edits in trunk

remove physical flex-flow values to match the updated spec
https://bugs.webkit.org/show_bug.cgi?id=68728

Reviewed by Tony Chang.

Source/WebCore:

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexFlow):

css/CSSValueKeywords.in:
rendering/style/RenderStyleConstants.h:

LayoutTests:

css3/flexbox/css-properties-expected.txt:
css3/flexbox/script-tests/css-properties.js:

2:31 PM Changeset in webkit [95858] by Adam Roben

1 copy in tags/Safari-535.3.1-Win

New tag

2:01 PM Changeset in webkit [95857] by inferno@chromium.org

4 edits
3 adds in trunk

Source/WebCore: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625

Reviewed by Dave Hyatt.

Test: fast/ruby/ruby-text-before-after-content.html

rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::updateBeforeAfterContent):

rendering/RenderRubyText.h:

LayoutTests: Style not updated for :before, :after content
in ruby text.
https://bugs.webkit.org/show_bug.cgi?id=68625

Reviewed by Dave Hyatt.

fast/ruby/ruby-text-before-after-content-expected.png: Added.
fast/ruby/ruby-text-before-after-content-expected.txt: Added.
fast/ruby/ruby-text-before-after-content.html: Added.

1:32 PM Changeset in webkit [95856] by ojan@chromium.org

5 edits in trunk/Source/WebCore

refactor RenderFlexibleBox to use flex-flow aware methods
https://bugs.webkit.org/show_bug.cgi?id=68665

Reviewed by Tony Chang.

This is just a refactor. Just move the all the code that needs to
be flow aware into helper functions. Actually making them flow-aware
can be done in a followup patch.

rendering/RenderBlock.cpp:
rendering/RenderBlock.h:

Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

rendering/RenderFlexibleBox.h:

1:25 PM Changeset in webkit [95855] by hyatt@apple.com

7 edits
6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68719

Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
columns, when regions have a non-uniform height, we may need to push through multiple regions
in order to find one that fits.

Added an optimization for quickly noticing if regions do have a uniform height so that we can
treat them like columns and pages if so.

Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
the new tests.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new tests in fast/regions.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::matchedEndLine):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

rendering/RenderFlowThread.h:

LayoutTests:

fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
fast/regions/webkit-flow-float-unable-to-push.html: Added.
platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.

1:21 PM Changeset in webkit [95854] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

PutScopedVar nodes should report that it has a var number
https://bugs.webkit.org/show_bug.cgi?id=68721

Reviewed by Anders Carlsson.

Another assertion fix.

dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):

1:11 PM Changeset in webkit [95853] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Move WebHitTestResult files to Shared/ in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=68718

Reviewed by Sam Weinig.

WebKit2.xcodeproj/project.pbxproj:

12:56 PM Changeset in webkit [95852] by jchaffraix@webkit.org

10 edits
47 adds in trunk

Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546

Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
Reviewed by David Hyatt.

Source/WebCore:

Move CollapsedBorderValues into RenderTable.h.
Calculate collapsed borders only once and re-use during paintObject().
Invalidate cache when cell, row, row group, col, col group or table border is changed.

Tests: fast/table/border-collapsing/cached-cell-append.html

fast/table/border-collapsing/cached-cell-remove.html
fast/table/border-collapsing/cached-change-cell-border-color.html
fast/table/border-collapsing/cached-change-cell-border-width.html
fast/table/border-collapsing/cached-change-col-border-color.html
fast/table/border-collapsing/cached-change-col-border-width.html
fast/table/border-collapsing/cached-change-colgroup-border-color.html
fast/table/border-collapsing/cached-change-colgroup-border-width.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-row-border-width.html
fast/table/border-collapsing/cached-change-table-border-color.html
fast/table/border-collapsing/cached-change-table-border-width.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-width.html

rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
(WebCore::RenderTable::layout): Invalidate cache if layout changed.
(WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
(WebCore::RenderTable::paintObject): Use cached collapsed borders.

rendering/RenderTable.h:

(WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
(WebCore::RenderTable::currentBorderValue): Rename to use word "value".

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.

Rename to use word "value".
(WebCore::addBorderStyle):
(WebCore::RenderTableCell::collectBorderValues):
(WebCore::compareBorderValuesForQSort):
(WebCore::RenderTableCell::sortBorderValues):
(WebCore::RenderTableCell::paintCollapsedBorder):

rendering/RenderTableCell.h:

If border changed, invalidate cache.

rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):

rendering/RenderTableCol.h:
rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):

LayoutTests:

Tests for invalidating collapsed borders cache.

fast/table/border-collapsing/cached-cell-append-expected.png: Added.
fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
fast/table/border-collapsing/cached-cell-append.html: Added.
fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
fast/table/border-collapsing/cached-cell-remove.html: Added.
fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-col-border-color.html: Added.
fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-col-border-width.html: Added.
fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-row-border-color.html: Added.
fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-row-border-width.html: Added.
fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-table-border-color.html: Added.
fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-table-border-width.html: Added.
fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.

12:48 PM Changeset in webkit [95851] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716

Reviewed by Darin Adler.

Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

12:46 PM Changeset in webkit [95850] by mihaip@chromium.org

5 edits in trunk

update layout_tests to account for new default of use_skia=1
https://bugs.webkit.org/show_bug.cgi?id=68698

Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
(Chromium-on-Mac now uses the Skia graphics library instead of
Core Graphics).

Also updates layout_test code to work with that change.

Patch by Elliot Poger <epoger@google.com> on 2011-09-23
Reviewed by Mihai Parparita.

Source/WebKit/chromium:

DEPS:

Tools:

Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:

12:40 PM Changeset in webkit [95849] by mhahnenberg@apple.com

81 edits in trunk

Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404

Reviewed by Darin Adler.

In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.

Source/autotools/symbols.filter:

Source/JavaScriptCore:

API/JSCallbackObject.h:

(JSC::JSCallbackObject::visitChildrenVirtual):
(JSC::JSCallbackObject::visitChildren):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::visitChildrenVirtual):
(JSC::DebuggerActivation::visitChildren):

debugger/DebuggerActivation.h:
heap/MarkStack.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):

runtime/Arguments.cpp:

(JSC::Arguments::visitChildrenVirtual):
(JSC::Arguments::visitChildren):

runtime/Arguments.h:
runtime/Executable.cpp:

(JSC::EvalExecutable::visitChildrenVirtual):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildrenVirtual):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildrenVirtual):
(JSC::FunctionExecutable::visitChildren):

runtime/Executable.h:
runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildrenVirtual):
(JSC::GetterSetter::visitChildren):

runtime/GetterSetter.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::visitChildrenVirtual):
(JSC::JSActivation::visitChildren):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::visitChildrenVirtual):
(JSC::JSArray::visitChildren):

runtime/JSArray.h:
runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::visitChildrenVirtual):
(JSC::JSBoundFunction::visitChildren):

runtime/JSBoundFunction.h:
runtime/JSCell.h:

(JSC::JSCell::visitChildrenVirtual):
(JSC::JSCell::visitChildren):

runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildrenVirtual):
(JSC::JSFunction::visitChildren):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildrenVirtual):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::visitChildrenVirtual):
(JSC::JSObject::visitChildren):

runtime/JSObject.h:

(JSC::JSObject::visitChildrenDirect):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildrenVirtual):
(JSC::JSPropertyNameIterator::visitChildren):

runtime/JSPropertyNameIterator.h:
runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::visitChildrenVirtual):
(JSC::JSStaticScopeObject::visitChildren):

runtime/JSStaticScopeObject.h:
runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildrenVirtual):
(JSC::JSWrapperObject::visitChildren):

runtime/JSWrapperObject.h:
runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildrenVirtual):
(JSC::NativeErrorConstructor::visitChildren):

runtime/NativeErrorConstructor.h:
runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildrenVirtual):
(JSC::RegExpObject::visitChildren):

runtime/RegExpObject.h:
runtime/ScopeChain.cpp:

(JSC::ScopeChainNode::visitChildrenVirtual):
(JSC::ScopeChainNode::visitChildren):

runtime/ScopeChain.h:
runtime/Structure.cpp:

(JSC::Structure::visitChildrenVirtual):
(JSC::Structure::visitChildren):

runtime/Structure.h:
runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildrenVirtual):
(JSC::StructureChain::visitChildren):

runtime/StructureChain.h:

Source/JavaScriptGlue:

UserObjectImp.cpp:

(UserObjectImp::visitChildrenVirtual):
(UserObjectImp::visitChildren):

UserObjectImp.h:

Source/WebCore:

No new tests.

WebCore.exp.in:
bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):

bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):

bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):

bindings/js/JSDOMGlobalObject.h:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSJavaScriptAudioNodeCustom.cpp:

(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):

bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):

bindings/js/JSNamedNodeMapCustom.cpp:

(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):

bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):

bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):

bindings/js/JSSVGElementInstanceCustom.cpp:

(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):

bindings/js/JSSharedWorkerCustom.cpp:

(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):

bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):

bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):

bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):

bindings/scripts/test/JS/JSTestObj.h:
bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):

bridge/qt/qt_runtime.h:
workers/WorkerContext.h:

12:31 PM Changeset in webkit [95848] by andersca@apple.com

3 edits
1 delete in trunk/Source/WebKit

Axe WebImageRendererFactory
https://bugs.webkit.org/show_bug.cgi?id=68715

Reviewed by Darin Adler.

../..:

Remove WebImageRendererFactory.m from the Xcode project.

WebKit.xcodeproj/project.pbxproj:

../../mac:

Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.

WebCoreSupport/WebImageRendererFactory.m: Removed.

12:24 PM Changeset in webkit [95847] by andersca@apple.com

15 edits in trunk/Source/WebKit

Add OVERRIDE to a bunch of virtual member functions on clients
https://bugs.webkit.org/show_bug.cgi?id=68712

Reviewed by Sam Weinig.

../..:

WebKit.xcodeproj/project.pbxproj:

../../mac:

Configurations/Base.xcconfig:
WebCoreSupport/WebChromeClient.h:
WebCoreSupport/WebContextMenuClient.h:
WebCoreSupport/WebDeviceOrientationClient.h:
WebCoreSupport/WebDragClient.h:
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameNetworkingContext.h:
WebCoreSupport/WebGeolocationClient.h:
WebCoreSupport/WebIconDatabaseClient.h:
WebCoreSupport/WebInspectorClient.h:
WebCoreSupport/WebPlatformStrategies.h:

12:19 PM Changeset in webkit [95846] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Node propagation doesn't handle PutScopedVar
https://bugs.webkit.org/show_bug.cgi?id=68713

Reviewed by Sam Weinig.

This was causing assertion failures.

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

12:19 PM Changeset in webkit [95845] by jochen@chromium.org

17 edits
4 copies in trunk/LayoutTests

Clarify wording in cross origin XSL tests and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=68683

The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.

Reviewed by Alexey Proskuryakov.

http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
http/tests/security/cross-origin-xsl-BLOCKED.html:
http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/gtk/Skipped:
platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
platform/wk2/Skipped:

12:17 PM Changeset in webkit [95844] by andersca@apple.com

2 edits in trunk/Source/JavaScriptCore

Make sure to define OVERRIDE and FINAL for older builds of clang.

wtf/Compiler.h:

12:07 PM Changeset in webkit [95843] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Mark two more tests as flaky.

platform/chromium/test_expectations.txt:

12:07 PM Changeset in webkit [95842] by loislo@chromium.org

2 edits
4 copies in branches/chromium/874

Merge 95410 - Web Inspector: didMarkDOMContentEvent() should send event of MarkDOMContent type.
https://bugs.webkit.org/show_bug.cgi?id=67528

Reviewed by Pavel Feldman.

Source/WebCore:

Tests: inspector/timeline/timeline-dom-content-loaded-event.html

inspector/timeline/timeline-load-event.html

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):

LayoutTests:

inspector/timeline/timeline-animation-frame.html:
inspector/timeline/timeline-dom-content-loaded-event-expected.txt: Added.
inspector/timeline/timeline-dom-content-loaded-event.html: Added.
inspector/timeline/timeline-load-event-expected.txt: Added.
inspector/timeline/timeline-load-event.html: Added.
inspector/timeline/timeline-test.js:

(initialize_Timeline.InspectorTest.waitForRecordType.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8021012

11:57 AM Changeset in webkit [95841] by loislo@chromium.org

2 edits in branches/chromium/874/Source/WebCore/inspector/front-end

Merge 95401 - Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineModel.prototype._saveToFile):

TBR=loislo@chromium.org
Review URL: http://codereview.chromium.org/8018012

11:52 AM Changeset in webkit [95840] by barraclough@apple.com

6 edits in trunk/Source/JavaScriptCore

Implement op_resolve_global in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68704

Reviewed by Oliver Hunt.

This is performance neutral, but increases coverage.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveInfoIndex):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:51 AM Changeset in webkit [95839] by mario@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Remove extra space at the beginning of the last line.
https://bugs.webkit.org/show_bug.cgi?id=68710

Reviewed by Gustavo Noronha Silva.

platform/network/soup/SocketStreamHandleSoup.cpp:

11:41 AM Changeset in webkit [95838] by mihaip@chromium.org

2 edits in trunk/LayoutTests

Mark a test as flaky.

platform/chromium/test_expectations.txt:

11:24 AM Changeset in webkit [95837] by mario@webkit.org

2 edits in trunk/Source/WebCore

2011-09-23 Mario Sanchez Prada <msanchez@igalia.com>

[GTK] Fix coding style issues in ResourceRequestSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68707

Reviewed by Xan Lopez.

This patch fixes some issues as reported by check-webkit-style.

platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateFromSoupMessage):

11:18 AM Changeset in webkit [95836] by Martin Robinson

1370 edits
476 copies
30 deletes in releases/WebKitGTK/webkit-1.6

Updating WebKitGTK+ branch to to the state of the 1.5.90 release

11:15 AM Changeset in webkit [95835] by mihaip@chromium.org

1 edit in branches/chromium/874/LayoutTests/http/tests/history/back-with-fragment-change.php

Merge 95322 - http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

http/tests/history/back-with-fragment-change.php:
platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:

TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/8018010

11:07 AM Changeset in webkit [95834] by andersca@apple.com

18 edits in trunk/Source/WebKit2

Add OVERRIDE to overrides of virtual member functions in client classes
https://bugs.webkit.org/show_bug.cgi?id=68702

Reviewed by Darin Adler.

Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
they have been removed from their respective base classes.

Configurations/Base.xcconfig:
WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebContextMenuClient.h:
WebProcess/WebCoreSupport/WebDatabaseManager.h:
WebProcess/WebCoreSupport/WebDragClient.h:
WebProcess/WebCoreSupport/WebEditorClient.cpp:
WebProcess/WebCoreSupport/WebEditorClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebCoreSupport/WebGeolocationClient.h:
WebProcess/WebCoreSupport/WebInspectorClient.h:
WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/WebPopupMenu.h:
WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
win/WebKit2Common.vsprops:

10:46 AM Changeset in webkit [95833] by mrowe@apple.com

2 edits in trunk/Source/JavaScriptCore

Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h.

wtf/Platform.h:

10:46 AM Changeset in webkit [95832] by mrowe@apple.com

2 edits in trunk/Tools

Fix the build.

TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside

the WTF namespace.

10:38 AM Changeset in webkit [95831] by Ademar Reis

2 edits in trunk/Source/WebCore

Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit

Include MSVC2010 in the list of compilers where incremental
build is disabled (INCREMENTAL:NO).

Change suggested by Simo Falt <simo.falt@nokia.com>, already present
in the Qt-4.8 repository where the problem was identified.

WebCore.pri:

10:11 AM Changeset in webkit [95830] by jamesr@google.com

2 edits in branches/chromium/874/Source/WebCore

Merge 95668 - [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
https://bugs.webkit.org/show_bug.cgi?id=68558

Reviewed by Stephen White.

The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>

platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

TBR=jamesr@google.com
Review URL: http://codereview.chromium.org/8020006

10:04 AM Changeset in webkit [95829] by inferno@chromium.org

11 edits in branches/chromium/874

Merge 94582 - Style not propagated to anonymous boxes and anonymous
inline-blocks.
BUG=95520
Review URL: http://codereview.chromium.org/8017007

10:03 AM Changeset in webkit [95828] by loislo@chromium.org

3 edits in trunk/LayoutTests

Unreviewed. Normalize test names.

inspector/performance/resources/first-open-elements.html:
inspector/performance/resources/first-open-resources.html:

10:01 AM Changeset in webkit [95827] by inferno@chromium.org

5 edits
4 copies in branches/chromium/874/LayoutTests/platform

Merge 95696 - Unreviewed. Chromium rebaselines for r95671.
BUG=95520
Review URL: http://codereview.chromium.org/8018006

9:59 AM Changeset in webkit [95826] by Darin Adler

2 edits in trunk/Source/WebCore

Try to fix warning seen in some 32-bit builds.

rendering/RenderBoxModelObject.cpp:

(WebCore::backgroundRectAdjustedForBleedAvoidance):
Use an explicit cast for the conversion from a double to a LayoutUnit.

9:59 AM Changeset in webkit [95825] by inferno@chromium.org

15 copies in branches/chromium/874/LayoutTests/platform

Merge 95477 - Unreviewed. Chromium Rebaselines for r95461.
BUG=95520
Review URL: http://codereview.chromium.org/8015011

9:57 AM Changeset in webkit [95824] by inferno@chromium.org

14 edits
3 copies in branches/chromium/874

Merge 95671 - Source/WebCore: Not use anonymousContainer on beforeChild calculation
and let later code handle it. Fix style update on block-level
anonymous objects.
BUG=95520
Review URL: http://codereview.chromium.org/8016006

9:49 AM Changeset in webkit [95823] by andersca@apple.com

2 edits in trunk/Source/JavaScriptCore

We should add support for OVERRIDE and FINAL annotations
https://bugs.webkit.org/show_bug.cgi?id=68654

Reviewed by David Hyatt.

Add OVERRIDE and FINAL macros for compilers that support them.

wtf/Compiler.h:

9:47 AM Changeset in webkit [95822] by yael.aharon@nokia.com

1 edit
1 move in trunk/LayoutTests

Fix typo in file name from http://trac.webkit.org/changeset/95813.

Unreviewed.

platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.

9:45 AM Changeset in webkit [95821] by inferno@chromium.org

3 edits in branches/chromium/874/Source/WebCore/dom

Merge 95600 - Style changes on forwarded shadow children should trigger shadow renderer reconstruction.
BUG=93788
Review URL: http://codereview.chromium.org/8002029

9:43 AM Changeset in webkit [95820] by inferno@chromium.org

1 edit in branches/chromium/874/Source/WebCore/dom/Document.cpp

Merge 95497
BUG=95639
Review URL: http://codereview.chromium.org/8016005

9:41 AM Changeset in webkit [95819] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95059 - Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
BUG=95639
Review URL: http://codereview.chromium.org/8018005

9:39 AM Changeset in webkit [95818] by yael.aharon@nokia.com

1 edit
2 adds in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/95799

Unreviewed.

platform/mac-wk2/media/video-playing-and-pause-expected.txt: Added.
platform/mac/media/video-playing-and-pause-expected.txt: Added.

9:38 AM Changeset in webkit [95817] by inferno@chromium.org

15 copies in branches/chromium/874/LayoutTests/fast/table

Merge 95461 - Child not placed correctly when beforeChild (table part)
BUG=95520
Review URL: http://codereview.chromium.org/8008019

9:31 AM Changeset in webkit [95816] by inferno@chromium.org

2 edits
2 copies in branches/chromium/874

Merge 95791 - use after free in WebCore::SVGTRefElement::updateReferencedText
BUG=95359
Review URL: http://codereview.chromium.org/8015009

9:26 AM Changeset in webkit [95815] by inferno@chromium.org

1 edit
3 copies in branches/chromium/874

Merge 95488 - Named property confusion with proto
BUG=95671
Review URL: http://codereview.chromium.org/8020005

9:20 AM Changeset in webkit [95814] by inferno@chromium.org

6 edits
2 copies in branches/chromium/874

Merge 95489 - [V8] document.all gets confused about its prototype chain
BUG=96885
Review URL: http://codereview.chromium.org/8015008

9:19 AM Changeset in webkit [95813] by yael.aharon@nokia.com

1 edit
1 add in trunk/LayoutTests

Rebaseline after http://trac.webkit.org/changeset/95799

Unreviewed.

platform/gtk/media/video-playing-and-pause-actual.txt: Added.

9:17 AM Changeset in webkit [95812] by inferno@chromium.org

2 edits
3 copies in branches/chromium/874

Merge 95580 - Invoke CachedResourceLoader::canRequest for all URLs in a redirect chain
BUG=97278
Review URL: http://codereview.chromium.org/8002026

9:14 AM Changeset in webkit [95811] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95667 - [Chromium] Protect the Frame in V8HTMLDocument::openCallback
BUG=97451
Review URL: http://codereview.chromium.org/8015007

9:13 AM Changeset in webkit [95810] by inferno@chromium.org

1 edit
2 copies in branches/chromium/874

Merge 95689 - [Chromium] Protect message ports from being deleted in V8MessageEvent::portsAccessorGetter
BUG=97520
Review URL: http://codereview.chromium.org/8016003

9:10 AM Changeset in webkit [95809] by xan@webkit.org

2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

[GTK] Skip crashing test fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=68700

Unreviewed.

platform/gtk/Skipped:

9:09 AM Changeset in webkit [95808] by inferno@chromium.org

4 edits
2 copies in branches/chromium/874

Merge 95728 - Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
BUG=97615
Review URL: http://codereview.chromium.org/8015006

8:57 AM Changeset in webkit [95807] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Clicking on error doesn't point on the correct line if user searched something
https://bugs.webkit.org/show_bug.cgi?id=68627

Reviewed by Yury Semikhatsky.

inspector/front-end/SearchController.js:

(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):

inspector/front-end/inspector.js:

(WebInspector._showAnchorLocationInPanel):

8:48 AM QtWebKitReleases edited by Ademar Reis

(diff)

8:22 AM Changeset in webkit [95806] by vsevik@chromium.org

4 edits
6 adds in trunk

Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one.
https://bugs.webkit.org/show_bug.cgi?id=68631

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/styles/styles-redirected-css.html

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

LayoutTests:

http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):

http/tests/inspector/styles/resources/styles-redirected-css.css: Added.

(div):

http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
http/tests/inspector/styles/styles-redirected-css.html: Added.

8:08 AM Changeset in webkit [95805] by vsevik@chromium.org

3 edits
2 adds in trunk

Web Inspector: XHRs requests with the same url as main resource should have correct category.
https://bugs.webkit.org/show_bug.cgi?id=68646

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

LayoutTests:

http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.

8:06 AM Changeset in webkit [95804] by jesus@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
https://bugs.webkit.org/show_bug.cgi?id=68696

Reviewed by Andreas Kling.

Instead of connecting signals and calling QtFileDownloader::onReadyRead()
on its constructor, QtFileDownloader will now handle this in start().

WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):

WebProcess/Downloads/qt/QtFileDownloader.cpp:

(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::start):

WebProcess/Downloads/qt/QtFileDownloader.h:

7:59 AM Changeset in webkit [95803] by pfeldman@chromium.org

2 edits
3 copies in branches/chromium/874

Merge 95083 - Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-pause-in-internal.html

bindings/v8/DebuggerScript.js:
bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::currentCallFrame):

LayoutTests:

inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
inspector/debugger/debugger-pause-in-internal.html: Added.
inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/8017006

7:58 AM Changeset in webkit [95802] by bulach@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update expectation for pservers-grad-14-b.svg on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=68697

Unreviewed rebaseline.

platform/chromium/test_expectations.txt:

7:35 AM Changeset in webkit [95801] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
https://bugs.webkit.org/show_bug.cgi?id=68657

Reviewed by Yury Semikhatsky.

English.lproj/localizedStrings.js:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightResource):

inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

inspector/front-end/inspector.js:

(WebInspector.openInNetworkPanelLabel):
(WebInspector.openRequestInNetworkPanel):

7:14 AM Changeset in webkit [95800] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Gtk] Title attribute is not respected on option elements.
https://bugs.webkit.org/show_bug.cgi?id=68615

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
Reviewed by Martin Robinson.

Set tooltip on PopupMenuGtk items created from GtkActions.

platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()

to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.

platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text

from client when creating a GtkAction.

7:03 AM Changeset in webkit [95799] by yael.aharon@nokia.com

4 edits
3 adds in trunk

[Qt][Gtk] Wrong state when pausing a video in the "playing" event handler
https://bugs.webkit.org/show_bug.cgi?id=68589

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-playing-and-pause.html

As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
in MediaPlayerGstreamerPrivate::paused().

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::paused):

LayoutTests:

media/video-playing-and-pause.html: Added.
media/video-paint-test.js:
platform/qt/media/video-playing-and-pause-expected.txt: Added.
platform/qt/media/video-playing-and-pause-expected.png: Added.

6:48 AM Changeset in webkit [95798] by bulach@chromium.org

1 edit
2 moves
4 adds
2 deletes in trunk/LayoutTests

[chromium, gtk, qt] Rebaseline following r95726
https://bugs.webkit.org/show_bug.cgi?id=68694

Unreviewed rebaseline.

css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt.
css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt.
platform/chromium/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
platform/chromium/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt: Removed.

6:17 AM Changeset in webkit [95797] by podivilov@chromium.org

5 edits in trunk

Web Inspector: skip overlapping scripts when displaying concatenated content.
https://bugs.webkit.org/show_bug.cgi?id=68144

Source/WebCore:

Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.

Reviewed by Pavel Feldman.

inspector/front-end/SourceFile.js:

(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):

LayoutTests:

Reviewed by Pavel Feldman.

inspector/debugger/content-providers-expected.txt:
inspector/debugger/content-providers.html:

6:04 AM Changeset in webkit [95796] by xan@webkit.org

2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

[GTK] Rebaseline following r95745, r95725

Unreviewed rebaseline.

platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:

5:43 AM Changeset in webkit [95795] by bulach@chromium.org

7 edits in trunk/LayoutTests

[chromium] Rebaseline following r95745, r95725
https://bugs.webkit.org/show_bug.cgi?id=68685

Unreviewed rebaseline.

platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
platform/chromium/test_expectations.txt:

5:06 AM Changeset in webkit [95794] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Yury Semikhatsky.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

4:43 AM Changeset in webkit [95793] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r95383.
http://trac.webkit.org/changeset/95383
https://bugs.webkit.org/show_bug.cgi?id=68690

It broke WebInspector.Timeline.LoadFromFile feature.
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-23

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._createFileSelector):

3:59 AM Changeset in webkit [95792] by loislo@chromium.org

1 edit
1 add in trunk/LayoutTests

Web Inspector: UI performance test for Scripts panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68541

The test's body has dummy scripts section copied from inspector-test.jss

Reviewed by Yury Semikhatsky.

inspector/performance/resources/first-open-scripts.html:

3:56 AM Changeset in webkit [95791] by commit-queue@webkit.org

4 edits
2 adds in trunk

use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555

Patch by Rob Buis <rbuis@rim.com> on 2011-09-23
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Event listeners can outlive the tref element that created them when
the tref is cloned and then garbage collected, causing a dangling pointer to the
tref. To fix this do not install event listener until the tref is inserted into the document.

Test: svg/custom/tref-clone-crash.html

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::svgAttributeChanged):
(WebCore::SVGTRefElement::insertedIntoDocument):

svg/SVGTRefElement.h:

LayoutTests:

Test that cloned tref does not cause a crash.

svg/custom/tref-clone-crash-expected.txt: Added.
svg/custom/tref-clone-crash.html: Added.

3:46 AM Changeset in webkit [95790] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
https://bugs.webkit.org/show_bug.cgi?id=68291

Reviewed by Tony Chang.

dom/Document.cpp:

(WebCore::Document::finishedParsing):

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):

page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

3:35 AM Changeset in webkit [95789] by xan@webkit.org

2 edits in trunk/LayoutTests

2011-09-23 Xan Lopez <xlopez@igalia.com>

Crash on editing/pasteboard/drag-drop-input-in-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68686

Unreviewed, skip crashing test.

platform/gtk/Skipped:

2:19 AM Changeset in webkit [95788] by kbalazs@webkit.org

3 edits in trunk/LayoutTests

plugins/mouse-click-iframe-to-plugin.html should not use flash plugin
https://bugs.webkit.org/show_bug.cgi?id=68601

Use the test plugin that we always have.

platform/qt-wk2/Skipped: Unskip the test.
plugins/mouse-click-iframe-to-plugin.html:

12:18 AM Changeset in webkit [95787] by barraclough@apple.com

6 edits
3 adds in trunk

Source/JavaScriptCore: GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Oliver Hunt.

Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

dfg/DFGNode.h:

(JSC::DFG::Node::hasPrediction):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):

LayoutTests: [Qt] Unreviewed gardening, update expected file after r95745.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2011-09-22

platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:

Sep 22, 2011:

11:59 PM Changeset in webkit [95786] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676

Reviewed by Oliver Hunt.

Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGGraph.h:

(JSC::DFG::Graph::predict):

dfg/DFGNode.h:

(JSC::DFG::Node::hasPrediction):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_scoped_var):

10:58 PM Changeset in webkit [95785] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update expected file after r95745.

platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:

10:53 PM Changeset in webkit [95784] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

Unreviewed fix after r95764, update expected fail to expected pass.

ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:

9:54 PM Changeset in webkit [95783] by tony@chromium.org

5 edits
3 adds in trunk

implement -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=67432

Reviewed by Ojan Vafai.

Source/WebCore:

flex-order can be an int (including negative), but we disallow the two
smallest values so we can put the numbers into a hash set.

Also, create two iterators: one that goes in render tree order (we use
this for the first pass and to collect the possible flex order values)
and one that goes in flex order.

Test: css3/flexbox/flex-order.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

rendering/RenderFlexibleBox.cpp:

(WebCore::FlexOrderHashTraits::emptyValue):
(WebCore::FlexOrderHashTraits::constructDeletedValue):
(WebCore::FlexOrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator

that goes in render tree order.

(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
(WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that

goes in flex-order order. Creating this involves sorting, so only create it once
and pass it around.

(WebCore::RenderFlexibleBox::FlexOrderIterator::first):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):

rendering/RenderFlexibleBox.h:

LayoutTests:

css3/flexbox/flex-order-expected.png: Added.
css3/flexbox/flex-order-expected.txt: Added.
css3/flexbox/flex-order.html: Added.

9:10 PM Changeset in webkit [95782] by Darin Adler

2 edits in trunk/Source/WebCore

Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68667

Reviewed by Simon Fraser.

platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
AffineTransform::yScale instead of the custom code here that seems to do
the same thing.

9:00 PM Changeset in webkit [95781] by dpranke@chromium.org

2 edits in trunk/Tools

enable NRWT for run-webkit-tests on Lion
https://bugs.webkit.org/show_bug.cgi?id=68673

Reviewed by Eric Seidel.

Scripts/run-webkit-tests:

(useNewRunWebKitTests):

8:35 PM Changeset in webkit [95780] by commit-queue@webkit.org

50 edits in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 6
https://bugs.webkit.org/show_bug.cgi?id=68671

Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.

platform/chromium-linux/tables/mozilla/marvin/: 9 changes
platform/chromium-linux/tables/mozilla_expected_failures/marvin/: 14 changes
platform/chromium-linux/transforms/svg-vs-css-expected.png:
platform/chromium-win/tables/mozilla/marvin/: 9 changes
platform/chromium-win/tables/mozilla_expected_failures/marvin/: 14 changes
platform/chromium-win/transforms/svg-vs-css-expected.png:
platform/chromium/test_expectations.txt:

8:27 PM Changeset in webkit [95779] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PPC build fix, part 3.

runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForConstructInternal):

8:21 PM Changeset in webkit [95778] by Darin Adler

2 edits in trunk/Source/WebCore

Remove unneeded type conversion from background bleed code
https://bugs.webkit.org/show_bug.cgi?id=68669

Reviewed by Geoffrey Garen.

rendering/RenderBoxModelObject.cpp:

(WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
and eliminate superflous conversion to float and use of FloatSize. Also added
a "why" comment.

8:00 PM Changeset in webkit [95777] by Darin Adler

6 edits in trunk/Source/WebCore

Refactor checks for antialiasing lines to share a single function
https://bugs.webkit.org/show_bug.cgi?id=68666

Reviewed by Dan Bernstein.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.

rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorder): Ditto.

7:41 PM Changeset in webkit [95776] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
https://bugs.webkit.org/show_bug.cgi?id=68297

Patch by Antoine Labour <piman@chromium.org> on 2011-09-22
Reviewed by James Robinson.

No functional change, no new test needed.

platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):

platform/graphics/chromium/LayerChromium.h:

7:40 PM Changeset in webkit [95775] by annacc@chromium.org

2 edits in trunk/LayoutTests

Adding testTracks() function to video-test.js
https://bugs.webkit.org/show_bug.cgi?id=68643

Reviewed by Eric Carlson.

media/video-test.js:

(testTracks):

7:28 PM Changeset in webkit [95774] by commit-queue@webkit.org

5 edits
6 adds in trunk

Make XSSAuditor extract meaningful snippet from script blocks for comparison
against the URL when checking for reflection. Avoids getting caugh up in
trailing comments.
https://bugs.webkit.org/show_bug.cgi?id=68094

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-22
Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html

http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::extractCodeFragment):

html/parser/XSSAuditor.h:

LayoutTests:

http/tests/security/xssAuditor/resources/echo-intertag.pl:
http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-trailing-comment.html: Added.
http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html: Added.
http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html: Added.

7:27 PM Changeset in webkit [95773] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] TouchWebView load test not running
https://bugs.webkit.org/show_bug.cgi?id=68620

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-22
Reviewed by Chang Shu.

Load test was not executed since it was missing in pro file. Added tst_load.qml to qmltests.pro

UIProcess/API/qt/tests/qmltests/qmltests.pro:

7:16 PM Changeset in webkit [95772] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

Another PPC build fix.

runtime/Executable.cpp:
runtime/Executable.h:

6:56 PM Changeset in webkit [95771] by commit-queue@webkit.org

55 edits
2 moves
1 add in trunk/LayoutTests

Rebaseline for bug 65583 (path based border radius drawing on skia) part 5
https://bugs.webkit.org/show_bug.cgi?id=68608

Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.

platform/chromium-linux/css2.1/: 14 changes
platform/chromium-linux/editing/execCommand/5138441-expected.png:
platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png:
platform/chromium-linux/fast/: 9 changes
platform/chromium-win/css2.1/: 14 changes
platform/chromium-win/editing/execCommand/5138441-expected.png:
platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
platform/chromium-win/fast/: 10 changes
platform/chromium/test_expectations.txt:
platform/win-xp/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt.
platform/win/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.

6:42 PM Changeset in webkit [95770] by commit-queue@webkit.org

3 edits
1 add in trunk/Tools

Add unit test for existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67080

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-22
Reviewed by Darin Adler.

TestWebKitAPI/TestWebKitAPI.gypi:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.

(operator<<):
(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):

6:33 PM WebKit Team edited by dino@apple.com

Moving me around (diff)

6:33 PM AddingFeatures created by dino@apple.com

Figured it was worth documenting how to add a feature

6:29 PM Changeset in webkit [95769] by dslomov@google.com

2 edits in trunk/LayoutTests

Updated expectations and filed WK68674.

platform/chromium/test_expectations.txt:

6:21 PM WikiStart edited by dino@apple.com

Adding link to new ENABLE page (diff)

6:12 PM Changeset in webkit [95768] by Nate Chapin

16 edits in trunk/Source/WebCore

Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient.
Instead, add a load-specific policy for showing the user authentication
challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, refactor only.

loader/DocumentThreadableLoader.cpp:
loader/DocumentThreadableLoader.h:
loader/MainResourceLoader.cpp:
loader/NetscapePlugInStreamLoader.cpp:
loader/ResourceLoadScheduler.h:
loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):

For resource types that always send a challenge to the embedder,
this patch doesn't change anything. For those that don't, we will
always try to continue without credentials when they are forbidden
and the platform supports it.
When continuing without credentials was initially implemented in
DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
then canceled the SubresourceLoader. This was necessary because of the
quirks of ThreadableLoader cancellation (we sever the client/loader connections
before the load actually cancels), but a simple didFail() should suffice at
the ResourceLoader layer.

loader/ResourceLoaderOptions.h:
loader/SubresourceLoader.cpp:
loader/SubresourceLoader.h:
loader/SubresourceLoaderClient.h:
loader/cache/CachedResource.cpp:
loader/cache/CachedResourceLoader.cpp:
loader/cache/CachedResourceLoader.h:
loader/icon/IconLoader.cpp: The ResourceLoader implementation of

didReceiveAuthenticationChallege means that IconLoader will now
try to continue with credentials on platforms that support it,
rather than just canceling outright. We still will never prompt
for authentication for icons.

loader/icon/IconLoader.h:

5:43 PM Changeset in webkit [95767] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Use ewk_view to navigate in history instead of ewk_history.
https://bugs.webkit.org/show_bug.cgi?id=68455

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.

BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.

This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.

DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(BackForwardItem::invoke):

5:38 PM Changeset in webkit [95766] by dino@apple.com

13 edits in trunk

Add ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=68652

Reviewed by Simon Fraser.

Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
Source/WebCore/Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
Source/WebKit2/Configurations/FeatureDefines.xcconfig:
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
Tools/Scripts/build-webkit:

5:02 PM Changeset in webkit [95765] by andersca@apple.com

2 edits in trunk/Source/WebCore

Make sure to update scrollbars in ScrollView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=68663

Reviewed by Sam Weinig.

Call updateScrollbars after setting the frame rect. This was previously done by the
call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
completely in http://trac.webkit.org/changeset/95725.

platform/ScrollView.cpp:

(WebCore::ScrollView::setFrameRect):

4:57 PM Changeset in webkit [95764] by barraclough@apple.com

5 edits in trunk

Function.prototype.bind.length shoudl be 1.

Rubber stamped by Olier Hunt.

Source/JavaScriptCore:

runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):

LayoutTests:

fast/js/function-bind-expected.txt:
fast/js/script-tests/function-bind.js:

4:24 PM Changeset in webkit [95763] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

PPC build fix.

bytecode/CodeBlock.h:

4:22 PM Changeset in webkit [95762] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Windows build fix pt. 2

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

4:05 PM Changeset in webkit [95761] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Windows build fix pt. 1

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

3:58 PM Changeset in webkit [95760] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][Mac]Unreviewed gardening.

New Qt specific results were added by r95723, but they fail on Qt-Mac platform

platform/qt-mac/Skipped: Skip css3/selectors3 tests.

3:49 PM Changeset in webkit [95759] by Simon Fraser

11 edits
1 copy
1 add in trunk/Source/WebKit2

Add APIObjects for Size, Point, Rect
https://bugs.webkit.org/show_bug.cgi?id=68644

Reviewed by Sam Weinig.

Make APIObjects for size, point and rect so that they can be
used in WKArrayRefs.

Make some inline helper methods to create WKSize, WKPoint and WKRect
types.

GNUmakefile.am:
Shared/API/c/WKBase.h:
Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.

(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
(WKSizeGetValue):
(WKPointGetValue):
(WKRectGetValue):

Shared/API/c/WKGeometry.h:

(WKPoint::WKPointMake):
(WKPoint::WKSizeMake):
(WKPoint::WKRectMake):

Shared/API/c/WKSharedAPICast.h:
Shared/APIObject.h:
Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

Shared/WebGeometry.h: Added.

(WebKit::WebSize::create):
(WebKit::WebSize::size):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::type):
(WebKit::WebPoint::create):
(WebKit::WebPoint::point):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::type):
(WebKit::WebRect::create):
(WebKit::WebRect::rect):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::type):

WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebKit2API.pri:
win/WebKit2.vcproj:

3:42 PM Changeset in webkit [95758] by fpizlo@apple.com

13 edits in trunk/Source/JavaScriptCore

DFG JIT does not support to_primitive or strcat
https://bugs.webkit.org/show_bug.cgi?id=68582

Reviewed by Darin Adler.

This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.

When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::callOperation):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):

dfg/DFGNode.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSC::JSGlobalData::scratchBufferForSize):

3:35 PM Changeset in webkit [95757] by jonlee@apple.com

4 edits in trunk/Source/WebCore

Progress control gets cropped on the bottom
https://bugs.webkit.org/show_bug.cgi?id=68302
<rdar://problem/10069915>

Reviewed by Kent Tamura.

As it turns out the smaller control type does not get rendered either, so this patch
fixes both.

manual-tests/dom/progressbar.html: Altered to show both sizes of controls
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect

(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
control height and glow margin.

3:28 PM Changeset in webkit [95756] by hyatt@apple.com

5 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=68658

Make matchedEndLine smart enough to not match lines that have moved to new
regions with different available content logical widths. When this happens, we go ahead and treat
the line as failing to match.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new tests in fast/regions.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):

rendering/RenderBlock.h:

Enhanced to take an optional delta, so that you can check a new position without having to move
the line box.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
New function that refactors checking for line width changes from region movement as well as the
float checks. Since the float checks were duplicated twice, this is a nice refactoring.

(WebCore::RenderBlock::matchedEndLine):
Changed to call the new helper function that will check both floats and pagination.

LayoutTests:

fast/regions/webkit-flow-inlines-dynamic.html: Added.
platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.

3:13 PM Changeset in webkit [95755] by andersca@apple.com

2 edits in trunk/Tools

EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
https://bugs.webkit.org/show_bug.cgi?id=68660

Reviewed by Adam Barth.

WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseUp):

3:02 PM Changeset in webkit [95754] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597

Reviewed by Darin Adler.

This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).

This is a 4% win on Kraken and a 1% loss on V8.

bytecode/CodeBlock.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGNode.h:

(JSC::DFG::Node::hasArithNodeFlags):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_div):

2:55 PM Changeset in webkit [95753] by oliver@apple.com

6 edits in trunk/Source/JavaScriptCore

Implement put_scoped_var in the DFG jit
https://bugs.webkit.org/show_bug.cgi?id=68653

Reviewed by Gavin Barraclough.

Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:43 PM Changeset in webkit [95752] by abarth@webkit.org

2 edits in trunk/LayoutTests

Skip test that need new baselines.

platform/mac/Skipped:

2:22 PM Changeset in webkit [95751] by barraclough@apple.com

58 edits
5 adds in trunk

Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.

JavaScriptCore.JSVALUE32_64only.exp:
JavaScriptCore.JSVALUE64only.exp:
JavaScriptCore.exp:
JavaScriptCore.xcodeproj/project.pbxproj:
jit/JITStubs.cpp:

(JSC::JITThunks::hostFunctionStub):

jit/JITStubs.h:
jsc.cpp:

(GlobalObject::addFunction):

runtime/CommonIdentifiers.h:
runtime/ConstructData.h:
runtime/Executable.h:

(JSC::NativeExecutable::NativeExecutable):

runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):

runtime/FunctionPrototype.h:
runtime/JSBoundFunction.cpp: Added.

(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):

runtime/JSBoundFunction.h: Added.

(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):

runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):

runtime/JSFunction.h:
runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

runtime/JSGlobalData.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::boundFunctionStructure):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

Source/WebCore:

Test: fast/js/function-bind.html

bindings/js/JSDOMBinding.cpp:

(WebCore::objectToStringFunctionGetter):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::nonCachingStaticFunctionGetter):

bindings/js/JSHistoryCustom.cpp:

(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):

bindings/js/JSLocationCustom.cpp:

(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):

Function::create no longer requires functionStructure() to be passed.

LayoutTests:

We now pass Function.bind tests.

fast/js/Object-getOwnPropertyNames-expected.txt:
fast/js/basic-strict-mode-expected.txt:
fast/js/function-bind-expected.txt: Added.
fast/js/function-bind.html: Added.
fast/js/mozilla/strict/15.3.4.5-expected.txt:
fast/js/script-tests/function-bind.js: Added.
ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:

1:50 PM Changeset in webkit [95750] by hyatt@apple.com

11 edits
1 add
1 delete in trunk

https://bugs.webkit.org/show_bug.cgi?id=68650

Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
region with a different available content logical width. When this happens, we go ahead and treat
the line as dirty.

Reviewed by Sam Weinig.

Source/WebCore:

Covered by existing fast/regions tests.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
Disable region fitting if we detect that the regions all have uniform widths. In this case we know
the content width can't vary, so there's no reason to waste time worrying about it.

(WebCore::RenderBlock::computeLogicalLocationForFloat):
Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
region fitting into the fixed offsets now rather than the line functions.

(WebCore::RenderBlock::positionNewFloats):
Changed because more code moved from here into computeLogicalLocationForFloat.

(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
No changes. Just moved the function above the left offset function.

(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Added. These new functions give the fixed left and right offsets for lines in a particular region.
When no regions are present or when all the regions have a uniform width, they are identical
to the versions of the functions that take no arguments.

(WebCore::RenderBlock::logicalRightOffsetForLine):
Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
New function that takes a root line box and compares its cached old content width with the width
available at the line's new location.

rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
Modified to call the logicalXXXOffsetForContent functions that take a block direction position.

(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
Added the new functions that take a position so that they can fit to the correct region.

(WebCore::RenderBlock::availableLogicalWidthForContent):
New helper function that calls right - left (similar to the corresponding line function that includes
floats).

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
Patched to check if a line has moved to a place with a different available content width. If so, the line
is dirtied so that line layout can re-run.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Sets the paginated line width from the current block logical height.

rendering/RootInlineBox.h:

(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
Fixed paginationStrut to be LayoutUnit instead of int.

(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
Added paginatedLineWidth getter/setter for caching the content width for a given root line.

LayoutTests:

platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:

1:37 PM Changeset in webkit [95749] by andersca@apple.com

5 edits in trunk/Source/WebCore

Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570

Reviewed by Darin Adler.

These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.

This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

platform/Widget.h:
platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):

rendering/RenderWidget.cpp:

Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.

12:59 PM Changeset in webkit [95748] by rniwa@webkit.org

48 edits in branches/chromium/874

Revert 93001 - Apple-style-span class seems unnecessary
https://bugs.webkit.org/show_bug.cgi?id=12248

Reviewed by Justin Garcia.

Source/WebCore:

Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component
no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on
style spans. WebKit continues to recognize Apple style spans to remove them.

Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.

editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.
(WebCore::createFontElement): No longer adds class="Apple-style-span".
(WebCore::createStyleSpanElement): Ditto.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan
instead of isUnstyledStyleSpan since there won't be any Apple style spans.
(WebCore::dummySpanAncestorForNode):
(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):

editing/ApplyStyleCommand.h:
editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead
of isStyleSpan.
(WebCore::handleStyleSpansBeforeInsertion): Ditto.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".

LayoutTests:

Rebaselined the tests because spans in these tests lost no longer have class="Apple-style-span".

editing/deleting/delete-br-012-expected.txt:
editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt:
editing/deleting/delete-select-all-001-expected.txt:
editing/execCommand/16049-expected.txt:
editing/execCommand/5685604-1.html:
editing/execCommand/delete-image-in-anchor-expected.txt:
editing/execCommand/hilitecolor-expected.txt:
editing/execCommand/modifyForeColorByCharacter-expected.txt:
editing/execCommand/query-font-size-expected.txt:
editing/execCommand/remove-format-multiple-elements-expected.txt:
editing/execCommand/script-tests/remove-format-multiple-elements.js:
editing/execCommand/script-tests/toggle-text-decorations.js:
editing/execCommand/script-tests/toggle-unlink.js:
editing/execCommand/toggle-style-2-expected.txt:
editing/execCommand/toggle-text-decorations-expected.txt:
editing/execCommand/toggle-unlink-expected.txt:
editing/inserting/5994480-2-expected.txt:
editing/pasteboard/5065605-expected.txt:
editing/pasteboard/copy-null-characters-expected.txt:
editing/pasteboard/copy-text-with-backgroundcolor-expected.txt:
editing/pasteboard/data-transfer-items-expected.txt:
editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt:
editing/pasteboard/do-not-copy-unnecessary-styles-expected.txt:
editing/pasteboard/onpaste-text-html-expected.txt:
editing/pasteboard/paste-text-with-style-2-expected.txt:
editing/style/apply-font-size-to-multiple-nodes-expected.txt:
editing/style/block-style-004-expected.txt:
editing/style/block-style-005-expected.txt:
editing/style/block-style-006-expected.txt:
editing/style/fontsize-1-expected.txt:
editing/style/fore-color-by-name-expected.txt:
editing/style/highlight-insert-paragraph-expected.txt:
editing/style/inline-style-container-expected.txt:
editing/style/inline-style-extend-run-expected.txt:
editing/style/invalid-font-size-expected.txt:
editing/style/push-down-font-styles-expected.txt:
editing/style/script-tests/inline-style-container.js:
editing/style/script-tests/inline-style-extend-run.js:
editing/style/script-tests/push-down-font-styles.js:
editing/style/style-text-node-without-editable-parent-expected.txt:
fast/events/ondrop-text-html-expected.txt:
platform/chromium-win/editing/inserting/5994480-2-expected.txt:
platform/gtk/editing/inserting/5994480-2-expected.txt:

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/7973008

12:41 PM Changeset in webkit [95747] by ap@apple.com

8 edits in trunk/Source/WebKit2

[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573

Reviewed by Anders Carlsson.

Re-landing with a slightly less aggressive check.

12:38 PM Changeset in webkit [95746] by robert@webkit.org

1 edit
3 adds in trunk/LayoutTests

Platform-specific results for test introduced by r95726

platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.

12:25 PM Changeset in webkit [95745] by rniwa@webkit.org

10 edits
17 deletes in trunk

Unreviewed, rolling out r95335 and r95645.
http://trac.webkit.org/changeset/95335
http://trac.webkit.org/changeset/95645
https://bugs.webkit.org/show_bug.cgi?id=68649

Wrong fix (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22

Source/WebCore:

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):

editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleAddedByNode):

editing/EditingStyle.h:
editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):

editing/markup.h:

LayoutTests:

editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
editing/deleting/merge-paragraph-from-address.html: Removed.
editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
editing/deleting/merge-paragraph-from-h6.html: Removed.
editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
editing/deleting/merge-paragraph-from-listing.html: Removed.
editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
editing/deleting/merge-paragraph-into-h1.html: Removed.
editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
editing/deleting/merge-paragraph-into-pre.html: Removed.
platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:

12:14 PM Changeset in webkit [95744] by robert@webkit.org

7 edits in trunk/LayoutTests

Unreviewed, update expected results after r95726

platform/chromium-win/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
platform/chromium-win/css2.1/20110323/abspos-replaced-width-margin-000-expected.png:
platform/gtk/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
platform/gtk/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
platform/qt/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
platform/qt/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:

12:12 PM QtWebKitSecurity edited by Ademar Reis

(diff)

12:11 PM QtWebKitSecurity edited by Ademar Reis

(diff)

12:11 PM QtWebKitSecurity edited by Ademar Reis

(diff)

11:55 AM Changeset in webkit [95743] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMouseDownEventToWidget):

platform/Widget.h:
platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):

rendering/RenderWidget.cpp:

11:51 AM Changeset in webkit [95742] by oliver@apple.com

6 edits in trunk/Source/JavaScriptCore

Implement get_scoped_var in the DFG
https://bugs.webkit.org/show_bug.cgi?id=68640

Reviewed by Gavin Barraclough.

Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):

dfg/DFGPropagator.cpp:

(JSC::DFG::Propagator::propagateNodePredictions):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:31 AM Changeset in webkit [95741] by hyatt@apple.com

1 edit
24 adds
11 deletes in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=68645

Fix the layout test fast/regions directory. Remove platform-specific results that were
incorrectly checked in to cross-platform locations and add missing pixel test results.

Reviewed by Beth Dakin.

fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
fast/regions/flows-dependency-same-flow-expected.txt: Removed.
fast/regions/render-region-renderer-expected.txt: Removed.
fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
fast/regions/webkit-flow-renderer-expected.txt: Removed.
fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
platform/mac/fast/regions/no-split-line-box-expected.png: Added.
platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.

11:12 AM Changeset in webkit [95740] by hyatt@apple.com

3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=68638

Make RenderFlowThread cache whether or not it has regions of varying widths. This will
be relevant for performance as we begin adding code to do custom block painting and
layout based off regions not having the same width.

Reviewed by Dan Bernstein and Adam Roben.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

rendering/RenderFlowThread.h:

11:03 AM Changeset in webkit [95739] by nduca@chromium.org

2 edits in branches/chromium/874/Source/WebCore

Merge 94587 - [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path
https://bugs.webkit.org/show_bug.cgi?id=67621

CCSingleThreadProxy should not perform layout when called
via the compositeImmediately path. Doing so makes it look
like frame rate is unbounded.

Reviewed by James Robinson.

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

platform/graphics/chromium/cc/CCSingleThreadProxy.h:

TBR=nduca@chromium.org
Review URL: http://codereview.chromium.org/7995010

11:02 AM QtWebKitReleases edited by Ademar Reis

(diff)

11:02 AM QtWebKitRelease22 edited by Ademar Reis

(diff)

11:01 AM QtWebKitRelease22 edited by Ademar Reis

(diff)

11:01 AM Changeset in webkit [95738] by andersca@apple.com

3 edits in trunk/Source/WebCore

FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=68639

Reviewed by David Hyatt.

FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
member functions that take IntRects, and Widget coordinates are currently defined in terms of
IntRects (and probably always should since we want them to be pixel-aligned).

page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):

page/FrameView.h:

10:56 AM QtWebKitPackaging edited by Ademar Reis

(diff)

10:54 AM QtWebKitReleases edited by Ademar Reis

(diff)

10:54 AM QtWebKitRelease21 edited by Ademar Reis

(diff)

10:53 AM QtWebKitRelease21 edited by Ademar Reis

(diff)

10:52 AM Changeset in webkit [95737] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix (fixes warning about too many parens).

rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

10:51 AM Changeset in webkit [95736] by andersca@apple.com

2 edits in trunk/Source/WebCore

Widget::frameRect shouldn't be virtual
https://bugs.webkit.org/show_bug.cgi?id=68637

Reviewed by Sam Weinig.

Nobody overrides Widget::frameRect and nobody should.

platform/Widget.h:

10:48 AM Changeset in webkit [95735] by Adam Roben

1 edit
1 delete in trunk/Tools

Remove FindSafari

It isn't used or built anymore.

Fixes <http://webkit.org/b/68628>

Reviewed by Darin Adler.

FindSafari: Removed this directory and its contents.

10:48 AM Changeset in webkit [95734] by Adam Roben

7 edits in trunk

Remove FindSafari from all our .sln files

It isn't used anymore, so there's no point in building it.

Part of <http://webkit.org/b/68628> Remove FindSafari

Reviewed by Steve Falkenburg.

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore.sln:

Source/WebKit/win:

WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.

Tools:

DumpRenderTree/DumpRenderTree.sln:
WebKitTestRunner/WebKitTestRunner.sln:

10:47 AM Changeset in webkit [95733] by Adam Roben

3 edits
1 delete in trunk/Tools

Remove all uses of FindSafari

It isn't really needed anymore.

Fixes <http://webkit.org/b/68626>.

Reviewed by Darin Adler.

Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.

Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of

WebKit, but now we use WebKit.exe for that.

Scripts/webkitdirs.pm:

(installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
do the same thing.

(readRegistryString):
(writeRegistryString):
Moved here from old-run-webkit-tests.

10:47 AM Changeset in webkit [95732] by Adam Roben

2 edits in trunk/Tools

Use the "direct object" form of system() to run WebKit.exe

This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
path to WebKit.exe.

Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
%WEBKITOUTPUTDIR%

Reviewed by Steve Falkenburg.

Scripts/webkitdirs.pm:

(runSafari):

10:46 AM Changeset in webkit [95731] by Adam Roben

2 edits in trunk/Tools

Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath

Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
spaces in the path to the WebKit source tree

Reviewed by John Sullivan.

Scripts/webkitdirs.pm:

(setupCygwinEnv):

10:46 AM Changeset in webkit [95730] by Adam Roben

2 edits in trunk/Source/WebKit/win

Add testRegExp.vcproj to WebKit.sln

Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj

Reviewed by Brian Weinstein.

WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it

does when built as part of JavaScriptCore.sln.

10:40 AM Changeset in webkit [95729] by vestbo@webkit.org

23 edits in trunk

[Qt] Use same DPI for application font as rest of app in DRT and WTR

QApplication will initialize the default application font based
on the application DPI at construction time, but we then override
the application DPI using QX11Info (hard-coding it to 96 for
consistency). This hard-coding is not reflected in the application
font, so we explicitly have update the font ourselves.

The 6 test results that are updated were originally produced with
a DPI of 75, as this is the default fallback DPI when a QFont is
constructed before QApplication. This was wrong, and the results
are updated to match a DPI of 96.

Reviewed by Csaba Osztrogonác.

10:36 AM Changeset in webkit [95728] by commit-queue@webkit.org

6 edits
2 adds in trunk

Ref protect shaders in V8WebGLRenderingContext::getAttachedShadersCallback
https://bugs.webkit.org/show_bug.cgi?id=68630

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-09-22
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/canvas/webgl/shader-deleted-by-accessor.html

bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getAttachedShaders):

html/canvas/WebGLRenderingContext.h:

LayoutTests:

fast/canvas/webgl/shader-deleted-by-accessor-expected.txt: Added.
fast/canvas/webgl/shader-deleted-by-accessor.html: Added.

10:30 AM Changeset in webkit [95727] by robert@webkit.org

1 edit
2 adds in trunk/LayoutTests

Unreviewed, platform-specific results for r95721.

platform/mac/fast/css/outline-narrowLine-expected.txt: Added.
platform/gtk/fast/css/outline-narrowLine-expected.txt: Added.

10:16 AM Changeset in webkit [95726] by robert@webkit.org

9 edits
11 moves
3 adds
11 deletes in trunk

CSS 2.1 failure: abspos-non-replaced-width-margin-000, abspos-replaced-width-margin-000
https://bugs.webkit.org/show_bug.cgi?id=47148

Reviewed by David Hyatt.

Source/WebCore:

rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::startOffsetForLine): Return offset from right, rather than offset from left + logicalwidth

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::startAlignedOffsetForLine):

Return the correct alignment for RTL blocks too. Looks like neither FF or Opera do this correctly.
Covered by new test left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html

rendering/RenderBox.cpp:

(WebCore::computeInlineStaticDistance):

The CSS 2.1 tests now require UAs to use the parent block's direction (rather than the containing block's direction) when computing static distance. The container block's direction is still used in the other width and offset related calculations.
In the context of this function, the logicalRight value is just an element that will be used later to calculate the correct logicalLeft position for the RTL block. So whereas an LTR block can substract containerBlock->borderLogicalLeft() in this function directly, an RTL block has to add it here so that will be later subtracted from availableSpace to get logicalLeft in computePositionedLogicalWidthUsing().

(WebCore::RenderBox::computePositionedLogicalWidth):

Update comments and use the container block's direction except when calculating the static distance.
Remove the notion of a quirks mode in this function and for calculating the position of replaced and non-replaced blocks generally. This is in line with both FF4 and Opera - neither of which have a quirks mode for them.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):

Update comments and use the container block's direction except when calculating the static distance.

(WebCore::RenderBox::computePositionedLogicalHeight):

Update comments.

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):

Update comments and use the container block's direction except when calculating the static distance.
If the containing block is RTL, always assume that values are over-constrained.

(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

Update comments.

LayoutTests:

platform/chromium-linux/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png:
platform/chromium-linux/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: New results for CSS 2.1 reference tests. These match exactly the reference test results.

fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks.html: Added.
platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added. New test for left,right and center alignment of inline LTR and RTL blocks. FF and Opera don't pass this test.

fast/block/positioning/absolute-position-direction-strict.html: Removed.
fast/block/positioning/absolute-position-direction.html: Renamed from LayoutTests/fast/block/positioning/absolute-position-direction-quirk.html.
platform/chromium-linux/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/block/positioning/absolute-position-direction-quirk-expected.png.
platform/chromium-linux/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.png.
platform/chromium-win/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
platform/chromium-win/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
platform/gtk/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.png.
platform/gtk/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
platform/gtk/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
platform/mac-leopard/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac-leopard/fast/block/positioning/absolute-position-direction-quirk-expected.png.
platform/mac-leopard/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
platform/mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.txt:
platform/mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.txt:
platform/mac/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.png.
platform/mac/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/mac/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
platform/mac/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed.
platform/qt/fast/block/positioning/absolute-position-direction-expected.png: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.png.
platform/qt/fast/block/positioning/absolute-position-direction-expected.txt: Renamed from LayoutTests/platform/qt/fast/block/positioning/absolute-position-direction-quirk-expected.txt.
platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.png: Removed.
platform/qt/fast/block/positioning/absolute-position-direction-strict-expected.txt: Removed. These tests are superseded by abspos-non-replaced-width-margin-000.htm. Using the parent() block's direction to compute static distance is now a strict requirement for CSS 2.1, rather than an IE quirk.

10:09 AM Changeset in webkit [95725] by andersca@apple.com

16 edits in trunk/Source

Get rid of Widget::setBoundsSize
https://bugs.webkit.org/show_bug.cgi?id=68491

Reviewed by Sam Weinig.

This basically reverts http://trac.webkit.org/changeset/79167 and http://trac.webkit.org/changeset/75897
which were added to make zoom gestures work with WebKit1, but since we don't support zoom gestures in WebKit1
anymore, it's better for code cleanliness to get rid of Widget::setBoundsSize and the associated code. While this
will unfortunately break transformed iframes in WebKit1, but Simon says that it's an acceptable tradeoff.

Source/WebCore:

WebCore.exp.in:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::open):

page/FrameView.cpp:

(WebCore::FrameView::create):

platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

platform/ScrollView.h:
platform/Widget.cpp:
platform/Widget.h:

(WebCore::Widget::resize):

platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::refresh):

platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::visibleContentRect):

platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):

rendering/RenderWidget.h:

Source/WebKit/mac:

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView updateAndSetWindow]):

WebView/WebFrameView.mm:

9:33 AM Changeset in webkit [95724] by hyatt@apple.com

5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=68590

Floats pushed to next page, column or region don't reposition properly if the amount of
available logical width at the new position changes. Refactor the code so that we can
run the float placement algorithm again when this happens.

Source/WebCore:

Covered by an existing regions test that exposes the issue.

Reviewed by Adam Roben.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::positionNewFloats):

rendering/RenderBlock.h:

LayoutTests:

Reviewed by Adam Roben.

fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:

9:31 AM Changeset in webkit [95723] by Csaba Osztrogonác

2 edits
1532 adds in trunk/LayoutTests

[Qt] Unreviewed. Add Qt specific expected results for css3/selectors3 tests.
All of them pass, they are compared to mac png results manually.

platform/qt/Skipped:
platform/qt/css3/selectors3/ [...]: Added.

9:18 AM Changeset in webkit [95722] by leandrogracia@chromium.org

5 edits
2 adds in trunk

Source/WebCore: Fire TextInput events on speech input, but not set/add any inputMethod attribute.
https://bugs.webkit.org/show_bug.cgi?id=60451

Reviewed by Ryosuke Niwa.

Introduce code to dispatch TextInput events when text is introduced via
the speech input feature. Handle also the cases where speech input is
started programmatically from the LayoutTestController.

Test: fast/speech/input-ontextinput-event.html

dom/TextEventInputType.h:
html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

LayoutTests: Testing text events triggered by speech input.
https://bugs.webkit.org/show_bug.cgi?id=60451

Reviewed by Ryosuke Niwa.

fast/speech/input-ontextinput-event-expected.txt: Added.
fast/speech/input-ontextinput-event.html: Added.
fast/speech/input-text-speechstart.html:

9:14 AM Changeset in webkit [95721] by robert@webkit.org

3 edits
5 adds in trunk

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2011-09-20
Reviewed by Simon Fraser.

CSS outline property on a narrow element has rabbit ear artifacts
https://bugs.webkit.org/show_bug.cgi?id=36793

Patch by Jason Liu <jason.liu@torchmobile.com.cn>
Patch updated by Robert Hogan <robert@webkit.org>

Source/WebCore:

Test: fast/css/outline-narrowLine.html

rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

LayoutTests:

fast/css/outline-narrowLine.html: Added.
platform/qt/fast/css/outline-narrowLine-expected.txt: Added.
platform/qt/fast/css/outline-narrowLine-expected.png: Added.
platform/chromium-linux/fast/css/outline-narrowLine-expected.txt: Added.
platform/chromium-linux/fast/css/outline-narrowLine-expected.png: Added.

9:08 AM Changeset in webkit [95720] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK]Popup drop-down menu contains extra empty spaces at beginning and
occupies whole screen when items in popup reaches the height of display device.
https://bugs.webkit.org/show_bug.cgi?id=68533

When implementing the GTK+ menu position function, set pushIn to false, which tell
GTK+ not create a menu that is as big as the entire screen.

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-22
Reviewed by Martin Robinson.

platform/gtk/GtkPopupMenu.cpp:

(WebCore::GtkPopupMenu::menuPositionFunction): Set pushIn to false in the menu position function.

8:42 AM Changeset in webkit [95719] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22

DEPS:

7:48 AM Changeset in webkit [95718] by bulach@chromium.org

1 edit
4 adds in trunk/LayoutTests

[chromium] Rebaseline following r95715
https://bugs.webkit.org/show_bug.cgi?id=68619

Unreviewed, rebaseline.

platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
platform/chromium-cg-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.
platform/chromium-mac/fast/events/scale-and-scroll-iframe-body-expected.png: Added.
platform/chromium-mac/fast/events/scale-and-scroll-iframe-window-expected.png: Added.

6:54 AM Changeset in webkit [95717] by hclam@chromium.org

2 edits in trunk/Source/WebCore

Define export symbol correctly due to rename of pageScaleFactor to
frameScaleFactor.

Not reviewed. Build fix.

WebCore.exp.in:

6:43 AM Changeset in webkit [95716] by vsevik@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Console is always scrolled to the top
https://bugs.webkit.org/show_bug.cgi?id=67483

Reviewed by Pavel Feldman.

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.wasShown):
(WebInspector.ConsoleView.prototype.storeScrollPositions):
(WebInspector.ConsoleView.prototype.restoreScrollPositions):
(WebInspector.ConsoleView.prototype.onResize):
(WebInspector.ConsoleView.prototype._immediatelyScrollIntoView):
(WebInspector.ConsoleView.prototype._cancelScheduledScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleCleared):

inspector/front-end/Drawer.js:

(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):

inspector/front-end/inspector.js:

(WebInspector.animateStyle):
(WebInspector.animateStyle.forceComplete):

6:30 AM Changeset in webkit [95715] by hclam@chromium.org

11 edits
12 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

The following things are done in this patch:

Rename Frame::pageScaleFactor() to Frame::frameScaleFactor() to better reflect its purpose.
Frame::frameScaleFactor() returns the scale factor of this frame with respect to the container. So for the main frame it'll return the scale factor of the page, inner frames will return 1.0
scrollBy(), scrollX() and scrollY() to take into account of the frame scale factor, causing incorrect coordinates reported to Javascript.

Tests: fast/events/scale-and-scroll-body.html

fast/events/scale-and-scroll-iframe-body.html
fast/events/scale-and-scroll-iframe-window.html
fast/events/scale-and-scroll-window.html

html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):

loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):

page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):
(WebCore::DOMWindow::scrollTo):

page/Frame.cpp:

(WebCore::Frame::frameScaleFactor): Return page's scale factor if this is

main frame, otherwise 1.0

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::scrollXForFixedPosition):
(WebCore::FrameView::scrollYForFixedPosition):

Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=68081
Fix scroll in page scaling mode.

Reviewed by Simon Fraser.

WebProcess/Plugins/PluginView.cpp: Rename pageScaleFactor to frameScaleFactor.

(WebKit::PluginView::handleEvent):
(WebKit::PluginView::viewGeometryDidChange):
(WebKit::PluginView::clipRectInWindowCoordinates):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=68081
Add layout test for page scale and scrolling.

Reviewed by Simon Fraser.

Add tests to cover the following cases:

Scale and scroll window
Scale and scroll document.body
Scale and scroll iframe's contentWindow
Scale and scroll iframe's contentDocument.body

fast/events/scale-and-scroll-body-expected.png: Added.
fast/events/scale-and-scroll-body-expected.txt: Added.
fast/events/scale-and-scroll-body.html: Added.
fast/events/scale-and-scroll-iframe-body-expected.png: Added.
fast/events/scale-and-scroll-iframe-body-expected.txt: Added.
fast/events/scale-and-scroll-iframe-body.html: Added.
fast/events/scale-and-scroll-iframe-window-expected.png: Added.
fast/events/scale-and-scroll-iframe-window-expected.txt: Added.
fast/events/scale-and-scroll-iframe-window.html: Added.
fast/events/scale-and-scroll-window-expected.png: Added.
fast/events/scale-and-scroll-window-expected.txt: Added.
fast/events/scale-and-scroll-window.html: Added.

6:25 AM Changeset in webkit [95714] by commit-queue@webkit.org

3 edits
3 adds in trunk

CSS: Implement 'font' property in CSSComputedStyle.
https://bugs.webkit.org/show_bug.cgi?id=66666

Patch by Andreas Kling <kling@webkit.org> on 2011-09-22
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/getComputedStyle/computed-style-font.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontFamilyFromStyle): Factored out of getPropertyCSSValue().
This function will always return a CSSValueList, as opposed to the previous
implementation which would return a CSSPrimitiveValue if there was only one family.
getCSSPropertyValue() will return the first element of the list for 1-element lists
to preserve the current behavior of getPropertyCSSValue('font-family').

(WebCore::lineHeightFromStyle): Factored out of getPropertyCSSValue().
(WebCore::fontSizeFromStyle): Ditto.
(WebCore::fontStyleFromStyle): Ditto.
(WebCore::fontVariantFromStyle): Ditto.
(WebCore::fontWeightFromStyle): Ditto.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
implementation of the computed 'font' property (CSSPropertyFont.)

LayoutTests:

fast/css/getComputedStyle/computed-style-font-expected.txt: Added.
fast/css/getComputedStyle/computed-style-font.html: Added.
fast/css/getComputedStyle/script-tests/computed-style-font.js: Added.

(computedFont):
(computedFontCSSValue):

6:05 AM Changeset in webkit [95713] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk

Remove useless empty WebKit namespace.

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2011-09-22
Reviewed by Xan Lopez.

webkit/webkitglobals.cpp:

(webkitInit):

6:01 AM Changeset in webkit [95712] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt][WK2] Unreivewed gardening.

platform/qt-wk2/Skipped: Skip new failing test introduced in r95645.

5:50 AM Changeset in webkit [95711] by Csaba Osztrogonác

64 edits in trunk/LayoutTests

[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed gardening. Update Qt 4.8 specific expected files after r95706.

platform/qt-4.8/ [...]: Updated.

5:43 AM Changeset in webkit [95710] by jesus@webkit.org

4 edits in trunk/Source

[Qt] Redirection overflow errors have wrong error domain
https://bugs.webkit.org/show_bug.cgi?id=68612

Reviewed by Andreas Kling.

Source/WebCore:

Redirection overflow currently puts the URL hostname in the errorDomain field.
Now redirection overflow errors will be classified as "HTTP" errors.

platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::redirect):

Source/WebKit2:

Redirection overflow currently puts the URL hostname in the errorDomain field
and therefore are treated as a QWebError::EngineError. From now on they
will be treated as QWebError::HttpError, since their error domain was modified
to "HTTP" in QNetworkReplyHandler::redirect().

UIProcess/API/qt/qweberror.cpp:

(QWebError::type):

5:23 AM Changeset in webkit [95709] by Csaba Osztrogonác

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add Qt specific expected files for new test introduced in r95671.

platform/qt/fast/table/quote-text-around-iframe-expected.png: Added.
platform/qt/fast/table/quote-text-around-iframe-expected.txt: Added.

4:50 AM Changeset in webkit [95708] by Csaba Osztrogonác

8 edits in trunk/Source/WebKit2

REGRESSION(r95679): It broke everything.
https://bugs.webkit.org/show_bug.cgi?id=68611

Unreviewed rolling out r95679 and r95690, because it broke everything.

UIProcess/API/mac/WKView.mm:

(maybeCreateSandboxExtensionFromPasteboard):
(-[WKView performDragOperation:]):

UIProcess/WebContext.cpp:

(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
(WebKit::WebContext::getPluginPath):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::initializeSandboxExtensionHandle):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::didInitiateLoadForResource):
(WebKit::WebPageProxy::didSendRequestForResource):
(WebKit::WebPageProxy::didReceiveResponseForResource):
(WebKit::WebPageProxy::missingPluginButtonClicked):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::addBackForwardItem):

UIProcess/WebProcessProxy.h:
UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

4:05 AM Changeset in webkit [95707] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

32-bit call code clobbers the function cell tag
https://bugs.webkit.org/show_bug.cgi?id=68606

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Csaba Osztrogonác.

This is a minimalistic fix: it simply emits code to restore the
cell tag on the slow path, if we know that we failed due to
emitCallIfNotType.

jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCallSlowCase):

3:23 AM Changeset in webkit [95706] by Csaba Osztrogonác

134 edits
2 adds in trunk/LayoutTests

[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
https://bugs.webkit.org/show_bug.cgi?id=65721

Unreviewed gardening. Update Qt specific expected files.

3:17 AM Changeset in webkit [95705] by bulach@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update test expectation following r95685
https://bugs.webkit.org/show_bug.cgi?id=68604

Unreviewed, update test expectation.

platform/chromium/test_expectations.txt:

3:05 AM Changeset in webkit [95704] by Csaba Osztrogonác

13 edits
1 add in trunk/LayoutTests

[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596

Update Qt specific expected files.

platform/qt/fast/css-generated-content/table-cell-before-content-expected.png:
platform/qt/fast/css-generated-content/table-cell-before-content-expected.txt:
platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
platform/qt/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
platform/qt/fast/table/table-cell-before-after-content-around-table-expected.txt:
platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
platform/qt/fast/table/table-row-before-after-content-around-block-expected.txt:
platform/qt/fast/table/table-row-before-after-content-around-table-expected.txt:
platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt:

2:29 AM Changeset in webkit [95703] by loki@webkit.org

2 edits in trunk/LayoutTests

[Qt] 11 tests failed after r95671 because the tests are updated.
https://bugs.webkit.org/show_bug.cgi?id=68596

Unreviewed gardening. Typo fixes.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22

platform/qt/Skipped:

12:53 AM Changeset in webkit [95702] by jamesr@google.com

15 edits in trunk/Source

Unreviewed, rolling out r95699.
http://trac.webkit.org/changeset/95699
https://bugs.webkit.org/show_bug.cgi?id=67417

Makes many chromium compositor tests crash

Source/WebCore:

platform/CrossThreadCopier.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):

platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCProxy.h:
platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::TEST_F):

tests/TreeSynchronizerTest.cpp:

(WebCore::TEST):

12:40 AM Changeset in webkit [95701] by Philippe Normand

11 edits
2 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline after r95671.

platform/gtk/fast/css-generated-content/table-cell-before-content-expected.txt:
platform/gtk/fast/table/quote-text-around-iframe-expected.png: Added.
platform/gtk/fast/table/quote-text-around-iframe-expected.txt: Added.
platform/gtk/fast/table/table-cell-after-child-in-block-expected.txt:
platform/gtk/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
platform/gtk/fast/table/table-cell-before-after-content-around-table-expected.txt:
platform/gtk/fast/table/table-cell-before-child-in-block-expected.txt:
platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
platform/gtk/fast/table/table-row-before-after-content-around-block-expected.txt:
platform/gtk/fast/table/table-row-before-after-content-around-table-expected.txt:
platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt:

12:35 AM Changeset in webkit [95700] by reni@webkit.org

2 edits in trunk/LayoutTests

[Qt] 11 tests failed after r95671.
https://bugs.webkit.org/show_bug.cgi?id=68596

Unreviewed gardening.

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-22

platform/qt/Skipped:

12:22 AM Changeset in webkit [95699] by jamesr@google.com

15 edits in trunk/Source

[chromium] Make CCThreadProxy draw
https://bugs.webkit.org/show_bug.cgi?id=67417

Source/WebCore:

Update the CCThreadProxy to correctly implement the CCProxy
interface, do all the right committing and updating steps, and
draw a picture on the screen.

Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.

platform/graphics/IntRect.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::~LayerRendererChromium):

platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):

platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::~CCLayerImpl):

platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::setNeedsRedraw):

platform/graphics/chromium/cc/CCLayerTreeHost.h:
platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):

platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::~CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::drawLayersAndReadbackOnCCThread):
(WebCore::CCThreadProxy::finishAllRendering):
(WebCore::CCThreadProxy::isStarted):
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitAndRedraw):
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::start):
(WebCore::CCThreadProxy::stop):
(WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::commitOnCCThread):
(WebCore::CCThreadProxy::scheduleDrawTaskOnCCThread):
(WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
(WebCore::CCThreadProxy::drawLayersOnCCThread):
(WebCore::CCThreadProxy::updateSchedulerStateOnCCThread):

platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

Disable CCLayerTreeHostTest temporarily. Will re-enable
with https://bugs.webkit.org/show_bug.cgi?id=67418

Patch by Nat Duca <nduca@chromium.org> on 2011-09-22
Reviewed by James Robinson.

tests/CCLayerTreeHostTest.cpp:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed