⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 11, 2012:

11:35 PM Changeset in webkit [113945] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

Implement Location.ancestorOrigins
​https://bugs.webkit.org/show_bug.cgi?id=83493

Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/Window/Location/ancestor-origins.html

This patch implements Location.ancestorOrigins(), which returns a list
of the origins of the enclosing frames. This API has been discussed
both on webkit-dev (see discussion following
​https://lists.webkit.org/pipermail/webkit-dev/2012-March/020090.html)
and on the whatwg list (see discussion following
​http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035188.html).

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):
(WebCore):

  • page/Location.h:

(Location):

  • page/Location.idl:

LayoutTests:

  • fast/dom/Window/Location/ancestor-origins-expected.txt: Added.
  • fast/dom/Window/Location/ancestor-origins.html: Added.
11:30 PM WebKitIDL edited by arv@chromium.org
Document the ArrayClass IDL attribute (diff)
11:05 PM Changeset in webkit [113944] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline.

Patch by Antonio Gomes <​agomes@rim.com> on 2012-04-11

  • media/nodesFromRect-shadowContent-expected.txt:
10:51 PM Changeset in webkit [113943] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/chromium

IndexedDB: Stub out WebKit interface for get(IndexedKeyRange)
​https://bugs.webkit.org/show_bug.cgi?id=83637

Patch by Alec Flett <​alecflett@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.

This is just a stub-out of IDBObjectStore.get(IDBKeyRange) to coordinate
a landing in chromium

  • public/WebIDBObjectStore.h:

(WebKit::WebIDBObjectStore::get):
(WebIDBObjectStore):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::get):
(WebKit):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):
(WebKit):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

10:40 PM Changeset in webkit [113942] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

fast/text/international/font-fallback-to-common-script.html fails on Mac
​https://bugs.webkit.org/show_bug.cgi?id=83743

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-04-11
Reviewed by Kent Tamura.

Change test not assume that there is no font setting for Simplified Chinese.

  • fast/text/international/font-fallback-to-common-script.html:
  • platform/mac/Skipped:
9:19 PM Changeset in webkit [113941] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

It is incorrect to short-circuit Branch(LogicalNot(@a)) if boolean speculations on @a may fail
​https://bugs.webkit.org/show_bug.cgi?id=83744
<rdar://problem/11206946>

Source/JavaScriptCore:

Reviewed by Andy Estes.

This does the conservative thing: it only short-circuits Branch(LogicalNot(@a)) if @a is a node
that is statically known to return boolean results.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Rubber stamped by Andy Estes.

  • fast/js/dfg-branch-not-fail-expected.txt: Added.
  • fast/js/dfg-branch-not-fail.html: Added.
  • fast/js/script-tests/dfg-branch-not-fail.js: Added.

(foo):
(bar):

8:48 PM Changeset in webkit [113940] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

AudioContext createChannelSplitter() method should have optional argument for number of outputs
​https://bugs.webkit.org/show_bug.cgi?id=83648

Patch by Raymond Liu <​raymond.liu@intel.com> on 2012-04-11
Reviewed by Chris Rogers.

Check ​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.

Source/WebCore:

Test: webaudio/audiochannelsplitter.html

  • Modules/webaudio/AudioChannelSplitter.cpp:

(WebCore::AudioChannelSplitter::create):
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
(WebCore::AudioChannelSplitter::process):

  • Modules/webaudio/AudioChannelSplitter.h:

(AudioChannelSplitter):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createChannelSplitter):
(WebCore):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioContext.idl:

LayoutTests:

  • webaudio/audiochannelsplitter-expected.txt: Added.
  • webaudio/audiochannelsplitter.html: Added.
8:34 PM Changeset in webkit [113939] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Revert the changes that depend on Event changes, which is reverted already internally.
​https://bugs.webkit.org/show_bug.cgi?id=83456

Reviewed by George Staikos.

No new tests, just to make BlackBerry-porting to build.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleTouchEvent):
(WebCore::PluginView::handleMouseEvent):

8:06 PM Changeset in webkit [113938] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] There shouldn't be two or more Accept-Language in platformRequest's headerList.
​https://bugs.webkit.org/show_bug.cgi?id=83670

FrameLoaderClientBlackBerry::dispatchWillSendRequest and NetworkManager::startJob will call
ResourceRequest::initializePlatformRequest. Accept-Language is added two times.
We should avoid the second adding to improve performance.

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-04-11
Reviewed by Rob Buis.

No new tests. Refactor.

  • platform/network/blackberry/ResourceRequestBlackBerry.cpp:

(WebCore::ResourceRequest::initializePlatformRequest):

7:32 PM April 2012 Meeting edited by rniwa@webkit.org
Add slides for perf-o-matic / performance tests talk (diff)
7:10 PM Changeset in webkit [113937] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[BlackBerry] MMRPlayer will hang webkit thread when retrieving media metadata
​https://bugs.webkit.org/show_bug.cgi?id=80978

Patch by Jonathan Dong <Jonathan Dong> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 143471
Implemented the interface function onWaitMetadataNotified()
which starts a timer to wait for the metadata retrieving to
finish, and pops up a dialog to notify the user what to do
if there still is no metadata when the timer fires.

This patch also contributed by Max Feil <​mfeil@rim.com>.
Internally reviewed by Max Feil.

Test: http/tests/media/video-throttled-load-metadata.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::onWaitMetadataNotified):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

RIM PR: 143471
Added a layout test which simulates a slow network, and starts a web worker
thread to write a log message when retrieving media metadata to see if the
webkit thread is blocked by media retrieving thread.

  • http/tests/media/video-throttled-load-metadata-expected.txt: Added.
  • http/tests/media/video-throttled-load-metadata-worker.js: Added.
  • http/tests/media/video-throttled-load-metadata.html: Added.
6:55 PM Changeset in webkit [113936] by bashi@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Fix Windows warnings in WebSocketDeflaterTest
​https://bugs.webkit.org/show_bug.cgi?id=83731

Reviewed by Kent Tamura.

Use const char* instead of const char[] to suppress warnings on
Windows.

  • tests/WebSocketDeflaterTest.cpp:

(WebCore::TEST):

6:38 PM Changeset in webkit [113935] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Invalid Union Reference in StructureStubInfo.{cpp.h}
​https://bugs.webkit.org/show_bug.cgi?id=83735

Reviewed by Filip Pizlo.

Changed the references to u.getByIdProtoList and u.getByIdSelfList
to be consistent.

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initGetByIdSelfList):

6:31 PM April 2012 Meeting edited by rniwa@webkit.org
Merge two test importing topics into one (diff)
6:13 PM Changeset in webkit [113934] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed attempting to make Qt's eccentric hardware work.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::compare8):
(MacroAssemblerARM):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::compare8):
(MacroAssemblerMIPS):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::compare8):
(MacroAssemblerSH4):

6:09 PM Changeset in webkit [113933] by jer.noble@apple.com
  • 4 edits in trunk

Layout Test webaudio/* is flaky
​https://bugs.webkit.org/show_bug.cgi?id=83624

Reviewed by Chris Rogers.

Source/WebCore:

No new tests; fixes webaudio/ layout tests.

A merge error led to an Mutex overunlock situation, which caused all future mutex trylock
attempts to fail, but only on Windows. Remove the extraneous mutex unlock().

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):

LayoutTests:

Re-enable webaudio/ layout tests on chromium-win.

  • platform/chromium/test_expectations.txt:
6:02 PM Changeset in webkit [113932] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Correct pixel snapping error in RenderBox::pixelSnappedClientWidth/Height
​https://bugs.webkit.org/show_bug.cgi?id=83621

Reviewed by Eric Seidel.

Though the problem wouldn't yet manifest itself since we haven't flipped the switch on sub-pixel
layout, clientWidth and clientHeight, when pixel snapped, need to take the RenderBox's location
into account. Previously, ClientLeft/Top were used, but these are simply the width of the borders,
and don't include the box's sub-pixel location, which is needed to properly snap the width/height.

No new tests. Untestable until we switch to FractionalLayoutUnits. A test case that covers this
is in the subpixellayout branch and will land with the switch.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollWidth): Replacing a raw zero with ZERO_LAYOUT_UNIT.

6:00 PM Changeset in webkit [113931] by arv@chromium.org
  • 31 edits
    1 copy
    4 adds in trunk

Add support for [ArrayClass] and use that on NodeList
​https://bugs.webkit.org/show_bug.cgi?id=81573

Reviewed by Adam Barth.

With this patch NodeLists now have Array.prototype on their prototype chain which allows
methods such as forEach and map to work on NodeLists.

​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-nodelist

For V8 we need to set a flag on the WrapperTypeInfo since V8 uses FunctionTemplates which
does not allow setting the prototype to a non FunctionTemplate so the prototype is therefore
set when the constructor is created.

For JSC we just pass the right prototype object when creating the NodeList prototype. JSC has
a bug (81588) that prevents toString to work as specced on Array.prototype.toString. This
causes test failures in the tests until that has been fixed.

Source/WebCore:

Test: fast/dom/NodeList/node-list-array-class.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Include ArrayPrototype.h if an ArrayClass.
(GenerateImplementation): If ArrayClass use arrayPrototype as prototype.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):
(GenerateImplementation): Adds a flag to the WrapperTypeInfo.

  • bindings/scripts/IDLAttributes.txt: Adds new attribute: ArrayClass.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::createPrototype):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

  • bindings/v8/V8BindingPerContextData.cpp:

(WebCore::V8BindingPerContextData::init): Get the array prototype too.
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase): If this is an ArrayClass we need to
set the Prototype.

  • bindings/v8/V8BindingPerContextData.h:

(V8BindingPerContextData):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeInfo):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

  • dom/NodeList.idl:

LayoutTests:

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/NodeList/node-list-array-class-expected.txt: Added.
  • fast/dom/NodeList/node-list-array-class.html: Added.
  • fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
  • platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Copied from LayoutTests/fast/dom/HTMLSelectElement/named-options-expected.txt.
  • platform/chromium/inspector/console/command-line-api-expected.txt: Added.
  • platform/chromium/inspector/console/console-dir-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
  • platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
5:55 PM Changeset in webkit [113930] by fpizlo@apple.com
  • 29 edits in trunk/Source/JavaScriptCore

op_is_foo should be optimized
​https://bugs.webkit.org/show_bug.cgi?id=83666

Reviewed by Gavin Barraclough.

This implements inlining of op_is_undefined, op_is_string, op_is_number,
and op_is_boolean in LLInt and the baseline JIT. op_is_object and
op_is_function are not inlined because they are quite a bit more complex.

This also implements all of the op_is_foo opcodes in the DFG, but it does
not do any type profiling based optimizations, yet.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::compare8):
(MacroAssemblerARMv7):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::compare8):
(MacroAssemblerX86Common):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::testPtr):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArguments):
(CCallHelpers):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):

  • jit/JITStubs.cpp:

(JSC):

  • llint/LLIntSlowPaths.cpp:

(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/armv7.rb:
  • offlineasm/instructions.rb:
  • offlineasm/x86.rb:
5:43 PM Changeset in webkit [113929] by dpranke@chromium.org
  • 4 edits in trunk/Tools

Fix regression introduced in r113927.

Unreviewed, build fix.

I failed to rename skipped_tests() to skipped_layout_tests()
everywhere it needed to be renamed. The unit tests didn't catch
this because the TestPort was one of the places that didn't get
renamed :(.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.parse_expectations):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort.skipped_layout_tests):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations._model):

5:29 PM Changeset in webkit [113928] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

If you use an IntegerOperand and want to return it with integerResult, you need to
zero extend to get rid of the box
​https://bugs.webkit.org/show_bug.cgi?id=83734
<rdar://problem/11232296>

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):

5:13 PM Changeset in webkit [113927] by dpranke@chromium.org
  • 8 edits in trunk/Tools

new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
​https://bugs.webkit.org/show_bug.cgi?id=47528

Reviewed by Adam Barth.

The skipped-ports command has been replaced by 'webkit-patch
print-expectations', which offers the equivalent functionality
via 'webkit-patch print-expectations --platform \* -t skip'
(and other features, of course).

This also allows me to fix a nasty layering violation where the
chromium port had to know about the TestExpectations objects in
order to implement the command properly.

Lastly, this allows me to rename skipped_tests() to
skipped_layout_tests() to more consistent with
skipped_perf_tests().

This patch removes skips_layout_test() from the Port interface,
because that can't be implemented without the port knowing about
Expectations objects (and skipped-ports was the only thing using it).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skipped_layout_tests):
(Port.skipped_perf_tests):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_default_configuration_notfound):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_path_to_image_diff):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort.skipped_layout_tests):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(QueryCommandsTest.test_tree_status):

4:46 PM Changeset in webkit [113926] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove an autorelease pool made redundant by r113923.
​https://bugs.webkit.org/show_bug.cgi?id=83730

Reviewed by Dan Bernstein.

Remove flushLayer()'s autorelease pool, since one now exists in the
call frame above it (in LayerFlushScheduler::runLoopObserverCallback()).

  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::flushLayers):

4:41 PM Changeset in webkit [113925] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix build with XSLT disabled.

Not reviewed.

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::parseStyleSheet):

4:32 PM April 2012 Meeting edited by adele@apple.com
(diff)
4:31 PM Changeset in webkit [113924] by arv@chromium.org
  • 8 edits in trunk

File API does not support DOM events (like addEventListener)
​https://bugs.webkit.org/show_bug.cgi?id=83688

Reviewed by Adam Barth.

Source/WebCore:

The IDL files where missing addEventListener, removeEventListener and dispatchEvent.

Tests: fast/filesystem/file-writer-events.html

fast/speech/scripted/basics.html

  • Modules/filesystem/FileWriter.idl: Add missing methods.
  • Modules/mediastream/LocalMediaStream.idl: This one gets its EventTarget from MediaStream.
  • Modules/speech/SpeechRecognition.idl: Add missing methods.

LayoutTests:

  • fast/filesystem/resources/file-writer-events.js:

(runTest):

  • fast/speech/scripted/basics-expected.txt:
  • fast/speech/scripted/basics.html:
4:28 PM Changeset in webkit [113923] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

LayerFlushScheduler's run loop observer should have an autorelease pool.
​https://bugs.webkit.org/show_bug.cgi?id=83729

Reviewed by Dan Bernstein.

LayerFlushScheduler's run loop observer needs an autorelease pool.
NSApplication creates one, but it is only drained after processing user
input. In the case where a WebView is displaying composited content but
not receiving user input, NSApplication's pool will accumulate a large
number of objects autoreleased by the run loop observer. Have
LayerFlushScheduler create an autorelease pool that is drained after
each run loop observer callback.

  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::runLoopObserverCallback):

4:20 PM Changeset in webkit [113922] by Antti Koivisto
  • 48 edits in trunk/Source

Split CSSStyleSheet into internal and CSSOM type
​https://bugs.webkit.org/show_bug.cgi?id=83612

Reviewed by Andreas Kling.

This will complete the separation of our style sheet data structures from CSSOM.

The internal parts of CSSStyleSheet move to StyleSheetInternal. CSS parser
and style selector will now operate on internal types. Unlike other CSSOM types
CSSStyleSheets are still always instantiated to hold the top level author stylesheets
(by Nodes).

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::addSubresourceStyleURLs):

  • css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

  • css/CSSImportRule.cpp:

(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::styleSheet):

  • css/CSSImportRule.h:

(WebCore):
(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::styleSheet):
(CSSImportRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::insertRule):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseFontFaceValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::parseFlowThread):

  • css/CSSParser.h:

(WebCore):
(CSSParser):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::addSubresourceStyleURLs):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::addSubresourceStyleURLs):

  • css/CSSReflectValue.h:

(CSSReflectValue):

  • css/CSSRule.h:

(CSSRule):

  • css/CSSStyleSelector.cpp:

(RuleSet):
(WebCore):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::parseUASheet):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

  • css/CSSStyleSelector.h:

(CSSStyleSelector):

Add a set for root CSSStyleSheet objects so that the wrappers created in ensureFullCSSOMWrapperForInspector
stay valid.


  • css/CSSStyleSheet.cpp:

(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::~StyleSheetInternal):
(WebCore::StyleSheetInternal::parserAppendRule):
(WebCore::StyleSheetInternal::createChildRuleCSSOMWrapper):
(WebCore::StyleSheetInternal::ruleCount):
(WebCore::StyleSheetInternal::clearCharsetRule):
(WebCore::StyleSheetInternal::clearRules):
(WebCore::StyleSheetInternal::parserSetEncodingFromCharsetRule):
(WebCore::StyleSheetInternal::wrapperInsertRule):
(WebCore::StyleSheetInternal::wrapperDeleteRule):
(WebCore::StyleSheetInternal::addNamespace):
(WebCore::StyleSheetInternal::determineNamespace):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore::StyleSheetInternal::isLoading):
(WebCore::StyleSheetInternal::checkLoaded):
(WebCore::StyleSheetInternal::notifyLoadedSheet):
(WebCore::StyleSheetInternal::startLoadingDynamicSheet):
(WebCore::StyleSheetInternal::findStyleSheetOwnerNode):
(WebCore::StyleSheetInternal::findDocument):
(WebCore::StyleSheetInternal::setMediaQueries):
(WebCore::StyleSheetInternal::styleSheetChanged):
(WebCore):
(WebCore::StyleSheetInternal::baseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::StyleSheetInternal::addSubresourceStyleURLs):
(WebCore::StyleSheetInternal::parentStyleSheet):
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::setDisabled):
(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::cssRules):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::media):
(WebCore::CSSStyleSheet::parentStyleSheet):

  • css/CSSStyleSheet.h:

(WebCore):
(WebCore::StyleSheetInternal::create):
(WebCore::StyleSheetInternal::createInline):
(StyleSheetInternal):
(WebCore::StyleSheetInternal::ownerNode):
(WebCore::StyleSheetInternal::clearOwnerNode):
(WebCore::StyleSheetInternal::ownerRule):
(WebCore::StyleSheetInternal::originalURL):
(WebCore::StyleSheetInternal::title):
(WebCore::StyleSheetInternal::setTitle):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::finalURL):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::removeRule):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::styleSheetChanged):
(WebCore::CSSStyleSheet::findDocument):
(WebCore::CSSStyleSheet::internal):
(WebCore::CSSStyleSheet::isCSSStyleSheet):
(WebCore::CSSStyleSheet::type):

  • css/CSSValue.cpp:

(WebCore::CSSValue::addSubresourceStyleURLs):

  • css/CSSValue.h:

(WebCore):
(CSSValue):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::addSubresourceStyleURLs):

  • css/CSSValueList.h:

(CSSValueList):

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createFontFaceValue):

  • css/CSSValuePool.h:

(WebCore):
(CSSValuePool):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):

  • css/PropertySetCSSStyleDeclaration.h:

(WebCore):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::parseDeclaration):
(WebCore::StylePropertySet::addSubresourceStyleURLs):

  • css/StylePropertySet.h:

(WebCore):
(StylePropertySet):

  • css/StyleSheet.cpp:

(WebCore):

  • css/StyleSheet.h:

(StyleSheet):
(WebCore::StyleSheet::media):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::isXSLStyleSheet):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::insertRule):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createCSSStyleSheet):

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
(WebCore::Document::addUserSheet):
(WebCore::Document::elementSheet):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore::Document::analyzeStylesheetChange):

  • dom/Document.h:

(WebCore):
(Document):
(WebCore::Document::documentUserSheets):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet):
(WebCore::ProcessingInstruction::parseStyleSheet):

  • dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore):
(WebCore::StyledElement::addPropertyToAttributeStyle):

  • dom/StyledElement.h:

(WebCore):

  • html/HTMLFontElement.cpp:

(WebCore::HTMLFontElement::collectStyleForAttribute):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::setCSSStyleSheet):
(WebCore::HTMLLinkElement::styleSheetIsLoading):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::addSubresourceAttributeURLs):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::styleSheetURL):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::parseAttribute):

  • xml/XSLStyleSheet.h:

(XSLStyleSheet):
(WebCore::XSLStyleSheet::finalURL):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):

4:14 PM Changeset in webkit [113921] by commit-queue@webkit.org
  • 4 edits
    5 deletes in trunk

Unreviewed, rolling out r113912.
​http://trac.webkit.org/changeset/113912
​https://bugs.webkit.org/show_bug.cgi?id=83727

broke atsui-spacing-features.html on windows (Requested by
simonjam on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-11

Source/WebCore:

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Removed.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Removed.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Removed.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Removed.
4:08 PM Changeset in webkit [113920] by mrowe@apple.com
  • 2 edits in trunk/Tools

Remove a fprintf from LayoutTestController.

This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
It was added for no apparent reason by Ryosuke in r113651.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::redirectionDestinationForURL):

3:52 PM Changeset in webkit [113919] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

SpeculativeJIT::fillStorage() should work with all the states that a cell may be in
​https://bugs.webkit.org/show_bug.cgi?id=83722

Reviewed by Gavin Barraclough.

It's now possible to do StorageOperand on a cell, in the case that the storage is
inline. But this means that fillStorage() must be able to handle all of the states
that a cell might be in. Previously it didn't.

With this change, it now does handle all of the states, and moreover, it does so
by preserving the DataFormat of cells and performing all of the cell speculations
that should be performed if you're using a cell as storage. But if you use this on
something that is known to be storage already then it behaves as it did before.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::fillStorage):

3:48 PM Changeset in webkit [113918] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] When rendering goes idle, do not count that time against frame rate
​https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <​anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
3:47 PM April 2012 Meeting edited by jacobg@adobe.com
(diff)
3:47 PM April 2012 Meeting edited by jacobg@adobe.com
(diff)
3:44 PM Changeset in webkit [113917] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two flaky plug-in tests.

  • platform/mac/Skipped:
3:38 PM Changeset in webkit [113916] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add tests that broke in r113900 to the Skipped list.

  • platform/mac/Skipped:
3:29 PM April 2012 Meeting edited by tomz@codeaurora.org
(diff)
3:25 PM April 2012 Meeting edited by rniwa@webkit.org
(diff)
3:12 PM Changeset in webkit [113915] by zmo@google.com
  • 4 edits in trunk/Source/WebCore

WebGLRenderingContext should defer caching program info
​https://bugs.webkit.org/show_bug.cgi?id=83513

Reviewed by Kenneth Russell.

  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::WebGLProgram):
(WebCore::WebGLProgram::numActiveAttribLocations): call cacheInfoIfNeeded();
(WebCore::WebGLProgram::getActiveAttribLocation): Ditto.
(WebCore::WebGLProgram::isUsingVertexAttrib0): Ditto.
(WebCore::WebGLProgram::getLinkStatus): Ditto.
(WebCore):
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::cacheInfoIfNeeded): Cache link status, active attire locations, etc if needed.
(WebCore::WebGLProgram::increaseLinkCount): also invalidate cached info.

  • html/canvas/WebGLProgram.h:

(WebGLProgram):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::linkProgram): Do not cache program info immediately.

3:04 PM Changeset in webkit [113914] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

Add keySystem attribute to canPlayType() for Encrypted Media Extensions
​https://bugs.webkit.org/show_bug.cgi?id=82973

Patch by David Dorwin <​ddorwin@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

The new attribute is behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
​http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#extensions.

Source/Platform:

  • chromium/public/WebMimeRegistry.h:

(WebKit::WebMimeRegistry::supportsMediaMIMEType):

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-can-play-type-webm.html

media/encrypted-media/encrypted-media-can-play-type.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadNextSourceChild):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::havePotentialSourceChild):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::getPluginProxyParams):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::supportsType):
(WebCore::MediaPlayer::networkStateChanged):

  • platform/graphics/MediaPlayer.h:

(MediaPlayer):
(WebCore):

Source/WebKit/chromium:

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::supportsType):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
  • media/encrypted-media/encrypted-media-can-play-type-webm-expected.txt: Added.
  • media/encrypted-media/encrypted-media-can-play-type-webm.html: Added.
  • media/encrypted-media/encrypted-media-can-play-type.html: Added.
2:43 PM Changeset in webkit [113913] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

[Qt] InspectorServer: Add an API level auto test
​https://bugs.webkit.org/show_bug.cgi?id=83594

Patch by Jocelyn Turcotte <​jocelyn.turcotte@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

  • Source/tests.pri:
2:42 PM Changeset in webkit [113912] by xji@chromium.org
  • 4 edits
    5 adds in trunk

[chromium] wrong justification for arabic/persian page in cr-win.
​https://bugs.webkit.org/show_bug.cgi?id=83227

Reviewed by Kent Tamura.

Source/WebCore:

GDI used to do Kashida justification.
After switch to Skia, we need to use space padding to justify the text
(assume Skia can not do Kashida justification -- stretching words).

Test: fast/text/international/arabic-justify.html

  • platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::justify):

LayoutTests:

  • fast/text/international/arabic-justify.html: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
  • platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
  • platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
2:33 PM Changeset in webkit [113911] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113885.

  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
2:27 PM Changeset in webkit [113910] by tonikitoo@webkit.org
  • 4 edits in trunk/LayoutTests

All Mac bots occasionally fail tons of media/ sputnik/ and svg/ tests
​https://bugs.webkit.org/show_bug.cgi?id=83411

Reviewed by Eric Carlson.
Patch by Antonio Gomes <​agomes@rim.com>

Fix obvious problems with the test in order to make tests lets
flaky.

  • media/nodesFromRect-shadowContent.html:
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt:
2:07 PM Changeset in webkit [113909] by Martin Robinson
  • 9 edits
    1 copy
    1 add in trunk

[CAIRO] Make GLContextGLX a subclass of GLContext
​https://bugs.webkit.org/show_bug.cgi?id=81285

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Add a configuration option for activating GLX.

This is selected automatically now, but in the future there will be
the choice to turn on EGL and turn off GLX at compilation time.

  • configure.ac: Ditto.

Source/WebCore:

No new tests. This should not change behavior.

  • GNUmakefile.list.am: Add new GLContextGLX files.
  • platform/graphics/cairo/GLContext.cpp: Added. Composed of the

EGL/GLX independent portions of GLContext. Made the current context
a static variable so we can keep getting the current context platform-
-independent.

  • platform/graphics/cairo/GLContext.h: Make this class an abstract

class. GLContextGLX is a concrete implementation.

  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Updated to reflect

slightly different calling conventions to create a sharing context.

  • platform/graphics/glx/GLContextGLX.cpp: Updated to reflect

that this code is in a subclass now.

  • platform/graphics/glx/GLContextGLX.h: Copied from Source/WebCore/platform/graphics/cairo/GLContext.h.
  • platform/graphics/gtk/GLContextGtk.cpp:

(WebCore::GLContext::getContextForWidget): Updated to respect the new
USE(GLX) flag.

2:03 PM Changeset in webkit [113908] by rniwa@webkit.org
  • 3 edits
    2 adds
    30 deletes in trunk/LayoutTests

fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html should be text tests
​https://bugs.webkit.org/show_bug.cgi?id=83715

Reviewed by Rob Buis.

Converted the fast/dom/dom-parse-serialize.html and dom-parse-serialize-display.html to dumpAsText tests.

  • fast/dom/dom-parse-serialize-display-expected.txt: Added.
  • fast/dom/dom-parse-serialize-display.html:
  • fast/dom/dom-parse-serialize-expected.txt: Added.
  • fast/dom/dom-parse-serialize.html:
  • platform/chromium-linux/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-linux/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-mac/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/chromium-win/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/efl/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/gtk/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/mac-leopard/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/mac-leopard/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/mac/fast/dom/dom-parse-serialize-expected.txt: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-display-expected.png: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-display-expected.txt: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-expected.png: Removed.
  • platform/qt/fast/dom/dom-parse-serialize-expected.txt: Removed.
1:57 PM Changeset in webkit [113907] by leviw@chromium.org
  • 7 edits
    3 adds in branches/subpixellayout

Fixing a truncation of length values that was occuring after a refactor in LengthFunctions and dealing with the repercussions in RenderMarquee, Document, and RenderFrameSet. Also correcting a table border painting issue evident in fast/multicol/table-vertical-align that only crops up in multi-column tables. We must floor the size when painting the Table's decorations because we ultimately lay out the contents using flooring.

1:51 PM Changeset in webkit [113906] by fpizlo@apple.com
  • 10 edits
    1 delete in trunk/Source/JavaScriptCore

Global variable predictions should not be coalesced unnecessarily
​https://bugs.webkit.org/show_bug.cgi?id=83678

Reviewed by Geoff Garen.

Removed the PredictionTracker and everyone who used it. Converted GetGlobalVar
to have a heapPrediction like a civilized DFG opcode ought to.

No performance effect.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.h:
  • bytecode/PredictionTracker.h: Removed.
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGenerationInfo.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

1:34 PM Changeset in webkit [113905] by tomz@codeaurora.org
  • 15 edits
    67 moves
    10 adds in trunk/LayoutTests

Unreviewed gardening and fix naming on EFL expected.txt files

  • platform/chromium-linux/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac-leopard/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium-win/fast/text/text-shadow-no-default-color-expected.png: Added.
  • platform/chromium-win/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/efl/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-001-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-002-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-003-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-004-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-006-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-007-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-008-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-009-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt.
  • platform/efl/ietestcenter/css3/text/textshadow-010-expected.txt: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt.
  • platform/efl/test_expectations.txt:
  • platform/mac/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • platform/qt/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/qt/test_expectations.txt:
1:26 PM Changeset in webkit [113904] by Lucas Forschler
  • 5 edits in branches/safari-534.57-branch/Source

Versioning.

1:25 PM Changeset in webkit [113903] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Upstream BlackBerry change to PatternSkia.cpp
​https://bugs.webkit.org/show_bug.cgi?id=83361

Reviewed by Antonio Gomes.

Upstream a cleaned up version.

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

1:19 PM Changeset in webkit [113902] by jamesr@google.com
  • 25 edits in trunk/Source

[chromium] Add OVERRIDE annotations for cc layer types
​https://bugs.webkit.org/show_bug.cgi?id=83658

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to overrides of functions on these classes:

  • CCLayerImpl
  • LayerChromium
  • TiledLayerChromium

Source/WebCore:

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/CanvasLayerChromium.h:

(CanvasLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/PluginLayerChromium.h:

(PluginLayerChromium):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/VideoLayerChromium.h:

(VideoLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

  • src/WebLayerImpl.cpp:
  • src/WebLayerImpl.h:

(WebLayerImpl): Removed unused and empty paintContents() function.

  • tests/CCLayerIteratorTest.cpp:
  • tests/CCLayerTreeHostCommonTest.cpp:
  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCOcclusionTrackerTest.cpp:
  • tests/CCTiledLayerTestCommon.h:

(FakeTiledLayerChromium):

  • tests/LayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:
1:16 PM Changeset in webkit [113901] by thakis@chromium.org
  • 2 edits in trunk/Tools

[mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
​https://bugs.webkit.org/show_bug.cgi?id=83709

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventCarbon):

1:13 PM Changeset in webkit [113900] by ap@apple.com
  • 6 edits
    4 adds in trunk

[Mac] lang, xml:lang, content-language ignored when choosing fonts
​https://bugs.webkit.org/show_bug.cgi?id=10874
<rdar://problem/3220202>

Reviewed by Dan Bernstein.

Adding a default font table for Mac port. Clients can still override these if they want to,
but knowing which fonts to use is more about the platform than about the client.

Tests: platform/mac/fonts/han-disunification.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Resources/DefaultFonts.plist.in: Added. Added SettingsMac.mm. Added preprocessed property list with default fonts.
  • page/Settings.cpp: (WebCore::setGenericFontFamilyMap): Don't notify the page if we don't have one yet. (WebCore::Settings::Settings): Assign to m_page after calling initializeDefaultFontFamilies, so that we won't try to call page->setNeedsRecalcStyleInAllFrames() in a half-initialized Page that's creating settings. (WebCore::Settings::initializeDefaultFontFamilies): Dummy imlplementation for ports that rely on client to set defaults.
  • page/Settings.h: Added initializeDefaultFontFamilies().
  • page/mac/SettingsMac.mm: Added. (WebCore::defaultFontFamilyDictionary): (WebCore::Settings::initializeDefaultFontFamilies): Load defaults from a plist file inside WebCore framework.
1:05 PM Changeset in webkit [113899] by simonjam@chromium.org
  • 9 edits
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-linux/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-linux/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-mac/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/chromium-win/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/chromium-win/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
  • platform/chromium/test_expectations.txt:
1:03 PM Changeset in webkit [113898] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Crash in CSSStyleSheet::deleteRule
​https://bugs.webkit.org/show_bug.cgi?id=83708

Source/WebCore:

Reviewed by Andreas Kling.

Andreas spotted that the wrapper needs to be null checked before calling setParentStyleSheet(0).

Test: fast/css/delete-rule-crash.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::deleteRule):

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/delete-rule-crash.html: Added.
  • fast/css/delete-rule-crash-expected.txt: Added.
1:00 PM Changeset in webkit [113897] by adamk@chromium.org
  • 10 edits in trunk

[MutationObservers] Setting an attributeFilter should filter out all namespaced attribute mutations
​https://bugs.webkit.org/show_bug.cgi?id=83706

Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch amounts to plumbing QualifiedName all the way down to shouldReceiveMutationFrom
as it now needs to know about namespaceURI as well as localName.

This change is coming soon to the DOM4 spec, see
​https://www.w3.org/Bugs/Public/show_bug.cgi?id=16563 for more discussion.

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):

  • dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(MutationObserverInterestGroup):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):

  • dom/MutationObserverRegistration.h:

(WebCore):
(MutationObserverRegistration):

  • dom/Node.cpp:

(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):

  • dom/Node.h:

(Node):

LayoutTests:

Updated attributes test to match new behavior.

  • fast/mutation/observe-attributes-expected.txt:
  • fast/mutation/observe-attributes.html:
1:00 PM Changeset in webkit [113896] by Lucas Forschler
  • 1 copy in branches/safari-534.57-branch

New Branch.

12:52 PM Changeset in webkit [113895] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Tools

Adding myself to committers.py
​https://bugs.webkit.org/show_bug.cgi?id=83711

Unreviewed update to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
12:51 PM Changeset in webkit [113894] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add two more DOM storage tests to the Skipped list.

  • platform/mac/Skipped:
12:45 PM Changeset in webkit [113893] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] LayoutTestController needs implementation of pageProperty
​https://bugs.webkit.org/show_bug.cgi?id=82449

Source/WebKit/efl:

Add missing implementation pageProperty to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::pageProperty):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation pageProperty to EFL's LayoutTestController
in order to unskip printing/page-rule-selection.html

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pageProperty):

LayoutTests:

Unskip printing/page-rule-selection.html

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-04-11
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
12:40 PM Changeset in webkit [113892] by andersca@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Move fast/js/navigator-language.html to platform/qt
​https://bugs.webkit.org/show_bug.cgi?id=83710

Reviewed by Ryosuke Niwa.

This test was for a Qt specific bug, and using setlocale on Mac will not update the preferred language correctly.

  • platform/qt/fast/js/navigator-language-expected.txt: Renamed from LayoutTests/fast/js/navigator-language-expected.txt.
  • platform/qt/fast/js/navigator-language.html: Renamed from LayoutTests/fast/js/navigator-language.html.
12:39 PM Changeset in webkit [113891] by schenney@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium/Linux] fonts-glyph-04-t.svg fails after r87152
​https://bugs.webkit.org/show_bug.cgi?id=61370

Unreviewed Chromium linux expectations update.

This test is now behaving like Mac. No complaints there, just a font change.

  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/chromium/test_expectations.txt:
12:33 PM Changeset in webkit [113890] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] svg/wicd/test-rightsizing-a.xhtml is flaky
​https://bugs.webkit.org/show_bug.cgi?id=66320

Unreviewed Chromium test expectations cleanup.

This test had been fixed some time ago and has no appearance in the flakiness board.

  • platform/chromium/test_expectations.txt:
12:26 PM Changeset in webkit [113889] by commit-queue@webkit.org
  • 6 edits
    1 copy
    1 add in trunk

add stereo source support in EqualPowerPanner
​https://bugs.webkit.org/show_bug.cgi?id=81092

Patch by Wei James <​james.wei@intel.com> on 2012-04-11
Reviewed by Chris Rogers.

Source/WebCore:

Test: webaudio/panner-equalpower-stereo.html

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

LayoutTests:

  • webaudio/panner-equalpower-stereo-expected.txt: Added.
  • webaudio/panner-equalpower-stereo.html: Copied from LayoutTests/webaudio/panner-equalpower.html.
  • webaudio/panner-equalpower.html:
  • webaudio/resources/audio-testing.js:

(createStereoImpulseBuffer):

  • webaudio/resources/panner-model-testing.js:

(createGraph):
(createTestAndRun):
(equalPowerGain):
(checkResult):

12:23 PM Changeset in webkit [113888] by schenney@chromium.org
  • 4 edits
    1 add in trunk/LayoutTests

[chromium] Need new image baseline for svg/dom/SVGTransformList-basics.xhtml
​https://bugs.webkit.org/show_bug.cgi?id=63036

Unreviewed Chromium test expectations update.

  • platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png:
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:21 PM Changeset in webkit [113887] by arv@chromium.org
  • 6 edits
    4 adds in trunk

StyleElement ownerNode is not cleared correctly
​https://bugs.webkit.org/show_bug.cgi?id=83696

Reviewed by Antti Koivisto.

Source/WebCore:

When the css text changes in such a way that we remove the sheet of a style element or a link[rel=stylesheet]
element we need to ensure that the ownerNode of the sheet is cleared. If we don't do this and there is a
wrapper for the sheet the sheet is kept alive but the ownerNode of the sheet may point to a deleted node.

Tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html

fast/dom/StyleSheet/detached-sheet-owner-node.html

  • dom/StyleElement.cpp:

(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearSheet):
(WebCore):
(WebCore::StyleElement::createSheet):

  • dom/StyleElement.h:

(StyleElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::clearSheet):
(WebCore):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

LayoutTests:

  • fast/dom/StyleSheet/detached-sheet-owner-node-expected.txt: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node-link-expected.txt: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node-link.html: Added.
  • fast/dom/StyleSheet/detached-sheet-owner-node.html: Added.
12:09 PM Changeset in webkit [113886] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Optimize String.split() for 1 character separator
​https://bugs.webkit.org/show_bug.cgi?id=83546

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2012-04-11
Reviewed by Gavin Barraclough.

This patch adds a serie of optimizations to make stringProtoFuncSplit() faster in the common case
where the separator is a single character.

The two main gains are:
-Use of the find() function with a single character instead of doing a full string matching.
-Use of WTF::find() instead of UString::find() to avoid branching on is8Bit() and have a simpler inline

function.

The code is also changed to avoid making unnecessary allocations by converting the 8bit string to 16bits.

This makes String.split() faster by about 13% in that particular case.

  • runtime/StringPrototype.cpp:

(JSC):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

11:35 AM Changeset in webkit [113885] by hyatt@apple.com
  • 9 edits
    3 adds in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=83614
<rdar://problem/11177351>

REGRESSION: Table on wikipedia overlaps float on right hand side.

Revise how auto margins are resolved so that for objects that avoid floats, the available line
width is always used instead of the overall containing block width. computeLogicalWidth now
always properly computes inline margins (based off the object's current logicalTop() position)
and so the code in computeStartPositionDeltaForChildAvoidingFloats that recomputes inline
direction margins can now be removed.

Reviewed by Dan Bernstein.

Added new test in fast/block/float.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::shrinkToAvoidFloats):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=83614

Improve how auto margins are handled on objects that avoid floats. Add a new test covering this
for tables and overflow sections and revise existing results. The CSS2.1 test in particular is
a progression.

Reviewed by Dan Bernstein.

  • fast/block/float/avoiding-float-centered.html: Added.
  • platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
  • platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
11:30 AM Changeset in webkit [113884] by tomz@codeaurora.org
  • 2 edits
    71 adds in trunk/LayoutTests

Unreviewed gardening. Found EFL results.

  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt: Added.
  • platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt: Added.
  • platform/efl/test_expectations.txt:
11:20 AM Changeset in webkit [113883] by enne@google.com
  • 3 edits
    3 adds in trunk

Fix regression where a clip style change did not update layer sizes
​https://bugs.webkit.org/show_bug.cgi?id=82990

Reviewed by Simon Fraser.

Source/WebCore:

After r111456, the size of composited layers also used clip, whereas
it previously had only used overflow. Because of this, when clip
changes on a render layer, it needs to recalculate its layer tree.

Test: compositing/clip-change.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):

LayoutTests:

  • compositing/clip-change-expected.png: Added.
  • compositing/clip-change-expected.txt: Added.
  • compositing/clip-change.html: Added.
11:19 AM April 2012 Meeting edited by jchaffraix@webkit.org
Added a topic + myself to some existing proposals (diff)
11:03 AM Changeset in webkit [113882] by tomz@codeaurora.org
  • 3 edits
    142 adds in trunk/LayoutTests

Expectations update after 81936 and 82734
​https://bugs.webkit.org/show_bug.cgi?id=81936

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-04-11
Reviewed by Adam Barth.

  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
  • platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
  • platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
  • platform/qt/test_expectations.txt:
11:02 AM Changeset in webkit [113881] by Antti Koivisto
  • 13 edits in trunk/Source/WebCore

V8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
​https://bugs.webkit.org/show_bug.cgi?id=83699

Reviewed by Adam Barth.

Call them FooV8Internal instead.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

10:58 AM Changeset in webkit [113880] by jamesr@google.com
  • 7 edits in trunk/Source

[chromium] Add OVERRIDE annotations for cc animation-related interfaces
​https://bugs.webkit.org/show_bug.cgi?id=83650

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCAnimationCurve
  • CCFloatAnimationCurve
  • CCLayerAnimationControllerClient
  • CCTransformAnimationCurve

Source/WebCore:

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCTimingFunction.h:
  • platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:

(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

  • tests/CCAnimationTestCommon.h:
10:50 AM Changeset in webkit [113879] by pdr@google.com
  • 4 edits
    2 adds in trunk

Fix bug where stroke's bounding box was clipped
​https://bugs.webkit.org/show_bug.cgi?id=83651

Reviewed by Dirk Schulze.

Source/WebCore:

This change contains two fixes for one bug:
1) FloatRect::contains contained a nasty mistake where

maxy() < y() was compared instead of maxy() < point.y().

2) RenderSVGShape::strokeContains was depending on its internal

m_strokeAndMarkerBoundingBox instead of calling the virtual
method strokeBoundingBox(). This change switches to using
strokeBoundingBox().

Test: svg/hittest/svg-ellipse-rect-stroke.xhtml

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::contains):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

  • svg/hittest/svg-ellipse-rect-stroke-expected.txt: Added.
  • svg/hittest/svg-ellipse-rect-stroke.xhtml: Added.
10:45 AM Changeset in webkit [113878] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Enable the [Supplemental] IDL on BlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=75413

Reviewed by Rob Buis.

This patch enables the [Supplemental] IDL on BlackBerry by changing the build
flow of BlackBerry as follows.

  • Previous build flow:

foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl;
generate-bindings.pl reads $idl;
generate-bindings.pl generates .h and .cpp files for $idl;

}

  • New build flow (See the discussions in bug 72138 for more details):

preprocess-idls.pl depends on all IDL files;
preprocess-idls.pl reads all IDL files;
preprocess-idls.pl resolves the dependency of [Supplemental=XXXX];
preprocess-idls.pl outputs supplemental_dependency.tmp;
foreach $idl (all IDL files) {

generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
generate-bindings.pl reads $idl;
generate-bindings.pl reads supplemental_dependency.tmp;
generate-bindings.pl generates .h and .cpp files for $idl,

including all attributes in the IDL files that are implementing $idl;

}

Tests: Confirm that build succeeds.

http/tests/websocket/tests/*

  • PlatformBlackBerry.cmake: This change is similar to the change we have done for

UseJSC.cmake and UseV8.cmake (bug 75345).

10:44 AM Changeset in webkit [113877] by commit-queue@webkit.org
  • 12 edits in trunk

Unreviewed, rolling out r113836.
​http://trac.webkit.org/changeset/113836
​https://bugs.webkit.org/show_bug.cgi?id=83705

Broke all the WebKit2 inspector tests (Requested by andersca
on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-11

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(registerWindowClass):

(WebInspector::setTimelineProfilingEnabled):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

10:36 AM Changeset in webkit [113876] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r113872.
​http://trac.webkit.org/changeset/113872
​https://bugs.webkit.org/show_bug.cgi?id=83703

broke chromium win/mac builds (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-11

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(CCHeadsUpDisplay):

10:32 AM Changeset in webkit [113875] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove webkit prefix from Media Source runtime feature name.
​https://bugs.webkit.org/show_bug.cgi?id=83633

Patch by Aaron Colwell <​acolwell@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):

  • html/HTMLMediaElement.idl:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):

10:05 AM Changeset in webkit [113874] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Wider suppression.

Unreviewed.

  • platform/chromium/test_expectations.txt:
9:59 AM Changeset in webkit [113873] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

Single ShareableBitmap revision blacks out WebView on Harmattan
​https://bugs.webkit.org/show_bug.cgi?id=83631

When swizzling is not supported in the driver, we need to initialize the texture as RGBA,
and make sure that the manual swizzling only modifies the sub-image.

Rubber stamped by Kenneth Rohde Christiansen.

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::didReset):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):

9:57 AM Changeset in webkit [113872] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[chromium] When rendering goes idle, do not count that time against frame rate
​https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <​anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
9:21 AM Changeset in webkit [113871] by enne@google.com
  • 27 edits
    2 copies in trunk/Source

[chromium] Draw missing layer tile checkerboards as checkerboards
​https://bugs.webkit.org/show_bug.cgi?id=83241

Reviewed by James Robinson.

Source/WebCore:

For non-Android platforms, draw missing tile checkerboards as actual
checkerboards. Use a shader to do this so that no texture uploads are
needed. This only happens on the non-composited content host to avoid
having unexpected (or transformed and aliased) checkerboards on other
content layers.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setDrawCheckerboardForMissingTiles):
(WebCore::LayerChromium::drawCheckerboardForMissingTiles):
(LayerChromium):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore):
(WebCore::LayerRendererChromium::checkerboardProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::FragmentShaderCheckerboard::FragmentShaderCheckerboard):
(WebCore):
(WebCore::FragmentShaderCheckerboard::init):
(WebCore::FragmentShaderCheckerboard::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(FragmentShaderCheckerboard):
(WebCore::FragmentShaderCheckerboard::alphaLocation):
(WebCore::FragmentShaderCheckerboard::texTransformLocation):
(WebCore::FragmentShaderCheckerboard::frequencyLocation):
(WebCore):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.

(WebCore):
(CCCheckerboardDrawQuad):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toCheckerboardDrawQuad):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(CCLayerImpl):
(WebCore::CCLayerImpl::setDrawCheckerboardForMissingTiles):
(WebCore::CCLayerImpl::drawCheckerboardForMissingTiles):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):

  • platform/graphics/chromium/cc/CCRenderPass.cpp:

(WebCore::CCRenderPass::appendQuadsForLayer):

  • platform/graphics/chromium/cc/CCRenderPass.h:

(CCRenderPass):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(CCScrollbarLayerImpl):

  • platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:

(CCSolidColorLayerImpl):

  • platform/graphics/chromium/cc/CCTextureLayerImpl.h:

(CCTextureLayerImpl):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:

(WebCore::CCTiledLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCTiledLayerImpl.h:

(CCTiledLayerImpl):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(CCVideoLayerImpl):

Source/WebKit/chromium:

Rename usedCheckerboard to hadMissingTile to avoid confusion. Update
tests to not expect SolidColor quads for checkerboards.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

  • tests/CCQuadCullerTest.cpp:

(WebCore::appendQuads):

  • tests/CCSolidColorLayerImplTest.cpp:

(CCLayerTestCommon::TEST):

  • tests/CCTiledLayerImplTest.cpp:

(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):

  • tests/LayerChromiumTest.cpp:
9:14 AM Changeset in webkit [113870] by Carlos Garcia Campos
  • 9 edits
    4 adds in trunk/Source/WebKit2

[GTK] Initial cookies API for WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=82441

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitCookieManager.cpp: Added.

(webkit_cookie_manager_init):
(webkitCookieManagerFinalize):
(webkit_cookie_manager_class_init):
(webkitCookieManagerCreate): Create a new WebKitCookieManager for
the given WKCookieManagerRef.
(webkit_cookie_manager_set_accept_policy): Set the cookie
acceptance policy.
(webkitCookieManagerGetAcceptPolicyCallback): Callback called by
the C API when the cookie acceptance policy has been received.
(webkit_cookie_manager_get_accept_policy): Asynchronously get the
cookie acceptance policy.
(webkit_cookie_manager_get_accept_policy_finish): Finish async
operation started by webkit_cookie_manager_get_accept_policy()
returning the cookie acceptance policy.
(webkitCookieManagerGetDomainsWithCookiesCallback): Callback
called by the C API when the list of hostnames with cookies has
been received.
(webkit_cookie_manager_get_domains_with_cookies): Asynchronously
get the list of domains with cookies.
(webkit_cookie_manager_get_domains_with_cookies_finish): Finish
async operation started by
webkit_cookie_manager_get_domains_with_cookies() returning the
list of domains.
(webkit_cookie_manager_delete_cookies_for_domain): Delete all
cookies for the given domain.
(webkit_cookie_manager_delete_all_cookies): Delete all cookies.

  • UIProcess/API/gtk/WebKitCookieManager.h: Added.
  • UIProcess/API/gtk/WebKitCookieManagerPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_get_cookie_manager): Get the
WebKitCookieManager associated with the web context.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for

WebKitCookieManager.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_cookie_manager_get_type.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
  • UIProcess/API/gtk/tests/TestCookieManager.cpp: Added.

(testCookieManagerAcceptPolicy):
(testCookieManagerDeleteCookies):
(serverCallback):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitCookieManager.h.
9:09 AM Changeset in webkit [113869] by Csaba Osztrogonác
  • 4 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening after r113738.

  • platform/qt/Skipped: Unskip a non-existing test.
  • platform/qt/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/qt/fast/multicol/cell-shrinkback-expected.txt: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.png:
  • platform/qt/fast/multicol/table-vertical-align-expected.txt:
9:05 AM Changeset in webkit [113868] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[BlackBerry] Update to the thread-safe GuardedPointer API
​https://bugs.webkit.org/show_bug.cgi?id=83603

Patch by Joe Mason <​jmason@rim.com> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 134894
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker. Use GuardedPointerDeleter
to delete LayerCompositingThread to avoid a deadlock.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::~CookieDatabaseBackingStore):

  • platform/blackberry/CookieManager.h:
  • platform/graphics/blackberry/LayerCompositingThread.cpp:
  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):
(WTF::::deref):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):

Source/WebKit/blackberry:

RIM PR: 134984
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStore::~BackingStore):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPage::destroy):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

9:03 AM Changeset in webkit [113867] by rakuco@webkit.org
  • 2 edits
    735 adds in trunk/LayoutTests

[EFL][DRT] SVG dynamic-updates rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=83689

Unreviewed, EFL gardening.

Bug 83562 landed EFL fixes for SVG support from JavaScript.
This allows us to unskip the dynamic-updates/* family of SVG tests.
All results were visually inspected and produced PASS results.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-04-11

  • platform/efl/Skipped: dynamic-updates removed.
  • platform/efl/svg/dynamic-updates/: New baselines.
8:53 AM Changeset in webkit [113866] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the build on OpenGL ES2 platforms

Unreviewed build fix.

No new tests needed.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):
Fix typo in TEXMAP_OPENGL_ES_2 define.

8:49 AM Changeset in webkit [113865] by fischman@chromium.org
  • 6 edits in trunk/Source

Remove unused WebVideoFrame::Format values
​https://bugs.webkit.org/show_bug.cgi?id=83625

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::convertVFCFormatToGC3DFormat):

Source/WebKit/chromium:

  • public/WebVideoFrame.h:

(WebKit):

  • src/AssertMatchingEnums.cpp:
8:40 AM Changeset in webkit [113864] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Follow up to r113863: fix chromium inspector interactive test harness.

  • src/js/Tests.js:
8:29 AM Changeset in webkit [113863] by pfeldman@chromium.org
  • 70 edits
    1 add in trunk

Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 1)
​https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

Meta bug: ​https://bugs.webkit.org/show_bug.cgi?id=61363.
In this step, NetworkRequest is introduced. It temporarily inherits from
the Resource, but all the call sites are now referring to it as to request.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/ApplicationCacheItemsView.js:

(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):

  • inspector/front-end/AuditLauncherView.js:

(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.getDomainToResourcesMap):
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
(WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
(WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):

  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):

  • inspector/front-end/ConsoleMessage.js:
  • inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleDispatcher.prototype.messageAdded):

  • inspector/front-end/ContentProviders.js:

(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):

  • inspector/front-end/DebuggerPresentationModel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):

  • inspector/front-end/HAREntry.js:

(WebInspector.HAREntry):
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype._buildTimings):
(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HAREntry.prototype._buildCookie):
(WebInspector.HAREntry.prototype._interval):
(WebInspector.HAREntry.prototype.get requestBodySize):
(WebInspector.HAREntry.prototype.get responseBodySize):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertResource):

  • inspector/front-end/NetworkItemView.js:

(WebInspector.NetworkItemView):

  • inspector/front-end/NetworkLog.js:

(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get requests):
(WebInspector.NetworkLog.prototype.pageLoadForRequest):
(WebInspector.NetworkLog.prototype._onMainFrameNavigated):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.PageLoad):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.inflightRequestForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._finishNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._initializeView):
(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype._requestGridNode):
(WebInspector.NetworkLogView.prototype._createRequestGridNode):
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.get requests):
(WebInspector.NetworkLogView.prototype.requestById):
(WebInspector.NetworkLogView.prototype._onRequestStarted):
(WebInspector.NetworkLogView.prototype._appendRequest):
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._refreshRequest):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkLogView.prototype.get _setLargerRequests):
(WebInspector.NetworkLogView.prototype._getPopoverAnchor):
(WebInspector.NetworkLogView.prototype._showPopover):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._copyAll):
(WebInspector.NetworkLogView.prototype._copyRequest):
(WebInspector.NetworkLogView.prototype._copyLocation):
(WebInspector.NetworkLogView.prototype._copyRequestHeaders):
(WebInspector.NetworkLogView.prototype._copyResponseHeaders):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):
(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkLogView.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype.handleShortcut):
(WebInspector.NetworkPanel.prototype.get requests):
(WebInspector.NetworkPanel.prototype.requestById):
(WebInspector.NetworkPanel.prototype._requestByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype._onViewCleared):
(WebInspector.NetworkPanel.prototype._onRequestSelected):
(WebInspector.NetworkPanel.prototype._showRequest):
(WebInspector.NetworkPanel.prototype._closeVisibleRequest):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphPercentages):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundaries):
(WebInspector.NetworkTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.select):
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype._fileName):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTimeCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
(WebInspector.NetworkDataGridNode.NameComparator):
(WebInspector.NetworkDataGridNode.SizeComparator):
(WebInspector.NetworkDataGridNode.InitiatorComparator):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):

  • inspector/front-end/NetworkRequest.js: Added.

(WebInspector.NetworkRequest):

  • inspector/front-end/RawSourceCode.js:

(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._requestFinished):
(WebInspector.RawSourceCode.prototype._createContentProvider):

  • inspector/front-end/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set finished):
(WebInspector.Resource.prototype.set timing):
(WebInspector.Resource.prototype.set requestHeaders):
(WebInspector.Resource.prototype.set requestHeadersText):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype.set responseHeadersText):
(WebInspector.Resource.prototype.requestContent):

  • inspector/front-end/ResourceCookiesView.js:

(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.get _gotCookies):
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

  • inspector/front-end/ResourceHeadersView.js:

(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshQueryString):
(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
(WebInspector.ResourceHeadersView.prototype._refreshFormData):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.addScript):

  • inspector/front-end/ResourceTimingView.js:

(WebInspector.ResourceTimingView):
(WebInspector.ResourceTimingView.prototype.wasShown):
(WebInspector.ResourceTimingView.prototype._refresh):
(WebInspector.ResourceTimingView.createTimingTable):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdated):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._addRequest):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(WebInspector.networkRequestById):

  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js:

(WebInspector.networkRequestById):
(WebInspector.openRequestInNetworkPanel):

Tools: Web Inspector: Disabling Inspector causes build failure on Windows
​https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 1)
​https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

  • http/tests/inspector/network-preflight-options.html:
  • http/tests/inspector/network-test.js:
  • http/tests/inspector/network/async-xhr-json-mime-type.html:
  • http/tests/inspector/network/download.html:
  • http/tests/inspector/network/network-cachedresources-with-same-urls.html:
  • http/tests/inspector/network/network-content-replacement-embed.html:
  • http/tests/inspector/network/network-content-replacement-xhr.html:
  • http/tests/inspector/network/network-cyrillic-xhr.html:
  • http/tests/inspector/network/network-disable-cache-memory.html:
  • http/tests/inspector/network/network-disable-cache-xhrs.html:
  • http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
  • http/tests/inspector/network/network-embed.html:
  • http/tests/inspector/network/network-empty-xhr.html:
  • http/tests/inspector/network/network-iframe-load-and-delete.html:
  • http/tests/inspector/network/network-initiator-from-console.html:
  • http/tests/inspector/network/network-initiator.html:
  • http/tests/inspector/network/network-request-revision-content.html:
  • http/tests/inspector/network/network-shared-worker.html:
  • http/tests/inspector/network/network-sidebar-width.html:
  • http/tests/inspector/network/network-size-chunked.html:
  • http/tests/inspector/network/network-size-sync.html:
  • http/tests/inspector/network/network-size.html:
  • http/tests/inspector/network/network-timing.html:
  • http/tests/inspector/network/network-worker.html:
  • http/tests/inspector/network/network-xhr-async.html:
  • http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
  • http/tests/inspector/network/network-xhr-sync.html:
  • http/tests/inspector/network/ping.html:
  • http/tests/inspector/network/x-frame-options-deny.html:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-har-headers.html:
  • http/tests/inspector/resource-har-pages.html:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resources-test.js:

(initialize_ResourceTest.InspectorTest.requestURLComparer):

  • inspector/debugger/raw-source-code.html:
  • inspector/debugger/source-frame.html:
  • inspector/network-status-non-http.html:
8:20 AM Changeset in webkit [113862] by arko@motorola.com
  • 3 edits in trunk/Source/WebCore

Microdata: Implement cache mechanism for HTMLPropertiesCollection.
​https://bugs.webkit.org/show_bug.cgi?id=80490

Reviewed by Ryosuke Niwa.

Implemented caching mechanism for HTMLPropertiesCollection.
propertyCache - contains microdata item properties.
itemRefElements - contains sorted microdata item and itemref elements.
propertyNames - contains microdata property names of the elements in the collection.
itemRefElementPosition - store the current position of itemRefElements.
hasItemRefElements - set to ture once we have sorted microdata item and itemref elements list i.e, itemRefElements.
Cache is invalidated only when dom tree modified. Whenever any query is made on HTMLPropertiesCollection,
result is returned from the cache. Earliar we used to calculate properties node list every time a query is made.

  • html/HTMLPropertiesCollection.cpp:

(WebCore):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCacheIfNeeded):
(WebCore::HTMLPropertiesCollection::updateRefElements): Appends microdata item element and elements which
are added through itemref attribute in itemRefElements (in tree order).
(WebCore::nextNodeWithProperty):
(WebCore::HTMLPropertiesCollection::itemAfter): Takes parent base and previous item property as argument.
Finds the next item property in base.
(WebCore::HTMLPropertiesCollection::calcLength): Calculates the length of properties collection if length
is not available in the cache.
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::firstProperty): Returns the first property in the collection.
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties): Finds microdata item properties in the base element.
Appends the properties in propertyCache and property names in propertyNames.
(WebCore::HTMLPropertiesCollection::updateNameCache): It updates the propertyCache and propertyNames if hasNameCache is false.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

7:53 AM Changeset in webkit [113861] by jocelyn.turcotte@nokia.com
  • 7 edits
    3 adds in trunk

[Qt] InspectorServer: Add an API level auto test
​https://bugs.webkit.org/show_bug.cgi?id=83594

Reviewed by Kenneth Rohde Christiansen.

.:

  • Source/tests.pri:

Source/WebKit2:

This tests InspectorServer and WebSocketServer.

  • UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Added.
  • UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Added.

(tst_InspectorServer):
(tst_InspectorServer::tst_InspectorServer):
(tst_InspectorServer::prepareWebViewComponent):
(tst_InspectorServer::newWebView):
(tst_InspectorServer::init):
(tst_InspectorServer::cleanup):
(tst_InspectorServer::webView):
(tst_InspectorServer::fetchPageList):
(tst_InspectorServer::testPageList): This tests that pages with developerExtrasEnabled appear available for inspection.
(tst_InspectorServer::testRemoteDebuggingMessage): This tests a web socket connection using a raw inspector command.
(tst_InspectorServer::openRemoteDebuggingSession): This tests the whole pipeline by starting a remote inspection session.

  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::prepareWebViewComponent):

  • UIProcess/API/qt/tests/tests.pri:
  • UIProcess/API/qt/tests/util.cpp:

(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):

  • UIProcess/API/qt/tests/util.h:

(LoadStartedCatcher):

7:52 AM Changeset in webkit [113860] by jocelyn.turcotte@nokia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] InspectorServer: Improve the JSON page list's parameter names
​https://bugs.webkit.org/show_bug.cgi?id=83592

Reviewed by Simon Hausmann.

  • Add "id" that would be needed to build the URL when using local front-end resources (and will be used by tests)
  • Rename description to "title", the description contains both the title and URL on the final list
  • Rename inspectorLocation to "inspectorUrl" to match with the url parameter.
  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::WebInspectorServer::buildPageList):

  • qt/Resources/inspectorPageIndex.html:
7:50 AM Changeset in webkit [113859] by jocelyn.turcotte@nokia.com
  • 8 edits in trunk/Source

[Qt] Fix issues when using the WebView as ShaderEffectSource
​https://bugs.webkit.org/show_bug.cgi?id=83587

Reviewed by Noam Rosenthal.

Source/WebCore:

  • Make sure that the bound frame buffer is preserved instead of binding to the default one
  • Accept a "mirrored" flag in beginPainting that we're applying on the projection matrix just as with internal FBOs

The "flip" logic in createProjectionMatrix has been reversed and renamed to
mirrored so that FBO rendering is considered the special case and not the
other way around just like within Qt.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::beginPainting):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::createProjectionMatrix):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):

  • platform/graphics/texmap/TextureMapperGL.h:

Source/WebKit2:

Qt is going to mirror the projection matrix when the shader effect source
is grabbed. Detect that the matrix is mirrored and pass on this information
to TextureMapper so that it can do the same.

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::render):

7:49 AM Changeset in webkit [113858] by jocelyn.turcotte@nokia.com
  • 9 edits in trunk/Source/WebKit2

[Qt] Remove unnecessary rendering code
​https://bugs.webkit.org/show_bug.cgi?id=83591

Reviewed by Noam Rosenthal.

  • Remove code that isn't needed since the introduction of WebLayerTreeRenderer
  • Remove TextureMapper::bindSurface(0) calls following beginPainting, which calls it itself.
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::paint):

  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:

(DrawingAreaProxyImpl):

  • UIProcess/LayerTreeHostProxy.cpp:
  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):

7:00 AM Changeset in webkit [113857] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

svg/text/svg-zoom-large-value.xhtml ASSERTs on Chromium Linux Debug
​https://bugs.webkit.org/show_bug.cgi?id=63400

Unreviewed Chromium test expectation removal.

  • platform/chromium/test_expectations.txt:
6:41 AM Changeset in webkit [113856] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
​https://bugs.webkit.org/show_bug.cgi?id=83484

Unreviewed attempted build fix.

  • dom/ContainerNodeAlgorithms.h: Adding Document.h include.
6:31 AM Changeset in webkit [113855] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip a new test because of missing layoutTestController.setBackingScaleFactor() implemetation.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-04-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
6:29 AM Changeset in webkit [113854] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary assignments from CSSParser::parseLinearGradient().
​https://bugs.webkit.org/show_bug.cgi?id=83661

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseLinearGradient):

6:23 AM Changeset in webkit [113853] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Tools

[Qt][WK2] Manage graphics buffers in the web process
​https://bugs.webkit.org/show_bug.cgi?id=78675

Make graphics surface available only for Qt 5, attempting to fix
the Qt-mac build.

Unreviewed build fix.

  • qmake/mkspecs/features/features.prf:
6:18 AM Changeset in webkit [113852] by schenney@chromium.org
  • 2 edits in trunk/Source/WebCore

Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
​https://bugs.webkit.org/show_bug.cgi?id=83484

Reviewed by Hajime Morita.

The ContainerNode::removeAllChildren method does fast and dirty node removal.
As compared to ContainerNode::removeChildren, it does not include the
method to adopt the removed child node into the root document's TreeScope.
Rather, it leaves the existing TreeScope in place. However, the existing
TreeScope may be removed, causing a crash when something prevents the child
node from being deleted immediately. The fix is to modify the code in
ContainerNodeAlgorithms to do the TreeScope adoption.

Could not reproduce crash in layout test.

  • dom/ContainerNodeAlgorithms.h:

(Private):
(WebCore::Private::NodeRemovalDispatcher::dispatch):
(WebCore::Private::addChildNodesToDeletionQueue):

5:52 AM Changeset in webkit [113851] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: showing summary view is very slow on a snapshot with thousands of constructors
​https://bugs.webkit.org/show_bug.cgi?id=83682

Node content is created only when the node becomes visible in the corresponding view.
This saves a lot of time when openning summary/comparison view of a snapshot
with lots of different classes.

Reviewed by Pavel Feldman.

  • inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):

  • inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view .data-grid tr:empty):

5:24 AM WebKitGtkLayoutTests edited by Philippe Normand
(diff)
5:24 AM Changeset in webkit [113850] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, GTK NRWT follow-up fix after r113849.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.

4:57 AM Changeset in webkit [113849] by commit-queue@webkit.org
  • 8 edits in trunk

[GTK] media/event-attributes.html fails
​https://bugs.webkit.org/show_bug.cgi?id=71662

Patch by Simon Pena <Simon Pena> on 2012-04-11
Reviewed by Philippe Normand.

Source/WebCore:

In MediaPlayerPrivateGStreamer::didEnd, when EOS is reached, don't
synchronize position and duration on regular playback. That is:
synchronize it (and fire the durationChange signal) only on reverse
playback.

This change makes media/event-attributes.html pass. It was
previously failing because an additional durationChange signal was
emitted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Avoid

sending durationChange signal on regular playback.

Tools:

PulseAudio's module "module-stream-restore" allows saving the volume
of a stream, restoring it the next time it runs.
This affects the tests, since DumpRenderTree's volume settings are
saved between test runs, and tests relying on specific volume values
would miss some volumeChange events (or get additional ones).

This patch hooks on the existing GtkPort setup_test_run method and
creates a new clean_up_test_run method, so PulseAudio's module is
unloaded (if found) before running the tests, and restored (if it
was there previously) after they finished, ensuring the tests run in
the right environment.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._clean_up_run): Invoke the port implementation of
clean_up_test_run.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.clean_up_test_run): Add an empty implementation of
clean_up_test_run.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort._unload_pulseaudio_module): Unloads the offending
pulseaudio module, if found.
(GtkPort):
(GtkPort._restore_pulseaudio_module): Restores the offending
pulseaudio module, if it was there previously.
(GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
(GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.

LayoutTests:

Unskip tests media/video-seek-past-end-playing and
media/sources-fallback-codecs, which no longer fail, and
media/event-attributes, which is fixed with this patch.

  • platform/gtk/Skipped: Unskip media/video-seek-past-end-playing,

media/sources-fallback-codecs and media/event-attributes

4:23 AM Changeset in webkit [113848] by abecsi@webkit.org
  • 7 edits in trunk

Fix the build with gcc 4.7.0
​https://bugs.webkit.org/show_bug.cgi?id=83584

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests needed.

  • Target.pri: Disable Werror on the ANGLE code since it has several recurring issues

because older versions of flex (<2.5.35) and bison (<2.5) generate code which
triggers warnings. This generated code is committed on each version update of ANGLE,
and it is very likely that the code is generated with older versions of the mentioned
tools.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::createForJSConstructor): Fails because of -Werror=extra

  • platform/graphics/TiledBackingStoreClient.h: Fails because -Werror=delete-non-virtual-dtor,

gcc requires classes which have virtual methods to have a virtual destructor, if their instances
or the instances of their subclasses are deleted.
(WebCore::TiledBackingStoreClient::~TiledBackingStoreClient):

  • platform/graphics/texmap/TextureMapperPlatformLayer.h: Ditto.

(WebCore::TextureMapperPlatformLayer::~TextureMapperPlatformLayer):

Tools:

  • qmake/mkspecs/features/unix/default_post.prf:

The -fuse-ld=gold option is not supported with upstream gcc.

3:50 AM Changeset in webkit [113847] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark two a11y tests as flaky.
3:06 AM Changeset in webkit [113846] by tkent@chromium.org
  • 4 edits
    2 adds in trunk/Source/WebCore

[V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClosePopup() to JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=83561

Reviewed by Adam Barth.

Add ScriptController::installFunctionsForPagePopup(), which add
window.setValueAndClosePopup() for JavaScript code in PagePopup
environment, and the function calls
WebCore::PagePopupClient::setValueAndClosePopup().

This patch introduces Supplement<DOMWindow> object to hold a
PagePopupClient object. It makes keeping a PagePopupClient easier.

  • WebCore.gypi: Add DOMWindowPagePopup.{cpp,h}
  • bindings/v8/ScriptController.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::ScriptController::installFunctionsForPagePopup):

  • bindings/v8/ScriptController.h:

(ScriptController): Add installFunctionsForPagePopup().

  • page/DOMWindowPagePopup.cpp: Added.

(WebCore::DOMWindowPagePopup::DOMWindowPagePopup):
(WebCore::DOMWindowPagePopup::supplementName):
Returns "DOMWindowPagePopup" as a key of this Supplement<DOMWindow>.
(WebCore::DOMWindowPagePopup::setValueAndClosePopup):
Gets a DOMWindowPagePopup from the window, then calls PagePopupClient::setValueAndClosePopup().
(WebCore::DOMWindowPagePopup::install):
On-demand creation of DOMWindowPagePopup doesn't work because it
must have a PagePopupClient object. We need to install
DOMWindowPagePopup explicitly.

  • page/DOMWindowPagePopup.h: Added.
3:00 AM Changeset in webkit [113845] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
​https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at ​http://www.w3.org/TR/2011/WD-battery-status-20111129/.
​https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
​https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
2:44 AM Changeset in webkit [113844] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
​https://bugs.webkit.org/show_bug.cgi?id=83574

Reviewed by Daniel Bates.

This new macro generates forwarding headers with absolute paths to the original files.
It accepts a list of files and/or a list of directories as input.

  • Source/cmake/WebKitMacros.cmake:
2:43 AM Changeset in webkit [113843] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/test_expectations.txt: Mark an editing test as flaky.
2:41 AM Changeset in webkit [113842] by mihnea@adobe.com
  • 16 edits
    2 adds in trunk/Source/WebCore

[CSS Regions]Add helper class for flow threads info in RenderView
​https://bugs.webkit.org/show_bug.cgi?id=83464

Reviewed by David Hyatt.

This patch creates a new helper class FlowThreadController that will accommodate all the flow thread
related info from RenderView and moves all the data structures/methods from RenderView into this new class.
There is only one FlowThreadController object per RenderView and it can be retrieved using flowThreadController() method from RenderView.
The flow thread controller object is owned by the RenderView and it is created on demand only if there are flowing
threads in the page.

Since there is no change in functionality, there are no new tests added.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::webkitGetFlowByName):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

  • rendering/FlowThreadController.cpp: Added.

(WebCore):
(WebCore::FlowThreadController::create):
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::~FlowThreadController):
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):

  • rendering/FlowThreadController.h: Added.

(WebCore):
(FlowThreadController):
(WebCore::FlowThreadController::currentRenderFlowThread):
(WebCore::FlowThreadController::setCurrentRenderFlowThread):
(WebCore::FlowThreadController::isRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::renderNamedFlowThreadList):
(WebCore::FlowThreadController::hasRenderNamedFlowThreads):

  • rendering/RenderFlowThread.cpp:

(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderNamedFlowThreads):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::flowThreadController):

  • rendering/RenderView.h:

(WebCore):
(RenderView):

2:29 AM Changeset in webkit [113841] by commit-queue@webkit.org
  • 3 edits
    119 adds in trunk/LayoutTests

[EFL][DRT] SVG Filters rebaseline
​https://bugs.webkit.org/show_bug.cgi?id=83673

Unreviewed, EFL rebaseline.

Bug 83562 fixed programmatically creating filters from JS, this
allows us to unskip a lot of SVG tests. This is part two.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-04-11

  • platform/efl/Skipped: Removed svg/filters/*.
  • platform/efl/svg/filters/: New baselines.
  • platform/efl/test_expectations.txt: Added one dropShadow filter failure.
2:16 AM Changeset in webkit [113840] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Device Metrics] Implement dimension swapping
​https://bugs.webkit.org/show_bug.cgi?id=83676

The change adds a "Swap dimensions" button that swaps the emulated device dimensions to
mimic the device rotation (give that the ORIENTATION_EVENTS feature is disabled in Chromium).

Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.swapDimensionsClicked):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

1:54 AM Changeset in webkit [113839] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Refactor PerfTestRunner to include file extensions in test names
​https://bugs.webkit.org/show_bug.cgi?id=83677

Reviewed by Hajime Morita.

Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', , test_name)" here.
(PerfTestsRunner._run_single_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

1:52 AM Changeset in webkit [113838] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix compiler warnings for generated CalendarPicker.cpp with VC++
​https://bugs.webkit.org/show_bug.cgi?id=83672

Reviewed by Kentaro Hara.

  • make-file-arrays.py:

(main): Do not generate literal integers larger than 127 for
members of char arrays. Use '\xHH' instead.

1:49 AM Changeset in webkit [113837] by Philippe Normand
  • 8 edits
    75 adds in trunk/LayoutTests

Unreviewed, GTK rebaseline and baselines for new tests.

  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
  • platform/gtk/fast/table/cell-pref-width-invalidation-expected.txt:
  • platform/gtk/fast/text/text-shadow-no-default-color-expected.txt: Added.
  • platform/gtk/ietestcenter/: Added.
  • platform/gtk/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2509-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug34176-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
1:49 AM Changeset in webkit [113836] by commit-queue@webkit.org
  • 12 edits in trunk

Web Inspector: Disabling Inspector causes build failure on Windows
​https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <​vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

Source/WebKit/win:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebInspector.cpp:
  • WebNodeHighlight.cpp:

(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):

  • WebNodeHighlight.h:

(WebNodeHighlight):

  • WebView.cpp:

(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):

  • WebView.h:

(WebView):

Tools:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

1:43 AM UsingGitWithWebKit edited by dominik.rottsches@intel.com
link to using github page (diff)
1:38 AM Changeset in webkit [113835] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: fix category -> type refactoring implications.
​https://bugs.webkit.org/show_bug.cgi?id=83680

Reviewed by Yury Semikhatsky.

We are now using type identifiers (singulars) as opposed to category identifier (plurals) in the style.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems.createFilterElement):
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._showCategory):
(WebInspector.NetworkLogView.prototype._hideCategory):
(WebInspector.NetworkLogView.prototype._filter):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.FrameResourceTreeElement):
(WebInspector.ResourceRevisionTreeElement):

  • inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid .network-type-script .icon):
(.network-log-grid.data-grid.small .network-type-script .icon):
(.network-log-grid.data-grid .network-type-document .icon):
(.network-log-grid.data-grid.small .network-type-document .icon):
(.network-log-grid.data-grid .network-type-stylesheet .icon):
(.network-log-grid.data-grid.small .network-type-stylesheet .icon):
(.network-log-grid.data-grid .network-type-image .icon):
(.network-log-grid.data-grid.small .network-type-image .icon):
(.network-type-document .network-graph-bar):
(.network-type-document.resource-cached .network-graph-bar):
(.network-type-stylesheet .network-graph-bar):
(.network-type-stylesheet.resource-cached .network-graph-bar):
(.network-type-image .network-graph-bar):
(.network-type-image.resource-cached .network-graph-bar):
(.network-type-font .network-graph-bar):
(.network-type-font.resource-cached .network-graph-bar):
(.network-type-script .network-graph-bar):
(.network-type-script.resource-cached .network-graph-bar):
(.network-type-xhr .network-graph-bar):
(.network-type-xhr.resource-cached .network-graph-bar):
(.network-type-websocket .network-graph-bar):
(.network-type-websocket.resource-cached .network-graph-bar):
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other):

  • inspector/front-end/resourcesPanel.css:

(.resource-sidebar-tree-item.resources-type-image .icon):
(.resources-type-image .image-resource-icon-preview):
(.children.small .resource-sidebar-tree-item.resources-type-image .icon):
(.children.small .resources-type-image .image-resource-icon-preview):
(.resource-sidebar-tree-item.resources-type-document .icon):
(.children.small .resource-sidebar-tree-item.resources-type-document .icon):
(.resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.children.small .resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.resource-sidebar-tree-item.resources-type-font .icon):
(.children.small .resource-sidebar-tree-item.resources-type-font .icon):
(.resource-sidebar-tree-item.resources-type-script .icon):
(.children.small .resource-sidebar-tree-item.resources-type-script .icon):
(.resource-sidebar-tree-item.resources-type-xhr .icon):
(.children.small .resource-sidebar-tree-item.resources-type-xhr .icon):

1:29 AM Changeset in webkit [113834] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

  • platform/gtk/Skipped: Skip failing ref test
  • platform/gtk/test_expectations.txt: Mark two tests as crashing

and unskip tests needing rebaseline.

12:02 AM Changeset in webkit [113833] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
​https://bugs.webkit.org/show_bug.cgi?id=83657

Reviewed by Martin Robinson.

Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
because that is a given.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

12:00 AM Changeset in webkit [113832] by Philippe Normand
  • 5 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline after r113756.

  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:

Apr 10, 2012:

11:46 PM Changeset in webkit [113831] by Carlos Garcia Campos
  • 6 edits in trunk/Source

Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Ad missing files.

Source/WebCore:

  • GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

  • GNUmakefile.am: Add missing header file.
11:26 PM Changeset in webkit [113830] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Signedness issue with code informing v8 of PatternSkia memory use
​https://bugs.webkit.org/show_bug.cgi?id=83642

Reviewed by James Robinson.

The unary negation of size_t is still a size_t, so clamp and cast to
an int instead when adjusting v8 memory limits.

  • platform/graphics/Pattern.h:

(Pattern):

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):

10:39 PM Changeset in webkit [113829] by tkent@chromium.org
  • 3 edits in trunk/Tools

Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.

  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
10:35 PM Changeset in webkit [113828] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[chromium] ImageBuffer minor style fix: remove compound declaration
​https://bugs.webkit.org/show_bug.cgi?id=83660

Reviewed by Kent Tamura.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

10:23 PM Changeset in webkit [113827] by fischman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS to last-known good revision
​https://bugs.webkit.org/show_bug.cgi?id=83652

Unreviewed, just a DEPS roll (131469:131684)

  • DEPS:
9:58 PM Changeset in webkit [113826] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Add gesture event enums for long-press and pinch
​https://bugs.webkit.org/show_bug.cgi?id=83640

Patch by Alexandre Elias <​aelias@google.com> on 2012-04-10
Reviewed by James Robinson.

Add new enum values GestureLongPress and GesturePinchBegin/End/Update,
along with no-op default handling.

Source/WebCore:

No new tests. (No-op change.)

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:
  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::gestureEvent):

9:48 PM Changeset in webkit [113825] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to intruding float not removed from next siblings.
​https://bugs.webkit.org/show_bug.cgi?id=83301

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html

markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.

For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

LayoutTests:

  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
9:35 PM April 2012 Meeting edited by morrita@google.com
(diff)
9:19 PM Changeset in webkit [113824] by mikelawther@chromium.org
  • 2 edits in trunk/Source/WebCore

Prevent fallthrough to keep static analysis tools happy
​https://bugs.webkit.org/show_bug.cgi?id=83639

Reviewed by Darin Adler.

No new tests - no new behaviour.

  • css/LengthFunctions.cpp:

(WebCore::valueForLength):

9:15 PM Changeset in webkit [113823] by jchaffraix@webkit.org
  • 10 edits in trunk/Source/WebCore

Don't expose the intrinsic padding concept to the code outside rendering
​https://bugs.webkit.org/show_bug.cgi?id=83380

Reviewed by Eric Seidel.

No new tests, refactoring only.

The current code would expose the concept of intrinsic padding to every
object holding a renderer through an enum on the padding* functions.

This was very fragile as only the class using intrinsic padding should know about
its very existence, the rest of the code shouldn't have to special case for it.
There is one exception: the getComputedStyle logic needs the opposite value
rendering needs. To handle that, we make it more explicit what returns the
computed values vs the rendering values.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Updated those functions to use the new computedCSS* functions below.

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::computedCSSContentBoxRect):
This is the computed content box. It includes the intrinsic padding.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Renamed from padding* as they returned the CSS computed values.

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):
Killed the enum paddingOptions!

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
All padding* functions call the computedCSSPadding* ones above.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
Updated these functions after the renaming.

  • rendering/RenderTableCell.h:

(RenderTableCell):
Updated the functions signature and decorated them with OVERRIDE.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):
Updated these functions after the renaming.

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore::RenderMathMLSquareRoot::paint):
Updated this function to use computeCSSContentBoxRect.location().

8:35 PM Changeset in webkit [113822] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

TextureMapperGL.cpp breaks build with OpenGL ES
​https://bugs.webkit.org/show_bug.cgi?id=83622

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2012-04-10
Reviewed by Noam Rosenthal.

Add !defined(TEXMAP_OPENGL_ES_2) guards as suggested by
No'am Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

8:33 PM Changeset in webkit [113821] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Calendar Picker: Initialize CalendarPickerElement::m_popup
​https://bugs.webkit.org/show_bug.cgi?id=83656

Reviewed by Hajime Morita.

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::CalendarPickerElement): Set 0 to m_popup.

8:26 PM Changeset in webkit [113820] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

CodeGeneratorV8 cleanup: eliminate redundant calls to IsRefPtrType
​https://bugs.webkit.org/show_bug.cgi?id=83623

Reviewed by Adam Barth.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader): Always emit toV8(PassRefPtr), as all wrapped types are RefCounted.
(GenerateImplementation): Always emit code for derefObject, as all wrapped types are RefCounted.

8:02 PM Changeset in webkit [113819] by jamesr@google.com
  • 13 edits in trunk/Source

[chromium] Add OVERRIDE annotations for cc tree host and proxy interfaces
​https://bugs.webkit.org/show_bug.cgi?id=83653

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCLayerTreeHostClient
  • CCLayerTreeHostImplClient
  • CCProxy
  • LayerRendererChromiumClient

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
  • platform/graphics/chromium/cc/CCProxy.h:

(WebCore):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • src/WebLayerTreeViewImpl.h:

(WebLayerTreeViewImpl):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/FakeCCLayerTreeHostClient.h:
  • tests/LayerRendererChromiumTest.cpp:
7:59 PM Changeset in webkit [113818] by dgrogan@chromium.org
  • 4 edits
    3 adds in trunk

Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
​https://bugs.webkit.org/show_bug.cgi?id=83104

Source/WebCore:

PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.

The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop() <-- problem

This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8

We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.

It's possible that there's a lower layer fix available in V8 or the
bindings.

Reviewed by David Levin.

Test: storage/indexeddb/pending-version-change-on-exit.html

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.

LayoutTests:

Reviewed by David Levin.

  • storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
  • storage/indexeddb/pending-version-change-on-exit.html: Added.
  • storage/indexeddb/resources/pending-version-change-on-exit.js: Added.

(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

7:57 PM Changeset in webkit [113817] by adamk@chromium.org
  • 6 edits
    2 adds in trunk

Break the association between form controls and their owner when the owner leaves the tree
​https://bugs.webkit.org/show_bug.cgi?id=81420

Reviewed by Kent Tamura.

Source/WebCore:

When parsing malformed markup, it's possible for a form and a
form-associated element to not be in an ancestor/descendant relationship.
When that form is later removed from the tree, the relationship needs to be updated.

Test: fast/forms/parser-associated-form-removal.html

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::formRemovedFromTree): New method called when
by the form when it's being removed: handles either resetting the
owner or storing a bit to optimize away a second walk up the tree.

  • html/FormAssociatedElement.h:

(FormAssociatedElement):

  • html/HTMLFormElement.cpp:

(WebCore::findRoot): Simple helper method copied from FormAssociatedElement (this should probably live elsewhere).
(WebCore::HTMLFormElement::removedFromTree): Override removedFromTree to notify associated elements of the removal.

  • html/HTMLFormElement.h:

(HTMLFormElement):

LayoutTests:

  • fast/forms/parser-associated-form-removal-expected.txt: Added.
  • fast/forms/parser-associated-form-removal.html: Added.
7:55 PM Changeset in webkit [113816] by jamesr@google.com
  • 10 edits in trunk/Source

[chromium] Add OVERRIDE annotations for cc scheduler-related client interfaces
​https://bugs.webkit.org/show_bug.cgi?id=83646

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:

  • CCFrameRateControllerClient
  • CCSchedulerClient
  • CCTimeSource
  • CCTimeSourceClient
  • CCTimerClient

Source/WebCore:

  • platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
  • platform/graphics/chromium/cc/CCFrameRateController.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
  • platform/graphics/chromium/cc/CCScheduler.h:

(CCScheduler):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:
  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

Source/WebKit/chromium:

  • tests/CCSchedulerTest.cpp:
  • tests/CCSchedulerTestCommon.h:
7:51 PM Changeset in webkit [113815] by commit-queue@webkit.org
  • 1 edit
    1 add
    11 deletes in trunk/LayoutTests

[CSS Regions] Convert a fast/regions pixel test to a ref test
​https://bugs.webkit.org/show_bug.cgi?id=83529

Patch by David Alcala <​dalcala@adobe.com> on 2012-04-10
Reviewed by Ryosuke Niwa.

  • fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.html: Added.
  • platform/chromium-linux/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
  • platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
7:49 PM Changeset in webkit [113814] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Attempt to fix the Windows build.

7:38 PM Changeset in webkit [113813] by dpranke@chromium.org
  • 5 edits in trunk/Tools

If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
​https://bugs.webkit.org/show_bug.cgi?id=82799

Reviewed by Ojan Vafai.

The tests we were skipping in _mark_interrupted_tests_as_skipped
had incorrectly-constructed TestResults, and so they were not
being treated as failures. The JSON generator doesn't record
tests that are passed or skiped in incremental_results, so you
couldn't tell these tests were being skipped at all.

This change changes _mark_interrupted_tests_as_skipped() to
treat the skipped tests as failures; this is arguably still
incorrect but is minimally invasive for now. We probably need to
revisit how we are uploading information about tests that are
skipped and passed altogether in a separate change.

This change also cleans up a couple of other nits that were
unnecessary or broken in this same code path.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._mark_interrupted_tests_as_skipped):
(Manager._upload_json_files): Deletes the check for
chromium-mac-leopard (as it is no longer necessary).

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init): Here we were
recalculating the failure type unnecessarily.

  • Scripts/webkitpy/layout_tests/models/test_failures.py:

(determine_result_type):
(FailureEarlyExit): Adds a new failure type so we can tell what
happened.
(FailureEarlyExit.message):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_exit_after_n_failures_upload): Add more checks to
ensure that we are recording the SKIP correctly; this is less
than ideal, because we can't actually test the contents of
incremental_results.json. We should fix that at some point.

7:28 PM Changeset in webkit [113812] by bashi@chromium.org
  • 3 edits in branches/chromium/1084/Source/WebCore/platform/graphics

Merge 113132 - [Chromium] Out-of-process font loading garbles text
​https://bugs.webkit.org/show_bug.cgi?id=83002

Reviewed by Kent Tamura.

Initialize m_CTFont by using m_cgFont in FontPlatformData when we use
out-of-process font loading.

No new tests. This problem only occurs when the user uses a third party
font management software like Font Explorer so it is difficult to add
tests.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore):
(WebCore::FontPlatformData::loadFont): If font loading fails, set null to outNSFont so that the FontPlatformData won't be used.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::ctFont): Modified to return the appropriate NSFont object when the font from the browser process.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData): Returns null when the generated FontPlatformData object doesn't have NSFont object.

TBR=​bashi@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10034005

7:27 PM Changeset in webkit [113811] by tkent@chromium.org
  • 9 edits
    1 add in trunk/Source/WebCore

Add a function to set empty clients to a PageClients
​https://bugs.webkit.org/show_bug.cgi?id=83555

Reviewed by Adam Barth.

No new tests because of no behavior change.

  • CMakeLists.txt: Add EmptyClients.cpp.
  • GNUmakefile.list.am: ditto.
  • Target.pri: ditto.
  • WebCore.gypi: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • loader/EmptyClients.cpp: Added.

(WebCore::fillWithEmptyClients): Some code was moved from SVGImage::dataChanged().

  • loader/EmptyClients.h: Add the declaration of fillWithEmptyClients().
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged): Moved some code to fillWithEmptyClients().

7:25 PM FeatureFlags edited by tkent@chromium.org
add LEGACY_CSS_VENDOR_PREFIXES (diff)
7:19 PM Changeset in webkit [113810] by rakuco@webkit.org
  • 28 edits in trunk/LayoutTests

[EFL] Garden fast/{backgrounds,dynamic,encoding}.

  • platform/efl/fast/backgrounds/svg-as-mask-expected.txt:
  • platform/efl/fast/dynamic/002-expected.png:
  • platform/efl/fast/dynamic/004-expected.png:
  • platform/efl/fast/dynamic/006-expected.png:
  • platform/efl/fast/dynamic/012-expected.png:
  • platform/efl/fast/dynamic/015-expected.png:
  • platform/efl/fast/dynamic/anchor-lock-expected.txt:
  • platform/efl/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
  • platform/efl/fast/dynamic/containing-block-change-expected.png:
  • platform/efl/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:
  • platform/efl/fast/dynamic/float-withdrawal-expected.png:
  • platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/efl/fast/dynamic/noninlinebadness-expected.png:
  • platform/efl/fast/dynamic/outerHTML-doc-expected.png:
  • platform/efl/fast/dynamic/outerHTML-img-expected.png:
  • platform/efl/fast/dynamic/selection-highlight-adjust-expected.png:
  • platform/efl/fast/dynamic/staticY-marking-parents-regression-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.png:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/dynamic/view-overflow-expected.png:
  • platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/efl/fast/encoding/invalid-UTF-8-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.png:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/encoding/xmacroman-encoding-test-expected.png:
7:13 PM Changeset in webkit [113809] by jamesr@google.com
  • 24 edits in trunk/Source

[chromium] Fold LayerChromium::updateCompositorResources into main update
​https://bugs.webkit.org/show_bug.cgi?id=83530

Reviewed by Adrienne Walker.

Source/WebCore:

We used to update layer contents in two phases. The first, called paintContentsIfDirty() /
idlePaintContentsIfDirty(), ran on the main WebKit thread and took care of any main-thread work - primarily
WebCore painting as the name implies. The second, called updateCompositorResources(), ran on the compositor
thread with the main thread blocked and took care of any actions that required direct access to the compositor's
context - such as texture uploads into compositor-managed textures. Now that all compositor texture operations
are queued on a CCTextureUpdater, the compositor can take care of these operations on the correct thread at the
right time without needing layer-specific logic.

This folds both functions into one function called LayerChromium::update() (and idleUpdate() for idle
prepainting) and adds a CCTextureUpdater reference for queuing up texture operations.

The CCProxy is responsible for the lifetime of the CCTextureUpdater. In the threaded proxy, the updater is
tied to the lifetime of the beginFrame operation. Specifically it's constructed on the impl thread when the
beginFrame message is generated, is accessed by reference on the main thread during the commit, and then
destroyed by the proxy when the commit is complete. CCTextureUpdater::update should only be called on the impl
thread by the proxy. In the future, it might be worth exposing a more limited interface to layers.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::update):

  • platform/graphics/chromium/Canvas2DLayerChromium.h:

(Canvas2DLayerChromium):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::idleUpdate):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerChromium):

  • platform/graphics/chromium/ImageLayerChromium.cpp:

(WebCore::ImageLayerTextureUpdater::updateLayerRect):
(WebCore::ImageLayerChromium::update):

  • platform/graphics/chromium/ImageLayerChromium.h:

(ImageLayerChromium):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::update):
(WebCore::LayerChromium::idleUpdate):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):

  • platform/graphics/chromium/TiledLayerChromium.h:

(TiledLayerChromium):

  • platform/graphics/chromium/WebGLLayerChromium.cpp:

(WebCore::WebGLLayerChromium::update):

  • platform/graphics/chromium/WebGLLayerChromium.h:

(WebGLLayerChromium):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::update):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.h:

(CCSingleThreadProxy):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

Update tests for interface changes.

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTest::runTest):
(WTF::ContentLayerChromiumWithUpdateTracking::update):
(WTF::ContentLayerChromiumWithUpdateTracking::idleUpdate):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::TestLayerChromium::update):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):

  • tests/CCTiledLayerTestCommon.cpp:

(WebKitTests::FakeLayerTextureUpdater::updateLayerRect):
(WebKitTests::FakeTiledLayerChromium::update):

  • tests/CCTiledLayerTestCommon.h:

(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):

  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):
(WTF::idlePaintRepeat):

7:07 PM Changeset in webkit [113808] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

fast/forms/implicit-submission.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=39056

Speed up the test by removing unnecessary iframe and navigation,
make it less flaky by removing timeouts.

Reviewed by Hajime Morita.

  • fast/forms/implicit-submission.html: Deflakified and sped up.
7:05 PM Changeset in webkit [113807] by rakuco@webkit.org
  • 161 edits
    1 add in trunk/LayoutTests

[EFL] Garden fast/css.

Account for some changes related to the jhbuild and font commits
and adjust some wrong results with fonts that are too big.

  • platform/efl/fast/css/001-expected.png:
  • platform/efl/fast/css/003-expected.png:
  • platform/efl/fast/css/004-expected.png:
  • platform/efl/fast/css/005-expected.png:
  • platform/efl/fast/css/MarqueeLayoutTest-expected.png:
  • platform/efl/fast/css/ZeroOpacityLayers-expected.png:
  • platform/efl/fast/css/ZeroOpacityLayers2-expected.png:
  • platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.png:
  • platform/efl/fast/css/acid2-pixel-expected.png:
  • platform/efl/fast/css/apple-prefix-expected.png:
  • platform/efl/fast/css/begin-end-contain-selector-empty-value-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/efl/fast/css/border-radius-outline-offset-expected.png:
  • platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png:
  • platform/efl/fast/css/color-correction-expected.png:
  • platform/efl/fast/css/color-correction-on-text-expected.png:
  • platform/efl/fast/css/compare-content-style-expected.png:
  • platform/efl/fast/css/continuationCrash-expected.png:
  • platform/efl/fast/css/create_element_align-expected.png:
  • platform/efl/fast/css/css-imports-expected.png:
  • platform/efl/fast/css/css1_forward_compatible_parsing-expected.png:
  • platform/efl/fast/css/css2-system-fonts-expected.png:
  • platform/efl/fast/css/css3-modsel-22-expected.png:
  • platform/efl/fast/css/css3-nth-child-expected.png:
  • platform/efl/fast/css/css3-space-in-nth-and-lang-expected.png:
  • platform/efl/fast/css/empty-pseudo-class-expected.png:
  • platform/efl/fast/css/error-in-last-decl-expected.png:
  • platform/efl/fast/css/ex-after-font-variant-expected.png:
  • platform/efl/fast/css/fieldset-display-row-expected.png:
  • platform/efl/fast/css/find-next-layer-expected.png:
  • platform/efl/fast/css/first-child-pseudo-class-expected.png:
  • platform/efl/fast/css/first-letter-capitalized-expected.png:
  • platform/efl/fast/css/first-letter-detach-expected.png:
  • platform/efl/fast/css/first-letter-float-after-float-expected.png:
  • platform/efl/fast/css/first-letter-float-expected.png:
  • platform/efl/fast/css/first-letter-hover-expected.png:
  • platform/efl/fast/css/first-letter-punctuation-expected.png:
  • platform/efl/fast/css/first-letter-recalculation-expected.png:
  • platform/efl/fast/css/first-letter-skip-out-of-flow-expected.png:
  • platform/efl/fast/css/first-letter-visibility-expected.png:
  • platform/efl/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/focus-ring-detached-expected.png:
  • platform/efl/fast/css/focus-ring-multiline-expected.png:
  • platform/efl/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
  • platform/efl/fast/css/focus-ring-outline-offset-expected.png:
  • platform/efl/fast/css/font-face-implicit-local-font-expected.png:
  • platform/efl/fast/css/font-face-locally-installed-expected.png:
  • platform/efl/fast/css/font-face-multiple-faces-expected.png:
  • platform/efl/fast/css/font-face-unicode-range-expected.png:
  • platform/efl/fast/css/font-weight-1-expected.png:
  • platform/efl/fast/css/font_property_normal-expected.png:
  • platform/efl/fast/css/h1-in-section-elements-expected.png:
  • platform/efl/fast/css/hover-subselector-expected.png:
  • platform/efl/fast/css/hsl-color-expected.png:
  • platform/efl/fast/css/import-rule-regression-11590-expected.png:
  • platform/efl/fast/css/import-rule-regression-11590-expected.txt:
  • platform/efl/fast/css/inline-element-line-break-expected.png:
  • platform/efl/fast/css/inline-element-line-break-expected.txt:
  • platform/efl/fast/css/inline-properties-important-expected.png:
  • platform/efl/fast/css/inline-properties-important-expected.txt:
  • platform/efl/fast/css/invalid-percentage-property-expected.png:
  • platform/efl/fast/css/invalid-percentage-property-expected.txt:
  • platform/efl/fast/css/invalidation-errors-2-expected.png:
  • platform/efl/fast/css/invalidation-errors-2-expected.txt:
  • platform/efl/fast/css/invalidation-errors-3-expected.png:
  • platform/efl/fast/css/invalidation-errors-3-expected.txt:
  • platform/efl/fast/css/invalidation-errors-expected.png:
  • platform/efl/fast/css/invalidation-errors-expected.txt:
  • platform/efl/fast/css/last-child-pseudo-class-expected.png:
  • platform/efl/fast/css/last-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/layerZOrderCrash-expected.png:
  • platform/efl/fast/css/layerZOrderCrash-expected.txt:
  • platform/efl/fast/css/line-height-expected.png:
  • platform/efl/fast/css/line-height-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.png:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css/list-outline-expected.png:
  • platform/efl/fast/css/list-outline-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.png:
  • platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.png:
  • platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/efl/fast/css/namespaces/004-expected.png:
  • platform/efl/fast/css/namespaces/005-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-comments-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-empty-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-escapes-expected.png:
  • platform/efl/fast/css/namespaces/namespaces-invalid-at-expected.png:
  • platform/efl/fast/css/negative-leading-expected.png:
  • platform/efl/fast/css/negative-leading-expected.txt:
  • platform/efl/fast/css/negative-nth-child-expected.png:
  • platform/efl/fast/css/negative-nth-child-expected.txt:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
  • platform/efl/fast/css/nested-layers-with-hover-expected.png:
  • platform/efl/fast/css/nested-layers-with-hover-expected.txt:
  • platform/efl/fast/css/nested-rounded-corners-expected.png:
  • platform/efl/fast/css/nth-child-dynamic-expected.png:
  • platform/efl/fast/css/nth-child-dynamic-expected.txt:
  • platform/efl/fast/css/only-child-pseudo-class-expected.png:
  • platform/efl/fast/css/only-child-pseudo-class-expected.txt:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/efl/fast/css/outline-auto-location-expected.png:
  • platform/efl/fast/css/outline-auto-location-expected.txt:
  • platform/efl/fast/css/outline-narrowLine-expected.png:
  • platform/efl/fast/css/outline-narrowLine-expected.txt:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.png:
  • platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/efl/fast/css/percentage-non-integer-expected.png:
  • platform/efl/fast/css/percentage-non-integer-expected.txt:
  • platform/efl/fast/css/positioned-overflow-scroll-expected.png:
  • platform/efl/fast/css/pseudo-element-line-break-expected.png:
  • platform/efl/fast/css/pseudo-element-line-break-expected.txt:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.png:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.txt: Added.
  • platform/efl/fast/css/quirk-orphaned-units-expected.png:
  • platform/efl/fast/css/quirk-orphaned-units-expected.txt:
  • platform/efl/fast/css/resize-corner-tracking-expected.png:
  • platform/efl/fast/css/resize-corner-tracking-expected.txt:
  • platform/efl/fast/css/resize-corner-tracking-transformed-expected.png:
  • platform/efl/fast/css/resize-corner-tracking-transformed-expected.txt:
  • platform/efl/fast/css/rtl-ordering-expected.png:
  • platform/efl/fast/css/rtl-ordering-expected.txt:
  • platform/efl/fast/css/selector-set-attribute-expected.png:
  • platform/efl/fast/css/selector-set-attribute-expected.txt:
  • platform/efl/fast/css/table-text-align-quirk-expected.png:
  • platform/efl/fast/css/table-text-align-quirk-expected.txt:
  • platform/efl/fast/css/table-text-align-strict-expected.png:
  • platform/efl/fast/css/table-text-align-strict-expected.txt:
  • platform/efl/fast/css/text-align-expected.png:
  • platform/efl/fast/css/text-align-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/efl/fast/css/text-security-expected.png:
  • platform/efl/fast/css/text-security-expected.txt:
  • platform/efl/fast/css/text-transform-select-expected.png:
  • platform/efl/fast/css/text-transform-select-expected.txt:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.png:
  • platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
  • platform/efl/fast/css/transformed-mask-expected.png:
  • platform/efl/fast/css/transformed-mask-expected.txt:
  • platform/efl/fast/css/universal-hover-quirk-expected.png:
  • platform/efl/fast/css/universal-hover-quirk-expected.txt:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
  • platform/efl/fast/css/word-space-extra-expected.png:
  • platform/efl/fast/css/word-space-extra-expected.txt:
  • platform/efl/fast/css/zoom-font-size-expected.png:
  • platform/efl/fast/css/zoom-font-size-expected.txt:
6:57 PM Changeset in webkit [113806] by adamk@chromium.org
  • 10 edits in trunk/Source/WebCore

Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
​https://bugs.webkit.org/show_bug.cgi?id=83615

Reviewed by Adam Barth.

Historically, these wrappers had their own map, but there doesn't seem
to be any particular reason for this. The V8GCController doesn't
treat them specially (which is the reason you normally need a separate
wrapper map).

No new tests, no expected change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetDomMapName):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/ScopedDOMDataStore.cpp:

(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):

  • bindings/v8/StaticDOMDataStore.cpp:

(WebCore::StaticDOMDataStore::StaticDOMDataStore):

  • bindings/v8/StaticDOMDataStore.h:

(StaticDOMDataStore):

  • bindings/v8/V8DOMMap.cpp:

(WebCore::removeAllDOMObjects):

  • bindings/v8/V8DOMMap.h:

(WebCore):

  • bindings/v8/V8DOMWrapper.cpp:
6:46 PM Changeset in webkit [113805] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[Qt] Separate image encoding from dataURL construction
​https://bugs.webkit.org/show_bug.cgi?id=83132

Reviewed by Noam Rosenthal.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::encodeImage): Output the encoded image to the provided QByteArray.
(WebCore):
(WebCore::ImageBuffer::toDataURL) Format the dataURL encoding of the mimeType
encoded image data here. Clarify the comment.

6:45 PM Changeset in webkit [113804] by dpranke@chromium.org
  • 4 edits in trunk/Tools

make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
​https://bugs.webkit.org/show_bug.cgi?id=83401

Reviewed by Adam Barth.

Last patch in the series - no longer look in mac-leopard,
mac-snowleopard, or mac-lion.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:

(ChromiumMacPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
6:39 PM Changeset in webkit [113803] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r113730.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::isInBounds):

6:37 PM Changeset in webkit [113802] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkit-patch: add a print-expectations command
​https://bugs.webkit.org/show_bug.cgi?id=83347

Reviewed by Adam Barth.

This command will print the expected results for a given set of
tests on a given set of ports matching a given set of keywords.

Example output (printing all the tests not expected to pass, and their
expected results, on a Mac):

$ webkit-patch print-expectations -x pass fast/html
For mac-snowleopard
fast/html/details-open4.html = TEXT
fast/html/details-open2.html = TEXT
fast/html/details-no-summary4.html = TEXT
fast/html/details-open-javascript.html = TEXT
$

You can also print full test-expectatons.txt lines using --full and a
CSV-style report (which can be useful for post-processing) using --csv.

It will replace the 'skipped-files' command (which will be
removed in a subsequent patch) and is a more general (and
cleaner and properly layered) solution.

Also add an update() command to MockOptions() to make overriding keywords easier.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationSerializer.to_string):
(TestExpectationSerializer):
(TestExpectationSerializer.to_csv):
(TestExpectationSerializer._format_result):
(TestExpectationLine.create_passing_expectation):
(TestExpectationsModel.get_test_set_for_keyword):
(TestExpectationsModel.has_keyword):
(TestExpectations.model):

  • Scripts/webkitpy/tool/commands/queries.py:

(execute):
(PrintExpectations):
(PrintExpectations.init):
(PrintExpectations.execute):
(PrintExpectations._filter_tests):
(PrintExpectations._format_lines):
(PrintExpectations._model):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(TestPrintExpectations): Added.

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions):
(MockOptions.init):
(MockOptions.update): Added.

6:30 PM Changeset in webkit [113801] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: refactor handling of --platform and related options
​https://bugs.webkit.org/show_bug.cgi?id=83525

Reviewed by Adam Barth.

This change moves to centralize handling of --platform, --debug,
--gtk, and other similar flags into a central place next to the
code that actually uses those flags in PortFactory to get the
right Port object.

  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:

(port_options):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintBaselines.init):

6:24 PM Changeset in webkit [113800] by mrowe@apple.com
  • 10 edits in trunk/Source

<rdar://problem/10583749> WebKit2 should log to both ASL and stderr

Source/WebKit2:

Replace direct calls to fprintf stderr with calls to WTFLogAlways.

Reviewed by Sam Weinig.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(WebKit::PluginProcessMain):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:

(readSandboxProfile):
(WKN_EnterSandbox):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

Source/WTF:

Reviewed by Sam Weinig.

  • wtf/Assertions.cpp: Add a WTFLogAlways function that unconditionally logs the given message.
  • wtf/Assertions.h:
6:19 PM FeatureFlags edited by tkent@chromium.org
Add ENCRYPTED_MEDIA (diff)
6:15 PM Changeset in webkit [113799] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Add transfer map argument to Intent constructor
​http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
​http://dev.w3.org/html5/postmsg/

Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.

​https://bugs.webkit.org/show_bug.cgi?id=80200

Patch by Greg Billock <​gbillock@google.com> on 2012-04-10
Reviewed by Adam Barth.

  • Modules/intents/Intent.cpp:

(WebCore::Intent::create):

  • Modules/intents/Intent.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8IntentCustom.cpp: Added.

(WebCore):
(WebCore::V8Intent::constructorCallback):

6:09 PM Changeset in webkit [113798] by Patrick Gansterer
  • 7 edits in trunk/Source

Cleanup wtf/Platform.h and config.h files
​https://bugs.webkit.org/show_bug.cgi?id=83431

Reviewed by Eric Seidel.

The ENABLE() and USE() macros take care about the case when the flag
isn't defined. So there is no need to define anything with 0.

Also move duplicated code from the config.h files to Platform.h and
merge a few preprocessor commands to make the file more readable.

Source/JavaScriptCore:

  • config.h:

Source/WebCore:

  • config.h:

Source/WTF:

  • config.h:
  • wtf/Platform.h:
5:56 PM Changeset in webkit [113797] by simonjam@chromium.org
  • 4 edits
    1 copy in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium/test_expectations.txt:
5:37 PM Changeset in webkit [113796] by fpizlo@apple.com
  • 13 edits
    14 adds in trunk

DFG should flush SetLocals to arguments
​https://bugs.webkit.org/show_bug.cgi?id=83554

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This is necessary to match baseline JIT argument capture behavior.

But to make this work right we need to have a story for arguments into
which we store values of different formats. This patch introduces the
notion of an ArgumentPosition - i.e. an argument in a particular inline
call frame - and forces unification of all data pertinent to selecting
the argument's data format.

Also fixed an amusing bug in the handling of OSR on SetLocals if there
was any insertion/deletion of nodes in the basic block. This is benign
for now but won't be eventually since the DFG is getting smarter. So
better fix it now.

Also fixed an amusing bug in the handling of OSR on SetLocals if they
are immediately followed by a Flush. I think this bug might have always
been there but now it'll happen more commonly, and it's covered by the
run-javascriptcore-tests.

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArgumentPosition.h: Added.

(DFG):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::addVariable):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGDoubleFormatState.h: Added.

(DFG):
(JSC::DFG::mergeDoubleFormatStates):
(JSC::DFG::mergeDoubleFormatState):
(JSC::DFG::doubleFormatStateToString):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::doubleFormatState):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeDoubleFormatState):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):

Source/WTF:

Reviewed by Gavin Barraclough.

Added an isRoot() method that is a faster shorthand for saying
find() == this.

  • wtf/UnionFind.h:

(WTF::UnionFind::isRoot):
(UnionFind):

LayoutTests:

Rubber stamped by Gavin Barraclough.

Added a variety of tests for reassigning arguments prior to function.arguments
retrieval.

  • fast/js/dfg-inline-arguments-become-double-expected.txt: Added.
  • fast/js/dfg-inline-arguments-become-double.html: Added.
  • fast/js/dfg-inline-arguments-become-int32-expected.txt: Added.
  • fast/js/dfg-inline-arguments-become-int32.html: Added.
  • fast/js/dfg-inline-arguments-reset-changetype-expected.txt: Added.
  • fast/js/dfg-inline-arguments-reset-changetype.html: Added.
  • fast/js/dfg-inline-arguments-reset-expected.txt: Added.
  • fast/js/dfg-inline-arguments-reset.html: Added.
  • fast/js/script-tests/dfg-inline-arguments-become-double.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-become-int32.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-reset-changetype.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

  • fast/js/script-tests/dfg-inline-arguments-reset.js: Added.

(foo):
(bar):
(baz):
(argsToStr):

5:17 PM Changeset in webkit [113795] by abarth@webkit.org
  • 14 edits in trunk

Source/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
​https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

As recommended by David Hyatt in
<​https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>,
we should phase out support for -khtml- and -apple- vendor prefixes in
CSS (in favor of -webkit-).

As noted in <​https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's
proposal is a bit too agressive. These prefixes appear to be needed
for a number of dashboard widgets. For that reason, this patch limits
the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES).

This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and
apple-win, which will let us learn whether removing these prefixes
causes a compatibility problem on the broader web.

  • Configurations/FeatureDefines.xcconfig:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyInfo):

  • css/CSSParser.cpp:

(WebCore::cssPropertyID):

Source/WebKit/chromium: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
​https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

  • features.gypi:

WebKitLibraries: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
​https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

  • win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests: Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
​https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

Skip these two tests, which are testing that -apple- and -khtml- vendor
prefixes work correctly.

  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
5:15 PM Changeset in webkit [113794] by adamk@chromium.org
  • 5 edits in trunk/Source

Remove unused NonNullPassRefPtr from WTF
​https://bugs.webkit.org/show_bug.cgi?id=82389

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

  • JavaScriptCore.order: Remove nonexistent symbols referencing NonNullPassRefPtr.

Source/WTF:

NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.

If someone decides they need this later, they can always revert this patch.

  • wtf/PassRefPtr.h:
  • wtf/RefPtr.h:

(RefPtr):

5:09 PM Changeset in webkit [113793] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r113791.

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):

4:44 PM Changeset in webkit [113792] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
​https://bugs.webkit.org/show_bug.cgi?id=83604

Reviewed by Julien Chaffraix.

Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.

Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See ​https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

  • editing/Editor.cpp:

(WebCore::Editor::firstRectForRange):

  • editing/RenderedPosition.cpp:

(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.

  • editing/RenderedPosition.h:

(RenderedPosition):

4:40 PM Changeset in webkit [113791] by yael.aharon@nokia.com
  • 18 edits
    1 add in trunk

Initial support for fixed position elements in Qt WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=81786

Reviewed by Noam Rosenthal.

.:

  • ManualTests/fixed-position.html: Added.

Source/WebCore:

When the setting acceleratedCompositingForFixedPositionEnabled is true, we update
the position of fixed layers, and send updates to the UI process as we scroll.
Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI
and the web processes, and adjusts its transform position accordingly.

  • page/FrameView.cpp:

(WebCore::FrameView::setFixedVisibleContentRect):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setScrollPositionDelta):
(WebCore):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

Source/WebKit2:

Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout.
As we scroll, we keep track of the delta in scroll position between the UI and web processes,
and adjust the position of all the fixed layers by that delta.
When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending,
and commit the new scroll position in flushLayerChanges.
This patch does not address scrolling overshoot and it does not fix the wrong positioning
that occurs when we zoom. These issues will be addressed in future patches.

  • Shared/WebLayerTreeInfo.h:
  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::setContentsSize):
(WebKit):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::didChangeScrollPosition):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::boundedScrollPosition):
(WebKit):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setContentsSize):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):

  • UIProcess/WebLayerTreeRenderer.h:

(WebLayerTreeRenderer):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebGraphicsLayer):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeHostQt::syncFixedLayers):
(WebKit::LayerTreeHostQt::setVisibleContentsRect):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

4:34 PM Changeset in webkit [113790] by simonjam@chromium.org
  • 12 edits
    2 adds
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Removed.
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Removed.
  • platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
  • platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
  • platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
  • platform/chromium/test_expectations.txt:
4:16 PM Changeset in webkit [113789] by abarth@webkit.org
  • 4 deletes in trunk/LayoutTests/platform

Remove empty directories.

4:10 PM Changeset in webkit [113788] by dpranke@chromium.org
  • 1 edit
    271 adds in trunk/LayoutTests

Clone any baselines chromium is using from mac-leopard and mac-snowleopard into chromium dirs.
​https://bugs.webkit.org/show_bug.cgi?id=83401

Unreviewed, baseline shuffling.

  • platform/chromium-mac-leopard/accessibility/aria-tables-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/lists-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/media-element-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-attributes-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-cell-spans-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-cells-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-detection-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-sections-expected.txt: Added.
  • platform/chromium-mac-leopard/accessibility/table-with-rules-expected.txt: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
  • platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
  • platform/chromium-mac-leopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/designmode-no-caret-expected.png: Added.
  • platform/chromium-mac-leopard/editing/spelling/grammar-expected.txt: Added.
  • platform/chromium-mac-leopard/editing/text-iterator/findString-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Added.
  • platform/chromium-mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • platform/chromium-mac-leopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/disabled-author-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/css/outline-auto-empty-rects-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/chromium-mac-leopard/fast/dom/gc-10-expected.png: Added.
  • platform/chromium-mac-leopard/fast/events/keydown-1-expected.png: Added.
  • platform/chromium-mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
  • platform/chromium-mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
  • platform/chromium-mac-leopard/fast/frames/inline-object-inside-frameset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/images/pdf-as-image-landscape-expected.png: Added.
  • platform/chromium-mac-leopard/fast/reflections/inline-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
  • platform/chromium-mac-leopard/fast/replaced/pdf-as-image-expected.png: Added.
  • platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/font-initial-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-selection-expected.png: Added.
  • platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-selection-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/inspector/console-websocket-error-expected.txt: Added.
  • platform/chromium-mac-leopard/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/error404-goback-expected.png: Added.
  • platform/chromium-mac-leopard/http/tests/navigation/error404-subframeload-expected.png: Added.
  • platform/chromium-mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
  • platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
  • platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/style-attribute-font-size-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/hixie/mixed/007-expected.png: Added.
  • platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Added.
  • platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-leopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
  • platform/chromium-mac-leopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
  • platform/chromium-mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/set-colors-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/preloader/document-write-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/preloader/document-write-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/media-queries-print-expected.png: Added.
  • platform/chromium-mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added.
  • platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/mixed/007-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/viewbox/001-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/hixie/viewbox/002-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
  • platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
  • platform/chromium-mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.
3:59 PM Changeset in webkit [113787] by ojan@chromium.org
  • 3 edits in trunk/Tools

Add a chromeless view to the individual tests view
​https://bugs.webkit.org/show_bug.cgi?id=83541

Reviewed by Daniel Bates.

This is the view suitable to inlining in other contexts (e.g. garden-o-matic).

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
  • TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

(testHtmlForIndividualTestOnAllBuilders):
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):
(htmlEscape):
(runTests):

3:59 PM Changeset in webkit [113786] by rakuco@webkit.org
  • 3 edits in trunk

[CMake] Do not pass -P to the preprocessor when running make_names.pl.
​https://bugs.webkit.org/show_bug.cgi?id=83225

Reviewed by Rob Buis.

This is necessary to make CMake-based ports build with the
recently-released GCC 4.7.0, whose preprocessor seems to ignore
empty lines when -P is passed to it. Such behavior breaks
make_names.pl (in fact, InFilesParser.pm), which expects an empty
line to separate common and specific sections in .in files.

A fix for this same problem has been supposedly done in r84123,
but as the CMake-based ports always pass --preprocessor to the
Perl tools the fix never reached us.

The idea is to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS
for (!MSVC && !QNX) and use it in the macros which call
make_names.pl.

  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitMacros.cmake:
3:52 PM Changeset in webkit [113785] by tomz@codeaurora.org
  • 6 edits in trunk/LayoutTests

Unreviewed update to test expectations

  • platform/efl/test_expectations.txt:
  • platform/gtk/test_expectations.txt:
  • platform/mac/test_expectations.txt:
  • platform/qt/test_expectations.txt:
  • platform/win/test_expectations.txt:
3:41 PM Changeset in webkit [113784] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fix test_expectations.txt from r113776.

  • platform/chromium/test_expectations.txt:
3:39 PM Changeset in webkit [113783] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types
​https://bugs.webkit.org/show_bug.cgi?id=83390

Patch by Peter Rybin <​peter.rybin@gmail.com> on 2012-04-10
Reviewed by Yury Semikhatsky.

Intermediate classes InspectorObjectBase and InspectorArrayBase are created. They have all raw methos
protected. InspectorObject and InspectorArray now inherit the corresponding base classes with exposing
all their protected methods.

"Open types" are left inheriting from InspectorObject, plus field name constants are generated for
an easy random access to all properties.

All the client code is fixed to use type-safe API rather than raw access methods in function parameter
and return types and bodies.

  • inspector/CodeGeneratorInspector.py:

(RawTypes.Object):
(RawTypes.Object.get_setter_name):
(RawTypes.Array):
(RawTypes.Array.get_setter_name):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(Array):
(Generator):
(Generator.resolve_type_and_generate_ad_hoc.InterfaceGenerateContext):
(Generator.process_types.GenerateContext):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::didPause):

  • inspector/InspectorPageAgent.cpp:

(WebCore::buildObjectForSearchResult):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didReceiveResponse):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::fillMediaListChain):
(WebCore::InspectorStyle::styleWithProperties):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorObjectBase::~InspectorObjectBase):
(WebCore::InspectorObjectBase::asObject):
(WebCore::InspectorObjectBase::openAccessors):
(WebCore):
(WebCore::InspectorObjectBase::getBoolean):
(WebCore::InspectorObjectBase::getString):
(WebCore::InspectorObjectBase::getObject):
(WebCore::InspectorObjectBase::getArray):
(WebCore::InspectorObjectBase::get):
(WebCore::InspectorObjectBase::remove):
(WebCore::InspectorObjectBase::writeJSON):
(WebCore::InspectorObjectBase::InspectorObjectBase):
(WebCore::InspectorArrayBase::~InspectorArrayBase):
(WebCore::InspectorArrayBase::asArray):
(WebCore::InspectorArrayBase::writeJSON):
(WebCore::InspectorArrayBase::InspectorArrayBase):
(WebCore::InspectorArrayBase::get):

  • inspector/InspectorValues.h:

(InspectorObjectBase):
(InspectorObject):
(WebCore::InspectorObject::create):
(WebCore):
(InspectorArrayBase):
(WebCore::InspectorArrayBase::length):
(InspectorArray):
(WebCore::InspectorArray::create):
(WebCore::InspectorObjectBase::find):
(WebCore::InspectorObjectBase::setBoolean):
(WebCore::InspectorObjectBase::setNumber):
(WebCore::InspectorObjectBase::setString):
(WebCore::InspectorObjectBase::setValue):
(WebCore::InspectorObjectBase::setObject):
(WebCore::InspectorObjectBase::setArray):
(WebCore::InspectorArrayBase::pushBoolean):
(WebCore::InspectorArrayBase::pushInt):
(WebCore::InspectorArrayBase::pushNumber):
(WebCore::InspectorArrayBase::pushString):
(WebCore::InspectorArrayBase::pushValue):
(WebCore::InspectorArrayBase::pushObject):
(WebCore::InspectorArrayBase::pushArray):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

3:37 PM Changeset in webkit [113782] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] defaultDeviceScaleFactor != 0 should set deviceScaleFactor = defaultDeviceScaleFactor in the absence of a viewport tag for debugging purposes
​https://bugs.webkit.org/show_bug.cgi?id=82757

Patch by Tim Dresser <​tdresser@chromium.org> on 2012-04-10
Reviewed by Darin Fisher.

If there is no viewport tag, the deviceScaleFactor is set to the defaultDeviceScaleFactor.
Tested by: WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag.

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • tests/WebFrameTest.cpp:

(WebKit):
(FixedLayoutTestWebViewClient):
(WebKit::TEST_F):

  • tests/data/no_viewport_tag.html: Added.
3:36 PM Changeset in webkit [113781] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary calls to RenderSVGShape::createShape()
​https://bugs.webkit.org/show_bug.cgi?id=83598

Reviewed by Rob Buis.

RenderSVGShape::strokeContains contains calls to fall back to path stroke hit detection
in several cases (dashed strokes, for example). One of these cases, a check for isStyled,
is not needed and is always true for Ellipses, Circles, and Rects (all styled elements).
This change removes the check for isStyled.

No new tests as this only affects performance, not test results.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeContains):

3:33 PM Changeset in webkit [113780] by mitz@apple.com
  • 5 edits
    4 adds in trunk

<rdar://problem/10912486> CanvasRenderingContext2D does not expose its backing store resolution
​https://bugs.webkit.org/show_bug.cgi?id=83619

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/2d.backingStorePixelRatio.html

Added a backingStorePixelRatio attribute to CanvasRenderingContext2D, as proposed in
<​http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-March/035112.html>. The attribute
is prefixed with “webkit” for now.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::deviceScaleFactor): Added this getter.

  • html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::webkitBackingStorePixelRatio): Added. Returns the canvas
element’s device scale factor.
(CanvasRenderingContext2D):

  • html/canvas/CanvasRenderingContext2D.idl: Added webkitBackingStorePixelRatio as a

read-only attribute.

LayoutTests:

  • fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
  • fast/canvas/2d.backingStorePixelRatio.html: Added.
  • platform/mac/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
  • platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Added.
3:26 PM Changeset in webkit [113779] by rakuco@webkit.org
  • 2 edits
    15 adds in trunk/LayoutTests

[EFL][DRT] Top level SVG rebaselines
​https://bugs.webkit.org/show_bug.cgi?id=83585

Unreviewed, EFL rebaseline.

Landing bug 83562 enables us to do a bigger rebaselining and
unskipping of EFL SVG testcases. This is part one.

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-04-10

  • platform/efl/Skipped:
  • platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/efl/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
  • platform/efl/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/efl/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Added.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Added.
3:24 PM Changeset in webkit [113778] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Segmentation fault in JS drop-down menus in facebook.com
​https://bugs.webkit.org/show_bug.cgi?id=82896

Patch by Mario Sanchez Prada <​msanchez@igalia.com> on 2012-04-10
Reviewed by Chris Fleizach.

Make sure changes introduced with r110819 affect to the Mac
platform only, since they depend on platform specific behaviour,
as not all the platforms treat attachments in the same way.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::detachFromParent):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::detachFromParent):
(WebCore):

3:18 PM Changeset in webkit [113777] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix fast/images/exif-orientation.html WebKitTestRunner failure
​https://bugs.webkit.org/show_bug.cgi?id=83627

Reviewed by Sam Weinig.

Handle overriding the WebKitShouldRespectImageOrientation preference.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

3:17 PM Changeset in webkit [113776] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test webaudio/* is flaky
​https://bugs.webkit.org/show_bug.cgi?id=83624

Add failing tests to skipped list.

  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [113775] by dpranke@chromium.org
  • 4 edits in trunk/Tools

remove 'win' from chromium-win, chromium-linux fallback paths
​https://bugs.webkit.org/show_bug.cgi?id=83613

Reviewed by Ojan Vafai.

The chromium ports no longer need to look at the apple 'win'
directory for baseline results.

Also remove the old '-gpu-' entries from the flakiness dashboard
map since I'm touching lines nearby.

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:

(ChromiumLinuxPort):

  • Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort):

  • TestResultServer/static-dashboards/flakiness_dashboard.html:
2:57 PM Changeset in webkit [113774] by kling@webkit.org
  • 4 edits in trunk/Source/WebCore

REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter.
<​http://webkit.org/b/83540>

Reviewed by Antti Koivisto.

Changed the behavior of getPropertyCSSValueInternal() to actually return the internal
value rather than a cloned one. There is an assertion in the CSSValue bindings that
will catch anyone trying to expose these values to the web.

This avoids constructing "safe" CSSValue objects in the bindings layer, for the cases
where we only want to extract the cssText or numeric value. These cloned objects are
only needed when exposing fully-fledged CSSValues to the web, which must be tied to
a single document.

  • css/CSSStyleDeclaration.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):

2:52 PM Changeset in webkit [113773] by noam.rosenthal@nokia.com
  • 25 edits
    11 adds in trunk

[Qt][WK2] Manage graphics buffers in the web process
​https://bugs.webkit.org/show_bug.cgi?id=78675

Source/WebCore:

Added WebCore::GraphicsSurface, a wrapper class to a platform-dependant
surface that can be accessed efficiently by both the CPU and the GPU.
This will allow fast texture uploads for WebKit2, and in the future
fast copies for 2D canvas and WebGL.
The first implementation is for Mac using IOSurfaces.

TextureMapperGL had to be modified to use GL_UNSIGNED_INT_8_8_8_8_REV
for textures on Mac, since that's the native pixel format of BGRA
IOSurfaces.

Though this feature is not written in a Qt-specific way, it's currently
only enabled for Qt and is protected by USE(GRAPHICS_SURFACE).

Reviewed by Kenneth Rohde Christiansen.

Covered by existing API tests.

  • Target.pri:
  • WebCore.pri:
  • platform/graphics/surfaces/GraphicsSurface.cpp: Added.
  • platform/graphics/surfaces/GraphicsSurface.h: Added.
  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp: Added.
  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp: Added.

(WebCore::GraphicsSurface::didReleaseImage):
(WebCore):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::BitmapTexture::isOpenGLBacked):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::toBitmapTextureGL):
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::BitmapTextureGL::isOpenGLBacked):
(WebCore):

Source/WebKit2:

Added ShareableSurface, a class allowing the use of GPU-enabled
surfaces for bitmap transfer between the web and UI processes.
Since GraphicsSurfaces may not always be available, ShareableSurface
uses a standard ShareableBitmap as a fallback backend.

The necessary plumbing was added in WebKit2 for passing updates via
ShareableSurfaces instead of ShareableBitmaps. SurfaceUpdateInfo was
added, as to not make UpdateInfo more complicated.

Reviewed by Kenneth Rohde Christiansen.

  • Shared/ShareableSurface.cpp: Added.
  • Shared/ShareableSurface.h: Added.
  • Shared/SurfaceUpdateInfo.cpp: Added.
  • Shared/SurfaceUpdateInfo.h: Added.
  • Target.pri:
  • UIProcess/LayerTreeHostProxy.cpp:

(WebKit::LayerTreeHostProxy::createTileForLayer):
(WebKit::LayerTreeHostProxy::updateTileForLayer):

  • UIProcess/LayerTreeHostProxy.h:

(LayerTreeHostProxy):

  • UIProcess/LayerTreeHostProxy.messages.in:
  • UIProcess/WebLayerTreeRenderer.cpp:

(WebKit::WebLayerTreeRenderer::updateTile):

  • UIProcess/WebLayerTreeRenderer.h:

(TileUpdate):
(WebKit::WebLayerTreeRenderer::TileUpdate::TileUpdate):

  • UIProcess/qt/LayerBackingStore.cpp:

(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit::LayerBackingStore::updateTile):

  • UIProcess/qt/LayerBackingStore.h:

(LayerBackingStoreTile):
(LayerBackingStore):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):

  • WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebGraphicsLayerClient):
(WebGraphicsLayer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:

(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

  • WebProcess/WebPage/TiledBackingStoreRemoteTile.h:

(WebKit):
(TiledBackingStoreRemoteTileClient):

  • WebProcess/WebPage/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/UpdateAtlas.h:

(WebKit::UpdateAtlas::surface):
(WebKit::UpdateAtlas::size):

  • WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::beginContentUpdate):

  • WebProcess/WebPage/qt/LayerTreeHostQt.h:

(LayerTreeHostQt):

Tools:

Enable graphics surfaces on Mac for Qt.

Reviewed by Kenneth Rohde Christiansen.

  • qmake/mkspecs/features/features.prf:
2:52 PM Changeset in webkit [113772] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/dom/inline-event-attributes-release.html to the Skipped list.

  • platform/mac/Skipped:
2:45 PM Changeset in webkit [113771] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: split nodes and edges array in heap profiler serialization.
​https://bugs.webkit.org/show_bug.cgi?id=83465

Frontend is now able to read format when nodes and edges arrive
in two separate arrays.

Patch by Alexei Filippov <​alexeif@chromium.org> on 2012-04-10
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotLoader.prototype._parseIntArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
(WebInspector.HeapSnapshot):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

  • inspector/profiler/heap-snapshot-loader-expected.txt:
  • inspector/profiler/heap-snapshot-loader.html:
  • inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotSplitNodesEdgesMockRaw):

2:41 PM Changeset in webkit [113770] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

CSS box-shadow default color should be something other than transparent
​https://bugs.webkit.org/show_bug.cgi?id=58511

Patch by Dave Tharp <​dtharp@codeaurora.org> on 2012-04-10
Reviewed by Simon Fraser.

Source/WebCore:

If box-shadow or text-shadow color is not specified, color defaults to
the value specified in the 'color' property of the element (as specified in W3C
spec).

Test: fast/text/text-shadow-no-default-color.html. Also existing
tests ietestcenter/css3/box-shadow-002 and ietestcenter/css3/box-shadow-003

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

Added new test for the case where no color is specified for text
shadow. This test and two others are marked as expected fail pending
rebaseline.

  • fast/text/text-shadow-no-default-color.html: Added.
  • platform/chromium/test_expectations.txt:
2:28 PM Changeset in webkit [113769] by crogers@google.com
  • 12 edits
    2 adds in trunk

AudioParam must support connections from audio-rate signals
​https://bugs.webkit.org/show_bug.cgi?id=83524

Source/WebCore:

Reviewed by Eric Carlson.

In the Web Audio API, it's possible to connect one AudioNode to another AudioNode.
Similary we should allow an AudioNode to connect to an AudioParam, thus controlling
a parameter with an audio-rate signal. This is important in many audio processing
applications.

Test: webaudio/audioparam-connect-audioratesignal.html

Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().

  • Modules/webaudio/AudioGainNode.cpp:

(WebCore::AudioGainNode::process):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect): Add connect() method from AudioNode -> AudioParam.
(WebCore):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::finishDeref):
Use AudioNodeOutput::disconnectAll() instead of AudioNodeOutput::disconnectAllInputs().

  • Modules/webaudio/AudioNode.h: Add connect() method from AudioNode -> AudioParam.

(WebCore):
(AudioNode):

  • Modules/webaudio/AudioNode.idl: Add connect() method from AudioNode -> AudioParam.

Implement support for an AudioNodeOutput to fanout to multiple AudioParams.

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateRenderingState): Update rendering state related to AudioParams.
(WebCore::AudioNodeOutput::pull): pull() must now take into account fanout to AudioParams for in-place processing.
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore):
(WebCore::AudioNodeOutput::paramFanOutCount): New method keeping track of number of connections to AudioParams.
(WebCore::AudioNodeOutput::renderingParamFanOutCount): New method keeping track of number of connections to AudioParams for rendering.
(WebCore::AudioNodeOutput::addParam): Add a connection to an AudioParam.
(WebCore::AudioNodeOutput::removeParam): Remove a connection to an AudioParam.
(WebCore::AudioNodeOutput::disconnectAllParams): Remove all connections to AudioParams.
(WebCore::AudioNodeOutput::disconnectAll): New method to disconnect all AudioNodeInputs and AudioParams.

  • Modules/webaudio/AudioNodeOutput.h:

(AudioNodeOutput):

Allow an AudioParam to accept a connection from an AudioNodeOutput, thus being controlled
by an audio-rate signal.

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateSampleAccurateValues): Calculates sample-accurate values from timeline or an AudioNode.
(WebCore):
(WebCore::AudioParam::calculateAudioRateSignalValues): Calculates sample-accurate values from an AudioNode.
(WebCore::AudioParam::calculateTimelineValues): Calculates sample-accurate values scheduled on the timeline.
(WebCore::AudioParam::connect): Connect from an AudioNodeOutput for control from an audio-rate signal.
(WebCore::AudioParam::disconnect): Disconnect from an AudioNodeOutput.

  • Modules/webaudio/AudioParam.h:

(WebCore):
(WebCore::AudioParam::AudioParam):
(WebCore::AudioParam::hasSampleAccurateValues): Change name from hasTimelineValues() and return true
either if we have timeline values or if we've been connected from an AudioNode.
(AudioParam):

Simple method name change of AudioParam::hasTimelineValues() to AudioParam::hasSampleAccurateValues().

  • Modules/webaudio/Oscillator.cpp:

(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):

LayoutTests:

Reviewed by Eric Carlson.

  • webaudio/audioparam-connect-audioratesignal-expected.txt: Added.
  • webaudio/audioparam-connect-audioratesignal.html: Added.
  • webaudio/resources/audio-testing.js:

(createLinearRampBuffer):
(createConstantBuffer):

2:25 PM Changeset in webkit [113768] by leviw@chromium.org
  • 3 edits in branches/subpixellayout/Source/WebCore/editing

Fix that mirrors the change from Bug 83604. Cleaning up RenderedPosition::absoluteRect and its usage in Editor.

2:16 PM Changeset in webkit [113767] by Patrick Gansterer
  • 2 edits in trunk

[CMake][WIN] Add /MP flag when using a compiler with support for it
​https://bugs.webkit.org/show_bug.cgi?id=83577

Reviewed by Daniel Bates.

  • Source/cmake/OptionsWindows.cmake:
2:14 PM Changeset in webkit [113766] by Patrick Gansterer
  • 2 edits in trunk

[CMake] Add missing DERIVED_SOURCES_WEBKIT_DIR variable
​https://bugs.webkit.org/show_bug.cgi?id=83573

Reviewed by Daniel Bates.

We need this variable when ports want to generate files in the WebKit target.

  • CMakeLists.txt:
2:12 PM Changeset in webkit [113765] by Darin Adler
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused data member from Lexer class
​https://bugs.webkit.org/show_bug.cgi?id=83429

Reviewed by Kentaro Hara.

I noticed that m_delimited was "write-only", so I deleted it.

  • parser/Lexer.cpp:

(JSC::Lexer::setCode): Removed code to set m_delimited.
(JSC::Lexer::parseIdentifier): Ditto.
(JSC::Lexer::parseIdentifierSlowCase): Ditto.
(JSC::Lexer::lex): Ditto.

  • parser/Lexer.h: Deleted m_delimited.
2:07 PM Changeset in webkit [113764] by Patrick Gansterer
  • 17 edits in trunk

[CMake] Enable USE_FOLDERS property
​https://bugs.webkit.org/show_bug.cgi?id=83571

Reviewed by Daniel Bates.

.:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:
  • shell/CMakeLists.txt:

Source/WebCore:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WebKit:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WebKit2:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • CMakeLists.txt:

Source/WTF:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • wtf/CMakeLists.txt:

Tools:

Setting the FOLDER property on targets gives more structure
to the generated Visual Studio solutions.
This does not affect other CMake generators.

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • WinCELauncher/CMakeLists.txt:
2:05 PM Changeset in webkit [113763] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] CMake SVG Code Generation fails to generate code for extra defines
​https://bugs.webkit.org/show_bug.cgi?id=83562

Patch by Dominik Röttsches <​dominik.rottsches@linux.intel.com> on 2012-04-10
Reviewed by Rob Buis.

Fixing CMakeLists.txt to generate correct extra defines for SVG code generator.

  • CMakeLists.txt:
1:52 PM Changeset in webkit [113762] by Lucas Forschler
  • 5 edits in branches/safari-534.56-branch/Source

Versioning.

1:50 PM Changeset in webkit [113761] by Lucas Forschler
  • 1 copy in tags/Safari-534.56.6

New tag.

1:40 PM BuildBot edited by rniwa@webkit.org
Update non-cygwin Windows instruction (diff)
1:34 PM Changeset in webkit [113760] by eae@chromium.org
  • 6 edits in branches/subpixellayout/Source/WebCore

chromium/linux and apple/win build fixes for branch.

1:32 PM Changeset in webkit [113759] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to captions list not updated after section recalc.
​https://bugs.webkit.org/show_bug.cgi?id=83552

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/table/table-caption-not-removed-crash.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild): no need to set the need for
section recalc. It was needed in old code when we had more than
one caption and we need to call section recalc to destroy the other
captions.
(WebCore::RenderTable::recalcSections): need to rebuild captions list.
This is how the old code worked before r100177. Basically, children can
moved without calling RenderTable::removeChild, so we should depend on
recalcSections to update our captions list. Also, fix a style nit of aligning
case labels with the switch statement.

LayoutTests:

  • fast/table/table-caption-not-removed-crash-expected.txt: Added.
  • fast/table/table-caption-not-removed-crash.html: Added.
1:09 PM Changeset in webkit [113758] by senorblanco@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/skia/ImageSkia.cpp

Merge 113373 - [chromium] Drawing an accelerated canvas onto itself is slow.
​https://bugs.webkit.org/show_bug.cgi?id=83295

Fixed by using a GPU-side deepCopy() in skia, so we don't trigger a
readback and re-upload.

Reviewed by James Robinson.

Correctness is covered by existing tests. Performance is covered
by the test case attached to the bug.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::create):

TBR=​laforge@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9960076

12:55 PM Changeset in webkit [113757] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when tearing down web page rendered using WebPageCompositor
​https://bugs.webkit.org/show_bug.cgi?id=83567

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-04-10
Reviewed by Antonio Gomes.

Fixed by checking if there's a layer renderer before calling into it.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):

12:48 PM Changeset in webkit [113756] by andersca@apple.com
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r113611.
​http://trac.webkit.org/changeset/113611
​https://bugs.webkit.org/show_bug.cgi?id=71541

Broke fast/forms/basic-textareas.html

Source/WebCore:

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasHorizontalOverflow):
(WebCore::RenderLayer::hasVerticalOverflow):

LayoutTests:

  • fast/overflow/overflow-auto-destroy-scroll-after-resizing-expected.html: Removed.
  • fast/overflow/overflow-auto-destroy-scroll-after-resizing.html: Removed.
  • platform/efl/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:45 PM Changeset in webkit [113755] by commit-queue@webkit.org
  • 16 edits
    4 deletes in trunk

Unreviewed, rolling out r113734.
​http://trac.webkit.org/changeset/113734
​https://bugs.webkit.org/show_bug.cgi?id=83606

causing a bunch of unrelated test failures (Requested by
simonjam on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-04-10

Source/WebCore:

  • Modules/battery/BatteryController.cpp:
  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Removed.
  • public/WebBatteryStatusClient.h: Removed.
  • public/WebView.h:

(WebKit):
(WebView):

  • public/WebViewClient.h:

(WebKit):

  • src/BatteryClientImpl.cpp: Removed.
  • src/BatteryClientImpl.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [113754] by adamk@chromium.org
  • 4 edits in trunk/Source/WebCore

Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects
​https://bugs.webkit.org/show_bug.cgi?id=83528

Reviewed by Kentaro Hara.

Instead of using a run-time call to isActiveNode to determine which
map to put a Node wrapper in, generate the proper call in the CodeGenerator.

This was originally part of r112318, which got rolled out due to OOM concerns.
I'm splitting it into smaller pieces so that each can be landed and
watched for issues seperately.

No new tests, no change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Use new GetDomMapName function to
figure out which setJSWrapper to call.
(GenerateNamedConstructorCallback): ditto.
(GetDomMapFunction): Delegate to GetDomMapName for logic.
(GetDomMapName): New helper factored out of GetDomMapFunction.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::setJSWrapperForDOMNode): Assert !isActiveNode instead of branching on it.
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMNode): New method split ouf of the above.
Assert isActiveNode instead of branching on it.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

12:36 PM Changeset in webkit [113753] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Pass PropertyHandler by reference in CSSStyleApplyProperty.h.
​https://bugs.webkit.org/show_bug.cgi?id=83551

Reviewed by Kentaro Hara.

No new tests / cleanup only.

  • css/CSSStyleApplyProperty.h:

(WebCore::CSSStyleApplyProperty::setPropertyHandler):

12:31 PM Changeset in webkit [113752] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Pass FontDescription as const reference instead of by value in CSSStyleSelector.h.
​https://bugs.webkit.org/show_bug.cgi?id=83548

Reviewed by Kentaro Hara.

FontDescription is relatively large, so pass-by-reference is preferred.

No new tests / code cleanup only.

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::fontDescription):
(WebCore::CSSStyleSelector::parentFontDescription):
(WebCore::CSSStyleSelector::setFontDescription):

12:23 PM Changeset in webkit [113751] by adamk@chromium.org
  • 1 edit
    13 adds in trunk/Source/WebCore

Add TestNode.idl to run-binding-tests
​https://bugs.webkit.org/show_bug.cgi?id=83599

Reviewed by Adam Barth.

TestNode.idl is a minimized version of Node.idl with enough attributes
to exercise CodeGenerator.pm's handling of Node subtypes.

  • bindings/scripts/test/CPP/WebDOMTestNode.cpp: Added.
  • bindings/scripts/test/CPP/WebDOMTestNode.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestNode.cpp: Added.
  • bindings/scripts/test/JS/JSTestNode.h: Added.
  • bindings/scripts/test/ObjC/DOMTestNode.h: Added.
  • bindings/scripts/test/ObjC/DOMTestNode.mm: Added.
  • bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Added.
  • bindings/scripts/test/TestNode.idl: Added.
  • bindings/scripts/test/V8/V8TestNode.cpp: Added.
  • bindings/scripts/test/V8/V8TestNode.h: Added.
12:18 PM Changeset in webkit [113750] by eae@chromium.org
  • 2 edits in branches/subpixellayout/Source/WebCore/rendering

Fix style issues on branch.

12:15 PM Changeset in webkit [113749] by commit-queue@webkit.org
  • 18 edits in trunk

msqrt's implied mrow should do operator stretching
​https://bugs.webkit.org/show_bug.cgi?id=82353

Patch by David Barton <Dave Barton> on 2012-04-10
Reviewed by Julien Chaffraix.

Source/WebCore:

An <msqrt> with more than one child is supposed to surround them with an implied <mrow>.
This patch does this, and thus includes vertical operator stretching. We also fix some
problems with the old RenderMathMLSquareRoot.cpp: possibly shared RenderStyles were
being modified, and layout() was using heights of children without checking whether they
needed layout themselves first.

To leave room for the radical sign, we use intrinsic padding. This is simpler and more
efficient than using anonymous RenderStyles.

Added tests to mo-stretch.html and style.xhtml. Regression tests are in roots.xhtml.

  • css/mathml.css:

(msqrt):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):

  • rendering/mathml/RenderMathMLBlock.h:

(RenderMathMLBlock):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):

  • rendering/mathml/RenderMathMLRow.h:

(RenderMathMLRow):

  • rendering/mathml/RenderMathMLSquareRoot.cpp:

(WebCore):
(WebCore::RenderMathMLSquareRoot::addChild):
(WebCore::RenderMathMLSquareRoot::computePreferredLogicalWidths):
(WebCore::RenderMathMLSquareRoot::computeLogicalHeight):
(WebCore::RenderMathMLSquareRoot::layout):
(WebCore::RenderMathMLSquareRoot::paint):

  • rendering/mathml/RenderMathMLSquareRoot.h:

(RenderMathMLSquareRoot):

LayoutTests:

  • mathml/presentation/mo-stretch.html:
  • mathml/presentation/style.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/style-expected.png:
  • platform/mac/mathml/presentation/style-expected.txt:
12:10 PM Changeset in webkit [113748] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't allow fallthrough for CSSPropertyBaselineShift in CSSComputedStyleDeclaration::getSVGPropertyCSSValue().
​https://bugs.webkit.org/show_bug.cgi?id=83536

Reviewed by Daniel Bates.

Add a return statement to the case CSSPropertyBaselineShift so that we don't fall through to the next case statement.

No new tests / code cleanup from coverity static analysis.

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

12:01 PM Changeset in webkit [113747] by adamk@chromium.org
  • 4 edits
    4 copies in branches/chromium/1084

Merge 113378 - Crash in MutationObservers due to an invalid HashSet iterator
​https://bugs.webkit.org/show_bug.cgi?id=83304

Reviewed by Ojan Vafai.

Source/WebCore:

If the observed node has been GCed when we clear transient observers
from it, the HashSet iterator in WebKitMutationObserver::deliver would
be invalidated. This patch fixes that behavior by copying the relevant
registrations into a seperate vector first and operating on the copy.

This patch also fixes a bug: transient observers should be cleared
after every microtask, not just when delivering.

Tests: fast/mutation/clear-transient-without-delivery.html

fast/mutation/transient-gc-crash.html

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
Notify the observer that it has a transient registration so it can be properly cleared.

  • dom/MutationObserverRegistration.h:

(WebCore::MutationObserverRegistration::hasTransientRegistrations):
Add an accessor for use when deliver() creates its vector of registrations.

  • dom/WebKitMutationObserver.cpp:

(WebCore::WebKitMutationObserver::setHasTransientRegistration): Add this to the active observer set
to allow transient registrations to be cleared appropriately.
(WebCore::WebKitMutationObserver::deliver): Avoid modifying m_registrations while iterating over it.
Clear registrations before checking for a lack of records to deliver.

  • dom/WebKitMutationObserver.h:

LayoutTests:

  • fast/mutation/clear-transient-without-delivery-expected.txt: Added.
  • fast/mutation/clear-transient-without-delivery.html: Added.
  • fast/mutation/transient-gc-crash-expected.txt: Added.
  • fast/mutation/transient-gc-crash.html: Added.

TBR=​inferno@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/9999033

11:56 AM Changeset in webkit [113746] by alex
  • 3 edits in trunk/Source/WebCore

2012-04-10 Alejandro G. Castro <​alex@igalia.com>

[GTK] Build fix TextureMapper compilation and solve warning.

Reviewed by Martin Robinson.

  • platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::BitmapTextureGL::updateContents):
  • platform/graphics/texmap/TextureMapperShaderManager.h: (WebCore::TextureMapperShaderManager::getShaderProgram):
11:52 AM Changeset in webkit [113745] by eae@chromium.org
  • 897 edits
    92 copies
    22 deletes in branches/subpixellayout

Merge trunk changes up until 113730 into subpixel branch.

11:46 AM Changeset in webkit [113744] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/events/drop-handler-should-not-stop-navigate.html.

Like fast/events/drop-with-file-paths.html, this expects eventSender.beginDragWithFiles to be implemented.

  • platform/wk2/Skipped:
11:44 AM Changeset in webkit [113743] by andersca@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/events/drop-with-file-paths.html to the WebKit2 Skipped list.

  • platform/wk2/Skipped:
11:29 AM Changeset in webkit [113742] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Separate image encoding from dataURL construction
​https://bugs.webkit.org/show_bug.cgi?id=83152

Reviewed by Martin Robinson.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage): Output the encoded image to the provided GOwnPtr<gchar>&
buffer. Update GTK document reference to a valid URL. Round the quality argument
to an int like the toDataURL() implementations of other ports. Ditch the success
variable; instead test the GError* error return to indicate success.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Format the dataURL encoding of the mimeType
encoded image data buffer herein.

11:20 AM Changeset in webkit [113741] by antonm@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add test expectations for Mac debug builds.

Unreviewed.

  • platform/chromium-mac-snowleopard/fast/dom/shadow: Added.
  • platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
11:17 AM Changeset in webkit [113740] by jamesr@google.com
  • 11 edits in trunk/Source

[chromium] Defer texture id allocation for copies until the actual copy executes
​https://bugs.webkit.org/show_bug.cgi?id=83514

Reviewed by Adrienne Walker.

Source/WebCore:

This allows for queuing a texture copy operation into a ManagedTexture whose texture ID has not yet been
allocated. The ManagedTexture* serves as a promise that an ID will be available when the copy is executed.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::updateCompositorResources):

  • platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:

(WebCore::CCSingleThreadProxy::doCommit):

  • platform/graphics/chromium/cc/CCTextureUpdater.cpp:

(WebCore::CCTextureUpdater::CCTextureUpdater):
(WebCore::CCTextureUpdater::appendManagedCopy):
(WebCore):
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):

  • platform/graphics/chromium/cc/CCTextureUpdater.h:

(CCTextureUpdater):
(ManagedCopyEntry):

  • platform/graphics/chromium/cc/CCThreadProxy.cpp:

(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):

Source/WebKit/chromium:

  • tests/CCTiledLayerTestCommon.cpp:
  • tests/CCTiledLayerTestCommon.h:
  • tests/Canvas2DLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:

(WTF::TEST):

11:14 AM Changeset in webkit [113739] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/multicol/cell-shrinkback-expected.html

Add ref test expected result.

11:14 AM Changeset in webkit [113738] by hyatt@apple.com
  • 4 edits
    1 add in trunk

Source/WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=83595
<rdar://problem/10443278> Overlapping text in table cell across column break

If a cell's height changes such that it is taller than the overall row height because
of pagination, then grow the entire row height to enclose the cell instead of shrinking
the cell.

Reviewed by Dan Bernstein.

Added fast/multicol/cell-shrinkback.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=83595

Add new layout test for cells paginating across columns.

Reviewed by Dan Bernstein.

  • fast/multicol/cell-shrinkback.html: Added.
  • fast/multicol/cell-shrinkback-expected.html: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
11:10 AM Changeset in webkit [113737] by macpherson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary null check in void SimplifyMarkupCommand::doApply().
​https://bugs.webkit.org/show_bug.cgi?id=83535

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

currentNode cannot be null within the loop body.
It is dereferenced before and after the removed line without checking.
Additionally I have added an assertion to express this loop invariant.

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):

10:47 AM Changeset in webkit [113736] by commit-queue@webkit.org
  • 27 edits
    5 adds in trunk

Add Encrypted Media Extensions methods to HTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=82971

Patch by David Dorwin <​ddorwin@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
Implementation is based on v0.1 of the draft proposal at
​http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.

Source/WebCore:

Tests: media/encrypted-media/encrypted-media-not-loaded.html

media/encrypted-media/encrypted-media-syntax.html

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitEncryptedMediaEnabled):

  • html/HTMLMediaElement.cpp:

(WebCore):
(WebCore::exceptionCodeForMediaKeyException):
(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):
(WebCore::HTMLMediaElement::webkitCancelKeyRequest):
(WebCore::HTMLMediaElement::setVolume):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::showingTrackWithSameKind):
(WebCore::HTMLMediaElement::didAddTrack):

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp:

(NullMediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayer::generateKeyRequest):
(WebCore::MediaPlayer::addKey):
(WebCore::MediaPlayer::cancelKeyRequest):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::addKey):
(WebCore::MediaPlayerPrivateInterface::generateKeyRequest):
(WebCore::MediaPlayerPrivateInterface::cancelKeyRequest):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebMediaPlayer.h:

(WebKit):
(WebMediaPlayer):
(WebKit::WebMediaPlayer::generateKeyRequest):
(WebKit::WebMediaPlayer::addKey):
(WebKit::WebMediaPlayer::cancelKeyRequest):

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit):
(WebKit::WebMediaPlayerClientImpl::generateKeyRequest):
(WebKit::WebMediaPlayerClientImpl::addKey):
(WebKit::WebMediaPlayerClientImpl::cancelKeyRequest):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::isMediaStreamEnabled):
(WebKit::WebRuntimeFeatures::enableEncryptedMedia):
(WebKit):
(WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • media/encrypted-media/encrypted-media-not-loaded-expected.txt: Added.
  • media/encrypted-media/encrypted-media-not-loaded.html: Added.
  • media/encrypted-media/encrypted-media-syntax-expected.txt: Added.
  • media/encrypted-media/encrypted-media-syntax.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/efl/Skipped:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
10:33 AM Changeset in webkit [113735] by leviw@chromium.org
  • 1 edit in branches/subpixellayout/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp

Build Fix for GTK.

10:28 AM Changeset in webkit [113734] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
​https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryController.h:

(BatteryController):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at ​http://www.w3.org/TR/2011/WD-battery-status-20111129/.
​https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

  • WebKit.gyp:
  • features.gypi:
  • public/WebBatteryStatus.h: Added.

(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):

  • public/WebBatteryStatusClient.h: Added.

(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):

  • public/WebView.h:

(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):

  • public/WebViewClient.h:

(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):

  • src/BatteryClientImpl.cpp: Added.

(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):

  • src/BatteryClientImpl.h: Added.

(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):

  • src/WebViewImpl.h:

(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
​https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <​sadrul@chromium.org> on 2012-04-10
Reviewed by Adam Barth.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
10:25 AM Changeset in webkit [113733] by zmo@google.com
  • 6 edits in trunk

getShaderFormatPrecision should return sensible values
​https://bugs.webkit.org/show_bug.cgi?id=83520

Reviewed by Kenneth Russell.

Source/WebCore:

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Fix getShaderPrecisionFormat values.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):

  • platform/graphics/qt/GraphicsContext3DQt.cpp: Ditto.

(WebCore::GraphicsContext3D::getShaderPrecisionFormat):

LayoutTests:

  • fast/canvas/webgl/shader-precision-format-expected.txt:
  • fast/canvas/webgl/shader-precision-format.html: Add tests to make sure getShaderPrecisionFormat returns sensible values.
10:20 AM Changeset in webkit [113732] by Lucas Forschler
  • 4 edits in branches/safari-534.56-branch/Source/JavaScriptCore

Merged r113654.

10:18 AM Changeset in webkit [113731] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add Galaxy Nexus to the list of emulated user agents
​https://bugs.webkit.org/show_bug.cgi?id=83589

The new record contains the device display metrics and the User Agent string.

Reviewed by Pavel Feldman.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

10:11 AM Changeset in webkit [113730] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

Add missing methods and operators to FractionalLayoutUnit
​https://bugs.webkit.org/show_bug.cgi?id=82403

Reviewed by Eric Seidel.

Add missing methods and operators and from branch version of
FractionalLayoutUnit. Also fix overflow assertion and add const keyword
to a couple of methods.

No new tests.

  • platform/FractionalLayoutUnit.h:

(WebCore::FractionalLayoutUnit::abs):
(FractionalLayoutUnit):
(WebCore::FractionalLayoutUnit::ceil):
(WebCore::FractionalLayoutUnit::round):
(WebCore::FractionalLayoutUnit::floor):
(WebCore::FractionalLayoutUnit::isInBounds):
(WebCore::operator<):
(WebCore):
(WebCore::operator-):

10:07 AM Changeset in webkit [113729] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2012-04-10 Zhenyao Mo <​zmo@google.com>

Unreviewed, roll chromium to 131469

  • DEPS:
10:04 AM Changeset in webkit [113728] by jer.noble@apple.com
  • 12 edits in trunk/Source/WebCore

WebAudio: propagate a silence hint through the AudioNode graph.
​https://bugs.webkit.org/show_bug.cgi?id=74553

Reviewed by Chris Rogers.

No new tests; optimization of existing code path, so covered by existing tests.

Introduce the concept of a "silent" channel:

  • platform/audio/AudioChannel.h:

(WebCore::AudioChannel::AudioChannel):
(WebCore::AudioChannel::set): Clear silent bit.
(WebCore::AudioChannel::zero): Set silent bit.
(WebCore::AudioChannel::clearSilentFlag): Clear silent bit.
(WebCore::AudioChannel::isSilent): Accessor.

Optimize a few channel operations when the source or destination channels are silent.

  • platform/audio/AudioChannel.cpp:

(WebCore::AudioChannel::scale): No-op on a silent channel.
(WebCore::AudioChannel::copyFrom): zero() when source is silent.
(WebCore::AudioChannel::copyFromRange): possibly zero() when source is silent.
(WebCore::AudioChannel::sumFrom): No-op when source is silent.
(WebCore::AudioChannel::maxAbsValue): 0 on a silent channel.

Optimize a few bus operations when the source or destination channels are silent.

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::processWithGainFromMonoStereo): No-op if source is silent and either

the destination bus is silent, or the output is not summed to the destination.

(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom): zero() if the source is silent

and the lengths of the gain values, source, and destination match.

(WebCore::AudioBus::createBySampleRateConverting): Return an empty bus if the source is silent.
(WebCore::AudioBus::createByMixingToMono): Ditto; clear the destination's silent bit otherwise.
(WebCore::AudioBus::isSilent): Return whether all channels are silent.
(WebCore::AudioBus::clearSilentFlag): Clear silent bit of constituent channels.

  • platform/audio/AudioBus.h:

Make sure that classes which generate audio clear their busses' silent bit.

  • webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process): Ditto.
(WebCore::AudioBufferSourceNode::renderFromBuffer): Ditto.
(WebCore::AudioBufferSourceNode::propagatesSilence): Propagate silence only when the source node

has nothing left to render.

  • webaudio/AudioBufferSourceNode.h:

(WebCore::AudioBufferSourceNode::playbackState): Made const correct.
(WebCore::AudioBufferSourceNode::isPlaying): Added simple accessor.
(WebCore::AudioBufferSourceNode::hasFinished): Ditto.

  • webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::currentSampleFrame): Made const correct.
(WebCore::AudioDestinationNode::currentTime): Ditto.

Audio nodes should not process audio data when the input is silent and the nodes will propagate silences.

  • webaudio/AudioNode.cpp:

(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::inputsAreSilent): Convenience function which walk over the node's inputs.
(WebCore::AudioNode::silenceOutputs): Ditto.
(WebCore::AudioNode::unsilenceOutputs): Ditto.

  • webaudio/AudioNode.h:

(WebCore::AudioNode::propagatesSilence):

These Nodes can generate audio when given silent input, so return false from propagatesSilence.

  • Modules/webaudio/Oscillator.h:

(WebCore::Oscillator::propagatesSilence): Added.

9:40 AM Changeset in webkit [113727] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed, add baselines for fast/dom/shadow/selection-in-shadow.html

  • platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Added.
9:36 AM Changeset in webkit [113726] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

It should be possible to see why a code block was not compiled by the DFG
​https://bugs.webkit.org/show_bug.cgi?id=83553

Reviewed by Geoff Garen.

If DFG_ENABLE(DEBUG_VERBOSE) and a code block is rejected, then print the
opcode that caused the rejection.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canHandleOpcodes):

9:29 AM Changeset in webkit [113725] by zandobersek@gmail.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed - adding myself as a committer.

9:22 AM Changeset in webkit [113724] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][DRT] Catch the "title,changed" signal
​https://bugs.webkit.org/show_bug.cgi?id=82174

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-10
Reviewed by Gustavo Noronha Silva.

Tools:

EFL's DumpRenderTree now catches the "title,changed" signal, and
prints out the needed information.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onTitleChanged):

LayoutTests:

Unskip tests which requires EFL's DumpRenderTree to catch the
"title,changed" signal and print out information, now that it
is implemented.

  • platform/efl/Skipped:
9:19 AM Changeset in webkit [113723] by yi.4.shen@nokia.com
  • 5 edits in trunk

Pressing enter on blank line after bullet deletes entire bulleted line.
​https://bugs.webkit.org/show_bug.cgi?id=82690

Reviewed by Enrica Casucci.

In CompositeEditCommand::breakOutOfEmptyListItem(), it checks the empty list item's renderer's siblings
to decide which empty part of the list should be removed. However, if the empty list item's renderer is
wrapped by an anonymous block, e.g. <ul><li>hello</li><br></ul>, the check may fail. So, we use isListItem
on the empty list node's siblings instead.

Source/WebCore:

No new tests : added new test case in the existing test (break-out-of-empty-list-item.html)

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

LayoutTests:

  • editing/execCommand/break-out-of-empty-list-item-expected.txt:
  • editing/execCommand/script-tests/break-out-of-empty-list-item.js:
9:15 AM Changeset in webkit [113722] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
​https://bugs.webkit.org/show_bug.cgi?id=82443

Patch by Christophe Dumez <Christophe Dumez> on 2012-04-10
Reviewed by Philippe Normand.

Tools:

EFL's DRT needs to support LayoutTestController's
willSendRequestReturnsNull() and return NULL when expected. This
allows for several tests to be removed from the skip list.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip tests which depend on EFL's DumpRenderTree support for
LayoutTestController's willSendRequestReturnsNull(), now that it is
implemented.

  • platform/efl/Skipped:
8:50 AM Changeset in webkit [113721] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Inspect Element - Edit as HTML - scrolling bug
​https://bugs.webkit.org/show_bug.cgi?id=83563

mousedown in the scrollbar focuses the Elements tree outline container DIV element,
so the corresponding mousedown event should be consumed in the AT_TARGET phase.

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.consume):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

8:42 AM WebKit Team edited by pdr@google.com
Adding my team to the committers wiki page. (diff)
8:36 AM Changeset in webkit [113720] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Assertion failure on loading new page after panning/zooming
​https://bugs.webkit.org/show_bug.cgi?id=83049

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

When handling contents size change, set the visible content rectangle immediately,
instead of animating to it.

  • UIProcess/qt/QtViewportInteractionEngine.cpp:

(WebKit::QtViewportInteractionEngine::itemSizeChanged):

8:35 AM Changeset in webkit [113719] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] LayoutTestController needs implementation of addUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=82446

Source/WebKit/efl:

Add missing implementation addUserStyleSheet to EFL's
DumpRenderTreeSupport.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::addUserStyleSheet):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
so that we can unskip related tests from the skip list.

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::addUserStyleSheet): Implemented.

LayoutTests:

Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/user-style-all-frames.html
userscripts/simple-stylesheet.html
userscripts/script-run-at-end.html

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-04-10
Reviewed by Antonio Gomes.

  • platform/efl/Skipped:
8:33 AM Changeset in webkit [113718] by pdr@google.com
  • 2 edits in trunk/Tools

Adding myself to committers.py!

Unreviewed update to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
8:33 AM Changeset in webkit [113717] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening, skip a test to try to paint the bot greener.

  • platform/qt-5.0-wk2/Skipped:
8:32 AM Changeset in webkit [113716] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove the unused function WebCore::toIconIndex
​https://bugs.webkit.org/show_bug.cgi?id=83037

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kentaro Hara.

  • WebCore.order:
  • dom/IconURL.cpp:
  • dom/IconURL.h:

(WebCore):

8:25 AM Changeset in webkit [113715] by commit-queue@webkit.org
  • 7 edits in trunk

[Qt][WK2] Title in MiniBrowser is not updated for a page with no title
​https://bugs.webkit.org/show_bug.cgi?id=82483

Patch by Dinu Jacob <​dinu.jacob@nokia.com> on 2012-04-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

titleChanged signal is not emitted on comitting a new load.

  • UIProcess/API/qt/tests/html/basic_page.html:
  • UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:

(tst_QQuickWebView):
(tst_QQuickWebView::titleUpdate):

  • UIProcess/qt/QtWebPageLoadClient.cpp:

(QtWebPageLoadClient::didCommitLoadForFrame):

Tools:

Set window title to default if there is no page title.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onTitleChanged):

  • MiniBrowser/qt/BrowserWindow.h:

(BrowserWindow):

8:14 AM Changeset in webkit [113714] by jesus@webkit.org
  • 4 edits in trunk

[Qt][WK2] Implement PageClient::isViewWindowActive()
​https://bugs.webkit.org/show_bug.cgi?id=81143

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

This patch implements PageClient::isViewWindowActive()
now that QQuickCanvas::isActive() is available (from QWindow).

  • UIProcess/qt/QtPageClient.cpp:

(QtPageClient::isViewWindowActive):

Tools:

Fix the WrapperWindow from our PlatformWebView
so it correctly creates the platform related
stuff for QWindow, which is not created unless
QWindow::setVisible() or QWindow::show() are called.

  • WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):

7:42 AM Changeset in webkit [113713] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Wk2] Gradening. Skip failing test.
​https://bugs.webkit.org/show_bug.cgi?id=83581

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/wk2/Skipped:
6:52 AM Changeset in webkit [113712] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a failing, a timeouting and a crashing test to paint the bots green.

  • platform/qt-5.0-wk2/Skipped:
5:53 AM Changeset in webkit [113711] by pfeldman@chromium.org
  • 11 edits in trunk

Web Inspector: make error a string on the front-end side, not an object.
​https://bugs.webkit.org/show_bug.cgi?id=83570

Reviewed by Yury Semikhatsky.

Source/WebCore:

We already expect it to be a string in all the code, we never use the error code in it.

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.dispatch):

LayoutTests:

  • inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
  • inspector/debugger/debugger-set-breakpoint-regex.html:
  • inspector/elements/resolve-node-blocked-expected.txt:
  • inspector/elements/set-attribute.html:
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles/set-property-boundaries-expected.txt:
5:34 AM Changeset in webkit [113710] by rwlbuis@webkit.org
  • 5 edits
    7 adds in trunk

getElementsByTagName unable to find SVG camelCase elements imported into HTML
​https://bugs.webkit.org/show_bug.cgi?id=46800

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Implement getElementsByTagName according to the algorithm in
​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagname.
If the owner document of the element is html, the new class HTMLTagNodeList deals with
finding the match(es) based on this algorithm. If the owner document is non HTML, the existing
TagNodeList is used.

Implement getElementsByTagNameNS according to the algorithm in
​http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-getelementsbytagnamens.
The existing TagNodeList implements this algorithm.

Cached results may have less hits after this change. Tag names that are equal when case
insensitive but different when case sensitive can't share the result due to above algorithms, i.e.
they would match differently in the non html part of the document.

Tests: fast/dom/getElementsByTagName-localName-matching.html

fast/dom/getElementsByTagName-localName-matching2.xhtml
svg/dom/getElementsByTagName-localName-matching.html

  • dom/Node.cpp:

(WebCore::Node::getElementsByTagName): create TagNodeList depending on owner document type.
(WebCore::Node::getElementsByTagNameNS): do not lowercase localName for html.

  • dom/TagNodeList.cpp:

(WebCore::HTMLTagNodeList::HTMLTagNodeList): add specialized TagNodeList for html matching rules.
(WebCore):
(WebCore::HTMLTagNodeList::nodeMatches):

  • dom/TagNodeList.h:

(TagNodeList):
(HTMLTagNodeList):
(WebCore::HTMLTagNodeList::create):

LayoutTests:

Add tests for getElementsByTagName(NS) in html, xhtml, and svg documents.

  • fast/dom/getElementsByTagName-localName-matching-expected.txt: Added.
  • fast/dom/getElementsByTagName-localName-matching.html: Added.
  • fast/dom/getElementsByTagName-localName-matching2-expected.txt: Added.
  • fast/dom/getElementsByTagName-localName-matching2.xhtml: Added.
  • svg/dom/getElementsByTagName-localName-matching-expected.txt: Added.
  • svg/dom/getElementsByTagName-localName-matching.html: Added.
  • svg/dom/script-tests/getElementsByTagName-localName-matching.js: Added.
5:29 AM Changeset in webkit [113709] by apavlov@chromium.org
  • 23 edits in trunk

Web Inspector: [Device Metrics] Introduce the "Fit window" option
​https://bugs.webkit.org/show_bug.cgi?id=83280

Source/WebCore:

This change adds the "Fit window" option to the Settings pane of Web Inspector, which lets users
resize the FrameView to fit the WebViewImpl size. When the user resizes the browser window
in the device metrics override mode with the option enabled, the FrameView follows
to match WebViewImpl by at least one dimension.

Reviewed by Pavel Feldman.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverrideImpl):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverrideImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::shouldApplyScreenWidthOverride):
(WebCore):
(WebCore::InspectorInstrumentation::shouldApplyScreenHeightOverride):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::updateViewMetrics):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

  • inspector/front-end/UserAgentSupport.js:
  • inspector/front-end/helpScreen.css:

(.help-content input[type=checkbox]):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):

Source/WebKit/chromium:

Implement the scaling of the FrameView to the WebViewImpl size, handle WebViewImpl resizes.

Reviewed by Pavel Feldman.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::overrideDeviceMetrics):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::setDeviceMetrics):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidthOnNavigation):
(DeviceMetricsSupport):
(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::webViewResized):
(WebKit::DeviceMetricsSupport::applySizeOverrideIfNecessary):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::restore):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):
(WebKit::DeviceMetricsSupport::forcedScrollbarDimensions):
(WebKit::DeviceMetricsSupport::applySizeOverrideInternal):
(WebKit::WebDevToolsAgentImpl::webViewResized):
(WebKit):
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
(WebKit::WebDevToolsAgentImpl::autoZoomPageToFitWidth):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebDevToolsAgentPrivate.h:

(WebDevToolsAgentPrivate):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):

LayoutTests:

Update the test to follow the protocol change and test the "Fit window" parameter.

Reviewed by Pavel Feldman.

  • inspector/styles/override-screen-size-expected.txt:
  • inspector/styles/override-screen-size.html:
4:34 AM Changeset in webkit [113708] by loislo@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: use maxJSObjectId that is provided by back-end.
​https://bugs.webkit.org/show_bug.cgi?id=82451

Summary view can filter objects in snapshot. It uses maxJSObjectId for this.
There was no such field in the profile header at the
moment but I've landed a patch in downstream.

Reviewed by Yury Semikhatsky.

  • bindings/js/ScriptHeapSnapshot.h:

(WebCore):
(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):

  • bindings/v8/ScriptHeapSnapshot.cpp:

(WebCore::ScriptHeapSnapshot::maxSnapshotJSObjectId):
(WebCore):

  • bindings/v8/ScriptHeapSnapshot.h:

(WebCore):
(ScriptHeapSnapshot):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::createSnapshotHeader):

  • inspector/front-end/DetailedHeapshotView.js:

(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.DetailedHeapshotView.prototype._changeFilter):

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype.updateStaticData):

  • inspector/front-end/HeapSnapshotProxy.js:
4:26 AM Changeset in webkit [113707] by pfeldman@chromium.org
  • 18 edits in trunk/Source/WebCore

Web Inspector: annotate front-end for newer closure compiler.
​https://bugs.webkit.org/show_bug.cgi?id=83478

Reviewed by Yury Semikhatsky.

This change mostly adds annotations to bound functions and !!bool expressions.
As a result, it makes closure compiler v20120305 happy.

  • inspector/Inspector.json:
  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/CSSStyleModel.js:
  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMAgent.prototype.pushNodeToFrontend):

  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/ObjectPropertiesSection.js:
  • inspector/front-end/RemoteObject.js:
  • inspector/front-end/Resource.js:

(WebInspector.ResourceDomainModelBinding.prototype.canSetContent):

  • inspector/front-end/ResourceUtils.js:
  • inspector/front-end/ScopeChainSidebarPane.js:
  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.editSource):

  • inspector/front-end/ScriptFormatter.js:

(WebInspector.ScriptFormatter.prototype.get _worker):

  • inspector/front-end/WorkerManager.js:
4:26 AM Changeset in webkit [113706] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r113701.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/wk2/Skipped:
4:14 AM PrefixedAPIs edited by hans@chromium.org
add spec links for speech and speech input (diff)
3:56 AM Changeset in webkit [113705] by Philippe Normand
  • 3 edits in trunk/LayoutTests

Unreviewed, skip a failing test and rebaseline another one after r113611.

  • platform/gtk/Skipped:
  • platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:
3:55 AM PrefixedAPIs edited by tonyg@chromium.org
(diff)
3:38 AM Changeset in webkit [113704] by gyuyoung.kim@samsung.com
  • 2 edits
    20 adds in trunk/LayoutTests

[EFL] Unreviewed. Gardening Add 19 missing expectations.

  • platform/efl/Skipped:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt: Added.
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt: Added.
  • platform/efl/http/tests/misc/acid2-expected.txt: Added.
  • platform/efl/http/tests/misc/error404-expected.txt: Added.
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt: Added.
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt: Added.
  • platform/efl/http/tests/misc/generated-content-inside-table-expected.txt: Added.
  • platform/efl/http/tests/misc/iframe404-expected.txt: Added.
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/efl/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-basic-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-goback-expected.txt: Added.
  • platform/efl/http/tests/navigation/error404-subframeload-expected.txt: Added.
  • platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt: Added.
  • platform/efl/http/tests/navigation/postredirect-basic-expected.txt: Added.
  • platform/efl/http/tests/navigation/postredirect-goback1-expected.txt: Added.
  • platform/efl/http/tests/uri/css-href-expected.txt: Added.
3:10 AM Changeset in webkit [113703] by kbalazs@webkit.org
  • 7 edits in trunk

[Qt][WK2] TestNetscapePlugin is broken
​https://bugs.webkit.org/show_bug.cgi?id=83024

Reviewed by Csaba Osztrogonác.

Tools:

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

Fix X11 availability check. embedded is always true with QPA.

  • Tools.pro:

Build the test plugin if plugins are enabled for WebKit2.

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/functions.prf:

Added a convenience function to determine availability
of X11 libraries.

LayoutTests:

Remove plugins from skiplist and put the rest
of failing tests to their group.

  • platform/qt-5.0-wk2/Skipped:
2:52 AM Changeset in webkit [113702] by Patrick Gansterer
  • 2 edits in trunk/Tools

[WIN] Fix build without precompiled header.

  • DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
2:30 AM Changeset in webkit [113701] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Gardening. Skip failing tests because of missing DnD support and ENABLE(SHADOW_DOM) is disabled.
[WK2] Skip tests because of missing layoutTestController.setAlwaysAcceptCookies().

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-04-10
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
  • platform/wk2/Skipped:
2:20 AM Changeset in webkit [113700] by pfeldman@chromium.org
  • 3 edits
    3 adds in trunk

Web Inspector: searching document with no documentElement results in 0x0 access.
​https://bugs.webkit.org/show_bug.cgi?id=83483

Reviewed by Yury Semikhatsky.

Source/WebCore:

Added the null check.

Test: inspector/elements/dom-search-crash.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

LayoutTests:

  • inspector/elements/dom-search-crash-expected.txt: Added.
  • inspector/elements/dom-search-crash.html: Added.
  • inspector/elements/resources/dom-search-crash-iframe.html: Added.
2:13 AM Changeset in webkit [113699] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1084/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 113585 - Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
​https://bugs.webkit.org/show_bug.cgi?id=83470

Reviewed by Yury Semikhatsky.

isPingRequest is tested for as a field, not a function return value.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):

TBR=​pfeldman@chromium.org
BUG=122639
Review URL: ​https://chromiumcodereview.appspot.com/10031030

1:15 AM Changeset in webkit [113698] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, GTK baselines for two new tests.

  • platform/gtk/fast/events/drop-with-file-paths-expected.txt: Added.
  • platform/gtk/media/nodesFromRect-shadowContent-expected.txt: Added.
12:40 AM Changeset in webkit [113697] by Carlos Garcia Campos
  • 12 edits
    4 copies
    2 adds in trunk/Source/WebKit2

[WK2][GTK] FullScreen signals
​https://bugs.webkit.org/show_bug.cgi?id=76166

Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp:

(WKViewSetFullScreenClientGtk): Initialize WebKitWebViewBase
fullscreen client.

  • UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
  • UIProcess/API/gtk/WebKitFullscreenClient.cpp: Added.

(willEnterFullScreen): Call webkitWebViewEnterFullScreen().
(willExitFullScreen): Call webkitWebViewLeaveFullScreen().
(attachFullScreenClientToView): Initialize FullScreenClient adding
implementations for willEnterFullScreen and willExitFullScreen callbacks.

  • UIProcess/API/gtk/WebKitFullscreenClient.h: Added.
  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach fullscreen client to view.
(webkit_web_view_class_init): Add WebKitWebView::enter-fullscreen
and WebKitWebView::leave-fullscreen signals.
(webkitWebViewEnterFullScreen): Emit
WebKitWebView::enter-fullscreen signal.
(webkitWebViewLeaveFullScreen): Emit
WebKitWebView::leave-fullscreen signal.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Only return early when leaving
fullscreen, otherwise let the view process the key pressed.
(webkitWebViewBaseEnterFullScreen): Return early if
willEnterFullScreen callback is handled and returns false.
(webkitWebViewBaseExitFullScreen): Return early if
willExitFullScreen callback is handled and returns false.
(webkitWebViewBaseInitializeFullScreenClient): Initialize the
fullscreen client.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewFullScreen):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::keyStroke): Helper function to synthesize key
press/release events.

  • UIProcess/API/gtk/tests/WebViewTest.h:
  • UIProcess/API/gtk/webkit2marshal.list:
  • UIProcess/gtk/WebFullScreenClientGtk.cpp:

(WebKit::WebFullScreenClientGtk::willEnterFullScreen): Call
willEnterFullScreen callback if defined.
(WebKit::WebFullScreenClientGtk::willExitFullScreen): Call
willExitFullScreen callback if defined.

  • UIProcess/gtk/WebFullScreenClientGtk.h:
12:38 AM Changeset in webkit [113696] by Patrick Gansterer
  • 4 edits in trunk/Source

[CMake] Add missing source files to build system

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:
12:29 AM Changeset in webkit [113695] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

Unreviewed. Fixed AppleWin and Chromium-win build failure.

Renamed 'exceptionNameDescription' to per-file variable name to avoid
name conflict.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/webdatabase/SQLException.cpp:

(WebCore::SQLException::initializeDescription):

  • dom/EventException.cpp:

(WebCore::EventException::initializeDescription):

  • dom/RangeException.cpp:

(WebCore::RangeException::initializeDescription):

  • fileapi/FileException.cpp:

(WebCore::FileException::initializeDescription):

  • fileapi/OperationNotAllowedException.cpp:

(WebCore::OperationNotAllowedException::initializeDescription):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • xml/XPathException.cpp:

(WebCore::XPathException::initializeDescription):

12:18 AM Changeset in webkit [113694] by arko@motorola.com
  • 2 edits in trunk/Tools

Unreviewed: adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
12:11 AM Changeset in webkit [113693] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

Unreviewed. Fixed AppleWin and Chromium-win build failure.

Renamed 'exceptions' to 'exceptionNameDescription' to avoid
variable name conflict.

  • Modules/indexeddb/IDBDatabaseException.cpp:

(WebCore::IDBDatabaseException::initializeDescription):

  • Modules/webdatabase/SQLException.cpp:

(WebCore::SQLException::initializeDescription):

  • dom/EventException.cpp:

(WebCore::EventException::initializeDescription):

  • dom/RangeException.cpp:

(WebCore::RangeException::initializeDescription):

  • fileapi/FileException.cpp:

(WebCore::FileException::initializeDescription):

  • fileapi/OperationNotAllowedException.cpp:

(WebCore::OperationNotAllowedException::initializeDescription):

  • svg/SVGException.cpp:

(WebCore::SVGException::initializeDescription):

  • xml/XPathException.cpp:

(WebCore::XPathException::initializeDescription):

12:05 AM Changeset in webkit [113692] by Philippe Normand
  • 7 edits in trunk/LayoutTests

Unreviewed, GTK rebaseline.

  • platform/gtk/editing/pasteboard/interchange-newline-2-expected.txt:
  • platform/gtk/editing/selection/editable-html-element-expected.txt:
  • platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/send-array-buffer-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/send-undefined-and-null-expected.txt:
Note: See TracTimeline for information about the timeline view.