Timeline
Apr 20, 2012:
- 11:24 PM Changeset in webkit [114838] by
-
- 47 edits12 adds in trunk/LayoutTests
Unreviewed, GTK svg rebaseline after r114799.
- 10:14 PM Changeset in webkit [114837] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114768.
http://trac.webkit.org/changeset/114768
https://bugs.webkit.org/show_bug.cgi?id=84521
Original patch was not the problem, re-applying (Requested by
pfeldman_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 8:22 PM April 2012 Meeting edited by
- (diff)
- 8:19 PM ShadowDOMDesignathon created by
- 8:07 PM Changeset in webkit [114836] by
-
- 4088 edits in trunk/LayoutTests
Rebaseline more GTK tests after <http://trac.webkit.org/changeset/114799>.
- 7:51 PM Changeset in webkit [114835] by
-
- 4 edits in trunk/Source
Make the Web Inspector be the first responder when opening docked.
<rdar://problem/11294217>
Reviewed by Brian Weinstein.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): Call makeFirstResponder: on
the window and pass the Inspector's WebView.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformAttach): Call makeFirstResponder: on
the window and pass the Inspector's WKView.
- 7:27 PM Changeset in webkit [114834] by
-
- 12 edits in trunk/LayoutTests
Undoing undesired changes.
- fast/block/float/008-expected.txt:
- fast/block/float/019-expected.txt:
- fast/block/float/035-expected.txt:
- fast/block/float/relative-painted-twice-expected.txt:
- fast/block/positioning/negative-rel-position-expected.txt:
- fast/canvas/canvas-bg-expected.txt:
- fast/css-generated-content/table-parts-before-and-after-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/flexbox/flex-hang-expected.txt:
- fast/forms/file/get-file-upload-expected.txt:
- fast/forms/select/listbox-in-multi-column-expected.txt:
- 7:21 PM Changeset in webkit [114833] by
-
- 240 edits in trunk/LayoutTests
Rebaseline more GTK fast tests after <http://trac.webkit.org/changeset/114799>.
- 7:19 PM Changeset in webkit [114832] by
-
- 125 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 and editing tests after <http://trac.webkit.org/changeset/114799>.
- 7:10 PM Changeset in webkit [114831] by
-
- 55 edits in trunk/LayoutTests
Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 7:05 PM Changeset in webkit [114830] by
-
- 299 edits in trunk/LayoutTests
Rebaseline more GTK editing, fast tests after <http://trac.webkit.org/changeset/114799>.
- 7:01 PM Changeset in webkit [114829] by
-
- 143 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 and animation tests after <http://trac.webkit.org/changeset/114799>.
- 6:50 PM Changeset in webkit [114828] by
-
- 35 edits in trunk/LayoutTests
Rebaseline more GTK CSS2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:48 PM Changeset in webkit [114827] by
-
- 20 edits in trunk/Source
[chromium] Refactor opaque content transform out of Skia context
https://bugs.webkit.org/show_bug.cgi?id=83608
Reviewed by James Robinson.
Source/WebCore:
Having PlatformContextSkia know about the transform into content space
for a layer is a layering violation. This change lets the
PlatformContextSkia deal with opaque rects in its own space and lets
the caller handle transforming it into its own space. This also
prevents a matrix multiply per draw into the Skia canvas and does it
just once at the end to transform the final rect.
This is an incremental refactoring so that additional tracking for
text rects can be added and use the same space as opaque rects.
Tests: LayerTextureUpdaterTest.testPartialOpaqueRectNoTransform
LayerTextureUpdaterTest.testPartialOpaqueRectTranslation
LayerTextureUpdaterTest.testPartialOpaqueRectScale
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(BitmapCanvasLayerTextureUpdater):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(BitmapSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
(WebCore::CanvasLayerTextureUpdater::paintContents):
- platform/graphics/chromium/CanvasLayerTextureUpdater.h:
(CanvasLayerTextureUpdater):
- platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
(SkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
- platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::didDrawRect):
(WebCore::PlatformContextSkia::didDrawPath):
(WebCore::PlatformContextSkia::didDrawPoints):
(WebCore::PlatformContextSkia::didDrawBounded):
- platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
Source/WebKit/chromium:
Add tests for opaque tracking in LayerTextureUpdater, since the
transform logic has moved there.
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::prepareToUpdate):
- tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
- tests/LayerTextureUpdaterTest.cpp:
(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(WebCore):
(WebCore::TEST):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- 6:45 PM Changeset in webkit [114826] by
-
- 70 edits in trunk/LayoutTests
Rebaseline more GTK editing, dom, fast tests after <http://trac.webkit.org/changeset/114799>.
- 6:43 PM Changeset in webkit [114825] by
-
- 190 edits in trunk/LayoutTests
Rebaseline more GTK CSS3 tests after <http://trac.webkit.org/changeset/114799>.
- 6:43 PM Acronyms edited by
- (diff)
- 6:36 PM Changeset in webkit [114824] by
-
- 104 edits in trunk/LayoutTests
Rebaseline more GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
- 6:34 PM Changeset in webkit [114823] by
-
- 13 edits in trunk/LayoutTests
Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:30 PM Changeset in webkit [114822] by
-
- 86 edits in trunk/LayoutTests
Rebaseline more GTK css2.1 tests after <http://trac.webkit.org/changeset/114799>.
- 6:25 PM Changeset in webkit [114821] by
-
- 291 edits in trunk/LayoutTests
Rebaseline more GTK css3 and editing tests after <http://trac.webkit.org/changeset/114799>.
- 6:22 PM Changeset in webkit [114820] by
-
- 27 edits in trunk/LayoutTests
Rebaseline GTK fast/block tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/fast/block/float/001-expected.txt:
- platform/gtk/fast/block/float/002-expected.txt:
- platform/gtk/fast/block/float/003-expected.txt:
- platform/gtk/fast/block/float/004-expected.txt:
- platform/gtk/fast/block/float/005-expected.txt:
- platform/gtk/fast/block/float/006-expected.txt:
- platform/gtk/fast/block/float/007-expected.txt:
- platform/gtk/fast/block/float/010-expected.txt:
- platform/gtk/fast/block/float/011-expected.txt:
- platform/gtk/fast/block/float/012-expected.txt:
- platform/gtk/fast/block/float/013-expected.txt:
- platform/gtk/fast/block/float/014-expected.txt:
- platform/gtk/fast/block/float/015-expected.txt:
- platform/gtk/fast/block/float/016-expected.txt:
- platform/gtk/fast/block/float/017-expected.txt:
- platform/gtk/fast/block/float/018-expected.txt:
- platform/gtk/fast/block/margin-collapse/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/002-expected.txt:
- platform/gtk/fast/block/margin-collapse/003-expected.txt:
- platform/gtk/fast/block/margin-collapse/004-expected.txt:
- platform/gtk/fast/block/margin-collapse/005-expected.txt:
- platform/gtk/fast/block/margin-collapse/006-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
- platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
- 6:19 PM Acronyms edited by
- Add JNI, NP, XC (diff)
- 6:17 PM Changeset in webkit [114819] by
-
- 27 edits in trunk/LayoutTests
Rebasing fast/background results after r114799.
- 6:12 PM Changeset in webkit [114818] by
-
- 18 edits in trunk/LayoutTests
Rebaseline more GTK css1 tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/css1/box_properties/border_width_inline-expected.txt:
- platform/gtk/css1/box_properties/clear-expected.txt:
- platform/gtk/css1/box_properties/clear_float-expected.txt:
- platform/gtk/css1/box_properties/float-expected.txt:
- platform/gtk/css1/box_properties/float_margin-expected.txt:
- platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
- platform/gtk/css1/box_properties/height-expected.txt:
- platform/gtk/css1/box_properties/margin-expected.txt:
- platform/gtk/css1/box_properties/margin_bottom-expected.txt:
- platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_left-expected.txt:
- platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_right-expected.txt:
- platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
- platform/gtk/css1/box_properties/margin_top-expected.txt:
- platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
- 6:08 PM Changeset in webkit [114817] by
-
- 4 edits4 adds in trunk
CRASH at WebCore::ReplaceSelectionCommand::removeRedundantMarkup
https://bugs.webkit.org/show_bug.cgi?id=84518
<rdar://problem/10714790>
Reviewed by Simon Fraser.
Source/WebCore:
There are cases where the m_lastNodeInserted is NULL to begin with or
gets deleted by removeRedundantStylesAndKeepStyleSpanInline.
This change handles those cases properly.
Tests: editing/pasteboard/paste-sanitize-crash-1.html
editing/pasteboard/paste-sanitize-crash-2.html
- editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
LayoutTests:
- editing/pasteboard/paste-sanitize-crash-1-expected.txt: Added.
- editing/pasteboard/paste-sanitize-crash-1.html: Added.
- editing/pasteboard/paste-sanitize-crash-2-expected.txt: Added.
- editing/pasteboard/paste-sanitize-crash-2.html: Added.
- 6:06 PM Changeset in webkit [114816] by
-
- 105 edits in trunk/LayoutTests
Rebasing editing results after r114799.
Baselines for more of css2.1 and dom.
- 6:03 PM Acronyms edited by
- Update CF and add UUID (diff)
- 6:03 PM Changeset in webkit [114815] by
-
- 6 edits in trunk/LayoutTests
Rebaseline GTK animations tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/animations/cross-fade-background-image-expected.txt:
- platform/gtk/animations/cross-fade-border-image-source-expected.txt:
- platform/gtk/animations/cross-fade-list-style-image-expected.txt:
- platform/gtk/animations/cross-fade-webkit-mask-box-image-expected.txt:
- platform/gtk/animations/cross-fade-webkit-mask-image-expected.txt:
- 6:02 PM Changeset in webkit [114814] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Tiny change to DomStorage v8 bindings to avoid a relatively expensive test in a couple
of places by reordering the expressions in compound conditions, if (fastTest && moreExpensiveTest)
https://bugs.webkit.org/show_bug.cgi?id=84500
Reviewed by Kentaro Hara.
No new tests, no new functionality.
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageGetter):
(WebCore::V8Storage::namedPropertyQuery):
- 5:59 PM Acronyms edited by
- (diff)
- 5:58 PM Changeset in webkit [114813] by
-
- 4 edits in trunk
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Reviewed by Anders Carlsson.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Changed to not assume that boxes only
have boxes as siblings.
LayoutTests:
- platform/mac/test_expectations.txt:
- 5:56 PM Changeset in webkit [114812] by
-
- 293 edits in trunk/LayoutTests
Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
Patch by Daniel Bates <dbates@webkit.org> on 2012-04-20
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/basic/comments-expected.txt:
- platform/gtk/css1/basic/containment-expected.txt:
- platform/gtk/css1/basic/contextual_selectors-expected.txt:
- platform/gtk/css1/basic/grouping-expected.txt:
- platform/gtk/css1/basic/id_as_selector-expected.txt:
- platform/gtk/css1/basic/inheritance-expected.txt:
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css1/box_properties/border-expected.txt:
- platform/gtk/css1/box_properties/border_bottom-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_color-expected.txt:
- platform/gtk/css1/box_properties/border_color_inline-expected.txt:
- platform/gtk/css1/box_properties/border_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left-expected.txt:
- platform/gtk/css1/box_properties/border_left_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left_width-expected.txt:
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right-expected.txt:
- platform/gtk/css1/box_properties/border_right_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right_width-expected.txt:
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_style-expected.txt:
- platform/gtk/css1/box_properties/border_style_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top-expected.txt:
- platform/gtk/css1/box_properties/border_top_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top_width-expected.txt:
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_width-expected.txt:
- platform/gtk/css1/cascade/cascade_order-expected.txt:
- platform/gtk/css1/cascade/important-expected.txt:
- platform/gtk/css1/classification/display-expected.txt:
- platform/gtk/css1/classification/list_style-expected.txt:
- platform/gtk/css1/classification/list_style_image-expected.txt:
- platform/gtk/css1/classification/list_style_position-expected.txt:
- platform/gtk/css1/classification/list_style_type-expected.txt:
- platform/gtk/css1/classification/white_space-expected.txt:
- platform/gtk/css1/color_and_background/background-expected.txt:
- platform/gtk/css1/color_and_background/background_attachment-expected.txt:
- platform/gtk/css1/color_and_background/background_color-expected.txt:
- platform/gtk/css1/color_and_background/background_image-expected.txt:
- platform/gtk/css1/color_and_background/background_position-expected.txt:
- platform/gtk/css1/color_and_background/background_repeat-expected.txt:
- platform/gtk/css1/color_and_background/color-expected.txt:
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/gtk/css1/font_properties/font-expected.txt:
- platform/gtk/css1/font_properties/font_family-expected.txt:
- platform/gtk/css1/font_properties/font_size-expected.txt:
- platform/gtk/css1/font_properties/font_style-expected.txt:
- platform/gtk/css1/font_properties/font_variant-expected.txt:
- platform/gtk/css1/font_properties/font_weight-expected.txt:
- platform/gtk/css1/formatting_model/canvas-expected.txt:
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/gtk/css1/formatting_model/inline_elements-expected.txt:
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css1/pseudo/anchor-expected.txt:
- platform/gtk/css1/pseudo/firstletter-expected.txt:
- platform/gtk/css1/pseudo/firstline-expected.txt:
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/line_height-expected.txt:
- platform/gtk/css1/text_properties/text_align-expected.txt:
- platform/gtk/css1/text_properties/text_decoration-expected.txt:
- platform/gtk/css1/text_properties/text_indent-expected.txt:
- platform/gtk/css1/text_properties/text_transform-expected.txt:
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css1/units/color_units-expected.txt:
- platform/gtk/css1/units/length_units-expected.txt:
- platform/gtk/css1/units/percentage_units-expected.txt:
- platform/gtk/css1/units/urls-expected.txt:
- 5:50 PM Changeset in webkit [114811] by
-
- 79 edits in trunk/LayoutTests
Rebaseline GTK CSS1 tests after <http://trac.webkit.org/changeset/114799>.
- platform/gtk/css1/basic/class_as_selector-expected.txt:
- platform/gtk/css1/basic/comments-expected.txt:
- platform/gtk/css1/basic/containment-expected.txt:
- platform/gtk/css1/basic/contextual_selectors-expected.txt:
- platform/gtk/css1/basic/grouping-expected.txt:
- platform/gtk/css1/basic/id_as_selector-expected.txt:
- platform/gtk/css1/basic/inheritance-expected.txt:
- platform/gtk/css1/box_properties/acid_test-expected.txt:
- platform/gtk/css1/box_properties/border-expected.txt:
- platform/gtk/css1/box_properties/border_bottom-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
- platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_color-expected.txt:
- platform/gtk/css1/box_properties/border_color_inline-expected.txt:
- platform/gtk/css1/box_properties/border_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left-expected.txt:
- platform/gtk/css1/box_properties/border_left_inline-expected.txt:
- platform/gtk/css1/box_properties/border_left_width-expected.txt:
- platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right-expected.txt:
- platform/gtk/css1/box_properties/border_right_inline-expected.txt:
- platform/gtk/css1/box_properties/border_right_width-expected.txt:
- platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_style-expected.txt:
- platform/gtk/css1/box_properties/border_style_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top-expected.txt:
- platform/gtk/css1/box_properties/border_top_inline-expected.txt:
- platform/gtk/css1/box_properties/border_top_width-expected.txt:
- platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
- platform/gtk/css1/box_properties/border_width-expected.txt:
- platform/gtk/css1/cascade/cascade_order-expected.txt:
- platform/gtk/css1/cascade/important-expected.txt:
- platform/gtk/css1/classification/display-expected.txt:
- platform/gtk/css1/classification/list_style-expected.txt:
- platform/gtk/css1/classification/list_style_image-expected.txt:
- platform/gtk/css1/classification/list_style_position-expected.txt:
- platform/gtk/css1/classification/list_style_type-expected.txt:
- platform/gtk/css1/classification/white_space-expected.txt:
- platform/gtk/css1/color_and_background/background-expected.txt:
- platform/gtk/css1/color_and_background/background_attachment-expected.txt:
- platform/gtk/css1/color_and_background/background_color-expected.txt:
- platform/gtk/css1/color_and_background/background_image-expected.txt:
- platform/gtk/css1/color_and_background/background_position-expected.txt:
- platform/gtk/css1/color_and_background/background_repeat-expected.txt:
- platform/gtk/css1/color_and_background/color-expected.txt:
- platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
- platform/gtk/css1/font_properties/font-expected.txt:
- platform/gtk/css1/font_properties/font_family-expected.txt:
- platform/gtk/css1/font_properties/font_size-expected.txt:
- platform/gtk/css1/font_properties/font_style-expected.txt:
- platform/gtk/css1/font_properties/font_variant-expected.txt:
- platform/gtk/css1/font_properties/font_weight-expected.txt:
- platform/gtk/css1/formatting_model/canvas-expected.txt:
- platform/gtk/css1/formatting_model/floating_elements-expected.txt:
- platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
- platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
- platform/gtk/css1/formatting_model/inline_elements-expected.txt:
- platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
- platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
- platform/gtk/css1/pseudo/anchor-expected.txt:
- platform/gtk/css1/pseudo/firstletter-expected.txt:
- platform/gtk/css1/pseudo/firstline-expected.txt:
- platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
- platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
- platform/gtk/css1/text_properties/letter_spacing-expected.txt:
- platform/gtk/css1/text_properties/line_height-expected.txt:
- platform/gtk/css1/text_properties/text_align-expected.txt:
- platform/gtk/css1/text_properties/text_decoration-expected.txt:
- platform/gtk/css1/text_properties/text_indent-expected.txt:
- platform/gtk/css1/text_properties/text_transform-expected.txt:
- platform/gtk/css1/text_properties/vertical_align-expected.txt:
- platform/gtk/css1/text_properties/word_spacing-expected.txt:
- platform/gtk/css1/units/color_units-expected.txt:
- platform/gtk/css1/units/length_units-expected.txt:
- platform/gtk/css1/units/percentage_units-expected.txt:
- platform/gtk/css1/units/urls-expected.txt:
- 5:38 PM Acronyms created by
- 5:33 PM Changeset in webkit [114810] by
-
- 147 edits in trunk/LayoutTests
Rebasing editing results after r114799.
- platform/gtk/editing/deleting/4922367-expected.txt:
- platform/gtk/editing/deleting/5099303-expected.txt:
- platform/gtk/editing/deleting/5126166-expected.txt:
- platform/gtk/editing/deleting/5144139-2-expected.txt:
- platform/gtk/editing/deleting/5206311-1-expected.txt:
- platform/gtk/editing/deleting/5272440-expected.txt:
- platform/gtk/editing/deleting/5369009-expected.txt:
- platform/gtk/editing/deleting/5433862-2-expected.txt:
- platform/gtk/editing/deleting/5483370-expected.txt:
- platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3857753-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3865854-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3928305-fix-expected.txt:
- platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
- platform/gtk/editing/deleting/delete-4083333-fix-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/gtk/editing/deleting/delete-and-undo-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/gtk/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/gtk/editing/execCommand/4580583-1-expected.txt:
- platform/gtk/editing/execCommand/4580583-2-expected.txt:
- platform/gtk/editing/execCommand/4641880-1-expected.txt:
- platform/gtk/editing/execCommand/4641880-2-expected.txt:
- platform/gtk/editing/execCommand/4747450-expected.txt:
- platform/gtk/editing/execCommand/4916402-expected.txt:
- platform/gtk/editing/execCommand/4916541-expected.txt:
- platform/gtk/editing/execCommand/4924441-expected.txt:
- platform/gtk/editing/execCommand/5080333-1-expected.txt:
- platform/gtk/editing/execCommand/5080333-2-expected.txt:
- platform/gtk/editing/execCommand/5136770-expected.txt:
- platform/gtk/editing/execCommand/5138441-expected.txt:
- platform/gtk/editing/execCommand/5142012-1-expected.txt:
- platform/gtk/editing/execCommand/5142012-2-expected.txt:
- platform/gtk/editing/execCommand/5190926-expected.txt:
- platform/gtk/editing/execCommand/5481523-expected.txt:
- platform/gtk/editing/execCommand/5482023-expected.txt:
- platform/gtk/editing/execCommand/5569741-expected.txt:
- platform/gtk/editing/execCommand/create-list-with-hr-expected.txt:
- platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/gtk/editing/input/emacs-ctrl-o-expected.txt:
- platform/gtk/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/gtk/editing/inserting/12882-expected.txt:
- platform/gtk/editing/inserting/4278698-expected.txt:
- platform/gtk/editing/inserting/4840662-expected.txt:
- platform/gtk/editing/inserting/4875189-1-expected.txt:
- platform/gtk/editing/inserting/4875189-2-expected.txt:
- platform/gtk/editing/inserting/4959067-expected.txt:
- platform/gtk/editing/inserting/4960120-1-expected.txt:
- platform/gtk/editing/inserting/4960120-2-expected.txt:
- platform/gtk/editing/inserting/5002441-expected.txt:
- platform/gtk/editing/inserting/5058163-1-expected.txt:
- platform/gtk/editing/inserting/5058163-2-expected.txt:
- platform/gtk/editing/inserting/5156401-2-expected.txt:
- platform/gtk/editing/inserting/5418891-expected.txt:
- platform/gtk/editing/inserting/5510537-expected.txt:
- platform/gtk/editing/inserting/5549929-2-expected.txt:
- platform/gtk/editing/inserting/5549929-3-expected.txt:
- platform/gtk/editing/inserting/6703873-expected.txt:
- platform/gtk/editing/inserting/before-after-input-element-expected.txt:
- platform/gtk/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/gtk/editing/inserting/editable-html-element-expected.txt:
- platform/gtk/editing/inserting/editable-inline-element-expected.txt:
- platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
- platform/gtk/editing/inserting/editing-empty-divs-expected.txt:
- platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3778059-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
- platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
- platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-01-expected.txt:
- platform/gtk/editing/inserting/insert-at-end-02-expected.txt:
- platform/gtk/editing/pasteboard/3976872-expected.txt:
- platform/gtk/editing/pasteboard/4076267-2-expected.txt:
- platform/gtk/editing/pasteboard/4076267-3-expected.txt:
- platform/gtk/editing/pasteboard/4076267-expected.txt:
- platform/gtk/editing/pasteboard/4242293-expected.txt:
- platform/gtk/editing/pasteboard/4631972-expected.txt:
- platform/gtk/editing/pasteboard/4641033-expected.txt:
- platform/gtk/editing/pasteboard/4806874-expected.txt:
- platform/gtk/editing/pasteboard/4944770-1-expected.txt:
- platform/gtk/editing/pasteboard/4944770-2-expected.txt:
- platform/gtk/editing/pasteboard/4947130-expected.txt:
- platform/gtk/editing/pasteboard/7955-expected.txt:
- platform/gtk/editing/pasteboard/8145-1-expected.txt:
- platform/gtk/editing/pasteboard/8145-2-expected.txt:
- platform/gtk/editing/pasteboard/8145-3-expected.txt:
- platform/gtk/editing/selection/13804-expected.txt:
- platform/gtk/editing/selection/14971-expected.txt:
- platform/gtk/editing/selection/3690703-2-expected.txt:
- platform/gtk/editing/selection/3690703-expected.txt:
- platform/gtk/editing/selection/3690719-expected.txt:
- platform/gtk/editing/selection/4397952-expected.txt:
- platform/gtk/editing/selection/4402375-expected.txt:
- platform/gtk/editing/selection/4776665-expected.txt:
- platform/gtk/editing/selection/4818145-expected.txt:
- platform/gtk/editing/selection/4866671-expected.txt:
- platform/gtk/editing/selection/4889598-expected.txt:
- platform/gtk/editing/selection/6476-expected.txt:
- platform/gtk/editing/selection/7152-1-expected.txt:
- platform/gtk/editing/selection/7152-2-expected.txt:
- platform/gtk/editing/style/4916887-expected.txt:
- platform/gtk/editing/style/5017613-1-expected.txt:
- platform/gtk/editing/style/5017613-2-expected.txt:
- platform/gtk/editing/style/5046875-1-expected.txt:
- platform/gtk/editing/style/5046875-2-expected.txt:
- platform/gtk/editing/style/5065910-expected.txt:
- platform/gtk/editing/style/5084241-expected.txt:
- platform/gtk/editing/style/5228141-expected.txt:
- platform/gtk/editing/style/5279521-expected.txt:
- platform/gtk/editing/style/apple-style-editable-mix-expected.txt:
- platform/gtk/editing/style/block-style-001-expected.txt:
- platform/gtk/editing/style/block-style-002-expected.txt:
- platform/gtk/editing/style/block-style-003-expected.txt:
- platform/gtk/editing/style/block-styles-007-expected.txt:
- platform/gtk/editing/style/create-block-for-style-001-expected.txt:
- platform/gtk/editing/style/create-block-for-style-002-expected.txt:
- platform/gtk/editing/style/create-block-for-style-003-expected.txt:
- platform/gtk/editing/style/create-block-for-style-004-expected.txt:
- platform/gtk/editing/undo/4063751-expected.txt:
- platform/gtk/editing/undo/redo-typing-001-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-combined-delete-expected.txt:
- platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-delete-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
- platform/gtk/editing/undo/undo-forward-delete-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/list-delete-003-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-after-expected.txt:
- platform/gtk/editing/unsupported-content/list-type-before-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-001-expected.txt:
- platform/gtk/editing/unsupported-content/table-delete-002-expected.txt:
- 5:31 PM Changeset in webkit [114809] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG should optimize int8 and int16 arrays on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84503
Reviewed by Oliver Hunt.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::ldrsb):
(JSC::ARMv7Assembler::ldrsh):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::load16Signed):
(JSC::MacroAssemblerARMv7::load8Signed):
- bytecode/PredictedType.h:
(JSC::isActionableIntMutableArrayPrediction):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt8Array):
(JSC::DFG::Node::shouldSpeculateInt16Array):
- 5:27 PM Changeset in webkit [114808] by
-
- 4 edits in trunk/Source
[chromium] Remove special case for recreating layers during sync
https://bugs.webkit.org/show_bug.cgi?id=84458
Reviewed by James Robinson.
Source/WebCore:
We no longer delete layers on the impl side, unless it is due to
deleting the layer on webkit side. So we will no longer have a
situation where we need to push properties from an old
LayerChromium to a new CCLayerImpl.
- platform/graphics/chromium/TreeSynchronizer.cpp:
(WebCore::TreeSynchronizer::reuseOrCreateCCLayerImpl):
Source/WebKit/chromium:
- tests/TreeSynchronizerTest.cpp:
- 5:25 PM WikiStart edited by
- Add link to "Acronyms" page in "Documentation" section (diff)
- 5:22 PM Changeset in webkit [114807] by
-
- 4 edits in trunk/Source
[chromium] WebFilterOperations API does not compile or dynamically link
https://bugs.webkit.org/show_bug.cgi?id=84506
Reviewed by James Robinson.
Non-inline functions need WEBKIT_EXPORT in their declarations,
and the type used in the WebPrivateOwnPtr needs to be forward-
declared even when WEBKIT_IMPLEMENTATION is not defined.
Source/Platform:
- chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):
(WebFilterOperations):
Source/WebCore:
- platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebFilterOperations::initialize):
- 5:18 PM Changeset in webkit [114806] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114333.
http://trac.webkit.org/changeset/114333
https://bugs.webkit.org/show_bug.cgi?id=84511
perf regression (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- dom/Node.cpp:
- dom/Node.h:
(WebCore):
(Node):
(WebCore::Node::isElementNode):
(WebCore::Node::isContainerNode):
(WebCore::Node::isTextNode):
(WebCore::Node::isHTMLElement):
(WebCore::Node::isSVGElement):
(WebCore::Node::isStyledElement):
(WebCore::Node::isShadowRoot):
(WebCore::Node::parentNode):
(WebCore::Node::parentNodeGuaranteedHostFree):
- 5:16 PM Changeset in webkit [114805] by
-
- 21 edits3 adds in trunk
IndexedDB: Support get/getKey(keyRange)
https://bugs.webkit.org/show_bug.cgi?id=83638
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-20
Reviewed by Ojan Vafai.
Source/WebCore:
Support IDBKeyRange as a parameter to all the various get/getKey
combinations. Switches the existing get/getKey versions that use
IDBKey directly to start using IDBKeyRange.only().
Test: storage/indexeddb/get-keyrange.html
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::get):
(WebCore):
(WebCore::IDBIndex::getKey):
- Modules/indexeddb/IDBIndex.h:
(IDBIndex):
- Modules/indexeddb/IDBIndex.idl:
- Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore):
(WebCore::IDBIndexBackendImpl::getByRangeInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):
(WebCore::IDBIndexBackendImpl::getKeyByRangeInternal):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- Modules/indexeddb/IDBIndexBackendImpl.h:
(IDBIndexBackendImpl):
- Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore):
- Modules/indexeddb/IDBObjectStore.h:
(IDBObjectStore):
- Modules/indexeddb/IDBObjectStore.idl:
- Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
(WebCore::IDBObjectStoreBackendImpl::getInternal):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
- Modules/indexeddb/IDBObjectStoreBackendInterface.h:
(IDBObjectStoreBackendInterface):
Source/WebKit/chromium:
Hook up WebKit API to the new get/getKey implementations.
- src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::get):
(WebKit):
(WebKit::IDBIndexBackendProxy::getKey):
- src/IDBIndexBackendProxy.h:
(IDBIndexBackendProxy):
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
LayoutTests:
Tests for all the get/getKey combinations when using a range.
- storage/indexeddb/get-keyrange-expected.txt: Added.
- storage/indexeddb/get-keyrange.html: Added.
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/resources/get-keyrange.js: Added.
(test):
(openDatabase):
(setVersion):
(deleteExisting):
(addData):
(getRangeOnlyTest.request.onsuccess):
(getRangeOnlyTest):
(getRangeLowerTest.request.onsuccess):
(getRangeLowerTest):
(getRangeLowerOpenTest.request.onsuccess):
(getRangeLowerOpenTest):
(getRangeUpperTest.request.onsuccess):
(getRangeUpperTest):
(getRangeLowerFractionTest.request.onsuccess):
(getRangeLowerFractionTest):
(getOutOfRangeTest.request.onsuccess):
(getOutOfRangeTest):
(getBadOnlyTest.request.onsuccess):
(getBadOnlyTest):
(getNullTest):
- 5:12 PM Changeset in webkit [114804] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r114789.
http://trac.webkit.org/changeset/114789
https://bugs.webkit.org/show_bug.cgi?id=84515
Caused 5 tests to fail on mac/ (Requested by jernoble on
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- 5:12 PM Changeset in webkit [114803] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add an ability to find the extent of a callframe
https://bugs.webkit.org/show_bug.cgi?id=84513
Reviewed by Filip Pizlo.
Add a function to get the extent of a callframe and
use that function for a new assertion to make sure the
RegisterFile makes sense using that information.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
(JSC):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
- 5:07 PM Changeset in webkit [114802] by
-
- 11 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=84512 Repurpose ActiveDOMObject::WillShowDialog to WillDeferLoading
Reviewed by Eric Carlson.
Source/WebCore:
No new tests. (Refactor, no behavior change)
Rename WillShowDialog to WillDeferLoading:
- dom/ActiveDOMObject.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend):
Don't take a ReasonForSuspension argument anymore, just use WillDeferLoading:
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
Don't pass a Reason anymore as WillDeferLoading is used by default:
- page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.
- Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runOpenPanel):
Source/WebKit/chromium:
PageGroupLoadDeferrer's don't take a ReasonForSuspension argument anymore;
They just use WillDeferLoading by default.
- src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop):
- 5:01 PM Changeset in webkit [114801] by
-
- 133 edits in trunk/LayoutTests
Unreviewed, GTK css2.1 rebaseline after r114796 and r114799.
- platform/gtk/css2.1: Massive Update.
- 4:49 PM Changeset in webkit [114800] by
-
- 20 edits in trunk/Source
[chromium] Plumb a compositor surface ready notification through to the threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=84305
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Adrienne Walker.
Source/Platform:
Add a notification for when the compositor surface associated with a given view is ready to use.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Plumb setSurfaceReady through to the scheduler.
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setSurfaceReady):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setSurfaceReady):
(WebCore):
(WebCore::CCThreadProxy::setSurfaceReadyOnImplThread):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Adds a notification to WebWidget for when the compositor surface is ready to use. This exists to fix a race
condition when WebKit requires that we enter compositing mode but we haven't completed initialization of the
native window/etc backing the WebWidget, and we can't block for this initialization to complete without inducing
deadlocks. In this situation, we proceed as usual except that we can't attempt to use the compositor context or
it will fail.
- public/WebWidget.h:
(WebWidget):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::setCompositorSurfaceReady):
(WebKit):
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositorSurfaceReady):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebViewImpl):
- 4:47 PM Changeset in webkit [114799] by
-
- 2 edits in trunk/Source/WebKit/gtk
[Gtk][WK1] Use mock scrollbars when testing
https://bugs.webkit.org/show_bug.cgi?id=79577
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-20
Reviewed by Daniel Bates.
Enable mock scrollbars if running DumpRenderTree.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
- 4:32 PM Changeset in webkit [114798] by
-
- 2 edits1 add in trunk/LayoutTests
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Reviewed by Simon Fraser.
Add -webkit-filter results to the platforms on which it is enabled.
This required a new platform result for WebKit mac.
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt.
- platform/mac/test_expectations.txt:
- 4:31 PM Changeset in webkit [114797] by
-
- 11 edits3 adds in trunk/Source
[Chromium] Call memoryUsageMB directly
https://bugs.webkit.org/show_bug.cgi?id=84376
Reviewed by Kentaro Hara.
Source/WebCore:
Now that memoryUsageMB has been moved from PlatformSupport.h to
Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/V8GCController.cpp.
That means we need a new MemoryUsageSupport class in
WebCore/platform/ and an implementation in
WebCore/platform/chromium/MemoryUsageSupportChromium.cpp.
Other ports are welcome to implement their memory usage
functions if they wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.
Part of a refactoring series. See tracking bug 82948.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/V8GCController.cpp:
(WebCore):
- platform/MemoryUsageSupport.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
- platform/MemoryUsageSupport.h: Added.
(WebCore):
(MemoryUsageSupport):
- platform/chromium/MemoryUsageSupportChromium.cpp: Added.
(WebCore):
(WebCore::MemoryUsageSupport::memoryUsageMB):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
Part of a refactoring series. See tracking bug 82948.
- src/PlatformSupport.cpp:
(WebCore):
- 4:18 PM Changeset in webkit [114796] by
-
- 3 edits in trunk/Tools
[GTK] Revert changes that disabled Cairo fonts metrics hinting
https://bugs.webkit.org/show_bug.cgi?id=84502
Reviewed by Daniel Bates.
Re-enable Cairo metrics hinting, which seems to ensure consistent results in
reference and pixel test results. This makes our font metrics a bit different
than the Mac port's, but it's a decent price to pay for consistent results.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):
- 4:18 PM Internals_Hackathon edited by
- (diff)
- 4:05 PM BuildingGtk edited by
- (diff)
- 4:04 PM Changeset in webkit [114795] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114784): svg/text/foreignObject-text-clipping-bug.xml failing on Mountain Lion Debug Tests
https://bugs.webkit.org/show_bug.cgi?id=84505
Unreviewed; add new crashing test result to test_expectations.txt.
- platform/mac/test_expectations.txt:
- 4:03 PM Changeset in webkit [114794] by
-
- 2 edits3 adds in trunk/LayoutTests
[EFL] [DRT] Add baselines for the tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84440
Unreviewed, added EFL baselines for passing tests and also skipped two tests
which are failing due to missing implementation.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
- platform/efl/Skipped:
- platform/efl/fast/block/float/avoiding-float-centered-expected.png: Added.
- platform/efl/fast/block/float/avoiding-float-centered-expected.txt: Added.
- platform/efl/fast/events/panScroll-click-hyperlink-expected.txt: Added.
- 3:52 PM Changeset in webkit [114793] by
-
- 4 edits in trunk/Source/JavaScriptCore
Inline the JSArray constructor
https://bugs.webkit.org/show_bug.cgi?id=84416
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-20
Reviewed by Geoffrey Garen.
The constructor is trivial, no reason to jump for it.
This makes the creation of array ~5% faster (on non-trivial cases, no empty arrays).
- runtime/JSArray.cpp:
(JSC):
- runtime/JSArray.h:
(JSC::JSArray::JSArray):
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 3:46 PM April 2012 Meeting edited by
- (diff)
- 3:45 PM April 2012 Meeting edited by
- Adding notes for the keeping the bots green session (diff)
- 3:44 PM April 2012 Keeping the bots green created by
- Notes for the keeping the bots green session
- 3:38 PM Changeset in webkit [114792] by
-
- 2 edits in trunk/Source/WebCore
Re-land. The non-fast scrollable region is now always updated after layout, and frameViewScrollableAreasDidChange has been removed.
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
- 3:35 PM Changeset in webkit [114791] by
-
- 4 edits in trunk/Source
[chromium] Clip TransparencyWin to prevent OOM from large Skia canvas
https://bugs.webkit.org/show_bug.cgi?id=84289
Reviewed by James Robinson.
Source/WebCore:
TransparencyWin will create a Skia canvas of whatever size is passed
in, even if the result will ultimately be clipped. Handle the clip
implicitly and try (in some cases) to create a smaller canvas. This
can happen due to RenderBox::paintBoxDecorations passing a paint rect
down of the entire element's size.
Modes with more complicated transforms (ScaleTransform, UnTransform)
are not handled yet.
Tests: TransparencyWin.ClippedKeepTransformNoLayer
TransparencyWin.ClippedKeepTransformOpaqueCompositeLayer
TransparencyWin.ClippedKeepTransformOpaqueWhiteLayer
- platform/graphics/chromium/TransparencyWin.cpp:
(WebCore::TransparencyWin::computeLayerSize):
Source/WebKit/chromium:
Add a test that would OOM if the layer wasn't clipped. Also, verify
that clipping the canvas doesn't shift pixels around incorrectly.
- tests/TransparencyWinTest.cpp:
(WebCore::testClippedLayerKeepTransform):
(WebCore):
(WebCore::TEST):
- 3:33 PM Changeset in webkit [114790] by
-
- 22 edits in trunk
apple.com top navigation bar appears inside video during full screen exit animation
https://bugs.webkit.org/show_bug.cgi?id=83095
Reviewed by Eric Carlson.
Source/WebCore:
Test: fullscreen/full-screen-exit-animation-stacking-context.html
Only tell ancestors of the full screen element that they are no longer ancestors once
the full screen animation is complete:
- dom/Document.cpp:
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
To facilitate writing reproducible LayoutTests, expose webkitWill/Did/Enter/ExitFullScreen
from the Internals object, so scripts can call them explicitly:
- testing/Internals.cpp:
(WebCore::Internals::webkitWillEnterFullScreenForElement): Call the Document equivalent.
(WebCore::Internals::webkitDidEnterFullScreenForElement): Ditto.
(WebCore::Internals::webkitWillExitFullScreenForElement): Ditto.
(WebCore::Internals::webkitDidExitFullScreenForElement): Ditto.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
Add new WebCore symbols needed by DumpRenderTree to exported symbol list.
- win/WebKit2.def:
- win/WebKit2CFLite.def:
Tools:
Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
Document methods from within the script. This allows subtle timing bugs to be consistently reproduced
from within LayoutTests.
Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
- DumpRenderTree/LayoutTestController.cpp:
(setHasCustomFullScreenBehaviorCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::setHasCustomFullScreenBehavior):
(WTR::LayoutTestController::hasCustomFullScreenBehavior):
- DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
- DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::setHasCustomFullScreenBehavior):
(LayoutTestController::hasCustomFullScreenBehavior):
Query the new methods before calling will/did/Enter/ExitFullScreen:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::enterFullScreenNow):
(WebViewHost::exitFullScreenNow):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:enterFullScreenForElement:listener:]):
(-[UIDelegate webView:exitFullScreenForElement:listener:]):
LayoutTests:
- fullscreen/full-screen-exit-animation-stacking-context-expected.txt: Added.
- fullscreen/full-screen-exit-animation-stacking-context.html: Added.
- platform/mac/fullscreen/full-screen-exit-animation-stacking-context-expected.png: Added.
- 3:33 PM Changeset in webkit [114789] by
-
- 5 edits in trunk/Source/WebCore
media-exit-fullscreen-button (and related enums) is unnecessary and should be removed.
https://bugs.webkit.org/show_bug.cgi?id=84162
Reviewed by Eric Carlson.
No new tests; no change in functionality so covered by existing tests.
Remove the media-exit-fullscreen-button keyword, and rename media-enter-fullscreen-button to
media-fullscreen-button.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/mediaControls.css:
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- 3:32 PM Changeset in webkit [114788] by
-
- 14 edits in trunk/Tools
NRWT: option --skip-pixel-test-if-no-baseline support on DRT
https://bugs.webkit.org/show_bug.cgi?id=72841
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-20
Reviewed by Dirk Pranke
This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
and 'reference_files' fields to the TestInput objects, and use those flags
to select the right driver to use in the DriverProxy.
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.init):
(SingleTestRunner._driver_input):
(SingleTestRunner._run_reftest):
- Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.handle_test_list):
(Worker._update_test_input):
- Scripts/webkitpy/layout_tests/models/test_input.py:
(TestInput):
(TestInput.init):
(TestInput.repr):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver._wrapper_options):
(ChromiumDriver.run_test):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):
- Scripts/webkitpy/layout_tests/port/driver.py:
(DriverInput.init):
(Driver.init):
(DriverProxy.init):
(DriverProxy.run_test):
(DriverProxy.start):
(DriverProxy.cmd_line):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
- Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRT.run):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.write_test_output):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.write_test_output):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.cmd_line):
(WebKitDriver.run_test):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
(TestController):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setIsPixelTest):
- WebKitTestRunner/TestInvocation.h:
(TestInvocation):
- 3:18 PM Changeset in webkit [114787] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Fix compile errors when DEBUG_GL_CALLS is enabled
https://bugs.webkit.org/show_bug.cgi?id=84491
Patch by Alexandre Elias <aelias@google.com> on 2012-04-20
Reviewed by Ojan Vafai.
DEBUG_GL_CALLS had not been used in a while and the mode no longer
compiled when I tried it. I improved the GLC macro to support either
raw pointers or RefPtrs, and to be a single expression in order to
interact properly with if/else blocks. I fixed the cases where we
were passing in the "context" method pointer by mistake, and removed the
now-unnecessary "get()" calls for the RefPtrs.
No new tests. (No-op change in release builds.)
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::clearRenderSurface):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::doNoOp):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::useRenderSurface):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
- 3:15 PM Changeset in webkit [114786] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
- 3:15 PM April 2012 Meeting edited by
- (diff)
- 2:54 PM Changeset in webkit [114785] by
-
- 6 edits in trunk/Source/WebCore
Set m_compositingDependsOnGeometry to false if possible
https://bugs.webkit.org/show_bug.cgi?id=84391
Reviewed by James Robinson.
For some kinds of elements, RenderLayerCompositor has to delay decisions about
compositing until the element's size and/or position are known. This was previsouly
based on the confusingly named m_compositingDependsOnGeometry flag, but another
variant of the same technique, with an additional flag m_compositingNeedsUpdate,
was added in r98627.
Also, once the m_compositingDependsOnGeometry flag was set to true, nothing
set it to false, so every compositing layer update resulted in a computeCompositingRequirements()
pass over the layers.
Rename the m_compositingDependsOnGeometry flag to m_reevaluateCompositingAfterLayout,
and clear the flag when we do a layout-related compositing layer update.
Use the same flag for position:fixed compositing.
This requires RenderLayerCompositor to distinguish between style- and layout-
related updates, requiring some minor refactoring in FrameView.
Should not change behavior.
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::layout):
- page/FrameView.h:
(FrameView):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 2:45 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:41 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:40 PM Changeset in webkit [114784] by
-
- 8 edits2 adds in trunk
Source/WebCore: <rdar://problem/10786000> Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
Test: fast/block/line-layout/selection-highlight-overlap.html
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::selectionRect): Changed to use
selection{Top,Height}AdjustedForPrecedingBlock().
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::inlineSelectionGaps): Ditto.
(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Added. Returns the block which is
likely to contain the selected line just before the first line in this block, if it is
within the same selection root.
- rendering/RenderBlock.h:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock): Added. If the selection
starts before our block, finds the last line in the preceding block and adjusts the selection
top to avoid overlap with that line’s selection bottom.
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::selectionHeightAdjustedForPrecedingBlock): Added. Like
selectionHeight(), but uses selectionTopAdjustedForPrecedingBlock().
LayoutTests: Selection highlights of lines in adjoining blocks can overlap
https://bugs.webkit.org/show_bug.cgi?id=84489
Reviewed by Anders Carlsson.
- fast/block/line-layout/selection-highlight-overlap-expected.html: Added.
- fast/block/line-layout/selection-highlight-overlap.html: Added.
- 2:37 PM Changeset in webkit [114783] by
-
- 2 edits in trunk/Source/WebCore
Crash in getOrDrawNodeHighlight after r114659
https://bugs.webkit.org/show_bug.cgi?id=84486
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2012-04-20
Reviewed by Daniel Bates.
No new tests. Fixes a crash in test: inspector/elements/elements-panel-selection-on-refresh.html.
- inspector/DOMNodeHighlighter.cpp:
- 2:33 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:29 PM Changeset in webkit [114782] by
-
- 11 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=84490
PageGroupLoadDeferrer needs to take a ReasonForSuspension argument
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests. (Refactor, no change in behavior)
- Make PageGroupLoadDeferrer take a ReasonForSuspension argument so it can pass it along.
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
- page/PageGroupLoadDeferrer.h:
- Change suspendScheduledTasks to take a ReasonForSuspension.
- As long as we're changing Document.h, add a m_suspendedScheduledTasks flag and some ASSERTs to catch what would be epically wrong behavior in the future.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
- dom/Document.h:
- Pass ActiveDOMObject::WillShowDialog along to all PageGroupLoadDeferrers, as it used to be the default behavior
- page/Chrome.cpp:
(WebCore::Chrome::runModal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::shouldInterruptJavaScript):
Source/WebKit/blackberry:
- Api/WebPageGroupLoadDeferrer.cpp:
(BlackBerry::WebKit::WebPageGroupLoadDeferrer::WebPageGroupLoadDeferrer): Pass along ActiveDOMObject::WillShowDialog,
which used to be the default
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow): Pass along ActiveDOMObject::WillShowDialog, which used to be the default.
(WebCore::ChromeClientBlackBerry::runOpenPanel): Ditto.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebView::willEnterModalLoop): Pass along ActiveDOMObject::WillShowDialog, which used
to be the default.
- 2:25 PM Changeset in webkit [114781] by
-
- 2 edits in trunk/Source/WebCore
Scrolling after going to a find-in-page result jumps to the top of the page
https://bugs.webkit.org/show_bug.cgi?id=84485
<rdar://problem/11273734>
Reviewed by Beth Dakin.
If we're both updating the requested scroll position and entering slow mode in the same commit, the
probable main thread scroll position should be the requested scroll position.
- page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
- 2:23 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:22 PM Changeset in webkit [114780] by
-
- 479 edits4 copies in branches/subpixellayout
Merge trunk changes up until 114777 into subpixel branch.
- 2:22 PM April 2012 Write Your Own Render Object edited by
- (diff)
- 2:19 PM Changeset in webkit [114779] by
-
- 6 edits2 adds in trunk/Source/WebKit
[BlackBerry] Expose WebViewportArguments to WebPageClient
https://bugs.webkit.org/show_bug.cgi?id=84471
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-04-20
Reviewed by Antonio Gomes.
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Implement the ability for the WebPageClient to specify a fallback
virtual viewport to be used whenever a meta viewport tag is not
present in the HTML. This can drastically impact apparent layout.
This patch is designed to provide a classic "Column View" style of
layout without breaking the web by simply exposing meta viewport
arguments to WebPageClients.
Note: As a side effect of this change. the WebPagePrivate::
recomputeVirtualViewportFromViewportArguments method no longer
modifies the targetDensityDpi property of the m_viewportArguments.
However this does not affect the class because that property itself
means nothing to us. Only the computeViewportArguments method from
WebCore uses it, and the currentViewportArguments object we pass
into that method has the adjusted targetDensityDpi value as before.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserViewportArguments):
(WebKit):
(BlackBerry::WebKit::WebPage::resetUserViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
- Api/WebPage.h:
(WebKit):
- Api/WebPage_p.h:
(WebPagePrivate):
- Api/WebViewportArguments.cpp: Added.
(WebKit):
(BlackBerry::WebKit:::d):
(BlackBerry::WebKit::WebViewportArguments::~WebViewportArguments):
(BlackBerry::WebKit::WebViewportArguments::initialScale):
(BlackBerry::WebKit::WebViewportArguments::setInitialScale):
(BlackBerry::WebKit::WebViewportArguments::minimumScale):
(BlackBerry::WebKit::WebViewportArguments::setMinimumScale):
(BlackBerry::WebKit::WebViewportArguments::maximumScale):
(BlackBerry::WebKit::WebViewportArguments::setMaximumScale):
(BlackBerry::WebKit::WebViewportArguments::width):
(BlackBerry::WebKit::WebViewportArguments::setWidth):
(BlackBerry::WebKit::WebViewportArguments::height):
(BlackBerry::WebKit::WebViewportArguments::setHeight):
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::userScalable):
(BlackBerry::WebKit::WebViewportArguments::setUserScalable):
(BlackBerry::WebKit::WebViewportArguments::operator==):
(BlackBerry::WebKit::WebViewportArguments::operator!=):
- Api/WebViewportArguments.h: Added.
(WebCore):
(WebKit):
- 2:17 PM Changeset in webkit [114778] by
-
- 6 edits in trunk/Source
Avoid synchronously recalculating the nonFastScrollableRegion when the ScrollableArea set changes
https://bugs.webkit.org/show_bug.cgi?id=84470
Patch by James Robinson <jamesr@chromium.org> on 2012-04-20
Reviewed by Anders Carlsson.
Source/WebCore:
When a scrollable area is added or removed, we shouldn't recalculate the nonFastScrollableRegion synchronously
since this is slow, the RenderObject tree might not be in an up-to-date state, and we'll typically do layout
soon anyway.
- page/FrameView.cpp:
(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
- page/scrolling/ScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
Source/WebKit/chromium:
Trigger a layout when a plugin becomes or stops being scrollable so the nonFastScrollableRegion
can be updated.
- src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::scrollbarCreated):
(WebKit::ScrollbarGroup::scrollbarDestroyed):
- 2:09 PM April 2012 Write Your Own Render Object created by
- 2:02 PM Changeset in webkit [114777] by
-
- 5 edits4 copies in trunk/LayoutTests
Rebaselining svg/css/getComputedStyle-basic.html after
http://trac.webkit.org/changeset/114766
Not reviewed.
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt.
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- 1:48 PM April 2012 Meeting edited by
- (diff)
- 1:47 PM April 2012 Meeting edited by
- (diff)
- 1:46 PM EFLWebKit edited by
- Update libsoup version (diff)
- 1:28 PM Changeset in webkit [114776] by
-
- 4 edits in trunk/Tools
[EFL] Make it possible to define offline storage quota per origin
https://bugs.webkit.org/show_bug.cgi?id=84170
Improved LayoutTestController::setDatabaseQuota to set quota based on
origin which was causing some tests to fail. Also align the default
quota for testing (5MB) with others ports.
When dumpDatabaseCallbacks is set to true by, also dump some database
information when quota is exceed, which is also required by some tests.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
(drtViewAdd):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setDatabaseQuota):
- 1:22 PM Changeset in webkit [114775] by
-
- 2 edits in trunk/Source/WebCore
Fix use of LayoutUnits in DOMNodeHighlighter
https://bugs.webkit.org/show_bug.cgi?id=84472
Reviewed by Eric Seidel.
Fix use of subpixel units and rounding in new code introduced in r114659.
No new tests, no change in functionality.
- inspector/DOMNodeHighlighter.cpp:
- 1:07 PM Changeset in webkit [114774] by
-
- 2 edits in trunk/LayoutTests
Enable Encrypted Media tests on Chromium now that Chromium side is committed
https://bugs.webkit.org/show_bug.cgi?id=84474
Unreviewed enabling of layout tests.
Patch by David Dorwin <ddorwin@chromium.org> on 2012-04-20
- platform/chromium/test_expectations.txt:
- 1:03 PM Changeset in webkit [114773] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r114764-r114766): svg/css/getComputedStyle-basic.xhtml failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84483
Unreviewed; add new failing test to expected results.
- platform/mac/test_expectations.txt:
- 12:55 PM Changeset in webkit [114772] by
-
- 6 edits in trunk/Source/JavaScriptCore
Heap should cancel GC timer at the start of the collection
https://bugs.webkit.org/show_bug.cgi?id=84477
Reviewed by Geoffrey Garen.
Currently the Heap cancels the GC timer at the conclusion of a collection.
We should change this to be at the beginning because something (e.g. a finalizer)
could call didAbandonObjectGraph(), which will schedule the timer, but then
we'll immediately unschedule the timer at the conclusion of the collection,
thus potentially preventing large swaths of memory from being reclaimed in a timely manner.
- API/JSBase.cpp:
(JSGarbageCollect): Remove outdated fix-me and remove check for whether the Heap is
busy or not, since we're just scheduling a timer to run a GC in the future.
- heap/Heap.cpp:
(JSC::Heap::collect): Rename didCollect to willCollect and move the call to the
top of Heap::collect.
- runtime/GCActivityCallback.cpp: Renamed didCollect to willCollect.
(JSC::DefaultGCActivityCallback::willCollect):
- runtime/GCActivityCallback.h: Ditto.
(JSC::GCActivityCallback::willCollect):
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp: Ditto.
(JSC::DefaultGCActivityCallback::willCollect):
- 12:36 PM Changeset in webkit [114771] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSGarbageCollect should not call collectAllGarbage()
https://bugs.webkit.org/show_bug.cgi?id=84476
Reviewed by Geoffrey Garen.
- API/JSBase.cpp:
(JSGarbageCollect): Notify the Heap's GCActivityCallback using didAbandonObjectGraph.
- 12:11 PM Changeset in webkit [114770] by
-
- 2 edits in trunk/Source/WebCore
Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false
https://bugs.webkit.org/show_bug.cgi?id=84178
Reviewed by Adam Treat.
Patch by Antonio Gomes <agomes@rim.com>
No new tests since it is not easily testable.
When a port has both delegatesScrolling and constrainsScrollingToContentEdge set to FALSE
(i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled
position still gets the position clamped to the content size edges.
Patch relaxes ::adjustScrollPositionWithinRange in that sense in order to track the actual scroll
position.
Note: ScrollView::setScrollOffset already does something similar.
- platform/ScrollView.cpp:
(WebCore::ScrollView::adjustScrollPositionWithinRange):
- 12:09 PM Changeset in webkit [114769] by
-
- 495 edits23 copies in branches/subpixellayout
Merge trunk changes up until 114767 into subpixel branch.
- 12:07 PM April 2012 Meeting edited by
- (diff)
- 12:04 PM Changeset in webkit [114768] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r114535.
http://trac.webkit.org/changeset/114535
https://bugs.webkit.org/show_bug.cgi?id=84475
It might have caused V8 crashes. (Requested by pfeldman_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
- bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
- bindings/v8/V8Proxy.h:
(V8Proxy):
- 11:51 AM April 2012 Reducing build systems edited by
- Add clarifying sentence to section "Another approach: scripts; … (diff)
- 11:46 AM Changeset in webkit [114767] by
-
- 2 edits in branches/subpixellayout/Source/WebCore
Misc platform fixes on branch.
- 11:42 AM April 2012 Reducing build systems edited by
- Fix formatting; spelling/grammer corrections (diff)
- 11:41 AM Changeset in webkit [114766] by
-
- 9 edits in trunk
-webkit-filter missing from computed style enumeration
https://bugs.webkit.org/show_bug.cgi?id=84468
Source/WebCore:
Reviewed by Timothy Hatcher.
CSSComputedStyleDeclaration has a list of properties that it exposes.
While the computed style for filter was available, the property wasn't
listed and hence missing in clients like the Web Inspector.
Covered by existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore): add CSSPropertyWebkitFilter
LayoutTests:
Reviewed by Timothy Hatcher.
Added new results for platforms that have filters enabled. Hopefully
I got them all. Luckily there were already platform results for this
test in each case.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 11:35 AM April 2012 Meeting edited by
- (diff)
- 11:34 AM April 2012 JavaScriptCore Roundup created by
- 11:29 AM April 2012 Meeting edited by
- (diff)
- 11:29 AM April 2012 Meeting edited by
- (diff)
- 11:28 AM April 2012 Reducing build systems created by
- First pass at notes.
- 11:27 AM April 2012 Canvas Canvass created by
- 11:13 AM Changeset in webkit [114765] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Move bot to Lion Debug to help catch up.
- 11:12 AM Changeset in webkit [114764] by
-
- 5 edits in trunk/Source
[win] Update windows platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=84283
Reviewed by Eric Seidel.
Source/WebCore:
No new tests, no change in functionality.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::pixelSnappedElementRect):
Use pixel snapped values when computing screenRect.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):
Cast client padding to ints as they are guaranteed to align with device pixels.
Source/WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::accLocation):
- 11:03 AM April 2012 Meeting edited by
- (diff)
- 11:02 AM April 2012 Meeting edited by
- (diff)
- 11:01 AM April 2012 Meeting edited by
- (diff)
- 11:00 AM Scrolling Session Meeting 2012 created by
- 10:57 AM Changeset in webkit [114763] by
-
- 6 edits in trunk/Source
[chromium] Some filters require inflating damage rect in CCDamageTracker
https://bugs.webkit.org/show_bug.cgi?id=84373
Reviewed by James Robinson.
Source/WebCore:
When a layer is blurred, damaged pixels are blurred out into a radius
and their damage should be expanded to include total blurred region.
Unit test: CCDamageTrackerTest.verifyDamageForBlurredSurface
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::updateDamageTrackingState):
(WebCore::CCDamageTracker::expandDamageRectWithForegroundFilters):
(WebCore):
- platform/graphics/chromium/cc/CCDamageTracker.h:
(WebCore):
(CCDamageTracker):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::trackDamageForAllSurfaces):
Source/WebKit/chromium:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::emulateDrawingOneFrame):
(WebKitTests::TEST_F):
(WebKitTests):
- 10:56 AM April 2012 Meeting edited by
- Add hyperlink to discussion notes for session "Reducing build systems" (diff)
- 10:54 AM Changeset in webkit [114762] by
-
- 978 edits65 copies30 deletes in branches/subpixellayout
Merge trunk changes up until 114758 into subpixel branch.
- 10:53 AM Changeset in webkit [114761] by
-
- 4 edits in trunk/Source
[chromium] Don't crash when scrolling empty layer tree
https://bugs.webkit.org/show_bug.cgi?id=84455
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-20
Reviewed by James Robinson.
Source/WebCore:
Do not try to calculate render passes when there are no layers in the
layer tree.
Added new unit test.
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
Source/WebKit/chromium:
Try to scroll an empty layer tree.
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):
- 10:46 AM Changeset in webkit [114760] by
-
- 5 edits in trunk
Ensure text is centered for default captions
https://bugs.webkit.org/show_bug.cgi?id=84450
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-20
Reviewed by Eric Carlson.
Source/WebCore:
Updated existing test.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getDisplayTree): Added default width.
LayoutTests:
Updated test to cover default positioning of captions.
- media/track/track-cue-rendering-expected.txt: Updated.
- media/track/track-cue-rendering.html: Updated.
- 10:31 AM Changeset in webkit [114759] by
-
- 21 edits23 adds in trunk/LayoutTests
[EFL][DRT] Gardening SVG tests and timeouts
https://bugs.webkit.org/show_bug.cgi?id=84462
Unreviewed, EFL gardening.
A number of SVG Batik text tests needed rebaselining likely due to bug 83264.
Also, moving some tests that fail to call notifyDone to test_expectations with appropriate bugs filed.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-20
- platform/efl/svg/batik/text/longTextOnPath-expected.png: Added.
- platform/efl/svg/batik/text/longTextOnPath-expected.txt:
- platform/efl/svg/batik/text/smallFonts-expected.png: Added.
- platform/efl/svg/batik/text/smallFonts-expected.txt:
- platform/efl/svg/batik/text/textAnchor2-expected.png: Added.
- platform/efl/svg/batik/text/textAnchor3-expected.png: Added.
- platform/efl/svg/batik/text/textDecoration-expected.png: Added.
- platform/efl/svg/batik/text/textDecoration-expected.txt:
- platform/efl/svg/batik/text/textDecoration2-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.txt:
- platform/efl/svg/batik/text/textEffect2-expected.png: Added.
- platform/efl/svg/batik/text/textEffect2-expected.txt:
- platform/efl/svg/batik/text/textEffect3-expected.png: Added.
- platform/efl/svg/batik/text/textEffect3-expected.txt:
- platform/efl/svg/batik/text/textFeatures-expected.png: Added.
- platform/efl/svg/batik/text/textFeatures-expected.txt:
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Added.
- platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
- platform/efl/svg/batik/text/textLayout-expected.png: Added.
- platform/efl/svg/batik/text/textLayout-expected.txt:
- platform/efl/svg/batik/text/textLayout2-expected.png: Added.
- platform/efl/svg/batik/text/textLayout2-expected.txt:
- platform/efl/svg/batik/text/textLength-expected.png: Added.
- platform/efl/svg/batik/text/textLength-expected.txt:
- platform/efl/svg/batik/text/textOnPath2-expected.png: Added.
- platform/efl/svg/batik/text/textOnPath2-expected.txt:
- platform/efl/svg/batik/text/textOnPathSpaces-expected.png: Added.
- platform/efl/svg/batik/text/textOnPathSpaces-expected.txt:
- platform/efl/svg/batik/text/textPCDATA-expected.png: Added.
- platform/efl/svg/batik/text/textPosition-expected.png: Added.
- platform/efl/svg/batik/text/textPosition-expected.txt:
- platform/efl/svg/batik/text/textPosition2-expected.png: Added.
- platform/efl/svg/batik/text/textPosition2-expected.txt:
- platform/efl/svg/batik/text/textProperties-expected.png: Added.
- platform/efl/svg/batik/text/textProperties-expected.txt:
- platform/efl/svg/batik/text/textStyles-expected.png: Added.
- platform/efl/svg/batik/text/textStyles-expected.txt:
- platform/efl/svg/batik/text/verticalText-expected.png: Added.
- platform/efl/svg/batik/text/verticalText-expected.txt:
- platform/efl/svg/batik/text/xmlSpace-expected.png: Added.
- platform/efl/svg/batik/text/xmlSpace-expected.txt:
- platform/efl/test_expectations.txt:
- 10:23 AM April 2012 HTML5 Media Element & WebAudio created by
- Initial Commit
- 10:23 AM April 2012 Meeting edited by
- (diff)
- 10:13 AM Changeset in webkit [114758] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: open file dialog is not centered.
https://bugs.webkit.org/show_bug.cgi?id=84464
Reviewed by Yury Semikhatsky.
There was an error in the positioning logic.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.position):
- 10:11 AM Importing Thirdparty tests edited by
- (diff)
- 10:11 AM April 2012 Meeting edited by
- (diff)
- 10:10 AM Importing Thirdparty tests created by
- 10:09 AM April 2012 Meeting edited by
- (diff)
- 10:09 AM Changeset in webkit [114757] by
-
- 28 edits in branches/chromium/1084/Source
Merge 113677 - [chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Currently we add gutter quads on the NonCompositedContentHost layer,
which lies above another visible layer - the rubberband layer on mac.
For this reason, on mac, gutter quads were disabled, as well as forcing
the NCCH layer to draw, in order to make the rubberband layer appear.
We move the logic for adding gutter quads into CCRenderPass, and add
gutter quads for all pixels that are visible through the viewport.
This allows us to stop special-casing the NCCH layer, and allows us
to skip drawing the layer equally with other layers. We remove the
backgroundCoversViewport() flag entirely.
In order to do this, we fix a bug in the occlusion tracker, that
allowed opaque() layers with skipsDraw to occlude, by making
the visibleContentOpaqueRegion() method on the layer classes
also return the opaque region for non-tiled layers, always use
its value in the occlusion tracker.
Unit test: CCLayerTreeHostImplTest.viewportCovered
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
(WebCore::TiledLayerChromium::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
(WebCore::CCLayerImpl::visibleContentOpaqueRegion):
(WebCore):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::appendQuads):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setBackgroundColor):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::backgroundColor):
(WebCore::CCLayerTreeHostImpl::setBackgroundColor):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):
(WebCore::CCOcclusionTrackerBase::computeVisibleRegionInScreen):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
(WebCore):
- platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
(CCRenderPass):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::visibleContentOpaqueRegion):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::skipsDraw):
(CCTiledLayerImpl):
Source/WebKit/chromium:
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setBackgroundColor):
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setBackgroundColor):
(WebKit):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setBackgroundColor):
(WebKit):
(WebKit::WebViewImplContentPainter::paint):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::BlendStateCheckLayer::appendQuads):
(WebKitTests::TEST_F):
(WebKitTests):
- tests/CCLayerTreeHostTest.cpp:
(WTF):
(CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::CCLayerTreeHostTestCommit):
(WTF::CCLayerTreeHostTestCommit::beginTest):
(WTF::CCLayerTreeHostTestCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommit::afterTest):
(WTF::TEST_F):
(TestLayerChromium):
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::TestContentLayerChromium::TestContentLayerChromium):
(WebKitTests::TestContentLayerChromium::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerChromium::setOpaqueContentsRect):
(TestContentLayerChromium):
(WebKitTests::TestContentLayerImpl::TestContentLayerImpl):
(TestContentLayerImpl):
(WebKitTests::TestContentLayerImpl::visibleContentOpaqueRegion):
(WebKitTests::TestContentLayerImpl::setOpaqueContentsRect):
- tests/CCTiledLayerImplTest.cpp:
- tests/LayerChromiumTest.cpp:
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10146014
- 10:08 AM Instrumentation and Metrics created by
- 10:07 AM Changeset in webkit [114756] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as TIMEOUT since it's too slow for even SLOW at the moment.
- platform/chromium/test_expectations.txt:
- 10:05 AM Changeset in webkit [114755] by
-
- 1 edit1 delete in trunk/Source/WebCore
[Qt] PlatformMouseEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84437
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-20
Reviewed by Kenneth Rohde Christiansen.
- platform/qt/PlatformMouseEventQt.cpp: Removed.
- 9:39 AM UpdatingBugzilla edited by
- (diff)
- 9:28 AM Changeset in webkit [114754] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: follow up to r114729: more @return annotations added.
https://bugs.webkit.org/show_bug.cgi?id=84447
Reviewed by Yury Semikhatsky.
- inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.ResourceRevision.prototype.get content):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame.prototype._addRequest):
- inspector/front-end/ResourceUtils.js:
(String.prototype.asParsedURL):
- 9:24 AM Changeset in webkit [114753] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: migrate from ScriptsNavigator to NavigatorView in the Styles panel
https://bugs.webkit.org/show_bug.cgi?id=84459
Reviewed by Yury Semikhatsky.
Now that NavigatorView has all the functionality we need, we can use it.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._itemSelected):
(WebInspector.StylesPanel.prototype._showFile):
- inspector/front-end/navigatorView.css:
(.navigator-tabbed-pane .tabbed-pane-content):
(.navigator-tabbed-pane .navigator-container):
(.navigator-tabbed-pane .navigator):
(.navigator-tabbed-pane .tabbed-pane-header):
(.navigator-tabbed-pane .tabbed-pane-header-contents):
- inspector/front-end/scriptsPanel.css:
- 9:15 AM Changeset in webkit [114752] by
-
- 3 edits in trunk/LayoutTests
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203
Reviewed by Simon Fraser.
This test compares CSS div's n a ref-test with a single spec for transform-origin
to SVG rects with multipe specs for transform-origin that are supposed
to all be equivalent, such as [50%,50%] and [center, center]. It fails
due to one-pixel differences on Chromium.
This change renders as many divs in the ref-test as SVG rects in the
test, and ends up with the same result. It seems likely that one of
the several specs that are used is computed slightly differently
(maybe 50% is not the same as center).
- platform/chromium/test_expectations.txt:
- svg/transforms/transform-origin-css-property-expected.xhtml:
- 9:13 AM Changeset in webkit [114751] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove empty svg/misc directory
https://bugs.webkit.org/show_bug.cgi?id=79917
Unreviewed test directory cleanup.
- svg/misc: Removed.
- svg/misc/resources: Removed.
- 9:11 AM Changeset in webkit [114750] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG anchor on use fails
https://bugs.webkit.org/show_bug.cgi?id=81122
Reviewed by Rob Buis.
Adding a ref test for this bug. This seems to have been fixed, but a
regression test is in order.
- svg/custom/anchor-on-use-expected.svg: Added.
- svg/custom/anchor-on-use.svg: Added.
- 9:08 AM Changeset in webkit [114749] by
-
- 7 edits2 adds in trunk/Source/WebKit
[EFL] Add Security Origin API
https://bugs.webkit.org/show_bug.cgi?id=84023
Source/WebKit:
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- PlatformEfl.cmake:
Source/WebKit/efl:
Added an API to get a Security Origin handle from a Ewk_Frame. This is
needed for fine grained security policy. This new API will also allow
to define quota and get usage information of a Web Storage based on its
Security Origin.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-20
Reviewed by Antonio Gomes.
- ewk/EWebKit.h:
- ewk/ewk_frame.cpp:
(ewk_frame_security_origin_get):
- ewk/ewk_frame.h:
- ewk/ewk_security_origin.cpp: Added.
(ewk_security_origin_protocol_get):
(ewk_security_origin_host_get):
(ewk_security_origin_port_get):
(ewk_security_origin_web_database_usage_get):
(ewk_security_origin_web_database_quota_get):
(ewk_security_origin_web_database_quota_set):
(ewk_security_origin_free):
(ewk_security_origin_new):
- ewk/ewk_security_origin.h: Added.
- 8:45 AM Changeset in webkit [114748] by
-
- 7 edits2 adds in trunk/Source/WebCore
Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)
https://bugs.webkit.org/show_bug.cgi?id=84235
Added buttons for navigating on seiarch matches in inspector panel
through button clicks as well.
Patch by Sam D <dsam2912@gmail.com> on 2012-04-20
Reviewed by Pavel Feldman.
No new tests / ux enhanced for search functionality
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- inspector/front-end/Images/searchNext.png: Added.
- inspector/front-end/Images/searchPrev.png: Added.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._createSearchNavigationButton):
(WebInspector.SearchController.prototype._populateSearchNavigationButtons):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
(.toolbar-search-item):
(#search):
(#toolbar-search-navigation-control):
(.toolbar-search-navigation-label):
(.toolbar-search-navigation-label:hover):
(.toolbar-search-navigation-icon-prev , .toolbar-search-navigation-icon-next):
(.toolbar-search-navigation-icon-prev):
(.toolbar-search-navigation-icon-next):
- inspector/front-end/inspector.html:
- 8:38 AM Changeset in webkit [114747] by
-
- 2 edits in trunk/LayoutTests
2012-04-20 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
as slow in release mode.
- platform/chromium/test_expectations.txt:
- 8:22 AM BuildBot edited by
- Pulseaudio troubleshooting (diff)
- 8:17 AM Deprecating features and vendor prefixes edited by
- (diff)
- 7:54 AM Changeset in webkit [114746] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update
https://bugs.webkit.org/show_bug.cgi?id=73991
Unmark passing tests (Vista & Win7):
fast/text/international/complex-character-based-fallback.html
fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
fast/text/international/chromium-complex-text-non-printable.html
platform/win/fast/text/uniscribe-missing-glyph.html
fast/text/international/bidi-neutral-run.html
fast/text/international/thai-line-breaks.html
- platform/chromium/test_expectations.txt:
- 7:36 AM Changeset in webkit [114745] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-20
- DEPS:
- 6:33 AM Changeset in webkit [114744] by
-
- 10 edits3 adds in trunk
Web Inspector: extract NavigatorView and NavigatorOverlayController from ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=84441
Reviewed by Yury Semikhatsky.
Source/WebCore:
- Moves NavigatorOverlayController out of ScriptsNavigator
- Extracts NavigatorView from ScriptsNavigator and makes ScriptsNavigator contain 3 NavigatorView instances (one per tab)
- Subclasses SnippetsNavigatorView and leaves it within ScriptsNavigator.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/NavigatorOverlayController.js: Added.
(WebInspector.NavigatorOverlayController.prototype.wasShown):
(WebInspector.NavigatorOverlayController.prototype._createNavigatorControlButton):
(WebInspector.NavigatorOverlayController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
- inspector/front-end/NavigatorView.js: Added.
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._updateScriptTitle.get if):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._scriptSelected):
(WebInspector.NavigatorView.prototype._removeUISourceCode.get while):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._showScriptFoldersSettingChanged):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorView.prototype.handleContextMenu):
(WebInspector.NavigatorTreeOutline):
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
(WebInspector.NavigatorTreeOutline.prototype.searchStarted):
(WebInspector.NavigatorTreeOutline.prototype.searchFinished):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
(WebInspector.BaseNavigatorTreeElement.prototype.get titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
(WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.get folderIdentifier):
(WebInspector.NavigatorFolderTreeElement.prototype.get isDomain):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement):
(WebInspector.NavigatorScriptTreeElement.prototype.get uiSourceCode):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
(WebInspector.NavigatorScriptTreeElement.prototype.onspace):
(WebInspector.NavigatorScriptTreeElement.prototype._onclick):
(WebInspector.NavigatorScriptTreeElement.prototype.onenter):
(WebInspector.NavigatorScriptTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
(WebInspector.ScriptsNavigator.prototype.reset):
(WebInspector.SnippetsNavigatorView):
(WebInspector.SnippetsNavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype._getOrCreateSnippetEvaluationsFolderTreeElement):
(WebInspector.SnippetsNavigatorView.prototype.handleContextMenu):
(WebInspector.SnippetsNavigatorView.prototype._fileRenamed):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/navigatorView.css: Added.
(.navigator-domain-tree-item .icon):
(.navigator-folder-tree-item .icon):
(.navigator-script-tree-item .icon):
(.navigator li):
(.navigator :focus li.selected):
(.navigator li.selected .selection):
(.navigator :focus li.selected .selection):
(.navigator .search-match-found li.selected .selection):
(.navigator .search-match-not-found li.selected .selection):
(.navigator .searching li.selected .selection):
(.navigator .icon):
(.navigator .base-navigator-tree-element-title):
(.navigator .base-navigator-tree-element-title.editing):
(.navigator-tree-search-box):
(.navigator-tree-search-box.visible):
(.navigator-tree-search-box > input):
- inspector/front-end/scriptsPanel.css:
LayoutTests:
- http/tests/inspector/debugger-test.js:
- 5:59 AM Changeset in webkit [114743] by
-
- 56 edits3 deletes in trunk/LayoutTests
[Chromium] Unreviewed test results update
http://code.google.com/p/chromium/issues/detail?id=123809
Rebaseline tests after Skia roll. There was a comment saying
"Rebaseline after Skia rev. 3695 lands", while Skia is
already at r3729.
- platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
- platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusDouble05-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-linux/svg/hixie/perf/001-expected.png:
- platform/chromium-linux/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-leopard/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac-leopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
- platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
- platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-mac/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-mac/fast/borders/border-styles-split-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac/fast/writing-mode/border-styles-vertical-lr-expected.png:
- platform/chromium-mac/fast/writing-mode/border-styles-vertical-rl-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Removed.
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Removed.
- platform/chromium-mac/svg/hixie/perf/001-expected.png:
- platform/chromium-mac/svg/hixie/perf/002-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
- platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
- platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png:
- platform/chromium-win/fast/borders/border-radius-groove-02-expected.png:
- platform/chromium-win/fast/borders/border-styles-split-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
- platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
- platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/chromium-win/svg/hixie/perf/001-expected.png:
- platform/chromium-win/svg/hixie/perf/002-expected.png:
- platform/chromium/test_expectations.txt:
- platform/efl/fast/borders/border-radius-complex-inner-expected.txt: Removed.
- 5:30 AM Changeset in webkit [114742] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=29359
Unmark passing fast/forms/date/date-appearance.html
- platform/chromium/test_expectations.txt:
- 5:07 AM Changeset in webkit [114741] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=83826
Remove now passing test from expectations:
fast/text/drawBidiText.html
fast/text/international/bidi-listbox-atsui.html
- platform/chromium/test_expectations.txt:
- 4:58 AM Changeset in webkit [114740] by
-
- 14 edits in trunk/Source/WebCore
Web Inspector: make ScriptNavigatorController use views only, rename to NavigatorOverlayController.
https://bugs.webkit.org/show_bug.cgi?id=84352
Reviewed by Vsevolod Vlasov.
This change makes navigator controller use view interfaces only. Focus machinery has been refactored in order
to make it possible: now all view ancestors can either override "focus" or "defaultFocusedElement" method
with latter method being preferred.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.defaultFocusedElement):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.defaultFocusedElement):
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
(WebInspector.Panel.prototype.defaultFocusedElement):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.NavigatorOverlayController.prototype._hidePinnedNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
- inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
- inspector/front-end/StylesPanel.js:
(WebInspector.StylesPanel):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.get view):
(WebInspector.TabbedEditorContainer.prototype.get visibleView):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.defaultFocusedElement):
- inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.defaultFocusedElement):
(WebInspector.TextEditorMainPanel.prototype.defaultFocusedElement):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.defaultFocusedElement):
- inspector/front-end/View.js:
(WebInspector.View.prototype._collectViewHierarchy):
(WebInspector.View.prototype.defaultFocusedElement):
(WebInspector.View.prototype.setDefaultFocusedElement):
(WebInspector.View.prototype.focus):
- 4:57 AM Changeset in webkit [114739] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
http://code.google.com/p/chromium/issues/detail?id=124313
Mark fast/css/font-face-opentype.html and fast/css/font-face-woff.html
as crashing on Debug XP.
- platform/chromium/test_expectations.txt:
- 4:48 AM Changeset in webkit [114738] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84432
Mark several fast/filesystem tests as failing on Windows.
- platform/chromium/test_expectations.txt:
- 3:56 AM Changeset in webkit [114737] by
-
- 4 edits in trunk
[EFL] [DRT] Send double click event from EventSender
https://bugs.webkit.org/show_bug.cgi?id=82867
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-20
Reviewed by Daniel Bates.
Tools:
Add support for EFL DumpRenderTree EventSender to send
double click events.
- DumpRenderTree/efl/EventSender.cpp:
(sendMouseEvent):
LayoutTests:
Unskip tests connected with double click simulation.
- platform/efl/Skipped:
- 3:54 AM Changeset in webkit [114736] by
-
- 8 edits in trunk
[GTK] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=42432
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Added WebTiming support to the GTK+ port. WebTiming allows
developers to collect detailed network timing information per
resource. It requires the new SoupMessage's "network-event"
signal.
- GNUmakefile.am:
- bindings/gobject/GNUmakefile.am:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::wroteBodyCallback):
(WebCore::requestStartedCallback):
(WebCore::networkEventCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::defaultSession):
Tools:
Build web timing by default whenever build-webkit is used.
- Scripts/build-webkit:
LayoutTests:
Removed some tests that are working fine now after adding Web
Timing support.
- platform/gtk/test_expectations.txt:
- 3:28 AM Changeset in webkit [114735] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
PASS/TIMEOUT on Mac and Win debug.
- platform/chromium/test_expectations.txt:
- 3:02 AM Changeset in webkit [114734] by
-
- 6 edits in trunk
Not reviewed: fixed chromium sanity tests for inspector via assigning last path component
to entire url for parsed urls with invalid specs.
Source/WebCore:
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
Source/WebKit/chromium:
- src/js/Tests.js:
(.TestSuite.prototype._scriptsAreParsed):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- 2:44 AM Changeset in webkit [114733] by
-
- 2 edits in trunk/Tools
[EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
https://bugs.webkit.org/show_bug.cgi?id=84430
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- 2:30 AM Changeset in webkit [114732] by
-
- 51 edits in trunk/Source/WebCore
Unreviewed, rolling out r114401.
http://trac.webkit.org/changeset/114401
https://bugs.webkit.org/show_bug.cgi?id=84161
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(NativeToJSValue):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSStyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMTokenListCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Float64ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Int8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint16ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint32ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
- 2:29 AM Changeset in webkit [114731] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114440.
http://trac.webkit.org/changeset/114440
https://bugs.webkit.org/show_bug.cgi?id=84173
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- 2:28 AM Changeset in webkit [114730] by
-
- 18 edits in trunk/Source/WebCore
Unreviewed, rolling out r114519.
http://trac.webkit.org/changeset/114519
https://bugs.webkit.org/show_bug.cgi?id=84202
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- 2:15 AM Changeset in webkit [114729] by
-
- 13 edits in trunk/Source/WebCore
Web Inspector: replace @type annotation with @return annotation for getters
https://bugs.webkit.org/show_bug.cgi?id=84362
Reviewed by Yury Semikhatsky.
Otherwise, compiler does not check for errors.
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get searchConfig):
- inspector/front-end/BreakpointManager.js:
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.requestContent):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/ScriptsNavigator.js:
- inspector/front-end/Settings.js:
- inspector/front-end/SnippetsModel.js:
- inspector/front-end/SplitView.js:
- inspector/front-end/TabbedEditorContainer.js:
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab):
- inspector/front-end/TextEditorModel.js:
- inspector/front-end/TimelinePresentationModel.js:
- 1:49 AM Changeset in webkit [114728] by
-
- 5 edits in trunk/Source
[Chromium] Call cacheMetadata directly
https://bugs.webkit.org/show_bug.cgi?id=84415
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandle::cacheMetadata):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 1:41 AM Changeset in webkit [114727] by
-
- 5 edits in trunk/Source
[Chromium] Call stopSharedTimer directly
https://bugs.webkit.org/show_bug.cgi?id=84418
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/SharedTimerChromium.cpp:
(WebCore::stopSharedTimer):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 12:50 AM Changeset in webkit [114726] by
-
- 1 edit4 deletes in trunk/LayoutTests
[Chromium] Unreviewed test results update.
Remove unneeded test results.
- platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- 12:42 AM Changeset in webkit [114725] by
-
- 2 edits in trunk/Tools
REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
https://bugs.webkit.org/show_bug.cgi?id=84424
Reviewed by Mark Rowe.
Let Windows and Chromium have their own list of files to copy.
- BuildSlaveSupport/built-product-archive:
(removeDirectoryIfExists):
(copyBuildFiles):
(archiveBuiltProduct):
- 12:40 AM Changeset in webkit [114724] by
-
- 3 edits2 adds in trunk
DOMFileSystem::scheduleCallback() crashes on file() call after reload.
https://bugs.webkit.org/show_bug.cgi?id=76461
DOMFileSystem::scheduleCallback() is unavailable when the page in unloading, so we should
avoid using it in callback.
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-04-20
Reviewed by David Levin.
Source/WebCore:
Test: fast/filesystem/file-after-reload-crash.html
- Modules/filesystem/DOMFileSystem.cpp:
(WebCore):
LayoutTests:
- fast/filesystem/file-after-reload-crash-expected.txt: Added.
- fast/filesystem/file-after-reload-crash.html: Added.
- 12:37 AM April 2012 Meeting edited by
- (diff)
- 12:33 AM Changeset in webkit [114723] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84427
Mark platform/chromium/editing/spelling/delete-misspelled-word.html as
timing out on Linux debug.
- platform/chromium/test_expectations.txt:
- 12:27 AM Changeset in webkit [114722] by
-
- 7 edits1 add in trunk
[EFL] Add setting API for author and user styles.
https://bugs.webkit.org/show_bug.cgi?id=82860
Patch by Kamil Blank <k.blank@samsung.com> on 2012-04-20
Reviewed by Daniel Bates.
Source/WebKit/efl:
Add missing implementation setAuthorAndUserStylesEnabled to EFL's
DumpRenderTreeSupport.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
Tools:
Implementation of setAuthorAndUserStylesEnabled.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setAuthorAndUserStylesEnabled):
LayoutTests:
Enable test connected with setAuthorAndUserStylesEnabled.
- platform/efl/Skipped:
- platform/efl/fast/css/disabled-author-styles-expected.txt: Added.
Apr 19, 2012:
- 11:58 PM Changeset in webkit [114721] by
-
- 6 edits in trunk
[EFL] Missing keycode translation for space key
https://bugs.webkit.org/show_bug.cgi?id=84153
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebCore:
Map space key to Unicode value in createKeyMap(), and also set
correct keyname 'space' for space key in createWindowsKeyMap().
Tests: fast/html/details-keyboard-show-hide.html
fast/forms/button-spacebar-click.html
- platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
Tools:
Set keyname for space key before dispatching event.
- DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue):
LayoutTests:
Unskip tests connected with space key.
- platform/efl/Skipped:
- 11:53 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:47 PM Changeset in webkit [114720] by
-
- 3 edits2 adds in trunk/Tools
[GTK] Allow to use WebInspector in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=84143
Reviewed by Martin Robinson.
- GNUmakefile.am: Add new files to compilation.
- GtkLauncher/LauncherInspectorWindow.c: Added.
(launcherInspectorWindowFinalize):
(launcher_inspector_window_init):
(launcher_inspector_window_class_init):
(inspectedURIChanged): Update the window title based on current
inspected URI.
(showInspectorWindow): Show inspector window.
(closeInspectorWindow): Hide inspector window.
(launcherInspectorWindowNew): Create an inspector window.
(launcherInspectorWindowGetWebView): Return the inspected web view.
- GtkLauncher/LauncherInspectorWindow.h: Added.
- GtkLauncher/main.c:
(inspectorInspectWebViewCb): Create an inspector window.
(createBrowser): Connect to inspect-web-view signal of the view
inspector.
- 11:44 PM Changeset in webkit [114719] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Ignore resources while replacing content in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=79777
Reviewed by Philippe Normand.
- UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didSendRequestForResource): Return early if resources is Null.
(didReceiveResponseForResource): Ditto.
(didReceiveContentLengthForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewLoadChanged): Clear resources before checking
whether we are replacing content.
(webkitWebViewIsReplacingContentOrDidReplaceContent): Helper
function to check whether view is replacing content or current
content is replaced.
(webkitWebViewResourceLoadStarted): Do not create resources when
replacing content.
(webkitWebViewGetLoadingWebResource): Ignore when replacing
content. Also add an assert when getting a loading resources to
make sure we only return Null when replacing content.
(webkitWebViewRemoveLoadingWebResource): Ditto.
(webkitWebViewResourceLoadFinished): Ditto.
- UIProcess/API/gtk/tests/TestResources.cpp:
(replacedContentResourceLoadStartedCallback):
(testWebViewResourcesReplacedContent):
(beforeAll):
- 11:18 PM Changeset in webkit [114718] by
-
- 3 edits2 adds in trunk
Inserting empty html moves caret.
https://bugs.webkit.org/show_bug.cgi?id=71771
Patch by Antaryami Pandia <antaryami.pandia@motorola.com> on 2012-04-19
Reviewed by Ryosuke Niwa.
Source/WebCore:
When we place the cursor in the middle of a text node and try to insert some text
between, then we split text node. But in this case we have nothing to insert since
the string to be inserted is empty. So the check for fragments should precedes the
call to code block containing splitTextNode.
Test: editing/inserting/insert-empty-html.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
LayoutTests:
Test inserting empty html.
- editing/inserting/insert-empty-html-expected.txt: Added.
- editing/inserting/insert-empty-html.html: Added.
- 10:35 PM Changeset in webkit [114717] by
-
- 4 edits in trunk/Source
Versioning.
- 10:23 PM Changeset in webkit [114716] by
-
- 1 copy in tags/Safari-536.8
New Tag.
- 9:49 PM WebComponentsStatusMeetingNotes edited by
- formatting! (diff)
- 8:35 PM Changeset in webkit [114715] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update HTTP connection per host limit in ResourceRequestBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=84380
Patch by Tay Grigg <tgrigg@rim.com> on 2012-04-19
Reviewed by George Staikos.
Reviewed Internally by: George Rizkalla, Lyon Chen
Set the limit on the http connection count per host to the default
of 10000, queue the requests in the networking layer instead,
this should increase parallelism at the WebKit layer to remove
any potential bottlenecks.
- platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
- 8:29 PM Changeset in webkit [114714] by
-
- 8 edits in trunk
Media Stream API: Piece of code cleanup for the chromium port
https://bugs.webkit.org/show_bug.cgi?id=84328
Patch by Jeremy Mao <yujie.mao@intel.com> on 2012-04-19
Reviewed by Kent Tamura.
Source/WebKit/chromium:
Remove some deprecated interfaces.
No new tests. No behavior changes.
- public/WebUserMediaClient.h:
Remove deprecated requestUserMedia interface.
- public/WebUserMediaRequest.h:
Remove deprecated requestSucceeded interface.
- src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
Use the requestUserMedia split sources implementation.
- src/WebUserMediaRequest.cpp:
Remove deprecated requestSucceeded implementation.
Tools:
WebUserMediaClientMock use an old requestUserMedia interface and
Replace it with the new interface.
- DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):
Remove the old requestUserMedia and replace it with the new.
- DumpRenderTree/chromium/WebUserMediaClientMock.h:
(WebUserMediaClientMock):
- 7:32 PM Changeset in webkit [114713] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r114711.
http://trac.webkit.org/changeset/114711
https://bugs.webkit.org/show_bug.cgi?id=84412
Many tests crash in RenderObject::container() (Requested by
dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
- 7:07 PM Changeset in webkit [114712] by
-
- 1 edit2 moves12 deletes in trunk/LayoutTests
Not reviewed, re-update baselines for new tests
added in http://trac.webkit.org/changeset/114666
and then modified in http://trac.webkit.org/changeset/114685
- platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- platform/chromium/fast/ruby/floating-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt.
- platform/chromium/fast/ruby/positioned-ruby-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt.
- 6:40 PM Changeset in webkit [114711] by
-
- 2 edits in trunk/Source/WebCore
computeNonFastScrollableRegion needs to traverse the entire frame tree
https://bugs.webkit.org/show_bug.cgi?id=84409
<rdar://problem/11285741>
Reviewed by Dan Bernstein.
Now that scrollable areas won't be in the set of scrollable areas unless they are actually scrollable, we need to look for scrollable
areas in the entire frame tree since there can be a scrollable frame that's a subframe of a non-scrollable frame for example.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::computeNonFastScrollableRegion):
Traverse the entire frame tree looking for scrollable areas. Also, remove the scrollability checks because scrollable areas will only be
in the set if they have scrollbars that are enabled.
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewScrollableAreasDidChange):
computeNonFastScrollableRegion now takes the main frame.
- 6:40 PM Changeset in webkit [114710] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/css/CSSImportRule.cpp
Merge 114350 - Stack overflow in CSS parser caused by recursive stylesheet import
https://bugs.webkit.org/show_bug.cgi?id=83545
Patch by David Barr <davidbarr@chromium.org> on 2012-04-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: http/tests/css/css-imports-redirect-cycle.html
- css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
LayoutTests:
- http/tests/css/css-imports-redirect-cycle-expected.txt: Added.
- http/tests/css/css-imports-redirect-cycle.css: Added.
- http/tests/css/css-imports-redirect-cycle.html: Added.
BUG=122606
TBR=commit-queue@webkit.org
Review URL: https://chromiumcodereview.appspot.com/10143006
- 6:14 PM Changeset in webkit [114709] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp
Merge 114267 - [chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
Disable kashida justification if using Skia to draw.
Test: fast/text/international/arabic-justify.html
- platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
- fast/text/international/arabic-justify.html: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
- platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
- platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
- platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
- platform/qt/fast/text/international/arabic-justify-expected.txt: Added.
TBR=xji@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10154002
- 5:59 PM Internals_Hackathon edited by
- (diff)
- 5:58 PM Changeset in webkit [114708] by
-
- 7 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB: Prep for changing keyPath return type
https://bugs.webkit.org/show_bug.cgi?id=84208
To introduce Array-type key paths (see http://webkit.org/b/84207) the keyPath() accessors
on WebIDBObjectStore and WebIDBIndex need to change return type. To do so requires temporarily
changing the method names to keyPathString with compatibility shims (on the WebKit side)
then switching the implementation in the Chromium port in a follow-up patch.
Reviewed by Kent Tamura.
- public/WebIDBIndex.h:
(WebKit::WebIDBIndex::keyPath):
(WebKit::WebIDBIndex::keyPathString):
- public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::keyPath):
(WebKit::WebIDBObjectStore::keyPathString):
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::keyPathString):
- src/WebIDBIndexImpl.h:
(WebIDBIndexImpl):
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::keyPathString):
- src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
- 5:50 PM Changeset in webkit [114707] by
-
- 4 edits in trunk/Source/WebCore
Focus ring on wikipedia gets blobs when you type
https://bugs.webkit.org/show_bug.cgi?id=84407
<rdar://problem/11011847>
Reviewed by Dan Bernstein.
Make it possible to override the focus ring visible rect from layer drawing code.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Call ThemeMac::setFocusRingClipRect to set the focus ring clip rect while drawing.
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
If there's an active focus ring visible rect, use it. Otherwise, fall back to the previous behavior
and just return the view's visible rect.
(WebCore::ThemeMac::setFocusRingClipRect):
Update the focus clip rect.
- 5:48 PM Changeset in webkit [114706] by
-
- 1 edit2 deletes in trunk/LayoutTests
Rollout r114674.
New tests added in http://trac.webkit.org/changeset/114685 made the
platform results added in http://trac.webkit.org/changeset/114674
unnecessary.
- platform/mac/fast/ruby/floating-ruby-text-expected.txt: Removed.
- platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Removed.
- 5:37 PM Changeset in webkit [114705] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] ASSERT(m_thread == currentThread()) on Mac when threaded rendering is enabled for the Qt scenegraph
https://bugs.webkit.org/show_bug.cgi?id=84278
Reviewed by Noam Rosenthal.
Delete the whole layer tree on UI side when paint node is deleted and force resync of the layers when
page becomes visible again.
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::purgeBackingStores):
- UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::purgeGLResources):
(WebKit::WebLayerTreeRenderer::appendUpdate):
(WebKit::WebLayerTreeRenderer::setActive):
(WebKit):
- UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
- UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::ContentsSGNode):
- WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::purgeBackingStores):
- 5:33 PM Changeset in webkit [114704] by
-
- 2 edits in trunk/LayoutTests
Partial rollout of r114673.
Test plugins/npp-set-window-called-during-destruction.html passes on mac-wk2,
but fails on mac. Update test_expectations so that both results are expected.
- platform/mac/test_expectations.txt:
- 5:33 PM Changeset in webkit [114703] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r114690.
http://trac.webkit.org/changeset/114690
https://bugs.webkit.org/show_bug.cgi?id=84408
Broke GlueSerializeTest.BackwardsCompatibleTest in Chromium
test_shell_tests (Requested by dimich on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 5:23 PM Deprecating features and vendor prefixes created by
- 5:17 PM Changeset in webkit [114702] by
-
- 25 edits in trunk
Exception stack traces aren't complete when the exception starts in native code
https://bugs.webkit.org/show_bug.cgi?id=84073
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Refactored building the stack trace to so that we can construct
it earlier, and don't rely on any prior work performed in the
exception handling machinery. Also updated LLInt and the DFG to
completely initialise the callframes of host function calls.
Also fixed a few LLInt paths that failed to correctly update the
topCallFrame.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- dfg/DFGJITCompiler.h:
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC):
(JSC::Interpreter::throwException):
- interpreter/Interpreter.h:
(Interpreter):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jsc.cpp:
(functionJSCStack):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/Parser.h:
(JSC::::parse):
- runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwError):
- runtime/Error.h:
(JSC):
LayoutTests:
Update tests to show complete trace information
- fast/js/exception-properties-expected.txt:
- fast/js/script-tests/exception-properties.js:
- fast/js/script-tests/stack-trace.js:
(selfRecursive1):
- fast/js/stack-trace-expected.txt:
- 5:12 PM Changeset in webkit [114701] by
-
- 1 edit18 adds in trunk/LayoutTests
[Chromium] Rebaselining new tests added in http://trac.webkit.org/changeset/114666
Not reviewed.
- platform/chromium-linux-x86/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-linux-x86/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-linux/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-linux/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-mac-leopard/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-mac-leopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-mac/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-win-vista/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-win-vista/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-win-xp/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-win-xp/fast/ruby/positioned-ruby-text-expected.txt: Added.
- platform/chromium-win/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/chromium-win/fast/ruby/positioned-ruby-text-expected.txt: Added.
- 5:11 PM Changeset in webkit [114700] by
-
- 2 edits in trunk/Source/WebCore
ElementAttributeData should be fast-malloc'd.
<http://webkit.org/b/84405>
Reviewed by Antti Koivisto.
Sprinkle missing WTF_MAKE_FAST_ALLOCATED.
- dom/ElementAttributeData.h:
(ElementAttributeData):
- 5:10 PM April 2012 Meeting edited by
- (diff)
- 5:08 PM Changeset in webkit [114699] by
-
- 9 edits in trunk
REGRESSION(r112177): Numbered list item rendered bulleted
https://bugs.webkit.org/show_bug.cgi?id=84216
Patch by David Barr <davidbarr@chromium.org> on 2012-04-19
Reviewed by Ryosuke Niwa.
Shorthands that imply omitted values cannot be derived from
an incomplete set of longhand rules.
No new tests; updated existing tests that should have caught this.
Source/WebCore:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTransformOriginShorthand):
Set implicit initial for Z when omitted.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getShorthandValue):
LayoutTests:
- css3/flexbox/css-properties.html:
- fast/css/cssText-shorthand.html:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- fast/dom/css-dom-read-2-expected.txt:
- 5:06 PM Internals_Hackathon edited by
- (diff)
- 5:05 PM Changeset in webkit [114698] by
-
- 19 edits in trunk/Source/JavaScriptCore
We're collecting pathologically due to small allocations
https://bugs.webkit.org/show_bug.cgi?id=84404
Reviewed by Geoffrey Garen.
No change in performance on run-jsc-benchmarks.
- dfg/DFGSpeculativeJIT.h: Replacing m_firstFreeCell with m_freeList.
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
- heap/CopiedSpace.cpp: Getting rid of any water mark related stuff, since it's no
longer useful.
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::tryAllocateSlowCase): We now only call didAllocate here rather than
carrying out a somewhat complicated accounting job for our old water mark throughout CopiedSpace.
(JSC::CopiedSpace::tryAllocateOversize): Call the new didAllocate to notify the Heap of
newly allocated stuff.
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::destroy):
- heap/CopiedSpace.h:
(CopiedSpace):
- heap/CopiedSpaceInlineMethods.h:
(JSC::CopiedSpace::startedCopying):
- heap/Heap.cpp: Removed water mark related stuff, replaced with new bytesAllocated and
bytesAllocatedLimit to track how much memory has been allocated since the last collection.
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::collect): We now set the new limit of bytes that we can allocate before triggering
a collection to be the size of the Heap after the previous collection. Thus, we still have our
2x allocation amount.
(JSC::Heap::didAllocate): Notifies the GC activity timer of how many bytes have been allocated
thus far and then adds the new number of bytes to the current total.
(JSC):
- heap/Heap.h: Removed water mark related stuff.
(JSC::Heap::notifyIsSafeToCollect):
(Heap):
(JSC::Heap::shouldCollect):
(JSC):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): Refactored to use MarkedBlock's new FreeList struct.
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::addBlock):
- heap/MarkedAllocator.h:
(MarkedAllocator):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::zapFreeList): Refactored to take in a FreeList instead of a FreeCell.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::zapFreeList):
- heap/MarkedBlock.h:
(FreeList): Added a new struct that keeps track of the current MarkedAllocator's
free list including the number of bytes of stuff in the free list so that when the free list is
exhausted, the correct amount can be reported to Heap.
(MarkedBlock):
(JSC::MarkedBlock::FreeList::FreeList):
(JSC):
- heap/MarkedSpace.cpp: Removing all water mark related stuff.
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
- heap/MarkedSpace.h:
(MarkedSpace):
(JSC):
- heap/WeakSet.cpp:
(JSC::WeakSet::findAllocator): Refactored to use the didAllocate interface with the Heap. This
function still needs work though now that the Heap knows how many bytes have been allocated
since the last collection.
- jit/JITInlineMethods.h: Refactored to use MarkedBlock's new FreeList struct.
(JSC::JIT::emitAllocateBasicJSObject): Ditto.
- llint/LowLevelInterpreter.asm: Ditto.
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::didAllocate): Renamed willAllocate to didAllocate to indicate that
the allocation that is being reported has already taken place.
(DefaultGCActivityCallback):
- runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::didAllocate): Refactored to return early if the amount of
allocation since the last collection is not above a threshold (initially arbitrarily chosen to
be 128KB).
- 5:05 PM Changeset in webkit [114697] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Don't compile FontCacheSkia for Android
https://bugs.webkit.org/show_bug.cgi?id=84392
Reviewed by Kent Tamura.
Chromium for the Android platform uses its own FontCacheAndroid
implementation. Compile errors show up when trying to build the
content shell.
- WebCore.gyp/WebCore.gyp:
- 5:03 PM Internals_Hackathon edited by
- (diff)
- 5:01 PM Internals_Hackathon edited by
- (diff)
- 4:59 PM Internals_Hackathon edited by
- (diff)
- 4:58 PM Internals_Hackathon edited by
- (diff)
- 4:58 PM Internals_Hackathon edited by
- (diff)
- 4:57 PM Internals_Hackathon edited by
- (diff)
- 4:56 PM Internals_Hackathon edited by
- (diff)
- 4:55 PM Internals_Hackathon edited by
- (diff)
- 4:54 PM Changeset in webkit [114696] by
-
- 1 edit2 deletes in trunk/Source/WebCore
[Cairo] Remove rgb24-hacks.txt and scale-removal.txt
https://bugs.webkit.org/show_bug.cgi?id=83475
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-19
Reviewed by Daniel Bates.
No new tests. This does not change functionality.
Remove some obsolete patch files for Cairo that were used in some
very old versions of Safari for Windows.
- platform/graphics/cairo/rgb24-hacks.txt: Removed.
- platform/graphics/cairo/scale-removal.txt: Removed.
- 4:54 PM Internals_Hackathon edited by
- (diff)
- 4:53 PM Internals_Hackathon edited by
- (diff)
- 4:52 PM Changeset in webkit [114695] by
-
- 2 edits in trunk/Source/JavaScriptCore
MacroAssemblerARMv7::branchTruncateDoubleToUint32 should obey the overflow signal
https://bugs.webkit.org/show_bug.cgi?id=84401
Reviewed by Gavin Barraclough.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTruncateDoubleToUint32):
- 4:52 PM Internals_Hackathon edited by
- (diff)
- 4:52 PM Internals_Hackathon edited by
- (diff)
- 4:50 PM Internals_Hackathon edited by
- (diff)
- 4:50 PM Changeset in webkit [114694] by
-
- 4 edits in trunk
[EFL] DRT console messages should contain only the file name part of local URIs
https://bugs.webkit.org/show_bug.cgi?id=84236
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-19
Reviewed by Kentaro Hara.
Tools:
Process console messages before printing them in EFL's DumpRenderTree
them so that they contain only the file name part of local URIs. This
is what is expected by test cases.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(urlSuitableForTestResult):
(onConsoleMessage):
LayoutTests:
Remove from the skip list the tests which expect only the file name
part of local URIs to be displayed in console messages now that it has
been fixed in EFL's DumpRenderTree.
- platform/efl/Skipped:
- 4:49 PM Internals_Hackathon edited by
- (diff)
- 4:48 PM Internals_Hackathon edited by
- (diff)
- 4:47 PM Internals_Hackathon edited by
- (diff)
- 4:46 PM Changeset in webkit [114693] by
-
- 3 edits1 add15 deletes in trunk/LayoutTests
transforms/no_transform_hit_testing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82415
Patch by Florin Malita <fmalita@google.com> on 2012-04-19
Reviewed by Simon Fraser.
Convert the test to text-only (dumpAsText) to avoid inconsistent pixel results.
- platform/chromium-linux/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-mac-snowleopard/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-mac/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-win/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/chromium-win/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/efl/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/efl/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/gtk/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/mac-leopard/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/mac/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/mac/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Removed.
- platform/qt/transforms/no_transform_hit_testing-expected.png: Removed.
- platform/qt/transforms/no_transform_hit_testing-expected.txt: Removed.
- transforms/no_transform_hit_testing-expected.txt: Added.
- transforms/no_transform_hit_testing.html:
- 4:45 PM Internals_Hackathon edited by
- (diff)
- 4:43 PM Internals_Hackathon edited by
- (diff)
- 4:42 PM Internals_Hackathon edited by
- (diff)
- 4:42 PM Internals_Hackathon edited by
- (diff)
- 4:41 PM Changeset in webkit [114692] by
-
- 2 edits3 deletes in trunk/LayoutTests
[chromium] Unreviewed, update chromium expectations for various compositing layout tests
- platform/chromium/test_expectations.txt:
- 4:39 PM Internals_Hackathon edited by
- (diff)
- 4:38 PM Changeset in webkit [114691] by
-
- 2 edits in trunk/Source/WebCore
Use sqrtf instead of sqrt in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=84403
Reviewed by Andreas Kling.
r114679 broke Chromium Win and Android bots due to call
ambiguity between a double and float argument.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
- 4:34 PM Internals_Hackathon edited by
- (diff)
- 4:30 PM Internals_Hackathon edited by
- (diff)
- 4:30 PM Changeset in webkit [114690] by
-
- 3 edits in trunk/Source/WebCore
Default to null value for HistoryItem::m_pageScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=84385
Patch by Alexandre Elias <aelias@google.com> on 2012-04-19
Reviewed by Nate Chapin.
Previously, HistoryItem::m_pageScaleFactor defaulted to a value
of 1, making it impossible to determine whether this value was never
set, or intentionally set to 1. This patch introduces a default value
of 0 and makes restoreScrollPositionAndViewState not touch the page
scale factor if this value is still present at time of reload.
This is a no-op change for common navigation scenarios. The
motivation for this change is the corner case of syncing history items
from a desktop browser to a mobile device. In that case, we need a
way to specify that the history item does not contain a
pageScaleFactor so that the mobile device does not display the page
overly zoomed in.
No new tests.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 4:28 PM Internals_Hackathon edited by
- (diff)
- 4:27 PM Changeset in webkit [114689] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Qt build warning fix.
The file editing/StringHelper.h does not exist.
- Target.pri:
- 4:27 PM Internals_Hackathon edited by
- (diff)
- 4:26 PM Internals_Hackathon edited by
- (diff)
- 4:19 PM Internals_Hackathon edited by
- (diff)
- 4:17 PM Internals_Hackathon edited by
- (diff)
- 4:03 PM Internals_Hackathon edited by
- (diff)
- 4:01 PM Changeset in webkit [114688] by
-
- 1 edit1 delete in trunk/Source/WebCore
Remove empty directory Source/WebCore/webaudio
Changeset 111474 <http://trac.webkit.org/changeset/111474> moved all the files in
Source/WebCore/webaudio to Source/WebCore/Modules/webaudio. We should remove the
empty directory Source/WebCore/webaudio.
- webaudio: Removed.
- 4:00 PM Changeset in webkit [114687] by
-
- 2 edits in trunk/LayoutTests
[Qt][Wk2] unskip page-reload-cancel-permission-requests from geolocation for wk2
https://bugs.webkit.org/show_bug.cgi?id=84293
Reviewed by Tor Arne Vestbø.
Unskipped page-reload-cancel-permission-requests after r105988.
- platform/qt-5.0-wk2/Skipped:
- 4:00 PM Internals_Hackathon edited by
- (diff)
- 3:59 PM Changeset in webkit [114686] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add simplified API for iterating over a WebElement's attributes.
<http://webkit.org/b/84183>
Reviewed by Dimitri Glazkov.
Add attributeCount(), attributeLocalName(index) and attributeValue(index) to the
WebElement API so that call sites currently using WebNamedNodeMap can be
converted, which will ultimately allow us to refactor WebCore::Attribute
on <http://webkit.org/b/83440>.
- public/WebElement.h:
- src/WebElement.cpp:
(WebKit::WebElement::attributeCount):
(WebKit::WebElement::attributeLocalName):
(WebKit::WebElement::attributeValue):
- 3:59 PM Internals_Hackathon edited by
- (diff)
- 3:59 PM Internals_Hackathon edited by
- (diff)
- 3:58 PM Internals_Hackathon edited by
- (diff)
- 3:57 PM April 2012 Meeting edited by
- (diff)
- 3:54 PM Internals_Hackathon edited by
- (diff)
- 3:53 PM Internals_Hackathon created by
- 3:49 PM Changeset in webkit [114685] by
-
- 5 edits in trunk/LayoutTests
New ruby tests broken on Mac
https://bugs.webkit.org/show_bug.cgi?id=84382
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Eric Seidel.
Tweaking new tests to make them render the same on all platforms.
- fast/ruby/floating-ruby-text-expected.txt:
- fast/ruby/floating-ruby-text.html:
- fast/ruby/positioned-ruby-text-expected.txt:
- fast/ruby/positioned-ruby-text.html:
- 3:44 PM Changeset in webkit [114684] by
-
- 2 edits in trunk/Source/JavaScriptCore
KeywordLookupGenerator.py should take an output file as an argument
https://bugs.webkit.org/show_bug.cgi?id=84292
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-19
Reviewed by Eric Seidel.
Extended KeywordLookupGenerator to accept an additional argument specifying an output file. If this argument is found stdout is redirected to a file for the duration of the script.
- KeywordLookupGenerator.py:
- 3:33 PM Changeset in webkit [114683] by
-
- 3 edits in trunk/Source/WebCore
Incorrect inter-caps in “ShouldSkipMetaData” etc.
https://bugs.webkit.org/show_bug.cgi?id=72159
Reviewed by Dan Bernstein.
No new tests since no change in functionality.
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
- 3:12 PM Changeset in webkit [114682] by
-
- 2 edits in trunk/Tools
[EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
https://bugs.webkit.org/show_bug.cgi?id=84169
All databases were being created inside ~/.webkit which was causing
flaky tests when running multiple tests in parallel, specially timeouts
due to concurrency.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-19
Reviewed by Eric Seidel.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
- 3:10 PM Changeset in webkit [114681] by
-
- 3 edits in trunk/Websites/webkit.org
Update Build Location notice on Mac debug instructions to reflect changes in Xcode 4.3.2
https://bugs.webkit.org/show_bug.cgi?id=84364
Reviewed by Eric Seidel.
As of Xcode 4.3.2, the build location "Locations Specified by Targets" has been renamed to
"Legacy".
- building/debug-mac-uiprocess.html:
- building/debug.html:
- 3:07 PM Changeset in webkit [114680] by
-
- 1 edit3 adds in trunk/LayoutTests
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792
Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.
- fast/canvas/canvas-strokePath-cap-join-expected.txt: Added.
- fast/canvas/canvas-strokePath-cap-join.html: Added.
- fast/canvas/script-tests/canvas-strokePath-cap-join.js: Added.
- 3:05 PM Changeset in webkit [114679] by
-
- 3 edits in trunk/Source/WebCore
Canvas more precisely makes the bounding rect for stroke rendering.
https://bugs.webkit.org/show_bug.cgi?id=75792
Patch by Huang Dongsung <luxtella@company100.net> on 2012-04-19
Reviewed by Simon Fraser.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
(WebCore::CanvasRenderingContext2D::inflateStrokeRect):
(WebCore):
- html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
- 3:03 PM Changeset in webkit [114678] by
-
- 2 edits in trunk/Source/WebCore
Eliminate potential null pointer dereference in CSSStyleSelector::containsUncommonAttributeSelector().
https://bugs.webkit.org/show_bug.cgi?id=84366
Reviewed by Kentaro Hara.
No new tests / code cleanup only.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 3:00 PM Changeset in webkit [114677] by
-
- 3 edits2 adds in trunk
Fix null-pointer dereference in ApplyPropertyZoom::applyValue().
https://bugs.webkit.org/show_bug.cgi?id=84279
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/css/zoom-on-unattached.html
- css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyZoom::applyValue):
LayoutTests:
- fast/css/zoom-on-unattached-expected.txt: Added.
- fast/css/zoom-on-unattached.html: Added.
- 2:56 PM Changeset in webkit [114676] by
-
- 2 edits in trunk/Source/WebCore
Clean up list iteration in MediaQueryExp constructor (avoid unnecessary calls to current()).
https://bugs.webkit.org/show_bug.cgi?id=84369
Reviewed by Simon Fraser.
No new tests / code cleanup only.
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp):
- 2:55 PM Changeset in webkit [114675] by
-
- 7 edits in trunk/Source/JavaScriptCore
It should be possible to perform debugCall on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=84381
Reviewed by Oliver Hunt.
debugCall() was clobbering the argument to the call it was making, leading to a
corrupt ExecState*. This change fixes that issue by using a scratch register that
does not clobber arguments, and it also introduces more assertions that we have
a valid call frame.
- dfg/DFGAssemblyHelpers.cpp:
(DFG):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::selectScratchGPR):
- 2:48 PM April 2012 Meeting edited by
- (diff)
- 2:32 PM Changeset in webkit [114674] by
-
- 1 edit2 adds in trunk/LayoutTests
REGRESSION (r114666): fast/ruby/floating-ruby-text.html, fast/ruby/positioned-ruby-text.html failing on Lion Release (Tests)
https://bugs.webkit.org/show_bug.cgi?id=84384
Add platform/mac baselines for new ruby tests.
- platform/mac/fast/ruby/floating-ruby-text-expected.txt: Added.
- platform/mac/fast/ruby/positioned-ruby-text-expected.txt: Added.
- 2:29 PM Changeset in webkit [114673] by
-
- 2 edits in trunk/LayoutTests
Check in correct expectations for some passing tests.
Rubber stamped by Oliver Hunt.
- platform/mac/test_expectations.txt:
- 2:26 PM Changeset in webkit [114672] by
-
- 53 edits in trunk/LayoutTests
Remove description from calls to indexedDB.open
https://bugs.webkit.org/show_bug.cgi?id=84109
open() used to take two parameters, a database name and an optional
string database description. The description was deprecated. An
optional integer version parameter was recently added in its place.
This change removes the description parameter from calls that still
had it so that it's not interpreted as a version.
Reviewed by Eric Seidel.
- storage/indexeddb/create-object-store-options-expected.txt:
- storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/createObjectStore-null-name-expected.txt:
- storage/indexeddb/cursor-update-value-argument-required-expected.txt:
- storage/indexeddb/database-odd-names-expected.txt:
- storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
- storage/indexeddb/deleteObjectStore-null-name-expected.txt:
- storage/indexeddb/factory-basics-expected.txt:
- storage/indexeddb/index-get-key-argument-required-expected.txt:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/key-sort-order-across-types-expected.txt:
- storage/indexeddb/key-sort-order-date-expected.txt:
- storage/indexeddb/key-type-array-expected.txt:
- storage/indexeddb/key-type-infinity-expected.txt:
- storage/indexeddb/keypath-basics-expected.txt:
- storage/indexeddb/keypath-fetch-key-expected.txt:
- storage/indexeddb/objectStore-required-arguments-expected.txt:
- storage/indexeddb/odd-strings-expected.txt:
- storage/indexeddb/readonly-expected.txt:
- storage/indexeddb/readonly-properties-expected.txt:
- storage/indexeddb/resources/create-object-store-options.js:
(test):
- storage/indexeddb/resources/createObjectStore-name-argument-required.js:
(test):
- storage/indexeddb/resources/createObjectStore-null-name.js:
(test):
- storage/indexeddb/resources/cursor-update-value-argument-required.js:
(test):
- storage/indexeddb/resources/database-odd-names.js:
(openNextDatabase):
- storage/indexeddb/resources/deleteObjectStore-name-argument-required.js:
(test):
- storage/indexeddb/resources/deleteObjectStore-null-name.js:
(test):
- storage/indexeddb/resources/factory-basics.js:
(test):
(getDatabaseNamesSuccess1):
- storage/indexeddb/resources/index-get-key-argument-required.js:
(test):
- storage/indexeddb/resources/invalid-keys.js:
(test):
- storage/indexeddb/resources/key-sort-order-across-types.js:
(test):
- storage/indexeddb/resources/key-sort-order-date.js:
(test):
- storage/indexeddb/resources/key-type-array.js:
(test):
- storage/indexeddb/resources/key-type-infinity.js:
(test):
- storage/indexeddb/resources/keypath-basics.js:
(test):
- storage/indexeddb/resources/keypath-fetch-key.js:
(test):
- storage/indexeddb/resources/objectStore-required-arguments.js:
(test):
- storage/indexeddb/resources/odd-strings.js:
(openNextDatabase):
(verifyNextDatabase):
- storage/indexeddb/resources/readonly-properties.js:
(test):
- storage/indexeddb/resources/readonly.js:
(test):
- storage/indexeddb/resources/setVersion-null.js:
(test):
- storage/indexeddb/resources/setVersion-undefined.js:
(test):
- storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(test):
- storage/indexeddb/resources/transaction-storeNames-required.js:
(test):
- storage/indexeddb/resources/value-undefined.js:
(test):
- storage/indexeddb/resources/values-odd-types.js:
(test):
- storage/indexeddb/setVersion-null-expected.txt:
- storage/indexeddb/setVersion-undefined-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-storeNames-required-expected.txt:
- storage/indexeddb/value-undefined-expected.txt:
- storage/indexeddb/values-odd-types-expected.txt:
- 2:24 PM Changeset in webkit [114671] by
-
- 5 edits in trunk/Source
[Chromium] Call signedPublicKeyAndChallengeString directly
https://bugs.webkit.org/show_bug.cgi?id=84372
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
- platform/chromium/SSLKeyGeneratorChromium.cpp:
(WebCore::signedPublicKeyAndChallengeString):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore):
- 2:22 PM Changeset in webkit [114670] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary assignment in CSSParser::parseCubicBezierTimingFunctionValue().
https://bugs.webkit.org/show_bug.cgi?id=84368
Reviewed by Simon Fraser.
No new tests / code cleanup only.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
- 2:20 PM Changeset in webkit [114669] by
-
- 2 edits in trunk/Source/WebCore
Initialize all member variables in CSSImageSetValue's copy constructor.
https://bugs.webkit.org/show_bug.cgi?id=84379
Reviewed by Simon Fraser.
No new tests / code cleanup only.
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
- 2:19 PM April 2012 Meeting edited by
- (diff)
- 1:54 PM April 2012 Meeting edited by
- (diff)
- 1:53 PM Changeset in webkit [114668] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Call audioHardwareBufferSize directly
https://bugs.webkit.org/show_bug.cgi?id=84370
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- 1:34 PM Changeset in webkit [114667] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK test_expectations update after r114640.
- platform/gtk/test_expectations.txt:
- 1:15 PM Changeset in webkit [114666] by
-
- 4 edits8 adds in trunk
Positioned children of ruby runs not handled correctly during layout
https://bugs.webkit.org/show_bug.cgi?id=84157
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-19
Reviewed by Julien Chaffraix.
Source/WebCore:
A positioned ruby text causes a problem because it is excluded from
normal layout by its parent and instead gets layout from
RenderRubyRun::layoutSpecialExcludedChild; however this means it gets
skipped over during the loop in RenderBlock::layoutBlockChildren,
which is where positioned RenderBlocks get added to the appropriate
positioned object lists. As a result, a dirty positioned ruby text
will not get layout again unless the RenderRubyRun also needs layout
which is not guaranteed.
This patch disqualifies ruby text elements from being positioned.
If it is necessary to support this in future, ruby text layout will
have to be modified to ensure the renderers are added to the
appropriate block lists.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::rubyText):
LayoutTests:
- fast/ruby/modify-positioned-ruby-text-crash-expected.txt: Added
- fast/ruby/modify-positioned-ruby-text-crash.html: Exercises the crash condition
in but 84157 relating to positioned ruby text. This is being added
in case support for positioned ruby text is added in future, so that
we can guard against regression.
- fast/ruby/floating-ruby-text-expected.png: Added
- fast/ruby/floating-ruby-text-expected.txt: Added
- fast/ruby/floating-ruby-text.html: Creates a positioned ruby text. The
position should be ignored.
- fast/ruby/positioned-ruby-text-expected.png: Added
- fast/ruby/positioned-ruby-text-expected.txt: Added
- fast/ruby/positioned-ruby-text.html: Creates a floating ruby text. The
float should be ignored.
- 12:27 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:22 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:20 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:19 PM April 2012 Meeting edited by
- Added link to Web Components notes (diff)
- 12:18 PM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 12:18 PM WebComponentsStatusMeetingNotes created by
- Initial commit; may fix formatting later.
- 12:12 PM Changeset in webkit [114665] by
-
- 3 edits in trunk/Source/WebKit2
DevTools: assertion failure upon devtools window reopen.
https://bugs.webkit.org/show_bug.cgi?id=53493
Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-19
Reviewed by Pavel Feldman.
The pointers pointed to by WebInspector must be reset explicitly
in WebInspector::didClose() method
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::didClose):
- 12:11 PM Accelerated rendering and compositing edited by
- (diff)
- 12:08 PM Changeset in webkit [114664] by
-
- 3 edits in trunk/Source/JavaScriptCore
LLInt no-JIT fallback native call trampoline's exception handler incorrectly assumes that
the PB/PC has been preserved
https://bugs.webkit.org/show_bug.cgi?id=84367
Reviewed by Oliver Hunt.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 11:59 AM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:56 AM Changeset in webkit [114663] by
-
- 6 edits3 adds in trunk
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265
Reviewed by Pavel Feldman.
Source/WebCore:
InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.
Test: http/tests/inspector/network/network-image-404.html
- inspector/InspectorResourceAgent.cpp:
(WebCore::isErrorStatusCode):
(WebCore):
(WebCore::InspectorResourceAgent::didReceiveData):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::purgeContent):
(WebCore):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceContent):
- inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
- inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
- http/tests/inspector/network/network-image-404-expected.txt: Added.
- http/tests/inspector/network/network-image-404.html: Added.
- http/tests/inspector/network/resources/404.php: Added.
- 11:51 AM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:50 AM Changeset in webkit [114662] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector / Heap snapshots: "Object's retaining tree" view doesn't get cleared when navigating between objects
https://bugs.webkit.org/show_bug.cgi?id=84337
When DataGrid root node is reset, make sure all existing rows are removed.
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setRootNode):
- 11:47 AM Changeset in webkit [114661] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=80534
REGRESSION: When Safari is not frontmost, pages should not get mouse moves or
hover
Reviewed by Adele Peterson.
This patch just adds some code back that was removed by
http://trac.webkit.org/changeset/102632 This particular code was unrelated to that
bug and should not have been removed.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseMoveEvent):
- 11:46 AM Accelerated rendering and compositing edited by
- (diff)
- 11:44 AM Changeset in webkit [114660] by
-
- 2 edits in trunk/Source/JavaScriptCore
It should be possible to load from Float64 arrays on ARMv7 without crashing
https://bugs.webkit.org/show_bug.cgi?id=84361
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::storeDouble):
- 11:42 AM April 2012 MeetingRethinkingRendering edited by
- (diff)
- 11:42 AM Changeset in webkit [114659] by
-
- 3 edits3 adds in trunk
DevTools highlights elements in frames at un-scaled positions
https://bugs.webkit.org/show_bug.cgi?id=84181
Source/WebCore:
On mobile platforms (e.g. chromium-android), normally pages are scaled,
thus the coordinations of highlight rect inside of a frame needs to
consider not only the offset, but also the scale. The change uses
FrameView::contentsToRootView() to map the coordinates of a node in
a frame to the coordinates in the main frame, instead of calculating
by only the offset.
Reviewed by Pavel Feldman.
Test: inspector/elements/highlight-node-scaled.html
- inspector/DOMNodeHighlighter.cpp:
LayoutTests:
The new test case is a scaled web page containing an iframe. It tests
if the highlight rect of an element in the iframe is correct.
Reviewed by Pavel Feldman.
- inspector/elements/highlight-node-scaled-expected.txt: Added.
- inspector/elements/highlight-node-scaled.html: Added.
- inspector/elements/resources/highlight-node-scaled-iframe.html: Added.
- 11:38 AM Changeset in webkit [114658] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector / Heap snapshots: "Objects allocated ..." views are empty
https://bugs.webkit.org/show_bug.cgi?id=84347
Pass parsed maxJSObjectId value to the profile header constructor.
Reviewed by Pavel Feldman.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
- 11:36 AM April 2012 Meeting edited by
- (diff)
- 11:35 AM April 2012 Meeting edited by
- (diff)
- 11:33 AM April 2012 Meeting edited by
- (diff)
- 11:33 AM April 2012 MeetingRethinkingRendering created by
- 11:30 AM UpdatingBugzilla edited by
- (diff)
- 11:30 AM UpdatingBugzilla edited by
- (diff)
- 11:28 AM April 2012 Meeting edited by
- (diff)
- 11:27 AM Changeset in webkit [114657] by
-
- 1 edit1 add in trunk/LayoutTests
AVFoundation: media/video-size-intrinsic-scale.html test fails, and the movie is drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=66601
Reviewed by Eric Carlson.
- platform/mac-snowleopard/media/video-size-intrinsic-scale-expected.txt: Added.
Copied passing result, since this doesn't fail on Snow Leopard.
- platform/mac/media/video-size-intrinsic-scale-expected.txt: Added a failing results to make
bots green.
- 11:25 AM Changeset in webkit [114656] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/10664148> and https://bugs.webkit.org/show_bug.cgi?id=84360 StorageThread should have an autorelease pool in place for Cocoa clients
Reviewed by Eric Carlson.
No new tests. (Not practical to test this with current tools)
- storage/StorageThread.cpp:
(WebCore::StorageThread::threadEntryPoint): Include an AutodrainedPool and cycle it after each message.
- 11:20 AM Changeset in webkit [114655] by
-
- 2 edits in trunk/Source/WebCore
Fix potential null pointer dereference in RuleSet::addRulesFromSheet().
https://bugs.webkit.org/show_bug.cgi?id=84258
Reviewed by Andreas Kling.
Fix variable that is dereferenced without null check here, but checked in code above and below.
No new test / code cleanup from coverity analysis.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
- 11:19 AM Accelerated rendering and compositing edited by
- (diff)
- 11:19 AM Accelerated rendering and compositing edited by
- (diff)
- 11:18 AM Accelerated rendering and compositing created by
- Initial draft
- 11:18 AM Changeset in webkit [114654] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: exception when hovering object while paused
https://bugs.webkit.org/show_bug.cgi?id=84358
Added missing boolean parameter to the call site of evaluate method
on call frame.
Reviewed by Vsevolod Vlasov.
- inspector/front-end/AdvancedSearchController.js:
- inspector/front-end/DebuggerPresentationModel.js: annotated slectedCallFrame
method so that closure compiler catches errors like in the bug report.
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
- 11:17 AM Changeset in webkit [114653] by
-
- 5 edits in trunk
[GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
https://bugs.webkit.org/show_bug.cgi?id=82484
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Martin Robinson.
Tools:
Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
LayoutTests:
Unskipping tests that were previously failing due to a bug in libsoup.
- platform/gtk/test_expectations.txt:
- 11:17 AM April 2012 Meeting edited by
- (diff)
- 11:14 AM April 2012 Meeting edited by
- (diff)
- 11:11 AM Changeset in webkit [114652] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: nodes are not removed from the summary view when switching between allocation ranges
https://bugs.webkit.org/show_bug.cgi?id=84354
Clear all top level nodes not only those visible in the viewport when populating
the constructors view with new content.
Reviewed by Pavel Feldman.
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.topLevelNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.removeTopLevelNodes):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
- 11:05 AM MeetingNotesLayoutModes edited by
- (diff)
- 11:03 AM Changeset in webkit [114651] by
-
- 18 edits in trunk/Source
Source/WebCore: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.
This patch enables scrolling child layers in the compositor thread.
Scroll deltas are accumulated for each scrolled CCLayerImpl and
synchronized to the main thread.
If a layer has no room to scroll in a given direction, one of its
ancestor layers is scrolled instead if possible.
Added new webkit_unit_tests to verify scrolling behavior.
- platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::scrollBy):
(WebCore):
- platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerDelegate):
(ContentLayerChromium):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::didScroll):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore):
(WebCore::LayerChromium::pushPropertiesTo):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::scrollBy):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::findLayerInSubtree):
(WebCore):
(WebCore::CCLayerImpl::tryScroll):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::findLayerById):
(WebCore):
(WebCore::findFirstScrollableLayer):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateVisibleLayers):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findRootScrollLayer):
(WebCore::findScrollLayerForContentLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::adjustScrollsForPageScaleChange):
(WebCore::applyPageScaleDeltaToScrollLayers):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::collectScrollDeltas):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::rootScrollLayer):
(CCLayerTreeHostImpl):
(LayerGeometry):
Source/WebKit/chromium: [chromium] Add tests for scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-19
Reviewed by James Robinson.
- src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::didScroll):
(WebKit):
- src/WebContentLayerImpl.h:
(WebContentLayerImpl):
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
(WebCore):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::createScrollableLayer):
(CCLayerTreeHostImplTest):
(WebKitTests::CCLayerTreeHostImplTest::initializeLayerRendererAndDrawFrame):
(WebKitTests::TEST_F):
(WebKitTests):
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestOpacityChangeLayerDelegate::didScroll):
(WTF::MockContentLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::didScroll):
(CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::CCLayerTreeHostTestScrollChildLayer):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginTest):
(WTF::CCLayerTreeHostTestScrollChildLayer::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollChildLayer::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollChildLayer::afterTest):
(WTF):
(WTF::TEST_F):
- 10:55 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:53 AM Changeset in webkit [114650] by
-
- 4 edits in trunk/LayoutTests
Space out captions-fast.vtt to prevent flakiness in media/track/track-mode.html.
https://bugs.webkit.org/show_bug.cgi?id=83878
Reviewed by Eric Carlson.
- media/track/captions-webvtt/captions-fast.vtt:
- media/track/track-mode-expected.txt:
- media/track/track-mode.html:
- 10:44 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:41 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:39 AM MeetingNotesLayoutModes edited by
- (diff)
- 10:39 AM MeetingNotesLayoutModes created by
- 10:11 AM Changeset in webkit [114649] by
-
- 7 edits in trunk
Web Inspector: make constructors and diff heap snapshot data grids use viewport
https://bugs.webkit.org/show_bug.cgi?id=84348
HeapSnapshotViewportDataGrid is introduced which allows to add to the tbody only
visible rows. HeapSnapshotConstructorsDataGrid and HeapSnapshotDiffDataGrid are
inherited from this class which makes them operate well on large amounts of nodes.
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.nodeHeight):
(WebInspector.DataGridNode.prototype._attach):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotViewportDataGrid):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.nodesForNameFilter):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendChildAfterSorting):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.appendTopLevelNode):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._addPaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._removePaddingRows):
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotViewportDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotPaddingNode):
(WebInspector.HeapSnapshotPaddingNode.prototype.setHeight):
(WebInspector.HeapSnapshotPaddingNode.prototype.removeFromTable):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.collapse):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
- inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode.prototype.createCells):
(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
LayoutTests:
- inspector/profiler/heap-snapshot-test.js: since summary and containment views are
now viewports, we should make sure all lazy clean up is done before collecting visible
rows content.
(initialize_HeapSnapshotTest):
- 10:07 AM Changeset in webkit [114648] by
-
- 2 edits in trunk/LayoutTests
[EFL] [DRT] Unskip KeyEvent related tests which are passing now
https://bugs.webkit.org/show_bug.cgi?id=84345
Unreviewed, unskip passing KeyEvent tests.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-19
- platform/efl/Skipped:
- 10:05 AM Changeset in webkit [114647] by
-
- 4 edits in trunk/Source/WebKit/chromium
IndexedDB: Stub out IDBCursor.advance for landing
https://bugs.webkit.org/show_bug.cgi?id=84280
Patch by Alec Flett <alecflett@chromium.org> on 2012-04-19
Reviewed by Dimitri Glazkov.
Just a stub method so it can be implemented on chromium
- public/WebIDBCursor.h:
(WebKit::WebIDBCursor::advance):
- src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::advance):
(WebKit):
- src/WebIDBCursorImpl.h:
(WebIDBCursorImpl):
- 10:00 AM Changeset in webkit [114646] by
-
- 2 edits in trunk/Tools
Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:00 AM Changeset in webkit [114645] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r114421.
http://trac.webkit.org/changeset/114421
https://bugs.webkit.org/show_bug.cgi?id=84103
Chromium crash
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::TestEventConstructorV8Internal::attr1AttrGetter):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetter):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::hashAttrGetter):
(WebCore::TestObjV8Internal::conditionalMethod1Callback):
- bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr):
- bindings/v8/V8Binding.h:
(WebCore::v8ExternalString):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):
(WebCore::v8StringOrFalse):
- 9:59 AM Changeset in webkit [114644] by
-
- 6 edits3 deletes in trunk
Unreviewed, rolling out r114626.
http://trac.webkit.org/changeset/114626
https://bugs.webkit.org/show_bug.cgi?id=84349
caused new assertions in debug builds (Requested by smfr_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
Source/WebCore:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
- inspector/NetworkResourcesData.h:
(ResourceData):
(NetworkResourcesData):
- inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
- http/tests/inspector/network/network-image-404-expected.txt: Removed.
- http/tests/inspector/network/network-image-404.html: Removed.
- http/tests/inspector/network/resources/404.php: Removed.
- 9:58 AM UpdatingBugzilla edited by
- (diff)
- 9:56 AM UpdatingBugzilla edited by
- (diff)
- 9:53 AM Changeset in webkit [114643] by
-
- 1 edit in branches/chromium/1084/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
Merge 114275
BUG=27086
TBR=raymes@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10113012
- 9:40 AM Changeset in webkit [114642] by
-
- 4 edits in branches/chromium/1084/Source/WebCore
Merge 114191 - [chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316
Reviewed by Adrienne Walker.
We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.
We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.
Covered by existing tests.
- platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
- platform/graphics/chromium/TextureManager.h:
(TextureManager):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10025037
- 9:40 AM Changeset in webkit [114641] by
-
- 5 edits in trunk/Source
[Chromium] Call mimeRegistry directly
https://bugs.webkit.org/show_bug.cgi?id=84334
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
- platform/chromium/PlatformSupport.h:
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::layoutTestMode):
- 9:27 AM Changeset in webkit [114640] by
-
- 9 edits3 adds in trunk
Display a TextTrackCue when snap-to-lines flag is not set
https://bugs.webkit.org/show_bug.cgi?id=79750
Patch by Victor Carbune <vcarbune@adobe.com> on 2012-04-19
Reviewed by Eric Carlson.
Source/WebCore:
Support for positioning of a cue on top of the video element when snap-to-lines is not set.
Test: media/track/track-cue-rendering-snap-to-lines-not-set.html
- css/mediaControls.css:
(video::-webkit-media-text-track-container): Marked the container as
flexible box in order to use all the available space on top of the controls.
(video::-webkit-media-text-track-background): Added background default settings.
(video::-webkit-media-text-track-display): Added default position.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Updated comments.
- html/track/TextTrackCue.cpp:
(WebCore):
(WebCore::TextTrackCue::TextTrackCue): Updated constructor to calculate
the computed line position.
(WebCore::TextTrackCue::setLine): Updated call to calculate the computed line
position.
(WebCore::TextTrackCue::setPosition):
(WebCore::TextTrackCue::calculateComputedLinePosition): Partial calculation of the
computated line position.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated display parameter computations
required by the spec.
(WebCore::TextTrackCue::getDisplayTree): Updated positioning attributes when snap-to-lines
is not set. Added extra anonymous box for background, because setting position:absolute
on the display tree determines the background to cover the whole block, not just inline.
(WebCore::TextTrackCue::getPositionCoordinates): Determine coordinates as required by the spec.
- html/track/TextTrackCue.h:
(TextTrackCue):
LayoutTests:
Added tests to support positioning of cues when snap-to-lines set.
- media/media-controls.js:
(textTrackDisplayElement): Added an extra parameter, to return the display
box of the N-th active cue.
- media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt: Added.
- media/track/track-cue-rendering-expected.txt: Updated background color check.
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
- media/track/track-cue-rendering-snap-to-lines-not-set.html: Added.
- media/track/track-cue-rendering.html: Updated background color check.
- 9:23 AM Changeset in webkit [114639] by
-
- 2 edits3 adds in trunk/LayoutTests
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302
Rubber stamped by Gavin Barraclough.
Added float64 array test coverage.
- fast/js/dfg-float64array-expected.txt: Added.
- fast/js/dfg-float64array.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-float64array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
- 9:20 AM Changeset in webkit [114638] by
-
- 1 edit in branches/chromium/1084/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
Merge 114373 - Web Inspector: [Chromium] Crash when inspecting empty IndexedDB object store.
https://bugs.webkit.org/show_bug.cgi?id=84035
Reviewed by Pavel Feldman.
Added a check that m_idbCursor is not null before calling postSuccessHandlerCallback() on it.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
TBR=vsevik@chromium.org
BUG=121578
Review URL: https://chromiumcodereview.appspot.com/10125008
- 9:19 AM Changeset in webkit [114637] by
-
- 17 edits1 add in trunk/Source/WebCore
Web Inspector: introduce styles panel as an experiment
https://bugs.webkit.org/show_bug.cgi?id=84331
Reviewed by Vsevolod Vlasov.
This change introduces new "Styles" panel that looks like the "Scripts" one,
but operates stylesheets. This is happening under the experimental flag.
- English.lproj/localizedStrings.js:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.showAnchorLocation):
- inspector/front-end/ResourceView.js:
(WebInspector.EditableResourceSourceFrame.prototype.didEditContent):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._clearLineHighlight):
- inspector/front-end/StylesPanel.js: Added.
(WebInspector.StylesPanel):
(WebInspector.StylesPanel.prototype.wasShown):
(WebInspector.StylesPanel.prototype._initialize):
(WebInspector.StylesPanel.prototype._populateResourceTree.populateFrame):
(WebInspector.StylesPanel.prototype._populateResourceTree):
(WebInspector.StylesPanel.prototype._resourceAdded):
(WebInspector.StylesPanel.prototype._reset):
(WebInspector.StylesPanel.prototype._cachedResourcesLoaded):
(WebInspector.StylesPanel.prototype.get toolbarItemLabel):
(WebInspector.StylesPanel.prototype.viewForFile.get if):
(WebInspector.StylesPanel.prototype.viewForFile):
(WebInspector.StylesPanel.prototype._textEdited):
(WebInspector.StylesPanel.prototype._scriptSelected):
(WebInspector.StylesPanel.prototype._showFile):
(WebInspector.StylesPanel.prototype.canShowAnchorLocation):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
(WebInspector._createPanels):
(WebInspector._showAnchorLocationInPanel):
- inspector/front-end/scriptsPanel.css:
- inspector/front-end/splitView.css:
(.sidebar-overlay):
- 9:16 AM Changeset in webkit [114636] by
-
- 2 edits in trunk/Source/WebCore
Follow up to r114632: build fix.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- 9:10 AM WebKitGTK/1.8.x edited by
- (diff)
- 8:57 AM Changeset in webkit [114635] by
-
- 5 edits in trunk/Source
[Chromium] Call sampleGamepads directly
https://bugs.webkit.org/show_bug.cgi?id=84339
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
Source/WebCore:
- platform/chromium/GamepadsChromium.cpp:
(WebCore::sampleGamepads):
- platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
Source/WebKit/chromium:
- src/PlatformSupport.cpp:
(WebCore::PlatformSupport::injectIDBKeyIntoSerializedValue):
- 8:51 AM Changeset in webkit [114634] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Call audioHardwareSampleRate directly
https://bugs.webkit.org/show_bug.cgi?id=84335
Reviewed by Kentaro Hara.
Part of a refactoring series. See tracking bug 82948.
- src/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
- 8:48 AM UpdatingBugzilla edited by
- Added (diff)
- 8:37 AM Changeset in webkit [114633] by
-
- 8 edits in trunk
[EFL] dispatchDidCancelClientRedirect needs implementation
https://bugs.webkit.org/show_bug.cgi?id=83669
Patch by Christophe Dumez <Christophe Dumez> on 2012-04-19
Reviewed by Antonio Gomes.
Source/WebKit/efl:
Emit a new "redirect,cancelled" signal on the ewk_frame when a
redirect is cancelled. This is needed by EFL's DumpRenderTree to dump
frame load callbacks information.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidCancelClientRedirect):
- ewk/ewk_frame.cpp:
(ewk_frame_redirect_cancelled):
- ewk/ewk_frame.h:
- ewk/ewk_private.h:
Tools:
Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
and print out information that is expected by several test cases if
LayoutTestController's dumpFrameLoadCallback() returns true.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectCancelled):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- 8:34 AM Changeset in webkit [114632] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970
Reviewed by Pavel Feldman.
Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):
- inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):
- inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WorkerManager.js:
- page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):
- page/Console.h:
(Console):
- 8:26 AM Changeset in webkit [114631] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Zoom out on the second double click does not always scale right.
https://bugs.webkit.org/show_bug.cgi?id=84332
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-19
Reviewed by Simon Hausmann.
Zoom out to the minimum scale value instead of the fixed 1.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
- 8:21 AM April 2012 Meeting edited by
- (diff)
- 7:46 AM Changeset in webkit [114630] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r114628.
http://trac.webkit.org/changeset/114628
https://bugs.webkit.org/show_bug.cgi?id=84341
Breaks EFL and GTK builds (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-19
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WorkerManager.js:
- page/Console.cpp:
(WebCore):
(WebCore::Console::addMessage):
(WebCore::Console::warn):
- page/Console.h:
(Console):
- 6:42 AM Changeset in webkit [114629] by
-
- 2 edits in trunk/LayoutTests
Add expectation for flaky svg/custom/foreign-object-skew.svg
Unreviewed Chromium expectations fix.
- platform/chromium/test_expectations.txt:
- 6:28 AM Changeset in webkit [114628] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: x-frame security errors logged when typing in the console are annoying.
https://bugs.webkit.org/show_bug.cgi?id=81970
Reviewed by Pavel Feldman.
Parameter DoNotPauseOnExceptions in Runtime.evaluate() renamed to DoNotPauseOnExceptionsAndMuteConsole.
Added this parameter to Runtime.callFunctionOn() and passed true in all call sites.
Added this parameter to Debugger.evaluateOnCallFrame().
Added a flag to console that mutes all messages unless they have ConsoleAPI message source.
This flag is now temporarily set from InspectorRuntimeAgent and InspectorDebuggerAgent for certain injected source calls.
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::asBool):
(WebCore):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore):
(WebCore::setPauseOnExceptionsState):
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
(WebCore::InspectorRuntimeAgent::getProperties):
- inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore):
(WebCore::PageDebuggerAgent::unmuteConsole):
- inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore):
(WebCore::PageRuntimeAgent::unmuteConsole):
- inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::muteConsole):
(WebCore):
(WebCore::WorkerDebuggerAgent::unmuteConsole):
- inspector/WorkerDebuggerAgent.h:
(WorkerDebuggerAgent):
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::muteConsole):
(WebCore):
(WebCore::WorkerRuntimeAgent::unmuteConsole):
- inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
- inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.evaluate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.callFunction):
(WebInspector.RemoteObject.prototype.callFunctionJSON):
- inspector/front-end/WorkerManager.js:
- page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::warn):
(WebCore):
(WebCore::Console::mute):
(WebCore::Console::unmute):
- page/Console.h:
(Console):
- 6:11 AM Changeset in webkit [114627] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix Qt-Mac build after libxml patch
https://bugs.webkit.org/show_bug.cgi?id=84313
Use direct include/library paths instead of PKGCONFIG when on Mac.
Reviewed by Simon Hausmann.
No new tests, build fix.
- WebCore.pri:
- 5:08 AM Changeset in webkit [114626] by
-
- 6 edits3 adds in trunk
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265
Source/WebCore:
Reviewed by Pavel Feldman.
InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.
Test: http/tests/inspector/network/network-image-404.html
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::httpStatusCode):
(WebCore):
- inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
(ResourceData):
(NetworkResourcesData):
- inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):
LayoutTests:
- http/tests/inspector/network/network-image-404-expected.txt: Added.
- http/tests/inspector/network/network-image-404.html: Added.
- http/tests/inspector/network/resources/404.php: Added.
- 4:55 AM Changeset in webkit [114625] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening. Skip failing reftest after 114574.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-19
Reviewed by Csaba Osztrogonác.
- platform/qt/Skipped:
- 4:46 AM SelectiveTestBuildBot edited by
- (diff)
- 4:44 AM Changeset in webkit [114624] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=84323
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-19
Reviewed by Antonio Gomes.
PR 150750
Regardless of whether there's a WebPageCompositorClient, we want the
AnimationFrameRateController to manage animation frames.
Reviewed internally by Andrew Lo.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 4:39 AM SelectiveTestBuildBot edited by
- (diff)
- 4:39 AM Changeset in webkit [114623] by
-
- 10 edits in trunk
Web Inspector: reuse ParsedUrl in the UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=84326
Reviewed by Yury Semikhatsky.
Source/WebCore:
Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
TabbedEditorContainer.
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.SourceMapParser.prototype._canonicalizeURL):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
- inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get parsedURL):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- inspector/debugger/ui-source-code-display-name.html:
- 4:36 AM SelectiveTestBuildBot edited by
- (diff)
- 3:18 AM SelectiveTestBuildBot edited by
- fixes (diff)
- 2:57 AM SelectiveTestBuildBot edited by
- (diff)
- 2:08 AM Changeset in webkit [114622] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Build fix after r114575
https://bugs.webkit.org/show_bug.cgi?id=84322
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Simon Hausmann.
Build fix, adding WTF when linking jsc shell.
- shell/CMakeLists.txt:
- 12:20 AM Changeset in webkit [114621] by
-
- 2 edits in trunk/Source/WebCore
Optimize for DARWIN in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80256
Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-04-19
Reviewed by Chris Rogers.
- platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):
- 12:09 AM Changeset in webkit [114620] by
-
- 3 edits in releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg
Finish merge of r111601
- 12:07 AM Changeset in webkit [114619] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .
- http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added.
- 12:05 AM Changeset in webkit [114618] by
-
- 1 edit in releases/WebKitGTK/webkit-1.8/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
Fix failed merge
