Timeline
Jun 1, 2012:
- 11:44 PM Changeset in webkit [119314] by
-
- 19 edits in trunk/Tools
Rename test_expectations.txt to TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=86690
Reviewed by Dirk Pranke.
Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
We can the code to read test_expectations.txt once we've successfully transitioned.
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._check_path_does_not_exist):
(TestExpectationParser._tokenize):
(TestExpectations): Removed TEST_LIST, which is not used anywhere.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
test_expectations.txt if one exists and the path to TestExpectations otherwise.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
virtual.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.path_from_chromium_base):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.test_expectations):
- Scripts/webkitpy/layout_tests/port/test.py:
(add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
(TestPort.init):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort.baseline_search_path):
(WebKitPort.test_expectations):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
tests to base as a follow up.
(WebKitPortTest.test_path_to_test_expectations_file):
(test_test_expectations):
(test_legacy_test_expectations):
- Scripts/webkitpy/style/checker.py:
(CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
with one for TestExpectations.
- Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
test_expectations.txt.
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
(TestExpectationsTestCase.assert_lines_lint):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.init):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineExpectations):
- Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
- Scripts/webkitpy/tool/steps/commit_unittest.py:
(CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
(CommitTest.test_check_test_expectations): For TestExpectations.
(CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
- TestResultServer/static-dashboards/dashboard_base.js:
(requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
Error only when neither exists.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(processMissingAndExtraExpectations):
(htmlForTestsWithExpectationsButNoFailures):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- 11:07 PM Changeset in webkit [119313] by
-
- 61 edits1 copy1 add in trunk/Source
[chromium] Software compositor initialization and base classes
https://bugs.webkit.org/show_bug.cgi?id=87920
Patch by Alexandre Elias <aelias@google.com> on 2012-06-01
Reviewed by James Robinson.
Source/Platform:
Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore:
This introduces new wrapper class CCGraphicsContext and base class
CCRenderer which will be used for software compositing support.
If no GraphicsContext3D is available, early return for now.
No new tests. (No-op change in 3d mode.)
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
(Texture):
(BitmapCanvasLayerTextureUpdater):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):
(BitmapSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/CanvasLayerTextureUpdater.h:
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
(Texture):
(FrameBufferSkPictureCanvasLayerTextureUpdater):
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::Texture::updateRect):
(WebCore::ImageLayerTextureUpdater::updateTextureRect):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::CCRenderer::toGLMatrix):
(WebCore):
(WebCore::LayerRendererChromium::create):
(WebCore::CCRenderer::CCRenderer):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::copyPlaneToTexture):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
- platform/graphics/chromium/LayerRendererChromium.h:
(CCRenderer):
(WebCore::CCRenderer::~CCRenderer):
(WebCore::CCRenderer::ccContext):
(WebCore::CCRenderer::settings):
(WebCore::CCRenderer::viewportSize):
(WebCore::CCRenderer::viewportWidth):
(WebCore::CCRenderer::viewportHeight):
(WebCore::CCRenderer::projectionMatrix):
(WebCore::CCRenderer::windowMatrix):
(WebCore::CCRenderer::sharedGeometryQuad):
(WebCore):
(LayerRendererChromium):
- platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::upload):
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
- platform/graphics/chromium/LayerTextureSubImage.h:
(WebCore):
(LayerTextureSubImage):
- platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore):
(Texture):
- platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
- platform/graphics/chromium/ManagedTexture.h:
(WebCore):
(ManagedTexture):
- platform/graphics/chromium/RenderSurfaceChromium.cpp:
- platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::copyTexture):
- platform/graphics/chromium/TextureCopier.h:
(TextureCopier):
(AcceleratedTextureCopier):
- platform/graphics/chromium/TextureUploader.h:
(TextureUploader):
- platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::uploadTexture):
- platform/graphics/chromium/ThrottledTextureUploader.h:
(ThrottledTextureUploader):
- platform/graphics/chromium/cc/CCGraphicsContext.h: Copied from Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.h.
(WebCore):
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):
- platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::willDraw):
(WebCore::CCLayerImpl::bindContentsTexture):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore):
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::context):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::context):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::layerRenderer):
- platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
(CCProxy):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
(WebCore::CCScrollbarLayerImpl::willDraw):
- platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
- platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
- platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
- platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::reserveTextures):
- platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):
Source/WebKit/chromium:
Add a new setting to force software compositing. In this mode,
no GraphicsContext3D should ever be created.
- public/WebSettings.h:
- src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::context):
- src/WebLayerTreeViewImpl.cpp:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setForceSoftwareCompositing):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::forceSoftwareCompositing):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createCompositorGraphicsContext3D):
(WebKit::WebViewImpl::createContext3D):
- tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::CCLayerTreeHostImplTest::createContext):
(WebKitTests::TEST_F):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
- tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::Texture::updateRect):
- tests/CCTiledLayerTestCommon.h:
(Texture):
(WebKitTests::FakeTextureCopier::copyTexture):
(WebKitTests::FakeTextureUploader::uploadTexture):
- tests/Canvas2DLayerChromiumTest.cpp:
(Canvas2DLayerChromiumTest::fullLifecycleTest):
- tests/FakeCCLayerTreeHostClient.h:
- tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST):
- tests/TextureCopierTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
- 10:47 PM Changeset in webkit [119312] by
-
- 2 edits in trunk/LayoutTests
Suppress text diff on http/tests/media/video-buffered.html on Chromium Leopard as
it has been failing on Leopard since it was re-enabled in http://trac.webkit.org/changeset/119268.
The failure is tracked by the bug 88160.
- platform/chromium/test_expectations.txt:
- 8:20 PM Changeset in webkit [119311] by
-
- 19 edits2 deletes in trunk/Source
Unreviewed, rolling out r119283, r119287, and r119291.
http://trac.webkit.org/changeset/119283
http://trac.webkit.org/changeset/119287
http://trac.webkit.org/changeset/119291
https://bugs.webkit.org/show_bug.cgi?id=88159
Not only broke compilation in the initial commit but also
broke LayerChromiumTest.basicCreateAndDestroy (Requested by
rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
- platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
- platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::LinkHighlight):
- platform/graphics/chromium/cc/CCAnimationCurve.h:
(CCTransformAnimationCurve):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::add):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationControllerClient):
(CCLayerAnimationController):
- platform/graphics/chromium/cc/CCLayerImpl.h:
Source/WebKit/chromium:
- tests/CCAnimationTestCommon.cpp:
(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):
- tests/CCAnimationTestCommon.h:
- tests/CCKeyframedAnimationCurveTest.cpp:
- tests/CCLayerAnimationControllerTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
- tests/GraphicsLayerChromiumTest.cpp:
(WebKitTests::MockGraphicsLayerClient::notifyAnimationStarted):
(WebKitTests::MockGraphicsLayerClient::notifySyncRequired):
(WebKitTests::MockGraphicsLayerClient::paintContents):
(WebKitTests::MockGraphicsLayerClient::showDebugBorders):
(WebKitTests::MockGraphicsLayerClient::showRepaintCounter):
(WebKitTests::TEST):
- 8:17 PM Changeset in webkit [119310] by
-
- 2 edits in trunk/Source/WebCore
Large number constant in TransformationMatrix::projectPoint overflows FractionalLayoutUnits with sub-pixel layout enabled
https://bugs.webkit.org/show_bug.cgi?id=87896
Reviewed by James Robinson.
kLargeNumber is meant to avoid overflowing when projecting a point through a transform. Unfortunately,
due to FractionalLayoutUnit's diminished range compared to integers, we were overflowing anyways. This
change adjusts our large number by the same value, but adjusted for our denominator.
This was originally missed because transforms/3d is marked as pass/fail in Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=66989 tracks removing this problem.
No new tests. Covered by transforms/3d/hit-testing/perspective-clipped.html
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::projectPoint):
- 7:47 PM Changeset in webkit [119309] by
-
- 4 edits in trunk
Remove dependency from ImageDiff to WTF
https://bugs.webkit.org/show_bug.cgi?id=88147
Reviewed by Adam Barth.
Source/WTF:
- WTF.gyp/WTF.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 7:09 PM Changeset in webkit [119308] by
-
- 5 edits in trunk/Tools
NRWT seems to leak (more?) temp dirs
https://bugs.webkit.org/show_bug.cgi?id=88126
Re-land r119297 with chromium fix (weren't calling the
super() method if not in --test-shell mode in start().
Add unit tests to chromium_unittest as well to check.
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.start):
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_stop_cleans_up_properly):
(ChromiumDriverTest.test_two_starts_cleans_up_properly):
- 6:38 PM Changeset in webkit [119307] by
-
- 7 edits in trunk/Source/WebCore
Cleanup GeneratorGeneratedImage/Gradient changes from r117858
https://bugs.webkit.org/show_bug.cgi?id=88063
Reviewed by Simon Fraser.
No new tests, code cleanup.
- platform/graphics/Generator.h:
(WebCore::Generator::hash): hash() should be const.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::drawPattern): Minor cleanup.
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::Gradient): Rename m_hashCache to m_cachedHash.
(WebCore::Gradient::addColorStop): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::sortStopsIfNecessary): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setSpreadMethod): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setGradientSpaceTransform): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::hash): Use intHash instead of the pair hasher. Add compile time size checks
for structures being passed to StringHasher.
- platform/graphics/Gradient.h:
(WebCore::Gradient::setP0): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setP1): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setStartRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::setEndRadius): Rename clearHashCache to invalidateHash.
(WebCore::Gradient::invalidateHash): Rename clearHashCache to invalidateHash.
- platform/graphics/GraphicsContext.cpp:
(WebCore::scalesMatch): Added. Determine if the scale of two AffineTransforms match.
(WebCore::GraphicsContext::isCompatibleWithBuffer): Make use of scalesMatch to simplify the logic.
- 6:26 PM Changeset in webkit [119306] by
-
- 2 edits in trunk/LayoutTests
Skip more asserting tests on Windows.
- platform/win/Skipped:
- 6:26 PM Changeset in webkit [119305] by
-
- 2 edits in trunk/Tools
Lots of "failed download-built-product" on Apple bots
https://bugs.webkit.org/show_bug.cgi?id=88158
Reviewed by Jessie Berlin.
Disable mergeRequests on all Apple builders. This is a speculative fix.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:00 PM Changeset in webkit [119304] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r119297.
http://trac.webkit.org/changeset/119297
https://bugs.webkit.org/show_bug.cgi?id=88156
May have broken Chromium bots (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.del):
(WebKitDriver.run_test):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
- 5:22 PM Changeset in webkit [119303] by
-
- 3 edits3 adds in trunk
DFG CFA should know that PutByVal can clobber the world
https://bugs.webkit.org/show_bug.cgi?id=88155
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
LayoutTests:
- fast/js/dfg-putbyval-cfa-clobber-expected.txt: Added.
- fast/js/dfg-putbyval-cfa-clobber.html: Added.
- fast/js/script-tests/dfg-putbyval-cfa-clobber.js: Added.
(foo.bar):
(foo):
- 5:09 PM Changeset in webkit [119302] by
-
- 7 edits in trunk/Source/WebCore
Remove RefInfo class
https://bugs.webkit.org/show_bug.cgi?id=87904
Patch by Raymond Toy <Raymond Toy> on 2012-06-01
Reviewed by Chris Rogers.
No new tests; covered by existing tests.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::~AudioBufferSourceNode): Clear
panner node.
(WebCore::AudioBufferSourceNode::totalPitchRate):
(WebCore::AudioBufferSourceNode::setPannerNode): Use
RefTypeConnection counting for panner node.
(WebCore):
(WebCore::AudioBufferSourceNode::clearPannerNode): New function to
clear panner node in AudioBufferSourceNode.
(WebCore::AudioBufferSourceNode::finish): Clear panner node when done.
- Modules/webaudio/AudioBufferSourceNode.h:
(AudioBufferSourceNode): Add virtual finish(), m_pannerNode is not
a RefPtr anymore.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::addDeferredFinishDeref): Remove unneeded RefTyp.
(WebCore::AudioContext::handleDeferredFinishDerefs): Remove
unneeded RefType.
- Modules/webaudio/AudioContext.h:
(AudioContext): Update addDeferredFinishDeref signature.
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::deref): Update call to addDeferredFinishDeref.
- Modules/webaudio/AudioScheduledSourceNode.h:
(AudioScheduledSourceNode): Make finish() virtual.
- 4:54 PM Changeset in webkit [119301] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CFA should mark basic blocks as having constants if local accesses yield constants
https://bugs.webkit.org/show_bug.cgi?id=88153
Reviewed by Gavin Barraclough.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- 4:47 PM Changeset in webkit [119300] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG arguments simplification phase uses a node.codeOrigin after appending a node
https://bugs.webkit.org/show_bug.cgi?id=88151
Reviewed by Geoffrey Garen.
The right thing to do is to save the CodeOrigin before appending to the graph.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- 4:18 PM Changeset in webkit [119299] by
-
- 3 edits3 adds in trunk
DFG should not emit unnecessary speculation checks when performing an int32 to double conversion on
a value that is proved to be a number, predicted to be an int32, but not proved to be an int32
https://bugs.webkit.org/show_bug.cgi?id=88146
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
LayoutTests:
- fast/js/dfg-int32-to-double-on-known-number-expected.txt: Added.
- fast/js/dfg-int32-to-double-on-known-number.html: Added.
- fast/js/script-tests/dfg-int32-to-double-on-known-number.js: Added.
(foo.bar):
(foo):
- 4:18 PM Changeset in webkit [119298] by
-
- 60 edits in trunk
rename -webkit-flex-pack and -webkit-flex-line-pack to -webkit-justify-content and -webkit-align-content
https://bugs.webkit.org/show_bug.cgi?id=88113
Reviewed by Ojan Vafai.
Source/WebCore:
This recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#justify-content-property
http://dev.w3.org/csswg/css3-flexbox/#align-content-property
No new tests, updated existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EJustifyContent):
(WebCore::CSSPrimitiveValue::operator EAlignContent):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::initialJustifyContentOffset):
(WebCore::justifyContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::initialAlignContentOffset):
(WebCore::alignContentSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::alignFlexLines):
- rendering/RenderFlexibleBox.h:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
Find and replace for the CSS keywords.
- css3/flexbox/columns-auto-size.html:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/flexbox/flex-pack.html:
- css3/flexbox/multiline-align.html:
- css3/flexbox/multiline-column-auto.html:
- css3/flexbox/multiline-line-pack-expected.txt:
- css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
- css3/flexbox/multiline-line-pack-horizontal-column.html:
- css3/flexbox/multiline-line-pack.html:
- css3/flexbox/multiline-pack-expected.txt:
- css3/flexbox/multiline-pack.html:
- css3/flexbox/multiline-reverse-wrap-overflow.html:
- css3/flexbox/multiline-shrink-to-fit.html:
- css3/flexbox/multiline.html:
- css3/flexbox/nested-stretch.html:
- css3/flexbox/position-absolute-child.html:
- css3/flexbox/true-centering.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 4:11 PM Changeset in webkit [119297] by
-
- 3 edits in trunk/Tools
nrwt seems to leak tmpdirs
https://bugs.webkit.org/show_bug.cgi?id=88126
Reviewed by Ojan Vafai.
Fix leak possibly introduced in r118979 - we now will
make sure we clean up any stale temp directories during the
start routine and attempt to clean up again in del. It
turns out that asserting in del logs a message but is
caught by the runtime, so it's mostly useless.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.del):
(WebKitDriver._start):
(WebKitDriver.run_test):
- Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(WebKitDriverTest.test_check_for_driver_crash):
(WebKitDriverTest.test_stop_cleans_up_properly):
(WebKitDriverTest):
(WebKitDriverTest.test_two_starts_cleans_up_properly):
- 4:09 PM Changeset in webkit [119296] by
-
- 6 edits1 delete in trunk/LayoutTests
Make cookie tests debuggable by merging scripts into HTML
https://bugs.webkit.org/show_bug.cgi?id=88143
Reviewed by Anders Carlsson.
- http/tests/cookies/double-quoted-value-with-semi-colon.html:
- http/tests/cookies/multiple-cookies.html:
- http/tests/cookies/script-tests: Removed.
- http/tests/cookies/script-tests/TEMPLATE.html: Removed.
- http/tests/cookies/script-tests/double-quoted-value-with-semi-colon.js: Removed.
- http/tests/cookies/script-tests/multiple-cookies.js: Removed.
- http/tests/cookies/script-tests/simple-cookies-expired.js: Removed.
- http/tests/cookies/script-tests/simple-cookies-max-age.js: Removed.
- http/tests/cookies/script-tests/single-quoted-value.js: Removed.
- http/tests/cookies/simple-cookies-expired.html:
- http/tests/cookies/simple-cookies-max-age.html:
- http/tests/cookies/single-quoted-value.html:
- 3:59 PM Changeset in webkit [119295] by
-
- 1 edit48 adds in trunk/LayoutTests
[Win] Windows 7 Release Testers report many compositing failures
https://bugs.webkit.org/show_bug.cgi?id=88040
Part 2 of adding expected (failing?) results to get the bots greener.
- platform/win/compositing/images: Added.
- platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
- platform/win/compositing/images/direct-image-background-color-expected.txt: Added.
- platform/win/compositing/images/direct-pdf-image-expected.txt: Added.
- platform/win/compositing/images/direct-svg-image-expected.txt: Added.
- platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Added.
- platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Added.
- platform/win/compositing/layer-creation/overlap-animation-expected.txt: Added.
- platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Added.
- platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Added.
- platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Added.
- platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Added.
- platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Added.
- platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Added.
- platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
- platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
- platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Added.
- platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
- platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Added.
- platform/win/compositing/masks: Added.
- platform/win/compositing/masks/direct-image-mask-expected.txt: Added.
- platform/win/compositing/masks/masked-ancestor-expected.txt: Added.
- platform/win/compositing/masks/multiple-masks-expected.txt: Added.
- platform/win/compositing/masks/simple-composited-mask-expected.txt: Added.
- platform/win/compositing/overflow/ancestor-overflow-expected.txt
- platform/win/compositing/overflow/clip-descendents-expected.txt: Added.
- platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
- platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
- platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Added.
- platform/win/compositing/overflow/overflow-positioning-expected.txt: Added.
- platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Added.
- platform/win/compositing/overflow/resize-painting-expected.txt: Added.
- platform/win/compositing/rtl: Added.
- platform/win/compositing/rtl/rtl-absolute-expected.txt: Added.
- platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
- platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
- platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
- platform/win/compositing/rtl/rtl-relative-expected.txt: Added.
- platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
- platform/win/compositing/visibility: Added.
- platform/win/compositing/visibility/layer-visible-content-expected.txt: Added.
- platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
- 3:53 PM Changeset in webkit [119294] by
-
- 2 edits in trunk/Source/WebCore
Overflow scrolling doesn't need to create a stacking context is the overflow is hidden
https://bugs.webkit.org/show_bug.cgi?id=88057
Reviewed by James Robinson.
This patch causes us to match the iOS implementation of this feature.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 3:50 PM Changeset in webkit [119293] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 3:44 PM Changeset in webkit [119292] by
-
- 3 edits3 adds in trunk
DFG constant folding search for the last local access skips the immediately previous local access
https://bugs.webkit.org/show_bug.cgi?id=88141
Source/JavaScriptCore:
Reviewed by Michael Saboff.
If you use a loop in the style of:
for (i = start; i--;)
then you need to remember that the first value of 'i' that the loop body will see is 'start - 1'.
Hence the following is probably wrong:
for (i = start - 1; i--;)
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run):
LayoutTests:
Reviewed by Michael Saboff.
- fast/js/dfg-obvious-constant-cfa-expected.txt: Added.
- fast/js/dfg-obvious-constant-cfa.html: Added.
- fast/js/script-tests/dfg-obvious-constant-cfa.js: Added.
(bar.baz):
(bar):
- 3:43 PM Changeset in webkit [119291] by
-
- 2 edits in trunk/Source/WebKit/chromium
Use fully qualified name for Fixed to avoid the collision with "typedef SInt32 Fixed" in MacTypes.h
- tests/GraphicsLayerChromiumTest.cpp:
(WebKitTests::TEST_F):
- 3:34 PM Changeset in webkit [119290] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix the return value checking in SelectPopupClient
https://bugs.webkit.org/show_bug.cgi?id=88130
Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-01
Reviewed by Rob Buis.
In SelectPopupClient, return '1' means selected, '0' means not selected,
the ASCII value of '0' is 48, not 32, use '0' to be more readable.
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValueAndClosePopup):
- 3:32 PM Changeset in webkit [119289] by
-
- 1 edit4 adds in trunk/LayoutTests
Chromium rebaseline after r119274.
- platform/chromium-linux/fast/reflections/reflection-with-zoom-expected.png: Added.
- platform/chromium-mac-leopard/fast/reflections/reflection-with-zoom-expected.png: Added.
- platform/chromium-mac/fast/reflections/reflection-with-zoom-expected.png: Added.
- platform/chromium-win/fast/reflections/reflection-with-zoom-expected.png: Added.
- 3:15 PM Changeset in webkit [119288] by
-
- 2 edits in trunk/LayoutTests
Fix a typo in the expected result for the test added in r119281.119281
- fast/js/dfg-cse-cfa-discrepancy-expected.txt:
- 3:14 PM Changeset in webkit [119287] by
-
- 5 edits in trunk/Source
[chromium] Unreviewed compile fix for r119283
For the record, Dana Jensens <danakj@chromium.org> wrote this slightly faster than I did.
Source/WebCore:
- platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::bounds):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::bounds):
Source/WebKit/chromium:
- tests/CCAnimationTestCommon.h:
- 3:11 PM Changeset in webkit [119286] by
-
- 2 edits in trunk/LayoutTests
http/tests/cookies/simple-cookies-expired.html and simple-cookies-max-age.html are failing
https://bugs.webkit.org/show_bug.cgi?id=82749
I don't see any failures locally (other than sometimes as flakiness in all cookie
tests), and the bug report doesnt' have any information about what was wrong.
- platform/mac/Skipped: Re-enable to see what happens.
- 2:59 PM Changeset in webkit [119285] by
-
- 3 edits48 adds in trunk/LayoutTests
[Win] Windows 7 Release Testers report many compositing failures
https://bugs.webkit.org/show_bug.cgi?id=88040
Part 1 of adding expected (failing?) results to get the bots greener.
- platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Added.
- platform/win/compositing/geometry/foreground-layer-expected.txt: Added.
- platform/win/compositing/geometry/foreground-offset-change-expected.txt: Added.
- platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
- platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
- platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
- platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
- platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/win/compositing/geometry/outline-change-expected.txt: Added.
- platform/win/compositing/geometry/partial-layout-update-expected.txt: Added.
- platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/win/compositing/geometry/root-layer-update-expected.txt: Added.
- platform/win/compositing/geometry/tall-page-composited-expected.txt: Added.
- platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
- platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
- platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Added.
- platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Added.
- platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
- platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
- platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
- platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Added.
- platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
- platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
- platform/win/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
- platform/win/compositing/iframes/invisible-iframe-expected.txt: Added.
- platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Added.
- platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Added.
- platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
- platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Added.
- platform/win/compositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
- platform/win/compositing/iframes/resizer-expected.txt: Added.
- platform/win/compositing/iframes/scrolling-iframe-expected.txt: Added.
- 2:53 PM Changeset in webkit [119284] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, adding a TEXT expectation for http/tests/media/video-buffered.html
after it started failing in r119268.
- platform/gtk/test_expectations.txt:
- 2:46 PM Changeset in webkit [119283] by
-
- 18 edits2 adds in trunk/Source
[chromium] Accelerated animations should use WebTransformOperations
https://bugs.webkit.org/show_bug.cgi?id=87686
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-01
Reviewed by James Robinson.
CCTransformKeyframe new owns a WebTransformOperations rather than a
TransformOperations. LayerChromium's API has been changed so that
LayerChromium::addAnimation should take only a CCActiveAnimation.
GraphicsLayerChromium is new responsible for translating to
WebTransformOperations and creating CCActiveAnimations. Tests that use
the public API (that is, they call addAnimation with KeyframeValueList
and Animation arguments) have been moved to GraphicsLayerChromiumTest.
Source/WebCore:
Unit tests:
GraphicsLayerChromiumTest.createOpacityAnimation
GraphicsLayerChromiumTest.createTransformAnimation
GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
GraphicsLayerChromiumTest.createReversedAnimation
GraphicsLayerChromiumTest.createAlternatingAnimation
GraphicsLayerChromiumTest.createReversedAlternatingAnimation
- WebCore.gypi:
- platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.
(WebCore):
(WebCore::toWebTransformOperations):
(WebCore::appendKeyframe):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):
- platform/graphics/chromium/AnimationTranslationUtil.h: Added.
(WebCore):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::addAnimation):
- platform/graphics/chromium/LayerChromium.h:
(WebCore):
(LayerChromium):
- platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::LinkHighlight):
- platform/graphics/chromium/cc/CCAnimationCurve.h:
(CCTransformAnimationCurve):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCTransformKeyframe::create):
(WebCore::CCTransformKeyframe::CCTransformKeyframe):
(WebCore::CCTransformKeyframe::value):
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCTransformKeyframe):
(CCKeyframedTransformAnimationCurve):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::removeAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::addAnimation):
(WebCore::CCLayerAnimationController::getActiveAnimation):
(WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
(WebCore::CCLayerAnimationController::tickAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(CCLayerAnimationControllerClient):
(CCLayerAnimationController):
Source/WebKit/chromium:
- tests/CCAnimationTestCommon.cpp:
(WebCore::addOpacityTransition):
(WebCore::addAnimatedTransform):
(WebKitTests::FakeTransformTransition::getValue):
- tests/CCAnimationTestCommon.h:
- tests/CCKeyframedAnimationCurveTest.cpp:
(WebCore::TEST):
- tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
- tests/GraphicsLayerChromiumTest.cpp:
(MockLayerTreeHostClient):
(WebKitTests):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
(WebKitTests::GraphicsLayerChromiumTest::expectTranslateX):
(WebKitTests::TEST_F):
- 2:34 PM Changeset in webkit [119282] by
-
- 2 edits in trunk/LayoutTests
DFG constant folding should be OK with GetLocal of captured variables having a constant
https://bugs.webkit.org/show_bug.cgi?id=88137
Fix a typo that Gavin found but that I failed to fix in previous commit.
- fast/js/script-tests/dfg-cse-cfa-discrepancy.js:
- 2:32 PM Changeset in webkit [119281] by
-
- 3 edits3 adds in trunk
DFG constant folding should be OK with GetLocal of captured variables having a constant
https://bugs.webkit.org/show_bug.cgi?id=88137
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run):
LayoutTests:
- fast/js/dfg-cse-cfa-discrepancy-expected.txt: Added.
- fast/js/dfg-cse-cfa-discrepancy.html: Added.
- fast/js/script-tests/dfg-cse-cfa-discrepancy.js: Added.
(foo.bar.baz):
(foo.bar):
(foo):
- 2:26 PM Changeset in webkit [119280] by
-
- 4 edits in trunk
WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
https://bugs.webkit.org/show_bug.cgi?id=88109
Reviewed by Geoffrey Garen.
Source/WebKit/mac:
Added short circuit return when the NSString to evaluate is nil.
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
Tools:
Additional test case.
- TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
(TestWebKitAPI::TEST):
- 2:04 PM Changeset in webkit [119279] by
-
- 2 edits in trunk/LayoutTests
[Win] ASSERT(enclosingIntRect(rendererMappedResult) == enclosingIntRect(FloatQuad(result).boundingBox()))
failed in RenderGeometryMap::absoluteRect
https://bugs.webkit.org/show_bug.cgi?id=88128
Add affected tests to the Windows Skipped list.
- platform/win/Skipped:
Also, fix the line endings for this file.
- 2:00 PM Changeset in webkit [119278] by
-
- 1 edit6 adds in trunk/LayoutTests
Unreviewed GTK gardening, adding new baselines after r119256.
- platform/gtk/fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
- platform/gtk/fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
- 1:47 PM Changeset in webkit [119277] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131
Unreviewed addition to Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 1:23 PM Changeset in webkit [119276] by
-
- 5 edits in trunk
Improve synchronous XHR disabling
https://bugs.webkit.org/show_bug.cgi?id=88032
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setSyncXHRInDocumentsEnabled): Fix a
copy-and-paste error
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open): Improves the disabled message, as
suggested in a comment after r118599 was put in the commit queue.
LayoutTests:
Update with new error message.
- fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt:
- 1:22 PM Changeset in webkit [119275] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix QObject bridge tests in Qt5 after (not so) recent QVariant changes
https://bugs.webkit.org/show_bug.cgi?id=88127
Reviewed by Noam Rosenthal.
We were checking for invalid QVariants in a very odd way. Since in Qt5 the
userType of invalid changed to not be Void, this broke the tests for QtWebKit
with Qt5. Replace those checks with QVariant::isValid() calls.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::evalJS):
(tst_QObjectBridge::evalJSV):
- 1:20 PM Changeset in webkit [119274] by
-
- 4 edits3 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=87774
REGRESSION (r105515): reflection masks are truncated at zoom levels < 1
-and corresponding-
<rdar://problem/11387506>
Reviewed by Simon Fraser.
Source/WebCore:
paintNinePieceImage() expects un-zoomed results from
calculateImageIntrinsicDimensions(). This was previously addressed by having
paintNinePieceImage() divide the effective zoom out of the result from
calculateImageIntrinsicDimensions(). However, that results in buggy behavior for
generated images and images with percentage sizes. In the end it seems best to
just send a parameter to calculateImageIntrinsicDimensions() indicating whether
the caller wants the result to be scaled by the effective zoom when appropriate.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
LayoutTests:
- fast/reflections/reflection-with-zoom.html: Added.
- platform/mac/fast/reflections/reflection-with-zoom-expected.png: Added.
- platform/mac/fast/reflections/reflection-with-zoom-expected.txt: Added.
- 1:15 PM Changeset in webkit [119273] by
-
- 2 edits in trunk/LayoutTests
Another Chromium test expectation update per the bug 88124.
Unreviewed Chromium test expectations fix.
- platform/chromium/test_expectations.txt:
- 1:15 PM Changeset in webkit [119272] by
-
- 6 edits in trunk/Source/WebCore
Prepare table collapsed border computation to support mixed directionality on row group
https://bugs.webkit.org/show_bug.cgi?id=88110
Reviewed by Ojan Vafai.
No expected change in behavior.
One big issue with supporting mixed directionality inside a table is that the start / end
borders don't align between table parts anymore: the start border of a ltr table will have
to match the end border of a rtl row group for the purpose of collapsed border computation.
This change adds the concept of adjoining borders in the table direction so that we can safely
hide which exact borders we pick up for the collapsed border computation.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
Refactored those functions to use proper naming along with the new APIs. The name 'adjoining' is
used extensively as we cannot make any assumptions on which borders we will get.
(WebCore::RenderTable::recalcBordersInRowDirection):
Added a FIXME found during testing.
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::borderAdjoiningTableStart):
(WebCore::RenderTableCell::borderAdjoiningTableEnd):
- rendering/RenderTableRow.h:
(WebCore::RenderTableRow::borderAdjoiningTableStart):
(WebCore::RenderTableRow::borderAdjoiningTableEnd):
- rendering/RenderTableSection.h:
(WebCore::RenderTableSection::borderAdjoiningTableStart):
(WebCore::RenderTableSection::borderAdjoiningTableEnd):
Those functions are the same at the moment to match the existing code. They
will be changed to use the proper directionality in a follow up patch.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
(WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
Those functions return the cells that is adjoining a table edge. Due to us flipping
the cells at layout to match the section's direction, those functions will need to
account for mixed direction in determining the right cell to consider.
- 1:13 PM Changeset in webkit [119271] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline of svg/css/getComputedStyle-basic for mac.
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- 1:08 PM Changeset in webkit [119270] by
-
- 3 edits4 adds in trunk
Indenting a paragraph that begins with a link 3 times breaks the paragraph into two paragraphs
https://bugs.webkit.org/show_bug.cgi?id=87428
Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-01
Reviewed by Ryosuke Niwa.
Source/WebCore:
Fix the way lastNode (our insertion point) is updated whenever
traverseNextSibling moves up to a new parent, so that the relative
depth between the next sibling and the original start node is
maintained in the clone. The divergence in depth broke the paragraph
into two paragraphs because the next sibling was inserted outside the
blockquote that was created for the indentation.
Note that the topNode is not required anymore because it is no longer
used anywhere.
Tests: editing/execCommand/indent-nested-inlines-1.html
editing/execCommand/indent-nested-inlines-2.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
LayoutTests:
Adding two tests for indenting nested inlines.
- editing/execCommand/indent-nested-inlines-1-expected.txt: Added.
- editing/execCommand/indent-nested-inlines-1.html: Added.
- editing/execCommand/indent-nested-inlines-2-expected.txt: Added.
- editing/execCommand/indent-nested-inlines-2.html: Added.
- 1:00 PM Changeset in webkit [119269] by
-
- 5 edits in trunk
[Qt] Use -Werror only in developer builds
Rubber-stamped by Tor Arne Vestbø.
In production builds -Werror with custom toolchains and wierd system
headers, -Werror is of no use and just creates confusion. So use it
only if Qt is configured with -developer-build.
.:
- Source/api.pri: qt_developer_build determination moved to default_pre.prf
Tools:
- qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
- qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
only if qt_developer_build is set.
- 12:58 PM Changeset in webkit [119268] by
-
- 4 edits in trunk/LayoutTests
[chromium] Unskip http/tests/media/video-buffered.html
https://bugs.webkit.org/show_bug.cgi?id=87568
Reviewed by Eric Carlson.
- http/tests/media/video-buffered-expected.txt:
- http/tests/media/video-buffered.html:
- platform/chromium/test_expectations.txt:
- 12:57 PM Changeset in webkit [119267] by
-
- 4 edits1 copy2 adds in trunk
[Qt] Move QObject bridge related tests from tst_qwebframe to tst_qobjectbridge
https://bugs.webkit.org/show_bug.cgi?id=88117
Reviewed by Noam Rosenthal.
.:
- Source/tests.pri: Add new entry for tst_qobjectbridge.
Source/WebKit/qt:
Five tests (classEnums, classConstructor, transferInvokable, findObject and
findChildren) were removed since they contained commented code since the file was
added back in 2008. The QObject bridge tests were probably inspired in similar
tests for QtScript, so many features not yet implemented were present in QtWebKit
tests but commented.
Other minor changes:
- Moved MyEnumTestQObject near the only test function that uses it.
- Removed unnecessary Q_INVOKABLE from setBrushProperty.
- Removed some bits of dead / commented code.
- tests/qobjectbridge/qobjectbridge.pro: Added.
- tests/qobjectbridge/tst_qobjectbridge.cpp: Copied from Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp.
Kept only the tests related to QObject bridge implementation.
- tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame):
(tst_QWebFrame::init):
(tst_QWebFrame::cleanup):
- 12:52 PM Changeset in webkit [119266] by
-
- 2 edits in trunk/Tools
[watchlist] Add myself to loader and v8 bindings changes
https://bugs.webkit.org/show_bug.cgi?id=88112
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/watchlist:
- 12:41 PM Changeset in webkit [119265] by
-
- 2 edits in trunk/LayoutTests
Another Chromium test expectation update per the bug 88124.
- platform/chromium/test_expectations.txt:
- 12:39 PM Changeset in webkit [119264] by
-
- 2 edits in trunk/Tools
Adding Jacky Jiang to committers.py
https://bugs.webkit.org/show_bug.cgi?id=88122
Reviewed by Rob Buis.
Adding myself to committers.py as a Committer.
- Scripts/webkitpy/common/config/committers.py:
- 12:38 PM Changeset in webkit [119263] by
-
- 3 edits in branches/safari-536-branch/LayoutTests
Update test results after r119025
- platform/mac/mathml/presentation/mo-stretch-expected.txt: Clearly incorrect results were landed for this test, not sure how that happened (I cannot find these wrong results anywhere in trunk history).
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt: Looks like this test was not updated with others. The only observable difference is a slightly smaller width of an input field, which matches what one could expect from the change.
- 12:32 PM Changeset in webkit [119262] by
-
- 2 edits in trunk/LayoutTests
Chromium test expectation update.
- platform/chromium/test_expectations.txt:
- 12:32 PM Changeset in webkit [119261] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call
Followup to r119260
Rubber-stamped by Anders Carlsson.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow): Set the m_hasCalledSetWindow here...
(WebKit::NetscapePlugin::geometryDidChange): ...instead of here.
- 12:24 PM Changeset in webkit [119260] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/11335622> and https://bugs.webkit.org/show_bug.cgi?id=88119
REGRESSION (r99448) Zero-sized plug-ins no longer get an NPP_SetWindow call
Reviewed by Oliver Hunt.
Add a flag to NetscapePlugin to track whether or not NPP_SetWindow has ever been called.
Check this flag in geometryDidChange to make sure every plug-in gets the call at least once.
"Everybody gets one. Tell him, Peter."
"Apparently everybody gets one."
"Bingo."
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::geometryDidChange):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
- 12:00 PM Changeset in webkit [119259] by
-
- 7 edits in trunk
getComputedStyle for background shorthand property does not return background-origin and background-clip.
https://bugs.webkit.org/show_bug.cgi?id=86155
Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-01
Reviewed by Tony Chang.
Added background-origin and background-clip CSS Property values to the background shorthand CSSValueList.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getBackgroundShorthandValue):
LayoutTests:
- fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
- fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
- 11:55 AM Changeset in webkit [119258] by
-
- 14 edits1 delete in trunk/Source
[Chromium] Call clipboard methods directly
https://bugs.webkit.org/show_bug.cgi?id=88038
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
- chromium/public/WebClipboard.h:
(WebKit::WebClipboard::sequenceNumber):
Source/WebCore:
- WebCore.gypi:
- platform/Pasteboard.h:
(Pasteboard):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::createFromPasteboard):
- platform/chromium/ChromiumDataObjectItem.cpp:
(WebCore::ChromiumDataObjectItem::getAsFile):
(WebCore::ChromiumDataObjectItem::internalGetAsString):
- platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::currentPasteboardBuffer):
- platform/chromium/ClipboardUtilitiesChromium.h:
(WebCore):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::writeClipboard):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
- platform/chromium/PasteboardPrivate.h: Removed.
- platform/chromium/PlatformSupport.h:
(WebCore):
(PlatformSupport):
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- src/PlatformSupport.cpp:
(WebCore::getCookieJar):
- 11:33 AM Changeset in webkit [119257] by
-
- 2 edits in trunk/Tools
Fix Windows build.
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
- 11:24 AM Changeset in webkit [119256] by
-
- 6 edits26 adds in trunk
Improve handling of legacy viewport meta tags
https://bugs.webkit.org/show_bug.cgi?id=55874
Patch by Hugo Parente Lima <Hugo Parente Lima> on 2012-06-01
Reviewed by Adam Barth.
Source/WebCore:
We now support MobileOptimized and HandheldFriendly as well.
We set width equal to device-width for HandheldFriendly and
for MobileOptimized, the content value of MobileOptimized is
ignored and the initial-scale set to 1 to fit Android behavior.
The prioritizing is done the same way as on Windows Phone 7:
XHTML Mobile Profile found
HandheldFriendly
MobileOptimized (overrides HandheldFriendly)
Viewport (overrides all above)
Original patch by Kenneth Rohde Christiansen.
Tests: fast/viewport/viewport-legacy-handheldfriendly.html
fast/viewport/viewport-legacy-mobileoptimized-2.html
fast/viewport/viewport-legacy-mobileoptimized-3.html
fast/viewport/viewport-legacy-mobileoptimized.html
fast/viewport/viewport-legacy-ordering-1.html
fast/viewport/viewport-legacy-ordering-2.html
fast/viewport/viewport-legacy-ordering-3.html
fast/viewport/viewport-legacy-ordering-4.html
fast/viewport/viewport-legacy-ordering-5.html
fast/viewport/viewport-legacy-ordering-6.html
fast/viewport/viewport-legacy-ordering-7.html
fast/viewport/viewport-legacy-ordering-8.html
fast/viewport/viewport-legacy-ordering-9.html
- dom/Document.cpp:
(WebCore::Document::setDocType):
(WebCore::Document::processViewport): Add an origin parameter to
tell what is changing the viewport.
- dom/Document.h:
(Document):
- dom/ViewportArguments.h:
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process):
LayoutTests:
Add tests and expected results.
- fast/viewport/viewport-legacy-handheldfriendly-expected.txt: Added.
- fast/viewport/viewport-legacy-handheldfriendly.html: Added.
- fast/viewport/viewport-legacy-mobileoptimized-2-expected.txt: Added.
- fast/viewport/viewport-legacy-mobileoptimized-2.html: Added.
- fast/viewport/viewport-legacy-mobileoptimized-3-expected.txt: Added.
- fast/viewport/viewport-legacy-mobileoptimized-3.html: Added.
- fast/viewport/viewport-legacy-mobileoptimized-expected.txt: Added.
- fast/viewport/viewport-legacy-mobileoptimized.html: Added.
- fast/viewport/viewport-legacy-ordering-1-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-1.html: Added.
- fast/viewport/viewport-legacy-ordering-2-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-2.html: Added.
- fast/viewport/viewport-legacy-ordering-3-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-3.html: Added.
- fast/viewport/viewport-legacy-ordering-4-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-4.html: Added.
- fast/viewport/viewport-legacy-ordering-5-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-5.html: Added.
- fast/viewport/viewport-legacy-ordering-6-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-6.html: Added.
- fast/viewport/viewport-legacy-ordering-7-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-7.html: Added.
- fast/viewport/viewport-legacy-ordering-8-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-8.html: Added.
- fast/viewport/viewport-legacy-ordering-9-expected.txt: Added.
- fast/viewport/viewport-legacy-ordering-9.html: Added.
- 11:10 AM Changeset in webkit [119255] by
-
- 43 edits in trunk
rename -webkit-flex-order to -webkit-order
https://bugs.webkit.org/show_bug.cgi?id=88104
Reviewed by Ojan Vafai.
Source/WebCore:
This recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#order-property
No new tests, just updated existing results.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
(WebCore::RenderFlexibleBox::OrderIterator::next):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::packFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):
- rendering/RenderFlexibleBox.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
Just a find and replace for the new property name.
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/flexbox/flex-order.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 10:50 AM Changeset in webkit [119254] by
-
- 2 edits1 copy1 move2 adds in trunk/LayoutTests
[Chromium] Unreviewed. Adding Win and Mac baselines after r119241.
Patch by Florin Malita <fmalita@chromium.org> on 2012-06-01
- platform/chromium-mac/svg/repaint/text-mask-update-expected.png: Added.
- platform/chromium-mac/svg/repaint/text-mask-update-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
- platform/chromium-win/svg/repaint/text-mask-update-expected.png: Added.
- platform/chromium-win/svg/repaint/text-mask-update-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/repaint/text-mask-update-expected.txt.
- platform/chromium/test_expectations.txt:
- 10:31 AM Changeset in webkit [119253] by
-
- 5 edits2 adds in trunk/LayoutTests
[Win] 9 plugin tests fail/time out
https://bugs.webkit.org/show_bug.cgi?id=88107
Skip the ones that time out and add/update platform-specific results for the the ones that
fail to get the bots greener.
- platform/win/Skipped:
- platform/win/plugins/get-value-netscape-window-expected.txt:
- platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Added.
- platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt:
- platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt:
- platform/win/plugins/geturlnotify-during-document-teardown-expected.txt
- 10:26 AM Changeset in webkit [119252] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r119247.
Do not include TextureMapperGL.h when not building
with GRAPHICS_SURFACE.
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
- 10:16 AM Changeset in webkit [119251] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] WebLayerTreeRenderer::setContentsSize called synchronously
https://bugs.webkit.org/show_bug.cgi?id=88091
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Noam Rosenthal.
Do not call WebLayerTreeRenderer::setContentsSize synchronously
from LayerTreeHostProxy.
- UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setContentsSize):
- 10:09 AM Changeset in webkit [119250] by
-
- 2 edits in trunk/Tools
Windows WK2 MouseMoveAfterCrash API test failing
https://bugs.webkit.org/show_bug.cgi?id=69982
Disable the test on Windows to get the bots greener.
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
(TestWebKitAPI::TEST):
- 10:05 AM Changeset in webkit [119249] by
-
- 3 edits4 adds in trunk/Source/WebCore
[GTK] Add a new and reusable Geoclue-based geolocation provider in WebCore
https://bugs.webkit.org/show_bug.cgi?id=87800
Reviewed by Carlos Garcia Campos.
Added new and reusable Geoclue-based geolocation provider to WebCore.
- GNUmakefile.am:
- GNUmakefile.list.am:
- platform/geoclue/GeolocationProviderGeoclue.cpp: Added.
(getPositionCallback):
(positionChangedCallback):
(GeolocationProviderGeoclue::GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::~GeolocationProviderGeoclue):
(GeolocationProviderGeoclue::startUpdating):
(GeolocationProviderGeoclue::stopUpdating):
(GeolocationProviderGeoclue::setEnableHighAccuracy):
(GeolocationProviderGeoclue::setGeoclueClient):
(GeolocationProviderGeoclue::setGeocluePosition):
(GeolocationProviderGeoclue::updateClientRequirements):
(GeolocationProviderGeoclue::positionChanged):
(GeolocationProviderGeoclue::errorOccured):
- platform/geoclue/GeolocationProviderGeoclue.h: Added.
(WebCore):
(GeolocationProviderGeoclue):
- platform/geoclue/GeolocationProviderGeoclueClient.h: Added.
(WebCore):
(GeolocationProviderGeoclueClient):
- 10:04 AM Changeset in webkit [119248] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove deprecated Q_GLOBAL_STATIC_WITH_INITIALIZER
https://bugs.webkit.org/show_bug.cgi?id=88100
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.
It will be deprecated on Qt5.
- platform/text/qt/TextBreakIteratorInternalICUQt.cpp:
(WebCore):
- 10:02 AM Changeset in webkit [119247] by
-
- 7 edits in trunk/Source/WebCore
Make TextureMapper work with GraphicsSurface.
https://bugs.webkit.org/show_bug.cgi?id=87738
Add TextureMapperSurfaceBackingStore, a new backing store
that allows to import textures from a GraphicsSurface.
On Mac the GraphicsSurface is backed by an IOSurface
which must be used with a GL_TEXTURE_RECTANGLE_ARB texture.
Therefore it is also necessary to add new shader programs
for directly painting these textures on screen.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
Add a new TextureMapperBackingStore implementation that can directly
reuse textures as they are being passed from the GraphicsSurface.
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperBackingStore.h:
(GraphicsSurfaceData):
(WebCore::GraphicsSurfaceData::setSurface):
(WebCore::GraphicsSurfaceData::GraphicsSurfaceData):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):
- platform/graphics/texmap/TextureMapperGL.cpp:
Add a drawing function for textures of type GL_TEXTURE_RECTANGLE_ARB.
(WebCore::TextureMapperGL::drawTextureRectangleARB):
- platform/graphics/texmap/TextureMapperShaderManager.cpp:
(WebCore::TextureMapperShaderManager::getShaderProgram):
(WebCore::TextureMapperShaderProgramSimple::create):
(WebCore::TextureMapperShaderProgramSimple::initialize):
(WebCore::TextureMapperShaderProgramSolidColor::create):
(WebCore::TextureMapperShaderProgramSolidColor::initialize):
(WebCore::TextureMapperShaderProgramRectSimple::create):
(WebCore::TextureMapperShaderProgramRectSimple::fragmentShaderSource):
(WebCore::TextureMapperShaderProgramOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramOpacityAndMask::initialize):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::create):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::fragmentShaderSource):
- platform/graphics/texmap/TextureMapperShaderManager.h:
Add new shader programs that can be used with GL_TEXTURE_RECTANGLE_ARB textures.
This is mainly necessary, because this type of texture uses non-normalized coordinates.
Further move the calls to initializeProgram() from the constructor into a separate
initialize() function, as initializeProgram() calls vertexShaderSource() (and friends)
and we should not call virtual functions in the constructor.
(WebCore::TextureMapperShaderProgram::initialize):
(TextureMapperShaderProgramSimple):
(WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
(TextureMapperShaderProgramRectSimple):
(WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple):
(TextureMapperShaderProgramOpacityAndMask):
(WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
(TextureMapperShaderProgramRectOpacityAndMask):
(WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask):
(TextureMapperShaderProgramSolidColor):
(WebCore::TextureMapperShaderProgramSolidColor::TextureMapperShaderProgramSolidColor):
- 9:57 AM Changeset in webkit [119246] by
-
- 2 edits in trunk/LayoutTests
Skip some plugin tests that crash/assert on Windows.
- platform/win/Skipped:
- 9:50 AM Changeset in webkit [119245] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Set QWebKitTest::isScalable default as false
https://bugs.webkit.org/show_bug.cgi?id=88095
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Tor Arne Vestbø.
Set QWebKitTest::isScalable default as false
- UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::isScalable):
- 9:41 AM Changeset in webkit [119244] by
-
- 2 edits2 copies in branches/chromium/1084
Merge 117365 - Crash if SVG gradient stop has display: none set
- 9:35 AM Changeset in webkit [119243] by
-
- 19 edits in trunk
[EFL] EFL port does not enable WEB_INTENTS_TAG flag
https://bugs.webkit.org/show_bug.cgi?id=86866
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Adam Barth.
.:
Enable WEB_INTENTS_TAG flag by default on EFL port.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Fix compilation error when WEB_INTENTS_TAG flag is enabled.
HTMLElement::insertedInto() takes a ContainerNode* in argument, not a
Node*.
Test: webintents/intent-tag.html
- CMakeLists.txt:
- html/HTMLIntentElement.cpp:
(WebCore::HTMLIntentElement::insertedInto):
- html/HTMLIntentElement.h:
(HTMLIntentElement):
Source/WebKit/efl:
Implement registerIntentService() in EFL's FrameLoaderClient.
Emit a "intent,service,register" signal on the frame when a new Web
Intent service registers.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore):
(WebCore::FrameLoaderClientEfl::registerIntentService):
- WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
- ewk/ewk_frame.cpp:
(ewk_frame_intent_service_register):
- ewk/ewk_frame.h:
- ewk/ewk_frame_private.h:
Tools:
Catch new "intent,service,register" signal on the frame and print out
information about the Web Intent service in EFL's DumpRenderTree.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameIntentServiceRegistration):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
Unskip webintents/intent-tag.html now that the WEB_INTENTS_TAG flag is
enabled by default on EFL port.
- platform/efl/test_expectations.txt:
- 9:19 AM Changeset in webkit [119242] by
-
- 7 edits in trunk
[cairo] Pixel artifacts can be seen on reflections
https://bugs.webkit.org/show_bug.cgi?id=85483
Source/WebCore:
Antialiased clipping in the simple rectangular clip method
leads to edge artifacts when transformations are applied to the layer.
Explicitly disabling antialiased clipping for this function solves this issue.
Comparing Cairo GraphicsContext to Qt and Skia GC, it seems that these
backends do not expect the platform context to clip antialiased in this
case either.
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.
No new tests, covered by fast/css/transformed-mask.html.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clip):
LayoutTests:
Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-01
Reviewed by Martin Robinson.
Rebaselining the relevant test case for GTK and EFL.
- platform/efl/fast/css/transformed-mask-expected.png:
- platform/efl/fast/css/transformed-mask-expected.txt:
- platform/efl/test_expectations.txt:
- platform/gtk/fast/css/transformed-mask-expected.png:
- 9:03 AM Changeset in webkit [119241] by
-
- 5 edits3 adds in trunk
http://shinydemos.com/clock/ doesn't seem to work
https://bugs.webkit.org/show_bug.cgi?id=79682
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Test: svg/repaint/text-mask-update.svg
Currently, parent resources are not invalidated when SVGInlineText nodes
are added or removed. Adjusting SVGResourcesCache::clientWasAddedToTree()
and SVGResourcesCache::clientWillBeRemovedFromTree() to cover this case.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):
LayoutTests:
- platform/chromium-linux/svg/repaint/text-mask-update-expected.png: Added.
- platform/chromium-linux/svg/repaint/text-mask-update-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/test_expectations.txt:
- svg/repaint/text-mask-update.svg: Added.
- 9:03 AM Changeset in webkit [119240] by
-
- 3 edits in trunk/Tools
The ChangeLog parser cannot handle reviewers with initials in their name
https://bugs.webkit.org/show_bug.cgi?id=87864
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-01
Reviewed by Ryosuke Niwa.
Add support in the ChangeLog parser for reviewer names that have
initials in them.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Add a new group of regular expressions that need a backreference
in the replacement string. This allows for matching the word characters before a
period, without totally throwing them away.
(ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
- 9:00 AM Changeset in webkit [119239] by
-
- 7 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add end editing handling into AutofillManager
https://bugs.webkit.org/show_bug.cgi?id=88071
Patch by Jonathan Dong <Jonathan Dong> on 2012-06-01
Reviewed by Rob Buis.
RIM PR: 160857
Implemented EditorClientBlackBerry::textFieldDidEndEditing
to notify AutofillManager to send the dismissing autofill
dialog notification to webpage client.
No new tests since there is no behavior changes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyDismissAutofillDialog):
(WebKit):
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/AutofillManager.cpp:
(WebCore::AutofillManager::textFieldDidEndEditing):
(WebCore):
- WebCoreSupport/AutofillManager.h:
(AutofillManager):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
- 8:56 AM Changeset in webkit [119238] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] ewk_intent_data_get() is not needed and can be removed
https://bugs.webkit.org/show_bug.cgi?id=88072
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Adam Barth.
Remove ewk_intent_data_get() method from Ewk_Intent. Intent data is
serialized and does not need to be publicly exposed. The browser only
needs action and type to match with services.
- ewk/ewk_intent.cpp:
(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_free):
- ewk/ewk_intent.h:
- 8:49 AM Changeset in webkit [119237] by
-
- 18 edits in trunk
[EFL] EFL's LayoutTestController needs to implement deliverWebIntent
https://bugs.webkit.org/show_bug.cgi?id=86865
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Adam Barth.
Source/WebKit:
Add "${WEBCORE_DIR}/dom/default" to include directories in
CMakeLists.txt.
- CMakeLists.txt:
Source/WebKit/efl:
Add method on Ewk_Frame to deliver an intent.
Add helper function to DumpRenderTreeSupportEfl to deliver a Web
Intent.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::deliverWebIntent):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
- ewk/ewk_frame.cpp:
(ewk_frame_intent_deliver):
- ewk/ewk_frame.h:
Tools:
Add deliverWebIntent method to LayoutTestController and provide
implementation for EFL port.
- DumpRenderTree/LayoutTestController.cpp:
(deliverWebIntentCallback):
(LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
- DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::deliverWebIntent):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::deliverWebIntent):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::deliverWebIntent):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::deliverWebIntent):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::deliverWebIntent):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::deliverWebIntent):
LayoutTests:
Unskip webintents/web-intents-delivery.html now that Web intent
delivery is implemented on EFL port.
- platform/efl/test_expectations.txt:
- 8:47 AM Changeset in webkit [119236] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Bridge Apps - Apps do not redraw correctly after orientation change
https://bugs.webkit.org/show_bug.cgi?id=88033
Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>
PR: 142961
When bridge apps were in carousel mode, the backing store was inactive
as its memory had been released. When we rotated the device, we would
call WebPagPrivate:setViewportSize and resume screen and backing store
to render and blit visible contents. As backing store was inactive and
the window usage was GLES2Usage, we were neither doing backing store
rendering nor direct rendering. Therefore, we drew layers directly
based on the invalid texture contents when blitting contents if
accelerated compositing was enabled.
This patch forces compositing mode to let the accelerated compositing
layer take care of the rendering which can update texture contents
before drawing when backing store is inactive and is openGL compositing.
Reviewed internally by George Staikos and Arvid Nilsson.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenAndBackingStoreUpdates):
- 8:45 AM Changeset in webkit [119235] by
-
- 2 edits in trunk/Source/WebCore
Don't set scroll position twice in HistoryController::restoreScrollPositionAndViewState
https://bugs.webkit.org/show_bug.cgi?id=88068
Patch by John Mellor <johnme@chromium.org> on 2012-06-01
Reviewed by Adam Barth.
In the case where pageScaleFactor changes, we were calling
setScrollPosition with an incorrect scroll position (i.e. a scroll
position scaled by the pageScaleFactor we hadn't yet applied), then
fixing it by setting the pageScaleFactor and scroll position together,
overwriting the old scroll position. It's cleaner to just set the
pageScaleFactor and scroll position together.
No new tests as this isn't expected to change the ultimate behavior, just clean up how it happens.
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState):
- 8:43 AM Changeset in webkit [119234] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Remove QtViewportInteractionEngine::pageItemSizeChanged.
https://bugs.webkit.org/show_bug.cgi?id=88082
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.
The function was causing flickering, and after testing it was verified
that it was no longer needed either.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- 8:38 AM Changeset in webkit [119233] by
-
- 4 edits in trunk
Unreviewed, rolling out r119228.
http://trac.webkit.org/changeset/119228
https://bugs.webkit.org/show_bug.cgi?id=88098
Caused the EFL debug bot to crash. (Requested by rakuco on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01
Source/WebKit/efl:
- ewk/ewk_main.cpp:
(ewk_init):
LayoutTests:
- platform/efl/test_expectations.txt:
- 8:34 AM Changeset in webkit [119232] by
-
- 7 edits in trunk/Source
[Qt] Remove deprecated to/fromAscii()
https://bugs.webkit.org/show_bug.cgi?id=88086
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-01
Reviewed by Simon Hausmann.
Replacing to/fromAscii with to/fromLatin1 since it
is deprecated on Qt5.
Source/WebCore:
- bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
Source/WebKit/qt:
- WebCoreSupport/InspectorClientQt.cpp:
(WebCore):
- WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
- tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::settings):
- 8:21 AM Changeset in webkit [119231] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Contents not rendered in MiniBrowser for some pages
https://bugs.webkit.org/show_bug.cgi?id=87922
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.
Set drawing area visible contents rect if new visible contents rect is different from
the previous one.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::informVisibleContentChange):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- 7:36 AM Changeset in webkit [119230] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/Skipped:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt: Added.
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt: Added.
- 7:27 AM Changeset in webkit [119229] by
-
- 4 edits in trunk/LayoutTests
Web Inspector: Prepare styles-new-API.html results format for a more complex CSS model
https://bugs.webkit.org/show_bug.cgi?id=88090
Reviewed by Antti Koivisto.
- inspector/styles/resources/styles-new-API.css:
- inspector/styles/styles-new-API-expected.txt:
- inspector/styles/styles-new-API.html:
- 7:23 AM Changeset in webkit [119228] by
-
- 4 edits in trunk
[EFL] [DRT] editing/execCommand/paste-and-match-style-event.html crashes
https://bugs.webkit.org/show_bug.cgi?id=86961
Patch by Christophe Dumez <Christophe Dumez> on 2012-06-01
Reviewed by Csaba Osztrogonác.
Source/WebKit/efl:
Call ecore_x_init() in ewk_init() to initialize the ecore_x library.
This avoids crashing upong calling WebCore::systemBeep() which uses
ecore_x_bell() internally.
- ewk/ewk_main.cpp:
(ewk_init):
LayoutTests:
Unskip editing/execCommand/paste-and-match-style-event.html now that
it is no longer crashing thanks to ecore_x library init.
- platform/efl/test_expectations.txt:
- 7:14 AM Changeset in webkit [119227] by
-
- 4 edits2 adds in trunk
Layout not updated after setting -webkit-line-clamp to none
https://bugs.webkit.org/show_bug.cgi?id=88049
Reviewed by Abhishek Arya.
Source/WebCore:
Test: fast/flexbox/line-clamp-removed-dynamically.html
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::styleWillChange): Added. Calls clearLineClamp if
line-clamp will change to none.
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): Added. Marks possibly-clamped
children for layout and clears truncation from blocks.
- rendering/RenderDeprecatedFlexibleBox.h:
LayoutTests:
- fast/flexbox/line-clamp-removed-dynamically-expected.html: Added.
- fast/flexbox/line-clamp-removed-dynamically.html: Added.
- 6:53 AM Changeset in webkit [119226] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r119213.
http://trac.webkit.org/changeset/119213
https://bugs.webkit.org/show_bug.cgi?id=88084
This patch broke two tests on all platform except Chromium.
The authors are unavailable. (Requested by zherczeg on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 6:51 AM Changeset in webkit [119225] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r119219.
http://trac.webkit.org/changeset/119219
https://bugs.webkit.org/show_bug.cgi?id=88088
This patch broke two tests on GTK/Qt. The authors are
unavailable. (Requested by kkristof on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-01
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):
- page/Frame.cpp:
(WebCore::Frame::willDetachPage):
- page/Frame.h:
(Frame):
(WebCore::Frame::detachFromPage):
(WebCore):
- page/Page.cpp:
(WebCore::Page::~Page):
- 6:47 AM Changeset in webkit [119224] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add Closure compiler annotations to WorkerConsole
https://bugs.webkit.org/show_bug.cgi?id=88073
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-01
Reviewed by Yury Semikhatsky.
- inspector/front-end/HeapSnapshotWorker.js:
(WebInspector.WorkerConsole.prototype.log):
(WebInspector.WorkerConsole.prototype.error):
(WebInspector.WorkerConsole.prototype.info):
- 5:57 AM Changeset in webkit [119223] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] New signals in ewk_view to enable global history delegate functionality
https://bugs.webkit.org/show_bug.cgi?id=86343
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.
Global history delegate is an interface for WebKit clients to manage their own global history store.
The new ewk_view signals do the following:
1) report that a navigation happened within the view and give the navigation details.
2) report that view performed a client redirect and give source and destination uris.
3) report that view performed a server redirect and give source and destination uris.
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks): implementation added.
(WebCore::FrameLoaderClientEfl::updateGlobalHistory): implementation added.
- ewk/ewk_view.h: Added new signals and data types.
- 5:52 AM Changeset in webkit [119222] by
-
- 2 edits in trunk/Source/WTF
[Qt] Save one copy when going from 8-bit WTF::String to QString
Asking for characters() of an 8-bit string will make a 16-bit copy internally
in WTF::String. Since we're going to copy the data to QStringData anyways, which
is 16-bit, we can do the conversion ourselves and save one copy.
Reviewed by Simon Hausmann.
- 5:50 AM Changeset in webkit [119221] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing and crashing tests.
- platform/qt-5.0-wk2/Skipped:
- platform/qt/Skipped:
- 5:32 AM Changeset in webkit [119220] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Move suspension to QtViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=88078
Reviewed by Simon Hausmann.
Next step is to take care of visibility changes.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::suspendPageContent):
(WebKit):
(WebKit::QtViewportInteractionEngine::resumePageContent):
- UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
- 5:30 AM Changeset in webkit [119219] by
-
- 5 edits in trunk/Source/WebCore
Frame::willDetachPage() shouldn't be called more than once.
https://bugs.webkit.org/show_bug.cgi?id=88056
Reviewed by Ryosuke Niwa.
This change moved willDetachPage() to private and calls it from
detachFromParent(). Also, it checks m_page and call
willDetachPage() only once, if m_page is available.
No new tests. Covered by existing suites.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeAndRemoveChild):
(WebCore::FrameLoader::detachFromParent):
- page/Frame.cpp:
(WebCore::Frame::detachFromPage):
(WebCore):
(WebCore::Frame::willDetachPage):
- page/Frame.h:
(Frame):
- page/Page.cpp:
(WebCore::Page::~Page):
- 5:26 AM Changeset in webkit [119218] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][W2] Qml Error in ViewportInfoItem.qml in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=87999
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-01
Reviewed by Kenneth Rohde Christiansen.
Return default viewport attributes rather than invalid QVariant.
- UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):
- 5:25 AM Changeset in webkit [119217] by
-
- 4 edits in trunk/Source/WTF
[Qt] Make conversion from QString to WTF::String (and back again) ~free
https://bugs.webkit.org/show_bug.cgi?id=87847
Instead of copying the QString data when converting to a WTF::String we
make the WTF::String adopt the QString data by introducing a new buffer
ownership type, and pointing the internal WTF::StringImpl 16-bit data
member to the string data managed by QStringData.
We make sure to reference the QStringData when adopting, so that the
data will stay alive, and then dereference it when the WTF::StringImpl
is deleted, which will free the QStringData (either straight away, if
we're the only one holding a reference still, or later, when the ref
count goes to 0).
In the case of going back from a WTF::String to a QString we can cheat
a bit (avoid a copy), if we know that the WTF::String was adopted from
a QString, since it's then just a matter of having the QString adopt
the existing QStringData (just like a regular QString copy).
If the WTF::String buffer is not owned by QStringData, eg a regular
8-bit or 16-bit string/substring, we have to fall back to copying,
as before (though there are potential optimization tricks we can
apply here later on).
Reviewed by Gavin Barraclough.
- wtf/qt/StringQt.cpp:
- wtf/text/StringImpl.cpp:
- wtf/text/StringImpl.h:
- 5:21 AM Changeset in webkit [119216] by
-
- 4 edits in trunk
[Qt] Support drawing a pattern with a translation.
https://bugs.webkit.org/show_bug.cgi?id=87025
Source/WebCore:
Drawing an SVG pattern that has its x or y attribute set
works by setting a transform on the Pattern.
We would ignore this by only taking into account the texture and
target rect.
Reviewed by Kenneth Rohde Christiansen.
test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::drawRepeatPattern): refactored to take into account the translation set on the brush.
(WebCore::GraphicsContext::fillRect):
LayoutTests:
Reviewed by Kenneth Rohde Christiansen.
- platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: fix the expected pixel result
- 4:56 AM Changeset in webkit [119215] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening failure case on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=88067
Unreviewed EFL gardening after r119196.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
- platform/efl/test_expectations.txt:
- 4:55 AM Changeset in webkit [119214] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 4:53 AM Changeset in webkit [119213] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
https://bugs.webkit.org/show_bug.cgi?id=88059
Reviewed by Kent Tamura.
This patch changes to share RenderStyle object among the "option"
elements to improve rendering performance and reducing memory usage
of RenderStyle.
No new tests. This patch doesn't change behavior but rendering performance.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Check attribute value
mismatching for "option" element.
- 4:26 AM Changeset in webkit [119212] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION] Bad layout of "Override device metrics" controls in the Settings dialog
https://bugs.webkit.org/show_bug.cgi?id=88074
Reviewed by Yury Semikhatsky.
The "Override device metrics" controls are placed in a table, which gets too narrow. Give it a
"white-space: nowrap" to avoid wrapping individual cells.
- inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
- inspector/front-end/elementsPanel.css:
- inspector/front-end/inspector.css:
(.nowrap):
- 4:18 AM Changeset in webkit [119211] by
-
- 2 edits in trunk/Tools
[Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
Reviewed by Simon Hausmann.
- 4:12 AM Changeset in webkit [119210] by
-
- 6 edits in trunk/Source/WebKit2
[Qt] Clean up our viewport handling mess
https://bugs.webkit.org/show_bug.cgi?id=87977
Reviewed by Simon Hausmann.
Consolidated functionality from QQuickWebViewPrivate* into
ViewportInteractionEngine that belongs there, in preparation for
renaming ViewportInteractionEngine in the future.
Remove unneeded methods and move others to private.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_resume):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
- UIProcess/API/qt/qquickwebview_p.h:
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):
(WebKit::QtViewportInteractionEngine::pageItemPositionChanged):
(WebKit::QtViewportInteractionEngine::pageContentPositionRequested):
(WebKit::QtViewportInteractionEngine::visibleContentsRect):
(WebKit):
(WebKit::QtViewportInteractionEngine::informVisibleContentChange):
(WebKit::QtViewportInteractionEngine::viewportItemSizeChanged):
- UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit):
(QtViewportInteractionEngine):
- 3:50 AM Changeset in webkit [119209] by
-
- 2 edits in trunk/LayoutTests
[EFL] Move input element's spinner style tests to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=88054
Unreviewed EFL gardening.
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-06-01
- platform/efl/test_expectations.txt:
- 3:45 AM Changeset in webkit [119208] by
-
- 8 edits2 adds1 delete in trunk/Source
[EFL] Implement PlatformStrategies
https://bugs.webkit.org/show_bug.cgi?id=86946
Source/WebCore:
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.
- PlatformEfl.cmake: Add PlatformStrategies.cpp file to the build system.
Also, remove PluginDataEfl.cpp because the same functionality is now
implemented in PlatformStrategiesEfl.cpp.
Source/WebKit:
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.
- PlatformEfl.cmake: Add PlatformStrategiesEfl file to the build
system.
Source/WebKit/efl:
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.
Enable PLATFORM_STRATEGIES for EFL platform.
- WebCoreSupport/PlatformStrategiesEfl.cpp: Added, code was moved
from platform/PluginDataEfl.
(PlatformStrategiesEfl::initialize): Initialize platform strategies.
(PlatformStrategiesEfl::PlatformStrategiesEfl):
(PlatformStrategiesEfl::createCookiesStrategy): Return this.
(PlatformStrategiesEfl::createPluginStrategy): Ditto.
(PlatformStrategiesEfl::createVisitedLinkStrategy): Ditto.
(PlatformStrategiesEfl::createPasteboardStrategy): Return 0, since
PasteboardStrategy is only used by mac code for now.
(PlatformStrategiesEfl::notifyCookiesChanged):
(PlatformStrategiesEfl::refreshPlugins): Refresh the plugin
database. Code executes only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::getPluginInfo): Initialize plugins and
populate the given vector with plugins information. Code executes
only when NETSCAPE_PLUGIN_API is ON.
(PlatformStrategiesEfl::isLinkVisited): Return whether the given
hash is a visited link of the page group.
(PlatformStrategiesEfl::addVisitedLink): Add the given hash to the
page group visited links.
- WebCoreSupport/PlatformStrategiesEfl.h: Added.
(PlatformStrategiesEfl):
- ewk/ewk_main.cpp: Initialize PlatformStrategiesEfl.
(_ewk_init_body):
Source/WTF:
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-01
Reviewed by Carlos Garcia Campos.
- wtf/Platform.h: Enable PLATFORM_STRATEGIES for EFL platform.
- 3:39 AM Changeset in webkit [119207] by
-
- 2 edits in trunk/Source/WebCore
ASSERT(m_fontSelector->document()) is bogus and should be removed
https://bugs.webkit.org/show_bug.cgi?id=88053
Reviewed by Abhishek Arya.
This ASSERT was introduced in http://trac.webkit.org/changeset/97402
together with a branch that handled the case of the ASSERT firing.
This ASSERT fires when running tests on Android (which runs with
ASSERTs enabled). The ASSERT appears to be bogus, so this patch removes
it.
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):
- 3:37 AM Changeset in webkit [119206] by
-
- 15 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, update expected files.
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png:
- platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/qt-5.0/fast/forms/form-element-geometry-expected.png:
- platform/qt-5.0/fast/forms/form-element-geometry-expected.txt:
- platform/qt-5.0/fast/forms/menulist-separator-painting-expected.png:
- platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt:
- platform/qt-5.0/fast/forms/select-baseline-expected.png:
- platform/qt-5.0/fast/forms/select-baseline-expected.txt:
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.png:
- platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt:
- platform/qt-5.0/fast/replaced/three-selects-break-expected.png:
- platform/qt-5.0/fast/replaced/three-selects-break-expected.txt:
- 2:40 AM Changeset in webkit [119205] by
-
- 4 edits in trunk/Source
[Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order
https://bugs.webkit.org/show_bug.cgi?id=88044
Reviewed by Kent Tamura.
Source/WebCore:
This patch fixed wrong argument of makeUInt128 in UInt128::operator/= to get right
result for decimal multiplication.
Test: WebKit/chromium/tests/DecimalTest.cpp: Add new a new test case.
- platform/Decimal.cpp:
(WebCore::DecimalPrivate::UInt128::operator/=):
Source/WebKit/chromium:
- tests/DecimalTest.cpp:
(TEST_F): Add a new test for multiplication.
- 2:26 AM Changeset in webkit [119204] by
-
- 7 edits9 adds in trunk
sandbox directive in X-WebKit-CSP header unable to create a unique origin
https://bugs.webkit.org/show_bug.cgi?id=88014
Reviewed by Ryosuke Niwa.
Source/WebCore:
We process the HTTP headers for a response after we create a document
object for the response. Previously, the SecurityOrigin of a document
was determined when the document was created, which meant that the
sandbox directive in CSP couldn't create a unique origin.
In this patch, we transition to a unique origin when we start enforcing
the SandboxOrigin bit. This patch is more complicated than you might
expect because we redundantly store the SecurityOrigin object in
DOMWindow. Removing that redundant state is
https://bugs.webkit.org/show_bug.cgi?id=75793.
The CSP sandbox directive is defined in
http://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-1.0-specification.html
by reference to
http://www.whatwg.org/specs/web-apps/current-work/#forced-sandboxing-flag-set.
The relation between sandbox and unique origin arises from
http://www.whatwg.org/specs/web-apps/current-work/#origin-0.
Test: http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html
http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html
http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html
- dom/Document.cpp:
(WebCore::Document::didUpdateSecurityOrigin):
(WebCore::Document::initContentSecurityPolicy):
- dom/Document.h:
(Document):
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::enforceSandboxFlags):
(WebCore):
(WebCore::SecurityContext::didUpdateSecurityOrigin):
- dom/SecurityContext.h:
(SecurityContext):
LayoutTests:
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control.html: Added.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header.html: Added.
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control.html: Added.
- http/tests/security/contentSecurityPolicy/resources/sandbox.php: Added.
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header.html: Added.
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-control-expected.txt: Added.
- 2:03 AM Changeset in webkit [119203] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: expose MemoryCache statistics in the inspector protocol
https://bugs.webkit.org/show_bug.cgi?id=87984
Reviewed by Pavel Feldman.
Added MemoryCache statistics to Memory.getProcessMemoryDistribution command
result. Corresponding sector is added to the memory pie-chart.
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::addMemoryBlockFor):
(WebCore::memoryCacheInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- 1:54 AM Changeset in webkit [119202] by
-
- 2 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening, add missing text and image baselines for
fast/images/png-suite/test.html. Add MISSING expectations for two
placeholder-in-text-area tests - the placeholder text does not appear
in text areas (known bug).
- platform/gtk/fast/images/png-suite: Added.
- platform/gtk/fast/images/png-suite/test-expected.png: Added.
- platform/gtk/fast/images/png-suite/test-expected.txt: Added.
- platform/gtk/test_expectations.txt:
- 1:34 AM Changeset in webkit [119201] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add RenderArena sizes to the memory pie-chart
https://bugs.webkit.org/show_bug.cgi?id=87971
Reviewed by Pavel Feldman.
Added allocated and used sizes of page render arenas to the memory
report returned by the InspectorMemoryAgent. Total allocated size of
the inspected page's render arenas will be displayed on the memory
pie-chart.
- inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
(WebCore::renderTreeInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- 1:32 AM Changeset in webkit [119200] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening after r119196.
- platform/gtk/fast/dom/gc-attribute-node-expected.txt: Added.
- platform/gtk/test_expectations.txt: Also mark fast/replaced/border-radius-clip.html as flaky.
- 1:29 AM Changeset in webkit [119199] by
-
- 3 edits2 copies in branches/chromium/1132
Merge 118721 - Form controls in <fieldset disabled> should not be validated.
https://bugs.webkit.org/show_bug.cgi?id=87381
Reviewed by Hajime Morita.
Source/WebCore:
We need to use disabeld() instead of m_disabled to calculate
willValidate property. Also, we need to update willValidate if
necessary.
Test: fast/forms/fieldset/validation-in-fieldset.html
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::disabledAttributeChanged):
- Do not traverse this.
- Calls ancestorDisabledStateWasChanged() instead of setNeedsStyleRecalc() because we'd like to do additional tasks.
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::ancestorDisabledStateWasChanged):
Added. Just calls disabledAttributeChanged().
(WebCore::HTMLFormControlElement::parseAttribute):
Do not call setNeedsWillValidateCheck() whenever an attribute is updated.
It should be called only if disabled or readonly attribute is updated.
(WebCore::HTMLFormControlElement::disabledAttributeChanged):
Add setNeedsWillValidateCheck(). It was moved from parseAttribute().
(WebCore::HTMLFormControlElement::insertedInto):
Invalidate ancestor information.
(WebCore::HTMLFormControlElement::recalcWillValidate):
Use disabled() instead of m_disabled. disabled() takes care of
ancestor's disabled state.
- html/HTMLFormControlElement.h:
(HTMLFormControlElement):
LayoutTests:
- fast/forms/fieldset/validation-in-fieldset-expected.txt: Added.
- fast/forms/fieldset/validation-in-fieldset.html: Added.
TBR=tkent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451107
- 1:23 AM Changeset in webkit [119198] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: change type of injected script id from long to int
https://bugs.webkit.org/show_bug.cgi?id=87837
Reviewed by Pavel Feldman.
Changed injected script id type from long to int so that we don't
lose precision when sending the id over the protocol.
- bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
(WebCore::InjectedScriptManager::injectedScriptFor):
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptForId):
(WebCore::InjectedScriptManager::injectedScriptIdFor):
(WebCore::InjectedScriptManager::injectScript):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
- 1:17 AM Changeset in webkit [119197] by
-
- 6 edits1 add in trunk/Source/WebCore
Web Inspector: draw pie-chart based on memory data received from backend
https://bugs.webkit.org/show_bug.cgi?id=87737
Reviewed by Pavel Feldman.
Added pie chart for memory data received from inspector memory agent.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeMemoryProfileType):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryProfileHeader):
(WebInspector.MemoryBlockViewProperties):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):
(WebInspector.NativeMemoryPieChart):
(WebInspector.NativeMemoryPieChart.prototype.onResize):
(WebInspector.NativeMemoryPieChart.prototype._updateSize):
(WebInspector.NativeMemoryPieChart.prototype._addBlockLabels):
(WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
(WebInspector.NativeMemoryPieChart.prototype._paint):
(WebInspector.NativeMemoryPieChart.prototype._clear):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/nativeMemoryProfiler.css: Added.
(.memory-pie-chart-container):
(.memory-pie-chart):
(.memory-blocks-list .swatch):
(.memory-blocks-list):
(.memory-blocks-list .item):
May 31, 2012:
- 11:37 PM Changeset in webkit [119196] by
-
- 3 edits4 adds in trunk
[V8] Expando properties on attribute nodes disappear
https://bugs.webkit.org/show_bug.cgi?id=87925
Source/WebCore:
Reviewed by Adam Barth.
Test: fast/dom/gc-attribute-node.html
- bindings/v8/V8GCController.cpp:
(WebCore::calculateGroupId): Group attributes like other nodes.
LayoutTests:
Checks in a failing result for JSC; see
<https://bugs.webkit.org/show_bug.cgi?id=88045>.
Reviewed by Adam Barth.
- fast/dom/gc-attribute-node-expected.txt: Added.
- fast/dom/gc-attribute-node.html: Added.
- platform/chromium/fast/dom/gc-attribute-node-expected.txt: Added.
- platform/mac/fast/dom/gc-attribute-node-expected.txt: Added.
- 11:33 PM Changeset in webkit [119195] by
-
- 7 edits9 adds in trunk
[EFL] <input type="number"> is not a spinbutton
https://bugs.webkit.org/show_bug.cgi?id=86846
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Implemented adjustInnerSpinButtonStyle and
paintInnerSpinButton in RenderThemeEfl.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::edjeGroupFromFormType):
(WebCore::RenderThemeEfl::adjustInnerSpinButtonStyle):
(WebCore):
(WebCore::RenderThemeEfl::paintInnerSpinButton):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
Source/WebKit/efl:
Implemented spinner widget.
- DefaultTheme/default.edc:
- DefaultTheme/widget/spinner/sp_bg.png: Added.
- DefaultTheme/widget/spinner/sp_down_default.png: Added.
- DefaultTheme/widget/spinner/sp_down_hover.png: Added.
- DefaultTheme/widget/spinner/sp_down_pressed.png: Added.
- DefaultTheme/widget/spinner/sp_up_default.png: Added.
- DefaultTheme/widget/spinner/sp_up_hover.png: Added.
- DefaultTheme/widget/spinner/sp_up_pressed.png: Added.
- DefaultTheme/widget/spinner/spinner.edc: Added.
LayoutTests:
Unskip spinbutton layout tests.
- platform/efl/test_expectations.txt:
- 10:05 PM Changeset in webkit [119194] by
-
- 2 edits in trunk/LayoutTests
Update Chromium test expectation of media/video-poster-blocked-by-willsendrequest.html to PASS TEXT
on all platforms as supposed to just Mac and Linux since the result of jquery/traversing.html is
bleeding into this test on Windows as well.
- platform/chromium/test_expectations.txt:
- 9:24 PM Changeset in webkit [119193] by
-
- 5 edits in trunk/LayoutTests
Unreviewed. Fix expectations for for fast/multicol/span/clone-flexbox.html,
the result I checked in was off by 1px.
- fast/multicol/span/clone-flexbox-expected.txt:
- platform/efl/fast/multicol/span/clone-flexbox-expected.txt:
- platform/gtk/fast/multicol/span/clone-flexbox-expected.txt:
- platform/qt/fast/multicol/span/clone-flexbox-expected.txt:
- 9:00 PM Changeset in webkit [119192] by
-
- 35 edits in trunk
REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
https://bugs.webkit.org/show_bug.cgi?id=86859
Source/WebCore:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
The test tries to reach an invalid SpellChecker object. Such an access should be guarded
beforehand.
Asynchronous spellchecking can return results after originated
frame is gone, which triggered an invalid access to the dead spellchecker
object. This chagne prevents it by marking request objects from
the spellchecker as invalid:
- Originally TextCheckerClient API was passed a SpellCheker object. This change abstracted it behind TextCheckingRequest interface, didSucceed() and didCancel() method specifically.
- TextCheckingRequest was turned from a plain old object into a refcounted abstract class, which is now subclassed by SpellCheckRequest.
- SpellChecker now marks pending SpellCheckRequest objects as invalid on its destructor.
Test: editing/spelling/spellcheck-async-remove-frame.html
- WebCore.exp.in:
- editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::SpellCheckRequest):
(WebCore::SpellCheckRequest::create):
(WebCore::SpellCheckRequest::didSucceed):
(WebCore):
(WebCore::SpellCheckRequest::didCancel):
(WebCore::SpellCheckRequest::wasRequestedBy):
(WebCore::SpellCheckRequest::requesterDestroyed):
(WebCore::SpellChecker::~SpellChecker):
(WebCore::SpellChecker::requestCheckingFor):
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::didCheckSucceed):
(WebCore::SpellChecker::didCheckCancel):
- editing/SpellChecker.h:
(WebCore):
(SpellCheckRequest):
(WebCore::SpellCheckRequest::isStarted):
(SpellChecker):
- loader/EmptyClients.h:
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
- platform/text/TextCheckerClient.h:
(TextCheckerClient):
- platform/text/TextChecking.h:
(GrammarDetail):
(TextCheckingResult):
(TextCheckingRequest):
(WebCore::TextCheckingRequest::~TextCheckingRequest):
Source/WebKit/blackberry:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
- WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
Source/WebKit/chromium:
Removed a port specific fix which was introduced at r117572.
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::frameWillDetachPage):
(WebKit::EditorClientImpl::requestCheckingOfString):
- src/EditorClientImpl.h:
(WebCore):
(EditorClientImpl):
- src/WebTextCheckingCompletionImpl.cpp:
(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
- src/WebTextCheckingCompletionImpl.h:
(WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
(WebTextCheckingCompletionImpl):
Source/WebKit/efl:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::requestCheckingOfString):
Source/WebKit/gtk:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/TextCheckerClientGtk.h:
(WebKit::TextCheckerClientGtk::requestCheckingOfString):
Source/WebKit/mac:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(-[WebEditorSpellCheckResponder initWithClient:sequence:results:]):
(-[WebEditorSpellCheckResponder perform]):
(WebEditorClient::didCheckSucceeded):
(WebEditorClient::requestCheckingOfString):
Source/WebKit/qt:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/TextCheckerClientQt.h:
(WebCore::TextCheckerClientQt::requestCheckingOfString):
Source/WebKit/win:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
Source/WebKit/wince:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebCoreSupport/EditorClientWinCE.h:
(WebKit::EditorClientWinCE::requestCheckingOfString):
Source/WebKit/wx:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebKitSupport/EditorClientWx.h:
(WebCore::EditorClientWx::requestCheckingOfString):
Source/WebKit2:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::requestCheckingOfString):
- WebProcess/WebCoreSupport/WebEditorClient.h:
LayoutTests:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-05-31
Reviewed by Ryosuke Niwa.
- platform/mac/Skipped: Unskipped the test.
- 8:35 PM WikiStart edited by
- Add a link to ChromiumWebKitAPI (diff)
- 8:32 PM Changeset in webkit [119191] by
-
- 57 edits in trunk
initial flex value should be 1 1 auto
https://bugs.webkit.org/show_bug.cgi?id=86526
Source/WebCore:
Reviewed by Ojan Vafai.
Also, if -webkit-flex is used to set the positive flex to 0 and
the negative flex is omitted, the negative flex is set to 0.
New test cases in: flex-property-parsing.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFlex::applyValue):
- rendering/style/RenderStyle.h:
LayoutTests:
In most tests, I added a CSS rule to default -webkit-flex: none.
In a few tests, -webkit-flex didn't include the negative flex value
and it was becoming 1, causing negative flexing. I fixed those by
explicitly stating the negative flex as 0.
Reviewed by Ojan Vafai.
- css3/flexbox/align-absolute-child.html:
- css3/flexbox/auto-margins.html:
- css3/flexbox/flex-algorithm-with-margins.html:
- css3/flexbox/flex-algorithm.html:
- css3/flexbox/flex-align-end.html:
- css3/flexbox/flex-flow-auto-margins.html:
- css3/flexbox/flex-flow-orientations.html:
- css3/flexbox/flex-flow-overflow.html:
- css3/flexbox/flex-pack.html:
- css3/flexbox/flex-property-parsing-expected.txt:
- css3/flexbox/flex-property-parsing.html:
- css3/flexbox/flexbox-overflow-auto-expected.html:
- css3/flexbox/flexbox-overflow-auto.html:
- css3/flexbox/multiline-column-auto.html:
- css3/flexbox/multiline-pack.html:
- css3/flexbox/multiline-shrink-to-fit.html:
- css3/flexbox/multiline.html:
- css3/flexbox/nested-stretch.html:
- css3/flexbox/orthogonal-flex-directions.html:
- css3/flexbox/position-absolute-child.html:
- css3/flexbox/preferred-widths-orthogonal.html:
- css3/flexbox/true-centering.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/qt/svg/css/getComputedStyle-basic-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 8:29 PM Changeset in webkit [119190] by
-
- 1 edit4 adds in trunk/LayoutTests
[Win] 4 fast/frames tests failing
https://bugs.webkit.org/show_bug.cgi?id=88034
Add Windows-specific expected (failing?) results to get the bots green.
- platform/win/fast/frames/frame-set-scaling-hit-expected.txt: Added.
- platform/win/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Added.
- platform/win/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt: Added.
- platform/win/fast/frames/frames-with-frameborder-zero-can-be-resized-expected.txt: Added.
- 8:21 PM Changeset in webkit [119189] by
-
- 3 edits in trunk/Source/WebKit2
[WebKit2] Remove nested #if conditions from messages.in files
https://bugs.webkit.org/show_bug.cgi?id=88039
Reviewed by Filip Pizlo.
The code generator that processes messages.in files can't handle nested
#if conditions. Sadly I added said conditions in r117700 but failed to
verify the generated result. Un-nest the conditions I added.
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.messages.in:
- 8:19 PM Changeset in webkit [119188] by
-
- 8 edits3 adds in trunk
Add public page loading performance tests using web-page-replay
https://bugs.webkit.org/show_bug.cgi?id=84008
Reviewed by Dirk Pranke.
PerformanceTests:
Add replay tests for google.com and youtube.com as examples.
- Replay: Added.
- Replay/www.google.com.replay: Added.
- Replay/www.youtube.com.replay: Added.
Tools:
Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
- Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.is_external_http_test): Added.
- Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.init): Takes port.
(PerfTest.prepare): Added. Overridden by ReplayPerfTest.
(PerfTest):
(PerfTest.run): Calls run_single.
(PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
(ChromiumStylePerfTest.init):
(PageLoadingPerfTest.init):
(PageLoadingPerfTest.run):
(ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
(ReplayServer.init):
(ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
but it caused a dead lock on some web pages.
(ReplayServer.stop):
(ReplayServer.del):
(ReplayPerfTest):
(ReplayPerfTest.init):
(ReplayPerfTest._start_replay_server):
(ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
The subsequent runs of the same test will just use test.wpr.
(ReplayPerfTest.run_single):
(PerfTestFactory):
(PerfTestFactory.create_perf_test):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
(TestPageLoadingPerfTest.test_run_with_bad_output):
(TestReplayPerfTest):
(TestReplayPerfTest.ReplayTestPort):
(TestReplayPerfTest.ReplayTestPort.init):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver):
(TestReplayPerfTest.ReplayTestPort.init.ReplayTestDriver.run_test):
(TestReplayPerfTest.ReplayTestPort._driver_class):
(TestReplayPerfTest.MockReplayServer):
(TestReplayPerfTest.MockReplayServer.init):
(TestReplayPerfTest.MockReplayServer.stop):
(TestReplayPerfTest._add_file):
(TestReplayPerfTest._setup_test):
(TestReplayPerfTest.test_run_single):
(TestReplayPerfTest.test_run_single.run_test):
(TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
(TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error):
(TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
(TestReplayPerfTest.test_prepare):
(TestReplayPerfTest.test_prepare.run_test):
(TestReplayPerfTest.test_prepare_calls_run_single):
(TestReplayPerfTest.test_prepare_calls_run_single.run_single):
(TestPerfTestFactory.test_regular_test):
(TestPerfTestFactory.test_inspector_test):
(TestPerfTestFactory.test_page_loading_test):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner):
(PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
(PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
(PerfTestsRunner._collect_tests._is_test_file):
(PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(create_runner):
(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_run_with_upload_json):
(test_upload_json):
(test_upload_json.MockFileUploader.upload_single_text_file):
(_add_file):
(test_collect_tests):
(test_collect_tests_with_multile_files):
(test_collect_tests_with_multile_files.add_file):
(test_collect_tests_with_skipped_list):
(test_collect_tests_with_page_load_svg):
(test_collect_tests_should_ignore_replay_tests_by_default):
(test_collect_tests_with_replay_tests):
(test_parse_args):
- Scripts/webkitpy/thirdparty/init.py: Added the dependency for web-page-replay version 1.1.1.
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_webpagereplay):
- 7:16 PM Changeset in webkit [119187] by
-
- 22 edits in trunk/Source
Unreviewed, rolling out r119146.
http://trac.webkit.org/changeset/119146
https://bugs.webkit.org/show_bug.cgi?id=88035
android breakage fixed in http://crrev.com/139945 (Requested
by fischman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::didLoadingProgress):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
- platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):
Source/WebKit/chromium:
- public/WebMediaPlayer.h:
(WebMediaPlayer):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 7:01 PM Changeset in webkit [119186] by
-
- 5 edits5 copies in branches/chromium/1132
Merge 118772 - REGRESSION(r109729): The optgroup element's "disabled" attribute has no effect to rendering and selection
https://bugs.webkit.org/show_bug.cgi?id=87614
Reviewed by Kent Tamura.
Source/WebCore:
This patch adds HTMLOptGroupElement::disabled and isEnabledFormControl
methods which was implemented in HTMLFormControlElement at r109729 and
updates CSS pseudo class checker to check "optgroup" element.
Tests: fast/forms/select/optgroup-clicking.html
fast/forms/select/optgroup-disabled.html
fast/forms/select/optgroup-rendering.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): On disabled and enabled pseudo class checker.
We checked tag name "optgroup" in addition isFormControlElement.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Checks optgroup.disabled.
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::disabled): Added.
- html/HTMLOptGroupElement.h:
(HTMLOptGroupElement): Added isEnabledFormControl.
LayoutTests:
Note: An image for optgroup-rendering.html will be change due by
BUG-87719. Color of option elements should be blue (:enabled
pseudo class) instead of green.
- fast/forms/select/optgroup-clicking-expected.txt: Added.
- fast/forms/select/optgroup-clicking.html: Added.
- fast/forms/select/optgroup-disabled-expected.txt: Added.
- fast/forms/select/optgroup-disabled.html: Added.
- fast/forms/select/optgroup-rendering.html: Added.
- platform/chromium/test_expectations.txt: Add MISSING entry for optgroup-rendering.html.
- platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png: Added.
- platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt: Added.
TBR=yosin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10453112
- 6:37 PM Changeset in webkit [119185] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebGL and 2D canvas output not available to WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=88012
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by George Staikos.
Properly set up resource sharing between WebKit thread EGL contexts and
the compositing thread EGL context, so the texture ID produced by WebGL
and 2D canvas makes sense to the compositing context.
There's no public API to supply an EGLContext yet, so we're lucky that
the embedder never makes its context un-current. Just grab the current
context on the compositing thread and use that as the compositing
context.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor):
- Api/WebPage_p.h:
(WebPagePrivate):
- 6:31 PM Changeset in webkit [119184] by
-
- 3 edits2 adds in trunk
XSSAuditor bypass with leading /*/*/ comment
https://bugs.webkit.org/show_bug.cgi?id=88002
Reviewed by Adam Barth.
Source/WebCore:
Fixes issue in xssauditor's parsing of /*/.
Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
LayoutTests:
Fixes issue in xssauditor's parsing of /*/.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html: Added.
- 6:13 PM Changeset in webkit [119183] by
-
- 2 edits in trunk/Tools
Support building the Android port of chromium with Ninja
https://bugs.webkit.org/show_bug.cgi?id=87545
Patch by Yaron Friedman <yfriedman@chromium.org> on 2012-05-31
Reviewed by Adam Barth.
Ensures that shared libraries are looked up in a generator-agnostic
way and that output is placed in the correct directory.
Depends on http://codereview.chromium.org/10386188/
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 5:59 PM Changeset in webkit [119182] by
-
- 3 edits2 adds in trunk
Bug: Negative SVG rect rx,ry corner radii values aren't handled correctly
https://bugs.webkit.org/show_bug.cgi?id=87859
Patch by Hans Muller <hmuller@adobe.com> on 2012-05-31
Reviewed by Dirk Schulze.
Source/WebCore:
Added the rect element corner radius constraints specified in steps 2-4 of
http://www.w3.org/TR/SVG/shapes.html#RectElement to Path::addRoundedRect().
Support for steps 6 and 7 was already included. Steps 2-4:
2 - If neither rx nor ry are properly specified, then set both rx and ry to 0. (This will result in square corners.)
3 - Otherwise, if a properly specified value is provided for rx, but not for ry then set both rx and ry to the value of rx.
4 - Otherwise, if a properly specified value is provided for ry, but not for rx, then set both rx and ry to the value of ry.
Tests: svg/custom/rect-negative-corner-radii-expected.svg
svg/custom/rect-negative-corner-radii.svg
- platform/graphics/Path.cpp:
(WebCore::Path::addRoundedRect):
LayoutTests:
Added a reftest which verifies that negative rect corner radius values are handled per the SVG spec,
http://www.w3.org/TR/SVG/shapes.html#RectElement.
- svg/custom/rect-negative-corner-radii-expected.svg: Added.
- svg/custom/rect-negative-corner-radii.svg: Added.
- 5:56 PM Changeset in webkit [119181] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening. Skip fast/loader/opaque-base-url.html only on debug bots.
The test hits an assertion which obviously only crashes the debug
bots.
- platform/efl/test_expectations.txt:
- 5:55 PM Changeset in webkit [119180] by
-
- 68 edits32 adds in trunk/LayoutTests
[EFL] Unskip fast/multicol tests.
Most tests were passing and just needed new baselines. Only skip
the few failing ones.
- platform/efl/Skipped:
- platform/efl/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
- platform/efl/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
- platform/efl/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
- platform/efl/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
- platform/efl/fast/multicol/block-axis-vertical-lr-expected.png: Added.
- platform/efl/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
- platform/efl/fast/multicol/block-axis-vertical-rl-expected.png: Added.
- platform/efl/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
- platform/efl/fast/multicol/client-rects-expected.png: Added.
- platform/efl/fast/multicol/client-rects-expected.txt: Added.
- platform/efl/fast/multicol/column-count-with-rules-expected.png:
- platform/efl/fast/multicol/column-rules-expected.png:
- platform/efl/fast/multicol/column-rules-stacking-expected.png:
- platform/efl/fast/multicol/columns-shorthand-parsing-expected.png:
- platform/efl/fast/multicol/float-avoidance-expected.png:
- platform/efl/fast/multicol/float-multicol-expected.png:
- platform/efl/fast/multicol/float-paginate-complex-expected.png:
- platform/efl/fast/multicol/float-paginate-complex-expected.txt:
- platform/efl/fast/multicol/float-paginate-empty-lines-expected.png:
- platform/efl/fast/multicol/float-paginate-expected.png:
- platform/efl/fast/multicol/layers-in-multicol-expected.png:
- platform/efl/fast/multicol/layers-split-across-columns-expected.png:
- platform/efl/fast/multicol/margin-collapse-expected.png:
- platform/efl/fast/multicol/max-height-columns-block-expected.png:
- platform/efl/fast/multicol/nested-columns-expected.png:
- platform/efl/fast/multicol/nested-columns-expected.txt:
- platform/efl/fast/multicol/overflow-across-columns-expected.png:
- platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png:
- platform/efl/fast/multicol/overflow-unsplittable-expected.png:
- platform/efl/fast/multicol/paginate-block-replaced-expected.png:
- platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
- platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
- platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
- platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
- platform/efl/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
- platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
- platform/efl/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
- platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
- platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
- platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
- platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
- platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
- platform/efl/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
- platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
- platform/efl/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
- platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.
- platform/efl/fast/multicol/positioned-split-expected.png:
- platform/efl/fast/multicol/positioned-with-constrained-height-expected.png:
- platform/efl/fast/multicol/positive-leading-expected.png:
- platform/efl/fast/multicol/scrolling-overflow-expected.png:
- platform/efl/fast/multicol/single-line-expected.png: Added.
- platform/efl/fast/multicol/single-line-expected.txt: Added.
- platform/efl/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
- platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
- platform/efl/fast/multicol/span/anonymous-style-inheritance-expected.png:
- platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
- platform/efl/fast/multicol/span/clone-flexbox-expected.txt: Added.
- platform/efl/fast/multicol/span/clone-summary-expected.txt: Added.
- platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
- platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
- platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
- platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
- platform/efl/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
- platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
- platform/efl/fast/multicol/table-margin-collapse-expected.png:
- platform/efl/fast/multicol/table-vertical-align-expected.png:
- platform/efl/fast/multicol/table-vertical-align-expected.txt:
- platform/efl/fast/multicol/unsplittable-inline-block-expected.png:
- platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
- platform/efl/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
- platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
- platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
- platform/efl/fast/multicol/vertical-lr/float-multicol-expected.png:
- platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.png:
- platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
- platform/efl/fast/multicol/vertical-lr/float-paginate-expected.png:
- platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
- platform/efl/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
- platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
- platform/efl/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
- platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
- platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
- platform/efl/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.png:
- platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
- platform/efl/fast/multicol/vertical-rl/float-paginate-expected.png:
- platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
- platform/efl/fast/multicol/vertical-rl/rule-style-expected.txt: Added.
- platform/efl/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
- platform/efl/test_expectations:
- 5:29 PM Changeset in webkit [119179] by
-
- 16 edits in branches/chromium/1132/Source
Merge 118383 - [chromium] Only display frames created with memory allocations meant to be displayed
https://bugs.webkit.org/show_bug.cgi?id=85108
Reviewed by Adrienne Walker.
Source/WebCore:
In this patch we remove the setVisible() code paths from CCProxy, and
instead commit visiblity state along with a frame. We also commit a
flag with a frame that indicates if the frame is one that can be drawn.
The impl host is set to visible during commit instead of using a
special channel through the proxy, and the scheduler allows
commits when we are waiting to draw our first frame but blocked on
being non-visible.
canDraw is gated on a new flag that indicates if the frame is one meant
for display. A frame is meant for display if the frame was generated
with a memory allocation meant for display. At this time, any non-zero
memory allocation is considered meant for display.
We prevent races by not changing the memory allocation at any time
except during a commit. So we force a commit when the memory
allocation needs to be adjusted and we are not visible. Similarly,
we force a commit when visibility changes so that we are able to
commit the visibility change to the impl tree.
In order to prevent drawing frames that are not meant for display
with a single thread, we prevent compositing when the impl tree
is not visible, with an early out in CCSingleThreadProxy.
Unit tests: CCLayerTreeHostTestVisibilityAndAllocationControlDrawing
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/TiledLayerChromium.cpp:
- platform/graphics/chromium/TiledLayerChromium.h:
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore):
(WebCore::CCLayerTreeHost::setNeedsForcedCommit):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::sourceFrameCanBeDrawn):
(WebCore::CCLayerTreeHostImpl::setSourceFrameCanBeDrawn):
(CCLayerTreeHostImpl):
- platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
- platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::drawSuspendedUntilCommit):
(WebCore::CCSchedulerStateMachine::scheduledToDraw):
(WebCore::CCSchedulerStateMachine::updateState):
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore):
(WebCore::CCSingleThreadProxy::setNeedsForcedCommit):
(WebCore::CCSingleThreadProxy::doComposite):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsForcedCommit):
(WebCore):
(WebCore::CCThreadProxy::setNeedsForcedCommitOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::scheduledActionCommit):
- platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Removing code to protect visible textures when a tab becomes invisible,
as we want to reduce our memory limit for invisible tabs and these
textures should not be saved.
- src/NonCompositedContentHost.cpp:
- src/NonCompositedContentHost.h:
(NonCompositedContentHost):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::didCommit):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::scheduleComposite):
(WTF::CCLayerTreeHostTest::dispatchComposite):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::willAnimateLayers):
(CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest):
(WTF):
- 5:24 PM Changeset in webkit [119178] by
-
- 65 edits in trunk/Source
[chromium] Migrate to WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=87788
Patch by Shawn Singh <shawnsingh@chromium.org> on 2012-05-31
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):
Source/WebCore:
Covered by all existing layout tests and unit tests.
This patch replaces all occurrences of WebCore::TransformationMatrix
with WebKit::WebTransformationMatrix in the chromium compositor code.
- platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::WebTransformationMatrix):
(WebKit):
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setTransformFromAnimation):
- platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::sublayerTransform):
(WebCore::LayerChromium::drawTransform):
(WebCore::LayerChromium::setDrawTransform):
(WebCore::LayerChromium::screenSpaceTransform):
(WebCore::LayerChromium::setScreenSpaceTransform):
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
- platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::projectionMatrix):
(WebCore::LayerRendererChromium::windowMatrix):
(LayerRendererChromium):
- platform/graphics/chromium/LinkHighlight.cpp:
(WebCore::LinkHighlight::LinkHighlight):
- platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::drawTransform):
(WebCore::RenderSurfaceChromium::setDrawTransform):
(WebCore::RenderSurfaceChromium::originTransform):
(WebCore::RenderSurfaceChromium::setOriginTransform):
(WebCore::RenderSurfaceChromium::screenSpaceTransform):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::replicaDrawTransform):
(WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
(WebCore::RenderSurfaceChromium::replicaOriginTransform):
(WebCore::RenderSurfaceChromium::setReplicaOriginTransform):
(WebCore::RenderSurfaceChromium::replicaScreenSpaceTransform):
(WebCore::RenderSurfaceChromium::setReplicaScreenSpaceTransform):
(RenderSurfaceChromium):
- platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::updateTiles):
- platform/graphics/chromium/cc/CCAnimationCurve.h:
(WebCore):
(CCTransformAnimationCurve):
- platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForLayer):
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
- platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::quadTransform):
(WebCore::CCDrawQuad::layerTransform):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
(WebCore::CCTransformKeyframe::clone):
(WebCore::CCKeyframedTransformAnimationCurve::getValue):
- platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCKeyframedTransformAnimationCurve):
- platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::tickAnimations):
- platform/graphics/chromium/cc/CCLayerAnimationController.h:
(WebKit):
(WebCore):
(CCLayerAnimationControllerClient):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::quadTransform):
(WebCore::CCLayerImpl::setTransformFromAnimation):
(WebCore::CCLayerImpl::setSublayerTransform):
(WebCore::CCLayerImpl::setTransform):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::sublayerTransform):
(WebCore::CCLayerImpl::drawTransform):
(WebCore::CCLayerImpl::setDrawTransform):
(WebCore::CCLayerImpl::screenSpaceTransform):
(WebCore::CCLayerImpl::setScreenSpaceTransform):
- platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):
- platform/graphics/chromium/cc/CCLayerSorter.h:
(WebKit):
(LayerShape):
- platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
- platform/graphics/chromium/cc/CCLayerTreeHost.h:
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::CCLayerTreeHostCommon::calculateVisibleRect):
(WebCore::isSurfaceBackFaceVisible):
(WebCore::calculateVisibleLayerRect):
(WebCore::isScaleOrTranslation):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::damageInSurfaceSpace):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore):
- platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::projectPoint):
(WebCore::mapPoint):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectQuad):
- platform/graphics/chromium/cc/CCMathUtil.h:
(WebKit):
(WebCore):
(CCMathUtil):
- platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::reduceOcclusionBelowSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::addOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
(WebCore::::unoccludedContributingSurfaceContentRect):
- platform/graphics/chromium/cc/CCOcclusionTracker.h:
- platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::didUpload):
(WebCore::CCOverdrawMetrics::didCullForDrawing):
(WebCore::CCOverdrawMetrics::didDraw):
- platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(WebKit):
(CCOverdrawMetrics):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsToFillScreen):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setDrawTransform):
(WebCore::CCRenderSurface::drawTransform):
(WebCore::CCRenderSurface::setOriginTransform):
(WebCore::CCRenderSurface::originTransform):
(WebCore::CCRenderSurface::setScreenSpaceTransform):
(WebCore::CCRenderSurface::screenSpaceTransform):
(WebCore::CCRenderSurface::setReplicaDrawTransform):
(WebCore::CCRenderSurface::replicaDrawTransform):
(WebCore::CCRenderSurface::setReplicaOriginTransform):
(WebCore::CCRenderSurface::replicaOriginTransform):
(WebCore::CCRenderSurface::setReplicaScreenSpaceTransform):
(WebCore::CCRenderSurface::replicaScreenSpaceTransform):
(CCRenderSurface):
- platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::create):
(WebCore::CCSharedQuadState::CCSharedQuadState):
- platform/graphics/chromium/cc/CCSharedQuadState.h:
(CCSharedQuadState):
(WebCore::CCSharedQuadState::quadTransform):
(WebCore::CCSharedQuadState::layerTransform):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:
(WebCore::CCSolidColorLayerImpl::quadTransform):
- platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::quadTransform):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
- src/WebLayer.cpp:
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::setTransform):
- tests/CCAnimationTestCommon.cpp:
(WebKitTests::FakeTransformTransition::getValue):
- tests/CCAnimationTestCommon.h:
- tests/CCDamageTrackerTest.cpp:
(WebKitTests::executeCalculateDrawTransformsAndVisibility):
(WebKitTests::TEST_F):
- tests/CCKeyframedAnimationCurveTest.cpp:
- tests/CCLayerAnimationControllerTest.cpp:
- tests/CCLayerImplTest.cpp:
(WebCore::TEST):
- tests/CCLayerIteratorTest.cpp:
- tests/CCLayerSorterTest.cpp:
- tests/CCLayerTreeHostCommonTest.cpp:
- tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::setLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
- tests/CCLayerTreeTestCommon.h:
(WebKitTests):
- tests/CCMathUtilTest.cpp:
- tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTest::createRoot):
(WebKitTests::CCOcclusionTrackerTest::createLayer):
(WebKitTests::CCOcclusionTrackerTest::createSurface):
(WebKitTests::CCOcclusionTrackerTest::createDrawingLayer):
(WebKitTests::CCOcclusionTrackerTest::createReplicaLayer):
(WebKitTests::CCOcclusionTrackerTest::createDrawingSurface):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::setBaseProperties):
(WebKitTests::CCOcclusionTrackerTest::setProperties):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontOccludePixelsNeededForBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTwoBackgroundFiltersReduceOcclusionTwice::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionBelowBackgroundFilter::runMyTest):
(WebKitTests::CCOcclusionTrackerTestDontReduceOcclusionIfBackgroundFilterIsOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReduceOcclusionWhenBackgroundFilterIsPartiallyOccluded::runMyTest):
- tests/CCQuadCullerTest.cpp:
- tests/CCRenderSurfaceTest.cpp:
- tests/FloatQuadTest.cpp:
- tests/LayerChromiumTest.cpp:
- tests/LinkHighlightTest.cpp:
- tests/TiledLayerChromiumTest.cpp:
- tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):
(WebKit):
- 5:05 PM Changeset in webkit [119177] by
-
- 2 edits in branches/chromium/1132/Source/WebKit/chromium
Merge 118276 - [chromium] Enable the CCLayerTreeHostTestCanDrawBlocksDrawing test in single-threaded mode
https://bugs.webkit.org/show_bug.cgi?id=87308
Reviewed by James Robinson.
Chromium bug: http://crbug.com/127481
Unit test: CCLayerTreeHostTestCanDrawBlocksDrawing.runSingleThread
- tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::didCommit):
(WTF):
(WTF::CCLayerTreeHostTestCanDrawBlocksDrawing::didCommit):
TBR=danakj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10456072
- 5:02 PM Changeset in webkit [119176] by
-
- 1 edit in branches/chromium/1132/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
Merge 117825 - Don't force rendering in finishAllRendering
https://bugs.webkit.org/show_bug.cgi?id=86919
Reviewed by James Robinson.
After we acquire the texture layers on the main thread, we can't draw.
In particular if we destroyed the texture ids used previously by
TextureLayerChromium, drawing before a commit would cause a
bind-after-destroy.
Tested by CCLayerTreeHostTestFinishAllRendering.
- platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):
TBR=piman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10448114
- 5:02 PM Changeset in webkit [119175] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSGlobalObject does not mark m_privateNameStructure
https://bugs.webkit.org/show_bug.cgi?id=88023
Rubber stamped by Gavin Barraclough.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren): We need to mark this so it doesn't get
inadvertently garbage collected.
- 4:53 PM Changeset in webkit [119174] by
-
- 1 edit7 adds in trunk/LayoutTests
[Win] 4 css3 tests fail
https://bugs.webkit.org/show_bug.cgi?id=88024
Add Windows-specific expected (failing?) results to get the bots green.
- platform/win/css3: Added.
- platform/win/css3/filters: Added.
- platform/win/css3/filters/composited-during-animation-expected.txt: Added.
- platform/win/css3/filters/composited-during-animation-layertree-expected.txt: Added.
- platform/win/css3/filters/composited-during-transition-layertree-expected.txt: Added.
- platform/win/css3/unicode-bidi-isolate-basic-expected.png: Added.
- platform/win/css3/unicode-bidi-isolate-basic-expected.txt: Added.
- 4:48 PM Changeset in webkit [119173] by
-
- 5 edits in trunk/Source
[chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized
https://bugs.webkit.org/show_bug.cgi?id=87873
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.
When the layer renderer fails to initialize, be sure to stop the animation timer.
Source/WebCore:
Unit test: CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation.runSingleThread
- platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
(WebCore::CCSingleThreadProxy::animationTimerDelay):
(WebCore):
- platform/graphics/chromium/cc/CCSingleThreadProxy.h:
Source/WebKit/chromium:
- tests/CCLayerTreeHostTest.cpp:
(CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WTF::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WTF):
(WTF::TestHooks::didRecreateContext):
(TestHooks):
(WTF::TestHooks::createContext):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::clearEndTestTask):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::~EndTestTask):
(WTF::CCLayerTreeHostTest::EndTestTask::clearTest):
(WTF::CCLayerTreeHostTest::EndTestTask::run):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::endTestAfterDelay):
(FakeWebGraphicsContext3DMakeCurrentFails):
(WTF::FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(WTF::CCLayerTreeHostTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(WTF::TEST_F):
- 4:48 PM WikiStart edited by
- Added "(obsolete)" to "Result Fallback Order" (diff)
- 4:25 PM Changeset in webkit [119172] by
-
- 3 edits in trunk/Source/WebCore
RenderLayerCompositor cleanup: make RenderGeometryMap part of the OverlapMap
https://bugs.webkit.org/show_bug.cgi?id=88021
Reviewed by James Robinson.
We only ever use the RenderGeometryMap when we have an OverlapMap, so make
it a member of the OverlapMap.
No behavior change.
- rendering/RenderLayerCompositor.cpp:
(RenderLayerCompositor::OverlapMap):
(WebCore::RenderLayerCompositor::OverlapMap::geometryMap):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):
- 4:13 PM Changeset in webkit [119171] by
-
- 6 edits in trunk/Source/WebCore
[V8] Pass Isolate to v8Boolean()
https://bugs.webkit.org/show_bug.cgi?id=87948
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8Boolean().
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyDeleter):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):
- bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::sendCallback):
- 4:12 PM Changeset in webkit [119170] by
-
- 1 edit in trunk/Source/WebKit/gtk/ChangeLog
Fix a broken ChangeLog entry from r119113 due to a corrupted patch.
- 4:02 PM Changeset in webkit [119169] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 4:01 PM Changeset in webkit [119168] by
-
- 1 copy in tags/Safari-536.15
New Tag.
- 4:00 PM Changeset in webkit [119167] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 4:00 PM Changeset in webkit [119166] by
-
- 8 edits12 adds in trunk/LayoutTests
[Win] 10 fast/forms tests failing
https://bugs.webkit.org/show_bug.cgi?id=88013
Add/update Windows-expected (failing?) results to get the bots greener.
- platform/win/fast/forms/basic-selects-expected.png: Added.
- platform/win/fast/forms/basic-selects-expected.txt:
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png:
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- platform/win/fast/forms/file: Added.
- platform/win/fast/forms/file/file-input-disabled-expected.png: Added.
- platform/win/fast/forms/file/file-input-disabled-expected.txt: Added.
- platform/win/fast/forms/implicit-submission-expected.txt:
- platform/win/fast/forms/input-step-as-double-expected.txt: Added.
- platform/win/fast/forms/input-text-drag-down-expected.png:
- platform/win/fast/forms/input-text-drag-down-expected.txt:
- platform/win/fast/forms/select: Added.
- platform/win/fast/forms/select-overflow-scroll-expected.png: Added.
- platform/win/fast/forms/select-overflow-scroll-expected.txt: Added.
- platform/win/fast/forms/select-overflow-scroll-inherited-expected.png: Added.
- platform/win/fast/forms/select-overflow-scroll-inherited-expected.txt: Added.
- platform/win/fast/forms/select/optgroup-rendering-expected.png: Added.
- platform/win/fast/forms/select/optgroup-rendering-expected.txt: Added.
- platform/win/fast/forms/text-control-intrinsic-widths-expected.txt:
- 3:58 PM Changeset in webkit [119165] by
-
- 3 edits in branches/safari-536-branch/Source/WebCore
fix after r119150.
- 3:54 PM Changeset in webkit [119164] by
-
- 4 edits in trunk/Source/WebKit/chromium
2012-05-15 Brett Wilson <brettw@chromium.org>
Hook up GTK IsKeyPad flag for keyboard events, and preserve this flag
on all platforms when converting back to a WebKeyboardEvent.
Reviewed by Dimitri Glazkov.
- src/WebInputEventConversion.cpp: (WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
- src/gtk/WebInputEventFactory.cpp: (WebKit::WebInputEventFactory::keyboardEvent):
- tests/WebInputEventFactoryTestGtk.cpp:
- 3:53 PM Changeset in webkit [119163] by
-
- 1 delete in tags/Safari-536.15
Remove Tag.
- 3:50 PM Changeset in webkit [119162] by
-
- 2 edits in trunk/Source/WTF
Enable support for rvalue references when building with a version of clang that supports them
https://bugs.webkit.org/show_bug.cgi?id=88018
Re-enable support for rvalue references when building with a version of Xcode newer than 4.2.
- wtf/Compiler.h:
- 3:47 PM Changeset in webkit [119161] by
-
- 78 edits in trunk
IndexedDB: Implement IDBTransaction.error and IDBRequest.error
https://bugs.webkit.org/show_bug.cgi?id=87865
Patch by Alec Flett <alecflett@chromium.org> on 2012-05-31
Reviewed by Tony Chang.
Source/WebCore:
Added "error" attribute to IDBRequest and IDBTransaction. Update
IDBDatabaseError to honor the IDBDatabaseException behavior
of dealing with IDB-specific throws of DOMException codes,
as per the spec.
Existing tests which previously tested 'errorCode' and
'webkitErrorMessage' have been updated to use the new attribute.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setVersion):
- Modules/indexeddb/IDBDatabaseError.h:
(WebCore::IDBDatabaseError::create):
(WebCore::IDBDatabaseError::code):
(WebCore::IDBDatabaseError::idbCode):
(WebCore::IDBDatabaseError::name):
(WebCore::IDBDatabaseError::IDBDatabaseError):
(IDBDatabaseError):
- Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
(WebCore::getErrorEntry):
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getErrorName):
(WebCore::IDBDatabaseException::getLegacyErrorCode):
- Modules/indexeddb/IDBDatabaseException.h:
(IDBDatabaseException):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::error):
(WebCore):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::onSuccessWithContinuation):
(WebCore::IDBRequest::dispatchEvent):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::error):
(WebCore):
(WebCore::IDBTransaction::setError):
- Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
- Modules/indexeddb/IDBTransaction.idl:
Source/WebKit/chromium:
IDBDatabaseError now honors IDB-specific DOMException codes,
so make sure that's how they are passed to/from chromium.
- src/WebIDBDatabaseError.cpp:
(WebKit::WebIDBDatabaseError::assign):
LayoutTests:
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics-workers-expected.txt:
- storage/indexeddb/create-and-remove-object-store-expected.txt:
- storage/indexeddb/cursor-continue-expected.txt:
- storage/indexeddb/cursor-update-expected.txt:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/deleteIndex-expected.txt:
- storage/indexeddb/factory-cmp-expected.txt:
- storage/indexeddb/get-keyrange-expected.txt:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics-workers-expected.txt:
- storage/indexeddb/index-count-expected.txt:
- storage/indexeddb/index-unique-expected.txt:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/key-generator-expected.txt:
- storage/indexeddb/key-type-array-expected.txt:
- storage/indexeddb/keypath-edges-expected.txt:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics-workers-expected.txt:
- storage/indexeddb/objectstore-count-expected.txt:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/readonly-expected.txt:
- storage/indexeddb/resources/basics.js:
(test):
(openCallback):
- storage/indexeddb/resources/create-and-remove-object-store.js:
(testCreateAndRemove):
(cleanDatabase):
(tryOnceMore):
- storage/indexeddb/resources/cursor-continue.js:
(ascendingErrorTestLessThan.request.onsuccess):
(ascendingErrorTestLessThan):
(ascendingErrorTestEqual.request.onsuccess):
(ascendingErrorTestEqual):
(descendingErrorTestGreaterThan.request.onsuccess):
(descendingErrorTestGreaterThan):
(descendingErrorTestEqual.request.onsuccess):
(descendingErrorTestEqual):
(onTransactionComplete):
- storage/indexeddb/resources/cursor-update.js:
(keyCursor):
- storage/indexeddb/resources/database-basics.js:
(testClose):
- storage/indexeddb/resources/database-quota.js:
(logError):
- storage/indexeddb/resources/deleteIndex.js:
(twiddleIndexes):
(postTwiddling):
- storage/indexeddb/resources/factory-cmp.js:
(testValidKeys):
(testInvalidKeys):
- storage/indexeddb/resources/get-keyrange.js:
(getNullTest):
- storage/indexeddb/resources/index-basics.js:
(index3Count):
- storage/indexeddb/resources/index-count.js:
- storage/indexeddb/resources/index-unique.js:
(addMoreDataFailed):
- storage/indexeddb/resources/invalid-keys.js:
- storage/indexeddb/resources/key-generator.js:
- storage/indexeddb/resources/key-type-array.js:
(testDepthLimits):
- storage/indexeddb/resources/keypath-edges.js:
- storage/indexeddb/resources/keyrange.js:
(test):
- storage/indexeddb/resources/objectstore-autoincrement.js:
(getAbrahamSuccess):
- storage/indexeddb/resources/objectstore-basics.js:
(setVersionSuccess):
(createIndex):
(addAgainFailure):
(removeSuccessButNotThere):
(testPreConditions.request.onsuccess):
(testPreConditions):
- storage/indexeddb/resources/objectstore-count.js:
- storage/indexeddb/resources/open-cursor.js:
(cursorWithKeySuccess):
(cursorSuccess):
- storage/indexeddb/resources/readonly.js:
(openSuccess):
- storage/indexeddb/resources/set_version_queue.js:
(connectionError):
- storage/indexeddb/resources/shared.js:
(unexpectedErrorCallback):
(evalAndExpectException):
- storage/indexeddb/resources/transaction-abort-workers.js:
(transactionAborted):
(transactionCompleted):
(timeoutTest.transaction.onabort):
(timeoutTest):
(errorTransactionAborted):
- storage/indexeddb/resources/transaction-abort.js:
(firstAdd):
(secondAdd):
(transactionAborted):
- storage/indexeddb/resources/transaction-after-close.js:
(firstTransactionComplete):
- storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(created):
(afterComplete):
- storage/indexeddb/resources/transaction-basics.js:
(testInactiveAbortedTransaction):
(testInactiveCompletedTransaction):
(testInvalidMode):
- storage/indexeddb/resources/transaction-read-only.js:
(setVersionDone):
(gotCursor):
- storage/indexeddb/set_version_queue-expected.txt:
- storage/indexeddb/transaction-abort-expected.txt:
- storage/indexeddb/transaction-abort-workers-expected.txt:
- storage/indexeddb/transaction-after-close-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-read-only-expected.txt:
- 3:43 PM Changeset in webkit [119160] by
-
- 4 edits in trunk/Source
[chromium] Assertion failures during compositor startup in lost context situations
https://bugs.webkit.org/show_bug.cgi?id=87912
Reviewed by Adrienne Walker.
Source/WebCore:
getShaderiv and getProgramiv may return 0 if the context is lost. We correctly recover in this case, so it's
bogus to fail an ASSERT in debug in this case.
Added new unit test in LayerRendererChromiumTest to cover this.
- platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::contextLost):
(WebCore):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::createShaderProgram):
Source/WebKit/chromium:
Adds a unit test verifying that even if we lose our context during or before initialization we get through the
rest of the path without failing ASSERT()s.
- tests/LayerRendererChromiumTest.cpp:
(LoseContextOnFirstGetContext):
(LoseContextOnFirstGetContext::LoseContextOnFirstGetContext):
(TEST):
- 3:37 PM Changeset in webkit [119159] by
-
- 3 edits in trunk/Source/WebKit/gtk
Unreviewed, rolling out r119113.
http://trac.webkit.org/changeset/119113
https://bugs.webkit.org/show_bug.cgi?id=88016
This caused multiple regressions (Requested by mrobinson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31
- WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString):
- webkit/webkitspellcheckerenchant.cpp:
(checkSpellingOfString):
- 3:36 PM Acronyms edited by
- (diff)
- 3:34 PM Changeset in webkit [119158] by
-
- 5 edits3 adds in trunk
Fix crash in V8Document::createTouchListCallback.
https://bugs.webkit.org/show_bug.cgi?id=87085
Source/WebCore:
Reviewed by Abhishek Arya.
Test: fast/events/touch/document-create-touch-list-crash.html
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::createTouchListCallback): Verify the native type
of the arguments passed to createTouchList are Touches before appending
them to the TouchList. In the case of a non-Touch argument, insert
null into the TouchList. This consolidates V8 and JSC bindings
behaviour.
- dom/Document.cpp: Remove dead code.
- dom/Document.h: ditto.
LayoutTests:
Test for crash in document.createTouchList when it
is supplied with non-touch parameters.
Reviewed by Abhishek Arya.
- fast/events/touch/document-create-touch-list-crash-expected.txt: Added.
- fast/events/touch/document-create-touch-list-crash.html: Added.
- 3:30 PM Changeset in webkit [119157] by
-
- 2 edits in trunk/Source/WTF
DataLog should be usable outside of JSC
https://bugs.webkit.org/show_bug.cgi?id=88015
Reviewed by Oliver Hunt.
- wtf/DataLog.h:
(WTF):
- 3:18 PM Changeset in webkit [119156] by
-
- 1 edit2 adds in trunk/LayoutTests
Updating test expectations after r119124.
- platform/chromium/fast/workers/storage/test-authorizer-sync-expected.txt: Added.
- 3:06 PM Changeset in webkit [119155] by
-
- 4 edits in branches/safari-536-branch/Source
Versioning.
- 3:03 PM Changeset in webkit [119154] by
-
- 1 copy in tags/Safari-536.15
New Tag.
- 2:51 PM Changeset in webkit [119153] by
-
- 2 edits in trunk/Tools
[Chromium] Chromium DRT should be able to load external resources
https://bugs.webkit.org/show_bug.cgi?id=87893
Reviewed by Dirk Pranke.
Allow external resources to be loaded when the main frame's URL is also an external resource.
This change is analogous to r118231 for Mac port.
- DumpRenderTree/chromium/WebViewHost.cpp:
(blockRequest):
(isLocalhost):
(hostIsUsedBySomeTestsToGenerateError):
(WebViewHost::willSendRequest):
- 2:32 PM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 2:26 PM Changeset in webkit [119152] by
-
- 4 edits in branches/safari-536-branch/LayoutTests
More result updating for disabling CSS Exclusions.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- 2:21 PM Changeset in webkit [119151] by
-
- 3 edits in trunk/Source/WebCore
Remove some duplicate code in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=88009
Reviewed by Anders Carlsson.
RenderLayerCompositor::hasNonAffineTransform() has the same code
as the existing RenderLayer::has3DTransform(), so just use the
RenderLayer method and remove hasNonAffineTransform().
No behavior change.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 2:20 PM Changeset in webkit [119150] by
-
- 34 edits in branches/safari-536-branch
Merge <rdar://problem/11524921>
- 2:15 PM Changeset in webkit [119149] by
-
- 1 edit5 adds in trunk/LayoutTests
[Win] 5 fast/events/popup-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88008
Add Windows-specific expected (failing?) results to get the bots greener.
- platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
- platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
- platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
- platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
- platform/win/fast/events/popup-blocking-timers-expected.txt: Added.
- 2:12 PM Changeset in webkit [119148] by
-
- 4 edits in branches/safari-536-branch/LayoutTests
Updating results after r119051.
Per discussion with Simon, it's not surprising that more layers have drawsContents now.
- compositing/layer-creation/overlap-animation-expected.txt:
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- 2:10 PM Changeset in webkit [119147] by
-
- 13 edits8 adds in trunk/LayoutTests
[Win] 23 media tests fail / time out
https://bugs.webkit.org/show_bug.cgi?id=88005
Add/update the Windows expected (failing?) results to get the bots greener.
- platform/win/Skipped:
- platform/win/media/audio-controls-rendering-expected.txt:
- platform/win/media/audio-repaint-expected.txt:
- platform/win/media/controls-after-reload-expected.txt:
- platform/win/media/controls-strict-expected.txt:
- platform/win/media/controls-styling-expected.txt:
- platform/win/media/controls-without-preload-expected.txt:
- platform/win/media/media-can-play-wav-audio-expected.txt: Added.
- platform/win/media/media-controls-clone-expected.txt:
- platform/win/media/media-controls-invalid-url-expected.txt: Added.
- platform/win/media/media-document-audio-repaint-expected.txt:
- platform/win/media/nodesFromRect-shadowContent-expected.txt: Added.
- platform/win/media/video-colorspace-yuv420-expected.txt: Added.
- platform/win/media/video-colorspace-yuv422-expected.txt: Added.
- platform/win/media/video-controls-rendering-expected.txt:
- platform/win/media/video-display-toggle-expected.txt:
- platform/win/media/video-no-audio-expected.txt:
- platform/win/media/video-pause-immediately-expected.txt: Added.
- platform/win/media/video-playing-and-pause-expected.txt: Added.
- platform/win/media/video-size-intrinsic-scale-expected.txt: Added.
- 2:09 PM Changeset in webkit [119146] by
-
- 22 edits in trunk/Source
Unreviewed, rolling out r119125.
http://trac.webkit.org/changeset/119125
https://bugs.webkit.org/show_bug.cgi?id=88007
Will break android build if rolled (Requested by rafaelw_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayer::bytesLoaded):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::bytesLoaded):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::bytesLoaded):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::bytesLoaded):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::bytesLoaded):
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::bytesLoaded):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::bytesLoaded):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
- platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):
Source/WebKit/chromium:
- public/WebMediaPlayer.h:
(WebMediaPlayer):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 2:03 PM Changeset in webkit [119145] by
-
- 12 edits in trunk/Source
Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=87933
Reviewed by Dan Bernstein.
Source/WebCore:
- editing/Editor.cpp:
- editing/Editor.h:
- loader/EmptyClients.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/EditorClient.h:
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
- 1:58 PM Changeset in webkit [119144] by
-
- 1 edit5 adds in trunk/LayoutTests
[Win] fast/events/remove-target* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88006
Add Windows-specific expected (failing?) results to get the bots greener.
- platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
- platform/win/fast/events/remove-target-in-mouseup-expected.txt: Added.
- platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
- platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
- platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.
- 1:55 PM Writing Layout Tests for DumpRenderTree edited by
- Added a section on ref-tests and added more tips on portable text (diff)
- 1:55 PM Changeset in webkit [119143] by
-
- 2 edits in trunk/Source/WTF
Disable support for rvalue references until I figure out why this is breaking the Xcode 4.2 build.
- wtf/Compiler.h:
- 1:53 PM Changeset in webkit [119142] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.
Skip the test just like GTK+, as there seems to be a problem in
the cairo backend that makes the test fail.
- platform/efl/test_expectations.txt:
- 1:48 PM Changeset in webkit [119141] by
-
- 9 edits in branches/safari-536-branch/LayoutTests
Update test results for disabling CSS Exclusions.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/Skipped:
- platform/mac/fast/js/global-constructors-expected.txt:
- platform/win/Skipped:
- platform/win/fast/js/global-constructors-expected.txt:
- platform/wk2/Skipped:
- svg/css/getComputedStyle-basic-expected.txt:
- 1:44 PM Changeset in webkit [119140] by
-
- 4 edits in trunk/Tools
Build fixes.
Disable the C++11 extensions warning.
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 1:41 PM Changeset in webkit [119139] by
-
- 17 edits in trunk/Source
[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=87877
Reviewed by James Robinson.
Source/WebCore:
We add data to CCRenderSurfaceDrawQuad so that the only use of
CCRenderSurface directly from LayerRendererChromium is to
reserve, release, and use the surface's textures, and to set the
scissor rect. Each of these changes will be done independent
of this change.
Covered by existing tests.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
- platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
- platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::contentsTextureId):
- platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
- platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
- platform/graphics/chromium/cc/CCQuadCuller.cpp:
- platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
- platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
- platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore):
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::hasValidContentsTexture):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::hasValidBackgroundTexture):
(WebCore::CCRenderSurface::hasMask):
(WebCore::CCRenderSurface::replicaHasMask):
(WebCore::CCRenderSurface::appendQuads):
- platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
(CCRenderSurface):
- platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:
(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):
- platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:
(WebKit):
(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::maskTextureId):
(WebCore::CCRenderSurfaceDrawQuad::filters):
(WebCore::CCRenderSurfaceDrawQuad::backgroundFilters):
- platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::contentsTextureId):
- platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
Source/WebKit/chromium:
- tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):
- 1:28 PM Changeset in webkit [119138] by
-
- 3 edits8 adds in trunk/LayoutTests
[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998
Add/update Windows-specific expected (failing?) pixel results in order to get the bots greener.
- platform/win/fast/text/complex-preferred-logical-widths-expected.png: Added.
- platform/win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
- platform/win/fast/text/international/arabic-justify-expected.png: Added.
- platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
- platform/win/fast/text/international/text-combine-image-test-expected.png:
- platform/win/fast/text/international/text-spliced-font-expected.png: Added.
- platform/win/fast/text/line-initial-and-final-swashes-expected.png: Added.
- platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
- platform/win/fast/text/unicode-variation-selector-expected.png: Added.
- 1:16 PM Changeset in webkit [119137] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening, updating baselines after r119124.
- dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
- dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
- fast/workers/storage/test-authorizer-sync-expected.txt:
- 12:58 PM Changeset in webkit [119136] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/11544454> and https://bugs.webkit.org/show_bug.cgi?id=87990
Crashes unregistering DOMWindowProperties while releasing CachedPages
Reviewed by Jessie Berlin.
This patch rewrites DOMWindowProperty to always keep direct track of the DOMWindow
it has registered with and to only ever unregister from that very same DOMWindow.
No new tests. (While the direct cause of the crash is understood, reproducing it is not)
- page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::~DOMWindowProperty):
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):
- page/DOMWindowProperty.h:
(DOMWindowProperty):
- 12:48 PM Changeset in webkit [119135] by
-
- 1 edit in branches/chromium/1132/LayoutTests/platform/chromium/test_expectations.txt
Revert bad merge of chromium test_expectations.txt on 1132 branch
BUG=130392
- 12:30 PM Changeset in webkit [119134] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[Blackberry] Initialize the select client and delete the pointer
in the destructor so it doesn't leak. Fixes test crashes.
https://bugs.webkit.org/show_bug.cgi?id=87992
Reviewed by Rob Buis.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):
- 12:20 PM Changeset in webkit [119133] by
-
- 2 edits2 copies in branches/chromium/1132
Merge 117365 - Crash if SVG gradient stop has display: none set
- 12:12 PM Changeset in webkit [119132] by
-
- 3 edits in trunk/Source/WTF
Vector should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=87997
Reviewed by Andreas Kling.
- wtf/Compiler.h:
Use has_extension so we can use move semantics and other C++11 features even when building as C++98.
- wtf/Vector.h:
Add a move constructor and a move assignment operator to Vector.
- 12:08 PM Changeset in webkit [119131] by
-
- 58 edits in trunk
rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
https://bugs.webkit.org/show_bug.cgi?id=87907
Reviewed by Ojan Vafai.
Source/WebCore:
This was recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#align-items-property
No new tests, updated the tests to use the new naming.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
- rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
- rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData): Move member variables to StyleRareNonInheritedData
because these values will eventually apply to more than just flexbox.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
Updated tests for new CSS property names.
- css3/flexbox/align-absolute-child.html:
- css3/flexbox/cross-axis-scrollbar.html:
- css3/flexbox/css-properties-expected.txt:
- css3/flexbox/css-properties.html:
- css3/flexbox/flex-align-baseline.html:
- css3/flexbox/flex-align-column.html:
- css3/flexbox/flex-align-end.html:
- css3/flexbox/flex-align-stretch.html:
- css3/flexbox/flex-align-vertical-writing-mode.html:
- css3/flexbox/flex-align.html:
- css3/flexbox/line-wrapping.html:
- css3/flexbox/multiline-align.html:
- css3/flexbox/multiline-reverse-wrap-baseline.html:
- css3/flexbox/orthogonal-flex-directions.html:
- css3/flexbox/position-absolute-child.html:
- css3/flexbox/true-centering.html:
- 11:52 AM Changeset in webkit [119130] by
-
- 2 edits9 adds in trunk/LayoutTests
[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998
Add/update Windows-specific expected (failing?) results in order to get the bots greener.
- platform/win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
- platform/win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
- platform/win/fast/text/international/arabic-justify-expected.txt: Added.
- platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
- platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
- platform/win/fast/text/international/text-combine-image-test-expected.txt:
- platform/win/fast/text/international/text-spliced-font-expected.txt: Added.
- platform/win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
- platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
- platform/win/fast/text/unicode-variation-selector-expected.txt: Added.
- 11:48 AM Changeset in webkit [119129] by
-
- 2 edits in trunk/Source/Platform
[chromium] Add copy constructor to WebFilterOperations
https://bugs.webkit.org/show_bug.cgi?id=87970
Reviewed by James Robinson.
- chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):
- 11:37 AM Changeset in webkit [119128] by
-
- 2 edits in trunk/LayoutTests
Updating test expectations (svg/as-image/animated-svg-as-image.html)
- platform/chromium/test_expectations.txt:
- 11:17 AM Writing testharness Tests edited by
- (diff)
- 11:17 AM Writing testharness Tests edited by
- (diff)
- 11:11 AM Changeset in webkit [119127] by
-
- 4 edits in trunk/Tools
[WK2] window.internals settings are not reset between tests
https://bugs.webkit.org/show_bug.cgi?id=87783
Reviewed by Mihai Parparita.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done): Call resetAfterTest().
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity. (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals. This needs to be done after a tets, because the code assumes that there is an object with this name in global scope.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 11:09 AM Changeset in webkit [119126] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
https://bugs.webkit.org/show_bug.cgi?id=87968
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Rob Buis.
The override object is using a compositing thread WebOverlayPrivate
object with no client because the layer doesn't delegate drawing to the
WebOverlayPrivate, it's only used to modify the override properties on
the underlying compositing thread layer.
Since the m_layerCompositingThreadClient is optional, we have to add
null checks.
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):
- 11:03 AM Changeset in webkit [119125] by
-
- 22 edits in trunk/Source
Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
https://bugs.webkit.org/show_bug.cgi?id=86113
Reviewed by Eric Carlson.
Source/WebCore:
No new functionality, so no new tests. Loading progress is already tested by existing layouttests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::didLoadingProgress):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
- platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
- platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):
Source/WebKit/chromium:
- public/WebMediaPlayer.h:
(WebMediaPlayer):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):
- src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):
- 11:00 AM Changeset in webkit [119124] by
-
- 31 edits3 moves8 adds4 deletes in trunk
Make DOM Exceptions Errors
https://bugs.webkit.org/show_bug.cgi?id=85078
Reviewed by Oliver Hunt.
WebIDL mandates that exceptions should have Error.prototype on its prototype chain.
For JSC we have access to the Error.prototype from the binding code.
For V8 we set a field in the WrapperTypeInfo and when the constructor function is created we
set the prototype as needed.
Updated test: fast/dom/DOMException/prototype-object.html
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
(JSC):
(JSGlobalObject):
(JSC::JSGlobalObject::errorPrototype):
Source/WebCore:
- ForwardingHeaders/runtime/ErrorPrototype.h: Added.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestException::createPrototype):
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
- bindings/v8/V8BindingPerContextData.cpp:
(WebCore):
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
- bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
LayoutTests:
- fast/dom/DOMException/prototype-object-expected.txt:
- fast/dom/DOMException/prototype-object.html:
- fast/dom/DOMException/resources/prototype-object.js: Removed.
- platform/chromium-win/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Removed.
- platform/chromium-win/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Removed.
- platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
- platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
- platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt: Added.
- platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
- platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt.
- platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt.
- platform/chromium/svg/filters/feBlend-invalid-mode-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt.
- 10:56 AM Changeset in webkit [119123] by
-
- 2 edits in trunk/LayoutTests
[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBlockChild
when running media/media-volume-slider-rendered-below.html
https://bugs.webkit.org/show_bug.cgi?id=87450
Add the test to the Windows Skipped list to get the bots greener.
- platform/win/Skipped:
- 10:55 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 10:51 AM Writing testharness Tests created by
- 10:42 AM WikiStart edited by
- (diff)
- 10:41 AM Changeset in webkit [119122] by
-
- 40 edits in branches/safari-536-branch
Merge <rdar://problem/10887709>
- 10:38 AM Changeset in webkit [119121] by
-
- 6 edits3 adds in trunk/Source
[chromium] create WebTransformOperation interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=87510
Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
- chromium/public/WebTransformOperations.h: Added.
(WebKit):
(WebTransformOperations):
(WebKit::WebTransformOperations::~WebTransformOperations):
(WebKit::WebTransformOperations::WebTransformOperations):
(WebKit::WebTransformOperations::operator=):
Source/WebCore:
Unit tests:
WebTransformOperationsTest.transformTypesAreUnique
WebTransformOperationsTest.matchesTypesSameLength
WebTransformOperationsTest.matchesTypesDifferentLength
WebTransformOperationsTest.applyTranslate
WebTransformOperationsTest.applyRotate
WebTransformOperationsTest.applyScale
WebTransformOperationsTest.applySkew
WebTransformOperationsTest.applyPerspective
WebTransformOperationsTest.applyMatrix
WebTransformOperationsTest.applyOrder
WebTransformOperationsTest.blendOrder
WebTransformOperationsTest.blendProgress
WebTransformOperationsTest.blendWhenTypesDoNotMatch
- WebCore.gypi:
- platform/chromium/support/WebTransformOperations.cpp: Added.
(WebKit):
(WebTransformOperationsPrivate):
(WebKit::WebTransformOperations::apply):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::matchesTypes):
(WebKit::WebTransformOperations::appendTranslate):
(WebKit::WebTransformOperations::appendRotate):
(WebKit::WebTransformOperations::appendScale):
(WebKit::WebTransformOperations::appendSkew):
(WebKit::WebTransformOperations::appendPerspective):
(WebKit::WebTransformOperations::appendMatrix):
(WebKit::WebTransformOperations::reset):
(WebKit::WebTransformOperations::initialize):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/WebTransformOperationsTest.cpp: Added.
(TEST):
(checkProgress):
- 10:36 AM WikiStart edited by
- (diff)
- 10:35 AM Changeset in webkit [119120] by
-
- 1 edit15 adds in trunk/LayoutTests
10 W3C video and audio canPlayType tests are failing on Mac and Win
https://bugs.webkit.org/show_bug.cgi?id=75184
Add Windows-specific expected (failing?) results to get the bots greener.
- platform/win/media/W3C: Added.
- platform/win/media/W3C/audio: Added.
- platform/win/media/W3C/audio/canPlayType: Added.
- platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
- platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
- platform/win/media/W3C/video: Added.
- platform/win/media/W3C/video/canPlayType: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
- platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
- 10:33 AM Changeset in webkit [119119] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[Blackberry] WebKit's fullscreen mode needs to notify page client.
https://bugs.webkit.org/show_bug.cgi?id=87337
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-31
Reviewed by Antonio Gomes.
Move "fullScreenVideoCapable" into webpagePrivate to make code
clean for "fullScreenForElement/Node" of cromeClientBlackberry,
All Video checks and code path selections are in webpagePrivate now.
For some UX and secure reasons, we could not apply fullscreen capacity
for all elements, So we use client's fullscreenStart/Stop only for
those video elements and those elements containing video tags.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(WebKit):
(BlackBerry::WebKit::containsVideoTags):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):
- 10:29 AM Changeset in webkit [119118] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] Memory leak in webkit_web_view_init
https://bugs.webkit.org/show_bug.cgi?id=87943
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-31
Reviewed by Martin Robinson.
Fixed a memory leak in webkit_web_view_init by making the
UserMediaClientGtk to be owned by the WebView.
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
- webkit/webkitwebviewprivate.h:
- 10:28 AM Changeset in webkit [119117] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix reference to unset variable in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87981
Reviewed by Geoffrey Garen.
- runtime/JSONObject.cpp (Stringifier::Holder::Holder):
Initialize m_size in debug mode, as we check it later in an assert.
- 10:15 AM Changeset in webkit [119116] by
-
- 9 edits in trunk
[EFL][DRT] EFL's DRT navigation_policy_decision implementation
https://bugs.webkit.org/show_bug.cgi?id=85006
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
Reviewed by Tor Arne Vestbø.
Tools:
Added navigation_policy_decision implementation for DumpRenderTreeView.
Added LayoutTestController::setCustomPolicyDelegate implementation.
Modified LayoutTestController::waitForPolicyDelegate.
- DumpRenderTree/efl/DumpRenderTree.cpp:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/DumpRenderTreeEfl.h:
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(navigationTypeToString): aux function
(onNavigationPolicyDecision): navigation_policy_decision implementation
(drtViewAdd):
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setCustomPolicyDelegate):
(LayoutTestController::waitForPolicyDelegate):
LayoutTests:
Unskipped corresponding tests. Those still not passing are put into
test_expectations.txt.
- platform/efl/Skipped:
- platform/efl/test_expectations.txt:
- 10:00 AM Changeset in webkit [119115] by
-
- 7 edits in trunk
[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
https://bugs.webkit.org/show_bug.cgi?id=86195
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-05-31
Reviewed by Gustavo Noronha Silva.
Source/WebKit/efl:
add new function to clear security origin application cache,
and a function to create a security origin from url string.
Reindent the header to match new longer return signature.
- ewk/ewk_security_origin.cpp:
(ewk_security_origin_application_cache_clear):
(ewk_security_origin_new_from_string):
- ewk/ewk_security_origin.h:
Tools:
Implement clearApplicationCacheForOrigin in EFL
LayoutTestController.
- DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearApplicationCacheForOrigin):
LayoutTests:
Unskip http/tests/appcache/origin-delete.html now that
EFL TestLayoutController has required functionality.
- platform/efl/Skipped:
- 9:53 AM Changeset in webkit [119114] by
-
- 2 edits in trunk/Source/WebCore
m_totalAllocated should be intialized in RenderArena constructor
https://bugs.webkit.org/show_bug.cgi?id=87967
Reviewed by Ojan Vafai.
- rendering/RenderArena.cpp:
(WebCore::RenderArena::RenderArena): added missing initializer.
- 9:36 AM Changeset in webkit [119113] by
-
- 3 edits in trunk/Source/WebKit/gtk
Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118
Patch by commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2012-05-31
Reviewed by Gustavo Noronha Silva.
The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. To know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character.
Simplify the way the we break strings, by search for non-graphable
character manually to find word starts and ends. This has the side
effect of removing the dependency on Pango and eliminating one copy.
This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).
- WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.
- webkit/webkitspellcheckerenchant.cpp:
(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(getExtentsOfNextWord): Ditto.
(wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
(checkSpellingOfString): Don't split words on apostrophes.
- 9:32 AM Changeset in webkit [119112] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.
- platform/gtk/test_expectations.txt:
- 9:08 AM Changeset in webkit [119111] by
-
- 1 edit6 adds in trunk/LayoutTests
[Win] 6 canvas tests failing
https://bugs.webkit.org/show_bug.cgi?id=87983
Add Windows-specific expected (failing?) results to get the bots greener.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
- platform/win/fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.
- 9:00 AM Changeset in webkit [119110] by
-
- 13 edits in trunk/Source/WebCore
The difference between a column and a column group renderer is badly drawn
https://bugs.webkit.org/show_bug.cgi?id=87556
Reviewed by Abhishek Arya.
No expected change in behavior.
This patch tries to draw a better line between those 3 concepts:
- renderer is a RenderTableCol (RenderObject::isRenderTableCol).
- renderer is a column (RenderTableCol::isTableColumn()).
- renderer is a column group (RenderTableCol::isTableColumnGroup()).
(most of the code that needs to know the difference manipulate a RenderTableCol
so there was no need to move the 2 last helpers into RenderObject)
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
Factored the code to use the column / column group iteration we
set up in the rest of the code. Made the code more self-describing
by using more RenderTableCol functions.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Factored the code to use the isTableColumn() and isTableColumnGroup() to
better underline what we check.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderTableCol):
(WebCore::RenderObject::isTablePart):
Renamed isTableCol to isRenderTableCol to match the class as this doesn't
imply that the renderer is actually a column.
- html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::fullRecalc):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn):
Updated after the isRenderTableCol rename.
- dom/Text.cpp:
(WebCore::Text::rendererIsNeeded):
- editing/htmlediting.cpp:
(WebCore::isTableStructureNode):
Ditto and renamed some variables.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
Ditto and added a FIXME as the logic doesn't seem very bullet proof.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
Changed to use the enclosingColumnGroup* helpers.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::isChildAllowed):
(WebCore::RenderTableCol::canHaveChildren):
(WebCore::RenderTableCol::enclosingColumnGroup):
(WebCore::RenderTableCol::nextColumn):
Updated to use the new functions.
- rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColumn):
(WebCore::RenderTableCol::isTableColumnGroup):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentBefore):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentAfter):
Added the following new helpers.
- 8:41 AM Changeset in webkit [119109] by
-
- 2 edits in trunk/Source/WebCore
Fix Lion build after r119073.
- platform/Decimal.cpp:
(WebCore::Decimal::toString):
Do not attempt to assign a unsigned long long to an int.
- 8:31 AM Changeset in webkit [119108] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=87957
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_get_request): Return the WebKitURIRequest
representing the request that originated the download.
- UIProcess/API/gtk/WebKitDownload.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadRemoteFile):
- 8:29 AM Changeset in webkit [119107] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=87953
Reviewed by Martin Robinson.
The output stream to write the downloaded data is created in the
didReceiveResponse callback of the download client. When a
download is created for an existing ResourceHandle (this happens
for example when policy decision is download), the response has
already been received. In this case we should make sure that the
download client is notified about the response, so that when data
actually arrives the output stream has already been created.
- WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::startWithHandle):
- 8:27 AM Changeset in webkit [119106] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
https://bugs.webkit.org/show_bug.cgi?id=87930
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitWebView.cpp:
- 8:27 AM Changeset in webkit [119105] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash when closing web page if selection is active
https://bugs.webkit.org/show_bug.cgi?id=87962
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Antonio Gomes.
The embedder may try to remove a layer from the compositor at a stage
where the compositor has been set to 0.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):
- 8:15 AM Changeset in webkit [119104] by
-
- 3 edits in trunk/LayoutTests
[v8] Fix bug reference in array-override-set.html test
https://bugs.webkit.org/show_bug.cgi?id=87952
Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-05-31
Reviewed by Abhishek Arya.
- fast/canvas/webgl/array-override-set-expected.txt:
- fast/canvas/webgl/array-override-set.html:
- 8:12 AM Changeset in webkit [119103] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.
- platform/gtk/test_expectations.txt:
- 7:47 AM Changeset in webkit [119102] by
-
- 8 edits in trunk
[EFL] Enable CSS_IMAGE_SET flag
https://bugs.webkit.org/show_bug.cgi?id=87727
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-31
Reviewed by Adam Roben.
.:
Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
CSS_IMAGE_SET flag is enabled.
- CMakeLists.txt:
LayoutTests:
Unskip test case associated to CSS image-set functionality now that it
is enabled by default on EFL port.
- platform/efl/test_expectations.txt:
- 7:44 AM Changeset in webkit [119101] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Added FAIL expectation for GTK due to missing feature in DRT.
- platform/gtk/test_expectations.txt:
- 7:32 AM Changeset in webkit [119100] by
-
- 6 edits in trunk
the imageSmoothingEnabled flag needs to be in the state object
https://bugs.webkit.org/show_bug.cgi?id=87853
Patch by Keyar Hood <keyar@chromium.org> on 2012-05-31
Reviewed by Darin Adler.
Source/WebCore:
Updated fast/canvas/canvas-imageSmoothingEnabled.html instead of
adding a new test.
The imageSmoothingEnabled flag is saved in the draw state now.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):
- html/canvas/CanvasRenderingContext2D.h:
(State):
LayoutTests:
Updated the test for imageSmoothingEnabled to test that it is saved in
the draw state.
- fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
- fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:
- 7:08 AM Changeset in webkit [119099] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix checkbox position on Settings screen.
https://bugs.webkit.org/show_bug.cgi?id=87007
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-31
Reviewed by Yury Semikhatsky.
Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.
UI changes, no new tests.
- inspector/front-end/helpScreen.css:
(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.
- 7:00 AM Changeset in webkit [119098] by
-
- 53 edits in trunk
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
https://bugs.webkit.org/show_bug.cgi?id=87955
Reviewed by Simon Hausmann.
Source/WebCore:
- bridge/qt/qt_class.cpp:
- bridge/qt/qt_instance.cpp:
- bridge/qt/qt_runtime.h:
- page/qt/EventHandlerQt.cpp:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/OpenGLShims.cpp:
- platform/graphics/OpenGLShims.h:
- platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
- platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
- platform/graphics/qt/SimpleFontDataQt.cpp:
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/qt/DeviceMotionProviderQt.h:
- platform/qt/DeviceOrientationProviderQt.h:
- platform/qt/KURLQt.cpp:
- platform/qt/PlatformScreenQt.cpp:
- platform/qt/QWebPageClient.h:
- plugins/qt/PluginPackageQt.cpp:
- plugins/qt/PluginViewQt.cpp:
Source/WebKit/qt:
- Api/qgraphicswebview.cpp:
- Api/qgraphicswebview.h:
- Api/qwebframe.cpp:
- Api/qwebframe_p.h:
- Api/qwebpage.cpp:
- Api/qwebpage.h:
- Api/qwebsettings.cpp:
- Api/qwebview.cpp:
- Api/qwebview.h:
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/GeolocationClientQt.cpp:
- WebCoreSupport/GeolocationClientQt.h:
- WebCoreSupport/PageClientQt.cpp:
- WebCoreSupport/WebEventConversion.cpp:
- declarative/plugin.cpp:
- tests/qwebframe/tst_qwebframe.cpp:
- tests/util.h:
Source/WebKit2:
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
Source/WTF:
- wtf/qt/UtilsQt.h:
Tools:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
- DumpRenderTree/qt/EventSenderQt.cpp:
- DumpRenderTree/qt/QtInitializeTestFonts.cpp:
- DumpRenderTree/qt/main.cpp:
- QtTestBrowser/cookiejar.cpp:
- QtTestBrowser/launcherwindow.cpp:
- WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
- qmake/mkspecs/features/default_post.prf:
- 6:38 AM Changeset in webkit [119097] by
-
- 5 edits in trunk/Source/WebCore
Have StylePropertySet constructor take array/length instead of vector.
<http://webkit.org/b/87876>
Reviewed by Antti Koivisto.
Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.
Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
- css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
- 6:24 AM Changeset in webkit [119096] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r118989
https://bugs.webkit.org/show_bug.cgi?id=87958
Unreviewed gardening.
fast/css/font-face-download-error.html is skipped as bug85977 is not fixed yet.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
- platform/efl/test_expectations.txt:
- 6:07 AM Changeset in webkit [119095] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
https://bugs.webkit.org/show_bug.cgi?id=87936
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):
- 5:41 AM Changeset in webkit [119094] by
-
- 3 edits in trunk/Source/WebCore
Fixing compilation with SVG disabled.
https://bugs.webkit.org/show_bug.cgi?id=87944
This patch adds the missing enumeration value
'CSSPropertyWebkitBoxDecorationBreak' into switch statements to make
clang happy.
Patch by Mike West <mkwst@chromium.org> on 2012-05-31
Reviewed by Alexis Menard.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
- 5:33 AM Changeset in webkit [119093] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as-immediate-columns-child.html.
- platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:
- 5:30 AM Changeset in webkit [119092] by
-
- 1 edit10 adds in trunk/Source/WebKit2
[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=70231
Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-05-31
Reviewed by Chang Shu.
These codes can be used for WKPageDecidePolicyForResponseCallback on page policy callbacks.
The callback conveys WKURLResponseRef and WKURLRequestRef as parameter.
By the way, EFL browser needs content type from response to decide correct policy.
Another information, cookie, is necessary with similar reason.
But, there is no way to obtain such information on WebKit2 main stream, except for WKURLRequestCopyURL().
So, EFL port created those files to extract necessary information from WKURLResponseRef and WKURLRequestRef,
and not to desturb WebKit2 main stream.
- Shared/API/c/efl/WKURLRequestEfl.cpp: Added.
(WKURLRequestEflCopyCookies): extracting cookie information from WKURLRequestRef.
- Shared/API/c/efl/WKURLRequestEfl.h: Added.
- Shared/API/c/efl/WKURLResponseEfl.cpp: Added.
(WKURLResponseEflCopyContentType): extracting content type (i.e. MIME type) from WKURLResponseRef.
- Shared/API/c/efl/WKURLResponseEfl.h: Added.
- Shared/efl/WebCoreArgumentCodersEfl.cpp: Added.
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/efl/WebURLRequestEfl.cpp: Added.
(WebKit):
(WebKit::WebURLRequestEfl::WebURLRequestEfl):
(WebKit::WebURLRequestEfl::cookies): obtaining cookie information from ResourceRequest.
- Shared/efl/WebURLRequestEfl.h: Added.
(WebKit):
(WebURLRequestEfl):
(WebKit::WebURLRequestEfl::create):
- Shared/efl/WebURLResponseEfl.cpp: Added.
(WebKit):
(WebKit::WebURLResponseEfl::WebURLResponseEfl):
(WebKit::WebURLResponseEfl::contentType): obtaining content type (i.e. MIME type) from ResourceResponse.
- Shared/efl/WebURLResponseEfl.h: Added.
(WebKit):
(WebURLResponseEfl):
(WebKit::WebURLResponseEfl::create):
- 5:06 AM Changeset in webkit [119091] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.
- platform/qt/Skipped:
- 4:57 AM Changeset in webkit [119090] by
-
- 2 edits4 adds in trunk/LayoutTests
Unreviewed. Added new baselines for GTK after r117815.
- platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Updated.
- platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
- 4:57 AM Changeset in webkit [119089] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed. Added new baselines for GTK after r118891.
- platform/gtk/fast/forms/select/optgroup-rendering-expected.png: Added.
- platform/gtk/fast/forms/select/optgroup-rendering-expected.txt: Added.
- 4:54 AM Changeset in webkit [119088] by
-
- 2 edits in trunk/Source/WebCore
[Platform] Implementation of Decimal(int32_t) isn't portable.
https://bugs.webkit.org/show_bug.cgi?id=87941
Reviewed by Kent Tamura.
This patch changes negation of integer to make unsigned integer
in portable way.
No new tests. This patch doesn't change behavior.
- platform/Decimal.cpp:
(WebCore::Decimal::Decimal): Use uint64_t(-int64_t(i32)) instead of uint64_t(-i32)
- 4:48 AM Changeset in webkit [119087] by
-
- 2 edits in trunk/LayoutTests
fast/events/message-port-multi.html needs new baseline after r119027
https://bugs.webkit.org/show_bug.cgi?id=87949
Unreviewed gardening.
Update baseline for fast/events/message-port-multi.html after r119027.
Now all the checks are passing and we can get rid of the FAIL lines in
the expected result.
Patch by Christophe Dumez <Christophe Dumez> on 2012-05-31
- fast/events/message-port-multi-expected.txt:
- 4:35 AM Changeset in webkit [119086] by
-
- 3 edits1 move in trunk/Source/WebKit2
[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
https://bugs.webkit.org/show_bug.cgi?id=87923
Reviewed by Kenneth Rohde Christiansen.
EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file in order to maintain
internal functions more easily. EFL WK2 needs to adjust this as well.
- UIProcess/API/efl/PageClientImpl.cpp:
- UIProcess/API/efl/ewk_view_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
(WebCore):
- UIProcess/cairo/BackingStoreCairo.cpp:
- 4:28 AM Changeset in webkit [119085] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=87871
Reviewed by Yury Semikhatsky.
When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
- 4:22 AM Changeset in webkit [119084] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r118993
https://bugs.webkit.org/show_bug.cgi?id=87946
Unreviewed gardening.
Test fast/forms/file/input-file-write-files.html that was added at r118993 relies on
unsupported EventSender.beginDragWithFiles and hence should be skipped.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
- platform/efl/test_expectations.txt:
- 4:14 AM Changeset in webkit [119083] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskipping tests for GTK now passing in all the bots.
- platform/gtk/test_expectations.txt:
- 3:42 AM Changeset in webkit [119082] by
-
- 2 edits in trunk/LayoutTests
fast/dom/Window/mozilla-focus-blur.html failing after r118916
https://bugs.webkit.org/show_bug.cgi?id=87951
Unreviewed. Added FAIL expectation for GTK after r118916.
- platform/gtk/test_expectations.txt:
- 3:10 AM Changeset in webkit [119081] by
-
- 7 edits in trunk/LayoutTests
Test expectation pngs missing checksums
https://bugs.webkit.org/show_bug.cgi?id=87947
Reviewed by Ojan Vafai.
Add proper platform independent png expectation with checksum and revert chromium
expectations since layoutTestController.keepWebHistory() seems to have no effect
on chromium, and the test is still failing (See bug 87839).
- http/tests/misc/acid3-expected.png: Add png with embedded checksum.
- platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
- platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
- platform/chromium-mac/http/tests/misc/acid3-expected.png: Revert to prior r118566.
- platform/chromium-mac/http/tests/misc/acid3-expected.txt: Revert to prior r118566.
- platform/chromium/test_expectations.txt: Revert to prior r118566.
- 3:02 AM Changeset in webkit [119080] by
-
- 4 edits in trunk/Source
Source/WebCore: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927
Reviewed by Kenneth Rohde Christiansen.
Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using "<wtf/gobject/XXX>" directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.
- PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.
Source/WebKit: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927
Reviewed by Kenneth Rohde Christiansen.
Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using <wtf/gobject/XXX> directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.
- PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.
- 2:50 AM Changeset in webkit [119079] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 2:47 AM Changeset in webkit [119078] by
-
- 2 edits in trunk/Tools
[Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
Rubber-stamped by Kenneth Rohde Christiansen.
- qmake/config.tests/libpng/libpng.pro:
- 2:22 AM Changeset in webkit [119077] by
-
- 5 edits in trunk
[Chromium] Automatically install 64-bit linker for Android
https://bugs.webkit.org/show_bug.cgi?id=79780
Reviewed by Adam Barth.
Source/WebKit/chromium:
Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.
- DEPS:
Tools:
Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and "installing" it has been added to the
webkitdirs.pm script.
The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.
- Scripts/update-webkit-chromium:
- Scripts/webkitdirs.pm:
(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):
- 2:02 AM Changeset in webkit [119076] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening after r118957
https://bugs.webkit.org/show_bug.cgi?id=87937
Unreviewed gardening.
compositing/layer-creation/fixed-position-and-transform.html and compositing/layer-creation/fixed-position-under-transform.html
added with r118957 were skipped in EFL port as EFL's LayoutTestController does not implement layerTreeAsText.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
- platform/efl/test_expectations.txt:
- 1:55 AM Changeset in webkit [119075] by
-
- 2 edits in trunk/Source/WebKit/chromium
Build fix for Chromium Linux (Tests) after r119073.
- tests/DecimalTest.cpp:
(TEST_F):
- 1:42 AM Changeset in webkit [119074] by
-
- 5 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-31
- platform/qt/Skipped:
- platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
- platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
- 1:28 AM Changeset in webkit [119073] by
-
- 9 edits3 adds in trunk/Source
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360
Reviewed by Kent Tamura.
Source/WebCore:
This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.
Test: WebKit/chromium/tests/DecimalTest.cpp
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/Decimal.cpp: Added.
(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):
- platform/Decimal.h: Added.
(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):
Source/WebKit/chromium:
This patch added unit test for Decimal class.
- WebKit.gypi:
- tests/DecimalTest.cpp: Added.
(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):
- 1:22 AM Changeset in webkit [119072] by
-
- 2 edits in trunk/LayoutTests
[EFL][DRT] Gardening after r118920
https://bugs.webkit.org/show_bug.cgi?id=87934
Unreviewed, gardening of http/tests/local/fileapi/file-last-modified-after-delete.html which
relies on unsupported drag'n'drop feature.
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
- platform/efl/test_expectations.txt:
- 1:05 AM Changeset in webkit [119071] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655
Skip the test on wincairo platform.
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-31
Reviewed by Yury Semikhatsky.
- platform/wincairo/Skipped:
- 1:00 AM Changeset in webkit [119070] by
-
- 22 edits in trunk/Source/WebCore
[V8] Pass Isolate to v8String() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87825
Reviewed by Adam Barth.
The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8String() in custom bindings.
No tests. No change in behavior.
- bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::installFastSet):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
(WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
- bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallback):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringCallback):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
- bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::getParameterCallback):
- 12:55 AM Changeset in webkit [119069] by
-
- 5 edits in trunk
ComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
https://bugs.webkit.org/show_bug.cgi?id=87493
Reviewed by Dimitri Glazkov.
Source/WebCore:
ComposedShadowTreeWalker assumed that a visited shadow root is
always assigned to a shadow insertion point since it only
traverses nodes which are rendered. But there is an exceptional
use case such as an event dispatching. Some events, such as a
'click' event, may happen in an orphaned shadow subtree. In such
cases, traversal might start with a node in an orphaned shadow
subtree. So ComposedShadowTreeWalker can not assume that visited
shadow root is always assigned to a shadow insertion point.
This patch only fixes ComposedShadowTreeWalker.
ComposedShadowTreeParentWalker will be fixed in another patch with
an event dispatching test.
Test: fast/dom/shadow/composed-shadow-tree-walker.html
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
LayoutTests:
- fast/dom/shadow/composed-shadow-tree-walker.html:
- 12:33 AM Changeset in webkit [119068] by
-
- 10 edits in trunk/Source
Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes
https://bugs.webkit.org/show_bug.cgi?id=87830
Reviewed by James Robinson.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
(WebKit::Platform::processMemorySizesInBytes): moved this method from
Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h, also
removed 'get' prefix.
Source/WebCore:
Added a method for getting process memory usage in bytes. It is
used in the inspector memory instrumentation to get process total
memory usage.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport): provided embedders with a way to report WebKit process
memory usage.
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):
Source/WebKit/chromium:
- public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up
to the Source/Platform/chromium/public/Platform.h
- src/PlatformSupport.cpp:
- 12:22 AM Changeset in webkit [119067] by
-
- 9 edits3 deletes in trunk/Source
Unreviewed, rolling out r119062 and r119064.
http://trac.webkit.org/changeset/119062
http://trac.webkit.org/changeset/119064
https://bugs.webkit.org/show_bug.cgi?id=87360
Broke build on Lion, SnowLoepard, Chromium Windows, and
Chromium Linux 32
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/Decimal.cpp: Removed.
- platform/Decimal.h: Removed.
Source/WebKit/chromium:
- WebKit.gypi:
- tests/DecimalTest.cpp: Removed.
- 12:18 AM Changeset in webkit [119066] by
-
- 3 edits in trunk/Source/WebKit2
Move the specification of framework and library linking out of WebKit2.xcodeproj and into WebKit2.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=87932
Reviewed by Dan Bernstein.
Doing this makes it easier to vary linking based on SDK or other factors.
- Configurations/WebKit2.xcconfig: Create FRAMEWORK_AND_LIBRARY_LDFLAGS,
which specifies the same list of frameworks and libraries that were
previously in WebKit2's 'Link Binary With Libraries' build phase, and
append it to $(OTHER_LDFLAGS).
- WebKit2.xcodeproj/project.pbxproj: Remove all frameworks and
libraries from the 'Link Binary With Libraries' build phase.
- 12:12 AM Changeset in webkit [119065] by
-
- 5 edits2 adds in trunk
text-decoration should not be propagated through absolutely positioned elements to <a> tags
https://bugs.webkit.org/show_bug.cgi?id=86517
Source/WebCore:
Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.
Test: fast/css/text-decoration-in-second-order-descendants.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
Remove fix from 18611 as it doesn't work on second order descendants.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
Add floating and positioned checks when deciding whether to avoid propagating text decoration. Move all checks into new method to improve readability.
(WebCore::doesNotInheritTextDecoration): Added
LayoutTests:
Added layout test to check no propagation of text-decoration to second-order descendants
(i.e. descendants of descendants), where the first-order descendant is positioned.
Tightened up existing descendants test to fail when text-decoration is incorrectly propagated
to first-order descendant.
Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.
- fast/css/text-decoration-in-descendants-expected.html:
- fast/css/text-decoration-in-second-order-descendants-expected.html: Added.
- fast/css/text-decoration-in-second-order-descendants.html: Added.
