Timeline
Apr 8, 2013:
- 11:59 PM Changeset in webkit [147989] by
-
- 1 edit1 delete in trunk/Source/ThirdParty
Remove gyp from ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=114244
Rubberstamped by Ryosuke Niwa.
- gyp: Removed.
- 11:57 PM Changeset in webkit [147988] by
-
- 1 edit1 delete in trunk/Source/ThirdParty/ANGLE
Remove ANGLE.gyp
https://bugs.webkit.org/show_bug.cgi?id=114245
Unreviewed. Just removing an empty directory.
- ANGLE.gyp: Removed.
- 11:49 PM Changeset in webkit [147987] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove WebCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114239
Reviewed by Benjamin Poulain.
- WebCore.gyp: Removed.
- WebCore.gyp/.gitignore: Removed.
- WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Removed.
- WebCore.gyp/MakeNames.gypi: Removed.
- WebCore.gyp/WebCore.gyp: Removed.
- WebCore.gyp/mac: Removed.
- WebCore.gyp/mac/adjust_visibility.sh: Removed.
- WebCore.gyp/mac/check_objc_rename.sh: Removed.
- WebCore.gyp/scripts: Removed.
- WebCore.gyp/scripts/action_csspropertynames.py: Removed.
- WebCore.gyp/scripts/action_cssvaluekeywords.py: Removed.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py: Removed.
- WebCore.gyp/scripts/action_makenames.py: Removed.
- WebCore.gyp/scripts/action_useragentstylesheets.py: Removed.
- WebCore.gyp/scripts/rule_bison.py: Removed.
- WebCore.gyp/scripts/supplemental_idl_files.py: Removed.
- WebCore.gypi: Removed.
- 11:46 PM Changeset in webkit [147986] by
-
- 1 edit2 deletes in trunk/Source/JavaScriptCore
Remove JavaScriptCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114238
Reviewed by Benjamin Poulain.
- JavaScriptCore.gyp: Removed.
- JavaScriptCore.gyp/.gitignore: Removed.
- JavaScriptCore.gypi: Removed.
- 11:45 PM Changeset in webkit [147985] by
-
- 14 edits in trunk/Source/JavaScriptCore
Adds fromCharCode intrinsic support.
https://bugs.webkit.org/show_bug.cgi?id=104807
Patch by Vahag Vardanyan <vaag@ispras.ru> on 2013-04-08
Reviewed by Oliver Hunt.
Switch to using fromCharCode intrinsic instead of call operation in some cases.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC):
- runtime/StringConstructor.h:
(JSC):
- 11:44 PM Changeset in webkit [147984] by
-
- 2 edits in trunk/Tools
WKR (new-commit-bot) is too slow
https://bugs.webkit.org/show_bug.cgi?id=110087
Reviewed by Geoffrey Garen.
Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
Just run "svn log -r <revision>" instead to cut down the delay.
Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot.next_work_item):
(NewCommitBot._is_empty_log):
(NewCommitBot._update_checkout):
- 11:16 PM Changeset in webkit [147983] by
-
- 15 edits6 deletes in trunk
Rollout r147756: performance regression
https://bugs.webkit.org/show_bug.cgi?id=114176
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-08
Reviewed by Alexis Menard.
Source/WebCore:
Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 "[CSS Regions] Elements in a region
should be assignable to a named flow" because of the performance regression in Parser/html5-full-render.html .
No new tests (because this is a rollout patch).
- dom/Element.cpp:
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/NodeRenderingContext.h:
- dom/PseudoElement.h:
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer):
- dom/Text.h:
- rendering/FlowThreadController.cpp:
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
LayoutTests:
- fast/regions/flow-body-in-html-expected.txt: Removed.
- fast/regions/flow-body-in-html.html: Removed.
- fast/regions/region-content-flown-into-region-expected.html: Removed.
- fast/regions/region-content-flown-into-region.html: Removed.
- fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
- fast/regions/universal-selector-children-to-the-same-region.html: Removed.
- 10:55 PM Changeset in webkit [147982] by
-
- 2 edits in trunk/Tools
Build fix. Can't remove appendCustomBuildFlags.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
- 10:35 PM Changeset in webkit [147981] by
-
- 4 edits in trunk/Tools
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990
Reviewed by Benjamin Poulain.
Removed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallGtkDependencies):
(RunUnitTests.start):
(RunWebKit2Tests.start):
(Factory.init):
(unitTestsSupported):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 9:53 PM Changeset in webkit [147980] by
-
- 1 edit2 deletes in trunk/Source/WTF
Remove WTF.gyp/WTF.gypi
https://bugs.webkit.org/show_bug.cgi?id=114237
Reviewed by Maciej Stachowiak.
- WTF.gyp: Removed.
- WTF.gyp/.gitignore: Removed.
- WTF.gyp/WTF.gyp: Removed.
- WTF.gypi: Removed.
- 8:23 PM FeatureFlags edited by
- (diff)
- 8:15 PM Changeset in webkit [147979] by
-
- 24 edits in trunk
Remove HTML Notification
https://bugs.webkit.org/show_bug.cgi?id=114231
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The feature is dead. It was only kept in the tree because of chromium.
- Configurations/FeatureDefines.xcconfig:
- Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/NotificationCenter.h:
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
- page/FeatureObserver.h:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- fast/notifications/notifications-with-permission-expected.txt:
- fast/notifications/notifications-with-permission.html:
- 8:09 PM Changeset in webkit [147978] by
-
- 2 edits in trunk/LayoutTests
[Mac][WebKit2] destroy-during-async-npp-new.html does not crash anymore
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
The test destroy-during-async-npp-new.html has not crashed in a long time. Re-enable
it to see how the bots like it.
- 8:08 PM FeatureFlags edited by
- (diff)
- 7:43 PM Changeset in webkit [147977] by
-
- 2 edits in trunk/Source/WebCore
Don't try to remove a non-existent snapshot
https://bugs.webkit.org/show_bug.cgi?id=114226
<rdar://problem/13604480>
Reviewed by Darin Adler.
We don't need to trigger the timer to remove a snapshot
if there was never a snapshot displayed.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Detect if we're moving from the DisplayingSnapshot state.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Guard against a missing renderer.
- 7:36 PM UnmaintainedFeatureList edited by
- Replaced the content by a hyperlink to … (diff)
- 7:36 PM FeatureFlags edited by
- Copied the rest of info from … (diff)
- 7:35 PM FeatureFlags edited by
- (diff)
- 7:34 PM UnmaintainedFeatureList edited by
- (diff)
- 7:32 PM FeatureFlags edited by
- Added grid layout (diff)
- 7:29 PM MaintainedFeatureList edited by
- Replaced the content with a link to FeatureFlags (diff)
- 7:28 PM FeatureFlags edited by
- Added the contributor list for CSS3_TEXT_LINE_BREAK (diff)
- 7:26 PM Changeset in webkit [147976] by
-
- 13 edits in trunk/Source/WTF
wtf/dtoa/* uses a confusing name to reference its buffers
https://bugs.webkit.org/show_bug.cgi?id=109709
Reviewed by Darin Adler.
The data structure Vector in wtf/dtoa has nothing to do with a traditional
vector, is it just a pointer and the length of the pointed buffer.
Rename it to BufferReference to avoid mistakes.
- wtf/dtoa/bignum-dtoa.cc:
- wtf/dtoa/bignum-dtoa.h:
- wtf/dtoa/bignum.cc:
- wtf/dtoa/bignum.h:
(Bignum):
- wtf/dtoa/double-conversion.cc:
- wtf/dtoa/fast-dtoa.cc:
- wtf/dtoa/fast-dtoa.h:
- wtf/dtoa/fixed-dtoa.cc:
- wtf/dtoa/fixed-dtoa.h:
(double_conversion):
- wtf/dtoa/strtod.cc:
- wtf/dtoa/strtod.h:
(double_conversion):
- wtf/dtoa/utils.h:
(double_conversion):
(WTF::double_conversion::BufferReference::BufferReference):
(WTF::double_conversion::BufferReference::SubBufferReference):
(StringBuilder):
- 7:12 PM UnmaintainedFeatureList edited by
- (diff)
- 6:45 PM Changeset in webkit [147975] by
-
- 2 edits in trunk/Source/WebCore
Do not define CAN_THEME_URL_ICON for PLATFORM(WIN_CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=108444
Reviewed by Darin Adler.
Image::loadPlatformResource("urlIcon") returns nothing
since r30961 on Windows which makes the code useless.
- loader/icon/IconDatabase.cpp:
- 6:40 PM Changeset in webkit [147974] by
-
- 9 edits in trunk/Source
Build fix.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
- WebKit.vcproj/WebKitExports.def.in:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:34 PM Changeset in webkit [147973] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPage: fix build due to type mismatches
https://bugs.webkit.org/show_bug.cgi?id=114148
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.
Add explicit conversions between LayoutUnit and int, and between
LayoutRect and IntRect.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rectForNode):
- 6:27 PM Changeset in webkit [147972] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
https://bugs.webkit.org/show_bug.cgi?id=112683
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.
After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.
The solution is to get rid of the macros defined in math.h and use
the real functions instead.
- wtf/MathExtras.h:
- 6:06 PM Changeset in webkit [147971] by
-
- 3 edits in trunk/LayoutTests
[Mac] Fix test expectations for ietestcenter/css3/grid/grid-items-003.htm
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations: The test pass on WebKit2 Mountain Lion Release builds.
- platform/mac/TestExpectations: The test is flaky on Mountain Lion Release builds.
- 5:50 PM Changeset in webkit [147970] by
-
- 3 edits in trunk/LayoutTests
[Mac][WebKit2] fast/css/sticky/sticky-top-zoomed.html is flaky on Mountain Lion
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
The test is flaky on MountainLion for WebKit1 and WebKit2. It fails systematically
in Debug or on older OS X.
- 5:46 PM UnmaintainedFeatureList edited by
- (diff)
- 5:45 PM Changeset in webkit [147969] by
-
- 15 edits in trunk/LayoutTests
Tests for exceptions of type DOMException.TYPE_ERR in encrypted-media-syntax.html are broken
https://bugs.webkit.org/show_bug.cgi?id=113119
Renames testException() to testDOMException() and tweaks the check.
Also adds a new testException() helper for checking non-DOM exceptions.
Patch by Steve Block <steveblock@chromium.org> on 2013-04-08
Reviewed by Darin Adler.
- media/encrypted-media/encrypted-media-not-loaded.html:
- media/encrypted-media/encrypted-media-syntax-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- media/media-fullscreen.js:
(buttonClickHandler):
(canplaythrough):
- media/track/track-add-remove-cue.html:
- media/track/track-addtrack-kind.html:
- media/track/track-cue-mutable.html:
- media/video-buffered.html:
- media/video-play-require-user-gesture.html:
- media/video-seek-no-src-exception.html:
- media/video-seekable.html:
- media/video-test.js:
(testDOMException):
- media/video-volume.html:
- 5:39 PM Changeset in webkit [147968] by
-
- 2 edits in trunk/LayoutTests
Skip async plugin test while fixing the failure.
https://bugs.webkit.org/show_bug.cgi?id=114217
- platform/mac-wk2/TestExpectations:
- 5:31 PM Changeset in webkit [147967] by
-
- 2 edits in trunk
Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349
Reviewed by Gustavo Noronha Silva.
- Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.
- 5:22 PM Changeset in webkit [147966] by
-
- 3 edits in trunk/Tools
Remove chromium EWS support, and fix broken test.
https://bugs.webkit.org/show_bug.cgi?id=114221
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractChromiumEWS): Removed.
(ChromiumLinuxEWS): Removed.
(ChromiumLinuxDebugEWS): Removed.
(ChromiumWindowsEWS): Removed.
(ChromiumAndroidEWS): Removed.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest): Fix misspelled class name.
(test_ewses): Fix entry point name to ensure test is run.
- 5:10 PM Changeset in webkit [147965] by
-
- 7 edits3 adds in trunk
DFG should be able to inline string equality comparisons
https://bugs.webkit.org/show_bug.cgi?id=114224
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Inline 8-bit string equality, go to slow path for 16-bit strings. 2x speed-up for string equality
comparisons on 8-bit strings. 20-50% speed-up on JSRegress/HashMap tests. 30% speed-up on
string-fasta. 2% speed-up on SunSpider overall. Some small speed-ups elsewhere.
This is a gnarly change but we have loads of test coverage already between the HashMap tests and
preexisting DFG string equality tests (which appear to have been designed to test OSR exits, but
also give us good overall coverage on string equality behavior).
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/regress/script-tests/string-equality.js: Added.
(foo):
- fast/js/regress/string-equality-expected.txt: Added.
- fast/js/regress/string-equality.html: Added.
- 4:59 PM Changeset in webkit [147964] by
-
- 2 edits in trunk/Source/WebKit2
Don't run primary plugin detection if plugin snapshotting is off
https://bugs.webkit.org/show_bug.cgi?id=114222
<rdar://problem/13603988>
Reviewed by Dean Jackson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- 4:55 PM FeatureFlags edited by
- Rename INPUT_TYPE_DATETIME to INPUT_TYPE_DATETIME_INCOMPLETE (diff)
- 4:53 PM Changeset in webkit [147963] by
-
- 4 edits15 deletes in trunk
[WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096
Reviewed by Anders Carlsson.
Source/WebKit2:
Remove conditional includes for the windows platform.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
Tools:
Remove the windows specific parts of the MiniBrowser.
- MiniBrowser/MiniBrowser.vcproj: Removed.
- MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
- MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
- MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
- MiniBrowser/win/BrowserView.cpp: Removed.
- MiniBrowser/win/BrowserView.h: Removed.
- MiniBrowser/win/BrowserWindow.cpp: Removed.
- MiniBrowser/win/BrowserWindow.h: Removed.
- MiniBrowser/win/MiniBrowser.cpp: Removed.
- MiniBrowser/win/MiniBrowser.h: Removed.
- MiniBrowser/win/MiniBrowser.rc: Removed.
- MiniBrowser/win/main.cpp: Removed.
- MiniBrowser/win/resource.h: Removed.
- MiniBrowser/win/stdafx.cpp: Removed.
- MiniBrowser/win/stdafx.h: Removed.
- 4:41 PM Changeset in webkit [147962] by
-
- 43 edits1 copy3 adds in trunk/Source
Stop #include-ing all of JavaScriptCore in every DOM-related file
https://bugs.webkit.org/show_bug.cgi?id=114220
Reviewed by Sam Weinig.
I separated WeakInlines.h from Weak.h so WebCore data types that need
to declare a Weak<T> data member don't have to #include all of the
infrastructure for accessing that data member.
This also required separating Weak<T> from PassWeak<T> by removing the
WeakImplAccessor class template and pushing code down into its subclasses.
- API/JSWeakObjectMapRefPrivate.cpp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/UnlinkedCodeBlock.h:
- heap/PassWeak.h:
(JSC):
(PassWeak):
(JSC::::PassWeak):
(JSC::::operator):
(JSC::::get):
- heap/SlotVisitorInlines.h:
- heap/Weak.h:
(JSC):
(Weak):
- heap/WeakInlines.h: Copied from Source/JavaScriptCore/heap/Weak.h.
(JSC):
(JSC::::Weak):
(JSC::::operator):
(JSC::::get):
(JSC::::was):
(JSC::weakClear):
- jit/JITThunks.h:
- runtime/RegExpCache.h:
- runtime/Structure.h:
- runtime/WeakGCMap.h:
../WebCore:
I separated ScriptWrappableInlines.h from ScriptWrappable.h so
WebCore data types that inherit from ScriptWrappable don't
have to #include all of the infrastructure for accessing that data member.
- ForwardingHeaders/heap/PassWeak.h: Added.
- ForwardingHeaders/heap/WeakInlines.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSDOMBinding.h:
(JSC):
- bindings/js/JSEventListener.h:
- bindings/js/JSMutationCallback.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptWrappable.h:
(JSC):
(WebCore):
(ScriptWrappable):
- bindings/js/ScriptWrappableInlines.h: Added.
(WebCore):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.h:
- bridge/runtime_root.cpp:
- bridge/runtime_root.h:
- css/StylePropertySet.cpp:
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- inspector/InspectorDebuggerAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- loader/cache/CachedSVGDocument.cpp:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):
../WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- 4:27 PM Changeset in webkit [147961] by
-
- 2 edits in trunk/LayoutTests
[Mac][WebKit2] The test images-enabled-unset-can-block-image-and-can-reload-in-place.html passes
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
This test have been passing reliably for many revisions and pass locally.
- 4:18 PM Changeset in webkit [147960] by
-
- 12 edits4 deletes in trunk
[BlackBerry] Update BlackBerry JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=114065
Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-08
Reviewed by Rob Buis.
.:
Internal PR 317350
Export JSC symbols in BlackBerry build.
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
Internal PR 317350
Remove obsolete files.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Internal PR 317350
Add new API for determining if user gesture is being processed.
Remove obsolete files.
Properly expose JSC global context.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(BlackBerry::WebKit::WebPage::globalContext):
(BlackBerry::WebKit::WebPage::isProcessingUserGesture):
(WebKit):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebCoreSupport/ClientExtension.cpp: Removed.
- WebCoreSupport/ClientExtension.h: Removed.
- WebCoreSupport/ExternalExtension.cpp: Removed.
- WebCoreSupport/ExternalExtension.h: Removed.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 4:01 PM Changeset in webkit [147959] by
-
- 2 edits in trunk/LayoutTests
Update the Mac WebKit2 TestExpectations for http/tests/canvas/canvas-slow-font-loading.html
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations: The test is flaky in release. Mark it as such.
- 4:01 PM WikiStart edited by
- Add links to new feature list pages. (diff)
- 3:56 PM MaintainedFeatureList created by
- 3:47 PM UnmaintainedFeatureList edited by
- (diff)
- 3:46 PM Changeset in webkit [147958] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Clean up render theme code.
https://bugs.webkit.org/show_bug.cgi?id=114216
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-08
Reviewed by Rob Buis.
BlackBerry PR 323062
Clean up redundant code.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- 3:19 PM Changeset in webkit [147957] by
-
- 2 edits in trunk/Tools
Use port 6665 instead of 6667 since the latter doesn't seem to work well.
- Scripts/webkitpy/common/config/irc.py:
- 3:05 PM Changeset in webkit [147956] by
-
- 14 edits5 adds in trunk
Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
https://bugs.webkit.org/show_bug.cgi?id=113139
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-08
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: plugins/npruntime/tostring.html
plugins/npruntime/valueof.html
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::~CInstance):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(Bindings):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::stringValue):
(JSC::Bindings::CInstance::booleanValue):
(JSC::Bindings::CInstance::valueOf):
(JSC::Bindings::CInstance::toJSPrimitive):
- bridge/c/c_instance.h:
(CInstance):
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
(ToStringAndValueOfObject):
(ToStringAndValueOfObject::ToStringAndValueOfObject):
(ScriptableObject):
(ToStringAndValueOfObject::ScriptableObject::hasMethod):
(ToStringAndValueOfObject::ScriptableObject::invoke):
(ToStringAndValueOfObject::ScriptableObject::pluginTest):
(ToStringAndValueOfObject::NPP_GetValue):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
LayoutTests:
- platform/qt-mac/TestExpectations:
- platform/wk2/TestExpectations:
- plugins/npruntime/tostring-expected.txt: Added.
- plugins/npruntime/tostring.html: Added.
- plugins/npruntime/valueof-expected.txt: Added.
- plugins/npruntime/valueof.html: Added.
- 2:43 PM Changeset in webkit [147955] by
-
- 4 edits in trunk
REGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when opening page in a background tab
https://bugs.webkit.org/show_bug.cgi?id=109935
<rdar://problem/13225963>
Reviewed by Brady Eidson.
Previously, we were deciding if a Page could go into
the PageCache by blacklisting certain load types. Instead,
whitelist the load types that we know can go into the cache,
so that newly-added load types are not cached unless
that is explicitly desired.
The crash occurs when a page which is actively loading
is put into the page cache while doing a redirect with
FrameLoadTypeRedirectWithLockedBackForwardList (note that
this is a redirect that was not covered in the blacklist),
and then promptly removed from the page cache, resulting
in resources from the redirect target (the now-active page)
being incorrectly destroyed.
No new tests, only known crash repro case is extremely
timing dependent (and only happens in WebKit2, with tiled
drawing, in background tabs).
- history/PageCache.cpp:
(WebCore::PageCache::canCache):
Adjust a test which depended on slow-redirects going
into the page cache (which will no longer happen)
to instead click on a link.
- fast/history/timed-refresh-in-cached-frame.html:
- 2:41 PM Changeset in webkit [147954] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::continueDidReceiveResponse):
- 2:31 PM Changeset in webkit [147953] by
-
- 3 edits in trunk/Source/WebKit2
Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217
Reviewed by Anders Carlsson.
The "Async initialization complete" messages probably don't have to be synchronous.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously): Notify of initialization success/failure asynchronously.
- WebProcess/Plugins/PluginProxy.messages.in:
- 2:24 PM Changeset in webkit [147952] by
-
- 11 edits in trunk/Source
Add an async version of ResourceHandle::didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=114215
Reviewed by Sam Weinig.
Source/WebCore:
In order to support converting NSURLConnections to NSURLDownloads when using the network process
we need an async version of didReceiveResponse.
- WebCore.exp.in:
- platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::didReceiveResponseAsync):
Just call continueDidReceiveResponse().
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::continueWillSendRequest):
Split up a single condition in two, making it easier to see which assertion fails.
(WebCore::ResourceHandle::continueDidReceiveResponse):
Call -[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse].
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
Split up a single condition in two, making it easier to see which assertion fails.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse]):
Signal the semaphore.
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
Call didReceiveResponseAsync on the main thread and wait on the semaphore.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Send the message and then call continueDidReceiveResponse.
- 2:07 PM Changeset in webkit [147951] by
-
- 2 edits in trunk
[GTK] Configure should verify ICU is installed on mingw
https://bugs.webkit.org/show_bug.cgi?id=113645
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-04-08
Reviewed by Gustavo Noronha Silva.
- Source/autotools/FindDependencies.m4: When falling back to hard-coded compiler flags
for ICU and mingw, check that headers do exist on the system and error out otherwise.
- 2:01 PM Changeset in webkit [147950] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 2:00 PM Changeset in webkit [147949] by
-
- 2 edits in trunk/Source/WebCore
Crash in ScrollingCoordinator::mainThreadScrollingReasons() when going back
https://bugs.webkit.org/show_bug.cgi?id=114214
-and corresponding-
<rdar://problem/13208616>
Reviewed by Anders Carlsson.
When a page is restoring from the page cache, the mainFrame can have a null
Document. So we should null-check the Document here.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
- 1:51 PM Changeset in webkit [147948] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 1:25 PM Changeset in webkit [147947] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make resolve more robust in the face of lookup misses
https://bugs.webkit.org/show_bug.cgi?id=114211
Reviewed by Filip Pizlo.
This simply short circuits the resolve operations in the
event that we don't find a path to a property. There's no
repro case for this happening unfortunately.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- 1:09 PM Changeset in webkit [147946] by
-
- 2 edits in trunk/Tools
[GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.
- 1:05 PM Changeset in webkit [147945] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] More null checks for m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=114172
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.
After r147744, some unit tests were crashing on WebPage
shutdown, because BackingStorePrivate::repaint() now uses
pixelContentsRect() (accessing m_webPage->contentsRect())
instead of BackingStoreClient::contentsRect(). In m_webPage,
m_mainFrame had already been set to 0.
Make us more robust against these errors by checking
the existence of m_mainFrame more diligently.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
(BlackBerry::WebKit::WebPagePrivate::contentsSize):
(BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
(BlackBerry::WebKit::WebPagePrivate::setViewMode):
- 12:50 PM UnmaintainedFeatureList edited by
- (diff)
- 12:35 PM Changeset in webkit [147944] by
-
- 3 edits in trunk/Tools
Remove my watchlist entries.
https://bugs.webkit.org/show_bug.cgi?id=114180
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 12:18 PM Changeset in webkit [147943] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening. Remove expected results added by r147824.
- platform/mac-future/accessibility/press-action-is-first-expected.txt: Removed.
- 12:10 PM Changeset in webkit [147942] by
-
- 9 edits4 adds2 deletes in trunk
Simplify ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=113517
Reviewed by Darin Adler.
The patch is based on the work made by Elliott Sprehn. He kindly agreed
for me to finalize the last bits and pieces of the fix.
Source/WebCore:
Simplify ContainerNode::removeChildren by merging the loops and removing
willRemoveChildren. This removes two traversals of the children, avoids
refing and derefing all the children once, avoids allocating a second
NodeVector of children, and means we detach() in the same order as
normal removal.
This does mean you can get into an infinite loop with DOMNodeRemoved
listeners by continously adding nodes but this is true in all other browsers
and the current behavior is bad because it means you don't get notified
of nodes added during removal (which other browsers do notify of). This
patch removes the containerNode.html test that originally tested for this
infinite loop and adds a new one that tests that all nodes get notified.
This makes PerformanceTests/Parser/innerHTML-setter.html 2-6% faster.
There's also a new test verifying ranges remain consistent if modified
inside an mutation event handler. Without the patch it's possible to create
a range with boundaries outside of the DOM tree.
Tests: fast/dom/Range/range-remove-children-event.html
fast/events/mutation-during-innerHTML.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
- dom/Document.h: nodeChildrenWillBeRemoved is not needed any more.
- dom/Range.cpp:
- dom/Range.h: nodeChildrenWillBeRemoved is not needed any more.
LayoutTests:
Remove containerNode.html test since it was checking for an infinite
loop when adding DOM nodes inside a DOMNodeRemoved mutation event
handler, but we actually do want to allow an infinite loop here for
correctness and compatability with other browsers.
Also added mutation-during-innerHTML which checks that all nodes
are notified of being removed even if they were added during the
DOMNodeRemoved notification.
There's a new test range-remove-children-event that verifies the
ranges modified inside a mutation event handler remain consistent.
- fast/dom/MutationObserver/added-out-of-order-expected.txt:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/Range/range-remove-children-event-expected.txt: Added.
- fast/dom/Range/range-remove-children-event.html: Added.
- fast/dom/containerNode-expected.txt: Removed.
- fast/dom/containerNode.html: Removed.
- fast/events/mutation-during-innerHTML-expected.txt: Added.
- fast/events/mutation-during-innerHTML.html: Added.
- 12:06 PM Changeset in webkit [147941] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 12:06 PM UnmaintainedFeatureList edited by
- (diff)
- 11:39 AM Changeset in webkit [147940] by
-
- 13 edits in trunk/Source/WebCore
Remove some #includes in headers in rendering code
https://bugs.webkit.org/show_bug.cgi?id=114079
Reviewed by Sam Weinig.
Clean up #includes in RenderObject, RenderLayer etc.
Moved makeMatrixRenderable() into RenderLayer.app, allowing
the removal of a TransformationMatrix.h include.
Make some RenderLayer functions that deal with filters not inline,
to avoid including RenderLayerFilterInfo.h.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ImageOrientation.cpp:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/transforms/AffineTransform.cpp:
- platform/graphics/transforms/AffineTransform.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderLayer.cpp:
(WebCore::makeMatrixRenderable):
(WebCore::RenderLayer::filterRenderer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.h:
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.h:
- 11:38 AM Changeset in webkit [147939] by
-
- 5 edits in trunk
Unreviewed, rolling out r147850.
http://trac.webkit.org/changeset/147850
https://bugs.webkit.org/show_bug.cgi?id=113706
Changeset crossed paths with 147505, which is the same fix.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 11:20 AM UnmaintainedFeatureList edited by
- (diff)
- 11:20 AM UnmaintainedFeatureList edited by
- Already in the list + not a problem. (diff)
- 11:17 AM Changeset in webkit [147938] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when processing a ping
https://bugs.webkit.org/show_bug.cgi?id=114178
Reviewed by Brady Eidson.
No test, I could never reproduce even manually.
Calling enqueueRawFrame() could change incoming buffer, so a subsequent skipBuffer()
would operate on wrong assumptions. This happened because enqueueRawFrame() actually
tried to process the queue, and send failure sometimed clears m_buffer.
Fixing this by decoupling enqueuing from sending, and making sure that skipBuffer()
in ping frame processing case is performed at a safe time.
- Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::startClosingHandshake): (WebCore::WebSocketChannel::processFrame): (WebCore::WebSocketChannel::enqueueTextFrame): (WebCore::WebSocketChannel::enqueueRawFrame): (WebCore::WebSocketChannel::enqueueBlobFrame):
- 11:09 AM Changeset in webkit [147937] by
-
- 17 edits10 deletes in trunk
REGRESSION (r147502): Animations of CA filters broken
https://bugs.webkit.org/show_bug.cgi?id=114067
Reviewed by Dean Jackson.
Revert r147502 [1] because it broke CA filter animations.
[1]: http://trac.webkit.org/changeset/147502
Source/WebCore:
- platform/graphics/IntRectExtent.h:
(WebCore::IntRectExtent::isZero):
(IntRectExtent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):
(WebCore):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Removed.
- css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Removed.
- css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Removed.
- css3/filters/composited-layer-bounds-with-composited-blur.html: Removed.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Removed.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Removed.
- css3/filters/filter-change-repaint-composited-expected.png:
- css3/filters/filter-change-repaint-composited.html:
- platform/qt/TestExpectations:
- 11:05 AM UnmaintainedFeatureList edited by
- (diff)
- 11:01 AM UnmaintainedFeatureList edited by
- (diff)
- 11:00 AM UnmaintainedFeatureList edited by
- (diff)
- 10:54 AM UnmaintainedFeatureList edited by
- (diff)
- 10:54 AM Changeset in webkit [147936] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Force horizontal list to be horizontal scrollable.
https://bugs.webkit.org/show_bug.cgi?id=114173
Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.
Force content to be horizontal/vertical overscrollable if it
scrolls in horizontal/vertical way.
PR 237440
Internally Reviewed by Arvid Nilsson.
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 10:53 AM UnmaintainedFeatureList edited by
- Added CSS Grid Layout to the list (diff)
- 10:52 AM Changeset in webkit [147935] by
-
- 4 edits in tags/Safari-537.35.10/Source
Versioning.
- 10:51 AM Changeset in webkit [147934] by
-
- 2 edits in trunk/Source/JavaScriptCore
Allow KeywordLookupGenerator.py to work on Windows with Windows style line endings
https://bugs.webkit.org/show_bug.cgi?id=63234
Patch by Justin Haygood <jhaygood@reaktix.com> on 2013-04-08
Reviewed by Oliver Hunt.
- KeywordLookupGenerator.py:
(parseKeywords):
- 10:48 AM Changeset in webkit [147933] by
-
- 4 edits in trunk
Source/JavaScriptCore: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129
<rdar://problem/13594898>
Reviewed by Darin Adler.
The check to see if we need a cell check when simplifying a GetById or PutById needs to be hoisted to
above where we abstractly execute the instruction, since after we abstracting execute it, it will
seem like it no longer needs the cell check.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
LayoutTests: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129 and https://bugs.webkit.org/show_bug.cgi?id=90649
<rdar://problem/13594898> and <rdar://problem/11815727>
Reviewed by Darin Adler.
Unskip these tests because they give us DFG coverage and they are now passing.
- platform/mac/TestExpectations:
- 10:46 AM Changeset in webkit [147932] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid "QFont::setPixelSize: Pixel size <= 0 (0)"
https://bugs.webkit.org/show_bug.cgi?id=114175
Reviewed by Allan Sandfeld Jensen.
QFont doesn't support a 0-size but WebCore does.
Leave our QFont in its default state in this case to avoid the warning.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 10:42 AM Changeset in webkit [147931] by
-
- 2 edits in tags/Safari-537.35.10/Source/WebCore
Merged r147806. <rdar://problem/13591653>
- 10:41 AM Changeset in webkit [147930] by
-
- 5 edits in trunk
Counter still gets incremented when counter-increment is set to none
https://bugs.webkit.org/show_bug.cgi?id=84985
Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-08
Reviewed by Darin Adler.
When the counter-increment is set to none, no counters are incremented.
Source/WebCore:
Tests: New test cases added in fast/css/counters/counter-increment-tests.htm
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyCounter::applyValue):
LayoutTests:
- fast/css/counters/counter-increment-tests-expected.txt: Added new test cases.
- fast/css/counters/counter-increment-tests.htm: Added new test cases.
- 10:37 AM Changeset in webkit [147929] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r147894): Broke WTFReportBacktrace() on Mac.
<http://webkit.org/b/114174>
Reviewed by Anders Carlsson.
An #elif !OS(ANDROID) block was erroneously removed, turn it into an #else instead since
that path will still be taken for OS(DARWIN).
- wtf/Assertions.cpp:
- 10:26 AM Changeset in webkit [147928] by
-
- 3 edits2 adds2 deletes in trunk
Crash in WebCore::ElementRuleCollector::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=113458
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-04-08
Reviewed by Darin Adler.
Source/WebCore:
A stylesheet which has been invalidated (type changed from "" or
"text/css") was not correctly removed from the list of active
style sheets when its children are changed.
This change releases StyleElement::m_sheet in advance of calling
DocumentStyleSheetCollection::updateActiveStyleSheets.
(StyleElement::clearSheet calls CSSStyleSheet::clearOwnerNode calls
CSSStyleSheet::didMutate calls Document::styleResolverChanged calls
DocumentStyleSheetCollection::updateActiveStyleSheets)
Test: fast/css/style-element-invalidation-crash.html
- dom/StyleElement.cpp:
(WebCore::StyleElement::clearSheet): Release m_sheet before we
trigger an update of the active style sheets.
LayoutTests:
- fast/css/style-element-invalidation-crash-expected.txt: Added.
- fast/css/style-element-invalidation-crash.html: Added.
- fast/css/stylesheet.innerHTML-calls-didmutate.html: Removed.
- fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Removed.
- 10:24 AM Changeset in webkit [147927] by
-
- 7 edits in trunk
[GTK] Build Platform as a separate static library
https://bugs.webkit.org/show_bug.cgi?id=114164
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Add webkit2platform_sources definition.
Source/WebKit2:
This way we reduce a bit the amount of files compiled twice
because of the plugin process.
- GNUmakefile.am:
- GNUmakefile.list.am:
- Platform/gtk/WorkQueueGtk.cpp: Remove unused header.
- Platform/unix/SharedMemoryUnix.cpp: Ditto.
- 10:23 AM Changeset in webkit [147926] by
-
- 3 edits in trunk/LayoutTests
Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
https://bugs.webkit.org/show_bug.cgi?id=104255
Updated test to match the one hosted by W3C which has corrected the reported error.
Reviewed by Eric Carlson.
- media/track/opera/interfaces/TextTrack/cues-expected.txt:
- media/track/opera/interfaces/TextTrack/cues.html:
- 10:22 AM Changeset in webkit [147925] by
-
- 8 edits in tags/Safari-537.35.10/Source
Merged r147659. <rdar://problem/13569460>
- 10:20 AM Changeset in webkit [147924] by
-
- 40 edits2 moves2 adds2 deletes in trunk/Source
[GTK] DOM objects created wrapping a base class have incorrect GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: Removed.
- bindings/gobject/WebKitDOMEventTarget.cpp:
(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.
- bindings/gobject/WebKitDOMEventTargetPrivate.h:
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.
(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):
- bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMObject.cpp:
- bindings/gobject/WebKitDOMPrivate.cpp: Added.
(WebKit):
(WebKit::wrap):
- bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
- bindings/scripts/CodeGeneratorGObject.pm:
(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:
(WebKit):
Source/WebKit/gtk:
Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp:
- webkit/webkithittestresult.cpp:
- 10:08 AM Changeset in webkit [147923] by
-
- 1 copy in tags/Safari-537.35.10
New Tag.
- 10:04 AM Changeset in webkit [147922] by
-
- 2 edits in trunk/Source/WebCore
Fix the build with strict GCC 4.8
Unreviewed build fix.
Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.
No new tests needed.
- page/DragController.cpp:
(WebCore::DragController::doImageDrag):
- 9:52 AM Changeset in webkit [147921] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Remove the unused LayoutTestSupport class
https://bugs.webkit.org/show_bug.cgi?id=114170
Reviewed by Alexey Proskuryakov.
The LayoutTestSupport class is not used by any port anywhere in the code and should be removed.
No new tests - no changes in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/LayoutTestSupport.cpp: Removed.
- platform/LayoutTestSupport.h: Removed.
- 9:51 AM Changeset in webkit [147920] by
-
- 11 edits1 delete in trunk/Source/WebCore
Remove WebCore::(enable|disable)SecureTextInput methods
https://bugs.webkit.org/show_bug.cgi?id=114126
Reviewed by Alexey Proskuryakov.
Remove the enableSecureTextInput and disableSecureTextInput methods and all the codepaths leading to them.
These were used only by the Chromium port and are as such not required anymore.
No new tests - no changes in functionality.
- GNUmakefile.list.am:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(Document):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
- editing/FrameSelection.h:
(FrameSelection):
- html/PasswordInputType.cpp:
- html/PasswordInputType.h:
(PasswordInputType):
- page/Frame.cpp:
(WebCore::Frame::setDocument):
- platform/SecureTextInput.h: Removed.
- 9:29 AM Changeset in webkit [147919] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; r147892 moved an export definition out of
a protective #ifdef, causing a link error on platforms which do
not define that method.
- WebCore.exp.in:
- 9:26 AM Changeset in webkit [147918] by
-
- 2 edits in trunk/Source/WTF
Build fix.
- 9:13 AM Changeset in webkit [147917] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Enable text tracks from track elements
https://bugs.webkit.org/show_bug.cgi?id=113522
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-08
Reviewed by Jocelyn Turcotte.
No new tests because they're already there. This just enables the feature.
- Target.pri:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):
- 9:05 AM Changeset in webkit [147916] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Toggle OverWrite mode when pressing the Insert key
https://bugs.webkit.org/show_bug.cgi?id=113384
Reviewed by Martin Robinson.
Perform an OverWrite command as a response to the emission of the
toggle-overwrite signal. Due to the nature of the command it will
only do that when being on a richly editable web content.
- platform/gtk/KeyBindingTranslator.cpp:
(WebCore::toggleOverwriteCallback):
- 8:30 AM Changeset in webkit [147915] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Provide more specific error description for SocketStreamError
https://bugs.webkit.org/show_bug.cgi?id=114134
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-08
Reviewed by Rob Buis.
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
- platform/network/blackberry/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::notifyStatusReceived):
- 8:26 AM Changeset in webkit [147914] by
-
- 3 edits5 adds in trunk
[GTK][EFL] HEAD requests changed to GET after 303 redirection
https://bugs.webkit.org/show_bug.cgi?id=110127
Patch by Youenn Fablet <youennf@gmail.com> on 2013-04-08
Reviewed by Martin Robinson.
Source/WebCore:
Made shouldRedirectAsGET always return false for HEAD requests.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::shouldRedirectAsGET):
LayoutTests:
Added tests checking HEAD redirection.
Redirected HEAD requests are expected to remain HEAD requests.
(http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)
- http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
- http/tests/xmlhttprequest/head-redirection.html: Added.
- http/tests/xmlhttprequest/resources/get_method.php: Added.
- http/tests/xmlhttprequest/resources/redirect_methods.php: Added.
- platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
- 7:49 AM Changeset in webkit [147913] by
-
- 9 edits in trunk/Source/WebKit2
[WK2][EFL] WebView: Add callbacks to the WKViewClient to remove direct access to page viewport controller
https://bugs.webkit.org/show_bug.cgi?id=110741
Reviewed by Anders Carlsson.
Provided WKViewClient with didRequestScroll, didRenderFrame and didCompletePageTransition
callbacks so that direct access from WebView to page viewport controller is avoided.
Implementation of callbacks is also added to keep the current EFL WK2 functionality.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
Moved here code from deleted WebView::didCommitLoad.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
- UIProcess/efl/WebViewClient.h:
(WebCore):
- 6:35 AM Changeset in webkit [147912] by
-
- 12 edits in trunk/Source/WebCore
DragImage should not depend on Frame and CachedImage
https://bugs.webkit.org/show_bug.cgi?id=21357
Reviewed by Sam Weinig.
Remove Frame and CachedImage dependencies from DragImage.
- dom/Clipboard.h:
(WebCore): Add forward delcaration for CacheImage since it's not
included anymore in DragImage.h.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Use
Frame::dragImageForSelection() and call
dissolveDragImageToFraction() for the returned DragImage. Pass the
font rendering mode to createDragImageForLink, instead of a Frame
that is only used to get the font rendering mode.
(WebCore::DragController::doImageDrag): Get the suggested filename
for the cached image and pass it to
createDragImageIconForCachedImageFilename().
- platform/DragImage.cpp:
(WebCore::createDragImageForLink): Receive a FontRenderingMode
instead of a Frame.
- platform/DragImage.h:
(WebCore): Remove createDragImageForSelection, change
createDragImageForLink to receive a FontRenderingMode instead of a
frame, and rename createDragImageIconForCachedImage as
createDragImageIconForCachedImageFilename since it nows received
the suggested filename of the cached image.
- platform/blackberry/DragImageBlackBerry.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
- platform/efl/DragImageEfl.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction): Return early if the passed
image is NULL.
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
(WebCore::createDragImageForLink): Ditto.
- platform/qt/DragImageQt.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
(WebCore::createDragImageForLink): Ditto.
- platform/wx/DragImageWx.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- 6:11 AM Changeset in webkit [147911] by
-
- 2 edits in trunk/Source/WebCore
[EFL] REGRESSION(r147743): Use the correct `operator new' override in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=114166
Reviewed by Alexis Menard.
r147743 disabled GLOBAL_FAST_MALLOC_NEW on the EFL port, but this has
caused some pixel tests in WK1 to crash.
The problem stems from RenderThemeEfl::applyEdjeRTLState() directly
calling `operator new(size_t)' for some allocations.
RefCounted<RenderTheme>, on its turn, has a WTF_MAKE_FAST_ALLOCATED
call which adds some `operator new' overrides to the class. Our direct
calls in applyEdjeRTLState() made the scope resolution rules choose the
WTF_MAKE_FAST_ALLOCATED version (which uses FastMalloc's allocator),
while WTF::deleteOwnedPtr() calls the global `operator delete' (which
uses the system's free() implementation).
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState): Explicitly choose the
global `operator new' when calling it.
- 5:57 AM Changeset in webkit [147910] by
-
- 2 edits in trunk/Source/WTF
Unreviewed trivial buildfix after r147799.
Add an ifdef guard to ensure Qt uses its own monotonicallyIncreasingTime()
implemenation instead of the GLIB based one.
- wtf/CurrentTime.cpp:
(WTF):
- 4:13 AM Changeset in webkit [147909] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] WebView's interactive property is not fully respected
https://bugs.webkit.org/show_bug.cgi?id=113066
Reviewed by Jocelyn Turcotte.
WK2 sign-off by Benjamin Poulain.
The QML WebView inherits the "interactive" property from Flickable
which is true by default, and disables the interaction with the
Flickable if set to false.
Resulting from the design of the WebView panning and flicking is
disabled by Flickable but to be consistent we also need to disable
double-tap gestures and pinch gestures since they would trigger
scale and position changes.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleDoubleTapEvent):
- 3:32 AM Changeset in webkit [147908] by
-
- 2 edits in trunk/Tools
[EFL] Mark ShouldGoToBackForwardListItem API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114161
Reviewed by Gyuyoung Kim.
Mark ShouldGoToBackForwardListItem API test as failing for EFL port
as it is crashing due to Bug 111074.
- TestWebKitAPI/PlatformEfl.cmake:
- 2:46 AM Changeset in webkit [147907] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Marked a few tests as failing.
- platform/efl/TestExpectations:
- 2:39 AM Changeset in webkit [147906] by
-
- 2 edits in trunk
Unreviewed GTK build fix.
- Source/autotools/symbols.filter: Exporting a bunch of symbols.
- 2:27 AM Changeset in webkit [147905] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPage: misc build fixes
https://bugs.webkit.org/show_bug.cgi?id=114152
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Carlos Garcia Campos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
(BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
Remove unused parameters.
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::blockZoom):
Replace TAAUTO with TASTART (this changed in r120495).
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
r142220).
(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
r113514).
- 2:27 AM Changeset in webkit [147904] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added after r147829.
- platform/qt/TestExpectations:
- 2:02 AM Changeset in webkit [147903] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/forms/select/popup-closes-on-blur.html as failing for EFL port.
- platform/efl/TestExpectations:
- 1:56 AM Changeset in webkit [147902] by
-
- 3 edits in trunk/LayoutTests
[EFL] Move some inspector tests to efl-wk1/TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=114147
Unreviewed EFL gardening.
Some inspector tests fail on only EFL-WK1 since it does not support plugins yet.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-08
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 1:54 AM Changeset in webkit [147901] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Skip fast/harness/use-page-cache.html for WK2 as WKTR does not support
overriding WebKitUsesPageCachePreferenceKey yet.
- platform/wk2/TestExpectations:
- 1:46 AM Changeset in webkit [147900] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark new accessibility test introduced in r147801 as failing for EFL.
- platform/efl/TestExpectations:
- 1:38 AM Changeset in webkit [147899] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several ref tests as failure for EFL port.
- platform/efl/TestExpectations:
- 1:28 AM UnmaintainedFeatureList edited by
- (diff)
- 1:26 AM Changeset in webkit [147898] by
-
- 5 edits in trunk/LayoutTests
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143
Unreviewed.
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/delete-ligature-003.html:
- editing/selection/context-menu-text-selection-expected.txt:
- editing/selection/context-menu-text-selection.html:
- 12:25 AM Changeset in webkit [147897] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] rendering was broken when scrolled ewk_view_single
https://bugs.webkit.org/show_bug.cgi?id=114135
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-04-08
Reviewed by Gyuyoung Kim.
ewk_view_single use memcpy() to copy previous buffer for scrolling, but
memcpy() should not be used when source buffer and destination buffer are
overwrapped.
- ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):
- 12:00 AM Styling Form Controls edited by
- (diff)
Apr 7, 2013:
- 11:53 PM Changeset in webkit [147896] by
-
- 19 edits in trunk/LayoutTests
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143
Patch by Christophe Dumez <Christophe Dumez> on 2013-04-07
Reviewed by Benjamin Poulain.
r147893 removed some Android code from WebCore but failed to update the
layout tests accordingly. This patch remove Android-specific tests from
several editing layout tests.
- editing/deleting/paragraph-in-preserveNewline-expected.txt:
- editing/deleting/paragraph-in-preserveNewline.html:
- editing/deleting/whitespace-pre-1-expected.txt:
- editing/deleting/whitespace-pre-1.html:
- editing/execCommand/script-tests/toggle-compound-styles.js:
- editing/execCommand/toggle-compound-styles-expected.txt:
- editing/selection/5354455-1-expected.txt:
- editing/selection/5354455-1.html:
- editing/selection/click-in-margins-inside-editable-div-expected.txt:
- editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
- editing/selection/extend-after-mouse-selection-expected.txt:
- editing/selection/extend-after-mouse-selection.html:
- editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
- editing/selection/programmatic-selection-on-mac-is-directionless.html:
- editing/selection/script-tests/click-in-margins-inside-editable-div.js:
- editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
- 11:31 PM Changeset in webkit [147895] by
-
- 2 edits in trunk
Modify .gitignore file to remove entries for chromium generated files
https://bugs.webkit.org/show_bug.cgi?id=114141
Reviewed by Gyuyoung Kim.
- .gitignore:
- 11:20 PM Changeset in webkit [147894] by
-
- 6 edits in trunk/Source/WTF
Remove the android code from WebKit Template Framework
https://bugs.webkit.org/show_bug.cgi?id=114138
Reviewed by Dirk Schulze.
- wtf/Assertions.cpp:
- wtf/Atomics.h:
- wtf/MathExtras.h:
- wtf/Platform.h:
- wtf/ThreadIdentifierDataPthreads.cpp:
- 9:20 PM Changeset in webkit [147893] by
-
- 11 edits in trunk/Source/WebCore
Remove the android code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114136
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- dom/ViewportArguments.cpp:
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
- editing/EditingBehaviorTypes.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongTap):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
- page/Settings.cpp:
(WebCore):
(WebCore::editingBehaviorTypeForPlatform):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::getRenderStyleForStrike):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEditingBehavior):
- 9:14 PM Changeset in webkit [147892] by
-
- 32 edits in trunk/Source
Add bounds checking for WTF::Vector::operator[]
https://bugs.webkit.org/show_bug.cgi?id=89600
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Make a few JSC classes opt-out of release mode bounds checking.
- assembler/AssemblerBuffer.h:
(AssemblerBuffer):
- assembler/AssemblerBufferWithConstantPool.h:
(AssemblerBufferWithConstantPool):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::bytecodeOffset):
(JSC):
(JSC::replaceExistingEntries):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
(JSC::CodeBlock::callReturnIndexVector):
(JSC::CodeBlock::codeOrigins):
(RareData):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedEvalCodeBlock::adoptVariables):
(UnlinkedEvalCodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/BytecodeGenerator.h:
(CallArguments):
(JSC::BytecodeGenerator::instructions):
(BytecodeGenerator):
- bytecompiler/StaticPropertyAnalysis.h:
(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis):
(StaticPropertyAnalysis):
- bytecompiler/StaticPropertyAnalyzer.h:
(StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::StaticPropertyAnalyzer):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- parser/ASTBuilder.h:
(ASTBuilder):
- runtime/ArgList.h:
(MarkedArgumentBuffer):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
Source/WebCore:
Fix exports
- WebCore.exp.in:
Source/WTF:
Add a template parameter to Vector<> that controls whether
bounds checking is performed in release builds or not.
Defaults to crashing on overflow.
- wtf/Forward.h:
(WTF):
- wtf/Vector.h:
(WTF):
(Vector):
(WTF::Vector::at):
(WTF::Vector::removeLast):
(WTF::::Vector):
(WTF::=):
(WTF::::contains):
(WTF::::find):
(WTF::::reverseFind):
(WTF::::fill):
(WTF::::appendRange):
(WTF::::expandCapacity):
(WTF::::tryExpandCapacity):
(WTF::::resize):
(WTF::::shrink):
(WTF::::grow):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::append):
(WTF::::tryAppend):
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):
(WTF::::appendVector):
(WTF::::insert):
(WTF::::prepend):
(WTF::::remove):
(WTF::::reverse):
(WTF::::releaseBuffer):
(WTF::::checkConsistency):
(WTF::deleteAllValues):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
- 9:10 PM Changeset in webkit [147891] by
-
- 3 edits in trunk/LayoutTests
Remove the android part of editing/selection/rtl-move-selection-right-left.html
https://bugs.webkit.org/show_bug.cgi?id=114137
Reviewed by Anders Carlsson.
- editing/selection/rtl-move-selection-right-left-expected.txt:
- editing/selection/rtl-move-selection-right-left.html:
- 8:16 PM UnmaintainedFeatureList edited by
- (diff)
- 7:55 PM UnmaintainedFeatureList edited by
- (diff)
- 7:03 PM UnmaintainedFeatureList edited by
- (diff)
- 6:38 PM UnmaintainedFeatureList created by
- 6:09 PM Changeset in webkit [147890] by
-
- 3 edits in trunk/Websites/webkit.org
Simplify the page "Getting the Code" on WebKit.org
https://bugs.webkit.org/show_bug.cgi?id=113980
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-07
Reviewed by Sam Weinig.
- building/checkout.html:
Instead of interleaving instructions for Mac and Windows, just
copy the things that make sense and have two clear sections.
Also mention Linux, it is the exact same instructions as Mac OS X.
Make svn checkout the alternative to a download of the tarball. It is
almost impossible to do a svn checkout on slow networks nowadays.
- 6:01 PM Changeset in webkit [147889] by
-
- 2 edits in trunk/Source/WebCore
Do not allocate static AtomicStrings when searching for alternate font names
https://bugs.webkit.org/show_bug.cgi?id=114110
Reviewed by Geoffrey Garen.
FontCache's alternateFamilyName does some font name substitutions
when a font is not found for a given name.
In the vast majority of cases, no substitutions are made and
alternateFamilyName returns the null atom.
Given the usage the function had a couple of problems:
-It created 6 static AtomicString.
-It did a case insensitive comparison with 6 differents strings
before failing.
This patch aims at solving both issues.
Instead of creating all AtomicString statically, the alternate name
are simply created on the fly as needed. Because the operation is so
unfrequent, and it uses the fast constructor, doing so should not slow
down the function.
To avoid comparing the input to every string, every time, the length of
the input is first evaluated, and we only do the necessary string comparisons.
On x86_64, this reduces the binary size by 2128 bytes.
- platform/graphics/FontCache.cpp:
(WebCore::familyNameEqualIgnoringCase):
When comparing strings, we know:
-The family name is non null.
-The length of both strings is equal.
-The length is not null.
Make the comparison accordingly.
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
- 5:52 PM Changeset in webkit [147888] by
-
- 77 edits1 delete in trunk/Source/WebCore
Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114081
Remove the remaining PLATFORM(CHROMIUM) build guards. There are still a couple of guards
that most likely apply only to Chromium, like OS(ANDROID) or USE(SKIA_ON_MAC_CHROMIUM),
but removal of these should go into separate patches.
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-07
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- config.h:
- history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::shouldAccelerate):
- html/HTMLCanvasElement.h:
- html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):
- html/HTMLSelectElement.cpp:
(WebCore):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- html/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
- html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::platformLayer):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didBeginFrame):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::notifyFinished):
- page/FeatureObserver.cpp:
(WebCore::FeatureObserver::~FeatureObserver):
- platform/AsyncFileSystem.cpp:
(WebCore):
- platform/ContextMenu.h:
(ContextMenu):
- platform/ContextMenuItem.h:
- platform/Cursor.h:
- platform/DragData.cpp:
(WebCore):
- platform/DragData.h:
- platform/DragImage.h:
- platform/LocalizedStrings.h:
(WebCore):
- platform/Pasteboard.h:
(Pasteboard):
- platform/PlatformExportMacros.h:
- platform/PlatformInstrumentation.h:
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):
- platform/PlatformMenuDescription.h:
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizer):
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):
- platform/ScrollAnimator.cpp:
(WebCore):
(WebCore::ScrollAnimator::handleWheelEvent):
- platform/ScrollAnimator.h:
(ScrollAnimator):
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateOverhangAreas):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):
- platform/Scrollbar.cpp:
- platform/SecureTextInput.cpp: Removed.
- platform/SecureTextInput.h:
(WebCore):
- platform/SuddenTermination.h:
(WebCore):
- platform/Widget.h:
(Widget):
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/FloatPoint.h:
(FloatPoint):
- platform/graphics/FloatRect.h:
(FloatRect):
- platform/graphics/FloatSize.h:
(FloatSize):
- platform/graphics/Font.cpp:
(WebCore):
(WebCore::Font::width):
- platform/graphics/Font.h:
(Font):
- platform/graphics/FontCache.cpp:
(WebCore):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/FontDescription.h:
- platform/graphics/FontPlatformData.cpp:
- platform/graphics/GlyphBuffer.h:
(WebCore):
(WebCore::GlyphBuffer::add):
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::supportsBackgroundColorContent):
- platform/graphics/Icon.h:
(Icon):
- platform/graphics/ImageSource.cpp:
- platform/graphics/ImageSource.h:
(WebCore):
- platform/graphics/IntRect.h:
(IntRect):
(WebCore):
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/PlatformLayer.h:
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(DerivedFontData):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::resizeContext):
- platform/graphics/gpu/DrawingBuffer.h:
(WebCore):
(DrawingBuffer):
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
- platform/image-decoders/ImageDecoder.h:
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
- platform/network/BlobRegistry.cpp:
(WebCore::blobRegistry):
- platform/network/BlobRegistryImpl.cpp:
- platform/network/NetworkStateNotifier.cpp:
- platform/network/NetworkStateNotifier.h:
(NetworkStateNotifier):
- platform/network/NetworkingContext.h:
(NetworkingContext):
- platform/network/ResourceHandleClient.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore):
- platform/text/cf/HyphenationCF.cpp:
- plugins/PluginViewNone.cpp:
(WebCore):
- testing/Internals.cpp:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
- 5:43 PM Changeset in webkit [147887] by
-
- 5 edits in trunk/Source/JavaScriptCore
Use Vector::reserveInitialCapacity() when possible in JavaScriptCore runtime
https://bugs.webkit.org/show_bug.cgi?id=114111
Reviewed by Andreas Kling.
Almost all the code was already using Vector::reserveInitialCapacity()
and Vector::uncheckedAppend(). Fix the remaining parts.
- runtime/ArgList.h:
(MarkedArgumentBuffer): The type VectorType is unused.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
Move the variable closer to where it is needed.
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyNames):
- 4:56 PM Changeset in webkit [147886] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=113902
Unreviewed.
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
- platform/efl/DefaultTheme/CMakeLists.txt:
Put possibly empty variable after non-empty to avoid space
at the beginning of string parameter
- 4:41 PM Changeset in webkit [147885] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] --minimal build fails with error: expected
;' beforereturn'
https://bugs.webkit.org/show_bug.cgi?id=113953
Unreviewed.
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
- ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_quota_get): Added missing semicolon.
- 4:00 PM Changeset in webkit [147884] by
-
- 2 edits in trunk/Source/WTF
[WIN] Fix problems with export macros of AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=114132
Reviewed by Geoffrey Garen.
Exporting an inline function results in an error with the MS compiler.
- wtf/AutodrainedPool.h:
(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):
- 3:18 PM Changeset in webkit [147883] by
-
- 5 edits4 deletes in trunk/Source/WebCore
Add default implementation for KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=108326
Reviewed by Benjamin Poulain.
The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- platform/KURL.cpp:
(WebCore):
(WebCore::KURL::fileSystemPath):
- platform/blackberry/KURLBlackBerry.cpp: Removed.
- platform/efl/KURLEfl.cpp: Removed.
- platform/wince/KURLWinCE.cpp: Removed.
- platform/wx/KURLWx.cpp: Removed.
- 3:09 PM Changeset in webkit [147882] by
-
- 2 edits in trunk/Source/WTF
[WinCE] Add workaround for UNUSED_PARAM()
https://bugs.webkit.org/show_bug.cgi?id=113440
Reviewed by Benjamin Poulain.
The MSVC compiler for Windwos CE throws an error when
an function parameter is passed to UNUSED_PARAM() and
its type is only forward declared.
- wtf/UnusedParam.h:
- 3:08 PM Changeset in webkit [147881] by
-
- 2 edits in trunk/Source/WTF
Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
https://bugs.webkit.org/show_bug.cgi?id=114127
Reviewed by Benjamin Poulain.
Platform.h defines WTF_ARM_ARCH_VERSION for CPU(ARM) always and removing
the check works around a bug in older Microsoft compiler versions.
- wtf/Platform.h:
- 2:28 PM Changeset in webkit [147880] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Marked another webaudio test as flaky.
- platform/efl/TestExpectations:
- 2:19 PM Changeset in webkit [147879] by
-
- 9 edits in trunk
Remove references to Skia and V8 from CMake files
https://bugs.webkit.org/show_bug.cgi?id=114130
Reviewed by Geoffrey Garen.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitPackaging.cmake:
Source/JavaScriptCore:
- shell/PlatformBlackBerry.cmake:
Source/WebCore:
- PlatformBlackBerry.cmake:
Source/WebKit:
- PlatformBlackBerry.cmake:
- 1:56 PM Changeset in webkit [147878] by
-
- 21 edits in trunk
Remove the rest of SVG_DOM_OBJC_BINDINGS
<http://webkit.org/b/114112>
Reviewed by Geoffrey Garen.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS. Note that DOMHTMLIFrameElementPrivate.h should not have been in this list because the class contained methods other than just -getSVGDocument.
- WebCore.xcodeproj/project.pbxproj:
- Remove DOMHTMLFrameElementPrivate.h since the only method it contained was -[DOMHTMLFrameElement getSVGDocument], which was part of the SVG DOM Objective-C bindings.
- bindings/objc/DOM.mm:
(kitClass):
- bindings/objc/DOMEvents.mm:
(kitClass):
- bindings/objc/ExceptionHandlers.mm:
(WebCore::raiseDOMException):
- Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
- Remove reference to SVG_DOM_OBJC_BINDINGS.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Source/WTF:
- wtf/FeatureDefines.h:
- Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.
Tools:
- Scripts/webkitperl/FeatureList.pm:
- Remove --svg-dom-objc-bindings switch.
- qmake/mkspecs/features/features.pri:
- Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
- 1:27 PM Changeset in webkit [147877] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening.
Rebaseline several test cases that have line number information after r147872.
- http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt:
- http/tests/security/window-onerror-exception-in-iframe-expected.txt:
- inspector/console/alert-toString-exception-expected.txt:
- storage/indexeddb/exception-in-event-aborts-expected.txt:
- storage/websql/sql-error-codes-expected.txt:
- storage/websql/statement-error-callback-expected.txt:
- storage/websql/transaction-callback-exception-crash-expected.txt:
- 1:02 PM Changeset in webkit [147876] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip a few test failing due to missing Quota API support.
- platform/efl/TestExpectations:
- 12:55 PM Changeset in webkit [147875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark a few tests as crashing on EFL port.
- platform/efl/TestExpectations:
- 12:38 PM Changeset in webkit [147874] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Generate missing baselines.
- platform/efl/editing/pasteboard/paste-text-004-expected.png: Added.
- platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
- platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
- platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
- platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
- 12:30 PM Changeset in webkit [147873] by
-
- 8 edits1 add in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several test cases.
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/efl/fast/forms/datalist/input-list-expected.txt:
- platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
- platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
- platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- platform/efl/fast/js/global-constructors-expected.txt:
- platform/efl/http/tests/inspector/console-websocket-error-expected.txt:
- 11:47 AM Changeset in webkit [147872] by
-
- 17 edits in trunk
Inspector should display information about non-object exceptions
https://bugs.webkit.org/show_bug.cgi?id=114123
Reviewed by Adele Peterson.
Source/JavaScriptCore:
Make sure we store the right stack information, even when throwing
a primitive.
- interpreter/CallFrame.h:
(JSC::ExecState::clearSupplementaryExceptionInfo):
(ExecState):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):
Source/WebCore:
Make use of the stack trace for line information when we're reporting
an exception
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
LayoutTests:
All these tests throw primitives as exceptions, and now they have source
and line number information
- fast/dom/exception-getting-event-handler-expected.txt:
- fast/dom/javascript-url-exception-isolation-expected.txt:
- fast/dom/nested-script-exceptions-expected.txt:
- fast/events/onerror-no-constructor-expected.txt:
- fast/events/window-onerror13-expected.txt:
- fast/events/window-onerror16-expected.txt:
- fast/events/window-onerror2-expected.txt:
- fast/events/window-onerror8-expected.txt:
- fast/js/uncaught-exception-line-number-expected.txt:
- fast/sub-pixel/inline-block-with-padding-expected.txt:
- platform/mac/fast/AppleScript/001-expected.txt:
- 11:37 AM Changeset in webkit [147871] by
-
- 3 edits2 adds in trunk
table element may get larger when its contents are recreated
https://bugs.webkit.org/show_bug.cgi?id=111342
Reviewed by Darin Adler.
Source/WebCore:
Remove anonymous table section wrappers when destroying their children.
Test: fast/table/anonymous-table-section-removed.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
LayoutTests:
- fast/table/anonymous-table-section-removed-expected.txt: Added.
- fast/table/anonymous-table-section-removed.html: Added.
- 11:31 AM Changeset in webkit [147870] by
-
- 3 edits in trunk/Source/WebCore
[WIN] Fix build without precompiled header after r145827.
- platform/ContextMenuItem.h:
- platform/PlatformMenuDescription.h:
- 11:30 AM Changeset in webkit [147869] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation of LocaleWin with !ENABLE(CALENDAR_PICKER) && !ENABLE(DATE_AND_TIME_INPUT_TYPES)
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::ensureShortMonthLabels):
(WebCore):
(WebCore::LocaleWin::ensureMonthLabels):
- 10:07 AM Changeset in webkit [147868] by
-
- 3 edits in trunk/Source/WebCore
[WIN] Fix build without precompiled header after r144216.
- platform/network/cf/FormDataStreamCFNet.h:
- platform/network/mac/FormDataStreamMac.h:
- 9:42 AM Changeset in webkit [147867] by
-
- 8 edits in trunk
Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.
Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
- editing/FrameSelection.h:
(WebCore):
Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.
Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
- DumpRenderTree/AccessibilityController.cpp:
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::DumpRenderTreeChrome):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
