Timeline
Apr 9, 2013:
- 11:59 PM Changeset in webkit [148079] by
-
- 3 edits3 adds in trunk
[GStreamer] playbin uri getter is invalid
https://bugs.webkit.org/show_bug.cgi?id=113884
Reviewed by Martin Robinson.
Source/WebCore:
When loading a new media location use the url stored as a member
variable instead of the one stored as a playbin property. The uri
property semantic changed in playbin since 0.10.36+. One should
now use current-uri but to avoid ifdefs depending on GStreamer
version we simply use the url already known as member variable.
Test: http/tests/media/video-redirect.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
LayoutTests:
New test for Quicktime reference movie redirect
support.
- http/tests/media/resources/redirect-to-counting-captioned.mov: Added.
- http/tests/media/video-redirect-expected.txt: Added.
- http/tests/media/video-redirect.html: Added.
- 11:45 PM Changeset in webkit [148078] by
-
- 2 edits in trunk/Source/WebKit2
WKFrameIsDisplayingMarkupDocument should return true for Web Archives
https://bugs.webkit.org/show_bug.cgi?id=114291
Reviewed by Dean Jackson.
Also return true for the Web Archive MIME type since a Web Archive
is displaying a markup document by nature.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):
- 10:21 PM Changeset in webkit [148077] by
-
- 2 edits in trunk/Tools
Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
Unreviewed.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
- 10:12 PM Changeset in webkit [148076] by
-
- 12 edits in trunk
[JSC] Script run from an isolated world should bypass a page's CSP
https://bugs.webkit.org/show_bug.cgi?id=100815
Reviewed by Oliver Hunt.
Source/WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptController.h: Test the current caller's DOM wrapper
world to decide whether CSP should be enforced.
Like most of CSP, this is a stupid policy because it doesn't address
second-order effects like <script> parsing or event handler execution,
which might be triggered indirectly by privileged scripts. These indirect
effects are still broken. Oh well.
LayoutTests:
Enabled these tests, now that they pass.
I removed all the nonsense in these tests about setting an isolated world's
CSP and origin manually, since we have no use for those features.
- http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
- http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html:
- http/tests/security/isolatedWorld/bypass-main-world-csp.html:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 9:59 PM Changeset in webkit [148075] by
-
- 11 edits11 deletes in trunk/Tools
[webkitpy] Remove chromium ports.
https://bugs.webkit.org/show_bug.cgi?id=114326
Reviewed by Dirk Pranke.
As a side effect, also:
- remove chromium builders from webkitpy.layout_tests.port.builders
- remove chromium builders from rebaseline
- rewrite chromium dependent tests in rebaseline_unittest
- remove chromium platform from garden-o-matic
- select apple platform as default platform in garden-o-matic
- remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_efl):
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):
(BaselineOptimizerTest.test_virtual_ports_filtered):
- Scripts/webkitpy/layout_tests/port/builders.py:
- Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
- Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory):
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.test_qt):
(FactoryTest.test_get_from_builder_name):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._builders_to_pull_from):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase):
(_BaseTestCase.setUp):
(TestRebaselineTest.setUp):
(TestRebaselineTest.test_baseline_directory):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(TestRebaselineExpectations.test_rebaseline_expectations):
- 6:59 PM Changeset in webkit [148074] by
-
- 2 edits in trunk/Source/WebCore
Remove chromium exceptions from WebCore's gitattributes
https://bugs.webkit.org/show_bug.cgi?id=114327
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.
- .gitattributes:
- 6:23 PM Changeset in webkit [148073] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318
Reviewed by Geoffrey Garen.
Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.
- API/APICast.h:
(toJS):
(toJSForGC):
(unsafeToJS):
- API/JSObjectRef.cpp:
(JSObjectGetPrivate):
- 6:11 PM Changeset in webkit [148072] by
-
- 3 edits2 adds in trunk
Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322
Reviewed by Darin Adler.
Source/WebCore:
Without this, moving a Node between documents can silently deactivate
an event listener, if it's one of the types that whose creation is
optimized away by Document::hasListenerType.
An alternate approach would be to simply copy the old document's
bitfield over. It's a tradeoff between making adoption fast and making
the operation of any operation depending on these event types fast.
The latter seems like the right optimization given that adoption
doesn't happen very often.
Test: fast/events/event-listener-moving-documents.html
- dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.
LayoutTests:
- fast/events/event-listener-moving-documents-expected.txt: Added.
- fast/events/event-listener-moving-documents.html: Added.
- 5:57 PM Changeset in webkit [148071] by
-
- 5 edits in trunk/Source/WebCore
Add logging channel for animations
https://bugs.webkit.org/show_bug.cgi?id=114325
Reviewed by Simon Fraser.
- platform/Logging.cpp: Add LogAnimations.
(WebCore::getChannelFromName): Return LogAnimations for "Animations".
- platform/Logging.h: Add LogAnimations.
- platform/mac/LoggingMac.mm:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
- platform/win/LoggingWin.cpp:
(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.
- 5:32 PM Changeset in webkit [148070] by
-
- 18 edits9 adds in trunk
[CSS3] Parsing the property, text-justify.
https://bugs.webkit.org/show_bug.cgi?id=100058
Reviewed by Andreas Kling.
This patch implements the parsing side of the "text-justify" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-justify
Source/WebCore:
Tests: fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html
fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StylePropertySet.cpp:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Added.
- fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
- fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
- platform/mac/TestExpectations: ditto
- platform/qt-4.8/TestExpectations: ditto
- platform/qt-mac/TestExpectations: ditto
- platform/qt/TestExpectations: ditto
- 5:17 PM Changeset in webkit [148069] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Adding contentsLayer for image and video
https://bugs.webkit.org/show_bug.cgi?id=113912
Reviewed by Gustavo Noronha Silva.
contentsLayer is a ClutterActor, which is added to the main layer
as a child when GraphicsLayer needs to render an image or video.
No new tests, already covered by existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore):
(WebCore::GraphicsLayerClutter::setContentsToImage): Pass a Cairo surface to GraphicsLayer.
(WebCore::GraphicsLayerClutter::setContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::setContentsRect):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateContentsImage): Set the Cairo surface for contentsLayer
to upload it as a texture.
(WebCore::GraphicsLayerClutter::updateContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::updateContentsRect):
(WebCore::GraphicsLayerClutter::updateSublayerList):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore::GraphicsLayerClutter::hasContentsLayer):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::contentsLayer):
- 5:04 PM Changeset in webkit [148068] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Blob URLs broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=114320
Reviewed by Brady Eidson.
Update BlobResourceHandle to use modern resource client calls.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::readSync): Don't call notifyReceiveData if there is no data (it's especially egregious when length is -1, signaling an error). (WebCore::BlobResourceHandle::notifyResponseOnSuccess): Use didReceiveResponseAsync when a client wants async callbacks. This is not very clean, as we don't wait for response, but should be workable for blobs. (WebCore::BlobResourceHandle::notifyResponseOnError): Ditto. (WebCore::BlobResourceHandle::notifyReceiveData): Use didReceiveBuffer (clients that only implement didReceiveData will have it automatically unwrapped).
- 5:03 PM Changeset in webkit [148067] by
-
- 2 edits in trunk/Source/JavaScriptCore
Rollout last patch as it destroyed everything
- 5:00 PM Changeset in webkit [148066] by
-
- 2 edits in trunk/LayoutTests
r148048 revealed that compositing/plugins/invalidate_rect.html was
only succeeded through chance, and cannot work as designed because
plugin painting is async on some platforms. Mark it as flakey.
- platform/mac/TestExpectations:
- 4:57 PM Changeset in webkit [148065] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r123837): Full screen transition is broken at apple.com
https://bugs.webkit.org/show_bug.cgi?id=95650
Reviewed by Simon Fraser.
Cancel any outstanding animations on <video> elements as they enter full screen, so as to
not confuse the WebKit/WebKit2 full screen window animation about the starting and destination
screen rects.
- css/fullscreen.css:
(video:-webkit-full-screen, audio:-webkit-full-screen):
- 4:52 PM Changeset in webkit [148064] by
-
- 3 edits in trunk/Source/WebCore
hang in mediaSelectionGroupForMediaCharacteristic
https://bugs.webkit.org/show_bug.cgi?id=114054
Reviewed by Eric Carlson.
No new tests; Fixes sporadic hangs in media/ tests.
-[AVURLAsset mediaSelectionGroupForMediaCharacteristic:] can deadlock in certain situations: When AVURLAsset
posts a synchronous AVAssetResourceLoader notification to the main thread, calling -mediaSelectionGroupForMediaCharacteristic:
on the main thread requires IO to occur if the media characteristics are not yet loaded. Instead of blocking,
bail out early if the media characteristics are not yet known.
Add a new method, safeMediaSelectionGroupForLegibleMedia(), which first checks selection group availability
before calling mediaSelectionGroupForMediaCharacteristic:.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(MediaPlayerPrivateAVFoundationObjC):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Use new safe method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
- 4:29 PM Changeset in webkit [148063] by
-
- 3 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix for iOS.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- 4:28 PM Changeset in webkit [148062] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318
Reviewed by Filip Pizlo.
Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.
- API/APICast.h:
(toJS):
(toJSForGC):
- 4:22 PM Changeset in webkit [148061] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed correctness fix: use lroundf instead of lround for a float to int conversion.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
- 4:04 PM Changeset in webkit [148060] by
-
- 2 edits in trunk/Source/WebCore
Change requisite hardware checks for enabling antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=114101
<rdar://problem/12342776>.
m_maySupportMultisampling should be true by default for all platforms/hardware now except older versions of AMD.
Reviewed by Dean Jackson.
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
- 3:55 PM Changeset in webkit [148059] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r148010.
http://trac.webkit.org/changeset/148010
https://bugs.webkit.org/show_bug.cgi?id=114310
Causes problems with focus rings (Requested by anttik on
#webkit).
Source/WebCore:
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
LayoutTests:
- fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Removed.
- fast/borders/border-width-less-then-a-unit-of-pt.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 3:52 PM Changeset in webkit [148058] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, another fix for the Windows build after r148050.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::setFontSize): Use lround().
- 3:37 PM Changeset in webkit [148057] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests affected by r148049 or r148048.
- compositing/layer-creation/rotate3d-overlap-expected.txt:
- compositing/repaint/resize-repaint-expected.txt:
- compositing/repaint/resize-repaint.html: Allow the test to run
outside WTR/DRT.
- 3:31 PM Changeset in webkit [148056] by
-
- 5 edits2 adds in trunk
[CSS Exclusions] Properly position multiple stacked floats with non rectangular shape outside
https://bugs.webkit.org/show_bug.cgi?id=110372
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-09
Reviewed by Dean Jackson.
Source/WebCore:
Stacked floats get positioned based on the bounding box of the shape,
not on the shape contours itself. This patch causes that to happen.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Use the
"BoundingBoxOffset" mode so that we compute offsets based on the shape
bounding boxes of previous floats, not the shape contour.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Check the
ShapeOutsideFloatOffsetMode to determine if the offset should be
adjusted for the shape contour or not.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine): Add parameter for offset mode.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(RenderBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): If the
new float is being added on top of a previous float on the same line,
undo the offset for the previous float's shape contour so that we
position the new float based on the bounding box.
LayoutTests:
Tests demonstrating stacked floats properly working with shape-outside.
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html: Added.
- 3:02 PM Changeset in webkit [148055] by
-
- 2 edits in trunk/Tools
newcommitbot (WKR) requires a subversion checkout
https://bugs.webkit.org/show_bug.cgi?id=114309
Reviewed by Benjamin Poulain.
Directly talk to the subversion server instead of relying on a local checkout.
This allows us to run WKR off of a git clone.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
(NewCommitBot.process_work_item):
- 2:35 PM Changeset in webkit [148054] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r147454): Youtube annotation links to new window broken
https://bugs.webkit.org/show_bug.cgi?id=114242
<rdar://problem/13609940>
Reviewed by Beth Dakin.
Set the current user gesture to "DefinitelyProcessingNewUserGesture" if popups are allowed.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
- 2:30 PM Changeset in webkit [148053] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Windows build after r148050.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Use lround().
- 2:28 PM Changeset in webkit [148052] by
-
- 2 edits in trunk/Source/WebCore
[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>
Reviewed by Simon Fraser.
Move an ASSERT that dereferenced a pointer inside the null-check for that pointer.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconBitmapForIconURL):
- 2:25 PM Changeset in webkit [148051] by
-
- 4 edits in trunk/Tools
webkitbot refers to sheriffbot in help
https://bugs.webkit.org/show_bug.cgi?id=114307
Reviewed by Benjamin Poulain.
Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Help):
(Help.execute):
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- Scripts/webkitpy/tool/bot/sheriff.py:
(Sheriff.name):
- 1:56 PM Changeset in webkit [148050] by
-
- 24 edits2 adds in trunk
[Mac] user caption styles not applied to correct element
https://bugs.webkit.org/show_bug.cgi?id=114230
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-css-user-override.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Drive by clean-up so we don't log excessively.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize
new member variables.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Set cue font size when it is
inserted into the tree.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Update the font size of
all active cues.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Set size-relative CSS properties
after a time because this can be called during layout.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged before updateSizes.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setFontSize): New, set the cue's font size.
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set cue properties on the cue element
instead of on the cue box to match what we do for the "cue" pseudo element.
(WebCore::TextTrackCueGeneric::setFontSize): New, set the cue's font size.
- html/track/TextTrackCueGeneric.h:
- html/track/TextTrackList.cpp:
(TextTrackList::remove): Drive-by cleanup, don't ASSERT when the media element is NULL.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride): New, allow user CSS overrides
to be tested in DRT.
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): New, generate a user style
sheet override. Moved here from CaptionUserPreferencesMac.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Don't ignore background color importance.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Implement even when we don't
have the media accessibility framework so this can be tested in DRT. Apply all cue properties
to the element used for the "cue" pseudo element.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress): Drive-by cleanup, remove logging
because this method is called so frequently and the logging is not especially useful.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Only log when the ready/network
state changes because this method is called so frequently.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): Drive-by cleanup, remove logging
because this method is called so frequently and the logging is not especially useful.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Make the logging more useful.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Reset captions style sheet override.
(WebCore::Internals::captionsStyleSheetOverride): New, return the captions style sheet override.
(WebCore::Internals::setCaptionsStyleSheetOverride): New, override the captions style sheet override.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/track/track-css-user-override-expected.txt: Added.
- media/track/track-css-user-override.html: Added.
- media/track/track-cue-container-rendering-position-expected.txt:
- media/track/track-cue-container-rendering-position.html:
- media/track/track-cue-rendering-expected.txt:
- media/track/track-cue-rendering.html: Font size is not applied instantly when a video element is
resized, so check after a very short delay.
- 1:52 PM Changeset in webkit [148049] by
-
- 66 edits2 adds in trunk
Repaint rect too small on elements with shadows
https://bugs.webkit.org/show_bug.cgi?id=114225
Source/WebCore:
Reviewed by Dain Adler.
We assumed that shadows (box-shadow, text-shadow, svg shadows)
only required inflating the repaint rect by the blur radius of
the shadow. However, this is incorrect; the shadow can extend
further, which resulted in clipped or incorrectly invalidated
shadows.
Fix by disambiguating the blur radius (which is 2x the standard
deviation of the Gaussian distribution used to generate the blur),
from the painting extent, which is how far the shadow visually
projects. Using a 1.4 multiplier of the blur radius is a good
approximation for the painting extent.
Renamed ShadowData::blur() to ShadowData::radius(), and added
ShadowData::paintingExtent(). Use the latter in all places
which relate to invalidation.
Test: fast/box-shadow/shadow-repaint.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paintDecoration):
- rendering/RenderBoxModelObject.cpp:
(WebCore::applyBoxShadowForBackground):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
- rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
- rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::radius):
(WebCore::ShadowData::paintingExtent):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
LayoutTests:
Reviewed by Darin Alder.
New test for invalidation with box-shadow. Update test results affected
by shadow extent.
- compositing/geometry/foreground-layer-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- fast/box-shadow/shadow-repaint-expected.txt: Added.
- fast/box-shadow/shadow-repaint.html: Added.
- platform/mac/fast/multicol/shadow-breaking-expected.png:
- platform/mac/fast/multicol/shadow-breaking-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
- platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
- platform/mac/svg/css/arrow-with-shadow-expected.png:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/mac/svg/css/clippath-with-shadow-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.png:
- platform/mac/svg/css/composite-shadow-example-expected.txt:
- platform/mac/svg/css/composite-shadow-text-expected.txt:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
- platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/mac/svg/css/group-with-shadow-expected.png:
- platform/mac/svg/css/group-with-shadow-expected.txt:
- platform/mac/svg/css/mask-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.png:
- platform/mac/svg/css/path-with-shadow-expected.txt:
- platform/mac/svg/css/shadow-and-opacity-expected.png:
- platform/mac/svg/css/shadow-and-opacity-expected.txt:
- platform/mac/svg/css/shadow-changes-expected.png:
- platform/mac/svg/css/shadow-changes-expected.txt:
- platform/mac/svg/css/shadow-with-large-radius-expected.png:
- platform/mac/svg/css/shadow-with-negative-offset-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.png:
- platform/mac/svg/css/stars-with-shadow-expected.txt:
- platform/mac/svg/css/text-gradient-shadow-expected.png:
- platform/mac/svg/css/text-gradient-shadow-expected.txt:
- platform/mac/svg/css/text-shadow-multiple-expected.png:
- platform/mac/svg/custom/repaint-shadow-expected.png:
- platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
- svg/css/arrow-with-shadow-expected.txt:
- svg/css/circle-in-mask-with-shadow-expected.txt:
- svg/css/clippath-with-shadow-expected.txt:
- svg/css/mask-with-shadow-expected.txt:
- svg/css/shadow-with-large-radius-expected.txt:
- svg/css/shadow-with-negative-offset-expected.txt:
- svg/css/text-shadow-multiple-expected.txt:
- svg/custom/repaint-shadow-expected.txt:
- svg/filters/shadow-on-rect-with-filter-expected.txt:
- svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
- 1:52 PM Changeset in webkit [148048] by
-
- 2 edits in trunk/Source/WebCore
window.internals.repaintRectsAsText() is hard to use because it doesn't force layout
https://bugs.webkit.org/show_bug.cgi?id=114219
Reviewed by Beth Dakin.
Force layout when setTracksRepaints() is set to true, to flush out any pending
repaints from a layout that hasn't happened yet. Also force layout in
trackedRepaintRectsAsText(), so that any pending layout happpens and thus
repaints.
- page/FrameView.cpp:
(WebCore::FrameView::setTracksRepaints):
(WebCore::FrameView::trackedRepaintRectsAsText):
- 1:48 PM Changeset in webkit [148047] by
-
- 10 edits2 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should provide utilities for common OSR exit tasks
https://bugs.webkit.org/show_bug.cgi?id=114306
Reviewed by Mark Hahnenberg.
Just abstract out some things that the FTL will want to use as well.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp: Added.
(DFG):
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h: Added.
(DFG):
- 1:47 PM Changeset in webkit [148046] by
-
- 3 edits in trunk/Tools
Kill old processes between runs on WinEWS bots.
Temporarily disable tests to let bots catch up again.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 1:42 PM Changeset in webkit [148045] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt conditional branch compilation fault on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=114264
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-04-09
Reviewed by Filip Pizlo.
Fix conditional branch compilation in LLInt offlineasm.
- offlineasm/mips.rb:
- 1:35 PM Changeset in webkit [148044] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix (again).
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- 1:35 PM Changeset in webkit [148043] by
-
- 3 edits in trunk/Source/WebKit2
If we fail to decode a message name, pass the message length as the name
https://bugs.webkit.org/show_bug.cgi?id=114305
<rdar://problem/13605703>
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::length):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- 1:18 PM Changeset in webkit [148042] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Unreviewed build fix.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(WebTransformCGPathToNSBezierPath):
- 1:06 PM Changeset in webkit [148041] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
https://bugs.webkit.org/show_bug.cgi?id=114296
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
PR: 308655
We were relying on the load state Committed to reset m_userPerformedManualZoom
and m_userPerformedManualScroll; however, the main resources of the
articles on read.thestar.com were preloaded and the WebPage didn't get
any load state change callbacks when going back to the main page from
the articles. Therefore, m_userPerformedManualZoom had never been reset
in this case and we picked up the wrong scale when restoring the main page.
Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
we are going back or forward.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::goBackOrForward):
- 12:56 PM Changeset in webkit [148040] by
-
- 2 edits in trunk/LayoutTests
Mark mouse-events-scaled-iframe.html as flaky
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
- platform/mac-wk2/TestExpectations:
- 12:55 PM Changeset in webkit [148039] by
-
- 2 edits in trunk/Source/WebCore
AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Reviewed by Tim Horton.
Minor fix from review feedback.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- 12:48 PM Changeset in webkit [148038] by
-
- 7 edits in trunk/Source/WebKit2
Don't create another plugin process for restarted plugins
https://bugs.webkit.org/show_bug.cgi?id=114233
Reviewed by Geoff Garen.
A snapshotting plugin starts in a separate process from
regular plugins. This can be a little confusing to users
because they might see two plugin processes. We can set
the minimum life and timeout on the snapshotting process
to much smaller values, since the process doesn't need
to live that long. This will reduce some potential
confusion. Also, since there is another plugin process
running real plugins, it should be paged in if it needs
to restart.
There was, however, a bug in the process management. A
restarted plugin received a special PluginProcess::Type,
so that it could cross fade into the page nicely. This
caused it to start a *third* plugin process. Instead
mark a restarted flag directly on the PluginProxy and
revert back to two process types.
- PluginProcess/PluginProcess.h: Remove TypeRestartedProcess.
- UIProcess/Plugins/PluginProcessProxy.cpp: Add two new
timeout values for snapshotting processes.
(WebKit::PluginProcessProxy::didFinishLaunching): Chose which
of the timeout pairs to use.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer): Don't look at the process type, instead
look at the process flag to see if we are restarted.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::create): Copy the new flag into constructor.
(WebKit::PluginProxy::PluginProxy): Remember the flag.
- WebProcess/Plugins/PluginProxy.h: Add a new m_restartedProcess flag.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): When we are creating the proxy, separate
the concept of snapshotting and restarting.
- 12:18 PM Changeset in webkit [148037] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should better abstract floating point arguments
https://bugs.webkit.org/show_bug.cgi?id=114300
Reviewed by Mark Hahnenberg.
- dfg/DFGFPRInfo.h:
(FPRInfo):
(JSC::DFG::FPRInfo::toArgumentRegister):
- 12:16 PM Changeset in webkit [148036] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235
Reviewed by Geoffrey Garen.
Due to the way that numCacheableSlots is currently calculated, checking an object's prototype for enumerable
properties causes us not to cache any properties at all. We should only cache properties on the object itself
since we currently don't take advantage of any sort of name caching for properties in the prototype chain.
This fix undoes a ~2% SunSpider regression caused by http://trac.webkit.org/changeset/147570.
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnNonIndexPropertyNames):
- 12:10 PM Changeset in webkit [148035] by
-
- 4 edits in trunk/Tools
[webkitpy] Remove chromium deprecated port support.
https://bugs.webkit.org/show_bug.cgi?id=114228
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
(ChromiumPort): Removed.
(ChromiumAndroidPort): Removed.
(ChromiumXVFBPort): Removed.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_chromium_port): Removed.
(DeprecatedPortTest.test_chromium_android_port): Removed.
(DeprecatedPortTest.test_chromium_xvfb_port): Removed.
- Scripts/webkitpy/tool/steps/update_unittest.py:
(UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
(UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
- 12:09 PM FeatureFlags edited by
- HTML Notifications were finally removed. (diff)
- 12:04 PM Changeset in webkit [148034] by
-
- 12 edits in trunk/Source
[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>
Reviewed by Oliver Hunt.
In the interests of keeping decoding of data coming in from the greater Internet
in the WebProcess, move decoding of favicons from the UIProcess to the WebProcess.
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::setIconBitmapForIconURL):
Receive a ShareableBitmap handle from the WebProcess instead of a DataReference.
Use the new setIconBitmapForIconURL IconDatabase method.
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
Rename setIconDataForIconURL to setIconBitmapForIconURL.
- UIProcess/WebIconDatabase.messages.in: Ditto.
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
In the WebProcess, decode the incoming icon and draw it into a ShareableBitmap.
No testable behavior change.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::updateIconRecord):
Added updateIconRecord, which factors most of setIconDataForIconURL out so it can
be shared with setIconBitmapForIconURL. This function will set either a bitmap or
raw image data for the given icon URL.
(WebCore::IconDatabase::setIconBitmapForIconURL):
Added; make a copy of the bitmap for thread-safety purposes, and call updateIconRecord.
(WebCore::IconDatabase::setIconDataForIconURL):
Factored out of what is now updateIconRecord.
- loader/icon/IconDatabase.h:
(IconDatabase): Add setIconBitmapForIconURL and updateIconRecord.
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::setIconBitmapForIconURL): Added.
- loader/icon/IconRecord.cpp:
(WebCore::IconRecord::setImage): Set the image for an icon record directly (as opposed
to setting the image data, which causes the image to be decoded in the WebProcess).
- loader/icon/IconRecord.h:
(IconRecord): Add setImage.
- 11:53 AM Changeset in webkit [148033] by
-
- 22 edits4 adds in trunk
AX: The bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817
Reviewed by David Kilzer.
Source/WebCore:
This allows bounding paths to be returned for some web elements (image map areas and SVG shapes).
This provides more accuracy when assistive technologies highlight elements.
The Mac and iOS platforms share some code to help transform paths to their screen coordinates.
Tests: platform/iphone-simulator/accessibility/element-paths.html
platform/mac/accessibility/element-paths.html
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::supportsPath):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::elementPath):
(WebCore::AccessibilityObject::supportsPath):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::supportsPath):
(WebCore::AccessibilityRenderObject::elementPath):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityPath]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
(WebCore):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(PathConversionInfo):
(ConvertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
(-[WebAccessibilityObjectWrapperBase convertPointToScreenSpace:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(WebTransformCGPathToNSBezierPath):
(-[WebAccessibilityObjectWrapper bezierPathFromPath:]):
(-[WebAccessibilityObjectWrapper path]):
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Add a pathDescription property for testing so that it's possible
to verify that a path is being returned correctly.
- DumpRenderTree/AccessibilityUIElement.cpp:
(getPathDescriptionCallback):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(_CGPathEnumerationIteration):
(AccessibilityUIElement::pathDescription):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::pathDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::pathDescription):
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::pathDescription):
(WTR):
LayoutTests:
Add new tests for Mac and iOS to verify that path output works.
Modify existing tests to indicate that there is a new AXAttribute, AXPath.
- platform/iphone-simulator/accessibility/element-paths-expected.txt: Added.
- platform/iphone-simulator/accessibility/element-paths.html: Added.
- platform/mac/accessibility/document-links-expected.txt:
- platform/mac/accessibility/element-paths-expected.txt: Added.
- platform/mac/accessibility/element-paths.html: Added.
- platform/mac/accessibility/image-map2-expected.txt:
- 11:04 AM Changeset in webkit [148032] by
-
- 2 edits2 deletes in trunk/Source
Remove the WebKit copy of GLU and the file using it
https://bugs.webkit.org/show_bug.cgi?id=114249
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.
Source/ThirdParty:
- glu/.gitignore: Removed.
- glu/LICENSE.txt: Removed.
- glu/README.webkit: Removed.
- glu/glu.gyp: Removed.
- glu/gluos.h: Removed.
- glu/internal_glu.h: Removed.
- glu/libtess/GNUmakefile: Removed.
- glu/libtess/Imakefile: Removed.
- glu/libtess/README: Removed.
- glu/libtess/alg-outline: Removed.
- glu/libtess/dict-list.h: Removed.
- glu/libtess/dict.c: Removed.
- glu/libtess/dict.h: Removed.
- glu/libtess/geom.c: Removed.
- glu/libtess/geom.h: Removed.
- glu/libtess/memalloc.c: Removed.
- glu/libtess/memalloc.h: Removed.
- glu/libtess/mesh.c: Removed.
- glu/libtess/mesh.h: Removed.
- glu/libtess/normal.c: Removed.
- glu/libtess/normal.h: Removed.
- glu/libtess/priorityq-heap.c: Removed.
- glu/libtess/priorityq-heap.h: Removed.
- glu/libtess/priorityq-sort.h: Removed.
- glu/libtess/priorityq.c: Removed.
- glu/libtess/priorityq.h: Removed.
- glu/libtess/render.c: Removed.
- glu/libtess/render.h: Removed.
- glu/libtess/sweep.c: Removed.
- glu/libtess/sweep.h: Removed.
- glu/libtess/tess.c: Removed.
- glu/libtess/tess.h: Removed.
- glu/libtess/tessmono.c: Removed.
- glu/libtess/tessmono.h: Removed.
Source/WebCore:
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Removed.
- 10:45 AM Changeset in webkit [148031] by
-
- 4 edits in trunk/Source/WebCore
Throttle resize events during live window resize.
<http://webkit.org/b/114292>
<rdar://problem/13411454>
Reviewed by Geoffrey Garen.
Limit resize events to one at max every 0.2 seconds during live window resize.
This mitigates heavy CPU usage during resize on pages with complex onresize handlers.
If there's a pending resize event when the live resize ends, it fires immediately.
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEvent):
Factored out dispatch of the resize event after layout so we can call it on a timer
instead of immediately while live window resize is active.
(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::delayedResizeEventTimerFired):
(WebCore::FrameView::willEndLiveResize):
(WebCore::FrameView::scheduleResizeEvent):
- page/FrameView.h:
- platform/ScrollableArea.h:
Made willStartLiveResize() and willEndLiveResize() virtual so we can override
them on FrameView.
- 10:31 AM FeatureFlags edited by
- (diff)
- 10:05 AM Changeset in webkit [148030] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 10:04 AM FeatureFlags edited by
- Add info on the CSS Exclusions flag (diff)
- 10:03 AM Changeset in webkit [148029] by
-
- 1 copy in tags/Safari-536.29.13
New Tag.
- 9:52 AM Changeset in webkit [148028] by
-
- 2 edits in trunk/Source/WebCore
Add webp to supported image mime types if WEBP feature is enabled/used
https://bugs.webkit.org/show_bug.cgi?id=112819
Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-09
Reviewed by Darin Adler.
Add WebP to list of supported image types in MIMETypeRegistry if enabled.
No new tests: WebP image decoding already covered by exisiting tests.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 9:46 AM Changeset in webkit [148027] by
-
- 3 edits4 adds in trunk
Whitespace in particular source code changes rendering; does not in Firefox
https://bugs.webkit.org/show_bug.cgi?id=100943
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-04-09
Reviewed by Darin Adler.
Source/WebCore:
A render inline which requires a line box is considered a possible
trailing object. So, ensureLineBoxInsideIgnoredSpaces will be called
for it, even if it is placed after a text render ending with a single
space.
Tests: fast/text/whitespace/trailing-space-before-empty-span-1.html
fast/text/whitespace/trailing-space-before-empty-span-2.html
- rendering/RenderBlockLineLayout.cpp:
(TrailingObjects):
(WebCore::TrailingObjects::appendBoxIfNeeded):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/trailing-space-before-empty-span-1-expected.html: Added.
- fast/text/whitespace/trailing-space-before-empty-span-1.html: A test
with a span whose text ends with a single span. A following span
is empty but requires a line box (because it has some padding).
The second span should be rendered.
- fast/text/whitespace/trailing-space-before-empty-span-2-expected.html: Added.
- fast/text/whitespace/trailing-space-before-empty-span-2.html: Same
test as trailing-space-before-empty-span-1.html except that second
span contains whitespace only text.
- 9:39 AM Keeping the Tree Green edited by
- (diff)
- 9:22 AM FeatureFlags edited by
- Add info about CSS_SHADERS. (diff)
- 8:27 AM Changeset in webkit [148026] by
-
- 13 edits in trunk
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352
Reviewed by Elliott Sprehn.
Source/WebCore:
Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.
To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.
In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html
- dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 7:50 AM Changeset in webkit [148025] by
-
- 16 edits in trunk
[EFL] Declare TEST_THEME_DIR in a single place.
https://bugs.webkit.org/show_bug.cgi?id=114285
Reviewed by Anders Carlsson.
.:
Instead of adding the `THEME_DIR' preprocessor variable in many
different CMakeList.txt files in the tree, declare it in
OptionsEfl.cmake so that we avoid needlessly duplicating code around.
While here, rename it to `TEST_THEME_DIR', which is the name used our
WebKit2 infrastructure, to better reflect the purpose of this value.
- Source/cmake/OptionsEfl.cmake: Add the TEST_THEME_DIR preprocessor
definition.
Source/WebKit2:
- PlatformEfl.cmake: Remove definition of `TEST_THEME_DIR', which is
now defined in OptionsEfl.cmake.
Tools:
Adapt to the renaming of
THEME_DIR' toTEST_THEME_DIR'.
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createInspectorView):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::onDownloadRequest):
- EWebLauncher/CMakeLists.txt:
- EWebLauncher/main.c:
(findThemePath):
- EWebLauncher/url_bar.c:
(url_bar_add):
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/efl/main.c:
(window_create):
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 7:48 AM Changeset in webkit [148024] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler: fix calls to HTMLInputElement methods
https://bugs.webkit.org/show_bug.cgi?id=114283
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-09
Reviewed by Rob Buis.
Fix calls with wrong names.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
- 7:35 AM Changeset in webkit [148023] by
-
- 3 edits in trunk/Source/WebKit/efl
[EFL] --minimal build fails with error:
setSeamlessIFramesEnabled' is not a member ofWebCore::RuntimeEnabledFeatures'
https://bugs.webkit.org/show_bug.cgi?id=113951
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-09
Reviewed by Laszlo Gombos.
Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 7:31 AM Changeset in webkit [148022] by
-
- 5 edits3 adds in trunk
[CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
https://bugs.webkit.org/show_bug.cgi?id=112582
Reviewed by Andreas Kling.
Source/WebKit/qt:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
- WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.
Source/WebKit2:
We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.
LayoutTests:
Add test to measure if the time interval is coherent with the unit
of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.
- fast/animation/request-animation-frame-time-unit-expected.txt: Added.
- fast/animation/request-animation-frame-time-unit.html: Added.
- fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
- 7:14 AM Changeset in webkit [148021] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h.
https://bugs.webkit.org/show_bug.cgi?id=114284
Reviewed by Andreas Kling.
The class QtWebPageFindClient was removed in r142073 when the functionality
was folded into QQuickWebViewPrivate.
- UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
- 7:13 AM Changeset in webkit [148020] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] TextureMapperLayer refactor for readiblity
https://bugs.webkit.org/show_bug.cgi?id=114278
Reviewed by Noam Rosenthal.
Removes non-needed return values, function parameters and changes
boolean values with enums for readibility.
No behavioral changes, thus no tests.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
- 6:45 AM Changeset in webkit [148019] by
-
- 8 edits in trunk
[WebSocket] Ignore incoming message in CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=85934
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-09
Reviewed by Kent Tamura.
Source/WebCore:
Change WebSocket implementation to suit the new WebSocket API, which
states that we should ignore messages in CLOSING state.
No new tests, updating existing tests.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveMessage):
LayoutTests:
- http/tests/websocket/tests/hybi/client-close-expected.txt: Rebaseline.
- http/tests/websocket/tests/hybi/client-close.html: Change expected results.
- http/tests/websocket/tests/hybi/client-close_wsh.py: Embed message in close frame
instead of using regular message sending call.
- http/tests/websocket/tests/hybi/fragmented-frames.html: Call WebSocket.close()
only after receiving all messages from server.
- http/tests/websocket/tests/hybi/unmasked-frames.html: Remove extra
WebSocket.close() call that caused regression.
- 6:26 AM Changeset in webkit [148018] by
-
- 4 edits in trunk
[GTK][AC] upversion of clutter and its dependecy
https://bugs.webkit.org/show_bug.cgi?id=114016
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-09
Reviewed by Gustavo Noronha Silva.
Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
.:
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild-optional.modules:
- 6:13 AM Changeset in webkit [148017] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add Localized strings after r144154 and r135127
https://bugs.webkit.org/show_bug.cgi?id=114269
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
Reviewed by Timothy Hatcher.
No new tests, no behavior change.
- English.lproj/localizedStrings.js:
- 5:55 AM Changeset in webkit [148016] by
-
- 1 delete in trunk/LayoutTests/platform/efl-wk2/tables/mozilla_expected_failures
Remove empty directories
- 5:53 AM Changeset in webkit [148015] by
-
- 4 edits2 deletes in trunk/LayoutTests
[EFL] Move tables/mozilla_expected_failures/bugs/bug89315.html's expectations to efl/.
There is no point in keeping the rebaselined results WK2-only. While
here, actually unskip the test and provide a more accurate pixel result
(the previous one was fine, but this one passes with --tolerance=0).
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Removed.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 5:13 AM Changeset in webkit [148014] by
-
- 2 edits in trunk/Source/WebKit2
Fix GTK WebKit2 build after r148005.
https://bugs.webkit.org/show_bug.cgi?id=114270
Reviewed by Andreas Kling.
Fix GTK build break that went through the buildbot undetected.
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
- 5:11 AM Changeset in webkit [148013] by
-
- 4 edits in trunk/Source/WebCore
Throttle compositing layer flushes in subframes
https://bugs.webkit.org/show_bug.cgi?id=114267
Reviewed by Andreas Kling.
Throttle compositing layer flushes in all frames, not just the main one.
This especially reduces flushes/repaints generated by ads in iframes.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/FrameView.cpp:
(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
- page/FrameView.h:
- 5:00 AM Changeset in webkit [148012] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening.
Now unskip a few compositing-related tests which are not failing
anymore.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:53 AM Changeset in webkit [148011] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Remove direct references to WebPageProxy from QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=112850
Reviewed by Andreas Kling.
Removes direct references to WebPageProxy from QQuickWebPage and prepares the
class for the move to QRawWebView. The access to the device scale factor and
CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
accessors to these properties are temporarily added. Eventually, this access will
be provided through QRawWebView when the move is complete.
This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
to QQuickWebViewPrivate as it is mainly used from there.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
- UIProcess/API/qt/qquickwebpage_p.h:
- UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::handleMouseEvent):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::coordinatedGraphicsScene):
(QQuickWebViewPrivate::deviceScaleFactor):
(QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::itemChange):
(QQuickWebView::touchEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebCore):
(WebKit):
(QQuickWebViewPrivate):
- 4:51 AM Changeset in webkit [148010] by
-
- 9 edits2 adds in trunk
Table border doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=13709
Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-09
Reviewed by Antti Koivisto.
Source/WebCore:
Border issue is fixed when border width is less than 0.8pt
Border width is stored as unsigned. Border width (specified by
author) is converted into pixels and some times this pixel value
goes less than 1px. In this case, border width becomes 0px when
pixel value (double type) assigned to unsigned type.
Border width should not fall to 0px unless it is specified by
author.
Test: fast/borders/border-width-less-then-a-unit-of-pt.html
- css/StyleBuilder.cpp:
ApplyPropetyComputeLength class is replaced with 3 classes :
ApplyPropertyComputeBorderWidth, ApplyPropertyComputeTextSpacing
and ApplyPropertyComputeTransformOriginZ.
(WebCore::ApplyPropertyComputeBorderWidth::applyValue):
(WebCore::ApplyPropertyComputeBorderWidth::createHandler):
This class handles all width properties like border, outline,
etc. These all properties stores value in integer types.
Pixel value rounded of to 1px if value less than 1px and greater
than 0px.
(WebCore):
(ApplyPropertyComputeTextSpacing):
(WebCore::ApplyPropertyComputeTextSpacing::setValue):
(WebCore::ApplyPropertyComputeTextSpacing::applyValue):
(WebCore::ApplyPropertyComputeTextSpacing::createHandler):
This class handles all spacing properties like word-spacing,
letter-spacing etc.
(ApplyPropertyComputeTransformOriginZ):
(WebCore::ApplyPropertyComputeTransformOriginZ::setValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::applyValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::createHandler):
This class handles TransformOriginZ Property.
(WebCore::StyleBuilder::StyleBuilder):
ApplyProprtyComputeLength class usage changed with defined new
classes as per class definition.
LayoutTests:
This test file have border width, outline offset, outline width, border
spacing and column rule width properties test cases.
- fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Added.
- fast/borders/border-width-less-then-a-unit-of-pt.html: Added.
Test case table/mozilla_expected_failures/bug89315.html need to do rebaseline
in efl, gtk and mac.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
Updated the test result for table/mozilla_expected_failures/bug89315.html
Border is expected for table in test table/mozilla_expected_failures/bug89315.html
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 4:50 AM Changeset in webkit [148009] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=114263
Unreviewed gardening.
Removed fast/events/autoscroll.html after r147830.
Unskip inspector/timeline/timeline-animation-frame.html that is now passing.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
- platform/qt/TestExpectations:
- 4:48 AM Changeset in webkit [148008] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Use C API to enable Navigator Qt Object.
https://bugs.webkit.org/show_bug.cgi?id=112810
Reviewed by Andreas Kling.
Replace the direct reference to the WebPageProxy with use of
C API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):
- 4:42 AM Changeset in webkit [148007] by
-
- 3 edits in trunk/LayoutTests
[EFL] More gardening.
Unskip some tests which have stopped crashing after r147759,
147933 and others.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:34 AM Changeset in webkit [148006] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening. Unskip some tests that have been passing for a while.
- platform/efl/TestExpectations:
- 4:13 AM Changeset in webkit [148005] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Add C API to copy selected files from WebOpenPanelParameters.
https://bugs.webkit.org/show_bug.cgi?id=112339
Reviewed by Andreas Kling.
Replaces the existing WebOpenPanelParameters::selectedFileNames() method
to return a copy of the selected file names and exposes it through the
C API. This is done in order to reduce the direct use of WebKit2 internal
classes. The implementation is very similar to the one in
WebOpenPanelParameters::acceptMIMETypes().
This also updates the GTK port, which is the other user of selectedFileNames.
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::selectedFileNames):
(WebKit):
- Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
- UIProcess/API/C/WKOpenPanelParameters.cpp:
(WKOpenPanelParametersCopySelectedFileNames):
- UIProcess/API/C/WKOpenPanelParameters.h:
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_selected_files):
- UIProcess/qt/QtWebPageUIClient.cpp:
(WebKit::QtWebPageUIClient::runOpenPanel):
- 4:01 AM Changeset in webkit [148004] by
-
- 2 edits in trunk/Source/WTF
[CMake] Remove conditional source file lists in WTF
https://bugs.webkit.org/show_bug.cgi?id=114250
Reviewed by Laszlo Gombos.
Use the #ifdef in the source file instead of conditional adding
files to the list of source files. This allows us to remove the
information of enabled features from CMake in next step.
- wtf/CMakeLists.txt:
- 3:44 AM Changeset in webkit [148003] by
-
- 2 edits in trunk/Source/WebCore
Initialization skipped error on WinCario after r147643
https://bugs.webkit.org/show_bug.cgi?id=114258
Reviewed by Csaba Osztrogonác.
Build fix. Adding extra block statement to avoid error C2362 on WinCario
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
- 3:15 AM Changeset in webkit [148002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for two a11y tests that regressed with r147719.
- 3:11 AM Changeset in webkit [148001] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r147995.
http://trac.webkit.org/changeset/147995
https://bugs.webkit.org/show_bug.cgi?id=114261
Wrong gardening. (Requested by gyuyoung on #webkit).
- platform/efl/TestExpectations:
- 3:03 AM Changeset in webkit [148000] by
-
- 15 edits in trunk/Source
[WK2] Remove build warnings for unused parameters
https://bugs.webkit.org/show_bug.cgi?id=114234
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
Reviewed by Andreas Kling.
Fix build warnings -Wunused-parameter.
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::openInMemory):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
- Modules/indexeddb/IDBLevelDBCoding.h:
(WebCore::IDBLevelDBCoding::encodeIntSafely):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::canSet):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::ComparatorAdapter::FindShortestSeparator):
(WebCore::ComparatorAdapter::FindShortSuccessor):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::removeItem):
(WebKit::StorageAreaProxy::clear):
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didFinishLoad):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
- 2:24 AM Changeset in webkit [147999] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Marking a bunch of CSS layout tests as flaky timeouts,
most likely due to libsoup dependency bump.
- 2:07 AM Changeset in webkit [147998] by
-
- 17 edits21 adds in trunk
[WK2] Drop WebProcess capabilities on Linux using seccomp filters
https://bugs.webkit.org/show_bug.cgi?id=89875
Reviewed by Maciej Stachowiak.
.:
Added the bits to EFL/CMake buildsystem to find the libseccomp
library.
- Source/cmake/FindLibSeccomp.cmake: Added.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Make the DATA_DIR global since it is now needed for WebCore and WebKit2.
It is now used to set a sandbox policy for the EFL port.
- PlatformEfl.cmake:
Source/WebKit2:
Introduce the foundations of the SeccompFilter-based sandbox. The
hardening of the WebProcess (and potentially PluginProcess, etc)
works by a combination of the two things:
- Blocking syscalls that are not used, reducing the size of the attack
surface.
- Trapping sensitive syscalls and delegating the execution of these
syscalls to a separated trusted process subject to a set of policies.
The initial implementation traps the open()-family of syscalls on WebKit
EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
since the code is suppose to be Linux-compliant. The list of syscalls handled
by the broker process should definitely grow as we mature the
implementation. Other syscalls needs to be handled to get this sandbox
fully functional, like unlink(), mkdir(), etc.
The broker process should be initialized as early as possible on the
sandboxed process main() function, because it only does a fork(), which
is cheap on Linux. That also aims to minimize the resident memory footprint
of the broker process.
Opening of files for upload and saving downloads is not supported yet,
since it should be handled to the UIProcess in a similar fashion as
the Mac port does.
- PlatformEfl.cmake:
- Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.
(WebKit):
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::OpenSyscall):
(WebKit::OpenSyscall::setResult):
(WebKit::OpenSyscall::execute):
(WebKit::OpenSyscall::encode):
(WebKit::OpenSyscall::decode):
(WebKit::OpenSyscallResult::OpenSyscallResult):
(WebKit::OpenSyscallResult::~OpenSyscallResult):
(WebKit::OpenSyscallResult::encode):
(WebKit::OpenSyscallResult::decode):
- Shared/linux/SeccompFilters/OpenSyscall.h: Added.
(CoreIPC):
(WebKit):
(OpenSyscall):
(WebKit::OpenSyscall::setPath):
(WebKit::OpenSyscall::setFlags):
(WebKit::OpenSyscall::setMode):
(OpenSyscallResult):
(WebKit::OpenSyscallResult::fd):
(WebKit::OpenSyscallResult::errorNumber):
- Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.
(WebKit):
(SeccompBrokerClient):
(WebKit::sendMessage):
(WebKit::receiveMessage):
(WebKit::SIGSYSHandler):
(WebKit::registerSIGSYSHandler):
(WebKit::SeccompBrokerClient::shared):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
(WebKit::SeccompBroker::launchProcess):
(WebKit::SeccompBroker::initialize):
(WebKit::SeccompBroker::runLoop):
- Shared/linux/SeccompFilters/SeccompBroker.h: Added.
(WebKit):
(SeccompBroker):
(WebKit::SeccompBroker::setSyscallPolicy):
(WebKit::SeccompBroker::SeccompBroker):
- Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.
(WebKit):
(WebKit::SeccompFilters::SeccompFilters):
(WebKit::SeccompFilters::~SeccompFilters):
(WebKit::SeccompFilters::addRule):
(WebKit::SeccompFilters::initialize):
- Shared/linux/SeccompFilters/SeccompFilters.h: Added.
(WebKit):
(SeccompFilters):
(WebKit::SeccompFilters::context):
(WebKit::SeccompFilters::platformInitialize):
- Shared/linux/SeccompFilters/SigactionSyscall.cpp: Added.
(WebKit):
(WebKit::SigactionSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigactionSyscall.h: Added.
(WebKit):
(SigactionSyscall):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Added.
(WebKit):
(WebKit::SigprocmaskSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Added.
(WebKit):
(SigprocmaskSyscall):
- Shared/linux/SeccompFilters/Syscall.cpp: Added.
(WebKit):
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::Syscall::Syscall):
(WebKit::SyscallResult::createFromDecoder):
(WebKit::SyscallResult::SyscallResult):
- Shared/linux/SeccompFilters/Syscall.h: Added.
(CoreIPC):
(WebKit):
(Syscall):
(WebKit::Syscall::~Syscall):
(WebKit::Syscall::type):
(WebKit::Syscall::setContext):
(WebKit::Syscall::context):
(SyscallResult):
(WebKit::SyscallResult::~SyscallResult):
(WebKit::SyscallResult::type):
- Shared/linux/SeccompFilters/SyscallPolicy.cpp: Added.
(WebKit):
(WebKit::removeTrailingSlash):
(WebKit::SyscallPolicy::hasPermissionForPath):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):
- Shared/linux/SeccompFilters/SyscallPolicy.h: Added.
(WebKit):
(SyscallPolicy):
- Target.pri:
- WebKit2.pri:
- WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessEfl::SeccompFiltersWebProcessEfl):
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):
- WebProcess/efl/SeccompFiltersWebProcessEfl.h: Added.
(WebKit):
(SeccompFiltersWebProcessEfl):
- WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Added.
(WebKit):
(WebKit::SeccompFiltersWebProcessQt::SeccompFiltersWebProcessQt):
(WebKit::SeccompFiltersWebProcessQt::platformInitialize):
- WebProcess/qt/SeccompFiltersWebProcessQt.h: Added.
(WebKit):
(SeccompFiltersWebProcessQt):
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Tools:
Add unit tests to verify if the handling of the open, openat, creat syscall
is being done right. We check if the Read/Write/ReadAndWrite permissions
are respected, if the canonical path is being resolved and if
the permissions are falling back to the topmost parent directory with a
policy set when the directory being opened has no policy.
We also test if any attempt of blocking SIGSYS is silently ignored.
SIGSYS cannot be blocked because in it's handler is where we hook
syscalls to the broker process.
Also added libseccomp to EFL's jhbuild to make the life of developers
willing to help easier.
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
(TestWebKitAPI):
(SeccompEnvironment):
(TestWebKitAPI::SeccompEnvironment::SetUp):
(TestWebKitAPI::SeccompEnvironment::TearDown):
(TestWebKitAPI::dummyHandler):
(TestWebKitAPI::TEST):
(TestWebKitAPI::stressTest):
- efl/jhbuild.modules:
- qmake/mkspecs/features/features.pri:
- 1:49 AM Changeset in webkit [147997] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ 32 bit build.
- Source/autotools/symbols.filter: Add some symbols that are
mangled differently in 32 bits due to size_t.
- 1:35 AM FeatureFlags edited by
- subpixel layout update (diff)
- 1:33 AM FeatureFlags edited by
- (diff)
- 1:31 AM FeatureFlags edited by
- (diff)
- 1:12 AM Changeset in webkit [147996] by
-
- 5 edits2 adds2 deletes in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
- platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- platform/gtk/fast/js/exception-linenums-in-html-3-expected.png: Removed.
- platform/gtk/fast/js/missing-style-end-tag-js-expected.png: Removed.
- platform/gtk/fast/text/international/003-expected.png:
- platform/gtk/fast/text/international/003-expected.txt:
- platform/gtk/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
- 1:04 AM FeatureFlags edited by
- CSS Regions (diff)
- 12:48 AM Changeset in webkit [147995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening.
fast/dom/shadow/selections-in-shadow.html is passed on EFL layout test now.
- platform/efl/TestExpectations:
- 12:35 AM Changeset in webkit [147994] by
-
- 22 edits in trunk
REGRESSION: Autocorrection doesn't work in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113846
Reviewed by Alexey Proskuryakov.
Tools:
The problem was that we were replacing NSSpellCheck's dictionary with our own
in DumpRenderTree but we were not adding necessary corrections to the dictionary.
Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
and "would" respectively in DumpRenderTree.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests:
Removed failing expectations from tests that require "mesage" to be corrected to "message".
Also modified to dynamically assert the marker positions so that we may catch regressions
without pixel results (we still dump pixel results via dumpAsText(true) for sanity check).
- platform/mac/TestExpectations:
- platform/mac/editing/spelling/autocorrection-contraction-expected.png:
- platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word-expected.png:
- platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/click-autocorrected-word.html:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
- platform/mac-wk2/TestExpectations:
- 12:30 AM Changeset in webkit [147993] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Mark not implemented methods in TextCheckerEfl.
https://bugs.webkit.org/show_bug.cgi?id=112261
Reviewed by Anders Carlsson.
There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
- 12:20 AM Changeset in webkit [147992] by
-
- 4 edits in trunk
Do not set CMAKE_BUILD_TYPE if it is not defined
https://bugs.webkit.org/show_bug.cgi?id=114243
Reviewed by Geoffrey Garen.
Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
- 12:12 AM Changeset in webkit [147991] by
-
- 1 edit4 deletes in trunk/Tools
Remove the gyp files for Tools
https://bugs.webkit.org/show_bug.cgi?id=114248
Reviewed by Ryosuke Niwa.
- DumpRenderTree/DumpRenderTree.gyp: Removed.
- DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
- DumpRenderTree/DumpRenderTree.gypi: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
- TestWebKitAPI/TestWebKitAPI.gypi: Removed.
- 12:07 AM Changeset in webkit [147990] by
-
- 1 edit1 delete in trunk/Source/JavaScriptCore
Remove yarr.gyp
https://bugs.webkit.org/show_bug.cgi?id=114247
Reviewed by Benjamin Poulain.
- yarr/yarr.gyp: Removed.
Apr 8, 2013:
- 11:59 PM Changeset in webkit [147989] by
-
- 1 edit1 delete in trunk/Source/ThirdParty
Remove gyp from ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=114244
Rubberstamped by Ryosuke Niwa.
- gyp: Removed.
- 11:57 PM Changeset in webkit [147988] by
-
- 1 edit1 delete in trunk/Source/ThirdParty/ANGLE
Remove ANGLE.gyp
https://bugs.webkit.org/show_bug.cgi?id=114245
Unreviewed. Just removing an empty directory.
- ANGLE.gyp: Removed.
- 11:49 PM Changeset in webkit [147987] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove WebCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114239
Reviewed by Benjamin Poulain.
- WebCore.gyp: Removed.
- WebCore.gyp/.gitignore: Removed.
- WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Removed.
- WebCore.gyp/MakeNames.gypi: Removed.
- WebCore.gyp/WebCore.gyp: Removed.
- WebCore.gyp/mac: Removed.
- WebCore.gyp/mac/adjust_visibility.sh: Removed.
- WebCore.gyp/mac/check_objc_rename.sh: Removed.
- WebCore.gyp/scripts: Removed.
- WebCore.gyp/scripts/action_csspropertynames.py: Removed.
- WebCore.gyp/scripts/action_cssvaluekeywords.py: Removed.
- WebCore.gyp/scripts/action_derivedsourcesallinone.py: Removed.
- WebCore.gyp/scripts/action_makenames.py: Removed.
- WebCore.gyp/scripts/action_useragentstylesheets.py: Removed.
- WebCore.gyp/scripts/rule_bison.py: Removed.
- WebCore.gyp/scripts/supplemental_idl_files.py: Removed.
- WebCore.gypi: Removed.
- 11:46 PM Changeset in webkit [147986] by
-
- 1 edit2 deletes in trunk/Source/JavaScriptCore
Remove JavaScriptCore.gyp/gypi
https://bugs.webkit.org/show_bug.cgi?id=114238
Reviewed by Benjamin Poulain.
- JavaScriptCore.gyp: Removed.
- JavaScriptCore.gyp/.gitignore: Removed.
- JavaScriptCore.gypi: Removed.
- 11:45 PM Changeset in webkit [147985] by
-
- 14 edits in trunk/Source/JavaScriptCore
Adds fromCharCode intrinsic support.
https://bugs.webkit.org/show_bug.cgi?id=104807
Patch by Vahag Vardanyan <vaag@ispras.ru> on 2013-04-08
Reviewed by Oliver Hunt.
Switch to using fromCharCode intrinsic instead of call operation in some cases.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileFromCharCode):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC):
- runtime/StringConstructor.h:
(JSC):
- 11:44 PM Changeset in webkit [147984] by
-
- 2 edits in trunk/Tools
WKR (new-commit-bot) is too slow
https://bugs.webkit.org/show_bug.cgi?id=110087
Reviewed by Geoffrey Garen.
Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
Just run "svn log -r <revision>" instead to cut down the delay.
Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot.next_work_item):
(NewCommitBot._is_empty_log):
(NewCommitBot._update_checkout):
- 11:16 PM Changeset in webkit [147983] by
-
- 15 edits6 deletes in trunk
Rollout r147756: performance regression
https://bugs.webkit.org/show_bug.cgi?id=114176
Patch by Mihai Maerean <Mihai Maerean> on 2013-04-08
Reviewed by Alexis Menard.
Source/WebCore:
Rolling out the patch for https://bugs.webkit.org/show_bug.cgi?id=74144 "[CSS Regions] Elements in a region
should be assignable to a named flow" because of the performance regression in Parser/html5-full-render.html .
No new tests (because this is a rollout patch).
- dom/Element.cpp:
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- dom/NodeRenderingContext.h:
- dom/PseudoElement.h:
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer):
- dom/Text.h:
- rendering/FlowThreadController.cpp:
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
LayoutTests:
- fast/regions/flow-body-in-html-expected.txt: Removed.
- fast/regions/flow-body-in-html.html: Removed.
- fast/regions/region-content-flown-into-region-expected.html: Removed.
- fast/regions/region-content-flown-into-region.html: Removed.
- fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
- fast/regions/universal-selector-children-to-the-same-region.html: Removed.
- 10:55 PM Changeset in webkit [147982] by
-
- 2 edits in trunk/Tools
Build fix. Can't remove appendCustomBuildFlags.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
- 10:35 PM Changeset in webkit [147981] by
-
- 4 edits in trunk/Tools
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990
Reviewed by Benjamin Poulain.
Removed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallGtkDependencies):
(RunUnitTests.start):
(RunWebKit2Tests.start):
(Factory.init):
(unitTestsSupported):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 9:53 PM Changeset in webkit [147980] by
-
- 1 edit2 deletes in trunk/Source/WTF
Remove WTF.gyp/WTF.gypi
https://bugs.webkit.org/show_bug.cgi?id=114237
Reviewed by Maciej Stachowiak.
- WTF.gyp: Removed.
- WTF.gyp/.gitignore: Removed.
- WTF.gyp/WTF.gyp: Removed.
- WTF.gypi: Removed.
- 8:23 PM FeatureFlags edited by
- (diff)
- 8:15 PM Changeset in webkit [147979] by
-
- 24 edits in trunk
Remove HTML Notification
https://bugs.webkit.org/show_bug.cgi?id=114231
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The feature is dead. It was only kept in the tree because of chromium.
- Configurations/FeatureDefines.xcconfig:
- Modules/notifications/Notification.cpp:
(WebCore):
(WebCore::Notification::Notification):
- Modules/notifications/Notification.h:
(Notification):
- Modules/notifications/NotificationCenter.h:
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
- page/FeatureObserver.h:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- qmake/mkspecs/features/features.pri:
LayoutTests:
- fast/notifications/notifications-with-permission-expected.txt:
- fast/notifications/notifications-with-permission.html:
- 8:09 PM Changeset in webkit [147978] by
-
- 2 edits in trunk/LayoutTests
[Mac][WebKit2] destroy-during-async-npp-new.html does not crash anymore
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
The test destroy-during-async-npp-new.html has not crashed in a long time. Re-enable
it to see how the bots like it.
- 8:08 PM FeatureFlags edited by
- (diff)
- 7:43 PM Changeset in webkit [147977] by
-
- 2 edits in trunk/Source/WebCore
Don't try to remove a non-existent snapshot
https://bugs.webkit.org/show_bug.cgi?id=114226
<rdar://problem/13604480>
Reviewed by Darin Adler.
We don't need to trigger the timer to remove a snapshot
if there was never a snapshot displayed.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Detect if we're moving from the DisplayingSnapshot state.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Guard against a missing renderer.
- 7:36 PM UnmaintainedFeatureList edited by
- Replaced the content by a hyperlink to … (diff)
- 7:36 PM FeatureFlags edited by
- Copied the rest of info from … (diff)
- 7:35 PM FeatureFlags edited by
- (diff)
- 7:34 PM UnmaintainedFeatureList edited by
- (diff)
- 7:32 PM FeatureFlags edited by
- Added grid layout (diff)
- 7:29 PM MaintainedFeatureList edited by
- Replaced the content with a link to FeatureFlags (diff)
- 7:28 PM FeatureFlags edited by
- Added the contributor list for CSS3_TEXT_LINE_BREAK (diff)
- 7:26 PM Changeset in webkit [147976] by
-
- 13 edits in trunk/Source/WTF
wtf/dtoa/* uses a confusing name to reference its buffers
https://bugs.webkit.org/show_bug.cgi?id=109709
Reviewed by Darin Adler.
The data structure Vector in wtf/dtoa has nothing to do with a traditional
vector, is it just a pointer and the length of the pointed buffer.
Rename it to BufferReference to avoid mistakes.
- wtf/dtoa/bignum-dtoa.cc:
- wtf/dtoa/bignum-dtoa.h:
- wtf/dtoa/bignum.cc:
- wtf/dtoa/bignum.h:
(Bignum):
- wtf/dtoa/double-conversion.cc:
- wtf/dtoa/fast-dtoa.cc:
- wtf/dtoa/fast-dtoa.h:
- wtf/dtoa/fixed-dtoa.cc:
- wtf/dtoa/fixed-dtoa.h:
(double_conversion):
- wtf/dtoa/strtod.cc:
- wtf/dtoa/strtod.h:
(double_conversion):
- wtf/dtoa/utils.h:
(double_conversion):
(WTF::double_conversion::BufferReference::BufferReference):
(WTF::double_conversion::BufferReference::SubBufferReference):
(StringBuilder):
- 7:12 PM UnmaintainedFeatureList edited by
- (diff)
- 6:45 PM Changeset in webkit [147975] by
-
- 2 edits in trunk/Source/WebCore
Do not define CAN_THEME_URL_ICON for PLATFORM(WIN_CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=108444
Reviewed by Darin Adler.
Image::loadPlatformResource("urlIcon") returns nothing
since r30961 on Windows which makes the code useless.
- loader/icon/IconDatabase.cpp:
- 6:40 PM Changeset in webkit [147974] by
-
- 9 edits in trunk/Source
Build fix.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
- WebKit.vcproj/WebKitExports.def.in:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:34 PM Changeset in webkit [147973] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPage: fix build due to type mismatches
https://bugs.webkit.org/show_bug.cgi?id=114148
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.
Add explicit conversions between LayoutUnit and int, and between
LayoutRect and IntRect.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rectForNode):
- 6:27 PM Changeset in webkit [147972] by
-
- 2 edits in trunk/Source/WTF
[BlackBerry] MathExtras: macros defined in math.h conflict with the real functions
https://bugs.webkit.org/show_bug.cgi?id=112683
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Darin Adler.
After calls to signbit and friends were prefixed with std:: in
r143232, the BlackBerry port no longer compiles.
The solution is to get rid of the macros defined in math.h and use
the real functions instead.
- wtf/MathExtras.h:
- 6:06 PM Changeset in webkit [147971] by
-
- 3 edits in trunk/LayoutTests
[Mac] Fix test expectations for ietestcenter/css3/grid/grid-items-003.htm
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations: The test pass on WebKit2 Mountain Lion Release builds.
- platform/mac/TestExpectations: The test is flaky on Mountain Lion Release builds.
- 5:50 PM Changeset in webkit [147970] by
-
- 3 edits in trunk/LayoutTests
[Mac][WebKit2] fast/css/sticky/sticky-top-zoomed.html is flaky on Mountain Lion
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
The test is flaky on MountainLion for WebKit1 and WebKit2. It fails systematically
in Debug or on older OS X.
- 5:46 PM UnmaintainedFeatureList edited by
- (diff)
- 5:45 PM Changeset in webkit [147969] by
-
- 15 edits in trunk/LayoutTests
Tests for exceptions of type DOMException.TYPE_ERR in encrypted-media-syntax.html are broken
https://bugs.webkit.org/show_bug.cgi?id=113119
Renames testException() to testDOMException() and tweaks the check.
Also adds a new testException() helper for checking non-DOM exceptions.
Patch by Steve Block <steveblock@chromium.org> on 2013-04-08
Reviewed by Darin Adler.
- media/encrypted-media/encrypted-media-not-loaded.html:
- media/encrypted-media/encrypted-media-syntax-expected.txt:
- media/encrypted-media/encrypted-media-syntax.html:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- media/media-fullscreen.js:
(buttonClickHandler):
(canplaythrough):
- media/track/track-add-remove-cue.html:
- media/track/track-addtrack-kind.html:
- media/track/track-cue-mutable.html:
- media/video-buffered.html:
- media/video-play-require-user-gesture.html:
- media/video-seek-no-src-exception.html:
- media/video-seekable.html:
- media/video-test.js:
(testDOMException):
- media/video-volume.html:
- 5:39 PM Changeset in webkit [147968] by
-
- 2 edits in trunk/LayoutTests
Skip async plugin test while fixing the failure.
https://bugs.webkit.org/show_bug.cgi?id=114217
- platform/mac-wk2/TestExpectations:
- 5:31 PM Changeset in webkit [147967] by
-
- 2 edits in trunk
Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349
Reviewed by Gustavo Noronha Silva.
- Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.
- 5:22 PM Changeset in webkit [147966] by
-
- 3 edits in trunk/Tools
Remove chromium EWS support, and fix broken test.
https://bugs.webkit.org/show_bug.cgi?id=114221
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractChromiumEWS): Removed.
(ChromiumLinuxEWS): Removed.
(ChromiumLinuxDebugEWS): Removed.
(ChromiumWindowsEWS): Removed.
(ChromiumAndroidEWS): Removed.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest): Fix misspelled class name.
(test_ewses): Fix entry point name to ensure test is run.
- 5:10 PM Changeset in webkit [147965] by
-
- 7 edits3 adds in trunk
DFG should be able to inline string equality comparisons
https://bugs.webkit.org/show_bug.cgi?id=114224
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
Inline 8-bit string equality, go to slow path for 16-bit strings. 2x speed-up for string equality
comparisons on 8-bit strings. 20-50% speed-up on JSRegress/HashMap tests. 30% speed-up on
string-fasta. 2% speed-up on SunSpider overall. Some small speed-ups elsewhere.
This is a gnarly change but we have loads of test coverage already between the HashMap tests and
preexisting DFG string equality tests (which appear to have been designed to test OSR exits, but
also give us good overall coverage on string equality behavior).
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/regress/script-tests/string-equality.js: Added.
(foo):
- fast/js/regress/string-equality-expected.txt: Added.
- fast/js/regress/string-equality.html: Added.
- 4:59 PM Changeset in webkit [147964] by
-
- 2 edits in trunk/Source/WebKit2
Don't run primary plugin detection if plugin snapshotting is off
https://bugs.webkit.org/show_bug.cgi?id=114222
<rdar://problem/13603988>
Reviewed by Dean Jackson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- 4:55 PM FeatureFlags edited by
- Rename INPUT_TYPE_DATETIME to INPUT_TYPE_DATETIME_INCOMPLETE (diff)
- 4:53 PM Changeset in webkit [147963] by
-
- 4 edits15 deletes in trunk
[WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096
Reviewed by Anders Carlsson.
Source/WebKit2:
Remove conditional includes for the windows platform.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
Tools:
Remove the windows specific parts of the MiniBrowser.
- MiniBrowser/MiniBrowser.vcproj: Removed.
- MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
- MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
- MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
- MiniBrowser/win/BrowserView.cpp: Removed.
- MiniBrowser/win/BrowserView.h: Removed.
- MiniBrowser/win/BrowserWindow.cpp: Removed.
- MiniBrowser/win/BrowserWindow.h: Removed.
- MiniBrowser/win/MiniBrowser.cpp: Removed.
- MiniBrowser/win/MiniBrowser.h: Removed.
- MiniBrowser/win/MiniBrowser.rc: Removed.
- MiniBrowser/win/main.cpp: Removed.
- MiniBrowser/win/resource.h: Removed.
- MiniBrowser/win/stdafx.cpp: Removed.
- MiniBrowser/win/stdafx.h: Removed.
- 4:41 PM Changeset in webkit [147962] by
-
- 43 edits1 copy3 adds in trunk/Source
Stop #include-ing all of JavaScriptCore in every DOM-related file
https://bugs.webkit.org/show_bug.cgi?id=114220
Reviewed by Sam Weinig.
I separated WeakInlines.h from Weak.h so WebCore data types that need
to declare a Weak<T> data member don't have to #include all of the
infrastructure for accessing that data member.
This also required separating Weak<T> from PassWeak<T> by removing the
WeakImplAccessor class template and pushing code down into its subclasses.
- API/JSWeakObjectMapRefPrivate.cpp:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/UnlinkedCodeBlock.h:
- heap/PassWeak.h:
(JSC):
(PassWeak):
(JSC::::PassWeak):
(JSC::::operator):
(JSC::::get):
- heap/SlotVisitorInlines.h:
- heap/Weak.h:
(JSC):
(Weak):
- heap/WeakInlines.h: Copied from Source/JavaScriptCore/heap/Weak.h.
(JSC):
(JSC::::Weak):
(JSC::::operator):
(JSC::::get):
(JSC::::was):
(JSC::weakClear):
- jit/JITThunks.h:
- runtime/RegExpCache.h:
- runtime/Structure.h:
- runtime/WeakGCMap.h:
../WebCore:
I separated ScriptWrappableInlines.h from ScriptWrappable.h so
WebCore data types that inherit from ScriptWrappable don't
have to #include all of the infrastructure for accessing that data member.
- ForwardingHeaders/heap/PassWeak.h: Added.
- ForwardingHeaders/heap/WeakInlines.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSDOMBinding.h:
(JSC):
- bindings/js/JSEventListener.h:
- bindings/js/JSMutationCallback.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptWrappable.h:
(JSC):
(WebCore):
(ScriptWrappable):
- bindings/js/ScriptWrappableInlines.h: Added.
(WebCore):
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):
- bridge/qt/qt_instance.h:
- bridge/qt/qt_runtime.h:
- bridge/runtime_root.cpp:
- bridge/runtime_root.h:
- css/StylePropertySet.cpp:
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- inspector/InspectorDebuggerAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- loader/cache/CachedSVGDocument.cpp:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):
../WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- 4:27 PM Changeset in webkit [147961] by
-
- 2 edits in trunk/LayoutTests
[Mac][WebKit2] The test images-enabled-unset-can-block-image-and-can-reload-in-place.html passes
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations:
This test have been passing reliably for many revisions and pass locally.
- 4:18 PM Changeset in webkit [147960] by
-
- 12 edits4 deletes in trunk
[BlackBerry] Update BlackBerry JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=114065
Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-08
Reviewed by Rob Buis.
.:
Internal PR 317350
Export JSC symbols in BlackBerry build.
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
Internal PR 317350
Remove obsolete files.
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Internal PR 317350
Add new API for determining if user gesture is being processed.
Remove obsolete files.
Properly expose JSC global context.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
(BlackBerry::WebKit::WebPage::globalContext):
(BlackBerry::WebKit::WebPage::isProcessingUserGesture):
(WebKit):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebCoreSupport/ClientExtension.cpp: Removed.
- WebCoreSupport/ClientExtension.h: Removed.
- WebCoreSupport/ExternalExtension.cpp: Removed.
- WebCoreSupport/ExternalExtension.h: Removed.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidClearWindowObjectInWorld):
- 4:01 PM Changeset in webkit [147959] by
-
- 2 edits in trunk/LayoutTests
Update the Mac WebKit2 TestExpectations for http/tests/canvas/canvas-slow-font-loading.html
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-08
- platform/mac-wk2/TestExpectations: The test is flaky in release. Mark it as such.
- 4:01 PM WikiStart edited by
- Add links to new feature list pages. (diff)
- 3:56 PM MaintainedFeatureList created by
- 3:47 PM UnmaintainedFeatureList edited by
- (diff)
- 3:46 PM Changeset in webkit [147958] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Clean up render theme code.
https://bugs.webkit.org/show_bug.cgi?id=114216
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-08
Reviewed by Rob Buis.
BlackBerry PR 323062
Clean up redundant code.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
- platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
- 3:19 PM Changeset in webkit [147957] by
-
- 2 edits in trunk/Tools
Use port 6665 instead of 6667 since the latter doesn't seem to work well.
- Scripts/webkitpy/common/config/irc.py:
- 3:05 PM Changeset in webkit [147956] by
-
- 14 edits5 adds in trunk
Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
https://bugs.webkit.org/show_bug.cgi?id=113139
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-08
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: plugins/npruntime/tostring.html
plugins/npruntime/valueof.html
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::~CInstance):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(Bindings):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::stringValue):
(JSC::Bindings::CInstance::booleanValue):
(JSC::Bindings::CInstance::valueOf):
(JSC::Bindings::CInstance::toJSPrimitive):
- bridge/c/c_instance.h:
(CInstance):
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
(ToStringAndValueOfObject):
(ToStringAndValueOfObject::ToStringAndValueOfObject):
(ScriptableObject):
(ToStringAndValueOfObject::ScriptableObject::hasMethod):
(ToStringAndValueOfObject::ScriptableObject::invoke):
(ToStringAndValueOfObject::ScriptableObject::pluginTest):
(ToStringAndValueOfObject::NPP_GetValue):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- GNUmakefile.am:
LayoutTests:
- platform/qt-mac/TestExpectations:
- platform/wk2/TestExpectations:
- plugins/npruntime/tostring-expected.txt: Added.
- plugins/npruntime/tostring.html: Added.
- plugins/npruntime/valueof-expected.txt: Added.
- plugins/npruntime/valueof.html: Added.
- 2:43 PM Changeset in webkit [147955] by
-
- 4 edits in trunk
REGRESSION (r138858): Crash in WebCore::FrameLoader::~FrameLoader() when opening page in a background tab
https://bugs.webkit.org/show_bug.cgi?id=109935
<rdar://problem/13225963>
Reviewed by Brady Eidson.
Previously, we were deciding if a Page could go into
the PageCache by blacklisting certain load types. Instead,
whitelist the load types that we know can go into the cache,
so that newly-added load types are not cached unless
that is explicitly desired.
The crash occurs when a page which is actively loading
is put into the page cache while doing a redirect with
FrameLoadTypeRedirectWithLockedBackForwardList (note that
this is a redirect that was not covered in the blacklist),
and then promptly removed from the page cache, resulting
in resources from the redirect target (the now-active page)
being incorrectly destroyed.
No new tests, only known crash repro case is extremely
timing dependent (and only happens in WebKit2, with tiled
drawing, in background tabs).
- history/PageCache.cpp:
(WebCore::PageCache::canCache):
Adjust a test which depended on slow-redirects going
into the page cache (which will no longer happen)
to instead click on a link.
- fast/history/timed-refresh-in-cached-frame.html:
- 2:41 PM Changeset in webkit [147954] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::continueDidReceiveResponse):
- 2:31 PM Changeset in webkit [147953] by
-
- 3 edits in trunk/Source/WebKit2
Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217
Reviewed by Anders Carlsson.
The "Async initialization complete" messages probably don't have to be synchronous.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously): Notify of initialization success/failure asynchronously.
- WebProcess/Plugins/PluginProxy.messages.in:
- 2:24 PM Changeset in webkit [147952] by
-
- 11 edits in trunk/Source
Add an async version of ResourceHandle::didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=114215
Reviewed by Sam Weinig.
Source/WebCore:
In order to support converting NSURLConnections to NSURLDownloads when using the network process
we need an async version of didReceiveResponse.
- WebCore.exp.in:
- platform/network/ResourceHandleClient.cpp:
(WebCore::ResourceHandleClient::didReceiveResponseAsync):
Just call continueDidReceiveResponse().
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::continueWillSendRequest):
Split up a single condition in two, making it easier to see which assertion fails.
(WebCore::ResourceHandle::continueDidReceiveResponse):
Call -[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse].
(WebCore::ResourceHandle::continueShouldUseCredentialStorage):
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace):
(WebCore::ResourceHandle::continueWillCacheResponse):
Split up a single condition in two, making it easier to see which assertion fails.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse]):
Signal the semaphore.
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
Call didReceiveResponseAsync on the main thread and wait on the semaphore.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Send the message and then call continueDidReceiveResponse.
- 2:07 PM Changeset in webkit [147951] by
-
- 2 edits in trunk
[GTK] Configure should verify ICU is installed on mingw
https://bugs.webkit.org/show_bug.cgi?id=113645
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-04-08
Reviewed by Gustavo Noronha Silva.
- Source/autotools/FindDependencies.m4: When falling back to hard-coded compiler flags
for ICU and mingw, check that headers do exist on the system and error out otherwise.
- 2:01 PM Changeset in webkit [147950] by
-
- 2 edits in trunk/Source/JavaScriptCore
Windows build fix fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 2:00 PM Changeset in webkit [147949] by
-
- 2 edits in trunk/Source/WebCore
Crash in ScrollingCoordinator::mainThreadScrollingReasons() when going back
https://bugs.webkit.org/show_bug.cgi?id=114214
-and corresponding-
<rdar://problem/13208616>
Reviewed by Anders Carlsson.
When a page is restoring from the page cache, the mainFrame can have a null
Document. So we should null-check the Document here.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
- 1:51 PM Changeset in webkit [147948] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 1:25 PM Changeset in webkit [147947] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make resolve more robust in the face of lookup misses
https://bugs.webkit.org/show_bug.cgi?id=114211
Reviewed by Filip Pizlo.
This simply short circuits the resolve operations in the
event that we don't find a path to a property. There's no
repro case for this happening unfortunately.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- 1:09 PM Changeset in webkit [147946] by
-
- 2 edits in trunk/Tools
[GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.
- 1:05 PM Changeset in webkit [147945] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] More null checks for m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=114172
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.
After r147744, some unit tests were crashing on WebPage
shutdown, because BackingStorePrivate::repaint() now uses
pixelContentsRect() (accessing m_webPage->contentsRect())
instead of BackingStoreClient::contentsRect(). In m_webPage,
m_mainFrame had already been set to 0.
Make us more robust against these errors by checking
the existence of m_mainFrame more diligently.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
(BlackBerry::WebKit::WebPagePrivate::contentsSize):
(BlackBerry::WebKit::WebPagePrivate::absoluteVisibleOverflowSize):
(BlackBerry::WebKit::WebPagePrivate::setViewMode):
- 12:50 PM UnmaintainedFeatureList edited by
- (diff)
- 12:35 PM Changeset in webkit [147944] by
-
- 3 edits in trunk/Tools
Remove my watchlist entries.
https://bugs.webkit.org/show_bug.cgi?id=114180
Reviewed by Adam Barth.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 12:18 PM Changeset in webkit [147943] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed gardening. Remove expected results added by r147824.
- platform/mac-future/accessibility/press-action-is-first-expected.txt: Removed.
- 12:10 PM Changeset in webkit [147942] by
-
- 9 edits4 adds2 deletes in trunk
Simplify ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=113517
Reviewed by Darin Adler.
The patch is based on the work made by Elliott Sprehn. He kindly agreed
for me to finalize the last bits and pieces of the fix.
Source/WebCore:
Simplify ContainerNode::removeChildren by merging the loops and removing
willRemoveChildren. This removes two traversals of the children, avoids
refing and derefing all the children once, avoids allocating a second
NodeVector of children, and means we detach() in the same order as
normal removal.
This does mean you can get into an infinite loop with DOMNodeRemoved
listeners by continously adding nodes but this is true in all other browsers
and the current behavior is bad because it means you don't get notified
of nodes added during removal (which other browsers do notify of). This
patch removes the containerNode.html test that originally tested for this
infinite loop and adds a new one that tests that all nodes get notified.
This makes PerformanceTests/Parser/innerHTML-setter.html 2-6% faster.
There's also a new test verifying ranges remain consistent if modified
inside an mutation event handler. Without the patch it's possible to create
a range with boundaries outside of the DOM tree.
Tests: fast/dom/Range/range-remove-children-event.html
fast/events/mutation-during-innerHTML.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
- dom/Document.h: nodeChildrenWillBeRemoved is not needed any more.
- dom/Range.cpp:
- dom/Range.h: nodeChildrenWillBeRemoved is not needed any more.
LayoutTests:
Remove containerNode.html test since it was checking for an infinite
loop when adding DOM nodes inside a DOMNodeRemoved mutation event
handler, but we actually do want to allow an infinite loop here for
correctness and compatability with other browsers.
Also added mutation-during-innerHTML which checks that all nodes
are notified of being removed even if they were added during the
DOMNodeRemoved notification.
There's a new test range-remove-children-event that verifies the
ranges modified inside a mutation event handler remain consistent.
- fast/dom/MutationObserver/added-out-of-order-expected.txt:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/Range/range-remove-children-event-expected.txt: Added.
- fast/dom/Range/range-remove-children-event.html: Added.
- fast/dom/containerNode-expected.txt: Removed.
- fast/dom/containerNode.html: Removed.
- fast/events/mutation-during-innerHTML-expected.txt: Added.
- fast/events/mutation-during-innerHTML.html: Added.
- 12:06 PM Changeset in webkit [147941] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
- 12:06 PM UnmaintainedFeatureList edited by
- (diff)
- 11:39 AM Changeset in webkit [147940] by
-
- 13 edits in trunk/Source/WebCore
Remove some #includes in headers in rendering code
https://bugs.webkit.org/show_bug.cgi?id=114079
Reviewed by Sam Weinig.
Clean up #includes in RenderObject, RenderLayer etc.
Moved makeMatrixRenderable() into RenderLayer.app, allowing
the removal of a TransformationMatrix.h include.
Make some RenderLayer functions that deal with filters not inline,
to avoid including RenderLayerFilterInfo.h.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ImageOrientation.cpp:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
- platform/graphics/qt/GraphicsContextQt.cpp:
- platform/graphics/transforms/AffineTransform.cpp:
- platform/graphics/transforms/AffineTransform.h:
- rendering/RenderBoxModelObject.h:
- rendering/RenderLayer.cpp:
(WebCore::makeMatrixRenderable):
(WebCore::RenderLayer::filterRenderer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.h:
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.h:
- 11:38 AM Changeset in webkit [147939] by
-
- 5 edits in trunk
Unreviewed, rolling out r147850.
http://trac.webkit.org/changeset/147850
https://bugs.webkit.org/show_bug.cgi?id=113706
Changeset crossed paths with 147505, which is the same fix.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 11:20 AM UnmaintainedFeatureList edited by
- (diff)
- 11:20 AM UnmaintainedFeatureList edited by
- Already in the list + not a problem. (diff)
- 11:17 AM Changeset in webkit [147938] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/12834449> Crashes in WebSocketChannel::processFrame when processing a ping
https://bugs.webkit.org/show_bug.cgi?id=114178
Reviewed by Brady Eidson.
No test, I could never reproduce even manually.
Calling enqueueRawFrame() could change incoming buffer, so a subsequent skipBuffer()
would operate on wrong assumptions. This happened because enqueueRawFrame() actually
tried to process the queue, and send failure sometimed clears m_buffer.
Fixing this by decoupling enqueuing from sending, and making sure that skipBuffer()
in ping frame processing case is performed at a safe time.
- Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::send): (WebCore::WebSocketChannel::startClosingHandshake): (WebCore::WebSocketChannel::processFrame): (WebCore::WebSocketChannel::enqueueTextFrame): (WebCore::WebSocketChannel::enqueueRawFrame): (WebCore::WebSocketChannel::enqueueBlobFrame):
- 11:09 AM Changeset in webkit [147937] by
-
- 17 edits10 deletes in trunk
REGRESSION (r147502): Animations of CA filters broken
https://bugs.webkit.org/show_bug.cgi?id=114067
Reviewed by Dean Jackson.
Revert r147502 [1] because it broke CA filter animations.
[1]: http://trac.webkit.org/changeset/147502
Source/WebCore:
- platform/graphics/IntRectExtent.h:
(WebCore::IntRectExtent::isZero):
(IntRectExtent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):
(WebCore):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Removed.
- css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Removed.
- css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Removed.
- css3/filters/composited-layer-bounds-with-composited-blur.html: Removed.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Removed.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Removed.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Removed.
- css3/filters/filter-change-repaint-composited-expected.png:
- css3/filters/filter-change-repaint-composited.html:
- platform/qt/TestExpectations:
- 11:05 AM UnmaintainedFeatureList edited by
- (diff)
- 11:01 AM UnmaintainedFeatureList edited by
- (diff)
- 11:00 AM UnmaintainedFeatureList edited by
- (diff)
- 10:54 AM UnmaintainedFeatureList edited by
- (diff)
- 10:54 AM Changeset in webkit [147936] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Force horizontal list to be horizontal scrollable.
https://bugs.webkit.org/show_bug.cgi?id=114173
Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-08
Reviewed by Rob Buis.
Force content to be horizontal/vertical overscrollable if it
scrolls in horizontal/vertical way.
PR 237440
Internally Reviewed by Arvid Nilsson.
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- 10:53 AM UnmaintainedFeatureList edited by
- Added CSS Grid Layout to the list (diff)
- 10:52 AM Changeset in webkit [147935] by
-
- 4 edits in tags/Safari-537.35.10/Source
Versioning.
- 10:51 AM Changeset in webkit [147934] by
-
- 2 edits in trunk/Source/JavaScriptCore
Allow KeywordLookupGenerator.py to work on Windows with Windows style line endings
https://bugs.webkit.org/show_bug.cgi?id=63234
Patch by Justin Haygood <jhaygood@reaktix.com> on 2013-04-08
Reviewed by Oliver Hunt.
- KeywordLookupGenerator.py:
(parseKeywords):
- 10:48 AM Changeset in webkit [147933] by
-
- 4 edits in trunk
Source/JavaScriptCore: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129
<rdar://problem/13594898>
Reviewed by Darin Adler.
The check to see if we need a cell check when simplifying a GetById or PutById needs to be hoisted to
above where we abstractly execute the instruction, since after we abstracting execute it, it will
seem like it no longer needs the cell check.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
LayoutTests: REGRESSION(r146669): Assertion hit in JSC::DFG::SpeculativeJIT::fillSpeculateCell() running webgl tests
https://bugs.webkit.org/show_bug.cgi?id=114129 and https://bugs.webkit.org/show_bug.cgi?id=90649
<rdar://problem/13594898> and <rdar://problem/11815727>
Reviewed by Darin Adler.
Unskip these tests because they give us DFG coverage and they are now passing.
- platform/mac/TestExpectations:
- 10:46 AM Changeset in webkit [147932] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid "QFont::setPixelSize: Pixel size <= 0 (0)"
https://bugs.webkit.org/show_bug.cgi?id=114175
Reviewed by Allan Sandfeld Jensen.
QFont doesn't support a 0-size but WebCore does.
Leave our QFont in its default state in this case to avoid the warning.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 10:42 AM Changeset in webkit [147931] by
-
- 2 edits in tags/Safari-537.35.10/Source/WebCore
Merged r147806. <rdar://problem/13591653>
- 10:41 AM Changeset in webkit [147930] by
-
- 5 edits in trunk
Counter still gets incremented when counter-increment is set to none
https://bugs.webkit.org/show_bug.cgi?id=84985
Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-04-08
Reviewed by Darin Adler.
When the counter-increment is set to none, no counters are incremented.
Source/WebCore:
Tests: New test cases added in fast/css/counters/counter-increment-tests.htm
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyCounter::applyValue):
LayoutTests:
- fast/css/counters/counter-increment-tests-expected.txt: Added new test cases.
- fast/css/counters/counter-increment-tests.htm: Added new test cases.
- 10:37 AM Changeset in webkit [147929] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r147894): Broke WTFReportBacktrace() on Mac.
<http://webkit.org/b/114174>
Reviewed by Anders Carlsson.
An #elif !OS(ANDROID) block was erroneously removed, turn it into an #else instead since
that path will still be taken for OS(DARWIN).
- wtf/Assertions.cpp:
- 10:26 AM Changeset in webkit [147928] by
-
- 3 edits2 adds2 deletes in trunk
Crash in WebCore::ElementRuleCollector::collectMatchingRulesForList
https://bugs.webkit.org/show_bug.cgi?id=113458
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-04-08
Reviewed by Darin Adler.
Source/WebCore:
A stylesheet which has been invalidated (type changed from "" or
"text/css") was not correctly removed from the list of active
style sheets when its children are changed.
This change releases StyleElement::m_sheet in advance of calling
DocumentStyleSheetCollection::updateActiveStyleSheets.
(StyleElement::clearSheet calls CSSStyleSheet::clearOwnerNode calls
CSSStyleSheet::didMutate calls Document::styleResolverChanged calls
DocumentStyleSheetCollection::updateActiveStyleSheets)
Test: fast/css/style-element-invalidation-crash.html
- dom/StyleElement.cpp:
(WebCore::StyleElement::clearSheet): Release m_sheet before we
trigger an update of the active style sheets.
LayoutTests:
- fast/css/style-element-invalidation-crash-expected.txt: Added.
- fast/css/style-element-invalidation-crash.html: Added.
- fast/css/stylesheet.innerHTML-calls-didmutate.html: Removed.
- fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Removed.
- 10:24 AM Changeset in webkit [147927] by
-
- 7 edits in trunk
[GTK] Build Platform as a separate static library
https://bugs.webkit.org/show_bug.cgi?id=114164
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Add webkit2platform_sources definition.
Source/WebKit2:
This way we reduce a bit the amount of files compiled twice
because of the plugin process.
- GNUmakefile.am:
- GNUmakefile.list.am:
- Platform/gtk/WorkQueueGtk.cpp: Remove unused header.
- Platform/unix/SharedMemoryUnix.cpp: Ditto.
- 10:23 AM Changeset in webkit [147926] by
-
- 3 edits in trunk/LayoutTests
Stop skipping first part of test in LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
https://bugs.webkit.org/show_bug.cgi?id=104255
Updated test to match the one hosted by W3C which has corrected the reported error.
Reviewed by Eric Carlson.
- media/track/opera/interfaces/TextTrack/cues-expected.txt:
- media/track/opera/interfaces/TextTrack/cues.html:
- 10:22 AM Changeset in webkit [147925] by
-
- 8 edits in tags/Safari-537.35.10/Source
Merged r147659. <rdar://problem/13569460>
- 10:20 AM Changeset in webkit [147924] by
-
- 40 edits2 moves2 adds2 deletes in trunk/Source
[GTK] DOM objects created wrapping a base class have incorrect GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: Removed.
- bindings/gobject/WebKitDOMEventTarget.cpp:
(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.
- bindings/gobject/WebKitDOMEventTargetPrivate.h:
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.
(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):
- bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitDOMObject.cpp:
- bindings/gobject/WebKitDOMPrivate.cpp: Added.
(WebKit):
(WebKit::wrap):
- bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.
(WebCore):
(WebKit):
- bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
- bindings/scripts/CodeGeneratorGObject.pm:
(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
(WebKit::kit):
- bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
(WebKit):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:
(WebKit):
Source/WebKit/gtk:
Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/EditorClientGtk.cpp:
- webkit/webkithittestresult.cpp:
- 10:08 AM Changeset in webkit [147923] by
-
- 1 copy in tags/Safari-537.35.10
New Tag.
- 10:04 AM Changeset in webkit [147922] by
-
- 2 edits in trunk/Source/WebCore
Fix the build with strict GCC 4.8
Unreviewed build fix.
Initialize dragImage to suppress GCC's warning about it being possibly used uninitialized,
which results is a build failure with GCC 4.8 that sets -Werror=maybe-uninitialized.
No new tests needed.
- page/DragController.cpp:
(WebCore::DragController::doImageDrag):
- 9:52 AM Changeset in webkit [147921] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Remove the unused LayoutTestSupport class
https://bugs.webkit.org/show_bug.cgi?id=114170
Reviewed by Alexey Proskuryakov.
The LayoutTestSupport class is not used by any port anywhere in the code and should be removed.
No new tests - no changes in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/LayoutTestSupport.cpp: Removed.
- platform/LayoutTestSupport.h: Removed.
- 9:51 AM Changeset in webkit [147920] by
-
- 11 edits1 delete in trunk/Source/WebCore
Remove WebCore::(enable|disable)SecureTextInput methods
https://bugs.webkit.org/show_bug.cgi?id=114126
Reviewed by Alexey Proskuryakov.
Remove the enableSecureTextInput and disableSecureTextInput methods and all the codepaths leading to them.
These were used only by the Chromium port and are as such not required anymore.
No new tests - no changes in functionality.
- GNUmakefile.list.am:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(Document):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
- editing/FrameSelection.h:
(FrameSelection):
- html/PasswordInputType.cpp:
- html/PasswordInputType.h:
(PasswordInputType):
- page/Frame.cpp:
(WebCore::Frame::setDocument):
- platform/SecureTextInput.h: Removed.
- 9:29 AM Changeset in webkit [147919] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; r147892 moved an export definition out of
a protective #ifdef, causing a link error on platforms which do
not define that method.
- WebCore.exp.in:
- 9:26 AM Changeset in webkit [147918] by
-
- 2 edits in trunk/Source/WTF
Build fix.
- 9:13 AM Changeset in webkit [147917] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Enable text tracks from track elements
https://bugs.webkit.org/show_bug.cgi?id=113522
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-08
Reviewed by Jocelyn Turcotte.
No new tests because they're already there. This just enables the feature.
- Target.pri:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):
- 9:05 AM Changeset in webkit [147916] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Toggle OverWrite mode when pressing the Insert key
https://bugs.webkit.org/show_bug.cgi?id=113384
Reviewed by Martin Robinson.
Perform an OverWrite command as a response to the emission of the
toggle-overwrite signal. Due to the nature of the command it will
only do that when being on a richly editable web content.
- platform/gtk/KeyBindingTranslator.cpp:
(WebCore::toggleOverwriteCallback):
- 8:30 AM Changeset in webkit [147915] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Provide more specific error description for SocketStreamError
https://bugs.webkit.org/show_bug.cgi?id=114134
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-08
Reviewed by Rob Buis.
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
- platform/network/blackberry/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::notifyStatusReceived):
- 8:26 AM Changeset in webkit [147914] by
-
- 3 edits5 adds in trunk
[GTK][EFL] HEAD requests changed to GET after 303 redirection
https://bugs.webkit.org/show_bug.cgi?id=110127
Patch by Youenn Fablet <youennf@gmail.com> on 2013-04-08
Reviewed by Martin Robinson.
Source/WebCore:
Made shouldRedirectAsGET always return false for HEAD requests.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::shouldRedirectAsGET):
LayoutTests:
Added tests checking HEAD redirection.
Redirected HEAD requests are expected to remain HEAD requests.
(http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-21#section-7.4)
- http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
- http/tests/xmlhttprequest/head-redirection.html: Added.
- http/tests/xmlhttprequest/resources/get_method.php: Added.
- http/tests/xmlhttprequest/resources/redirect_methods.php: Added.
- platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt: Added.
- 7:49 AM Changeset in webkit [147913] by
-
- 9 edits in trunk/Source/WebKit2
[WK2][EFL] WebView: Add callbacks to the WKViewClient to remove direct access to page viewport controller
https://bugs.webkit.org/show_bug.cgi?id=110741
Reviewed by Anders Carlsson.
Provided WKViewClient with didRequestScroll, didRenderFrame and didCompletePageTransition
callbacks so that direct access from WebView to page viewport controller is avoided.
Implementation of callbacks is also added to keep the current EFL WK2 functionality.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
Moved here code from deleted WebView::didCommitLoad.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
- UIProcess/efl/WebViewClient.h:
(WebCore):
- 6:35 AM Changeset in webkit [147912] by
-
- 12 edits in trunk/Source/WebCore
DragImage should not depend on Frame and CachedImage
https://bugs.webkit.org/show_bug.cgi?id=21357
Reviewed by Sam Weinig.
Remove Frame and CachedImage dependencies from DragImage.
- dom/Clipboard.h:
(WebCore): Add forward delcaration for CacheImage since it's not
included anymore in DragImage.h.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Use
Frame::dragImageForSelection() and call
dissolveDragImageToFraction() for the returned DragImage. Pass the
font rendering mode to createDragImageForLink, instead of a Frame
that is only used to get the font rendering mode.
(WebCore::DragController::doImageDrag): Get the suggested filename
for the cached image and pass it to
createDragImageIconForCachedImageFilename().
- platform/DragImage.cpp:
(WebCore::createDragImageForLink): Receive a FontRenderingMode
instead of a Frame.
- platform/DragImage.h:
(WebCore): Remove createDragImageForSelection, change
createDragImageForLink to receive a FontRenderingMode instead of a
frame, and rename createDragImageIconForCachedImage as
createDragImageIconForCachedImageFilename since it nows received
the suggested filename of the cached image.
- platform/blackberry/DragImageBlackBerry.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
- platform/efl/DragImageEfl.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction): Return early if the passed
image is NULL.
(WebCore::createDragImageIconForCachedImageFilename): Adapt to API
changes.
(WebCore::createDragImageForLink): Ditto.
- platform/qt/DragImageQt.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
(WebCore::createDragImageForLink): Ditto.
- platform/wx/DragImageWx.cpp:
(WebCore::createDragImageIconForCachedImageFilename): Ditto.
- 6:11 AM Changeset in webkit [147911] by
-
- 2 edits in trunk/Source/WebCore
[EFL] REGRESSION(r147743): Use the correct `operator new' override in RenderThemeEfl.
https://bugs.webkit.org/show_bug.cgi?id=114166
Reviewed by Alexis Menard.
r147743 disabled GLOBAL_FAST_MALLOC_NEW on the EFL port, but this has
caused some pixel tests in WK1 to crash.
The problem stems from RenderThemeEfl::applyEdjeRTLState() directly
calling `operator new(size_t)' for some allocations.
RefCounted<RenderTheme>, on its turn, has a WTF_MAKE_FAST_ALLOCATED
call which adds some `operator new' overrides to the class. Our direct
calls in applyEdjeRTLState() made the scope resolution rules choose the
WTF_MAKE_FAST_ALLOCATED version (which uses FastMalloc's allocator),
while WTF::deleteOwnedPtr() calls the global `operator delete' (which
uses the system's free() implementation).
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState): Explicitly choose the
global `operator new' when calling it.
- 5:57 AM Changeset in webkit [147910] by
-
- 2 edits in trunk/Source/WTF
Unreviewed trivial buildfix after r147799.
Add an ifdef guard to ensure Qt uses its own monotonicallyIncreasingTime()
implemenation instead of the GLIB based one.
- wtf/CurrentTime.cpp:
(WTF):
- 4:13 AM Changeset in webkit [147909] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] WebView's interactive property is not fully respected
https://bugs.webkit.org/show_bug.cgi?id=113066
Reviewed by Jocelyn Turcotte.
WK2 sign-off by Benjamin Poulain.
The QML WebView inherits the "interactive" property from Flickable
which is true by default, and disables the interaction with the
Flickable if set to false.
Resulting from the design of the WebView panning and flicking is
disabled by Flickable but to be consistent we also need to disable
double-tap gestures and pinch gestures since they would trigger
scale and position changes.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleDoubleTapEvent):
- 3:32 AM Changeset in webkit [147908] by
-
- 2 edits in trunk/Tools
[EFL] Mark ShouldGoToBackForwardListItem API test as failing
https://bugs.webkit.org/show_bug.cgi?id=114161
Reviewed by Gyuyoung Kim.
Mark ShouldGoToBackForwardListItem API test as failing for EFL port
as it is crashing due to Bug 111074.
- TestWebKitAPI/PlatformEfl.cmake:
- 2:46 AM Changeset in webkit [147907] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Marked a few tests as failing.
- platform/efl/TestExpectations:
- 2:39 AM Changeset in webkit [147906] by
-
- 2 edits in trunk
Unreviewed GTK build fix.
- Source/autotools/symbols.filter: Exporting a bunch of symbols.
- 2:27 AM Changeset in webkit [147905] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] WebPage: misc build fixes
https://bugs.webkit.org/show_bug.cgi?id=114152
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-08
Reviewed by Carlos Garcia Campos.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::shouldPluginEnterFullScreen):
(BlackBerry::WebKit::WebPagePrivate::didPluginExitFullScreen):
(BlackBerry::WebKit::WebPagePrivate::onPluginStartBackgroundPlay):
(BlackBerry::WebKit::WebPagePrivate::onPluginStopBackgroundPlay):
Remove unused parameters.
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::blockZoom):
Replace TAAUTO with TASTART (this changed in r120495).
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
Rename m_fullscreenVideoNode to m_fullscreenNode (this changed in
r142220).
(BlackBerry::WebKit::WebPagePrivate::compositorDrawsRootLayer):
Rename paintingGoesToWindow() to paintsIntoWindow() (this changed in
r113514).
- 2:27 AM Changeset in webkit [147904] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added after r147829.
- platform/qt/TestExpectations:
- 2:02 AM Changeset in webkit [147903] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/forms/select/popup-closes-on-blur.html as failing for EFL port.
- platform/efl/TestExpectations:
- 1:56 AM Changeset in webkit [147902] by
-
- 3 edits in trunk/LayoutTests
[EFL] Move some inspector tests to efl-wk1/TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=114147
Unreviewed EFL gardening.
Some inspector tests fail on only EFL-WK1 since it does not support plugins yet.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-08
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 1:54 AM Changeset in webkit [147901] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Skip fast/harness/use-page-cache.html for WK2 as WKTR does not support
overriding WebKitUsesPageCachePreferenceKey yet.
- platform/wk2/TestExpectations:
- 1:46 AM Changeset in webkit [147900] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark new accessibility test introduced in r147801 as failing for EFL.
- platform/efl/TestExpectations:
- 1:38 AM Changeset in webkit [147899] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark several ref tests as failure for EFL port.
- platform/efl/TestExpectations:
- 1:28 AM UnmaintainedFeatureList edited by
- (diff)
- 1:26 AM Changeset in webkit [147898] by
-
- 5 edits in trunk/LayoutTests
Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143
Unreviewed.
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/delete-ligature-003.html:
- editing/selection/context-menu-text-selection-expected.txt:
- editing/selection/context-menu-text-selection.html:
- 12:25 AM Changeset in webkit [147897] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] rendering was broken when scrolled ewk_view_single
https://bugs.webkit.org/show_bug.cgi?id=114135
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-04-08
Reviewed by Gyuyoung Kim.
ewk_view_single use memcpy() to copy previous buffer for scrolling, but
memcpy() should not be used when source buffer and destination buffer are
overwrapped.
- ewk/ewk_view_single.cpp:
(_ewk_view_screen_move):
- 12:00 AM Styling Form Controls edited by
- (diff)
