⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 3, 2013:

8:49 PM Changeset in webkit [149550] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

incorrect repainting when a table has a transform
​https://bugs.webkit.org/show_bug.cgi?id=109867

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-03
Reviewed by Simon Fraser.

Source/WebCore:

Disable LayoutState when table, tableRow or tableSection render
objects have transforms or reflections.

Tests: fast/repaint/reflection-table-layout.html

fast/repaint/transform-table-layout.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

Create tests that resize an element inside a display: table element.
Compare to a reference html file where the element has a static size.
In the first test, the table like element has a transform. In the
second, it has a reflection.

  • fast/repaint/reflection-table-layout-expected.html: Added.
  • fast/repaint/reflection-table-layout.html: Added.
  • fast/repaint/transform-table-layout-expected.html: Added.
  • fast/repaint/transform-table-layout.html: Added.
8:43 PM Changeset in webkit [149549] by Antti Koivisto
  • 30 edits in trunk

Remove concept of younger and older shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=115570

Reviewed by Andreas Kling.

Source/WebCore:

Younger and older shadow trees are an obscure corner of the Shadow DOM spec.

Support only one shadow tree per element. This simplifies many things.

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):

  • dom/ComposedShadowTreeWalker.h:

(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(ComposedShadowTreeWalker):

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyDescendantInsertedIntoTree):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyDescendantRemovedFromTree):
(WebCore::ChildFrameDisconnector::collectFrameOwners):
(WebCore::assertConnectedSubrameCountIsConsistent):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):

  • dom/Element.cpp:

(WebCore::Element::authorShadowRoot):
(WebCore::Element::userAgentShadowRoot):
(WebCore::Element::ensureUserAgentShadowRoot):

  • dom/Element.h:

(Element):
(WebCore::Element::hasAuthorShadowRoot):

  • dom/Element.idl:
  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot):

Allow only one ShadowRoot per ElementShadow. Remove linked list handling.

(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::detach):
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
(WebCore::ElementShadow::recalcStyle):
(WebCore::ElementShadow::removeAllEventListeners):

  • dom/ElementShadow.h:

(WebCore::ElementShadow::shadowRoot):
(ElementShadow):
(WebCore::ElementShadow::host):
(WebCore::Node::shadowRoot):
(WebCore):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::showNodePathForThis):
(WebCore::traverseTreeAndMark):
(WebCore::showSubTreeAcrossFrame):

  • dom/Node.h:

(Node):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertedInto):

  • dom/ShadowRoot.h:

(ShadowRoot):

Remove LinkedList base.


  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
(WebCore::ContentDistributor::ensureSelectFeatureSet):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • page/FocusController.cpp:

(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::updateReferencedText):
(WebCore::SVGTRefElement::detachTarget):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildShadowTree):

  • testing/Internals.cpp:

(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

  • editing/text-iterator/basic-iteration-expected.txt:
  • editing/text-iterator/script-tests/basic-iteration.js:

(addShadowTreeWithDivElement):

  • fast/forms/resources/common-spinbutton-change-and-input-events.js:

(testSpinButtonChangeAndInputEvents):

  • fast/forms/resources/common-spinbutton-click-in-iframe.js:

(getSpinButton):

7:11 PM Changeset in webkit [149548] by commit-queue@webkit.org
  • 2 edits in trunk/PerformanceTests/SunSpider

SunSpider 1.0: 3d-morph: use epsilon to check result
​https://bugs.webkit.org/show_bug.cgi?id=115553

Patch by Cosmin Truta <​ctruta@blackberry.com> on 2013-05-03
Reviewed by George Staikos.

SunSpider/3d-morph should be more lenient in validating its results, since they depend on Math.sin, which isn't formally specified.

  • tests/sunspider-1.0/3d-morph.js:
7:07 PM Changeset in webkit [149547] by commit-queue@webkit.org
  • 1 edit
    9 adds in trunk/Tools

Create a script to import W3C tests
​https://bugs.webkit.org/show_bug.cgi?id=111513

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2013-05-03
Reviewed by Dirk Pranke.

Script to automate the import of W3C tests into WebKit.
For the full description of how it works, see the comments
at the top of test_importer.py.

  • Scripts/import-w3c-tests: Added.
  • Scripts/webkitpy/w3c/init.py: Added.
  • Scripts/webkitpy/w3c/test_converter.py: Added.

(TestConverter):
(TestConverter.init):
(TestConverter.load_prefixed_prop_list):
(TestConverter.load_file):
(TestConverter.convert_for_webkit):
(TestConverter.convert_testharness_paths):
(TestConverter.convert_prefixed_properties):
(TestConverter.scrub_unprefixed_props):
(TestConverter.replace_tag):

  • Scripts/webkitpy/w3c/test_converter_unittest.py: Added.

(TestConverterTest):
(TestConverterTest.testLoadPrefixedPropList):
(TestConverterTest.test_convertForWebkitNothingToConvert):
(test_convertForWebkitHarnessOnly):
(test_convertForWebkitPropsOnly):
(test_convertForWebkitHarnessAndProps):
(test_convertTestHarnessPaths):
(test_convertPrefixedProperties):
(verifyTestHarnessPaths):
(verifyPrefixedProperties):
(generateTestContent):

  • Scripts/webkitpy/w3c/test_importer.py: Added.

(main):
(parse_args):
(validate_import_directory):
(TestImporter):
(TestImporter.init):
(TestImporter.do_import):
(TestImporter.get_changeset):
(TestImporter.scan_source_directory):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.get_test_status):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):

  • Scripts/webkitpy/w3c/test_importer_unittest.py: Added.

(TestImporterTest):
(TestImporterTest.test_ImportDirWithNoTests):

  • Scripts/webkitpy/w3c/test_parser.py: Added.

(TestParser):
(TestParser.init):
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.get_reftests):
(TestParser.is_jstest):
(TestParser.get_support_files):

  • Scripts/webkitpy/w3c/test_parser_unittest.py: Added.

(TestParserTest):
(TestParserTest.test_analyzeTestReftestOneMatch):
(test_analyzeTestReftestMultipleMatches):
(test_analyzeTestReftestMatchAndMismatch):
(test_analyzeTestReftestWithRefSupportFiles):
(test_analyzeJSTest):
(test_analyzePixelTestAllTrue):
(test_analyzePixelTestAllFalse):
(test_analyzeNonHTMLFile):

5:40 PM May 2013 Meeting edited by rniwa@webkit.org
Add a link to binding generators script (diff)
5:08 PM May 2013 Meeting edited by betravis@adobe.com
(diff)
5:03 PM Changeset in webkit [149546] by Martin Robinson
  • 5 edits in trunk/Source/WebCore

Simplify the #ifdefs in GraphicsContext3D.h
​https://bugs.webkit.org/show_bug.cgi?id=115568

Reviewed by Daniel Bates.

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D): Combine #ifdefs paths that have a common
implementation. This reduces the #ifdef paths from many to just three.

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::platformTexture): Move the implementation
here to simplify the header.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::platformTexture): Ditto.
(WebCore):

4:50 PM Changeset in webkit [149545] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed. Update Viatcheslav Ostapenko's email in contributors.json.

  • Scripts/webkitpy/common/config/contributors.json:
4:44 PM Changeset in webkit [149544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Build with --video-track fails because String(AtomicString) is ambiguous
​https://bugs.webkit.org/show_bug.cgi?id=115551

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-05-03
Reviewed by Benjamin Poulain.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup):
Change String(textTrack->kind()) to textTrack->kind().string(), and same thing with language.

4:41 PM Improving the DOM now that we only have 1 JS engine / the removal of ScriptState! created by jonlee@apple.com
4:40 PM May 2013 Meeting edited by jonlee@apple.com
(diff)
4:12 PM Changeset in webkit [149543] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
​https://bugs.webkit.org/show_bug.cgi?id=115575

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-05-03
Reviewed by Philippe Normand.

No new tests needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

Using extern debug category.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Declaring debug category as not static.

3:19 PM Changeset in webkit [149542] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Page rendering scale is changed after go back and forward
​https://bugs.webkit.org/show_bug.cgi?id=115573

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-05-03.
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers.

PR: 326886
When navigating back from page A with viewport to page B without
viewport, we didn't call setViewMode(); therefore, we didn't change
the fixed layout size which was set by page A. In that case, WebCore
would just pick up page A's fixed layout size to layout page B which
caused this issue.
Expecting zoomToInitialScaleOnLoad() or other functions to setViewMode()
later is not a good way, because zoomToInitialScaleOnLoad() has never
been called in this case. So we should always call setViewMode() to set
fixed layout size when a new page is committed.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):

3:14 PM Changeset in webkit [149541] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed VS2010 Build Correction.

  • WebCore.vcxproj/WebCore.vcxproj: Exclude CG-only

SubimageCacheWithTimer.cpp from WinCairo build.

3:12 PM Changeset in webkit [149540] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[Cairo] Anti-aliasing should not be always disabled for lines
​https://bugs.webkit.org/show_bug.cgi?id=109535

Patch by Viatcheslav Ostapenko <​viatchslav.o@samsung.com> on 2013-05-03
Reviewed by Martin Robinson.

Source/WebCore:

Don't disable antialiasing for text lines because it produces ugly picture if
page is scaled.

Test: fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::drawLineOnCairoContext):

LayoutTests:

Add pixel test with scaled text lines.

  • fast/css3-text/css3-text-decoration/text-decoration-line-scaled.html: Added.
  • platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.png: Added.
  • platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt: Added.
2:41 PM Changeset in webkit [149539] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary include HTMLNames.h from RenderThemeGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=115571

Reviewed by Martin Robinson.

  • platform/gtk/RenderThemeGtk.cpp:
2:18 PM Changeset in webkit [149538] by ggaren@apple.com
  • 81 edits in branches/dfgFourthTier

Rolled out r149527 because it caused a crash.

Source/JavaScriptCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebCore:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit/mac:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Source/WebKit2:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

LayoutTests:

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

2:06 PM May 2013 Meeting edited by betravis@adobe.com
(diff)
1:56 PM Changeset in webkit [149537] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] setMetadataURL incorrectly treats path bytes as Latin-1
​https://bugs.webkit.org/show_bug.cgi?id=115557

Reviewed by Sam Weinig.

  • platform/mac/FileSystemMac.mm: (WebCore::setMetaData): Use the correct constructor.
1:56 PM Changeset in webkit [149536] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

PDFPlugin: Changes being made to active annotation aren't saved when the PDF is exported
​https://bugs.webkit.org/show_bug.cgi?id=115544
<rdar://problem/13801789>

Reviewed by Alexey Proskuryakov.

Commit changes to the active annotation (if there is one) before
returning the live PDF data, so that said changes are represented
in the exported or printed output.

  • WebProcess/Plugins/PDF/PDFPlugin.h: Override liveData.
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::liveData): Commit the active annotation if there is one.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:

(SimplePDFPlugin): Make liveData virtual.

1:56 PM Changeset in webkit [149535] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
​https://bugs.webkit.org/show_bug.cgi?id=115056
<rdar://problem/13719543>

Reviewed by Simon Fraser.

Null-check m_page. In theory, we shouldn't get here, because we stop
the timer at the only point where m_page is cleared, but crash logs say
we're still crashing here.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):

1:55 PM Changeset in webkit [149534] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove some "what" comments from FindController
​https://bugs.webkit.org/show_bug.cgi?id=115546

Reviewed by Andreas Kling.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::willMoveToWebPage):
(WebKit::FindController::mouseEvent):
Remove or reword some comments.

1:48 PM Changeset in webkit [149533] by abucur@adobe.com
  • 4 edits in trunk/Source/WebCore

Move pixelSnappedLayoutOverflowRect and maxLayoutOverflow from RenderBox
​https://bugs.webkit.org/show_bug.cgi?id=115550

Reviewed by Simon Fraser.

The patch moves pixelSnappedLayoutOverflowRect and maxLayoutOverflow out
of RenderBox somewhere logically closer to their usage place.

pixelSnappedLayoutOverflowRect - moved to RenderView because it's called only
for RenderView at this moment.
There are other places when the overflow rect is pixel snapped but only after
the rect is adjusted for writing modes or inflated.

maxLayoutOverflow - moved to RenderTreeAsText.cpp as a static function because
it's used only there.

Tests: no new functional change.

  • rendering/RenderBox.h: The functions declarations are removed.
  • rendering/RenderTreeAsText.cpp:

(WebCore::maxLayoutOverflow):

  • rendering/RenderView.h:

(WebCore::RenderView::pixelSnappedLayoutOverflowRect):

1:43 PM Changeset in webkit [149532] by akling@apple.com
  • 11 edits in trunk/Source

StyleResolver: Have "list of matched rules" API vend internal types instead of CSSOM wrappers.
<​http://webkit.org/b/115563>

Reviewed by Antti Koivisto.

Source/WebCore:

Change styleRulesForElement() and pseudoStyleRulesForElement() to return Vectors of StyleRuleBase
instead of CSSRuleLists. This defers instantiating CSSOM wrappers until they're actually needed
for exposure to web API.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

Create a StaticCSSRuleList and populate it with CSSOM wrappers for the matched rules.
This is the one place where we expose this functionality to the web.

  • css/ElementRuleCollector.h:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):

Collect internal StyleRuleBase pointers here instead of creating wrappers.

  • css/StyleResolver.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):

Vend said pointers.

  • editing/EditingStyle.cpp:

(WebCore::styleFromMatchedRulesForElement):

Dodge CSSOM wrapper instantiation (Woop woop!)

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildObjectForRule):

Split buildObjectForRule() into two versions, one for CSSStyleRule and one for StyleRule.
The CSSStyleRule one doesn't need a special path for parent-less rules, since those always
come in through the StyleRule interface instead. This factoring can be improved further
after this change.

(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

Tweaked for changes in StyleResolver API.

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

Tweaked for changes in StyleResolver API.

1:29 PM Changeset in webkit [149531] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r145042): Downloading a file sometimes results in could not create
a sandbox extension Console message and file stays as a .download file
​https://bugs.webkit.org/show_bug.cgi?id=115559
<rdar://problem/13785101>

Reviewed by Sam Weinig.

CString is evil, it has two lengths which can be different - specifically, fileSystemRepresentation()
creates a string with maximum possible buffer size. This was confusing resolveSymlinksInPath().

  • platform/cf/FileSystemCF.cpp: (WebCore::fileSystemRepresentation): Change fileSystemRepresentation to be less surprising. Really, we should rip apart CString and update callers to use better defined semantics, but this is the one function that repeatedly causes problems in practice.
1:27 PM Changeset in webkit [149530] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

CSSRule style declarations getters shouldn't be const.
<​http://webkit.org/b/115572>

Reviewed by Antti Koivisto.

Accessing the CSSStyleDeclaration for a CSSRule is a potentially mutating operation,
and should not be const.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):

  • css/CSSFontFaceRule.h:
  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):

  • css/CSSPageRule.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):

  • css/CSSStyleRule.h:

(CSSStyleRule):

  • css/WebKitCSSFilterRule.cpp:

(WebCore::WebKitCSSFilterRule::style):

  • css/WebKitCSSFilterRule.h:
  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::style):

  • css/WebKitCSSKeyframeRule.h:

(WebKitCSSKeyframeRule):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::style):

  • css/WebKitCSSViewportRule.h:
12:31 PM Changeset in webkit [149529] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Use NotNull tag for placement new in WebCore.
<​http://webkit.org/b/115569>

Reviewed by Antti Koivisto.

Avoid emitting null checks where we use placement new to construct objects into safe locations.

  • css/StylePropertySet.cpp:

(WebCore::ImmutableStylePropertySet::create):

  • dom/Element.cpp:

(WebCore::ShareableElementData::createWithAttributes):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::init):
(WebCore::createQualifiedName):

  • dom/make_names.pl:

(printNamesCppFile):

  • platform/ThreadGlobalData.h:

(WebCore::threadGlobalData):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createForMixedFontData):

12:11 PM Changeset in webkit [149528] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify CSSSelectorList creation/adoption.
<​http://webkit.org/b/106649>

Reviewed by Antti Koivisto.

Remove the optimization that special-cased construction of CSSSelectorLists with a single entry.
This is in preparation for changing the way we store the selector lists on style rules.

  • css/CSSParser.h:
  • css/CSSSelector.h:

Remove move(PassOwnPtr<CSSSelector> from, CSSSelector* to), inlining it into
CSSSelectorList::adoptSelectorVector instead.

  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::deleteSelectors):

Handle all selector list lengths the same way.

(WebCore::CSSSelectorList::adoptSelectorVector):

Merge move() from CSSSelector.h into this code since it was the only call site.
Also some minor readability cleanups.

11:46 AM Changeset in webkit [149527] by ggaren@apple.com
  • 81 edits in branches/dfgFourthTier

Rationalized 'this' value conversion
​https://bugs.webkit.org/show_bug.cgi?id=115542

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This fixes a bunch of Sputnik tests.

The new model is that the callee always performs 'this' value conversion.

My ultimate goal is to break up resolve_with_this into single-result
opcodes. This step avoids having to add a new kind of convert_this for
call sites.

  • API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call): Perform 'this' value conversion for
our callee, since it may observe 'this'.

  • API/JSCallbackObjectFunctions.h:

(JSC::::call): Ditto.

  • API/JSContextRef.cpp:

(JSGlobalContextCreateInGroup): Use a proxy 'this' object in global scope
even when we're not in the browser. This eliminates some odd cases where
API clients used to be able to get a direct reference to an environment
record. Now, any reference to an environment record unambiguously means
that the VM resolved that record in the scope chain.

(JSContextGetGlobalObject): Removed an incorrect comment. Now that JSC
participates in the proxy 'this' object scheme, the behavior is not
WebCore-only.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

What are the chances that this will work?

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock): Renamed convert_this to to_this, to match our
other conversion opcodes.

  • bytecode/CodeOrigin.h:

(CodeOrigin):
(InlineCallFrame):
(JSC::CodeOrigin::codeOriginOwner): Use the more precise type for our
executable, so compilation can discover where we're in strict mode.

  • bytecode/Opcode.h:

(JSC::padOpcodeName): Updated for rename.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Always emit to_this when
'this' is in use -- strict mode still needs to convert environment
records to 'undefined'.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode): Updated for renames.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Tightened up this code to consider
strict mode (a new requirement) and to consider the global object (which
was always a requirement).

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::globalThisObjectFor):
(JSC::DFG::Graph::executableFor):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Ditto.

  • interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):

  • interpreter/Interpreter.h: Don't ASSERT about 'this' -- it's our job

to fix it up if needed.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JIT):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emitSlow_op_to_this):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h: Removed special case code for various kinds of

conversions. The baseline fast path is now only final objects. It hurt
my brain to think through how to keep the other fast paths working, and
our benchmarks do not object.

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

  • runtime/CallData.cpp:

(JSC::call):

  • runtime/ClassInfo.h:

(MethodTable):
(JSC):

  • runtime/Completion.cpp:

(JSC::evaluate):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToJSON):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::toThis):

  • runtime/JSActivation.h:

(JSActivation):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toThisSlowCase):

  • runtime/JSCJSValue.h:

(JSValue):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::toThis):

  • runtime/JSCell.cpp:

(JSC::JSCell::toThis):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::toThis):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • runtime/JSNameScope.cpp:

(JSC::JSNameScope::toThis):

  • runtime/JSNameScope.h:

(JSNameScope):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::toThis):

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSScope.cpp:

(JSC::JSScope::resolveWithThis):

  • runtime/JSString.cpp:

(JSC::JSString::toThis):

  • runtime/JSString.h:

(JSString):

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter):

  • runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayEntry::get):
(JSC::SparseArrayEntry::put):

  • runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::toThis):

  • runtime/StrictEvalActivation.h:

(StrictEvalActivation): Filled out runtime support for converting 'this'
values as needed, according to the strictness of the caller.

Source/WebCore:

Updated to match JSC requirement that the callee performs 'this' value
conversion.

  • WebCore.order:
  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::internalConstructorName):

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::call):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bridge/NP_jsobject.cpp:

(_NPN_Invoke):

Source/WebKit/mac:

Updated to match JSC requirement that the callee performs 'this' value
conversion.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Updated to match JSC requirement that the callee performs 'this' value
conversion.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::invoke):

LayoutTests:

We pass these tests now:

  • sputnik/Conformance/11_Expressions/11.1_Primary_Expressions/11.1.1_The_this_Keyword/S11.1.1_A2-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.11_String.prototype.replace/S15.5.4.11_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.6_String.prototype.concat/S15.5.4.6_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A1_T3-expected.txt:
  • sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A1_T3-expected.txt:
11:26 AM Changeset in webkit [149526] by Stephanie Lewis
  • 1 edit
    1 add in trunk/LayoutTests

Revert to old results on Lion.

Unreviewed.

Results were updated in (​http://trac.webkit.org/changeset/149503) but that is compiled
out on Lion (​http://trac.webkit.org/changeset/149510).

  • platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.
11:08 AM Changeset in webkit [149525] by Antti Koivisto
  • 18 edits
    3 deletes in trunk/Source/WebCore

Remove HTMLShadowElement
​https://bugs.webkit.org/show_bug.cgi?id=115555

Reviewed by Andreas Kling.

This is not used internally.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedShadowTreeWalker.cpp:
  • dom/NodeRenderingContext.cpp:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

  • html/shadow/HTMLShadowElement.cpp: Removed.
  • html/shadow/HTMLShadowElement.h: Removed.
  • html/shadow/HTMLShadowElement.idl: Removed.
  • page/DOMWindow.idl:
11:08 AM Changeset in webkit [149524] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WTF

Make ThreadFunctionInvocation fast allocated.
​https://bugs.webkit.org/show_bug.cgi?id=115552

Reviewed by Benjamin Poulain.

  • wtf/ThreadFunctionInvocation.h:

(ThreadFunctionInvocation): Make Fast-allocated.

10:12 AM Changeset in webkit [149523] by mikhail.pozdnyakov@intel.com
  • 12 edits
    1 delete in trunk/Source

Remove WTF::ListRefPtr class
​https://bugs.webkit.org/show_bug.cgi?id=115516

Reviewed by Anders Carlsson.

ListRefPtr was used only by FontFamily class, besides it strongly depended
on FontFamily class semantics which made it non-generic and inappropriate
for being present inside WTF.

This patch removes WTF::ListRefPtr class and moves its the functionality
into FontFamily class.

Source/WebCore:

No new tests, no change in the behavior.

  • page/FrameTree.h:

(FrameTree):

  • platform/graphics/FontFamily.h:

(FontFamily):
(WebCore::FontFamily::~FontFamily):
(WebCore):

Source/WTF:

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Forward.h:

(WTF):

  • wtf/ListRefPtr.h: Removed.
9:58 AM Changeset in webkit [149522] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip some failing tests after r149504.

  • platform/efl/TestExpectations:
3:35 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Adding r149486 as a proposed merge. (diff)
3:02 AM WebKitGTK/2.0.x edited by agarcia@igalia.com
(diff)
2:34 AM Changeset in webkit [149521] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Crash when calling QWebFrame::evaluateJavaScript
​https://bugs.webkit.org/show_bug.cgi?id=113434

Reviewed by Simon Hausmann.

We must take the JS API lock before accessing internal JS methods.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::unwrapBoxedPrimitive):
(JSC::Bindings::getGregorianDateTimeUTC):
(JSC::Bindings::convertQVariantToValue):

12:45 AM May 2013 Meeting edited by Joseph Pecoraro
Added Merging iOS WebKit notes (diff)
12:10 AM Changeset in webkit [149520] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2][CustomProtocols] NSURLProtocolClient methods should be dispatched on NSURLConnection's resource loader run loop
​https://bugs.webkit.org/show_bug.cgi?id=115539

Reviewed by Alexey Proskuryakov.

It turns out that calling NSURLProtocolClient methods from a different
thread than the one running the NSURLConnection run loop is unsafe.
Although I can't capture it reliably in a test case, doing so can
sometimes result in a load timing out because the call to
-[NSURLProtocolClient URLProtocolDidFinishLoading:] was ignored by
NSURLConnection.

Fix this by dispatching these methods on the NSURLConnection resource
load run loop. This matches where NSURLProtocolClient methods are
dispatched by typical NSURLProtocol implementations, and in my testing
this solves the timeout issue.

  • Shared/Network/CustomProtocols/CustomProtocolManager.h: Declare

dispatchOnResourceLoaderRunLoop().

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

Declare +[NSURLConnection resourceLoaderRunLoop] on a category of
NSURLConnection. Also include the header that declares it if it's present.
(WebKit::CustomProtocolManager::didFailWithError): Call the
NSURLProtocolClient method via dispatchOnResourceLoaderRunLoop().
(WebKit::CustomProtocolManager::didLoadData): Ditto.
(WebKit::CustomProtocolManager::didReceiveResponse): Ditto.
(WebKit::CustomProtocolManager::didFinishLoading): Ditto.
(WebKit::CustomProtocolManager::dispatchOnResourceLoaderRunLoop):
Dispatch a block on the NSURLConnection resource loader run loop and
then wake up the run loop.

12:05 AM May 2013 Meeting edited by Joseph Pecoraro
Added Web Inspector talk notes (diff)

May 2, 2013:

11:47 PM Changeset in webkit [149519] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fine tune dependencies for glslang generated files
​https://bugs.webkit.org/show_bug.cgi?id=115537

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-05-02
Reviewed by Martin Robinson.

Make glslang.* explictly depend on glslang_tab.*, since the
dependency does exist. Otherwise Make might decide to compile
things ahead of time and fail.

  • GNUmakefile.am:
11:46 PM Changeset in webkit [149518] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Profiler should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115445

Reviewed by Geoffrey Garen.

Change the Profiler::Database API for Compilation creation so that we don't add
it to the Database until it's completely constructed. This prevents the Database
from seeing Compilations that are being concurrently constructed.

Change the Profiler::Database itself to do locking for creation of Bytecodes and
for modifying the map. This map may be consulted by both the main thread and the
concurrent thread.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • profiler/ProfilerBytecodes.h:
  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::notifyDestruction):
(JSC::Profiler::Database::addCompilation):

  • profiler/ProfilerDatabase.h:

(Database):

10:20 PM May 2013 Meeting - Unifying Build Systems - Notes edited by mark.salisbury@hp.com
minor edits; fixed referenced bug # (diff)
10:01 PM Changeset in webkit [149517] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build warnings on ResourceHandleClient.h
​https://bugs.webkit.org/show_bug.cgi?id=115540

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2013-05-02
Reviewed by Alexey Proskuryakov.

Comment out the parameter names for 'getOrCreateReadBuffer' to fix -Wunused-parameter build warnings.

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::getOrCreateReadBuffer):

8:29 PM May 2013 Meeting - Unifying Build Systems - Notes created by jmason@blackberry.com
8:17 PM May 2013 Meeting edited by jmason@blackberry.com
link to Unifying Build Systems notes (diff)
7:57 PM Changeset in webkit [149516] by fpizlo@apple.com
  • 41 edits
    3 adds in branches/dfgFourthTier/Source

fourthTier: DFG tries to ref/deref StringImpls in a ton of places
​https://bugs.webkit.org/show_bug.cgi?id=115300

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Change any code transitively called from DFG compilation to use StringImpl*
directly instead of String, Identifier, or PropertyName. I use the convention
of passing "StringImpl* uid" instead of an Identifier or PropertyName.

Switch over any code transitively called from DFG compilation to use CStrings
whenever possible for all of its debug dumping.

This makes it possible to compile things without hitting the ref/deref
assertion in StringImpl.

(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):
(JSC::pointerToSourceString):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dumpBytecode):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::CodeBlockHash):

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::inferredName):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC):
(GetByIdStatus):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(JSC):
(PutByIdStatus):

  • bytecode/ReduceWhitespace.cpp:

(JSC::reduceWhitespace):

  • bytecode/ReduceWhitespace.h:

(JSC):

  • bytecode/ResolveGlobalStatus.cpp:

(JSC::computeForStructure):
(JSC::ResolveGlobalStatus::computeFor):

  • bytecode/ResolveGlobalStatus.h:

(JSC):
(ResolveGlobalStatus):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDesiredIdentifiers.cpp: Added.

(DFG):
(JSC::DFG::DesiredIdentifiers::DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::~DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • dfg/DFGDesiredIdentifiers.h: Added.

(DFG):
(DesiredIdentifiers):
(JSC::DFG::DesiredIdentifiers::numberOfIdentifiers):
(JSC::DFG::DesiredIdentifiers::at):
(JSC::DFG::DesiredIdentifiers::operator[]):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::tryBuildGetByIDList):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • parser/SourceCode.cpp: Added.

(JSC):
(JSC::SourceCode::toUTF8):

  • parser/SourceCode.h:

(SourceCode):

  • profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::toJS):

  • profiler/ProfilerBytecodes.h:

(JSC::Profiler::Bytecodes::inferredName):
(JSC::Profiler::Bytecodes::sourceCode):
(Bytecodes):

  • runtime/Identifier.h:

(JSC::Identifier::utf8):
(JSC):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::prototypeChainMayInterceptStoreTo):
(JSC):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

Source/WTF:

Reviewed by Geoffrey Garen.

Make it possible to do more things directly to StringImpl*'s, including being
able to directly do utf8 conversion on a substring without creating the
substring first.

Add assertions to StringImpl that it isn't being ref/deref'd from the
compilation thread.

  • wtf/PrintStream.cpp:

(WTF::printInternal):
(WTF):

  • wtf/PrintStream.h:

(WTF):
(WTF::printInternal):

  • wtf/StringPrintStream.h:

(WTF):
(WTF::toCString):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8ForRange):
(WTF::StringImpl::utf8):
(WTF):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::hasAtLeastOneRef):
(WTF::StringImpl::ref):
(WTF::StringImpl::deref):

6:06 PM Changeset in webkit [149515] by roger_fong@apple.com
  • 4 edits in trunk/Source

Following r149463, set Path for WebCore and WebKit makefile as well.

  • WebKit.vcxproj/WebKit.make:
6:02 PM May 2013 Meeting edited by kov@webkit.org
(diff)
5:38 PM Changeset in webkit [149514] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip html5lib test cases that were skipped due to failure after r143804.

  • platform/efl/TestExpectations:
5:25 PM Changeset in webkit [149513] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk/Source/WTF

[WinCairo] Unreviewed build fix.

  • WTF.vcxproj/WTF.vcxproj: Use WinCairo FeatureDefines
  • WTF.vcxproj/WTF.vcxproj.filters: Use WinCairo FeatureDefines
  • WTF.vcxproj/WTFDebugWinCairo.props: Added.
  • WTF.vcxproj/WTFReleaseWinCairo.props: Added.
5:09 PM Changeset in webkit [149512] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure transition table keys don't have to ref their StringImpl's
​https://bugs.webkit.org/show_bug.cgi?id=115525

Reviewed by Geoffrey Garen.

The structure transition table basically maps string to structure. The string is
always also stored, and ref'd, in the structure in Structure::m_nameInPrevious.
m_nameInPrevious is never mutated, and never cleared. The string cannot die unless
the structure dies. If the structure dies, then that entry in the transition map
becomes a zombie anyway and we will detect this separately.

So, we don't need to use RefPtr<StringImpl>. We can just use StringImpl*.

This also fixes a goof where we were getting the StringImpl's hash rather than
using a pointer hash. Not only is the latter faster, but it prevents my change
from leading to crashes: with my change we can have zombie keys, not just zombie
values. They will exist only until the next map mutation, which will clear them.
Lookups will work fine because the lookup routine will reject zombies. But it
does mean that the HashMap will have to deal with dangling StringImpl*'s; all it
takes to make this work is to ensure that the HashMap itself never dereferences
them. Using a pointer hash rather than StringImpl::existingHash() accomplishes
this.

This also ensures that we don't accidentally call ref() or deref() from the
compilation thread, if the compilation thread inspects the transition table.

And no, we wouldn't have been able to use the HashMap<RefPtr<...>, ...>
specialization, because the transition table is actually
HashMap<pair<RefPtr<StringImpl>, unsigned>, ...>: hence that specialization
doesn't kick in. We could have written a new specialization or something, but
that seemed like a lot of work given that we don't need the table to be ref'ing
the strings anyways.

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::add):

  • runtime/StructureTransitionTable.h:

(StructureTransitionTable):
(Hash):
(JSC::StructureTransitionTable::Hash::hash):

5:04 PM Changeset in webkit [149511] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Unreviewed Windows build fix.

  • win/lib/WebKitSystemInterface.lib:
5:04 PM Changeset in webkit [149510] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed fix for Mac Lion build after r149503.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
5:01 PM Changeset in webkit [149509] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WTF

[Windows, WinCairo] Fix crash in fast/js/create-lots-of-workers.html
​https://bugs.webkit.org/show_bug.cgi?id=115130

Reviewed by Tim Horton.

Windows is suffering from mismatched allocation/deallocation
between the system allocator and fastMalloc/fastFree. By turning
off the global switch to fastMalloc, only classes specified to
honor fastMalloc/fastFree are affected, and other memory allocation
and freeing is done with consistent library calls.

  • wtf/Platform.h: Deactivate ENABLE_GLOBAL_FASTMALLOC_NEW for

the Windows build.

5:00 PM Changeset in webkit [149508] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: Move Mac-only symbols into the shared symbol list

  • WebCore.exp.in: Move symbols.
4:56 PM Changeset in webkit [149507] by Antti Koivisto
  • 10 edits
    2 deletes in trunk/Source/WebCore

Shadow DOM removal: Get rid of ContentSelectorQuery
​https://bugs.webkit.org/show_bug.cgi?id=115533

Reviewed by Anders Carlsson.

This is only used for Shadow DOM distribution. <details> element works fine without it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distributeSelectionsTo):

  • html/shadow/ContentSelectorQuery.cpp: Removed.
  • html/shadow/ContentSelectorQuery.h: Removed.
  • html/shadow/HTMLContentElement.cpp:
4:49 PM May 2013 Meeting edited by Bem Jones-Bey
(diff)
4:39 PM Changeset in webkit [149506] by ryuan.choi@samsung.com
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Moved XFrameOptions results from efl-wk2 to efl and rebased source-list-parsing-nonascii.html

  • platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
  • platform/efl/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Renamed from LayoutTests/platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
  • platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Added.
4:34 PM Changeset in webkit [149505] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip WebAudio test cases on EFL WK2.

  • platform/efl-wk2/TestExpectations:
4:33 PM Changeset in webkit [149504] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

border-radius clipping a canvas does not always clip
​https://bugs.webkit.org/show_bug.cgi?id=113343

Source/WebCore:

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

clipToRect method clip context to clipRect, and then clip to rounded
rect if clipRect has a radius. But currently, clipToRect exit early if
clipToRect is equal to paintDirtyRect.

This patch allows clipping to rounded corner ever if clipToRect is
equal to paintDirtyRect.

Test: fast/overflow/border-radius-clipping-2.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

LayoutTests:

Create a test that draws a canvas into a clipped overflown div with
radius corner. Then redraw that same thing a moment later. The canvas
should stay correctly clipped the second time.

Patch by Arnaud Renevier <​a.renevier@sisa.samsung.com> on 2013-05-02
Reviewed by Simon Fraser.

  • fast/overflow/border-radius-clipping-2-expected.html: Added.
  • fast/overflow/border-radius-clipping-2.html: Added.
4:07 PM May 2013 Meeting edited by betravis@adobe.com
(diff)
4:06 PM Changeset in webkit [149503] by eric.carlson@apple.com
  • 18 edits
    2 copies in trunk

Caption menu does not include in-band captions
​https://bugs.webkit.org/show_bug.cgi?id=111934

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, upated existing tests for these changes.

  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::loadInternal): Clear the LoadMediaResource from m_pendingActionFlags

in case there is a pending async load.

(WebCore::HTMLMediaElement::configureTextTrackGroup): Always log the track score.
(WebCore::HTMLMediaElement::configureTextTracks): Call configureTextTrackDisplay so

m_legacyWebKitClosedCaptionsVisible is always updated immediately.

(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Use m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Ditto.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::CaptionUserPreferences): Initialize m_displayMode to ForcedOnly

because it is no longer used for testing only.

(WebCore::CaptionUserPreferences::notify): Post notifications when not in testing-only mode.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate a track score when

webkitClosedCaptionsVisible has been set.

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Don't filter track list when we

don't have the media accessibility framework. Make logging more informative.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:

(WebCore::InbandTextTrackPrivateAVFObjC::create): Take a AVFInbandTrackParent instead of a

MediaPlayerPrivateAVFoundationObjC.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC): Ditto.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm: Added.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): We only have legible output when

HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT is defined.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create a legacy CC track if

there are no media selection options and there is a CC AVAssetTrack.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyCCTracks): New, process CC tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processNewAndRemovedTextTracks): New, refactored

common setup/cleanup code from processMediaSelectionOptions.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Renamed from

processTextTracks. Move common setup/cleanup code to processNewAndRemovedTextTracks.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Deal with legacy CC tracks.

Source/WTF:

  • wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT on 10.8 and higher. Added

HAVE_AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT.

LayoutTests:

  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
3:57 PM Changeset in webkit [149502] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] caption track menu includes "easy to read" in-band tracks twice
​https://bugs.webkit.org/show_bug.cgi?id=115529

Reviewed by Dean Jackson.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Check to see if a track is

easy-to-read after checking if it is forced only.

3:41 PM Changeset in webkit [149501] by Antti Koivisto
  • 7 edits
    1 delete in trunk/Source/WebCore

Remove SiblingTraversalStrategies.h
​https://bugs.webkit.org/show_bug.cgi?id=115532

Reviewed by Andreas Kling.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/SiblingTraversalStrategies.h: Removed.
3:39 PM Changeset in webkit [149500] by Lucas Forschler
  • 4 edits in tags/Safari-537.40/Source/WebKit2

Merged r149499. <rdar://problem/13795795>

3:23 PM Changeset in webkit [149499] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

REGRESSION (149389) Main resources converted to downloads are immediately cancelled.
<rdar://problem/13795795> and ​https://bugs.webkit.org/show_bug.cgi?id=115530

Reviewed by Alexey Proskuryakov.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload): Call didConvertHandleToDownload

on the NetworkResourceLoader.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload): Set m_handleConvertedToDownload to true.
(WebKit::NetworkResourceLoader::abort): Only cancel the handle if m_handleConvertedToDownload is false.

  • NetworkProcess/NetworkResourceLoader.h:
3:13 PM Changeset in webkit [149498] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Shadow DOM removal: Make SelectorChecker non-generic
​https://bugs.webkit.org/show_bug.cgi?id=115526

Reviewed by Andreas Kling.

Without Shadow DOM distribution we don't need SiblingTraversalStrategies anymore.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • css/SelectorChecker.cpp:

(WebCore):
(WebCore::isFirstChildElement):
(WebCore::isLastChildElement):
(WebCore::isFirstOfType):
(WebCore::isLastOfType):
(WebCore::countElementsBefore):
(WebCore::countElementsOfTypeBefore):
(WebCore::countElementsAfter):
(WebCore::countElementsOfTypeAfter):
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/SiblingTraversalStrategies.h:
  • css/StyleResolver.h:

(WebCore::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorDataList::checkContentSelector):

3:10 PM May 2013 Meeting edited by msaboff@apple.com
(diff)
3:09 PM May 2013 Meeting edited by msaboff@apple.com
(diff)
2:33 PM Changeset in webkit [149497] by joone.hur@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

  • platform/efl-wk2/TestExpectations:
1:59 PM Changeset in webkit [149496] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix potential bug in lookup logic
​https://bugs.webkit.org/show_bug.cgi?id=115522

Reviewed by Mark Hahnenberg.

Though not a problem in practise, it is technically possible
to inject an un-proxied global object into the scope chain
via the C API. This change makes sure that the scope walk
in BytecodeGenerator actually limits itself to scopes that
are statically bindable.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):

  • runtime/JSObject.h:

(JSObject):
(JSC):
(JSC::JSObject::isStaticScopeObject):

1:56 PM Changeset in webkit [149495] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify WebCoreObjCExtras by using WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=115524

Reviewed by Andreas Kling.

  • platform/mac/WebCoreObjCExtras.mm:

(deallocCallback):
(WebCoreObjCScheduleDeallocateOnMainThread):

1:49 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
1:43 PM Changeset in webkit [149494] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated WebKitGTK+ Translation for Odia [or] language.
​https://bugs.webkit.org/show_bug.cgi?id=115030

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.

  • or.po: updated translation.
1:42 PM Changeset in webkit [149493] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WTF

Make BloomFilter fast allocated.
​https://bugs.webkit.org/show_bug.cgi?id=115519

Reviewed by Benjamin Poulain.

  • wtf/BloomFilter.h:

(BloomFilter): Make BloomFilter Fast-allocated.

1:17 PM May 2013 Meeting edited by timothy_horton@apple.com
Make the schedule words bigger! (diff)
1:00 PM Changeset in webkit [149492] by thakis@chromium.org
  • 1 edit
    1 delete in trunk/Tools

Remove a stale script file.
​https://bugs.webkit.org/show_bug.cgi?id=115521

Reviewed by Anders Carlsson.

This script was added in
​https://bugs.webkit.org/show_bug.cgi?id=17507, but it relies on the
Bakefile system that was removed in
​https://bugs.webkit.org/show_bug.cgi?id=49983 . As a result, this
script just asserts when it's run and is useless.

  • Scripts/update-sources-list.py: Removed.
12:27 PM May 2013 Meeting edited by cavalcantii@gmail.com
(diff)
12:26 PM Changeset in webkit [149491] by ap@apple.com
  • 6 edits in trunk/Source

<rdar://problem/13740375> Non-ASCII downloaded file names are garbled when using NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=115520

Reviewed by Darin Adler.

  • Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::::encodePlatformData): (CoreIPC::::decodePlatformData): Send the encoding fallback array over IPC, so that it's present when NetworkProcess does its loading.
12:17 PM May 2013 Meeting edited by cavalcantii@gmail.com
(diff)
11:33 AM May 2013 Meeting edited by rniwa@webkit.org
Remove "proposed" from both sections since they have been voted on (diff)
11:33 AM Changeset in webkit [149490] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Cannot touch scroll readonly text input.
​https://bugs.webkit.org/show_bug.cgi?id=115378

Patch by Genevieve Mak <​gmak@rim.com> on 2013-05-02
Reviewed by Rob Buis.

PR #332902
Reviewed Internally by Mike Fenton.
Forgot half the patch.
Node::rendererIsEditable() returns false if the input element has the readonly tag set.
Check the node type instead.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

11:32 AM May 2013 Meeting edited by rniwa@webkit.org
More prune & merge (diff)
11:30 AM May 2013 Meeting edited by rniwa@webkit.org
Prune & merge (diff)
11:28 AM May 2013 Meeting edited by rniwa@webkit.org
Add back the location info. (diff)
11:25 AM May 2013 Meeting edited by Beth Dakin
(diff)
10:45 AM Changeset in webkit [149489] by Lucas Forschler
  • 2 edits in tags/Safari-537.40/Source/WebKit2

Merged r149488. <rdar://problem/13787297>

9:56 AM Changeset in webkit [149488] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r149422): -[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]
broken when second argument is nil
​https://bugs.webkit.org/show_bug.cgi?id=115505
<rdar://problem/13787297>

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadFile): Pass a URL string to assumeReadAccessToBaseURL, as this is what it takes.
8:52 AM Changeset in webkit [149487] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
​https://bugs.webkit.org/show_bug.cgi?id=115178

Patch by Iris Wu <​shuwu@blackberry.com> on 2013-05-02
Reviewed by Rob Buis.

PR 308796
Debug build fix.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):

7:22 AM Changeset in webkit [149486] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit/gtk

Segmentation Fault with Romanian locale. Evolution not starting.
​https://bugs.webkit.org/show_bug.cgi?id=115484

Reviewed by Darin Adler.

Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.

  • webkit/webkitviewportattributes.cpp:

(webkit_viewport_attributes_class_init):

7:06 AM WebKit Team edited by Alexandru Chiculita
(diff)
5:49 AM Changeset in webkit [149485] by zarvai@inf.u-szeged.hu
  • 14 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed. Some more gardening after r149292.
​https://bugs.webkit.org/show_bug.cgi?id=115372

  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.png:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.png:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/filters/filtered-compositing-descendant-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.txt:
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt:
  • platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt:
  • platform/qt-5.0-wk2/svg/custom/glyph-selection-bidi-mirror-expected.txt:
  • platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:
5:13 AM Changeset in webkit [149484] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r149457 and r149388.

  • platform/qt/TestExpectations:
  • platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
12:06 AM May 2013 Meeting edited by rniwa@webkit.org
Add myself to various talks (diff)
Note: See TracTimeline for information about the timeline view.