Timeline
Jun 13, 2013:
- 9:58 PM Changeset in webkit [151581] by
-
- 6 edits in trunk/Source/WebCore
Sometimes we stick in slow scrolling mode even after leaving a page
https://bugs.webkit.org/show_bug.cgi?id=117622
Reviewed by Sam Weinig.
ScrollingCoordinator, and thus the scrolling state tree, is owned by Page,
and so persists when navigating between cached pages. We do give the ScrollingStateTree
a new ScrollingStateScrollingNode on navigation, however the ScrollingStateScrollingNode
would not have dirty flags set for, say, WheelEventHandlerCount if the document had
no wheel handlers. And because that dirty flag wasn't set, ScrollingTree::commitNewTreeState()
would fail to update m_hasWheelEventHandlers, so we'd remain in slow scrolling.
Fix by having ScrollingStateTree remember if it's been given a new root ScrollingStateScrollingNode,
and making ScrollingTree::commitNewTreeState() to the right thing in that case.
Also fix a couple of issues with the tiled scrolling indicator. First, on cached page
navigation, the indicator color would show the state for the old page, because
ScrollingCoordinatorMac::commitTreeState() checked scrollingTree()->hasWheelEventHandlers()
before the scrolling thread has committed the new scrolling tree.
Second, the color change would animate, so stop that.
Not testable, since tests can only dump the scrolling state tree.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::commit):
- page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::hasNewRootStateNode):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- platform/graphics/ca/mac/TileController.mm:
(-[WebTiledScrollingIndicatorLayer init]): Turn off borderColor implicit animations.
- 9:47 PM Changeset in webkit [151580] by
-
- 2 edits in trunk/Source/WebCore
[curl] Merge http response header values
https://bugs.webkit.org/show_bug.cgi?id=117342
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-13
Reviewed by Brent Fulgham.
According to the HTTP RFC some HTTP header values should be
merged if multiple entries for the same header exists.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader):
(WebCore::headerCallback):
- 9:32 PM Changeset in webkit [151579] by
-
- 2 edits in trunk/Source/WebCore
Should not call firePaintRelatedMilestones() for "update control tints" paint pass
https://bugs.webkit.org/show_bug.cgi?id=117624
Reviewed by Sam Weinig.
When window activation changes, we do a fake paint pass that is just used to
invalidate controls that change their appearance in background windows. This fake
paint should not be recorded in the inspector, and it should not cause paint-related
milestones to fire.
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- 8:43 PM Changeset in webkit [151578] by
-
- 4 edits in trunk/Source
Remove LiteralIdentifierTable
https://bugs.webkit.org/show_bug.cgi?id=117613
Reviewed by Geoffrey Garen.
Removed LiteralIdentifierTable since it doesn't seem to have any perf. impact now.
Source/JavaScriptCore:
- runtime/Identifier.cpp:
(JSC::Identifier::add):
Source/WTF:
- wtf/WTFThreadData.h:
- 7:55 PM Changeset in webkit [151577] by
-
- 3 edits30 adds in trunk/LayoutTests
Unreviewed. Added new baselines for some tests as r151533 on EFL port.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/editing/selection/select-across-readonly-input-1-expected.png: Added.
- platform/efl/editing/selection/select-across-readonly-input-1-expected.txt: Added.
- platform/efl/editing/selection/select-across-readonly-input-2-expected.png: Added.
- platform/efl/editing/selection/select-across-readonly-input-2-expected.txt: Added.
- platform/efl/editing/selection/select-across-readonly-input-3-expected.png: Added.
- platform/efl/editing/selection/select-across-readonly-input-3-expected.txt: Added.
- platform/efl/editing/selection/select-across-readonly-input-4-expected.png: Added.
- platform/efl/editing/selection/select-across-readonly-input-4-expected.txt: Added.
- platform/efl/editing/selection/select-across-readonly-input-5-expected.png: Added.
- platform/efl/editing/selection/select-across-readonly-input-5-expected.txt: Added.
- platform/efl/editing/selection/select-all-002-expected.png: Added.
- platform/efl/editing/selection/select-all-002-expected.txt: Added.
- platform/efl/editing/selection/select-all-003-expected.png: Added.
- platform/efl/editing/selection/select-all-003-expected.txt: Added.
- platform/efl/editing/selection/select-all-004-expected.png: Added.
- platform/efl/editing/selection/select-all-004-expected.txt: Added.
- platform/efl/editing/selection/select-all-005-expected.png: Added.
- platform/efl/editing/selection/select-all-005-expected.txt: Added.
- platform/efl/editing/selection/select-all-006-expected.png: Added.
- platform/efl/editing/selection/select-all-006-expected.txt: Added.
- platform/efl/editing/selection/select-box-expected.png: Added.
- platform/efl/editing/selection/select-box-expected.txt: Added.
- platform/efl/editing/selection/select-element-paragraph-boundary-expected.png: Added.
- platform/efl/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
- platform/efl/editing/selection/select-from-textfield-outwards-expected.png: Added.
- platform/efl/editing/selection/select-from-textfield-outwards-expected.txt: Added.
- platform/efl/editing/selection/selection-actions-expected.png: Added.
- platform/efl/editing/selection/selection-actions-expected.txt: Added.
- platform/efl/editing/selection/selection-button-text-expected.png: Added.
- platform/efl/editing/selection/selection-button-text-expected.txt: Added.
- 6:20 PM Changeset in webkit [151576] by
-
- 4 edits in trunk/Source/WebCore
Clicking on snapshotting plug-ins does not restart them
https://bugs.webkit.org/show_bug.cgi?id=117620
<rdar://problem/13821729>
Reviewed by Simon Fraser.
HTMLPlugInElement has an event handler which would return
immediately if the element was not snapshotted, restarting
or playing. There is a case it missed, which was snapshotting
(WaitingForSnapshot to be precise). If we get a click in this
state then it should immediately restart.
- html/HTMLPlugInElement.h: Move defaultEventHandler to public (we call it from the child class).
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler): If there is a click on a snapshotting
plug-in, then call restart.
- html/HTMLPlugInImageElement.h: Virtual defaultEventHandler declaration.
- 5:39 PM Changeset in webkit [151575] by
-
- 10 edits in trunk/Source/WebCore
Use borderAndPadding[Before,After]() instead of border[Before,After]() + padding[Before,After]()
https://bugs.webkit.org/show_bug.cgi?id=117611
Reviewed by Dirk Schulze.
I added a new function called borderAndPaddingAfter(), since we already had borderAndPaddingBefore(). I changed
every separate additions to the old/new function. This change makes the code shorter and more straightforward.
Behavior hasn't changed, no new tests were needed.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::relayoutForPagination):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustStartEdgeForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingStart):
(WebCore::RenderBoxModelObject::borderAndPaddingBefore):
(WebCore::RenderBoxModelObject::borderAndPaddingAfter):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::columnRectAt):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::cellBaselinePosition):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::firstLineBoxBaseline):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSnapAdjustment):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::ascentAndDescentForBox):
- 4:54 PM Changeset in webkit [151574] by
-
- 2 edits in trunk/Source/WebInspectorUI
<http://webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space between "do" and "{"
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-13
Reviewed by Timothy Hatcher.
- UserInterface/CodeMirrorFormatters.js:
- 4:33 PM Changeset in webkit [151573] by
-
- 2 edits in trunk/Source/WebInspectorUI
<http://webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel when I remove all text search text
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-13
Reviewed by Timothy Hatcher.
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._searchFieldInput):
- 3:47 PM Changeset in webkit [151572] by
-
- 7 edits in trunk/Source/WebCore
Move Node::shouldUseInputMethod() to Element.
<http://webkit.org/b/117603>
Reviewed by Antti Koivisto.
This method is only ever called on Elements, so move it off of Node.
- dom/Element.cpp:
(WebCore::Element::shouldUseInputMethod):
- dom/Element.h:
- dom/Node.cpp:
- dom/Node.h:
- html/HTMLInputElement.h:
- html/HTMLTextAreaElement.h:
- 3:32 PM Changeset in webkit [151571] by
-
- 3 edits2 adds in trunk
[CSS Regions] Selection dragged from a region paints its background
https://bugs.webkit.org/show_bug.cgi?id=117607
Reviewed by Alexandru Chiculita.
.:
Add a manual test for the painting of a dragged selection from a region. We don't have an
automated way to test this yet. This test is similar to the other manual selection dragging
tests (e.g. ManualTests/drag-image.html).
- ManualTests/regions/drag-selection-painting.html: Added.
Source/WebCore:
When a RenderFlowThread is in the selection paint phase, tell its layer to paint with the
selection only behavior. This way, only foregrounds and not backgrounds will be painted in
the dragged selection.
Manual test: ManualTests/regions/drag-selection-painting.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
- 2:09 PM Changeset in webkit [151570] by
-
- 4 edits8 adds in trunk
[CSS Shapes][CSS Regions] Respect bottom positioned shapes and content adjustment inside shapes
https://bugs.webkit.org/show_bug.cgi?id=117599
Reviewed by David Hyatt.
In r150478 I added support for multiple positioned shape-insides on regions, this patch covers the cases when a shape
is positioned to the bottom of the region or the region contains a shape which forces the content to be adjusted inside
the shape (e.g. we have a triangle shape and the first line needs to be started at the first position where it fits).
I introduced a new helper function to update the current shape and the current line segments in the flow thread cases. With
this new helper function all the logic which calculates the segments for shape-inside on regions is located in one function.
Source/WebCore:
Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html
- rendering/RenderBlock.h: Add new helper's declaration
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::LineLayoutState): Add a member to carry adjustment for flow thread cases.
(WebCore::LineLayoutState::adjustedLogicalLineTop): Add new member.
(WebCore::LineLayoutState::setAdjustedLogicalLineTop): Add new setter for the new member.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Move flow thread case to its helper function.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Added new helper for flow thread cases.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Save adjustment for flow thread cases.
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html: Added.
- 1:51 PM Changeset in webkit [151569] by
-
- 30 edits12 adds in branches/dfgFourthTier
fourthTier: DFG should support op_in and it should use patching to make it fast
https://bugs.webkit.org/show_bug.cgi?id=117385
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Implement op_in in the DFG and give it patching. The code we generate is just
a jump on the hot path, and the slow paths generate stubs and link the jump to
them. I didn't want to bother with patching structures and load offsets and
the like, although I probably could have.
This is a ginormous speed-up on microbenchmarks for "in", obviously.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::resetStubInternal):
(JSC::structureStubInfoLessThan):
(JSC):
(JSC::CodeBlock::sortStructureStubInfos):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):
- bytecode/StructureStubInfo.h:
(JSC::isInAccess):
(JSC):
(StructureStubInfo):
(JSC::StructureStubInfo::initInList):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupResults):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::payloadOnly):
(JSValueRegs):
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueSource::operator!):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::InRecord::InRecord):
(InRecord):
(DFG):
(JITCompiler):
(JSC::DFG::JITCompiler::addIn):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryRepatchIn):
(DFG):
(JSC::DFG::dfgRepatchIn):
(JSC::DFG::dfgResetIn):
- dfg/DFGRepatch.h:
(DFG):
(JSC::DFG::dfgResetIn):
- dfg/DFGSlowPathGenerator.h:
(JSC::DFG::CallSlowPathGenerator::CallSlowPathGenerator):
(JSC::DFG::CallSlowPathGenerator::tearDown):
(JSC::DFG::CallResultAndNoArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::CallResultAndOneArgumentSlowPathGenerator::generateInternal):
(JSC::DFG::CallResultAndTwoArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::CallResultAndThreeArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::CallResultAndFourArgumentsSlowPathGenerator::generateInternal):
(JSC::DFG::CallResultAndFiveArgumentsSlowPathGenerator::generateInternal):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIn):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::extractResult):
(DFG):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::JSValueOperand::tagGPR):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dump):
- runtime/JSString.h:
(JSString):
(JSC::JSString::tryGetValueImpl):
(JSC):
- runtime/Operations.h:
(JSC::normalizePrototypeChainForChainAccess):
Source/WTF:
Reviewed by Geoffrey Garen.
Now if you pass a null StringImpl* then something will still get printed instead
of crashing. I figure that this is broadly useful for debug code, and I make use
of it in the JSC portion of this patch.
- wtf/PrintStream.cpp:
(WTF::printInternal):
LayoutTests:
Reviewed by Geoffrey Garen.
Test coverage for op_in performance.
- fast/js/regress/in-four-cases-expected.txt: Added.
- fast/js/regress/in-four-cases.html: Added.
- fast/js/regress/in-one-case-false-expected.txt: Added.
- fast/js/regress/in-one-case-false.html: Added.
- fast/js/regress/in-one-case-true-expected.txt: Added.
- fast/js/regress/in-one-case-true.html: Added.
- fast/js/regress/in-two-cases-expected.txt: Added.
- fast/js/regress/in-two-cases.html: Added.
- fast/js/regress/script-tests/in-four-cases.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/in-one-case-false.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/in-one-case-true.js: Added.
(foo):
(bar):
- fast/js/regress/script-tests/in-two-cases.js: Added.
(foo):
(bar):
- 12:03 PM Changeset in webkit [151568] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after rr151563.
Export needed symbols for Windows.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 11:34 AM Changeset in webkit [151567] by
-
- 1 edit16 adds in trunk/LayoutTests
Add tests to validate CSS Background Blending
This patch set removes the test case of adding bg blend mode through script, as it
is now part of bug#117223
https://bugs.webkit.org/show_bug.cgi?id=117537
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-default-value.html: Added.
- css3/compositing/background-blend-mode-different-image-formats.html: Added.
- css3/compositing/background-blend-mode-image-color.html: Added.
- css3/compositing/background-blend-mode-image-image.html: Added.
- css3/compositing/background-blend-mode-single-layer-no-blending.html: Added.
- css3/compositing/resources/ducky.jpg: Added.
- platform/mac/css3/compositing/background-blend-mode-default-value-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-default-value-expected.txt: Added.
- platform/mac/css3/compositing/background-blend-mode-different-image-formats-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-different-image-formats-expected.txt: Added.
- platform/mac/css3/compositing/background-blend-mode-image-color-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-image-color-expected.txt: Added.
- platform/mac/css3/compositing/background-blend-mode-image-image-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-image-image-expected.txt: Added.
- platform/mac/css3/compositing/background-blend-mode-single-layer-no-blending-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-single-layer-no-blending-expected.txt: Added.
- 11:25 AM Changeset in webkit [151566] by
-
- 3 edits7 adds in trunk
[CSS Background Blending] Enable CSS Background blending for layers with SVGs.
Source/WebCore:
The change implies adding the blending parameter for SVGImage
https://bugs.webkit.org/show_bug.cgi?id=117588
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
Tests: css3/compositing/background-blend-mode-image-svg.html
css3/compositing/background-blend-mode-svg-color.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):
LayoutTests:
Adding tests for SVGs over simple background colors and images blending with SVGs.
https://bugs.webkit.org/show_bug.cgi?id=117588
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-image-svg-expected.txt: Added.
- css3/compositing/background-blend-mode-image-svg.html: Added.
- css3/compositing/background-blend-mode-svg-color-expected.txt: Added.
- css3/compositing/background-blend-mode-svg-color.html: Added.
- css3/compositing/resources/red-circle.svg: Added.
- platform/mac/css3/compositing/background-blend-mode-image-svg-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-svg-color-expected.png: Added.
- 11:24 AM Changeset in webkit [151565] by
-
- 3 edits2 adds in trunk
Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.
Source/WebCore:
Adding krit's fix: actual blending values should be compared, not the sets.
https://bugs.webkit.org/show_bug.cgi?id=117223
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-image-color-dynamic.html
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::operator==):
LayoutTests:
Adding test that sets background blend modes from script, after the page is loaded.
https://bugs.webkit.org/show_bug.cgi?id=117223
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
- fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
- fast/repaint/background-blend-mode-image-color-dynamic.html: Added.
- 11:22 AM Changeset in webkit [151564] by
-
- 2 edits in trunk/Source/WebCore
Headers and footers should be pinned to the left edge of the window when scrolling
horizontally, even when zoomed
https://bugs.webkit.org/show_bug.cgi?id=117562
-and corresponding-
<rdar://problem/14006745>
Reviewed by Sam Weinig.
We really want to use the width value from scrollOffsetForFixedPosition() for the
banner with a scaled factor of 1. So if there is a different scale factor, re-
compute this value specifically for the banners.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
- 11:13 AM Changeset in webkit [151563] by
-
- 24 edits in trunk
Support byte and octet types in bindings generators
https://bugs.webkit.org/show_bug.cgi?id=117547
Reviewed by Kentaro Hara.
Source/WebCore:
Add support for byte and octet IDL types to the bindings
generator:
http://dev.w3.org/2006/webapi/WebIDL/#idl-byte
http://dev.w3.org/2006/webapi/WebIDL/#idl-octet
No new tests, covered by existing layout tests and by new
bindings tests.
No new tests, covered by bindings tests and:
fast/js/webidl-type-mapping.html
- WebCore.exp.in: Export new symbols for mac port.
- bindings/js/JSDOMBinding.cpp:
- bindings/js/JSDOMBinding.h: Add toInt8() / toUInt8()
methods to convert from JSValue to int8_t / uint8_t as
specified by Web IDL.
- bindings/js/JSDataViewCustom.cpp: Remove custom code for
getInt8, getUInt8, setInt8, setUInt8 now that byte and octet
types are supported by the bindings generator.
- bindings/scripts/CodeGeneratorCPP.pm:
- bindings/scripts/CodeGeneratorGObject.pm:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/TestObj.idl: Add tests for byte and octet types.
- html/canvas/DataView.idl: Remove [Custom] extended attribute for
getInt8, getUInt8, setInt8, setUInt8 and use newly supported byte / octet
types.
LayoutTests:
Update fast/js/webidl-type-mapping.html to cover byte and octet
Web IDL types with and without [EnforceRange].
- fast/js/webidl-type-mapping-expected.txt:
- fast/js/webidl-type-mapping.html:
- 11:06 AM Changeset in webkit [151562] by
-
- 2 edits in trunk/Source/WebCore
Revert r150339 since it causes a hang while paused in the Web Inspector in other apps.
https://bugs.webkit.org/show_bug.cgi?id=117596
Reviewed by Joseph Pecoraro.
- platform/mac/EventLoopMac.mm:
(WebCore::EventLoop::cycle):
- 10:48 AM Changeset in webkit [151561] by
-
- 2 edits in trunk/Source/WTF
[WinCairo] Correct FeatureDefines.h Default for ENABLE_VIEW_MODE_CSS_MEDIA
https://bugs.webkit.org/show_bug.cgi?id=114396
Reviewed by Dean Jackson.
- wtf/FeatureDefines.h: The WinCairo port does not (currently) support Media elements,
so make sure we do not enable this feature by default for that port.
- 10:44 AM Changeset in webkit [151560] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed gardening. Remove dangling 'strings' folder from solution.
- WebCore.vcxproj/WebCore.vcxproj.filters: Get rid of 'strings' that was orphaned by
recent file reorganization.
- 10:33 AM Changeset in webkit [151559] by
-
- 3 edits in trunk/Source/WTF
[Windows] Unreviewed gardening.
- WTF.vcxproj/WTF.vcxproj: Add FeatureDefines.h to visible files.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- 10:03 AM Changeset in webkit [151558] by
-
- 3 edits in trunk/Source/WebCore
Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set.
https://bugs.webkit.org/show_bug.cgi?id=117578.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-13
Reviewed by Darin Adler.
ScriptProcessorNode process operation continues to dispatch AudioProcessingEvent
even though 'onaudioprocess' listener is not set. This results in unwanted thread hops.
Code is optimized to dispatch AudioProcessingEvent only if the listener is set.
No new tests, already covered by existing tests.
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::setOnaudioprocess):
- Modules/webaudio/ScriptProcessorNode.h:
(WebCore::ScriptProcessorNode::onaudioprocess):
- 10:02 AM Changeset in webkit [151557] by
-
- 3 edits in trunk/Source/WebKit
[Windows] Revise WebKit project to show generated export definition file.
https://bugs.webkit.org/show_bug.cgi?id=109629
Reviewed by Mark Rowe.
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Add generated file.
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto
- 9:56 AM Changeset in webkit [151556] by
-
- 2 edits in trunk/Source/WTF
Optimize String::fromUTF8 for ASCII
https://bugs.webkit.org/show_bug.cgi?id=117586
Reviewed by Brent Fulgham.
From Blink r152243 by <abarth@chromium.org>
Current String::fromUTF8() implementation converts 8 bit ASCII character into 16 bit.
Instead of always trying to convert into a 16 bit buffer, we can add a call to charactersAreAllASCII.
In the common case when characters are ASCII, we directly copy it into an 8 bit string buffer.
- wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):
- 9:50 AM Changeset in webkit [151555] by
-
- 4 edits2 adds in trunk
[CSS Regions] -webkit-background-clip: text; does not clip the background in regions
https://bugs.webkit.org/show_bug.cgi?id=117566
Reviewed by Alexandru Chiculita.
Source/WebCore:
This patch enables -webkit-background-clip: text; on regions.
Test: fast/regions/webkit-background-clip-text.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
Force black text if we're in the text clip paint phase. This makes sure the text's alpha
channel does not affect the final opacity of the background clipping result. Rather,
the text's alpha channel affects the amount of blending between the text color
and the background.
- rendering/RenderRegion.cpp:
(WebCore::shouldPaintRegionContentsInPhase):
Factor out a function to check if we should paint the region contents in a particular
phase. Add "PaintPhaseTextClip" so that we draw the contents in the text clipping phase.
(WebCore::RenderRegion::paintObject):
Call shouldPaintRegionContentsInPhase instead of doing the phase checks directly in this
function. Move, update, and clarify the surrounding comments.
LayoutTests:
- fast/regions/webkit-background-clip-text-expected.html: Added.
- fast/regions/webkit-background-clip-text.html: Added.
- 9:49 AM Changeset in webkit [151554] by
-
- 2 edits2 adds in trunk
[CSS Regions] Regions auto-height and absolute positioning bug
https://bugs.webkit.org/show_bug.cgi?id=111092
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-06-13
Reviewed by David Hyatt.
During last layout that should update the auto-height regions new auto-height region height
is calculated correctly based on the text content, but it requires extra step
to reposition the render block after new logical height is set (correct logical height becomes
available only during last layout).
Tests: fast/regions/autoheight-abspos-bottom-align.html
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateLogicalHeight):
- 9:47 AM Changeset in webkit [151553] by
-
- 2 edits in trunk
[GTK] [WK2] Found missing symbol when running some tests
https://bugs.webkit.org/show_bug.cgi?id=117598
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-13
Reviewed by Martin Robinson.
- Source/autotools/symbols.filter: Added missing
_ZN7WebCore28notImplementedLoggingChannelEv.
- 9:20 AM Changeset in webkit [151552] by
-
- 2 edits in trunk/Source/WebKit
[WinCairo] Unreviewed build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
missing symbols needed by TestWebKitAPI on WinCairo build.
- 9:18 AM Changeset in webkit [151551] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build correction.
- WebCore.vcxproj/WebCoreCairo.props: Use proper WebKit_Libraries
environment variable, rather than older WebKitLibraries.
- 9:12 AM Changeset in webkit [151550] by
-
- 2 edits in trunk/Source/WebCore
Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings
https://bugs.webkit.org/show_bug.cgi?id=117593
Reviewed by Geoffrey Garen.
Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by
calling asInt32() / asUInt32() instead of toInt32() / toUInt32()
when we already know the value is a int32 / uint32.
No new tests, no behavior change.
- bindings/js/JSDOMBinding.cpp:
- 9:01 AM EFLWebKit edited by
- (diff)
- 9:00 AM SettingUpDevelopmentEnvironmentForN9 edited by
- (diff)
- 8:59 AM TinOS edited by
- (diff)
- 8:59 AM BuildingQtOnOSX edited by
- (diff)
- 8:58 AM BuildingQtOnLinux edited by
- (diff)
- 8:57 AM BuildingCairoOnWindows edited by
- (diff)
- 8:37 AM Changeset in webkit [151549] by
-
- 5 edits2 adds in trunk
Setting overflow:hidden on position:absolute does not repaint hidden content
https://bugs.webkit.org/show_bug.cgi?id=116994
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-13
Reviewed by Simon Fraser.
Source/WebCore:
Since a container which has overflow clip of RenderBox which has self painting layer doesn't have a rect of the RenderBox as visual overflow,
the container should not clip request repainting rect of the RenderBox.
Test: fast/repaint/change-overflow-and-display-of-relative.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::shouldUseClipForRepaint): If this has self painting layer, we should not clip for repaint.
- rendering/RenderLayerModelObject.h:
LayoutTests:
- fast/repaint/change-overflow-and-display-of-relative-expected.txt: Added.
- fast/repaint/change-overflow-and-display-of-relative.html: Added.
- 8:29 AM Changeset in webkit [151548] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
The Math object should not be polymorphic
https://bugs.webkit.org/show_bug.cgi?id=117576
Reviewed by Oliver Hunt.
Fill in the Math object eagerly, to avoid its structure changing during
execution. There are lots of ways to skin this cat; this one seemed
easiest, and justified given the relative hotness of math operations.
20% speedup on DSP-filtrr tests, small speedups on a few Kraken tests.
- DerivedSources.make:
- JavaScriptCore.order:
- create_hash_table:
- interpreter/CallFrame.h:
(JSC::ExecState::jsonTable): Removed the Math object's static table.
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunctionWithoutTransition):
- runtime/JSObject.h:
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
- runtime/MathObject.h:
(JSC::MathObject::create): Set up the Math object at construction time.
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- runtime/VM.h: Removed the Math object's static table.
- 8:05 AM Changeset in webkit [151547] by
-
- 4 edits12 adds in trunk
[CSS Background Blending] Gradients don't blend with any of the layers behind.
First, allow the layers behind opaque gradients to be drawn, then add the blending filters
when working with gradients.
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=117532
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
Tests: css3/compositing/background-blend-mode-gradient-color.html
css3/compositing/background-blend-mode-gradient-gradient.html
css3/compositing/background-blend-mode-gradient-image.html
css3/compositing/background-blend-mode-multiple-background-layers.html
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=117532
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-gradient-color-expected.txt: Added.
- css3/compositing/background-blend-mode-gradient-color.html: Added.
- css3/compositing/background-blend-mode-gradient-gradient-expected.txt: Added.
- css3/compositing/background-blend-mode-gradient-gradient.html: Added.
- css3/compositing/background-blend-mode-gradient-image-expected.txt: Added.
- css3/compositing/background-blend-mode-gradient-image.html: Added.
- css3/compositing/background-blend-mode-multiple-background-layers-expected.txt: Added.
- css3/compositing/background-blend-mode-multiple-background-layers.html: Added.
- platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png: Added.
- platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png: Added.
- 7:42 AM Changeset in webkit [151546] by
-
- 4 edits in trunk
[Qt][Mac] Disable QTKit video on OS X.
https://bugs.webkit.org/show_bug.cgi?id=117591
Reviewed by Tor Arne Vestbø.
Source/WebCore:
Deployment of the same Qt binaries to different
Mac OS X version makes it impossible to link against
the correct WebKitSystemInterface version at build time.
No new tests, no behavioural change.
- WebCore.pri:
Tools:
Deployment of Qt binaries to different Mac OS X
platform version makes it impossible to link against
the correct version of the WebKitSystemInterface library,
so we need to disable QTKit for media elements.
- qmake/mkspecs/features/features.prf:
- 7:11 AM Changeset in webkit [151545] by
-
- 11 edits32 adds in trunk
Column balancing support in the region based multicol implementation
https://bugs.webkit.org/show_bug.cgi?id=116033
Source/WebCore:
Start by setting the column height to the flow thread's height divided
by the number of columns. Then stretch the column height until
contents fits without creating overflowing columns, or until the
maximum allowed column height is reached, whichever comes first. This
may require several layout iterations (but normally only a
couple). For each time we stretch, stretch by the least amount
required to make a difference to which box goes where.
Also make sure that the columns get tall enough to honor orphans
and widows settings.
This change takes some tiny steps in preparing for multiple column
set support. There is also some minor cleanup and bugfixing; see
details below.
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
Reviewed by David Hyatt.
Tests: fast/multicol/newmulticol/balance-images.html
fast/multicol/newmulticol/balance-maxheight1.html
fast/multicol/newmulticol/balance-maxheight2.html
fast/multicol/newmulticol/balance1.html
fast/multicol/newmulticol/balance2.html
fast/multicol/newmulticol/balance3.html
fast/multicol/newmulticol/balance4.html
fast/multicol/newmulticol/balance5.html
fast/multicol/newmulticol/balance6.html
fast/multicol/newmulticol/balance7.html
fast/multicol/newmulticol/balance8.html
fast/multicol/newmulticol/balance9.html
fast/multicol/newmulticol/cell-shrinkback.html
fast/multicol/newmulticol/columns-shorthand-parsing.html
fast/multicol/newmulticol/orphans-and-widows-balance.html
fast/multicol/newmulticol/single-line.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::setPageBreak):
(WebCore):
(WebCore::RenderBlock::updateMinimumPageHeight):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::adjustBlockChildForPagination): If no lines
cross the boundaries, we need to report where blocks cross
instead, so that the column balancer knows how much to stretch
columns if necessary.
- rendering/RenderBlock.h:
- rendering/RenderFlowThread.h:
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
- rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::columnHeightAvailable):
(WebCore::RenderMultiColumnBlock::requiresBalancing):
(RenderMultiColumnBlock):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):
(WebCore::RenderMultiColumnFlowThread::setPageBreak):
(WebCore):
(WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnSet.cpp: Get rid of
RenderMultiColumnSet::updateLogicalHeight() override. Make
RenderMultiColumnSet behave more like normal blocks, by having
computeLogicalHeight() calculate logical top in addition to
height, just like any other block.
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset): This
method will become more meaningful once we add support for
multiple column sets.
(WebCore):
(WebCore::RenderMultiColumnSet::pageLogicalTopForOffset):
(WebCore::RenderMultiColumnSet::setAndConstrainColumnHeight):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::recordSpaceShortage):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnIndexAtOffset):
repaintFlowThreadContent() could end up in an infinite loop
because columnIndexAtOffset() could return UINT_MAX
(subtracting 1 from unsigned 0, which columnCount() could return),
which an unsigned integer obviously can never become larger
than. Also always call columnIndexAtOffset() if we want to get the
column index for some offset, rather than doing it on our own
sometimes. To make this work also during layout, we cannot just
return the last column created so far if we're past it, since
adding new columns is exactly what we want to do at this point.
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
LayoutTests:
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
Reviewed by David Hyatt.
- fast/multicol/newmulticol/balance-images-expected.txt: Added.
- fast/multicol/newmulticol/balance-images.html: Added.
- fast/multicol/newmulticol/balance-maxheight1-expected.txt: Added.
- fast/multicol/newmulticol/balance-maxheight1.html: Added.
- fast/multicol/newmulticol/balance-maxheight2-expected.txt: Added.
- fast/multicol/newmulticol/balance-maxheight2.html: Added.
- fast/multicol/newmulticol/balance1-expected.txt: Added.
- fast/multicol/newmulticol/balance1.html: Added.
- fast/multicol/newmulticol/balance2-expected.txt: Added.
- fast/multicol/newmulticol/balance2.html: Added.
- fast/multicol/newmulticol/balance3-expected.txt: Added.
- fast/multicol/newmulticol/balance3.html: Added.
- fast/multicol/newmulticol/balance4-expected.txt: Added.
- fast/multicol/newmulticol/balance4.html: Added.
- fast/multicol/newmulticol/balance5-expected.txt: Added.
- fast/multicol/newmulticol/balance5.html: Added.
- fast/multicol/newmulticol/balance6-expected.txt: Added.
- fast/multicol/newmulticol/balance6.html: Added.
- fast/multicol/newmulticol/balance7-expected.txt: Added.
- fast/multicol/newmulticol/balance7.html: Added.
- fast/multicol/newmulticol/balance8-expected.txt: Added.
- fast/multicol/newmulticol/balance8.html: Added.
- fast/multicol/newmulticol/balance9-expected.txt: Added.
- fast/multicol/newmulticol/balance9.html: Added.
- fast/multicol/newmulticol/cell-shrinkback-expected.html: Added.
- fast/multicol/newmulticol/cell-shrinkback.html: Added.
- fast/multicol/newmulticol/columns-shorthand-parsing-expected.html: Added.
- fast/multicol/newmulticol/columns-shorthand-parsing.html: Added.
- fast/multicol/newmulticol/orphans-and-widows-balance-expected.txt: Added.
- fast/multicol/newmulticol/orphans-and-widows-balance.html: Added.
- fast/multicol/newmulticol/single-line-expected.html: Added.
- fast/multicol/newmulticol/single-line.html: Added.
- 5:53 AM Changeset in webkit [151544] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipping passing test and move to the right place.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-13
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 2:45 AM Changeset in webkit [151543] by
-
- 2 edits in trunk/LayoutTests
[ARM] Unreviewed gardening, skip one more test to paint the bot green.
- platform/qt-arm/TestExpectations:
- 2:17 AM Changeset in webkit [151542] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for most of the current failures.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 1:23 AM Changeset in webkit [151541] by
-
- 8 edits in trunk
[EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
https://bugs.webkit.org/show_bug.cgi?id=116610
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-13
Reviewed by Noam Rosenthal.
Source/WebKit2:
WebKit2 EFL uses fixed layout - because of this ScrollView::contentsToWindow, does
not take scroll into account, as it is meant to be handled by UI application.
When popup and context menu are created, after calling contentsToWindow their position
are not adjusted to page scroll.
Added two functions to EwkView and WKView, converting contents position to user viewport
coordinates, to adjust popup and context menu positions.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewContentsToUserViewport):
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
(EwkView::requestPopupMenu):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::contentsToUserViewport):
- UIProcess/CoordinatedGraphics/WebView.h:
Tools:
Remove unnecessary code adjusting context menu position to webview position.
Now position is calculcated in EwkView.
- MiniBrowser/efl/main.c:
(on_context_menu_show):
- 12:52 AM Changeset in webkit [151540] by
-
- 7 edits in trunk/Source/WebKit/efl
[EFL] Refactor ewk_view_scroll to remove internal structure.
https://bugs.webkit.org/show_bug.cgi?id=115713
Reviewed by Gyuyoung Kim.
After removed c-ism from WebKit/Efl, There is no reason to keep internal
structures like Ewk_Scroll_Request.
This patch refactored ewk_view_scroll to use WTF instead of Ewk_Scroll_Request
and scrolls of SmartData.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::scroll):
- ewk/ewk_view.cpp: Removed functions to manage Ewk_Scroll_Request.
(_Ewk_View_Private_Data):
(_ewk_view_scrolls_flush):
(_ewk_view_priv_del):
(_ewk_view_smart_calculate):
(ewk_view_scroll_offsets_get):
(ewk_view_scroll_rects_get):
(ewk_view_scroll):
- ewk/ewk_view.h: Removed Ewk_Scroll_Request which is private structure.
- ewk/ewk_view_private.h:
(WebCore):
- ewk/ewk_view_single.cpp:
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
- ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_smart_scrolls_process):
- 12:15 AM Changeset in webkit [151539] by
-
- 5 edits in trunk/Source
Versioning.
- 12:04 AM Changeset in webkit [151538] by
-
- 1 copy in tags/Safari-537.45
New Tag.
Jun 12, 2013:
- 11:10 PM Changeset in webkit [151537] by
-
- 2 edits in trunk/LayoutTests
[ARM] Unreviewed gardening, skip one more test to paint the bot green.
- platform/qt-arm/TestExpectations:
- 10:58 PM Changeset in webkit [151536] by
-
- 3 edits in trunk/WebKitLibraries
[WinCairo] Unreviewed build correction.
- win/tools32/vsprops/WinCairo.props: Switch from using the $WebKitLibraries environment variable to the newer $WebKit_Libraries.
- win/tools32/vsprops/debug_wincairo.props: Ditto.
- 6:48 PM Changeset in webkit [151535] by
-
- 2 edits in trunk/Tools
Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
- Scripts/webkitpy/common/config/ews.json:
- 6:15 PM Changeset in webkit [151534] by
-
- 4 edits3 moves in trunk/Websites/webkit.org
Update webkit.org build instructions for Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=117563.
Reviewed by Brent Fulgham.
- building/build.html:
- building/debug.html:
- building/launch-debugger-vs2005.png: Removed.
- building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png.
- building/set-as-startup-project-vs2005.png: Removed.
- building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png.
- building/set-debugging-properties-vs2005.png: Removed.
- building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png.
- building/tools.html:
- 6:13 PM Changeset in webkit [151533] by
-
- 3 edits29 adds in trunk/LayoutTests
Unreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passing on EFL bots.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/editing/selection/3690703-2-expected.png: Added.
- platform/efl/editing/selection/3690703-2-expected.txt: Added.
- platform/efl/editing/selection/3690703-expected.png: Added.
- platform/efl/editing/selection/3690703-expected.txt: Added.
- platform/efl/editing/selection/3690719-expected.png: Added.
- platform/efl/editing/selection/3690719-expected.txt: Added.
- platform/efl/editing/selection/4397952-expected.png: Added.
- platform/efl/editing/selection/4397952-expected.txt: Added.
- platform/efl/editing/selection/4895428-3-expected.png: Added.
- platform/efl/editing/selection/4895428-3-expected.txt: Added.
- platform/efl/editing/selection/4975120-expected.png: Added.
- platform/efl/editing/selection/4975120-expected.txt: Added.
- platform/efl/editing/selection/5007143-2-expected.png: Added.
- platform/efl/editing/selection/5007143-2-expected.txt: Added.
- platform/efl/editing/selection/5007143-expected.png: Added.
- platform/efl/editing/selection/5007143-expected.txt: Added.
- platform/efl/editing/selection/5057506-expected.png: Added.
- platform/efl/editing/selection/5057506-expected.txt: Added.
- platform/efl/editing/selection/5195166-1-expected.txt: Added.
- platform/efl/editing/selection/7152-2-expected.png: Added.
- platform/efl/editing/selection/7152-2-expected.txt: Added.
- platform/efl/editing/selection/caret-before-select-expected.png: Added.
- platform/efl/editing/selection/caret-before-select-expected.txt: Added.
- platform/efl/editing/selection/caret-ltr-right-expected.png: Added.
- platform/efl/editing/selection/caret-ltr-right-expected.txt: Added.
- platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added.
- platform/efl/editing/selection/caret-rtl-right-expected.png: Added.
- platform/efl/editing/selection/caret-rtl-right-expected.txt: Added.
- 6:00 PM Changeset in webkit [151532] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Remove irrelevant blog from Planet WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117572
Reviewed by Mark Rowe.
- config.ini: Remove Chromium blog from planet.webkit.org
- 5:59 PM Changeset in webkit [151531] by
-
- 2 edits in trunk/Source/WTF
[Windows] Activate supported C++11 Features for VS2010
https://bugs.webkit.org/show_bug.cgi?id=117569
Reviewed by Anders Carlsson.
- wtf/Compiler.h: Turn on rvalue references and static_assert
when compiling with VS2010 (or newer)
- 5:34 PM Changeset in webkit [151530] by
-
- 18 edits in trunk/Source
Remove the notion of inactive plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117570
<rdar://problem/13484213>
Reviewed by Tim Horton.
Source/WebCore:
Remove RenderEmbeddedObject::PluginInactive and the replacement text.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
- rendering/RenderEmbeddedObject.h:
Source/WebKit/mac:
Remove code that deals with inactive plug-ins.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Source/WebKit2:
Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now.
- Shared/Plugins/PluginModuleInfo.h:
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
- UIProcess/Plugins/PluginInfoStore.cpp:
- UIProcess/Plugins/PluginInfoStore.h:
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- 5:10 PM BuildingOnWindows edited by
- (diff)
- 5:05 PM Changeset in webkit [151529] by
-
- 18 edits7 adds in trunk
[Windows] Implement Accessibility2 APIs in Windows.
https://bugs.webkit.org/show_bug.cgi?id=117561
Reviewed by Anders Carlsson.
Source/WebKit:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
- WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto.
Source/WebKit/win:
- AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue
method with get_attribute from IAccessible2 API.
- AccessibleBase.h: Ditto.
- AccessibleDocument.cpp: Revise signatures for IAccessible2.
- AccessibleDocument.h: Ditto.
- AccessibleImage.cpp: Revise signatures for IAccessible2.
- AccessibleImage.h: Ditto.
- Interfaces/Accessible2: Added.
- Interfaces/Accessible2/Accessible2.idl: Added.
- Interfaces/Accessible2/Accessible2_2.idl: Added.
- Interfaces/Accessible2/AccessibleApplication.idl: Added.
- Interfaces/Accessible2/AccessibleRelation.idl: Added.
- Interfaces/Accessible2/AccessibleStates.idl: Added.
- Interfaces/Accessible2/IA2CommonTypes.idl: Added.
- Interfaces/AccessibleComparable.idl:
- Interfaces/WebKit.idl: Reference IAccessible2 types.
- WebFrame.cpp:
(WebFrame::accessible): Pass window handle to IAccessible types.
- 4:55 PM Changeset in webkit [151528] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Change default Traditional Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117568
Reviewed by Alexey Proskuryakov.
Change default font on newer versions of OS X.
- page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC'
on 10.9 and above.
- 4:53 PM Changeset in webkit [151527] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
https://bugs.webkit.org/show_bug.cgi?id=117564
Reviewed by Martin Robinson.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- 4:48 PM Changeset in webkit [151526] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Change default Simplified Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117567
Reviewed by Alexey Proskuryakov.
Change default font on newer versions of OS X.
- page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC'
instead of 'STSong' on newer systems.
- 4:30 PM Changeset in webkit [151525] by
-
- 2 edits in trunk/Source/WebCore
Fix crashes due to failed ImageBuffer allocation
https://bugs.webkit.org/show_bug.cgi?id=117541
Reviewed by Andreas Kling.
From Blink r152268 by <pdr@chromium.org>
A crash can happen due to a failed ImageBuffer allocation in
SVGImage::drawPatternForContainer(). Added a check for that failed allocation.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- 4:28 PM BuildingOnWindows edited by
- (diff)
- 4:20 PM BuildingOnWindows edited by
- (diff)
- 4:19 PM BuildingOnWindows edited by
- (diff)
- 4:13 PM BuildingOnWindows edited by
- (diff)
- 4:08 PM BuildingOnWindows edited by
- (diff)
- 3:56 PM BuildingOnWindows edited by
- (diff)
- 3:48 PM BuildingOnWindows edited by
- (diff)
- 3:46 PM BuildingOnWindows edited by
- (diff)
- 3:44 PM BuildingOnWindows edited by
- (diff)
- 3:29 PM BuildingOnWindows edited by
- (diff)
- 2:39 PM Changeset in webkit [151524] by
-
- 6 edits in trunk
[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115647
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12
Reviewed by Martin Robinson.
Source/WebCore:
Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal
AtkObject, to include custom implementations for AtkDocument and AtkText objects,
taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's
AccessibilityUIElementAtk::language(), respectively.
Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.
No new functionality, no new tests.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentInterfaceInit): Chains implementation of
AtkDocument::get_document_locale() to AtkObject::get_object_locale().
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale): Add implementation of locale resolution for
objects of type AtkDocument and AtkText.
(webkitAccessibleClassInit): Override AtkObject::get_object_locale() method.
Tools:
Locale resolution is moved to WebKitAccessibleWrapperAtk using
AtkObject::get_object_locale() API. Now, implementation of
AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
be leveraged to get_object_locale() of AtkObject.
Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.
No new functionality, no new tests.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().
- 1:46 PM Changeset in webkit [151523] by
-
- 3 edits in trunk/Tools
Remove last bits of GYP from build-webkit and update-webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=117557
Reviewed by Ryosuke Niwa.
- Scripts/build-webkit:
- Scripts/update-webkit:
- 1:18 PM Changeset in webkit [151522] by
-
- 6 edits in trunk/Source
[GTK] Move more build targets for source code that's free of layer violations into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115936
Reviewed by Martin Robinson.
Source/Platform:
- GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories
that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies'
CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk
CPPFLAGS.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing.
These build targets represent source files that are already free of platform layer violations and are as such
ready to be pushed down from the WebCore layer into the Platform layer.
Source/WebKit2:
- GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS.
- 1:07 PM Changeset in webkit [151521] by
-
- 1 edit1 delete in trunk/Tools
Remove forgotten unused Tools/Script/make-gypi script
https://bugs.webkit.org/show_bug.cgi?id=117558
Reviewed by Ryosuke Niwa.
This script isn't used since the GYP removal from WebKit.
- Scripts/make-gypi: Removed.
- 12:58 PM Changeset in webkit [151520] by
-
- 7 edits in trunk/Source
"Open Video in New Window" doesn't make sense in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=117556
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Beth Dakin.
Source/WebCore:
No new tests needed.
- WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.
Source/WebKit2:
Adds method mediaIsInFullscreen() that checks if a media element is in
fullscreen mode, which is needed to decide when to display the
"Open Video in New Window" context menu item.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaIsInFullscreen): Added.
Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
Checks if media element is in fullscreen.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- 12:52 PM Changeset in webkit [151519] by
-
- 3 edits2 adds in trunk
Accessibility code assumes an area element's parent is a map element
https://bugs.webkit.org/show_bug.cgi?id=117496
Reviewed by Chris Fleizach.
Source/WebCore:
We can't make such an assumption. Scripts can insert any element between area and map elements.
Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.
Test: accessibility/image-map-with-indirect-area-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
LayoutTests:
Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.
- accessibility/image-map-with-indirect-area-crash-expected.txt: Added.
- accessibility/image-map-with-indirect-area-crash.html: Added.
- 12:20 PM Changeset in webkit [151518] by
-
- 3 edits2 adds in trunk
Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=117370
Reviewed by David Hyatt.
Test: fast/text/whitespace/inline-whitespace-wrapping-8.html
A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line.
Likewise when we finish iterating through the objects on a line we should clear our linebreak
if the only thing that prevents us fitting on the line is our collapsed trailing whitespace.
Removing the trailing space from this measurement means we need to watch out for potential
breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces
and enter an autowrap inline then we need to mark the beginning of the autowrap inline
as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html
is an example of such a case.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117370
Reviewed by David Hyatt.
- fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-8.html: Added.
- 11:59 AM Changeset in webkit [151517] by
-
- 16 edits4 adds in trunk
[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry
https://bugs.webkit.org/show_bug.cgi?id=116745
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-12
Reviewed by Dirk Schulze.
Source/WebCore:
If ry is not supplied, it now defaults to the rx value. Also, if rx
and ry are not supplied, they default to 0px. This also has the effect
that the computed style for any rectangle or inset-rectangle now
contains all six parameters.
If rx > width/2 then it is clamped to width/2, and if ry > height/2,
then it is clamped to height/2. This happens at layout time because
given mixed units and relative units, that is the only time this
determination can be made.
Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html
fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Remove checks for undefined, since rx
and ry cannot be undefined in BasicShapes anymore.
(WebCore::basicShapeForValue): If radii are undefined in CSS, set
default values in the BasicShape, per the spec.
- rendering/ExclusionShape.cpp:
(WebCore::ensureRadiiDoNotOverlap): Utility method to ensure radii
don't overlap.
(WebCore::ExclusionShape::createExclusionShape): Remove defaulting to
zero, clamp radii per the spec.
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeRectangle::path): Remove defaulting.
(WebCore::BasicShapeRectangle::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::path): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::BasicShapeRectangle): Remove defaulting
to undefined for radii.
(WebCore::BasicShapeRectangle::setCornerRadiusX): Add assert to
prevent undefined.
(WebCore::BasicShapeRectangle::setCornerRadiusY): Add assert to
prevent undefined.
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle): Ditto.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX): Add assert to
prevent undefined.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY): Add assert to
prevent undefined.
LayoutTests:
Update tests to check for the rx and ry conditions.
- fast/exclusions/parsing/parsing-shape-inside-expected.txt: New results.
- fast/exclusions/parsing/parsing-shape-outside-expected.txt: New results.
- fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Update
to reflect that the computed value now always has rx and ry.
- fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Ditto.
- fast/exclusions/parsing/script-tests/parsing-test-utils.js: Ditto.
- fast/exclusions/resources/rounded-rectangle.js:
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Factor out left and
right into separate methods so that they can be used in tests that
only have left floats or only right floats.
(genLeftRoundedRectFloatShapeOutsideRefTest): Ditto.
(genRightRoundedRectFloatShapeOutsideRefTest): Ditto.
- fast/exclusions/shape-inside/shape-inside-animation-expected.txt: New results.
- fast/exclusions/shape-inside/shape-inside-animation.html: Change to
reflect new computed style value.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
Note that the expected test here uses shape-inside, because we
really are just testing that the behavior is the same as a
shape-inside with rx and ry set to 50%, and it turned out to be
very hard to construct an expected result that didn't use
shape-inside and wasn't off by a pixel.
- css3/masking/clip-path-animation.html: Update expected value.
- css3/masking/clip-path-animation-expected.txt: New results.
- 11:57 AM Changeset in webkit [151516] by
-
- 9 edits in trunk
[Windows] Support Title UI Element Accessibility Attribute
https://bugs.webkit.org/show_bug.cgi?id=117530
Reviewed by Anders Carlsson.
Source/WebCore:
Fixes: accessibility/list-item-role.html
accessibility/hidden-legend.html
- accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Extend to support access
for the Title UI Element object.
- accessibility/win/AccessibilityObjectWrapperWin.h: Revise interface to use Variant output,
which is more in keeping with the Mac's 'id' method signature.
Source/WebKit/win:
- AccessibleBase.cpp:
(AccessibleBase::attributeValue): Extend to handle Title UI Element.
- AccessibleBase.h: Revise signature to use a variant argument.
- Interfaces/AccessibleComparable.idl: Revise interface to use variant
- 11:53 AM Changeset in webkit [151515] by
-
- 1 edit17 adds in trunk/Websites/webkit.org
Add new Web Inspector images for a blog post.
- blog-files/new-inspector/activity-viewer.png: Added.
- blog-files/new-inspector/codemirror.png: Added.
- blog-files/new-inspector/console.png: Added.
- blog-files/new-inspector/hero-labeled.png: Added.
- blog-files/new-inspector/hero.png: Added.
- blog-files/new-inspector/layer-borders.png: Added.
- blog-files/new-inspector/layers.png: Added.
- blog-files/new-inspector/navigation-bar.png: Added.
- blog-files/new-inspector/open-sign.png: Added.
- blog-files/new-inspector/reasons.png: Added.
- blog-files/new-inspector/save.png: Added.
- blog-files/new-inspector/source-map.png: Added.
- blog-files/new-inspector/styles.png: Added.
- blog-files/new-inspector/toolbar-context-menu.png: Added.
- blog-files/new-inspector/toolbar-docked.png: Added.
- blog-files/new-inspector/toolbar.png: Added.
- 11:41 AM Changeset in webkit [151514] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=117553
Reviewed by Carlos Garcia Campos.
In CredentialTransformData we should use RefPtr for
m_userNameElement, m_passwordElement and m_oldPasswordElement
because otherwise the elements could go away when the form
elements get destroyed.
Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().
No functionalities changed no new tests.
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
(WebCore::CredentialTransformData::locateSpecificPasswords):
- WebCoreSupport/CredentialTransformData.h:
- 11:28 AM Changeset in webkit [151513] by
-
- 2 edits in trunk/Source/WebCore
[CSS Shaders] Animations and transitions should use validated custom programs
https://bugs.webkit.org/show_bug.cgi?id=117550
Run filters used for animations and transitions through RenderLayer::computeFilterOperations
in order to validate custom filter operations.
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-12
Reviewed by Alexandru Chiculita.
No new tests as no platform can run custom filters with accelerated animations yet.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
- 10:33 AM Changeset in webkit [151512] by
-
- 13 edits in trunk/Source
Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Dean Jackson.
Source/WebCore:
This patch adds the ability for fullscreen
context menu item on <video> elements to switch between "Enter Fullscreen"
and "Exit Fullscreen" and behave appropriately.
No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.
- English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.
- html/HTMLMediaElement.h:
- page/ContextMenuController.cpp:
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
was a media element in fullscreen.
(WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into
HTMLMediaElement::toggleFullscreenState.
- rendering/HitTestResult.h:
Source/WebKit2:
- Shared/API/c/WKContextMenuItemTypes.h:
- Shared/API/c/WKSharedAPICast.h:
Added variables to support the toggle-ability of the fullscreen
video context menu item.
- 10:32 AM Changeset in webkit [151511] by
-
- 2 edits3 deletes in trunk/LayoutTests
[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.
- platform/qt-arm/TestExpectations:
- platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
- platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
- platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Removed.
- 10:23 AM Changeset in webkit [151510] by
-
- 3 edits2 adds in trunk
Skipping {}, () and [] blocks while error recovering in CSS
https://bugs.webkit.org/show_bug.cgi?id=116071
Reviewed by Darin Adler.
From Blink r150201 and r150755 by <serya@chromium.org>
Source/WebCore:
Test: fast/css/parsing-expr-error-recovery.html
The CSS parser should properly recover from invalid {}, () and []
blocks skipping them instead of discarding the whole declaration
as invalid. This merge is actually made of two different changes
from Blink, the original one that fixes the bug and another one
which refactors a bit the code making it more legible.
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-expr-error-recovery-expected.txt: Added.
- fast/css/parsing-expr-error-recovery.html: Added.
- 10:22 AM Changeset in webkit [151509] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSExport header documentation substitutes "semicolon" for "colon"
https://bugs.webkit.org/show_bug.cgi?id=117552
Patch by Conrad Shultz <Conrad Shultz> on 2013-06-12
Reviewed by Mark Hahnenberg.
- API/JSExport.h:
Fix a couple typos.
- 10:17 AM Changeset in webkit [151508] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalidate the ProcessLauncher when the process is terminated before it has finished launching
https://bugs.webkit.org/show_bug.cgi?id=117412
Reviewed by Anders Carlsson.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::terminateProcess): If process is still
launching just invalidate the launcher. Reset the process
identifier after killing the process.
- 10:11 AM Changeset in webkit [151507] by
-
- 9 edits in trunk
[BlackBerry] Remove dead WebDOM code
https://bugs.webkit.org/show_bug.cgi?id=113370
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-12
Reviewed by Anders Carlsson.
BlackBerry PR 347565
Internally reviewed by Charles Wei.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/WebCore:
- PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
- Api/WebPage.cpp:
- Api/WebPage.h:
- WebCoreSupport/AboutDataEnableFeatures.in:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 10:01 AM Changeset in webkit [151506] by
-
- 5 edits in trunk/LayoutTests
[css exclusions] fast/css/variables/var-inside-shape.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116059
Reviewed by Alexandru Chiculita.
Some shapes were incorrectly defined, there was a "rectange"
instead of a "rectangle" and also the number of parameters and
their types was wrong. Apart from that, both the CSS exclusions
and CSS variables settings were not enabled at runtime.
Some extra text was also added to the divs in order to verify that
the CSS exclusions are working properly.
- fast/css/variables/var-inside-shape-expected.html:
- fast/css/variables/var-inside-shape.html:
- platform/efl/TestExpectations: Removed var-inside-shape.html.
- platform/gtk/TestExpectations: Ditto.
- 9:46 AM Changeset in webkit [151505] by
-
- 10 edits1 copy3 adds in trunk
window.find() case-insensitive search doesn't match diacritical marks
https://bugs.webkit.org/show_bug.cgi?id=117353
<rdar://problem/8535227>
Patch by Daniel Bates <dabates@apple.com> on 2013-06-12
Reviewed by Darin Adler.
Source/WebCore:
Currently, a case-insensitive window.find() search will return true for a word w
(e.g. café) with diacritical characters when w appears on the page without
diacritical marks (e.g. cafe). This leads to bad results, especially when
searching for a non-English word (e.g. qué) where the presence of an accented
character(s) may change the meaning of the word. Instead window.find() should
return false when case-insensitively matching a word with diacritical marks to
the same word without diacritical marks.
Test: fast/text/find-diacritical-mark.html
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):
LayoutTests:
Added test to use window.find() to find a search string in text, where either
the search string or text (or both) contain diacritical characters.
Additionally, updated tests LayoutTests/fast/text/find-soft-hyphen.html
and LayoutTests/editing/execCommand/findString-diacriticals.html based on the
new behavior of window.find(). Moved function testFind() from LayoutTests/fast/text/script-tests/find-backwards.js
to its own file, LayoutTests/fast/text/resources/test-find.js, so that this function can
be used by both tests LayoutTests/fast/text/find-{backwards, diacritical-mark}.html.
- LayoutTests/editing/execCommand/findString-diacriticals.html: Update test based on the new
behavior of window.find().
- fast/text/find-backwards.html: Include external JavaScript file test-find.js.
- fast/text/find-case-folding-expected.txt: Rebase result; expected failure.
- fast/text/find-case-folding.html: Add comment to see bug #117548 with regards to expected failure.
- fast/text/find-diacritical-mark-expected.txt: Added.
- fast/text/find-diacritical-mark.html: Copied from LayoutTests/fast/text/find-backwards.html.
- fast/text/find-soft-hyphen-expected.txt: Rebase result.
- fast/text/resources/test-find.js: Added.
(testFind):
- fast/text/script-tests/find-backwards.js: Moved function testFind() from here to
file fast/text/resources/test-find.js and modified it to take an additional argument to
toggle search case sensitivity.
- fast/text/script-tests/find-diacritical-mark.js: Added.
- fast/text/script-tests/find-soft-hyphen.js: Update test based on the new behavior of window.find().
- 9:30 AM Changeset in webkit [151504] by
-
- 29 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, rolled back in http://trac.webkit.org/changeset/151362.
I fixed that the llint exception process was happening in common slow paths
even when call via the baseline JIT. Also moved emitSlow_* methods to
be right after the corresponding emit_* method.
2013-06-07 Michael Saboff <msaboff@apple.com>
fourthTier: The baseline jit and LLint should use common slow paths
https://bugs.webkit.org/show_bug.cgi?id=116889
- 9:06 AM Changeset in webkit [151503] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Smarter algorithm to determine the backingstore rect
https://bugs.webkit.org/show_bug.cgi?id=117451
JIRA115644
https://jira.bbqnx.net/browse/BRWSR-7028
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-12
Reviewed by Rob Buis.
So far, the backingstore tile geometry allocation was
pretty straightforward: We would start off from the
current viewport and append all available tiles into
the current scrolling direction from there.
This will usually work well enough, but has the downside
of discarding all the tiles in the opposite direction.
Also, tiles very close to the viewport will often get
discarded even if the user only scrolls very slowly.
This patch completely revamps the algorithm for
determining where the backingstore should be positioned.
The general idea is that we construct a "desired rect"
based on the viewport and inflate it into all four
directions according to the current scroll momentum.
This rectangle will be similarly large as a backingstore
tile geometry rectangle might be, by using the
approximate number of pixels that are available in the
given number of tiles.
The proportions for extending the rectangle from the
viewport are influenced by different factors, including
scroll momentum, viewport ratio, available space in the
overall contents rectangle, and natural bias for the
"down" direction.
In practice, this results in a backingstore that is
roughly evenly distributed around the viewport when no
movement is happening, and will gradually narrow down
and extend into the scroll direction at a higher momentum.
The final tile geometry is constructed by trying fit
the tiles into the desired rect in a way that maximizes
the area of its intersection. There are a few parameters
that can be tweaked, the ones in this patch seem to
handle most cases well enough to minimize checkerboarding.
As an additional bonus, a rectangle-based tiling strategy
can more easily be adopted for accelerated compositing,
which currently operates on a simpler algorithm that also
inflates the viewport but does not take scrolling into
account.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
(BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
(BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- 8:48 AM Changeset in webkit [151502] by
-
- 2 edits in trunk/LayoutTests
[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails
https://bugs.webkit.org/show_bug.cgi?id=97199
Unreviewed, Qt Gardening.
Unskip test that is now passing on the bots.
Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-06-12
- platform/qt/TestExpectations:
- 8:37 AM Changeset in webkit [151501] by
-
- 3 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk:
------------------------------------------------------------------------
r148746 | jberlin@webkit.org | 2013-04-19 08:21:49 -0700 (Fri, 19 Apr 2013) | 3 lines
Fix expectations added in r148720.
------------------------------------------------------------------------
- 8:03 AM Changeset in webkit [151500] by
-
- 23 edits4 deletes in branches/dfgFourthTier/Source
Unreviewed, rolled out r151456, r151420:
Source/JavaScriptCore:
It causes layout test failures.
Source/WebCore:
It causes layout test failures.
- 7:49 AM WebKitIDL edited by
- Remove [IndexedGetter] and [NumericIndexedGetter] after r151499 (diff)
- 7:41 AM Changeset in webkit [151499] by
-
- 58 edits in trunk/Source/WebCore
Support latest Web IDL indexed property getters
https://bugs.webkit.org/show_bug.cgi?id=117507
Reviewed by Kentaro Hara.
Support latest Web IDL indexed property getters:
http://www.w3.org/TR/WebIDL/#dfn-support-indexed-properties
Drop support for outdated [IndexedGetter] and [NumericIndexedGetter]
IDL extended attributes. Since the new getter format specifies the
return type, the bindings generator is now smart enough to know if
the indexed getter is numeric or not on its own.
Based on Blink r149564 by <kojih@chromium.org>.
No new tests, no behavior change.
- Modules/filesystem/EntryArray.idl:
- Modules/filesystem/EntryArraySync.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- bindings/scripts/CodeGenerator.pm:
(IsNumericType):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetIndexedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestEventTarget.idl:
- bindings/scripts/test/TestTypedArray.idl:
- css/CSSRuleList.idl:
- css/CSSStyleDeclaration.idl:
- css/CSSValueList.idl:
- css/MediaList.idl:
- css/StyleSheetList.idl:
- css/WebKitCSSFilterValue.idl:
- css/WebKitCSSKeyframesRule.idl:
- css/WebKitCSSTransformValue.idl:
- dom/ClientRectList.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DOMStringList.idl:
- dom/DataTransferItemList.idl:
- dom/NamedNodeMap.idl:
- dom/NodeList.idl:
- dom/PropertyNodeList.idl:
- dom/TouchList.idl:
- fileapi/FileList.idl:
- html/DOMSettableTokenList.idl:
- html/DOMTokenList.idl:
- html/HTMLAllCollection.idl:
- html/HTMLCollection.idl:
- html/HTMLFormControlsCollection.idl:
- html/HTMLFormElement.idl:
- html/HTMLPropertiesCollection.idl:
- html/HTMLSelectElement.idl:
- html/RadioNodeList.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegionList.idl:
- html/track/VideoTrackList.idl:
- page/PerformanceEntryList.idl:
- page/SpeechInputResultList.idl:
- plugins/DOMMimeTypeArray.idl:
- plugins/DOMPlugin.idl:
- plugins/DOMPluginArray.idl:
- 7:37 AM Changeset in webkit [151498] by
-
- 3 edits in trunk/Source/WebKit2
[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy
https://bugs.webkit.org/show_bug.cgi?id=117539
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-12
Reviewed by Noam Rosenthal.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- 6:50 AM Changeset in webkit [151497] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Unskipping passing tests.
- platform/gtk-wk2/TestExpectations:
- 6:39 AM Changeset in webkit [151496] by
-
- 2 edits in trunk/Tools
[GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
https://bugs.webkit.org/show_bug.cgi?id=117533
Patch by Andres Gomez <Andres Gomez> on 2013-06-12
Reviewed by Carlos Garcia Campos.
MiniBrowser now starts automatically the download of the documents
that cannot be shown just by WebKit itself on link left clicking.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): handled the
WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
- 5:49 AM WebKitIDL edited by
- Rename [CallWith] to [ConstructorCallWith] for interfaces (diff)
- 5:25 AM Changeset in webkit [151495] by
-
- 22 edits in trunk/Source/WebCore
Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=117531
Reviewed by Kentaro Hara.
Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
meaning is slightly different when [CallWith] is used for IDL operations
or attributes. This improves IDL readability a bit and makes it more
directly understandable.
Also removed [ConstructorCallWith] statements from interfaces with custom
constructors or no constructor, as this does not have any effect.
No new tests, no behavior change.
- Modules/filesystem/FileWriter.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/notifications/Notification.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/TestInterface.idl:
- dom/MessageChannel.idl:
- fileapi/FileReader.idl:
- html/MediaController.idl:
- html/track/TextTrackCue.idl:
- page/EventSource.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- xml/XMLHttpRequest.idl:
- 4:44 AM Changeset in webkit [151494] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Set windows key-code for multimedia keys
https://bugs.webkit.org/show_bug.cgi?id=117535
Reviewed by Jocelyn Turcotte.
Map Qt Key-events to their defined windows keycode values.
- platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- 4:34 AM Changeset in webkit [151493] by
-
- 3 edits in trunk/Source/WebCore
[Soup] Use ResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=112902
Reviewed by Carlos Garcia Campos.
Use the ResourceLoadPriority from the ResourceRequest to set the
correnpondent priority to each SoupMessage.
No new tests required as there is no change in functionality,
we're just enabling a new feature in the underlying network stack.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):
- platform/network/soup/ResourceRequest.h:
(WebCore):
(WebCore::toSoupMessagePriority): Translates ResourceLoadPriority
to SoupMessagePriority.
- 1:51 AM Changeset in webkit [151492] by
-
- 4 edits in trunk
[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
https://bugs.webkit.org/show_bug.cgi?id=116723
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.
Tools:
- TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
not expensive and produces a working archive without problems even on incremental builds.
- 1:45 AM Changeset in webkit [151491] by
-
- 16 edits in trunk/Source
Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings
https://bugs.webkit.org/show_bug.cgi?id=117512
Reviewed by Darin Adler.
Source/WebCore:
- page/Settings.in: Remove the memoryInfoEnabled and the quantizedMemoryInfoEnabled settings. These are not used
anywhere anymore after r151199 which simplified and moved the MemoryInfo interface under window.internals.
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
Source/WebKit/mac:
- WebKit.order: Remove the memoryInfoEnabled entry.
- WebView/WebPreferenceKeysPrivate.h: Remove WebKitMemoryInfoEnabledPreferenceKey.
- WebView/WebPreferences.mm: Remove memoryInfoEnabled, setMemoryInfoEnabled methods.
(+[WebPreferences initialize]): Don't set the default value for the WebKitMemoryInfoEnabledPreferenceKey, the preference is being removed.
- WebView/WebPreferencesPrivate.h: Remove memoryInfoEnabled, setMemoryInfoEnabled method declarations.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl: Remove memoryInfoEnabled, setMemoryInfoEnabled entries.
- WebPreferenceKeysPrivate.h: Remove the WebKitMemoryInfoEnabledPreferenceKey definition.
- WebPreferences.cpp: Remove the memoryInfo, setMemoryInfoEnabled methods.
(WebPreferences::initializeDefaultSettings): Remove the WebKitMemoryInfoEnabledPreferenceKey entry initialization.
- WebPreferences.h: Remove the memoryInfo, setMemoryInfoEnabled method declarations.
- WebView.cpp:
(WebView::notifyPreferencesChanged): Remove the Settings::setMemoryInfoEnabled call, the method is being removed.
- 1:36 AM Changeset in webkit [151490] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix.
- GNUmakefile.list.am: Adding missing build targets to the plugin process after r151480.
- 1:09 AM Changeset in webkit [151489] by
-
- 4 edits in trunk/Source
[GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL
https://bugs.webkit.org/show_bug.cgi?id=117332
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-12
Reviewed by Xan Lopez.
Source/WebCore:
Add parameter 'pseudoElement' to the list of parameters that are allowed to
be NULL.
- bindings/scripts/CodeGeneratorGObject.pm:
(GetGReturnMacro):
Source/WebKit/gtk:
Add test for function 'webkit_dom_dom_window_get_computed_style'.
- tests/testdomdomwindow.c:
(dom_dom_window_fixture_setup): Test setup for function
'dom_dom_window_get_computed_style'.
(dom_dom_window_fixture_teardown): Test teardown for function
'dom_dom_window_get_computed_style'.
(loadedCallback):
(test_dom_dom_window_get_computed_style): Checks function
'dom_dom_window_get_computed_style'.
(main):
- 12:20 AM Changeset in webkit [151488] by
-
- 4 edits in trunk
Add CSS parsing recovery to functions
https://bugs.webkit.org/show_bug.cgi?id=117500
Reviewed by Andreas Kling.
From Blink r150205 by <serya@chromium.org>
Source/WebCore:
Add parsing recovery capabilities to functions. Errors were
correctly detected without this change but then the whole
declaration was invalidated. By using expr_recovery to handle them
we can recover from those errors and go on with the parsing.
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-error-recovery.html: added some test cases for
parsing recovery inside functions.
