Timeline
Jan 22, 2015:
- 11:31 PM Changeset in webkit [178985] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 11:04 PM Changeset in webkit [178984] by
-
- 4 edits in trunk/Source/JavaScriptCore
EdenCollections unnecessarily visit SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=140762
Reviewed by Geoffrey Garen.
- heap/Heap.cpp:
(JSC::Heap::copyBackingStores): Also added a GCPhase for copying
backing stores, which is a significant portion of garbage collection.
(JSC::Heap::visitSmallStrings): Check to see if we need to visit
SmallStrings based on the collection type.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::visitStrongReferences): Set the fact that we have
visited the SmallStrings since the last modification.
- runtime/SmallStrings.h:
(JSC::SmallStrings::needsToBeVisited): If we're doing a
FullCollection, we need to visit. Otherwise, it depends on whether
we've been visited since the last modification/allocation.
- 10:26 PM Changeset in webkit [178983] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Move leading whitespace handling from removeTrailingWhitespace() to initializeNewLine().
https://bugs.webkit.org/show_bug.cgi?id=140757
Reviewed by Antti Koivisto.
Checking if overflowed pre-wrap whitespace needs to be ignored should not be part of the trailing whitespace handling.
Move it to initializeNewLine().
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::preWrap):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isLineBreak):
- 9:38 PM Changeset in webkit [178982] by
-
- 6 edits in branches/safari-600.5-branch/Source
Merge r174708. rdar://problem/19451256
- 9:38 PM Changeset in webkit [178981] by
-
- 1 edit3 adds in branches/safari-600.5-branch/LayoutTests
Merge r175264. rdar://problem/19451378
- 8:17 PM Changeset in webkit [178980] by
-
- 10 edits in trunk/Source/WebKit2
[iOS][WK2] Ignore synthetic click initiated on a previous page
https://bugs.webkit.org/show_bug.cgi?id=139556
rdar://problem/18586008
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-22
Reviewed by David Kilzer.
Under the right accumulation of bad luck, a synthetic click could be generated
on a page that never asked for it.
What happened was:
1) Page Foo listen to touch event.
2) In response to touch events, Foo decides to navigate to page Bar
*but* it does not cancel the native gesture recognizers with preventDefault().
3) Page Bar loads.
4) The native gesture recognizer ask us to click, we forward that to the WebProcess
and generate a synthetic mouse event.
-> Bar receives a click.
If you are unlucky enough, it looks like a single tap does a double click.
There are two ways this patch avoids the problem:
First, in the UIProcess, we just cancel the HighlightLongPressGestureRecognizer
on didCommitLoadForMainFrame. This prevents "fast clicks" from accidentally going through.
This is not bullet proof because we get didCommitLoadForMainFrame asynchronously but
killing the timer and gesture seems like a good idea.
Second, we skip any tap command at the WebProcess level when it was issued for
the previous page. This is using the same principle we used for VisibleContentRect:
any input generated before the current layer tree commit is useless for the current page.
We track the commit ID in the UIProcess when we decide to do the tracking or not.
Note that we keep the ID regardless of the tracking state, it does not matter if we have sent
touch events, what matters is what content was on screen when the touch events were handled.
If the user interaction result in a tap, we send the commit ID along the tap commands.
In the WebProcess, we know the actual layer tree commit associated with the current page.
If the tap was generated with a layer ID preceding the current page, we fail the command.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLoadForMainFrame]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _attemptClickAtLocation:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap):
(WebKit::WebPage::commitPotentialTap):
- 8:06 PM Changeset in webkit [178979] by
-
- 2 edits in trunk/Tools
configure-xcode-for-ios-development needs to import webkitdirs.pm
<http://webkit.org/b/140704>
Fixes the following runtime error:
Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
- Scripts/configure-xcode-for-ios-development: Add back code to
import webkitdirs.pm for the exitStatus() method. Not sure why
I removed it before patch review.
- 7:32 PM Changeset in webkit [178978] by
-
- 3 edits2 deletes in trunk/Source/WebKit
Remove unused class EmojiFallbackFontSelector.
<https://webkit.org/b/140809>
Reviewed by Antti Koivisto.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/ios:
This class no longer has any clients.
- Misc/EmojiFallbackFontSelector.cpp: Removed.
- Misc/EmojiFallbackFontSelector.h: Removed.
- 6:21 PM Changeset in webkit [178977] by
-
- 6 edits in branches/safari-600.5-branch/Source/WebCore
Merged r178967. <rdar://19572776>
- 6:17 PM Changeset in webkit [178976] by
-
- 1 edit2 adds in trunk/LayoutTests
Import fast/css/font-shorthand-line-height.html layout test from Blink
https://bugs.webkit.org/show_bug.cgi?id=140801
Reviewed by Andreas Kling.
Import fast/css/font-shorthand-line-height.html layout test from Blink
to get better test coverage for 'line-height' font shorthands cascades:
https://src.chromium.org/viewvc/blink?view=rev&revision=184346
I am working on expanding the font shorthand at parsing time (like
other shorthands) via Bug 140577 and I want to make sure I don't break
line-height in the process.
- fast/css/font-shorthand-line-height-expected.txt: Added.
- fast/css/font-shorthand-line-height.html: Added.
- 5:57 PM Changeset in webkit [178975] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][Cocoa] Drop WKWebViewConfiguration._featureCounterEnabled SPI.
https://bugs.webkit.org/show_bug.cgi?id=140799
Reviewed by Dan Bernstein.
Drop WKWebViewConfiguration._featureCounterEnabled SPI now that the
client-side has been updated.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]):
(-[WKWebViewConfiguration _featureCounterEnabled]): Deleted.
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 5:28 PM Changeset in webkit [178974] by
-
- 1 copy in tags/Safari-600.4.3
New tag.
- 5:19 PM Changeset in webkit [178973] by
-
- 2 edits in trunk/Source/WebKit2
Fix ENABLE(NETWORK_CACHE) build
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
- 5:16 PM Changeset in webkit [178972] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Unreviewed test fix after r178965.
- WebView.cpp: Supply missing implementation of 'setEditable'. It
currently asserts, causing all debug tests to fail.
- 4:47 PM Changeset in webkit [178971] by
-
- 2 edits in trunk/Tools
REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
https://bugs.webkit.org/show_bug.cgi?id=140795
Reviewed by Jon Honeycutt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
r178847 accidentally remove the scheduler for this bot. Re-add it to the
Yosemite scheduler.
- 4:44 PM Changeset in webkit [178970] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIString with a variable parameter
https://bugs.webkit.org/show_bug.cgi?id=140268
Reviewed by Timothy Hatcher.
UIString no longer incorrectly used around variables. Drive-by fixes to prototype inheritance style.
Use of Promises corrected such that requesting content for a resource resolves rather than rejects if
a resource can't be found or has another error that isn't a web inspector error.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/Models/Resource.js: Change reject to resolve.
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype.requestContentFromBackend): Proper use of Error object.
- UserInterface/Models/SourceCode.js: Use correct inheritance style.
- UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype._contentAvailable): Handle error now that promise resolves.
(WebInspector.ResourceContentView.prototype._contentError): Remove incorrect use of UIString.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._contentAvailable): Handle error now that promise resolves.
- 4:31 PM Changeset in webkit [178969] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Media controls disappear when loading a HLS live stream
https://bugs.webkit.org/show_bug.cgi?id=140792
rdar://problem/19491658
Reviewed by Dean Jackson.
Overload reconnectControls to reconnect the "start playback" button
if the control type has been set to "StartPlaybackButton".
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.reconnectControls):
- 4:18 PM Changeset in webkit [178968] by
-
- 5 edits in trunk/Source
[Win] No plugin content on some sites.
https://bugs.webkit.org/show_bug.cgi?id=140780
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-22
Reviewed by Anders Carlsson.
Source/WebCore:
Return script instance from ScriptController::createScriptInstanceForWidget(),
instead of always returning null.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::bindingInstance):
Source/WebKit/win:
Add override modifier to bindingInstance method.
- Plugins/PluginView.h:
- 4:17 PM Changeset in webkit [178967] by
-
- 6 edits in trunk/Source/WebCore
[Mac][EME] Adopt changes to AVStreamSession class methods
https://bugs.webkit.org/show_bug.cgi?id=140778
rdar://problem/19458200
Reviewed by Eric Carlson.
AVStreamSession class methods have added a "storageDirectoryAtURL:" parameter so as to be able to
read and modify records stored at non-default storage locations.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::mediaKeysStorageDirectory): Implement client method by querying document and settings.
- Modules/encryptedmedia/MediaKeySession.h:
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): Check whether the AVStreamSession class responds to new selector before calling.
(WebCore::CDMSessionMediaSourceAVFObjC::update): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::storagePath): Fetch the storage path from the client.
- 4:15 PM Changeset in webkit [178966] by
-
- 3 edits2 adds in trunk
REGRESSION (174847): can't view NHK(Japan's national public broadcasting organization)’s news pages
https://bugs.webkit.org/show_bug.cgi?id=140794
Reviewed by Anders Carlsson.
Source/WebCore:
If a document.open has been set, return it instead of always returning a new,
non-cached instance of jsHTMLDocumentPrototypeFunctionOpen.
Test: js/dom/document-overwrite-open.html
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
LayoutTests:
- js/dom/document-overwrite-open-expected.txt: Added.
- js/dom/document-overwrite-open.html: Added.
- 3:46 PM Changeset in webkit [178965] by
-
- 11 edits in trunk
[Win] Expose missing editing features through WebView interface
https://bugs.webkit.org/show_bug.cgi?id=140773
<rdar://problem/19565421>
Reviewed by Dean Jackson.
Connect the various WebView editing delegate methods to our
test infrastructure. Also prefer _bstr_t to raw BSTR types
to simplify life cycle management.
Source/WebKit/win:
- DOMCoreClasses.cpp: Flesh out the DOMRange object.
(DOMElement::createInstance):
(DOMRange::QueryInterface):
(DOMRange::DOMRange):
(DOMRange::~DOMRange):
(DOMRange::createInstance):
(DOMRange::startContainer):
(DOMRange::startOffset):
(DOMRange::endContainer):
(DOMRange::endOffset):
(DOMRange::collapsed):
(DOMRange::commonAncestorContainer):
(DOMRange::setStart):
(DOMRange::setEnd):
(DOMRange::setStartBefore):
(DOMRange::setStartAfter):
(DOMRange::setEndBefore):
(DOMRange::setEndAfter):
(DOMRange::collapse):
(DOMRange::selectNode):
(DOMRange::selectNodeContents):
(DOMRange::compareBoundaryPoints):
(DOMRange::deleteContents):
(DOMRange::extractContents):
(DOMRange::cloneContents):
(DOMRange::insertNode):
(DOMRange::surroundContents):
(DOMRange::cloneRange):
(DOMRange::toString):
(DOMRange::detach):
- DOMCoreClasses.h:
(DOMRange::AddRef):
(DOMRange::Release):
(DOMRange::throwException):
(DOMRange::callWebScriptMethod):
(DOMRange::evaluateWebScript):
(DOMRange::removeWebScriptKey):
(DOMRange::stringRepresentation):
(DOMRange::webScriptValueAtIndex):
(DOMRange::setWebScriptValueAtIndex):
(DOMRange::setException):
- Interfaces/IWebEditingDelegate.idl:
- Interfaces/IWebView.idl:
- WebCoreSupport/WebEditorClient.cpp: Connect more methods
to actual editing features in WebCore.
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::didEndEditing):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldInsertNode):
(WebEditorClient::shouldInsertText):
(WebEditorClient::shouldChangeSelectedRange):
(WebEditorClient::webViewDidChangeTypingStyle):
(WebEditorClient::webViewDidChangeSelection):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):
- WebView.cpp:
(WebView::setEditingDelegate): Added.
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/EditingDelegate.cpp:
(EditingDelegate::QueryInterface):
(dumpPath):
(dump):
(EditingDelegate::shouldBeginEditingInDOMRange):
(EditingDelegate::shouldEndEditingInDOMRange):
(EditingDelegate::shouldInsertNode):
(EditingDelegate::shouldInsertText):
(EditingDelegate::shouldDeleteDOMRange):
(EditingDelegate::shouldChangeSelectedDOMRange):
(EditingDelegate::shouldApplyStyle):
(EditingDelegate::shouldChangeTypingStyle):
(EditingDelegate::doPlatformCommand):
(EditingDelegate::webViewDidBeginEditing):
(EditingDelegate::webViewDidChange):
(EditingDelegate::webViewDidEndEditing):
(EditingDelegate::webViewDidChangeTypingStyle):
(EditingDelegate::webViewDidChangeSelection):
(EditingDelegate::checkSpellingOfString):
(EditingDelegate::onNotify):
- DumpRenderTree/win/EditingDelegate.h:
- 3:42 PM Changeset in webkit [178964] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Reset LineState when starting a new line.
https://bugs.webkit.org/show_bug.cgi?id=140789
Reviewed by Antti Koivisto.
Reset LineState when starting a new line to ensure we always
start with a clean state.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createTextRuns):
- 3:35 PM Changeset in webkit [178963] by
-
- 12 edits15 adds in trunk
[WebGL2] Create empty interface files for new WebGL2 objects.
https://bugs.webkit.org/show_bug.cgi?id=140779.
<rdar://problem/15002288>
Reviewed by Dean Jackson.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLQuery.cpp: Added.
(WebCore::WebGLQuery::create):
(WebCore::WebGLQuery::~WebGLQuery):
(WebCore::WebGLQuery::WebGLQuery):
(WebCore::WebGLQuery::deleteObjectImpl):
- html/canvas/WebGLQuery.h: Added.
- html/canvas/WebGLQuery.idl: Added.
- html/canvas/WebGLSampler.cpp: Added.
(WebCore::WebGLSampler::create):
(WebCore::WebGLSampler::~WebGLSampler):
(WebCore::WebGLSampler::WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):
- html/canvas/WebGLSampler.h: Added.
- html/canvas/WebGLSampler.idl: Added.
- html/canvas/WebGLSharedObject.h:
(WebCore::WebGLSharedObject::isQuery):
(WebCore::WebGLSharedObject::isSampler):
(WebCore::WebGLSharedObject::isSync):
(WebCore::WebGLSharedObject::isTransformFeedback):
(WebCore::WebGLSharedObject::isVertexArrayObject):
- html/canvas/WebGLSync.cpp: Added.
(WebCore::WebGLSync::create):
(WebCore::WebGLSync::~WebGLSync):
(WebCore::WebGLSync::WebGLSync):
(WebCore::WebGLSync::deleteObjectImpl):
- html/canvas/WebGLSync.h: Added.
- html/canvas/WebGLSync.idl: Added.
- html/canvas/WebGLTransformFeedback.cpp: Added.
(WebCore::WebGLTransformFeedback::create):
(WebCore::WebGLTransformFeedback::~WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):
- html/canvas/WebGLTransformFeedback.h: Added.
- html/canvas/WebGLTransformFeedback.idl: Added.
- html/canvas/WebGLVertexArrayObject.cpp: Added.
(WebCore::WebGLVertexArrayObject::create):
(WebCore::WebGLVertexArrayObject::~WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):
- html/canvas/WebGLVertexArrayObject.h: Added.
- html/canvas/WebGLVertexArrayObject.idl: Added.
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 3:35 PM Changeset in webkit [178962] by
-
- 2 edits in tags/Safari-601.1.15.1/Source/WebKit2
Merged r178958. rdar://problem/19438402
- 3:34 PM Changeset in webkit [178961] by
-
- 2 edits in trunk/WebKitLibraries
[iOS] Fix build for external iphoneos SDK
Reviewed by Daniel Bates.
- WebKitSystemInterface.h: Remove import of the
<IOSurface/IOSurface.h> header, and add a typedef for
IOSurfaceRef in its place.
- 3:32 PM Changeset in webkit [178960] by
-
- 5 edits in tags/Safari-601.1.15.1/Source
Versioning.
- 3:30 PM Changeset in webkit [178959] by
-
- 1 copy in tags/Safari-601.1.15.1
New tag.
- 3:21 PM Changeset in webkit [178958] by
-
- 2 edits in trunk/Source/WebKit2
UserData decoding of WKTypeRefWrapper always fails
https://bugs.webkit.org/show_bug.cgi?id=140791
<rdar://problem/19438402>
Reviewed by Anders Carlsson.
- Shared/mac/ObjCObjectGraph.mm:
(WebKit::ObjCObjectGraph::decode):
Add a missing break.
- 3:20 PM Changeset in webkit [178957] by
-
- 2 edits in trunk/LayoutTests
Skip another copy of oes-vertex-array-object test, because it has the same problems
as the old one.
- platform/mac/TestExpectations:
- 3:16 PM Changeset in webkit [178956] by
-
- 18 edits12 adds1 delete in trunk/LayoutTests
[Win] Unreviewed test gardening.
Clean up editing-related tests and rebaseline some output.
- platform/win/TestExpectations:
- platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
- platform/win/editing/pasteboard/4641033-expected.txt: Added.
- platform/win/editing/pasteboard/4944770-1-expected.txt: Added.
- platform/win/editing/pasteboard/4944770-2-expected.txt: Added.
- platform/win/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
- platform/win/editing/selection/3690703-2-expected.txt:
- platform/win/editing/selection/3690703-expected.txt:
- platform/win/editing/selection/3690719-expected.txt:
- platform/win/editing/selection/4975120-expected.txt: Added.
- platform/win/editing/selection/5240265-expected.txt:
- platform/win/editing/selection/caret-before-select-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-left-expected.txt:
- platform/win/editing/selection/caret-rtl-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-right-expected.txt:
- platform/win/editing/selection/drag-select-1-expected.txt: Added.
- platform/win/editing/selection/mixed-editability-10-expected.txt:
- platform/win/editing/selection/replaced-boundaries-3-expected.txt: Added.
- platform/win/editing/selection/select-box-expected.txt: Added.
- platform/win/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/editing/selection/selection-button-text-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- 3:13 PM Changeset in webkit [178955] by
-
- 2 edits in trunk/Source/WebCore
Fix remaining multiple targets per rule issues in DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=140790
Reviewed by David Kilzer.
Fix remaining multiple target per rule issues in DerivedSources.make,
similarly to Bug 140784 and Bug 140756.
This was causing us to run scripts several times to generate the same
files and may lead to malformed files in case of concurrency.
- DerivedSources.make:
- 3:12 PM Changeset in webkit [178954] by
-
- 17 edits in trunk
Add a build flag for ES6 class syntax
https://bugs.webkit.org/show_bug.cgi?id=140760
Reviewed by Michael Saboff.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Added ES6_CLASS_SYNTAX build flag and used it in tokenizer to recognize
"class", "extends", "static" and "super" keywords.
- Configurations/FeatureDefines.xcconfig:
- parser/Keywords.table:
- parser/ParserTokens.h:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:09 PM Changeset in webkit [178953] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip flakey inspector test.
- 2:23 PM Changeset in webkit [178952] by
-
- 2 edits in trunk/Source/WebCore
SVGNames.cpp and HTMLNames.cpp are sometimes malformed
https://bugs.webkit.org/show_bug.cgi?id=140784
<rdar://problem/17701233>
Reviewed by David Kilzer.
Due to bad rules in DerivedSources.make, make_names.pl was called
several times with the same arguments during build. This is because
SVG/HTML/MathML each had several targets associated to the same
command. This would cause the command (make_names.pl) to be called
once per target. However, make_names.pl only needs to be executed
once to generate all of the files currently marked as target.
Calling make_names.pl several times for the same files is not only
wasteful, but it can also lead to malformed generated files if the
scripts instances are executed in parallel as they will read / write
from / to the same files.
This patch uses INTERMEDIATE targets instead so that we can still
indicate which files are generated by make_names.pl but only run
the script once.
This is a similar fix as for Bug 140756. There may several other
similar issues in DerivedSources.make but this patch focuses on
make_names.pl. I will take care of other in follow-ups if needed.
- DerivedSources.make:
- 2:21 PM Changeset in webkit [178951] by
-
- 4 edits in trunk/Source/WebCore
Have Counter::create() return a Ref<Counter>
https://bugs.webkit.org/show_bug.cgi?id=140777
Reviewed by Andreas Kling.
Have Counter::create() return a Ref<Counter> instead of a PassRefPtr.
The CSSPrimitiveValue class needed some updates as well to support
constructing a CSSPrimitiveValue object from a Ref<>.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/Counter.h:
(WebCore::Counter::create):
(WebCore::Counter::cloneForCSSOM):
- 2:20 PM Changeset in webkit [178950] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r178426. rdar://problem/19526069
- 2:19 PM Changeset in webkit [178949] by
-
- 21 edits4 deletes in trunk/Source
Drop the legacy FeatureCounter class
https://bugs.webkit.org/show_bug.cgi?id=140749
Reviewed by Andreas Kling.
Drop the legacy FeatureCounter class and use DiagnosticLoggingClient
instead.
Source/WebCore:
- CMakeLists.txt:
- Configurations/WebCore.xcconfig:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::logMemoryCacheResourceRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::mediaKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::reasonKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::resourceRequestKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::zoomedKey):
- page/DiagnosticLoggingKeys.h:
- page/Settings.in:
- platform/FeatureCounter.cpp: Removed.
- platform/FeatureCounter.h: Removed.
- platform/FeatureCounterKeys.h: Removed.
- platform/ios/FeatureCounter.mm: Removed.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::willStartUserTriggeredZooming):
- 2:17 PM Changeset in webkit [178948] by
-
- 2 edits in trunk/Source/WebCore
When extending the fallback transitions with their closure, we are modifying the Set while iterating it
https://bugs.webkit.org/show_bug.cgi?id=140785
Reviewed by Andreas Kling.
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::populateTransitions):
Make that in two steps: accumulate the fallback transitions then add the closure
of every element.
- 2:16 PM Changeset in webkit [178947] by
-
- 5 edits5 adds in branches/safari-600.5-branch
Merge r178038. rdar://problem/19451263
- 2:16 PM Changeset in webkit [178946] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merge r177611. rdar://problem/19451361
- 2:16 PM Changeset in webkit [178945] by
-
- 1 edit5 adds in branches/safari-600.5-branch/LayoutTests
Merge r177408. rdar://problem/19451330
- 2:16 PM Changeset in webkit [178944] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r177360. rdar://problem/19451319
- 2:13 PM Changeset in webkit [178943] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290
- http/tests/appcache/404-resource-with-slow-main-resource.php: Try updating the
tiemout, as it's not sufficient for appcache load to fail on some bots.
- http/tests/appcache/404-resource-with-slow-main-resource.php:
- 2:02 PM Changeset in webkit [178942] by
-
- 3 edits5 adds in branches/safari-600.5-branch
Merge r177292. rdar://problem/19452139
- 2:02 PM Changeset in webkit [178941] by
-
- 18 edits in branches/safari-600.5-branch/Source
Merge r177152. rdar://problem/19451288
- 1:57 PM Changeset in webkit [178940] by
-
- 118 edits2 moves in trunk/Source
Rename SimpleFontData to Font
https://bugs.webkit.org/show_bug.cgi?id=140496
Reviewed by Zalan Bujtas.
The fallback supporting Font type was renamed FontCascade.
We can now rename SimpleFontData to Font matching the usual definition.
- 1:54 PM Changeset in webkit [178939] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Make trailing whitespace handling more explicit.
https://bugs.webkit.org/show_bug.cgi?id=140776
Reviewed by Antti Koivisto.
Differentiate between committed and uncommitted trailing whitespace.
This enables further cleanup in removeTrailingWhitespace().
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun):
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::LineState::LineState): Deleted.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::LineState::resetTrailingWhitespace): Deleted.
- 1:40 PM Changeset in webkit [178938] by
-
- 6 edits in trunk/Source
ibtoold crash below -[WebView close]
https://bugs.webkit.org/show_bug.cgi?id=140782
-and corresponding-
rdar://problem/19558472
Reviewed by Tim Horton.
Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
Source/WebKit/mac:
it is because interface builder is messing with our views.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _cancelImmediateAction]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController _updateImmediateActionItem]):
Source/WebKit2:
it is because interface builder can mess with our views.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _cancelImmediateAction]):
(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):
(-[WKImmediateActionController _updateImmediateActionItem]):
- 1:04 PM Changeset in webkit [178937] by
-
- 6 edits2 adds in trunk
Crash in URL::protocol() after appcache load fails
https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290
Reviewed by Dan Bates.
Source/WebCore:
Test: http/tests/appcache/404-resource-with-slow-main-resource.php
Not every cache that isn't being updated is complete. It could also be in a zombie
state after failing to load. We get rid of the cache once the main resource finishes
loading, but while it's being loaded, the zombie still looks like a regular
candidate application cache.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isComplete):
- loader/appcache/ApplicationCache.h:
Removed const from isComplete(), because otherwise we couldn't use ApplicationCacheGroup::m_caches.contains().
Constness doesn't make a lot of sense for these objects anyway.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::failedLoadingMainResource): Toned down an assertion.
We can fail a main resource load when the document has a zombie appcache, too.
- loader/appcache/ApplicationCacheGroup.h:
(WebCore::ApplicationCacheGroup::cacheIsComplete):
(WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): Deleted.
These functions are only used in ApplicationCache::isComplete().
LayoutTests:
- http/tests/appcache/404-resource-with-slow-main-resource-expected.txt: Added.
- http/tests/appcache/404-resource-with-slow-main-resource.php: Added.
- 12:35 PM Changeset in webkit [178936] by
-
- 3 edits5 adds in branches/safari-600.5-branch
Merge r177033. rdar://problem/19451244
- 12:34 PM Changeset in webkit [178935] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merge r177011. rdar://problem/19451253
- 12:34 PM Changeset in webkit [178934] by
-
- 2 edits in branches/safari-600.5-branch/Source/WTF
Merge r176982. rdar://problem/19452174
- 12:34 PM Changeset in webkit [178933] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176971. rdar://problem/19452174
- 12:34 PM Changeset in webkit [178932] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176768. rdar://problem/19451369
- 12:03 PM Changeset in webkit [178931] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176285. rdar://problem/19452164
- 12:01 PM Changeset in webkit [178930] by
-
- 2 edits in trunk/Source/WebCore
Avoid defining always empty Vector<TextCheckingResult>
https://bugs.webkit.org/show_bug.cgi?id=140765
Reviewed by Alexey Proskuryakov.
Pass an empty vector direclty instead.
No new tests. No behavior change.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckCancel):
- 11:38 AM Changeset in webkit [178929] by
-
- 2 edits in trunk/Source/WebCore
makeprop.pl script is called too many times during build
https://bugs.webkit.org/show_bug.cgi?id=140756
<rdar://problem/19467942>
Reviewed by David Kilzer.
The makeprop.pl script was called 4 times (instead of once) during
build due to a bad Makefile rule in DerivedSources.make. makeprop.pl
had 4 associated targets and thus was called 4 times (with the same
parameter). Calling it once is sufficient to generate all 4 files
that were marked as target. This patch uses an INTERMEDIATE target
instead so that we can indicate that several files are generated
by the same command.
I believe this may be the reason for the sporatic build failures
that look like:
"""
CSSPropertyNames.gperf: No keywords in input file!
calling gperf failed: 256 at WebCore/css/makeprop.pl line 1036.
"""
The makeprop.pl script is generating gperf's input file and calling the
gperf executable on this file. If the script is executed several times
in parallel, it would explain the build failures as several instances
of makeprop.pl may be writing / reading from the same
CSSPropertyNames.gperf file.
- DerivedSources.make:
- 11:34 AM Changeset in webkit [178928] by
-
- 31 edits3 deletes in trunk
Unreviewed, rolling out r178894.
https://bugs.webkit.org/show_bug.cgi?id=140775
Broke JSC and bindings tests (Requested by ap_ on #webkit).
Reverted changeset:
"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
https://bugs.webkit.org/show_bug.cgi?id=140426
http://trac.webkit.org/changeset/178894
- 11:27 AM Changeset in webkit [178927] by
-
- 9 edits2 copies1 add in trunk/Source
[iOS] Fix iphoneos SDK builds for ios-ews queue
<http://webkit.org/b/140748>
Reviewed by Daniel Bates.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add new SPI headers.
- platform/graphics/cg/ImageBufferCG.cpp: Switch to using
"IOSurfaceSPI.h" from <IOSurface/IOSurface.h>.
- platform/graphics/cg/ImageBufferDataCG.cpp: Ditto.
- platform/graphics/cocoa/IOSurface.mm: Ditto. Move definitions
in <IOSurface/IOSurfacePrivate.h> into "IOSurfaceSPI.h".
- platform/spi/cg/CoreGraphicsSPI.h: Switch to
WTF_EXTERN_C_{BEGIN,END}. Add
CGContextGetFontAntialiasingStyle() and
CGContextSetFontAntialiasingStyle().
- platform/spi/cocoa/IOPMLibSPI.h: Switch to use IOReturnSPI.h.
- platform/spi/cocoa/IOReturnSPI.h: Add.
- platform/spi/cocoa/IOSurfaceSPI.h: Add.
- platform/spi/cocoa/IOTypesSPI.h: Add.
Source/WebKit2:
- Platform/spi/ios/BKSProcessAssertionSPI.h: Add -invalidate
definition. Sort @property to the top of BKSProcessAssertion.
- 11:05 AM Changeset in webkit [178926] by
-
- 5 edits3 adds in trunk
BytecodeGenerator::initializeCapturedVariable() sets a misleading value for the 5th operand of op_put_to_scope.
<https://webkit.org/b/140743>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
BytecodeGenerator::initializeCapturedVariable() was setting the 5th operand to
op_put_to_scope to an inappropriate value (i.e. 0). As a result, the execution
of put_to_scope could store a wrong inferred value into the VariableWatchpointSet
for which ever captured variable is at local index 0. In practice, this turns
out to be the local for the Arguments object. In this reproduction case in the
bug, the wrong inferred value written there is the boolean true.
Subsequently, DFG compilation occurs and CreateArguments is emitted to first do
a check of the local for the Arguments object. But because that local has a
wrong inferred value, the check always discovers a non-null value and we never
actually create the Arguments object. Immediately after this, an OSR exit
occurs leaving the Arguments object local uninitialized. Later on at arguments
tear off, we run into a boolean true where we had expected to find an Arguments
object, which in turn, leads to the crash.
The fix is to:
- In the case where the resolveModeType is LocalClosureVar, change the 5th operand of op_put_to_scope to be a boolean. True means that the local var is watchable. False means it is not watchable. We no longer pass the local index (instead of true) and UINT_MAX (instead of false).
This allows us to express more clearer in the code what that value means,
as well as remove the redundant way of getting the local's identifier.
The identifier is always the one passed in the 2nd operand.
- Previously, though intuitively, we know that the watchable variable identifier should be the same as the one that is passed in operand 2, this relationship was not clear in the code. By code analysis, I confirmed that the callers of BytecodeGenerator::emitPutToScope() always use the same identifier for operand 2 and for filling out the ResolveScopeInfo from which we get the watchable variable identifier later. I've changed the code to make this clear now by always using the identifier passed in operand 2.
- In the case where the resolveModeType is LocalClosureVar, initializeCapturedVariable() and emitPutToScope() will now query hasWatchableVariable() to determine if the local is watchable or not. Accordingly, we pass the boolean result of hasWatchableVariable() as operand 5 of op_put_to_scope.
Also added some assertions.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::initializeCapturedVariable):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::emitPutToScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasWatchableVariable):
(JSC::BytecodeGenerator::watchableVariableIdentifier):
(JSC::BytecodeGenerator::watchableVariable): Deleted.
LayoutTests:
- js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Added.
- js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Added.
- js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Added.
(foo):
- 10:51 AM Changeset in webkit [178925] by
-
- 2 edits in trunk/Tools
[iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
runtime in simctl output
https://bugs.webkit.org/show_bug.cgi?id=140751
Reviewed by David Kilzer.
Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
with an error because it does not know how to parse the output of the simctl tool
to identify an Apple Internal runtime.
- Scripts/webkitpy/xcode/simulator.py:
(Runtime.init): Add parameter is_internal_runtime (defaults to False).
(Runtime.eq): Take is_internal_runtime when comparing two Runtime objects for equality.
(Runtime.repr): Update printable representation of Runtime object to indicate whether
the runtime is an internal runtime.
(Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
(Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
appropriate value.
(Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
it updates the appropriate Runtime object.
(Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
looking up a Runtime object for an internal runtime.
- 10:47 AM Changeset in webkit [178924] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r175771. rdar://problem/19451238
- 10:47 AM Changeset in webkit [178923] by
-
- 7 edits in branches/safari-600.5-branch/Source/WebKit2
Merge r175759. rdar://problem/19450899
- 10:47 AM Changeset in webkit [178922] by
-
- 4 edits2 adds in branches/safari-600.5-branch
Merge r175131. rdar://problem/19452187
- 10:46 AM Changeset in webkit [178921] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r174716. rdar://problem/19451273
- 10:46 AM Changeset in webkit [178920] by
-
- 3 edits in branches/safari-600.5-branch
Merge r174698. rdar://problem/19451342
- 10:25 AM Changeset in webkit [178919] by
-
- 8 edits5 adds in trunk/LayoutTests
[Win] More unskips and rebaselines.
- platform/win/TestExpectations:
- platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
- platform/win/inspector-protocol: Added.
- platform/win/inspector-protocol/debugger: Added.
- platform/win/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
- platform/win/inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
- platform/win/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
- platform/win/svg/text/kerning-expected.txt:
- platform/win/svg/text/multichar-glyph-expected.txt:
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- 10:07 AM Changeset in webkit [178918] by
-
- 3 edits in trunk/Source/JavaScriptCore
PropertyListNode::emitNode duplicates the code to put a constant property
https://bugs.webkit.org/show_bug.cgi?id=140761
Reviewed by Geoffrey Garen.
Extracted PropertyListNode::emitPutConstantProperty to share the code.
Also made PropertyListNode::emitBytecode private since nobody is calling this function directly.
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty): Added.
- parser/Nodes.h:
- 9:59 AM Changeset in webkit [178917] by
-
- 2 edits in trunk/Tools
LeaksViewer doesn't show recent builds if there are less than 10
https://bugs.webkit.org/show_bug.cgi?id=140716
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
- 9:21 AM Changeset in webkit [178916] by
-
- 3 edits in trunk/WebKitLibraries
[Win] Unreviewed gardening.
Activate ENABLE(MOUSE_CURSOR_SCALE). This works on Windows and causes more tests to pass.
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 5:46 AM Changeset in webkit [178915] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix up slave distribution for Apple bots.
- 5:14 AM Changeset in webkit [178914] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix json.
- 5:12 AM Changeset in webkit [178913] by
-
- 2 edits in trunk/Tools
Add Apple build slaves.
Fixed text alignment for slave list.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:22 AM Changeset in webkit [178912] by
-
- 4 edits2 adds in trunk/LayoutTests
AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
https://bugs.webkit.org/show_bug.cgi?id=140721
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-22
Reviewed by Chris Fleizach.
The test checks the heuristic to determine if a 'list' is really a list.
In the area of ATK a role for description list has been separated from the role AXList.
This made the test stopped giving positive results for ports EFL and GTK.
The proposed amendment restores test for these ports.
- accessibility/list-detection.html:
- platform/efl/TestExpectations:
- platform/efl/accessibility/list-detection-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/list-detection-expected.txt: Added.
- 2:35 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:23 AM Changeset in webkit [178911] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Expected gutter highlight when selecting console input line, just like output line
https://bugs.webkit.org/show_bug.cgi?id=140696
Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-01-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
- 2:21 AM Changeset in webkit [178910] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning in WebKit2/UIProcess module
https://bugs.webkit.org/show_bug.cgi?id=140758
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2015-01-22
Reviewed by Csaba Osztrogonác.
Fix build warnings by using UNUSED_PARAM macro
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):
- 2:18 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:09 AM Changeset in webkit [178909] by
-
- 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore
Merge r174381. rdar://problem/19450841
- 2:08 AM Changeset in webkit [178908] by
-
- 2 edits in branches/safari-600.5-branch/Source/WTF
Merge r174377. rdar://problem/19451247
- 2:08 AM Changeset in webkit [178907] by
-
- 8 edits in branches/safari-600.5-branch/Source/JavaScriptCore
Merge r174371. rdar://problem/19450845
- 2:08 AM Changeset in webkit [178906] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r174345. rdar://problem/19451258
- 2:08 AM Changeset in webkit [178905] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r173790. rdar://problem/19451354
- 2:04 AM WebKitGTK/Roadmap edited by
- (diff)
- 1:32 AM Changeset in webkit [178904] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r173688. rdar://problem/19451277
- 1:31 AM Changeset in webkit [178903] by
-
- 4 edits32 adds in branches/safari-600.5-branch
Merge r172797. rdar://problem/19451324
- 1:31 AM Changeset in webkit [178902] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit
Merge r172509. rdar://problem/19451367
- 1:31 AM Changeset in webkit [178901] by
-
- 6 edits2 adds in branches/safari-600.5-branch
Merge r172504. rdar://problem/19451367
- 1:31 AM Changeset in webkit [178900] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r172326. rdar://problem/19452126
- 1:11 AM Changeset in webkit [178899] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171404. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178898] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171392. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178897] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171388. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178896] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171385. rdar://problem/19451349
- 12:56 AM Changeset in webkit [178895] by
-
- 4 edits2 adds in trunk
[CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
https://bugs.webkit.org/show_bug.cgi?id=140720
Reviewed by David Hyatt.
Source/WebCore:
Section "11.5. Resolve Intrinsic Track Sizes" of the specs forces
us to ignore items spanning tracks with flex sizing functions when
resolving the content-based track sizing functions. Items with
span < 2 are not affected by this rule (as they will belong to a
single track). This way the algorithm ensures that min-content and
max-content restrictions are fulfilled before distributing the
extra space.
Test: fast/css-grid-layout/flex-and-content-sized-resolution-columns.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::spanningItemCrossesFlexibleSizedTracks):
(WebCore::integerSpanForDirection):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
- rendering/RenderGrid.h:
LayoutTests:
- fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-and-content-sized-resolution-columns.html: Added.
- 12:54 AM Changeset in webkit [178894] by
-
- 31 edits3 adds in trunk
put_by_val_direct need to check the property is index or not for using putDirect / putDirectIndex
https://bugs.webkit.org/show_bug.cgi?id=140426
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
In the put_by_val_direct operation, we use JSObject::putDirect.
However, it only accepts non-index property. For index property, we need to use JSObject::putDirectIndex.
This patch changes Identifier::asIndex() to return Optional<uint32_t>.
It forces callers to check the value is index or not explicitly.
Additionally, it checks toString-ed Identifier is index or not to choose putDirect / putDirectIndex.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDirectPutById):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::emitPutTransitionStubAndGetOldStructure):
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnProperty):
- runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):
- runtime/JSString.cpp:
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::getStringPropertySlot):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::parse):
- runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
(JSC::toUInt32FromStringImpl):
(JSC::PropertyName::asIndex):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
- runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
Source/WebCore:
Test: js/dfg-put-by-val-direct-with-edge-numbers.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):
LayoutTests:
- js/dfg-put-by-val-direct-with-edge-numbers-expected.txt: Added.
- js/dfg-put-by-val-direct-with-edge-numbers.html: Added.
- js/script-tests/dfg-put-by-val-direct-with-edge-numbers.js: Added.
(lookupWithKey):
(dfgShouldThrow):
(lookupWithKey2):
(toStringThrowsError.toString):
- 12:36 AM Changeset in webkit [178893] by
-
- 6 edits in trunk
[CSS Grid Layout] Size tracks using a list of all items sorted by span
https://bugs.webkit.org/show_bug.cgi?id=140615
Reviewed by Andreas Kling.
Source/WebCore:
In r173620 we fixed
RenderGrid::resolveContentBasedTrackSizingFunctions() so that it
now collects all items spanning content-sized tracks and process
them one by one after sorting them by ascending span.
The problem is that it was incorrectly implemented, it has two
important bugs. First one is that the hash table that collects
items is regenerated after processing each track, so it's actually
doing nothing. Secondly we're only sorting the items on each
track, instead of all the items in the grid.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
LayoutTests:
- fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
Added tons of new test cases.
- fast/css-grid-layout/grid-content-sized-columns-resolution.html: Ditto.
- fast/css-grid-layout/grid-preferred-logical-widths.html:
Adjusted results.
- 12:30 AM Changeset in webkit [178892] by
-
- 11 edits in trunk/Source/WebKit2
[GTK] Use API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
https://bugs.webkit.org/show_bug.cgi?id=138467
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuPopulate): Add a version that receives a Vector<WebContextMenuItemData>&.
(webkitContextMenuCreate): Change it to receive a const
Vector<WebContextMenuItemData>& instead of a API::Array* and also
add a another version that receives const Vector<ContextMenuItem>&.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView): Use a class derived from
API::ContextMenuClient to implement the context menu client.
(getContextMenuFromProposedMenu): Deleted.
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate): Change it to receive a const
WebContextMenuItemData& and added another version that receives a
const ContextMenuItem&.
- UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
- UIProcess/API/gtk/WebKitContextMenuPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu): Remove the creation of a
WebHitTestResult::Data, since it receives it now as parameter.
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp:
(webkitWebHitTestResultCreate): Change it to receive a const
HitTestResult& instead of const InjectedBundleHitTestResult&.
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Use a class derived from
API::InjectedBundle::PageContextMenuClient to implement the
context menu client.
(getContextMenuFromDefaultMenu): Deleted.
- 12:05 AM Changeset in webkit [178891] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Try to fix Debug build after r178889.
- UIProcess/API/C/WKPage.cpp: Include Logging.h.
- 12:02 AM Changeset in webkit [178890] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171357. rdar://problem/19451349
Jan 21, 2015:
- 11:53 PM Changeset in webkit [178889] by
-
- 13 edits1 copy1 move1 delete in trunk/Source/WebKit2
Add API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
https://bugs.webkit.org/show_bug.cgi?id=138466
Reviewed by Anders Carlsson.
Move ContextMenuClient to use API classes in both UI and Injected
Bundle APIs.
- CMakeLists.txt: Remove WebPageContextMenuClient.cpp.
- UIProcess/API/APIContextMenuClient.h: Renamed from Source/WebKit2/UIProcess/WebPageContextMenuClient.h.
(API::ContextMenuClient::~ContextMenuClient):
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::customContextMenuItemSelected):
(API::ContextMenuClient::contextMenuDismissed):
(API::ContextMenuClient::showContextMenu):
(API::ContextMenuClient::hideContextMenu):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
- UIProcess/WebPageContextMenuClient.cpp: Removed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setContextMenuClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::initializeContextMenuClient): Deleted.
- UIProcess/WebPageProxy.h:
- WebKit2.xcodeproj/project.pbxproj: Remove deleted files and add
new files to compilation.
- WebProcess/InjectedBundle/API/APIInjectedBundlePageContextMenuClient.h: Copied from Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h.
(API::InjectedBundle::PageContextMenuClient::~PageContextMenuClient):
(API::InjectedBundle::PageContextMenuClient::getCustomMenuFromDefaultItems):
(API::InjectedBundle::PageContextMenuClient::prepareForActionMenu):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
(WebKit::InjectedBundlePageContextMenuClient::InjectedBundlePageContextMenuClient):
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
(WebKit::InjectedBundlePageContextMenuClient::prepareForActionMenu):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::menuItemsWithUserData):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setInjectedBundleContextMenuClient):
(WebKit::WebPage::close):
(WebKit::WebPage::initializeInjectedBundleContextMenuClient): Deleted.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleContextMenuClient):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
- 10:39 PM Changeset in webkit [178888] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
Consolidate out arguments of parseFunctionInfo into a struct
https://bugs.webkit.org/show_bug.cgi?id=140754
Reviewed by Oliver Hunt.
Introduced ParserFunctionInfo for storing out arguments of parseFunctionInfo.
- JavaScriptCore.xcodeproj/project.pbxproj:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty): This one takes a property name in addition to
ParserFunctionInfo since the property name and the function name could differ.
(JSC::ASTBuilder::createFuncDeclStatement):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/Parser.h:
- parser/ParserFunctionInfo.h: Added.
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createClassDeclStatement):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
- 10:01 PM Changeset in webkit [178887] by
-
- 14 edits4 adds in trunk/LayoutTests
[Win] Rebaseline SVG results from test machine.
- platform/win/css2.1/20110323/c543-txt-decor-000-expected.png: Added.
- platform/win/css2.1/20110323/c543-txt-decor-000-expected.txt: Added.
- platform/win/css2.1/20110323/replaced-elements-001-expected.png: Added.
- platform/win/css2.1/20110323/replaced-elements-001-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- platform/win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
- platform/win/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
- 9:31 PM Changeset in webkit [178886] by
-
- 2 edits in trunk/LayoutTests
[Win] Update expectations file for failures on test machine.
- platform/win/TestExpectations:
- 8:57 PM Changeset in webkit [178885] by
-
- 2 edits2 adds in trunk/LayoutTests
[Win] Add more tests and baselines.
Stop skipping a number of tests that are fully functional. Add some
Windows baselines.
- platform/win/TestExpectations:
- platform/win/printing/setPrinting-expected.txt: Added.
- platform/win/printing/width-overflow-expected.txt: Added.
- 6:56 PM Changeset in webkit [178884] by
-
- 4 edits in trunk/Source/JavaScriptCore
Change Heap::m_compiledCode to use a Vector
https://bugs.webkit.org/show_bug.cgi?id=140717
Reviewed by Andreas Kling.
Right now it's a DoublyLinkedList, which is iterated during each
collection. This contributes to some of the longish Eden pause times.
A Vector would be more appropriate and would also allow ExecutableBase
to be 2 pointers smaller.
- heap/Heap.cpp:
(JSC::Heap::deleteAllCompiledCode):
(JSC::Heap::deleteAllUnlinkedFunctionCode):
(JSC::Heap::clearUnmarkedExecutables):
- heap/Heap.h:
- runtime/Executable.h: No longer need to inherit from DoublyLinkedListNode.
- 6:08 PM Changeset in webkit [178883] by
-
- 2 edits in trunk/LayoutTests
[Win] More gardening.
Unskip the flexbox tests. These have been functional in Windows for YEARS!
- platform/win/TestExpectations:
- 6:06 PM Changeset in webkit [178882] by
-
- 4 edits in trunk/Source/JavaScriptCore
BytecodeGenerator shouldn't expose all of its member variables
https://bugs.webkit.org/show_bug.cgi?id=140752
Reviewed by Mark Lam.
Added "private:" and removed unused data members as detected by clang.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::lastOpcodeID): Added. Used in BinaryOpNode::emitBytecode.
- bytecompiler/NodesCodegen.cpp:
(JSC::BinaryOpNode::emitBytecode):
- 6:06 PM Changeset in webkit [178881] by
-
- 2 edits in trunk/Tools
Teach build.webkit.org about bot308 and bot309.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 5:31 PM Changeset in webkit [178880] by
-
- 2 edits in trunk/LayoutTests
[Win] Gardening pass over file.
Convert Skips to Failure wherever possible. Try to delete unnecessary skips/failures.
- platform/win/TestExpectations:
- 5:21 PM Changeset in webkit [178879] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r178072. rdar://problem/19395123
- 5:20 PM Changeset in webkit [178878] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177329. rdar://problem/19419784
- 5:19 PM Changeset in webkit [178877] by
-
- 3 edits1 copy in branches/safari-600.1.4.15-branch
Merged r177115. rdar://problem/19420090
- 5:10 PM Changeset in webkit [178876] by
-
- 2 edits in trunk/LayoutTests
After updating tests to use kerning, ligatures, and printer fonts, some tests fail
https://bugs.webkit.org/show_bug.cgi?id=139968
- platform/mac/TestExpectations:
Mark svg/custom/svg-fonts-without-missing-glyph.xhtml as flaky.
- 5:03 PM Changeset in webkit [178875] by
-
- 4 edits in trunk
Web Inspector: ASSERT expanding objects in console PrimitiveBindingTraits<T>::assertValueHasExpectedType
https://bugs.webkit.org/show_bug.cgi?id=140746
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-21
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
Do not add impure properties to the descriptor object that will
eventually be sent to the frontend.
LayoutTests:
Unskip the test now that is doesn't ASSERT in debug builds.
- 4:50 PM Changeset in webkit [178874] by
-
- 2 edits in trunk/Source/WebCore
Fix the iOS release build after <http://trac.webkit.org/changeset/178868>
(https://bugs.webkit.org/show_bug.cgi?id=140742)
Substitute ASSERT_UNUSED() for ASSERT() since the parameter layer is used only in the assertion expression.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack):
- 4:22 PM Changeset in webkit [178873] by
-
- 2 edits in trunk/Tools
Add two Apple Mavericks slaves.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:04 PM Changeset in webkit [178872] by
-
- 3 edits90 deletes in trunk/LayoutTests
Update iOS WebKit2 expected results for compositing tests
Following the patch for bug #140742, <https://bugs.webkit.org/show_bug.cgi?id=140742>, we can remove
all iOS WebKit2-specific expected results that are identical to the platform-independent results.
- platform/ios-simulator-wk2/TestExpectations: Add WebKit2-specific failures: compositing/reflections/nested-reflection-on-overflow.html
and compositing/repaint/invalidations-on-composited-layers.html.
- platform/ios-simulator-wk2/compositing/absolute-inside-out-of-view-fixed-expected.txt: Removed.
[...]
- platform/ios-simulator-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Removed.
- platform/ios-simulator-wk2/compositing/visibility/layer-visible-content-expected.txt: Removed.
- platform/ios-simulator-wk2/compositing/visible-rect/3d-transform-style-expected.txt: Removed.
- platform/ios-simulator/TestExpectations: Remove tests that now pass in both iOS WebKit1 and WebKit2.
- 3:56 PM WebKitGTK/Roadmap edited by
- Add link to long-tap context-menu bug (diff)
- 3:52 PM Changeset in webkit [178871] by
-
- 3 edits in trunk/LayoutTests
Update iOS WebKit test expectations for compositing tests
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 3:47 PM WebKitGTK/Roadmap edited by
- Add link to Python web-extension bug (diff)
- 3:47 PM Changeset in webkit [178870] by
-
- 7 edits in trunk/Source/WebKit2
[iOS] WebKitTestRunner: Tests fail due to incorrect web view size
<https://bugs.webkit.org/show_bug.cgi?id=139736>
<rdar://problem/19282196>
This starts happening after we fail to reset the test controller to
consistent values in TestInvocation::invoke(). When we terminate the
web process and relaunch it, the new WebPage object created in the web
process is using the default ViewportConfiguration with dimensions of
1024x768.
The PageClient on iOS currently notifies the WKWebView and the
WKContentView when the web process is relaunched. This patch extends
that to also notify the WKView.
Reviewed by Benjamin Poulain.
- UIProcess/API/Cocoa/WKViewPrivate.h:
Declare -_didRelaunchProcess.
- UIProcess/API/ios/WKViewIOS.mm:
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
Call the new method that accepts a WKView.
(-[WKView _didRelaunchProcess]):
Call -_frameOrBoundsChanged to update the web process's size to the
size of the WKView.
- UIProcess/ios/PageClientImplIOS.h:
Add a constructor that takes a WKView, and add a member var to hold it.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClientImpl):
Implement the constructor that takes a WKView.
(WebKit::PageClientImpl::didRelaunchProcess):
Tell the WKView that the web process relaunched.
- UIProcess/ios/WKContentView.h:
Declare an initializer that takes a WKView.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
Split out from -[WKContentView initWithFrame:processPool:configuration:webView:].
(-[WKContentView initWithFrame:processPool:configuration:webView:]):
Perform some initialization, including creating the PageClient, and
call the common initializer.
(-[WKContentView initWithFrame:processPool:configuration:wkView:]):
Ditto.
- 3:44 PM Changeset in webkit [178869] by
-
- 10 edits in trunk/Source/WebKit2
Add WKPageGroupRef SPI for user content filters
https://bugs.webkit.org/show_bug.cgi?id=140728
Reviewed by Anders Carlsson.
While Safari is transitioning to WKUserContentController, it is useful
for them to have access to have access to content filters on the page group
where they currently have user content related functionality.
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
- Shared/WebPageGroupData.h:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):
- UIProcess/API/C/WKPageGroup.h:
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::addUserContentFilter):
(WebKit::WebPageGroup::removeAllUserContentFilters):
- UIProcess/WebPageGroup.h:
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::addUserContentFilter):
(WebKit::WebPageGroupProxy::removeAllUserContentFilters):
- WebProcess/WebPage/WebPageGroupProxy.h:
- WebProcess/WebPage/WebPageGroupProxy.messages.in:
- 3:42 PM Changeset in webkit [178868] by
-
- 8 edits1 delete in trunk
[iOS] Many compositing tests fail in DumpRenderTree due to contentsOpaque difference
https://bugs.webkit.org/show_bug.cgi?id=140742
Reviewed by Simon Fraser.
Source/WebCore:
Make RenderLayerBacking::layerTreeAsText() (including internals.layerTreeAsText()) always
report that the main frame's RenderView layer is opaque when running iOS DumpRenderTree to
avoid test failures and the need to maintain for iOS WebKit1 an almost identical copy of the
platform-independent compositing test results.
The main frame's RenderView layer is always transparent in iOS WebKit1 since it does
not make use of a tiled cache layer and defers to UIKit to handle the final compositing
of the web view, including applying the page scale factor.
- platform/RuntimeApplicationChecksIOS.mm:
(WebCore::applicationIsDumpRenderTree): The app bundle identifier of DumpRenderTree has
the form org.webkit.DumpRenderTreeX where X is some non-negative integer.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties): Modified to report that a layer is opaque when
GraphicsLayerClient::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack() returns true.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack): Added
default implementation (returns false).
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::needsIOSDumpRenderTreeMainFrameRenderViewLayerIsAlwaysOpaqueHack): Added;
returns true when running in DumpRenderTree and the passed GraphicsLayer corresponds to the main frame's
RenderView layer.
- rendering/RenderLayerBacking.h:
LayoutTests:
Update test expectations and remove an unnecessary test result.
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/compositing/backing/backface-visibility-flip-expected.txt: Removed.
- 3:29 PM Changeset in webkit [178867] by
-
- 4 edits2 adds in trunk
Add iOS WebKit1 TestExpectation file
https://bugs.webkit.org/show_bug.cgi?id=140739
Reviewed by David Kilzer.
Tools:
Teach run-webkit-tests to look for iOS WebKit1-specific test results and
expectations in directory LayoutTests/platform/ios-simulator-wk1.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_baseline_search_path):
LayoutTests:
iOS WebKit1 is different enough from iOS WebKit2 that it would benefit from having its
own TestExpectation file. We can work to reduce such differences over time.
- platform/ios-simulator-wk1/TestExpectations: Added.
- platform/ios-simulator/TestExpectations: Move iOS WebKit1-specific test expectation from here
to file LayoutTests/platform/ios-simulator-wk1/TestExpectations.
- 3:21 PM Changeset in webkit [178866] by
-
- 2 edits in trunk/Tools
[iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
<http://webkit.org/b/140704>
Reviewed by Daniel Bates.
- Scripts/configure-xcode-for-ios-development:
- Update copyright.
- Remove FIXME addressed by r178709.
- Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
(copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
missing headers from iphonesimulator SDK to iphoneos SDK.
(sdkDirectory): Add method that returns SDK directory.
(sdkPlatformDirectory): Extract method from
xcodeSDKSpecificationsPath() that returns SDK platform
directory.
(xcodeSDKSpecificationsPath): Update to use
sdkPlatformDirectory().
- 3:14 PM Changeset in webkit [178865] by
-
- 2 edits in trunk/Source/WebCore
WebGL2 (spec section 3.1): Add new types to WebGL2 API.
https://bugs.webkit.org/show_bug.cgi?id=140741.
<rdar://problem/19552962>
Reviewed by Dean Jackson.
- html/canvas/WebGL2RenderingContext.idl:
- 3:04 PM Changeset in webkit [178864] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Change Annotator's isActive getter into an isActive() function.
https://bugs.webkit.org/show_bug.cgi?id=140729
Reviewed by Timothy Hatcher.
This patch also makes the child classes of Annotator use
the function instead of accessing the property directly.
- UserInterface/Controllers/Annotator.js:
(WebInspector.Annotator.prototype.isActive):
(WebInspector.Annotator.prototype.get isActive): Deleted.
- UserInterface/Controllers/BasicBlockAnnotator.js:
(WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
(WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
(WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
- 2:51 PM Changeset in webkit [178863] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't allow the BasicBlockAnnotator to highlight a section if it's only a closing brace
https://bugs.webkit.org/show_bug.cgi?id=140727
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/BasicBlockAnnotator.js:
(WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
(WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyClosingBrace):
BasicBlockAnnotator tries to no longer highlight a basic block if it is only
whitespace and a closing brace. These ranges are often after statements
that make these basic blocks unreachable, such as a return/break/continue
statement occurring inside a if/else/while/for block. This check won't
match every highlighted empty closing brace, but catches most of them
because it only does intra block analysis instead of inter block analysis.
- 2:51 PM Changeset in webkit [178862] by
-
- 4 edits in trunk/Source/WebCore
Simple line layout: Move nextTextFragment() to FlowContents class.
https://bugs.webkit.org/show_bug.cgi?id=140738
Reviewed by Antti Koivisto.
This is in preparation to make FlowContents an iterator class.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::addUncommittedWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::TextFragment::TextFragment): Deleted.
(WebCore::SimpleLineLayout::TextFragment::isEmpty): Deleted.
(WebCore::SimpleLineLayout::nextFragment): Deleted.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::nextTextFragment):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::FlowContents::TextFragment::isEmpty):
- 2:49 PM Changeset in webkit [178861] by
-
- 14 edits2 adds in trunk
bmalloc: support aligned allocation
https://bugs.webkit.org/show_bug.cgi?id=140732
Reviewed by Andreas Kling.
PerformanceTests:
- MallocBench/MallocBench.xcodeproj/project.pbxproj:
- MallocBench/MallocBench/Benchmark.cpp:
- MallocBench/MallocBench/memalign.cpp:
(test):
(benchmark_memalign): Added a test for specific interesting memalign values.
- MallocBench/MallocBench/stress_aligned.cpp: Added.
(benchmark_stress_aligned):
- MallocBench/MallocBench/stress_aligned.h: Added. Added a stress test
for arbitrary memalign values.
Source/bmalloc:
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::allocate): New function for aligned allocation.
Small and medium requests just allocate and free until they find an
aligned pointer. This is slightly inefficient in the worst case, but
still constant-time with little-to-no space overhead.
Large requests use a new API that requires the client to specify both
its ideal size and alignment, and the worst-case size you would have to
allocate in order to produce some interior pointer of the requested size
and alignment. We put the burden of this calculation on the client
because it simplifies things if we guarantee that allocation won't fail.
XLarge requests are easy: we just forward them to vmAllocate, which
already supported aligned requests.
- bmalloc/BoundaryTag.h:
- bmalloc/BoundaryTagInlines.h:
(bmalloc::BoundaryTag::mergeLeft):
(bmalloc::BoundaryTag::mergeRight):
(bmalloc::BoundaryTag::merge):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::split):
(bmalloc::BoundaryTag::allocate): No behavior change here. I just
refactored the interface to remove some reference out parameters in
order to clarify what changes and what doesn't.
- bmalloc/Heap.cpp:
(bmalloc::Heap::allocateXLarge): Added an alignment API.
(bmalloc::Heap::allocateLarge):
- bmalloc/Heap.h: Added an alignment API. I split out allocateLarge into
a few variants, so aligned and unaligned allocation could share some code.
- bmalloc/SegregatedFreeList.cpp:
(bmalloc::SegregatedFreeList::take):
- bmalloc/SegregatedFreeList.h: Changed to use a separate, explicit API
for aligned allocation. It turns out that the aligned path is pretty
different, since it ends up searching for two potential ways to satisfy
an allocation: either large enough and aligned, or large enough to split
into something not aligned and something large enough and aligned.
- bmalloc/VMAllocate.h:
(bmalloc::vmAllocate): Switched alignment to come before size because
that's how the memalign API specifies it.
- bmalloc/VMHeap.h:
(bmalloc::VMHeap::allocateLargeRange): Added an alignment API.
- 2:43 PM Changeset in webkit [178860] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Updated split such that it does not include the empty end of input string match.
https://bugs.webkit.org/show_bug.cgi?id=138129
<rdar://problem/18807403>
Reviewed by Filip Pizlo.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncSplit):
- tests/stress/empty_eos_regex_split.js: Added.
- 2:33 PM Changeset in webkit [178859] by
-
- 13 edits in trunk/Source/WebCore
DocumentLoader::timing() should return a reference.
<https://webkit.org/b/128272>
Reviewed by Antti Koivisto.
There is always a DocumentLoadTiming object, so return it by
reference since it can never be null.
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::from):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForTiming):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::timing):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
- page/Performance.cpp:
(WebCore::Performance::now):
- page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::redirectCount):
- page/PerformanceResourceTiming.cpp:
(WebCore::monotonicTimeToDocumentMilliseconds):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):
- page/PerformanceTiming.cpp:
(WebCore::PerformanceTiming::documentLoadTiming):
- 2:30 PM Changeset in webkit [178858] by
-
- 4 edits in trunk/Source
Crash in QuickLook preview delegate method
https://bugs.webkit.org/show_bug.cgi?id=140740
-and corresponding-
rdar://problem/19540806
Reviewed by Tim Horton.
Clear out the delegate.
Source/WebKit/mac:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webViewClosed]):
Source/WebKit2:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
- 1:56 PM Changeset in webkit [178857] by
-
- 8 edits in trunk/Source/WebCore
Handle the transition on any character as a separate type of transition
https://bugs.webkit.org/show_bug.cgi?id=140711
Reviewed by Andreas Kling.
Instead of considering the universal transition as 127 transitions, it is now
handled as a separate type of transition.
The goal is to reduce the number of exit edge to consider for each node. Instead
of having 127 for any partition containing one universal transition, we have
as few exit edges as necessary + one universal transition.
In the NFA, the universal transition is stored directly on NFANode in a new
HashSet (transitionsOnAnyCharacter).
The target nodes are made exclusive between "transitionsOnAnyCharacter" and "transitions"
by construction. That is not strictly needed but it simplify debugging at the moment.
When converting a NFA to a DFA, we first find all the node that transition on any character.
Then, when we iterate over "real" transition, we also augment that set with the set on
any character.
When creating the DFA node, we first consider each "real" transition, then we have a single
"fallback" transition for any character that has not been handled yet.
When matching, we first search for any real transition. If there is none but a fallback exists,
we take the fallback.
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::nextState):
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::DFA::debugPrintDot):
(WebCore::ContentExtensions::printTransition): Deleted.
- contentextensions/DFANode.h:
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::addTransition):
(WebCore::ContentExtensions::NFA::addTransitionsOnAnyCharacter):
(WebCore::ContentExtensions::printTransitions):
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::printTransition): Deleted.
- contentextensions/NFA.h:
- contentextensions/NFANode.h:
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::populateTransitions):
(WebCore::ContentExtensions::getOrCreateDFANode):
(WebCore::ContentExtensions::NFAToDFA::convert):
- contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::GraphBuilder::generateTransition):
- 1:43 PM Changeset in webkit [178856] by
-
- 22 edits in trunk/Source/JavaScriptCore
Eliminate Scope slot from JavaScript CallFrame
https://bugs.webkit.org/show_bug.cgi?id=136724
Reviewed by Geoffrey Garen.
This finishes the removal of the scope chain slot from the call frame header.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- ftl/FTLJSCall.cpp:
(JSC::FTL::JSCall::emit):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- interpreter/JSStack.h:
- interpreter/VMInspector.cpp:
(JSC::VMInspector::dumpFrame):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
- jit/Repatch.cpp:
(JSC::generateByIdStub):
(JSC::linkClosureCall):
- jit/ThunkGenerators.cpp:
(JSC::virtualForThunkGenerator):
(JSC::nativeForGenerator):
Deleted ScopeChain slot from JSStack. Removed all code where ScopeChain was being
read or set. In most cases this was where we make JS calls.
- interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::setArgument):
(JSC::CallFrameClosure::resetCallFrame): Deleted.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- interpreter/ProtoCallFrame.cpp:
(JSC::ProtoCallFrame::init):
- interpreter/ProtoCallFrame.h:
(JSC::ProtoCallFrame::scope): Deleted.
(JSC::ProtoCallFrame::setScope): Deleted.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
Removed the related scopeChainValue member from ProtoCallFrame. Reduced the number of
registers that needed to be copied from the ProtoCallFrame to a callee's frame
from 5 to 4.
- llint/LowLevelInterpreter32_64.asm:
In addition to the prior changes, also deleted the unused macro getDeBruijnScope.
- 11:46 AM Changeset in webkit [178855] by
-
- 3 edits in trunk/Source/JavaScriptCore
Eliminate construct methods from NullGetterFunction and NullSetterFunction classes
https://bugs.webkit.org/show_bug.cgi?id=140708
Reviewed by Mark Lam.
Eliminated construct methods and change getConstructData() for both classes to return
ConstructTypeNone as they can never be called.
- runtime/NullGetterFunction.cpp:
(JSC::NullGetterFunction::getConstructData):
(JSC::constructReturnUndefined): Deleted.
- runtime/NullSetterFunction.cpp:
(JSC::NullSetterFunction::getConstructData):
(JSC::constructReturnUndefined): Deleted.
- 11:35 AM Changeset in webkit [178854] by
-
- 470 edits20 moves1 add in trunk/LayoutTests/imported/w3c
Move w3c/canvas/resources/ common resources to w3c/resources/.
https://bugs.webkit.org/show_bug.cgi?id=140712.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-01-21
Reviewed by Alexey Proskuryakov.
Move the w3c common resources from w3c/canvas/resources/ to w3c/resources/. All
the paths to the common resources from the w3c/canvas and w3c/common should be
../resources/<file name> instead of resources/<file name>
- canvas/2d.clearRect.basic.html:
- canvas/2d.clearRect.clip.html:
- canvas/2d.clearRect.globalalpha.html:
- canvas/2d.clearRect.globalcomposite.html:
- canvas/2d.clearRect.negative.html:
- canvas/2d.clearRect.nonfinite.html:
- canvas/2d.clearRect.path.html:
- canvas/2d.clearRect.shadow.html:
- canvas/2d.clearRect.transform.html:
- canvas/2d.clearRect.zero.html:
- canvas/2d.composite.canvas.copy.html:
- canvas/2d.composite.canvas.destination-atop.html:
- canvas/2d.composite.canvas.destination-in.html:
- canvas/2d.composite.canvas.destination-out.html:
- canvas/2d.composite.canvas.destination-over.html:
- canvas/2d.composite.canvas.lighter.html:
- canvas/2d.composite.canvas.source-atop.html:
- canvas/2d.composite.canvas.source-in.html:
- canvas/2d.composite.canvas.source-out.html:
- canvas/2d.composite.canvas.source-over.html:
- canvas/2d.composite.canvas.xor.html:
- canvas/2d.composite.clip.copy.html:
- canvas/2d.composite.clip.destination-atop.html:
- canvas/2d.composite.clip.destination-in.html:
- canvas/2d.composite.clip.destination-out.html:
- canvas/2d.composite.clip.destination-over.html:
- canvas/2d.composite.clip.lighter.html:
- canvas/2d.composite.clip.source-atop.html:
- canvas/2d.composite.clip.source-in.html:
- canvas/2d.composite.clip.source-out.html:
- canvas/2d.composite.clip.source-over.html:
- canvas/2d.composite.clip.xor.html:
- canvas/2d.composite.globalAlpha.canvas.html:
- canvas/2d.composite.globalAlpha.canvaspattern.html:
- canvas/2d.composite.globalAlpha.fill.html:
- canvas/2d.composite.globalAlpha.image.html:
- canvas/2d.composite.globalAlpha.imagepattern.html:
- canvas/2d.composite.image.copy.html:
- canvas/2d.composite.image.destination-atop.html:
- canvas/2d.composite.image.destination-in.html:
- canvas/2d.composite.image.destination-out.html:
- canvas/2d.composite.image.destination-over.html:
- canvas/2d.composite.image.lighter.html:
- canvas/2d.composite.image.source-atop.html:
- canvas/2d.composite.image.source-in.html:
- canvas/2d.composite.image.source-out.html:
- canvas/2d.composite.image.source-over.html:
- canvas/2d.composite.image.xor.html:
- canvas/2d.composite.uncovered.image.copy.html:
- canvas/2d.composite.uncovered.image.destination-atop.html:
- canvas/2d.composite.uncovered.image.destination-in.html:
- canvas/2d.composite.uncovered.image.source-in.html:
- canvas/2d.composite.uncovered.image.source-out.html:
- canvas/2d.composite.uncovered.pattern.copy.html:
- canvas/2d.composite.uncovered.pattern.destination-atop.html:
- canvas/2d.composite.uncovered.pattern.destination-in.html:
- canvas/2d.composite.uncovered.pattern.source-in.html:
- canvas/2d.composite.uncovered.pattern.source-out.html:
- canvas/2d.drawImage.3arg.html:
- canvas/2d.drawImage.5arg.html:
- canvas/2d.drawImage.9arg.basic.html:
- canvas/2d.drawImage.9arg.destpos.html:
- canvas/2d.drawImage.9arg.destsize.html:
- canvas/2d.drawImage.9arg.sourcepos.html:
- canvas/2d.drawImage.9arg.sourcesize.html:
- canvas/2d.drawImage.alpha.html:
- canvas/2d.drawImage.animated.apng.html:
- canvas/2d.drawImage.animated.gif.html:
- canvas/2d.drawImage.animated.poster.html:
- canvas/2d.drawImage.broken.html:
- canvas/2d.drawImage.canvas.html:
- canvas/2d.drawImage.clip.html:
- canvas/2d.drawImage.composite.html:
- canvas/2d.drawImage.floatsource.html:
- canvas/2d.drawImage.image.incomplete.empty.html:
- canvas/2d.drawImage.image.incomplete.omitted.html:
- canvas/2d.drawImage.incomplete.html:
- canvas/2d.drawImage.negativedest.html:
- canvas/2d.drawImage.negativedir.html:
- canvas/2d.drawImage.negativesource.html:
- canvas/2d.drawImage.nonfinite.html:
- canvas/2d.drawImage.nowrap.html:
- canvas/2d.drawImage.path.html:
- canvas/2d.drawImage.self.1.html:
- canvas/2d.drawImage.self.2.html:
- canvas/2d.drawImage.transform.html:
- canvas/2d.drawImage.zerocanvas.html:
- canvas/2d.drawImage.zerosource.html:
- canvas/2d.fillRect.basic.html:
- canvas/2d.fillRect.clip.html:
- canvas/2d.fillRect.negative.html:
- canvas/2d.fillRect.nonfinite.html:
- canvas/2d.fillRect.path.html:
- canvas/2d.fillRect.shadow.html:
- canvas/2d.fillRect.transform.html:
- canvas/2d.fillRect.zero.html:
- canvas/2d.fillStyle.invalidstring.html:
- canvas/2d.fillStyle.invalidtype.html:
- canvas/2d.fillStyle.parse.current.basic.html:
- canvas/2d.fillStyle.parse.current.changed.html:
- canvas/2d.fillStyle.parse.invalid.hex1.html:
- canvas/2d.fillStyle.parse.invalid.hex2.html:
- canvas/2d.fillStyle.parse.invalid.hex3.html:
- canvas/2d.fillStyle.parse.invalid.hex4.html:
- canvas/2d.fillStyle.parse.invalid.hex5.html:
- canvas/2d.fillStyle.parse.invalid.hex6.html:
- canvas/2d.fillStyle.parse.invalid.hex7.html:
- canvas/2d.fillStyle.parse.invalid.hex8.html:
- canvas/2d.fillStyle.parse.invalid.hsl-1.html:
- canvas/2d.fillStyle.parse.invalid.hsl-2.html:
- canvas/2d.fillStyle.parse.invalid.hsl-3.html:
- canvas/2d.fillStyle.parse.invalid.hsl-4.html:
- canvas/2d.fillStyle.parse.invalid.hsl-5.html:
- canvas/2d.fillStyle.parse.invalid.hsl-6.html:
- canvas/2d.fillStyle.parse.invalid.hsla-1.html:
- canvas/2d.fillStyle.parse.invalid.hsla-2.html:
- canvas/2d.fillStyle.parse.invalid.name-1.html:
- canvas/2d.fillStyle.parse.invalid.name-2.html:
- canvas/2d.fillStyle.parse.invalid.name-3.html:
- canvas/2d.fillStyle.parse.invalid.name-4.html:
- canvas/2d.fillStyle.parse.invalid.name-5.html:
- canvas/2d.fillStyle.parse.invalid.rgb-1.html:
- canvas/2d.fillStyle.parse.invalid.rgb-2.html:
- canvas/2d.fillStyle.parse.invalid.rgb-3.html:
- canvas/2d.fillStyle.parse.invalid.rgb-4.html:
- canvas/2d.fillStyle.parse.invalid.rgb-5.html:
- canvas/2d.fillStyle.parse.invalid.rgb-6.html:
- canvas/2d.fillStyle.parse.invalid.rgb-7.html:
- canvas/2d.fillStyle.parse.invalid.rgba-1.html:
- canvas/2d.fillStyle.parse.invalid.rgba-2.html:
- canvas/2d.fillStyle.parse.invalid.rgba-3.html:
- canvas/2d.fillStyle.parse.invalid.rgba-4.html:
- canvas/2d.fillStyle.parse.invalid.rgba-5.html:
- canvas/2d.fillStyle.parse.invalid.rgba-6.html:
- canvas/2d.fillStyle.parse.invalid.rgba-7.html:
- canvas/2d.getcontext.shared.html:
- canvas/2d.gradient.empty.html:
- canvas/2d.gradient.interpolate.outside.html:
- canvas/2d.gradient.interpolate.overlap2.html:
- canvas/2d.gradient.interpolate.solid.html:
- canvas/2d.gradient.interpolate.zerosize.fill.html:
- canvas/2d.gradient.interpolate.zerosize.fillRect.html:
- canvas/2d.gradient.interpolate.zerosize.fillText.html:
- canvas/2d.gradient.interpolate.zerosize.html:
- canvas/2d.gradient.interpolate.zerosize.stroke.html:
- canvas/2d.gradient.interpolate.zerosize.strokeRect.html:
- canvas/2d.gradient.interpolate.zerosize.strokeText.html:
- canvas/2d.gradient.linear.transform.1.html:
- canvas/2d.gradient.linear.transform.2.html:
- canvas/2d.gradient.linear.transform.3.html:
- canvas/2d.gradient.object.crosscanvas.html:
- canvas/2d.gradient.object.update.html:
- canvas/2d.gradient.radial.cone.behind.html:
- canvas/2d.gradient.radial.cone.beside.html:
- canvas/2d.gradient.radial.cone.bottom.html:
- canvas/2d.gradient.radial.cone.cylinder.html:
- canvas/2d.gradient.radial.cone.front.html:
- canvas/2d.gradient.radial.cone.shape1.html:
- canvas/2d.gradient.radial.cone.shape2.html:
- canvas/2d.gradient.radial.cone.top.html:
- canvas/2d.gradient.radial.equal.html:
- canvas/2d.gradient.radial.inside1.html:
- canvas/2d.gradient.radial.inside2.html:
- canvas/2d.gradient.radial.inside3.html:
- canvas/2d.gradient.radial.outside1.html:
- canvas/2d.gradient.radial.outside2.html:
- canvas/2d.gradient.radial.outside3.html:
- canvas/2d.gradient.radial.touch1.html:
- canvas/2d.gradient.radial.touch2.html:
- canvas/2d.gradient.radial.touch3.html:
- canvas/2d.gradient.radial.transform.1.html:
- canvas/2d.gradient.radial.transform.2.html:
- canvas/2d.gradient.radial.transform.3.html:
- canvas/2d.imageData.get.unaffected.html:
- canvas/2d.imageData.put.basic.html:
- canvas/2d.imageData.put.clip.html:
- canvas/2d.imageData.put.created.html:
- canvas/2d.imageData.put.cross.html:
- canvas/2d.imageData.put.dirty.negative.html:
- canvas/2d.imageData.put.dirty.outside.html:
- canvas/2d.imageData.put.dirty.rect1.html:
- canvas/2d.imageData.put.dirty.rect2.html:
- canvas/2d.imageData.put.dirty.zero.html:
- canvas/2d.imageData.put.modified.html:
- canvas/2d.imageData.put.path.html:
- canvas/2d.imageData.put.unaffected.html:
- canvas/2d.imageData.put.wrongtype.html:
- canvas/2d.line.cap.butt.html:
- canvas/2d.line.cap.closed.html:
- canvas/2d.line.cap.open.html:
- canvas/2d.line.cap.round.html:
- canvas/2d.line.cap.square.html:
- canvas/2d.line.cross.html:
- canvas/2d.line.join.bevel.html:
- canvas/2d.line.join.closed.html:
- canvas/2d.line.join.miter.html:
- canvas/2d.line.join.open.html:
- canvas/2d.line.join.parallel.html:
- canvas/2d.line.join.round.html:
- canvas/2d.line.miter.acute.html:
- canvas/2d.line.miter.exceeded.html:
- canvas/2d.line.miter.lineedge.html:
- canvas/2d.line.miter.obtuse.html:
- canvas/2d.line.miter.rightangle.html:
- canvas/2d.line.miter.within.html:
- canvas/2d.line.union.html:
- canvas/2d.line.width.basic.html:
- canvas/2d.line.width.scaledefault.html:
- canvas/2d.line.width.transformed.html:
- canvas/2d.path.arc.angle.1.html:
- canvas/2d.path.arc.angle.2.html:
- canvas/2d.path.arc.angle.3.html:
- canvas/2d.path.arc.angle.4.html:
- canvas/2d.path.arc.angle.5.html:
- canvas/2d.path.arc.angle.6.html:
- canvas/2d.path.arc.default.html:
- canvas/2d.path.arc.empty.html:
- canvas/2d.path.arc.end.html:
- canvas/2d.path.arc.nonempty.html:
- canvas/2d.path.arc.nonfinite.html:
- canvas/2d.path.arc.scale.1.html:
- canvas/2d.path.arc.scale.2.html:
- canvas/2d.path.arc.selfintersect.1.html:
- canvas/2d.path.arc.selfintersect.2.html:
- canvas/2d.path.arc.shape.1.html:
- canvas/2d.path.arc.shape.2.html:
- canvas/2d.path.arc.shape.3.html:
- canvas/2d.path.arc.shape.4.html:
- canvas/2d.path.arc.shape.5.html:
- canvas/2d.path.arc.twopie.1.html:
- canvas/2d.path.arc.twopie.2.html:
- canvas/2d.path.arc.twopie.3.html:
- canvas/2d.path.arc.twopie.4.html:
- canvas/2d.path.arc.zero.1.html:
- canvas/2d.path.arc.zero.2.html:
- canvas/2d.path.arc.zeroradius.html:
- canvas/2d.path.arcTo.coincide.1.html:
- canvas/2d.path.arcTo.coincide.2.html:
- canvas/2d.path.arcTo.collinear.1.html:
- canvas/2d.path.arcTo.collinear.2.html:
- canvas/2d.path.arcTo.collinear.3.html:
- canvas/2d.path.arcTo.ensuresubpath.1.html:
- canvas/2d.path.arcTo.ensuresubpath.2.html:
- canvas/2d.path.arcTo.nonfinite.html:
- canvas/2d.path.arcTo.scale.html:
- canvas/2d.path.arcTo.shape.curve1.html:
- canvas/2d.path.arcTo.shape.curve2.html:
- canvas/2d.path.arcTo.shape.end.html:
- canvas/2d.path.arcTo.shape.start.html:
- canvas/2d.path.arcTo.transformation.html:
- canvas/2d.path.arcTo.zero.1.html:
- canvas/2d.path.arcTo.zero.2.html:
- canvas/2d.path.beginPath.html:
- canvas/2d.path.bezierCurveTo.basic.html:
- canvas/2d.path.bezierCurveTo.ensuresubpath.1.html:
- canvas/2d.path.bezierCurveTo.ensuresubpath.2.html:
- canvas/2d.path.bezierCurveTo.nonfinite.html:
- canvas/2d.path.bezierCurveTo.scaled.html:
- canvas/2d.path.bezierCurveTo.shape.html:
- canvas/2d.path.clip.basic.1.html:
- canvas/2d.path.clip.basic.2.html:
- canvas/2d.path.clip.empty.html:
- canvas/2d.path.clip.intersect.html:
- canvas/2d.path.clip.unaffected.html:
- canvas/2d.path.clip.winding.1.html:
- canvas/2d.path.clip.winding.2.html:
- canvas/2d.path.closePath.empty.html:
- canvas/2d.path.closePath.newline.html:
- canvas/2d.path.closePath.nextpoint.html:
- canvas/2d.path.fill.closed.basic.html:
- canvas/2d.path.fill.closed.unaffected.html:
- canvas/2d.path.fill.winding.add.html:
- canvas/2d.path.fill.winding.subtract.1.html:
- canvas/2d.path.fill.winding.subtract.2.html:
- canvas/2d.path.fill.winding.subtract.3.html:
- canvas/2d.path.initial.html:
- canvas/2d.path.lineTo.basic.html:
- canvas/2d.path.lineTo.ensuresubpath.1.html:
- canvas/2d.path.lineTo.ensuresubpath.2.html:
- canvas/2d.path.lineTo.nextpoint.html:
- canvas/2d.path.lineTo.nonfinite.html:
- canvas/2d.path.moveTo.basic.html:
- canvas/2d.path.moveTo.multiple.html:
- canvas/2d.path.moveTo.newsubpath.html:
- canvas/2d.path.moveTo.nonfinite.html:
- canvas/2d.path.quadraticCurveTo.basic.html:
- canvas/2d.path.quadraticCurveTo.ensuresubpath.1.html:
- canvas/2d.path.quadraticCurveTo.ensuresubpath.2.html:
- canvas/2d.path.quadraticCurveTo.nonfinite.html:
- canvas/2d.path.quadraticCurveTo.scaled.html:
- canvas/2d.path.quadraticCurveTo.shape.html:
- canvas/2d.path.rect.basic.html:
- canvas/2d.path.rect.closed.html:
- canvas/2d.path.rect.end.1.html:
- canvas/2d.path.rect.end.2.html:
- canvas/2d.path.rect.newsubpath.html:
- canvas/2d.path.rect.nonfinite.html:
- canvas/2d.path.rect.selfintersect.html:
- canvas/2d.path.rect.zero.1.html:
- canvas/2d.path.rect.zero.2.html:
- canvas/2d.path.rect.zero.3.html:
- canvas/2d.path.rect.zero.4.html:
- canvas/2d.path.rect.zero.5.html:
- canvas/2d.path.rect.zero.6.html:
- canvas/2d.path.stroke.empty.html:
- canvas/2d.path.stroke.prune.arc.html:
- canvas/2d.path.stroke.prune.closed.html:
- canvas/2d.path.stroke.prune.corner.html:
- canvas/2d.path.stroke.prune.curve.html:
- canvas/2d.path.stroke.prune.line.html:
- canvas/2d.path.stroke.prune.rect.html:
- canvas/2d.path.stroke.scale1.html:
- canvas/2d.path.stroke.scale2.html:
- canvas/2d.path.stroke.skew.html:
- canvas/2d.path.stroke.unaffected.html:
- canvas/2d.path.stroke.union.html:
- canvas/2d.path.transformation.basic.html:
- canvas/2d.path.transformation.changing.html:
- canvas/2d.path.transformation.multiple.html:
- canvas/2d.pattern.animated.gif.html:
- canvas/2d.pattern.basic.canvas.html:
- canvas/2d.pattern.basic.image.html:
- canvas/2d.pattern.basic.nocontext.html:
- canvas/2d.pattern.basic.type.html:
- canvas/2d.pattern.crosscanvas.html:
- canvas/2d.pattern.image.incomplete.empty.html:
- canvas/2d.pattern.image.incomplete.omitted.html:
- canvas/2d.pattern.modify.canvas1.html:
- canvas/2d.pattern.modify.canvas2.html:
- canvas/2d.pattern.modify.image1.html:
- canvas/2d.pattern.modify.image2.html:
- canvas/2d.pattern.paint.norepeat.basic.html:
- canvas/2d.pattern.paint.norepeat.coord1.html:
- canvas/2d.pattern.paint.norepeat.coord2.html:
- canvas/2d.pattern.paint.norepeat.coord3.html:
- canvas/2d.pattern.paint.norepeat.outside.html:
- canvas/2d.pattern.paint.orientation.canvas.html:
- canvas/2d.pattern.paint.orientation.image.html:
- canvas/2d.pattern.paint.repeat.basic.html:
- canvas/2d.pattern.paint.repeat.coord1.html:
- canvas/2d.pattern.paint.repeat.coord2.html:
- canvas/2d.pattern.paint.repeat.coord3.html:
- canvas/2d.pattern.paint.repeat.outside.html:
- canvas/2d.pattern.paint.repeatx.basic.html:
- canvas/2d.pattern.paint.repeatx.coord1.html:
- canvas/2d.pattern.paint.repeatx.outside.html:
- canvas/2d.pattern.paint.repeaty.basic.html:
- canvas/2d.pattern.paint.repeaty.coord1.html:
- canvas/2d.pattern.paint.repeaty.outside.html:
- canvas/2d.pattern.repeat.empty.html:
- canvas/2d.pattern.repeat.null.html:
- canvas/2d.shadow.alpha.1.html:
- canvas/2d.shadow.canvas.alpha.html:
- canvas/2d.shadow.canvas.basic.html:
- canvas/2d.shadow.canvas.transparent.1.html:
- canvas/2d.shadow.canvas.transparent.2.html:
- canvas/2d.shadow.clip.1.html:
- canvas/2d.shadow.clip.2.html:
- canvas/2d.shadow.clip.3.html:
- canvas/2d.shadow.composite.1.html:
- canvas/2d.shadow.composite.2.html:
- canvas/2d.shadow.composite.3.html:
- canvas/2d.shadow.enable.blur.html:
- canvas/2d.shadow.enable.off.1.html:
- canvas/2d.shadow.enable.off.2.html:
- canvas/2d.shadow.enable.x.html:
- canvas/2d.shadow.enable.y.html:
- canvas/2d.shadow.gradient.basic.html:
- canvas/2d.shadow.gradient.transparent.1.html:
- canvas/2d.shadow.gradient.transparent.2.html:
- canvas/2d.shadow.image.alpha.html:
- canvas/2d.shadow.image.basic.html:
- canvas/2d.shadow.image.scale.html:
- canvas/2d.shadow.image.section.html:
- canvas/2d.shadow.image.transparent.1.html:
- canvas/2d.shadow.image.transparent.2.html:
- canvas/2d.shadow.offset.negativeX.html:
- canvas/2d.shadow.offset.negativeY.html:
- canvas/2d.shadow.offset.positiveX.html:
- canvas/2d.shadow.offset.positiveY.html:
- canvas/2d.shadow.outside.html:
- canvas/2d.shadow.pattern.alpha.html:
- canvas/2d.shadow.pattern.basic.html:
- canvas/2d.shadow.pattern.transparent.1.html:
- canvas/2d.shadow.pattern.transparent.2.html:
- canvas/2d.shadow.stroke.basic.html:
- canvas/2d.shadow.stroke.cap.1.html:
- canvas/2d.shadow.stroke.cap.2.html:
- canvas/2d.shadow.stroke.join.1.html:
- canvas/2d.shadow.stroke.join.2.html:
- canvas/2d.shadow.stroke.join.3.html:
- canvas/2d.shadow.transform.1.html:
- canvas/2d.shadow.transform.2.html:
- canvas/2d.state.saverestore.bitmap.html:
- canvas/2d.state.saverestore.clip.html:
- canvas/2d.state.saverestore.path.html:
- canvas/2d.state.saverestore.transformation.html:
- canvas/2d.strokeRect.basic.html:
- canvas/2d.strokeRect.clip.html:
- canvas/2d.strokeRect.globalalpha.html:
- canvas/2d.strokeRect.globalcomposite.html:
- canvas/2d.strokeRect.negative.html:
- canvas/2d.strokeRect.nonfinite.html:
- canvas/2d.strokeRect.path.html:
- canvas/2d.strokeRect.shadow.html:
- canvas/2d.strokeRect.transform.html:
- canvas/2d.strokeRect.zero.1.html:
- canvas/2d.strokeRect.zero.2.html:
- canvas/2d.strokeRect.zero.3.html:
- canvas/2d.strokeRect.zero.5.html:
- canvas/2d.text.draw.align.center.html:
- canvas/2d.text.draw.align.end.ltr.html:
- canvas/2d.text.draw.align.end.rtl.html:
- canvas/2d.text.draw.align.left.html:
- canvas/2d.text.draw.align.right.html:
- canvas/2d.text.draw.align.start.ltr.html:
- canvas/2d.text.draw.align.start.rtl.html:
- canvas/2d.text.draw.baseline.alphabetic.html:
- canvas/2d.text.draw.fill.maxWidth.bound.html:
- canvas/2d.text.draw.fill.maxWidth.fontface.html:
- canvas/2d.text.draw.fill.maxWidth.negative.html:
- canvas/2d.text.draw.fill.maxWidth.small.html:
- canvas/2d.text.draw.fill.maxWidth.zero.html:
- canvas/2d.text.draw.fill.unaffected.html:
- canvas/2d.text.draw.fontface.html:
- canvas/2d.text.draw.fontface.notinpage.html:
- canvas/2d.text.draw.fontface.repeat.html:
- canvas/2d.text.draw.kern.consistent.html:
- canvas/2d.text.draw.space.basic.html:
- canvas/2d.text.draw.space.collapse.nonspace.html:
- canvas/2d.text.draw.stroke.unaffected.html:
- canvas/2d.transformation.order.html:
- canvas/2d.transformation.rotate.direction.html:
- canvas/2d.transformation.rotate.nonfinite.html:
- canvas/2d.transformation.rotate.radians.html:
- canvas/2d.transformation.rotate.wrap.html:
- canvas/2d.transformation.rotate.wrapnegative.html:
- canvas/2d.transformation.rotate.zero.html:
- canvas/2d.transformation.scale.basic.html:
- canvas/2d.transformation.scale.large.html:
- canvas/2d.transformation.scale.multiple.html:
- canvas/2d.transformation.scale.negative.html:
- canvas/2d.transformation.scale.nonfinite.html:
- canvas/2d.transformation.scale.zero.html:
- canvas/2d.transformation.setTransform.multiple.html:
- canvas/2d.transformation.setTransform.nonfinite.html:
- canvas/2d.transformation.setTransform.skewed.html:
- canvas/2d.transformation.transform.identity.html:
- canvas/2d.transformation.transform.multiply.html:
- canvas/2d.transformation.transform.nonfinite.html:
- canvas/2d.transformation.transform.skewed.html:
- canvas/2d.transformation.translate.basic.html:
- canvas/2d.transformation.translate.nonfinite.html:
- canvas/2d.voidreturn.html:
- canvas/initial.reset.clip.html:
- canvas/initial.reset.gradient.html:
- canvas/initial.reset.pattern.html:
- canvas/initial.reset.transform.html:
- canvas/resources/anim-gr.gif: Removed.
- canvas/resources/anim-gr.png: Removed.
- canvas/resources/anim-poster-gr.png: Removed.
- canvas/resources/background.png: Removed.
- canvas/resources/broken.png: Removed.
- canvas/resources/clear-100x50.png: Removed.
- canvas/resources/ggrr-256x256.png: Removed.
- canvas/resources/green-100x50.png: Removed.
- canvas/resources/green-16x16.png: Removed.
- canvas/resources/green-1x1.png: Removed.
- canvas/resources/green.png: Removed.
- canvas/resources/red-16x16.png: Removed.
- canvas/resources/red.png: Removed.
- canvas/resources/redtransparent.png: Removed.
- canvas/resources/rgrg-256x256.png: Removed.
- canvas/resources/rrgg-256x256.png: Removed.
- canvas/resources/transparent.png: Removed.
- canvas/resources/transparent50.png: Removed.
- canvas/resources/yellow.png: Removed.
- canvas/resources/yellow75.png: Removed.
- canvas/security.dataURI.html:
- canvas/security.drawImage.canvas.html:
- canvas/security.drawImage.image.html:
- canvas/security.pattern.canvas.fillStyle.html:
- canvas/security.pattern.canvas.strokeStyle.html:
- canvas/security.pattern.canvas.timing.html:
- canvas/security.pattern.create.html:
- canvas/security.pattern.cross.html:
- canvas/security.pattern.image.fillStyle.html:
- canvas/security.pattern.image.strokeStyle.html:
- canvas/security.reset.html:
- resources: Added.
- resources/anim-gr.gif: Added.
- resources/anim-gr.png: Added.
- resources/anim-poster-gr.png: Added.
- resources/background.png: Added.
- resources/broken.png: Added.
- resources/clear-100x50.png: Added.
- resources/ggrr-256x256.png: Added.
- resources/green-100x50.png: Added.
- resources/green-16x16.png: Added.
- resources/green-1x1.png: Added.
- resources/green.png: Added.
- resources/red-16x16.png: Added.
- resources/red.png: Added.
- resources/redtransparent.png: Added.
- resources/rgrg-256x256.png: Added.
- resources/rrgg-256x256.png: Added.
- resources/transparent.png: Added.
- resources/transparent50.png: Added.
- resources/yellow.png: Added.
- resources/yellow75.png: Added.
- 11:33 AM Changeset in webkit [178853] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(r178180): Membuster regressed ~4%
https://bugs.webkit.org/show_bug.cgi?id=140495
Reviewed by Andreas Kling.
After r178180 we keep system fallback fonts that are used on glyph pages alive.
Previously we would traverse the glyph pages and remove entries referencing system fallbacks.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::purgeInactiveFontData):
- platform/graphics/FontCascade.cpp:
(WebCore::pruneUnreferencedEntriesFromFontGlyphsCache):
(WebCore::pruneSystemFallbackFonts):
- platform/graphics/FontCascade.h:
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::pruneSystemFallbacks):
When clearing the font cache also remove the cached glyph pages that may contain system fallback fonts
and release the fallbacks.
- platform/graphics/FontGlyphs.h:
- 11:31 AM Changeset in webkit [178852] by
-
- 2 edits in trunk/Tools
https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
https://bugs.webkit.org/show_bug.cgi?id=140731
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
(Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
- 11:27 AM Changeset in webkit [178851] by
-
- 5 edits in trunk/LayoutTests
[Win] Unreviewed gardening based on TestBot runs.
Update a few failure cass with bug reports. Rebaseline a handful of tests.
- platform/win/TestExpectations: Update based on bug reports.
- platform/win/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
- platform/win/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
- 11:13 AM Changeset in webkit [178850] by
-
- 4 edits in trunk/Source/WebKit2
AsyncRequestImpl casting in AsyncRequest::completeRequest() is incorrect
https://bugs.webkit.org/show_bug.cgi?id=139724
Reviewed by Darin Adler.
AsyncRequestImpl casting in AsyncRequest::completeRequest() relies on
the parameter pack to properly determine the type of the AsyncRequestImpl
object. The casting result can be incorrect when an argument is passed
by reference while the original object was constructed with a callback
that expects an argument that's passed by value.
To avoid this the AsyncRequestImpl template is now instantiated with
raw types, with callback parameters remaining raw types in case
of being integral (enforcing passing-by-value these arguments when
dispatching), and const references being used otherwise (enforcing
passing-by-reference).
This enables casting AsyncRequest objects to the correct AsyncRequestImpl<>
by running the parameter pack through std::decay.
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
- Shared/AsyncRequest.h:
(WebKit::AsyncRequest::completeRequest):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::get):
- 10:59 AM Changeset in webkit [178849] by
-
- 8 edits in trunk
[Win] eventSender does not support scalePageBy
https://bugs.webkit.org/show_bug.cgi?id=140726
<rdar://problem/19549865>
Reviewed by Dean Jackson.
Source/WebKit/win:
- Interfaces/IWebViewPrivate.idl: Add scaleWebView API.
- WebView.cpp:
(WebView::scaleWebView):
Connect WebCore implementation to the Windows COM interface.
- WebView.h:
Tools:
- DumpRenderTree/win/EventSender.cpp:
(scalePageByCallback): Provide implementation using new WebView method.
LayoutTests:
- platform/win/TestExpectations: Unskip test.
- 10:55 AM Changeset in webkit [178848] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API
https://bugs.webkit.org/show_bug.cgi?id=140655
Reviewed by Anders Carlsson.
Stop using WKDiagnosticLoggingResultType.h C API header in Cocoa API.
Instead, introduce a new _WKDiagnosticLoggingResultType enum in
_WKDiagnosticLoggingDelegate.h.
A few defines mapping WKDiagnosticLoggingResultType enum and its values
to the new _WKDiagnosticLoggingResultType are temporarily added until
the client-side is transitioned.
- UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
- UIProcess/Cocoa/DiagnosticLoggingClient.mm:
(WebKit::toWKDiagnosticLoggingResultType):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithResult):
- 10:52 AM Changeset in webkit [178847] by
-
- 2 edits in trunk/Tools
Remove Apple Mountain Lion Build & Test slaves.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:47 AM Changeset in webkit [178846] by
-
- 1 edit1 copy1 delete in branches/safari-600.1.4.15-branch
Merged r177088. rdar://problem/19339033
- 10:46 AM Changeset in webkit [178845] by
-
- 6 edits1 copy in branches/safari-600.1.4.15-branch
Merged r177000. rdar://problem/19339033
- 10:44 AM Changeset in webkit [178844] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176977. rdar://problem/19420073
- 10:43 AM Changeset in webkit [178843] by
-
- 3 edits3 copies in branches/safari-600.1.4.15-branch
Merged r176972. rdar://problem/19450085
- 10:42 AM Changeset in webkit [178842] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WTF
Merged r176982. rdar://problem/19419996
- 10:41 AM Changeset in webkit [178841] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176971. rdar://problem/19419996
- 10:40 AM Changeset in webkit [178840] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176969. rdar://problem/19302738
- 10:39 AM Changeset in webkit [178839] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176948. rdar://problem/19419766
- 10:38 AM Changeset in webkit [178838] by
-
- 9 edits in branches/safari-600.1.4.15-branch
Merged r176904. rdar://problem/19419865
- 10:32 AM Changeset in webkit [178837] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176768. rdar://problem/19450126
- 10:31 AM Changeset in webkit [178836] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176734. rdar://problem/19420067
- 10:30 AM Changeset in webkit [178835] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176701. rdar://problem/19419925
- 10:30 AM Changeset in webkit [178834] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176484. rdar://problem/19419988
- 10:29 AM Changeset in webkit [178833] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176471. rdar://problem/19419820
- 10:28 AM Changeset in webkit [178832] by
-
- 4 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176447. rdar://problem/19419828
- 10:25 AM Changeset in webkit [178831] by
-
- 4 edits3 copies in branches/safari-600.1.4.15-branch
Merged r176372. rdar://problem/19419916
- 10:24 AM Changeset in webkit [178830] by
-
- 5 edits9 copies in branches/safari-600.1.4.15-branch
Merged r176354. rdar://problem/19432696
- 10:20 AM Changeset in webkit [178829] by
-
- 7 edits in branches/safari-600.1.4.15-branch
Merged r176318. rdar://problem/19339000
- 10:06 AM Changeset in webkit [178828] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176305. rdar://problem/19395081
- 10:05 AM Changeset in webkit [178827] by
-
- 3 edits2 copies in branches/safari-600.1.4.15-branch
Merged r176285. rdar://problem/19420011
- 9:02 AM Changeset in webkit [178826] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening after reactivating some tests.
- platform/win/TestExpectations: Add failure entries for a few tests with bug reports.
- 9:00 AM Changeset in webkit [178825] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Use C++ lambdas in ProcessLauncher class
https://bugs.webkit.org/show_bug.cgi?id=138186
Reviewed by Darin Adler.
Replace uses of WTF::bind() in the ProcessLauncher class with C++ lambdas.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):
- 8:55 AM Changeset in webkit [178824] by
-
- 2 edits in trunk/Source/WebKit2
Clean up ViewUpdateDispatcher
https://bugs.webkit.org/show_bug.cgi?id=140619
Reviewed by Darin Adler.
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
Replace WTF::bind() with a C++ lambda.
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):
Use WTF::move() to move the HashMap member into the local variable.
- 2:20 AM Changeset in webkit [178823] by
-
- 2 edits in trunk
[EFL][WK2] EFL MiniBrowser doesn't run because shared library is not found
https://bugs.webkit.org/show_bug.cgi?id=140049
Reviewed by Gyuyoung Kim.
- Source/cmake/OptionsCommon.cmake:
- 2:02 AM Changeset in webkit [178822] by
-
- 7 edits4 adds in trunk
first-letter pseudo-element from ancestors is not being ignored in grids and flexboxes
https://bugs.webkit.org/show_bug.cgi?id=138424
Reviewed by Benjamin Poulain.
Source/WebCore:
Source/WebCore:
According to the grid and flexbox specs:
"::first-letter pseudo-element do not apply to grid/flex containers".
http://dev.w3.org/csswg/css-grid/#grid-containers
http://dev.w3.org/csswg/css-flexbox/#flex-containers
Check also the CSS WG mailing list discussion:
http://lists.w3.org/Archives/Public/www-style/2014Dec/0305.html
This was almost working right, except in the case that an ancestor was
setting the ::first-letter pseudo-element.
Added a few more cases to the current tests in order to check this
behavior.
Also created some new tests to increase coverage
Tests: fast/css/first-letter-from-ancestors-not-apply-inline-elements.html
fast/css/first-letter-ignores-display-property.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getFirstLetter): Go to the next sibling when
looking for the first text child if you reach a grid or flexbox.
LayoutTests:
Modified current tests to check that first-letter from ancestors is
ignored too.
Added 2 new tests to increase coverage.
- css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt:
- css3/flexbox/flexbox-ignore-container-firstLetter.html:
- fast/css-grid-layout/grid-container-ignore-first-letter-expected.txt:
- fast/css-grid-layout/grid-container-ignore-first-letter.html:
- fast/css/first-letter-from-ancestors-not-apply-inline-elements-expected.html: Added.
- fast/css/first-letter-from-ancestors-not-apply-inline-elements.html: Added.
- fast/css/first-letter-ignores-display-property-expected.html: Added.
- fast/css/first-letter-ignores-display-property.html: Added.
- 1:52 AM WebKitGTK/Roadmap edited by
- (diff)
- 1:51 AM WebKitGTK/Roadmap edited by
- (diff)
- 12:46 AM Changeset in webkit [178821] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align warning in Source/WebCore/platform/efl/EflScreenUtilities.cpp
https://bugs.webkit.org/show_bug.cgi?id=140670
Reviewed by Darin Adler.
- platform/efl/EflScreenUtilities.cpp:
(WebCore::createCustomCursor):
- 12:45 AM Changeset in webkit [178820] by
-
- 262 edits in trunk
Remove ENABLE(INSPECTOR) ifdef guards
https://bugs.webkit.org/show_bug.cgi?id=140668
Reviewed by Darin Adler.
.:
- Source/PlatformEfl.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- bindings/ScriptValue.cpp:
(Deprecated::ScriptValue::toInspectorValue):
- bindings/ScriptValue.h:
- inspector/ConsoleMessage.cpp:
- inspector/ConsoleMessage.h:
- inspector/ContentSearchUtilities.cpp:
- inspector/ContentSearchUtilities.h:
- inspector/IdentifiersFactory.cpp:
- inspector/IdentifiersFactory.h:
- inspector/InjectedScript.cpp:
- inspector/InjectedScript.h:
- inspector/InjectedScriptBase.cpp:
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
- inspector/InjectedScriptManager.h:
- inspector/InjectedScriptModule.cpp:
- inspector/InjectedScriptModule.h:
- inspector/InspectorAgentRegistry.cpp:
- inspector/InspectorBackendDispatcher.cpp:
- inspector/InspectorBackendDispatcher.h:
- inspector/InspectorProtocolTypes.h:
- inspector/JSGlobalObjectConsoleClient.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectScriptDebugServer.cpp:
- inspector/JSGlobalObjectScriptDebugServer.h:
- inspector/JSInjectedScriptHost.cpp:
- inspector/JSInjectedScriptHost.h:
- inspector/JSInjectedScriptHostPrototype.cpp:
- inspector/JSInjectedScriptHostPrototype.h:
- inspector/JSJavaScriptCallFrame.cpp:
- inspector/JSJavaScriptCallFrame.h:
- inspector/JSJavaScriptCallFramePrototype.cpp:
- inspector/JSJavaScriptCallFramePrototype.h:
- inspector/JavaScriptCallFrame.cpp:
- inspector/JavaScriptCallFrame.h:
- inspector/ScriptCallFrame.cpp:
(Inspector::ScriptCallFrame::buildInspectorObject):
- inspector/ScriptCallFrame.h:
- inspector/ScriptCallStack.cpp:
(Inspector::ScriptCallStack::buildInspectorArray):
- inspector/ScriptCallStack.h:
- inspector/ScriptDebugServer.cpp:
- inspector/agents/InspectorAgent.cpp:
- inspector/agents/InspectorAgent.h:
- inspector/agents/InspectorConsoleAgent.cpp:
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/InspectorRuntimeAgent.cpp:
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/agents/JSGlobalObjectConsoleAgent.cpp:
- inspector/agents/JSGlobalObjectConsoleAgent.h:
- inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
- inspector/agents/JSGlobalObjectDebuggerAgent.h:
- inspector/agents/JSGlobalObjectRuntimeAgent.cpp:
- inspector/agents/JSGlobalObjectRuntimeAgent.h:
- inspector/scripts/codegen/cpp_generator_templates.py:
(CppGeneratorTemplates):
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/enum-values.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
- runtime/TypeSet.cpp:
(JSC::TypeSet::inspectorTypeSet):
(JSC::StructureShape::inspectorRepresentation):
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- bindings/js/JSCommandLineAPIHostCustom.cpp:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):
- bindings/js/JSInspectorFrontendHostCustom.cpp:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
- bindings/js/ScriptController.h:
- bindings/js/ScriptGlobalObject.cpp:
(WebCore::ScriptGlobalObject::set):
- bindings/js/ScriptGlobalObject.h:
- bindings/js/WorkerScriptDebugServer.cpp:
- bindings/js/WorkerScriptDebugServer.h:
- dom/Node.cpp:
(WebCore::Node::inspect):
- inspector/CommandLineAPIHost.cpp:
- inspector/CommandLineAPIHost.idl:
- inspector/CommandLineAPIModule.cpp:
- inspector/CommandLineAPIModule.h:
- inspector/DOMEditor.cpp:
- inspector/DOMEditor.h:
- inspector/DOMPatchSupport.cpp:
- inspector/DOMPatchSupport.h:
- inspector/InspectorApplicationCacheAgent.cpp:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorClient.cpp:
- inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
(WebCore::InspectorInstrumentation::startProfiling):
(WebCore::InspectorInstrumentation::stopProfiling):
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
- inspector/InspectorDatabaseAgent.cpp:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorDatabaseInstrumentation.h:
(WebCore::InspectorInstrumentation::didOpenDatabase):
- inspector/InspectorDatabaseResource.cpp:
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.idl:
- inspector/InspectorHistory.cpp:
- inspector/InspectorHistory.h:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
(WebCore::InspectorInstrumentation::isDebuggerPaused):
(WebCore::InspectorInstrumentation::willInsertDOMNode):
(WebCore::InspectorInstrumentation::didInsertDOMNode):
(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
(WebCore::InspectorInstrumentation::didModifyDOMAttr):
(WebCore::InspectorInstrumentation::didRemoveDOMAttr):
(WebCore::InspectorInstrumentation::didInvalidateStyleAttr):
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::mediaQueryResultChanged):
(WebCore::InspectorInstrumentation::didPushShadowRoot):
(WebCore::InspectorInstrumentation::willPopShadowRoot):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore::InspectorInstrumentation::didChangeRegionOverset):
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement):
(WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
(WebCore::InspectorInstrumentation::handleTouchEvent):
(WebCore::InspectorInstrumentation::handleMousePress):
(WebCore::InspectorInstrumentation::forcePseudoState):
(WebCore::InspectorInstrumentation::characterDataModified):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
(WebCore::InspectorInstrumentation::didInstallTimer):
(WebCore::InspectorInstrumentation::didRemoveTimer):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didCallFunction):
(WebCore::InspectorInstrumentation::willDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRReadyStateChangeEvent):
(WebCore::InspectorInstrumentation::willDispatchEvent):
(WebCore::InspectorInstrumentation::didDispatchEvent):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore::InspectorInstrumentation::didHandleEvent):
(WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::didDispatchEventOnWindow):
(WebCore::InspectorInstrumentation::willEvaluateScript):
(WebCore::InspectorInstrumentation::didEvaluateScript):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore::InspectorInstrumentation::willFireTimer):
(WebCore::InspectorInstrumentation::didFireTimer):
(WebCore::InspectorInstrumentation::didInvalidateLayout):
(WebCore::InspectorInstrumentation::willLayout):
(WebCore::InspectorInstrumentation::didLayout):
(WebCore::InspectorInstrumentation::didScroll):
(WebCore::InspectorInstrumentation::willDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::didDispatchXHRLoadEvent):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
(WebCore::InspectorInstrumentation::willScrollLayer):
(WebCore::InspectorInstrumentation::didScrollLayer):
(WebCore::InspectorInstrumentation::willRecalculateStyle):
(WebCore::InspectorInstrumentation::didRecalculateStyle):
(WebCore::InspectorInstrumentation::didScheduleStyleRecalculation):
(WebCore::InspectorInstrumentation::applyEmulatedMedia):
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::continueAfterPingLoader):
(WebCore::InspectorInstrumentation::markResourceAsCached):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::continueAfterXFrameOptionsDenied):
(WebCore::InspectorInstrumentation::continueWithPolicyDownload):
(WebCore::InspectorInstrumentation::continueWithPolicyIgnore):
(WebCore::InspectorInstrumentation::didReceiveData):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
(WebCore::InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient):
(WebCore::InspectorInstrumentation::willLoadXHR):
(WebCore::InspectorInstrumentation::didFailXHRLoading):
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
(WebCore::InspectorInstrumentation::didReceiveXHRResponse):
(WebCore::InspectorInstrumentation::willLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::didLoadXHRSynchronously):
(WebCore::InspectorInstrumentation::scriptImported):
(WebCore::InspectorInstrumentation::scriptExecutionBlockedByCSP):
(WebCore::InspectorInstrumentation::didReceiveScriptResponse):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetachedFromParent):
(WebCore::InspectorInstrumentation::didCommitLoad):
(WebCore::InspectorInstrumentation::frameDocumentUpdated):
(WebCore::InspectorInstrumentation::loaderDetachedFromFrame):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):
(WebCore::InspectorInstrumentation::didDispatchDOMStorageEvent):
(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):
(WebCore::InspectorInstrumentation::didStartWorkerGlobalScope):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminated):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrame):
(WebCore::InspectorInstrumentation::didReceiveWebSocketFrameError):
(WebCore::InspectorInstrumentation::didSendWebSocketFrame):
(WebCore::InspectorInstrumentation::sessionCreated):
(WebCore::InspectorInstrumentation::sessionLoaded):
(WebCore::InspectorInstrumentation::sessionModified):
(WebCore::InspectorInstrumentation::segmentCreated):
(WebCore::InspectorInstrumentation::segmentCompleted):
(WebCore::InspectorInstrumentation::segmentLoaded):
(WebCore::InspectorInstrumentation::segmentUnloaded):
(WebCore::InspectorInstrumentation::captureStarted):
(WebCore::InspectorInstrumentation::captureStopped):
(WebCore::InspectorInstrumentation::playbackStarted):
(WebCore::InspectorInstrumentation::playbackPaused):
(WebCore::InspectorInstrumentation::playbackFinished):
(WebCore::InspectorInstrumentation::playbackHitPosition):
(WebCore::InspectorInstrumentation::networkStateChanged):
(WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
(WebCore::InspectorInstrumentation::didFireAnimationFrame):
(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):
(WebCore::InspectorInstrumentation::pseudoElementDestroyed):
(WebCore::InspectorInstrumentation::instrumentingAgentsForDocument):
(WebCore::InspectorInstrumentation::hasFrontends): Deleted.
(WebCore::InspectorInstrumentation::consoleAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::runtimeAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::timelineAgentEnabled): Deleted.
(WebCore::InspectorInstrumentation::replayAgentEnabled): Deleted.
- inspector/InspectorLayerTreeAgent.cpp:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/InspectorReplayAgent.cpp:
- inspector/InspectorReplayAgent.h:
- inspector/InspectorResourceAgent.cpp:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp:
- inspector/InspectorStyleSheet.h:
- inspector/InspectorStyleTextEditor.cpp:
- inspector/InspectorStyleTextEditor.h:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/InspectorWorkerResource.h:
- inspector/InstrumentingAgents.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageConsoleAgent.h:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/PageScriptDebugServer.cpp:
- inspector/PageScriptDebugServer.h:
- inspector/TimelineRecordFactory.cpp:
- inspector/WebConsoleAgent.cpp:
- inspector/WebConsoleAgent.h:
- inspector/WebDebuggerAgent.cpp:
- inspector/WebDebuggerAgent.h:
- inspector/WebInjectedScriptHost.cpp:
- inspector/WebInjectedScriptHost.h:
- inspector/WebInjectedScriptManager.cpp:
- inspector/WebInjectedScriptManager.h:
- inspector/WorkerConsoleAgent.cpp:
- inspector/WorkerConsoleAgent.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::applicationCacheInfo):
- loader/appcache/ApplicationCacheHost.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- page/FrameView.cpp:
(WebCore::FrameView::sendResizeEventIfNeeded):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
- page/Page.h:
- platform/ContextMenuItem.h:
- platform/efl/EflInspectorUtilities.cpp:
- platform/efl/EflInspectorUtilities.h:
- platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::ResourceRequestBase):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
- testing/Internals.cpp:
(WebCore::InspectorFrontendChannelDummy::sendMessageToFrontend):
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::setInspectorIsUnderTest):
- testing/Internals.h:
- testing/Internals.idl:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerGlobalScope.h:
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSendRequest):
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(registerWindowClass):
- WebInspector.cpp:
(WebInspector::setTimelineProfilingEnabled):
- WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
- WebNodeHighlight.h:
- WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
- WebView.h:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorGetTypeID):
(WKInspectorGetPage):
(WKInspectorIsConnected):
(WKInspectorIsVisible):
(WKInspectorIsFront):
(WKInspectorConnect):
(WKInspectorShow):
(WKInspectorHide):
(WKInspectorClose):
(WKInspectorShowConsole):
(WKInspectorShowResources):
(WKInspectorShowMainResourceForFrame):
(WKInspectorIsAttached):
(WKInspectorAttach):
(WKInspectorDetach):
(WKInspectorIsProfilingPage):
(WKInspectorTogglePageProfiling):
- UIProcess/API/C/WKPage.cpp:
(WKPageGetInspector):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_inspector_show):
(ewk_view_inspector_close):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- UIProcess/PageClient.h:
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
- UIProcess/efl/WebInspectorProxyEfl.cpp:
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::disableInspectorNodeSearch):
- UIProcess/ios/WebInspectorProxyIOS.mm:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::disableInspectorNodeSearch):
- UIProcess/mac/WebInspectorProxyMac.mm:
- WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorGetTypeID):
(WKBundleInspectorShow):
(WKBundleInspectorClose):
(WKBundleInspectorEvaluateScriptForTest):
(WKBundleInspectorSetPageProfilingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetInspector):
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
- WebProcess/WebPage/WebInspector.cpp:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspector.messages.in:
- WebProcess/WebPage/WebInspectorUI.cpp:
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebPage/WebInspectorUI.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::close):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/efl/WebInspectorEfl.cpp:
- WebProcess/WebPage/efl/WebInspectorUIEfl.cpp:
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
- WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::disableInspectorNodeSearch):
- WebProcess/WebPage/mac/WebInspectorMac.mm:
- WebProcess/WebPage/mac/WebInspectorUIMac.mm:
- config.h:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::showWebInspector):
(TestRunner::closeWebInspector):
(TestRunner::evaluateInWebInspector):
- Scripts/webkitperl/FeatureList.pm:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::showWebInspector):
(WTR::TestRunner::closeWebInspector):
(WTR::TestRunner::evaluateInWebInspector):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):
- 12:20 AM Changeset in webkit [178819] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175818. rdar://problem/19419835
- 12:18 AM Changeset in webkit [178818] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175812. rdar://problem/19420081
- 12:17 AM Changeset in webkit [178817] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175771. rdar://problem/19450090
- 12:16 AM Changeset in webkit [178816] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175718. rdar://problem/19395083
- 12:15 AM Changeset in webkit [178815] by
-
- 6 edits2 copies in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175698. rdar://problem/19419806
- 12:13 AM Changeset in webkit [178814] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175636. rdar://problem/19419798
- 12:12 AM Changeset in webkit [178813] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175334. rdar://problem/19302743
- 12:11 AM Changeset in webkit [178812] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175277. rdar://problem/19419795
- 12:10 AM Changeset in webkit [178811] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175266. rdar://problem/19420035
- 12:06 AM Changeset in webkit [178810] by
-
- 4 edits3 copies in branches/safari-600.1.4.15-branch
Merged r175236. rdar://problem/19432709
