Context Navigation

← Previous Period
Next Period →

Timeline

Mar 13, 2015:

7:57 PM Changeset in webkit [181496] by achristensen@apple.com

11 edits
4 adds in trunk

Progress towards CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=142680

Reviewed by Gyuyoung Kim.

CMakeLists.txt:
Source/PlatformMac.cmake: Added stub.
Source/cmake/OptionsMac.cmake:

Change defines to get CMake working.

Source/bmalloc:

CMakeLists.txt:
PlatformMac.cmake:

Added Zone.cpp to Mac CMake builds.

Source/JavaScriptCore:

PlatformMac.cmake:

Generate TracingDtrace.h based on project.pbxproj.

Source/WebCore:

PlatformMac.cmake:

Added new include directories and removed old source files.

Source/WebKit:

CMakeLists.txt: Added.

Source/WebKit2:

PlatformMac.cmake: Added.

7:50 PM Changeset in webkit [181495] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Object allocation sinking phase shouldn't re-decorate previously sunken allocations on each fixpoint operation
https://bugs.webkit.org/show_bug.cgi?id=142686

Reviewed by Oliver Hunt.

Just because promoteHeapAccess() notifies us of an effect to a heap location in a node doesn't
mean that we should handle it as if it was for one of our sinking candidates. Instead we should
prune based on m_sinkCandidates.

This fixes a benign bug where we would generate a lot of repeated IR for some pathological
tests.

dfg/DFGObjectAllocationSinkingPhase.cpp:

(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields):

7:50 PM Changeset in webkit [181494] by commit-queue@webkit.org

44 edits in trunk/Source

Unreviewed, rolling out r181483.
https://bugs.webkit.org/show_bug.cgi?id=142688

Caused use-after-free on many tests (Requested by ap on
#webkit).

Reverted changeset:

"Allow clients to selectively disable plug-ins"
https://bugs.webkit.org/show_bug.cgi?id=142506
http://trac.webkit.org/changeset/181483

6:44 PM Changeset in webkit [181493] by bshafiei@apple.com

8 edits in tags/Safari-601.1.22.1/Source

Merged r181491. rdar://problem/20153362

6:10 PM Changeset in webkit [181492] by Antti Koivisto

12 edits in trunk/Source/WebCore

Cache glyph widths to GlyphPages
https://bugs.webkit.org/show_bug.cgi?id=142028

Reviewed by Andreas Kling.

Currently we have a separate cache in Font for glyph widths. In practice we always need
the widths so we can just cache them in GlyphPages. This simplifies the code and removes
a per-character hash lookup from WidthIterator.

platform/graphics/Font.cpp:

(WebCore::Font::Font):
(WebCore::Font::initCharWidths):
(WebCore::Font::platformGlyphInit):
(WebCore::createAndFillGlyphPage):
(WebCore::Font::computeWidthForGlyph):

Rename to make it clear this doesn't cache.

(WebCore::GlyphPage::setGlyphDataForIndex):

Initialize the width.
This could go to GlyphPage.cpp if we had one.

platform/graphics/Font.h:

(WebCore::Font::glyphZeroWidth):
(WebCore::Font::isZeroWidthSpaceGlyph):
(WebCore::Font::zeroGlyph): Deleted.
(WebCore::Font::setZeroGlyph): Deleted.
(WebCore::Font::widthForGlyph): Deleted.

platform/graphics/FontCascade.cpp:

(WebCore::offsetToMiddleOfGlyph):

platform/graphics/FontCascadeFonts.cpp:

(WebCore::FontCascadeFonts::glyphDataForCharacter):

platform/graphics/GlyphPage.h:

(WebCore::GlyphData::GlyphData):

Return width too as part of GlyphData.

(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::setGlyphDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(WebCore::GlyphPage::GlyphPage):

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

No need to lookup width separately now.

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::advanceForGlyph):

rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::missingGlyphForFont):

svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFont):

5:52 PM Changeset in webkit [181491] by eric.carlson@apple.com

8 edits in trunk/Source

[Mac] Enable WIRELESS_PLAYBACK_TARGET
https://bugs.webkit.org/show_bug.cgi?id=142635

Reviewed by Darin Adler.

Configurations/FeatureDefines.xcconfig:

4:01 PM Changeset in webkit [181490] by rniwa@webkit.org

14 edits
3 adds in trunk

Class constructor should throw TypeError when "called"
https://bugs.webkit.org/show_bug.cgi?id=142566

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Added ConstructorKind::None to denote code that doesn't belong to an ES6 class.
This allows BytecodeGenerator to emit code to throw TypeError when generating code block
to call ES6 class constructors.

Most of changes are about increasing the number of bits to store ConstructorKind from one
bit to two bits.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

bytecode/UnlinkedCodeBlock.h:

(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::needsActivation):
(JSC::ExecutableInfo::usesEval):
(JSC::ExecutableInfo::isStrictMode):
(JSC::ExecutableInfo::isConstructor):
(JSC::ExecutableInfo::isBuiltinFunction):
(JSC::ExecutableInfo::constructorKind):
(JSC::UnlinkedFunctionExecutable::constructorKind):
(JSC::UnlinkedCodeBlock::constructorKind):
(JSC::UnlinkedFunctionExecutable::constructorKindIsDerived): Deleted.
(JSC::UnlinkedCodeBlock::constructorKindIsDerived): Deleted.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate): Don't emit bytecode when we had already emitted code
to throw TypeError.
(JSC::BytecodeGenerator::BytecodeGenerator): Emit code to throw TypeError when generating
code to call.
(JSC::BytecodeGenerator::emitReturn):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::constructorKind):
(JSC::BytecodeGenerator::constructorKindIsDerived): Deleted.

bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):

parser/Nodes.cpp:

(JSC::FunctionBodyNode::FunctionBodyNode):

parser/Nodes.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionInfo): Renamed the incoming function argument to
ownerClassKind. Set constructorKind to Base or Derived only if we're parsing a constructor.
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass): Don't parse static methods using MethodMode since that
would result in BytecodeGenerator erroneously treating static method named "constructor" as
a class constructor.
(JSC::Parser<LexerType>::parsePropertyMethod):
(JSC::Parser<LexerType>::parsePrimaryExpression):

parser/Parser.h:
parser/ParserModes.h:
runtime/Executable.h:

(JSC::EvalExecutable::executableInfo):
(JSC::ProgramExecutable::executableInfo):

LayoutTests:

Added tests for calling class constructors.

TestExpectations: Skipped the test since ES6 class syntax isn't enabled by default.
js/class-syntax-call-expected.txt: Added.
js/class-syntax-call.html: Added.
js/script-tests/class-syntax-call.js: Added.

3:34 PM March 2015 Meeting edited by achristensen@apple.com

(diff)

3:33 PM March 2015 Meeting edited by achristensen@apple.com

(diff)

3:32 PM CMake edited by achristensen@apple.com

(diff)

3:30 PM Changeset in webkit [181489] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix typo restoreUserInterfaceForOptimizedFullscreeStopWithCompletionHandler.
https://bugs.webkit.org/show_bug.cgi?id=142678

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-03-13
Reviewed by Eric Carlson.

Add the missing 'n' in "fullscreen".

platform/spi/ios/AVKitSPI.h:

3:28 PM CMake created by achristensen@apple.com

2:40 PM WebKitDotOrgUpdates created by bfulgham@webkit.org

2:07 PM Changeset in webkit [181488] by timothy_horton@apple.com

5 edits in trunk/Source

Sites that use a device-width viewport but don't have enough height to fill the view are scaled up
https://bugs.webkit.org/show_bug.cgi?id=142664
<rdar://problem/18859470>

Reviewed by Benjamin Poulain.

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints):
(WebCore::ViewportConfiguration::shouldIgnoreVerticalScalingConstraints):
(WebCore::ViewportConfiguration::shouldIgnoreScalingConstraints):
Split shouldIgnoreScalingConstraints into one for each dimension.

(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::minimumScale):
Don't force the initial and minimum scales to cover the whole view if the
page claims to want to lay out to device width but then lays out too big.
This will allow pages that misbehave in this way to scale down further
than they previously could, but will result in a region of empty background
color being exposed at the initial/minimum scale.

(WebCore::ViewportConfiguration::description):
Update the logging to show each dimension separately.

page/ViewportConfiguration.h:

UIProcess/ios/WKScrollView.mm:

(-[WKScrollView _rubberBandOffsetForOffset:maxOffset:minOffset:range:outside:]):
Now that the WKContentView can (without pinching) be smaller than the unobscured
region of the WKWebView, we need to take that into account when deciding where
to retarget scrolling.

1:57 PM March 2015 Meeting edited by bfulgham@webkit.org

(diff)

1:56 PM March 2015 Meeting edited by bfulgham@webkit.org

(diff)

1:55 PM March 2015 Meeting edited by bfulgham@webkit.org

(diff)

1:18 PM Changeset in webkit [181487] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG::PutStackSinkingPhase should eliminate GetStacks that have an obviously known source
https://bugs.webkit.org/show_bug.cgi?id=141624

Reviewed by Oliver Hunt.

This was an obvious omission from the original PutStackSinkingPhase. Previously, we would treat
GetStacks conservatively and assume that the stack slot escaped. That's pretty dumb, since a
GetStack is a local load of the stack. This change makes GetStack a no-op from the standpoint of
this phase's deferral analysis. At the end we either keep the GetStack (if there was no concrete
deferral) or we replace it with an identity over the value that would have been stored by the
deferred PutStack. Note that this might be a Phi that the phase creates, so this is strictly
stronger than what GCSE could do.

This is probably not a speed-up now, but it will be very useful for the varargs simplification
done in bug 141174.

dfg/DFGPutStackSinkingPhase.cpp:

1:14 PM Changeset in webkit [181486] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

Prohibit GC while sweeping
https://bugs.webkit.org/show_bug.cgi?id=142638

Reviewed by Andreas Kling.

I noticed in https://bugs.webkit.org/show_bug.cgi?id=142636 that a GC
could trigger a sweep which could trigger another GC. Yo Dawg.

I tried to figure out whether this could cause problems or not and it
made me cross-eyed.

(Some clients like to report extra memory cost during deallocation as a
way to indicate that the GC now owns something exclusively. It's
arguably a bug to communicate with the GC in this way, but we shouldn't
do crazy when this happens.)

This patch makes explicit the fact that we don't allow GC while sweeping.

Usually, sweeping implicitly defers GC by virtue of happening during
allocation. But not always.

heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Defer GC while sweeping due to an
explicit GC request.

(JSC::Heap::didFinishCollection): Make sure that zombifying sweep
defers GC by not returning to the non-GC state until we're all done.

heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::sweepNextBlock): Defer GC while sweeping due
to a timer.

1:04 PM Changeset in webkit [181485] by mark.lam@apple.com

28 edits
1 add
1 delete in trunk/Source

Replace TCSpinLock with a new WTF::SpinLock based on WTF::Atomic.
<https://webkit.org/b/142674>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

API/JSValue.mm:

(handerForStructTag):

API/JSWrapperMap.mm:
dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing):
(JSC::DFG::isCrashing):

Changed to use a StaticSpinLock since that's what this code was trying to do anyway.
heap/CopiedBlock.h:

(JSC::CopiedBlock::CopiedBlock):

heap/CopiedSpace.cpp:

(JSC::CopiedSpace::CopiedSpace):

heap/CopiedSpace.h:
heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):

heap/GCThreadSharedData.h:
heap/ListableHandler.h:

(JSC::ListableHandler::List::List):

parser/SourceProvider.cpp:
profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::removeFirstAtExitDatabase):

Source/WebCore:

No new tests because there is no new functionality. This is a refactoring effort.

bindings/objc/WebScriptObject.mm:
platform/ios/wak/WAKWindow.mm:

(-[WAKWindow initWithLayer:]):
(-[WAKWindow initWithFrame:]):

Source/WebKit2:

WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::EventDispatcher):

WebProcess/WebPage/EventDispatcher.h:
WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::ViewUpdateDispatcher):

WebProcess/WebPage/ViewUpdateDispatcher.h:

Source/WTF:

We no longer use TCMalloc in our code, and we now have C++11. This replaces the
TCMalloc_SpinLock with a new WTF::SpinLock based on WTF::Atomic (which is a
wrapper around std::atomic).

Note that there is a StaticSpinLock and a SpinLock:

StaticSpinLock is an alias for SpinLockBase, and its initialization relies on static / global std:atomic being automatically initialized to 0 at compile time. Hence, StaticSpinLock should only be used for statics / globals (including static members of classes / structs).

SpinLock is derived from SpinLockBase, and adds a default constructor to initialize its internal atomic value to 0. Because SpinLock has a constructor, it cannot be used for statics / globals. Objects that want to embed a spin lock as an instance field should use SpinLock so that it is initialized properly. std::atomic will not automatically initialize instance fields to 0. Hence, StaticSpinLock will not work correctly as instance fields of a class / struct.

WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::~MetaAllocator):
(WTF::MetaAllocator::MetaAllocator):

wtf/MetaAllocator.h:
wtf/SpinLock.h: Added.

(WTF::SpinLockBase::lock):
(WTF::SpinLockBase::unlock):
(WTF::SpinLockBase::isLocked):
(WTF::SpinLockBase::slowLock):
(WTF::SpinLock::SpinLock):

wtf/TCSpinLock.h: Removed.
wtf/text/AtomicString.cpp:

12:24 PM Changeset in webkit [181484] by commit-queue@webkit.org

11 edits
2 adds in trunk

AX: Provide API for assistive tech to ignore DOM key event handlers
https://bugs.webkit.org/show_bug.cgi?id=142059

Patch by Doug Russell <d_russell@apple.com> on 2015-03-13
Reviewed by Beth Dakin.

Assistive technology applications on the desktop are heavily dependent on keyboard navigation being reliable. This is greatly hindered by sites that handle key events without updating keyboard selection and then consume the event. It is important for assistive technology apps to allow users to decide to ignore these handlers that are incorrect for their purposes.

This can be fixed by exposing, via a new accessibility attribute, a way to decide, for a given WebCore::Frame, to pre-empt DOM dispatch and instead let accessibility caret browsing take place.

Source/WebCore:

Test: platform/mac/accessibility/prevent-keyboard-event-dispatch.html

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::preventKeyboardDOMEventDispatch):
(WebCore::AccessibilityObject::setPreventKeyboardDOMEventDispatch):

accessibility/AccessibilityObject.h:
accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

dom/Element.cpp:

(WebCore::Element::dispatchKeyEvent):

page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent):
(WebCore::handleKeyboardSelectionMovement):
(WebCore::EventHandler::handleKeyboardSelectionMovementForAccessibility):

page/EventHandler.h:
page/Settings.in:

LayoutTests:

accessibility/parent-delete-expected.txt:
platform/mac/accessibility/document-attributes-expected.txt:
platform/mac/accessibility/prevent-keyboard-event-dispatch-expected.txt: Added.
platform/mac/accessibility/prevent-keyboard-event-dispatch.html: Added.

11:58 AM Changeset in webkit [181483] by Conrad Shultz

44 edits in trunk/Source

Allow clients to selectively disable plug-ins
https://bugs.webkit.org/show_bug.cgi?id=142506

Reviewed by Anders Carlsson.

Source/WebCore:

Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
from the page). As part of this:

1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying

set of plug-ins.

2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper

down the stack.

3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce

a concrete implementation thereof in WebPlatformStrategies in WebKit2.

4) Add messaging infrastructure to allow clients to set and clear plug-in policies.

While currently only used in a very limited manner, the new declarative plug-in policies are written generically
so that they could be easily used in the future to reduce synchronous messaging to the client when loading plug-ins.

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
Update to reflect function rename.

loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::logPluginRequest):
Update to reflect function rename.
(WebCore::SubframeLoader::shouldUsePlugin):
Ditto.

platform/PlatformStrategies.h:

Export platformStrategies(), since it is now used in WebProcess.cpp.

plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::type):
(WebCore::DOMMimeType::description):
(WebCore::DOMMimeType::mimeClassInfo):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::DOMMimeType::enabledPlugin):
Ditto.

plugins/DOMMimeType.h:

Don't return references in a few places where it is no longer safe to do so.
(WebCore::DOMMimeType::mimeClassInfo): Deleted.

plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::length):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::DOMMimeTypeArray::item):
Ditto.
(WebCore::DOMMimeTypeArray::canGetItemsForName):
Ditto.
(WebCore::DOMMimeTypeArray::namedItem):
Ditto.

plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::pluginInfo):
Adopt getWebVisiblePlugins().
(WebCore::DOMPlugin::item):
Adopt getWebVisibleMimesAndPluginIndices().
(WebCore::DOMPlugin::canGetItemsForName):
Ditto.
(WebCore::DOMPlugin::namedItem):
Ditto.

plugins/DOMPlugin.h:

(WebCore::DOMPlugin::pluginInfo): Deleted.

plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::length):
Adopt getWebVisiblePlugins().
(WebCore::DOMPluginArray::item):
Ditto.
(WebCore::DOMPluginArray::canGetItemsForName):
Ditto.
(WebCore::DOMPluginArray::namedItem):
Ditto.

plugins/PluginData.cpp:

(WebCore::PluginData::PluginData):
Stash the passed-in Page and call initPlugins().
(WebCore::PluginData::getWebVisiblePlugins):
New member function; call through to PluginStrategy::getWebVisiblePluginInfo().
(WebCore::PluginData::getWebVisibleMimesAndPluginIndices):
New member function; build up the mimes and mimePluginIndices vectors in the same manner as before, but
limited to the web-visible plug-ins.
(WebCore::PluginData::supportsWebVisibleMimeType):
Renamed from supportsMimeType(); update to work in terms of web-visible plug-ins.
(WebCore::PluginData::pluginInfoForWebVisibleMimeType):
Renamed from pluginInfoForMimeType(); ditto.
(WebCore::PluginData::pluginNameForWebVisibleMimeType):
Renamed from pluginNameForMimeType(); ditto.
(WebCore::PluginData::pluginFileForWebVisibleMimeType):
Renamed from pluginFileForMimeType(); ditto.
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::supportsMimeType): Deleted.
(WebCore::PluginData::pluginInfoForMimeType): Deleted.
(WebCore::PluginData::pluginNameForMimeType): Deleted.
(WebCore::PluginData::pluginFileForMimeType): Deleted.

plugins/PluginData.h:

Add a member variable for the associate Page; declare the PluginLoadClientPolicy enumeration; add
new members to PluginInfo for the clientLoadPolicy and bundle information.
(WebCore::PluginData::PluginData):
Replace some member functions with new ones that will hide plug-ins upon request from the client;
(WebCore::PluginData::mimes): Deleted.
(WebCore::PluginData::mimePluginIndices): Deleted.

plugins/PluginStrategy.h:

Declare new member functions for retrieving web-visible plug-ins and setting/clearing plug-in policies.

replay/SerializationMethods.cpp:

(JSC::EncodingTraits<PluginData>::encodeValue):
Remove now-obsolete code for handling MIME types and add a FIXME.
(JSC::DeserializedPluginData::DeserializedPluginData):
(JSC::EncodingTraits<PluginData>::decodeValue):
Ditto.
(JSC::EncodingTraits<PluginInfo>::encodeValue):
Handle the new members in PluginInfo.
(JSC::EncodingTraits<PluginInfo>::decodeValue):
Ditto.

replay/WebInputs.json:

Teach Replay about PluginLoadClientPolicy.

Source/WebKit/mac:

Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
from the page). As part of this:

1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying

set of plug-ins.

2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper

down the stack.

3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce

a concrete implementation thereof in WebPlatformStrategies in WebKit2.

4) Add messaging infrastructure to allow clients to set and clear plug-in policies.

Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage getPluginInfoFromPLists]):
Set new members in PluginInfo.

Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):
Set new members in PluginInfo.

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::getWebVisiblePluginInfo):
Override to wrap getPluginInfo().
(WebPlatformStrategies::setPluginLoadClientPolicy):
Override to do nothing.
(WebPlatformStrategies::clearPluginClientPolicies):
Ditto.

WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]):
Update to reflect function rename.

Source/WebKit/win:

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getWebVisiblePluginInfo):
Wrap getPluginInfo();

WebView.cpp:

(WebView::canShowMIMEType):
Update to reflect function rename.

Source/WebKit2:

Add new functionality allow clients to declaratively disable individual plug-ins (in a manner that conceals them
from the page). As part of this:

1) Introduce the concept of web-visible plug-ins and related concepts, as distinct from the real underlying

set of plug-ins.

2) Where applicable, plumb additional information about plug-ins (specifically, bundle identification) deeper

down the stack.

3) Add generic functionality to PluginStrategy to support filtering plug-ins for visibility and introduce

a concrete implementation thereof in WebPlatformStrategies in WebKit2.

4) Add messaging infrastructure to allow clients to set and clear plug-in policies.

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):
Set new PluginInfo members.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PluginInfo>::encode):
Handle new PluginInfo members.
(IPC::ArgumentCoder<PluginInfo>::decode):
Ditto.

Shared/WebProcessCreationParameters.h:

Declare a member to store client plug-in policies.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
Encode the policies.
(WebKit::WebProcessCreationParameters::decode):
Decode the policies.

UIProcess/API/C/WKAPICast.h:

(WebKit::toWKPluginLoadClientPolicy):
Teach how to cast between WebCore and WebKit2 policy definitions.
(WebKit::toPluginLoadClientPolicy):
Ditto.

UIProcess/API/C/WKPluginLoadPolicy.h:

Declare WKPluginLoadClientPolicy, matching PluginLoadClientPolicy in WebCore.

UIProcess/API/C/mac/WKContextPrivateMac.h:
UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextSetPluginLoadClientPolicy):
New function; wrap WebProcessPool::setPluginLoadClientPolicy().
(WKContextClearPluginClientPolicies):
New function; wrap WebProcessPool::clearPluginClientPolicies().

UIProcess/WebProcessPool.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):
Copy any client plug-in policies to the new process' creation parameters.
(WebKit::WebProcessPool::setPluginLoadClientPolicy):
Send SetPluginLoadClientPolicy to all processes and stash the passed-in policy info.
(WebKit::WebProcessPool::clearPluginClientPolicies):
Send ClearPluginClientPolicies to all processes and clear any stashed policy info.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::pluginInfo):
Set new PluginInfo member.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::pluginSupportsExtension):
Adopt getWebVisibleMimesAndPluginIndices().
(WebKit::WebFrameLoaderClient::objectContentType):
Update to reflect reflect function rename.

WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPluginInfo):
Pass the Page to populatePluginCache().
(WebKit::WebPlatformStrategies::getWebVisiblePluginInfo):
New member function; wrap getPluginInfo(); if appropriate, filter out plug-ins the client has asked
to block on the current page.
(WebKit::WebPlatformStrategies::setPluginLoadClientPolicy):
New member function; map empty inputs to a wildcard character and insert the new policy into the nested map.
(WebKit::WebPlatformStrategies::clearPluginClientPolicies):
New member function; empty m_hostsToPluginIdentifierData.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost):
New member function; look up the most specific policy for the given plug-in and host.
(WebKit::WebPlatformStrategies::populatePluginCache):
If appropriate, set the client load policy on the plug-ins; do this irrespective of whether the cache has
been populated since the Page, and therefore host, may change.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canShowMIMEType):
Update to reflect function rename.

WebProcess/WebProcess.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Enumerate and process the client plug-in policies in the creation parameters.
(WebKit::WebProcess::setPluginLoadClientPolicy):
New member function; wrap PluginStrategy::setPluginLoadClientPolicy.
(WebKit::WebProcess::clearPluginClientPolicies):
New member function; wrap PluginStrategy::clearPluginClientPolicies().

WebProcess/WebProcess.messages.in:

Add messages for setting and clearing policies.

11:19 AM Changeset in webkit [181482] by rniwa@webkit.org

3 edits in trunk/Source/JavaScriptCore

BytecodeGenerator needs to be re-entrant to support miranda functions
https://bugs.webkit.org/show_bug.cgi?id=142627

Reviewed by Filip Pizlo.

Made CodeCache::getGlobalCodeBlock and CodeCache::getFunctionExecutableFromGlobalCode re-entrant
by not keeping AddResult while invoking BytecodeGenerator::generate.

This is needed to support Miranda functions since they need to be lazily initialized.

runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

runtime/CodeCache.h:

(JSC::CodeCacheMap::findCacheAndUpdateAge): Extracted from add.
(JSC::CodeCacheMap::addCache): Extracted from add.
(JSC::CodeCacheMap::add): Deleted.

11:02 AM Changeset in webkit [181481] by mark.lam@apple.com

7 edits in trunk/Source

Introduce WTF::Atomic to wrap std::atomic for a friendlier CAS.
<https://webkit.org/b/142661>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Changed CodeBlock, and the DFG's crashLock to use WTF::Atomic instead of
std::atomic.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):

bytecode/CodeBlock.h:
dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing):

Source/WTF:

The CAS functions provided by std::atomic takes a reference to the expected
value and modifies it if the CAS fails. However, in a lot of our CAS usage,
we don't want the expected value to change. The solution to this is to
provide a WTF::Atomic struct that wraps std::atomic, and provide CAS
methods that won't alter the expected value if the CAS fails.

The method names in WTF::Atomic are chosen to be identical to those
in std::atomic so that WTF::Atomic can be a simple drop in replacement
for std::atomic.

Also changed ByteSpinLock to use WTF::Atomic instead of std::atomic.

wtf/Atomics.h:

(WTF::Atomic::load):
(WTF::Atomic::store):
(WTF::Atomic::compare_exchange_weak):
(WTF::Atomic::compare_exchange_strong):

wtf/ByteSpinLock.h:

(WTF::ByteSpinLock::ByteSpinLock):
(WTF::ByteSpinLock::lock):

10:58 AM Changeset in webkit [181480] by Chris Dumez

12 edits
3 adds in trunk

XMLHttpRequests should not prevent a page from entering PageCache
https://bugs.webkit.org/show_bug.cgi?id=142612
<rdar://problem/19923085>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Make XMLHttpRequest ActiveDOMObjects suspendable in most cases to
drastically improve the likelihood of pages using them to enter
PageCache. XMLHttpRequest used to be only suspendable when not
loading. After this patch, if the XMLHttpRequest is loading when
navigating away from the page, it will be aborted and the page
will enter the PageCache. Upon restoring the page from PageCache,
the XMLHttpRequests' error handlers will be executed to give them
a chance to reload if they want to.

Test: http/tests/navigation/page-cache-xhr.html

history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
Do not prevent a page to enter the page cache ff the main document has
an error that is a cancellation and all remaining subresource loaders
are for XHR. We extend the pre-existing mechanism used on iOS, which
allowed PageCaching if the remaining resource loads are for images.

loader/DocumentLoader.cpp:

(WebCore::areAllLoadersPageCacheAcceptable):
Mark XHR loaders as PageCache acceptable.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::isXMLHttpRequest):

loader/DocumentThreadableLoader.h:
loader/ThreadableLoader.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::areAllClientsXMLHttpRequests):

loader/cache/CachedResource.h:
loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::isXMLHttpRequest):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::canSuspend):
Report that we can suspend XMLHttpRequests as long as the window load
event has already fired. If the window load event has not fired yet,
it would be unsafe to cancel the load in suspend() as it would
potentially cause arbitrary JS execution while suspending.

(WebCore::XMLHttpRequest::suspend):
If suspending for PageCache and the request is currently loading, abort
the load and mark that we should fire the error event upon restoring
from PageCache.

(WebCore::XMLHttpRequest::resume):
(WebCore::XMLHttpRequest::resumeTimerFired):
Upon resuming, fire the error event in a timer if the load was aborted
for suspending. We need to do this in a timer because we are not allowed
to execute arbitrary JS inside resume().

(WebCore::XMLHttpRequest::stop):
Add a assertion to make sure we are not firing event inside stop() as
this would potentially cause arbitrary JS execution and it would be
unsafe. It seems to me that our code is currently unsafe but the
assertion does not seem to be hit by our current layout tests. I am
adding the assertion as it would make it clear we have a bug and we
need to fix it.

xml/XMLHttpRequest.h:

LayoutTests:

Add a tests to make sure that loading XMLHttpRequests do not prevent a
page from entering PageCache.

http/tests/navigation/page-cache-xhr-expected.txt: Added.
http/tests/navigation/page-cache-xhr.html: Added.
http/tests/navigation/resources/page-cache-helper.html: Added.

9:00 AM Changeset in webkit [181479] by youenn.fablet@crf.canon.fr

3 edits
3 adds in trunk

WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
https://bugs.webkit.org/show_bug.cgi?id=134764

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

TestRepositories defines the git repositories used to import tests.
It defines for each repository the infrastructure paths to always import, the paths to skip and the revision to use.
ImportExpectartions defines the tests to import.

resources/ImportExpectations: Added.
resources/TestRepositories: Added.

Tools:

TestDownloader is introduced to download W3C tests from the official
W3C tests repositories (https://github.com/w3c/web-platform-tests.git
and https://github.com/w3c/csswg-test.git).
TestDownloader clones the repositories and checkouts revisions of the tests
defined in LayoutTests/imported/w3c/resources/TestRepositories.

Similarly to https://codereview.chromium.org/148173016,
TestDownloader copies part of the files based on the rules
defined in LayoutTests/imported/w3c/resources/ImportExpectations.

TestDownloader is used by TestImporter when no source directory is provided.

Scripts/webkitpy/w3c/test_downloader.py: Added.

(TestDownloader):
(TestDownloader.default_options):
(TestDownloader.load_test_repositories):
(TestDownloader.init):
(TestDownloader.checkout_test_repository):
(TestDownloader._init_paths_from_expectations):
(TestDownloader._add_test_suite_paths):
(TestDownloader._empty_directory):
(TestDownloader.copy_tests):
(TestDownloader.download_tests):

Scripts/webkitpy/w3c/test_importer.py:

(main):
(parse_args):
(TestImporter.init):
(TestImporter.do_import):
(TestImporter.test_downloader):
(TestImporter.find_importable_tests.should_keep_subdir):
(TestImporter.should_convert_test_harness_links):
(TestImporter.import_tests):
(TestImporter.write_import_log):

8:45 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

6:50 AM Changeset in webkit [181478] by commit-queue@webkit.org

2 edits
1 add in trunk/LayoutTests

Unreviewed Gardening 13th March.
https://bugs.webkit.org/show_bug.cgi?id=142665

Unreviewed.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-13

platform/gtk/TestExpectations:
platform/gtk/fast/borders/mixed-border-style2-expected.txt: Added. The result was missing.

6:47 AM Changeset in webkit [181477] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Rebaseline accessibility/color-well.html
https://bugs.webkit.org/show_bug.cgi?id=141697

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-13
Reviewed by Chris Fleizach.

The revision (r179922) which makes this test fail, implements a color
picker for GTK+ platform. So now we have different accessibility
information for a color input and we could update the expected file.

TestExpectations has also been updated.

platform/gtk/TestExpectations:
platform/gtk/accessibility/color-well-expected.txt:

6:00 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

1:27 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com

(diff)

1:08 AM Changeset in webkit [181476] by jhoneycutt@apple.com

3 edits in trunk/Source/WebKit2

Use UIDocumentMenuViewController to allow selection of files from
iCloud Drive in WKFileUploadPanel

Part of <https://bugs.webkit.org/show_bug.cgi?id=142596> WebKit on
iOS should support file upload from iCloud Drive
<rdar://problem/12178991>

Reviewed by Andy Estes.

Platform/spi/ios/UIKitSPI.h:

Include UIDocumentMenuViewController_Private.h if it exists. If not,
declare this new SPI.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(fallbackIconForFile):
Create a UIDocumentInteractionController for the file, and return a
thumbnail image from its smallest icon.

(iconForImageFile):
If we can get a UIImage from the file, create a thumbnail from it.
Otherwise, call fallbackIconForFile().

(iconForVideoFile):
Code moved from -[_WKVideoFileUploadItem displayImage].

(iconForFile):
Get the file's extension, and get the extension's preferred UTI. If the
UTI is an image type, call iconForImageFile(). If it's a video type,
call iconForVideoFile(). Otherwise, return the fallback icon.

(-[_WKFileUploadItem initWithFileURL:]):
Added an initializer that takes a file URL.

(-[_WKFileUploadItem fileURL]):
(-[_WKImageFileUploadItem initWithFileURL:originalImage:]):
(-[_WKVideoFileUploadItem displayImage]):
(WKFileUploadPanel):
Inherit from UIDocumentPickerDelegate and UIDocumentMenuDelegate. Add
an ivar for the document menu controller.

(-[WKFileUploadPanel dealloc]):
(-[WKFileUploadPanel presentWithParameters:resultListener:]):
If instances of UIDocumentMenuViewController respond to
-_setIgnoreApplicationEntitlementForImport:, meaning we can disable the
assertion that the current app has the iCloud Documents entitlement,
then show the document picker menu. Otherwise, show the current source
selection UI. The runtime check will be removed when a newer UIKit is
available.

(UTIsForMIMETypes):
Return the UTIs for the <input> element's "accept" attribute's MIME
type list.

(-[WKFileUploadPanel _mediaTypesForPickerSourceType:]):
Call UTIsForMIMETypes(). Fall back to available source types for this
picker type.

(-[WKFileUploadPanel _documentPickerMenuMediaTypes]):
Call UTIsForMIMETypes(). Fall back to the all-encompassing
"public.item" UTI.

(-[WKFileUploadPanel _photoLibraryButtonLabel]):
(-[WKFileUploadPanel _cameraButtonLabel]):
Factored out of -_showMediaSourceSelectionSheet. Return the
appropriate label for the camera button, based on whether it can take a
photo or video, or return nil if the camera is not available.

(-[WKFileUploadPanel _showMediaSourceSelectionSheet]):
Changed to use -_cameraButtonLabel and
-_presentForCurrentInterfaceIdiom:.

(-[WKFileUploadPanel _showDocumentPickerMenu]):
Create a UIDocumentMenuViewController, and populate it with options to
open the photo library or take a picture or video. If iCloud Drive or
other document sources are available, they will be added automatically.

(-[WKFileUploadPanel _presentForCurrentInterfaceIdiom:]):
(-[WKFileUploadPanel documentMenu:didPickDocumentPicker:]):
(-[WKFileUploadPanel documentMenuWasCancelled:]):
(-[WKFileUploadPanel documentPicker:didPickDocumentAtURL:]):
(-[WKFileUploadPanel documentPickerWasCancelled:]):
(-[WKFileUploadPanel _uploadItemFromMediaInfo:successBlock:failureBlock:]):

(-[_WKImageFileUploadItem initWithFilePath:originalImage:]): Deleted.
(-[_WKImageFileUploadItem fileURL]): Deleted.
(-[_WKVideoFileUploadItem initWithFilePath:mediaURL:]): Deleted.
(-[_WKVideoFileUploadItem fileURL]): Deleted.

12:52 AM Changeset in webkit [181475] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Fix Debug build error 'comparison is always true due to limited range of data type [-Werror=type-limits]'
https://bugs.webkit.org/show_bug.cgi?id=142652

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-03-13
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes.

Now CSSPropertyID type is uint16_t, so propertyID >= 0 check is needed no more.

css/CSSPrimitiveValue.cpp:

(WebCore::propertyName):

css/makeprop.pl:

12:18 AM Changeset in webkit [181474] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

Unreviewed GTK+ Gardening
https://bugs.webkit.org/show_bug.cgi?id=142620

Rebaseline the missing test result

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-03-13

platform/gtk/fast/borders/mixed-border-style2-expected.png: Added.
platform/gtk/fast/css/css2-system-fonts-expected.txt: Added.
platform/gtk/fast/text/tatechuyoko-expected.txt: Added.

Mar 12, 2015:

11:26 PM Changeset in webkit [181473] by bshafiei@apple.com

5 edits in tags/Safari-601.1.22.1/Source

Versioning.

11:23 PM Changeset in webkit [181472] by bshafiei@apple.com

1 copy in tags/Safari-601.1.22.1

New tag.

11:17 PM Changeset in webkit [181471] by bshafiei@apple.com

5 edits in branches/safari-600.5-branch/Source

Versioning.

11:17 PM Changeset in webkit [181470] by bshafiei@apple.com

5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

8:02 PM Changeset in webkit [181469] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Change the DFG crashLock to use std::atomic.
<https://webkit.org/b/142649>

Reviewed by Filip Pizlo.

dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing):
(JSC::DFG::isCrashing):

7:01 PM Changeset in webkit [181468] by commit-queue@webkit.org

14 edits
4 deletes in trunk/Source/WebCore

Remove DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=142641

Patch by Zan Dobersek <zdobersek@igalia.com> on 2015-03-12
Reviewed by Darin Adler.

Remove the DrawingBuffer class. Objects of this type were only held in the
WebGLRenderingContext (later renamed to WebGLRenderingContextBase) on the
Chromium port, with the relevant code removed in r147888. Since then, the
m_drawingBuffer member variable has always been null.

CMakeLists.txt:
PlatformEfl.cmake:
PlatformGTK.cmake:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::copyTexImage2D):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexImage2D):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::initializeNewContext):
(WebCore::WebGLRenderingContextBase::destroyGraphicsContext3D):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::clearIfComposited):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToImageData):
(WebCore::WebGLRenderingContextBase::reshape):
(WebCore::WebGLRenderingContextBase::drawingBufferWidth):
(WebCore::WebGLRenderingContextBase::drawingBufferHeight):
(WebCore::WebGLRenderingContextBase::activeTexture):
(WebCore::WebGLRenderingContextBase::bindFramebuffer):
(WebCore::WebGLRenderingContextBase::bindTexture):
(WebCore::WebGLRenderingContextBase::copyTexSubImage2D):
(WebCore::WebGLRenderingContextBase::deleteFramebuffer):
(WebCore::WebGLRenderingContextBase::disable):
(WebCore::WebGLRenderingContextBase::enable):
(WebCore::WebGLRenderingContextBase::getContextAttributes):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::getBoundFramebufferWidth):
(WebCore::WebGLRenderingContextBase::getBoundFramebufferHeight):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):

html/canvas/WebGLRenderingContextBase.h:

(WebCore::ScopedDrawingBufferBinder::ScopedDrawingBufferBinder): Deleted.
(WebCore::ScopedDrawingBufferBinder::~ScopedDrawingBufferBinder): Deleted.

platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContext3D.h:
platform/graphics/cairo/DrawingBufferCairo.cpp: Removed.
platform/graphics/gpu/DrawingBuffer.cpp: Removed.
platform/graphics/gpu/DrawingBuffer.h: Removed.
platform/graphics/gpu/mac/DrawingBufferMac.mm: Removed.
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):

6:57 PM Changeset in webkit [181467] by fpizlo@apple.com

6 edits in trunk/Source

Bytecode liveness analysis should have more lambdas and fewer sets
https://bugs.webkit.org/show_bug.cgi?id=142647

Reviewed by Mark Lam.

Source/JavaScriptCore:

In bug 141174 I'll need to identify all of the bytecode kill sites. This requires hooking into
the bytecode analysis' stepOverFunction method, except in such a way that we observe uses that
are not in outs. This refactors stepOverFunction so that you can pass it use/def functors that
can either be used to propagate outs (as we do right now) or to additionally detect kills or
whatever else.

In order to achieve this, the liveness analysis was moved off of maintaining uses/defs
bitvectors. This wasn't helping the abstraction and was probably inefficient. The new code
should be a bit faster since we don't have to clear uses/defs bitvectors on each instruction. On
the other hand, being able to intercept each use means that our code for exception handlers is
no longer a bitwise-merge; it requires finding set bits. Fortunately, this code only kicks in
for instructions inside a try, and its performance is O(live at catch), so that's probably not
bad.

bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::indexForOperand):
(JSC::stepOverInstruction):
(JSC::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeFullLiveness):
(JSC::setForOperand): Deleted.

bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

Source/WTF:

Add a method for iterating each set bit in a FastBitVector. Uses a functor as a callback since
this allows for a more efficient algorithm.

wtf/FastBitVector.h:

(WTF::FastBitVector::forEachSetBit):

6:11 PM Changeset in webkit [181466] by rniwa@webkit.org

31 edits
10 adds in trunk/Source/JavaScriptCore

"this" should be in TDZ until super is called in the constructor of a derived class
https://bugs.webkit.org/show_bug.cgi?id=142527

Reviewed by Mark Hahnenberg.

DFG and FTL implementations co-authored by Filip Pizlo.

In ES6 class syntax, "this" register must be in the "temporal dead zone" (TDZ) and throw ReferenceError until
super() is called inside the constructor of a derived class.

Added op_check_tdz, a new OP code, which throws a reference error when the first operand is an empty value
to all tiers of JIT and LLint. The op code throws in the slow path on the basis that a TDZ error should be
a programming error and not a part of the programs' normal control flow. In DFG, this op code is represented
by a no-op must-generate node CheckNotEmpty modeled after CheckCell.

Also made the constructor of a derived class assign the empty value to "this" register rather than undefined
so that ThisNode can emit the op_check_tdz to check the initialized-ness of "this" in such a constructor.

bytecode/BytecodeList.json: Added op_check_tdz.
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset): Ditto.
(JSC::computeDefsForBytecodeOffset): Ditto.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode): Ditto.

bytecode/ExitKind.cpp:

(JSC::exitKindToString): Added TDZFailure.

bytecode/ExitKind.h: Ditto.
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Assign the empty value to "this" register to indicate it's in TDZ.
(JSC::BytecodeGenerator::emitTDZCheck): Added.
(JSC::BytecodeGenerator::emitReturn): Emit the TDZ check since "this" can still be in TDZ if super() was never
called. e.g. class B extends A { constructor() { } }

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode): Always emit the TDZ check if we're inside the constructor of a derived class.
We can't omit this check even if the result was ignored per spec.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Previously, empty value could never appear
in a local variable. This is no longer true so generalize this code. Also added the support for CheckNotEmpty.
Like CheckCell, we phantomize this DFG node in the constant folding phase if the type of the operand is already
found to be not empty. Otherwise filter out SpecEmpty.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Added op_check_tdz.

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel): op_check_tdz can be compiled and inlined.

dfg/DFGClobberize.h:

(JSC::DFG::clobberize): CheckNotEmpty doesn't read or write values.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants): Convert CheckNotEmpty to a phantom if non-emptiness had already
been proven for the operand prior to this node.

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC): CheckNotEmpty does not trigger GC.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): CheckNotEmpty is a no-op in the fixup phase.

dfg/DFGNodeType.h: CheckNotEmpty cannot be removed even if the result was ignored. See ThisNode::emitBytecode.
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate): CheckNotEmpty doesn't return any value.

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute): CheckNotEmpty doesn't load from heap so it's safe.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Speculative the operand to be not empty. OSR exit if the speculation fails.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Ditto.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile): CheckNotEmpty can be compiled in FTL.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode): Calls compileCheckNotEmpty for CheckNotEmpty.
(JSC::FTL::LowerDFGToLLVM::compileCheckNotEmpty): OSR exit with "TDZFailure" if the operand is not empty.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass): Added op_check_tdz.
(JSC::JIT::privateCompileSlowCases): Ditto.

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_check_tdz): Implements op_check_tdz in Baseline JIT.
(JSC::JIT::emitSlow_op_check_tdz): Ditto.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_check_tdz): Ditto.
(JSC::JIT::emitSlow_op_check_tdz): Ditto.

llint/LowLevelInterpreter32_64.asm: Implements op_check_tdz in LLint.
llint/LowLevelInterpreter64.asm: Ditto.
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Throws a reference error for op_check_tdz. Shared by LLint and Baseline JIT.

runtime/CommonSlowPaths.h:
tests/stress/class-syntax-no-loop-tdz.js: Added.
tests/stress/class-syntax-no-tdz-in-catch.js: Added.
tests/stress/class-syntax-no-tdz-in-conditional.js: Added.
tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js: Added.
tests/stress/class-syntax-no-tdz-in-loop.js: Added.
tests/stress/class-syntax-no-tdz.js: Added.
tests/stress/class-syntax-tdz-in-catch.js: Added.
tests/stress/class-syntax-tdz-in-conditional.js: Added.
tests/stress/class-syntax-tdz-in-loop.js: Added.
tests/stress/class-syntax-tdz.js: Added.

5:57 PM Changeset in webkit [181465] by rniwa@webkit.org

3 edits
2 adds in trunk

REGRESSION(r180726): Removing an empty line at the end of textarea clears the entire texture
https://bugs.webkit.org/show_bug.cgi?id=142646

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by TypingCommand::deleteKeyPressed erroneously determining the editable root to be empty because
Position::atStartOfTree returns true when it's anchored at a BR that is immediately below the root editable element.

Fixed the bug by replacing the use of the deprecated atFirstEditingPositionForNode by a code that understands modern
position types such as PositionIsBeforeAnchor in atStartOfTree and atEndOfTree. These two functions will no longer
return true when anchored before or after BR after this patch.

Test: editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html

dom/Position.cpp:

(WebCore::Position::atStartOfTree):
(WebCore::Position::atEndOfTree):

LayoutTests:

Added a regression test for deleting empty lines at the end of a textarea element.

editing/deleting/delete-empty-line-breaks-at-end-of-textarea-expected.txt: Added.
editing/deleting/delete-empty-line-breaks-at-end-of-textarea.html: Added.

5:55 PM Changeset in webkit [181464] by bshafiei@apple.com

1 copy in tags/Safari-600.1.4.15.15

New tag.

5:53 PM Changeset in webkit [181463] by bshafiei@apple.com

1 copy in tags/Safari-600.5.13

New tag.

5:40 PM Changeset in webkit [181462] by msaboff@apple.com

2 edits in trunk/Source/WTF

Disable Yarr JIT for ARMv7k
https://bugs.webkit.org/show_bug.cgi?id=142645

Reviewed by Oliver Hunt.

Make the setting of ENABLE_YARR_JIT match ENABLE_JIT for ARMv7k.

wtf/Platform.h:

5:20 PM Changeset in webkit [181461] by mark.lam@apple.com

2 edits in trunk/Source/WTF

Change WTF::ByteSpinLock to use std::atomic.
<https://webkit.org/b/142644>

Reviewed by Filip Pizlo.

wtf/ByteSpinLock.h:

(WTF::ByteSpinLock::ByteSpinLock):
(WTF::ByteSpinLock::lock):
(WTF::ByteSpinLock::unlock):
(WTF::ByteSpinLock::isHeld):

4:54 PM Changeset in webkit [181460] by Brent Fulgham

2 edits in trunk/Source/ThirdParty/ANGLE

[Win] Unreviewed build fix (part 2).

ANGLE.vcxproj/libGLESv2Common.props: Missed a directory separator.

4:47 PM Changeset in webkit [181459] by Brent Fulgham

2 edits in trunk/Source/ThirdParty/ANGLE

[Win] Unreviewed build fix for some DirectX SDK Installs

ANGLE.vcxproj/libGLESv2Common.props: Correct path for Lib and

Include paths based on problems others have had building WebKit
under different Windows and DirectX revisions.

3:57 PM Changeset in webkit [181458] by Yusuke Suzuki

23 edits
1 move
1 add in trunk

Integrate MapData into JSMap and JSSet
https://bugs.webkit.org/show_bug.cgi?id=142556

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch integrates MapData into JSMap and JSSet.
This removes 2 object allocation per one JSMap / JSSet.

MapDataImpl is specialized into MapData and SetData.
In the case of SetData, it does not have the dummy values
previously stored in the MapDataImpl. So the storage size of SetData
becomes the half of the previous implementation.

And now MapData and SetData are completely integrated into JSMap and JSSet,
these structures are not exposed to the other code even in WebCore world.

And at the same time, this patch fixes missing destroy functions
in JSMapIterator and JSSetIterator.
They are needed because MapData::const_iterator is a non-trivial destructor.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSMap.cpp:

(JSC::JSMap::destroy):
(JSC::JSMap::visitChildren):
(JSC::JSMap::copyBackingStore):
(JSC::JSMap::has):
(JSC::JSMap::size):
(JSC::JSMap::get):
(JSC::JSMap::set):
(JSC::JSMap::clear):
(JSC::JSMap::remove):
(JSC::JSMap::finishCreation): Deleted.

runtime/JSMap.h:

(JSC::JSMap::Entry::key):
(JSC::JSMap::Entry::value):
(JSC::JSMap::Entry::visitChildren):
(JSC::JSMap::Entry::setKey):
(JSC::JSMap::Entry::setKeyWithoutWriteBarrier):
(JSC::JSMap::Entry::setValue):
(JSC::JSMap::Entry::clear):
(JSC::JSMap::begin):
(JSC::JSMap::end):
(JSC::JSMap::JSMap):
(JSC::JSMap::mapData): Deleted.

runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::destroy):
(JSC::JSMapIterator::visitChildren):

runtime/JSMapIterator.h:

(JSC::JSMapIterator::JSMapIterator):

runtime/JSSet.cpp:

(JSC::JSSet::destroy):
(JSC::JSSet::visitChildren):
(JSC::JSSet::copyBackingStore):
(JSC::JSSet::has):
(JSC::JSSet::size):
(JSC::JSSet::add):
(JSC::JSSet::clear):
(JSC::JSSet::remove):
(JSC::JSSet::finishCreation): Deleted.

runtime/JSSet.h:

(JSC::JSSet::Entry::key):
(JSC::JSSet::Entry::value):
(JSC::JSSet::Entry::visitChildren):
(JSC::JSSet::Entry::setKey):
(JSC::JSSet::Entry::setKeyWithoutWriteBarrier):
(JSC::JSSet::Entry::setValue):
(JSC::JSSet::Entry::clear):
(JSC::JSSet::begin):
(JSC::JSSet::end):
(JSC::JSSet::JSSet):
(JSC::JSSet::mapData): Deleted.

runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::finishCreation):
(JSC::JSSetIterator::visitChildren):
(JSC::JSSetIterator::destroy):

runtime/JSSetIterator.h:

(JSC::JSSetIterator::JSSetIterator):

runtime/MapConstructor.cpp:

(JSC::constructMap):

runtime/MapData.h:

(JSC::MapDataImpl::const_iterator::key):
(JSC::MapDataImpl::const_iterator::value):
(JSC::MapDataImpl::size):
(JSC::MapDataImpl<Entry>::MapDataImpl):
(JSC::MapDataImpl<Entry>::clear):
(JSC::MapDataImpl<Entry>::KeyType::KeyType):
(JSC::MapDataImpl<Entry>::const_iterator::internalIncrement):
(JSC::MapDataImpl<Entry>::const_iterator::ensureSlot):
(JSC::MapDataImpl<Entry>::const_iterator::const_iterator):
(JSC::MapDataImpl<Entry>::const_iterator::~const_iterator):
(JSC::MapDataImpl<Entry>::const_iterator::operator):
(JSC::=):
(JSC::MapData::const_iterator::key): Deleted.
(JSC::MapData::const_iterator::value): Deleted.
(JSC::MapData::create): Deleted.
(JSC::MapData::createStructure): Deleted.
(JSC::MapData::size): Deleted.
(JSC::MapData::clear): Deleted.
(JSC::MapData::KeyType::KeyType): Deleted.
(JSC::MapData::const_iterator::internalIncrement): Deleted.
(JSC::MapData::const_iterator::ensureSlot): Deleted.
(JSC::MapData::const_iterator::const_iterator): Deleted.
(JSC::MapData::const_iterator::~const_iterator): Deleted.
(JSC::MapData::const_iterator::operator*): Deleted.
(JSC::MapData::const_iterator::end): Deleted.
(JSC::MapData::const_iterator::operator!=): Deleted.
(JSC::MapData::const_iterator::operator==): Deleted.

runtime/MapDataInlines.h: Renamed from Source/JavaScriptCore/runtime/MapData.cpp.

(JSC::MapDataImpl<Entry>::find):
(JSC::MapDataImpl<Entry>::contains):
(JSC::MapDataImpl<Entry>::add):
(JSC::MapDataImpl<Entry>::set):
(JSC::MapDataImpl<Entry>::get):
(JSC::MapDataImpl<Entry>::remove):
(JSC::MapDataImpl<Entry>::replaceAndPackBackingStore):
(JSC::MapDataImpl<Entry>::replaceBackingStore):
(JSC::MapDataImpl<Entry>::ensureSpaceForAppend):
(JSC::MapDataImpl<Entry>::visitChildren):
(JSC::MapDataImpl<Entry>::copyBackingStore):

runtime/MapPrototype.cpp:

(JSC::getMap):
(JSC::mapProtoFuncClear):
(JSC::mapProtoFuncDelete):
(JSC::mapProtoFuncForEach):
(JSC::mapProtoFuncGet):
(JSC::mapProtoFuncHas):
(JSC::mapProtoFuncSet):
(JSC::mapProtoFuncSize):
(JSC::getMapData): Deleted.

runtime/SetPrototype.cpp:

(JSC::getSet):
(JSC::setProtoFuncAdd):
(JSC::setProtoFuncClear):
(JSC::setProtoFuncDelete):
(JSC::setProtoFuncForEach):
(JSC::setProtoFuncHas):
(JSC::setProtoFuncSize):
(JSC::getMapData): Deleted.

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

Source/WebCore:

Now Set has SetData and it's different from MapData.
And MapData/SetData are completely integrated into JSSet and JSMap.
Structured-cloning algorithm need to be aware of these changes.
And in the case of JSSet, since JSSet doesn't need dummy value for construction,
Structured-cloning only serialize the keys in JSSet.

ForwardingHeaders/runtime/MapDataInlines.h: Added.
bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::consumeCollectionDataTerminationIfPossible):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::consumeMapDataTerminationIfPossible): Deleted.

LayoutTests:

Test structure-clone implementation that becomes aware of the difference between Map and Set.

fast/storage/serialized-script-value.html:

3:50 PM Changeset in webkit [181457] by ggaren@apple.com

2 edits in trunk/Source/bmalloc

Assertion failure in bmalloc::LargeObject::validateSelf on Mavericks Debug layout test bot
https://bugs.webkit.org/show_bug.cgi?id=142642

Reviewed by Michael Saboff.

The typical backtrace to this crash shows the main thread trying to
realloc a large string while a DFG compiler thread tries to
free a large vector buffer.

I believe that this is a race condition -- at least in debug builds --
since the main thread will try to validate its object's neighbors
without holding a lock, even though those neighbors might be in the
midst of changing.

In general, there may be sneaky times when it is valid to look at an
object's metadata without holding the heap lock, but it is best not to
do so unless we have a really really good reason to.

bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Take a lock before reading the metadata
for this object, since we generally require any access to shared heap
metadata to take a lock.

3:49 PM March 2015 Meeting edited by Simon Fraser

(diff)

3:14 PM Changeset in webkit [181456] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Use std::atomic for CodeBlock::m_visitAggregateHasBeenCalled.
<https://webkit.org/b/142640>

Reviewed by Mark Hahnenberg.

We used to spin our own compare and swap on a uint8_t. Now that we can
use C++11, let's use std::atomic instead.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

The CAS here needs std::memory_order_acquire ordering because it requires lock acquisition semantics to visit the CodeBlock.

bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::clearMarksForEdenCollection):

These can go with relaxed ordering because they are all done before the GC starts parallel marking.

3:04 PM FiveYearPlan edited by bfulgham@webkit.org

(diff)

2:54 PM FiveYearPlan edited by bfulgham@webkit.org

(diff)

2:33 PM FiveYearPlan edited by bfulgham@webkit.org

(diff)

2:27 PM FiveYearPlan edited by bfulgham@webkit.org

(diff)

2:15 PM FiveYearPlan created by bfulgham@webkit.org

2:04 PM WikiStart edited by bfulgham@webkit.org

(diff)

2:01 PM Changeset in webkit [181455] by mitz@apple.com

3 edits in trunk/Source/WebCore

Finish up <rdar://problem/20086546> [Cocoa] Add an option to treat certificate chains with SHA1-signed certificates as insecure

Added back OS X bits that I couldn’t land initially in r181317 or had to remove in r181327.

platform/network/mac/CertificateInfoMac.mm:

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate):

platform/spi/cocoa/SecuritySPI.h:

1:59 PM WebKitGTK/2.8.x edited by clopez@igalia.com

(diff)

1:49 PM Changeset in webkit [181454] by bshafiei@apple.com

2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r181448. rdar://problem/20130417

1:37 PM Changeset in webkit [181453] by ggaren@apple.com

3 edits in trunk/Source/WebCore

REGRESSION: Crash under Heap::reportExtraMemoryAllocatedSlowCase for media element
https://bugs.webkit.org/show_bug.cgi?id=142636

Reviewed by Mark Hahnenberg.

This was a pre-existing bug that I made a lot worse in
<https://trac.webkit.org/changeset/181411>.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Compare size before
subtracting rather than subtracting and then comparing to zero. The
latter technique is not valid for unsigned integers, which will happily
underflow into giant numbers.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::reportExtraMemoryAllocated): This code was

technically correct, but I took the opportunity to clean it up a bit.
There's no need to do two checks here, and it smells bad to check for
a negative unsigned integer.

1:32 PM Changeset in webkit [181452] by jonowells@apple.com

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger sidebar should group global breakpoints together
https://bugs.webkit.org/show_bug.cgi?id=142607

Reviewed by Timothy Hatcher.

Update the DebuggerSidebarPanel class to hold global breakpoints such as "All Exceptions" in one container. This
will be the place future such breakpoints are added.

Localizations/en.lproj/localizedStrings.js: Added string.
UserInterface/Main.html: Small rearrangement.

UserInterface/Views/DebuggerSidebarPanel.js: Change how exception breaking options are displayed.

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
(WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):

UserInterface/Views/FolderTreeElement.js: Support additional classes for icons.
UserInterface/Views/ResourceSidebarPanel.js: Change call to FolderTreeElement constructor.

1:24 PM Changeset in webkit [181451] by ap@apple.com

2 edits in trunk/Tools

[Mavericks] Test snapshots are 1600x1200 on Retina devices
https://bugs.webkit.org/show_bug.cgi?id=142630

Reviewed by Tim Horton.

WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):

Removed an ifdef that disabled the fix on Mavericks.

1:04 PM schedule.png attached to March 2015 Meeting by Simon Fraser

schedule

12:44 PM Changeset in webkit [181450] by Simon Fraser

2 edits in trunk/LayoutTests

These hidpi filter tests pass sometimes.

platform/mac/TestExpectations:

12:31 PM Changeset in webkit [181449] by commit-queue@webkit.org

8 edits in trunk/Source/WebCore

Stop using single-include headers that are only available since GStreamer >= 1.2.

https://bugs.webkit.org/show_bug.cgi?id=142537

Patch by Sebastian Dröge <sebastian@centricular.com> on 2015-03-12
Reviewed by Philippe Normand.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
platform/graphics/gstreamer/GStreamerUtilities.cpp:
platform/graphics/gstreamer/GStreamerUtilities.h:
platform/graphics/gstreamer/ImageGStreamer.h:

Instead of using single-include headers for the GStreamer libraries,
directly include the headers we need. The single-include headers were
only added in 1.2, and this would be the only reason why we would
depend on 1.2.

12:26 PM Changeset in webkit [181448] by enrica@apple.com

2 edits in trunk/Source/WebKit2

Adopt new API for keyboard event handling.
https://bugs.webkit.org/show_bug.cgi?id=142602
rdar://problem/19966087

Reviewed by Sam Weinig.

Adopts the new API.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didHandleKeyEvent:]):

12:13 PM Changeset in webkit [181447] by Csaba Osztrogonác

2 edits in trunk/Tools

Remove isWK2 cruft from webkitdirs.pm after r170426
https://bugs.webkit.org/show_bug.cgi?id=142618

Reviewed by Daniel Bates.

Scripts/webkitdirs.pm:

(isWK2): Deleted.

11:38 AM Changeset in webkit [181446] by ap@apple.com

14 edits in trunk

testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=138687

Source/WebKit2:

Reviewed by Carlos Garcia Campos.

UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Don't change system-wide
cookie accept policy when in testing mode. Also, update the policy in WebProcesses too,
as we still do some networking there.

UIProcess/WebProcessPool.h:
WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAlwaysAcceptCookies): Deleted.

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAlwaysAcceptCookies): Deleted.

WebProcess/InjectedBundle/InjectedBundle.h:

Remove WKBundleSetAlwaysAcceptCookies SPI, as WKTR now uses an API in UI process.

Tools:

Reviewed by Carlos Garcia Campos.

Always change cookie policy from UI process, as changing it from WebProcess doesn't
affect other processes.

The implementation is imperfect, because the change happens asynchronously, but I
don't expect it to be a problem in practice.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAlwaysAcceptCookies):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Unreviewed (only code changes were reviewed).

platform/gtk/TestExpectations:
platform/mac-wk2/TestExpectations:

Unskip tests that used to be affected.

11:19 AM March 2015 Meeting edited by Simon Fraser

(diff)

10:46 AM Changeset in webkit [181445] by andersca@apple.com

2 edits in trunk/Source/WebKit2

WKErrorDomain should be declared nonnull
https://bugs.webkit.org/show_bug.cgi?id=142628

Reviewed by Antti Koivisto.

Add WK_ASSUME_NONNULL_BEGIN and WK_ASSUME_NONNULL_END so everything will be implicitly nonnull.

UIProcess/API/Cocoa/WKError.h:

10:41 AM Changeset in webkit [181444] by bshafiei@apple.com

16 edits
2 copies in tags/Safari-601.1.22/Source

Merged r181442. rdar://problem/11903887

10:27 AM Changeset in webkit [181443] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

PDFs don't snapshot properly in iOS Safari
https://bugs.webkit.org/show_bug.cgi?id=142623

Patch by Ian Henderson <ian@ianhenderson.org> on 2015-03-12
Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
If we have a _customContentView, use UIView snapshotting instead of
trying to snapshot the web page.

10:18 AM Changeset in webkit [181442] by eric.carlson@apple.com

16 edits
2 adds in trunk/Source

[Mac] Update AirPlay handling
https://bugs.webkit.org/show_bug.cgi?id=142541

Source/WebCore:

Unreviewed, respond to post-review comments.

dom/Document.cpp:

(WebCore::Document::didChoosePlaybackTarget):

page/ChromeClient.h:
page/Page.cpp:

(WebCore::Page::showPlaybackTargetPicker):
(WebCore::Page::didChoosePlaybackTarget):
(WebCore::Page::configurePlaybackTargetMonitoring):

Source/WebKit2:

Unreviewed, respond to post-review comments and add previously reviewed changes
missed by a bungled merge.

Shared/mac/WebCoreArgumentCodersMac.mm:
UIProcess/WebMediaPlaybackTargetPickerProxy.cpp:

(WebKit::WebMediaPlaybackTargetPickerProxy::~WebMediaPlaybackTargetPickerProxy):

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPlaybackTargetPicker):

UIProcess/mac/WebMediaPlaybackTargetPickerProxyMac.h: Added.
UIProcess/mac/WebMediaPlaybackTargetPickerProxyMac.mm: Added.
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:
WebProcess/com.apple.WebProcess.sb.in:

10:02 AM Changeset in webkit [181441] by Simon Fraser

3 edits in trunk/LayoutTests

Clean up after JoePeck.

http/tests/security/contentSecurityPolicy/injected-inline-style-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt:

9:55 AM Changeset in webkit [181440] by Csaba Osztrogonác

2 edits in trunk/Tools

[EFL] Enable building EFL 1.13 with NEON support
https://bugs.webkit.org/show_bug.cgi?id=142619

Reviewed by Gyuyoung Kim.

efl/jhbuild.modules:

9:40 AM Changeset in webkit [181439] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

Fix the !ENABLE(PICTURE_SIZES) build
https://bugs.webkit.org/show_bug.cgi?id=142617

Reviewed by Darin Adler.

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):

9:10 AM Changeset in webkit [181438] by commit-queue@webkit.org

2 edits
5 adds in trunk/LayoutTests

Unreviewed EFL gardening on 13th Mar.
https://bugs.webkit.org/show_bug.cgi?id=142624

Rebaseline the missing test result.

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-03-12

platform/efl/TestExpectations:
platform/efl/editing/inserting/before-after-input-element-expected.png: Added.
platform/efl/editing/inserting/before-after-input-element-expected.txt: Added.
platform/efl/fast/css/css2-system-fonts-expected.txt: Added.
platform/efl/fast/text/tatechuyoko-expected.png: Added.
platform/efl/fast/text/tatechuyoko-expected.txt: Added.

9:10 AM Changeset in webkit [181437] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Console Errors during provisional document loads get lost with "Clear Log on Reload"
https://bugs.webkit.org/show_bug.cgi?id=142603

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-12
Reviewed by Timothy Hatcher.

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._messageAdded):
(WebInspector.LogContentView.prototype._provisionalLoadStarted):
Detect a provisional load has started to start save messages that come in at this time.

(WebInspector.LogContentView.prototype._sessionStarted):
Reappend provisional load messages if we auto-cleared.

(WebInspector.LogContentView.prototype._reappendProvisionalMessages):
(WebInspector.LogContentView.prototype._clearProvisionalState):
Helpers for dealing with the provisional loading state.

8:35 AM March 2015 Meeting edited by Simon Fraser