Timeline
Oct 12, 2018:
- 5:29 PM October 2018 Meeting edited by
- Added IntersectionObserver Notes (diff)
- 5:29 PM IntersectionObserverNotes created by
- Notes from 2018 WebKit Contributors Meeting
- 5:17 PM October 2018 Meeting edited by
- Added Redesigned Form Controls and Dark Mode CSS notes (diff)
- 5:17 PM RedesignedFormControlsAndDarkModeCSS created by
- Notes from 2018 WebKit Contributors Meeting
- 5:09 PM October 2018 Meeting edited by
- Added Fixing WebKit Development Annoyances notes (diff)
- 5:08 PM FixingWebKitDevelopmentAnnoyances created by
- Notes from 2018 WebKit Contributors Meeting
- 4:54 PM Changeset in webkit [237091] by
-
- 1 edit2 adds in trunk/Websites/webkit.org
Add a demo for WebInspector scanvas debugging.
- demos/canvas-debugging/index.html: Added.
- 4:52 PM Changeset in webkit [237090] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas: previews aren't removed when the parent view is hidden
https://bugs.webkit.org/show_bug.cgi?id=190525
Reviewed by Matt Baker.
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype.attached):
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype.get canvases):
(WI.CanvasManager.prototype.get shaderPrograms):
Drive-by: simplify these getters.
- 4:48 PM October 2018 Meeting edited by
- (diff)
- 4:46 PM October 2018 Meeting edited by
- Added Last 2 Years of Platform/Network/cURL notes (diff)
- 4:44 PM Last2YearsOfPlatformNetworkCurl created by
- Notes from 2018 WebKit Contributors Meeting
- 4:42 PM October 2018 Meeting edited by
- (diff)
- 4:39 PM WPTandWebKitTests edited by
- (diff)
- 4:31 PM October 2018 Meeting edited by
- Added WPT and WebKit Tests (diff)
- 4:30 PM WPTandWebKitTests created by
- Notes from 2018 WebKit Contributors Meeting
- 4:27 PM Changeset in webkit [237089] by
-
- 2 edits in trunk/Tools
[Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
https://bugs.webkit.org/show_bug.cgi?id=190537
Reviewed by Alexey Proskuryakov.
In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
needs to be split before adding it to the command since it is treated
as a list of args.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_javascriptcore_tests_command):
- 4:17 PM October 2018 Meeting edited by
- Added EWS Updates notes (diff)
- 4:16 PM Changeset in webkit [237088] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: Build fix after r237084.
https://bugs.webkit.org/show_bug.cgi?id=189708
Unreviewd.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 4:16 PM EWSUpdates2018 created by
- Notes from 2018 WebKit Contributors Meeting
- 4:14 PM October 2018 Meeting edited by
- Added notes for WebKitGTK+ and WPE WebKit in Five Minutes (diff)
- 4:14 PM WebKitGTKAndWPEWebKitInFiveMinutes created by
- Notes from 2018 WebKit Contributors Meeting
- 4:13 PM Changeset in webkit [237087] by
-
- 27 edits5 adds in trunk
[iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
https://bugs.webkit.org/show_bug.cgi?id=190504
<rdar://problem/45117760>
Reviewed by Tim Horton.
Source/WebCore:
Add support in ViewportConfiguration for applying a layout size scale factor to the viewport. See below for
more details.
Tests: fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setViewLayoutSize):
The viewport's layout size may now be changed alongside the layout size scale factor. If either of these two
variables change, we recompute our minimum layout size and viewport configuration parameters.
(WebCore::ViewportConfiguration::shouldIgnoreHorizontalScalingConstraints const):
(WebCore::ViewportConfiguration::nativeWebpageParameters):
(WebCore::ViewportConfiguration::testingParameters):
(WebCore::ViewportConfiguration::updateConfiguration):
Multiply the minimum scale, initial scale, and maximum scale by the layout size scale factor. This allows us to
keep the document well-proportioned within the viewport, while still laying out at a different layout size.
(WebCore::ViewportConfiguration::updateMinimumLayoutSize):
Compute the minimum layout size by scaling the default layout size derived from our view's size.
(WebCore::ViewportConfiguration::layoutWidth const):
(WebCore::ViewportConfiguration::layoutHeight const):
- page/ViewportConfiguration.h:
Maintain the original initial scale, unaffected by the layout size scale factor. This is used when computing
layout width and height to prevent scaling by the layout size scale factor twice when computing layout sizes.
(WebCore::ViewportConfiguration::description const):
Include the layout size scale factor in ViewportConfiguration's description string.
(WebCore::ViewportConfiguration::Parameters::operator== const):
(WebCore::operator<<):
Source/WebKit:
Add support for _setViewScale: and _viewScale on iOS. While similar in concept to macOS, changing this property
on iOS uses viewport configurations to change the minimum layout size of the document and apply view scaling.
Setting the view scale on iOS to a valuesmultiplies the minimium layout size by a factor1 / s, but also
multiplies the initial, minimum and maximum scales by a factor ofs. The net effect of applying this scale
causes the page to lay out at a larger width and shrink (or a smaller width and expand) to fit the viewport.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Send
viewportConfigurationLayoutSizeScaleFactoralongsideviewportConfigurationViewLayoutSize.
(-[WKWebView _dispatchSetViewLayoutSize:]):
(-[WKWebView _viewScale]):
(-[WKWebView _setViewScale:]):
Provide a different implementation of
_setViewScale:on iOS, by scaling the effective minimum layout size.
(See above for more detail).
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Add missing API availability annotations for the _viewScale property.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setViewScale:]):
- UIProcess/Cocoa/WebViewImpl.mm:
Both -[WKView _setViewScale:] and -[WKWebView _setViewScale:] throw Objective C exceptions upon receiving a bad
argument (e.g. scale <= 0). However, logic for throwing this exception is specific to iOS in WKWebView, and
handled in WebViewImpl on macOS. To make this less confusing, move the exception throwing code out of
!PLATFORM(MAC) in WKWebView, and move the path for raising this exception in WKView on macOS from WebViewImpl to
WKView.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::layoutSizeScaleFactor const):
Tie the notion of "view scale" on iOS to
layoutSizeScaleFactor. As its name suggests, this is a scale factor
by which we transform the layout size.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::setViewportConfigurationViewLayoutSize):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Plumb the layout size scale factor over to the web process, along with the layout size.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setViewportConfigurationViewLayoutSize):
Tools:
Teach UIScriptController to set WKWebView's view scale via a new
setViewScalemethod, supported in WebKit2 on
macOS and iOS.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::setViewScale):
- DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::setViewScale):
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setViewScale):
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
Add a new file for UIScriptController methods on Cocoa platforms.
(WTR::UIScriptController::setViewScale):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
Ensure that _viewScale is reset to 1 after running a layout test.
LayoutTests:
Add two new layout tests on iOS that change WKWebView's view scale, and measure the resulting window sizes and
lengths of viewport units.
- fast/viewport/ios/constant-width-viewport-after-changing-view-scale-expected.txt: Added.
- fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html: Added.
Add a test page with a viewport meta tag that has a constant width and an explicit initial scale of 0.5.
- fast/viewport/ios/device-width-viewport-after-changing-view-scale-expected.txt: Added.
- fast/viewport/ios/device-width-viewport-after-changing-view-scale.html: Added.
Add a test page with a viewport meta tag at device-width, with initial scale 1.
- resources/ui-helper.js:
(window.UIHelper.setViewScale):
Add a convenience function that wraps a UI script invocation of
setViewScalein a promise.
(window.UIHelper):
- 4:13 PM October 2018 Meeting edited by
- Added Igalia Contributions to WebKit (diff)
- 4:12 PM IgaliaContributionsToWebKit created by
- Notes from 2018 WebKit Contributors Meeting
- 4:10 PM Changeset in webkit [237086] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard: add a test for aggregating subtests without a matching metric in /api/report
https://bugs.webkit.org/show_bug.cgi?id=190544
Rubber-stamped by Keith Miller and unofficially reviewed by Dewei Zhu.
Added tests for reporting results to /api/report where a test with aggregated metrics has a subtest
without a matching metric type. The aggregation should simply skip such a subtest instead of returning
an error or aggregating with a mismatching metric type.
- server-tests/api-report-tests.js:
(.makeReport): Extracted out of a test case.
- 4:05 PM October 2018 Meeting edited by
- Added JavaScript RegExp Processing and JavaScriptCore Goals (diff)
- 4:03 PM JSCRegExpProcessingAndJSCGoals created by
- Notes from 2018 WebKit Contributors Meeting
- 3:59 PM Changeset in webkit [237085] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark
https://bugs.webkit.org/show_bug.cgi?id=190510
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-12
Reviewed by Devin Rousso.
- UserInterface/Views/ResourceHeadersContentView.css:
(.resource-headers.showing-find-banner .search-highlight):
Use adaptive text-color.
- 3:54 PM October 2018 Meeting edited by
- Added Web Inspector notes (diff)
- 3:52 PM WebInspectorNotes2018 created by
- Notes from 2018 WebKit Contributors Meeting
- 3:50 PM October 2018 Meeting edited by
- Added WebDriver Notes (diff)
- 3:47 PM WebDriverNotes2018 created by
- Notes from 2018 WebKit Contributors Meeting
- 3:39 PM Changeset in webkit [237084] by
-
- 7 edits2 adds in trunk/Source/JavaScriptCore
Separate configuration extraction from offset extraction
https://bugs.webkit.org/show_bug.cgi?id=189708
Reviewed by Keith Miller.
Instead of generating a file with all offsets for every combination of
configurations, we first generate a file with only the configuration
indices and pass that to the offset extractor. The offset extractor then
only generates the offsets for valid configurations
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- llint/LLIntOffsetsExtractor.cpp:
(JSC::LLIntOffsetsExtractor::dummy):
- llint/LLIntSettingsExtractor.cpp: Added.
(main):
- offlineasm/generate_offset_extractor.rb:
- offlineasm/generate_settings_extractor.rb: Added.
- offlineasm/offsets.rb:
- offlineasm/settings.rb:
- 3:38 PM October 2018 Meeting edited by
- Added WebKit Accessibility Performance notes (diff)
- 3:37 PM WebKitAccessibilityPerformance created by
- Notes from 2018 WebKit Contributors Meeting
- 3:28 PM October 2018 Meeting edited by
- Added Investigating Leaks and Bloat (diff)
- 3:28 PM InvestigatingLeaksAndBloat created by
- Notes from 2018 WebKit Contributors Meeting
- 3:24 PM October 2018 Meeting edited by
- Added WebKit Feature Focus 2018-2019 Notes (diff)
- 3:23 PM WebKitFeatureFocus2018-2019 created by
- Notes from the 2018 WebKit Contributors Meeting
- 3:16 PM October 2018 Meeting edited by
- (diff)
- 3:06 PM Changeset in webkit [237083] by
-
- 2 edits in trunk/Tools
[ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=190536
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
- 3:06 PM Changeset in webkit [237082] by
-
- 5 edits in trunk/Source/WebCore
Use downcast for use of RealtimeMediaSource in LibWebRTCMediaEndpoint
https://bugs.webkit.org/show_bug.cgi?id=190533
Reviewed by Chris Dumez.
Clean-up work.
No change of behavior.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::setExistingReceiverSourceTrack):
- platform/mediastream/RealtimeIncomingAudioSource.h:
(isType):
- platform/mediastream/RealtimeIncomingVideoSource.h:
(isType):
- platform/mediastream/RealtimeMediaSource.h:
- 2:43 PM Changeset in webkit [237081] by
-
- 2 edits in trunk/Source/WebCore
WebAVSampleBufferErrorListener's parent should be a WeakPtr.
https://bugs.webkit.org/show_bug.cgi?id=190524
<rdar://problem/44359307>
Reviewed by Eric Carlson.
Once WebAVSampleBufferErrorListener's parent is a WeakPtr, we no longer need to pass
protectedSelf into the callOnMainThread lambdas; we can pass in the parent itself.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener initWithParent:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(-[WebAVSampleBufferErrorListener layerFailedToDecode:]):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers):
- 2:42 PM Changeset in webkit [237080] by
-
- 15 edits in trunk/Source
Unreviewed, rolling out r237063.
Caused layout test fast/dom/Window/window-postmessage-clone-
deep-array.html to fail on macOS and iOS Debug bots.
Reverted changeset:
"[JSC] Remove gcc warnings on mips and armv7"
https://bugs.webkit.org/show_bug.cgi?id=188598
https://trac.webkit.org/changeset/237063
- 2:32 PM Changeset in webkit [237079] by
-
- 1 edit in trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt
Unreviewed.
Speculative build fix for GTK/WPE after r237075.
- 2:30 PM Changeset in webkit [237078] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: wrong color used for "goto arrow" for selected DOM breakpoint tree element
https://bugs.webkit.org/show_bug.cgi?id=190180
<rdar://problem/44927654>
Reviewed by Matt Baker.
- UserInterface/Views/Main.css:
(@media (prefers-dark-interface)):
(:focus .selected .go-to-arrow):
- 2:29 PM Changeset in webkit [237077] by
-
- 2 edits in trunk/Source/WebCore
Address the review comment which was meant to be addressed in r237025.
- editing/MarkupAccumulator.cpp:
(WebCore::elementCannotHaveEndTag):
- 2:04 PM Changeset in webkit [237076] by
-
- 1 edit1 delete in trunk/Source/ThirdParty/libwebrtc
Unreviewed build fix, remove executable file imported with r237075.
- Source/webrtc/data/voice_engine/stereo_rtp_files/rtpplay.exe: Removed.
- 1:53 PM October 2018 Meeting edited by
- Moved "How Text Works" into main schedule (diff)
- 1:45 PM Changeset in webkit [237075] by
-
- 1279 edits64 copies164 moves313 adds92 deletes in trunk/Source
Refresh libwebrtc up to 343f4144be
https://bugs.webkit.org/show_bug.cgi?id=190361
Reviewed by Chris Dumez.
This refresh should not change behavior but will allow us to implement better
mdns candidate support and simulcast activation surfacing through addTransceiver.
Covered by existing tests.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp: (WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
- testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnection::CreateAnswer):
- testing/MockLibWebRTCPeerConnection.h: (WebCore::MockRtpSender::GetParameters): Deleted. (WebCore::MockRtpSender::SetParameters): Deleted. (WebCore::MockRtpSender::GetDtmfSender const): Deleted.
ThirdParty/libwebrtc
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Configurations/libwebrtc.xcconfig:
- Source/webrtc: Resynced.
- WebKit/0001-Updating-webrtc.patch: Removed.
- libwebrtc.xcodeproj/project.pbxproj:
- 1:20 PM Changeset in webkit [237074] by
-
- 23 edits in trunk/Source
Allow encoding of small enum classes
https://bugs.webkit.org/show_bug.cgi?id=190531
Reviewed by Tim Horton.
Source/WebCore:
- Modules/webauthn/PublicKeyCredentialCreationOptions.h:
- dom/Document.h:
- editing/FontAttributeChanges.h:
- history/CachedFrame.h:
- loader/FrameLoaderTypes.h:
- platform/CookiesStrategy.h:
- platform/PasteboardItemInfo.h:
- platform/ReferrerPolicy.h:
Source/WebKit:
- NetworkProcess/NetworkLoadClient.h:
- Scripts/webkit/messages.py:
- Scripts/webkit/parser.py:
(parse_parameters_string):
- UIProcess/API/APINavigation.h:
- UIProcess/WebFramePolicyListenerProxy.h:
- UIProcess/WebNavigationState.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.messages.in:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(-[WebFramePolicyListener dealloc]):
Source/WTF:
- wtf/Forward.h:
- 12:58 PM October 2018 Meeting edited by
- Added IntersectionObserver talk (diff)
- 12:51 PM October 2018 Meeting edited by
- (diff)
- 12:47 PM October 2018 Meeting edited by
- (diff)
- 12:43 PM October 2018 Meeting edited by
- Changed order of Igalia and Web Inspector talks (diff)
- 12:20 PM Changeset in webkit [237073] by
-
- 15 edits in trunk/Source
Solve the confusion around blankURL() and isBlankURL() in URL
https://bugs.webkit.org/show_bug.cgi?id=158988
Patch by Rob Buis <rbuis@igalia.com> on 2018-10-12
Reviewed by Alex Christensen.
Source/WebCore:
The name isBlankURL is not accurate as the function tests the
protocol, not the full URL. Choose protocolIsAbout to align with
exisiting protocolIsData, protocolIsBlob etc.
No tests as no change in functionality.
- WebCore.order:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::loadApplicationManifest):
(WebCore::DocumentLoader::startIconLoading):
- loader/NavigationAction.cpp:
(WebCore::shouldTreatAsSameOriginNavigation):
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::SerializerMarkupAccumulator::appendCustomAttributes):
(WebCore::PageSerializer::serializeFrame):
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFrame const):
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForObjectSource const):
- platform/URL.cpp:
(WebCore::URL::protocolIsAbout const):
(WebCore::URL::isBlankURL const): Deleted.
- platform/URL.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
Source/WebKit:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueWillSendRequest):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setLastSeen):
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom):
- 11:03 AM Changeset in webkit [237072] by
-
- 2 edits in trunk/LayoutTests
[Mojave Wk2] Layout Test http/tests/cache/disk-cache/disk-cache-validation-attachment.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190323
Unreviewed, mark test as Flaky.
Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-12
- platform/mac-wk2/TestExpectations:
- 10:57 AM Changeset in webkit [237071] by
-
- 5 edits in trunk/Source/WebKit
Cache API tests are flaky due to file writing failing from time to time
https://bugs.webkit.org/show_bug.cgi?id=190321
Reviewed by Chris Dumez.
Make NetworkCache::Storage::store callback return an error in case of writing failure.
Use this to surface this error at Cache API level.
Minor clean-up to make Storage::clear take a completion handler.
Make also sure to create the folder before writing the file in CacheStorageEngine.
As can be seen from some logging, it does happen that writing the 'origin' file sometimes fail with Posix error 9,
which might mean the folder is not present.
Changes are covered by current tests, flaky tests like http/wpt/cache-storage/cache-put-keys.https.any.worker.html
will show a "failed writing data to the file system" error message.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::writeFile):
- NetworkProcess/cache/CacheStorageEngine.h:
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::storeOrigin):
(WebKit::CacheStorage::Caches::writeCachesToDisk):
(WebKit::CacheStorage::Caches::writeRecord):
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::WriteOperation::WriteOperation):
(WebKit::NetworkCache::Storage::dispatchWriteOperation):
(WebKit::NetworkCache::Storage::finishWriteOperation):
(WebKit::NetworkCache::Storage::store):
(WebKit::NetworkCache::Storage::clear):
- NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::store):
- 10:14 AM Changeset in webkit [237070] by
-
- 2 edits in trunk/Source/WebCore
DOMCache should dereference itself as soon as stopped
https://bugs.webkit.org/show_bug.cgi?id=190441
Reviewed by Chris Dumez.
Dereference the DOMCache as soon as its context is stopped instead of waiting for garbage collection.
This allows freeing resources sooner in the network process.
No observable change of behavior since the DOMCache becomes no-op when its context is stopped.
- Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::~DOMCache):
(WebCore::DOMCache::stop):
- 9:57 AM Changeset in webkit [237069] by
-
- 2 edits in trunk/Source/WTF
Add PLATFORM(IOS_FAMILY) and OS(IOS_FAMILY)
https://bugs.webkit.org/show_bug.cgi?id=190477
Reviewed by Tim Horton.
Currently, PLATFORM(IOS) and OS(IOS) are true when building for any
TARGET_OS_IPHONE target, which is quite confusing. Add a better named alternative,
as a first step towards mass replacing PLATFORM(IOS). Can't so it all at once
because of dependencies in other source repositories.
- wtf/Platform.h: Changed to the new name in this file though. Kept a few
instances that actually target iOS only, having a version check.
- 9:24 AM October 2018 Meeting edited by
- (diff)
- 9:07 AM Changeset in webkit [237068] by
-
- 2 edits in trunk/LayoutTests
Layout Test editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190520
Unreviewed test gardening.
- platform/win/TestExpectations:
- 8:28 AM Changeset in webkit [237067] by
-
- 3 edits in trunk/Source/WebCore
CRASH in WebCore::MediaPlayerPrivateAVFoundation::setPreload
https://bugs.webkit.org/show_bug.cgi?id=190485
<rdar://problem/34613350>
Reviewed by Eric Carlson.
Crash analytics show that a pure-virtual function is called by MediaPlayerPrivateAVFoundation::setPreload(), and
the likely cause of that pure-virtual function call is that the MediaPlayerPrivateAVFoundation object itself has
been destroyed, likely as a side effect of calling MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL().
The usual suspect for this kind of crash is due to calling into JS (e.g., from a callback passed up to
HTMLMediaElement). Code inspection hasn't yielded any good hints about why this might be occurring, so we will
add a ScriptDisallowedScope assertion inside HTMLMediaElement::prepareToPlay(), to generate a good crashlog
showing exactly what callback is resulting in a JS call. But just in case the deallocation is not due to JS,
also add an explicit strong-ref inside MediaPlayer::prepareToPlay.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareToPlay):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::prepareToPlay):
- 8:28 AM Changeset in webkit [237066] by
-
- 2 edits in trunk/Source/WebCore
Null-dereference in SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged
https://bugs.webkit.org/show_bug.cgi?id=190490
<rdar://problem/42213807>
Reviewed by Eric Carlson.
Crash analytics show a null dereference occurring, likely because m_mediaSource is null.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
- 6:19 AM October 2018 Meeting edited by
- Cannot attend the meeting. (diff)
