Timeline
Feb 18, 2013:
- 11:57 PM Changeset in webkit [143303] by
-
- 9 edits2 adds in trunk
Make EventDispatcher take an Event object in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=109898
Reviewed by Dimitri Glazkov.
Source/WebCore:
Re-landing r143145, which caused a crash when deltaX and deltaY of a PlatformWheelEvent are both zero.
Fixed a crash by early exiting in EventDispatcher::dispatchEvent(Node*, PassRefPtr<EventDispatcher*>)
if mediator's event() returns null.
Also Added a layout test to catch this kind of crash in the future.
Test: fast/events/platform-wheelevent-with-delta-zero-crash.html
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::dispatchEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- dom/WheelEvent.cpp:
(WebCore::WheelEventDispatchMediator::dispatchEvent):
Assert event() rather than an early exit since this code path should be hit only when event() is non-null.
LayoutTests:
- fast/events/platform-wheelevent-with-delta-zero-crash-expected.txt: Added.
- fast/events/platform-wheelevent-with-delta-zero-crash.html: Added.
- 11:48 PM Changeset in webkit [143302] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] Remove webkit_web_view_get_subresources from WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=110125
Reviewed by Anders Carlsson.
This API is currently implemented caching all resources in the
WebView which causes some problems in documents loading resources
indefinitely. This API was used in WebKit1 mainly to implement
webkit_web_view_save(), but we already have such API in
WebKit2.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate):
(webkitWebViewLoadChanged):
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResources):
(testWebResourceGetData):
- 11:39 PM Changeset in webkit [143301] by
-
- 2 edits in trunk/LayoutTests
Add a flaky failing test expectation to inspector/editor/brace-matcher.html on Mac per bug 110186.
- platform/mac/TestExpectations:
- 11:31 PM Changeset in webkit [143300] by
-
- 5 edits2 adds in trunk
:before/:after pseudo elements do not always apply to the proper element
https://bugs.webkit.org/show_bug.cgi?id=93925
Reviewed by Dimitri Glazkov.
Source/WebCore:
Disable sharing a style with siblings if :after or :before pseudo style
is unique.
Test: fast/css/before-after-pseudo-class.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
Added a new condition, hasUniquePseudoStyle.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::hasUniquePseudoStyle):
Added to check whether any pseudo style has unique bit or not.
(WebCore):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/css/before-after-pseudo-class-expected.html: Added.
- fast/css/before-after-pseudo-class.html: Added.
- 11:22 PM Changeset in webkit [143299] by
-
- 5 edits2 adds in trunk
Focusing a new frame (via window.focus()) should blur the active element in the current frame
https://bugs.webkit.org/show_bug.cgi?id=110172
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a change in the focused node crosses a frame boundary, WebKit
doesn't always succeed in blurring the old focused node before focusing
the new one.
Each document remembers its focused node, and a Page-scoped
FocusController remembers the focused frame. If a new focused node is
in a different frame than the focused frame, FocusController tells the
old frame's document to clear its focused node before focusing the new
one (and remembering the new frame).
Unfortunately, web content can confuse FocusController by calling
window.focus() at the wrong time. Since window.focus() changes
FocusController's focused frame without focusing a new node,
FocusController won't think that a frame boundary is being crossed if a
node in this frame is later focused. Therefore it won't clear the old
frame's focused node (it won't even know which frame contained the old
focused node), causing at least two bugs:
1) The node in the old frame will not receive a blur event.
2) Calling document.activeElement on the main frame will return the
previously focused node, but the HTML5 spec says it should return
the frame owner element if a subframe has focus.
Fix both of these bugs by explicitly clearing the current frame's
focused node if window.focus() changes the focused frame. This fix
carries some compatibility risk by changing a long-standing behavior
of the engine (we've had this bug since the beginning of the project,
AFAICT). On the upside, it matches the behavior of both Firefox and IE,
matches what HTML5 says about subframe focus, and fixes at least one
well-known enterprise web app.
Tests: fast/dom/HTMLDocument/active-element-frames.html
fast/frames/frame-focus-blurs-active-element.html
- page/DOMWindow.cpp:
(WebCore::DOMWindow::focus): If the frame being focused is not the same
as the currently focused frame, clear the currently focused frame's
focused node.
LayoutTests:
- fast/dom/HTMLDocument/active-element-frames-expected.txt:
- fast/dom/HTMLDocument/active-element-frames.html: Modified to run the
test a second time, focusing each element's frame before focusing the
element itself.
- fast/frames/frame-focus-blurs-active-element-expected.txt: Added.
- fast/frames/frame-focus-blurs-active-element.html: Added a test that
verifies a blur event is fired on the active element when a new frame
is focused.
- 11:18 PM Changeset in webkit [143298] by
-
- 2 edits in trunk/Tools
Unreviewed. Adjust expectations.
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
(TestWebKitAPI::TEST):
- 10:57 PM Changeset in webkit [143297] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][EFL] Stop using internal C++ API in ewk_error
https://bugs.webkit.org/show_bug.cgi?id=108796
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-18
Reviewed by Benjamin Poulain.
Stop using internal C++ API in ewk_error and use C API instead of avoid
violating API layering.
- UIProcess/API/efl/ewk_error.cpp:
(EwkError::domain):
(EwkError::isCancellation):
(ewk_error_type_get):
- UIProcess/API/efl/ewk_error_private.h:
(EwkError):
- 10:39 PM Changeset in webkit [143296] by
-
- 2 edits in trunk/LayoutTests
[EFL][WebGL] Enable test webgl/conformance/canvas/texture-bindings-unaffected-on-resize.html.
https://bugs.webkit.org/show_bug.cgi?id=110176
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-18
Reviewed by Laszlo Gombos.
Enable the test for EFL port, as it passes after r143220.
- platform/efl-wk2/TestExpectations:
- 10:35 PM Changeset in webkit [143295] by
-
- 30 edits in trunk/Source
Clean up the boolean argument to visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=110167
Source/WebCore:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
No behavior change.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::viewportSize):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::innerHeight):
(WebCore::DOMWindow::innerWidth):
- page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::windowClipRect):
- page/SpatialNavigation.cpp:
(WebCore::canScrollInDirection):
- platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::visibleContentRect):
(WebCore::ScrollView::layoutSize):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::paint):
- platform/ScrollView.h:
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::visibleContentRect):
- platform/ScrollableArea.h:
- rendering/RenderDialog.cpp:
(WebCore::RenderDialog::layout):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::visibleContentRect):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidChangeSize):
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
Source/WebKit/blackberry:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::getRecursiveVisibleWindowRect):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
Source/WebKit/chromium:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::popupOpened):
Source/WebKit/efl:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- ewk/ewk_frame.cpp:
(ewk_frame_visible_content_geometry_get):
Source/WebKit/win:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- WebFrame.cpp:
(WebFrame::visibleContentRect):
(WebFrame::frameBounds):
Source/WebKit2:
Reviewed by Simon Fraser.
Replace the boolean argument to visibleContentRect() with
an enum.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
- 10:27 PM Changeset in webkit [143294] by
-
- 2 edits in trunk/Source/WebCore
That didn't work either. Just make it public. This is why I hate nested classes. They just don't work.
- rendering/RenderBlock.h:
(RenderBlock):
- 10:12 PM Changeset in webkit [143293] by
-
- 3 edits in trunk/Source/WebCore
Windows build fix. Apparently Visual Studio still has a lot of bugs with respect to nested classes.
Work around it by directly instantiating the class inside createFloatingObjects.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createFloatingObjects): Directly instantiate FloatingObjects.
- rendering/RenderBlock.h:
(RenderBlock): Moved the declaration of createFloatingObjects up.
(FloatingObjects::FloatingObjects):
- 9:51 PM Changeset in webkit [143292] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for Apple Windows. Second stage.
Add missed export statement.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 7:52 PM Changeset in webkit [143291] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash expectation to video-controls-captions-trackmenu.html on Mac per bug 110173.
- platform/mac/TestExpectations:
- 7:42 PM Changeset in webkit [143290] by
-
- 3 edits in trunk/Source/WebCore
Merge handleSpecialChild into layoutBlockChildren
https://bugs.webkit.org/show_bug.cgi?id=110165
Reviewed by Darin Adler.
Merge handleSpecialChild, handlePositionedChild, and handleFloatingChild into layoutBlockChildren
to make the semantics of the code clear and to get rid of the outdated comment about how there are
four types of four types of special children.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChildren):
- rendering/RenderBlock.h:
(RenderBlock):
- 7:38 PM Changeset in webkit [143289] by
-
- 3 edits in trunk/Source/WebCore
Encapsulate FloatingObject's constructor inside create
https://bugs.webkit.org/show_bug.cgi?id=110169
Reviewed by Darin Adler.
Added FloatingObject::create and made FloatingObject's constructor private.
Also added RenderBlock::ensureFloatingObjects to help lazily creating FloatingObjects.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::ensureFloatingObjects):
(WebCore::RenderBlock::FloatingObjects::create):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
- rendering/RenderBlock.h:
(FloatingObjects):
(RenderBlock):
- 7:20 PM Changeset in webkit [143288] by
-
- 2 edits in trunk/LayoutTests
Remove a stale Mac test expectation.
- platform/mac/TestExpectations:
- 6:55 PM Changeset in webkit [143287] by
-
- 16 edits in trunk/Source
Add a DefaultHash for RefPtr<SecurityOrigin>
https://bugs.webkit.org/show_bug.cgi?id=110170
Reviewed by Andreas Kling.
Remove all explicit uses of SecurityOriginHash.
Source/WebCore:
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/OriginQuotaManager.h:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::getOriginsWithCache):
- loader/cache/MemoryCache.h:
- page/SecurityOriginHash.h:
- storage/StorageNamespaceImpl.h:
(StorageNamespaceImpl):
Source/WebKit/mac:
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache originsWithCache]):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::SessionStorageNamespace):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
- WebProcess/Notifications/NotificationPermissionRequestManager.h:
Include SecurityOriginHash.h. This fixes a bug where m_originToIDMap used pointer-equality
for looking up security origins.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
This can just take a const reference.
- WebProcess/ResourceCache/WebResourceCacheManager.h:
- 6:34 PM Changeset in webkit [143286] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:02 PM Changeset in webkit [143285] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/Modules/mediastream
Merge 142887
BUG=176033
Review URL: https://codereview.chromium.org/12297021
- 6:01 PM Changeset in webkit [143284] by
-
- 5 edits2 adds in trunk
Padding and border changes don't trigger the relayout of children in some cases.
https://bugs.webkit.org/show_bug.cgi?id=109639.
Reviewed by Ryosuke Niwa.
Source/WebCore:
The fix for this bug was way too general and involved putting code into RenderBox. Since
RenderBox makes no assumptions about what kind of layout system might derive from it, it
was incorrect to just mark all children as needing layout whenever borders and padding
changed widths.
This patch takes the two cases handled by the original code and makes them more
specialized down in subclasses, i.e., RenderBlock and RenderTableRow. RenderBlock has
been refined to only check if children aren't inline and to also not invalidate
floats or irrelevant positioned objects that might not even have this block as their
containing block.
The RenderTableRow code is specialized to only care about collapsing borders and
to only check borders rather than padding. It also requires that a child be a cell
in order to do the invalidation.
Covered by existing tests, since this is just specializing the code to more precisely
cover the test cases that have already been written.
Longer term, it should be layout code that figures this stuff out rather than style
change code, but that involves more dramatic changes that can wait.
Test: fast/block/positioning/border-change-relayout-test.html
- rendering/RenderBlock.cpp:
(WebCore::borderOrPaddingLogicalWidthChanged):
(WebCore):
(WebCore::RenderBlock::styleDidChange):
- rendering/RenderBox.cpp:
(WebCore):
(WebCore::RenderBox::styleDidChange):
- rendering/RenderTableRow.cpp:
(WebCore::borderLogicalWidthChanged):
(WebCore):
(WebCore::RenderTableRow::styleDidChange):
LayoutTests:
- fast/block/positioning/border-change-relayout-test-expected.html: Added.
- fast/block/positioning/border-change-relayout-test.html: Added.
- 5:56 PM Changeset in webkit [143283] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unneeded explicit function template arguments.
https://bugs.webkit.org/show_bug.cgi?id=110043
Reviewed by Ryosuke Niwa.
- runtime/Identifier.cpp:
(JSC::IdentifierASCIIStringTranslator::hash): Let the compiler deduce the type
when calling computeHashAndMaskTop8Bits.
(JSC::IdentifierLCharFromUCharTranslator::hash): Ditto.
- runtime/Identifier.h:
(JSC::IdentifierCharBufferTranslator::hash): Ditto.
- 5:55 PM Changeset in webkit [143282] by
-
- 3 edits in trunk/Source/WebCore
Small follow up to r143271: Fix SQLTransaction leak.
https://bugs.webkit.org/show_bug.cgi?id=110052.
Reviewed by Geoffrey Garen.
Applied Geoff's suggestion nullify m_frontend sooner for greater
code clarity. Also added some comments about m_frontend.
No new tests.
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- 5:51 PM Changeset in webkit [143281] by
-
- 4 edits2 copies in branches/chromium/1410
Merge 143060
BUG=170184
Review URL: https://codereview.chromium.org/12301012
- 5:45 PM Changeset in webkit [143280] by
-
- 2 edits in trunk/Source/WTF
Style tweaks to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=110042
Reviewed by Alexey Proskuryakov.
I have a bug fix coming soon, but figured I'd separate out style tweaks and land them
first to make that patch easier to undrestand.
- wtf/StringHasher.h: Tweak and rearrange comments a bit.
(WTF::StringHasher::addCharacter): Use character instead of ch.
(WTF::StringHasher::addCharacters): Use remainder instead of rem. Also capitalize the U
that we use to make an unsigned 1 constant.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Ditto.
(WTF::StringHasher::hashMemory): Change version that takes size as a template argument
to call the version that takes the size at runtime, since both generate the same code
anyway. Added a FIXME questioning why this function uses the "mask top 8 bits" version
of the hash. Fix incorrect compile assertion that required sizes that are multiples
of four. This function works on sizes that are multiples of two. Also fixed a spelling
error where we called it a "multible".
(WTF::StringHasher::defaultConverter): Use character instead of ch.
(WTF::StringHasher::addCharactersToHash): Eliminated unnecessary local variable.
- 5:39 PM Changeset in webkit [143279] by
-
- 17 edits3 adds in trunk
Shrank the SourceProvider cache
https://bugs.webkit.org/show_bug.cgi?id=110158
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
CodeCache is now our primary source cache, so a long-lived SourceProvider
cache is a waste. I measured this as a 10MB Membuster win; with more
precise instrumentation, Andreas estimated it as up to 30MB.
I didn't eliminate the SourceProvider cache because it's still useful
in speeding up uncached parsing of scripts with large nested functions
(i.e., all scripts).
- heap/Heap.cpp:
(JSC::Heap::collect): Discard all source provider caches after GC. This
is a convenient place to do so because it's reasonably soon after initial
parsing without being immediate.
- parser/Parser.cpp:
(JSC::::Parser): Updated for interface change: The heap now owns the
source provider cache, since most SourceProviders are not expected to
have one by default, and the heap is responsible for throwing them away.
(JSC::::parseInner): No need to update statistics on cache size, since
we're going to throw it away no matter what.
(JSC::::parseFunctionInfo): Reduced the minimum function size to 16. This
is a 27% win on a new parsing micro-benchmark I've added. Now that the
cache is temporary, we don't have to worry so much about its memory
footprint.
- parser/Parser.h:
(Parser): Updated for interface changes.
- parser/SourceProvider.cpp:
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):
- parser/SourceProvider.h:
(JSC):
(SourceProvider): SourceProvider doesn't own its cache anymore because
the cache is temporary.
- parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
(JSC::SourceProviderCache::SourceProviderCache):
(SourceProviderCache):
- parser/SourceProviderCacheItem.h:
(SourceProviderCacheItem): No need to update statistics on cache size,
since we're going to throw it away no matter what.
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::addSourceProviderCache):
(JSC):
(JSC::JSGlobalData::clearSourceProviderCaches):
- runtime/JSGlobalData.h:
(JSC):
(JSGlobalData): Moved the cache here so it's easier to throw away.
Source/WebCore:
Test: fast/js/regress/nested-function-parsing.html
No need to keep statistics on cache size, since we're going to throw it
away no matter what.
- WebCore.order:
- bindings/js/CachedScriptSourceProvider.h:
(CachedScriptSourceProvider):
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::destroyDecodedData):
(WebCore):
(WebCore::CachedScript::reportMemoryUsage):
- loader/cache/CachedScript.h:
(CachedScript):
LayoutTests:
New benchmark to show that a minimum size of 16 is better than 64.
- fast/js/regress/nested-function-parsing-expected.txt: Added.
- fast/js/regress/nested-function-parsing.html: Added.
- fast/js/regress/script-tests/nested-function-parsing.js: Added.
- 5:29 PM Changeset in webkit [143278] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed VS2010 build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Sync
export definition with VS2005 version.
- 5:22 PM Changeset in webkit [143277] by
-
- 3 edits in trunk/Source/WebKit2
Begin stubbing out session storage classes
https://bugs.webkit.org/show_bug.cgi?id=110168
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::StorageArea::~StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::isEmpty):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::~SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- 5:15 PM Changeset in webkit [143276] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG backend Branch handling has duplicate code and dead code
https://bugs.webkit.org/show_bug.cgi?id=110162
Reviewed by Mark Hahnenberg.
Streamline the code, and make the 64 backend's optimizations make more sense
(i.e. not be dead code).
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- 4:40 PM Changeset in webkit [143275] by
-
- 16 edits2 moves10 adds in trunk/Source/WebKit2
[EFL][WK2] Add C API for popup menu and popup item
https://bugs.webkit.org/show_bug.cgi?id=109083
Reviewed by Anders Carlsson.
WK2 EFL delegates display of the popup menu to the browser which causes
us to have a strong interdependency between internal C++ classes
(WebPopupMenuProxyEfl, WebPopupItem) and our EFL API implementation
(EwkView, EwkPopupMenu, EwkPopupMenuItem).
Since we want to remove this interdependency, this patch introduces a
for WebPopupMenuProxyEfl (WKPopupMenuListener) and for WebPopupItem
(WKPopupItem). It also introduces a WKPage client with callbacks for
showPopupMenu and hidePopupMenu.
Note that the popup menu functionality is covered by ewk_popup_menu API
tests and no functionality is lost.
- PlatformEfl.cmake: Add new files to EFL CMake config.
- Shared/API/c/efl/WKBaseEfl.h: Add typedefs for WKPopupItemRef and
WKPopupMenuListenerRef.
- Shared/APIObject.h: Add new TypePopupMenuItem APIObject type for EFL
platform.
- UIProcess/API/C/efl/WKAPICastEfl.h: Add mapping for WKPopupItemRef
and WKPopupMenuListenerRef API types.
(WebKit):
(WebKit::toAPI):
- UIProcess/API/C/efl/WKPageEfl.cpp: Added.
(WKPageSetUIPopupMenuClient): Add new C API to set the UI Popup Menu
client on the page.
- UIProcess/API/C/efl/WKPageEfl.h: Added.
- UIProcess/API/C/efl/WKPopupItem.cpp: Added. Add C API for WebPopupItem.
(WKPopupItemGetType):
(WKPopupItemGetTextDirection):
(WKPopupItemHasTextDirectionOverride):
(WKPopupItemCopyText):
(WKPopupItemCopyToolTipText):
(WKPopupItemCopyAccessibilityText):
(WKPopupItemIsEnabled):
(WKPopupItemIsLabel):
(WKPopupItemIsSelected):
- UIProcess/API/C/efl/WKPopupItem.h: Added.
- UIProcess/API/C/efl/WKPopupMenuListener.cpp: Added. Add C API for
WebPopupMenuListenerEfl (formerly WebPopupMenuProxyEfl) so that the
client can report which popup menu item was selected.
(WKPopupMenuListenerSetSelection):
- UIProcess/API/C/efl/WKPopupMenuListener.h: Added.
- UIProcess/API/efl/EwkView.cpp: Remove dependency on internal C++ types
(WebPopupMenuProxyEfl and WebPopupItem) and use C API types instead.
(EwkView::requestPopupMenu):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
- UIProcess/API/efl/ewk_popup_menu.cpp: Use C API for Popup menu.
(EwkPopupMenu::EwkPopupMenu):
(EwkPopupMenu::setSelectedIndex):
- UIProcess/API/efl/ewk_popup_menu_private.h:
(EwkPopupMenu::create):
(EwkPopupMenu):
- UIProcess/WebPageProxy.cpp: Use WKPageUIPopupMenuClient to show / hide
the popup menu on EFL port instead of asking the WebPopupMenuProxy.
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
- UIProcess/WebPageProxy.h: Add new WKPageUIPopupMenuClient member and
corresponding initialization method.
(WebPageProxy):
- UIProcess/WebPopupMenuProxy.h: Disable showPopupMenu / hidePopupMenu
virtual methods on EFL port since we go via WKPageUIPopupMenuClient
for this now.
(WebPopupMenuProxy):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl): Handle WKPageUIPopupMenuClient
callbacks and call corresponding EwkView methods. Previously, the EwkView
methods were called by the internal WebPageProxyEfl class which is no
longer needed.
(WebKit::PageUIClientEfl::showPopupMenu):
(WebKit):
(WebKit::PageUIClientEfl::hidePopupMenu):
- UIProcess/efl/PageUIClientEfl.h:
(PageUIClientEfl):
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::initializeUIPopupMenuClient):
(WebKit):
- UIProcess/efl/WebPopupItemEfl.cpp: Added. Add APIObject wrapper for
WebPopupItem so that we can use it in WKPageUIPopupMenuClient.
(WebKit):
(WebKit::WebPopupItemEfl::WebPopupItemEfl):
(WebKit::WebPopupItemEfl::~WebPopupItemEfl):
- UIProcess/efl/WebPopupItemEfl.h: Added.
(WebKit):
(WebPopupItemEfl):
(WebKit::WebPopupItemEfl::create):
(WebKit::WebPopupItemEfl::data):
(WebKit::WebPopupItemEfl::itemType):
(WebKit::WebPopupItemEfl::text):
(WebKit::WebPopupItemEfl::textDirection):
(WebKit::WebPopupItemEfl::hasTextDirectionOverride):
(WebKit::WebPopupItemEfl::toolTipText):
(WebKit::WebPopupItemEfl::accessibilityText):
(WebKit::WebPopupItemEfl::isEnabled):
(WebKit::WebPopupItemEfl::isLabel):
(WebKit::WebPopupItemEfl::isSelected):
(WebKit::WebPopupItemEfl::type):
- UIProcess/efl/WebPopupMenuListenerEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.cpp.
Use WebPopupMenuListenerEfl name instead of WebPopupMenuProxyEfl since
it more accurately represents its functionality now.
(WebKit):
(WebKit::WebPopupMenuListenerEfl::WebPopupMenuListenerEfl):
(WebKit::WebPopupMenuListenerEfl::valueChanged):
- UIProcess/efl/WebPopupMenuListenerEfl.h: Renamed from Source/WebKit2/UIProcess/efl/WebPopupMenuProxyEfl.h.
(WebKit):
(WebPopupMenuListenerEfl):
(WebKit::WebPopupMenuListenerEfl::create):
- UIProcess/efl/WebUIPopupMenuClient.cpp: Added.
(WebUIPopupMenuClient::showPopupMenu):
(WebUIPopupMenuClient::hidePopupMenu):
- UIProcess/efl/WebUIPopupMenuClient.h: Added.
(WebKit):
(WebUIPopupMenuClient):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy):
- 4:30 PM WebKit Team edited by
- (diff)
- 4:19 PM Changeset in webkit [143274] by
-
- 4 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed VS2010 build correction after r143273.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing source
file SourceProvider.cpp.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Add missing exports.
- 4:03 PM Changeset in webkit [143273] by
-
- 5 edits in trunk/Source/WebKit2
Add StorageManager member functions for keeping track of session storage namespaces
https://bugs.webkit.org/show_bug.cgi?id=110163
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit):
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebContext.h:
(WebKit::WebContext::storageManager):
(WebContext):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::createNewPage):
- 4:00 PM Changeset in webkit [143272] by
-
- 2 edits in trunk/Source/WebCore
[Curl] The function cookiesForDOM() does not behave correctly.
https://bugs.webkit.org/show_bug.cgi?id=109923
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-18
Reviewed by Brent Fulgham.
The cookiesForDOM() function should return a list of matching cookies, both persistent and session cookies.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::readCurlCookieToken): Added function to read next token from Curl cookie string.
(WebCore::addMatchingCurlCookie): Added function to add matching cookies to cookie list.
(WebCore::setCookiesFromDOM): Add domain and path from url to cookie if not already set.
(WebCore::cookiesForDOM): Return a list of matching cookies, both session and persistent cookies.
- 3:42 PM Changeset in webkit [143271] by
-
- 11 edits in trunk/Source/WebCore
Fix SQLTransaction leak.
https://bugs.webkit.org/show_bug.cgi?id=110052.
Reviewed by Geoffrey Garen.
With https://bugs.webkit.org/show_bug.cgi?id=104750, there is now a circular
reference between SQLTransaction and its backend. The clean up process needs
to be fixed to explicitly break this reference cycle.
The 5 phases of the SQLTransaction (and backend) phases and their clean up
actions are:
Phase 1. After Birth, before scheduling
- During shutdown, DatabaseThread::databaseThread() calls DatabaseBackendAsync::close(). DatabaseBackendAsync::close() iterates DatabaseBackendAsync::m_transactionQueue and calls SQLtransactionBackend::notifyDatabaseThreadIsShuttingDown() on each transaction there.
Phase 2. After scheduling, before state AcquireLock
- ~DatabaseTask() calls SQLtransactionBackend's notifyDatabaseThreadIsShuttingDown().
Phase 3. After state AcquireLock, before "lockAcquired"
- During shutdown, DatabaseThread::databaseThread() calls SQLTransactionCoordinator::shutdown(), which calls SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown().
Phase 4: After "lockAcquired", before state CleanupAndTerminate
- Same as Phase 3.
Phase 5: After state CleanupAndTerminate
- state CleanupAndTerminate calls SQLTransactionBackend::doCleanup().
See comment at the top of SQLTransactionBackend.cpp for more details.
Other supporting changes:
- Moved Database::close() to the DatabaseBackendAsync.
- Moved the "if already cleaned up" check from SQLTransactionBackend's notifyDatabaseThreadIsShuttingDown() to doCleanup().
- Added a check to prevent SQLTransactionCoordinator's releaseLock() from running when it's shutting down.
No new tests.
- Modules/webdatabase/Database.cpp:
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::close): Move from Database.cpp.
- Modules/webdatabase/DatabaseBackendAsync.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
- Modules/webdatabase/DatabaseTask.h:
(DatabaseBackendAsync::DatabaseTransactionTask):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):
- Modules/webdatabase/SQLTransactionCoordinator.h:
(SQLTransactionCoordinator):
- 3:29 PM Changeset in webkit [143270] by
-
- 2 edits in trunk/Source/WebCore
Fix WebCore Xcode project
- WebCore.xcodeproj/project.pbxproj: Fix path for CDMPrivate.h.
- 3:21 PM Changeset in webkit [143269] by
-
- 4 edits3 adds in trunk
Structure::flattenDictionaryStructure should compute max offset in a manner that soundly handles the case where the property list becomes empty
https://bugs.webkit.org/show_bug.cgi?id=110155
<rdar://problem/13233773>
Source/JavaScriptCore:
Reviewed by Mark Rowe.
This was a rookie mistake. It was doing:
for (blah) {
m_offset = foo foo's monotonically increase in the loop
}
as a way of computing max offset for all of the properties. Except what if the loop doesn't
execute because there are no properties? Well, then, you're going to have a bogus m_offset.
The solution is to initialize m_offset at the top of the loop.
- runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
LayoutTests:
Reviewed by Mark Rowe.
- fast/js/flatten-dictionary-structure-from-which-all-properties-were-deleted-expected.txt: Added.
- fast/js/flatten-dictionary-structure-from-which-all-properties-were-deleted.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/flatten-dictionary-structure-from-which-all-properties-were-deleted.js: Added.
- 3:15 PM Changeset in webkit [143268] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] Refactor grid position resolution code to support an internal grid representation
https://bugs.webkit.org/show_bug.cgi?id=109718
Reviewed by Ojan Vafai.
In order to support auto placement (where we can't infer a grid item's position from its style),
we need to have 2 code paths:
- One that places the elements on the grid representation.
- One that reuse the grid representation to return the position.
This code path implements this split so that we can add auto placement in a follow-up patch(es).
Also in order to avoid a O(n2) behavior [walking over our grid to find a grid item's position],
the cached position code path needed an efficient way to find the grid items -> position mapping.
Refactoring, covered by existing tests.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::cachedGridCoordinate):
(WebCore::RenderGrid::resolveGridPositionFromStyle):
These methods implements the above split. The first one
reuses our cached information whereas the other one is
used to build the cache.
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):
Added some code to clear the grid items' position.
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::logicalContentHeightForChild):
Updated these functions to use cachedGridPosition.
(WebCore::RenderGrid::maximumIndexInDirection):
Added a comment about why we don't use cachedGridPosition.
(WebCore::RenderGrid::insertItemIntoGrid):
Added this helper function to insert into the grid and
cache the position in the reverse lookup map.
(WebCore::RenderGrid::placeItemsOnGrid):
Updated to call insertItemIntoGrid. Also added an ASSERT
similar to m_grid.
(WebCore::RenderGrid::clearGrid):
Added this helper function to clear our grid structure.
- rendering/RenderGrid.h:
(GridCoordinate):
(WebCore::RenderGrid::GridCoordinate::GridCoordinate):
Added this POD to hold the coordinates in our reverse map.
- 3:07 PM Changeset in webkit [143267] by
-
- 37 edits2 adds in trunk
feFlood incorrectly applied color-interpolation-filters
https://bugs.webkit.org/show_bug.cgi?id=109985
Reviewed by Dirk Schulze.
Source/WebCore:
The SVG spec defines the color-interpolation-filters property for all
filter effect elements in order to control cases where a color is
based on some arithmetic computation on other colors. For example,
when computing gradients or blending colors. feFlood simply fills a
region with the given color, and that given color is always defined to
be in sRGB space, so the feFlood result should always be sRGB.
The new behavior matches both Opera and Firefox.
Tests: svg/filters/feFlood-color-interpolation-expected.svg
svg/filters/feFlood-color-interpolation.svg
- platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::platformApplySoftware): Force the color mode to be
sRGB before returning.
LayoutTests:
New test for feFlood behavior when color-interpolation-filters is used.
Failing expectations for tests affected by this change.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- svg/filters/feFlood-color-interpolation-expected.svg: Added.
- svg/filters/feFlood-color-interpolation.svg: Added.
- 3:00 PM Changeset in webkit [143266] by
-
- 2 edits in trunk/LayoutTests
Just skip the seamless iframe flowed into regions test on chromium. It's failing with a repaint issue.
- platform/chromium/TestExpectations:
- 2:38 PM Changeset in webkit [143265] by
-
- 2 edits in trunk/Source/WTF
Make HexNumber functions return 8-bit strings
https://bugs.webkit.org/show_bug.cgi?id=110152
Reviewed by Michael Saboff.
- wtf/HexNumber.h: (Internal): (WTF::Internal::hexDigitsForMode): (WTF::appendByteAsHex): (WTF::placeByteAsHexCompressIfPossible): (WTF::placeByteAsHex): (WTF::appendUnsignedAsHex): (WTF::appendUnsignedAsHexFixedSize): Use LChar everywhere.
- 2:31 PM Changeset in webkit [143264] by
-
- 15 edits2 adds in trunk/Source/WebCore
Introduced AbstractSQLStatement and AbstractSQLStatementBackend.
https://bugs.webkit.org/show_bug.cgi?id=110148.
Reviewed by Geoff Garen.
This is part of the webdatabase refactoring for webkit2.
- Also changed the frontend and backend to only refer to the abstract interface of each other.
No new tests.
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractSQLStatement.h: Added.
(AbstractSQLStatement):
(WebCore::AbstractSQLStatement::~AbstractSQLStatement):
- Modules/webdatabase/AbstractSQLStatementBackend.h: Added.
(AbstractSQLStatementBackend):
(WebCore::AbstractSQLStatementBackend::~AbstractSQLStatementBackend):
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::setBackend):
- Modules/webdatabase/SQLStatement.h:
(SQLStatement):
- Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::frontend):
- Modules/webdatabase/SQLStatementBackend.h:
(SQLStatementBackend):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverStatementCallback):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::executeSQL):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 2:11 PM Changeset in webkit [143263] by
-
- 5 edits in trunk/Source/WebCore
BUILD FIX (r143230): Fix renamed header and implementation of -[WebAccessibilityObjectWrapper accessibilityPostedNotification:]
<http://webkit.org/b/110077>
Fixes the following build failures:
AccessibilityObjectIOS.mm:35:9: fatal error: 'AccessibilityObjectWrapperIOS.h' file not found
#import "AccessibilityObjectWrapperIOS.h"
1 error generated.
WebAccessibilityObjectWrapperIOS.mm:2051:35: error: use of undeclared identifier 'notificationString'; did you mean 'notificationType'?
if (AXNotificationCallback && notificationString)
~
notificationType
WebAccessibilityObjectWrapperIOS.mm:2049:81: note: 'notificationType' declared here
- (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType
WebAccessibilityObjectWrapperIOS.mm:2052:38: error: use of undeclared identifier 'notificationString'; did you mean 'notificationType'?
AXNotificationCallback(self, notificationString, AXPostedNotificationContext);
~
notificationType
WebAccessibilityObjectWrapperIOS.mm:2049:81: note: 'notificationType' declared here
- (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType
WebAccessibilityObjectWrapperIOS.mm:2052:38: error: cannot initialize a parameter of type 'NSString *' with an lvalue of type 'WebCore::AXObjectCache::AXNotification'
AXNotificationCallback(self, notificationString, AXPostedNotificationContext);
~
WebAccessibilityObjectWrapperIOS.mm:2049:81: error: conflicting parameter types in implementation of 'accessibilityPostedNotification:': 'NSString *' vs 'WebCore::AXObjectCache::AXNotification' [-Werror,-Wmismatched-parameter-types]
- (void)accessibilityPostedNotification:(WebCore::AXObjectCache::AXNotification)notificationType
WebAccessibilityObjectWrapperBase.h:48:53: note: previous definition is here
- (void)accessibilityPostedNotification:(NSString *)notificationName;
4 errors generated.
- accessibility/ios/AccessibilityObjectIOS.mm: Fix name of
included header.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
Fix implementation to match declaration.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
- accessibility/ios/AXObjectCacheIOS.mm:
- Clean up #endif comments.
- 1:52 PM Changeset in webkit [143262] by
-
- 6 edits in trunk/Source/WebKit2
StorageManager message handlers should take the connection
https://bugs.webkit.org/show_bug.cgi?id=110151
Reviewed by Andreas Kling.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC):
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):
- Scripts/webkit2/messages.py:
(sync_message_statement):
(generate_message_handler):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
(WebKit::StorageManager::getValues):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/Storage/StorageManager.messages.in:
- 1:52 PM Changeset in webkit [143261] by
-
- 2 edits in trunk/LayoutTests
clear databases before running read-transactions-running-concurrently test
https://bugs.webkit.org/show_bug.cgi?id=110144
Reviewed by Nico Weber.
Otherwise, we might not have enough quota when running this tests and lots
of databases from previous tests are hanging around.
- storage/websql/read-transactions-running-concurrently.html:
- 1:44 PM Changeset in webkit [143260] by
-
- 6 edits in tags/Safari-537.31.3/Source
Merge <rdar://problem/12968169>
- 1:37 PM Changeset in webkit [143259] by
-
- 6 edits2 adds in trunk/Source/WebCore
EME: Add a CDMPrivate implementation using AVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=109739
Reviewed by Eric Carlson.
Add a CDMPrivate implementation using AVFoundation, similar to the EME v1 implementation
in MediaPlayerPrivateAVFoundationObjC. This requires passing the AVAssetResourceLoadingRequest
from the MediaPlayerPrivateAVFoundationObjC instance to CDMSessionAVFoundation. To do so
without adding platform-specific API to MediaPlayer, add a static map from MediaPlayer ->
MediaPlayerPrivateAVFoundationObjC instances to be used to vend the AVAssetResourceLoadingRequest
to CDMSessionAVFoundation.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::installedCDMFactories): Add the factory for CDMPrivateAVFoundation.
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMPrivateAVFoundation.h: Added.
(WebCore::CDMPrivateAVFoundation::create): Simple factory method.
(WebCore::CDMPrivateAVFoundation::~CDMPrivateAVFoundation): Simple virtual destructor.
(WebCore::CDMPrivateAVFoundation::cdm): Simple getter.
(WebCore::CDMPrivateAVFoundation::CDMPrivateAVFoundation): Simple constructor.
- Modules/encryptedmedia/CDMPrivateAVFoundation.mm: Added.
(WebCore::CDMSessionAVFoundation::~CDMSessionAVFoundation): Simple destructor.
(WebCore::CDMPrivateAVFoundation::supportsKeySytem): Check whether the given key system is supported.
(WebCore::CDMPrivateAVFoundation::supportsMIMEType): Check whether the given MIME type is supported.
(WebCore::CDMPrivateAVFoundation::createSession): Return a new CDMSessionAVFoundation.
(WebCore::CDMSessionAVFoundation::CDMSessionAVFoundation): Simple constructor.
(WebCore::CDMSessionAVFoundation::generateKeyRequest): Retrieve the AVAssetResourceLoadingRequest
from the MediaPlayer, and use it to generate a key request.
(WebCore::CDMSessionAVFoundation::releaseKeys): No-op.
(WebCore::CDMSessionAVFoundation::update): Add the passed in key to the AVAssetResourceLoadingRequest.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::playerToPrivateMap): Lazily instantiate static map.
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Register with the playerToPrivateMap.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Unregister from same.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Also send keyNeeded event in ENCRYPTED_MEDIA_V2.
(WebCore::MediaPlayerPrivateAVFoundationObjC::extractKeyURIKeyIDAndCertificateFromInitData): Convert this
method from file-static to class static.
(WebCore::MediaPlayerPrivateAVFoundationObjC::takeRequestForPlayerAndKeyURI): Pull the AVAssetResourceLoadingRequest
from m_keyURIToRequestMap and return it, if present.
- 1:36 PM Changeset in webkit [143258] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_security_origin
https://bugs.webkit.org/show_bug.cgi?id=107923
Patch by Christophe Dumez <Christophe Dumez> on 2013-02-18
Reviewed by Alexey Proskuryakov.
Use C API inside ewk_security_origin instead of accessing
directly internal C++ classes, to avoid breaking API
layering.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::enterFullScreen):
- UIProcess/API/efl/ewk_security_origin.cpp:
(EwkSecurityOrigin::EwkSecurityOrigin):
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin::create):
(EwkSecurityOrigin):
- 1:25 PM Changeset in webkit [143257] by
-
- 3 edits2 adds in trunk
Fix scaling of tiled SVG backgrounds on high-dpi displays
https://bugs.webkit.org/show_bug.cgi?id=110047
Reviewed by Dirk Schulze.
Source/WebCore:
This patch fixes the scaling of SVG when used for drawing patterns. Tiled/patterend SVG
images are first drawn into an image buffer and then the image buffer is used to stamp
out tiles. Because it is a raster source, the size of the image buffer needs to
be scaled to the final resolution of the device. After scaling the image buffer, the
source rect and pattern transforms need to be adjusted so they align in device pixel
coordinates. This adjustment was not done before this patch, causing pixelated rendering.
Additionally, a FIXME has been added due to webkit.org/b/110065 and the image buffer
has been manually scaled (using "zoomedAndScaledContainerRect") instead of relying
on the ImageBuffer's resolutionScale parameter.
Test: svg/as-background-image/tiled-background-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
Note that fixing the FIXME does not change that the source rect and transform need
to be adjusted for page scale.
LayoutTests:
- svg/as-background-image/tiled-background-image-expected.html: Added.
- svg/as-background-image/tiled-background-image.html: Added.
- 1:20 PM Changeset in webkit [143256] by
-
- 7 edits8 adds in trunk
Make seamless iframes paginate properly in their enclosing document's pagination context.
https://bugs.webkit.org/show_bug.cgi?id=106125
<rdar://problem/12922720> Text in iframe is clipped while printing
Reviewed by Simon Fraser.
Added new tests in fast/multicol and fast/region.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clampToStartAndEndRegions):
Don't clamp when the RenderView is the containing block of an object in a RenderFlowThread.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint):
Don't attempt any repaint container antics when we're in a seamless iframe, since the ancestor
document will actually do the handoff into the flow thread.
- rendering/RenderView.cpp:
(WebCore::enclosingSeamlessRenderer):
Heper function to test for an enclosing seamless iframe.
(WebCore::RenderView::addChild):
Subclass addChild on RenderView to properly set the inRenderFlowThread state for a seamless
child document so thta it will check regions.
(WebCore::RenderView::initializeLayoutState):
New helper method for setting up the initial layout state of a RenderView. If inside a seamless
paginated ancestor, set up the appropriate pagination information so the child document
knows about it. This method will expand to inherit info about line grids and exclusions eventually
also.
(WebCore::RenderView::layout):
Now calls initializeLayoutState to set up the layout state.
- rendering/RenderView.h:
(WebCore::RenderView::pageLogicalHeight):
(WebCore::RenderView::setPageLogicalHeight):
(RenderView):
Fix the type of the page logical height methods to be LayoutUnit instead of unsigned.
LayoutTests:
- fast/multicol/resources/ipad.jpg: Added.
- fast/multicol/resources/seamless.html: Added.
- fast/multicol/seamless-flowed-through-columns-expected.html: Added.
- fast/multicol/seamless-flowed-through-columns.html: Added.
- fast/regions/resources/ipad.jpg: Added.
- fast/regions/resources/seamless.html: Added.
- fast/regions/seamless-iframe-flowed-into-regions-expected.html: Added.
- fast/regions/seamless-iframe-flowed-into-regions.html: Added.
- 12:25 PM Changeset in webkit [143255] by
-
- 3 edits in tags/Safari-537.31.3/Source/WebKit2
Merged r143111. <rdar://problem/13205468>
- 12:25 PM Changeset in webkit [143254] by
-
- 2 edits in trunk/Source/WTF
Remove Vector::dataSlot(), it has no implementation
https://bugs.webkit.org/show_bug.cgi?id=109999
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-18
Reviewed by Andreas Kling.
VectorBufferBase does not implement any function bufferSlot().
The file only compiles because that part of the template is never
instantiated.
- wtf/Vector.h:
- 12:22 PM Changeset in webkit [143253] by
-
- 2 edits in tags/Safari-537.31.3/Source/WebKit2
Merged r143091. <rdar://problem/13212621>
- 12:19 PM Changeset in webkit [143252] by
-
- 4 edits1 copy in tags/Safari-537.31.3
Merged r143074. <rdar://problem/13216100>
- 12:15 PM Changeset in webkit [143251] by
-
- 8 edits in tags/Safari-537.31.3/Source/WebCore
Merged r142936. <rdar://problem/13210723>
- 12:08 PM Changeset in webkit [143250] by
-
- 2 edits in tags/Safari-537.31.3/Source/WebKit2
Merged r142836. <rdar://problem/13211893>
- 12:05 PM Changeset in webkit [143249] by
-
- 1 edit in tags/Safari-537.31.3/Source/WebCore/English.lproj/Localizable.strings
Update localizable strings.
- 11:29 AM Changeset in webkit [143248] by
-
- 2 edits in trunk/Source/WTF
Move ENABLE macros for WebCore out from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=105735
Unreviewed, build fix when NETSCAPE_PLUGIN_API is disabled.
Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH even if
NETSCAPE_PLUGIN_API is disabled (Qt, Efl, GTK, WX ports).
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-18
- wtf/FeatureDefines.h:
- 11:25 AM Changeset in webkit [143247] by
-
- 13 edits in trunk/Source
MIPS DFG implementation.
https://bugs.webkit.org/show_bug.cgi?id=101328
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-18
Reviewed by Oliver Hunt.
DFG implementation for MIPS.
Source/JavaScriptCore:
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::MIPSAssembler):
(JSC::MIPSAssembler::sllv):
(JSC::MIPSAssembler::movd):
(MIPSAssembler):
(JSC::MIPSAssembler::negd):
(JSC::MIPSAssembler::labelForWatchpoint):
(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::vmov):
(JSC::MIPSAssembler::linkDirectJump):
(JSC::MIPSAssembler::maxJumpReplacementSize):
(JSC::MIPSAssembler::revertJumpToMove):
(JSC::MIPSAssembler::replaceWithJump):
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::poke):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::and32):
(JSC::MacroAssemblerMIPS::lshift32):
(JSC::MacroAssemblerMIPS::mul32):
(JSC::MacroAssemblerMIPS::or32):
(JSC::MacroAssemblerMIPS::rshift32):
(JSC::MacroAssemblerMIPS::urshift32):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::xor32):
(JSC::MacroAssemblerMIPS::store32):
(JSC::MacroAssemblerMIPS::jump):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchNeg32):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::loadDouble):
(JSC::MacroAssemblerMIPS::moveDouble):
(JSC::MacroAssemblerMIPS::swapDouble):
(JSC::MacroAssemblerMIPS::subDouble):
(JSC::MacroAssemblerMIPS::mulDouble):
(JSC::MacroAssemblerMIPS::divDouble):
(JSC::MacroAssemblerMIPS::negateDouble):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerMIPS::truncateDoubleToInt32):
(JSC::MacroAssemblerMIPS::truncateDoubleToUint32):
(JSC::MacroAssemblerMIPS::branchDoubleNonZero):
(JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerMIPS::invert):
(JSC::MacroAssemblerMIPS::replaceWithJump):
(JSC::MacroAssemblerMIPS::maxJumpReplacementSize):
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::debugCall):
- dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- dfg/DFGFPRInfo.h:
(DFG):
(FPRInfo):
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):
- dfg/DFGGPRInfo.h:
(DFG):
(GPRInfo):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- jit/JSInterfaceJIT.h:
(JSInterfaceJIT):
- runtime/JSGlobalData.h:
(JSC::ScratchBuffer::allocationSize):
(ScratchBuffer):
Source/WTF:
- wtf/Platform.h:
- 11:16 AM Changeset in webkit [143246] by
-
- 4 edits in tags/Safari-537.31.3/Source
Versioning.
- 11:13 AM Changeset in webkit [143245] by
-
- 1 copy in tags/Safari-537.31.3
New Tag.
- 11:07 AM Changeset in webkit [143244] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r143145.
http://trac.webkit.org/changeset/143145
https://bugs.webkit.org/show_bug.cgi?id=110143
Causes frequent crashes. (Requested by eric_carlson on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::dispatchEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- 11:01 AM Changeset in webkit [143243] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Free cookies explicitly in loops instead of using GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=110103
Reviewed by Martin Robinson.
Free cookies explicitly in loops instead of using GOwnPtr for this.
Until now, the code was mixing both styles. This patch makes the
code consistent one way. Adopting list items with GOwnPtr for the
sole purpose to free them makes the freeing less obvious and may
lead to mistakes if someone refactors the code and calls "break;"
to abort loop iteration.
No new tests, no behavior change.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
- 10:43 AM Changeset in webkit [143242] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG::SpeculativeJIT::isKnownXYZ methods should use CFA rather than other things
https://bugs.webkit.org/show_bug.cgi?id=110092
Reviewed by Geoffrey Garen.
These methods were previously using GenerationInfo and other things to try to
gain information that the CFA could give away for free, if you asked kindly
enough.
Also fixed CallLinkStatus's dump() method since it was making an invalid
assertion: we most certainly can have a status where the structure is non-null
and the executable is null, like if we're dealing with an InternalFunction.
Also removed calls to isKnownNotXYZ from fillSpeculateABC methods in 32_64. I
don't know why that was there. But it was causing asserts if the value was
empty - i.e. we had already exited unconditionally but we didn't know it. I
could have fixed this by introducing another form of isKnownNotXYZ which was
tolerant of empty values, but I didn't feel like fixing code that I knew to be
unnecessary. (More deeply, isKnownNotCell, for example, really asks: "do you
know that this value can never be a cell?" while some of the previous uses
wanted to ask: "do you know that this is a value that is not a cell?". The
former is "true" if the value is a contradiction [i.e. BOTTOM], while the
latter is "false" for contradictions, since contradictions are not values.)
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::dump):
- bytecode/CallLinkStatus.h:
(JSC::CallLinkStatus::CallLinkStatus):
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
- 10:40 AM Changeset in webkit [143241] by
-
- 11 edits3 adds in trunk
Get rid of DFG::DoubleOperand and simplify ValueToInt32
https://bugs.webkit.org/show_bug.cgi?id=110072
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
ValueToInt32 had a side-effecting path, which was not OSR-friendly: an OSR after
the side-effect would lead to the side-effect re-executing. I got rid of that path
and replaced it with an optimization for the case where the input is speculated
number-or-other. This makes idioms like null|0 and true|0 work as expected, and
get optimized appropriately.
Also got rid of DoubleOperand. Replaced all remaining uses of it with
SpeculateDoubleOperand. Because the latter asserts that the Edge is a DoubleUse
edge and the remaining uses of DoubleOperand are all for untyped uses, I worked
around the assertion by setting the UseKind to DoubleUse by force. This is sound,
since all existing assertions for DoubleUse are actually asserting that we're not
converting a value to double unexpectedly. But all of these calls to
SpeculateDoubleOperand are when the operand is already known to be represented as
double, so there is no conversion.
This is neutral on benchmarks, except stanford-crypto-ccm, which speeds up a
little. Mostly, this is intended to delete a bunch of code. DoubleOperand was
equivalent to the replace-edge-with-DoubleUse trick that I'm using now, except it
involved a _lot_ more code.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(DFG):
(FPRTemporary):
- dfg/DFGSpeculativeJIT32_64.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(DFG):
LayoutTests:
Reviewed by Geoffrey Garen.
- fast/js/dfg-value-to-int32-with-side-effect-expected.txt: Added.
- fast/js/dfg-value-to-int32-with-side-effect.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-value-to-int32-with-side-effect.js: Added.
(foo):
(.result.foo):
- 10:33 AM Changeset in webkit [143240] by
-
- 5 edits in trunk
[JSC]: ASSERT in KURL(ParsedURLStringTag) under sourceMapURLForScript
https://bugs.webkit.org/show_bug.cgi?id=109987
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-18
Reviewed by Pavel Feldman.
Source/WebCore:
Improved an existing test to cover this.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
Remove the sourceURL parsing and script.url replacement from the JSC
implementation of ScriptDebugServer. The WebCore inspector code that
this was added for already does this, at a more appropriate time.
LayoutTests:
- inspector/debugger/source-url-comment-expected.txt:
- inspector/debugger/source-url-comment.html:
Add a test for a sourceURL with a non-relative path. This was causing
an ASSERT, rightfully so, in JSC builds.
- 10:21 AM Changeset in webkit [143239] by
-
- 3 edits2 adds in trunk
compareDocumentPosition reports disconnected nodes as following each other
https://bugs.webkit.org/show_bug.cgi?id=108274
Reviewed by Dimitri Glazkov.
Source/WebCore:
jQuery has had to implement their own sorting mechanism in Sizzle[1] due
to Node::compareDocumentPosition always reporting disconnected nodes
as following each other. According to spec[2], we should instead be
indicating that the result is (a) disconnected, (b) implementation
specific, and (c) deterministically ordered.
[1]: https://github.com/jquery/sizzle/commit/1c8aec91284af8d8c14447976235d5dd72b0d75e
[2]: http://dom.spec.whatwg.org/#dom-node-comparedocumentposition
Test: fast/dom/compare-document-position-disconnected-nodes.html
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
After walking the parentNode chain of both Nodes, compare the root.
If the Nodes don't share a root, they're in distinct trees, and
should return as described above. We determine which element
"preceeds" the other in an arbitrary fashion via pointer comparison.
LayoutTests:
- fast/dom/compare-document-position-disconnected-nodes-expected.txt: Added.
- fast/dom/compare-document-position-disconnected-nodes.html: Added.
- 10:06 AM Changeset in webkit [143238] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Update test expectations for recent failures.
- platform/chromium/TestExpectations:
- 9:45 AM Changeset in webkit [143237] by
-
- 5 edits in trunk
Web Inspector: [Canvas] fix replay log grouping by frames
https://bugs.webkit.org/show_bug.cgi?id=110122
Reviewed by Pavel Feldman.
Source/WebCore:
Bug: log grouping by frames did not work if a frame end call is not a draw call.
Drive-by: Last draw call group may not contain a draw call. In this case merge it into the previous group.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._appendCallNode):
(WebInspector.CanvasProfileView.prototype._maybeMergeLastDrawCallGroups):
LayoutTests:
Canvas replay test: last command is not a draw call.
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- 9:42 AM Changeset in webkit [143236] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
Fix test expectations for effect-reference* tests which I messed up
in my last commit.
- platform/chromium/TestExpectations:
- 9:33 AM Changeset in webkit [143235] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Mountain Lion buildfix after r143147.
Reviewed by Csaba Osztrogonác.
- runtime/DateConstructor.cpp:
- 9:19 AM Changeset in webkit [143234] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Moved WK1 specific failures from the shared TestExpectations file
to the wk1 one. Also removed some tests from the WK2
TestExpectations file as they have been consistently passing on
bots.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 9:19 AM Changeset in webkit [143233] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Superfluous HashMap check in SocketStreamHandleSoup::getHandleFromId()
https://bugs.webkit.org/show_bug.cgi?id=110107
Reviewed by Martin Robinson.
Remove Superfluous HashMap::contains() call in SocketStreamHandleSoup::getHandleFromId()
as HashMap::get() will already return 0 in this case anyway.
No new tests, no behavior change.
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore):
(WebCore::getHandleFromId):
- 9:13 AM Changeset in webkit [143232] by
-
- 66 edits in trunk/Source
Stop placing std::isfinite and std::signbit inside the global scope
https://bugs.webkit.org/show_bug.cgi?id=109817
Reviewed by Darin Adler.
Prefix calls to the isfinite and signbit methods with std:: as the two
methods are no longer being imported into the global scope.
Source/JavaScriptCore:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::shouldBlindDouble):
- offlineasm/cloop.rb:
- runtime/BigInteger.h:
(JSC::BigInteger::BigInteger):
- runtime/DateConstructor.cpp:
(JSC::constructDate):
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncSetYear):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::JSValue):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncIsFinite):
- runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax): Also include an opportunistic style fix.
(JSC::mathProtoFuncMin): Ditto.
- runtime/NumberPrototype.cpp:
(JSC::toStringWithRadix):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
- runtime/Uint16WithFraction.h:
(JSC::Uint16WithFraction::Uint16WithFraction):
Source/WebCore:
No new tests as there's no change in functionality.
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsDateOrNull):
- bindings/js/JSDOMBinding.h:
(WebCore::finiteInt32Value):
- bindings/v8/V8Binding.h:
(WebCore::v8DateOrNull):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::parseToNumber):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValueAsNumber):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::setOptimum):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::valueAsDate):
(WebCore::MonthInputType::defaultValueForStepUp):
(WebCore::MonthInputType::parseToNumber):
- html/NumberInputType.cpp:
(WebCore::NumberInputType::typeMismatchFor):
(WebCore::NumberInputType::sanitizeValue):
(WebCore::NumberInputType::hasBadInput):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::typeMismatchFor):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::defaultValueForStepUp):
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::moveTo):
(WebCore::CanvasPathMethods::lineTo):
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
(WebCore::CanvasPathMethods::arcTo):
(WebCore::CanvasPathMethods::arc):
(WebCore::CanvasPathMethods::rect):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setLineWidth):
(WebCore::CanvasRenderingContext2D::setMiterLimit):
(WebCore::CanvasRenderingContext2D::setShadowOffsetX):
(WebCore::CanvasRenderingContext2D::setShadowOffsetY):
(WebCore::CanvasRenderingContext2D::setShadowBlur):
(WebCore::lineDashSequenceIsValid):
(WebCore::CanvasRenderingContext2D::setLineDashOffset):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::validateRectForCanvas):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::setDuration):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::reset):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlFullscreenTimelineElement::setDuration):
(WebCore::MediaControlsBlackBerry::reset):
- inspector/InspectorValues.cpp:
(WebCore::InspectorBasicValue::writeJSON):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::currentAge):
(WebCore::CachedResource::freshnessLifetime):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
- platform/DateComponents.cpp:
(WebCore::DateComponents::setMillisecondsSinceEpochForDate):
(WebCore::DateComponents::setMillisecondsSinceEpochForDateTime):
(WebCore::DateComponents::setMillisecondsSinceEpochForMonth):
(WebCore::DateComponents::setMillisecondsSinceMidnight):
(WebCore::DateComponents::setMonthsSinceEpoch):
(WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
- platform/Decimal.cpp:
(WebCore::Decimal::fromDouble):
- platform/FileSystem.h:
(WebCore::isValidFileTime):
- platform/LocalizedStrings.cpp:
(WebCore::localizedMediaTimeDescription):
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::drawPatternToCairoContext):
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::addArc):
(WebCore::Path::contains):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::addArc):
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:
(WebCore::FullscreenVideoControllerGStreamer::timeToString):
- platform/graphics/openvg/PathOpenVG.cpp:
(WebCore::Path::addArc):
- platform/graphics/skia/SkiaUtils.h:
(WebCore::WebCoreFloatToSkScalar):
(WebCore::WebCoreDoubleToSkScalar):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::maxTimeSeekable):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaTimeDescription):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(timeToString):
- platform/network/ResourceResponseBase.cpp:
(WebCore::parseDateValueInHeader):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::localizedMediaTimeDescription):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::formatChromiumMediaControlsTime):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontSize):
- svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::decomposeArcToCubic):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunRound::round):
- xml/XPathValue.cpp:
(WebCore::XPath::Value::toString):
Source/WebKit/win:
- FullscreenVideoController.cpp:
(timeToString):
Source/WTF:
On Solaris and OpenBSD platforms or when using Visual C++ the two methods
are now defined (as incompatibility workarounds) inside the std namespace.
- wtf/DateMath.cpp:
(WTF::timeClip):
- wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
- wtf/MathExtras.h:
(std):
(std::isfinite):
(std::signbit):
(lrint):
(wtf_pow):
(decomposeDouble):
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
- wtf/dtoa.cpp:
(WTF::dtoa):
- 9:08 AM Changeset in webkit [143231] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Mountain Lion buildfix after r143147.
Reviewed by Csaba Osztrogonác.
- runtime/DateInstance.cpp:
- 9:06 AM Changeset in webkit [143230] by
-
- 3 edits2 moves in trunk/Source/WebCore
AX: Make iOS wrapper use the WebAccessibilityObjectBase wrapper
https://bugs.webkit.org/show_bug.cgi?id=110077
Reviewed by David Kilzer.
Make the iOS wrapper a subclass of the shared wrapper so that iOS can re-use code from the Mac.
Rename the iOS file to reflect the class name.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/AccessibilityObjectWrapperIOS.h: Removed.
- accessibility/ios/AccessibilityObjectWrapperIOS.mm: Removed.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.h: Copied from Source/WebCore/accessibility/ios/AccessibilityObjectWrapperIOS.h.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: Copied from Source/WebCore/accessibility/ios/AccessibilityObjectWrapperIOS.mm.
(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):
- 9:06 AM Changeset in webkit [143229] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
- 9:04 AM Changeset in webkit [143228] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r143210.
http://trac.webkit.org/changeset/143210
https://bugs.webkit.org/show_bug.cgi?id=110128
Still causing some test timeouts (Requested by anttik on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
- platform/SharedTimer.h:
(SharedTimer):
(WebCore):
(WebCore::MainThreadSharedTimer::stop):
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
- platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 8:54 AM Changeset in webkit [143227] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Disable hiding the debugger when it is below the source code
https://bugs.webkit.org/show_bug.cgi?id=110106
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.
When the "Split horizontally" option is checked in the Sources panel the button responsible for the sidebar
visibility is hidden and the sidebar is force-shown. Also set the "Split sidebar" option default to true.
No new tests.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/scriptsPanel.css:
(.split-view-horizontal #scripts-debug-sidebar-resizer-widget):
- 8:49 AM Changeset in webkit [143226] by
-
- 3 edits in trunk/Source/WebKit2
pinch-zooming webpage messes up full-screening of embedded video
https://bugs.webkit.org/show_bug.cgi?id=106115
Reviewed by Maciej Stachowiak.
Reset the page scale when entering full screen, and reset to the original scale when exiting.
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 8:48 AM Changeset in webkit [143225] by
-
- 6 edits2 adds in trunk
[CSS Exclusions] Support outside-shape layout for shape-inside property
https://bugs.webkit.org/show_bug.cgi?id=102571
Reviewed by David Hyatt.
Source/WebCore:
A shape-inside value of 'outside-shape' should resolve to the value of
the shape-outside property for layout. This patch introduces a helper
method to resolve shape-inside in RenderStyle, and replaces calls to
RenderStyle::shapeInside() when the resolved (layout) value should be
used.
Test: fast/exclusions/shape-inside/shape-inside-outside-shape.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore::::computedShape): Use the resolved shape-inside getter.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Ditto.
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Ditto.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange): Ditto.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Ditto.
- rendering/style/RenderStyle.h: Add the resolved shape inside getter.
LayoutTests:
Test that the shape-outside value correctly propagates to shape-inside
when shape-inside has a value of 'outside-shape,' using both an
undefined and a simple shape outside value.
- fast/exclusions/shape-inside/shape-inside-outside-shape-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-outside-shape.html: Added.
- 8:41 AM Changeset in webkit [143224] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119
Reviewed by Vsevolod Vlasov.
Removed context menus, made it toggle automatically upon dock orientation change.
- inspector/front-end/DockController.js:
(WebInspector.DockController.prototype._toggleDockState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._dockSideChanged):
(WebInspector.ElementsPanel.prototype._setVerticalSplit):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._dockSideChanged):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/inspector.css:
- inspector/front-end/scriptsPanel.css:
(#scripts-sidebar-stack-pane):
(div.sidebar-pane-stack#scripts-debug-sidebar-contents):
- inspector/front-end/tabbedPane.css:
(.tabbed-pane):
- 8:34 AM Changeset in webkit [143223] by
-
- 4 edits in trunk
[GTK] Fix nits for configuration
https://bugs.webkit.org/show_bug.cgi?id=110083
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-18
Reviewed by Martin Robinson.
.:
Remove unicode backend printing option. The only backend for unicode is icu
after changeset 142724.
- Source/autotools/PrintBuildConfiguration.m4:
Source/WebCore:
Remove trailing white space. It has caused annoying warning while configuration.
No new tests since no funtionality change.
- GNUmakefile.list.am:
- 8:29 AM Changeset in webkit [143222] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adjusting failure expectation for an inspector
test which now times out.
- 8:17 AM Changeset in webkit [143221] by
-
- 2 edits in trunk/Tools
[Qt][WK2] Remove duped test name and append new test in project file
https://bugs.webkit.org/show_bug.cgi?id=110117
A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
add this test into the runnable test suite and remove a duped test in project file.
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-18
Reviewed by Jocelyn Turcotte.
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
- 8:15 AM Changeset in webkit [143220] by
-
- 18 edits in trunk/Source/WebCore
[WebGL][EFL] Refactor GraphicsContext3DPrivate to add support for SharedContext.
https://bugs.webkit.org/show_bug.cgi?id=109988
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This patch refactors PlatformContext and GraphicsContext3DPrivate to
add support for Shared Context. This would help share GL resources
between transport surface and offscreen surface without having to worry
about the context state. So far, we used the same drawable as transport
surface and offscreen surface. After this patch we use pixmap surface as
offscreen surface and use shared context to render texture content to
transport surface. This would also align as to how shared surface is implemented
on EFL and Qt ports.
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::makeSharedContextCurrent):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::GLPlatformContext::initialize):
- platform/graphics/opengl/GLPlatformContext.h:
Needed changes to take shared context into use.
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface):
(WebCore::GLPlatformSurface::updateContents):
- platform/graphics/opengl/GLPlatformSurface.h:
(GLPlatformSurface):
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pixmapContextConfig):
(GLXConfigSelector):
(WebCore::GLXConfigSelector::reset):
- platform/graphics/surfaces/glx/GLXContext.cpp:
Added support to query configiration supporting
pixmap surface.
(WebCore::GLXOffScreenContext::initialize):
- platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::swapBuffers):
(WebCore::GLXOffScreenSurface::GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::~GLXOffScreenSurface):
(WebCore::GLXOffScreenSurface::initialize):
(WebCore::GLXOffScreenSurface::configuration):
(WebCore::GLXOffScreenSurface::destroy):
(WebCore::GLXOffScreenSurface::freeResources):
(WebCore::GLXOffScreenSurface::setGeometry):
Renamed GLXPBuffer surface as GLXOffScreenSurface.
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXOffScreenSurface):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::createSurface):
- platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createPixmap):
(WebCore):
(WebCore::X11Helper::destroyPixmap):
(WebCore::X11Helper::createOffScreenWindow):
- platform/graphics/surfaces/glx/X11Helper.h:
(X11Helper):
Added functions to create and destroy pixmap.
- 8:14 AM Changeset in webkit [143219] by
-
- 2 edits in trunk/Websites/webkit.org
Add Digia to the domain affiliations
https://bugs.webkit.org/show_bug.cgi?id=110116
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
- team.html:
- 7:46 AM Changeset in webkit [143218] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: Generate meta information for HeapSnapshot parser.
https://bugs.webkit.org/show_bug.cgi?id=110104
Reviewed by Yury Semikhatsky.
The format of Native heap snapshot is slightly different so it should provide its own meta information.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::finish):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/Inspector.json:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
- inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshot):
- 7:40 AM Changeset in webkit [143217] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r183105. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
- DEPS:
- 7:33 AM Changeset in webkit [143216] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove ahem_path from WebKit.gyp
https://bugs.webkit.org/show_bug.cgi?id=110111
Reviewed by Jochen Eisinger.
It's only used in DumpRenderTree.gyp, and that file defines its own
copy of this variable.
- WebKit.gyp:
- 7:32 AM Changeset in webkit [143215] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Unreviewed. Add myself to committers list.
- 7:32 AM Changeset in webkit [143214] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark perf/show-hide-table-rows.html as sometimes failing or slow
on EFL port.
- platform/efl/TestExpectations:
- 6:47 AM Changeset in webkit [143213] by
-
- 2 edits in trunk/Tools
[chromium] remove log spew from dumpAllBackForwardLists
https://bugs.webkit.org/show_bug.cgi?id=110108
Reviewed by Nico Weber.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
- 6:45 AM Changeset in webkit [143212] by
-
- 18 edits in trunk/Source/WebCore
[GTK] Force single header includes in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=104676
Reviewed by Xan Lopez.
Only including <webkitdom/webkitdom.h> should be allowed from
apps.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateHeader):
- bindings/scripts/gobject-generate-headers.pl:
- bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
- bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
- bindings/scripts/test/GObject/WebKitDOMTestException.h:
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
- bindings/scripts/test/GObject/WebKitDOMTestNode.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- 6:35 AM Changeset in webkit [143211] by
-
- 10 edits1 add in trunk/Source
Move ENABLE macros for WebCore out from Platform.h
https://bugs.webkit.org/show_bug.cgi?id=105735
Source/WebKit/chromium:
Move the chromium specific WebCore ENABLE macro definitions
from Platform.h to features.gypi.
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-18
Reviewed by Darin Adler and Benjamin Poulain.
- features.gypi: Set ENABLE_SUBPIXEL_LAYOUT to 1.
Source/WTF:
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-18
Reviewed by Darin Adler and Benjamin Poulain.
Introduce FeatureDefines.h by combining the existing rules from
Platform.h and adding new rules for all the ENABLE flags that are
listed in the FeatureFlags wiki.
The new rules are not used at the moment by any ports
as the port specific build systems already define these flags
so the !defined() guard will prevent redefinition of the macros.
- GNUmakefile.list.am: Add FeatureDefines.h.
- WTF.gypi: Ditto.
- WTF.pro: Ditto.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- wtf/CMakeLists.txt: Ditto.
- wtf/FeatureDefines.h: Added.
- wtf/Platform.h: Move macro definitions to FeatureDefines.h.
- 6:28 AM Changeset in webkit [143210] by
-
- 4 edits in trunk/Source/WebCore
Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765
Reviewed by Andreas Kling.
Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.
- platform/SharedTimer.h:
(WebCore::SharedTimer::willEnterNestedEventLoop):
(WebCore):
(MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::willEnterNestedEventLoop):
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::fireTimersInNestedEventLoop):
- platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::clearSharedTimer):
(WebCore::ensurePowerObserver):
(WebCore::sharedTimer):
(WebCore::reinsertSharedTimer):
Before entering nested runloop (used for inspector debugger mostly) reconstruct and reinsert the timer. For some reason
the timer doesn't fire otherwise.
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 6:10 AM Changeset in webkit [143209] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Resources] Only remember the tree element selection if explicitly made by user
https://bugs.webkit.org/show_bug.cgi?id=110105
Reviewed by Pavel Feldman.
This change instructs the Resources panel to remember the selected tree element only if it has been
selected by the user (not automatically, like selecting a parent when its child is removed).
All onselect() overrides pass the selectedByUser argument value
to BaseStorageTreeElement.prototype.onselect.
Drive-by: Use === comparisons everywhere.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._reset): Do not detach [immutable] category views.
(WebInspector.BaseStorageTreeElement.prototype.onselect): Remember itemURL on user gesture only.
(WebInspector.StorageCategoryTreeElement.prototype.onselect):
(WebInspector.FrameTreeElement.prototype.onselect):
(WebInspector.FrameResourceTreeElement.prototype.onselect):
(WebInspector.DatabaseTreeElement.prototype.onselect):
(WebInspector.DatabaseTableTreeElement.prototype.onselect):
(WebInspector.IDBDatabaseTreeElement.prototype.onselect):
(WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
(WebInspector.IDBIndexTreeElement.prototype.onselect):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.onselect):
(WebInspector.CookieTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.onselect):
(WebInspector.FileSystemTreeElement.prototype.clear):
(WebInspector.ResourcesSearchController.prototype.nextSearchResult):
- 6:03 AM Changeset in webkit [143208] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/dom/shadow/shadow-dom-event-dispatching-distributed-child.html as
failing on EFL port. The test was introduced in r143191.
- platform/efl/TestExpectations:
- 6:01 AM Changeset in webkit [143207] by
-
- 4 edits in trunk
Web Inspector: Color picker should not be available in Computed Styles pane
https://bugs.webkit.org/show_bug.cgi?id=109697
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-18
Reviewed by Pavel Feldman.
Source/WebCore:
Refactored PropertiesSection and TreeElement inheritors in StylesSidebarPane.js for cleaner separation
of read-only and editable properties.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype.onpopulate):
(WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
(WebInspector.ComputedStylePropertiesSection):
(WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
(WebInspector.BlankStylePropertiesSection):
(WebInspector.StylePropertyTreeElementBase):
(WebInspector.StylePropertyTreeElementBase.prototype.node):
(WebInspector.StylePropertyTreeElementBase.prototype.editablePane):
(WebInspector.StylePropertyTreeElementBase.prototype.onattach):
(WebInspector.StylePropertyTreeElementBase.prototype.updateTitle.linkifyURL):
(WebInspector.StylePropertyTreeElementBase.prototype.updateTitle.):
(WebInspector.StylePropertyTreeElementBase.prototype):
(.event):
(.isRevert):
LayoutTests:
- inspector/styles/undo-add-property.html:
- 5:45 AM Changeset in webkit [143206] by
-
- 9 edits in trunk
Web Inspector: [Canvas] group replay log calls by frames
https://bugs.webkit.org/show_bug.cgi?id=110101
Reviewed by Pavel Feldman.
Source/WebCore:
Group canvas replay log by frames, then by draw calls.
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/Inspector.json:
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._appendCallNode):
(WebInspector.CanvasProfileView.prototype._appendDrawCallGroup):
LayoutTests:
- inspector/profiler/canvas-profiler-test.js:
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt:
- inspector/profiler/canvas2d/canvas-replay-log-grid.html:
- inspector/profiler/canvas2d/canvas-stack-trace-expected.txt:
- 5:35 AM Changeset in webkit [143205] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Deleted extraneous file. It has been added accidentally in r142135.
https://bugs.webkit.org/show_bug.cgi?id=109953.
- platform/qt-5.0-wk2/TestExpectations.orig: Removed.
- 5:29 AM Changeset in webkit [143204] by
-
- 2 edits in trunk/Source/WebCore
[Soup] CookieJarSoup::deleteCookie() should stop looking for the cookie after it is removed
https://bugs.webkit.org/show_bug.cgi?id=110100
Reviewed by Kenneth Rohde Christiansen.
CookieJarSoup::deleteCookie() retrieves the list of cookies that apply to a given URL, then
iterates through the cookies to find the one with the right name and delete it. However, the
current implementation keeps on comparing cookie names after the cookie was removed. This
patch introduces a "wasDeleted" boolean to stop comparing cookie names after the cookie was
deleted. Note that we cannot break as soon as the cookie is found as we need to keep iterating
so that the cookies get freed by GOwnPtr.
No new tests, no behavior change.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteCookie):
- 5:26 AM Changeset in webkit [143203] by
-
- 4 edits in trunk
[EFL][WK2] Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=110081
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Disable EWK2UnitTestBase.ewk_view_scale API test as it is failing.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Tools:
Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
- TestWebKitAPI/PlatformEfl.cmake:
- 5:26 AM Changeset in webkit [143202] by
-
- 10 edits in trunk
Web Inspector: Create separate project for each domain for UISourceCode based on browser resources.
https://bugs.webkit.org/show_bug.cgi?id=109691
Reviewed by Pavel Feldman.
Source/WebCore:
Separate project of certain type is now created for each domain.
UISourceCode path represents a path in the project now.
UISourceCode uri is now calculated based on project id and path.
It is also possible to calculate path based on projectId and URI, which is used for uiSourceCodeForURI() methods.
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForPath):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.projectId):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.splitURL):
(WebInspector.SimpleWorkspaceProvider._pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._projectDelegate):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.uri):
(WebInspector.UISourceCode.path):
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/uisourcecode-revisions.html:
- 5:21 AM Changeset in webkit [143201] by
-
- 2 edits in trunk/Tools
[Qt] Disable the build if certain configure checks fail
https://bugs.webkit.org/show_bug.cgi?id=110094
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-18
Reviewed by Tor Arne Vestbø.
Allow for the build to be skipped (clear out SUBDIRS) if certain
configure conditions aren't met.
- qmake/mkspecs/features/configure.prf:
- 5:20 AM Changeset in webkit [143200] by
-
- 4 edits in trunk/Source/WebKit/efl
[EFL] Fix build when CONTEXT_MENUS flag is turned off
https://bugs.webkit.org/show_bug.cgi?id=109924
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-02-18
Reviewed by Gyuyoung Kim.
- WebCoreSupport/ContextMenuClientEfl.cpp:
- WebCoreSupport/ContextMenuClientEfl.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_get):
- 5:12 AM Changeset in webkit [143199] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 5:06 AM Changeset in webkit [143198] by
-
- 22 edits in trunk
[EFL] Rebaseline failure media tests after r142947
https://bugs.webkit.org/show_bug.cgi?id=109904
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
- css/mediaControlsEfl.css: Align time text vertically.
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
LayoutTests:
- platform/efl/TestExpectations:
- platform/efl/media/audio-controls-rendering-expected.png:
- platform/efl/media/audio-controls-rendering-expected.txt:
- platform/efl/media/controls-after-reload-expected.png:
- platform/efl/media/controls-after-reload-expected.txt:
- platform/efl/media/controls-strict-expected.png:
- platform/efl/media/controls-strict-expected.txt:
- platform/efl/media/controls-styling-expected.png:
- platform/efl/media/controls-styling-expected.txt:
- platform/efl/media/controls-styling-strict-expected.png:
- platform/efl/media/controls-styling-strict-expected.txt:
- platform/efl/media/controls-without-preload-expected.png:
- platform/efl/media/controls-without-preload-expected.txt:
- platform/efl/media/video-controls-rendering-expected.png:
- platform/efl/media/video-controls-rendering-expected.txt:
- platform/efl/media/video-display-toggle-expected.png:
- platform/efl/media/video-display-toggle-expected.txt:
- platform/efl/media/video-playing-and-pause-expected.png:
- platform/efl/media/video-playing-and-pause-expected.txt:
- 5:00 AM Changeset in webkit [143197] by
-
- 9 edits6 adds in trunk
[Qt][WK2] Support WK2 API tests
https://bugs.webkit.org/show_bug.cgi?id=109843
Reviewed by Jocelyn Turcotte.
Source/WebKit2:
- UIProcess/API/qt/qquickwebview_p.h:
(TestWebKitAPI):
Tools:
- TestWebKitAPI/DerivedSources.pri: Added.
- TestWebKitAPI/InjectedBundle.pri: Added.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.pri:
- TestWebKitAPI/TestWebKitAPI.pro:
- TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
- TestWebKitAPI/Tests/WTF/WTF.pro:
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
- TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::isKeyDown):
(Util):
- TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
(TestWebKitAPI):
(WrapperWindow):
(TestWebKitAPI::WrapperWindow::WrapperWindow):
(TestWebKitAPI::WrapperWindow::handleStatusChanged):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::focus):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
- TestWebKitAPI/qt/main.cpp:
(addQtWebProcessToPath):
(main):
- 4:56 AM Changeset in webkit [143196] by
-
- 9 edits1 move1 add in trunk/Source/WebCore
Web Inspector: Extract FileSystemUtils from FileSystemProjectDelegate as IsolatedFileSystem class.
https://bugs.webkit.org/show_bug.cgi?id=110086
Reviewed by Pavel Feldman.
Extracted IsolatedFileSystem class that could be mocked for tests now.
Renamed IsolatedFileSystemModel to IsolatedFileSystemManager.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.displayName):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
- inspector/front-end/IsolatedFileSystem.js: Added.
(WebInspector.IsolatedFileSystem):
(WebInspector.IsolatedFileSystem.errorMessage):
(WebInspector.IsolatedFileSystem.prototype.id):
(WebInspector.IsolatedFileSystem.prototype.path):
(WebInspector.IsolatedFileSystem.prototype._requestFileSystem):
(WebInspector.IsolatedFileSystem.prototype.fileSystemLoaded):
(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):
(WebInspector.IsolatedFileSystem.prototype.fileEntryLoaded):
(WebInspector.IsolatedFileSystem.prototype.fileLoaded):
(WebInspector.IsolatedFileSystem.prototype.readerLoadEnd):
(WebInspector.IsolatedFileSystem.prototype.errorHandler):
(WebInspector.IsolatedFileSystem.prototype.requestFileContent):
(WebInspector.IsolatedFileSystem.prototype.fileWriterCreated.fileTruncated):
(WebInspector.IsolatedFileSystem.prototype.fileWriterCreated):
(WebInspector.IsolatedFileSystem.prototype.writerEnd):
(WebInspector.IsolatedFileSystem.prototype.setFileContent):
(WebInspector.IsolatedFileSystem.prototype.):
(WebInspector.IsolatedFileSystem.prototype.toArray):
(WebInspector.IsolatedFileSystem.prototype._readDirectory):
(WebInspector.IsolatedFileSystem.prototype._requestEntries):
- inspector/front-end/IsolatedFileSystemManager.js: Renamed from Source/WebCore/inspector/front-end/IsolatedFileSystemModel.js.
(WebInspector.IsolatedFileSystemManager):
(WebInspector.IsolatedFileSystemManager.prototype.mapping):
(WebInspector.IsolatedFileSystemManager.prototype.supportsFileSystems):
(WebInspector.IsolatedFileSystemManager.prototype._requestFileSystems):
(WebInspector.IsolatedFileSystemManager.prototype.addFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.removeFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemsLoaded):
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemPaths):
(WebInspector.IsolatedFileSystemManager.prototype._processPendingFileSystemRequests):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemAdded):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
(WebInspector.IsolatedFileSystemManager.prototype._isolatedFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype.requestDOMFileSystem):
(WebInspector.IsolatedFileSystemDispatcher):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemsLoaded):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemRemoved):
(WebInspector.IsolatedFileSystemDispatcher.prototype.fileSystemAdded):
- inspector/front-end/SettingsScreen.js:
(WebInspector.WorkspaceSettingsTab.prototype._createFileSystemsEditor):
(WebInspector.WorkspaceSettingsTab.prototype._addFileSystemRow.removeFileSystemClicked):
(WebInspector.WorkspaceSettingsTab.prototype._addFileSystemClicked):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- 4:54 AM Changeset in webkit [143195] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Changing WebView.contentY and WebView.contentX does not redraw content
https://bugs.webkit.org/show_bug.cgi?id=108337
Reviewed by Jocelyn Turcotte.
We should not ignore content position changes unless pinch zoom or bounce-back
animation is ongoing.
This way we notify the web process about visible rect changes if the contentX
and contentY properties are used to programmatically scroll the content from QML.
One important usecase for this is when implementing scrollbars.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
- 4:11 AM Changeset in webkit [143194] by
-
- 4 edits in trunk
[EFL][WK2] compositing/layer-creation/fixed-position-out-of-view-scaled.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=110059
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-18
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Remove the ASSERT check in TextureMapperLayer. This assertion seems
valid because CoordinatedGraphicsScene::adjustPositionForFixedLayers() calls
TextureMapperLayer::setScrollPositionDeltaIfNeeded() when the graphics
layer is a fixed position layer. However, the assertion can be failed
because it is possible that TextureMapperLayer is a non-fixed position
layer when the graphics layer that holds the TextureMapperLayer is a
fixed position layer. When CoordinatedGraphicsScene flushes,
TextureMapperLayer becomes a fixed position layer.
No new tests. No change in behavior.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
LayoutTests:
Unskip two tests on EFL port. Now those pass.
compositing/layer-creation/fixed-position-out-of-view-scaled.html
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html
- platform/efl-wk2/TestExpectations:
- 3:45 AM Changeset in webkit [143193] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several webgl/conformance tests that started passing after
r142854.
- platform/efl-wk2/TestExpectations:
- 3:33 AM Changeset in webkit [143192] by
-
- 8 edits in trunk/Source
[WK2][EFL] Unified text checker implementation
https://bugs.webkit.org/show_bug.cgi?id=107682
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests, covered by editing/spelling tests.
- platform/text/TextChecking.h:
(WebCore):
Enabling unified text checker feature for WebKit-EFL.
Source/WebKit/efl:
Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):
Source/WebKit2:
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit):
(WebKit::nextWordOffset):
Helper function to determine the word offset to do not call
client's checkSpellingOfString for the word separators.
(WebKit::TextChecker::checkTextOfParagraph):
Allow to check spelling for multiple words,
their misspelling location and length are saved to the vector.
- WebProcess/WebCoreSupport/WebEditorClient.h:
Add UNIFIED_TEXT_CHECKING guard to checkTextOfParagraph.
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
(WebKit):
(WebKit::WebEditorClient::checkTextOfParagraph):
As spelling implementation is exposed to UIProcess,
send a meesage to UIProcess to call TextChecker::checkTextOfParagraph.
- 3:26 AM Changeset in webkit [143191] by
-
- 2 edits25 adds2 deletes in trunk/LayoutTests
fast/dom/shadow/shadow-dom-event-dispatching.html flake
https://bugs.webkit.org/show_bug.cgi?id=103299
Reviewed by Jochen Eisinger.
This patch breaks fast/dom/shadow/shadow-dom-event-dispatching.html out
into 12 separate tests to avoid timeouts. Common logic for all these
dispatching tests is now in resources/event-dispatching.js, and each
individual test function now runs in its own HTML file.
- fast/dom/shadow/resources/event-dispatching.js: Added.
(moveMouseOver):
(recordEvent):
(dumpNode):
(dumpComposedShadowTree):
(addEventListeners):
(debugDispatchedEvent):
(moveMouse):
(showSandboxTree):
- fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-child-of-inactive-content.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-details-summary-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-details-summary.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-child-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-child.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-with-same-related-target.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-manually-fired.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-nested-shadow-roots.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree.html: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt: Added.
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root.html: Added.
New tests!
- fast/dom/shadow/shadow-dom-event-dispatching-expected.txt: Removed.
- fast/dom/shadow/shadow-dom-event-dispatching.html: Removed.
- platform/chromium/TestExpectations:
Dropped the old, monolithic test, and removed it from Chromium's
TestExpectations file.
- 3:24 AM Changeset in webkit [143190] by
-
- 12 edits in trunk
[EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
https://bugs.webkit.org/show_bug.cgi?id=108598
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Refactor the Ewk_Favicon code so that it no longer relies on internal
C++ API and so that it is based solely on the C API. The API is changed
a little as well so that the Favicon URL is no longer exposed to the
client. Also the client is now only notified of icon changes once the
favicon data is actually available.
The API is covered by existing API tests and by MiniBrowser which are
both updated accordingly in this patch.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::informURLChange):
(EwkView::createFavicon):
(EwkView::onFaviconChanged):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/ewk_favicon_database.cpp:
Client are now notified of favicon changes only when the favicon data
becomes available and make API to retrieve a favicon synchronous. NULL
is returned if the favicon data is not available.
(EwkFaviconDatabase::EwkFaviconDatabase):
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::iconDataReadyForPageURL):
(ewk_favicon_database_icon_get):
- UIProcess/API/efl/ewk_favicon_database.h:
- UIProcess/API/efl/ewk_favicon_database_private.h:
(EwkFaviconDatabase):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_favicon_get):
- UIProcess/API/efl/ewk_view.h:
Rename 'icon,changed' signal to 'favicon,changed' for clarity and
consistency with the rest of the favicon API. Remove API to retrieve
the favicon URL and replace it by one to retrieve the favicon image as
an Evas_Object instead.
- UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
Update API tests to use the new favicon API.
Tools:
Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
- MiniBrowser/efl/main.c:
(update_view_favicon):
(on_view_favicon_changed):
(window_create):
- 3:22 AM Changeset in webkit [143189] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several webaudio test cases that pass now that we updated to
gstreamer 1.0.
- platform/efl/TestExpectations:
- 2:59 AM Changeset in webkit [143188] by
-
- 2 edits in trunk/Source/WebCore
[chromium/clang] Remove -Wno-return-type-c-linkage
https://bugs.webkit.org/show_bug.cgi?id=110098
Reviewed by Jochen Eisinger.
The one instance where this triggered was removed in
http://trac.webkit.org/changeset/141184 . A clang that has this
warning landed in chromium r182694, so it should be safe to turn
the warning on now.
- WebCore.gyp/WebCore.gyp:
- 2:56 AM Changeset in webkit [143187] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Update expectations for several test cases to make the bots green.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 2:51 AM Changeset in webkit [143186] by
-
- 21 edits2 adds in trunk
Web Inspector: provide basic console.table implementation (no [,columns] support)
https://bugs.webkit.org/show_bug.cgi?id=109453
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/console/console-format-table.html
Using console preview infrastructure to support console.table.
- English.lproj/localizedStrings.js:
- inspector/ConsoleAPITypes.h:
- inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue):
(WebCore::ConsoleMessage::addToFrontend):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapObject):
(WebCore):
(WebCore::InjectedScript::wrapTable):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl):
(WebInspector.ConsoleMessageImpl.prototype.willHide):
(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
(WebInspector.ConsoleMessageImpl.prototype._renderPropertyPreview):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsTable):
- inspector/front-end/ConsoleModel.js:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleCommand.prototype.wasShown):
(WebInspector.ConsoleCommand.prototype.willHide):
(WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/DataGrid.js:
(.sortDataGrid.comparator):
(.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.renderInline):
- inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView.prototype._queryFinished):
- inspector/front-end/dataGrid.css:
(.data-grid.inline):
(.data-grid.inline td.corner):
- inspector/front-end/resourcesPanel.css:
(.storage-view > .data-grid):
- page/Console.cpp:
(WebCore::Console::table):
(WebCore):
- page/Console.h:
(Console):
- page/Console.idl:
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-format-table-expected.txt: Added.
- inspector/console/console-format-table.html: Added.
- 2:45 AM Changeset in webkit [143185] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/inspector/front-end
Merge 142870
Web Inspector: fix to record button remaining red after heap snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=109804
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.
Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12294013
- 2:45 AM Changeset in webkit [143184] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: JavaScriptSourceFrame should inherit UISourceCodeFrame
https://bugs.webkit.org/show_bug.cgi?id=110091
Reviewed by Pavel Feldman.
Removed duplicated code from JavaScriptSourceFrame and made it inherit UISourceCodeFrame.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.canEditSource):
(WebInspector.UISourceCodeFrame.prototype.onTextChanged):
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
(WebInspector.UISourceCodeFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.UISourceCodeFrame.prototype._innerSetContent):
- 2:35 AM Changeset in webkit [143183] by
-
- 3 edits in branches/chromium/1410/Source/WebCore/inspector/front-end
Merge 142745
Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.
The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.
No new tests.
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12301008
- 2:31 AM Changeset in webkit [143182] by
-
- 3 edits in trunk/LayoutTests
Follow up to r143112, fixing tests.
Not reviewed.
- inspector/elements/insert-node-expected.txt:
- inspector/elements/insert-node.html:
- 2:30 AM Changeset in webkit [143181] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed speculative build fix for Apple Win bots.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 2:29 AM Changeset in webkit [143180] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove unused _files field in FileSystemProjectDelegate
https://bugs.webkit.org/show_bug.cgi?id=110082
Reviewed by Pavel Feldman.
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype._addFile):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
- 2:28 AM Changeset in webkit [143179] by
-
- 5 edits in trunk
Web Inspector: allow 0 as a formatted parameter in console message.
https://bugs.webkit.org/show_bug.cgi?id=110096
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):
LayoutTests:
- inspector/console/console-format.html:
- 2:20 AM Changeset in webkit [143178] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed speculative fix for Chromium Mac.
- WebCore.gypi:
- 2:15 AM Changeset in webkit [143177] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped failing tests.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 2:11 AM Changeset in webkit [143176] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 1:54 AM Changeset in webkit [143175] by
-
- 6 edits1 add in trunk
Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554
In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.
Reviewed by Yury Semikhatsky.
It is covered by newly added tests in TestWebKitAPI.
Source/WebCore:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
Tools:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):
- 1:30 AM Changeset in webkit [143174] by
-
- 9 edits in trunk
Unreviewed, rolling out r143100.
http://trac.webkit.org/changeset/143100
https://bugs.webkit.org/show_bug.cgi?id=110088
Breaks file system support in workspace. (Requested by vsevik
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-18
Source/WebCore:
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.projectForUISourceCode):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/uisourcecode-revisions.html:
- 1:27 AM Changeset in webkit [143173] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
Adding failure expectations for two tests that are failing on GTK and Qt,
most likely due to disabled subpixel layout.
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 1:26 AM Changeset in webkit [143172] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of StructureStubInfo.h
Rubber stamped by Mark Hahnenberg.
- bytecode/StructureStubInfo.h:
- 1:25 AM Changeset in webkit [143171] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix indentation of JSGlobalObject.h and JSGlobalObjectFunctions.h
Rubber stamped by Mark Hahnenberg.
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectFunctions.h:
- 1:20 AM Changeset in webkit [143170] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indention of Operations.h
Rubber stamped by Mark Hahnenberg.
- runtime/Operations.h:
- 1:16 AM Changeset in webkit [143169] by
-
- 3 edits2 deletes in trunk/LayoutTests
Unreviewed. Clean up a few EFL unexpected passes.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Removed.
- platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Removed.
- 1:16 AM Changeset in webkit [143168] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove DFG::SpeculativeJIT::isKnownNumeric(), since it's not called from anywhere.
Rubber stamped by Andy Estes.
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 1:11 AM Changeset in webkit [143167] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove DFG::SpeculativeJIT::isStrictInt32(), since it's not called from anywhere.
Rubber stampted by Andy Estes.
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 1:00 AM Changeset in webkit [143166] by
-
- 2 edits in branches/chromium/1364/Source/WebCore/Modules/mediastream
Merge 142887
MediaStream API: RTCDataChannel triggers a use-after-free
https://bugs.webkit.org/show_bug.cgi?id=109806
Reviewed by Adam Barth.
Making sure RTCPeerConnection::stop() is always called at least once.
Also making sure that RTCDataChannels state gets set to Closed correctly.
Hard to test in WebKit but covered by Chromium tests.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::stop):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::stop):
TBR=tommyw@google.com
Review URL: https://codereview.chromium.org/12301006
- 12:59 AM Changeset in webkit [143165] by
-
- 7 edits in trunk/Source/JavaScriptCore
Remove dead code for ValueToNumber from the DFG.
Rubber stamped by Andy Estes.
We killed ValueToNumber at some point, but forgot to kill all of the backend support
for it.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleMinMax):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- 12:59 AM Changeset in webkit [143164] by
-
- 2 edits4 deletes in trunk/LayoutTests
Unreviewed. Clean up a few EFL unexpected passes.
- platform/efl/TestExpectations:
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Removed.
- platform/efl/fast/repaint/caret-with-transformation-expected.png: Removed.
- platform/efl/fast/repaint/caret-with-transformation-expected.txt: Removed.
- 12:46 AM Changeset in webkit [143163] by
-
- 2 edits12 deletes in trunk/LayoutTests
Unreviewed. Remove invalid EFL results that were wrongly added in r140249.
- platform/efl/TestExpectations:
- platform/efl/fast/css/color-correction-on-background-image-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-background-image-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-backgrounds-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-box-shadow-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-text-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-text-expected.txt: Removed.
- platform/efl/fast/css/color-correction-on-text-shadow-expected.png: Removed.
- platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Removed.
- platform/efl/fast/css/color-correction-untagged-images-expected.png: Removed.
- platform/efl/fast/css/color-correction-untagged-images-expected.txt: Removed.
- 12:38 AM Changeset in webkit [143162] by
-
- 2 edits in trunk/Tools
WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 12:37 AM Changeset in webkit [143161] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskip several test cases that are now passing on
EFL port, most of them due to enabling subpixel layout.
- platform/efl/TestExpectations:
- 12:22 AM Changeset in webkit [143160] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unskip several compositing tests that are now
passing on WK2 EFL.
- platform/efl/TestExpectations:
Feb 17, 2013:
- 11:51 PM Changeset in webkit [143159] by
-
- 12 edits1 add in trunk
Web Inspector: Introduce ProfilesPanelDescriptor.
https://bugs.webkit.org/show_bug.cgi?id=109906
Reviewed by Pavel Feldman.
Source/WebCore:
Some constants/methods should be accesible before ProfilesPanel
is instantiated.
Extracted methods to check if profile is "user-initiated" and what is
its index.
Also profile URL regexp moved to ProfilesPanelDescriptor.
- inspector/front-end/ProfilesPanelDescriptor.js: Added.
- WebCore.gypi: Added ProfilesPanelDescriptor.js
- WebCore.vcproj/WebCore.vcproj: Ditto.
- inspector/compile-front-end.py: Ditto.
- inspector/front-end/WebKit.qrc: Ditto.
- inspector/front-end/inspector.html: Ditto.
- inspector/front-end/HeapSnapshotView.js: Adopted changes.
- inspector/front-end/ProfilesPanel.js: Ditto.
- inspector/front-end/externs.js: Ditto.
- inspector/front-end/inspector.js: Ditto.
LayoutTests:
- inspector/profiler/heap-snapshot-test.js: Adopted changes.
- 11:50 PM WebKit Team edited by
- (diff)
- 11:47 PM Changeset in webkit [143158] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 11:46 PM Changeset in webkit [143157] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update test expectation for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110079
- platform/chromium/TestExpectations:
- 11:44 PM Changeset in webkit [143156] by
-
- 7 edits in trunk/Tools
GCE EWS bots are all offline
https://bugs.webkit.org/show_bug.cgi?id=110069
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-17
Reviewed by Eric Seidel.
Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
- EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
- EWSTools/GoogleComputeEngine/build-commit-queue.sh:
- EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- EWSTools/build-vm.sh:
- EWSTools/start-queue.sh:
- 11:35 PM Changeset in webkit [143155] by
-
- 2 edits in trunk/LayoutTests
Add missing braces in fast/parser/noscript-with-javascript-enabled.html
https://bugs.webkit.org/show_bug.cgi?id=110078
Unreviewed gardening. Adding the missing braces.
- fast/parser/noscript-with-javascript-enabled.html:
- 11:25 PM WebKit Team edited by
- (diff)
- 11:18 PM Changeset in webkit [143154] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed buildfix for JSVALUE32_64 builds after r143147.
- jit/JIT.h:
- 10:50 PM Changeset in webkit [143153] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to commiters.py.
- Scripts/webkitpy/common/config/committers.py:
- 10:44 PM Changeset in webkit [143152] by
-
- 3 edits in trunk/Source/WebCore
Stop passing around SelectorChecker in SelectorQuery, now that it's stack-allocated.
https://bugs.webkit.org/show_bug.cgi?id=110038
Reviewed by Andreas Kling.
No functional changes, covered by existing tests.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::matches): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorDataList::queryAll): Got rid of unneeded SelectorChecker arg.
(WebCore::SelectorDataList::queryFirst): Ditto.
(WebCore::SelectorDataList::execute): Moved instantiation of SelectorChecker in here.
(WebCore::SelectorQuery::matches): Removed instantiation of SelectorChecker here.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.
- dom/SelectorQuery.h:
(WebCore): Tweaked headers to make SelectorChecker just an implementation detail.
(SelectorDataList): Tweaked decls to remove SelectorChecker args.
- 10:38 PM Changeset in webkit [143151] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update test expectation for chromium.
https://bugs.webkit.org/show_bug.cgi?id=110076
- platform/chromium/TestExpectations:
- 10:37 PM Changeset in webkit [143150] by
-
- 3 edits in trunk/Source/WebCore
Stop passing around SelectorChecker in ContentSelectorQuery.
https://bugs.webkit.org/show_bug.cgi?id=110041
Now that SelectorChecker has no interesting state, we can simplify ContentSelectorQuery and get rid of a class.
Reviewed by Andreas Kling.
No functional changes, covered by existing tests.
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorDataList::checkContentSelector): Zapped ContentSelectorChecker and moved its only remaining method here.
(WebCore::ContentSelectorDataList::matches): Removed SelectorChecker argument.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Removed an unnecessary member.
(WebCore::ContentSelectorQuery::matches): Removed unnecessary argument.
- html/shadow/ContentSelectorQuery.h:
(WebCore): Cleaned up the file.
(ContentSelectorDataList): Updated decls.
(ContentSelectorQuery): Ditto.
- 10:33 PM Changeset in webkit [143149] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 10:31 PM Changeset in webkit [143148] by
-
- 3 edits2 adds in trunk
WheelEvent should not target text nodes.
https://bugs.webkit.org/show_bug.cgi?id=109939
Reviewed by Darin Adler.
Source/WebCore:
WheelEvent, like other mouse events, should not target text nodes.
EventHandler correctly handles other mouse events by retargeting
events to text nodes' parents; this patch adds that logic to the
WheelEvent handler.
This should allow jQuery to stop working around WebKit's behavior[1].
[1]: https://github.com/jquery/jquery/commit/c61150427fc8ccc8e884df8f221a6c9bb5477929
Test: fast/events/wheelevent-in-text-node.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):
If a WheelEvent's hit test lands on a text node, retarget the
event to the text node's parent. Do this before latching the node.
LayoutTests:
- fast/events/wheelevent-in-text-node-expected.txt: Added.
- fast/events/wheelevent-in-text-node.html: Added.
- 10:28 PM Changeset in webkit [143147] by
-
- 35 edits4 adds in trunk/Source
Move all Structure out-of-line inline methods to StructureInlines.h
https://bugs.webkit.org/show_bug.cgi?id=110024
Source/JavaScriptCore:
Rubber stamped by Mark Hahnenberg and Sam Weinig.
This was supposed to be easy.
But, initially, there was a Structure inline method in CodeBlock.h, and moving that
into StructureInlines.h meant that Operations.h included CodeBlock.h. This would
cause WebCore build failures, because CodeBlock.h transitively included the JSC
parser (via many, many paths), and the JSC parser defines tokens using enumeration
elements that CSSGrammar.cpp (generated by bison) would #define. For example,
bison would give CSSGrammar.cpp a #define FUNCTION 123, and would do so before
including anything interesting. The JSC parser would have an enum that included
FUNCTION as an element. Hence the JSC parser included into CSSGrammar.cpp would have
a token element called FUNCTION declared in an enumeration, but FUNCTION was
#define'd to 123, leading to a parser error.
Wow.
So I removed all transitive include paths from CodeBlock.h to the JSC Parser. I
believe I was able to do so without out-of-lining anything interesting or performance
critical. This is probably a purely good thing to have done: it will be nice to be
able to make changes to the parser without having to compile the universe.
Of course, doing this caused a bunch of other things to not compile, since a bunch of
headers relied on things being implicitly included for them when they transitively
included the parser. I fixed a lot of that.
Finally, I ended up removing the method that depended on CodeBlock.h from
StructureInlines.h, and putting it in Structure.cpp. That might seem like all of this
was a waste of time, except that I suspect it was a worthwhile forcing function for
cleaning up a bunch of cruft.
- API/JSCallbackFunction.cpp:
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.h:
(JSC):
- bytecode/EvalCodeCache.h:
- bytecode/SamplingTool.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::parameterCount):
(JSC):
- bytecode/UnlinkedCodeBlock.h:
(UnlinkedFunctionExecutable):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/Label.h:
(JSC):
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGByteCodeParser.h:
- dfg/DFGFPRInfo.h:
- dfg/DFGRegisterBank.h:
- heap/HandleStack.cpp:
- jit/JITWriteBarrier.h:
- parser/Nodes.h:
(JSC):
- parser/Parser.h:
- parser/ParserError.h: Added.
(JSC):
(JSC::ParserError::ParserError):
(ParserError):
(JSC::ParserError::toErrorObject):
- parser/ParserModes.h:
- parser/SourceProvider.cpp: Added.
(JSC):
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):
- parser/SourceProvider.h:
(JSC):
(SourceProvider):
- runtime/ArrayPrototype.cpp:
- runtime/DatePrototype.cpp:
- runtime/Executable.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
(JSC):
- runtime/Operations.h:
- runtime/Structure.cpp:
(JSC::Structure::prototypeForLookup):
(JSC):
- runtime/Structure.h:
(JSC):
- runtime/StructureInlines.h: Added.
(JSC):
(JSC::Structure::create):
(JSC::Structure::createStructure):
(JSC::Structure::get):
(JSC::Structure::masqueradesAsUndefined):
(JSC::SlotVisitor::internalAppend):
(JSC::Structure::transitivelyTransitionedFrom):
(JSC::Structure::setEnumerationCache):
(JSC::Structure::enumerationCache):
(JSC::Structure::prototypeForLookup):
(JSC::Structure::prototypeChain):
(JSC::Structure::isValid):
- runtime/StructureRareData.cpp:
Source/WebCore:
Rubber stamped by Sam Weinig.
No new tests because no new behavior. Just rewiring includes.
- ForwardingHeaders/parser/SourceProviderCache.h: Added.
- loader/cache/CachedScript.cpp:
- 10:02 PM WebKit Team edited by
- (diff)
- 9:53 PM Changeset in webkit [143146] by
-
- 3 edits in trunk/Source/WebKit2
Remove unnecessary public method DrawingAreaImpl::createGraphicsContext()
https://bugs.webkit.org/show_bug.cgi?id=109893
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-17
Reviewed by Anders Carlsson.
DrawingAreaImpl::createGraphicsContext() is unnecessary since
createGraphicsContext can be called directly using ShareableBitmap.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- 9:51 PM Changeset in webkit [143145] by
-
- 7 edits in trunk/Source/WebCore
Make EventDispatcher take an Event object in its constructor.
https://bugs.webkit.org/show_bug.cgi?id=109898
Reviewed by Dimitri Glazkov.
That makes EventDispatcher more RAII-like so that we can calculate
an EventPath in its constructor. I'll remove
EventDispatcher::ensureEventPath() in a following patch.
No tests. No change in behavior.
- dom/EventDispatchMediator.cpp:
(WebCore::EventDispatchMediator::dispatchEvent):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::ensureEventPath):
(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPreProcess):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
(EventDispatcher):
(WebCore::EventDispatcher::node):
(WebCore::EventDispatcher::event):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- 9:38 PM Changeset in webkit [143144] by
-
- 3 edits2 adds in trunk
Fix non-root SVG viewport under zoom
https://bugs.webkit.org/show_bug.cgi?id=99453
Reviewed by Dirk Schulze.
Source/WebCore:
The root SVG element handles zoom differently than other SVG nodes because it needs
to translate between CSS (where zoom is applied to all units) and SVG (where zoom is only
applied at the top level). A good description of this difference can be found here:
http://trac.webkit.org/browser/trunk/Source/WebCore/css/StyleResolver.cpp?rev=142855#L2598
SVG elements can appear as children in the SVG tree as well, and in this mode
SVGSVGElement should not consider the current zoom level. This patch fixes a bug
where non-root viewport calculations were removing zoom.
Test: svg/custom/symbol-zoom.html
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentViewportSize):
This change removes the unnecessary zoom calculation for non-root nodes. This is similar
to how zoom is handled elsewhere, e.g., SVGSVGElement::localCoordinateSpaceTransform.
LayoutTests:
- svg/custom/symbol-zoom-expected.html: Added.
- svg/custom/symbol-zoom.html: Added.
- 9:31 PM WebKit Team edited by
- (diff)
- 9:30 PM Changeset in webkit [143143] by
-
- 2 edits5 adds in trunk/Source/WebCore
AX: Upstream iOS Accessibility files
https://bugs.webkit.org/show_bug.cgi?id=110071
Reviewed by David Kilzer.
Upstream the iOS Accessibility files for WebCore.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/ios: Added.
- accessibility/ios/AXObjectCacheIOS.mm: Added.
(WebCore):
(WebCore::AXObjectCache::detachWrapper):
(WebCore::AXObjectCache::attachWrapper):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleScrolledToAnchor):
- accessibility/ios/AccessibilityObjectIOS.mm: Added.
(-[WAKView accessibilityIsIgnored]):
(WebCore):
(WebCore::AccessibilityObject::detachFromParent):
(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/ios/AccessibilityObjectWrapperIOS.h: Added.
(WAKView):
- accessibility/ios/AccessibilityObjectWrapperIOS.mm: Added.
(AccessibilityUnignoredAncestor):
(-[WebAccessibilityTextMarker initWithTextMarker:cache:]):
(-[WebAccessibilityTextMarker initWithData:cache:]):
(-[WebAccessibilityTextMarker initWithData:accessibilityObject:]):
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityObjectWrapper initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper dealloc]):
(-[WebAccessibilityObjectWrapper _prepareAccessibilityCall]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityPostProcessHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityLanguage]):
(-[WebAccessibilityObjectWrapper _accessibilityIsLandmarkRole:]):
(-[WebAccessibilityObjectWrapper _accessibilityListAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityLandmarkAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper isAccessibilityElement]):
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper tableCellParent]):
(-[WebAccessibilityObjectWrapper tableParent]):
(-[WebAccessibilityObjectWrapper accessibilityTitleElement]):
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityElementForRow:andColumn:]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
(-[WebAccessibilityObjectWrapper accessibilityPlaceholderValue]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
(-[WebAccessibilityObjectWrapper accessibilityIsComboBox]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
(-[WebAccessibilityObjectWrapper accessibilityURL]):
(-[WebAccessibilityObjectWrapper _convertIntRectToScreenCoordinates:]):
(-[WebAccessibilityObjectWrapper accessibilityElementRect]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper _accessibilityWebDocumentView]):
(-[WebAccessibilityObjectWrapper _accessibilityNextElementsWithCount:]):
(-[WebAccessibilityObjectWrapper _accessibilityPreviousElementsWithCount:]):
(-[WebAccessibilityObjectWrapper accessibilityRequired]):
(-[WebAccessibilityObjectWrapper accessibilityFlowToElements]):
(-[WebAccessibilityObjectWrapper accessibilityLinkedElement]):
(-[WebAccessibilityObjectWrapper isAttachment]):
(-[WebAccessibilityObjectWrapper _accessibilityActivate]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper postFocusChangeNotification]):
(-[WebAccessibilityObjectWrapper postSelectedTextChangeNotification]):
(-[WebAccessibilityObjectWrapper postLayoutChangeNotification]):
(-[WebAccessibilityObjectWrapper postLiveRegionChangeNotification]):
(-[WebAccessibilityObjectWrapper postLoadCompleteNotification]):
(-[WebAccessibilityObjectWrapper postChildrenChangedNotification]):
(-[WebAccessibilityObjectWrapper postInvalidStatusChangedNotification]):
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
(-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]):
(-[WebAccessibilityObjectWrapper accessibilityIncreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityDecreaseSelection:]):
(-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]):
(-[WebAccessibilityObjectWrapper accessibilityIncrement]):
(-[WebAccessibilityObjectWrapper accessibilityDecrement]):
(-[WebAccessibilityObjectWrapper _addAccessibilityObject:toTextMarkerArray:]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(blockquoteLevel):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetFont):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _convertToDOMRange:]):
(-[WebAccessibilityObjectWrapper positionForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRange]):
(-[WebAccessibilityObjectWrapper elementTextRange]):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper textMarkerForPosition:]):
(-[WebAccessibilityObjectWrapper _stringForRange:attributed:]):
(-[WebAccessibilityObjectWrapper stringForRange:]):
(-[WebAccessibilityObjectWrapper attributedStringForRange:]):
(-[WebAccessibilityObjectWrapper elementsForRange:]):
(-[WebAccessibilityObjectWrapper selectionRangeString]):
(-[WebAccessibilityObjectWrapper selectedTextMarker]):
(-[WebAccessibilityObjectWrapper lineEndMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper lineStartMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper nextMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper previousMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):
(-[WebAccessibilityObjectWrapper textMarkerForPoint:]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
(-[WebAccessibilityObjectWrapper accessibilitySpeechHint]):
(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIARelevantStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilityInvalidStatus]):
(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
(-[WebAccessibilityObjectWrapper accessibilitySetPostedNotificationCallback:withContext:]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:WebCore::AXObjectCache::]):
(-[WebAccessibilityObjectWrapper description]):
- 7:34 PM Changeset in webkit [143142] by
-
- 4 edits2 moves2 adds in trunk/Source/WebCore
AX: rename WebAccessibilityObjectWrapper to WebAccessibilityObjectWrapperBase
https://bugs.webkit.org/show_bug.cgi?id=110061
Reviewed by David Kilzer.
Rename the base accessibility wrapper class so that the iOS class can share the same name.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
- accessibility/mac/WebAccessibilityObjectWrapper.h: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.h.
- accessibility/mac/WebAccessibilityObjectWrapper.mm: Replaced with Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm.
- accessibility/mac/WebAccessibilityObjectWrapperBase.h: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.h.
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Copied from Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm.
- accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed.
- 7:33 PM Changeset in webkit [143141] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Windows build fix.
- runtime/CodeCache.h:
(CodeCacheMap):
- 7:13 PM Changeset in webkit [143140] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix typo in script.
- EWSTools/start-queue-win.sh:
- 5:58 PM Changeset in webkit [143139] by
-
- 2 edits in trunk/Tools
Pass in bot name as parameter to start-queue-win script.
https://bugs.webkit.org/show_bug.cgi?id=109998.
Reviewed by Darin Adler.
- EWSTools/start-queue-win.sh:
- 5:25 PM Changeset in webkit [143138] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 3:26 PM Changeset in webkit [143137] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler.
<http://webkit.org/b/108835>
Reviewed by Ojan Vafai.
Streamline the case where GlyphPage has a per-glyph SimpleFontData* lookup table to allow
taking earlier branches on pages with lots of mixed-font text.
We accomplish this by explicitly storing a null SimpleFontData* for glyph #0 in the per-glyph
lookup table instead of relying on "if (!glyph)" checks in getters.
This is a speculative optimization, I can't get stable enough numbers locally to tell if this
will resolve the issue on the bots.
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
- 12:57 PM Changeset in webkit [143136] by
-
- 17 edits2 adds in trunk
WebSpeech: plumb through a method to generate fake speech jobs for testing
https://bugs.webkit.org/show_bug.cgi?id=107351
Reviewed by Adam Barth.
Source/WebCore:
We can't reliably use the platforms synthesizer to test speech synthesis internals.
This patch adds an Internals method to enable a mock synthesizer, which is inherits
from the PlatformSpeechSythesizer.
The fake synthesizer goes through all the motions of a real synthesizer but doesn't do anything.
A bunch of changes were needed here to make PlatformSpeechSynthesizer subclassable so that the
right virtual are used.
The Mock synthesizer only lives in WebCoreTestSupport. Because PlatformSpeechSynthesizer uses
a RetainPtr, I needed to make WebCoreTestSupport link CoreFoundation
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
- platform/mac/fast/speechsynthesis/speech-synthesis-voices.html:
- 12:05 PM Changeset in webkit [143135] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark compositing/layer-creation/fixed-position-out-of-view-scaled.html as
flaky on WebKit2 EFL. It sometimes hits an assertion.
- platform/efl-wk2/TestExpectations:
- 11:55 AM Changeset in webkit [143134] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Remove fullscreen manager proxy as a message receiver on invalidate()
https://bugs.webkit.org/show_bug.cgi?id=109451
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-17
Reviewed by Anders Carlsson.
Remove fullscreen manager proxy as a message receiver on invalidate(), like
other ports do after r142160.
- UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):
- 11:15 AM Changeset in webkit [143133] by
-
- 5 edits in trunk/Source/JavaScriptCore
Code cache should be explicit about what it caches
https://bugs.webkit.org/show_bug.cgi?id=110039
Reviewed by Oliver Hunt.
This patch makes the code cache more explicit in two ways:
(1) The cache caches top-level scripts. Any sub-functions executed as a
part of a script are cached with it and evicted with it.
This simplifies things by eliminating out-of-band sub-function tracking,
and fixes pathological cases where functions for live scripts would be
evicted in favor of functions for dead scripts, and/or high probability
functions executed early in script lifetime would be evicted in favor of
low probability functions executed late in script lifetime, due to LRU.
Statistical data from general browsing and PLT confirms that caching
functions independently of scripts is not profitable.
(2) The cache tracks script size, not script count.
This reduces the worst-case cache size by a factor of infinity.
Script size is a reasonable first-order estimate of in-memory footprint
for a cached script because there are no syntactic constructs that have
super-linear memory footprint.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock): Moved this function out of the cache
because it does not consult the cache, and is not managed by it.
(JSC::UnlinkedFunctionExecutable::visitChildren): Visit our code blocks
because they are strong references now, rather than weak, a la (1).
(JSC::UnlinkedFunctionExecutable::codeBlockFor): Updated for interface changes.
- bytecode/UnlinkedCodeBlock.h:
(UnlinkedFunctionExecutable):
(UnlinkedFunctionCodeBlock): Strong now, not weak, a la (1).
- runtime/CodeCache.cpp:
(JSC::CodeCache::CodeCache):
- runtime/CodeCache.h:
(JSC::SourceCodeKey::length):
(SourceCodeKey):
(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::find):
(JSC::CodeCacheMap::set):
(JSC::CodeCacheMap::clear):
(CodeCache):
(JSC::CodeCache::clear): Removed individual function tracking, due to (1).
Added explicit character counting, for (2).
You might think 16000000 characters is a lot. It is. But this patch
didn't establish that limit -- it just took the existing limit and
made it more visible. I intend to reduce the size of the cache in a
future patch.
- 10:59 AM Changeset in webkit [143132] by
-
- 4 edits in trunk
Regression(r143124): Caused plugins/plugin-javascript-access.html to fail
https://bugs.webkit.org/show_bug.cgi?id=110053
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Clear m_plugins in loadPluginsIfNecessary() before populating the
vector again. We get duplicates otherwise.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
LayoutTests:
Unskip plugins/plugin-javascript-access.html for WK2 EFL now that the
Test is passing again.
- platform/efl-wk2/TestExpectations:
- 10:53 AM Changeset in webkit [143131] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Remove duplicates from EFL port's TestExpectations.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 7:39 AM Changeset in webkit [143130] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Generate baseline for svg/filters/filter-hidden-content.svg on EFL
port.
- platform/efl/svg/filters/filter-hidden-content-expected.png: Added.
- platform/efl/svg/filters/filter-hidden-content-expected.txt: Added.
- 7:35 AM Changeset in webkit [143129] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark compositing/geometry/limit-layer-bounds-fixed.html as failing on
EFL WK2. This test was introduced in r143073 but never passed on EFL.
- platform/efl-wk2/TestExpectations:
- 7:19 AM Changeset in webkit [143128] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark plugins/plugin-javascript-access.html as failing on WK2 EFL
due to a regression in r143124.
- platform/efl-wk2/TestExpectations:
- 1:14 AM Changeset in webkit [143127] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed buildfix for !USE(LIBXML) builds after r143112.
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
- 12:50 AM FeatureFlags edited by
- See r142533 (diff)
- 12:44 AM Changeset in webkit [143126] by
-
- 2 edits in trunk/Tools
Rename new-commit-bot to WKR to disambiguate it from commit-queue.
Rubber-stamped by Andreas Kling.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.begin_work_queue):
- 12:17 AM Changeset in webkit [143125] by
-
- 4 edits in trunk/Source/WebCore
Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>
Reviewed by Antti Koivisto.
Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.
If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.
This was landed before with some bogus branch prediction hints and didn't fare well on
page cyclers (intl2 specifically.) These have been removed this time around, and will
hopefully be regression-free.
4.98 MB progression on Membuster3.
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.
(WebCore::GlyphPage::setGlyphDataForIndex):
Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.
(WebCore::GlyphPage::~GlyphPage):
Free the SimpleFontData* array if needed.
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
The font data for glyph #0 is always a null pointer now.
(WebCore::GlyphPage::clearForFontData):
Updated for new storage format.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
Fix bug where non-zero glyph was temporarily associated with null font data,
which triggered the new assertion in setGlyphDataForIndex().
Feb 16, 2013:
- 10:01 PM Changeset in webkit [143124] by
-
- 6 edits in trunk/Source
Source/WebCore: Remove multi-threading gunk from WebKit2's PluginInfoStore.
<http://webkit.org/b/110046>
Reviewed by Alexey Proskuryakov.
Remove now-unused code for making deep (isolated) copies of WebCore plugin structures.
- plugins/PluginData.h:
(MimeClassInfo):
(PluginInfo):
Source/WebKit2: Remove multi-threading gunk from PluginInfoStore.
<http://webkit.org/b/110046>
Reviewed by Alexey Proskuryakov.
PluginInfoStore is never accessed from multiple threads anymore, so remove the Mutex locking
and stop making isolated copies of everything.
- Shared/Plugins/PluginModuleInfo.h:
(PluginModuleInfo):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
(WebKit::PluginInfoStore::infoForPluginWithPath):
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
- 9:42 PM Changeset in webkit [143123] by
-
- 2 edits in trunk/Source/WebCore
Identifier generated twice in FrameLoader::loadResourceSynchronously()
https://bugs.webkit.org/show_bug.cgi?id=110022
Reviewed by Darin Adler.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Fix an apparent refactoring mistake.
- 9:36 PM Changeset in webkit [143122] by
-
- 8 edits1 delete in trunk/Source/JavaScriptCore
Remove support for bytecode comments, since it doesn't build, and hasn't been used in a while.
https://bugs.webkit.org/show_bug.cgi?id=110035
Rubber stamped by Andreas Kling.
There are other ways of achieving the same effect, like adding print statements to the bytecode generator.
The fact that this feature doesn't build and nobody noticed implies that it's probably not a popular
feature. As well, the amount of wiring that was required for it was quite big considering its relatively
modest utility.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/Comment.h: Removed.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitOpcode):
(JSC):
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
(JSC::BytecodeGenerator::symbolTable):
- 9:19 PM Changeset in webkit [143121] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- 8:08 PM Changeset in webkit [143120] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed Visual Studio 2010 build fix after r143117
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Reference new path to property sheets.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Build correction after new operator == added.
- 5:03 PM Changeset in webkit [143119] by
-
- 3 edits in trunk/Tools
new-commit-bot should report the full name of committer and reviewer instead of just nicks
https://bugs.webkit.org/show_bug.cgi?id=110040
Reviewed by Darin Adler.
Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot):
(NewCommitBot._summarize_commit_log):
- Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
- 5:02 PM Changeset in webkit [143118] by
-
- 3 edits in trunk/Source/WebCore
[JSC] Remove custom mark function for NamedNodeMap.
<http://webkit.org/b/110029>
Reviewed by Darin Adler.
NamedNodeMap refs and unrefs its Element owner, so there's no need for the wrapper to keep the Element alive.
Covered by fast/dom/Attr/access-after-element-destruction.html
- bindings/js/JSNamedNodeMapCustom.cpp:
- dom/NamedNodeMap.idl:
- 4:11 PM Changeset in webkit [143117] by
-
- 2 edits in trunk/Source/WebKit2
Fix non-production builds.
- WebKit2.xcodeproj/project.pbxproj:
- 3:51 PM Changeset in webkit [143116] by
-
- 2 edits in trunk/Source/WTF
Remove redundant use of inline keyword in StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=110036
Reviewed by Geoffrey Garen.
I have some other improvements for StringHasher.h, but wanted to get the simplest ones
out of the way first.
- wtf/StringHasher.h: Remove inline keyword on functions inside the class definition,
since functions defined inside the class are automatically inline.
- 3:47 PM Changeset in webkit [143115] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r143076): Crash when calling removeNamedItem or removeNamedItemNS with a non-existent attribute of newly created element.
<http://webkit.org/b/110019>
Patch by Peter Nelson <peter@peterdn.com> on 2013-02-16
Reviewed by Andreas Kling.
Now checks Element::hasAttributes() before calling Element::getAttributeItemIndex().
Test: http/tests/misc/acid3.html
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
- 3:34 PM Changeset in webkit [143114] by
-
- 9 edits in trunk/Source/WebCore
Element: Devirtualize attribute synchronization functions.
<http://webkit.org/b/110033>
Reviewed by Darin Adler.
Devirtualize the functions that perform re-serialization of lazy attributes and give
them "synchronize"-style names:
- SVGElement::synchronizeAnimatedSVGAttribute()
- StyledElement::synchronizeStyleAttributeInternal()
- dom/Element.cpp:
(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
- dom/Element.h:
- dom/StyledElement.cpp:
(WebCore::StyledElement::synchronizeStyleAttribute):
- dom/StyledElement.h:
(StyledElement):
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::applyResource):
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
- svg/SVGElement.cpp:
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):
- svg/SVGElement.h:
(SVGElement):
- 3:02 PM Changeset in webkit [143113] by
-
- 2 edits1 delete in trunk/Source/WebKit2
The Plugin.32 target does not build
https://bugs.webkit.org/show_bug.cgi?id=110032
Reviewed by Anders Carlsson.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm: Removed.
This was meant to be removed already.
- WebKit2.xcodeproj/project.pbxproj:
Add Plugin.32 as dependency in All as it should be.
- 2:57 PM Changeset in webkit [143112] by
-
- 4 edits in trunk/Source/WebCore
Element: Avoid unrelated attribute synchronization on other attribute access.
<http://webkit.org/b/110025>
Reviewed by Darin Adler.
We've been extremely trigger happy with re-serializing the style attribute (and SVG animatables)
whenever any Element attribute API was used. This patch narrows this down to (almost always)
only synchronizing an attribute when someone specifically wants to read/update it.
Also removed two more confusing ElementData accessors:
- Element::elementDataWithSynchronizedAttributes()
- Element::ensureElementDataWithSynchronizedAttributes()
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::synchronizeAllAttributes):
Renamed updateInvalidAttributes() to synchronizeAllAttributes().
This function should only be used when we need every single attribute to be up-to-date.
(WebCore::Element::synchronizeAttribute):
Broke out logic for synchronizing a specific attribute, given either a full QualifiedName
or a localName.
(WebCore::Element::setSynchronizedLazyAttribute):
Don't call ensureUniqueElementData() indisciminately here. This avoids converting the attribute
storage when re-serializing the inline style yields the same CSS text that was already in the
style attribute.
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::getAttribute):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
Only synchronize the attribute in question.
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
Call synchronizeAllAttributes() when comparing two Attr nodes on the same Element instead
of relying on the side-effects of another function doing this.
- 2:27 PM Changeset in webkit [143111] by
-
- 3 edits in trunk/Source/WebKit2
Fix WKDOMRangePrivate.h mistakes
https://bugs.webkit.org/show_bug.cgi?id=110028
Reviewed by Ryosuke Niwa.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
Added include of WKDOMRangePrivate.h.
- WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h:
Fixed class name and include to be WKDOMRange.
Fixed method name, _copyBundleRangeHandleRef, to match the
name in the source file.
- 2:24 PM Changeset in webkit [143110] by
-
- 2 edits in trunk/LayoutTests
Add a flaky image only failure expectation to the test added in r142979 on Mac per bug 110027.
- platform/mac/TestExpectations:
- 1:57 PM Changeset in webkit [143109] by
-
- 8 edits2 adds in trunk/Tools
We need a CIA replacement
https://bugs.webkit.org/show_bug.cgi?id=110008
Reviewed by Andreas Kling.
Added new-commit-bot.
- Scripts/webkitpy/tool/bot/queueengine.py:
(QueueEngine.init):
(QueueEngine): Made the sleep tiem configurable.
(QueueEngine._sleep_message):
(QueueEngine._sleep):
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
(QueueEngineTest.test_sleep_message):
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
(PingPong): Added. Implements the ping pong protocol.
(NewCommitBot):
(NewCommitBot.begin_work_queue):
(NewCommitBot.work_item_log_path):
(NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
the last time we checked the head SVN revision.
(NewCommitBot.process_work_item):
(NewCommitBot._update_checkout): svn up.
(NewCommitBot._new_svn_revisions): Returns a range of new revisions.
(NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
(NewCommitBot.handle_unexpected_error):
(NewCommitBot.handle_script_error):
- Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
(NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
(NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.execute):
- Scripts/webkitpy/tool/commands/queuestest.py:
(MockQueueEngine.init):
- Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
(SheriffBotTest.test_command_aliases):
- Scripts/webkitpy/tool/main.py:
(WebKitPatch):
- 1:00 PM Changeset in webkit [143108] by
-
- 2 edits in trunk/Source/WebCore
Fix build warnings after r139853
https://bugs.webkit.org/show_bug.cgi?id=109929
Patch by Seokju Kwon <Seokju Kwon> on 2013-02-16
Reviewed by Alexey Proskuryakov.
Use UNUSED_PARAM macro to fix build warning -Wunused-parameter
when INSPECTOR is disabled.
No new tests, no behavior change.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
- 12:07 PM Changeset in webkit [143107] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of Structure.h
Rubber stamped by Mark Hahnenberg.
- runtime/Structure.h:
- 10:27 AM Changeset in webkit [143106] by
-
- 3 edits in trunk/Tools
[chromium] initialize all variables of TestRunner classes
https://bugs.webkit.org/show_bug.cgi?id=110013
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- 10:08 AM Changeset in webkit [143105] by
-
- 2 edits in trunk/Tools
[chromium] destroy the TestPlugin when the destroy() method is invoked.
https://bugs.webkit.org/show_bug.cgi?id=110012
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::destroy):
- 9:09 AM Changeset in webkit [143104] by
-
- 11 edits3 deletes in trunk
Unreviewed, rolling out r142734.
http://trac.webkit.org/changeset/142734
https://bugs.webkit.org/show_bug.cgi?id=110018
"Triggered crashes on lots of websites" (Requested by ggaren
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-16
Source/WebCore:
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
LayoutTests:
- http/tests/plugins/resources/cross-frame-object-access.html:
- http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
- http/tests/security/cross-frame-access-location-get-expected.txt:
- http/tests/security/cross-frame-access-location-get.html:
- http/tests/security/resources/cross-frame-access.js:
- http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
- http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:
- http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
- platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Removed.
- platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Removed.
- platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Removed.
- 8:35 AM Changeset in webkit [143103] by
-
- 2 edits1 delete in trunk/LayoutTests
Rebaseline for Win7.
Unreviewed chromium gardening.
- platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- 5:06 AM Changeset in webkit [143102] by
-
- 5 edits10 adds in trunk
percentage top value of position:relative element not calculated using parent's min-height unless height set
https://bugs.webkit.org/show_bug.cgi?id=14762
Reviewed by Julien Chaffraix.
Source/WebCore:
Percentage height "is calculated with respect to the height of the generated box's containing block" says
http://www.w3.org/TR/CSS21/visudet.html#the-height-property and "If the height of the containing block is not
specified explicitly (i.e., it depends on content height), and this element is not absolutely positioned, the
value computes to 'auto'." So when calculating the used height of a replaced element do not crawl through ancestor
blocks except when traversing anonymous blocks. Ensure that anonymous table cells are not skipped through though.
http://www.w3.org/TR/CSS21/tables.html#height-layout adds "In CSS 2.1, the height of a cell box is the minimum
height required by the content." This height is decided by allowing table cells to report their height as auto.
It's not clear why http://trac.webkit.org/changeset/91242 decided it should no longer do this - doing so caused
us to regress in our rendering of computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html.
Tests: fast/block/percent-top-parent-respects-min-height.html
fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr.html
fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html
fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr.html
fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):
(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffset):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::hasReplacedLogicalHeight):
LayoutTests:
- fast/block/percent-top-parent-respects-min-height-expected.txt: Added.
- fast/block/percent-top-parent-respects-min-height.html: Added.
- fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-expected.txt: Added.
- fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr-expected.txt: Added.
- fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor-vertical-lr.html: Added.
- fast/replaced/computed-image-width-with-percent-height-and-fixed-ancestor.html: Added.
- fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-expected.txt: Added.
- fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr-expected.txt: Added.
- fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor-vertical-lr.html: Added.
- fast/replaced/computed-image-width-with-percent-height-inside-table-cell-and-fixed-ancestor.html: Added.
- 4:45 AM Changeset in webkit [143101] by
-
- 7 edits1 add in trunk
[skia] FEOffset should have a Skia implementation.
https://bugs.webkit.org/show_bug.cgi?id=109831
Reviewed by James Robinson.
Source/WebCore:
Covered by css3/filters/effect-reference.html and -hw.html.
- WebCore.gypi:
- platform/graphics/filters/FEOffset.h: Implement createImageFilter()
for the Skia path.
- platform/graphics/filters/skia/FEOffsetSkia.cpp: Added.
(WebCore::FEOffset::createImageFilter):
Instantiate an SkOffsetImageFilter when building the Skia DAG.
LayoutTests:
- css3/filters/effect-reference-hw.html:
- css3/filters/effect-reference.html:
- platform/chromium/TestExpectations:
- 3:28 AM Changeset in webkit [143100] by
-
- 9 edits in trunk
Web Inspector: Create separate project for each domain for UISourceCode based on browser resources.
https://bugs.webkit.org/show_bug.cgi?id=109691
Reviewed by Pavel Feldman.
Source/WebCore:
Separate project of certain type is now created for each domain.
UISourceCode path represents a path in the project now.
UISourceCode uri is now calculated based on project id and path.
It is also possible to calculate path based on projectId and URI, which is used for uiSourceCodeForURI() methods.
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.projectId):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.splitURL):
(WebInspector.SimpleWorkspaceProvider._pathForSplittedURL):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._projectDelegate):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFile):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFileByName):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.uri):
(WebInspector.UISourceCode.path):
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/uisourcecode-revisions.html:
- 12:46 AM Changeset in webkit [143099] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix.
Export symbol for new CString operator== operator to fix Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Feb 15, 2013:
- 11:36 PM WikiStart edited by
- (diff)
- 11:35 PM JavaScriptCore edited by
- (diff)
- 10:15 PM WebKit Team edited by
- added new committer silvia (diff)
- 9:56 PM Changeset in webkit [143098] by
-
- 5 edits2 copies in trunk/Source/WebCore
AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
https://bugs.webkit.org/show_bug.cgi?id=109849
Reviewed by David Kilzer.
Split up the WebAccessibilityObjectWrapper so that iOS can share more
code with MacOS. I imagine over time, more code will move into this base class,
but for now this will be a good start.
A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
of that. iOS will be able to do the same.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
- accessibility/mac/WebAccessibilityObjectWrapper.h:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Added.
(std):
(-[WebAccessibilityObjectWrapperMac detach]):
(-[WebAccessibilityObjectWrapperMac attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
(-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
(-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapperMac position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapperMac role]):
(-[WebAccessibilityObjectWrapperMac subrole]):
(-[WebAccessibilityObjectWrapperMac roleDescription]):
(-[WebAccessibilityObjectWrapperMac scrollViewParent]):
(-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
(-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
(-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
(-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):
- 9:31 PM Changeset in webkit [143097] by
-
- 4 edits in trunk/Source/JavaScriptCore
Structure should be more methodical about the relationship between m_offset and m_propertyTable
https://bugs.webkit.org/show_bug.cgi?id=109978
Reviewed by Mark Hahnenberg.
Allegedly, the previous relationship was that either m_propertyTable or m_offset
would be set, and if m_propertyTable was not set you could rebuild it. In reality,
we would sometimes "reset" both: some transitions wouldn't set m_offset, and other
transitions would clear the previous structure's m_propertyTable. So, in a
structure transition chain of A->B->C you could have:
A transitions to B: B doesn't copy m_offset but does copy m_propertyTable, because
that seemed like a good idea at the time (this was a common idiom in the code).
B transitions to C: C steals B's m_propertyTable, leaving B with neither a
m_propertyTable nor a m_offset.
Then we would ask for the size of the property storage of B and get the answer
"none". That's not good.
Now, there is a new relationship, which, hopefully, should fix things: m_offset is
always set and always refers to the maximum offset ever used by the property table.
From this, you can infer both the inline and out-of-line property size, and
capacity. This is accomplished by having PropertyTable::add() take a
PropertyOffset reference, which must be Structure::m_offset. It will update this
offset. As well, all transitions now copy m_offset. And we frequently assert
(using RELEASE_ASSERT) that the m_offset matches what m_propertyTable would tell
you. Hence if you ever modify the m_propertyTable, you'll also update the offset.
If you ever copy the property table, you'll also copy the offset. Life should be
good, I think.
- runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::add):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::checkConsistency):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::PropertyTable::checkConsistency):
- runtime/Structure.h:
(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::outOfLineSize):
(JSC::Structure::isEmpty):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(Structure):
(JSC::Structure::checkOffsetConsistency):
- 9:19 PM Changeset in webkit [143096] by
-
- 8 edits in trunk/Source
[Mac] remove wkCaptionAppearance from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=109996
Patch by Eric Carlson <eric.carlson@apple.com> on 2013-02-15
Reviewed by Simon Fraser.
Source/WebCore:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 8:31 PM Changeset in webkit [143095] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r143088.
http://trac.webkit.org/changeset/143088
https://bugs.webkit.org/show_bug.cgi?id=110000
Breaks the build (Requested by dgorbik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15
Source/WebCore:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 7:47 PM Changeset in webkit [143094] by
-
- 3 edits in trunk/Source/WebCore
Enhance AudioBus copyFrom() and sumFrom() to be able to handle discrete and speakers up and down-mixing
https://bugs.webkit.org/show_bug.cgi?id=109983
Reviewed by Kenneth Russell.
The Web Audio spec has a more detailed explanation for how channels are to be up and down-mixed:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#UpMix
This patch adds the initial support for handling ChannelInterpretation, although no
new JS API is yet implemented.
No new tests since no new APIs have yet been exposed.
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::copyFrom):
(WebCore):
(WebCore::AudioBus::sumFrom):
(WebCore::AudioBus::speakersCopyFrom):
(WebCore::AudioBus::speakersSumFrom):
(WebCore::AudioBus::discreteCopyFrom):
(WebCore::AudioBus::discreteSumFrom):
- platform/audio/AudioBus.h:
(AudioBus):
- 7:26 PM Changeset in webkit [143093] by
-
- 5 edits3 moves in trunk/Source
[GTK] Spread the gyp build files throughout the tree
https://bugs.webkit.org/show_bug.cgi?id=109960
Reviewed by Dirk Pranke.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Renamed from Source/WebKit/gtk/gyp/JavaScriptCore.gyp.
- JavaScriptCore.gyp/generate-derived-sources.sh: Renamed from Source/WebKit/gtk/gyp/generate-derived-sources.sh.
Source/WebKit/gtk:
- gyp/Configuration.gypi.in: Remove the 'Source', since now it cannot be shared.
- gyp/run-gyp: Update the path to the JavaScriptCore gypfile.
Source/WTF:
- WTF.gyp/WTFGTK.gyp: Renamed from Source/WebKit/gtk/gyp/WTF.gyp.
- 7:06 PM Changeset in webkit [143092] by
-
- 4 edits2 adds in trunk
Padding and border changes doesn't trigger relayout of children
https://bugs.webkit.org/show_bug.cgi?id=109639
Reviewed by Kent Tamura.
Source/WebCore:
In RenderBlock::layoutBlock, we only relayout our children if our logical width
changes. This misses cases where our logical width doesn't change (i.e., padding
or border changes), but our content width does change.
Also convert the needsLayout ASSERT into the if statement. This is because
RenderScrollbarPart can change border widths and not need a layout if the scrollbar
doesn't have a parent. In this case, we don't need to set any children for layout.
This is a more general case of bug 104997.
Test: fast/block/dynamic-padding-border.html
- rendering/RenderBox.cpp:
(WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
(WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
even without border-box box sizing.
LayoutTests:
- fast/block/dynamic-padding-border-expected.txt: Added.
- fast/block/dynamic-padding-border.html: Added.
- fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying
out the table when the border changed. The pixel results in this case is the same, but the
render tree shows the difference.
- 7:06 PM Changeset in webkit [143091] by
-
- 2 edits in trunk/Source/WebKit2
Disable sudden termination on Mac
https://bugs.webkit.org/show_bug.cgi?id=109990
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-15
Reviewed by Mark Rowe.
Sudden Termination is causing WebContent XPC services to be killed in
response to memory pressure. Hence, disable it until we can identify
if it is being enabled in error or not.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize): Add call to
[NSProcessInfo disableSuddenTermination].
- 7:03 PM Changeset in webkit [143090] by
-
- 17 edits2 copies in trunk/Source/WebCore
Split SQLStatement work between the frontend and backend.
https://bugs.webkit.org/show_bug.cgi?id=104751.
Reviewed by Geoffrey Garen.
This is part of the webdatabase refactoring for webkit2.
- Copied SQLTransaction to SQLTransactionBackend, and then reduce the 2 to only handle frontend and backend work respectively.
- Changed how statements are created.
- SQLTransaction::executeSQL() first creates a SQLStatement frontend which encapsulates the 2 script callbacks. It then passes the SQLStatement to the backend database to create the SQLStatementBackend.
- The SQLStatementBackend manages all sqlite work.
- Remove the Database::reportExecuteStatementResult() wrapper because it is only needed in the backend now.
- Added new files to the build / project files.
- Updated / added comments about how the SQLStatement life-cycle works.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/Database.cpp:
- Modules/webdatabase/Database.h:
(Database):
(WebCore::Database::reportCommitTransactionResult):
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::create):
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::setBackend):
(WebCore::SQLStatement::hasCallback):
(WebCore::SQLStatement::hasErrorCallback):
(WebCore::SQLStatement::performCallback):
- Modules/webdatabase/SQLStatement.h:
(SQLStatement):
- Modules/webdatabase/SQLStatementBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLStatement.cpp.
(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::frontend):
(WebCore::SQLStatementBackend::sqlError):
(WebCore::SQLStatementBackend::sqlResultSet):
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
(WebCore::SQLStatementBackend::clearFailureDueToQuota):
(WebCore::SQLStatementBackend::lastExecutionFailedDueToQuota):
- Modules/webdatabase/SQLStatementBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLStatement.h.
(SQLStatementBackend):
(WebCore::SQLStatementBackend::hasStatementCallback):
(WebCore::SQLStatementBackend::hasStatementErrorCallback):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::executeSQL):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 6:36 PM Changeset in webkit [143089] by
-
- 20 edits in trunk/Source/WebCore
Rename HasCustomCallbacks to HasCustomStyleCallbacks
https://bugs.webkit.org/show_bug.cgi?id=109982
Reviewed by Eric Seidel.
Now that inside ChildFrameDisconnector we only call isFrameOwnerElement()
on elements that report having descendants (or themselves) have connected
frames we don't need to be as agressive about avoiding the virtual call
to isFrameOwnerElement() which lets us rename hasCustomCallbacks to
hasCustomStyleCallbacks to better reflect it's purpose.
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectFrameOwners):
- dom/Element.cpp:
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::customStyleForRenderer):
- dom/Node.h:
(WebCore::Node::pseudoId):
(WebCore::Node::hasCustomStyleCallbacks):
(WebCore::Node::customPseudoId):
(WebCore::Node::setHasCustomStyleCallbacks):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcStyle):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::HTMLOptionElement):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::DateTimeEditElement):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
- 6:33 PM Changeset in webkit [143088] by
-
- 7 edits in trunk/Source
[Mac] remove wkCaptionAppearance from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=109996
Reviewed by Simon Fraser.
Source/WebCore:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 6:23 PM Changeset in webkit [143087] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142899
BUG=168982
Review URL: https://codereview.chromium.org/12279020
- 6:19 PM Changeset in webkit [143086] by
-
- 5 edits2 copies in branches/chromium/1410
Merge 142500
BUG=169398
Review URL: https://codereview.chromium.org/12278026
- 6:13 PM Changeset in webkit [143085] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142922
BUG=170679
Review URL: https://codereview.chromium.org/12284016
- 6:11 PM Changeset in webkit [143084] by
-
- 2 edits2 copies in branches/chromium/1410
Merge 142816
BUG=171557
Review URL: https://codereview.chromium.org/12281016
- 6:09 PM Changeset in webkit [143083] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/Modules/webaudio
Merge 142687
BUG=172331
Review URL: https://codereview.chromium.org/12284015
- 6:00 PM Changeset in webkit [143082] by
-
- 3 edits in branches/chromium/1410
Merge 142635
BUG=172794
Review URL: https://codereview.chromium.org/12285018
- 5:58 PM Changeset in webkit [143081] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142539
BUG=173068
Review URL: https://codereview.chromium.org/12282015
- 5:56 PM Changeset in webkit [143080] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142657
BUG=173399
Review URL: https://codereview.chromium.org/12283026
- 5:49 PM Changeset in webkit [143079] by
-
- 15 edits in branches/chromium/1410
Merge 142759
BUG=174566
Review URL: https://codereview.chromium.org/12288020
- 5:44 PM Changeset in webkit [143078] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/editing/CompositeEditCommand.cpp
Merge 142642
BUG=175342
Review URL: https://codereview.chromium.org/12286016
- 5:42 PM Changeset in webkit [143077] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Crash on window resize if WebProcess is closed/crashed
https://bugs.webkit.org/show_bug.cgi?id=109216
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-15
Reviewed by Benjamin Poulain.
Only make calls into DrawingAreaProxy pointer after checking its state.
When the WebProcess was closed or crashed, WebKit::WebPageProxy will set
its DrawingAreaProxy pointer to null. Resize events on UIProcess/client will
try to access the object to update the geometry and forward this information
into the WebProcess. This would create a crash scenario that is fixed by this patch.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewLegacyPrivate::updateViewportSize):
- 5:39 PM Changeset in webkit [143076] by
-
- 3 edits in trunk/Source/WebCore
Calling DOM Element.attributes shouldn't force creation of ElementData.
<http://webkit.org/b/109976>
Reviewed by Darin Adler.
Don't create ElementData for an Element unnecessarily just because someone calls .attributes on it.
Previously, JS like this would create empty ElementData when 'element' has no attributes:
for (i = 0; i < element.attributes.length; ++i)
doStuff(element.attributes[i]);
Make NamedNodeMap::length() short-circuit and return 0 if !Element::hasAttributes().
- dom/Element.cpp:
(WebCore::Element::attributes):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::length):
- 5:24 PM Changeset in webkit [143075] by
-
- 2 edits in trunk/Source/WebCore
[V8] An "EvenTarget" type in IDL should be converted to EventTarget*, not to Node*
https://bugs.webkit.org/show_bug.cgi?id=109895
Reviewed by Adam Barth.
Currently an "EventTarget" type in IDL is converted to Node*.
This is wrong because there are non-Node interfaces that inherit
a EventTarget. We should convert an "EventTarget" type to EventTarget*.
This will fix FIXMEs in CodeGeneratorV8.pm.
- bindings/scripts/CodeGeneratorV8.pm:
(GetNativeType):
(JSValueToNative):
- 5:20 PM Changeset in webkit [143074] by
-
- 4 edits1 add in trunk
REGRESSION (r142505?): Crashes in WebCore::ScrollingStateNode::appendChild when using back/forward buttons
https://bugs.webkit.org/show_bug.cgi?id=109826
<rdar://problem/13216100>
Source/WebCore:
Reviewed by Beth Dakin.
Fix a crash when going Back on some pages with fixed position elements.
When a page was being restored from the page cache, and a layout from
FrameLoader::commitProvisionalLoad() caused us to try to register the fixed
position layer before the main scrolling layer, we'd crash trying to dereference
the root node.
Fix by bailing from ScrollingStateTree::attachNode() if we can't find the parent
node.
Test: platform/mac-wk2/tiled-drawing/null-parent-back-crash.html
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::stateNodeForID):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
LayoutTests:
Reviewed by Beth Dakin.
Test having a page with an iframe that navigates forwards then back.
- platform/mac-wk2/tiled-drawing/null-parent-back-crash.html: Added.
- 5:05 PM Changeset in webkit [143073] by
-
- 3 edits2 adds in trunk
Constrain fixed layers to the viewport, not the document
https://bugs.webkit.org/show_bug.cgi?id=109646
Source/WebCore:
Reviewed by Beth Dakin.
It's bad to constrain position:fixed compositing layers to the
document rect, because their bounds will change every time the scroll
position changes, and we're not good currently at synchronizing scrolling
thread layer updates with main thread layer updates, so jiggles ensue.
Fix by constraining position:fixed layers to the viewport.
Test: compositing/geometry/limit-layer-bounds-fixed.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateCompositedBounds):
LayoutTests:
Reviewed by Beth Dakin.
Test with a big fixed element in a compositing layer.
- compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
- compositing/geometry/limit-layer-bounds-fixed.html: Added.
- 5:03 PM Changeset in webkit [143072] by
-
- 7 edits in trunk/Source/WebCore
Add a CDMClient class which allows the CDM to query for the currently attached MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=109702
Reviewed by Eric Carlson.
Some CDM implementations will need to work closely with an associated
MediaPlayer in order to generate key requests and provide keys. Add a
client protocol to be implemented by the MediaKeys object which can
provide access to the associated MediaPlayer if present.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM): Initialize the m_client ivar.
(WebCore::CDM::mediaPlayer): Pass to the client, if present.
- Modules/encryptedmedia/CDM.h:
(WebCore::CDM::client): Simple getter.
(WebCore::CDM::setClient): Simple setter.
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::MediaKeys): Initialize the m_mediaElement ivar
and call setClient() on the passed in CDM.
(WebCore::MediaKeys::setMediaElement): Simple setter.
(WebCore::MediaKeys::cdmMediaPlayer): Retrieve the MediaPlayer from
the m_mediaElement if present.
- Modules/encryptedmedia/MediaKeys.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Call setMediaKeys(0)
to clear the mediaElement in any associated MediaKeys.
(WebCore::HTMLMediaElement::setMediaKeys): Clear the mediaElement on
any associated MediaKeys, and set the mediaElement on the newly
associated MediaKeys.
- 5:01 PM Changeset in webkit [143071] by
-
- 5 edits in trunk/Source
Add HashMap::isValidKey and HashSet::isValidValue
https://bugs.webkit.org/show_bug.cgi?id=109977
Reviewed by Sam Weinig and Darin Adler.
Source/WebKit2:
Just call HashMap::isValidKey directly.
- UIProcess/WebProcessProxy.cpp:
(WebKit::generatePageID):
Initialize the id to 0 and use prefix increment.
(WebKit::WebProcessProxy::webFrame):
(WebKit::WebProcessProxy::canCreateFrame):
(WebKit::WebProcessProxy::didDestroyFrame):
Source/WTF:
Add helper functions for determining whether keys are valid, i.e. if
they are _not_ empty or deleted according to the hash traits.
- wtf/HashMap.h:
- wtf/HashSet.h:
- 4:55 PM Changeset in webkit [143070] by
-
- 4 edits2 adds in trunk
drop-shadow filter with overflow:hidden child misbehaves
https://bugs.webkit.org/show_bug.cgi?id=109783
Source/WebCore:
Reviewed by Dean Jackson.
The change in r112745 was not sufficient; it failed to account
for descendant layers that needed to not clipping to avoid artefacts
with filters like drop-shadow.
Test: css3/filters/filter-repaint-shadow-layer-child.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): Remove the useClipRect bool.
Replace it with a clipToDirtyRect member on the LayerPaintingInfo, which
gets passed to descendants. Remove some "Restore the clip" comments that added
nothing.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
(LayerPaintingInfo):
LayoutTests:
Reviewed by Dean Jackson.
- css3/filters/filter-repaint-shadow-layer-child-expected.html: Added.
- css3/filters/filter-repaint-shadow-layer-child.html: Added.
- 4:52 PM Changeset in webkit [143069] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r143066.
http://trac.webkit.org/changeset/143066
https://bugs.webkit.org/show_bug.cgi?id=109986
Broke the Apple Lion build (among others). (Requested by
ddkilzer on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
- accessibility/mac/WebAccessibilityObjectWrapper.h:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
(-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapper position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
(-[WebAccessibilityObjectWrapper scrollViewParent]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapper accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapper accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapper accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapper accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapper doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapper _convertToNSRange:]):
(-[WebAccessibilityObjectWrapper _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapper _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapper doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.h: Removed.
- accessibility/mac/WebAccessibilityObjectWrapperMac.m: Removed.
- 4:33 PM Changeset in webkit [143068] by
-
- 2 edits in trunk/Source/WebCore
Change MouseRelatedEvent to use LayoutPoint::scale
https://bugs.webkit.org/show_bug.cgi?id=109979
Reviewed by Dimitri Glazkov.
Change MouseRelatedEvent::MouseRelatedEvent to use LayoutPoint::
scale to adjust location and scroll offset for scale factor and
zooming.
No new tests, no change in functionality.
- dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
- 4:22 PM Changeset in webkit [143067] by
-
- 4 edits1 add in trunk/Tools
[WK2] Write a test to simulate crashed WebProcess followed by Window resize
https://bugs.webkit.org/show_bug.cgi?id=109842
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-15
Reviewed by Benjamin Poulain.
This new test will kill WebProcess, followed by next resizing the Window. It helps to
identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
before making calls into them.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::didCrash):
(TestWebKitAPI::TEST):
- 4:17 PM Changeset in webkit [143066] by
-
- 4 edits2 adds in trunk/Source/WebCore
AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
https://bugs.webkit.org/show_bug.cgi?id=109849
Reviewed by David Kilzer.
Split up the WebAccessibilityObjectWrapper so that iOS can share more
code with MacOS. I imagine over time, more code will move into this base class,
but for now this will be a good start.
A base class called WebAccessibilityObjectWrapper now exists, and Mac has a subclass
of that. iOS will be able to do the same.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
- accessibility/mac/WebAccessibilityObjectWrapper.h:
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper accessibilityObject]):
(-[WebAccessibilityObjectWrapper accessibilityPostedNotification:]):
(-[WebAccessibilityObjectWrapper titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapper accessibilityTitle]):
(-[WebAccessibilityObjectWrapper accessibilityDescription]):
(-[WebAccessibilityObjectWrapper accessibilityHelpText]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.h: Added.
- accessibility/mac/WebAccessibilityObjectWrapperMac.m: Added.
(std):
(-[WebAccessibilityObjectWrapperMac detach]):
(-[WebAccessibilityObjectWrapperMac attachmentView]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(SearchKeyEntry):
(createAccessibilitySearchKeyMap):
(accessibilitySearchKeyForString):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapperMac textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[WebAccessibilityObjectWrapperMac visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributedStringRangeIsValid):
(AXAttributeStringSetFont):
(CreateCGColorIfDifferent):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetStyle):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetSpelling):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):
(AXAttributedStringAppendText):
(nsStringForReplacedNode):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeFromVisiblePositions:endPosition:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionNames]):
(-[WebAccessibilityObjectWrapperMac additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapperMac visiblePositionRangeForTextMarkerRange:]):
(-[WebAccessibilityObjectWrapperMac renderWidgetChildren]):
(-[WebAccessibilityObjectWrapperMac remoteAccessibilityParentObject]):
(convertToVector):
(convertToNSArray):
(-[WebAccessibilityObjectWrapperMac textMarkerRangeForSelection]):
(-[WebAccessibilityObjectWrapperMac position]):
(createAccessibilityRoleMap):
(roleValueToNSString):
(-[WebAccessibilityObjectWrapperMac role]):
(-[WebAccessibilityObjectWrapperMac subrole]):
(-[WebAccessibilityObjectWrapperMac roleDescription]):
(-[WebAccessibilityObjectWrapperMac scrollViewParent]):
(-[WebAccessibilityObjectWrapperMac titleTagShouldBeUsedInDescriptionField]):
(-[WebAccessibilityObjectWrapperMac accessibilityTitle]):
(-[WebAccessibilityObjectWrapperMac accessibilityDescription]):
(-[WebAccessibilityObjectWrapperMac accessibilityHelpText]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapperMac accessibilityFocusedUIElement]):
(-[WebAccessibilityObjectWrapperMac accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsAttributeSettable:]):
(-[WebAccessibilityObjectWrapperMac accessibilityIsIgnored]):
(-[WebAccessibilityObjectWrapperMac accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformIncrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformDecrementAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformShowMenuAction]):
(-[WebAccessibilityObjectWrapperMac accessibilityShowContextMenu]):
(-[WebAccessibilityObjectWrapperMac accessibilityPerformAction:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySetValue:forAttribute:]):
(rendererForView):
(-[WebAccessibilityObjectWrapperMac _accessibilityParentForSubview:]):
(-[WebAccessibilityObjectWrapperMac accessibilityActionDescription:]):
(-[WebAccessibilityObjectWrapperMac doAXAttributedStringForRange:]):
(-[WebAccessibilityObjectWrapperMac _convertToNSRange:]):
(-[WebAccessibilityObjectWrapperMac _indexForTextMarker:]):
(-[WebAccessibilityObjectWrapperMac _textMarkerForIndex:]):
(-[WebAccessibilityObjectWrapperMac doAXRTFForRange:]):
(-[WebAccessibilityObjectWrapperMac accessibilityAttributeValue:forParameter:]):
(-[WebAccessibilityObjectWrapperMac accessibilitySupportsOverriddenAttributes]):
(-[WebAccessibilityObjectWrapperMac accessibilityShouldUseUniqueId]):
(-[WebAccessibilityObjectWrapperMac accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapperMac accessibilityArrayAttributeValues:index:maxCount:]):
([WebAccessibilityObjectWrapperMac accessibilitySetShouldRepostNotifications:]):
(-[WebAccessibilityObjectWrapperMac accessibilityPostedNotification:]):
- 3:58 PM Changeset in webkit [143065] by
-
- 2 edits in trunk/Source/WebKit2
Typo fix after r143064.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
- 3:47 PM Changeset in webkit [143064] by
-
- 2 edits in trunk/Source/WebKit2
One more buildfix after r143052.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
- 3:14 PM Changeset in webkit [143063] by
-
- 1 edit in trunk/Tools/EWSTools/start-queue-win.sh
Win EWS script, credentials passed in.
- 3:14 PM Changeset in webkit [143062] by
-
- 12 edits in trunk/Source/WebKit2
Unreviewed buildfix after r143052 for Qt/GTK/EFL ports.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::encode):
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::encode):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode):
- Shared/WebBatteryStatus.cpp:
(WebKit::WebBatteryStatus::Data::encode):
- Shared/WebNetworkInfo.cpp:
(WebKit::WebNetworkInfo::Data::encode):
- Shared/efl/LayerTreeContextEfl.cpp:
(WebKit::LayerTreeContext::encode):
- Shared/gtk/LayerTreeContextGtk.cpp:
(WebKit::LayerTreeContext::encode):
- Shared/qt/LayerTreeContextQt.cpp:
(WebKit::LayerTreeContext::encode):
- Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::encode):
- Shared/qt/QtNetworkRequestData.cpp:
(WebKit::QtNetworkRequestData::encode):
- Shared/soup/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::encode):
- 3:12 PM Changeset in webkit [143061] by
-
- 20 edits1 delete in trunk/Source/WTF
Remove support for RVCT version less than 4.0
https://bugs.webkit.org/show_bug.cgi?id=109390
The 4.0 version of the RVCT compiler was
released in 2008.
Remove support for version older then 4.0 of RVCT,
and keep the support for newer RVCT versions.
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-15
Reviewed by Zoltan Herczeg.
- WTF.gypi: Remove StringExtras.cpp.
- WTF.vcproj/WTF.vcproj: Remove StringExtras.cpp.
- WTF.vcxproj/WTF.vcxproj: Remove StringExtras.cpp.
- WTF.vcxproj/WTF.vcxproj.filters: Remove StringExtras.cpp.
- WTF.xcodeproj/project.pbxproj: Remove StringExtras.cpp.
- wtf/CMakeLists.txt: Remove StringExtras.cpp.
- wtf/Compiler.h: Remove tests for RVCT_VERSION_AT_LEAST(3, 0, 0, 0).
- wtf/Float32Array.h: Remove a quirk introduced for RVCT version <=2.2 .
- wtf/Float64Array.h: Ditto.
- wtf/Int16Array.h: Ditto.
- wtf/Int32Array.h: Ditto.
- wtf/Int8Array.h: Ditto.
- wtf/MathExtras.h: Remove a quirk needed for RVCT version <= 3.0.
- wtf/Platform.h: Remove test for RVCT 4.0. Remove OS(RVCT).
- wtf/StringExtras.cpp: Removed.
- wtf/StringExtras.h: Remove a quirk introduced for RVCT version < 4.0.
- wtf/Uint16Array.h: Remove a quirk introduced for RVCT version <= 2.2.
- wtf/Uint32Array.h: Ditto.
- wtf/Uint8Array.h: Ditto.
- wtf/Uint8ClampedArray.h: Ditto.
- 3:11 PM Changeset in webkit [143060] by
-
- 6 edits2 adds in trunk
RenderQuote should not mark renderers as needing layout during layout
https://bugs.webkit.org/show_bug.cgi?id=109876
Reviewed by Ojan Vafai.
Source/WebCore:
Marking RenderQuotes as needing pref width recalcs and layouts during a
layout is dangerous since an ancestor may mark itself as having completed
layout, but then some subtree still thinks it needs layout.
Instead, since the only time we create RenderQuote instances is inside
PseudoElement, we can call attachQuote inside PseudoElement::attach during
the regular tree mutating cycle. We can then use RenderQuote::styleDidChange
to update the kind of quotes on normal style changes.
This makes RenderQuote behave much more similarly to DOM nodes and means
we no longer need to set dirty bits during layout.
Test: fast/css-generated-content/quote-layout-focus-crash.html
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::attach): Now call attachQuote().
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeRemovedFromTree):
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::updateText):
(WebCore::RenderQuote::attachQuote):
(WebCore::RenderQuote::detachQuote):
(WebCore::RenderQuote::updateDepth):
- rendering/RenderQuote.h:
(RenderQuote):
LayoutTests:
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
- fast/css-generated-content/quote-layout-focus-crash-expected.txt: Added.
- fast/css-generated-content/quote-layout-focus-crash.html: Added.
- 3:07 PM Changeset in webkit [143059] by
-
- 1 edit in trunk/Tools/EWSTools/start-queue-win.sh
Unreviewed. Modify Win EWS script.
- 3:07 PM Changeset in webkit [143058] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
Add myself (sadrul@chromium.org) as committer.
- 2:57 PM Changeset in webkit [143057] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG SpeculativeJIT64 should be more precise about when it's dealing with a cell (even though it probably doesn't matter)
https://bugs.webkit.org/show_bug.cgi?id=109625
Reviewed by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compile):
- 2:49 PM Changeset in webkit [143056] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142492
document.write during window.onload can trigger DumpRenderTree to dump the render tree
https://bugs.webkit.org/show_bug.cgi?id=109465
Reviewed by Eric Seidel.
Source/WebCore:
This patch is a partial revert of
http://trac.webkit.org/changeset/142378. It's not safe to call
checkComplete during the load event. We'll need to find another way of
calling checkComplete at the right time.
Test: fast/parser/document-write-during-load.html
- dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
LayoutTests:
- fast/parser/document-write-during-load-expected.txt: Added.
- fast/parser/document-write-during-load.html: Added.
TBR=abarth@webkit.org
Review URL: https://codereview.chromium.org/12287016
- 2:48 PM Changeset in webkit [143055] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Stub out SharedBuffer version of get()
https://bugs.webkit.org/show_bug.cgi?id=108993
Reviewed by Darin Fisher.
All asynchronous get()-like calls go through WebIDBCallbacks,
so this includes both get() and cursor callbacks.
- public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onSuccess):
(WebKit::WebIDBCallbacks::onSuccessWithPrefetch):
- 2:47 PM Changeset in webkit [143054] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r143044.
http://trac.webkit.org/changeset/143044
https://bugs.webkit.org/show_bug.cgi?id=109974
broke windows build (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15
- dom/DocumentSharedObjectPool.cpp:
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
- dom/Element.cpp:
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
- dom/Element.h:
(WebCore::ShareableElementData::immutableAttributeArray):
(ShareableElementData):
(WebCore::ElementData::attributeItem):
- 2:41 PM Changeset in webkit [143053] by
-
- 11 edits in branches/chromium/1410/Source/WebCore
Revert 140571
https://bugs.webkit.org/show_bug.cgi?id=107628
Sometimes scroll position is jerky during rubber-band, affects nytimes.com
-and corresponding-
<rdar://problem/12679549>
Reviewed by Simon Fraser.
The basic problem here is that isRubberBandInProgress() was only implemented for
main thread scrolling. So when we were actually scrolling on the scrolling thread,
that function would always return false regardless.
New ScrollableArea virtual function isRubberBandInProgress() will allow us to ask
the ScrollingCoordinator when the scrolling thread is scrolling, or the
ScrollAnimator otherwise.
- page/FrameView.cpp:
(WebCore::FrameView::isRubberBandInProgress):
- page/FrameView.h:
(FrameView):
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::isRubberBandInProgress):
New ScrollingCoordinator function isRubberBandInProgress() always returns false
for non-Mac ports, and is overridden in ScrollingCoordinatorMac to consult the
ScrollingTree.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::isRubberBandInProgress):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::isRubberBandInProgress):
New variable m_mainFrameIsRubberBanding keeps track of whether there is currently
a rubber-band happening on the scrolling thread.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::isRubberBandInProgress):
(WebCore::ScrollingTree::setMainFrameIsRubberBanding):
- page/scrolling/ScrollingTree.h:
(ScrollingTree):
(WebCore::ScrollingTree::rootNode):
Call setMainFrameIsRubberBanding() whenever the stretchAmount is calculated and
whenever we stop the rubber-band timer.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::stretchAmount):
(WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer):
Consult FrameView for isRubberBandInProgress().
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
TBR=jamesr@chromium.org
BUG=173009
Review URL: https://codereview.chromium.org/12279017
- 2:27 PM Changeset in webkit [143052] by
-
- 9 edits in trunk/Source/WebKit2
Make most ArgumentEncoder::encode member functions private
https://bugs.webkit.org/show_bug.cgi?id=109973
Reviewed by Sam Weinig.
Make the encode overloads private; the stream operator should be used instead.
- Platform/CoreIPC/ArgumentEncoder.h:
(ArgumentEncoder):
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments1::encode):
(CoreIPC::Arguments2::encode):
(CoreIPC::Arguments3::encode):
(CoreIPC::Arguments4::encode):
(CoreIPC::Arguments5::encode):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments10::encode):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::createSyncMessageEncoder):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC::MessageEncoder::MessageEncoder):
- Scripts/webkit2/messages.py:
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::EncoderAdapter):
(WebKit::EncoderAdapter::encodeBytes):
(WebKit::EncoderAdapter::encodeBool):
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit::EncoderAdapter::encodeUInt32):
(WebKit::EncoderAdapter::encodeUInt64):
(WebKit::EncoderAdapter::encodeInt32):
(WebKit::EncoderAdapter::encodeInt64):
(WebKit::EncoderAdapter::encodeFloat):
(WebKit::EncoderAdapter::encodeDouble):
(WebKit::EncoderAdapter::encodeString):
- 2:14 PM Changeset in webkit [143051] by
-
- 12 edits in trunk/Source/WebCore
Enable the preload scanner on the background parser thread
https://bugs.webkit.org/show_bug.cgi?id=108027
Reviewed by Tony Gentilcore.
The patch causes us to pass all the fast/preloader tests with the
threaded parser enabled.
This patch wires up the BackgroundHTMLParser to the
TokenPreloadScanner. Currently, we bail out of preload scanning if we
encounter a document.write becaues we don't know how to rewind the
preload scanner, but that's something we can tune in the future.
The BackgroundHTMLParser delivers the preloads to the
HTMLDocumentParser together with the token stream. If the
HTMLDocumentParser isn't able to use the token stream immediately, it
kicks off the preloads.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::checkThatPreloadsAreSafeToSendToAnotherThread):
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/BackgroundHTMLParser.h:
(Configuration):
- We need to add a struct for the create function because the number of arguments exceeds the limits of Functional.h.
(BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::create):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):
- We need to use a new string here so that the string is safe to send to another thread.
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::startBackgroundParser):
- Following the example of the XSSAuditor, we create the TokenPreloadScanner on the main thread and then send it to the background thread for operation.
- html/parser/HTMLDocumentParser.h:
(WebCore):
(ParsedChunk):
- html/parser/HTMLParserOptions.h:
(HTMLParserOptions):
- We need to add a default constructor so that the HTMLDocumentParser can create an empty BackgroundHTMLParser::Configuration struct.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::isSafeToSendToAnotherThread):
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore):
- html/parser/HTMLResourcePreloader.h:
(WebCore::PreloadRequest::PreloadRequest):
(WebCore):
(HTMLResourcePreloader):
- 2:01 PM Changeset in webkit [143050] by
-
- 6 edits in trunk/Source/WebKit2
Add a synchronous GetValues message to StorageManager
https://bugs.webkit.org/show_bug.cgi?id=109968
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
Handle synchronous messages.
(CoreIPC::Connection::processIncomingMessage):
Check for work queue message receivers before doing any other processing.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getValues):
Add empty stub.
- UIProcess/Storage/StorageManager.h:
- UIProcess/Storage/StorageManager.messages.in:
Add GetValues message.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::loadValuesIfNeeded):
Send the GetValues message.
- 1:53 PM Changeset in webkit [143049] by
-
- 5 edits in trunk
Add CString operators for comparison with const char*
https://bugs.webkit.org/show_bug.cgi?id=109947
Reviewed by Darin Adler.
Source/WTF:
Add operators to WTF::CString for equality/inequality comparison
with const char* strings. This avoids constructing a CString
from a const char* in such cases, which is can be expensive as
it would copy it and call strlen().
- wtf/text/CString.cpp:
(WTF::operator==): Use memcmp instead of strncmp to compare the
CString buffers as we know they are the same size and we don't
want to scan for terminating null byte.
(WTF):
- wtf/text/CString.h:
(WTF):
(WTF::operator!=):
Tools:
Add tests for WTF::CString's comparison operators.
- TestWebKitAPI/Tests/WTF/CString.cpp:
(TEST):
- 1:50 PM Changeset in webkit [143048] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r143030. We need to keep updatedRange around until createMarkupInternal returns.
- editing/markup.cpp:
(WebCore::createMarkup):
- 1:48 PM Changeset in webkit [143047] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: fix chromium windows bustage
https://bugs.webkit.org/show_bug.cgi?id=109970
Unreviewed build fix for Chromium Windows.
- tests/IDBDatabaseBackendTest.cpp:
- 1:43 PM Changeset in webkit [143046] by
-
- 23 edits10 adds in trunk
Add platform support for -webkit-background-blend-mode to CG context
https://bugs.webkit.org/show_bug.cgi?id=108549
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-15
Reviewed by Dean Jackson.
Source/WebCore:
Tests: css3/compositing/effect-background-blend-mode-stacking.html
css3/compositing/effect-background-blend-mode.html
This patch adds support for blending on background images to the Core Graphics port of WebKit.
- platform/graphics/CrossfadeGeneratedImage.cpp: Added interface change for blending.
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.h: Added interface change for blending.
(CrossfadeGeneratedImage):
- platform/graphics/GeneratedImage.h: Added interface change for blending.
(GeneratedImage):
- platform/graphics/GeneratorGeneratedImage.cpp: Added interface change for blending.
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.h: Added interface change for blending.
(GeneratorGeneratedImage):
- platform/graphics/GraphicsContext.cpp: Added interface change for blending and passes blend mode to image object.
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::blendModeOperation):
(WebCore):
- platform/graphics/GraphicsContext.h: Added interface change for blending.
(GraphicsContext):
- platform/graphics/Image.cpp: Added interface change for blending and passed it to graphics layer.
(WebCore::Image::drawTiled):
- platform/graphics/Image.h: Added interface change for blending.
(Image):
- platform/graphics/cg/ImageCG.cpp: Added interface change for blending and passed it to OS.
(WebCore::Image::drawPattern):
- rendering/RenderBoxModelObject.cpp: Passed blend mode when drawing background images.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- platform/graphics/cairo/ImageCairo.cpp: Added interface change for blending.
(WebCore::Image::drawPattern):
- platform/graphics/qt/ImageQt.cpp: Added interface change for blending.
(WebCore::Image::drawPattern):
- platform/graphics/skia/ImageSkia.cpp: Added interface change for blending.
(WebCore::Image::drawPattern):
- rendering/RenderBoxModelObject.cpp: Added interface change for blending.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- svg/graphics/SVGImageForContainer.cpp: Added interface change for blending.
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h: Added interface change for blending.
Source/WebKit:
Fixed build issue.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
Fixed build issue.
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
Added tests for background images.
- css3/compositing/effect-background-blend-mode-expected.png: Added.
- css3/compositing/effect-background-blend-mode-expected.txt: Added.
- css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
- css3/compositing/effect-background-blend-mode-stacking-expected.txt: Added.
- css3/compositing/effect-background-blend-mode-stacking.html: Added.
- css3/compositing/effect-background-blend-mode.html: Added.
- css3/compositing/resources/ducky.png: Added.
- platform/chromium/TestExpectations:
- platform/mac/css3/compositing: Added.
- platform/mac/css3/compositing/effect-background-blend-mode-expected.png: Added.
- platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
- 1:35 PM Changeset in webkit [143045] by
-
- 3 edits2 adds in trunk
Clamp span value in RenderTableCell::parse[Col|Row]SpanFromDOM
https://bugs.webkit.org/show_bug.cgi?id=109878
Source/WebCore:
Reviewed by Abhishek Arya.
Test: fast/table/colspan-huge-number.html
Clamp colspan and rowspan values to their respective maximum
supported values.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
LayoutTests:
Reviewed by Abhishek Arya.
Add test for handling of very large colspan value.
- fast/table/colspan-huge-number-expected.txt: Added.
- fast/table/colspan-huge-number.html: Added.
- 1:30 PM Changeset in webkit [143044] by
-
- 4 edits in trunk/Source/WebCore
ShareableElementData should use zero-length array for storage.
<http://webkit.org/b/109959>
Reviewed by Anders Carlsson.
Use a zero-length Attribute array instead of always casting from void* to an array.
It was done this way originally because I didn't know we could sidestep the MSVC
build error with some #pragma hackery.
- dom/DocumentSharedObjectPool.cpp:
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
- dom/Element.cpp:
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
- dom/Element.h:
(ShareableElementData):
(WebCore::ElementData::attributeItem):
- 1:18 PM Changeset in webkit [143043] by
-
- 3 edits in trunk/Source/WebCore
Implement RenderGrid::computeIntrinsicLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=109881
Reviewed by Tony Chang.
For now this is not observable due to the FIXMEs for unimplemented bits
of computePreferredLogicalWidths. But, soon, I'll be removing the computePreferredLogicalWidths
override entirely and instead use RenderBlock's, which will also address the
RenderGrid FIXMEs.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
const_cast the usages of m_grid. Alternately, we could stack allocate it, but there's disagreement on
whether that's the right choice. See https://bugs.webkit.org/show_bug.cgi?id=109880.
(WebCore::RenderGrid::computePreferredLogicalWidths):
- rendering/RenderGrid.h:
- 1:16 PM Changeset in webkit [143042] by
-
- 3 edits6 adds in trunk
Flexbox should ignore firstLine pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=104485
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-02-15
Reviewed by Tony Chang.
Source/WebCore:
Spec[1] said that "None of the properties defined in this module
apply to '::first-line' or '::first-letter' pseudo-elements." and
css2[2] define "The :first-line pseudo-element can only be attached
to a block container element."
[1]http://dev.w3.org/csswg/css3-flexbox/#display-flex
[2]http://www.w3.org/TR/CSS2/selector.html#first-line-pseudo
tests:
css3/flexbox/flexbox-ignore-firstLine.html
css3/flexbox/flexitem-firstLine-valid.html
css3/flexbox/inline-flexbox-ignore-firstLine.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock):
LayoutTests:
Spec[1] said that "None of the properties defined in this module
apply to '::first-line' or '::first-letter' pseudo-elements." and
css2[2] define "The :first-line pseudo-element can only be attached
to a block container element."
[1]http://dev.w3.org/csswg/css3-flexbox/#display-flex
[2]http://www.w3.org/TR/CSS2/selector.html#first-line-pseudo
some case by Kenny Lu <kanghaol@oupeng.com>
- css3/flexbox/flex-item-firstLine-valid-expected.txt: Added.
- css3/flexbox/flex-item-firstLine-valid.html: Added.
- css3/flexbox/flexbox-ignore-firstLine-expected.txt: Added.
- css3/flexbox/flexbox-ignore-firstLine.html: Added.
- css3/flexbox/inline-flexbox-ignore-firstLine-expected.txt: Added.
- css3/flexbox/inline-flexbox-ignore-firstLine.html: Added.
- 1:15 PM Changeset in webkit [143041] by
-
- 4 edits in tags/Safari-537.31.2/Source
Versioning.
- 1:11 PM Changeset in webkit [143040] by
-
- 1 copy in tags/Safari-537.31.2
New Tag.
- 1:05 PM Changeset in webkit [143039] by
-
- 5 edits in trunk/Source/WebKit/gtk
Unreviewed, rolling out parts of r142731.
http://trac.webkit.org/changeset/142731
https://bugs.webkit.org/show_bug.cgi?id=109672
This patch broke the GTK+ gyp build. Roll out the changes there,
since they were actually unnecessary.
- gyp/Configuration.gypi.in:
- gyp/Dependencies.gyp:
- gyp/JavaScriptCore.gyp:
- gyp/WTF.gyp:
- 1:03 PM Changeset in webkit [143038] by
-
- 5 edits in trunk/Source/WebKit2
A storage area should know its storage type
https://bugs.webkit.org/show_bug.cgi?id=109964
Reviewed by Andreas Kling.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::storageType):
(WebKit):
- WebProcess/Storage/StorageNamespaceProxy.h:
(StorageNamespaceProxy):
- 1:01 PM Changeset in webkit [143037] by
-
- 13 edits in trunk/Source
IndexedDB: Implement SharedBuffer version of put()
https://bugs.webkit.org/show_bug.cgi?id=109092
Reviewed by Adam Barth.
Source/WebCore:
Switch IDBDatabaseBackendInterface::put over
to SharedBuffer, to avoid buffer copies of the value.
No new tests, this is a refactor.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::putRecord):
- Modules/indexeddb/IDBBackingStore.h:
(WebCore):
(IDBBackingStore):
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(PutOperation):
(WebCore::IDBDatabaseBackendImpl::put):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
Source/WebKit/chromium:
Implement SharedBuffer/WebData version of
IDBDatabaseBackendInterface::put, and put
temporary scaffolding in until chrome is ready.
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::put):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::put):
(WebKit):
- src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
- tests/IDBDatabaseBackendTest.cpp:
- 12:56 PM Changeset in webkit [143036] by
-
- 28 edits in trunk/LayoutTests
Rebaseline 7 SVG tests after r142765.
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
- platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png:
- platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
- platform/chromium-mac-lion/svg/as-image/svg-image-change-content-size-expected.png:
- platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac-lion/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
- platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
- platform/chromium-mac/svg/as-image/svg-image-change-content-size-expected.png:
- platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
- platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
- platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
- platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
- platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
- platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
- platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
- platform/chromium/TestExpectations:
- 12:50 PM Changeset in webkit [143035] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark inspector/profiler/heap-snapshot-get-profile-crash.html flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=109963
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 12:49 PM Changeset in webkit [143034] by
-
- 5 edits in trunk/Source
Implement StorageAreaProxy::length
https://bugs.webkit.org/show_bug.cgi?id=109962
Reviewed by Andreas Kling.
Source/WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::length):
Load the values if needed and then return the length.
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Add helper function.
(WebKit::StorageAreaProxy::loadValuesIfNeeded):
Just allocate the hash map for now.
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- 12:45 PM Changeset in webkit [143033] by
-
- 4 edits in trunk/Tools
webkit-patch suggest-reviewers should limit itself to 5 reviewers
https://bugs.webkit.org/show_bug.cgi?id=107528
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.suggested_reviewers): Iterate through the sorted commit info list,
scraping reviewers from the commit information and in the end producing a list
of reviewers that's sorted from the most to least recent activity of any reviewer
that has reviewed or authored patches for the changed files.
- Scripts/webkitpy/tool/commands/queries.py:
(SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
the same logic.
(SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
defaults to False.
- Scripts/webkitpy/tool/steps/suggestreviewers.py:
(SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
on a single line. Only ask for CC-ing the suggested reviewers to the bug if the
bug ID is located in the command's state.
- 12:35 PM Changeset in webkit [143032] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] WebInputEventBuilders should not reverse page scale
https://bugs.webkit.org/show_bug.cgi?id=109901
Reviewed by James Robinson.
Though in theory logical that if WebInputEvent -> PlatformEvent
conversions divide by page scale, then the reverse builders should
multiply, in reality the only user of the reverse builders is
plugins which expect the same coordinate space as WebCore.
- src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
- 12:05 PM Changeset in webkit [143031] by
-
- 10 edits in trunk/Source
Remove const from a bunch of StorageArea member functions
https://bugs.webkit.org/show_bug.cgi?id=109957
Reviewed by Beth Dakin.
Source/WebCore:
StorageArea is an abstract base class, and its subclasses might want to mutate the object
when certain member functions are called so remove const from all member functions.
- storage/StorageArea.h:
(WebCore):
(StorageArea):
(WebCore::StorageArea::~StorageArea):
(WebCore::StorageArea::incrementAccessCount):
(WebCore::StorageArea::decrementAccessCount):
(WebCore::StorageArea::closeDatabaseIfIdle):
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::canAccessStorage):
(WebCore::StorageAreaImpl::length):
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::getItem):
(WebCore::StorageAreaImpl::contains):
(WebCore::StorageAreaImpl::memoryBytesUsedByCache):
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
Source/WebKit/chromium:
Update for WebCore changes.
- src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::length):
(WebCore::StorageAreaProxy::key):
(WebCore::StorageAreaProxy::getItem):
(WebCore::StorageAreaProxy::contains):
(WebCore::StorageAreaProxy::canAccessStorage):
(WebCore::StorageAreaProxy::memoryBytesUsedByCache):
- src/StorageAreaProxy.h:
(StorageAreaProxy):
Source/WebKit2:
Update for WebCore changes.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::length):
(WebKit::StorageAreaProxy::key):
(WebKit::StorageAreaProxy::getItem):
(WebKit::StorageAreaProxy::contains):
(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::memoryBytesUsedByCache):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- 11:59 AM Changeset in webkit [143030] by
-
- 4 edits in trunk/Source/WebCore
DeleteButtonController::enable and disable should be called via a RAII object
https://bugs.webkit.org/show_bug.cgi?id=109550
Reviewed by Enrica Casucci.
Added DeleteButtonControllerDisableScope, a friend class of DeleteButtonController,
and made DeleteButtonController::enable/disable private.
- dom/ContainerNode.cpp:
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):
- editing/DeleteButtonController.h:
(WebCore):
(DeleteButtonController):
(DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope):
- editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::createFragmentFromNodes):
- 11:58 AM Changeset in webkit [143029] by
-
- 16 edits in trunk/LayoutTests
Rebaseline 4 svg/zoom/page tests after r142765
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium/TestExpectations:
- 11:54 AM Changeset in webkit [143028] by
-
- 7 edits6 adds in trunk
Source/WebCore: Add code from other branch.
[CSS Shaders] Parse src property in @-webkit-filter at-rules
https://bugs.webkit.org/show_bug.cgi?id=109770
Reviewed by Dean Jackson.
This patch implements the parsing for the CSS src property in @-webkit-filter at-rules.
The Filter Effects spec [1] specifies its syntax:
src: [ <uri> [format(<string>)]?]#
In practice, it can look like:
src: url(shader.vs) format('x-shader/x-vertex'),
url(shader.fs) format('x-shader/x-fragment');
This src property is similar to the src property in CSS font-face rules, but a little
different. The CSS Fonts spec [2] specifies:
src: [ <uri> [format(<string>#)]? | <font-face-name> ]#
The syntax for a <font-face-name> is a unique font face name enclosed by "local("
and ")".
Unlike the filter src property, the font face src property accepts the local function
[e.g. src: local("SomeFont");]. Also, the font face src property accepts a list of strings
instead of just one string in its format function.
[1]: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-src
[2]: http://www.w3.org/TR/css3-fonts/#src-desc
Tests: css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html
- css/CSSGrammar.y.in:
Set (and unset) a flag called "m_inFilterRule", which tells us if we are in a
@-webkit-filter at-rule or in a @font-face at-rule when we encounter a src property.
We parse the two variants of the src property separately so that we can create different
objects (WebKitCSSShaderValue vs. CSSFontFaceSrcValue) and because their syntax is a
little different.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleSrcUriAndFormat):
Parses a URI and format pair found in the @-webkit-filter src property.
(WebCore::CSSParser::parseFilterRuleSrc):
Parse the @-webkit-filter src property.
- css/CSSParser.h:
(CSSParser):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::customCssText):
WebKitCSSShaderValue now has an m_format member, which needs to be included in its
cssText.
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
- css/WebKitCSSShaderValue.h:
(WebCore::WebKitCSSShaderValue::format):
(WebCore::WebKitCSSShaderValue::setFormat):
(WebKitCSSShaderValue):
LayoutTests: [CSS Shaders] Parse src property in @-webkit-filter at-rules
https://bugs.webkit.org/show_bug.cgi?id=109770
Reviewed by Dean Jackson.
Add positive and negative parsing tests for the @-webkit-filter src property.
- css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html: Added.
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-invalid.js: Added.
(testInvalidSrcProperty):
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-valid.js: Added.
(testSrcProperty):
- 11:54 AM Changeset in webkit [143027] by
-
- 4 edits in trunk/Source
Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660
Reviewed by Sam Weinig.
Responding to review comments by Darin Adler.
- runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
in the hash table deleted value because they're meaningless.
../WTF:
- wtf/HashTraits.h: Added a using directive to simplify client code.
- 11:53 AM Changeset in webkit [143026] by
-
- 19 edits in trunk/LayoutTests
Rebaseline 4 tests after r142765
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png:
- platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/background-intrinsic-004-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/background-intrinsic-005-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png:
- platform/chromium-mac/css2.1/20110323/background-intrinsic-004-expected.png:
- platform/chromium-mac/css2.1/20110323/background-intrinsic-005-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/same-image-two-instances-expected.png:
- platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png:
- platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
- platform/chromium/TestExpectations:
- 11:50 AM Changeset in webkit [143025] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 11:47 AM Changeset in webkit [143024] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG AbstractState should filter operands to NewArray more precisely
https://bugs.webkit.org/show_bug.cgi?id=109900
Reviewed by Mark Hahnenberg.
NewArray for primitive indexing types speculates that the inputs are the appropriate
primitives. Now, the CFA filters the abstract state accordingly, as well.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- 11:46 AM Changeset in webkit [143023] by
-
- 11 edits1 add in trunk/LayoutTests
Rebaseline 3 tests after r142765
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium/TestExpectations:
- 11:17 AM Changeset in webkit [143022] by
-
- 1 edit1 add in trunk/Tools
Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
- EWSTools/start-queue-win.sh: Added.
- 11:15 AM Changeset in webkit [143021] by
-
- 4 edits in trunk
Crash occurs at WebCore::TextTrackList::length() when enabling closed captions in movie
https://bugs.webkit.org/show_bug.cgi?id=109886
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, media/media-captions.html does not crash with this change.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Early return when
m_textTracks is NULL.
LayoutTests:
- platform/mac/TestExpectations: Remove media/media-captions.html.
- 11:11 AM Changeset in webkit [143020] by
-
- 5 edits in trunk/Source/WebCore
TokenPreloadScanner should be able to scan CompactHTMLTokens
https://bugs.webkit.org/show_bug.cgi?id=109861
Reviewed by Eric Seidel.
This patch moves the main scanning logic for the TokenPreloadScanner to
a templated scanCommon routine that can scan either an HTMLToken or a
CompactHTMLToken. This patch will let the BackgroundHTMLParser preload
scan its CompactHTMLTokens.
- html/parser/CSSPreloadScanner.cpp:
(WebCore):
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- Tweak the CSSPreloadScanner API slightly to make it easier to call from templated code.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(TokenPreloadScanner):
- 11:06 AM WebKit Team edited by
- add myself as committer (diff)
- 11:06 AM Changeset in webkit [143019] by
-
- 10 edits in trunk
WebKit shouldn't accept "none, none" in transition shorthand property.
https://bugs.webkit.org/show_bug.cgi?id=108751
Reviewed by Dean Jackson.
Source/WebCore:
http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property
specifies that if there is more than one transition defined in the
shorthand and any of them has a value of 'none' then the declaration is
invalid. This patch fixes the problem by passing a parsing context to
track if a keyword has been set for the transition-property and if so
then use it to invalidate or not the declaration.
Test: transitions/transitions-parsing.html
- css/CSSParser.cpp:
(AnimationParseContext):
(WebCore::AnimationParseContext::AnimationParseContext):
(WebCore::AnimationParseContext::commitFirstAnimation): track whether
it's the first <single-transition/animation> or not defined in the
shorthand.
(WebCore::AnimationParseContext::hasCommittedFirstAnimation):
(WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand):
In the shorthand as soon as a keyword has been found then the parsing
is 'finished', if any other animation/transition declaration part of
the shorthand are with a keyword then it's invalid.
(WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed):
(WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword):
(WebCore::AnimationParseContext::sawAnimationPropertyKeyword):
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseAnimationProperty):
- css/CSSParser.h:
(WebCore):
LayoutTests:
Extend exisiting tests to cover the bug. Modify old tests with invalid declarations.
- fast/css/transform-inline-style-expected.txt:
- fast/css/transform-inline-style-remove-expected.txt:
- fast/css/transform-inline-style-remove.html:
- fast/css/transform-inline-style.html:
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 10:56 AM Changeset in webkit [143018] by
-
- 6 edits in trunk/Source/JavaScriptCore
Yarr: Use OwnPtr to make pattern/disjunction/character-class ownership clearer.
<http://webkit.org/b/109218>
Reviewed by Benjamin Poulain.
- Let classes that manage lifetime of other objects hold on to them with OwnPtr instead of raw pointers.
- Placed some strategic Vector::shrinkToFit(), ::reserveInitialCapacity() and ::swap().
668 kB progression on Membuster3.
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(ByteCompiler):
- yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
(BytecodePattern):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):
- yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
- yarr/YarrPattern.h:
(JSC::Yarr::PatternDisjunction::addNewAlternative):
(PatternDisjunction):
(YarrPattern):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):
- 10:55 AM Changeset in webkit [143017] by
-
- 2 edits in trunk/Tools
Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
- Scripts/webkitpy/common/config/committers.py:
- 10:33 AM Changeset in webkit [143016] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 10:29 AM Changeset in webkit [143015] by
-
- 2 edits in trunk/Tools
NRWT: ML Debug Test bot is timing out after cleaning up ports
https://bugs.webkit.org/show_bug.cgi?id=109912
Reviewed by Simon Fraser.
Added more debug messgaes to diagnose the issue.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- 10:28 AM Changeset in webkit [143014] by
-
- 3 edits in trunk/Source/WebCore
ElementData: Move leafy things out of the base class.
<http://webkit.org/b/109888>
Reviewed by Antti Koivisto.
- Moved functions for mutating/adding/removing attributes into UniqueElementData. Attempts to modify shared element data will now fail at compile-time.
- Removed mutableAttributeVector() and have call sites access the vector directly.
- Move immutableAttributeArray() to ShareableElementData.
- Move some function bodies from Element.h to Element.cpp since all clients are in there.
- dom/Element.cpp:
(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::UniqueElementData::addAttribute):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::UniqueElementData::getAttributeItem):
(WebCore::UniqueElementData::attributeItem):
- dom/Element.h:
(ElementData):
(WebCore::ShareableElementData::immutableAttributeArray):
(ShareableElementData):
(UniqueElementData):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeItem):
- 10:27 AM Changeset in webkit [143013] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/committers.py:
- 10:24 AM Changeset in webkit [143012] by
-
- 2 edits in trunk/Tools
Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
emails on their behalf.
- Scripts/webkitpy/common/config/committers.py:
- 10:09 AM WebKit Team edited by
- adding myself as a committer (diff)
- 9:53 AM Changeset in webkit [143011] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip failing tests on EFL wk1 and wk2 bots.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 9:31 AM Changeset in webkit [143010] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Enable shape-inside support for circles
https://bugs.webkit.org/show_bug.cgi?id=109713
Patch by Hans Muller <hmuller@adobe.com> on 2013-02-15
Reviewed by Dirk Schulze.
Source/WebCore:
Removed the test that disabled circle values for shape-inside.
The remaining support for circles, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.
Test: fast/exclusions/shape-inside/shape-inside-circle.html
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Now only disallows ellipse.
LayoutTests:
Added a test for circle shape-inside values.
- fast/exclusions/shape-inside/shape-inside-circle-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-circle.html: Added.
- 9:09 AM Changeset in webkit [143009] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Leverage new soup_cookie_jar_get_cookie_list() API
https://bugs.webkit.org/show_bug.cgi?id=109931
Reviewed by Kenneth Rohde Christiansen.
In several cases, the CookieJarSoup implementation was retrieving / copying ALL the
cookies using soup_cookie_jar_all_cookies() and then using soup_cookie_applies_to_uri()
to filter out cookies it is not interested in. This was inefficient.
In libsoup 2.40, soup_cookie_jar_get_cookie_list() was introduced to retrieve only the
cookies that apply to a given URI. This patch leverages this new API in CookieJarSoup's
getRawCookies() and deleteCookie(). This way, only the cookies we are interested in
are retrieved and copied. Libsoup does not need to iterate over all the cookies itself
because it keeps the cookies in a hash table using the host names as key.
No new tests, no behavior change.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- 9:09 AM Changeset in webkit [143008] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside BatteryProvider and NetworkInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=107821
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-15
Reviewed by Anders Carlsson.
BatteryProvider and NetworkInfoProvider should use C API
instead of accessing the internal C++ classes directly.
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
- UIProcess/efl/BatteryProvider.cpp:
(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):
- UIProcess/efl/BatteryProvider.h:
(BatteryProvider):
- UIProcess/efl/NetworkInfoProvider.cpp:
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
- UIProcess/efl/NetworkInfoProvider.h:
(NetworkInfoProvider):
- 9:07 AM Changeset in webkit [143007] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][EFL]REGRESSION (r141978): ewk_view_type_check api test failing
https://bugs.webkit.org/show_bug.cgi?id=109038
Reviewed by Anders Carlsson.
EFL API is defensive by its nature and expects graceful handling of wrong function arguments
whereas webkit implementation code does not. This patch adds new 'toEwkViewChecked' function,
which provides handling of wrong arguments, to be used within EFL API layer code.
- UIProcess/API/efl/EwkView.cpp:
(toEwkView):
EwkView* toEwkView(const Ewk_View_Smart_Data* smartData) is not exported anymore
as it's used within EwkView class only.
(EwkView::handleTouchMove):
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/ewk_view.cpp:
(toEwkViewChecked):
- 9:05 AM Changeset in webkit [143006] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: Added an option to split Elements and Sources sidebars in two panes.
https://bugs.webkit.org/show_bug.cgi?id=109298.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-15
Reviewed by Vsevolod Vlasov.
Introduced the "Split sidebar" context menu option that splits the horizontal sidebar into two panes.
The width split ratio is 1:1 by default and is preserved when the Inspector window is resized.
Elements sidebar is split into two tabbed panes, Sources sidebar is split into a pane stack and a tabbed pane.
No new tests.
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._populateContextMenuForSidebar.toggleSetting):
(WebInspector.ElementsPanel.prototype.get _arrangeSidebarPanes.get this):
(WebInspector.ElementsPanel.prototype.addExtensionSidebarPane):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):
(WebInspector.ScriptsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ScriptsPanel.prototype._populateContextMenuForSidebar.toggleSetting):
(WebInspector.ScriptsPanel.prototype.get _arrangeSidebarPanes.get this):
- inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarPaneTitle.prototype._expand):
(WebInspector.SidebarPaneTitle.prototype._collapse):
(WebInspector.SidebarPaneTitle.prototype._toggleExpanded):
(WebInspector.SidebarPaneTitle.prototype._onTitleKeyDown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):
- inspector/front-end/SidebarView.js:
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
(WebInspector.SplitView.prototype.get mainElement):
(WebInspector.SplitView.prototype.get sidebarElement):
- 8:53 AM Changeset in webkit [143005] by
-
- 5 edits in trunk
Web Inspector: Several consecutive Backspace or Delete strikes should not be marked as undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109915
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted _isEditRangeUndoBoundary() and _isEditRangeAdjacentToLastCommand() in TextEditorModel
to detect if markUndoableState() call is needed before and after editRange.
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.prototype.immediatelyPrecedes):
(WebInspector.TextRange.prototype.immediatelyFollows):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
- inspector/editor/text-editor-undo-redo-expected.txt:
- inspector/editor/text-editor-undo-redo.html:
- 8:49 AM Changeset in webkit [143004] by
-
- 10 edits6 deletes in trunk/Source/WebKit2
[EFL][WK2] Have WebView subclass PageClient
https://bugs.webkit.org/show_bug.cgi?id=109684
Reviewed by Anders Carlsson.
Stop constructing the PageClient in EwkView. PageClient is an internal
class and we should not use it directly in our Ewk implementation.
Instead, have WebView subclass PageClient. The PageClient implementation
just calls WebView methods otherwise.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::setSize):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
(EwkView::webView):
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/efl/PageClientBase.cpp: Removed.
- UIProcess/efl/PageClientBase.h: Removed.
- UIProcess/efl/PageClientDefaultImpl.cpp: Removed.
- UIProcess/efl/PageClientDefaultImpl.h: Removed.
- UIProcess/efl/PageClientLegacyImpl.cpp: Removed.
- UIProcess/efl/PageClientLegacyImpl.h: Removed.
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
- UIProcess/efl/PageViewportControllerClientEfl.h:
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::evasObject):
(WebKit::WebView::setThemePath):
(WebKit::WebView::setDrawsBackground):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::createDrawingAreaProxy):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::displayView):
(WebKit::WebView::scrollView):
(WebKit::WebView::viewSize):
(WebKit::WebView::isViewWindowActive):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
(WebKit::WebView::isViewInWindow):
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
(WebKit::WebView::pageClosed):
(WebKit::WebView::toolTipChanged):
(WebKit::WebView::setCursor):
(WebKit::WebView::setCursorHiddenUntilMouseMoves):
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
(WebKit::WebView::screenToWindow):
(WebKit::WebView::windowToScreen):
(WebKit::WebView::doneWithKeyEvent):
(WebKit::WebView::doneWithTouchEvent):
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorChooserProxy):
(WebKit::WebView::setFindIndicator):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::updateAcceleratedCompositingMode):
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
(WebKit::WebView::customRepresentationZoomFactor):
(WebKit::WebView::setCustomRepresentationZoomFactor):
(WebKit::WebView::flashBackingStoreUpdates):
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
(WebKit::WebView::updateTextInputState):
(WebKit::WebView::handleDownloadRequest):
(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- UIProcess/efl/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::page):
(WebKit::WebView::canScrollView):
- 8:26 AM Changeset in webkit [143003] by
-
- 2 edits in trunk/Source/WebCore
Fix inconsistency in WebGLRenderingContext.idl for getAttribLocation
https://bugs.webkit.org/show_bug.cgi?id=109892
Reviewed by Kentaro Hara.
- html/canvas/WebGLRenderingContext.idl:
- 8:21 AM Changeset in webkit [143002] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip failing WebGL conformance tests added in r142851.
- platform/efl-wk2/TestExpectations:
- 8:12 AM Changeset in webkit [143001] by
-
- 2 edits in trunk
Unreviewed build fix.
- Source/autotools/SetupLibtool.m4: Move AR_FLAGS definition so it comes before dolt
and libtool initialization, thus having an effect once again.
- 7:56 AM Changeset in webkit [143000] by
-
- 12 edits2 adds in trunk
Web Inspector: [Canvas] show replay log grouped by draw calls
https://bugs.webkit.org/show_bug.cgi?id=109592
Reviewed by Pavel Feldman.
Source/WebCore:
Show canvas capturing log grouped by drawing calls.
Drive-by: extended Array.prototype with a handy peekLast function.
Drive-by: removed code dups in few places.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._selectedDrawCallGroupIndex):
(WebInspector.CanvasProfileView.prototype._appendCallNode):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setColumnVisible):
(WebInspector.DataGridNode.prototype.set hasChildren):
(WebInspector.DataGridNode.prototype.set revealed):
(WebInspector.DataGridNode.prototype.get leftPadding):
- inspector/front-end/externs.js:
(Array.prototype.peekLast):
- inspector/front-end/utilities.js:
LayoutTests:
A test to dump canvas replay log.
- inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt: Added.
- inspector/profiler/canvas2d/canvas-replay-log-grid.html: Added.
- 7:47 AM Changeset in webkit [142999] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: highlight record revealed in Timeline
https://bugs.webkit.org/show_bug.cgi?id=109930
Reviewed by Pavel Feldman.
Revealed timeline record is now highlighted with yellow background
that fades out in 2 seconds.
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._revealRecord):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._clearRecordHighlight):
- inspector/front-end/timelinePanel.css:
(.highlighted-timeline-record):
(@-webkit-keyframes timeline_record_highlight):
(to):
- 7:45 AM Changeset in webkit [142998] by
-
- 6 edits in trunk
Web Inspector: Pass original selection to textModel to correctly restore it after undo.
https://bugs.webkit.org/show_bug.cgi?id=109911
Reviewed by Pavel Feldman.
Source/WebCore:
We can distinguish backspace pressed with and without selection now.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlBackspace):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorCommand):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
- inspector/editor/text-editor-undo-redo-expected.txt:
- inspector/editor/text-editor-undo-redo.html:
- 7:33 AM Changeset in webkit [142997] by
-
- 3 edits in trunk/Source/WebKit2
[Qt] Restore URL Scheme Delegates after QtWebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=108808
When the QtWebProcess crashes, the registered URL Scheme
Delegates are not properly restored over IPC in the newly
launched process instance.
Patch by Milian Wolff <milian.wolff@kdab.com> on 2013-02-15
Reviewed by Simon Hausmann.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::updateSchemeDelegates):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- 7:25 AM Changeset in webkit [142996] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Remove redundant requireAuth parameter of NetworkJob::notifyAuthReceived
https://bugs.webkit.org/show_bug.cgi?id=109855
Patch by Joe Mason <jmason@rim.com> on 2013-02-15
Reviewed by Yong Li.
Internal PR: 296697
Internally Reviewed By: Leo Yang
Code cleanup: The requireAuth parameter of NetworkJob::notifyAuthReceived is redundant as its value
can be determined from "result" - if result is AuthResultRetry, requireAuth is false, otherwise it
is true.
No new tests as there is no behaviour change.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- 7:03 AM QtWebKitBuildBots edited by
- (diff)
- 6:56 AM Changeset in webkit [142995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium rebaselines for r142947.
- platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
- 6:55 AM Changeset in webkit [142994] by
-
- 4 edits in trunk
Web Inspector: Redo in text editor should always collapse selection to end.
https://bugs.webkit.org/show_bug.cgi?id=109907
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
- inspector/editor/text-editor-undo-redo-expected.txt:
- 6:53 AM Changeset in webkit [142993] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip failing tests after r142947.
- platform/efl/TestExpectations:
- 6:42 AM Changeset in webkit [142992] by
-
- 46 edits1 add in trunk/LayoutTests
Unreviewed chromium expectations changes for r142947.
- platform/chromium-mac-lion/media/audio-repaint-expected.png:
- platform/chromium-mac-lion/media/controls-after-reload-expected.png:
- platform/chromium-mac-lion/media/controls-strict-expected.png:
- platform/chromium-mac-lion/media/controls-styling-expected.png:
- platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
- platform/chromium-mac-lion/media/controls-without-preload-expected.png:
- platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Added.
- platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
- platform/chromium-mac-lion/media/video-display-toggle-expected.png:
- platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
- platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
- platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
- platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
- platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
- platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
- platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
- platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
- platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
- platform/chromium-mac/media/audio-repaint-expected.png:
- platform/chromium-mac/media/controls-after-reload-expected.png:
- platform/chromium-mac/media/controls-strict-expected.png:
- platform/chromium-mac/media/controls-styling-expected.png:
- platform/chromium-mac/media/controls-styling-strict-expected.png:
- platform/chromium-mac/media/controls-without-preload-expected.png:
- platform/chromium-mac/media/media-document-audio-repaint-expected.png:
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac/media/video-controls-rendering-expected.png:
- platform/chromium-mac/media/video-display-toggle-expected.png:
- platform/chromium-mac/media/video-playing-and-pause-expected.png:
- platform/chromium-mac/media/video-zoom-controls-expected.txt:
- platform/chromium-win/media/audio-repaint-expected.png:
- platform/chromium-win/media/controls-after-reload-expected.png:
- platform/chromium-win/media/controls-strict-expected.png:
- platform/chromium-win/media/controls-styling-expected.png:
- platform/chromium-win/media/controls-styling-strict-expected.png:
- platform/chromium-win/media/controls-without-preload-expected.png:
- platform/chromium-win/media/media-document-audio-repaint-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-win/media/video-controls-rendering-expected.png:
- platform/chromium-win/media/video-display-toggle-expected.png:
- platform/chromium-win/media/video-playing-and-pause-expected.png:
- platform/chromium/TestExpectations:
- 6:38 AM Changeset in webkit [142991] by
-
- 6 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt/TestExpectations:
- platform/qt/fast/replaced/width100percent-image-expected.png: Added after r142931.
- platform/qt/fast/replaced/width100percent-image-expected.txt: Added after r142931.
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added after r142931.
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added after r142931.
- 6:20 AM Changeset in webkit [142990] by
-
- 5 edits1 delete in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaselining after r142931 and r142759.
- platform/efl/fast/replaced/width100percent-image-expected.png:
- platform/efl/fast/replaced/width100percent-image-expected.txt:
- platform/efl/svg/dom/SVGLengthList-basics-expected.txt: Removed.
- platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 6:15 AM Changeset in webkit [142989] by
-
- 2 edits in trunk/Source/WebCore
[v8] persistent handle dispose before last use
https://bugs.webkit.org/show_bug.cgi?id=109927
Patch by Dan Carney <dcarney@google.com> on 2013-02-15
Reviewed by Jochen Eisinger.
No new tests. No change in functionality.
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::weakCallback):
- 6:05 AM Changeset in webkit [142988] by
-
- 15 edits in trunk/Source
PagePopupController.formatMonth should support short month format
https://bugs.webkit.org/show_bug.cgi?id=109530
Reviewed by Kent Tamura.
Source/WebCore:
PagePopupController.formatMonth should support short month format so we
can use it in the new calendar picker.
Tested by LocaleMacTest::formatMonth.
- page/PagePopupController.cpp:
(WebCore::PagePopupController::formatMonth): Take an extra bool argument to switch to short month format.
- page/PagePopupController.h:
(PagePopupController):
- page/PagePopupController.idl:
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::shortMonthFormat):
(WebCore):
- platform/text/LocaleICU.h:
(LocaleICU):
- platform/text/LocaleNone.cpp:
(WebCore::shortMonthFormat):
(WebCore):
- platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::visitField):
(WebCore::Locale::formatDateTime):
- platform/text/PlatformLocale.h:
(Locale):
- platform/text/mac/LocaleMac.h:
(LocaleMac):
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::shortMonthFormat):
(WebCore):
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::shortMonthFormat): Windows doesn't have a short
month format so we just replace MMMM with MMM.
(WebCore):
- platform/text/win/LocaleWin.h:
(LocaleWin):
Source/WebKit/chromium:
- tests/LocaleMacTest.cpp:
(LocaleMacTest::formatMonth):
(TEST_F):
- 5:36 AM Changeset in webkit [142987] by
-
- 21 edits in trunk
Add setValue and closePopup methods to PagePopupController
https://bugs.webkit.org/show_bug.cgi?id=109897
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Added mock setValue and closePopup implementation.
- ManualTests/forms/color-suggestion-picker.html: Ditto.
Source/WebCore:
The new calendar picker (Bug 109439) needs to set a value without
closing the popup. We can't do that with the existing
setValueAndClosePopup.
No new tests. Existing calendar picker and color suggestion picker tests
that closing and setting values work properly.
- Resources/pagepopups/pickerCommon.js:
(Picker.prototype.submitValue): Stop using setValueAndClosePopup.
(Picker.prototype.handleCancel): Ditto.
- page/PagePopupClient.h:
(PagePopupClient):
- page/PagePopupController.cpp:
(WebCore::PagePopupController::setValue): Sets value to element without closing popup.
(WebCore):
(WebCore::PagePopupController::closePopup): Just closes popup.
- page/PagePopupController.h:
(PagePopupController):
- page/PagePopupController.idl:
Source/WebKit/blackberry:
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::setValue): Added empty implementation.
(WebCore):
- WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient):
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValue): Ditto.
(WebCore):
- WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValue): Ditto.
(WebCore):
- WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):
Source/WebKit/chromium:
- src/ColorChooserPopupUIController.cpp:
(WebKit::ColorChooserPopupUIController::setValue):
(WebKit):
- src/ColorChooserPopupUIController.h:
(ColorChooserPopupUIController):
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::setValueAndClosePopup): Use setValue and closePopup.
(WebKit):
(WebKit::DateTimeChooserImpl::setValue):
(WebKit::DateTimeChooserImpl::closePopup):
- src/DateTimeChooserImpl.h:
(DateTimeChooserImpl):
- 5:18 AM Changeset in webkit [142986] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL WK1 gardening.
EFL WK1 doesn't support WebGL conformance tests which were added by r142847.
- platform/efl-wk1/TestExpectations: Skipped WebGL conformance tests.
- 5:04 AM Changeset in webkit [142985] by
-
- 1 edit2 moves1 add in trunk/LayoutTests
Unreviewed chromium expectations update for r142955.
- platform/chromium-mac/svg/filters/filter-hidden-content-expected.png: Added.
- platform/chromium-win/svg/filters/filter-hidden-content-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png.
- platform/chromium/svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.txt.
- 5:00 AM Changeset in webkit [142984] by
-
- 10 edits in trunk
[CSS Regions] RenderRegion should inherit from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=74132
Reviewed by Julien Chaffraix.
Source/WebCore:
Change the base class for RenderRegion to be RenderBlock instead of RenderReplaced.
Per spec http://dev.w3.org/csswg/css3-regions/#the-flow-from-property, a region is a non-replaced block container.
This change is covered by the existing regions tests (in fast/region and fast/repaint).
The RenderFlowThread object is a self-painting layer (it requires layer and is positioned).
Because of that, the RenderFlowThread object is responsible for painting its children,
the collected objects. When the RenderRegion::paintObject is called during paint, it delegates painting
of content collected inside the flow thread to the associated RenderFlowThread object.
Since we do not want to paint the flow thread content multiple times (for each paint phase
in which the RenderRegion::paintObject is called), we allow RenderFlowThread painting only for
selection and foreground paint phases.
- rendering/RenderBox.cpp: Clean-up the code from regions specific stuff, now that the regions are render blocks.
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
- rendering/RenderLayerBacking.cpp: A region should always render content from its associated flow thread,
even when it does not have children of its own.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
- rendering/RenderMultiColumnSet.cpp: Make changes to match the new inheritance for RenderRegion.
(WebCore::RenderMultiColumnSet::paint):
(WebCore::RenderMultiColumnSet::paintColumnRules):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::willBeRemovedFromTree):
(WebCore::RenderRegion::computePreferredLogicalWidths): Use this method instead of min/maxPreferredLogicalWidth.
(WebCore::RenderRegion::updateLogicalHeight):
- rendering/RenderRegion.h: For now, assume the region is not allowed to have children.
When we will implement the processing model for pseudo-elements http://dev.w3.org/csswg/css3-regions/#processing-model,
we will have to remove this function. By having this function return false i was able to leave some tests unchanged.
LayoutTests:
Fix tests that were failing after the inheritance change.
- fast/regions/flows-dependency-dynamic-remove.html: As a block, an empty region can self collapse,
which was not possible for a replaced element. I used '-webkit-margin-collapse: separate' to prevent
margins self collapsing for body and avoid recreating the expectations.
I want regions margins to be able to self collapse, just like the other block elements.
- fast/regions/flows-dependency-same-flow.html: Ditto.
- 4:30 AM Changeset in webkit [142983] by
-
- 9 edits2 adds in trunk
Web Inspector: implement smart braces functionality
https://bugs.webkit.org/show_bug.cgi?id=109200
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-15
Reviewed by Pavel Feldman.
Source/WebCore:
- implement SmartBraceController which will handle character insertions
and override them if brace character was inserted. Additionally it
should handle Backspace key and override it if a cursor is located
inside of a bracket pair.
- guard smart brace functionality via experiment checkbox.
New test: inspector/editor/text-editor-smart-braces.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleKeyPress):
(WebInspector.TextEditorMainPanel.SmartBraceController):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype.registerShortcuts):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype.registerCharOverrides):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleBackspace):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleBracePairInsertion):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleClosingBraceOverride):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
Tools:
Fix eventSender.keyDown implementation to correctly process opening
round brace symbol.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::keyDown):
LayoutTests:
- inspector/editor/text-editor-smart-braces-expected.txt: Added.
- inspector/editor/text-editor-smart-braces.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 4:28 AM Changeset in webkit [142982] by
-
- 7 edits in trunk
[CSS Regions][Mac] fast/regions/full-screen-video-from-region.html hits an assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=106075
Patch by Andrei Bucur <abucur@adobe.com> on 2013-02-15
Reviewed by Tony Chang.
Source/WebCore:
The crash is caused by two issues.
The first problem is how a block inside a flow thread determines if the children needs relayout or not.
When the region chain is invalidated, the information is lost so we need to return true, even for the
enclosing RenderFlowThread. Because the video renderer is the first child of the flow thread this doesn't
happen.
The patch implements this behaviour by inspecting both if the region chain has changed and
if the block has no range computed yet.
The second problem is RenderMedia not inheriting from RenderBlock. The logic of child relayout doesn't apply
to it. In the test case, when the full screen button is pressed, the region changes width to fill the viewport,
the chain is invalidated and the box info hash map is cleared. When the video is laid out again (after fixing
the first issue) it has the same size so the controls don't do a layout. They remain without box info inside
the flow thread, thus causing the assertion.
The patch forces the controls to relayout if the region chain was invalidated. We can't use the
logicalWidthChangedInRegions method because it is block specific. This will be fixed in a later patch.
Tests: No new tests. fast/regions/full-screen-video-from-region.html no longer crashes.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
- rendering/RenderFlowThread.h: Renamed pageLogicalHeightChanged to pageLogicalSizeChanged.
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
LayoutTests:
Removed the crash/fail expectation for fast/regions/full-screen-video-from-region.html.
- platform/mac/TestExpectations:
- 4:25 AM Changeset in webkit [142981] by
-
- 10 edits2 copies1 move1 delete in trunk/LayoutTests
Unreviewed chromium expectation changes after r142931.
- platform/chromium-mac-lion/fast/replaced/width100percent-image-expected.png:
- platform/chromium-mac-lion/fast/replaced/width100percent-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-image-expected.txt.
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-image-expected.txt.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-image-expected.txt:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
- platform/chromium-win/fast/replaced/width100percent-image-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt.
- 4:18 AM Changeset in webkit [142980] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- 4:09 AM Changeset in webkit [142979] by
-
- 7 edits2 adds in trunk
Source/WebCore: [CoordGfx] Regression from r135212: big layers with transform animations sometime fail to render tiles
https://bugs.webkit.org/show_bug.cgi?id=109179
Reviewed by Jocelyn Turcotte.
Fix adjustForContentsRect logic for AC layers that are higher or wider than the visible rect.
Force updates of the visible rect while it is animating, and until we have done one last update after
it stops animating.
Test: compositing/transitions/transform-on-large-layer.html
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
LayoutTests: [CoordGfx] Regression from r135212: big layers with transform animations sometime fail to render tiles.
https://bugs.webkit.org/show_bug.cgi?id=109179
Reviewed by Jocelyn Turcotte.
Test of a large layer with an animated transform. Skipped on WK1 due to resize event not firing in DRT.
- compositing/transitions/transform-on-large-layer-expected.html: Added.
- compositing/transitions/transform-on-large-layer.html: Added.
- platform/mac/TestExpectations:
- platform/qt-5.0-wk1/TestExpectations:
- 3:40 AM Changeset in webkit [142978] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r142876.
http://trac.webkit.org/changeset/142876
https://bugs.webkit.org/show_bug.cgi?id=109920
Broke relative URL linkification in the computed styles pane
(Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
- 2:46 AM Changeset in webkit [142977] by
-
- 46 edits in trunk
Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720
.:
Reviewed by Julien Chaffraix.
Update exported symbols.
- Source/autotools/symbols.filter:
Source/WebCore:
Reviewed by Julien Chaffraix.
The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.
- WebCore.exp.in:
- WebCore.order:
- dom/Document.cpp:
(WebCore::Document::nodesFromRect):
- dom/Document.h:
(Document):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
- page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):
- page/EventHandler.h:
(WebCore):
(EventHandler):
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
- page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::allowsFrameScrollbars):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
Source/WebKit/blackberry:
Reviewed by Julien Chaffraix.
Update calls to new API.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
Source/WebKit/chromium:
Reviewed by Julien Chaffraix.
Update calls to new API.
- src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::hitTestResultForWindowPos):
Source/WebKit/efl:
Reviewed by Julien Chaffraix.
Update calls to new API.
- ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
Source/WebKit/mac:
Reviewed by Julien Chaffraix.
Update calls to new API.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary):
- WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
Source/WebKit/qt:
Reviewed by Julien Chaffraix.
Update calls to new API.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::hitTestContent):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::TouchAdjuster::findCandidatePointForTouch):
(QWebPageAdapter::handleSoftwareInputPanel):
(QWebPageAdapter::updatePositionDependentMenuActions):
Source/WebKit/win:
Reviewed by Julien Chaffraix.
Update calls to new API.
- WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
- WebKit.vcproj/WebKitExports.def.in:
- WebView.cpp:
(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):
Source/WebKit/wx:
Reviewed by Julien Chaffraix.
Update calls to new API.
- WebFrame.cpp:
(WebKit::WebFrame::HitTest):
Source/WebKit2:
Reviewed by Julien Chaffraix and Maciej Stachowiak.
Update calls to new API and update exported symbols.
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hitTest):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
- 2:37 AM Changeset in webkit [142976] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: make component-based compile-front-end happy
https://bugs.webkit.org/show_bug.cgi?id=109798
Reviewed by Vsevolod Vlasov.
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setVariableValue):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/compile-front-end.py:
- inspector/front-end/AuditResultView.js:
- inspector/front-end/CPUProfileView.js:
- inspector/front-end/DataGrid.js:
- inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.loadTimelineFromURL):
- 2:29 AM Changeset in webkit [142975] by
-
- 12 edits3 adds in trunk
Web Inspector: Implement tracking of active stylesheets in the frontend
https://bugs.webkit.org/show_bug.cgi?id=105828
Reviewed by Pavel Feldman.
Source/WebCore:
- This change introduces the CSS.styleSheetAdded() and CSS.styleSheetRemoved() events
that update the frontend with all active stylesheet changes in the inspected page.
As such, fetching stylesheet headers from the backend manually is no longer needed,
and many asynchronous methods have been turned into normal accessors.
- One notable change to the stylesheet binding process is that when a via-inspector stylesheet
is created, it is instantly reported through the instrumentation, and the viaInspectorStyleSheet() method
is [indirectly] called recursively from bindStyleSheet(). Thus, the actual creation and registration
of the respective InspectorStyleSheet have been moved into bindStyleSheet(),
which relies upon the m_creatingViaInspectorStyleSheet flag.
Test: inspector/styles/stylesheet-tracking.html
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Instrumented.
- inspector/Inspector.json: Add events, update the CSS domain description.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable): Push all existing stylesheet headers into the frontend.
(WebCore::InspectorCSSAgent::activeStyleSheetsUpdated): Push added/removed stylesheet into the frontend.
(WebCore::InspectorCSSAgent::getAllStyleSheets): Slightly refactored to make use of collectAllStyleSheets().
(WebCore::InspectorCSSAgent::collectAllStyleSheets): Added to collect InspectorStyleSheets rather than headers.
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet): Binds via-inspector stylesheets, too.
(WebCore::InspectorCSSAgent::unbindStyleSheet): Now we can unbind stylesheets upon their removal from the document.
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet): Modifies m_creatingViaInspectorStyleSheet when necessary.
(WebCore::InspectorCSSAgent::detectOrigin): Modified to make use of m_creatingViaInspectorStyleSheet.
(WebCore::InspectorCSSAgent::buildObjectForRule): Removed extraneous bound InspectorStyleSheet 0-check.
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp: Instrumentation of active stylesheet set updates.
(WebCore::InspectorInstrumentation::activeStyleSheetsUpdatedImpl):
- inspector/InspectorInstrumentation.h: Ditto.
(WebCore::InspectorInstrumentation::activeStyleSheetsUpdated):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.styleSheetHeaders):
(WebInspector.CSSStyleModel.prototype._styleSheetAdded): Added.
(WebInspector.CSSStyleModel.prototype._styleSheetRemoved): Added.
(WebInspector.CSSStyleModel.prototype.viaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype._setHeaderForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype.resourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype.styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._headerKey): Calculate the (frameID + URL) key for CSSStyleSheetHeader.
(WebInspector.CSSStyleModelResourceBinding.prototype._createInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._inspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
(WebInspector.CSSDispatcher.prototype.styleSheetAdded): Added.
(WebInspector.CSSDispatcher.prototype.styleSheetRemoved): Added.
- inspector/front-end/SASSSourceMapping.js: Get rid of async implementations.
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
- inspector/front-end/StylesSidebarPane.js: Ditto.
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
- inspector/front-end/StylesSourceMapping.js: Ditto.
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
LayoutTests:
- inspector/styles/resources/stylesheet-tracking.css: Added.
- inspector/styles/stylesheet-tracking-expected.txt: Added.
- inspector/styles/stylesheet-tracking.html: Added.
- 2:22 AM Changeset in webkit [142974] by
-
- 5 edits8 adds in trunk
Implement the -webkit-margin-collapse properties correct rendering
https://bugs.webkit.org/show_bug.cgi?id=108168
Patch by Andrei Bucur <abucur@adobe.com> on 2013-02-15
Reviewed by David Hyatt.
Source/WebCore:
The patch implements the correct behavior for the -webkit-margin-collapse properties:
- a value of "discard" on a margin will truncate all the margins collapsing with it;
- a value of "separate" will prevent the margin to collapse;
- a value of "collapse" is the default collapse behavior.
The implementation is aware of multiple writing-modes:
- if the writing mode of a child is parallel with the writing mode of the container and has the same direction,
the -webkit-margin-collapse properties on the child are left as is;
- if the writing mode of a child is parallel with the writing mode of the container but has a different direction,
the -webkit-margin-collapse properties on the child are reversed;
- if the writing mode of a child is perpendicular on the writing mode of the container,
the -webkit-margin-collapse properties on the child are ignored;
- The "discard" value implementation
There are two new bits (before and after) added on the RenderBlockRareData structure specifying if the margins
of the block will be discarded or not. We can't rely only on the value from style() because
it's possible a block to discard it's margins because it has collapsed with a children that
specified "discard" for -webkit-margin-collapse. However, the bits are set only if it is
required.
Another bit is added on the MarginInfo structure specifying if the margin has to be discarded or not. When
collapsing at the before side of a block it will hold information if the container block needs to discard
or not. If the collapsing happens between siblings/with after side of the container it will tell if the previous
child discards the margin or not. The self collapsing blocks are a special case. If any of its margins
discards then both its margins discard and all the other margins collapsing with it.
To ensure an optimal behavior it is asserted margin values can't be set on the MarginInfo object if the
discard flag is active. If this happens it may indicate someone ignored the possibility of the margin being
discarded altogether and incorrectly updated the margin values.
Float clearing also needs to change because it may force margins to stop collapsing. If this happens the discard
flags and margins needs to be restored to their values before the collapse.
- The "separate" value implementation
The implementation for separate was not changed too much. I've added new accessor methods for the property
that take writing mode into consideration and I've removed some code that didn't work correctly in layoutBlockChild.
The problem was the marginInfo structure was cleared if the child was specifying the "separate" value for before.
This is wrong because you lose the margin information of the previous child/before side.
Tests: fast/block/margin-collapse/webkit-margin-collapse-container.html
fast/block/margin-collapse/webkit-margin-collapse-floats.html
fast/block/margin-collapse/webkit-margin-collapse-siblings-bt.html
fast/block/margin-collapse/webkit-margin-collapse-siblings.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMustDiscardMarginBefore):
(WebCore):
(WebCore::RenderBlock::setMustDiscardMarginAfter):
(WebCore::RenderBlock::mustDiscardMarginBefore):
(WebCore::RenderBlock::mustDiscardMarginAfter):
(WebCore::RenderBlock::mustDiscardMarginBeforeForChild):
(WebCore::RenderBlock::mustDiscardMarginAfterForChild):
(WebCore::RenderBlock::mustSeparateMarginBeforeForChild):
(WebCore::RenderBlock::mustSeparateMarginAfterForChild):
- rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::initMaxMarginValues):
(MarginInfo):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::setCanCollapseMarginAfterWithChildren):
(WebCore::RenderBlock::MarginInfo::setDiscardMargin):
(WebCore::RenderBlock::MarginInfo::discardMargin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(RenderBlockRareData):
- rendering/style/RenderStyle.h:
LayoutTests:
Four new tests covering the -webkit-margin-collapse property basic behavior: collapsing
between a block container and its children, collapsing between sibling boxes in both TTB
and BTT direction. The last test verifies if a container's before margin correctly resets
the discard value after a clear of the child that initally caused it.
- fast/block/margin-collapse/webkit-margin-collapse-container-expected.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-container.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-floats-expected.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-floats.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-siblings-bt-expected.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-siblings-bt.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-siblings-expected.html: Added.
- fast/block/margin-collapse/webkit-margin-collapse-siblings.html: Added.
- 1:49 AM Changeset in webkit [142973] by
-
- 2 edits in trunk/Tools
Speculative build fix for chromium-win.
Unreviewed build fix.
Add declarations of the copy constructor and assignment operator to
WebTestProxyBase, so VS doesn't try to generate them.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- 1:44 AM Changeset in webkit [142972] by
-
- 10 edits1 delete in trunk
[Qt] Port GCController to JSC C API
https://bugs.webkit.org/show_bug.cgi?id=109690
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-15
Reviewed by Benjamin Poulain.
Source/WebKit/qt:
Add hooks to retrieve JSContextRef and window object.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::getJSWindowObject):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
Rename TestRunner to TestRunnerQt to avoid conflict when
including TestRunner.h in the future.
Replaced QObject based GCController implementation with JSC C API
based one.
- DumpRenderTree/qt/DumpRenderTree.pro:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::initJSObjects):
(WebCore::methodNameStringForFailedTest):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::DumpRenderTree::testRunner):
(DumpRenderTree):
- DumpRenderTree/qt/GCControllerQt.cpp:
(GCController::getJSObjectCount):
- DumpRenderTree/qt/GCControllerQt.h: Removed.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::TestRunnerQt):
(TestRunnerQt::reset):
(TestRunnerQt::dumpNotifications):
(TestRunnerQt::processWork):
(TestRunnerQt::maybeDump):
(TestRunnerQt::dumpAsText):
(TestRunnerQt::waitUntilDone):
(TestRunnerQt::setViewModeMediaFeature):
(TestRunnerQt::webHistoryItemCount):
(TestRunnerQt::keepWebHistory):
(TestRunnerQt::notifyDone):
(TestRunnerQt::windowCount):
(TestRunnerQt::grantWebNotificationPermission):
(TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
(TestRunnerQt::denyWebNotificationPermission):
(TestRunnerQt::removeAllWebNotificationPermissions):
(TestRunnerQt::simulateWebNotificationClick):
(TestRunnerQt::simulateLegacyWebNotificationClick):
(TestRunnerQt::display):
(TestRunnerQt::displayInvalidatedRegion):
(TestRunnerQt::clearBackForwardList):
(TestRunnerQt::pathToLocalResource):
(TestRunnerQt::dumpEditingCallbacks):
(TestRunnerQt::dumpFrameLoadCallbacks):
(TestRunnerQt::dumpProgressFinishedCallback):
(TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
(TestRunnerQt::dumpResourceLoadCallbacks):
(TestRunnerQt::dumpResourceResponseMIMETypes):
(TestRunnerQt::dumpWillCacheResponse):
(TestRunnerQt::dumpHistoryCallbacks):
(TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
(TestRunnerQt::setWillSendRequestReturnsNull):
(TestRunnerQt::setWillSendRequestClearHeader):
(TestRunnerQt::setDeferMainResourceDataLoad):
(TestRunnerQt::queueBackNavigation):
(TestRunnerQt::queueForwardNavigation):
(TestRunnerQt::queueLoad):
(TestRunnerQt::queueLoadHTMLString):
(TestRunnerQt::queueReload):
(TestRunnerQt::queueLoadingScript):
(TestRunnerQt::queueNonLoadingScript):
(TestRunnerQt::provisionalLoad):
(TestRunnerQt::timerEvent):
(TestRunnerQt::encodeHostName):
(TestRunnerQt::decodeHostName):
(TestRunnerQt::closeWebInspector):
(TestRunnerQt::setDeveloperExtrasEnabled):
(TestRunnerQt::setAsynchronousSpellCheckingEnabled):
(TestRunnerQt::showWebInspector):
(TestRunnerQt::evaluateInWebInspector):
(TestRunnerQt::goBack):
(TestRunnerQt::setDefersLoading):
(TestRunnerQt::setAllowUniversalAccessFromFileURLs):
(TestRunnerQt::setAllowFileAccessFromFileURLs):
(TestRunnerQt::setAppCacheMaximumSize):
(TestRunnerQt::setAutofilled):
(TestRunnerQt::setValueForUser):
(TestRunnerQt::setFixedContentsSize):
(TestRunnerQt::setPrivateBrowsingEnabled):
(TestRunnerQt::setSpatialNavigationEnabled):
(TestRunnerQt::setPopupBlockingEnabled):
(TestRunnerQt::setPluginsEnabled):
(TestRunnerQt::setPOSIXLocale):
(TestRunnerQt::setWindowIsKey):
(TestRunnerQt::setMainFrameIsFirstResponder):
(TestRunnerQt::setJavaScriptCanAccessClipboard):
(TestRunnerQt::setXSSAuditorEnabled):
(TestRunnerQt::dispatchPendingLoadRequests):
(TestRunnerQt::clearAllApplicationCaches):
(TestRunnerQt::clearApplicationCacheForOrigin):
(TestRunnerQt::localStorageDiskUsageForOrigin):
(TestRunnerQt::setApplicationCacheOriginQuota):
(TestRunnerQt::applicationCacheDiskUsageForOrigin):
(TestRunnerQt::originsWithApplicationCache):
(TestRunnerQt::setCacheModel):
(TestRunnerQt::setDatabaseQuota):
(TestRunnerQt::clearAllDatabases):
(TestRunnerQt::addOriginAccessWhitelistEntry):
(TestRunnerQt::removeOriginAccessWhitelistEntry):
(TestRunnerQt::setCustomPolicyDelegate):
(TestRunnerQt::waitForPolicyDelegate):
(TestRunnerQt::overridePreference):
(TestRunnerQt::setUserStyleSheetLocation):
(TestRunnerQt::setCaretBrowsingEnabled):
(TestRunnerQt::setAuthorAndUserStylesEnabled):
(TestRunnerQt::setUserStyleSheetEnabled):
(TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
(TestRunnerQt::callShouldCloseOnWebView):
(TestRunnerQt::setScrollbarPolicy):
(TestRunnerQt::setSmartInsertDeleteEnabled):
(TestRunnerQt::setSelectTrailingWhitespaceEnabled):
(TestRunnerQt::execCommand):
(TestRunnerQt::isCommandEnabled):
(TestRunnerQt::findString):
(TestRunnerQt::markerTextForListItem):
(TestRunnerQt::computedStyleIncludingVisitedInfo):
(TestRunnerQt::elementDoesAutoCompleteForElementWithId):
(TestRunnerQt::authenticateSession):
(TestRunnerQt::setIconDatabaseEnabled):
(TestRunnerQt::setMockDeviceOrientation):
(TestRunnerQt::setGeolocationPermission):
(TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
(TestRunnerQt::setGeolocationPermissionCommon):
(TestRunnerQt::setMockGeolocationPositionUnavailableError):
(TestRunnerQt::setMockGeolocationPosition):
(TestRunnerQt::addMockSpeechInputResult):
(TestRunnerQt::setMockSpeechInputDumpRect):
(TestRunnerQt::startSpeechInput):
(TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
(TestRunnerQt::evaluateScriptInIsolatedWorld):
(TestRunnerQt::addUserStyleSheet):
(TestRunnerQt::removeAllVisitedLinks):
(TestRunnerQt::addURLToRedirect):
(TestRunnerQt::originsWithLocalStorage):
(TestRunnerQt::deleteAllLocalStorage):
(TestRunnerQt::deleteLocalStorageForOrigin):
(TestRunnerQt::observeStorageTrackerNotifications):
(TestRunnerQt::syncLocalStorage):
(TestRunnerQt::resetPageVisibility):
(TestRunnerQt::setPageVisibility):
(TestRunnerQt::setAutomaticLinkDetectionEnabled):
(TestRunnerQt::setTextDirection):
(TestRunnerQt::setAlwaysAcceptCookies):
(TestRunnerQt::setAlwaysBlockCookies):
(TestRunnerQt::setAudioData):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 1:02 AM Changeset in webkit [142971] by
-
- 2 edits in trunk/LayoutTests
[EFL] fast/forms/input-text-scroll-left-on-blur.html is passing now
https://bugs.webkit.org/show_bug.cgi?id=109896
Unreviewed efl gardening.
The expectations are added by r140250 and the test seems to be passing now.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-15
- platform/efl/TestExpectations:
- 1:00 AM Changeset in webkit [142970] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
ChangeLog fix for bug 109689.
https://bugs.webkit.org/show_bug.cgi?id=109689
Feb 14, 2013:
- 11:45 PM Changeset in webkit [142969] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: always show memory size in Mb on the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=109813
Reviewed by Pavel Feldman.
Memory size vlue is alway shown in Mb on the native memory graph.
- inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):
- 11:28 PM EnableFormFeatures edited by
- (diff)
- 11:15 PM Changeset in webkit [142968] by
-
- 17 edits in trunk/Source/WebKit2
[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=109885
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-14
Reviewed by Simon Fraser.
Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it
scrollOffset. So this patch corrects this misnaming.
In addition, all subclasses of LayerTreeHost don't use the misnamed
scrollOffset in scrollNonCompositedContents(), so this patch removes the
scrollOffset argument.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scroll):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scroll):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
- 11:01 PM Changeset in webkit [142967] by
-
- 2 edits in trunk/Source/WebCore
Use GL typedefs in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=109060
Reviewed by Kenneth Russell.
Use GL typedefs in WebGLRenderingContext.idl according to the specs.
Added a FIXME about inconsistency with the current WebGL spec for getAttribLocation.
Tested manually that generators V8, JS, ObjC, GObject, CPP produce same output.
- html/canvas/WebGLRenderingContext.idl:
- 10:41 PM Changeset in webkit [142966] by
-
- 5 edits in trunk/Source/JavaScriptCore
Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660
Reviewed by Sam Weinig.
This has a few benefits:
(*) Saves a few kB by removing a second cache data structure.
(*) Reduces the worst case memory usage of the cache by 1.75X. (Heavy
use of 'new Function' and other techniques could cause us to fill
both root caches, and they didn't trade off against each other.)
(*) Paves the way for future improvements based on a non-trivial
cache key (for example, shrinkable pointer to the key string, and
more precise cache size accounting).
Also cleaned up the cache implementation and simplified it a bit.
- heap/Handle.h:
(HandleBase):
- heap/Strong.h:
(Strong): Build!
- runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode): Updated for three interface changes:
(*) SourceCodeKey is a class, not a pair.
(*) Table values are abstract pointers, since they can be executables
or code blocks. (In a future patch, I'd like to change this so we
always store only code blocks. But that's too much for one patch.)
(*) The cache function is named "set" because it always overwrites
unconditionally.
- runtime/CodeCache.h:
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear): Added support for specifying hash traits, so we
can use a SourceCodeKey.
Removed side table and random number generator to save space and reduce
complexity. Hash tables are already random, so we don't need another source
of randomness.
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue): A SourceCodeKey is just a
fancy triplet: source code string; function name (or null, for non-functions);
and flags. Flags and function name distinguish between functions and programs
with identical code, so they can live in the same cache.
I chose to use the source code string as the primary hashing reference
because it's likely to be unique. We can use profiling to choose another
technique in future, if collisions between functions and programs prove
to be hot. I suspect they won't.
(JSC::CodeCache::clear):
(CodeCache): Removed the second cache.
- heap/Handle.h:
(HandleBase):
- heap/Strong.h:
(Strong):
- runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
- runtime/CodeCache.h:
(JSC):
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear):
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue):
(JSC::CodeCache::clear):
(CodeCache):
- 10:39 PM Changeset in webkit [142965] by
-
- 5 edits in trunk
Web Inspector: Copy-pasting selected text over itself should be an undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109830
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
- inspector/editor/text-editor-undo-redo-expected.txt:
- inspector/editor/text-editor-undo-redo.html:
- 10:33 PM Changeset in webkit [142964] by
-
- 2 edits in trunk/LayoutTests
Remove a test expectation now that the culprit has been rolled out in r142962.
- platform/mac/TestExpectations:
- 10:29 PM Changeset in webkit [142963] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed chromium test fix: incorrect field was used for UISourceCode url.
- src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
- 10:26 PM Changeset in webkit [142962] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r142889.
http://trac.webkit.org/changeset/142889
https://bugs.webkit.org/show_bug.cgi?id=109891
It caused an assertion failure in scrollbars/overflow-
scrollbar-combinations.html (Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::borderWidthChanged):
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/block/dynamic-padding-border-expected.txt: Removed.
- fast/block/dynamic-padding-border.html: Removed.
- fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- 10:21 PM Changeset in webkit [142961] by
-
- 3 edits in trunk/LayoutTests
Add assertion failure expectations on Mac per bugs 109869 and 109890.
- platform/mac/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 10:06 PM JavaScriptCore edited by
- (diff)
- 9:59 PM Changeset in webkit [142960] by
-
- 4 edits2 adds in trunk
Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.
https://bugs.webkit.org/show_bug.cgi?id=106452
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-14
Reviewed by Ryosuke Niwa.
Source/WebCore:
Pressing the down or the right arrow key at the end of a text line in
vertical writing mode would make the caret dissapear. This occurs only
when the text line is followed by an empty block.
When trying to compute the next position for placing the caret (for
down/right key), we try to ascertain whether the renderer (in this
case the empty block) is a valid candidate or not. For blockFlow
elements we check against their height.
In vertical writing mode though we would fail such a check since we
should instead be comparing against the renderer's width and not
it's height. Thus, a valid position for the placement of the caret
was not found in such a case.
Test: editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html
- dom/Position.cpp:
(WebCore::Position::isCandidate):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
Instead of checking against the height(), check against the
logicalHeight() of the renderer has been added. logicalHeight()
on blockFlow renderer's returns a value in accordance with
the writing mode.
LayoutTests:
- editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt: Added.
- editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html: Added.
Layout test case added for verifying that pressing the down or the right arrow
key at the end of the text line in vertical writing mode will not make the caret
dissapear.
Caret positions at the start, the end, and after pressing the right and the down
arrow keys at the end of the text line, are compared for verification.
- 9:55 PM Changeset in webkit [142959] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix after r142957.
- dom/DOMAllInOne.cpp:
- 9:54 PM JavaScriptCore edited by
- (diff)
- 9:53 PM JavaScriptCore edited by
- (diff)
- 9:47 PM Changeset in webkit [142958] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo introduced in r142705.
Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.
e.g. "run-webkit-tests platform/mac/editing/deleting/deletionUI-single-instance.html
platform/mac/editing/input/text-input-controller.html --child-processes=1"
- editing/Editor.cpp:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController):
- 9:47 PM JavaScriptCore edited by
- (diff)
- 8:38 PM Changeset in webkit [142957] by
-
- 11 edits2 adds in trunk/Source/WebCore
Factor Event retargeting code.
https://bugs.webkit.org/show_bug.cgi?id=109156
Reviewed by Dimitri Glazkov.
To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent,
but also other events.
New class, EventRetargeter, was introduced. From now,
EventDispatchMediator (and its subclasses) should call, if event
retargeting is required, an appropriate function provided in
EventRetargeter rather than calling
EventDispatcher::adjustRelatedTarget(), which was removed in this
patch.
No tests. No change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventDispatchMediator.cpp:
- dom/EventDispatcher.cpp:
(WebCore):
(WebCore::EventDispatcher::ensureEventPath): Changed to return an EventPath, which will be used by EventRetargeter.
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
(WebCore):
(EventDispatcher):
- dom/EventRetargeter.cpp: Added.
(WebCore):
(WebCore::inTheSameScope):
(WebCore::determineDispatchBehavior):
(WebCore::EventRetargeter::calculateEventPath): Factored out from EventDispatcher::ensureEventPath().
(WebCore::EventRetargeter::adjustForMouseEvent):
(WebCore::EventRetargeter::adjustForFocusEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::buildRelatedNodeMap): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::findRelatedNode):
- dom/EventRetargeter.h: Added.
(WebCore):
(EventRetargeter):
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForFocusEvent().
(WebCore::BlurEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusInEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusOutEventDispatchMediator::dispatchEvent): Ditto.
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForMouseEvent().
- 8:28 PM Changeset in webkit [142956] by
-
- 6 edits4 deletes in trunk
Reverting r142861. Hit testing inside of style recalc is fundamentally wrong
Source/WebCore:
- page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
- page/EventHandler.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::areNonIdenticalCursorListsEqual):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::styleDidChange):
LayoutTests:
- fast/events/mouse-cursor-change-expected.txt: Removed.
- fast/events/mouse-cursor-change.html: Removed.
- fast/events/mouse-cursor-no-mousemove-expected.txt: Removed.
- fast/events/mouse-cursor-no-mousemove.html: Removed.
- platform/mac/TestExpectations:
- 7:58 PM Changeset in webkit [142955] by
-
- 11 edits3 adds in trunk
[SVG] Cached filter results are not invalidated on repaint rect change
https://bugs.webkit.org/show_bug.cgi?id=106221
Reviewed by Dean Jackson.
Source/WebCore:
Since the cached filter results are not invalidated for different repaint rects, we need
to render the content of the whole filter region upfront (otherwise elements not visible
during the initial paint due to scrolling/window size/etc. are never redrawn).
Tests: svg/filters/filter-hidden-content-expected.svg
svg/filters/filter-hidden-content.svg
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::drawingRegion):
(WebCore):
- rendering/svg/RenderSVGResourceFilter.h:
(FilterData):
(RenderSVGResourceFilter):
Track the filter drawing region in FilterData.
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGRenderingContext.h:
Update paintInfo.rect to cover the whole drawing region while rendering filter content, and
restore it when done.
LayoutTests:
- svg/filters/filter-hidden-content-expected.svg: Added.
- svg/filters/filter-hidden-content.svg: Added.
- 7:57 PM Changeset in webkit [142954] by
-
- 19 edits in trunk
Unreviewed. Some final touch-ups to the VS2010 WebKit solution before nuking the VS2005 solution.
Remove un-needed include directories and force includes.
Update exports file.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- WebKit.vcxproj/common.props:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
- win/record-memory/record-memoryCommon.props:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- JavaScriptCore.vcxproj/jsc/jscCommon.props:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
- WTF.vcxproj/WTFCommon.props:
- 7:07 PM Changeset in webkit [142953] by
-
- 2 edits1 copy in trunk/LayoutTests
Unreviewed rebaselining following r142940.
- fast/events/onerror-no-constructor-expected.txt:
- platform/chromium/fast/events/onerror-no-constructor-expected.txt: Copied from LayoutTests/fast/events/onerror-no-constructor-expected.txt.
- 6:38 PM Changeset in webkit [142952] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Correct the mismatched cursor map
https://bugs.webkit.org/show_bug.cgi?id=109655
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-14
Reviewed by Laszlo Gombos.
Correct the mismatched ECORE_X_CURSOR values in the cursor map.
- platform/efl/EflScreenUtilities.cpp:
(WebCore::CursorMap::CursorMap):
- 6:07 PM Changeset in webkit [142951] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::anyAttribute):
(WebDOMTestObj::setAnyAttribute):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_any_attribute):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcWithClampCallback):
- 6:02 PM Changeset in webkit [142950] by
-
- 1 edit in trunk/Tools/ChangeLog
adding myself as a committer
- 6:00 PM Changeset in webkit [142949] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py
adding myself as a committer
- 5:42 PM Changeset in webkit [142948] by
-
- 1 edit in trunk/Source/WebCore/Modules/webdatabase/SQLTransactionStateMachine.cpp
Commented out code meant to be deleted.
- 5:39 PM Changeset in webkit [142947] by
-
- 158 edits in trunk
Convert media controls from DeprecatedFlexibleBox to FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109775
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-14
Reviewed by Ojan Vafai.
Source/WebCore:
Covered by existing tests in media/.
- css/mediaControls.css:
- css/mediaControlsBlackBerry.css:
- css/mediaControlsChromium.css:
- css/mediaControlsChromiumAndroid.css:
- css/mediaControlsEfl.css:
- css/mediaControlsGtk.css:
- css/mediaControlsQt.css:
- css/mediaControlsQuickTime.css:
Automated search and replace of old flexbox CSS rules to new ones.
Minor tuning of the chromium rules.
- rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderMediaControlTimeDisplay::layout):
- rendering/RenderMediaControlElements.h:
Make media controls inherit from RenderFlexibleBox
LayoutTests:
Rebaselined lots of tests. There were two kinds of changes:
- Replaced the RenderDeprecatedFlexibleBox class name with
RenderFlexibleBox, and minor printing differences
- Slight positioning/size changes due to a different algorithm for
shrinking elements (old flexbox shrinks elements evenly, new flexbox
shrinks in proportion to the size of the flex item)
- 5:28 PM Changeset in webkit [142946] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Windows.
- Modules/webdatabase/SQLTransactionStateMachine.cpp:
(WebCore::nameForSQLTransactionState):
- 5:23 PM Changeset in webkit [142945] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
Mac rebaseline after r142931.
- platform/chromium-mac/fast/replaced/width100percent-image-expected.txt: Added.
- platform/chromium/fast/replaced/width100percent-image-expected.txt: Removed.
- platform/mac/fast/replaced/width100percent-image-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 5:19 PM Changeset in webkit [142944] by
-
- 2 edits in trunk/Source/WebCore
Inspector doesn't show rules from pluginsStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=109872
Reviewed by Darin Adler.
Make sure getWrapperForRuleInSheets collects the rules
from CSSDefaultStyleSheets::plugInsStyleSheet.
Making a test for this is difficult because the rules in
this sheet only apply to snapshotted plugins at the moment,
which are disabled in DRT, and would require a fairly long
timeout in the test.
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
- 5:19 PM Changeset in webkit [142943] by
-
- 1 edit2 adds in trunk/LayoutTests
Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648
Unreviewed. Adding the files I forgot to commit in r142774.
- media/video-controls-captions-trackmenu-hide-on-click.html: Added.
- platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
- 5:01 PM Changeset in webkit [142942] by
-
- 2 edits in trunk/Source/WebCore
Recover edge names used in MemoryInstrumentation for DocumentRuleSets.
https://bugs.webkit.org/show_bug.cgi?id=109800
Reviewed by Hajime Morita.
This is a following patch for r142573.
r142563 accidentally removes edge names for MemoryInstrumentation. We should recover edge names.
No tests. No change in behavior.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::reportMemoryUsage):
- 4:56 PM Changeset in webkit [142941] by
-
- 18 edits1 add in trunk
new-run-webkit-tests needs a shared TestExpectations between all WebKit ports
https://bugs.webkit.org/show_bug.cgi?id=37565
Introduce generic TestExpectations file that applies as a fallback for all ports, the location of which
is LayoutTests/TestExpectations.
Patch by Glenn Adams <glenn@skynav.com> on 2013-02-14
Reviewed by Dirk Pranke.
Tools:
- Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
(FakePort.path_to_generic_test_expectations_file):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.path_to_generic_test_expectations_file):
(Port):
(Port._port_specific_expectations_files):
(Port.expectations_files):
- Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_expectations_files):
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_expectations_files):
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_expectations_ordering):
(test_expectations_files):
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_expectations_files):
- Scripts/webkitpy/layout_tests/port/win_unittest.py:
(WinPortTest.test_expectations_files):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_paths):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
LayoutTests:
- TestExpectations: Added.
- 4:42 PM Changeset in webkit [142940] by
-
- 3 edits2 adds in trunk
[V8] Assertion failure on an exception is thrown
https://bugs.webkit.org/show_bug.cgi?id=109129
Source/WebCore:
An assertion in V8AbstractEventListener is wrong. This change turns it into an error check.
Reviewed by Kentaro Hara.
Test: fast/events/onerror-no-constructor.html
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
LayoutTests:
Reviewed by Kentaro Hara.
- fast/events/onerror-no-constructor-expected.txt: Added.
- fast/events/onerror-no-constructor.html: Added.
- 4:38 PM Changeset in webkit [142939] by
-
- 2 edits in trunk/Source/WebCore
[V8] CodeGeneratorV8.pm can assume that DOMWindow has [CheckSecurity]
https://bugs.webkit.org/show_bug.cgi?id=109788
Reviewed by Adam Barth.
There is code like this:
if ($extendedAttr{"CheckSecurity"} $interfaceName eq "DOMWindow") This check is redundant. DOMWindow has [CheckSecurity]. We can remove the
DOMWindow check.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateReplaceableAttrSetter):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
- 4:36 PM Changeset in webkit [142938] by
-
- 2 edits in trunk/Source/WebCore
[V8] IndexedDB: Remove unused creationContext paramter from idbKeyToV8Value
https://bugs.webkit.org/show_bug.cgi?id=109870
Reviewed by Kentaro Hara.
This parameter was left over from when the function was toV8(IDBKey). Remove it.
No new tests - just removing dead code.
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::idbKeyToV8Value): Remove unused parameter.
(WebCore::injectIDBKeyIntoScriptValue): No need for dummy handle.
(WebCore::idbKeyToScriptValue): No need for dummy handle.
- 4:35 PM Changeset in webkit [142937] by
-
- 3 edits in trunk/Source/WebCore
[WebGL][Qt] regression:r142786 Qt Build fix for Arm and Windows.
https://bugs.webkit.org/show_bug.cgi?id=109797
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-14
Reviewed by Csaba Osztrogonác.
After r142786, we use OpenGLShims to load necessary GL functions
exposed by ARB_vertex_array_object extension. Qt uses OpenGLShims
to load functions with GLES too. This patch adds support for loading the
equivalent functions on GLES exposed by OES_vertex_array_object.
- platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
- platform/graphics/OpenGLShims.h:
- 4:27 PM Changeset in webkit [142936] by
-
- 8 edits in trunk/Source/WebCore
<rdar://problem/13210723> CORS preflight broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=109753
Reviewed by Brady Eidson.
- loader/DocumentThreadableLoader.h:
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::cancel): (WebCore::DocumentThreadableLoader::didReceiveResponse): (WebCore::DocumentThreadableLoader::dataReceived): (WebCore::DocumentThreadableLoader::didReceiveData): (WebCore::DocumentThreadableLoader::notifyFinished): (WebCore::DocumentThreadableLoader::didFinishLoading): (WebCore::DocumentThreadableLoader::didFail): (WebCore::DocumentThreadableLoader::preflightFailure): Notify InspectorInstrumentation immediately. In addition to keeping up eith other changes, this means that an accurate error will be passed now, not a cancellation. (WebCore::DocumentThreadableLoader::loadRequest): Get rid of m_preflightRequestIdentifier. Every loader has an identifier, and tracking identifiers twice is wrong. Pass identifier explicitly to more internal functions, so that they would not have to second-guess callers.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): Create an identifier for all loaders, not just those that we expect to have client callbacks about. Both Inspector and NetworkProcess need identifiers everywhere.
- loader/TextTrackLoader.cpp: (WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource):
- loader/TextTrackLoader.h:
- loader/cache/CachedResourceClient.h: (WebCore::CachedResourceClient::deprecatedDidReceiveCachedResource):
- loader/cache/CachedTextTrack.cpp: (WebCore::CachedTextTrack::data): Renamed didReceiveData to avoid conflict with the new DocumentThreadableLoader::didReceiveData. And we should really get rid of this CachedResourceClient function anyway.
- 4:25 PM Changeset in webkit [142935] by
-
- 18 edits in trunk/Source/WebCore
Replace 'DOMObject' with 'any'
https://bugs.webkit.org/show_bug.cgi?id=109793
Reviewed by Dimitri Glazkov.
In the Web IDL spec, there is no type named 'DOMObject'.
It should be 'any'. We should replace all 'DOMObject's in WebKit IDLs with 'any's.
- Modules/webdatabase/SQLResultSetRowList.idl:
- bindings/scripts/CodeGeneratorCPP.pm:
(GetClassName):
(AddIncludesForType):
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
- bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForType):
(GenerateImplementation):
(JSValueToNative):
(NativeToJSValue):
- bindings/scripts/CodeGeneratorV8.pm:
(GetNativeType):
(JSValueToNative):
(GetV8HeaderName):
- dom/CustomEvent.idl:
- dom/MessageEvent.idl:
- dom/PopStateEvent.idl:
- fileapi/FileReader.idl:
- html/HTMLCanvasElement.idl:
- html/HTMLElement.idl:
- html/canvas/DataView.idl:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorFrontendHost.idl:
- inspector/JavaScriptCallFrame.idl:
- page/DOMWindow.idl:
- page/Location.idl:
- 4:17 PM Changeset in webkit [142934] by
-
- 2 edits in trunk/Source/WebCore
[V8] Remove GenerateEventListenerCallback() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=109786
Reviewed by Adam Barth.
Some code is duplicated between GenerateEventListenerCallback()
and GenerateFunctionCallback(). By inlining GenerateEventListenerCallback()
into GenerateFunctionCallback(), we can remove the duplication.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
- 4:16 PM Changeset in webkit [142933] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/13161700> REGRESSION: Safari is unable to make SSL connections
when running from recovery partition
Reviewed by Sam Weinig.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in: Re-added /private/var/db/mds/system rules lost in r141445.
- 4:08 PM Changeset in webkit [142932] by
-
- 41 edits1 delete in trunk/LayoutTests
Rebaseline 9 SVG tests after r142765
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
- platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-linux/svg/as-background-image/svg-background-partial-redraw-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/animated-svg-as-background-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-1-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-background-partial-redraw-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-background-partial-redraw-expected.png:
- platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png:
- platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-mac/svg/as-background-image/svg-background-partial-redraw-expected.png:
- platform/chromium-win-xp/svg/as-background-image: Removed.
- platform/chromium-win-xp/svg/as-background-image/svg-as-background-1-expected.png: Removed.
- platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png: Removed.
- platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
- platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
- platform/chromium/TestExpectations:
- 3:58 PM Changeset in webkit [142931] by
-
- 10 edits2 adds in trunk
Intrinsic and preferred widths on replaced elements are wrong in many cases
https://bugs.webkit.org/show_bug.cgi?id=109859
Reviewed by Levi Weintraub.
Source/WebCore:
Test: fast/replaced/preferred-widths.html
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
Separate out computing the intrinsic widths. Eventually,
we should be able to share computePreferredLogicalWidth implementations
for all replaced elements and form controls since only the intrinsic width
changes.
(WebCore::RenderReplaced::computePreferredLogicalWidths):
-Apply min-width and max-width constraints and then add borderAndPaddingLogicalWidth
at the end to make sure it's always applied. This matches all our other
computePreferredLogicalWidths override and makes use match Gecko's/Opera's rendering.
-Only set the minPreferredLogicalWidth to 0 if the width or max-width is a percent value.
Doing it for height values and for min-width doesn't make any sense and doesn't
match other browsers. Doing this for max-width still doesn't match other browsers,
but it sounds like Gecko at least would like to change that.
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::hasRelativeIntrinsicLogicalWidth):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::hasRelativeIntrinsicLogicalWidth):
Add a way to check if the logicalWidth is relative so that we only check
the width in computePreferredLogicalWidths instead of also checking the height.
- rendering/svg/RenderSVGRoot.h:
LayoutTests:
- fast/replaced/preferred-widths-expected.txt: Added.
- fast/replaced/preferred-widths.html: Added.
These results match Gecko and Opera except for the 3rd container div.
Talking to dbaron and bz and Mozilla they sound likely to match our behavior there.
See https://bugzilla.mozilla.org/show_bug.cgi?id=823483 for example.
The width of the containers is wrong in some of these cases because our
computePreferredLogicalWidths methods don't currently account for
intrinsic sizes (e.g. min-content, max-content, etc).
- platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- platform/chromium-win/fast/replaced/width100percent-image-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
These new results are more correct. The width100percent-image case now
matches other browsers and is due to not setting the minPreferrredLogicalWidth to
0 if the height is a percentage. The bugs85016 case is different because we
now correctly add the border and padding width to the preferred width of the image.
- 3:51 PM Changeset in webkit [142930] by
-
- 2 edits in trunk/LayoutTests
Add a crash test expectation to media/media-captions.html on Mac per bug 109869.
- platform/mac/TestExpectations:
- 3:49 PM Changeset in webkit [142929] by
-
- 15 edits in trunk/Tools
[chromium] move pixel generation logic to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109686
Reviewed by Stephen White.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::proxy):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::setWebView):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::display):
(WebTestRunner::TestRunner::displayInvalidatedRegion):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::setWebView):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner::WebTestProxyBase::capturePixels):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::paintRect):
(WebTestRunner::WebTestProxyBase::paintInvalidatedRegion):
(WebTestRunner::WebTestProxyBase::paintPagesWithBoundaries):
(WebTestRunner::WebTestProxyBase::canvas):
(WebTestRunner::WebTestProxyBase::displayRepaintMask):
(WebTestRunner::WebTestProxyBase::display):
(WebTestRunner::WebTestProxyBase::displayInvalidatedRegion):
(WebTestRunner::WebTestProxyBase::discardBackingStore):
(WebTestRunner::WebTestProxyBase::setWindowRect):
(WebTestRunner::WebTestProxyBase::userMediaClient):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::showDevTools):
(TestShell::closeDevTools):
(TestShell::dump):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 3:45 PM Changeset in webkit [142928] by
-
- 4 edits2 adds in trunk
Crash when selecting a HarfBuzz text run with SVG fonts included
https://bugs.webkit.org/show_bug.cgi?id=109833
Reviewed by Tony Chang.
Source/WebCore:
There is an assert in SimpleFontData::applyTransforms that should not
be there, as the code is valid for SVG fonts. If we get past this,
then the HarfBuzz text run shaping code assumes that font data has a
SkTypeface member, and SVG fonts do not. So we crash there too.
For now, we fix the crashes. This still leaves incorrect selection
rectangles in this situation, on all platforms, tracked in
https://bugs.webkit.org/show_bug.cgi?id=108133
Test: svg/css/font-face-crash.html
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.
LayoutTests:
Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.
- svg/css/font-face-crash-expected.txt: Added.
- svg/css/font-face-crash.html: Added.
- 3:42 PM Changeset in webkit [142927] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] No triggering autofill on unfocus
https://bugs.webkit.org/show_bug.cgi?id=109735
Patch by David Trainor <dtrainor@chromium.org> on 2013-02-14
Reviewed by James Robinson.
Need to notify the autofill client to not process text changes when we're setting
focus to false and are trying to commit a composition.
- public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::setIgnoreTextChanges):
(WebKit::WebAutofillClient::~WebAutofillClient):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
- tests/WebViewTest.cpp:
- 3:14 PM Changeset in webkit [142926] by
-
- 5 edits in trunk/Source/WebCore
[BlackBerry] Notify platform layer of failing to get authentication credentials
https://bugs.webkit.org/show_bug.cgi?id=109751
Patch by Joe Mason <jmason@rim.com> on 2013-02-13
Reviewed by Yong Li.
Reviewed internally by Leo Yang
Internal PR: 181302
The BlackBerry platform network layer needs to know if a stream failed to get authentication credentials.
This patch is using newly added stream API to do it.
No functionality changed no new tests.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
- platform/network/blackberry/NetworkJob.h:
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::protectionSpaceToPlatformAuth):
(WebCore):
(WebCore::setAuthCredentials):
- platform/network/blackberry/NetworkManager.h:
(WebCore):
- 2:54 PM Changeset in webkit [142925] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix indentation in GNUmakefile.list.am.
https://bugs.webkit.org/show_bug.cgi?id=109854
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-14
Reviewed by Martin Robinson.
This patch fixes indentation in GNUmakefile.list.am.
- GNUmakefile.list.am:
- 2:50 PM Changeset in webkit [142924] by
-
- 2 edits in trunk/Source/WTF
No easy way to use a RetainPtr as a key in a HashMap using object (rather than pointer) equality
https://bugs.webkit.org/show_bug.cgi?id=109864
Reviewed by Sam Weinig and Benjamin Poulain.
Added RetainPtrObjectHashTraits and RetainPtrObjectHash, which use CFEqual
and CFHash.
- wtf/RetainPtr.h:
(RetainPtrObjectHashTraits):
(WTF::RetainPtrObjectHashTraits::emptyValue):
(WTF::RetainPtrObjectHashTraits::constructDeletedValue):
(WTF::RetainPtrObjectHashTraits::isDeletedValue):
(WTF):
(WTF::RetainPtrObjectHash::hash):
(WTF::RetainPtrObjectHash::equal):
(RetainPtrObjectHash):
- 2:46 PM Changeset in webkit [142923] by
-
- 81 edits in trunk
Unreviewed, set svn:eol-style native for .sln, .vsprops, and .vcproj files.
https://bugs.webkit.org/show_bug.cgi?id=96934
- 2:34 PM Changeset in webkit [142922] by
-
- 3 edits2 adds in trunk
Bad cast in RenderBlock::splitBlocks.
https://bugs.webkit.org/show_bug.cgi?id=108691
Reviewed by Levi Weintraub.
Source/WebCore:
Test: fast/multicol/remove-child-split-flow-crash.html
- rendering/RenderBlock.cpp:
(WebCore):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): rename gIsInColumnFlowSplit to gColumnFlowSplitEnabled
and use it to decide when to do the column flow split or not.
(WebCore::RenderBlock::removeChild): Do not allow column flow split inside removeChild
since we might be merging anonymous blocks.
LayoutTests:
- fast/multicol/remove-child-split-flow-crash-expected.txt: Added.
- fast/multicol/remove-child-split-flow-crash.html: Added.
- 2:31 PM Changeset in webkit [142921] by
-
- 32 edits4 adds in trunk/Source/WebCore
Split SQLTransaction work between the frontend and backend.
https://bugs.webkit.org/show_bug.cgi?id=104750.
Reviewed by Sam Weinig.
This is part of the webdatabase refactoring for webkit2.
- Changed how transactions are created.
- Database::runTransaction() first creates a SQLTransaction frontend which encapsulates the 3 script callbacks. It then passes the SQLTransaction to the backend database to create the SQLTransactionBackend.
- The SQLTransactionBackend manages all SQLiteTransaction work.
- Introduced SQLTransactionState and SQLTransactionStateMachine.
- Instead of tracking the transaction phases as "steps" in m_nextStep, we now use m_nextState which is of enum class SQLTransactionState. Unlike m_nextStep which is a pointer to a "step" function, m_nextState is a state variable which is used to index into a state dispatch table.
- Both SQLTransaction and SQLTransactionBackend now extends SQLTransactionStateMachine, and uses its dispatch mechanism based on the SQLTransactionState.
- Instead of having 1 state machine instances, there are 2: 1 in the frontend, and 1 in the backend. The 2 have mirrored states, and transfers work to the other state machine when needed.
- Previously, state functions can be called inline from other states. They are now only called from the state machines runStateMachine() method. This makes it possible to isolate the state transition mechanism going between the sides (frontend and backend) to 2 functions only: SQLTransaction::sendToBackendState() and SQLTransactionBackend::sendToFrontendState().
- Consolidated cleanup work (mostly) to a unified cleanup function.
- Changed the frontend Database::runTransaction() to use a ChangeVersionData* (instead of a ChangeVersionWrapper ref ptr).
- This is necessary because ChangeVersionWrapper contains functionality used in processing a transaction (to be invoked in the backend). Instead, what we want is to simply pass the 2 old and new version strings to the backend. The new ChangeVersionData simply packages up these 2 strings.
- This makes ChangeVersionData easy to serialize for IPC messaging later.
- Moved some transaction functions back to the frontend SQLTransaction because they belong there.
- Moved some Database functions to its DatabaseBackendAsync backend now that the transaction has been split up.
- This is driven naturally by those functions being used exclusively in the backend for transaction work.
- SQLTransactionClient, SQLTransactionCoordinator, and SQLTransactionWrapper are now exclusively backend data structures. SQLTransactionClient still has some frontend "pollution" that I'll fix later.
- Made the few database report functions used only by Chromium conditional on PLATFORM(chromium).
- The report functions gets re-routed to Chromium's DatabaseObserver which further routes them elsewhere. It is unclear how Chromium uses these routed messages, and I am therefore not able to determine how they should work in a frontend/backend world. So, I'm #ifdef'ing them out. They still work like in the old way for Chromium.
- Added new files to the build / project files.
- Updated / added comments about how the transaction and its states work.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/ChangeVersionData.h: Added.
(ChangeVersionData):
(WebCore::ChangeVersionData::ChangeVersionData):
(WebCore::ChangeVersionData::oldVersion):
(WebCore::ChangeVersionData::newVersion):
- Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
(WebCore::ChangeVersionWrapper::handleCommitFailedAfterPostflight):
- Modules/webdatabase/ChangeVersionWrapper.h:
(ChangeVersionWrapper):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::close):
(WebCore::Database::changeVersion):
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
(WebCore::Database::reportStartTransactionResult):
(WebCore::Database::reportCommitTransactionResult):
(WebCore::Database::reportExecuteStatementResult):
- Modules/webdatabase/Database.h:
(WebCore::Database::databaseContext):
(Database):
(WebCore::Database::reportStartTransactionResult):
(WebCore::Database::reportCommitTransactionResult):
(WebCore::Database::reportExecuteStatementResult):
- Modules/webdatabase/DatabaseBackend.cpp:
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
(WebCore::DatabaseBackend::reportOpenDatabaseResult):
(WebCore::DatabaseBackend::reportChangeVersionResult):
(WebCore::DatabaseBackend::reportStartTransactionResult):
(WebCore::DatabaseBackend::reportCommitTransactionResult):
(WebCore::DatabaseBackend::reportExecuteStatementResult):
(WebCore::DatabaseBackend::reportVacuumDatabaseResult):
- Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
(WebCore::DatabaseBackendAsync::runTransaction):
(WebCore::DatabaseBackendAsync::inProgressTransactionCompleted): Moved from frontend.
(WebCore::DatabaseBackendAsync::scheduleTransaction): Moved from frontend.
(WebCore::DatabaseBackendAsync::scheduleTransactionStep): Moved from frontend.
(WebCore::DatabaseBackendAsync::transactionClient): Moved from frontend.
(WebCore::DatabaseBackendAsync::transactionCoordinator): Moved from frontend.
- Modules/webdatabase/DatabaseBackendAsync.h:
(DatabaseBackendAsync):
- Modules/webdatabase/DatabaseBackendContext.cpp:
(WebCore::DatabaseBackendContext::frontend):
- Modules/webdatabase/DatabaseBackendContext.h:
(DatabaseBackendContext):
- Modules/webdatabase/DatabaseManager.cpp:
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::setBackend):
(WebCore::SQLTransaction::stateFunctionFor):
(WebCore::SQLTransaction::requestTransitToState):
(WebCore::SQLTransaction::nextStateForTransactionError):
- was handleTransactionError(). There's also a backend version.
(WebCore::SQLTransaction::deliverTransactionCallback): Moved from backend.
(WebCore::SQLTransaction::deliverTransactionErrorCallback): Moved from backend.
(WebCore::SQLTransaction::deliverStatementCallback): Moved from backend.
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Moved from backend.
(WebCore::SQLTransaction::deliverSuccessCallback): Moved from backend.
(WebCore::SQLTransaction::unreachableState):
(WebCore::SQLTransaction::sendToBackendState):
(WebCore::SQLTransaction::performPendingCallback): Moved from backend.
(WebCore::SQLTransaction::executeSQL): Moved from backend.
(WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransaction::clearCallbackWrappers):
- Modules/webdatabase/SQLTransaction.h:
(SQLTransaction):
(WebCore::SQLTransaction::database):
(WebCore::SQLTransaction::hasCallback):
(WebCore::SQLTransaction::hasSuccessCallback):
(WebCore::SQLTransaction::hasErrorCallback):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::transactionError):
(WebCore::SQLTransactionBackend::setShouldRetryCurrentStatement):
(WebCore::SQLTransactionBackend::stateFunctionFor):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
- was runCurrentStatement().
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
- was handleCurrentStatementError().
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAndTerminate):
(WebCore::SQLTransactionBackend::nextStateForTransactionError):
- was handleTransactionError(). There's also a frontend version.
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::requestTransitToState):
(WebCore::SQLTransactionBackend::unreachableState):
(WebCore::SQLTransactionBackend::sendToFrontendState):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionWrapper):
(SQLTransactionBackend):
(WebCore::SQLTransactionBackend::database):
- Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
- Modules/webdatabase/SQLTransactionState.h: Added.
- Modules/webdatabase/SQLTransactionStateMachine.cpp: Added.
(WebCore::nameForSQLTransactionState):
- was debugStepName().
- Modules/webdatabase/SQLTransactionStateMachine.h: Added.
(SQLTransactionStateMachine):
(WebCore::SQLTransactionStateMachine::~SQLTransactionStateMachine):
(WebCore::::SQLTransactionStateMachine):
(WebCore::::setStateToRequestedState):
(WebCore::::runStateMachine):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorDatabaseAgent.cpp:
- 2:30 PM Changeset in webkit [142920] by
-
- 1 edit2 copies in branches/chromium/1410
Merge 142788. Requested by Christian Biesinger <cbiesinger@chromium.org>.
Crash when encountering <object style="resize:both;">
https://bugs.webkit.org/show_bug.cgi?id=109728
Source/WebCore:
See also https://code.google.com/p/chromium/issues/detail?id=175535
This bug can be reproduced on
http://dramalink.net/tudou.y/?xink=162601060
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.
Test: fast/css/resize-object-crash.html
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
Only call paintResizer() if we have a layer and canResize() is true
LayoutTests:
See also https://code.google.com/p/chromium/issues/detail?id=175535
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.
- fast/css/resize-object-crash-expected.txt: Added.
- fast/css/resize-object-crash.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12252048
- 2:27 PM Changeset in webkit [142919] by
-
- 7 edits1 move in trunk
Add WKContextIsPlugInUpdateAvailable
https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>
Reviewed by Sam Weinig.
Source/WebKit2:
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp.
(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
(WKContextIsPlugInUpdateAvailable):
- WebKit2.xcodeproj/project.pbxproj:
WebKitLibraries:
Roll WebKitSystemInterface DEPS.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 2:26 PM Changeset in webkit [142918] by
-
- 10 edits in trunk
EME: replace MediaKeySession.addKey() -> update()
https://bugs.webkit.org/show_bug.cgi?id=109461
Source/WebCore:
Reviewed by Eric Carlson.
No new tests; updated media/encrypted-media/encrypted-media-v2-syntax.html test.
In the latest draft of the Encrypted Media Spec, the addKeys() method has been replaced
with update().
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::addKeyTimerFired):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeySession.idl:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitAddKey):
- testing/MockCDM.cpp:
(WebCore::MockCDMSession::update):
LayoutTests:
Rebaseline after API change.
Reviewed by Eric Carlson.
- media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
- media/encrypted-media/encrypted-media-v2-syntax.html:
- 2:04 PM Changeset in webkit [142917] by
-
- 51 edits5 moves in trunk
Move all .props files from WebKitLibraries folder to WebKit Source folder.
https://bugs.webkit.org/show_bug.cgi?id=109761
Reviewed by Brent Fulgham.
- win/tools/vsprops/FeatureDefines.props: Removed.
- win/tools/vsprops/common.props: Removed.
- win/tools/vsprops/debug.props: Removed.
- win/tools/vsprops/release.props: Removed.
- win/tools/vsprops/releaseproduction.props: Removed.
- 2:01 PM Changeset in webkit [142916] by
-
- 7 edits3 copies in tags/Safari-537.31.1/Source/WebKit2
Merged r142900. <rdar://problem/13205468>
- 2:00 PM Changeset in webkit [142915] by
-
- 14 edits in trunk
Unreviewed, set svn:eol-style CRLF for .sln files.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property
- svn:eol-style.
Source/ThirdParty:
- gtest/msvc/gtest-md.sln: Added property svn:eol-style.
- gtest/msvc/gtest.sln: Added property svn:eol-style.
Source/WebCore:
- WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
- WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.
Source/WebKit/win:
- WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
- WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
Source/WTF:
- WTF.vcproj/WTF.sln: Added property svn:eol-style.
Tools:
- CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
- DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
- MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
- WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
- 1:58 PM Changeset in webkit [142914] by
-
- 7 edits in trunk
Unreviewed, set svn:eol-style CRLF for .sln files.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
Source/ThirdParty:
- gtest/msvc/gtest-md.sln: Added property svn:eol-style.
- gtest/msvc/gtest.sln: Added property svn:eol-style.
Source/WebCore:
- WebCore.vcproj/WebCore.sln: Modified property svn:eol-style.
- WebCore.vcproj/WebCore.submit.sln: Modified property svn:eol-style.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln: Modified property svn:eol-style.
Source/WebKit/win:
- WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
- WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
Source/WTF:
- WTF.vcproj/WTF.sln: Added property svn:eol-style.
Tools:
- CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
- DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
- MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
- WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
- 1:56 PM Changeset in webkit [142913] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Fix scaling in WebViewImpl::handleGestureEvent, second try
https://bugs.webkit.org/show_bug.cgi?id=109671
Reviewed by James Robinson.
My patch 142571 broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.
142808 was an earlier version of this patch that was reverted
due to fling events asserting they can't be converted to
PlatformGestureEvent. This version moves fling earlier in the
function to avoid that.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/LinkHighlightTest.cpp:
(WebCore::TEST):
- 1:54 PM Changeset in webkit [142912] by
-
- 1 delete in tags/Safari-537.31.1/Safari-537.31
- 1:54 PM Changeset in webkit [142911] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r142901.
http://trac.webkit.org/changeset/142901
r182258 introduces a dependency on chrome.gyp that breaks the win
build. Rolling back to r182150 until I can work up a workaround.
- DEPS:
- 1:51 PM Changeset in webkit [142910] by
-
- 2 edits in trunk/Source/WebCore
[Mac] adjust caption color user preference calculation
https://bugs.webkit.org/show_bug.cgi?id=109840
Reviewed by Dean Jackson.
No new tests, it isn't possible to test this with DRT.
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): The color is "important" if either the
color or opacity are supposed to override.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsTextColor): Ditto.
- 1:49 PM Changeset in webkit [142909] by
-
- 7 edits in trunk/Source/WebCore
Numeric identifiers of events are not guaranteed to be unique
https://bugs.webkit.org/show_bug.cgi?id=103259
Patch by Cosmin Truta <ctruta@rim.com> on 2013-02-14
Reviewed by Alexey Proskuryakov.
The results of setTimeout, setInterval and navigator.geolocation.watchPosition
are positive integer values extracted from a simple circular sequential number
generator, whose uniqueness can be guaranteed for no more than 231 calls to
any of these functions. In order to provide this guarantee beyond this limit,
we repeatedly ask for the next sequential id until we get one that's not used
already.
This solution works instantly under normal circumstances, when there are few
live timeout ids or geolocation ids at any given moment. Handling millions of
live ids will require another solution.
No new tests. Brief tests of uniqueness already exist.
Moreover, reproducing this particular issue would require 231 set/clear
function calls, which is prohibitively expensive.
- Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::Watchers::add): Rename from Watchers::set; return false if watch id already exists.
(WebCore::Geolocation::watchPosition): Repeat until the new watch id is unique.
- Modules/geolocation/Geolocation.h:
(Watchers): Rename Watchers::set to Watchers::add.
- Modules/geolocation/Geolocation.idl: Rename the argument of Geolocation::clearWatch to WatchID.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::ScriptExecutionContext): Update initialization.
(WebCore::ScriptExecutionContext::circularSequentialID): Rename from newUniqueID; remove FIXME note.
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext): Rename ScriptExecutionContext::newUniqueID to ScriptExecutionContext::circularSequentialID.
(WebCore::ScriptExecutionContext::addTimeout): Return false (do not assert) if timeout id already exists.
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer): Repeat until the new timeout id is unique.
- 1:40 PM Changeset in webkit [142908] by
-
- 7 edits in trunk
[GTK] Errors when building WebKit2 with Clang
https://bugs.webkit.org/show_bug.cgi?id=109603
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- UIProcess/API/gtk/WebKitUIClient.cpp:
(setWindowFrame): Cast the position parameters to the integer type when constructing the GdkRectangle.
- UIProcess/Authentication/WebCredential.cpp: Add an empty implementation of the newly specified destructor.
- UIProcess/Authentication/WebCredential.h: Work around the incomplete WebCertificateInfo type errors thrown in the inline
RefPtr destructor of the m_certificateInfo class member by defining a destructor in the class.
- WebProcess/WebCoreSupport/WebEditorClient.h: The GTK-specific methods are not virtual and as such cannot be overriden.
The OVERRIDE keywords are thus unnecessary.
Tools:
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::resizeTo): Cast the width and height parameters to the integer
type when constructing the GtkAllocation.
- 1:34 PM Changeset in webkit [142907] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r142825.
http://trac.webkit.org/changeset/142825
https://bugs.webkit.org/show_bug.cgi?id=109856
Causes some inspector tests to time out (Requested by anttik
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
- platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 1:31 PM Changeset in webkit [142906] by
-
- 1 copy in tags/Safari-537.31.1/Safari-537.31
New Tag.
- 1:30 PM Changeset in webkit [142905] by
-
- 1 copy in tags/Safari-537.31.1
New Tag.
- 1:18 PM Changeset in webkit [142904] by
-
- 12 edits2 adds in trunk
Support the ch unit from css3-values
https://bugs.webkit.org/show_bug.cgi?id=85755
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-14
Reviewed by David Hyatt.
Original patch by Sumedha Widyadharma <sumedha.widyadharma@basyskom.com>.
Source/WebCore:
Test: fast/css/css3-ch-unit.html
- css/CSSCalculationValue.cpp:
(WebCore::unitCategory):
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isLength):
- platform/graphics/FontMetrics.h:
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::zeroWidth):
(WebCore::FontMetrics::setZeroWidth):
(FontMetrics):
(WebCore::FontMetrics::hasZeroWidth):
(WebCore::FontMetrics::setHasZeroWidth):
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit):
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::zeroGlyph):
(WebCore::SimpleFontData::setZeroGlyph):
(SimpleFontData):
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
- fast/css/css3-ch-unit-expected.txt: Added.
- fast/css/css3-ch-unit.html: Added.
- 1:16 PM Changeset in webkit [142903] by
-
- 10 edits in trunk/Source
[Mac] Clean up WARNING_CFLAGS
<http://webkit.org/b/109747>
<rdar://problem/13208373>
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.
Source/WebCore:
- Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.
Source/WebKit/mac:
- Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.
Source/WebKit2:
- Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.
Source/WTF:
- Configurations/Base.xcconfig: Use
GCC_WARN_64_TO_32_BIT_CONVERSION to enable and disable
-Wshorten-64-to-32 rather than WARNING_CFLAGS.
- 1:11 PM Changeset in webkit [142902] by
-
- 5 edits in trunk/Source/WebCore
Add addHTTPHeaderField() method to ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=109844
Reviewed by Adam Barth.
ResourceRequestBase provides both setHTTPHeaderField() and addHTTPHeaderField(). However,
ResourceResponseBase only provides setHTTPHeaderField(). This is a bit inconsistent. As a
result, the addHTTPHeaderField() functionality's implementation is duplicated in several
ports (at least chromium and soup).
This patch introduces addHTTPHeaderField() to ResourceResponseBase and makes use of it
in Chromium and Soup backends.
No new tests, no behavior change.
- platform/chromium/support/WebURLResponse.cpp:
(WebKit::WebURLResponse::addHTTPHeaderField): Use ResourceResponseBase::addHTTPHeaderField().
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::updateHeaderParsedState): Move headers' parsed state update code
from setHTTPHeaderField() to a new updateHeaderParsedState() method to avoid code duplication.
(WebCore):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::addHTTPHeaderField):
- platform/network/ResourceResponseBase.h:
(ResourceResponseBase):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Use ResourceResponseBase::addHTTPHeaderField().
- 1:08 PM Changeset in webkit [142901] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, chromium roll 182150 -> 182448
- DEPS:
- 12:53 PM Changeset in webkit [142900] by
-
- 7 edits3 adds in trunk/Source/WebKit2
Add conversions between ObjC and C DOM wrappers
<rdar://problem/13205468>
https://bugs.webkit.org/show_bug.cgi?id=109851
Reviewed by Anders Carlsson.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
(WKBundleRangeHandleCreate):
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h: Added.
- WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
(-[WKDOMNode _copyBundleNodeHandleRef]):
- WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h: Added.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
(-[WKDOMRange _copyBundleRangeHandleRef]):
- WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h: Added.
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
(InjectedBundleRangeHandle):
- 12:16 PM Changeset in webkit [142899] by
-
- 3 edits2 adds in trunk
Prevent inconsistent firstChild during document destruction
https://bugs.webkit.org/show_bug.cgi?id=106530
Reviewed by Abhishek Arya.
Source/WebCore:
During document destruction, addChildNodesToDeletionQueue can allow a container
node to have an invalid first child, causing a crash. This patch updates
addChildNodesToDeletionQueue to maintain a valid value for firstChild() even
while updating its children.
Test: svg/custom/animateMotion-path-change-crash.svg
- dom/ContainerNodeAlgorithms.h:
(WebCore::Private::addChildNodesToDeletionQueue):
To ensure prevoiusSibling() is also valid, this code was slightly refactored
to call setPreviousSibling(0) on the next node instead of the current node.
LayoutTests:
- svg/custom/animateMotion-path-change-crash-expected.txt: Added.
- svg/custom/animateMotion-path-change-crash.svg: Added.
- 12:15 PM Changeset in webkit [142898] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] Add an internal 2D grid representation to RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=109714
Reviewed by Ojan Vafai.
This change introduces a 2D grid representation of the grid areas. Our implementation
is a straight Vector of Vectors for the grid areas, each grid area able to hold an
arbitrary number of RenderBox* so they hold a Vector of RenderBoxes. As an optimization,
each grid area has enough inline storage to hold one grid item which should cover
most cases.
In order to keep the code readable, a GridIterator was introduced to hide the new grid.
Refactoring, covered by existing tests.
- rendering/RenderGrid.cpp:
(RenderGrid::GridIterator):
(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::GridIterator::nextGridItem):
Added a mono-directional iterator. In order to be more aligned with the rest of the code,
this iterator actually walks orthogonally to the |direction| (ie fixing the |direction|'s track).
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
(WebCore::RenderGrid::layoutGridItems):
Updated these 2 functions to place the items on the grid and clear it at the end.
(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated to use the GridIterator to walk over the rows / columns.
(WebCore::RenderGrid::placeItemsOnGrid):
Added this function that inserts the grid items into the right grid area.
- rendering/RenderGrid.h:
(WebCore::RenderGrid::gridColumnCount):
(WebCore::RenderGrid::gridRowCount):
Added these helper functions.
- 11:53 AM Changeset in webkit [142897] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r141990.
http://trac.webkit.org/changeset/141990
https://bugs.webkit.org/show_bug.cgi?id=109850
~5% regression on intl2 page cycler (Requested by kling on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::create):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(GlyphPage):
(WebCore::GlyphPage::copyFrom):
(WebCore::GlyphPage::clear):
(WebCore::GlyphPage::clearForFontData):
(WebCore::GlyphPage::GlyphPage):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- 11:31 AM Changeset in webkit [142896] by
-
- 10 edits2 moves1 add in trunk/Source
[Chromium] Move PlatformMessagePortChannel to WebCore
https://bugs.webkit.org/show_bug.cgi?id=109845
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 106829.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- dom/default/chromium: Added.
- dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Added.
(WebCore):
(WebCore::MessagePortChannel::create):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::~MessagePortChannel):
(WebCore::MessagePortChannel::entangleIfOpen):
(WebCore::MessagePortChannel::disentangle):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
(WebCore::MessagePortChannel::close):
(WebCore::MessagePortChannel::isConnectedTo):
(WebCore::MessagePortChannel::hasPendingActivity):
(WebCore::MessagePortChannel::locallyEntangledPort):
(WebCore::PlatformMessagePortChannel::create):
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
(WebCore::PlatformMessagePortChannel::createChannel):
(WebCore::PlatformMessagePortChannel::messageAvailable):
(WebCore::PlatformMessagePortChannel::entangleIfOpen):
(WebCore::PlatformMessagePortChannel::disentangle):
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
(WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
(WebCore::PlatformMessagePortChannel::close):
(WebCore::PlatformMessagePortChannel::isConnectedTo):
(WebCore::PlatformMessagePortChannel::hasPendingActivity):
(WebCore::PlatformMessagePortChannel::setEntangledChannel):
(WebCore::PlatformMessagePortChannel::webChannelRelease):
- dom/default/chromium/PlatformMessagePortChannelChromium.h: Added.
(WebKit):
(WebCore):
(PlatformMessagePortChannel):
Source/WebKit/chromium:
- WebKit.gyp:
- src/PlatformMessagePortChannel.cpp: Removed.
- src/PlatformMessagePortChannel.h: Removed.
- src/SharedWorkerRepository.cpp:
- src/WebDOMMessageEvent.cpp:
- src/WebFrameImpl.cpp:
- src/WebSharedWorkerImpl.cpp:
- src/WebWorkerClientImpl.cpp:
- 11:22 AM Changeset in webkit [142895] by
-
- 9 edits in trunk/Source/WebCore
Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard)
https://bugs.webkit.org/show_bug.cgi?id=90250
Reviewed by Eric Seidel.
The Leopard era checks for accessibility lists and accessibility tables can be removed now.
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore):
- accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
(WebCore::AccessibilityARIAGrid::isTableExposableThroughAccessibility):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityList.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::AccessibilityTable):
(WebCore::AccessibilityTable::init):
- accessibility/AccessibilityTable.h:
(AccessibilityTable):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(createAccessibilityRoleMap):
- 11:17 AM Changeset in webkit [142894] by
-
- 2 edits in trunk/Source/WTF
String(Vector) behaves differently from String(vector.data(), vector.size()) for vectors with inline capacity in the size=0 case
https://bugs.webkit.org/show_bug.cgi?id=109784
Reviewed by Darin Adler.
This makes String(Vector) never return null strings.
Which matches behavior of String(UChar*, size_t)
for vectors with inlineCapacity, but differs from
String(UChar*, size_t) in the no-inlineCapacity case.
This incidentally will fix a behavioral regression
in the html threaded parser which came from converting
many String(UChar*, size_t) callsites to using String(Vector).
- wtf/text/WTFString.h:
(String):
(WTF::String::String):
- 11:09 AM Changeset in webkit [142893] by
-
- 10 edits in trunk
Make outside-shape the default value for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=109605
Patch by Bear Travis <betravis@adobe.com> on 2013-02-14
Reviewed by Levi Weintraub.
Source/WebCore:
Creating a single reference outside-shape value and setting it as the default
for shape-inside.
Existing tests cover the default value, just updating them to use outside-shape.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::initialShapeInside): Define a local static outside-shape
value.
(WebCore):
- rendering/style/RenderStyle.h: Move the initialShapeInside method to the .cpp
file.
LayoutTests:
Updating tests to account for the new default value of shape-inside.
- fast/exclusions/css-exclusions-disabled-expected.txt:
- fast/exclusions/css-exclusions-disabled.html:
- fast/exclusions/parsing-wrap-shape-inside-expected.txt:
- fast/exclusions/parsing-wrap-shape-lengths-expected.txt:
- fast/exclusions/parsing-wrap-shape-lengths.html:
- fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
(negative_test):
- 11:06 AM Changeset in webkit [142892] by
-
- 3 edits1 add in trunk/Tools
Add eol-style=native to solution files. Add a new solution file.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added property svn:eol-style.
- TestWebKitAPI/TestWebKitAPI.vcxproj: Added property svn:eol-style. Modified property svn:ignore.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.sln: Added.
- 10:49 AM Changeset in webkit [142891] by
-
- 7 edits in trunk/Source
Passing alpha to DeferredImageDecoder once decoding completes
https://bugs.webkit.org/show_bug.cgi?id=108892
Patch by Min Qin <qinmin@chromium.org> on 2013-02-14
Reviewed by Stephen White.
Source/WebCore:
We should pass hasAlpha value back to the DeferredImageDecoder once decoding is completed
Added unit tests in ImageFrameGeneratorTest.
- platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::frameHasAlphaAtIndex):
- platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::decode):
- platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
- platform/graphics/chromium/LazyDecodingPixelRef.h:
(WebCore::LazyDecodingPixelRef::hasAlpha):
(LazyDecodingPixelRef):
- platform/graphics/chromium/ScaledImageFragment.cpp:
(WebCore::ScaledImageFragment::ScaledImageFragment):
- platform/graphics/chromium/ScaledImageFragment.h:
(WebCore::ScaledImageFragment::create):
(ScaledImageFragment):
(WebCore::ScaledImageFragment::hasAlpha):
Source/WebKit/chromium:
Add test to check that alpha value is passed from the decoder to ImageFrameGenerator.
- tests/ImageFrameGeneratorTest.cpp:
(WebCore::MockImageDecoderFactory::create):
(WebCore::TEST_F):
- tests/MockImageDecoder.h:
(WebCore::MockImageDecoder::MockImageDecoder):
(WebCore::MockImageDecoder::setFrameHasAlpha):
(MockImageDecoder):
(WebCore::MockImageDecoder::frameHasAlphaAtIndex):
- 10:17 AM Changeset in webkit [142890] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762
Reviewed by Tony Chang.
A few places where commits could fail weren't being logged.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):
- 9:53 AM Changeset in webkit [142889] by
-
- 4 edits2 adds in trunk
Padding and border changes doesn't trigger relayout of children
https://bugs.webkit.org/show_bug.cgi?id=109639
Reviewed by Kent Tamura.
Source/WebCore:
In RenderBlock::layoutBlock, we only relayout our children if our logical width
changes. This misses cases where our logical width doesn't change (i.e., padding
or border changes), but our content width does change.
This is a more general case of bug 104997.
Test: fast/block/dynamic-padding-border.html
- rendering/RenderBox.cpp:
(WebCore::borderOrPaddingLogicalWidthChanged): Only check if the logical width changed.
(WebCore::RenderBox::styleDidChange): Drop the border-box condition since this can happen
even without border-box box sizing.
LayoutTests:
- fast/block/dynamic-padding-border-expected.txt: Added.
- fast/block/dynamic-padding-border.html: Added.
- fast/table/border-collapsing/cached-change-row-border-width-expected.txt: We should have been relaying
out the table when the border changed. The pixel results in this case is the same, but the
render tree shows the difference.
- 9:52 AM Changeset in webkit [142888] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: fix closure compilation warnings caused by setVariableValue change
https://bugs.webkit.org/show_bug.cgi?id=109488
Patch by Peter Rybin <prybin@chromium.org> on 2013-02-14
Reviewed by Pavel Feldman.
Annotations are fixed as required by closure compiler.
Parameters in Inspector.json are reordered as required.
- inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.setFunctionVariableValue):
(JavaScriptCallFrame.prototype.setVariableValue):
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setVariableValue):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- 9:47 AM Changeset in webkit [142887] by
-
- 3 edits in trunk/Source/WebCore
MediaStream API: RTCDataChannel triggers a use-after-free
https://bugs.webkit.org/show_bug.cgi?id=109806
Reviewed by Adam Barth.
Making sure RTCPeerConnection::stop() is always called at least once.
Also making sure that RTCDataChannels state gets set to Closed correctly.
Hard to test in WebKit but covered by Chromium tests.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::stop):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::stop):
- 9:38 AM Changeset in webkit [142886] by
-
- 5 edits in trunk
Web Inspector: [Regression] When several consecutive characters are typed each of them is marked as undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109823
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
- inspector/editor/text-editor-undo-redo-expected.txt:
- inspector/editor/text-editor-undo-redo.html:
- 9:23 AM Changeset in webkit [142885] by
-
- 7 edits2 deletes in trunk
Unreviewed, rolling out r142820.
http://trac.webkit.org/changeset/142820
https://bugs.webkit.org/show_bug.cgi?id=109839
Causing crashes on chromium canaries (Requested by atwilson_
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::updateLayout):
(WebCore::Document::implicitClose):
- rendering/RenderQuote.h:
(RenderQuote):
- rendering/RenderView.cpp:
- rendering/RenderView.h:
LayoutTests:
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
- fast/css-generated-content/quote-layout-focus-crash-expected.txt: Removed.
- fast/css-generated-content/quote-layout-focus-crash.html: Removed.
- 9:21 AM Changeset in webkit [142884] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update keyboard event details to match platform details.
https://bugs.webkit.org/show_bug.cgi?id=109693
Reviewed by Yong Li.
PR 220170.
When re-creating the Platform::Keyboard event ensure
all values are updated.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- 9:15 AM Changeset in webkit [142883] by
-
- 9 edits2 adds in trunk
[GTK] Missing call to g_object_ref while retrieving accessible table cells
https://bugs.webkit.org/show_bug.cgi?id=106903
Reviewed by Martin Robinson.
Source/WebCore:
Add missing extra ref to implementation of atk_table_ref_at().
Test: accessibility/table-cell-for-column-and-row-crash.html
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): This method transfers full ownership
over the returned AtkObject, so an extra reference is needed here.
Tools:
Both DRT and WKTR need to call g_object_unref() now that an extra
reference is added in the implementation of atk_table_ref_at().
- DumpRenderTree/atk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::cellForColumnAndRow): Call g_object_unref
before returning the new instance of AccessibilityUIElement.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
LayoutTests:
Added new test. It should work fine at least in Mac and GTK ports,
but will need specific results for chromium and windows.
- accessibility/table-cell-for-column-and-row-crash.html: Added.
- accessibility/table-cell-for-column-and-row-crash-expected.txt: Added.
- platform/chromium/TestExpectations: Skipped test.
- platform/win/TestExpectations: Ditto.
- platform/wincairo/TestExpectations: Ditto.
- 9:11 AM Changeset in webkit [142882] by
-
- 4 edits in trunk/Source
[BlackBerry] Update keyboard event details to match platform details.
https://bugs.webkit.org/show_bug.cgi?id=109693
Reviewed by Yong Li.
PR 220170.
Source/WebCore:
Update the keyboard event details to match the
platform details available.
Rename helper function to better describe the conversion.
Reviewed Internally by Nima Ghanavatian and Gen Mak.
- platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::windowsKeyCodeForBlackBerryKeycode):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Source/WebKit/blackberry:
Update keyboard event details.
Reviewed Internally by Nima Ghanavatian and Gen Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::keyEvent):
- 9:06 AM Changeset in webkit [142881] by
-
- 2 edits6 adds in trunk/LayoutTests
[Qt] Reviewing TestExpectations. Added platform specific expected files and unskip them.
https://bugs.webkit.org/show_bug.cgi?id=59334.
- platform/qt-5.0-wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
- platform/qt/TestExpectations:
- platform/qt/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
- 8:47 AM Changeset in webkit [142880] by
-
- 21 edits in trunk/LayoutTests
[Chromium] Unreviewed rebaseline after brightness filter update.
- platform/chromium-linux/css3/filters/effect-brightness-clamping-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-expected.png:
- platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-clamping-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-expected.png:
- platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-expected.png:
- platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-mac/css3/filters/multiple-filters-invalidation-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-clamping-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-clamping-hw-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-expected.png:
- platform/chromium-win/css3/filters/effect-brightness-hw-expected.png:
- platform/chromium-win/css3/filters/effect-combined-expected.png:
- platform/chromium-win/css3/filters/effect-combined-hw-expected.png:
- platform/chromium-win/css3/filters/multiple-filters-invalidation-expected.png:
- platform/chromium/TestExpectations:
- 8:39 AM Changeset in webkit [142879] by
-
- 18 edits in trunk
Web Inspector: expose did{Begin,Cancel}Frame() and {will,did}Composite() on WebDebToolsAgent
https://bugs.webkit.org/show_bug.cgi?id=109192
Reviewed by Pavel Feldman.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- remove frame and compositing instrumentation methods from InspectorInstrumentation;
- expose those methods on InspectorController instead.
- WebCore.exp.in:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didBeginFrame):
(WebCore):
(WebCore::InspectorController::didCancelFrame):
(WebCore::InspectorController::willComposite):
(WebCore::InspectorController::didComposite):
- inspector/InspectorController.h:
(InspectorController):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- testing/Internals.cpp:
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
Source/WebKit/blackberry:
- invoke frame instrumentation methods on InspectorController, not on InspectorInstrumentation.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::instrumentBeginFrame):
(BlackBerry::WebKit::BackingStorePrivate::instrumentCancelFrame):
Source/WebKit/chromium:
- expose frame and compositing insturmentation methods on WebDevToolsAgent;
- temporarily route them from WebViewImpl to WebDevToolsAgent;
- public/WebDevToolsAgent.h:
(WebDevToolsAgent):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::didBeginFrame):
(WebKit):
(WebKit::WebDevToolsAgentImpl::didCancelFrame):
(WebKit::WebDevToolsAgentImpl::willComposite):
(WebKit::WebDevToolsAgentImpl::didComposite):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentBeginFrame):
(WebKit::WebViewImpl::instrumentCancelFrame):
(WebKit::WebViewImpl::didBeginFrame):
(WebKit::WebViewImpl::willCommit):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 8:15 AM Changeset in webkit [142878] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fixed a layout regression in CanvasProfileView.
https://bugs.webkit.org/show_bug.cgi?id=109835
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
Reviewed by Pavel Feldman.
Changed splitView.css to supported nested SplitView instances.
- inspector/front-end/splitView.css:
(.split-view-vertical > .split-view-contents):
(.split-view-vertical > .split-view-contents-first):
(.split-view-vertical > .split-view-contents-first.maximized):
(.split-view-vertical > .split-view-contents-second):
(.split-view-vertical > .split-view-contents-second.maximized):
(.split-view-horizontal > .split-view-contents):
(.split-view-horizontal > .split-view-contents-first):
(.split-view-horizontal > .split-view-contents-first.maximized):
(.split-view-horizontal > .split-view-contents-second):
(.split-view-horizontal > .split-view-contents-second.maximized):
(.split-view-vertical > .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical > .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal > .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal > .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical > .split-view-resizer):
(.split-view-horizontal > .split-view-resizer):
- 8:05 AM Changeset in webkit [142877] by
-
- 2 edits in trunk/LayoutTests
Unskip mediastream tests that are passing after webkit_support update
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 7:15 AM Changeset in webkit [142876] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Color picker should not be available in Computed Styles pane.
https://bugs.webkit.org/show_bug.cgi?id=109697
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-14
Reviewed by Alexander Pavlov.
Changed the parentPane parameter of WebInspector.ComputedStylePropertiesSection to the correct value
(the ComputedStyleSidebarPane instance).
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
- 5:53 AM Changeset in webkit [142875] by
-
- 6 edits2 adds in trunk/Source/WebKit/chromium
[Chromium] Add a setting to control scaling content to fit viewport
https://bugs.webkit.org/show_bug.cgi?id=109584
Adds a setting called 'initializeAtMinimumPageScale'. By default,
it is set to 'true' which corresponds to Chrome on Android behavior--
adjust the page scale to make the content fit into the viewport
by width. When set to false, the setting instructs ChromeClientImpl to
set page scale to 1.0, unless the scale value is set by the page
in the viewport meta-tag.
Reviewed by Adam Barth.
- public/WebSettings.h:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setInitializeAtMinimumPageScale):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::initializeAtMinimumPageScale):
- tests/WebFrameTest.cpp:
- tests/data/viewport-2x-initial-scale.html: Added.
- tests/data/viewport-auto-initial-scale.html: Added.
- 5:39 AM Changeset in webkit [142874] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip flaky test after r140689.
- platform/qt/TestExpectations:
- 5:19 AM Changeset in webkit [142873] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: don't create static local string for program literal in InspectorTimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=109811
Reviewed by Pavel Feldman.
Use const char* constant value instead of creating String from it in thread-unsafe
static local variable.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
- 5:08 AM Changeset in webkit [142872] by
-
- 4 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r142808.
http://trac.webkit.org/changeset/142808
https://bugs.webkit.org/show_bug.cgi?id=109816
Crashes on chromium webkit canary bots (Requested by atwilson_
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::enableTouchHighlight):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/LinkHighlightTest.cpp:
(WebCore::TEST):
- 5:01 AM Changeset in webkit [142871] by
-
- 3 edits in trunk/Source/WebCore
[Web Inspector] Fix initiator name issue in reload scenario for Network Panel.
https://bugs.webkit.org/show_bug.cgi?id=108746.
Patch by Pan Deng <pan.deng@intel.com> on 2013-02-14
Reviewed by Vsevolod Vlasov.
WebInspector.displayNameForURL() does not work as expected in the reload scenario,
for example, "http://www.yahoo.com/" was trimed to "/" at one time, but at another,
the full host name will be displayed.
This fix return host + "/" in the issue scenario, and keep with get displayName() in ParsedURL.
No new tests.
- inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL.prototype.get displayName): append "/" in the display host scenario.
- inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL): add host in the head if url trimed as a "/".
- 4:57 AM Changeset in webkit [142870] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fix to record button remaining red after heap snapshot is taken
https://bugs.webkit.org/show_bug.cgi?id=109804
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-14
Reviewed by Yury Semikhatsky.
Revert part of r142243 fix. Namely heap snapshot taking button made
stateless as it was before.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
- 4:47 AM Changeset in webkit [142869] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Consistently use SecurityOrigin::toRawString() for serialization across the backend code
https://bugs.webkit.org/show_bug.cgi?id=109801
Reviewed by Yury Semikhatsky.
No new tests, as existing tests cover the change.
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
- 4:35 AM Changeset in webkit [142868] by
-
- 2 edits in trunk/Source/WebCore
Add logging support to IndexedDB for non-Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=109809
Reviewed by Kentaro Hara.
Enable logging of IndexedDB through the StorageAPI log channel for
non-Chromium architectures.
No new tests required, we're just enabling logging for IndexedDB
using the currently available logging framework.
- Modules/indexeddb/IDBTracing.h:
- 4:27 AM Changeset in webkit [142867] by
-
- 6 edits in trunk
Web Inspector: Remove uriForFile and fileForURI methods from FileSystemMapping.
https://bugs.webkit.org/show_bug.cgi?id=109704
Reviewed by Alexander Pavlov.
Source/WebCore:
Replaced this methods with one line implementation on the only call site.
- inspector/front-end/FileSystemMapping.js:
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype._filePathForURI):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
LayoutTests:
- inspector/file-system-mapping-expected.txt:
- inspector/file-system-mapping.html:
- 4:09 AM Changeset in webkit [142866] by
-
- 4 edits2 adds in trunk
[Text Autosizing] Process narrow descendants with the same multiplier for the font size.
https://bugs.webkit.org/show_bug.cgi?id=109573
Source/WebCore:
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.
Combine narrow descendants of the same autosizing cluster into a group that is autosized
with the same multiplier.
For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we want them all to share the same multiplier, as
if they were a single cluster.
Test: fast/text-autosizing/narrow-descendants-combined.html
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::processClusterInternal):
Common implementation for processCluster() and processCompositeCluster that accepts the
text width and whether the cluster should be autosized as parameters instead of
calculating it inline.
(WebCore::TextAutosizer::processCluster):
Calculates the text width for a single cluster and whether it should be autosized, then
calls processClusterInternal() to apply the multiplier and process the cluster's
descendants.
(WebCore::TextAutosizer::processCompositeCluster):
Calculates the text width for a group of renderers and if the group should be autosized,
then calls processClusterInternal() repeatedly with the same multiplier to apply it and
process all the descendants of the group.
(WebCore::TextAutosizer::clusterShouldBeAutosized):
Calls the multiple renderers version to avoid code duplication.
(WebCore::TextAutosizer::compositeClusterShouldBeAutosized):
The multiple renderers version of clusterShouldBeAutosized.
- rendering/TextAutosizer.h:
Updated method declarations.
LayoutTests:
Test to verify that all narrow descendants of a cluster are autosized with the same
multiplier.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.
- fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
- fast/text-autosizing/narrow-descendants-combined.html: Added.
- 3:53 AM Changeset in webkit [142865] by
-
- 2 edits13 adds in trunk/Source/WebCore
Look into possibilities of typedef in webkit idl files
https://bugs.webkit.org/show_bug.cgi?id=52340
Reviewed by Kentaro Hara.
Add typedef support for WebKit IDL parser.
Drive by: fixed a bug of generating "unrestrictedfloat" without a space.
Added a new IDL test TestTypedefs.idl. The results were generated without typedefs.
- bindings/scripts/IDLParser.pm:
(assertNoExtendedAttributesInTypedef):
(parseDefinitions):
(applyTypedefs):
(applyTypedefsForSignature):
(parseTypedef):
(parseUnrestrictedFloatType):
- bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp: Added.
(WebDOMTestTypedefs::WebDOMTestTypedefsPrivate::WebDOMTestTypedefsPrivate):
(WebDOMTestTypedefs::WebDOMTestTypedefsPrivate):
(WebDOMTestTypedefs::WebDOMTestTypedefs):
(WebDOMTestTypedefs::operator=):
(WebDOMTestTypedefs::impl):
(WebDOMTestTypedefs::~WebDOMTestTypedefs):
(WebDOMTestTypedefs::unsignedLongLongAttr):
(WebDOMTestTypedefs::setUnsignedLongLongAttr):
(WebDOMTestTypedefs::immutableSerializedScriptValue):
(WebDOMTestTypedefs::setImmutableSerializedScriptValue):
(WebDOMTestTypedefs::func):
(WebDOMTestTypedefs::multiTransferList):
(WebDOMTestTypedefs::setShadow):
(WebDOMTestTypedefs::nullableArrayArg):
(WebDOMTestTypedefs::immutablePointFunction):
(toWebCore):
(toWebKit):
- bindings/scripts/test/CPP/WebDOMTestTypedefs.h: Added.
(WebCore):
(WebDOMTestTypedefs):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp: Added.
(_WebKitDOMTestTypedefsPrivate):
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestTypedefs):
(webkit_dom_test_typedefs_finalize):
(webkit_dom_test_typedefs_set_property):
(webkit_dom_test_typedefs_get_property):
(webkit_dom_test_typedefs_constructor):
(webkit_dom_test_typedefs_class_init):
(webkit_dom_test_typedefs_init):
(webkit_dom_test_typedefs_func):
(webkit_dom_test_typedefs_multi_transfer_list):
(webkit_dom_test_typedefs_set_shadow):
(webkit_dom_test_typedefs_nullable_array_arg):
(webkit_dom_test_typedefs_immutable_point_function):
(webkit_dom_test_typedefs_string_array_function):
(webkit_dom_test_typedefs_get_unsigned_long_long_attr):
(webkit_dom_test_typedefs_set_unsigned_long_long_attr):
(webkit_dom_test_typedefs_get_immutable_serialized_script_value):
(webkit_dom_test_typedefs_set_immutable_serialized_script_value):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h: Added.
(_WebKitDOMTestTypedefs):
(_WebKitDOMTestTypedefsClass):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h: Added.
(WebKit):
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Added.
(WebCore):
(WebCore::JSTestTypedefsConstructor::constructJSTestTypedefs):
(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::finishCreation):
(WebCore::JSTestTypedefsConstructor::getOwnPropertySlot):
(WebCore::JSTestTypedefsConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestTypedefsConstructor::getConstructData):
(WebCore::JSTestTypedefsPrototype::self):
(WebCore::JSTestTypedefsPrototype::getOwnPropertySlot):
(WebCore::JSTestTypedefsPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::finishCreation):
(WebCore::JSTestTypedefs::createPrototype):
(WebCore::JSTestTypedefs::destroy):
(WebCore::JSTestTypedefs::~JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot):
(WebCore::JSTestTypedefs::getOwnPropertyDescriptor):
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsImmutableSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsConstructor):
(WebCore::JSTestTypedefs::put):
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::JSTestTypedefs::getConstructor):
(WebCore::jsTestTypedefsPrototypeFunctionFunc):
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):
(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionNullableArrayArg):
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp):
(WebCore::jsTestTypedefsPrototypeFunctionImmutablePointFunction):
(WebCore::jsTestTypedefsPrototypeFunctionStringArrayFunction):
(WebCore::isObservable):
(WebCore::JSTestTypedefsOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestTypedefsOwner::finalize):
(WebCore::toJS):
(WebCore::toTestTypedefs):
- bindings/scripts/test/JS/JSTestTypedefs.h: Added.
(WebCore):
(JSTestTypedefs):
(WebCore::JSTestTypedefs::create):
(WebCore::JSTestTypedefs::createStructure):
(WebCore::JSTestTypedefs::impl):
(WebCore::JSTestTypedefs::releaseImpl):
(WebCore::JSTestTypedefs::releaseImplIfNotNull):
(JSTestTypedefsOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestTypedefsPrototype):
(WebCore::JSTestTypedefsPrototype::create):
(WebCore::JSTestTypedefsPrototype::createStructure):
(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):
(JSTestTypedefsConstructor):
(WebCore::JSTestTypedefsConstructor::create):
(WebCore::JSTestTypedefsConstructor::createStructure):
- bindings/scripts/test/ObjC/DOMTestTypedefs.h: Added.
- bindings/scripts/test/ObjC/DOMTestTypedefs.mm: Added.
(-[DOMTestTypedefs dealloc]):
(-[DOMTestTypedefs finalize]):
(-[DOMTestTypedefs unsignedLongLongAttr]):
(-[DOMTestTypedefs setUnsignedLongLongAttr:]):
(-[DOMTestTypedefs immutableSerializedScriptValue]):
(-[DOMTestTypedefs setImmutableSerializedScriptValue:]):
(-[DOMTestTypedefs multiTransferList:tx:second:txx:]):
(-[DOMTestTypedefs setShadow:height:blur:color:alpha:]):
(-[DOMTestTypedefs immutablePointFunction]):
(core):
(kit):
- bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h: Added.
(WebCore):
- bindings/scripts/test/TestTypedefs.idl: Added.
- bindings/scripts/test/V8/V8TestTypedefs.cpp: Added.
(WebCore):
(WebCore::checkTypeOrDieTrying):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::V8_USE):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetter):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
(WebCore::TestTypedefsV8Internal::TestTypedefsConstructorGetter):
(WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetter):
(WebCore::TestTypedefsV8Internal::funcCallback):
(WebCore::TestTypedefsV8Internal::multiTransferListCallback):
(WebCore::TestTypedefsV8Internal::setShadowCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgCallback):
(WebCore::TestTypedefsV8Internal::funcWithClampCallback):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionCallback):
(WebCore::V8TestTypedefs::constructorCallback):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetRawTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
(WebCore::V8TestTypedefs::createWrapper):
(WebCore::V8TestTypedefs::derefObject):
- bindings/scripts/test/V8/V8TestTypedefs.h: Added.
(WebCore):
(V8TestTypedefs):
(WebCore::V8TestTypedefs::toNative):
(WebCore::V8TestTypedefs::installPerContextProperties):
(WebCore::V8TestTypedefs::installPerContextPrototypeProperties):
(WebCore::wrap):
(WebCore::toV8):
(WebCore::toV8Fast):
- 3:18 AM Changeset in webkit [142864] by
-
- 2 edits in trunk
[V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(),
and XXXAccessorSetter() to XXXAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=109679
Reviewed by Adam Barth.
For naming consistency and clarification.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateHeaderCustomCall):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::customAttrAttrGetter):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):
- bindings/v8/custom/V8BiquadFilterNodeCustom.cpp:
(WebCore::V8BiquadFilterNode::typeAttrSetterCustom):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrSetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrSetterCustom):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAttrGetterCustom):
- bindings/v8/custom/V8CoordinatesCustom.cpp:
(WebCore::V8Coordinates::altitudeAttrGetterCustom):
(WebCore::V8Coordinates::altitudeAccuracyAttrGetterCustom):
(WebCore::V8Coordinates::headingAttrGetterCustom):
(WebCore::V8Coordinates::speedAttrGetterCustom):
- bindings/v8/custom/V8CustomEventCustom.cpp:
(WebCore::V8CustomEvent::detailAttrGetterCustom):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::locationAttrSetterCustom):
(WebCore::V8DOMWindow::openerAttrSetterCustom):
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::accelerationAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::rotationRateAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::intervalAttrGetterCustom):
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::alphaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::betaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::gammaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::absoluteAttrGetterCustom):
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAttrGetterCustom):
(WebCore::V8Document::locationAttrSetterCustom):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAttrGetterCustom):
(WebCore::V8Event::clipboardDataAttrGetterCustom):
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAttrGetterCustom):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::allAttrSetterCustom):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAttrGetterCustom):
(WebCore::V8HTMLElement::itemValueAttrSetterCustom):
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
(WebCore::V8HTMLFrameElement::locationAttrSetterCustom):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionStartAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrSetterCustom):
- bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAttrGetterCustom):
(WebCore::V8HTMLLinkElement::sizesAttrSetterCustom):
- bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAttrSetterCustom):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAttrGetterCustom):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::scopeChainAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::thisObjectAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::typeAttrGetterCustom):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAttrSetterCustom):
(WebCore::V8Location::hostAttrSetterCustom):
(WebCore::V8Location::hostnameAttrSetterCustom):
(WebCore::V8Location::hrefAttrSetterCustom):
(WebCore::V8Location::pathnameAttrSetterCustom):
(WebCore::V8Location::portAttrSetterCustom):
(WebCore::V8Location::protocolAttrSetterCustom):
(WebCore::V8Location::searchAttrSetterCustom):
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):
(WebCore::V8MessageEvent::portsAttrGetterCustom):
- bindings/v8/custom/V8OscillatorNodeCustom.cpp:
(WebCore::V8OscillatorNode::typeAttrSetterCustom):
- bindings/v8/custom/V8PannerNodeCustom.cpp:
(WebCore::V8PannerNode::panningModelAttrSetterCustom):
(WebCore::V8PannerNode::distanceModelAttrSetterCustom):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAttrGetterCustom):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAttrGetterCustom):
(WebCore::V8SVGLength::valueAttrSetterCustom):
- bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAttrGetterCustom):
- bindings/v8/custom/V8WebKitAnimationCustom.cpp:
(WebCore::V8WebKitAnimation::iterationCountAttrGetterCustom):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAttrGetterCustom):
(WebCore::V8XMLHttpRequest::responseAttrGetterCustom):
- 2:23 AM Changeset in webkit [142863] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r142712): attribute values show up as "(null)" instead of null with the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=109784
Reviewed by Benjamin Poulain.
When I changed many callsites to use the (existing) String(Vector) constructor
I inadvertantly made those callsites convert empty vectors to null strings
instead of empty strings (like String(UChar,size_t) does).
This is due to an oddity/bug in our Vector implementation where data()
will be 0 if the Vector is empty, but only if it doesn't have inline capacity.
https://bugs.webkit.org/show_bug.cgi?id=109792
This changes String(Vector) to exactly match the behavior of String(vector.data(), vector.size()).
This regression was easily detectable with the threaded parser, because we use String
instead of AtomicString in our CompactToken (used to send the Token data
between threads). The main-thread parser path uses AtomicHTMLToken which
uses AtomicString(Vector) and does not have this bug.
- wtf/text/WTFString.h:
(String):
(WTF::String::String):
- 2:22 AM Changeset in webkit [142862] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: extract DOM counters graph implementation into its own class
https://bugs.webkit.org/show_bug.cgi?id=109796
Reviewed by Alexander Pavlov.
Extracted DOM counters graph implementation into DOMCountersGraph.js leaving
in MemoryStatistics.js only common parts shared with NativeMemoryGraph.js
Added some closure annotations and converted object literals into classes
with named constructors.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/DOMCountersGraph.js: Added.
(WebInspector.DOMCountersGraph):
(WebInspector.DOMCounterUI):
(WebInspector.DOMCountersGraph.Counter):
(WebInspector.DOMCounterUI.prototype.setRange):
(WebInspector.DOMCounterUI.prototype.updateCurrentValue):
(WebInspector.DOMCounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.DOMCounterUI.prototype.saveImageUnderMarker):
(WebInspector.DOMCounterUI.prototype.restoreImageUnderMarker):
(WebInspector.DOMCounterUI.prototype.discardImageUnderMarker):
(WebInspector.DOMCountersGraph.prototype._createCurrentValuesBar):
(WebInspector.DOMCountersGraph.prototype._createCounterUIList):
(WebInspector.DOMCountersGraph.prototype._createCounterUIList.getNodeCount):
(WebInspector.DOMCountersGraph.prototype._createCounterUIList.getListenerCount):
(WebInspector.DOMCountersGraph.prototype._canvasHeight):
(WebInspector.DOMCountersGraph.prototype._onRecordAdded):
(WebInspector.DOMCountersGraph.prototype._draw):
(WebInspector.DOMCountersGraph.prototype._restoreImageUnderMarker):
(WebInspector.DOMCountersGraph.prototype._saveImageUnderMarker):
(WebInspector.DOMCountersGraph.prototype._drawMarker):
(WebInspector.DOMCountersGraph.prototype._drawGraph):
(WebInspector.DOMCountersGraph.prototype._discardImageUnderMarker):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.Counter):
(WebInspector.MemoryStatistics.prototype._createCurrentValuesBar):
(WebInspector.MemoryStatistics.prototype._createCounterUIList):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype._canvasHeight):
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._onClick):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._onMouseMove):
(WebInspector.MemoryStatistics.prototype._restoreImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._drawMarker):
(WebInspector.MemoryStatistics.prototype._discardImageUnderMarker):
- inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryGraph.Counter):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
(WebInspector.NativeMemoryGraph.prototype._draw):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/WebKit.qrc:
- 2:14 AM Changeset in webkit [142861] by
-
- 6 edits4 adds in trunk
Source/WebCore: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857
Patch by Aivo Paas <aivopaas@gmail.com> on 2013-02-14
Reviewed by Allan Sandfeld Jensen.
Mouse cursor changes in styles used to be reflected in UI through dispatching a fake
mousemove event. The old approach has some flaws: it emits a mousemove event in
javascript when there is no mouse movement involved (bug 85343); the fake mousemove
event is cancelled while there is a mouse button held down - cursor won't change
until mouse is moved or the button released (bug 53341); it has extra overhead of
using a timer which was introduced to make scrolling smoother.
The new approach does not use the fake mousemove event. Instead, it uses only the logic
needed for the actual cursor change to happen. This bypasses all the mousemove event related
overhead. The remaining code is a stripped version of what was run through the mousemove
event path. Everything that was not needed for changing a cursor is stripped off, everything
that is needed, remains the same.
The call to update cursor was moved up in the call tree from RenderObject::StyleDidChange
to RenderObject::SetStyle right after the StyleDidChange call. This allows to any updates
and style propagations in StyleDidChange to happen and makes sure that a cursor change is
not missed. Previous place was at the end of RenderObject::StyleDidChange, where it could
have been missed because of an early exit. For example, cursor change on mousedown/up on
a text node missed the correct cursor in the first pass.
Refactored EventHandler::selectCursor to not take a whole mouse event but instead work with
HitTestResult so that EventHandler::updateCursor must not create a useless PlatformEvent.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=85343 (mousemove event on cursor change)
https://bugs.webkit.org/show_bug.cgi?id=53341 (no cursor change when mouse button down)
Tests: fast/events/mouse-cursor-change.html
fast/events/mouse-cursor-no-mousemove.html
- page/EventHandler.cpp:
(WebCore::EventHandler::updateCursor): Newly added method for updating mouse cursor
(WebCore):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
- page/EventHandler.h:
(EventHandler):
- rendering/RenderObject.cpp:
(WebCore::areNonIdenticalCursorListsEqual):
(WebCore):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::styleDidChange):
LayoutTests: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857
Changing CSS cursor should work no matter is mouse button is pressed or not
https://bugs.webkit.org/show_bug.cgi?id=53341
Patch by Aivo Paas <aivopaas@gmail.com> on 2013-02-14
Reviewed by Allan Sandfeld Jensen.
Added tests for changing cursor on mousemove, mousedown, mouseup and mousemove
while mouse button being hold down. Also added test to verify that a mousemove
event is not fired for changing cursor while mouse is not moving.
- fast/events/mouse-cursor-change-expected.txt: Added.
- fast/events/mouse-cursor-change.html: Added.
- fast/events/mouse-cursor-no-mousemove-expected.txt: Added.
- fast/events/mouse-cursor-no-mousemove.html: Added.
- platform/mac/TestExpectations:
- 1:16 AM Changeset in webkit [142860] by
-
- 7 edits in trunk
Unreviewed, rolling out r142841.
http://trac.webkit.org/changeset/142841
https://bugs.webkit.org/show_bug.cgi?id=109791
Caused webkit_unit_tests to crash on chromium bots. (Requested
by atwilson_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
Source/Platform:
- chromium/public/WebUnitTestSupport.h:
(WebKit):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):
- 12:57 AM Changeset in webkit [142859] by
-
- 2 edits in trunk/Tools
[EFL][jhbuild] Silence GSettings-related warning.
https://bugs.webkit.org/show_bug.cgi?id=109749
Reviewed by Martin Robinson.
Apply the same change done to the GTK+ port in r109127; this
silences the warnings printed by glib about the memory GSettings
backend being used.
Not only does this make the bots (as well as manual runs of, say,
WebKitTestRunner) much more silent, but it also removes an stderr
line (which run-perf-tests considers as a failure).
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.setup_environ_for_server): Explicitly set the
GSETTINGS_BACKEND environment variable to "memory".
- 12:38 AM Changeset in webkit [142858] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: Report child nodes as direct members of a container node to make them look like a tree in the snapshot.
https://bugs.webkit.org/show_bug.cgi?id=109703
Also we need to traverse the tree from the top root element down to the leaves.
Reviewed by Yury Semikhatsky.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
- 12:07 AM Changeset in webkit [142857] by
-
- 11 edits2 moves in trunk/Tools
[chromium] move mock notification presenter to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109706
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::notificationPresenter):
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.cpp.
(WebTestRunner::NotificationPresenter::NotificationPresenter):
(WebTestRunner):
(WebTestRunner::NotificationPresenter::~NotificationPresenter):
(WebTestRunner::NotificationPresenter::grantPermission):
(WebTestRunner::NotificationPresenter::simulateClick):
(WebTestRunner::NotificationPresenter::show):
(WebTestRunner::NotificationPresenter::cancel):
(WebTestRunner::NotificationPresenter::objectDestroyed):
(WebTestRunner::NotificationPresenter::checkPermission):
(WebTestRunner::NotificationPresenter::requestPermission):
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Renamed from Tools/DumpRenderTree/chromium/NotificationPresenter.h.
(WebTestRunner):
(NotificationPresenter):
(WebTestRunner::NotificationPresenter::setDelegate):
(WebTestRunner::NotificationPresenter::reset):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setDelegate):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::notificationPresenter):
(WebTestRunner):
(WebTestRunner::TestRunner::grantWebNotificationPermission):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(WebTestRunner):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::notificationPresenter):
(WebTestRunner):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::resetTestController):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 12:01 AM Changeset in webkit [142856] by
-
- 2 edits15 adds in trunk/LayoutTests
Adds the WebGL Conformance Tests limits folder.
https://bugs.webkit.org/show_bug.cgi?id=108904
Reviewed by Kenneth Russell.
- platform/mac/TestExpectations:
- webgl/conformance/limits/gl-max-texture-dimensions-expected.txt: Added.
- webgl/conformance/limits/gl-max-texture-dimensions.html: Added.
- webgl/conformance/limits/gl-min-attribs-expected.txt: Added.
- webgl/conformance/limits/gl-min-attribs.html: Added.
- webgl/conformance/limits/gl-min-textures-expected.txt: Added.
- webgl/conformance/limits/gl-min-textures.html: Added.
- webgl/conformance/limits/gl-min-uniforms-expected.txt: Added.
- webgl/conformance/limits/gl-min-uniforms.html: Added.
- webgl/resources/webgl_test_files/conformance/limits/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/limits/gl-max-texture-dimensions.html: Added.
- webgl/resources/webgl_test_files/conformance/limits/gl-min-attribs.html: Added.
- webgl/resources/webgl_test_files/conformance/limits/gl-min-textures.html: Added.
- webgl/resources/webgl_test_files/conformance/limits/gl-min-uniforms.html: Added.
Feb 13, 2013:
- 11:51 PM Changeset in webkit [142855] by
-
- 21 edits22 adds in trunk
[Shadow DOM] Implements a '::distributed()' pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=82169
Reviewed by Dimitri Glazkov.
Source/WebCore:
Implements a '::distributed()' pseudo element.
See the Shadow DOM specification and the filed bug for the detail.
- http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#selecting-nodes-distributed-to-insertion-points
- https://www.w3.org/Bugs/Public/show_bug.cgi?id=19684
For example, suppose we are given the following DOM tree and shadow tree:
- <A>
- <B>
- <C>
- <B>
[A's ShadowRoot]
<D>
- <style>
E content::distributed(B C) { color: green; }
- <E>
- <content> (Node B is distributed to this insertion point.)
In this case, the style rule defined in the shadow tree matches node 'C'.
A '::distributed()' pseudo element can not be a pseudo class since
an intersection between matched_elements(some_selector) and
matched_elements(some_selector::distributed(...)) is always an
empty set. A '::distributed()' pseudo element is the first-ever
*functional* pseudo element which takes a parameter, which can be
a selector.
This rule crosses the shadow boundary from a shadow tree to the
tree of its shadow host. That means a rule which includes
'::distributed()' pseudo element is defined in shadow tree, but
the node which is matched in the rule, the subject of the
selector, is outside of the shadow tree. Therefore, we cannot
predict where the subject of the selector will be beforehand.
Current CSS implementation assumes the subject of the selector
must exist in the current scope.
To overcome this issue, DocumentRuleSets now has a instance of
ShadowDistributedRules class. A style rule will be stored in this
instance if the rule includes a '::distributed()' pseudo element.
This class also keeps track of each RuleSet by mapping it with a
scope where the rule was originally defined. In the example, the
scope is A's ShadowRoot. The scope is used to check whether the
left-most matched element (in the example, it's a node 'E') exists
in the scope.
Internally, a '::distributed' pseudo element is represented by a
newly introduced 'ShadowDistributed' relation. That makes an
implementation of SelectorChecker::checkSelector() much simpler.
A transformation from a distributed pseudo element to a
ShadowDistributed is done in parsing stage of CSS.
Since '::distributed()' is an experimental feature, it's actually
prefixed with '-webkit-' and guarded by SHADOW_DOM flag.
Tests: fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html
fast/dom/shadow/distributed-pseudo-element-match-all.html
fast/dom/shadow/distributed-pseudo-element-match-descendant.html
fast/dom/shadow/distributed-pseudo-element-nested.html
fast/dom/shadow/distributed-pseudo-element-no-match.html
fast/dom/shadow/distributed-pseudo-element-reprojection.html
fast/dom/shadow/distributed-pseudo-element-scoped.html
fast/dom/shadow/distributed-pseudo-element-support-selector.html
fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html
fast/dom/shadow/distributed-pseudo-element-with-any.html
fast/dom/shadow/distributed-pseudo-element.html
- css/CSSGrammar.y.in:
CSS Grammar was updated to support '::distrbuted(selector)'.
This pseudo element is the first pseudo element which can take a selector as a parameter.
- css/CSSParser.cpp:
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Here we are converting a '::distributed' pseudo element into a
ShadowDistributed relation internally. To support the conversion,
these rewriteSpecifiersXXX functions (formally called
updateSpecifiersXXX) now return the specifiers which may be
converted.
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
- css/CSSParserValues.h:
(CSSParserSelector):
(WebCore::CSSParserSelector::functionArgumentSelector):
To hold an intermediate selector which appears at the position of an argument in
functional pseudo element when parsing CSS.
(WebCore::CSSParserSelector::setFunctionArgumentSelector):
(WebCore::CSSParserSelector::isDistributedPseudoElement):
- css/CSSSelector.cpp:
Add new pseudo element, PseudoDistributed, and its internal representation, ShadowDistributed relation.
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
(CSSSelector):
(WebCore):
(WebCore::CSSSelector::isDistributedPseudoElement):
(WebCore::CSSSelector::isShadowDistributed):
- css/CSSSelectorList.cpp:
(WebCore):
(SelectorHasShadowDistributed):
(WebCore::SelectorHasShadowDistributed::operator()):
(WebCore::CSSSelectorList::hasShadowDistributedAt):
- css/CSSSelectorList.h:
(CSSSelectorList):
- css/DocumentRuleSets.cpp:
(WebCore):
(WebCore::ShadowDistributedRules::addRule):
Every CSS rule which includes '::distributed(...)' should be managed by calling this function.
(WebCore::ShadowDistributedRules::collectMatchRequests):
(WebCore::DocumentRuleSets::resetAuthorStyle):
- css/DocumentRuleSets.h:
(WebCore):
(ShadowDistributedRules):
(WebCore::ShadowDistributedRules::clear):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::shadowDistributedRules)
DocumentRuleSets owns an instance of ShadowDistributedRules.
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
Updated to check whether the rule contains '::distributed()' or not.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
Support ShadowDistributed relation. Check all possible insertion points where a node is distributed.
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
Adds enum of BehaviorAtBoundary. '::distributed()' is the only
rule which uses 'CrossedBoundary' since it is the only rule which
crosses shadow boundaries.
(SelectorCheckingContext):
- css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectIdentifierHashes):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::ruleMatches):
- css/StyleResolver.h:
(MatchRequest):
(WebCore::MatchRequest::MatchRequest): Add behaviorAtBoundary field.
(WebCore):
(StyleResolver):
- html/shadow/InsertionPoint.cpp:
(WebCore::collectInsertionPointsWhereNodeIsDistributed):
(WebCore):
- html/shadow/InsertionPoint.h:
(WebCore):
LayoutTests:
- fast/dom/shadow/distributed-pseudo-element-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-for-shadow-element-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html: Added.
- fast/dom/shadow/distributed-pseudo-element-match-all-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-match-all.html: Added.
- fast/dom/shadow/distributed-pseudo-element-match-descendant-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-match-descendant.html: Added.
- fast/dom/shadow/distributed-pseudo-element-nested-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-nested.html: Added.
- fast/dom/shadow/distributed-pseudo-element-no-match-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-no-match.html: Added.
- fast/dom/shadow/distributed-pseudo-element-reprojection-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-reprojection.html: Added.
- fast/dom/shadow/distributed-pseudo-element-scoped-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-scoped.html: Added.
- fast/dom/shadow/distributed-pseudo-element-support-selector-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-support-selector.html: Added.
- fast/dom/shadow/distributed-pseudo-element-used-in-selector-list-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html: Added.
- fast/dom/shadow/distributed-pseudo-element-with-any-expected.html: Added.
- fast/dom/shadow/distributed-pseudo-element-with-any.html: Added.
- fast/dom/shadow/distributed-pseudo-element.html: Added.
- 11:41 PM Changeset in webkit [142854] by
-
- 1 edit126 adds in trunk/LayoutTests
Add WebGL Conformance Tests more folder.
https://bugs.webkit.org/show_bug.cgi?id=109118
Reviewed by Kenneth Russell.
- webgl/conformance/more/conformance/constants-expected.txt: Added.
- webgl/conformance/more/conformance/constants.html: Added.
- webgl/conformance/more/conformance/getContext-expected.txt: Added.
- webgl/conformance/more/conformance/getContext.html: Added.
- webgl/conformance/more/conformance/methods-expected.txt: Added.
- webgl/conformance/more/conformance/methods.html: Added.
- webgl/conformance/more/conformance/webGLArrays-expected.txt: Added.
- webgl/conformance/more/conformance/webGLArrays.html: Added.
- webgl/conformance/more/functions/bindBuffer-expected.txt: Added.
- webgl/conformance/more/functions/bindBuffer.html: Added.
- webgl/conformance/more/functions/bindBufferBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/bindBufferBadArgs.html: Added.
- webgl/conformance/more/functions/bindFramebufferLeaveNonZero-expected.txt: Added.
- webgl/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
- webgl/conformance/more/functions/bufferData-expected.txt: Added.
- webgl/conformance/more/functions/bufferData.html: Added.
- webgl/conformance/more/functions/bufferSubData-expected.txt: Added.
- webgl/conformance/more/functions/bufferSubData.html: Added.
- webgl/conformance/more/functions/bufferSubDataBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/bufferSubDataBadArgs.html: Added.
- webgl/conformance/more/functions/isTests-expected.txt: Added.
- webgl/conformance/more/functions/isTests.html: Added.
- webgl/conformance/more/functions/isTestsBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/isTestsBadArgs.html: Added.
- webgl/conformance/more/functions/readPixels-expected.txt: Added.
- webgl/conformance/more/functions/readPixels.html: Added.
- webgl/conformance/more/functions/texImage2D-expected.txt: Added.
- webgl/conformance/more/functions/texImage2D.html: Added.
- webgl/conformance/more/functions/texImage2DHTMLBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
- webgl/conformance/more/functions/texSubImage2D-expected.txt: Added.
- webgl/conformance/more/functions/texSubImage2D.html: Added.
- webgl/conformance/more/functions/texSubImage2DHTMLBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
- webgl/conformance/more/functions/uniformMatrix-expected.txt: Added.
- webgl/conformance/more/functions/uniformMatrix.html: Added.
- webgl/conformance/more/functions/uniformMatrixBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/uniformMatrixBadArgs.html: Added.
- webgl/conformance/more/functions/uniformf-expected.txt: Added.
- webgl/conformance/more/functions/uniformf.html: Added.
- webgl/conformance/more/functions/uniformfArrayLen1-expected.txt: Added.
- webgl/conformance/more/functions/uniformfArrayLen1.html: Added.
- webgl/conformance/more/functions/uniformfBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/uniformfBadArgs.html: Added.
- webgl/conformance/more/functions/uniformi-expected.txt: Added.
- webgl/conformance/more/functions/uniformi.html: Added.
- webgl/conformance/more/functions/uniformiBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/uniformiBadArgs.html: Added.
- webgl/conformance/more/functions/vertexAttrib-expected.txt: Added.
- webgl/conformance/more/functions/vertexAttrib.html: Added.
- webgl/conformance/more/functions/vertexAttribBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/vertexAttribBadArgs.html: Added.
- webgl/conformance/more/functions/vertexAttribPointer-expected.txt: Added.
- webgl/conformance/more/functions/vertexAttribPointer.html: Added.
- webgl/conformance/more/functions/vertexAttribPointerBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
- webgl/conformance/more/glsl/arrayOutOfBounds-expected.txt: Added.
- webgl/conformance/more/glsl/arrayOutOfBounds.html: Added.
- webgl/conformance/more/glsl/uniformOutOfBounds-expected.txt: Added.
- webgl/conformance/more/glsl/uniformOutOfBounds.html: Added.
- webgl/resources/webgl_test_files/conformance/more/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/more/README.md: Added.
- webgl/resources/webgl_test_files/conformance/more/all_tests.html: Added.
- webgl/resources/webgl_test_files/conformance/more/all_tests_linkonly.html: Added.
- webgl/resources/webgl_test_files/conformance/more/all_tests_sequential.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-A.js: Added.
(ArgGenerators.activeTexture.generate):
(ArgGenerators.activeTexture.checkArgValidity):
(ArgGenerators.activeTexture.teardown):
(ArgGenerators.attachShader.generate):
(ArgGenerators.attachShader.checkArgValidity):
(ArgGenerators.attachShader.cleanup):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B1.js: Added.
(ArgGenerators.bindAttribLocation.generate):
(ArgGenerators.bindAttribLocation.checkArgValidity):
(ArgGenerators.bindAttribLocation.cleanup):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B2.js: Added.
(ArgGenerators.bindBuffer.generate):
(ArgGenerators.bindBuffer.checkArgValidity):
(ArgGenerators.bindBuffer.cleanup):
(ArgGenerators.bindFramebuffer.generate):
(ArgGenerators.bindFramebuffer.checkArgValidity):
(ArgGenerators.bindFramebuffer.cleanup):
(ArgGenerators.bindRenderbuffer.generate):
(ArgGenerators.bindRenderbuffer.checkArgValidity):
(ArgGenerators.bindRenderbuffer.cleanup):
(ArgGenerators.bindTexture.generate):
(ArgGenerators.bindTexture.checkArgValidity):
(ArgGenerators.bindTexture.cleanup):
(ArgGenerators.blendColor.generate):
(ArgGenerators.blendColor.teardown):
(ArgGenerators.blendEquation.generate):
(ArgGenerators.blendEquation.checkArgValidity):
(ArgGenerators.blendEquation.teardown):
(ArgGenerators.blendEquationSeparate.generate):
(ArgGenerators.blendEquationSeparate.checkArgValidity):
(ArgGenerators.blendEquationSeparate.teardown):
(ArgGenerators.blendFunc.generate):
(ArgGenerators.blendFunc.checkArgValidity):
(ArgGenerators.blendFunc.teardown):
(ArgGenerators.blendFuncSeparate.generate):
(ArgGenerators.blendFuncSeparate.checkArgValidity):
(ArgGenerators.blendFuncSeparate.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B3.js: Added.
(ArgGenerators.bufferData.setup):
(ArgGenerators.bufferData.generate):
(ArgGenerators.bufferData.checkArgValidity):
(ArgGenerators.bufferData.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B4.js: Added.
(ArgGenerators.bufferSubData.setup):
(ArgGenerators.bufferSubData.generate):
(ArgGenerators.bufferSubData.checkArgValidity):
(ArgGenerators.bufferSubData.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-C.js: Added.
(ArgGenerators.checkFramebufferStatus.generate):
(ArgGenerators.checkFramebufferStatus.checkArgValidity):
(ArgGenerators.checkFramebufferStatus.cleanup):
(ArgGenerators.clear.generate):
(ArgGenerators.clear.checkArgValidity):
(ArgGenerators.clearColor.generate):
(ArgGenerators.clearColor.teardown):
(ArgGenerators.clearDepth.generate):
(ArgGenerators.clearDepth.teardown):
(ArgGenerators.clearStencil.generate):
(ArgGenerators.clearStencil.teardown):
(ArgGenerators.colorMask.generate):
(ArgGenerators.colorMask.teardown):
(ArgGenerators.createBuffer.generate):
(ArgGenerators.createBuffer.returnValueCleanup):
(ArgGenerators.createFramebuffer.generate):
(ArgGenerators.createFramebuffer.returnValueCleanup):
(ArgGenerators.createProgram.generate):
(ArgGenerators.createProgram.returnValueCleanup):
(ArgGenerators.createRenderbuffer.generate):
(ArgGenerators.createRenderbuffer.returnValueCleanup):
(ArgGenerators.createShader.generate):
(ArgGenerators.createShader.checkArgValidity):
(ArgGenerators.createShader.returnValueCleanup):
(ArgGenerators.createTexture.generate):
(ArgGenerators.createTexture.returnValueCleanup):
(ArgGenerators.cullFace.generate):
(ArgGenerators.cullFace.checkArgValidity):
(ArgGenerators.cullFace.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-D_G.js: Added.
(ArgGenerators.deleteBuffer.generate):
(ArgGenerators.deleteBuffer.checkArgValidity):
(ArgGenerators.deleteBuffer.cleanup):
(ArgGenerators.deleteFramebuffer.generate):
(ArgGenerators.deleteFramebuffer.checkArgValidity):
(ArgGenerators.deleteFramebuffer.cleanup):
(ArgGenerators.deleteProgram.generate):
(ArgGenerators.deleteProgram.checkArgValidity):
(ArgGenerators.deleteProgram.cleanup):
(ArgGenerators.deleteRenderbuffer.generate):
(ArgGenerators.deleteRenderbuffer.checkArgValidity):
(ArgGenerators.deleteRenderbuffer.cleanup):
(ArgGenerators.deleteShader.generate):
(ArgGenerators.deleteShader.checkArgValidity):
(ArgGenerators.deleteShader.cleanup):
(ArgGenerators.deleteTexture.generate):
(ArgGenerators.deleteTexture.checkArgValidity):
(ArgGenerators.deleteTexture.cleanup):
(ArgGenerators.depthFunc.generate):
(ArgGenerators.depthFunc.checkArgValidity):
(ArgGenerators.depthFunc.teardown):
(ArgGenerators.depthMask.generate):
(ArgGenerators.depthMask.teardown):
(ArgGenerators.depthRange.generate):
(ArgGenerators.depthRange.teardown):
(ArgGenerators.detachShader.generate):
(ArgGenerators.detachShader.checkArgValidity):
(ArgGenerators.detachShader.cleanup):
(ArgGenerators.disable.generate):
(ArgGenerators.disable.checkArgValidity):
(ArgGenerators.disable.cleanup):
(ArgGenerators.disableVertexAttribArray.generate):
(ArgGenerators.disableVertexAttribArray.checkArgValidity):
(ArgGenerators.enable.generate):
(ArgGenerators.enable.checkArgValidity):
(ArgGenerators.enable.cleanup):
(ArgGenerators.enableVertexAttribArray.generate):
(ArgGenerators.enableVertexAttribArray.checkArgValidity):
(ArgGenerators.enableVertexAttribArray.cleanup):
(ArgGenerators.finish.generate):
(ArgGenerators.flush.generate):
(ArgGenerators.frontFace.generate):
(ArgGenerators.frontFace.checkArgValidity):
(ArgGenerators.frontFace.cleanup):
(ArgGenerators.generateMipmap.setup):
(ArgGenerators.generateMipmap.generate):
(ArgGenerators.generateMipmap.checkArgValidity):
(ArgGenerators.generateMipmap.teardown):
(ArgGenerators.getAttachedShaders.setup):
(ArgGenerators.getAttachedShaders.generate):
(ArgGenerators.getAttachedShaders.checkArgValidity):
(ArgGenerators.getAttachedShaders.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-G_I.js: Added.
(ArgGenerators.getAttribLocation.generate):
(ArgGenerators.getAttribLocation.checkArgValidity):
(ArgGenerators.getAttribLocation.cleanup):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-L_S.js: Added.
(ArgGenerators.lineWidth.generate):
(ArgGenerators.lineWidth.teardown):
(ArgGenerators.pixelStorei.generate):
(ArgGenerators.pixelStorei.checkArgValidity):
(ArgGenerators.pixelStorei.teardown):
(ArgGenerators.polygonOffset.generate):
(ArgGenerators.polygonOffset.teardown):
(ArgGenerators.sampleCoverage.generate):
(ArgGenerators.sampleCoverage.teardown):
(ArgGenerators.scissor.generate):
(ArgGenerators.scissor.checkArgValidity):
(ArgGenerators.scissor.teardown):
(ArgGenerators.stencilFunc.generate):
(ArgGenerators.stencilFunc.checkArgValidity):
(ArgGenerators.stencilFunc.teardown):
(ArgGenerators.stencilFuncSeparate.generate):
(ArgGenerators.stencilFuncSeparate.checkArgValidity):
(ArgGenerators.stencilFuncSeparate.teardown):
(ArgGenerators.stencilMask.generate):
(ArgGenerators.stencilMask.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-S_V.js: Added.
(ArgGenerators.stencilMaskSeparate.generate):
(ArgGenerators.stencilMaskSeparate.checkArgValidity):
(ArgGenerators.stencilMaskSeparate.teardown):
(ArgGenerators.stencilOp.generate):
(ArgGenerators.stencilOp.checkArgValidity):
(ArgGenerators.stencilOp.teardown):
(ArgGenerators.stencilOpSeparate.generate):
(ArgGenerators.stencilOpSeparate.checkArgValidity):
(ArgGenerators.stencilOpSeparate.teardown):
(ArgGenerators.texImage2D.setup):
(ArgGenerators.texImage2D.generate):
(ArgGenerators.texImage2D.checkArgValidity):
(ArgGenerators.texImage2D.teardown):
(ArgGenerators.texParameterf.generate):
(ArgGenerators.texParameterf.checkArgValidity):
(ArgGenerators.texParameteri.generate):
(ArgGenerators.texParameteri.checkArgValidity):
(ArgGenerators.viewport.generate):
(ArgGenerators.viewport.checkArgValidity):
(ArgGenerators.viewport.teardown):
- webgl/resources/webgl_test_files/conformance/more/conformance/badArgsArityLessThanArgc.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/constants.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/fuzzTheAPI.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/getContext.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/methods.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI.js: Added.
(Array.from):
(Array.prototype.has):
(Array.prototype.random):
(castToInt):
(constCheck.a.has):
(constCheck):
(isBufferData):
(isVertexAttribute):
(isValidName):
(randomWebGLArray):
(randomArrayBuffer):
(randomBufferData):
(randomSmallWebGLArray):
(randomBufferSubData):
(randomColor):
(randomName):
(randomVertexAttribute):
(randomBool):
(randomStencil):
(randomLineWidth):
(randomImage):
(mutateArgs):
(argGeneratorTestRunner):
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPIBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/webGLArrays.html: Added.
- webgl/resources/webgl_test_files/conformance/more/demos/opengl_web.html: Added.
- webgl/resources/webgl_test_files/conformance/more/demos/video.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bindBuffer.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bindBufferBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bufferData.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bufferSubData.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bufferSubDataBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/isTests.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/isTestsBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/readPixels.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2D.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2D.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrix.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrixBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformf.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformfArrayLen1.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformfBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformi.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/uniformiBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/vertexAttrib.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointer.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/glsl/arrayOutOfBounds.html: Added.
- webgl/resources/webgl_test_files/conformance/more/glsl/longLoops.html: Added.
- webgl/resources/webgl_test_files/conformance/more/glsl/uniformOutOfBounds.html: Added.
- webgl/resources/webgl_test_files/conformance/more/glsl/unusedAttribsUniforms.html: Added.
- webgl/resources/webgl_test_files/conformance/more/index.html: Added.
- webgl/resources/webgl_test_files/conformance/more/performance/CPUvsGPU.html: Added.
- webgl/resources/webgl_test_files/conformance/more/performance/bandwidth.html: Added.
- webgl/resources/webgl_test_files/conformance/more/performance/jsGCPause.html: Added.
- webgl/resources/webgl_test_files/conformance/more/performance/jsMatrixMult.html: Added.
- webgl/resources/webgl_test_files/conformance/more/performance/jsToGLOverhead.html: Added.
- webgl/resources/webgl_test_files/conformance/more/unit.css: Added.
(.ok):
(.fail):
(canvas):
(#test-status):
(#test-log):
(#test-log > div):
(#test-log h2):
(#test-log h3):
(#test-log p):
- webgl/resources/webgl_test_files/conformance/more/unit.js: Added.
(.window.console.log):
(.window.console.error):
(Tests.startUnit):
(Tests.setup):
(Tests.teardown):
(Tests.endUnit):
(.):
(Object.toSource):
- webgl/resources/webgl_test_files/conformance/more/util.js: Added.
(loadTexture):
(getShader):
(loadShaderArray):
(loadShader):
(getGLErrorAsString):
(checkError):
(throwError):
(Math.cot):
(Matrix.newIdentity):
(Matrix.newIdentity3x3):
(Matrix.copyMatrix):
(Matrix.to3x3):
(Matrix.inverseON):
(Matrix.inverseTo3x3):
(Matrix.inverseTo3x3InPlace):
(Matrix.inverse3x3):
(Matrix.inverse3x3InPlace):
(Matrix.frustum):
(Matrix.perspective):
(Matrix.mul4x4):
(Matrix.mul4x4InPlace):
(Matrix.mulv4):
(Matrix.rotate):
(Matrix.rotateInPlace):
(Matrix.scale):
(Matrix.scale3):
(Matrix.scale1):
(Matrix.scale3InPlace):
(Matrix.scale1InPlace):
(Matrix.scaleInPlace):
(Matrix.translate3):
(Matrix.translate):
(Matrix.translate3InPlace):
(Matrix.translateInPlace):
(Matrix.lookAt):
(Matrix.transpose4x4):
(Matrix.transpose4x4InPlace):
(Matrix.transpose3x3):
(Matrix.transpose3x3InPlace):
(Vec3.make):
(Vec3.copy):
(Vec3.add):
(Vec3.sub):
(Vec3.negate):
(Vec3.direction):
(Vec3.normalizeInPlace):
(Vec3.normalize):
(Vec3.scale):
(Vec3.dot):
(Vec3.inner):
(Vec3.cross):
(Shader):
(Shader.prototype.destroy):
(Shader.prototype.compile):
(Shader.prototype.use):
(Shader.prototype.uniform1fv):
(Shader.prototype.uniform2fv):
(Shader.prototype.uniform3fv):
(Shader.prototype.uniform4fv):
(Shader.prototype.uniform1f):
(Shader.prototype.uniform2f):
(Shader.prototype.uniform3f):
(Shader.prototype.uniform4f):
(Shader.prototype.uniform1iv):
(Shader.prototype.uniform2iv):
(Shader.prototype.uniform3iv):
(Shader.prototype.uniform4iv):
(Shader.prototype.uniform1i):
(Shader.prototype.uniform2i):
(Shader.prototype.uniform3i):
(Shader.prototype.uniform4i):
(Shader.prototype.uniformMatrix4fv):
(Shader.prototype.uniformMatrix3fv):
(Shader.prototype.uniformMatrix2fv):
(Shader.prototype.attrib):
(Shader.prototype.uniform):
(Filter):
(Filter.prototype.apply):
(VBO):
(VBO.prototype.setData):
(VBO.prototype.destroy):
(VBO.prototype.init):
(VBO.prototype.use):
(VBO.prototype.draw):
(FBO):
(FBO.prototype.destroy):
(FBO.prototype.init):
(FBO.prototype.getTempCanvas):
(FBO.prototype.use):
(GLError):
(makeGLErrorWrapper):
(wrapGLContext.wrap.getError):
(getGLContext):
(assertSomeGLError):
(assertThrowNoGLError):
(Quad.makeVBO):
(.gl):
(Quad.getCachedVBO):
(deleteShader):
(Cube.create):
(Cube.makeVBO):
(Cube.getCachedVBO):
(Sphere.create.vert):
(Sphere.create):
(initGL_CONTEXT_ID):
- 11:36 PM Changeset in webkit [142853] by
-
- 1 edit45 adds in trunk/LayoutTests
Add the WebGL Conformance Tests extensions folder.
https://bugs.webkit.org/show_bug.cgi?id=109117
Reviewed by Kenneth Russell.
- webgl/conformance/extensions/ext-texture-filter-anisotropic-expected.txt: Added.
- webgl/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
- webgl/conformance/extensions/get-extension-expected.txt: Added.
- webgl/conformance/extensions/get-extension.html: Added.
- webgl/conformance/extensions/oes-element-index-uint-expected.txt: Added.
- webgl/conformance/extensions/oes-element-index-uint.html: Added.
- webgl/conformance/extensions/oes-standard-derivatives-expected.txt: Added.
- webgl/conformance/extensions/oes-standard-derivatives.html: Added.
- webgl/conformance/extensions/oes-texture-float-expected.txt: Added.
- webgl/conformance/extensions/oes-texture-float-with-canvas-expected.txt: Added.
- webgl/conformance/extensions/oes-texture-float-with-canvas.html: Added.
- webgl/conformance/extensions/oes-texture-float-with-image-data-expected.txt: Added.
- webgl/conformance/extensions/oes-texture-float-with-image-data.html: Added.
- webgl/conformance/extensions/oes-texture-float-with-image-expected.txt: Added.
- webgl/conformance/extensions/oes-texture-float-with-image.html: Added.
- webgl/conformance/extensions/oes-texture-float-with-video-expected.txt: Added.
- webgl/conformance/extensions/oes-texture-float-with-video.html: Added.
- webgl/conformance/extensions/oes-texture-float.html: Added.
- webgl/conformance/extensions/oes-vertex-array-object-expected.txt: Added.
- webgl/conformance/extensions/oes-vertex-array-object.html: Added.
- webgl/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Added.
- webgl/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
- webgl/conformance/extensions/webgl-debug-renderer-info-expected.txt: Added.
- webgl/conformance/extensions/webgl-debug-renderer-info.html: Added.
- webgl/conformance/extensions/webgl-debug-shaders-expected.txt: Added.
- webgl/conformance/extensions/webgl-debug-shaders.html: Added.
- webgl/conformance/extensions/webgl-depth-texture-expected.txt: Added.
- webgl/conformance/extensions/webgl-depth-texture.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/get-extension.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-standard-derivatives.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-canvas.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image-data.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-video.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/oes-vertex-array-object.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-renderer-info.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-shaders.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html: Added.
- 11:31 PM Changeset in webkit [142852] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark new WebGL conformance tests added in r142847 as failing for
EFL WK2.
- platform/efl-wk2/TestExpectations:
- 11:10 PM Changeset in webkit [142851] by
-
- 1 edit454 adds in trunk/LayoutTests
Add the WebGL Conformance Tests ogles folder.
https://bugs.webkit.org/show_bug.cgi?id=109116
Reviewed by Kenneth Russell.
- webgl/conformance/ogles/GL/abs/abs_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
- webgl/conformance/ogles/GL/all/all_001_to_004-expected.txt: Added.
- webgl/conformance/ogles/GL/all/all_001_to_004.html: Added.
- webgl/conformance/ogles/GL/any/any_001_to_004-expected.txt: Added.
- webgl/conformance/ogles/GL/any/any_001_to_004.html: Added.
- webgl/conformance/ogles/GL/array/array_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/array/array_001_to_006.html: Added.
- webgl/conformance/ogles/GL/atan/atan_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
- webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
- webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
- webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt: Added.
- webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
- webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001-expected.txt: Added.
- webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
- webgl/conformance/ogles/GL/ceil/ceil_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
- webgl/conformance/ogles/GL/clamp/clamp_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
- webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010-expected.txt: Added.
- webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
- webgl/conformance/ogles/GL/cos/cos_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
- webgl/conformance/ogles/GL/cross/cross_001_to_002-expected.txt: Added.
- webgl/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
- webgl/conformance/ogles/GL/default/default_001_to_001-expected.txt: Added.
- webgl/conformance/ogles/GL/default/default_001_to_001.html: Added.
- webgl/conformance/ogles/GL/degrees/degrees_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
- webgl/conformance/ogles/GL/discard/discard_001_to_002-expected.txt: Added.
- webgl/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
- webgl/conformance/ogles/GL/distance/distance_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
- webgl/conformance/ogles/GL/dot/dot_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
- webgl/conformance/ogles/GL/equal/equal_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
- webgl/conformance/ogles/GL/equal/equal_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
- webgl/conformance/ogles/GL/exp/exp_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
- webgl/conformance/ogles/GL/exp/exp_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
- webgl/conformance/ogles/GL/exp2/exp2_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
- webgl/conformance/ogles/GL/exp2/exp2_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
- webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
- webgl/conformance/ogles/GL/floor/floor_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
- webgl/conformance/ogles/GL/fract/fract_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
- webgl/conformance/ogles/GL/functions/functions_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
- webgl/conformance/ogles/GL/functions/functions_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
- webgl/conformance/ogles/GL/functions/functions_017_to_024-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
- webgl/conformance/ogles/GL/functions/functions_025_to_032-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
- webgl/conformance/ogles/GL/functions/functions_033_to_040-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
- webgl/conformance/ogles/GL/functions/functions_041_to_048-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
- webgl/conformance/ogles/GL/functions/functions_049_to_056-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
- webgl/conformance/ogles/GL/functions/functions_057_to_064-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
- webgl/conformance/ogles/GL/functions/functions_065_to_072-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
- webgl/conformance/ogles/GL/functions/functions_073_to_080-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
- webgl/conformance/ogles/GL/functions/functions_081_to_088-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
- webgl/conformance/ogles/GL/functions/functions_089_to_096-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
- webgl/conformance/ogles/GL/functions/functions_097_to_104-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
- webgl/conformance/ogles/GL/functions/functions_105_to_112-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
- webgl/conformance/ogles/GL/functions/functions_113_to_120-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
- webgl/conformance/ogles/GL/functions/functions_121_to_126-expected.txt: Added.
- webgl/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
- webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt: Added.
- webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
- webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001-expected.txt: Added.
- webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
- webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
- webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
- webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
- webgl/conformance/ogles/GL/length/length_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/length/length_001_to_006.html: Added.
- webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
- webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
- webgl/conformance/ogles/GL/log/log_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/log/log_009_to_012.html: Added.
- webgl/conformance/ogles/GL/log2/log2_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
- webgl/conformance/ogles/GL/mat/mat_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
- webgl/conformance/ogles/GL/mat/mat_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
- webgl/conformance/ogles/GL/mat/mat_017_to_024-expected.txt: Added.
- webgl/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
- webgl/conformance/ogles/GL/mat/mat_025_to_032-expected.txt: Added.
- webgl/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
- webgl/conformance/ogles/GL/mat/mat_033_to_040-expected.txt: Added.
- webgl/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
- webgl/conformance/ogles/GL/mat/mat_041_to_046-expected.txt: Added.
- webgl/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
- webgl/conformance/ogles/GL/mat3/mat3_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
- webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004-expected.txt: Added.
- webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
- webgl/conformance/ogles/GL/max/max_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/max/max_001_to_006.html: Added.
- webgl/conformance/ogles/GL/min/min_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/min/min_001_to_006.html: Added.
- webgl/conformance/ogles/GL/mix/mix_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
- webgl/conformance/ogles/GL/mod/mod_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
- webgl/conformance/ogles/GL/normalize/normalize_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
- webgl/conformance/ogles/GL/not/not_001_to_004-expected.txt: Added.
- webgl/conformance/ogles/GL/not/not_001_to_004.html: Added.
- webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
- webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012-expected.txt: Added.
- webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
- webgl/conformance/ogles/GL/operators/operators_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
- webgl/conformance/ogles/GL/operators/operators_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
- webgl/conformance/ogles/GL/operators/operators_017_to_024-expected.txt: Added.
- webgl/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
- webgl/conformance/ogles/GL/operators/operators_025_to_026-expected.txt: Added.
- webgl/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
- webgl/conformance/ogles/GL/pow/pow_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
- webgl/conformance/ogles/GL/pow/pow_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
- webgl/conformance/ogles/GL/pow/pow_017_to_024-expected.txt: Added.
- webgl/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
- webgl/conformance/ogles/GL/radians/radians_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
- webgl/conformance/ogles/GL/reflect/reflect_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
- webgl/conformance/ogles/GL/refract/refract_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
- webgl/conformance/ogles/GL/sign/sign_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
- webgl/conformance/ogles/GL/sin/sin_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
- webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
- webgl/conformance/ogles/GL/step/step_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/step/step_001_to_006.html: Added.
- webgl/conformance/ogles/GL/struct/struct_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
- webgl/conformance/ogles/GL/struct/struct_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
- webgl/conformance/ogles/GL/struct/struct_017_to_024-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
- webgl/conformance/ogles/GL/struct/struct_025_to_032-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
- webgl/conformance/ogles/GL/struct/struct_033_to_040-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
- webgl/conformance/ogles/GL/struct/struct_041_to_048-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
- webgl/conformance/ogles/GL/struct/struct_049_to_056-expected.txt: Added.
- webgl/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120-expected.txt: Added.
- webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
- webgl/conformance/ogles/GL/tan/tan_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
- webgl/conformance/ogles/GL/vec/vec_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
- webgl/conformance/ogles/GL/vec/vec_009_to_016-expected.txt: Added.
- webgl/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
- webgl/conformance/ogles/GL/vec/vec_017_to_018-expected.txt: Added.
- webgl/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
- webgl/conformance/ogles/GL/vec3/vec3_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_001_to_004.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_001_to_004.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/array_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cross/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_001_to_001.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/discard/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_001_to_004.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/input.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/README.md: Added.
- webgl/resources/webgl_test_files/conformance/ogles/mustpass.run.txt: Added.
- webgl/resources/webgl_test_files/conformance/ogles/process-ogles2-tests.py: Added.
(Log):
(TransposeMatrix):
(GetValidTypeName):
(WriteOpen):
(TxtWriter):
(TxtWriter.init):
(TxtWriter.Write):
(TxtWriter.Close):
(ReadFileAsLines):
(ReadFile):
(Chunkify):
(GetText):
(GetElementText):
(GetBoolElement):
(GetModel):
(RelativizePaths):
(CopyFile):
(CopyShader):
(IsOneOf):
(CheckForUnknownTags):
(IsFileWeWant):
(TestReader):
(TestReader.to):
(TestReader.init):
(TestReader.Print):
(TestReader.MakeOutPath):
(TestReader.ReadTests):
(TestReader.ReadTest):
(TestReader.ProcessTest):
(TestReader.WriteTests):
(CopyShaders):
(Process_compare):
(Process_shaderload):
(Process_extension):
(Process_createtests):
(Process_GL2Test):
(Process_uniformquery):
(Process_egl_image_external):
(Process_dismount):
(Process_build):
(Process_coverage):
(Process_attributes):
(Process_fixed):
(main):
- 10:56 PM Changeset in webkit [142850] by
-
- 1 edit592 adds in trunk/LayoutTests
Add WebGL Conformance Tests glsl folder.
https://bugs.webkit.org/show_bug.cgi?id=109115
Reviewed by Kenneth Russell.
- webgl/conformance/glsl/functions/glsl-function-abs-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-abs.html: Added.
- webgl/conformance/glsl/functions/glsl-function-acos-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-acos.html: Added.
- webgl/conformance/glsl/functions/glsl-function-asin-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-asin.html: Added.
- webgl/conformance/glsl/functions/glsl-function-atan-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-atan-xy-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
- webgl/conformance/glsl/functions/glsl-function-atan.html: Added.
- webgl/conformance/glsl/functions/glsl-function-ceil-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-ceil.html: Added.
- webgl/conformance/glsl/functions/glsl-function-clamp-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-clamp-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
- webgl/conformance/glsl/functions/glsl-function-cos-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-cos.html: Added.
- webgl/conformance/glsl/functions/glsl-function-cross-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-cross.html: Added.
- webgl/conformance/glsl/functions/glsl-function-distance-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-distance.html: Added.
- webgl/conformance/glsl/functions/glsl-function-dot-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-dot.html: Added.
- webgl/conformance/glsl/functions/glsl-function-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-faceforward-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-faceforward.html: Added.
- webgl/conformance/glsl/functions/glsl-function-floor-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-floor.html: Added.
- webgl/conformance/glsl/functions/glsl-function-fract-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-fract.html: Added.
- webgl/conformance/glsl/functions/glsl-function-length-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-length.html: Added.
- webgl/conformance/glsl/functions/glsl-function-max-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-max-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-max-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
- webgl/conformance/glsl/functions/glsl-function-min-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-min-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-min-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
- webgl/conformance/glsl/functions/glsl-function-mix-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-mix-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-mix-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
- webgl/conformance/glsl/functions/glsl-function-mod-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-mod-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-mod-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
- webgl/conformance/glsl/functions/glsl-function-normalize-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-normalize.html: Added.
- webgl/conformance/glsl/functions/glsl-function-reflect-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-reflect.html: Added.
- webgl/conformance/glsl/functions/glsl-function-sign-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-sign.html: Added.
- webgl/conformance/glsl/functions/glsl-function-sin-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-sin.html: Added.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-step-float-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-step-float.html: Added.
- webgl/conformance/glsl/functions/glsl-function-step-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
- webgl/conformance/glsl/functions/glsl-function.html: Added.
- webgl/conformance/glsl/implicit/add_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/add_int_mat2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
- webgl/conformance/glsl/implicit/add_int_mat3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
- webgl/conformance/glsl/implicit/add_int_mat4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
- webgl/conformance/glsl/implicit/add_int_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/add_int_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/add_int_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/add_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/add_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/add_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/assign_int_to_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
- webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/construct_struct.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/construct_struct.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_mat2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_mat3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_mat4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_int_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/equal_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/equal_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/function_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/function_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/function_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/function_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/function_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/greater_than.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/greater_than.vert.html: Added.
- webgl/conformance/glsl/implicit/greater_than_equal.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
- webgl/conformance/glsl/implicit/less_than.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/less_than.vert.html: Added.
- webgl/conformance/glsl/implicit/less_than_equal.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/less_than_equal.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_mat2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_mat3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_mat4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_int_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/not_equal_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_mat2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_mat3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_mat4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_int_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/implicit/ternary_int_float.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
- webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
- webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
- webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert-expected.txt: Added.
- webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
- webgl/conformance/glsl/matrices/glsl-mat4-to-mat3-expected.txt: Added.
- webgl/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
- webgl/conformance/glsl/misc/attrib-location-length-limits-expected.txt: Added.
- webgl/conformance/glsl/misc/attrib-location-length-limits.html: Added.
- webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden-expected.txt: Added.
- webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
- webgl/conformance/glsl/misc/glsl-function-nodes-expected.txt: Added.
- webgl/conformance/glsl/misc/glsl-function-nodes.html: Added.
- webgl/conformance/glsl/misc/glsl-long-variable-names-expected.txt: Added.
- webgl/conformance/glsl/misc/glsl-long-variable-names.html: Added.
- webgl/conformance/glsl/misc/glsl-vertex-branch-expected.txt: Added.
- webgl/conformance/glsl/misc/glsl-vertex-branch.html: Added.
- webgl/conformance/glsl/misc/large-loop-compile-expected.txt: Added.
- webgl/conformance/glsl/misc/large-loop-compile.html: Added.
- webgl/conformance/glsl/misc/non-ascii-comments.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
- webgl/conformance/glsl/misc/non-ascii.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/non-ascii.vert.html: Added.
- webgl/conformance/glsl/misc/re-compile-re-link-expected.txt: Added.
- webgl/conformance/glsl/misc/re-compile-re-link.html: Added.
- webgl/conformance/glsl/misc/shader-with-256-character-define-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-256-character-define.html: Added.
- webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-257-character-define-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-257-character-define.html: Added.
- webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
- webgl/conformance/glsl/misc/shader-with-attrib-array.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-attrib-struct.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-clipvertex.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-comma-assignment-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
- webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
- webgl/conformance/glsl/misc/shader-with-conditional-scoping-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
- webgl/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
- webgl/conformance/glsl/misc/shader-with-default-precision.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-default-precision.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-dfdx.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-do-loop-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-do-loop.html: Added.
- webgl/conformance/glsl/misc/shader-with-error-directive-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-error-directive.html: Added.
- webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-float-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-for-loop-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-for-loop.html: Added.
- webgl/conformance/glsl/misc/shader-with-for-scoping-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-for-scoping.html: Added.
- webgl/conformance/glsl/misc/shader-with-frag-depth.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-function-recursion.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-function-scoped-struct-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
- webgl/conformance/glsl/misc/shader-with-functional-scoping-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
- webgl/conformance/glsl/misc/shader-with-glcolor.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-gles-1.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-gles-symbol.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
- webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-include.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-include.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-int-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-limited-indexing.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-long-line-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-long-line.html: Added.
- webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-precision.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-precision.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-quoted-error.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-reserved-words-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-reserved-words.html: Added.
- webgl/conformance/glsl/misc/shader-with-too-many-uniforms-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
- webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
- webgl/conformance/glsl/misc/shader-with-version-100.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
- webgl/conformance/glsl/misc/shader-with-version-100.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-version-120.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-version-130.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
- webgl/conformance/glsl/misc/shader-with-while-loop-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-while-loop.html: Added.
- webgl/conformance/glsl/misc/shader-without-precision.frag-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-without-precision.frag.html: Added.
- webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms-expected.txt: Added.
- webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
- webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings-expected.txt: Added.
- webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
- webgl/conformance/glsl/misc/shaders-with-missing-varyings-expected.txt: Added.
- webgl/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
- webgl/conformance/glsl/misc/shared-expected.txt: Added.
- webgl/conformance/glsl/misc/shared.html: Added.
- webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum-expected.txt: Added.
- webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
- webgl/conformance/glsl/misc/struct-nesting-under-maximum-expected.txt: Added.
- webgl/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
- webgl/conformance/glsl/misc/uniform-location-length-limits-expected.txt: Added.
- webgl/conformance/glsl/misc/uniform-location-length-limits.html: Added.
- webgl/conformance/glsl/reserved/_webgl_field.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/_webgl_field.vert.html: Added.
- webgl/conformance/glsl/reserved/_webgl_function.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/_webgl_function.vert.html: Added.
- webgl/conformance/glsl/reserved/_webgl_struct.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
- webgl/conformance/glsl/reserved/_webgl_variable.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
- webgl/conformance/glsl/reserved/webgl_field.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/webgl_field.vert.html: Added.
- webgl/conformance/glsl/reserved/webgl_function.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/webgl_function.vert.html: Added.
- webgl/conformance/glsl/reserved/webgl_preprocessor_reserved-expected.txt: Added.
- webgl/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
- webgl/conformance/glsl/reserved/webgl_struct.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/webgl_struct.vert.html: Added.
- webgl/conformance/glsl/reserved/webgl_variable.vert-expected.txt: Added.
- webgl/conformance/glsl/reserved/webgl_variable.vert.html: Added.
- webgl/conformance/glsl/samplers/glsl-function-texture2d-bias-expected.txt: Added.
- webgl/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
- webgl/conformance/glsl/samplers/glsl-function-texture2dlod-expected.txt: Added.
- webgl/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
- webgl/conformance/glsl/samplers/glsl-function-texture2dproj-expected.txt: Added.
- webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
- webgl/conformance/glsl/variables/gl-fragcoord-expected.txt: Added.
- webgl/conformance/glsl/variables/gl-fragcoord.html: Added.
- webgl/conformance/glsl/variables/gl-frontfacing-expected.txt: Added.
- webgl/conformance/glsl/variables/gl-frontfacing.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-abs.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-acos.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-asin.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-ceil.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cos.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cross.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-distance.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-dot.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-faceforward.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-floor.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-fract.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-length.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-lessThan.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-normalize.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-reflect.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-refract.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sign.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sin.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-float.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/construct_struct.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/function_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than_equal.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/literals/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/matrices/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/attrib-location-length-limits.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/foo: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-2types-of-textures-on-same-unit.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-function-nodes.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-long-variable-names.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-vertex-branch.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/include.vs: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/large-loop-compile.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/re-compile-re-link.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-define.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-define.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-do-loop.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-error-directive.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-loop.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-scoping.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-include.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-long-line.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-precision.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-reserved-words.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-while-loop.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-without-precision.frag.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shared.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/uniform-location-length-limits.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_field.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_function.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_field.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_function.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_struct.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_variable.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/samplers/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/variables/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/glsl/variables/gl-fragcoord.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/variables/gl-frontfacing.html: Added.
- 10:17 PM Changeset in webkit [142849] by
-
- 45 edits in trunk/Source/WebCore
[V8] Generate wrapper methods for custom methods
https://bugs.webkit.org/show_bug.cgi?id=109678
Reviewed by Adam Barth.
Currently V8 directly calls back custom methods written
in custom binding files. This makes it impossible for code
generators to hook custom methods (e.g. Code generators cannot
insert a code for FeatureObservation into custom methods).
To solve the problem, we should generate wrapper methods for
custom methods.
No tests. No change in behavior.
- page/DOMWindow.idl: Removed overloaded methods. The fact that methods in an IDL
file are overloaded but they are not overloaded in custom bindings confuses code
generators. (For some reason, this problem hasn't appeared before this change.)
- xml/XMLHttpRequest.idl: Ditto.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateEventListenerCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalMethod3Callback):
(TestInterfaceV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::customMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customMethodWithArgsCallback):
(WebCore::TestObjV8Internal::classMethod2Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::clearDataCallbackCustom):
(WebCore::V8Clipboard::setDragImageCallbackCustom):
- bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::traceCallbackCustom):
(WebCore::V8Console::assertCallbackCustom):
(WebCore::V8Console::profileCallbackCustom):
(WebCore::V8Console::profileEndCallbackCustom):
- bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesCallbackCustom):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::appendCallbackCustom):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallbackCustom):
(WebCore::V8DOMWindow::removeEventListenerCallbackCustom):
(WebCore::V8DOMWindow::postMessageCallbackCustom):
(WebCore::V8DOMWindow::toStringCallbackCustom):
(WebCore::V8DOMWindow::releaseEventsCallbackCustom):
(WebCore::V8DOMWindow::captureEventsCallbackCustom):
(WebCore::V8DOMWindow::showModalDialogCallbackCustom):
(WebCore::V8DOMWindow::openCallbackCustom):
(WebCore::V8DOMWindow::setTimeoutCallbackCustom):
(WebCore::V8DOMWindow::setIntervalCallbackCustom):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8CallbackCustom):
(WebCore::V8DataView::getUint8CallbackCustom):
(WebCore::V8DataView::setInt8CallbackCustom):
(WebCore::V8DataView::setUint8CallbackCustom):
- bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageCallbackCustom):
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallbackCustom):
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallbackCustom):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallbackCustom):
(WebCore::V8Document::createTouchListCallbackCustom):
- bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallbackCustom):
(WebCore::V8Geolocation::watchPositionCallbackCustom):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::V8HTMLAllCollection::itemCallbackCustom):
(WebCore::V8HTMLAllCollection::namedItemCallbackCustom):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallbackCustom):
(WebCore::V8HTMLCanvasElement::toDataURLCallbackCustom):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::writeCallbackCustom):
(WebCore::V8HTMLDocument::writelnCallbackCustom):
(WebCore::V8HTMLDocument::openCallbackCustom):
- bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore::V8HTMLFormControlsCollection::namedItemCallbackCustom):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallbackCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::setSelectionRangeCallbackCustom):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::namedItemCallbackCustom):
(WebCore::V8HTMLOptionsCollection::removeCallbackCustom):
(WebCore::V8HTMLOptionsCollection::addCallbackCustom):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::removeCallbackCustom):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallbackCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameCallbackCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallbackCustom):
(WebCore::V8InjectedScriptHost::typeCallbackCustom):
(WebCore::V8InjectedScriptHost::functionDetailsCallbackCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesCallbackCustom):
(WebCore::V8InjectedScriptHost::getEventListenersCallbackCustom):
(WebCore::V8InjectedScriptHost::inspectCallbackCustom):
(WebCore::V8InjectedScriptHost::databaseIdCallbackCustom):
(WebCore::V8InjectedScriptHost::storageIdCallbackCustom):
(WebCore::V8InjectedScriptHost::evaluateCallbackCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallbackCustom):
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallbackCustom):
(WebCore::V8InspectorFrontendHost::portCallbackCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallbackCustom):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::evaluateCallbackCustom):
(WebCore::V8JavaScriptCallFrame::restartCallbackCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueCallbackCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeCallbackCustom):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::reloadCallbackCustom):
(WebCore::V8Location::replaceCallbackCustom):
(WebCore::V8Location::assignCallbackCustom):
(WebCore::V8Location::valueOfCallbackCustom):
(WebCore::V8Location::toStringCallbackCustom):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallbackCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventCallbackCustom):
- bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::V8MessagePort::postMessageCallbackCustom):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallbackCustom):
(WebCore::V8Node::replaceChildCallbackCustom):
(WebCore::V8Node::removeChildCallbackCustom):
(WebCore::V8Node::appendChildCallbackCustom):
- bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::requestPermissionCallbackCustom):
- bindings/v8/custom/V8NotificationCustom.cpp:
(WebCore::V8Notification::requestPermissionCallbackCustom):
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallbackCustom):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallbackCustom):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallbackCustom):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallbackCustom):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallbackCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getExtensionCallbackCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallbackCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getUniformCallbackCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvCallbackCustom):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallbackCustom):
(WebCore::V8WorkerContext::setTimeoutCallbackCustom):
(WebCore::V8WorkerContext::setIntervalCallbackCustom):
- bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::V8Worker::postMessageCallbackCustom):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openCallbackCustom):
(WebCore::V8XMLHttpRequest::sendCallbackCustom):
- bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::setParameterCallbackCustom):
(WebCore::V8XSLTProcessor::getParameterCallbackCustom):
(WebCore::V8XSLTProcessor::removeParameterCallbackCustom):
- 10:04 PM Changeset in webkit [142848] by
-
- 8 edits in trunk
JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
https://bugs.webkit.org/show_bug.cgi?id=109542
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.
Source/WebCore:
"JSGenerateToJSObject" should be included in IDL files
of ChannelSplitterNode and ChannelMergerNode in WebAudio.
This ensures html files to access corresponding objects.
- Modules/webaudio/ChannelMergerNode.idl:
- Modules/webaudio/ChannelSplitterNode.idl:
LayoutTests:
Test cases updated to check validity of ChannelSplitterNode
and ChannelMergerNode Objects.
- webaudio/audiochannelmerger-basic-expected.txt:
- webaudio/audiochannelmerger-basic.html:
- webaudio/audiochannelsplitter-expected.txt:
- webaudio/audiochannelsplitter.html:
- 9:49 PM Changeset in webkit [142847] by
-
- 3 edits249 adds in trunk/LayoutTests
Adds failing WebGL Conformance Tests.
https://bugs.webkit.org/show_bug.cgi?id=109075
Reviewed by Kenneth Russell.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Added.
- webgl/conformance/canvas/buffer-offscreen-test.html: Added.
- webgl/conformance/canvas/buffer-preserve-test-expected.txt: Added.
- webgl/conformance/canvas/buffer-preserve-test.html: Added.
- webgl/conformance/canvas/drawingbuffer-test-expected.txt: Added.
- webgl/conformance/canvas/drawingbuffer-test.html: Added.
- webgl/conformance/canvas/to-data-url-test-expected.txt: Added.
- webgl/conformance/canvas/to-data-url-test.html: Added.
- webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Added.
- webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
- webgl/conformance/context/context-creation-and-destruction-expected.txt: Added.
- webgl/conformance/context/context-creation-and-destruction.html: Added.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
- webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Added.
- webgl/conformance/glsl/literals/float_literal.vert.html: Added.
- webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
- webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
- webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
- webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
- webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
- webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
- webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Added.
- webgl/conformance/glsl/misc/shaders-with-varyings.html: Added.
- webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Added.
- webgl/conformance/glsl/variables/gl-pointcoord.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-A.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B1.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B2.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B3.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B4.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-C.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
- webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/bufferDataBadArgs.html: Added.
- webgl/conformance/more/functions/copyTexImage2D-expected.txt: Added.
- webgl/conformance/more/functions/copyTexImage2D.html: Added.
- webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Added.
- webgl/conformance/more/functions/copyTexSubImage2D.html: Added.
- webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/deleteBufferBadArgs.html: Added.
- webgl/conformance/more/functions/drawArrays-expected.txt: Added.
- webgl/conformance/more/functions/drawArrays.html: Added.
- webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Added.
- webgl/conformance/more/functions/drawArraysOutOfBounds.html: Added.
- webgl/conformance/more/functions/drawElements-expected.txt: Added.
- webgl/conformance/more/functions/drawElements.html: Added.
- webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/drawElementsBadArgs.html: Added.
- webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/readPixelsBadArgs.html: Added.
- webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/texImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/texImage2DHTML-expected.txt: Added.
- webgl/conformance/more/functions/texImage2DHTML.html: Added.
- webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/texSubImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
- webgl/conformance/more/functions/texSubImage2DHTML.html: Added.
- webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
- webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
- webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
- webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
- webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/log/log_001_to_008.html: Added.
- webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
- webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
- webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Added.
- webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
- webgl/conformance/programs/program-test-expected.txt: Added.
- webgl/conformance/programs/program-test.html: Added.
- webgl/conformance/reading/read-pixels-test-expected.txt: Added.
- webgl/conformance/reading/read-pixels-test.html: Added.
- webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
- webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
- webgl/conformance/rendering/gl-scissor-test-expected.txt: Added.
- webgl/conformance/rendering/gl-scissor-test.html: Added.
- webgl/conformance/rendering/more-than-65536-indices-expected.txt: Added.
- webgl/conformance/rendering/more-than-65536-indices.html: Added.
- webgl/conformance/rendering/multisample-corruption-expected.txt: Added.
- webgl/conformance/rendering/multisample-corruption.html: Added.
- webgl/conformance/rendering/point-size-expected.txt: Added.
- webgl/conformance/rendering/point-size.html: Added.
- webgl/conformance/state/gl-object-get-calls-expected.txt: Added.
- webgl/conformance/state/gl-object-get-calls.html: Added.
- webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
- webgl/conformance/textures/copy-tex-image-2d-formats.html: Added.
- webgl/conformance/textures/gl-pixelstorei-expected.txt: Added.
- webgl/conformance/textures/gl-pixelstorei.html: Added.
- webgl/conformance/textures/origin-clean-conformance-expected.txt: Added.
- webgl/conformance/textures/origin-clean-conformance.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
- webgl/conformance/textures/texture-active-bind-2-expected.txt: Added.
- webgl/conformance/textures/texture-active-bind-2.html: Added.
- webgl/conformance/textures/texture-active-bind-expected.txt: Added.
- webgl/conformance/textures/texture-active-bind.html: Added.
- webgl/conformance/textures/texture-mips-expected.txt: Added.
- webgl/conformance/textures/texture-mips.html: Added.
- webgl/conformance/textures/texture-npot-video-expected.txt: Added.
- webgl/conformance/textures/texture-npot-video.html: Added.
- webgl/conformance/textures/texture-size-expected.txt: Added.
- webgl/conformance/textures/texture-size-limit-expected.txt: Added.
- webgl/conformance/textures/texture-size-limit.html: Added.
- webgl/conformance/textures/texture-size.html: Added.
- webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Added.
- webgl/conformance/uniforms/gl-uniform-arrays.html: Added.
- webgl/conformance/uniforms/uniform-default-values-expected.txt: Added.
- webgl/conformance/uniforms/uniform-default-values.html: Added.
- webgl/conformance/uniforms/uniform-location-expected.txt: Added.
- webgl/conformance/uniforms/uniform-location.html: Added.
- webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Added.
- webgl/conformance/uniforms/uniform-samplers-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/program-test.html: Added.
- webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Added.
- webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Added.
- 8:17 PM Changeset in webkit [142846] by
-
- 4 edits in trunk/Source/WebCore
[Regression] After r142831 collection-null-like-arguments.html layout test failing
https://bugs.webkit.org/show_bug.cgi?id=109780
Reviewed by Kentaro Hara.
No new tests. LayoutTests/fast/dom/collection-null-like-arguments.html
Should pass now.
- bindings/js/JSHTMLAllCollectionCustom.cpp: Return null for namedItem() only.
(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::namedItem):
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.
(WebCore::getNamedItems):
(WebCore::JSHTMLFormControlsCollection::namedItem):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.
(WebCore::getNamedItems):
(WebCore::JSHTMLOptionsCollection::namedItem):
- 7:45 PM Changeset in webkit [142845] by
-
- 2 edits in trunk/Source/WebCore
Fix indentation error in MediaPlayerPrivateGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=109768
Patch by Soo-Hyun Choi <sh9.choi@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.
No new tests as this patch just changes indentation style.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::hasVideo):
(WebCore::MediaPlayerPrivateGStreamer::hasAudio):
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):
- 7:44 PM Changeset in webkit [142844] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=109779
Rebaseline http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html
on Linux after r142683.
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13
- platform/chromium-linux/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
- 7:31 PM Changeset in webkit [142843] by
-
- 3 edits in trunk/Source/WebCore
TokenPreloadScanner should be (mostly!) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109760
Reviewed by Eric Seidel.
This patch makes the bulk of TokenPreloadScanner thread-safe. The one
remaining wart is processPossibleBaseTag because it wants to grub
around in the base tag's attributes. I have a plan for that, but it's
going to need to wait for the next patch.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(WebCore):
- 6:36 PM Changeset in webkit [142842] by
-
- 2 edits1 add in trunk/Tools
Unreviewed. Add separate DumpRenderTree VS2010 solution file.
- DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
- 6:30 PM Changeset in webkit [142841] by
-
- 6 edits in trunk
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebUnitTestSupport.h:
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):
- 6:16 PM Changeset in webkit [142840] by
-
- 2 edits in trunk/Source/WebCore
StartTagScanner should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109750
Reviewed by Eric Seidel.
This patch weens the StartTagScanner off AtomicString using two
techniques:
1) This patch creates an enum to represent the four tag names that the
StartTagScanner needs to understand. Using an enum is better than
using an AtomicString because we can use the enum on both the main
thread and on the background thread.
2) For attributes, this patch uses threadSafeMatch. We're not able to
use threadSafeMatch everywhere due to performance, but using it for
attributes appears to be ok becaues we only call threadSafeMatch on
the attributes of "interesting" tags.
I tested the performance of this patch using
PerformanceTests/Parser/html-parser.html and did not see any slowdown.
(There actually appeared to be a <1% speedup, but I'm attributing that
to noise.)
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::identifierFor):
(WebCore):
(WebCore::inititatorFor):
(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(StartTagScanner):
(WebCore::StartTagScanner::createPreloadRequest):
(WebCore::StartTagScanner::processAttribute):
(WebCore::StartTagScanner::charset):
(WebCore::StartTagScanner::resourceType):
(WebCore::StartTagScanner::shouldPreload):
(WebCore::HTMLPreloadScanner::processToken):
- 6:11 PM Changeset in webkit [142839] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Remove StringPairVector
https://bugs.webkit.org/show_bug.cgi?id=109778
Reviewed by Ryosuke Niwa.
Our message generation scripts can handle nested template parameter types now,
so we no longer need to use StringPairVector.
- Shared/StringPairVector.h: Removed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::willSubmitForm):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
- 5:58 PM Changeset in webkit [142838] by
-
- 2 edits in trunk/Source/JavaScriptCore
Better build fix.
- API/tests/testapi.c:
(assertEqualsAsNumber):
(main):
- 5:57 PM EnableFormFeatures edited by
- (diff)
- 5:56 PM Changeset in webkit [142837] by
-
- 4 edits in trunk/Source/WebCore
Coordinated Graphics: a long page is scaled vertically while loading.
https://bugs.webkit.org/show_bug.cgi?id=109645
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-13
Reviewed by Noam Rosenthal.
When loading http://www.w3.org/TR/xpath-datamodel/, Coordinated Graphics draws
vertically scaled contents. It is because there is the difference between the
size of a layer and the size of CoordinatedBackingStore.
Currently, CoordinatedGraphicsScene notifies the size to CoordinatedBackingStore
at the moment of creating, updating and removing a tile. However, it is not
necessary to send tile-related messages when the size of layer is changed.
So this patch resets the size of CoordinatedBackingStore when receiving the
message that is created when the size is changed: SyncLayerState.
There is no current way to reliably test flicker issues.
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Add m_pendingSize to set m_size at the moment of flushing. After http://webkit.org/b/108294, m_pendingSize will be removed because the bug makes CoordinatedGraphicsScene execute all messages at the moment of flushing.
(WebCore::CoordinatedBackingStore::setSize):
(WebCore::CoordinatedBackingStore::commitTileOperations):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
(CoordinatedBackingStore):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTile):
(WebCore::CoordinatedGraphicsScene::removeTile):
(WebCore::CoordinatedGraphicsScene::updateTile):
- 5:50 PM Changeset in webkit [142836] by
-
- 2 edits in trunk/Source/WebKit2
PlugIn Autostart should expire in 30 days, not half a day
https://bugs.webkit.org/show_bug.cgi?id=109767
Reviewed by Brian Weinstein.
We forgot to multiply by 60 seconds in a minute.
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
- 5:49 PM Changeset in webkit [142835] by
-
- 4 edits in trunk/Source/WebKit2
Message generation should handle nested templates
https://bugs.webkit.org/show_bug.cgi?id=109771
Reviewed by Ryosuke Niwa.
Make it possible to have nested class template types as message parameters and
correctly gather all the needed headers and argument coder headers.
- Scripts/webkit2/messages.py:
(class_template_headers):
Recursively figure out the types and template headers needed for a given type.
(argument_coder_headers_for_type):
(headers_for_type):
Call class_template_headers.
- Scripts/webkit2/messages_unittest.py:
(CoreIPC):
- Scripts/webkit2/parser.py:
(split_parameters_string):
(parse_parameters_string):
- 5:48 PM EnableFormFeatures edited by
- (diff)
- 5:43 PM Changeset in webkit [142834] by
-
- 35 edits in trunk/Source/WebCore
[V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(),
and XXXAccessorSetter() to XXXAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=109679
Reviewed by Adam Barth.
For naming consistency and clarification.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateHeaderCustomCall):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::customAttrAttrGetter):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):
- bindings/v8/custom/V8BiquadFilterNodeCustom.cpp:
(WebCore::V8BiquadFilterNode::typeAttrSetterCustom):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrSetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrSetterCustom):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAttrGetterCustom):
- bindings/v8/custom/V8CoordinatesCustom.cpp:
(WebCore::V8Coordinates::altitudeAttrGetterCustom):
(WebCore::V8Coordinates::altitudeAccuracyAttrGetterCustom):
(WebCore::V8Coordinates::headingAttrGetterCustom):
(WebCore::V8Coordinates::speedAttrGetterCustom):
- bindings/v8/custom/V8CustomEventCustom.cpp:
(WebCore::V8CustomEvent::detailAttrGetterCustom):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::locationAttrSetterCustom):
(WebCore::V8DOMWindow::openerAttrSetterCustom):
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
(WebCore::V8DeviceMotionEvent::accelerationAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::rotationRateAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::intervalAttrGetterCustom):
- bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::alphaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::betaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::gammaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::absoluteAttrGetterCustom):
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAttrGetterCustom):
(WebCore::V8Document::locationAttrSetterCustom):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAttrGetterCustom):
(WebCore::V8Event::clipboardDataAttrGetterCustom):
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAttrGetterCustom):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::allAttrSetterCustom):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAttrGetterCustom):
(WebCore::V8HTMLElement::itemValueAttrSetterCustom):
- bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
(WebCore::V8HTMLFrameElement::locationAttrSetterCustom):
- bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionStartAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrSetterCustom):
- bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAttrGetterCustom):
(WebCore::V8HTMLLinkElement::sizesAttrSetterCustom):
- bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAttrSetterCustom):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAttrGetterCustom):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::scopeChainAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::thisObjectAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::typeAttrGetterCustom):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::hashAttrSetterCustom):
(WebCore::V8Location::hostAttrSetterCustom):
(WebCore::V8Location::hostnameAttrSetterCustom):
(WebCore::V8Location::hrefAttrSetterCustom):
(WebCore::V8Location::pathnameAttrSetterCustom):
(WebCore::V8Location::portAttrSetterCustom):
(WebCore::V8Location::protocolAttrSetterCustom):
(WebCore::V8Location::searchAttrSetterCustom):
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):
(WebCore::V8MessageEvent::portsAttrGetterCustom):
- bindings/v8/custom/V8OscillatorNodeCustom.cpp:
(WebCore::V8OscillatorNode::typeAttrSetterCustom):
- bindings/v8/custom/V8PannerNodeCustom.cpp:
(WebCore::V8PannerNode::panningModelAttrSetterCustom):
(WebCore::V8PannerNode::distanceModelAttrSetterCustom):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAttrGetterCustom):
- bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAttrGetterCustom):
(WebCore::V8SVGLength::valueAttrSetterCustom):
- bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAttrGetterCustom):
- bindings/v8/custom/V8WebKitAnimationCustom.cpp:
(WebCore::V8WebKitAnimation::iterationCountAttrGetterCustom):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAttrGetterCustom):
(WebCore::V8XMLHttpRequest::responseAttrGetterCustom):
- 5:35 PM Changeset in webkit [142833] by
-
- 4 edits in trunk/Source/WebCore
[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666
Reviewed by Adam Barth.
Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). To solve the problem,
we should generate wrapper methods for custom getters/setters.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):
- 5:32 PM Changeset in webkit [142832] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix.
- API/tests/testapi.c:
(assertEqualsAsNumber):
(main):
- 5:31 PM Changeset in webkit [142831] by
-
- 10 edits2 adds in trunk
HTMLCollections namedItem() methods should return null than undefined for empty collections.
https://bugs.webkit.org/show_bug.cgi?id=104096
Reviewed by Kentaro Hara.
As per specification namedItem() should return null if collection is empty.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection
Source/WebCore:
Test: fast/dom/htmlcollection-namedItem.html
- bindings/js/JSHTMLAllCollectionCustom.cpp: Returning null.
(WebCore::getNamedItems):
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.
(WebCore::getNamedItems):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.
(WebCore::getNamedItems):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: Ditto.
(WebCore::V8HTMLAllCollection::namedItemCallback):
- bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp: Ditto.
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Ditto.
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
LayoutTests:
- fast/dom/HTMLFormElement/move-option-between-documents-expected.txt:
- fast/dom/HTMLFormElement/move-option-between-documents.html:
- fast/dom/htmlcollection-namedItem-expected.txt: Added.
- fast/dom/htmlcollection-namedItem.html: Added.
- 5:31 PM Changeset in webkit [142830] by
-
- 2 edits in trunk/Source/WebKit2
Make WebKit2 Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109763
Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.
- WebKit2.xcodeproj/project.pbxproj: Pass SDKROOT=${SDKROOT} to DerivedSources.make
- 5:25 PM Changeset in webkit [142829] by
-
- 7 edits in trunk
Fix svg/in-html/script-write.html with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109495
Reviewed by Eric Seidel.
Source/WebCore:
This patch makes the background parser's simulateTreeBuilder() more realistic.
- The HTMLTreeBuilder does not call the updateStateFor() setState()s when in foreign content mode so we shouldn't do it when simulating the tree builder.
- HTMLTreeBuilder::processTokenInForeignContent has a list of tags which exit foreign content mode. We need to respect those.
- Support the <foreignObject> tag which enters and leaves foreign content mode.
- The tree builder sets state to DataState upon a </script> tag when not in foreign content mode. We need to do the same.
This involved creating a namespace stack where we push upon entering each namespace and pop upon leaving.
We are in foreign content if the topmost namespace is SVG or MathML.
This fixes svg/in-html/script-write.html and likely others.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::getAttributeItem): Returns the attribute of the given name. Necessary to test for <font> attributes in simulateTreeBuilder.
(WebCore):
- html/parser/CompactHTMLToken.h:
(WebCore):
(CompactHTMLToken):
LayoutTests:
Added 3 new test cases:
- Test the behavior of a plaintext tag inside an svg foreignObject. It applies to the remainder of the document. This behavior seems a little wonky, but it matches our current behavior and Firefox's behavior.
- Test that we don't blindly go into HTML mode after </foreignObject>.
- Test that unmatched </foreignObject>s are ignored.
- html5lib/resources/webkit02.dat:
- 5:17 PM Changeset in webkit [142828] by
-
- 2 edits in trunk/Tools
TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
https://bugs.webkit.org/show_bug.cgi?id=109766
Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.
- TestWebKitAPI/Configurations/Base.xcconfig:
- Don't search Mac OS X header search paths when building on iOS
- 5:11 PM Changeset in webkit [142827] by
-
- 6 edits in trunk/Source/WebCore
Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
<http://webkit.org/b/109756>
Reviewed by Antti Koivisto.
Remove this to prevent callers from accidentally causing elements to convert to UniqueElementData.
There are two call sites (Attr and HTMLSelectElement) that legitimately need to mutate Attribute
objects in-place, they now use Element::ensureUniqueElementData()->getAttributeItem() directly instead.
Small progression on Membuster3, mostly for peace of mind.
- dom/Attr.cpp:
(WebCore::Attr::elementAttribute):
- dom/Element.h:
(Element):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 5:07 PM Changeset in webkit [142826] by
-
- 6 edits in trunk/Source/WebCore
Stronger ElementData pointer typing.
<http://webkit.org/b/109752>
Reviewed by Antti Koivisto.
Use ShareableElementData/UniqueElementData pointers instead of generic ElementData pointers
where possible. Moved some methods from base class into leaf classes that don't make sense
for both classes.
- dom/DocumentSharedObjectPool.cpp:
(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
- dom/DocumentSharedObjectPool.h:
(DocumentSharedObjectPool):
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::ShareableElementData::createWithAttributes):
(WebCore::UniqueElementData::create):
(WebCore::ElementData::makeUniqueCopy):
(WebCore::UniqueElementData::makeShareableCopy):
- dom/Element.h:
(ElementData):
(ShareableElementData):
(UniqueElementData):
(Element):
(WebCore::Element::ensureUniqueElementData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- 5:03 PM Changeset in webkit [142825] by
-
- 2 edits in trunk/Source/WebCore
Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765
Reviewed by Andreas Kling and Anders Carlsson.
Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.
- platform/mac/SharedTimerMac.mm:
(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::sharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- 5:02 PM Changeset in webkit [142824] by
-
- 6 edits2 adds in trunk
getComputedStyle returns truncated value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=109759
Source/WebCore:
Reviewed by Tony Chang.
Due to an unfortunate cast in CSSComputedStyleDeclaration::
getPropertyCSSValue getComputedStyle returns truncated styles
for margin-right in cases where it isn't set to a specific pixel
value.
Test: fast/sub-pixel/computedstylemargin.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Change type of temporary value variable to float to prevent loss of precision.
LayoutTests:
Reviewed by Tony Chang.
Add test for getComputedStyle with fractional margin values.
- fast/sub-pixel/computedstylemargin-expected.txt: Added.
- fast/sub-pixel/computedstylemargin.html: Added.
- 4:59 PM Changeset in webkit [142823] by
-
- 14 edits1 add in trunk/Source
[CSS Filters] Refactor filter outsets into a class
https://bugs.webkit.org/show_bug.cgi?id=109330
Source/WebCore:
Reviewed by Dean Jackson.
In filters related code, we're often operating on 4 ints representing the top, right,
bottom, and left filter outsets. These outsets come from a filter like blur or drop-shadow.
This patch packages those ints and their related operations into a class called
IntRectExtent.
Here are some signs that we should make a class to hold those 4 ints:
1) In RenderLayer.cpp, we have a expandRectForFilterOutsets function, which looks like
feature envy.
2) RenderStyle and other classes have methods like getFilterOutsets which set the 4 ints by
reference. The calling code has to define 4 ints, which looks bloated.
3) To fix bug 109098, we will need to check if filter outsets changed, which sounds like a
nice job for an inequality operator. (https://bugs.webkit.org/show_bug.cgi?id=109098)
No new tests. No change in behavior. Just refactoring.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/IntRectExtent.h: Added.
(WebCore):
(IntRectExtent):
(WebCore::IntRectExtent::IntRectExtent):
(WebCore::IntRectExtent::top):
(WebCore::IntRectExtent::setTop):
(WebCore::IntRectExtent::right):
(WebCore::IntRectExtent::setRight):
(WebCore::IntRectExtent::bottom):
(WebCore::IntRectExtent::setBottom):
(WebCore::IntRectExtent::left):
(WebCore::IntRectExtent::setLeft):
(WebCore::IntRectExtent::expandRect):
(WebCore::IntRectExtent::isZero):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::operator+=):
- platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::outsets):
- platform/graphics/filters/FilterOperations.h:
(FilterOperations):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
- rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::calculateLayerBounds):
- rendering/style/RenderStyle.h:
Source/WebKit/chromium:
Update FilterOperations unit tests to use new interface for getting filter outsets.
Reviewed by Dean Jackson.
- tests/FilterOperationsTest.cpp:
(WebKit::TEST):
- 4:56 PM Changeset in webkit [142822] by
-
- 3 edits in trunk/Source/WebCore
Factor HTMLTokenScanner out of HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109754
Reviewed by Eric Seidel.
This patch is just a mechanical separation of the per-token "scanning"
logic from HTMLPreloadScanner into a separate class.
HTMLPreloadScanner's job is now to keep track of the input stream and
to pump the tokenizer.
This factorization class will let us use HTMLTokenScanner on the
background thread (once we finish making it thread-safe). In a follow
up patch, I'll move HTMLTokenScanner to its own file.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLTokenScanner::HTMLTokenScanner):
(WebCore::HTMLTokenScanner::~HTMLTokenScanner):
(WebCore::HTMLTokenScanner::processPossibleTemplateTag):
(WebCore::HTMLTokenScanner::processPossibleStyleTag):
(WebCore::HTMLTokenScanner::processPossibleBaseTag):
(WebCore::HTMLTokenScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore):
(WebCore::HTMLPreloadScanner::~HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::appendToEnd):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
(HTMLTokenScanner):
(WebCore::HTMLTokenScanner::setPredictedBaseElementURL):
(HTMLPreloadScanner):
(WebCore):
- 4:37 PM Changeset in webkit [142821] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r125794) - inline-children-root-linebox-crash asserts in Chromium debug
https://bugs.webkit.org/show_bug.cgi?id=94256
Unreviewed test expectations update. Re-enabling inline-children-root-linebox-crash
as it was fixed by r139479.
- platform/chromium/TestExpectations:
- 4:12 PM Changeset in webkit [142820] by
-
- 7 edits2 adds in trunk
ASSERT(!renderer()->needsLayout()) when calling Element::focus() with generated content
https://bugs.webkit.org/show_bug.cgi?id=109616
Reviewed by Julien Chaffraix.
Source/WebCore:
Test: fast/css-generated-content/quote-layout-focus-crash.html
In some cases RenderQuote may mark itself and containing blocks as needing layout
during a layout, but then one of it's containing blocks will mark itself as having
finished layout so the RenderQuote and potentially some of it's ancestor renderers
needLayout(), but the ancestors above those do not.
Until we have proper pre-layout tasks we should just walk the list of quotes
right before layout and mark all their ancestors as needing layout if the quote
needs layout.
- dom/Document.cpp:
(WebCore::Document::updateLayout): Call markQuoteContainingBlocksForLayoutIfNeeded.
(WebCore::Document::implicitClose): Call markQuoteContainingBlocksForLayoutIfNeeded.
- rendering/RenderQuote.h:
(WebCore::RenderQuote::next): Added.
- rendering/RenderView.cpp:
(WebCore::RenderView::markQuoteContainingBlocksForLayoutIfNeeded): Added.
- rendering/RenderView.h:
(RenderView):
LayoutTests:
- fast/block/float/float-not-removed-from-pre-block-expected.txt: Changed output.
- fast/css-generated-content/quote-layout-focus-crash-expected.txt: Added.
- fast/css-generated-content/quote-layout-focus-crash.html: Added.
- 4:02 PM Changeset in webkit [142819] by
-
- 5 edits in trunk/Source/WebCore
EME: MediaPlayer::keyNeede() should return a bool indicating whether an event listener was triggered.
https://bugs.webkit.org/show_bug.cgi?id=109701
Reviewed by Eric Carlson.
Clients of MediaPlayer may need to do cleanup if calling keyNeeded()
results in no event listener being triggered. Return a bool (like the
v1 equivalent keyNeeded method) to indicate this.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyNeeded):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):
- 3:57 PM Changeset in webkit [142818] by
-
- 3 edits in trunk
Try once again to fix the build after r142756
- Source/autotools/PrintBuildConfiguration.m4: Do not try to print the GStreamer version
in the build output.
- Source/autotools/SetupAutoconfHeader.m4: Remove the last reference to have_gstreamer.
- 3:53 PM Changeset in webkit [142817] by
-
- 2 edits in trunk/Source/WebKit2
One more buildfix for !ENABLE(PLUGIN_PROCESS) platforms.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- 3:44 PM Changeset in webkit [142816] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: !object object->isBox(), Bad cast in RenderBox::computeLogicalHeight https://bugs.webkit.org/show_bug.cgi?id=107748
Reviewed by Levi Weintraub.
Source/WebCore:
Make sure that body renderer is not an inline-block display
when determining that it stretches to viewport or when paginated
content needs base height.
Test: fast/block/body-inline-block-crash.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
- rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport):
LayoutTests:
- fast/block/body-inline-block-crash-expected.txt: Added.
- fast/block/body-inline-block-crash.html: Added.
- 3:43 PM Changeset in webkit [142815] by
-
- 2 edits in trunk/Source/WebCore
Fix debug assertion being triggered because we may access dirty normalFlowList.
https://bugs.webkit.org/show_bug.cgi?id=109740
A debug assertion in RenderLayer.h is being hit when trying to
access the normalFlowList when it is dirty. This is caused by a
new recursion that I added in RenderLayerBacking::hasVisibleNonCompositingDescendant(),
but I overlooked the need to call updateLayerListsIfNeeded()
recursively as well.
Reviewed by Simon Fraser.
No test, because there's no reliable way to test this (same as bug 85512).
- rendering/RenderLayerBacking.cpp:
(WebCore::hasVisibleNonCompositingDescendant):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):
- 3:37 PM Changeset in webkit [142814] by
-
- 3 adds in trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj
Unreviewed. Add some missing property sheets for TestWebKitAPI.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Added.
- 3:37 PM Changeset in webkit [142813] by
-
- 2 edits in trunk/Source/JavaScriptCore
Yet another build fix
- 3:34 PM Changeset in webkit [142812] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Qt-Mac and Qt-Win buildfix after r142768.
Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13
- WebProcess/WebProcess.h:
(WebKit):
- 3:09 PM Changeset in webkit [142811] by
-
- 3 edits in trunk/Source/WebCore
Don't restart shared timer if both the current and the new fire time are in the past
https://bugs.webkit.org/show_bug.cgi?id=109731
Reviewed by Andreas Kling.
In 40-50% of cases we reschedule the shared timer both the old and the new fire time have already passed. This can happen at least when rescheduling
a zero duration timer and when stopping a timer that was ready to fire.
We can skip rescheduling in this case, the shared timer will fire immediately anyway.
Scheduling timers calls into platform layer and can be slow. This about halves the time under setSharedTimerFireInterval in PLT3
for ~0.1% total CPU time reduction.
- platform/ThreadTimers.cpp:
(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::setSharedTimer):
(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):
- platform/ThreadTimers.h:
(ThreadTimers):
- 3:01 PM Changeset in webkit [142810] by
-
- 79 edits in trunk
The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
https://bugs.webkit.org/show_bug.cgi?id=109325
Reviewed by Anders Carlsson.
Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
two methods as they're provided by the C++ standard library being used.
Source/JavaScriptCore:
- API/JSValueRef.cpp:
(JSValueMakeNumber):
- JSCTypedArrayStubs.h:
(JSC):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::constantNaN):
- offlineasm/cloop.rb:
- runtime/DateConstructor.cpp:
(JSC::dateUTC): Also include an opportunistic style fix.
- runtime/DateInstance.cpp:
(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::toInteger):
- runtime/JSDateMath.cpp:
(JSC::getUTCOffset):
(JSC::parseDateFromNullTerminatedCharacters):
(JSC::parseDate):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncIsNaN):
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):
- runtime/PropertyDescriptor.cpp:
(JSC::sameValue):
Source/WebCore:
No new tests as there's no change in functionality.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDuration):
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::totalPitchRate):
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::setValue):
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::isValidNumber):
- Modules/webaudio/PannerNode.cpp:
(WebCore::fixNANs):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):
- bindings/js/JSGeolocationCustom.cpp:
(WebCore::setTimeout):
(WebCore::setMaximumAge):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::setLength):
- bindings/js/JSWebKitPointCustom.cpp:
(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getByIndex):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/v8/V8Binding.cpp:
(WebCore::toInt32):
(WebCore::toUInt32):
- bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::createPositionOptions):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
- bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCallbackCustom):
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::translate):
(WebCore::WebKitCSSMatrix::scale):
(WebCore::WebKitCSSMatrix::rotate):
(WebCore::WebKitCSSMatrix::rotateAxisAngle):
(WebCore::WebKitCSSMatrix::skewX):
(WebCore::WebKitCSSMatrix::skewY):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::endedPlayback):
- html/MediaController.cpp:
(MediaController::duration):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::clearColor):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::addCue):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setStartTime):
(WebCore::TextTrackCue::setEndTime):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
- page/WindowFeatures.cpp:
(WebCore::WindowFeatures::floatFeature): Also include an opportunistic style fix.
- platform/CalculationValue.cpp:
(WebCore::CalculationValue::evaluate):
- platform/Decimal.cpp:
(WebCore::Decimal::fromDouble):
- platform/Length.cpp:
(WebCore::Length::nonNanCalculatedValue):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::setRate):
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::process):
- platform/audio/Reverb.cpp:
(WebCore::calculateNormalizationScale):
- platform/graphics/Font.cpp:
(WebCore::Font::width):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::isLiveStream):
- platform/graphics/gpu/LoopBlinnMathUtils.cpp:
(LoopBlinnMathUtils):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):
- platform/graphics/opentype/OpenTypeVerticalData.cpp:
(WebCore::OpenTypeVerticalData::getVerticalTranslationsForGlyphs):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
- rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaSlider):
(WebCore::paintMediaVolumeSlider):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentTime):
- svg/animation/SMILTime.h:
(WebCore::SMILTime::SMILTime):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):
- xml/XPathFunctions.cpp:
(WebCore::XPath::FunSubstring::evaluate):
(WebCore::XPath::FunRound::round):
- xml/XPathValue.cpp:
(WebCore::XPath::Value::toBoolean): Also include an opportunistic style fix.
(WebCore::XPath::Value::toString):
Source/WebKit/chromium:
- tests/DecimalTest.cpp:
(TEST_F):
Source/WebKit/mac:
- tests/DecimalTest.cpp:
(TEST_F):
Source/WTF:
- wtf/Compiler.h: Remove the global isinf/isnan compiler quirk definitions. They're not required anymore.
- wtf/DateMath.cpp: Move the workaround for isinf on Solaris into the std namespace. Ditto for isinf and isnan
when using MSVC. Stop bringing the isinf and isnan methods into the global scope when using other configurations.
(WTF::parseDateFromNullTerminatedCharacters):
- wtf/IntegralTypedArrayBase.h:
(WTF::IntegralTypedArrayBase::set):
- wtf/MathExtras.h:
(std):
(std::isinf):
(wtf_fmod):
(wtf_pow):
(doubleToInteger):
- wtf/MediaTime.cpp:
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
- wtf/Uint8ClampedArray.h:
(WTF::Uint8ClampedArray::set):
Tools:
- DumpRenderTree/TestRunner.cpp:
(setAppCacheMaximumSizeCallback):
(setApplicationCacheOriginQuotaCallback):
(setDatabaseQuotaCallback):
- 2:57 PM Changeset in webkit [142809] by
-
- 16 edits1 add in trunk
[Mac] Caption menu should have only one item selected
https://bugs.webkit.org/show_bug.cgi?id=109730
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, media/track/track-user-preferences.html was modified to test the changes.
- CMakeLists.txt: Add CaptionUserPreferences.cpp.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_processingPreferenceChange.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Only end up with one selected track when
called because of a preferences change.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Call setClosedCaptionsVisible instead
of calling markCaptionAndSubtitleTracksAsUnconfigured directly.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Process all tracks,
not just track elements.
- html/HTMLMediaElement.h:
- page/CaptionUserPreferences.cpp: Added so the functionality can be tested in DRT.
(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::setUserPrefersCaptions):
(WebCore::CaptionUserPreferences::captionPreferencesChanged):
(WebCore::CaptionUserPreferences::preferredLanguages):
(WebCore::CaptionUserPreferences::setPreferredLanguage):
(WebCore::CaptionUserPreferences::displayNameForTrack):
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Moved some logic
to base class.
(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Ditto.
LayoutTests:
- media/track/track-user-preferences-expected.txt:
- media/track/track-user-preferences.html: Update test to check for reactions to preferences.
- 2:54 PM Changeset in webkit [142808] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Fix scaling in WebViewImpl::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=109671
Reviewed by James Robinson.
My last patch broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/LinkHighlightTest.cpp:
(WebCore::TEST):
- 2:54 PM Changeset in webkit [142807] by
-
- 2 edits in trunk/Source/WebKit2
Remove bogus ASSERT in WebFrameProxy::didStartProvisionalLoad
https://bugs.webkit.org/show_bug.cgi?id=109733
Reviewed by Sam Weinig.
After http://trac.webkit.org/changeset/142555, this ASSERT is
triggering on these tests:
fast/dom/window-load-crash.html
fast/frames/seamless/seamless-hyperlink-named.html
fast/frames/seamless/seamless-hyperlink.html
The ASSERT appears to be bogus. This patch removes it.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
- 2:46 PM Changeset in webkit [142806] by
-
- 17 edits1 copy4 moves2 adds14 deletes in trunk/Source/WebKit2
Consolidate main functions in WebKit2 now that they are all identical
https://bugs.webkit.org/show_bug.cgi?id=109748
Reviewed by Anders Carlsson.
- Consolidates all the LegacyProcess main functions into ChildProcessMain.mm
- Consolidates all the XPCService main functions into XPCServiceMain.mm and XPCServiceMain.Development.mm
- Rename existing ChildProcessMain.h/mm to ChildProcessEntryPoint.h/mm to match the XPCService ones.
- Switch LegacyProcess to use the "entry point in the plist" idiom, instead of hard coding each one, again matching the XPCService.
- Configurations/BaseLegacyProcess.xcconfig: Add base configuration to hold common legacy process options.
- Configurations/BaseXPCService.xcconfig:
- Configurations/NetworkProcess.xcconfig:
- Configurations/OfflineStorageProcess.xcconfig:
- Configurations/PluginProcess.xcconfig:
- Configurations/SharedWorkerProcess.xcconfig:
- Configurations/WebContentProcess.xcconfig: Renamed form WebProcess.xcconfig.
- NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:
- NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Removed.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Removed.
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm:
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Removed.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Removed.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Removed.
- PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Removed.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Removed.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Replaced.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Removed.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Removed.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Removed.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:
- SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Removed.
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm: Removed.
- WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 2:43 PM Changeset in webkit [142805] by
-
- 4 edits2 adds in trunk
[CSS Exclusions] ExclusionPolygon reflex vertices should constrain the first fit location.
https://bugs.webkit.org/show_bug.cgi?id=107568
Patch by Hans Muller <hmuller@adobe.com> on 2013-02-13
Reviewed by Dirk Schulze.
Source/WebCore:
The ExclusionPolygon::firstIncludedIntervalLogicalTop() method now includes offset edges
for each of the polygon's reflex vertices. The motivation for this change is explained
here: http://hansmuller-webkit.blogspot.com/2013/01/getting-to-point-reflex-vertices.html.
Test: fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html
- rendering/ExclusionPolygon.cpp:
(WebCore::isReflexVertex): Given three vertices that represent a pair of connected polygon edges, return true if the second vertex is a reflex vertex.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This method now includes offset edges for reflex vertices.
- rendering/ExclusionPolygon.h:
(WebCore::OffsetPolygonEdge::OffsetPolygonEdge): Added a constructor for creating an OffsetPolygonEdge given a reflex vertex.
(WebCore::OffsetPolygonEdge::edgeIndex): Changed this property from unsigned to int. Now using -1 to indicate that the offset edge doesn't correspond to a single polygon edge.
LayoutTests:
In this carefully contrived test case, the Y coordinate of the origin of the line
of text is only computed correctly if the constraints implied by the polygon's
reflex vertices are considered.
- fast/exclusions/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html: Added.
- 2:40 PM Changeset in webkit [142804] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change another use of (SpecCell & ~SpecString) to SpecObject.
Reviewed by Mark Hahnenberg.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- 2:40 PM Changeset in webkit [142803] by
-
- 4 edits in trunk/Source/WebCore
CSSPreloadScanner should not depend on HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=109742
Reviewed by Eric Seidel.
There's no need for the CSSPreloadScanner to depend on HTMLToken. On
the background thread, we'll likely want to use a CompactHTMLToken for
preload scanning, so this dependency is problematic. This patch also
teaches the CSSPreloadScanner how to scan LChars.
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::~CSSPreloadScanner):
(WebCore):
(WebCore::CSSPreloadScanner::scan):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLPreloadScanner::processToken):
- 2:39 PM Changeset in webkit [142802] by
-
- 6 edits1 add in trunk/Tools
cr-linux debug should use clang and maybe be a components build
https://bugs.webkit.org/show_bug.cgi?id=108512
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13
Reviewed by Adam Barth.
Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
Build bots will update clang with each bot cycle.
Updated GCE image paths to suit gcutil 1.6.1.
- EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
- EWSTools/GoogleComputeEngine/build-commit-queue.sh:
- EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
- EWSTools/start-queue.sh:
- 2:39 PM Changeset in webkit [142801] by
-
- 2 edits in trunk/Source/WebCore
Fix !ENABLE(BLOB) build.
Reviewed by NOBODY (OOPS!).
- fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::getCachedOrigin):
- page/SecurityOrigin.cpp: (WebCore::getCachedOrigin):
- 2:36 PM Changeset in webkit [142800] by
-
- 2 edits in trunk/Source/JavaScriptCore
ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726
Reviewed by Mark Hahnenberg.
If you add it to the list of relevant node types, you also need to make sure
it's listed as either hasChild or one of the other kinds. Otherwise you get
an assertion. This is causing test failures in run-javascriptcore-tests.
- dfg/DFGMinifiedNode.h:
(JSC::DFG::MinifiedNode::hasChild):
- 2:31 PM Changeset in webkit [142799] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking a few tests as slow on the debug builds. This shall prevent them timing out unnecessarily.
- platform/gtk/TestExpectations:
- 2:17 PM Changeset in webkit [142798] by
-
- 14 edits4 adds in trunk
[CSS Grid Layout] Adding or removing grid items doesn't properly recompute the track sizes
https://bugs.webkit.org/show_bug.cgi?id=109100
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-removal-track-breadth-update.html
The test uncovered several bugs in our implementation that is fixed as part
of this change. They will be detailed below.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
Added this function to share the code between minContentForChild and maxContentForChild.
Also forced a relayout in this case to avoid getting a wrong answer (e.g. the logical height
constrained by the previous layout's grid breadth).
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Updated to use logicalContentHeightForChild.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated to match the specification and set max breadth to current breadth per the specification.
This made us over-grow some cases in the test.
(WebCore::RenderGrid::distributeSpaceToTracks):
Updated to match the specification and use an extra variable to do the intermediate spreading. Also removed
a now unneeded max. This fixes the case of multiple grid items in the same grid area that was completely broken.
(WebCore::RenderGrid::layoutGridItems):
Added a FIXME about always relaying out content sized tracks' children.
- rendering/RenderGrid.h:
Added logicalContentHeightForChild.
LayoutTests:
- fast/css-grid-layout/grid-item-addition-track-breadth-update-expected.txt: Added.
- fast/css-grid-layout/grid-item-addition-track-breadth-update.html: Added.
- fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt: Added.
- fast/css-grid-layout/grid-item-removal-track-breadth-update.html: Added.
New tests.
- fast/css-grid-layout/resources/grid.css:
(.constrainedContainer):
(.unconstrainedContainer):
Added these class to share them with other tests.
- fast/css-grid-layout/auto-content-resolution-columns.html:
- fast/css-grid-layout/auto-content-resolution-rows.html:
- fast/css-grid-layout/implicit-columns-auto-resolution.html:
- fast/css-grid-layout/implicit-position-dynamic-change.html:
- fast/css-grid-layout/implicit-rows-auto-resolution.html:
- fast/css-grid-layout/minmax-max-content-resolution-columns.html:
- fast/css-grid-layout/minmax-max-content-resolution-rows.html:
- fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
- fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
Removed constrainedContainer definition as it was moved to grid.css.
- 2:12 PM Changeset in webkit [142797] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Rebasline after r142765
Unreviewed test expectations update.
The change caused sub-pixel changing in SVG-as-image positions.
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
- 2:03 PM Changeset in webkit [142796] by
-
- 4 edits in trunk/Source/WebCore
Clean up some style nits in HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109738
Reviewed by Tony Gentilcore.
This patch just fixes a few style nits I noticed when reading through
the code.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::StartTagScanner::StartTagScanner):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
- html/parser/HTMLResourcePreloader.cpp:
(WebCore::PreloadRequest::isSafeToSendToAnotherThread):
- html/parser/HTMLResourcePreloader.h:
(PreloadRequest):
(WebCore::PreloadRequest::PreloadRequest):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):
- 2:02 PM Changeset in webkit [142795] by
-
- 6 edits1 delete in trunk
Unreviewed, rolling out r142747.
http://trac.webkit.org/changeset/142747
https://bugs.webkit.org/show_bug.cgi?id=109746
broke component build (Requested by alecf_gardening on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
Source/WebCore:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(WebCore):
(HeapGraphSerializer):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
Tools:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
- 1:56 PM Changeset in webkit [142794] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Stop using WebString in ewk_cookie_manager, ewk_form_submission_request and ewk_text_checker
https://bugs.webkit.org/show_bug.cgi?id=108794
Reviewed by Alexey Proskuryakov.
Stop using WebString in ewk_cookie_manager, ewk_form_submission_request
and ewk_text_checker as it is internal C++ API. WKString and
WKEinaSharedString are used instead.
- UIProcess/API/cpp/efl/WKEinaSharedString.cpp:
(WKEinaSharedString::leakString): Add leakString() method to
WKEinaSharedString so that we can conveniently convert a WKString to a
Eina shared string and take ownership of it.
- UIProcess/API/cpp/efl/WKEinaSharedString.h:
- UIProcess/API/efl/ewk_cookie_manager.cpp:
(getHostnamesWithCookiesCallback):
- UIProcess/API/efl/ewk_form_submission_request.cpp:
(EwkFormSubmissionRequest::copyFieldValue):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
- UIProcess/API/efl/ewk_form_submission_request_private.h:
(EwkFormSubmissionRequest):
- UIProcess/API/efl/ewk_text_checker.cpp:
(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):
- UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
(TEST_F): Add API test for new WKEinaSharedString::leakString() method.
- 1:55 PM Changeset in webkit [142793] by
-
- 3 edits2 adds in trunk
Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137
Reviewed by Eric Seidel.
Source/WebCore:
First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.
Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html
- rendering/InlineIterator.h:
(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.
LayoutTests:
- fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
- fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
- 1:49 PM Changeset in webkit [142792] by
-
- 3 edits in trunk/Source/WebKit2
Remove Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109744
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::connectionDidClose):
- Platform/CoreIPC/Connection.h:
(Connection):
- 1:48 PM Changeset in webkit [142791] by
-
- 16 edits in trunk/Source/WebCore
Better names for ElementAttributeData & subclasses.
<http://webkit.org/b/109529>
Reviewed by Antti Koivisto.
- ElementAttributeData => ElementData
Because ElementAttributeData won't be a good name once we move some non-attribute related
things to this structure.
- ImmutableElementAttributeData => ShareableElementData
These objects can be shared with other Elements that have the same attribute name/value pairs.
- MutableElementAttributeData => UniqueElementData
These objects contain data that is unique to a specific Element, and cannot be shared with
other Elements. This is what's important about it, not that its underlying storage is mutable.
- attributeData() -> elementData()
- updatedAttributeData() -> elementDataWithSynchronizedAttributes()
- ensureUpdatedAttributeData() -> ensureElementDataWithSynchronizedAttributes()
- mutableAttributeData() -> ensureUniqueElementData()
Ride-along renames. Much less vague than previous names IMO.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
- dom/Attr.cpp:
(WebCore::Attr::elementAttribute):
- dom/DocumentSharedObjectPool.cpp:
(WebCore::ShareableElementDataCacheKey::ShareableElementDataCacheKey):
(WebCore::ShareableElementDataCacheKey::operator!=):
(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
- dom/DocumentSharedObjectPool.h:
(DocumentSharedObjectPool):
- dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::Element::reportMemoryUsage):
(WebCore::ElementData::deref):
(WebCore::ElementData::ElementData):
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ElementData::createShareableWithAttributes):
(WebCore::ElementData::createUnique):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
(WebCore::ElementData::makeMutableCopy):
(WebCore::ElementData::makeImmutableCopy):
(WebCore::ElementData::setPresentationAttributeStyle):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::ElementData::getAttributeItemIndexSlowCase):
- dom/Element.h:
(ElementData):
(WebCore::ElementData::isUnique):
(ShareableElementData):
(UniqueElementData):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::elementData):
(Element):
(WebCore::Element::elementDataWithSynchronizedAttributes):
(WebCore::Element::ensureElementDataWithSynchronizedAttributes):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::classNames):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::updateInvalidAttributes):
(WebCore::Element::hasID):
(WebCore::Element::hasClass):
(WebCore::Element::ensureUniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::attributeItem):
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::compareDocumentPosition):
- dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
(WebCore::StyledElement::setInlineStyleFromString):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- dom/StyledElement.h:
(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):
- html/ClassList.cpp:
(WebCore::ClassList::classNames):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::updateAnimatedSVGAttribute):
- svg/SVGElement.h:
(WebCore::SVGElement::invalidateSVGAttributes):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
- 1:47 PM Changeset in webkit [142790] by
-
- 9 edits in trunk/Tools
[chromium] fix TestRunner build with enable_webrtc=0
https://bugs.webkit.org/show_bug.cgi?id=109700
Reviewed by Tony Chang.
We can't use ENABLE() macros in the TestRunner library, however,
ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::userMediaClient):
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
- 1:40 PM Changeset in webkit [142789] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix.
Rearranged the code somewhat to reduce the number of
DFG related ifdefs.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- 1:36 PM Changeset in webkit [142788] by
-
- 3 edits2 adds in trunk
Crash when encountering <object style="resize:both;">
https://bugs.webkit.org/show_bug.cgi?id=109728
Source/WebCore:
See also https://code.google.com/p/chromium/issues/detail?id=175535
This bug can be reproduced on
http://dramalink.net/tudou.y/?xink=162601060
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.
Test: fast/css/resize-object-crash.html
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paint):
Only call paintResizer() if we have a layer and canResize() is true
LayoutTests:
See also https://code.google.com/p/chromium/issues/detail?id=175535
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.
- fast/css/resize-object-crash-expected.txt: Added.
- fast/css/resize-object-crash.html: Added.
- 1:33 PM Changeset in webkit [142787] by
-
- 3 edits in trunk/Source/WebCore
[Microdata] HTMLPropertiesCollection code cleanup
https://bugs.webkit.org/show_bug.cgi?id=109721
Reviewed by Ryosuke Niwa.
Removed forward declaration of DOMStringList class.
Removed unused findRefElements() method declaration.
Also Removed unused parameter Element* from updatePropertyCache() method.
No new test since no change in behavior.
- html/HTMLPropertiesCollection.cpp:
(WebCore::HTMLPropertiesCollection::updateNameCache):
- html/HTMLPropertiesCollection.h:
(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):
- 1:30 PM Changeset in webkit [142786] by
-
- 9 edits in trunk
[WebGL][EFL][GTK][Qt]Add support for OES_vertex_array_object.
https://bugs.webkit.org/show_bug.cgi?id=109382
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-13
Reviewed by Kenneth Russell.
Source/WebCore:
Covered by fast/canvas/webgl/oes-vertex-array-object.html
This patch adds support for using Vertex Array Object with OpenGl.
The patch adds support for loading necessary opengl functions
and support for checking GL_ARB_vertex_array_object. The support
for OES_vertex_array_object is advertised if GL_ARB_vertex_array_object is
supported.
- platform/graphics/OpenGLShims.cpp:
(WebCore::initializeOpenGLShims):
- platform/graphics/OpenGLShims.h:
(_OpenGLFunctionTable):
Added support for loading the necessary functions.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore):
(WebCore::Extensions3DOpenGL::isVertexArrayObjectSupported):
- platform/graphics/opengl/Extensions3DOpenGL.h:
(Extensions3DOpenGL):
LayoutTests:
Enable oes-vertex-array-object for EFL port.
- fast/canvas/webgl/oes-vertex-array-object-expected.txt:
- fast/canvas/webgl/oes-vertex-array-object.html:
- platform/efl/TestExpectations:
- 1:29 PM Changeset in webkit [142785] by
-
- 4 edits3 copies11 adds in trunk
TestWebKitAPI, record-memory and gtest-md projects and property sheets for VS2010.
https://bugs.webkit.org/show_bug.cgi?id=107034
Reviewed by Brent Fulgham.
- TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
- win/record-memory: Added.
- win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
- win/record-memory/record-memory.vcxproj: Added.
- win/record-memory/record-memory.vcxproj.filters: Added.
- win/record-memory/record-memoryCommon.props: Added.
- win/record-memory/record-memoryDebug.props: Added.
- win/record-memory/record-memoryRelease.props: Added.
- gtest/msvc/gtest-md.vcxproj: Added.
- gtest/msvc/gtest-md.vcxproj.filters: Added.
- WebKit.vcxproj/WebKit.sln:
- 1:29 PM Changeset in webkit [142784] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Lion build.
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- 1:27 PM Changeset in webkit [142783] by
-
- 4 edits in trunk/Source/WebKit2
Remove support for the DispatchOnConnectionQueue message attribute
https://bugs.webkit.org/show_bug.cgi?id=109743
Reviewed by Sam Weinig.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC):
- Scripts/webkit2/messages.py:
(handler_function):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- 1:22 PM Changeset in webkit [142782] by
-
- 7 edits2 deletes in trunk/Source
chromium: remove CompositorHUDFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=109328
Patch by Eberhard Graether <egraether@google.com> on 2013-02-13
Reviewed by James Robinson.
After switching the HudLayer to use skia's font rendering the
CompositorHUDFontAtlas has become obsolete. This change removes
this class and the related WebLayerTreeView API.
Source/Platform:
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
Source/WebCore:
No new tests.
- WebCore.gypi:
- platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Removed.
- platform/graphics/chromium/CompositorHUDFontAtlas.h: Removed.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
- 1:17 PM Changeset in webkit [142781] by
-
- 4 edits in trunk/Source/WebKit2
StorageManager should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109741
Reviewed by Sam Weinig.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::processWillOpenConnection):
(WebKit::StorageManager::processWillCloseConnection):
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/Storage/StorageManager.messages.in:
- 1:15 PM Changeset in webkit [142780] by
-
- 2 edits in trunk/Source/JavaScriptCore
ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726
Reviewed by Gavin Barraclough.
This is asymptomatic because ForwardInt32ToDouble is only used in SetLocals, in
which case the value is already stored to the stack. Still, we should fix this.
- dfg/DFGMinifiedNode.h:
(JSC::DFG::belongsInMinifiedGraph):
- 1:00 PM Changeset in webkit [142779] by
-
- 4 edits3 adds in trunk
DFG LogicalNot/Branch peephole removal and inversion ignores the possibility of things exiting
https://bugs.webkit.org/show_bug.cgi?id=109489
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
If things can exit between the LogicalNot and the Branch then don't peephole.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
LayoutTests:
Reviewed by Mark Hahnenberg.
- fast/js/dfg-branch-logical-not-peephole-around-osr-exit-expected.txt: Added.
- fast/js/dfg-branch-logical-not-peephole-around-osr-exit.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-branch-logical-not-peephole-around-osr-exit.js: Added.
(foo):
- 12:58 PM Changeset in webkit [142778] by
-
- 6 edits in trunk/Source/WebKit2
EventDispatcher should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109736
Reviewed by Andreas Kling.
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::create):
(WebKit):
(WebKit::EventDispatcher::EventDispatcher):
(WebKit::EventDispatcher::initializeConnection):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebPage/EventDispatcher.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
(WebKit):
(WebKit::WebProcess::eventDispatcher):
(WebProcess):
- 12:52 PM Changeset in webkit [142777] by
-
- 2 edits in trunk
Try to fix the build after r142756
- Source/autotools/SetupAutomake.m4: Instead of using the (now gone) have_gstreamer
variable, activate GStreamer if either web audio or web video is enabled.
- 12:51 PM Changeset in webkit [142776] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r142768.
r142768 broke the EFL WK2 build due to wrong member initialization
order in the WebProcess constructor initialization list.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- 12:34 PM Changeset in webkit [142775] by
-
- 2 edits in trunk/Source/WebCore
Small update to speech bubble for captions menu [Mac]
https://bugs.webkit.org/show_bug.cgi?id=109641
Reviewed by Eric Carlson
Small adjustment to the embedded SVG that draws a speech bubble
for the captions button. Remove a polygon that was so small
it looked like a rendering error.
- css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button):
- 12:34 PM Changeset in webkit [142774] by
-
- 9 edits in trunk
Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648
Reviewed by Eric Carlson.
Source/WebCore:
Add a virtual override to the platform-specific
defaultEventHandler to intercept any click in the controls,
and hide the captions menu if it is showing.
Test: media/video-controls-captions-trackmenu-hide-on-click.html
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::defaultEventHandler): Override from MediaControls. Hide
captions menu if a click event comes in.
- html/shadow/MediaControlsApple.h:
LayoutTests:
New test for captions menu. Skip it everywhere but Mac.
- media/video-controls-captions-trackmenu-hide-on-click.html: Added.
- platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 12:32 PM Changeset in webkit [142773] by
-
- 10 edits in trunk
MediaStream API: Use the source id when creating new tracks
https://bugs.webkit.org/show_bug.cgi?id=109688
Reviewed by Adam Barth.
Source/Platform:
Added id to initialize and renamed audio/videoSources to audio/videoTracks.
- chromium/public/WebMediaStream.h:
(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):
- chromium/public/WebMediaStreamTrack.h:
(WebMediaStreamTrack):
Source/WebCore:
This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.
Covered by existing tests.
- platform/chromium/support/WebMediaStream.cpp:
(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):
- platform/chromium/support/WebMediaStreamTrack.cpp:
(WebKit::WebMediaStreamTrack::initialize):
(WebKit):
- platform/mediastream/MediaStreamComponent.h:
(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
Tools:
Switching mock to new API.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
- 12:23 PM Changeset in webkit [142772] by
-
- 2 edits in trunk/Source/WebCore
Use fancy new Vector-based String constructors in the WebVTT parser
https://bugs.webkit.org/show_bug.cgi?id=109619
Reviewed by Benjamin Poulain.
No change in behavior. Added some FIXMEs for future perf optimization.
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):
- 12:14 PM Changeset in webkit [142771] by
-
- 6 edits in trunk/Tools
[Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
to include paths, to match VS2005 build behavior.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
- WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
- 12:11 PM Changeset in webkit [142770] by
-
- 3 edits2 adds in trunk
WebKit ignores column-rules wider than column-gap
https://bugs.webkit.org/show_bug.cgi?id=15553
Paint column rules even if they are wider than the gap.
Rules wider than the gap should just overlap with column contents.
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-13
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/multicol/rule-thicker-than-gap.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
LayoutTests:
- fast/multicol/rule-thicker-than-gap-expected.html: Added.
- fast/multicol/rule-thicker-than-gap.html: Added.
- 12:08 PM Changeset in webkit [142769] by
-
- 14 edits in trunk/Source/JavaScriptCore
Remove unnecessary indirection to non-local variable access operations
https://bugs.webkit.org/show_bug.cgi?id=109724
Reviewed by Filip Pizlo.
Linked bytecode now stores a direct pointer to the resolve operation
vectors, so the interpreter no longer needs a bunch of indirection to
to perform non-local lookup.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/Instruction.h:
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCapabilities.h:
(JSC::DFG::canInlineOpcode):
- dfg/DFGGraph.h:
(ResolveGlobalData):
(ResolveOperationData):
(PutToBaseOperationData):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_put_to_base):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_put_to_base):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- 12:08 PM Changeset in webkit [142768] by
-
- 6 edits in trunk/Source/WebKit2
Make PluginProcessConnectionManager a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109727
Reviewed by Andreas Kling.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::create):
(WebKit):
(WebKit::PluginProcessConnectionManager::PluginProcessConnectionManager):
(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
- WebProcess/Plugins/PluginProcessConnectionManager.h:
(PluginProcessConnectionManager):
- WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::pluginProcessConnectionManager):
- WebProcess/WebProcess.h:
(WebKit):
(WebProcess):
- 12:05 PM Changeset in webkit [142767] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r182150. Requested by
jamesr_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
- DEPS:
- 11:56 AM Changeset in webkit [142766] by
-
- 3 edits in trunk/Source/WTF
Don't copy Vector<UChar> when passing to new String methods from bug 109617
https://bugs.webkit.org/show_bug.cgi?id=109708
Reviewed by Tony Gentilcore.
Thanks for the catch Darin.
- wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
- wtf/text/StringImpl.h:
(WTF::StringImpl::create8BitIfPossible):
- 11:44 AM Changeset in webkit [142765] by
-
- 14 edits6 adds in trunk
Replace SVG bitmap cache with directly-rendered SVG
https://bugs.webkit.org/show_bug.cgi?id=106159
Reviewed by Tim Horton.
Source/WebCore:
This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
http://ie.microsoft.com/testdrive/Performance/Chalkboard/
On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(http://philbit.com/SvgImagePerformance/viewport.html):
without patch: ~20FPS
with patch: ~55FPS
The bitmap SVG image cache had several shortcomings:
- The bitmap cache prevented viewport rendering. (WK104693)
- Bitmap memory usage was high. (WK106484)
- Caching animating images was expensive.
This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).
This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.
Tests: svg/as-image/svg-image-scaled.html
svg/as-image/svg-image-viewbox.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):
SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):
drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:
the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed
SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.
(WebCore::SVGImage::drawPatternForContainer):
For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.
(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):
- svg/graphics/SVGImage.h:
(WebCore):
(SVGImage):
- svg/graphics/SVGImageCache.cpp:
Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.
To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.
Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.
(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):
Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.
(WebCore::SVGImageCache::imageForRenderer):
A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.
- svg/graphics/SVGImageCache.h:
(WebCore):
(SVGImageCache):
- svg/graphics/SVGImageForContainer.cpp: Added.
(WebCore):
SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.
(WebCore::SVGImageForContainer::size):
This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.
(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):
- svg/graphics/SVGImageForContainer.h: Added.
(WebCore):
(SVGImageForContainer):
In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.
(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):
LayoutTests:
This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.
- platform/chromium/TestExpectations:
- svg/as-image/svg-image-scaled-expected.html: Added.
- svg/as-image/svg-image-scaled.html: Added.
- svg/as-image/svg-image-viewbox-expected.html: Added.
- svg/as-image/svg-image-viewbox.html: Added.
- 11:30 AM Changeset in webkit [142764] by
-
- 3 edits in trunk/Source/WebCore
Avoid updating timer heap when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=109630
Reviewed by Andreas Kling.
When the fire time of a Timer is changed we remove it from the timer heap and reinsert it. This is pretty slow.
Turns out that in ~80% of cases we are already in the heap and the insertion position is the same as the
original position. We can check if anything is actually going to change before doing this work.
This makes starting a timer ~30% faster in average, ~0.1% progression in PLT3.
- platform/Timer.cpp:
(TimerHeapLessThanFunction):
(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::parentHeapPropertyHolds):
(WebCore):
(WebCore::childHeapPropertyHolds):
(WebCore::TimerBase::hasValidHeapPosition):
The code here assumes that STL heap is a normal binary heap. If there is a different implementation
somewhere the assertions will catch it.
(WebCore::TimerBase::updateHeapIfNeeded):
Skip updating the heap if it is already valid.
(WebCore::TimerBase::setNextFireTime):
- platform/Timer.h:
(TimerBase):
- 11:18 AM Changeset in webkit [142763] by
-
- 6 edits in trunk/Source/WebKit2
Make SecItemShimProxy be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109719
Reviewed by Sam Weinig.
This adds a WantsConnection message attribute to be used for messages whose handlers
should take the connection the message was delivered to.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
Add new handleMessage overload.
- Scripts/webkit2/messages.py:
(async_message_statement):
(generate_message_handler):
Handle the WantsMessage attribute.
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::shared):
Use dispatch_once and adoptRef.
(WebKit::SecItemShimProxy::SecItemShimProxy):
Initialize the queue.
(WebKit::SecItemShimProxy::initializeConnection):
Add the proxy as a work queue message receiver.
(WebKit::SecItemShimProxy::secItemRequest):
This no longer needs to call out to a dispatch queue, it's already on a queue.
- UIProcess/mac/SecItemShimProxy.messages.in:
This doesn't need to be a legacy receiver. Also, add the WantsConnection message.
- 10:51 AM Changeset in webkit [142762] by
-
- 11 edits in trunk
Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716
Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
Source/WebKit2:
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 10:49 AM Changeset in webkit [142761] by
-
- 6 edits in trunk/Source
[GTK] Remove remaining dead code from the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109707
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.
Source/WebCore:
- platform/KURL.cpp:
(WebCore::appendEncodedHostname):
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):
Source/WTF:
- wtf/unicode/Unicode.h:
- 10:37 AM Changeset in webkit [142760] by
-
- 4 edits1 add in trunk
.: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects.
https://bugs.webkit.org/show_bug.cgi?id=108695
Add a manual test. Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.
Reviewed by Abhishek Arya.
- ManualTests/scrolling-coordinator-viewport-constrained-crash.html: Added.
Source/WebCore: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects
https://bugs.webkit.org/show_bug.cgi?id=108695
See comments of RenderLayerModelObject::willBeDestroyed() below for details.
Reviewed by Abhishek Arya.
Test: ManulTests/scrolling-coordinator-viewport-constrained-crash.html
Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed): Moved removeViewportConstrainedObject() call into RenderLayerModelObject::willBeDestroyed() because only RenderLayerModelObjects can be added as viewportConstrainedObjects.
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::willBeDestroyed): Changed this->view() (then view->frameView()) to this->frame() (then frame->view()) because when willBeDestroyed() is called, the document has set its renderView to 0 thus this->view() will return 0, causing removeViewportConstrainedObject() not called and a deleted RenderLayerModelObject in FrameView's viewportConstrainedObjects.
- 9:49 AM Changeset in webkit [142759] by
-
- 17 edits in trunk
[SVG] OOB access in SVGListProperty::replaceItemValues()
https://bugs.webkit.org/show_bug.cgi?id=109293
Source/WebCore:
Replacing a list property item with itself should be a no-op. This patch updates the related
APIs and logic to detect the self-replace case and prevent removal of the item from the list.
To avoid scanning the list multiple times, removeItemFromList() is updated to operate on
indices and a findItem() method is added to resolve an item to an index.
Reviewed by Dirk Schulze.
No new tests: updated existing tests cover the change.
- svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::findItem):
(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
(WebCore::SVGAnimatedPathSegListPropertyTearOff::findItem):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
Add a findItem() delegating method, and update removeItemFromList() to use the new
index-based API.
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(SVGListProperty):
Updated to handle the no-op case for insertItemBefore() & replaceItem().
- svg/properties/SVGListPropertyTearOff.h:
(WebCore::SVGListPropertyTearOff::findItem):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
Index-based API updates.
(WebCore::SVGListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGListPropertyTearOff::processIncomingListItemWrapper):
- svg/properties/SVGPathSegListPropertyTearOff.cpp:
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue):
Detect the self-replace case and return without removing the item from the list.
- svg/properties/SVGPathSegListPropertyTearOff.h:
(WebCore::SVGPathSegListPropertyTearOff::findItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):
- svg/properties/SVGStaticListPropertyTearOff.h:
(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemWrapper):
Index-based API updates.
LayoutTests:
Updated tests to cover the crash and new behavior.
Reviewed by Dirk Schulze.
- svg/dom/SVGLengthList-basics-expected.txt:
- svg/dom/SVGLengthList-basics.xhtml:
- svg/dom/SVGNumberList-basics-expected.txt:
- svg/dom/SVGNumberList-basics.xhtml:
- svg/dom/SVGPointList-basics-expected.txt:
- svg/dom/SVGPointList-basics.xhtml:
- svg/dom/SVGTransformList-basics-expected.txt:
- svg/dom/SVGTransformList-basics.xhtml:
- 9:46 AM Changeset in webkit [142758] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][EFL] Cleanup of graphics related code in EwkView
https://bugs.webkit.org/show_bug.cgi?id=109377
Reviewed by Anders Carlsson.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
Initialize the evasGL dependencies here and
set m_isAccelerated to false if this fails.
Set the coordinated graphics scene as active
when using fixed layout.
(EwkView::setSize):
Add a method to set the size and user-viewport
transform from the outside. The idea is moving
this to our pure WK C API in the future.
(EwkView::transformFromScene):
(EwkView::transformToScene):
Update the transform methods to use the user-
viewport transform.
(EwkView::paintToCurrentGLContext):
(EwkView::paintToCairoSurface):
Add methods to paint to either the current GL context
or to a given cairo_surface_t (for software fallback
cases).
(EwkView::displayTimerFired):
Clean up and use the two above methods.
(EwkView::scheduleUpdateDisplay):
Use the new size() methods instead of using the
smart-object data directly.
(EwkView::createGLSurface):
Make this method use size() to query the surface size
and avoid creating the context (done in ctor now).
Also avoid using the smart-object data directly.
(EwkView::enterAcceleratedCompositingMode):
(EwkView::exitAcceleratedCompositingMode):
Turn on/off the use of the coord. graphics scene.
(EwkView::handleEvasObjectCalculate):
Use the new setSize and setUserViewportTransform.
(EwkView::takeSnapshot):
- UIProcess/API/efl/EwkView.h:
(WebCore):
(EwkView):
(EwkView::size):
(EwkView::setUserViewportTransform):
(EwkView::userViewportTransform):
Add the new method definitions and rename isHardwareAccelerated
to isAccelerated which fits better with the naming in WebCore.
- 9:26 AM Changeset in webkit [142757] by
-
- 6 edits in trunk
Source/WebCore: [Refactoring] StyleResolver::State should have methods to access its member variables.
https://bugs.webkit.org/show_bug.cgi?id=108563
Reviewed by Antti Koivisto.
Made all member variables private and added methods to access the
variables, because most of the member variables are read-only.
We don't need to update those read-only variables while resolving
styles.
No new tests, because just refactoring.
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::initElement):
Modified to invoke m_state.initElement if a given element is
different from current m_state's element.
(WebCore::StyleResolver::State::initForStyleResolve):
Moved from StyleResolver.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
Changed ASSERT in the first line. ASSERT(m_state.parentStyle) would be
wrong, because it depends on previous resolving. However,
initForStyleResolve will also update m_state.parentStyle. No code in
pseudoStyleForElement depends on previous resolving state.
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
Added one more parameter, dynamicPseudo, because dynamicPseudo in
State class is just used for returning matched pseudo style from
this ruleMatches to collectMatchingRulesForList. No need to keep
dynamicPseudo while resolving styles.
(WebCore::StyleResolver::checkRegionSelector):
Removed m_pseudoStyle = NOPSEUDO, because this method uses just
SelectorChecker::matched. SelectorChecker doesn't see StyleResolver's
m_pseudoStyle directly. Need to use SelectorCheckerContext. So no
need to set m_pseudoStyle to be NOPSEUDO.
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
- css/StyleResolver.h:
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::clear):
Modified to use clear at the end of styleForElement.
(WebCore::StyleResolver::State::document):
(WebCore::StyleResolver::State::element):
(WebCore::StyleResolver::State::styledElement):
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::State::style):
(WebCore::StyleResolver::State::takeStyle):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::parentNode):
(WebCore::StyleResolver::State::setParentStyle):
(WebCore::StyleResolver::State::parentStyle):
(WebCore::StyleResolver::State::rootElementStyle):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyle):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::distributedToInsertionPoint):
(WebCore::StyleResolver::State::setElementAffectedByClassRules):
(WebCore::StyleResolver::State::elementAffectedByClassRules):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::applyPropertyToRegularStyle):
(WebCore::StyleResolver::State::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::pendingImageProperties):
(WebCore::StyleResolver::State::pendingSVGDocuments):
(WebCore::StyleResolver::State::setHasPendingShaders):
(WebCore::StyleResolver::State::hasPendingShaders):
(WebCore::StyleResolver::State::setLineHeightValue):
(WebCore::StyleResolver::State::lineHeightValue):
(WebCore::StyleResolver::State::setFontDirty):
(WebCore::StyleResolver::State::fontDirty):
(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::State::hasUAAppearance):
(WebCore::StyleResolver::State::borderData):
(WebCore::StyleResolver::State::backgroundData):
(WebCore::StyleResolver::State::backgroundColor):
(WebCore::StyleResolver::State::fontDescription):
(WebCore::StyleResolver::State::parentFontDescription):
(WebCore::StyleResolver::State::setFontDescription):
(WebCore::StyleResolver::State::setZoom):
(WebCore::StyleResolver::State::setEffectiveZoom):
(WebCore::StyleResolver::State::setTextSizeAdjust):
(WebCore::StyleResolver::State::setWritingMode):
(WebCore::StyleResolver::State::setTextOrientation):
fontDescription, ... and setTextOrientation were moved from
StyleResolver.
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
Moved from StyleResolver.
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
These fontDescription, ..., setTextOrientation are wrappers to
invoke State's methods. StyleBuilder still depends on StyleResolver
and invokes these methods. So we need these wrappers.
LayoutTests: [Refactoring] StyleResolver::State should have methods to access its me
https://bugs.webkit.org/show_bug.cgi?id=108563
Reviewed by Antti Koivisto.
- inspector/styles/region-style-crash-expected.txt:
Rebaseline. Since inspector hasn't supported CSS region styles yet,
region-style-crash.html has no CSS region styles as its result.
- 9:24 AM Changeset in webkit [142756] by
-
- 5 edits in trunk
[GTK] Remove support for compiling with GStreamer 0.10
https://bugs.webkit.org/show_bug.cgi?id=109593
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.
Remove support for building WebKitGTK+ with GStreamer 0.10. We
can simplify things greatly because we don't have to worry any
longer about selecting one GStreamer API set.
- Source/autotools/FindDependencies.m4:
- Source/autotools/ReadCommandLineArguments.m4:
- Source/autotools/SetupAutoconfHeader.m4:
- Source/autotools/Versions.m4:
- 9:21 AM Changeset in webkit [142755] by
-
- 8 edits in trunk/Source
[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Do not override width or height of 0, as that indicates default size, and not minimum size.
Tested by tst_qwebpage.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::adjustWindowRect):
Source/WebKit/efl:
Do not resize window when default size is requested.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::setWindowRect):
Source/WebKit/gtk:
Do not resize window when default size is requested.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::setWindowRect):
Source/WebKit/qt:
Test that minimum size is applied only when the requested size is too small,
not when default is requested.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):
- 9:01 AM Changeset in webkit [142754] by
-
- 3 edits6 adds in trunk
The 2D Canvas functions fillText()/strokeText() should display nothing when maxWidth is less then or equal to zero
https://bugs.webkit.org/show_bug.cgi?id=102656
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-13
Reviewed by Dirk Schulze.
The functions fillText()/strokeText() should not display anything when
maxWidth is less than or equal to zero, according to spec :
http://www.w3.org/TR/2dcontext/#text-preparation-algorithm
Source/WebCore:
Test: fast/canvas/canvas-fillText-maxWidth-zero.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
LayoutTests:
- fast/canvas/canvas-fillText-invalid-maxWidth-expected.txt: Added.
- fast/canvas/canvas-fillText-invalid-maxWidth.html: Added.
- fast/canvas/canvas-strokeText-invalid-maxWidth-expected.txt: Added.
- fast/canvas/canvas-strokeText-invalid-maxWidth.html: Added.
- fast/canvas/script-tests/canvas-fillText-invalid-maxWidth.js: Added.
- fast/canvas/script-tests/canvas-strokeText-invalid-maxWidth.js: Added.
- 8:47 AM Changeset in webkit [142753] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Provide the same custom expectations as all the other
platforms. This likely means that there is a bug in the code or
that the expected result is incorrect.
- platform/gtk/TestExpectations:
- platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.
- 8:25 AM Changeset in webkit [142752] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
https://bugs.webkit.org/show_bug.cgi?id=109611
The deltas in mousewheel events generated by track can be accelerated (e.g. when
scrolling repeatedly). Keep track of the ratio of the acceleration since that is
useful for some tasks (e.g. overflow navigation gesture).
Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2013-02-13
Reviewed by Adam Barth.
- public/WebInputEvent.h:
(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
- src/WebInputEvent.cpp:
(SameSizeAsWebMouseWheelEvent):
- 8:23 AM Changeset in webkit [142751] by
-
- 2 edits in trunk/Source/JavaScriptCore
replaceWithJump should not decrease the offset by 1 on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109689
Reviewed by Zoltan Herczeg.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::replaceWithJump):
- 8:16 AM Changeset in webkit [142750] by
-
- 13 edits4 copies in trunk/Source/WebKit2
[EFL][WK2] Introduce WKViewClient C API
https://bugs.webkit.org/show_bug.cgi?id=109559
Reviewed by Anders Carlsson.
This patch introduces the WKViewClient C API for EFL's WKView. The purpose of
this new C API is to eventually remove the interdependency between EFL's
PageClient and EwkView. When completed, PageClient should only interact with
WebView and not be aware of EwkView so that we have a clean separation between
internal WebKit2 classes and our EFL Ewk API implementation.
This patch is only a first step towards this goal as there is a lot of work
to do to achieve complete separation between EwkView and PageClient. The purpose
of this patch is to introduce the needed architecture which will later be
extended by introducing new WKViewClient callbacks.
- PlatformEfl.cmake: Add new ViewClientEfl.cpp and WebViewClient.cpp to EFL's CMake
configuration.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetViewClient):
- UIProcess/API/C/efl/WKView.h: Introduce new WKViewClient C API.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView): Initialize ViewClientEfl.
- UIProcess/API/efl/EwkView.h: Add new ViewClientEfl member.
(WebKit):
(EwkView):
- UIProcess/API/efl/EwkViewCallbacks.h: Update ContentsSizeChanged smart callback to
accept a WKSize in parameter instead of an IntRect.
- UIProcess/efl/PageClientBase.cpp: Start calling WKViewClient callbacks instead of
interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientBase::view):
(WebKit::PageClientBase::setViewNeedsDisplay):
- UIProcess/efl/PageClientBase.h:
(WebKit):
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp: Start calling WKViewClient callbacks instead of
interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
- UIProcess/efl/PageClientLegacyImpl.cpp: Start calling WKViewClient callbacks instead of
interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit):
(WebKit::ViewClientEfl::toEwkView):
(WebKit::ViewClientEfl::viewNeedsDisplay):
(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h: Introduce new ViewClientEfl which handles WKViewClient callbacks
and interacts with EwkView.
(WebKit):
(ViewClientEfl):
(WebKit::ViewClientEfl::create):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::initializeClient):
(WebKit):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::didChangeContentsSize):
- UIProcess/efl/WebView.h: Add new WebViewClient member and corresponding methods to interact
with it.
(WebView):
- UIProcess/efl/WebViewClient.cpp:
(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):
- UIProcess/efl/WebViewClient.h: Add new WebViewClient APIClient for WKViewClient.
(WebCore):
(WebKit):
- 8:15 AM EnableFormFeatures edited by
- (diff)
- 8:12 AM Changeset in webkit [142749] by
-
- 6 edits in trunk/Source/WebCore
[GTK][AC] Implement basic transform animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109363
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-13
Reviewed by Gustavo Noronha Silva.
Implement basic transform animation with clutter ac backend.
GraphicsLayerClutter is almost same with GraphicsLayerCA. And PlatformClutterAnimation
interfaces are also similar with PlatformCAAnimation, but they are implemented
with native clutter APIs. Clutter backend AC supports a basic single transform animation
with this patch now, but additive animation combination and keyframe animation
are not supported yet.
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetTransform):
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::isTransformTypeTransformationMatrix):
(WebCore):
(WebCore::isTransformTypeFloatPoint3D):
(WebCore::isTransformTypeNumber):
(WebCore::getTransformFunctionValue):
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::appendToUncommittedAnimations):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(GraphicsLayerClutter):
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::toClutterActorPropertyString):
(WebCore):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- 7:57 AM Changeset in webkit [142748] by
-
- 4 edits in trunk
[WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
https://bugs.webkit.org/show_bug.cgi?id=109456
Reviewed by Anders Carlsson.
Source/WebKit2:
WebView destructor now considers the situation if its WebPageProxy
instance had been closed from outside the class (explicitly
by client code).
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::~WebView):
Tools:
WebView instance must not live longer than EwkView, as EwkView owns
objects that page proxy refers to, doing otherwise leads to a crash.
Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
leads to evas objects deletion. So, the problem was that test controller was
deleted after ewk_shutdown() had been called in main() function causing
crashes on WTR exit.
The patch introduces a scope for test controller so that it is deleted first.
- WebKitTestRunner/efl/main.cpp:
(main):
- 7:30 AM Changeset in webkit [142747] by
-
- 6 edits1 add in trunk
Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554
In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.
Reviewed by Yury Semikhatsky.
It is covered by newly added tests in TestWebKitAPI.
Source/WebCore:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):
- inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
Tools:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):
- 7:27 AM Changeset in webkit [142746] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: add experimental native heap graph to Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=109687
Reviewed by Alexander Pavlov.
Added experimentatl support for native heap graph on the Timeline panel.
Native memory usage data is collected after each top level task and can
be displayed instead of DOM counters graph on the Timeline panel if
corresponding experiment is enabled in the inspector settings.
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorTimelineAgent.cpp:
(TimelineAgentState):
(WebCore::InspectorTimelineAgent::setIncludeDomCounters):
(WebCore):
(WebCore::InspectorTimelineAgent::setIncludeNativeMemoryStatistics):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
- inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/TimelinePanel.js:
- 7:25 AM Changeset in webkit [142745] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.
The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.
No new tests.
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
- 6:27 AM Changeset in webkit [142744] by
-
- 4 edits in trunk/LayoutTests
Unreviewed chromium expectation changes resulting from r142719.
- platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
- platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
- 6:19 AM Changeset in webkit [142743] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix js compilation warnings in TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109685
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.
Mark last argument of _applySuggestion function as optional.
No new tests: no change in behaviour.
- inspector/front-end/TextPrompt.js:
- 6:09 AM Changeset in webkit [142742] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl/TestExpectations:
- 6:04 AM Changeset in webkit [142741] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed chromium expectation changes.
Fallout from r142683.
- platform/chromium-win/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
- 6:03 AM Changeset in webkit [142740] by
-
- 13 edits1 copy6 deletes in branches/chromium/1364
Merge 141769
Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020
Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.
Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.
Source/WebKit/chromium:
This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.
- features.gypi:
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):
- tests/data/non-fast-scrollable.html:
- tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
LayoutTests:
The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.
- compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
- compositing/overflow/iframe-inside-overflow-clipping.html:
- compositing/overflow/nested-scrolling.html:
- compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
- compositing/overflow/scrolling-content-clip-to-viewport.html:
- compositing/overflow/scrolling-without-painting.html:
- compositing/overflow/textarea-scroll-touch.html:
- compositing/overflow/updating-scrolling-content.html:
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
- platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/12254005
- 5:45 AM Changeset in webkit [142739] by
-
- 30 edits5 adds in trunk
Implement css-conditional's CSS.supports()
https://bugs.webkit.org/show_bug.cgi?id=100324
Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-13
Reviewed by Antti Koivisto.
Source/WebCore:
http://dev.w3.org/csswg/css3-conditional/#the-css-interface
The supports() method provides the css @supports rule's corresponding
dom api.
The patch also adds the CSS interface on DOMWindow, which holds "useful
CSS-related functions that do not belong elsewhere". This is where
supports() lives.
Test: css3/supports-dom-api.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/gobject/GNUmakefile.am:
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction):
Add DOMWindowCSS.* to the build systems.
- bindings/scripts/CodeGenerator.pm:
(WK_lcfirst):
Handle CSS prefixes correctly (s/cSS/css/).
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSupportsCondition):
(WebCore::CSSParser::detectAtToken):
- css/CSSParser.h:
webkit_supports_condition parses just the condition part of an
@supports rule and evaluates it, outputting whether the condition
is supported or not.
- css/CSSAllInOne.cpp:
- css/DOMWindowCSS.cpp: Added.
- css/DOMWindowCSS.h: Added.
- css/DOMWindowCSS.idl: Added.
The CSS interface object.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::css):
- page/DOMWindow.h:
- page/DOMWindow.idl:
window.CSS
LayoutTests:
- css3/supports-dom-api-expected.txt: Added.
- css3/supports-dom-api.html: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 5:15 AM Changeset in webkit [142738] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Simplify SplitView to rely more on CSS
https://bugs.webkit.org/show_bug.cgi?id=109426
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Vsevolod Vlasov.
Simplified Javascript code by moving large part of the layout logic into CSS rules. The patch is larger than it
should be because one of the clients (TimelinePanel) is breaking SplitView incapsulation by reparenting its
resizer.
No new tests.
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
(WebInspector.SplitView.prototype._innerSetVertical):
(WebInspector.SplitView.prototype.setSecondIsSidebar):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/cssNamedFlows.css:
(.css-named-flow-collections-view .split-view-sidebar):
(.css-named-flow-collections-view .split-view-sidebar .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar .selection):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before, .css-named-flow-collections-view .region-empty:before, .css-named-flow-collections-view .region-fit::before, .css-named-flow-collections-view .region-overset::before):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before):
- inspector/front-end/splitView.css:
(.split-view-contents.maximized):
(.split-view-vertical .split-view-contents):
(.split-view-vertical .split-view-contents-first):
(.split-view-vertical .split-view-contents-first.maximized):
(.split-view-vertical .split-view-contents-second):
(.split-view-vertical .split-view-contents-second.maximized):
(.split-view-horizontal .split-view-contents):
(.split-view-horizontal .split-view-contents-first):
(.split-view-horizontal .split-view-contents-first.maximized):
(.split-view-horizontal .split-view-contents-second):
(.split-view-horizontal .split-view-contents-second.maximized):
(.split-view-vertical .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical .split-view-resizer):
(.split-view-horizontal .split-view-resizer):
- inspector/front-end/timelinePanel.css:
(.timeline.split-view-vertical .split-view-resizer):
(#timeline-container .split-view-sidebar):
- 4:57 AM Changeset in webkit [142737] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r142730.
http://trac.webkit.org/changeset/142730
https://bugs.webkit.org/show_bug.cgi?id=109666
chromium browser tests are failing
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(TestInterfaceV8Internal):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- 3:59 AM Changeset in webkit [142736] by
-
- 11 edits in trunk
[WK2] Remove web intents callbacks
https://bugs.webkit.org/show_bug.cgi?id=109654
Reviewed by Benjamin Poulain.
Web intents was removed by r142549.
Source/WebKit2:
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.h:
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 3:39 AM Changeset in webkit [142735] by
-
- 5 edits1 add in trunk/Source/WebCore
OpenCL implementation of Flood SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=109580
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-13
Reviewed by Zoltan Herczeg.
- Target.pri:
- platform/graphics/filters/FEFlood.h:
(FEFlood):
- platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:
(WebCore):
(WebCore::PROGRAM_STR):
(WebCore::FilterContextOpenCL::compileFill):
(WebCore::FilterContextOpenCL::fill):
- platform/graphics/gpu/opencl/FilterContextOpenCL.h:
(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):
- platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Added.
(WebCore):
(WebCore::FEFlood::platformApplyOpenCL):
- 3:19 AM Changeset in webkit [142734] by
-
- 11 edits1 copy2 adds in trunk
location.href does not throw SECURITY_ERR when accessed across origins with JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=43891
Reviewed by Adam Barth.
Source/WebCore:
Other browsers (IE, Firefox, and Opera) throw an exception when accessing
properties of a Location object across origins, as the spec suggests[1].
WebKit is currently the outlier.
This has a few negative effects: developers are forced to hack around
access violations in two ways rather than having a single code path, and
(more annoyingly) developers are unable to avoid generating the error
message. See every ad on the internet for the effect on the console. :)
This patch adds a SECURITY_ERR exception to these access violations,
which is the first step towards getting rid of the console spam. Getting
rid of the message entirely will require a solution to
http://wkbug.com/98050.
A fairly inconclusive thread[2] on webkit-dev popped up in 2010 and
trailed off without reaching conclusion. A more recent thread reached
agreement that this patch seems like a reasonable thing to do[3].
This is the JSC half of the patch. V8 is coming in http://wkbug.com/43892
[1]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#security-location
[2]: https://lists.webkit.org/pipermail/webkit-dev/2010-August/013880.html
[2]: https://lists.webkit.org/pipermail/webkit-dev/2012-February/023636.html
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
LayoutTests:
- http/tests/plugins/resources/cross-frame-object-access.html:
- http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
- http/tests/security/cross-frame-access-location-get-expected.txt:
- http/tests/security/cross-frame-access-location-get.html:
- http/tests/security/resources/cross-frame-access.js:
(accessThrowsException):
- http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
- http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:
Adjusting tests to check for exceptions, and adjusting expectations to match.
- platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt.
- platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Added.
- platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Copied from LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt.
V8 fails at the moment: http://wkbug.com/43892
- 2:59 AM Changeset in webkit [142733] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test fix: removed redundant testRunnet.notifyDone() call that was causing other test failures.
- inspector/script-execution-state-change-notification.html:
- 2:45 AM Changeset in webkit [142732] by
-
- 9 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining tests after the DOM4 Events constructors and CSS image-set
support were enabled.
- platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/gtk/fast/events/constructors: Added.
- platform/gtk/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
- platform/gtk/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
- platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt:
- platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
- platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt:
- platform/gtk/fast/hidpi/image-set-simple-expected.txt:
- platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt:
- 2:39 AM Changeset in webkit [142731] by
-
- 10 edits in trunk/Source
Unreviewed Chromium gyp-file cleanup after glib backend removal.
https://bugs.webkit.org/show_bug.cgi?id=109672
Removed references to GLib unicode backend:
Source/WebCore:
- WebCore.gypi:
Source/WebKit/gtk:
- gyp/Configuration.gypi.in:
- gyp/Dependencies.gyp:
- gyp/JavaScriptCore.gyp:
- gyp/WTF.gyp:
Source/WTF:
- WTF.gyp/WTF.gyp:
- WTF.gypi:
- 2:04 AM EnableFormFeatures edited by
- (diff)
- 1:50 AM EnableFormFeatures edited by
- (diff)
- 1:43 AM Changeset in webkit [142730] by
-
- 4 edits in trunk/Source/WebCore
[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666
Reviewed by Adam Barth.
Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). We should generate
wrapper methods for custom getters/setters.
In the future, I will insert TRACE_EVENT() macros into these wrapper methods
to profile DOM getters/setters/methods.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):
- 1:28 AM EnableFormFeatures edited by
- (diff)
- 1:27 AM Changeset in webkit [142729] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt/TestExpectations:
- 1:21 AM WikiStart edited by
- (diff)
- 1:21 AM WikiStart edited by
- (diff)
- 1:21 AM EnableFormFeatures created by
- 1:15 AM WikiStart edited by
- (diff)
- 12:24 AM Changeset in webkit [142728] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r142611.
http://trac.webkit.org/changeset/142611
https://bugs.webkit.org/show_bug.cgi?id=109668
Suggest box is not shown anymore when user types "window." in
inspector console. (Requested by vsevik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
- 12:10 AM Changeset in webkit [142727] by
-
- 2 edits in trunk/Source/WebCore
[V8] There is no XXXConstructor that requires a custom getter
https://bugs.webkit.org/show_bug.cgi?id=109667
Reviewed by Adam Barth.
Currently '[Custom] attribute XXXConstructor xxx' generates
XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
In addition, it does make no sense to generate XXXAttrGetter() for such cases.
We can remove the logic from CodeGeneratorV8.pm.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleBatchedAttribute):
Feb 12, 2013:
- 11:34 PM Changeset in webkit [142726] by
-
- 3 edits2 adds in trunk
[Internals] setShadowDOMEnabled() shouldn't be used except a few tests.
https://bugs.webkit.org/show_bug.cgi?id=109642
Reviewed by Kent Tamura.
Source/WebCore:
InternalSettings.setShadowDOMEnabled() shouldn't be called after
any relevant DOM bindings are touched. However for fuzzers, it
isn't trivial to regulate its behavior.
This change whitelists the URL of running test for prevent
unintended API calls. This doesn't hurt the Internals usability
since the API is called from just a couple of tests and the number
isn't expected to grow.
Test: fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html
- testing/InternalSettings.cpp:
(WebCore::urlIsWhitelisted):
(WebCore):
(WebCore::InternalSettings::setShadowDOMEnabled):
LayoutTests:
- fast/dom/shadow/shadow-dom-enabled-flag-whitelist-expected.txt: Added.
- fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html: Added.
- 11:24 PM Changeset in webkit [142725] by
-
- 5 edits in trunk
Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553
Reviewed by Yury Semikhatsky.
Source/WebCore:
This patch introduces version controller that could be used to migrate inspector settings.
Test: inspector/version-controller.html
- inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/version-controller-expected.txt: Added.
- inspector/version-controller.html: Added.
- 10:30 PM Changeset in webkit [142724] by
-
- 9 edits5 deletes in trunk
[GTK] Remove the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109627
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Benjamin Poulain.
.:
Remove references to the GLib unicode backend from configuration.
- Source/autotools/FindDependencies.m4:
- Source/autotools/ReadCommandLineArguments.m4:
- Source/autotools/SetupAutoconfHeader.m4:
- Source/autotools/SetupAutomake.m4:
Source/WebCore:
Remove references to the GLib unicode backend from WebCore.
- GNUmakefile.list.am: Update the source list.
- platform/text/gtk/TextBreakIteratorGtk.cpp: Removed.
- platform/text/gtk/TextCodecGtk.cpp: Removed.
- platform/text/gtk/TextCodecGtk.h: Removed.
Source/WTF:
Remove references to the GLib unicode backend from WTF.
- GNUmakefile.list.am: Remove GLib unicode files from the source list.
- wtf/unicode/glib/UnicodeGLib.cpp: Removed.
- wtf/unicode/glib/UnicodeGLib.h: Removed.
- 10:21 PM Changeset in webkit [142723] by
-
- 7 edits3 deletes in trunk/LayoutTests
Eradicate fast/js/dfg-poison-fuzz.html
https://bugs.webkit.org/show_bug.cgi?id=109660
Unreviewed.
I haven't seen this test fail in ages. And I've seen a lot of DFG bugs!
This is a super expensive test for one bug that used to be in the DFG but that has
since been thoroughly eradicated. Likely the plethora of other DFG tests cover that
bug. Heck, I'm not even sure if the code that this covers is even in the repository
anymore.
In the spirit of not having super expensive and mostly useless tests, I'm removing
this test.
- fast/js/dfg-poison-fuzz-expected.txt: Removed.
- fast/js/dfg-poison-fuzz.html: Removed.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-poison-fuzz.js: Removed.
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt-4.8/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- 10:16 PM Changeset in webkit [142722] by
-
- 4 edits in trunk/Source
Versioning.
- 10:15 PM Changeset in webkit [142721] by
-
- 2 edits in trunk/Source/WebCore
AX: crash when accessing AccessibilityScrollbar after page has been unloaded
https://bugs.webkit.org/show_bug.cgi?id=109524
Reviewed by Ryosuke Niwa.
AX clients can hold onto AccesibilityScrollbar references that reference parent
AccessibilityScrollViews that have already gone away.
AccessibilityScrollView is not calling detachFromParent after it is removed, which
leads to a crash. The fix is to clearChildren() when an object is deallocated.
I could not create a test because the crash only manifests over multiple page loads.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::detach):
- 10:13 PM Changeset in webkit [142720] by
-
- 1 copy in tags/Safari-537.31
New Tag.
- 10:09 PM Changeset in webkit [142719] by
-
- 4 edits in trunk/Source/WebCore
Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=109650
Reviewed by Dimitri Glazkov.
Set FocusEvent.relatedTarget in its constructor so that each
EventDispatchMediator can use FocusEvent.relatedTarget rather than
its redundant m_{old,new}FocusedNode member variable.
I've also removed FIXME comments, mentioning bug 109261, since I
can not reproduce the issue.
No new tests. No change in functionality.
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/FocusEvent.h:
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
- dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
- 9:17 PM Changeset in webkit [142718] by
-
- 2 edits in trunk/Source/WTF
Remove unnecessary and confusing includes from StreamBuffer.h.
https://bugs.webkit.org/show_bug.cgi?id=109652
Patch by Takeshi Yoshino <tyoshino@google.com> on 2013-02-12
Reviewed by Benjamin Poulain.
StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
FixedArray.h and PassOwnPtr.h are included but not used.
VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
is even slower).
- wtf/StreamBuffer.h:
- 9:10 PM Changeset in webkit [142717] by
-
- 6 edits in trunk/Source/WebCore
[Refactoring] Make SelectorChecker::mode a constructor parameter.
https://bugs.webkit.org/show_bug.cgi?id=109653
Reviewed by Dimitri Glazkov.
No new tests, because just refactoring.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::SelectorChecker):
Made mode a constructor parameter.
- css/SelectorChecker.h:
Removed setMode.
(SelectorChecker):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
- dom/SelectorQuery.cpp:
(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
- html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorChecker::ContentSelectorChecker):
- 8:58 PM Changeset in webkit [142716] by
-
- 6 edits3 copies in branches/chromium/1364
Merge 142572
REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158
Reviewed by Kent Tamura.
Source/WebCore:
The calendar picker button's icon and position where wrong when rtl.
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html
- Resources/pagepopups/calendarPicker.css:
(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.
- Resources/pagepopups/calendarPicker.js:
(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.
- 8:38 PM Changeset in webkit [142715] by
-
- 7 edits in trunk/LayoutTests
[Chromium] Rebaseline suggestion-picker layout tests
https://bugs.webkit.org/show_bug.cgi?id=109647
Unreviewed rebaseline.
Text position differences, imperceptible to human sight.
Test failures possibly caused by: http://trac.webkit.org/changeset/142659
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-12
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- 8:27 PM Changeset in webkit [142714] by
-
- 4 edits in trunk/Source/WebCore
Remove Element::ensureAttributeData().
<http://webkit.org/b/109643>
Reviewed by Anders Carlsson.
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
Use attributeData() instead of ensureAttributeData(), it's already guaranteed to exist in
both these functions as they are called in response to attribute changes.
- svg/SVGElement.h:
(WebCore::SVGElement::invalidateSVGAttributes):
Use mutableAttributeData() instead of ensureAttributeData() when invalidating animated
SVG attributes. While I can't find any bugs caused by this, an element with property animations
shouldn't share attribute data with other elements.
- 8:25 PM Changeset in webkit [142713] by
-
- 3 edits in trunk/Source/WebCore
Make {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator type safe.
https://bugs.webkit.org/show_bug.cgi?id=109561
Reviewed by Dimitri Glazkov.
Use FocusEvent rather than Event in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
No new tests. No change in functionality.
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
- dom/FocusEvent.h:
(FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::event):
(BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::event):
(FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::event):
(FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::event):
- 8:24 PM Changeset in webkit [142712] by
-
- 10 edits in trunk/Source/WebCore
Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions
https://bugs.webkit.org/show_bug.cgi?id=109638
Reviewed by Adam Barth.
Darin Adler noted in:
https://bugs.webkit.org/show_bug.cgi?id=109408#c4
that HTMLToken::Attribute (then MarkupTokenBase::Attribute)
was a struct, yet incorrectly used m_ for its public members.
This patch fixes the members to not have the m_, and since I was
touching all callers, I also updated all callers to use modern
Vector-based String creation/append functions instead of manually
calling UChar*, size_t versions.
There should be no behavior change to this patch. Where I saw
performance/memory bugs, I noted them with FIXMEs to keep
this change simple.
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::processTagToken):
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLToken.h:
(Range):
(Attribute):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::eraseValueOfAttribute):
- html/parser/HTMLTokenizer.cpp:
(WebCore::AtomicHTMLToken::nameForAttribute):
- html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::updateTokenizerState):
- html/parser/XSSAuditor.cpp:
(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
- 8:08 PM Changeset in webkit [142711] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- editing/Editor.h:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController):
- 7:59 PM Changeset in webkit [142710] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Build fix for Chromium-Win.
Add #include <functional> for std::bind1st.
- tests/PrerenderingTest.cpp:
- 7:26 PM Changeset in webkit [142709] by
-
- 1 edit in branches/chromium/1364/Source/WebKit/chromium/features.gypi
Merge 141193
BUG=175910
Review URL: https://codereview.chromium.org/12250029
- 7:05 PM Changeset in webkit [142708] by
-
- 163 edits in branches/chromium/1364/Source
Merge 141034
BUG=175910
Review URL: https://codereview.chromium.org/12251015
- 6:42 PM Changeset in webkit [142707] by
-
- 7 edits3 adds in trunk
REGRESSION: Reloading a local file doesn't pick up changes
https://bugs.webkit.org/show_bug.cgi?id=109344
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/cache/reload-main-resource.php
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::cachePolicy): Don't use subresourceCachePolicy()
for main resources.
- loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
LayoutTests:
- http/tests/cache/reload-main-resource-expected.txt: Added.
- http/tests/cache/reload-main-resource.php: Added.
- http/tests/cache/resources/reload-main-resource-iframe.php: Added.
- http/tests/misc/favicon-loads-with-images-disabled-expected.txt: This test
was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.
- http/tests/misc/link-rel-icon-beforeload-expected.txt: This test
was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.
- 6:40 PM Changeset in webkit [142706] by
-
- 3 edits5 adds1 delete in trunk/Source/WebKit/gtk
[GTK] Connect the gyp build to autoconf
https://bugs.webkit.org/show_bug.cgi?id=109360
Reviewed by Dirk Pranke.
Move Configuration.gypi to Configuration.gypi.in and allow autoconf to
fill in variables during a configuration phase. Also add some scripts
to support connecting autoconf up to the gyp build. This allows us
to have a very autotools-esque experience.
- gyp/Configuration.gypi: Removed.
- gyp/Configuration.gypi.in: Added. Fleshed out Configuration.gypi to include
dependency CFLAGS and LIBS directly from configure. Due to the way we are
generating the gyp build now, we also need to include an absolute path to
the build directory. Fixing bugs in gyp should allow us to avoid this in the
future.
- gyp/Dependencies.gyp: Added this file which holds external dependency targets.
We could consider auto-generating this at some point.
- gyp/JavaScriptCore.gyp: Remove references to the old Configuration.gypi.
It's now included via the command-line -I flag. Update to support the new
s/default/global/g terminology for variables.
- gyp/WTF.gyp: Remove the dependency targets as this is now handled entirely
by autoconf.
- gyp/autogen.sh: Added. Set up the build directory and kick off autoconf.
- gyp/configure.ac: Added. An autoconf build that re-uses much of our
existing autoconf setup.
- gyp/run-gyp: Added. Script for invoking gyp for out-of-tree builds.
- 6:39 PM Changeset in webkit [142705] by
-
- 7 edits in trunk/Source/WebCore
Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller
https://bugs.webkit.org/show_bug.cgi?id=109549
Reviewed by Tony Chang.
Renamed avoidIntersectionWithNode to Editor::avoidIntersectionWithDeleteButtonController and added trivial
implementations when delete button controllers are disabled (ENABLE_DELETION_UI is 0).
- editing/DeleteButtonController.cpp:
- editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand):
- editing/Editor.cpp:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Moved from htmlediting.cpp and renamed.
The version that takes VisibleSelection has been updated to use updatePositionForNodeRemoval to share
mode code with that function.
(WebCore::Editor::rangeForPoint):
- editing/Editor.h:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Added; trivial implementations.
- editing/htmlediting.cpp:
- editing/htmlediting.h:
- editing/markup.cpp:
(WebCore::createMarkupInternal): Extracted from createMarkup.
(WebCore::createMarkup):
- 6:39 PM Changeset in webkit [142704] by
-
- 6 edits1 add in trunk
[WK2] Page reloading will crash UIProcess after WebProcess was killed
https://bugs.webkit.org/show_bug.cgi?id=109305
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-12
Reviewed by Benjamin Poulain.
Source/WebKit2:
Re-initialize the pointer to a WebInspectorProxy object before calling
initializeWebPage().
When the WebProcess crashes, WebPageProxy::processDidCrash() will
set WebInspectorProxy pointer to null, which later is accessed by
initializeWebPage(). This patch avoids a crash scenario where
calls into a null pointer would be made.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
Tools:
Adding a new test to simulate the case of WebProcess crash followed by a trying
to load a new page.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):
- 6:22 PM Changeset in webkit [142703] by
-
- 5 edits2 adds2 deletes in trunk/LayoutTests
Mac rebaseline for r142638.
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-12
Reviewed by Benjamin Poulain.
- platform/mac-lion/accessibility/table-attributes-expected.txt: Removed.
- platform/mac-lion/accessibility/table-cell-spans-expected.txt: Removed.
- platform/mac-lion/accessibility/table-sections-expected.txt: Removed.
- platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Removed.
- platform/mac/accessibility/table-attributes-expected.txt:
- platform/mac/accessibility/table-cell-spans-expected.txt:
- platform/mac/accessibility/table-cells-expected.txt:
- platform/mac/accessibility/table-sections-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Added.
- 6:20 PM Changeset in webkit [142702] by
-
- 3 edits in trunk/LayoutTests
[HTMLTemplateElement] Change template.dat serialization format
https://bugs.webkit.org/show_bug.cgi?id=109635
Reviewed by Eric Seidel.
The serialization format now uses 'content' instead of '#document-fragment' to
denote template contents.
- html5lib/resources/template.dat:
- resources/dump-as-markup.js:
(Markup._get):
- 6:13 PM Changeset in webkit [142701] by
-
- 8 edits in trunk/Source
[iOS] Enable PAGE_VISIBILITY_API
https://bugs.webkit.org/show_bug.cgi?id=109399
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-12
Reviewed by David Kilzer.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 6:10 PM Changeset in webkit [142700] by
-
- 2 edits in trunk/Source/WebKit2
Update a comment in NetworkProcess to be more accurate.
Rubberstamped by Sam Weinig.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
- 5:53 PM Changeset in webkit [142699] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/bindings/v8/ScriptWrappable.h
Merge 140575
BUG=171893
Review URL: https://codereview.chromium.org/12225160
- 5:43 PM Changeset in webkit [142698] by
-
- 12 edits2 deletes in trunk/Source/WebCore
Move ElementAttributeData into Element.cpp/h
<http://webkit.org/b/109610>
Reviewed by Anders Carlsson.
Removed ElementAttributeData.cpp/h and moved the class itself into Element headquarters.
In the near future, Element should be the only client of this class, and thus it won't
be necessary for other classes to know anything about it.
- dom/ElementAttributeData.cpp: Removed.
- dom/ElementAttributeData.h: Removed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/DocumentSharedObjectPool.cpp:
- dom/Element.cpp:
- dom/Element.h:
- workers/SharedWorker.cpp:
- Modules/webdatabase/DatabaseManager.cpp: Add ExceptionCode.h since Element.h doesn't pull it in anymore.
- 5:37 PM Changeset in webkit [142697] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Build fix for VS2010 WebKit solution.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 5:28 PM Changeset in webkit [142696] by
-
- 6 edits in trunk/Source/WebKit2
SecItemShim should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109636
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
Add a helper function for dispatching a work queue message receiver message.
(CoreIPC::Connection::processIncomingMessage):
Check if there are any work queue message receivers registered for this message.
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::shared):
Use dispatch_once instead of the AtomicallyInitializedStatic macro.
(WebKit::SecItemShim::SecItemShim):
Initialize the queue.
(WebKit::SecItemShim::secItemResponse):
Remove the connection parameter.
(WebKit::SecItemShim::initializeConnection):
Register the shim object as a work queue message receiver.
- Shared/mac/SecItemShim.h:
Inherit from WorkQueueMessageReceiver.
- Shared/mac/SecItemShim.messages.in:
Remove LegacyReceiver and DispatchOnConnectionQueue.
- 5:25 PM Changeset in webkit [142695] by
-
- 7 edits in trunk/Source/JavaScriptCore
Renamed SpecObjectMask to SpecObject.
Rubber stamped by Mark Hahnenberg.
"SpecObjectMask" is a weird name considering that a bunch of the other speculated
types are also masks, but don't have "Mask" in the name.
- bytecode/SpeculatedType.h:
(JSC):
(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- 5:13 PM Changeset in webkit [142694] by
-
- 7 edits in trunk/LayoutTests
Remove webintents from TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=109620
Reviewed by James Robinson.
- platform/chromium/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-5.0-mac-wk2/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 5:10 PM Changeset in webkit [142693] by
-
- 4 edits in trunk/Source/WebKit2
Make Plug-in XPC services "join existing sessions"
<rdar://problem/13196448>
Reviewed by Mark Rowe.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
- 5:00 PM Changeset in webkit [142692] by
-
- 2 edits in trunk/Tools
Update WebKitDirs.pm for new Windows paths
https://bugs.webkit.org/show_bug.cgi?id=107714
Reviewed by Daniel Bates.
- Scripts/webkitdirs.pm: For each existing Windows environment
variable, also include creation of the 'new' variables. The
'old' variables will be removed in a future update.
(windowsSourceSourceDir): New helper routine to return the
actual 'Source' folder of the WebKit source tree.
- 4:58 PM Changeset in webkit [142691] by
-
- 5 edits in trunk/Source/WebCore
Crash when scrolling soon after page starts loading
https://bugs.webkit.org/show_bug.cgi?id=109631
<rdar://problem/13157533&13159627&13196727>
Reviewed by Anders Carlsson.
Make the scrolling tree more robust when the root state node,
and/or scrolling node are null. This can happen if we try to
handle a wheel event before we've done the first scrolling
tree commit.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::commit): Handle the case where
m_rootStateNode is null. We'll still commit, but the state tree
will have no state nodes.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEvent): Null-check m_rootNode.
(WebCore::ScrollingTree::commitNewTreeState): Handle a null root node.
(WebCore::ScrollingTree::updateTreeFromStateNode): If the rood state node
is null, just clear the map and null out the root scrolling node.
- page/scrolling/ScrollingTree.h: m_debugInfoLayer was unused.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ensureRootStateNodeForFrameView): It may be possible
to get here before we've registered the root scroll layer, in which case scrollLayerID()
will be 0. Assert to see if this can ever happen.
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeAsText): Handle case of rootStateNode()
being null.
- 4:58 PM Changeset in webkit [142690] by
-
- 4 edits16 copies11 adds in trunk/Source/WebKit2
Add skeleton of the OfflineStorageProcess
https://bugs.webkit.org/show_bug.cgi?id=109615
Reviewed by Anders Carlsson.
This adds the skeleton of a new process to contain Database and Local Storage
backends in (hence, offline storage). We're adding a new process, rather than
using the Network or UIProcesses, to allow us to tightly sandbox these activities
away from networking and full filesystem access.
- Configurations/OfflineStorageProcess.xcconfig: Added.
- Configurations/OfflineStorageService.Development.xcconfig: Added.
- Configurations/OfflineStorageService.xcconfig: Added.
- DerivedSources.make:
- OfflineStorageProcess: Added.
- OfflineStorageProcess/EntryPoint: Added.
- OfflineStorageProcess/EntryPoint/mac: Added.
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess: Added.
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm: Added.
- OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/Info.plist: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/Info.plist: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Added.
- OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageServiceEntryPoint.mm: Added.
- OfflineStorageProcess/OfflineStorageProcess.cpp: Added.
- OfflineStorageProcess/OfflineStorageProcess.h: Added.
- OfflineStorageProcess/OfflineStorageProcess.messages.in: Added.
- OfflineStorageProcess/mac: Added.
- OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: Added.
(WebKit::OfflineStorageProcess::initializeProcessName):
(WebKit::OfflineStorageProcess::initializeSandbox):
- OfflineStorageProcess/mac/com.apple.WebKit.OfflineStorage.sb: Added.
- Shared/OfflineStorage: Added.
- Shared/OfflineStorage/OfflineStorageProcessCreationParameters.cpp: Added.
- Shared/OfflineStorage/OfflineStorageProcessCreationParameters.h: Added.
- Scripts/webkit2/messages.py:
(struct_or_class):
Added OfflineStorageProcessCreationParameters.
- WebKit2.xcodeproj/project.pbxproj:
- 4:41 PM Changeset in webkit [142689] by
-
- 4 edits in trunk/Source/WTF
Teach more WTF string classes about vectors with inline capacity
https://bugs.webkit.org/show_bug.cgi?id=109617
Reviewed by Benjamin Poulain.
The HTML and WebVTT parsers use constructions like:
AtomicString name(m_name.data(), m_name.size())
all over the place because they use inline capacity
on the parse vectors for performance.
This change just add the necessary template variants
to the related String constructors/methods in WTF so that
this parser code can just pass the vector directly instead.
I'll do the actual parser cleanups in follow-up patches to keep things simple.
- wtf/text/AtomicString.h:
(AtomicString):
(WTF::AtomicString::AtomicString):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::StringImpl::create8BitIfPossible):
- wtf/text/WTFString.h:
(String):
(WTF::String::make8BitFrom16BitSource):
(WTF):
(WTF::append):
- 4:23 PM Changeset in webkit [142688] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build warning after r142579
https://bugs.webkit.org/show_bug.cgi?id=109547
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-12
Reviewed by Alexey Proskuryakov.
Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
- 4:10 PM Changeset in webkit [142687] by
-
- 3 edits in trunk/Source/WebCore
Synchronize setting of panner node model and processing
https://bugs.webkit.org/show_bug.cgi?id=109599
Reviewed by Chris Rogers.
No new tests.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
- Modules/webaudio/PannerNode.h:
- 3:53 PM Changeset in webkit [142686] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove webintents from TestExpectations on mac - directory no longer exists.
- platform/mac/TestExpectations:
- 3:53 PM Changeset in webkit [142685] by
-
- 7 edits in trunk/Source/WebCore
Add class name for snapshotted plugin based on dimensions
https://bugs.webkit.org/show_bug.cgi?id=108369
Reviewed by Simon Fraser.
As the size of the plugin changes, the Shadow Root for the snapshot
might want to toggle different interfaces. Expose "tiny", "small",
"medium" and "large" classes on the Shadow. (The dimensions are
currently chosen fairly arbitrarily).
Because we only know the dimensions after layout, we set up
a post layout task to add the class. Luckily there already was
a post layout task for plugins - I just updated it to handle
both real and snapshotted plugins. This involved modifying
the list of RenderEmbeddedObjects in FrameView to take generic
RenderObjects, and decide which type they are when calling
the update method.
- html/HTMLPlugInImageElement.cpp: Some new dimensions for the various size thresholds.
(WebCore::classNameForShadowRootSize): New static function that returns a class name
after examining the size of the object.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Sets the class name for
the shadow root. This is called in the post layout task.
(WebCore::shouldPlugInShowLabelAutomatically): Use new size names.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Ditto.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New method updateSnapshotInfo.
- page/FrameView.cpp:
(WebCore::FrameView::addWidgetToUpdate): Change RenderEmbeddedObject* to RenderObject*.
(WebCore::FrameView::removeWidgetToUpdate): Ditto
(WebCore::FrameView::updateWidget): Branch based on EmbeddedObject vs SnapshottedPlugIn. Call
plugin snapshot update if necessary.
(WebCore::FrameView::updateWidgets): Handle both EmbeddedObject and SnapshottedPlugIn cases.
- page/FrameView.h: Change RenderEmbeddedObject* to RenderObject* for post layout widget updates.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::layout): New virtual override. If size has changed, ask the
FrameView to recalculate size after layout.
- rendering/RenderSnapshottedPlugIn.h: New layout() method.
- 3:53 PM Changeset in webkit [142684] by
-
- 2 edits in trunk/Tools
Fix signedness in WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=109623
Reviewed by Adam Barth.
Fix signedness problem, using size_t instead of int.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
- 3:44 PM Changeset in webkit [142683] by
-
- 14 edits11 adds in trunk
Implement script MIME restrictions for X-Content-Type-Options: nosniff
https://bugs.webkit.org/show_bug.cgi?id=71851
Reviewed by Adam Barth.
Source/WebCore:
This patch adds support for 'X-Content-Type-Options: nosniff' when
deciding whether or not to execute a given chunk of JavaScript. If the
header is present, script will only execute if it matches a predefined
set of MIME types[1] that are deemed "executable". Scripts served with
types that don't match the list will not execute.
IE introduced this feature, and Gecko is working on an implementation[2]
now. There's been some discussion on the WHATWG list about formalizing
the specification for this feature[3], but nothing significant has been
decided.
This implementation's list of acceptible MIME types differs from IE's:
it matches the list of supported JavaScript MIME types defined in
MIMETypeRegistry::initializeSupportedJavaScriptMIMETypes()[4]. In
particular, the VBScript types are not accepted, and
'text/javascript1.{1,2,3}' are accepted, along with 'text/livescript'.
This feature is locked tightly behind the ENABLE_NOSNIFF flag, which is
currently only enabled on the Chromium port.
[1]: http://msdn.microsoft.com/en-us/library/gg622941(v=vs.85).aspx
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=471020
[3]: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-November/037974.html
[4]: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/MIMETypeRegistry.cpp?rev=142086#L307
Tests: http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html
http/tests/security/contentTypeOptions/nosniff-script-allowed.html
http/tests/security/contentTypeOptions/nosniff-script-blocked.html
http/tests/security/contentTypeOptions/nosniff-script-without-content-type-allowed.html
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
Before executing script, ensure that it shouldn't be blocked due to
its MIME type. If it is blocked, write an error message to the
console.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::mimeType):
Make scripts' MIME type available outside the context of
CachedScript in order to correctly populate error messages we write
to the console in ScriptElement::executeScript
(WebCore):
(WebCore::CachedScript::mimeTypeAllowedByNosniff):
- loader/cache/CachedScript.h:
(CachedScript):
A new method which checks the resource's HTTP headers to set the
'nosniff' disposition, and compares the resource's MIME type against
the list of allowed executable types. Returns true iff the script
is allowed.
- platform/network/HTTPParsers.cpp:
(WebCore):
(WebCore::parseContentTypeOptionsHeader):
- platform/network/HTTPParsers.h:
Adds a new enum which relates the sniffable status of the resource,
and a method to parse the HTTP header.
LayoutTests:
- http/tests/security/contentTypeOptions/invalid-content-type-options-allowed-expected.txt: Added.
- http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html: Added.
- http/tests/security/contentTypeOptions/nosniff-script-allowed-expected.txt: Added.
- http/tests/security/contentTypeOptions/nosniff-script-allowed.html: Added.
- http/tests/security/contentTypeOptions/nosniff-script-blocked-expected.txt: Added.
- http/tests/security/contentTypeOptions/nosniff-script-blocked.html: Added.
- http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
- http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html: Added.
- http/tests/security/contentTypeOptions/resources/script-with-header.pl: Added.
New tests!
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
Skip the new tests on platforms where ENABLE_NOSNIFF isn't yet
enabled (everything other than Chromium).
- 3:38 PM Changeset in webkit [142682] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Assume setScrollingOrZooming() to be called on the WebKit thread.
https://bugs.webkit.org/show_bug.cgi?id=109614
Internal PR 294513
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
With this further simplification of threading assumptions,
we can get rid of atomic integer access as well as the
backing store mutex which was otherwise unused.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::isScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- 3:35 PM Changeset in webkit [142681] by
-
- 2 edits in trunk/Tools
Add alias
- 3:28 PM Changeset in webkit [142680] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 141858
BUG=174020
Review URL: https://codereview.chromium.org/12250020
- 3:23 PM Changeset in webkit [142679] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CFA doesn't filter precisely enough for CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=109618
Reviewed by Mark Hahnenberg.
The backend speculates object for this case, but the CFA was filtering on
(SpecCell & ~SpecString) | SpecOther.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- 3:10 PM Changeset in webkit [142678] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Reenable ewk_auth_request API tests
https://bugs.webkit.org/show_bug.cgi?id=108451
Reviewed by Benjamin Poulain.
ewk_auth_request API tests were temporarily disabled after
the C API for resource loading was removed from WebKit2.
This patches updates the tests so that they no longer rely
on the resource loading events and renables them.
This patch also corrects the naming of the static variables
in the test to follow more closely the WebKit coding style.
- PlatformEfl.cmake:
- UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(serverCallback):
(TEST_F):
(onLoadFinished):
- 3:09 PM Changeset in webkit [142677] by
-
- 11 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Eliminate the direct rendering option.
https://bugs.webkit.org/show_bug.cgi?id=109608
RIM PR 293298
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
It added a lot of complexity and we're not going to use it anymore.
This patch removes direct rendering functionality from
WebKit/blackberry together with the assumption that blitting on the
WebKit thread is possible or acceptable. It now isn't anymore.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):
- Api/BackingStore.h:
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):
- Api/WebPage_p.h:
(WebPagePrivate):
- Api/WebSettings.cpp:
(WebKit):
- Api/WebSettings.h:
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
(BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::initialize):
- 3:05 PM Changeset in webkit [142676] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp
Merge 140879
BUG=172243
Review URL: https://codereview.chromium.org/12217152
- 2:57 PM Changeset in webkit [142675] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/css/html.css
Merge 142076
REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132
Reviewed by Hajime Morita.
<input type=date> should be shown in Japanese UI as:
[ ?\229?\185?\180 /?\230?\156?\136/?\230?\151?\165]
But it is shown wrongly since r141195:
/?\230?\156?\136/?\230?\151?\165
We should use white-space:pre.
No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.
- css/html.css:
(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.
TBR=tkent@chromium.org
BUG=crbug.com/174827
Review URL: https://codereview.chromium.org/12211140
- 2:56 PM Changeset in webkit [142674] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed chromium rebaseline for r142638, garden-o-matic screwed up the original rebaseline :(
- platform/chromium-mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/chromium-win-xp/fast/dom/Window: Added.
- platform/chromium-win-xp/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- 2:44 PM Changeset in webkit [142673] by
-
- 7 edits in trunk/Source/WebCore
Threaded HTML parser should pass the remaining fast/tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=109607
Reviewed by Eric Seidel.
This patch fixes some edge cases involving document.write. Previously,
we would drop input characters on the floor if the tokenizer wasn't
able to consume them synchronously. In this patch, we send the unparsed
characters to the background thread for consumption after rewinding the
input stream.
- html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLInputStream.h:
(BackgroundHTMLInputStream):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::resumeFrom):
- html/parser/BackgroundHTMLParser.h:
(Checkpoint):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::finish):
- html/parser/HTMLInputStream.h:
(WebCore::HTMLInputStream::closeWithoutMarkingEndOfFile):
(HTMLInputStream):
- 2:17 PM Changeset in webkit [142672] by
-
- 3 edits in trunk/Source/WebKit2
Introduce a WorkQueueMessageReceiver class as a replacement for QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109612
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::addWorkQueueMessageReceiver):
(CoreIPC):
(CoreIPC::Connection::removeWorkQueueMessageReceiver):
(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
(CoreIPC::Connection::removeWorkQueueMessageReceiverOnConnectionWorkQueue):
- Platform/CoreIPC/Connection.h:
(Connection):
- 2:16 PM Changeset in webkit [142671] by
-
- 2 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 142564
pre-requisite to merging https://src.chromium.org/viewvc/chrome?view=rev&revision=182008
IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519
Reviewed by Adam Barth.
- public/WebIDBDatabaseException.h:
- src/AssertMatchingEnums.cpp:
TBR=dgrogan@chromium.org
BUG=174895
Review URL: https://codereview.chromium.org/12212148
- 1:59 PM Changeset in webkit [142670] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] CSS animations stop running during zoom
https://bugs.webkit.org/show_bug.cgi?id=109606
Patch by Andrew Lo <anlo@rim.com> on 2013-02-12
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
Internal PR 286160.
New BackingStore API for suspending/resuming geometry updates.
This is needed because we want to allow render jobs to continue during
zoom, but we don't want to allow geometry updates during zoom.
Prevent scroll/zoom render jobs from being added to the queue if
the tile is outside the expanded content rect.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendGeometryUpdates):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::resumeGeometryUpdates):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStore::suspendGeometryUpdates):
(BlackBerry::WebKit::BackingStore::resumeGeometryUpdates):
- Api/BackingStore.h:
- Api/BackingStore_p.h:
(BackingStorePrivate):
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):
- 1:51 PM QtWebKitBugs edited by
- (diff)
- 1:36 PM Changeset in webkit [142669] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed buildfix for !ENABLE(INSPECTOR) platforms after r142654.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::scriptsEnabled):
- 1:32 PM Changeset in webkit [142668] by
-
- 2 edits in trunk/Source/WebKit2
Typo fix after r142663.
- GNUmakefile.list.am:
- 1:28 PM Changeset in webkit [142667] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 1:26 PM Changeset in webkit [142666] by
-
- 1 copy in branches/safari-536.29-branch
New Branch.
- 1:24 PM Changeset in webkit [142665] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.js
Merge 141890
Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.
Quick fix for regression.
- inspector/front-end/inspector.js:
Avoid "exit route" when URL is a profile URL.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12223108
- 1:21 PM Changeset in webkit [142664] by
-
- 8 edits in trunk
Remove remaining traces of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=109586
Reviewed by Eric Seidel.
.:
Remove references to Web Intents from CMake files as the functionality
was removed in r142549.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Remove remaining traces of Web Intents as the functionality was
removed in r142549.
No new tests, no behavior change for layout tests.
- GNUmakefile.features.am.in:
- html/HTMLTagNames.in:
Source/WebKit/blackberry:
Remove remaining traces of Web Intents from Blackberry port
configuration as the functionality was removed in r142549.
- WebCoreSupport/AboutDataEnableFeatures.in:
- 1:19 PM Changeset in webkit [142663] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Unreviewed trivial buildfix after r142630 and r142651.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
- 1:17 PM Changeset in webkit [142662] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/watchlist
Adding myself to watch lists.
Unreviewed.
- Scripts/webkitpy/common/config/watchlist:
- 1:15 PM Changeset in webkit [142661] by
-
- 3 edits in branches/chromium/1364
Merge 142128
Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/utilities.js:
LayoutTests:
- inspector/map-expected.txt:
- inspector/map.html:
TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/12208136
- 1:07 PM Changeset in webkit [142660] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js
Merge 142127
Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193
Reviewed by Vsevolod Vlasov.
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12225145
- 1:06 PM Changeset in webkit [142659] by
-
- 3 edits2 adds in trunk
REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476
Reviewed by Levi Weintraub.
Source/WebCore:
Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html
The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
LayoutTests:
- fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
- fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.
- 1:03 PM Changeset in webkit [142658] by
-
- 7 edits10 adds2 deletes in trunk/LayoutTests
Unreviewed rebaseline for r142638.
- platform/chromium-linux-x86/fast/dom/Window: Removed.
- platform/chromium-linux-x86/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
- platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
- platform/chromium-mac/fast/dom/Window/webkitConvertPoint-expected.txt:
- platform/chromium-win/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/mac-lion/accessibility: Added.
- platform/mac-lion/accessibility/table-attributes-expected.txt: Added.
- platform/mac-lion/accessibility/table-cell-spans-expected.txt: Added.
- platform/mac-lion/accessibility/table-sections-expected.txt: Added.
- platform/mac-lion/fast/dom/Window: Added.
- platform/mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Added.
- platform/mac-wk2/fast/dom/Window: Added.
- platform/mac-wk2/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/mac/accessibility/image-link-expected.txt:
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- platform/mac/accessibility/table-detection-expected.txt:
- platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt:
- 1:01 PM Changeset in webkit [142657] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: !object object->isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker https://bugs.webkit.org/show_bug.cgi?id=108699
Reviewed by Abhishek Arya.
Source/WebCore:
RenderListItems performs special management of its children to maintain list markers. Splitting a flow
through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splitting
flows when inside one.
Test: fast/multicol/span/list-multi-column-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):
LayoutTests:
- fast/multicol/span/list-multi-column-crash-expected.txt: Added.
- fast/multicol/span/list-multi-column-crash.html: Added.
- 12:56 PM Changeset in webkit [142656] by
-
- 15 edits in trunk/Source/WebKit2
Change the queue client base class to be private everywhere
https://bugs.webkit.org/show_bug.cgi?id=109604
Reviewed by Andreas Kling.
Move connection queue client registration inside of the respective queue client classes.
Also, it's too late to add queue clients in ChildProcessProxy::didFinishLaunching, so do this in
ChildProcessProxy::connectionWillOpen instead.
Finally, assert that queue clients are only being added and removed from the client thread.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeConnection):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::initializeConnection):
(WebKit):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::connectionWillOpen):
(WebKit):
(WebKit::NetworkProcessProxy::connectionWillClose):
(WebKit::NetworkProcessProxy::didFinishLaunching):
- UIProcess/Network/NetworkProcessProxy.h:
(NetworkProcessProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::didFinishLaunching):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::initializeConnection):
(WebKit):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit):
- WebProcess/Plugins/PluginProcessConnectionManager.h:
(PluginProcessConnectionManager):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::initializeConnection):
(WebKit):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- 12:56 PM Changeset in webkit [142655] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):
- 12:45 PM Changeset in webkit [142654] by
-
- 10 edits2 adds in trunk
Web Inspector: JavaScript execution disabled by browser/UA should be notified to the front-end
https://bugs.webkit.org/show_bug.cgi?id=109402
Reviewed by Yury Semikhatsky.
Source/WebCore:
Whenever the UA/Browser changes the Script Execution state of a page, it should notify the
inspector front-end. Added the InspectorInstrumentation method didScriptExecutionStateChange
to achieve this. Also the state change triggered by the inspector should be ignored to avoid
infinite loop.
Test: inspector/script-execution-state-change-notification.html
- inspector/Inspector.json:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::scriptsEnabledImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::scriptsEnabled):
(WebCore):
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
(WebInspector.PageDispatcher.prototype.scriptsEnabled):
- page/Settings.cpp:
(WebCore::Settings::setScriptEnabled):
LayoutTests:
Tests that whenever Script Execution state is changed outside inspector, its notified to the Inspector front-end.
- inspector/script-execution-state-change-notification-expected.txt: Added.
- inspector/script-execution-state-change-notification.html: Added.
- 12:23 PM Changeset in webkit [142653] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] IndexedDB/Worker crash during shutdown
https://bugs.webkit.org/show_bug.cgi?id=109467
Reviewed by Tony Chang.
If the message queue has already been terminated, don't bother scheduling
a new error event that will never be delivered. Speculative fix for the
issue, which only repros in multiprocess ports and so far only on some
platforms.
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.
- 12:14 PM Changeset in webkit [142652] by
-
- 3 edits in trunk/Source/WebCore
Cache timer heap pointer to timers
https://bugs.webkit.org/show_bug.cgi?id=109597
Reviewed by Andreas Kling.
Accessing timer heap through thread global storage is slow (~0.1% in PLT3). We can cache the heap pointer to
each TimerBase. There are not huge numbers of timers around so memory is not an issue and many timers are heavily reused.
- platform/Timer.cpp:
(WebCore::threadGlobalTimerHeap):
(WebCore::TimerHeapReference::operator=):
(WebCore::TimerHeapIterator::checkConsistency):
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::checkHeapIndex):
(WebCore::TimerBase::setNextFireTime):
- platform/Timer.h:
(WebCore::TimerBase::timerHeap):
(TimerBase):
- 12:12 PM Changeset in webkit [142651] by
-
- 17 edits2 adds in trunk/Source/WebKit2
Add WKContext API to retrieve basic network process statistics
https://bugs.webkit.org/show_bug.cgi?id=109329
Reviewed by Sam Weinig.
This patch adds a WKContextGetStatisticsWithOptions which allows the client to ask for
certain types of statistics.
It also expands the "get statistics" callback mechanism to allow for a statistics request
to be answered by multiple child processes.
That mechanism still has some rough edges but will eventually allow for getting statistics
from multiple web processes, as well.
- NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::pendingRequestCount):
(WebKit::HostRecord::activeLoadCount):
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::getNetworkProcessStatistics):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::hostsPendingCount):
(WebKit::NetworkResourceLoadScheduler::loadsPendingCount):
(WebKit::NetworkResourceLoadScheduler::hostsActiveCount):
(WebKit::NetworkResourceLoadScheduler::loadsActiveCount):
- NetworkProcess/NetworkResourceLoadScheduler.h:
- Shared/Authentication/AuthenticationManager.h:
(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):
- Shared/Downloads/DownloadManager.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):
- UIProcess/API/C/WKContext.h:
- UIProcess/StatisticsRequest.cpp: Added.
(WebKit::StatisticsRequest::StatisticsRequest):
(WebKit::StatisticsRequest::~StatisticsRequest):
(WebKit::StatisticsRequest::addOutstandingRequest):
(WebKit::addToDictionaryFromHashMap):
(WebKit::createDictionaryFromHashMap):
(WebKit::StatisticsRequest::completedRequest):
- UIProcess/StatisticsRequest.h: Added.
(WebKit::StatisticsRequest::create):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::networkingProcessConnection):
(WebKit::WebContext::getStatistics):
(WebKit::WebContext::requestWebContentStatistics):
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::didGetStatistics):
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWebCoreStatistics):
- WebKit2.xcodeproj/project.pbxproj:
- 11:56 AM Changeset in webkit [142650] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the gyp build of JavaScriptCore.
- JavaScriptCore.gypi: Added some missing DFG files to the source list.
- 11:46 AM Changeset in webkit [142649] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r142387.
http://trac.webkit.org/changeset/142387
https://bugs.webkit.org/show_bug.cgi?id=109601
caused all layout and jscore tests on windows to fail
(Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(UnlinkedCodeBlock):
- 11:39 AM Changeset in webkit [142648] by
-
- 4 edits in trunk/Source/WebCore
BackgroundHTMLParser::resumeFrom should take a struct
https://bugs.webkit.org/show_bug.cgi?id=109598
Reviewed by Eric Seidel.
This patch is purely a syntatic change that paves the way for fixing
the partial-entity document.write tests. To fix those tests, we'll need
to pass more information to resumeFrom, but we're hitting the argument
limits in Functional.h. Rather than adding yet more arguments, this
patch moves to a single argument that's a struct.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::resumeFrom):
- html/parser/BackgroundHTMLParser.h:
(Checkpoint):
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didFailSpeculation):
- 11:35 AM Changeset in webkit [142647] by
-
- 3 edits in trunk/Source/WebCore
rootRenderer in FrameView is really RenderView
https://bugs.webkit.org/show_bug.cgi?id=109510
Reviewed by Eric Seidel.
The global function rootRenderer(FrameView*) is really just a way
to get the RenderView from the Frame so replace it with a renderView()
method and replace usage of the word "root" with renderView so it's
obvious the root we're talking about is the renderView. This is an
important distinction to make since we also have rootRenderer in the code
for the documentElement()'s renderer and we also have a "layout root" which
is entirely different.
No new tests, just refactoring.
- page/FrameView.cpp:
(WebCore::FrameView::rootRenderer): Removed.
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::usesCompositedScrolling):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::scrollLayerID):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):
- page/FrameView.h:
(WebCore::FrameView::renderView): Added.
- 11:27 AM Changeset in webkit [142646] by
-
- 2 edits in trunk/Source/WebCore
[GTK][Introspection] GObject bindings for DataTransferItemList - one add() method must be removed from .idl
https://bugs.webkit.org/show_bug.cgi?id=109180
Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-12
Reviewed by Xan Lopez.
When compiling WebKit with --enable-introspection and generating GObject bindings
for DataTransferItemList we must disable one add() method, because GObject is
based on C and C does not allow two functions with the same name.
No tests needed.
- bindings/scripts/CodeGeneratorGObject.pm:
- 11:13 AM Changeset in webkit [142645] by
-
- 3 edits2 adds in trunk
Background size width specified in viewport percentage units not working
https://bugs.webkit.org/show_bug.cgi?id=109536
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.
Source/WebCore:
Corrected the check for viewport percentage unit while calculating
background image width.
Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
LayoutTests:
Added a test for background image width specified in viewport percentage unit.
- fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
- fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
- 11:04 AM Changeset in webkit [142644] by
-
- 3 edits in trunk/Source/WebKit2
Build fix.
Add back the files to the Xcode project that were removed in r142580.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
- 10:50 AM Changeset in webkit [142643] by
-
- 14 edits1 copy in trunk/Tools
[chromium] move text dump generation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109575
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.
(WebTestRunner::normalizeLayoutTestURL):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::checkResponseMimeType):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpAsText):
(WebTestRunner::TestRunner::shouldGeneratePixelResults):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::dump):
(TestShell::captureHistoryForWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::captureHistoryForWindow):
- DumpRenderTree/chromium/WebViewHost.h:
- 10:49 AM Changeset in webkit [142642] by
-
- 2 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::DeleteButtonController::enable
https://bugs.webkit.org/show_bug.cgi?id=109447
Reviewed by Ryosuke Niwa.
RefPtr frame pointer since it can get deleted due to mutation events
fired inside AppendNodeCommand::doUnapply.
No new tests. Testcase is hard to minimize due to recursive
calls with DOMNodeRemovedFromDocument mutation event.
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
- 10:43 AM Changeset in webkit [142641] by
-
- 26 edits1 add1 delete in trunk/Source/WebCore
Remove HTMLTokenTypes header (and split out AtomicHTMLToken.h from HTMLToken.h)
https://bugs.webkit.org/show_bug.cgi?id=109525
Reviewed by Adam Barth.
We no longer need a separate HTMLTokenTypes class now that NEW_XML is gone.
However, to remove HTMLTokenTypes, I had to split AtomicHTMLToken.h from
HTMLToken.h (to fix a circular dependancy).
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addSource):
- html/parser/AtomicHTMLToken.h: Added.
(WebCore):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::forceQuirks):
(WebCore::AtomicHTMLToken::type):
(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::selfClosing):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::characters):
(WebCore::AtomicHTMLToken::charactersLength):
(WebCore::AtomicHTMLToken::isAll8BitData):
(WebCore::AtomicHTMLToken::comment):
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::clearExternalCharacters):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::type):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::sourceForToken):
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::HTMLStackItem):
- html/parser/HTMLToken.h:
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::forceQuirks):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::publicIdentifier):
(WebCore::HTMLToken::systemIdentifier):
(WebCore::HTMLToken::setPublicIdentifierToEmptyString):
(WebCore::HTMLToken::setSystemIdentifierToEmptyString):
(WebCore::HTMLToken::appendToPublicIdentifier):
(WebCore::HTMLToken::appendToSystemIdentifier):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):
(HTMLToken):
- html/parser/HTMLTokenTypes.h: Removed.
- html/parser/HTMLTokenizer.cpp:
(WebCore::AtomicHTMLToken::usesName):
(WebCore::AtomicHTMLToken::usesAttributes):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):
- html/parser/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):
- html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::updateTokenizerState):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
- 10:40 AM Changeset in webkit [142640] by
-
- 8 edits in trunk
Handle error recovery in @supports
https://bugs.webkit.org/show_bug.cgi?id=103934
Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.
Source/WebCore:
Tests 021, 024, 031, and 033 in
http://hg.csswg.org/test/file/5f94e4b03ed9/contributors/opera/submitted/css3-conditional
fail because there's no explicit error recovery in @support's grammar.
Opera and Firefox pass the tests.
No new tests, modified css3/supports{,-cssom}.html
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
(WebCore::CSSParser::popSupportsRuleData):
- css/CSSParser.h:
LayoutTests:
- css3/supports-cssom.html:
- css3/supports-expected.txt:
- css3/supports.html:
- 10:34 AM Changeset in webkit [142639] by
-
- 2 edits in trunk/Source/WebCore
[Mac] guard against NULL languages array
https://bugs.webkit.org/show_bug.cgi?id=109595
Reviewed by Dean Jackson.
No new tests, existing tests won't crash if this is correct.
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::preferredLanguages):
- 9:40 AM Changeset in webkit [142638] by
-
- 9 edits4 adds in trunk
TransformState::move should not round offset to int
https://bugs.webkit.org/show_bug.cgi?id=108266
Source/WebCore:
Reviewed by Simon Fraser.
Currently TransformState::move rounds the offset to the nearest
integer values, this results in operations using TransformState
to compute a position to misreport the location, specifically
Element:getBoundingClientRect and repaint rects. Sizes are
handled correctly and do not have the same problem.
Tests: fast/sub-pixel/boundingclientrect-subpixel-margin.html
fast/sub-pixel/clip-rect-box-consistent-rounding.html
- page/FrameView.cpp:
(WebCore::FrameView::convertFromRenderer):
Change to use pixel snapping instead of enclosing box. All other
code paths use pixelSnappedIntRect to align the rects to device
pixels however this used enclosingIntRect (indirectly through
the FloatQuad::enclosingBoundingBox call).
Without the rounding in TransformState this causes repaint rects
for elements on subpixel bounds to be too large by up to one
pixel on each axis. For normal repaints this isn't really a
problem but in scrollContentsSlowPath it can result in moving
too large a rect.
- platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::translateTransform):
(WebCore::TransformState::translateMappedCoordinates):
Change to take a LayoutSize instead of an IntSize.
(WebCore::TransformState::move):
(WebCore::TransformState::applyAccumulatedOffset):
- platform/graphics/transforms/TransformState.h:
Remove rounding logic and use original, more precise, value.
- rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToContainer):
Remove rounding logic and use original, more precise, value.
LayoutTests:
Reviewed by Simon Fraser.
Add new tests for Element::boundingClientRect and clip rects for
elements on subpixel boundaries.
- fast/dom/Window/webkitConvertPoint.html:
- platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt:
Update test and expectations to take new rounding into account.
- fast/sub-pixel/boundingclientrect-subpixel-margin-expected.txt: Added.
- fast/sub-pixel/boundingclientrect-subpixel-margin.html: Added.
Add test ensuring that boundingClientRect returns accurate and
precise (as opposed to rounded) metrics.
- fast/sub-pixel/clip-rect-box-consistent-rounding-expected.html: Added.
- fast/sub-pixel/clip-rect-box-consistent-rounding.html: Added.
Add test ensuring that clip rects and elements use consistent rounding.
- 9:37 AM Changeset in webkit [142637] by
-
- 8 edits1 delete in trunk
Rollout r142618, it broke all the Mac builds.
Source/WebCore:
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(WebCore):
(HeapGraphSerializer):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
Tools:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 9:34 AM Changeset in webkit [142636] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG CompareEq optimization should be retuned
https://bugs.webkit.org/show_bug.cgi?id=109545
Reviewed by Mark Hahnenberg.
- Made the object-to-object equality case work again by hoisting the if statement for it. Previously, object-to-object equality would be compiled as object-to-object-or-other.
- Added AbstractState guards for most of the type checks that the object equality code uses.
Looks like a hint of a speed-up on all of the things.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
- 9:05 AM Changeset in webkit [142635] by
-
- 5 edits in trunk
[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338
Reviewed by Adam Barth.
Source/WebCore:
This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.
Tests added to html5lib.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
- html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
LayoutTests:
- html5lib/resources/template.dat:
- 9:04 AM Changeset in webkit [142634] by
-
- 5 edits in trunk
[GTK] Remove the enable-debug-feature configuration option
https://bugs.webkit.org/show_bug.cgi?id=109539
Reviewed by Philippe Normand.
Remove the --enable-debug-feature option from configuration. It doesn't
do anything that --enable-debug doesn't.
- Source/autotools/PrintBuildConfiguration.m4: Remove references to --enable-debug-features.
- Source/autotools/ReadCommandLineArguments.m4: Ditto.
- Source/autotools/SetupAutoconfHeader.m4: Ditto.
- Source/autotools/SetupAutomake.m4: Ditto.
- 8:59 AM Changeset in webkit [142633] by
-
- 5 edits6 copies in branches/chromium/1364
Merge 142111
Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136
Reviewed by Kent Tamura.
Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.
Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
- Resources/pagepopups/calendarPicker.css:
(.today-clear-area):
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.
LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055
Reviewed by Kent Tamura.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
- platform/chromium/TestExpectations:
- 8:59 AM Changeset in webkit [142632] by
-
- 2 edits in trunk/Source/WebKit2
Build fix after r142540 and r142518
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::didReceivePluginProcessConnectionManagerMessageOnConnectionWorkQueue):
This function was added to the header in r142518 but not implemented in that revision.
It wasn't a problem until r142540 started using it.
Add a stub implementation for it.
- 8:58 AM Changeset in webkit [142631] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452
Reviewed by Chris Fleizach.
Source/WebCore:
Send the accessibility childrenChanged notification in
HTMLSelectElement::setRecalcListItems instead of in childrenChanged
so that all possible codepaths are caught.
Test: accessibility/insert-selected-option-into-select-causes-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):
LayoutTests:
Add test to ensure a crash doesn't happen if a selected option
is added to a select element, which was triggering a code path where
the DOM has added a new child of the select but the accessibility
object never got updated.
- accessibility/insert-selected-option-into-select-causes-crash-expected.txt: Added.
- accessibility/insert-selected-option-into-select-causes-crash.html: Added.
- 8:55 AM Changeset in webkit [142630] by
-
- 7 edits in trunk/Source/WebKit2
Make PluginProcessProxy a ChildProcessProxy.
https://bugs.webkit.org/show_bug.cgi?id=109513
Reviewed by Anders Carlsson.
- Shared/ChildProcessProxy.h: Inherit from ThreadSafeRefCounted.
- UIProcess/Network/NetworkProcessProxy.h: Don't inherit from RefCounted.
- UIProcess/WebProcessProxy.h: Don't inherit from ThreadSafeRefCounted
- UIProcess/Plugins/PluginProcessProxy.h: Don't inherit from RefCounted, do inherit from ChildProcessProxy
Rely on ChildProcessProxy for process launcher management and launch options:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
(WebKit::PluginProcessProxy::getLaunchOptions):
(WebKit::PluginProcessProxy::getPluginProcessConnection):
(WebKit::PluginProcessProxy::getSitesWithData):
(WebKit::PluginProcessProxy::clearSiteData):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):
- 8:53 AM QtWebKitBuildBots edited by
- (diff)
- 8:49 AM QtWebKit edited by
- General layouting and point users to the Qt bug tracker to report bugs (diff)
- 8:48 AM QtWebKitBugs edited by
- General cleanup related to bugs now being tracked in the Qt bug tracker (diff)
- 8:45 AM Changeset in webkit [142629] by
-
- 2 edits in trunk/Source/WebKit/mac
BUILD FIX (r142576): WK1 build fails when ENABLE(DELETION_UI) is off
<https://bugs.webkit.org/show_bug.cgi?id=109534>
Fixes the following build failure:
WebEditorClient.mm:243:23: error: out-of-line definition of 'shouldShowDeleteInterface' does not match any declaration in 'WebEditorClient'
bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element)
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldShowDeleteInterface): Protect with
ENABLE(DELETION_UI) macro.
- 8:18 AM Changeset in webkit [142628] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13196331> NetworkProcess deny mach-lookup com.apple.PowerManagement.control
Reviewed by Sam Weinig.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 8:01 AM Changeset in webkit [142627] by
-
- 13 edits in trunk
Web Inspector: for event listener provide handler function value in protocol and in UI
https://bugs.webkit.org/show_bug.cgi?id=109284
Patch by Peter Rybin <prybin@chromium.org> on 2013-02-12
Reviewed by Yury Semikhatsky.
Source/WebCore:
The feature implies that we include a real handler function value into event listener description.
Protocol description, inspector DOM agent (with V8 and JSC backends) and front-end is patched accordingly.
- bindings/js/ScriptEventListener.cpp:
(WebCore::eventListenerHandler):
(WebCore):
(WebCore::eventListenerHandlerScriptState):
- bindings/js/ScriptEventListener.h:
(WebCore):
- bindings/v8/ScriptEventListener.cpp:
(WebCore::eventListenerHandler):
(WebCore):
(WebCore::eventListenerHandlerScriptState):
- bindings/v8/ScriptEventListener.h:
(WebCore):
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.eventListeners):
- inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update):
(.):
LayoutTests:
Test is rebased.
- inspector/elements/event-listener-sidebar-expected.txt:
- inspector/elements/event-listeners-about-blank-expected.txt:
- 7:56 AM Changeset in webkit [142626] by
-
- 8 edits1 add in trunk/Source/WebCore
Web Inspector: add initial implementation of native memory graph to Timeline
https://bugs.webkit.org/show_bug.cgi?id=109578
Reviewed by Alexander Pavlov.
This change adds inital implementation of native memory graph UI. The graph
will be shown in the same place as DOM counters graph on the Timeline panel.
Added NativeMemoryGraph.js that reuses parts of DOM counters graph
implementation. MemoryStatistics.js was refactor to allow sharing
more code between DOM counters and native memory graph.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype._createCurrentValuesBar):
(WebInspector.MemoryStatistics.prototype._createCounterUIList):
(WebInspector.MemoryStatistics.prototype._createCounterUIList.getNodeCount):
(WebInspector.MemoryStatistics.prototype._createCounterUIList.getListenerCount):
(WebInspector.MemoryStatistics.prototype._canvasHeight):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawMarker):
- inspector/front-end/NativeMemoryGraph.js: Added.
(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryCounterUI):
(WebInspector.NativeMemoryCounterUI.prototype._hslToString):
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):
(WebInspector.NativeMemoryCounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.NativeMemoryGraph.prototype._createCurrentValuesBar):
(WebInspector.NativeMemoryGraph.prototype._createCounterUIList.getCounterValue):
(WebInspector.NativeMemoryGraph.prototype._createCounterUIList):
(WebInspector.NativeMemoryGraph.prototype._canvasHeight):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
(WebInspector.NativeMemoryGraph.prototype._draw):
(WebInspector.NativeMemoryGraph.prototype._clearCurrentValueAndMarker):
(WebInspector.NativeMemoryGraph.prototype._updateCurrentValue):
(WebInspector.NativeMemoryGraph.prototype._restoreImageUnderMarker):
(WebInspector.NativeMemoryGraph.prototype._saveImageUnderMarker):
(WebInspector.NativeMemoryGraph.prototype._drawMarker):
(WebInspector.NativeMemoryGraph.prototype._maxCounterValue):
(WebInspector.NativeMemoryGraph.prototype._resetTotalValues):
(WebInspector.NativeMemoryGraph.prototype.valueGetter):
(WebInspector.NativeMemoryGraph.prototype._drawGraph):
(WebInspector.NativeMemoryGraph.prototype._discardImageUnderMarker):
- inspector/front-end/TimelinePanel.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/timelinePanel.css:
(#memory-graphs-canvas-container.dom-counters .resources-dividers):
(.memory-category-value):
- 7:53 AM Changeset in webkit [142625] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix Chromium compilation after r142618.
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
(TestWebKitAPI::HeapGraphReceiver::printNode):
- 7:33 AM Changeset in webkit [142624] by
-
- 4 edits in branches/chromium/1410/Source/WebCore/bindings/v8
Merge 142565
[V8] ScheduledAction::m_context can be empty, so we shouldn't
retrieve an Isolate by using m_context->GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=109523
Reviewed by Adam Barth.
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges
Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate().
This can crash because ScheduledAction::m_context can be empty. Specifically,
ScheduledAction::m_context is set to ScriptController::currentWorldContext(),
which can return an empty handle when a frame does not exist. In addition,
'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty.
Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.
No tests. The Chromium crash report doesn't provide enough information
to reproduce the bug.
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore):
(WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/ScheduledAction.h:
(ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12211130
- 7:29 AM Changeset in webkit [142623] by
-
- 1 add in branches/chromium/1410/codereview.settings
for easy drovering into m26
- 7:28 AM Changeset in webkit [142622] by
-
- 1 copy in branches/chromium/1410
branching for m27
- 7:18 AM Changeset in webkit [142621] by
-
- 4 edits2 adds in trunk
Web Inspector: refactor some reusable functionality from BraceHighlighter
https://bugs.webkit.org/show_bug.cgi?id=109574
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Pavel Feldman.
Source/WebCore:
New test: inspector/editor/text-editor-brace-highlighter.html
Extract functionality which, for given line and cursor position, will
return position for a brace that should be highlighted. Add a layout
test to verify brace highlighter funcionality.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.activeBraceColumnForCursorPosition):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):
- inspector/front-end/TextUtils.js:
(WebInspector.TextUtils.isOpeningBraceChar):
(WebInspector.TextUtils.isClosingBraceChar):
(WebInspector.TextUtils.isBraceChar):
LayoutTests:
Add layout test to verify brace highlighter functionality.
- inspector/editor/text-editor-brace-highlighter-expected.txt: Added.
- inspector/editor/text-editor-brace-highlighter.html: Added.
- 7:06 AM Changeset in webkit [142620] by
-
- 2 edits1 add in trunk/Tools
[GTK] Add an optional moduleset with hard to get packages (including libsecret)
https://bugs.webkit.org/show_bug.cgi?id=109195
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Philippe Normand.
Add an optional moduleset that includes libsecret. This moduleset will
be used to install some annoyingly hard to obtain dependencies on older
distributions.
- gtk/jhbuild-optional.modules: Added.
- gtk/jhbuild.modules: Add a reference to the new moduleset file.
- 6:58 AM Changeset in webkit [142619] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium expectation update.
https://bugs.webkit.org/show_bug.cgi?id=109581
- platform/chromium/TestExpectations: mark debugger-script-preprocessor.html as crashy.
- 6:53 AM Changeset in webkit [142618] by
-
- 8 edits1 add in trunk
Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554
Source/WebCore:
In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.
Reviewed by Yury Semikhatsky.
It is covered by newly added tests in TestWebKitAPI.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializerClient):
(WebCore::HeapGraphSerializerClient::~HeapGraphSerializerClient):
(HeapGraphSerializer):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
Tools:
In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
This patch has new set of tests for HeapGraphSerializer.
Reviewed by Yury Semikhatsky.
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 6:51 AM Changeset in webkit [142617] by
-
- 2 edits in trunk/Tools
Unreviewed followup to r142606, the EFL port also enables the CSS image-set
feature so the new configuration option's default value should reflect that.
- Scripts/webkitperl/FeatureList.pm:
- 6:40 AM Changeset in webkit [142616] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC asserting with long parameter list functions in debug mode on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=109565
Reviewed by Zoltan Herczeg.
Increase the value of sequenceGetByIdSlowCaseInstructionSpace to 80.
- jit/JIT.h:
- 6:33 AM Changeset in webkit [142615] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed chromium rebaselines after r142586.
- platform/chromium-mac/fast/canvas/webgl/webgl-layer-update-expected.png: Added.
- 6:29 AM Changeset in webkit [142614] by
-
- 4 edits2 adds in trunk
Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553
Reviewed by Yury Semikhatsky.
Source/WebCore:
This patch introduces version controller that could be used to migrate inspector settings.
Test: inspector/version-controller.html
- inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/version-controller-expected.txt: Added.
- inspector/version-controller.html: Added.
- 6:19 AM Changeset in webkit [142613] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: File system should produce more verbose error messages and recover from errors
https://bugs.webkit.org/show_bug.cgi?id=109571
Reviewed by Alexander Pavlov.
Error handler prints original file system call params now.
Added callbacks to error handler to recover from errors.
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
(WebInspector.FileSystemUtils.errorMessage):
(.fileSystemLoaded):
(.fileEntryLoaded):
(.errorHandler):
(WebInspector.FileSystemUtils.requestFileContent):
(WebInspector.FileSystemUtils.setFileContent):
(WebInspector.FileSystemUtils._readDirectory):
(.innerCallback):
(WebInspector.FileSystemUtils._requestEntries):
- 6:17 AM Changeset in webkit [142612] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Get rid of unnecessary complexity in FileSystemUtil: remove _getDirectory() method.
https://bugs.webkit.org/show_bug.cgi?id=109567
Reviewed by Alexander Pavlov.
The code in this method was redundant as the same result could be achieved by using File System API directly.
- inspector/front-end/FileSystemProjectDelegate.js:
- 6:15 AM Changeset in webkit [142611] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [SuggestBox] SuggestBox not hidden when prefix is empty and there is preceding input
https://bugs.webkit.org/show_bug.cgi?id=109568
Reviewed by Vsevolod Vlasov.
The suggestbox would get hidden in the case of empty input, yet it should get hidden
in the case of empty user-entered prefix (which is a wider notion.)
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
- 6:04 AM Changeset in webkit [142610] by
-
- 7 edits1 add in trunk/Source/WebCore
Web Inspector: separate SuggestBox from TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109430
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Alexander Pavlov.
Create WebInspector.SuggestBoxDelegate interface and
refactor TextPrompt to use this interface. Separate SuggestBox into
WebInspector.SuggestBox namespace and put it into its own file.
No new tests: no change in behaviour.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/SuggestBox.js: Added.
(WebInspector.SuggestBoxDelegate):
(WebInspector.SuggestBoxDelegate.prototype.applySuggestion):
(WebInspector.SuggestBoxDelegate.prototype.acceptSuggestion):
(WebInspector.SuggestBoxDelegate.prototype.userEnteredText):
(WebInspector.SuggestBox):
(WebInspector.SuggestBox.prototype.get visible):
(WebInspector.SuggestBox.prototype.get hasSelection):
(WebInspector.SuggestBox.prototype._onscrollresize):
(WebInspector.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.SuggestBox.prototype._updateBoxPosition):
(WebInspector.SuggestBox.prototype._onboxmousedown):
(WebInspector.SuggestBox.prototype.hide):
(WebInspector.SuggestBox.prototype.removeFromElement):
(WebInspector.SuggestBox.prototype._applySuggestion):
(WebInspector.SuggestBox.prototype.acceptSuggestion):
(WebInspector.SuggestBox.prototype._selectClosest):
(WebInspector.SuggestBox.prototype.updateSuggestions):
(WebInspector.SuggestBox.prototype._onItemMouseDown):
(WebInspector.SuggestBox.prototype._createItemElement):
(WebInspector.SuggestBox.prototype._updateItems):
(WebInspector.SuggestBox.prototype._selectItem):
(WebInspector.SuggestBox.prototype._canShowBox):
(WebInspector.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.SuggestBox.prototype._completionsReady):
(WebInspector.SuggestBox.prototype.upKeyPressed):
(WebInspector.SuggestBox.prototype.downKeyPressed):
(WebInspector.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.SuggestBox.prototype.enterKeyPressed):
(WebInspector.SuggestBox.prototype.tabKeyPressed):
- inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.userEnteredText):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype._applySuggestion):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 5:56 AM Changeset in webkit [142609] by
-
- 4 edits in trunk
[GTK] Enable CSS Variables feature in development builds
https://bugs.webkit.org/show_bug.cgi?id=109474
Reviewed by Martin Robinson.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the feature on development
builds of the GTK port.
LayoutTests:
- platform/gtk/TestExpectations: Remove the expectations for tests that now pass.
- 5:49 AM Changeset in webkit [142608] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540
Reviewed by Noam Rosenthal.
Adds basysKom copyright info to TextureMapperFPSCounter header.
- platform/graphics/texmap/TextureMapperFPSCounter.cpp:
- platform/graphics/texmap/TextureMapperFPSCounter.h:
- 5:27 AM Changeset in webkit [142607] by
-
- 5 edits in trunk
Unreviewed, rolling out r142531.
http://trac.webkit.org/changeset/142531
https://bugs.webkit.org/show_bug.cgi?id=109569
Causes html5lib/run-template layout test to crash. (Requested
by atwilson_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12
Source/WebCore:
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processEndOfFile):
- html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
LayoutTests:
- html5lib/resources/template.dat:
- 5:25 AM Changeset in webkit [142606] by
-
- 6 edits1 delete in trunk
[GTK] Enable CSS image-set support in development builds
https://bugs.webkit.org/show_bug.cgi?id=109475
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - majority of the related tests now passes.
- GNUmakefile.features.am.in: Add the feature define for the CSS image-set feature
with the define value defaulting to 0. The value gets overridden with 1 in development
builds, meaning the feature is enabled under that configuration.
Tools:
- Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.
Note that the Mac port also enables the feature but does so in Platform.h as the feature
is also enabled for the iOS port which can't at the moment be detected via webkitperl.
LayoutTests:
- platform/gtk/TestExpectations: Reclassify two failures that now fail due to
cursor images not loading while the other expectations are removed as the tests
now pass.
- platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Removed. The generic
expectation now matches the test output.
- 5:23 AM Changeset in webkit [142605] by
-
- 6 edits in trunk
[GTK] Enable DOM4 events constructors in development builds
https://bugs.webkit.org/show_bug.cgi?id=109471
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - the related tests now pass.
- GNUmakefile.features.am.in: Add the feature define for the DOM4 events
constructors feature, its value defaulting to 0. This value is overridden
with 1 in development builds, effectively enabling the feature.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.
LayoutTests:
- platform/gtk/TestExpectations: Remove the failure expectations, the related
tests now pass.
- 5:06 AM Changeset in webkit [142604] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for the GTK port after r142595.
Adding the TextureMapperFPSCounter files to the list of build targets
in case of using the OpenGL texture mapper.
- GNUmakefile.list.am:
- 4:04 AM Changeset in webkit [142603] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in extension server and API
https://bugs.webkit.org/show_bug.cgi?id=109563
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ExtensionAPI.js: drive-by: make sure we fail if extensionServer is not defined in outer scope.
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
- inspector/front-end/externs.js: add extensionServer
- 3:13 AM Changeset in webkit [142602] by
-
- 2 edits in trunk/LayoutTests
Unreviewed -- suppress stray console message that emerged after r142486.
- inspector/extensions/extensions-events.html:
- 3:08 AM Changeset in webkit [142601] by
-
- 2 edits in trunk/Tools
Remove unnecessary variables from FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=109558
Reviewed by Daniel Bates.
A small cleanup, removing unused variables for which the related configuration
options were already removed.
- Scripts/webkitperl/FeatureList.pm:
- 3:06 AM Changeset in webkit [142600] by
-
- 9 edits in trunk
Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
https://bugs.webkit.org/show_bug.cgi?id=109481
Reviewed by Daniel Bates.
The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
back in r120574. There are still occurrences of it in various build systems
which should all be removed as they are useless.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
- features.gypi:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 2:58 AM Changeset in webkit [142599] by
-
- 6 edits2 moves2 deletes in trunk/LayoutTests
REGRESSION(r142576): It made fast/dom/Element/id-in-deletebutton.html fail on Qt.
https://bugs.webkit.org/show_bug.cgi?id=109557
Build fix. Also move this test into platform/mac as done in r142559.
- fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
- fast/dom/Element/id-in-deletebutton.html: Removed.
- platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/editing/deleting/id-in-deletebutton-expected.txt: Copied from LayoutTests/fast/dom/Element/id-in-deletebutton-expected.txt.
- platform/mac/editing/deleting/id-in-deletebutton.html: Copied from LayoutTests/fast/dom/Element/id-in-deletebutton.html.
- platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 2:49 AM QtWebKitBuildBots edited by
- (diff)
- 2:34 AM QtWebKitBuildBots edited by
- (diff)
- 2:06 AM Changeset in webkit [142598] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix !ENABLE(INSPECTOR) builds after r142575
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-12
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willDispatchEvent):
- 2:04 AM Changeset in webkit [142597] by
-
- 8 edits in trunk
Web Inspector: move showWhitespace option into experiments
https://bugs.webkit.org/show_bug.cgi?id=109552
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Remove "show whitespace" setting and add it to experiments.
No new tests: fixed an existing test to verify changes.
- English.lproj/localizedStrings.js:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
LayoutTests:
Fix layout test to switch on experiment instead of toggling one of the
options.
- inspector/editor/text-editor-show-whitespace-expected.txt:
- inspector/editor/text-editor-show-whitespace.html:
- 1:40 AM Changeset in webkit [142596] by
-
- 8 edits in trunk/Source/WebCore
Add error checking into OpenCL version of SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=107444
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-12
Reviewed by Zoltan Herczeg.
In case of an error the program runs through all the remaining filters by doing nothing.
After that deletes the results of every filter and starts software rendering.
- platform/graphics/filters/FilterEffect.cpp:
(WebCore):
(WebCore::FilterEffect::applyAll): At software rendering this is a simple inline methode, but at OpenCL rendering it releases OpenCL things. If we have an error remove filter's results and start software rendering.
(WebCore::FilterEffect::clearResultsRecursive):
(WebCore::FilterEffect::openCLImageToImageBuffer):
(WebCore::FilterEffect::createOpenCLImageResult):
(WebCore::FilterEffect::transformResultColorSpace):
- platform/graphics/filters/FilterEffect.h:
(FilterEffect):
(WebCore::FilterEffect::applyAll):
- platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:
(WebCore::FilterContextOpenCL::isFailed):
(WebCore):
(WebCore::FilterContextOpenCL::freeResources):
(WebCore::FilterContextOpenCL::destroyContext):
(WebCore::FilterContextOpenCL::compileTransformColorSpaceProgram):
(WebCore::FilterContextOpenCL::openCLTransformColorSpace):
(WebCore::FilterContextOpenCL::compileProgram):
(WebCore::FilterContextOpenCL::freeResource):
- platform/graphics/gpu/opencl/FilterContextOpenCL.h:
(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(WebCore::FilterContextOpenCL::setInError):
(WebCore::FilterContextOpenCL::inError):
(FilterContextOpenCL):
(WebCore::FilterContextOpenCL::RunKernel::RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::addArgument):
(WebCore::FilterContextOpenCL::RunKernel::run):
(RunKernel):
- platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:
(WebCore::FilterContextOpenCL::compileFEColorMatrix):
(WebCore::FEColorMatrix::platformApplyOpenCL):
- platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp:
(WebCore::FilterContextOpenCL::compileFETurbulence):
(WebCore::FETurbulence::platformApplyOpenCL):
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
- 1:34 AM Changeset in webkit [142595] by
-
- 22 edits2 adds in trunk/Source
[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-12
Reviewed by Noam Rosenthal.
Source/WebCore:
r142524 implemented frames-per-second debug counter on WK2. This patch
applies frames-per-second debug counter to WK1 also.
Visual debugging feature, no need for new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperFPSCounter.cpp: Added.
(WebCore):
(WebCore::TextureMapperFPSCounter::TextureMapperFPSCounter):
(WebCore::TextureMapperFPSCounter::updateFPSAndDisplay):
- platform/graphics/texmap/TextureMapperFPSCounter.h: Added.
(WebCore):
(TextureMapperFPSCounter):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::TextureMapperGL::drawNumber):
Rename from drawRepaintCounter to drawNumber.
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::TextureMapperImageBuffer::drawNumber):
- platform/graphics/texmap/TextureMapperImageBuffer.h:
(TextureMapperImageBuffer):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStore::drawRepaintCounter):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Move frames-per-second debug counter code to TextureMapperFPSCounter.
(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
Source/WebKit/efl:
Make AcceleratedCompositingContextEfl use TextureMapperFPSCounter.
- WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
(WebCore::AcceleratedCompositingContext::renderLayers):
- WebCoreSupport/AcceleratedCompositingContextEfl.h:
(AcceleratedCompositingContext):
Source/WebKit/gtk:
Make AcceleratedCompositingContext use TextureMapperFPSCounter.
- WebCoreSupport/AcceleratedCompositingContext.h:
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::compositeLayersToContext):
Source/WebKit/qt:
Make TextureMapperLayerClientQt use TextureMapperFPSCounter.
- WebCoreSupport/TextureMapperLayerClientQt.cpp:
(TextureMapperLayerClientQt::renderCompositedLayers):
- WebCoreSupport/TextureMapperLayerClientQt.h:
(TextureMapperLayerClientQt):
- 1:20 AM Changeset in webkit [142594] by
-
- 3 edits4 adds in trunk
Web Inspector: stack trace is cut at native bind if inspector is closed
https://bugs.webkit.org/show_bug.cgi?id=109427
Reviewed by Pavel Feldman.
Source/WebCore:
Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.
Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
LayoutTests:
Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.
- http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
- http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
- platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
- 12:47 AM Changeset in webkit [142593] by
-
- 17 edits12 moves in trunk
[chromium] move webrtc mocks to testrunner library
https://bugs.webkit.org/show_bug.cgi?id=109041
Reviewed by Adam Barth.
Tools:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(main):
- DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
(MockWebKitPlatformSupport::setInterfaces):
(MockWebKitPlatformSupport::createMediaStreamCenter):
(MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
- DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
(WebTestRunner):
(MockWebKitPlatformSupport):
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::showContextMenu):
(WebTestRunner::WebTestProxy::userMediaClient):
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.
(WebTestRunner::MockConstraints::verifyConstraints):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.
(WebKit):
(WebTestRunner):
(MockConstraints):
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.
(WebTestRunner):
(WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
(MockWebAudioDestinationConsumer):
(WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
(WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.
(WebKit):
(WebTestRunner):
(MockWebMediaStreamCenter):
(WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.
(WebTestRunner):
(DTMFSenderToneTask):
(WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
(WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
(WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
(WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
(WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
(WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.
(WebTestRunner):
(MockWebRTCDTMFSenderHandler):
(WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
(WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.
(WebTestRunner):
(DataChannelReadyStateTask):
(WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
(WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
(WebTestRunner::MockWebRTCDataChannelHandler::setClient):
(WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
(WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
(WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
(WebTestRunner::MockWebRTCDataChannelHandler::close):
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.
(WebTestRunner):
(MockWebRTCDataChannelHandler):
(WebTestRunner::MockWebRTCDataChannelHandler::taskList):
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.
(WebTestRunner):
(RTCSessionDescriptionRequestSuccededTask):
(WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCStatsRequestSucceededTask):
(WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(RTCVoidRequestTask):
(WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
(RTCPeerConnectionStateTask):
(WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
(RemoteDataChannelTask):
(WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
(WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
(WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
(WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
(WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
(WebTestRunner::MockWebRTCPeerConnectionHandler::stop):
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.
(WebKit):
(WebTestRunner):
(MockWebRTCPeerConnectionHandler):
(WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
(WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::delegate):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::userMediaClient):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.
(WebTestRunner):
(UserMediaRequestTask):
(WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
(MockExtraData):
(WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
(WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.
(WebTestRunner):
(WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::taskList):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
LayoutTests:
Temporarily disable two WebRTC tests that fail due to a bug in
webkit_support's getCurrentTimeMillsecond.
- platform/chromium/TestExpectations:
- 12:34 AM Changeset in webkit [142592] by
-
- 16 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Mouse click not on sub-fields in multiple fields input should not move focus
https://bugs.webkit.org/show_bug.cgi?id=109544
Reviewed by Kentaro Hara.
Source/WebCore:
This is similar to Bug 108914, "Should not move focus if the element
already has focus." We fixed a focus() case in Bug 108914. However we
still have the problem in a case of focusing by mouse click.
The fix for Bug 108914 intercepted focus() function to change the
behavior. However focus-by-click doesn't call focus(), but calls
FocusController::setFocusedNode. To fix this problem, we introduce
oldFocusedNode argument to handleFocusEvent, and
BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent restores the
focus to oldFocusedNode if oldFocusedNode is one of sub-fields.
handleFocusEvent is called whenever the focused node is changed.
We don't need InputType::willCancelFocus any more because the new code
in handleFocusEvent covers it.
Tests: Update fast/forms/time-multiple-fields/time-multiple-fields-focus.html.
- html/HTMLTextFormControlElement.h:
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add oldFocusedNode argument.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
Pass oldFocusedNode to handleFocusEvent.
- html/HTMLInputElement.h:
(HTMLInputElement):
- Add oldFocusedNode argument to handleFocusEvent.
- Remove focus() override.
- html/HTMLInputElement.cpp: Remove focus() override.
(WebCore::HTMLInputElement::handleFocusEvent):
Pass oldFocusedNode to InputType::handleFocusEvent.
- html/InputType.cpp: Remove willCancelFocus.
(WebCore::InputType::handleFocusEvent):
Add oldFocusedNode argument.
- html/InputType.h:
(InputType): Ditto.
- html/PasswordInputType.cpp:
(WebCore::PasswordInputType::handleFocusEvent): Ditto.
- html/PasswordInputType.h:
(PasswordInputType): Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Remove willCancelFocus, and add oldFocusedNode argument to handleFocusEvent.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
Pass oldFocusedNode to DateTimeEditElement::focusByOwner if the
direction is FocusDirectionNone.
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Add oldFocusedNode argument to focusByOwner.
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::focusByOwner):
If oldFocusedNode is one of sub-fields, focus on it again.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-focus.html:
Add test to click a delimiter.
- 12:07 AM Changeset in webkit [142591] by
-
- 5 edits in trunk/Source/WebCore
[Refactoring] Make m_selectorChecker in StyleResolver an on-stack object.
https://bugs.webkit.org/show_bug.cgi?id=108595
Reviewed by Eric Seidel.
StyleResolver uses SelectorChecker's mode to change its resolving mode.
However it is a state of StyleResolver. StyleResolver should have the
mode and make SelectorChecker instance on a stack while required.
No new tests, just refactoring.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheck):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
Changed to static class function, because these methods never use
"this".
(WebCore):
- css/SelectorChecker.h:
(SelectorChecker):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
Now, matchesFocusPseudoClass is not a static method of
SelectorChecker, so replaced "m_selectorChecker." with
"SelectorChecker::".
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
Use m_mode instead of m_selectorChecker.mode().
Also use document()->inQuirksMode() instead of
m_selectoChecker.strictParsing().
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
Created an on-stack SelectorChecker object and used it to check
selectors.
- css/StyleResolver.h:
(WebCore::StyleResolver::State::State):
Added m_mode, this keeps m_selectorChecker's mode.
(State):
(StyleResolver):
Removed m_selectorChecker.
- 12:03 AM Changeset in webkit [142590] by
-
- 2 edits in trunk/Source/WebKit/chromium
Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
https://bugs.webkit.org/show_bug.cgi?id=109548
Unreviewed gardening.
- tests/WebFrameTest.cpp:
Feb 11, 2013:
- 11:58 PM Changeset in webkit [142589] by
-
- 4 edits in trunk/Tools
webkit-patch upload regenerates the WebCore ChangeLog every time it's called
https://bugs.webkit.org/show_bug.cgi?id=108983
Patch by Timothy Loh <timloh@chromium.com> on 2013-02-11
Reviewed by Ryosuke Niwa.
This patch puts the behaviour from Bug 74358 behind the flag (default=OFF)
--update-changelogs', and removes the flag--no-prepare-changelogs'.
The flag name change from prepare to update is since we still want to
prepare changelogs in the default case when none currently exist.
- Scripts/webkitpy/tool/commands/commandtest.py:
(CommandsTest.assert_execute_outputs):
- Scripts/webkitpy/tool/steps/options.py:
(Options):
- Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog.options):
(PrepareChangeLog.run):
- 11:31 PM Changeset in webkit [142588] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove webintents from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=109537
Unreviewed. webintents tests no longer exist.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
- platform/efl/TestExpectations:
- 11:26 PM Changeset in webkit [142587] by
-
- 4 edits in trunk/Source/WebCore
[Qt][EFL][WebGL] Minor refactoring of GraphicsSurface/GraphicsSurfaceGLX
https://bugs.webkit.org/show_bug.cgi?id=108686
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-11
Reviewed by Noam Rosenthal.
Remove unused platformSurface()/m_platformSurface from GraphicsSurface.
Move m_texture from GraphicsSurface to GLX GraphicsSurfacePrivate to match
Win and Mac implementations.
No new tests, refactoring only.
- platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::GraphicsSurface):
- platform/graphics/surfaces/GraphicsSurface.h:
(GraphicsSurface):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::surface):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::textureID):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformDestroy):
- 11:24 PM Changeset in webkit [142586] by
-
- 4 edits3 adds in trunk
[EFL][WebGL] WebGL content is not painted after resizing the viewport.
https://bugs.webkit.org/show_bug.cgi?id=106358
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-11
Reviewed by Noam Rosenthal.
Source/WebCore:
When page size changes and layer parameters get updated LayerTreeRenderer::setLayerState
clears the layer backing store and detaches the canvas surface from the layer. If the layer
size is not changed then the canvas is not recreated. This leaves the canvas detached from
the layer, but still referenced from m_surfaceBackingStores.
Don't assign layer backing store to layer in assignImageBackingToLayer if there is a canvas
surface already attached to the layer.
Test: fast/canvas/webgl/webgl-layer-update.html
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
LayoutTests:
Add test checking that canvas painting is correct if layer parameters were changed,
but webgl canvas didn't change.
- fast/canvas/webgl/webgl-layer-update-expected.png: Added.
- fast/canvas/webgl/webgl-layer-update-expected.txt: Added.
- fast/canvas/webgl/webgl-layer-update.html: Added.
- 11:19 PM Changeset in webkit [142585] by
-
- 5 edits in trunk/Tools
[chromium] move printPage() implementation to testRunner library
https://bugs.webkit.org/show_bug.cgi?id=109436
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::showContextMenu):
(WebTestRunner::WebTestProxy::printPage):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::printPage):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 10:50 PM Changeset in webkit [142584] by
-
- 2 edits in trunk/LayoutTests
[EFL] Some placeholder paint order tests are passing now
https://bugs.webkit.org/show_bug.cgi?id=109164
Unreviewed efl gardening.
fast/forms/input-placeholder-paint-order.html and
fast/forms/textarea/textarea-placeholder-paint-order.html are passing now.
RenderTheme::shouldShowPlaceholderWhenFocused() returns true by r127723
and the expectations are added by r140149.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
- platform/efl/TestExpectations:
- 10:49 PM Changeset in webkit [142583] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove editing/deleting/deletionUI-single-instance.html from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=109538
Unreviewed. This test is removed by r142559.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
- platform/efl/TestExpectations:
- 10:46 PM Changeset in webkit [142582] by
-
- 7 edits3 deletes in trunk
[Chromium] Get rid of WebAnimationController
https://bugs.webkit.org/show_bug.cgi?id=109235
Patch by James Robinson <jamesr@chromium.org> on 2013-02-11
Reviewed by Benjamin Poulain.
Source/WebKit/chromium:
- public/WebAnimationController.h: Removed.
- public/WebFrame.h:
(WebFrame):
- src/WebAnimationControllerImpl.cpp: Removed.
- src/WebAnimationControllerImpl.h: Removed.
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
Tools:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- 10:42 PM Changeset in webkit [142581] by
-
- 6 edits in trunk/Source
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403
Reviewed by Adam Barth.
Source/Platform:
webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):
- chromium/public/WebUnitTestSupport.h:
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
- 10:30 PM Changeset in webkit [142580] by
-
- 22 edits2 adds in trunk
[Mac] Track language selection should be sticky
https://bugs.webkit.org/show_bug.cgi?id=109466
Reviewed by Dean Jackson.
.:
- Source/autotools/symbols.filter: Export PageGroup::captionPreferences and Page::initGroup.
Source/WebCore:
Choosing a text track from the caption menu should make that track's language the
preferred caption language. Turning captions off from the menu should disable captions
in videos loaded subsequently.
OS X has system support for these settings, so changes made by DRT should not change the
settings on the user's system. Add support for all other ports in DRT only.
Test: media/track/track-user-preferences.html
- WebCore.exp.in: Export PageGroup::captionPreferences().
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Use page()->group().captionPreferences().
(WebCore::HTMLMediaElement::attach): Ditto.
(WebCore::HTMLMediaElement::detach): Ditto.
(WebCore::HTMLMediaElement::userPrefersCaptions): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto. Update for
preferredLanguageFromList change.
(WebCore::HTMLMediaElement::toggleTrackAtIndex): Set user prefs for captions visible and
caption language as appropriate.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Remove unneeded comment.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Use page()->group().captionPreferences().
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::closedCaptionTracksChanged): Update caption menu button visibility.
- page/CaptionUserPreferences.h:
(WebCore::CaptionUserPreferences::userPrefersCaptions): Support "testing" mode.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferences::preferredLanguages): Ditto.
(WebCore::CaptionUserPreferences::testingMode): Ditto.
(WebCore::CaptionUserPreferences::setTestingMode): Ditto.
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Ditto.
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Change name from
registerForCaptionPreferencesChangedCallbacks. Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::unregisterForPreferencesChangedCallbacks): Change name from
unregisterForCaptionPreferencesChangedCallbacks. Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto. Return the platform override when set.
- page/PageGroup.cpp:
(WebCore::PageGroup::registerForCaptionPreferencesChangedCallbacks): Remove because it is already
available from the caption preference object.
(WebCore::PageGroup::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::PageGroup::userPrefersCaptions): Ditto.
(WebCore::PageGroup::userHasCaptionPreferences): Ditto.
(WebCore::PageGroup::captionFontSizeScale): Ditto.
- page/PageGroup.h:
- platform/Language.cpp:
(WebCore::preferredLanguageFromList): Take the list of preferred languages instead of assuming
the system list.
- platform/Language.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Disable caption testing mode.
(WebCore::Internals::Internals): Enable caption testing mode so the user's system
preferences are not modified.
LayoutTests:
- media/track/track-user-preferences-expected.txt: Added.
- media/track/track-user-preferences.html: Added.
- platform/chromium/TestExpectations: Skip new test, it depends on the track menu.
- platform/efl/TestExpectations: Ditto.
- platform/gtk/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 10:26 PM Changeset in webkit [142579] by
-
- 11 edits in trunk/Source
Coordinated Graphics: Make CoordinatedGraphicsScene not know contents size.
https://bugs.webkit.org/show_bug.cgi?id=108922
Source/WebCore:
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Currently, CoordinatedGraphicsScene has two methods to know contents
size: setContentsSize() and setVisibleContentsRect(). Contents size is
used when adjusting a scroll position, but adjustment is not needed
because EFL and Qt platform code (currently PageViewportController)
already adjusts a scroll position, and it is natural for each platform
to be in charge of adjusting. So this patch makes CoordinatedGraphicsScene
not know contents size.
In addition, now DrawingAreaProxy::coordinatedLayerTreeHostProxy() is only used
to get CoordinatedGraphicsScene.
This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html
ManualTests/nested-fixed-position.html
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setScrollPosition):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
Source/WebKit2:
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Benjamin Poulain.
Currently, CoordinatedGraphicsScene has two methods to know contents
size: setContentsSize() and setVisibleContentsRect(). Contents size is
used when adjusting a scroll position, but adjustment is not needed
because EFL and Qt platform code (currently PageViewportController)
already adjusts a scroll position, and it is natural for each platform
to be in charge of adjusting. So this patch makes CoordinatedGraphicsScene
not know contents size.
In addition, now DrawingAreaProxy::coordinatedLayerTreeHostProxy() is only used
to get CoordinatedGraphicsScene.
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::updateSize):
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setSize):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
- 9:29 PM Changeset in webkit [142578] by
-
- 9 edits in trunk/Source
Coordinated Graphics: remove the DidChangeScrollPosition message.
https://bugs.webkit.org/show_bug.cgi?id=108051
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Benjamin Poulain.
Currently, we use the DidChangeScrollPosition message to send the scroll
position that WebCore used in this frame to UI Process. We had to have
some member variables for the DidChangeScrollPosition message.
However, we can send a scroll position via the DidRenderFrame message,
because CoordinatedGraphicsScene::m_renderedContentsScrollPosition is
updated at the moment of flushing. So we can remove the
DidChangeScrollPosition message and some redundant member variables.
Source/WebCore:
No tests. No change in behavior.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::flushLayerChanges):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
Source/WebKit2:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::didRenderFrame):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in: Remove the DidChangeScrollPosition message.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
Send a scroll position via the DidChangeScrollPosition message.
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
Don't send a scroll position because flushPendingLayerChanges() does
that. In addition, it is weird to check if we must send a scroll
position at the moment of sending the SyncLayerState message of every
layers.
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 9:11 PM Changeset in webkit [142577] by
-
- 2 edits in trunk/Source/WTF
Build fix.
- 8:55 PM Changeset in webkit [142576] by
-
- 40 edits in trunk
Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
https://bugs.webkit.org/show_bug.cgi?id=109534
Reviewed by Anders Carlsson.
Source/WebCore:
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::show):
- editing/Editor.cpp:
(WebCore):
- editing/Editor.h:
(Editor):
- loader/EmptyClients.h:
(WebCore::EmptyEditorClient::shouldDeleteRange):
(EmptyEditorClient):
(WebCore::EmptyEditorClient::shouldShowDeleteInterface):
- page/EditorClient.h:
(EditorClient):
Source/WebKit/blackberry:
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore):
- WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
Source/WebKit/chromium:
- src/EditorClientImpl.cpp:
(WebKit):
- src/EditorClientImpl.h:
(EditorClientImpl):
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore):
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit):
- WebCoreSupport/EditorClientGtk.h:
(EditorClient):
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.h:
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore):
- WebCoreSupport/EditorClientQt.h:
(EditorClientQt):
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp:
- WebCoreSupport/WebEditorClient.h:
(WebEditorClient):
Source/WebKit/wince:
- WebCoreSupport/EditorClientWinCE.cpp:
(WebKit):
- WebCoreSupport/EditorClientWinCE.h:
(EditorClientWinCE):
Source/WebKit/wx:
- WebKitSupport/EditorClientWx.cpp:
(WebCore):
- WebKitSupport/EditorClientWx.h:
(EditorClientWx):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Source/WTF:
- wtf/Platform.h:
Tools:
- DumpRenderTree/gtk/EditingCallbacks.cpp:
(shouldShowDeleteInterfaceForElement):
- 8:43 PM Changeset in webkit [142575] by
-
- 7 edits in trunk/Source/WebCore
Factor EventContext and introduces MouseOrFocusEventContext.
https://bugs.webkit.org/show_bug.cgi?id=109278
Reviewed by Dimitri Glazkov.
To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent or FocusEvent,
but also other events.
This is the first attempt to refactor event retargeting code, a
separated patch from bug 109156. EventContext is now factored and
MouseOrFocusEventContext was introduced to support MouseEvent or
FocusEvent separately.
In following patches, I'll introduce TouchEventContext and
TouchEventDispatchMediator to support Touch event retargeting.
No new tests. No change in functionality.
- dom/EventContext.cpp:
(WebCore::EventContext::EventContext): Factor relatedTarget out from EventContext into MouseOrFocusEventContext.
(WebCore::EventContext::~EventContext):
(WebCore):
(WebCore::EventContext::handleLocalEvents):
(WebCore::EventContext::isMouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext): New. Handles MouseEvent's (or FocusEvent's) relatedTarget retargeting.
(WebCore::MouseOrFocusEventContext::~MouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::handleLocalEvents):
(WebCore::MouseOrFocusEventContext::isMouseOrFocusEventContext):
- dom/EventContext.h:
(EventContext):
(WebCore::EventContext::node):
(WebCore::EventContext::target):
(WebCore::EventContext::currentTargetSameAsTarget):
(WebCore):
(MouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::relatedTarget):
(WebCore::MouseOrFocusEventContext::setRelatedTarget):
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventPath): Renamad from ensureEventAncestors. Use the DOM Core terminology.
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):
- dom/EventDispatcher.h:
(EventRelatedTargetAdjuster):
(EventDispatcher):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::eventHasListeners):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDispatchEvent):
- 8:34 PM Changeset in webkit [142574] by
-
- 4 edits in trunk/Source/WebCore
[Curl] setCookiesFromDOM function does not save cookies to disk.
https://bugs.webkit.org/show_bug.cgi?id=109285
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-11
Reviewed by Brent Fulgham.
Write cookies to disk by using the Curl easy api.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::setCookiesFromDOM):Write cookie to disk.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::getCurlShareHandle): Added method to get Curl share handle.
(WebCore::ResourceHandleManager::getCookieJarFileName): Added method to get cookie file name.
- platform/network/curl/ResourceHandleManager.h: Added methods to get cookie file name, and Curl share handle.
- 8:32 PM Changeset in webkit [142573] by
-
- 10 edits2 adds in trunk/Source/WebCore
Split each RuleSet and feature out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107777
Reviewed by Dimitri Glazkov.
Re-landing r141964, which was reverted in r141973, since r141964 seem to be innocent.
No tests. No change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DocumentRuleSets.cpp: Added.
(WebCore):
(WebCore::DocumentRuleSets::DocumentRuleSets):
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle): New helper to initialize each RuleSets.
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets): Factored out from StyleResolver.
(WebCore::makeRuleSet): Ditto.
(WebCore::DocumentRuleSets::resetAuthorStyle): Ditto.
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Ditto.
(WebCore::DocumentRuleSets::collectFeatures): Ditto.
(WebCore::DocumentRuleSets::reportMemoryUsage): New methods to report memory usage. Factored out from StyleResolver.
- css/DocumentRuleSets.h: Added.
(WebCore):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::authorStyle): Moved from StyleResolver.
(WebCore::DocumentRuleSets::userStyle): Ditto.
(WebCore::DocumentRuleSets::features): Ditto.
(WebCore::DocumentRuleSets::sibling): Ditto.
(WebCore::DocumentRuleSets::uncommonAttribute): Ditto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets): Now calls DocumentRuleSets::appendAuthorStyleSheets.
(WebCore::StyleResolver::matchAuthorRules): Use m_ruleSets.
(WebCore::StyleResolver::matchUserRules): Ditto.
(WebCore::StyleResolver::classNamesAffectedByRules): Ditto.
(WebCore::StyleResolver::locateCousinList): Ditto.
(WebCore::StyleResolver::canShareStyleWithElement): Ditto.
(WebCore::StyleResolver::locateSharedStyle): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::checkRegionStyle): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::reportMemoryUsage): Now calls DocumentRuleSets::reportMemoryUsage.
- css/StyleResolver.h:
(WebCore::StyleResolver::scopeResolver):
(StyleResolver):
(WebCore::StyleResolver::ruleSets): accessor r to DocumentRuleSets.
(WebCore::StyleResolver::usesSiblingRules): Use m_ruleSets.
(WebCore::StyleResolver::usesFirstLineRules): Ditto.
(WebCore::StyleResolver::usesBeforeAfterRules): Ditto.
(WebCore::StyleResolver::hasSelectorForAttribute): Ditto.
(WebCore::StyleResolver::hasSelectorForClass): Ditto.
(WebCore::StyleResolver::hasSelectorForId): Ditto.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- 8:24 PM Changeset in webkit [142572] by
-
- 6 edits3 adds in trunk
REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158
Reviewed by Kent Tamura.
Source/WebCore:
The calendar picker button's icon and position where wrong when rtl.
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html
- Resources/pagepopups/calendarPicker.css:
(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.
- Resources/pagepopups/calendarPicker.js:
(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.
- 8:23 PM Changeset in webkit [142571] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Apply page scale to all WebInputEvent types
https://bugs.webkit.org/show_bug.cgi?id=109370
Reviewed by James Robinson.
Previously we only adjusted a few common input event types by page
scale, but in fact almost every position and size in WebInputEvents
requires it.
I also took the opportunity to change some WebGestureEvent members to
floats (which I checked causes no warnings in Chromium-side code with
GCC or Clang).
New WebInputEventConversionTest: InputEventsScaling
- public/WebInputEvent.h:
(WebKit::WebGestureEvent::WebGestureEvent):
- src/WebInputEventConversion.cpp:
(WebKit::widgetScaleFactor):
(WebKit):
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit::WebViewImpl::handleInputEvent):
- tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
(WebCore):
- 8:22 PM Changeset in webkit [142570] by
-
- 2 edits1 delete in trunk/Source/WebCore
REGRESSION (r142549): Remove web intents code
https://bugs.webkit.org/show_bug.cgi?id=109532
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
Reviewed by Nico Weber.
Remove remaning code related to web intents.
No new tests, no change on behavior.
- UseJSC.cmake:
- bindings/js/JSIntentConstructor.cpp: Removed.
- 8:17 PM Changeset in webkit [142569] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r142568.
http://trac.webkit.org/changeset/142568
https://bugs.webkit.org/show_bug.cgi?id=109541
Broke the build, won't compile. (Requested by alancutter on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11
Source/Platform:
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):
- chromium/public/WebUnitTestSupport.h:
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
- 6:50 PM Changeset in webkit [142568] by
-
- 6 edits in trunk/Source
[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403
Reviewed by Adam Barth.
Source/Platform:
webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.
- chromium/public/WebCompositorSupport.h:
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):
- chromium/public/WebUnitTestSupport.h:
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
- 6:38 PM Changeset in webkit [142567] by
-
- 2 edits in trunk/Source/WebCore
Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
https://bugs.webkit.org/show_bug.cgi?id=109127
Reviewed by Dean Jackson.
No new tests. Built and tested WebKit and Chromium with this change.
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore):
Define temporary typedef spanning int -> size_t change.
(WebCore::getValidationResultValue):
(WebCore::getSymbolInfo):
Use temporary typedef.
- 6:38 PM Changeset in webkit [142566] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r181817. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11
- DEPS:
- 6:06 PM Changeset in webkit [142565] by
-
- 5 edits in trunk/Source/WebCore
[V8] ScheduledAction::m_context can be empty, so we shouldn't
retrieve an Isolate by using m_context->GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=109523
Reviewed by Adam Barth.
Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges
Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate().
This can crash because ScheduledAction::m_context can be empty. Specifically,
ScheduledAction::m_context is set to ScriptController::currentWorldContext(),
which can return an empty handle when a frame does not exist. In addition,
'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty.
Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.
No tests. The Chromium crash report doesn't provide enough information
to reproduce the bug.
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore):
(WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/ScheduledAction.h:
(ScheduledAction):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::SetTimeoutOrInterval):
- 5:58 PM Changeset in webkit [142564] by
-
- 3 edits in trunk/Source/WebKit/chromium
IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519
Reviewed by Adam Barth.
- public/WebIDBDatabaseException.h:
- src/AssertMatchingEnums.cpp:
- 5:52 PM Changeset in webkit [142563] by
-
- 4 edits in trunk/Source
Build fix: r142549 broke EFL build
https://bugs.webkit.org/show_bug.cgi?id=109527
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-11
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests, no change on behavior.
- CMakeLists.txt:
Source/WebKit:
Build fix.
- CMakeLists.txt:
- 5:42 PM Changeset in webkit [142562] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Build fix
https://bugs.webkit.org/show_bug.cgi?id=109518
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-11
Reviewed by Laszlo Gombos.
Fix EFL build by including PluginProcessConnectionManager.messages.in in
CMakeLists.txt
- CMakeLists.txt:
- 5:35 PM Changeset in webkit [142561] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r142520?): Space no longer scrolls the page
https://bugs.webkit.org/show_bug.cgi?id=109526
Reviewed by Tim Horton.
ScrollingTree::updateTreeFromStateNode() used to bail early when it had
no children (no fixed or sticky elements), but that left updateAfterChildren()
uncalled. Fix by always calling updateAfterChildren(), which updates the scroll
position.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
- 5:31 PM Changeset in webkit [142560] by
-
- 2 edits in trunk/Source/WebCore
Remove extra early-return in FrameView::setScrollPosition
Rubber-stamped by Simon Fraser.
- page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
- 5:31 PM Changeset in webkit [142559] by
-
- 6 edits3 moves4 deletes in trunk/LayoutTests
Move deletionUI tests into platform/mac
https://bugs.webkit.org/show_bug.cgi?id=109517
Reviewed by Benjamin Poulain.
Moved deletionUI tests into platform/mac since Mac is the only port that ships this feature.
- editing/deleting/5408255-expected.txt: Removed.
- editing/deleting/5408255.html: Removed.
- editing/deleting/deletionUI-single-instance.html: Removed.
- platform/chromium/editing/deleting/deletionUI-single-instance-expected.png: Removed.
- platform/chromium/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/mac/editing/deleting/deletionUI-click-on-delete-button-expected.txt: Copied from LayoutTests/editing/deleting/5408255-expected.txt.
- platform/mac/editing/deleting/deletionUI-click-on-delete-button.html: Copied from LayoutTests/editing/deleting/5408255.html.
- platform/mac/editing/deleting/deletionUI-single-instance.html: Copied from LayoutTests/editing/deleting/deletionUI-single-instance.html.
- platform/qt-mac/TestExpectations:
- platform/qt/editing/deleting/deletionUI-single-instance-expected.png: Removed.
- platform/qt/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 5:29 PM Changeset in webkit [142558] by
-
- 2 edits in trunk/Source/WebCore
[Microdata] Fix crash after r141034 in chromuim port
https://bugs.webkit.org/show_bug.cgi?id=109514
Reviewed by Ryosuke Niwa.
Added V8SkipVTableValidation extended attribute to skip
VTable validation check for DOMSettableTokenList interface.
This patch fixes below test failures:
Tests: fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html
fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html
fast/dom/MicroData/element-with-empty-itemprop.html
fast/dom/MicroData/itemprop-add-remove-tokens.html
fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
fast/dom/MicroData/itemprop-must-be-read-only.html
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
fast/dom/MicroData/itemref-add-remove-tokens.html
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
fast/dom/MicroData/itemref-must-be-read-only.html
fast/dom/MicroData/itemtype-add-remove-tokens.html
fast/dom/MicroData/itemtype-attribute-test.html
fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html
fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html
fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html
fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html
- html/DOMSettableTokenList.idl:
- 5:20 PM Changeset in webkit [142557] by
-
- 4 edits in trunk/Source/JavaScriptCore
Make JSC API more NULL tolerant
https://bugs.webkit.org/show_bug.cgi?id=109515
Reviewed by Mark Hahnenberg.
We do so much marshalling for the C API these days anyway that a single null
check isn't a performance issue. Yet the existing "null is unsafe" behaviour
leads to crashes in embedding applications whenever there's an untested code
path, so it seems having defined behaviour is superior.
- API/APICast.h:
(toJS):
(toJSForGC):
- API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):
- API/tests/testapi.c:
(main):
- 5:09 PM Changeset in webkit [142556] by
-
- 3 edits in trunk/Source/WebKit2
Fix build.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.cpp:
- 5:07 PM Changeset in webkit [142555] by
-
- 8 edits2 adds in trunk
Load event fires too early with threaded HTML parser (take 2)
https://bugs.webkit.org/show_bug.cgi?id=109485
Reviewed by Eric Seidel.
Source/WebCore:
This patch restores the code that was removed in
http://trac.webkit.org/changeset/142492 and adds code to
DocumentLoader.cpp to avoid the regression.
- dom/Document.cpp:
(WebCore::Document::hasActiveParser):
(WebCore::Document::decrementActiveParserCount):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense):
LayoutTests:
This patch also fixes a bug whereby removing an iframe during the load
event would trigger DumpRenderTree to dump the test in the middle of
the load event. We now wait until the load event is over.
- compositing/iframes/remove-iframe-crash-expected.txt:
- fast/frames/iframe-access-screen-of-deleted-expected.txt:
- fast/frames/remove-frame-during-load-event-expected.txt: Added.
- fast/frames/remove-frame-during-load-event.html: Added.
- http/tests/misc/xslt-bad-import-expected.txt:
- 5:05 PM Changeset in webkit [142554] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, adding a FIXME to remind ourselves of a bug.
https://bugs.webkit.org/show_bug.cgi?id=109487
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
- 4:55 PM Changeset in webkit [142553] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Build fix.
https://bugs.webkit.org/show_bug.cgi?id=109516
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-11
Reviewed by Csaba Osztrogonác.
PluginProcessConnectionManagerMessages are omitted from messages list.
- GNUmakefile.list.am:
- 4:53 PM Changeset in webkit [142552] by
-
- 7 edits in trunk/Source/WebCore
Fold HTMLTokenizerState back into HTMLTokenizer now that MarkupTokenizerBase is RFG
https://bugs.webkit.org/show_bug.cgi?id=109502
Reviewed by Tony Gentilcore.
Just a search replace of HTMLTokenizerState with HTMLTokenizer and moving the enum.
This restores us to the peacefull world pre-NEW_XML.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::forcePlaintextForTextDocument):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLTokenizer.cpp:
(WebCore::isEndTagBufferingState):
(WebCore):
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushEmitAndResumeIn):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):
- html/parser/HTMLTokenizer.h:
(HTMLTokenizer):
(WebCore::HTMLTokenizer::create):
(WebCore::HTMLTokenizer::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::emitEndOfFile):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/parser/TextViewSourceParser.cpp:
(WebCore::TextViewSourceParser::TextViewSourceParser):
- 4:49 PM Changeset in webkit [142551] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r181787. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11
- DEPS:
- 4:46 PM Changeset in webkit [142550] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r142528
https://bugs.webkit.org/show_bug.cgi?id=109520
Reviewed by Eric Seidel.
r142528 changed GIFImageReader from a struct to a class.
We also need to fix a forward declaration.
No tests.
- platform/image-decoders/gif/GIFImageDecoder.h:
- 4:39 PM Changeset in webkit [142549] by
-
- 40 edits52 deletes in trunk
Remove web intents code
https://bugs.webkit.org/show_bug.cgi?id=109501
Reviewed by Eric Seidel.
See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.
Source/WebCore:
- DerivedSources.make:
- Modules/intents/DOMWindowIntents.cpp: Removed.
- Modules/intents/DOMWindowIntents.h: Removed.
- Modules/intents/DOMWindowIntents.idl: Removed.
- Modules/intents/DeliveredIntent.cpp: Removed.
- Modules/intents/DeliveredIntent.h: Removed.
- Modules/intents/DeliveredIntent.idl: Removed.
- Modules/intents/Intent.cpp: Removed.
- Modules/intents/Intent.h: Removed.
- Modules/intents/Intent.idl: Removed.
- Modules/intents/IntentRequest.cpp: Removed.
- Modules/intents/IntentRequest.h: Removed.
- Modules/intents/IntentResultCallback.h: Removed.
- Modules/intents/IntentResultCallback.idl: Removed.
- Modules/intents/NavigatorIntents.cpp: Removed.
- Modules/intents/NavigatorIntents.h: Removed.
- Modules/intents/NavigatorIntents.idl: Removed.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- bindings/v8/custom/V8IntentCustom.cpp: Removed.
- html/HTMLElementsAllInOne.cpp:
- html/HTMLIntentElement.cpp: Removed.
- html/HTMLIntentElement.h: Removed.
- html/HTMLIntentElement.idl: Removed.
- loader/EmptyClients.cpp:
- loader/EmptyClients.h:
(EmptyFrameLoaderClient):
- loader/FrameLoaderClient.h:
(WebCore):
- page/DOMWindow.idl:
Source/WebKit/chromium:
- WebKit.gyp:
- features.gypi:
- public/WebDeliveredIntentClient.h: Removed.
- public/WebFrame.h:
(WebKit):
(WebFrame):
- public/WebFrameClient.h:
(WebKit):
- public/WebIntent.h: Removed.
- public/WebIntentRequest.h: Removed.
- public/WebIntentServiceInfo.h: Removed.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/DeliveredIntentClientImpl.cpp: Removed.
- src/DeliveredIntentClientImpl.h: Removed.
- src/FrameLoaderClientImpl.cpp:
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebKit):
(WebFrameImpl):
- src/WebIntent.cpp: Removed.
- src/WebIntentRequest.cpp: Removed.
- src/WebIntentServiceInfo.cpp: Removed.
- src/WebRuntimeFeatures.cpp:
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::didEndEditing):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- webintents/intent-tag-expected.txt: Removed.
- webintents/intent-tag.html: Removed.
- webintents/resources/pass.html: Removed.
- webintents/resources/web-intents-reload-orig.html: Removed.
- webintents/resources/web-intents-testing.js: Removed.
- webintents/web-intents-api-expected.txt: Removed.
- webintents/web-intents-api.html: Removed.
- webintents/web-intents-delivery-expected.txt: Removed.
- webintents/web-intents-delivery-reuse-expected.txt: Removed.
- webintents/web-intents-delivery-reuse.html: Removed.
- webintents/web-intents-delivery.html: Removed.
- webintents/web-intents-failure-expected.txt: Removed.
- webintents/web-intents-failure.html: Removed.
- webintents/web-intents-invoke-expected.txt: Removed.
- webintents/web-intents-invoke-port-expected.txt: Removed.
- webintents/web-intents-invoke-port.html: Removed.
- webintents/web-intents-invoke.html: Removed.
- webintents/web-intents-obj-constructor-expected.txt: Removed.
- webintents/web-intents-obj-constructor.html: Removed.
- webintents/web-intents-reload-expected.txt: Removed.
- webintents/web-intents-reload.html: Removed.
- webintents/web-intents-reply-expected.txt: Removed.
- webintents/web-intents-reply.html: Removed.
- 4:36 PM Changeset in webkit [142548] by
-
- 1 edit2 adds in trunk/LayoutTests
SVG DOM manipulation crash
https://bugs.webkit.org/show_bug.cgi?id=108709
Reviewed by Eric Seidel.
Adding a test for the case where an SVG <use> tree is rebuild due to
one event listener and a subsequent listener tries to access it. This
does not crash in WebKit but has caused problems in browser code where
the listener tries to access and use toNode on the target of the
event. The test prevents regressions and gives automated security
tests something to work on.
- svg/custom/use-listener-append-crash-expected.txt: Added.
- svg/custom/use-listener-append-crash.html: Added.
- 4:33 PM Changeset in webkit [142547] by
-
- 2 edits in trunk/Source/WebCore
Fix Mac build after http://trac.webkit.org/changeset/142535.
Unreviewed build fix.
- html/parser/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
- 4:32 PM Changeset in webkit [142546] by
-
- 2 edits in trunk/Source/WebCore
Make WebCore Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109324
Patch by David Farler <dfarler@apple.com> on 2013-02-11
Reviewed by Sam Weinig.
- WebCore.xcodeproj/project.pbxproj: Pass SDKROOT to make for DerivedSources.make
- 4:31 PM Changeset in webkit [142545] by
-
- 2 edits in trunk/Source/WebCore
WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
https://bugs.webkit.org/show_bug.cgi?id=109508
Reviewed by Kenneth Russell.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension): Check whether the extension support is there before returning the extension pointer.
- 4:29 PM Changeset in webkit [142544] by
-
- 15 edits6 adds in trunk
Strange bug in DFG OSR in JSC
https://bugs.webkit.org/show_bug.cgi?id=109491
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Int32ToDouble was being injected after a side-effecting operation and before a SetLocal. Anytime we
inject something just before a SetLocal we should be aware that the previous operation may have been
a side-effect associated with the current code origin. Hence, we should use a forward exit.
Int32ToDouble does not do forward exits by default.
This patch adds a forward-exiting form of Int32ToDouble, for use in SetLocal Int32ToDouble injections.
Changed the CSE and other things to treat these nodes identically, but for the exit strategy to be
distinct (Int32ToDouble -> backward, ForwardInt32ToDouble -> forward). The use of the NodeType for
signaling exit direction is not "great" but it's what we use in other places already (like
ForwardCheckStructure).
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
LayoutTests:
Reviewed by Mark Hahnenberg.
Added one version of the test (dfg-int32-to-double-on-set-local-and-exit) that is based
exactly on Gabor's original test, and another that ought to fail even if I fix other bugs
in the future (see https://bugs.webkit.org/show_bug.cgi?id=109511).
- fast/js/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Added.
- fast/js/dfg-int32-to-double-on-set-local-and-exit.html: Added.
- fast/js/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Added.
- fast/js/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Added.
- fast/js/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Added.
(checkpoint):
(func1):
(func2):
(func3):
(test):
- fast/js/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Added.
(checkpoint):
(func1):
(func2):
(func3):
(test):
- 4:27 PM Changeset in webkit [142543] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 4:21 PM Changeset in webkit [142542] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] setMinimumLayoutWidth should bail if there's no WebProcess
https://bugs.webkit.org/show_bug.cgi?id=109512
<rdar://problem/13093627>
Reviewed by Anders Carlsson.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMinimumLayoutWidth):
- 4:10 PM Changeset in webkit [142541] by
-
- 1 copy in branches/safari-534.59-branch
New Branch.
- 4:08 PM Changeset in webkit [142540] by
-
- 5 edits in trunk/Source/WebKit2
PluginProcessConnectionManager should be a QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109496
Reviewed by Andreas Kling.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::didReceiveMessageOnConnectionWorkQueue):
(WebKit):
(WebKit::PluginProcessConnectionManager::didCloseOnConnectionWorkQueue):
- WebProcess/Plugins/PluginProcessConnectionManager.h:
(PluginProcessConnectionManager):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- WebProcess/WebProcess.h:
(WebProcess):
- 4:07 PM Changeset in webkit [142539] by
-
- 3 edits2 adds in trunk
Change RenderFrameSet::paint to use m-rows/m_cols directly.
https://bugs.webkit.org/show_bug.cgi?id=108503
Source/WebCore:
Reviewed by Eric Seidel.
Test: fast/frames/invalid-frameset.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paint):
LayoutTests:
Reviewed by Eric Seidel.
Add test for how we render an invalid frameset.
- fast/frames/invalid-frameset-expected.html: Added.
- fast/frames/invalid-frameset.html: Added.
- 4:01 PM Changeset in webkit [142538] by
-
- 2 edits in trunk/Source/WebCore
XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary
https://bugs.webkit.org/show_bug.cgi?id=105348
Reviewed by Alexey Proskuryakov.
Let resume() clear the defer flag and return if there is deferred events to dispatch.
No new tests as this should not affect existing cross-platform behavior. It should be
OK as long as it doesn't break anything.
- xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::resume):
- 3:54 PM Changeset in webkit [142537] by
-
- 2 edits in trunk/Source/WTF
[iOS] Upstream changes to Platform.h
<http://webkit.org/b/109459>
Reviewed by Benjamin Poulain.
- wtf/Platform.h:
- Changes for armv7s.
- Add ENABLE() definitions for DASHBOARD_SUPPORT and WEBGL.
- Re-sort USE() macros.
- Remove ENABLE() macros for JIT, LLINT and YARR_JIT to enable on iOS Simulator. They are already defined below.
- Turn off HAVE(HOSTED_CORE_ANIMATION) for iOS.
- Turn on USE(COREMEDIA) for iOS 6.0 and later.
- 3:53 PM Changeset in webkit [142536] by
-
- 3 edits in trunk/Source/WTF
Harden FastMalloc (again)
https://bugs.webkit.org/show_bug.cgi?id=109334
Reviewed by Mark Hahnenberg.
Re-implement hardening of linked lists in TCMalloc.
In order to keep heap introspection working, we need to thread the
heap entropy manually as the introspection process can't use the
address of a global in determining the mask. Given we now have to
thread a value through anyway, I've stopped relying on ASLR for entropy
and am simply using arc4random() on darwin, and time + ASLR everywhere
else.
I've also made an explicit struct type for the FastMalloc singly linked
lists, as it seemed like the only way to reliably distinguish between
void*'s that were lists vs. void* that were not. This also made it
somewhat easier to reason about things across processes.
Verified that all the introspection tools work as expected.
- wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(HardenedSLL):
(WTF::HardenedSLL::create):
(WTF::HardenedSLL::null):
(WTF::HardenedSLL::setValue):
(WTF::HardenedSLL::value):
(WTF::HardenedSLL::operator!):
(WTF::HardenedSLL::operator UnspecifiedBoolType):
(TCEntry):
(WTF::SLL_Next):
(WTF::SLL_SetNext):
(WTF::SLL_Push):
(WTF::SLL_Pop):
(WTF::SLL_PopRange):
(WTF::SLL_PushRange):
(WTF::SLL_Size):
(PageHeapAllocator):
(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::Delete):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::Span::next):
(WTF::Span::remoteNext):
(WTF::Span::prev):
(WTF::Span::setNext):
(WTF::Span::setPrev):
(Span):
(WTF::DLL_Init):
(WTF::DLL_Remove):
(WTF::DLL_IsEmpty):
(WTF::DLL_Length):
(WTF::DLL_Prepend):
(TCMalloc_Central_FreeList):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(WTF::TCMalloc_Central_FreeList::entropy):
(TCMalloc_PageHeap):
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::ReturnedBytes):
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::TCMalloc_PageHeap::ReleaseFreeList):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Init):
(WTF::TCMalloc_ThreadCache_FreeList::empty):
(WTF::TCMalloc_ThreadCache_FreeList::Push):
(WTF::TCMalloc_ThreadCache_FreeList::PushRange):
(WTF::TCMalloc_ThreadCache_FreeList::PopRange):
(WTF::TCMalloc_ThreadCache_FreeList::Pop):
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects):
(TCMalloc_ThreadCache):
(WTF::TCMalloc_Central_FreeList::Init):
(WTF::TCMalloc_Central_FreeList::ReleaseListToSpans):
(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):
(WTF::TCMalloc_Central_FreeList::InsertRange):
(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):
(WTF::TCMalloc_Central_FreeList::FetchFromSpans):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Init):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::FetchFromCentralCache):
(WTF::TCMalloc_ThreadCache::ReleaseToCentralCache):
(WTF::TCMalloc_ThreadCache::InitModule):
(WTF::TCMalloc_ThreadCache::NewHeap):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/MallocZoneSupport.h:
(RemoteMemoryReader):
- 3:52 PM Changeset in webkit [142535] by
-
- 10 edits1 delete in trunk/Source/WebCore
Fold MarkupTokenizerBase into HTMLTokenizer now that it is the only subclass
https://bugs.webkit.org/show_bug.cgi?id=109499
Reviewed by Adam Barth.
For great justice. And sanity.
Epic amount of template code deleted.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::HTMLTokenizer):
- html/parser/HTMLTokenizer.h:
(HTMLTokenizer):
(Checkpoint):
(WebCore::HTMLTokenizer::state):
(WebCore::HTMLTokenizer::setState):
(WebCore::HTMLTokenizer::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::bufferCharacter):
(WebCore::HTMLTokenizer::emitAndResumeIn):
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
(WebCore::HTMLTokenizer::emitEndOfFile):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):
- xml/parser/MarkupTokenizerBase.h: Removed.
- 3:48 PM Changeset in webkit [142534] by
-
- 2 edits in trunk/Source/WebCore
[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
https://bugs.webkit.org/show_bug.cgi?id=109054
Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.
For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-11
Reviewed by Julien Chaffraix.
No behavioral changes thus no new tests or test changes.
- rendering/TextAutosizer.cpp:
(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):
Remember narrow descendants of the parent cluster for later processing.
- 3:47 PM Changeset in webkit [142533] by
-
- 15 edits in trunk/Source
Source/WebCore: Add ENABLE_DELETION_UI to control the use of the deletion UI.
https://bugs.webkit.org/show_bug.cgi?id=109463.
Reviewed by Ryosuke Niwa.
This patch adds #if ENABLE(DELETION_UI) in every spot where
DeleteButtonController is used. This class is now only instantiated
if the feature is enabled. I've also done some cleanup in the
DeleteButtonController class, removing unused methods and making
private some methods only used internally to the class.
Both DeleteButtonController and DeleteButton classes are now excluded
from the compilation if the feature is not enabled.
No new tests, no change of functionality.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):
- editing/DeleteButton.cpp:
- editing/DeleteButtonController.cpp:
- editing/DeleteButtonController.h: Some cleanup.
(WebCore::DeleteButtonController::enabled): Made private.
- editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand):
- editing/Editor.cpp:
(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::Editor):
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::deviceScaleFactorChanged):
- editing/Editor.h:
- editing/htmlediting.cpp: avoidIntersectionWithNode is
used only if the feature is enabled.
- editing/htmlediting.h:
- editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::createFragmentFromNodes):
- rendering/RenderTable.cpp: Removed unnecessary include
fo DeleteButtonController.h
Source/WTF: Add ENABLE_DELETION_UI to control the use of the deletion UI.
https://bugs.webkit.org/show_bug.cgi?id=109463.
ENABLE_DELETION_UI is set to 1 by default for
all ports. It is explicitly enabled for MAC and disabled for iOS.
Reviewed by Ryosuke Niwa.
- wtf/Platform.h:
- 3:42 PM Changeset in webkit [142532] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed WK2 buildfix after r142518.
- DerivedSources.pri:
- 3:34 PM Changeset in webkit [142531] by
-
- 5 edits in trunk
[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338
Reviewed by Adam Barth.
Source/WebCore:
This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.
Tests added to html5lib.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):
- html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
LayoutTests:
- html5lib/resources/template.dat:
- 3:34 PM Changeset in webkit [142530] by
-
- 8 edits in trunk/Source/JavaScriptCore
NonStringCell and Object are practically the same thing for the purpose of speculation
https://bugs.webkit.org/show_bug.cgi?id=109492
Reviewed by Mark Hahnenberg.
Removed isNonStringCellSpeculation, and made all callers use isObjectSpeculation.
Changed isNonStringCellOrOtherSpeculation to be isObjectOrOtherSpeculation.
I believe this is correct because even weird object types like JSNotAnObject end up
being "objects" from the standpoint of our typesystem. Anyway, the assumption that
"is cell but not a string" equates to "object" is an assumption that is already made
in other places in the system so there's little value in being paranoid about it.
- bytecode/SpeculatedType.h:
(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::shouldSpeculateObjectOrOther):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- 3:28 PM Changeset in webkit [142529] by
-
- 2 edits in trunk/Source/WebCore
RenderText::isAllCollapsibleWhitespace() shouldn't upconvert string to 16-bit.
<http://webkit.org/b/109354>
Reviewed by Eric Seidel.
254 KB progression on Membuster3.
- rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace):
- 3:21 PM Changeset in webkit [142528] by
-
- 4 edits in trunk/Source/WebCore
Fix code style violations in GIFImageReader.{cc|h}
https://bugs.webkit.org/show_bug.cgi?id=109007
Reviewed by Stephen White.
This is just a style clean up for GIFImageReader.{cc|h}.
There's going to be a lot changes in these two files and style check
will add a lot of noise in later reviews. Fix style problems first.
There is no change in logic at all. Just style fixes.
No new tests.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::outputRow):
(GIFImageReader::doLZW):
(GIFImageReader::read):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader):
(GIFImageReader::imagesCount):
(GIFImageReader::loopCount):
(GIFImageReader::globalColormap):
(GIFImageReader::globalColormapSize):
(GIFImageReader::frameContext):
- 3:17 PM Changeset in webkit [142527] by
-
- 15 edits2 adds in trunk
[CSS Exclusions] Handle shape-outside changing a float's overhang behavior
https://bugs.webkit.org/show_bug.cgi?id=106927
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-02-11
Reviewed by Julien Chaffraix.
Source/WebCore:
When the position on a shape outside causes a float to spill out into
another block than it's container, it was not being drawn correctly. It
became apparent that in order to fix this properly, the approach to
positioning shape outsides and floats needed to be changed. The new
approach also fixes some other outstanding issues, like hit detection.
When a float has a shape outside, inline and float layout happens
using the exclusion shape bounds instead of the float's box. The
effect of this is that the float itself no longer has any effect on
layout, both with respect to positioning of the float's siblings as
well as positioning the float's box. This means that when the float is
positioned, it is the shape's box that must obey the positioning rules
for floats. When the shape is given a position relative to the float's
box, the rules for float positioning determine where the shape sits
in the parent, causing the float's box to be offset by the position of
the shape. Since the float's box does not affect layout (due to the
shape), this is similar to relative positioning in that the offset is
a paint time occurrence.
So the new approach is to implement positioning of shape outside on
floats similar to how relative positioning is implemented, using a
RenderLayer.
This is also tested by the existing tests for shape outside on floats positioning.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html
- rendering/ExclusionShapeOutsideInfo.h:
(WebCore::ExclusionShapeOutsideInfo::shapeLogicalOffset): Utility method to create a LayoutSize for computing the layer offset.
(ExclusionShapeOutsideInfo):
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Check for floats with shape outside as well as in flow positioning.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::flipFloatForWritingModeForChild): Remove old positioning implementation.
(WebCore::RenderBlock::paintFloats): Remove old positioning implementation.
(WebCore::RenderBlock::blockSelectionGaps): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBlock::positionNewFloats): Remove old positioning implementation.
(WebCore::RenderBlock::addOverhangingFloats): Remove FIXME.
(WebCore::positionForPointRespectingEditingBoundaries): Check for floats with shape outside as well as in flow positioning.
- rendering/RenderBlock.h:
(RenderBlock): Remove old positioning implementation.
(WebCore::RenderBlock::xPositionForFloatIncludingMargin): Remove old positioning implementation.
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Remove old positioning implementation.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::offsetFromContainer): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::computeRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Check for floats with shape outside as well as in flow positioning.
- rendering/RenderBox.h: Make floats with shape outside get a layer.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintOffset): Method to return in flow
positioning offset + offset from shape outside on floats.
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject): Add paintOffset method.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderInline::computeRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderInline::mapLocalToContainer): Check for floats with shape outside as well as in flow positioning.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderLayer::calculateClipRects): Check for floats with shape outside as well as in flow positioning.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::paintOffset): Rename offsetForInFlowPosition to reflect that it's not just for
in flow positioning, it also reflects shape outside position on floats.
(RenderLayer):
- rendering/RenderObject.h:
(WebCore::RenderObject::hasPaintOffset): Determines if this object is in flow positioined or is a float with shape outside.
- rendering/style/RenderStyle.h: Add hasPaintOffset method, analagous to method with same name on RenderObject.
LayoutTests:
This is also tested by the existing tests for shape outside on floats positioning.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overhang-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html: Added.
- 3:13 PM Changeset in webkit [142526] by
-
- 7 edits2 adds in trunk
FrameView::setScrollPosition should clamp scroll position before handing it to
ScrollingCoordinator instead of depending on ScrollView to do this
https://bugs.webkit.org/show_bug.cgi?id=109497
<rdar://problem/12631789>
Reviewed by Simon Fraser.
Clamp scroll position before handing it to ScrollingCoordinator. Also, like ScrollView does,
bail out if we've already scrolled to the clamped scroll position.
Test: platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html
- page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
Adjust some test results which previously expected out-of-bounds scrolling to happen.
Add a test that ensures that out-of-bounds scrolling doesn't happen.
- platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html: Added.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- 3:11 PM Changeset in webkit [142525] by
-
- 3 edits2 adds in trunk
The threaded HTML parser should pass all the fast/parser tests
https://bugs.webkit.org/show_bug.cgi?id=109486
Reviewed by Tony Gentilcore.
Source/WebCore:
This patch fixes the last two test failures in fast/parser, which were
crashes caused by not having a tokenizer when document.close() was
called. (The tokenizer is created lazily by calls to document.write,
which might not happen before document.close).
fast/parser/document-close-iframe-load.html
fast/parser/document-close-nested-iframe-load.html
In addition, I've added a new test to make sure we flush the tokenizer
properly in these cases.
Test: fast/parser/document-close-iframe-load-partial-entity.html
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):
LayoutTests:
- fast/parser/document-close-iframe-load-partial-entity-expected.txt: Added.
- fast/parser/document-close-iframe-load-partial-entity.html: Added.
- 3:07 PM Changeset in webkit [142524] by
-
- 3 edits in trunk/Source/WebCore
[texmap] Implement frames-per-second debug counter
https://bugs.webkit.org/show_bug.cgi?id=107942
Reviewed by Noam Rosenthal.
Adds FPS counter via WEBKIT_SHOW_FPS=<interval> environment variable,
where <interval> is the period in seconds (i.e. =1.5) between FPS
updates on screen. It is measured by counting
CoordinatedGraphicsScene::paintTo* calls and is painted using
drawRepaintCounter() after TextureMapperLayer has finished painting its
contents.
Visual debugging feature, no need for new tests.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
(WebCore::CoordinatedGraphicsScene::updateFPS):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
- 3:00 PM Changeset in webkit [142523] by
-
- 6 edits in trunk/LayoutTests
Unreviewed Chromium rebaselining after r142500.
- platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
- platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
- platform/chromium-mac/fast/repaint/selection-after-remove-expected.png:
- platform/chromium-win/fast/repaint/selection-after-remove-expected.png:
Slight painting regression that brings us back to pre-r132591 baselines.
- 3:00 PM Changeset in webkit [142522] by
-
- 11 edits1 delete in trunk/Source/WebCore
Fold MarkupTokenBase into HTMLToken now that it has no other subclasses
https://bugs.webkit.org/show_bug.cgi?id=109483
Reviewed by Adam Barth.
This deletes an epic amount of template yuck, as well as removes
a vtable !?! from HTMLToken.
This paves the way for further cleanup of HTMLToken now that we
can see the whole object at once.
We'll also probably re-create an HTMLToken.cpp again, now that we're
free from the chains of template nonsense.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/HTMLToken.h:
(WebCore::findAttributeInVector):
(WebCore):
(HTMLToken):
(Attribute):
(Range):
(WebCore::HTMLToken::HTMLToken):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::setBaseOffset):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::isAll8BitData):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):
- html/parser/HTMLTokenTypes.h:
- html/parser/XSSAuditor.h:
- xml/parser/MarkupTokenBase.h: Removed.
- 2:58 PM Changeset in webkit [142521] by
-
- 7 edits in trunk/Source
PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>
Reviewed by Brady Eidson.
Source/WebCore:
This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
- Initialize m_lowMemoryHandler to releaseMemory.
(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOff):
- Cleaned up spacing.
(WebCore::MemoryPressureHandler::releaseMemory):
- Added null implementation for non-Mac builds.
- platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::setLowMemoryHandler):
- Added method to set m_lowMemoryHandler.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
- Changed to call releaseMemory via m_lowMemoryHandler.
Source/WebKit2:
PluginProcess now installs a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::lowMemoryHandler):
- Custom callback to terminate if appropriate.
(WebKit::PluginProcess::initializeProcess):
- Install the MemoryPressureHandler.
(WebKit::PluginProcess::shouldTerminate):
- This method now also needs to be callable in situations where it might return false.
- PluginProcess/PluginProcess.h:
(PluginProcess):
- Added declaration for lowMemoryHandler.
- 2:57 PM Changeset in webkit [142520] by
-
- 13 edits in trunk/Source/WebCore
REGRESSION (r133807): Sticky-position review bar on bugzilla review page is jumpy
https://bugs.webkit.org/show_bug.cgi?id=104276
<rdar://problem/12827187>
Reviewed by Tim Horton.
When committing new scrolling tree state, if the root node has a scroll
position update, we would handle that before updating the state of child
nodes (with possibly new viewport constraints). That would cause incorrect
child layer updates.
Fix by adding a second 'update' phase that happens after child nodes,
and moving the scroll position update into that.
Scrolling tests only dump the state tree, so cannot test the bug.
- page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition): If the scroll position didn't
actually change, don't request a scroll position update from the ScrollingCoordinator.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode): Keep track of the scrolling node so
that we can call updateAfterChildren() on it.
- page/scrolling/ScrollingTreeNode.h:
(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::updateAfterChildren):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(ScrollingTreeScrollingNode):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
In the current bug the scrolling tree was scheduled for commit because of a
scroll position request, but if only the viewport constraints change, we also need
to commit the tree.
- page/scrolling/mac/ScrollingTreeFixedNode.h:
(ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::updateBeforeChildren):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
(ScrollingTreeScrollingNodeMac):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::updateAfterChildren): Move code here
that updates things that have to happen after children.
- page/scrolling/mac/ScrollingTreeStickyNode.h:
(ScrollingTreeStickyNode):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::updateBeforeChildren):
- 2:47 PM Changeset in webkit [142519] by
-
- 2 edits in trunk/Source/WebKit/win
Build fix for Windows after r142509
- WebKit.vcproj/WebKitExports.def.in:
- 2:40 PM Changeset in webkit [142518] by
-
- 9 edits1 add in trunk/Source/WebKit2
Move the PluginProcessCrashed message to PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=109493
Reviewed by Andreas Kling.
This is in preparation for making PluginProcessConnectionManager a connection queue client.
- DerivedSources.make:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didClose):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
- WebProcess/Plugins/PluginProcessConnectionManager.h:
(PluginProcessConnectionManager):
- WebProcess/Plugins/PluginProcessConnectionManager.messages.in: Added.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
(WebKit::WebProcess::webResourceLoadScheduler):
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/WebProcess.messages.in:
- 2:33 PM Changeset in webkit [142517] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Build fix for Win7 Release.
Because of InspectorAllInOne.cpp static globals must be named differently in files included by InspectorAllInOne.
This was the case for UserInitiatedProfileName. Also removed the repeated HeapProfileType definition in
InspectorHeapProfilerAgent.cpp since it wasn't being used anyways.
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
- 2:24 PM Changeset in webkit [142516] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r181770.
- DEPS:
- 2:23 PM Changeset in webkit [142515] by
-
- 9 edits in trunk/Source/JavaScriptCore
DFG CompareEq(a, null) and CompareStrictEq(a, const) are unsound with respect to constant folding
https://bugs.webkit.org/show_bug.cgi?id=109387
Reviewed by Oliver Hunt and Mark Hahnenberg.
Lock in the decision to use a non-speculative constant comparison as early as possible
and don't let the CFA change it by folding constants. This might be a performance
penalty on some really weird code (FWIW, I haven't seen this on benchmarks), but on
the other hand it completely side-steps the unsoundness that the bug speaks of.
Rolling back in after adding 32-bit path.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::isConstantForCompareStrictEq):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:22 PM Changeset in webkit [142514] by
-
- 2 edits in trunk/Source/WebCore
SegmentedString's copy ctor should copy all fields
https://bugs.webkit.org/show_bug.cgi?id=109477
Reviewed by Adam Barth.
This fixes http/tests/inspector-enabled/document-write.html (and likely others) for the threaded HTML parser.
No new tests because covered by existing tests.
- platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::SegmentedString):
- 2:13 PM Changeset in webkit [142513] by
-
- 8 edits3 adds in trunk
IndexedDB: database connections don't close after versionchange transaction aborts
https://bugs.webkit.org/show_bug.cgi?id=102298
Reviewed by Tony Chang.
Source/WebCore:
Per spec, close the database if the "versionchange" transaction aborts.
Tests: storage/indexeddb/aborted-versionchange-closes.html
storage/indexeddb/lazy-index-population.html
storage/objectstore-basics.html
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::onAbort): Tell the IDBDatabase (connection) to close if
this was a "versionchange" transaction.
LayoutTests:
Added dedicated test, updated tests dependent on buggy behavior.
- storage/indexeddb/aborted-versionchange-closes-expected.txt: Added.
- storage/indexeddb/aborted-versionchange-closes.html: Added.
- storage/indexeddb/lazy-index-population-expected.txt:
- storage/indexeddb/lazy-index-population.html: Remove manual closing.
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics-workers-expected.txt:
- storage/indexeddb/resources/aborted-versionchange-closes.js: Added.
- storage/indexeddb/resources/objectstore-basics.js: Removed dependency on bug.
- 1:59 PM Changeset in webkit [142512] by
-
- 7 edits in trunk
[EFL] fast/forms/number/number-l10n-input.html is failing
https://bugs.webkit.org/show_bug.cgi?id=109440
Reviewed by Laszlo Gombos.
Source/WebCore:
Use LocaleICU instead of LocaleNone on EFL port. The EFL
port already depends on ICU library and we get additional
functionality this way.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
LayoutTests:
Unskip fast/forms/number/number-l10n-input.html on EFL port
now that it passes.
- platform/efl/TestExpectations:
- 1:48 PM Changeset in webkit [142511] by
-
- 2 edits in trunk/Source/WebKit
Rename Visual Studio solution folders to avoid conflicts with project names
https://bugs.webkit.org/show_bug.cgi?id=109484
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit.sln: Rename several solution folders (e.g.,
WTF, WebCore, WebKit, JavaScriptCore) so that they do not conflict
with projects using the same name.
- 1:48 PM Changeset in webkit [142510] by
-
- 2 edits in trunk/LayoutTests
Remove failure expectation now that this test is passing.
- platform/chromium/TestExpectations:
- 1:41 PM Changeset in webkit [142509] by
-
- 51 edits in trunk
Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=109349
Reviewed by Sam Weinig.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Expose setMinimumTimerInterval() and implement the backup/restore to keep
a consistent state between tests.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setMinimumTimerInterval):
(WebCore):
- testing/InternalSettings.h:
(Backup):
(InternalSettings):
- testing/InternalSettings.idl:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
Tools:
Get rid of TestRunner's setMinimumTimerInterval and all the related functions.
This also fixes an oddity:
TestRunners were initialized with a minimum timer interval of 10 milliseconds instead
of using the default value. All with the same copy of an outdated comment.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::reset):
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Update the tests to use InternalSettings.
- fast/dom/timer-increase-min-interval-and-reset-part-1.html:
- fast/dom/timer-increase-min-interval-repeating.html:
- fast/dom/timer-increase-min-interval.html:
- fast/dom/timer-increase-then-decrease-min-interval-repeating.html:
- fast/dom/timer-increase-then-decrease-min-interval.html:
- 1:39 PM Changeset in webkit [142508] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG TypeOf implementation should have its backend code aligned to what the CFA does
https://bugs.webkit.org/show_bug.cgi?id=109385
Reviewed by Sam Weinig.
The problem was that if we ended up trying to constant fold, but didn't succeed
because of prediction mismatches, then we would also fail to do filtration.
Rearranged the control flow in the CFA to fix that.
As far as I know, this is asymptomatic - it's sort of OK for the CFA to prove less
things, which is what the bug was.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- 1:34 PM Changeset in webkit [142507] by
-
- 24 edits in trunk
Source/WebCore: Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Reviewed by Simon Fraser.
Take three - relanding after rollout in r142400 that was caused by a global
selector interfering with CSS Instrumentation in the Inspector.
A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.
The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.
In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.
Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.
- css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.
- platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- platform/chromium/LocalizedStringsChromium.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
displayState for snapshots.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
a snapshot should be immediately labeled.
- page/ChromeClient.h: No need for plugInStartLabelImage any more.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.
Source/WebKit2: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Reviewed by Simon Fraser.
Take three of this commit - after rollout in r142400 and r142405.
We no longer have any need for plugInStartLabelImage.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
Tools: Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273
Reviewed by Simon Fraser.
Take two - after rollout in r142405.
Removed plugInStartLabelImage entry from client structure.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- 1:29 PM Changeset in webkit [142506] by
-
- 4 edits2 adds in trunk
CSP reports for blocked 'data:' URLs should report the scheme only.
https://bugs.webkit.org/show_bug.cgi?id=109429
Reviewed by Adam Barth.
Source/WebCore:
https://dvcs.w3.org/hg/content-security-policy/rev/001dc8e8bcc3 changed
the CSP 1.1 spec to require that blocked URLs that don't refer to
generally resolvable schemes (e.g. 'data:', 'javascript:', etc.) be
stripped down to their scheme in violation reports.
Test: http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
If the blocked URL is a web-resolvable scheme, apply the current
stripping logic to it, otherwise, strip it to the scheme only.
- platform/KURL.h:
(KURL):
Move KURL::isHierarchical() out into KURL's public API.
LayoutTests:
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html: Added.
- 1:28 PM Changeset in webkit [142505] by
-
- 5 edits in trunk/Source/WebCore
ScrollingTree node maps keep getting larger
https://bugs.webkit.org/show_bug.cgi?id=109348
Reviewed by Sam Weinig.
When navigating between pages, nodes would get left in the ScrollingTree's
node map, and the ScrollingStateTree's node map, so these would get larger
and larger as you browse.
Simplify map maintenance by clearing the map when setting a new root node
(which happens on the first commit of a new page). Also, don't keep root nodes
around, but create them afresh for each page, which simplifies their ID
management.
This is closer to the original behavior; keeping the root nodes around was
a fix for bug 99668, but we avoid regressing that fix by bailing early
from frameViewLayoutUpdated() if there is no root state node (we'll get
called again anyway).
This now allows state nodeIDs to be purely read-only.
- page/scrolling/ScrollingStateNode.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNode):
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
- 1:28 PM Changeset in webkit [142504] by
-
- 5 edits in trunk/Source/WebCore
Move m_stateNodeMap from ScrollingCoordinatorMac to ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=109361
Reviewed by Sam Weinig.
The map of scrolling node IDs to ScollingStateNodes was maintained by
ScrollingCoordinatorMac, rather than ScrollingStateTree. This is different
from the ScrollingTree (which owns its node map), and added some amount
of to-and-fro between ScrollingStateTree and ScrollingCoordinatorMac.
Having ScrollingCoordinatorMac maintain the map of IDs to state nodes
simplifies things.
No behavior change.
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNode):
(WebCore::ScrollingStateTree::stateNodeForID):
- page/scrolling/ScrollingStateTree.h:
(ScrollingStateTree): Remove some stale comments.
(WebCore::ScrollingStateTree::removedNodes):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollingCoordinatorMac):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::recomputeWheelEventHandlerCountForFrameView):
(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinatorMac::attachToStateTree):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):
(WebCore::ScrollingCoordinatorMac::updateScrollingNode):
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
- 1:26 PM Changeset in webkit [142503] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/mac/PlatformSpeechSynthesizerMac.mm: Fix the case in the include.
- 1:26 PM Changeset in webkit [142502] by
-
- 3 edits in trunk/Source/WebKit2
The plug-in process connection manager doesn't need to be heap allocated
https://bugs.webkit.org/show_bug.cgi?id=109479
Reviewed by Andreas Kling.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::pluginProcessCrashed):
- WebProcess/WebProcess.h:
(WebKit):
(WebProcess):
- 1:24 PM Changeset in webkit [142501] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r181742. Requested by
fmalita_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11
- DEPS:
- 1:11 PM Changeset in webkit [142500] by
-
- 7 edits2 adds in trunk
Regression(r131539): Heap-use-after-free in WebCore::RenderBlock::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=107189
Reviewed by Abhishek Arya.
Source/WebCore:
Test: fast/dynamic/continuation-detach-crash.html
This patch reverts r131539 and the following changes (r132591 and r139664).
This means we redo detaching from the bottom-up which solves the regression.
It fixes the attached test case as we re-attach child nodes before detaching
the parent. It seems wrong to do but this avoid a stale continuation.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::detach): Detach the children first, then ourself.
- dom/Node.cpp:
(WebCore::Node::detach): Clear the renderer instead of ASSERT'ing.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed): Removed the code to clear the associated node's renderer.
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
Moved the repainting logic back into removeChildNode from destroyAndCleanupAnonymousWrappers.
(WebCore::RenderObjectChildList::destroyLeftoverChildren): Re-added the code to clear the associated node's
renderer.
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setText): Re-added the code to set the associated node's renderer.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::detach):
- dom/Node.cpp:
(WebCore::Node::detach):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::destroyLeftoverChildren):
(WebCore::RenderObjectChildList::removeChildNode):
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setText):
LayoutTests:
- fast/dynamic/continuation-detach-crash-expected.txt: Added.
- fast/dynamic/continuation-detach-crash.html: Added.
- 1:04 PM Changeset in webkit [142499] by
-
- 47 edits2 adds in trunk
Move setFrameFlatteningEnabled from layoutTestController to window.internals.settings
https://bugs.webkit.org/show_bug.cgi?id=87149
Reviewed by Simon Fraser.
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Add setFrameFlatteningEnabled to the list of overridable values.
Tools:
Remove testRunner.setFrameFlatteningEnabled from DRT and WTR. WebKit API
methods are left because there may be users of it. Add a test for Apple Mac
to ensure that the API for the preference still works using overridePreference.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Update tests to use internal.settings.setFrameFlatteningEnabled, which is automatically
generated from Settings.in.
Add a Mac only test that uses overridePreference to test the API.
- fast/frames/flattening/crash-svg-document.html:
- fast/frames/flattening/frameset-flattening-advanced.html:
- fast/frames/flattening/frameset-flattening-grid.html:
- fast/frames/flattening/frameset-flattening-simple.html:
- fast/frames/flattening/frameset-flattening-subframe-resize.html:
- fast/frames/flattening/frameset-flattening-subframesets.html:
- fast/frames/flattening/iframe-flattening-crash.html:
- fast/frames/flattening/iframe-flattening-fixed-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width.html:
- fast/frames/flattening/iframe-flattening-nested.html:
- fast/frames/flattening/iframe-flattening-offscreen.html:
- fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
- fast/frames/flattening/iframe-flattening-out-of-view.html:
- fast/frames/flattening/iframe-flattening-selection-crash.html:
- fast/frames/flattening/iframe-flattening-simple.html:
- fast/frames/flattening/iframe-tiny.html:
- fast/spatial-navigation/snav-iframe-flattening-simple.html:
- fast/text-autosizing/narrow-iframe-flattened.html:
- http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html:
- platform/chromium/TestExpectations: Chromium doesn't use frame flattening on mobile either.
- plugins/frameset-with-plugin-frame.html:
- fast/frames/flattening/crash-svg-document.html:
- fast/frames/flattening/frameset-flattening-advanced.html:
- fast/frames/flattening/frameset-flattening-grid.html:
- fast/frames/flattening/frameset-flattening-simple.html:
- fast/frames/flattening/frameset-flattening-subframe-resize.html:
- fast/frames/flattening/frameset-flattening-subframesets.html:
- fast/frames/flattening/iframe-flattening-crash.html:
- fast/frames/flattening/iframe-flattening-fixed-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
- fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
- fast/frames/flattening/iframe-flattening-fixed-width.html:
- fast/frames/flattening/iframe-flattening-nested.html:
- fast/frames/flattening/iframe-flattening-offscreen.html:
- fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
- fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
- fast/frames/flattening/iframe-flattening-out-of-view.html:
- fast/frames/flattening/iframe-flattening-selection-crash.html:
- fast/frames/flattening/iframe-flattening-simple.html:
- fast/frames/flattening/iframe-tiny.html:
- fast/spatial-navigation/snav-iframe-flattening-simple.html:
- fast/text-autosizing/narrow-iframe-flattened.html:
- http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html:
- platform/chromium/TestExpectations:
- platform/mac/fast/frames/flattening/set-preference-expected.txt: Added.
- platform/mac/fast/frames/flattening/set-preference.html: Added.
- plugins/frameset-with-plugin-frame.html:
- 12:43 PM Changeset in webkit [142498] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r142491.
http://trac.webkit.org/changeset/142491
https://bugs.webkit.org/show_bug.cgi?id=109470
broke the 32 bit build (Requested by jessieberlin on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 12:41 PM Changeset in webkit [142497] by
-
- 14 edits1 add in trunk/Source/WebCore
Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase
https://bugs.webkit.org/show_bug.cgi?id=109411
Reviewed by Adam Barth.
Moved InputStreamPreprocessor into its own header file so it can be
used by both WebVTTTokenizer and HTMLTokenizer.
Also split out kEndOfFileMarker from InputStreamPreprocessor<T> so that
it can be used w/o a specific instantiation of the template class.
This also made it possible to fix three old fixmes about wanting to share
that constant.
Again, separating WebVTT code from Markup* base classes made it simpler
at the cost of a little copy/paste code. WebVTT tokenization is remarkably
simple compared to HTML.
This will make it immediately possible to pull MarkupTokenizerBase up into
HTMLTokenizer and further simplify the code.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::markEndOfFile):
- html/parser/HTMLInputStream.h:
(WebCore::HTMLInputStream::markEndOfFile):
- html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):
- html/parser/InputStreamPreprocessor.h: Added.
(WebCore):
(InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::nextInputCharacter):
(WebCore::InputStreamPreprocessor::peek):
(WebCore::InputStreamPreprocessor::advance):
(WebCore::InputStreamPreprocessor::skipNextNewLine):
(WebCore::InputStreamPreprocessor::reset):
(WebCore::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):
- html/track/WebVTTTokenizer.cpp:
(WebCore::WebVTTTokenizer::WebVTTTokenizer):
(WebCore::WebVTTTokenizer::nextToken):
- html/track/WebVTTTokenizer.h:
(WebVTTTokenizer):
(WebCore::WebVTTTokenizer::haveBufferedCharacterToken):
(WebCore::WebVTTTokenizer::bufferCharacter):
(WebCore::WebVTTTokenizer::emitAndResumeIn):
(WebCore::WebVTTTokenizer::emitEndOfFile):
(WebCore::WebVTTTokenizer::shouldSkipNullCharacters):
- xml/parser/MarkupTokenizerBase.h:
(MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::bufferCharacter):
- 12:37 PM Changeset in webkit [142496] by
-
- 2 edits in trunk/Source/Platform
[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380
Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).
Reviewed by James Robinson.
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):
- 12:36 PM Changeset in webkit [142495] by
-
- 2 edits in trunk/Tools
Unreviewed. Windows 7 Debug mode build fix.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- 12:23 PM Changeset in webkit [142494] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
https://bugs.webkit.org/show_bug.cgi?id=108513
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-11
Reviewed by Tony Chang.
WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
to avoid introducing spaces around misspellings.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.
- tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.
- 11:53 AM Changeset in webkit [142493] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions
https://bugs.webkit.org/show_bug.cgi?id=108459
Patch by Claudio Saavedra <Claudio Saavedra> on 2013-02-11
Reviewed by Alexey Proskuryakov.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
Providers might return 0 and we will end up with a null-pointer dereference.
Early check against this.
- 11:48 AM Changeset in webkit [142492] by
-
- 3 edits2 adds in trunk
document.write during window.onload can trigger DumpRenderTree to dump the render tree
https://bugs.webkit.org/show_bug.cgi?id=109465
Reviewed by Eric Seidel.
Source/WebCore:
This patch is a partial revert of
http://trac.webkit.org/changeset/142378. It's not safe to call
checkComplete during the load event. We'll need to find another way of
calling checkComplete at the right time.
Test: fast/parser/document-write-during-load.html
- dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
LayoutTests:
- fast/parser/document-write-during-load-expected.txt: Added.
- fast/parser/document-write-during-load.html: Added.
- 11:21 AM Changeset in webkit [142491] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG CompareEq(a, null) and CompareStrictEq(a, const) are unsound with respect to constant folding
https://bugs.webkit.org/show_bug.cgi?id=109387
Reviewed by Oliver Hunt.
Lock in the decision to use a non-speculative constant comparison as early as possible
and don't let the CFA change it by folding constants. This might be a performance
penalty on some really weird code (FWIW, I haven't seen this on benchmarks), but on
the other hand it completely side-steps the unsoundness that the bug speaks of.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::isConstantForCompareStrictEq):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:13 AM Changeset in webkit [142490] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark fast/flexbox/line-clamp-link-after-ellipsis.html as failing
on EFL port. This test was introduced in r142335.
- platform/efl/TestExpectations:
- 10:16 AM Changeset in webkit [142489] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed fix after r13954 for !ENABLE(JIT) builds.
- llint/LowLevelInterpreter.cpp:
- 10:15 AM Changeset in webkit [142488] by
-
- 4 edits2 adds in trunk
Web Inspector: Timeline: invalidate and force locations are same for Layout records caused by style recalculaiton
https://bugs.webkit.org/show_bug.cgi?id=109294
Reviewed by Pavel Feldman.
Source/WebCore:
Use the stack that caused style recalculation as a cause for relayout performed due to
layout invalidation caused by style recalculation.
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.Record):
LayoutTests:
- inspector/timeline/timeline-layout-reason-expected.txt: Added.
- inspector/timeline/timeline-layout-reason.html: Added.
- inspector/timeline/timeline-test.js:
(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline): Extracted "performActions" step from performActionsAndPrint()
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):
- 10:11 AM Changeset in webkit [142487] by
-
- 2 edits in trunk/Tools
[BlackBerry] Set mouse document position for mouse event in DRT.
https://bugs.webkit.org/show_bug.cgi?id=109094.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-11
Reviewed by Rob Buis.
RIM PR 246976.
Internally Reviewed by Nima Ghanavatian & Genevieve Mak.
Set mouse document position when we create mouse event in DRT.
- DumpRenderTree/blackberry/EventSender.cpp:
(setMouseEventDocumentPos):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):
- 10:05 AM Changeset in webkit [142486] by
-
- 7 edits in trunk
Web Inspector: [Extension API] adjust inspectedWindow.eval() callback parameters to expose non-exceptional error
https://bugs.webkit.org/show_bug.cgi?id=108640
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- only set first parameter to eval() callback iff expression successfully evaluates;
- use object, not bool as second parameter;
- pass exceptions and extension errors as second parameter if evaluate failed;
- minor drive-by changes in ExtensionAPI utilities.
- inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.InspectedWindow.prototype.):
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionStatus):
LayoutTests:
Rebase tests following change in exception parameter to inspectedWindow.eval() callback.
- inspector/extensions/extensions-eval-expected.txt:
- inspector/extensions/extensions-eval.html:
- inspector/extensions/extensions-sidebar-expected.txt:
- 10:01 AM Changeset in webkit [142485] by
-
- 6 edits in trunk
Web Inspector: [Extensions API] expose ExtensionServerClient to tests so tests use same port as extensions API
https://bugs.webkit.org/show_bug.cgi?id=109443
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Promote extensionServer var to the outer closure, so it may be accessed by platform-specific (or test) code.
- inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):
LayoutTests:
- replace additional message ports used for evaluating code in front-end with normal extension transport.
- http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.window.buildPlatformExtensionAPI):
(initialize_ExtensionsTest.InspectorTest._replyToExtension):
(initialize_ExtensionsTest.onEvaluate):
- http/tests/inspector/resources/extension-main.js:
- inspector/extensions/extensions-audits.html:
- 9:54 AM Changeset in webkit [142484] by
-
- 2 edits in trunk/Source/WebCore
Move WebVTTToken off of MarkupTokenBase
https://bugs.webkit.org/show_bug.cgi?id=109410
Reviewed by Tony Gentilcore.
This introduces a small amount of "copy/paste" code
but actually makes WebVTTToken much smaller and simpler!
This also frees the HTMLParser to have its Token class
back to itself so we can tune it to make HTML faster.
- html/track/WebVTTToken.h:
(WebVTTToken):
(WebCore::WebVTTToken::WebVTTToken):
(WebCore::WebVTTToken::appendToName):
(WebCore::WebVTTToken::type):
(WebCore::WebVTTToken::name):
(WebCore::WebVTTToken::ensureIsCharacterToken):
(WebCore::WebVTTToken::appendToCharacter):
(WebCore::WebVTTToken::beginEmptyStartTag):
(WebCore::WebVTTToken::beginStartTag):
(WebCore::WebVTTToken::beginEndTag):
(WebCore::WebVTTToken::beginTimestampTag):
(WebCore::WebVTTToken::makeEndOfFile):
(WebCore::WebVTTToken::clear):
- 9:28 AM Changeset in webkit [142483] by
-
- 6 edits3 adds in trunk
[V8] IndexedDB: Minor GC can collect IDBDatabase wrapper with versionchange handler
https://bugs.webkit.org/show_bug.cgi?id=108670
Reviewed by Kentaro Hara.
Source/WebCore:
Prevent IDBDatabase's wrapper from being GC'd while the database is open if it has
listeners, as those listeners may close the database in response to events.
Also, removed extraneous super-calls from hasPendingActivity() overrides.
Test: storage/indexeddb/database-wrapper.html
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::hasPendingActivity): Implemented.
- Modules/indexeddb/IDBDatabase.h: Declared.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::hasPendingActivity): Simplified.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::hasPendingActivity): Simplified.
LayoutTests:
- storage/indexeddb/database-wrapper-expected.txt: Added.
- storage/indexeddb/database-wrapper.html: Added.
- storage/indexeddb/resources/database-wrapper.js: Added.
(test):
(openDB):
(onUpgradeNeeded):
(openSuccess.get request.onsuccess):
(onVersionChange):
(collectGarbage):
(openAgain):
(onBlocked):
(openAgainSuccess):
- 9:17 AM Changeset in webkit [142482] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add form navigation control state tracking.
https://bugs.webkit.org/show_bug.cgi?id=109300
Reviewed by Rob Buis.
Add form navigation control state tracking.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::focusNextField):
(WebKit):
(BlackBerry::WebKit::WebPage::focusPreviousField):
(BlackBerry::WebKit::WebPage::submitForm):
- Api/WebPage.h:
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::updateFormState):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 9:01 AM Changeset in webkit [142481] by
-
- 5 edits in trunk/Source/JavaScriptCore
JSC build failing with verbose debug mode
https://bugs.webkit.org/show_bug.cgi?id=109441
Reviewed by Darin Adler.
Fixing some verbose messages which caused build errors.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::mergeToSuccessors):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- 8:52 AM Changeset in webkit [142480] by
-
- 4 edits in trunk/Source/WebCore
Remove AttributeBase now that NEW_XML is gone
https://bugs.webkit.org/show_bug.cgi?id=109408
Reviewed by Adam Barth.
Just deleting code. HTMLToken::Attribute is now just
the real class and not a typedef.
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/HTMLTokenizer.cpp:
(WebCore::AtomicHTMLToken::nameForAttribute):
- xml/parser/MarkupTokenBase.h:
(WebCore):
(MarkupTokenBase):
(Attribute):
(Range):
- 8:24 AM Changeset in webkit [142479] by
-
- 2 edits in trunk/Tools
[BlackBerry] Add graphics subdirectory to include path.
https://bugs.webkit.org/show_bug.cgi?id=109437
Patch by Mike Lattanzio <mlattanzio@rim.com> on 2013-02-11
Reviewed by Rob Buis.
Add browser/platform/graphics to include path.
Internal review by Jeff Rogers.
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
- 8:19 AM Changeset in webkit [142478] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip fast/forms/number/number-l10n-input.html that was added in r142122
but fails on EFL port.
- platform/efl/TestExpectations:
- 8:06 AM Changeset in webkit [142477] by
-
- 2 edits in trunk/Tools
[EFL][WKTR] Regression(r141836) fast/dom/Window/mozilla-focus-blur.html started failing
https://bugs.webkit.org/show_bug.cgi?id=109438
Reviewed by Kenneth Rohde Christiansen.
Some refactoring in r141836 caused the view not to get focus if the focused
frame is not the main one. The idea of the code was to remove focus from the
view if the focused frame was not the main one, and then focus the view again.
However, after the refactoring, the second step never happened: Focus was
removed but not given again.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus):
- 8:00 AM Changeset in webkit [142476] by
-
- 3 edits in trunk/LayoutTests
Unreviewed revert test fix attempt and skip it.
- inspector/editor/text-editor-home-button.html:
- platform/chromium/TestExpectations:
- 7:58 AM Changeset in webkit [142475] by
-
- 2 edits in trunk/Source/WebCore
Rename PreloadTask to StartTagScanner to match its purpose
https://bugs.webkit.org/show_bug.cgi?id=109406
Reviewed by Sam Weinig.
As discussed in bug 107807.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::processToken):
- 7:50 AM Changeset in webkit [142474] by
-
- 13 edits1 move in trunk
Web Inspector: WebInspector.Project refactorings.
https://bugs.webkit.org/show_bug.cgi?id=109433
Reviewed by Alexander Pavlov.
Source/WebCore:
This change prepares Workspace and Project to migration to project-per-domain mode for network based projects.
Renamed WebInspector.WorkspaceProvider to WebInspector.ProjectDelegate.
Renamed Project.name() to Project.id() and delegated it to project delegate.
Added Project.displayName() method that is delegated to project delegate.
SimpleWorkspaceProvider is now responsible for creation of SimpleWorkspaceDelegates and
isolates various mappings from Project/ProjectDelegate concept.
UISourceCode is now created based on path in the project.
UISourceCode uri is now calculated based on project and path (right now uri is equal to path).
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileSystemProjectDelegate.js: Renamed from Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js.
(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.type):
(WebInspector.FileSystemProjectDelegate.prototype.displayName):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
(WebInspector.FileSystemProjectDelegate.prototype._addFile):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
(WebInspector.FileSystemProjectDelegate.prototype.reset):
(WebInspector.FileSystemUtils):
(WebInspector.FileSystemUtils.errorHandler):
(WebInspector.FileSystemUtils.requestFileSystem):
(.fileSystemLoaded):
(.innerCallback):
(WebInspector.FileSystemUtils.requestFilesRecursive):
(.fileEntryLoaded):
(.fileLoaded):
(.readerLoadEnd):
(WebInspector.FileSystemUtils.requestFileContent):
(.fileWriterCreated.fileTruncated):
(.fileWriterCreated):
(.writerEnd):
(WebInspector.FileSystemUtils.setFileContent):
(WebInspector.FileSystemUtils._getDirectory):
(.toArray):
(WebInspector.FileSystemUtils._readDirectory):
(WebInspector.FileSystemUtils._requestEntries):
- inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.setFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._uniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleProjectDelegate.prototype.reset):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.path):
(WebInspector.UISourceCode.prototype.uri):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.ProjectDelegate):
(WebInspector.ProjectDelegate.prototype.id):
(WebInspector.ProjectDelegate.prototype.displayName):
(WebInspector.ProjectDelegate.prototype.requestFileContent):
(WebInspector.ProjectDelegate.prototype.setFileContent):
(WebInspector.ProjectDelegate.prototype.searchInFileContent):
(WebInspector.Project):
(WebInspector.Project.prototype.id):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.displayName):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Project.prototype.dispose):
(WebInspector.Workspace.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.removeProject):
(WebInspector.Workspace.prototype.project):
(WebInspector.Workspace.prototype.uiSourceCodes):
(WebInspector.Workspace.prototype.projectForUISourceCode):
- inspector/front-end/inspector.html:
LayoutTests:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/uisourcecode-revisions.html:
- 7:45 AM Changeset in webkit [142473] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in the profiler code
https://bugs.webkit.org/show_bug.cgi?id=109432
Reviewed by Pavel Feldman.
Updated type annotations to match the code.
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/ProfilesPanel.js:
- 7:44 AM Changeset in webkit [142472] by
-
- 2 edits in trunk/Source/WebCore
[QT] Regression (r142444): Broke qt linux minimal build
https://bugs.webkit.org/show_bug.cgi?id=109423
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2013-02-11
Reviewed by Kenneth Rohde Christiansen.
Test: cssom/cssvalue-comparison.html
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
- 7:40 AM Changeset in webkit [142471] by
-
- 7 edits1 add in trunk/Source/WebCore
Web Inspector: introduce WebInspector.TextUtils
https://bugs.webkit.org/show_bug.cgi?id=109289
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Pavel Feldman.
Add new WebInspector.TextUtils file and extract commonly used
text-operation subroutines from DefaultTextEditor into it.
No new tests: no change in behaviour.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._isWord):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._rangeForCtrlArrowMove):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):
- inspector/front-end/TextUtils.js: Added.
(WebInspector.TextUtils.isStopChar):
(WebInspector.TextUtils.isWordChar):
(WebInspector.TextUtils.isSpaceChar):
(WebInspector.TextUtils.isWord):
(WebInspector.TextUtils.isBraceChar):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 7:26 AM Changeset in webkit [142470] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
- Rebaseline fast/dynamic/002.html on EFL port after r142015.
- Skip several compositing test cases that started failing after r142112.
- Skip several new Kronos WebGL conformance tests that are failing on EFL WK2.
- platform/efl-wk2/TestExpectations:
- platform/efl/fast/dynamic/002-expected.png:
- platform/efl/fast/dynamic/002-expected.txt:
- 7:12 AM Changeset in webkit [142469] by
-
- 2 edits in trunk/Websites/webkit.org
Add basysKom to domainAffiliations in team.html
https://bugs.webkit.org/show_bug.cgi?id=109306
Reviewed by Laszlo Gombos.
Register basysKom as contributing company in
http://www.webkit.org/team.html.
- team.html:
- 7:09 AM Changeset in webkit [142468] by
-
- 2 edits in trunk/Websites/webkit.org
Add intel.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109424
Reviewed by Kenneth Rohde Christiansen.
- team.html:
- 7:05 AM Changeset in webkit [142467] by
-
- 2 edits in trunk/Tools
[GTK] Don't generate documentation if building neither WebKit1 nor WebKit2
https://bugs.webkit.org/show_bug.cgi?id=109420
Reviewed by Philippe Normand.
Don't generate the GTK documentation if neither of the WebKit1 and WebKit2
layers was built. This just results in unnecessary errors being spewed out
by the gtkdoc utilities.
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- 7:03 AM Changeset in webkit [142466] by
-
- 1 edit in trunk/Source/WebCore
Adding the svn:ignore property that the previous commit (done through webkit-patch) failed to.
- 6:59 AM Changeset in webkit [142465] by
-
- 1 edit in trunk/ChangeLog
- Source/WebCore: Modified property svn:ignore, adding GNUmakefile.features.am
to the list of paths to be ignored.
- 6:47 AM Changeset in webkit [142464] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for the
cssom/cssvalue-comparison.html, the test was added in r142444 and is failing
due to CSS image-set functionality not yet enabled in the GTK port.
- 6:43 AM Changeset in webkit [142463] by
-
- 2 edits in trunk/Source/WebCore
[GTK][Clang] Build errors in LocalizedStringsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=109418
Reviewed by Philippe Normand.
Use the C++ isfinite(float) and abs(float) (instead of fabsf(float))
methods by including the WTF MathExtras.h header. Use a static cast to
an integer type on the float return value of the abs(float) method call
instead of the C-style cast.
No new tests - no new functiolnality.
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaTimeDescription):
- 6:42 AM Changeset in webkit [142462] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for the WTFURL backend of KURL.
- platform/KURL.cpp:
(WebCore::KURL::isSafeToSendToAnotherThread): m_urlImpl is of RefPtr type so use
the appropriate operator on it when calling the isSafeToSendToAnotherThread method.
- 5:55 AM Changeset in webkit [142461] by
-
- 3 edits in trunk/Source/WebCore
Range::collapsed callers should explicitly ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=108921
Reviewed by Jochen Eisinger.
For clarity and consistency, this patch adjusts Range::collapsed() to
drop the default value of the ExceptionCode parameter it accepts. The
three call sites that called the method with no arguments (all part of
Editor::rangeOfString) will now explicitly ASSERT_NO_EXCEPTION.
- dom/Range.h:
(Range):
- editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
- 5:54 AM Changeset in webkit [142460] by
-
- 32 edits2 adds in trunk
Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
https://bugs.webkit.org/show_bug.cgi?id=108653
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-11
Reviewed by Yury Semikhatsky.
Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
In fact these two profile types have not too much in common. So put each into its own domain.
It should also help when Profiles panel gets split into several tools.
This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
change the original InspectorProfilerAgent.
PerformanceTests:
- inspector/heap-snapshot-performance-test.js:
(test.performanceTest.cleanup):
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.json:
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorHeapProfilerAgent.cpp: Added.
(WebCore):
(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::~InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetState):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::setFrontend):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::collectGarbage):
(WebCore::InspectorHeapProfilerAgent::createSnapshotHeader):
(WebCore::InspectorHeapProfilerAgent::hasHeapProfiler):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::removeProfile):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::getHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::reportMemoryUsage):
- inspector/InspectorHeapProfilerAgent.h: Added.
(WebCore):
(InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::clearProfiles):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
- inspector/InstrumentingAgents.h:
(WebCore):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorHeapProfilerAgent):
(WebCore::InstrumentingAgents::setInspectorHeapProfilerAgent):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/front-end/HeapSnapshotDataGrids.js:
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._clearProfiles):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._populateProfiles.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.revealInView):
(WebInspector.HeapProfilerDispatcher):
(WebInspector.HeapProfilerDispatcher.prototype.addProfileHeader):
(WebInspector.HeapProfilerDispatcher.prototype.addHeapSnapshotChunk):
(WebInspector.HeapProfilerDispatcher.prototype.finishHeapSnapshot):
(WebInspector.HeapProfilerDispatcher.prototype.resetProfiles):
(WebInspector.HeapProfilerDispatcher.prototype.reportHeapSnapshotProgress):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
- inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgent::shouldInterruptForMessage):
LayoutTests:
- inspector-protocol/heap-profiler/resources/heap-snapshot-common.js:
(InspectorTest.takeHeapSnapshot.InspectorTest.eventHandler.string_appeared_here):
(InspectorTest.takeHeapSnapshot):
- inspector-protocol/nmi-webaudio-leak-test.html:
- inspector/profiler/heap-snapshot-get-profile-crash.html:
- inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
- inspector/profiler/heap-snapshot-loader.html:
- inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
- 5:51 AM Changeset in webkit [142459] by
-
- 2 edits in trunk/Source/WebCore
Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions.
https://bugs.webkit.org/show_bug.cgi?id=109372
Reviewed by Jochen Eisinger.
Rather than implicitly ignoring exceptions, we should use the
IGNORE_EXCEPTION macro for clarity.
- editing/Editor.cpp:
(WebCore::Editor::countMatchesForText):
- 5:12 AM Changeset in webkit [142458] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline EFL expectation for fast/js/global-constructors.html after
r142205.
- platform/efl/fast/js/global-constructors-expected.txt:
- 4:55 AM Changeset in webkit [142457] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Unreviewed. Fix minimal build after r142444.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-11
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
- 4:47 AM Changeset in webkit [142456] by
-
- 2 edits in trunk/LayoutTests
Unreviewed r142439 follow-up: test fix.
- inspector/editor/text-editor-home-button.html:
- 4:46 AM Changeset in webkit [142455] by
-
- 2 edits in trunk/Tools
Unreviewed change to add myself to the Inspector IDLs watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 4:44 AM Changeset in webkit [142454] by
-
- 6 edits in trunk/Source
[EFL] Stop using smart pointers for Ecore_Timer
https://bugs.webkit.org/show_bug.cgi?id=109409
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Stop using a smart pointer for Ecore_Timer in RunLoop::TimerBase. This
is a bad idea because the timer handle becomes invalid as soon as the
timer callback returns ECORE_CALLBACK_CANCEL. This may lead to crashes
on destruction because OwnPtr calls ecore_timer_del() on an invalid
handle.
No new tests, already covered by exiting tests.
- platform/RunLoop.h:
(TimerBase):
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):
Source/WTF:
Remove support in OwnPtr for EFL's Ecore_Timer. It is a bad idea to use
OwnPtr for Ecore_Timer because the timer handle may become invalid.
- wtf/OwnPtrCommon.h:
(WTF):
- wtf/efl/OwnPtrEfl.cpp:
- 4:38 AM Changeset in webkit [142453] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark 2 webgl/conformance test cases as crashing on EFL WK2.
- platform/efl-wk2/TestExpectations:
- 4:15 AM Changeset in webkit [142452] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Allow SplitView to keep the sidebar size as a fraction of the container size
https://bugs.webkit.org/show_bug.cgi?id=109414
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.
SplitView now interprets defaultSidebarWidth and defaultSidebarHeight values between 0 and 1 as
fractions of the total container size. The sidebar then will grow or shrink along with the container.
When the sidebar is resized manually the updated ratio is stored in the settings.
- inspector/front-end/SplitView.js:
(WebInspector.SplitView):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
(WebInspector.SplitView.prototype._updateTotalSize):
(WebInspector.SplitView.prototype._innerSetSidebarSize):
(WebInspector.SplitView.prototype._saveSidebarSize):
- 3:51 AM Changeset in webkit [142451] by
-
- 5 edits1 copy2 moves2 adds in trunk/Tools
[GTK][EFL] Shares WebKit-GTK's DumpRenderTree accessibility implementation with other Webkit ports
https://bugs.webkit.org/show_bug.cgi?id=105007
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-02-11
Reviewed by Martin Robinson.
Shares specific ATK's accessibility implementation.
Keeps platform specific methods in EFL and GTK's directories.
- DumpRenderTree/atk/AccessibilityCallbacks.h: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.h.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp.
(printAccessibilityEvent):
(axObjectEventListener):
(connectAccessibilityCallbacks):
(disconnectAccessibilityCallbacks):
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp.
(coreAttributeToAtkAttribute):
(roleToString):
(replaceCharactersForResults):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::indexOfChild):
(attributeSetToString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(checkElementState):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::indexInTable):
(indexRangeInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::numberAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(alterCurrentValue):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::press):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(AccessibilityUIElement::url):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
- DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers, libraries, new sources.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::helpText):
- GNUmakefile.am: Adds renamed sources.
- 3:49 AM Changeset in webkit [142450] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: highlight DOM nodes on hover while debugging
https://bugs.webkit.org/show_bug.cgi?id=109355
Reviewed by Vsevolod Vlasov.
Along with showing the popover, highlight the remote object as node.
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
- 3:42 AM Changeset in webkit [142449] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marked editing/spelling/spellcheck-async.html
as [ Pass Failure ].
- platform/chromium/TestExpectations:
- 3:36 AM Changeset in webkit [142448] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Added [Timeout] to http/tests/misc/window-dot-stop.html.
- platform/chromium/TestExpectations:
- 3:29 AM Changeset in webkit [142447] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: displaying whitespace characters is broken
https://bugs.webkit.org/show_bug.cgi?id=109412
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.
Add "pointer-events: none" rule for pseudo-class "before", which
maintains rendering of whitespace characters.
No new tests.
- inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-whitespace::before):
- 3:17 AM Changeset in webkit [142446] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adjusted expectations for two flaky crashers.
Removed failure expectations for tests that pass.
- platform/gtk/TestExpectations:
- 3:05 AM Changeset in webkit [142445] by
-
- 10 edits4 adds2 deletes in trunk
Web Inspector: Implement position-based sourcemapping for stylesheets
https://bugs.webkit.org/show_bug.cgi?id=109168
Source/WebCore:
Reviewed by Vsevolod Vlasov.
This change introduces support for position-based source maps for CSS stylesheets.
Sourcemaps and originating resources (sass, scss, etc.) are loaded synchronously
upon the CSS UISourceCode addition. RangeBasedSourceMap is removed as it is not used.
Test: http/tests/inspector/stylesheet-source-mapping.html
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSLocation):
(WebInspector.CSSProperty):
(WebInspector.CSSProperty.parsePayload):
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(WebInspector.SASSSourceMapping.prototype._loadAndProcessSourceMap):
(WebInspector.SASSSourceMapping.prototype.loadSourceMapForStyleSheet):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.SASSSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.SASSSourceMapping.prototype._reset):
- inspector/front-end/SourceMap.js:
(WebInspector.SourceMap):
(WebInspector.SourceMap.load):
(WebInspector.SourceMap.prototype.findEntry):
(WebInspector.SourceMap.prototype.findEntryReversed):
(WebInspector.SourceMap.prototype._parseMap):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._bindUISourceCode):
- inspector/front-end/inspector.js:
LayoutTests:
Added test for the stylesheet source mappings, followed the API changes,
removed RangeBasedSourceMap tests as this type of sourcemap is gone.
Reviewed by Vsevolod Vlasov.
- http/tests/inspector/compiler-script-mapping-expected.txt:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/resources/example.css.map: Added.
- http/tests/inspector/resources/example.scss: Added.
- http/tests/inspector/stylesheet-source-mapping-expected.txt: Added.
- http/tests/inspector/stylesheet-source-mapping.html: Added.
- inspector/styles/range-based-mapping-expected.txt: Removed.
- inspector/styles/range-based-mapping.html: Removed.
- 3:00 AM Changeset in webkit [142444] by
-
- 69 edits2 adds in trunk
Implement CSSValue::equals(const CSSValue&) to optimise CSSValue comparison
https://bugs.webkit.org/show_bug.cgi?id=102901
Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2013-02-11
Reviewed by Antti Koivisto.
Source/WebCore:
Added comparison method to CSSValue and its children, so that the
css values could be compared efficiently. Before this patch, CSSValue
objects were compared using strings that were generated by the cssText() method.
Test: cssom/cssvalue-comparison.html
- css/CSSAspectRatioValue.cpp:
(WebCore::CSSAspectRatioValue::equals):
(WebCore):
- css/CSSAspectRatioValue.h:
(CSSAspectRatioValue):
- css/CSSBasicShapes.cpp:
(WebCore::CSSBasicShapeRectangle::equals):
(WebCore):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):
- css/CSSBasicShapes.h:
(CSSBasicShapeRectangle):
(CSSBasicShapeCircle):
(CSSBasicShapeEllipse):
(CSSBasicShapePolygon):
- css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::equals):
(WebCore):
- css/CSSBorderImageSliceValue.h:
(CSSBorderImageSliceValue):
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::equals):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::equals):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::type):
(WebCore::CSSCalcBinaryOperation::equals):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::type):
- css/CSSCalculationValue.h:
(WebCore::CSSCalcExpressionNode::equals):
(CSSCalcExpressionNode):
(CSSCalcValue):
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::equals):
(WebCore):
- css/CSSCanvasValue.h:
(CSSCanvasValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::equals):
(WebCore):
- css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::equals):
(WebCore):
- css/CSSCursorImageValue.h:
(CSSCursorImageValue):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::equals):
(WebCore):
- css/CSSFontFaceSrcValue.h:
(CSSFontFaceSrcValue):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::equals):
(WebCore):
- css/CSSFunctionValue.h:
(CSSFunctionValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSLinearGradientValue::equals):
(WebCore):
(WebCore::CSSRadialGradientValue::equals):
- css/CSSGradientValue.h:
(WebCore::CSSGradientColorStop::operator==):
(CSSLinearGradientValue):
(CSSRadialGradientValue):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::equals):
(WebCore):
- css/CSSImageValue.h:
(CSSImageValue):
- css/CSSInheritedValue.h:
(WebCore::CSSInheritedValue::equals):
(CSSInheritedValue):
- css/CSSInitialValue.h:
(WebCore::CSSInitialValue::equals):
(CSSInitialValue):
- css/CSSLineBoxContainValue.h:
(WebCore::CSSLineBoxContainValue::equals):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::equals):
(WebCore):
- css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
- css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::equals):
(WebCore):
- css/CSSReflectValue.h:
(CSSReflectValue):
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSCubicBezierTimingFunctionValue::equals):
(WebCore):
(WebCore::CSSStepsTimingFunctionValue::equals):
- css/CSSTimingFunctionValue.h:
(WebCore::CSSLinearTimingFunctionValue::equals):
(CSSLinearTimingFunctionValue):
(CSSCubicBezierTimingFunctionValue):
(CSSStepsTimingFunctionValue):
- css/CSSUnicodeRangeValue.cpp:
(WebCore::CSSUnicodeRangeValue::equals):
(WebCore):
- css/CSSUnicodeRangeValue.h:
(CSSUnicodeRangeValue):
- css/CSSValue.cpp:
(WebCore):
(WebCore::compareCSSValues):
(WebCore::CSSValue::equals):
- css/CSSValue.h:
(CSSValue):
(WebCore):
(WebCore::compareCSSValueVector):
(WebCore::compareCSSValuePtr):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::removeAll):
(WebCore::CSSValueList::hasValue):
(WebCore::CSSValueList::equals):
(WebCore):
- css/CSSValueList.h:
(CSSValueList):
- css/CSSVariableValue.h:
(WebCore::CSSVariableValue::equals):
(CSSVariableValue):
- css/Counter.h:
(Counter):
(WebCore::Counter::equals):
- css/DashboardRegion.h:
(WebCore::DashboardRegion::equals):
- css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::equals):
(WebCore):
- css/FontFeatureValue.h:
(FontFeatureValue):
- css/FontValue.cpp:
(WebCore::FontValue::equals):
(WebCore):
- css/FontValue.h:
(FontValue):
- css/MediaQueryExp.h:
(WebCore::MediaQueryExp::operator==):
- css/Pair.h:
(WebCore::Pair::equals):
(Pair):
- css/Rect.h:
(WebCore::RectBase::equals):
(RectBase):
- css/ShadowValue.cpp:
(WebCore::ShadowValue::equals):
(WebCore):
- css/ShadowValue.h:
(ShadowValue):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::propertyMatches):
- css/WebKitCSSArrayFunctionValue.cpp:
(WebCore::WebKitCSSArrayFunctionValue::equals):
(WebCore):
- css/WebKitCSSArrayFunctionValue.h:
(WebKitCSSArrayFunctionValue):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::equals):
(WebCore):
- css/WebKitCSSFilterValue.h:
(WebKitCSSFilterValue):
- css/WebKitCSSMixFunctionValue.cpp:
(WebCore::WebKitCSSMixFunctionValue::equals):
(WebCore):
- css/WebKitCSSMixFunctionValue.h:
(WebKitCSSMixFunctionValue):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::equals):
(WebCore):
- css/WebKitCSSSVGDocumentValue.h:
(WebKitCSSSVGDocumentValue):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::equals):
(WebCore):
- css/WebKitCSSShaderValue.h:
(WebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::equals):
- editing/EditingStyle.cpp:
(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):
- svg/SVGColor.cpp:
(WebCore::SVGColor::equals):
(WebCore):
- svg/SVGColor.h:
(SVGColor):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::equals):
(WebCore):
- svg/SVGPaint.h:
(SVGPaint):
LayoutTests:
New layout test to verify that CSSValue objects comparison works properly.
- cssom/cssvalue-comparison-expected.txt: Added.
- cssom/cssvalue-comparison.html: Added.
- 2:24 AM Changeset in webkit [142443] by
-
- 2 edits in trunk/Source/WebCore
[Web Inspector] Network panel, sort by "transferSize" instead of "resourceSize".
https://bugs.webkit.org/show_bug.cgi?id=109142.
Patch by Pan Deng <pan.deng@intel.com> on 2013-02-11
Reviewed by Vsevolod Vlasov.
Sort by "transferSize" as it is the primary rather than "resoureSize".
No new tests.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.SizeComparator):
- 2:22 AM Changeset in webkit [142442] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Mark svg/custom/foreign-object-skew.svg
as [ ImageOnlyFailure Pass ].
- platform/chromium/TestExpectations:
- 2:11 AM Changeset in webkit [142441] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Resources] Prefactorings in DataGrid and CookieTable
https://bugs.webkit.org/show_bug.cgi?id=109141
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.
1) Make deleteCookie method static and move to WebInspector.Cookie
2) Replace resfreshCallback getter/setter in DataGrid with
constructor parameter
- inspector/front-end/CookieItemsView.js: Adopt changes.
- inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.remove): Moved from CookiesTable.
- inspector/front-end/CookiesTable.js: Adopt changes.
- inspector/front-end/DataGrid.js:
Replace setter with constructor parameter.
- 1:39 AM Changeset in webkit [142440] by
-
- 7 edits in trunk
Web Inspector: Don't throw exceptions in WebInspector.Color
https://bugs.webkit.org/show_bug.cgi?id=104835
Source/WebCore:
Patch by John J. Barton <johnjbarton@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.
WebInspector.Color.parse() returns a Color from a string, or null;
Ctor calls now call parse();
In the StylesSideBarPane, test null rather than catch(e).
Added case to inspector/styles/styles-invalid-color-values.html
- inspector/front-end/Color.js:
(WebInspector.Color):
(WebInspector.Color.parse):
(WebInspector.Color.fromRGBA):
(WebInspector.Color.fromRGB):
(WebInspector.Color.prototype.toString):
(WebInspector.Color.prototype._parse.this.alpha.set 0):
(WebInspector.Color.prototype._parse.this.nickname.set 2):
(WebInspector.Color.prototype._parse.this.hsla.set 1):
(WebInspector.Color.prototype._parse.this.rgba.set 0):
(WebInspector.Color.prototype._parse.set WebInspector):
(WebInspector.Color.prototype._parse):
- inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.get color):
- inspector/front-end/StylesSidebarPane.js:
LayoutTests:
Patch by John J. Barton <johnjbarton@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.
Added case to test parsing 'none' from border style
- inspector/styles/styles-invalid-color-values-expected.txt:
- inspector/styles/styles-invalid-color-values.html:
- 1:34 AM Changeset in webkit [142439] by
-
- 7 edits2 adds in trunk
Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Handle home key shortcut explicitly in TextEditorMainPanel.
New test: inspector/editor/text-editor-home-button.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):
LayoutTests:
Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.
- inspector/editor/editor-test.js:
(initialize_EditorTests.lineWithCursor):
(initialize_EditorTests.InspectorTest.textWithSelection): Added helper method to add selection symbols in text.
- inspector/editor/text-editor-home-button-expected.txt: Added.
- inspector/editor/text-editor-home-button.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 1:04 AM Changeset in webkit [142438] by
-
- 3 edits in trunk/Tools
[chromium] clear the webcache from within the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109405
Reviewed by Kentaro Hara.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::resetAll):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::resetTestController):
- 1:02 AM Changeset in webkit [142437] by
-
- 3 edits in trunk/Tools
[chromium] add a destructor to EventSender
https://bugs.webkit.org/show_bug.cgi?id=109401
Reviewed by Kentaro Hara.
Otherwise, the compiler will automatically generate a destructor, for
which we need to unnecessarily include WebContextMenuData.h in the
header.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::~EventSender):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebKit):
(EventSender):
- 12:36 AM Changeset in webkit [142436] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening
- platform/gtk/TestExpectations: Flagging media tests affected
by bug 108682
- 12:27 AM Changeset in webkit [142435] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip faling test.
https://bugs.webkit.org/show_bug.cgi?id=109353.
- platform/qt/TestExpectations:
- 12:06 AM Changeset in webkit [142434] by
-
- 33 edits in trunk/Source
Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
https://bugs.webkit.org/show_bug.cgi?id=108981
Reviewed by Eric Seidel.
Source/WebCore:
- Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addElement):
(WebCore::RTCStatsResponse::addStatistic):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::skipBuffer):
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
- css/WebKitCSSTransformValue.cpp:
(WebCore::transformValueToCssString):
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::search):
- html/HTMLElement.cpp:
(WebCore::parseColorStringWithCrazyLegacyRules):
- html/ImageData.cpp:
(WebCore::ImageData::ImageData):
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
- html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::getSomeData):
- platform/SharedBufferChunkReader.cpp:
(WebCore::SharedBufferChunkReader::nextChunk):
- platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::getKernelsFromAzimuthElevation):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/Region.cpp:
(WebCore::Region::Shape::segments_end):
- platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::getValues):
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::inputEffect):
- platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):
- platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::decode):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkFloatsInCleanLine):
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::executeAction):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculatePercentForSpline):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::findInstanceTime):
Source/WebKit/chromium:
- src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):
Source/WTF:
- wtf/BitVector.h:
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
- wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
- wtf/SegmentedVector.h:
(WTF::SegmentedVector::ensureSegment):
- wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::vprintf):
- wtf/Vector.h:
(WTF::::insert):
(WTF::::remove):
- wtf/dtoa/utils.h:
(WTF::double_conversion::StringBuilder::SetPosition):
(WTF::double_conversion::StringBuilder::AddSubstring):
Feb 10, 2013:
- 11:24 PM Changeset in webkit [142433] by
-
- 12 edits2 adds in trunk
WebSpeech: Implement basic speaking/finished speaking behavior
https://bugs.webkit.org/show_bug.cgi?id=107135
Reviewed by Sam Weinig.
Source/WebCore:
Implements the basic functionality of speaking utterances.
In the WebCore side, it manages the speech queue the way the spec defines
(that is, new jobs are appended to a queue and wait for other jobs to finish).
On the Mac side, it instantiates a synthesizer and handles the callbacks for when
jobs are finished. It sends those jobs back to WebCore to dispatch the right events.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-speak.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::speak):
(WebCore):
(WebCore::SpeechSynthesis::fireEvent):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
- Modules/speech/SpeechSynthesis.h:
(WebCore):
(WebCore::SpeechSynthesis::speaking):
(SpeechSynthesis):
- Modules/speech/SpeechSynthesisEvent.cpp:
(WebCore::SpeechSynthesisEvent::create):
(WebCore):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):
- Modules/speech/SpeechSynthesisEvent.h:
(SpeechSynthesisEvent):
(WebCore::SpeechSynthesisEvent::interfaceName):
- Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(SpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
(WebCore::PlatformSpeechSynthesisUtterance::startTime):
(WebCore::PlatformSpeechSynthesisUtterance::setStartTime):
(WebCore::PlatformSpeechSynthesisUtterance::client):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::client):
(PlatformSpeechSynthesizer):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
(-[WebSpeechSynthesisWrapper dealloc]):
(-[WebSpeechSynthesisWrapper convertRateToWPM:]):
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-speak-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-speak.html: Added.
- 11:06 PM EFLWebKitBuildBots edited by
- (diff)
- 11:04 PM EFLWebKitBuildBots edited by
- (diff)
- 10:54 PM Changeset in webkit [142432] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaselined an image.
- platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- 10:53 PM Changeset in webkit [142431] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marked http/tests/css/css-image-loading.html as SLOW.
- platform/chromium/TestExpectations:
- 10:47 PM Changeset in webkit [142430] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaselined an image.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 10:38 PM Changeset in webkit [142429] by
-
- 2 edits in trunk/Websites/webkit.org
Add adobe.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109396
Patch by Dirk Schulze <dschulze@adobe.com> on 2013-02-10
Reviewed by Laszlo Gombos.
- team.html:
- 9:16 PM Changeset in webkit [142428] by
-
- 22 edits in trunk/Source/WebKit2
Make the Plug-in XPCService build work even when building in Xcode
<rdar://problem/13011186>
https://bugs.webkit.org/show_bug.cgi?id=109392
Reviewed by Anders Carlsson.
- Configurations/DebugRelease.xcconfig:
Add a DEBUG_OR_RELEASE variable to test against.
- Configurations/PluginService.32.xcconfig:
- Configurations/PluginService.64.xcconfig:
In non-production builds, don't link against WebKit2, so that we don't get warnings about WebKit2.framework
not containing the right architectures. This is ok, as these services are not used in non-production builds.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:
Switch off the the old idiom of defining a macro for the initializer function, and instead set
it in the Info.plist, so the XPCServiceBootstrapper can grab it.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:
(WebKit::XPCServiceEventHandler):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h:
(WebKit::XPCServiceEventHandler):
Get the entry point from the bundle, rather than the macro. This is not only a bit less gross,
but also allows us to build without having linked against WebKit2.framework.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::shouldUseXPC):
Re-enable using XPC for plug-ins.
- WebKit2.xcodeproj/project.pbxproj:
Update project.
- 9:14 PM Changeset in webkit [142427] by
-
- 15 edits2 adds in trunk/Source/WebCore
Make the existing HTMLPreloadScanner threading-aware
https://bugs.webkit.org/show_bug.cgi?id=107807
Reviewed by Adam Barth.
The HTMLPreloadScanner and CSSPreloadScanner do a number of things.
CSSPreloadScanner is mostly just a helper class for HTMLPreloadScanner.
HTMLPreloadScanner runs its own copy of the HTMLTokenizer and uses
HTMLTokenizer::updateStateFor to emulate enough of the TreeBuilder
to get a realistic stream of tokens. It does some additional TreeBuilder
emulation, including tracking template tags and base tags, but mostly
just scans the token stream for start-tags and looks for URLs in them.
It tracks when it has seen a <style> tag and starts sending all character tokens
to the CSSPreloadScanner until a </style> tag is seen.
It also (unfortunately) knows some about the loader guts and how to construct
a proper CachedResourcRequest and issue a preload.
This patch changes the model so that the preload scanners only know how to produce
PreloadRequest objects and append them to a passed-in vector.
This changes the preload-scanner behavior so that preloads are now all issued in one large
batch at the end of scanning, instead of as we hit each resource. It's possible that
we'll wait to instead check for preload requests more often, at a possible tradeoff
to tokenizing speed.
An alternate approach might be to pass in a preload-delegate of sorts which knew how
to either build a vector, or send requests immediately. For now the build-a-vector-always
approach seems clean, and does not seem to slow down our PerformanceTest microbenchmarks at least.
This patch has 2 main pieces:
- Remove Document and (and loader) dependencies from HTMLPreloadScanner/CSSPreloadScanner This is done through introduction of a new HTMLResourcePreloader class which holds a Document* and knows how to talk to the CachedResourceLoader.
- Clean-up HTMLPreloadScanners token-loop to not be tied to having a Tokenizer. (On a background thead, the HTMLPreloadScanner won't own the tokenizer, it will just
be passed in tokens and expected to issue loads if necessary.)
This passes all of the LayoutTests using the main thread parser.
This patch does not make the HTMLPreloadScanner 100% ready for threading
(it still uses AtomicString which is currently not-OK on the parser thread)
but it's very close. Two further (already written) patches will complete this.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::CSSPreloadScanner):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):
- html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::PreloadTask::processAttributes):
(WebCore::PreloadTask::charset):
(PreloadTask):
(WebCore::PreloadTask::resourceType):
(WebCore::PreloadTask::shouldPreload):
(WebCore::PreloadTask::createPreloadRequest):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleTemplateTag):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):
- html/parser/HTMLPreloadScanner.h:
(HTMLPreloadScanner):
- html/parser/HTMLResourcePreloader.cpp: Added.
(WebCore):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::PreloadRequest::isSafeToSendToAnotherThread):
(WebCore::PreloadRequest::completeURL):
(WebCore::PreloadRequest::resourceRequest):
(WebCore::HTMLResourcePreloader::preload):
- html/parser/HTMLResourcePreloader.h: Added.
(WebCore):
(PreloadRequest):
(WebCore::PreloadRequest::create):
(WebCore::PreloadRequest::PreloadRequest):
(HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::createWeakPtr):
- loader/cache/CachedResourceRequest.h:
- 8:37 PM Changeset in webkit [142426] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaselined an image.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 8:29 PM Changeset in webkit [142425] by
-
- 2 edits in trunk/Websites/webkit.org
Add sisa.samsung.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109394
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-10
Reviewed by Dirk Schulze.
- team.html:
- 8:14 PM Changeset in webkit [142424] by
-
- 11 edits in trunk/Source/WebCore
[V8] Rename isolated() to getWorld(), rename worldForEnteredContextIfIsolated() to worldForEnteredContext()
https://bugs.webkit.org/show_bug.cgi?id=109039
Reviewed by Adam Barth.
This is a follow-up patch for r141983.
Rename methods for consistency.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
- bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::getWorld):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.h:
(WebCore::worldForEnteredContext):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCallbackCustom):
- 6:54 PM Changeset in webkit [142423] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Fix Android scrollbar size
https://bugs.webkit.org/show_bug.cgi?id=109374
Reviewed by James Robinson.
This shrinks scrollbars to 3 device-independent pixels (usually 6
physical pixels) and deletes the edge fade. Although the Android
system theme does have an edge fade, it's a much sharper cliff
than we had (against black, the colors go 64 -> 64 -> 52 -> 21 -> 0)
and I can't perceive any difference compared with no fade at all.
No new tests (due for rewrite in a week anyway).
- platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
- 6:38 PM Changeset in webkit [142422] by
-
- 18 edits in trunk/Source/WebKit/chromium
[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369
Patch by James Robinson <jamesr@chromium.org> on 2013-02-10
Reviewed by Darin Fisher.
Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
calling into webkit_support so they work in component builds.
- WebKit.gyp:
- tests/AssociatedURLLoaderTest.cpp:
- tests/EventListenerTest.cpp:
- tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::createWebViewAndLoad):
(QuitTask):
(WebKit::FrameTestHelpers::QuitTask::run):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::runPendingTasks):
- tests/FrameTestHelpers.h:
(FrameTestHelpers):
- tests/ListenerLeakTest.cpp:
- tests/PopupMenuTest.cpp:
- tests/PrerenderingTest.cpp:
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::navigateTo):
- tests/URLTestHelpers.cpp:
(WebKit::URLTestHelpers::registerMockedURLLoad):
- tests/WebFrameTest.cpp:
- tests/WebImageTest.cpp:
(WebKit::readFile):
- tests/WebPageNewSerializerTest.cpp:
- tests/WebPageSerializerTest.cpp:
- tests/WebPluginContainerTest.cpp:
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::TEST_F):
- tests/WebViewTest.cpp:
- 5:29 PM Changeset in webkit [142421] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marked fast/frames/seamless/seamless-inherited-origin.html as FAIL.
- platform/chromium/TestExpectations:
- 5:23 PM Changeset in webkit [142420] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaselined svg/custom/foreign-object-skew.svg.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 5:16 PM Changeset in webkit [142419] by
-
- 7 edits in trunk/Source/WebCore
[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579
Reviewed by Adam Barth.
Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.
Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).
Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.
Before:
mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms
After:
mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms
As shown above, I couldn't observe any performance regression.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 1:50 PM Changeset in webkit [142418] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r181645. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-10
- DEPS:
- 1:04 PM Changeset in webkit [142417] by
-
- 6 edits in trunk
Consolidate the way WTF_USE_PTHREADS is enabled
https://bugs.webkit.org/show_bug.cgi?id=108191
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-10
Reviewed by Benjamin Poulain.
.:
Remove duplicated definition of WTF_USE_PTHREADS.
WTF_USE_PTHREADS is defined to 1 on all OS(UNIX) environments in
Platform.h.
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
Source/WTF:
Define WTF_USE_PTHREADS to 1 on all OS(UNIX) environments.
- WTF.gyp/WTF.gyp: Remove duplicated definition of WTF_USE_PTHREADS.
- wtf/Platform.h:
- 12:11 PM Changeset in webkit [142416] by
-
- 3 edits5 adds in trunk
REGRESSION (r132422): Page content and scrollbars are incorrectly offset after restoring a page from the page cache
https://bugs.webkit.org/show_bug.cgi?id=109317
<rdar://problem/12649131>
Reviewed by Simon Fraser.
Mark all scrolling that occurs beneath FrameView::layout as programmatic.
Test: platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html
- page/FrameView.cpp:
(WebCore::FrameView::layout):
Add a test that ensures that scroll position is correctly restored for pages coming out of the page cache when tiled drawing is enabled.
- platform/mac-wk2/tiled-drawing/resources/go-back.html: Added.
- platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html: Added.
- platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html: Added.
- 11:54 AM Changeset in webkit [142415] by
-
- 2 edits in trunk/Tools
Unreviewed attempted build fix for Gtk after r142412
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
- 11:51 AM Changeset in webkit [142414] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r142413.
http://trac.webkit.org/changeset/142413
https://bugs.webkit.org/show_bug.cgi?id=109383
didn't fix the gtk build (Requested by thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-10
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
- 11:40 AM Changeset in webkit [142413] by
-
- 2 edits in trunk/Tools
Unreviewed attempted build fix for Gtk after r142412
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
- 11:27 AM Changeset in webkit [142412] by
-
- 7 edits in trunk/Tools
WKTR should propagate view creation options to opened windows
https://bugs.webkit.org/show_bug.cgi?id=109381
Reviewed by Simon Fraser.
- WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::options):
Add storage and a getter for PlatformWebView's creation options dictionary.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
Propagate creation options from parent to child PlatformWebView when creating subwindows.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):
Store creation options on the PlatformWebView.
- 10:26 AM Changeset in webkit [142411] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the GTK+ gyp build
- JavaScriptCore.gypi: Update the source list to accurately
reflect what's in the repository and remove the offsets extractor
from the list of JavaScriptCore files. It's only used to build
the extractor binary.
- 10:18 AM Changeset in webkit [142410] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Fix release build failure by recent reverts
- WebCore.exp.in:
- 9:55 AM Changeset in webkit [142409] by
-
- 2 edits in trunk/Source/WebKit2
Add back code that was accidentally removed when moving plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109379
Reviewed by Andreas Kling.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPlugins):
- 9:48 AM Changeset in webkit [142408] by
-
- 2 edits in trunk/Source/WebKit/mac
Added *.pdf to EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
Rubber-stamped by Anders Carlsson.
- Configurations/WebKit.xcconfig:
- 9:33 AM Changeset in webkit [142407] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/TestExpectations: Remove duplicate test expectation
for media/track/track-in-band-style.html.
- 9:29 AM Changeset in webkit [142406] by
-
- 9 edits in trunk
[GStreamer] media/video-controls-fullscreen-volume.html crashes
https://bugs.webkit.org/show_bug.cgi?id=108682
Reviewed by Martin Robinson.
Source/WebCore:
Clean up various signal handlers and avoid bad interaction between
the FullscreenVideoControllerGStreamer and its subclasses,
especially when the platform video window is created.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:
(WebCore::FullscreenVideoControllerGStreamer::enterFullscreen):
Initialize the window before connecting to the volume/mute
signals. This ensures that the signals won't ever interfere with
an inexisting window.
- platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::~GStreamerGWorld): Remove GstBus
synchronous handler function.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect from volume/mute signals.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
Keep a trace of volume/mute signal handlers.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Various forward type declarations to avoid un-necessary header includes.
(MediaPlayerPrivateGStreamerBase):
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:
(WebCore::FullscreenVideoControllerGtk::FullscreenVideoControllerGtk):
(WebCore::FullscreenVideoControllerGtk::volumeChanged): Bail out
if volume button hasn't been created yet.
(WebCore::FullscreenVideoControllerGtk::muteChanged): Ditto.
LayoutTests:
- platform/gtk/TestExpectations: Unflag now passing tests.
- 8:39 AM Changeset in webkit [142405] by
-
- 5 edits in trunk
Unreviewed, rolling out r142347.
http://trac.webkit.org/changeset/142347
https://bugs.webkit.org/show_bug.cgi?id=108273
Because a depending change r142343 was rolled out.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- 8:04 AM Changeset in webkit [142404] by
-
- 5 edits in trunk/Source/WebCore
RenderStyle should use copy-on-write inheritance for NinePieceImage.
<http://webkit.org/b/109366>
Reviewed by Antti Koivisto.
Refactor NinePieceImage to hold a copy-on-write DataRef like other RenderStyle substructures.
This allows us to avoids copying the NinePieceImageData when one RenderStyle inherits from another
but modifies something in the substructure holding the NinePieceImage (typically StyleSurroundData.)
Also made RenderStyle not copy-on-write its StyleSurroundData prematurely when doing a no-op write
to a border-image related value.
1.23 MB progression on Membuster3.
- rendering/style/NinePieceImage.cpp:
(WebCore::defaultData):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImageData::NinePieceImageData):
(WebCore::NinePieceImageData::operator==):
- rendering/style/NinePieceImage.h:
(WebCore::NinePieceImageData::create):
(WebCore::NinePieceImageData::copy):
(NinePieceImageData):
(NinePieceImage):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::computeOutset):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setBorderImageSource):
(WebCore::RenderStyle::setBorderImageSlices):
(WebCore::RenderStyle::setBorderImageWidth):
(WebCore::RenderStyle::setBorderImageOutset):
- rendering/style/RenderStyle.h:
- 7:05 AM Changeset in webkit [142403] by
-
- 2 edits in trunk/Tools
[Chromium] Build fix for r142371
https://bugs.webkit.org/show_bug.cgi?id=109313
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebKit):
- 6:33 AM Changeset in webkit [142402] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=109376
- platform/chromium/TestExpectations:
fast/frames/seamless/seamless-inherited-origin.html is failing on debug bots.
- 6:26 AM Changeset in webkit [142401] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK gardening.
- platform/gtk/TestExpectations: Flag new failing media/track test.
- 6:24 AM Changeset in webkit [142400] by
-
- 21 edits in trunk/Source
Unreviewed, rolling out r142343.
http://trac.webkit.org/changeset/142343
https://bugs.webkit.org/show_bug.cgi?id=108284
It might make inspector/profiler/selector-profiler-url.html
crashy.
Source/WebCore:
- WebCore.exp.in:
- css/plugIns.css:
(p):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::createRenderer):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::updateSnapshot):
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
- html/HTMLPlugInImageElement.h:
(WebCore):
(HTMLPlugInImageElement):
- page/ChromeClient.h:
(WebCore::ChromeClient::plugInStartLabelImage):
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- platform/chromium/LocalizedStringsChromium.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::paint):
(WebCore::RenderSnapshottedPlugIn::paintReplaced):
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::RenderSnapshottedPlugIn::startLabelImage):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel):
- rendering/RenderSnapshottedPlugIn.h:
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
(InjectedBundlePageUIClient):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::plugInStartLabelImage):
(WebKit):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 6:13 AM Changeset in webkit [142399] by
-
- 2 edits in trunk/Source/WTF
Refactor the way HAVE_XXX macros are set
https://bugs.webkit.org/show_bug.cgi?id=108132
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-10
Reviewed by Benjamin Poulain.
OS(WINDOWS) and OS(UNIX) are so broadly defined that for each
builds exactly one of them is enabled. Use this assumption to
cleanup Platform.h.
- wtf/Platform.h:
- 5:44 AM Changeset in webkit [142398] by
-
- 3 edits in trunk/Source/WebCore
RenderText: Access characters through m_text instead of caching data pointers separately.
<http://webkit.org/b/109357>
Reviewed by Antti Koivisto.
Go through RenderText::m_text.impl() instead of caching the character data pointer.
RenderText should never have a null String in m_text so it's safe to access impl() directly.
We have assertions for this since before.
Removing this pointer shrinks RenderText by 8 bytes, allowing it to fit into a snugger size class.
749 KB progression on Membuster3.
- rendering/RenderText.cpp:
(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::setTextInternal):
- rendering/RenderText.h:
(WebCore::RenderText::is8Bit):
(WebCore::RenderText::characters8):
(WebCore::RenderText::characters16):
(WebCore::RenderText::characterAt):
(WebCore::RenderText::operator[]):
(RenderText):
- 5:01 AM Changeset in webkit [142397] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=92941
- platform/chromium/TestExpectations:
accessibility/loading-iframe-updates-axtree.html is [ Timeout ].
- 4:49 AM FeatureFlags edited by
- Remove GLIB_SUPPORT, add ENCRYPTED_MEDiA_V2 and NOSNIFF (diff)
- 4:42 AM Changeset in webkit [142396] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip fast/encoding/parser-tests-*.html tests now that the crashes
have been fixed by r142385.
- platform/efl-wk2/TestExpectations:
- 3:23 AM Changeset in webkit [142395] by
-
- 18 edits in trunk
Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
https://bugs.webkit.org/show_bug.cgi?id=104266
Patch by Jae Hyun Park <jae.park08@gmail.com> on 2013-02-10
Reviewed by Philippe Normand.
Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
the existing macro naming conventions.
From Platform.h
USE() - use a particular third-party library or optional OS service
ENABLE() - turn on a specific feature of WebKit
.:
- Source/autotools/SetupAutoconfHeader.m4:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
No new tests, no new functionality.
- WebCore.pri:
Source/WebKit/gtk:
- gyp/Configuration.gypi:
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
Source/WTF:
- WTF.pri:
- wtf/Platform.h:
- wtf/gobject/GOwnPtr.cpp:
- wtf/gobject/GOwnPtr.h:
- wtf/gobject/GRefPtr.cpp:
- wtf/gobject/GRefPtr.h:
- 2:44 AM Changeset in webkit [142394] by
-
- 3 edits in trunk/Tools
gtkdoc-scangobj throwing warnings when using Clang, causes generate-gtkdoc to fail
https://bugs.webkit.org/show_bug.cgi?id=109315
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Philippe Normand.
- GNUmakefile.am: Define the CC environment variable to the CC compiler that the whole
project was configured to use. This ensures both the regular build and the gtkdoc-scangobj
program use the same compiler.
- gtk/generate-gtkdoc: Add '-Qunused-arguments' to the CFLAGS in case we're using Clang. This
forces Clang to suppress unused arguments warnings that can unnecessarily cause generate-gtkdoc
script to fail.
- 2:42 AM Changeset in webkit [142393] by
-
- 2 edits in trunk/Source/WebKit2
[WebKit2][Gtk] Remove the fullscreen manager proxy message receiver upon invalidating
https://bugs.webkit.org/show_bug.cgi?id=109352
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Sam Weinig.
As added for the Mac port in r142160 due to the changes in the same revision, remove
the fullscreen manager proxy as a message receiver. Also fixes a failing unit test.
- UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::invalidate):
- 2:40 AM Changeset in webkit [142392] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build errors in TextureMapperShaderProgram.cpp when compiling with Clang
https://bugs.webkit.org/show_bug.cgi?id=109321
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Noam Rosenthal.
Clang is reporting errors due to non-constant expressions that cannot be narrowed
from double to float type in initializer list when constructing a matrix of GC3Dfloat
numbers. To avoid this every parameter is passed through an explicit GC3Dfloat constructor.
No new tests - no new functionality.
- platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::setMatrix):
- 2:00 AM Changeset in webkit [142391] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] audio is muted when playback rate is between 0.8 and 2.0
https://bugs.webkit.org/show_bug.cgi?id=109362
Reviewed by Martin Robinson.
Don't mute sound if the audio pitch is preserved. If this is not
the case mute it if it's too extreme, as the HTML5 spec recommends.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate):
- 12:36 AM Changeset in webkit [142390] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Fix build on PLUGIN_ARCHITECTURE(UNSUPPORTED) after r142314
https://bugs.webkit.org/show_bug.cgi?id=109364
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-10
Reviewed by Simon Hausmann.
void NetscapePlugin::platformPreInitialize() is need to be added to NetscapePluginNone.cpp.
- WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:
(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):
Feb 9, 2013:
- 11:37 PM Changeset in webkit [142389] by
-
- 2 edits in trunk/Tools
Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978
Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by Joseph Pecoraro.
- TestWebKitAPI/Configurations/Base.xcconfig:
Added back FRAMEWORK_SEARCH_PATHS for Lion builds.
- 11:09 PM Changeset in webkit [142388] by
-
- 2 edits1 add in trunk/Source/Platform
[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369
Reviewed by Darin Fisher.
Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
in component builds.
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::unitTestSupport):
- chromium/public/WebUnitTestSupport.h: Added.
(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::registerMockedURL):
(WebKit::WebUnitTestSupport::registerMockedErrorURL):
(WebKit::WebUnitTestSupport::unregisterMockedURL):
(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
(WebKit::WebUnitTestSupport::webKitRootDir):
- 10:41 PM Changeset in webkit [142387] by
-
- 3 edits in trunk/Source/JavaScriptCore
Shrink-wrap UnlinkedCodeBlock members.
<http://webkit.org/b/109368>
Reviewed by Oliver Hunt.
Rearrange the members of UnlinkedCodeBlock to avoid unnecessary padding on 64-bit.
Knocks ~600 KB off of the Membuster3 peak.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(UnlinkedCodeBlock):
- 10:26 PM Changeset in webkit [142386] by
-
- 3 edits in trunk/LayoutTests
Chromium gardening
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium/TestExpectations:
- 10:11 PM Changeset in webkit [142385] by
-
- 4 edits in trunk
fast/encoding/parser-tests-*.html tests sometimes crash
https://bugs.webkit.org/show_bug.cgi?id=108058
Reviewed by Chris Fleizach.
Source/WebCore:
To avoid calling accessibilityIsIgnored while the render
tree is unstable, call accessibilityIsIgnored in the
notification timer handler, only for childrenChanged
notifications.
This exposed a problem where notifications queued on
objects can fire after the object has been deleted; fix that
by checking the object's id, which is always set to 0 when
removed from the tree.
Covered by existing tests.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):
LayoutTests:
Make test less brittle by (1) giving the iframe an aria-role so
it's never ignored, and (2) using accessibilityElementById instead
of assuming an element is in a specific place in the AX tree.
- accessibility/loading-iframe-updates-axtree.html:
- 7:48 PM Changeset in webkit [142384] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r137328.
http://trac.webkit.org/changeset/137328
https://bugs.webkit.org/show_bug.cgi?id=109367
causes memory usage to balloon if connection queue is filling
faster than sending (Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
- Platform/CoreIPC/ArgumentEncoder.h:
(CoreIPC::ArgumentEncoder::buffer):
(ArgumentEncoder):
- 4:50 PM Changeset in webkit [142383] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Do not assume MediaAccessibility framework is installed
https://bugs.webkit.org/show_bug.cgi?id=109365
Reviewed by Sam Weinig.
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Call the base class if the framework
is not available.
(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Ditto.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto.
- 3:06 PM Changeset in webkit [142382] by
-
- 39 edits in trunk/Source/WebCore
AX: move isIgnored caching to AXObject
https://bugs.webkit.org/show_bug.cgi?id=109322
Reviewed by Chris Fleizach.
There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.
AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.
No new tests.
- accessibility/AccessibilityImageMapLink.h:
(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityList.h:
(AccessibilityList):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):
- accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityListBoxOption.h:
(AccessibilityListBoxOption):
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):
- accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListOption.h:
(AccessibilityMenuListOption):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListPopup.h:
(AccessibilityMenuListPopup):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
- accessibility/AccessibilityProgressIndicator.h:
(AccessibilityProgressIndicator):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):
- accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
- accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
- accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
(AccessibilitySliderThumb):
- accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTable.h:
(AccessibilityTable):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableColumn.h:
(AccessibilityTableColumn):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableHeaderContainer.h:
(AccessibilityTableHeaderContainer):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):
- accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):
- 2:53 PM Changeset in webkit [142381] by
-
- 10 edits1 copy1 move1 add in trunk
Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978
Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.
Source/WebCore:
Tests already exist - refactor only.
- WebCore.exp.in: Lumped ZNK7WebCore4KURL7hasPathEv with related methods.
- platform/KURL.cpp: Inlined hasPath() into the header
- platform/KURL.h: Inlined hasPath() into the header
Tools:
- Makefile: Added TestWebKitAPI to iOS MODULES list.
- TestWebKitAPI/Configurations/Base.xcconfig:
- Include FeatureDefines
- Removed VALID_ARCHS
- Removed FRAMEWORK_SEARCH_PATHS - allows building against other SDKs
- Excluded source files per platform
- TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- framework and library switches per platform
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Remove explicit framework and library linking (moved to xcconfigs)
- Added iOS main.mm
- TestWebKitAPI/config.h:
- Guard importing Cocoa.h and WebKit2_C.h on iOS
- TestWebKitAPI/ios/mainIOS.mm: Copied from Tools/TestWebKitAPI/mac/main.mm.
- TestWebKitAPI/mac/mainMac.mm: Renamed from Tools/TestWebKitAPI/mac/main.mm.
- 1:00 PM Changeset in webkit [142380] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Reverting earlier change now
Unreviewed expectations.
- platform/chromium/TestExpectations: Removed all the expectations added earlier.
- 12:13 PM Changeset in webkit [142379] by
-
- 2 edits in trunk/Tools
[CHROMIUM] Suppress c4267 build warnings for Win64 tests
https://bugs.webkit.org/show_bug.cgi?id=109359
Reviewed by Abhishek Arya.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 11:34 AM Changeset in webkit [142378] by
-
- 8 edits in trunk/Source/WebCore
Load event fires too early with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108984
Reviewed by Eric Seidel.
Previously, the DocumentLoader would always be on the stack when the
HTMLDocumentParser was processing data from the network. The
DocumentLoader would then tell isLoadingInAPISense not to fire the load
event. Now that we process data asynchronously with the threaded
parser, the DocumentLoader is not always on the stack, which means we
need to delay the load event using the clause that asks the parser
whether it is processing data.
Unfortunately, that clause is fragile because we can check for load
completion while we're switching parsers between the network-created
parser and a script-created parser. To avoid accidentially triggerin
the load event during these "gaps," this patch introduces a counter on
document to record how many parsers are active on the stack. While
that numer is non-zero, we'll delay the load event. When that number
reaches zero, we'll check for load complete.
That last step is required because the DocumentLoader::finishLoading
method is no longer guarunteed to check for load complete after calling
finish on the parser because the finish operation might complete
asynchronously.
After this patch, the threaded parser passes all but four fast/parser
tests.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::hasActiveParser):
(WebCore):
(WebCore::Document::decrementActiveParserCount):
- dom/Document.h:
(Document):
(WebCore::Document::incrementActiveParserCount):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLParserScheduler.cpp:
(WebCore::ActiveParserSession::ActiveParserSession):
(WebCore):
(WebCore::ActiveParserSession::~ActiveParserSession):
(WebCore::PumpSession::PumpSession):
(WebCore::PumpSession::~PumpSession):
- html/parser/HTMLParserScheduler.h:
(WebCore):
(ActiveParserSession):
(PumpSession):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense):
- 11:33 AM Changeset in webkit [142377] by
-
- 33 edits6 adds in trunk/Source/JavaScriptCore
DFG should allow phases to break Phi's and then have one phase to rebuild them
https://bugs.webkit.org/show_bug.cgi?id=108414
Reviewed by Mark Hahnenberg.
Introduces two new DFG forms: LoadStore and ThreadedCPS. These are described in
detail in DFGCommon.h.
Consequently, DFG phases no longer have to worry about preserving data flow
links between basic blocks. It is generally always safe to request that the
graph be dethreaded (Graph::dethread), which brings it into LoadStore form, where
the data flow is implicit. In this form, only liveness-at-head needs to be
preserved.
All of the machinery for "threading" the graph to introduce data flow between
blocks is now moved out of the bytecode parser and into the CPSRethreadingPhase.
All phases that previously did this maintenance themselves now just rely on
being able to dethread the graph. The one exception is the structure check
hoising phase, which operates over a threaded graph and preserves it, for the
sake of performance.
Also moved two other things into their own phases: unification (previously found
in the parser) and prediction injection (previously found in various places).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/Operands.h:
(Operands):
(JSC::Operands::sizeFor):
(JSC::Operands::atFor):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGAllocator.h:
(JSC::DFG::::allocateSlow):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCPSRethreadingPhase.cpp: Added.
(DFG):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::clearVariablesAtHeadAndTail):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
(JSC::DFG::CPSRethreadingPhase::addPhi):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):
(JSC::DFG::performCPSRethreading):
- dfg/DFGCPSRethreadingPhase.h: Added.
(DFG):
- dfg/DFGCSEPhase.cpp:
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.cpp:
(WTF):
(WTF::printInternal):
- dfg/DFGCommon.h:
(JSC::DFG::logCompilationChanges):
(DFG):
(WTF):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dethread):
(JSC::DFG::Graph::collectGarbage):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::performSubstitution):
(Graph):
(JSC::DFG::Graph::performSubstitutionForEdge):
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToPhantomLocal):
(Node):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::hasVariableAccessData):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
- dfg/DFGPhase.h:
(JSC::DFG::runAndLog):
- dfg/DFGPredictionInjectionPhase.cpp: Added.
(DFG):
(PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::run):
(JSC::DFG::performPredictionInjection):
- dfg/DFGPredictionInjectionPhase.h: Added.
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- dfg/DFGUnificationPhase.cpp: Added.
(DFG):
(UnificationPhase):
(JSC::DFG::UnificationPhase::UnificationPhase):
(JSC::DFG::UnificationPhase::run):
(JSC::DFG::performUnification):
- dfg/DFGUnificationPhase.h: Added.
(DFG):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::dump):
- runtime/JSString.h:
(JSString):
- runtime/Options.h:
(JSC):
- 11:29 AM Changeset in webkit [142376] by
-
- 2 edits in trunk/Tools
Add a link to EFL perf bot on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=109342
Reviewed by Gyuyoung Kim.
Added.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 11:19 AM Changeset in webkit [142375] by
-
- 39 edits in trunk/Source/WebCore
Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes.
https://bugs.webkit.org/show_bug.cgi?id=109295
Reviewed by Darin Adler.
The monster patch in http://wkbug.com/108771 missed an entire class of
ignored exceptions. It only dealt with call sites that never initialized
the ExceptionCode variable, on the assumption that only such call sites
would ignore the variable's value.
That was a flawed assumption: a large number of sites that initialize the
ExceptionCode to 0 ignore it regardless. This patch deals with the
almost-as-large set of callsites that initialize the variable, pass it to
a function, and then never touch it again.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::forceClose):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
- accessibility/atk/WebKitAccessibleUtil.cpp:
(selectionBelongsToObject):
- dom/Node.cpp:
(WebCore::Node::textRects):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::hide):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleAtSelectionStart):
- editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::shouldDeleteRange):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::setComposition):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::isFrameInRange):
- editing/EditorCommand.cpp:
(WebCore::expandSelectionToGranularity):
- editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
- editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply):
- editing/TextCheckingHelper.cpp:
(WebCore::expandToParagraphBoundary):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
- editing/TextInsertionBaseCommand.cpp:
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):
- editing/TextIterator.cpp:
(WebCore::findPlainText):
- editing/htmlediting.cpp:
(WebCore::extendRangeToWrappingNodes):
(WebCore::isNodeVisiblyContainedWithin):
- editing/visible_units.cpp:
(WebCore::nextBoundary):
- html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
- html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::didCompleteLoad):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
- html/track/TextTrackList.cpp:
(TextTrackList::asyncEventTimerFired):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- inspector/InspectorDatabaseAgent.cpp:
(WebCore):
- inspector/InspectorFileSystemAgent.cpp:
(WebCore):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange):
- page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleTouchEvent):
- page/FrameActionScheduler.cpp:
(WebCore::EventFrameAction::fire):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::dispatchZoomEvent):
(WebCore::SVGDocument::dispatchScrollEvent):
- svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::exitText):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::startDocument):
(WebCore::XMLDocumentParser::parseCharacters):
- 11:11 AM Changeset in webkit [142374] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my IRC nickname in committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 11:09 AM Changeset in webkit [142373] by
-
- 3 edits in trunk/Tools
build-webkit: document sdk, debug, release, device, and simulator options
https://bugs.webkit.org/show_bug.cgi?id=109221
Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.
- Scripts/build-webkit: Add options to usage
- Scripts/webkitdirs.pm: Remove --deploy and --devel checks
- 11:07 AM WebKit Team edited by
- Update my IRC nickname (diff)
- 11:05 AM Changeset in webkit [142372] by
-
- 6 edits in trunk/Source/WebCore
[skia] Fix memory management in SkiaImageFilterBuilder and friends.
https://bugs.webkit.org/show_bug.cgi?id=109326
Sadly, skia has no official ref-counted pointers, so we must make do
with SkAutoTUnref.
Reviewed by James Robinson.
Correctness covered by existing tests in css3/filters.
- platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::createImageFilter):
- platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::createImageFilter):
- platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::createImageFilter):
Adopt refs produced by the build() pass with SkAutoTUnref.
- platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
(WebCore::SkiaImageFilterBuilder::~SkiaImageFilterBuilder):
Unref the builder's hashmap effect pointers.
(WebCore::SkiaImageFilterBuilder::build):
Ref the pointer returned to the caller, and use SkAutoTUnref
internally while building the tree.
- platform/graphics/filters/skia/SkiaImageFilterBuilder.h:
(SkiaImageFilterBuilder):
Add a destructor to SkiaImageFilterBuilder.
- 11:01 AM Changeset in webkit [142371] by
-
- 8 edits in trunk/Tools
[chromium] move context menu data tracking to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109313
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::showContextMenu):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::setContextMenuData):
(WebTestRunner::EventSender::contextClick):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebKit):
(EventSender):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::showContextMenu):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::showContextMenu):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 10:55 AM Changeset in webkit [142370] by
-
- 9 edits in trunk/Tools
[chromium] move methods that change initial testRunner state to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109043
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::configureForTestWithURL):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::showDevTools):
(WebTestRunner):
(WebTestRunner::TestRunner::showWebInspector):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::configureForTestWithURL):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
- 10:41 AM Changeset in webkit [142369] by
-
- 2 edits in trunk/Tools
Add myself as a reviewer. (Yay!!!!!)
https://bugs.webkit.org/show_bug.cgi?id=109110
Unreviewed.
- Scripts/webkitpy/common/config/committers.py:
- 10:35 AM Changeset in webkit [142368] by
-
- 4 edits in trunk/Source/WebCore
AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
https://bugs.webkit.org/show_bug.cgi?id=108238
Reviewed by Chris Fleizach.
Simple refactoring, no new tests.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- 10:34 AM Changeset in webkit [142367] by
-
- 3 edits in trunk/Source/WebCore
[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since
non-null pointer is always expected.
https://bugs.webkit.org/show_bug.cgi?id=109079
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.
Cleanup change, no need to add new tests or modify the existing ones.
- rendering/TextAutosizer.cpp:
Changed parameter from a pointer to a reference in the methods below.
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isNarrowDescendant):
(WebCore::TextAutosizer::isWiderDescendant):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
- rendering/TextAutosizer.h: updated method prototypes.
- 10:15 AM Changeset in webkit [142366] by
-
- 10 edits1 copy5 adds in trunk/Source/WebCore
[TexMap] Separate classes per file in TextureMapperBackingStore.h
https://bugs.webkit.org/show_bug.cgi?id=109333
Reviewed by Noam Rosenthal.
TextureMapperBackingStore.h had the classes TextureMapperBackingStore,
TextureMapperTiledBackingStore, TextureMapperSurfaceBackingStore and
TextureMapperTile which was quite confusing. Now each one has its
own header and its own source file.
No new tests needed, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
- platform/graphics/texmap/TextureMapperBackingStore.h:
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp: Added.
(WebCore):
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.h: Added.
(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):
- platform/graphics/texmap/TextureMapperTile.cpp: Added.
(WebCore):
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTile::paint):
- platform/graphics/texmap/TextureMapperTile.h: Added.
(WebCore):
(TextureMapperTile):
(WebCore::TextureMapperTile::texture):
(WebCore::TextureMapperTile::rect):
(WebCore::TextureMapperTile::setTexture):
(WebCore::TextureMapperTile::setRect):
(WebCore::TextureMapperTile::~TextureMapperTile):
(WebCore::TextureMapperTile::TextureMapperTile):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp.
(WebCore):
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::adjustedTransformForRect):
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):
- platform/graphics/texmap/TextureMapperTiledBackingStore.h: Added.
(WebCore):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::create):
(WebCore::TextureMapperTiledBackingStore::~TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
- 10:02 AM Changeset in webkit [142365] by
-
- 3 edits2 adds in trunk
Sanitize m_keyTimes for paced value animations
https://bugs.webkit.org/show_bug.cgi?id=108828
Reviewed by Dirk Schulze.
Source/WebCore:
SVG animations with calcMode=paced calculate new m_keyTimes in
SVGAnimationElement::calculateKeyTimesForCalcModePaced() because paced animations do not
specify keyTimes. If an error occurs while calculating m_keyTimes, and there exists
user-specified values, a crash could occur because the user-specified values were not
sanitized.
This change clears user-specified keyTimes before calculating new ones.
Test: svg/animations/animate-keytimes-crash.html
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
LayoutTests:
- svg/animations/animate-keytimes-crash-expected.html: Added.
- svg/animations/animate-keytimes-crash.html: Added.
- 9:54 AM Changeset in webkit [142364] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set mouse document position for mouse event in updateCursor.
https://bugs.webkit.org/show_bug.cgi?id=109094.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-09
Reviewed by Rob Buis.
RIM PR 246976
Internally Reviewed by Genevieve Mak.
BlackBerry::Platform::MouseEvent have document viewport and document
content position as members. When we create the event, we should initial
them as well.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
- 9:52 AM Changeset in webkit [142363] by
-
- 6 edits in trunk/Source/WebCore
Fix TextDocumentParser to play nice with threading
https://bugs.webkit.org/show_bug.cgi?id=109240
Reviewed by Adam Barth.
Before the HTML5 parser re-write the text document parser
was completely custom. With the HTML5 parser, we just made
the TextDocumentParser use the HTMLDocumentParser with an
artificial script tag.
However, our solution was slightly over-engineered to avoid
lying about the column numbers of the first line of the text document
during parsing. :)
This change makes us use a simpler (and threading-compatible)
solution by just inserting a real "<pre>" tag into the
input stream instead of hacking one together with the treebuilder
and manually setting the Tokenizer state.
fast/parser/empty-text-resource.html covers this case.
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::TextDocumentParser):
(WebCore::TextDocumentParser::insertFakePreElement):
- 9:28 AM Changeset in webkit [142362] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
- DEPS: 181594
- 9:21 AM Changeset in webkit [142361] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to last-known good revision.
Requested by "Stephen Chenney" <schenney@chromium.org> via
sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09
- DEPS:
- 9:05 AM Changeset in webkit [142360] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Trying to turn the build.webkit.org builders greener
Unreviewed expectations.
We seem to have an issue with build.webkit.org test bots and
Chromium.WebKit test bots doing different things. This is temporary
until we figure out what went wrong.
- platform/chromium/TestExpectations: Re-adding all the changes due to Skia flags.
- 7:37 AM Changeset in webkit [142359] by
-
- 3 edits in trunk/Source/WebCore
Add missing copyright header
https://bugs.webkit.org/show_bug.cgi?id=107507
- Resources/pagepopups/chromium/calendarPickerChromium.css:
- Resources/pagepopups/chromium/pickerCommonChromium.css:
- 7:25 AM Changeset in webkit [142358] by
-
- 3 edits2 adds in trunk
Fix crash by img[ismap] with content property
https://bugs.webkit.org/show_bug.cgi?id=108702
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/dom/HTMLAnchorElement/anchor-ismap-crash.html
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
Check if the renderer of an img element is RenderImage.
LayoutTests:
- fast/dom/HTMLAnchorElement/anchor-ismap-crash-expected.txt: Added.
- fast/dom/HTMLAnchorElement/anchor-ismap-crash.html: Added.
- 7:16 AM Changeset in webkit [142357] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectation update.
- platform/chromium/TestExpectations:
Correct encrypted-media-v2-*.html expectation.
- 7:14 AM Changeset in webkit [142356] by
-
- 5 edits in trunk/Source/WebCore
Drop ExceptionCode from IDB's directionToString and modeToString.
https://bugs.webkit.org/show_bug.cgi?id=109143
Reviewed by Jochen Eisinger.
No caller of either IDBCursor::directionToString or
IDBTransaction::modeToString makes use of the ExceptionCode these
methods require. This patch removes the 'ExceptionCode&' parameter from
both methods and their callsites.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::directionToString):
Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::modeToString):
Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.
- Modules/indexeddb/IDBTransaction.h:
- 7:10 AM Changeset in webkit [142355] by
-
- 12 edits1 copy1 add2 deletes in trunk
[EFL][Qt][WebGL] Share the common code between GraphicsSurfaceGLX and X11WindowResources.
https://bugs.webkit.org/show_bug.cgi?id=106666
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This patch removes any duplicate code in X11WindowResources and
GraphicsSurfaceGLX. No new functionality is added.
- PlatformEfl.cmake:
- Target.pri:
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore::EGLConfigSelector::pixmapContextConfig):
- platform/graphics/surfaces/egl/EGLConfigSelector.h:
(EGLConfigSelector):
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):
- platform/graphics/surfaces/egl/EGLSurface.h:
(WebCore):
(EGLWindowTransportSurface):
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):
- platform/graphics/surfaces/glx/GLXContext.cpp:
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):
- platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::initialize):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initialize):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
No new functionality added. Made changes to take the common code into use.
- platform/graphics/surfaces/glx/X11WindowResources.h: Removed.
- platform/graphics/surfaces/glx/X11Helper.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp.
(WebCore):
(WebCore::DisplayConnection::DisplayConnection):
(DisplayConnection):
(WebCore::DisplayConnection::~DisplayConnection):
(WebCore::DisplayConnection::display):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::OffScreenRootWindow::rootWindow):
(WebCore::X11Helper::resizeWindow):
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::destroyWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
(WebCore::X11Helper::nativeDisplay):
(WebCore::X11Helper::offscreenRootWindow):
- platform/graphics/surfaces/glx/X11Helper.h: Added.
(WebCore):
(WebCore::handleXPixmapCreationError):
(X11Helper):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Moved common code from GraphicsSurfaceGLX to X11Helper.
- 6:58 AM Changeset in webkit [142354] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for the test introduced in r142335.
- 6:31 AM Changeset in webkit [142353] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/text/international/bidi-ignored-for-first-child-inline.html
after r142152.
- platform/efl/TestExpectations:
- platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- 3:51 AM Changeset in webkit [142352] by
-
- 2 edits in trunk
Unreviewed, another GTK+ build fix after r142343.
- Source/autotools/symbols.filter: Expose the InlineBox delete operator.
- 1:58 AM Changeset in webkit [142351] by
-
- 7 edits2 adds in trunk
Web Inspector: show whitespace characters in DTE
https://bugs.webkit.org/show_bug.cgi?id=108947
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-09
Reviewed by Pavel Feldman.
Source/WebCore:
New test: inspector/editor/text-editor-show-whitespaces.html
Split consecutive whitespace characters into groups of 16, 8, 4, 2 and 1 and
add ::before pseudoclass for this groups which contains necessary
amount of "dots" (u+00b7). Add a setting "Show whitespace" for this
option in "Sources" section of "General" tab.
- English.lproj/localizedStrings.js:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._renderWhitespaceCharsWithFixedSizeSpans):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-whitespace-1::before):
(.webkit-whitespace-2::before):
(.webkit-whitespace-4::before):
(.webkit-whitespace-8::before):
(.webkit-whitespace-16::before):
(.webkit-whitespace::before):
LayoutTests:
Add layout test to verify whitespace highlight functionality.
- inspector/editor/text-editor-show-whitespace-expected.txt: Added.
- inspector/editor/text-editor-show-whitespace.html: Added.
Feb 8, 2013:
- 10:13 PM Changeset in webkit [142350] by
-
- 2 edits in trunk/Source/WebKit2
Fix ASSERT when the Web Content Process crashes
https://bugs.webkit.org/show_bug.cgi?id=109346
Reviewed by Simon Fraser.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
We need to remove ourselves as a message receiver before calling out to the client, as
the client might want to re-add us (as Safari does).
- 9:52 PM Changeset in webkit [142349] by
-
- 16 edits2 adds in trunk
[Mac] respect in-band caption color
https://bugs.webkit.org/show_bug.cgi?id=109203
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/track/track-in-band-style.html
- WebCore.xcodeproj/project.pbxproj: Add HTMLDivElement.h to private headers because it is
included by HTMLTextElement, which is included by HTMLMediaElement.h, which is included
by files in WebKit/WebKit2.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue): Set cue colors if necessary.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::element): New, accessor for the cue element so it can be styled.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set container and cue background
color if necessary.
(WebCore::TextTrackCueGeneric::operator==): Compare cue colors.
- html/track/TextTrackCueGeneric.h:
(WebCore::TextTrackCueGeneric::foregroundColor): Add color accessors.
(WebCore::TextTrackCueGeneric::setForegroundColor):
(WebCore::TextTrackCueGeneric::backgroundColor):
(WebCore::TextTrackCueGeneric::setBackgroundColor):
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Always
regenerate override CSS when an element registers for callbacks.
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Drive by fix of "window color" padding.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Log the stylesheet generated
for easier debugging.
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::foregroundColor): Add color getters/setters.
(WebCore::GenericCueData::setForegroundColor):
(WebCore::GenericCueData::backgroundColor):
(WebCore::GenericCueData::setBackgroundColor):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::makeRGBA32FromARGBCFArray): Initialize a RGBA32 from a CFArray of color values.
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process cue colors.
LayoutTests:
- media/track/track-in-band-style-expected.txt: Added.
- media/track/track-in-band-style.html: Added.
- platform/chromium/TestExpectations: Skip new test.
- platform/efl/TestExpectations: Ditto.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 9:17 PM Changeset in webkit [142348] by
-
- 49 edits1 delete in trunk
Move workerThreadCount from TestRunner to WebCore Internals
https://bugs.webkit.org/show_bug.cgi?id=109239
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-08
Reviewed by Darin Adler.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Add the new read-only property workerThreadCount.
- testing/Internals.cpp:
(WebCore::Internals::workerThreadCount):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
Get rid of WebWorkersPrivate, which was only needed for DRT.
- WebKit.exp:
- Workers/WebWorkersPrivate.h: Removed.
- Workers/WebWorkersPrivate.mm: Removed.
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebProcess/WebPage/WebFrame.cpp: Remove a useless #include.
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticValues):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::webHistoryItemCount):
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
Update the tests testRunner->internals.
- fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
- fast/workers/resources/worker-lifecycle.js:
(runTests.worker.onmessage):
(runTests):
- fast/workers/resources/worker-util.js:
(.return):
(waitUntilThreadCountMatches):
- fast/workers/worker-close-more.html:
- http/tests/workers/resources/worker-util.js:
(.return):
(waitUntilThreadCountMatches):
- 8:21 PM Changeset in webkit [142347] by
-
- 5 edits in trunk
Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273
Reviewed by Simon Fraser.
Source/WebKit2:
Remove any use of plugInStartLabelImage. While there, implement plugInStartLabelTitle
and plugInStartLabelSubtitle to return the values from the client.
implement them.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Remove callback and entry from client structure.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle): Ask the client bundle for value.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle): Ditto.
Tools:
Removed plugInStartLabelImage entry from client structure.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- 8:04 PM Changeset in webkit [142346] by
-
- 2 edits in trunk
Only a fool would cut and paste from a terminal showing truncated git logs.
I am that fool.
Export the full symbol for InlineBox::nodeAtPoint.
- Source/autotools/symbols.filter:
- 7:58 PM Changeset in webkit [142345] by
-
- 2 edits in trunk
Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Unreviewed GTK+ build fix.
- Source/autotools/symbols.filter: Export InlineBox symbols.
- 7:42 PM Changeset in webkit [142344] by
-
- 2 edits in trunk/Tools
Fix the WebInspectorAPI watch list.
Reviewed by Joseph Pecoraro.
- Scripts/webkitpy/common/config/watchlist: Fix the regrexs.
Added InjectedScriptSource.js and Console.idl.
- 7:29 PM Changeset in webkit [142343] by
-
- 21 edits in trunk/Source
Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Reviewed by Simon Fraser.
Take two! This time with updated exports file.
A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.
The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.
In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.
Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.
- WebCore.exp.in: Export the InlineBox interface.
- css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.
- platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- platform/chromium/LocalizedStringsChromium.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
displayState for snapshots.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
a snapshot should be immediately labeled.
- page/ChromeClient.h: No need for plugInStartLabelImage any more.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
(InjectedBundlePageUIClient):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 7:08 PM Changeset in webkit [142342] by
-
- 2 edits in trunk/LayoutTests
Disable All WebGL Tests on WebKit for Windows
https://bugs.webkit.org/show_bug.cgi?id=109207
Unreviewed expectations update.
- platform/win/TestExpectations:
- 6:42 PM Changeset in webkit [142341] by
-
- 20 edits in trunk/Source
Rolling out r142333 and r142337 which broke Mac Release builds.
- 6:40 PM Changeset in webkit [142340] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r142337.
http://trac.webkit.org/changeset/142337
https://bugs.webkit.org/show_bug.cgi?id=109339
Breaking Mac release builds (Requested by dino_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08
- rendering/RenderSnapshottedPlugIn.h:
- 6:34 PM Changeset in webkit [142339] by
-
- 9 edits in trunk/Source/WebKit2
Move plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109337
<rdar://problem/12015046>
Reviewed by Andreas Kling.
Plug-in enumeration was moved to a separate work queue to improve responsiveness, but
doing so lead to crashes when WebKit1 would enumerate plug-ins on the main thread at the same time.
Bug <rdar://problem/13185819> tracks fixing the responsiveness issue by spawning a plug-in process
and have it do the enumeration.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
(WebKit::WebProcessProxy::getPlugins):
- UIProcess/WebProcessProxy.h:
(WebCore):
(WebProcessProxy):
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit):
(WebKit::WebPlatformStrategies::populatePluginCache):
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/WebProcess.messages.in:
- 6:20 PM Changeset in webkit [142338] by
-
- 7 edits in trunk/LayoutTests
Some tiled drawing tests use scalePageBy() incorrectly
https://bugs.webkit.org/show_bug.cgi?id=109336
Rubber-stamped by Simon Fraser.
scalePageBy takes (scale, x, y). Some of the tiled drawing tests are incorrectly handing them (scale, scale).
Adjust the tests and the expected results.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html:
- 6:07 PM Changeset in webkit [142337] by
-
- 2 edits in trunk/Source/WebCore
Attempted Mac and GTK build fix after r142333.
- rendering/RenderSnapshottedPlugIn.h: Include InlineBox.h.
- 5:58 PM Changeset in webkit [142336] by
-
- 2 edits in trunk/Source/WTF
ARM_NEON Inline Assembly for copyLCharsFromUCharSource() inefficient for aligned destinations
https://bugs.webkit.org/show_bug.cgi?id=109335
Reviewed by Filip Pizlo.
Change a "do while" to a "while" so that we don't copy single characters to align the
destination when it is already aligned.
- wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
- 5:48 PM Changeset in webkit [142335] by
-
- 4 edits2 adds2 deletes in trunk
Restore pre-r118852 behavior for EllipsisBox::nodeAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=109277
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/flexbox/line-clamp-link-after-ellipsis.html
Roll out r118852. Enough time has passed that this can't be done
mechanically, so transcribe the old method definition to current
WebCore interfaces.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::markupBox): EllipsisBox no longer has
m_markupBox, so break the logic for finding the markup box from
paintMarkupBox() into its own function.
(WebCore::EllipsisBox::paintMarkupBox): Call markupBox().
(WebCore::EllipsisBox::nodeAtPoint): Transcribe the pre-r118852 implementation.
- rendering/EllipsisBox.h:
(EllipsisBox): Declare markupBox().
LayoutTests:
Remove test added by r118852 and add a test that verifies the original
expected behavior.
- fast/css/text-overflow-ellipsis-hit-test-expected.txt: Removed.
- fast/css/text-overflow-ellipsis-hit-test.html: Removed.
- fast/flexbox/line-clamp-link-after-ellipsis-expected.txt: Added.
- fast/flexbox/line-clamp-link-after-ellipsis.html: Added.
- 5:32 PM Changeset in webkit [142334] by
-
- 2 edits in trunk/Source/WebCore
[Mac] In-band closed caption tracks are not always initialized correctly
https://bugs.webkit.org/show_bug.cgi?id=109323
Reviewed by Dean Jackson.
No new tests, makes existing tests less flakey.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Create and configure legible output
here instad of in tracksChanged.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing in a build with
in-band track support.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Move legible output creation to
createAVPlayerItem, don't set look at track media type to see if the movie has captions
when we have support for in-band captions.
- 5:24 PM Changeset in webkit [142333] by
-
- 20 edits in trunk/Source
Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284
Reviewed by Simon Fraser.
Source/WebCore:
A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.
The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.
In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.
Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.
- css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.
- platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
- platform/LocalizedStrings.h:
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
- platform/chromium/LocalizedStringsChromium.cpp:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
displayState for snapshots.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
a snapshot should be immediately labeled.
- page/ChromeClient.h: No need for plugInStartLabelImage any more.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.
Source/WebKit2:
We no longer have any need for plugInStartLabelImage.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
- 4:45 PM Changeset in webkit [142332] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Expectation modification after r142327
Unreviewed expectations update.
The test from "Bring WebKit up to speed with latest Encrypted Media spec" is slow.
- platform/chromium/TestExpectations:
- 4:41 PM Changeset in webkit [142331] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
[Chromium] Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
A remaining textual fix.
- editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- 4:28 PM Changeset in webkit [142330] by
-
- 2 edits1 delete in trunk/LayoutTests
[Mac] Unreviewed rebaseline
- platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Removed.
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
- 4:20 PM Changeset in webkit [142329] by
-
- 7 edits in trunk/Source/WebCore
{FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=109265
Reviewed by Dimitri Glazkov.
Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp.
We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.
No tests. No change in behavior.
- dom/EventDispatchMediator.cpp:
- dom/EventDispatchMediator.h:
- dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
- dom/FocusEvent.h:
(WebCore):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
- dom/UIEvent.cpp:
- dom/UIEvent.h:
- 4:13 PM Changeset in webkit [142328] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. MSVC (and other compilers) need a default: case in switch statement.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::notificationName):
- 3:31 PM Changeset in webkit [142327] by
-
- 30 edits8 copies16 adds in trunk
Bring WebKit up to speed with latest Encrypted Media spec.
https://bugs.webkit.org/show_bug.cgi?id=97037
Reviewed by Eric Carlson.
Source/JavaScriptCore:
Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
The most recent version of the Encrypted Media Extensions spec breaks functionality out of the
HTMLMediaElement and into new MediaKeys and MediaKeySession classes. Since the CDM functionality
has been pulled out of the media element, we create a proxy CDM class and factory system for
creating specific CDM key system implementations. The spec also breaks out MediaKeyEvent
into distinct event classes, MediaKeyNeededEvent and MediaKeyMessageEvent, for needkey and
keymessage events, respectively.
Tests: media/encrypted-media/encrypted-media-v2-events.html
media/encrypted-media/encrypted-media-v2-syntax.html
CDM is a proxy class (a la MediaPlayer) for a specific CDMPrivateInterface implementation. A CDM
implementation is registered with the CDMFactory and will be created if that implementation supports
the key system passed into the MediaKeys constructor. CDMSession is a pure-virtual interface exposed
by concrete CDMPrivate subclasses. Its lifetime is owned by MediaKeySession.
- Modules/encryptedmedia/CDM.cpp: Added.
(WebCore::installedCDMFactories): Initialize all the known CDM subtypes. Ports will add CDM implementations here.
(WebCore::CDM::registerCDMFactory): Registers a new CDMFactory using the passed in function pointers.
(WebCore::CDMFactoryForKeySystem): Return the first CDM factory which supports the requested key system.
(WebCore::CDM::supportsKeySystem): Walk the installed CDMs and ask if the given key system is supported.
(WebCore::CDM::supportsKeySystemMIMETypeAndCodec): Ditto, with an additional MIME type and codec string.
(WebCore::CDM::create): Simple constructor wrapper.
(WebCore::CDM::CDM): Simple constructor; calls bestCDMForKeySystem() to create it's private implementation.
(WebCore::CDM::~CDM): Simple destructor.
(WebCore::CDM::createSession): Creates a new CDMSession.
- Modules/encryptedmedia/CDM.h: Added.
(WebCore::CDM::keySystem): Simple accessor for m_keySystem.
(WebCore::CDMSession::CDMSession): Simple constructor.
(WebCore::CDMSession::~CDMSession): Simple destructor.
- Modules/encryptedmedia/CDMPrivate.h: Added.
(WebCore::CDMPrivateInterface::CDMPrivateInterface): Simple constructor.
(WebCore::CDMPrivateInterface::~CDMPrivateInterface): Simple destructor.
The new classes, MediaKeyMessageEvent and MediaKeyNeededEvent, take distinct subsets of the initializers of
the original MediaKeyMessageEvent.
- Modules/encryptedmedia/MediaKeyMessageEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.cpp.
(WebCore::MediaKeyMessageEventInit::MediaKeyMessageEventInit): Initializer now only takes message and destinationURL
parameters.
(WebCore::MediaKeyMessageEvent::MediaKeyMessageEvent): Simple constructor.
(WebCore::MediaKeyMessageEvent::~MediaKeyMessageEvent): Simple destructor.
(WebCore::MediaKeyMessageEvent::interfaceName): Standard interfaceName.
- Modules/encryptedmedia/MediaKeyMessageEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyMessageEvent::create): Simple construction wrapper.
(WebCore::MediaKeyMessageEvent::message): Simple accessor for m_message.
(WebCore::MediaKeyMessageEvent::destinationURL): Simple accessor for m_destinationURL.
- Modules/encryptedmedia/MediaKeyMessageEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.
- Modules/encryptedmedia/MediaKeyNeededEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyNeededEventInit::MediaKeyNeededEventInit): Initializer now only takes initData parameter.
(WebCore::MediaKeyNeededEvent::MediaKeyNeededEvent): Simple constructor.
(WebCore::MediaKeyNeededEvent::~MediaKeyNeededEvent): Simple destructor.
(WebCore::MediaKeyNeededEvent::interfaceName): Standard interfaceName.
- Modules/encryptedmedia/MediaKeyNeededEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyNeededEvent::create): Simple construction wrapper.
(WebCore::MediaKeyNeededEvent::initData): Simple accessor for m_initData.
- Modules/encryptedmedia/MediaKeyNeededEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.
MediaKeySession is a new class that maps keys and key requests to a given session ID:
- Modules/encryptedmedia/MediaKeySession.cpp: Added.
(WebCore::MediaKeySession::create): Simple construction wrapper.
(WebCore::MediaKeySession::MediaKeySession): Simple constructor.
(WebCore::MediaKeySession::~MediaKeySession): Simple destructor; calls close().
(WebCore::MediaKeySession::setError): Simple setter for m_error;
(WebCore::MediaKeySession::close): Tell the CDM to clear any saved session keys.
(WebCore::MediaKeySession::generateKeyRequest): Start a one-shot timer, handled in keyRequestTimerFired.
(WebCore::MediaKeySession::keyRequestTimerFired): Follow the steps in the spec; ask the CDM to generate a key request.
(WebCore::MediaKeySession::addKey): Start a one-shot timer, handled in addKeyTimerFired.
(WebCore::MediaKeySession::addKeyTimerFired): Follow the steps in the spec; provide the key data to the CDM.
- Modules/encryptedmedia/MediaKeySession.h: Added.
(WebCore::MediaKeySession::keySystem): Simple accessor for m_keySystem.
(WebCore::MediaKeySession::sessionId): Simple accessor for m_sessionId.
(WebCore::MediaKeySession::error): Simple accessor for m_error;
- Modules/encryptedmedia/MediaKeySession.idl:
MediaKeySession inherits from EventTarget, and must override the pure virtual functions in that class:
- Modules/encryptedmedia/MediaKeySession.cpp: Added.
(WebCore::MediaKeySession::interfaceName):
- Modules/encryptedmedia/MediaKeySession.h: Added.
(WebCore::MediaKeySession::refEventTarget):
(WebCore::MediaKeySession::derefEventTarget):
(WebCore::MediaKeySession::eventTargetData):
(WebCore::MediaKeySession::ensureEventTargetData):
(WebCore::MediaKeySession::scriptExecutionContext):
MediaKeys is a new class that encapsulates a CDM and a number of key sessions:
- Modules/encryptedmedia/MediaKeys.cpp: Added.
(WebCore::MediaKeys::create): Throw an exception if the key system parameter is unsupported; create a CDM object
and a new MediaKeys session.
(WebCore::MediaKeys::MediaKeys): Simple constructor.
(WebCore::MediaKeys::~MediaKeys): Simple destructor.
(WebCore::MediaKeys::createSession): Follow the spec and create a new key session.
- Modules/encryptedmedia/MediaKeys.h: Added.
- Modules/encryptedmedia/MediaKeys.idl: Copied from Source/WebCore/html/MediaError.idl.
Provide a new interface to HTMLMediaElement for MediaPlayer which does not require a sessionId or a key system:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyNeeded):
MediaKeyError now has a systemCode parameter and member variable.
- html/MediaKeyError.h:
(WebCore::MediaKeyError::create): Take a systemCode parameter with a default (0) value.
(WebCore::MediaKeyError::MediaKeyError): Ditto.
(WebCore::MediaKeyError::systemCode): Simple accessor for m_systemCode.
- html/MediaKeyError.idl:
Add new methods to HTMLMediaElement to support MediaKeys. Support different initializer
for the MediaKeyNeededEvent.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaKeys): Simple setter for m_mediaKeys.
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded): This version takes fewer parameters
than the deprecated version.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaKeys): Simple accessor for m_mediaKeys.
- html/HTMLMediaElement.idl: Add the mediaKeys attribute.
Add an ENABLE(ENCRYPTED_MEDIA_V2) check to the existing ENABLE(ENCRYPTED_MEDIA) one:
- html/MediaError.h:
- html/MediaError.idl:
- platform/graphics/MediaPlayer.cpp:
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::supportsType):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::keyNeeded): This version takes fewer parameters than the
deprecated version.
Support the new version of canPlayType which takes an extra parameter:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationObjC::extendedSupportsType):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
(WebCore::MediaPlayerPrivateQTKit::extendedSupportsType):
Add a mock CDM for use within DRT and WKTR to test the MediaKeys and MediaKeySession
APIs and events:
- testing/Internals.cpp:
(WebCore::Internals::initializeMockCDM): Add the MockCDM class to the CDM factories.
- testing/Internals.h:
- testing/Internals.idl: Add the initializeMockCDM() method.
- testing/MockCDM.cpp: Added.
(WebCore::MockCDM::supportsKeySystem): Only supports the 'com.webcore.mock' key system.
(WebCore::MockCDM::supportsMIMEType): Only supports the 'video/mock' mime type.
(WebCore::initDataPrefix): Static method which returns a Uint8Array containing 'mock'.
(WebCore::keyPrefix): Static method which returns a Uint8Array containing 'key'.
(WebCore::keyRequest): Static method which returns a Uint8Array containing 'request'.
(WebCore::generateSessionId): Return a monotonically increasing number.
(WebCore::MockCDMSession::MockCDMSession): Simple constructor.
(WebCore::MockCDMSession::generateKeyRequest): Ignores the parameters and returns a keyRequest() array.
(WebCore::MockCDMSession::releaseKeys): No-op.
(WebCore::MockCDMSession::addKey): Checks that the key starts with the keyPrefix() array.
- testing/MockCDM.h: Added.
(WebCore::MockCDM::create):
(WebCore::MockCDM::~MockCDM): Simple destructor.
(WebCore::MockCDM::MockCDM): Simple constructor.
Add the new classes to the built system:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Miscelaneous changes:
- dom/EventNames.in: Add the two new event types, MediaKeyMessageEvent and MediaKeyNeededEvent.
- dom/EventTargetFactory.in: Add the new EventTarget, MediaKeySession.
- page/DOMWindow.idl: Add constructors for the new classes to the window object.
Source/WTF:
Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.
- wtf/Platform.h:
LayoutTests:
Added new tests for the updated Encrypted Media Extensions spec.
- media/encrypted-media/encrypted-media-v2-events-expected.txt: Added.
- media/encrypted-media/encrypted-media-v2-events.html: Added.
- media/encrypted-media/encrypted-media-v2-syntax-expected.txt: Added.
- media/encrypted-media/encrypted-media-v2-syntax.html: Added.
- platform/Chromium/TestExpectations: Skip the new media/encrypted-media/ v2 tests.
- platform/mac/media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.
- 3:04 PM Changeset in webkit [142326] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Fix the build on !Mac after r142314.
https://bugs.webkit.org/show_bug.cgi?id=109327
Reviewed by Benjamin Poulain.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPreInitialize): Add a stub for
the newly-added function.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):
- 3:02 PM Changeset in webkit [142325] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Why does this test always fail to be correctly rebaselined during mass updates?
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 2:48 PM Changeset in webkit [142324] by
-
- 3 edits in trunk/LayoutTests
IndexedDB: De-flake open-during-transaction layout test
https://bugs.webkit.org/show_bug.cgi?id=109072
Reviewed by Tony Chang.
This test was observed to be flaky in local runs; sometimes the transaction
would terminate after the third open() call rather than the second, resulting
in a TEXT difference. Added code to keep the transaction alive until all of
the open() calls are complete, and changed expectations to match.
- storage/indexeddb/open-during-transaction-expected.txt:
- storage/indexeddb/resources/open-during-transaction.js:
- 2:35 PM Changeset in webkit [142323] by
-
- 11 edits1 add4 deletes in trunk/LayoutTests
[Chromium] Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Cleaning up the remaining failures. With luck this is it, although probably not.
- platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
- platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
- platform/chromium-mac-lion/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/media/video-zoom-controls-expected.png:
- 2:18 PM Changeset in webkit [142322] by
-
- 611 edits3 adds1 delete in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 19. The last, except for cleanup. Too many to list.
- platform/chromium/TestExpectations:
- 1:46 PM Changeset in webkit [142321] by
-
- 457 edits10 adds14 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 18. SVG all but dynamic-updates and custom tests. List omitted
except for changes touching other ports.
- platform/chromium/TestExpectations:
- platform/efl-wk2/svg/css/circle-in-mask-with-shadow-expected.png: Added.
- platform/efl-wk2/svg/css/group-with-shadow-expected.png: Added.
- platform/efl-wk2/svg/css/text-gradient-shadow-expected.png: Added.
- platform/efl/svg/batik/text/textEffect-expected.png: Removed.
- platform/efl/svg/batik/text/textEffect2-expected.png: Removed.
- platform/efl/svg/batik/text/textProperties2-expected.png: Removed.
- platform/efl/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
- platform/efl/svg/css/group-with-shadow-expected.png: Removed.
- platform/efl/svg/css/text-gradient-shadow-expected.png: Removed.
- platform/mac/svg/batik/text/textPosition2-expected.txt: Removed.
- platform/win-future/svg/batik/text/textPosition2-expected.txt: Added.
- svg/batik/text/textPosition2-expected.txt: Replaced.
- 1:45 PM Changeset in webkit [142320] by
-
- 9 edits8 copies1 move in trunk/Source/WebCore
Refactor platform-specific code in SpeechSynthesis
https://bugs.webkit.org/show_bug.cgi?id=107414
Reviewed by Sam Weinig.
Refactor WebSpeech code to use a platform mechanism to provide access to platform resources.
- Modules/speech/DOMWindowSpeechSynthesis.cpp:
(WebCore::DOMWindowSpeechSynthesis::from):
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore):
(WebCore::SpeechSynthesis::voicesDidChange):
(WebCore::SpeechSynthesis::getVoices):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
- Modules/speech/SpeechSynthesis.h:
(WebCore):
(SpeechSynthesis):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::voiceURI):
(WebCore::SpeechSynthesisUtterance::setVoiceURI):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
- Modules/speech/SpeechSynthesisVoice.cpp:
(WebCore::SpeechSynthesisVoice::create):
(WebCore::SpeechSynthesisVoice::SpeechSynthesisVoice):
- Modules/speech/SpeechSynthesisVoice.h:
(SpeechSynthesisVoice):
(WebCore::SpeechSynthesisVoice::voiceURI):
(WebCore::SpeechSynthesisVoice::name):
(WebCore::SpeechSynthesisVoice::lang):
(WebCore::SpeechSynthesisVoice::localService):
(WebCore::SpeechSynthesisVoice::isDefault):
- Modules/speech/mac/SpeechSynthesisMac.mm:
- WebCore.xcodeproj/project.pbxproj:
- platform/PlatformSpeechSynthesis.h: Added.
(WebCore):
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisUtterance.h: Added.
(WebCore):
(PlatformSpeechSynthesisUtteranceClient):
(WebCore::PlatformSpeechSynthesisUtteranceClient::~PlatformSpeechSynthesisUtteranceClient):
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::text):
(WebCore::PlatformSpeechSynthesisUtterance::setText):
(WebCore::PlatformSpeechSynthesisUtterance::lang):
(WebCore::PlatformSpeechSynthesisUtterance::setLang):
(WebCore::PlatformSpeechSynthesisUtterance::voiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::setVoiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::volume):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::rate):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::pitch):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
- platform/PlatformSpeechSynthesisVoice.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisVoice.h: Added.
(WebCore):
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):
(WebCore::PlatformSpeechSynthesisVoice::isDefault):
- platform/PlatformSpeechSynthesizer.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
- platform/PlatformSpeechSynthesizer.h: Added.
(WebCore):
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizerClient::~PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::voiceList):
- platform/mac/PlatformSpeechSynthesisMac.mm: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesis::create):
(WebCore::PlatformSpeechSynthesis::PlatformSpeechSynthesis):
(WebCore::PlatformSpeechSynthesis::platformSpeak):
- platform/mac/PlatformSpeechSynthesizerMac.mm: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
- 1:41 PM Changeset in webkit [142319] by
-
- 8 edits in trunk/Source/JavaScriptCore
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889
Reviewed by Joseph Pecoraro
Following up on review comments, mostly typos.
- API/JSBlockAdaptor.h:
- API/JSBlockAdaptor.mm:
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
- API/JSContext.h:
- API/JSExport.h:
- API/JSValue.h:
- API/JSValue.mm:
- API/JSWrapperMap.mm:
(selectorToPropertyName):
(-[JSWrapperMap classInfoForClass:]):
(-[JSWrapperMap wrapperForObject:]):
- 1:18 PM Changeset in webkit [142318] by
-
- 666 edits2 adds in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 17. SVG W3C tests. List omitted.
- platform/chromium/TestExpectations:
- 1:04 PM Changeset in webkit [142317] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed, fix test expectation for a test only crashing in debug mode
- platform/mac/TestExpectations:
- 1:00 PM Changeset in webkit [142316] by
-
- 37 edits33 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 16. Everything done but SVG, and cleanup.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Removed.
- platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/core: Removed.
- platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/dom: Removed.
- platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/other: Removed.
- platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Removed.
- platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
- platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
- platform/chromium-linux/tables/mozilla/core/margins-expected.png:
- platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
- platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
- platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
- platform/chromium/TestExpectations:
- 12:54 PM Changeset in webkit [142315] by
-
- 48 edits12 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 15. platform/. Too many to list.
- platform/chromium/TestExpectations:
- 12:46 PM Changeset in webkit [142314] by
-
- 6 edits in trunk/Source/WebKit2
Work around a bug in Flash where NSException objects can be released too early
https://bugs.webkit.org/show_bug.cgi?id=109242
<rdar://problem/13003470>
Reviewed by Darin Adler.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
Set the new plug-in quirk.
- Shared/Plugins/PluginQuirks.h:
Add a new plug-in quirk.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize):
Call platformPreInitialize.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
Add platformPreInitialize.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NSException_release):
Add new empty function.
(WebKit::NetscapePlugin::platformPreInitialize):
Patch -[NSException release] to be a no-op.
- 12:45 PM Changeset in webkit [142313] by
-
- 178 edits1 add28 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 14. Remaining tests up to platform in sorted order. Too many to list.
- platform/chromium/TestExpectations:
- 12:35 PM Changeset in webkit [142312] by
-
- 153 edits13 adds62 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 13. Last of the fast tests. Too many to list. Still listing efl changes.
- platform/chromium/TestExpectations:
- platform/chromium/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
- platform/efl-wk2/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
- platform/efl-wk2/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
- platform/efl-wk2/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
- platform/efl-wk2/fast/repaint/shadow-multiple-vertical-expected.png: Added.
- platform/efl-wk2/fast/text: Added.
- platform/efl-wk2/fast/text/stroking-decorations-expected.png: Added.
- platform/efl-wk2/fast/text/stroking-expected.png: Added.
- platform/efl-wk2/fast/transforms: Added.
- platform/efl-wk2/fast/transforms/shadows-expected.png: Added.
- platform/efl-wk2/fast/transforms/transformed-focused-text-input-expected.png: Added.
- platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
- platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
- platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
- platform/efl/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
- platform/efl/fast/text/stroking-decorations-expected.png: Removed.
- platform/efl/fast/text/stroking-expected.png: Removed.
- platform/efl/fast/transforms/shadows-expected.png: Removed.
- platform/efl/fast/transforms/transformed-focused-text-input-expected.png: Removed.
- platform/mac/fast/replaced/three-selects-break-expected.png: Removed.
- 12:24 PM Changeset in webkit [142311] by
-
- 4 edits in trunk/Source/WebCore
Put snapshotting label text into localizable strings
https://bugs.webkit.org/show_bug.cgi?id=108268
Reviewed by Simon Fraser.
In preparation for a snapshotted plug-in using a ShadowRoot, allow
its label to be localized.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
(WebCore::snapshottedPlugInLabelTitle): New method for returning title.
(WebCore::snapshottedPlugInLabelSubtitle): New method for returning subtitle.
- platform/LocalizedStrings.h:
- 12:23 PM Changeset in webkit [142310] by
-
- 4 edits in trunk/Source
Do not register autostart for plugins from file:// (or nowhere)
https://bugs.webkit.org/show_bug.cgi?id=108271
Reviewed by Tim Horton.
Source/WebCore:
If the page url origin is treated as a local URL, don't attempt
to add it to the auto-start list.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
Source/WebKit2:
If the pageOrigin is the empty string don't add
it to the auto-start origin list for snapshotting.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addPlugInAutoStartOrigin):
- 12:18 PM Changeset in webkit [142309] by
-
- 2 edits in trunk
Update .gitignore for vim swap files.
https://bugs.webkit.org/show_bug.cgi?id=109252
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-08
Reviewed by Dirk Pranke.
When opening the same files multiple with vim, vim creates a .*.sw[a-p]
file as the swap file.
- .gitignore:
- 11:48 AM Changeset in webkit [142308] by
-
- 266 edits4 adds94 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 12. More fast tests. Too many to list.
- platform/chromium/TestExpectations:
- 11:41 AM Changeset in webkit [142307] by
-
- 20 edits3 adds20 deletes in trunk
Unreviewed. VS2010 WebKit Solution touchups.
Remove all .user files.
Add some build scripts to QTMovieWin that were forgotten about earlier.
Update the OpenSource WebKit solution to include DumpRenderTree and related projects.
- WebKit.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
- WebKit.vcxproj/Interfaces: Added property svn:ignore.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Removed.
- WebKit.vcxproj/WebKit: Added property svn:ignore.
- WebKit.vcxproj/WebKit.sln:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Removed.
- WebKit.vcxproj/WebKitExportGenerator: Added property svn:ignore.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Removed.
- WebKit.vcxproj/WebKitGUID: Added property svn:ignore.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Removed.
- WebCore.vcxproj: Added properties svn:ignore and svn:ignore.
- WebCore.vcxproj/QTMovieWin: Added property svn:ignore.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.user: Removed.
- WebCore.vcxproj/QTMovieWin/QTMovieWinPostBuild.cmd: Added.
- WebCore.vcxproj/QTMovieWin/QTMovieWinPreBuild.cmd: Added.
- WebCore.vcxproj/QTMovieWin/QTMovieWinPreLink.cmd: Added.
- WebCore.vcxproj/WebCore.vcxproj.user: Removed.
- WebCore.vcxproj/WebCoreGenerated.vcxproj.user: Removed.
- JavaScriptCore.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added property svn:ignore.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly: Added property svn:ignore.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets: Added property svn:ignore.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor: Added property svn:ignore.
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/jsc: Added property svn:ignore.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/testRegExp: Added property svn:ignore.
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.user: Removed.
- JavaScriptCore.vcxproj/testapi: Added property svn:ignore.
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj.user: Removed.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added property svn:ignore.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added property svn:ignore.
- WinLauncher/WinLauncher.vcxproj: Added property svn:ignore.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.user: Removed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.user: Removed.
- WTF.vcxproj: Added property svn:ignore.
- WTF.vcxproj/WTF.vcxproj.user: Removed.
- WTF.vcxproj/WTFGenerated.vcxproj.user: Removed.
- 11:30 AM Changeset in webkit [142306] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Flakey test expectations update
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 11:30 AM Changeset in webkit [142305] by
-
- 7 edits in trunk/Source
Use WeakPtrs to communicate between the HTMLDocumentParser and the BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107190
Reviewed by Eric Seidel.
Source/WebCore:
This patch replaces the parser map with WeakPtr. We now use WeakPtrs to
communicate from the main thread to the background thread. (We were
already using WeakPtrs to communicate from the background thread to the
main thread.) This change lets us remove a bunch of boilerplate code.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::stop):
(WebCore):
- html/parser/BackgroundHTMLParser.h:
(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::startBackgroundParser):
(WebCore::HTMLDocumentParser::stopBackgroundParser):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::finish):
- html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):
Source/WTF:
Add the ability to create an unbound weak reference. This facility lets
you start sending messages to a WeakPtr on another thread before the
object backing the WeakPtr has actually been created.
- wtf/WeakPtr.h:
(WTF::WeakReference::createUnbound):
(WTF::WeakReference::bindTo):
(WeakReference):
(WTF::WeakReference::WeakReference):
(WTF::WeakPtr::WeakPtr):
(WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):
(WeakPtrFactory):
(WTF::WeakPtrFactory::revokeAll):
- 11:09 AM Changeset in webkit [142304] by
-
- 274 edits17 adds80 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 11. Some fast tests. Elided.
- platform/chromium/TestExpectations:
- 10:45 AM Changeset in webkit [142303] by
-
- 2 edits3 copies1 move35 adds in trunk
DumpRenderTree, ImageDiff and TestNetscapePlugin projects, property sheets and resources for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=107034.
Reviewed by Brent Fulgham.
- DumpRenderTree/DumpRenderTree.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Copied from DumpRenderTree/TestNetscapePlugIn/win/resource.h.
- DumpRenderTree/TestNetscapePlugIn/Tests/win/CallJSThatDestroysPlugin.cpp: Copied from DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp.
- DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Removed.
VS2010 WebCore TestSupport project.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj: Added.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Added.
- 10:42 AM GStreamer edited by
- (diff)
- 10:11 AM GStreamer/GStreamerOnMac created by
- 10:09 AM Changeset in webkit [142302] by
-
- 4 edits1 add2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 10. Mac 10.6 results were wrong. This simplifies things a lot.
- fast/repaint/scale-page-shrink-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/background-scaling-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium/fast/repaint/scale-page-shrink-expected.png: Removed.
- platform/mac/fast/repaint/scale-page-shrink-expected.png: Removed.
- 10:08 AM GStreamer created by
- 10:06 AM Changeset in webkit [142301] by
-
- 19 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 9. These were rebaselined earlier before all the bots were done.
- platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac-lion/svg/text/selection-styles-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
- platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
- platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
- platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac/svg/text/selection-styles-expected.png:
- platform/chromium-win/svg/batik/text/smallFonts-expected.png:
- platform/chromium-win/svg/batik/text/textDecoration-expected.png:
- platform/chromium-win/svg/batik/text/textFeatures-expected.png:
- platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-win/svg/text/selection-styles-expected.png:
- 10:04 AM Changeset in webkit [142300] by
-
- 1 edit2 adds2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 8. Outstanding mac failure.
- editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
- platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- 10:01 AM Changeset in webkit [142299] by
-
- 1 edit2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 7. Outstanding failing linux tests
- platform/chromium-linux-x86/fast/forms/button-generated-content-expected.png: Removed.
- platform/chromium-linux-x86/fast/forms/button-inner-block-reuse-expected.png: Removed.
- 9:59 AM Changeset in webkit [142298] by
-
- 6 edits5 adds in trunk/Source
[GTK] Add an experimental gyp build
https://bugs.webkit.org/show_bug.cgi?id=109003
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-08
Reviewed by Gustavo Noronha Silva.
Source/JavaScriptCore:
- JavaScriptCore.gypi: Update the list of source files to include those
necessary for the GTK+ build.
Source/WebKit/gtk:
Add an experimental gyp build for WebKitGTK+. Currently only libjavascriptcoregtk,
jsc, and minidom build (and only on platforms for that support bash). To use the
build simply run:
$ gyp --generator-output=build --depth=. Source/WebKit/gtk/gyp/JavaScriptCore.gyp
Then enter the build directory and run make.
- gyp/Configuration.gypi: Added.
- gyp/JavaScriptCore.gyp: Added.
- gyp/WTF.gyp: Added.
- gyp/generate-derived-sources.sh: Added.
Source/WTF:
- WTF.gyp/WTF.gyp: Filter out MetaAllocator.(cpp/h) from the Chromium
build. It's only necessary for GTK+.
- WTF.gypi: Add MetaAllocator to the build for WebKitGTK+.
- 9:58 AM Changeset in webkit [142297] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] GraphicsLayerActor code clean up after clutter version up.
https://bugs.webkit.org/show_bug.cgi?id=109304
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-08
Reviewed by Gustavo Noronha Silva.
This patch cleans up GraphicsLayerActor functions by using new clutter apis
and makes existing functions simple & readable.
No new tests since no change in functionality
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorPaint):
(graphicsLayerActorDraw):
(graphicsLayerActorUpdateTexture):
(drawLayerContents):
(graphicsLayerActorNew):
(graphicsLayerActorInvalidateRectangle):
(graphicsLayerActorSetTransform):
(graphicsLayerActorSetAnchorPoint):
(graphicsLayerActorGetAnchorPoint):
(graphicsLayerActorSetScrollPosition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
- 9:58 AM Changeset in webkit [142296] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 6. Outstanding failing linux tests
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
- 9:55 AM Changeset in webkit [142295] by
-
- 1126 edits2 adds188 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 5. Editing expectations.
File list truncated to remove the hundreds of files that have been updated.
- platform/chromium/TestExpectations: Removed the temp expectations and re-added one mac failure case
- platform/efl-wk1/editing/selection: Added.
- platform/efl-wk1/editing/selection/move-by-character-6-expected.png: Added.
- platform/efl/editing/selection/move-by-character-6-expected.png: Removed.
- 9:35 AM Changeset in webkit [142294] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Update platform specific expected files after r142280.
- 9:32 AM Changeset in webkit [142293] by
-
- 4 edits in tags/Safari-537.30.1/Source
Versioning.
- 9:29 AM Changeset in webkit [142292] by
-
- 1 copy in tags/Safari-537.30.1
New Tag.
- 9:28 AM Changeset in webkit [142291] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Remove effect-reference-hw from test expectations, since it's now passing.
https://bugs.webkit.org/show_bug.cgi?id=104289
- platform/chromium/TestExpectations:
- 9:12 AM Changeset in webkit [142290] by
-
- 5 edits in trunk
[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=109272
Reviewed by Kentaro Hara.
Source/WebKit/chromium:
We enabled this flag for desktop Chromium, but disabled the feature by a
runtime flag. We disables the compile flag too because we have no plan
to ship it in near future.
- features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
LayoutTests:
- platform/chromium/TestExpectations:
Skip fast/forms/datetime and datetime-multiple-fields
- 9:05 AM Changeset in webkit [142289] by
-
- 4 edits in trunk
Source/WebCore: Fix and test for missing return statement
RTCPeerConnection.getStats() failed when remote stats were instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292
Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.
Tested by extending the existing mock's behaviour.
- Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):
Tools: Fix and test for missing return
RTCPeerConnection.getStats() fails when remote stats are instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292
Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):
- 8:57 AM Changeset in webkit [142288] by
-
- 6 edits2 deletes in trunk
MediaStream API: Removing the deprecated WebMediaStreamDescriptor and WebMediaStreamComponent shims
https://bugs.webkit.org/show_bug.cgi?id=109296
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebMediaStreamComponent.h: Removed.
- chromium/public/WebMediaStreamDescriptor.h: Removed.
Tools:
- DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp:
(MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
- DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h:
(MockWebRTCDTMFSenderHandler):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::createDTMFSender):
- 8:40 AM Changeset in webkit [142287] by
-
- 3 edits in trunk/Source/WebCore
[Text Autosizing] Split isAutosizingCluster into three independent checks
https://bugs.webkit.org/show_bug.cgi?id=109093
Refactoring to create more flexible version of isAutosizingCluster since there're more types
of autosizing cluster now: narrower than the parent cluster, wider than the parent cluster
and the one that doesn't depend on the parent cluster.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-08
Reviewed by Kenneth Rohde Christiansen.
Refactoring, no test changes.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizer::isNarrowDescendant):
Separate check for the container to be of the narrow-descendant type. Was a part of
isAutosizingCluster().
(WebCore::TextAutosizer::isWiderDescendant):
Separate check for the container to be of the wider-descendant type. Was a part of
isAutosizingCluster().
(WebCore::TextAutosizer::isIndependentDescendant):
Separate check for the container to be autosized separately from the ancestor cluster.
Checks for conditions independent of the aforementioned cluster.
(WebCore::TextAutosizer::isAutosizingCluster):
Handy method to check all separate conditions together.
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):
The methods above were updated to use new functions/arguments.
- rendering/TextAutosizer.h:
Updated/added method definitions.
- 8:27 AM Changeset in webkit [142286] by
-
- 46 edits6 adds18 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 4. CSS expectations.
- platform/chromium-linux-x86/css1/box_properties: Removed.
- platform/chromium-linux-x86/css1/box_properties/acid_test-expected.png: Removed.
- platform/chromium-linux-x86/css2.1/t09-c5526c-display-00-e-expected.png: Removed.
- platform/chromium-linux-x86/css3/images: Removed.
- platform/chromium-linux-x86/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-161-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-19b-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-25-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-64-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-70-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-161-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-25-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-64-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-70-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-25-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-64-expected.png: Removed.
- platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-70-expected.png: Removed.
- platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
- platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-linux/css1/box_properties/acid_test-expected.png:
- platform/chromium-linux/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
- platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png:
- platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png:
- platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-mac-lion/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-mac-lion/css3/images: Removed.
- platform/chromium-mac-lion/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.txt: Added.
- platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
- platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png:
- platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png:
- platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
- platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.png:
- platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.txt:
- platform/chromium-win-xp/css3/images: Removed.
- platform/chromium-win-xp/css3/images/cross-fade-overflow-position-expected.png: Removed.
- platform/chromium-win-xp/css3/selectors3: Removed.
- platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
- platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.txt:
- platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
- platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png:
- platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png:
- platform/chromium-win/css3/masking/clip-path-ellipse-expected.png:
- platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
- platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Added.
- platform/chromium/TestExpectations:
- platform/chromium/css2.1/t0505-c16-descendant-01-e-expected.txt: Removed.
- platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Removed.
- platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Removed.
- 8:17 AM Changeset in webkit [142285] by
-
- 3 edits in trunk
[GTK] Include files from DerivedSources/webkitdom for introspection
https://bugs.webkit.org/show_bug.cgi?id=108631
Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-08
Reviewed by Martin Robinson.
Include files from DerivedSources/webkitdom for introspection
- /Source/WebKit/gtk/GNUmakefile.am:
- /Source/WebKit2/GNUmakefile.am:
- 8:15 AM Changeset in webkit [142284] by
-
- 2 edits9 adds in trunk
[GTK] Split configure.ac into reusable portions
https://bugs.webkit.org/show_bug.cgi?id=109246
Reviewed by Philippe Normand.
Split up configure.ac into sections based on different "phases"
of configuration. This should make it easier to find what you are
looking for as well as creating a "right" place to put things.
A nice side effect of this is that we can share the different
modules with a gyp build.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Added.
- Source/autotools/FindDependencies.m4: Added.
- Source/autotools/PrintBuildConfiguration.m4: Added.
- Source/autotools/ReadCommandLineArguments.m4: Added.
- Source/autotools/SetupAutoconfHeader.m4: Added.
- Source/autotools/SetupAutomake.m4: Added.
- Source/autotools/SetupCompilerFlags.m4: Added.
- Source/autotools/SetupLibtool.m4: Added.
- Source/autotools/Versions.m4: Added.
- configure.ac:
- 8:09 AM Changeset in webkit [142283] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Extension sever should use Workspace.projectForType() instead of Workspace.project()
https://bugs.webkit.org/show_bug.cgi?id=109301
Reviewed by Alexander Pavlov.
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):
- 8:09 AM Changeset in webkit [142282] by
-
- 22 edits6 adds9 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 3. Remaining expected failures that had platform-specific supppressions
- platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
- platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
- platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png:
- platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/chromium-mac-lion/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
- platform/chromium-mac-lion/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
- platform/chromium-mac-lion/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac-lion/fast/dom/52776-expected.png:
- platform/chromium-mac-lion/fast/frames/iframe-scaling-with-scroll-expected.png:
- platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
- platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
- platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
- platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-mac/fast/dom/52776-expected.png:
- platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
- platform/chromium-mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
- platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
- platform/chromium-win/fast/css/background-clip-radius-values-expected.png:
- platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
- platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
- platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/editing/pasteboard/emacs-cntl-y-001-expected.png: Removed.
- platform/chromium/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Removed.
- 8:04 AM Changeset in webkit [142281] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: simplify Memory.getDOMNodeCount implementation
https://bugs.webkit.org/show_bug.cgi?id=108821
Reviewed by Alexander Pavlov.
Removed Memory.getDOMNodeCount command from the protocol. Memory.getDOMCounters
should be used instead.
- inspector/Inspector.json:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- 7:59 AM Changeset in webkit [142280] by
-
- 9 edits1 copy1 add in trunk/LayoutTests
[Qt] Reviewin Qt TestExpectations. Rebaseline and unskip passing tests.
- platform/qt/TestExpectations:
- platform/qt/svg/css/arrow-with-shadow-expected.png:
- platform/qt/svg/css/arrow-with-shadow-expected.txt:
- platform/qt/svg/css/clippath-with-shadow-expected.png:
- platform/qt/svg/css/clippath-with-shadow-expected.txt:
- platform/qt/svg/css/composite-shadow-text-expected.png:
- platform/qt/svg/custom/simple-text-double-shadow-expected.png:
- platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
- platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.png: Copied from LayoutTests/platform/qt/svg/css/clippath-with-shadow-expected.png.
- platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
- 7:46 AM Changeset in webkit [142279] by
-
- 16 edits2 adds2 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 2. Failing Linux tests with no expectations
- platform/chromium-linux/fast/forms/button-generated-content-expected.png:
- platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png:
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
- platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
- platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-linux/svg/text/selection-styles-expected.png:
- platform/efl-wk2/fast/repaint: Added.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
- platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png: Removed.
- platform/efl/svg/batik/text/textDecoration-expected.png: Removed.
- 7:44 AM Changeset in webkit [142278] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: refactor MemoryStatistics.js
https://bugs.webkit.org/show_bug.cgi?id=109299
Reviewed by Vsevolod Vlasov.
Extracted functionality specific to DOM counter graphs drawing into
separate methods on MemoryStatistics class.
Introduced CounterUIBase base class for DOMCounterUI that contains
functionality which can be shared with native memory graph.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.CounterUIBase):
(WebInspector.CounterUIBase.prototype.updateCurrentValue):
(WebInspector.CounterUIBase.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUIBase.prototype.get visible):
(WebInspector.DOMCounterUI):
(WebInspector.DOMCounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._clearCurrentValueAndMarker):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._updateCurrentValue):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._restoreImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._drawMarker):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.MemoryStatistics.prototype._discardImageUnderMarker):
- 7:36 AM Changeset in webkit [142277] by
-
- 25 edits7 adds6 deletes in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
Round 1. Some tests that have existing expectations.
- editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
- platform/chromium-linux-x86/editing/input: Removed.
- platform/chromium-linux/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-linux/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-win-xp/editing/input: Removed.
- platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- platform/efl-wk2/editing/input: Added.
- platform/efl-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
- 7:07 AM Changeset in webkit [142276] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=109209.
- 7:02 AM Changeset in webkit [142275] by
-
- 2 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 141904
[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957
Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.
Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12210085
- 6:50 AM Changeset in webkit [142274] by
-
- 2 edits in trunk/LayoutTests
[Qt][Wk2] Unreviewed gardening. Skip failing tests.
https://bugs.webkit.org/show_bug.cgi?id=109291.
- platform/qt-5.0-wk2/TestExpectations:
- 6:42 AM Changeset in webkit [142273] by
-
- 11 edits25 adds in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed expectations update.
These are tests that failed due to bad expectations.
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.txt: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
- platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.txt: Added.
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
- platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
- platform/chromium-win/svg/custom/embedding-external-svgs-expected.png:
- platform/chromium-win/svg/custom/pointer-events-text-expected.png:
- platform/chromium/TestExpectations:
- 6:23 AM Changeset in webkit [142272] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Last of the Win failures.
- 6:21 AM Changeset in webkit [142271] by
-
- 66 edits in trunk/Source/WebCore
Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting
https://bugs.webkit.org/show_bug.cgi?id=108771
Reviewed by Eric Seidel.
In cases where the ExceptionCode passed into a function is completely
ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
makes our expectations about possible exceptions (or lack thereof)
explicit, rather than relying on implicit assumptions about whether a
variable is intentionally uninitialized or not. It also removes
knowledge about the internals of ExceptionCodes (that they're currently
ints, for instance) from code that shouldn't care, which will help with
future refactorings.
The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
shouldn't have any visible effect on the web. As long as all the
current tests pass, we're good.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::stop):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::processBuffer):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ExceptionCodePlaceholder.h:
(WebCore):
- dom/Node.cpp:
(WebCore::Node::normalize):
- dom/Text.cpp:
(WebCore::Text::replaceWholeText):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doUnapply):
- editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):
(WebCore::Editor::applyEditingStyleToElement):
- editing/EditorCommand.cpp:
(WebCore::executeFormatBlock):
- editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::elementForFormatBlockCommand):
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/RemoveCSSPropertyCommand.cpp:
(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):
- editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
- editing/TextIterator.cpp:
(WebCore::TextIterator::getLocationAndLengthFromRange):
- editing/WrapContentsInDummySpanCommand.cpp:
(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):
- editing/htmlediting.cpp:
(WebCore::comparePositions):
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::returnToRealtime):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::setTextContentInternal):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::remove):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTHead):
(WebCore::HTMLTableElement::deleteTHead):
(WebCore::HTMLTableElement::createTFoot):
(WebCore::HTMLTableElement::deleteTFoot):
(WebCore::HTMLTableElement::createCaption):
(WebCore::HTMLTableElement::deleteCaption):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setDefaultValue):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- html/InputType.cpp:
(WebCore::InputType::stepUpFromRenderer):
- html/MediaController.cpp:
(MediaController::bringElementUpToSpeed):
(MediaController::asyncEventTimerFired):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- html/TimeRanges.cpp:
(TimeRanges::contain):
(TimeRanges::nearest):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlSeekButtonElement::seekTimerFired):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::updateCurrentTimeDisplay):
(WebCore::MediaControls::createTextTrackDisplay):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::updateCurrentTimeDisplay):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlEmbeddedPanelElement::setPosition):
(WebCore::MediaControlEmbeddedPanelElement::resetPosition):
(WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
(WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::updateCurrentTimeDisplay):
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::markUndoableState):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::replayXHR):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/DOMWindow.cpp:
(WebCore::didAddStorageEventListener):
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::percentLoaded):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection):
(WebCore::documentFragmentWithImageResource):
(WebCore::Pasteboard::documentFragment):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
(-[WebVideoFullscreenHUDWindowController setVolume:]):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaSliderTrack):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::getRanges):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaSliderTrack):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::detachTarget):
- xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::transformDocumentToTreeView):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
- 6:14 AM Changeset in webkit [142270] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Adding Mac rubberbanding failures
- 6:10 AM Changeset in webkit [142269] by
-
- 25 edits in trunk
Web Inspector: Introduce workspace provider/project type, encapsulate uri creation in SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=109282
Reviewed by Alexander Pavlov.
Source/WebCore:
SimpleWorkspaceProvider now fully takes care of creating uri based on project/workspace provider type.
This is the first step on the way to project-per-domain mode for non file system project types.
Workspace is now partly aware of the possibility that several projects with the same type exist.
Drive-by: ScriptsPanel now uses FileMapping to show anchor location properly.
- inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.uriForURL):
- inspector/front-end/FileSystemWorkspaceProvider.js:
(WebInspector.FileSystemWorkspaceProvider.prototype.type):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):
- inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._navigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.type):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._uniqueURI):
- inspector/front-end/Workspace.js:
(WebInspector.WorkspaceProvider.prototype.type):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodesForProjectType):
(WebInspector.Workspace.prototype.projectsForType):
- inspector/front-end/inspector.js:
LayoutTests:
- http/tests/inspector-enabled/dynamic-scripts.html:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-scripts.html:
- inspector/debugger/script-snippet-model.html:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- inspector/uisourcecode-revisions.html:
- 5:55 AM Changeset in webkit [142268] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Updated French translation
https://bugs.webkit.org/show_bug.cgi?id=106229
Patch by Alexandre Franke <alexandre.franke@gmail.com> on 2013-02-08
Rubber-stamped by Gustavo Noronha.
- fr.po: updated.
- 5:49 AM Changeset in webkit [142267] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Outstanding Win failures
- 5:41 AM Changeset in webkit [142266] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: One more to get all bots green again ready for rebaselining.
- 5:35 AM Changeset in webkit [142265] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changing anchor position.
https://bugs.webkit.org/show_bug.cgi?id=109226
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-08
Reviewed by Gustavo Noronha Silva.
Clutter has a different coordinate system from mac port's, so we don't need to
recalulate GraphicsLayer position after changing its anchor position.
Covered by existing ac tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::updateGeometry):
- 5:16 AM Changeset in webkit [142264] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations: Modified a MountainLion expectation
- 5:05 AM Changeset in webkit [142263] by
-
- 2 edits in trunk/LayoutTests
Expectations as a result of removing Skia code suppressions
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 5:04 AM Changeset in webkit [142262] by
-
- 4 edits in trunk/Source/WebCore
Migrate ExceptionCode ASSERTs in IDB to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109266
Reviewed by Jochen Eisinger.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former in IDB code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):
These methods checked the value of the ExceptionCode without first
initializing it to 0. Now the ExceptionCode is explicitly set to 0
before doing potentially exception-generating work.
(WebCore::IDBCursor::direction):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
Replace the above pattern with ASSERT_NO_EXCEPTION.
- 4:54 AM Changeset in webkit [142261] by
-
- 7 edits in trunk/Source/WebCore
Migrate ExceptionCode ASSERTs in SVG to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109267
Reviewed by Jochen Eisinger.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former in SVG code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.
- svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::setValue):
This method checked the value of the ExceptionCode without first
initializing it to 0. Now it initializes before doing potentially
exception-generating work.
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
- svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
- svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
Replace the above pattern with ASSERT_NO_EXCEPTION.
- 4:45 AM Changeset in webkit [142260] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC: Lower minimum PropertyTable size.
<http://webkit.org/b/109247>
Reviewed by Darin Adler.
Lower the minimum table size for PropertyTable from 16 to 8.
3.32 MB progression on Membuster3 (a ~13% reduction in memory used by PropertyTables.)
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::sizeForCapacity):
- 4:42 AM Changeset in webkit [142259] by
-
- 13 edits in trunk
Web Inspector: Replace workspace with project in UISourceCode constructor.
https://bugs.webkit.org/show_bug.cgi?id=109256
Reviewed by Alexander Pavlov.
Source/WebCore:
Replaced workspace with project in UISourceCode constructor since every UISourceCode
operation is delegated to project anyway.
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.project):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/script-formatter-search.html:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/ui-source-code-display-name.html:
- inspector/debugger/ui-source-code.html:
- inspector/uisourcecode-revisions.html:
- 4:39 AM Changeset in webkit [142258] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142205.
- 4:22 AM Changeset in webkit [142257] by
-
- 4 edits in trunk
Remove Skia code suppressions
Unreviewed enabling of existing optimizations
Removing all skia_webkit.gyp code suppressions and adding expectations
for the failures.
Source/WebKit/chromium:
- skia_webkit.gyp:
LayoutTests:
- platform/chromium/TestExpectations:
- 4:10 AM Changeset in webkit [142256] by
-
- 2 edits in trunk/Tools
Update my entries in the watchlist
Unreviewed.
- Scripts/webkitpy/common/config/watchlist:
- 4:08 AM Changeset in webkit [142255] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Adjusting expectations for two failures.
Unreviewed Chromium expectations
- platform/chromium/TestExpectations:
- 3:58 AM Changeset in webkit [142254] by
-
- 2 edits in trunk/Source/WebCore
Build fix for Windows after r141981.
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
- 3:51 AM Changeset in webkit [142253] by
-
- 7 edits in trunk/Tools
[chromium] copy normalizeLayoutTestURL code to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109269
Reviewed by Kent Tamura.
The method doesn't have any external dependencies, so there's no reason
it should be on the delegate. It's still required by TestShell, however,
by making a copy, we can avoid implementing this in content shell.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::windowCount):
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 3:45 AM Changeset in webkit [142252] by
-
- 1 edit in trunk/Tools/MiniBrowser/efl/main.c
Unreviewed, forced commit to trigger an EFL bot cycle
- 3:15 AM Changeset in webkit [142251] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r141695 and r141697.
http://trac.webkit.org/changeset/141695
http://trac.webkit.org/changeset/141697
https://bugs.webkit.org/show_bug.cgi?id=109279
broke on-disk buffering for http(s) media (Requested by philn
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):
- 2:17 AM Changeset in webkit [142250] by
-
- 37 edits in trunk/Source
[v8] isolate parameter added to all v8::peristent calls
https://bugs.webkit.org/show_bug.cgi?id=109268
Patch by Dan Carney <dcarney@google.com> on 2013-02-08
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. No change in functionality.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::GetRawTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::V8TestActiveDOMObject::GetRawTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetRawTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::GetRawTemplate):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetRawTemplate):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::GetRawTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetRawTemplate):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::GetRawTemplate):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::clear):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):
- bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
- bindings/v8/ScopedPersistent.h:
(WebCore::ScopedPersistent::ScopedPersistent):
(WebCore::ScopedPersistent::set):
(WebCore::ScopedPersistent::clear):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):
- bindings/v8/V8Binding.cpp:
(WebCore::createRawTemplate):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::npObjectGetProperty):
(WebCore::createV8ObjectForNPObject):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
- bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperConfiguration::configureWrapper):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
Source/WebKit/chromium:
- tests/WebFrameTest.cpp:
- 1:56 AM Changeset in webkit [142249] by
-
- 2 edits in trunk/Tools
[EFL] Make the Performance bot also build WebKit.
https://bugs.webkit.org/show_bug.cgi?id=109273
Reviewed by Philippe Normand.
There has not been much benefit in fetching binaries compiled by
another bot; it makes the build bot take 6 to 7 minutes to upload
the binaries to build.webkit.org, we need to manually override
LD_LIBRARY_PATH to find the compiled libraries and still have
other path-related problems.
Since we have enough horsepower in the perf bot, let's experiment
with building WebKit there instead.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:34 AM Changeset in webkit [142248] by
-
- 41 edits in trunk/Source/WebCore
Adjust usage of ENABLE flags to enable whole content
https://bugs.webkit.org/show_bug.cgi?id=109270
Reviewed by Eric Seidel.
Our common usage of ENABLE flags to enable whole content of files is:
For .cpp files:
#include "config.h"
#if ENABLE(FOOBAR)
#include "FooBar.h"
For .h files:
#ifndef FooBar_h
#define FooBar_h
#if ENABLE(FOOBAR)
Fix files which have uncommon usage, and fix CodeGeneratorV8.pm so that
it generates the common pattern. Note that CodeGeneratorJS.pm already
generates code in this order.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
- bindings/scripts/test/V8/V8TestCallback.cpp:
- bindings/scripts/test/V8/V8TestCallback.h:
- bindings/scripts/test/V8/V8TestInterface.cpp:
- bindings/scripts/test/V8/V8TestInterface.h:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
- html/BaseMultipleFieldsDateAndTimeInputType.h:
- html/ColorInputType.cpp:
- html/ColorInputType.h:
- html/DateInputType.cpp:
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.cpp:
- html/HTMLAudioElement.cpp:
- html/HTMLAudioElement.h:
- html/HTMLDataListElement.cpp:
- html/HTMLDialogElement.cpp:
- html/HTMLDialogElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLMeterElement.cpp:
- html/HTMLProgressElement.cpp:
- html/HTMLSourceElement.cpp:
- html/HTMLSourceElement.h:
- html/HTMLTrackElement.cpp:
- html/HTMLTrackElement.h:
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- html/MonthInputType.cpp:
- html/TimeInputType.cpp:
- html/WeekInputType.cpp:
- html/shadow/DateTimeFieldElement.h:
- html/shadow/DetailsMarkerControl.cpp:
- html/shadow/MeterShadowElement.cpp:
- html/shadow/ProgressShadowElement.cpp:
- rendering/RenderDetailsMarker.cpp:
- rendering/RenderInputSpeech.cpp:
- rendering/RenderMeter.cpp:
- rendering/RenderProgress.cpp:
- 1:12 AM Changeset in webkit [142247] by
-
- 26 edits in trunk/Source/WebCore
Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044
Reviewed by Darin Adler.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.
No change in behavior should result from this refactoring.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
- dom/Document.cpp:
(WebCore::Document::setTitle):
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
- editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
(WebCore::DeleteButtonController::show):
Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
- editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
- editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
- editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
- page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
- 1:03 AM Changeset in webkit [142246] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Adjusting expectations for two hidpi tests.
https://bugs.webkit.org/show_bug.cgi?id=96441
- platform/chromium/TestExpectations:
- 1:00 AM Changeset in webkit [142245] by
-
- 3 edits1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt-5.0/fast/js/global-constructors-expected.txt: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/js/global-constructors-expected.txt: Added after r142149.
- 12:57 AM Changeset in webkit [142244] by
-
- 4 edits in trunk/LayoutTests
[EFL] Mark some tests as passing with incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=109173
Unreviewed EFL gardening.
Add new category for TestExpectations: PASSING TESTS WITH INCORRECT EXPECTATIONS.
Currently, the tests are passing with their generated incorrect expectations.
It should be checked if the test starts failing. It means, the test can be passing now.
Below tests are marked as passing tests with incorrect expectations.
fast/forms/basic-textareas-quirks.html
fast/forms/input-disabled-color.html
fast/forms/input-readonly-dimmed.html
fast/forms/listbox-hit-test-zoomed.html
fast/forms/menulist-narrow-width.html
fast/forms/menulist-style-color.html
fast/forms/plaintext-mode-2.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/forms/select-baseline.html
fast/forms/select-style.html
fast/forms/zoomed-controls.html
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-08
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 12:25 AM Changeset in webkit [142243] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: disable profile type switching while profile in progress
https://bugs.webkit.org/show_bug.cgi?id=109178
Patch by Alexei Filippov <alph@chromium.org> on 2013-02-08
Reviewed by Yury Semikhatsky.
Disables profile type selection controls when a profiling session
is in progress.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype._updateControls):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
- 12:24 AM Changeset in webkit [142242] by
-
- 2 edits in trunk/Source/WTF
Web Inspector: Native Memory Instrumentation: reportBaseAddress needs to be called after the reportNode. So it may reuse the node index for the real address.
https://bugs.webkit.org/show_bug.cgi?id=109051
Reviewed by Yury Semikhatsky.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::WrapperBase::processPointer):
- 12:18 AM Changeset in webkit [142241] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.
https://bugs.webkit.org/show_bug.cgi?id=109263
Reviewed by Yury Semikhatsky.
The chunk size is changed from 100 to 10000.
addString counts only first 256 symbols of the string.o
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::pushUpdateIfNeeded):
(WebCore::HeapGraphSerializer::addString):
- inspector/front-end/NativeMemorySnapshotView.js:
- 12:05 AM Changeset in webkit [142240] by
-
- 9 edits in trunk
Support a relatedTarget attribute on focus/blur events
https://bugs.webkit.org/show_bug.cgi?id=109176
Reviewed by Ojan Vafai.
In bug 76216, we supported a relatedTarget attribute on
focusin/focusout events. We should also support it on focus/blur events.
See http://lists.w3.org/Archives/Public/www-dom/2012OctDec/0061.html
for the www-dom discussion.
Source/WebCore:
Test: fast/dom/shadow/shadow-boundary-events.html
fast/events/related-target-focusevent.html
- dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
- dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
- dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):
LayoutTests:
- fast/dom/shadow/shadow-boundary-events-expected.txt:
- fast/dom/shadow/shadow-boundary-events.html:
- fast/events/related-target-focusevent-expected.txt:
- fast/events/related-target-focusevent.html:
Feb 7, 2013:
- 11:58 PM Changeset in webkit [142239] by
-
- 13 edits in trunk
Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146
Reviewed by Pavel Feldman.
Source/WebCore:
Merged some of memory instrumentation categories.
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
LayoutTests:
Updated tests to use new memory categories.
- inspector-protocol/nmi-webaudio-expected.txt:
- inspector-protocol/nmi-webaudio-leak-test-expected.txt:
- inspector-protocol/nmi-webaudio-leak-test.html:
- inspector-protocol/nmi-webaudio.html:
- inspector/profiler/memory-instrumentation-cached-images-expected.txt:
- inspector/profiler/memory-instrumentation-cached-images.html:
- inspector/profiler/memory-instrumentation-canvas-expected.txt:
- inspector/profiler/memory-instrumentation-canvas.html:
- 11:47 PM Changeset in webkit [142238] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Flakiness on table-cell-before-after-content-around-table-row.html
https://bugs.webkit.org/show_bug.cgi?id=109262
An assert is sometimes hit in WebCore::RenderTableCell::styleDidChange.
- platform/chromium/TestExpectations:
- 11:38 PM Changeset in webkit [142237] by
-
- 31 edits3 copies in trunk/Tools
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466
Reviewed by Adam Barth.
To achieve this, we need to drop all dependencies on WTF.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- 11:35 PM Changeset in webkit [142236] by
-
- 5 edits in trunk
<iframe seamless> should avoid vertical scrollbars during the initial layout passes.
https://bugs.webkit.org/show_bug.cgi?id=87707
Reviewed by Eric Seidel.
Source/WebCore:
Seamless documents currently render incorrectly when their content fills
the width of the container into which they're placed. Because FrameView
assumes that the container's size is properly set before the first pass
of layout, vertical scrollbars are incorrectly forced onto seamless
content, because seamless sets the container's height to 0 before
handing it off to FrameView for layout. The scrollbars make the
available width for the seamless document ~15px smaller than it should
be, resulting in content getting bumped to the next line.
This patch special-cases FrameView::calculateScrollbarModesForLayout in
order to force scrollbars off for seamless documents with a full visible
height of 0px. Once the layout pass has grabbed the content height and
applied it to the visible height, scrollbars will again be applicable.
The change should be covered by rebaselines for the newly-passing
results in fast/frame/seamless-{float,inline}.html
- page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
If we're rendering a seamless document, and the full visible height
is 0, and the vertical scrollbar would otherwise be ScrollbarAuto,
then force ScrollbarAlwaysOff.
LayoutTests:
- fast/frames/seamless/seamless-float-expected.txt:
- fast/frames/seamless/seamless-inline-expected.txt:
Rebaseline the now-passing bits of these tests.
- 11:34 PM Changeset in webkit [142235] by
-
- 2 edits2 copies9 adds in trunk/LayoutTests
Unreviewed rebaseline.
- platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Added.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Added.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Added.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Added.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Added.
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Added.
- 11:18 PM Changeset in webkit [142234] by
-
- 3 edits2 adds in trunk
document.activeElement should not return a non-focusable element
https://bugs.webkit.org/show_bug.cgi?id=86707
Reviewed by Hajime Morita.
Source/WebCore:
This is based on a patch by Arpita Bahuguna.
Test: fast/dom/HTMLDocument/set-focus-on-valid-element.html
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
Added check for verifying that the node to be focused is
focusable. However, this check should be skipped for HTMLPlugInElement
because it has special behavior.
LayoutTests:
- fast/dom/HTMLDocument/set-focus-on-valid-element-expected.txt: Added.
- fast/dom/HTMLDocument/set-focus-on-valid-element.html: Added.
This test verifies that document.activeElement does not return an
invalid or non-focusable element.
- 11:08 PM Changeset in webkit [142233] by
-
- 2 edits in trunk/Tools
Unreviewed followup to r142232.
Work around a bug in jhbuild that was incorrectly composing the source
package URL by adjusting slightly the repository and module paths.
- gtk/jhbuild.modules:
- 10:46 PM Changeset in webkit [142232] by
-
- 2 edits in trunk/Tools
Use a mirror for the sourceware.org repo used in jhbuild
Unreviewed.
The ftp://sourceware.org site is down, causing errors when running jhbuild
and subsequently failing complete builds on the builders. Use the mirrors.kernel.org
mirror to get sources for the desired libffi dependency.
- gtk/jhbuild.modules:
- 10:42 PM Changeset in webkit [142231] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane
https://bugs.webkit.org/show_bug.cgi?id=109259
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
- inspector/front-end/SidebarPane.js:
- 10:41 PM Changeset in webkit [142230] by
-
- 2 edits in trunk/Source/WTF
Fix #endif comment from r142163 and r142183
- wtf/MainThread.h:
(WTF): s/PLATFORM/USE/
- 10:15 PM Changeset in webkit [142229] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening. Two webgl/conformance/context tests are timing out.
See https://bugs.webkit.org/show_bug.cgi?id=109114
- platform/chromium/TestExpectations:
- 10:05 PM Changeset in webkit [142228] by
-
- 1 edit7 deletes in trunk/LayoutTests
Cleaning up after r142208
https://bugs.webkit.org/show_bug.cgi?id=109228
Unreviewed.
The commit-queue didn't remove these files for some reason. Removing them manually.
- platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- 9:47 PM Changeset in webkit [142227] by
-
- 2 edits in trunk/Source/WebKit/blackberry
webpage needs null check in BackingStore::setCurrentBackingStoreOwner
https://bugs.webkit.org/show_bug.cgi?id=109253
Reviewed by George Staikos.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
- 9:37 PM Changeset in webkit [142226] by
-
- 3 edits in trunk/Source/WebCore
[V8] enum V8HiddenPropertyCreationType is not used
https://bugs.webkit.org/show_bug.cgi?id=109250
Reviewed by Adam Barth.
V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.
No tests. No change in behavior.
- bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::hiddenReferenceName):
- bindings/v8/V8HiddenPropertyName.h:
(WebCore):
- 9:32 PM Changeset in webkit [142225] by
-
- 11 edits in trunk/Source
Unreviewed, rolling out r142212.
http://trac.webkit.org/changeset/142212
https://bugs.webkit.org/show_bug.cgi?id=109255
Causes ASSERT(!m_installed) on launch (Requested by smfr on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07
Source/WebCore:
- WebCore.exp.in:
- platform/MemoryPressureHandler.cpp:
(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
- platform/MemoryPressureHandler.h:
(MemoryPressureHandler):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):
Source/WebKit2:
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::shouldTerminate):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 9:03 PM Changeset in webkit [142224] by
-
- 5 edits1 move4 adds in trunk/LayoutTests
Rebaseline text output for contentOpaque
https://bugs.webkit.org/show_bug.cgi?id=108656
Unreviewed rebaseline.
- platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- platform/mac/TestExpectations:
- platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Added.
- 8:59 PM Changeset in webkit [142223] by
-
- 4 edits in trunk/Source/WebCore
NamedFlowCollection should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=99239
Patch by Hanyee Kim <choco@company100.net> on 2013-02-07
Reviewed by Adam Barth
This patch removes the raw pointer of Document in NamedFlowCollection.
It could be replaced with ContextDestructionObserver.
ContextDestructionObserver has the pointer and clears the pointer
automatically when the document is destroyed.
- dom/Document.cpp:
(WebCore::Document::~Document):
- dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::NamedFlowCollection):
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
(WebCore::NamedFlowCollection::document):
(WebCore):
- dom/NamedFlowCollection.h:
(NamedFlowCollection):
- 8:29 PM Changeset in webkit [142222] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Remove dead code after r142169
https://bugs.webkit.org/show_bug.cgi?id=109251
Reviewed by Benjamin Poulain.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- 8:16 PM Changeset in webkit [142221] by
-
- 2 edits in trunk/Source/WebCore
Followup review suggestions from Alexey Proskuryakov on
https://bugs.webkit.org/show_bug.cgi?id=109215
Don't provide a charset on embedded SVG, especially
with incorrect syntax :)
- css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-closed-captions-track-list li.selected):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover):
- 7:01 PM Changeset in webkit [142220] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable non-video element enter/exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=108314
Reviewed by Antonio Gomes.
Webkit support non-video element (like div) to enter/exit
fullscreen. We should pass this capability in blackberry porting.
RIM PR 256370, internally reviewed by Max Feil.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
- Api/WebPage_p.h:
(WebPagePrivate):
- 6:41 PM Changeset in webkit [142219] by
-
- 2 edits in trunk/Source/WebCore
[Gtk] RunLoop::run shuold run current thread's run loop.
https://bugs.webkit.org/show_bug.cgi?id=107887
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-07
Reviewed by Martin Robinson.
Currently, RunLoop in Gtk can use just main thread's event loop.
But the other ports are implemented to use RunLoop in sub threads.
This patch makes RunLoop constructor create new context, not use default
context.
But in the main thread still uses default context to use main event loop
since there is some codes using glib directly (e.g. in
LayerTreeHostGtk::scheduleLayerFlush).
No new tests. There is no case that uses RunLoop in off the main thread
yet.
- platform/gtk/RunLoopGtk.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::run):
- 6:29 PM Changeset in webkit [142218] by
-
- 1 edit1 move in trunk/LayoutTests
Unreviewed gardening. Rebaseline bidi-ignored-for-first-child-inline.html
which was failing on Chromium Mac after r142152.
- platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Renamed from LayoutTests/platform/chromium/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt.
- 6:11 PM Changeset in webkit [142217] by
-
- 9 edits in trunk/Source/WebCore
[V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
https://bugs.webkit.org/show_bug.cgi?id=109186
Reviewed by Adam Barth.
V8HiddenPropertyName.h is a right place for setNamedHiddenReference().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
- bindings/v8/V8DOMWrapper.cpp:
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::hiddenReferenceName):
(WebCore::V8HiddenPropertyName::setNamedHiddenReference):
(WebCore):
- bindings/v8/V8HiddenPropertyName.h:
(V8HiddenPropertyName):
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
- bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCallbackCustom):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- 5:42 PM Changeset in webkit [142216] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, rolling out r142113.
http://trac.webkit.org/changeset/142113
https://bugs.webkit.org/show_bug.cgi?id=109244
tests started failing after r142081 was rolled out in r142166
(Requested by falken on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07
- inspector/profiler/memory-instrumentation-cached-images-expected.txt:
- inspector/profiler/memory-instrumentation-cached-images.html:
- inspector/profiler/memory-instrumentation-canvas-expected.txt:
- inspector/profiler/memory-instrumentation-canvas.html:
- 5:40 PM Changeset in webkit [142215] by
-
- 10 edits in trunk
getComputedStyle() doesn't report intermediate values during a transition of a pseudo element
https://bugs.webkit.org/show_bug.cgi?id=106535
Reviewed by Ojan Vafai.
Source/WebCore:
Element::computedStyle and CSSComputedStyleDeclaration::getPropertyCSSValue
should use the PseudoElement and it's renderer if they exist so that
querying the computed style while an animation is running returns
the intermediate values.
No new tests, updated existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::styledNode): Added, returns either the PseudoElement or the Node.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to use styledNode.
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- dom/Element.cpp:
(WebCore::Element::computedStyle): Check the PseudoElement, not just the cached pseudo style.
- dom/ElementRareData.h:
(WebCore::ElementRareData::pseudoElement): Remove ASSERT_NOT_REACHED so passing other pseudos returns 0.
LayoutTests:
Update tests to also check getComputedStyle during animations and transitions.
- fast/css-generated-content/pseudo-animation-expected.txt:
- fast/css-generated-content/pseudo-animation.html:
- fast/css-generated-content/pseudo-transition-expected.txt:
- fast/css-generated-content/pseudo-transition.html:
- 5:28 PM Changeset in webkit [142214] by
-
- 4 edits in trunk
[Chromium-Android] Disable input[type=datetime]
https://bugs.webkit.org/show_bug.cgi?id=107614
Reviewed by Kentaro Hara.
Source/WebKit/chromium:
Reason:
http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html
- features.gypi:
Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
We enable it for non-Android ports but the runtime flag for it is
disabled by default. The runtime flag is enabled only in DumpRenderTree.
LayoutTests:
- platform/chromium/TestExpectations:
Tetsts in fast/forms/datetime/ fail.
- 5:23 PM Changeset in webkit [142213] by
-
- 2 edits in trunk/Source/WebCore
Add a comment about how the SQLTransaction state machine works.
https://bugs.webkit.org/show_bug.cgi?id=109243.
Rubber stamped by Anders Carlsson.
No new tests.
- Modules/webdatabase/SQLTransactionBackend.cpp:
- 5:22 PM Changeset in webkit [142212] by
-
- 11 edits in trunk/Source
PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>
Reviewed by Darin Adler.
Source/WebCore:
This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).
MemoryPressureHandler::install is currently used for two purposes - it is
called when first initializing a low memory handler for a process, and also
used to reinstall the handler (on a delay) after the notification has occured.
Since reinstallation doesn't change the callback, split these behaviours out -
MemoryPressureHandler::initialize is added to initialization, and accepts a
custom callback, install in made private.
- WebCore.exp.in:
- Added export for releaseMemory.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseMemory):
- Added null implementation for non-Mac builds.
- platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::initialize):
- distinguish initialization from reinstallations, allow handler to be set.
(MemoryPressureHandler):
- Added m_lowMemoryHandler function pointer member variable.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
- Call m_lowMemoryHandler instead of releaseMemory.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
- MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.
(WebInstallMemoryPressureHandler):
- MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.
Source/WebKit2:
PluginProcess now initializes a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::lowMemoryHandler):
- Custom callback to terminate if appropriate.
(WebKit::PluginProcess::initializeProcess):
- Initialize the MemoryPressureHandler.
(WebKit::PluginProcess::shouldTerminate):
- This method now also needs to be callable in situations where it might return false.
- PluginProcess/PluginProcess.h:
(PluginProcess):
- Added declaration for lowMemoryHandler.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.
- 5:13 PM Changeset in webkit [142211] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed, skip crashing test
- platform/mac/TestExpectations:
- 5:07 PM Changeset in webkit [142210] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed. Corrections the exports definition file.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- WebKit.vcproj/WebKitExports.def.in:
- 5:06 PM Changeset in webkit [142209] by
-
- 3 edits in trunk/Source/WebCore
[V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
https://bugs.webkit.org/show_bug.cgi?id=109167
Reviewed by Andreas Kling.
Given that assertContextHasCorrectPrototype() is anyway empty in a release
build, we don't need to surround it with #ifndef NDEBUG.
No tests. No change in behavior.
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):
- 4:59 PM Changeset in webkit [142208] by
-
- 2 edits1 add5 deletes in trunk/LayoutTests
[CSS Regions] Turn selecting-text-through-different-region-flows test into a reftest
https://bugs.webkit.org/show_bug.cgi?id=109228
Reviewed by Eric Seidel.
Simplify and turn the test into a reftest, remove the unnecessary expected files.
- fast/regions/selecting-text-through-different-region-flows-expected.html: Added.
- fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- fast/regions/selecting-text-through-different-region-flows.html:
- platform/chromium-linux/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
- platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
- 4:56 PM Changeset in webkit [142207] by
-
- 7 edits in trunk
Makefiles should work for arbitrary SDKs and architectures on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=107863
Patch by David Farler <dfarler@apple.com> on 2013-02-07
Reviewed by Mark Rowe.
.:
- Makefile:
Allow SDKROOT, ARCHS outside of $(ARGS).
Setting ARCHS => ONLY_ACTIVE_ARCH=NO.
- Makefile.shared: options to webkitdirs based on SDKROOT
- Source/Makefile: don't build WebKit2 for iOS
Tools:
- DumpRenderTree/Makefile: SDKROOT=iphone* => -target All-iOS
- Makefile: Only build some projects for iOS
- 4:51 PM Changeset in webkit [142206] by
-
- 3 edits2 adds in trunk
Chromium: Hang parsing bidi control chars on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=108877
This was broken a while ago by:
On 10.6, CoreText will not produce any runs covering the
Unicode BiDi RTL mark control char, which causes an infinite
loop in ComplexTextController::indexOfCurrentRun() due to no
run covering the character at offset 0.
This patch fixes that issue by finding the earliest run
explicitly via the minimum stringBegin() index instead of
relying on a run existing that covers offset 0.
Fixes hang on many BiDi wikipedia pages on Chromium/Mac10.6.
Chromium bug: http://crbug.com/167844
Source/WebCore:
New test in the same style as the harfbuzz-buffer-overrun.html
test (in the same folder).
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.
Test: fast/text/international/rtl-mark.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::indexOfCurrentRun):
LayoutTests:
New test in the same style as harfbuzz-buffer-overrun.html
in the same folder.
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.
- fast/text/international/rtl-mark-expected.txt: Added.
- fast/text/international/rtl-mark.html: Added.
- 4:37 PM Changeset in webkit [142205] by
-
- 12 edits2 adds in trunk
Implement FocusEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=109170
Reviewed by Adam Barth.
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
FocusEvent constructor should be implemented under a DOM4_EVENTS_CONSTRUCTOR
flag, which is enabled on Chromium and Safari.
Source/WebCore:
Test: fast/events/constructors/focus-event-constructor.html
- dom/FocusEvent.cpp:
(WebCore::FocusEventInit::FocusEventInit):
(WebCore):
(WebCore::FocusEvent::FocusEvent):
- dom/FocusEvent.h:
(FocusEventInit):
(WebCore):
(WebCore::FocusEvent::create):
(FocusEvent):
- dom/FocusEvent.idl:
- page/DOMWindow.idl:
LayoutTests:
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/events/constructors/focus-event-constructor-expected.txt: Added.
- fast/events/constructors/focus-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 4:35 PM Changeset in webkit [142204] by
-
- 6 edits2 adds in trunk
HTML parser should queue MutationRecords for its operations
https://bugs.webkit.org/show_bug.cgi?id=89351
Reviewed by Eric Seidel.
Source/WebCore:
Generate mutation records inside the parser. This is done by using a
ChildListMutationScope in the ContainerNode::parser* methods and then
adding delivery before each <script> element would be processed by
the parser.
Test: fast/dom/MutationObserver/parser-mutations.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):
LayoutTests:
Add new test mutation records in the parser and fix shadow-dom.html
test since it used setTimeout and sometimes could observe parser
mutations.
- fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
- fast/dom/MutationObserver/parser-mutations.html: Added.
- fast/dom/MutationObserver/shadow-dom-expected.txt:
- fast/dom/MutationObserver/shadow-dom.html:
- 4:34 PM Changeset in webkit [142203] by
-
- 8 edits in trunk
Unreviewed. More VS2010 WebKit solution touchups.
- win/tools/vsprops/common.props:
Move an ignored warning from a project to common properties.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
Make WebKitExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters:
Make JavaScriptCoreExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.
- 4:30 PM Changeset in webkit [142202] by
-
- 2 edits in trunk/Source/WebCore
Fix FIXMEs in WindowFeatures.h
https://bugs.webkit.org/show_bug.cgi?id=109151
Reviewed by Adam Barth.
- FIXME: We can delete this constructor once V8 showModalDialog is changed to use DOMWindow.
This FIXME is not right. The WindowFeatures() constructor is used by
other ports too (e.g. WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp).
So we should remove the FIXME.
- FIXME: We can make these functions private non-member functions once V8 showModalDialog is changed to use DOMWindow.
Given that V8 now uses DOMWindow in showModalDialog(), we can make the
methods private.
No tests. No change in behavior.
- page/WindowFeatures.h:
(WebCore):
(WebCore::WindowFeatures::WindowFeatures):
(WindowFeatures):
- 4:27 PM Changeset in webkit [142201] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning after r142017
https://bugs.webkit.org/show_bug.cgi?id=109119
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.
Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
- 4:24 PM Changeset in webkit [142200] by
-
- 4 edits4 adds in trunk
fast/parser/document-write-noscript.html fails for threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109237
Reviewed by Eric Seidel.
Source/WebCore:
If there are multiple calls to document.write in an external script, we
need to wait for them all to complete before invalidating the
speculative tokens. Instead of doing this when we unwind the
document.write call stack, we do this when we're about to resume
parsing after script execution.
Test: fast/parser/document-write-basic.html
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
LayoutTests:
This tests basic document.write functionality. There doesn't appear to
be another fast/parser test that covers this basic case (although it's
convered in some more complicated test cases incidentally.)
- fast/parser/document-write-basic-expected.txt: Added.
- fast/parser/document-write-basic.html: Added.
- 4:18 PM Changeset in webkit [142199] by
-
- 2 edits in trunk/Source/WebCore
Fix build when compiling with css3-text and css3-conditional-rules feature flags enabled.
https://bugs.webkit.org/show_bug.cgi?id=109217
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-07
Reviewed by Benjamin Poulain.
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collect):
- 4:06 PM Changeset in webkit [142198] by
-
- 5 edits6 adds in trunk
REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136
Patch by Keishi Hattori <keishi@webkit.org> on 2013-02-07
Reviewed by Kent Tamura.
Source/WebCore:
Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.
Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
- Resources/pagepopups/calendarPicker.css:
(.today-clear-area):
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
- platform/chromium/TestExpectations:
- 4:03 PM Changeset in webkit [142197] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=108719
Reviewed by Eric Seidel.
In the event of a main-thread touch fling, dispatch a series of
GestureScrollUpdateWithoutPropagation events defined in
https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
GestureScrollUpdate events) so that the fling does not
propagate to enclosing scrollables.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
- 3:59 PM Changeset in webkit [142196] by
-
- 1 edit in branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/Skipped
Skip test -> <rdar://problem/12968012>
- 3:58 PM Changeset in webkit [142195] by
-
- 4 edits6 adds in trunk
Non-scrollable divs and non-scrollable iframes can scroll with touch
https://bugs.webkit.org/show_bug.cgi?id=109087
Reviewed by Eric Seidel.
Source/WebCore:
Tests: fast/events/touch/gesture/touch-gesture-noscroll-div.html
fast/events/touch/gesture/touch-gesture-noscroll-iframe.html
When finding a candidate for a scrollable node in
EventHandler::handleGestureScrollUpdate(), select the document node
if it is reached before any scrollable element when walking up the DOM
tree. Also ensure that calling RenderLayer::scrollBy() for a document
node does not result in scrolling if the element is not scrollable.
- page/EventHandler.cpp:
(WebCore::closestScrollableNodeCandidate):
(WebCore::EventHandler::handleGestureScrollUpdate):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollBy):
LayoutTests:
Two new layout tests added to demonstrate that the changes to
RenderLayer::scrollBy() and closestScrollableNodeCandidate() in
EventHandler.cpp are both necessary to ensure that non-scrollable
divs and non-scrollable iframes cannot be scrolled with touch.
- fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-div.html: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-noscroll-iframe.html: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
- 3:52 PM Changeset in webkit [142194] by
-
- 1 edit4 adds in trunk/Source/WebCore
Introduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
https://bugs.webkit.org/show_bug.cgi?id=109109.
Reviewed by Anders Carlsson.
Adding back the new SQLTransaction and SQLTransactionSync files.
No new tests.
- Modules/webdatabase/SQLTransaction.cpp: Added.
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::from):
- Modules/webdatabase/SQLTransaction.h: Added.
(SQLTransaction):
- Modules/webdatabase/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::from):
- Modules/webdatabase/SQLTransactionSync.h: Added.
(SQLTransactionSync):
- 3:49 PM Changeset in webkit [142193] by
-
- 16 edits4 moves in trunk/Source/WebCore
Introduce SQLTransactionBackend and SQLTransactionBackendSync.
https://bugs.webkit.org/show_bug.cgi?id=109109.
Reviewed by Anders Carlsson.
- Renamed SQLTransaction and SQLTransactionSync to SQLTransactionBackend and SQLTransactionBackendSync respectively.
- Added back SQLTransaction and SQLTransactionSync as new files, and have their classes extends their respective backends. This is a stop gap measure to keep things working until the front-end and back-end can be properly split. Note: these files will be committed in a subsequent commit to ensure that the patching goes smoothly.
- Where needed, I made use of new SQLTransaction::from() and SQLTransactionSync::from() static methods that "get" the front-end transactions from the back-ends. This is also a stop gap measure to keep things working until the proper refactoring is complete.
- Fixed up pre-existing style checker violations that are now detected on code that were touched during my renaming.
- Added the back-end files to all the build files.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::scheduleTransactionStep):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::create):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::transaction):
(DatabaseBackendAsync::DatabaseTransactionTask):
- Modules/webdatabase/SQLTransaction.cpp: Removed.
- Modules/webdatabase/SQLTransaction.h: Removed.
- Modules/webdatabase/SQLTransactionBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.cpp.
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::~SQLTransactionBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::debugStepName):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::performPendingCallback):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::deliverTransactionCallback):
(WebCore::SQLTransactionBackend::scheduleToRunStatements):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::deliverStatementCallback):
(WebCore::SQLTransactionBackend::deliverQuotaIncreaseCallback):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::deliverSuccessCallback):
(WebCore::SQLTransactionBackend::cleanupAfterSuccessCallback):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::deliverTransactionErrorCallback):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
- Modules/webdatabase/SQLTransactionBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.h.
(SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionBackendSync.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp.
(WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::~SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::executeSQL):
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::execute):
(WebCore::SQLTransactionBackendSync::commit):
(WebCore::SQLTransactionBackendSync::rollback):
- Modules/webdatabase/SQLTransactionBackendSync.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.h.
(SQLTransactionBackendSync):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):
- Modules/webdatabase/SQLTransactionCoordinator.h:
(SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(CoordinationInfo):
- Modules/webdatabase/SQLTransactionSync.cpp: Removed.
- Modules/webdatabase/SQLTransactionSync.h: Removed.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 3:45 PM Changeset in webkit [142192] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Add a flag to enable native form validation message
https://bugs.webkit.org/show_bug.cgi?id=109134
Reviewed by Adam Barth.
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures): Add enableNativeValidationMessage and
isNativeValidationMessageEnabled.
- src/WebRuntimeFeatures.cpp:
(WebKit): Add nativeValidationMessageEnabled.
(WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
(WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
Fill Page::PageClients::validationMessageClient if the flag is true.
- 3:42 PM Changeset in webkit [142191] by
-
- 6 edits in trunk/Source/WebCore
Use new speech bubble artwork for captions menu button
https://bugs.webkit.org/show_bug.cgi?id=109215
Reviewed by Eric Carlson.
Rather than call into RenderTheme to display this button, embed artwork
into the CSS. This means we can remove some uncalled methods in
RenderTheme.
- css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-toggle-closed-captions-button): New background image using SVG.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Don't call the specific painter for the CC button.
- rendering/RenderTheme.h: Remove unused function.
- rendering/RenderThemeMac.h: Ditto.
- rendering/RenderThemeMac.mm: Ditto.
- 3:32 PM Changeset in webkit [142190] by
-
- 4 edits2 adds in trunk
[CSS Shaders] Add the last blending step
https://bugs.webkit.org/show_bug.cgi?id=104012
Source/WebCore:
The resulting blended color in mix() is now weighted according to
the original element's backdrop alpha value.
Reviewed by Dean Jackson.
Test: css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
LayoutTests:
Added a test to check the correct blending in presence of a transparent backdrop.
Reviewed by Dean Jackson.
- css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Added.
- css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Added.
- platform/mac/TestExpectations: This test is currently skipped on Mac for slight color
differences, please see the relevant bug: http://webkit.org/b/107487
- 3:29 PM Changeset in webkit [142189] by
-
- 2 edits in trunk/Source/WebCore
Fix two exports of WebCore symbols on iOS
https://bugs.webkit.org/show_bug.cgi?id=109238
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by David Kilzer.
- WebCore.exp.in: Export wkCTFontTransformGlyphs but not
wkCGContextDrawsWithCorrectShadowOffsets on iOS.
- 3:25 PM Changeset in webkit [142188] by
-
- 2 edits in trunk/Tools
Unreviewed. Another temporary EWS bot fix. It'll totally work this time.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 3:20 PM Changeset in webkit [142187] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
https://bugs.webkit.org/show_bug.cgi?id=107566
Patch by Hans Muller <hmuller@adobe.com> on 2013-02-07
Reviewed by David Hyatt.
Source/WebCore:
Improve ExclusionPolygon::firstIncludedIntervalLogicalTop() performance by only
creating offset edges for polygon edges that are below the horizontal minLogicalIntervalTop
line. In other words, don't bother creating offset edges that can't define the polygon's
first fit location.
Test: fast/exclusions/shape-inside/shape-inside-first-fit-004.html
- rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Don't create offset edges for polygon edges above minLogicalIntervalTop.
LayoutTests:
Added a simple polygonal shape-inside test where only a subset of the polygon edges
should contribute to each line's offset edges.
- fast/exclusions/shape-inside/shape-inside-first-fit-004-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-first-fit-004.html: Added.
- 3:19 PM Changeset in webkit [142186] by
-
- 3 edits in trunk/Source/WebCore
Improve logging of MediaPlayerPrivateAVFoundation Notifications.
https://bugs.webkit.org/show_bug.cgi?id=109223
Reviewed by Eric Carlson.
Convert the existing Notification enum to an expandable macro. Then add a
Logging-only function which stringifies the enums.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore):
(WebCore::notificationName):
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- 3:17 PM Changeset in webkit [142185] by
-
- 1 edit2 adds in trunk/LayoutTests
Add layout test verifying role, subrole, and role description for all HTML elements and ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=109027
Patch by James Craig <jcraig@apple.com> on 2013-02-07
Reviewed by Chris Fleizach.
New layout test verifies AXRole, AXSubrole, and AXRoleDescription for all HTML elements and ARIA roles.
- platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
- platform/mac/accessibility/role-subrole-roledescription.html: Added.
- 3:11 PM Changeset in webkit [142184] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838
Reviewed by Mark Rowe.
Removing the changes to the Xcode project file and moving the equivalent flags into
the ToolExecutable xcconfig file.
- Configurations/ToolExecutable.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:53 PM Changeset in webkit [142183] by
-
- 2 edits in trunk/Source/WTF
Fix an incorrect comment from r142163
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
- wtf/MainThread.h:
I accidentally copied PLATFORM(IOS) instead of USE(WEB_THREAD) for the #ifdef closing.
- 2:52 PM Changeset in webkit [142182] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix syntax error in runtests.py.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 2:44 PM Changeset in webkit [142181] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
[Windows] Unreviewed Visual Studio 2010 build fixes after r142179.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Correct changed symbols
- JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Removed autogenerated file.
- 2:33 PM Changeset in webkit [142180] by
-
- 2 edits in trunk/Tools
Temporary fix for Win EWS bots.
Don't build DRT since it has already been built in the build step.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 2:08 PM Changeset in webkit [142179] by
-
- 11 edits in trunk
[GTK] Cleanup command-line defines
https://bugs.webkit.org/show_bug.cgi?id=109213
Reviewed by Xan Lopez.
.:
- GNUmakefile.am: Remove references to flags that are now provided
by autotoolsconfig.h
- configure.ac: Add new AC_DEFINE invocations for flags that were
before manually appended to the compiler CPPFLAGS and clump all
AC_DEFINE invocations together.
Source/WebCore:
- GNUmakefile.am: Remove references to flags that are now handled
via autotoolsconfig.h.
Source/WebKit/gtk:
- GNUmakefile.am: Remove references to flags that are now provided
by autotoolsconfig.h
Source/WebKit2:
- GNUmakefile.am: Remove references to flags that are now
provided by autotoolsconfig.h.
Tools:
- TestWebKitAPI/config.h: Include the autotoolsconfig.h header to pick
up defines from autoconf.
- 2:04 PM Changeset in webkit [142178] by
-
- 2 edits in trunk/Tools
git.svn_revision doesn't fetch the same revision as svn.svn_revision
https://bugs.webkit.org/show_bug.cgi?id=108684
Reviewed by Dirk Pranke.
Always call git log on the checkout root.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.svn_revision):
- 1:58 PM Changeset in webkit [142177] by
-
- 2 edits in trunk/Source/WebCore
[V8] Binding Integrity crash in V8MediaStream::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=109211
Reviewed by Adam Barth.
Patch suppresses a chrome crasher.
- Modules/mediastream/MediaStream.idl:
- 1:55 PM Changeset in webkit [142176] by
-
- 2 edits in trunk/Source/WebCore
[Mac] decrease in-band caption advance notice interval
https://bugs.webkit.org/show_bug.cgi?id=109190
Reviewed by Simon Fraser.
No new tests, no observable change in behavior.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.
- 1:49 PM Changeset in webkit [142175] by
-
- 2 edits in trunk/Tools
Unreviewed. Patch for testing Win EWS bots.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 1:44 PM Changeset in webkit [142174] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 1:39 PM Changeset in webkit [142173] by
-
- 31 edits3 deletes in trunk/Tools
Unreviewed, rolling out r142165.
http://trac.webkit.org/changeset/142165
https://bugs.webkit.org/show_bug.cgi?id=108466
Broke linux_aura builds.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
(WebTaskList):
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(MockGrammarCheck::checkGrammarOfString):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- 1:37 PM Changeset in webkit [142172] by
-
- 5 edits in trunk
[GTK][AC] Clutter required version up to 1.12
https://bugs.webkit.org/show_bug.cgi?id=109037
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-07
Reviewed by Martin Robinson.
.:
The clutter requried version is changed to 1.12.
- configure.ac:
Source/WebCore:
Replace deprecated clutter apis with new ones.
No new tests, since this patch is minor refactoring.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetAnchorPoint):
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::updateSublayerList):
- 1:34 PM Changeset in webkit [142171] by
-
- 53 edits4 adds4 deletes in trunk
Move pauseAnimation/pauseTransition from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109107
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: animations/animation-internals-api-multiple-keyframes.html
animations/animation-internals-api.html
- testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnElement):
(WebCore):
(WebCore::Internals::pauseTransitionAtTimeOnElement):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
Change the tests with the following:
-Use the methods on Internals instead of TestRunner.
-Adapt the calls to pass a particular element instead of an ID.
-Remove feature detection. Having Internals implies having the feature.
- animations/animation-hit-test-transform.html:
- animations/animation-hit-test.html:
- animations/animation-internals-api-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-expected.txt.
- animations/animation-internals-api-multiple-keyframes-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.txt.
- animations/animation-internals-api-multiple-keyframes.html: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes.html.
- animations/animation-internals-api.html: Renamed from LayoutTests/animations/animation-drt-api.html.
- animations/change-keyframes-name.html:
- animations/change-transform-style-during-animation.html:
- animations/missing-from-to-transforms.html:
- animations/missing-from-to.html:
- animations/resources/animation-test-helpers.js:
(checkExpectedValue):
(startTest):
- css3/calc/transitions-dependent.html:
- fast/dom/shadow/transition-on-shadow-host-with-distributed-node.html:
- transitions/opacity-transition-zindex.html:
- transitions/resources/transition-test-helpers.js:
(expected):
- transitions/transition-drt-api-delay.html:
- transitions/transition-drt-api.html:
- transitions/transition-hit-test-transform.html:
- transitions/transition-hit-test.html:
- 1:26 PM Changeset in webkit [142170] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r142155.
http://trac.webkit.org/changeset/142155
https://bugs.webkit.org/show_bug.cgi?id=82888
cr/win build broke.
- bindings/js/JSClipboardCustom.cpp:
(WebCore::JSClipboard::types):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
- dom/Clipboard.h:
(Clipboard):
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h:
(ClipboardBlackBerry):
- platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::types):
- platform/chromium/ClipboardChromium.h:
(ClipboardChromium):
- platform/efl/ClipboardEfl.cpp:
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h:
(ClipboardEfl):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h:
(ClipboardGtk):
- platform/mac/ClipboardMac.h:
(ClipboardMac):
- platform/mac/ClipboardMac.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
- platform/win/ClipboardWin.cpp:
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h:
(ClipboardWin):
- 1:20 PM Changeset in webkit [142169] by
-
- 22 edits in trunk/Source/WebKit2
[WK2][EFL] Removal of non coordinated graphics code path from WK2 EFL
https://bugs.webkit.org/show_bug.cgi?id=109165
Reviewed by Anders Carlsson.
Removed non coordinated graphics code path from WK2 EFL as it was not used by
anyone and caused a lot of preprocessor macros in the code making it less readable.
- UIProcess/API/efl/EvasGLContext.cpp:
- UIProcess/API/efl/EvasGLContext.h:
(WebKit::EvasGLContext::context):
- UIProcess/API/efl/EvasGLSurface.cpp:
- UIProcess/API/efl/EvasGLSurface.h:
(WebKit::EvasGLSurface::surface):
Removed also 'inline' and 'const' keywords from functions declaration,
as both EvasGLContext::context() and EvasGLSurface::surface()
are defined inside their classes and return mutable pointer.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::transformFromScene):
(EwkView::transformToScreen):
(EwkView::coordinatedGraphicsScene):
(EwkView::displayTimerFired):
(EwkView::scheduleUpdateDisplay): Renamed from EwkView::update().
(EwkView::exitAcceleratedCompositingMode):
(EwkView::handleEvasObjectCalculate):
(EwkView::takeSnapshot):
- UIProcess/API/efl/EwkView.h:
(WebCore):
(EwkView):
- UIProcess/API/efl/SnapshotImageGL.cpp:
(getImageSurfaceFromFrameBuffer):
- UIProcess/API/efl/SnapshotImageGL.h:
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
- UIProcess/efl/PageClientBase.h:
(PageClientBase):
- UIProcess/efl/PageClientDefaultImpl.cpp:
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
- UIProcess/efl/PageClientDefaultImpl.h:
(PageClientDefaultImpl):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
- UIProcess/efl/PageClientLegacyImpl.h:
(PageClientLegacyImpl):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):
- UIProcess/efl/PageLoadClientEfl.h:
(PageLoadClientEfl):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
- UIProcess/efl/PageViewportControllerClientEfl.h:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- 1:13 PM Changeset in webkit [142168] by
-
- 11 edits8 adds in trunk
Add support for parsing of -webkit-background-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=108547
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-07
Reviewed by David Hyatt.
Source/WebCore:
Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode
Tests: css3/compositing/background-blend-mode-property-parsing.html
css3/compositing/background-blend-mode-property.html
- css/CSSComputedStyleDeclaration.cpp: Built value for getComputedStyle.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp: Parsed and stored value of -webkit-background-blend-mode.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
- css/CSSProperty.cpp: Listed -webkit-background-blend-mode as a non-inherited property.
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in: Added -webkit-background-blend-mode as a CSS property.
- css/CSSToStyleMap.cpp: Mapped background blend mode from CSS value to enum.
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore):
- css/CSSToStyleMap.h: Added function declaration 'mapFillBlendMode'.
(CSSToStyleMap):
- css/StyleBuilder.cpp: Set up propery handler for -webkit-background-blend-mode.
(WebCore::StyleBuilder::StyleBuilder):
- rendering/style/FillLayer.cpp: Added code to store and retrieve the blend mode from a layer.
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
- rendering/style/FillLayer.h: Added function definitions to manage blend mode in a layer.
(WebCore::FillLayer::blendMode):
(WebCore::FillLayer::isBlendModeSet):
(WebCore::FillLayer::setBlendMode):
(WebCore::FillLayer::clearBlendMode):
(WebCore::FillLayer::initialFillBlendMode):
(FillLayer):
LayoutTests:
Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode
- css3/compositing/background-blend-mode-property-expected.txt: Added.
- css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
- css3/compositing/background-blend-mode-property-parsing.html: Added.
- css3/compositing/background-blend-mode-property.html: Added.
- css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):
- css3/compositing/script-tests/background-blend-mode-property.js: Added.
(testblendmode):
- css3/compositing/background-blend-mode-property-expected.txt: Added.
- css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
- css3/compositing/background-blend-mode-property-parsing.html: Added.
- css3/compositing/background-blend-mode-property.html: Added.
- css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.
(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):
- css3/compositing/script-tests/background-blend-mode-property.js: Added.
(testblendmode):
- platform/chromium/css3/compositing/background-blend-mode-property-expected.txt: Added.
- platform/chromium/css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
- 1:10 PM Changeset in webkit [142167] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r142142.
http://trac.webkit.org/changeset/142142
https://bugs.webkit.org/show_bug.cgi?id=109154
Source/WebCore:
Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
LayoutTests:
Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html
- inspector/editor/text-editor-home-button-expected.txt: Removed.
- inspector/editor/text-editor-home-button.html: Removed.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 1:03 PM Changeset in webkit [142166] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r142081.
http://trac.webkit.org/changeset/142081
https://bugs.webkit.org/show_bug.cgi?id=109146
The patch caused a crash in inspector-protocol/nmi-webaudio*.html .
See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- 12:58 PM Changeset in webkit [142165] by
-
- 31 edits3 copies in trunk/Tools
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466
Reviewed by Adam Barth.
To achieve this, we need to drop all dependencies on WTF.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- 12:50 PM Changeset in webkit [142164] by
-
- 7 edits2 adds in trunk
[CSS Exclusions] shape-inside does not properly handle padding or border
https://bugs.webkit.org/show_bug.cgi?id=102715
Patch by Bear Travis <betravis@adobe.com> on 2013-02-07
Reviewed by David Hyatt.
Source/WebCore:
This patch positions the exclusion shape based on the value of the css box sizing
property. Geometry calculations happen in the shape coordinate space. For layout,
these coordinates are translated to the border-box coordinate system by adding
the appropriate offsets.
Test: fast/exclusions/shape-inside/shape-inside-box-sizing.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore::::computedShape): Pass m_shapeLogicalWidth to the exclusion shape
geometry code.
- rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::setShapeSize): Adjust block layout dimensions to
shape dimensions when checking to see if the shape geometry must be recalculated.
(WebCore::ExclusionShapeInfo::shapeLogicalTop): Account for layout offsets.
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::logicalTopOffset): Return the offset from the logical
top of the border box to the logical top of the shape.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Return the offset from the logical
left of the border box to the logical left of the shape.
(ExclusionShapeInfo):
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Adjust line top to
be in shape coordinates.
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Use consistent
coordinate system (border box) to test for whether a line overlaps a shape.
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): Include the logical offset
from the border box.
(WebCore::ExclusionShapeInsideInfo::logicalLineBottom): Ditto.
LayoutTests:
Test that borders and padding are properly accounted for when laying out text in
a shape inside.
- fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified to no longer
use padding.
- fast/exclusions/shape-inside/shape-inside-box-sizing-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-box-sizing.html: Added.
- 12:35 PM Changeset in webkit [142163] by
-
- 8 edits in trunk/Source
Upstream iOS isWebThread() and isUIThread()
https://bugs.webkit.org/show_bug.cgi?id=109130
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Sam Weinig.
Source/WebCore:
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject initialize]):
- platform/mac/SharedBufferMac.mm:
(+[WebCoreSharedBufferData initialize]):
#ifdef out the legacy initialization as it is not correct when
using a WebThread.
Source/WTF:
On iOS, it is sometimes necessary to differenciate the thread running WebCore,
and the thread running the UI. This patch upstream those functions.
- wtf/MainThread.cpp:
- wtf/MainThread.h:
Disable the legacy initializer as it is incorrect when using the WebThread to run WebCore.
(WTF::isWebThread):
(WTF::isUIThread):
Return true when the current thread is the Web/UI thread.
- wtf/mac/MainThreadMac.mm:
(WTF::isUIThread):
(WTF::isWebThread):
- wtf/text/AtomicString.cpp:
(WTF::AtomicStringTable::create):
Use the newly added methods.
- 12:22 PM Changeset in webkit [142162] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG::ByteCodeParser should do surgical constant folding to reduce load on the optimization fixpoint
https://bugs.webkit.org/show_bug.cgi?id=109000
Reviewed by Oliver Hunt.
Previously our source parser's ASTBuilder did some surgical constant folding, but it
didn't cover some cases. It was particularly incapable of doing constant folding for
cases where we do some minimal loop peeling in the bytecode generator - since it
didn't "see" those constants prior to the peeling. Example:
for (var i = 0; i < 4; ++i)
things;
This will get peeled just a bit by the bytecode generator, so that the "i < 4" is
duplicated both at the top of the loop and the bottom. This means that we have a
constant comparison: "0 < 4", which the bytecode generator emits without any further
thought.
The DFG optimization fixpoint of course folds this and simplifies the CFG
accordingly, but this incurs a compile-time cost. The purpose of this change is to
do some surgical constant folding in the DFG's bytecode parser, so that such
constructs reduce load on the CFG simplifier and the optimization fixpoint. The goal
is not to cover all cases, since the DFG CFA and CFG simplifier have a powerful
sparse conditional constant propagation that we can always fall back on. Instead the
goal is to cover enough cases that for common small functions we don't have to
perform such transformations, thereby reducing compile times.
This also refactors m_inlineStackEntry->m_inlineCallFrame to be a handy method call
and also adds the notion of a TriState-based JSValue::pureToBoolean(). Both of these
things are used by the folder.
As well, care has been taken to make sure that the bytecode parser only does folding
that is statically provable, and that doesn't arise out of speculation. This means
we cannot fold on data flow that crosses inlining boundaries. On the other hand, the
folding that the bytecode parser uses doesn't require phantoming anything. Such is
the trade-off: for anything that we do need phantoming, we defer it to the
optimization fixpoint.
Slight SunSpider speed-up.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::canFold):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGNode.h:
(JSC::DFG::Node::isStronglyProvedConstantIn):
(Node):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):
(JSC):
- 12:02 PM Changeset in webkit [142161] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: CPU pegged when inspecting LocalStorage that mutates.
https://bugs.webkit.org/show_bug.cgi?id=107937
Reviewed by Yury Semikhatsky.
The DOM storage agent will fire an event to the frontend based on the action
performed on the storage. Based on this action, the front-end will just add/update/remove
the entry in the view. This enhances the front-end responsiveness as the round trip
for fetching the storage entries has been eliminated.
Existing test: LayoutTests/inspector/storage-panel-dom-storage-update.html should verify the change
- inspector/Inspector.json:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemAdded):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemUpdated):
- inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView):
(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemAdded):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):
- 11:58 AM Changeset in webkit [142160] by
-
- 20 edits in trunk/Source/WebKit2
Make WebPageProxy and sub-objects MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=108785
Reviewed by Anders Carlsson.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::~DrawingAreaProxy):
(WebKit::DrawingAreaProxy::contentsRect):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
- UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
- UIProcess/WebFullScreenManagerProxy.messages.in:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::inspector):
(WebKit::WebPageProxy::fullScreenManager):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/mac/WebFullScreenManagerProxyMac.mm:
(WebKit::WebFullScreenManagerProxy::invalidate):
- 11:48 AM Changeset in webkit [142159] by
-
- 35 edits in trunk/Source/WebCore
[v8] move persistent::new and ::dispose into same class
https://bugs.webkit.org/show_bug.cgi?id=109065
Patch by Dan Carney <dcarney@google.com> on 2013-02-07
Reviewed by Adam Barth.
No new tests. No change in functionality.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::createWrapper):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::createWrapper):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::createWrapper):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::createWrapper):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::createWrapper):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::createWrapper):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::createWrapper):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::createWrapper):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::createWrapper):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::createWrapper):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
- bindings/v8/DOMDataStore.cpp:
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapper):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::removeAndDispose):
(WebCore::DOMWrapperMap::defaultWeakCallback):
- bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::associateObjectWithWrapper):
- bindings/v8/V8NPObject.cpp:
(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::initializeContextIfNeeded):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperConfiguration):
(WebCore::WrapperConfiguration::configureWrapper):
(WebCore::buildWrapperConfiguration):
- bindings/v8/custom/V8ArrayBufferCustom.cpp:
(WebCore::V8ArrayBuffer::constructorCallbackCustom):
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):
- bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallbackCustom):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallbackCustom):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallbackCustom):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
- bindings/v8/custom/V8IntentCustom.cpp:
(WebCore::V8Intent::constructorCallbackCustom):
- bindings/v8/custom/V8MessageChannelCustom.cpp:
(WebCore::V8MessageChannel::constructorCallbackCustom):
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallbackCustom):
- bindings/v8/custom/V8WebKitPointCustom.cpp:
(WebCore::V8WebKitPoint::constructorCallbackCustom):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCallbackCustom):
- 11:31 AM Changeset in webkit [142158] by
-
- 7 edits in trunk
[Autotools] Remove uses of Automake FARSTREAM_(CFLAGS|LIBS) variables, USE_FARSTREAM conditional
https://bugs.webkit.org/show_bug.cgi?id=109198
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: The USE_FARSTREAM conditional is being removed while the WTF_USE_FARSTREAM
define is currently a no-op.
- configure.ac: Don't set the Automake conditional as it's currently not needed due
to checking for Farstream dependency being removed in r142005.
Source/WebCore:
- GNUmakefile.am: Remove FARSTREAM_CFLAGS variable, it's not set to anything.
Source/WebKit2:
- GNUmakefile.am: Remove the FARSTREAM_(CFLAGS|LIBS) variables, they're
not set to anything.
- 11:19 AM Changeset in webkit [142157] by
-
- 8 edits in trunk/Source/WebKit2
[WK2][EFL] Add WKView methods related to background drawing
https://bugs.webkit.org/show_bug.cgi?id=109159
Reviewed by Anders Carlsson.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setDrawsBackground):
(WebKit):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
- UIProcess/efl/WebView.h:
(WebView):
- UIProcess/API/C/efl/WKView.h:
New methods added
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::handleEvasObjectColorSet):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_draws_page_background_set):
Remove the unneeded m_setDrawsBackground and replace
it with the WKView setting.
- 11:04 AM Changeset in webkit [142156] by
-
- 2 edits in trunk/Tools
Do not check enum's casing for WebKit2 C API.
https://bugs.webkit.org/show_bug.cgi?id=109128
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-02-07
Reviewed by Kenneth Rohde Christiansen.
Add "-readability/enum_casing" for WebKit2 C APIs because we use word
which starts with non-capital letter 'k' for types of enums.
- Scripts/webkitpy/style/checker.py:
- 11:00 AM Changeset in webkit [142155] by
-
- 20 edits in trunk/Source/WebCore
Consider replacing return type of Clipboard::types() from ListHashSet<String> to Vector<String>
https://bugs.webkit.org/show_bug.cgi?id=82888
Reviewed by Kentaro Hara.
As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than ListHashSet<String>
No new tests. Existing test should pass with this change as no behavoural changes.
- bindings/js/JSClipboardCustom.cpp: Replace data type from ListHashSet<> to Vector<>.
(WebCore::JSClipboard::types):
- bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.
(WebCore::V8Clipboard::typesAccessorGetter): Ditto.
- dom/Clipboard.h: Ditto.
- platform/blackberry/ClipboardBlackBerry.cpp: Ditto.
(WebCore::ClipboardBlackBerry::types):
- platform/blackberry/ClipboardBlackBerry.h: Ditto.
- platform/chromium/ChromiumDataObject.cpp: Ditto.
(WebCore::ChromiumDataObject::types):
- platform/chromium/ChromiumDataObject.h: Ditto.
- platform/chromium/ClipboardChromium.cpp: Ditto.
(WebCore::ClipboardChromium::types):
- platform/chromium/ClipboardChromium.h: Ditto.
- platform/efl/ClipboardEfl.cpp: Ditto.
(WebCore::ClipboardEfl::types):
- platform/efl/ClipboardEfl.h: Ditto.
- platform/gtk/ClipboardGtk.cpp: Ditto.
(WebCore::ClipboardGtk::types):
- platform/gtk/ClipboardGtk.h: Ditto.
- platform/mac/ClipboardMac.h: Ditto.
- platform/mac/ClipboardMac.mm: Ditto.
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):
- platform/qt/ClipboardQt.cpp: Ditto.
(WebCore::ClipboardQt::types):
- platform/qt/ClipboardQt.h: Ditto.
- platform/win/ClipboardWin.cpp: Ditto.
(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):
- platform/win/ClipboardWin.h: Ditto.
- 10:57 AM Changeset in webkit [142154] by
-
- 3 edits in trunk/Source/WebCore
[V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
https://bugs.webkit.org/show_bug.cgi?id=109123
Reviewed by Adam Barth.
Currently StringCache::m_stringCache is implemented as
HashMap<StringImpl*, v8::String*>. Given that v8::String*
can change when a GC is triggered, it is dangerous to store a raw pointer.
We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.
This is a possible fix for an IndexedDB crash (https://bugs.webkit.org/show_bug.cgi?id=105363),
although I'm not sure if this patch fixes the crash. (I couldn't reproduce the crash.)
No tests. This change highly depends on GC behavior and thus it is
difficult to make a reliable test case.
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
- bindings/v8/V8ValueCache.h:
(StringCache):
- 10:49 AM Changeset in webkit [142153] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
https://bugs.webkit.org/show_bug.cgi?id=108634
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.
Use more robust data validation in EWK2UnitTestBase.ewk_view_page_contents_get
so that the test passes consistently. The issue was that the header before the
data includes the current date. Depending on the date, the data may start at a
different index in the returned string. Instead of hardcoding the data start
index in the test, we now use String::contains().
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsCallback):
(TEST_F):
- 10:48 AM Changeset in webkit [142152] by
-
- 9 edits4 adds in trunk
CSS 2.1 failure: floats-149 fails
https://bugs.webkit.org/show_bug.cgi?id=95772
Reviewed by David Hyatt.
Source/WebCore:
Treat inlines that contain nothing but empty inlines as empty too so that they get a linebox.
Tests: fast/inline/inline-with-empty-inline-children.html
css2.1/20110323/floats-149.htm
- rendering/InlineIterator.h:
(WebCore::isEmptyInline):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Now that empty inlines get a linebox any out-of-flow
objects inside an empty inline (on a line that is otherwise empty) won't get positioned while skipping
through leading whitespace.
LayoutTests:
- css2.1/20110323/floats-149-expected.html: Added.
- css2.1/20110323/floats-149.htm: Added.
- fast/inline/inline-with-empty-inline-children-expected.txt: Added.
- fast/inline/inline-with-empty-inline-children.html: Added.
- platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- 10:39 AM Changeset in webkit [142151] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fix after r141981
https://bugs.webkit.org/show_bug.cgi?id=109184
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-07
Reviewed by Brent Fulgham.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously):
- 10:24 AM Changeset in webkit [142150] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Cookie database isn't loaded into memory in some rare cases
https://bugs.webkit.org/show_bug.cgi?id=109202
PR 286189
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-02-07
Reviewed by Yong Li.
Internally Reviewed by Konrad Piascik.
If a get/setCookie call is made before the database is loaded, or if there's some
kind of error that causes the loading of the database to fail in the constructor
of CookieManager, the browser will get into a state where it seems like cookie is
permanenty disabled.
Instead of logging the errors and redispatching the setCookie, we should do a force sync
to load the cookie database before continuing.
Since the bug is so difficult to reproduce (I never did so myself), I did the follow test
to make sure the code path is correct:
1) Make sure original implementation is retained - open and loading done in the constructor
2) Removed opening and loading in constructor, the new calls in get/setcookies loaded the db just fine (although with
an initial lag because we are blocking WKT while performing SQLite options).
3) Removed loading in constructor, the new calls loaded the db just fine.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::openAndLoadDatabaseSynchronously):
(WebCore):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
(CookieDatabaseBackingStore):
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::getCookie):
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::getRawCookies):
- 10:21 AM Changeset in webkit [142149] by
-
- 3 edits5 moves1 add2 deletes in trunk
[CSS Shaders] Add WebKitCSSFilterRule to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=109082
Source/WebCore:
Reviewed by Dean Jackson.
Add an entry for WebKitCSSFilterRuleConstructor in DOMWindow.idl.
Tests: css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html
- page/DOMWindow.idl:
LayoutTests:
Move the at-rule parsing tests to the recently added folder named
"custom-with-at-rule-parsing".
Remove the "custom-filter" prefix from the test filenames to
match the new convention.
Update the tests to use the "shouldHaveConstructor" JS helper function instead of the
"shouldBeType" JS helper function. Among other things, using "shouldHaveConstructor" tests
that window.WebKitCSSFilterRule is defined. "shouldHaveConstructor" has the same
behavior in JSC and V8, unlike "shouldBeType". Therefore, remove the Chromium-specific text
expectation file that was previously needed for "shouldBeType".
Reviewed by Dean Jackson.
- css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid-expected.txt: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.txt.
- css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid.html.
- css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-valid.html.
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-invalid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js.
(testInvalidFilterAtRule):
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-valid.js.
(testFilterAtRule):
(testNestedRules):
(checkRule):
- css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.
- platform/chromium/css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.
- 10:14 AM Changeset in webkit [142148] by
-
- 5 edits in trunk
Web Inspector: Remove unused workspace field from NetworkUISourceCodeProvider
https://bugs.webkit.org/show_bug.cgi?id=109201
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/debugger/network-uisourcecode-provider.html:
- 10:12 AM Changeset in webkit [142147] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distinguished
by key
https://bugs.webkit.org/show_bug.cgi?id=109196
Reviewed by Eric Carlson.
- English.lproj/Localizable.strings:
Updated for the changes.
- platform/LocalizedStrings.cpp:
(WebCore::unknownFileSizeText):
Add a key.
(WebCore::textTrackNoLabelText):
Ditto.
- 10:04 AM Changeset in webkit [142146] by
-
- 2 edits in trunk/Source/JavaScriptCore
Invalid code is generated for storing constants with baseindex addressing modes on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109050
Reviewed by Oliver Hunt.
The S! scratch register is reused, but it should contain the constant value.
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::baseIndexTransfer16):
- 10:03 AM Changeset in webkit [142145] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: linkifyResourceAsNode produced anchor should not prefer resources to scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=109197
Reviewed by Pavel Feldman.
Javascript syntax errors in console are now linkified so that they show sources panel by default.
- inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyResourceAsNode):
- 9:55 AM Changeset in webkit [142144] by
-
- 16 edits in trunk/Source
Web Inspector: Add settings checkbox for composited layer borders
https://bugs.webkit.org/show_bug.cgi?id=109096
Patch by Eberhard Graether <egraether@google.com> on 2013-02-07
Reviewed by Pavel Feldman.
This change adds a checkbox to show composited layer borders to the WebInspector's
rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
is visible if InspectorClient::canShowDebugBorders() returns true.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowDebugBorders):
Source/WebCore:
No new tests.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::canShowDebugBorders):
(WebCore::InspectorClient::setShowDebugBorders):
(InspectorClient):
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowDebugBorders):
(WebCore):
(WebCore::InspectorPageAgent::setShowDebugBorders):
- inspector/InspectorPageAgent.h:
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showDebugBordersChanged):
- inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
Source/WebKit/chromium:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowDebugBorders):
(WebKit):
(WebKit::InspectorClientImpl::setShowDebugBorders):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowDebugBorders):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- 9:51 AM Changeset in webkit [142143] by
-
- 12 edits3 adds in trunk
Unreviewed, rolling out r142141.
http://trac.webkit.org/changeset/142141
https://bugs.webkit.org/show_bug.cgi?id=108990
Reland r142112, will update Chromium expectations and create a
Chromium bug instead for the crash.
.:
- ManualTests/remove-fixed-position-but-keep-compositing.html: Added.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- WebCore.pri:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.
(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- 9:46 AM Changeset in webkit [142142] by
-
- 6 edits2 adds in trunk
Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Handle home key shortcut explicitly in TextEditorMainPanel.
New test: inspector/editor/text-editor-home-button.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):
LayoutTests:
Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.
- inspector/editor/text-editor-home-button-expected.txt: Added.
- inspector/editor/text-editor-home-button.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 9:32 AM Changeset in webkit [142141] by
-
- 12 edits3 deletes in trunk
Unreviewed, rolling out r142112.
http://trac.webkit.org/changeset/142112
https://bugs.webkit.org/show_bug.cgi?id=108990
The new test scrollingcoordinator/non-fast-scrollable-region-transformed- iframe.html crashes on Lion.
.:
- ManualTests/remove-fixed-position-but-keep-compositing.html: Removed.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- WebCore.pri:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Removed.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Removed.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::CoordinatedLayerTreeHost::syncFixedLayers):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- 9:29 AM Changeset in webkit [142140] by
-
- 5 edits in trunk
Scrollbars misplaced with accelerated compositing for overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=108625
Reviewed by Simon Fraser.
Source/WebCore:
Scrollbars require their own layer if overflow scroll is composited,
otherwise the scrollbars would be rendered on the content layer and
not fixed to the viewport.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):
LayoutTests:
Update the results for the one test that explicitly set accelerated compositing for overflow scroll,
and used to have bad results for non-chromium. The new baselines are almost identical to chomium baseline.
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- 9:18 AM Changeset in webkit [142139] by
-
- 2 edits in trunk/Source/WebCore
Don't ASSERT things about uninitialized variables.
https://bugs.webkit.org/show_bug.cgi?id=109187
Reviewed by Jochen Eisinger.
Rather than ASSERTing that an uninitialized ExceptionCode is non-zero
after some method executes, we should use the ASSERT_NO_EXCEPTION macro.
- editing/markup.cpp:
(WebCore::removeElementPreservingChildren):
- 9:17 AM Changeset in webkit [142138] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Regression] breakpoint condition not editable
https://bugs.webkit.org/show_bug.cgi?id=109183
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.
Improve TextEditorMainPanel.selection() method to return null if the
selection is set inside of decoration element.
No new tests.
- inspector/front-end/DOMExtension.js:
(Node.prototype.enclosingNodeOrSelfWithClass): Improve to add iteration boundary.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.selection):
- 8:58 AM Changeset in webkit [142137] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix all flicker caused by empty/incomplete geometries.
https://bugs.webkit.org/show_bug.cgi?id=108951
RIM PR 286925
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
The main idea for this patch is that whenever we adopt
a new backingstore geometry that doesn't contain any
rendered tiles, or VisibleZoom render jobs that need more
tiles to be rendered to be considered complete, we'll then
suspend blitting until there is valid content to show.
This main idea is codified as checks for empty buffers
in adoptAsFrontState(), and checks for the current state
of the render queue after rendering content in render().
However, as BackingStore objects with disabled surface pools
or pure use of accelerated compositing also swap geometries
in some circumstances, the use of suspend counters grows
increasingly fragile.
To make this patch more resilient against regressions,
the current suspend counter is complemented with several
explicit conditions for suspending screen updates,
and both subsequently combined into a single cached
boolean value telling the UI thread whether or not to
suspend. In the future, other suspend calls can be
migrated to this "state machine" design as well,
potentially phasing out the suspend counter altogether.
The immediate result is that there will be no flashing
of background color between page loads or after discarding
tiles on scale changes until the content has been rendered.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
(BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):
- Api/BackingStore_p.h:
(BackingStorePrivate):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):
- 8:46 AM Changeset in webkit [142136] by
-
- 2 edits in trunk/Source/WebCore
[WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
https://bugs.webkit.org/show_bug.cgi?id=109185
Reviewed by Kenneth Rohde Christiansen.
This patch is disabling paints clipping logic added at r142045 for the case
when the view should render the entire contents (case of using tiled backing store).
No new tests, covered by plenty of existing manual tests that allow scrolling
(for example fixed-position.html).
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
- 8:42 AM Changeset in webkit [142135] by
-
- 26 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Added platform specific expected files after r140693.
https://bugs.webkit.org/show_bug.cgi?id=107567.
- platform/qt/TestExpectations:
- platform/qt/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/qt/css2.1/t0505-c16-descendant-01-e-expected.txt:
- platform/qt/editing/selection/extend-by-sentence-001-expected.png:
- platform/qt/editing/selection/extend-by-sentence-001-expected.txt:
- platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
- platform/qt/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
- platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
- platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
- platform/qt/fast/text/whitespace/006-expected.png:
- platform/qt/fast/text/whitespace/006-expected.txt:
- platform/qt/fast/text/whitespace/007-expected.png:
- platform/qt/fast/text/whitespace/007-expected.txt:
- platform/qt/svg/batik/text/xmlSpace-expected.png:
- platform/qt/svg/batik/text/xmlSpace-expected.txt:
- platform/qt/svg/carto.net/combobox-expected.png:
- platform/qt/svg/carto.net/combobox-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1188-expected.png:
- platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
- platform/qt/tables/mozilla/bugs/bug1318-expected.png:
- platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
- 8:42 AM Changeset in webkit [142134] by
-
- 2 edits in trunk/Tools
Unreviewed warning fix.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):
- 8:42 AM Changeset in webkit [142133] by
-
- 2 edits in trunk/Tools
Unreviewed typo fix after r142121.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 8:39 AM Changeset in webkit [142132] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: Show elements and sources sidebar panes in a tabbed pane when they are below the main pane
https://bugs.webkit.org/show_bug.cgi?id=107552
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.
Removed the aspect ratio detection logic and implemented explicit user action "Split Horizontally" available
in Elements and Sources panels. When split horizontally the sidebar panes are organized into a tabbed pane.
This user action is behind an experimental flag.
No new tests.
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenu.prototype.show):
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.createProxy):
(WebInspector.DOMBreakpointsSidebarPane.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expanded):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expand):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.collapse):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.wasShown):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._clearInterface):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expanded):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.collapse):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype.activePaneId):
(WebInspector.SidebarPaneStack.prototype.setActivePaneId):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):
(WebInspector.SidebarTabbedPane.prototype.activePaneId):
(WebInspector.SidebarTabbedPane.prototype.setActivePaneId):
(WebInspector.SidebarPaneGroup):
(WebInspector.SidebarPaneGroup.prototype.setStacked):
(WebInspector.SidebarPaneGroup.prototype.addPane):
(WebInspector.SidebarPaneGroup.prototype.attachToPanel):
(WebInspector.SidebarPaneGroup.prototype.populateContextMenu.toggleSplitDirection):
(WebInspector.SidebarPaneGroup.prototype.get _contextMenuEventFired):
(WebInspector.SidebarPaneGroup.prototype._onSplitDirectionSettingChanged):
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarElementStyle):
(WebInspector.SidebarView.prototype.setVertical):
(WebInspector.SidebarView.prototype.onResize):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.ComputedStyleSidebarPane.prototype.wasShown):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):
- inspector/front-end/inspector.css:
(.sidebar-pane .section .properties, .event-bar .event-properties):
(.pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > select):
(.sidebar-pane-toolbar > select:hover):
(.sidebar-pane-toolbar > select:active):
(.sidebar-pane-toolbar > select.select-settings):
(.sidebar-pane-toolbar > select.select-filter):
(.sidebar-pane-toolbar > select > option, .sidebar-pane-toolbar > select > hr):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane > .body .breakpoint-condition):
(.sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):
(.sidebar-pane .breakpoint-hit):
- 8:38 AM Changeset in webkit [142131] by
-
- 2 edits in trunk
[GTK] configure.ac requires a cleanup
https://bugs.webkit.org/show_bug.cgi?id=99272
Reviewed by Martin Robinson.
Clean up configure.ac. While there is no strict style guideline determined
for this file the changes enforce the usual indentation of four spaces along
with line wrapping at 130 characters and grammar fixes/updates.
- configure.ac:
- 8:37 AM Changeset in webkit [142130] by
-
- 5 edits6 deletes in trunk
Unreviewed, rolling out r142111.
http://trac.webkit.org/changeset/142111
https://bugs.webkit.org/show_bug.cgi?id=108055
win7 bot didn't display Arabic, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html
Source/WebCore:
- Resources/pagepopups/calendarPicker.css:
(.today-clear-area .today-button):
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize):
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Removed.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Removed.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Removed.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Removed.
- 8:31 AM Changeset in webkit [142129] by
-
- 2 edits in trunk/Source/WTF
[Qt] Fix build without 3D_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=109194
Reviewed by Noam Rosenthal.
Now that Coordinated Graphics was moved to WebCore, we need to explicitly enable
it when we have 3D_GRAPHICS. This dependency was implicitly by the fact that
3D_GRAPHICS is a dependency of WebKit2 and Coordinated Graphics was only
available there. This should fix build for Qt SH4 Linux.
- wtf/Platform.h:
- 8:30 AM Changeset in webkit [142128] by
-
- 5 edits in trunk
Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/utilities.js:
LayoutTests:
- inspector/map-expected.txt:
- inspector/map.html:
- 8:25 AM Changeset in webkit [142127] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193
Reviewed by Vsevolod Vlasov.
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update):
- 8:22 AM Changeset in webkit [142126] by
-
- 35 edits in trunk/Source/WebCore
Unreviewed, rolling out r142118.
http://trac.webkit.org/changeset/142118
https://bugs.webkit.org/show_bug.cgi?id=109044
Broke SVG! Oh noes!
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
- dom/Document.cpp:
(WebCore::Document::setTitle):
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
- editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):
- editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
- editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
- editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
- page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
- svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
- svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
- 8:21 AM WebKitGTK/1.10.x edited by
- (diff)
- 8:19 AM WebKitGTK/1.10.x edited by
- (diff)
- 8:04 AM Changeset in webkit [142125] by
-
- 3 edits in trunk/Tools
[Qt] QtTestBrowser should provide option to enable/disable Javascript
https://bugs.webkit.org/show_bug.cgi?id=107461
Reviewed by Jocelyn Turcotte.
Option to enable/disable Javascript would be handy option to test
certain functionalities of web pages with/without Javascript.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::toggleJavaScriptEnabled):
- QtTestBrowser/launcherwindow.h:
(LauncherWindow):
- 7:56 AM Changeset in webkit [142124] by
-
- 2 edits in trunk/Source/WebCore
Remove #if USE(V8) from IDBRequest.h
https://bugs.webkit.org/show_bug.cgi?id=109163
Reviewed by Andreas Kling.
The header included inside the #if USE(V8) macro is not used.
We can simply remove it.
No tests. No change in behavior.
- Modules/indexeddb/IDBRequest.h:
- 7:53 AM Changeset in webkit [142123] by
-
- 3 edits in trunk/Source/WebCore
GraphicsContext::drawImageBuffer is inefficient
https://bugs.webkit.org/show_bug.cgi?id=104367
Reviewed by Dirk Schulze.
This patch converts all of the drawImage and drawImageBuffer
convenience methods (those that take parameters of various types) to
invoke the implementing method (that takes FloatRect src and dest)
directly, rather than through the next-most-convenient method as was
done previously. This will knock some layers off the stack compared
to the existing code, and may remove one or two constructor invocations.
This may be slightly more efficient, and also makes debugging simpler.
Also removes the unused drawImage method that takes and IntRect source
area and IntRect destination. It is not invoked anywhere in a standard
WebKit checkout.
No new tests. No change in functionality, just refactoring.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage): Modify all the convenience versions to call
the implementing version directly.
(WebCore::GraphicsContext::drawImageBuffer): Modify all the convenience versions
to call the implementing version directly.
- platform/graphics/GraphicsContext.h:
(GraphicsContext): Remove IntRect, IntRect version of drawImage.
- 7:46 AM Changeset in webkit [142122] by
-
- 3 edits2 adds in trunk
Conversion from localized numbers to HTML numbers should accept not only localized numbers but also HTML numbers
https://bugs.webkit.org/show_bug.cgi?id=109160
Reviewed by Kentaro Hara.
Source/WebCore:
For example, A French user needs to specify a number to a number input
field. He might use a local decimal point, like 3,141592, or he might
use the standard decimal point like 3.141592. We had better accept both
of them.
We accepted both last year, but we changed the behavior so that we
accept only localized numbers because we had some cases where an input
string can be recognized as both of a localized number and the standard
number. e.g. 3.141 is 3141 in French locale and 3.141 in the
standard. Now we introduce a simple rule that we don't accept group
separator at all. So users won't confuse even if we accept both of
decimal points.
Test: fast/forms/number/number-l10n-input.html
- platform/text/PlatformLocale.cpp:
(WebCore::Locale::convertFromLocalizedNumber):
If the specified string contains invalid characters including group
separators, just return the specified string.
LayoutTests:
- fast/forms/number/number-l10n-input-expected.txt: Added.
- fast/forms/number/number-l10n-input.html: Added.
- 7:35 AM Changeset in webkit [142121] by
-
- 2 edits in trunk/Tools
[EFL] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=109188
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/config.json: Add the
efl-linux-perf-1 slave (a 64-bit Release WK2 Perf bot), and make
the "EFL Linux 64-bit Release" bot trigger it.
- 7:24 AM Changeset in webkit [142120] by
-
- 11 edits in trunk
[BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
https://bugs.webkit.org/show_bug.cgi?id=109126
PR 292540
Source/WebCore:
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
Change char code to 4 bytes.
Need to convert UTF32 key char to UTF16 before constructing a WTF::String.
- platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
(PlatformKeyboardEvent):
- platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Source/WebKit/blackberry:
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.
Key char is UTF32 encoded, should be 4 bytes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::handleScrolling):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- WebKitSupport/InputHandler.h:
(InputHandler):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
Tools:
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
Change char code to 4 bytes.
- DumpRenderTree/blackberry/EventSender.cpp:
(keyDownCallback):
- 7:21 AM Changeset in webkit [142119] by
-
- 8 edits4 adds in trunk/LayoutTests
[chromium] New baselines for GPU-accelerated reference filters tests. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=104289
- platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png:
- platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
- platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png:
- platform/chromium/TestExpectations:
- 7:14 AM Changeset in webkit [142118] by
-
- 35 edits in trunk/Source/WebCore
Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044
Reviewed by Darin Adler.
The pattern:
ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);
is more clearly and succinctly written as:
methodThatGeneratesException(ASSERT_NO_EXCEPTION);
This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.
No change in behavior should result from this refactoring.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
- dom/Document.cpp:
(WebCore::Document::setTitle):
- dom/MessagePort.cpp:
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
- editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
(WebCore::DeleteButtonController::show):
Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
- editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doUnapply):
- editing/TextIterator.cpp:
(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):
- editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
- editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::getCookies):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::addRule):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::dispatchDOMEvent):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
- page/DragController.cpp:
(WebCore::prepareClipboardForImageDrag):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::visiblePositionForIndex):
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):
- svg/SVGAnimatedLength.cpp:
(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
- svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::textLengthAnimated):
- svg/animation/SVGSMILElement.cpp:
(WebCore::constructQualifiedName):
Replaced inline ASSERT with ASSERT_NO_EXCEPTION.
- 7:08 AM Changeset in webkit [142117] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
https://bugs.webkit.org/show_bug.cgi?id=109124
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
RIM BUG 291246 Internally reviewed by YongLi.
Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
into WebPageClientImpl::createWindow() to make it more close to its protecting place.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
- 7:07 AM Changeset in webkit [142116] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Send type details with IMF mask as part of focus gained.
https://bugs.webkit.org/show_bug.cgi?id=109086
Reviewed by Yong Li.
PR 292609.
Add masking options based on VKB type to the IMF mask.
Reviewed Internally by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::addInputStyleMaskForKeyboardType):
(WebKit):
(BlackBerry::WebKit::InputHandler::setElementFocused):
- 7:05 AM Changeset in webkit [142115] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Export mimeType in NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=109002
Reviewed by Yong Li.
NetworkJob will analysize resource mimetype and set it to resourceResponse,
we will pass it on to be used by other Streams like download stream.
RIM bug# 284408, internally reviewed by Liam Quinn.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::mimeType):
(WebCore):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- 7:00 AM Changeset in webkit [142114] by
-
- 20 edits3 adds in trunk
Web Inspector: support JavaScript variable mutation in protocol and V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=107829
Source/WebCore:
A new command is added to protocol description and the call is passed through
debugger agent through injected script and debugger script down to V8 mirror
API. JSC bindings got a thorw exception stub.
Only declarative JavaScript scopes are supported (local, closure, catch). Other
scopes (global, with) are not supported by V8 and not supported by protocol, because
manual approach (direct property assigment) is available for them in form of evaluate
commands and is more desirable because of a complex nature of operation (it can throw
exception in several cases such as exception in setter function).
Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.
Test: inspector-protocol/debugger-setVariableValue.html
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
(WebCore):
- bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::setVariableValue):
(WebCore):
- bindings/v8/DebuggerScript.js:
(.):
- bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::setVariableValue):
(WebCore):
- bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setFunctionVariableValue):
(WebCore):
- bindings/v8/ScriptDebugServer.h:
(ScriptDebugServer):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallback):
(WebCore):
- bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::setVariableValueCallback):
(WebCore):
- inspector/InjectedScript.cpp:
(WebCore::InjectedScript::setVariableValue):
(WebCore):
- inspector/InjectedScript.h:
(InjectedScript):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::setVariableValue):
(WebCore):
- inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
- inspector/JavaScriptCallFrame.idl:
LayoutTests:
Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.
- inspector-protocol/debugger-setVariableValue-expected.txt: Added.
- inspector-protocol/debugger-setVariableValue.html: Added.
- inspector/console/command-line-api-expected.txt:
- platform/chromium/inspector-protocol/debugger-setVariableValue-expected.txt: Added.
- 6:56 AM Changeset in webkit [142113] by
-
- 5 edits in trunk/LayoutTests
Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146
Reviewed by Pavel Feldman.
Fix layout tests that started failing after r142081.
- inspector/profiler/memory-instrumentation-cached-images-expected.txt:
- inspector/profiler/memory-instrumentation-cached-images.html:
- inspector/profiler/memory-instrumentation-canvas-expected.txt:
- inspector/profiler/memory-instrumentation-canvas.html:
- 6:47 AM Changeset in webkit [142112] by
-
- 12 edits4 adds in trunk
[CoordinatedGraphics] Use ScrollingCoordinator to track fixed layers
https://bugs.webkit.org/show_bug.cgi?id=108990
.:
Reviewed by Noam Rosenthal.
Add a new test that allow us to remove the fixed positioning of a layer but still keeping
it compositing. Coordinated Graphics had a bug where the CoordinatedSceneGraph would still
count this layer as fixed position.
- ManualTests/remove-fixed-position-but-keep-compositing.html: Added.
Source/WebCore:
Reviewed by Noam Rosenthal.
WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.
The function ScrollingCoordinator::setLayerIsFixedToContainerLayer() is called when
RenderLayerBacking is updating its graphics layers.
The new code also works in new situations where the previous was broken: if a layer changed
from being fixed to not fixed (but still kept as a layer for other reasons), the layer will
be correctly updated. Previous implementation only had logic to mark layers as fixed, but
not the other way round. A manual test was added to illustrate the solved problem.
Testing was done with the existing manual tests that make use of "position:fixed". Automatic
tests are mostly not affected by this because usage of this information affects only the
UseFixedLayout mode, not used by default in WebKitTestRunner. Work to improve this situation
will be tracked in bug https://bugs.webkit.org/show_bug.cgi?id=109175.
- CMakeLists.txt:
- Target.pri:
- WebCore.pri:
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create): create specific version of ScrollingCoordinator.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):
update layer information using existing hook in ScrollingCoordinator.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.
(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport): now that setting viewport is not
embedded in the synchronization work, we need to mark the layer so it is updated in the
next frame.
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): remove call to syncFixedLayers().
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient): remove now unused syncFixedLayers() from client.
(CoordinatedGraphicsLayer):
Source/WebKit2:
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.
WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp: remove
syncFixedLayers() and its helper functions. Those were used to identify the fixed layers
and are not needed anymore.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): enable the scrolling coordinator usage for
Coordinated Graphics.
- 6:42 AM Changeset in webkit [142111] by
-
- 5 edits6 adds in trunk
Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136
Reviewed by Kent Tamura.
Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.
Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html
- Resources/pagepopups/calendarPicker.css:
(.today-clear-area):
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.
LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055
Reviewed by Kent Tamura.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
- platform/chromium/TestExpectations:
- 6:32 AM Changeset in webkit [142110] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test.
- platform/qt/TestExpectations:
- 6:20 AM Changeset in webkit [142109] by
-
- 31 edits3 deletes in trunk/Tools
Unreviewed, rolling out r142090.
http://trac.webkit.org/changeset/142090
https://bugs.webkit.org/show_bug.cgi?id=108466
lots of selection expectations failures
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
(WebTaskList):
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(MockGrammarCheck::checkGrammarOfString):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- 6:14 AM Changeset in webkit [142108] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix. libWebCore.la needs to be relinked when
symbols.filter changes.
- GNUmakefile.am: add symbols.filter as a dependency for the
libWebCore.la library.
- 5:56 AM Changeset in webkit [142107] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Closure compilation fixes
https://bugs.webkit.org/show_bug.cgi?id=109131
Reviewed by Yury Semikhatsky.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):
- inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):
- inspector/front-end/SidebarPane.js:
- 5:51 AM Changeset in webkit [142106] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviwed gardening. Rebaselining and skipping new failures.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-07
- platform/qt/TestExpectations:
- platform/qt/fast/dynamic/002-expected.txt:
- platform/qt/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
- platform/qt/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
- 5:48 AM Changeset in webkit [142105] by
-
- 2 edits in trunk
Unreviewed build fix after r141196 for 32 bits autotools.
- Source/autotools/symbols.filter: restore 32 bits version of the
WebCore::TextIterator::getLocationAndLengthFromRange(WebCore::Node*,
WebCore::Range const*, unsigned int&, unsigned int&) symbol.
- 5:47 AM Changeset in webkit [142104] by
-
- 1 edit30 adds in trunk/LayoutTests
Add WebGL Conformance Tests state, renderbuffers, and reading folders.
https://bugs.webkit.org/show_bug.cgi?id=109121
Reviewed by Kenneth Russell.
- webgl/conformance/reading/read-pixels-pack-alignment-expected.txt: Added.
- webgl/conformance/reading/read-pixels-pack-alignment.html: Added.
- webgl/conformance/renderbuffers/framebuffer-state-restoration-expected.txt: Added.
- webgl/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
- webgl/conformance/renderbuffers/framebuffer-test-expected.txt: Added.
- webgl/conformance/renderbuffers/framebuffer-test.html: Added.
- webgl/conformance/renderbuffers/renderbuffer-initialization-expected.txt: Added.
- webgl/conformance/renderbuffers/renderbuffer-initialization.html: Added.
- webgl/conformance/state/gl-enable-enum-test-expected.txt: Added.
- webgl/conformance/state/gl-enable-enum-test.html: Added.
- webgl/conformance/state/gl-enum-tests-expected.txt: Added.
- webgl/conformance/state/gl-enum-tests.html: Added.
- webgl/conformance/state/gl-get-calls-expected.txt: Added.
- webgl/conformance/state/gl-get-calls.html: Added.
- webgl/conformance/state/gl-geterror-expected.txt: Added.
- webgl/conformance/state/gl-geterror.html: Added.
- webgl/conformance/state/gl-getstring-expected.txt: Added.
- webgl/conformance/state/gl-getstring.html: Added.
- webgl/resources/webgl_test_files/conformance/reading/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/reading/read-pixels-pack-alignment.html: Added.
- webgl/resources/webgl_test_files/conformance/renderbuffers/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
- webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-test.html: Added.
- webgl/resources/webgl_test_files/conformance/renderbuffers/renderbuffer-initialization.html: Added.
- webgl/resources/webgl_test_files/conformance/state/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-enable-enum-test.html: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-enum-tests.html: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-get-calls.html: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-geterror.html: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-getstring.html: Added.
- 5:37 AM Changeset in webkit [142103] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r142077.
http://trac.webkit.org/changeset/142077
https://bugs.webkit.org/show_bug.cgi?id=108579
fast/filesystem/workers/file-writer-empty-blob.html is broken
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8GCController.cpp:
(WebCore::WrapperVisitor::WrapperVisitor):
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 5:36 AM Changeset in webkit [142102] by
-
- 1 edit29 adds in trunk/LayoutTests
Add WebGL Conformance Tests rendering folder.
https://bugs.webkit.org/show_bug.cgi?id=109122
Reviewed by Kenneth Russell.
- webgl/conformance/rendering/culling-expected.txt: Added.
- webgl/conformance/rendering/culling.html: Added.
- webgl/conformance/rendering/draw-arrays-out-of-bounds-expected.txt: Added.
- webgl/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
- webgl/conformance/rendering/draw-elements-out-of-bounds-expected.txt: Added.
- webgl/conformance/rendering/draw-elements-out-of-bounds.html: Added.
- webgl/conformance/rendering/gl-clear-expected.txt: Added.
- webgl/conformance/rendering/gl-clear.html: Added.
- webgl/conformance/rendering/gl-drawelements-expected.txt: Added.
- webgl/conformance/rendering/gl-drawelements.html: Added.
- webgl/conformance/rendering/gl-scissor-fbo-test-expected.txt: Added.
- webgl/conformance/rendering/gl-scissor-fbo-test.html: Added.
- webgl/conformance/rendering/line-loop-tri-fan-expected.txt: Added.
- webgl/conformance/rendering/line-loop-tri-fan.html: Added.
- webgl/conformance/rendering/simple-expected.txt: Added.
- webgl/conformance/rendering/simple.html: Added.
- webgl/conformance/rendering/triangle-expected.txt: Added.
- webgl/conformance/rendering/triangle.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/rendering/culling.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/draw-elements-out-of-bounds.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/gl-clear.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/gl-drawelements.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-fbo-test.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/line-loop-tri-fan.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/simple.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/triangle.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/vertex-texture-fetch.html: Added.
- 5:20 AM Changeset in webkit [142101] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled DEPS.
- DEPS:
- 5:05 AM Changeset in webkit [142100] by
-
- 1 edit25 adds in trunk/LayoutTests
Add WebGL Conformance Tests programs folder.
https://bugs.webkit.org/show_bug.cgi?id=109120
Reviewed by Kenneth Russell.
- webgl/conformance/programs/get-active-test-expected.txt: Added.
- webgl/conformance/programs/get-active-test.html: Added.
- webgl/conformance/programs/gl-bind-attrib-location-test-expected.txt: Added.
- webgl/conformance/programs/gl-bind-attrib-location-test.html: Added.
- webgl/conformance/programs/gl-get-active-attribute-expected.txt: Added.
- webgl/conformance/programs/gl-get-active-attribute.html: Added.
- webgl/conformance/programs/gl-get-active-uniform-expected.txt: Added.
- webgl/conformance/programs/gl-get-active-uniform.html: Added.
- webgl/conformance/programs/gl-getshadersource-expected.txt: Added.
- webgl/conformance/programs/gl-getshadersource.html: Added.
- webgl/conformance/programs/gl-shader-test-expected.txt: Added.
- webgl/conformance/programs/gl-shader-test.html: Added.
- webgl/conformance/programs/invalid-UTF-16-expected.txt: Added.
- webgl/conformance/programs/invalid-UTF-16.html: Added.
- webgl/conformance/programs/use-program-crash-with-discard-in-fragment-shader-expected.txt: Added.
- webgl/conformance/programs/use-program-crash-with-discard-in-fragment-shader.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/programs/get-active-test.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-test.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-get-active-attribute.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-get-active-uniform.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-getshadersource.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-shader-test.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/invalid-UTF-16.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/use-program-crash-with-discard-in-fragment-shader.html: Added.
- 5:01 AM Changeset in webkit [142099] by
-
- 9 edits in trunk/Source/WebCore
Call XSSAuditor.filterToken() from threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=107603
Reviewed by Adam Barth.
With this patch we now pass 180 of 182 tests in http/tests/security/xssAuditor.
We do this by creating aan XSSAuditor on the main thread and passing ownership of them to the BackgroundHTMLParser upon its creation.
Then the background thread calls filterToken() and stores the resulting XSSInfo (if any) on the CompactHTMLToken for the main thread to handle.
This involved trimming the XSSAuditor to only depend on the TextEncoding instead of the whole TextResourceDecoder.
No new tests because covered by existing tests.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::createPartial):
- html/parser/BackgroundHTMLParser.h:
(WebCore):
(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::startBackgroundParser):
- html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::end):
- html/parser/HTMLSourceTracker.h: Change the HTMLInputStream args to SegmentedString because the background thread only has a BackgroundHTMLInputStream.
(HTMLSourceTracker):
- html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::pumpTokenizer):
- html/parser/XSSAuditor.cpp:
(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init): Copies necessary to make isSafeToSendToAnotherThread() happy.
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
(WebCore::XSSAuditor::isSafeToSendToAnotherThread): Check that all String and KURL members are safe to send to another thread.
(WebCore):
- html/parser/XSSAuditor.h:
(WebCore):
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):
- 4:57 AM Changeset in webkit [142098] by
-
- 1 edit38 adds in trunk/LayoutTests
Add WebGL Conformance Tests context folder.
https://bugs.webkit.org/show_bug.cgi?id=109114
Reviewed by Kenneth Russell.
- webgl/conformance/context/constants-expected.txt: Added.
- webgl/conformance/context/constants.html: Added.
- webgl/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
- webgl/conformance/context/context-attributes-alpha-depth-stencil-antialias.html: Added.
- webgl/conformance/context/context-lost-expected.txt: Added.
- webgl/conformance/context/context-lost-restored-expected.txt: Added.
- webgl/conformance/context/context-lost-restored.html: Added.
- webgl/conformance/context/context-lost.html: Added.
- webgl/conformance/context/context-release-upon-reload-expected.txt: Added.
- webgl/conformance/context/context-release-upon-reload.html: Added.
- webgl/conformance/context/context-release-with-workers-expected.txt: Added.
- webgl/conformance/context/context-release-with-workers.html: Added.
- webgl/conformance/context/context-type-test-expected.txt: Added.
- webgl/conformance/context/context-type-test.html: Added.
- webgl/conformance/context/incorrect-context-object-behaviour-expected.txt: Added.
- webgl/conformance/context/incorrect-context-object-behaviour.html: Added.
- webgl/conformance/context/methods-expected.txt: Added.
- webgl/conformance/context/methods.html: Added.
- webgl/conformance/context/premultiplyalpha-test-expected.txt: Added.
- webgl/conformance/context/premultiplyalpha-test.html: Added.
- webgl/conformance/context/resource-sharing-test-expected.txt: Added.
- webgl/conformance/context/resource-sharing-test.html: Added.
- webgl/resources/webgl_test_files/conformance/context/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/context/constants.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-attributes-alpha-depth-stencil-antialias.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-lost-restored.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-lost.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-release-upon-reload.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-release-with-workers.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-type-test.html: Added.
- webgl/resources/webgl_test_files/conformance/context/incorrect-context-object-behaviour.html: Added.
- webgl/resources/webgl_test_files/conformance/context/methods.html: Added.
- webgl/resources/webgl_test_files/conformance/context/premultiplyalpha-test.html: Added.
- webgl/resources/webgl_test_files/conformance/context/resource-sharing-test.html: Added.
- webgl/resources/webgl_test_files/conformance/context/resources/context-release-child-with-worker.html: Added.
- webgl/resources/webgl_test_files/conformance/context/resources/context-release-upon-reload-child.html: Added.
- webgl/resources/webgl_test_files/conformance/context/resources/context-release-worker.js: Added.
- 4:43 AM Changeset in webkit [142097] by
-
- 1 edit17 adds in trunk/LayoutTests
Add WebGL Conformance Tests uniforms folder.
https://bugs.webkit.org/show_bug.cgi?id=109112
Reviewed by Kenneth Russell.
- webgl/conformance/uniforms/gl-uniform-bool-expected.txt: Added.
- webgl/conformance/uniforms/gl-uniform-bool.html: Added.
- webgl/conformance/uniforms/gl-uniformmatrix4fv-expected.txt: Added.
- webgl/conformance/uniforms/gl-uniformmatrix4fv.html: Added.
- webgl/conformance/uniforms/gl-unknown-uniform-expected.txt: Added.
- webgl/conformance/uniforms/gl-unknown-uniform.html: Added.
- webgl/conformance/uniforms/null-uniform-location-expected.txt: Added.
- webgl/conformance/uniforms/null-uniform-location.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-bool.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-packing-restrictions.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-struct-unused.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-unused-array-elements-get-truncated.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniformmatrix4fv.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-unknown-uniform.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/null-uniform-location.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/out-of-bounds-uniform-array-access.html: Added.
- 4:39 AM Changeset in webkit [142096] by
-
- 1 edit22 adds in trunk/LayoutTests
Add WebGL Conformance Tests canvas folder.
https://bugs.webkit.org/show_bug.cgi?id=109113
Reviewed by Kenneth Russell.
- webgl/conformance/canvas/canvas-test-expected.txt: Added.
- webgl/conformance/canvas/canvas-test.html: Added.
- webgl/conformance/canvas/canvas-zero-size-expected.txt: Added.
- webgl/conformance/canvas/canvas-zero-size.html: Added.
- webgl/conformance/canvas/drawingbuffer-hd-dpi-test-expected.txt: Added.
- webgl/conformance/canvas/drawingbuffer-hd-dpi-test.html: Added.
- webgl/conformance/canvas/drawingbuffer-static-canvas-test-expected.txt: Added.
- webgl/conformance/canvas/drawingbuffer-static-canvas-test.html: Added.
- webgl/conformance/canvas/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
- webgl/conformance/canvas/framebuffer-bindings-unaffected-on-resize.html: Added.
- webgl/conformance/canvas/texture-bindings-unaffected-on-resize-expected.txt: Added.
- webgl/conformance/canvas/texture-bindings-unaffected-on-resize.html: Added.
- webgl/conformance/canvas/viewport-unchanged-upon-resize-expected.txt: Added.
- webgl/conformance/canvas/viewport-unchanged-upon-resize.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/canvas/canvas-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/canvas-zero-size.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-hd-dpi-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-static-canvas-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/framebuffer-bindings-unaffected-on-resize.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/texture-bindings-unaffected-on-resize.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/viewport-unchanged-upon-resize.html: Added.
- 4:34 AM Changeset in webkit [142095] by
-
- 6 edits2 deletes in trunk/Source/WebKit2
[Qt][WK2] Fold QtWebPageLoadClient into QQuickWebViewPrivate and move to C API.
https://bugs.webkit.org/show_bug.cgi?id=108473
Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.
This patch removes the QtWebPageLoadClient and moves the functionality into the
QQuickWebViewPrivate as most callback methods are calling the private webview
indirectly anyway.
The patch also moves as much of the functionality to the C API as is possible with
the current C API.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didStartProvisionalLoadForFrame):
(QQuickWebViewPrivate::didReceiveServerRedirectForProvisionalLoadForFrame):
(QQuickWebViewPrivate::didFailLoad):
(QQuickWebViewPrivate::didCommitLoadForFrame):
(QQuickWebViewPrivate::didFinishLoadForFrame):
(QQuickWebViewPrivate::didSameDocumentNavigationForFrame):
(QQuickWebViewPrivate::didReceiveTitleForFrame):
(QQuickWebViewPrivate::didStartProgress):
(QQuickWebViewPrivate::didChangeProgress):
(QQuickWebViewPrivate::didFinishProgress):
(QQuickWebViewPrivate::didChangeBackForwardList):
(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewPrivate::loadProgressDidChange):
- UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
- UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate):
- UIProcess/qt/QtWebError.cpp:
(WebKit::QtWebError::url):
- UIProcess/qt/QtWebPageLoadClient.cpp: Removed.
- UIProcess/qt/QtWebPageLoadClient.h: Removed.
- 4:21 AM Changeset in webkit [142094] by
-
- 8 edits2 adds in trunk/Source
[GTK][AC] Implement opacity animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=108961
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-07
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Implement opacity animation with clutter ac backend.
Almost all implementations of GraphicsLayerClutter are based on mac port's one.
PlatformClutterAnimation interfaces are also similar with mac port, but they are implemented
with native clutter APIs.
This patch includes only opacity animation related changes, so many APIs might be empty.
Remained animations like rotation and translate will be dealt in another patches.
Covered by existing animation tests.
- GNUmakefile.list.am:
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorGetAnimationForKey):
- platform/graphics/clutter/GraphicsLayerActor.h:
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore):
(WebCore::propertyIdToString):
(WebCore::animationIdentifier):
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::setOpacity):
(WebCore::GraphicsLayerClutter::updateAnimations):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupAnimation):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::createBasicAnimation):
(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::createAnimationFromKeyframes):
(WebCore::GraphicsLayerClutter::addAnimation):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):
(WebCore::GraphicsLayerClutter::pauseClutterAnimationOnLayer):
(WebCore::GraphicsLayerClutter::setAnimationOnLayer):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
(WebCore::GraphicsLayerClutter::animatedLayer):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::LayerPropertyAnimation::LayerPropertyAnimation):
(LayerPropertyAnimation):
(WebCore::GraphicsLayerClutter::AnimationProcessingAction::AnimationProcessingAction):
(AnimationProcessingAction):
- platform/graphics/clutter/PlatformClutterAnimation.cpp: Added.
(WebCore):
(WebCore::timelineStartedCallback):
(WebCore::toClutterAnimationMode):
(WebCore::PlatformClutterAnimation::stringToAnimatedPropertyType):
(WebCore::PlatformClutterAnimation::create):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::~PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::beginTime):
(WebCore::PlatformClutterAnimation::setBeginTime):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::speed):
(WebCore::PlatformClutterAnimation::setSpeed):
(WebCore::PlatformClutterAnimation::timeOffset):
(WebCore::PlatformClutterAnimation::setTimeOffset):
(WebCore::PlatformClutterAnimation::repeatCount):
(WebCore::PlatformClutterAnimation::setRepeatCount):
(WebCore::PlatformClutterAnimation::autoreverses):
(WebCore::PlatformClutterAnimation::setAutoreverses):
(WebCore::PlatformClutterAnimation::fillMode):
(WebCore::PlatformClutterAnimation::setFillMode):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::copyTimingFunctionFrom):
(WebCore::PlatformClutterAnimation::isRemovedOnCompletion):
(WebCore::PlatformClutterAnimation::setRemovedOnCompletion):
(WebCore::PlatformClutterAnimation::isAdditive):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::copyFromValueFrom):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::copyToValueFrom):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::copyValuesFrom):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::copyKeyTimesFrom):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::copyTimingFunctionsFrom):
(WebCore::PlatformClutterAnimation::animationDidStart):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):
- platform/graphics/clutter/PlatformClutterAnimation.h: Added.
(WebCore):
(PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::animationType):
Source/WebKit/gtk:
Add AnimationTrigger for ac compositing.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::allowedCompositingTriggers):
- 4:18 AM Changeset in webkit [142093] by
-
- 3 edits in trunk/Source/WebKit/chromium
Add null check to editable in moveCaretSelectionTowardsWindowPoint
https://bugs.webkit.org/show_bug.cgi?id=108962
Patch by David Trainor <dtrainor@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
- tests/WebFrameTest.cpp:
- 3:57 AM Changeset in webkit [142092] by
-
- 1 edit85 adds in trunk/LayoutTests
Add WebGL Conformance Tests texture folder.
https://bugs.webkit.org/show_bug.cgi?id=109111
Reviewed by Kenneth Russell.
- webgl/conformance/textures/compressed-tex-image-expected.txt: Added.
- webgl/conformance/textures/compressed-tex-image.html: Added.
- webgl/conformance/textures/copy-tex-image-and-sub-image-2d-expected.txt: Added.
- webgl/conformance/textures/copy-tex-image-and-sub-image-2d.html: Added.
- webgl/conformance/textures/gl-get-tex-parameter-expected.txt: Added.
- webgl/conformance/textures/gl-get-tex-parameter.html: Added.
- webgl/conformance/textures/gl-teximage-expected.txt: Added.
- webgl/conformance/textures/gl-teximage.html: Added.
- webgl/conformance/textures/mipmap-fbo-expected.txt: Added.
- webgl/conformance/textures/mipmap-fbo.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html: Added.
- webgl/conformance/textures/tex-image-and-uniform-binding-bugs-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-uniform-binding-bugs.html: Added.
- webgl/conformance/textures/tex-image-webgl-expected.txt: Added.
- webgl/conformance/textures/tex-image-webgl.html: Added.
- webgl/conformance/textures/tex-image-with-format-and-type-expected.txt: Added.
- webgl/conformance/textures/tex-image-with-format-and-type.html: Added.
- webgl/conformance/textures/tex-image-with-invalid-data-expected.txt: Added.
- webgl/conformance/textures/tex-image-with-invalid-data.html: Added.
- webgl/conformance/textures/tex-input-validation-expected.txt: Added.
- webgl/conformance/textures/tex-input-validation.html: Added.
- webgl/conformance/textures/tex-sub-image-2d-bad-args-expected.txt: Added.
- webgl/conformance/textures/tex-sub-image-2d-bad-args.html: Added.
- webgl/conformance/textures/tex-sub-image-2d-expected.txt: Added.
- webgl/conformance/textures/tex-sub-image-2d.html: Added.
- webgl/conformance/textures/texparameter-test-expected.txt: Added.
- webgl/conformance/textures/texparameter-test.html: Added.
- webgl/conformance/textures/texture-attachment-formats-expected.txt: Added.
- webgl/conformance/textures/texture-attachment-formats.html: Added.
- webgl/conformance/textures/texture-clear-expected.txt: Added.
- webgl/conformance/textures/texture-clear.html: Added.
- webgl/conformance/textures/texture-complete-expected.txt: Added.
- webgl/conformance/textures/texture-complete.html: Added.
- webgl/conformance/textures/texture-formats-test-expected.txt: Added.
- webgl/conformance/textures/texture-formats-test.html: Added.
- webgl/conformance/textures/texture-hd-dpi-expected.txt: Added.
- webgl/conformance/textures/texture-hd-dpi.html: Added.
- webgl/conformance/textures/texture-npot-expected.txt: Added.
- webgl/conformance/textures/texture-npot.html: Added.
- webgl/conformance/textures/texture-size-cube-maps-expected.txt: Added.
- webgl/conformance/textures/texture-size-cube-maps.html: Added.
- webgl/conformance/textures/texture-sub-image-cube-maps-expected.txt: Added.
- webgl/conformance/textures/texture-sub-image-cube-maps.html: Added.
- webgl/conformance/textures/texture-transparent-pixels-initialized-expected.txt: Added.
- webgl/conformance/textures/texture-transparent-pixels-initialized.html: Added.
- webgl/conformance/textures/texture-upload-cube-maps-expected.txt: Added.
- webgl/conformance/textures/texture-upload-cube-maps.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/textures/compressed-tex-image.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-and-sub-image-2d.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/gl-get-tex-parameter.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/gl-teximage.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/mipmap-fbo.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-uniform-binding-bugs.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-webgl.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-with-format-and-type.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-with-invalid-data.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-input-validation.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-sub-image-2d-bad-args.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-sub-image-2d.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texparameter-test.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-attachment-formats.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-clear.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-complete.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-formats-test.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-hd-dpi.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-npot.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-size-cube-maps.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-sub-image-cube-maps.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-transparent-pixels-initialized.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-upload-cube-maps.html: Added.
- 3:51 AM Changeset in webkit [142091] by
-
- 8 edits2 adds in trunk
Web Inspector: highlight matching braces in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108697
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.
Source/WebCore:
Implement BraceMatcher class which for given position in textModel
will respond with enclosing brace pair for that position.
Make use of this class in DefaultTextEditor by handling
selectionChange event. Make use of this class in "_closingBlockOffset"
method of TextEditorMainPanel as this method implements similar
functionality.
New test: inspector/editor/brace-matcher.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.BraceHighlightController):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):
- inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/textEditor.css:
(.text-editor-brace-match):
LayoutTests:
New layout test to verify brace matching functionality. Fix some
layout test expectations as the patch removes braces from highlight
ranges.
- inspector/editor/brace-matcher-expected.txt: Added.
- inspector/editor/brace-matcher.html: Added.
- inspector/editor/highlighter-basics-expected.txt:
- inspector/editor/text-editor-long-line-expected.txt:
- 3:46 AM Changeset in webkit [142090] by
-
- 31 edits3 copies in trunk/Tools
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466
Reviewed by Adam Barth.
To achieve this, we need to drop all dependencies on WTF.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- 3:21 AM Changeset in webkit [142089] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180752. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07
- DEPS:
- 3:02 AM Changeset in webkit [142088] by
-
- 8 edits in trunk
[Qt] Use GNU ar's thin archive format for intermediate static libs
https://bugs.webkit.org/show_bug.cgi?id=109052
Reviewed by Jocelyn Turcotte.
Source/JavaScriptCore:
Adjust project files that used activeBuildConfig()
to use targetSubDir().
- JavaScriptCore.pri:
- LLIntOffsetsExtractor.pro:
- Target.pri:
Tools:
With debug builds we exceed the 4GiB limit of GNU ar when creating the WebCore
intermediate static library which results in build failure even with a x86_64
toolchain (http://sourceware.org/bugzilla/show_bug.cgi?id=14625).
When using a GNU toolchain we can use the thin archive format for these static
libraries which also has the benefit of not copying the object files, thus
drastically reducing disk usage and overall compile time.
Currently qmake does not support GNU ar's thin archive format so for
now we need to do the magic in the build system as a stopgap solution.
- qmake/mkspecs/features/configure.prf:
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/functions.prf:
- 3:01 AM Changeset in webkit [142087] by
-
- 5 edits in trunk/Source
[EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=97173
Reviewed by Kenneth Rohde Christiansen, signed-off by Benjamin Poulain.
Source/WebCore:
Remove codes to initialize and shutdown the EFL libraries from
RunLoopEfl.cpp. Initialization and shutdown will be done in the
ewk_main.cpp for ui process and WebProcessMainEfl.cpp for web
process.
No new tests. This patch doesn't change behavior.
- platform/efl/RunLoopEfl.cpp:
(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):
Source/WebKit2:
Initialize and shutdown the EFL libraries in the ewk_main.cpp for
UIProcess and WebProcessMainEfl.cpp for WebProcess.
This allows us to shut down the libraries in a proper way, since
RunLoop persist until the process exits.
- UIProcess/API/efl/ewk_main.cpp:
(ewk_init):
(ewk_shutdown):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- 2:05 AM Changeset in webkit [142086] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed fix for inspector tests in debug.
m_frontend should be initialized in constructor.
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- 1:37 AM Changeset in webkit [142085] by
-
- 18 edits in branches/chromium/1364
Merge 140539
Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
https://bugs.webkit.org/show_bug.cgi?id=107523
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::isUnderTest):
(WebCore):
(WebCore::InspectorController::evaluateForTestInFrontend):
- inspector/InspectorController.h:
(InspectorController):
- inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::isUnderTest):
(WebCore):
- inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isUnderTest):
(WebCore):
- inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
- inspector/InspectorFrontendHost.idl:
- inspector/front-end/DOMExtension.js:
- inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
(.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest):
- inspector/front-end/TestController.js:
(.invokeMethod):
(WebInspector.evaluateForTestInFrontend):
- inspector/front-end/externs.js:
Source/WebKit/chromium:
- public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::isUnderTest):
(WebDevToolsFrontendClient):
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::isUnderTest):
- src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
Tools:
- DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::isUnderTest):
(DRTDevToolsClient::call):
- DumpRenderTree/chromium/DRTDevToolsClient.h:
(DRTDevToolsClient):
TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12224049
- 1:24 AM Changeset in webkit [142084] by
-
- 4 edits249 deletes in trunk/LayoutTests
Rollout r142058 various crashes and timeouts on AppleMac and Chromium
https://bugs.webkit.org/show_bug.cgi?id=109152
Reviewed by Pavel Feldman.
Unreviewed gardening. r142058 added failing tests and marked many as
Skip or Failure but there are also Timeouts and Crashes causing
redness.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Removed.
- webgl/conformance/canvas/buffer-offscreen-test.html: Removed.
- webgl/conformance/canvas/buffer-preserve-test-expected.txt: Removed.
- webgl/conformance/canvas/buffer-preserve-test.html: Removed.
- webgl/conformance/canvas/drawingbuffer-test-expected.txt: Removed.
- webgl/conformance/canvas/drawingbuffer-test.html: Removed.
- webgl/conformance/canvas/to-data-url-test-expected.txt: Removed.
- webgl/conformance/canvas/to-data-url-test.html: Removed.
- webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Removed.
- webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Removed.
- webgl/conformance/context/context-creation-and-destruction-expected.txt: Removed.
- webgl/conformance/context/context-creation-and-destruction.html: Removed.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Removed.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Removed.
- webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Removed.
- webgl/conformance/glsl/literals/float_literal.vert.html: Removed.
- webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Removed.
- webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Removed.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Removed.
- webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Removed.
- webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Removed.
- webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Removed.
- webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Removed.
- webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Removed.
- webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Removed.
- webgl/conformance/glsl/misc/shaders-with-varyings.html: Removed.
- webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Removed.
- webgl/conformance/glsl/variables/gl-pointcoord.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-A.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B1.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B2.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B3.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-B4.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-C.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Removed.
- webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Removed.
- webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/bufferDataBadArgs.html: Removed.
- webgl/conformance/more/functions/copyTexImage2D-expected.txt: Removed.
- webgl/conformance/more/functions/copyTexImage2D.html: Removed.
- webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Removed.
- webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Removed.
- webgl/conformance/more/functions/copyTexSubImage2D.html: Removed.
- webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Removed.
- webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/deleteBufferBadArgs.html: Removed.
- webgl/conformance/more/functions/drawArrays-expected.txt: Removed.
- webgl/conformance/more/functions/drawArrays.html: Removed.
- webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Removed.
- webgl/conformance/more/functions/drawArraysOutOfBounds.html: Removed.
- webgl/conformance/more/functions/drawElements-expected.txt: Removed.
- webgl/conformance/more/functions/drawElements.html: Removed.
- webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/drawElementsBadArgs.html: Removed.
- webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/readPixelsBadArgs.html: Removed.
- webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/texImage2DBadArgs.html: Removed.
- webgl/conformance/more/functions/texImage2DHTML-expected.txt: Removed.
- webgl/conformance/more/functions/texImage2DHTML.html: Removed.
- webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Removed.
- webgl/conformance/more/functions/texSubImage2DBadArgs.html: Removed.
- webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Removed.
- webgl/conformance/more/functions/texSubImage2DHTML.html: Removed.
- webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Removed.
- webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Removed.
- webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Removed.
- webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Removed.
- webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Removed.
- webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Removed.
- webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Removed.
- webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Removed.
- webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Removed.
- webgl/conformance/ogles/GL/log/log_001_to_008.html: Removed.
- webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Removed.
- webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Removed.
- webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Removed.
- webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Removed.
- webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Removed.
- webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Removed.
- webgl/conformance/programs/program-test-expected.txt: Removed.
- webgl/conformance/programs/program-test.html: Removed.
- webgl/conformance/reading/read-pixels-test-expected.txt: Removed.
- webgl/conformance/reading/read-pixels-test.html: Removed.
- webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Removed.
- webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Removed.
- webgl/conformance/rendering/gl-scissor-test-expected.txt: Removed.
- webgl/conformance/rendering/gl-scissor-test.html: Removed.
- webgl/conformance/rendering/more-than-65536-indices-expected.txt: Removed.
- webgl/conformance/rendering/more-than-65536-indices.html: Removed.
- webgl/conformance/rendering/multisample-corruption-expected.txt: Removed.
- webgl/conformance/rendering/multisample-corruption.html: Removed.
- webgl/conformance/rendering/point-size-expected.txt: Removed.
- webgl/conformance/rendering/point-size.html: Removed.
- webgl/conformance/state/gl-object-get-calls-expected.txt: Removed.
- webgl/conformance/state/gl-object-get-calls.html: Removed.
- webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Removed.
- webgl/conformance/textures/copy-tex-image-2d-formats.html: Removed.
- webgl/conformance/textures/gl-pixelstorei-expected.txt: Removed.
- webgl/conformance/textures/gl-pixelstorei.html: Removed.
- webgl/conformance/textures/origin-clean-conformance-expected.txt: Removed.
- webgl/conformance/textures/origin-clean-conformance.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Removed.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Removed.
- webgl/conformance/textures/texture-active-bind-2-expected.txt: Removed.
- webgl/conformance/textures/texture-active-bind-2.html: Removed.
- webgl/conformance/textures/texture-active-bind-expected.txt: Removed.
- webgl/conformance/textures/texture-active-bind.html: Removed.
- webgl/conformance/textures/texture-mips-expected.txt: Removed.
- webgl/conformance/textures/texture-mips.html: Removed.
- webgl/conformance/textures/texture-npot-video-expected.txt: Removed.
- webgl/conformance/textures/texture-npot-video.html: Removed.
- webgl/conformance/textures/texture-size-expected.txt: Removed.
- webgl/conformance/textures/texture-size-limit-expected.txt: Removed.
- webgl/conformance/textures/texture-size-limit.html: Removed.
- webgl/conformance/textures/texture-size.html: Removed.
- webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Removed.
- webgl/conformance/uniforms/gl-uniform-arrays.html: Removed.
- webgl/conformance/uniforms/uniform-default-values-expected.txt: Removed.
- webgl/conformance/uniforms/uniform-default-values.html: Removed.
- webgl/conformance/uniforms/uniform-location-expected.txt: Removed.
- webgl/conformance/uniforms/uniform-location.html: Removed.
- webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Removed.
- webgl/conformance/uniforms/uniform-samplers-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Removed.
- webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Removed.
- webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Removed.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Removed.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Removed.
- webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/programs/program-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Removed.
- webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Removed.
- webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Removed.
- webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Removed.
- webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Removed.
- webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Removed.
- webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Removed.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Removed.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Removed.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Removed.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Removed.
- 1:11 AM Changeset in webkit [142083] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing WebGL tests.
- platform/qt/TestExpectations:
- 1:10 AM Changeset in webkit [142082] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix.
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::processDidClose):
m_process can't be initialized nullptr yet. Use 0 instead of nullptr.
- 1:09 AM Changeset in webkit [142081] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146
Reviewed by Pavel Feldman.
Merged some of memory instrumentation categories.
- dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
- platform/PlatformMemoryInstrumentation.cpp:
(WebCore):
- 1:03 AM Changeset in webkit [142080] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp
Merge 141772
Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831
Reviewed by Vsevolod Vlasov.
Otherwise, the ports that use page scale factor have broken overlay.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12217060
- 1:01 AM Changeset in webkit [142079] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r142067.
http://trac.webkit.org/changeset/142067
https://bugs.webkit.org/show_bug.cgi?id=109147
adding Slow modifier did not help completely (Requested by
falken on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07
- platform/chromium/TestExpectations:
- 12:59 AM Changeset in webkit [142078] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Expanding failure expectation for fast/dom/Window/slow-unload-handler.html.
Adding failure expectation for the new fast/css/negative-text-indent-in-inline-block.html
layout tests.
- platform/gtk/TestExpectations:
- 12:42 AM Changeset in webkit [142077] by
-
- 7 edits in trunk/Source/WebCore
[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579
Reviewed by Adam Barth.
Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.
Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).
Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.
Before:
mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms
After:
mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms
As shown above, I couldn't observe any performance regression.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 12:40 AM Changeset in webkit [142076] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132
Reviewed by Hajime Morita.
<input type=date> should be shown in Japanese UI as:
[ 年 /月/日]
But it is shown wrongly since r141195:
[年 /月/日]
We should use white-space:pre.
No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.
- css/html.css:
(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.
- 12:38 AM Changeset in webkit [142075] by
-
- 3 edits in trunk/Source/WebCore
Remove DOMWindow::parseModalDialogFeatures()
https://bugs.webkit.org/show_bug.cgi?id=109139
Reviewed by Kent Tamura.
No one uses the method. FIXME is saying:
FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.
Given that V8's showModalDialog() is now using DOMWindow, we can remove it.
No tests. No change in behavior.
- page/DOMWindow.cpp:
- page/DOMWindow.h:
(DOMWindow):
- 12:38 AM Changeset in webkit [142074] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: reduce native heap snapshot runtime memory footprint
https://bugs.webkit.org/show_bug.cgi?id=108824
Reviewed by Yury Semikhatsky.
New event was added into Memory domain addNativeSnapshotChunk.
The content of HeapGraphSerializer is completely rewritten according to new API.
Now it collects strings, nodes, edges and id2id map and pushes when the collected items count exceed a limit.
On the frontend side I added new method for the new event and fixed the postprocessing step.
MemoryInstrumentation was slightly changed. Now it reports base to real address map only after reporting the node with real address.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdateIfNeed):
(WebCore):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::reportBaseAddress):
(WebCore::HeapGraphSerializer::finish):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
(WebCore::HeapGraphSerializer::addString):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/Inspector.json:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::processMemoryDistribution):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionMap):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
(WebCore::InspectorMemoryAgent::setFrontend):
(WebCore::InspectorMemoryAgent::clearFrontend):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshot):
(WebInspector.NativeHeapSnapshotNode.prototype.classIndex):
(WebInspector.NativeHeapSnapshotNode.prototype.id):
(WebInspector.NativeHeapSnapshotNode.prototype.name):
(WebInspector.NativeHeapSnapshotNode.prototype.serialize):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileHeader):
(WebInspector.NativeSnapshotProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.NativeSnapshotProfileHeader.prototype.addNativeSnapshotChunk):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.MemoryDispatcher):
(WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk):
- 12:34 AM Changeset in webkit [142073] by
-
- 4 edits2 deletes in trunk/Source/WebKit2
[Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=108920
Reviewed by Jocelyn Turcotte, signed off for WK2 by Benjamin.
Employ the pattern suggested by Jocelyn to simply implement the C
callbacks directly using static functions.
- Target.pri:
- UIProcess/API/qt/qquickwebview.cpp:
(toQQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didFindString):
(QQuickWebViewPrivate::didFailToFindString):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- UIProcess/qt/QtWebPageFindClient.cpp: Removed.
- UIProcess/qt/QtWebPageFindClient.h: Removed.
- 12:30 AM Changeset in webkit [142072] by
-
- 18 edits5 adds in trunk
WebKit's focus events are UIEvents (instead of FocusEvent) and thus don't expose .relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=76216
Reviewed by Eric Seidel.
Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-FocusEvent
This patch creates a new FocusEvent class with a relatedTarget attribute.
Now when focusin or focusout events are dispatched, a FocusEvent is created with
the relatedTarget attribute set accordingly.
Source/WebCore:
Test: fast/events/related-target-focusevent.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMAllInOne.cpp:
- dom/Event.cpp:
(WebCore::Event::isFocusEvent):
(WebCore):
- dom/Event.h:
(Event):
- dom/EventContext.cpp:
(WebCore::EventContext::handleLocalEvents):
- dom/EventNames.in:
- dom/FocusEvent.h: Added.
(WebCore):
(FocusEvent):
(WebCore::FocusEvent::create):
(WebCore::FocusEvent::relatedTarget):
(WebCore::FocusEvent::setRelatedTarget):
(WebCore::toFocusEvent):
- dom/FocusEvent.idl: Added.
- dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
LayoutTests:
- fast/dom/shadow/shadow-boundary-events-expected.txt:
- fast/dom/shadow/shadow-boundary-events.html:
- fast/events/related-target-focusevent-expected.txt: Added.
- fast/events/related-target-focusevent.html: Added.
- 12:25 AM Changeset in webkit [142071] by
-
- 3 edits in trunk/Source/WebCore
Fix style of RenderTheme.cpp and RenderThemeChromiumWin.h
https://bugs.webkit.org/show_bug.cgi?id=109137
Reviewed by Kentaro Hara.
No new tests. Just style fix.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlStyled):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::systemColor):
- rendering/RenderThemeChromiumWin.h:
(WebCore::ThemeData::ThemeData):
(ThemeData):
(RenderThemeChromiumWin):
(WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
(WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
- 12:25 AM Changeset in webkit [142070] by
-
- 6 edits8 adds in trunk
[Qt] Compile WTF tests of TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=108935
Reviewed by Kenneth Rohde Christiansen.
.:
Build gtest on Linux.
- WebKit.pro:
Source/ThirdParty:
Add qmake build system .pro file for building gtest as static library.
- gtest/gtest.pro: Added.
Tools:
Add initial stubs and files for building at least the WTF tests.
The WK2 tests need more platform code, in particular PlatformWebView
and injected bundle support.
- TestWebKitAPI/TestWebKitAPI.pri: Added.
- TestWebKitAPI/TestWebKitAPI.pro: Added.
- TestWebKitAPI/Tests/WTF/WTF.pro: Added.
- TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
- TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Added.
(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
- TestWebKitAPI/qt/main.cpp: Added.
(main):
- Tools.pro:
- qmake/mkspecs/features/default_post.prf:
- 12:23 AM Changeset in webkit [142069] by
-
- 3 edits in trunk/Source/WebCore
Fix style of Chrome.h and Page.h
https://bugs.webkit.org/show_bug.cgi?id=109138
Reviewed by Ryosuke Niwa.
No new tests. Just style fixes.
- page/Chrome.h:
(WebCore):
(Chrome):
(WebCore::Chrome::client):
- page/Page.h:
(JSC):
(WebCore):
(WebCore::ArenaSize::ArenaSize):
(ArenaSize):
(Page):
(PageClients):
(WebCore::Page::theme):
(WebCore::Page::canStartMedia):
(WebCore::Page::editorClient):
(WebCore::Page::plugInClient):
(WebCore::Page::mainFrame):
(WebCore::Page::groupPtr):
(WebCore::Page::incrementSubframeCount):
(WebCore::Page::decrementSubframeCount):
(WebCore::Page::subframeCount):
(WebCore::Page::chrome):
(WebCore::Page::dragCaretController):
(WebCore::Page::dragController):
(WebCore::Page::focusController):
(WebCore::Page::contextMenuController):
(WebCore::Page::inspectorController):
(WebCore::Page::pointerLockController):
(WebCore::Page::validationMessageClient):
(WebCore::Page::settings):
(WebCore::Page::progress):
(WebCore::Page::backForward):
(WebCore::Page::featureObserver):
(WebCore::Page::viewMode):
(WebCore::Page::setTabKeyCyclesThroughElements):
(WebCore::Page::tabKeyCyclesThroughElements):
(WebCore::Page::scheduledRunLoopPairs):
(WebCore::Page::defersLoading):
(WebCore::Page::mediaVolume):
(WebCore::Page::pageScaleFactor):
(WebCore::Page::deviceScaleFactor):
(WebCore::Page::shouldSuppressScrollbarAnimations):
(WebCore::Page::pagination):
(WebCore::Page::isOnscreen):
(WebCore::Page::scriptedAnimationsSuspended):
(WebCore::Page::debugger):
(WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
(WebCore::Page::customHTMLTokenizerTimeDelay):
(WebCore::Page::hasCustomHTMLTokenizerChunkSize):
(WebCore::Page::customHTMLTokenizerChunkSize):
(WebCore::Page::areMemoryCacheClientCallsEnabled):
(WebCore::Page::setEditable):
(WebCore::Page::isEditable):
(WebCore::Page::displayID):
(WebCore::Page::layoutMilestones):
(WebCore::Page::setIsPainting):
(WebCore::Page::isPainting):
(WebCore::Page::alternativeTextClient):
(WebCore::Page::checkSubframeCountConsistency):
(WebCore::Page::group):
Feb 6, 2013:
- 11:41 PM Changeset in webkit [142068] by
-
- 3 edits9 adds in trunk
Entity-header extension headers honored on 304 responses.
https://bugs.webkit.org/show_bug.cgi?id=72414
Reviewed by Alexey Proskuryakov.
Source/WebCore:
This patch ports Chromium's network stack logic governing header
updates after resource revalidation. Generally, headers sent with 304
responses ought to update the original cached resource's headers.
Certain headers should never be sent with 304 responses, and we should
ignore them if a misconfigured server sends them anyway.
Currently, WebCore ignores all headers prefixed with 'content-'. This
patch adds 'x-content-' and 'x-webkit-' to the list, as well as specific
headers like 'upgrade', 'trailer', and others that the Chromium network
stack currently ignores.
The tests verify that those headers with visible effect are correctly
handled: 'x-frame-options', 'content-security-policy', and
'x-xss-protection'.
Tests: http/tests/security/XFrameOptions/x-frame-options-cached.html
http/tests/security/contentSecurityPolicy/cached-frame-csp.html
http/tests/security/xssAuditor/cached-frame.html
- loader/cache/CachedResource.cpp:
(WebCore):
(WebCore::CachedResource::updateResponseAfterRevalidation):
This patch adds two arrays containing the specific headers to
ignore and the prefixes to ignore. These lists are processed in
shouldUpdateHeaderAfterRevalidation.
CachedResource::updateResponseAfterRevalidation relies on this new
method when processing revalidated resources.
- loader/cache/CachedResource.cpp:
(WebCore):
(WebCore::shouldUpdateHeaderAfterRevalidation):
(WebCore::CachedResource::updateResponseAfterRevalidation):
LayoutTests:
- http/tests/security/XFrameOptions/resources/nph-cached-xfo.pl: Added.
- http/tests/security/XFrameOptions/x-frame-options-cached-expected.txt: Added.
- http/tests/security/XFrameOptions/x-frame-options-cached.html: Added.
- http/tests/security/contentSecurityPolicy/cached-frame-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/cached-frame-csp.html: Added.
- http/tests/security/contentSecurityPolicy/resources/nph-cached-csp.pl: Added.
- http/tests/security/xssAuditor/cached-frame-expected.txt: Added.
- http/tests/security/xssAuditor/cached-frame.html: Added.
- http/tests/security/xssAuditor/resources/nph-cached.pl: Added.
- 9:20 PM Changeset in webkit [142067] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking all webgl/conformance tests as slow.
- platform/chromium/TestExpectations:
- 9:19 PM Changeset in webkit [142066] by
-
- 4 edits in trunk/Source
Versioning.
- 9:16 PM Changeset in webkit [142065] by
-
- 1 copy in tags/Safari-537.30
New Tag.
- 8:40 PM Changeset in webkit [142064] by
-
- 11 edits in trunk/Source/WebKit2
Make CustomProtocolManagerProxy a MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=108787
Reviewed by Anders Carlsson.
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::addMessageReceiver):
(WebKit::ChildProcessProxy::removeMessageReceiver):
(WebKit::ChildProcessProxy::dispatchMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):
- Shared/ChildProcessProxy.h:
Sink the MessageReceiverMap down into the ChildProcessProxy.
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::DownloadProxyMap):
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::processDidClose):
- UIProcess/Downloads/DownloadProxyMap.h:
Pass the ChildProcessProxy rather than the MessageReceiverMap to the constructor.
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
Convert to a MessageReceiver.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::createDownloadProxy):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::createDownloadProxy):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
Remove direct chaining to CustomProtocolManagerProxy.
- 7:14 PM Changeset in webkit [142063] by
-
- 5 edits in trunk
document.referrer leakage with XSS Auditor page block
https://bugs.webkit.org/show_bug.cgi?id=109089
Reviewed by Adam Barth.
Source/WebCore:
Pass "about:blank" as referrer instead of "" so that the actual page
is not leaked when empty referrers are replaced later on in the
request.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
LayoutTests:
Test prints the referrer to show it isn't leaked.
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- 6:50 PM Changeset in webkit [142062] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking gl-vertexattribpointer.html as slow.
- platform/chromium/TestExpectations:
- 6:43 PM Changeset in webkit [142061] by
-
- 31 edits in trunk/Source/WebCore
[V8] Make an Isolate parameter mandatory in GetTemplate() and GetRawTemplate()
https://bugs.webkit.org/show_bug.cgi?id=109026
Reviewed by Adam Barth.
Now it's time to kill an optional Isolate parameter.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
(WebCore::V8Float64Array::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
(WebCore::V8TestException::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
(WebCore::V8TestOverloadedConstructors::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::installPerContextPrototypeProperties):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WebCore::WrapperTypeInfo::installPerContextPrototypeProperties):
- 6:00 PM Changeset in webkit [142060] by
-
- 6 edits1 add in trunk/Source
Unreviewed. Touchups to VS2010 WebKit solution.
Fix an export generator script, modify some property sheets, add resouce file.
Add WinLauncher projects to solution.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props:
- JavaScriptCore.vcxproj/resource.h: Added.
- WebKit.vcxproj/WebKit.sln:
- 5:52 PM Changeset in webkit [142059] by
-
- 1 edit8 copies15 adds in trunk/Tools
VS2010 WinLauncher project, property sheets and resources.
https://bugs.webkit.org/show_bug.cgi?id=107037.
Reviewed by Brent Fulgham.
- WinLauncher/WinLauncher.vcxproj: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Copied from WinLauncher/WinLauncher.ico.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Copied from WinLauncher/WinLauncherLauncher.rc.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.user: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Copied from WinLauncher/WinLauncher.rc.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.user: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Copied from WinLauncher/WinLauncherPostBuild.cmd.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Copied from WinLauncher/WinLauncherPreBuild.cmd.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Copied from WinLauncher/resource.h.
- WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Copied from WinLauncher/WinLauncherLauncherResource.h.
- WinLauncher/WinLauncher.vcxproj/small.ico: Copied from WinLauncher/small.ico.
- 5:35 PM Changeset in webkit [142058] by
-
- 4 edits292 adds in trunk/LayoutTests
Adds failing WebGL Conformance Tests.
https://bugs.webkit.org/show_bug.cgi?id=109075
Reviewed by Kenneth Russell.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Added.
- webgl/conformance/canvas/buffer-offscreen-test.html: Added.
- webgl/conformance/canvas/buffer-preserve-test-expected.txt: Added.
- webgl/conformance/canvas/buffer-preserve-test.html: Added.
- webgl/conformance/canvas/drawingbuffer-test-expected.txt: Added.
- webgl/conformance/canvas/drawingbuffer-test.html: Added.
- webgl/conformance/canvas/to-data-url-test-expected.txt: Added.
- webgl/conformance/canvas/to-data-url-test.html: Added.
- webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Added.
- webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
- webgl/conformance/context/context-creation-and-destruction-expected.txt: Added.
- webgl/conformance/context/context-creation-and-destruction.html: Added.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Added.
- webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
- webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Added.
- webgl/conformance/glsl/literals/float_literal.vert.html: Added.
- webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
- webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
- webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
- webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
- webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
- webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Added.
- webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
- webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Added.
- webgl/conformance/glsl/misc/shaders-with-varyings.html: Added.
- webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Added.
- webgl/conformance/glsl/variables/gl-pointcoord.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-A.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B1.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B2.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B3.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-B4.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-C.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
- webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Added.
- webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
- webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/bufferDataBadArgs.html: Added.
- webgl/conformance/more/functions/copyTexImage2D-expected.txt: Added.
- webgl/conformance/more/functions/copyTexImage2D.html: Added.
- webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Added.
- webgl/conformance/more/functions/copyTexSubImage2D.html: Added.
- webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/deleteBufferBadArgs.html: Added.
- webgl/conformance/more/functions/drawArrays-expected.txt: Added.
- webgl/conformance/more/functions/drawArrays.html: Added.
- webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Added.
- webgl/conformance/more/functions/drawArraysOutOfBounds.html: Added.
- webgl/conformance/more/functions/drawElements-expected.txt: Added.
- webgl/conformance/more/functions/drawElements.html: Added.
- webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/drawElementsBadArgs.html: Added.
- webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/readPixelsBadArgs.html: Added.
- webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/texImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/texImage2DHTML-expected.txt: Added.
- webgl/conformance/more/functions/texImage2DHTML.html: Added.
- webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Added.
- webgl/conformance/more/functions/texSubImage2DBadArgs.html: Added.
- webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
- webgl/conformance/more/functions/texSubImage2DHTML.html: Added.
- webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
- webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
- webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
- webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
- webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/log/log_001_to_008.html: Added.
- webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Added.
- webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
- webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Added.
- webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
- webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Added.
- webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
- webgl/conformance/programs/program-test-expected.txt: Added.
- webgl/conformance/programs/program-test.html: Added.
- webgl/conformance/reading/read-pixels-test-expected.txt: Added.
- webgl/conformance/reading/read-pixels-test.html: Added.
- webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
- webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
- webgl/conformance/rendering/gl-scissor-test-expected.txt: Added.
- webgl/conformance/rendering/gl-scissor-test.html: Added.
- webgl/conformance/rendering/more-than-65536-indices-expected.txt: Added.
- webgl/conformance/rendering/more-than-65536-indices.html: Added.
- webgl/conformance/rendering/multisample-corruption-expected.txt: Added.
- webgl/conformance/rendering/multisample-corruption.html: Added.
- webgl/conformance/rendering/point-size-expected.txt: Added.
- webgl/conformance/rendering/point-size.html: Added.
- webgl/conformance/state/gl-object-get-calls-expected.txt: Added.
- webgl/conformance/state/gl-object-get-calls.html: Added.
- webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
- webgl/conformance/textures/copy-tex-image-2d-formats.html: Added.
- webgl/conformance/textures/gl-pixelstorei-expected.txt: Added.
- webgl/conformance/textures/gl-pixelstorei.html: Added.
- webgl/conformance/textures/origin-clean-conformance-expected.txt: Added.
- webgl/conformance/textures/origin-clean-conformance.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
- webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
- webgl/conformance/textures/texture-active-bind-2-expected.txt: Added.
- webgl/conformance/textures/texture-active-bind-2.html: Added.
- webgl/conformance/textures/texture-active-bind-expected.txt: Added.
- webgl/conformance/textures/texture-active-bind.html: Added.
- webgl/conformance/textures/texture-mips-expected.txt: Added.
- webgl/conformance/textures/texture-mips.html: Added.
- webgl/conformance/textures/texture-npot-video-expected.txt: Added.
- webgl/conformance/textures/texture-npot-video.html: Added.
- webgl/conformance/textures/texture-size-expected.txt: Added.
- webgl/conformance/textures/texture-size-limit-expected.txt: Added.
- webgl/conformance/textures/texture-size-limit.html: Added.
- webgl/conformance/textures/texture-size.html: Added.
- webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Added.
- webgl/conformance/uniforms/gl-uniform-arrays.html: Added.
- webgl/conformance/uniforms/uniform-default-values-expected.txt: Added.
- webgl/conformance/uniforms/uniform-default-values.html: Added.
- webgl/conformance/uniforms/uniform-location-expected.txt: Added.
- webgl/conformance/uniforms/uniform-location.html: Added.
- webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Added.
- webgl/conformance/uniforms/uniform-samplers-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Added.
- webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
- webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Added.
- webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
- webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Added.
- webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
- webgl/resources/webgl_test_files/conformance/programs/program-test.html: Added.
- webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Added.
- webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Added.
- webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Added.
- webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Added.
- webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Added.
- webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Added.
- 5:01 PM Changeset in webkit [142057] by
-
- 24 edits9 adds in trunk
Add support for gesture scroll events that do not propagate to enclosing scrollables
https://bugs.webkit.org/show_bug.cgi?id=108849
Reviewed by Antonio Gomes.
Source/WebCore:
Tests: fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html
fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html
fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html
Rename RenderLayer::scrollByRecursively() to RenderLayer::scrollBy() and add a parameter
of type RenderLayer::ScrollPropagation to specify whether or not the scroll should
propagate to its parent by recursing. Implement RenderLayer::scrollByRecursively() as a
call to RenderLayer::scrollBy() with argument RenderLayer::ShouldPropagateScroll so
that all existing calls to the function still produce the correct behavior.
In EventHandler::handleGestureScrollUpdate(), call RenderLayer::scrollBy() with
argument RenderLayer::ShouldPropagateScroll if |gestureEvent| is a GestureScrollUpdate
or instead with argument RenderLayer::DontPropagateScroll if |gestureEvent| is a
GestureScrollUpdateWithoutPropagation.
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollUpdate):
- platform/PlatformEvent.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::gestureEvent):
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
(WebCore):
(WebCore::RenderLayer::scrollBy):
- rendering/RenderLayer.h:
Source/WebKit/chromium:
Define the new event type GestureScrollUpdateWithoutPropagation.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- src/WebPluginContainerImpl.cpp:
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
Tools:
Modify chromium's DRT EventSender to support the new event type
GestureScrollUpdateWithoutPropagation.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureScrollUpdateWithoutPropagation):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(EventSender):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::handleInputEvent):
LayoutTests:
New tests added to ensure that GestureScrollUpdateWithoutPropagation events will not
propagate to the scrollable parent of their target when the target has no area
left to be scrolled.
Modified two chromium-specific plugin tests to ensure that the plugins receive
GestureScrollUpdate events when GestureScrollUpdateWithoutPropagation events are
dispatched to them.
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html: Added.
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html: Added.
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
- platform/chromium/plugins/gesture-events-expected.txt:
- platform/chromium/plugins/gesture-events-scrolled-expected.txt:
- platform/chromium/plugins/gesture-events-scrolled.html:
- platform/chromium/plugins/gesture-events.html:
- 4:55 PM Changeset in webkit [142056] by
-
- 11 edits in trunk
[Chromium] table-section-overflow-clip-crash.html hits an assert
https://bugs.webkit.org/show_bug.cgi?id=108594
Reviewed by Levi Weintraub.
Source/WebCore:
When a counter calls setNeedsLayout, it also marks it's containing blocks
as needing layout, so we need to clear the setNeedsLayoutIsForbidden bit on the
containing blocks as well as the counter itself.
Also, use RAII objects for all the places where we clear this bit and make
the setter/getter for it private to RenderObject.
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::SetLayoutNeededForbiddenScope::SetLayoutNeededForbiddenScope):
(WebCore::RenderObject::markContainingBlocksForLayout):
- rendering/RenderObject.h:
(SetLayoutNeededForbiddenScope):
(RenderObject):
(WebCore::RenderObject::isSetNeedsLayoutForbidden):
(WebCore::RenderObject::setNeedsLayoutIsForbidden):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::computePreferredLogicalWidths):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
LayoutTests:
- platform/chromium/TestExpectations:
- 4:47 PM Changeset in webkit [142055] by
-
- 2 edits in trunk/Source/WebKit2
ASSERT(!m_findPageOverlay) in FindController.cpp after r140769.
https://bugs.webkit.org/show_bug.cgi?id=109105.
Reviewed by Tim Horton.
In r140769 we changed the way the overlay is destroyed,
therefore the assert is no longer valid and should be removed.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
- 4:41 PM Changeset in webkit [142054] by
-
- 3 edits2 adds in trunk
display:none file upload button crashes
https://bugs.webkit.org/show_bug.cgi?id=109102
Reviewed by Levi Weintraub.
Source/WebCore:
Test: fast/forms/file/display-none-upload-button.html
- rendering/RenderFileUploadControl.cpp:
(WebCore::nodeWidth):
(WebCore::RenderFileUploadControl::paintObject):
Having an upload button doesn't mean we have a rendered upload button.
Null check the renderer before trying to access it.
LayoutTests:
- fast/forms/file/display-none-upload-button-expected.txt: Added.
- fast/forms/file/display-none-upload-button.html: Added.
Tests that we don't crash. Also exposes a bug that the baseline and height of
the input don't include the height of the filename text.
- 4:32 PM Changeset in webkit [142053] by
-
- 10 edits1 add1 delete in trunk/LayoutTests
[Chromium] Test expectations update for Skia change.
Unreviewed expectations update
Files that we were expecting to fail. Now being rebaselined.
- platform/chromium-linux-x86/svg/text/text-viewbox-rescale-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
- platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
- platform/chromium-linux/svg/text/selection-styles-expected.png:
- platform/chromium-linux/svg/text/text-viewbox-rescale-expected.png:
- platform/chromium-mac-lion/svg/text/text-viewbox-rescale-expected.png:
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/chromium-mac/svg/text/text-viewbox-rescale-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
- platform/efl/svg/batik/text/smallFonts-expected.png: Removed.
- 4:31 PM Changeset in webkit [142052] by
-
- 2 edits in trunk/LayoutTests
Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test
https://bugs.webkit.org/show_bug.cgi?id=109101
We check that the style matches a pseudo element by setting its height to 1px.
Some user agents, like iOS, have default border styles that affect the minimum height,
so we need to reset those.
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-06
Reviewed by Joseph Pecoraro.
- fast/css/unknown-pseudo-element-matching.html:
- 4:28 PM Changeset in webkit [142051] by
-
- 8 edits3 adds in trunk
Context's currentPath should check for passed type
https://bugs.webkit.org/show_bug.cgi?id=109097
Patch by Dirk Schulze <dschulze@adobe.com> on 2013-02-06
Reviewed by Dean Jackson.
Source/WebCore:
Add check for passed pointer and return earlier.
Test: fast/canvas/canvas-currentPath-crash.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setCurrentPath):
LayoutTests:
Add checks with different data types as value for canvas.currentPath.
- fast/canvas/canvas-currentPath-crash-expected.txt: Added.
- fast/canvas/canvas-currentPath-crash.html: Added.
- fast/canvas/script-tests/canvas-currentPath-crash.js: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 4:18 PM Changeset in webkit [142050] by
-
- 11 edits2 adds2 deletes in trunk/LayoutTests
[Chromium] Test expectations update for Skia change.
Unreviewed expectations update
Files that we were expecting to fail. Now being rebaselined.
- platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png:
- platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-linux/svg/custom/text-ctm-expected.png:
- platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-mac/svg/custom/text-ctm-expected.txt:
- platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
- platform/chromium-win/svg/custom/text-ctm-expected.png:
- platform/chromium-win/svg/custom/text-ctm-expected.txt: Removed.
- platform/gtk/svg/custom/text-ctm-expected.txt: Removed.
- svg/custom/text-ctm-expected.txt: Added.
- 4:15 PM Changeset in webkit [142049] by
-
- 4 edits in trunk
[HTMLTemplateElement] Non </template> end tags should be ignored in "template contents" insertion mode.
https://bugs.webkit.org/show_bug.cgi?id=109090
Reviewed by Adam Barth.
Source/WebCore:
Test added to html5lib suite.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):
LayoutTests:
- html5lib/resources/template.dat:
- 3:59 PM Changeset in webkit [142048] by
-
- 15 edits1 add2 deletes in trunk/LayoutTests
[Chromium] Test expectations update for Skia change.
Unreviewed expectations update
Files that we were expecting to fail. Now being rebaslined.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Removed.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Removed.
- platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
- platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
- 3:51 PM Changeset in webkit [142047] by
-
- 1 edit4 adds in trunk/LayoutTests
[Chromium] Test expectations update for Skia change.
Unreviewed expectations update
And these too. See change below.
- platform/chromium-mac-lion/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
- platform/chromium-mac-lion/fast/writing-mode/japanese-rl-text-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-text-expected.txt: Added.
- 3:50 PM Changeset in webkit [142046] by
-
- 1 edit2 adds in trunk/LayoutTests
[Chromium] Test expectations update for Skia change.
Unreviewed expectations update
Apparently there are width differences on the mac platforms. These were
clobbered qwhen I updated the 10.8 expectations.
- platform/chromium-mac-lion/fast/writing-mode/japanese-lr-text-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/writing-mode/japanese-lr-text-expected.txt: Added.
- 3:47 PM Changeset in webkit [142045] by
-
- 4 edits in trunk/Source
Make ScrollView::paint() clip by visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=108888
Reviewed by Levi Weintraub.
When applyPageScaleFactorInCompositor or fixedVisibleContentRect
are used, frameRect() and visibleContentRect(true).size() are
no longer synonyms, and the latter is the one that should be
used for clipping paints.
New WebFrameTest: pageScaleFactorScalesPaintClip.
Source/WebCore:
- platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
Source/WebKit/chromium:
- tests/WebFrameTest.cpp:
- 3:44 PM Changeset in webkit [142044] by
-
- 3 edits in trunk/Source/WebKit2
Dispatch storage manager messages to the storage work queue
https://bugs.webkit.org/show_bug.cgi?id=109099
Reviewed by Andreas Kling.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
(WebKit::StorageManager::dispatchMessageOnStorageManagerQueue):
(WebKit):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- 3:33 PM Changeset in webkit [142043] by
-
- 9 edits in trunk
Store the language internally instead of using lang attribute for WebVTT nodes
https://bugs.webkit.org/show_bug.cgi?id=108858
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-06
Reviewed by Eric Carlson.
Source/WebCore:
Only language webvtt elements should have a lang attribute so we have to store
the language internally in the element. Refactored the code to make
computeInheritedLanguage virtual.
Existing tests were modified to cover this case.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::WebVTTElement):
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
(WebCore::WebVTTElement::createEquivalentHTMLElement): clone the internal language property.
- html/track/WebVTTElement.h:
(WebCore::WebVTTElement::language):
(WebCore::WebVTTElement::setLanguage):
- html/track/WebVTTParser.cpp: only set the lang attribute for language objects.
(WebCore::WebVTTParser::constructTreeFromToken):
LayoutTests:
- media/track/captions-webvtt/styling-lang.vtt:
- media/track/track-css-matching-lang-expected.txt:
- media/track/track-css-matching-lang.html:
- 3:08 PM Changeset in webkit [142042] by
-
- 3 edits2 adds in trunk
Negative text indents can break RenderBlock's inline maximum preferred width calculation
https://bugs.webkit.org/show_bug.cgi?id=108973
Reviewed by Emil A Eklund.
Source/WebCore:
Change two quirks about to how we calculate a block's inline preferred width with
text-indent.
First, re-use text-indent that's first applied to floats on text that follows it.
This matches Layout, as otherwise we can prematurely wrap text when there's a negative
margin on a block starting with a float. This also matches FireFox.
Second, correct how the max preferred width is calculated in the presence of a negative
text-indent. If the text-indent is more negative than the first text line break, we
update the value to be the remainder. Previously, we added this remaining negative value
to subsequent minimum and maximum preferred width calculations (until the remainder was
gone). This is wrong for the max preferred width, as we're adding the negative value more
than once, and leads to a max preferred width that's smaller than our line.
Test: fast/css/negative-text-indent-in-inline-block.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
LayoutTests:
- fast/css/negative-text-indent-in-inline-block-expected.html: Added.
- fast/css/negative-text-indent-in-inline-block.html: Added.
- 3:06 PM Changeset in webkit [142041] by
-
- 2 edits in branches/chromium/1364
Revert 141898
Disable Fullscreen API on Android.
Disable the fullscreen API, as it is not working correctly on Android.
BUG=173664
Review URL: https://codereview.chromium.org/12208016
TBR=jknotten@chromium.org
Review URL: https://codereview.chromium.org/12225065
- 2:59 PM Changeset in webkit [142040] by
-
- 2 edits in branches/safari-536.28-branch/LayoutTests
We don't have the text-based repaint test harness on the branch.
<rdar://problem/12968804>
Reviewed by Tim Horton.
- platform/mac/Skipped:
- 2:56 PM Changeset in webkit [142039] by
-
- 2 edits in branches/safari-536.28-branch/LayoutTests
<rdar://problem/12968605>
Reviewed by Enrica Casucci.
- platform/mac-wk2/Skipped:
- 2:47 PM Changeset in webkit [142038] by
-
- 1 edit1 add in branches/safari-536.28-branch/LayoutTests
Update WK2 test results.
<rdar://problem/12968040> Chopin test failure: http/tests/loading/remove-child-triggers-parser.html
Reviewed by Jeffrey Pfau.
- platform/mac-wk2/http/tests/loading/remove-child-triggers-parser-expected.txt: Added.
- 2:46 PM Changeset in webkit [142037] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Refactor renderContents() for cleaner code.
https://bugs.webkit.org/show_bug.cgi?id=109059
RIM PR 280374
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
The fact that we've got two renderContents() implementations
in BackingStore.cpp, one of which was tailored to just
being called from drawContents(), is a major annoyance.
With this patch, the regular renderContents() is modified
in a way so that drawContents() can make use of it as well.
This includes an API change for both functions which makes
it more flexible and enables further cleanups and improvements
to accuracy. The second, unloved renderContents() is removed.
The user-visible changes are improved (float) accuracy for
render offsets, clipping to exactly the dstRect that has
been specified, and the changed public drawContents() API.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):
- Api/BackingStore.h:
(Platform):
(Graphics):
- Api/BackingStore_p.h:
(WebCore):
(BackingStorePrivate):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
- WebKitSupport/SurfacePool.h:
(SurfacePool):
- 2:45 PM Changeset in webkit [142036] by
-
- 2 edits in branches/safari-536.28-branch/LayoutTests
<rdar://problem/12967921>
Update test results.
Reviewed by Enrica Casucci.
- editing/pasteboard/paste-noscript-xhtml-expected.txt:
- 2:44 PM Changeset in webkit [142035] by
-
- 31 edits3 deletes in trunk/Tools
Unreviewed, rolling out r142032.
http://trac.webkit.org/changeset/142032
https://bugs.webkit.org/show_bug.cgi?id=109095
component build still broken (Requested by jochen on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
(WebTaskList):
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(MockGrammarCheck::checkGrammarOfString):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- 2:33 PM Changeset in webkit [142034] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Expanding failure expectation for fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html.
- platform/gtk/TestExpectations:
- 2:30 PM Changeset in webkit [142033] by
-
- 2 edits in trunk/Source/WebCore
Fix broken release builds, greening the bots.
https://bugs.webkit.org/show_bug.cgi?id=107475.
Not reviewed.
No new tests.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::logOpenDatabaseError):
- 2:14 PM Changeset in webkit [142032] by
-
- 31 edits3 copies in trunk/Tools
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466
Reviewed by Adam Barth.
To achieve this, we need to drop all dependencies on WTF.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- 1:57 PM Changeset in webkit [142031] by
-
- 23 edits9 deletes in trunk
Unreviewed, rolling out r142025.
http://trac.webkit.org/changeset/142025
https://bugs.webkit.org/show_bug.cgi?id=109091
broke the build (Requested by tdanderson on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06
Source/WebCore:
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollUpdate):
- platform/PlatformEvent.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::gestureEvent):
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
- rendering/RenderLayer.h:
Source/WebKit/chromium:
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- src/WebPluginContainerImpl.cpp:
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
Tools:
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(EventSender):
LayoutTests:
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Removed.
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html: Removed.
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Removed.
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html: Removed.
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Removed.
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html: Removed.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Removed.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Removed.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Removed.
- platform/chromium/plugins/gesture-events-expected.txt:
- platform/chromium/plugins/gesture-events-scrolled-expected.txt:
- platform/chromium/plugins/gesture-events-scrolled.html:
- platform/chromium/plugins/gesture-events.html:
- 1:51 PM Changeset in webkit [142030] by
-
- 22 edits in trunk/Source/WebCore
Split openDatabase() between front and back end work.
https://bugs.webkit.org/show_bug.cgi?id=107475.
Reviewed by Anders Carlsson.
The main work of splitting DatabaseManager::openDatabase() is in
refactoring how DatabaseTracker::canEstablishDatabase() works. It used
to check for adequate space quota, and if the check fails, it would call
back into the client from inside canEstablishDatabase(). The call back
allows the client to update the quota (if appropriate). Thereafter,
canEstablishDatabase() will retry its quota check.
In a webkit2 world, we'll want to minimize the traffic between the
client (script side) and the server (sqlite db side), and ideally, we
don't want the server to call back to the client. Note: the
DatabaseTracker belongs on the server side.
To achieve this, we split canEstablishDatabase() into 2 parts: the
checks before the call back to the client, and the checks after.
The first part will retain the name canEstablishDatabase(), and the
second part will be named retryCanEstablishDatabase().
We also added a DatabaseServer::openDatabase() function that can be
called with a retry flag.
The client side DatabaseManager::openDatabase() will call
DatabaseServer::openDatabase(), which then calls canEstablishDatabase()
to do its quota check. If there is enough quota,
DatabaseServer::openDatabase() will proceed to open the backend database
without return to the client first. The opened database will be returned
to the client.
If DatabaseServer::openDatabase() finds inadequate quota the first time,
it will return with a DatabaseSizeExceededQuota error. The DatabaseManager
(on the client side) will check for this error and call back to its client
for an opportunity to increase the quota. Thereafter, the DatabaseManager
will call DatabaseServer::openDatabase() again. This time,
DatabaseServer::openDatabase() will call retryCanEstablishDatabase() to
check the quota, and then open the backend database if there is enough
quota.
No new tests.
- Modules/webdatabase/AbstractDatabaseServer.h:
- Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::create):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::performOpenAndVerify):
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
- Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::openAndVerifyVersion):
(WebCore::DatabaseBackendAsync::performOpenAndVerify):
- Modules/webdatabase/DatabaseBackendAsync.h:
(DatabaseBackendAsync):
- Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::openAndVerifyVersion):
- Modules/webdatabase/DatabaseBackendSync.h:
(DatabaseBackendSync):
- Modules/webdatabase/DatabaseError.h:
(WebCore::ENUM_CLASS):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::exceptionCodeForDatabaseError):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::create):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
- Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
- Modules/webdatabase/WorkerContextWebDatabase.cpp:
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
- 1:49 PM Changeset in webkit [142029] by
-
- 2 edits in trunk/Source/WebCore
Fix CompactHTMLToken's copy ctor to copy all fields
https://bugs.webkit.org/show_bug.cgi?id=109076
Reviewed by Adam Barth.
This was introduced by me in r142004. Without this patch we fail all tests when using the background parser.
Also don't use getters in copy ctor.
No new tests because no new functionality.
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- 1:42 PM Changeset in webkit [142028] by
-
- 2 edits in trunk/Source/WebCore
[Chromium/Skia] Remove use of deprecated Skia names
https://bugs.webkit.org/show_bug.cgi?id=109085
Patch by Brian Salomon <bsalomon@google.com> on 2013-02-06
Reviewed by Stephen White.
Tested by every existing canvas2d test.
- platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::grContext):
- 1:35 PM Changeset in webkit [142027] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove "config.h" header from WebUnitTests.cpp
https://bugs.webkit.org/show_bug.cgi?id=108966
Reviewed by Tony Chang.
This file includes headers from base/ in Chromium, and config.h
conflicts with base/logging.h. Rather than teaching certain files in
base/ not to #include base/logging.h, remove the config.h include
here. The ASSERT isn't really necessary, as attempting to run a null
test suite won't go very far anyway.
- tests/WebUnitTests.cpp:
(WebKit::RunAllUnitTests):
- 1:30 PM Changeset in webkit [142026] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining and adding a few failure expectations after r142015.
- platform/gtk/TestExpectations:
- platform/gtk/fast/dynamic/002-expected.txt:
- 1:26 PM Changeset in webkit [142025] by
-
- 23 edits9 adds in trunk
Add support for gesture scroll events that do not propagate to enclosing scrollables
https://bugs.webkit.org/show_bug.cgi?id=108849
Reviewed by Antonio Gomes.
Source/WebCore:
Tests: fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html
fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html
fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html
Rename RenderLayer::scrollByRecursively() to RenderLayer::scrollBy() and add a parameter
of type RenderLayer::ScrollPropagation to specify whether or not the scroll should
propagate to its parent by recursing. Implement RenderLayer::scrollByRecursively() as a
call to RenderLayer::scrollBy() with argument RenderLayer::ShouldPropagateScroll so
that all existing calls to the function still produce the correct behavior.
In EventHandler::handleGestureScrollUpdate(), call RenderLayer::scrollBy() with
argument RenderLayer::ShouldPropagateScroll if |gestureEvent| is a GestureScrollUpdate
or instead with argument RenderLayer::DontPropagateScroll if |gestureEvent| is a
GestureScrollUpdateWithoutPropagation.
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollUpdate):
- platform/PlatformEvent.h:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::gestureEvent):
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
(WebCore):
(WebCore::RenderLayer::scrollBy):
- rendering/RenderLayer.h:
Source/WebKit/chromium:
Define the new event type GestureScrollUpdateWithoutPropagation.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- src/WebPluginContainerImpl.cpp:
- src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
Tools:
Modify chromium's DRT EventSender to support the new event type
GestureScrollUpdateWithoutPropagation.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureScrollUpdateWithoutPropagation):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(EventSender):
LayoutTests:
New tests added to ensure that GestureScrollUpdateNotPropagated events will not
propagate to the scrollable parent of their target when the target has no area
left to be scrolled.
Modified two chromium-specific plugin tests to ensure that the plugins receive
GestureScrollUpdate events when GestureScrollUpdateNotPropagated events are
dispatched to them.
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html: Added.
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html: Added.
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
- fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
- platform/chromium/plugins/gesture-events-expected.txt:
- platform/chromium/plugins/gesture-events-scrolled-expected.txt:
- platform/chromium/plugins/gesture-events-scrolled.html:
- platform/chromium/plugins/gesture-events.html:
- 1:11 PM Changeset in webkit [142024] by
-
- 4 edits in trunk
REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
https://bugs.webkit.org/show_bug.cgi?id=108380
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Re-enable the main resource cache since the regression had been fixed in r141615.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
LayoutTests:
Re-enable tests that have been temporarily disabled.
- platform/mac/TestExpectations:
- 1:01 PM Changeset in webkit [142023] by
-
- 2 edits in trunk/Tools
[TestResultServer] Adjust the name of the GTK 64-bit debug builder
https://bugs.webkit.org/show_bug.cgi?id=109016
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/builders.jsonp: The GTK 64-bit debug
builder was adjusted to build WebKit1 only, with the name changed accordingly.
Reflect that change here as well.
- 1:00 PM Changeset in webkit [142022] by
-
- 6 edits in trunk/Source/WTF
[WTFURL] Fix erroneous header inclusions in WTFURL code
https://bugs.webkit.org/show_bug.cgi?id=109040
Reviewed by Benjamin Poulain.
Include WTFURL API headers from files in Source/WTF/wtf/url/src
by specifying their relative path to Source/WTF.
- GNUmakefile.am: The changes make it possible to compile the WTF library
without specifying both Source/WTF/wtf/url/api and Source/WTF/wtf/url/src
as inclusion directories in CPPFLAGS, so remove these two entries.
- wtf/url/src/RawURLBuffer.h:
- wtf/url/src/URLCanon.h: Include the URLParse.h header by specifying
only the base name as it's located in the same directory.
- wtf/url/src/URLCanonQuery.cpp:
- wtf/url/src/URLUtil.h:
- 12:58 PM Changeset in webkit [142021] by
-
- 13 edits4 adds in trunk
Implement 'vmax' from CSS3 values and units
https://bugs.webkit.org/show_bug.cgi?id=91440
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-06
Reviewed by Antti Koivisto.
vmax is implemented as primitive length unit.
New length type ViewportPercentageMax is added and included support for fetching the value
of this viewport percentage unit based on current viewport size.
The specification related to this implementation is
http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.
Source/WebCore:
Tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute.html
css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax.html
- css/CSSGrammar.y.in: Added vmax support.
- css/CSSParser.cpp: Parsing of vmax unit.
(WebCore::CSSParser::validUnit): Added vmax to valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vmax to primitive untis.
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitive for vmax.
(WebCore::CSSParser::detectNumberToken): Parsing of vmax token.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue): Added support for vmax.
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vmax.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto.
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCssText): Added support for vmax.
(WebCore::CSSPrimitiveValue::viewportPercentageLength): Function to create the Length structure for the viewport-percentage unit types.
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageLength): Checks whether the primitive value is ViewportPercentage Length.
- css/CSSPrimitiveValue.idl: Added support for vmax.
- css/LengthFunctions.cpp: Calcuation of length value based on the current viewport size.
(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):
- platform/Length.h:
(WebCore::Length::isViewportPercentage): To check the Length is of type ViewportPercentage.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
LayoutTests:
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt:
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-expected.html: Added.
- css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax.html: Added.
- 12:56 PM Changeset in webkit [142020] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Walked through the WontFix test expectations, expanding them with the expected failure.
This forces the test to run but not complain as long as the failure is the same as expected.
- platform/gtk/TestExpectations:
- 12:43 PM Changeset in webkit [142019] by
-
- 2 edits in trunk/Source/WebKit/blackberry
2013-02-06 Nima Ghanavatian <nghanavatian@rim.com>
[BlackBerry] Check range before use in parseBlockForSpellChecking
https://bugs.webkit.org/show_bug.cgi?id=109080
Reviewed by Yong Li.
PR291394
This was missed during patch webkit/5aea04f6ea625827. Since getRangeForSpellCheckWithFineGranularity
now returns null values, we need a check here before using the range object here as well.
Internally reviewed by Mike Fenton.
- WebKitSupport/SpellingHandler.cpp: (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- 12:41 PM Changeset in webkit [142018] by
-
- 2 edits in trunk/LayoutTests
Suppress failures for minor pixel diffs which will be caused when https://codereview.chromium.org/12217047/ lands. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=104289
- platform/chromium/TestExpectations:
- 12:40 PM Changeset in webkit [142017] by
-
- 8 edits in trunk/Source/WebKit2
Pass the document source URL to the pluginLoadPolicy callback
https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>
Reviewed by Andreas Kling.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h:
(WebUIClient):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
- 12:25 PM Changeset in webkit [142016] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Marking required tests as slow so the test runs are not interrupted when timeouts
occur in tests that would actually pass if given enough time.
- platform/gtk/TestExpectations:
- 12:10 PM Changeset in webkit [142015] by
-
- 17 edits14 adds in trunk
When a block element is made inline positioned and has static left and right, it does not follow inline formatting context
https://bugs.webkit.org/show_bug.cgi?id=91665
Patch by Pravin D <pravind.2k4@gmail.com> on 2013-02-06
Reviewed by Julien Chaffraix.
Source/WebCore:
Out-of-flow-positioned elements have their display overriden to BLOCK. When a static block elements
changes to inline out-of-flow-positioned or vice-versa, the element current and previous display properties
are same. This causes the element to follow a wrong flow context(in this case Block context) and the element
is laid out incorrectly. The patch fixes the issue by reattaching the renderers of the node whenever either
position property changes or when its floating property changes.
Also the cases when an out-of-flow-positioned/floating element changes to static/non-floating element where
being specially handled. As reattaching the renderers in the above cases correctly handles the above cases,
special handling for such cases is no more required and the related code can be safely removed.
Reattaching renderers for the afore mentioned issues takes a different(longer) code path. Performance measurements
summary for the same is as follows:
% increase in time
Absolute-block-to-static-block 2.00
Absolute-inline-to-static-block 1.21
Absolute-inline-to-static-inline 1.18
Static-block-to-absolute-block 1.13
Static-inline-to-absolute-inline 1.35
Floating-block-non-floating-block 0.85
Floating-inline-non-floating-block 0.66
Floating-inline-non-floating-inline 0.57
Non-floating-block-floating-block 0.12
Non-floating-inline-floating-inline 1.36
Tests: fast/dynamic/absolute-positioned-to-static-positioned.html
fast/dynamic/floating-to-non-floating.html
fast/dynamic/non-floating-to-floating.html
fast/dynamic/static-positioned-to-absolute-positioned.html
- dom/Node.cpp:
(WebCore::Node::diff):
Return detach in the following conditions:
1) Element changes to out-of-flow-positioned or vice-versa.
2) Element becomes floating or vice-versa.
- rendering/RenderBlock.cpp:
(WebCore):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- rendering/RenderInline.cpp:
(WebCore):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
(RenderObject):
The fix in Node::diff() obsoletes some code. The above deletion are part of this dead code cleanup.
LayoutTests:
- fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Added.
- fast/dynamic/absolute-positioned-to-static-positioned.html: Added.
- fast/dynamic/floating-to-non-floating-expected.txt: Added.
- fast/dynamic/floating-to-non-floating.html: Added.
- fast/dynamic/non-floating-to-floating-expected.txt: Added.
- fast/dynamic/non-floating-to-floating.html: Added.
- fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Added.
- fast/dynamic/static-positioned-to-absolute-positioned.html: Added.
Testcases for the patch.
- fast/dynamic/resources/helper-bug91665.js: Added.
- fast/dynamic/resources/style-bug91665.css: Added.
Common javascript functions and css classes used by the above testcases.
- fast/css/first-letter-removed-added-expected.txt:
Previously failing sub-test is passing.
- fullscreen/full-screen-fixed-pos-parent-expected.txt:
Change orthogonal to the current patch.
- platform/mac/fast/dynamic/002-expected.txt:
- platform/chromium-win/fast/dynamic/002-expected.txt:
- platform/chromium/fast/dynamic/002-expected.txt:
Expected change. The testcase has a static block element followed by a text node wrapped
in an anonymous block. When the block element becomes floating, it is out of the flow context.
Thus the text node must no longer be wrapped by the anonymous block.
- platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
- platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:
Progression. Previously we used to repaint the a much larger area as compared to the behavior
with the patch, which repaints only the area affected due to the change in style(position)
of certain elements.
- platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
- platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
- platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
- platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
Added platform specific images.
- 12:08 PM Changeset in webkit [142014] by
-
- 4 edits2 adds in trunk
AX: if <html> has an ARIA attribute, it's exposed as an AXGroup
https://bugs.webkit.org/show_bug.cgi?id=109008
Reviewed by Ryosuke Niwa.
Source/WebCore:
If an <html> element had an ARIA attribute, it was being turned into an element
in the AX hierarchy. This was causing trouble for screen readers by inserting
an unexpected element in the navigation sequence.
Test: accessibility/html-html-element-is-ignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
- accessibility/html-html-element-is-ignored-expected.txt: Added.
- accessibility/html-html-element-is-ignored.html: Added.
- platform/chromium/TestExpectations:
- 11:43 AM Changeset in webkit [142013] by
-
- 2 edits in trunk/Source/WebKit2
Get rid of unneeded writeable preferences.
Reviewed by Anders Carlsson.
com.apple.HIToolbox.plist and com.apple.WebProcess.plist were made writeable very
early in WebKit2 development, before we moved a lot of functionality to UI process.
They don't appear to be needed any more.
Note that we do not even need to allow reading for com.apple.WebProcess.plist -
it's read at process initialization before we enter the sandbox, and services
have a different plist anyway.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:35 AM Changeset in webkit [142012] by
-
- 3 edits3 adds in trunk
RenderLayer hasVisibleContent() has inconsistent semantics causing disappearing composited layers
https://bugs.webkit.org/show_bug.cgi?id=108118
Reviewed by Simon Fraser.
Source/WebCore:
RenderLayerBacking::hasVisibleNonCompositingDescendantLayers was
only checking whether direct children had visible content. As a
result, composited layers had wrong visibility status if only a
deeper descendant RenderLayer was visible.
Test: compositing/visibility/visibility-on-distant-descendant.html
- rendering/RenderLayerBacking.cpp:
(WebCore::hasVisibleNonCompositingDescendant): copied the original
implementation into this function; then added the RenderLayer
recursion as appropriate.
(WebCore):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):
This is now just a wrapper to the private static recursive
function.
LayoutTests:
- compositing/visibility/visibility-on-distant-descendant-expected.png: Added.
- compositing/visibility/visibility-on-distant-descendant-expected.txt: Added.
- compositing/visibility/visibility-on-distant-descendant.html: Added.
- 11:07 AM Changeset in webkit [142011] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
https://bugs.webkit.org/show_bug.cgi?id=108667
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-06
Reviewed by Darin Fisher.
WebWidget::selectionBounds() returns the anchor and focus of the
selection. This matches the arguments to WebFrame::selectRange().
Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
anchor/focus to start/end.
- public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::isSelectionAnchorFirst):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isSelectionAnchorFirst):
(WebKit):
- src/WebViewImpl.h:
- tests/WebViewTest.cpp:
- 10:56 AM Changeset in webkit [142010] by
-
- 2 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 141540
[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
https://bugs.webkit.org/show_bug.cgi?id=108543
Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.
Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositionFromExistingText):
- tests/WebViewTest.cpp:
Re-enabling the test
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12233004
- 10:54 AM Changeset in webkit [142009] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Assertion failure on MiniBrowser exit
https://bugs.webkit.org/show_bug.cgi?id=108932
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-06
Reviewed by Anders Carlsson.
WorkQueue is now refcounted after r141497, so increase ref
count when a new job is scheduled and unref it when it finishes.
- Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::performWork):
(WorkQueue::performTimerWork):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
- 10:44 AM Changeset in webkit [142008] by
-
- 2 edits in trunk/Source/WebKit/chromium
IndexedDB: Stub out SharedBuffer version of put()
https://bugs.webkit.org/show_bug.cgi?id=108986
Reviewed by Darin Fisher.
This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.
- public/WebIDBDatabase.h:
(WebKit):
(WebKit::WebIDBDatabase::put):
- 10:35 AM Changeset in webkit [142007] by
-
- 1 edit1567 adds in trunk/LayoutTests
Adds the WebGL Conformance Test ogles support files.
https://bugs.webkit.org/show_bug.cgi?id=109063
Reviewed by Kenneth Russell.
Note: This was reviewed offline because the patch was too large to upload to
bugs.webkit.org. It doesn't add any LayoutTests. It only adds support files.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_empty_array_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_empty_array_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_uniform_array_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_uniform_array_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/initfunc_empty_array_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/array/initfunc_empty_array_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvaryyvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvaryyvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvaryyvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvaryyvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvaryyvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvaryyvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvaryyvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvaryyvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvaryyvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvaryyvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvaryyvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvaryyvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxCombinedTextureImageUnits_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxCombinedTextureImageUnits_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxDrawBuffers_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxDrawBuffers_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxFragmentUniformVectors_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxFragmentUniformVectors_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxTextureImageUnits_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxTextureImageUnits_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVaryingVectors_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVaryingVectors_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexAttribs_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexAttribs_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexTextureImageUnits_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexTextureImageUnits_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexUniformVectors_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexUniformVectors_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/DepthRange_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/DepthRange_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CG_Data_Types_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CG_Standard_Library_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectBuiltInOveride_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectComma_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectConstFolding1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectConstFolding2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectConstruct_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectExtension10_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectExtension1_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectExtension4_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFull_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFuncOverload_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFuncOverload_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFunction1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectModule_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParse1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParse2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParse2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParseTest1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParseTest_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectPreprocess5_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectPreprocess8_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectPreprocess9_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectVersion_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/DuplicateVersion1_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/FunctionParam_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/Include_Preprocessor_Directive_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/Low_Level_Assembly_Reserved_Words_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/Main_Parameters_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/ParseTest3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/ParseTest4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/Permissive_Constant_Conversions_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/Permissive_Scalar_Vector_Expressions_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/TernaryOp_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/Texture_Rectangle_Samplers_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array10_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array11_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array5_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array7_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array8_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/array9_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/break_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/comment_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/conditional1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/conditional2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/conditional3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/constFunc_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/constructor1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/constructor2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/constructor3_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/continue_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType10_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType11_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType12_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType13_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType19_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType5_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType7_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType8_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType9_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/default.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/default.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dowhile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/dvec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension2_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension3_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension5_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension6_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension7_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension8_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension9_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/float2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/float3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/float4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function10_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function2_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function7_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function8_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/function9_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/hvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/hvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/hvec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/identifier1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/identifier2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/identifier3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/if1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/if2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/main1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/main2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/main3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/matrix_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/normal_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser10_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser5_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser7_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser8_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser9_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess0_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess10_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess7_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/scoping1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/scoping2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct10_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct11_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct5_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct6_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct7_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct8_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct9_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/swizzle1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/swizzle2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/swizzle3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/typecast_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/uniform1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/uniform_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/vector_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/version2_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/version3_V100_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/vertexOnly2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/vertexOnly_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/vertex_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/while1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/while2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/build/while_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/gl_Color_array_index_out_of_bounds_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_frag_xvary_yconstquarter.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_frag_xvary_yconstquarter_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_vert_xvary_yconstquarter.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_vert_xvary_yconstquarter_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_frag_xvary_yconstquarter.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_frag_xvary_yconstquarter_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_vert_xvary_yconstquarter.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_vert_xvary_yconstquarter_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_frag_xvary_yconstquarter.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_frag_xvary_yconstquarter_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_vert_xvary_yconstquarter.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_vert_xvary_yconstquarter_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_break_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_break_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_continue_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_continue_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_break_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_break_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_continue_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_continue_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/nested_if_else_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/nested_if_else_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_frag_xvaryyconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_frag_xvaryyconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_vert_xvaryyconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_vert_xvaryyconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/default.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/default.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_textured.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_textured.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/default/expected.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_cond_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_cond_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_frag_xvaryyhalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_frag_xvaryyhalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_vert_xvaryyhalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_vert_xvaryyhalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_frag_xvaryyhalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_frag_xvaryyhalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_vert_xvaryyhalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_vert_xvaryyhalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_frag_xvaryyhalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_frag_xvaryyhalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_vert_xvaryyhalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_vert_xvaryyhalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_frag_xvaryyone.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_frag_xvaryyone_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_vert_xvaryyone.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_vert_xvaryyone_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_frag_xvaryyhalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_frag_xvaryyhalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_vert_xvaryyhalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_vert_xvaryyhalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_frag_xvaryythird.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_frag_xvaryythird_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_vert_xvaryythird.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_vert_xvaryythird_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvaryneg.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvaryneg_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvaryneg.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvaryneg_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvaryneg.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvaryneg_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvaryneg.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvaryneg_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvaryneg.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvaryneg_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvaryneg.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvaryneg_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvaryneg.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvaryneg_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvaryneg.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvaryneg_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvaryneg.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvaryneg_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvaryneg.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvaryneg_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvaryneg.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvaryneg_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvaryneg.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvaryneg_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_frag_nvaryiconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_frag_nvaryiconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_vert_nvaryiconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_vert_nvaryiconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_frag_nvaryiconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_frag_nvaryiconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_vert_nvaryiconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_vert_nvaryiconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_frag_nvaryiconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_frag_nvaryiconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_vert_nvaryiconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_vert_nvaryiconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/array_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/array_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_bigarray_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_bigarray_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_bigarray_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_bigarray_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_struct_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_struct_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_bigarray_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_bigarray_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/void_empty_empty_void_empty_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/functions/void_empty_empty_void_empty_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_w_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_xy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_xy_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_z_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_z_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_z_frag_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary01.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary01_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary01.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary01_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary01.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary01_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary01.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary01_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary01.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary01_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary01.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary01_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary01.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary01_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary01.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary01_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary01.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary01_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary01.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary01_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary01.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary01_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary01.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary01_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_copy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_copy_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_copy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_copy_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_copy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_copy_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_4float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_4float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_copy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_copy_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_3vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_3vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_9float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_9float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_copy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_copy_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_16float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_16float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_4vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_4vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_copy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_copy_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect0_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect0_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect1_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect1_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arraysimple_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arraysimple_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_frag_xvary_yconsthalf_aconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_frag_xvary_yconsthalf_aconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_vert_xvary_yconsthalf_aconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_vert_xvary_yconsthalf_aconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_frag_xvary_yconsthalf_aconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_frag_xvary_yconsthalf_aconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_vert_xvary_yconsthalf_aconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_vert_xvary_yconsthalf_aconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_frag_xvary_yconsthalf_aconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_frag_xvary_yconsthalf_aconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_vert_xvary_yconsthalf_aconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_vert_xvary_yconsthalf_aconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_frag_xvary_yconst1.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_frag_xvary_yconst1_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_vert_xvary_yconst1.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_vert_xvary_yconst1_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_frag_xvary_yconst1.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_frag_xvary_yconst1_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_vert_xvary_yconst1.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_vert_xvary_yconst1_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_frag_xvary_yconst1.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_frag_xvary_yconst1_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_vert_xvary_yconst1.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_vert_xvary_yconst1_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_x_large_y_large_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_x_large_y_large_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_vert_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/addsubtract_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/addsubtract_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/assignments_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/assignments_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/division_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/division_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/equality_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/equality_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/logical_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/logical_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/multiplicative_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/multiplicative_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixdecrement_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixdecrement_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixincrement_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixincrement_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixdecrement_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixdecrement_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixincrement_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixincrement_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/relational_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/relational_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/selection_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/selection_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/unary_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/operators/unary_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconst2_yvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconst2_yvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconsthalf_yvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconsthalf_yvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconst2.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconst2_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconst2_yvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconst2_yvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconsthalf_yvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconsthalf_yvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconst2.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconst2_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconst2_yvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconst2_yvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconsthalf_yvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconsthalf_yvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconst2.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconst2_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconst2_yvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconst2_yvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconsthalf_yvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconsthalf_yvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconst2.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconst2_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconst2_yvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconst2_yvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconsthalf_yvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconsthalf_yvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconst2.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconst2_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconst2_yvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconst2_yvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconsthalf_yvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconsthalf_yvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconst2.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconst2_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_frag_ivarynconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_frag_ivarynconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_vert_ivarynconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_vert_ivarynconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_frag_ivarynconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_frag_ivarynconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_vert_ivarynconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_vert_ivarynconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_frag_ivarynconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_frag_ivarynconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_vert_ivarynconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_vert_ivarynconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_frag_ivarynconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_frag_ivarynconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_vert_ivarynconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_vert_ivarynconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_frag_ivarynconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_frag_ivarynconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_vert_ivarynconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_vert_ivarynconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_frag_ivarynconst.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_frag_ivarynconst_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_vert_ivarynconst.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_vert_ivarynconst_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_frag_xvary_edgeconstquarter.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_frag_xvary_edgeconstquarter_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_vert_xvary_edgeconstquarter.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_vert_xvary_edgeconstquarter_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_frag_xvary_edgeconstquarter.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_frag_xvary_edgeconstquarter_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_vert_xvary_edgeconstquarter.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_vert_xvary_edgeconstquarter_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_frag_xvary_edgeconstquarter.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_frag_xvary_edgeconstquarter_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_vert_xvary_edgeconstquarter.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_vert_xvary_edgeconstquarter_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_frag_xvary_edgeconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_frag_xvary_edgeconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_vert_xvary_edgeconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_vert_xvary_edgeconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_frag_xvary_edgeconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_frag_xvary_edgeconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_vert_xvary_edgeconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_vert_xvary_edgeconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_frag_xvary_edgeconsthalf.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_frag_xvary_edgeconsthalf_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_vert_xvary_edgeconsthalf.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_vert_xvary_edgeconsthalf_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/nestedstructcomb_various_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/nestedstructcomb_various_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bool_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bool_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bvec2bvec3bvec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bvec2bvec3bvec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bool_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bool_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bvec2bvec3bvec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bvec2bvec3bvec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bool_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bool_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bvec2bvec3bvec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bvec2bvec3bvec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_bgr_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_bgr_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_br_g_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_br_g_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_gb_r_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_gb_r_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_grb_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_grb_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_ps_t_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_ps_t_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_pts_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_pts_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rb_g_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rb_g_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rg_b_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rg_b_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rgb_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rgb_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_sp_t_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_sp_t_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_st_p_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_st_p_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_stp_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_stp_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tp_s_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tp_s_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tsp_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tsp_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xy_z_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xy_z_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xyz_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xyz_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xz_y_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xz_y_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yxz_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yxz_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yz_x_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yz_x_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zx_y_1vec2_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zx_y_1vec2_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zyx_1vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zyx_1vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ar_bg_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ar_bg_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arb_g_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arb_g_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arbg_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arbg_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_bar_g_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_bar_g_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_barg_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_barg_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_br_ag_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_br_ag_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gr_ab_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gr_ab_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gra_b_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gra_b_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_grab_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_grab_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqs_t_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqs_t_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqst_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqst_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ps_qt_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ps_qt_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qs_pt_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qs_pt_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qsp_t_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qsp_t_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qspt_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qspt_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_r_g_b_a_4float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_r_g_b_a_4float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rg_ba_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rg_ba_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgb_a_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgb_a_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgba_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgba_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_s_t_p_q_4float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_s_t_p_q_4float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_st_pq_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_st_pq_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stp_q_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stp_q_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stpq_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stpq_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ts_qp_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ts_qp_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsq_p_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsq_p_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsqp_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsqp_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wx_zy_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wx_zy_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxz_y_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxz_y_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxzy_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxzy_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_x_y_z_w_4float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_x_y_z_w_4float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xy_zw_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xy_zw_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyz_w_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyz_w_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyzw_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyzw_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yx_wz_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yx_wz_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxw_z_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxw_z_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxwz_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxwz_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwx_y_1vec3_1float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwx_y_1vec3_1float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwxy_1vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwxy_1vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zx_wy_2vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zx_wy_2vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_frag_xvary.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_frag_xvary_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_vert_xvary.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_vert_xvary_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/bvec4_2int_2float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/bvec4_2int_2float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/ivec3_3int_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/ivec3_3int_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_2float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_2float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_vec3_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_vec3_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_float_vec2_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_float_vec2_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec2_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec2_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_ivec4_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_ivec4_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_vec3_float_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_vec3_float_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3array_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3array_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arraydirect_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arraydirect_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arrayindirect_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arrayindirect_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3single_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3single_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/compressed_paletted_texture/compressed_paletted_texture.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/compressed_paletted_texture/compressed_paletted_texture.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default_textured.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default_textured.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dx.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dx.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dy.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dy.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dx.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dx.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dy.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dy.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_multitexturing.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_multitexturing.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_pointSize.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_pointSize.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/copy_texture/copy_texture.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default_textured.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default_textured.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse_ref.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse_ref.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_rasterization/point_rasterization.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_rasterization/point_rasterization.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_sprites/point_sprites.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_sprites/point_sprites.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/user_clip_planes/user_clip_planes.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/user_clip_planes/user_clip_planes.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/unsuccessfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/unsuccessfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/bind_attribute_location/brick.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/bind_attribute_location/brick.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/brick.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/texture.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/wood.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/wood.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/delete_object/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/delete_object/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/detach_shader/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/detach_shader/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/framebuffer_objects/fboShader0.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/framebuffer_objects/fboShader0.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_mat2.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_mat3.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_mat4.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_vec.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_uniform/brick.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_uniform/brick.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_attribute_location/brick.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_attribute_location/brick.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_handle/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_handle/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_uniform_location/brick.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_uniform_location/brick.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramInfoLog_2.0/simple.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramInfoLog_2.0/simple.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramiv_2.0/brick.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramiv_2.0/brick.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetShaderInfoLog_2.0/simple.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetShaderInfoLog_2.0/simple.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/bvec_tests.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/bvec_tests.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/ivec_tests.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/ivec_tests.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/mat_tests.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/mat_tests.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/vec_tests.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/vec_tests.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetVertexAttrib/mat_tests.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetVertexAttrib/mat_tests2.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetVertexAttrib/vec_tests.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1b_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1b_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1b_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1f_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1f_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1i_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1i_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/21f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/21i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/22f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/22i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/23f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/23i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/24f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/24i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2b_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2b_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2b_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2f_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2f_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2i_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2i_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2m_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3b_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3b_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3b_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3f_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3f_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3i_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3i_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3m_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_firstthree_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_firstthree_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_lastthree_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_lastthree_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4f_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4f_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4i_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4i_vert.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4i_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4m_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/default.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2VSU.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2VSU.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2arrayVSU.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2arrayVSU.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrixVSU.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrixVSU.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/unsuccessfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/unsuccessfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/precision_specifiers/precision_specifiers.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/precision_specifiers/precision_specifiers.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/relink_program/simple.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/relink_program/simple.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/unsuccessfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/unsuccessfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/three_uniforms/4f_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/unsuccessfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/unsuccessfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/successfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/successfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/unsuccessfulcompile_frag.frag: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/unsuccessfulcompile_vert.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/vertex_program_point_size/point_size.vert: Added.
- webgl/resources/webgl_test_files/conformance/ogles/ogles-utils.js: Added.
(OpenGLESTestRunner):
(OpenGLESTestRunner.):
- 10:22 AM Changeset in webkit [142006] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Check for a valid range object before using it
https://bugs.webkit.org/show_bug.cgi?id=109058
Reviewed by Rob Buis.
PR291394
Crash occurs if makeRange returns null, since we are using this value without checking
its validity. We had an assert before which I'm replacing with just a check for null.
Internally reviewed by Mike Fenton.
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):
- 10:15 AM Changeset in webkit [142005] by
-
- 12 edits2 adds in trunk
[GStreamer] MediaPlayer's code is not easily reusable by other GStreamer-based players
https://bugs.webkit.org/show_bug.cgi?id=100261
.:
Patch by Jonathon Jongsma <jonathon.jongsma@collabora.com> on 2013-02-06
Reviewed by Philippe Normand
- configure.ac: removed farstream requirement for now since it's
not actually used yet and makes it more difficult to build and test
Source/WebCore:
Refactor the media player implementation so that more of the
internal functionality can be shared between the current media
backend and the mediastream player backend. Common code is
broken out into a MediaPlayerPrivateGStreamerBase class, and
both MediaPlayerPrivateGStreamer and
StreamMediaPlayerPrivateGStreamer inherit from this base class.
Patch by Jonathon Jongsma <jonathon.jongsma@collabora.com> on 2013-02-06
Reviewed by Philippe Normand
No new tests since functionality is covered by existing media tests
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- Target.pri:
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:
(WebCore::FullscreenVideoControllerGStreamer::create):
(WebCore::FullscreenVideoControllerGStreamer::FullscreenVideoControllerGStreamer):
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h:
(WebCore):
(FullscreenVideoControllerGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Added.
(WebCore):
(WebCore::greatestCommonDivisor):
(WebCore::mediaPlayerPrivateVolumeChangedCallback):
(WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback):
(WebCore::mediaPlayerPrivateMuteChangedCallback):
(WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback):
(WebCore::mediaPlayerPrivateRepaintCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::setVolume):
(WebCore::MediaPlayerPrivateGStreamerBase::volume):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfVolumeChange):
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::readyState):
(WebCore::MediaPlayerPrivateGStreamerBase::sizeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::setSize):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::enterFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::exitFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::platformMedia):
(WebCore::MediaPlayerPrivateGStreamerBase::movieLoadType):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::audioDecodedByteCount):
(WebCore::MediaPlayerPrivateGStreamerBase::videoDecodedByteCount):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Added.
(WebCore):
(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::supportsMuting):
(WebCore::MediaPlayerPrivateGStreamerBase::setVisible):
(WebCore::MediaPlayerPrivateGStreamerBase::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivateGStreamerBase::maxTimeLoaded):
(WebCore::MediaPlayerPrivateGStreamerBase::canEnterFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::mediaPlayer):
(WebCore::MediaPlayerPrivateGStreamerBase::audioSink):
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:
(WebCore::FullscreenVideoControllerGtk::FullscreenVideoControllerGtk):
- platform/graphics/gtk/FullscreenVideoControllerGtk.h:
(FullscreenVideoControllerGtk):
- 9:50 AM Changeset in webkit [142004] by
-
- 21 edits in trunk/Source
Call XSSAuditor's didBlockScript() for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108726
Reviewed by Adam Barth.
Source/WebCore:
This patch causes us to call didBlockScript() on the main thread if the CompactHTML token has XSSInfo.
To do so, we:
- Rename DidBlockScriptRequest to XSSInfo.
- Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
- Add an isSafeToSendToAnotherThread() method to String and KURL.
We don't yet populate didBlockScriptRequest on the background thread, but this should just work once we do.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer): Update comment for rename.
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken): Add a copy constructor used by Vector.
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread): Include new m_xssInfo field in safety check.
(WebCore):
(WebCore::CompactHTMLToken::xssInfo): Added.
(WebCore::CompactHTMLToken::setXSSInfo): Added.
- html/parser/CompactHTMLToken.h: Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
(WebCore):
(CompactHTMLToken):
(WTF): Add VectorTraits necessary for copying Vector fields objects that contain an OwnPtr.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser): Add new didBlockScript() call.
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/XSSAuditor.cpp: Renaming.
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h: Renaming.
(WebCore):
(XSSAuditor):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSInfo::isSafeToSendToAnotherThread):
(WebCore):
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
(XSSAuditorDelegate):
- platform/KURL.cpp:
(WebCore::KURL::isSafeToSendToAnotherThread): Added.
(WebCore):
- platform/KURL.h:
(KURL):
- platform/KURLGoogle.cpp:
(WebCore):
(WebCore::KURLGooglePrivate::isSafeToSendToAnotherThread): Added.
- platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
- platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::isSafeToSendToAnotherThread): Added.
Source/WTF:
This patch adds isSafeToSendToAnotherThread() methods to CString, String, ParsedURL and URLString.
These methods check to ensure there are 0 or 1 references.
- wtf/text/CString.cpp:
(WTF::CString::isSafeToSendToAnotherThread): Added.
(WTF):
- wtf/text/CString.h:
(CString):
- wtf/text/WTFString.cpp:
(WTF::String::isSafeToSendToAnotherThread): Added.
(WTF):
- wtf/text/WTFString.h:
(String):
- wtf/url/api/ParsedURL.h:
(WTF::ParsedURL::isSafeToSendToAnotherThread): Added.
- wtf/url/api/URLString.h:
(WTF::URLString::isSafeToSendToAnotherThread): Added.
- 9:27 AM Changeset in webkit [142003] by
-
- 9 edits in trunk
Minor updates to captions menu UI
https://bugs.webkit.org/show_bug.cgi?id=109005
Reviewed by Eric Carlson.
Now that we only have a single section in the captions menu, remove the
unnecessary wrapper element. Also update the UI for Mac so that the menu
grows in size dynamically, and change the text we display for a caption
that has neither label or language identifiers.
Covered by existing tests.
- English.lproj/Localizable.strings: New string for an unknown caption label.
- css/fullscreenQuickTime.css: New rules for the captions menu.
(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
(video:-webkit-full-screen::-webkit-media-controls-closed-captions-track-list):
- css/mediaControlsQuickTime.css: Ditto.
(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-track-list):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
Remove the <section> element container.
- platform/LocalizedStrings.cpp:
(WebCore::textTrackNoLabelText): New string for an unknown caption label.
LayoutTests:
A caption track without a label or language is now given the menu
title 'Unknown'. Note also that the test includes some intentional
failure text.
- media/video-controls-captions-trackmenu-localized.html:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- 8:20 AM Changeset in webkit [142002] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][Win] Fix build after MessageID.h related changes and after r141619.
https://bugs.webkit.org/show_bug.cgi?id=108612
Patch by Simon Hausmann <simon.hausmann@digia.com>, Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-06
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
- Platform/WorkQueue.h:
(WorkQueue::WorkItemWin::queue):
(WorkItemWin):
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::decode):
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::handleCallback):
(WorkQueue::performWorkOnRegisteredWorkThread):
- 8:10 AM Changeset in webkit [142001] by
-
- 5 edits3 adds in trunk/LayoutTests
[Chromium] Test expectations update for Skia change.
Unreviewed expectations update
- platform/chromium-mac/fast/writing-mode/japanese-lr-text-expected.png:
- platform/chromium-mac/fast/writing-mode/japanese-lr-text-expected.txt: Added.
- platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png:
- platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
- platform/chromium-mac/fast/writing-mode/japanese-rl-text-expected.png:
- platform/chromium-mac/fast/writing-mode/japanese-rl-text-expected.txt: Added.
- platform/chromium/TestExpectations:
- 7:52 AM Changeset in webkit [142000] by
-
- 11 edits in trunk
Source/WebCore: Web Inspector: Remove isSnippet field from FileDescriptor and UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=109045
Reviewed by Pavel Feldman.
Snippets are now distinguished based on uiSourceCode project.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):
- inspector/front-end/NavigatorView.js:
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._navigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.rename):
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
- inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.Project.prototype._fileAdded):
LayoutTests: Web Inspector: Remove isSnippet field from FileDescriptor and UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=109045
Reviewed by Pavel Feldman.
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-sorting.html:
- 7:50 AM Changeset in webkit [141999] by
-
- 7 edits in trunk/Source/WebCore
Unreviewed, rolling out r141983.
http://trac.webkit.org/changeset/141983
https://bugs.webkit.org/show_bug.cgi?id=109055
lots of new crashes in handlescope (Requested by gavinp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8GCController.cpp:
(WebCore::WrapperVisitor::WrapperVisitor):
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 6:43 AM Changeset in webkit [141998] by
-
- 31 edits3 deletes in trunk/Tools
Unreviewed, rolling out r141991.
http://trac.webkit.org/changeset/141991
https://bugs.webkit.org/show_bug.cgi?id=109047
Fails to compile on all Chromium platforms (Requested by
schenney on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
(WebTaskList):
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(MockGrammarCheck::checkGrammarOfString):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- 6:43 AM Changeset in webkit [141997] by
-
- 2 edits in trunk/Source/WebKit/chromium
Add Skia code suppression flags to WebKit skia.gyp
Unreviewed.
This is step one in removing these flags. First we get them into
WebKit, then we can remove them from Chrome.
- skia_webkit.gyp:
- 6:32 AM Changeset in webkit [141996] by
-
- 3 edits in trunk/Tools
Unreviewed, rolling out r141995.
http://trac.webkit.org/changeset/141995
https://bugs.webkit.org/show_bug.cgi?id=109046
May allow me to roll out the real problem (Requested by
schenney on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::sendWebIntentResponse):
(WebTestRunner::TestRunner::deliverWebIntent):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
- 6:06 AM Changeset in webkit [141995] by
-
- 3 edits in trunk/Tools
[chromium] fix android build which doesn't support intents
Unreviewed build fix.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::sendWebIntentResponse):
(WebTestRunner::TestRunner::deliverWebIntent):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
- 5:37 AM Changeset in webkit [141994] by
-
- 2 edits in trunk/LayoutTests
[WK2] New tests introduced in r100895 fail
https://bugs.webkit.org/show_bug.cgi?id=73913
Patch by Marja Hölttä <marja@chromium.org> on 2013-02-06
Reviewed by Jochen Eisinger.
The tests now work, because WTR supports HTTPS tests.
- platform/wk2/TestExpectations:
- 5:32 AM Changeset in webkit [141993] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing WebGl test.
- platform/qt/TestExpectations:
- 5:29 AM Changeset in webkit [141992] by
-
- 5 edits in trunk/Source
Web Inspector: Native Memory Instrumentation: assign class name to the heap graph node automatically
https://bugs.webkit.org/show_bug.cgi?id=107262
Reviewed by Yury Semikhatsky.
Source/JavaScriptCore:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Source/WTF:
We need a way to calculate class name for a pointer automatically.
Otherwise we need to write className manually in all the instrumentation methods.
And for all reported but not instrumented classes.
C++ can do that for us with help of typeid but unfortunatelly it requires rtti.
There is another way to do that. C++ preprocessor provides a define which has a function name.
For g++ and clang it is PRETTY_FUNCTION.
For MSVC it is FUNCTION.
The content of the string is a function signature.
We can use it because it has the name of the template argument.
The format is sligthly different. That's why I made two different parsers.
One for MSVC the other for GCC, Clang etc.
The other problem is the resulting binary size.
I made very simple function that does the only thing, returns the smallest possible function signature.
Unfortunatelly MSVC doesn't generate template argument name for functions.
It does this only for classes.
- wtf/MemoryInstrumentation.cpp:
(WTF):
(WTF::className):
(WTF::MemoryClassInfo::callReportObjectInfo):
(WTF::MemoryClassInfo::init):
- wtf/MemoryInstrumentation.h:
(WTF):
(WTF::FN::fn):
(WTF::fn):
(WTF::MemoryClassInfo::MemoryClassInfo):
(MemoryClassInfo):
(WTF::::reportObjectMemoryUsage):
- 5:11 AM Changeset in webkit [141991] by
-
- 31 edits3 copies in trunk/Tools
[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466
Reviewed by Adam Barth.
To achieve this, we need to drop all dependencies on WTF.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/public/WebTask.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
(AccessibilityUIElementList):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:
(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:
(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
(CppVariant):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:
(WebTestRunner::NativeKeyCodeForWindowsKeyCode):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:
(WebTestRunner):
(MockGrammarCheck):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck):
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
(isASCIIAlpha):
(isNotASCIIAlpha):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:
(TestPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
- DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
- 5:09 AM Changeset in webkit [141990] by
-
- 4 edits in trunk/Source/WebCore
Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>
Reviewed by Antti Koivisto.
Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.
If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.
4.98 MB progression on Membuster3.
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.
(WebCore::GlyphPage::setGlyphDataForIndex):
Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.
(WebCore::GlyphPage::~GlyphPage):
Free the SimpleFontData* array if needed.
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
The font data for glyph #0 is always a null pointer now.
(WebCore::GlyphPage::clearForFontData):
Updated for new storage format.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
Fix bug where non-zero glyph was temporarily associated with null font data,
which triggered the new assertion in setGlyphDataForIndex().
- 5:04 AM Changeset in webkit [141989] by
-
- 2 edits in trunk/Source/WebCore
Follow up to r141979: do not consume Home/End.
Not reviewed.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
- 5:03 AM Changeset in webkit [141988] by
-
- 7 edits in trunk
Web Inspector: Remove show script folders setting
https://bugs.webkit.org/show_bug.cgi?id=108940
Reviewed by Pavel Feldman.
Source/WebCore:
Removed showScriptFolders setting, the sources are never shown as a flat list in navigator anymore.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._getOrCreateFolderTreeElement):
- inspector/front-end/Settings.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
LayoutTests:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- 4:36 AM Changeset in webkit [141987] by
-
- 11 edits in trunk
Web Inspector: update javascriptsourcetokenizer to produce "whitespaces" token
https://bugs.webkit.org/show_bug.cgi?id=108945
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-06
Reviewed by Pavel Feldman.
Source/WebCore:
Update re2c grammar for SourceJavaScriptTokenizer to produce
"whitespace" token which holds consequtive whitespaces in it.
Updated existing tests expectations.
- inspector/front-end/DOMSyntaxHighlighter.js:
(WebInspector.DOMSyntaxHighlighter.prototype.createSpan): Do not strip spaces from tokens with class "whitespaces".
- inspector/front-end/SourceJavaScriptTokenizer.js: Regenerated.
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
LayoutTests:
Update test expectations so that they have "whitespace" token in
there.
- inspector/editor/highlighter-basics-expected.txt:
- inspector/editor/highlighter-chunk-limit-expected.txt:
- inspector/editor/highlighter-long-line.html:
- inspector/editor/text-editor-long-line-expected.txt:
- inspector/syntax-highlight-html-expected.txt:
- inspector/syntax-highlight-javascript-expected.txt:
- 4:27 AM Changeset in webkit [141986] by
-
- 4 edits in trunk
Web Inspector: refactor registerShortcuts method of DTE
https://bugs.webkit.org/show_bug.cgi?id=109031
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-06
Reviewed by Pavel Feldman.
Source/WebCore:
Implement _registerShortcuts method in TextEditorMainPanel which will
bind its private methods to the different key combinations. Refactor
method handlers handleUndoRedo, handleTabKeyPress and handleEnterKey
from public to private.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts): Remove bindings of TextEditorMainPanel methods
(WebInspector.DefaultTextEditor.prototype._handleKeyDown):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts): Added.
(WebInspector.TextEditorMainPanel.prototype._handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype.handleKeyDown):
LayoutTests:
Fix helper method to correspond to refactoring of handleUndoRedo
method.
- http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.undoSourceEditing):
(initialize_LiveEditTest):
- 4:07 AM Changeset in webkit [141985] by
-
- 19 edits in trunk
Add an ENABLE_NOSNIFF feature flag.
https://bugs.webkit.org/show_bug.cgi?id=109029
Reviewed by Jochen Eisinger.
This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
when processing script and other resource types.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 3:57 AM Changeset in webkit [141984] by
-
- 23 edits16 adds in trunk
MediaStream API: Implement DTMF support in RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=106782
Reviewed by Adam Barth.
Source/Platform:
The WebRTC specification have added support for DTMF:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#peer-to-peer-dtmf
Implementation wise this is implemented using the same pattern as RTCDataChannel;
where a RTCDTMFSenderHandler is created by the UA through a new method on
RTCPeerConnectionHandler.
- Platform.gypi:
- chromium/public/WebMediaStreamTrack.h:
(WebMediaStreamTrack):
- chromium/public/WebRTCDTMFSenderHandler.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebKit):
(WebRTCDTMFSenderHandler):
(WebKit::WebRTCDTMFSenderHandler::~WebRTCDTMFSenderHandler):
- chromium/public/WebRTCDTMFSenderHandlerClient.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebKit):
(WebRTCDTMFSenderHandlerClient):
(WebKit::WebRTCDTMFSenderHandlerClient::~WebRTCDTMFSenderHandlerClient):
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebKit::WebRTCPeerConnectionHandler::createDTMFSender):
Source/WebCore:
The WebRTC specification have added support for DTMF:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#peer-to-peer-dtmf
Implementation wise this is implemented using the same pattern as RTCDataChannel;
where a RTCDTMFSenderHandler is created by the UA through a new method on
RTCPeerConnectionHandler.
Test: fast/mediastream/RTCPeerConnection-dtmf.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCDTMFSender.cpp: Added.
(WebCore):
(WebCore::RTCDTMFSender::create):
(WebCore::RTCDTMFSender::RTCDTMFSender):
(WebCore::RTCDTMFSender::~RTCDTMFSender):
(WebCore::RTCDTMFSender::canInsertDTMF):
(WebCore::RTCDTMFSender::track):
(WebCore::RTCDTMFSender::toneBuffer):
(WebCore::RTCDTMFSender::insertDTMF):
(WebCore::RTCDTMFSender::didPlayTone):
(WebCore::RTCDTMFSender::interfaceName):
(WebCore::RTCDTMFSender::scriptExecutionContext):
(WebCore::RTCDTMFSender::stop):
(WebCore::RTCDTMFSender::eventTargetData):
(WebCore::RTCDTMFSender::ensureEventTargetData):
(WebCore::RTCDTMFSender::scheduleDispatchEvent):
(WebCore::RTCDTMFSender::scheduledEventTimerFired):
- Modules/mediastream/RTCDTMFSender.h: Added.
(WebCore):
(RTCDTMFSender):
(WebCore::RTCDTMFSender::duration):
(WebCore::RTCDTMFSender::interToneGap):
- Modules/mediastream/RTCDTMFSender.idl: Added.
- Modules/mediastream/RTCDTMFToneChangeEvent.cpp: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebCore):
(WebCore::RTCDTMFToneChangeEvent::create):
(WebCore::RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent):
(WebCore::RTCDTMFToneChangeEvent::~RTCDTMFToneChangeEvent):
(WebCore::RTCDTMFToneChangeEvent::tone):
(WebCore::RTCDTMFToneChangeEvent::interfaceName):
- Modules/mediastream/RTCDTMFToneChangeEvent.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebCore):
(RTCDTMFToneChangeEventInit):
(RTCDTMFToneChangeEvent):
- Modules/mediastream/RTCDTMFToneChangeEvent.idl: Added.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore):
(WebCore::RTCPeerConnection::getStreamByTrackId):
(WebCore::RTCPeerConnection::createDTMFSender):
- Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- WebCore.gypi:
- dom/EventNames.h:
(WebCore):
- dom/EventNames.in:
- dom/EventTargetFactory.in:
- platform/chromium/support/WebMediaStreamTrack.cpp:
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit):
- platform/mediastream/RTCDTMFSenderHandler.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebCore):
(RTCDTMFSenderHandler):
(WebCore::RTCDTMFSenderHandler::~RTCDTMFSenderHandler):
- platform/mediastream/RTCDTMFSenderHandlerClient.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebCore):
(RTCDTMFSenderHandlerClient):
(WebCore::RTCDTMFSenderHandlerClient::~RTCDTMFSenderHandlerClient):
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
- platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.cpp: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebCore):
(WebCore::RTCDTMFSenderHandlerChromium::create):
(WebCore::RTCDTMFSenderHandlerChromium::RTCDTMFSenderHandlerChromium):
(WebCore::RTCDTMFSenderHandlerChromium::~RTCDTMFSenderHandlerChromium):
(WebCore::RTCDTMFSenderHandlerChromium::setClient):
(WebCore::RTCDTMFSenderHandlerChromium::currentToneBuffer):
(WebCore::RTCDTMFSenderHandlerChromium::canInsertDTMF):
(WebCore::RTCDTMFSenderHandlerChromium::insertDTMF):
(WebCore::RTCDTMFSenderHandlerChromium::didPlayTone):
- platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(WebCore):
(RTCDTMFSenderHandlerChromium):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::createDTMFSender):
(WebCore):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):
Tools:
Adding Mock functionality for the DTMFSender.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp: Added.
(DTMFSenderToneTask):
(DTMFSenderToneTask::DTMFSenderToneTask):
(MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
(MockWebRTCDTMFSenderHandler::setClient):
(MockWebRTCDTMFSenderHandler::currentToneBuffer):
(MockWebRTCDTMFSenderHandler::canInsertDTMF):
(MockWebRTCDTMFSenderHandler::insertDTMF):
- DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.
(MockWebRTCDTMFSenderHandler):
(MockWebRTCDTMFSenderHandler::taskList):
(MockWebRTCDTMFSenderHandler::clearToneBuffer):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::createDTMFSender):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
LayoutTests:
- fast/mediastream/RTCPeerConnection-dtmf-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-dtmf.html: Added.
- 3:48 AM QtWebKitGardening edited by
- (diff)
- 3:40 AM Changeset in webkit [141983] by
-
- 7 edits in trunk/Source/WebCore
[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579
Reviewed by Adam Barth.
Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.
Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).
Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.
Before:
mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms
After:
mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms
As shown above, I couldn't observe any performance regression.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):
- bindings/v8/V8Binding.h:
(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 3:32 AM Changeset in webkit [141982] by
-
- 4 edits2 adds in trunk
[CSSRegions] Assertion failure in Node::detach (!renderer renderer->inRenderFlowThread()) https://bugs.webkit.org/show_bug.cgi?id=104517
Patch by Mihai Maerean <Mihai Maerean> on 2013-02-06
Reviewed by Julien Chaffraix.
Source/WebCore:
The RenderObject::inRenderFlowThread bit could have become disconnected from the fact that the RenderObject
has (or not) an enclosing RenderFlowThread.
The cause of this was that, when setting or removing the parent of a RenderObject, the inRenderFlowThread flags
wasn't being set/reset for the children too.
This is now fixed by calling the new setInRenderFlowThreadIncludingDescendants.
The ASSERT was hit for anonymous blocks when detaching the document.
Test: fast/regions/detaching-regions-with-anonymous-blocks.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setInRenderFlowThreadRecursive):
(WebCore):
- rendering/RenderObject.h:
(WebCore::RenderObject::setParent):
(RenderObject):
LayoutTests:
The test adds an anonymous block in a region and detaches the body of document. The ASSERT is not hit anymore.
- fast/regions/detaching-regions-with-anonymous-blocks-expected.txt: Added.
- fast/regions/detaching-regions-with-anonymous-blocks.html: Added.
- 3:24 AM Changeset in webkit [141981] by
-
- 35 edits in trunk
Take referrer policy into account when clearing the referrer header
https://bugs.webkit.org/show_bug.cgi?id=86000
Patch by Marja Hölttä <marja@chromium.org> on 2013-02-06
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The referrer should only be cleared when doing a https -> http redirect,
if the policy is "default". Otherwise the referrer should be left intact.
In order to do that, added a function for checking the policy in
NetworkingContext, and stored the NetworkingContext in ResourceHandle
(like some ports already did).
No new tests (unskipped old tests).
- loader/FrameNetworkingContext.h:
(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect):
(FrameNetworkingContext):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
- platform/network/NetworkingContext.h:
(NetworkingContext):
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::context):
(WebCore):
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::context):
(WebCore):
(WebCore::ResourceHandle::start):
- platform/network/chromium/ResourceHandleInternal.h:
(WebCore):
(ResourceHandleInternal):
(WebCore::ResourceHandleInternal::context):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::redirect):
- platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):
(WebCore::ResourceHandle::start):
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
Source/WebKit2:
The referrer should only be cleared when doing a https -> http redirect,
if the policy is "default". Otherwise the referrer should be left intact.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
- NetworkProcess/SchedulableLoader.h:
(WebKit::SchedulableLoader::shouldClearReferrerOnHTTPSToHTTPRedirect):
(SchedulableLoader):
- NetworkProcess/SyncNetworkResourceLoader.cpp:
(WebKit::SyncNetworkResourceLoader::start):
- NetworkProcess/mac/RemoteNetworkingContext.h:
(WebKit::RemoteNetworkingContext::create):
(RemoteNetworkingContext):
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect):
(WebKit):
(WebKit::RemoteNetworkingContext::RemoteNetworkingContext):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::shouldClearReferrerOnHTTPSToHTTPRedirect):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- WebProcess/Network/WebResourceLoadScheduler.h:
(WebResourceLoadScheduler):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
LayoutTests:
Unskip http/tests/security/referrer-policy-redirect-link.html
Skipping the tests on wk2, because other referrer policy tests are
skipped, too ( https://bugs.webkit.org/show_bug.cgi?id=73913 ).
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wk2/TestExpectations:
- 2:27 AM Changeset in webkit [141980] by
-
- 2 edits11 deletes in trunk/LayoutTests
[Qt] Unskip working filter tests.
Unreviewed gardening
These tests work if we remove our failure expecting baselines.
- platform/qt/TestExpectations:
- platform/qt/css3/filters/filter-animation-expected.png: Removed.
- platform/qt/css3/filters/filter-animation-expected.txt: Removed.
- platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
- platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-expected.png: Removed.
- platform/qt/css3/filters/filter-property-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
- platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
- platform/qt/css3/filters/filter-repaint-expected.png: Removed.
- platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
- 2:11 AM Changeset in webkit [141979] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: file selector list jumps as I type or move Up/Down
https://bugs.webkit.org/show_bug.cgi?id=108933
Reviewed by Vsevolod Vlasov.
Missing return was scheduling extra updates.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
- 1:54 AM Changeset in webkit [141978] by
-
- 13 edits1 delete in trunk/Source/WebKit2
[EFL][WK2] Encapsulate Ewk View evas smart object code inside EwkView class
https://bugs.webkit.org/show_bug.cgi?id=108062
Reviewed by Kenneth Rohde Christiansen.
The Ewk View implementation is encapsulated within EwkView class.
Besides multiple refactoring of Ewk View evas smart object code was made.
- UIProcess/API/C/efl/WKView.cpp:
(createWKView):
Aux function to share WKView creation implementation.
- UIProcess/API/efl/EwkView.cpp:
(smartDataChanged):
(defaultSmartClassInstance):
(toSmartData):
(EwkView::initSmartClassInterface):
(EwkView::toEvasObject):
(EwkView::smartData):
Renamed and moved here from ewk_view.
(EwkViewEventHandler):
(EwkViewEventHandler::subscribe):
(EwkViewEventHandler::unsubscribe):
(::handleEvent):
Added a new template class to encapsulate Ewk View Evas events handling.
(EwkView::EwkView):
(EwkView::~EwkView):
Constructor and desctructor are private.
(EwkView::createEvasObject):
Added factory function for ewk view evas objects creation.
(EwkView::handleEvasObjectAdd):
(EwkView::handleEvasObjectDelete):
(EwkView::handleEvasObjectResize):
(EwkView::handleEvasObjectMove):
(EwkView::handleEvasObjectCalculate):
(EwkView::handleEvasObjectShow):
(EwkView::handleEvasObjectHide):
(EwkView::handleEvasObjectColorSet):
Evas_Smart_Class interface callbacks moved into the EwkView class.
(EwkView::handleEwkViewFocusIn):
(EwkView::handleEwkViewFocusOut):
(EwkView::handleEwkViewMouseWheel):
(EwkView::handleEwkViewMouseDown):
(EwkView::handleEwkViewMouseUp):
(EwkView::handleEwkViewMouseMove):
(EwkView::handleEwkViewKeyDown):
(EwkView::handleEwkViewKeyUp):
Ewk_View_Smart_Class interface callback moved into the EwkView class.
(EwkView::handleTouchDown):
(EwkView::handleTouchUp):
(EwkView::handleTouchMove):
Renamed.
(toEwkView):
Aux function to get the EwkView instance fromevas object.
(isViewEvasObject):
Aux function to check that given evas object is ewk view.
- UIProcess/API/efl/EwkView.h:
(EwkView::evasObject):
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_smart_class_set):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_feed_touch_event):
(Ewk_Page_Contents_Context):
- UIProcess/API/efl/ewk_view_private.h: Removed.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewCreate):
(WKViewCreateWithFixedLayout):
(WKViewCreateSnapshot):
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate):
- UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
(WebKit::ContextHistoryClientEfl::didPerformClientRedirect):
(WebKit::ContextHistoryClientEfl::didPerformServerRedirect):
(WebKit::ContextHistoryClientEfl::didUpdateHistoryTitle):
- UIProcess/efl/PageClientBase.cpp:
(WebKit::PageClientBase::processDidCrash):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
- UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):
Updated due to changes in EwkView interface.
- 12:58 AM Performance Tests edited by
- Small typo fix. (diff)
- 12:55 AM Changeset in webkit [141977] by
-
- 19 edits in trunk/Source/WebCore
[V8] Pass an Isolate to remaining GetTemplate()s
https://bugs.webkit.org/show_bug.cgi?id=109001
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheck): Because this method is a callback from V8,
we cannot change its signature to receive an Isolate.
(WebCore::V8DOMWindow::indexedSecurityCheck): Ditto.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::createWrapper):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::createWrapper):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::createWrapper):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::createWrapper):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::createWrapper):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::createWrapper):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::createWrapper):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::createWrapper):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::createWrapper):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::createWrapper):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::createWrapper):
- bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
- 12:30 AM EFLWebKitBuildBots edited by
- Update my email information. (diff)
- 12:27 AM Changeset in webkit [141976] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r141961.
http://trac.webkit.org/changeset/141961
https://bugs.webkit.org/show_bug.cgi?id=109019
assertion failures on svn tests such as fonts-glyph-04-t.svg
(Requested by falken on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::create):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(GlyphPage):
(WebCore::GlyphPage::copyFrom):
(WebCore::GlyphPage::clear):
(WebCore::GlyphPage::clearForFontData):
(WebCore::GlyphPage::GlyphPage):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- 12:23 AM Changeset in webkit [141975] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my email address in committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 12:04 AM Changeset in webkit [141974] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skipping the newly-added tests in webgl/, the GTK builders are not
yet able to run these tests.
- platform/gtk/TestExpectations:
- 12:00 AM Changeset in webkit [141973] by
-
- 10 edits2 deletes in trunk/Source/WebCore
Unreviewed, rolling out r141964.
http://trac.webkit.org/changeset/141964
https://bugs.webkit.org/show_bug.cgi?id=109014
caused performance regression (Requested by hayato on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DocumentRuleSets.cpp: Removed.
- css/DocumentRuleSets.h: Removed.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::resetAuthorStyle):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::classNamesAffectedByRules):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::checkRegionStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(StyleResolver):
(WebCore::StyleResolver::usesSiblingRules):
(WebCore::StyleResolver::usesFirstLineRules):
(WebCore::StyleResolver::usesBeforeAfterRules):
(WebCore::StyleResolver::hasSelectorForAttribute):
(WebCore::StyleResolver::hasSelectorForClass):
(WebCore::StyleResolver::hasSelectorForId):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
Feb 5, 2013:
- 11:44 PM Changeset in webkit [141972] by
-
- 2 edits in trunk/Source/WebCore
Add #if USE(V8) to Node::V8CollectableDuringMinorGCFlag
https://bugs.webkit.org/show_bug.cgi?id=109009
Reviewed by Kent Tamura.
Node flags should be saved. V8CollectableDuringMinorGCFlag is used by V8 only.
- dom/Node.h:
(Node):
- 11:41 PM Changeset in webkit [141971] by
-
- 2 edits24 adds in trunk/LayoutTests
Adds the WebGL Conformance Tests attrib folder.
https://bugs.webkit.org/show_bug.cgi?id=108901
Reviewed by Kenneth Russell.
- platform/chromium/TestExpectations:
- webgl/conformance/attribs/gl-disabled-vertex-attrib-expected.txt: Added.
- webgl/conformance/attribs/gl-disabled-vertex-attrib.html: Added.
- webgl/conformance/attribs/gl-enable-vertex-attrib-expected.txt: Added.
- webgl/conformance/attribs/gl-enable-vertex-attrib.html: Added.
- webgl/conformance/attribs/gl-vertex-attrib-expected.txt: Added.
- webgl/conformance/attribs/gl-vertex-attrib-render-expected.txt: Added.
- webgl/conformance/attribs/gl-vertex-attrib-render.html: Added.
- webgl/conformance/attribs/gl-vertex-attrib-zero-issues-expected.txt: Added.
- webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html: Added.
- webgl/conformance/attribs/gl-vertex-attrib.html: Added.
- webgl/conformance/attribs/gl-vertexattribpointer-expected.txt: Added.
- webgl/conformance/attribs/gl-vertexattribpointer-offsets-expected.txt: Added.
- webgl/conformance/attribs/gl-vertexattribpointer-offsets.html: Added.
- webgl/conformance/attribs/gl-vertexattribpointer.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-disabled-vertex-attrib.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-enable-vertex-attrib.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-render.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-zero-issues.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer-offsets.html: Added.
- webgl/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer.html: Added.
- 11:07 PM Changeset in webkit [141970] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaseline navigator-detached-no-crash.html,
whose output is affected by the disabling of web intents in Chromium.
- platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
- 10:09 PM Changeset in webkit [141969] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Chromium disabled web intents.
- platform/chromium/TestExpectations:
- 9:49 PM Changeset in webkit [141968] by
-
- 2 edits3 adds1 delete in trunk/LayoutTests
[Chromium] Split calendar-picker-key-operations.html into two
https://bugs.webkit.org/show_bug.cgi?id=109006
Reviewed by Kentaro Hara.
Split calendar-picker-key-operations.html into two parts:
- OS-independent part (calendar-picker-key-operations.html), and
- OS-dependent part (calendar-picker-f4-key.html).
We had some troubles when we updated calendar-picker-key-operations.html
because the behavior by F4 key is OS-dependent. We move the test for F4
key to new test.
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key-expected.txt:
Added. It is expected that this contains FAIL line because we don't
support the F4 key behavior on OSX.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
Removed. Now the result of calendar-picker-key-operations.html is OS-independent.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key.html:
Added. Move from calendar-picker-key-operations.html.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
Move the F4 key part to calendar-picker-f4-key.html.
- 9:16 PM Changeset in webkit [141967] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add ending slashes automatically to file mappings.
https://bugs.webkit.org/show_bug.cgi?id=108936
Reviewed by Pavel Feldman.
- inspector/front-end/SettingsScreen.js:
(WebInspector.WorkspaceSettingsTab.prototype._addFileMappingClicked):
- 9:12 PM Changeset in webkit [141966] by
-
- 10 edits in trunk/Source/WebCore
More updates to Caption user preferences
https://bugs.webkit.org/show_bug.cgi?id=108997
Reviewed by Dean Jackson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::captionPreferencesChanged): Give the media controls a chance
to update for a preferences change.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Add optional "force update"
param to force font size recalc even when the video size hasn't changed.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): New, force a font size recalc.
- html/shadow/MediaControls.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Don't set width/size of cues
that use default positioning. Use "start" as the default alignment.
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Set padding when the window is visible
so it shows around the cue background.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Set padding to 0 when the background
is visible.
(WebCore::CaptionUserPreferencesMac::windowRoundedCornerRadiusCSS): Add "px" to the border radius
so it actually works.
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::layout): Special case generic cues with default style.
(WebCore::RenderTextTrackCue::repositionGenericCue):
- rendering/RenderTextTrackCue.h:
- 8:30 PM Changeset in webkit [141965] by
-
- 2 edits in trunk/Source/WTF
Fix EnumClass so that it can be used with switch statements.
https://bugs.webkit.org/show_bug.cgi?id=109004.
Reviewed by Sam Weinig.
- wtf/EnumClass.h:
(WTF::EnumClass::operator==):
(WTF::EnumClass::operator!=):
(WTF::EnumClass::operator<):
(WTF::EnumClass::operator<=):
(WTF::EnumClass::operator>):
(WTF::EnumClass::operator>=):
(EnumClass):
(WTF::EnumClass::operator Value):
- 8:28 PM Changeset in webkit [141964] by
-
- 10 edits2 adds in trunk/Source/WebCore
Split each RuleSet and feature out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107777
Reviewed by Dimitri Glazkov.
Splitting each RuleSet and feature out from StyleResover into its onw class, DocumentRuleSets,
to manage them separately.
This is one of the attempts to try to resolve meta bug (bug 89879)
to lose StyleResolver's weight. We need further action to factor
StyleResolver to separate it into some classes cleanly.
See also https://bugs.webkit.org/show_bug.cgi?id=108890. A following patch will address that.
No tests. No change in behavior.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DocumentRuleSets.cpp: Added.
(WebCore):
(WebCore::DocumentRuleSets::DocumentRuleSets):
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle): New helper to initialize each RuleSets.
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets): Factored out from StyleResolver.
(WebCore::makeRuleSet): Ditto.
(WebCore::DocumentRuleSets::resetAuthorStyle): Ditto.
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Ditto.
(WebCore::DocumentRuleSets::collectFeatures): Ditto.
(WebCore::DocumentRuleSets::reportMemoryUsage): New methods to report memory usage. Factored out from StyleResolver.
- css/DocumentRuleSets.h: Added.
(WebCore):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::authorStyle): Moved from StyleResolver.
(WebCore::DocumentRuleSets::userStyle): Ditto.
(WebCore::DocumentRuleSets::features): Ditto.
(WebCore::DocumentRuleSets::sibling): Ditto.
(WebCore::DocumentRuleSets::uncommonAttribute): Ditto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets): Now calls DocumentRuleSets::appendAuthorStyleSheets.
(WebCore::StyleResolver::matchAuthorRules): Use m_ruleSets.
(WebCore::StyleResolver::matchUserRules): Ditto.
(WebCore::StyleResolver::classNamesAffectedByRules): Ditto.
(WebCore::StyleResolver::locateCousinList): Ditto.
(WebCore::StyleResolver::canShareStyleWithElement): Ditto.
(WebCore::StyleResolver::locateSharedStyle): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::checkRegionStyle): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::reportMemoryUsage): Now calls DocumentRuleSets::reportMemoryUsage.
- css/StyleResolver.h:
(WebCore::StyleResolver::scopeResolver):
(StyleResolver):
(WebCore::StyleResolver::ruleSets): accessor r to DocumentRuleSets.
(WebCore::StyleResolver::usesSiblingRules): Use m_ruleSets.
(WebCore::StyleResolver::usesFirstLineRules): Ditto.
(WebCore::StyleResolver::usesBeforeAfterRules): Ditto.
(WebCore::StyleResolver::hasSelectorForAttribute): Ditto.
(WebCore::StyleResolver::hasSelectorForClass): Ditto.
(WebCore::StyleResolver::hasSelectorForId): Ditto.
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- 7:01 PM Changeset in webkit [141963] by
-
- 5 edits2 adds in trunk
[CSS Grid Layout] Grid item's logical height is not properly recomputed after -webkit-grid-column / -webkit-grid-row changes
https://bugs.webkit.org/show_bug.cgi?id=108975
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-grid-layout/implicit-position-dynamic-change.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::clearContainingBlockOverrideSize):
(WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight):
- rendering/RenderBox.h:
Added clearOverrideContainingBlockContentLogicalHeight and updated clearContainingBlockOverrideSize
to use it.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Added missing clearContainingBlockOverrideSize to ensure we don't use a previous layout's override.
LayoutTests:
- fast/css-grid-layout/implicit-position-dynamic-change-expected.txt: Added.
- fast/css-grid-layout/implicit-position-dynamic-change.html: Added.
- 6:53 PM Changeset in webkit [141962] by
-
- 4 edits in trunk/Source/JavaScriptCore
put_to_base should emit a Phantom for "value" across the ForceOSRExit
https://bugs.webkit.org/show_bug.cgi?id=108998
Reviewed by Oliver Hunt.
Otherwise, the OSR exit compiler could clobber it, which would lead to badness.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites): Build fixes for when DFG debug logging is enabled.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): Added extra Phantoms for the "value" field where needed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile): Ditto.
- 6:48 PM Changeset in webkit [141961] by
-
- 3 edits in trunk/Source/WebCore
Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>
Reviewed by Antti Koivisto.
Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.
If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.
4.98 MB progression on Membuster3.
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.
(WebCore::GlyphPage::setGlyphDataForIndex):
Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.
(WebCore::GlyphPage::~GlyphPage):
Free the SimpleFontData* array if needed.
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
The font data for glyph #0 is always a null pointer now.
(WebCore::GlyphPage::clearForFontData):
Updated for new storage format.
- 6:34 PM Changeset in webkit [141960] by
-
- 10 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Read-only inputs should be focusable
https://bugs.webkit.org/show_bug.cgi?id=108795
Reviewed by Kentaro Hara.
Source/WebCore:
According to the standard [1], readonly form controls should be focusable.
- Sub-fields should be focusable if they are read-only. We should check isDisabled mainly.
- All keyboard operations should not be handled if a field is disabled, and focus navigation keyboard operations should be handled even if a field is read-only.
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-readonly-attribute
No new tests. Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
for the new behavior.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make <input> focusable even if it is read-only.
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::isFieldOwnerDisabled):
Separate isFieldOwnerDisabledOrReadOnly into two.
(WebCore::DateTimeEditElement::isFieldOwnerReadOnly): Ditto.
(WebCore::DateTimeEditElement::updateUIState):
We don't need to focus out if this is read-only.
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Separate isFieldOwnerDisabledOrReadOnly into two.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::defaultEventHandler):
Skip handleKeyboardEvent if the field is disabled or the owner input is
disabled or read-only. handleKeyboardEvent handles editing key
operations.
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
If this field is disabled or the owner input is disabled, all keyboard
inputs are ignored.
If this field is read-only, we handle only left and right arrows to
change focus, and skip down/up/backspace/del keys.
(WebCore::DateTimeFieldElement::isFieldOwnerDisabled):
A helper function to check disable state of the owner input.
(WebCore::DateTimeFieldElement::isFieldOwnerReadOnly):
A helper function to check read-only state of the owner input.
(WebCore::DateTimeFieldElement::isFocusable):
This field should be focusable if it is read-only and not disabled.
- html/shadow/DateTimeFieldElement.h:
(FieldOwner): Separate isFieldOwnerDisabledOrReadOnly into two.
(DateTimeFieldElement):
Declare isFieldOwnerDisabled and isFieldOwnerReadOnly.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
Remove redundant isDisabled check. It is done in
DateTimeFieldElement::defaultEventHandler.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- 6:27 PM Changeset in webkit [141959] by
-
- 2 edits in trunk/Source/ThirdParty
Building with MinGW compiler dies with gtest errors
https://bugs.webkit.org/show_bug.cgi?id=108470
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-02-05
Reviewed by Martin Robinson.
Variable Libraries_libgtest_la_CXXFLAGS blindly assumes that
pthreads will always be enabled. Make using pthreads for gtest
conditional on the build target.
- gtest/GNUmakefile.am: Set Libraries_libgtest_la_CXXFLAGS accordingly to the build target.
- 6:21 PM Changeset in webkit [141958] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed build fix.
- WebKit.vcproj/WebKitExports.def.in:
- 6:15 PM Changeset in webkit [141957] by
-
- 11 edits in trunk
[Mac] Complete plumbing so captions menu can indicate track type
https://bugs.webkit.org/show_bug.cgi?id=108994
Reviewed by Dean Jackson.
Source/WebCore:
Plumb "isClosedCaptions" through to the Mac media engine.
Updated media/video-controls-captions-trackmenu-localized.html and results.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::isClosedCaptions): New, pass the call through to the private track.
- html/track/InbandTextTrack.h:
(InbandTextTrack):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Lose the member variable, this won't be accessed often enough
to make it worth caching the value.
- html/track/TextTrack.h:
(WebCore::TextTrack::isClosedCaptions): Make virtual so derived classes can oveerride.
- platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::isClosedCaptions): New.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::isClosedCaptions): New.
LayoutTests:
Update test results now that the Mac media engine identifies CC tracks.
- media/video-controls-captions-trackmenu-localized.html:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- 6:10 PM Changeset in webkit [141956] by
-
- 9 edits in trunk/Source/WebCore
Change DatabaseTask and DatabaseThread to work with DatabaseBackendAsync
instead of Database.
https://bugs.webkit.org/show_bug.cgi?id=108995.
Reviewed by Sam Weinig.
This change also moves the task inner classes from Database to
DatabaseBackendAsync.
No new tests.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::from):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
- Modules/webdatabase/DatabaseBackendAsync.h:
(DatabaseBackendAsync):
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::debugTaskName):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::create):
(DatabaseBackendAsync::DatabaseOpenTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::create):
(DatabaseBackendAsync::DatabaseCloseTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::create):
(DatabaseBackendAsync::DatabaseTableNamesTask):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):
- Modules/webdatabase/DatabaseThread.h:
(DatabaseThread):
- 6:04 PM Changeset in webkit [141955] by
-
- 2 edits in trunk/Source/WTF
2013-02-05 Oliver Hunt <oliver@apple.com>
Disable TCMalloc hardening as it's breaking leaks.
Reviewed by Gavin Barraclough.
- wtf/FastMalloc.cpp:
- 5:42 PM Changeset in webkit [141954] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
https://bugs.webkit.org/show_bug.cgi?id=108989
Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-05
Reviewed by Kent Tamura.
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
- 5:36 PM Changeset in webkit [141953] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed. Get rid of redundant exports in export definitions file.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- WebKit.vcproj/WebKitExports.def.in:
- 5:32 PM Changeset in webkit [141952] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] TiledCoreAnimationDrawingArea has one more layer in its CAContext when we're in the background
https://bugs.webkit.org/show_bug.cgi?id=108992
<rdar://problem/13087365>
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add storage for m_isInWindow.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext): Only set the root layer on our layer
hosting context if we're in the window when swapping out contexts.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): Update m_isInWindow, and set the root layer
of the layer hosting context (or unset it if we're out of the window).
- 5:06 PM Changeset in webkit [141951] by
-
- 2 edits in trunk/Source/JavaScriptCore
Crash at JSC::call when loading www.gap.com with JSVALUE32_64 Enabled
https://bugs.webkit.org/show_bug.cgi?id=108991
Reviewed by Oliver Hunt.
Changed the restoration from calleeGPR to nonArgGPR0 because the restoration of the return location
may step on calleeGPR is it happen to be nonArgGPR2.
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkClosureCall):
- 4:58 PM Changeset in webkit [141950] by
-
- 9 edits in trunk/Source
Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS(), and make DatabaseType a strong enum.
https://bugs.webkit.org/show_bug.cgi?id=108988.
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests.
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
- Modules/webdatabase/DatabaseBackendAsync.cpp:
(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
- Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::DatabaseBackendSync):
- Modules/webdatabase/DatabaseBasicTypes.h:
(WebCore::ENUM_CLASS):
- Modules/webdatabase/DatabaseError.h:
(WebCore::ENUM_CLASS):
Source/WTF:
- wtf/EnumClass.h:
- 4:48 PM Changeset in webkit [141949] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed Visual Studio 2010 build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Link export definitions out of date with ToT. Corrected.
- 4:28 PM Changeset in webkit [141948] by
-
- 5 edits in trunk/Source/WebCore
[V8] Remove deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=108919
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/V8Binding.cpp:
(WebCore::toXPathNSResolver):
- bindings/v8/V8Binding.h:
- bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::create):
(WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
- bindings/v8/custom/V8CustomXPathNSResolver.h:
(V8CustomXPathNSResolver):
- 4:05 PM Changeset in webkit [141947] by
-
- 5 edits in trunk
formenctype to have empty string as default value.
https://bugs.webkit.org/show_bug.cgi?id=108969
Reviewed by Kent Tamura.
The spec says formEnctype should only have an invalid value default, not a missing value default.
Spec: http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formenctype
http://www.whatwg.org/specs/web-apps/current-work/#attr-fs-formenctype
Source/WebCore:
No new tests. Covered by existing test case fast/forms/submit-form-attributes.html
- html/HTMLFormControlElement.cpp: For the missing formEnctype attr return empty string.
(WebCore::HTMLFormControlElement::formEnctype):
LayoutTests:
- fast/forms/submit-form-attributes-expected.txt:
- fast/forms/submit-form-attributes.html: Modified test to behave as expected.
- 4:00 PM Changeset in webkit [141946] by
-
- 20 edits in trunk/Source
[V8] Reduce usage of deprecatedString() and deprecatedInteger()
https://bugs.webkit.org/show_bug.cgi?id=108909
Reviewed by Adam Barth.
Source/WebCore:
By passing an Isolate parameter around, we can reduce usage of
deprecated methods.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
- bindings/v8/NPV8Object.cpp:
(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
- bindings/v8/ScriptProfiler.cpp:
(WebCore):
(WebCore::ScriptProfiler::takeHeapSnapshot):
- bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
- bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
- bindings/v8/V8NPUtils.h:
(WebCore):
- bindings/v8/V8Utilities.cpp:
(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):
- bindings/v8/V8Utilities.h:
(WebCore):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
Source/WebKit/chromium:
No tests. No change in behavior.
- src/WebBindings.cpp:
(WebKit::WebBindings::toV8Value):
- 3:55 PM Changeset in webkit [141945] by
-
- 34 edits in trunk/Source
[V8] Make an Isolate parameter mandatory in HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108917
Reviewed by Adam Barth.
Source/WebCore:
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::HasInstance):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::HasInstance):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
Source/WebKit/chromium:
Because these methods do not have an Isolate, we have to call
v8::Isolate::GetCurrent().
No tests. No change in behavior.
- src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):
- src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):
- src/WebBindings.cpp:
(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::getRange):
(WebKit::WebBindings::getArrayBuffer):
(WebKit::WebBindings::getArrayBufferView):
(WebKit::WebBindings::getNode):
(WebKit::WebBindings::getElement):
- 3:43 PM Changeset in webkit [141944] by
-
- 2 edits in trunk/Source/WebCore
[JSC] Clean up CodeGeneratorJS.pm by introducing HasCustom{Getter,Setter,Method}
https://bugs.webkit.org/show_bug.cgi?id=108898
Reviewed by Sam Weinig.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):
- 3:42 PM Changeset in webkit [141943] by
-
- 8 edits1 delete in trunk/Source
[chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
https://bugs.webkit.org/show_bug.cgi?id=107776
Source/Platform:
Make "createGrGLInterface" the preferred virtual method for
WebGraphicsContext3D implementations to override. For now it
just calls the old method in its default implementation.
Reviewed by James Robinson.
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createGrGLInterface):
Source/WebCore:
Reviewed by James Robinson.
Allow the compositor thread's context to be retrieved on either thread,
so the main thread can create and pass the context to the impl thread
via its own mechanisms.
Move the code to bind the GrGLInterface to a WebGraphicsContext3D into
chromium's GraphicsContext3DPrivate. The chromium-side code will need
to implement this code itself.
- platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):
- platform/chromium/support/GraphicsContext3DPrivate.h:
- platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::getForImplThread):
Source/WebKit/chromium:
Reviewed by James Robinson.
- WebKit.gyp:
- src/WebGraphicsContext3D.cpp: Removed.
- 3:40 PM Changeset in webkit [141942] by
-
- 2 edits in trunk/Tools
[CMake] Don't warn unused cmake variables which aren't used by cmake ports
https://bugs.webkit.org/show_bug.cgi?id=108761
Reviewed by Laszlo Gombos.
Ignore unused macro variables which aren't used by cmake ports.
- Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):
- 3:37 PM Changeset in webkit [141941] by
-
- 3 edits in trunk/Tools
Add cc_unittests to the dashboards
https://bugs.webkit.org/show_bug.cgi?id=108878
Reviewed by Dirk Pranke.
- TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 3:24 PM Changeset in webkit [141940] by
-
- 2 edits in trunk/Source/WTF
Unreviewed build fix.
- wtf/FastMalloc.cpp:
- 3:05 PM Changeset in webkit [141939] by
-
- 8 edits11 adds in trunk/Source
Add a JavaScriptCore Export Generator project.
https://bugs.webkit.org/show_bug.cgi?id=108971.
Reviewed by Brent Fulgham.
- JavaScriptCore.vcxproj/JavaScriptCore.sln:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Added.
- WebKit.vcxproj/WebKit.sln:
- 2:39 PM Changeset in webkit [141938] by
-
- 4 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove dependency on the parser's tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108666
Reviewed by Adam Barth.
This is the final dependency on the parser, so we remove that as well. Yay!
No new tests because no new functionality.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer): Pass m_tokenizer->shouldAllowCDATA()
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor): Remove isMainThread() check because we have one in init() anyway.
Move m_isEnabled and m_documentURL initialization to init() because we have a Document* there.
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterEndToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
- html/parser/XSSAuditor.h:
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):
- 2:37 PM Changeset in webkit [141937] by
-
- 4 edits in trunk/Source/WebCore
Make baseWritingDirectionForSelectionStart available to all platforms in the Editor class.
https://bugs.webkit.org/show_bug.cgi?id=108977.
Reviewed by Ryosuke Niwa.
Now that baseWritingDirectionForSelectionStart doesn't use
platform specific type anymore, we can make it available for
all platforms. This way it can be used for iOS as well.
No new tests, no functionality change.
- editing/Editor.cpp:
(WebCore::Editor::baseWritingDirectionForSelectionStart): Added.
- editing/Editor.h: Moved from PLATFORM(MAC).
- editing/mac/EditorMac.mm: baseWritingDirectionForSelectionStart removed.
- 2:35 PM Changeset in webkit [141936] by
-
- 4 edits in tags/Safari-537.29.1/Source
Versioning.
- 2:33 PM Changeset in webkit [141935] by
-
- 2 edits in trunk/Source/WebCore
Avoid String->AtomicString conversion in Attr::childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=108742
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.
- dom/Attr.cpp:
(WebCore::Attr::childrenChanged): StringBuilder can output AtomicString directly.
- 2:32 PM Changeset in webkit [141934] by
-
- 1 copy in tags/Safari-537.29.1
New Tag.
- 2:15 PM Changeset in webkit [141933] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Win7 port doesn't run WebGL.
- platform/win/TestExpectations:
- 2:14 PM Changeset in webkit [141932] by
-
- 2 edits in trunk/Source/WTF
Tidy up StackBounds
https://bugs.webkit.org/show_bug.cgi?id=108889
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Ryosuke Niwa.
- wtf/StackBounds.h:
(StackBounds):
(WTF::StackBounds::isSafeToRecurse):
(WTF::StackBounds::size):
Adopt a more conventional style for a multiline branch.
(WTF::StackBounds::StackBounds):
(WTF::StackBounds::current):
(WTF::StackBounds::recursionLimit):
Make those method private.
Making the constructor private ensure initialize() is alwasy called on any StackBounds.
- 2:14 PM Changeset in webkit [141931] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
DFG should have a precise view of jump targets
https://bugs.webkit.org/show_bug.cgi?id=108868
Reviewed by Oliver Hunt.
Previously, the DFG relied entirely on the CodeBlock's jump targets list for
determining when to break basic blocks. This worked great, except sometimes it
would be too conservative since the CodeBlock just says where the bytecode
generator inserted labels.
This change keeps the old jump target list in CodeBlock since it is still
valuable to the baseline JIT, but switches the DFG to use its own jump target
calculator. This ought to reduce pressure on the DFG simplifier, which would
previously do a lot of work to try to merge redundantly created basic blocks.
It appears to be a 1% progression on SunSpider.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/PreciseJumpTargets.cpp: Added.
(JSC):
(JSC::addSimpleSwitchTargets):
(JSC::computePreciseJumpTargets):
- bytecode/PreciseJumpTargets.h: Added.
(JSC):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- 2:08 PM Changeset in webkit [141930] by
-
- 2 edits in trunk/LayoutTests
[GTK][WK2] Unflag tests related to layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=108976
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-05
Reviewed by Martin Robinson.
- platform/gtk-wk2/TestExpectations: Unflag
fast/loader/policy-delegate-action-hit-test-zoomed.html as it is
already passing (layoutTestController.setCustomPolicyDelegate was
implemented in r128600). Mark some tests related with
layoutTestController.setCustomPolicyDelegate as passing in WK2 but
failing in WK1.
- 2:04 PM Changeset in webkit [141929] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Enable shouldGesturesTriggerActive for Android
https://bugs.webkit.org/show_bug.cgi?id=96948
Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-02-05
Reviewed by James Robinson.
We need this to fix performance issues we are getting because of touchstart
triggering hover/active states.
No new tests. The tests introduced in https://bugs.webkit.org/show_bug.cgi?id=96060
should run with the corrected behavior and would cover this change as well.
- page/EventHandler.cpp:
(WebCore::shouldGesturesTriggerActive):
- 2:02 PM Changeset in webkit [141928] by
-
- 31 edits8 adds in trunk/Source
Introduced back-end database classes + a few small fixes.
https://bugs.webkit.org/show_bug.cgi?id=108759.
Source/WebCore:
Reviewed by Brady Eidson.
- Added DatabaseBackendContext, DatabaseBackendAsync, and DatabaseBackendSync. These are backends for DatabaseContext, Database, and DatabaseSync respectively.
- Added DatabaseBase to hold common code between Database and DatabaseSync.
- Renamed a few functions.
- Cleaned up unneeded code in ~DatabaseSync().
- Added some FIXMEs as reminders or places to clean up when we're done refactoring.
- Moved the calling of ScriptController::initializeThreading() from the Database constructor to DatabaseManager::openDatabase(). This just moves the call earlier in the same code path. System initialization work (i.e. initializing script threading in this case) should be done by the manager instead of by each Database instance.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabaseServer.h:
(AbstractDatabaseServer):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::backend):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::~DatabaseBackend):
(WebCore::DatabaseBackend::incrementalVacuumIfNeeded):
- Modules/webdatabase/DatabaseBackend.h:
(DatabaseBackend):
(WebCore::DatabaseBackend::databaseContext):
(WebCore::DatabaseBackend::setFrontend):
- Modules/webdatabase/DatabaseBackendAsync.cpp: Added.
(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):
- Modules/webdatabase/DatabaseBackendAsync.h: Added.
(DatabaseBackendAsync):
- Modules/webdatabase/DatabaseBackendContext.cpp: Added.
(WebCore::DatabaseBackendContext::securityOrigin):
(WebCore::DatabaseBackendContext::isContextThread):
- Modules/webdatabase/DatabaseBackendContext.h: Added.
(DatabaseBackendContext):
(WebCore::DatabaseBackendContext::scriptExecutionContext):
- Modules/webdatabase/DatabaseBackendSync.cpp: Added.
(WebCore::DatabaseBackendSync::DatabaseBackendSync):
(WebCore::DatabaseBackendSync::~DatabaseBackendSync):
- Modules/webdatabase/DatabaseBackendSync.h: Added.
(DatabaseBackendSync):
- Modules/webdatabase/DatabaseBase.cpp: Added.
(WebCore::DatabaseBase::DatabaseBase):
(WebCore::DatabaseBase::scriptExecutionContext):
(WebCore::DatabaseBase::logErrorMessage):
- Modules/webdatabase/DatabaseBase.h: Added.
(DatabaseBase):
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::backend):
- Modules/webdatabase/DatabaseContext.h:
(DatabaseContext):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::hasOpenDatabases):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
(WebCore::DatabaseManager::logErrorMessage):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::interruptAllDatabasesForContext):
(WebCore::DatabaseServer::canEstablishDatabase):
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::backend):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::openTrackerDatabase):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::populateOriginsIfNeeded):
(WebCore::DatabaseTracker::databaseNamesForOriginNoLock):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::isDeletingDatabaseOrOriginFor):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::isDeletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::isDeletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
- Modules/webdatabase/SQLTransaction.cpp:
- Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didExceedQuota):
- Modules/webdatabase/SQLTransactionSync.cpp:
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::closeDatabasesImmediately):
- Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExceedQuota):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
Reviewed by Brady Eidson.
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
- 1:58 PM Changeset in webkit [141927] by
-
- 2 edits in trunk/Source/WTF
[WTFURL] Comparison between signed and unsigned integer expressions in URLUtil.cpp
https://bugs.webkit.org/show_bug.cgi?id=108955
Reviewed by Benjamin Poulain.
- wtf/url/src/URLUtil.cpp:
(URLUtilities): Make the counter variable a signed integer to get rid of the warning.
- 1:44 PM Changeset in webkit [141926] by
-
- 10 edits in trunk
DumpRenderTree should be able to enable the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=108970
Reviewed by Eric Seidel.
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setThreadedHTMLParser):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Tools:
We can now enable the parser at runtime using --enable-threaded-html-parser.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
(WebPreferences):
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::setThreadedHTMLParser):
(TestShell):
- 1:41 PM Changeset in webkit [141925] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Delete some errant preprocessor definitions.
- WebKit.vcxproj/WebKit/WebKitCommon.props:
- 1:30 PM Changeset in webkit [141924] by
-
- 3 edits3 copies41 adds in trunk/Source/WebKit
VS2010 WebKit projects, scripts, and property sheets.
https://bugs.webkit.org/show_bug.cgi?id=106989.
Reviewed by Brent Fulgham.
- WebKit.vcxproj/Interfaces: Added.
- WebKit.vcxproj/Interfaces/FixMIDLHeaders.pl: Copied from win/WebKit.vcproj/FixMIDLHeaders.pl.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Added.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Added.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Added.
- WebKit.vcxproj/Interfaces/InterfacesCommon.props: Added.
- WebKit.vcxproj/Interfaces/InterfacesDebug.props: Added.
- WebKit.vcxproj/Interfaces/InterfacesPostBuild.cmd: Added.
- WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd: Added.
- WebKit.vcxproj/Interfaces/InterfacesRelease.props: Added.
- WebKit.vcxproj/WebKit: Added.
- WebKit.vcxproj/WebKit.sln:
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Added.
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Added.
- WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Added.
- WebKit.vcxproj/WebKit/WebKitApple.props: Added.
- WebKit.vcxproj/WebKit/WebKitCFLite.props: Added.
- WebKit.vcxproj/WebKit/WebKitCommon.props: Added.
- WebKit.vcxproj/WebKit/WebKitDebug.props: Added.
- WebKit.vcxproj/WebKit/WebKitDirectX.props: Added.
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Added.
- WebKit.vcxproj/WebKit/WebKitPreBuild.cmd: Added.
- WebKit.vcxproj/WebKit/WebKitPreLink.cmd: Added.
- WebKit.vcxproj/WebKit/WebKitRelease.props: Added.
- WebKit.vcxproj/WebKit/resource.h: Copied from win/WebKit.vcproj/resource.h.
- WebKit.vcxproj/WebKitExportGenerator: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebug.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorRelease.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Copied from win/WebKit.vcproj/WebKitExports.def.in.
- WebKit.vcxproj/WebKitGUID: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDCommon.props: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDDebug.props: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDPostBuild.cmd: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDRelease.props: Added.
- 1:26 PM Changeset in webkit [141923] by
-
- 5 edits in trunk/Source/WebKit2
WebKit clients should be able to override loading of blocked plug-ins
https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>
Reviewed by Sam Weinig.
Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp:
(WebKit::toWKPluginLoadPolicy):
(WebKit):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h:
(WebUIClient):
- 1:16 PM Changeset in webkit [141922] by
-
- 8 edits in trunk
[WEBGL] Rename WEBKIT_WEBGL_depth_texture to WEBGL_depth_texture.
https://bugs.webkit.org/show_bug.cgi?id=108959
Reviewed by Kenneth Russell.
Source/WebCore:
WEBGL_depth_texture is official now. Hence remove the vendor prefix from
WEBKIT_WEBGL_depth_texture and rename this extension string to WEBGL_depth_texture.
Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/.
Tests already exists, modified them to test querying of unprefixed extension string.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLDepthTexture.cpp:
(WebCore::WebGLDepthTexture::getName):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
LayoutTests:
- fast/canvas/webgl/webgl-depth-texture.html:
- 1:14 PM Changeset in webkit [141921] by
-
- 2 edits in trunk/Source/JavaScriptCore
Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC.
https://bugs.webkit.org/show_bug.cgi?id=108693.
Rubberstamped by Timothy Horton.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 1:04 PM Changeset in webkit [141920] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove optionalness of second parameter to WebLayerTreeView::setViewportSize
https://bugs.webkit.org/show_bug.cgi?id=108972
Reviewed by Adam Barth.
This was added to ease the transition of adding this parameter, but it's now always set.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
- 12:58 PM Changeset in webkit [141919] by
-
- 2 edits in trunk/Source/WTF
Rationalize the use of iOS/Mac #defines in Assertions.cpp
https://bugs.webkit.org/show_bug.cgi?id=108870
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by David Kilzer.
- wtf/Assertions.cpp: Instead of using PLATFORM(MAC) and assume it works for iOS and OS X,
use CF as the guard for CFString. Similarily, USE_APPLE_SYSTEM_LOG guards code using ASL.
- 12:52 PM Changeset in webkit [141918] by
-
- 2 edits in trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj
Unreviewed. VS2010 JavaScriptCore projects touch-ups.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
- JavaScriptCore.vcxproj/testRegExp/testRegExpPostBuild.cmd:
- 12:49 PM Changeset in webkit [141917] by
-
- 4 edits in trunk
Source/WTF: Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of length zero
https://bugs.webkit.org/show_bug.cgi?id=108894
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::toAtomicString): The function was returning the nullAtom for strings of length zero.
This is inconsistent with StringBuilder::toString() which always return an empty string.
This patch unifies the behavior.
Tools: Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of null length
https://bugs.webkit.org/show_bug.cgi?id=108894
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.
- TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
Extend the tests to check toAtomicString() on an empty builder.
- 12:43 PM Changeset in webkit [141916] by
-
- 4 edits in trunk/Source
Structure::m_outOfLineCapacity is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=108206
Reviewed by Darin Adler.
Simplifying the utility functions that we use since we don't need a
bunch of fancy templates for this one specific call site.
Source/JavaScriptCore:
- runtime/Structure.h:
(JSC::Structure::outOfLineCapacity):
Source/WTF:
- wtf/MathExtras.h:
(WTF::roundUpToPowerOfTwo):
- 12:41 PM Changeset in webkit [141915] by
-
- 27 adds in trunk/Source/WebKit/win/WebKit.resources
Unreviewed. Copy some resource files for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=106989.
- WebKit.resources/WebKit.rc: Added.
- WebKit.resources/deleteButton.png: Added.
- WebKit.resources/deleteButtonPressed.png: Added.
- WebKit.resources/fsVideoAudioVolumeHigh.png: Added.
- WebKit.resources/fsVideoAudioVolumeLow.png: Added.
- WebKit.resources/fsVideoExitFullscreen.png: Added.
- WebKit.resources/fsVideoPause.png: Added.
- WebKit.resources/fsVideoPlay.png: Added.
- WebKit.resources/missingImage.png: Added.
- WebKit.resources/nullplugin.png: Added.
- WebKit.resources/panEastCursor.png: Added.
- WebKit.resources/panIcon.png: Added.
- WebKit.resources/panNorthCursor.png: Added.
- WebKit.resources/panNorthEastCursor.png: Added.
- WebKit.resources/panNorthWestCursor.png: Added.
- WebKit.resources/panSouthCursor.png: Added.
- WebKit.resources/panSouthEastCursor.png: Added.
- WebKit.resources/panSouthWestCursor.png: Added.
- WebKit.resources/panWestCursor.png: Added.
- WebKit.resources/searchCancel.png: Added.
- WebKit.resources/searchCancelPressed.png: Added.
- WebKit.resources/searchMagnifier.png: Added.
- WebKit.resources/searchMagnifierResults.png: Added.
- WebKit.resources/textAreaResizeCorner.png: Added.
- WebKit.resources/verticalTextCursor.png: Added.
- WebKit.resources/zoomInCursor.png: Added.
- WebKit.resources/zoomOutCursor.png: Added.
- 12:38 PM Changeset in webkit [141914] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838
Reviewed by Oliver Hunt.
In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using. We use Xcode project
settings to make sure we don't try to compile ARC on 32-bit.
- API/tests/testapi.mm:
(+[TestObject testObject]):
(testObjectiveCAPI):
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:34 PM Changeset in webkit [141913] by
-
- 2 edits1 add in trunk/WebKitLibraries/win/tools
Unreviewed. VS2010 solution touch-ups.
Make common.props use a platform dependent preprocessor definition (WIN32 or X64).
Add a few base properties.
Create a temporary auto-version script for use by the VS2010 solution. Will be removed later.
https://bugs.webkit.org/show_bug.cgi?id=106949.
- win/tools/scripts/auto-version2010.sh: Added.
- win/tools/vsprops/common.props:
- 12:32 PM Changeset in webkit [141912] by
-
- 1 edit18 adds in trunk/LayoutTests
Adds the WebGL Conformance Tests typedarrays folder.
https://bugs.webkit.org/show_bug.cgi?id=108907
Reviewed by Kenneth Russell.
- webgl/conformance/typedarrays/array-buffer-crash-expected.txt: Added.
- webgl/conformance/typedarrays/array-buffer-crash.html: Added.
- webgl/conformance/typedarrays/array-buffer-view-crash-expected.txt: Added.
- webgl/conformance/typedarrays/array-buffer-view-crash.html: Added.
- webgl/conformance/typedarrays/array-unit-tests-expected.txt: Added.
- webgl/conformance/typedarrays/array-unit-tests.html: Added.
- webgl/conformance/typedarrays/data-view-crash-expected.txt: Added.
- webgl/conformance/typedarrays/data-view-crash.html: Added.
- webgl/conformance/typedarrays/data-view-test-expected.txt: Added.
- webgl/conformance/typedarrays/data-view-test.html: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/array-buffer-crash.html: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/array-buffer-view-crash.html: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/data-view-crash.html: Added.
- webgl/resources/webgl_test_files/conformance/typedarrays/data-view-test.html: Added.
- 12:20 PM Changeset in webkit [141911] by
-
- 1 edit45 adds in trunk/LayoutTests
Adds the WebGL Conformance Tests misc folder.
https://bugs.webkit.org/show_bug.cgi?id=108905
Reviewed by Kenneth Russell.
- webgl/conformance/misc/bad-arguments-test-expected.txt: Added.
- webgl/conformance/misc/bad-arguments-test.html: Added.
- webgl/conformance/misc/boolean-argument-conversion-expected.txt: Added.
- webgl/conformance/misc/boolean-argument-conversion.html: Added.
- webgl/conformance/misc/delayed-drawing-expected.txt: Added.
- webgl/conformance/misc/delayed-drawing.html: Added.
- webgl/conformance/misc/error-reporting-expected.txt: Added.
- webgl/conformance/misc/error-reporting.html: Added.
- webgl/conformance/misc/functions-returning-strings-expected.txt: Added.
- webgl/conformance/misc/functions-returning-strings.html: Added.
- webgl/conformance/misc/instanceof-test-expected.txt: Added.
- webgl/conformance/misc/instanceof-test.html: Added.
- webgl/conformance/misc/invalid-passed-params-expected.txt: Added.
- webgl/conformance/misc/invalid-passed-params.html: Added.
- webgl/conformance/misc/is-object-expected.txt: Added.
- webgl/conformance/misc/is-object.html: Added.
- webgl/conformance/misc/null-object-behaviour-expected.txt: Added.
- webgl/conformance/misc/null-object-behaviour.html: Added.
- webgl/conformance/misc/object-deletion-behaviour-expected.txt: Added.
- webgl/conformance/misc/object-deletion-behaviour.html: Added.
- webgl/conformance/misc/shader-precision-format-expected.txt: Added.
- webgl/conformance/misc/shader-precision-format.html: Added.
- webgl/conformance/misc/type-conversion-test-expected.txt: Added.
- webgl/conformance/misc/type-conversion-test.html: Added.
- webgl/conformance/misc/uninitialized-test-expected.txt: Added.
- webgl/conformance/misc/uninitialized-test.html: Added.
- webgl/conformance/misc/webgl-specific-expected.txt: Added.
- webgl/conformance/misc/webgl-specific.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/misc/bad-arguments-test.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/boolean-argument-conversion.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/delayed-drawing.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/error-reporting.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/functions-returning-strings.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/instanceof-test.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/invalid-passed-params.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/is-object.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/null-object-behaviour.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/object-deletion-behaviour.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/shader-precision-format.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/type-conversion-test.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/uninitialized-test.html: Added.
- webgl/resources/webgl_test_files/conformance/misc/webgl-specific.html: Added.
- 12:09 PM Changeset in webkit [141910] by
-
- 1 edit31 adds in trunk/LayoutTests
Adds the WebGL Conformance Tests buffers folder
https://bugs.webkit.org/show_bug.cgi?id=108902
Reviewed by Kenneth Russell.
- webgl/conformance/buffers/buffer-bind-test-expected.txt: Added.
- webgl/conformance/buffers/buffer-bind-test.html: Added.
- webgl/conformance/buffers/buffer-data-array-buffer-expected.txt: Added.
- webgl/conformance/buffers/buffer-data-array-buffer.html: Added.
- webgl/conformance/buffers/element-array-buffer-delete-recreate-expected.txt: Added.
- webgl/conformance/buffers/element-array-buffer-delete-recreate.html: Added.
- webgl/conformance/buffers/index-validation-copies-indices-expected.txt: Added.
- webgl/conformance/buffers/index-validation-copies-indices.html: Added.
- webgl/conformance/buffers/index-validation-crash-with-buffer-sub-data-expected.txt: Added.
- webgl/conformance/buffers/index-validation-crash-with-buffer-sub-data.html: Added.
- webgl/conformance/buffers/index-validation-expected.txt: Added.
- webgl/conformance/buffers/index-validation-large-buffer-expected.txt: Added.
- webgl/conformance/buffers/index-validation-large-buffer.html: Added.
- webgl/conformance/buffers/index-validation-verifies-too-many-indices-expected.txt: Added.
- webgl/conformance/buffers/index-validation-verifies-too-many-indices.html: Added.
- webgl/conformance/buffers/index-validation-with-resized-buffer-expected.txt: Added.
- webgl/conformance/buffers/index-validation-with-resized-buffer.html: Added.
- webgl/conformance/buffers/index-validation.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/00_test_list.txt: Added.
- webgl/resources/webgl_test_files/conformance/buffers/buffer-bind-test.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/buffer-data-array-buffer.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/element-array-buffer-delete-recreate.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/index-validation-copies-indices.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/index-validation-crash-with-buffer-sub-data.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/index-validation-large-buffer.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/index-validation-verifies-too-many-indices.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/index-validation-with-resized-buffer.html: Added.
- webgl/resources/webgl_test_files/conformance/buffers/index-validation.html: Added.
- 11:47 AM Changeset in webkit [141909] by
-
- 21 edits in trunk/Source
Unreviewed, rolling out r141905.
http://trac.webkit.org/changeset/141905
https://bugs.webkit.org/show_bug.cgi?id=108963
"Broke mac build" (Requested by tonyg-cr on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05
Source/WebCore:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h:
(WebCore):
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h:
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):
- platform/KURL.cpp:
- platform/KURL.h:
(KURL):
- platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
- platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
- platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
Source/WTF:
- wtf/text/CString.cpp:
- wtf/text/CString.h:
- wtf/text/WTFString.cpp:
- wtf/text/WTFString.h:
(String):
- wtf/url/api/ParsedURL.h:
(ParsedURL):
- wtf/url/api/URLString.h:
- 11:38 AM Changeset in webkit [141908] by
-
- 2 edits in trunk/Source/WebCore
[HarfBuzz][Cairo] harfBuzzGetGlyph is slow and hot
https://bugs.webkit.org/show_bug.cgi?id=108941
Reviewed by Kenneth Rohde Christiansen.
The text to glyph conversion using Cairo is slow
due to expensive text codec conversion to UTF-8.
Additionally, the glyph lookup itself is expensive.
Inspired by the approach taken in HarfBuzzFaceSkia.cpp
I suggest to implement a similar caching mechanism to
accelerate this conversion.
Arabic line breaking test, under review in
bug 108948 shows about 58% improvement on my system
with this patch.
- platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
(WebCore::HarfBuzzFontData::HarfBuzzFontData):
New container structure that keeps pointers
to the cairo scaled font as well as the glyph cache.
(HarfBuzzFontData):
(WebCore):
(WebCore::harfBuzzGetGlyph): Using the new container structure for accessing the cache.
(WebCore::harfBuzzGetGlyphHorizontalAdvance): Using the new container structure for accessing the scaled font.
(WebCore::harfBuzzGetGlyphExtents): Ditto.
(WebCore::destroyHarfBuzzFontData): Destroying the container that held the pointers.
(WebCore::HarfBuzzFace::createFont):
Initializing the container structure with the pointers
to the cache that is held in HarfBuzzFace and the cairo scaled font.
- 11:26 AM Changeset in webkit [141907] by
-
- 1 copy in releases/WebKitGTK/webkit-1.11.5
Tag the WebKitGTK+ 1.11.5 release
- 11:15 AM Changeset in webkit [141906] by
-
- 2 edits1 add in trunk/PerformanceTests
Add a performance test for arabic line breaking
https://bugs.webkit.org/show_bug.cgi?id=108948
Reviewed by Eric Seidel.
Adding a perfomance test based to exercise the complex
font path used in rendering arabic script.
- Layout/ArabicLineLayout.html: Added.
- Skipped: New test skipped by default as per Ryosuke's request.
- 11:06 AM Changeset in webkit [141905] by
-
- 21 edits in trunk/Source
Call XSSAuditor's didBlockScript() for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108726
Reviewed by Adam Barth.
Source/WebCore:
This patch causes us to call didBlockScript() on the main thread if the CompactHTML token has XSSInfo.
To do so, we:
- Rename DidBlockScriptRequest to XSSInfo.
- Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
- Add an isSafeToSendToAnotherThread() method to String and KURL.
We don't yet populate didBlockScriptRequest on the background thread, but this should just work once we do.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer): Update comment for rename.
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken): Add a copy constructor used by Vector.
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread): Include new m_xssInfo field in safety check.
(WebCore):
(WebCore::CompactHTMLToken::xssInfo): Added.
(WebCore::CompactHTMLToken::setXSSInfo): Added.
- html/parser/CompactHTMLToken.h: Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
(WebCore):
(CompactHTMLToken):
(WTF): Add VectorTraits necessary for copying Vector fields objects that contain an OwnPtr.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser): Add new didBlockScript() call.
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/XSSAuditor.cpp: Renaming.
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h: Renaming.
(WebCore):
(XSSAuditor):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSInfo::isSafeToSendToAnotherThread):
(WebCore):
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
(XSSAuditorDelegate):
- platform/KURL.cpp:
(WebCore::KURL::isSafeToSendToAnotherThread): Added.
(WebCore):
- platform/KURL.h:
(KURL):
- platform/KURLGoogle.cpp:
(WebCore):
(WebCore::KURLGooglePrivate::isSafeToSendToAnotherThread): Added.
- platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
- platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::isSafeToSendToAnotherThread): Added.
Source/WTF:
This patch adds isSafeToSendToAnotherThread() methods to CString, String, ParsedURL and URLString.
These methods check to ensure there are 0 or 1 references.
- wtf/text/CString.cpp:
(WTF::CString::isSafeToSendToAnotherThread): Added.
(WTF):
- wtf/text/CString.h:
(CString):
- wtf/text/WTFString.cpp:
(WTF::String::isSafeToSendToAnotherThread): Added.
(WTF):
- wtf/text/WTFString.h:
(String):
- wtf/url/api/ParsedURL.h:
(WTF::ParsedURL::isSafeToSendToAnotherThread): Added.
- wtf/url/api/URLString.h:
(WTF::URLString::isSafeToSendToAnotherThread): Added.
- 10:55 AM Changeset in webkit [141904] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957
Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.
Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.
- 10:44 AM Changeset in webkit [141903] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Scrolling performance drops doing page load
https://bugs.webkit.org/show_bug.cgi?id=108949
Patch by Andrew Lo <anlo@rim.com> on 2013-02-05
Reviewed by Yong Li.
Internally reviewed by Jakob Petsovits.
Internal PR 291390.
The intention of this code was to not update non-visible tiles during page load.
Before this patch, the code would update tiles that have already been rendered
during page load.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
- 10:43 AM Changeset in webkit [141902] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed VS2010 Build Correction after r141651
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing
StructureRareData.h and StructureRareData.cpp files.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- 10:36 AM Changeset in webkit [141901] by
-
- 4 edits2 adds in trunk
TextAutosizing: adjust the maximum difference between cluster text width and its descendant
width.
https://bugs.webkit.org/show_bug.cgi?id=108411
Source/WebCore:
Currently, if a render object is more than 200 CSS units shorter than its parent cluster, it
becomes a separate autosizing cluster (see https://bugs.webkit.org/show_bug.cgi?id=105188).
This doesn't work well for layouts when narrow nodes are related, like nested comments:
deeper comments are all shorter than the parent cluster and become autosized differently. To
avoid that the difference that makes a shorter descendant a new autosizing cluster is
adjusted each time the width difference is not greater than 50 CSS units from the previous
one. This allows nested comments, for example, to remain a part of the parent cluster and be
autosized with the same multiplier.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.
Tests:
fast/text-autosizing/nested-child.html
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizingClusterInfo::TextAutosizingClusterInfo):
Added a new field to store the current maximum width difference for the cluster.
(WebCore::TextAutosizer::isAutosizingCluster):
Uses the new field to determine if the current node is a separate cluster,
updates the maximum allowed width difference between the cluster and its descendant.
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
Non-const reference passed to the methods above.
- rendering/TextAutosizer.h: updated method parameters.
LayoutTests:
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.
Tests that certain width difference doesn't make descendants separate clusters.
- fast/text-autosizing/nested-child-expected.html: Added.
- fast/text-autosizing/nested-child.html: Added.
- 10:30 AM Changeset in webkit [141900] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r141896.
http://trac.webkit.org/changeset/141896
https://bugs.webkit.org/show_bug.cgi?id=108956
crashes indexdb security tests (Requested by gavinp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05
- public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 10:26 AM WebKit Team edited by
- Update my affiliation. (diff)
- 10:07 AM Changeset in webkit [141899] by
-
- 3 edits in trunk/Tools
[chromium] remove methods from the WebTestRunner interface that are only used by WebTestProxyBase
https://bugs.webkit.org/show_bug.cgi?id=108926
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebKit):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- 9:59 AM Changeset in webkit [141898] by
-
- 2 edits in branches/chromium/1364
Disable Fullscreen API on Android.
Disable the fullscreen API, as it is not working correctly on Android.
BUG=173664
Review URL: https://codereview.chromium.org/12208016
- 9:55 AM Changeset in webkit [141897] by
-
- 5 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove dependency on parser's sourceForToken and TextResourceDecoder
https://bugs.webkit.org/show_bug.cgi?id=108698
Reviewed by Adam Barth.
We'd like to be able to call filterToken() from the BackgroundHTMLParser where there is no HTMLDocumentParser. So we are removing the dependencies of
filterToken() on the HTMLDocumentParser. This patch brings us one step closer to removing the m_parser member from XSSAuditor by passing in the
TextResourceDecoder and HTMLSourceTracker to filterToken. To keep the number of parameters from blowing up, this introduces a FilterTokenRequest struct
to hold its arguments. We expect to add one more member to this struct.
No new tests because no new functionality.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.h:
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
- html/parser/XSSAuditor.h:
(WebCore):
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):
- 9:42 AM Changeset in webkit [141896] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457
Reviewed by Adam Barth.
Now that https://codereview.chromium.org/12181010/ has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.
- public/platform/WebKitPlatformSupport.h:
(WebKit):
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
- 9:21 AM Changeset in webkit [141895] by
-
- 5 edits4 copies in branches/chromium/1364
Merge 141093
REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style
https://bugs.webkit.org/show_bug.cgi?id=105672
Reviewed by Andreas Kling.
Source/WebCore:
Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits
were not set due to sharing of styles between cousin elements.
This patch fixes the issue by not sharing styles from children with parents who prevent sharing.
Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html
fast/selectors/cousin-stylesharing-last-child-selector.html
- css/StyleResolver.cpp:
(WebCore::parentElementPreventsSharing):
(WebCore::StyleResolver::locateCousinList):
- dom/Element.cpp:
(WebCore::Element::hasFlagsSetDuringStylingOfChildren):
- dom/Element.h:
(Element):
LayoutTests:
Two test cases by Philippe Wittenbergh that triggers the issue.
- fast/selectors/cousin-stylesharing-adjacent-selector-expected.html: Added.
- fast/selectors/cousin-stylesharing-adjacent-selector.html: Added.
- fast/selectors/cousin-stylesharing-last-child-selector-expected.html: Added.
- fast/selectors/cousin-stylesharing-last-child-selector.html: Added.
TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12209019
- 7:52 AM Changeset in webkit [141894] by
-
- 2 edits in trunk/Source/JavaScriptCore
r141788 won't build due to not having all changes needed by Node* change
https://bugs.webkit.org/show_bug.cgi?id=108944
Reviewed by David Kilzer.
Fixed three instances of integerResult(..., m_compileIndex) to be integerResult(..., node).
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):
- 7:48 AM Changeset in webkit [141893] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=108942.
- platform/qt/TestExpectations:
- 7:34 AM Changeset in webkit [141892] by
-
- 4 edits in trunk
[Qt] REGRESSION(r137436): It made all inspector tests timeout on developer builds
https://bugs.webkit.org/show_bug.cgi?id=106554
Reviewed by Simon Hausmann.
.:
Explicitely link WebCore resources in the final DLL only on Windows to
support force_static_libs_as_shared on other platforms.
WebKit1 applications don't get the QtWebKit dynamic library loaded
since libQtWebKitWidgets doesn't depend on libQtWebKit if WebCore and
WebKit1 are dynamic libraries of their own.
- Source/api.pri:
Source/WebCore:
- Target.pri:
- 7:05 AM Changeset in webkit [141891] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: prevent crash, add required error string value
https://bugs.webkit.org/show_bug.cgi?id=108776
Patch by Peter Rybin <prybin@chromium.org> on 2013-02-05
Reviewed by Pavel Feldman.
Error string is assigned where missing, assert is added where empty string is
possible.
- inspector/InjectedScriptBase.cpp:
(WebCore::InjectedScriptBase::makeEvalCall):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::injectedScriptForEval):
- 6:18 AM Changeset in webkit [141890] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.
Quick fix for regression.
- inspector/front-end/inspector.js:
Avoid "exit route" when URL is a profile URL.
- 5:54 AM Changeset in webkit [141889] by
-
- 4 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: element.focus() should not focus on disabled sub-fields.
https://bugs.webkit.org/show_bug.cgi?id=108924
Reviewed by Kentaro Hara.
Source/WebCore:
The first field may be non-focusable. We should search sub-fields for
focusable one.
Test: fast/forms/date-multiple-fields/date-multiple-fields-focus.html
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::focusOnNextFocusableField):
Added. A private helper function.
(WebCore::DateTimeEditElement::focusIfNoFocus): Use focusOnNextFocusableField.
(WebCore::DateTimeEditElement::focusByOwner): Ditto.
(WebCore::DateTimeEditElement::focusOnNextField): Ditto.
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare focusOnNextFocusableField.
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Added.
- 5:52 AM Changeset in webkit [141888] by
-
- 8 edits2 adds in trunk
Web Inspector: Create separate project for each file system added to inspector.
https://bugs.webkit.org/show_bug.cgi?id=108652
Reviewed by Pavel Feldman.
Source/WebCore:
Every file system added to web inspector is now represented by its own project in workspace.
FileSystemMapping changed accrodingly.
Test: inspector/file-system-mapping.html
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype._entryURIPrefix):
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMapping.prototype.fileForURI):
(WebInspector.FileSystemMapping.prototype.uriForFile):
(WebInspector.FileSystemMapping.prototype.uriPrefixForPathPrefix):
(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set _fileSystemName):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemId):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(WebInspector.FileSystemMappingImpl.prototype.uriForFile):
(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):
- inspector/front-end/FileSystemWorkspaceProvider.js:
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype.innerCallback):
(WebInspector.FileSystemWorkspaceProvider.prototype.requestFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype.setFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype._populate.filesLoaded):
(WebInspector.FileSystemWorkspaceProvider.prototype._populate):
(WebInspector.FileSystemWorkspaceProvider.prototype._addFile):
(WebInspector.FileSystemWorkspaceProvider.prototype._removeFile):
(WebInspector.FileSystemWorkspaceProvider.prototype.reset):
- inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel):
(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):
- inspector/front-end/Workspace.js:
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Project.prototype.dispose):
(WebInspector.Workspace.prototype.removeProject):
LayoutTests:
- inspector/file-mapping.html:
- inspector/file-system-mapping-expected.txt: Added.
- inspector/file-system-mapping.html: Added.
- 5:28 AM WebKit Team edited by
- (diff)
- 5:03 AM Changeset in webkit [141887] by
-
- 8 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: Should not move focus if the element already has focus
https://bugs.webkit.org/show_bug.cgi?id=108914
Reviewed by Kentaro Hara.
Source/WebCore:
If timeInput.focus() is called when a sub-field of the time input
already has focus, we should not focus on the first sub-field of the
time input.
Test: fast/forms/time-multiple-fields/time-multiple-fields-focus.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::willCancelFocus): If
the input elment already has focused sub-field, we don't need to proceed
focus handling. FocusDirection check is required because we don't need
to do this in cases of sequential focus navigation.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Override InputType::willCancelFocus.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::focus):
Cancel focus if InputType::willCancelFocus returns true.
- html/HTMLInputElement.h:
(HTMLInputElement): Override focus.
- html/InputType.cpp:
(WebCore::InputType::willCancelFocus):
Add a default implementation. It returns false.
- html/InputType.h:
(InputType): Declare willCancelFocus.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Added.
- 4:57 AM Changeset in webkit [141886] by
-
- 4 edits in trunk/Source/WebCore
[Qt] RGB -> BGR is wrong on big endian
https://bugs.webkit.org/show_bug.cgi?id=107560
Reviewed by Jocelyn Turcotte.
Replace the conversion to methods that make it clearer what is going on.
The routines are also optimized compared to the existing by avoiding going
over slow Color constructor.
Tested by existing tests in canvas and fast/canvas.
- platform/graphics/Color.cpp:
(WebCore::colorFromPremultipliedARGB):
Cleanup.
(WebCore::premultipliedARGBFromColor):
Cleanup and correct for alpha = 0.
- platform/graphics/Color.h:
(WebCore):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::copyColorToRGBA):
(WebCore::copyRGBAToColor):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
- 4:41 AM Changeset in webkit [141885] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Use visible as initial value of backface-visibility-property.
https://bugs.webkit.org/show_bug.cgi?id=108875
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-02-05
Reviewed by Noam Rosenthal.
According to W3C spec, the initial value of backface-visibility-visibility is visible.
However TextureMapperLayer's initial value is false which means hidden.
So this patch is for changing the value to visible(true).
Covered by existing tests.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::State::State): Change the initial value false to true
to use backface-visibility.
- 4:34 AM Changeset in webkit [141884] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Canvas] do not store a dropped trace log in backend
https://bugs.webkit.org/show_bug.cgi?id=108600
Reviewed by Pavel Feldman.
Clear memory immediately on dropping current trace log instead of waiting for the next capture command.
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- 4:04 AM Changeset in webkit [141883] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile
https://bugs.webkit.org/show_bug.cgi?id=108602
Reviewed by Pavel Feldman.
Cancel recording profile of canvas-type when deleting an alive trace log.
Drive-by: rename ProfileHeader.reset to ProfileHeader.dispose since it's called on header's destruction.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileHeader.prototype.dispose):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
- 2:58 AM Changeset in webkit [141882] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Replace more uses of WebPageProxy with WKPage in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=108826
Reviewed by Kenneth Rohde Christiansen and signed off for WK2 by
Benjamin Poulain.
This patch converts a few more usages of WebPageProxy to functions in
the WKPage API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewLegacyPrivate::zoomFactor):
(QQuickWebViewLegacyPrivate::setZoomFactor):
(QQuickWebViewExperimental::postMessage):
(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):
(QQuickWebViewExperimental::evaluateJavaScript):
(QQuickWebViewExperimental::findText):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::setUrl):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::loading):
(QQuickWebView::title):
(QQuickWebView::pageRef):
(QQuickWebView::loadHtml):
(QQuickWebView::runJavaScriptInMainFrame):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- 2:33 AM QtWebKitGardening edited by
- (diff)
- 2:32 AM Changeset in webkit [141881] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a flaky crash expectation for a couple of tests.
Reclassifying the expectation for http/tests/media/video-play-stall.html as a flaky timeouting test.
- platform/gtk/TestExpectations:
- 2:27 AM Changeset in webkit [141880] by
-
- 2 edits in trunk/Source/WebCore
Build is broken since r141543 for platforms without OpenGL
https://bugs.webkit.org/show_bug.cgi?id=108862
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-02-05
Reviewed by Simon Hausmann.
- Target.pri:
- 2:26 AM Changeset in webkit [141879] by
-
- 20 edits in trunk/Source
Unreviewed, rolling out r141865.
http://trac.webkit.org/changeset/141865
https://bugs.webkit.org/show_bug.cgi?id=108909
webkit unit tests are broken
Source/WebCore:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
- bindings/v8/NPV8Object.cpp:
(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::takeHeapSnapshot):
- bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
- bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
- bindings/v8/V8NPUtils.h:
(WebCore):
- bindings/v8/V8Utilities.cpp:
(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):
- bindings/v8/V8Utilities.h:
(WebCore):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
Source/WebKit/chromium:
- src/WebBindings.cpp:
(WebKit::WebBindings::toV8Value):
- 2:20 AM Changeset in webkit [141878] by
-
- 2 edits in trunk/Tools
[chromium] remove unneccessary 0 checks for testRunner now that the TestRunner library owns it
https://bugs.webkit.org/show_bug.cgi?id=108923
Reviewed by Kentaro Hara.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::shouldBeginEditing):
(WebTestRunner::WebTestProxyBase::shouldEndEditing):
(WebTestRunner::WebTestProxyBase::shouldInsertNode):
(WebTestRunner::WebTestProxyBase::shouldInsertText):
(WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
(WebTestRunner::WebTestProxyBase::shouldDeleteRange):
(WebTestRunner::WebTestProxyBase::shouldApplyStyle):
(WebTestRunner::WebTestProxyBase::didBeginEditing):
(WebTestRunner::WebTestProxyBase::didChangeSelection):
(WebTestRunner::WebTestProxyBase::didChangeContents):
(WebTestRunner::WebTestProxyBase::didEndEditing):
(WebTestRunner::WebTestProxyBase::createView):
(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner::WebTestProxyBase::didStopLoading):
(WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
(WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
(WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
(WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
(WebTestRunner::WebTestProxyBase::didFailLoad):
(WebTestRunner::WebTestProxyBase::didFinishLoad):
(WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
(WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
(WebTestRunner::WebTestProxyBase::didRunInsecureContent):
(WebTestRunner::WebTestProxyBase::didDetectXSS):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willRequestResource):
(WebTestRunner::WebTestProxyBase::didCreateDataSource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didReceiveResponse):
(WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
(WebTestRunner::WebTestProxyBase::didFailResourceLoad):
(WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
(WebTestRunner::WebTestProxyBase::locationChangeDone):
(WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
(WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
- 2:13 AM Changeset in webkit [141877] by
-
- 15 edits in trunk/Source/WebCore
Cleanup: Use exceptionless Range::* methods rather than ignoring exceptions.
https://bugs.webkit.org/show_bug.cgi?id=108773
Reviewed by Darin Adler.
We often call Range::{start,end}{Container,Offset} with an ExceptionCode
that's completely ignored. In these cases, we should simply use the
exceptionless version of the method instead.
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
Here, I also moved parameters onto one line to make the
stylebot happy.
(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::setMarkersActive):
Dropped ignored ExceptionCode variable entirely.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
Can't drop the variable because of the selectNodeContents call.
- editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
Dropped ignored ExceptionCode variable entirely.
(WebCore::Editor::advanceToNextMisspelling):
Can't drop the variable because of setStart/setEnd.
- editing/EditorCommand.cpp:
(WebCore::unionDOMRanges):
Can't drop the variable because of compareBoundaryPoints.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendNodeValue):
Dropped ignored ExceptionCode variable entirely.
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingParagraph::offsetAsRange):
(WebCore::TextCheckingHelper::findFirstMisspelling):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::renderedText):
(WebCore::StyledMarkupAccumulator::stringValueForRange):
Dropped ignored ExceptionCode variable entirely.
- editing/visible_units.cpp:
(WebCore::previousBoundary):
Can't drop the variable due to many other calls.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::deleteFromDocument):
(WebCore::DOMSelection::containsNode):
For both these cases, the 'ASSERT(!ec)' after the statement I've
edited only checked the last occurance of the exception: that is,
if 'startXxx(ec)' threw an exception, it would be overwritten by
the 'setBaseAndExtend()' or 'compareBoundaryPoints()' exception.
Removing the exception parameters from the parameters' calls
shouldn't effect behavior.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writeRange):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeSelection):
- platform/wince/PasteboardWinCE.cpp:
(WebCore::Pasteboard::writeSelection):
Dropped ignored ExceptionCode variable entirely.
- 2:10 AM Changeset in webkit [141876] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: introduce Memory.getDOMCounters
https://bugs.webkit.org/show_bug.cgi?id=108822
Reviewed by Pavel Feldman.
Introduced Memory.getDOMCounters command that returns number of Documents, Nodes
and JS event listeners in the inspected process.
- inspector/Inspector.json:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getDOMCounters):
(WebCore):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- 1:57 AM Changeset in webkit [141875] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt][Wk2] Unreviewed gardening. Added platform specific expected.
- 1:37 AM Changeset in webkit [141874] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: rename Image m_data member to m_encodedImageData for the consistency
https://bugs.webkit.org/show_bug.cgi?id=108913
Reviewed by Yury Semikhatsky.
No new tests because no API changes.
- platform/graphics/Image.cpp:
(WebCore::Image::setData):
(WebCore::Image::reportMemoryUsage):
- platform/graphics/Image.h:
(WebCore::Image::data):
(Image):
- 1:19 AM Changeset in webkit [141873] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed Linux ASAN build fix for r141783.
- platform/RefCountedSupplement.h:
(Wrapper):
- platform/Supplementable.h:
(Supplement):
- 1:13 AM Changeset in webkit [141872] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Unreviewed: Fix broken SVG-disabled build.
https://bugs.webkit.org/show_bug.cgi?id=108916
The new enum value CSSPropertyWebkitGridAutoFlow was introduced in
r141787, and accidentally left out of CSSParser::parseValue's big
switch. This causes problems in non-SVG builds.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 1:10 AM Changeset in webkit [141871] by
-
- 13 edits3 deletes in trunk
MediaStream API: Update RTCPeerConnections stream accessors to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=108179
Reviewed by Adam Barth.
Source/WebCore:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#interface-definition
The attributes localStreams and remoteStreams have been changes to the methods
getLocalStreams() and getRemoteStreams() which return a native array instead.
Existing tests updated to cover patch.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/MediaStream.h:
(WebCore):
- Modules/mediastream/MediaStreamList.cpp: Removed.
- Modules/mediastream/MediaStreamList.h: Removed.
- Modules/mediastream/MediaStreamList.idl: Removed.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::getLocalStreams):
(WebCore::RTCPeerConnection::getRemoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- WebCore.gypi:
LayoutTests:
Updating tests for RTCPeerConnections new stream accessors.
- fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
- fast/mediastream/RTCPeerConnection-statsSelector.html:
- 1:07 AM Changeset in webkit [141870] by
-
- 2 edits in trunk/Source/WebCore
[Qt][EFL][WebGL] Webgl doesn't work on nvidia cards
https://bugs.webkit.org/show_bug.cgi?id=108059
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.
Commit r138327 fixed repainting issues on mesa3d GL library by re-binding
texture to the window after every glXSwapBuffer. Unfortunatelly re-bind
breaks rendering on NVidia cards with NVidia propiertary drivers.
This change limits texture re-binding only for mesa3d GL library.
No new tests. HW specific fix.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::isMesaGLX):
(OffScreenRootWindow):
(WebCore::GraphicsSurface::platformSwapBuffers):
- 1:05 AM Changeset in webkit [141869] by
-
- 3 edits in trunk/LayoutTests
touch-event.html should check touchstartFiredInShadowDOM is true.
https://bugs.webkit.org/show_bug.cgi?id=108910
Reviewed by Hajime Morita.
We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM.
This is a follow-up patch for http://trac.webkit.org/changeset/141054
- fast/dom/shadow/touch-event-expected.txt:
- fast/dom/shadow/touch-event.html:
- 12:55 AM Changeset in webkit [141868] by
-
- 4 edits in trunk
Update the NEWS and configuration in preparation for 1.11.5.
Reviewed by Philippe Normand.
.:
- configure.ac:
Source/WebKit/gtk:
- NEWS:
- 12:39 AM Changeset in webkit [141867] by
-
- 6 edits in trunk
Floating point precision error in AudioPannerNode.
https://bugs.webkit.org/show_bug.cgi?id=106001
Patch by Praveen Jadhav <praveen.j@samsung.com> on 2013-02-05
Reviewed by Kentaro Hara.
Specifications Update:
https://dvcs.w3.org/hg/audio/rev/69a39a516e45
Source/WebCore:
Conversion from double to float and back to double
results in precision error. Avoiding these conversions
will make sure that proper values are retained in the
parameters.
- Modules/webaudio/PannerNode.h:
(WebCore::PannerNode::refDistance):
(WebCore::PannerNode::setRefDistance):
(WebCore::PannerNode::maxDistance):
(WebCore::PannerNode::setMaxDistance):
(WebCore::PannerNode::rolloffFactor):
(WebCore::PannerNode::setRolloffFactor):
(WebCore::PannerNode::coneInnerAngle):
(WebCore::PannerNode::setConeInnerAngle):
(WebCore::PannerNode::coneOuterAngle):
(WebCore::PannerNode::setConeOuterAngle):
(WebCore::PannerNode::coneOuterGain):
(WebCore::PannerNode::setConeOuterGain):
- Modules/webaudio/PannerNode.idl:
LayoutTests:
New test scenarios are added to verify precision
error issues in PannerNode.
- webaudio/pannernode-basic-expected.txt:
- webaudio/pannernode-basic.html:
- 12:31 AM Changeset in webkit [141866] by
-
- 13 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Use disabled attribute internally instead of readonly attribute
https://bugs.webkit.org/show_bug.cgi?id=108911
Reviewed by Kentaro Hara.
Source/WebCore:
Use 'disabled' attribute for shadow elements for <input> with
multiple-fields UI instead of 'readonly' attribute because 'readonly'
attribute represents focusable-but-non-editable state in HTML though
we'd like to represent non-focusable-and-non-editable state.
The summary of changes:
- Use 'disabled' attribute instead of 'readonly' attribute for DateTimeFieldElement,
- Rename C++ functions for it,
- Call isFocusable instead of isReadOnly to check focusable state.
No new tests. This doesn't make user-visible behavior changes.
- css/html.css:
Replace [readonly] with [disabled] for sub-fields.
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldYearFieldDisabled):
(WebCore::DateTimeEditElement::anyEditableFieldsHaveValues):
(WebCore::DateTimeEditElement::focusOnNextField): Use isFocusable.
(WebCore::DateTimeEditElement::focusOnPreviousField): Use isFocusable.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::isFocusable):
(WebCore::DateTimeFieldElement::isDisabled):
(WebCore::DateTimeFieldElement::setDisabled):
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Make isFocusable public in order that
DateTimeEditElement can call it.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html:
- fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
- fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html:
- 12:20 AM Changeset in webkit [141865] by
-
- 20 edits in trunk/Source
[V8] Reduce usage of deprecatedString() and deprecatedInteger()
https://bugs.webkit.org/show_bug.cgi?id=108909
Reviewed by Adam Barth.
Source/WebCore:
By passing an Isolate parameter around, we can reduce usage of
deprecated methods.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
- bindings/v8/NPV8Object.cpp:
(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::compileAndRunScript):
- bindings/v8/ScriptProfiler.cpp:
(WebCore):
(WebCore::ScriptProfiler::takeHeapSnapshot):
- bindings/v8/ScriptSourceCode.cpp:
(WebCore::ScriptSourceCode::compileScript):
- bindings/v8/ScriptSourceCode.h:
(ScriptSourceCode):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
- bindings/v8/V8NPUtils.cpp:
(WebCore::convertNPVariantToV8Object):
- bindings/v8/V8NPUtils.h:
(WebCore):
- bindings/v8/V8Utilities.cpp:
(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):
- bindings/v8/V8Utilities.h:
(WebCore):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):
Source/WebKit/chromium:
No tests. No change in behavior.
- src/WebBindings.cpp:
(WebKit::WebBindings::toV8Value):
- 12:03 AM Changeset in webkit [141864] by
-
- 14 edits2 moves1 add1 delete in trunk
[Mac] Captions menu should indicate language and type of track
https://bugs.webkit.org/show_bug.cgi?id=108882
Reviewed by Eric Carlson.
Source/WebCore:
On Mac, we want a specific format for menu items in a caption list. Since
other ports might want different formats, move the generation of the label
into CaptionsUserPreferences where it can be overridden.
This required CaptionsUserPreferences to become public on the PageGroup, so
it could be used when creating the menu. Also, since CaptionsUserPreferences
was hidden on Mountain Lion and below, be a little more specific about
which pieces can be seen on which builds.
Covered by existing media/video-controls-captions-trackmenu tests.
- English.lproj/Localizable.strings: Remove textTrackClosedCaptionsText.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Build only
one section and get the track's display name from the user preferences.
- page/CaptionUserPreferences.h:
(WebCore::CaptionUserPreferences::displayNameForTrack): Default implementation of
virtual function that provides a label for a captions menu item.
- page/CaptionUserPreferencesMac.h: Add the new virtual function, and expose just
a bit of this class outside 10.9 builds.
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Guard features for system version.
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): New OS X-specific method that
returns a string for the menu label.
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences): Unguard for system version.
- page/PageGroup.h: Make captionPreferences public.
- platform/LocalizedStrings.cpp: Remove textTrackClosedCaptionsText - not needed any more.
- platform/LocalizedStrings.h: Remove textTrackClosedCaptionsText.
LayoutTests:
Now that the captions menu can be labelled in a platform-specific way, move
the results into the platform directory. At the moment, they are skipped
everywhere but Mac. Also update the tests to the new menu structure, which
only has a single list of entries.
- media/video-controls-captions-trackmenu-localized.html: Updated for new menu structure.
- media/video-controls-captions-trackmenu-expected.txt: Removed.
- media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
- media/video-controls-captions-trackmenu-sorted-expected.txt: Removed.
- media/video-controls-captions-trackmenu-sorted.html: Updated for new menu structure.
- media/video-controls-captions-trackmenu.html: Updated for new menu structure.
- platform/mac/media/video-controls-captions-trackmenu-expected.txt: New platform specific results.
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
- 12:00 AM Changeset in webkit [141863] by
-
- 2 edits in trunk/Tools
EWS bots don't remove untracked files after processing a patch
https://bugs.webkit.org/show_bug.cgi?id=108891
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-04
Reviewed by Adam Barth.
Added option to remove untracked files in the bot's repo.
- EWSTools/start-queue.sh:
Feb 4, 2013:
- 11:39 PM Changeset in webkit [141862] by
-
- 31 edits in trunk/Source/WebCore
[V8] Pass an Isolate to V8DOMConfiguration
https://bugs.webkit.org/show_bug.cgi?id=108900
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateToV8Converters):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::createWrapper):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::V8Float64Array::installPerContextProperties):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::createWrapper):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::V8TestActiveDOMObject::installPerContextProperties):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::createWrapper):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::V8TestCustomNamedGetter::installPerContextProperties):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::V8TestEventConstructor::installPerContextProperties):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::createWrapper):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::V8TestEventTarget::installPerContextProperties):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::createWrapper):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::V8TestException::installPerContextProperties):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::createWrapper):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::installPerContextProperties):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::createWrapper):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::installPerContextProperties):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::V8TestNamedConstructor::installPerContextProperties):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::createWrapper):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::V8TestNode::installPerContextProperties):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::createWrapper):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::createWrapper):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::V8TestOverloadedConstructors::installPerContextProperties):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::installPerContextProperties):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
- 11:28 PM Changeset in webkit [141861] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, skipping heap-snapshot-with-detached-dom-tree.html
- platform/chromium/TestExpectations:
- 10:53 PM Changeset in webkit [141860] by
-
- 2 edits in trunk/Source/WebCore
[V8] Clean up CodeGeneratorV8.pm by introducing HasCustom{Getter,Setter,Method}
https://bugs.webkit.org/show_bug.cgi?id=108896
Reviewed by Adam Barth.
No tests. No change in generated code.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):
(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(RequiresCustomSignature):
- 10:35 PM Changeset in webkit [141859] by
-
- 1 edit6 adds in trunk/LayoutTests
[Chromium] Unreviewed rebaselining.
- platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt: Added.
- platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Added.
- 10:20 PM Changeset in webkit [141858] by
-
- 3 edits2 adds in trunk
Fix crash by <select> type change on focus
https://bugs.webkit.org/show_bug.cgi?id=108830
Reviewed by Abhishek Arya.
Source/WebCore:
Test: fast/forms/select/select-change-type-on-focus.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
focus() calls may change the renderer type.
LayoutTests:
- fast/forms/select/select-change-type-on-focus-expected.txt: Added.
- fast/forms/select/select-change-type-on-focus.html: Added.
- 10:08 PM Changeset in webkit [141857] by
-
- 6 edits in trunk/Source/WebCore
[V8] Pass an Isolate to opaqueRootForGC()
https://bugs.webkit.org/show_bug.cgi?id=108886
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateOpaqueRootForGC):
(GenerateHeader):
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::opaqueRootForGC):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WebCore::WrapperTypeInfo::opaqueRootForGC):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):
- 9:56 PM Changeset in webkit [141856] by
-
- 7 edits in trunk/LayoutTests
Add missing tests for default values of event constructors
https://bugs.webkit.org/show_bug.cgi?id=108885
Reviewed by Adam Barth.
Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-keyboardevent
- fast/events/constructors/keyboard-event-constructor-expected.txt:
- fast/events/constructors/keyboard-event-constructor.html:
- fast/events/constructors/mouse-event-constructor-expected.txt:
- fast/events/constructors/mouse-event-constructor.html:
- fast/events/constructors/wheel-event-constructor-expected.txt:
- fast/events/constructors/wheel-event-constructor.html:
- 9:22 PM Changeset in webkit [141855] by
-
- 1 edit65 adds in trunk/LayoutTests
Add Support Files for WebGL Conformance Tests
https://bugs.webkit.org/show_bug.cgi?id=108731
Reviewed by Kenneth Russell.
These are the 'resource' files for the WebGL
Conformance Tests. Other CLs will add the
actual tests.
- webgl/resources/webgl_test_files/conformance/resources/3x3.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/blue-1x1.jpg: Added.
- webgl/resources/webgl_test_files/conformance/resources/boolUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/bug-32888-texture.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/floatUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/fragmentShader.frag: Added.
- webgl/resources/webgl_test_files/conformance/resources/glsl-conformance-test.js: Added.
(GLSLConformanceTester):
- webgl/resources/webgl_test_files/conformance/resources/glsl-feature-tests.css: Added.
(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):
- webgl/resources/webgl_test_files/conformance/resources/glsl-generator.js: Added.
(GLSLGenerator.):
(GLSLGenerator):
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256-with-128-alpha.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-default-gamma.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma0.1.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma1.0.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma2.0.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma4.0.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma9.0.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/gray-ramp.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/green-2x2-16bit.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/intArrayUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/intUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/matUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.frag: Added.
- webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/npot-video.mp4: Added.
- webgl/resources/webgl_test_files/conformance/resources/npot-video.theora.ogv: Added.
- webgl/resources/webgl_test_files/conformance/resources/npot-video.webmvp8.webm: Added.
- webgl/resources/webgl_test_files/conformance/resources/ogles-tests.css: Added.
(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):
- webgl/resources/webgl_test_files/conformance/resources/pnglib.js: Added.
(.):
- webgl/resources/webgl_test_files/conformance/resources/red-green.mp4: Added.
- webgl/resources/webgl_test_files/conformance/resources/red-green.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/red-green.theora.ogv: Added.
- webgl/resources/webgl_test_files/conformance/resources/red-green.webmvp8.webm: Added.
- webgl/resources/webgl_test_files/conformance/resources/red-indexed.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/samplerUniformShader.frag: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-cie-rgb-profile.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-colormatch-profile.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.jpg: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-e-srgb-profile.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-smpte-c-profile.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
- webgl/resources/webgl_test_files/conformance/resources/structUniformShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-canvas.js: Added.
(.init):
(.setCanvasToRedGreen):
(.drawTextInCanvas):
(.setCanvasTo257x257):
(.setCanvasTo1x2):
(.else):
(.runOneIteration):
(.runTest.runNextTest):
(.runTest):
(generateTest):
- webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image-data.js: Added.
(.init):
(.runOneIteration):
(.runTest):
(generateTest):
- webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image.js: Added.
(.init):
(.runOneIteration):
(.runTestOnImage):
(.runTest.newImage.onload):
(.runTest):
(.runTest2.newImage.onload):
(.runTest2):
(.runTest3):
(generateTest):
- webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-video.js: Added.
(debug):
(.init):
(.runOneIteration):
(.runTest):
- webgl/resources/webgl_test_files/conformance/resources/vertexShader.vert: Added.
- webgl/resources/webgl_test_files/conformance/resources/webgl-test-utils.js: Added.
(WebGLTestUtils):
(WebGLTestUtils.):
- webgl/resources/webgl_test_files/conformance/resources/webgl-test.js: Added.
(webglTestLog):
(getGLErrorAsString):
(shouldGenerateGLError):
(glErrorShouldBe):
- webgl/resources/webgl_test_files/conformance/resources/zero-alpha.png: Added.
- webgl/resources/webgl_test_files/resources/desktop-gl-constants.js: Added.
- webgl/resources/webgl_test_files/resources/js-test-post.js: Added.
- webgl/resources/webgl_test_files/resources/js-test-pre.js: Added.
(.):
(reportTestResultsToHarness):
(notifyFinishedToHarness):
(description):
(debug):
(escapeHTML):
(testPassed):
(testFailed):
(areArraysEqual):
(isMinusZero):
(isResultCorrect):
(stringify):
(evalAndLog):
(shouldBe):
(shouldNotBe):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldEvaluateTo):
(shouldBeNonZero):
(shouldBeNonNull):
(shouldBeUndefined):
(shouldBeDefined):
(shouldBeGreaterThanOrEqual):
(expectTrue):
(shouldThrow):
(assertMsg):
(gc.gcRec):
(gc):
(finishTest.epilogue.onload):
(finishTest):
- webgl/resources/webgl_test_files/resources/js-test-style.css: Added.
(.pass):
(.fail):
(#console):
- webgl/resources/webgl_test_files/resources/test-eval.js: Added.
(TestEval):
- webgl/resources/webgl_test_files/resources/webgl-logo.png: Added.
- webgl/resources/webgl_test_files/resources/webgl-test-harness.js: Added.
(WebGLTestHarnessModule.log):
(WebGLTestHarnessModule.try.request.onreadystatechange):
(WebGLTestHarnessModule.loadTextFileAsynchronous):
(WebGLTestHarnessModule.greaterThanOrEqualToVersion):
(WebGLTestHarnessModule.copyObject):
(WebGLTestHarnessModule.toCamelCase):
(WebGLTestHarnessModule.):
(WebGLTestHarnessModule.getFileListImpl):
(WebGLTestHarnessModule.var):
(WebGLTestHarnessModule.getFileList):
(WebGLTestHarnessModule.FilterURL):
(WebGLTestHarnessModule.TestFile):
(WebGLTestHarnessModule.Test):
(WebGLTestHarnessModule.TestHarness):
(WebGLTestHarnessModule.TestHarness.prototype.addFiles_):
(WebGLTestHarnessModule.TestHarness.prototype.runTests):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.clearTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.startNextTest):
(WebGLTestHarnessModule.TestHarness.prototype.startTest):
(WebGLTestHarnessModule.TestHarness.prototype.getTest):
(WebGLTestHarnessModule.TestHarness.prototype.reportResults):
(WebGLTestHarnessModule.TestHarness.prototype.dequeTest):
(WebGLTestHarnessModule.TestHarness.prototype.notifyFinished):
(WebGLTestHarnessModule.TestHarness.prototype.timeout):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeoutDelay):
(WebGLTestHarnessModule):
- webgl/resources/webkit-webgl-test-harness.js: Added.
(.):
- 9:11 PM Changeset in webkit [141854] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180583. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-04
- DEPS:
- 8:45 PM Changeset in webkit [141853] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
https://bugs.webkit.org/show_bug.cgi?id=108807
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-04
Reviewed by Anders Carlsson.
We need to add newly created WebCustomFilterProgramProxy to a hashset to
disconnect when CoordinatedLayerTreeHost gets destructed.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
- 8:40 PM Changeset in webkit [141852] by
-
- 4 edits4 copies2 moves5 adds in trunk/LayoutTests
[Chromium] Unreviewed rebaselining for r141769.
- platform/chromium-mac-lion/compositing/overflow/nested-scrolling-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/overflow/nested-scrolling-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
- platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png:
- platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt: Added.
- platform/chromium/compositing/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
- platform/chromium/compositing/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
- 8:30 PM Changeset in webkit [141851] by
-
- 2 edits in trunk/Source/WebCore
Heap-buffer-overflow in WebCore::AudioBufferSourceNode::process
https://bugs.webkit.org/show_bug.cgi?id=108515
After calling setBuffer() with a buffer having a different number of
channels, there can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of use of
tryLocks() in the context's updating system.
In this case, if the the buffer has just been changed and we're
not quite ready yet then just output silence.
Reviewed by Chris Rogers.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
- 8:23 PM Changeset in webkit [141850] by
-
- 8 edits in trunk/Source
[Chromium] Add a signal for when the body is inserted in the document
https://bugs.webkit.org/show_bug.cgi?id=108725
Reviewed by Adam Barth.
Source/WebCore:
This is an important signal for resource scheduling. We know we have enough to paint something,
so we can start kicking off image preloads.
Test: Chromium webkit_unit_tests
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchWillInsertBody):
Source/WebKit/chromium:
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::willInsertBody):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
(WebKit):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- tests/WebFrameTest.cpp:
- 8:21 PM Changeset in webkit [141849] by
-
- 47 edits in trunk
Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
https://bugs.webkit.org/show_bug.cgi?id=108741
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-04
Reviewed by Tony Chang.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Move suspendAnimations and resumeAnimations to group all the animation related
code together.
Add support for numberOfActiveAnimations, similarily to the feature previously defined
in TestRunner.
- testing/Internals.cpp:
(WebCore::Internals::numberOfActiveAnimations):
(WebCore):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
- WebView/WebFrame.mm:
- WebView/WebFramePrivate.h:
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
Source/WebKit2:
Suspending and resuming application has been useless for a one. Someone just
"forgot" WebKit2.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
Tools:
Remove all support for suspendAnimation(), resumeAnimation() and numberOfActiveAnimations().
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Update the tests to use WebCore Internals instead of the TestRunner.
- animations/animation-controller-drt-api.html:
- transitions/hang-with-bad-transition-list.html:
- transitions/remove-transition-style.html:
- transitions/repeated-firing-background-color.html:
- transitions/zero-duration-with-non-zero-delay-end.html:
- 8:02 PM Changeset in webkit [141848] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
https://bugs.webkit.org/show_bug.cgi?id=106979
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-02-04
Reviewed by Benjamin Poulain.
Implement runBeforeUnloadConfirmPanel() to support window.onbeforeunload.
We can show confirmation window when beforeunload event is fired.
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::runBeforeUnloadConfirmPanel):
(WebKit):
- UIProcess/efl/PageUIClientEfl.h:
(PageUIClientEfl):
- 7:42 PM Changeset in webkit [141847] by
-
- 3 edits in trunk/Tools
[chromium] Try to get WebKit building with enable_web_intents set to 0 on Windows too.
https://bugs.webkit.org/show_bug.cgi?id=108887
Reviewed by Kentaro Hara.
This is a follow-up to http://trac.webkit.org/changeset/141614. The
Mac and Linux linkers didn't complain about the reference to
WebIntent in that function for some reason (probably because it's
a dead function that's stripped).
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- 7:30 PM Changeset in webkit [141846] by
-
- 6 edits in trunk/Source/WebCore
[WEBGL] Rename WEBKIT_WEBGL_compressed_texture_s3tc to WEBGL_compressed_texture_s3tc
https://bugs.webkit.org/show_bug.cgi?id=108866
Reviewed by Kenneth Russell.
WEBGL_compressed_texture_s3tc is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_compressed_texture_s3tc.
Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/
No tests currently present to test WEBKIT_WEBGL_compressed_texture_s3tc.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLCompressedTextureS3TC.cpp:
(WebCore::WebGLCompressedTextureS3TC::getName):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
- 7:28 PM Changeset in webkit [141845] by
-
- 18 edits in trunk
[WEBGL] Rename WEBKIT_WEBGL_lose_context to WEBGL_lose_context.
https://bugs.webkit.org/show_bug.cgi?id=108694
Reviewed by Kenneth Russell.
WEBGL_lose_context is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_lose_context extension.
Spefication: http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/
Source/WebCore:
Tests already exists, modified them to verify the change in extension name.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLLoseContext.cpp:
(WebCore::WebGLLoseContext::getName):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
LayoutTests:
- fast/canvas/webgl/WebGLContextEvent.html:
- fast/canvas/webgl/context-destroyed-crash.html:
- fast/canvas/webgl/context-lost-expected.txt:
- fast/canvas/webgl/context-lost-restored.html:
- fast/canvas/webgl/context-lost.html:
- platform/chromium-linux-x86/fast/canvas/webgl/context-lost-expected.txt:
- platform/chromium-linux/fast/canvas/webgl/context-lost-expected.txt:
- platform/chromium-mac/fast/canvas/webgl/context-lost-expected.txt:
- platform/chromium-win-xp/fast/canvas/webgl/context-lost-expected.txt:
- platform/chromium-win/fast/canvas/webgl/context-lost-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt:
- 6:57 PM Changeset in webkit [141844] by
-
- 4 edits in trunk/Source/WebCore
Default element styles are not always collected for sharing detection
https://bugs.webkit.org/show_bug.cgi?id=108404
Reviewed by Antti Koivisto.
The method ensureDefaultStyleSheetsForElement is run as we add elements
to the document. This may update the defaultStyle of the document, but
does not recollect any changes into the StyleResolver. This means that
style sharing might be overly ambitious, thinking it can share a style
for an element which was matched in the new rules. This showed up most
often in the Shadow Root for media elements, which would add a set of
style rules, but the shadow children would sometimes share styles even
when they shouldn't.
The fix is to detect if we need to collect after adding a
style for an element. This might cause a little more work, but
in my testing it doesn't happen very often.
Unfortunately it is hard to get a reproducible test for this.
- css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement): As we load in
styles, keep track of whether or not we change the default style.
- css/CSSDefaultStyleSheets.h:
(CSSDefaultStyleSheets): New boolean parameter indicating if the style has changed.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForElement): Collect features if the element
caused the default style to update.
(WebCore::StyleResolver::collectFeatures): Protect for null in updates.
- 6:25 PM Changeset in webkit [141843] by
-
- 2 edits in trunk/Source/WebCore
Fix the issue that some possible source formats are ignored for float textures in texture packing for CG port
https://bugs.webkit.org/show_bug.cgi?id=108812
Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.
Already covered by latest WebGL conformance test.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- 6:12 PM Changeset in webkit [141842] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Remove needless local variables in LocalizedStringsEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=108869
Reviewed by Kentaro Hara.
fromUTF8() returns static String. So, we don't need to use needless local variables.
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagDelete):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):
- 6:11 PM Changeset in webkit [141841] by
-
- 4 edits in trunk/Source/WebCore
WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only
https://bugs.webkit.org/show_bug.cgi?id=108304
Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.
Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used
for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only.
It can make the code more clear and reduce the binary size for both CG port and non-CG port.
Already covered by current tests.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
(WebCore::GraphicsContext3D::srcFormatComeFromDOMElementOrImageData):
(ImageExtractor):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 6:01 PM Changeset in webkit [141840] by
-
- 3 edits in trunk/Source/WebCore
Allow TextTracks to be marked as closed captions
https://bugs.webkit.org/show_bug.cgi?id=108856
Reviewed by Darin Adler.
While this isn't exposed directly in markup, some platform media frameworks can
provide indication that a caption track is a closed caption. Expose such a flag
on TextTrack and platforms can show a different UI if they want to.
No tests - this isn't used elsewhere yet, nor exposed to the DOM.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Initialise new member.
- html/track/TextTrack.h:
(WebCore::TextTrack::isClosedCaptions): New member variable.
(WebCore::TextTrack::setIsClosedCaptions):
- 5:46 PM Changeset in webkit [141839] by
-
- 6 edits in trunk/Tools
Dashboard cleanup: Make builder a real dashboardSpecificParameter.
https://bugs.webkit.org/show_bug.cgi?id=108706
Reviewed by Dirk Pranke.
Add builder to g_defaultDashboardSpecificParameter maps for the
dashboards where it is used (flakiness, timeline, treemap).
Default it to null, and then update reads of it to check the
builder group's default if one is not set, rather than trying to
set and track this everywhere.
This allows us to remove tons of special-casing of builder parsing,
including where we used to add it to the query string even when the
user did not specify it.
- TestResultServer/static-dashboards/dashboard_base.js:
(parseParameters):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(handleQueryParameterChange):
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- 5:30 PM Changeset in webkit [141838] by
-
- 2 edits in trunk/Tools
Setting tests on flakiness dashboard should invalidate builder.
https://bugs.webkit.org/show_bug.cgi?id=108521
Reviewed by Dirk Pranke.
When you move into a cross builder view, builder should not still be
set. Currently, it is deleted from the internal state, but still shows
up in the url, causing the current state and the hash to not match.
To see this in action, load the flakiness dashboard, select a builder,
and then click on an individual test, to get into individual test view.
The url will still have the builder you selected listed, even though it
is cleared in the UI.
The fix is to consider 'tests' to be a parameter that invalidates builder.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 5:27 PM Changeset in webkit [141837] by
-
- 34 edits1 add in trunk
Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
https://bugs.webkit.org/show_bug.cgi?id=107850
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-04
Reviewed by Ojan Vafai.
Source/WebCore:
On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type.
The new EditingBehavior is the same as EditingUnixBehavior except for
EditingBehavior::shouldMoveCaret[...]. This new behavior fixes
WebFrame::moveCaretTowardsWindowPoint to not span to the
beginning/end.
- editing/EditingBehavior.h:
(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
- editing/EditingBehaviorTypes.h:
- page/Settings.cpp:
(WebCore):
(WebCore::editingBehaviorTypeForPlatform):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setEditingBehavior):
Source/WebKit/chromium:
On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type so that we can change these settings independent
of behavior for other platforms.
- public/WebSettings.h:
- src/AssertMatchingEnums.cpp:
Just add the corresponding assertion for the new editing behavior.
- public/WebSettings.h:
- src/AssertMatchingEnums.cpp:
- tests/WebFrameTest.cpp:
- tests/data/move_caret.html: Added.
Add a test that moveCaretTowardsWindowPoint works as expected on
Android.
LayoutTests:
Test the new "android" editing behavior in the following tests:
- editing/deleting/delete-ligature-003-expected.txt:
- editing/deleting/delete-ligature-003.html:
- editing/deleting/paragraph-in-preserveNewline-expected.txt:
- editing/deleting/paragraph-in-preserveNewline.html:
- editing/deleting/whitespace-pre-1-expected.txt:
- editing/deleting/whitespace-pre-1.html:
- editing/execCommand/script-tests/toggle-compound-styles.js:
- editing/execCommand/toggle-compound-styles-expected.txt:
- editing/selection/5354455-1-expected.txt:
- editing/selection/5354455-1.html:
- editing/selection/click-in-margins-inside-editable-div-expected.txt:
- editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
- editing/selection/context-menu-text-selection-expected.txt:
- editing/selection/context-menu-text-selection.html:
- editing/selection/extend-after-mouse-selection-expected.txt:
- editing/selection/extend-after-mouse-selection.html:
- editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
- editing/selection/programmatic-selection-on-mac-is-directionless.html:
- editing/selection/rtl-move-selection-right-left-expected.txt:
- editing/selection/rtl-move-selection-right-left.html:
- editing/selection/script-tests/click-in-margins-inside-editable-div.js:
- editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
- editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
- 5:20 PM Changeset in webkit [141836] by
-
- 16 edits2 adds in trunk
[EFL][WK2] Introduce a WebView class as counterpart for WKViewRef
https://bugs.webkit.org/show_bug.cgi?id=107931
Reviewed by Anders Carlsson.
Source/WebKit2:
This is just one step of the new plan for the EFL API.
The plan is to move the public EFL-like API on top of the shared
WK2 C API, plus a few EFL extensions (WKView class mostly).
The EFL-like API can be seen as a convenience API which ties
well into EFL and which makes it easy to add web experiences
to existing and new EFL applications. It provides a smart object
like API and a Evas_Object based view.
For more advanced use cases, such as browser and runtime, it is
possible to use the WK* C API, which is gives more flexibility
while being more low level.
The idea is that the WKView class will not depend on Evas_Object
and X11 (future plan) unlike the current EFL-like API. This should
make it possible to use it for cases where none of these are
available.
This patch introduces the WebView class which serves as our
counterpart for the WKView class, and adds a few needed methods.
The EwkView owns the WebView class (and will be constructing it
in the near future when the EwkView class has been changed to
handle all smart object related code)
The clean up of the smart object related code as the proper
construction of EwkView and WebView will be done in follow-up
patches.
- UIProcess/API/C/efl/WKAPICastEfl.h:
(WebKit):
The WKView API is not based on WebView and not Evas_Object*
- UIProcess/API/C/efl/WKView.cpp:
(WKViewCreate):
(WKViewCreateWithFixedLayout):
(WKViewInitialize):
(WKViewGetPage):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewGetEvasObject):
(WKViewCreateSnapshot):
Add a few new WKView EFL C methods, and update existing
methods to reflect that the WKViewRef is now a WebView*
The construction methods will be rewritten when the smart
object construction has been solved.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/WebView.cpp: Added.
(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setThemePath):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
- UIProcess/efl/WebView.h: Added.
(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::evasObject):
(WebKit::WebView::page):
(WebKit::WebView::type):
Add a new WebKit::WebView class for EFL.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::wkPage):
(EwkView::setThemePath):
(EwkView::createGLSurface):
Base methods on C API instead of internal API as much
as currently possible.
- UIProcess/API/efl/EwkView.h:
(WebKit):
(WebView):
(EwkView):
(EwkView::wkView):
(EwkView::page):
- UIProcess/API/efl/ewk_view.cpp:
(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):
Modify to return the EwkView class for now.
- UIProcess/API/efl/ewk_view_private.h:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Updated due to changed API.
Tools:
Change platformView to be a WKView and use WKViewGetEvasObject
for the places where an Evas_Object is needed.
Instead of extracting the Ecore_Evas* from the m_view we use
the m_window instead, which actually holds the it.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::windowSnapshotImage):
- 5:17 PM Changeset in webkit [141835] by
-
- 13 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: Focus order is not controllable by tabIndex attribute on <input>
https://bugs.webkit.org/show_bug.cgi?id=108447
Reviewed by Hajime Morita.
Source/WebCore:
We make <input> elements with the multiple-fields UI focusable.
- However, we don't want to change the existing focus behavior for multiple-fields <input>. We'd like to focus on the last sub-field of an<input> with Shift + TAB focus navigation, and focus on the first sub-field of the <input> otherwise. So, we move focus immediately after the <input> gets focus.
- We don't need the isFocusableByClickOnLabel hack any more. <input> elements with the multiple-fields UI are mouse-focusable.
Test: fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html
- html/InputType.h:
(InputType): Add FocusDirection argument to handleFocusEvent, and remove
unnecessary isFocusableByClickOnLabel and focus.
- html/InputType.cpp:
(WebCore::InputType::handleFocusEvent): Ditto.
- html/PasswordInputType.cpp:
(WebCore::PasswordInputType::handleFocusEvent): Follow the argument change.
- html/PasswordInputType.h:
(PasswordInputType): Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
If this element gets focus by FocusDirectionBackward (it means the focus
is moved from the first sub-field of the element,) move the focus
backward once more. Otherwise, we focus on the first sub-filed of the
element.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make this keyboard-focusable. We have a wrong test to ensure read-only
input does NOT get focus. We'll address it later.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable):
Make this mouse-focusable.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
- html/HTMLInputElement.h:
(HTMLInputElement): Remove defaultFocus, focus, and isFocusableByClickOnLabel.
Add missing OVERRIDE to handleFocusEvent.
- html/HTMLInputElement.cpp: Remove unnecessary functions.
(WebCore::HTMLInputElement::handleFocusEvent):
Pass FocusDirection value to InputTYpe::handleFocusEvent.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
Use isMouseFocusable().
- html/HTMLElement.cpp: Remove unnecessary isFocusableByClickOnLabel.
- html/HTMLElement.h: Ditto.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Added.
- 5:13 PM Changeset in webkit [141834] by
-
- 6 edits in trunk/Source/WebKit2
Set up the storage manager as a connection queue
https://bugs.webkit.org/show_bug.cgi?id=108879
Reviewed by Sam Weinig.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::processWillOpenConnection):
Add the storage manager as a connection queue client.
(WebKit::StorageManager::processWillCloseConnection):
Remove the storage manager.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::processWillOpenConnection):
Call the storage manager.
(WebKit::WebContext::processWillCloseConnection):
Call the storage manager.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
Call the context.
(WebKit::WebProcessProxy::connectionWillClose):
Call the context.
(WebKit::WebProcessProxy::didFinishLaunching):
Remove a comment.
- 4:54 PM Changeset in webkit [141833] by
-
- 2 edits in trunk/Source/WebCore
Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
https://bugs.webkit.org/show_bug.cgi?id=107639
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-04
Reviewed by Kenneth Rohde Christiansen.
In TiledBackingStore::adjustForContentsRect method, inflating is not
needed when there is no intersections between the cover/keep rect and
the content rect.
No new tests, no change in functionality.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::adjustForContentsRect):
- 4:46 PM Changeset in webkit [141832] by
-
- 3 edits in trunk/Source/WebCore
[skia] Remove use of SkSingleInputImageFilter.
https://bugs.webkit.org/show_bug.cgi?id=108867
Reviewed by James Robinson.
This class is but a hollow shell of its former self, and has
been removed in Skia.
Covered by existing tests in css3/filters.
- platform/graphics/filters/skia/DropShadowImageFilter.cpp:
(WebCore::DropShadowImageFilter::DropShadowImageFilter):
(WebCore::DropShadowImageFilter::onFilterImage):
- platform/graphics/filters/skia/DropShadowImageFilter.h:
- 4:39 PM Changeset in webkit [141831] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98527
The bug was fixed but the test was never removed from the Mac WK2 TestExpectations file.
Remove it now.
- platform/mac-wk2/TestExpectations:
- 4:34 PM Changeset in webkit [141830] by
-
- 6 edits in trunk/Source/WebKit2
Send message when creating and destroying StorageAreaProxy objects
https://bugs.webkit.org/show_bug.cgi?id=108874
Reviewed by Sam Weinig.
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::fromSecurityOrigin):
- Shared/SecurityOriginData.h:
(SecurityOriginData):
Add helper function for creating a SecurityOriginData object given a WebCore::SecurityOrigin object.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::generateStorageAreaID):
New function to create a unique storage area ID.
(WebKit::StorageAreaProxy::StorageAreaProxy):
Send a CreateStorageArea message.
(WebKit::StorageAreaProxy::~StorageAreaProxy):
Send a DestroyStorageArea message.
(WebKit::StorageAreaProxy::contains):
Remove this assertion for now, it fires too often.
- WebProcess/Storage/StorageNamespaceProxy.h:
(WebKit::StorageNamespaceProxy::storageNamespaceID):
Add getter.
- 4:30 PM Changeset in webkit [141829] by
-
- 7 edits in trunk/Tools
Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.
https://bugs.webkit.org/show_bug.cgi?id=108788
Patch by Timothy Loh <timloh@chromium.com> on 2013-02-04
Reviewed by Ryosuke Niwa.
As per discussion in Bug 74358, it's probably preferable to remove the
behaviour of updating the author details in a ChangeLog entry. We also
want to be able to skip preparing change logs (e.g. rebaselining many
tests), so a --no-prepare-changelogs option is added to webkit-patch.
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry._parse_entry):
(ChangeLogEntry.date): Added
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_log_entries_from_changelog):
- Scripts/webkitpy/tool/commands/commandtest.py:
(CommandsTest.assert_execute_outputs):
- Scripts/webkitpy/tool/steps/options.py:
(Options): Added --no-prepare-changelogs
- Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog.options):
(PrepareChangeLog._merge_entries): date_line() gets the entire line, including
the author's name and email, but we only want to replace the date.
(PrepareChangeLog.run):
- Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest.test_resolve_existing_entry): Added tests for changed
authors. Removed unneeded variable.
- 4:28 PM Changeset in webkit [141828] by
-
- 2 edits in trunk/LayoutTests
[ Linux ] Mark media/track/track-cues-cuechange.html and media/track/track-cues-enter-exit.html as slow
https://bugs.webkit.org/show_bug.cgi?id=108876
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-04
Reviewed by Dirk Pranke.
Tests take ~5.4 seconds to run locally.
Timing out on the EWS bots but passing on the Webkit buildbots.
Marked tests as slow in TestExpectations.
- platform/chromium/TestExpectations:
- 3:57 PM Changeset in webkit [141827] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside EwkView
https://bugs.webkit.org/show_bug.cgi?id=108825
Reviewed by Anders Carlsson.
A straight-forward port towards the C API.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView): Use C API for common default preferences.
(EwkView::wkPage): Make it const and remove useless comment.
(EwkView::deviceScaleFactor):
(EwkView::title):
(EwkView::customTextEncodingName):
(EwkView::setCustomTextEncodingName):
(EwkView::informURLChange):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- 3:55 PM Changeset in webkit [141826] by
-
- 10 edits in trunk
Implement WheelEvent::deltaMode
https://bugs.webkit.org/show_bug.cgi?id=108455
Reviewed by Adam Barth.
Source/WebCore:
Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.
Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
Test: fast/event/wheel-event-constructor.html
- dom/WheelEvent.cpp:
(WebCore::WheelEventInit::WheelEventInit):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::deltaMode):
- dom/WheelEvent.h:
(WheelEventInit):
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::deltaMode):
(WheelEvent):
- dom/WheelEvent.idl:
- page/EventHandler.cpp:
(WebCore::wheelGranularityToScrollGranularity):
Source/WebKit/chromium:
- src/WebInputEventConversion.cpp:
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
LayoutTests:
Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.
Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
- fast/events/constructors/wheel-event-constructor-expected.txt:
- fast/events/constructors/wheel-event-constructor.html:
- 3:54 PM Changeset in webkit [141825] by
-
- 2 edits in trunk/Source/WebKit2
Remove an unnecessary sandbox rule.
Reviewed by Sam Weinig.
- WebProcess/com.apple.WebProcess.sb.in: We already have a file-read rule for /Library/Managed Preferences, no need for another rule for something inside it.
- 3:24 PM Changeset in webkit [141824] by
-
- 5 edits in trunk/Source/WebKit2
WebProcess crashes handling repeated NetworkProcess crashes.
<rdar://problem/13049867> and https://bugs.webkit.org/show_bug.cgi?id=108861
Reviewed by Alexey Proskuryakov.
- Rename the concept of "unschedulable loader" to "internally failed loader"
- When the NetworkProcess crashes, add all outstanding ResourceLoaders into the unschedulable pile.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::scheduleInternallyFailedLoad):
(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::remove): Also remove a non-helpful, out of date comment.
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):
- WebProcess/Network/WebResourceLoadScheduler.h:
WebResourceLoader no longer responds to crashes directly, but now exposes its WebCore ResourceLoader:
- WebProcess/Network/WebResourceLoader.cpp:
- WebProcess/Network/WebResourceLoader.h:
(WebKit::WebResourceLoader::resourceLoader):
- 3:23 PM Changeset in webkit [141823] by
-
- 14 edits5 deletes in trunk/Tools
[chromium] Remove WebEventSender and WebAccessibilityController from public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestRunner):
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner):
(WebTestProxyBase):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::webView):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::setTestIsRunning):
(WebTestRunner::WebTestInterfaces::webView):
(WebTestRunner::WebTestInterfaces::testRunner):
(WebTestRunner::WebTestInterfaces::testInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::setInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Removed.
- DumpRenderTree/chromium/TestShell.h:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 3:19 PM Changeset in webkit [141822] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Remove duplicate setting of first party for cookies
https://bugs.webkit.org/show_bug.cgi?id=108814
Reviewed by Martin Robinson.
Covered by existing tests.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest): there is no need to set
the first party for cookies here, since that is already done in
ResourceRequest::updateSoupMessage, which is called a few lines before.
- 3:18 PM Changeset in webkit [141821] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-02-04
Reviewed by Philippe Normand.
Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.
No behaviour change, covered by existing tests.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(createGstBufferForData): New helper to create a GstBuffer when
we have a data pointer and a length.
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.
- platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.
- 3:07 PM Changeset in webkit [141820] by
-
- 15 edits in trunk/Source/WebKit2
Update message generation to use the new queue client semantics
https://bugs.webkit.org/show_bug.cgi?id=108865
Reviewed by Andreas Kling.
- Scripts/webkit2/messages.py:
(connection_work_queue_message_statement):
(async_message_statement):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.h:
(WebProcess):
- 3:01 PM Changeset in webkit [141819] by
-
- 2 edits in trunk/Source/WTF
Build fix for AtomicString on iOS
Unreviewed. The commit r141812 rely on isUIThread(), there is no such things
in the tree right now. Use pthread_main_np() until more thread handling is upstreamed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-04
- wtf/text/AtomicString.cpp:
(WTF::AtomicStringTable::create):
- 2:49 PM Changeset in webkit [141818] by
-
- 6 edits1 move2 adds in trunk/Source
[Chromium] Move WorkerContextProxy to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108847
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 106829.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- workers/chromium: Added.
- workers/chromium/WorkerContextProxyChromium.cpp: Added.
(WebCore):
(WebCore::setWorkerContextProxyCreateFunction):
(WebCore::WorkerContextProxy::create):
- workers/chromium/WorkerContextProxyChromium.h: Added.
(WebCore):
Source/WebKit/chromium:
- WebKit.gyp:
- src/WebKit.cpp:
(WebKit::initializeWithoutV8):
- src/WorkerContextProxy.cpp: Removed.
- 2:39 PM Changeset in webkit [141817] by
-
- 3 edits3 adds in trunk
WebVTT <i>, <b> and <u> elements should have default styles
https://bugs.webkit.org/show_bug.cgi?id=107214
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Darin Adler.
Source/WebCore:
Added default styles for basic webvtt object types.
Test: media/track/track-css-matching-default.html
- css/mediaControls.css:
(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):
LayoutTests:
- media/track/captions-webvtt/styling-default.vtt: Added.
- media/track/track-css-matching-default-expected.txt: Added.
- media/track/track-css-matching-default.html: Added.
- 2:36 PM Changeset in webkit [141816] by
-
- 47 edits in trunk/Source
Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
https://bugs.webkit.org/show_bug.cgi?id=108668
Reviewed by Eric Seidel.
Source/WebCore:
- bindings/v8/SerializedScriptValue.cpp:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseCalc):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::customCssText):
- css/CSSParserValues.h:
(WebCore::CSSParserString::operator[]):
- css/CSSValueList.h:
(WebCore::CSSValueListInspector::item):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):
- dom/Document.cpp:
(WebCore::Document::processArguments):
- dom/Element.cpp:
(WebCore::Element::removeAttributeInternal):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::removeAttribute):
- dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::attributeItem):
- dom/SpaceSplitString.h:
(WebCore::SpaceSplitStringData::operator[]):
(WebCore::SpaceSplitString::operator[]):
- editing/TextIterator.cpp:
(WebCore::TextIterator::characterAt):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::removeFormElement):
- html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::swapTo):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
- inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::replaceProperty):
- inspector/InspectorValues.cpp:
(WebCore::InspectorArrayBase::get):
- page/WindowFeatures.cpp:
(WebCore::WindowFeatures::WindowFeatures):
- platform/audio/AudioArray.h:
(WebCore::AudioArray::at):
- platform/audio/AudioFIFO.cpp:
(WebCore::AudioFIFO::findWrapLengths):
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::setGlyphDataForIndex):
- platform/graphics/TextRun.h:
(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setDrawRange):
- platform/graphics/openvg/TiledImageOpenVG.cpp:
(WebCore::TiledImageOpenVG::setTile):
(WebCore::TiledImageOpenVG::tile):
- platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::imageTypeAtIndex):
- platform/text/QuotedPrintable.cpp:
(WebCore::lengthOfLineEndingAtIndex):
- platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::advance):
- platform/win/WebCoreTextRenderer.cpp:
(WebCore::doDrawTextAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
Source/WebKit/chromium:
- src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesCache::entryFor):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectFindMatch):
Source/WebKit2:
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::HandleArray::operator[]):
Source/WTF:
- wtf/AVLTree.h:
(WTF::AVLTreeDefaultBSet::operator[]):
- wtf/BitArray.h:
(WTF::BitArray::set):
(WTF::BitArray::get):
- wtf/FastBitVector.h:
(WTF::FastBitVector::set):
(WTF::FastBitVector::clear):
(WTF::FastBitVector::get):
- wtf/FixedArray.h:
(WTF::FixedArray::operator[]):
- wtf/RefCountedArray.h:
(WTF::RefCountedArray::at):
- wtf/TypedArrayBase.h:
(WTF::TypedArrayBase::item):
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::operator[]):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::operator[]):
- wtf/text/StringImpl.h:
(WTF::StringImpl::operator[]):
- 2:35 PM Changeset in webkit [141815] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r141809.
http://trac.webkit.org/changeset/141809
https://bugs.webkit.org/show_bug.cgi?id=108860
ARC isn't supported on 32-bit. (Requested by mhahnenberg on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-04
- API/tests/testapi.mm:
(+[TestObject testObject]):
(testObjectiveCAPI):
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:33 PM Changeset in webkit [141814] by
-
- 15 edits in trunk/Source/WebKit2
Change didReceiveMessageOnConnectionWorkQueue semantics
https://bugs.webkit.org/show_bug.cgi?id=108859
Reviewed by Sam Weinig.
Change didReceiveMessageOnConnectionWorkQueue to take a reference to an
OwnPtr<MessageDecoder>. This lets queue clients handle a message later, on a different
work queue for example. Also, get rid of the didHandleMessage boolean, since taking ownership
of the decoder implicitly means that the message was handled.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- Platform/CoreIPC/Connection.h:
(QueueClient):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageManager):
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/Storage/StorageManager.h:
(WebKit):
(StorageManager):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.h:
(WebProcess):
- 2:28 PM Changeset in webkit [141813] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/12884778> Sandbox violation due to MediaAccessibility code trying to access ~/Library/Preferences/com.apple.mediaaccessibility.plist
Reviewed by Sam Weinig.
- WebProcess/com.apple.WebProcess.sb.in:
- 2:20 PM Changeset in webkit [141812] by
-
- 3 edits in trunk/Source/WTF
Upstream iOS's AtomicString
https://bugs.webkit.org/show_bug.cgi?id=108139
Reviewed by David Kilzer.
On iOS, WebCore can be executed from two different threads. To maintain consistency,
a few changes had been made:
-The main UI thread and the WebThread share the same AtomicStringTable.
-A spin lock is needed before any access to prevent any concurrent modification of the string table.
The spin lock also prevent race on the static initialization of the shared table.
- wtf/Platform.h:
Introduce a new USE(WEB_THREAD) to scope changes related to iOS Web Thread.
- wtf/text/AtomicString.cpp:
(AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::~AtomicStringTableLocker):
(WTF::AtomicStringTable::create):
wtfThreadData() is not necessarily inlined on ARM. When it is not inlined, the old code
causes two call to the function. Instead, we can keep the value in register and pass it
to AtomicStringTable::create().
(WTF::stringTable):
(WTF::addToStringTable):
(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::find):
(WTF::AtomicString::remove):
- 2:19 PM Changeset in webkit [141811] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r137607): Loading of archives as substitute data is broken
https://bugs.webkit.org/show_bug.cgi?id=108589
Reviewed by Alexey Proskuryakov.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::resourceData): Return the content from
SubstituteData as mainResourceData if present.
- 2:18 PM Changeset in webkit [141810] by
-
- 3 edits2 adds in trunk
[CSS Grid Layout] Heap-buffer-overflow in std::sort
https://bugs.webkit.org/show_bug.cgi?id=108834
Reviewed by Abhishek Arya.
Source/WebCore:
Test: fast/css-grid-layout/grid-strict-ordering-crash.html
- rendering/RenderGrid.cpp:
(WebCore::sortByGridTrackGrowthPotential):
The std::sort documentation says that this function should define a *strict* weak ordering. Fixed the strict
part of the ordering. Also moved the function definition next to where it is needed and made the GridTrack
argument const (as it shouldn't modify them or std::sort will misbehave).
- rendering/RenderGrid.cpp:
(WebCore::sortByGridTrackGrowthPotential):
(WebCore):
LayoutTests:
- fast/css-grid-layout/grid-strict-ordering-crash-expected.txt: Added.
- fast/css-grid-layout/grid-strict-ordering-crash.html: Added.
The test requires a column / row index above the Vector inline capacity to work (which is currently 16).
The values are much higher in case we decide to bump the inline capacity.
- 2:13 PM Changeset in webkit [141809] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838
Reviewed by Oliver Hunt.
In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using.
- API/tests/testapi.mm:
(-[TestObject init]):
(-[TestObject dealloc]):
(+[TestObject testObject]):
(testObjectiveCAPI):
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:02 PM Changeset in webkit [141808] by
-
- 2 edits in trunk/Tools
[EFL] Add "full screen" parameter to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108850
Reviewed by Antonio Gomes.
Implements the {-F,--full-screen}={true,false} parameter to WebKit EFL's
MiniBrowser.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
Added '-F/--full-screen' parameter functionality.
- 1:49 PM Changeset in webkit [141807] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Implement BGRA swizzling detection
https://bugs.webkit.org/show_bug.cgi?id=81103
For OpenGLES if the extension EXT_texture_format_BGRA8888 is supported
the internal and external formats need to be BGRA.
Reviewed by Noam Rosenthal.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::driverSupportsExternalTextureBGRA):
(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::didReset):
- 1:45 PM Changeset in webkit [141806] by
-
- 5 edits in trunk
class="cue" is getting some default style
https://bugs.webkit.org/show_bug.cgi?id=108752
Source/WebCore:
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.
The value variable inside the selector is used to store different information depending on the
type of the selector so we have to check explicitly that the selector we apply filtering to
matches a pseudo element.
Existing tests modified to cover this case.
- css/RuleSet.cpp:
(WebCore::determinePropertyWhitelistType):
LayoutTests:
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.
- media/track/track-css-property-whitelist-expected.txt:
- media/track/track-css-property-whitelist.html:
- 1:37 PM Changeset in webkit [141805] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: ObjCCallbackFunction should retain the target of its NSInvocation
https://bugs.webkit.org/show_bug.cgi?id=108843
Reviewed by Darin Adler.
Currently, ObjCCallbackFunction doesn't retain the target of its NSInvocation. It needs to do
this to prevent crashes when trying to invoke a callback later on.
- API/ObjCCallbackFunction.mm:
(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):
- 1:34 PM Changeset in webkit [141804] by
-
- 15 edits in trunk/Source/WebKit2
Add didCloseOnConnectionWorkQueue to Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=108853
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::connectionDidClose):
- Platform/CoreIPC/Connection.h:
(QueueClient):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didCloseOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::didCloseOnConnectionWorkQueue):
(WebKit):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didCloseOnConnectionWorkQueue):
(WebKit):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didCloseOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didCloseOnConnectionWorkQueue):
(WebKit):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didCloseOnConnectionWorkQueue):
(WebKit):
- WebProcess/WebProcess.h:
(WebProcess):
- 1:31 PM Changeset in webkit [141803] by
-
- 2 edits in trunk/Source/WebCore
[V8] Binding Integrity crash in V8HTMLEmbedElement::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=108841
Reviewed by Adam Barth.
- html/HTMLEmbedElement.idl:
Quick change to IDL to disable binding check for now.
- 1:29 PM Changeset in webkit [141802] by
-
- 2 edits in trunk/LayoutTests
[WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552
Skip another test that depends on setting eventSender.dragMode.
- platform/wk2/TestExpectations:
- 1:29 PM Changeset in webkit [141801] by
-
- 2 edits in trunk/LayoutTests
Out-of-view check of fixed position element in frame might still be incorrect on Mac when
page is scaled
https://bugs.webkit.org/show_bug.cgi?id=105049
These tests have started passing all the time on all the Lion and Mountain Lion Debug and
Release WK1 and WK2 testers. Remove the failing expectation.
- platform/mac/TestExpectations:
- 1:28 PM Changeset in webkit [141800] by
-
- 9 edits in trunk/Source
Fix GTK+ 'make dist' in preparation for the 1.11.5 release.
Source/JavaScriptCore:
- GNUmakefile.list.am: Update the source lists.
Source/WebCore:
- GNUmakefile.list.am:
Source/WebKit2:
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WTF:
- GNUmakefile.list.am:
- 1:22 PM Changeset in webkit [141799] by
-
- 11 edits in trunk/Source
Add specific EditActions for Bold and Italic commands.
https://bugs.webkit.org/show_bug.cgi?id=108842.
<rdar://problem/13098252>
Source/WebCore:
This change is required on iOS where we need to
identify the command in order to display the correct
message in the undo popup. It is also in line with
what we do for underline, which already has its own
separate EditAction.
Reviewed by Ryosuke Niwa.
No new tests. No behavior change.
- editing/EditAction.h:
- editing/EditorCommand.cpp:
(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):
Source/WebKit/mac:
Reviewed by Ryosuke Niwa.
- WebCoreSupport/WebEditorClient.mm:
(undoNameForEditAction):
Source/WebKit/qt:
Reviewed by Ryosuke Niwa.
- WebCoreSupport/UndoStepQt.cpp:
(undoNameForEditAction):
Source/WebKit/win:
Reviewed by Ryosuke Niwa.
- WebCoreSupport/WebEditorClient.cpp:
(undoNameForEditAction):
Source/WebKit2:
Reviewed by Ryosuke Niwa.
- UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::nameForEditAction):
- 1:15 PM Changeset in webkit [141798] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 141127
BUG=172814
Review URL: https://codereview.chromium.org/12183027
- 1:12 PM Changeset in webkit [141797] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-04
Reviewed by Antonio Gomes.
RIM Bug 246976
We still need to clip the fatfinger detection rect to the viewport to
avoid wrong hitTest result.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::mouseEvent):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- 1:11 PM Changeset in webkit [141796] by
-
- 4 edits in trunk/Source/WebKit2
Use a separate queue for the connection watchdog callback in the web process
https://bugs.webkit.org/show_bug.cgi?id=108844
Reviewed by Andreas Kling.
Don't pass the connection work queue to the didCloseOnConnectionWorkQueue callback.
Instead, create a new, temporary work queue where the exit call will be dispatched to.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::connectionDidClose):
- Platform/CoreIPC/Connection.h:
(Connection):
- Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
- 1:00 PM Changeset in webkit [141795] by
-
- 6 edits in trunk
Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105478
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Antti Koivisto.
Source/WebCore:
In WebVTT lang is preprocessed and stored in the lang attribute of the element,
so we access it instead of walking up the tree the way it is done in HTML.
Existing tests were modified to cover this case.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
LayoutTests:
- media/track/captions-webvtt/styling-lang.vtt:
- media/track/track-css-matching-lang-expected.txt:
- media/track/track-css-matching-lang.html:
- 12:40 PM Changeset in webkit [141794] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 140975
BUG=167728
Review URL: https://codereview.chromium.org/12194024
- 12:37 PM Changeset in webkit [141793] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 141198
BUG=171830
Review URL: https://codereview.chromium.org/12178024
- 12:30 PM Changeset in webkit [141792] by
-
- 2 edits in trunk/Source/WebCore
Disable autoscrolling the main frame if main frame scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=108848
<rdar://problem/13004059>
Reviewed by Simon Fraser.
Ensure that the main frame can scroll at all before allowing an autoscroll.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::canAutoscroll):
- 11:48 AM Changeset in webkit [141791] by
-
- 3 edits2 adds in trunk
XSS Auditor bypass via svg tags and xlink:href
https://bugs.webkit.org/show_bug.cgi?id=84158
Source/WebCore:
This patch adds a test for the xlink:href attribute inside of
script tokens. The test is complicated by the namespacing; the
xlink hrefAttr qualified name does not contain a literal "xlink"
prefix but only the URI of the namespace.
Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.
Test: http/tests/security/xssAuditor/svg-script-tag.html
- html/parser/XSSAuditor.cpp:
(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterScriptToken):
LayoutTests:
Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.
- http/tests/security/xssAuditor/svg-script-tag-expected.txt: Added.
- http/tests/security/xssAuditor/svg-script-tag.html: Added.
- 11:39 AM Changeset in webkit [141790] by
-
- 10 edits in trunk/Source/WebCore
Update CaptionUserPreferences
https://bugs.webkit.org/show_bug.cgi?id=108783
Reviewed by Dean Jackson.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Mark font size as important
when necessary.
- page/CaptionUserPreferences.h:
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): New, allow a port to remember that
the user has chosen to see captions.
(WebCore::CaptionUserPreferences::setPreferredLanguage): New, allow a port to remember the
user's preferred caption language.
(WebCore::CaptionUserPreferences::preferredLanguages): New, return a Vector of the user's
preferred caption languages.
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
- page/PageGroup.cpp:
(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::captionFontSizeScale):
- page/PageGroup.h:
- platform/Language.cpp:
(WebCore::userPreferredLanguagesOverride): New, return the user preferred languages override
used during testing.
- platform/Language.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::kind):
- 11:26 AM Changeset in webkit [141789] by
-
- 6 edits in trunk/Source
Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
https://bugs.webkit.org/show_bug.cgi?id=108729
<rdar://problem/13047546>
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add didCommitChangesForLayer and storage for the
current PlatformLayer corresponding to m_pageOverlayLayer.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Update the TileCache's visible rect.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward exposed rect changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Forward scrollability changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer): Allow the page overlay layer to become tiled. Update its exposed rect and whether or not it respects the exposed rect if it's tiled upon creation.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer): If a GraphicsLayer's platform layer changes (because it switched to or from a tiled layer), reparent it. If it's switching to a tiled layer, update the exposed rect and whether or not it should respect the exposed rect.
- WebCore.exp.in:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): The "for this layer only" variant
of flushCompositingState wasn't informing its client that it committed changes for the layer.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): We now explicitly want to be able to have a
GraphicsLayerCA switch into or out of tiling while being unparented (we'll get a client callback and
swap out its parent ourselves).
- 11:18 AM Changeset in webkit [141788] by
-
- 7 edits in trunk/Source/JavaScriptCore
For ARMv7s use integer divide instruction for divide and modulo when possible
https://bugs.webkit.org/show_bug.cgi?id=108840
Reviewed in person by Filip Pizlo.
Added ARMv7s integer divide path for ArithDiv and ArithMod where operands and results are integer.
This is patterned after the similar code for X86. Also added modulo power of 2 optimization
that uses logical and. Added sdiv and udiv to the ARMv7 disassembler. Put all the changes
behind #if CPU(APPLE_ARMV7S).
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::sdiv):
(JSC::ARMv7Assembler::udiv):
- dfg/DFGCommon.h:
(JSC::DFG::isARMv7s):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 11:14 AM Changeset in webkit [141787] by
-
- 13 edits2 adds in trunk
[CSS Grid Layout] Add parsing for grid-auto-flow
https://bugs.webkit.org/show_bug.cgi?id=108397
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-auto-flow-get-set.html
This change adds the parsing, application and conversion back through getComputedStyle
for the new property -webkit-grid-auto-flow, which accpets the following:
-webkit-grid-auto-flow: none | rows | columns
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added code to convert the RenderStyle information back into a CSS value.
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
Implemented parsing for -webkit-grid-auto-flow.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Added the conversion operators, used for parsing and getComputedStyle.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
Added -webkit-grid-auto-flow to the list of the not inherited properties.
- css/CSSPropertyNames.in:
Added the new value and keywords.
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
Added a handler for the new CSS property.
- rendering/style/RenderStyle.h:
Added the usual getter / setter / initial function.
- rendering/style/RenderStyleConstants.h:
Added a new enum GridAutoFlow to hold the parsed value.
- rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
- rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
Updated after adding a new field for the GridAutoFlow value.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-auto-flow-get-set.html: Added.
- fast/css-grid-layout/resources/grid.css:
(.gridAutoFlowNone):
(.gridAutoFlowColumn):
(.gridAutoFlowRow):
Added these new classes to our common style.
- 11:01 AM Changeset in webkit [141786] by
-
- 2 edits in trunk/Source/JavaScriptCore
Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
<http://webkit.org/b/108749>
Reviewed by Joseph Pecoraro.
- JavaScriptCore.xcodeproj/project.pbxproj: Add
PrivateHeaders/JSBasePrivate.h to list of headers to check in
"Check for Inappropriate Macros in External Headers" build phase
script.
- 10:59 AM Changeset in webkit [141785] by
-
- 5 edits1 move1 add1 delete in trunk/Tools
[chromium] remove WebTestPlugin from the public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createPlugin):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.
(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner):
(WebTestRunner::TestPlugin::~TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::updateGeometry):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::parseOpacity):
(WebTestRunner::TestPlugin::parseBoolean):
(WebTestRunner::TestPlugin::initScene):
(WebTestRunner::TestPlugin::drawScene):
(WebTestRunner::TestPlugin::destroyScene):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleInputEvent):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
(WebTestRunner::TestPlugin::create):
(WebTestRunner::TestPlugin::mimeType):
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.
(WebTestRunner):
(TestPlugin):
(WebTestRunner::TestPlugin::scriptableObject):
(WebTestRunner::TestPlugin::canProcessDrag):
(WebTestRunner::TestPlugin::paint):
(WebTestRunner::TestPlugin::updateFocus):
(WebTestRunner::TestPlugin::updateVisibility):
(WebTestRunner::TestPlugin::acceptsInputEvents):
(WebTestRunner::TestPlugin::didReceiveResponse):
(WebTestRunner::TestPlugin::didReceiveData):
(WebTestRunner::TestPlugin::didFinishLoading):
(WebTestRunner::TestPlugin::didFailLoading):
(WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
(WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
(WebTestRunner::TestPlugin::isPlaceholder):
(WebTestRunner::TestPlugin::prepareTexture):
(WebTestRunner::TestPlugin::context):
(Scene):
(WebTestRunner::TestPlugin::Scene::Scene):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::createPlugin):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createPlugin):
- 10:52 AM Changeset in webkit [141784] by
-
- 8 edits1 copy1 move1 add in trunk/Source
[Chromium] Move IDBFactoryBackendInterface to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108638
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 106829.
Source/WebCore:
- Modules/indexeddb/chromium: Added.
- Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.
(WebCore):
(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
(WebCore::IDBFactoryBackendInterface::create):
- Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.
(WebCore):
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
Source/WebKit/chromium:
- WebKit.gyp:
- src/AssertMatchingEnums.cpp:
- src/IDBFactoryBackendInterface.cpp: Removed.
- src/IDBFactoryBackendProxy.h:
- src/WebKit.cpp:
(WebKit::initializeWithoutV8):
- 10:43 AM Changeset in webkit [141783] by
-
- 45 edits in trunk/Source
Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
https://bugs.webkit.org/show_bug.cgi?id=108688
Reviewed by Eric Seidel.
Source/WebCore:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):
- Modules/speech/SpeechGrammar.cpp:
(WebCore::SpeechGrammar::setSrc):
- Modules/speech/SpeechGrammarList.cpp:
(WebCore::SpeechGrammarList::addFromUri):
- Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::cellForColumnAndRow):
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reattach):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reattach):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reattach):
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
- css/StyleResolver.cpp:
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
- css/WebKitCSSFilterRule.cpp:
(WebCore::WebKitCSSFilterRule::reattach):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::reattach):
- css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reattach):
- editing/EditCommand.h:
(WebCore::toSimpleEditCommand):
- editing/visible_units.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
- html/HTMLCollection.cpp:
(WebCore::LiveNodeListBase::setItemCache):
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
- page/Frame.cpp:
(WebCore::Frame::frameForWidget):
- platform/RefCountedSupplement.h:
(WebCore::RefCountedSupplement::from):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::firstLineBlock):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::positionForPoint):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
(WebCore::SharedWorkerConnectTask::performTask):
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- workers/WorkerContext.cpp:
(WebCore::CloseWorkerContextTask::performTask):
- workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::performTask):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
Source/WebKit/chromium:
- src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
(WebKit::getWebFrame):
- src/LocalFileSystemChromium.cpp:
(WebCore::LocalFileSystem::deleteFileSystem):
- src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::connectTask):
(WebKit::resumeWorkerContextTask):
(WebKit::connectToWorkerContextInspectorTask):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::disconnectFromWorkerContextInspectorTask):
(WebKit::dispatchOnInspectorBackendTask):
Source/WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 10:35 AM Changeset in webkit [141782] by
-
- 2 edits in trunk/Source/WebKit/gtk
Made the documentation on the confirmed argument for the
WebView::script-confirm signal clearer about its type.
Reviewed by Martin Robinson.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- 10:34 AM Changeset in webkit [141781] by
-
- 2 edits in trunk/Source/WebKit2
Use UNUSED_PARAM instead of C style comments.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):
- 10:32 AM Changeset in webkit [141780] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Stop using libsoup in ewk_url_scheme_request
https://bugs.webkit.org/show_bug.cgi?id=108816
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-04
Reviewed by Anders Carlsson.
As we are trying to minimize use of external dependencies in our WK2 EFL
API implementation, we should stop using libsoup in
ewk_url_scheme_request and use the WK2 C API instead.
- UIProcess/API/efl/ewk_url_scheme_request.cpp:
(EwkUrlSchemeRequest::EwkUrlSchemeRequest):
- 10:29 AM Changeset in webkit [141779] by
-
- 3 edits in trunk/Tools
Add a new method for obtaining a build-type-dependent path,
instead of modifying all call sites to pass it in.
Reviewed by Martin Robinson.
- Scripts/run-gtk-tests:
(TestRunner.init): use the new method, which takes a tuple.
(TestRunner._setup_testing_environment): ditto.
- gtk/common.py:
(get_build_path): accept a tuple that may include Release and
Debug as build types, for searching.
(build_path_for_build_types): new method that finds the path when
it is dependent on the build type.
(build_path): restore its original behaviour.
- 10:22 AM WebKitGTK/1.10.x edited by
- Add a new proposed item for 1.10.3 (diff)
- 10:21 AM Changeset in webkit [141778] by
-
- 2 edits in trunk/Source/WebCore
[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
https://bugs.webkit.org/show_bug.cgi?id=108479
Reviewed by Emil A Eklund.
Remove a FIXME that intended to solve the value truncation.
Should positively affect SVG text positioning.
No new tests, partially covered by manual test
ManualTests/harfbuzz-mouse-selection-crash.html.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::offsetForPositionForComplexText):
- 10:19 AM Changeset in webkit [141777] by
-
- 26 edits in trunk
Web Inspector: Create a container class for SidebarPane instances
https://bugs.webkit.org/show_bug.cgi?id=108183
Source/WebCore:
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.
SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
SidebarPanes are inserted into DOM lazily and can belong to more than one container.
SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in https://bugs.webkit.org/show_bug.cgi?id=107552).
There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
shared between Elements and Sources sidebars.
- inspector/front-end/AuditResultView.js:
(WebInspector.AuditResultView):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):
- inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
- inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.title):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPane.prototype.setShowCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.wasShown):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype._addTitle):
(WebInspector.SidebarPaneStack.prototype._attachToPane):
(WebInspector.SidebarPaneStack.prototype._isExpanded):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarPaneStack.prototype._togglePane):
(WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
- inspector/front-end/inspector.css:
(.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
(.pane-title):
(.pane-title:active):
(.pane-title::before):
(.pane-title.expanded::before):
(.pane-title > select):
(.pane-title > select:hover):
(.pane-title > select:active):
(.pane-title > select.select-settings):
(.pane-title > select.select-filter):
(.pane-title > select > option, .pane-title > select > hr):
(.pane-title > .pane-title-button):
(.pane-title > .pane-title-button:hover):
(.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
(.pane-title > .pane-title-button.add):
(.pane-title > .pane-title-button.element-state):
(.pane-title > .pane-title-button.refresh):
(.pane.visible > .body):
(.pane.visible:nth-last-of-type(1)):
(.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
(.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
(body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):
LayoutTests:
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.
- http/tests/inspector/elements-test.js:
(initialize_ElementTest.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):
- inspector/audits/audits-panel-functional-expected.txt:
- inspector/audits/audits-panel-noimages-functional-expected.txt:
- inspector/debugger/error-in-watch-expressions.html:
- inspector/debugger/properties-special.html:
- inspector/debugger/watch-expressions-panel-switch.html:
- inspector/debugger/watch-expressions-preserve-expansion.html:
- inspector/extensions/extensions-audits-api-expected.txt:
- inspector/extensions/extensions-audits-content-script-expected.txt:
- inspector/extensions/extensions-audits-expected.txt:
- inspector/extensions/extensions-events.html:
- inspector/extensions/extensions-sidebar.html:
- inspector/styles/lazy-computed-style.html:
- 10:14 AM Changeset in webkit [141776] by
-
- 4 edits in trunk/LayoutTests
[Qt][Wk2] Unreviewed gardnening. Skip failing tests.
- 9:45 AM Changeset in webkit [141775] by
-
- 5 edits in trunk/Source/WebCore
Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707
Reviewed by Eric Seidel.
The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.
Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.
No new tests, no change in functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPadding):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):
- 9:42 AM Changeset in webkit [141774] by
-
- 8 edits in trunk
Web Inspector: add round braces to javascript tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108692
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.
Source/WebCore:
Change SourceJavascriptTokenizer.re2js file to produce "brace-start"
and "brace-end" tokens for round braces.
Regenerate SourceJavascriptTokenizer.js according to new re2js file.
No new tests: no change in behaviour.
- inspector/front-end/SourceJavaScriptTokenizer.js:
(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
- inspector/front-end/SourceJavaScriptTokenizer.re2js:
LayoutTests:
Updated test expectations to correspond to new tokens "brace-start"
and "brace-end" in javascript tokenizer.
- inspector/editor/highlighter-basics-expected.txt:
- inspector/editor/text-editor-long-line-expected.txt:
- inspector/syntax-highlight-html-expected.txt:
- inspector/syntax-highlight-javascript-expected.txt:
- 9:38 AM Changeset in webkit [141773] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
https://bugs.webkit.org/show_bug.cgi?id=108760
Patch by Andrew Lo <anlo@rim.com> on 2013-02-04
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.
Internal PR 286218.
When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
we need to set the needs one-shot drawing synchronization flag
before rendering, so that when the render is completed we
commit the root layer.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
- 8:42 AM Changeset in webkit [141772] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831
Reviewed by Vsevolod Vlasov.
Otherwise, the ports that use page scale factor have broken overlay.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
- 7:56 AM Changeset in webkit [141771] by
-
- 17 edits in trunk/Source/WebCore
[v8] explicit isolate parameter for MakeWeak calls
https://bugs.webkit.org/show_bug.cgi?id=108818
Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.
No new tests. No change in functionality.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::weakCallback):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
(DOMDataStore):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::defaultWeakCallback):
(DOMWrapperMap):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):
- bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::weakReferenceCallback):
- bindings/v8/ScriptState.h:
(ScriptState):
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::weakEventListenerCallback):
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):
- bindings/v8/V8AbstractEventListener.h:
(V8AbstractEventListener):
- bindings/v8/V8EventListener.cpp:
(WebCore::V8EventListener::V8EventListener):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::V8LazyEventListener):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
- bindings/v8/V8MutationCallback.h:
(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):
- bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::V8NPTemplateMap):
(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):
- bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
(WebCore::StringCache::v8ExternalStringSlow):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):
- bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallbackCustom):
- 7:00 AM Changeset in webkit [141770] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Weird stripe at the end of the page
https://bugs.webkit.org/show_bug.cgi?id=108820
Reviewed by Noam Rosenthal.
The page scroll bound was artificially enlarged by one causing the artifact appearance.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::boundContentsPositionAtScale):
- 6:45 AM Changeset in webkit [141769] by
-
- 15 edits1 move7 deletes in trunk
Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020
Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.
Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.
Source/WebKit/chromium:
This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.
- features.gypi:
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):
- tests/data/non-fast-scrollable.html:
- tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.
LayoutTests:
The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.
- compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
- compositing/overflow/iframe-inside-overflow-clipping.html:
- compositing/overflow/nested-scrolling.html:
- compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
- compositing/overflow/scrolling-content-clip-to-viewport.html:
- compositing/overflow/scrolling-without-painting.html:
- compositing/overflow/textarea-scroll-touch.html:
- compositing/overflow/updating-scrolling-content.html:
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
- platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
- platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
- 6:43 AM Changeset in webkit [141768] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Allow user to change dock side by dragging toolbar
https://bugs.webkit.org/show_bug.cgi?id=108073
Dragging toolbar to the right/bottom will change the dock side accordingly
instead of changing the inspector window height (if dock to right is available).
Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.
No new tests, because of pure inspector UI change.
- inspector/front-end/DockController.js:
(WebInspector.DockController.prototype.dockSide):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isDockedToBottom):
(WebInspector.Toolbar.prototype._isUndocked):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._toolbarDragMoveWindow):
(WebInspector.Toolbar.prototype._toolbarDragChangeDocking):
(WebInspector.Toolbar.prototype._toolbarDragChangeHeight):
- inspector/front-end/UIUtils.js:
(WebInspector._elementDragStart):
(WebInspector._elementDragMove):
(WebInspector._cancelDragEvents):
(WebInspector._elementDragEnd):
- 6:35 AM Changeset in webkit [141767] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping failing tests.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-04
- platform/qt/TestExpectations:
- 6:23 AM Changeset in webkit [141766] by
-
- 4 edits in trunk
Web Inspector: sync list of console API methods to that used by auto-complete
https://bugs.webkit.org/show_bug.cgi?id=108804
Reviewed by Pavel Feldman.
- push new method names from InjectedScriptSource to RuntimeModel;
- add a comment to InjectedScriptSource noting the necessity of keeping lists in sync.
- inspector/InjectedScriptSource.js:
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):
- 6:08 AM Changeset in webkit [141765] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Network] Minor refactorings.
https://bugs.webkit.org/show_bug.cgi?id=108162
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.
Apply minor refactorings to NetworkPanel.js
Add hint to statusbar selector buttons.
- English.lproj/localizedStrings.js: Added hint string.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createStatusBarItems): Ditto.
(WebInspector.NetworkLogView.prototype._makeHeaderFragment):
Applied minor refactoring.
(WebInspector.NetworkLogView.prototype._createStatusBarItems.createFilterElement):
Ditto.
(WebInspector.NetworkLogView.prototype._updateOffscreenRows): Ditto.
(WebInspector.NetworkPanel.prototype._onRowSizeChanged): Ditto.
- 5:55 AM Changeset in webkit [141764] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=108437
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.
CPU Profile code has obsolete inline-comments to clarify types.
Currently we use JSDocs to specify types.
Also applied some minor refactorings.
- inspector/front-end/BottomUpProfileDataGridTree.js:
(WebInspector.BottomUpProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._merge):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.BottomUpProfileDataGridTree):
Added JSDocs. Renamed parameters.
(WebInspector.BottomUpProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
Ditto.
- inspector/front-end/CPUProfileView.js: Removed unused getter/setter.
(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
Un-nested. Added JSDocs.
(WebInspector.CPUProfileView.prototype._getBottomUpProfileDataGridTree):
Added JSDocs. Turned to method from getter. Simplified.
(WebInspector.CPUProfileView.prototype._getTopDownProfileDataGridTree):
Added JSDocs. Turned to method from getter.
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
Optimized.
- inspector/front-end/DataGrid.js: Added JSDocs.
- inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.ProfileDataGridNode.prototype.createCell): Added JSDocs.
(WebInspector.ProfileDataGridNode.prototype.sort): Ditto.
(WebInspector.ProfileDataGridNode.prototype.insertChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
Added JSDocs. Removed parameter.
(WebInspector.ProfileDataGridNode.prototype.findChild): Added JSDocs.
(WebInspector.ProfileDataGridTree): Added JSDocs. Renamed parameter.
- inspector/front-end/TopDownProfileDataGridTree.js:
(WebInspector.TopDownProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.TopDownProfileDataGridTree):
Added JSDocs. Renamed parameter.
(WebInspector.TopDownProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
Ditto.
- 5:48 AM Changeset in webkit [141763] by
-
- 24 edits in trunk/Source/WebCore
[v8] use toV8Fast in hand coded callbacks
https://bugs.webkit.org/show_bug.cgi?id=108817
Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.
No new tests. No change in functionality.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
- bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
- bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
- bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore):
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
- bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::V8HTMLCollection::namedPropertyGetter):
- bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorGetter):
- bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:
(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):
- bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
- bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
- bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
- bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
- bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
- 4:44 AM Changeset in webkit [141762] by
-
- 2 edits in trunk/Tools
Remove duplicate entry from DumpRenderTree Xcode project
$ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Remove duplicate.
- 4:41 AM Changeset in webkit [141761] by
-
- 2 edits in trunk/Tools
Sort TestWebKitAPI Xcode project file
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 4:36 AM Changeset in webkit [141760] by
-
- 2 edits in trunk/Source/WebKit2
Sort WebKit2 Xcode project file
- WebKit2.xcodeproj/project.pbxproj:
- 4:32 AM Changeset in webkit [141759] by
-
- 2 edits in trunk/Source/WebCore
Remove duplicate entry from WebCore Xcode project
$ uniq Source/WebCore/WebCore.xcodeproj/project.pbxproj | diff -u - Source/WebCore/WebCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
- WebCore.xcodeproj/project.pbxproj: Remove duplicate.
- 4:30 AM Changeset in webkit [141758] by
-
- 2 edits in trunk/Source/WebCore
Sort WebCore Xcode project file
- WebCore.xcodeproj/project.pbxproj:
- 4:26 AM Changeset in webkit [141757] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove duplicate entries from JavaScriptCore Xcode project
$ uniq Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | diff -u - Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
- JavaScriptCore.xcodeproj/project.pbxproj: Remove duplicates.
- 4:21 AM Changeset in webkit [141756] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][Qt] Replace WebPageGroup usage for user scripts with WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=108651
Reviewed by Sam Weinig.
It's straight-forward port towards the C API.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):
- UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
- 4:21 AM Changeset in webkit [141755] by
-
- 2 edits in trunk/Source/JavaScriptCore
Sort JavaScriptCore Xcode project file
- JavaScriptCore.xcodeproj/project.pbxproj:
- 4:14 AM Changeset in webkit [141754] by
-
- 2 edits in trunk/Source/WTF
Sort WTF Xcode project file
- WTF.xcodeproj/project.pbxproj:
- 4:13 AM Changeset in webkit [141753] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Sort ANGLE Xcode project file.
- ANGLE.xcodeproj/project.pbxproj:
- 3:34 AM Changeset in webkit [141752] by
-
- 2 edits in trunk/Source/WebCore
[v8] disable ascii check once latin-1 is enabled in v8
https://bugs.webkit.org/show_bug.cgi?id=108805
Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.
No new tests. No change in functionality.
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
- 2:46 AM Changeset in webkit [141751] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: make tabbed pane header a relayout boundary.
https://bugs.webkit.org/show_bug.cgi?id=108650
Reviewed by Alexander Pavlov.
Otherwise, its measure width routine causes total reflow.
- inspector/front-end/tabbedPane.css:
(.tabbed-pane-header):
- 2:27 AM Changeset in webkit [141750] by
-
- 9 edits2 adds in trunk/Source/WebCore
Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
https://bugs.webkit.org/show_bug.cgi?id=108797
Reviewed by Hajime Morita.
This is a following patch after r141373. Now we can have
InspectorCSSOMWrappers in its own file since CSSDefaultStyleSheets
was factored out from StyleResolver.cpp in r141733.
WebCore/inspector/ directory is used for basic inspector
functionalities. Therefore, I've put
InspectorCSSOMWrappers.{h,cpp} in WebCore/css/ rather than
WebCore/inspector/.
No new tests, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/InspectorCSSOMWrappers.cpp: Added.
(WebCore):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
- css/InspectorCSSOMWrappers.h: Added.
(WebCore):
(InspectorCSSOMWrappers):
- css/StyleResolver.cpp:
- css/StyleResolver.h:
- 1:33 AM Changeset in webkit [141749] by
-
- 21 edits1 add in trunk/Source
[Soup] Wrap SoupSession by NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=108615
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Implement NetworkStorageSession for ports using soup. It has been
separated from NetworkingContext, so now we have a default storage
session, which is the same as before but now wrapped with NetworkStorageSession,
and it can be overridden by the networking context.
No change in behavior so no new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- loader/CookieJar.cpp:
(WebCore):
Now we also get the storage session from the networking context
and not the other way.
- platform/network/NetworkStorageSession.h:
(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
Hold a SoupSession pointer for ports using soup. Added a setter because it is
necessary for API's that allow it to be specified per page, like EFL WK1.
- platform/network/NetworkingContext.h:
(NetworkingContext):
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForSession):
- platform/network/soup/NetworkStorageSessionSoup.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp.
(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createDefaultSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sessionFromContext):
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- loader/CookieJar.cpp:
(WebCore):
- platform/network/NetworkStorageSession.h:
(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
- platform/network/NetworkingContext.h:
(NetworkingContext):
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookieJarForSession):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sessionFromContext):
Source/WebKit/efl:
Changed to hold the SoupSession pointer in a NetworkStorageSession
so we can pass it to WebCore. _Ewk_View_Private_Data has to be
changed for that reason.
- WebCoreSupport/FrameNetworkingContextEfl.cpp:
(WebCore::FrameNetworkingContextEfl::storageSession):
- WebCoreSupport/FrameNetworkingContextEfl.h:
(FrameNetworkingContextEfl):
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(EWKPrivate::storageSession):
(EWKPrivate):
- ewk/ewk_view_private.h:
(EWKPrivate):
Source/WebKit/gtk:
- WebCoreSupport/FrameNetworkingContextGtk.cpp:
(WebKit::FrameNetworkingContextGtk::storageSession):
- WebCoreSupport/FrameNetworkingContextGtk.h:
(FrameNetworkingContextGtk):
Source/WebKit2:
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):
- 1:08 AM Changeset in webkit [141748] by
-
- 16 edits3 deletes in trunk/LayoutTests
[Chromium] Rebaseline for r141741
https://bugs.webkit.org/show_bug.cgi?id=108791
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
- platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
- platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium/TestExpectations:
- 1:01 AM Changeset in webkit [141747] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: source location in statusbar has few bugs in it
https://bugs.webkit.org/show_bug.cgi?id=108748
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.
Call super method statusBarItems in SnippetJavaScriptSourceFrame class
and merge its results. Fix css styles for source location in statusbar
and rename its css class into a less confusing name.
No new test: no change in behaviour.
- inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/inspector.css:
(.source-frame-cursor-position):
- 12:26 AM Changeset in webkit [141746] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
https://bugs.webkit.org/show_bug.cgi?id=108766
Reviewed by Kentaro Hara.
This patch refactors checkAddChild and checkReplaceChild to remove the
creation of an extra ExceptionCode that's not necessary for the
desired behavior, and to bring the ExceptionCode usage into line with
the rest of WebKit (this was the only case where ExceptionCode was
assigned inside an 'if' statement's condition).
After this patch, 'ec' will always be assigned a value, even if the
result of 'checkAcceptChild' is 0. This would only change behavior if
'ec' was non-zero coming into the function, and 'checkAcceptChild'
returned 0. Since every callsite is either directly after an explicit
zeroing of 'ec', or after an 'if (ec)' clause, that case should never
appear. This patch, therefore, shouldn't visibly change WebKit's
behavior.
- dom/ContainerNode.cpp:
(WebCore::checkAddChild):
(WebCore::checkReplaceChild):
Feb 3, 2013:
- 11:44 PM Changeset in webkit [141745] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108793
Unreviewed EFL gardening.
Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as
flaky due to Bug 108058. It sometimes crashes on the bots.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl-wk2/TestExpectations:
- 11:16 PM Changeset in webkit [141744] by
-
- 8 edits in trunk/Source
Upstream ENABLE_PDFKIT_PLUGIN settting
<http://webkit.org/b/108792>
Reviewed by Tim Horton.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN
on iOS since PDFKit is a Mac-only framework.
- 11:14 PM Changeset in webkit [141743] by
-
- 2 edits in trunk/Source/WebKit2
Silently block one more directory needed for NSApplication initialization.
Reviewed by Sam Weinig.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:02 PM Changeset in webkit [141742] by
-
- 4 edits in trunk/Source/WebCore
Split per-resolve logic out from StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=96421
Reviewed by Eric Seidel.
Implemented class StyleResolver::State and added m_state to
StyleResolver. All member variables used for per-resolve logic are
moved into the state class.
No new tests, because just refactoring.
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::cacheBorderAndBackground):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::addMatchedRule):
(StyleResolver):
(State):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
Added "m_state." to access member variables used for per-resolve logic.
- 10:58 PM Changeset in webkit [141741] by
-
- 4 edits in trunk
Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
https://bugs.webkit.org/show_bug.cgi?id=108791
Reviewed by Kentaro Hara.
Source/WebCore:
We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
Chromium Windows XP because of lack of LocaleNameToLCID API. This change
add manual mapping from locale names to LCIDs for Windows XP.
No new tests. This doesn't make any behavior changes in products, and
this improves some test results.
- platform/text/win/LocaleWin.cpp:
(WebCore): Define NameToLCIDMap.
(WebCore::removeLastComponent):
Remove the last component separated with '-'.
(WebCore::ensureNameToLCIDMap):
Add locale names used in layout tests.
(WebCore::convertLocaleNameToLCID):
Find an appropriate LCID longest matching with the specified locale name.
(WebCore::LCIDFromLocale):
Use convertLocaleNameToLCID if LocaleNameToLCID is not available.
LayoutTests:
- platform/chromium/TestExpectations:
Mark affected tests failure.
Actually we should be able to remove XP-specific test results for
them. We just mark them in this patch just in case, and do rebaseline
later.
- 10:17 PM Changeset in webkit [141740] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking some as timing out.
- platform/chromium/TestExpectations:
- 10:16 PM Changeset in webkit [141739] by
-
- 3 edits in trunk/Tools
PatchLogs are not getting created on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=108593
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-03
Reviewed by Eric Seidel.
Added missing "added" patch event to submit-to-ews handler.
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/submittoews.py:
(SubmitToEWS._add_attachment_to_ews_queues):
- 10:11 PM Changeset in webkit [141738] by
-
- 24 edits in trunk/Source/WebCore
Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
https://bugs.webkit.org/show_bug.cgi?id=108775
Reviewed by Hajime Morita.
We'd like to add a FocusDirection argument to
HTMLTextFormControlElement::handleFocusEvent in order to fix Bug
- This is a preparation for it.
We need to add FocusDirection arguments to some focus-related functions
to pass it correctly when TAB or Shift+TAB is pressed.
No new tests. This doesn't make any behavior changes.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
To pass the FocusDirection argument to handleFocusEvent, we need to add
it to dispatchFocusEvent too.
- html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
Add FocusDirection arugment to dispatchFocusEvent.
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add FocusDirection argument.
- dom/Node.cpp:
(WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.
- dom/Node.h:
(Node): Ditto.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode): Add FocusDirection argument in
order to pass it to Node::dispatchFocusEvent.
- dom/Document.h:
(Document): Ditto.
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
Adjust Node::dispatchFocusEvent argument.
(WebCore::FocusController::advanceFocusInDocumentOrder):
Pass FocusDirectio to Element::focus.
(WebCore::FocusController::setFocusedNode):
Add FocusDirection argument in order to pass it to Document::setFocusedNode.
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Pass FocusDirectio to Element::focus.
- page/FocusController.h:
(FocusController): Add FocusDirection argument to setFocusedNode.
- dom/Element.cpp:
(WebCore::Element::focus):
Add FocusDirection argument to pass it to FocusController::setFocusedNode.
- dom/Element.h:
(Element): Ditto.
- WebCore.exp.in:
Update FocusController::setFocusedNode and Document::setFocusedNode.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.
- html/HTMLLabelElement.h:
(HTMLLabelElement): Ditto.
- html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::focus): Ditto.
- html/HTMLLegendElement.h:
(HTMLLegendElement): Ditto.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.
- html/HTMLSelectElement.h:
(HTMLSelectElement): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultFocus):
Add FocusDirection argument in order to pass it from
HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
(WebCore::HTMLInputElement::focus):
Pass the FocusDirection argument to InputType::focus. See above.
(WebCore::HTMLInputElement::handleFocusEvent):
Adjust FocusDirection argument.
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::focus): Add FocusDirection argument.
- html/InputType.h:
(InputType): Ditto.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
Add FocusDirection argument to follow InputType.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Ditto.
- 10:02 PM Changeset in webkit [141737] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.
- platform/chromium/TestExpectations:
- 9:59 PM Changeset in webkit [141736] by
-
- 16 edits in trunk/Source/WebKit
Fix build warning after r141473
https://bugs.webkit.org/show_bug.cgi?id=108782
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.
Fix -Wunused-parameter build warning.
Source/WebKit/blackberry:
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
Source/WebKit/chromium:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::getClientPasteboardDataForRange):
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::getClientPasteboardDataForRange):
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::getClientPasteboardDataForRange):
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::getClientPasteboardDataForRange):
Source/WebKit/wince:
- WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):
Source/WebKit/wx:
- WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::getClientPasteboardDataForRange):
- 9:11 PM Changeset in webkit [141735] by
-
- 8 edits1 add in trunk/Source/WebCore
Adds usage instrumentation for indexedDB
Includes new header file in project files
https://bugs.webkit.org/show_bug.cgi?id=107772
Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-03
Reviewed by Tony Chang.
Currently untestable. Has zero effect apart from histogramming.
- GNUmakefile.list.am:
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBHistograms.h: Added.
(WebCore):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 8:54 PM Changeset in webkit [141734] by
-
- 3 edits in trunk/Tools
Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
https://bugs.webkit.org/show_bug.cgi?id=108777
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-02-03
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 8:53 PM Changeset in webkit [141733] by
-
- 8 edits2 adds in trunk/Source/WebCore
Split default style-sheet statics out from StyleResolver into its own class
https://bugs.webkit.org/show_bug.cgi?id=107780
Reviewed by Dimitri Glazkov.
Factored static variables and logic about default style sheets out from StyleResolver into its own class
CSSDefaultStyleSheets. This is a following patch after r141373.
No new tests, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/CSSDefaultStyleSheets.cpp: Added.
(WebCore):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::parseUASheet):
(WebCore::CSSDefaultStyleSheets::initDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
- css/CSSDefaultStyleSheets.h: Added.
(WebCore):
(CSSDefaultStyleSheets):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):
- 8:27 PM FeatureFlags edited by
- Rename CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to … (diff)
- 8:25 PM Changeset in webkit [141732] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning after r141648
https://bugs.webkit.org/show_bug.cgi?id=108784
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.
Fix -Wunused-parameter build warning.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
- 8:04 PM Changeset in webkit [141731] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
https://bugs.webkit.org/show_bug.cgi?id=108740
Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-03
Reviewed by Kent Tamura.
The calls to m_widgetClient->show() and setFocus() do not appear to be
necessary, and the former causes problems on at least on platform.
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
(WebKit::WebHelperPluginImpl::setFocus): Should never be called.
- 7:22 PM Changeset in webkit [141730] by
-
- 5 edits in trunk/Source/WebCore
[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441
Reviewed by Adam Barth.
A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
- dom/EventTarget.idl: Added [EventTarget] which should have been added.
- svg/SVGElementInstance.idl: Ditto.
- 7:09 PM Changeset in webkit [141729] by
-
- 2 edits in trunk/Tools
Fix failing test.
- TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
(TestWebKitAPI::didFinishLoadForFrame):
- 6:55 PM Changeset in webkit [141728] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed rebaselining.
- platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- 6:16 PM Changeset in webkit [141727] by
-
- 2 edits in trunk/Source/WebCore
[Soup] Do not use local variables for the client
https://bugs.webkit.org/show_bug.cgi?id=108714
Reviewed by Martin Robinson.
Covered by existing tests, refactoring code only.
We have had problems in the past with the client being destroyed or
changed inside a method or function, and we ended up with a stale
pointer, leading to crashes. This refactoring is an effort to minimize
the possibility of hitting that same issue in the future.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::redirectSkipCallback): no longer use a local variable to hold
the client.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::closeCallback): ditto.
(WebCore::readCallback): ditto.
- 6:15 PM Changeset in webkit [141726] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.
- platform/chromium/TestExpectations:
- 5:54 PM Changeset in webkit [141725] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking block-test.html as a fail.
- platform/chromium/TestExpectations:
- 5:37 PM Changeset in webkit [141724] by
-
- 2 edits in trunk/LayoutTests
[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
https://bugs.webkit.org/show_bug.cgi?id=85463
Test added in http://trac.webkit.org/changeset/141618 - requires that DRT or WKTR
implement setAutomaticLinkDetectionEnabled().
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 5:03 PM Changeset in webkit [141723] by
-
- 3 edits in trunk/Tools
Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
https://bugs.webkit.org/show_bug.cgi?id=108433
Patch by Timothy Loh <timloh@chromium.com> on 2013-02-03
Reviewed by Eric Seidel.
PrepareChangeLog is supposed to update the file/function list if we
haven't touched it, but the existing regex doesn't handle the
annotations prepare-ChangeLog adds (e.g. "Added.")
- Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry.is_touched_files_text_clean):
- Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_is_touched_files_text_clean):
- 4:47 PM Changeset in webkit [141722] by
-
- 3 edits in trunk/LayoutTests
calendar-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108566
Reviewed by Kentaro Hara.
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
Month.createFromDate supports only UTC Date. Use the Month constructor
with local year and local month.
- 4:43 PM Changeset in webkit [141721] by
-
- 18 edits in trunk/Source/WebCore
[V8] Pass an Isolate to HasInstance() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=108617
Reviewed by Adam Barth.
This is one of efforts to pass an Isolate to GetTemplate().
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(JSValueToNative):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
- bindings/v8/V8GCController.cpp:
(WebCore::WrapperVisitor::WrapperVisitor):
(WrapperVisitor):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):
- bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- 4:01 PM Changeset in webkit [141720] by
-
- 4 edits in trunk/Source
[GTK] Make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=108756
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-02-03
Reviewed by Kentaro Hara.
Source/WebCore:
- GNUmakefile.list.am: Remove header files which no longer exist;
correct one which got added incorrectly.
Source/WebKit2:
- GNUmakefile.list.am: Remove header files which no longer exist
- 3:53 PM Changeset in webkit [141719] by
-
- 5 edits in trunk/Source/WebCore
[V8] Pass an Isolate to HasInstance() (part 3)
https://bugs.webkit.org/show_bug.cgi?id=108622
Reviewed by Adam Barth.
This is one of efforts to pass an Isolate to GetTemplate().
No tests. No change in behavior.
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendCallback):
- 3:26 PM Changeset in webkit [141718] by
-
- 13 edits in trunk/Source/WebCore
[V8] Pass an Isolate to HasInstance() (part 2)
https://bugs.webkit.org/show_bug.cgi?id=108620
Reviewed by Adam Barth.
This is one of efforts to pass an Isolate to GetTemplate().
No tests. No change in behavior.
- bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):
- bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
- bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallbackCustom):
- bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
- bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageCallback):
- bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesCallback):
- bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCallbackCustom):
(WebCore::V8DOMFormData::appendCallback):
- bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallbackCustom):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
- bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):
- 10:35 AM Changeset in webkit [141717] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
https://bugs.webkit.org/show_bug.cgi?id=108769
Reviewed by Eric Seidel.
Does what it says on the tin: reference parameters should read
'type& name', and this patch fixes the two occurances of 'type &name'
that cropped up for ExceptionCode.
Pure style change; no effect on behavior.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- 5:37 AM Changeset in webkit [141716] by
-
- 8 edits in trunk/Source
Vector should consult allocator about ideal size when choosing capacity.
<http://webkit.org/b/108410>
<rdar://problem/13124002>
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
Also export WTF::fastMallocGoodSize() for Windows builds.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Source/WTF:
Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.
Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.
- wtf/Deque.h:
(WTF::::expandCapacity):
- wtf/FastMalloc.cpp:
(WTF::fastMallocGoodSize):
- wtf/FastMalloc.h:
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
- 4:17 AM Changeset in webkit [141715] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark inspector/debugger/source-frame-count.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108768
Unreviewed EFL gardening.
Mark inspector/debugger/source-frame-count.html as flaky as it sometimes
crashes due to Bug 81574.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl-wk2/TestExpectations:
- 2:48 AM Changeset in webkit [141714] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=108765
Unreviewed EFL gardening.
Mark 2 more media tests as flaky since the update to gstreamer 1.0.
They sometimes crash in MediaPlayerPrivateGStreamer dtor.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl/TestExpectations:
- 2:42 AM Changeset in webkit [141713] by
-
- 1 edit2 adds in trunk/LayoutTests
[EFL] svg/custom/text-ctm.svg needs a baseline
https://bugs.webkit.org/show_bug.cgi?id=108764
Unreviewed EFL gardening.
Add baseline for svg/custom/text-ctm.svg that was added in r17879.
Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03
- platform/efl/svg/custom/text-ctm-expected.png: Added.
- platform/efl/svg/custom/text-ctm-expected.txt: Added.
Feb 2, 2013:
- 10:12 PM Changeset in webkit [141712] by
-
- 4 edits in trunk/Source
[chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
in place and in use.
https://bugs.webkit.org/show_bug.cgi?id=108736
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebFileSystem.h:
(WebFileSystem):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):
Source/WebKit/chromium:
- public/WebFileSystemCallbacks.h:
(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):
- 5:14 PM Changeset in webkit [141711] by
-
- 24 edits in trunk/Source/WebKit2
Remove more LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108758
Reviewed by Anders Carlsson.
- UIProcess/Downloads/DownloadProxy.cpp:
- UIProcess/Downloads/DownloadProxy.messages.in:
- UIProcess/WebApplicationCacheManagerProxy.cpp:
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebApplicationCacheManagerProxy.messages.in:
- UIProcess/WebCookieManagerProxy.cpp:
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebCookieManagerProxy.messages.in:
- UIProcess/WebDatabaseManagerProxy.cpp:
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebDatabaseManagerProxy.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.messages.in:
- UIProcess/mac/RemoteLayerTreeHost.mm:
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in:
- WebProcess/Cookies/WebCookieManager.cpp:
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/Cookies/WebCookieManager.messages.in:
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
- 5:11 PM Changeset in webkit [141710] by
-
- 10 edits in trunk/Source/WebKit2
Convert CustomProtocolManagerProxy, CustomProtocolManager and AuthenticationManager to be non-LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108757
Reviewed by Anders Carlsson.
- Shared/Authentication/AuthenticationManager.cpp:
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
- 4:14 PM Changeset in webkit [141709] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_file_chooser_request
https://bugs.webkit.org/show_bug.cgi?id=107811
Reviewed by Sam Weinig.
Use C API inside ewk_file_chooser_request instead of
accessing the internal C++ classes directly, to
avoid violating API layering.
- UIProcess/API/efl/ewk_file_chooser_request.cpp:
(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):
- UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest::create):
(EwkFileChooserRequest):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::runOpenPanel):
- 3:50 PM Changeset in webkit [141708] by
-
- 10 edits in trunk/Source/WebKit2
Stop keeping a frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=81728
Reviewed by Oliver Hunt.
This patch removes the parent/child relationships of WebFrameProxys
in the UIProcess
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
(WKFrameGetParentFrame):
- UIProcess/API/C/WKFrame.h:
Null out the implementations of WKFrameCopyChildFrames and WKFrameGetParentFrame,
but keep them around as their symbols are still needed for nightlies.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
- UIProcess/WebFrameProxy.h:
Remove parent/child connections.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):
Remove/Update messages that only served to update the parent/child connection.
- 3:01 PM Changeset in webkit [141707] by
-
- 2 edits in trunk/Tools
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750
No review necessary.
- Scripts/webkitpy/common/config/committers.py:
- 2:32 PM Changeset in webkit [141706] by
-
- 2 edits in trunk/Source/WebCore
Optimize some operations for float type in texture format conversions of WebGL
https://bugs.webkit.org/show_bug.cgi?id=107526
Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-02
Reviewed by Darin Adler.
Some small changes are made to optimize the operations for float type in the texture format conversion of WebGL to improve performance.
Already covered by current tests.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- 2:26 PM Changeset in webkit [141705] by
-
- 5 edits in trunk/Source/WebKit2
Make it possible to modify the connection from ChildProcessProxy subclasses.
Reviewed by Anders Carlsson.
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionWillClose):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 1:04 PM Changeset in webkit [141704] by
-
- 16 edits in trunk/Source/WebCore
Clean up the storage of dirty bits on nodes in the scrolling state tree
https://bugs.webkit.org/show_bug.cgi?id=108744
Reviewed by Sam Weinig.
ScrollingStateNode and its subclasses used different techniques for
tracking which properties changed. ScrollingStateNode tracked its layers
via a bool member and some layer-specific methods, but also had virtual
methods to allow subclasses to track properties via a bit mask.
Clean this up by having the base class store the bit mask, and use
enums to specify bits for the various properties. All properties are thus
tracked in the same way. Bits are read and written through non-virtual member
functions on ScrollingStateNode. All bit checking is done via hasChangedProperty().
- page/scrolling/ScrollingStateFixedNode.cpp:
(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): m_changedProperties is now on the base class.
(WebCore::ScrollingStateFixedNode::updateConstraints): Use setPropertyChanged()
- page/scrolling/ScrollingStateFixedNode.h: Remove overrides that are no longer needed.
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode): Initialize m_changedProperties,
m_scrollLayerDidChange no longer tracked separately.
(WebCore::ScrollingStateNode::cloneAndReset):
- page/scrolling/ScrollingStateNode.h:
(WebCore::ScrollingStateNode::hasChangedProperties):
(WebCore::ScrollingStateNode::hasChangedProperty): Tests the bit.
(WebCore::ScrollingStateNode::resetChangedProperties): Set all bits to 0.
(WebCore::ScrollingStateNode::setPropertyChanged): Set the bit.
(WebCore::ScrollingStateNode::changedProperties): Private to discourage incorrect usage
(changeProperties() & foo).
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Base class does the copying now.
(WebCore::ScrollingStateScrollingNode::setViewportRect): Use setPropertyChanged().
(WebCore::ScrollingStateScrollingNode::setContentsSize): Ditto.
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Etc.
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):
- page/scrolling/ScrollingStateScrollingNode.h:
(ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateStickyNode.cpp:
(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::updateConstraints):
- page/scrolling/ScrollingStateStickyNode.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::update):
- page/scrolling/mac/ScrollingStateNodeMac.mm:
(WebCore::ScrollingStateNode::setScrollLayer):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::update):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::update):
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::update):
- 1:03 PM Changeset in webkit [141703] by
-
- 12 edits in trunk/Source/WebCore
Fixed and sticky nodes have no nodeID set
https://bugs.webkit.org/show_bug.cgi?id=108734
Reviewed by Sam Weinig.
Push ScrollingNodeIDs onto scrolling nodes at construction time, and thereafter
treat them as readonly. Previously, only the root scrolling node would have a node ID.
Node IDs aren't actually used by the scrolling tree yet, but are useful for debugging.
Not testable since we only dump the scrolling state tree, not the scrolling
node tree in tests.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree): No longer create the root node here;
we can only create it when we know what its ID will be.
(WebCore::ScrollingTree::updateTreeFromStateNode): Create the root node if
necessary. Pass node IDs into create methods.
- page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
- page/scrolling/ScrollingTreeNode.h:
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
- page/scrolling/ScrollingTreeScrollingNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.h:
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNode::create):
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
- page/scrolling/mac/ScrollingTreeStickyNode.h:
- page/scrolling/mac/ScrollingTreeStickyNode.mm:
(WebCore::ScrollingTreeStickyNode::create):
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):
- 12:59 PM Changeset in webkit [141702] by
-
- 5 edits2 deletes in trunk
[CMake] Adopt the WinCE port to new CMake
https://bugs.webkit.org/show_bug.cgi?id=108754
Reviewed by Laszlo Gombos.
.:
Remove the entry point hack which isn't required in the new
CMake version with offical WindowsCE support.
- Source/cmake/OptionsWindows.cmake:
Source/JavaScriptCore:
- os-win32/WinMain.cpp: Removed.
- shell/PlatformWinCE.cmake: Removed.
Tools:
- WinCELauncher/CMakeLists.txt: Mark WinCELauncher
as WIN32 target to use the correct entry point.
- 12:55 PM Changeset in webkit [141701] by
-
- 3 edits2 adds in trunk
Making -webkit-image-set() the first value of background property causes crash.
https://bugs.webkit.org/show_bug.cgi?id=108409
Reviewed by Beth Dakin.
Source/WebCore:
CSSParser::addFillValue should use lval->isBaseValueList() instead
of lval->isValueList(). If lval is -webkit-image-set, rval is appended
to -webkit-image-set.
Test: fast/css/image-set-value-crash-in-fillImageSet.html
- css/CSSParser.cpp:
(WebCore::CSSParser::addFillValue):
If lval is not a value list, lval is initialized by using
CSSValueList::createCommaSeparated(). So we have to check whether
lval is created by CSSValueList::createCommaSeparated() or not.
LayoutTests:
- fast/css/image-set-value-crash-in-fillImageSet-expected.txt: Added.
- fast/css/image-set-value-crash-in-fillImageSet.html: Added.
- 12:25 PM Changeset in webkit [141700] by
-
- 5 edits in trunk/Source
<http://webkit.org/b/108745> WTF shouldn't use a script build phase to detect the presence of headers when the compiler can do it for us
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- DerivedSources.make: Remove an obsolete Makefile rule. This should have been removed when the use
of the generated file moved to WTF.
Source/WTF:
- WTF.xcodeproj/project.pbxproj: Remove the script phase that used to generate a header file
containing information about whether certain header files exist on the system.
- wtf/FastMalloc.cpp: Use Clang's has_include to detect whether the header exists before including it.
- 11:02 AM Changeset in webkit [141699] by
-
- 8 edits in trunk/Source
Upstream iOS FeatureDefines
<http://webkit.org/b/108753>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
- ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
- FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
- 9:31 AM Changeset in webkit [141698] by
-
- 2 edits in trunk/Tools
One is not allowed to use commit-queue to make oneself a committer.
- Scripts/webkitpy/common/config/committers.py: Rolled out r141693. Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.
- 8:41 AM Changeset in webkit [141697] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Media tests fix after r141695.
Rubber-stamped by Martin Robinson.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Remove
both fragment and query string for file:// uris before loading.
- 8:12 AM Changeset in webkit [141696] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r141637.
- platform/graphics/wince/ImageBufferWinCE.cpp:
- 8:00 AM Changeset in webkit [141695] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] webkitwebsrc is exposed to application-side
https://bugs.webkit.org/show_bug.cgi?id=108088
Reviewed by Martin Robinson.
Switch the webkitwebsrc to handle webkit+http(s) uris so it is now
explicit that this element is meant to be used preferrably inside
WebKit. This change is internal to the player.
No new tests, covered by existing http/tests/media tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):
- 7:27 AM Changeset in webkit [141694] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed trivial prospective build fix for A17n disabled
configurations.
The dummy computed object attriute cache control functions need to be defined
as being member functions of AXObjectCache, because that's where they are
declared.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- 6:09 AM Changeset in webkit [141693] by
-
- 2 edits in trunk/Tools
Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750
Reviewed by Dean Jackson.
- Scripts/webkitpy/common/config/committers.py:
- 5:55 AM Changeset in webkit [141692] by
-
- 3 edits in trunk/Source/WebCore
Creating a WebInspector.ContextMenu without an event crashes WebCore when calling .show()
https://bugs.webkit.org/show_bug.cgi?id=108636
Reviewed by Pavel Feldman.
Return early if InspectorFrontendHost::showContextMenu() is called without an event and
assert in ContextMenuController::createContextMenu() in case no event was provided.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
- 5:05 AM Changeset in webkit [141691] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Improper initialization of ANGLEResources
https://bugs.webkit.org/show_bug.cgi?id=101489
Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2013-02-02
Reviewed by Antonio Gomes.
MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 4:54 AM Changeset in webkit [141690] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages
https://bugs.webkit.org/show_bug.cgi?id=108611
Reviewed by Pavel Feldman.
Added reporting of various error messages. Moved the modification of output
parameter at a later stage when there are no errors reported.
No new tests as code refactoring.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::hadException):
(WebCore):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
- 3:58 AM Changeset in webkit [141689] by
-
- 5 edits in trunk
Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
https://bugs.webkit.org/show_bug.cgi?id=108685
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-02
Reviewed by Pavel Feldman.
Source/WebCore:
Use Math.min instead of Math.max in rangesForLine method.
Updated test: text-editor-highlight-api.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):
LayoutTests:
Updated layout test to cover specific bug case.
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-api.html:
- 1:43 AM Changeset in webkit [141688] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations:
- platform/gtk/svg/custom/text-ctm-expected.txt:
- platform/gtk/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- 1:01 AM Changeset in webkit [141687] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r141648.
- DerivedSources.pri:
- 12:25 AM Changeset in webkit [141686] by
-
- 5 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove unsafe AtomicString compares
https://bugs.webkit.org/show_bug.cgi?id=108557
Reviewed by Adam Barth.
Unfortunately HTMLNames comparisons will always be false on a non-main thread
with our current design, so we have to use some "threadSafeMatch" helpers written
for the HTMLBackgroundParser.
Also factor out threadSafeMatch() methods to HTMLParserIdioms.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
(WebCore):
(WebCore::threadSafeMatch):
- html/parser/HTMLParserIdioms.h:
(WebCore):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::eraseAttributeIfInjected):
- 12:04 AM Changeset in webkit [141685] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up to r141682. Adding build targets for the files that should be generated from the new message.in file.
Unreviewed.
- GNUmakefile.list.am:
Feb 1, 2013:
- 11:40 PM Changeset in webkit [141684] by
-
- 10 edits in trunk/Source
Add didChangePriority() to ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=107995
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebURLLoader.h:
(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::didChangePriority): Added.
Source/WebCore:
For PLT, it's important that preloads remain a lower priority than parser requested resources.
This can lead to a 5% improvement.
The plan is to use this plumbing to expose the desired behavior. This patch simply allows a
resource's priority to change and have it propagate to the network layer. An upcoming patch will
lower the priority of preloads and then increase the priority when the parser officially requests
it.
No new tests. No visible change, because priority doesn't change yet.
- loader/cache/CachedResource.cpp:
(WebCore):
(WebCore::CachedResource::setLoadPriority):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource): Allow loads to modify priority.
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::setPriority): Notify when priority changes.
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::didChangePriority): Added.
(WebCore):
- platform/network/ResourceHandle.h:
(ResourceHandle):
- platform/network/chromium/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didChangePriority):
(WebCore):
(WebCore::ResourceHandle::didChangePriority):
- platform/network/chromium/ResourceHandleInternal.h:
(ResourceHandleInternal):
- 10:26 PM Changeset in webkit [141683] by
-
- 2 edits in trunk/Tools
[GTK] Building fails in an armv5tel board
https://bugs.webkit.org/show_bug.cgi?id=108083
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-02-01
Reviewed by Martin Robinson.
In some systems in which $architecture is filled-in from "uname -m"
the value may not start with "arm-", but with "armvN", where "N" is
an architecture version number. The regexp in isARM() is modified
so it covers these kind of cases.
- Scripts/webkitdirs.pm:
(isARM):
- 10:18 PM Changeset in webkit [141682] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r141648.
- GNUmakefile.am: Add UIProcess/Storage to the list of paths that
should be searched for *.messages.in files.
- 7:57 PM Changeset in webkit [141681] by
-
- 6 edits in trunk/Source/JavaScriptCore
Structure::m_enumerationCache should be moved to StructureRareData
https://bugs.webkit.org/show_bug.cgi?id=108723
Reviewed by Oliver Hunt.
m_enumerationCache is only used by objects whose properties are iterated over, so not every Structure needs this
field and it can therefore be moved safely to StructureRareData to help with memory savings.
- runtime/JSPropertyNameIterator.h:
(JSPropertyNameIterator):
(JSC::Register::propertyNameIterator):
(JSC::StructureRareData::enumerationCache): Add to JSPropertyNameIterator.h so that it can see the correct type.
(JSC::StructureRareData::setEnumerationCache): Ditto.
- runtime/Structure.cpp:
(JSC::Structure::addPropertyWithoutTransition): Use the enumerationCache() getter rather than accessing the field.
(JSC::Structure::removePropertyWithoutTransition): Ditto.
(JSC::Structure::visitChildren): We no longer have to worry about marking the m_enumerationCache field.
- runtime/Structure.h:
(JSC::Structure::setEnumerationCache): Move the old accessors back since we don't have to have any knowledge of
the JSPropertyNameIterator type.
(JSC::Structure::enumerationCache): Ditto.
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::visitChildren): Mark the new m_enumerationCache field.
- runtime/StructureRareData.h: Add new functions/fields.
(StructureRareData):
- 7:40 PM Changeset in webkit [141680] by
-
- 6 edits1 move5 adds1 delete in trunk/LayoutTests
Rebaseline tests after bug 9221
https://bugs.webkit.org/show_bug.cgi?id=108712
Unreviewed rebaseline of test expectations.
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-01
- fast/css/resize-corner-tracking-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.txt.
- platform/chromium-mac-lion/fast/css/resize-corner-tracking-expected.png:
- platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-expected.png:
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/chromium-mac/fast/css/resize-corner-tracking-expected.png:
- platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.png:
- platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/chromium-win/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/fast/css/resize-corner-tracking-expected.txt: Removed.
- 6:54 PM Changeset in webkit [141679] by
-
- 6 edits1 delete in trunk/Source/WebCore
Unreviewed. Clean up WebCore VS2010 project.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.vcxproj/WebCoreGenerated.make:
- WebCore.vcxproj/WebCorePreLink.cmd: Removed.
- WebCore.vcxproj/build-generated-files.sh:
- 6:53 PM Changeset in webkit [141678] by
-
- 2 edits in trunk/Source/WebCore
Don't use deprecated method -[NSImage dissolveToPoint:fraction:]
<rdar://problem/11723792>
https://bugs.webkit.org/show_bug.cgi?id=108739
Reviewed by Anders Carlsson.
- platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction):
Remove use of deprecated NSImage methods and simplify a bit.
- 6:51 PM Changeset in webkit [141677] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed. JavaScriptCore VS2010 project cleanup.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- 6:48 PM Changeset in webkit [141676] by
-
- 3 edits1 delete in trunk/Source/WTF
Unreviewed. WTF VS2010 project cleanup.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.vcxproj/WTFPreLink.cmd: Removed.
- 6:36 PM Changeset in webkit [141675] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180221. Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- DEPS:
- 6:35 PM Changeset in webkit [141674] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r141662.
http://trac.webkit.org/changeset/141662
https://bugs.webkit.org/show_bug.cgi?id=108738
it's an incorrect change since processPhiStack will
dereference dangling BasicBlock pointers (Requested by pizlo
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 6:17 PM Changeset in webkit [141673] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix "DOM Exception 8" when deleting lines containing decoration in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108689
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.
Add a check that decoration element is still added to the line before trying to delete it. This
won't be true if the whole line is deleted in contentEditable,
and this is the reason for the exception to be thrown.
No new tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):
- 6:16 PM Changeset in webkit [141672] by
-
- 3 edits in trunk/Tools
Update LayoutTests scripts to skip webgl folder on ports
https://bugs.webkit.org/show_bug.cgi?id=108705
Patch by Gregg Tavares <gman@google.com> on 2013-02-01
Reviewed by Dirk Pranke.
I'm working on checking in the WebGL Conformance Tests
as layout tests into LayoutTests/webgl. For ports
that do not have WebGL enabled this changes will
skip tests in the "webgl" folder.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port._missing_symbol_to_skipped_tests):
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_skipped_directories_for_symbols):
- 5:35 PM Changeset in webkit [141671] by
-
- 3 edits in trunk/Tools
Unreviewed. Fix for webkitpy tests.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 5:27 PM Changeset in webkit [141670] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r141669.
http://trac.webkit.org/changeset/141669
https://bugs.webkit.org/show_bug.cgi?id=108728
Broke the windows build. (Requested by leviw on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
- rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
- 5:10 PM Changeset in webkit [141669] by
-
- 3 edits in trunk/Source/WebCore
Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707
Reviewed by Levi Weintraub.
The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.
Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.
No new tests, no change in functionality.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPadding):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):
- 5:05 PM Changeset in webkit [141668] by
-
- 14 edits in trunk/Source/WebCore
Replace ExceptionCode with DatabaseError in the openDatabase() code path.
https://bugs.webkit.org/show_bug.cgi?id=108724.
Reviewed by Alexey Proskuryakov.
Also made DatabaseBackend::performOpenAndVerify() a little more
straightforward and less repetitive.
No new tests.
- Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):
- Modules/webdatabase/Database.h:
(Database):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::openSucceeded):
(WebCore::DatabaseBackend::performOpenAndVerify):
- Modules/webdatabase/DatabaseBackend.h:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::openAndVerifyVersion):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):
- Modules/webdatabase/DatabaseTask.h:
(WebCore::Database::DatabaseOpenTask::create):
(Database::DatabaseOpenTask):
- Modules/webdatabase/WorkerContextWebDatabase.cpp:
(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):
- WebCore.gypi:
- 4:58 PM Changeset in webkit [141667] by
-
- 3 edits2 adds in trunk
Document is never released if an image's src attribute is changed to a url blocked by content-security-policy.
https://bugs.webkit.org/show_bug.cgi?id=108545
Source/WebCore:
If we just scheduled an error event due to an null newImage, we should not cancel it when newImage and oldImage
is not the same. Otherwise we will ref the sourceElement in updateHasPendingEvent (m_hasPendingErrorEvent is true)
but never deref it since we already cancelled the error event.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.
Test: fast/images/image-error-event-not-firing.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): don't cancel error event if newImage is null, we want the
error event to fire.
LayoutTests:
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.
Add a test to verify the error event is fired when image's src attribute is changed to a url
but the url blocked by content-security-policy.
- fast/images/image-error-event-not-firing-expected.txt: Added.
- fast/images/image-error-event-not-firing.html: Added.
- 4:51 PM Changeset in webkit [141666] by
-
- 2 edits in trunk/Tools
LLDB: add synthetic provider for WTF::HashTable
https://bugs.webkit.org/show_bug.cgi?id=108718
Reviewed by Darin Adler.
Add a synthetic provider which will emit the contents of a given
WTF::HashTable. This allows clients using Xcode/lldb to enumerate
the hash contents.
- lldb/lldb_webkit.py:
(lldb_init_module):
(lldb_init_module.lldb_webkit):
(WTFHashTable_SummaryProvider):
(WTFVectorProvider.has_children):
(WTFHashTableProvider):
(WTFHashTableProvider.init):
(WTFHashTableProvider.num_children):
(WTFHashTableProvider.get_child_index):
(WTFHashTableProvider.get_child_at_index):
(WTFHashTableProvider.tableSize):
(WTFHashTableProvider.keyCount):
(WTFHashTableProvider.update):
(WTFHashTableProvider.has_children):
- 4:51 PM Changeset in webkit [141665] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r141648
Needs to add StorageManager.messages.in to CMakeLists.txt.
- CMakeLists.txt:
- 4:50 PM Changeset in webkit [141664] by
-
- 2 edits3 copies3 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline after http://trac.webkit.org/changeset/141634
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
- 4:33 PM Changeset in webkit [141663] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for CustomProtocolManagerMac after r141658.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::supplementName): I accidentally typed "const" twice twice.
- 4:26 PM Changeset in webkit [141662] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
https://bugs.webkit.org/show_bug.cgi?id=108717
Reviewed by Mark Hahnenberg.
I think this makes the code clearer. It doesn't change behavior.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
- 4:25 PM Changeset in webkit [141661] by
-
- 2 edits in trunk/LayoutTests
The assertions in updateLayerPositionsAfterScroll were commented out in r141278, so stop
expecting http/tests/inspector/resource-har-pages.html to assert in debug builds.
(see https://bugs.webkit.org/show_bug.cgi?id=103432).
- platform/mac/TestExpectations:
- 4:19 PM Changeset in webkit [141660] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180186. Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- DEPS:
- 4:14 PM Changeset in webkit [141659] by
-
- 5 edits3 deletes in trunk/LayoutTests
Make svg-fonts-in-text-controls.html have the same results across platforms
https://bugs.webkit.org/show_bug.cgi?id=108676
Reviewed by Dirk Pranke.
Mac uses a different default font-size for form controls and Windows
uses different padding for textareas/inputs. Override these so
this test doesn't need platform specific expectations.
- platform/chromium/TestExpectations:
- platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
- platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
- platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
- svg/custom/script-tests/svg-fonts-in-text-controls.js:
- svg/custom/svg-fonts-in-text-controls-expected.txt:
- svg/custom/svg-fonts-in-text-controls.html:
These dummy elements aren't needed anymore. js-test-pre.js inserts them.
- 4:10 PM Changeset in webkit [141658] by
-
- 42 edits in trunk/Source/WebKit2
[WK2] Use light supplement names instead of static AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=108570
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Anders Carlsson.
Since all the supplement names are just string literals and are all different,
we can just use their pointer as the key in the supplement hashmaps.
This is lighter and faster than using AtomicString. WebCore already moved to this
in Supplementable.
- NetworkProcess/NetworkProcess.h:
(WebKit::NetworkProcess::addSupplement):
(NetworkProcess):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::supplementName):
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::supplementName):
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::supplementName):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::supplementName):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::supplementName):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::supplementName):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::supplementName):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::supplementName):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::supplementName):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::supplementName):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::supplementName):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::supplementName):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::supplementName):
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::supplementName):
- WebProcess/Geolocation/WebGeolocationManager.h:
(WebGeolocationManager):
- WebProcess/MediaCache/WebMediaCacheManager.cpp:
(WebKit::WebMediaCacheManager::supplementName):
- WebProcess/MediaCache/WebMediaCacheManager.h:
(WebMediaCacheManager):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::supplementName):
- WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::supplementName):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
- WebProcess/Storage/WebKeyValueStorageManager.cpp:
(WebKit::WebKeyValueStorageManager::supplementName):
- WebProcess/Storage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::supplementName):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::addSupplement):
(WebProcess):
- 3:59 PM Changeset in webkit [141657] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] WebWidget::selectionBounds should return the bounds in document space
https://bugs.webkit.org/show_bug.cgi?id=108386
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-01
Reviewed by James Robinson.
When in applyPageScaleFactorInCompositor mode, selectionBounds needs
to scale the anchor/focus window points by the pageScaleFactor.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
- 3:55 PM Changeset in webkit [141656] by
-
- 14 edits in trunk
Clean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
https://bugs.webkit.org/show_bug.cgi?id=108558
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Dean Jackson.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
This is a step torward killing the implicit conversion from String to AtomicString.
The animation name are AtomicString. The API is changed all the way to the callers
to take an AtomicString. When needed, we use explicit conversion.
- WebCore.exp.in:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationController::pauseAnimationAtTime):
- page/animation/AnimationController.h:
(AnimationController):
- page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseAnimationAtTime):
We should not null check the name. Getting a null name from the HashMap would be
an error from the tests, and the HashMap would never return a value anyway.
- testing/Internals.cpp:
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFramePauseAnimationOnElementWithId):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::pauseAnimationOnElementWithId):
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
- 3:50 PM Changeset in webkit [141655] by
-
- 9 edits in trunk/Source
AX: memoize expensive computation during blocks where tree doesn't change
https://bugs.webkit.org/show_bug.cgi?id=106497
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add a cache for computed attributes of AXObjects.
The cache can be enabled at the start of a batch of
read-only operations on the accessibility tree, and
it's cleared automatically when the tree mutates.
Currently accessibilityIsIgnored is cached, since it's
frequently called and relatively expensive to compute.
No new tests.
- accessibility/AXObjectCache.cpp:
(WebCore):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleScrollbarUpdate):
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- accessibility/AXObjectCache.h:
(AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::create):
(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
(CachedAXObjectAttributes):
(WebCore):
(WebCore::AXObjectCache::computedObjectAttributeCache):
(AXObjectCache):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::stopCachingComputedObjectAttributes):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::findMatchingObjects):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
Source/WebKit/chromium:
Expose two methods to enable and disable caching of
computed WebAccessibilityObject attributes, to speed up
batch read-only operations.
- public/WebAccessibilityObject.h:
(WebAccessibilityObject):
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
(WebKit):
(WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):
- 3:46 PM Changeset in webkit [141654] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- Modules/webdatabase/DatabaseBackend.cpp: (DoneCreatingDatabaseOnExitCaller): Don't fail because of an unused member variable in cross-plaform code path.
- 3:30 PM Changeset in webkit [141653] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Expose WebNode::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=108681
Reviewed by Dimitri Glazkov.
BrowserPlugin needs to be able to check the event listeners attached to
<webview> and so we expose shadowHost to permit it to poke at the webview
node.
- public/WebNode.h:
- src/WebNode.cpp:
(WebKit::WebNode::shadowHost):
(WebKit):
- 3:23 PM Changeset in webkit [141652] by
-
- 5 edits in trunk/Source
[chromium] Fat scrollbars on Windows in high-DPI mode.
https://bugs.webkit.org/show_bug.cgi?id=108637
Updates mechanism for retrieving scrollbar metrics on the
Windows port of Chromium. Previously, GetSystemMetrics calls
were used, which fetches prescaled sizes in pixel rather than
logical units, resulting in a double scaling when a device
scale factor is set. With the patch, the size is retrieved
from the theme engine in DIP.
Patch by Kevin Ellis <kevers@chromium.org> on 2013-02-01
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/win/WebThemeEngine.h:
(WebThemeEngine):
Source/WebCore:
No new tests.
- platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
- rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::menuListButtonWidth):
- 3:10 PM Changeset in webkit [141651] by
-
- 18 edits3 adds in trunk/Source/JavaScriptCore
Structure should have a StructureRareData field to save space
https://bugs.webkit.org/show_bug.cgi?id=108659
Reviewed by Oliver Hunt.
Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must
pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially
many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to
refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields.
To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we
can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and
can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union
with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has
a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData
if it has one. There could be some potential for optimizing this process, but the initial implementation will
be dumb since we'd be paying these overhead costs for each Structure anyways.
Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll
continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our
Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from
Structures (and into StructureRareData).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGRepatch.cpp: Includes for linking purposes.
- jit/JITStubs.cpp:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
- runtime/JSCellInlines.h: Added ifdef guards.
- runtime/JSGlobalData.cpp: New Structure for StructureRareData class.
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSGlobalObject.h:
- runtime/JSTypeInfo.h: New flag to indicate whether or not a Structure has a StructureRareData field.
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):
- runtime/ObjectPrototype.cpp:
- runtime/Structure.cpp: We use a combined WriteBarrier<JSCell> field m_previousOrRareData to avoid compiler issues.
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData): Handles allocating a brand new StructureRareData field.
(JSC::Structure::cloneRareDataFrom): Handles cloning a StructureRareData field from another. Used during Structure
transitions.
(JSC::Structure::visitChildren): We no longer have to worry about marking m_objectToStringValue.
- runtime/Structure.h:
(JSC::Structure::previousID): Checks the structureHasRareData flag to see where it should get the previous Structure.
(JSC::Structure::objectToStringValue): Reads the value from the StructureRareData. If it doesn't exist, returns 0.
(JSC::Structure::setObjectToStringValue): Ensures that we have a StructureRareData field, then forwards the function
call to it.
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID): Checks for StructureRareData and forwards if necessary.
(Structure):
(JSC::Structure::clearPreviousID): Ditto.
(JSC::Structure::create):
- runtime/StructureRareData.cpp: Added. All of the basic functionality of a JSCell with the fields that we've moved
from Structure and the functions required to access/modify those fields as Structure would have done.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h: Added.
(JSC):
(StructureRareData):
- runtime/StructureRareDataInlines.h: Added.
(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::Structure::previous): Handles the ugly casting to get the value of the right type of m_previousOrRareData.
(JSC::Structure::rareData): Ditto.
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGRepatch.cpp:
- jit/JITStubs.cpp:
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
- runtime/JSCellInlines.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSGlobalObject.h:
- runtime/JSTypeInfo.h:
(JSC):
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):
- runtime/ObjectPrototype.cpp:
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData):
(JSC):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::visitChildren):
- runtime/Structure.h:
(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID):
(Structure):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
(JSC::Structure::create):
- runtime/StructureRareData.cpp: Added.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h: Added.
(JSC):
(StructureRareData):
- runtime/StructureRareDataInlines.h: Added.
(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):
- 3:03 PM Changeset in webkit [141650] by
-
- 4 edits in trunk
Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108511
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.
- src/ContextMenuClientImpl.cpp:
(WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
(WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
https://bugs.webkit.org/show_bug.cgi?id=108511
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.
- platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.
- 3:03 PM Changeset in webkit [141649] by
-
- 13 edits in trunk/Source/WebCore
Clean up calls to DatabaseTracker::add/removeOpenDatabase().
https://bugs.webkit.org/show_bug.cgi?id=108431
Reviewed by Geoffrey Garen.
Also adapted the chromium port to work with this new code.
Chromium parts reviewed by Michael Nordman and David Levin.
This is part of the webdatabase refactoring effort.
No new tests.
- Modules/webdatabase/AbstractDatabaseServer.h:
(AbstractDatabaseServer):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
- Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackend::performOpenAndVerify):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp:
- Modules/webdatabase/DatabaseServer.h:
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::openAndVerifyVersion):
(WebCore::DatabaseSync::closeImmediately):
- Modules/webdatabase/DatabaseSync.h:
(DatabaseSync):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
- Modules/webdatabase/DatabaseTracker.h:
(DatabaseTracker):
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
- 2:56 PM Changeset in webkit [141648] by
-
- 7 edits1 add in trunk/Source/WebKit2
More work on UI side storage
https://bugs.webkit.org/show_bug.cgi?id=108700
Reviewed by Sam Weinig.
- DerivedSources.make:
Add StorageManager.messages.in.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
Call the right function.
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
Add stubs.
- UIProcess/Storage/StorageManager.messages.in: Added.
Add new messages files.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::~StorageAreaProxy):
Add another FIXME.
(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::incrementAccessCount):
(WebKit::StorageAreaProxy::decrementAccessCount):
Implement these.
- 2:55 PM Changeset in webkit [141647] by
-
- 5 edits in trunk
Web Inspector: remove extra padding around overlay highlight.
https://bugs.webkit.org/show_bug.cgi?id=108679
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.
Source/WebCore:
No new tests: no change in behaviour.
Remove extraWidth from overlay highlight spans.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
LayoutTests:
Update layout test expectations to correspond to updated overlay highlight style.
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-token-expected.txt:
- 2:46 PM Changeset in webkit [141646] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
Allow prettify.rb to be run from any directory, and don't hard-code the system ruby path
https://bugs.webkit.org/show_bug.cgi?id=108569
Patch by Nathan de Vries <ndevries@apple.com> on 2013-02-01
Reviewed by Joseph Pecoraro.
- PrettyPatch/prettify.rb:
- 2:38 PM Changeset in webkit [141645] by
-
- 8 edits3 adds in trunk
Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429
Reviewed by Eric Seidel.
Source/WebCore:
This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.
I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.
Test: svg/repaint/svgsvgelement-repaint-children.html
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport):
This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().
LayoutTests:
Need to update expectations for a single file (just a 1px difference).
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
- svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
- svg/repaint/svgsvgelement-repaint-children.html: Added.
- 2:24 PM Changeset in webkit [141644] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening of two svg/zoom/page tests.
This change rebaselines two tests for WK108108.
Unreviewed update of test expectations.
- platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium/TestExpectations:
- 2:10 PM Changeset in webkit [141643] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 2:00 PM Changeset in webkit [141642] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled.
- platform/chromium/TestExpectations:
- 2:00 PM Changeset in webkit [141641] by
-
- 3 edits in trunk/Source/JavaScriptCore
offlineasm BaseIndex handling is broken on ARM due to MIPS changes
https://bugs.webkit.org/show_bug.cgi?id=108261
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-01
Reviewed by Filip Pizlo.
offlineasm BaseIndex handling fix on MIPS.
- offlineasm/mips.rb:
- offlineasm/risc.rb:
- 1:56 PM Changeset in webkit [141640] by
-
- 5 edits in trunk/Source/WebKit2
[Gtk] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108687
Reviewed by Benjamin Poulain.
Take a reference instead of a pointer for decoding functions.
- Platform/gtk/SharedMemoryGtk.cpp:
(WebKit::SharedMemory::Handle::decode):
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
(CoreIPC::decodeDataObject):
(CoreIPC::::decode):
(CoreIPC::decodeGKeyFile):
(CoreIPC::decode):
- Shared/gtk/ArgumentCodersGtk.h:
- Shared/gtk/LayerTreeContextGtk.cpp:
(WebKit::LayerTreeContext::decode):
- 1:40 PM Changeset in webkit [141639] by
-
- 10 edits in trunk/Source/WebKit2
[EFL] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108683
Reviewed by Benjamin Poulain.
Take a reference instead of a pointer for decoding functions.
- Shared/WebBatteryStatus.cpp:
(WebKit::WebBatteryStatus::Data::decode):
- Shared/WebBatteryStatus.h:
(Data):
- Shared/WebNetworkInfo.cpp:
(WebKit::WebNetworkInfo::Data::decode):
- Shared/WebNetworkInfo.h:
(Data):
- Shared/cairo/LayerTreeContextCairo.cpp:
(WebKit::LayerTreeContext::decode):
- Shared/efl/LayerTreeContextEfl.cpp:
(WebKit::LayerTreeContext::decode):
- Shared/soup/PlatformCertificateInfo.cpp:
(WebKit::PlatformCertificateInfo::decode):
- Shared/soup/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::decodePlatformData):
- 1:34 PM Changeset in webkit [141638] by
-
- 2 edits in trunk/LayoutTests
[Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots
https://bugs.webkit.org/show_bug.cgi?id=108677
Patch by David Farler <dfarler@apple.com> on 2013-02-01
Reviewed by Tim Horton.
- platform/mac/TestExpectations:
Mark fast/parser/parser-yield-timing.html as [ Pass Failure ]
- 1:31 PM Changeset in webkit [141637] by
-
- 45 edits1 add in trunk
Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
https://bugs.webkit.org/show_bug.cgi?id=106966
Reviewed by Stephen White.
Source/WebCore:
Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
was treated as returning whether the frame had alpha when it would actually conservatively
return true.
This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
correctly implements it for SVG images.
All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
currently returns a cached bitmap image. Therefore, this patch will not affect existing
functionality. A regression test has been added that will catch if this changes in the
future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
isBitmapImage() calls have been removed in this patch.
image-box-shadow.html has been modified to test SVG images.
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.
- css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::knownToBeOpaque):
- css/CSSGradientValue.h:
(CSSGradientValue):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSImageGeneratorValue.h:
(CSSImageGeneratorValue):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::knownToBeOpaque):
- css/CSSImageValue.h:
(CSSImageValue):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameKnownToBeOpaque):
- loader/cache/CachedImage.h:
(CachedImage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::currentFrameKnownToBeOpaque):
- platform/graphics/BitmapImage.h:
(BitmapImage):
- platform/graphics/GeneratedImage.h:
(GeneratedImage):
- platform/graphics/Image.h:
Note: now a pure virtual function!
(Image):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
Removed unnecessary isBitmapImage() checks.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
Removed unnecessary isBitmapImage() checks.
- platform/graphics/cg/PDFDocumentImage.h:
(PDFDocumentImage):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
Removed unnecessary isBitmapImage() checks.
(WebCore::GraphicsLayerChromium::setContentsToImage):
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::currentFrameKnownToBeOpaque):
- platform/graphics/qt/StillImageQt.h:
(StillImage):
- platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):
- platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContents):
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::backgroundIsObscured):
Removed unnecessary isBitmapImage() checks and slightly reworked the logic.
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::knownToBeOpaque):
- rendering/style/StyleCachedImage.h:
(StyleCachedImage):
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::knownToBeOpaque):
- rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::knownToBeOpaque):
- rendering/style/StyleGeneratedImage.h:
(StyleGeneratedImage):
- rendering/style/StyleImage.h:
(StyleImage):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::knownToBeOpaque):
- svg/graphics/SVGImage.h:
(SVGImage):
Source/WebKit/chromium:
- tests/DragImageTest.cpp:
(WebCore::TestImage::currentFrameKnownToBeOpaque):
(TestImage):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::currentFrameKnownToBeOpaque):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
An SVG image has been added to this test to check for regressions.
- fast/box-shadow/image-box-shadow-expected.html:
- fast/box-shadow/image-box-shadow.html:
Add an SVG image and correct a small mistake in the test that used values of 256
instead of 255.
- fast/box-shadow/resources/green.svg: Added.
- 1:26 PM Changeset in webkit [141636] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, GTK TestExpectations update.
- platform/gtk/TestExpectations: Flag some new media tests
crashing until a fix is figured out.
- 1:18 PM Changeset in webkit [141635] by
-
- 8 edits in trunk/Source
Clean up WebArchive loading with the NetworkProcess
<rdar://problem/12695840> and https://bugs.webkit.org/show_bug.cgi?id=108673
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests (No change in WebCore behavior).
Remove a now unneeded function and add a needed export.
- WebCore.exp.in:
- loader/ResourceLoadScheduler.cpp:
- loader/ResourceLoadScheduler.h:
Source/WebKit2:
- NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::servePendingRequestsForQueue): Add new logging.
(WebKit::HostRecord::servePendingRequests): Tweak existing logging.
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::servePendingRequests): Tweak existing logging.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Handle archive resource scheduling better,
and add new logging to better explore archive loading behavior in the future.
- 1:16 PM Changeset in webkit [141634] by
-
- 405 edits in trunk
Print GraphicsLayer::m_contentsOpaque if non-default (true)
https://bugs.webkit.org/show_bug.cgi?id=108354
Reviewed by Simon Fraser.
Source/WebCore:
No new tests. This change facilitates testing of GraphicsLayer opaqueness.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
LayoutTests:
- compositing/absolute-inside-out-of-view-fixed-expected.txt:
- compositing/backing/no-backing-for-clip-expected.txt:
- compositing/backing/no-backing-for-clip-overlap-expected.txt:
- compositing/backing/no-backing-for-perspective-expected.txt:
- compositing/bounds-in-flipped-writing-mode-expected.txt:
- compositing/clip-child-by-non-stacking-ancestor-expected.txt:
- compositing/columns/composited-in-paginated-expected.txt:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- compositing/geometry/ancestor-overflow-change-expected.txt:
- compositing/geometry/bounds-clipped-composited-child-expected.txt:
- compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
- compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- compositing/geometry/bounds-ignores-hidden-expected.txt:
- compositing/geometry/clip-expected.txt:
- compositing/geometry/clip-inside-expected.txt:
- compositing/geometry/composited-in-columns-expected.txt:
- compositing/geometry/fixed-position-composited-switch-expected.txt:
- compositing/geometry/flipped-writing-mode-expected.txt:
- compositing/geometry/foreground-layer-expected.txt:
- compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- compositing/geometry/preserve-3d-switching-expected.txt:
- compositing/iframes/become-composited-nested-iframes-expected.txt:
- compositing/iframes/become-overlapped-iframe-expected.txt:
- compositing/iframes/composited-parent-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- compositing/iframes/connect-compositing-iframe-expected.txt:
- compositing/iframes/connect-compositing-iframe2-expected.txt:
- compositing/iframes/connect-compositing-iframe3-expected.txt:
- compositing/iframes/enter-compositing-iframe-expected.txt:
- compositing/iframes/iframe-resize-expected.txt:
- compositing/iframes/iframe-size-from-zero-expected.txt:
- compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- compositing/iframes/invisible-nested-iframe-show-expected.txt:
- compositing/iframes/overlapped-iframe-expected.txt:
- compositing/iframes/overlapped-iframe-iframe-expected.txt:
- compositing/iframes/overlapped-nested-iframes-expected.txt:
- compositing/iframes/page-cache-layer-tree-expected.txt:
- compositing/iframes/scrolling-iframe-expected.txt:
- compositing/images/clip-on-directly-composited-image-expected.txt:
- compositing/layer-creation/animation-overlap-with-children-expected.txt:
- compositing/layer-creation/fixed-position-and-transform-expected.txt:
- compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- compositing/layer-creation/fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
- compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- compositing/layer-creation/overlap-animation-clipping-expected.txt:
- compositing/layer-creation/overlap-animation-container-expected.txt:
- compositing/layer-creation/overlap-animation-expected.txt:
- compositing/layer-creation/overlap-child-layer-expected.txt:
- compositing/layer-creation/overlap-clipping-expected.txt:
- compositing/layer-creation/overlap-transformed-3d-expected.txt:
- compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- compositing/layer-creation/overlap-transformed-layer-expected.txt:
- compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- compositing/layer-creation/overlap-transforms-expected.txt:
- compositing/layer-creation/rotate3d-overlap-expected.txt:
- compositing/layer-creation/scroll-partial-update-expected.txt:
- compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- compositing/layer-creation/stacking-context-overlap-expected.txt:
- compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
- compositing/layer-creation/translatez-overlap-expected.txt:
- compositing/masks/mask-layer-size-expected.txt:
- compositing/overflow-trumps-transform-style-expected.txt:
- compositing/overflow/clip-descendents-expected.txt:
- compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- compositing/overflow/content-gains-scrollbars-expected.txt:
- compositing/overflow/content-loses-scrollbars-expected.txt:
- compositing/overflow/overflow-auto-with-touch-expected.txt:
- compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
- compositing/overflow/overflow-overlay-with-touch-expected.txt:
- compositing/overflow/overflow-scrollbar-layers-expected.txt:
- compositing/overflow/resize-painting-expected.txt:
- compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
- compositing/overflow/scrolling-without-painting-expected.txt:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- compositing/overflow/updating-scrolling-content-expected.txt:
- compositing/plugins/no-backing-store-expected.txt:
- compositing/plugins/small-to-large-composited-plugin-expected.txt:
- compositing/repaint/invalidations-on-composited-layers-expected.txt:
- compositing/repaint/resize-repaint-expected.txt:
- compositing/rtl/rtl-absolute-expected.txt:
- compositing/rtl/rtl-absolute-overflow-expected.txt:
- compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-fixed-expected.txt:
- compositing/rtl/rtl-fixed-overflow-expected.txt:
- compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-absolute-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-fixed-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- compositing/rtl/rtl-iframe-relative-expected.txt:
- compositing/rtl/rtl-relative-expected.txt:
- compositing/tiled-layers-hidpi-expected.txt:
- compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- compositing/tiling/huge-layer-add-remove-child-expected.txt:
- compositing/tiling/huge-layer-expected.txt:
- compositing/tiling/huge-layer-img-expected.txt:
- compositing/tiling/huge-layer-resize-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-expected.txt:
- compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- compositing/tiling/rotated-tiled-clamped-expected.txt:
- compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- compositing/tiling/tile-cache-zoomed-expected.txt:
- compositing/tiling/tiled-layer-resize-expected.txt:
- compositing/visibility/layer-visible-content-expected.txt:
- compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- compositing/visible-rect/2d-transformed-expected.txt:
- compositing/visible-rect/3d-transform-style-expected.txt:
- compositing/visible-rect/3d-transformed-expected.txt:
- compositing/visible-rect/animated-expected.txt:
- compositing/visible-rect/animated-from-none-expected.txt:
- compositing/visible-rect/clipped-by-viewport-expected.txt:
- compositing/visible-rect/clipped-visible-rect-expected.txt:
- compositing/visible-rect/iframe-and-layers-expected.txt:
- compositing/visible-rect/iframe-no-layers-expected.txt:
- compositing/visible-rect/nested-transform-expected.txt:
- compositing/visible-rect/scrolled-expected.txt:
- css3/compositing/should-have-compositing-layer-expected.txt:
- css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
- platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
- platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-resize-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/chromium/compositing/canvas/accelerated-canvas-compositing-expected.txt:
- platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
- platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt:
- platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt:
- platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt:
- platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
- platform/chromium/compositing/geometry/clip-expected.txt:
- platform/chromium/compositing/geometry/clip-inside-expected.txt:
- platform/chromium/compositing/geometry/composited-in-columns-expected.txt:
- platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
- platform/chromium/compositing/geometry/foreground-layer-expected.txt:
- platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/chromium/compositing/iframes/resizer-expected.txt:
- platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
- platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
- platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
- platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
- platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
- platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
- platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
- platform/chromium/compositing/overflow/clip-descendents-expected.txt:
- platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt:
- platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/compositing/overflow/resize-painting-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium/compositing/rtl/rtl-relative-expected.txt:
- platform/chromium/compositing/tiling/huge-layer-img-expected.txt:
- platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt:
- platform/efl/compositing/geometry/foreground-layer-expected.txt:
- platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt:
- platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
- platform/mac/compositing/iframes/resizer-expected.txt:
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
- platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
- platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/mac/compositing/tiling/huge-layer-expected.txt:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt:
- platform/mac/compositing/tiling/huge-layer-resize-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
- platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
- platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
- platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
- platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
- platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
- platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
- platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
- platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
- platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
- platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
- platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
- platform/qt/compositing/overflow/clip-descendents-expected.txt:
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/qt/css3/compositing/should-have-compositing-layer-expected.txt:
- platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
- platform/win/compositing/iframes/composited-iframe-expected.txt:
- platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
- platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- 1:13 PM Changeset in webkit [141633] by
-
- 3 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL
https://bugs.webkit.org/show_bug.cgi?id=108655
Reviewed by Adam Barth.
No new tests because no new functionality.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::isLikelySafeResource):
- html/parser/XSSAuditor.h:
- 1:08 PM Changeset in webkit [141632] by
-
- 15 edits in trunk/Source/WebKit2
[Qt] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108680
Reviewed by Benjamin Poulain.
Take a reference instead of a pointer for decoding functions.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::Handle::decode):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::Handle::decode):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
(Handle):
- Shared/qt/ArgumentCodersQt.cpp:
(CoreIPC::::decode):
- Shared/qt/ArgumentCodersQt.h:
(CoreIPC):
- Shared/qt/LayerTreeContextQt.cpp:
(WebKit::LayerTreeContext::decode):
- Shared/qt/PlatformCertificateInfo.h:
(WebKit::PlatformCertificateInfo::decode):
- Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::decode):
- Shared/qt/QtNetworkReplyData.h:
(QtNetworkReplyData):
- Shared/qt/QtNetworkRequestData.cpp:
(WebKit::QtNetworkRequestData::decode):
- Shared/qt/QtNetworkRequestData.h:
(QtNetworkRequestData):
- Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::decodePlatformData):
- 12:46 PM Changeset in webkit [141631] by
-
- 2 edits in trunk/Tools
Unreviewed. Re-try enabling Win-EWS tests for the third time.
https://bugs.webkit.org/show_bug.cgi?id=107968
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 12:44 PM Changeset in webkit [141630] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
https://bugs.webkit.org/show_bug.cgi?id=108674
<rdar://problem/13133595>
Reviewed by Eric Carlson.
When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
AVFoundation's supported types. Instead, it should be appending to the list of supported types.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::concatenateHashSets): Added static utility function.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.
- 12:43 PM Changeset in webkit [141629] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip more test in preparation for Win EWS bots (round 2).
https://bugs.webkit.org/show_bug.cgi?id=108249
- platform/win/TestExpectations:
- 12:36 PM Changeset in webkit [141628] by
-
- 2 edits in trunk/Tools
Fix test scripts for EWS bots to get them running once and for all.
https://bugs.webkit.org/show_bug.cgi?id=108422
Reviewed by Timothy Horton.
Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.options):
(RunTests.run):
- 12:27 PM Changeset in webkit [141627] by
-
- 2 edits in trunk/LayoutTests
WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162
Skip a test on wk2 added in r14618 that uses setAutomaticLinkDetectionEnabled.
- platform/wk2/TestExpectations:
- 12:21 PM Changeset in webkit [141626] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
https://bugs.webkit.org/show_bug.cgi?id=108252
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Konrad Piascik.
PR: 284828
We got float layoutSize(342.284122, 521.448467) and
m_maximumScale(2.243750) after computing viewport meta based on the
device pixel ratio and laid out the contents at IntSize(342, 521).
Therefore, zoomToFitScale(2.245681) would be a bit larger than
m_maximumScale based on that contents size and resulted in
maximumScale()!=minimumScale(), which made the non-scalable page
scalable.
Return zoomToFitScale for maximumScale() in such kind of case.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
- 12:13 PM Changeset in webkit [141625] by
-
- 2 edits in trunk/Source/WebCore
Another speculative windows build fix.
- platform/ScrollAnimator.h:
- 12:11 PM Changeset in webkit [141624] by
-
- 9 edits3 adds in trunk
[canvas] Add more constructors to Path
https://bugs.webkit.org/show_bug.cgi?id=108587
Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.
Source/WebCore:
Add more constructors to Path object to make it possible
to copy Path objects and parse SVG strings into a Path
object that can be used on the canvas context afterwards.
Test: fast/canvas/canvas-path-constructors.html
- html/canvas/DOMPath.h: New constructors for Path.
(WebCore::DOMPath::create):
(WebCore::DOMPath::DOMPath):
- html/canvas/DOMPath.idl: Ditto.
LayoutTests:
Add tests for new constructors of Path objects.
Since the feature is behind a flag, the test is skipped on
all platforms for now.
- fast/canvas/canvas-path-constructors-expected.txt: Added.
- fast/canvas/canvas-path-constructors.html: Added.
- fast/canvas/script-tests/canvas-path-constructors.js: Added.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 12:11 PM Changeset in webkit [141623] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler status is not restored when page history goes back
https://bugs.webkit.org/show_bug.cgi?id=108448
Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
Reviewed by Yong Li.
PR288406 Internally reviewed by Mike Fenton
When webpage goes back, it restores the old frame's selection and focused node,
but we don't save the InputHandler's status, it becomes non-input mode when page
goes back. When it restores the focus, since the new focus node is same as the old
document focused node, webcore will not notify client to update the input handler.
This patch updates the input handler's status by notifying it focus node changed.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
(WebKit):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 12:06 PM Changeset in webkit [141622] by
-
- 9 edits in trunk
[GTK] Add WTFURL source files to the build
https://bugs.webkit.org/show_bug.cgi?id=108215
Reviewed by Benjamin Poulain.
.:
- Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.
This is required when using the WTFURL backend but otherwise doesn't affect the build.
Source/WebCore:
- platform/KURLWTFURL.cpp:
(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.
Source/WTF:
The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.
- GNUmakefile.am: List the directories from which source headers will be included.
Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.
- GNUmakefile.list.am: Add build targets for the WTFURL source files.
- wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and
reorder the inclusions.
- wtf/url/src/URLCanon.h: Ditto.
- 11:58 AM Changeset in webkit [141621] by
-
- 13 edits in trunk
Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
https://bugs.webkit.org/show_bug.cgi?id=108477
Reviewed by Adam Barth.
Source/WebCore:
This change removes the 'SecurityOrigin::canAccessDatabase' check from
the constructor for the 'indexedDB' property on both DOMWindow and
WorkerContext. After the patch for http://wkbug.com/94171 this check
is redundant, as all the entry points to IDB are now gated on access
being granted.
As a side-effect, dropping the check in WorkerContextIndexedDatabase
allows us to stop holding a pointer to the ScriptExecutionContext we're
extending, which can only be a good thing.
The tests in storage/indexeddb should continue to pass.
- Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):
Drop the SecurityOrigin::canAccessDatabase check.
- Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
Drop the ScriptExecutionContext parameter from the class's
constructor and callsites.
(WebCore::WorkerContextIndexedDatabase::indexedDB):
Drop the SecurityOrigin::canAccessDatabase check.
- Modules/indexeddb/WorkerContextIndexedDatabase.h:
(WorkerContextIndexedDatabase):
Drop the stored pointer to ScriptExecutionContext, as we no longer
need it in ::indexedDB.
LayoutTests:
- http/tests/security/no-indexeddb-from-sandbox-expected.txt:
- http/tests/security/no-indexeddb-from-sandbox.html:
This test expected the 'webkitIndexedDB' property to be missing
entirely inside a sandbox. The expectation has been updated to
expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.
- platform/efl/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
This test was accidentally passing on a variety of platforms that
don't yet implement IndexedDB. Now that failure is distinguishable
we should skip it on a variety of platforms.
- 11:54 AM Changeset in webkit [141620] by
-
- 2 edits in trunk/Source/WebCore
Speculative Windows build fix.
- platform/ScrollAnimator.h:
(WebCore):
- 11:53 AM Changeset in webkit [141619] by
-
- 109 edits in trunk/Source/WebKit2
Message decoding functions should take a MessageDecoder reference
https://bugs.webkit.org/show_bug.cgi?id=108669
Reviewed by Andreas Kling.
Message encoding functions already take a reference instead of a pointer, so
make the decoding functions take a reference as well.
- Platform/CoreIPC/ArgumentCoder.h:
(CoreIPC::ArgumentCoder::decode):
- Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeStringText):
- Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::SimpleArgumentCoder::decode):
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments0::decode):
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
(CoreIPC::Arguments7::decode):
(CoreIPC::Arguments8::decode):
(CoreIPC::Arguments10::decode):
- Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::decode):
- Platform/CoreIPC/Attachment.h:
(Attachment):
- Platform/CoreIPC/DataReference.cpp:
(CoreIPC::DataReference::decode):
- Platform/CoreIPC/DataReference.h:
(DataReference):
- Platform/CoreIPC/StringReference.cpp:
(CoreIPC::StringReference::decode):
- Platform/CoreIPC/StringReference.h:
(StringReference):
- Platform/CoreIPC/mac/MachPort.h:
(CoreIPC::MachPort::decode):
- Platform/SharedMemory.h:
(Handle):
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::decode):
- PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::decode):
- PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h:
(DictionaryPopupInfo):
- Shared/EditorState.cpp:
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(EditorState):
- Shared/FontInfo.cpp:
(WebKit::FontInfo::decode):
- Shared/FontInfo.h:
(FontInfo):
- Shared/LayerTreeContext.h:
(LayerTreeContext):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
(NetworkProcessCreationParameters):
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
- Shared/OriginAndDatabases.cpp:
(WebKit::OriginAndDatabases::decode):
- Shared/OriginAndDatabases.h:
(OriginAndDatabases):
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
(PlatformPopupMenuData):
- Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::decode):
- Shared/Plugins/NPIdentifierData.h:
(NPIdentifierData):
- Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::decode):
- Shared/Plugins/NPVariantData.h:
(NPVariantData):
- Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::decode):
- Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
- Shared/PrintInfo.cpp:
(WebKit::PrintInfo::decode):
- Shared/PrintInfo.h:
(PrintInfo):
- Shared/SandboxExtension.h:
(Handle):
(HandleArray):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::decode):
- Shared/SecurityOriginData.h:
(SecurityOriginData):
- Shared/SessionState.cpp:
(WebKit::SessionState::decode):
- Shared/SessionState.h:
(SessionState):
- Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::decode):
- Shared/ShareableBitmap.h:
(Handle):
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::decode):
- Shared/ShareableResource.h:
(Handle):
- Shared/SharedWorkerProcessCreationParameters.cpp:
(WebKit::SharedWorkerProcessCreationParameters::decode):
- Shared/SharedWorkerProcessCreationParameters.h:
(SharedWorkerProcessCreationParameters):
- Shared/StatisticsData.cpp:
(WebKit::StatisticsData::decode):
- Shared/StatisticsData.h:
(StatisticsData):
- Shared/StringPairVector.h:
(WebKit::StringPairVector::decode):
- Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::decode):
- Shared/UpdateInfo.h:
(UpdateInfo):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::decode):
- Shared/WebContextMenuItemData.h:
(WebContextMenuItemData):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeImage):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebEvent.cpp:
(WebKit::WebEvent::decode):
- Shared/WebEvent.h:
(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):
- Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::Data::decode):
- Shared/WebGeolocationPosition.h:
(Data):
- Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::decode):
- Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h:
(Data):
- Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::decode):
- Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::decode):
- Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::decode):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::decode):
- Shared/WebPageGroupData.h:
(WebPageGroupData):
- Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::decode):
- Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::decode):
- Shared/WebPopupItem.h:
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
- Shared/WebPreferencesStore.h:
(WebPreferencesStore):
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
- Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::decode):
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::decode):
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
- Shared/cf/ArgumentCodersCF.h:
(CoreIPC):
- Shared/mac/ArgumentCodersMac.h:
(CoreIPC):
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
- Shared/mac/AttributedString.h:
(AttributedString):
- Shared/mac/AttributedString.mm:
(WebKit::AttributedString::decode):
- Shared/mac/ColorSpaceData.h:
(ColorSpaceData):
- Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::decode):
- Shared/mac/LayerTreeContextMac.mm:
(WebKit::LayerTreeContext::decode):
- Shared/mac/ObjCObjectGraphCoders.h:
(WebContextObjCObjectGraphDecoder):
(InjectedBundleObjCObjectGraphDecoder):
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphDecoder::baseDecode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
(WebKit::WebContextObjCObjectGraphDecoder::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoder::decode):
- Shared/mac/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
- Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::decode):
- Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
(RemoteLayerTreeTransaction):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::decode):
- Shared/mac/SecItemRequestData.h:
- Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::decode):
- Shared/mac/SecItemResponseData.h:
(SecItemResponseData):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::decodePlatformData):
(CoreIPC::::decode):
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageDecoder::decode):
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h:
(Parameters):
- 11:44 AM Changeset in webkit [141618] by
-
- 3 edits2 adds in trunk
Smart link can erroneously move caret after an URL when typing immediately before it
https://bugs.webkit.org/show_bug.cgi?id=92812
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by smart link being triggered even when a user finished typing a word
immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
was after the URL but we were missing a check for when the caret is before the URL.
Fixed the bug by adding this check.
Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html
- editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
LayoutTests:
Add a regression for typing immediately before an URL while smart link is enabled.
WebKit should not be moving the caret erroneously.
- editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
- editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.
- 11:40 AM Changeset in webkit [141617] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.
- WebCore.vcproj/WebCore.vcproj:
- 11:29 AM Changeset in webkit [141616] by
-
- 4 edits2 adds in trunk
[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
https://bugs.webkit.org/show_bug.cgi?id=108403
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-preferred-logical-widths.html
The code before this change was only handling minmax() with 2 fixed widths.
The new code was updated to remove this artificial limitation and we now
support all combination of minmax().
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated to use computePreferredTrackWidth..
(WebCore::RenderGrid::computePreferredTrackWidth):
Added this helper function that implements the core of the preferred width
computation.
- rendering/RenderGrid.h: Added computePreferredTrackWidth.
LayoutTests:
- fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
- fast/css-grid-layout/grid-preferred-logical-widths.html: Added.
- 11:25 AM Changeset in webkit [141615] by
-
- 5 edits3 adds in trunk
Cached main resources report a zero identifer on 304s
https://bugs.webkit.org/show_bug.cgi?id=108402
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/cache/iframe-304-crash.html
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader
instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):
LayoutTests:
- http/tests/cache/iframe-304-crash-expected.txt: Added.
- http/tests/cache/iframe-304-crash.html: Added.
- http/tests/cache/resources/iframe304.php: Added.
- platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
- platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.
- 11:14 AM Changeset in webkit [141614] by
-
- 11 edits in trunk
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408
Reviewed by Tony Chang.
I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.
Source/WebCore:
- bindings/v8/custom/V8IntentCustom.cpp:
Source/WebKit/chromium:
The features.gypi bit depends on https://codereview.chromium.org/12143002/
and will disable web intents support on android. Since common.gypi
sets enable_web_intents to 0 explicitly, it seems this is currently on
by accident anyway.
While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
features.gypi completely, it's still set further down the file if
enable_web_intents is on.
- WebKit.gyp:
- features.gypi:
- src/WebFrameImpl.cpp:
Tools:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 11:07 AM Changeset in webkit [141613] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: make console object state hint non-active
https://bugs.webkit.org/show_bug.cgi?id=108642
Reviewed by Vsevolod Vlasov.
Otherwise it seems like an active element user could click.
- inspector/front-end/inspector.css:
(.object-info-state-note):
- 11:04 AM Changeset in webkit [141612] by
-
- 3 edits18 adds in trunk
Zero size gradient should paint nothing on canvas
https://bugs.webkit.org/show_bug.cgi?id=102654
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-01
Reviewed by Dirk Schulze.
Source/WebCore:
The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.
Tests: fast/canvas/canvas-fill-zeroSizeGradient.html
fast/canvas/canvas-fillRect-zeroSizeGradient.html
fast/canvas/canvas-fillText-zeroSizeGradient.html
fast/canvas/canvas-stroke-zeroSizeGradient.html
fast/canvas/canvas-strokeRect-zeroSizeGradient.html
fast/canvas/canvas-strokeText-zeroSizeGradient.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
LayoutTests:
The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.
- fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
- fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
- fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
- fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
- fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
- fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
- fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
- fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
- fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.
- 11:00 AM Changeset in webkit [141611] by
-
- 2 edits in trunk/Source/WebCore
HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=108504
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-02-01
Reviewed by Kenneth Russell.
Fixed a segfault by checking if the returned AudioBus is null or not.
If it is, we should early return in the same way it was being done already
in HRTFElevation::calculateKernelsForAzimuthElevation();
No new tests, covered by existing tests.
- platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
- 10:59 AM Changeset in webkit [141610] by
-
- 8 edits in trunk/Source/WebCore
ScrollAnimatorMac should adopt contentAreaScrolledInDirection
https://bugs.webkit.org/show_bug.cgi?id=108647
-and corresponding-
<rdar://problem/12434779>
Reviewed by Anders Carlsson.
This patch makes notifyContentAreaScrolled() and notifyPositionChanged() take a
FloatSize parameter that represents the scroll delta so that it can be passed
along to contentAreaScrolledInDirection:.
Pass along the scroll delta.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
The delta is not needed in this base-class implementation. It will only be needed
in the ScrollAnimatorMac override.
(WebCore::ScrollAnimator::notifyPositionChanged):
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):
Pass along the delta.
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):
Add contentAreaScrolledInDirection: to the NSScrollerImpDetails.
- platform/mac/NSScrollerImpDetails.h:
New member variable m_contentAreaScrolledTimerScrollDelta stores the current
scroll delta while we are waiting for m_sendContentAreaScrolledTimer to fire.
- platform/mac/ScrollAnimatorMac.h:
We need this so that we can call just contentAreaScrolled if
contentAreaScrolledInDirection: is not available.
- platform/mac/ScrollAnimatorMac.mm:
(supportsContentAreaScrolledInDirection):
Pass along the delta.
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
If contentAreaScrolledInDirection: is available, call it with the delta, and then
reset our delta. Otherwise, still call contentAreaScrolled.
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- 10:56 AM Changeset in webkit [141609] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 141357
[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381
Reviewed by James Robinson.
Source/WebKit/chromium:
WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):
Tools:
- DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
LayoutTests:
- platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
- platform/chromium/plugins/re-request-touch-events-crash.html: Added.
TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/12088115
- 10:55 AM Changeset in webkit [141608] by
-
- 4 edits in trunk
Source/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108510
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.
- src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.
LayoutTests: [Chromium] Expect spellcheck to ignore whitespace
https://bugs.webkit.org/show_bug.cgi?id=108510
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.
- platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.
- 10:49 AM Changeset in webkit [141607] by
-
- 4 edits in trunk
Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
https://bugs.webkit.org/show_bug.cgi?id=108639
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering-expected.txt:
- 10:45 AM Changeset in webkit [141606] by
-
- 3 edits4 adds in trunk
Padding in a parent inline preceding an empty inline child should be counted towards width
https://bugs.webkit.org/show_bug.cgi?id=108226
Reviewed by Levi Weintraub.
Source/WebCore:
Add the border/padding/margin from an empty inline's parent inline if it is the first or last
child of the inline.
Tests: fast/inline/parent-inline-element-padding-contributes-width.html
fast/inline/positioned-element-padding-contributes-width.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/inline/parent-inline-element-padding-contributes-width-expected.txt: Added.
- fast/inline/parent-inline-element-padding-contributes-width.html: Added.
- fast/inline/positioned-element-padding-contributes-width-expected.txt: Added.
- fast/inline/positioned-element-padding-contributes-width.html: Added.
- 10:40 AM Changeset in webkit [141605] by
-
- 4 edits in trunk/Source/WebCore
Continue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
https://bugs.webkit.org/show_bug.cgi?id=108531
Reviewed by Adam Barth.
The threaded HTML parser will create and init() the XSSAuditor on the main thread, but filterToken() will be called on the background.
No new tests because no change in functionality.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
- 10:32 AM Changeset in webkit [141604] by
-
- 3 edits in trunk/Source/JavaScriptCore
Removed an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
https://bugs.webkit.org/show_bug.cgi?id=108657
Reviewed by Anders Carlsson.
- runtime/JSGlobalObject.cpp:
(JSC):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
- 10:31 AM Changeset in webkit [141603] by
-
- 4 edits in trunk/Source/WebCore
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
https://bugs.webkit.org/show_bug.cgi?id=108654
Reviewed by Alexey Proskuryakov.
No new tests (No behavior change.)
Remove the KURL parameter parameter from this method which, in practice,
is always the same as the url of the ResourceRequest parameter.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
- loader/DocumentLoader.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):
- 10:18 AM Changeset in webkit [141602] by
-
- 3 edits in trunk/Tools
Set the GTK 64-bit Debug builder to build and test only WebKit1
https://bugs.webkit.org/show_bug.cgi?id=108648
Reviewed by Philippe Normand.
- BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
(BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
for building and testing only WebKit1 on the builder's platform.
- 9:49 AM Changeset in webkit [141601] by
-
- 2 edits in tags/Safari-537.26.5/Source/WebKit2
Merged r141180. <rdar://problem/13047398>
- 9:46 AM Changeset in webkit [141600] by
-
- 29 edits in tags/Safari-537.26.5/Source/WebKit2
Merged r141167. <rdar://problem/13047398>
- 9:18 AM Changeset in webkit [141599] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
https://bugs.webkit.org/show_bug.cgi?id=108607
Reviewed by Anders Carlsson.
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::executeEventSource): Remove the is valid
work queue check.
(WorkQueue::EventSource): WorkQueue is now refcounted, so keep a
reference when a new job is scheduled and unref it when it
finishes.
- 8:34 AM Changeset in webkit [141598] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt] Make QWebHistory unit tests more robust
Reviewed by Jocelyn Turcotten.
The tests were using a QEventLoop::exec() call to verify the emission
of the loadFinished() signal after calling for example back() or forward().
However sometimes the call to back() may emit the signal immediately and
sometimes async, causing instabilities in test runs. The call to exec()
also means that if there was a bug then the rest would hang forever because
exec() has no timeout.
This patch introduces a simple SignalBarrier class that solves both issues:
(1) ensureSignalEmitted() supports the immediate signal emission case as well
as the async one.
(2) Through the use of QSignalSpy's wait() there's an actual timeout.
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::init):
(tst_QWebHistory::cleanup):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
(tst_QWebHistory::goToItem):
(tst_QWebHistory::serialize_2):
- tests/util.h:
(waitForSignal):
(SignalBarrier):
(SignalBarrier::SignalBarrier):
(SignalBarrier::ensureSignalEmitted):
- 8:14 AM Changeset in webkit [141597] by
-
- 2 edits in trunk/Source/WebKit/gtk/po
Unreviewed, GTK build fix after r141566.
- POTFILES.in: The FullscreenVideoController moved to WebCore.
- 8:02 AM Changeset in webkit [141596] by
-
- 18 edits1 add1 delete in trunk/Tools
[chromium] move ownership of TestRunner object to TestInterfaces
https://bugs.webkit.org/show_bug.cgi?id=108464
Reviewed by Adam Barth.
Before, TestShell owned the class. This also removes the last include
from DumpRenderTree to TestRunner/src.
This also deletes TestDelegate and uses WebTestDelegate everywhere
instead.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebKit):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
(WebTestRunner::EventSender::setDelegate):
(EventSender):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
(WebTestRunner::GamepadController::setDelegate):
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
(WebTestRunner):
(GamepadController):
- DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::bindTo):
(WebTestRunner::TestInterfaces::resetAll):
(WebTestRunner):
(WebTestRunner::TestInterfaces::setTestIsRunning):
(WebTestRunner::TestInterfaces::testRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
- DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
(WebTestRunner):
(WebTestRunner::WebTestRunner::WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
(WebTestRunner::WebTestRunner::shouldDumpCreateView):
(WebTestRunner::WebTestRunner::canOpenWindows):
(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner::WebTestRunner::webPermissions):
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::setTitleTextDirection):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::runFileTest):
(TestShell::resetTestController):
(TestShell::dump):
(TestShell::bindJSObjectsToWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::testRunner):
(TestShell):
- 7:58 AM Changeset in webkit [141595] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180131. Requested by
"Florin Malita" <fmalita@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- DEPS:
- 7:46 AM Changeset in webkit [141594] by
-
- 6 edits in trunk
Web Inspector: relax goto file matching again.
https://bugs.webkit.org/show_bug.cgi?id=108346
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change brings back behavior introduced in r116244.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):
- inspector/front-end/utilities.js:
(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering-expected.txt:
- inspector/filtered-item-selection-dialog-filtering.html:
- 7:43 AM Changeset in webkit [141593] by
-
- 8 edits in trunk
Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
https://bugs.webkit.org/show_bug.cgi?id=108601
Reviewed by Pavel Feldman.
Source/WebCore:
Tree elememnts for uiSourceCodes are not created until really needed anymore.
They are now created when parent folder tree elememnts are expanded or when uiSourceCode is revealed in navigator.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getOrCreateScriptTreeElement):
(WebInspector.NavigatorView.prototype._getScriptTreeElement):
(WebInspector.NavigatorView.prototype._createScriptTreeElement):
(WebInspector.NavigatorView.prototype._removeScriptTreeElement):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.isScriptSourceAdded):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype._populateFolderTreeElement):
(WebInspector.NavigatorView.prototype._addScriptTreeElement):
(WebInspector.NavigatorView.prototype._adoptUISourceCode):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
LayoutTests:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
- inspector/debugger/scripts-file-selector-expected.txt:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-sorting-expected.txt:
- inspector/debugger/scripts-sorting.html:
- 7:40 AM Changeset in webkit [141592] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, flagging more fullscreen tests in GTK due to bug 108363.
- platform/gtk/TestExpectations:
- 7:32 AM Changeset in webkit [141591] by
-
- 9 edits in trunk/Source/WTF
Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
https://bugs.webkit.org/show_bug.cgi?id=107303
Reviewed by Yury Semikhatsky.
I'd like to use ValueType[] as className for the container data members
because class names of template parameters already present in the container class names.
- wtf/MemoryInstrumentationArrayBufferView.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashCountedSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashMap.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationHashSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationListHashSet.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationSequence.h:
- wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
- wtf/MemoryInstrumentationVector.h:
(WTF::reportMemoryUsage):
- 7:27 AM Changeset in webkit [141590] by
-
- 3 edits in trunk/Tools
PatchLog process durations are increasing linearly with time (faulty data logging)
https://bugs.webkit.org/show_bug.cgi?id=108621
Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.
Added a check to prevent a stop event from happening to the same patch multiple times.
- QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.stopped):
- 7:27 AM Changeset in webkit [141589] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: TabbedEditorContainer.History performance optimization.
https://bugs.webkit.org/show_bug.cgi?id=108581
Introduced history items indexing by url.
Reviewed by Pavel Feldman.
Covered by existing test.
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):
- 7:01 AM Changeset in webkit [141588] by
-
- 6 edits1 add in trunk/Source
Added TriState to WTF and started using it in one place
https://bugs.webkit.org/show_bug.cgi?id=108628
Reviewed by Beth Dakin.
- runtime/PrototypeMap.h:
(JSC::PrototypeMap::isPrototype): Use TriState instead of boolean. In
response to review feedback, this is an attempt to clarify that our
'true' condition is actually just a 'maybe'.
- runtime/PrototypeMap.h:
(PrototypeMap):
(JSC::PrototypeMap::isPrototype):
../WebCore:
- editing/EditingStyle.h:
(WebCore): Moved TriState to WTF so it can be used in more places.
../WTF:
Useful for expressing "maybe" conditions in a boolean context.
- WTF.xcodeproj/project.pbxproj:
- wtf/TriState.h: Added.
(WTF):
- 6:17 AM Changeset in webkit [141587] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r141319.
http://trac.webkit.org/changeset/141319
https://bugs.webkit.org/show_bug.cgi?id=108629
This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- 6:12 AM Changeset in webkit [141586] by
-
- 2 edits in trunk/Source/WTF
Build fix for WinCE after r137709
https://bugs.webkit.org/show_bug.cgi?id=105767
Do not pass functions as const references to
templated arguments to make the compiler happy.
- wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 6:11 AM Changeset in webkit [141585] by
-
- 2 edits in trunk/Tools
[GTK][WK2] MiniBrowser fullscreen signals support
https://bugs.webkit.org/show_bug.cgi?id=108005
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-01
Reviewed by Carlos Garcia Campos.
Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.
- MiniBrowser/gtk/BrowserWindow.c:
(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):
- 5:42 AM Changeset in webkit [141584] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip some failing tests on EFL bots after r141459 and r141310.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.
- 5:08 AM Changeset in webkit [141583] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] EwkContext should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107666
Reviewed by Andreas Kling.
EwkContext should be based on C WK2 API so that API layering is not violated.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):
- UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
- 5:00 AM Changeset in webkit [141582] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix hanging deleteQWebViewTwice test
Reviewed by Allan Sandfeld Jensen.
Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::deleteQWebViewTwice):
- 4:56 AM Changeset in webkit [141581] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_auth_request
https://bugs.webkit.org/show_bug.cgi?id=107806
Reviewed by Andreas Kling.
Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.
- UIProcess/API/efl/ewk_auth_request.cpp:
(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):
- UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
(EwkAuthRequest):
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):
- 4:54 AM Changeset in webkit [141580] by
-
- 2 edits in trunk/Source/WebKit2
[Gtk][WK2] Fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108588
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.
Don't remove WorkQueue during execution.
Following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544
- Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):
- 4:23 AM Changeset in webkit [141579] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
- 4:16 AM Changeset in webkit [141578] by
-
- 32 edits in trunk
Enable unprefixed CSS transitions by default.
https://bugs.webkit.org/show_bug.cgi?id=108216
Reviewed by Dean Jackson.
.:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- GNUmakefile.features.am.in:
- css/CSSPropertyNames.in:
- dom/EventNames.in:
- dom/TransitionEvent.cpp:
- dom/TransitionEvent.h:
- dom/TransitionEvent.idl:
- page/DOMWindow.idl:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):
Source/WebKit/chromium:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- features.gypi:
Source/WebKit/mac:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Configurations/FeatureDefines.xcconfig:
Tools:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.
- fast/events/event-creation-expected.txt:
- fast/events/event-creation.html: Add the test that was commented out
before.
- platform/chromium/TestExpectations:
- 3:49 AM Changeset in webkit [141577] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r141548.
http://trac.webkit.org/changeset/141548
https://bugs.webkit.org/show_bug.cgi?id=108579
userscript-plugin-document.html is flaky
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 3:39 AM Changeset in webkit [141576] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipped some failing tests.
- platform/qt/TestExpectations:
- 3:27 AM Changeset in webkit [141575] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Skip hanging WebGL software fallback tests
Reviewed by Allan Sandfeld Jensen.
See also https://bugs.webkit.org/show_bug.cgi?id=105820.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
- 3:26 AM Changeset in webkit [141574] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: fix jscompiler warnings
https://bugs.webkit.org/show_bug.cgi?id=108604
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextSubMenuItem):
- inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._isDockedToBottom):
- 3:22 AM Changeset in webkit [141573] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed EFL gardening.
Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439
- platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/efl/fast/js/global-constructors-expected.txt:
- 3:00 AM Changeset in webkit [141572] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.
- platform/efl/TestExpectations:
- 2:51 AM Changeset in webkit [141571] by
-
- 4 edits in trunk/Source
Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=108590
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.
Source/WebCore:
Sort CoordinatedGraphics files in Target.pri in alphabetical order.
No new tests. No change in behavior.
- Target.pri:
Source/WebKit2:
Sort class declarations in alphabetical order.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):
- 2:42 AM Changeset in webkit [141570] by
-
- 173 edits in trunk/Source/WebCore
Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
https://bugs.webkit.org/show_bug.cgi?id=107369
Reviewed by Yury Semikhatsky.
It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::reportMemoryUsage):
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::reportMemoryUsage):
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
- bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
- bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::reportMemoryUsage):
- css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
- css/CSSCalculationValue.cpp:
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
- css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportMemoryUsage):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
- css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportMemoryUsage):
- css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
- css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::reportMemoryUsage):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportMemoryUsage):
- css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
- css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportMemoryUsage):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
- css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
- css/CSSRule.cpp:
(WebCore::CSSRule::reportMemoryUsage):
- css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
- css/CSSRuleList.h:
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportMemoryUsage):
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
- css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
- css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
- css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
- css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
- css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
- css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
- css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::reportMemoryUsage):
- css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
- css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleRule.cpp:
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):
- css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):
- css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
- css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
- css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):
- dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
- dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::reportMemoryUsage):
- dom/ContainerNode.h:
(ContainerNode):
- dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
- dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
- dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
- dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
- dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
- dom/NodeRareData.cpp:
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
- dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportMemoryUsage):
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::reportMemoryUsage):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::reportMemoryUsage):
- dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reportMemoryUsage):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::reportMemoryUsage):
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
- inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::reportMemoryUsage):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reportMemoryUsage):
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):
- inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
- loader/CachedMetadata.cpp:
(WebCore::CachedMetadata::reportMemoryUsage):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
- loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::reportMemoryUsage):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
- loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
- loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
- page/DOMTimer.cpp:
(WebCore::DOMTimer::reportMemoryUsage):
- page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
- page/Page.cpp:
(WebCore::Page::reportMemoryUsage):
- platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
- platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
- platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::reportMemoryUsage):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
- platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
- platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::reportMemoryUsage):
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::reportMemoryUsage):
- platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::reportMemoryUsage):
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::reportMemoryUsage):
- platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
(reportMemoryUsage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
- platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::reportMemoryUsage):
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::reportMemoryUsage):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::reportMemoryUsage):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBufferData::reportMemoryUsage):
- platform/graphics/skia/MemoryInstrumentationSkia.cpp:
(reportMemoryUsage):
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::reportMemoryUsage):
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
- platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase):
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
- platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::reportMemoryUsage):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::reportMemoryUsage):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::reportMemoryUsage):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::reportMemoryUsage):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reportMemoryUsage):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::reportMemoryUsage):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::reportMemoryUsage):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::reportMemoryUsage):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::reportMemoryUsage):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::reportMemoryUsage):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
- rendering/RenderText.cpp:
(WebCore::RenderText::reportMemoryUsage):
- rendering/RenderView.cpp:
(WebCore::RenderView::reportMemoryUsage):
- rendering/style/DataRef.h:
(WebCore::DataRef::reportMemoryUsage):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
- svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):
- 2:40 AM Changeset in webkit [141569] by
-
- 1 edit in trunk/Source/WebKit/qt/ChangeLog
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327
Rubber-stamped by Simon Hausmann.
In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 2:37 AM Changeset in webkit [141568] by
-
- 4 edits2 adds32 deletes in trunk/LayoutTests
[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
https://bugs.webkit.org/show_bug.cgi?id=108333
Reviewed by Tony Chang.
Add reftests, cleanup existing tests.
- fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
- fast/regions/region-overflow-auto-overflow-hidden.html:
- fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
- fast/regions/region-overflow-auto-overflow-visible.html:
- platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
- platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
- 2:35 AM Changeset in webkit [141567] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327
Rubber-stamped by Simon Hausmann.
In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.
- WebCoreSupport/FrameLoaderClientQt.cpp:
- 2:25 AM Changeset in webkit [141566] by
-
- 12 edits2 moves in trunk/Source
[GTK][GStreamer] FullscreenVideoControllerGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=107398
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.
- GNUmakefile.list.am:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
- platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.
Source/WebKit/gtk:
Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.
- GNUmakefile.am: Remove FullscreenVideoController.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
- WebCoreSupport/FullscreenVideoController.cpp: Removed.
- WebCoreSupport/FullscreenVideoController.h: Removed.
- webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
- webkit/webkitwebviewprivate.h: Ditto
- 2:11 AM Changeset in webkit [141565] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: fix cursor location in Source Frame
https://bugs.webkit.org/show_bug.cgi?id=108592
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.
Normalize range before computing amount of lines in
_updateSourcePosition.
No new tests.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.
- inspector/front-end/inspector.css: Slightly bigger left padding for the text.
(.source-frame-position):
- 2:09 AM Changeset in webkit [141564] by
-
- 15 edits in trunk/Source/WebCore
Unreviewed build fix after r141553.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::HasInstance):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::HasInstance):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
- 2:07 AM Changeset in webkit [141563] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584
Reviewed by Pavel Feldman.
Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.
- inspector/front-end/NavigatorView.js:
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
- 2:06 AM Changeset in webkit [141562] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] MiniBrowser segfaults on loading google.com
https://bugs.webkit.org/show_bug.cgi?id=108597
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.
This patch also adds omitted break statement.
- 1:52 AM Changeset in webkit [141561] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
https://bugs.webkit.org/show_bug.cgi?id=108591
Reviewed by Pavel Feldman.
Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
- 1:32 AM Changeset in webkit [141560] by
-
- 5 edits2 adds in trunk
AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596
Reviewed by Ryosuke Niwa.
Source/WebCore:
Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.
The solution is to not trigger a focus change in this case and instead use a selected children change notification.
Test: platform/mac/accessibility/combobox-activedescendant-notifications.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
- platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.
- 1:17 AM Changeset in webkit [141559] by
-
- 4 edits in trunk
Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
https://bugs.webkit.org/show_bug.cgi?id=108291
Reviewed by Ryosuke Niwa.
This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.
Unskip a failing Lion test
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=108291
Reviewed by Ryosuke Niwa.
- platform/mac/TestExpectations:
- 1:06 AM Changeset in webkit [141558] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Replace localeCompare in NavigatorView with compareTo.
https://bugs.webkit.org/show_bug.cgi?id=108585
Reviewed by Pavel Feldman.
Replaced String.prototype.localeCompare with String.prototype.compareTo
in NavigatorView to improve performance.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
- 12:57 AM Changeset in webkit [141557] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: File system pending requests list is not cleared after processing.
https://bugs.webkit.org/show_bug.cgi?id=108573
Reviewed by Pavel Feldman.
- inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._processPendingFileSystemRequests):
- 12:52 AM Changeset in webkit [141556] by
-
- 5 edits in trunk/Source/WebCore
Dubious cast from HTMLCollection to HTMLAllCollection
https://bugs.webkit.org/show_bug.cgi?id=108538
Reviewed by Adam Barth.
Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.
- dom/Document.cpp:
(WebCore::Document::all):
Pass correct type to template.
- html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
- html/HTMLAllCollection.h:
(HTMLAllCollection):
Make create() method arguments compatible with template above.
- html/HTMLAllCollection.idl:
Enable binding integrity.
- 12:50 AM Changeset in webkit [141555] by
-
- 16 edits2 adds in trunk
Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883
Patch by Ken Kania <kkania@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.
Introduce support for being notified when a JavaScript modal dialog
is opening and closing, as well as a new command for accepting or
dismissing the dialog.
Source/WebCore:
Test: inspector-protocol/page/willRunJavaScriptDialog.html
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
(InspectorClient):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
- inspector/InspectorPageAgent.h:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
(WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
- page/Chrome.cpp:
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
Source/WebKit/chromium:
- public/WebDevToolsAgent.h:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
(WebKit):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(BrowserDataHintStringValues):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
LayoutTests:
- inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
- inspector-protocol/page/javascriptDialogEvents.html: Added.
- 12:48 AM Changeset in webkit [141554] by
-
- 4 edits1 add in trunk/Source
Touch disambiguation blacklist is not being queried properly
https://bugs.webkit.org/show_bug.cgi?id=108222
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-02-01
Reviewed by Adam Barth.
TEST=WebFrameTest::DisambiguationPopupBlacklist
Source/WebCore:
Fix the blacklist so that we check it for the right nodes.
Add a chromium test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.
- page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
Source/WebKit/chromium:
Fix the blacklist so that we check it for the right nodes.
Add a test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_blacklist.html: Added.
- 12:45 AM Changeset in webkit [141553] by
-
- 28 edits in trunk/Source/WebCore
[V8] Add a temporary optional Isolate parameter to HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108567
Reviewed by Adam Barth.
The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- 12:44 AM Changeset in webkit [141552] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.
- platform/chromium/TestExpectations:
- 12:44 AM Changeset in webkit [141551] by
-
- 6 edits in trunk/Source/WebCore
[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108578
Patch by Nils Barth <nbarth@google.com> on 2013-02-01
Reviewed by Kentaro Hara.
Since CPP/GObject/ObjC code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support static attributes, add test to skip these.
This lets us remove #if macro from static in test files and not need
these in future.
Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
Test: bindings/scripts/test/TestSupplemental.idl (run-bindings-test)
- bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestSupplemental.idl:
- 12:37 AM Changeset in webkit [141550] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
https://bugs.webkit.org/show_bug.cgi?id=108236
Patch by Eberhard Graether <egraether@google.com> on 2013-02-01
Reviewed by Pavel Feldman.
This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
This way the checkboxes only show up for users that can make use of these features.
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit::InspectorClientImpl::canContinuouslyPaint):
- 12:30 AM Changeset in webkit [141549] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaselining a result.
- platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
- 12:27 AM Changeset in webkit [141548] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove V8GCController::m_edenNodes
https://bugs.webkit.org/show_bug.cgi?id=108579
Reviewed by Adam Barth.
Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.
Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).
Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.
Before:
mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms
After:
mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms
As shown above, I couldn't observe any performance regression.
No tests. No change in behavior.
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
- bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
- bindings/v8/V8GCController.h:
(V8GCController):
- 12:19 AM Changeset in webkit [141547] by
-
- 8 edits in trunk
Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
https://bugs.webkit.org/show_bug.cgi?id=108575
Reviewed by Yury Semikhatsky.
Source/WebCore:
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):
- inspector/front-end/FileSystemMapping.js:
(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):
LayoutTests:
- http/tests/inspector/console-cd-completions.html:
- http/tests/inspector/console-cd.html:
- http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
- inspector/network-status-non-http.html:
- 12:02 AM Changeset in webkit [141546] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Add MessageFlags.h in Target.pri
https://bugs.webkit.org/show_bug.cgi?id=108583
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Kentaro Hara.
Since MessageDecoder and MessageEncoder include MessageFlags.h, it
should be included in Target.pri.
- Target.pri:
Jan 31, 2013:
- 11:43 PM Changeset in webkit [141545] by
-
- 16 edits in trunk
Editor::m_compositionNode not updated on HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737
Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.
Source/WebCore:
Chromium has a bug where the IME composition did not get cancelled on JavaScript changes
to the focused editing field. Most of other WebKit ports were already doing this check
in their EditorClient::respondToChangedSelection. I took that logic and moved it to the
Editor so every port and use the same code.
An existing test editing/input/setting-input-value-cancel-ime-composition.html covers this change.
This test used to have an expectation to fail on Chromium and after this patch it will start passing.
- editing/Editor.cpp:
(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
Adding a call that can be used by any the port to cancel the composition if it's no longer valid.
(WebCore):
- editing/Editor.h:
(Editor):
Source/WebKit/chromium:
- public/WebViewClient.h:
(WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
Adding a callback to let the WebViewClient know that the composition has been cancelled.
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):
Adding a call composition if it is no longer valid.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
Adding a call to the newly refactored method.
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):
Adding a call to the newly refactored Editor method.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):
Source/WebKit/win:
- WebView.cpp:
(WebView::updateSelectionForIME):
Adding a call to the newly refactored method.
LayoutTests:
- platform/chromium/TestExpectations: Removed fail expectation for the editing/input/setting-input-value-cancel-ime-composition.html since this patch fixes the bug https://bugs.webkit.org/show_bug.cgi?id=55560
- 11:40 PM Changeset in webkit [141544] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::CFGSimplificationPhase::keepOperandAlive() conflates liveness and availability
https://bugs.webkit.org/show_bug.cgi?id=108580
Reviewed by Oliver Hunt.
This is a harmless bug in that it only results in us keeping a bit too many things
for OSR. But it's worth fixing so that the code is consistent.
keepOperandAlive() is called when block A has a branch to blocks B and C, but the
A->B edge is proven to never be taken and we want to optimize the code to have A
unconditionally jump to C. In that case, for the purposes of OSR, we need to
preserve the knowledge that the state that B expected to be live incoming from A
ought still to be live up to the point of where the A->B,C branch used to be. The
way we keep things alive is by using the variablesAtTail of A (i.e., we use the
knowledge of in what manner A made state available to B and C). The way we choose
which state should be kept alive ought to be chosen by the variablesAtHead of B
(i.e. the things B says it needs from its predecessors, including A), except that
keepOperandAlive() was previously just using variablesAtTail of A for this
purpose.
The fix is to have keepOperandAlive() use both liveness and availability in its
logic. It should use liveness (i.e. B->variablesAtHead) to decide what to keep
alive, and it should use availability (i.e. A->variablesAtTail) to decide how to
keep it alive.
This might be a microscopic win on some programs, but it's mainly intended to be
a code clean-up so that I don't end up scratching my head in confusion the next
time I look at this code.
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- 11:32 PM Changeset in webkit [141543] by
-
- 25 edits20 moves1 add in trunk/Source
Coordinated Graphics : Move CoordinatedGraphics related files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108149
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.
This patch moves Coordinated Graphics related code to WebCore. To
implement Threaded Coordinated Graphics, most of Coordianted Graphics
code should be shared. Therefore, they should reside in WebCore instead of
WebKit2.
When moving to WebCore, two renamings have been done.
- Rename LayerTreeRenderer to CoordinatedGraphicsScene.
- Rename WebCustomFilterProgram and WebCustomFilterOperation to
CoordinatedCustomFilterProgram and CoordinatedCustomFilterOperation,
respectively.
No new tests, covered by existing tests.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp.
- platform/graphics/texmap/coordinated/AreaAllocator.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h.
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp.
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h.
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterOperation.h.
- platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterProgram.h.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h.
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp.
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h.
- platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedLayerInfo.h.
- platform/graphics/texmap/coordinated/CoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp.
- platform/graphics/texmap/coordinated/CoordinatedSurface.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.h.
- platform/graphics/texmap/coordinated/CoordinatedTile.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp.
- platform/graphics/texmap/coordinated/CoordinatedTile.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h.
- platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/SurfaceUpdateInfo.h.
- platform/graphics/texmap/coordinated/UpdateAtlas.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp.
- platform/graphics/texmap/coordinated/UpdateAtlas.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h.
Source/WebKit2:
- CMakeLists.txt:
- Scripts/webkit2/messages.py:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Target.pri:
- UIProcess/API/efl/EwkView.cpp:
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/qt/qquickwebpage.cpp:
- UIProcess/API/qt/raw/qrawwebview.cpp:
- UIProcess/API/qt/raw/qrawwebview_p.h:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- UIProcess/efl/PageClientBase.cpp:
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
- UIProcess/qt/QtWebPageSGNode.cpp:
- UIProcess/qt/QtWebPageSGNode.h:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 11:26 PM Changeset in webkit [141542] by
-
- 3 edits5 adds in trunk
[Qt] Add support for text decoration "wavy" style
https://bugs.webkit.org/show_bug.cgi?id=93507
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-01-31
Reviewed by Simon Hausmann.
Source/WebCore:
Add support for text decoration "wavy" style for Qt platform.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQPenStyle):
Remove FIXME comments obsoleted by this patch.
(WebCore::GraphicsContext::drawLine):
Implement wavy style line tracer.
LayoutTests:
Add pixel-test expected results for CSS3 text decoration tests for Qt port.
- platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style-expected.png: Added.
- platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.
- 11:07 PM Changeset in webkit [141541] by
-
- 5 edits in trunk/Source/WebCore
[CPP,GObject,ObjC] Add 'enum' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108565
Patch by Nils Barth <nbarth@google.com> on 2013-01-31
Reviewed by Kentaro Hara.
Since legacy code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support enumerations, add test to skip attributes of enum type.
This lets us remove #if macro from enum in test file and not need
these in future.
Also minor associated code cleaning:
auxiliary variable: $type = $attribute->signature->type.
Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
- bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
- bindings/scripts/test/TestObj.idl: remove #if macro
- 10:56 PM Changeset in webkit [141540] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
https://bugs.webkit.org/show_bug.cgi?id=108543
Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.
Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositionFromExistingText):
- tests/WebViewTest.cpp:
Re-enabling the test
- 10:52 PM Changeset in webkit [141539] by
-
- 3 edits in trunk/Source/WTF
Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
https://bugs.webkit.org/show_bug.cgi?id=107278
Reviewed by Yury Semikhatsky.
I replaced nodeName with className because we newer report node name for private and raw buffers
but need to report their class names.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
- wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addRawBuffer):
(MemoryClassInfo):
- 10:36 PM Changeset in webkit [141538] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, followup fix for r141535.
- tests/WebFrameTest.cpp:
- 10:28 PM Changeset in webkit [141537] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r180023. Requested by
thakis_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31
- DEPS:
- 9:54 PM Changeset in webkit [141536] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r141192): Crash beneath cti_op_get_by_id_generic @ discussions.apple.com
https://bugs.webkit.org/show_bug.cgi?id=108576
Reviewed by Filip Pizlo.
This was a long-standing bug. The DFG would destructively reuse a register
in op_convert_this, but:
- The bug only presented during speculation failure for type Other
- The bug presented by removing the low bits of a pointer, which used to be harmless, since all objects were so aligned anyway.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Don't reuse our this register as
our scratch register. The whole point of our scratch register is to
avoid destructively modifying our this register. I'm pretty sure this
was a copy-paste error.
- 9:37 PM Changeset in webkit [141535] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed, disabling failing test.
- tests/WebFrameTest.cpp:
- 9:01 PM Changeset in webkit [141534] by
-
- 2 edits in trunk/Tools
Provide a sensible default architecture when building on iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=108395
Patch by David Farler <dfarler@apple.com> on 2013-01-31
Reviewed by Anders Carlsson.
- Scripts/webkitdirs.pm:
(determineArchitecture): Anchor SDK regex matches at the beginning.
- 8:25 PM Changeset in webkit [141533] by
-
- 5 edits in trunk/Source/WebCore
Refactoring: Remove the default argument value for Node::setFocus
https://bugs.webkit.org/show_bug.cgi?id=108554
Reviewed by Kentaro Hara.
There is no code to use the default argument.
No new tests. Just a refactoring.
- dom/Node.h: Remove default argument value for setFocus.
- dom/ContainerNode.h:
(ContainerNode): Ditto.
- html/HTMLAreaElement.h:
(HTMLAreaElement): Add OVERRIDE to setFocus.
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase): Ditto.
- 8:20 PM Changeset in webkit [141532] by
-
- 1 edit5 adds in trunk/LayoutTests
[Chromium] Unreviewed, rebaselining expectations.
- platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
- platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.
- 8:03 PM Changeset in webkit [141531] by
-
- 7 edits in trunk
[Track] Closed Caption button shouldn't be visible if all the track resources have failed loading
https://bugs.webkit.org/show_bug.cgi?id=106285
Reviewed by Eric Carlson.
Source/WebCore:
Updated existing test cases.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTracksAreReady): Checked whether there are tracks not loaded
when the algorithm began.
(WebCore::HTMLMediaElement::textTrackReadyStateChanged): If the ready state changed to
FailedToLoad the media controls should check whether there are other caption tracks
and hide the button if not.
(WebCore::HTMLMediaElement::didAddTrack): Added trigger to closedCaptionsTrackChanged.
(WebCore::HTMLMediaElement::hasClosedCaptions): Updated check to skip tracks that
failed to load.
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Used the newly added method.
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility): Added container method for
default behaviour for refreshing the visibility of the caption button.
(WebCore::MediaControls::closedCaptionTracksChanged): Used the newly added method.
(WebCore):
- html/shadow/MediaControls.h:
(MediaControls):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTracksAreReady):
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::didAddTrack):
(WebCore::HTMLMediaElement::hasClosedCaptions):
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset):
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility):
(WebCore::MediaControls::closedCaptionTracksChanged):
(WebCore):
- html/shadow/MediaControls.h:
(MediaControls):
LayoutTests:
Updated tests to include improved behavior.
- media/video-controls-captions-expected.txt: Updated.
- media/video-controls-captions.html: Updated.
- 8:01 PM Changeset in webkit [141530] by
-
- 3 edits4 moves in trunk/Tools
buildbot should not rely on webkitpy
https://bugs.webkit.org/show_bug.cgi?id=107379
Reviewed by Eric Seidel.
Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
Once this patch is landed, we can stop restarting the master on webkitpy changes.
- BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
- BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
- BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.
(ShouldBuildTest.test_should_build):
- Scripts/webkitpy/common/config/build.py: Removed.
- Scripts/webkitpy/common/config/build_unittest.py: Removed.
- Scripts/webkitpy/common/net/htdigestparser.py: Removed.
- Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.
- 7:57 PM Changeset in webkit [141529] by
-
- 10 edits in trunk
REGRESSION(r140231): media track layout tests crashing
https://bugs.webkit.org/show_bug.cgi?id=107579
Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-31
Reviewed by Eric Carlson.
Source/WebCore:
We were using non-standard element names with HTMLElement, which made v8 try to cast
WebVTTElements to HTMLUnknownElements which was not possible. Subclassing Element instead
of HTMLElement, though this requires building HTMLElements from WebVTTElements for creating
a DOM tree. The code has been refactored to move WebVTT node type to QuialifiedName mappings
inside the WebVTTElement class. All WebVTTElements in the shadow dom tree now are in the
namespace defined by 'NullAtom'. This prevents regular styles from being applied to <b>, <i>
and similar tags. Those have to be styled separately without reusing existing QualifiedNames
and their styles. https://bugs.webkit.org/show_bug.cgi?id=107214
Unskipping tests to cover this.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::createCueRenderingTree):
(WebCore::TextTrackCue::markFutureAndPastNodes):
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::cueShadowPseudoId):
- html/track/WebVTTElement.cpp:
(WebCore::nodeTypeToTagName): get a QualifiedName to use in the shadow DOM tree.
(WebCore::WebVTTElement::WebVTTElement):
(WebCore::WebVTTElement::create):
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
(WebCore::WebVTTElement::createEquivalentHTMLElement): create an HTMLElement to use in the DOM tree.
- html/track/WebVTTElement.h:
(WebCore::WebVTTElement::setWebVTTNodeType):
(WebCore::WebVTTElement::webVTTNodeType):
(WebCore::WebVTTElement::isPastNode):
(WebCore::WebVTTElement::setIsPastNode):
(WebCore::WebVTTElement::voiceAttributeName):
- html/track/WebVTTParser.cpp:
(WebCore::tokenToNodeType): determine a WebVTT node type for the token.
(WebCore::WebVTTParser::constructTreeFromToken):
LayoutTests:
- platform/chromium/TestExpectations:
- 7:52 PM Changeset in webkit [141528] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108548
Reviewed by Anders Carlsson.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processMessage): Change Deque to Vector and do similar
logic as on patch for https://bugs.webkit.org/show_bug.cgi?id=108517
(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):
- Platform/qt/WorkQueueQt.cpp: Reflect changes on Qt WorkQueue to increase ref
count when the execution is started and decrease it when the work item is deleted,
following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): This function was moved from WebProcessProxy but
mac specific code was not protected properly: https://bugs.webkit.org/show_bug.cgi?id=108407
- 7:51 PM Changeset in webkit [141527] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking a failing test.
- platform/chromium/TestExpectations:
- 7:28 PM Changeset in webkit [141526] by
-
- 13 edits2 copies in branches/chromium/1364
Merge 141195
INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary
https://bugs.webkit.org/show_bug.cgi?id=108069
Reviewed by Hajime Morita.
Source/WebCore:
To avoid the overflow, we do:
A) Specify overflow:hidden to <input>.
However, we need to make sub-fields and buttons workable even if the
width is smaller than the intrinsic size. So, we do:
B) Make DateTimeEditElement shrinkable, and
C) Make the sub-fields scrollable horizontally like input[type=text].
To achieve B, we need to remove -webkit-date-and-time-container (D)
because width property for <input> can shrink only the direct child
elements.
Tests: fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
and new test cases in fast/forms/date/date-appearance-basic.html.
- css/html.css:
(input[type="date"]):
Change -webkit-align-items value. (D)
Specify overflow:hidden. (A)
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-datetime-edit):
Add min-width:0 (B), and overflow:hidden. (C)
Remove unnecessary white-space:pre because of white-space:nowrap below.
(input::-webkit-datetime-edit-fields-wrapper):
Added. This is the child of -webkit-datetime-edit, and contains
sub-fields. (C)
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Remove -webkit-date-and-time-container, and append DateTimeEditElement,
spin button, and picker indicator element to the ShadowRoot. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldApplyLocaleDirection):
<input> for multiple fields UI should have the direction of the browser
locale. This is a replacement of the code for dir attribute in
updateInnerTextValue below. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
Remove the code to set dir= to -webkit-date-and-time-container.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Declare shouldApplyLocaleDirection. (D)
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
Calls setHasCustomCallbacks for customStyleForRenderer. (D)
(WebCore::HTMLInputElement::customStyleForRenderer):
Set direction to RenderStyle if shouldApplyLocaleDirection is true. This
is a replacement of the dir setting code in
BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue. (D)
- html/HTMLInputElement.h:
(HTMLInputElement): Declare customStyleForRenderer. (D)
- html/InputType.cpp:
(WebCore::InputType::shouldApplyLocaleDirection):
Add default implmentation of shouldApplyLocaleDirection. (D)
- html/InputType.h:
(InputType): Declare shouldApplyLocaleDirection. (D)
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::fieldsWrapperElement):
A helper to get -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::addField):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::customStyleForRenderer):
- Iterate over children of -webkit-datetime-edit-fields-wrapper element. (C)
- Set width property instead of min-width. (B)
(WebCore::DateTimeEditElement::layout):
- Prepare -webkit-datetime-edit-fields-wrapper element. (C)
- Handle children of -webkit-datetime-edit-fields-wrapper element. (C)
- Need to do style recalc because child structure is changed. (C)
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare fieldsWrapperElement. (C)
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
Add test cases for small width and small height.
- fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html:
Update the code because of shadow tree structure change.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:
Added.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt:
Added.
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- date-appearance-basic.html: New test cases are added.
- *-appearance-pseudo-element.html: :before :after position is slightly changed because of the -webkit-align-items change.
- suggestion-picker/*.html: RTL behavior is changed. The direction of suggestion pickers matches to the direction of the input content (browser locale).
TBR=tkent@chromium.org
BUG=crbug.com/172029
Review URL: https://codereview.chromium.org/12159003
- 7:20 PM Changeset in webkit [141525] by
-
- 16 edits in trunk
Unreviewed, rolling out r141479.
http://trac.webkit.org/changeset/141479
https://bugs.webkit.org/show_bug.cgi?id=108564
breaks chromium test (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31
Source/WebCore:
- editing/Editor.cpp:
- editing/Editor.h:
(Editor):
Source/WebKit/chromium:
- public/WebViewClient.h:
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):
Source/WebKit/win:
- WebView.cpp:
(WebView::updateSelectionForIME):
LayoutTests:
- platform/chromium/TestExpectations:
- 7:17 PM Changeset in webkit [141524] by
-
- 43 edits in trunk/Source
Rename from parentOrHost* to parentOrShadowHost* in Node.h.
https://bugs.webkit.org/show_bug.cgi?id=108308
Source/WebCore:
Patch by Changhun Kang <temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.
No new tests. No change in behavior.
Source/WebKit2:
Patch by Changhun Kang <temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.
- 7:01 PM Changeset in webkit [141523] by
-
- 25 edits12 deletes in trunk/Source
IndexedDB: remove old transaction backend bootstrap code
https://bugs.webkit.org/show_bug.cgi?id=103923
Reviewed by Dimitri Glazkov.
Source/WebCore:
Finally remove all leftover code from the IndexedDB "giant
async refactor of 2012." This includes removal of all
IDBTransaction* interfaces that were shared between
the frontend and backend and a few straggling methods
like onUpgradeNeeded and onSuccess that were left from
the last stage of refactoring.
- Modules/indexeddb/IDBCallbacks.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore):
(WebCore::IDBDatabaseBackendImpl::metadata):
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
(IDBDatabaseBackendInterface):
- Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore):
- Modules/indexeddb/IDBTransaction.h:
(WebCore):
(IDBTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore):
(IDBTransactionBackendImpl):
- Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
- Modules/indexeddb/IDBTransactionCallbacks.h: Removed.
- Modules/indexeddb/IDBTransactionCoordinator.h:
(WebCore):
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
Remove all deprecated WebKit APIs from
the IDB backend.
- WebKit.gyp:
- public/WebIDBCallbacks.h:
(WebKit):
- public/WebIDBDatabase.h:
(WebKit):
- public/WebIDBTransaction.h: Removed.
- public/WebIDBTransactionCallbacks.h: Removed.
- src/AssertMatchingEnums.cpp:
- src/IDBCallbacksProxy.cpp:
- src/IDBDatabaseBackendProxy.cpp:
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/IDBTransactionBackendProxy.cpp: Removed.
- src/IDBTransactionBackendProxy.h: Removed.
- src/IDBTransactionCallbacksProxy.cpp: Removed.
- src/IDBTransactionCallbacksProxy.h: Removed.
- src/WebIDBCallbacksImpl.cpp:
- src/WebIDBDatabaseImpl.cpp:
(WebKit):
- src/WebIDBDatabaseImpl.h:
(WebKit):
(WebIDBDatabaseImpl):
- src/WebIDBTransactionCallbacksImpl.cpp: Removed.
- src/WebIDBTransactionCallbacksImpl.h: Removed.
- src/WebIDBTransactionImpl.cpp: Removed.
- src/WebIDBTransactionImpl.h: Removed.
- tests/IDBAbortOnCorruptTest.cpp:
- tests/IDBDatabaseBackendTest.cpp:
- 6:44 PM Changeset in webkit [141522] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r141349.
http://trac.webkit.org/changeset/141349
https://bugs.webkit.org/show_bug.cgi?id=108422
"yet another windows ews fix needed" (Requested by lforschler
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 6:42 PM Changeset in webkit [141521] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 6:41 PM Changeset in webkit [141520] by
-
- 2 edits in trunk/LayoutTests
Use TouchEvent.targetTouches rather than TouchEvent.touches since the order of Touches in TouchList is not guaranteed.
https://bugs.webkit.org/show_bug.cgi?id=108426
Reviewed by Dimitri Glazkov.
Neat fix for LayoutTest in http://trac.webkit.org/changeset/141054.
In this LayoutTest context, the length of touchEvent.touches is 2.
The Touch order in TouchList is not guaranteed. Therefore
touchEvent.touches[0] can be another touch. Rather, we should use
touchEvent.targetTouches here since its length is 1 in this context.
- fast/dom/shadow/touch-event.html:
- 6:05 PM Changeset in webkit [141519] by
-
- 10 edits in trunk
Source/WebKit/chromium: [Chromium] Select multi-word misspelling on context click
https://bugs.webkit.org/show_bug.cgi?id=108509
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.
- src/ContextMenuClientImpl.cpp:
(WebKit):
(WebKit::selectMisspellingAsync): Added utility function to get the misspelling for asynchronous spellcheck.
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Select multi-word misspelling on context click.
Tools: [Chromium] Suggest 'uppercase' for multi-word misspelling 'upper case'
https://bugs.webkit.org/show_bug.cgi?id=108509
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(append): Added utility function to append WebString to WebVector.
(MockSpellCheck::fillSuggestionList): Suggest 'uppercase' for misspelling 'upper case'.
LayoutTests: [Chromium] Expect spellcheck to select multi-word misspelling on context click
https://bugs.webkit.org/show_bug.cgi?id=108509
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.
- editing/spelling/spelling-exactly-selected-multiple-words.html: Check spelling suggestion for multi-word misspelling.
- editing/spelling/spelling-should-select-multiple-words.html: Check spelling suggestion for multi-word misspelling.
- editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
- editing/spelling/spelling-should-select-multiple-words-expected.txt:
- platform/chromium/TestExpectations: Expect spellcheck to select multi-word misspelling on context click
- 5:57 PM Changeset in webkit [141518] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r141502.
http://trac.webkit.org/changeset/141502
https://bugs.webkit.org/show_bug.cgi?id=108441
Hit assert in SVGElementInstance
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
- dom/EventTarget.idl:
- svg/SVGElementInstance.idl:
- 5:48 PM Changeset in webkit [141517] by
-
- 7 edits in trunk/Source/WebCore
Assert that computePreferredLogicalWidths never calls setNeedsLayout
https://bugs.webkit.org/show_bug.cgi?id=108539
Reviewed by Tony Chang.
computePreferredLogicalWidths should only set m_minPreferredLogicalWidth
and m_maxPreferredLogicalWidth. It shouldn't have other side-effects.
This is take 2 after this was rolled out because it was missing the guards
in RenderCounter/RenderQuote.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::minPreferredLogicalWidth):
(WebCore::RenderBox::maxPreferredLogicalWidth):
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::computePreferredLogicalWidths):
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::computePreferredLogicalWidths):
- 5:39 PM Changeset in webkit [141516] by
-
- 25 edits in trunk/Source/WebCore
Use ASSERT_WITH_SECURITY_IMPLICATION to catch bad casts in DOM
https://bugs.webkit.org/show_bug.cgi?id=108490
Reviewed by Eric Seidel.
- dom/ContainerNode.h:
(WebCore::toContainerNode):
- dom/Element.h:
(WebCore::toElement):
- dom/ShadowRoot.h:
(WebCore::toShadowRoot):
- dom/Text.h:
(WebCore::toText):
- html/HTMLElement.h:
(HTMLElement):
(WebCore::toHTMLElement):
- html/HTMLFrameOwnerElement.h:
(WebCore::toFrameOwnerElement):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasMediaControls):
- html/HTMLTemplateElement.cpp:
(WebCore::toHTMLTemplateElement):
- html/HTMLUnknownElement.h:
(WebCore::toHTMLUnknownElement):
- html/shadow/InsertionPoint.h:
(WebCore::toInsertionPoint):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
- html/shadow/MediaControls.h:
(WebCore::toMediaControls):
- html/shadow/SliderThumbElement.h:
(WebCore::toSliderThumbElement):
- html/shadow/TextControlInnerElements.h:
(WebCore::toInputFieldSpeechButtonElement):
- html/shadow/TextFieldDecorationElement.h:
(WebCore::toTextFieldDecorationElement):
- html/track/WebVTTElement.h:
(WebCore::toWebVTTElement):
- mathml/MathMLElement.h:
(WebCore::toMathMLElement):
- page/scrolling/ScrollingStateFixedNode.h:
(WebCore::toScrollingStateFixedNode):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::toScrollingStateScrollingNode):
- page/scrolling/ScrollingStateStickyNode.h:
(WebCore::toScrollingStateStickyNode):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/svg/SVGResources.cpp:
(WebCore::registerPendingResource):
(WebCore::SVGResources::buildCachedResources):
- svg/SVGElement.h:
(WebCore::toSVGElement):
- svg/SVGStyledElement.h:
(WebCore::toSVGStyledElement):
- 5:34 PM Changeset in webkit [141515] by
-
- 2 edits in trunk/Tools
Provide a sensible default architecture when building on iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=108395
Patch by David Farler <dfarler@apple.com> on 2013-01-31
Reviewed by Joseph Pecoraro.
- Scripts/webkitdirs.pm:
(determineArchitecture):
Check for iphoneos and iphonesimulator SDKs for a default arch.
(determineXcodeSDK): Added.
(xcodeSDK): Added.
(XcodeOptions): Add ARCHS= if defined.
- 5:32 PM Changeset in webkit [141514] by
-
- 6 edits12 adds in trunk
Fix rubber-band effect on non-scrollable pages
https://bugs.webkit.org/show_bug.cgi?id=107611
Source/WebCore:
Patch by Christopher Cameron <ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.
Handle a FrameView's wheel event even if it is not scrollable
because Chrome relies on handling these wheel events for the
over-scroll rubber-band effect.
This had been removed in r138378
[EFL][WK2] Never create WebCore scrollbars for EFL/WK2
by kenneth@chromium.org
Tests: platform/chromium/rubberbanding/wheelevent-overhang-e.html
platform/chromium/rubberbanding/wheelevent-overhang-n.html
platform/chromium/rubberbanding/wheelevent-overhang-s.html
platform/chromium/rubberbanding/wheelevent-overhang-w.html
- page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
Tools:
Add mouseWheelBegin function to EventSender to allow
event-based rubber-banding tests.
Patch by Christopher Cameron <ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::mouseDragBegin):
- DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(EventSender):
LayoutTests:
Patch by Christopher Cameron <ccameron@chromium.org> on 2013-01-31
Reviewed by Antonio Gomes.
- platform/chromium/rubberbanding/event-overhang-e-expected.png: Added.
- platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
- platform/chromium/rubberbanding/event-overhang-e.html: Added.
- platform/chromium/rubberbanding/event-overhang-n-expected.png: Added.
- platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
- platform/chromium/rubberbanding/event-overhang-n.html: Added.
- platform/chromium/rubberbanding/event-overhang-s-expected.png: Added.
- platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
- platform/chromium/rubberbanding/event-overhang-s.html: Added.
- platform/chromium/rubberbanding/event-overhang-w-expected.png: Added.
- platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.
- platform/chromium/rubberbanding/event-overhang-w.html: Added.
- 5:25 PM Changeset in webkit [141513] by
-
- 5 edits in trunk/Source
Mac: Editor::baseWritingDirectionForSelectionStart should return WritingDirection instead of NSWritingDirection.
https://bugs.webkit.org/show_bug.cgi?id=108519.
Reviewed by Sam Weinig.
Source/WebCore:
No new tests, no change in behavior.
There is no need to use AppKit types here.
baseWritingDirectionForSelectionStart now returns WritingDirection and
WebHTMLView toggleWritingDirection has been modified accordingly.
- editing/Editor.h:
- editing/mac/EditorMac.mm:
(WebCore::Editor::baseWritingDirectionForSelectionStart):
Source/WebKit/mac:
There is no need to use AppKit types here.
baseWritingDirectionForSelectionStart now returns WritingDirection and
WebHTMLView toggleWritingDirection has been modified accordingly.
- WebView/WebHTMLView.mm:
(-[WebHTMLView toggleBaseWritingDirection:]):
- 5:23 PM Changeset in webkit [141512] by
-
- 2 edits in trunk/Tools
[chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
https://bugs.webkit.org/show_bug.cgi?id=108518
Patch by James Robinson <jamesr@chromium.org> on 2013-01-31
Reviewed by Adrienne Walker.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::shutdown):
- 5:21 PM Changeset in webkit [141511] by
-
- 6 edits in trunk/Source/WebCore
[V8] Pass an Isolate to GetTemplate() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=108445
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
- 5:16 PM Changeset in webkit [141510] by
-
- 5 edits in trunk/Source/WebKit2
StorageManager should be ref-counted
https://bugs.webkit.org/show_bug.cgi?id=108553
Reviewed by Beth Dakin.
It's likely we'd want to have the storage manager outlive its context at times, so make it
reference counted.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::create):
(WebKit):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
- UIProcess/WebContext.h:
(WebContext):
- 5:12 PM Changeset in webkit [141509] by
-
- 2 edits in trunk/Source/WebCore
[V8] Clean up Dictionary::get() by removing redundant FindInstanceInPrototypeChain()
https://bugs.webkit.org/show_bug.cgi?id=108443
Reviewed by Adam Barth.
In Dictionary::get(), wrapper->FindInstanceInPrototypeChain(V8XXX::GetTemplate())
is unnecessary for DOM wrappers other than DOMWindow. For wrappers other than
DOMWindow, we can simply use V8XXX::HasInstance(wrapper).
Tests: fast/events/constructors/*
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- 5:10 PM Changeset in webkit [141508] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
https://bugs.webkit.org/show_bug.cgi?id=108380
Mark another test whose results depend on main resource caching being enabled as failing until
main resource caching can be re-enabled on mac.
- platform/mac/TestExpectations:
- 5:05 PM Changeset in webkit [141507] by
-
- 2 edits in branches/chromium/1364/Source/WebCore
Merge 141226
Scrollbar and scroll corner composited layers positioned incorrectly
https://bugs.webkit.org/show_bug.cgi?id=108255
Patch by James Robinson <jamesr@chromium.org> on 2013-01-29
Reviewed by Simon Fraser.
ScrollView::updateScrollbars() needs to update the overflow controls composited layers if scrollbars are added
or removed. It was doing this by recording on entry to the function if it had horizontal or vertical scrollbars
and then comparing that to m_horizontal/verticalScrollbar on exit. Unfortunately updateScrollbars is recursive
and exits without running the postamble code when nested on the callstack. As a result, scrollbars may be
added or removed several times during the recursion, possibly leaving the overflow control layers in an
inconsistent state, while ending up with the same set of scrollbars.
This changes the "has anything changed" logic to only compare local state (hasXXXScrollbar vs
newHasXXXScrollbar) so changes in recursive calls are not considered.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
TBR=jamesr@chromium.org
BUG=170264
Review URL: https://codereview.chromium.org/12084101
- 4:52 PM Changeset in webkit [141506] by
-
- 1 edit1 add in trunk/LayoutTests
Land failing baselines for Lion after r141333. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=108523
- platform/mac-lion/fast/canvas/canvas-composite-alpha-expected.txt: Added.
- 4:48 PM Changeset in webkit [141505] by
-
- 5 edits4 adds in trunk
[CSS Grid Layout] Support implicit rows and columns
https://bugs.webkit.org/show_bug.cgi?id=103573
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/css-grid-layout/implicit-columns-auto-resolution.html
fast/css-grid-layout/implicit-rows-auto-resolution.html
This change makes us properly initialize our GridTrack vectors's size
so that we can safely query any items during layout.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):
Added this helper function to return the track size from the grid
element's columns' / rows' definitions or the default value.
(WebCore::RenderGrid::maximumIndexInDirection):
Added this helper function to get the maximum index in a direction
taking grid item's implicit indexes into account.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Changed the funtion to not append the new tracks as we are properly
sized now.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
Updated these functions to use the new helper functions.
(WebCore::RenderGrid::layoutGridItems):
Changed this function to size both vectors when initializing them.
Also removed an unneeded bounds check as it shouldn't be needed anymore.
- rendering/RenderGrid.h:
Added the new helper functions.
- rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::GridTrackSize):
Added a constructor taking a LengthType.
LayoutTests:
- fast/css-grid-layout/implicit-columns-auto-resolution-expected.txt: Added.
- fast/css-grid-layout/implicit-columns-auto-resolution.html: Added.
- fast/css-grid-layout/implicit-rows-auto-resolution-expected.txt: Added.
- fast/css-grid-layout/implicit-rows-auto-resolution.html: Added.
- 4:37 PM Changeset in webkit [141504] by
-
- 7 edits in trunk/Source
Rolling out r141407 because it is causing crashes under
WTF::TCMalloc_Central_FreeList::FetchFromSpans() in Release builds.
Source/JavaScriptCore:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Source/WTF:
- wtf/Deque.h:
(WTF::::expandCapacity):
- wtf/FastMalloc.cpp:
- wtf/FastMalloc.h:
(WTF):
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
- 4:37 PM Changeset in webkit [141503] by
-
- 4 edits in trunk
[GTK] fast/css/relative-positioned-block-crash.html is intermittently crashing
https://bugs.webkit.org/show_bug.cgi?id=108200
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-01-31
Reviewed by Martin Robinson.
Source/WebCore:
Getting the Position of a PseudoElement now triggers an assertion.
This can occur when clicking on empty space in a render block.
Looking to the unignored parent's node (and passing that accessible
object on in a signal to Assistive Technologies) seems like the most
reasonable thing to do here.
No new tests; instead skipping two tests that were crashing as a result.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(objectFocusedAndCaretOffsetUnignored):
LayoutTests:
Unskip two crashing tests having fixed the underlying bug.
- platform/gtk/TestExpectations:
- 4:25 PM Changeset in webkit [141502] by
-
- 4 edits in trunk/Source/WebCore
[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441
Reviewed by Adam Barth.
A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
- dom/EventTarget.idl: Added [EventTarget] which should have been added.
- svg/SVGElementInstance.idl: Ditto.
- 3:59 PM Changeset in webkit [141501] by
-
- 3 edits2 moves2 deletes in trunk/LayoutTests
Rebaseline after r141459.
- fast/multicol/shrink-to-column-height-for-pagination-expected.png: Renamed from LayoutTests/platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png.
- fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Renamed from LayoutTests/platform/chromium/fast/multicol/shrink-to-column-height-for-pagination-expected.txt.
- platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
- platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Removed.
- platform/gtk/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
- platform/qt/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Removed.
- 3:51 PM Changeset in webkit [141500] by
-
- 6 edits4 adds in trunk
Source/WebCore: Quadratic and bezier curves with coincident endpoints rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=105650
Patch by Youenn Fablet <youennf@gmail.com> on 2013-01-31
Reviewed by Kenneth Russell.
Tests: fast/canvas/canvas-bezier-same-endpoint.html
fast/canvas/canvas-quadratic-same-endpoint.html
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
LayoutTests: Quadratic and bezier curves with coincident endpoints rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=105650
Modified TestExpectations for Mac, efl and Qt platforms as quadratic curves
may not be rendered correctly
(see https://bugs.webkit.org/show_bug.cgi?id=107118)
Patch by Youenn Fablet <youennf@gmail.com> on 2013-01-31
Reviewed by Kenneth Russell.
- fast/canvas/canvas-bezier-same-endpoint-expected.txt: Added.
- fast/canvas/canvas-bezier-same-endpoint.html: Added.
- fast/canvas/canvas-quadratic-same-endpoint-expected.txt: Added.
- fast/canvas/canvas-quadratic-same-endpoint.html: Added.
- platform/efl/TestExpectations: Skipped quad test
- platform/mac/TestExpectations: Skipped quad test
- platform/qt/TestExpectations: Skipped quad test
- 3:49 PM Changeset in webkit [141499] by
-
- 4 edits1 move in trunk/Source
Abstraction for hiding enum class.
https://bugs.webkit.org/show_bug.cgi?id=108533
Reviewed by Anders Carlsson.
../WebCore:
No new tests.
- Modules/webdatabase/DatabaseError.h:
(WebCore::ENUM_CLASS_BEGIN):
../WTF:
- wtf/Compiler.h:
- wtf/EnumClass.h: Copied from Source/WTF/wtf/TypeSafeEnum.h.
(WTF::EnumClass::EnumClass):
(WTF::EnumClass::operator==):
(WTF::EnumClass::operator!=):
(WTF::EnumClass::operator<):
(WTF::EnumClass::operator<=):
(WTF::EnumClass::operator>):
(WTF::EnumClass::operator>=):
- wtf/TypeSafeEnum.h: Removed.
- 3:46 PM Changeset in webkit [141498] by
-
- 4 edits in trunk/Source/WebCore
[Gtk] drag and drop has black background without composition
https://bugs.webkit.org/show_bug.cgi?id=108376
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-31
Reviewed by Martin Robinson.
Use gtk_drag_set_icon_surface (or gtk_drag_set_icon_pixbuf) when the
screen is not composited. That way, drag window will be decomposited
and rendered transparent with Xshape.
To determine which parts of the window must be transparent, gtk checks
if a pixel is more than 50% opaque. With dissolveDragImageToFraction,
all pixels are made 25% transparent. With antialiasing, opacity goes
below the threshold for some pixels, which makes the resulting image
messy. So, we need to skip dissolveDragImageToFraction when we use
gtk_drag_set_icon_surface.
- platform/gtk/DragIcon.cpp:
(WebCore::DragIcon::DragIcon):
(WebCore::DragIcon::~DragIcon):
(WebCore::DragIcon::setImage):
(WebCore::DragIcon::useForDrag):
- platform/gtk/DragIcon.h:
(DragIcon):
- platform/gtk/DragImageGtk.cpp:
(WebCore::dissolveDragImageToFraction):
- 3:43 PM Changeset in webkit [141497] by
-
- 10 edits in trunk/Source/WebKit2
WorkQueue should be a ref-counted class
https://bugs.webkit.org/show_bug.cgi?id=108544
Reviewed by Sam Weinig.
Make WorkQueue a ref-counted class that's implicitly ref()'d when dispatching a function to it, and then
implicitly deref()'d when the function is done executing. This matches the behavior of dispatch queues,
and ensures that the WorkQueue object won't go away while dispatched functions are running.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
(CoreIPC::Connection::~Connection):
(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):
(CoreIPC::Connection::invalidate):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(CoreIPC::Connection::connectionDidClose):
- Platform/CoreIPC/Connection.h:
(Connection):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createDataAvailableSource):
(CoreIPC::Connection::open):
(CoreIPC::Connection::initializeDeadNameSource):
- Platform/WorkQueue.cpp:
(WorkQueue::create):
(WorkQueue::WorkQueue):
(WorkQueue::~WorkQueue):
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/mac/WorkQueueMac.cpp:
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
- Shared/ChildProcess.cpp:
(WebKit::didCloseOnConnectionWorkQueue):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::processLauncherWorkQueue):
(WebKit::ProcessLauncher::ProcessLauncher):
- UIProcess/WebProcessProxy.cpp:
(WebKit::pluginWorkQueue):
(WebKit::WebProcessProxy::getPlugins):
- 3:38 PM Changeset in webkit [141496] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
WebViewTest.SetCompositionFromExistingText failing after r141479.
- tests/WebViewTest.cpp:
- 3:26 PM Changeset in webkit [141495] by
-
- 7 edits in trunk/Source/WebKit2
[Qt][WK2] Fix build after removal of MessageID.h
https://bugs.webkit.org/show_bug.cgi?id=108534
Reviewed by Anders Carlsson.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyIsOutOfLine):
(CoreIPC::MessageInfo::isMessageBodyIsOutOfLine):
(MessageInfo):
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):
- Target.pri:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
- UIProcess/DrawingAreaProxy.cpp:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
- WebProcess/soup/WebSoupRequestManager.cpp:
- 3:18 PM Changeset in webkit [141494] by
-
- 14 edits2 adds in trunk/Source/WebCore
Begin to make XSSAuditor thread aware
https://bugs.webkit.org/show_bug.cgi?id=108394
Reviewed by Adam Barth.
This patch moves the parts of filterToken() that depend on Frame, Document, etc. to a delegate class.
The new didBlockScript delegate method is invoked with the resulting DidBlockScriptRequest which will
be owned by the CompactHTMLToken in the threaded case.
This is just the first step as there is more to do to make XSSAuditor thread safe.
No new tests because covered by existing tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processTokensFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
- html/parser/XSSAuditorDelegate.cpp: Added.
(WebCore):
(WebCore::XSSAuditorDelegate::XSSAuditorDelegate):
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h: Added.
(WebCore):
(DidBlockScriptRequest):
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):
- html/parser/XSSAuditorDelegate.cpp: Added.
(WebCore):
(WebCore::XSSAuditorDelegate::XSSAuditorDelegate):
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h: Added.
(WebCore):
(DidBlockScriptRequest):
(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):
- 3:13 PM Changeset in webkit [141493] by
-
- 2 edits in trunk/Source/WebKit2
Assertion failure in WebResourceLoadScheduler::remove when loading .webarchives
<rdar://problem/12888145> and https://bugs.webkit.org/show_bug.cgi?id=108520
Reviewed by Alexey Proskuryakov.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Even if it isn't to be scheduled with the
NetworkProcess, still add this ResourceLoader to the scheduler's records.
- 3:12 PM Changeset in webkit [141492] by
-
- 6 edits2 adds in trunk
CSS3's vh attribute is not adjusting while browser resizes
https://bugs.webkit.org/show_bug.cgi?id=86418
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-01-31
Reviewed by Antti Koivisto.
Source/WebCore:
Elements with viewport percentage units needs layout whenever
viewport size changes. Check for viewport percentage unit
was missing for height.
Test: css3/viewport-percentage-lengths/vh-resize.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::hasViewportPercentageLogicalHeight): Check if style
is specified in viewport percentage units.
(WebCore):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout): Elements with viewport percentage units
needs relayout when viewport size changes.
LayoutTests:
Added test to check element with vh units gets resized when
viewport height is increased or decreased.
- css3/viewport-percentage-lengths/vh-resize-expected.html: Added.
- css3/viewport-percentage-lengths/vh-resize.html: Added.
- 2:56 PM Changeset in webkit [141491] by
-
- 2 edits in trunk/Tools
DumpRenderTree should put NSSound calls inside USE(APPKIT)
https://bugs.webkit.org/show_bug.cgi?id=108499
Reviewed by Andy Estes.
- DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree):
- 2:38 PM CoordinatedGraphicsSystem edited by
- (diff)
- 2:36 PM CoordinatedGraphicsSystem edited by
- (diff)
- 2:33 PM Changeset in webkit [141490] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSContext exception property causes reference cycle
https://bugs.webkit.org/show_bug.cgi?id=107778
Reviewed by Darin Adler.
JSContext has a (retain) JSValue * exception property which, when non-null, creates a
reference cycle (since the JSValue * holds a strong reference back to the JSContext *).
- API/JSContext.mm: Instead of JSValue *, we now use a plain JSValueRef, which eliminates the reference cycle.
(-[JSContext initWithVirtualMachine:]):
(-[JSContext setException:]):
(-[JSContext exception]):
- 2:31 PM Changeset in webkit [141489] by
-
- 3 edits in trunk/Source/WebCore
TextAutosizing: refactor the cluster related method parameters into a single struct.
https://bugs.webkit.org/show_bug.cgi?id=108384
This anticipates adding more cluster related information in the following patches.
Patch by Anton Vayvod <avayvod@chromium.org> on 2013-01-31
Reviewed by Kenneth Rohde Christiansen.
Just a refactoring so no new tests.
- rendering/TextAutosizer.cpp: define the new struct and pass it to every method instead of
a cluster and its descendant block containing all text.
- rendering/TextAutosizer.h: change method prototypes to receive the new struct
as a parameter defining an autosizing cluster.
- rendering/TextAutosizer.cpp:
(WebCore::TextAutosizingClusterInfo::TextAutosizingClusterInfo):
(TextAutosizingClusterInfo):
(WebCore):
(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
- rendering/TextAutosizer.h:
(WebCore):
- 2:28 PM Changeset in webkit [141488] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed trivial Unix build fix.
Use Vector<> instead of Deque<> when iterating
over m_attachments in the USE(UNIX_DOMAIN_SOCKETS)
case.
- Platform/CoreIPC/ArgumentDecoder.cpp:
- 2:23 PM Changeset in webkit [141487] by
-
- 2 edits in trunk/LayoutTests
Rebaseline after r141459.
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
- 2:17 PM Changeset in webkit [141486] by
-
- 16 edits in trunk
Add a call to the page UI client to determine if a plug-in should load
https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>
Source/WebKit2:
Reviewed by Anders Carlsson.
This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.
- UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
m_uiClient.shouldInstantiatePlugin.
- UIProcess/WebPageProxy.h:
- UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
the client function isn't defined, and call the function if it is.
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
client function.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy.
(WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
send the message to the WebPageProxy, not the WebProcessProxy.
- WebProcess/WebPage/WebPage.h:
Tools:
Add entries for the new function in the necessary structs.
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
- 2:13 PM Changeset in webkit [141485] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix. Win7 port.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- 2:12 PM Changeset in webkit [141484] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Tweak ChangeLog.
- 2:02 PM Changeset in webkit [141483] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Rework page scale factor limits initialization
https://bugs.webkit.org/show_bug.cgi?id=108446
Reviewed by James Robinson.
When loading a page with viewportEnabled, both the limits
specified by the viewport tag and the content width need to be
considered before we initialize the minimum page scale (and
pageScaleFactor itself usually to the same value). The timing has
proven tricky to get correct.
This patch simplifies the flow by computing the
limits only at the end of layouts and at no other time. In combination
with https://bugs.webkit.org/show_bug.cgi?id=107922 which sets
needsLayout() appropriately, this results in a more robust and easy
to understand sequence.
Fixes FixedLayoutInitializeAtMinimumPageScale test.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::layoutUpdated):
(WebKit::WebViewImpl::didChangeContentsSize):
- src/WebViewImpl.h:
(WebKit::WebViewImpl::setInitialPageScaleFactor):
(WebViewImpl):
- tests/WebFrameTest.cpp:
- 2:00 PM Changeset in webkit [141482] by
-
- 7 edits in trunk/Source/WebKit2
Use a Vector for IPC attachments
https://bugs.webkit.org/show_bug.cgi?id=108517
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::create):
(CoreIPC::ArgumentDecoder::ArgumentDecoder):
(CoreIPC::ArgumentDecoder::removeAttachment):
- Platform/CoreIPC/ArgumentDecoder.h:
(ArgumentDecoder):
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::create):
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/CoreIPC/MessageDecoder.h:
(MessageDecoder):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
- 1:57 PM Changeset in webkit [141481] by
-
- 7 edits in trunk/Source
[BlackBerry] Bing Images viewport causes layout "fun"
https://bugs.webkit.org/show_bug.cgi?id=108393
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson and partially reviewed by Konrad Piascik.
Source/WebCore:
PR: 277855
On bing.com image search page, JS generated styles for the divs which
contained images based on the window.screen and window.innerWidth.
Unfortunately the styles for the divs weren't good enough on our device
which resulted in three images being overlapped in the same viewport.
On our port, we calculate the screen rect base on the physical screen
pixels. However, iOS and lastest Android Chrome port already changed it
to density-independent (logical) pixels. And also to my knowledge that
some websites would generate bad styles for us as well through
@media device-width/device-height.
To be consistent and fix such kinds of issues, we should use
density-independent pixels instead of physical screen pixels. Mainly
ported from Chrome port change r139356. The patch will affect
screen.width/height, window.outerWidth/outerHeight and
@media device-width/device-height.
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore):
(WebCore::toUserSpace):
(WebCore::screenAvailableRect):
(WebCore::screenRect):
Source/WebKit/blackberry:
PR: 277855
Set applyPageScaleFactorInCompositor settting to false by default.
Scale down chrome window rect to density-independent pixels.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::applyDeviceScaleFactorInCompositor):
(BlackBerry::WebKit::WebSettings::setApplyPageScaleFactorInCompositor):
- Api/WebSettings.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::windowRect):
- 1:52 PM Changeset in webkit [141480] by
-
- 7 edits8 adds in trunk
[CSS Shaders] Parse custom filter function with the at-rule reference syntax
https://bugs.webkit.org/show_bug.cgi?id=108351
Reviewed by Dean Jackson.
Source/WebCore:
This patch implements the parsing for the new custom filter function "at-rule reference"
syntax. It does not implement the style resolution yet.
The custom function syntax has changed in the spec. Instead of including all of the custom
filter information inline, the custom function can now reference an @filter rule by name.
The custom function can still accept a list of parameters.
The syntax is defined as the following, where IDENT is the name of the @filter rule:
filter: custom(IDENT [, <param>]*)
In practice, it can look like this:
filter: custom(page-curl, direction 90, amount 0.5);
Spec: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#customident-ltparamgt
Tests: css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilterParameters):
Factor out a new function that just parses custom filter parameters. This is used by the
previous inline syntax and the new at-rule reference syntax.
(WebCore):
(WebCore::CSSParser::parseCustomFilterFunctionWithAtRuleReferenceSyntax):
This method parses the new at-rule reference syntax. When we remove the inline syntax,
we can rename this method to "parseCustomFilterFunction" and call it directly.
(WebCore::CSSParser::parseCustomFilterFunctionWithInlineSyntax):
Move the previous inline syntax parsing code into a new function.
(WebCore::CSSParser::parseCustomFilterFunction):
This method looks ahead in the CSS parser values and decides whether to parse the custom
function with the previous inline syntax or with the new at-rule reference syntax.
(WebCore::CSSParser::parseFilter):
I renamed the "parseCustomFilter" method to "parseCustomFilterFunction" to be more
explicit. Here, we update the name in the call site.
- css/CSSParser.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithAtRuleReferenceSyntax):
This is a stub method. In the future, style resolution for the at-rule reference
syntax will happen here. When we remove the inline syntax, we can rename this method
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
This method contains the previous inline syntax style resolution code.
(WebCore):
(WebCore::StyleResolver::createCustomFilterOperation):
This method decides which syntax we should use to resolve the style.
- css/StyleResolver.h:
(StyleResolver):
LayoutTests:
Add positive and negative parsing tests for the new custom function syntax.
Add a new folder "css3/filters/custom-with-at-rule-syntax". This will contain all the tests
using the new custom filters at-rule syntax. We will gradually copy tests in
"css3/filters/custom" over to "css3/filters/custom-with-at-rule-syntax" and modify them to
use the new at-rule syntax. When all of the tests have been replicated using the new syntax,
we will remove the previous syntax and the tests in "css3/filters/custom".
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid.html: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt: Added.
- css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html: Added.
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js: Added.
(testInvalidFilterRule):
- css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js: Added.
(testFilterProperty):
- css3/filters/script-tests/custom-filter-parsing-common.js:
(heading):
New function to print a heading to make groups of related parsing tests easier to see.
(shouldHaveConstructor):
New function to check the JS type of an object on JSC as well as V8. This is intended to
eventually replace shouldBeType, which works differently on V8 vs. JSC and requires us
to create Chromium-specific expectations for the custom filters parsing tests.
- 1:50 PM Changeset in webkit [141479] by
-
- 16 edits in trunk
Editor::m_compositionNode not updated on HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737
Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.
Source/WebCore:
Chromium has a bug where the IME composition did not get cancelled on JavaScript changes
to the focused editing field. Most of other WebKit ports were already doing this check
in their EditorClient::respondToChangedSelection. I took that logic and moved it to the
Editor so every port and use the same code.
An existing test editing/input/setting-input-value-cancel-ime-composition.html covers this change.
This test used to have an expectation to fail on Chromium and after this patch it will start passing.
- editing/Editor.cpp:
(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
Adding a call that can be used by any the port to cancel the composition if it's no longer valid.
(WebCore):
- editing/Editor.h:
(Editor):
Source/WebKit/chromium:
- public/WebViewClient.h:
(WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
Adding a callback to let the WebViewClient know that the composition has been cancelled.
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):
Adding a call composition if it is no longer valid.
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
Adding a call to the newly refactored method.
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):
Adding a call to the newly refactored Editor method.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):
Source/WebKit/win:
- WebView.cpp:
(WebView::updateSelectionForIME):
Adding a call to the newly refactored method.
LayoutTests:
- platform/chromium/TestExpectations: Removed fail expectation for the editing/input/setting-input-value-cancel-ime-composition.html since this patch fixes the bug https://bugs.webkit.org/show_bug.cgi?id=55560
- 1:47 PM Changeset in webkit [141478] by
-
- 2 edits in trunk/Tools
[Chromium] Unreviewed gardening.
Win build fix after http://trac.webkit.org/changeset/141471.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord):
- 1:42 PM Changeset in webkit [141477] by
-
- 8 edits in trunk/Source
Disable ENABLE_FULLSCREEN_API on iOS
https://bugs.webkit.org/show_bug.cgi?id=108250
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 1:25 PM Changeset in webkit [141476] by
-
- 2 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 141454
WebFrameTest.DisambiguationPopup is failing
https://bugs.webkit.org/show_bug.cgi?id=108160
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-01-31
Reviewed by Adam Barth.
Fix the unit test so that it is using the right HTML file.
- tests/WebFrameTest.cpp:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12087118
- 1:24 PM Changeset in webkit [141475] by
-
- 4 edits1 copy in branches/chromium/1364/Source/WebKit/chromium
Merge 141019
[Chromium, Mobile] Do not show disambiguation pop up in mobile sites
https://bugs.webkit.org/show_bug.cgi?id=107607
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-01-28
Reviewed by Adam Barth.
Add a check before showing the disambiguation popup to prevent it from appearing
on mobile sites. Makes a similar test to the current disambiguation popup test
that expects the popup to never appear.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::WebViewImpl::isLikelyMobileSite):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_mobile_site.html: Added.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit):
(WebKit::WebViewImpl::shouldDisableDesktopWorkarounds):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/disambiguation_popup_mobile_site.html: Added.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12086096
- 1:18 PM Changeset in webkit [141474] by
-
- 4 edits1 move in trunk/Source
[Chromium] Move LocalizedStrings to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108488
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 106829.
Source/WebCore:
- WebCore.gypi:
- platform/chromium/LocalizedStringsChromium.cpp: Copied from Source/WebKit/chromium/src/LocalizedStrings.cpp.
(WebCore::imageTitle):
Source/WebKit/chromium:
- WebKit.gyp:
- src/LocalizedStrings.cpp: Removed.
- 1:14 PM Changeset in webkit [141473] by
-
- 49 edits11 adds in trunk
WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
https://bugs.webkit.org/show_bug.cgi?id=108396.
<rdar://problem/12920461>
Source/WebCore:
Reviewed by Alexey Proskuryakov.
Adds support in WebCore to new EditorClient methods to support the modified
client bundle API in WebKit2.
- WebCore.exp.in:
- editing/Editor.cpp:
(WebCore::Editor::cut): Added call to willWriteSelectionToPasteboard.
(WebCore::Editor::copy): Ditto.
(WebCore::Editor::willWriteSelectionToPasteboard): Added.
- editing/Editor.h:
- loader/EmptyClients.h: Added empty client implementation
for the new methods.
(WebCore::EmptyEditorClient::willWriteSelectionToPasteboard):
(WebCore::EmptyEditorClient::getClientPasteboardDataForRange):
- page/EditorClient.h:
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelectionForTypes): Added call to getClientPasteboardDataForRange.
Source/WebKit/blackberry:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::willWriteSelectionToPasteboard):
(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):
- WebCoreSupport/EditorClientBlackBerry.h:
Source/WebKit/chromium:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::willWriteSelectionToPasteboard):
(WebKit::EditorClientImpl::getClientPasteboardDataForRange):
- src/EditorClientImpl.h:
Source/WebKit/efl:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::willWriteSelectionToPasteboard):
(WebCore::EditorClientEfl::getClientPasteboardDataForRange):
- WebCoreSupport/EditorClientEfl.h:
Source/WebKit/gtk:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::willWriteSelectionToPasteboard):
(WebKit::EditorClient::getClientPasteboardDataForRange):
- WebCoreSupport/EditorClientGtk.h:
Source/WebKit/mac:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::willWriteSelectionToPasteboard):
(WebEditorClient::getClientPasteboardDataForRange):
Source/WebKit/qt:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::willWriteSelectionToPasteboard):
(WebCore::EditorClientQt::getClientPasteboardDataForRange):
- WebCoreSupport/EditorClientQt.h:
Source/WebKit/win:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::willWriteSelectionToPasteboard):
(WebEditorClient::getClientPasteboardDataForRange):
- WebCoreSupport/WebEditorClient.h:
Source/WebKit/wince:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::willWriteSelectionToPasteboard):
(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):
- WebCoreSupport/EditorClientWinCE.h:
Source/WebKit/wx:
Reviewed by Alexey Proskuryakov.
Adds stub implementation for WebKit of the new EditorClient methods.
- WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::willWriteSelectionToPasteboard):
(WebCore::EditorClientWx::getClientPasteboardDataForRange):
- WebKitSupport/EditorClientWx.h:
Source/WebKit2:
Reviewed by Alexey Proskuryakov.
This patch adds new bundle client API to receive notifications
relative the pasteboard activity. There are 2 new API added to
InjectedBundleEditorClient, to receive notification before and
after the pasteboard content is added and one API to provide
additional content to add to the pasteboard.
In order to create content to add to the pasteboard, WKWebArchiveRef
and WKWebArchiveResourcesRef have been added to the set of API level
object.
This work is a joint effort with Sam Weinig who contributed the
support for WKWebArchiveRef, WKWebArchiveResourcesRef and related
files. Sam is the author of the first chunk of changes listed below.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/mac/WKWebArchive.cpp: Added.
(WKWebArchiveGetTypeID):
(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):
(WKWebArchiveCopyData):
- Shared/API/c/mac/WKWebArchive.h: Added.
- Shared/API/c/mac/WKWebArchiveResource.cpp: Added.
(WKWebArchiveResourceGetTypeID):
(WKWebArchiveResourceCreate):
(WKWebArchiveResourceCopyData):
(WKWebArchiveResourceCopyURL):
(WKWebArchiveResourceCopyMIMEType):
(WKWebArchiveResourceCopyTextEncoding):
- Shared/API/c/mac/WKWebArchiveResource.h: Added.
- Shared/APIObject.h:
- Shared/WebArchive.cpp: Added.
(WebKit::WebArchive::create):
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::~WebArchive):
(WebKit::WebArchive::mainResource):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
(WebKit::releaseCFData):
(WebKit::WebArchive::data):
(WebKit::WebArchive::coreLegacyWebArchive):
- Shared/WebArchive.h: Added.
(WebKit::WebArchive::type):
- Shared/WebArchiveResource.cpp: Added.
(WebKit::WebArchiveResource::create):
(WebKit::WebArchiveResource::WebArchiveResource):
(WebKit::WebArchiveResource::~WebArchiveResource):
(WebKit::releaseCFData):
(WebKit::WebArchiveResource::data):
(WebKit::WebArchiveResource::URL):
(WebKit::WebArchiveResource::MIMEType):
(WebKit::WebArchiveResource::textEncoding):
(WebKit::WebArchiveResource::coreArchiveResource):
- Shared/WebArchiveResource.h: Added.
(WebKit::WebArchiveResource::type):
- WebKit2.xcodeproj/project.pbxproj:
- Shared/APIClientTraits.cpp: Added versioning to InjectedBundlePageEditorClient.
- Shared/APIClientTraits.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::willWriteToPasteboard): Added.
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange): Added.
(WebKit::InjectedBundlePageEditorClient::didWriteToPasteboard): Added.
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didWriteSelectionToPasteboard):
(WebKit::WebEditorClient::willWriteSelectionToPasteboard):
(WebKit::WebEditorClient::getClientPasteboardDataForRange):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Tools:
Reviewed by Alexey Proskuryakov.
Adding new WebKit2 test with relevant bundle, to test the new APIs.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::setInjectedBundleClient):
- TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.
(PasteboardNotificationsTest):
(TestWebKitAPI::willWriteToPasteboard):
(TestWebKitAPI::getPasteboardDataForRange):
(TestWebKitAPI::didWriteToPasteboard):
(TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
(TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
- TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect
changes in InjectedBundleEditorClient.
(WTR::InjectedBundlePage::InjectedBundlePage):
- 1:03 PM Changeset in webkit [141472] by
-
- 25 edits2 deletes in trunk/Source/WebKit2
Remove MessageID.h
https://bugs.webkit.org/show_bug.cgi?id=108516
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC):
(Connection):
- Platform/CoreIPC/MessageID.h: Removed.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::Connection::receiveSourceEventHandler):
- Shared/CoreIPCSupport/WebConnectionMessageKinds.h: Removed.
- Shared/CoreIPCSupport/WebContextMessageKinds.h:
- UIProcess/DrawingAreaProxy.h:
(CoreIPC):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
- UIProcess/WebApplicationCacheManagerProxy.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebCookieManagerProxy.h:
- UIProcess/WebFrameProxy.h:
(CoreIPC):
- UIProcess/WebFullScreenManagerProxy.h:
(CoreIPC):
- UIProcess/WebIconDatabase.h:
(CoreIPC):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
(CoreIPC):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/FullScreen/WebFullScreenManager.h:
(CoreIPC):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/InjectedBundle/InjectedBundle.h:
(CoreIPC):
- WebProcess/WebPage/DrawingArea.h:
(CoreIPC):
- WebProcess/WebPage/LayerTreeHost.h:
(CoreIPC):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
(CoreIPC):
- WebProcess/WebPage/WebPageGroupProxy.h:
(CoreIPC):
- 12:58 PM Changeset in webkit [141471] by
-
- 5 edits in trunk
Tools: [Chromium] Add two-word misspelling to mock spellchecker
https://bugs.webkit.org/show_bug.cgi?id=108498
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.
Some layout tests verify spellcheck behavior when multiple words are
marked as a single misspelling. This change adds a two-word misspelling
'upper case' to the mock spellchecker used by layout tests.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
(MockSpellCheck::spellCheckWord): Modified to handle spaces in misspellings.
(MockSpellCheck::initializeIfNeeded): Modified to use a vector instead of a hash table.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
(MockSpellCheck): Changed misspellings container from hash table to vector.
LayoutTests: [Chromium] Expect spellcheck to work for exactly-selected multi-word misspellings
https://bugs.webkit.org/show_bug.cgi?id=108498
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-31
Reviewed by Tony Chang.
- platform/chromium/TestExpectations: Update spellcheck tests expectations.
- 12:55 PM Changeset in webkit [141470] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Make selection handling work in applyPageScaleInCompositor mode
https://bugs.webkit.org/show_bug.cgi?id=107831
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.
These functions expect a window point. When in
applyPageScaleFactorInCompositor mode, the points need to be unscaled
by the page scale factor.
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
- 12:55 PM Changeset in webkit [141469] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
https://bugs.webkit.org/show_bug.cgi?id=108380
Mark some tests whose results depend on main resource caching being enabled as failing until
main resource caching can be re-enabled on mac.
- platform/mac/TestExpectations:
- 12:52 PM Changeset in webkit [141468] by
-
- 2 edits in trunk/Source/WebCore
Use OS() and PLATFORM() macros in WebCorePrefix.h for readability
<http://webkit.org/b/108374>
Reviewed by Laszlo Gombos.
- WebCorePrefix.h: Replaced all possible checks with OS() or
PLATFORM() macros other than APPLE.
- 12:51 PM Changeset in webkit [141467] by
-
- 2 edits in trunk/Tools
[Qt] Prospective build fix.
Reviewed by Jocelyn Turcotte.
Don't create .prl files for intermediate libs as their contents get
injected within -Wl,-whole-archive -lFoo -wl,-no-whole-archive.
- qmake/mkspecs/features/default_post.prf:
- 12:48 PM Changeset in webkit [141466] by
-
- 7 edits in trunk/Source
Cleanup: Use ScriptExecutionContext::topOrigin when relevant.
https://bugs.webkit.org/show_bug.cgi?id=108476
Source/WebCore:
Reviewed by Jochen Eisinger.
Rather than diving through 'frame()->top()' or 'topDocument()' to get
the SecurityOrigin of the top-level document in a frame, we can now
directly grab the 'topOrigin()' off of a ScriptExecutionContext. This
patch adjusts a few callsites to use the new hotness rather than the
old brokenness.
This is a pure refactoring: No web-visible changes should result.
- Modules/webdatabase/DOMWindowWebDatabase.cpp:
(WebCore::DOMWindowWebDatabase::openDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
Source/WebKit2:
Reviewed by Anders Carlsson.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::storageBlockingStateChanged):
(WebKit::PluginView::isPrivateBrowsingEnabled):
- 12:47 PM Changeset in webkit [141465] by
-
- 3 edits in trunk/Source/WebKit2
Get rid of IncomingMessage
https://bugs.webkit.org/show_bug.cgi?id=108514
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(Connection::SyncMessageState):
(ConnectionAndIncomingMessage):
(CoreIPC::Connection::SyncMessageState::~SyncMessageState):
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):
(CoreIPC::Connection::dispatchOneMessage):
- Platform/CoreIPC/Connection.h:
(Connection):
- 12:44 PM Changeset in webkit [141464] by
-
- 2 edits in trunk/Source/WebCore
[Curl] There is no way for a WebKit client to set the Curl cookie jar path
https://bugs.webkit.org/show_bug.cgi?id=107692
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-01-31
Reviewed by Brent Fulgham.
Set default cookie jar path.
Get the cookie jar path for Curl from the environment variable CURL_COOKIE_JAR_PATH.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::cookieJarPath): Added helper function to set cookie jar path.
(WebCore::ResourceHandleManager::ResourceHandleManager): Call helper function.
- 12:41 PM Changeset in webkit [141463] by
-
- 2 edits in trunk/Source/WebKit2
Remove PLATFORM(WIN_CAIRO) from NetscapePluginX11.cpp
https://bugs.webkit.org/show_bug.cgi?id=108439
Reviewed by Brent Fulgham.
PLATFORM(WIN_CAIRO) is Windows only, where no X11 exists.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
- 12:38 PM Changeset in webkit [141462] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r138962): Fails to show "confirm form resubmission", hangs browser
https://bugs.webkit.org/show_bug.cgi?id=108214
Reviewed by Adam Barth.
Attempt a workaround suggested by Nate Chapin by putting some code
in #ifdef !PLATFORM(CHROMIUM).
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::notifyFinished):
- 12:24 PM Changeset in webkit [141461] by
-
- 2 edits in trunk/Source/WebKit/chromium
[v8] Enable binding integrity on mac
https://bugs.webkit.org/show_bug.cgi?id=108500
Reviewed by Adam Barth.
Patch is correct if existing tests pass without new crashes.
- features.gypi:
Set ENABLE_BINDING_INTEGRITY=1 when OS=="mac"
- 12:02 PM Changeset in webkit [141460] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Merge 141009
Crash inside RenderBlock::layoutRunsAndFloatsInRange in the widow code
https://bugs.webkit.org/show_bug.cgi?id=108084
Reviewed by Dean Jackson.
This is a blind fix based on the code and Chromium's stack-traces.
Unfortunately no new test as I couldn't get a local reproduction.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
Added a missing NULL-check: the previous 'while' finish if |lineBox|
is NULL and we don't want to crash in this case.
TBR=jchaffraix@webkit.org
Review URL: https://codereview.chromium.org/12084093
- 12:00 PM Changeset in webkit [141459] by
-
- 7 edits6 adds in trunk
REGRESSION(r128517): Percentage heights in quirks mode collapse when printing
https://bugs.webkit.org/show_bug.cgi?id=108382
Reviewed by David Hyatt.
Source/WebCore:
r128517 clean up our containing block finding logic, but broke percentage
heights in quirks mode during printing since the RenderView would have 0 height.
Turns out we already had a long-standing bug where we'd incorrectly
treat collapse percentage heights on the body when printing as well.
Fix both bugs by changing the way we grab the logical height on the RenderView.
RenderView::computeLogicalHeight returns 0 when printing. For the purposes of
stretching and percentage heights, we instead need to return the pageLogicalHeight.
Tests: printing/quirks-percentage-height-body.html
printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
This FIXME is outdated and already fixed. Also, call viewLogicalHeightForPercentages
which does the same logic except also correctly handles column RenderViews.
(WebCore::RenderBox::viewLogicalHeightForPercentages):
(WebCore::RenderBox::computePercentageLogicalHeight):
- rendering/RenderBox.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::viewLogicalHeightForPercentages):
(WebCore):
(WebCore::RenderBox::computePercentageLogicalHeight):
- rendering/RenderBox.h:
(RenderBox):
LayoutTests:
- platform/chromium/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
We're just clipping more content that you can't scroll to anyways. This looks
like an improvement to me.
- printing/css2.1/page-break-inside-000-expected.txt:
We pass this test now!
- printing/quirks-percentage-height-body-expected.html: Added.
- printing/quirks-percentage-height-body.html: Added.
- printing/quirks-percentage-height-expected.html: Added.
- printing/quirks-percentage-height.html: Added.
- printing/standards-percentage-heights-expected.html: Added.
- printing/standards-percentage-heights.html: Added.
- 11:56 AM Changeset in webkit [141458] by
-
- 2 edits in trunk/LayoutTests
inspector/editor/text-editor-ctrl-movements.html was renamed to
inspector/editor/text-editor-word-jumps.html in r141399. Update the TestExpectations file.
- platform/mac/TestExpectations:
- 11:56 AM Changeset in webkit [141457] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (clipRectsContext.respectOverflowClip == RespectOverflowClip) in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=108257
- platform/mac/TestExpectations:
Mark the tests as "crashing" in debug.
- 11:46 AM Changeset in webkit [141456] by
-
- 14 edits3 adds in trunk
[canvas] Implement currentPath to get and set the current path of the context
https://bugs.webkit.org/show_bug.cgi?id=108246
Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.
Source/WebCore:
Add currentPath attribute to CanvasRenderingContext2d interface. This allows
setting the current context path by an existing Path object as well as getting
the current context path as new Path object. The returned and the set Paths
are not live.
This feature is behind the CANVAS_PATH compiler flag which is disabled by
default for now.
Test: fast/canvas/canvas-currentPath.html
- html/canvas/CanvasPathMethods.cpp: Rename transformIsInvertible to
isTransformInvertible for harmonizing naming schema.
(WebCore::CanvasPathMethods::moveTo): Ditto.
(WebCore::CanvasPathMethods::lineTo): Ditto.
(WebCore::CanvasPathMethods::quadraticCurveTo): Ditto.
(WebCore::CanvasPathMethods::bezierCurveTo): Ditto.
(WebCore::CanvasPathMethods::arcTo): Ditto.
(WebCore::CanvasPathMethods::arc): Ditto.
(WebCore::CanvasPathMethods::rect): Ditto.
- html/canvas/CanvasPathMethods.h: Ditto.
(CanvasPathMethods):
(WebCore::CanvasPathMethods::isTransformInvertible):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore):
(WebCore::CanvasRenderingContext2D::currentPath): Getter for currentPath.
(WebCore::CanvasRenderingContext2D::setCurrentPath): Setter for currentPath.
- html/canvas/CanvasRenderingContext2D.h:
(WebCore):
(CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::isTransformInvertible):
- html/canvas/CanvasRenderingContext2D.idl: Add currentPath attribute.
- html/canvas/DOMPath.h: Add new constructor and getter for Path object.
(WebCore::DOMPath::create): New static function for new ctor.
(DOMPath):
(WebCore::DOMPath::path): Getter for Path object.
(WebCore::DOMPath::DOMPath):
LayoutTests:
Added tests for canvas.currentPath in various combinations of the context state.
- fast/canvas/canvas-currentPath-expected.txt: Added.
- fast/canvas/canvas-currentPath.html: Added.
- fast/canvas/script-tests/canvas-currentPath.js: Added.
(testPointCollection):
- platform/chromium/TestExpectations: Skip test until enabling CANVAS_PATH.
- platform/efl/TestExpectations: Ditto.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- 11:42 AM Changeset in webkit [141455] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix: Remove Web Intents files from
the Qt build system.
- Target.pri:
- 11:40 AM Changeset in webkit [141454] by
-
- 2 edits in trunk/Source/WebKit/chromium
WebFrameTest.DisambiguationPopup is failing
https://bugs.webkit.org/show_bug.cgi?id=108160
Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-01-31
Reviewed by Adam Barth.
Fix the unit test so that it is using the right HTML file.
- tests/WebFrameTest.cpp:
- 11:37 AM Changeset in webkit [141453] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] webkit_unit_tests should depend on base/allocator for ASAN
https://bugs.webkit.org/show_bug.cgi?id=108497
Reviewed by James Robinson.
- WebKitUnitTests.gyp:
- 11:35 AM Changeset in webkit [141452] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix.
Removing build targets for Web Intents files that were removed in r141448.
- GNUmakefile.list.am:
- 11:34 AM Changeset in webkit [141451] by
-
- 7 edits2 copies in trunk/Tools
EWS graphs have unusual data for patch waiting times
https://bugs.webkit.org/show_bug.cgi?id=108427
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-31
Reviewed by Eric Seidel.
The max_patches_waiting QueueLog property may have missed recording patches waiting in idle times when no events are fired to update it. I added a cron job to take care of this issue.
The patch wait duration in PatchLogs was being incorrectly updated after a patch expired and was picked up again from the queue. That period should really count towards the processing time instead.
Added a WarningLog to record if any erroneous situations occur due to invalid contents in the datastore. These basically highlight if any "impossible" execution paths get executed.
- QueueStatusServer/app.yaml:
- QueueStatusServer/cron.yaml:
- QueueStatusServer/handlers/syncqueuelogs.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
(SyncQueueLogs):
(SyncQueueLogs.get):
- QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.added):
(RecordPatchEvent.retrying):
(RecordPatchEvent.started):
(RecordPatchEvent.stopped):
(RecordPatchEvent.updated):
- QueueStatusServer/main.py:
- QueueStatusServer/model/patchlog.py:
(PatchLog.lookup):
(PatchLog):
(PatchLog.lookup_if_exists):
(PatchLog.calculate_process_duration):
(PatchLog._generate_key):
- QueueStatusServer/model/queuelog.py:
(QueueLog.update_max_patches_waiting):
(QueueLog._get_or_create_txn):
(QueueLog):
(QueueLog._get_patches_waiting):
- QueueStatusServer/model/warninglog.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
(WarningLog):
(WarningLog.record):
- 11:25 AM Changeset in webkit [141450] by
-
- 5 edits in trunk/Source
Call FrameView::contentsResized() when setting fixed layout size
https://bugs.webkit.org/show_bug.cgi?id=107922
Reviewed by James Robinson.
In fixed layout mode, we should be calling contentsResized() when the
fixed layout size is changed, but not laying out when the visible
content rect changes.
Previously landed as r140869 but was reverted due to a bug in bundled
Chromium-specific code. This patch includes just the minimum needed in
WebCore.
New WebFrameTest: FrameViewNeedsLayoutOnFixedLayoutResize. Some
flaky and obsolete tests for the old page scale mode are also deleted.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::visibleContentsResized):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFixedLayoutSize):
(WebCore::ScrollView::setUseFixedLayout):
Source/WebKit/chromium:
- tests/WebFrameTest.cpp:
- 11:16 AM Changeset in webkit [141449] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed, update expectation after the order of elements was codified.
https://bugs.webkit.org/show_bug.cgi?id=98686
Also delete the Qt result since this test is skipped on Qt.
- editing/pasteboard/data-transfer-items-expected.txt:
- platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Removed.
- 11:11 AM Changeset in webkit [141448] by
-
- 35 edits20 deletes in trunk
Remove Web Intents code from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=108506
Reviewed by Simon Fraser.
Source/WebKit2:
Since nobody builds with Web Intents enabled anymore, and since the code is going to
be removed from WebCore, remove it from WebKit2.
- Shared/API/c/WKBase.h:
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIObject.h:
- Shared/IntentData.cpp: Removed.
- Shared/IntentData.h: Removed.
- Shared/IntentServiceInfo.cpp: Removed.
- Shared/IntentServiceInfo.h: Removed.
- Shared/WebIntentServiceInfo.cpp: Removed.
- Shared/WebIntentServiceInfo.h: Removed.
- UIProcess/API/C/WKAPICast.h:
(WebKit):
- UIProcess/API/C/WKIntentData.cpp: Removed.
- UIProcess/API/C/WKIntentData.h: Removed.
- UIProcess/API/C/WKIntentServiceInfo.cpp: Removed.
- UIProcess/API/C/WKIntentServiceInfo.h: Removed.
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPage.h:
- UIProcess/WebIntentData.cpp: Removed.
- UIProcess/WebIntentData.h: Removed.
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebLoaderClient.h:
(WebKit):
(WebLoaderClient):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
(WebKit):
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessProxy.cpp:
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(WebKit):
- WebProcess/InjectedBundle/API/c/WKBundleIntent.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleIntent.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.cpp: Removed.
- WebProcess/InjectedBundle/API/c/WKBundleIntentRequest.h: Removed.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundleIntent.cpp: Removed.
- WebProcess/InjectedBundle/InjectedBundleIntent.h: Removed.
- WebProcess/InjectedBundle/InjectedBundleIntentRequest.cpp: Removed.
- WebProcess/InjectedBundle/InjectedBundleIntentRequest.h: Removed.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(WebKit):
(InjectedBundlePageLoaderClient):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebFrame.h:
(WebCore):
(WebKit):
(WebFrame):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
(WebCore):
(WebKit):
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
(WebCore):
(WebProcess):
- WebProcess/WebProcess.messages.in:
Tools:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
- 11:06 AM Changeset in webkit [141447] by
-
- 4 edits in trunk/Source
Lack of a log level string should not obliterate compiled in logging channel state.
https://bugs.webkit.org/show_bug.cgi?id=108502
Reviewed by Alexey Proskuryakov and Sam Weinig.
Source/WebKit/mac:
- Misc/WebKitLogging.m: If there's no log level string, leave the channel state alone.
Source/WebKit2:
- Platform/mac/Logging.mac.mm:
(WebKit::initializeLogChannel): If there's no log level string, leave the channel state alone.
- 11:06 AM Changeset in webkit [141446] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] CookieParser should ignore invalid/unsupported attributes instead of ignoring the cookie
https://bugs.webkit.org/show_bug.cgi?id=108494
PR 287832
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-31
Reviewed by Rob Buis.
Internally Reviewed by Liam Quinn.
A short-term fix for CookieParser to not blow up when a Set-Cookie header has an invalid
or unsupported cookie attribute.
We will ignore the attribute only, not the entire cookie.
Also, making sure the parser won't replace values of valid attributes when evaluating an unsupported
cookie with the same length and same first character as a supported attribute.
Tested using opera cookie and browser.swlab.rim.net cookies test suite. Tested using regular sites that
has a login mechanism.
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
- 11:05 AM Changeset in webkit [141445] by
-
- 2 edits in trunk/Source/WebKit2
WebProcess sandbox profile overhaul.
Reviewed by Sam Weinig.
Moves some rules together by susbystem for easier maintenance.
Addresses <rdar://problem/9276393>, <rdar://problem/10844321>, <rdar://problem/12408537>,
<rdar://problem/12558524>.
- WebProcess/com.apple.WebProcess.sb.in:
- 11:01 AM Changeset in webkit [141444] by
-
- 27 edits1 copy3 adds2 deletes in trunk
[chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=108458
Source/Platform:
Only renames, no other code changes.
Reviewed by Adam Barth.
- Platform.gypi:
- chromium/public/WebMediaStream.h: Copied from Source/Platform/chromium/public/WebMediaStreamDescriptor.h.
(WebCore):
(WebKit):
(WebMediaStream):
(ExtraData):
(WebKit::WebMediaStream::ExtraData::~ExtraData):
(WebKit::WebMediaStream::WebMediaStream):
(WebKit::WebMediaStream::~WebMediaStream):
(WebKit::WebMediaStream::operator=):
(WebKit::WebMediaStream::isNull):
- chromium/public/WebMediaStreamCenter.h:
(WebKit):
(WebMediaStreamCenter):
(WebKit::WebMediaStreamCenter::didAddMediaStreamTrack):
(WebKit::WebMediaStreamCenter::didRemoveMediaStreamTrack):
- chromium/public/WebMediaStreamCenterClient.h:
(WebKit):
(WebMediaStreamCenterClient):
- chromium/public/WebMediaStreamComponent.h:
- chromium/public/WebMediaStreamDescriptor.h:
- chromium/public/WebMediaStreamTrack.h: Added.
(WebCore):
(WebKit):
(WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::~WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator=):
(WebKit::WebMediaStreamTrack::isNull):
- chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):
- chromium/public/WebRTCStatsRequest.h:
(WebKit):
(WebRTCStatsRequest):
Source/WebCore:
Reviewed by Adam Barth.
Only renames, no other code changes.
- WebCore.gypi:
- platform/chromium/support/WebMediaStream.cpp: Added.
(WebKit::WebMediaStream::WebMediaStream):
(WebKit):
(WebKit::WebMediaStream::reset):
(WebKit::WebMediaStream::label):
(WebKit::WebMediaStream::id):
(WebKit::WebMediaStream::extraData):
(WebKit::WebMediaStream::setExtraData):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):
(WebKit::WebMediaStream::operator=):
(WebKit::WebMediaStream::operator PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStream::operator WebCore::MediaStreamDescriptor*):
(WebKit::WebMediaStream::initialize):
(WebKit::WebMediaStream::assign):
- platform/chromium/support/WebMediaStreamComponent.cpp: Removed.
- platform/chromium/support/WebMediaStreamDescriptor.cpp: Removed.
- platform/chromium/support/WebMediaStreamTrack.cpp: Added.
(WebKit):
(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit::WebMediaStreamTrack::operator=):
(WebKit::WebMediaStreamTrack::initialize):
(WebKit::WebMediaStreamTrack::reset):
(WebKit::WebMediaStreamTrack::operator PassRefPtr<MediaStreamComponent>):
(WebKit::WebMediaStreamTrack::operator MediaStreamComponent*):
(WebKit::WebMediaStreamTrack::isEnabled):
(WebKit::WebMediaStreamTrack::id):
(WebKit::WebMediaStreamTrack::stream):
(WebKit::WebMediaStreamTrack::source):
(WebKit::WebMediaStreamTrack::assign):
- platform/chromium/support/WebRTCStatsRequest.cpp:
(WebKit::WebRTCStatsRequest::stream):
(WebKit::WebRTCStatsRequest::component):
- platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didCreateMediaStream):
(WebCore::MediaStreamCenterChromium::stopLocalMediaStream):
(WebCore::MediaStreamCenterChromium::addMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::removeMediaStreamTrack):
- platform/mediastream/chromium/MediaStreamCenterChromium.h:
(WebKit):
(MediaStreamCenterChromium):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteStream):
(WebCore::RTCPeerConnectionHandlerChromium::didRemoveRemoteStream):
- platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):
Source/WebKit/chromium:
Reviewed by Adam Barth.
Only renames, no other code changes.
- public/WebMediaStreamRegistry.h:
(WebKit):
(WebMediaStreamRegistry):
- public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
- src/WebMediaStreamRegistry.cpp:
(WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):
- src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::requestSucceeded):
Tools:
Reviewed by Adam Barth.
Only renames, no other code changes.
- DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
(MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(MockWebMediaStreamCenter::didAddMediaStreamTrack):
(MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
(MockWebMediaStreamCenter::didStopLocalMediaStream):
(MockWebMediaStreamCenter::didCreateMediaStream):
- DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
(MockWebMediaStreamCenter):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::addStream):
(MockWebRTCPeerConnectionHandler::removeStream):
(MockWebRTCPeerConnectionHandler::getStats):
- DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):
- DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(UserMediaRequestTask::UserMediaRequestTask):
(WebUserMediaClientMock::requestUserMedia):
- 10:54 AM Changeset in webkit [141443] by
-
- 4 edits in trunk/Source/JavaScriptCore
Objective-C API: Fix insertion of values greater than the max index allowed by the spec
https://bugs.webkit.org/show_bug.cgi?id=108264
Reviewed by Oliver Hunt.
Fixed a bug, added a test to the API tests, cleaned up some code.
- API/JSValue.h: Changed some of the documentation on setValue:atIndex: to indicate that
setting values at indices greater than UINT_MAX - 1 wont' affect the length of JS arrays.
- API/JSValue.mm:
(-[JSValue valueAtIndex:]): We weren't returning when we should have been.
(-[JSValue setValue:atIndex:]): Added a comment about why we do the early check for being larger than UINT_MAX.
(objectToValueWithoutCopy): Removed two redundant cases that were already checked previously.
- API/tests/testapi.mm:
- 10:54 AM Changeset in webkit [141442] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed trivial build fix: Pre C++11 the use of
in nested templates is ambiguous in the grammar and
requires the insertion of a space here. Since these files are
not Mac specific we don't require C++11 yet and a space
fixes the build.
- Platform/CoreIPC/Connection.h:
(Connection):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
- 10:50 AM Changeset in webkit [141441] by
-
- 2 edits in trunk/Tools
REGRESSION (r141402): incorrectly set injected bundle path when running GTK unit tests
https://bugs.webkit.org/show_bug.cgi?id=108496
Reviewed by Philippe Normand.
- Scripts/run-gtk-tests:
(TestRunner.init): Add the build type as a member on the TestRunner interface.
(TestRunner._setup_testing_environment): Use the build type member to determine correct path
to the injected bundle.
- 10:46 AM Changeset in webkit [141440] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 10:43 AM Changeset in webkit [141439] by
-
- 29 edits14 deletes in trunk
[EFL] Disable Web Intents
https://bugs.webkit.org/show_bug.cgi?id=108457
Patch by Christophe Dumez <dchris@gmail.com> on 2013-01-31
Reviewed by Alexey Proskuryakov.
.:
Turn off WEB_INTENTS flag in EFL CMake project.
- Source/cmake/OptionsEfl.cmake:
Source/WebKit:
Remove intents files from EFL CMake project.
- PlatformEfl.cmake:
Source/WebKit/efl:
Remove code related to Web Intents from EFL
WebKit.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
- ewk/EWebKit.h:
- ewk/ewk_frame.cpp:
- ewk/ewk_frame.h:
- ewk/ewk_frame_private.h:
- ewk/ewk_intent.cpp: Removed.
- ewk/ewk_intent.h: Removed.
- ewk/ewk_intent_private.h: Removed.
- ewk/ewk_intent_request.cpp: Removed.
- ewk/ewk_intent_request.h: Removed.
Source/WebKit2:
Remove code related to Web Intents from EFL
WebKit2.
- CMakeLists.txt:
- PlatformEfl.cmake:
- UIProcess/API/efl/EWebKit2.h:
- UIProcess/API/efl/EwkViewCallbacks.h:
- UIProcess/API/efl/ewk_intent.cpp: Removed.
- UIProcess/API/efl/ewk_intent.h: Removed.
- UIProcess/API/efl/ewk_intent_private.h: Removed.
- UIProcess/API/efl/ewk_intent_service.cpp: Removed.
- UIProcess/API/efl/ewk_intent_service.h: Removed.
- UIProcess/API/efl/ewk_intent_service_private.h: Removed.
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/resources/intent-request.html: Removed.
- UIProcess/API/efl/tests/resources/intent-service.html: Removed.
- UIProcess/API/efl/tests/test_ewk2_intents.cpp: Removed.
- UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::PageLoadClientEfl):
- UIProcess/efl/PageLoadClientEfl.h:
(PageLoadClientEfl):
Tools:
Remove EFL DRT code related to Web intents.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onFrameCreated):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::sendWebIntentResponse):
(TestRunner::deliverWebIntent):
- Scripts/webkitperl/FeatureList.pm: Turn off WEB_INTENTS flag
for EFL port.
LayoutTests:
Skip webintents/ test cases for EFL port now that
the feature is disabled.
- platform/efl/TestExpectations:
- 10:39 AM Changeset in webkit [141438] by
-
- 5 edits in trunk/Source/WebKit/chromium
IndexedDB: Remove WebKit API for old onSuccess/onUpgradeNeeded
https://bugs.webkit.org/show_bug.cgi?id=108399
Reviewed by Dimitri Glazkov.
Cleanup now that chromium proxies the new signatures through.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- 10:38 AM Changeset in webkit [141437] by
-
- 118 edits1 delete in trunk/LayoutTests
[chromium] Unreviewed, land baselines with textarea resizer enabled.
https://bugs.webkit.org/show_bug.cgi?id=108383
- platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png: Removed.
- platform/chromium-mac-lion/editing/inserting/4960120-1-expected.png:
- platform/chromium-mac-lion/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-mac-lion/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac-lion/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-mac-lion/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac-lion/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/chromium-mac-lion/fast/forms/negativeLineHeight-expected.png:
- platform/chromium-mac-lion/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-lion/fast/forms/textAreaLineHeight-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-align-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-scroll-height-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-setinnerhtml-expected.png:
- platform/chromium-mac-lion/fast/forms/textarea-width-expected.png:
- platform/chromium-mac-lion/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-mac-lion/fast/parser/entity-comment-in-textarea-expected.png:
- platform/chromium-mac-lion/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-mac-lion/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-mac-lion/fast/table/003-expected.png:
- platform/chromium-mac-lion/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/chromium-mac-lion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug194024-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug30559-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium-mac-snowleopard/editing/inserting/4960120-1-expected.png:
- platform/chromium-mac-snowleopard/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/negativeLineHeight-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textAreaLineHeight-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-align-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-scroll-height-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/textarea-width-expected.png:
- platform/chromium-mac-snowleopard/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/entity-comment-in-textarea-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-mac-snowleopard/fast/table/003-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug194024-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30559-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium-mac/editing/inserting/4960120-1-expected.png:
- platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-mac/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-mac/fast/forms/form-element-geometry-expected.png:
- platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/chromium-mac/fast/forms/negativeLineHeight-expected.png:
- platform/chromium-mac/fast/forms/placeholder-position-expected.png:
- platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png:
- platform/chromium-mac/fast/forms/textarea-align-expected.png:
- platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png:
- platform/chromium-mac/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-mac/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-mac/fast/forms/textarea-setinnerhtml-expected.png:
- platform/chromium-mac/fast/forms/textarea-width-expected.png:
- platform/chromium-mac/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-mac/fast/parser/entity-comment-in-textarea-expected.png:
- platform/chromium-mac/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-mac/fast/repaint/textarea-set-disabled-expected.png:
- platform/chromium-mac/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-mac/fast/table/003-expected.png:
- platform/chromium-mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug194024-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium-win/editing/inserting/4960120-1-expected.png:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png:
- platform/chromium-win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-win/fast/forms/basic-textareas-expected.png:
- platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-win/fast/forms/form-element-geometry-expected.png:
- platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/chromium-win/fast/forms/negativeLineHeight-expected.png:
- platform/chromium-win/fast/forms/placeholder-position-expected.png:
- platform/chromium-win/fast/forms/textAreaLineHeight-expected.png:
- platform/chromium-win/fast/forms/textarea-align-expected.png:
- platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-win/fast/forms/textarea-scroll-height-expected.png:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-win/fast/forms/textarea-setinnerhtml-expected.png:
- platform/chromium-win/fast/forms/textarea-width-expected.png:
- platform/chromium-win/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-win/fast/parser/entity-comment-in-textarea-expected.png:
- platform/chromium-win/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-win/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-win/fast/table/003-expected.png:
- platform/chromium-win/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/chromium-win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug194024-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium/TestExpectations:
- 10:34 AM Changeset in webkit [141436] by
-
- 5 edits in trunk
Web Inspector: searching for <u> in elements panel finds all tags containing "u"
https://bugs.webkit.org/show_bug.cgi?id=108176
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
When searching for tag name check that tag name must either start from
search query, or must end with it.
Source/WebCore:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
LayoutTests:
- inspector/elements/elements-panel-search-expected.txt:
- inspector/elements/elements-panel-search.html:
- 10:32 AM Changeset in webkit [141435] by
-
- 2 edits in trunk/Tools
[Qt] Disable force_static_libs_as_shared in developer builds if wk2 is enabled
Reviewed by Jocelyn Turcotte.
This is a temporary workaround during the development of #108471, where we move files around
but some link time dependencies might remain.
- qmake/mkspecs/features/default_post.prf:
- 10:24 AM Changeset in webkit [141434] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a flaky crasher expectation for fast/css-generated-content/block-and-box-hit-testing.html.
Removing failure expectations for SVGViewSpec tests.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 10:22 AM Changeset in webkit [141433] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/12695827> PPT: Make loading file URLs work with a sandboxed NetworkProcess
Address review comments.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:18 AM Changeset in webkit [141432] by
-
- 5 edits in trunk/Source/WebKit2
Stop using OutgoingMessage
https://bugs.webkit.org/show_bug.cgi?id=108495
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendOutgoingMessages):
- Platform/CoreIPC/Connection.h:
(Connection):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::~ChildProcessProxy):
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
- 10:12 AM Changeset in webkit [141431] by
-
- 4 edits in trunk/Source/WebCore
DatabaseContext needs to outlive the ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=108355.
Reviewed by Geoffrey Garen.
Added a RefPtr<DatabaseContext> in ScriptExecutionContext to keep the
DatabaseContext alive until after ScriptExecutionContext destructs.
No new tests.
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::setDatabaseContext):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
- 10:04 AM Changeset in webkit [141430] by
-
- 8 edits1 copy1 add in trunk
[Qt] Make it possible to compile WebKit2 Qt related files without access to internal WK2 C++ API
https://bugs.webkit.org/show_bug.cgi?id=108472
Reviewed by Andreas Kling.
.:
When linking WebKit2, also link the WebKit2QML module.
- Source/api.pri:
Source/WebKit2:
Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
that doesn't depend on WebKit2 internals.
Changed qwebnavigationhistory.cpp to not use any internal headers and compile it as part of the
internals-free module.
- Target.pri:
- UIProcess/API/qt/qwebnavigationhistory.cpp:
- WebKit2.pro:
- WebKit2QML.pri: Added.
Tools:
Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
that doesn't depend on WebKit2 internals.
- qmake/mkspecs/features/webkit_modules.prf:
- qmake/mkspecs/modules/webkit2qml.prf: Copied from Source/WebKit2/WebKit2.pro.
- 9:59 AM Changeset in webkit [141429] by
-
- 2 edits in trunk/Source/WebCore
On Linux, can't get spelling suggestions without selection when unified text checker is enabled
https://bugs.webkit.org/show_bug.cgi?id=107684
Reviewed by Ryosuke Niwa.
No new tests, covered by context-menu-suggestions.html.
- editing/Editor.cpp:
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
For Linux, extend selection range to the closest word to get
the spelling suggestions when unified text checker is enabled.
- 9:44 AM Changeset in webkit [141428] by
-
- 7 edits in trunk
[chromium] Remove dead transitional code from WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=107889
Patch by James Robinson <jamesr@chromium.org> on 2013-01-31
Reviewed by Adam Barth.
Source/WebKit/chromium:
The chromium side of this landed at r178256 and seems stable.
- public/WebWidget.h:
(WebKit::WebWidget::setCompositorSurfaceReady):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
(FakeWebViewClient):
(WebKit::FakeWebViewClient::layerTreeView):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(ScrollingCoordinatorChromiumTest):
Tools:
ScrollingCoordinatorChromiumTests need to initialize compositing, so its implementation of
WebWidgetClient has to support the new compositor initialization path.
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWebWidget):
- 9:36 AM Changeset in webkit [141427] by
-
- 2 edits in trunk/Source/WebCore
[Skia] Update SkiaImageFilterBuilder's brightness matrix to match Chromium's implementation
https://bugs.webkit.org/show_bug.cgi?id=107841
Reviewed by Stephen White.
Update Skia's brightness filter to match the spec after http://trac.webkit.org/changeset/139770.
No new tests: covered by existing tests (currently disabled pending rebaseline).
- platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
- 9:17 AM Changeset in webkit [141426] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: show cursor location in DTE
https://bugs.webkit.org/show_bug.cgi?id=108478
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
Add a new status bar element to SourceFrame to display current
DefaultTextEditor cursor position.
No new tests.
- English.lproj/localizedStrings.js:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.copyRange):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.statusBarItems):
(WebInspector.SourceFrame.prototype.selectionChanged):
(WebInspector.SourceFrame.prototype._updateSourcePosition):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.copyRange):
- inspector/front-end/inspector.css:
(.source-frame-position):
- 8:45 AM Changeset in webkit [141425] by
-
- 2 edits in trunk/LayoutTests
WebKitTestRunner needs an implementation of eventSender.beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=64285
- platform/wk2/TestExpectations:
Skip another test that uses eventSender.beginDragWithFiles.
- 8:33 AM Changeset in webkit [141424] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: overlay highlight in DTE gets messed up when zoom factor changes.
https://bugs.webkit.org/show_bug.cgi?id=108486
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
Repaint overlay highlight when zoom factor changes.
No new tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeHighlight):
(WebInspector.TextEditorMainPanel.prototype.highlightRange):
(WebInspector.TextEditorMainPanel.prototype._repaintLineRowsAffectedByHighlightDescriptors):
(WebInspector.TextEditorMainPanel.prototype.resize):
- 8:13 AM Changeset in webkit [141423] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a failing test after r141269.
https://bugs.webkit.org/show_bug.cgi?id=108481.
Renamed inspector/editor/text-editor-ctrl-movements.html after r141399.
- platform/qt/TestExpectations:
- 7:48 AM PortIntegrationArchitectureIssues edited by
- (diff)
- 7:40 AM PortIntegrationArchitectureIssues created by
- 7:16 AM Changeset in webkit [141422] by
-
- 1 copy in tags/Safari-537.29
New Tag.
- 7:16 AM Changeset in webkit [141421] by
-
- 1 delete in tags/Safari-537.29
Remove Tag.
- 7:07 AM Changeset in webkit [141420] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix minor memory leak in slot execution
Reviewed by Allan Sandfeld Jensen.
Don't leak the "length" string when executing a slot in JavaScript.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtConnectionObject::execute):
- 6:59 AM Changeset in webkit [141419] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed trivial build fix: Add missing virtual destructor to
LayerTreeRendererClient. Otherwise the build with -Werror breaks, which
complains (rightly so) that we're deleting a sub-class where the super class
doesn't have a virtual destructor.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit::LayerTreeRendererClient::~LayerTreeRendererClient):
- 6:57 AM Changeset in webkit [141418] by
-
- 13 edits12 adds in trunk
Allow blocking of IndexedDB in third-party contexts
https://bugs.webkit.org/show_bug.cgi?id=94171
Reviewed by Jochen Eisinger.
Source/WebCore:
This patch ensures that the origin of the top window is passed into
SecurityOrigin::canAccessDatabase when working with IndexedDB. Giving
SecurityOrigin access to this data means that it can properly check
whether the database is being opened in a third-party context, and
therefore properly enforce the third-party access checks that were
added in http://trac.webkit.org/changeset/125736.
Third-party checks are added to IDBFactory::open,
IDBFactory::deleteDatabase, and IDBFactory::getDatabaseNames; each will
now throw a SECURITY_ERR exception when access in a third-party context
if third-party access checks are enabled.
To make this process slightly more clear, and avoid some ugly casting
logic, this patch adds a 'topOrigin' method to ScriptExecutionContext,
and implements it on both WorkerContext and Document.
Tests: http/tests/security/cross-origin-indexeddb-allowed.html
http/tests/security/cross-origin-indexeddb.html
http/tests/security/cross-origin-worker-indexeddb-allowed.html
http/tests/security/cross-origin-worker-indexeddb.html
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
Grab the SecurityOrigin of the current context's top-level origin,
and pass it to SecurityOrigin::canAccessDatabase to ensure that
access checks are properly applied to these three methods.
- dom/Document.cpp:
(WebCore::Document::topOrigin):
(WebCore):
- dom/Document.h:
(Document):
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
Add a topOrigin() method to ScriptExecutionContext, and implement it
on Document in order to give callers access to the top document's
SecurityOrigin without casting ScriptExecutionContext.
- workers/WorkerContext.h:
Change the existing topOrigin() method to override the new method
on ScriptExecutionContext.
LayoutTests:
Add tests to ensure that IndexedDB can be blocked in a third-party
context in both normal documents and in workers. These tests are
modeled after the existing cross-origin-websql* tests; it might be
possible to reuse some code in the future.
- http/tests/security/cross-origin-indexeddb-allowed-expected.txt: Added.
- http/tests/security/cross-origin-indexeddb-allowed.html: Added.
- http/tests/security/cross-origin-indexeddb-expected.txt: Added.
- http/tests/security/cross-origin-indexeddb.html: Added.
- http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt: Added.
- http/tests/security/cross-origin-worker-indexeddb-allowed.html: Added.
- http/tests/security/cross-origin-worker-indexeddb-expected.txt: Added.
- http/tests/security/cross-origin-worker-indexeddb.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-indexeddb.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-worker-indexeddb.html: Added.
- http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html: Added.
- http/tests/security/resources/worker-for-indexeddb.js: Added.
(self.onmessage):
Add exciting new tests, with more boilerplate than I expected!
- platform/efl/TestExpectations:
- platform/mac-snowleopard/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Skip these IndexedDB tests on platforms where the feature isn't
enabled.
- 6:52 AM Changeset in webkit [141417] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Network] Add cookie column to show presence of request/response cookies.
https://bugs.webkit.org/show_bug.cgi?id=107441
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
In some use cases only responses that contain "set-cookie" headers
are interesting.
- English.lproj/localizedStrings.js: Added "Set-Cookies" string.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable): Added columns.
(WebInspector.NetworkLogView.prototype._createSortingFunctions): Ditto.
(WebInspector.NetworkDataGridNode.prototype.createCells): Ditto.
(WebInspector.NetworkDataGridNode.prototype.refreshRequest): Ditto.
(WebInspector.NetworkDataGridNode.prototype._refreshCookiesCell): Added.
(WebInspector.NetworkDataGridNode.prototype._refreshSetCookiesCell): Added.
(WebInspector.NetworkDataGridNode.RequestCookiesCountComparator): Added.
(WebInspector.NetworkDataGridNode.ResponseCookiesCountComparator): Added.
- 6:30 AM Changeset in webkit [141416] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip two compositing tests, because They hit assertion fail after 140999.
https://bugs.webkit.org/show_bug.cgi?id=108257.
- platform/qt/TestExpectations:
- 6:15 AM Changeset in webkit [141415] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Exception in HeapSnapshotView.js
https://bugs.webkit.org/show_bug.cgi?id=108456
Reviewed by Yury Semikhatsky.
Listen "profile added" events in the HeapSnapshotView targeted only to the Heap Snapshot type.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._onProfileHeaderAdded):
- 6:10 AM Changeset in webkit [141414] by
-
- 7 edits in trunk
Web Inspector: do not set any textContent in overlay highlight spans
https://bugs.webkit.org/show_bug.cgi?id=108460
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
Source/WebCore:
Do not set any text content for overlay highlight spans to implicitly
set its height. Instead, measure its height in the same manner as its
done for "width" and "left" and set it explicitly.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.ElementMetrics):
- inspector/front-end/textEditor.css:
(.text-editor-token-highlight): Update highlight to correspond to
slightly different elements height.
LayoutTests:
Replace "height" pixel value with "<number>" to avoid difference in
test expectations on varioius platforms and correct test expectations.
- inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.dumpEditorHTML):
- inspector/editor/text-editor-highlight-api-expected.txt:
- inspector/editor/text-editor-highlight-token-expected.txt:
- 6:07 AM Changeset in webkit [141413] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Box shadows on a transparency layer is very slow
https://bugs.webkit.org/show_bug.cgi?id=107547
Reviewed by Noam Rosenthal.
Include the window boundaries in the clip returned by GraphicsContext,
since QPainter may remember clips larger than the destination, but
ShadowBlur uses the clipBounds to determine the size of the shadow layer.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clipBounds):
- 6:07 AM Changeset in webkit [141412] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: view the debug border/repaint count of the non composited layer.
https://bugs.webkit.org/show_bug.cgi?id=108401
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.
Make non-compositing layer draw debug border and show repaint counter
accroding to settings.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- 6:05 AM Changeset in webkit [141411] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: highlight backend languages as scripts
https://bugs.webkit.org/show_bug.cgi?id=108336
Reviewed by Vsevolod Vlasov.
Most languages have structure similar to js, so enabling default highlighter for them won't hurt.
- inspector/front-end/FileSystemWorkspaceProvider.js:
(WebInspector.FileSystemWorkspaceProvider.prototype._contentTypeForPath):
- 5:58 AM EFLWebKitBuildBots edited by
- (diff)
- 5:57 AM EFLWebKitBuildBots edited by
- (diff)
- 5:56 AM WebKit Team edited by
- Update my affiliation. (diff)
- 5:48 AM Changeset in webkit [141410] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Unjumble ChangeLog authors after r141407.
- 5:42 AM Changeset in webkit [141409] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Profiles] show launcher view upon deleting last profile type's header
https://bugs.webkit.org/show_bug.cgi?id=108468
Reviewed by Pavel Feldman.
We should show launcher view and hide profile type sidebar section upon deleting last profile type's header from the sidebar.
Right now we only show launcher view upon deleting the last profile header (of any profile type).
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
- 5:39 AM Changeset in webkit [141408] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
- 5:34 AM Changeset in webkit [141407] by
-
- 7 edits in trunk/Source
Vector should consult allocator about ideal size when choosing capacity.
<http://webkit.org/b/108410>
<rdar://problem/13124002>
Source/JavaScriptCore:
Patch by Filip Pizlo <fpizlo@apple.com> on 2013-01-30
Reviewed by Benjamin Poulain.
Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
Source/WTF:
Reviewed by Benjamin Poulain.
Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.
Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.
- wtf/Deque.h:
(WTF::::expandCapacity):
- wtf/FastMalloc.cpp:
(WTF::fastMallocGoodSize):
- wtf/FastMalloc.h:
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
- 5:25 AM Changeset in webkit [141406] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Network] Columns are misaligned as first row goes out of sight.
https://bugs.webkit.org/show_bug.cgi?id=107933
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
For some reason if "td" elements in first table row have "display: none"
style, then column width calculation breaks.
- inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid tr.offscreen > td > div):
Hide content instead of "td" element itself.
- 5:01 AM Changeset in webkit [141405] by
-
- 5 edits2 adds in trunk
formMethod to have empty string as default value and 'get' as invalid.
https://bugs.webkit.org/show_bug.cgi?id=108263
Reviewed by Kent Tamura.
The spec says formmethod should only have an invalid value default, not a missing value default.
Spec: http://www.whatwg.org/specs/web-apps/current-work/#form-submission-0
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formmethod
Source/WebCore:
Test: fast/forms/formmethod-attribute-test.html
- html/HTMLFormControlElement.cpp: For the missing formMethod attr return empty string.
(WebCore::HTMLFormControlElement::formMethod):
LayoutTests:
- fast/forms/formmethod-attribute-test-expected.txt: Added.
- fast/forms/formmethod-attribute-test.html: Added.
- fast/forms/submit-form-attributes-expected.txt:
- fast/forms/submit-form-attributes.html: Modified test to behave as expected.
- 4:47 AM Changeset in webkit [141404] by
-
- 6 edits1 add in trunk/Source/WebCore
[Efl][WebGL] Add better support to track and free XResources.
https://bugs.webkit.org/show_bug.cgi?id=107397
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-20
Reviewed by Noam Rosenthal.
We leak Memory during config selection as we dont free temporary
allocated visuals, config etc. This patch ensures that we dont leak any
memory.
Covered by existing WebGL tests.
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):
Removed XVisualInfo as member variable. Fixed memory leaks.
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
- platform/graphics/surfaces/glx/OwnPtrX11.h: Added.
(OwnPtrX11):
(WebCore::OwnPtrX11::OwnPtrX11):
(WebCore::OwnPtrX11::~OwnPtrX11):
(WebCore::OwnPtrX11::operator=):
(WebCore::OwnPtrX11::operator T*):
(WebCore::OwnPtrX11::operator->):
(WebCore::OwnPtrX11::get):
Calls XFree on pointer to memory allocated by X when the class goes out of scope.
OwnPtr cannot be used here as GLXFBConfig is a pointer to an array of pointers.
- platform/graphics/surfaces/glx/X11WindowResources.cpp:
(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::~X11OffScreenWindow):
(WebCore):
(WebCore::X11OffScreenWindow::createOffScreenWindow):
(WebCore::X11OffScreenWindow::destroyWindow):
(WebCore::X11OffScreenWindow::nativeSharedDisplay):
- platform/graphics/surfaces/glx/X11WindowResources.h:
(X11OffScreenWindow):
Removed unused code. Fixed memory leaks.
- 4:45 AM Changeset in webkit [141403] by
-
- 11 edits in trunk
Web Inspector: [Canvas] remove invalid canvas profile trace logs upon frame navigation
https://bugs.webkit.org/show_bug.cgi?id=108454
Reviewed by Pavel Feldman.
Source/WebCore:
When canvas profile trace logs stored in the backend get destroyed (for example, on frame navigation), send an event to frontend and update the UI.
Drive-by: replace String types to corresponding TypeBuilder::Canvas::* typedefs.
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore::InjectedScriptCanvasModule::startCapturing):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::stopCapturing):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):
(WebCore::InjectedScriptCanvasModule::replayTraceLog):
(WebCore::InjectedScriptCanvasModule::resourceInfo):
(WebCore::InjectedScriptCanvasModule::resourceState):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/Inspector.json:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::dropTraceLog):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::getResourceInfo):
(WebCore::InspectorCanvasAgent::getResourceState):
(WebCore::InspectorCanvasAgent::frameNavigated):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::hasIdForFrame):
(WebCore):
- inspector/InspectorPageAgent.h:
(InspectorPageAgent):
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype._traceLogsRemoved):
(WebInspector.CanvasDispatcher.prototype.contextCreated):
(WebInspector.CanvasDispatcher.prototype.traceLogsRemoved):
(WebInspector.CanvasProfileHeader):
(WebInspector.CanvasProfileHeader.prototype.frameId):
LayoutTests:
- inspector/profiler/canvas-profiler-test.js:
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent.InspectorBackend.registerCanvasDispatcher):
- 4:43 AM Changeset in webkit [141402] by
-
- 3 edits in trunk/Tools
[GTK] run-gtk-tests does not respect the -d argument
https://bugs.webkit.org/show_bug.cgi?id=107822
Reviewed by Philippe Normand.
- Scripts/run-gtk-tests:
(TestRunner.init): use the value for the debug option to decide what
build_type to request a path for.
- gtk/common.py:
(get_build_path): now accepts a build_type argument instead of trying both
Release and Debug in order, defaults to release.
(build_path): takes and passes a build_type argument, no default value.
- 4:04 AM Changeset in webkit [141401] by
-
- 5 edits in trunk
Web Inspector: DTE doesn't highlight words if the selected one is the last in the line
https://bugs.webkit.org/show_bug.cgi?id=108344
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
Source/WebCore:
Fix error in _isWord function which made an erroneous line-end check.
Improved test: inspector/editor/text-editor-highlight-token.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._isWord):
LayoutTests:
Add a test to cover specific case which caused the bug.
- inspector/editor/text-editor-highlight-token-expected.txt:
- inspector/editor/text-editor-highlight-token.html:
- 4:01 AM Changeset in webkit [141400] by
-
- 2 edits in trunk/Source/WebKit2
InjectedBundle is being built even with --disable-webkit2
https://bugs.webkit.org/show_bug.cgi?id=108364
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-01-31
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Wrap Injected bundle with ENABLE_WEBKIT2 condition
- 4:01 AM Changeset in webkit [141399] by
-
- 2 edits2 moves in trunk/LayoutTests
Web Inspector: text-editor-ctrl-movements.html timeouts on mac
https://bugs.webkit.org/show_bug.cgi?id=108440
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-31
Reviewed by Pavel Feldman.
Use "alt-arrows" key shortcuts to jump over words instead of
"ctrl-arrows" on Mac platform.
- inspector/editor/text-editor-word-jumps-expected.txt: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements-expected.txt.
- inspector/editor/text-editor-word-jumps.html: Renamed from LayoutTests/inspector/editor/text-editor-ctrl-movements.html.
- platform/chromium/TestExpectations: Do not skip this test anymore.
- 3:44 AM Changeset in webkit [141398] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Qt build fix after r141265.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Avoid uninitialized variable error when NATIVE_FULLSCREEN_VIDEO is disabled.
- 3:44 AM Changeset in webkit [141397] by
-
- 2 edits in trunk/Tools
Update Christophe Dumez's email address
https://bugs.webkit.org/show_bug.cgi?id=108453
Patch by Christophe Dumez <dchris@gmail.com> on 2013-01-31
Reviewed by Kenneth Rohde Christiansen.
Update my email address in committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 3:25 AM Changeset in webkit [141396] by
-
- 1 edit2 adds in trunk/LayoutTests
Web Inspector: test that references from DOM nodes to event listeners are presented in heap snapshots
https://bugs.webkit.org/show_bug.cgi?id=108322
Reviewed by Vsevolod Vlasov.
Test that links from DOM node wrappers to event listener functions are presented
in heap snapshots.
- inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt: Added.
- inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html: Added.
- 3:17 AM Changeset in webkit [141395] by
-
- 13 edits2 adds in trunk
Click on a label element won't select input[type=date]
https://bugs.webkit.org/show_bug.cgi?id=108428
Reviewed by Kentaro Hara.
Source/WebCore:
date/time input types with INPUT_MULTIPLE_FIELDS_UI are not
mouse-focusable. <input> as a shadow host never gets focus and
sub-fields in its shadow tree are focusable. Howevever, the click
handling of <label> checked isMouseFocusable. We introduce new function
isFocusableByClickOnLabel to HTMLElement. It's default implementation is
same as isMouseFocusable, and we add special handling for
BaseMultipleFieldsDateAndTimeInputType::isFocusableByClickOnLabel.
Also, date/time input types without INPUT_MULTIPLE_FIELDS_UI were not
mouse-focusable by a mistake. It should be mouse-focusable.
Test: fast/forms/date/date-click-on-label.html
- html/HTMLElement.cpp:
(WebCore::HTMLElement::isFocusableByClickOnLabel):
Added. Just calls isMouseFocusable.
- html/HTMLElement.h:
(HTMLElement): Declare isFocusableByClickOnLabel.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::defaultEventHandler):
Calls isFocusableByClickOnLabel instead of isMouseFocusable.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isFocusableByClickOnLabel):
Delegate to InputType::isFocusableByClickOnLabel.
- html/HTMLInputElement.h:
(HTMLInputElement): Declare isFocusableByClickOnLabel.
- html/InputType.cpp:
(WebCore::InputType::isFocusableByClickOnLabel):
Added. Calls isMouseFocusable.
- html/InputType.h:
(InputType): Declare isFocusableByClickOnLabel.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isFocusableByClickOnLabel):
Added. Use the same logic with textfields.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare isFocusableByClickOnLabel.
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::isMouseFocusable):
Added. Use the same logic with textfields.
- html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Declare isMouseFocusable.
LayoutTests:
- fast/forms/date/date-click-on-label-expected.txt: Added.
- fast/forms/date/date-click-on-label.html: Added.
- 3:10 AM Changeset in webkit [141394] by
-
- 6 edits in trunk/Source
Rename WheelEvent::Granularity to WheelEvent::DeltaMode
https://bugs.webkit.org/show_bug.cgi?id=108434
Reviewed by Ryosuke Niwa.
Per the spec, WheelEvent::Granularity should be renamed to WheelEvent::DeltaMode.
Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-WheelEvent
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent
No tests. No change in behavior.
Source/WebCore:
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::deltaMode):
(WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
- dom/WheelEvent.h:
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::deltaMode):
(WheelEvent):
- page/EventHandler.cpp:
(WebCore::wheelGranularityToScrollGranularity):
(WebCore::EventHandler::defaultWheelEventHandler):
Source/WebKit/chromium:
- src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):
- 2:52 AM Changeset in webkit [141393] by
-
- 4 edits3 adds in trunk
Web Inspector: test that nodes from the same detached DOM tree will get into one group in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=108202
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
- inspector/front-end/JSHeapSnapshot.js:
(WebInspector.JSHeapSnapshotNode.prototype.className): removed unnecessary i18n.
LayoutTests:
Test that JS wrappers for all DOM nodes from the same detached DOM tree will get into
single "Detached DOM Tree" entry in the JS heap snapshot.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.importScript):
- inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Added.
- inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Added. I started
with writing simplified version of WebInspector.JSHeapSnapshot just for tests
but it soon it became clear that we would need to reimplement too much functionality
of WebInspector.JSHeapSnapshot so I decided not to reinvent the wheel and just import
original heap snapshot model.
- inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Added.
(InspectorTest.takeHeapSnapshot):
- 2:02 AM Changeset in webkit [141392] by
-
- 5 edits in trunk/Tools
[chromium] move runModalBeforeUnloadDialog to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108442
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 1:46 AM Changeset in webkit [141391] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Bump Chromium dependency to 179332
- DEPS:
- 12:52 AM Changeset in webkit [141390] by
-
- 2 edits in trunk/Source/WebCore
[V8] Trace not only major DOM GCs but also minor DOM GCs
https://bugs.webkit.org/show_bug.cgi?id=108436
Reviewed by Adam Barth.
Currently only major DOM GCs are traced.
We should also trace minor DOM GCs.
No tests. No change in behavior.
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::minorGCEpilogue):
- 12:49 AM Changeset in webkit [141389] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] RequestManagerClientEfl, DownloadManagerEfl and ContextHistoryClientEfl should be based on C API
https://bugs.webkit.org/show_bug.cgi?id=107685
Reviewed by Benjamin Poulain.
RequestManagerClientEfl, DownloadManagerEfl and ContextHistoryClientEfl
should be based on C API so that API layering is not violated.
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
- UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):
- UIProcess/efl/ContextHistoryClientEfl.h:
(WebKit::ContextHistoryClientEfl::create):
(ContextHistoryClientEfl):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
(WebKit::DownloadManagerEfl::~DownloadManagerEfl):
- UIProcess/efl/DownloadManagerEfl.h:
(WebKit::DownloadManagerEfl::create):
(DownloadManagerEfl):
- UIProcess/efl/RequestManagerClientEfl.cpp:
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
- UIProcess/efl/RequestManagerClientEfl.h:
(WebKit::RequestManagerClientEfl::create):
(RequestManagerClientEfl):
- 12:45 AM Changeset in webkit [141388] by
-
- 8 edits in trunk
Layout Test inspector-protocol/take-heap-snapshot.html crashes in the Debug mode
https://bugs.webkit.org/show_bug.cgi?id=104800
Reviewed by Jochen Eisinger.
Source/WebCore:
The test crashed because during snapshot generation Profiler.reportHeapSnapshotProgress
events were sent to the inspector front-end, then parsed and dispatched there.
Since in case of layout tests the front-end resides in the same process
as the inspected page parsing the event broke an assumption that there are
no JS heap allocations while heap snapshot is being taken.
I added optional boolean parameter 'reportProgress' to Profiler.takeHeapSnapshot
command so that the protocol client can control whether progress events should
be sent during snapshot generation. The protocol test is not interested in the
progress events and sets reportProgress to false.
Test: inspector-protocol/heap-profiler/take-heap-snapshot.html
- inspector/Inspector.json:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::takeHeapSnapshot):
- inspector/InspectorProfilerAgent.h:
(InspectorProfilerAgent):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
LayoutTests:
Marked the test as not crashing in the debug mode.
- inspector-protocol/heap-profiler/take-heap-snapshot.html:
- platform/chromium/TestExpectations:
- 12:38 AM Changeset in webkit [141387] by
-
- 10 edits in trunk
Unreviewed, rolling out r141110.
http://trac.webkit.org/changeset/141110
https://bugs.webkit.org/show_bug.cgi?id=108349
This patch broke WK2-EFL unit tests (Requested by grzegorz on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31
Source/WebCore:
- platform/text/TextChecking.h:
(WebCore):
Source/WebKit/efl:
- WebCoreSupport/EditorClientEfl.h:
Source/WebKit2:
- UIProcess/efl/TextCheckerEfl.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
LayoutTests:
- platform/efl-wk2/TestExpectations:
- 12:33 AM Changeset in webkit [141386] by
-
- 3 edits2 adds in trunk/LayoutTests
Add composition-event-constructor.html, which I forgot to add in r141028
https://bugs.webkit.org/show_bug.cgi?id=107919
Reviewed by Adam Barth.
r141028 implemented a CompositionEvent constructor, but I forgot to add a test
when I landed the patch manually. This patch adds the test.
- fast/events/constructors/composition-event-constructor-expected.txt: Added.
- fast/events/constructors/composition-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 12:30 AM Changeset in webkit [141385] by
-
- 4 edits in trunk/Tools
[chromium] move postMessage related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108343
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::willCheckAndDispatchMessageEvent):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::willCheckAndDispatchMessageEvent):
- 12:29 AM Changeset in webkit [141384] by
-
- 7 edits1 add in trunk/Source/WebKit2
Coordinated Graphics : Remove WebCoordinatedSurface dependency from CoordinatedSurface
https://bugs.webkit.org/show_bug.cgi?id=108259
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.
This is a preparation patch for Threaded Coordinated Graphics.
WebCoordinatedSurface dependency should be removed from
CoordinatedSurface so as to share CoordinatedSurface between
WebCoordinatedSurface and CoordinatedSurface of WebKit1, which will be
implemented for Threaded Coordinated Graphics.
This patch introduces CoordinatedSurface::Factory, which is a function
pointer that creates CoordinatedSurfaces. CoordinatedLayerTreeHost sets
static CoordinatedSurface::Factory member variable. Classes that use
CoordinatedSurface, which are CoordinatedImageBacking and UpdateAtlas,
create CoordinatedSurfaces by calling CoordinatedSurface::create, which
will call the function set by CoordinatedLayerTreeHost.
This way, we can remove the WebCoordinatedSurface dependency from
CoordinatedSurface and be able to share the code in Threaded Coordinated
Graphics.
No new tests. No change in behavior.
- CMakeLists.txt:
- Shared/CoordinatedGraphics/CoordinatedSurface.cpp: Added.
(WebKit):
(WebKit::CoordinatedSurface::setFactory):
(WebKit::CoordinatedSurface::create):
- Shared/CoordinatedGraphics/CoordinatedSurface.h:
(CoordinatedSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
- Target.pri:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface):
(WebKit):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 12:12 AM Changeset in webkit [141383] by
-
- 5 edits in trunk
[V8] 'new MouseEvent("click", {relatedTarget: window}).window' should return window
https://bugs.webkit.org/show_bug.cgi?id=108432
Reviewed by Adam Barth.
In V8 'new MouseEvent("click", {relatedTarget: window}).window'
returns null. JSC returns window, which is a correct behavior.
V8 should also return window.
Source/WebCore:
The point is that we need to handle a DOMWindow wrapper specially
before converting it to an EventTarget object. A wrapper returned by
Dictionary::get("relatedTarget") is not an expected DOMWindow wrapper.
To get the expected DOMWindow wrapper, we need to look up a prototype
chain of the DOMWindow wrapper.
In JSC, this special handling is done by JSEventTargetCustom::toEventTarget().
Test: fast/events/constructors/mouse-event-constructor.html
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
LayoutTests:
- fast/events/constructors/mouse-event-constructor-expected.txt:
- fast/events/constructors/mouse-event-constructor.html:
- 12:05 AM Changeset in webkit [141382] by
-
- 6 edits1 move in trunk/Source
[Chromium] Move MediaPlayerPrivateChromium to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108415
Reviewed by Adam Barth.
Part of a larger refactoring series; see tracking bug 106829.
Source/WebCore:
- WebCore.gypi:
- platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Added.
(WebCore):
(WebCore::MediaPlayerPrivate::registerMediaEngine): call
registerMediaEngine through static function pointer that was set
during WebKit initializeWithoutV8
(WebCore::MediaPlayerPrivate::setMediaEngineRegisterSelfFunction):
new setter function that takes a function pointer that is used by registerMediaEngine
- platform/graphics/chromium/MediaPlayerPrivateChromium.h:
(WebCore):
(MediaPlayerPrivate):
Source/WebKit/chromium:
- WebKit.gyp:
- src/MediaPlayerPrivateChromium.cpp: Removed.
- src/WebKit.cpp:
(WebKit::initializeWithoutV8): call new setter function in
WebCore::MediaPlayerPrivate
- 12:00 AM Changeset in webkit [141381] by
-
- 6 edits in trunk/Tools
[chromium] move remaining resource load related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108334
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::allowExternalPages):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::canHandleRequest):
(WebTestRunner::WebTestProxy::cannotHandleRequestError):
(WebTestRunner::WebTestProxy::didCreateDataSource):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::canHandleRequest):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
(WebTestRunner::WebTestProxyBase::didCreateDataSource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::canHandleRequest):
(WebViewHost::didCreateDataSource):
(WebViewHost::willSendRequest):
(WebViewHost::allowExternalPages):
- DumpRenderTree/chromium/WebViewHost.h:
Jan 30, 2013:
- 11:24 PM Changeset in webkit [141380] by
-
- 2 edits1 delete in trunk/LayoutTests
[Chromium] Unreviewed, rebaselining expectations.
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
- platform/chromium/TestExpectations:
- 10:05 PM Changeset in webkit [141379] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed, marking video-error-does-not-exist.html as a fail.
- platform/chromium/TestExpectations:
- 10:00 PM Changeset in webkit [141378] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port DragImageWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=108329
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/DragImageWin.cpp:
(WebCore::dragLabelFont):
- platform/wince/DragImageWinCE.cpp: Removed.
- 9:27 PM Changeset in webkit [141377] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after http://trac.webkit.org/changeset/141372.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
- 9:22 PM Changeset in webkit [141376] by
-
- 4 edits in trunk/Source/WebKit2
Coordinated Graphics : Remove CoordinatedLayerTreeHostProxy dependency from LayerTreeRenderer
https://bugs.webkit.org/show_bug.cgi?id=108164
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-30
Reviewed by Benjamin Poulain.
This is a preparation patch for Threaded Coordinated Graphics.
LayerTreeRenderer should not depend on CoordinatedLayerTreeHostProxy so that it
can be moved to WebCore. This patch introduces LayerTreeRendererClient which
is implemented in CoordinatedLayerTreeHostProxy. LayerTreeRenderer uses this
client, instead of using CoordinatedLayerTreeHostProxy directly.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::animationFrameReady):
(WebKit::LayerTreeRenderer::updateViewport):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeBackingStores):
(WebKit::LayerTreeRenderer::detach):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(WebKit):
(LayerTreeRendererClient):
(LayerTreeRenderer):
- 9:15 PM Changeset in webkit [141375] by
-
- 4 edits in trunk/Source
Versioning.
- 9:11 PM Changeset in webkit [141374] by
-
- 1 copy in tags/Safari-537.29
New Tag.
- 9:03 PM Changeset in webkit [141373] by
-
- 4 edits in trunk/Source/WebCore
Split CSSOMWrapper data and functions out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107779
Reviewed by Dimitri Glazkov.
Factored CSSOMWrapper logic and data out from StyleResolver into a
InspectorCSSOMWrappers class. Since InspectorCSSOMWrappers
depends on static variables defined in StyleResolver.cpp, this
patch does not extract a new class into a new file, which makes a
review easier since it produces readable diffs.
After we factor static variables related to default style sheets
in a following patch (bug 107780), I'll move
InspectorCSSOMWrappers into a its own file.
No new tests, refactoring only.
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Name it explicitly rather than overloading.
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets): Renamed from ensureFullCSSOMWrapperForInspector().
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(InspectorCSSOMWrappers):
(WebCore):
(StyleResolver):
(WebCore::StyleResolver::inspectorCSSOMWrappers):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
(WebCore::InspectorCSSAgent::willProcessRule):
(WebCore::InspectorCSSAgent::buildObjectForRule):
- 9:02 PM Changeset in webkit [141372] by
-
- 11 edits in trunk/Source/WebKit2
PDFPlugin: Should respond to three-finger tap for dictionary definitions
https://bugs.webkit.org/show_bug.cgi?id=108418
<rdar://problem/13121409>
Reviewed by Simon Fraser.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add default implementation of performDictionaryLookupAtLocation.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add getSelectionForWordAtPoint and searchInDictionaryWithSelection.
- WebProcess/Plugins/PDF/PDFPlugin.h: Add performDictionaryLookupAtLocation.
- WebProcess/Plugins/PDF/PDFPlugin.mm: Grab a PDFSelection representing the word encompassing the given point, and
throw up a dictionary popover.
(WebKit::PDFPlugin::performDictionaryLookupAtLocation):
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add default implementation of performDictionaryLookupAtLocation.
- WebProcess/Plugins/Plugin.h: Add performDictionaryLookupAtLocation.
- WebProcess/Plugins/PluginProxy.h: Add default implementation of performDictionaryLookupAtLocation.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performDictionaryLookupAtLocation): Forward performDictionaryLookupAtLocation to the plugin.
- WebProcess/Plugins/PluginView.h: Add performDictionaryLookupAtLocation.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Intercept performDictionaryLookupAtLocation, and give
the main-frame plugin (if it exists) a chance to handle it.
- 8:57 PM Changeset in webkit [141371] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r141358.
http://trac.webkit.org/changeset/141358
https://bugs.webkit.org/show_bug.cgi?id=108421
breaks android builder (Requested by morrita on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-30
Source/WebCore:
- bindings/v8/custom/V8IntentCustom.cpp:
Source/WebKit/chromium:
- WebKit.gyp:
- features.gypi:
- src/WebFrameImpl.cpp:
- 8:46 PM Changeset in webkit [141370] by
-
- 4 edits in trunk/Source
Versioning.
- 8:42 PM Changeset in webkit [141369] by
-
- 3 edits in trunk/Tools
Unreviewed test failure fix for r141341.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- 8:32 PM Changeset in webkit [141368] by
-
- 2 edits in trunk/Source/WebCore
[V8] Use state->isolate() when state is not 0
https://bugs.webkit.org/show_bug.cgi?id=107674
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
- 8:07 PM Changeset in webkit [141367] by
-
- 90 edits2 adds in trunk/LayoutTests
[Chromium] Rebaline for form-related tests
https://bugs.webkit.org/show_bug.cgi?id=105574
https://bugs.webkit.org/show_bug.cgi?id=108069
- platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Added.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium/TestExpectations:
- 7:57 PM Changeset in webkit [141366] by
-
- 14 edits in trunk/Source/WebKit2
[WK2] Cleanup MessageID parameter after r141332
https://bugs.webkit.org/show_bug.cgi?id=108419
Unreviewed to fix build breaks.
r141332 didn't remove MessageID parameter on some features.
(battery, vibration, coordinate graphics, network info and so on)
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didReceiveCoordinatedLayerTreeHostProxyMessage):
- UIProcess/WebBatteryManagerProxy.h:
(WebBatteryManagerProxy):
- UIProcess/WebNetworkInfoManagerProxy.h:
(WebNetworkInfoManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
- UIProcess/WebVibrationProxy.h:
(WebVibrationProxy):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- WebProcess/Battery/WebBatteryManager.h:
(WebBatteryManager):
- WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebNetworkInfoManager):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveCoordinatedLayerTreeHostMessage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- WebProcess/soup/WebSoupRequestManager.h:
(WebSoupRequestManager):
- 7:38 PM Changeset in webkit [141365] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Re-enabling fast/workers/storage tests after fix(r141320).
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 7:14 PM Changeset in webkit [141364] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG bytecode parser should have more assertions about the status of local accesses
https://bugs.webkit.org/show_bug.cgi?id=108417
Reviewed by Mark Hahnenberg.
Assert some things that we already know to be true, just to reassure ourselves that they are true.
This is meant as a prerequisite for https://bugs.webkit.org/show_bug.cgi?id=108414, which will
make these rules even stricter.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
- 6:40 PM Changeset in webkit [141363] by
-
- 14 edits4 adds in trunk
The background HTML parser should be able to parse speculatively
https://bugs.webkit.org/show_bug.cgi?id=107753
Reviewed by Eric Seidel.
Source/WebCore:
This patch adds the ability for the foreground HTML parser to
invalidate speculative parsing done by the background HTML parser.
Currently, we're a bit overly agressive an invalidate all speculations
on document.write. We plan to refine that in the future.
Test: fast/parser/document-write-partial-script.html
- WebCore.gypi:
- html/parser/BackgroundHTMLInputStream.cpp: Added.
(WebCore):
(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::append):
(WebCore::BackgroundHTMLInputStream::close):
(WebCore::BackgroundHTMLInputStream::createCheckpoint):
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLInputStream.h: Added.
(WebCore):
(BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::current):
(WebCore::BackgroundHTMLInputStream::Checkpoint::Checkpoint):
(Checkpoint):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::append):
(WebCore):
(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::markEndOfFile):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
(WebCore::BackgroundHTMLParser::resumeFromPartial):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(ParsedChunk):
(HTMLDocumentParser):
LayoutTests:
- fast/parser/document-write-partial-script-expected.txt: Added.
- fast/parser/document-write-partial-script.html: Added.
- 6:38 PM Changeset in webkit [141362] by
-
- 4 edits70 moves4 adds in trunk/LayoutTests
[Mac Lion] [WK2] tiled-drawing tests are being run when they shouldn't be
https://bugs.webkit.org/show_bug.cgi?id=106187
Reviewed by Ryosuke Niwa.
Since the feature is mac-wk2 only, move the tests from platform mac to platform mac-wk2 and just
skip the tests on Lion entirely.
- platform/mac-lion/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-background-no-image.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-positioned.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-body-background.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-html-background.html.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.png: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.png.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-fixed.html.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html.
- platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-in-overflow.html.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html.
- platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view.html.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars-zoomed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars-zoomed.html.
- platform/mac-wk2/tiled-drawing/fixed/four-bars.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/four-bars.html.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset-in-view.html.
- platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/negative-scroll-offset.html.
- platform/mac-wk2/tiled-drawing/fixed/nested-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/nested-fixed.html.
- platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt.
- platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html: Renamed from LayoutTests/platform/mac/tiled-drawing/fixed/percentage-inside-fixed.html.
- platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt.
- platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-after-scroll.html.
- platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt.
- platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html: Renamed from LayoutTests/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling.html.
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/negative-scroll-offset-expected.txt.
- platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/negative-scroll-offset.html.
- platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-horizontal-expected.txt.
- platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-horizontal.html.
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-vertical-expected.txt.
- platform/mac-wk2/tiled-drawing/sticky/sticky-vertical.html: Renamed from LayoutTests/platform/mac/tiled-drawing/sticky/sticky-vertical.html.
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt.
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-after-scroll.html.
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt.
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom.html.
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt.
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tile-coverage-slow-scrolling.html.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled.html.
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html: Renamed from LayoutTests/platform/mac/tiled-drawing/tiled-drawing-zoom.html.
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt: Renamed from LayoutTests/platform/mac/tiled-drawing/use-tiled-drawing-expected.txt.
- platform/mac-wk2/tiled-drawing/use-tiled-drawing.html: Renamed from LayoutTests/platform/mac/tiled-drawing/use-tiled-drawing.html.
- platform/mac/TestExpectations:
- 6:30 PM Changeset in webkit [141361] by
-
- 97 edits in trunk/Source/WebKit2
Remove MessageID from MessageSender
https://bugs.webkit.org/show_bug.cgi?id=108413
Reviewed by Andreas Kling.
This is another step towards eliminating MessageID.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcess):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveMessage):
(WebKit::NetworkProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):
- Platform/CoreIPC/Connection.h:
(QueueClient):
(CoreIPC::Connection::waitForAndDispatchImmediately):
- Platform/CoreIPC/MessageReceiver.h:
(MessageReceiver):
(CoreIPC::MessageReceiver::didReceiveSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::dispatchMessage):
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.h:
(MessageReceiverMap):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didReceiveMessage):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
- Scripts/webkit2/messages.py:
(forward_declarations_and_headers):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveMessage):
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
(WebKit::ChildProcessProxy::send):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::didReceiveMessage):
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/Plugins/NPRemoteObjectMap.h:
(NPRemoteObjectMap):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::didReceiveMessage):
- Shared/WebConnection.h:
(WebConnection):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::didReceiveMessage):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didReceiveCoordinatedLayerTreeHostProxyMessage):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didReceiveCoordinatedLayerTreeHostProxyMessage):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
(WebKit::CustomProtocolManagerProxy::didReceiveMessage):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
- UIProcess/Network/NetworkProcessProxy.h:
(NetworkProcessProxy):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveMessage):
- UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didReceiveMessage):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
(SharedWorkerProcessProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::dispatchMessage):
(WebKit::WebContext::dispatchSyncMessage):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didReceiveMessage):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::didReceiveMessage):
(WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage):
- UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::didReceiveMessage):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::didReceiveMessage):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::didReceiveMessage):
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didReceiveMessage):
- WebProcess/FullScreen/WebFullScreenManager.h:
(WebFullScreenManager):
- WebProcess/Geolocation/WebGeolocationManager.h:
(WebGeolocationManager):
- WebProcess/IconDatabase/WebIconDatabaseProxy.h:
(WebIconDatabaseProxy):
- WebProcess/MediaCache/WebMediaCacheManager.h:
(WebMediaCacheManager):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/NetworkProcessConnection.h:
(NetworkProcessConnection):
- WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
(PluginProcessConnection):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
- WebProcess/Storage/WebKeyValueStorageManager.h:
(WebKeyValueStorageManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::didReceiveMessage):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveCoordinatedLayerTreeHostMessage):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebPageGroupProxy):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.h:
(WebProcess):
- 6:21 PM Changeset in webkit [141360] by
-
- 8 edits in trunk/Source/WebCore
[V8] Add IDL 'enum' support to CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=106553
Patch by Nils Barth <nbarth@google.com> on 2013-01-30
Reviewed by Kentaro Hara.
Add partial support for Web IDL enumerations in V8 bindings
Binding generators currently cannot handle IDL enumerations.
(An enumeration is an DOMString with a limited set of values, thus
treated internally as DOMString, with validation code added in
bindings.)
This adds support for enumerations in V8, adding validation checking
to setters.
It does not add validation checking to operations (no test case), and
does not add support in JSC.
Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
- bindings/scripts/IDLParser.pm:
- Parser assumes all IDL definitions are interfaces; add support for other definitions
- Parser parses but discards enum definitions; instead, record parsed data
(Parse): Sort definitions into interfaces and enums.
Remove "@definitions eq (someIdlDocument)" test, as this never
happens (fossil code) -- parseDefinitions returns list of definitions,
never a one-item list consisting of a document (no nested documents).
(unquoteString): new utility function to unquote StringToken (token
itself still quoted)
(parseEnum):
(parseEnumValueList):
(parseEnumValues):
(parseEnumOld):
- bindings/scripts/CodeGenerator.pm:
- Expose parsed enum data to backends (detect enums, list valid values)
- Enums treated as DOMString type in internal function
(ProcessDocument):
(IsEnumType):
(ValidEnumValues):
(IsRefPtrType):
- bindings/scripts/CodeGeneratorV8.pm:
- Enums treated as DOMString type in internal functions
- Add validation to setter
(GenerateNormalAttrSetter):
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):
(ConvertToV8StringResource):
- bindings/scripts/test/TestObj.idl:
- New enum type and enum variable test for IDL enumeration support
- bindings/scripts/test/V8/V8TestObj.cpp:
- Generated code, desired behavior
(WebCore::TestObjV8Internal::enumAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enumAttrAttrSetter):
(WebCore):
- bindings/scripts/test/JS/JSTestObj.cpp:
- Generated code, currently incorrect
(WebCore):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
- bindings/scripts/test/JS/JSTestObj.h:
- Generated code, currently incorrect
(WebCore):
- 6:19 PM Changeset in webkit [141359] by
-
- 4 edits in trunk/Source/WebKit2
PDFPlugin: Update scrollbars if PDFLayerController's display mode changes
https://bugs.webkit.org/show_bug.cgi?id=108412
<rdar://problem/13002261>
Reviewed by Simon Fraser.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add pdfLayerController:didChangeDisplayMode:
- WebProcess/Plugins/PDF/PDFPlugin.h: Add notifyDisplayModeChanged().
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeDisplayMode:]): Forward didChangeDisplayMode to notifyDisplayModeChanged.
(WebKit::PDFPlugin::notifyDisplayModeChanged): Update content size and scrollbar size when display mode changes.
- 6:17 PM Changeset in webkit [141358] by
-
- 6 edits in trunk/Source
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408
Reviewed by Kentaro Hara.
I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.
Source/WebCore:
- bindings/v8/custom/V8IntentCustom.cpp:
Source/WebKit/chromium:
- WebKit.gyp:
- features.gypi:
- src/WebFrameImpl.cpp:
- 6:15 PM Changeset in webkit [141357] by
-
- 5 edits2 adds in trunk
[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381
Reviewed by James Robinson.
Source/WebKit/chromium:
WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::requestTouchEventType):
Tools:
- DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
LayoutTests:
- platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
- platform/chromium/plugins/re-request-touch-events-crash.html: Added.
- 6:13 PM Changeset in webkit [141356] by
-
- 4 edits in trunk/Source
Start sending scrollType as NonBubblingGesture for flings
https://bugs.webkit.org/show_bug.cgi?id=108372
Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-01-30
Reviewed by James Robinson.
Source/Platform:
Using the newly defined scrollType layerTreeHostImpl will stop bubbling flings to
parent layers. It will only bubble if the child layer is at the end of its scroll
range
- chromium/public/WebInputHandlerClient.h:
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
- 6:11 PM Changeset in webkit [141355] by
-
- 6 edits in trunk/Tools
Add a concept of dashboard parameters that invalidate others
https://bugs.webkit.org/show_bug.cgi?id=108362
Reviewed by Dirk Pranke.
There are certain parameters to the dashboards, that when selected,
invalidate others, such as selecting the test type invalidates the
builder group. Add this concept to dashboard_base and allow specifc
dashboard to add their own invalidating parameters.
The result is that when the user takes a specific action, like changing
the test type, the builder would get reset to the default for the new
test type, rather than erroring or not matching the query param, as is
the current behavior.
Also deletes some unused code (selectBuilder).
- TestResultServer/static-dashboards/dashboard_base.js:
(invalidateQueryParameters):
(setQueryParameter):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- 6:07 PM Changeset in webkit [141354] by
-
- 9 edits24 adds in trunk/LayoutTests
Tests for spellcheck behavior
https://bugs.webkit.org/show_bug.cgi?id=108405
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-01-30
Reviewed by Tony Chang.
- editing/spelling/resources/util.js: Added. Boilerplate for spellcheck tests.
- editing/spelling/spelling-double-clicked-word.html: Added. Spelling should work for double-clicked misspellings.
- editing/spelling/spelling-double-clicked-word-with-underscores.html: Added. Underscores should be treated as whitespace: spelling should ignore them.
- editing/spelling/spelling-exactly-selected-multiple-words.html: Added. Spelling should work when the user selects a multi-word misspelling exactly.
- editing/spelling/spelling-exactly-selected-word.html: Added. Spelling should work when the user selects the misspelled word exactly.
- editing/spelling/spelling-multiword-selection.html: Added. Spelling should be disabled when user selects multiple words that are not a single misspelling.
- editing/spelling/spelling-should-select-multiple-words.html: Added. Spellcheck should select multi-word misspellings on context click.
- editing/spelling/spelling-should-select-single-word.html: Added. Spellcheck should select the misspelled word on context click.
- editing/spelling/spelling-subword-selection.html: Added. Spelling should be disabled when user selects a part of misspelling.
- editing/spelling/spelling-with-punctuation-selection.html: Added. Punctuation marks should be treated as whitespace: spelling should ignore them.
- editing/spelling/spelling-with-underscore-selection.html: Added. Underscores should be treated as whitespace: spelling should ignore them.
- editing/spelling/spelling-with-whitespace-selection.html: Added. Spelling should ignore whitespace.
- editing/spelling/spelling-double-clicked-word-expected.txt: Added.
- editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Added.
- editing/spelling/spelling-exactly-selected-multiple-words-expected.txt: Added.
- editing/spelling/spelling-exactly-selected-word-expected.txt: Added.
- editing/spelling/spelling-multiword-selection-expected.txt: Added.
- editing/spelling/spelling-should-select-multiple-words-expected.txt: Added.
- editing/spelling/spelling-should-select-single-word-expected.txt: Added.
- editing/spelling/spelling-subword-selection-expected.txt: Added.
- editing/spelling/spelling-with-punctuation-selection-expected.txt: Added.
- editing/spelling/spelling-with-underscore-selection-expected.txt: Added.
- editing/spelling/spelling-with-whitespace-selection-expected.txt: Added.
- platform/chromium/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/efl/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/gtk/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/mac/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/qt/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/wincairo/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/win/TestExpectations: Skip the tests until the platform implements the behavior.
- platform/wk2/TestExpectations: Skip the tests until the platform implements the behavior.
- 6:07 PM Changeset in webkit [141353] by
-
- 2 edits in trunk/Tools
Disable process suppression of DumpRenderTree on Mac
https://bugs.webkit.org/show_bug.cgi?id=108400
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-30
Reviewed by Jessie Berlin.
- DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment): Take assertion to prevent
process suppression.
- 5:39 PM Changeset in webkit [141352] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Add WebFrame::visibleContentRect()
https://bugs.webkit.org/show_bug.cgi?id=108311
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-30
Reviewed by James Robinson.
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visibleContentRect):
(WebKit):
- src/WebFrameImpl.h:
(WebFrameImpl):
- 5:31 PM Changeset in webkit [141351] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Remove speculative dispatchEvent crash fix now that root cause is addressed
https://bugs.webkit.org/show_bug.cgi?id=108131
Reviewed by Tony Chang.
A patch was landed in r140027 to prevent a null pointer crash in
IDBRequest::dispatchEvent and confirm the source of the crash (which
we couldn't repro locally). Following confirmation from user reports,
the root cause was tracked down to a race condition in MessageQueue,
and was fixed in r140483. This patch is no longer needed, and there's
always been an ASSERT in place to catch regressions while debugging.
No new tests - no behavior change.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent): Remove extraneous test.
- 5:26 PM Changeset in webkit [141350] by
-
- 6 edits in trunk/Source/WebCore
[BlackBerry] Store both proxy and host credentials simultaneously for NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=108388
Patch by Joe Mason <jmason@rim.com> on 2013-01-30
Reviewed by Yong Li.
The platform NetworkRequest interface has been updated again, to store both a proxy and host
credential for each request (to prevent an infinite loop when a request authenticates against a
proxy but fails the host authentication, and then the followup contains the host credential but not
the proxy credential so it fails proxy authentication, so the next followup contains the proxy
credential but not the host credential...)
Complying with the new interface requires the host and proxy challenge to be stored separately in
webkit so they can both be added to the same NetworkRequest.
Internal PR: 281172
Internal Reviewer: Leo Yang
- platform/network/ResourceHandleInternal.h:
(ResourceHandleInternal):
- platform/network/blackberry/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::hasCredentials):
(AuthenticationChallenge):
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
(WebCore::NetworkJob::handleRedirect):
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::storeCredentials):
(WebCore):
(WebCore::NetworkJob::purgeCredentials):
(WebCore::NetworkJob::notifyChallengeResult):
(WebCore::NetworkJob::updateCurrentWebChallenge):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::setAuthCredentials):
(WebCore):
(WebCore::NetworkManager::startJob):
- 5:22 PM Changeset in webkit [141349] by
-
- 2 edits in trunk/Tools
Enable tests for Windows EWS!
https://bugs.webkit.org/show_bug.cgi?id=107968.
Patch by Lucas Forschler.
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 5:08 PM Changeset in webkit [141348] by
-
- 2 edits in trunk/Source/WebCore
Make JSEventListener more robust in the event of the compiled handler being released.
https://bugs.webkit.org/show_bug.cgi?id=108390
Reviewed by Michael Saboff.
It shouldn't be possible for a handler to be collected for any object that
might still trigger an event. Nonetheless it does still happen, and the
only point of failure that currently exists is compiling the handler.
This patch is mostly just assertions, but also removes a bunch of field
clearing that was previously being performed. Given we do seem to periodically
end up needing to recompile a handler this appears to be necessary. That
said there does not appear to be a memory hit from this as the event handlers
that make us use JSLazyEventListener are not frequently compiled, and the bulk
of the functions that are compiled end up causing us to keep the strings around
anyway.
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::initializeJSFunction):
- 5:05 PM Changeset in webkit [141347] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed, update expectations on Mac for textarea change.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
- 4:56 PM Changeset in webkit [141346] by
-
- 17 edits2 adds in trunk
Implement KeyboardEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=108320
Reviewed by Adam Barth.
Source/WebCore:
This patch implements KeyboardEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
This significantly simplifies a code to construct a KeyboardEvent.
Before:
e = document.createEvent("KeyboardEvent");
e.initKeyboardEvent("keypress", true, true, null, false, false, false, false, 0, 0);
After:
e = new KeyboardEvent("keypress");
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
- 'char' and 'code' are not yet supported due to lack of WebCore implementation.
- 'altGraphKey' is not supported because it's an extended attribute in WebKit
and is not speced.
- Renamed keyboard event constant variables to avoid style errors.
Test: fast/events/constructors/keyboard-event-constructor.html
- dom/KeyboardEvent.cpp:
(WebCore::keyLocationCode):
(WebCore::KeyboardEventInit::KeyboardEventInit):
(WebCore):
(WebCore::KeyboardEvent::KeyboardEvent):
- dom/KeyboardEvent.h:
(WebCore):
(WebCore::KeypressCommand::KeypressCommand):
(KeypressCommand):
(KeyboardEventInit):
(KeyboardEvent):
(WebCore::KeyboardEvent::create):
(WebCore::KeyboardEvent::keyIdentifier):
(WebCore::KeyboardEvent::keyLocation):
(WebCore::KeyboardEvent::altGraphKey):
(WebCore::KeyboardEvent::keyEvent):
(WebCore::KeyboardEvent::keypressCommands):
- dom/KeyboardEvent.idl:
Source/WebKit/chromium:
Renamed keyboard event constant variables to avoid style errors.
- src/WebInputEventConversion.cpp:
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
- tests/WebInputEventConversionTest.cpp:
- tests/WebInputEventFactoryTestGtk.cpp:
LayoutTests:
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
This patch implements KeyboardEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/events/constructors/keyboard-event-constructor-expected.txt: Added.
- fast/events/constructors/keyboard-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 4:55 PM Changeset in webkit [141345] by
-
- 4 edits in branches/safari-536.28-branch/Source
Versioning.
- 4:54 PM Changeset in webkit [141344] by
-
- 1 edit2 deletes in trunk/LayoutTests
[chromium] Unreviewed, update expectations Linux 32 textarea tests.
- platform/chromium-linux-x86/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
- platform/chromium-linux-x86/fast/forms/form-element-geometry-expected.png: Removed.
- 4:53 PM Changeset in webkit [141343] by
-
- 1 copy in tags/Safari-536.28.10
New Tag.
- 4:50 PM Changeset in webkit [141342] by
-
- 5 edits in trunk
Add a StringTypeAdapter for ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=108338
Reviewed by Benjamin Poulain.
Source/WTF:
Add StringTypeAdapter for ASCIILiteral type so that concatenation of an
ASCIILiteral and a String using + operator is efficiently handled.
- wtf/text/StringConcatenate.h:
- wtf/text/StringOperators.h:
(WTF::operator+): Inline some of the operator+ functions that were not
yet.
(WTF):
Tools:
Add API tests for operator+() taking an ASCIILiteral.
- TestWebKitAPI/Tests/WTF/StringOperators.cpp:
(TestWebKitAPI::TEST):
- 4:49 PM Changeset in webkit [141341] by
-
- 2 edits in trunk/Tools
Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
Rubberstamped by Timothy Horton.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 4:32 PM Changeset in webkit [141340] by
-
- 3 edits in trunk/LayoutTests
[chromium] Unreviewed, update expectations for Win/Mac
Rebaseline one more textarea test on Linux.
- platform/chromium-linux/fast/forms/placeholder-position-expected.png:
- platform/chromium/TestExpectations:
- 4:28 PM Changeset in webkit [141339] by
-
- 2 edits in trunk/LayoutTests
Mark tests as failing after r141303.
These tests were rebaselined before the bots had correct results. This change
marks these tests as [ ImageOnlyFailure Pass ] again while the bots catch up.
Unreviewed test expectations update.
- platform/chromium/TestExpectations:
- 4:25 PM Changeset in webkit [141338] by
-
- 5 edits in trunk/Source/WebCore
IndexedDB: IDBKeyRange::isOnlyKey() does pointer equality comparison
https://bugs.webkit.org/show_bug.cgi?id=107582
Reviewed by Tony Chang.
Per the bug title, IDBKeyRange::isOnlyKey() was testing the upper/lower pointers to
determine if this was a "trivial" range, which can be used to fast-path lookups. This
is insufficient in multi-process ports where range values may be thrown across the wire.
This is addressed by using the existing key equality tests.
In addition, the bounds type check incorrectly checked m_lowerType == LowerBoundOpen, which
meant the function could never return true (since upper == lower implies closed bounds).
Therefore, the fast-path case wasn't used even in single-process ports (e.g. DRT). The
slow-path case contructed a backing store cursor over the range, and exited early if the
cursor yielded nothing. The fast-path case doesn't need to create a cursor, so needs to
deal with lookup misses. This revealed two similar (but trivial) lurking bugs in the
fast-path.
No new behavior; covered by tests such as: storage/indexeddb/get-keyrange.html
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::getRecord): Handle backing store read miss case.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::GetOperation::perform): Handle backing store read miss case.
- Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::isOnlyKey): Compare keys by value, not pointer, correct
type checks, add assertions.
- Modules/indexeddb/IDBKeyRange.h:
(IDBKeyRange): Move implementation to CPP file.
- 4:05 PM Changeset in webkit [141337] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r141205.
http://trac.webkit.org/changeset/141205
https://bugs.webkit.org/show_bug.cgi?id=108353
Command for running tests on windows needs to be investigated.
(Requested by lforschler on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-30
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:03 PM Changeset in webkit [141336] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Never store empty credentials in NetworkJob::storeCredentials
https://bugs.webkit.org/show_bug.cgi?id=108387
Patch by Joe Mason <jmason@rim.com> on 2013-01-30
Reviewed by Yong Li.
There is a code path that can cause NetworkJob::storeCredentials to be called with empty
credentials, causing the existing credentials to be overwritten even though authentication
succeeded. PR 287791 has been filed to investigate why this happens; in the meantime, ignore empty
credentials.
Internal PR: 281172
Internally Reviewed By: Leo Yang
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::storeCredentials):
- 3:52 PM Changeset in webkit [141335] by
-
- 4 edits1 add in trunk/Source/WebKit2
<rdar://problem/12695827> PPT: Make loading file URLs work with a sandboxed NetworkProcess
Reviewed by Sam Weinig.
- DerivedSources.make: Preprocess a .sb.in file to build the profile.
- NetworkProcess/mac/NetworkProcessMac.mm: Don't prevent entering the sandbox. Override sandbox path, because service gets a differnt one by default.
- WebKit2.xcodeproj/project.pbxproj:
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Added.
- 3:45 PM Changeset in webkit [141334] by
-
- 4 edits in trunk/Source/WebCore
ContentFilter should be a ref-counted class
https://bugs.webkit.org/show_bug.cgi?id=108392
Reviewed by David Kilzer.
- loader/MainResourceLoader.h:
(MainResourceLoader): Store a RefPtr to m_contentFilter.
- platform/ContentFilter.h: Inherit from RefCounted<ContentFilter>.
- platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::create): Return a PassRefPtr.
- 3:34 PM Changeset in webkit [141333] by
-
- 3 edits in trunk/Source/WebCore
[mac] ImageBuffer should create accelerated buffers for small canvases, but we shouldn't force them to create compositing layers
https://bugs.webkit.org/show_bug.cgi?id=107804
<rdar://problem/11752381>
Reviewed by Simon Fraser.
Make all canvases IOSurface-backed if requested, instead of having a size threshold
under which we won't use accelerated canvas.
Make requiresCompositingForCanvas take the size of the canvas into account, using
the threshold which was previously in ImageBuffer to determine whether or not a
canvas should be forced into a compositing layer.
This improves canvas performance on some benchmarks
(http://www.mikechambers.com/html5/javascript/QuadTree/examples/collision.html, for example)
significantly, in cases where canvases which fall below the size limit
(and thus are unaccelerated) are being drawn rapidly into either accelerated
tiles or another accelerated canvas, by preventing excessive copying to/from the GPU.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore):
(WebCore::ImageBuffer::ImageBuffer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
- 3:30 PM Changeset in webkit [141332] by
-
- 4 edits in trunk/Source/WebCore
IndexedDB: clean up scheduleTask return type
https://bugs.webkit.org/show_bug.cgi?id=108361
Reviewed by Tony Chang.
This is just a code simplification now that the
synchronous consumers of scheduleTask are gone.
No new tests: pure refactor.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(IDBTransactionBackendImpl):
- 3:27 PM Changeset in webkit [141331] by
-
- 37 edits in trunk
[Chromium] Enable textarea resize corner for tests
https://bugs.webkit.org/show_bug.cgi?id=108385
Reviewed by Ojan Vafai.
Tools:
We should test what we ship. Also, this makes us pass more tests in content_shell.
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset): Turn on resize corner.
LayoutTests:
- compositing/overflow/textarea-scroll-touch-expected.txt:
- fast/dom/shadow/shadowdom-for-textarea-with-placeholder-expected.html:
This ref test would overlay 2 textarea on top of each other. Turn off the resize corner on one of them.
- fast/dom/shadow/shadowdom-for-textarea-without-shadow.html: Turn off the resize corner since the reference
file doesn't use a textarea.
- fast/repaint/textarea-set-disabled-expected.png:
- platform/chromium-linux/editing/inserting/4960120-1-expected.png:
- platform/chromium-linux/editing/pasteboard/pasting-tabs-expected.png:
- platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.png:
- platform/chromium-linux/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
- platform/chromium-linux/fast/forms/basic-textareas-expected.png:
- platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
- platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
- platform/chromium-linux/fast/forms/negativeLineHeight-expected.png:
- platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
- platform/chromium-linux/fast/forms/textarea-align-expected.png:
- platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/chromium-linux/fast/forms/textarea-scroll-height-expected.png:
- platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
- platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.png:
- platform/chromium-linux/fast/forms/textarea-setinnerhtml-expected.png:
- platform/chromium-linux/fast/forms/textarea-width-expected.png:
- platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-linux/fast/parser/entity-comment-in-textarea-expected.png:
- platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-linux/fast/table/003-expected.png:
- platform/chromium-linux/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug194024-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug30692-expected.png:
- platform/chromium/TestExpectations: Mark image failures for Mac and Win.
- 3:22 PM Changeset in webkit [141330] by
-
- 12 edits in trunk
Elements that dynamically become fixed sometimes jump to the top left on scrolling
https://bugs.webkit.org/show_bug.cgi?id=108389
Source/WebCore:
Reviewed by Beth Dakin.
When an element became position:fixed and gained a compositing layer
as a result, we would compute its viewport constraints (including the
last GraphicsLayer position) before we had actually updated the GraphicsLayer
geometry for the first time. This would cause a jump to 0,0 on scrolling.
Fix by removing the call to updateViewportConstraintStatus() just after
creating the backing. Instead, hook in to registerScrollingLayers(),
which is called on every geometry update, to update the viewport
constraints for this layer.
Tested via existing tests, which now show correct positions at last
layout.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::registerScrollingLayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
LayoutTests:
Reviewed by Beth Dakin.
Update test results; these results now correctly reflect the last layout
positions.
- platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt:
- platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt:
- platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt:
- platform/mac/tiled-drawing/fixed/four-bars-expected.txt:
- platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt:
- platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt:
- platform/mac/tiled-drawing/sticky/sticky-horizontal-expected.txt:
- platform/mac/tiled-drawing/sticky/sticky-vertical-expected.txt:
- 3:19 PM Changeset in webkit [141329] by
-
- 2 edits in trunk/LayoutTests
Revert r138912, the right fix for https://bugs.webkit.org/show_bug.cgi?id=106187 is in
r141323.
- platform/mac-wk2/TestExpectations:
- 3:16 PM Changeset in webkit [141328] by
-
- 5 edits in trunk/Source/WebCore
HTMLDocumentParser::insert should be aware of threaded parsing
https://bugs.webkit.org/show_bug.cgi?id=107764
Reviewed by Eric Seidel.
This patch is an incremental step towards recovering from
document.write invalidating our speculative parsing buffer. The
approach I've taken is to make it possible to transfer the
HTMLDocumentParser's HTMLTokenizer and HTMLToken to the background
thread. To make that possible, I've taught the HTMLDocumentParser how
to operate without a tokenizer or a token.
Not having a tokenizer or a token while parsing in the background also
helps us avoid accidentially feeding input to the main thread's
tokenizer when we're supposed to feed it to the background thread.
This patch shouldn't have any behavior change (other than possibly
fixing a crash in fast/parser when threading parsing is enabled).
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::TextDocumentParser):
- 3:11 PM Changeset in webkit [141327] by
-
- 6 edits in trunk
[HTMLTemplateElement] prevent the parser from removing nodes from the content when the foster agency is processing formatting elements
https://bugs.webkit.org/show_bug.cgi?id=108377
Reviewed by Adam Barth.
Source/WebCore:
callTheAdoptionAgency now appends to the template's content when it previously would have appended to the template element itself.
New test added to html5lib.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
LayoutTests:
Note that dump-as-markup.js is modified here to put both template content and its direct children. This was an oversight and fixing it will make it
easier to spot parse errors like ones that arise from this bug, where nodes are appended directly to the template element.
- html5lib/resources/template.dat:
- resources/dump-as-markup.js:
(Markup._get):
- 3:06 PM Changeset in webkit [141326] by
-
- 5 edits4 deletes in trunk/LayoutTests
Update fast/backgrounds/size/contain-and-cover-zoomed test expectations.
Unreviewed update of test expectations.
- platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium/TestExpectations:
- 3:00 PM Changeset in webkit [141325] by
-
- 5 edits in trunk/Source/WebKit2
Coordinated Graphics: LayerTreeRenderer manages the surface of UpdateAtlas.
https://bugs.webkit.org/show_bug.cgi?id=107224
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Benjamin Poulain.
Currently, CoordinatedLayerTreeHostProxy manages the surface of UpdateAtlas, but
all other resources are managed by LayerTreeRenderer. This patch matches the
surface of UpdateAtlas to other resources.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::updateTileForLayer):
(WebKit::CoordinatedLayerTreeHostProxy::createUpdateAtlas):
(WebKit::CoordinatedLayerTreeHostProxy::removeUpdateAtlas):
(WebKit::CoordinatedLayerTreeHostProxy::purgeBackingStores):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::createUpdateAtlas):
(WebKit):
(WebKit::LayerTreeRenderer::removeUpdateAtlas):
(WebKit::LayerTreeRenderer::purgeGLResources):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):
(LayerTreeRenderer):
- 2:58 PM Changeset in webkit [141324] by
-
- 4 edits in trunk/LayoutTests
Update chromium-mac svg/zoom test expectations after r141303
Unreviewed update of test expectations.
- platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- 2:49 PM Changeset in webkit [141323] by
-
- 2 edits in trunk/LayoutTests
Don't run the tiled-drawing tests on Lion WK2.
- platform/mac-wk2/TestExpectations:
Even though the platform/mac/tiled-drawing tests were skipped in the Lion TestExpectations
file, the Pass value in the mac-wk2 TestExpectations file was causing them to be run on
Lion WK2. Explicity skip the tests on Lion here as well.
- 2:48 PM Changeset in webkit [141322] by
-
- 75 edits in trunk/Source/WebKit2
Remove MessageID parameter from generated message receivers
https://bugs.webkit.org/show_bug.cgi?id=108379
Reviewed by Beth Dakin.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcess):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveMessage):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- PluginProcess/PluginControllerProxy.h:
(PluginControllerProxy):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didReceiveMessage):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
(WebProcessConnection):
- Scripts/webkit2/messages.py:
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::didReceiveMessage):
- Shared/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::didReceiveMessage):
- Shared/Plugins/NPObjectMessageReceiver.h:
(NPObjectMessageReceiver):
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::didReceiveMessage):
- Shared/WebConnection.h:
(WebConnection):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- Shared/mac/SecItemShim.h:
(SecItemShim):
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::didReceiveMessage):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveMessage):
(WebKit::DownloadProxy::didReceiveSyncMessage):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
(WebKit::CustomProtocolManagerProxy::didReceiveMessage):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
- UIProcess/Network/NetworkProcessProxy.h:
(NetworkProcessProxy):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didReceiveMessage):
- UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didReceiveMessage):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
(SharedWorkerProcessProxy):
- UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::didReceiveMessage):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didReceiveMessage):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::didReceiveMessage):
(WebKit::WebFullScreenManagerProxy::didReceiveSyncMessage):
- UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/mac/RemoteLayerTreeHost.h:
(RemoteLayerTreeHost):
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::didReceiveMessage):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.h:
(SecItemShimProxy):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::didReceiveMessage):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebApplicationCacheManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::didReceiveMessage):
- WebProcess/Cookies/WebCookieManager.h:
(WebCookieManager):
- WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didReceiveMessage):
- WebProcess/FullScreen/WebFullScreenManager.h:
(WebFullScreenManager):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/WebResourceLoader.h:
(WebResourceLoader):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
(PluginProcessConnection):
- WebProcess/Plugins/PluginProxy.h:
(PluginProxy):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::didReceiveMessage):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebPage/WebInspector.h:
(WebInspector):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebProcess.h:
(WebProcess):
- 2:46 PM Changeset in webkit [141321] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSContext's dealloc causes ASSERT due to ordering of releases
https://bugs.webkit.org/show_bug.cgi?id=107978
Reviewed by Filip Pizlo.
We need to add the Identifier table save/restore in JSContextGroupRelease so that we
have the correct table if we end up destroying the JSGlobalData/Heap.
- API/JSContextRef.cpp:
(JSContextGroupRelease):
- 2:45 PM Changeset in webkit [141320] by
-
- 2 edits in trunk/Source/WebCore
DatabaseContext should implement ThreadSafeRefCounted.
https://bugs.webkit.org/show_bug.cgi?id=108285.
Reviewed by Alexey Proskuryakov.
DatabaseManager::interruptAllDatabasesForContext() can ref a
DatabaseContext from another thread. Hence, the DatabaseContext needs
to be a ThreadSafeRefCounted instead of a RefCounted.
No new tests.
- Modules/webdatabase/DatabaseContext.h:
- 2:44 PM Changeset in webkit [141319] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][UNIX] g_spawn_sync() generates warning in PluginProcessProxy::scanPlugin()
https://bugs.webkit.org/show_bug.cgi?id=108371
Patch by Christophe Dumez <dchris@gmail.com> on 2013-01-30
Reviewed by Martin Robinson.
g_spawn_sync() was sometimes displaying a warning about the SIGCHLD
signal disposition not being set to SIG_DFL, despite the fix in r133755.
The reason was that the code was only setting the disposition to SIG_DFL
if the previous disposition was SIG_IGN.
In this patch, we set the SIGCHLD signal disposition to SIG_DFL, no
matter what its previous disposition was. Also, the signal disposition
is now restored to its previous state after the call to g_spawn_sync()
to avoid side effects. Finally, we now use SIGCHLD instead of SIDCLD
since this is the more compatible POSIX name.
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::spawnProcessSync):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):
- 2:43 PM Changeset in webkit [141318] by
-
- 15 edits2 adds in trunk
Implement WheelEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=108303
Reviewed by Adam Barth.
Source/WebCore:
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
This patch implements UIEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
Test: fast/events/constructors/wheel-event-constructor.html
- dom/WheelEvent.cpp:
(WebCore::WheelEventInit::WheelEventInit):
(WebCore):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
- dom/WheelEvent.h:
(WheelEventInit):
(WebCore):
(WheelEvent):
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::wheelDelta):
(WebCore::WheelEvent::wheelDeltaX):
(WebCore::WheelEvent::wheelDeltaY):
(WebCore::WheelEvent::rawDeltaX):
(WebCore::WheelEvent::rawDeltaY):
(WebCore::WheelEvent::granularity):
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice):
(WebCore::WheelEvent::isHorizontal):
- dom/WheelEvent.idl:
Source/WebKit/chromium:
This patch just renames an enum value to avoid style check error.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
LayoutTests:
Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
This patch implements UIEvent constructor under a DOM4_EVENTS_CONSTRUCTOR flag,
which is enabled on Chromium and Safari.
Test: fast/events/constructors/wheel-event-constructor.html
- fast/events/constructors/wheel-event-constructor-expected.txt: Added.
- fast/events/constructors/wheel-event-constructor.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 2:41 PM Changeset in webkit [141317] by
-
- 3 edits4 adds in trunk
[CSS Grid Layout] Support 'auto' sized grid items
https://bugs.webkit.org/show_bug.cgi?id=103332
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-grid-layout/auto-content-resolution-columns.html
fast/css-grid-layout/auto-content-resolution-rows.html
The specification interprets 'auto' as minmax(min-content, max-content).
Because we stored the grid definitions as an 'auto' length, we wouldn't
handle it properly during layout.
This change makes us do the translation when we query the information for
layout.
- rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
Translate 'auto' to minmax(min-content, max-content). This works as getComputedStyle
still sees the GridTrackSize as a single length and thus query length() instead of the
individual component of minmax().
LayoutTests:
- fast/css-grid-layout/auto-content-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/auto-content-resolution-columns.html: Added.
- fast/css-grid-layout/auto-content-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/auto-content-resolution-rows.html: Added.
- 2:39 PM Changeset in webkit [141316] by
-
- 4 edits3 adds in trunk
IndexedDB: Avoid crashing when deleting indexes
https://bugs.webkit.org/show_bug.cgi?id=108356
Reviewed by Tony Chang.
Source/WebCore:
It is reasonable that the backend aborts a transaction before
the frontend is aware, depending on the timing of events. This
allows the transactionId to be invalid rather than asserting.
Test: storage/indexeddb/createIndex-after-failure.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::setIndexesReady):
(WebCore::IDBDatabaseBackendImpl::openCursor):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::IDBDatabaseBackendImpl::deleteRange):
(WebCore::IDBDatabaseBackendImpl::clear):
LayoutTests:
This test works on an edge case around the asynchronous
creation/deletion of indexes that used to crash. It doesn't fail/crash even
without this patch but was the test condition that uncovered the overall problem
before https://bugs.webkit.org/show_bug.cgi?id=107311 changed the timing of
some of the events.
- storage/indexeddb/createIndex-after-failure.html: Added.
- storage/indexeddb/resources/createIndex-after-failure.js: Added.
(sleep):
(prepareDatabase):
(deleteIndexAfterGet):
- storage/indexeddb/resources/shared.js:
(.requests.forEach):
(waitForRequests):
- storage/indexeddb/createIndex-after-failure.html: Added.
- storage/indexeddb/resources/createIndex-after-failure.js: Added.
(prepareDatabase):
(deleteIndexAfterGet):
- storage/indexeddb/resources/shared.js:
(.requests.forEach):
(waitForRequests):
- 2:36 PM Changeset in webkit [141315] by
-
- 5 edits in trunk/Source/WebCore
isSameAsCurrentState() should take SerializedScriptValue* instead of PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=107904
Reviewed by Darin Adler.
Applied Darin's comment: https://bugs.webkit.org/show_bug.cgi?id=107904#c5
No tests. No change in behavior.
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- page/History.cpp:
(WebCore::History::isSameAsCurrentState):
- page/History.h:
(History):
- 2:32 PM Changeset in webkit [141314] by
-
- 7 edits in trunk/Source/WebCore
Remove unnecessary setAnimating() method
https://bugs.webkit.org/show_bug.cgi?id=107495
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-01-30
Reviewed by Dean Jackson.
The corresponding accessor and uses were removed in r39211.
No new tests: no change in behaviour.
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
- page/animation/AnimationBase.h:
(AnimationBase):
- page/animation/CompositeAnimation.cpp:
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
- 2:30 PM Changeset in webkit [141313] by
-
- 4 edits in trunk/Source/WebCore
Clean up interface to ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=108300
Reviewed by Dimitri Glazkov.
Lots of general clean up to ShadowRoot removing unused headers and forward
declarations, moving short inline methods into the class definition so it's
easier to understand what methods do what, and replacing macros with methods
with inline methods.
No new tests, just refactoring.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::setInnerHTML): Use isOrphan instead of macro.
(WebCore::ShadowRoot::setApplyAuthorStyles): Use isOrphan instead of macro.
(WebCore::ShadowRoot::setResetStyleInheritance): Use isOrphan instead of macro.
(WebCore::ShadowRoot::childrenChanged): Use isOrphan instead of macro.
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::setHost): Removed.
(WebCore::ShadowRoot::host):
(WebCore::ShadowRoot::owner):
(ShadowRoot):
(WebCore::ShadowRoot::isOrphan): Replacement of GuardOrphanShadowRoot macro.
- 2:30 PM Changeset in webkit [141312] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Remove useless comment from Base.xcconfig
Rubber-stamped by Mark Rowe.
- Configurations/Base.xcconfig: Remove comment.
- 2:29 PM Changeset in webkit [141311] by
-
- 7 edits in trunk/LayoutTests
Update svg/zoom test expectations after r141303
Unreviewed update of test expectations.
- platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- 2:27 PM Changeset in webkit [141310] by
-
- 16 edits in trunk/Source/WebKit2
[EFL][Qt][WK2] We should consider a page scale factor in WebCore instead of our own scale factor.
https://bugs.webkit.org/show_bug.cgi?id=105978
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Simon Fraser.
Currently, PageViewportController sends a page scale factor to Coordinated
Graphics System regardless of the page scale factor in WebCore. This patch makes
Coordinated Graphics System use the page scale factor in WebCore to match other
ports.
When it is needed to change a page scale, PageViewportController sends the scale
to Page in Web Process via WebPageProxy::scalePage. When the page scale in
WebCore is changed, CoordinatedGraphicsLayer gets notified via
deviceOrPageScaleFactorChanged callback. CoordinatedGraphicsLayer uses the page
scale factor like previous our own scale factor.
We set true to applyDeviceScaleFactorInCompositor and
ApplyPageScaleFactorInCompositor in Settings like chromium, because
TiledBackingStore that is a backing store of each GraphicsLayer applies the
scale to our raster graphics engines instead of applying the scale to the local
transform of each render object.
Thank Kenneth Rohde Christiansen for implementing the base patch of this patch.
No new tests. Covered by existing tests.
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebView::setSize):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):
Does not receive a pageScaleFactor argument because
PageViewportController sends a page scale factor to Page.
However, this method still receives a scroll position because we
enable delegates scrolling.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):
- UIProcess/efl/PageClientLegacyImpl.cpp:
(WebKit::PageClientLegacyImpl::updateViewportSize):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::deviceOrPageScaleFactorChanged):
(WebCore::CoordinatedGraphicsLayer::effectiveContentsScale):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::deviceScaleFactor):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::pageScaleFactor):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 2:27 PM Changeset in webkit [141309] by
-
- 12 edits in branches/safari-536.28-branch
Merged r138606. <rdar://problem/13117769>
- 2:24 PM Changeset in webkit [141308] by
-
- 6 edits1 add in trunk/Source/WTF
Upstream iOS build file changes for WTF
<http://webkit.org/b/108221>
Reviewed by Mark Rowe.
- Configurations/Base.xcconfig:
- Import iOS.xcconfig.
- Remove VALID_ARCHS. Modern Xcodes define these correctly.
- Make HEADER_SEARCH_PATHS work with iOS Simulator builds.
- Add SUPPORTED_PLATFORMS so both Mac and iOS SDKs appear in schemes.
- Define INSTALL_PATH when building for macosx SDK.
- Configurations/CopyWTFHeaders.xcconfig:
- Make PRIVATE_HEADERS_FOLDER_PATH work with iOS Simulator builds.
- Configurations/DebugRelease.xcconfig:
- Simplify ARCHS. This works correctly on 32-bit-only SDKs.
- Configurations/WTF.xcconfig:
- Fix installation directory for iOS Simulator builds by defining INSTALL_PATH_ACTUAL.
- Configurations/iOS.xcconfig: Add.
- WTF.xcodeproj/project.pbxproj:
- Add iOS.xcconfig to the project.
- 2:20 PM Changeset in webkit [141307] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Temporarily change expectations for tests affected by tiling shaders
https://bugs.webkit.org/show_bug.cgi?id=108367
Patch by Brian Anderson <brianderson@chromium.org> on 2013-01-30
Reviewed by Adrienne Walker.
- platform/chromium/TestExpectations:
- 2:17 PM Changeset in webkit [141306] by
-
- 2 edits in trunk/Source/WebCore
Apple's internal PLT test suite doesn't finish after r141136
https://bugs.webkit.org/show_bug.cgi?id=108380
Reviewed by Alexey Proskuryakov.
Temporarily disable the feature to see if that fixes it.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- 2:16 PM Changeset in webkit [141305] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: exceptionHandler needs to be released in JSContext dealloc
https://bugs.webkit.org/show_bug.cgi?id=108378
Reviewed by Filip Pizlo.
JSContext has a (copy) exceptionHandler property that it doesn't release in dealloc.
That sounds like the potential for a leak. It should be released.
- API/JSContext.mm:
(-[JSContext dealloc]):
- 1:55 PM Changeset in webkit [141304] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] Unreviewed gardening.
Attempted Mac build fix after http://trac.webkit.org/changeset/141291.
- platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp:
(WebCore::harfBuzzCoreTextGetFontFuncs):
- 1:09 PM Changeset in webkit [141303] by
-
- 8 edits in trunk
Track scale and zoom together when drawing SVG images
https://bugs.webkit.org/show_bug.cgi?id=108108
Reviewed by Tim Horton.
Source/WebCore:
This patch refactors SVGImage::drawSVGToImageBuffer to take a single zoomAndScale parameter
and removes two messy calls to setPageZoomFactor. This patch makes progress towards an
SVG image cache keyed on just container size and scale.
This refactoring is covered by existing tests.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
This complex logic has been refactored out of CachedImage and into SVGImageCache.
In addition to the code move, we no longer divide by the zoom factor because the
container size is stored without zoom.
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
This method signature has changed to take a FloatSize for the container size and
a combined zoom and scale parameter (zoomAndScale). A FloatSize is needed for the
container size because we now store the container size unzoomed, and in this process
we do not want to lose precision.
The messy setPageZoomFactor calls have also been removed which cleans this function up.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):
This function now stores the container size unzoomed. The container size was changed
to a FloatSize so that precision is not lost.
(WebCore::SVGImageCache::imageSizeForRenderer):
Note that the ImageBuffer size will stay the same. We now store the size as:
containerSize (without zoom) * zoom * scale
Previously this was:
containerSize (with zoom) * scale
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
- svg/graphics/SVGImageCache.h:
(WebCore::SVGImageCache::SizeAndScales::SizeAndScales):
(SizeAndScales):
(SVGImageCache):
LayoutTests:
- platform/chromium/TestExpectations:
- 1:03 PM Changeset in webkit [141302] by
-
- 7 edits in trunk/Source
[chromium] Add recordRenderingStats to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=108358
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebKit/chromium:
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setRecordRenderingStats):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::recordRenderingStats):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- 1:02 PM Changeset in webkit [141301] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(140504): pure CSE no longer matches things, 10% regression on Kraken
https://bugs.webkit.org/show_bug.cgi?id=108366
Reviewed by Geoffrey Garen and Mark Hahnenberg.
This was a longstanding bug that was revealed by http://trac.webkit.org/changeset/140504.
Pure CSE requires that the Node::flags() that may affect the behavior of a node match,
when comparing a possibly redundant node to its possible replacement. It was doing this
by comparing Node::arithNodeFlags(), which as the name might appear to suggest, returns
just those flag bits that correspond to actual node behavior and not auxiliary things.
Unfortunately, Node::arithNodeFlags() wasn't actually masking off the irrelevant bits.
This worked prior to r140504 because CSE itself didn't mutate the flags, so there was a
very high probability that matching nodes would also have completely identical flag bits
(even the ones that aren't relevant to arithmetic behavior, like NodeDoesNotExit). But
r140504 moved one of CSE's side-tables (m_relevantToOSR) into a flag bit for quicker
access. These bits would be mutated as the CSE ran over a basic block, in such a way that
there was a very high probability that the possible replacement would already have the
bit set, while the redundant node did not have the bit set. Since Node::arithNodeFlags()
returned all of the bits, this would cause CSEPhase::pureCSE() to reject the match
almost every time.
The solution is to make Node::arithNodeFlags() do as its name suggests: only return those
flags that are relevant to arithmetic behavior. This patch introduces a new mask that
represents those bits, and includes NodeBehaviorMask and NodeBackPropMask, which are both
used for queries on Node::arithNodeFlags(), and both affect arithmetic code gen. None of
the other flags are relevant to Node::arithNodeFlags() since they either correspond to
information already conveyed by the opcode (like NodeResultMask, NodeMustGenerate,
NodeHasVarArgs, NodeClobbersWorld, NodeMightClobber) or information that doesn't affect
the result that the node will produce or any of the queries performed on the result of
Node::arithNodeFlags (NodeDoesNotExit and of course NodeRelevantToOSR).
This is a 10% speed-up on Kraken, undoing the regression from r140504.
- dfg/DFGNode.h:
(JSC::DFG::Node::arithNodeFlags):
- dfg/DFGNodeFlags.h:
(DFG):
- 12:51 PM Changeset in webkit [141300] by
-
- 5 edits in trunk/Source/WebCore
Do not convert to String->AtomicString for NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=108289
Reviewed by Kentaro Hara.
NamedNodeMap's API was taking a WTF::String. Internally, attribute
names are AtomicString.
The conversions String->AtomicString was causing an additional ref-deref
for the JS/V8 bindings. And could cause an additional memory allocation for the Objective-C
bindings.
This patch changes the API to use AtomicString, and update the custom bindings accordingly.
- bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
- bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::namedPropertyGetter):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
- dom/NamedNodeMap.h:
(NamedNodeMap):
- 12:47 PM Changeset in webkit [141299] by
-
- 4 edits in trunk
[GTK] http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108100
Reviewed by Tony Gentilcore.
Source/WebCore:
Similarly to the changes to V8 bindings in r140882, wrap the PerformanceEntry
as a PerformanceMark or PerformanceMeasure if possible.
No new tests - the relevant test now passes.
- bindings/js/JSPerformanceEntryCustom.cpp:
(WebCore::toJS):
LayoutTests:
- platform/gtk/TestExpectations: Remove the failure expectation.
- 12:46 PM Changeset in webkit [141298] by
-
- 9 edits in trunk/Tools
[chromium] move custom policy delegate to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=108328
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::decidePolicyForNavigation):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::policyDelegateIsPermissive):
(WebTestRunner::TestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::TestRunner::setCustomPolicyDelegate):
(WebTestRunner::TestRunner::waitForPolicyDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::decidePolicyForNavigation):
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 12:42 PM Changeset in webkit [141297] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix compile error in WebFrameTest
https://bugs.webkit.org/show_bug.cgi?id=108360
Unreviewed build fix.
Fixes compile error:
../../Source/WebKit/chromium/tests/WebFrameTest.cpp:330:5: error: converting false to pointer type for argument 1 of char testing::internal::IsNullLiteralHelper(testing::internal::Secret*) [-Werror=conversion-null]
- tests/WebFrameTest.cpp:
- 12:22 PM Changeset in webkit [141296] by
-
- 15 edits2 adds2 deletes in trunk/Source/WebCore
[JSC] MutationObservers should not create circular, leaky references
https://bugs.webkit.org/show_bug.cgi?id=93661
Reviewed by Adam Barth.
This patch makes JSMutationCallback an entirely-custom class that
holds a weak reference to the function it wraps. To keep that function
alive, it also adds a PrivateName between the JSMutationObserver
wrapper and the function when the MutationObserver is constructed.
Unlike the generated JSC callbacks, JSMutationCallback doesn't hold a
reference to the JSDOMGlobalObject, instead holding the
DOMWrapperWorld it was created in. As an ActiveDOMCallback, it also
holds a weak pointer to ScriptExecutionContext (via ContextDestructionObserver).
It's not clear to me how to write a test for this. There's an existing
manual test in ManualTests/leak-cycle-observer-wrapper.html which may
be of use but which doesn't seem to currently give meaningful output.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSMutationCallback.cpp: Added.
(WebCore):
(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::~JSMutationCallback):
(WebCore::JSMutationCallback::handleEvent):
- bindings/js/JSMutationCallback.h: Added.
(WebCore):
(JSMutationCallback): Instead of a JSCallbackData, hold a weak ref to the callback and a RefPtr to the DOMWrapperWorld.
(WebCore::JSMutationCallback::create):
- bindings/js/JSMutationCallbackCustom.cpp: Removed.
- bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
When constructing the JSMutationObserver, add a reference via PrivateName from the MutationObserver to the callback function.
- dom/MutationCallback.idl: Removed. Neither JSC nor V8 use an IDL file to generate this class any more.
- 12:05 PM Changeset in webkit [141295] by
-
- 5 edits in trunk/Source
Structure::m_outOfLineCapacity is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=108206
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We can calculate our out of line capacity by using the outOfLineSize and our knowledge about our resize policy.
According to GDB, this knocks Structures down from 136 bytes to 128 bytes (I'm guessing the extra bytes are from
better alignment of object fields), which puts Structures in a smaller size class. Woohoo! Looks neutral on our
benchmarks.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC):
(JSC::Structure::suggestedNewOutOfLineStorageCapacity):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::addPropertyWithoutTransition):
- runtime/Structure.h:
(Structure):
(JSC::Structure::outOfLineCapacity):
(JSC::Structure::totalStorageCapacity):
Source/WTF:
We're adding a new function that gives us the ability to round a value up to the next power of a certain base.
- wtf/MathExtras.h:
(WTF::roundUpToPowerOf):
- 12:03 PM Changeset in webkit [141294] by
-
- 2 edits in trunk/LayoutTests
[EFL] Gardening: Add expectations for flaky crashers
https://bugs.webkit.org/show_bug.cgi?id=108359
Unreviewed gardening: add a bunch of flaky results.
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-30
- platform/efl-wk2/TestExpectations:
- 12:01 PM Changeset in webkit [141293] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for a couple of fullscreen tests, probably
regressed with r141265.
Adding a crash expectation for an HTTP test that regressed with r141136.
- platform/gtk/TestExpectations:
- 11:41 AM Changeset in webkit [141292] by
-
- 10 edits in trunk/Source/WebCore
Remove willAddAuthorShadowRoot and replace with alwaysCreateUserAgentShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=108248
Reviewed by Dimitri Glazkov.
The only reason willAddAuthorShadowRoot exists is so that a handful of
other elements can create the user agent shadow root right before the
author shadow root is created. Instead of providing this generic hook
just expose a virtual method on Element that requests this behavior.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::createShadowRoot):
- dom/Element.h:
(Element):
(WebCore::Element::alwaysCreateUserAgentShadowRoot): Added.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Remove willAddAuthorShadowRoot notification.
- html/HTMLButtonElement.cpp:
- html/HTMLButtonElement.h:
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- 11:39 AM Changeset in webkit [141291] by
-
- 12 edits7 moves in trunk/Source/WebCore
[HarfBuzz] Naming fixes after removing old HarfBuzz code
https://bugs.webkit.org/show_bug.cgi?id=108170
Reviewed by Tony Chang.
Since the old harfbuzz code is gone in r141241, it makes sense to get rid
of the now unnecessray NG suffix in a number of places. While at it,
I am also fixing some naming inconsistencies.
Renamed all occurences of HarfBuzzNG* to HarfBuzz*,
renamed lowercase variants of harfbuzz* in variable and function names to camel-case harfBuzz*,
moved files in platform/graphics/harfbuzz/ng/* one level up and removed ng folder.
Updated corresponding entries in Chromium, GTK and EFL build system files.
No new tests, no change in behavior.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
- platform/graphics/FontPlatformData.cpp:
- platform/graphics/FontPlatformData.h:
(WebCore):
(FontPlatformData):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::harfBuzzFace):
- platform/graphics/freetype/FontPlatformData.h:
(FontPlatformData):
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::harfBuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::harfBuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(WebCore):
(FontPlatformData):
- platform/graphics/harfbuzz/HarfBuzzFace.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp.
(WebCore):
(FaceCacheEntry):
(WebCore::FaceCacheEntry::create):
(WebCore::FaceCacheEntry::~FaceCacheEntry):
(WebCore::FaceCacheEntry::face):
(WebCore::FaceCacheEntry::glyphCache):
(WebCore::FaceCacheEntry::FaceCacheEntry):
(WebCore::harfBuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):
(WebCore::findScriptForVerticalGlyphSubstitution):
(WebCore::HarfBuzzFace::setScriptForVerticalGlyphSubstitution):
- platform/graphics/harfbuzz/HarfBuzzFace.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h.
(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):
- platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCairo.cpp.
(WebCore):
(CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::CairoFtFaceLocker):
(WebCore::CairoFtFaceLocker::lock):
(WebCore::CairoFtFaceLocker::~CairoFtFaceLocker):
(WebCore::floatToHarfBuzzPosition):
(WebCore::doubleToHarfBuzzPosition):
(WebCore::CairoGetGlyphWidthAndExtents):
(WebCore::harfBuzzGetGlyph):
(WebCore::harfBuzzGetGlyphHorizontalAdvance):
(WebCore::harfBuzzGetGlyphHorizontalOrigin):
(WebCore::harfBuzzGetGlyphExtents):
(WebCore::harfBuzzCairoTextGetFontFuncs):
(WebCore::harfBuzzCairoGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfBuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp.
(WebCore):
(WebCore::HarfBuzzFontData::HarfBuzzFontData):
(HarfBuzzFontData):
(WebCore::SkiaScalarToHarfBuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfBuzzGetGlyph):
(WebCore::harfBuzzGetGlyphHorizontalAdvance):
(WebCore::harfBuzzGetGlyphHorizontalOrigin):
(WebCore::harfBuzzGetGlyphExtents):
(WebCore::harfBuzzSkiaGetFontFuncs):
(WebCore::harfBuzzSkiaGetTable): Also fixed style checker whitespace complaint / indentation.
(WebCore::destroyHarfBuzzFontData):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp.
(WebCore):
(HarfBuzzScopedPtr):
(WebCore::HarfBuzzScopedPtr::HarfBuzzScopedPtr):
(WebCore::HarfBuzzScopedPtr::~HarfBuzzScopedPtr):
(WebCore::HarfBuzzScopedPtr::get):
(WebCore::harfBuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setDrawRange):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::adjustStartPoint):
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun):
(WebCore::HarfBuzzShaper::fillGlyphBuffer):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):
- platform/graphics/harfbuzz/HarfBuzzShaper.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h.
(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::fontData):
(WebCore::HarfBuzzShaper::HarfBuzzRun::startIndex):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::advances):
(WebCore::HarfBuzzShaper::HarfBuzzRun::offsets):
(WebCore::HarfBuzzShaper::HarfBuzzRun::glyphToCharacterIndexes):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
- 11:21 AM Changeset in webkit [141290] by
-
- 3 edits2 adds in trunk
REGRESSION(r136324): Flexbox should relayout flex children when width changes
https://bugs.webkit.org/show_bug.cgi?id=108231
Reviewed by Ojan Vafai.
Source/WebCore:
If the width of a block changes, we need to set relayoutChildren = true
to relayout the children. This broke when we optimized the layout calls
in layoutAndPlaceChildren.
Test: css3/flexbox/width-change-and-relayout-children.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Also reorder the code to match RenderBlock.
The bug fix is to use updateLogicalWidthAndColumnWidth() and its return value to set
relayoutChildren = true.
LayoutTests:
- css3/flexbox/width-change-and-relayout-children-expected.txt: Added.
- css3/flexbox/width-change-and-relayout-children.html: Added.
- 11:19 AM Changeset in webkit [141289] by
-
- 6 edits in tags/Safari-537.26.5
Merged r141045. <rdar://problem/12960662>
- 11:18 AM Changeset in webkit [141288] by
-
- 4 edits in trunk/Source/WebCore
GraphicsContext3DCG needs to copy image data in paintToCanvas
https://bugs.webkit.org/show_bug.cgi?id=108310
Reviewed by Simon Fraser.
Make the CG implementation of GraphicsContext3D::paintToCanvas copy image data
before drawing if we're drawing into an accelerated context, matching the fix made
in http://trac.webkit.org/changeset/106095 for 2D canvas.
No new tests, depends on acceleration and would be flaky at best.
- platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D): Make CG's paintToCanvas take a GraphicsContext instead of a CGContextRef.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::releaseImageData): Added.
(WebCore::GraphicsContext3D::paintToCanvas): Copy image data if the destination is
an accelerated context. Also, use GraphicsContext API instead of CGContext.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- 11:12 AM Changeset in webkit [141287] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Fix Win build after r141177
https://bugs.webkit.org/show_bug.cgi?id=108325
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-30
Reviewed by Anders Carlsson.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::sendOutgoingMessage):
- 11:02 AM Changeset in webkit [141286] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
inspector/editor/text-editor-ctrl-movements.html is timing out after r141245.
- platform/chromium/TestExpectations:
- 10:54 AM Changeset in webkit [141285] by
-
- 4 edits in trunk/WebKitLibraries
Update WebKitSystemInterface for <rdar://problem/13111288>.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- WebKitSystemInterface.h: Removed WKEnterPluginSandbox, which has been unused now.
- 10:52 AM Changeset in webkit [141284] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Screenshot is clipped when content is smaller than the desintation size
https://bugs.webkit.org/show_bug.cgi?id=107735
Patch by Ed Baker <edbaker@rim.com> on 2013-01-30
Reviewed by Rob Buis.
Internal PR #284662
Don't scale the transformed content rect when the content is smaller than the destination
size. Scale the graphics context when it has a scale factor that isn't 1.0.
Internally reviewed by Andrew Lo
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
- 10:52 AM Changeset in webkit [141283] by
-
- 4 edits in tags/Safari-537.26.5/Source
Versioning.
- 10:40 AM Changeset in webkit [141282] by
-
- 1 copy in tags/Safari-537.26.5
New Tag.
- 10:20 AM Changeset in webkit [141281] by
-
- 2 edits in trunk/Source/WebCore
MediaPlayerPrivateQTKit claims it supports application/x-diskcopy, breaking downloads.
https://bugs.webkit.org/show_bug.cgi?id=108237
Reviewed by Eric Carlson.
Disclaim any non-'video/' or 'audio/' types which QTKit purports to support.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::addFileTypesToCache):
- 9:55 AM Changeset in webkit [141280] by
-
- 2 edits in trunk/Source/WebCore
Do not restart the matched properties cache timer if active
https://bugs.webkit.org/show_bug.cgi?id=108345
Reviewed by Andreas Kling.
StyleResolver::addToMatchedPropertiesCache() keeps resetting the timer as more than
matchedDeclarationCacheAdditionsBetweenSweeps entries are added. When armed, we should let
the timer expire at its scheduled time - otherwise it may never get a chance to fire if
entries keep getting added.
No new tests. This is a long lived timer (1min) which makes testing impractical.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::addToMatchedPropertiesCache):
- 9:55 AM Changeset in webkit [141279] by
-
- 5 edits in branches/chromium/1364/Source/WebKit/chromium
Merge 141252
BUG=163887
[Chromium] Fix find in page rects for overflowing content.
https://bugs.webkit.org/show_bug.cgi?id=104924
Reviewed by Julien Chaffraix.
If a div has overflowing content, we should only normalise its
coordinates against the renderview or the containing scrollable block.
TEST=WebFrameTest.FindInPageMatchRects
- src/FindInPageCoordinates.cpp:
(WebKit::enclosingScrollableAncestor):
Helper function to find the enclosing containing block with an overflow clip.
(WebKit::toNormalizedRect):
Pass in the container as an argument.
(WebKit::findInPageRectFromAbsoluteRect):
Compute the container for toNormalizedRect using enclosingScrollableAncestor.
- tests/WebFrameTest.cpp:
Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
- tests/data/find.html:
Add test case for <select> element.
- tests/data/find_in_page_frame.html:
Add test cases:
- Result 15, 16 tests that containing <div> with style float:left and height:0px does not impact coordinate normalization.
- Result 17, 18 tests that matches with absolute positioning are normalized containing relative positioned block, even if there is a closer parent block with overflow clip.
- Result 19 adds a test case for <select> element.
TBR=jknotten@chromium.org
Review URL: https://codereview.chromium.org/12092069
- 9:39 AM Changeset in webkit [141278] by
-
- 2 edits in trunk/Source/WebCore
Temporarily disable assertions related to clip rect computation in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=108265
Reviewed by Dean Jackson.
These assertions are killing the test bots, so disable them temporarily
until we figure out the underlying bug (tracked by https://bugs.webkit.org/show_bug.cgi?id=103432).
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
- 9:15 AM Changeset in webkit [141277] by
-
- 7 edits in trunk/Source/WebCore
Element::areAuthorShadowsAllowed should be private
https://bugs.webkit.org/show_bug.cgi?id=108298
Reviewed by Darin Adler.
There's no reason for areAuthorShadowsAllowed to be exposed publically
on Element since it just controls the behavior of createShadowRoot. Make
it private and fix all places where it wasn't in subclasses.
No new tests, just refactoring.
- dom/Element.h:
(WebCore::Element::areAuthorShadowsAllowed): Made private.
- html/HTMLFrameElementBase.h:
(HTMLFrameElementBase):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/HTMLMediaElement.h:
(HTMLMediaElement):
- html/HTMLPlugInElement.h:
(HTMLPlugInElement):
- svg/SVGElement.h:
(SVGElement):
- 9:12 AM Changeset in webkit [141276] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Webpage was cut off after rotating to landscape and then rotating back to portrait on specific website
https://bugs.webkit.org/show_bug.cgi?id=108281
PR 284985
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-01-30
Reviewed by Rob Buis.
Internally reviewed by Jacky Jiang.
Return correct fixedLayoutSize when overflow exceeds contents size.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
- 8:58 AM Changeset in webkit [141275] by
-
- 11 edits in trunk
REGRESSION (r141051): Broke plugin support on non-Mac WebKit2 Ports
https://bugs.webkit.org/show_bug.cgi?id=108182
Reviewed by Sam Weinig.
Source/WebKit2:
Send the plugin path to the PluginProcess as a parameter.
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
LayoutTests:
Unskip failing tests.
- platform/efl-wk2/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- 8:52 AM Changeset in webkit [141274] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API inside ewk_window_features
https://bugs.webkit.org/show_bug.cgi?id=107924
Reviewed by Sam Weinig.
Use C API inside ewk_window_features instead of accessing
internal C++ classes directly, to avoid violating API
layering.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::createNewPage):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/ewk_window_features.cpp:
(EwkWindowFeatures::EwkWindowFeatures):
(getWindowFeatureValue):
(EwkWindowFeatures::getWindowFeatureBoolValue):
(EwkWindowFeatures::getWindowFeatureDoubleValue):
(ewk_window_features_geometry_get):
- UIProcess/API/efl/ewk_window_features_private.h:
(EwkWindowFeatures::create):
(EwkWindowFeatures::geometry):
(EwkWindowFeatures::setGeometry):
(EwkWindowFeatures):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::createNewPage):
- 8:15 AM Changeset in webkit [141273] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Script Profiler: Make profiler output typed.
https://bugs.webkit.org/show_bug.cgi?id=102792
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-30
Reviewed by Yury Semikhatsky.
Currently fields "head" and "bottomUpHead" of Profile object
returned by Profiler.getCPUProfile is untyped (type = object).
That's not good both for client side (protocol users may
only guess on output content) and backend side (field names
are hardcoded in source code).
This patch defines "head" and "bottomUpHead" to be of new
"CPUProfileNode" type and updates serialization code to use
builders to create output.
- bindings/js/ScriptProfile.cpp: Used buiders for serialization.
- bindings/js/ScriptProfile.h: Ditto.
- bindings/v8/ScriptProfile.cpp: Ditto.
- bindings/v8/ScriptProfile.h: Ditto.
- inspector/Inspector.json: Added and used new ProfileNode type.
- 8:12 AM Changeset in webkit [141272] by
-
- 7 edits1 delete in trunk/Source/WebCore
Web Inspector: remove NativeHeapGraph.js
https://bugs.webkit.org/show_bug.cgi?id=108342
Reviewed by Pavel Feldman.
NativeHeapGraph.js was removed as NativeHeapSnapshot.js provides more
features and shares its implementation with JSHeapSnapshot.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/NativeHeapGraph.js: Removed.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileHeader.prototype.startSnapshotTransfer):
- inspector/front-end/ProfilesPanel.js:
- inspector/front-end/WebKit.qrc:
- 8:11 AM QtWebKitBuildBots edited by
- (diff)
- 7:33 AM Changeset in webkit [141271] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=108341
Add a few failing results for EFL.
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-30
- platform/efl/TestExpectations:
- 7:12 AM Changeset in webkit [141270] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Sidebar splitter is invisible in Elements and Sources panels
https://bugs.webkit.org/show_bug.cgi?id=108331
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
This was a regression caused by https://bugs.webkit.org/show_bug.cgi?id=108181.
The splitter element did not get the correct class at the initialization.
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarPosition):
- 7:10 AM Changeset in webkit [141269] by
-
- 10 edits3 adds in trunk
Web Inspector: Filters on Console panel
https://bugs.webkit.org/show_bug.cgi?id=107813
Source/WebCore:
The problem is that third-party libraries may spam javascript console with internal
messages. Now there's filter context-menu option, which allows to hide/show messages
sent from specific scripts or urls.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.appendUndefined):
(WebInspector.ConsoleMessageImpl.prototype._printArray):
(WebInspector.ConsoleMessageImpl.prototype._highlightSearchResultsInElement):
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get var):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.set get contextMenu):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleGroup.prototype.addMessage):
- inspector/front-end/ContextMenu.js:
(WebInspector.ContextMenuItem.prototype.isEnabled):
(WebInspector.ContextMenuItem.prototype.setEnabled):
- inspector/front-end/Settings.js:
LayoutTests:
The problem is that third-party libraries may spam javascript console
with internal messages. Now there's filter context-menu option, which
allows to hide/show messages sent from specific scripts or urls.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
- http/tests/inspector/console-test.js:
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessages):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithStyles):
(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithClasses):
(initialize_ConsoleTest.InspectorTest.expandConsoleMessages):
(initialize_ConsoleTest.InspectorTest.checkConsoleMessagesDontHaveParameters):
(initialize_ConsoleTest):
- http/tests/inspector/stacktraces/resources/stacktrace-test.js:
(test.addMessage):
(test):
- inspector/console/console-filter-test-expected.txt: Added.
- inspector/console/console-filter-test.html: Added.
- inspector/console/resources/log-source.js: Added.
(log2):
- 7:07 AM Changeset in webkit [141268] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix minimal build after r141259.
Unreviewed build fix.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearNotificationPermissions):
- 7:06 AM Changeset in webkit [141267] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 141160
REGRESSION (r135628-135632): Double box shadow failure to render
https://bugs.webkit.org/show_bug.cgi?id=107833
Reviewed by Simon Fraser.
Source/WebCore:
Regression caused by http://trac.webkit.org/changeset/135629
The regression was due to faulty occlusion logic that was assuming
that drawing the background color of a render box background layer
could be skipped when the same layer also has an opaque image attached.
In the case where the background color is drawn for the purpose of
rendering a box shadow, the shadow is typically not
completely occluded by the background image because of the shadow
blur and/or offset. This patch fixes the problem by not culling a
background draw if it is used to draw a box shadow.
Test: fast/backgrounds/gradient-background-shadow.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Changing occlusion culling test to never cull background color
draw if it is used to draw a box shadow. This is because box shadows
can draw outside the border fill region.
LayoutTests:
New ref test verifies that box shadow is drawn when
background is an opaque image. Test uses an blue gradient
as background image. Reference uses blue background color.
- fast/backgrounds/gradient-background-shadow-expected.html: Added.
- fast/backgrounds/gradient-background-shadow.html: Added.
TBR=junov@google.com
Review URL: https://codereview.chromium.org/12089070
- 7:00 AM Changeset in webkit [141266] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=108340.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-01-30
- platform/qt/TestExpectations:
- 6:55 AM Changeset in webkit [141265] by
-
- 18 edits2 adds in trunk/Source
[GStreamer] USE(NATIVE_FULLSCREEN_VIDEO) support
https://bugs.webkit.org/show_bug.cgi?id=106760
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Initial support for NATIVE_FULLSCREEN_VIDEO in the GStreamer media
player. A new FullscreenVideoControllerGStreamer class is
introduced, ports interested to implement native fullscreen video
support should inherit from it (see FullscreenVideoControllerGtk)
and hook it in the MediaPlayerPrivateGStreamer backend.
The GStreamerGWorld port to GStreamer 1.x is partly based on a
patch by Sebastian Dröge <sebastian.droge@collabora.com>.
- GNUmakefile.am: Enable NATIVE_FULLSCREEN_VIDEO support.
- GNUmakefile.list.am: New
FullscreenVideoController{GStreamer,Gtk} modules.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp: Added.
(WebCore):
(WebCore::playerVolumeChangedCallback): Playbin notify::volume
signal callback.
(WebCore::playerMuteChangedCallback): Playbin notify::mute signal callback.
(WebCore::FullscreenVideoControllerGStreamer::FullscreenVideoControllerGStreamer):
(WebCore::FullscreenVideoControllerGStreamer::~FullscreenVideoControllerGStreamer):
(WebCore::FullscreenVideoControllerGStreamer::enterFullscreen):
Switch GStreamerGWorld to full screen, hook in to playbin's
notify::volume and mute signals and initialize the full screen window.
(WebCore::FullscreenVideoControllerGStreamer::exitFullscreen):
Destroy the full screen window, disconnect from playbin signals
and switch GStreamerGWorld out of full screen.
(WebCore::FullscreenVideoControllerGStreamer::exitOnUserRequest):
Trigger exit from full screen mode. This method is meant to be
called when the user explicitely requests to exit from full screen
by pressing a key or something similar.
(WebCore::FullscreenVideoControllerGStreamer::togglePlay): Switch
between play and pause states. Useful for child classes.
(WebCore::FullscreenVideoControllerGStreamer::increaseVolume):
Useful for child classes as well.
(WebCore::FullscreenVideoControllerGStreamer::decreaseVolume): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::setVolume): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::timeToString): Ditto.
- platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h: Added.
(WebCore):
(FullscreenVideoControllerGStreamer):
(WebCore::FullscreenVideoControllerGStreamer::playStateChanged):
To be implemented by child class to reflect the player's state changed.
(WebCore::FullscreenVideoControllerGStreamer::volumeChanged): To
be implemented by child class as well.
(WebCore::FullscreenVideoControllerGStreamer::muteChanged): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::initializeWindow): Ditto.
(WebCore::FullscreenVideoControllerGStreamer::destroyWindow): Ditto.
- platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::gstGWorldSyncMessageCallback): Adapt for GStreamer video
overlay API changes.
(WebCore::GStreamerGWorld::GStreamerGWorld):
gst_bus_set_sync_handler takes one more argument in GStreamer 1.x.
(WebCore::GStreamerGWorld::enterFullscreen): ffmpegcolorspace was
renamed to videoconvert in GStreamer 1.x and the tee src pad
template was renamed to src_%u. There is no need to send a new
segment query either.
(WebCore):
(WebCore::gstGWorldPadProbeCallback): Remove the platform video
sink branch once the tee source pad starting it has been blocked.
(WebCore::GStreamerGWorld::exitFullscreen): Refactor to use an
asynchronous pad probe.
(WebCore::GStreamerGWorld::removePlatformVideoSink): Refactored
from exitFullscreen.
(WebCore::GStreamerGWorld::setWindowOverlay): Adapt for GStreamer video
overlay API changes.
- platform/graphics/gstreamer/GStreamerGWorld.h:
(GStreamerGWorld):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Hook NATIVE_FULLSCREEN_VIDEO support.
(WebCore::MediaPlayerPrivateGStreamer::volume): Playbin volume
query used by the FullscreenVideoController.
(WebCore):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore):
(MediaPlayerPrivateGStreamer): volume(), muted() and MediaPlayer
accessor methods added. NATIVE_FULLSCREEN_VIDEO methods added as well.
(WebCore::MediaPlayerPrivateGStreamer::canEnterFullscreen):
(WebCore::MediaPlayerPrivateGStreamer::mediaPlayer):
- platform/graphics/gstreamer/PlatformVideoWindow.h: Re-enable
module if NATIVE_FULLSCREEN_VIDEO is turned on.
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Ditto.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Re-enable
GStreamerGWorld support.
(_WebKitVideoSinkPrivate):
(webkitVideoSinkRender):
- platform/graphics/gstreamer/VideoSinkGStreamer.h: Ditto.
Source/WebKit/qt:
Build fixes for GStreamer NATIVE_FULLSCREEN_VIDEO support. Some
more changes will be needed to use the new
FullscreenVideoController though.
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
- WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore):
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):
- WebCoreSupport/FullScreenVideoQt.h:
(WebCore):
(FullScreenVideoQt):
- 6:49 AM Changeset in webkit [141264] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=108340.
- platform/qt/TestExpectations:
- 6:48 AM Changeset in webkit [141263] by
-
- 4 edits in trunk/Source
[Qt] Fix Qt/Mac build after r141024 and r141037
https://bugs.webkit.org/show_bug.cgi?id=108318
Reviewed by Kentaro Hara.
Source/WebKit2:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::platformInvalidate):
Replace nullptr with 0 to allow compiling without C++11 support.
Source/WTF:
- wtf/Functional.h:
Make sure Block.h is included and its functionality
is enabled for Qt on Mac.
- 6:36 AM Changeset in webkit [141262] by
-
- 6 edits in branches/chromium/1364/Source
Promote composited scrolling render layers to stacking containers.
https://bugs.webkit.org/show_bug.cgi?id=106142
https://code.google.com/p/chromium/issues/detail?id=167201
- 6:31 AM Changeset in webkit [141261] by
-
- 12 edits6 adds in trunk/LayoutTests
[Chromium] Unreviewed gaedening.
Updated results after http://trac.webkit.org/changeset/141243.
- platform/chromium-linux/fast/repaint/4774354-expected.png:
- platform/chromium-linux/fast/repaint/4776765-expected.png:
- platform/chromium-linux/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/4774354-expected.png:
- platform/chromium-mac-lion/fast/repaint/4776765-expected.png:
- platform/chromium-mac-lion/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/repaint/4774354-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/4776765-expected.png:
- platform/chromium-mac/fast/repaint/4774354-expected.png:
- platform/chromium-mac/fast/repaint/4776765-expected.png:
- platform/chromium-mac/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-mac/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/chromium-win/fast/repaint/4774354-expected.png:
- platform/chromium-win/fast/repaint/4776765-expected.png:
- platform/chromium-win/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/chromium-win/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/chromium/TestExpectations:
- 6:03 AM Changeset in webkit [141260] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: beautify file selector dialog to render as two rows
https://bugs.webkit.org/show_bug.cgi?id=108335
Reviewed by Vsevolod Vlasov.
Go-to-file is now rendered in two rows.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.renderAsTwoRows):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.OpenResourceDialog.show):
- inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl):
(WebInspector.ViewportControl.prototype.refresh):
- inspector/front-end/filteredItemSelectionDialog.css:
(.filtered-item-list-dialog > input):
(.filtered-item-list-dialog > div.progress):
(.filtered-item-list-dialog > div.container):
(.filtered-item-list-dialog-item):
(.filtered-item-list-dialog-subtitle):
(.filtered-item-list-dialog-item.one-row .filtered-item-list-dialog-subtitle):
(.filtered-item-list-dialog-item.two-rows):
(.filtered-item-list-dialog-item.selected):
(.filtered-item-list-dialog-item span.highlight):
- 5:59 AM Changeset in webkit [141259] by
-
- 17 edits in trunk
[Qt][WK1] Support better testing of Web Notifications
https://bugs.webkit.org/show_bug.cgi?id=107696
Reviewed by Jocelyn Turcotte.
Source/WebKit/qt:
Implement support for the DRT to clear notification permissions.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::clearNotificationPermissions):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::clearCachedPermissions):
(WebCore):
- WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationPresenterClientQt):
Tools:
Do not dump notification output to the console by default, instead allow the
tests that need this feature to enable it.
Implement denyWebNotificationPermission and removeAllWebNotificationPermissions.
Remove unused m_desktopNotificationAllowedOrigins variable.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::TestRunner):
(TestRunner::reset):
(TestRunner::dumpNotifications):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
LayoutTests:
Unskip the now working tests in http/tests/notifications.
Skip four tests that still fail on WebKit1.
Update tests that need notifications dumped.
- fast/notifications/notifications-click-event.html:
- fast/notifications/notifications-display-close-events.html:
- fast/notifications/notifications-no-icon.html:
- fast/notifications/notifications-replace.html:
- fast/notifications/notifications-rtl.html:
- fast/notifications/notifications-with-permission.html:
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 4:47 AM Changeset in webkit [141258] by
-
- 9 edits1 add in trunk/Source/WebCore
Web Inspector: migrate file selection dialog to the viewport.
https://bugs.webkit.org/show_bug.cgi?id=108313
Reviewed by Vsevolod Vlasov.
Otherwise it takes too long to render.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.focus):
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype._itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown.updateSelection):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemCount):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
- inspector/front-end/ViewportControl.js: Added.
(WebInspector.ViewportControl):
(WebInspector.ViewportControl.Provider):
(WebInspector.ViewportControl.Provider.prototype.itemCount):
(WebInspector.ViewportControl.Provider.prototype.itemElement):
(WebInspector.ViewportControl.prototype.contentElement):
(WebInspector.ViewportControl.prototype.refresh):
(WebInspector.ViewportControl.prototype._onScroll):
(WebInspector.ViewportControl.prototype.rowsPerViewport):
(WebInspector.ViewportControl.prototype.firstVisibleIndex):
(WebInspector.ViewportControl.prototype.lastVisibleIndex):
(WebInspector.ViewportControl.prototype.renderedElementAt):
(WebInspector.ViewportControl.prototype.scrollItemIntoView):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/filteredItemSelectionDialog.css:
(.js-outline-dialog .container div.item.selected):
(.js-outline-dialog .container div.item span.highlight):
- inspector/front-end/inspector.html:
- 4:43 AM Changeset in webkit [141257] by
-
- 4 edits2 adds2 deletes in trunk
Web Inspector: implement highlight range API
https://bugs.webkit.org/show_bug.cgi?id=108317
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/editor/text-editor-highlight-api.html
Introduce RangeHighlightDescriptor class and implement Highlight Range
api.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.removeHighlight):
(WebInspector.DefaultTextEditor.prototype.highlightRange):
(WebInspector.TextEditorMainPanel.prototype.removeHighlight):
(WebInspector.TextEditorMainPanel.prototype.highlightRange):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.affectsLine):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):
(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.cssClass):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._removeHighlight):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.highlightRange):
(WebInspector.TextEditor.prototype.removeHighlight):
LayoutTests:
Added test cases to the existed test to cover highlight range
functionality.
- inspector/editor/text-editor-highlight-api-expected.txt: Added.
- inspector/editor/text-editor-highlight-api.html: Added.
- inspector/editor/text-editor-highlight-regexp-expected.txt: Removed.
- inspector/editor/text-editor-highlight-regexp.html: Removed.
- 4:39 AM Changeset in webkit [141256] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/accessibility/aria-combobox-expected.txt: Rebaselining after r141186.
- 4:27 AM Changeset in webkit [141255] by
-
- 12 edits3 deletes in trunk/Source
[Qt] Remove QT4_UNICODE related code paths
https://bugs.webkit.org/show_bug.cgi?id=108316
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Get rid of QT4_UNICODE and any related code paths. The Qt port
requires Qt5 and ICU these days. This also allows for the removal
of TextCodecQt.
- Target.pri:
- platform/KURL.cpp:
(WebCore::appendEncodedHostname):
- platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps):
- platform/text/qt/TextCodecQt.cpp: Removed.
- platform/text/qt/TextCodecQt.h: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in: The feature macro has been removed.
Source/WTF:
Get rid of QT4_UNICODE and any related code paths. The Qt port
requires Qt5 and ICU these days.
- WTF.gypi:
- WTF.pro:
- wtf/unicode/Unicode.h:
- wtf/unicode/qt4/UnicodeQt4.h: Removed.
- 4:21 AM Changeset in webkit [141254] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Make WebCorePrefix.h build on iOS
<http://webkit.org/b/108224>
Reviewed by Sam Weinig.
- WebCorePrefix.h:
- Include <wtf/Platform.h>.
- Do not include <CoreServices/CoreServices.h> on iOS.
- Include <Foundation/Foundation.h> instead of <Cocoa/Cocoa.h> on iOS.
- 4:20 AM Changeset in webkit [141253] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r141156.
- PlatformWinCE.cmake:
- 4:13 AM Changeset in webkit [141252] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Fix find in page rects for overflowing content.
https://bugs.webkit.org/show_bug.cgi?id=104924
Reviewed by Julien Chaffraix.
If a div has overflowing content, we should only normalise its
coordinates against the renderview or the containing scrollable block.
TEST=WebFrameTest.FindInPageMatchRects
- src/FindInPageCoordinates.cpp:
(WebKit::enclosingScrollableAncestor):
Helper function to find the enclosing containing block with an overflow clip.
(WebKit::toNormalizedRect):
Pass in the container as an argument.
(WebKit::findInPageRectFromAbsoluteRect):
Compute the container for toNormalizedRect using enclosingScrollableAncestor.
- tests/WebFrameTest.cpp:
Add expectations for new tests in WebFrameTest::FindInPageMatchRects and WebFrameTest::FindInPage.
- tests/data/find.html:
Add test case for <select> element.
- tests/data/find_in_page_frame.html:
Add test cases:
- Result 15, 16 tests that containing <div> with style float:left and height:0px does not impact coordinate normalization.
- Result 17, 18 tests that matches with absolute positioning are normalized containing relative positioned block, even if there is a closer parent block with overflow clip.
- Result 19 adds a test case for <select> element.
- 4:07 AM Changeset in webkit [141251] by
-
- 7 edits3 moves2 adds in trunk/LayoutTests
Web Inspector: move heap profiler protocol tests into heap-profiler subfolder
https://bugs.webkit.org/show_bug.cgi?id=108324
Reviewed by Vsevolod Vlasov.
Moved heap profiler protocol tests into LayoutTests/inspector-protocol/heap-profiler
- inspector-protocol/heap-profiler/resources/page-with-function.html: Renamed from LayoutTests/inspector-protocol/resources/page-with-function.html.
- inspector-protocol/heap-profiler/take-heap-snapshot-expected.txt: Renamed from LayoutTests/inspector-protocol/take-heap-snapshot-expected.txt.
- inspector-protocol/heap-profiler/take-heap-snapshot.html: Renamed from LayoutTests/inspector-protocol/take-heap-snapshot.html.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 4:01 AM Changeset in webkit [141250] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Canvas] support instrumenting canvases in iframes (frontend side)
https://bugs.webkit.org/show_bug.cgi?id=108319
Reviewed by Pavel Feldman.
Add a frame selector to choose between frames with canvases. Show this selector in the status
bar only if there are 2 or more frames with canvses. Otherwise, assume silently the only
frame with canvases (most common use case).
- English.lproj/localizedStrings.js:
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.get statusBarItems):
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._frameAdded):
(WebInspector.CanvasProfileType.prototype._addFrame):
(WebInspector.CanvasProfileType.prototype._frameRemoved):
(WebInspector.CanvasProfileType.prototype._contextCreated):
(WebInspector.CanvasProfileType.prototype._selectedFrameId):
(WebInspector.CanvasProfileType.prototype._dispatchViewUpdatedEvent):
(WebInspector.CanvasDispatcher):
(WebInspector.CanvasDispatcher.prototype.contextCreated):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
(WebInspector.ProfilesPanel.prototype._updateProfileTypeSpecificUI):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarComboBox.prototype.size):
- 3:59 AM Changeset in webkit [141249] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: Change the Elements panel sidebar layout based on its aspect ratio.
https://bugs.webkit.org/show_bug.cgi?id=108181
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Sidebar aspect ratio proved to be a better trigger for the sidebar layout change that the docking mode.
Moved the sidebar layout handling completely into WebInspector.SidebarView which now only accepts
two positions: Start (corresponding to Left or Top) and End (corresponding to Right or Bottom).
No new tests.
- inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView):
- inspector/front-end/DockController.js:
(WebInspector.DockController.prototype._updateUI):
(WebInspector.DockController.prototype._toggleDockState):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.onResize):
- inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView):
- inspector/front-end/MemoryStatistics.js:
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.createSidebarView):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype.setAutoOrientation):
(WebInspector.SidebarView.prototype._updateSidebarPosition):
(WebInspector.SidebarView.prototype.onResize):
- 3:58 AM Changeset in webkit [141248] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port SharedTimerWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=103724
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around some parts of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/SharedTimerWin.cpp:
(WebCore):
(WebCore::TimerWindowWndProc):
(WebCore::initializeOffScreenTimerWindow):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- platform/wince/SharedTimerWinCE.cpp: Removed.
- 3:56 AM Changeset in webkit [141247] by
-
- 4 edits2 adds in trunk
[EFL][Qt][WebGL] Avoid deleting an uncreated canvas.
https://bugs.webkit.org/show_bug.cgi?id=106878
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-30
Reviewed by Benjamin Poulain.
Source/WebKit2:
setContentsToCanvas is responsible for marking canvas for creation or deletion.
The issue here is that the canvas is marked for deletion even though it has not
been created. This causes an assert in LayerTreeRenderer::destroyCanvas.
This patch adds a seperate check to ensure that CoordinatedGraphicsLayer
tries to issue a request for canvas deletion only after request for canvas
creation has been handled.
New test: fast/canvas/webgl/canvas-resize-crash.html
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas):
(WebCore::CoordinatedGraphicsLayer::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::fixedToViewport):
LayoutTests:
- fast/canvas/webgl/canvas-resize-crash-expected.txt: Added.
- fast/canvas/webgl/canvas-resize-crash.html: Added.
- 3:55 AM Changeset in webkit [141246] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp: Include GraphicsLayerTextureMapper.h
as a forwarding header from WebCore.
- 3:53 AM Changeset in webkit [141245] by
-
- 7 edits2 adds in trunk
Source/WebCore: ctrl-arrows, ctrl-shift-arrow, ctrl-backspace
Web Inspector: implmenet Ctrl-Arrow/Ctrl-Backspace in DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=107944
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Add ctrl-arrows/ctrl-shift-arrow/ctrl-backspace shortcuts to jump over
and delete words.
New test: inspector/editor/text-editor-ctrl-movements.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):
(WebInspector.DefaultTextEditor.prototype.selection):
(WebInspector.DefaultTextEditor.WordMovementController): Added.
(WebInspector.DefaultTextEditor.WordMovementController.prototype._registerShortcuts):
(WebInspector.DefaultTextEditor.WordMovementController.prototype.):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._rangeForCtrlArrowMove):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlArrow):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlShiftArrow):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlBackspace):
LayoutTests: Web Inspector: implmenet Ctrl-Arrow/Ctrl-Backspace in DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=107944
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Add new test to verify ctrl-arrow/ctrl-backspace behavior. Exclude
this test on the platforms that do not currently support eventSender.
- inspector/editor/text-editor-ctrl-movements-expected.txt: Added.
- inspector/editor/text-editor-ctrl-movements.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 3:49 AM Changeset in webkit [141244] by
-
- 5 edits in trunk
Web Inspector: do not repaint all lines in highlight regex API in DTE
https://bugs.webkit.org/show_bug.cgi?id=108081
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Source/WebCore:
Implement repaintLineRowsAffectedByHighlightDescriptor method that
will go through the visible lineRows and repaint only those of them
which were outdated by highlight change.
Improved test: inspector/editor/text-editor-highlight-regexp.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._repaintLineRowsAffectedByHighlightDescriptor):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineRows):
LayoutTests:
Modify layout test to add a verification that highlight does not
repaint more DefaultTextEditor line rows than it needs to.
- inspector/editor/text-editor-highlight-regexp-expected.txt:
- inspector/editor/text-editor-highlight-regexp.html:
- 3:20 AM Changeset in webkit [141243] by
-
- 5 edits in trunk
REGRESSION (r139282): Caret repainting is broken for text-align: center'd <input>
https://bugs.webkit.org/show_bug.cgi?id=108283
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-30
Reviewed by Tim Horton.
Occasionally carets won't be fully erased when blinking.
There used to be 1-pixel padding but removed since r139282.
This patch adds back the same workaround.
Source/WebCore:
Need to rebaseline test expectations.
- editing/FrameSelection.cpp:
(WebCore::repaintCaretForLocalRect):
LayoutTests:
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- 2:52 AM Changeset in webkit [141242] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
More plugin test cases skipped, failing after r141051,
plugins/document-open.html is not crashing, but currently timing out.
- platform/efl-wk2/TestExpectations:
- 2:45 AM Changeset in webkit [141241] by
-
- 15 edits4 deletes in trunk
[HarfBuzz] Remove the HarfBuzz-old code
https://bugs.webkit.org/show_bug.cgi?id=108077
Reviewed by Benjamin Poulain.
.:
Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
won't be a distinction between ng and non-ng HarfBuzz after
removing the old code.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Removing unused old variant of the HarfBuzz code.
No new tests, no change in functionality.
- GNUmakefile.am: Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ
- WebCore.gypi: Removing ComplexTextControllerHarfBuzz* and HarfBuzzSkia* files,
- platform/graphics/SimpleFontData.h:
(SimpleFontData): USE(HARFBUZZ_NG) renamed to USE(HARFBUZZ).
- platform/graphics/freetype/FontPlatformData.h:
(FontPlatformData): Removing USE(HARFBUZZ_NG) ifdefs.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp: USE(HARFBUZZ_NG) renamed to USE(HARFBUZZ).
(WebCore):
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Removed.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h: Removed.
- platform/graphics/harfbuzz/FontHarfBuzz.cpp: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore::FontPlatformData::harfbuzzFace):
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Removing USE(HARFBUZZ_NG) ifdefs.
(WebCore):
(FontPlatformData):
- platform/graphics/harfbuzz/HarfBuzzSkia.cpp: Removed.
- platform/graphics/harfbuzz/HarfBuzzSkia.h: Removed.
- platform/graphics/skia/SimpleFontDataSkia.cpp: USE(HARFBUZZ_NG) renamed to USE(HARFBUZZ).
(WebCore):
Source/WebKit/chromium:
Rename WTF_USE_HARFBUZZ_NG to WTF_USE_HARFBUZZ since there
won't be a distinction between ng and non-ng HarfBuzz after
removing the old code.
- features.gypi:
- 2:34 AM Changeset in webkit [141240] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Major performance improvement in Qt's PluginDatabase implementation
https://bugs.webkit.org/show_bug.cgi?id=106140
Patch by David Faure <faure@kde.org> on 2013-01-30
Reviewed by Simon Hausmann.
No new tests, only a performance improvement.
- plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo): Don't do a full-fledged load(), load the module directly.
Keep the refcounting as it was before (broken, but otherwise flash crashes).
(WebCore::PluginPackage::load): Use existing module if fetchInfo created it.
- 2:31 AM Changeset in webkit [141239] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
More plugin test cases skipped, failing after r141051,
- 2:20 AM Changeset in webkit [141238] by
-
- 11 edits in trunk/Source
[TexMap] Remove GraphicsLayer in TextureMapperLayer.
https://bugs.webkit.org/show_bug.cgi?id=107073
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Noam Rosenthal.
Source/WebCore:
Remove the dependency of TextureMapperLayer on GraphicsLayer. It is needed to
remove GraphicsLayerTextureMapper in LayerTreeRenderer.
This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).
Covered by existing tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::toTextureMapperLayer):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
Set BackgroundColorChange to m_changeMask instead of ContentChange.
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToSolidColor):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::setShowDebugBorder):
(WebCore::GraphicsLayerTextureMapper::setShowRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::setDebugBorder):
(WebCore::toTextureMapperLayerVector):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
Flush pending changes into TextureMapperLayer.
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):
(WebCore::GraphicsLayerTextureMapper::setFilters):
(WebCore::GraphicsLayerTextureMapper::setBackingStore):
(WebCore::GraphicsLayerTextureMapper::setFixedToViewport):
(WebCore::GraphicsLayerTextureMapper::setRepaintCount):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
(WebCore):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setChildren):
(WebCore::TextureMapperLayer::setMaskLayer):
(WebCore):
(WebCore::TextureMapperLayer::setReplicaLayer):
(WebCore::TextureMapperLayer::setPosition):
(WebCore::TextureMapperLayer::setSize):
(WebCore::TextureMapperLayer::setAnchorPoint):
(WebCore::TextureMapperLayer::setPreserves3D):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::setChildrenTransform):
(WebCore::TextureMapperLayer::setContentsRect):
(WebCore::TextureMapperLayer::setMasksToBounds):
(WebCore::TextureMapperLayer::setDrawsContent):
(WebCore::TextureMapperLayer::setContentsVisible):
(WebCore::TextureMapperLayer::setContentsOpaque):
(WebCore::TextureMapperLayer::setBackfaceVisibility):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setSolidColor):
(WebCore::TextureMapperLayer::setFilters):
(WebCore::TextureMapperLayer::setDebugVisuals):
(WebCore::TextureMapperLayer::setRepaintCount):
(WebCore::TextureMapperLayer::setContentsLayer):
(WebCore::TextureMapperLayer::setAnimations):
(WebCore::TextureMapperLayer::setFixedToViewport):
(WebCore::TextureMapperLayer::setBackingStore):
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
Source/WebKit/efl:
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
- WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
Source/WebKit/gtk:
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Source/WebKit/qt:
Include GraphicsLayerTextureMapper.h to use toTextureMapperLayer().
- WebCoreSupport/TextureMapperLayerClientQt.cpp:
- 2:13 AM Changeset in webkit [141237] by
-
- 10 edits in trunk/Tools
[chromium] move methods from WebTestDelegate to WebTestRunner
https://bugs.webkit.org/show_bug.cgi?id=108309
Reviewed by Adam Barth.
By moving more logic to the TestRunner library, we can share more
code with content shell.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createView):
(WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled):
(WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
(WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::createView):
(WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
(WebViewHost::didStartLoading):
(WebViewHost::didStopLoading):
(WebViewHost::isSmartInsertDeleteEnabled):
(WebViewHost::isSelectTrailingWhitespaceEnabled):
(WebViewHost::reset):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 1:50 AM Changeset in webkit [141236] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Jae Hyun Park to contributor list.
- Scripts/webkitpy/common/config/committers.py:
- 1:41 AM Changeset in webkit [141235] by
-
- 2 edits in trunk/Source/WebCore
getDecorationRootAndDecoratedRoot should add new user agent shadow roots
https://bugs.webkit.org/show_bug.cgi?id=108301
Reviewed by Hajime Morita.
getDecorationRootAndDecoratedRoot intended to add a second UserAgentShadowRoot
to the input, not just reuse the existing one so it could insert icons into
the inputs. Add back in this behavior for now so we can sort out the right thing
to do.
This behavior is wrong in the current architecture since it means if you had an
input type=submit, add an author shadow root, and then change the type to text
and then the browser decorates it your shadow magically becomes inaccessible since
input.shadowRoot is no longer available. This feature is currently only used for
decorating type=password fields in Chromium with an icon for password generation.
No new tests, there's no way to test this because it's only used in Chromium
by way of the ChromeClient.
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::getDecorationRootAndDecoratedRoot):
- 1:37 AM Changeset in webkit [141234] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] WebConsoleMessage is missing LevelDebug (chromium bug 172416)
https://bugs.webkit.org/show_bug.cgi?id=108004
http://code.google.com/p/chromium/issues/detail?id=172416
console.debug triggers a NOTREACHED() assertation in Chromium. This
is because WebCore::MessageLevel contains 5 levels, including debug,
where WebConsoleMessage::Level is missing a "debug" level. Add a
WebConsoleMessage::LevelDebug so that it can get passed up to the
renderer even if it doesn't make use of that now.
Requires another patch to chromium itself to fix chromium bug 172416
but this is a prerequisite.
Also add an enum compile time check to AssertMatchingEnums.cpp,
Patch by Kevin Day <kevinday@gmail.com> on 2013-01-28
Reviewed by Jochen Eisinger.
- public/WebConsoleMessage.h:
- src/AssertMatchingEnums.cpp:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::addMessageToConsole):
- 1:28 AM Changeset in webkit [141233] by
-
- 6 edits in trunk/Source/WebKit/qt
[Qt][WK1] Remember denied permission for notifications
https://bugs.webkit.org/show_bug.cgi?id=107694
Reviewed by Jocelyn Turcotte.
Store denied permissions. According to the specification, we should
ask the user again if he has already granted or denied permission.
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::setNotificationsAllowedForFrame):
- WebCoreSupport/NotificationPresenterClientQt.h:
(NotificationPresenterClientQt):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::setNotificationsAllowedForFrame):
- WebCoreSupport/QWebPageAdapter.h:
- WidgetApi/qwebpage.cpp:
(QWebPage::setFeaturePermission):
- 12:22 AM Changeset in webkit [141232] by
-
- 8 edits in trunk/Source
Coordinated Graphics: Remove m_pendingSyncBackingStores in LayerTreeRenderer.
https://bugs.webkit.org/show_bug.cgi?id=107099
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-30
Reviewed by Noam Rosenthal.
Source/WebCore:
Add GraphicsLayerTextureMapper::setBackingStore() so that
LayerTreeRenderer sets a backing store to GraphicsLayerTextureMapper.
Remove three methods of TextureMapperLayer related to a backing store
because they are no longer used.
Covered by existing compositing tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::setBackingStore):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
Source/WebKit2:
Instead of queuing the setting of backing stores in LayerTreeRenderer,
and then setting them directly to TextureMapperLayer, we allow
GraphicsLayerTextureMapper's existing queuing mechanism to handle that.
Instead of a m_pendingSyncBackingStores queue, we have a m_backingStores
queue which can be applied much more easily to the layer tree.
In addition, LayerTreeRenderer::purgeGLResources() does not call
TextureMapperLayer::clearBackingStoresRecursive() because
TextureMapperLayer will be destructed soon.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::createBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit::LayerTreeRenderer::resetBackingStoreSizeToLayerSize):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::commitPendingBackingStoreOperations):
(WebKit::LayerTreeRenderer::purgeGLResources):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
- 12:22 AM Changeset in webkit [141231] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Correct zoom for focused node when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107599
Reviewed by Adam Barth.
When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
Reapply r141153. Added font-size in html to ensure same caret size across platforms.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
(WebKit):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
- tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
- 12:05 AM Changeset in webkit [141230] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: DTE adds additional space to the end of line.
https://bugs.webkit.org/show_bug.cgi?id=108192
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-30
Reviewed by Pavel Feldman.
Append overlay highlight spans before decorations elements and skip
them in _collectLinesFromDom method.
No new tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):
Jan 29, 2013:
- 11:48 PM Changeset in webkit [141229] by
-
- 2 edits in trunk
Unreviewed GTK build fix after r141175.
- Source/autotools/symbols.filter: Export the WebCore::Element::createShadowRoot symbol.
- 11:28 PM Changeset in webkit [141228] by
-
- 3 edits2 adds in trunk
Renderer is recreated unexpectedly after detach in HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=108150
Reviewed by Kent Tamura.
Source/WebCore:
After r140659, destoryShadowSubtree() may update style in removeChild(). It causes
attaching HTMLInputElement before creating shadowsubtree in HTMLInputElement::updateType().
For safe, destroyShadowSubtree() should be done before detach().
Test: fast/forms/number/number-change-type-on-focus-2.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2-expected.txt: Added.
- 10:31 PM Changeset in webkit [141227] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL Gradening.
fast/events/constructors/composition-event-constructor.html isn't exist anymore.
- platform/efl/TestExpectations:
- 10:30 PM Changeset in webkit [141226] by
-
- 2 edits in trunk/Source/WebCore
Scrollbar and scroll corner composited layers positioned incorrectly
https://bugs.webkit.org/show_bug.cgi?id=108255
Patch by James Robinson <jamesr@chromium.org> on 2013-01-29
Reviewed by Simon Fraser.
ScrollView::updateScrollbars() needs to update the overflow controls composited layers if scrollbars are added
or removed. It was doing this by recording on entry to the function if it had horizontal or vertical scrollbars
and then comparing that to m_horizontal/verticalScrollbar on exit. Unfortunately updateScrollbars is recursive
and exits without running the postamble code when nested on the callstack. As a result, scrollbars may be
added or removed several times during the recursion, possibly leaving the overflow control layers in an
inconsistent state, while ending up with the same set of scrollbars.
This changes the "has anything changed" logic to only compare local state (hasXXXScrollbar vs
newHasXXXScrollbar) so changes in recursive calls are not considered.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
- 10:14 PM Changeset in webkit [141225] by
-
- 2 edits in trunk/Source/WebCore
Convert deprecatedShadowAncestorNode() to shadowHost() in Editor.cpp
https://bugs.webkit.org/show_bug.cgi?id=108287
Reviewed by Hajime Morita.
This is the effort to convert deprecatedShadowAncestorNode() to shadowHost().
Since all the caller object of deprecatedShadowAncestorNode() is in a shadow tree, calling deprecatedShadowAncestorNode()
is equiavalent to calling shadowHost(). Also, for all the occurence of deprecatedShadowAncestorNode(), we don't need to
worry about nested ShadowDOM issues. So directly converting deprecatedShadowAncestorNode() to shadowHost() should be safe.
No new tests, simple refactoring.
- editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
- 10:07 PM Changeset in webkit [141224] by
-
- 3 edits in trunk/Source/WebKit2
Update the expected generated message results
https://bugs.webkit.org/show_bug.cgi?id=108293
Reviewed by Beth Dakin.
- Scripts/webkit2/messages.py:
(generate_messages_header):
- Scripts/webkit2/messages_unittest.py:
- 10:02 PM Changeset in webkit [141223] by
-
- 4 edits2 adds in trunk/Tools
Need a cr-linux debug EWS bot
https://bugs.webkit.org/show_bug.cgi?id=98957
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Eric Seidel.
Added cr-linux-debug-ews bot to webkit-patch, QueueStatusServer and GCE build scripts.
- EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Added.
- QueueStatusServer/app.yaml:
- QueueStatusServer/config/queues.py: Added.
- QueueStatusServer/model/queues.py:
(Queue.init):
(Queue.queue_with_name):
(Queue.all):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumLinuxDebugEWS):
- 9:43 PM Changeset in webkit [141222] by
-
- 3 edits in trunk/Source/JavaScriptCore
Be a little more conservative about emitting table-based switches
https://bugs.webkit.org/show_bug.cgi?id=108292
Reviewed by Filip Pizlo.
Profiling shows we're using op_switch in cases where it's a regression.
- bytecompiler/NodesCodegen.cpp:
(JSC):
(JSC::length):
(JSC::CaseBlockNode::tryTableSwitch):
(JSC::CaseBlockNode::emitBytecodeForBlock):
- parser/Nodes.h:
(CaseBlockNode):
- 9:37 PM Changeset in webkit [141221] by
-
- 3 edits in trunk/Source/WebCore
Rubberband scrolling on news.google.com causes text to blink repeatedly
https://bugs.webkit.org/show_bug.cgi?id=107326
Reviewed by Beth Dakin.
When in the middle of layout, RenderBlock::updateScrollInfoAfterLayout()
could cause us to re-evaluate reasons for compositing, via the call
to updateLayerCompositingState() in RenderLayer::updateScrollInfoAfterLayout().
At this time, when layout is still happening, it's bad to look at render
geometry to decide when to do compositing (e.g. for fixed position); we might
incorrectly conclude that the layer is outside the viewport.
Fix by having RenderLayerCompositing store in a member whether it's safe
to look at layout information. requiresCompositingForPosition() then consults
this bit, and, if it needs to make decisions based on layout but layout is not
complete, it doesn't change the compositing state of the layer.
Not testable, since dumping the layer tree will update layout and mask the bug.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 9:36 PM Changeset in webkit [141220] by
-
- 2 edits in trunk/LayoutTests
Add a failing Mac Lion test expectation per bug 108291.
- platform/mac/TestExpectations:
- 9:17 PM Changeset in webkit [141219] by
-
- 9 edits2 adds in trunk/Source
Introducing WTF::TypeSafeEnum and DatabaseError.
https://bugs.webkit.org/show_bug.cgi?id=108279.
Reviewed by Geoffrey Garen.
Source/WebCore:
DatabaseError will be used later in the webdatabase refactoring effort.
It is currently unused.
No new tests.
- GNUmakefile.list.am:
- Modules/webdatabase/DatabaseError.h: Added.
(WebCore):
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/TypeSafeEnum.h: Added.
(WTF):
(TypeSafeEnum):
(WTF::TypeSafeEnum::TypeSafeEnum):
(WTF::TypeSafeEnum::value):
(WTF::TypeSafeEnum::operator==):
(WTF::TypeSafeEnum::operator!=):
(WTF::TypeSafeEnum::operator<):
(WTF::TypeSafeEnum::operator<=):
(WTF::TypeSafeEnum::operator>):
(WTF::TypeSafeEnum::operator>=):
- 8:55 PM Changeset in webkit [141218] by
-
- 6 edits in trunk/Source/WebCore
Move ShadowRoot creation into ElementShadow
https://bugs.webkit.org/show_bug.cgi?id=108267
Reviewed by Hajime Morita.
Instead of the ShadowRoot::create method doing crazy factory things and
then needing to assert about the state of the ShadowRoot in addShadowRoot,
just create ShadowRoots from inside ElementShadow.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::createShadowRoot): Use addShadowRoot().
(WebCore::Element::ensureUserAgentShadowRoot): Use addShadowRoot().
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Now returns the new ShadowRoot.
- dom/ElementShadow.h:
(ElementShadow):
- dom/ShadowRoot.cpp:
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::create): No longer does the association.
(WebCore::ShadowRoot::setHost): Sets parent tree scope automatically.
- 8:33 PM Changeset in webkit [141217] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking fixed-position-composited-page-scale-down tests as failing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 8:05 PM Changeset in webkit [141216] by
-
- 12 edits2 moves in trunk/Source/WebCore
Rename DBBackend::Server to DatabaseServer.
https://bugs.webkit.org/show_bug.cgi?id=108278.
Rubber stamped by Geoffrey Garen.
This is only a renaming operation as part of the webdatabase refactoring
effort. There is no semantic change.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/DBBackendServer.cpp: Removed.
- Modules/webdatabase/DBBackendServer.h: Removed.
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
- Modules/webdatabase/DatabaseServer.cpp: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.cpp.
(WebCore::DatabaseServer::initialize):
(WebCore::DatabaseServer::setClient):
(WebCore::DatabaseServer::databaseDirectoryPath):
(WebCore::DatabaseServer::setDatabaseDirectoryPath):
(WebCore::DatabaseServer::fullPathForDatabase):
(WebCore::DatabaseServer::hasEntryForOrigin):
(WebCore::DatabaseServer::origins):
(WebCore::DatabaseServer::databaseNamesForOrigin):
(WebCore::DatabaseServer::detailsForNameAndOrigin):
(WebCore::DatabaseServer::usageForOrigin):
(WebCore::DatabaseServer::quotaForOrigin):
(WebCore::DatabaseServer::setQuota):
(WebCore::DatabaseServer::deleteAllDatabases):
(WebCore::DatabaseServer::deleteOrigin):
(WebCore::DatabaseServer::deleteDatabase):
(WebCore::DatabaseServer::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseServer::databaseChanged):
(WebCore::DatabaseServer::closeDatabasesImmediately):
(WebCore::DatabaseServer::interruptAllDatabasesForContext):
(WebCore::DatabaseServer::canEstablishDatabase):
(WebCore::DatabaseServer::addOpenDatabase):
(WebCore::DatabaseServer::removeOpenDatabase):
(WebCore::DatabaseServer::setDatabaseDetails):
(WebCore::DatabaseServer::getMaxSizeForDatabase):
(WebCore):
- Modules/webdatabase/DatabaseServer.h: Copied from Source/WebCore/Modules/webdatabase/DBBackendServer.h.
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::getDatabaseServer):
- 8:02 PM Changeset in webkit [141215] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking terminate-during-sync-operation.html as crashing after r141166.
Unreviwed. Gardening.
- platform/chromium/TestExpectations:
- 7:57 PM Changeset in webkit [141214] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Rebaselining probably after r141136.
Unreviwed. Gardening.
- platform/chromium-win/http/tests/loading/redirect-methods-expected.txt: Added.
- 7:49 PM Changeset in webkit [141213] by
-
- 3 adds in branches/chromium/1364/Source/WebCore/Resources/pagepopups/chromium
Add leftover files for r141211
- 7:41 PM Changeset in webkit [141212] by
-
- 3 edits2 adds in trunk
AX: VoiceOver not reading bullets correctly in the text of notes
https://bugs.webkit.org/show_bug.cgi?id=107980
Reviewed by Ryosuke Niwa.
Source/WebCore:
Accessibility code should not assume that all list markers end with the same "." suffix.
We need to use the actual suffix.
Test: platform/mac/accessibility/listmarker-suffix.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
LayoutTests:
- platform/mac/accessibility/listmarker-suffix-expected.txt: Added.
- platform/mac/accessibility/listmarker-suffix.html: Added.
- 7:36 PM Changeset in webkit [141211] by
-
- 19 edits1 delete in branches/chromium/1364
Merge 140778
Adjust design of the Calendar Picker
https://bugs.webkit.org/show_bug.cgi?id=107507
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: Use pickerCommonChromium.css and calendarPickerChromium.css.
Source/WebCore:
Covered by existing calendar picker appearance tests.
- Resources/pagepopups/calendarPicker.css:
(body): Use bigger font.
(.calendar-picker):
(.month-selector):
(.month-selector svg):
(.month-selector-popup-contents):
(.year-month-button-left .year-month-button):
(.year-month-button-right .year-month-button):
(.days-area-container):
(.days-area):
(.day-label):
(.day):
(.available):
(.month-mode .day):
(.today-clear-area .today-button):
- Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Calculate the width of today-clear-area too.
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo): Use svg icons inside buttons.
(YearMonthController.prototype._attachRightButtonsTo): Use svg icons inside buttons.
(YearMonthController.prototype.setMonth):
(YearMonthController.prototype._handleButtonClick):
- Resources/pagepopups/calendarPickerMac.css: Removed.
- Resources/pagepopups/chromium/calendarPickerChromium.css: Added.
(.year-month-button):
(.days-area-container:focus):
- Resources/pagepopups/chromium/pickerCommonChromium.css: Added. Use Chrome-style buttons.
(button):
(:enabled:hover:-webkit-any(button, input[type='button'])):
(:enabled:active:-webkit-any(button, input[type='button'])):
(:disabled:-webkit-any(button, input[type='button'])):
(:enabled:focus:-webkit-any(button, input[type='button'])):
- WebCore.gyp/WebCore.gyp: Include pickerCommonChromium.css and calendarPickerChromium.css.
- rendering/RenderTheme.cpp: Remove extraCalendarPickerStyleSheet
- rendering/RenderTheme.h: Ditto.
- rendering/RenderThemeChromiumMac.h: Ditto.
- rendering/RenderThemeChromiumMac.mm: Ditto.
(WebCore):
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Include pickerCommonChromium.css and calendarPickerChromium.css.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium/TestExpectations: Marking calendar picker appearance tests as needing rebaseline.
TBR=keishi@webkit.org
BUG=crbug.com/172514
Review URL: https://codereview.chromium.org/12082066
- 7:34 PM Changeset in webkit [141210] by
-
- 2 edits in trunk/LayoutTests
[Chromium] fast/workers/storage crashing after r141166
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 7:29 PM Changeset in webkit [141209] by
-
- 21 edits in trunk/Source/WebKit2
Replace unnecessary ArgumentDecoder member functions with decode overloads
https://bugs.webkit.org/show_bug.cgi?id=102013
Reviewed by Anders Carlsson.
- Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::decode):
- Platform/CoreIPC/ArgumentCoders.h:
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeVariableLengthByteArray):
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/ArgumentDecoder.h:
(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decodeEnum):
(CoreIPC):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::decode):
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::decode):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::decode):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphDecoder::baseDecode):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::HandleArray::decode):
- Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::decode):
- Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::decode):
- Shared/qt/ArgumentCodersQt.cpp:
(CoreIPC::::decode):
- Shared/qt/QtNetworkReplyData.cpp:
(WebKit::QtNetworkReplyData::decode):
- WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeBool):
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit::DecoderAdapter::decodeUInt32):
(WebKit::DecoderAdapter::decodeUInt64):
(WebKit::DecoderAdapter::decodeInt32):
(WebKit::DecoderAdapter::decodeInt64):
(WebKit::DecoderAdapter::decodeFloat):
(WebKit::DecoderAdapter::decodeDouble):
- 7:21 PM Changeset in webkit [141208] by
-
- 18 edits in trunk/LayoutTests
[Chromium] Rebaselining after r141195
Unreviewed. Gardening.
- platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/datetime/datetime-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- 7:20 PM Changeset in webkit [141207] by
-
- 32 edits2 moves in trunk/Source
Rename AbstractDatabase to DatabaseBackend.
https://bugs.webkit.org/show_bug.cgi?id=108275.
Reviewed by Sam Weinig.
This is a pure rename operation as part of the webdatabase refactoring
effort. There is no semantic change in this patch.
Source/WebCore:
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/AbstractDatabase.cpp: Removed.
- Modules/webdatabase/AbstractDatabase.h: Removed.
- Modules/webdatabase/AbstractDatabaseServer.h:
(WebCore):
(AbstractDatabaseServer):
- Modules/webdatabase/DBBackendServer.cpp:
(WebCore::DBBackend::Server::databaseChanged):
(WebCore::DBBackend::Server::addOpenDatabase):
(WebCore::DBBackend::Server::removeOpenDatabase):
(WebCore::DBBackend::Server::getMaxSizeForDatabase):
- Modules/webdatabase/DBBackendServer.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::version):
(WebCore::Database::performOpenAndVerify):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabase.cpp.
(WebCore):
(WebCore::DatabaseBackend::databaseInfoTableName):
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::~DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(WebCore::DatabaseBackend::version):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::scriptExecutionContext):
(WebCore::DatabaseBackend::securityOrigin):
(WebCore::DatabaseBackend::stringIdentifier):
(WebCore::DatabaseBackend::displayName):
(WebCore::DatabaseBackend::estimatedSize):
(WebCore::DatabaseBackend::fileName):
(WebCore::DatabaseBackend::details):
(WebCore::DatabaseBackend::getVersionFromDatabase):
(WebCore::DatabaseBackend::setVersionInDatabase):
(WebCore::DatabaseBackend::setExpectedVersion):
(WebCore::DatabaseBackend::getCachedVersion):
(WebCore::DatabaseBackend::setCachedVersion):
(WebCore::DatabaseBackend::getActualVersionForTransaction):
(WebCore::DatabaseBackend::disableAuthorizer):
(WebCore::DatabaseBackend::enableAuthorizer):
(WebCore::DatabaseBackend::setAuthorizerReadOnly):
(WebCore::DatabaseBackend::setAuthorizerPermissions):
(WebCore::DatabaseBackend::lastActionChangedDatabase):
(WebCore::DatabaseBackend::lastActionWasInsert):
(WebCore::DatabaseBackend::resetDeletes):
(WebCore::DatabaseBackend::hadDeletes):
(WebCore::DatabaseBackend::resetAuthorizer):
(WebCore::DatabaseBackend::maximumSize):
(WebCore::DatabaseBackend::incrementalVacuumIfNeeded):
(WebCore::DatabaseBackend::interrupt):
(WebCore::DatabaseBackend::isInterrupted):
(WebCore::DatabaseBackend::logErrorMessage):
(WebCore::DatabaseBackend::reportOpenDatabaseResult):
(WebCore::DatabaseBackend::reportChangeVersionResult):
(WebCore::DatabaseBackend::reportStartTransactionResult):
(WebCore::DatabaseBackend::reportCommitTransactionResult):
(WebCore::DatabaseBackend::reportExecuteStatementResult):
(WebCore::DatabaseBackend::reportVacuumDatabaseResult):
- Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/AbstractDatabase.h.
(DatabaseBackend):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::databaseChanged):
(WebCore::DatabaseManager::addOpenDatabase):
(WebCore::DatabaseManager::removeOpenDatabase):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
- Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::DatabaseSync):
- Modules/webdatabase/DatabaseSync.h:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::databaseChanged):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):
- Modules/webdatabase/DatabaseTracker.h:
(WebCore):
(DatabaseTracker):
- Modules/webdatabase/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::markDatabase):
- Modules/webdatabase/OriginQuotaManager.h:
(WebCore):
(OriginQuotaManager):
- Modules/webdatabase/SQLTransactionClient.cpp:
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
- Modules/webdatabase/SQLTransactionClient.h:
(WebCore):
(SQLTransactionClient):
- Modules/webdatabase/chromium/DatabaseObserver.h:
(WebCore):
(DatabaseObserver):
- Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::NotifyDatabaseObserverOnCloseTask::create):
(WebCore::NotifyDatabaseObserverOnCloseTask::NotifyDatabaseObserverOnCloseTask):
(NotifyDatabaseObserverOnCloseTask):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):
- Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
(WebCore::NotifyDatabaseChangedTask::create):
(WebCore::NotifyDatabaseChangedTask::NotifyDatabaseChangedTask):
(NotifyDatabaseChangedTask):
(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExecuteStatement):
(WebCore::SQLTransactionClient::didExceedQuota):
- Target.pri:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/chromium:
- public/WebDatabase.h:
(WebDatabase):
- src/DatabaseObserver.cpp:
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
(WebCore::DatabaseObserver::reportOpenDatabaseResult):
(WebCore::DatabaseObserver::reportChangeVersionResult):
(WebCore::DatabaseObserver::reportStartTransactionResult):
(WebCore::DatabaseObserver::reportCommitTransactionResult):
(WebCore::DatabaseObserver::reportExecuteStatementResult):
(WebCore::DatabaseObserver::reportVacuumDatabaseResult):
- src/WebDatabase.cpp:
(WebKit::WebDatabase::WebDatabase):
- 7:00 PM Changeset in webkit [141206] by
-
- 3 edits5 deletes in trunk/Tools
Tidy up Sheriffbot's Sheriffs command's unit tests
https://bugs.webkit.org/show_bug.cgi?id=108262
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Eric Seidel.
Added the use of MockWeb instead of the filesystem to test the sheriffs command.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Sheriffs._retrieve_webkit_sheriffs):
(Sheriffs.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_sheriffs):
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Removed.
- Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Removed.
- 6:43 PM Changeset in webkit [141205] by
-
- 2 edits in trunk/Tools
Enable tests for Windows EWS!
https://bugs.webkit.org/show_bug.cgi?id=107968
Reviewed by Adam Barth.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 6:37 PM Changeset in webkit [141204] by
-
- 5 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r141153.
http://trac.webkit.org/changeset/141153
https://bugs.webkit.org/show_bug.cgi?id=108280
Caused WebFrameTest.DivScrollIntoEditableTest to fail on Mac.
(Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/data/get_scale_for_zoom_into_editable_test.html:
- 6:32 PM Changeset in webkit [141203] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Adjust missing MessageID removals to fix build breaks
https://bugs.webkit.org/show_bug.cgi?id=108276
Unreviewed to fix build breaks.
Some MessageID removals wasn't adjusted into ConnectionUnix.cpp and coordinated graphics.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyIsOutOfLine):
(CoreIPC::MessageInfo::isMessageBodyIsOutOfLine):
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
- UIProcess/WebProcessProxy.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- 6:30 PM Changeset in webkit [141202] by
-
- 24 edits in trunk
Unreviewed, rolling out r140983.
http://trac.webkit.org/changeset/140983
https://bugs.webkit.org/show_bug.cgi?id=108277
Unfortunately, this API has one last client (Requested by
abarth on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Modules/notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore):
(WebCore::Notification::create):
- Modules/notifications/Notification.h:
(Notification):
(WebCore::Notification::isHTML):
(WebCore::Notification::setHTML):
(WebCore::Notification::url):
(WebCore::Notification::setURL):
- Modules/notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createHTMLNotification):
(NotificationCenter):
- Modules/notifications/NotificationCenter.idl:
- page/FeatureObserver.h:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
- src/WebNotification.cpp:
(WebKit::WebNotification::isHTML):
(WebKit::WebNotification::url):
(WebKit::WebNotification::iconURL):
(WebKit::WebNotification::title):
(WebKit::WebNotification::body):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::displayNotification):
(WebCore::NotificationPresenterClientQt::cancel):
(WebCore::NotificationPresenterClientQt::notificationClicked):
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue):
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
(WebCore::NotificationPresenterClientQt::dumpShowText):
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
LayoutTests:
- fast/notifications/notifications-with-permission-expected.txt:
- fast/notifications/notifications-with-permission.html:
- 6:22 PM Changeset in webkit [141201] by
-
- 10 edits1 copy in branches/chromium/1364
Merge 140803
INPUT_MULTIPLE_FIELDS_UI: Inconsistent value of aria-valuetext attribute
https://bugs.webkit.org/show_bug.cgi?id=107897
Reviewed by Kentaro Hara.
Source/WebCore:
aria-valuetext and aria-valuenow attributes had inconsistent values in
a case of initial empty state and a case that a user clears a field.
- aria-valuetext attribute should have "blank" message in the initial empty state.
- aria-valuenow attribute should be removed in the cleared empty state.
Also, we have a bug that aira-valuenow had a symbolic value such as "AM"
"January". It should always have a numeric value according to the
specification.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow
No new tests. Updates fast/forms/*-multiple-fields/*-multiple-fields-ax-aria-attributes.html.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::DateTimeFieldElement):
Set "blank" message to aria-valuetext attribute.
(WebCore::DateTimeFieldElement::updateVisibleValue):
aria-valuenow attribute should be a numeric value. Apply String::number
to the return value of valueForARIAValueNow.
Remove aria-valuenow attribute if nothing is selected.
(WebCore::DateTimeFieldElement::valueForARIAValueNow):
Added.
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Declare valueForARIAValueNow.
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::valueForARIAValueNow):
Added. Returns 1 + internal selection index.
For example, the function returns 1 for January.
- html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Declare valueForARIAValueNow.
LayoutTests:
Fix existing tests to show aria-valuenow attribute values.
- fast/forms/resources/multiple-fields-ax-aria-attributes.js: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
Add tests for initial empty-value state.
- fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt:
- fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
- fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
TBR=tkent@chromium.org
BUG=crbug.com/172199
Review URL: https://codereview.chromium.org/12086056
- 6:19 PM Changeset in webkit [141200] by
-
- 6 edits in branches/chromium/1364/Source/WebCore/html/shadow
Merge 140791
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove confusing minimum() and maximum() of DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=107918
Reviewed by Kentaro Hara.
DateTimeSymbolicFieldElement::minimum() and maximum() are very
confusing. They don't return minimum/maximum value of 0-based symbol
index though valueAsInteger is 0-based. These functions are used only
for ARIA attributes in DateTimeFieldElement::initialize().
- Remove DateTimeFieldElement::minimum() and maximum(), and pass
minimum/maximum values for ARIA attributes as function arguments.
- DateTimeNumericFieldElement::maximum() is now non-virtual. It is called by subclasses.
No new tests. This should not change any behavior.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
Add axMimimum/axMaximum arguments. Don't use minimum() and maximum().
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Ditto.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::initialize):
Pass m_range.minimum and maximum to DateTimeFieldElement::initialize().
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
- Add initialize()
- Make maximum() non-virtual
- Remove minimum().
- html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::initialize):
Pass m_minimumIndex + 1 and m_maximumIndex + 1 to
DateTimeFieldElement::initialize().
- html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement):
Add initialize() and remove minimum() and maximum().
TBR=tkent@chromium.org
BUG=crbug.com/172199
Review URL: https://codereview.chromium.org/12079062
- 6:17 PM Changeset in webkit [141199] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSObjCClassInfo creates reference cycle with JSContext
https://bugs.webkit.org/show_bug.cgi?id=107839
Reviewed by Geoffrey Garen.
Fixing several ASSERTs that were incorrect along with some of the reallocation of m_prototype and
m_constructor that they were based on.
- API/JSWrapperMap.mm:
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We now only allocate those
fields that are null (i.e. have been collected or have never been allocated to begin with).
(-[JSObjCClassInfo reallocateConstructorAndOrPrototype]): Renamed to better indicate that we're
reallocating one or both of the prototype/constructor combo.
(-[JSObjCClassInfo wrapperForObject:]): Call new reallocate function.
(-[JSObjCClassInfo constructor]): Ditto.
- 6:17 PM Changeset in webkit [141198] by
-
- 4 edits2 adds in trunk
parserAppendChild and parserInsertBefore should ensure that child nodes are in the same document
https://bugs.webkit.org/show_bug.cgi?id=108260
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/parser/xml-error-adopted.xml
The check and adoption if the documents don't match is now moved into ContainerNode::parser* from HTMLConstructionSite.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::fosterParent):
LayoutTests:
- fast/parser/xml-error-adopted-expected.txt: Added.
- fast/parser/xml-error-adopted.xml: Added.
- 6:11 PM Changeset in webkit [141197] by
-
- 4 edits in branches/chromium/1364/Source/WebCore/html/shadow
Merge 140788
INPUT_MULTIPLE_FIELDS_UI: Refactoring: Remove unused DateTimeHourFieldElement::valueAsInteger
https://bugs.webkit.org/show_bug.cgi?id=107915
Reviewed by Kentaro Hara.
DateTimeHourFieldElement::valueAsInteger is never called. Remove it and
make valueAsInteger non-public.
No new tests. This shouldn't change any behavior.
- html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Make valueAsInteger protected.
- html/shadow/DateTimeFieldElements.cpp:
Remove DateTimeHourFieldElement::valueAsInteger.
(WebCore::DateTimeHourFieldElement::populateDateTimeFieldsState):
Remove unnecessary DateTimeNumericFieldElement:: prefix.
- html/shadow/DateTimeFieldElements.h:
(DateTimeHourFieldElement): Remove valueAsInteger.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
Make valueAsInteger FINAL.
BUG=crbug.com/172199
TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/12090060
- 6:08 PM Changeset in webkit [141196] by
-
- 13 edits2 adds in trunk
[Chromium] Cannot copy text when selecting readonly (or disabled) input elements
https://bugs.webkit.org/show_bug.cgi?id=106287
Reviewed by Hajime Morita.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
a document element. However, the inner element and document element have a different tree scope, the selection range
cannot be gotten correctly.
We should use ShadowRoot instead of document so that we can stay in the same tree scope.
- WebCore.exp.in:
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::rootEditableElementOrTreeScopeRootNode): Added. Returns ShadowRoot so that we can
stay in the same tree scope.
(WebCore):
- editing/FrameSelection.h:
(FrameSelection):
- editing/TextIterator.cpp:
(WebCore::TextIterator::getLocationAndLengthFromRange):
- editing/TextIterator.h:
(TextIterator):
Source/WebKit/chromium:
When an input element is disabled or readonly, its inner element is not editable. So its rootEditableElement
does not exist. In WebViewImpl::caretOrSelectionRange, if rootEditableElement does not exist, it uses
a document element. However, the inner element and document element have a different tree scope, selection range
cannot be gotten correctly.
We should use ShadowRoot instead of document so that we can stay in the same tree scope.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::caretOrSelectionRange):
- tests/WebViewTest.cpp:
- tests/data/selection_disabled.html: Added.
- tests/data/selection_readonly.html: Added.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 6:05 PM Changeset in webkit [141195] by
-
- 16 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: The content should not overflow the <input> boundary
https://bugs.webkit.org/show_bug.cgi?id=108069
Reviewed by Hajime Morita.
Source/WebCore:
To avoid the overflow, we do:
A) Specify overflow:hidden to <input>.
However, we need to make sub-fields and buttons workable even if the
width is smaller than the intrinsic size. So, we do:
B) Make DateTimeEditElement shrinkable, and
C) Make the sub-fields scrollable horizontally like input[type=text].
To achieve B, we need to remove -webkit-date-and-time-container (D)
because width property for <input> can shrink only the direct child
elements.
Tests: fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html
and new test cases in fast/forms/date/date-appearance-basic.html.
- css/html.css:
(input[type="date"]):
Change -webkit-align-items value. (D)
Specify overflow:hidden. (A)
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-datetime-edit):
Add min-width:0 (B), and overflow:hidden. (C)
Remove unnecessary white-space:pre because of white-space:nowrap below.
(input::-webkit-datetime-edit-fields-wrapper):
Added. This is the child of -webkit-datetime-edit, and contains
sub-fields. (C)
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
Remove -webkit-date-and-time-container, and append DateTimeEditElement,
spin button, and picker indicator element to the ShadowRoot. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldApplyLocaleDirection):
<input> for multiple fields UI should have the direction of the browser
locale. This is a replacement of the code for dir attribute in
updateInnerTextValue below. (D)
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
Remove the code to set dir= to -webkit-date-and-time-container.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Declare shouldApplyLocaleDirection. (D)
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
Calls setHasCustomCallbacks for customStyleForRenderer. (D)
(WebCore::HTMLInputElement::customStyleForRenderer):
Set direction to RenderStyle if shouldApplyLocaleDirection is true. This
is a replacement of the dir setting code in
BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue. (D)
- html/HTMLInputElement.h:
(HTMLInputElement): Declare customStyleForRenderer. (D)
- html/InputType.cpp:
(WebCore::InputType::shouldApplyLocaleDirection):
Add default implmentation of shouldApplyLocaleDirection. (D)
- html/InputType.h:
(InputType): Declare shouldApplyLocaleDirection. (D)
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::fieldsWrapperElement):
A helper to get -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::addField):
Add elements to -webkit-datetime-edit-fields-wrapper element. (C)
(WebCore::DateTimeEditElement::customStyleForRenderer):
- Iterate over children of -webkit-datetime-edit-fields-wrapper element. (C)
- Set width property instead of min-width. (B)
(WebCore::DateTimeEditElement::layout):
- Prepare -webkit-datetime-edit-fields-wrapper element. (C)
- Handle children of -webkit-datetime-edit-fields-wrapper element. (C)
- Need to do style recalc because child structure is changed. (C)
- html/shadow/DateTimeEditElement.h:
(DateTimeEditElement): Declare fieldsWrapperElement. (C)
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
Add test cases for small width and small height.
- fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html:
Update the code because of shadow tree structure change.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:
Added.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt:
Added.
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- date-appearance-basic.html: New test cases are added.
- *-appearance-pseudo-element.html: :before :after position is slightly changed because of the -webkit-align-items change.
- suggestion-picker/*.html: RTL behavior is changed. The direction of suggestion pickers matches to the direction of the input content (browser locale).
- 5:51 PM Changeset in webkit [141194] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. More Windows7 gardening.
- platform/win/TestExpectations:
- 5:48 PM Changeset in webkit [141193] by
-
- 4 edits in trunk/Source
[v8] Enable binding integrity on linux
https://bugs.webkit.org/show_bug.cgi?id=108242
Reviewed by Adam Barth.
Source/WebCore:
Patch is correct if existing tests pass.
- html/TextMetrics.idl:
Suppress check to allow link on linux.
Source/WebKit/chromium:
- features.gypi:
- 5:44 PM Changeset in webkit [141192] by
-
- 5 edits in trunk/Source/JavaScriptCore
Make precise size classes more precise
https://bugs.webkit.org/show_bug.cgi?id=108270
Reviewed by Mark Hahnenberg.
Size inference makes this profitable.
I chose 8 byte increments because JSString is 24 bytes. Otherwise, 16
byte increments might be better.
- heap/Heap.h:
(Heap): Removed firstAllocatorWithoutDestructors because it's unused now.
- heap/MarkedBlock.h:
(MarkedBlock): Updated constants.
- heap/MarkedSpace.h:
(MarkedSpace):
(JSC): Also reduced the maximum precise size class because my testing
has shown that the smaller size classes are much more common. This
offsets some of the size class explosion caused by reducing the precise
increment.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): No need for this ASSERT anymore
because we don't rely on firstAllocatorWithoutDestructors anymore, since
we pick size classes dynamically now.
- 5:38 PM Changeset in webkit [141191] by
-
- 8 edits in trunk/Source/WebKit2
Remove MessageID parameter from Connection::sendMessage
https://bugs.webkit.org/show_bug.cgi?id=108269
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
- Platform/CoreIPC/Connection.h:
(Connection):
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendMessage):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- 5:31 PM Changeset in webkit [141190] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add some hardening to methodTable()
https://bugs.webkit.org/show_bug.cgi?id=108253
Reviewed by Mark Hahnenberg.
When accessing methodTable() we now always make sure that our
structure _could_ be valid. Added a separate method to get a
classes methodTable during destruction as it's not possible to
validate the structure at that point. This separation might
also make it possible to improve the performance of methodTable
access more generally in future.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor):
- runtime/JSCell.h:
(JSCell):
- runtime/JSCellInlines.h:
(JSC::JSCell::methodTableForDestruction):
(JSC):
(JSC::JSCell::methodTable):
- 5:18 PM Changeset in webkit [141189] by
-
- 2 edits in trunk/Source/JavaScriptCore
offlineasm BaseIndex handling is broken on ARM due to MIPS changes
https://bugs.webkit.org/show_bug.cgi?id=108261
Reviewed by Oliver Hunt.
Backends shouldn't override each other's methods. That's not cool.
- offlineasm/mips.rb:
- 5:14 PM Changeset in webkit [141188] by
-
- 2 edits in trunk/LayoutTests
[chromium] Disable layout tests impacted by page scale change
https://bugs.webkit.org/show_bug.cgi?id=108232
Unreviewed, gardening.
After https://codereview.chromium.org/12045002/, these
tests are expected to fail. Disabling and creating bugs for follow-up.
- platform/chromium/TestExpectations:
- 5:10 PM Changeset in webkit [141187] by
-
- 2 edits in trunk/Source/WebCore
Don't updateTileCoverageMap() from setScrollingModeIndication if we don't need to.
Reviewed by Simon Fraser.
Only do the work if the tiled scrolling indicator/map is enabled.
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setScrollingModeIndication):
- 4:59 PM Changeset in webkit [141186] by
-
- 4 edits2 adds in trunk
AX: Add support for aria-autocomplete="list" on ARIA combobox
https://bugs.webkit.org/show_bug.cgi?id=108228
Reviewed by Ryosuke Niwa.
Source/WebCore:
Comboboxes behave much like textfields, and so they need
to respond like text controls.
Test: platform/mac/accessibility/combox-box-value.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isTextControl):
(WebCore):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
LayoutTests:
- platform/mac/accessibility/combox-box-value-expected.txt: Added.
- platform/mac/accessibility/combox-box-value.html: Added.
- 4:59 PM Changeset in webkit [141185] by
-
- 4 edits in trunk/Source/JavaScriptCore
cloop.rb shouldn't use a method called 'dump' for code generation
https://bugs.webkit.org/show_bug.cgi?id=108251
Reviewed by Mark Hahnenberg.
Revert http://trac.webkit.org/changeset/141178 and rename 'dump' to 'clDump'.
Also made trivial build fixes for !ENABLE(JIT).
- offlineasm/cloop.rb:
- runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::intrinsicFor):
- runtime/JSGlobalData.h:
- 4:57 PM Changeset in webkit [141184] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Do not mark translation-unit-local functions as extern "C"
https://bugs.webkit.org/show_bug.cgi?id=108218
Reviewed by Adam Barth.
Requested by darin in https://bugs.webkit.org/show_bug.cgi?id=107845
This also allows enabling -Wreturn-type-c-linkage again, but I'd like to
wait for the next clang roll (which tweaks this warning) before undoing
r140800 (which removed that warning).
No behavior change.
- bindings/v8/npruntime.cpp:
- 4:57 PM Changeset in webkit [141183] by
-
- 8 edits in trunk/Source/WebKit2
Stop generating the message kind enum
https://bugs.webkit.org/show_bug.cgi?id=108258
Reviewed by Beth Dakin.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::waitForAndDispatchImmediately):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Scripts/webkit2/messages.py:
(surround_in_condition):
(message_to_struct_declaration):
(generate_messages_header):
- Scripts/webkit2/messages_unittest.py:
- Scripts/webkit2/model.py:
(Message.init):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- 4:56 PM Changeset in webkit [141182] by
-
- 3 edits in trunk/Tools
MockWeb should be able to serve mock web content
https://bugs.webkit.org/show_bug.cgi?id=108240
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Dirk Pranke.
Added the ability to have MockWeb serve mock web data.
- Scripts/webkitpy/common/host_mock.py:
(MockHost.init):
- Scripts/webkitpy/common/net/web_mock.py:
(MockWeb.init):
(MockWeb.get_binary):
- 4:50 PM Changeset in webkit [141181] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip a bunch of tests on Win7 in preparation of turning on EWS testers.
https://bugs.webkit.org/show_bug.cgi?id=108249
- platform/win/TestExpectations:
- 4:43 PM Changeset in webkit [141180] by
-
- 2 edits in trunk/Source/WebKit2
Fix erroneous semicolon causing build failure: if statement has empty body [-Werror,-Wempty-body]
https://bugs.webkit.org/show_bug.cgi?id=108241
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-29
Reviewed by Anders Carlsson.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addExistingWebPage): Remove erroneous
semicolon following the if condition.
- 4:36 PM Changeset in webkit [141179] by
-
- 18 edits2 deletes in trunk/Source
Removed GGC because it has been disabled for a long time
https://bugs.webkit.org/show_bug.cgi?id=108245
Reviewed by Filip Pizlo.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::writeBarrier):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- heap/CardSet.h: Removed.
- heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::collect):
- heap/Heap.h:
(Heap):
(JSC::Heap::shouldCollect):
(JSC::Heap::isWriteBarrierEnabled):
(JSC):
(JSC::Heap::writeBarrier):
- heap/MarkedBlock.h:
(MarkedBlock):
(JSC):
- heap/MarkedSpace.cpp:
(JSC):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
../WebCore:
- ForwardingHeaders/heap/CardSet.h: Removed.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 4:30 PM Changeset in webkit [141178] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove redundant AST dump method from cloop.rb, since they are already defined in ast.rb
https://bugs.webkit.org/show_bug.cgi?id=108247
Reviewed by Oliver Hunt.
Makes offlineasm dumping easier to read and less likely to cause assertion failures.
Also fixes the strange situation where cloop.rb and ast.rb both defined dump methods,
but cloop.rb was winning.
- offlineasm/cloop.rb:
- 4:22 PM Changeset in webkit [141177] by
-
- 3 edits in trunk/Source/WebKit2
Remove almost everything from MessageID
https://bugs.webkit.org/show_bug.cgi?id=108244
Reviewed by Beth Dakin.
- Platform/CoreIPC/MessageID.h:
(CoreIPC::MessageID::MessageID):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC):
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):
(CoreIPC::Connection::receiveSourceEventHandler):
- 4:07 PM Changeset in webkit [141176] by
-
- 4 edits in trunk/Source/JavaScriptCore
Objective-C API: JSObjCClassInfo creates reference cycle with JSContext
https://bugs.webkit.org/show_bug.cgi?id=107839
Reviewed by Oliver Hunt.
JSContext has a JSWrapperMap, which has an NSMutableDictionary m_classMap, which has values that
are JSObjCClassInfo objects, which have strong references to two JSValue *'s, m_prototype and
m_constructor, which in turn have strong references to the JSContext, creating a reference cycle.
We should make m_prototype and m_constructor Weak<JSObject>. This gets rid of the strong reference
to the JSContext and also prevents clients from accidentally creating reference cycles by assigning
to the prototype of the constructor. If Weak<JSObject> fields are ever garbage collected, we will
reallocate them.
- API/JSContext.mm:
(-[JSContext wrapperMap]):
- API/JSContextInternal.h:
- API/JSWrapperMap.mm:
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSObjCClassInfo dealloc]):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(-[JSObjCClassInfo allocateConstructorAndPrototype]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSObjCClassInfo constructor]):
- 4:02 PM Changeset in webkit [141175] by
-
- 12 edits in trunk/Source
Refactor ShadowRoot exception handling
https://bugs.webkit.org/show_bug.cgi?id=108209
Reviewed by Dimitri Glazkov.
Source/WebCore:
Many of the exception cases for ShadowRoot are actually impossible and
should be asserts instead. We can also move the one case of exception logic,
for elements that don't allow author shadows into Element::createShadowRoot
instead of having it all over the ShadowRoot and ElementShadow classes. This
is the first step in centralizing all ShadowRoot creation inside ElementShadow.
No new tests, covered by existing tests.
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::createShadowRoot): Be explicit about what kind of ShadowRoot you're creating.
(WebCore::Element::ensureUserAgentShadowRoot): No more exceptions.
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): This never actually throws exceptions, remove ExceptionCode.
- dom/ElementShadow.h:
(ElementShadow):
- dom/ShadowRoot.cpp:
(WebCore::determineUsageType): Merge with Element::createShadowRoot.
(WebCore):
(WebCore::ShadowRoot::ShadowRoot): Moved Histogram logic here since it's actually about the constructor anyway.
(WebCore::ShadowRoot::create): Removed overload that made the code less obvious.
- dom/ShadowRoot.h:
(ShadowRoot):
- html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
- html/shadow/TextFieldDecorationElement.cpp:
(WebCore::getDecorationRootAndDecoratedRoot):
- testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::createShadowRoot):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: Swap ShadowRoot::create export with Element::createShadowRoot.
- 4:00 PM Changeset in webkit [141174] by
-
- 15 edits in trunk/Source/WebKit2
Get rid of MessageID::is()
https://bugs.webkit.org/show_bug.cgi?id=108234
Reviewed by Beth Dakin.
Add explicit message receiver name equality checks instead of using MessageID::is.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- Platform/CoreIPC/MessageID.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
- 3:54 PM Changeset in webkit [141173] by
-
- 9 edits in trunk/Source
Allow clients to ask for the WebView/WKView placeholder view when in full screen mode.
https://bugs.webkit.org/show_bug.cgi?id=103558
<rdar://problem/12763112>
Reviewed by Benjamin Poulain.
Source/WebKit/mac:
Clients may want to behave differently when their WebView/WKView has been swapped out by a placeholder
view when in full screen mode. Add a simple accessor for the existing placeholder view to
WebFullScreenController and WebView.
- WebView/WebFullScreenController.h:
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController webViewPlaceholder]): Added simple accessor.
- WebView/WebView.mm:
(-[WebView fullScreenPlaceholderView]): Added simple accessor.
Source/WebKit2:
Clients may want to behave differently when their WebView/WKView has been swapped out by a placeholder
view when in full screen mode. Add a simple accessor for the existing placeholder view to
WKFullScreenWindowController and WKView.
- UIProcess/API/mac/WKView.mm:
(-[WKView fullScreenPlaceholderView]): Added simple accessor.
- UIProcess/API/mac/WKViewPrivate.h:
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController webViewPlaceholder]): Added simple accessor.
- 3:35 PM Changeset in webkit [141172] by
-
- 2 edits in trunk/Tools
run-api-tests should have an option to specify root
https://bugs.webkit.org/show_bug.cgi?id=108210
Reviewed by Ryosuke Niwa.
- Scripts/run-api-tests:
Add the option and use it to set the configuration product directory. Since it is supposed
to point to the built products, do not build the products if root is specified (this mimics
the behavior of run-javascriptcore-tests).
- 3:24 PM Changeset in webkit [141171] by
-
- 9 edits in trunk/Source/WebKit2
[WK2] Call LayerTreeHost::deviceOrPageScaleFactorChanged() when a device or page scale factor is changed.
https://bugs.webkit.org/show_bug.cgi?id=107802
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-29
Reviewed by Simon Fraser.
Currently, LayerTreeHostMac and *GTK call deviceOrPageScaleFactorChanged()
of the non compositing GraphicsLayer when a device scale factor is changed.
There are two problems.
- We don't notify LayerTreeHost when a page scale factor is changed.
- When using TiledCoreAnimationDrawingAreaProxy, LayerTreeHostMac does
not receive the device scale factor changed callback.
So this patch changes three points.
- Rename from deviceScaleFactorDidChange() to deviceOrPageScaleFactorChanged()
in LayerTreeHost.
- WebPage::setDeviceScaleFactor() calls LayerTreeHost::deviceScaleFactorDidChange()
because of dealing with TiledCoreAnimationDrawingAreaProxy.
- WebPage::pageScaleFactor() calls LayerTreeHost::deviceScaleFactorDidChange()
to call deviceOrPageScaleFactorChanged() of the non compositing GraphicsLayer.
Unfortunately, I couldn't think of a way to test this in an automated fashion.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):
Don't call LayerTreeHost::deviceScaleFactorDidChange() because this
method calls WebPage::setDeviceScaleFactor() and then
LayerTreeHost::deviceScaleFactorDidChange() is called.
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scalePage):
(WebKit::WebPage::setDeviceScaleFactor):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::deviceOrPageScaleFactorChanged):
- 3:15 PM Changeset in webkit [141170] by
-
- 4 edits in trunk/Source/WebKit2
Get rid of MessageID::get()
https://bugs.webkit.org/show_bug.cgi?id=108235
Reviewed by Beth Dakin.
Just check for the message receiver name and message name explicitly instead.
- Platform/CoreIPC/MessageID.h:
(CoreIPC::MessageID::is):
- Shared/CoreIPCSupport/WebContextMessageKinds.h:
(WebContextLegacyMessage::messageReceiverName):
(WebContextLegacyMessage):
(WebContextLegacyMessage::postMessageMessageName):
(WebContextLegacyMessage::postSynchronousMessageMessageName):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- 3:00 PM Changeset in webkit [141169] by
-
- 4 edits in branches/chromium/1364/Source
Merge 140483
Prevent race condition during Worker shutdown
https://bugs.webkit.org/show_bug.cgi?id=107577
Reviewed by Dmitry Titov.
Source/WebCore:
During worker shutdown, from the main thread a cleanup task is posted followed by
terminating the message queue, which prevents further tasks from being processed. It was
possible for another task be posted by another thread between the main thread calls
to postTask and terminate(), which would cause that task to run after cleanup. Expose
a new WTF::MessageQueue::appendAndKill() method which keeps a mutex around the two steps,
and use that during worker shutdown.
No reliable tests for the race - problem identified by inspection of user crash stacks.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTaskAndTerminate): New method, uses MessageQueue::appendAndKill()
- workers/WorkerRunLoop.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::stop): Uses postTaskAndTerminate() to avoid race.
Source/WTF:
Add MessageQueue::appendAndKill() which wraps those two steps with a mutex so other
threads can't sneak a message in between.
- wtf/MessageQueue.h: Added appendAndKill() method.
TBR=jsbell@chromium.org
Review URL: https://codereview.chromium.org/12096050
- 2:52 PM Changeset in webkit [141168] by
-
- 5 edits in trunk
REGRESSION (r140594): RELEASE_ASSERT_NOT_REACHED in JSC::Interpreter::execute
https://bugs.webkit.org/show_bug.cgi?id=108097
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
LiteralParser was accepting a bogus 'var a.b = c' statement
- runtime/LiteralParser.cpp:
(JSC::::tryJSONPParse):
LayoutTests:
Add parser test for invalid var a.b syntax
- fast/js/parser-syntax-check-expected.txt:
- fast/js/script-tests/parser-syntax-check.js:
- 2:52 PM Changeset in webkit [141167] by
-
- 29 edits in trunk/Source/WebKit2
Add support for enabling process suppression in WebProcesses with no visible pages
https://bugs.webkit.org/show_bug.cgi?id=108054
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-29
Reviewed by Anders Carlsson.
Provide a preference to enable process suppression in WebProcesses with
no visible pages even if the application is not completely occluded.
This provides more opportunities for process suppression to take effect.
Replace the messaging of application occlusion status from UI process to
ChildProcesses with messages that indicate the current required process
suppression state. WebProcessProxy should determine if the process is
eligible for process suppression based on both application occlusion
and page visibility. When either of these parameters changes,
the proxy should message the child process of the updated process
suppression state.
- NetworkProcess/NetworkProcess.messages.in: Rename
SetApplicationIsOccluded to SetProcessSuppressionEnabled.
- PluginProcess/PluginProcess.messages.in: Ditto.
- Shared/ChildProcess.h:
(WebKit::ChildProcess::processSuppressionEnabled): Rename
applicationIsOccluded.
- Shared/WebPreferencesStore.h: Add a new preference
pageVisibilityBasedProcessSuppressionEnabled, to enabled/disable
process suppression of WebProcesses when all pages are hidden.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): Rename
setApplicationIsOccluded.
(WebKit::ChildProcess::platformInitialize): Replace call to
setApplicationIsOccluded with setProcessSuppressionEnabled.
- SharedWorkerProcess/SharedWorkerProcess.messages.in: Rename
SetApplicationIsOccluded to SetProcessSuppressionEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPageVisibilityBasedProcessSuppressionEnabled):
(WKPreferencesGetPageVisibilityBasedProcessSuppressionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Use setter
to update process suppression state instead of messaging directly.
Use WebContext::canEnableProcessSuppressionForNetworkProcess() helper
method to determine if process suppression should be enabled.
- UIProcess/Network/NetworkProcessProxy.h: Rename
setApplicationIsOccluded to setProcessSuppresionEnabled.
- UIProcess/Network/mac/NetworkProcessProxyMac.mm:
(WebKit::NetworkProcessProxy::setProcessSuppressionEnabled): Ditto.
- UIProcess/Plugins/PluginProcessManager.h: Ditto.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Use setter
to update process suppression state instead of messaging directly.
Use WebContext::canEnableProcessSuppressionForGlobalChildProcesses()
helper method to determine if process suppression should be enabled.
- UIProcess/Plugins/PluginProcessProxy.h: Rename
setApplicationIsOccluded to setProcessSuppresionEnabled.
- UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::setProcessSuppressionEnabled): Ditto.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::setProcessSuppressionEnabled): Ditto.
- UIProcess/SharedWorkers/SharedWorkerProcessManager.h: Ditto.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Use setter
to update process suppression state instead of messaging directly.
Use WebContext::canEnableProcessSuppressionForGlobalChildProcesses()
helper method to determine if process suppression should be enabled.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h: Rename
setApplicationIsOccluded to setProcessSuppresionEnabled.
- UIProcess/SharedWorkers/mac/SharedWorkerProcessManagerMac.mm:
(WebKit::SharedWorkerProcessManager::setProcessSuppressionEnabled):
Ditto.
- UIProcess/SharedWorkers/mac/SharedWorkerProcessProxyMac.mm:
(WebKit::SharedWorkerProcessProxy::setProcessSuppressionEnabled): Ditto.
- UIProcess/WebContext.h: Replace applicationIsOccluded() getter with
helper methods to determine if a child process can have process
suppression enabled.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange): Notify WebProcessProxy of
page visibility change.
(WebKit::WebPageProxy::preferencesDidChange): Notify WebProcessProxy of
change in preferences.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy): Initialize member variable
tracking process suppression state to false.
(WebKit::WebProcessProxy::createWebPage): Update set of pages which can
be process suppressed and the resulting process suppression state for
the child process.
(WebKit::WebProcessProxy::addExistingWebPage): Ditto.
(WebKit::WebProcessProxy::removeWebPage): Ditto.
(WebKit::WebProcessProxy::pageVisibilityChanged): Ditto.
(WebKit::WebProcessProxy::pagePreferencesChanged): Ditto.
(WebKit::WebProcessProxy::didFinishLaunching): Call
updateProcessSuppressionState().
- UIProcess/WebProcessProxy.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::updateProcessSuppressionStateOfGlobalChildProcesses): Use new
helper method canEnableProcessSuppressionForGlobalChildProcesses() to
determine if process suppression should be enabled.
(WebKit::applicationOcclusionStateChanged): Update renamed methods
and variables.
(WebKit::enableOcclusionNotifications): Move OmitProcessSuppression
user default check into canEnableProcessSuppression methods.
(WebKit::omitProcessSuppression):
(WebKit::WebContext::updateProcessSuppressionStateOfChildProcesses):
Use new helper method canEnableProcessSuppressionForNetworkProcess() to
determine if process suppression should be enabled for NetworkProcess.
Let WebProcess update process suppression state based on application
occlusion state and page visibility.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess):
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess):
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses):
(WebKit::WebContext::processSuppressionEnabledChanged): Reevaluate if
process suppression is enabled for all contexts and update process
suppression state of global child processes.
- UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::pageIsProcessSuppressible):
(WebKit::WebProcessProxy::allPagesAreProcessSuppressible):
(WebKit::WebProcessProxy::updateProcessSuppressionState):
- WebProcess/WebProcess.messages.in:
- 2:51 PM Changeset in webkit [141166] by
-
- 14 edits in trunk/Source/WebCore
Change DatabaseContext lookup to be thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=107784.
Reviewed by Geoffrey Garen.
DatabaseContext will no longer be a Supplement of ScriptExecutionContext.
Instead we will maintain a mutex guarded contextMap in the DatabaseManager
which maps ScriptExecutionContexts to DatabaseContexts.
Also cleaned up the shutdown mechanism of the DatabaseContext,
DatabaseThread, and Databases when their owner ScriptExecutionContext
destructs.
No new tests.
- Modules/webdatabase/AbstractDatabase.cpp:
(WebCore::AbstractDatabase::AbstractDatabase):
- Modules/webdatabase/AbstractDatabase.h:
(WebCore::AbstractDatabase::databaseContext):
(AbstractDatabase):
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
- Modules/webdatabase/Database.h:
(WebCore):
(Database):
- Modules/webdatabase/DatabaseContext.cpp:
(WebCore):
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::~DatabaseContext):
(WebCore::DatabaseContext::contextDestroyed):
(WebCore::DatabaseContext::stop):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::stopDatabases):
- Modules/webdatabase/DatabaseContext.h:
(DatabaseContext):
(WebCore::DatabaseContext::scriptExecutionContext):
(WebCore::DatabaseContext::hasOpenDatabases):
(WebCore::DatabaseContext::stopDatabases):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::manager):
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::getExistingDatabaseContext):
(WebCore):
(WebCore::DatabaseManager::getDatabaseContext):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::notifyDatabaseContextConstructed):
(WebCore::DatabaseManager::notifyDatabaseContextDestructed):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::hasOpenDatabases):
(WebCore::DatabaseManager::stopDatabases):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
- Modules/webdatabase/DatabaseManager.h:
(WebCore):
(DatabaseManager):
(WebCore::DatabaseManager::notifyDatabaseContextConstructed):
(WebCore::DatabaseManager::notifyDatabaseContextDestructed):
- Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::DatabaseSync):
- Modules/webdatabase/DatabaseSync.h:
(WebCore):
(DatabaseSync):
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::~DatabaseThread):
(WebCore::DatabaseThread::requestTermination):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
- dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::~ActiveDOMObject):
- 2:24 PM Changeset in webkit [141165] by
-
- 9 edits1 copy in trunk/Source/WebKit2
Start using the message flag in MessageEncoder/MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=108227
Reviewed by Beth Dakin.
Stop using the flags in MessageID and store the flags directly in the message instead.
This is another step towards eliminating MessageID.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::dispatchSyncMessage):
(CoreIPC::Connection::dispatchMessage):
- Platform/CoreIPC/Connection.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
(CoreIPC::MessageDecoder::isSyncMessage):
(CoreIPC):
(CoreIPC::MessageDecoder::shouldDispatchMessageWhenWaitingForSyncReply):
- Platform/CoreIPC/MessageDecoder.h:
(MessageDecoder):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC):
(CoreIPC::MessageEncoder::MessageEncoder):
(CoreIPC::MessageEncoder::~MessageEncoder):
(CoreIPC::MessageEncoder::setIsSyncMessage):
(CoreIPC::MessageEncoder::setShouldDispatchMessageWhenWaitingForSyncReply):
- Platform/CoreIPC/MessageEncoder.h:
(MessageEncoder):
- Platform/CoreIPC/MessageFlags.h: Copied from Source/WebKit2/Platform/CoreIPC/MessageEncoder.h.
(CoreIPC):
- Platform/CoreIPC/MessageID.h:
- WebKit2.xcodeproj/project.pbxproj:
- 2:14 PM Changeset in webkit [141164] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Temporarily disable inspector tests.
They are all timing out due to some configuration problem on the bots.
- platform/win/TestExpectations:
- 2:11 PM Changeset in webkit [141163] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] Make resolveContentBasedTrackSizingFunctionsForItems reuse distributeSpaceToTracks
https://bugs.webkit.org/show_bug.cgi?id=108110
Reviewed by Tony Chang.
This change makes us match more closely the specification by reusing distributeSpaceToTracks inside
resolveContentBasedTrackSizingFunctionsForItems. This also removes some existing code duplication.
Refactoring covered by existing tests.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Updated after distributeSpaceToTracks new arguments. Copying the tracks to a Vector<GridTrack*> is
now done here.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Removed code duplication and switched to using distributeSpaceToTracks.
(WebCore::RenderGrid::distributeSpaceToTracks):
Refactored distributeSpaceToTracks to implement the distribution of any extra space above max breadth
as it was required to pass the tests (required to properly handling min-content > max). Also changed
the arguments of the function to better match the intent of the function.
- rendering/RenderGrid.h: Updated distributeSpaceToTracks's arguments.
- 1:51 PM Changeset in webkit [141162] by
-
- 3 edits in trunk/Source/WebCore
Remove all ShadowRoots during ElementShadow destruction
https://bugs.webkit.org/show_bug.cgi?id=108207
Reviewed by Dimitri Glazkov.
There's no reason to expose removeAllShadowRoots since the only legitimate
place to call it is right as we're destroying the ElementShadow.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::~Element): Remove call to removeAllShadowRoots()
- dom/ElementShadow.h:
(WebCore::ElementShadow::~ElementShadow): Call removeAllShadowRoots().
(ElementShadow): Make removeAllShadowRoots() private.
- 1:49 PM Changeset in webkit [141161] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 140834
BUG=164581
Review URL: https://codereview.chromium.org/12087064
- 1:32 PM Changeset in webkit [141160] by
-
- 4 edits2 adds in trunk
REGRESSION (r135628-135632): Double box shadow failure to render
https://bugs.webkit.org/show_bug.cgi?id=107833
Reviewed by Simon Fraser.
Source/WebCore:
Regression caused by http://trac.webkit.org/changeset/135629
The regression was due to faulty occlusion logic that was assuming
that drawing the background color of a render box background layer
could be skipped when the same layer also has an opaque image attached.
In the case where the background color is drawn for the purpose of
rendering a box shadow, the shadow is typically not
completely occluded by the background image because of the shadow
blur and/or offset. This patch fixes the problem by not culling a
background draw if it is used to draw a box shadow.
Test: fast/backgrounds/gradient-background-shadow.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Changing occlusion culling test to never cull background color
draw if it is used to draw a box shadow. This is because box shadows
can draw outside the border fill region.
LayoutTests:
New ref test verifies that box shadow is drawn when
background is an opaque image. Test uses an blue gradient
as background image. Reference uses blue background color.
- fast/backgrounds/gradient-background-shadow-expected.html: Added.
- fast/backgrounds/gradient-background-shadow.html: Added.
- 1:22 PM Changeset in webkit [141159] by
-
- 2 edits in trunk/Source/WebCore
Add RenderLayer::enclosingStackingContainer
https://bugs.webkit.org/show_bug.cgi?id=108211
Reviewed by Simon Fraser.
No new tests, no change in functionality.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::enclosingStackingContainer):
This function is similar to RenderLayer::stackingContainer, but may return the
layer itself if it's a stacking container.
- 1:19 PM Changeset in webkit [141158] by
-
- 7 edits4 deletes in branches/chromium/1364
Revert 141139
Merge 140202
Fix scrollRectToVisible in the presence of transforms
https://bugs.webkit.org/show_bug.cgi?id=105574
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-18
Reviewed by Simon Fraser.
Source/WebCore:
When scrolling to reveal an overflow layer, the required scroll was
being calculated in absolute coordinates. To properly account for
transforms, this calculation should be done in the local coordinates
of the renderBox.
Tests: editing/input/reveal-selection-transformed-overflow-parent.html
editing/input/reveal-selection-transformed-textarea.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
When scrolling to reveal an overflow layer, calculate the required
scroll in the local coordinates of the RenderBox.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteToLocalQuad):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
Add function to convert an absolute quad to a local quad.
LayoutTests:
- editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added.
- editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
Test that when scrolling an overflow layer to reveal a rect, the rect
passed to the parent to scroll is calculated properly.
- editing/input/reveal-caret-of-transformed-multiline-input.html: Added.
- editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.
Test that scrolling to reveal a rect works properly on a transformed
overflow layer.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12084049
TBR=kerz@chromium.org
Review URL: https://codereview.chromium.org/12087062
- 1:18 PM Changeset in webkit [141157] by
-
- 2 edits in trunk
[CMake] Add minimum version information for tool dependencies
https://bugs.webkit.org/show_bug.cgi?id=97592
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-29
Reviewed by Kenneth Rohde Christiansen.
Capture the minimum version information for the tools that are required
to build WebKit for all CMake based build systems.
- CMakeLists.txt:
- 1:14 PM Changeset in webkit [141156] by
-
- 1 edit1 move1 add in trunk/Source/WebCore
Rename TextBreakIteratorWinCE to TextBreakIteratorWchar
https://bugs.webkit.org/show_bug.cgi?id=108094
Reviewed by Ryosuke Niwa.
TextBreakIteratorWinCE does not contain any Windows CE specific code.
Rename it to TextBreakIteratorWchar to match the name in wtf/unicode.
- platform/text/wchar/TextBreakIteratorWchar.cpp: Renamed from Source/WebCore/platform/text/wince/TextBreakIteratorWinCE.cpp.
- 1:13 PM Changeset in webkit [141155] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/Modules/webdatabase/AbstractDatabase.cpp
Merge 141057
BUG=171951
Review URL: https://codereview.chromium.org/12094043
- 1:11 PM Changeset in webkit [141154] by
-
- 8 edits in trunk/Source/JavaScriptCore
Force debug builds to do bounds checks on contiguous property storage
https://bugs.webkit.org/show_bug.cgi?id=108212
Reviewed by Mark Hahnenberg.
Add a ContiguousData type that we use to represent contiguous property
storage. In release builds it is simply a pointer to the correct type,
but in debug builds it also carries the data length and performs bounds
checks. This means we don't have to add as many manual bounds assertions
when performing operations over contiguous data.
- dfg/DFGOperations.cpp:
- runtime/ArrayStorage.h:
(ArrayStorage):
(JSC::ArrayStorage::vector):
- runtime/Butterfly.h:
(JSC::ContiguousData::ContiguousData):
(ContiguousData):
(JSC::ContiguousData::operator[]):
(JSC::ContiguousData::data):
(JSC::ContiguousData::length):
(JSC):
(JSC::Butterfly::contiguousInt32):
(Butterfly):
(JSC::Butterfly::contiguousDouble):
(JSC::Butterfly::contiguous):
- runtime/JSArray.cpp:
(JSC::JSArray::sortNumericVector):
(ContiguousTypeAccessor):
(JSC::ContiguousTypeAccessor::getAsValue):
(JSC::ContiguousTypeAccessor::setWithValue):
(JSC::ContiguousTypeAccessor::replaceDataReference):
(JSC):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
- runtime/JSArray.h:
(JSArray):
- runtime/JSObject.cpp:
(JSC::JSObject::copyButterfly):
(JSC::JSObject::visitButterfly):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::rageConvertDoubleToContiguous):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::rageEnsureContiguousSlow):
(JSC::JSObject::ensureLengthSlow):
- runtime/JSObject.h:
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::rageEnsureContiguous):
(JSObject):
(JSC::JSObject::indexingData):
(JSC::JSObject::currentIndexingData):
- 1:08 PM Changeset in webkit [141153] by
-
- 5 edits in trunk/Source/WebKit/chromium
[Chromium] Correct zoom for focused node when using compositor scaling
https://bugs.webkit.org/show_bug.cgi?id=107599
Reviewed by Adam Barth.
When applyDeviceScaleFactorInCompositor, targetScale should exclude device scale factor.
When applyPageScaleFactorInCompositor, caret size and content sizes are in css pixels and they should be in the viewport of the new scale.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):
(WebKit):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode): Extracted from scrollFocusedNodeIntoRect() to ease testing.
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp: Updated test DivScrollEditableTest
- tests/data/get_scale_for_zoom_into_editable_test.html: Moved the logic of onload script (which seems not to work) into WebFrameTest.cpp.
- 1:04 PM Changeset in webkit [141152] by
-
- 2 edits in trunk/Tools
[EFL] Add Toggle fullscreen (F11) to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108122
Reviewed by Antonio Gomes.
Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
- MiniBrowser/efl/main.c:
(on_key_down): Add 'F11' key handler.
- 1:04 PM WinCE edited by
- (diff)
- 12:59 PM Changeset in webkit [141151] by
-
- 10 edits in trunk/Source
MediaStream API: A MediaStreamComponent should be able to return the MediaStreamDescriptor it belongs to
https://bugs.webkit.org/show_bug.cgi?id=108173
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebMediaStreamComponent.h:
(WebKit):
(WebMediaStreamComponent):
Source/WebCore:
To be able to return the MediaStreamDescriptor a MediaStreamComponent belongs to the "ownership"
of the MediaStreamDescriptor needed to move from a MediaStreamTrack to the MediaStreamComponent.
This is also better from an architectonic view as well.
Patch covered by existing tests.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::addRemoteTrack):
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::setEnabled):
- Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
- Modules/mediastream/RTCStatsRequestImpl.cpp:
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
- platform/chromium/support/WebMediaStreamComponent.cpp:
(WebKit::WebMediaStreamComponent::stream):
(WebKit):
- platform/mediastream/MediaStreamComponent.h:
(WebCore):
(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::stream):
(WebCore::MediaStreamComponent::setStream):
(WebCore::MediaStreamComponent::MediaStreamComponent):
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
- 12:56 PM Changeset in webkit [141150] by
-
- 11 edits in trunk/Source/WebKit2
Encode/decode message send flags in the message
https://bugs.webkit.org/show_bug.cgi?id=108208
Reviewed by Beth Dakin.
This is another step towards getting rid of MessageID.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeUInt8):
(CoreIPC):
- Platform/CoreIPC/ArgumentDecoder.h:
(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decode):
(CoreIPC):
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC):
- Platform/CoreIPC/ArgumentEncoder.h:
(ArgumentEncoder):
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/CoreIPC/MessageDecoder.h:
(CoreIPC::MessageDecoder::messageSendFlags):
(MessageDecoder):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC):
(CoreIPC::MessageEncoder::MessageEncoder):
(CoreIPC::MessageEncoder::~MessageEncoder):
(CoreIPC::MessageEncoder::setMessageSendFlags):
- Platform/CoreIPC/MessageEncoder.h:
(MessageEncoder):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(CoreIPC):
- 12:56 PM Changeset in webkit [141149] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows, WinCairo] Unreviewed build fix after r141050
- JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Update symbols
to match JavaScriptCore.vcproj version.
- 12:55 PM Changeset in webkit [141148] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 140520
BUG=170188
Review URL: https://codereview.chromium.org/12084050
- 12:54 PM Changeset in webkit [141147] by
-
- 2 edits in trunk/LayoutTests
Current error reporting method used by check-layout.js should not affect subsequent sub-tests using checking data-offset-y.
https://bugs.webkit.org/show_bug.cgi?id=105407
Patch by Pravin D <pravind.2k4@gmail.com> on 2013-01-29
Reviewed by Tony Chang.
When a testcase is processed by check-layout.js, the result is written just after the node being processed. This causes
offsetTop of subsequent sub-testcases to altered. If however if we process the nodes in the reverse order in which they
appear in the DOM tree, the result of node being processed will not affect the offsetTop of susequent nodes.
- resources/check-layout.js:
- 12:51 PM Changeset in webkit [141146] by
-
- 1 edit2 copies in branches/chromium/1364
Merge 139806
BUG=168489
Review URL: https://codereview.chromium.org/12087060
- 12:48 PM Changeset in webkit [141145] by
-
- 8 edits in branches/chromium/1364/Source/WebCore/inspector
Merge 140127
BUG=170237
Review URL: https://codereview.chromium.org/12077053
- 12:40 PM Changeset in webkit [141144] by
-
- 1 edit in branches/chromium/1364/Source/WebCore/html/parser/HTMLConstructionSite.cpp
Merge 140537
BUG=170381
Review URL: https://codereview.chromium.org/12091046
- 12:37 PM Changeset in webkit [141143] by
-
- 1 edit4 copies in branches/chromium/1364
Merge 140101
BUG=170381
Review URL: https://codereview.chromium.org/12088052
- 12:32 PM Changeset in webkit [141142] by
-
- 13 edits in trunk/Source
IndexedDB: Pass metadata in to IDBOpenDBRequest.onUpgradeNeeded/onSuccess
https://bugs.webkit.org/show_bug.cgi?id=103920
Reviewed by Dimitri Glazkov.
Source/WebCore:
Update IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded to
pass through a metadata parameter. While there, remove the unused
IDBTransactionBackendInterface parameter to onUpgradeNeeded.
As this is another step in the IDB refactor, I've simplified future cleanup
work by making the WebKit API code still use the old API. This
will make it possible to outright remove code on the chromium side rather
than another three-step checkin.
No new tests, as this is more refactoring.
- Modules/indexeddb/IDBCallbacks.h:
(WebCore::IDBCallbacks::onUpgradeNeeded): new method signature.
(WebCore::IDBCallbacks::onSuccess): new method signature.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded): use passed-in metadata.
(WebCore::IDBOpenDBRequest::onSuccess): use passed-in metadata.
- Modules/indexeddb/IDBOpenDBRequest.h:
(IDBOpenDBRequest):
Source/WebKit/chromium:
Support the new IDBCallbacks::onSuccess and IDBCallbacks::onUpgradeNeeded
while maintaining chromium compatibility by shimming in the old API
in the WebKit side. Future code will clean this up so that it is just a
pass-through as it was before.
- public/WebIDBCallbacks.h:
(WebKit):
(WebKit::WebIDBCallbacks::onSuccess): new method signature.
(WebKit::WebIDBCallbacks::onUpgradeNeeded): new method signature.
- src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::onSuccess): call on new method signature proxies through old API.
(WebKit):
(WebKit::IDBCallbacksProxy::onUpgradeNeeded): call on new method signature proxies through old API.
- src/IDBCallbacksProxy.h:
(IDBCallbacksProxy):
- src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onSuccess): call on old WebKit proxy signature calls new API.
(WebKit):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded): call on old WebKit proxy signature calls new API.
- src/WebIDBCallbacksImpl.h:
(WebIDBCallbacksImpl):
- tests/IDBAbortOnCorruptTest.cpp: new method signature.
(WebCore::MockIDBCallbacks::onSuccess):
- tests/IDBDatabaseBackendTest.cpp: new method signature.
- 12:26 PM Changeset in webkit [141141] by
-
- 6 edits3 adds in trunk
Canvas support for isPointInStroke
https://bugs.webkit.org/show_bug.cgi?id=108185
Reviewed by Dean Jackson.
Source/WebCore:
isPointInStroke(x,y) returns true if a point hits the stroke
with applied stroke styles like dashArray, lineCap, lineJoin, lineWidth.
The syntax is similar to isPointInPath, which returns true if a point hits
the fill area of a path.
Firefox implemented isPointInStroke originally and unprefixed it recently:
https://bugzilla.mozilla.org/show_bug.cgi?id=803124
Test: fast/canvas/canvas-isPointInStroke.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasStrokeStyleApplier::strokeStyle): Take dashArray and lineDashOffset into account.
(WebCore):
(WebCore::CanvasRenderingContext2D::isPointInStroke): The implementation of the function.
- html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
- html/canvas/CanvasRenderingContext2D.idl: Added operation to interface.
LayoutTests:
Test the implementation of isPointOfStroke with all stroke style
properties in Canvas.
- fast/canvas/canvas-isPointInStroke-expected.txt: Added.
- fast/canvas/canvas-isPointInStroke.html: Added.
- fast/canvas/script-tests/canvas-isPointInStroke.js: Added.
- fast/canvas/canvas-isPointInStroke-expected.txt: Added.
- fast/canvas/canvas-isPointInStroke.html: Added.
- fast/canvas/script-tests/canvas-isPointInStroke.js: Added.
- inspector/profiler/canvas2d/canvas2d-api-changes.html: Added property for isPointInStroke.
- 12:19 PM Changeset in webkit [141140] by
-
- 4 edits4 moves in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r141122.
Removing a few duplicate test expectations.
- platform/gtk/TestExpectations:
- platform/gtk/fast/text/midword-break-before-surrogate-pair-expected.txt:
- platform/gtk/fonts/complex-text-shadows-expected.txt: Replaced with LayoutTests/platform/gtk/platform/gtk/fonts/complex-text-shadows-expected.txt.
- platform/gtk/fonts/font-face-with-complex-text-expected.txt: Replaced with LayoutTests/platform/gtk/platform/gtk/fonts/font-face-with-complex-text-expected.txt.
- platform/gtk/fonts/non-bmp-characters-expected.png: Copied from LayoutTests/platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.png.
- platform/gtk/fonts/non-bmp-characters-expected.txt: Copied from LayoutTests/platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.txt.
- platform/gtk/platform/gtk/fonts/complex-text-shadows-expected.txt: Removed.
- platform/gtk/platform/gtk/fonts/font-face-with-complex-text-expected.txt: Removed.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.png: Removed.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.txt: Removed.
- platform/gtk/svg/text/non-bmp-positioning-lists-expected.txt:
- 12:12 PM Changeset in webkit [141139] by
-
- 7 edits4 copies in branches/chromium/1364
Merge 140202
Fix scrollRectToVisible in the presence of transforms
https://bugs.webkit.org/show_bug.cgi?id=105574
Patch by Chris Hopman <cjhopman@google.com> on 2013-01-18
Reviewed by Simon Fraser.
Source/WebCore:
When scrolling to reveal an overflow layer, the required scroll was
being calculated in absolute coordinates. To properly account for
transforms, this calculation should be done in the local coordinates
of the renderBox.
Tests: editing/input/reveal-selection-transformed-overflow-parent.html
editing/input/reveal-selection-transformed-textarea.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
When scrolling to reveal an overflow layer, calculate the required
scroll in the local coordinates of the RenderBox.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::absoluteToLocalQuad):
(WebCore):
- rendering/RenderObject.h:
(RenderObject):
Add function to convert an absolute quad to a local quad.
LayoutTests:
- editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added.
- editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
Test that when scrolling an overflow layer to reveal a rect, the rect
passed to the parent to scroll is calculated properly.
- editing/input/reveal-caret-of-transformed-multiline-input.html: Added.
- editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.
Test that scrolling to reveal a rect works properly on a transformed
overflow layer.
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12084049
- 12:10 PM Changeset in webkit [141138] by
-
- 6 edits2 copies in branches/chromium/1364
Merge 140748
BUG=171907
Review URL: https://codereview.chromium.org/12092048
- 12:07 PM Changeset in webkit [141137] by
-
- 2 edits in trunk/Tools
[CMake] Use offical Windows CE support
https://bugs.webkit.org/show_bug.cgi?id=108061
Reviewed by Laszlo Gombos.
Recent version of CMake has added Windows CE support, but uses a
slightly different interface than the patched version used before.
Change the command line parameters to use the offical CMake binaries.
- Scripts/webkitdirs.pm:
(cmakeBasedPortArguments):
- 12:06 PM Changeset in webkit [141136] by
-
- 25 edits3 adds in trunk
.: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Adam Barth.
- Source/autotools/symbols.filter: Expose MemoryCache::resourceForURL().
Source/WebCore: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Adam Barth.
Test: http/tests/cache/cached-main-resource.html
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute.
(WebCore):
- dom/Document.h:
(Document):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since
MainResourceLoader will take care of it.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also,
ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader.
(WebCore::MainResourceLoader::identifier):
- loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader
to better describe when it is used.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary.
(WebCore::CachedRawResource::willSendRequest): Note the redirects we received.
(WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store".
- loader/cache/CachedRawResource.h:
(CachedRawResource):
(RedirectPair):
(WebCore::CachedRawResource::RedirectPair::RedirectPair):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addClientToSet): Don't return cached data for a main resource synchronously
- loader/cache/CachedResource.h:
(WebCore::CachedResource::canReuse):
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource): Leave cahce reuse of main resources off for chromium for now.
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources.
- testing/Internals.cpp:
(WebCore::Internals::isPreloaded):
(WebCore):
(WebCore::Internals::isLoadingFromMemoryCache):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/win: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Adam Barth.
- WebKit.vcproj/WebKitExports.def.in: Expose some MemoryCache symbols for use in Internals.
LayoutTests: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667.
Reviewed by Adam Barth.
- http/tests/cache/cached-main-resource-expected.txt: Added.
- http/tests/cache/cached-main-resource.html: Added.
- http/tests/cache/resources/cacheable-iframe.php: Added.
- http/tests/inspector/resource-har-pages-expected.txt:
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
- http/tests/misc/link-rel-icon-beforeload-expected.txt:
- platform/chromium/TestExpectations:
- 11:09 AM Changeset in webkit [141135] by
-
- 2 edits in trunk/Source/WebCore
Fix a problem that deferred image decoding is enabled for multiframe images
https://bugs.webkit.org/show_bug.cgi?id=108152
Patch by Min Qin <qinmin@chromium.org> on 2013-01-29
Reviewed by Stephen White.
Deferred image decoding should only work for single frame images now.
However, using ImageDecoder::repetitionCount() does not capture all the cases.
Enforce the rule using ImageDecoder::frameCount()==1.
Fixing a failing layout test: platform/chromium/virtual/deferred/fast/images/icon-0colors.html
- platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
- 11:01 AM Changeset in webkit [141134] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Fix contents size calculation for page scale initialization
https://bugs.webkit.org/show_bug.cgi?id=108204
Reviewed by enne.
My previous patch http://webk.it/107424 had a few issues that are
blocking WebKit roll.
- We still need the layout in resize() given that
http://webk.it/107922 was reverted.
- I deleted code used only for the old page-scale mode in
contentsSize(), but this needs to wait until WebKit roll since it's
making bots fail in this short term.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::contentsSize):
- 10:47 AM WebKitIDL edited by
- Typos. (diff)
- 10:30 AM WebKitIDL edited by
- (diff)
- 10:22 AM Changeset in webkit [141133] by
-
- 2 edits in trunk/LayoutTests
Add back test expectations that got erroneously removed in r140981.
- platform/mac/TestExpectations:
- 10:22 AM Changeset in webkit [141132] by
-
- 3 edits in trunk/Source/WebCore
Move ElementShadow creation to ElementRareData
https://bugs.webkit.org/show_bug.cgi?id=108195
Reviewed by Dimitri Glazkov.
Move the creation of ElementShadow to ElementRareData
for better encapsulation, and get rid of ElementRareData::setShadow.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::~Element): Use clearShadow() instead of setShadow which is removed.
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow): Use ElementRareData::ensureShadow().
- dom/ElementRareData.h:
(WebCore::ElementRareData::clearShadow): Added.
(WebCore::ElementRareData::ensureShadow): Added.
- 10:16 AM Changeset in webkit [141131] by
-
- 3 edits in trunk/Source/WebCore
[chromium] Unreviewed build fix.
Revert my revert at 141033 which can cause deadlock.
- platform/graphics/chromium/DiscardablePixelRef.cpp:
(WebCore::DiscardablePixelRefAllocator::allocPixelRef):
(WebCore::DiscardablePixelRef::DiscardablePixelRef):
- platform/graphics/chromium/DiscardablePixelRef.h:
(DiscardablePixelRef):
- 10:09 AM Changeset in webkit [141130] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Unreviewed DEPS roll.
Roll Chromium DEPS to 179332.
- DEPS:
- 10:07 AM Changeset in webkit [141129] by
-
- 8 edits1 copy3 adds in trunk/Tools
QueueStatusServer needs pages to display historical queue data
https://bugs.webkit.org/show_bug.cgi?id=107659
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-29
Reviewed by Eric Seidel.
Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
- QueueStatusServer/app.yaml:
- QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
(get_time_unit):
- QueueStatusServer/filters/webkit_extras.py:
(webkit_linkify):
(webkit_bug_id):
(webkit_attachment_id):
(results_link):
(queue_status_link):
(queue_charts_link):
- QueueStatusServer/handlers/queuecharts.py: Added.
(QueueCharts):
(QueueCharts.get):
(QueueCharts._get_min_med_max):
(QueueCharts._get_patch_data):
(QueueCharts._get_patch_logs):
(QueueCharts._get_queue_data):
(QueueCharts._get_queue_logs):
(QueueCharts._get_time_unit):
(QueueCharts._get_timestamp):
(QueueCharts._get_view_range):
- QueueStatusServer/handlers/queuestatus.py:
(QueueStatus.get):
- QueueStatusServer/index.yaml:
- QueueStatusServer/main.py:
- QueueStatusServer/model/queuelog.py:
(QueueLog):
(QueueLog.create_key):
(QueueLog.get_at):
(QueueLog.get_current):
(QueueLog.get_or_create):
(QueueLog._get_or_create_txn):
- QueueStatusServer/stylesheets/charts.css: Added.
(.chart):
(.choices):
- QueueStatusServer/templates/queuecharts.html: Added.
- QueueStatusServer/templates/queuestatus.html:
- 9:58 AM Changeset in webkit [141128] by
-
- 13 edits in trunk/Source
[Chromium] IndexedDB: Let callers specify reason (error) for aborting transaction
https://bugs.webkit.org/show_bug.cgi?id=107851
Reviewed by Tony Chang.
Source/WebCore:
Internal to the back-end, callers are able to abort transactions and specify a reason
as an IDBDatabaseError, e.g. ConstraintError. Expose this to the WebKit/chromium/public
API so that intermediate layers can specify reasons as well, e.g. QuotaExceededError.
Test will land in Chromium as fix for crbug.com/113118
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::abort): Added overload that takes error.
- Modules/indexeddb/IDBDatabaseBackendImpl.h: Ditto.
- Modules/indexeddb/IDBDatabaseBackendInterface.h: Ditto.
Source/WebKit/chromium:
Let Chromium call abort() on a transaction and specify a reason, specifically for
QuotaExceededError.
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::abort): New overload for abort() that takes an error.
- public/WebIDBDatabaseError.h:
(WebKit::WebIDBDatabaseError::WebIDBDatabaseError): Overloaded constructor/assign that takes error.
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::abort): New overload for abort() that takes an error.
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy): Ditto.
- src/WebIDBDatabaseError.cpp: Implementation of overload ctor/assign.
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::abort): New overload for abort() that takes an error.
- src/WebIDBDatabaseImpl.h: Ditto.
- tests/IDBDatabaseBackendTest.cpp: Overload stubs for Mock class.
- 9:52 AM Changeset in webkit [141127] by
-
- 4 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderTextTrackCue::layout
https://bugs.webkit.org/show_bug.cgi?id=108197
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-rendering-tree-is-removed-properly.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ensure the display tree
is removed when the cue is removed from the list of cues.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::~TextTrackCue): Enfore display tree removal.
LayoutTests:
Added test that triggers the crash. Verified proper removal of the tree.
- media/track/track-cue-rendering-tree-is-removed-properly-expected.txt: Added.
- media/track/track-cue-rendering-tree-is-removed-properly.html: Added.
- 9:50 AM Changeset in webkit [141126] by
-
- 9 edits in trunk
[GTK] Missing build flags when building with Harfbuzz
https://bugs.webkit.org/show_bug.cgi?id=108174
Reviewed by Martin Robinson.
Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
parameter will be added to linking lines when needed.
Source/WebKit/gtk:
- GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
Source/WebKit2:
- GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
- UIProcess/API/gtk/tests/GNUmakefile.am: Ditto.
Tools:
- GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
- MiniBrowser/gtk/GNUmakefile.am: Ditto.
- TestWebKitAPI/GNUmakefile.am: Ditto.
- 9:44 AM Changeset in webkit [141125] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Disable WebFrameTest.pageScaleFactorShrinksViewport (pending investigation after r141053).
- tests/WebFrameTest.cpp:
- 9:32 AM Changeset in webkit [141124] by
-
- 2 edits2 adds in trunk
On HarfbuzzNG ports, Arabic TATWEEL is not joined.
https://bugs.webkit.org/show_bug.cgi?id=108037
Reviewed by Tony Chang.
The tatweel (U+0640) is being split into a separate run, because its script is USCRIPT_COMMON.
It has script extensions for USCRIPT_ARABIC, so I think it shouldn't trigger a new run.
Test: fast/text/international/arabic-tatweel-join.html
- platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
- 9:29 AM Changeset in webkit [141123] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a failing ref html test.
- platform/qt/TestExpectations:
- 9:25 AM Changeset in webkit [141122] by
-
- 6 edits4 adds in trunk
[Freetype] Cannot use characters outside the BMP
https://bugs.webkit.org/show_bug.cgi?id=108102
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-29
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Test: platform/gtk/fonts/non-bmp-characters.html
Instead of never handling surrogate pairs when dealing with UChar arrays,
abstract way the logic for this into UTF16UChar32Iterator and use it
everywhere in Freetype. This allows the Freetype backend to render
non-BMP characters which are always represented as surrogate pairs in
UTF-16.
- GNUmakefile.list.am: Added UTF16UChar32Iterator to the source list.
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters): Use the new iterator.
(WebCore::FontCache::getFontDataForCharacters): Ditto.
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill): Ditto. Remove the early return when dealing
with non-BMP data.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters): Use the new iterator.
- platform/graphics/freetype/UTF16UChar32Iterator.h: Added. An iterator that
extracts UChar32 from UTF-16 UChar arrays.
- GNUmakefile.list.am:
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters):
(WebCore::FontCache::getFontDataForCharacters):
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters):
- platform/graphics/freetype/UTF16UChar32Iterator.h: Added.
(WebCore):
(UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::end):
(WebCore::UTF16UChar32Iterator::next):
- GNUmakefile.list.am:
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::createFontConfigPatternForCharacters):
- platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters):
- platform/graphics/freetype/UTF16UChar32Iterator.h: Added.
(WebCore):
(UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::UTF16UChar32Iterator):
(WebCore::UTF16UChar32Iterator::end):
(WebCore::UTF16UChar32Iterator::next):
LayoutTests:
Added a pixel test for rendering non-BMP characters.
- platform/gtk/fonts/non-bmp-characters.html: Added.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.png: Added.
- platform/gtk/platform/gtk/fonts/non-bmp-characters-expected.txt: Added.
- 9:04 AM Changeset in webkit [141121] by
-
- 4 edits in trunk/Source/WebCore
Don't overlap test for composited scroll DIVs after scroll
https://bugs.webkit.org/show_bug.cgi?id=107471
Patch by Glenn Hartmann <hartmanng@chromium.org> on 2013-01-29
Reviewed by Simon Fraser.
We don't need to test for overlap after scroll when both
usesCompositedScrolling and !hasOutOfFlowPositionedDescendant
because:
a) Since we're using composited-scrolling, the composited region
presented by the composited-scrolling element to other non-descendant
layers doesn't change during composited scrolling (it's always the
entire scroll layer), and
b) Since we have no out of flow positioned descendants, the scrolling
descendants all move together, so their overlap with respect to each
other cannot change.
So no descendants nor any non-descendants can have their overlap
affected, so it's safe to skip testing.
No new tests (no change in behaviour).
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
- rendering/RenderLayerCompositor.h:
- 8:55 AM Changeset in webkit [141120] by
-
- 13 edits in branches/chromium/1397/Source/WebCore/bindings/v8
Revert 140611
[V8] Reduce usage of deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=107674
Reviewed by Adam Barth.
No tests. No change in behavior.
- bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::evaluate):
- bindings/v8/NPV8Object.cpp:
(_NPN_Enumerate):
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::bindToWindowObject):
(WebCore::ScriptController::disableEval):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::compileScript):
- bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
- bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::addListener):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12087054
- 8:55 AM Changeset in webkit [141119] by
-
- 17 edits2 adds in trunk
Implement pseudoElement attribute on transition DOM events.
https://bugs.webkit.org/show_bug.cgi?id=107986
Reviewed by Julien Chaffraix.
Source/WebCore:
Implement the pseudoElement attribute documented here :
http://dev.w3.org/csswg/css3-transitions/#transition-events.
This add a new attribute to the transition DOM event useful when
animating pseudo elements. As they are not accessible in JS, it's
very useful to get on which pseudo element the transition just ended.
This patch adds the new attribute on the IDLs of DOM transition events as well
as adding it to the C++ classes representing them. The event
dispatching code have been patched to change the target of the event
(we can't send the current target as it is the actual DOM
representation of the pseudo element).
Test: fast/css-generated-content/pseudo-transition-event.html
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingTargetRules): Change the target of the
event in the case of a pseudo element. We can't expose them through the
public interface so the target is the node they belong to.
(WebCore::EventDispatcher::ensureEventAncestors):
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventTarget.cpp:
(WebCore::createMatchingPrefixedEvent):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::pseudoElementNameForEvents):
(WebCore):
- dom/PseudoElement.h:
- dom/TransitionEvent.cpp:
(WebCore::TransitionEventInit::TransitionEventInit):
(WebCore::TransitionEvent::TransitionEvent):
(WebCore::TransitionEvent::pseudoElement):
(WebCore):
- dom/TransitionEvent.h:
(TransitionEventInit):
(WebCore::TransitionEvent::create):
(TransitionEvent):
- dom/TransitionEvent.idl:
- dom/WebKitTransitionEvent.cpp:
(WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit):
(WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
(WebCore::WebKitTransitionEvent::pseudoElement):
(WebCore):
- dom/WebKitTransitionEvent.h:
(WebKitTransitionEventInit):
(WebCore::WebKitTransitionEvent::create):
(WebKitTransitionEvent):
- dom/WebKitTransitionEvent.idl:
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Pass
the pseudo element name when creating the Event objects. If the element
is not a pseudo element then the name will be empty which is what the
spec is telling to do. If the element is a pseudo element then the name
will be the pseudo element's name with "::" as a prefix.
LayoutTests:
Add new tests to cover the feature.
- fast/css-generated-content/pseudo-transition-event-expected.txt: Added.
- fast/css-generated-content/pseudo-transition-event.html: Added.
- fast/events/constructors/transition-event-constructor-expected.txt:
- fast/events/constructors/transition-event-constructor.html:
- fast/events/constructors/webkit-transition-event-constructor-expected.txt:
- fast/events/constructors/webkit-transition-event-constructor.html:
- 8:54 AM Changeset in webkit [141118] by
-
- 14 edits in branches/chromium/1397/Source/WebCore
Revert 138962
ResourceHandle::willLoadFromCache is evil
https://bugs.webkit.org/show_bug.cgi?id=106147
Reviewed by Brady Eidson.
For back/forward navigations to a page that's a result of form submission, we may
never silently re-submit the form. So, we show a warning dialog when about to re-submit,
but try to load from cache if possible.
This patch changes the logic so that we always try to fetch from cache, without
any preflighting. If cache load fails, we restart the load as a known re-submit.
No behavior change expected, so no tests.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): Added a FIXME.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Amended a FIXME with some information about why this call may still be needed.
- loader/FrameLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Pass an explicit argument for unchanged caching behavior. (WebCore::FrameLoader::reloadWithOverrideEncoding): Added a FIXME. This function can silently re-submit a form. (WebCore::FrameLoader::addExtraFieldsToMainResourceRequest): Added a FIXME about an incorrect use of current load type. (WebCore::FrameLoader::addExtraFieldsToRequest): Make sure that a correct caching policy is used for subresources even if main resource was loaded from cache. We didn't need that before because initial request had wrong extra fields due to a use of m_loadType when it was first called. Removed code to change caching policy for b/f navigations. This function does not have enough context to decide what the policy should be. (WebCore::FrameLoader::loadDifferentDocumentItem): Added an argument telling the function whether it should attempt loading from cache. It should do that on first attempt to navigate to a form submission result, but not if that failed. Pass a correct loadType - m_loadType is one for _previous_ load. Removed a special case for https - we've long stopped prohibiting caching of https resources, and using a resource that's already cached should definitely be allowed. (WebCore::FrameLoader::loadItem): Pass an explicit argument for unchanged caching behavior. (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad): Added.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::notifyFinished): Removed a check for m_resource being null, because we were immediately dereferencing it anyway. Call retryAfterFailedCacheOnlyMainResourceLoad() to let FrameLoader restart the navigation.
- platform/network/ResourceHandle.h:
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/chromium/ResourceHandle.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/qt/ResourceHandleQt.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/win/ResourceHandleWin.cpp: Removed willLoadFromCache() - the new logic is cross-platform.
TBR=ap@apple.com
Review URL: https://codereview.chromium.org/12090050
- 8:51 AM Changeset in webkit [141117] by
-
- 1 add in branches/chromium/1397/codereview.settings
for drovering
- 8:50 AM Changeset in webkit [141116] by
-
- 1 copy in branches/chromium/1397
branching to do dev
- 8:49 AM Changeset in webkit [141115] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Reclassified one IDB failure as a flaky crasher.
Added a test expectation for a flaky crasher that's failnig
due to probably malfunctioning accessibility code.
- platform/gtk/TestExpectations:
- 8:45 AM Changeset in webkit [141114] by
-
- 6 edits in trunk/Source
[Qt] Implement GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=103998
Reviewed by Simon Hausmann.
Source/JavaScriptCore:
Implements the activity triggered garbage collector.
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
- runtime/GCActivityCallback.h:
(GCActivityCallback):
(DefaultGCActivityCallback):
Source/WebCore:
Implements the activity triggered garbage collector,
and disables the timer based fallback.
- bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
- bindings/js/GCController.h:
(GCController):
- 8:09 AM Changeset in webkit [141113] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix bottom span in token highlight in DTE
https://bugs.webkit.org/show_bug.cgi?id=108194
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-29
Reviewed by Pavel Feldman.
Change css style for token highlight from "border" to "outline" to
avoid border included in box dimensions.
No new tests: no change in behaviour.
- inspector/front-end/textEditor.css:
(.text-editor-token-highlight):
- 8:02 AM Changeset in webkit [141112] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after r140927.
https://bugs.webkit.org/show_bug.cgi?id=108190.
- platform/qt/TestExpectations:
- 7:52 AM Changeset in webkit [141111] by
-
- 5 edits in trunk
Web Inspector: introduce HighlightDescriptor interface in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108161
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-29
Reviewed by Pavel Feldman.
Source/WebCore:
Introduce new HighlightDescriptor interface and its
RegexHighlightDescriptor implementation and use it in DTE to
support overlay highlight.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.highlightRegex):
(WebInspector.DefaultTextEditor.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
(WebInspector.TextEditorMainPanel.HighlightDescriptor): Added.
(WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.affectsLine):
(WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.rangesForLine):
(WebInspector.TextEditorMainPanel.HighlightDescriptor.prototype.cssClass):
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor): Added.
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.affectsLine):
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.rangesForLine):
(WebInspector.TextEditorMainPanel.RegexHighlightDescriptor.prototype.cssClass):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._highlight):
(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._removeHighlight):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.removeRegexHighlight):
LayoutTests:
Correct layout test according to refactoring changes.
- inspector/editor/text-editor-highlight-regexp.html:
- 7:29 AM Changeset in webkit [141110] by
-
- 10 edits in trunk
[EFL] Unified text checker implementation.
https://bugs.webkit.org/show_bug.cgi?id=107682
Reviewed by Anders Carlsson.
Source/WebCore:
No new tests, covered by editing/spelling tests.
- platform/text/TextChecking.h:
(WebCore):
Enabling unified text checker feature for WebKit-EFL.
Source/WebKit/efl:
Add an empty checkTextOfParagraph implementation for WK1-EFL
to do not break build when WTF_USE_UNIFIED_TEXT_CHECKING
is enabled.
- WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
(WebCore::EditorClientEfl::checkTextOfParagraph):
Source/WebKit2:
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit):
(WebKit::TextChecker::checkTextOfParagraph):
Allow to check spelling for multiple words,
their misspelling location and length are saved to the vector.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
(WebKit::WebEditorClient::checkTextOfParagraph):
(WebKit):
As spelling implementation is exposed to UIProcess,
send a meesage to UIProcess to call TextChecker::checkTextOfParagraph.
LayoutTests:
- platform/efl-wk2/TestExpectations:
Skip context-menu-suggestions.html until
https://bugs.webkit.org/show_bug.cgi?id=107684 lands.
- 7:01 AM Changeset in webkit [141109] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Wrong indent in Styles sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=108186
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-01-29
Reviewed by Alexander Pavlov.
Added an extra selector to prevent a conflict with a rule in elementsPanel.css.
No new tests.
- inspector/front-end/inspector.css:
(.pane.expanded .section .properties, .event-bar .event-properties):
- 6:53 AM Changeset in webkit [141108] by
-
- 4 edits in trunk
Enable Workers for WinCE
https://bugs.webkit.org/show_bug.cgi?id=108099
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-29
Reviewed by Gyuyoung Kim.
WORKERS are enabled for all CMake based ports except WinCE.
Turn on WORKERS for all CMake based ports.
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- 6:48 AM Changeset in webkit [141107] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][WK1] Fix QObject Bridge tests expected output.
https://bugs.webkit.org/show_bug.cgi?id=107827
Reviewed by Simon Hausmann.
The "not a function" TypeError now includes the call that caused the error.
Correct expected values accordingly.
- tests/qobjectbridge/tst_qobjectbridge.cpp:
(tst_QObjectBridge::connectAndDisconnect):
- 6:37 AM Changeset in webkit [141106] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-29
- platform/qt-5.0-wk2/TestExpectations: Skip broken plugin tests after r141051.
- 6:19 AM Changeset in webkit [141105] by
-
- 14 edits in trunk/Source/WebCore
[Chromium] Unreviewed gardening.
Update bindings-tests results after http://trac.webkit.org/changeset/141034.
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8Float64Array::createWrapper):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestActiveDOMObject::createWrapper):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestCustomNamedGetter::createWrapper):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestEventConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestEventTarget::createWrapper):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestException::createWrapper):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestInterface::createWrapper):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestMediaQueryListListener::createWrapper):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestNamedConstructor::createWrapper):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestNode::createWrapper):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestObj::createWrapper):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestOverloadedConstructors::createWrapper):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::checkTypeOrDieTrying):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):
- 6:14 AM Changeset in webkit [141104] by
-
- 2 edits3 deletes in trunk/LayoutTests
Unreviewed gardening. Update generic expected file after r141031.
Remove Chromium, GTK and Qt specific expected files, because they are the same as the generic expected file.
- 6:07 AM FeatureFlags edited by
- Remove SPEECH_INPUT - see 141092 (diff)
- 5:49 AM Changeset in webkit [141103] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Skipping tests broken by r141051.
- platform/efl-wk2/TestExpectations:
- 5:22 AM Changeset in webkit [141102] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Add API to prefetch DNS of a given hostname to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99695
Reviewed by Anders Carlsson.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_prefetch_dns): Public method to resolve the
domain name in advance for the given hostname.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_web_context_prefetch_dns.
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage): Parse PrefetchDNS message
and call WebCore::prefetchDNS() with the given hostname.
(didReceiveMessage): Call webkitWebExtensionDidReceiveMessage().
(webkitWebExtensionCreate): Add implementation for
didReceiveMessage callback.
- 4:59 AM Changeset in webkit [141101] by
-
- 2 edits3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip failing tests. https://bugs.webkit.org/show_bug.cgi?id=108175.
- platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added after r140999.
- platform/qt/fast/js/regress/integer-modulo-expected.txt: Added after r141031.
- 4:57 AM Changeset in webkit [141100] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: in inspector-protocol tests do not swallow errors
https://bugs.webkit.org/show_bug.cgi?id=108087
Patch by Peter Rybin <peter.rybin@gmail.com> on 2013-01-29
Reviewed by Pavel Feldman.
Additional checks are added. Debuggee is more aggressive at
when to kill the test.
- http/tests/inspector-protocol/resources/InspectorTest.js:
- http/tests/inspector-protocol/resources/protocol-test.js:
(runTest):
- 4:54 AM Changeset in webkit [141099] by
-
- 2 edits in trunk/Source/JavaScriptCore
Compilation warning in JSC
https://bugs.webkit.org/show_bug.cgi?id=108178
Reviewed by Kentaro Hara.
Fixed 'comparison between signed and unsigned integer' warning in JSC::Structure constructor.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- 4:43 AM Changeset in webkit [141098] by
-
- 8 edits in trunk
Web Inspector: [Canvas] support instrumenting canvases in iframes (backend side)
https://bugs.webkit.org/show_bug.cgi?id=107951
Reviewed by Pavel Feldman.
Source/WebCore:
Accept optional FrameId argument for captureFrame and startCapturing commands.
Add event to the protocol to inform about instrumented canvas context creation.
- inspector/Inspector.json:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::hasUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::captureFrame):
(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
(WebCore::InspectorCanvasAgent::replayTraceLog):
(WebCore::InspectorCanvasAgent::getResourceInfo):
(WebCore::InspectorCanvasAgent::getResourceState):
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::wrapWebGLRenderingContextForInstrumentation):
(WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
(WebCore):
(WebCore::InspectorCanvasAgent::findFramesWithUninstrumentedCanvases):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::frameDetached):
- inspector/InspectorCanvasAgent.h:
(WebCore):
(WebCore::InspectorCanvasAgent::create):
(InspectorCanvasAgent):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
LayoutTests:
Stub Canvas dispatcher for now to silence alerts in tests.
- inspector/profiler/canvas-profiler-test.js:
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent.InspectorBackend.registerCanvasDispatcher):
- 4:34 AM Changeset in webkit [141097] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Qt] Fix the JSC build on Mac
Unreviewed, build fix.
- heap/HeapTimer.h:
Qt on Mac has USE(CF) true, and should use the CF HeapTimer in that case.
- 4:01 AM Changeset in webkit [141096] by
-
- 10 edits2 adds in trunk
[GTK] Implement resources API using injected bundle
https://bugs.webkit.org/show_bug.cgi?id=107457
Reviewed by Sam Weinig.
Source/WebKit2:
The ResourceLoaderClient was removed from the UI process in
r140285, and most of the GTK+ API depends on resources. This patch
implements the same API using the ResourceLoaderClient from
injected bundle. It fixes the resources unit tests, as well as
other 14 unit tests that are timing out because they depend on
resource API.
- GNUmakefile.list.am: Add new files to compilation.
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode): Add support for encoding
WebURLResponse and WebError objects in user messages.
(WebKit::UserMessageDecoder::baseDecode): Add support for decoding
WebURLResponse and WebError objects from user messages.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp: Added.
(didReceiveWebViewMessageFromInjectedBundle): Handle messages sent
to the WebView. For now it hanldes all the sresource loader client
messages.
(didReceiveMessageFromInjectedBundle): Handle messages received
from injected bundle.
(attachInjectedBundleClientToContext): Initialize the injected
bundle client.
- UIProcess/API/gtk/WebKitInjectedBundleClient.h: Added.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Add a HashMap to map page IDs to
WebKitWebViews.
(createDefaultWebContext): Call
attachInjectedBundleClientToContext() to intialize the injected
bundle client.
(webkitWebContextCreatePageForWebView): Use
webkitWebViewBaseCreateWebPage() to create and initialize a new
WebPageProxy and map the newly created page with the given
WebKitWebView.
(webkitWebContextWebViewDestroyed): Called when the given
WebKitWebView is being destroyed to remove it from the views map.
(webkitWebContextGetWebViewForPage): Returns the WebKitWebView
associated to the given page ID.
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Use
webkitWebContextCreatePageForWebView() instead of
webkitWebViewBaseCreateWebPage() directly.
(webkitWebViewDispose): Call webkitWebContextWebViewDestroyed() to
notify the context.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(didInitiateLoadForResource): Send a message to the UI process
with the callback parameters encoded.
(willSendRequestForFrame): Ditto.
(didReceiveResponseForResource): Ditto.
(didReceiveContentLengthForResource): Ditto.
(didFinishLoadForResource): Ditto.
(didFailLoadForResource): Ditto.
(webkitWebPageCreate): Initialize the
WKBundlePageResourceLoadClient.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unksip resources unit tests.
- 3:58 AM Changeset in webkit [141095] by
-
- 2 edits in trunk/Tools
Unreviewed, updated my email information.
- Scripts/webkitpy/common/config/committers.py:
- 3:55 AM Changeset in webkit [141094] by
-
- 3 edits2 adds in trunk
Web Inspector: [CPU Profile] Taking profile crashes renderer.
https://bugs.webkit.org/show_bug.cgi?id=108072
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-29
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/profiler/cpu-profiler-agent-crash-on-start.html
Fixed null-pointer access.
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start): Fixed null-pointer access.
(WebCore::ScriptProfiler::stop): Ditto.
LayoutTests:
Added test to check that ProfilerAgent start/stop doesn't crash.
- inspector/profiler/cpu-profiler-agent-crash-on-start-expected.txt: Added.
- inspector/profiler/cpu-profiler-agent-crash-on-start.html: Added.
- 3:36 AM Changeset in webkit [141093] by
-
- 5 edits4 adds in trunk
REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style
https://bugs.webkit.org/show_bug.cgi?id=105672
Reviewed by Andreas Kling.
Source/WebCore:
Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits
were not set due to sharing of styles between cousin elements.
This patch fixes the issue by not sharing styles from children with parents who prevent sharing.
Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html
fast/selectors/cousin-stylesharing-last-child-selector.html
- css/StyleResolver.cpp:
(WebCore::parentElementPreventsSharing):
(WebCore::StyleResolver::locateCousinList):
- dom/Element.cpp:
(WebCore::Element::hasFlagsSetDuringStylingOfChildren):
- dom/Element.h:
(Element):
LayoutTests:
Two test cases by Philippe Wittenbergh that triggers the issue.
- fast/selectors/cousin-stylesharing-adjacent-selector-expected.html: Added.
- fast/selectors/cousin-stylesharing-adjacent-selector.html: Added.
- fast/selectors/cousin-stylesharing-last-child-selector-expected.html: Added.
- fast/selectors/cousin-stylesharing-last-child-selector.html: Added.
- 3:32 AM Changeset in webkit [141092] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Remove misspelled ENABLE(SPEECH_INPUT) guard
https://bugs.webkit.org/show_bug.cgi?id=105683
Patch by Laszlo Gombos <Laszlo Gombos> on 2013-01-29
Reviewed by Simon Hausmann.
The ENABLE(SPEECH_INPUT) guard is only used in one location
in the source tree and as such it is always 0.
I believe that this guard is a left over and is not needed any more
as the code guarded is not guarded anywhere else.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- 3:08 AM Changeset in webkit [141091] by
-
- 3 edits2 adds in trunk
Web Inspector: [Regression] Search across all sources is broken.
https://bugs.webkit.org/show_bug.cgi?id=108157
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/search/scripts-search-scope.html
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
LayoutTests:
- http/tests/inspector/search/scripts-search-scope-expected.txt: Added.
- http/tests/inspector/search/scripts-search-scope.html: Added.
- 3:06 AM Changeset in webkit [141090] by
-
- 5 edits in trunk/Source/WebCore
IDBFactory::webkitGetDatabaseNames should raise DOMExceptions.
https://bugs.webkit.org/show_bug.cgi?id=108154
Reviewed by Jochen Eisinger.
In order to properly support blocking third-party IndexedDB usage,
open(), getDatabaseNames(), and deleteDatabase() should all throw
SECURITY_ERR when used in a blocked third-party context. That's possible
now for open() and deleteDatabase(), but getDatabaseNames() can't
currently raise exceptions.
This patch adjusts the IDL file and implementation. No exceptions are
currently thrown, but that will change as soon as wkbug.com/94171 lands.
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
- Modules/indexeddb/IDBFactory.h:
(IDBFactory):
- Modules/indexeddb/IDBFactory.idl:
Add "raises (DOMException)" to getDatabaseNames, and adjust the
implementation to match.
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
Pass in an ExceptionCode when calling getDatabaseNames, and handle
possible exceptions.
- 2:51 AM Changeset in webkit [141089] by
-
- 5 edits in trunk/Source/JavaScriptCore
[Qt] Implement IncrementalSweeper and HeapTimer
https://bugs.webkit.org/show_bug.cgi?id=103996
Reviewed by Simon Hausmann.
Implements the incremental sweeping garbage collection for the Qt platform.
- heap/HeapTimer.cpp:
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::timerEvent):
(JSC::HeapTimer::synchronize):
(JSC::HeapTimer::invalidate):
(JSC::HeapTimer::didStartVMShutdown):
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::scheduleTimer):
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- 2:15 AM Changeset in webkit [141088] by
-
- 2 edits in trunk/Source/WebCore
Revert an accidentally changed line of EventHander::handleMousePressEvent(PlatformMouseEvent&) in r135650.
https://bugs.webkit.org/show_bug.cgi?id=108165
Reviewed by Hajime Morita.
No new tests.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
- 2:01 AM Changeset in webkit [141087] by
-
- 1 edit78 deletes in trunk/LayoutTests
Unreviewed, rolling out r140959 and r140977.
http://trac.webkit.org/changeset/140959
http://trac.webkit.org/changeset/140977
https://bugs.webkit.org/show_bug.cgi?id=108171
Reverting rebaseline because after r141067 the expected
results should be the old values. (Requested by kadam on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
- platform/qt-5.0-wk1/compositing/absolute-inside-out-of-view-fixed-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/bounds-in-flipped-writing-mode-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/clip-child-by-non-stacking-ancestor-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-clipped-composited-child-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/clip-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/clip-inside-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/composited-in-columns-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/geometry/foreground-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/become-composited-nested-iframes-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/iframe-resize-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-iframe-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/overlapped-nested-iframes-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/iframes/scrolling-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/animation-overlap-with-children-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/fixed-position-under-transform-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-clipping-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-animation-container-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/masks/mask-layer-size-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/repaint/resize-repaint-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/backface-preserve-3d-tiled-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/huge-layer-img-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-clamped-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/tiling/tiled-layer-resize-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.png: Removed.
- platform/qt-5.0-wk1/compositing/visibility/layer-visible-content-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Removed.
- platform/qt-5.0-wk1/css3/filters/composited-during-transition-layertree-expected.txt: Removed.
- platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.png: Removed.
- platform/qt-5.0-wk1/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
- 2:01 AM Changeset in webkit [141086] by
-
- 32 edits in trunk/Source/WebCore
FeatureObserver: Input types are counted unexpectedly in a page with Modernizr
https://bugs.webkit.org/show_bug.cgi?id=108141
Reviewed by Kentaro Hara.
We don't want to record input type instantiation by Modernizr. Modernizr
creates input elements with these types, append it to document.body, and
render it with visibility:hidden. So, we record input types only when
they are attached without visibility:hidden.
No new tests. FeatureObserver is not testable by layout test.
- html/InputType.cpp:
(WebCore::InputType::create): Remove FeatureObserver::observe
callsites. They are moved to TextInputType::attach.
(WebCore::InputType::observeFeatureIfVisible):
Added. A helper for attach().
- html/InputType.h:
(InputType): Add observeFeatureIfVisible.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::create):
Remove a FeatureObserver::observe callsite.
(WebCore::ColorInputType::attach):
Calls FetureObserver through InputType::observeFeatureIfVisible.
- html/ColorInputType.h:
(ColorInputType): Declare attach.
- html/DateInputType.cpp: Ditto.
- html/DateInputType.h: Ditto.
- html/DateTimeInputType.cpp: Ditto.
- html/DateTimeInputType.h: Ditto.
- html/DateTimeLocalInputType.cpp: Ditto.
- html/DateTimeLocalInputType.h: Ditto.
- html/MonthInputType.cpp: Ditto.
- html/MonthInputType.h: Ditto.
- html/RangeInputType.cpp: Ditt
- html/RangeInputType.h: Ditto.
- html/TimeInputType.cpp: Ditto.
- html/TimeInputType.h: Ditto.
- html/WeekInputType.cpp: Ditto.
- html/WeekInputType.h: Ditto.
- html/TextFieldInputType.h:
(TextFieldInputType):
Make attach protected in order that sub classes can call it.
- html/EmailInputType.cpp:
(WebCore::EmailInputType::create):
Remove a FeatureObserver::observe callsite.
(WebCore::EmailInputType::attach): Calls FetureObserver through
InputType::observeFeatureIfVisible after TextFieldInptuType::attach.
- html/EmailInputType.h:
(EmailInputType):Declare attach.
- html/NumberInputType.cpp: Ditto.
- html/NumberInputType.h: Ditto.
- html/SearchInputType.cpp: Ditto.
- html/SearchInputType.h: Ditto.
- html/TelephoneInputType.cpp: Ditto.
- html/TelephoneInputType.h: Ditto.
- html/URLInputType.cpp: Ditto.
- html/URLInputType.h: Ditto.
- html/TextInputType.cpp:
(WebCore::TextInputType::attach):
Move the code for type fallback from InputType::create.
- html/TextInputType.h:
(TextInputType): Declare attach.
- 1:41 AM Changeset in webkit [141085] by
-
- 2 edits in trunk/Source/WebCore
[Qt][WK1] Reflect recursion limit and loop checks also for list conversions.
https://bugs.webkit.org/show_bug.cgi?id=107950
Reviewed by Allan Sandfeld Jensen.
No new tests, bugfix, no behavioral change.
Make conversions from Javascript values to QLists take the maximum
recursion depth into consideration and check for objects that were
already visited. Otherwise, the conversion may recurse until the
stack is full and then cause a segmentation fault.
- bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertToList):
(JSC::Bindings::convertValueToQVariant):
- 1:37 AM Changeset in webkit [141084] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Added failure/flaky crash expectations for two layout tests.
- platform/gtk/fast/js/regress: Added.
- platform/gtk/fast/js/regress/integer-modulo-expected.txt: Added the baseline after r141031.
- 1:35 AM Changeset in webkit [141083] by
-
- 4 edits in trunk/Source/WebCore
Clean up interface to ElementShadow
https://bugs.webkit.org/show_bug.cgi?id=108158
Reviewed by Hajime Morita.
Lots of general clean up to ElementShadow removing unused headers,
adding a create() method that returns a PassOwnPtr, adding missing const,
and moving short inline methods into the class definition so it's easier
to understand what methods do what.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::ensureShadow):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::childNeedsStyleRecalc):
(WebCore::ElementShadow::needsStyleRecalc):
- dom/ElementShadow.h:
(WebCore::ElementShadow::create):
(ElementShadow):
(WebCore::ElementShadow::~ElementShadow):
(WebCore::ElementShadow::youngestShadowRoot):
(WebCore::ElementShadow::oldestShadowRoot):
(WebCore::ElementShadow::distributor):
(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::containingShadow):
- 1:30 AM Changeset in webkit [141082] by
-
- 10 edits2 deletes in trunk/Tools
[chromium] delete DRTTestRunner
https://bugs.webkit.org/show_bug.cgi?id=108082
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
- DumpRenderTree/chromium/DRTTestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::testFinished):
(WebTestRunner::WebTestDelegate::testTimedOut):
(WebTestRunner::WebTestDelegate::isBeingDebugged):
(WebTestRunner::WebTestDelegate::layoutTestTimeout):
(WebTestRunner::WebTestDelegate::closeRemainingWindows):
(WebTestRunner::WebTestDelegate::navigationEntryCount):
(WebTestRunner::WebTestDelegate::windowCount):
(WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
(WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
(WebTestRunner::WebTestDelegate::goToOffset):
(WebTestRunner::WebTestDelegate::reload):
(WebTestRunner::WebTestDelegate::loadURLForFrame):
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
(WebTestRunner):
(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::shouldInterceptPostMessage):
(WebTestRunner::TestRunner::waitUntilDone):
(WebTestRunner::TestRunner::notifyDone):
(WebTestRunner::TestRunner::completeNotifyDone):
(WorkItemBackForward):
(WebTestRunner::WorkItemBackForward::WorkItemBackForward):
(WebTestRunner::WorkItemBackForward::run):
(WebTestRunner::TestRunner::queueBackNavigation):
(WebTestRunner::TestRunner::queueForwardNavigation):
(WorkItemReload):
(WebTestRunner::WorkItemReload::run):
(WebTestRunner::TestRunner::queueReload):
(WorkItemLoadingScript):
(WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
(WebTestRunner::WorkItemLoadingScript::run):
(WorkItemNonLoadingScript):
(WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
(WebTestRunner::WorkItemNonLoadingScript::run):
(WebTestRunner::TestRunner::queueLoadingScript):
(WebTestRunner::TestRunner::queueNonLoadingScript):
(WorkItemLoad):
(WebTestRunner::WorkItemLoad::WorkItemLoad):
(WebTestRunner::WorkItemLoad::run):
(WebTestRunner::TestRunner::queueLoad):
(WorkItemLoadHTMLString):
(WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WebTestRunner::WorkItemLoadHTMLString::run):
(WebTestRunner::TestRunner::queueLoadHTMLString):
(WebTestRunner::TestRunner::locationChangeDone):
(WebTestRunner::TestRunner::windowCount):
(WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
(WebTestRunner::TestRunner::setCustomPolicyDelegate):
(WebTestRunner::TestRunner::waitForPolicyDelegate):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
(WorkItem):
(WebTestRunner::TestRunner::WorkItem::~WorkItem):
(WorkQueue):
(WebTestRunner::TestRunner::WorkQueue::WorkQueue):
(WebTestRunner::TestRunner::WorkQueue::setFrozen):
(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(WebTestRunner::TestRunner::WorkQueue::taskList):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::runFileTest):
(TestShell::loadURL):
(TestShell::createNewWindow):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::testRunner):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::testFinished):
(WebViewHost::testTimedOut):
(WebViewHost::isBeingDebugged):
(WebViewHost::layoutTestTimeout):
(WebViewHost::closeRemainingWindows):
(WebViewHost::navigationEntryCount):
(WebViewHost::windowCount):
(WebViewHost::setCustomPolicyDelegate):
(WebViewHost::waitForPolicyDelegate):
(WebViewHost::goToOffset):
(WebViewHost::reload):
(WebViewHost::loadURLForFrame):
(WebViewHost::shutdown):
(WebViewHost::testRunner):
- DumpRenderTree/chromium/WebViewHost.h:
(WebTestRunner):
(WebViewHost):
- 1:21 AM Changeset in webkit [141081] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disabling WebFrameTest.DisambiguationPopupMobileSite because WebFrameTest is still failing after r141073.
Unreviewed. Gardening.
- tests/WebFrameTest.cpp:
- 1:16 AM Changeset in webkit [141080] by
-
- 3 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r141064.
http://trac.webkit.org/changeset/141064
https://bugs.webkit.org/show_bug.cgi?id=108166
[Chromium] WebFrameTest.DivScrollIntoEditableTest is failing
on WinXP. (Requested by keishi on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-29
- tests/WebFrameTest.cpp:
- tests/data/get_scale_for_zoom_into_editable_test.html:
- 12:58 AM Changeset in webkit [141079] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix after r141024.
Adding new files to the build.
- GNUmakefile.am:
- GNUmakefile.list.am:
- 12:55 AM Changeset in webkit [141078] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Fix unused parameter build warning
https://bugs.webkit.org/show_bug.cgi?id=108156
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-01-29
Reviewed by Kentaro Hara.
Comment out the unused parameters to fix the build warnings.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/PluginProxy.h:
- 12:51 AM Changeset in webkit [141077] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Marking icon-0colors.html as crashing.
Unreviewed. Gardening.
- platform/chromium/TestExpectations:
- 12:39 AM Changeset in webkit [141076] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 140928
[chromium] add missing plumbing for Notification.requestPermission
https://bugs.webkit.org/show_bug.cgi?id=108012
Reviewed by Adam Barth.
Source/WebKit/chromium:
- src/NotificationPresenterImpl.cpp:
(WebKit):
(WebKit::VoidCallbackClient::VoidCallbackClient):
(NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::NotificationPermissionCallbackClient):
(WebKit::NotificationPermissionCallbackClient::permissionRequestComplete):
(WebKit::NotificationPermissionCallbackClient::~NotificationPermissionCallbackClient):
(WebKit::NotificationPresenterImpl::requestPermission):
- src/NotificationPresenterImpl.h:
(NotificationPresenterImpl):
LayoutTests:
- fast/notifications/notifications-constructor-request-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-request-permission.html: Added.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12086041
- 12:33 AM Changeset in webkit [141075] by
-
- 3 edits in trunk/Source/WebCore
Store ShadowRootType inside the bitfield
https://bugs.webkit.org/show_bug.cgi?id=108147
Reviewed by Dimitri Glazkov.
We can simplify the interface to ShadowRoot by storing the enum value of
ShadowRootType inside the bitfield like we do in the rest of WebCore.
No new tests, just refactoring.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::create):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::type):
(ShadowRoot):
- 12:31 AM Changeset in webkit [141074] by
-
- 2 edits1 delete in branches/chromium/1364
Merge 139616
Web Inspector: Audit Tool's False Positive on Set-Cookie header
https://bugs.webkit.org/show_bug.cgi?id=106794
Reviewed by Pavel Feldman.
Source/WebCore:
Header value is now returned as undefined if there is no such header as it was before regression.
Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html
- inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype._headerValue):
LayoutTests:
- http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
- http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
- http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
TBR=vsevik@chromium.org
BUG=169771
Review URL: https://codereview.chromium.org/12089042
- 12:30 AM Changeset in webkit [141073] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Disabling WebFrameTest.DisambiguationPopup because it is failing.
Unreviewed. Gardening.
- tests/WebFrameTest.cpp:
- 12:25 AM Changeset in webkit [141072] by
-
- 1 edit4 copies in branches/chromium/1364
Merge 140927
Check notification permissions in the show() method
https://bugs.webkit.org/show_bug.cgi?id=108009
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/notifications/notifications-constructor-with-permission.html
fast/notifications/notifications-constructor-without-permission.html
- Modules/notifications/Notification.cpp:
(WebCore::Notification::show):
(WebCore::Notification::taskTimerFired):
LayoutTests:
- fast/notifications/notifications-constructor-with-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-with-permission.html: Added.
- fast/notifications/notifications-constructor-without-permission-expected.txt: Added.
- fast/notifications/notifications-constructor-without-permission.html: Added.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/12087048
- 12:18 AM Changeset in webkit [141071] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r141070): Broke debug build
https://bugs.webkit.org/show_bug.cgi?id=108159
Unreviewed build fix.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
- 12:01 AM Changeset in webkit [141070] by
-
- 7 edits in trunk/Source/WebCore
HTMLDocumentParser should hold the HTMLToken using an OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=107762
Reviewed by Eric Seidel.
Using an OwnPtr will let us detach the HTMLToken from the
HTMLDocumentParser and send it to the BackgroundHTMLParser for further
processing.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/CompactHTMLToken.h:
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- 12:01 AM Changeset in webkit [141069] by
-
- 63 edits9 adds in trunk/Source/JavaScriptCore
DFG should not use a graph that is a vector, Nodes shouldn't move after allocation, and we should always refer to nodes by Node*
https://bugs.webkit.org/show_bug.cgi?id=106868
Reviewed by Oliver Hunt.
This adds a pool allocator for Nodes, and uses that instead of a Vector. Changes all
uses of Node& and NodeIndex to be simply Node*. Nodes no longer have an index except
for debugging (Node::index(), which is not guaranteed to be O(1)).
1% speed-up on SunSpider, presumably because this improves compile times.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/DataFormat.h:
(JSC::dataFormatToString):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::booleanResult):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
(JSC::DFG::AbstractState::dump):
- dfg/DFGAbstractState.h:
(DFG):
(JSC::DFG::AbstractState::forNode):
(AbstractState):
(JSC::DFG::AbstractState::speculateInt32Unary):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):
(JSC::DFG::AbstractState::trySetConstant):
- dfg/DFGAbstractValue.h:
(AbstractValue):
- dfg/DFGAdjacencyList.h:
(JSC::DFG::AdjacencyList::AdjacencyList):
(JSC::DFG::AdjacencyList::initialize):
- dfg/DFGAllocator.h: Added.
(DFG):
(Allocator):
(JSC::DFG::Allocator::Region::size):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::Allocator::Region::regionFor):
(Region):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::originalArrayStructure):
(JSC::DFG::ArrayMode::alreadyChecked):
- dfg/DFGArrayMode.h:
(ArrayMode):
- dfg/DFGArrayifySlowPathGenerator.h:
(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::node):
(JSC::DFG::BasicBlock::isInPhis):
(JSC::DFG::BasicBlock::isInBlock):
(BasicBlock):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setPair):
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::getToInt32):
(JSC::DFG::ByteCodeParser::toInt32):
(JSC::DFG::ByteCodeParser::getJSConstantForValue):
(JSC::DFG::ByteCodeParser::getJSConstant):
(JSC::DFG::ByteCodeParser::getCallee):
(JSC::DFG::ByteCodeParser::getThis):
(JSC::DFG::ByteCodeParser::setThis):
(JSC::DFG::ByteCodeParser::isJSConstant):
(JSC::DFG::ByteCodeParser::isInt32Constant):
(JSC::DFG::ByteCodeParser::valueOfJSConstant):
(JSC::DFG::ByteCodeParser::valueOfInt32Constant):
(JSC::DFG::ByteCodeParser::constantUndefined):
(JSC::DFG::ByteCodeParser::constantNull):
(JSC::DFG::ByteCodeParser::one):
(JSC::DFG::ByteCodeParser::constantNaN):
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::addVarArgChild):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::ConstantRecord::ConstantRecord):
(ConstantRecord):
(JSC::DFG::ByteCodeParser::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::setIntrinsicResult):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::dump):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::recordNewTarget):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::constantCSE):
(JSC::DFG::CSEPhase::weakConstantCSE):
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkFunctionElimination):
(JSC::DFG::CSEPhase::checkExecutableElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performSubstitution):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(CSEPhase):
- dfg/DFGCommon.cpp: Added.
(DFG):
(JSC::DFG::NodePointerTraits::dump):
- dfg/DFGCommon.h:
(DFG):
(JSC::DFG::NodePointerTraits::defaultValue):
(NodePointerTraits):
(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::shouldDumpGraphAtEachPhase):
(JSC::DFG::validationEnabled):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::isCapturedAtOrAfter):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::createDumpList):
(JSC::DFG::Disassembler::dumpDisassembly):
- dfg/DFGDisassembler.h:
(JSC::DFG::Disassembler::setForNode):
(Disassembler):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGEdge.cpp: Added.
(DFG):
(JSC::DFG::Edge::dump):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::Edge):
(JSC::DFG::Edge::node):
(JSC::DFG::Edge::operator*):
(JSC::DFG::Edge::operator->):
(Edge):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKind):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::isSet):
(JSC::DFG::Edge::shift):
(JSC::DFG::Edge::makeWord):
(JSC::DFG::operator==):
(JSC::DFG::operator!=):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(FixupPhase):
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::GenerationInfo):
(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(GenerationInfo):
(JSC::DFG::GenerationInfo::node):
(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(DFG):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::amountOfNodeWhiteSpace):
(JSC::DFG::Graph::printNodeWhiteSpace):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::refChildren):
(JSC::DFG::Graph::derefChildren):
(JSC::DFG::Graph::predictArgumentTypes):
(JSC::DFG::Graph::collectGarbage):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetExitStates):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
(JSC::DFG::Graph::changeChild):
(JSC::DFG::Graph::compareAndSwap):
(JSC::DFG::Graph::clearAndDerefChild):
(JSC::DFG::Graph::clearAndDerefChild1):
(JSC::DFG::Graph::clearAndDerefChild2):
(JSC::DFG::Graph::clearAndDerefChild3):
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::getJSConstantSpeculation):
(JSC::DFG::Graph::addSpeculationMode):
(JSC::DFG::Graph::valueAddSpeculationMode):
(JSC::DFG::Graph::arithAddSpeculationMode):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::mulShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isCellConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::isInternalFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::numSuccessors):
(JSC::DFG::Graph::successor):
(JSC::DFG::Graph::successorForCondition):
(JSC::DFG::Graph::isPredictedNumerical):
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
(JSC::DFG::Graph::varArgNumChildren):
(JSC::DFG::Graph::numChildren):
(JSC::DFG::Graph::varArgChild):
(JSC::DFG::Graph::child):
(JSC::DFG::Graph::voteNode):
(JSC::DFG::Graph::voteChildren):
(JSC::DFG::Graph::substitute):
(JSC::DFG::Graph::substituteGetLocal):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):
- dfg/DFGInsertionSet.h:
(JSC::DFG::Insertion::Insertion):
(JSC::DFG::Insertion::element):
(Insertion):
(JSC::DFG::InsertionSet::insert):
(InsertionSet):
- dfg/DFGJITCompiler.cpp:
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::setForNode):
(JSC::DFG::JITCompiler::addressOfDoubleConstant):
(JSC::DFG::JITCompiler::noticeOSREntry):
- dfg/DFGLongLivedState.cpp: Added.
(DFG):
(JSC::DFG::LongLivedState::LongLivedState):
(JSC::DFG::LongLivedState::~LongLivedState):
(JSC::DFG::LongLivedState::shrinkToFit):
- dfg/DFGLongLivedState.h: Added.
(DFG):
(LongLivedState):
- dfg/DFGMinifiedID.h:
(JSC::DFG::MinifiedID::MinifiedID):
(JSC::DFG::MinifiedID::node):
- dfg/DFGMinifiedNode.cpp:
(JSC::DFG::MinifiedNode::fromNode):
- dfg/DFGMinifiedNode.h:
(MinifiedNode):
- dfg/DFGNode.cpp: Added.
(DFG):
(JSC::DFG::Node::index):
(WTF):
(WTF::printInternal):
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::Node::Node):
(Node):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::shouldSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateIntegerForArithmetic):
(JSC::DFG::Node::shouldSpeculateIntegerExpectingDefined):
(JSC::DFG::Node::shouldSpeculateDoubleForArithmetic):
(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
(JSC::DFG::Node::shouldSpeculateFinalObject):
(JSC::DFG::Node::shouldSpeculateArray):
(JSC::DFG::Node::dumpChildren):
(WTF):
- dfg/DFGNodeAllocator.h: Added.
(DFG):
(operator new ):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
- dfg/DFGOSRExit.h:
(OSRExit):
(SpeculationFailureDebugInfo):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGPhase.cpp:
(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
- dfg/DFGPhase.h:
(Phase):
(JSC::DFG::runAndLog):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::setPrediction):
(JSC::DFG::PredictionPropagationPhase::mergePrediction):
(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::ScoreBoard):
(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::useIfHasResult):
(ScoreBoard):
- dfg/DFGSilentRegisterSavePlan.h:
(JSC::DFG::SilentRegisterSavePlan::SilentRegisterSavePlan):
(JSC::DFG::SilentRegisterSavePlan::node):
(SilentRegisterSavePlan):
- dfg/DFGSlowPathGenerator.h:
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
(JSC::DFG::SlowPathGenerator::generate):
(SlowPathGenerator):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentSavePlanForFPR):
(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::useChildren):
(JSC::DFG::SpeculativeJIT::isStrictInt32):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownNumeric):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotCell):
(JSC::DFG::SpeculativeJIT::isKnownNotInteger):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::FPRTemporary::FPRTemporary):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::noticeOSRBirth):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::compileNewFunctionNoCheck):
(JSC::DFG::SpeculativeJIT::compileNewFunctionExpression):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstantAsInt32):
(JSC::DFG::SpeculativeJIT::addressOfDoubleConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::isNullConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstantAsImm64):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::integerResult):
(JSC::DFG::SpeculativeJIT::noResult):
(JSC::DFG::SpeculativeJIT::cellResult):
(JSC::DFG::SpeculativeJIT::booleanResult):
(JSC::DFG::SpeculativeJIT::jsValueResult):
(JSC::DFG::SpeculativeJIT::storageResult):
(JSC::DFG::SpeculativeJIT::doubleResult):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::temporaryRegisterForPutByVal):
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
(JSC::DFG::SpeculativeJIT::setNodeForOperand):
(JSC::DFG::IntegerOperand::IntegerOperand):
(JSC::DFG::IntegerOperand::node):
(JSC::DFG::IntegerOperand::gpr):
(JSC::DFG::IntegerOperand::use):
(IntegerOperand):
(JSC::DFG::DoubleOperand::DoubleOperand):
(JSC::DFG::DoubleOperand::node):
(JSC::DFG::DoubleOperand::fpr):
(JSC::DFG::DoubleOperand::use):
(DoubleOperand):
(JSC::DFG::JSValueOperand::JSValueOperand):
(JSC::DFG::JSValueOperand::node):
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::JSValueOperand::fill):
(JSC::DFG::JSValueOperand::use):
(JSValueOperand):
(JSC::DFG::StorageOperand::StorageOperand):
(JSC::DFG::StorageOperand::node):
(JSC::DFG::StorageOperand::gpr):
(JSC::DFG::StorageOperand::use):
(StorageOperand):
(JSC::DFG::SpeculateIntegerOperand::SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::node):
(JSC::DFG::SpeculateIntegerOperand::gpr):
(JSC::DFG::SpeculateIntegerOperand::use):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateStrictInt32Operand::SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateStrictInt32Operand::node):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::use):
(SpeculateStrictInt32Operand):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::node):
(JSC::DFG::SpeculateDoubleOperand::fpr):
(JSC::DFG::SpeculateDoubleOperand::use):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::node):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
(SpeculateCellOperand):
(JSC::DFG::SpeculateBooleanOperand::SpeculateBooleanOperand):
(JSC::DFG::SpeculateBooleanOperand::node):
(JSC::DFG::SpeculateBooleanOperand::gpr):
(JSC::DFG::SpeculateBooleanOperand::use):
(SpeculateBooleanOperand):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeValueToInt32):
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntStrict):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compileValueAdd):
(JSC::DFG::SpeculativeJIT::compileNonStringCellOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitNonStringCellOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.h:
(StructureAbstractValue):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- dfg/DFGValidate.cpp:
(DFG):
(Validate):
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::reportValidationContext):
- dfg/DFGValidate.h:
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::ValueSource):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- runtime/FunctionExecutableDump.cpp: Added.
(JSC):
(JSC::FunctionExecutableDump::dump):
- runtime/FunctionExecutableDump.h: Added.
(JSC):
(FunctionExecutableDump):
(JSC::FunctionExecutableDump::FunctionExecutableDump):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSC):
(DFG):
(JSGlobalData):
- runtime/Options.h:
(JSC):
